1 2012-05-02 Jim Meyering <meyering@redhat.com>
3 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5 2012-04-29 Eli Zaretskii <eliz@gnu.org>
7 * xdisp.c (pos_visible_p): If already at a newline from the
8 display string before the 'while' loop, don't walk back the glyphs
9 from it3.glyph_row. Solves assertion violation when the display
10 string begins with a newline (egg.el). (Bug#11367)
12 2012-04-24 Chong Yidong <cyd@gnu.org>
14 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
16 2012-04-23 Eli Zaretskii <eliz@gnu.org>
18 * xdisp.c (pos_visible_p): If the window start position is beyond
19 ZV, start the display from buffer beginning. Prevents assertion
20 violation in init_iterator when the minibuffer window is scrolled
23 * window.c (window_scroll_pixel_based): Likewise.
25 2012-04-23 Chong Yidong <cyd@gnu.org>
27 * keymap.c (where_is_internal): Doc fix (Bug#10872).
29 2012-04-20 Glenn Morris <rgm@gnu.org>
31 * fileio.c (Fcopy_file, Fset_file_selinux_context):
32 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
34 2012-04-20 Eli Zaretskii <eliz@gnu.org>
36 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
37 overrun array limits of glyph row's used[] array. (Bug#11288)
39 2012-04-20 Chong Yidong <cyd@gnu.org>
41 * process.c (wait_reading_process_output): If EIO occurs on a pty,
42 set the status to "failed" and ensure that sentinel is run.
44 2012-04-18 Glenn Morris <rgm@gnu.org>
46 * process.c (Fset_process_inherit_coding_system_flag)
47 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
48 (Fmake_network_process, Fmake_serial_process): Doc fix.
50 2012-04-17 Eli Zaretskii <eliz@gnu.org>
52 * xdisp.c (string_buffer_position_lim): Limit starting position to
54 (set_cursor_from_row): If called for a mode-line or header-line
55 row, return zero immediately.
56 (try_cursor_movement): If inside continuation line, don't back up
57 farther than the first row after the header line, if any. Don't
58 consider the header-line row as "partially visible", even if
59 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
61 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
63 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
65 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
67 * process.c (make_process):
68 * process.h: Add integer `gnutls_handshakes_tried' member to
71 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
72 Add convenience `GNUTLS_LOG2i' macro.
74 * gnutls.c (gnutls_log_function2i): Convenience log function.
75 (emacs_gnutls_read): Use new log functions,
76 `gnutls_handshakes_tried' process member, and
77 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
78 attempts per process (connection).
80 2012-04-09 Eli Zaretskii <eliz@gnu.org>
82 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
83 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
85 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
87 * nsterm.m (constrainFrameRect): Always constrain when there is only
88 one screen (Bug#10962).
90 2012-04-06 Eli Zaretskii <eliz@gnu.org>
92 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
93 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
94 about subtle differences between FETCH_CHAR* and STRING_CHAR*
95 macros related to unification of CJK characters. For the details,
96 see the discussion following the message here:
97 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
99 2012-04-04 Chong Yidong <cyd@gnu.org>
101 * keyboard.c (Vdelayed_warnings_list): Doc fix.
103 2012-04-01 Eli Zaretskii <eliz@gnu.org>
105 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
106 instead of alloca. (Bug#11138)
108 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
110 * w32menu.c (is_simple_dialog): Properly check lisp types.
113 2012-03-31 Eli Zaretskii <eliz@gnu.org>
115 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
116 position we get to after a call to move_it_to fails the
117 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
118 only if we wind up in a string from display property. (Bug#11063)
120 * window.c (Fdelete_other_windows_internal): Invalidate the row
121 and column information about mouse highlight, so that redisplay
122 restores it after reallocating the glyph matrices. (Bug#7464)
124 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
125 string comes from a `display' text property, use the buffer
126 position of that property as if we actually saw that position in
128 (move_it_by_lines): Remove the assertion that
129 "it->current_x == 0 && it->hpos == 0" which can be legitimately
130 violated when there's a before-string at the beginning of a line.
133 2012-03-30 Eli Zaretskii <eliz@gnu.org>
135 * xdisp.c (append_space_for_newline): If the default face was
136 remapped, use the remapped face for the appended newline.
137 (extend_face_to_end_of_line): Use the remapped default face for
138 extending the face to the end of the line.
139 (display_line): Call extend_face_to_end_of_line when the default
140 face was remapped. (Bug#11068)
142 2012-03-29 Eli Zaretskii <eliz@gnu.org>
144 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
146 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
148 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
150 2012-03-27 Glenn Morris <rgm@gnu.org>
152 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
155 2012-03-26 Kenichi Handa <handa@m17n.org>
157 * dispextern.h (struct glyph): Fix previous change. Change the
158 bit length of glyphless.ch to 25 (Bug#11082).
160 2012-03-26 Chong Yidong <cyd@gnu.org>
162 * keyboard.c (Vselection_inhibit_update_commands): New variable.
163 (command_loop_1): Use it; inhibit selection update for
164 handle-select-window too (Bug#8996).
166 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
168 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
170 2012-03-25 Kenichi Handa <handa@m17n.org>
172 * dispextern.h (struct glyph): Change the bit length of
173 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
175 2012-03-24 Eli Zaretskii <eliz@gnu.org>
177 * s/ms-w32.h (tzname): Include time.h before redirecting to
178 _tzname. Fixes the MSVC build. (Bug#9960)
180 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
182 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
185 * xterm.c (XTread_socket): Only modify handling_signal if
186 !SYNC_INPUT. (Bug#11080)
188 2012-03-23 Eli Zaretskii <eliz@gnu.org>
190 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
191 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
192 when fetching a multibyte character consumes more bytes than
193 CHAR_BYTES returns, due to unification of CJK characters in
194 string_char. (Bug#11073)
196 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
198 * process.c (wait_reading_process_output): Handle pty disconnect
199 by refraining from sending oneself a SIGCHLD (bug#10933).
201 2012-03-22 Chong Yidong <cyd@gnu.org>
203 * dispextern.h (struct it): New member string_from_prefix_prop_p.
205 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
206 Mark string as coming from a prefix property.
207 (handle_face_prop): Use default face for prefix strings (Bug#4281).
208 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
210 2012-03-21 Chong Yidong <cyd@gnu.org>
212 * xfaces.c (Vface_remapping_alist): Doc fix.
214 2012-03-20 Eli Zaretskii <eliz@gnu.org>
216 * w32proc.c (Fw32_set_console_codepage)
217 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
220 2012-03-20 Chong Yidong <cyd@gnu.org>
222 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
223 to reflect default non-nil value of redisplay-dont-pause.
225 2012-03-19 Kenichi Handa <handa@m17n.org>
227 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
228 it fit in a valid range (Bug#11003).
230 2012-03-18 Eli Zaretskii <eliz@gnu.org>
232 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
233 that is not from display property, accept the row as a "cursor
234 row" if one of the string's character has a non-nil `cursor'
235 property. Fixes cursor positioning when there are newlines in
236 overlay strings, e.g. in icomplete.el. (Bug#11035)
238 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
240 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
242 2012-03-12 Chong Yidong <cyd@gnu.org>
244 * eval.c (inhibit_lisp_code): Rename from
245 inhibit_window_configuration_change_hook; move from window.c.
247 * xfns.c (unwind_create_frame_1, Fx_create_frame):
248 * window.c (run_window_configuration_change_hook)
249 (syms_of_window): Callers changed.
251 2012-03-11 Chong Yidong <cyd@gnu.org>
253 * keymap.c (Fkey_description): Doc fix (Bug#9700).
255 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
257 2012-03-10 Chong Yidong <cyd@gnu.org>
259 * frame.c (other_visible_frames): Don't assume the selected frame
260 is visible (Bug#10955).
262 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
264 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
266 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
268 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
269 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
272 2012-03-03 Glenn Morris <rgm@gnu.org>
274 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
276 2012-03-02 Eli Zaretskii <eliz@gnu.org>
278 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
279 position past the first glyph_row that ends at ZV. (Bug#10902)
280 (redisplay_window, next_element_from_string): Fix typos in
282 (redisplay_window): Pass to move_it_vertically the margin in
283 pixels, not in screen lines.
285 2012-03-02 Glenn Morris <rgm@gnu.org>
287 * buffer.c (buffer-list-update-hook): Doc fix.
289 2012-02-29 Eli Zaretskii <eliz@gnu.org>
291 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
292 push_it before setting up the iterator for the first overlay
293 string, even if we have an empty string loaded.
294 (next_overlay_string): If there's an empty string on the iterator
295 stack, pop the stack. (Bug#10903)
297 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
299 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
300 Suggested by Stefan Monnier in
301 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
302 * alloc.c (widen_to_Lisp_Object): New static function.
303 (mark_memory): Also mark Lisp_Objects by fetching pointer words
304 and widening them to Lisp_Objects. This would work even if
305 USE_LSB_TAG is defined and wide integers are used, which might
306 happen in a future version of Emacs.
308 2012-02-25 Chong Yidong <cyd@gnu.org>
310 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
313 * xselect.c (Fx_selection_exists_p): Doc fix.
314 (x_clipboard_manager_save_all): Print an informative message
315 before saving to clipboard manager.
317 2012-02-24 Chong Yidong <cyd@gnu.org>
319 * keyboard.c (process_special_events): Handle all X selection
320 requests in kbd_buffer, not just the next one (Bug#8869).
322 2012-02-23 Chong Yidong <cyd@gnu.org>
324 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
325 call when setting menu-bar-lines and tool-bar-lines parameters.
326 (unwind_create_frame_1): New helper function.
328 * window.c (inhibit_window_configuration_change_hook): New var.
329 (run_window_configuration_change_hook): Obey it.
330 (syms_of_window): Initialize it.
332 2012-02-22 Chong Yidong <cyd@gnu.org>
334 * xterm.c (x_draw_image_relief): Add missing type check for
335 Vtool_bar_button_margin (Bug#10743).
337 2012-02-21 Chong Yidong <cyd@gnu.org>
339 * fileio.c (Vfile_name_handler_alist): Doc fix.
341 * buffer.c (Fget_file_buffer): Protect against invalid file
342 handler return value.
344 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
346 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
347 when computing $valmask.
349 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
350 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
351 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
352 It's useless in that case, and it can cause problems on hosts
353 that allocate halves of EMACS_INT values separately.
354 Reported by Dan Horák. Diagnosed by Andreas Schwab in
355 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
356 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
357 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
358 it avoids undefined behavior on hosts where shifting right by more
359 than the word width has undefined behavior.
361 2012-02-19 Chong Yidong <cyd@gnu.org>
363 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
364 (Funhandled_file_name_directory, Ffile_name_as_directory)
365 (Fdirectory_file_name, Fexpand_file_name)
366 (Fsubstitute_in_file_name): Protect against invalid file handler
367 return values (Bug#10845).
369 2012-02-18 Eli Zaretskii <eliz@gnu.org>
371 * .gdbinit (pitx): Fix incorrect references to fields of the
374 2012-02-17 Chong Yidong <cyd@gnu.org>
376 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
378 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
380 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
381 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
383 2012-02-15 Chong Yidong <cyd@gnu.org>
385 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
386 marked as special. Also, starting docstrings with * is obsolete.
388 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
390 * gnutls.c (emacs_gnutls_write): Fix last change.
392 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
394 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
397 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
399 * keymap.c (Fsingle_key_description): Handle char ranges.
401 2012-02-12 Chong Yidong <cyd@gnu.org>
403 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
404 as that creates a dangerous corner case.
406 * window.c (Fdelete_window_internal): Invalidate the mouse
407 highlight (Bug#9904).
409 2012-02-12 Glenn Morris <rgm@gnu.org>
411 * xselect.c (Fx_own_selection_internal)
412 (Fx_get_selection_internal, Fx_disown_selection_internal)
413 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
414 * nsselect.m (Fx_own_selection_internal)
415 (Fx_disown_selection_internal, Fx_selection_exists_p)
416 (Fx_selection_owner_p, Fx_get_selection_internal):
417 Sync docs and argument specs with the xselect.c versions.
419 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
421 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
423 2012-02-11 Eli Zaretskii <eliz@gnu.org>
425 * w32select.c (Fx_selection_exists_p): Sync doc string and
426 argument list with xselect.c. (Bug#10783)
428 * w16select.c (Fx_selection_exists_p): Sync doc string and
429 argument list with xselect.c. (Bug#10783)
431 2012-02-10 Glenn Morris <rgm@gnu.org>
433 * fns.c (Fsecure_hash): Doc fix.
435 2012-02-09 Kenichi Handa <handa@m17n.org>
437 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
439 2012-02-07 Chong Yidong <cyd@gnu.org>
441 * buffer.c (Fbuffer_local_variables)
442 (buffer_lisp_local_variables): Handle unbound vars correctly;
443 don't let Qunbound leak into Lisp.
445 2012-02-07 Glenn Morris <rgm@gnu.org>
447 * image.c (Fimagemagick_types): Doc fix.
449 * image.c (imagemagick-render-type): Change it from a lisp object
450 to an integer. Move the doc here from the lisp manual.
451 Treat all values not equal to 0 the same.
453 2012-02-06 Chong Yidong <cyd@gnu.org>
455 * doc.c (store_function_docstring): Avoid applying docstring of
456 alias to base function (Bug#2603).
458 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
460 * .gdbinit (pp1, pv1): Remove redundant defines.
463 2012-02-04 Chong Yidong <cyd@gnu.org>
465 * nsterm.m: Declare a global (Bug#10694).
467 2012-02-04 Eli Zaretskii <eliz@gnu.org>
469 * w32.c (get_emacs_configuration_options):
470 Include --enable-checking, if specified, in the return value.
472 2012-02-04 Martin Rudalics <rudalics@gmx.at>
474 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
475 after rounding frame sizes. (Bug#9723)
477 2012-02-04 Eli Zaretskii <eliz@gnu.org>
479 * keyboard.c (adjust_point_for_property): Don't position point
480 before BEGV. (Bug#10696)
482 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
484 Handle overflow when computing char display width (Bug#9496).
485 * character.c (char_width): Return EMACS_INT, not int.
486 (char_width, c_string_width): Check for overflow when
487 computing the width; this is possible now that individual
488 characters can have unbounded width. Problem introduced
489 by merge from Emacs 23 on 2012-01-19.
491 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
493 * dbusbind.c (Fdbus_register_method): Mention the return value
494 :ignore in the docstring.
496 2012-02-02 Glenn Morris <rgm@gnu.org>
498 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
500 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
501 Unconditionally set to t. (Bug#10673)
502 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
503 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
504 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
506 2012-02-02 Kenichi Handa <handa@m17n.org>
508 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
509 0, do not call append_composite_glyph.
511 2012-02-02 Kenichi Handa <handa@m17n.org>
513 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
515 (x_produce_glyphs): If the component of a composition is a null
516 string, set it->pixel_width to 1 to avoid zero-width glyph.
518 2012-02-01 Eli Zaretskii <eliz@gnu.org>
520 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
521 first 2 arguments are identical. This makes inserting large
522 output from a subprocess an order of magnitude faster on
523 MS-Windows, where all sbrk'ed memory is always contiguous.
525 2012-01-31 Glenn Morris <rgm@gnu.org>
527 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
528 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
529 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
531 2012-01-29 Glenn Morris <rgm@gnu.org>
533 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
535 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
537 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
539 2012-01-28 Chong Yidong <cyd@gnu.org>
541 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
543 2012-01-26 Chong Yidong <cyd@gnu.org>
545 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
547 * search.c (Fsearch_forward, Fsearch_backward): Document negative
548 repeat counts (Bug#10507).
550 2012-01-26 Glenn Morris <rgm@gnu.org>
552 * lread.c (syms_of_lread): Doc fix.
554 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
556 * coding.c (encode_designation_at_bol): Change return value to
559 2012-01-25 Chong Yidong <cyd@gnu.org>
561 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
563 2012-01-21 Chong Yidong <cyd@gnu.org>
565 * floatfns.c (Fcopysign): Make the second argument non-optional,
566 since nil is not allowed anyway.
568 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
570 * process.c (read_process_output): Use p instead of XPROCESS (proc).
571 (send_process): Likewise.
573 2012-01-19 Martin Rudalics <rudalics@gmx.at>
575 * window.c (save_window_save, Fcurrent_window_configuration)
576 (Vwindow_persistent_parameters): Do not use Qstate.
579 2012-01-19 Kenichi Handa <handa@m17n.org>
581 * character.c (char_width): New function.
582 (Fchar_width, c_string_width, lisp_string_width):
583 Use char_width (Bug#9496).
585 2012-01-16 Martin Rudalics <rudalics@gmx.at>
587 * window.c (Vwindow_persistent_parameters): New variable.
588 (Fset_window_configuration, save_window_save): Handle persistent
591 2012-01-14 Eli Zaretskii <eliz@gnu.org>
593 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
594 thrashing the stack of the thread. (Bug#9087)
596 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
598 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
600 2012-01-11 Eli Zaretskii <eliz@gnu.org>
602 * xdisp.c (rows_from_pos_range): Handle the case where the
603 highlight ends on a newline. (Bug#10464)
604 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
605 he end column for display of highlight that ends on a newline
608 2012-01-11 Glenn Morris <rgm@gnu.org>
610 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
611 from load-path also when installation-directory is nil. (Bug#10208)
613 2012-01-10 Glenn Morris <rgm@gnu.org>
615 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
617 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
618 Update template values to be closer to their typical values these days.
620 2012-01-09 Eli Zaretskii <eliz@gnu.org>
622 * xdisp.c (rows_from_pos_range): Accept additional argument
623 DISP_STRING, and accept any glyph in a row whose object is that
624 string as eligible for mouse highlight. Fixes mouse highlight of
625 display strings from overlays. (Bug#10464)
627 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
629 emacs: fix an auto-save permissions race condition (Bug#10400)
630 * fileio.c (auto_saving_dir_umask): New static var.
631 (Fmake_directory_internal): Use it.
632 (do_auto_save_make_dir): Set it, instead of invoking chmod after
633 creating the directory. The old code temporarily assigns
634 too-generous permissions to the directory.
635 (do_auto_save_eh): Clear it.
636 (Fdo_auto_save): Catch all errors, not just file errors, so
637 that the var is always cleared.
639 2012-01-07 Eli Zaretskii <eliz@gnu.org>
641 * search.c (scan_buffer): Pass character positions to
642 know_region_cache, not byte positions. (Bug#6540)
644 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
646 * w32.c (sys_rename): Report EXDEV when rename of a directory
647 fails because the target is on another logical disk. (Bug#10284)
649 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
651 * xterm.c (x_embed_request_focus): New function.
653 * xterm.h: Add prototype.
655 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
657 2012-01-05 Glenn Morris <rgm@gnu.org>
659 * emacs.c (emacs_copyright): Update short copyright year to 2012.
661 2012-01-01 Eli Zaretskii <eliz@gnu.org>
663 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
664 Load gnutls_transport_set_lowat only if GnuTLS version is below
666 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
667 GnuTLS versions below 2.11.1.
669 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
671 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
672 to the doc string advising against its use for altering the way
673 windows are scrolled.
675 2011-12-28 Kenichi Handa <handa@m17n.org>
677 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
678 coding-system ASCII compatible only when it does not produce BOM
679 on encoding (Bug#10383).
681 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
683 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
685 (create_and_show_popup_menu): Always use menu_position_func for
688 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
690 * callint.c (Fcall_interactively): Don't truncate prompt string.
692 2011-12-23 Eli Zaretskii <eliz@gnu.org>
694 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
695 property that ends at ZV, so that the bidi iteration could be
696 resumed from there (after widening). (Bug#10360)
698 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
700 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
702 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
704 * nsterm.m (x_free_frame_resources):
705 Release f->output_data.ns->miniimage.
706 (ns_index_color): Fix indentation. Do not retain
707 color_table->colors[i].
709 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
712 * nsfns.m (x_set_background_color): Assign return value from
713 ns_index_color to face-background instead of NSColor*.
714 (ns_implicitly_set_icon_type): Fix indentation.
715 Change assignment in for loop to comparison.
717 * emacs.c (ns_pool): New variable.
718 (main): Assign ns_pool.
719 (Fkill_emacs): Call ns_release_autorelease_pool.
721 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
722 autorelease fdesc, release fdAttrs and tdict.
723 (ns_get_covering_families): Release charset.
724 (ns_findfonts): Release NSFontDescriptor created with new.
725 (ns_uni_to_glyphs): Fix indentation.
726 (setString): Release attrStr before assigning new value.
728 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
730 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
732 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
733 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
735 2011-12-18 David Reitter <reitter@cmu.edu>
737 * nsterm.m (ns_term_init): Subscribe for notifications
738 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
739 to method trackingNotification in EmacsMenu.
741 * nsmenu.m (trackingMenu): New variable.
742 (trackingNotification): New method (from Aquamacs).
743 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
744 from Aquamacs (Bug#7030).
746 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
748 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
749 (symbol_to_nsstring): Fix indentation.
750 (ns_symbol_to_pb): New function.
751 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
752 (Fns_rotate_cut_buffers_internal): Remove.
753 (Fns_store_selection_internal): Rename from
754 Fns_store_cut_buffer_internal.
755 (ns_get_foreign_selection, Fx_own_selection_internal)
756 (Fx_disown_selection_internal, Fx_selection_exists_p)
757 (Fns_get_selection_internal, Fns_store_selection_internal):
758 Use ns_symbol_to_pb and check if return value is nil.
759 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
760 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
761 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
762 renamed to Sns_store_selection_internal.
763 (ns_handle_selection_request): Move code to Fx_own_selection_internal
764 and remove this function.
765 (ns_handle_selection_clear): Remove, never used.
766 (Fx_own_selection_internal): Move code from ns_handle_selection_request
769 2011-12-17 Ken Brown <kbrown@cornell.edu>
771 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
772 GID is unknown (Bug#10257).
774 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
776 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
777 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
778 which caused a build failure on GNU/Linux IA-64. This problem was
779 introduced by my 2011-10-07 patch.
781 2011-12-15 Juri Linkov <juri@jurta.org>
783 * image.c (imagemagick_error): New function. (Bug#10112)
784 (imagemagick_load_image): Comment out `MagickSetResolution' call.
785 Use `imagemagick_error' where ImageMagick functions return
787 (Fimagemagick_types): Add `Fnreverse' to return the list in the
790 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
792 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
793 fill background (Bug#8992).
795 2011-12-13 Martin Rudalics <rudalics@gmx.at>
797 * window.c (Vwindow_combination_resize)
798 (Vwindow_combination_limit): Use t instead of non-nil in
800 (Vrecenter_redisplay): Add first sentence of doc-string on
802 (Frecenter): Fix doc-string typo.
804 2011-12-11 Kenichi Handa <handa@m17n.org>
806 * coding.c (Funencodable_char_position): Pay attention to the
807 buffer text relocation (Bug#9389).
809 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
811 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
812 gtk_init (Bug#10100).
814 2011-12-10 Eli Zaretskii <eliz@gnu.org>
816 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
817 IT->string is nil. (Bug#10263)
819 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
821 * nsterm.h (x_free_frame_resources): Declare.
823 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
824 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
826 * nsterm.h (ns_get_defaults_value): Declare.
828 * nsterm.m (ns_default): Call ns_get_defaults_value.
830 2011-12-09 Eli Zaretskii <eliz@gnu.org>
832 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
835 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
837 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
838 that where the value of an _OBJC_* symbol points to is in the .bss
841 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
843 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
844 after the loop to call ccl_driver at least once (Bug#8619).
846 2011-12-08 Kenichi Handa <handa@m17n.org>
848 * ftfont.c (get_adstyle_property): Fix previous change
851 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
853 * w32.c (init_environment): If no_site_lisp, remove site-lisp
854 dirs from the default value of EMACSLOADPATH (bug#10208).
856 2011-12-07 Glenn Morris <rgm@gnu.org>
858 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
859 installation and source directories as well. (Bug#10208)
861 2011-12-06 Chong Yidong <cyd@gnu.org>
863 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
865 2011-12-06 Glenn Morris <rgm@gnu.org>
867 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
868 as an error, not just -1. (Bug#10217)
870 2011-12-05 Chong Yidong <cyd@gnu.org>
872 * keyboard.c (process_special_events): New function.
873 (swallow_events, Finput_pending_p): Use it (Bug#10195).
875 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
877 * coding.c (encode_designation_at_bol): Don't use uninitialized
878 local variable (Bug#9318).
880 2011-12-05 Kenichi Handa <handa@m17n.org>
882 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
883 return Qnil (Bug#8046, Bug#10193).
885 2011-12-05 Kenichi Handa <handa@m17n.org>
887 * coding.c (encode_designation_at_bol): New args charbuf_end and
888 dst. Return the number of produced bytes. Callers changed.
889 (coding_set_source): Return how many bytes coding->source was
891 (coding_set_destination): Return how many bytes
892 coding->destination was relocated.
893 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
894 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
896 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
898 * coding.c (CODING_CHAR_CHARSET_P): New macro.
899 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
902 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
904 The following changes are to fix Bug#9318.
906 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
907 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
908 (encode_coding_iso_2022, encode_coding_sjis)
909 (encode_coding_big5, encode_coding_charset): Use the above macros.
911 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
913 * lisp.h (process_quit_flag): Fix external declaration.
915 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
917 Don't macro-inline non-performance-critical code.
918 * eval.c (process_quit_flag): New function.
919 * lisp.h (QUIT): Use it.
921 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
923 * nsfns.m (get_geometry_from_preferences): New function.
924 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
926 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
928 * emacs.c (Qkill_emacs): Define.
929 (syms_of_emacs): Initialize it.
930 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
931 Qquit_flag to `kill-emacs' instead.
932 (quit_throw_to_read_char): Add parameter `from_signal'.
933 All callers changed. Call Fkill_emacs if requested and safe.
934 * lisp.h (QUIT): Call Fkill_emacs if requested.
936 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
938 * widget.c (update_wm_hints): Return if wmshell is null.
939 (widget_update_wm_size_hints): New function.
941 * widget.h (widget_update_wm_size_hints): Declare.
943 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
944 widget_update_wm_size_hints (Bug#10104).
946 2011-12-03 Eli Zaretskii <eliz@gnu.org>
948 * xdisp.c (handle_invisible_prop): If the invisible text ends just
949 before a newline, prepare the bidi iterator for consuming the
950 newline, and keep the current paragraph direction. (Bug#10183)
951 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
953 2011-12-02 Juri Linkov <juri@jurta.org>
955 * search.c (Fword_search_regexp): New Lisp function created from
956 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
957 (Fword_search_backward, Fword_search_forward)
958 (Fword_search_backward_lax, Fword_search_forward_lax):
959 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
960 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
962 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
964 * fileio.c (Finsert_file_contents): Move after-change-function call
965 to before the "handled:" label, since all "goto handled" appear in
966 cases where the *-change-functions have already been properly called
969 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
971 * keyboard.c (interrupt_signal): Don't call kill-emacs when
972 waiting for input. (Bug#10169)
974 2011-11-30 Eli Zaretskii <eliz@gnu.org>
976 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
977 verifies glyph row's hash code--we have just reallocated the
978 glyphs, so their contents can be complete garbage. (Bug#10164)
980 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
982 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
984 2011-11-30 Eli Zaretskii <eliz@gnu.org>
986 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
987 attributes are tested _before_ calling verify_row_hash, to protect
988 against GCC re-ordering of the tests. (Bug#10164)
990 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
992 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
994 * xterm.c (handle_one_xevent): Only set async_visible and friends
995 if net_wm_state_hidden_seen is non-zero (Bug#10002)
996 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
997 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
999 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1001 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1002 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1003 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1004 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1005 All uses changed to use GCPRO1 etc.
1006 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1007 Revert to old implementation (i.e., before 2011-03-11).
1009 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1011 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1012 of scroll runs so as to avoid assigning disabled bogus rows and
1013 unnecessary graphics copy operations.
1015 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1017 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1018 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1019 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1020 (malloc, free, realloc, calloc): Redirect to e_* only when
1023 * lisp.h (GCTYPEBITS): Move before first use.
1024 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1025 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1026 this macro definition.
1028 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1031 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1033 * gtkutil.c (xg_create_frame_widgets):
1034 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1035 present with Gtk+ 2.0.
1037 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1039 * fileio.c (Finsert_file_contents): Undo previous change; see
1040 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1042 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1044 Rename locals to avoid shadowing.
1045 * fileio.c (Finsert_file_contents):
1046 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1047 * process.c (wait_reading_process_output):
1048 Rename inner 'proc' to 'p' to avoid shadowing.
1049 Indent for consistency with usual Emacs style.
1051 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1053 * xdisp.c (redisplay_window): If cursor row is not fully visible
1054 after recentering, and scroll-conservatively is set to a large
1055 number, scroll window by a few more lines to make the cursor fully
1056 visible and out of scroll-margin. (Bug#10105)
1057 (start_display): Don't move to the next line if the display should
1058 start at a newline that is part of a display vector or an overlay
1061 2011-11-24 Juri Linkov <juri@jurta.org>
1063 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1064 after the `MagickPingImage' call. (Bug#10112)
1066 2011-11-23 Chong Yidong <cyd@gnu.org>
1068 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1070 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1072 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1073 making another buffer current. (Bug#10114)
1075 2011-11-23 Glenn Morris <rgm@gnu.org>
1077 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1079 2011-11-23 Chong Yidong <cyd@gnu.org>
1081 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1082 using it (Bug#5984).
1084 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1086 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1087 and header-lines, as they don't have one computed for them.
1090 * .gdbinit (prow): Make displayed values more self-explaining.
1091 Add row's hash code.
1093 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1095 * process.c (wait_reading_process_output): Fix asynchrounous
1096 GnuTLS socket handling on some versions of the GnuTLS library.
1097 (wait_reading_process_output): Add comment and URL.
1099 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1101 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1103 2011-11-21 Chong Yidong <cyd@gnu.org>
1105 * window.c (Fnext_window, Fprevious_window): Doc fix.
1107 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1109 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1111 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1113 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1115 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1117 * window.c (Fset_window_combination_limit): Rename argument
1119 (Vwindow_combination_limit): Remove "status" from doc-string.
1121 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1123 * m/ibms390.h: Remove.
1124 * m/ibms390x.h: Don't include "ibms390.h".
1126 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1128 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1129 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1131 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1133 * casetab.c (Fset_case_table):
1134 * charset.c (Fcharset_after): Fix typos.
1136 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1138 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1139 Otherwise, valgrind does not work on some platforms.
1140 Problem reported by Andreas Schwab in
1141 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1142 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1143 is set, removing the need for VIRT_ADDRESS_VARIES.
1144 (PURE_P): Use a more-efficient implementation that needs just one
1145 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1146 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1147 to 4 (xorl, subq, cmpq, setbe).
1148 * alloc.c (pure): Always extern now, since that's the
1149 VIRT_ADDR_VARIES behavior.
1150 (PURE_POINTER_P): Use a single comparison, not two, for
1151 consistency with the new puresize.h.
1152 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1153 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1154 Remove VIRT_ADDR_VARIES no longer needed.
1156 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1158 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1159 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1160 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1161 behave as if the cursor position were at the window margin.
1163 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1164 and the cursor position is out of bounds, behave as if the cursor
1165 position were at the window margin. (Bug#10075)
1167 2011-11-18 Chong Yidong <cyd@gnu.org>
1169 * window.c (Fwindow_combination_limit): Make first argument
1170 non-optional, since it is meaningless for live windows like the
1173 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1175 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1177 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1179 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1180 (graft_intervals_into_buffer): Simplify.
1182 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1184 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1185 hash values of the two rows.
1186 (copy_row_except_pointers): Preserve the used[] arrays and the
1187 hash values of the two rows. (Bug#10035)
1188 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1190 * xdisp.c (row_hash): New function, body extracted from
1191 compute_line_metrics.
1192 (compute_line_metrics): Call row_hash, instead of computing the
1195 * dispnew.c (verify_row_hash): Call row_hash for computing the
1196 hash code of a row, instead of duplicating code from xdisp.c.
1198 * dispextern.h (row_hash): Add prototype.
1200 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1202 * frame.c (delete_frame): Don't delete the terminal when the last
1203 X frame is closed if emacs is built with GTK toolkit.
1205 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1207 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1209 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1211 * window.c (Vwindow_splits): Rename to
1212 Vwindow_combination_resize. Suggested by Juri Linkov.
1213 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1216 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1218 * nsfns.m (Fns_font_name):
1219 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1221 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1223 * window.h (window): Rename slot "nest" to "combination_limit".
1224 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1225 (Fset_window_nest): Rename to Fset_window_combination_limit.
1226 (Vwindow_nest): Rename to Vwindow_combination_limit.
1227 (recombine_windows, make_parent_window, make_window)
1228 (Fsplit_window_internal, saved_window)
1229 (Fset_window_configuration, save_window_save): Rename all
1230 occurrences of window_nest to window_combination_limit.
1232 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1234 * image.c (imagemagick_load_image): Fix typo.
1236 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1238 * xdisp.c (display_line): Move the call to
1239 highlight_trailing_whitespace before the call to
1240 compute_line_metrics, since the latter needs to see the final
1241 faces of all the glyphs to compute ROW's hash value.
1242 Fixes assertion violations in row_equal_p. (Bug#10035)
1244 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1246 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1247 just return (bug#10044).
1249 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1251 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1252 with user-defined heap size. Bump the default size of the temacs
1253 heap to 27MB, to avoid memory warning when running temacs.
1254 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1256 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1257 current_matrix and desired_matrix. (Bug#9990)
1258 (verify_row_hash) [XASSERTS]: New function.
1259 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1260 that the hash value of glyph rows is correct.
1262 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1264 * window.h (window): Remove splits slot.
1265 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1266 (Fdelete_other_windows_internal, make_parent_window)
1267 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1268 (Fset_window_configuration, save_window_save): Don't deal with
1269 split status of windows.
1270 (saved_window): Remove splits slot.
1271 (Vwindow_splits): Rewrite doc-string.
1273 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1275 * xfns.c (unwind_create_frame):
1276 * nsfns.m (unwind_create_frame):
1277 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1278 Vframe_list (Bug#9999).
1280 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1282 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1284 2011-11-11 Kenichi Handa <handa@m17n.org>
1286 * callproc.c (Fcall_process): Set the member dst_multibyte of
1289 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1291 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1292 avoid a crash (bug#9496).
1294 2011-11-09 Chong Yidong <cyd@gnu.org>
1296 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1297 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1299 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1301 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1303 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1305 Avoid some portability problems by eschewing 'extern inline' functions.
1306 The trivial performance wins aren't worth the portability hassles; see
1307 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1309 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1310 (window_box_width, window_box_left, window_box_left_offset)
1311 (window_box_right, window_box_right_offset): Undo previous change,
1312 by removing the "extern"s.
1313 * intervals.c (adjust_intervals_for_insertion)
1314 (adjust_intervals_for_deletion): Undo previous change,
1315 making these static again.
1316 (offset_intervals, temp_set_point_both, temp_set_point)
1317 (copy_intervals_to_string): No longer inline.
1318 * xdisp.c (window_text_bottom_y, window_box_width)
1319 (window_box_height, window_box_left_offset)
1320 (window_box_right_offset, window_box_left, window_box_right)
1321 (window_box): No longer inline.
1323 2011-11-08 Chong Yidong <cyd@gnu.org>
1325 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1326 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1327 Signal an error if not a live window.
1328 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1329 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1331 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1333 * lisp.h (syms_of_abbrev): Remove declaration.
1334 Reported by CHENG Gao <chenggao@royau.me>.
1336 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1338 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1339 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1340 of temacs in GUI mode.
1342 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1344 * window.h: Declare delete_all_child_windows instead of
1345 delete_all_subwindows.
1346 * window.c (Fwindow_nest, Fset_window_nest)
1347 (Fset_window_new_total, Fset_window_new_normal)
1348 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1349 (delete_all_subwindows): Rename to delete_all_child_windows.
1350 (Fdelete_other_windows_internal, Fset_window_configuration):
1351 Call delete_all_child_windows instead of delete_all_subwindows.
1352 * frame.c (delete_frame): Call delete_all_child_windows instead
1353 of delete_all_subwindows.
1355 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1357 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1358 This is also needed for porting to any host where GC_MARK_STACK is
1359 not GC_MAKE_GCPROS_NOOPS.
1360 (which_symbols): Use it.
1362 2011-11-07 Kenichi Handa <handa@m17n.org>
1364 * coding.c (coding_set_destination): Check coding->src_pos only
1365 when coding->src_object is a buffer (bug#9910).
1367 * process.c (send_process): Set the member src_multibyte of coding
1368 to 0 (bug#9911) when sending a unibyte text.
1370 * callproc.c (Fcall_process): Set the member src_multibyte of
1371 process_coding to 0 (bug#9912).
1373 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1375 * xmenu.c (cleanup_widget_value_tree): New function.
1376 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1377 calling free_menubar_widget_value_tree directly (Bug#9830).
1379 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1381 Fix some portability problems with 'inline'.
1382 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1383 (window_box_width, window_box_left, window_box_left_offset)
1384 (window_box_right, window_box_right_offset): Declare extern.
1385 Otherwise, these inline functions do not conform to C99 and
1386 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1387 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1388 * intervals.c (adjust_intervals_for_insertion)
1389 (adjust_intervals_for_deletion): Now extern, because otherwise the
1390 extern inline functions 'offset_intervals' couldn't refer to it.
1391 (static_offset_intervals): Remove.
1392 (offset_intervals): Rewrite using the old contents of
1393 static_offset_intervals. The old version didn't conform to C99
1394 because an extern inline function contained a reference to an
1395 identifier with static linkage.
1397 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1399 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1402 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1404 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1405 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1406 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1407 return Qleft_to_right.
1409 2011-11-06 Chong Yidong <cyd@gnu.org>
1411 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1412 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1413 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1414 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1415 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1416 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1417 (Fwindow_vscroll): Doc fix.
1418 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1419 argument, since it makes no sense to pass a live window and for
1420 consistency with window-child.
1422 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1424 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1427 2011-11-05 Jason Rumney <jasonr@gnu.org>
1429 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1430 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1432 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1433 bitwise arithmetic preventing use of unicode-sip and non-truetype
1436 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1438 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1441 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1442 initialization code to keep similarity to xfns.c after changes
1445 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1447 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1448 (unwind_create_frame): New function (Bug#9943).
1449 (Fx_create_frame): Restructure code to be more similar to the one in
1450 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1451 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1452 Move terminal->reference_count++ just before making the frame official
1455 * nsterm.m (x_free_frame_resources): New function.
1456 (x_destroy_window): Move code to x_free_frame_resources.
1458 * xfns.c (unwind_create_frame): Fix comment.
1459 (Fx_create_frame, x_create_tip_frame):
1460 Move terminal->reference_count++ just before making the frame
1461 official. Move initialization of image_cache_refcount and
1462 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1464 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1466 Support MSVC build with newer versions of Visual Studio.
1467 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1468 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1471 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1472 which are not supported by MSVC.
1473 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1474 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1476 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1478 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1480 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1482 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1484 Support MSVC build with newer versions of Visual Studio.
1485 * w32.c: Don't include w32api.h for MSVC.
1486 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1488 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1489 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1490 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1491 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1493 (alloca) [_MSC_VER]: Define to _alloca.
1495 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1497 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1499 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1501 * xdisp.c (note_mouse_highlight): If either of
1502 previous/next-single-property-change returns nil, treat that as
1503 the beginning or the end of the buffer. (Bug#9955)
1505 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1507 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1508 label is not null (Bug#9951).
1509 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1512 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1514 * window.c (Fwindow_body_size): Mention in the doc string that the
1515 return value is in frame's canonical units. (Bug#9949)
1517 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1519 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1521 * w32fns.c (unwind_create_frame): If needed, free the glyph
1522 matrices of the partially constructed frame. (Bug#9943)
1523 * xfns.c (unwind_create_frame): Likewise.
1525 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1527 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1528 Don't stop backward scan on the continuation glyph, even though
1529 its CHARPOS is positive.
1530 (mouse_face_from_buffer_pos, note_mouse_highlight):
1531 Rename cover_string to disp_string.
1533 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1535 * window.c (temp_output_buffer_show): Don't use
1536 Vtemp_buffer_show_specifiers.
1537 (Vtemp_buffer_show_specifiers): Remove unused variable.
1539 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1541 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1542 past the beginning of the current glyph matrix.
1544 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1546 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1547 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1548 HAVE_GTK3 (Bug#9869).
1550 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1551 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1553 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1555 * xterm.c: Declare x_handle_net_wm_state to return int.
1556 (handle_one_xevent): Check if we are iconified but don't have
1557 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1558 (get_current_wm_state): Return non-zero if not hidden,
1559 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1560 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1561 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1562 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1564 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1566 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1567 so that this new function doesn't get optimized away by a
1568 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1570 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1572 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1574 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1576 Fix the `xbytecode' command.
1577 * .gdbinit (xprintbytestr): New command.
1578 (xwhichsymbols): Rename from `which'; all callers changed.
1579 (xbytecode): Print the byte-code string as well.
1581 2011-10-29 Kim Storm <storm@cua.dk>
1583 * alloc.c (which_symbols): New function.
1585 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1587 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1590 2011-10-29 Glenn Morris <rgm@gnu.org>
1592 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1593 Not clear what it was for, and it causes various bugs. (Bug#9839)
1595 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1597 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1598 possible random value that matches one of those tested as
1599 condition to clear the mouse face.
1601 2011-10-28 Chong Yidong <cyd@gnu.org>
1603 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1605 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1607 * window.c (make_window): Initialize phys_cursor_on_p.
1609 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1611 * lisp.h (struct Lisp_Symbol): Update comments.
1613 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1615 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1617 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1619 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1620 <oslsachem@gmail.com> for helping to debug this.
1622 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1623 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1624 (g_b_init_get_glyph_outline_w): New static variables.
1625 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1626 (GetGlyphOutlineW_Proc): New typedefs.
1627 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1628 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1630 (w32font_open_internal, compute_metrics):
1631 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1632 instead of calling the "wide" APIs directly.
1634 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1636 * w32.h (syms_of_w32font): Add prototype.
1638 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1640 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1641 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1642 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1643 (Fmove_to_window_line): Doc fix.
1645 2011-10-27 Chong Yidong <cyd@gnu.org>
1647 * process.c (make_process): Set gnutls_state to NULL.
1649 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1650 non-NULL, regardless of GNUTLS_INITSTAGE.
1651 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1652 an error. Set process slots as soon as we allocate them.
1654 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1656 2011-10-27 Chong Yidong <cyd@gnu.org>
1658 * gnutls.c (emacs_gnutls_deinit): New function.
1659 Deallocate credentials structures as well as calling gnutls_deinit.
1660 (Fgnutls_deinit, Fgnutls_boot): Use it.
1662 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1663 (deactivate_process): Call emacs_gnutls_deinit.
1665 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1667 * image.c (x_create_x_image_and_pixmap):
1668 * w32.c (sys_rename, w32_delayed_load):
1669 * w32font.c (fill_in_logfont):
1670 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1672 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1674 * w32fns.c (w32_default_color_map): New function,
1675 extracted from Fw32_default_color_map.
1676 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1678 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1680 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1682 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1684 * keyboard.c (test_undefined): New function (bug#9751).
1685 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1687 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1689 * sysdep.c (init_sys_modes): Fix the check for the controlling
1690 terminal (Bug#6649).
1692 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1694 * dispextern.h (struct bidi_it): New member next_en_type.
1696 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1697 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1698 current character, check also for next_en_type being WEAK_EN.
1699 (bidi_resolve_weak): Don't enter the expensive loop if the current
1700 position is before next_en_pos. Record the bidi type of the first
1701 non-ET, non-BN character we find, in addition to its position.
1702 (bidi_level_of_next_char): Invalidate next_en_type when
1703 next_en_pos is over-stepped.
1705 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1707 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1708 * editfns.c: Rewrite current-time-zone so that it invokes
1709 the equivalent of (format-time-string "%Z") to get the time zone name.
1710 This fixes a bug when the time zone name contains characters that
1711 need converting from the system time locale to Emacs internal format.
1712 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1713 that patch fixed format-time-string to do the conversion, but
1714 I forgot to fix current-time-zone.
1715 (format_time_string): New function, containing most of
1716 what Fformat_time_string used to contain.
1717 (Fformat_time_string): Rewrite in terms of format_time_string.
1718 This doesn't change this function's behavior.
1719 (current-time-zone): Rewrite to use format_time_string.
1720 This fixes the bug reported by Michael Schierl in
1721 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1722 Jason Rumney's 2007-06-07 change worked around this bug, but
1724 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1726 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1728 * xdisp.c (start_display): If the character at POS is displayed
1729 via a display vector, reset IT->current.dpvec_index to zero.
1730 (try_window_reusing_current_matrix): If a line ends in a display
1731 vector or the next line starts in a display vector, continue
1732 redrawing the window even though the character position of
1733 start_row was reached.
1736 2011-10-18 Chong Yidong <cyd@gnu.org>
1738 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1739 with nobreak-char-display too.
1741 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1743 Fix part 3 of bug#9771.
1744 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1745 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1746 non-neutral characters if the current character is a paragraph
1747 separator (a.k.a. Newline). This avoids running the same
1748 expensive loop twice, once when we consume the preceding newline
1749 and the other time when the line actually needs to be displayed.
1750 Avoid the loop when we see neutrals on the base embedding level
1751 following a character whose directionality is the same as the
1752 paragraph's. This avoids running the expensive loop when a line
1753 ends in a long sequence of neutrals, like control characters.
1754 Add assertion against STRONG_AL type. Slightly rearrange code
1755 that determines the type of a neutral given the first non-neutral
1757 (bidi_level_of_next_char): Set next_en_pos to zero when
1758 invalidating its info.
1760 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1762 * xdisp.c (push_display_prop): Determine whether to record string
1763 or buffer position by IT->string, not by IT->method. Allow
1764 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1765 (move_it_vertically_backward): Don't look for character position
1766 immediately after the newline when in a continuation line.
1769 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1771 * window.c (coordinates_in_window): Rewrite and delabelize
1772 vertical border check. (Bug#5357) (Bug#9618)
1774 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1776 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1777 errors in XSetWindowBorder (bug#9310).
1779 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1781 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1782 avoid crash when xmalloc overrun checking is enabled.
1784 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1786 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1787 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1788 cursor motion with <left> and <right> arrow keys.
1790 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1791 some callers set that themselves.
1793 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1795 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1796 display string and the previous row comes from the same string and
1797 is empty. (Bug#9739) (Bug#9738)
1799 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1801 * doc.c (get_doc_string): Encode file name (bug#9735).
1803 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1805 * bidi.c (bidi_level_of_next_char):
1806 * xdisp.c (get_visually_first_element): Remove old incorrect
1807 comments regarding the Unicode Line Separator character.
1809 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1811 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1813 * alloc.c (Fgc_status): Do not access beyond zombies array
1814 boundary if nzombies > MAX_ZOMBIES.
1815 * alloc.c (dump_zombies): Add missing format specifier.
1817 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1819 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1820 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1822 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1823 Some packages use them to denote characters with modifiers.
1825 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1827 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1828 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1829 matching a pp-number. Rename parameter var to var1.
1831 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1833 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1835 2011-10-08 Glenn Morris <rgm@gnu.org>
1837 * callint.c (Fcall_interactively): Give a more explicit error for the
1838 'c' case with a non-character input. (Bug#8479)
1840 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1842 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1844 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1845 lines that are hscrolled on the left.
1847 * dispnew.c (buffer_posn_from_coords): Account for a possible
1848 presence of header-line. (Bug#4426)
1850 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1852 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1853 Don't advertise functionality which we discourage or doesn't work.
1855 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1857 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1858 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1859 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1860 this makes Emacs dump core during garbage collection on rare
1861 occasions. sizeof is obviously inferior to offsetof here, so
1862 stick with offsetof.
1863 (GC_POINTER_ALIGNMENT): New macro.
1864 (mark_memory): Omit 3rd (offset) arg; caller changed.
1865 Don't assume EMACS_INT alignment is the same as pointer alignment.
1867 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1869 * keyboard.c (read_key_sequence_remapped): New var.
1870 (read_key_sequence): Compute remapping in the right buffer.
1871 (command_loop_1): Use read_key_sequence's remapping directly.
1873 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1875 * dired.c (file_name_completion): Don't expand file name.
1876 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1877 before checking file name handler.
1879 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1880 they've been requested explicitly (bug#9591).
1882 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1884 * keymap.c (Fsingle_key_description): Use make_specified_string
1885 instead of build_string to build string from push_key_description.
1888 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1890 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1891 This fixes a Y2038 bug on 64-bit hosts.
1892 * buffer.c (reset_buffer):
1893 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1894 (Fclear_buffer_auto_save_failure):
1895 Use 0, not -1, to represent an unset failure time, since time_t
1896 might not be signed.
1898 Remove dependency on glibc malloc internals.
1899 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1900 Move back here from lisp.h, but with their new implementations.
1901 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1902 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1903 * charset.c (charset_table_init): New static var.
1904 (syms_of_charset): Use it instead of xmalloc. This removes a
1905 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1906 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1907 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1908 Move back to alloc.c.
1909 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1910 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1912 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1914 * nsterm.m (windowDidResize): Call x_set_window_size only when
1915 ns_in_resize is true. Otherwise set pixelwidth/height and
1916 call change_frame_size (Bug#9628).
1918 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1920 Port --enable-checking=all to Fedora 14 x86-64.
1921 * charset.c (syms_of_charset): Also account for glibc malloc's
1922 internal overhead when calculating the initial malloc maximum.
1924 Port --enable-checking=all to Fedora 14 x86.
1925 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1927 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1928 (overrun_check_realloc, overrun_check_free):
1929 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1930 That way, xmalloc returns a properly-aligned pointer even if
1931 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1932 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1933 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1934 into account when calculating the initial malloc maximum.
1935 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1936 Move here from alloc.c, so that charset.c can use it too.
1937 Properly align; the old code wasn't right for common 32-bit hosts
1938 when configured with --enable-checking=all.
1939 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1940 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1942 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1944 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1947 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1949 * xdisp.c (compute_display_string_end): If there's no display
1950 string at CHARPOS, return -1.
1952 * bidi.c (bidi_fetch_char): When compute_display_string_end
1953 returns a negative value, treat the character as a normal
1954 character not covered by a display string. (Bug#9624)
1956 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1958 * lread.c (Fread_from_string): Fix typo in docstring.
1960 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1962 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1963 newline, reseat the iterator instead of bidi-iterating there one
1964 character at a time. (Bug#9610)
1965 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1966 TO_CHARPOS if the bidi iterator is at base embedding level.
1968 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1970 * lread.c (readevalloop): Use correct code for NBSP.
1971 (read1): Likewise. (Bug#9608)
1973 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1975 * dbusbind.c (Fdbus_register_signal): When service is not
1976 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1978 2011-09-25 Glenn Morris <rgm@gnu.org>
1980 * buffer.c (truncate-lines): Doc fix.
1982 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1984 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1985 (Fset_window_next_buffers): Doc fix.
1987 2011-09-24 Glenn Morris <rgm@gnu.org>
1989 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1991 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1993 Fix minor problems found by static checking.
1994 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1995 * indent.c (Fvertical_motion): Fix == vs = typo.
1997 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1999 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2000 Default value is now t. Doc fix.
2002 * indent.c (Fvertical_motion): Compute and apply the overshoot
2003 logic when moving up, not only when moving down. Fix the
2004 confusing name and values of the it_overshoot_expected variable;
2005 logic changes accordingly. (Bug#9254) (Bug#9549)
2007 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2008 CHARPOS is covered by a display string which includes newlines.
2009 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2010 is covered by a display string with embedded newlines.
2012 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2014 * dbusbind.c (Fdbus_register_signal): Add match rule to
2015 Vdbus_registered_objects_table. (Bug#9581)
2016 (Fdbus_register_method, Vdbus_registered_objects_table):
2019 2011-09-24 Jim Meyering <meyering@redhat.com>
2021 do not ignore write error for any output size
2022 The previous change was incomplete.
2023 While it makes emacs --batch detect the vast majority of stdout
2024 write failures, errors were still ignored whenever the output size is
2025 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2026 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2027 && echo FAIL: ignored write error
2028 FAIL: ignored write error
2029 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2030 && echo FAIL: ignored write error
2031 FAIL: ignored write error
2032 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2034 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2036 * emacs.c (Fkill_emacs): In noninteractive mode exit
2037 non-successfully if a write error occurred on stdout. (Bug#9574)
2039 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2041 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2044 * dispextern.h (struct it): Update the comment documenting what
2047 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2049 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2050 a display string, extend search for cursor position to end of row.
2051 (find_row_edges): If the row ends in a newline from a display
2052 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2053 Handle the case of a display string with multiple newlines.
2054 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2055 non-empty line. Fixes confusing cursor motion with arrow keys at
2056 the beginning of a line that starts with whitespace.
2058 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2060 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2063 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2065 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2068 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2070 * xdisp.c (display_line): Record maximum and minimum buffer
2071 positions even if no glyphs were produced (e.g., by a zero-width
2072 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2073 buffer positions that will be removed from the glyph row because
2075 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2076 column is beyond frame width: don't subtract 1 "pixel" when
2077 computing width of the stretch.
2078 (reseat_at_next_visible_line_start): Undo the change made on
2079 2011-09-17 that saved paragraph information and restored it after
2080 the call to `reseat'. (Bug#9545)
2082 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2084 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2085 and turn window cursor on if cleared (Bug#9415).
2087 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2089 * search.c (boyer_moore): Take unibyte characters from pattern
2090 literally. (Bug#9458)
2092 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2094 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2096 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2098 Fix minor problem found by static checking.
2099 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2100 initialized, to pacify gcc -Wuninitialized.
2102 * fileio.c: Report proper errno when syscall falls.
2103 (Finsert_file_contents): Save and restore errno,
2104 so that report_file_error outputs the correct diagnostic.
2105 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2107 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2109 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2111 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2113 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2114 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2116 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2118 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2119 about the current paragraph and restore it after the call to reseat.
2121 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2122 (bidi_find_paragraph_start): Search back for paragraph beginning
2123 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2124 (bidi_move_to_visually_next): Only trigger paragraph-related
2125 computations when the last character is a newline or at EOB, not
2126 just any NEUTRAL_B. (Bug#9470)
2128 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2129 truncated lines if point is covered by a display string. (Bug#9524)
2131 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2133 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2134 (cons_to_x_long): New function.
2135 (lisp_data_to_selection_data): Use it. Correct the test for
2136 short-versus-long data; it was negated. Break out of vector
2137 loop, for efficiency, when a long datum is discovered.
2139 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2141 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2143 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2145 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2146 GCC PR/17406) by declaring this function with external scope.
2148 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2150 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2151 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2153 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2155 * editfns.c (Fformat): Correctly handle text properties on "%%".
2157 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2159 * xterm.c (x_draw_composite_glyph_string_foreground):
2160 * w32term.c (x_draw_composite_glyph_string_foreground):
2161 * term.c (encode_terminal_code):
2162 * composite.c (composition_update_it, get_composition_id):
2163 * xdisp.c (get_next_display_element)
2164 (fill_composite_glyph_string): Add comments about special meaning
2165 of TAB characters in a composition.
2167 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2169 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2170 This occurs when processing a multibyte format.
2171 Problem reported by Wolfgang Jenker.
2173 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2175 * xdisp.c (try_cursor_movement): Only check for exact match if
2176 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2178 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2180 Remove unused external symbols.
2181 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2182 * xdisp.c (calc_pixel_width_or_height): Now static.
2183 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2184 * indent.c (check_display_width):
2185 * w32term.c: Fix comment to match code.
2186 * xterm.c, xterm.h (x_catching_errors): Remove.
2188 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2190 * xselect.c: Use signed conversions more consistently (Bug#9498).
2191 (selection_data_to_lisp_data): Assume incoming selection data are
2192 signed integers, not unsigned. This is to be consistent with
2193 outgoing selection data, which was modified to use signed integers
2194 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2195 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2196 expects long, not unsigned long.
2198 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2200 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2201 computation of loop end. Reported by Johan Bockgård
2204 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2206 * frame.c (Fother_visible_frames_p): Function deleted.
2208 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2210 * indent.c (compute_motion): Process display vector front to back
2211 rather than the other way around. (Bug#2496)
2213 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2215 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2217 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2219 * minibuf.c (Fread_from_minibuffer): Doc fix.
2221 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2223 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2224 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2226 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2228 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2229 value for non-existent files.
2231 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2233 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2234 set its "size" to -1. This will set the modtime_size field of
2235 the corresponding buffer to -1, which is what
2236 verify-visited-file-modtime expects for files that do not exist.
2239 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2241 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2243 * lisp.h: ... from here. push_key_description is no longer
2244 defined in keyboard.c, so its declaration should not be in
2245 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2246 logically belongs with push_key_description.
2248 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2250 * buffer.h: Include <sys/types.h> instead of <time.h>.
2251 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2252 Problem reported by Herbert J. Skuhra.
2254 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2256 * xml.c (parse_region): Make the parsing work for
2257 non-comment-starting XML files again (bug#9144).
2259 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2261 * image.c (gif_load): Fix calculation of bottom and right corner.
2264 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2266 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2267 redisplay in small windows.
2269 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2271 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2273 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2275 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2276 Operate on live windows only.
2278 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2280 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2282 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2284 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2285 only under bidi iteration.
2287 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2289 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2291 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2293 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2294 Without this fix, the command to link temacs failed due to an
2295 undefined symbol __builtin_isnan. This is because
2296 /usr/include/iso/math_c99.h #defines isnan(x) to
2297 __builtin_isnan(x), but the bundled gcc, which identifies itself
2298 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2300 * floatfns.c (isnan): #undef, and then #define to a clone of
2302 (Fisnan): Always define, since it's always available now.
2303 (syms_of_floatfns): Always define isnan at the Lisp level.
2305 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2307 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2309 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2311 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2312 The previous code assumed that file offsets (off_t values) fit in
2313 EMACS_INT variables, which is not true on typical 32-bit hosts.
2314 The code messed up by falsely reporting buffer overflow in cases
2315 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2316 when "big" contains more than 2**29 bytes, even though this
2317 inserts just one byte and does not overflow the buffer.
2318 (Finsert_file_contents): Store file offsets as off_t
2319 values, not as EMACS_INT values. Check for overflow when
2320 converting between EMACS_INT and off_t. When checking for
2321 buffer overflow or for overlap, take the offsets into account.
2322 Don't use EMACS_INT for small values where int suffices.
2323 When checking for overlap, fix a typo: ZV was used where
2324 ZV_BYTE was intended.
2325 (Fwrite_region): Don't assume off_t fits into 'long'.
2326 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2328 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2330 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2332 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2334 sprintf-related integer and memory overflow issues (Bug#9412).
2336 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2337 (esprintf, exprintf, evxprintf): New functions.
2338 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2339 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2340 (modify_event_symbol): Do not assume that the length of
2341 name_alist_or_stem is safe to alloca and fits in int.
2342 (Fexecute_extended_command): Likewise for function name and binding.
2343 (Frecursion_depth): Wrap around reliably on integer overflow.
2344 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2345 since some callers pass EMACS_INT values.
2346 (Fsingle_key_description): Don't crash if symbol name contains more
2347 than MAX_ALLOCA bytes.
2348 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2349 (get_minibuffer): Arg is now EMACS_INT, not int.
2350 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2351 (esprintf, exprintf, evxprintf): New decls.
2352 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2354 * dbusbind.c (signature_cat): New function.
2355 (xd_signature, Fdbus_register_signal):
2356 Do not overrun buffer; instead, report string overflow.
2358 * dispnew.c (add_window_display_history): Don't overrun buffer.
2359 Truncate instead; this is OK since it's just a log.
2361 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2362 even if the time zone offset is outlandishly large.
2363 Don't mishandle offset == INT_MIN.
2365 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2366 when creating daemon; the previous buffer-overflow check was incorrect.
2368 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2369 which has the guts of the old verror function.
2371 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2372 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2374 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2375 (font_unparse_xlfd): Don't blindly alloca long strings.
2376 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2377 fits in int, when using sprintf. Use single snprintf to count
2378 length of string rather than counting it via multiple sprintfs;
2379 that's simpler and more reliable.
2380 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2381 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2382 sprintf, in case result does not fit in int.
2384 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2385 (fontset_from_font): Print it.
2387 * frame.c (tty_frame_count): Now printmax_t, not int.
2388 (make_terminal_frame, set_term_frame_name): Print it.
2389 (x_report_frame_params): In X, window IDs are unsigned long,
2390 not signed long, so print them as unsigned.
2391 (validate_x_resource_name): Check for implausibly long names,
2392 and don't assume name length fits in 'int'.
2393 (x_get_resource_string): Don't blindly alloca invocation name;
2394 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2397 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2398 (xg_check_special_colors, xg_set_geometry):
2399 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2401 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2402 Use esprintf, not sprintf, in case result does not fit in int.
2404 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2405 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2406 it as a large positive number.
2407 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2408 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2410 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2411 in case result does not fit in int.
2413 * print.c (float_to_string): Detect width overflow more reliably.
2414 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2415 buffer overrun. Don't assume list length fits in 'int'. Treat
2416 print length of 0 as 0, not as infinity; to be consistent with other
2417 uses of print length in this function. Don't overflow print length
2418 index. Don't assume hash table size fits in 'long', or that
2419 vectorlike size fits in 'unsigned long'.
2421 * process.c (make_process): Use printmax_t, not int, to format
2422 process-name gensyms.
2424 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2426 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2427 to avoid potential buffer overrun.
2429 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2430 if X resource line is longer than 512 bytes.
2432 * xfns.c (x_window): Make sprintf buffer a bit bigger
2433 to avoid potential buffer overrun.
2435 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2437 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2439 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2441 Integer overflow fixes for scrolling, etc.
2442 Without these, Emacs silently mishandles large integers sometimes.
2443 For example, "C-u 4294967297 M-x recenter" was treated as if
2444 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2446 * xdisp.c (try_window_id): Check Emacs fixnum range before
2447 converting to 'int'.
2449 * window.c (window_scroll_line_based, Frecenter):
2450 Check that an Emacs fixnum is in range before assigning it to 'int'.
2451 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2452 values converted from Emacs fixnums.
2453 (Frecenter): Don't wrap around a line count if it is out of 'int'
2454 range; instead, treat it as an extreme value.
2455 (Fset_window_configuration, compare_window_configurations):
2456 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2458 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2459 that can exceed INT_MAX. Check that EMACS_INT value is in range
2460 before assigning it to the (possibly-narrower) index.
2461 (match_limit): Don't assume that a fixnum can fit in 'int'.
2463 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2466 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2467 (Fvertical_motion): Don't wrap around LINES values that don't fit
2468 in 'int'. Instead, treat them as extreme values. This is good
2469 enough for windows, which can't have more than INT_MAX lines anyway.
2471 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473 * Require libxml/parser.h to avoid compilation warning.
2475 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2477 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2478 since this reportedly can destroy thread storage.
2480 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2482 * syntax.c (find_defun_start): Update all cache variables if
2483 exiting early (Bug#9401).
2485 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2487 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2489 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2490 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2491 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2493 * term.c (tty_append_glyph): New function.
2494 (produce_stretch_glyph): Static function and its prototype deleted.
2496 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2499 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2501 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2502 when checking :margin (Bug#9390).
2503 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2504 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2505 so that the name doesn't mislead. All uses changed.
2507 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2509 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2512 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2514 * xdisp.c (move_it_to): Don't bail out early when reaching
2515 position beyond to_charpos, if we are scanning backwards.
2516 (move_it_vertically_backward): When DY == 0, make sure we get to
2517 the first character in the line after the newline.
2519 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2521 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2522 (ccl_driver): Do not generate an out-of-range pointer.
2523 (Fccl_execute_on_string): Remove unnecessary check for
2524 integer overflow, noted by Stefan Monnier in
2525 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2526 Remove a FIXME that didn't need fixing.
2527 Simplify the newly-introduced buffer reallocation code.
2529 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2531 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2533 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2535 Integer and memory overflow issues (Bug#9196).
2537 * doc.c (get_doc_string): Rework so that
2538 get_doc_string_buffer_size is the actual buffer size, rather than
2539 being 1 less than the actual buffer size; this makes xpalloc more
2542 * image.c (x_allocate_bitmap_record, cache_image):
2543 * xselect.c (Fx_register_dnd_atom):
2544 Simplify previous changes by using xpalloc.
2546 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2547 since either will do and ptrdiff_t is convenient with xpalloc.
2549 * charset.c (charset_table_size)
2550 (struct charset_sort_data.priority): Now ptrdiff_t.
2551 (charset_compare): Don't overflow if priorities differ greatly.
2552 (Fsort_charsets): Don't assume list length fits in int.
2553 Check for size-calculation overflow when allocating sort data.
2554 (syms_of_charset): Allocate an initial charset table that is
2555 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2557 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2559 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2560 The actual value is always <= INT_MAX, and leaving it unsigned made
2561 overflow checking harder.
2563 * dispextern.h (struct glyph_matrix.rows_allocated)
2564 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2565 with xpalloc. The values are still always <= INT_MAX.
2567 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2569 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2570 (SAFE_NALLOCA): New macro.
2572 * region-cache.c (struct boundary.pos, find_cache_boundary)
2573 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2574 (set_cache_region, invalidate_region_cache)
2575 (revalidate_region_cache, know_region_cache, region_cache_forward)
2576 (region_cache_backward, pp_cache):
2577 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2578 so that ptrdiff_t * can be passed to xpalloc.
2579 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2580 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2581 (pp_cache): Don't assume cache_len fits in int.
2582 * region-cache.h: Adjust extern decls to match.
2584 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2585 EMACS_INT, since either will do, for xpalloc.
2587 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2588 (xnmalloc, xnrealloc, xpalloc): New functions.
2590 * bidi.c (bidi_shelve_header_size): New constant.
2591 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2592 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2594 * bidi.c (bidi_cache_shrink):
2595 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2597 Don't update size of array until after memory allocation succeeds,
2598 because xmalloc/xrealloc may not return.
2599 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2600 now that we have proper integer overflow checking.
2601 (record_overlay_string, overlay_strings): Catch overflows when
2602 calculating size of overlay_str_buf.
2604 * callproc.c (Fcall_process): Check for size overflow when
2605 calculating size of args2.
2606 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2607 Normally we prefer signed values, but sticking with ptrdiff_t would
2608 require adding more-complicated checks.
2610 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2611 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2612 Redo buffer-overflow calculations to avoid integer overflow.
2613 Add a FIXME comment where memory seems to be over-allocated.
2615 * character.c (Fstring): Check for size-calculation overflow.
2617 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2618 unnecessary integer overflow. Check for size overflow.
2619 (encode_coding_object): Don't update size until xmalloc succeeds.
2621 * composite.c (get_composition_id): Check for overflow in glyph
2622 length calculations.
2624 Integer and memory overflow fixes for display code.
2625 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2626 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2627 (scrolling_window): Check for overflow in size calculations.
2628 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2629 Don't assume glyph table len fits in int.
2630 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2631 (row_table_size): Now ptrdiff_t, not int.
2632 (scrolling_window): Avoid overflow in size calculations.
2633 Don't update size until allocation succeeds.
2634 * fns.c (concat): Check for overflow in size calculations.
2635 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2636 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2637 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2639 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2640 (get_doc_string): Check for size calculation overflow.
2641 Don't update size until allocation succeeds.
2642 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2643 EMACS_INT, where ptrdiff_t will do.
2644 (Fsubstitute_command_keys): Check for string overflow.
2646 * editfns.c (set_time_zone_rule): Don't assume environment length
2648 (message_length): Now ptrdiff_t, not int.
2649 (Fmessage_box): Don't update size until allocation succeeds.
2650 Don't assume message length fits in int.
2651 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2653 * emacs.c (main): Do not reallocate argv, since there is a null at
2654 the end that can be overwritten, and this way there's no need to
2655 worry about size-calculation overflow.
2656 (sort_args): Check for size-calculation overflow.
2658 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2660 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2662 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2663 (x_set_scroll_bar_width, x_figure_window_size):
2664 Check for integer overflow.
2665 (x_set_alpha): Do not assume XINT fits in int.
2667 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2668 This is for the members text_lines, text_cols, total_lines, total_cols,
2669 where the system imposes an 'int' limit.
2671 * fringe.c (Fdefine_fringe_bitmap):
2672 Don't update size until alloc works.
2674 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2675 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2677 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2678 Check for size-calculation overflow.
2679 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2680 do, as we prefer signed integers.
2681 (id_to_widget.max_size, id_to_widget.used)
2682 (xg_store_widget_in_map, xg_remove_widget_from_map)
2683 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2684 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2685 Use and return ptrdiff_t, not int.
2686 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2687 * gtkutil.h: Change prototypes to match the above.
2689 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2690 are duplicate now that they've been promoted to lisp.h.
2691 (x_allocate_bitmap_record, x_alloc_image_color)
2692 (make_image_cache, cache_image, xpm_load):
2693 Don't update size until alloc is done.
2694 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2696 Check for size calculation overflow.
2697 (ct_colors_allocated_max): New constant.
2698 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2701 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2702 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2703 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2704 Use ptrdiff_t, not int, to count maps.
2705 (read_char_minibuf_menu_prompt): Check for overflow in size
2706 calculations. Don't update size until allocation succeeds.
2707 Redo calculations to avoid overflow.
2708 * keyboard.h: Change prototypes to match the above.
2710 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2712 (current_minor_maps): Check for size calculation overflow.
2713 * keymap.h: Change prototypes to match the above.
2715 * lread.c (read1, init_obarray): Don't update size until alloc done.
2717 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2718 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2720 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2721 Now ptrdiff_t, not int.
2722 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2723 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2725 * process.c (Fnetwork_interface_list): Check for overflow
2726 in size calculation.
2728 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2730 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2731 overflow. Don't bother calling xmalloc when xrealloc will do.
2733 * search.c (Freplace_match): Check for size calculation overflow.
2734 (Fset_match_data): Don't assume list lengths fit in 'int'.
2736 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2737 for command line length. Do not attempt to address one before the
2738 beginning of an array, as that's not portable.
2740 * term.c (max_frame_lines): Remove; unused.
2741 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2743 (encode_terminal_code, calculate_costs): Check for size
2744 calculation overflow.
2745 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2746 table lengths and related sizes. Don't update size until alloc
2747 done. Redo calculations to avoid overflow.
2748 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2750 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2751 subtracting pointers.
2752 (gobble_line): Check for overflow more carefully. Don't update size
2755 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2756 Don't update size until alloc done.
2757 Redo size calculations to avoid overflow.
2758 Check for size calculation overflow.
2759 (main) [DEBUG]: Fix typo in invoking tparam1.
2761 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2762 Use ptrdiff_t, not int, for sizes.
2763 (store_mode_line_noprop_char): Don't update size until alloc done.
2765 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2766 Use ptrdiff_t, not int, for sizes.
2767 (Finternal_make_lisp_face, cache_face):
2768 Check for size calculation overflow.
2769 (cache_face): Treat size calculation overflows as if they were
2770 memory exhaustion (the usual treatment), rather than aborting.
2772 * xfns.c (x_encode_text, x_set_name_internal)
2773 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2774 sizes, since they can exceed INT_MAX in size. Check for size
2775 calculation overflow.
2777 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2778 (xg_select): Check for size calculation overflow.
2779 Don't update size until alloc done.
2781 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2782 as sprintf is limited to int lengths.
2784 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2785 (X_LONG_MIN): New macros.
2786 Use them to make the following changes clearer.
2787 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2788 This change doesn't affect the value now, but it may help remind
2789 future maintainers not to raise the value too much later.
2790 (SELECTION_QUANTUM): Remove, replacing with ...
2791 (selection_quantum): ... new function, which avoids overflow.
2793 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2794 assumption that selection length fits in 'int'.
2795 (x_reply_selection_request, x_handle_selection_request)
2796 (x_get_window_property, receive_incremental_selection)
2797 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2798 (lisp_data_to_selection_data, clean_local_selection_data):
2799 Use ptrdiff_t, not int, to record length of selection.
2800 (x_reply_selection_request, x_get_window_property)
2801 (receive_incremental_selection, x_property_data_to_lisp):
2802 Redo calculations to avoid overflow.
2803 (x_reply_selection_request): When sending hint, ceiling it at
2804 X_LONG_MAX rather than relying on wraparound overflow to send
2806 (x_get_window_property, receive_incremental_selection)
2807 (lisp_data_to_selection_data, x_property_data_to_lisp):
2808 Check for size-calculation overflow.
2809 (x_get_window_property, receive_incremental_selection)
2810 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2811 Don't store size until memory allocation succeeds.
2812 (x_get_window_property): Plug memory leak on memory exhaustion.
2813 Don't double-block input; malloc is safe here. Don't assume 2**34
2814 - 4 fits in unsigned long. Add an xassert to check
2815 XGetWindowProperty overflow. Be more careful about overflow
2816 calculations, and distinguish size from memory overflow better.
2817 (receive_incremental_selection): When tracing, don't assume
2818 unsigned int is less than INT_MAX.
2819 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2820 harmful) conversions of unsigned short to int.
2821 (lisp_data_to_selection_data): Don't assume that integers
2822 in the range -65535 through -1 fit in an X unsigned short.
2823 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2824 result parameters unless successful. Rely on cons_to_unsigned
2825 to report problems with elements; the old code wasn't right anyway.
2826 (x_check_property_data): Check for int overflow; we cannot use
2827 a wider type due to X limits.
2828 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2830 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2832 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2833 (x_term_init): Check for size calculation overflow.
2834 (x_color_cells): Don't store size until memory allocation succeeds.
2835 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2836 Don't assume alloca size is less than MAX_ALLOCA.
2837 (x_term_init): Don't assume length fits in int (sprintf is limited
2840 Use ptrdiff_t for composition IDs.
2841 * character.c (lisp_string_width):
2842 * composite.c (composition_table_size, n_compositions)
2843 (get_composition_id, composition_gstring_from_id):
2844 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2845 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2846 * window.c (Frecenter):
2847 Use ptrdiff_t, not int, for composition IDs.
2848 * composite.c (get_composition_id): Check for integer overflow.
2849 * composite.h: Adjust prototypes to match the above changes.
2851 Use ptrdiff_t for hash table indexes.
2852 * category.c (hash_get_category_set):
2853 * ccl.c (ccl_driver):
2854 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2855 * coding.c (coding_system_charset_list, detect_coding_system):
2856 * coding.h (struct coding_system.id):
2857 * composite.c (get_composition_id, gstring_lookup_cache):
2858 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2859 * image.c (xpm_get_color_table_h):
2860 * lisp.h (hash_lookup, hash_put):
2861 * minibuf.c (Ftest_completion):
2862 Use ptrdiff_t for hash table indexes, not int (which is too
2863 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2864 32-bit --with-wide-int hosts).
2866 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2867 Add a FIXME comment about memory leaks.
2868 (syms_of_charset): Don't assume xmalloc returns.
2870 Don't assume that stated character widths fit in int.
2871 * character.c (Fchar_width, c_string_width, lisp_string_width):
2872 * character.h (CHAR_WIDTH):
2873 * indent.c (MULTIBYTE_BYTES_WIDTH):
2874 Use sanitize_char_width to avoid undefined and/or bad behavior
2875 with outlandish widths.
2876 * character.h (sanitize_tab_width): Rename from sanitize_width,
2877 now that we have two such functions. All uses changed.
2878 (sanitize_char_width): New inline function.
2880 Don't assume that tab-width fits in int.
2881 * character.h (sanitize_width): New inline function.
2882 (SANE_TAB_WIDTH): New macro.
2883 (ASCII_CHAR_WIDTH): Use it.
2884 * indent.c (sane_tab_width): Remove. All uses replaced by
2885 SANE_TAB_WIDTH (current_buffer).
2886 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2888 * fileio.c: Integer overflow issues with file modes.
2889 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2891 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2892 Remove unreachable code.
2893 (read_hex, load_charset_map_from_file): Check for integer overflow.
2895 * xterm.c: Don't go over XClientMessageEvent limit.
2896 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2897 (x_send_scroll_bar_event): Likewise. Check that the size does not
2898 exceed limits imposed by XClientMessageEvent, as well as the usual
2899 ptrdiff_t and size_t limits.
2901 * keyboard.c: Overflow, signedness and related fixes.
2902 (make_lispy_movement): Use same integer type in forward decl
2903 that is used in the definition.
2904 (read_key_sequence, keyremap_step):
2905 Change bufsize argument back to int, undoing my 2011-03-30 change.
2906 We prefer signed types, and int is wide enough here.
2907 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2908 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2909 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2910 length, not size_t. Use ptrdiff_t for index, not int.
2911 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2912 possibility of integer overflow.
2914 Overflow, signedness and related fixes for images.
2916 * dispextern.h (struct it.stack[0].u.image.image_id)
2917 (struct_it.image_id, struct image.id, struct image_cache.size)
2918 (struct image_cache.used, struct image_cache.ref_count):
2919 * gtkutil.c (update_frame_tool_bar):
2920 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2921 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2922 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2923 * nsmenu.m (update_frame_tool_bar):
2924 * xdisp.c (calc_pixel_width_or_height):
2925 * xfns.c (image_cache_refcount):
2926 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2927 on typical 64-bit hosts.
2929 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2930 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2931 Omit unnecessary casts to int.
2932 (parse_image_spec): Check that integers fall into 'int' range
2933 when the callers expect that.
2934 (image_ascent): Redo ascent calculation to avoid int overflow.
2935 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2936 (lookup_image): Remove unnecessary tests.
2937 (xbm_image_p): Locals are now of int, not EMACS_INT,
2938 since parse_image_check makes sure they fit into int.
2939 (png_load, gif_load, svg_load_image):
2940 Prefer int to unsigned where either will do.
2941 (tiff_handler): New function, combining the cores of the
2942 old tiff_error_handler and tiff_warning_handler.
2943 This function is rewritten to use vsnprintf and thereby avoid
2944 stack buffer overflows. It uses only the features of vsnprintf
2945 that are common to both POSIX and native Microsoft.
2946 (tiff_error_handler, tiff_warning_handler): Use it.
2947 (tiff_load, gif_load, imagemagick_load_image):
2948 Don't assume :index value fits in 'int'.
2949 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2950 (imagemagick_load_image): Check that crop parameters fit into
2951 the integer types that MagickCropImage accepts. Don't assume
2952 Vimagemagick_render_type has a nonnegative value. Don't assume
2953 size_t fits in 'long'.
2954 (gs_load): Use printmax_t to print the widest integers possible.
2955 Check for integer overflow when computing image height and width.
2957 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2959 * xdisp.c (redisplay_window): Don't force window start if point
2960 will be invisible in the resulting window. (Bug#9324)
2962 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2964 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2965 the display spec is of the form `(space ...)'.
2966 (handle_display_spec): Return the value returned by
2967 handle_single_display_spec, not just 1 or zero.
2968 (handle_single_display_spec): If the display spec is of the form
2969 `(space ...)', and specifies display in the text area, return 2
2971 (try_cursor_movement): Check for the need to scroll more
2972 accurately, and prefer exact match for point under bidi.
2973 Don't advance `row' beyond the last row of the window.
2975 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2976 into disp_prop; all users changed.
2978 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2979 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2980 for the text covered by the display property.
2982 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2984 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2985 Change return value to nil.
2986 (Frecord_buffer): Delete unused function.
2988 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2990 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2991 buffers, return left-to-right.
2992 (set_cursor_from_row): Consider candidate row a win if its glyph
2993 represents a newline and point is on that newline. Fixes cursor
2994 positioning on the newline at EOL of R2L text within L2R
2995 paragraph, and vice versa.
2996 (try_cursor_movement): Check continued rows, in addition to
2997 continuation rows. Fixes unwarranted scroll when point enters a
2998 continued line of R2L text within an L2R paragraph, or vice versa.
2999 (cursor_row_p): Consider the case of point being equal to
3000 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3001 from the end of a short line to the beginning of a continued line
3002 of R2L text within L2R paragraph.
3003 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3004 composed characters.
3006 * bidi.c (bidi_check_type): Use xassert.
3007 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3010 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3012 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3015 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3017 * nsfont.m (ns_otf_to_script): Fix typo.
3019 2011-08-22 Kenichi Handa <handa@m17n.org>
3021 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3022 extra slot even if the purpose is char-code-property-table.
3024 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3026 * xdisp.c (redisplay_window): When computing centering_position,
3027 account for the height of the header line. (Bug#8874)
3029 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3030 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3031 candidate is selected by the mouse, and that candidate has a
3032 composed character under the mouse.
3034 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3035 coordinates reported by pos-visible-in-window-p for a composed
3036 character in column zero.
3038 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3040 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3042 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3044 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3045 consider it a hit if to_charpos is anywhere in the range of the
3046 composed buffer positions.
3048 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3050 * image.c (gif_load): Don't assume that each subimage has the same
3051 dimensions as the base image. Handle disposal method that is
3052 "undefined" by the gif spec (Bug#9335).
3054 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3056 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3057 (Fcondition_case): Document `debug' symbol in error handler.
3059 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3061 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3062 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3063 from an Org mode buffer to a Speedbar frame.
3065 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3066 a composition, take its buffer position from IT->cmp_it.charpos.
3067 Fixes cursor positioning at the beginning of a line that begins
3068 with a composed character.
3070 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3072 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3073 character bidirectional type, use STRONG_L instead. Fixes crashes
3074 in a buffer produced by `describe-categories'.
3076 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3077 members before the level stack, so they would be saved and
3078 restored when copying iterator state. Fixes incorrect reordering
3079 around TABs covered by display properties.
3081 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3083 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3085 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3087 * eval.c (internal_condition_case, internal_condition_case_1)
3088 (internal_condition_case_2, internal_condition_case_n):
3089 Remove unnecessary aborts (Bug#9081).
3091 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3093 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3094 has no `load' handler, try opening the file locally. (Bug#9311)
3096 2011-08-16 Ken Brown <kbrown@cornell.edu>
3098 * gmalloc.c: Expand comment.
3100 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3102 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3103 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3105 2011-08-16 Ken Brown <kbrown@cornell.edu>
3107 Fix memory allocation problems in Cygwin build (Bug#9273).
3109 * unexcw.c ( __malloc_initialized): Declare external variable.
3110 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3112 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3114 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3116 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3118 [CYGWIN] (special_realloc): New function.
3119 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3120 requests to realloc storage in the static heap.
3122 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3124 * bidi.c (bidi_initialize): Remove unused local.
3126 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3129 * biditype.h: Remove file.
3130 * makefile.w32-in ($(BLD)/bidi.$(O)):
3131 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3133 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3135 * chartab.c: Improve commentary for the uniprop_table API.
3137 * bidi.c (bidi_paragraph_init): Support zero value of
3138 bidi_ignore_explicit_marks_for_paragraph_level.
3139 (bidi_initialize): Use uniprop_table instead of including
3140 biditype.h and bidimirror.h.
3142 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3143 coordinates of the iterator when restoring from ppos_it.
3146 2011-08-14 Kenichi Handa <handa@m17n.org>
3148 * process.c (create_process): Call setup_process_coding_systems
3149 after the pid of the process is set to -1 (Bug#8162).
3151 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3153 * xdisp.c (move_it_in_display_line_to): Don't invoke
3154 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3155 ppos_it. Fixes vertical cursor motion when line beginning is
3156 covered by an image. (Bug#9296)
3158 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3160 * nsterm.h (ns_run_ascript): Declare.
3161 (NSAPP_DATA2_RUNASSCRIPT): Define.
3163 * nsfns.m (as_script, as_result, as_status): New static variables.
3164 (ns_run_ascript): New function.
3165 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3166 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3167 the event loop. Get status from as_status (Bug#7276).
3169 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3170 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3171 the event loop (Bug#7276).
3173 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3175 * gnutls.c (QCgnutls_bootprop_priority)
3176 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3177 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3178 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3179 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3180 (QCgnutls_bootprop_verify_hostname_error)
3181 (QCgnutls_bootprop_callbacks_verify): Rename from
3182 Qgnutls_bootprop_..., all uses changed.
3184 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3187 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3189 * xfaces.c (Qframe_set_background_mode): Now static.
3190 * dispextern.h (Qframe_set_background_mode): Remove decl.
3192 * process.c (Fnetwork_interface_info): Declare local only if needed.
3194 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3196 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3197 (Fnetwork_interface_list): Allocate in increments of bytes instead
3198 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3199 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3201 (struct ifflag_def): notrailers is smart on OSX.
3202 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3203 Get hardware address with getifaddrs if available.
3205 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3207 * xdisp.c (iterate_out_of_display_property): xassert that
3208 IT->position is set to within IT->object's boundaries. Break from
3209 the loop as soon as EOB is reached; avoids infloops in redisplay
3210 when IT->position is set up wrongly due to some bug.
3211 Set IT->current to match the bidi iterator unconditionally.
3212 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3213 entry. Force push_it to save on the stack the current
3214 buffer/string position, to be restored by pop_it. Fix flags in
3215 the iterator structure wrt the object coming from a display
3216 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3217 properties. (Bug#9284)
3219 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3221 * fontset.c (fontset_get_font_group): Add proper type checks.
3224 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3226 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3227 and LC_VERSION_MIN_MACOSX.
3228 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3229 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3231 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3233 * xdisp.c (forward_to_next_line_start): Allow to use the
3234 no-display-properties-and-no-overlays under bidi display.
3235 Set disp_pos in the bidi iterator to avoid searches for display
3236 properties and overlays.
3238 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3240 * editfns.c (Fset_time_zone_rule): Document relationship with the
3243 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3244 the font entity extracted from the cache (Bug#8109).
3246 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3248 * composite.c (autocmp_chars): Don't reset point. That is done by
3249 restore_point_unwind (Bug#5984).
3251 2011-08-07 Juri Linkov <juri@jurta.org>
3253 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3254 to show the arg `TIME' instead of `TIMEVAL'.
3256 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3258 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3259 display property strides EOL and includes a newline, as in
3260 longlines-mode. (Bug#9254)
3261 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3262 word-wrap under bidirectional display. (Bug#9224)
3264 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3265 is non-zero, even if the data buffer is NULL. Fixes a crash in
3266 vertical-motion with longlines-mode. (Bug#9254)
3268 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3270 * bidi.c <bidi_cache_total_alloc>: Now static.
3271 (bidi_initialize): Initialize bidi_cache_total_alloc.
3273 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3276 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3277 amount allocated this far in `bidi_cache_total_alloc'.
3278 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3279 non-zero, only free the data buffer without restoring the cache
3280 contents. All callers changed.
3282 * dispextern.h (bidi_unshelve_cache): Update prototype.
3284 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3285 (move_it_in_display_line, move_it_to)
3286 (move_it_vertically_backward, move_it_by_lines): Replace the call
3287 to xfree to an equivalent call to bidi_unshelve_cache.
3288 (move_it_in_display_line_to): Fix logic of returning
3289 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3291 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3293 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3294 came from a string character with a `cursor' property. (Bug#9229)
3296 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3298 * Makefile.in (LIB_PTHREAD): New variable.
3299 (LIBES): Add LIB_PTHREAD (Bug#9216).
3301 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3302 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3304 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3306 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3308 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3310 * xterm.c (x_find_topmost_parent): New function.
3311 (x_set_frame_alpha): Find topmost parent window with
3312 x_find_topmost_parent and set the property there also (bug#9181).
3313 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3315 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3317 * callproc.c (Fcall_process): Avoid vfork clobbering
3318 the local vars buffer, coding_systems, current_dir.
3320 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3322 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3324 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3326 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3327 so that it is not optimized away.
3329 * xdisp.c (compute_display_string_pos): Remove unused local.
3331 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3333 Fix slow cursor motion and scrolling in large buffers with
3334 selective display, like Org Mode buffers. (Bug#9218)
3336 * dispextern.h (struct bidi_it): New member disp_prop_p.
3338 * xdisp.c: Remove one-slot cache of display string positions.
3339 (compute_display_string_pos): Accept an additional argument
3340 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3341 for a display string or property. If found, set DISP_PROP_P
3344 * bidi.c (bidi_fetch_char): Accept an additional argument
3345 DISP_PROP_P, and pass it to compute_display_string_pos.
3346 Only handle text covered by a display string if DISP_PROP_P is returned
3347 non-zero. All callers of bidi_fetch_char changed.
3349 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3351 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3353 2010-12-03 Don March <don@ohspite.net>
3355 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3356 last character M-[char] is translated to ESC [char] (bug#7541).
3358 2011-08-02 Kenichi Handa <handa@m17n.org>
3360 * lisp.h (uniprop_table): Extern it.
3362 * chartab.c (uniprop_table): Make it non-static.
3364 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3366 * xdisp.c (forward_to_next_line_start): Accept additional argument
3367 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3369 (reseat_at_next_visible_line_start): Use the bidi iterator state
3370 returned by forward_to_next_line_start to restore the state of
3371 it->bidi_it after backing up to previous newline. (Bug#9212)
3373 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3375 * regex.c (re_comp): Protoize.
3376 (re_exec): Fix return type.
3377 (regexec): Fix type of `ret'. (Bug#9203)
3379 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3381 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3382 This is needed if max-image-size is a floating-point number.
3384 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3386 * print.c (print_object): Print empty symbol as ##.
3388 * lread.c (read1): Read ## as empty symbol.
3390 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3392 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3393 setting frame foreground color (Bug#9175).
3394 (x_set_background_color): Likewise.
3396 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3397 contents (Bug#9176).
3398 (EmacsTooltip -init): Remove bezels and add shadows to
3401 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3402 or scroll bar (Bug#8470).
3404 * nsfont.m (nsfont_open): Remove assignment to voffset and
3405 unnecessary vars hshink, expand, hd, full_height, min_height.
3406 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3408 * nsterm.h (nsfont_info): Remove voffset field.
3410 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3412 Implement strike-through and overline on NextStep (Bug#8863).
3414 * nsfont.m (nsfont_open): Use underline position provided by font,
3415 instead of hard-coded value of 2.
3416 (nsfont_draw): Call ns_draw_text_decoration instead.
3418 * nsterm.h: Add declaration for ns_draw_text_decoration.
3420 * nsterm.m (ns_draw_text_decoration): New function for drawing
3421 underline, overline, and strike-through.
3422 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3423 ns_draw_text_decoration. Change treatment of cursor drawing to
3424 accommodate underlining, etc.
3426 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3428 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3431 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3433 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3434 Without this fix, if a signal arrives just after memory fills up,
3435 'malloc' might be invoked reentrantly.
3437 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3438 In other words, assume that every image size is allowed, on non-X
3439 hosts. This assumption is probably wrong, but it lets Emacs compile.
3441 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3443 * regex.c (re_iswctype): Convert return values to boolean.
3445 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3447 * xdisp.c (compute_display_string_pos): Don't use cached display
3448 string position if the buffer had its restriction changed.
3451 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3453 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3455 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3457 Integer signedness and overflow and related fixes. (Bug#9079)
3459 * bidi.c: Integer size and overflow fixes.
3460 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3461 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3462 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3463 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3464 (bidi_find_other_level_edge):
3465 Use ptrdiff_t instead of EMACS_INT where either will do.
3466 This works better on 32-bit hosts configured --with-wide-int.
3467 (bidi_cache_ensure_space): Check for size-calculation overflow.
3468 Use % rather than repeated addition, for better worst-case speed.
3469 Don't set bidi_cache_size until after xrealloc returns, because it
3471 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3472 (bidi_cache_ensure_space): Also check that the bidi cache size
3473 does not exceed that of the largest Lisp string or buffer. See Eli
3474 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3476 * alloc.c (__malloc_size_t): Remove.
3477 All uses replaced by size_t. See Andreas Schwab's note
3478 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3480 * image.c: Improve checking for integer overflow.
3481 (check_image_size): Assume that f is nonnull, since
3482 it is always nonnull in practice. This is one less thing to
3483 worry about when checking for integer overflow later.
3484 (x_check_image_size): New function, which checks for integer
3485 overflow issues inside X.
3486 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3487 This removes the need for a memory_full check.
3488 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3489 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3490 (xbm_read_bitmap_data): Change locals back to 'int', since
3491 their values must fit in 'int'.
3492 (xpm_load_image, png_load, tiff_load):
3493 Invoke x_create_x_image_and_pixmap earlier,
3494 to avoid much needless work if the image is too large.
3495 (tiff_load): Treat overly large images as if
3496 x_create_x_image_and_pixmap failed, not as malloc failures.
3497 (gs_load): Use x_check_image_size.
3499 * gtkutil.c: Omit integer casts.
3500 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3501 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3503 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3505 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3506 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3507 would wrongly return t on a 64-bit host.
3509 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3510 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3511 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3512 and therefore cause GCC to emit a bogus diagnostic in some cases.
3514 * image.c: Integer signedness and overflow and related fixes.
3515 This is not an exhaustive set of fixes, but it's time to
3516 record what I've got.
3517 (lookup_pixel_color, check_image_size): Remove redundant decls.
3518 (check_image_size): Don't assume that arbitrary EMACS_INT values
3519 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3520 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3521 (tiff_load, imagemagick_load_image):
3522 Check for overflow in size calculations.
3523 (x_create_x_image_and_pixmap): Remove unnecessary test for
3524 xmalloc returning NULL; that can't happen.
3525 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3526 (xpm_color_bucket): Use better integer hashing function.
3527 (xpm_cache_color): Don't possibly over-allocate memory.
3528 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3529 (gif_memory_source):
3530 Use ptrdiff_t, not int or size_t, to record sizes.
3531 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3532 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3533 either works, as we prefer signed integers.
3534 (tiff_read_from_memory, tiff_write_from_memory):
3535 Return tsize_t, not size_t, since that's what the TIFF API wants.
3536 (tiff_read_from_memory): Don't fail simply because the read would
3537 go past EOF; instead, return a short read.
3538 (tiff_load): Omit no-longer-needed casts.
3539 (Fimagemagick_types): Don't assume size fits into 'int'.
3541 Improve hashing quality when configured --with-wide-int.
3542 * fns.c (hash_string): New function, taken from sxhash_string.
3543 Do not discard information about ASCII character case; this
3544 discarding is no longer needed.
3545 (sxhash-string): Use it. Change sig to match it. Caller changed.
3546 * lisp.h: Declare it.
3547 * lread.c (hash_string): Remove, since we now use fns.c's version.
3548 The fns.c version returns a wider integer if --with-wide-int is
3549 specified, so this should help the quality of the hashing a bit.
3551 * emacs.c: Integer overflow minor fix.
3552 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3553 Define only if GNU_LINUX.
3554 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3556 * dispnew.c: Integer signedness and overflow fixes.
3557 Remove unnecessary forward decls, that were a maintenance hassle.
3558 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3560 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3561 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3562 (prepare_desired_row, line_draw_cost):
3563 Use int, not unsigned, where either works.
3564 (save_current_matrix, restore_current_matrix):
3565 Use ptrdiff_t, not size_t, where either works.
3566 (init_display): Check for overflow more accurately, and without
3567 relying on undefined behavior.
3569 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3570 Remove, replacing with the new symbols in lisp.h. All uses changed.
3571 * fileio.c (make_temp_name):
3572 * filelock.c (lock_file_1, lock_file):
3573 * xdisp.c (message_dolog):
3574 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3575 Use pMd etc. instead.
3576 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3577 replacing the pWIDE etc. symbols removed from editfns.c.
3579 * keyboard.h (num_input_events): Now uintmax_t.
3580 This is (very slightly) less likely to mess up due to wraparound.
3583 * buffer.c: Integer signedness fixes.
3584 (alloc_buffer_text, enlarge_buffer_text):
3585 Use ptrdiff_t rather than size_t when either will do, as we prefer
3588 * alloc.c: Integer signedness and overflow fixes.
3589 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3590 (__malloc_size_t): Default to size_t, not to int.
3591 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3592 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3593 Prefer ptrdiff_t to size_t when either would do, as we prefer
3595 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3596 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3597 Now const. Initialize with values that are in range even if char
3599 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3600 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3601 These functions do the right thing with sizes > 2**32.
3602 (check_depth): Now ptrdiff_t, not int.
3603 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3604 Adjust to new way of storing sizes. Check for size overflow bugs
3606 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3607 slightly wrong anyway, as it missed one instance of
3608 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3609 (refill_memory_reserve): Omit needless cast to size_t.
3610 (mark_object_loop_halt): Mark as externally visible.
3612 * xselect.c: Integer signedness and overflow fixes.
3613 (Fx_register_dnd_atom, x_handle_dnd_message):
3614 Use ptrdiff_t, not size_t, since we prefer signed.
3615 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3616 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3617 x_dnd_atoms_size and x_dnd_atoms_length.
3619 * doprnt.c: Prefer signed to unsigned when either works.
3621 * doprnt.c (doprnt):
3623 * xdisp.c (vmessage):
3624 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3625 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3626 prefer signed arithmetic to avoid comparison confusion.
3627 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3628 but is a bit tricky.
3630 Assume freestanding C89 headers, string.h, stdlib.h.
3631 * data.c, doprnt.c, floatfns.c, print.c:
3632 Include float.h unconditionally.
3633 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3634 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3635 * regex.c: Likewise for stddef.h, string.h.
3636 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3637 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3638 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3639 (STDC_HEADERS): Remove obsolete defines.
3640 * sysdep.c: Include limits.h unconditionally.
3642 Assume support for memcmp, memcpy, memmove, memset.
3643 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3644 * regex.c (memcmp, memcpy):
3645 Remove; we assume C89 now.
3647 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3648 (__malloc_safe_bcopy): Remove; no longer needed.
3650 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3651 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3652 well either way, and we prefer signed to unsigned.
3654 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3656 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3657 closes the connection while we're reading (bug#9182).
3659 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3661 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3662 are specified (Bug#9168).
3664 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3666 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3667 Found by GCC static checking and --with-wide-int on a 32-bit host.
3669 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3671 * xdisp.c (compute_display_string_pos): Fix logic of caching
3672 previous display string position. Initialize cached_prev_pos to
3673 -1. Fixes slow-down at the beginning of a buffer.
3675 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3677 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3678 for attrs[LFACE_FONTSET_INDEX].
3680 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3682 * xml.c (parse_region): Remove unused local
3683 that was recently introduced.
3685 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3687 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3688 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3690 * xdisp.c (move_it_in_display_line_to): Record the best matching
3691 position for TO_CHARPOS while scanning the line, and restore it on
3692 exit if none of the characters scanned was an exact match.
3693 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3694 when exact match is impossible due to invisible text, and the
3695 lines are truncated.
3697 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3699 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3702 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3704 Fix a significant slow-down of cursor motion with C-n, C-p,
3705 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3706 auto-repeat under bidi redisplay in fontified buffers.
3707 * xdisp.c (compute_stop_pos_backwards): New function.
3708 (next_element_from_buffer): Call compute_stop_pos_backwards to
3709 find a suitable prev_stop when we find ourselves before
3711 (reseat): Don't look for prev_stop, as that could mean a very long
3713 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3714 <cached_disp_overlay_modiff>: Cache for last found display string
3716 (compute_display_string_pos): Return the cached position if asked
3717 about the same buffer in the same area of character positions, and
3718 the buffer wasn't changed since the time the display string
3719 position was cached.
3721 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3723 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3724 is an integer, which is important for empty lines. (Bug#9149)
3726 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3728 * frame.c (Fmodify_frame_parameters): In tty case, update the
3729 default face if necessary (Bug#4238).
3731 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3733 * editfns.c (Fstring_to_char): No need to explain what a character
3734 is in the docstring (Bug#6576).
3736 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3738 * xml.c (parse_region): Make sure we always return a tree.
3740 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3742 * xml.c (parse_region): If a document contains only comments,
3745 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3747 * xml.c (make_dom): Return comments, too.
3749 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3752 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3753 and the surrounding thread.
3754 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3755 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3756 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3758 * s/openbsd.h (BROKEN_SIGIO): Define.
3759 * unexelf.c (unexec) [__OpenBSD__]:
3760 Don't update the .mdebug section of the Alpha COFF symbol table.
3762 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3764 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3767 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3769 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3770 This fixes some race conditions on the permissions of any newly
3773 * alloc.c (valid_pointer_p): Use pipe, not open.
3774 This fixes some permissions issues when debugging.
3776 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3777 If fchown fails to set both uid and gid, try to set just gid,
3778 as that is sometimes allowed. Adjust the file's mode to eliminate
3779 setuid or setgid bits that are inappropriate if fchown fails.
3781 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3783 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3784 to compare Lisp_Objects.
3785 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3786 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3787 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3789 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3791 * lread.c (read_integer): Unread even EOF character.
3792 (read1): Likewise. Properly record start position of symbol.
3794 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3795 symbol character follows.
3797 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3799 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3800 This works around a problem with the previous change to Fcopy_file.
3801 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3802 and without this change, GCC might complain about discarding
3803 fchown's return value.
3805 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3807 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3809 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3811 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3813 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3815 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3816 it's used from the C level.
3818 * process.c: Use the same condition for POLL_FOR_INPUT in both
3819 keyboard.c and process.c (bug#1858).
3821 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3823 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3824 (Fgnutls_boot): Use it.
3826 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3828 * doc.c (Fsubstitute_command_keys): Revert last change.
3830 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3832 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3833 quotes the next character, and doesn't affect other longer
3834 sequences (bug#8935).
3836 * lread.c (syms_of_lread): Clarify that is isn't only
3837 `eval-buffer' and `eval-defun' that's affected by
3838 `lexical-binding' (bug#8460).
3840 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3842 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3843 bidi redisplay when a line includes both an image and is truncated.
3845 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3847 Fix minor problems found by static checking.
3848 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3849 (elsz): Now a signed constant, not a size_t var. We prefer signed
3850 types to unsigned, to avoid integer comparison confusion. Without
3851 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3852 "cannot optimize loop, the loop counter may overflow", a symptom
3854 * indent.c (Fvertical_motion): Mark locals as initialized.
3855 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3857 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3859 * search.c (Fre_search_backward): Mention `case-fold-search' in
3860 all the re_search_* functions (bug#8138).
3862 * keyboard.c (Fopen_dribble_file): Document when the file is
3865 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3867 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3870 Support bidi reordering of display and overlay strings.
3871 * xdisp.c (compute_display_string_pos)
3872 (compute_display_string_end): Accept additional argument STRING.
3873 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3874 (reseat_to_string): Initialize bidi_it->string.s and
3875 bidi_it->string.schars.
3876 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3877 NULL (avoids a crash in bidi_paragraph_init).
3878 Initialize itb.string.lstring.
3879 (init_iterator): Call bidi_init_it only of a valid
3880 buffer position was specified. Initialize paragraph_embedding to
3882 (reseat_to_string): Initialize the bidi iterator.
3883 (display_string): If we need to ignore text properties of
3884 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3885 original value of -1 will not work with bidi.)
3886 (compute_display_string_pos): First arg is now struct
3887 `text_pos *'; all callers changed. Support display properties on
3889 (compute_display_string_end): Support display properties on Lisp
3891 (init_iterator, reseat_1, reseat_to_string): Initialize the
3892 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3893 when iterating on a string not from display properties).
3894 (compute_display_string_pos, compute_display_string_end):
3895 Fix calculation of the object to scan. Fixes an error when using
3897 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3898 base_level_stop; instead, set base_level_stop to BEGV.
3899 Fixes crashes in vertical-motion.
3900 (next_element_from_buffer): Improve commentary for when
3901 the iterator is before prev_stop.
3902 (init_iterator): Initialize bidi_p from the default value of
3903 bidi-display-reordering, not from buffer-local value. Use the
3904 buffer-local value only if initializing for buffer iteration.
3905 (handle_invisible_prop): Support invisible properties on strings
3906 that are being bidi-reordered.
3907 (set_iterator_to_next): Support bidi reordering of C strings and
3909 (next_element_from_string): Support bidi reordering of Lisp
3911 (handle_stop_backwards): Support Lisp strings as well.
3912 (display_string): Support display of R2L glyph rows.
3913 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3914 (init_iterator): Don't initialize it->bidi_p for strings
3916 (reseat_to_string): Initialize it->bidi_p for strings here.
3917 (next_element_from_string, next_element_from_c_string)
3918 (next_element_from_buffer): Add xassert's for correspondence
3919 between IT's object being iterated and it->bidi_it.string
3921 (face_before_or_after_it_pos): Support bidi iteration.
3922 (next_element_from_c_string): Handle the case of the first string
3923 character that is not the first one in the visual order.
3924 (get_visually_first_element): New function, refactored from common
3925 parts of next_element_from_buffer, next_element_from_string, and
3926 next_element_from_c_string.
3927 (tool_bar_lines_needed, redisplay_tool_bar)
3928 (display_menu_bar): Force left-to-right direction. Add a FIXME
3929 comment for making that be controlled by a user option.
3930 (push_it, pop_it): Save and restore the state of the
3931 bidi iterator. Save and restore the bidi_p flag.
3932 (pop_it): Iterate out of display property for string iteration as
3934 (iterate_out_of_display_property): Support iteration over strings.
3935 (handle_single_display_spec): Set up it->bidi_it for iteration
3936 over a display string, and call bidi_init_it.
3937 (handle_single_display_spec, next_overlay_string)
3938 (get_overlay_strings_1, push_display_prop): Set up the bidi
3939 iterator for displaying display or overlay strings.
3940 (forward_to_next_line_start): Don't use the shortcut if
3942 (back_to_previous_visible_line_start): If handle_display_prop
3943 pushed the iterator stack, restore the internal state of the bidi
3944 iterator by calling bidi_pop_it same number of times.
3945 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3946 and we are bidi-iterating, don't decrement the iterator position;
3947 instead, set the first_elt flag in the bidi iterator, to produce
3949 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3950 (push_display_prop): xassert that we are iterating a buffer.
3951 (push_it, pop_it): Save and restore paragraph_embedding member.
3952 (handle_single_display_spec, next_overlay_string)
3953 (get_overlay_strings_1, reseat_1, reseat_to_string)
3954 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3955 correctly. Don't assume unibyte strings are not bidi-reordered.
3956 (compute_display_string_pos)
3957 (compute_display_string_end): Fix handling the case of C string.
3958 (push_it, pop_it): Save and restore from_disp_prop_p.
3959 (handle_single_display_spec, push_display_prop): Set the
3960 from_disp_prop_p flag.
3961 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3962 (pop_it): Call iterate_out_of_display_property only if we are
3963 popping after iteration over a string that came from a display
3964 property. Fix a typo in popping stretch info. Add an assertion
3965 for verifying that the iterator position is in sync with the bidi
3967 (handle_single_display_spec, get_overlay_strings_1)
3968 (push_display_prop): Fix initialization of paragraph direction for
3969 string when that of the parent object is not yet determined.
3970 (reseat_1): Call bidi_init_it to resync the bidi
3971 iterator with IT's position. (Bug#7616)
3972 (find_row_edges): If ROW->start.pos gives position
3973 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3974 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3975 Reset the from_disp_prop_p flag.
3976 (SAVE_IT, RESTORE_IT): New macros.
3977 (pos_visible_p, face_before_or_after_it_pos)
3978 (back_to_previous_visible_line_start)
3979 (move_it_in_display_line_to, move_it_in_display_line)
3980 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3981 (try_scrolling, redisplay_window, display_line): Use them when
3982 saving a temporary copy of the iterator and restoring it back.
3983 (back_to_previous_visible_line_start, reseat_1)
3984 (init_iterator): Empty the bidi cache "stack".
3985 (move_it_in_display_line_to): If iterator ended up at
3986 EOL, but we never saw any buffer positions smaller than
3987 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3988 motion in bidi-reordered lines.
3989 (move_it_in_display_line_to): Record prev_method and prev_pos
3990 immediately before the call to set_iterator_to_next. Fixes cursor
3991 motion in bidi-reordered lines with stretch glyphs and strings
3992 displayed in margins. (Bug#8133) (Bug#8867)
3993 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3995 (pos_visible_p): Support positions in bidi-reordered lines.
3996 Save and restore bidi cache.
3998 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3999 (bidi_paragraph_info): Delete unused struct.
4000 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4001 (bidi_cache_start): New variable.
4002 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4004 (bidi_cache_fetch_state, bidi_cache_search)
4005 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4006 (bidi_cache_find, bidi_peek_at_next_level)
4007 (bidi_level_of_next_char, bidi_find_other_level_edge)
4008 (bidi_move_to_visually_next): Compare cache index with
4009 bidi_cache_start rather than with zero.
4010 (bidi_fetch_char): Accept new argument STRING; all callers
4011 changed. Support iteration over a string. Support strings with
4012 display properties. Support unibyte strings. Fix the type of
4013 `len' according to what STRING_CHAR_AND_LENGTH expects.
4014 (bidi_paragraph_init, bidi_resolve_explicit_1)
4015 (bidi_resolve_explicit, bidi_resolve_weak)
4016 (bidi_level_of_next_char, bidi_move_to_visually_next):
4017 Support iteration over a string.
4018 (bidi_set_sor_type, bidi_resolve_explicit_1)
4019 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4020 can now be zero (for strings); special values 0 and -1 were
4021 changed to -1 and -2, respectively.
4022 (bidi_char_at_pos): New function.
4023 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4024 Call it instead of FETCH_MULTIBYTE_CHAR.
4025 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4026 initialized to valid values.
4027 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4029 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4030 the test for valid cached positions. Fix the logic for looking up
4031 the sentinel state in the cache. GCPRO the Lisp string we are
4033 (bidi_push_it, bidi_pop_it): New functions.
4034 (bidi_initialize): Initialize the bidi cache start stack pointer.
4035 (bidi_cache_ensure_space): New function, refactored from part of
4036 bidi_cache_iterator_state. Don't assume the required size is just
4037 one BIDI_CACHE_CHUNK away.
4038 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4039 (bidi_count_bytes, bidi_char_at_pos): New functions.
4040 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4041 always valid if bidi_cache_idx is valid.
4042 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4043 is valid if it's going to be used.
4044 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4045 (bidi_cache_fetch_state, bidi_cache_search)
4046 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4047 (bidi_cache_iterator_state, bidi_cache_find)
4048 (bidi_find_other_level_edge, bidi_cache_start_stack):
4049 All variables related to cache indices are now EMACS_INT.
4051 * dispextern.h (struct bidi_string_data): New structure.
4052 (struct bidi_it): New member `string'. Make flag members be 1-bit
4053 fields, and put them last in the struct.
4054 (compute_display_string_pos, compute_display_string_end):
4056 (bidi_push_it, bidi_pop_it): Add prototypes.
4057 (struct iterator_stack_entry): New members bidi_p,
4058 paragraph_embedding, and from_disp_prop_p.
4059 (struct it): Member bidi_p is now a bit field 1 bit wide.
4060 (bidi_shelve_cache, bidi_unshelve_cache):
4063 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4064 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4065 and vector-like objects.
4067 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4068 cache around display iteration.
4070 * window.c (Fwindow_end, window_scroll_pixel_based)
4071 (displayed_window_lines, Frecenter): Save and restore the bidi
4072 cache around display iteration.
4074 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4076 * editfns.c (Fdelete_region): Clarify the use of the named
4077 parameters (bug#6788).
4079 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4081 * indent.c (Fvertical_motion): Set and restore w->pointm when
4082 saving and restoring the window's buffer (Bug#9006).
4084 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4086 * editfns.c (Fstring_to_char): Clarify just what is returned
4087 (bug#6576). Text by Eli Zaretskii.
4089 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4091 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4093 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4095 * buffer.c (mmap_find): Fix a typo.
4097 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4099 Fix execution of x selection hooks.
4100 * xselect.c (Qx_lost_selection_functions)
4101 (Qx_sent_selection_functions): New vars.
4102 (syms_of_xselect): DEFSYM them.
4103 (x_handle_selection_request): Pass Qx_sent_selection_functions
4104 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4105 (x_handle_selection_clear,x_clear_frame_selections):
4106 Pass Qx_lost_selection_functions rather than
4107 Vx_lost_selection_functions to Frun_hook_with_args.
4109 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4111 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4112 The old code sometimes used this field without initializing it.
4114 * alloc.c (gc_sweep): Don't read past end of array.
4115 In theory, the old code could also have corrupted Emacs internals,
4116 though it'd be very unlikely.
4118 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4120 * character.c (Fcharacterp): Don't advertise optional ignored
4121 argument. (Bug#4026)
4123 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4125 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4128 * window.c (Fset_window_start): Doc fix (bug#4199).
4129 (Fset_window_hscroll): Ditto.
4131 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4133 Fix minor new problems caught by GCC 4.6.1.
4134 * term.c (init_tty): Remove unused local.
4135 * xsettings.c (store_monospaced_changed): Define this function only
4136 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4139 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4141 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4143 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4145 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4146 are the mini-buffer and the echo area (bug#3320).
4148 * term.c (init_tty): Remove support for supdup, c10 and perq
4149 terminals, which are no longer supported (bug#1482).
4151 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4153 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4155 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4157 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4158 for non-popups (Bug#3642).
4160 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4162 * alloc.c (reset_malloc_hooks): Protoize.
4163 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4164 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4165 * cm.c (losecursor): Likewise.
4166 * data.c (fmod): Likewise.
4167 * dispnew.c (swap_glyphs_in_rows): Likewise.
4168 * emacs.c (memory_warning_signal): Likewise.
4169 * floatfns.c (float_error): Likewise.
4170 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4171 (otf_open, font_otf_capability, generate_otf_features)
4172 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4174 * image.c (pbm_read_file): Likewise.
4175 * indent.c (string_display_width): Likewise.
4176 * intervals.c (check_for_interval, search_for_interval)
4177 (inc_interval_count, count_intervals, root_interval)
4178 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4179 * lread.c (defalias): Likewise.
4180 * ralloc.c (r_alloc_check): Likewise.
4181 * regex.c (set_image_of_range_1, set_image_of_range)
4182 (regex_grow_registers): Likewise.
4183 * sysdep.c (strerror): Likewise.
4184 * termcap.c (valid_filename_p, tprint, main): Likewise.
4185 * tparam.c (main): Likewise.
4186 * unexhp9k800.c (run_time_remap, save_data_space)
4187 (update_file_ptrs, read_header, write_header, calculate_checksum)
4188 (copy_file, copy_rest, display_header): Likewise.
4189 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4191 * xdisp.c (check_it): Likewise.
4192 * xfaces.c (register_color, unregister_color, unregister_colors):
4194 * xfns.c (print_fontset_result): Likewise.
4195 * xrdb.c (member, fatal, main): Likewise.
4197 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4199 Fix minor problems found by static checking (Bug#9031).
4200 * chartab.c (char_table_set_range, map_sub_char_table):
4201 Remove unused locals.
4202 (uniprop_table): Now static.
4203 * composite.c (_work_char): Remove unused static var.
4205 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4207 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4209 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4211 * gtkutil.c (qttip_cb): Remove code without function.
4213 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4215 * w32.c (pthread_sigmask): New stub.
4217 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4219 Use pthread_sigmask, not sigprocmask (Bug#9010).
4220 sigprocmask is portable only for single-threaded applications, and
4221 Emacs can be multi-threaded when it uses GTK.
4222 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4224 * callproc.c (Fcall_process):
4225 * process.c (create_process):
4226 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4227 Use pthread_sigmask, not sigprocmask.
4229 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4231 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4232 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4235 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4237 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4238 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4239 (xg_hide_tooltip): Fix comment.
4241 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4242 in registerServicesMenuSendTypes.
4243 (validRequestorForSendType): Don't check ns_return_types.
4245 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4248 2011-07-08 Jason Rumney <jasonr@gnu.org>
4250 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4251 SH_SHOW for hidden windows (Bug#5482).
4253 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4254 frame struct members of non-existent frames (Bug#6284).
4256 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4258 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4259 variable firstTime not needed on OSX >= 10.6.
4260 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4261 >= 10.5. Use setKnobProportion, setDoubleValue.
4263 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4264 (MAC_OS_X_VERSION_10_5): Define if not defined.
4265 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4266 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4267 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4269 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4270 cString and lossyCString on OSX >= 10.4
4272 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4273 sizeToFit on OSX >= 10.2.
4275 * nsimage.m (allocInitFromFile): Don't use deprecated method
4276 bestRepresentationForDevice on OSX >= 10.6.
4278 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4281 * emacs.c: Declare unexec_init_emacs_zone.
4283 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4285 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4287 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4288 on svcsMenu (Bug#8842).
4290 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4292 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4294 * nsterm.m (QUTF8_STRING): Declare.
4295 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4296 (validRequestorForSendType): Return type is (id).
4297 Change indexOfObjectIdenticalTo to indexOfObject.
4298 Check if we have local selection before returning self (Bug#8842).
4299 (writeSelectionToPasteboard): Put local selection into paste board
4300 if we have a local selection (Bug#8842).
4301 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4303 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4304 (ns_get_local_selection): Declare.
4306 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4308 * keymap.c (describe_map_tree): Don't insert a double newline at
4309 the end of the buffer (bug#1169) and return whether we inserted
4312 * callint.c (Fcall_interactively): Change "reading args" to
4313 "providing args" to try to clarify what it does (bug#1010).
4315 2011-07-07 Kenichi Handa <handa@m17n.org>
4317 * composite.c (composition_compute_stop_pos): Ignore a static
4318 composition starting before CHARPOS (Bug#8915).
4320 * xdisp.c (handle_composition_prop): Likewise.
4322 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4324 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4327 2011-07-07 Kenichi Handa <handa@m17n.org>
4329 * character.h (unicode_category_t): New enum type.
4331 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4332 (Qchar_code_property_table): New variable.
4333 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4334 (UNIPROP_COMPRESSED_FORM_P): New macros.
4335 (char_table_ascii): Uncompress the compressed values.
4336 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4337 Uncompress the compressed values.
4338 (sub_char_table_ref_and_range): Likewise.
4339 (char_table_ref_and_range): Uncompress the compressed values.
4340 (sub_char_table_set): New arg is_uniprop. Callers changed.
4341 Uncompress the compressed values.
4342 (sub_char_table_set_range): Args changed. Callers changed.
4343 (char_table_set_range): Adjuted for the above change.
4344 (map_sub_char_table): Delete args default_val and parent. Add arg
4345 top. Give decoded values to a Lisp function.
4346 (map_char_table): Adjust for the above change. Give decoded
4347 values to a Lisp function. Gcpro more variables.
4348 (uniprop_table_uncompress)
4349 (uniprop_decode_value_run_length): New functions.
4350 (uniprop_decoder, uniprop_decoder_count): New variables.
4351 (uniprop_get_decoder, uniprop_encode_value_character)
4352 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4354 (uniprop_encoder, uniprop_encoder_count): New variables.
4355 (uniprop_get_encoder, uniprop_table)
4356 (Funicode_property_table_internal, Fget_unicode_property_internal)
4357 (Fput_unicode_property_internal): New functions.
4358 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4359 Sunicode_property_table_internal, Sget_unicode_property_internal,
4360 and Sput_unicode_property_internal. Defvar_lisp
4361 char-code-property-alist.
4363 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4364 Vunicode_category_table.
4366 * font.c (font_range): Adjust for the change of
4367 Vunicode_category_table.
4369 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4371 * m/iris4d.h: Remove file, move contents ...
4372 * s/irix6-5.h: ... here.
4374 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4376 Remove unportable assumption about struct layout (Bug#8884).
4377 * alloc.c (mark_buffer):
4378 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4379 (clone_per_buffer_values): Don't assume that
4380 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4381 This isn't true in general, and it's particularly not true
4382 if Emacs is configured with --with-wide-int.
4383 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4384 New macros, used in the buffer.c change.
4386 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4388 * xsettings.c: Use both GConf and GSettings if both are available.
4389 (store_config_changed_event): Add comment.
4390 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4391 (store_tool_bar_style_changed): New functions.
4392 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4393 (struct xsettings): Move font inside HAVE_XFT.
4394 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4395 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4396 Move inside HAVE_XFT.
4397 (something_changed_gsettingsCB): Rename from something_changedCB.
4398 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4400 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4401 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4402 (something_changed_gconfCB): Rename from something_changedCB.
4403 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4404 (parse_settings): Move check for font inside HAVE_XFT.
4405 (read_settings, apply_xft_settings): Add comment.
4406 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4407 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4408 call store_font_name_changed.
4409 (xft_settings_event): Add comment.
4410 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4411 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4412 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4413 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4414 (xsettings_initialize): Call init_gsettings last.
4415 (xsettings_get_system_font, xsettings_get_system_normal_font):
4418 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4420 Random fixes. E.g., (random) never returned negative values.
4421 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4422 subseconds part to the entropy, as that's a bit more random.
4423 Prefer signed to unsigned, since the signedness doesn't matter and
4424 in general we prefer signed. When given a limit, use a
4425 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4426 latter isn't right if USE_2_TAGS_FOR_INTS.
4427 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4428 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4430 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4432 * textprop.c (text_property_stickiness):
4433 Obey Vtext_property_default_nonsticky.
4434 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4435 * w32fns.c (syms_of_w32fns):
4436 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4438 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4440 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4441 This is more efficient than Ffile_directory_p and avoids a minor race.
4443 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4445 * buffer.c (Foverlay_put): Say what the return value is
4448 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4449 is a directory before asking whether to use the file name
4451 (barf_or_query_if_file_exists): Make the "File is a directory"
4452 error be more correct.
4454 * fns.c (Frequire): Remove the mention of the .gz files, since
4455 that's installation-specific, but keep the mention of
4456 `get-load-suffixes'.
4458 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4460 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4461 Report string overflow if the output is too long.
4463 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4465 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4466 (syms_of_gnutls): Remove duplicate DEFSYM for
4467 Qgnutls_bootprop_verify_hostname_error, an error for
4468 Qgnutls_bootprop_verify_error (which is no longer used).
4470 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4471 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4472 Also (re)move comments that are misplaced or no longer relevant.
4474 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4476 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4478 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4480 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4481 and background color parameters if they have been changed.
4483 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4485 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4487 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4489 * xsettings.c (SYSTEM_FONT): Define only when used.
4490 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4492 * keymap.c (access_keymap_1): Now static.
4494 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4496 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4497 leave any prefix arg for the up event (Bug#1586).
4499 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4501 * lread.c (syms_of_lread): Mention single symbols defined by
4502 `defvar' or `defconst' (bug#7154).
4504 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4505 (Frequire): Mention get-load-suffixes.
4507 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4509 * window.h (window): Remove clone_number slot.
4510 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4512 (make_parent_window, make_window, saved_window)
4513 (Fset_window_configuration, save_window_save): Don't deal with
4515 * buffer.c (Qclone_number): Remove declaration.
4516 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4518 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4520 Add multiple inheritance to keymaps.
4521 * keymap.c (Fmake_composed_keymap): New function.
4522 (Fset_keymap_parent): Simplify.
4523 (fix_submap_inheritance): Remove.
4524 (access_keymap_1): New function extracted from access_keymap to handle
4525 embedded parents and handle lists of maps.
4526 (access_keymap): Use it.
4527 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4528 (Fcopy_keymap): Handle embedded parents.
4529 (Fcommand_remapping, define_as_prefix): Simplify.
4530 (Fkey_binding): Simplify.
4531 (syms_of_keymap): Move minibuffer-local-completion-map,
4532 minibuffer-local-filename-completion-map,
4533 minibuffer-local-must-match-map, and
4534 minibuffer-local-filename-must-match-map to Elisp.
4535 (syms_of_keymap): Defsubr make-composed-keymap.
4536 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4537 (parse_menu_item): Trivial simplification.
4539 2011-07-01 Glenn Morris <rgm@gnu.org>
4541 * Makefile.in (SETTINGS_LIBS): Fix typo.
4543 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4545 * coding.c (Fencode_coding_string): Record the last coding system
4546 used, as the function doc string says (bug#8738).
4548 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4550 * xsettings.c (store_monospaced_changed): Take new font as arg and
4551 check for change against current_mono_font.
4552 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4553 (emacs_settings_constructor, emacs_settings_get_property)
4554 (emacs_settings_set_property, emacs_settings_class_init)
4555 (emacs_settings_init, gsettings_obj): Remove.
4556 (something_changedCB): New function for HAVE_GSETTINGS.
4557 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4558 with value as argument.
4559 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4560 g_settings_new (Bug#8967). Do not create gsettings_obj.
4561 Remove calls to g_settings_bind. Connect something_changedCB to
4564 * xgselect.c: Add defined (HAVE_GSETTINGS).
4565 (xgselect_initialize): Ditto.
4567 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4568 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4571 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4573 * eval.c (struct backtrace): Simplify and port the data structure.
4574 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4575 signed bit field, as this assumption is not portable and it makes
4576 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4577 "char debug_on_exit : 1" as this is not portable either; instead,
4578 use the portable "unsigned int debug_on_exit : 1". Remove unused
4579 member evalargs. Remove obsolete comments about cc bombing out.
4581 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4583 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4584 Let HAVE_GSETTINGS override HAVE_GCONF.
4585 (store_monospaced_changed): New function.
4586 (EMACS_SETTINGS): A new type derived from GObject to handle
4587 GSettings notifications.
4588 (emacs_settings_constructor, emacs_settings_get_property)
4589 (emacs_settings_set_property, emacs_settings_class_init):
4591 (gsettings_client, gsettings_obj): New variables.
4592 (GSETTINGS_SCHEMA): New define.
4593 (something_changedCB): Call store_monospaced_changed.
4594 (init_gsettings): New function.
4595 (xsettings_initialize): Call init_gsettings.
4596 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4599 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4602 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4604 * window.c (resize_root_window, grow_mini_window)
4605 (shrink_mini_window): Rename Qresize_root_window to
4606 Qwindow_resize_root_window and Qresize_root_window_vertically to
4607 Qwindow_resize_root_window_vertically.
4609 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4611 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4613 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4615 * makefile.w32-in: Redesign dependencies so they reflect more
4616 clearly which files are directly included by each source file,
4617 and not through other includes.
4619 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4621 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4622 (sort_overlays, overlay_strings): When an overlay's clone number
4623 matches the window's clone number process the overlay even if
4624 the overlay's window property doesn't match the current window.
4626 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4627 (Fwindow_hchild): Rename to Fwindow_left_child.
4628 (Fwindow_next): Rename to Fwindow_next_sibling.
4629 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4630 (resize_window_check): Rename to window_resize_check.
4631 (resize_window_apply): Rename to window_resize_apply.
4632 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4633 (Fdelete_other_windows_internal, resize_frame_windows)
4634 (Fsplit_window_internal, Fdelete_window_internal)
4635 (grow_mini_window, shrink_mini_window)
4636 (Fresize_mini_window_internal): Fix callers accordingly.
4638 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4640 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4641 (emacs_fixed_set_min_size): Remove.
4642 (emacs_fixed_new): Take frame as argument.
4644 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4645 (_EmacsFixedPrivate): Remove minwidth/height.
4646 Add struct frame *f.
4647 (emacs_fixed_init): Initialize priv->f.
4648 (get_parent_class, emacs_fixed_set_min_size): Remove.
4649 (emacs_fixed_new): Set priv->f to argument.
4650 (emacs_fixed_get_preferred_width)
4651 (emacs_fixed_get_preferred_height): Use min_width/height from
4652 frames size_hint to set minimum and natural (Bug#8919).
4653 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4654 and use min_width/height from frames size_hint to set
4655 min_width/height (Bug#8919).
4657 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4658 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4661 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4663 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4664 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4667 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4669 * process.c (wait_reading_process_output): Bypass select if
4670 waiting for a cell while ignoring keyboard input, and input is
4671 pending. Suggested by Jan Djärv (Bug#8869).
4673 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4675 Use gnulib's dup2 module instead of rolling our own.
4676 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4678 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4680 * dispnew.c (scrolling_window): Before scrolling, turn off a
4681 mouse-highlight in the window being scrolled.
4683 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4685 Move DEFSYM to lisp.h and use everywhere.
4687 * character.h (DEFSYM): Move declaration...
4688 * lisp.h (DEFSYM): ...here.
4694 * w32select.c: Don't include character.h.
4696 * alloc.c (syms_of_alloc):
4697 * buffer.c (syms_of_buffer):
4698 * bytecode.c (syms_of_bytecode):
4699 * callint.c (syms_of_callint):
4700 * casefiddle.c (syms_of_casefiddle):
4701 * casetab.c (init_casetab_once):
4702 * category.c (init_category_once, syms_of_category):
4703 * ccl.c (syms_of_ccl):
4704 * cmds.c (syms_of_cmds):
4705 * composite.c (syms_of_composite):
4706 * dbusbind.c (syms_of_dbusbind):
4707 * dired.c (syms_of_dired):
4708 * dispnew.c (syms_of_display):
4709 * doc.c (syms_of_doc):
4710 * editfns.c (syms_of_editfns):
4711 * emacs.c (syms_of_emacs):
4712 * eval.c (syms_of_eval):
4713 * fileio.c (syms_of_fileio):
4714 * fns.c (syms_of_fns):
4715 * frame.c (syms_of_frame):
4716 * fringe.c (syms_of_fringe):
4717 * insdel.c (syms_of_insdel):
4718 * keymap.c (syms_of_keymap):
4719 * lread.c (init_obarray, syms_of_lread):
4720 * macros.c (syms_of_macros):
4721 * msdos.c (syms_of_msdos):
4722 * print.c (syms_of_print):
4723 * process.c (syms_of_process):
4724 * search.c (syms_of_search):
4725 * sound.c (syms_of_sound):
4726 * syntax.c (init_syntax_once, syms_of_syntax):
4727 * terminal.c (syms_of_terminal):
4728 * textprop.c (syms_of_textprop):
4729 * undo.c (syms_of_undo):
4730 * w32.c (globals_of_w32):
4731 * window.c (syms_of_window):
4732 * xdisp.c (syms_of_xdisp):
4733 * xfaces.c (syms_of_xfaces):
4734 * xfns.c (syms_of_xfns):
4735 * xmenu.c (syms_of_xmenu):
4736 * xsettings.c (syms_of_xsettings):
4737 * xterm.c (syms_of_xterm): Use DEFSYM.
4739 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4741 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4743 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4745 Integer and buffer overflow fixes (Bug#8873).
4747 * print.c (printchar, strout): Check for string overflow.
4748 (PRINTPREPARE, printchar, strout):
4749 Don't set size unless allocation succeeds.
4751 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4752 for sizes. Check for string overflow more accurately.
4753 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4755 * macros.c: Integer and buffer overflow fixes.
4756 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4757 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4758 Use ptrdiff_t, not int, for sizes.
4759 Don't increment bufsize until after realloc succeeds.
4760 Check for size-calculation overflow.
4761 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4763 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4765 * lread.c: Integer overflow fixes.
4766 (read_integer): Radix is now EMACS_INT, not int,
4767 to improve quality of diagnostics for out-of-range radices.
4768 Calculate buffer size correctly for out-of-range radices.
4769 (read1): Check for integer overflow in radices, and in
4770 read-circle numbers.
4771 (read_escape): Avoid int overflow.
4772 (Fload, openp, read_buffer_size, read1)
4773 (substitute_object_recurse, read_vector, read_list, map_obarray):
4774 Use ptrdiff_t, not int, for sizes.
4775 (read1): Use EMACS_INT, not int, for sizes.
4776 Check for size overflow.
4778 * image.c (cache_image): Check for size arithmetic overflow.
4780 * lread.c: Integer overflow issues.
4781 (saved_doc_string_size, saved_doc_string_length)
4782 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4783 Now ptrdiff_t, not int.
4784 (read1): Don't assume doc string length fits in int. Check for
4785 out-of-range doc string lengths.
4786 (read_list): Don't assume file position fits in int.
4787 (read_escape): Check for hex character overflow.
4789 2011-06-22 Leo Liu <sdl.web@gmail.com>
4791 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4792 Move to minibuffer.el.
4794 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4796 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4797 The following patches are for when GLYPH_DEBUG && !XASSERT.
4798 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4799 * dispnew.c (flush_stdout):
4800 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4801 Mark as externally visible.
4802 * dispnew.c (check_window_matrix_pointers): Now static.
4803 * dispnew.c (window_to_frame_vpos):
4804 * xfns.c (unwind_create_frame):
4805 * xterm.c (x_check_font): Remove unused local.
4806 * scroll.c (CHECK_BOUNDS):
4807 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4808 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4809 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4810 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4811 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4813 (debug_method_add): Use va_list and vsprintf rather than relying
4814 on undefined behavior with wrong number of arguments.
4815 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4816 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4817 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4818 since we're not interested in debugging glyphs with old libraries.
4819 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4820 GCC 4.6.0's static checking.
4822 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4824 Integer overflow and signedness fixes (Bug#8873).
4825 A few related buffer overrun fixes, too.
4827 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4829 * dispextern.h (struct face.stipple):
4830 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4831 (x_bitmap_mask, x_allocate_bitmap_record)
4832 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4833 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4834 (x_create_bitmap_from_xpm_data):
4835 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4836 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4838 * xfaces.c (load_pixmap):
4839 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4840 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4841 (.bitmaps_last, struct x_output.icon_bitmap):
4842 Use ptrdiff_t, not int, for bitmap indexes.
4843 (x_allocate_bitmap_record): Check for size overflow.
4844 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4846 Use ptrdiff_t, not int, for overlay counts.
4847 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4848 * editfns.c (overlays_around, get_pos_property):
4849 * textprop.c (get_char_property_and_overlay):
4850 * xdisp.c (next_overlay_change, note_mouse_highlight):
4851 * xfaces.c (face_at_buffer_position):
4852 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4853 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4854 (Fnext_overlay_change, Fprevious_overlay_change)
4855 (mouse_face_overlay_overlaps, Foverlays_in):
4856 Use ptrdiff_t, not int, for sizes.
4857 (overlays_at, overlays_in): Check for size-calculation overflow.
4859 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4861 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4862 (x_session_initialize): Do not assume string length fits in int.
4864 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4865 This is unlikely, but can occur if DPI is outlandish.
4867 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4868 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4870 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4871 * xrdb.c (magic_file_p, search_magic_path):
4872 Omit last arg SUFFIX; it was always 0. All callers changed.
4873 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4875 * xfont.c (xfont_match): Avoid need for strlen.
4877 * xfns.c: Don't assume strlen fits in int.
4878 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4880 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4881 not unsigned long, as we prefer signed integers. All callers changed.
4882 Detect integer overflow in repeat count.
4883 (message_dolog): Don't assume print length fits in 39 bytes.
4884 (display_mode_element): Don't assume strlen fits in int.
4886 * termcap.c: Don't assume sizes fit in int and never overflow.
4887 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4888 (gobble_line): Check for size-calculation overflow.
4890 * minibuf.c (Fread_buffer):
4891 * lread.c (intern, intern_c_string):
4892 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4893 Don't assume string length fits in int.
4895 * keyboard.c (parse_tool_bar_item):
4896 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4898 * font.c: Don't assume string length fits in int.
4899 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4900 Use ptrdiff_t, not int.
4901 (font_intern_prop): Don't assume string length fits in int.
4902 Don't assume integer property fits in fixnum.
4903 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4905 * filelock.c: Fix some buffer overrun and integer overflow issues.
4906 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4907 Reformulate so as not to need the command string.
4908 Invoke gzip -cd rather than gunzip, as it's more portable.
4909 (lock_info_type, lock_file_1, lock_file):
4910 Don't assume pid_t and time_t fit in unsigned long.
4911 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4912 (current_lock_owner): Prefer signed type for sizes.
4913 Use memcpy, not strncpy, where memcpy is what is really wanted.
4914 Don't assume (via atoi) that time_t and pid_t fit in int.
4915 Check for time_t and/or pid_t out of range, e.g., via a network share.
4916 Don't alloca where an auto var works fine.
4918 * fileio.c: Fix some integer overflow issues.
4919 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4920 Don't assume string length fits in int.
4921 (directory_file_name): Don't assume string length fits in long.
4922 (make_temp_name): Don't assume pid fits in int, or that its print
4923 length is less than 20.
4925 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4927 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4929 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4931 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4932 We prefer signed integers, even for size calculations.
4934 * emacs.c: Don't assume string length fits in 'int'.
4935 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4936 (main): Don't invoke strlen when not needed.
4938 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4939 (XD_DEBUG_MESSAGE): Don't waste a byte.
4941 * callproc.c (getenv_internal_1, getenv_internal)
4943 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4945 * lread.c (invalid_syntax): Omit length argument.
4946 All uses changed. This doesn't fix a bug, but it simplifies the
4947 code away from its former Hollerith-constant appearance, and it's
4948 one less 'int' to worry about when looking at integer-overflow issues.
4949 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4951 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4952 This didn't break anything, but it didn't help either.
4953 It's confusing to put a bogus integer in a place where the actual
4954 value does not matter.
4955 (LIST_END_P): Remove unused macro and its bogus comment.
4956 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4958 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4959 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4961 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4962 We prefer signed types, and the value cannot exceed the EMACS_INT
4963 range anyway (because otherwise the length would not be representable).
4964 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4965 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4966 This avoids a GCC warning when WIDE_EMACS_INT.
4968 * indent.c (sane_tab_width): New function.
4969 (current_column, scan_for_column, Findent_to, position_indentation)
4970 (compute_motion): Use it. This is just for clarity.
4971 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4973 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4975 * lisp.h (lint_assume): New macro.
4976 * composite.c (composition_gstring_put_cache):
4977 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4979 * editfns.c, insdel.c:
4980 Omit unnecessary forward decls, to simplify future changes.
4982 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4984 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4986 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4987 Use much-faster test for byte-length change.
4988 Don't assume string byte-length fits in 'int'.
4989 Check that character arg fits in 'int'.
4990 (mapcar1): Declare byte as byte, for clarity.
4992 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4994 * fns.c (concat): Catch string overflow earlier.
4995 Do not rely on integer wraparound.
4997 * dispextern.h (struct it.overlay_strings_charpos)
4998 (struct it.selective): Now EMACS_INT, not int.
4999 * xdisp.c (forward_to_next_line_start)
5000 (back_to_previous_visible_line_start)
5001 (reseat_at_next_visible_line_start, next_element_from_buffer):
5002 Don't arbitrarily truncate the value of 'selective' to int.
5004 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5006 * composite.c: Don't truncate sizes to 'int'.
5007 (composition_gstring_p, composition_reseat_it)
5008 (composition_adjust_point): Use EMACS_INT, not int.
5009 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5010 not EMACS_UINT, for indexes.
5012 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5014 * buffer.c: Include <verify.h>.
5015 (struct sortvec.priority, struct sortstr.priority):
5016 Now EMACS_INT, not int.
5017 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5018 (struct sortstr.size, record_overlay_string)
5019 (struct sortstrlist.size, struct sortlist.used):
5020 Don't truncate size to int.
5021 (record_overlay_string): Check for size-calculation overflow.
5022 (init_buffer_once): Check at compile-time, not run-time.
5024 2011-06-22 Jim Meyering <meyering@redhat.com>
5026 Don't leak an XBM-image-sized buffer
5027 * image.c (xbm_load): Free the image buffer after using it.
5029 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5032 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5033 that Sun C diagnosed.
5034 * fns.c (secure_hash): Fix pointer signedness issue.
5035 * intervals.c (static_offset_intervals): New function.
5036 (offset_intervals): Use it.
5038 2011-06-21 Leo Liu <sdl.web@gmail.com>
5041 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5044 * fns.c (secure_hash): Rename from crypto_hash_function and change
5045 the first arg to accept symbols.
5046 (Fsecure_hash): New primitive.
5047 (syms_of_fns): New symbols.
5049 2011-06-20 Deniz Dogan <deniz@dogan.se>
5051 * process.c (Fset_process_buffer): Clarify return value in
5054 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5056 * dispnew.c (add_window_display_history): Use BVAR.
5058 * xdisp.c (debug_method_add): Use BVAR.
5059 (check_window_end, dump_glyph_matrix, dump_glyph)
5060 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5062 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5065 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5066 check till after the cache is created in init_frame_faces.
5068 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5070 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5072 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5074 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5075 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5076 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5078 Improve buffer-overflow checking (Bug#8873).
5079 * fileio.c (Finsert_file_contents):
5080 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5081 Remove the old (too-loose) buffer overflow checks.
5082 They weren't needed, since make_gap checks for buffer overflow.
5083 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5084 The old code merely checked for Emacs fixnum overflow, and relied
5085 on undefined (wraparound) behavior. The new code avoids undefined
5086 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5088 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5089 Tune. Don't use wider integers than needed. Don't use alloca.
5090 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5092 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5094 * insdel.c, lisp.h (buffer_overflow): New function.
5095 (insert_from_buffer_1, replace_range, replace_range_2):
5096 * insdel.c (make_gap_larger):
5097 * editfns.c (Finsert_char):
5098 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5100 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5102 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5104 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5106 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5107 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5109 * fileio.c: Don't assume EMACS_INT fits in off_t.
5110 (emacs_lseek): New static function.
5111 (Finsert_file_contents, Fwrite_region): Use it.
5112 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5114 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5116 * fns.c: Don't overflow int when computing a list length.
5117 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5118 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5119 truncation on 64-bit hosts. Check for QUIT every
5120 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5121 faster and is responsive enough.
5122 (Flength): Report an error instead of overflowing an integer.
5123 (Fsafe_length): Return a float if the value is not representable
5124 as a fixnum. This shouldn't happen except in contrived situations.
5125 (Fnthcdr, Fsort): Don't assume list length fits in int.
5126 (Fcopy_sequence): Don't assume vector length fits in int.
5128 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5129 (header_size, word_size): New constants.
5130 (allocate_vectorlike): Don't check size overflow here.
5131 (allocate_vector): Check it here instead, since this is the only
5132 caller of allocate_vectorlike that could cause overflow.
5133 Check that the new vector's length is representable as a fixnum.
5135 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5136 The previous code was bogus. For example, next_almost_prime (32)
5137 returned 39, which is undesirable as it is a multiple of 3; and
5138 next_almost_prime (24) returned 25, which is a multiple of 5 so
5139 why was the code bothering to check for multiples of 7?
5141 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5143 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5145 Variadic C functions now count arguments with ptrdiff_t.
5146 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5147 Back then I didn't know that the Emacs coding style prefers signed int.
5148 Also, in the meantime I found a few more instances where arguments
5149 were being counted with int, which may truncate counts on 64-bit
5150 machines, or EMACS_INT, which may be unnecessarily wide.
5151 * lisp.h (struct Lisp_Subr.function.aMANY)
5152 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5153 Arg counts are now ptrdiff_t, not size_t.
5154 All variadic functions and their callers changed accordingly.
5155 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5156 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5157 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5158 * callint.c (Fcall_interactively): Check arg count for overflow,
5159 to avoid potential buffer overrun. Use signed char, not 'int',
5160 for 'varies' array, so that we needn't bother to check its size
5161 calculation for overflow.
5162 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5163 * eval.c (apply_lambda):
5164 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5165 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5166 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5168 * callint.c (Fcall_interactively): Don't use index var as event count.
5170 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5171 * mem-limits.h (SIZE): Remove; no longer used.
5173 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5175 Remove unnecessary casts.
5176 * xterm.c (x_term_init):
5177 * xfns.c (x_set_border_pixel):
5178 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5179 These aren't needed now that we assume ANSI C.
5181 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5182 It's more likely to cause problems (due to unsigned overflow)
5185 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5187 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5189 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5191 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5193 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5195 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5197 GLYPH_CODE_FACE returns EMACS_INT, not int.
5198 * dispextern.h (merge_faces):
5199 * xfaces.c (merge_faces):
5200 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5201 Don't assume EMACS_INT fits in int.
5203 * character.h (CHAR_VALID_P): Remove unused parameter.
5204 * fontset.c, lisp.h, xdisp.c: All uses changed.
5206 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5208 * fns.c (concat): Minor tuning based on overflow analysis.
5209 This doesn't fix any bugs. Use int to hold character, instead
5210 of constantly refetching from Emacs object. Use XFASTINT, not
5211 XINT, for value known to be a character. Don't bother comparing
5212 a single byte to 0400, as it's always less.
5214 * floatfns.c (Fexpt):
5215 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5217 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5220 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5222 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5223 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5224 incorrectly succeed when S was a string, because 4294967386 was
5225 truncated before it was used.
5227 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5228 Otherwise, an out-of-range integer could cause undefined behavior
5231 * composite.c: Use int, not EMACS_INT, for characters.
5232 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5233 EMACS_INT, for values that are known to be in character range.
5234 This doesn't fix any bugs but is the usual style inside Emacs and
5235 may generate better code on 32-bit machines.
5237 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5238 This is for reasons similar to the recent CHAR_STRING fix.
5239 * charset.c (Fencode_char): Check that character arg is actually
5240 a character. Pass an int to ENCODE_CHAR.
5241 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5242 wider than 'int', as a compile-time check to prevent future regressions
5245 * character.c (char_string): Remove unnecessary casts.
5247 Make sure a 64-bit char is never passed to CHAR_STRING.
5248 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5249 by silently ignoring the top 32 bits, allowing some values
5250 that were far too large to be valid characters.
5251 * character.h: Include <verify.h>.
5252 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5253 arguments are no wider than unsigned, as a compile-time check
5254 to prevent future regressions in this area.
5256 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5257 (Fsubst_char_in_region):
5259 * xdisp.c (decode_mode_spec_coding):
5260 Adjust to CHAR_STRING's new requirement.
5261 * editfns.c (Finsert_char, Fsubst_char_in_region):
5262 * fns.c (concat): Check that character args are actually
5263 characters. Without this test, these functions did the wrong
5264 thing with wildly out-of-range values on 64-bit hosts.
5266 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5267 These casts should not be needed on 32-bit hosts, either.
5268 * keyboard.c (read_char):
5269 * lread.c (Fload): Remove casts to unsigned.
5271 * lisp.h (UNSIGNED_CMP): New macro.
5272 This fixes comparison bugs on 64-bit hosts.
5273 (ASCII_CHAR_P): Use it.
5274 * casefiddle.c (casify_object):
5275 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5276 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5277 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5278 * dispextern.h (FACE_FROM_ID):
5279 * keyboard.c (read_char): Use UNSIGNED_CMP.
5281 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5282 not to EMACS_INT, to avoid GCC warning.
5284 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5286 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5287 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5288 isn't needed on 32-bit machines.
5290 * buffer.c (Fgenerate_new_buffer_name):
5291 Use EMACS_INT for count, not int.
5292 (advance_to_char_boundary): Return EMACS_INT, not int.
5294 * data.c (Qcompiled_function): Now static.
5296 * window.c (window_body_lines): Now static.
5298 * image.c (gif_load): Rename local to avoid shadowing.
5300 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5301 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5302 * alloc.c (make_save_value): Integer argument is now of type
5304 (mark_object): Use ptrdiff_t, not int.
5305 * lisp.h (pD): New macro.
5306 * print.c (print_object): Use it.
5308 * alloc.c: Use EMACS_INT, not int, to count objects.
5309 (total_conses, total_markers, total_symbols, total_vector_size)
5310 (total_free_conses, total_free_markers, total_free_symbols)
5311 (total_free_floats, total_floats, total_free_intervals)
5312 (total_intervals, total_strings, total_free_strings):
5313 Now EMACS_INT, not int. All uses changed.
5314 (Fgarbage_collect): Compute overall total using a double, so that
5315 integer overflow is less likely to be a problem. Check for overflow
5316 when converting back to an integer.
5317 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5318 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5319 These were 'int' variables that could overflow on 64-bit hosts;
5320 they were never used, so remove them instead of repairing them.
5321 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5322 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5323 Previously, this ceilinged at INT_MAX, but that doesn't work on
5325 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5327 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5328 (allocate_vectorlike): Check for ptrdiff_t overflow.
5329 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5330 when a (possibly-narrower) signed value would do just as well.
5331 We prefer using signed arithmetic, to avoid comparison confusion.
5333 * alloc.c: Catch some string size overflows that we were missing.
5334 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5335 for convenience in STRING_BYTES_MAX.
5336 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5337 The definition here is exact; the one in lisp.h was approximate.
5338 (allocate_string_data): Check for string overflow. This catches
5339 some instances we weren't catching before. Also, it catches
5340 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5341 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5342 and ptrdiff_t and EMACS_INT are both 64 bits.
5344 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5345 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5346 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5348 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5350 * alloc.c (Fmake_string): Check for out-of-range init.
5352 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5354 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5356 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5358 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5359 xg_get_default_scrollbar_width.
5361 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5362 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5363 (style_changed_cb): Call update_theme_scrollbar_width and call
5364 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5365 all frames (Bug#8505).
5366 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5367 Call gtk_window_set_resizable if HAVE_GTK3.
5368 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5369 and height if HAVE_GTK3 (Bug#8505).
5370 (scroll_bar_width_for_theme): New variable.
5371 (update_theme_scrollbar_width): New function.
5372 (xg_get_default_scrollbar_width): Move code to
5373 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5374 (xg_initialize): Call update_theme_scrollbar_width.
5376 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5378 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5380 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5382 * frame.c (make_frame): Call other_buffer_safely instead of
5385 * window.c (temp_output_buffer_show): Call display_buffer with
5386 second argument Vtemp_buffer_show_specifiers and reset latter
5387 immediately after the call.
5388 (Vtemp_buffer_show_specifiers): New variable.
5389 (auto_window_vscroll_p, next_screen_context_lines)
5390 (Vscroll_preserve_screen_position): Remove leading asterisks from
5393 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5395 Fix minor problems found by GCC 4.6.0 static checking.
5396 * buffer.c (Qclone_number): Remove for now, as it's unused.
5397 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5398 (record_buffer): Remove unused local.
5399 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5400 (set_frame_buffer_list): Remove; unused.
5401 * frame.h (other_visible_frames): Remove decl.
5402 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5403 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5404 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5406 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5407 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5408 Define only if HAVE_GPM.
5409 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5410 (update_hints_inhibit): Remove; never set. All uses removed.
5411 * widgetprv.h (emacsFrameClassRec): Remove decl.
5412 * window.c (delete_deletable_window): Now returns void, since it
5413 wasn't returning anything.
5414 (compare_window_configurations): Remove unused locals.
5415 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5416 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5417 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5418 the same widths as pointers. This follows up on the 2011-05-06 patch.
5419 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5420 * xterm.h: Likewise.
5421 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5423 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5425 * makefile.w32-in: Update dependencies.
5426 (LISP_H): Add lib/intprops.h.
5428 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5430 * image.c (gif_load): Add animation frame delay to the metadata.
5431 (syms_of_image): Use DEFSYM. New symbol `delay'.
5433 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5435 * window.c (delete_deletable_window): Re-add.
5436 (Fset_window_configuration): Rewrite to handle dead buffers and
5437 consequently deletable windows.
5438 (window_tree, Fwindow_tree): Remove. Supply functionality in
5440 (compare_window_configurations): Simplify code.
5442 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5444 * image.c (imagemagick_load_image): Fix type mismatch.
5445 (Fimagemagick_types): Likewise.
5447 * window.h (replace_buffer_in_windows): Declare.
5449 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5451 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5452 Qclone_number. Remove external declaration of Qdelete_window.
5453 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5455 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5456 Run Qbuffer_list_update_hook if allowed.
5457 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5458 buffer list implementation.
5459 (other_buffer_safely): New function.
5460 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5461 calls to replace_buffer_in_windows and
5462 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5464 (record_buffer): Inhibit quitting and rewrite using quittable
5465 functions. Run Qbuffer_list_update_hook if allowed.
5466 (Frecord_buffer, Funrecord_buffer): New functions.
5467 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5468 Move switch-to-buffer to window.el.
5469 (bury-buffer): Move to window.el.
5470 (Vbuffer_list_update_hook): New variable.
5472 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5475 * window.h (resize_frame_windows): Move up in code.
5476 (Fwindow_frame): Remove EXFUN.
5477 (replace_buffer_in_all_windows): Remove prototype.
5478 (replace_buffer_in_windows_safely): Add prototype.
5480 * window.c: Declare Qdelete_window static again. Move down
5481 declaration of select_count.
5482 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5483 (Fother_window): Move to window.el.
5484 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5485 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5486 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5488 (replace_buffer_in_windows): Implement by calling
5489 Qreplace_buffer_in_windows.
5490 (replace_buffer_in_all_windows): Remove with some functionality
5491 moved into replace_buffer_in_windows_safely.
5492 (replace_buffer_in_windows_safely): New function.
5493 (select_window_norecord, select_frame_norecord): Move in front
5494 of run_window_configuration_change_hook. Remove now obsolete
5496 (Fset_window_buffer): Rewrite doc-string.
5497 Call Qrecord_window_buffer.
5498 (keys_of_window): Move binding for other-window to window.el.
5500 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5502 * dispextern.h (struct image): Replace data member, whose int_val
5503 and ptr_val fields were not used by anything, with a single
5506 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5507 (gif_clear_image, gif_load, imagemagick_load_image)
5508 (gs_clear_image, gs_load): Callers changed.
5510 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5512 * buffer.h: Include <time.h>, for time_t.
5513 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5515 Fix minor problems found by static checking.
5517 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5519 Make identifiers static if they are not used in other modules.
5520 * data.c (Qcompiled_function, Qframe, Qvector):
5521 * image.c (QimageMagick, Qsvg):
5522 * minibuf.c (Qmetadata):
5523 * window.c (resize_window_check, resize_root_window): Now static.
5524 * window.h (resize_window_check, resize_root_window): Remove decls.
5526 * window.c (window_deletion_count, delete_deletable_window):
5528 (window_body_lines): Now static.
5529 (Fdelete_other_windows_internal): Mark vars as initialized.
5530 Make sure 'resize_failed' is initialized.
5531 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5532 (resize_window_apply): Remove unused local.
5533 * window.h (delete_deletable_window): Remove decl.
5535 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5536 (imagemagick_load_image): Fix pointer signedness problem by changing
5537 last arg from unsigned char * to char *. All uses changed.
5538 Also, fix a local for similar reasons.
5539 Remove unused locals. Remove locals to avoid shadowing.
5540 (fn_rsvg_handle_free): Remove; unused.
5541 (svg_load, svg_load_image): Fix pointer signedness problem.
5542 (imagemagick_load_image): Don't use garbage pointer image_wand.
5544 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5546 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5548 * image.c (gif_load): Fix omitted cast error introduced by
5551 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5553 * window.h (resize_proportionally, orig_total_lines)
5554 (orig_top_line): Remove from window structure.
5555 (set_window_height, set_window_width, change_window_heights)
5556 (Fdelete_window): Remove prototypes.
5557 (resize_frame_windows): Remove duplicate declaration.
5559 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5561 * window.h (resize_frame_windows, resize_window_check)
5562 (delete_deletable_window, resize_root_window)
5563 (resize_frame_windows): Declare prototypes.
5565 * window.c (resize_window_apply): Make definition be "static" to
5566 match the prototype.
5568 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5570 * window.c: Remove declarations of Qwindow_size_fixed,
5571 window_min_size_1, window_min_size_2, window_min_size,
5572 size_window, window_fixed_size_p, enlarge_window, delete_window.
5573 Remove static from declaration of Qdelete_window, it's
5574 temporarily needed by Fbury_buffer.
5575 (replace_window): Don't assign orig_top_line and
5577 (Fdelete_window, delete_window): Remove. Window deletion is
5578 handled by window.el.
5579 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5580 Replace Fdelete_window calls with calls to Qdelete_window.
5581 (Fdelete_other_windows): Remove. Deleting other windows is
5582 handled by window.el.
5583 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5584 handled in window.el.
5585 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5586 Window minimum sizes are handled in window.el.
5587 (shrink_windows, size_window, set_window_height)
5588 (set_window_width, change_window_heights, window_height)
5589 (window_width, CURBEG, CURSIZE, enlarge_window)
5590 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5591 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5592 handled in window.el.
5593 (make_dummy_parent): Rename to make_parent_window and give it a
5594 second argument horflag.
5595 (make_window): Don't set resize_proportionally any more.
5596 (Fsplit_window): Remove. Windows are split in window.el.
5597 (save_restore_action, save_restore_orig_size)
5598 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5599 Resize mini windows in window.el.
5600 (grow_mini_window, shrink_mini_window): Implement by calling
5601 Qresize_root_window_vertically, resize_window_check and
5602 resize_window_apply.
5603 (saved_window, Fset_window_configuration, save_window_save):
5604 Do not handle orig_top_line, orig_total_lines, and
5605 resize_proportionally.
5606 (window_min_height, window_min_width): Move to window.el.
5607 (keys_of_window): Move bindings for delete-other-windows,
5608 split-window, delete-window and enlarge-window to window.el.
5610 * buffer.c: Temporarily extern Qdelete_window.
5611 (Fbury_buffer): Temporarily call Qdelete_window instead of
5612 Fdelete_window (Fbury_buffer will move to window.el soon).
5614 * frame.c (set_menu_bar_lines_1): Remove code handling
5615 orig_top_line and orig_total_lines.
5617 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5618 set_window_height but set heights directly.
5619 (change_frame_size_1): Use resize_frame_windows.
5621 * xdisp.c (init_xdisp): Don't use set_window_height but set
5624 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5625 Use resize_frame_windows instead of change_window_heights and run
5626 run_window_configuration_change_hook.
5628 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5629 instead of change_window_heights and run
5630 run_window_configuration_change_hook.
5632 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5634 * window.c (replace_window): Rename second argument REPLACEMENT to
5635 NEW. New third argument SETFLAG. Rewrite.
5636 (delete_window, make_dummy_parent): Call replace_window with
5638 (window_list_1): Move down in code.
5639 (run_window_configuration_change_hook): Move set_buffer part
5640 before select_frame_norecord part in order to unwind correctly.
5641 Rename count1 to count.
5642 (recombine_windows, delete_deletable_window, resize_root_window)
5643 (Fdelete_other_windows_internal)
5644 (Frun_window_configuration_change_hook, make_parent_window)
5645 (resize_window_check, resize_window_apply, Fresize_window_apply)
5646 (resize_frame_windows, Fsplit_window_internal)
5647 (Fdelete_window_internal, Fresize_mini_window_internal):
5649 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5651 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5653 * window.h (window): Add some new members to window structure -
5654 normal_lines, normal_cols, new_total, new_normal, clone_number,
5655 splits, nest, prev_buffers, next_buffers.
5656 (WINDOW_TOTAL_SIZE): Move here from window.c.
5657 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5659 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5661 (make_dummy_parent): Set new members of windows structure.
5662 (make_window): Move down in code. Handle new members of window
5664 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5665 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5666 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5667 (Fset_window_prev_buffers, Fwindow_next_buffers)
5668 (Fset_window_next_buffers, Fset_window_clone_number):
5670 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5671 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5673 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5674 Argument WINDOW can be now internal window too.
5675 (Fwindow_use_time): Move up in code.
5676 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5678 (Fset_window_configuration, saved_window)
5679 (Fcurrent_window_configuration, save_window_save): Handle new
5680 members of window structure.
5681 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5682 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5683 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5684 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5685 Qget_mru_window, Qresize_root_window,
5686 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5687 Qauto_buffer_name; staticpro them.
5689 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5691 * window.c (Fwindow_total_size, Fwindow_left_column)
5692 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5693 (Fwindow_list_1): New functions.
5694 (window_box_text_cols): Replace with window_body_cols.
5695 (Fwindow_width, Fscroll_left, Fscroll_right):
5696 Use window_body_cols instead of window_box_text_cols.
5697 (delete_window, Fset_window_configuration):
5698 Call delete_all_subwindows with window as argument.
5699 (delete_all_subwindows): Take a window as argument and not a
5701 (window_loop): Remove handling of GET_LRU_WINDOW and
5703 (Fget_lru_window, Fget_largest_window): Move to window.el.
5705 * window.h: Extern window_body_cols instead of
5706 window_box_text_cols. delete_all_subwindows now takes a
5707 Lisp_Object as argument.
5709 * indent.c (compute_motion, Fcompute_motion):
5710 Use window_body_cols instead of window_box_text_cols.
5712 * frame.c (delete_frame): Call delete_all_subwindows with root
5715 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5717 * fns.c (Fputhash): Document return value.
5719 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5721 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5723 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5725 Cons<->int and similar integer overflow fixes (Bug#8794).
5727 Check for overflow when converting integer to cons and back.
5728 * charset.c (Fdefine_charset_internal, Fdecode_char):
5729 Use cons_to_unsigned to catch overflow.
5730 (Fencode_char): Use INTEGER_TO_CONS.
5731 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5732 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5733 * data.c (long_to_cons, cons_to_long): Remove.
5734 (cons_to_unsigned, cons_to_signed): New functions.
5735 These signal an error for invalid or out-of-range values.
5736 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5737 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5738 * font.c (Ffont_variation_glyphs):
5739 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5740 * lisp.h: Include <intprops.h>.
5741 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5742 (cons_to_signed, cons_to_unsigned): New decls.
5743 (long_to_cons, cons_to_long): Remove decls.
5744 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5745 (Fprimitive_undo): Use CONS_TO_INTEGER.
5746 * xfns.c (Fx_window_property): Likewise.
5747 * xselect.c: Include <limits.h>.
5748 (x_own_selection, selection_data_to_lisp_data):
5749 Use INTEGER_TO_CONS.
5750 (x_handle_selection_request, x_handle_selection_clear)
5751 (x_get_foreign_selection, Fx_disown_selection_internal)
5752 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5753 (lisp_data_to_selection_data): Use cons_to_unsigned.
5754 (x_fill_property_data): Use cons_to_signed.
5755 Report values out of range.
5757 Check for buffer and string overflow more precisely.
5758 * buffer.h (BUF_BYTES_MAX): New macro.
5759 * lisp.h (STRING_BYTES_MAX): New macro.
5760 * alloc.c (Fmake_string):
5761 * character.c (string_escape_byte8):
5762 * coding.c (coding_alloc_by_realloc):
5763 * doprnt.c (doprnt):
5764 * editfns.c (Fformat):
5766 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5767 since they may not be the same number.
5768 * editfns.c (Finsert_char):
5769 * fileio.c (Finsert_file_contents):
5770 Likewise for BUF_BYTES_MAX.
5772 * image.c: Use ptrdiff_t, not int, for sizes.
5773 (slurp_file): Switch from int to ptrdiff_t.
5775 (slurp_file): Check that file size fits in both size_t (for
5776 malloc) and ptrdiff_t (for sanity and safety).
5778 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5779 if b->modtime has its maximal value.
5781 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5783 Don't assume time_t can fit into int.
5784 * buffer.h (struct buffer.modtime): Now time_t, not int.
5785 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5786 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5788 Minor fixes for signed vs unsigned integers.
5789 * character.h (MAYBE_UNIFY_CHAR):
5790 * charset.c (maybe_unify_char):
5791 * keyboard.c (read_char, reorder_modifiers):
5792 XINT -> XFASTINT, since the integer must be nonnegative.
5793 * ftfont.c (ftfont_spec_pattern):
5794 * keymap.c (access_keymap, silly_event_symbol_error):
5795 XUINT -> XFASTINT, since the integer must be nonnegative.
5796 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5797 since it makes no difference and we prefer signed.
5798 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5799 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5802 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5804 * window.h (Fwindow_frame): Declare.
5806 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5808 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5809 (SPARE_MEMORY): Always define.
5810 (LARGE_REQUEST): Remove.
5811 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5813 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5815 * lisp.h: Move EXFUNS for Fframe_root_window,
5816 Fframe_first_window and Fset_frame_selected_window to window.h.
5818 * window.h: Move EXFUNS for Fframe_root_window,
5819 Fframe_first_window and Fset_frame_selected_window here from
5822 * frame.c (Fwindow_frame, Fframe_first_window)
5823 (Fframe_root_window, Fframe_selected_window)
5824 (Fset_frame_selected_window): Move to window.c.
5825 (Factive_minibuffer_window): Move to minibuf.c.
5826 (Fother_visible_frames_p): New function.
5828 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5830 * window.c (decode_window, decode_any_window): Move up in code.
5831 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5832 (inhibit_frame_unsplittable): Remove unused variable.
5833 (Fwindow_buffer): Move up and rewrite doc-string.
5834 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5835 (Fwindow_prev): New functions.
5836 (Fwindow_frame): Move here from frame.c. Accept any window as
5838 (Fframe_root_window, Fframe_first_window)
5839 (Fframe_selected_window): Move here from frame.c. Accept frame
5840 or arbitrary window as argument. Update doc-strings.
5841 (Fminibuffer_window): Move up in code.
5842 (Fwindow_minibuffer_p): Move up in code and simplify.
5843 (Fset_frame_selected_window): Move here from frame.c.
5845 (Fselected_window, select_window, Fselect_window): Move up in
5846 code. Minor doc-string fixes.
5848 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5850 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5851 Do not assume that spare memory exists; that assumption is valid
5852 only if SYSTEM_MALLOC.
5853 (LARGE_REQUEST): New macro, so that the issue of large requests
5854 is separated from the issue of spare memory.
5856 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5858 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5861 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5863 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5866 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5868 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5870 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5872 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5873 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5875 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5877 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5879 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5881 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5882 (x_clipboard_manager_save): Add return value.
5883 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5885 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5886 Obey Vx_select_enable_clipboard_manager. Catch errors in
5887 x_clipboard_manager_save (Bug#8779).
5888 (Vx_select_enable_clipboard_manager): New variable.
5889 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5891 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5893 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5895 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5897 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5898 in the current matrix if keep_current_p is non-zero.
5900 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5902 * bidi.c (bidi_level_of_next_char): Fix last change.
5904 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5906 Support bidi reordering of text covered by display properties.
5908 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5909 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5910 (bidi_cache_search, bidi_cache_iterator_state)
5911 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5912 (bidi_level_of_next_char, bidi_move_to_visually_next):
5913 Support character positions inside a run of characters covered by a
5915 (bidi_paragraph_init, bidi_resolve_explicit_1)
5916 (bidi_level_of_next_char): Call bidi_fetch_char and
5917 bidi_fetch_char_advance instead of FETCH_CHAR and
5919 (bidi_init_it): Initialize new members.
5920 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5922 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5923 instead of using explicit *_CHAR codes.
5924 (bidi_resolve_explicit, bidi_resolve_weak):
5925 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5926 bidirectional text is supported only in multibyte buffers.
5927 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5928 it to initialize the frame_window_p member of struct bidi_it.
5929 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5930 (bidi_resolve_explicit, bidi_resolve_weak)
5931 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5932 bidi_it->nchars is non-positive.
5933 (bidi_level_of_next_char): Don't try to lookup the cache for the
5934 next/previous character if nothing is cached there yet, or if we
5935 were just reseat()'ed to a new position.
5937 * xdisp.c (set_cursor_from_row): Set start and stop points
5938 according to the row's direction when priming the loop that looks
5939 for the glyph on which to display cursor.
5940 (single_display_spec_intangible_p): Function deleted.
5941 (display_prop_intangible_p): Reimplement to call
5942 handle_display_spec instead of single_display_spec_intangible_p.
5943 Accept 3 additional arguments needed by handle_display_spec.
5944 This fixes incorrect cursor motion across display property with complex
5945 values: lists, `(when COND...)' forms, etc.
5946 (single_display_spec_string_p): Support property values that are
5947 lists with the argument STRING its top-level element.
5948 (display_prop_string_p): Fix the condition for processing a
5949 property that is a list to be consistent with handle_display_spec.
5950 (handle_display_spec): New function, refactored from the
5951 last portion of handle_display_prop.
5952 (compute_display_string_pos): Accept additional argument
5953 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5954 value of a `display' property is a "replacing spec".
5955 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5956 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5957 the display property, but just return a value indicating whether
5958 the display property will replace the characters it covers.
5959 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5960 frame_window_p members of struct bidi_it.
5961 (compute_display_string_pos, compute_display_string_end):
5963 (push_it): Accept second argument POSITION, where pop_it should
5964 jump to continue iteration.
5965 (reseat_1): Initialize bidi_it.disp_pos.
5967 * keyboard.c (adjust_point_for_property): Adjust the call to
5968 display_prop_intangible_p to its new signature.
5970 * dispextern.h (struct bidi_it): New member frame_window_p.
5971 (bidi_init_it): Update prototypes.
5972 (display_prop_intangible_p): Update prototype.
5973 (compute_display_string_pos, compute_display_string_end):
5975 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5978 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5980 Malloc failure behavior now depends on size of allocation.
5981 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5982 * lisp.h: Change signatures accordingly.
5983 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5984 All callers changed. (Bug#8762)
5986 * gnutls.c: Use Emacs's memory allocators.
5987 Without this change, the gnutls library would invoke malloc etc.
5988 directly, which causes problems on non-SYNC_INPUT hosts, and which
5989 runs afoul of improving memory_full behavior. (Bug#8761)
5990 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5991 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5992 xfree instead of the default malloc, realloc, free.
5993 (Fgnutls_boot): No need to check for memory allocation failure,
5994 since xmalloc does that for us.
5996 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5997 * category.c (hash_get_category_set):
5998 * ccl.c (ccl_driver):
5999 * charset.c (Fdefine_charset_internal):
6000 * charset.h (struct charset.hash_index):
6001 * composite.c (get_composition_id, gstring_lookup_cache)
6002 (composition_gstring_put_cache):
6003 * composite.h (struct composition.hash_index):
6004 * dispextern.h (struct image.hash):
6005 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6006 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6007 (hashfn_equal, hashfn_user_defined, make_hash_table)
6008 (maybe_resize_hash_table, hash_lookup, hash_put)
6009 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6010 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6011 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6012 * image.c (make_image, search_image_cache, lookup_image)
6013 (xpm_put_color_table_h):
6014 * lisp.h (struct Lisp_Hash_Table):
6015 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6016 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6017 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6018 * alloc.c (allocate_vectorlike):
6019 Check for overflow in vector size calculations.
6020 * ccl.c (ccl_driver):
6021 Check for overflow when converting EMACS_INT to int.
6022 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6023 need to be updated by these changes.
6024 * fns.c (make_hash_table, maybe_resize_hash_table):
6025 Check for integer overflow with large hash tables.
6026 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6027 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6028 (SXHASH_REDUCE): New macro.
6029 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6030 Use it instead of discarding useful hash info with large hash values.
6031 (sxhash_float): New function.
6032 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6033 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6034 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6035 Rewrite to use FIXNUM_BITS, as this simplifies things.
6036 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6037 Adjust signatures to match updated version of code.
6038 (consing_since_gc): Now EMACS_INT, since a single hash table can
6039 use more than INT_MAX bytes.
6041 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6043 Make it possible to build with GCC-4.6+ -O2 -flto.
6045 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6047 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6049 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6050 Call minibuffer-inactive-mode.
6052 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6054 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6055 Update dependencies.
6057 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6059 * data.c (init_data): Remove code for UTS, this system is not
6062 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6064 Don't force ./temacs to start in terminal mode.
6066 * frame.c (make_initial_frame): Initialize faces in all cases, not
6067 only when CANNOT_DUMP is defined.
6068 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6070 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6072 * dispnew.c (add_window_display_history): Use const for the string
6073 pointer. Remove declaration, not needed.
6075 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6077 Use 'inline', not 'INLINE'.
6078 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6079 * alloc.c, fontset.c (INLINE): Remove.
6080 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6081 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6082 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6083 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6084 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6086 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6088 Make it possible to run ./temacs.
6090 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6091 syms_of_callproc does the same thing. Remove test for
6092 "initialized", do it in the caller.
6093 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6095 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6097 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6098 (read_minibuf): Use get_minibuffer.
6099 (syms_of_minibuf): Use DEFSYM.
6100 (Qmetadata): New var.
6101 * data.c (Qbuffer): Don't make it static.
6102 (syms_of_data): Use DEFSYM.
6104 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6106 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6107 (CCL_CODE_MIN): New macro.
6109 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6111 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6113 * eval.c (Qdebug): Now static.
6114 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6115 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6116 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6118 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6120 * image.c: Various fixes to ImageMagick code comments.
6121 (Fimagemagick_types): Doc fix.
6123 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6125 Minor fixes prompted by GCC 4.6.0 warnings.
6127 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6129 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6130 (x_clipboard_manager_save_all): Move extern decl to ...
6131 * xterm.h: ... here, so that it can be checked for consistency.
6133 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6135 * xselect.c (x_clipboard_manager_save_frame)
6136 (x_clipboard_manager_save_all): New functions.
6137 (Fx_clipboard_manager_save): Lisp function deleted.
6139 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6140 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6142 * xterm.h: Update prototype.
6144 2011-05-28 William Xu <william.xwl@gmail.com>
6146 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6149 2011-05-28 Jim Meyering <meyering@redhat.com>
6151 Avoid a sign-extension bug in crypto_hash_function.
6152 * fns.c (to_uchar): Define.
6153 (crypto_hash_function): Use it to convert some newly-signed
6154 variables to unsigned, to avoid sign-extension bugs. For example,
6155 without this change, (md5 "truc") would evaluate to
6156 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6157 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6158 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6160 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6162 Integer overflow fixes.
6164 * dbusbind.c: Serial number integer overflow fixes.
6165 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6166 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6167 to hold a serial number that is too large for a fixnum.
6168 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6169 Check for serial numbers out of range. Decode any serial number
6170 that was so large that it became a float. (Bug#8722)
6172 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6173 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6174 Use XFASTINT rather than XUINT when numbers are nonnegative.
6175 (xd_append_arg, Fdbus_method_return_internal):
6176 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6177 arguments, check that Lisp number is nonnegative, rather than
6178 silently wrapping negative numbers around. (Bug#8722)
6179 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6182 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6184 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6186 ccl: Add integer overflow checks.
6187 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6188 (IN_INT_RANGE): New macros.
6189 (ccl_driver): Use them to check for integer overflow when
6190 decoding a CCL program. Many of the new checks are whether XINT (x)
6191 fits in int; it doesn't always, on 64-bit hosts. The new version
6192 doesn't catch all possible integer overflows, but it's an
6193 improvement. (Bug#8719)
6195 * alloc.c (make_event_array): Use XINT, not XUINT.
6196 There's no need for unsigned here.
6198 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6199 This follows up to the 2011-05-06 change that substituted uintptr_t
6200 for EMACS_INT. This case wasn't caught back then.
6202 Rework Fformat to avoid integer overflow issues.
6203 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6204 now (part of C89). Include <verify.h>.
6205 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6206 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6207 (Fformat): Avoid the prepass trying to compute sizes; it was only
6208 approximate and thus did not catch overflow reliably. Instead, walk
6209 through the format just once, formatting and computing sizes as we go,
6210 checking for integer overflow at every step, and allocating a larger
6211 buffer as needed. Keep track separately whether the format is
6212 multibyte. Keep only the most-recently calculated precision, rather
6213 than them all. Record whether each argument has been converted to
6214 string. Use EMACS_INT, not int, for byte and char and arg counts.
6215 Support field widths and precisions larger than INT_MAX. Avoid
6216 sprintf's undefined behavior with conversion specifications such as %#d
6217 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6218 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6219 formatting out-of-range floating point numbers with int
6222 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6224 * data.c: Avoid integer truncation in expressions involving floats.
6225 * data.c: Include <intprops.h>.
6226 (arith_driver): When there's an integer overflow in an expression
6227 involving floating point, convert the integers to floating point
6228 so that the resulting value does not suffer from catastrophic
6229 integer truncation. For example, on a 64-bit host (* 4
6230 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6231 Do not rely on undefined behavior after integer overflow.
6233 merge count_size_as_multibyte, parse_str_to_multibyte
6234 * character.c, character.h (count_size_as_multibyte):
6235 Rename from parse_str_to_multibyte; all uses changed.
6236 Check for integer overflow.
6237 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6238 since it's now a duplicate of the other. This is more of
6239 a character than a buffer op, so better that it's in character.c.
6240 * fns.c, print.c: Adjust to above changes.
6242 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6244 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6246 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6248 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6249 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6250 (x_clipboard_manager_save): Now static.
6251 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6253 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6254 (crypto_hash_function): Now static.
6255 Fix pointer signedness problems. Avoid unnecessary initializations.
6257 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6259 * termhooks.h (Vselection_alist): Make it terminal-local.
6261 * terminal.c (create_terminal): Initialize it.
6263 * xselect.c: Support for clipboard managers.
6264 (Vselection_alist): Move to termhooks.h as terminal-local var.
6265 (LOCAL_SELECTION): New macro.
6266 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6267 (symbol_to_x_atom): Remove gratuitous arg.
6268 (x_handle_selection_request, lisp_data_to_selection_data)
6269 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6270 (x_own_selection, x_get_local_selection, x_convert_selection):
6271 New arg, specifying work frame. Use terminal-local Vselection_alist.
6272 (some_frame_on_display): Delete unused function.
6273 (Fx_own_selection_internal, Fx_get_selection_internal)
6274 (Fx_disown_selection_internal, Fx_selection_owner_p)
6275 (Fx_selection_exists_p): New optional frame arg.
6276 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6277 (x_handle_selection_clear): Don't treat other terminals with the
6278 same keyboard specially. Use the terminal-local Vselection_alist.
6279 (x_clear_frame_selections): Use Frun_hook_with_args.
6281 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6283 * xterm.h: Add support for those atoms.
6285 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6287 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6288 (converted_selections, conversion_fail_tag): New global variables.
6289 (x_selection_request_lisp_error): Free the above.
6290 (x_get_local_selection): Remove unnecessary code.
6291 (x_reply_selection_request): Args changed; handle arbitrary array
6292 of converted selections stored in converted_selections.
6293 Separate the XChangeProperty and SelectionNotify steps.
6294 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6295 (x_convert_selection): New function.
6296 (x_handle_selection_event): Simplify.
6297 (x_get_foreign_selection): Don't ignore incoming requests while
6298 waiting for an answer; this will fail when we implement
6299 SAVE_TARGETS, and seems unnecessary anyway.
6300 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6301 (Vx_sent_selection_functions): Doc fix.
6303 2011-05-26 Leo Liu <sdl.web@gmail.com>
6305 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6307 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6309 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6311 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6312 for fringe update if it has periodic bitmap.
6313 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6314 and fringe_bitmap_periodic_p.
6316 * fringe.c (get_fringe_bitmap_data): New function.
6317 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6318 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6319 row. Mark glyph row for fringe update if periodicity changed.
6321 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6322 for fringe update unless it has periodic bitmap.
6324 2011-05-25 Kenichi Handa <handa@m17n.org>
6326 * xdisp.c (get_next_display_element): Set correct it->face_id for
6327 a static composition.
6329 2011-05-24 Leo Liu <sdl.web@gmail.com>
6332 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6334 * fns.c (crypto_hash_function, Fsha1): New function.
6335 (Fmd5): Use crypto_hash_function.
6336 (syms_of_fns): Add Ssha1.
6338 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6340 * gnutls.c: Remove unused macros.
6341 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6342 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6343 Remove macros that are defined and never used.
6344 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6346 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6348 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6349 (Fx_get_selection_internal): Minor cleanup.
6350 (Fx_own_selection_internal): Rename arguments for consistency with
6353 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6355 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6357 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6359 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6361 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6363 * dispnew.c (scrolling_window): Don't exclude the case that the
6364 last enabled row in the desired matrix touches the bottom boundary.
6366 2011-05-21 Glenn Morris <rgm@gnu.org>
6368 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6369 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6370 and add some more files.
6372 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6374 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6375 report_file_error introduced by the change from 2011-05-07.
6377 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6379 * systime.h (Time): Define only if emacs is defined.
6380 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6381 where the include path doesn't have X11/X.h by default. See
6382 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6384 2011-05-20 Kenichi Handa <handa@m17n.org>
6386 * composite.c (find_automatic_composition): Fix previous change.
6388 2011-05-20 Glenn Morris <rgm@gnu.org>
6390 * lisp.mk: New file, split from Makefile.in.
6391 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6392 (shortlisp): Remove.
6393 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6395 2011-05-19 Glenn Morris <rgm@gnu.org>
6397 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6398 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6399 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6400 (lisp): Set the order to that of loadup.el.
6401 (shortlisp): Make it a copy of $lisp.
6402 (SOME_MACHINE_LISP): Remove.
6403 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6404 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6406 2011-05-18 Kenichi Handa <handa@m17n.org>
6408 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6409 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6410 (find_automatic_composition): Mostly rewrite for efficiency.
6412 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6414 * makefile.w32-in: Update dependencies.
6416 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6418 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6419 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6421 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6423 Fix some integer overflow issues, such as string length overflow.
6425 * insdel.c (count_size_as_multibyte): Check for string overflow.
6427 * character.c (lisp_string_width): Check for string overflow.
6428 Use EMACS_INT, not int, for string indexes and lengths; in
6429 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6430 the resulting string length overflows an EMACS_INT; instead,
6431 report a string overflow if no precision given. When checking for
6432 precision exhaustion, use a check that cannot possibly have
6433 integer overflow. (Bug#8675)
6434 * character.h (lisp_string_width): Adjust to new signature.
6436 * alloc.c (string_overflow): New function.
6437 (Fmake_string): Use it. This doesn't change behavior, but saves
6438 a few bytes and will simplify future changes.
6439 * character.c (string_escape_byte8): Likewise.
6440 * lisp.h (string_overflow): New decl.
6442 Fixups, following up to the user-interface timestamp change.
6443 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6444 for UI timestamps, instead of unsigned long.
6445 * msdos.c (mouse_get_pos): Likewise.
6446 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6447 * w32gui.h (Time): Define by including "systime.h" rather than by
6448 declaring it ourselves. (Bug#8664)
6450 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6451 * image.c (clear_image_cache): Likewise.
6453 * term.c (term_mouse_position): Don't assume time_t wraparound.
6455 Be more systematic about user-interface timestamps.
6456 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6457 and sometimes 'EMACS_UINT', to represent these timestamps.
6458 This change causes it to use 'Time' uniformly, as that's what X uses.
6459 This makes the code easier to follow, and makes it easier to catch
6460 integer overflow bugs such as Bug#8664.
6461 * frame.c (Fmouse_position, Fmouse_pixel_position):
6462 Use Time, not unsigned long, for user-interface timestamps.
6463 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6464 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6465 * keyboard.h (last_event_timestamp): Likewise.
6466 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6467 * menu.h (xmenu_show): Likewise.
6468 * term.c (term_mouse_position): Likewise.
6469 * termhooks.h (struct input_event.timestamp): Likewise.
6470 (struct terminal.mouse_position_hook): Likewise.
6471 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6472 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6473 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6474 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6476 * menu.h, termhooks.h: Include "systime.h", for Time.
6478 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6479 Don't assume that the difference between two unsigned long values
6480 can fit into an integer. At this point, we know button_down_time
6481 <= event->timestamp, so the difference must be nonnegative, so
6482 there's no need to cast the result if double-click-time is
6483 nonnegative, as it should be; check that it's nonnegative, just in
6484 case. This bug is triggered when events are more than 2**31 ms
6485 apart (about 25 days). (Bug#8664)
6487 * xselect.c (last_event_timestamp): Remove duplicate decl.
6488 (x_own_selection): Remove needless cast to unsigned long.
6490 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6491 that always fit in int. Use a sentinel instead of a counter, to
6492 avoid a temp and to allay GCC's concerns about possible int overflow.
6493 * frame.h (struct frame): Use int for menu_bar_items_used
6494 instead of EMACS_INT, since it always fits in int.
6496 * menu.c (grow_menu_items): Check for int overflow.
6498 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6500 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6501 Before, the code was not consistent. These values cannot exceed
6502 2**31 - 1 so there's no need to make them unsigned.
6503 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6504 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6505 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6507 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6509 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6510 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6511 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6512 presumably because the widths might not match.
6514 * window.c (size_window): Avoid needless test at loop start.
6516 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6518 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6520 2011-05-12 Drew Adams <drew.adams@oracle.com>
6522 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6524 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6526 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6527 `width' to `bar_area_x' and `bar_area_width', respectively.
6528 (x_scroll_run): Take account of fringe background extension.
6530 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6531 Rename local vars `left' and `width' to `bar_area_x' and
6532 `bar_area_width', respectively.
6533 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6534 background extension.
6536 2011-05-10 Jim Meyering <meyering@redhat.com>
6538 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6540 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6542 * image.c (Finit_image_library): Return t for built-in image types,
6543 like pbm and xbm. (Bug#8640)
6545 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6547 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6549 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6551 * w32console.c (Fset_screen_color): Doc fix.
6552 (Fget_screen_color): New function.
6553 (syms_of_ntterm): Defsubr it.
6555 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6556 unlink the temporary file if Fcall_process didn't create it in the
6558 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6559 child process will be redirected to a file specified with `:file'.
6560 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6561 cue to call_process_cleanup not to close that handle.
6563 2011-05-07 Ben Key <bkey76@gmail.com>
6565 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6566 one of two shell specific rules, either bootstrap-temacs-CMD or
6567 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6568 to the previous implementation of the bootstrap-temacs rule.
6569 The bootstrap-temacs-CMD rule is similar to the previous
6570 implementation of the bootstrap-temacs rule except that it
6571 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6574 These changes, along with some changes to nt/configure.bat,
6575 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6576 earlier fix to add support for --cflags and --ldflags options
6577 that include quotes so that it works whether make uses cmd or
6580 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6582 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6583 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6585 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6586 a string. Handle both cases.
6587 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6588 (Fdbus_register_method): Use Qinvalid_function.
6590 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6592 * makefile.w32-in: Update dependencies.
6593 (LISP_H): Add inttypes.h and stdin.h.
6594 (PROCESS_H): Add unistd.h.
6596 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6598 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6599 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6601 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6603 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6605 * term.c (vfatal): Remove stray call to va_end.
6606 It's not needed and the C Standard doesn't allow it here anyway.
6608 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6609 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6611 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6614 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6616 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6618 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6620 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6622 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6624 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6625 * charset.c (Fdefine_charset_internal): Don't initialize
6626 charset.code_space[15]. The value was garbage, on hosts with
6627 32-bit int (Bug#8600).
6629 * lread.c (read_integer): Be more consistent with string-to-number.
6630 Use string_to_number to do the actual conversion; this avoids
6631 rounding errors and fixes some other screwups. Without this fix,
6632 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6633 (digit_to_number): Move earlier, for benefit of read_integer.
6634 Return -1 if the digit is out of range for the base, -2 if it is
6635 not a digit in any supported base. (Bug#8602)
6637 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6639 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6640 to match comment at start of function. This also removes a
6641 GCC warning about overflow in a 32+64-bit port.
6643 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6645 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6646 Reported by Stefan Monnier in
6647 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6648 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6649 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6651 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6652 (EMACS_UINTPTR): Likewise, with uintptr_t.
6654 * lisp.h: Prefer 64-bit EMACS_INT if available.
6655 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6656 on 32-bit hosts that have 64-bit int, so that they can access
6658 However, temporarily disable this change unless the temporary
6659 symbol WIDE_EMACS_INT is defined.
6661 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6663 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6664 This removes an assumption that EMACS_INT and long are the same
6665 width as pointers. The assumption is true for Emacs porting targets
6666 now, but we want to make other targets possible.
6667 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6668 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6669 In the rest of the code, change types of integers that hold casted
6670 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6671 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6672 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6673 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6674 No need to cast type when ORing.
6675 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6676 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6677 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6678 assume EMACS_INT is the same width as char *.
6679 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6680 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6681 Remove no-longer-needed casts.
6682 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6683 (xg_tool_bar_help_callback, xg_make_tool_item):
6684 Use EMACS_INTPTR to hold an integer
6685 that will be cast to void *; this can avoid a GCC warning
6686 if EMACS_INT is not the same width as void *.
6687 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6688 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6689 (current_message_1, set_message_1):
6690 Use a local to convert to proper width without a cast.
6691 * xmenu.c (dialog_selection_callback): Likewise.
6693 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6694 Also, don't assume VALBITS / RAND_BITS is less than 5,
6695 and don't rely on undefined behavior when shifting a 1 left into
6697 * lisp.h (get_random): Change signature to match.
6699 * lread.c (hash_string): Use size_t, not int, for hash computation.
6700 Normally we prefer signed values; but hashing is special, because
6701 it's better to use unsigned division on hash table sizes so that
6702 the remainder is nonnegative. Also, size_t is the natural width
6703 for hashing into memory. The previous code used 'int', which doesn't
6704 retain enough info to hash well into very large tables.
6705 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6707 * dbusbind.c: Don't possibly lose pointer info when converting.
6708 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6709 Use XPNTR rather than XHASH, so that the high-order bits of
6710 the pointer aren't lost when converting through void *.
6712 * eval.c (Fautoload): Don't double-shift a pointer.
6714 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6716 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6718 * gnutls.c (DEF_GNUTLS_FN):
6719 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6721 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6723 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6726 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6728 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6729 New version that can reserve upto 2GB of heap space.
6731 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6733 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6735 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6737 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6738 `gnutls_certificate_set_x509_key_file'.
6740 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6742 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6743 Update dependencies.
6745 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6747 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6748 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6749 Remove unused parameter `fildes'.
6750 * process.c (read_process_output, send_process): Don't pass it.
6752 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6754 Fix previous change: the library cache is defined in w32.c.
6755 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6756 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6758 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6760 Implement dynamic loading of GnuTLS on Windows.
6762 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6763 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6764 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6767 * gnutls.c (Qgnutls_dll): Define.
6768 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6769 (gnutls_*): Declare function pointers.
6770 (init_gnutls_functions): New function to initialize function pointers.
6771 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6772 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6773 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6774 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6775 (emacs_gnutls_write, emacs_gnutls_read)
6776 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6777 (Fgnutls_available_p): New function.
6778 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6779 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6780 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6782 * image.c: Include w32.h.
6783 (Vimage_type_cache): Delete.
6784 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6785 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6786 (w32_delayed_load): Move to w32.c.
6788 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6790 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6791 (w32_delayed_load): Move from image.c. When loading a library, record
6792 its filename in the :loaded-from property of the library id.
6793 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6794 Initialize and staticpro them.
6795 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6797 * process.c: Include lisp.h before w32.h, not after.
6798 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6799 instead of gnutls_record_check_pending.
6801 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6803 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6805 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6806 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6809 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6811 * xterm.c (x_set_frame_alpha): Do not set property on anything
6812 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6814 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6816 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6818 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6820 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6821 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6822 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6823 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6824 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6825 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6826 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6827 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6828 (Qgnutls_bootprop_callbacks_verify): Make static.
6830 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6832 * callproc.c: Indentation fixup.
6834 * sysdep.c (wait_for_termination_1): Make static.
6835 (wait_for_termination, interruptible_wait_for_termination):
6836 Move after wait_for_termination_1.
6838 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6840 * sysdep.c (interruptible_wait_for_termination): New function
6841 which is like wait_for_termination, but allows keyboard
6844 * callproc.c (Fcall_process): Add (:file "file") as an option for
6846 (Fcall_process_region): Ditto.
6848 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6850 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6851 rather than `XVECTOR (FOO)->size'.
6853 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6854 inttypes.h, as a gnulib replacement is used if it not available in
6857 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6859 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6860 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6861 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6863 * coding.c (coding_alloc_by_realloc): Error out if destination
6864 will grow beyond MOST_POSITIVE_FIXNUM.
6865 (decode_coding_emacs_mule): Abort if there isn't enough place in
6866 charbuf for the composition carryover bytes. Reserve an extra
6867 space for up to 2 characters produced in a loop.
6868 (decode_coding_iso_2022): Abort if there isn't enough place in
6869 charbuf for the composition carryover bytes.
6871 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6873 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6874 aborting when %lld or %lll format is passed.
6875 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6876 %llo or %llx format is passed. (Bug#8545)
6878 * window.c (window_scroll_line_based): Use a marker instead of
6879 simple variables to record original value of point. (Bug#7952)
6881 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6882 produced by %s or %c overflows available buffer space. (Bug#8545)
6884 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6886 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6887 (SIZE_MAX): Move defn after all includes, as they might #define it.
6889 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6891 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6893 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6895 * keyboard.c (Qdelayed_warnings_hook): Define.
6896 (command_loop_1): Run `delayed-warnings-hook'
6897 if Vdelayed_warnings_list is non-nil.
6898 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6899 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6901 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6903 * doprnt.c (doprnt): Don't return value smaller than the buffer
6904 size if the message was truncated. (Bug#8545).
6906 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6908 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6909 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6911 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6913 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6915 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6917 * makefile.w32-in: Update dependencies.
6919 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6921 Improve `doprnt' and its usage. (Bug#8545)
6922 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6923 `format_end'. Remove support for %l as a conversion specifier.
6924 Don't use xrealloc. Improve diagnostics when the %l size modifier
6925 is used. Update the commentary.
6927 * eval.c (verror): Simplify calculation of size_t.
6929 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6932 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6934 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6937 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6939 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6940 This makes this file independent of the recent pseudovector change.
6942 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6944 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6946 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6947 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6948 Remove unused local.
6949 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6951 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6952 GCC 4.6.0 optimizes based on type-based alias analysis.
6953 For example, if b is of type struct buffer * and v of type struct
6954 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6955 != &v->size, and therefore "v->size = 1; b->size = 2; return
6956 v->size;" must therefore return 1. This assumption is incorrect
6957 for Emacs, since it type-puns struct Lisp_Vector * with many other
6958 types. To fix this problem, this patch adds a new type struct
6959 vectorlike_header that documents the constraints on layout of vectors
6960 and pseudovectors, and helps optimizing compilers not get fooled
6961 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6962 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6963 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6965 (XSETPVECTYPE): Rewrite in terms of new macro.
6966 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6967 This is a bit clearer, and further avoids the possibility of
6968 undesirable aliasing.
6969 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6970 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6971 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6972 since Lisp_Subr is a special case (no "next" field).
6973 (ASIZE): Now uses header.size rather than size.
6974 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6975 to avoid the hassle of writing XVECTOR (foo)->header.size.
6976 (struct vectorlike_header): New type.
6977 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6978 object, to help avoid aliasing.
6979 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6980 (SUBRP): Likewise, since Lisp_Subr is a special case.
6981 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6982 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6983 (struct Lisp_Hash_Table): Combine first two members into a single
6984 struct vectorlike_header member. All uses of "size" and "next" members
6985 changed to be "header.size" and "header.next".
6986 * buffer.h (struct buffer): Likewise.
6987 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6988 * frame.h (struct frame): Likewise.
6989 * process.h (struct Lisp_Process): Likewise.
6990 * termhooks.h (struct terminal): Likewise.
6991 * window.c (struct save_window_data, struct saved_window): Likewise.
6992 * window.h (struct window): Likewise.
6993 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6994 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6995 * buffer.c (init_buffer_once): Likewise.
6996 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6998 * process.c (Fformat_network_address): Use local var for size,
7001 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7003 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7004 * data.c (atof): Remove decl; no longer used or needed.
7005 (digit_to_number): Move to lread.c.
7006 (Fstring_to_number): Use new string_to_number function, to be
7007 consistent with how the Lisp reader treats infinities and NaNs.
7008 Do not assume that floating-point numbers represent EMACS_INT
7009 without losing information; this is not true on most 64-bit hosts.
7010 Avoid double-rounding errors, by insisting on integers when
7011 parsing non-base-10 numbers, as the documentation specifies.
7012 * lisp.h (string_to_number): New decl, replacing ...
7013 (isfloat_string): Remove.
7014 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7015 (read1): Do not accept +. and -. as integers; this
7016 appears to have been a coding error. Similarly, do not accept
7017 strings like +-1e0 as floating point numbers. Do not report
7018 overflow for integer overflows unless the base is not 10 which
7019 means we have no simple and reliable way to continue.
7020 Break out the floating-point parsing into a new
7021 function string_to_number, so that Fstring_to_number parses
7022 floating point numbers consistently with the Lisp reader.
7023 (digit_to_number): Move here from data.c. Make it static inline.
7024 (E_CHAR, EXP_INT): Remove, replacing with ...
7025 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7026 (string_to_number): New function, replacing isfloat_string.
7027 This function checks for valid syntax and produces the resulting
7028 Lisp float number too. Rework it so that string-to-number
7029 no longer mishandles examples like "1.0e+". Use strtoumax,
7030 so that overflow for non-base-10 numbers is reported only when
7031 there's no portable and simple way to convert to floating point.
7033 * textprop.c (set_text_properties_1): Rewrite for clarity,
7034 and to avoid GCC warning about integer overflow.
7036 * intervals.h (struct interval): Use EMACS_INT for members
7037 where EMACS_UINT might cause problems. See
7038 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7039 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7040 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7042 (offset_intervals): Tell GCC not to worry about length overflow
7043 when negating a negative length.
7045 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7046 (overrun_check_free): Likewise.
7048 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7049 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7052 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7053 (gnutls_make_error): Rename local to avoid shadowing.
7054 (gnutls_emacs_global_deinit): ifdef out; not used.
7055 (Fgnutls_boot): Use const for pointer to readonly storage.
7056 Comment out unused local. Fix pointer signedness problems.
7058 * lread.c (openp): Don't stuff size_t into an 'int'.
7059 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7060 about possible signed overflow.
7062 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7063 (GDK_KEY_g): Don't define if already defined.
7064 (xg_prepare_tooltip): Avoid pointer signedness problem.
7065 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7067 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7068 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7070 * xfns.c (Fx_window_property): Simplify a bit,
7071 to make a bit faster and to avoid GCC 4.6.0 warning.
7072 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7074 * fns.c (internal_equal): Don't assume size_t fits in int.
7076 * alloc.c (compact_small_strings): Tighten assertion a little.
7078 Replace pEd with more-general pI, and fix some printf arg casts.
7079 * lisp.h (pI): New macro, generalizing old pEd macro to other
7080 conversion specifiers. For example, use "...%"pI"d..." rather
7081 than "...%"pEd"...".
7082 (pEd): Remove. All uses replaced with similar uses of pI.
7083 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7084 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7085 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7086 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7087 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7088 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7089 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7091 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7092 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7093 * print.c (safe_debug_print, print_object): Likewise.
7094 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7096 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7097 avoiding the 0 flag, which is not portable.
7098 * process.c (Fmake_network_process): Use pI to avoid cast.
7099 * region-cache.c (pp_cache): Likewise.
7100 * xdisp.c (decode_mode_spec): Likewise.
7101 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7102 behavior on 64-bit hosts with printf arg.
7103 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7104 (x_stop_queuing_selection_requests): Likewise.
7105 (x_get_window_property): Don't truncate byte count to an 'int'
7108 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7109 here, since it parses constructs like leading '-' and spaces,
7110 which are not wanted; and it overflows with large numbers.
7111 Instead, simply match F[0-9]+, which is what is wanted anyway.
7113 * alloc.c: Remove unportable assumptions about struct layout.
7114 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7115 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7116 (allocate_vectorlike, make_pure_vector): Use the new macros,
7117 plus offsetof, to remove unportable assumptions about struct layout.
7118 These assumptions hold on all porting targets that I know of, but
7119 they are not guaranteed, they're easy to remove, and removing them
7120 makes further changes easier.
7122 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7123 This doesn't fix a bug but makes the code clearer.
7124 (string_overrun_cookie): Now const. Use initializers that
7125 don't formally overflow signed char, to avoid warnings.
7126 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7127 can cause Emacs to crash when string overrun checking is enabled.
7128 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7129 multiple of sizeof (EMACS_INT); it need not be, if
7130 alignof(EMACS_INT) < sizeof (EMACS_INT).
7131 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7133 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7135 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7137 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7139 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7140 supposed to be handshaking. (Bug#8556)
7141 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7143 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7145 * lisp.h (Qdebug): List symbol.
7146 * eval.c (Qdebug): Restore global linkage.
7147 * keyboard.c (debug-on-event): New variable.
7148 (handle_user_signal): Break into debugger when debug-on-event
7149 matches the current signal symbol.
7151 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7153 * alloc.c (check_sblock, check_string_bytes)
7154 (check_string_free_list): Convert to standard C.
7156 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7158 * w32.c (emacs_gnutls_push): Fix typo.
7160 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7162 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7163 "cast to pointer from integer of different size".
7165 Improve doprnt and its use in verror. (Bug#8545)
7166 * doprnt.c (doprnt): Document the set of format control sequences
7167 supported by the function. Use SAFE_ALLOCA instead of always
7170 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7171 is one byte too soon. Don't use xrealloc; instead xfree and
7174 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7176 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7179 * gnutls.c: Renamed global_initialized to
7180 gnutls_global_initialized. Added internals for the
7181 :verify-hostname-error, :verify-error, and :verify-flags
7182 parameters of `gnutls-boot' and documented those parameters in the
7183 docstring. Start callback support.
7184 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7185 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7186 on error. Return error code.
7187 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7188 (emacs_gnutls_read): Likewise.
7189 (Fgnutls_boot): Return handshake error code.
7190 (emacs_gnutls_handle_error): New function.
7191 (wsaerror_to_errno): Likewise.
7193 * w32.h (emacs_gnutls_pull): Add prototype.
7194 (emacs_gnutls_push): Likewise.
7196 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7197 (emacs_gnutls_push): Likewise.
7199 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7201 * process.c (wait_reading_process_output): Check if GnuTLS
7202 buffered some data internally if no FDs are set for TLS
7205 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7206 (LIBS): Link to USER_LIBS.
7207 ($(BLD)/gnutls.$(0)): New target.
7209 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7211 * xdisp.c (handle_single_display_spec): Rename the
7212 display_replaced_before_p argument into display_replaced_p, to
7213 make it consistent with the commentary. Fix typos in the
7216 * textprop.c (syms_of_textprop): Remove dead code.
7217 (copy_text_properties): Delete obsolete commentary about an
7218 interface that was deleted long ago. Fix typos in the description
7221 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7222 to changes in oldXMenu/XMenu.h from 2011-04-16.
7223 <menu_help_message, prev_menu_help_message>: Constify.
7224 (IT_menu_make_room): menu->help_text is now `const char **';
7227 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7228 to changes in oldXMenu/XMenu.h from 2011-04-16.
7229 (struct XMenu): Declare `help_text' `const char **'.
7231 * xfaces.c <Qunspecified>: Make extern again.
7233 * syntax.c: Include sys/types.h before including regex.h, as
7236 * doc.c (get_doc_string): Improve the format passed to `error'.
7238 * doprnt.c (doprnt): Improve commentary.
7240 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7242 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7245 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7246 changes in globals.h immediately force recompilation.
7247 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7248 $(CURDIR)/s/ms-w32.h.
7249 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7251 * character.c (Fchar_direction): Function deleted.
7252 (syms_of_character): Don't defsubr it.
7253 <char-direction-table>: Deleted.
7255 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7257 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7258 * doprnt.c: Include limits.h.
7259 (SIZE_MAX): New macro.
7260 (doprnt): Return a size_t value. 2nd arg is now size_t.
7261 Many local variables are now size_t instead of int or unsigned.
7262 Improve overflow protection. Support `l' modifier for integer
7263 conversions. Support %l conversion. Don't assume an EMACS_INT
7264 argument for integer conversions and for %c.
7266 * lisp.h (doprnt): Restore prototype.
7268 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7271 * Makefile.in (base_obj): Add back doprnt.o.
7273 * deps.mk (doprnt.o): Add back prerequisites.
7274 (callint.o): Depend on character.h.
7276 * eval.c (internal_lisp_condition_case): Include the handler
7277 representation in the error message.
7278 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7279 when breaking from the loop.
7281 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7283 * callint.c (Fcall_interactively): When displaying error message
7284 about invalid control letter, pass the character's codepoint, not
7285 a pointer to its multibyte form. Improve display of the character
7286 in octal and display also its hex code.
7288 * character.c (char_string): Use %x to display the (unsigned)
7289 codepoint of an invalid character, to avoid displaying a bogus
7292 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7293 `error', not SYMBOL_NAME itself.
7295 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7296 character arguments to `error'.
7298 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7299 to `error' in error message about FINAL_CHAR argument. Make sure
7300 FINAL_CHAR is a character, and use %c when it is passed as
7301 argument to `error'.
7303 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7305 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7307 * w32.c: Include <time.h>.
7308 (sys_localtime): New function.
7310 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7312 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7314 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7316 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7318 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7321 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7323 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7324 gl_state.e_property when gl_state.object is Qt.
7326 * insdel.c (make_gap_larger): Remove limitation of buffer size
7329 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7331 * xdisp.c (lookup_glyphless_char_display)
7332 (produce_glyphless_glyph): Handle cons cell entry in
7333 glyphless-char-display.
7334 (Vglyphless_char_display): Document it.
7336 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7337 glyphless-char-display.
7339 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7341 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7343 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7345 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7346 definition for no-X builds.
7348 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7350 Static checks with GCC 4.6.0 and non-default toolkits.
7352 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7354 * process.c (keyboard_bit_set): Define only if SIGIO.
7355 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7356 (send_process): Repair possible setjmp clobbering.
7358 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7360 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7362 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7364 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7365 Define only if needed.
7367 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7368 by pacifying GCC about it. Maybe it's time to retire it?
7369 * xfaces.c (USG, __TIMEVAL__): Likewise.
7371 * dispextern.h (struct redisplay_interface): Rename param
7373 * termhooks.h (struct terminal): Likewise.
7374 * xterm.c (xembed_send_message): Likewise.
7376 * insdel.c (make_gap_smaller): Define only if
7377 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7379 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7382 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7383 so that we aren't warned about unused symbols.
7385 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7387 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7389 * xfns.c (x_real_positions): Mark locals as initialized.
7391 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7393 * xterm.c: Fix problems found by static analysis with other toolkits.
7394 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7395 (x_dispatch_event): Declare static if USE_GTK, and
7396 define if USE_GTK || USE_X_TOOLKIT.
7397 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7398 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7399 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7400 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7402 * xmenu.c (menu_help_callback): Pointer type fixes.
7403 Use const pointers when pointing at readonly data. Avoid pointer
7405 (FALSE): Remove unused macro.
7406 (update_frame_menubar): Remove unused decl.
7408 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7410 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7411 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7412 (single_menu_item): Rename local to avoid shadowing.
7414 * keyboard.c (make_lispy_event): Remove unused local var.
7416 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7417 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7419 * bitmaps: Change bitmaps from unsigned char back to the X11
7420 compatible char. Avoid the old compiler warnings about
7421 out-of-range initializers by using, for example, '\xab' rather
7424 * xgselect.c (xgselect_initialize): Check vs interface
7425 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7427 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7429 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7430 to read-only memory.
7432 * fns.c (vector): Remove; this old hack is no longer needed.
7434 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7436 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7438 * xrdb.c (x_load_resources): Omit unused local.
7440 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7441 (x_window): Rename locals to avoid shadowing.
7442 (USG): Use the kludged USG macro, to pacify gcc.
7444 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7445 (x_term_init): Remove local to avoid shadowing.
7447 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7449 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7450 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7452 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7454 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7456 Fix regex.c, syntax.c and friends for buffers > 2GB.
7457 * syntax.h (struct gl_state_s): Declare character position members
7460 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7462 * textprop.c (verify_interval_modification, interval_of):
7463 Declare arguments EMACS_INT.
7465 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7468 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7470 * indent.c (Fvertical_motion): Local variable it_start is now
7473 * regex.c (re_match, re_match_2, re_match_2_internal)
7474 (bcmp_translate, regcomp, regexec, print_double_string)
7475 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7476 (re_compile_pattern, re_exec): Declare arguments and local
7477 variables `size_t' and `ssize_t' and return values `regoff_t', as
7479 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7480 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7481 <compile_stack_type>: `size' and `avail' are now `size_t'.
7483 * regex.h <regoff_t>: Use ssize_t, not int.
7484 (re_search, re_search_2, re_match, re_match_2): Arguments that
7485 specify buffer/string position and length are now ssize_t and
7486 size_t. Return type is regoff_t.
7488 2011-04-16 Ben Key <bkey76@gmail.com>
7490 * nsfont.m: Fixed bugs in ns_get_family and
7491 ns_descriptor_to_entity that were caused by using free to
7492 deallocate memory blocks that were allocated by xmalloc (via
7493 xstrdup). This caused Emacs to crash when compiled with
7494 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7495 --enable-checking=xmallocoverrun). xfree is now used to
7496 deallocate these memory blocks.
7498 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7500 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7502 emacs_write: Accept and return EMACS_INT for sizes.
7503 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7505 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7506 Accept and return EMACS_INT.
7507 (emacs_gnutls_write): Return the number of bytes written on
7509 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7510 (emacs_read, emacs_write): Remove check for negative size, as the
7511 Emacs source code has been audited now.
7512 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7513 (emacs_read, emacs_write): Use it.
7514 * process.c (send_process): Adjust to the new signatures of
7515 emacs_write and emacs_gnutls_write. Do not attempt to store
7516 a byte offset into an 'int'; it might overflow.
7517 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7519 * sound.c: Don't assume sizes fit in 'int'.
7520 (struct sound_device.period_size, alsa_period_size):
7521 Return EMACS_INT, not int.
7522 (struct sound_device.write, vox_write, alsa_write):
7523 Accept EMACS_INT, not int.
7524 (wav_play, au_play): Use EMACS_INT to store sizes and to
7525 record read return values.
7527 2011-04-15 Ben Key <bkey76@gmail.com>
7529 * keyboard.c (Qundefined): Don't declare static since it is used
7531 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7532 static since they are used in nsfont.m.
7534 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7536 * process.c (Qprocessp): Don't declare static.
7537 * lisp.h (Qprocessp): Declare again.
7539 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7541 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7543 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7545 Improve C-level modularity by making more things 'static'.
7547 Don't publish debugger-only interfaces to other modules.
7548 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7549 (verify_bytepos, count_markers): Move decls to the only modules
7551 * region-cache.h (pp_cache): Likewise.
7552 * window.h (check_all_windows): Likewise.
7553 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7555 * sysdep.c (croak): Now static, if
7556 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7557 * syssignal.h (croak): Declare only if not static.
7559 * alloc.c (refill_memory_reserve): Now static if
7560 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7561 * lisp.h (refill_memory_reserve): Declare only if not static.
7563 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7564 Define only if USE_LUCID.
7566 * xrdb.c (x_customization_string, x_rm_string): Now static.
7568 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7569 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7571 * xdisp.c (draw_row_with_mouse_face): Now static.
7572 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7574 * window.h (check_all_windows): Mark externally visible.
7576 * window.c (window_deletion_count): Now static.
7578 * undo.c: Make symbols static if they're not exported.
7579 (last_undo_buffer, last_boundary_position, pending_boundary):
7582 * textprop.c (interval_insert_behind_hooks): Now static.
7583 (interval_insert_in_front_hooks): Likewise.
7585 * term.c: Make symbols static if they're not exported.
7586 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7587 (max_frame_lines, tty_set_terminal_modes):
7588 (tty_reset_terminal_modes, tty_turn_off_highlight):
7589 (get_tty_terminal): Now static.
7590 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7591 * termhooks.h (term_mouse_moveto): Do not declare if
7593 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7594 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7596 * sysdep.c: Make symbols static if they're not exported.
7597 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7599 (sigprocmask_set, full_mask): Remove; unused.
7600 (wait_debugging): Mark as visible.
7601 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7602 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7604 * syntax.c (syntax_temp): Define only if !__GNUC__.
7606 * sound.c (current_sound_device, current_sound): Now static.
7608 * search.c (searchbufs, searchbuf_head): Now static.
7610 * scroll.c (scroll_cost): Remove; unused.
7611 * dispextern.h (scroll_cost): Remove decl.
7613 * region-cache.h (pp_cache): Mark as externally visible.
7615 * process.c: Make symbols static if they're not exported.
7616 (process_tick, update_tick, create_process, chan_process):
7617 (Vprocess_alist, proc_buffered_char, datagram_access):
7618 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7619 (deactivate_process): Mark defn as static, as well as decl.
7620 * lisp.h (create_process): Remove decl.
7621 * process.h (chan_process, Vprocess_alist): Remove decls.
7623 * print.c: Make symbols static if they're not exported.
7624 (print_depth, new_backquote_output, being_printed, print_buffer):
7625 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7626 (print_interval, print_number_index, initial_stderr_stream):
7628 * lisp.h (Fprinc): Remove decl.
7629 (debug_output_compilation_hack): Mark as externally visible.
7631 * sysdep.c (croak): Move decl from here to syssignal.h.
7632 * syssignal.h (croak): Put it here, so the API can be checked when
7633 'croak' is called from dissociate_if_controlling_tty.
7635 * minibuf.c: Make symbols static if they're not exported.
7636 (minibuf_save_list, choose_minibuf_frame): Now static.
7637 * lisp.h (choose_minibuf_frame): Remove decl.
7639 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7641 * lread.c: Make symbols static if they're not exported.
7642 (read_objects, initial_obarray, oblookup_last_bucket_number):
7644 (make_symbol): Remove; unused.
7645 * lisp.h (initial_obarray, make_symbol): Remove decls.
7647 * keyboard.c: Make symbols static if they're not exported.
7648 (single_kboard, recent_keys_index, total_keys, recent_keys):
7649 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7650 (this_single_command_key_start, echoing, last_auto_save):
7651 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7652 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7653 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7654 (Vlispy_mouse_stem, double_click_count):
7656 (force_auto_save_soon): Define only if SIGDANGER.
7657 (ignore_mouse_drag_p): Now static if
7658 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7659 (print_help): Remove; unused.
7660 (stop_character, last_timer_event): Mark as externally visible.
7661 * keyboard.h (ignore_mouse_drag_p): Declare only if
7662 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7663 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7664 * lisp.h (echoing): Remove decl.
7665 (force_auto_save_soon): Declare only if SIGDANGER.
7666 * xdisp.c (redisplay_window): Simplify code, to make it more
7667 obvious that ignore_mouse_drag_p is not accessed if !defined
7668 USE_GTK && !defined HAVE_NS.
7670 * intervals.c: Make symbols static if they're not exported.
7671 (merge_properties_sticky, merge_interval_right, delete_interval):
7673 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7675 * insdel.c: Make symbols static if they're not exported.
7676 However, leave prepare_to_modify_buffer alone. It's never
7677 called from outside this function, but that appears to be a bug.
7678 (combine_after_change_list, combine_after_change_buffer):
7679 (adjust_after_replace, signal_before_change): Now static.
7680 (adjust_after_replace_noundo): Remove; unused.
7681 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7682 (signal_before_change): Remove decls.
7684 * indent.c (val_compute_motion, val_vmotion): Now static.
7686 * image.c: Make symbols static if they're not exported.
7687 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7689 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7690 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7692 * fringe.c (standard_bitmaps): Now static.
7693 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7695 * frame.c: Make symbols static if they're not exported.
7696 (x_report_frame_params, make_terminal_frame): Now static.
7697 (get_frame_param): Now static, unless HAVE_NS.
7698 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7699 (x_get_resource_string): Remove; not used.
7700 * frame.h (make_terminal_frame, x_report_frame_params):
7701 (x_get_resource_string); Remove decls.
7702 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7703 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7705 * font.c, fontset.c: Make symbols static if they're not exported.
7706 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7707 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7708 * font.c (font_close_object): Now static.
7709 * font.h (font_close_object): Remove.
7710 * fontset.c (FONTSET_OBJLIST): Remove.
7711 (free_realized_fontset) #if-0 the body, which does nothing.
7712 (face_suitable_for_char_p): #if-0, as it's never called.
7713 * fontset.h (face_suitable_for_char_p): Remove decl.
7714 * xfaces.c (face_at_string_position):
7715 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7716 since 0 is always ASCII.
7718 * fns.c (weak_hash_tables): Now static.
7720 * fileio.c: Make symbols static if they're not exported.
7721 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7722 (Vwrite_region_annotation_buffers): Now static.
7724 * eval.c: Make symbols static if they're not exported.
7725 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7726 * lisp.h (backtrace_list): Remove decl.
7728 * emacs.c: Make symbols static if they're not exported.
7729 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7730 (fatal_error_code, fatal_error_signal_hook, standard_args):
7732 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7733 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7734 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7735 * lisp.h (fatal_error_signal_hook): Remove decl.
7736 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7738 * editfns.c: Move a (normally-unused) function to its only use.
7739 * editfns.c, lisp.h (get_operating_system_release): Remove.
7740 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7741 worth the hassle of breaking this out.
7743 * xterm.c: Make symbols static if they're not exported.
7744 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7745 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7746 (x_destroy_window, x_delete_display):
7748 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7749 (x_mouse_leave): Remove; unused.
7750 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7751 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7752 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7754 (x_mouse_leave): Declare only if WINDOWSNT.
7755 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7756 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7759 * ftxfont.c: Make symbols static if they're not exported.
7760 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7762 * font.h (ftxfont_driver): Likewise.
7764 * xfns.c: Make symbols static if they're not exported.
7765 (x_last_font_name, x_display_info_for_name):
7766 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7767 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7768 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7769 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7770 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7771 (last_show_tip_args): Now static.
7772 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7773 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7774 (x_screen_planes): Remove; unused.
7775 * dispextern.h (x_screen_planes): Remove decl.
7777 * dispnew.c: Make symbols static if they're not exported.
7778 * dispextern.h (redraw_garbaged_frames, scrolling):
7779 (increment_row_positions): Remove.
7780 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7781 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7783 (redraw_garbaged_frames): Remove; unused.
7785 * xfaces.c: Make symbols static if they're not exported.
7786 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7788 * xterm.h (defined_color): Remove decls.
7789 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7790 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7791 (menu_face_changed_default, defined_color, free_realized_face):
7792 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7793 (ascii_face_of_lisp_face): Remove; unused.
7795 * xdisp.c: Make symbols static if they're not exported.
7796 * dispextern.h (scratch_glyph_row, window_box_edges):
7797 (glyph_to_pixel_coords, set_cursor_from_row):
7798 (get_next_display_element, set_iterator_to_next):
7799 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7800 (show_mouse_face): Remove decls
7801 * frame.h (message_buf_print): Likewise.
7802 * lisp.h (pop_message, set_message, check_point_in_composition):
7804 * xterm.h (set_vertical_scroll_bar): Likewise.
7805 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7806 (message_buf_print, scratch_glyph_row, displayed_buffer):
7807 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7808 (get_next_display_element, show_mouse_face, window_box_edges):
7809 (frame_to_window_pixel_xy, check_point_in_composition):
7810 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7811 (glyph_to_pixel_coords): Remove; unused.
7813 * dired.c (file_name_completion): Now static.
7815 * dbusbind.c (xd_in_read_queued_messages): Now static.
7817 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7818 * data.c (circular_list_error): Remove.
7820 * commands.h (last_point_position, last_point_position_buffer):
7821 (last_point_position_window): Remove decls.
7822 * keyboard.c: Make these variables static.
7824 * coding.h (coding, code_convert_region, encode_coding_gap):
7826 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7827 (iso_code_class, detect_coding, code_convert_region): Now static.
7828 (encode_coding_gap): Remove; unused.
7830 * chartab.c (chartab_chars, chartab_bits): Now static.
7832 * charset.h (charset_iso_8859_1): Remove decl.
7833 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7836 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7837 * ccl.c (Vccl_program_table): Now static.
7838 (check_ccl_update): Remove; unused.
7840 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7841 * category.h: ... from here.
7842 * category.c (check_category_table, set_category_set): Now static.
7844 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7845 * lisp.h: Remove these decls.
7847 * buffer.c (buffer_count): Remove unused var.
7849 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7850 so that it's not optimized away.
7851 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7852 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7853 exported only to the debugger.
7855 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7856 * atimer.h (run_all_atimers): Remove; not exported.
7858 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7859 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7860 was inaccessible from Lisp.
7861 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7862 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7864 alloc.c: Import and export fewer symbols, and remove unused items.
7865 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7867 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7868 it's not optimized away by whole-program optimization.
7869 (message_enable_multibyte, free_misc): Remove.
7870 (catchlist, handlerlist, mark_backtrace):
7871 Declare only if BYTE_MARK_STACK.
7872 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7873 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7874 (message_enable_multibyte): Remove decl.
7875 (free_misc, interval_free_list, float_block, float_block_index):
7876 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7877 (cons_free_list, last_marked_index):
7879 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7880 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7881 (mark_backtrace): Define only if BYTE_MARK_STACK.
7882 * xdisp.c (message_enable_multibyte): Now static.
7884 Declare Lisp_Object Q* variables to be 'static' if not exported.
7885 This makes it easier for human readers (and static analyzers)
7886 to see whether these variables are used from other modules.
7887 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7888 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7889 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7890 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7891 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7892 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7893 * xmenu.c, xselect.c:
7894 Declare Q* vars static if they are not used in other modules.
7895 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7896 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7897 Remove decls of unexported vars.
7898 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7900 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7902 Make Emacs functions such as Fatom 'static' by default.
7903 This makes it easier for human readers (and static analyzers)
7904 to see whether these functions can be called from other modules.
7905 DEFUN now defines a static function. To make the function external
7906 so that it can be used in other C modules, use the new macro DEFUE.
7907 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7908 (Finit_image_library):
7909 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7910 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7911 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7912 Remove decls, since these functions are now static.
7913 (Funintern, Fget_internal_run_time): New decls, since these functions
7914 were already external.
7916 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7917 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7918 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7919 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7920 * keyboard.c, keymap.c, lread.c:
7921 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7922 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7923 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7924 Mark functions with DEFUE instead of DEFUN,
7925 if they are used in other modules.
7926 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7927 decls for now-static functions.
7928 * buffer.h (Fdelete_overlay): Remove decl.
7929 * callproc.c (Fgetenv_internal): Mark as internal.
7930 * composite.c (Fremove_list_of_text_properties): Remove decl.
7931 (Fcomposition_get_gstring): New forward static decl.
7932 * composite.h (Fcomposite_get_gstring): Remove decl.
7933 * dired.c (Ffile_attributes): New forward static decl.
7934 * doc.c (Fdocumntation_property): New forward static decl.
7935 * eval.c (Ffetch_bytecode): New forward static decl.
7936 (Funintern): Remove extern decl; now in .h file where it belongs.
7937 * fileio.c (Fmake_symbolic_link): New forward static decl.
7938 * image.c (Finit_image_library): New forward static decl.
7939 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7940 * intervals.h (Fprevious_property_change):
7941 (Fremove_list_of_text_properties): Remove decls.
7942 * keyboard.c (Fthis_command_keys): Remove decl.
7943 (Fcommand_execute): New forward static decl.
7944 * keymap.c (Flookup_key): New forward static decl.
7945 (Fcopy_keymap): Now static.
7946 * keymap.h (Flookup_key): Remove decl.
7947 * process.c (Fget_process): New forward static decl.
7948 (Fprocess_datagram_address): Mark as internal.
7949 * syntax.c (Fsyntax_table_p): New forward static decl.
7950 (skip_chars): Remove duplicate decl.
7951 * textprop.c (Fprevious_property_change): New forward static decl.
7952 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7954 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7955 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7957 * editfns.c (Fformat): Remove unreachable code.
7959 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7961 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7964 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7966 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7967 when at ZV. (Bug#8487)
7969 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7971 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7973 * keyboard.c (parse_tool_bar_item): Likewise.
7974 * sound.c (sound_cleanup, alsa_close): Likewise.
7975 * termcap.c (tgetent): Likewise.
7976 * xfns.c (x_default_font_parameter): Likewise.
7977 * xsettings.c (read_and_apply_settings): Likewise.
7979 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7980 (overrun_check_free): Protoize.
7982 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7984 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7985 since callers should never pass a negative size.
7986 Change the signature to match that of plain 'read' and 'write'; see
7987 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7988 * lisp.h: Update prototypes of emacs_write and emacs_read.
7990 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7992 * xdisp.c (redisplay_window): Don't try to determine the character
7993 position of the scroll margin if the window start point w->startp
7994 is outside the buffer's accessible region. (Bug#8468)
7996 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7998 Fix write-region and its subroutines for buffers > 2GB.
7999 * fileio.c (a_write, e_write): Modify declaration of arguments and
8000 local variables to support buffers larger than 2GB.
8001 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8003 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8004 argument, local variables, and return value.
8006 * lisp.h: Update prototypes of emacs_write and emacs_read.
8008 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8010 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8012 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8014 Fix more problems found by GCC 4.6.0's static checks.
8016 * xdisp.c (vmessage): Use a better test for character truncation.
8018 * charset.c (load_charset_map): <, not <=, for optimization,
8019 and to avoid potential problems with integer overflow.
8020 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8021 * casetab.c (set_identity, shuffle): Likewise.
8022 * editfns.c (Fformat): Likewise.
8023 * syntax.c (skip_chars): Likewise.
8025 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8026 This also lets GCC 4.6.0 generate slightly better loop code.
8028 * callint.c (Fcall_interactively): <, not <=, for optimization.
8029 (Fcall_interactively): Count the number of arguments produced,
8030 not the number of arguments given. This is simpler and lets GCC
8031 4.6.0 generate slightly better code.
8033 * ftfont.c: Distingish more carefully between FcChar8 and char.
8034 The previous code passed unsigned char * to a functions like
8035 strlen and xstrcasecmp that expect char *, which does not
8036 conform to the C standard.
8037 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8038 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8039 char * when the C standard requires it.
8041 * keyboard.c (read_char): Remove unused var.
8043 * eval.c: Port to Windows vsnprintf (Bug#8435).
8045 (SIZE_MAX): Define if the headers do not.
8046 (verror): Do not give up if vsnprintf returns a negative count.
8047 Instead, grow the buffer. This ports to Windows vsnprintf, which
8048 does not conform to C99. Problem reported by Eli Zaretskii.
8049 Also, simplify the allocation scheme, by avoiding the need for
8050 calling realloc, and removing the ALLOCATED variable.
8052 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8054 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8055 But keep the doprint source code for now, as we might revamp it
8056 and use it again (Bug#8435).
8057 * lisp.h (doprnt): Remove.
8058 * Makefile.in (base_obj): Remove doprnt.o.
8059 * deps.mk (doprnt.o): Remove.
8061 error: Print 32- and 64-bit integers portably (Bug#8435).
8062 Without this change, on typical 64-bit hosts error ("...%d...", N)
8063 was used to print both 32- and 64-bit integers N, which relied on
8065 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8066 * lisp.h (error, verror): Mark as printf-like functions.
8067 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8068 Report overflow in size calculations when allocating printf buffer.
8069 Do not truncate output string at its first null byte.
8070 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8071 Truncate the output at a character boundary, since vsnprintf does not
8073 * charset.c (check_iso_charset_parameter): Convert internal
8074 character to string before calling 'error', since %c now has the
8076 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8077 overflow when computing char to be passed to 'error'. Do not
8078 pass Lisp_Object to 'error'; pass the integer instead.
8079 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8080 formatted with plain %d.
8082 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8084 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8086 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8088 * xterm.c (x_catch_errors): Remove duplicate declaration.
8090 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8092 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8094 2011-04-10 Jim Meyering <meyering@redhat.com>
8096 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8097 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8098 return ssize_t not "int", and use size_t as the buffer length.
8099 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8100 * gnutls.h: Update declarations.
8101 * process.c (read_process_output): Use ssize_t, to match.
8102 (send_process): Likewise.
8104 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8106 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8108 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8110 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8111 Use unsigned char, to match FcChar8 type definition.
8113 * xterm.c (handle_one_xevent):
8114 * xmenu.c (create_and_show_popup_menu):
8115 * xselect.c (x_decline_selection_request)
8116 (x_reply_selection_request): Avoid type-punned deref of X events.
8118 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8120 Fix some uses of `int' instead of EMACS_INT.
8121 * search.c (string_match_1, fast_string_match)
8122 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8123 (scan_buffer, find_next_newline_no_quit)
8124 (find_before_next_newline, search_command, Freplace_match)
8125 (Fmatch_data): Make some `int' variables be EMACS_INT.
8127 * xdisp.c (display_count_lines): 3rd argument and return value now
8128 EMACS_INT. All callers changed.
8129 (pint2hrstr): Last argument is now EMACS_INT.
8131 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8132 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8133 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8134 (decode_coding_utf_16, decode_coding_emacs_mule)
8135 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8136 (decode_coding_ccl, decode_coding_charset)
8137 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8138 (decode_coding_iso_2022, decode_coding_emacs_mule)
8139 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8140 <char_offset, last_offset>: Declare EMACS_INT.
8141 (encode_coding_utf_8, encode_coding_utf_16)
8142 (encode_coding_emacs_mule, encode_invocation_designation)
8143 (encode_designation_at_bol, encode_coding_iso_2022)
8144 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8145 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8147 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8148 (encode_invocation_designation): Last argument P_NCHARS is now
8150 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8151 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8153 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8156 * ccl.c (Fccl_execute_on_string): Declare some variables
8159 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8161 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8163 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8165 * process.c (Fformat_network_address): Doc fix.
8167 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8169 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8171 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8173 * keyboard.c (read_char): Call Lisp function help-form-show,
8174 instead of using internal_with_output_to_temp_buffer.
8175 (Qhelp_form_show): New var.
8176 (syms_of_keyboard): Use DEFSYM macro.
8178 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8180 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8182 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8184 * process.c (Flist_processes): Remove to Lisp.
8185 (list_processes_1): Delete.
8187 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8189 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8191 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8193 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8195 Fix more problems found by GCC 4.6.0's static checks.
8197 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8199 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8201 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8203 * xdisp.c (vmessage): Mark as a printf-like function.
8205 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8207 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8209 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8210 printf-like functions.
8211 (tiff_load): Add casts to remove these marks before passing them
8212 to system-supplied API.
8214 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8216 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8217 This avoids several warnings with gcc -Wstrict-overflow.
8218 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8219 directly, rather than having caller test rule sign. This avoids
8220 some unnecessary tests.
8221 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8222 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8223 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8225 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8226 (xfont_open): Avoid unnecessary tests.
8228 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8230 * composite.h, composite.c (composition_gstring_put_cache):
8231 Use EMACS_INT, not int, for length.
8233 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8234 breaking out part of COMPOSITION_DECODE_RULE.
8235 (COMPOSITION_DECODE_RULE): Use it.
8236 * composite.c (get_composition_id): Remove unused local vars,
8237 by using the new macro.
8239 * textprop.c (set_text_properties_1): Change while to do-while,
8240 since the condition is always true at first.
8242 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8243 (interval_deletion_adjustment): Return unsigned value.
8246 * process.c (list_processes_1, create_pty, read_process_output):
8247 (exec_sentinel): Remove vars that were set but not used.
8248 (create_pty): Remove unnecessary "volatile"s.
8249 (Fnetwork_interface_info): Avoid possibility of int overflow.
8250 (read_process_output): Do adaptive read buffering even if carryover.
8251 (read_process_output): Simplify nbytes computation if buffered.
8253 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8255 * syntax.c (scan_words): Remove var that was set but not used.
8256 (update_syntax_table): Use unsigned instead of int.
8258 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8259 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8260 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8262 * print.c (print_error_message): Avoid int overflow.
8264 * font.c (font_list_entities): Redo for clarity,
8265 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8267 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8268 (font_score): Avoid potential overflow in diff calculation.
8270 * fns.c (substring_both): Remove var that is set but not used.
8271 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8273 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8275 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8276 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8277 can always succeed if overflow has undefined behavior.
8279 * search.c (boyer_moore, wordify): Remove vars set but not used.
8280 (wordify): Omit three unnecessary tests.
8282 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8283 All callers changed. This avoids the need for an unused var.
8285 * casefiddle.c (casify_region): Remove var that is set but not used.
8287 * dired.c (file_name_completion): Remove var that is set but not used.
8289 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8291 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8292 (Finsert_file_contents): Remove unnecessary code checking fd.
8294 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8295 Check for integer overflow on size calculations.
8297 * buffer.c (Fprevious_overlay_change): Remove var that is set
8300 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8301 Remove vars that are set but not used.
8302 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8303 (timer_check_2): Mark vars as initialized.
8305 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8307 * image.c (lookup_image): Remove var that is set but not used.
8308 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8310 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8311 that are set but not used.
8313 * xfns.c (make_invisible_cursor): Don't return garbage
8314 if XCreateBitmapFromData fails (Bug#8410).
8316 * xselect.c (x_get_local_selection, x_handle_property_notify):
8317 Remove vars that are set but not used.
8319 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8320 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8322 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8323 Remove var that is set but not used.
8324 (scroll_bar_windows_size): Now size_t, not int.
8325 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8328 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8329 (map_tty_color) [!defined MSDOS]: Likewise.
8331 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8333 * coding.c: Remove vars that are set but not used.
8334 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8335 All callers changed.
8336 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8337 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8338 (decode_coding_charset): Remove vars that are set but not used.
8340 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8341 that is set but not used.
8343 * print.c (print_object): Remove var that is set but not used.
8345 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8346 The gnulib version avoids calling malloc in the usual case,
8347 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8348 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8349 * filelock.c (current_lock_owner): Likewise.
8350 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8351 * sysdep.c: Include allocator.h, careadlinkat.h.
8352 (emacs_no_realloc_allocator): New static constant.
8353 (emacs_readlink): New function.
8354 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8355 ../lib/careadlinkat.h.
8357 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8359 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8360 first non-nil return value).
8362 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8364 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8365 if not defined (Bug#8403).
8367 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8369 * xdisp.c (display_count_lines): Remove parameter `start',
8370 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8371 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8372 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8373 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8374 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8375 and thereabouts. All callers changed.
8376 (get_per_char_metric): Remove parameter `f', unused since
8377 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8379 2011-04-02 Jim Meyering <meyering@redhat.com>
8381 do not dereference NULL upon failed strdup
8382 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8383 (ns_get_family): Likewise.
8385 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8387 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8389 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8391 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8394 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8396 Add lexical binding.
8398 * window.c (Ftemp_output_buffer_show): New fun.
8399 (Fsave_window_excursion):
8400 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8402 * lread.c (lisp_file_lexically_bound_p): New function.
8403 (Fload): Bind Qlexical_binding.
8404 (readevalloop): Remove `evalfun' arg.
8405 Bind Qinternal_interpreter_environment.
8406 (Feval_buffer): Bind Qlexical_binding.
8407 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8409 (syms_of_lread): Declare `lexical-binding'.
8411 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8413 * keyboard.c (eval_dyn): New fun.
8414 (menu_item_eval_property): Use it.
8416 * image.c (parse_image_spec): Use Ffunctionp.
8418 * fns.c (concat, mapcar1): Accept byte-code-functions.
8420 * eval.c (Fsetq): Handle lexical vars.
8421 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8422 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8423 (FletX, Flet): Obey lexical binding.
8424 (Fcommandp): Handle closures.
8425 (Feval): New `lexical' arg.
8426 (eval_sub): New function extracted from Feval. Use it almost
8427 everywhere where Feval was used. Look up vars in lexical env.
8429 (Ffunctionp): Move from subr.el.
8430 (Ffuncall): Handle closures.
8431 (apply_lambda): Remove `eval_flags'.
8432 (funcall_lambda): Handle closures and new byte-code-functions.
8433 (Fspecial_variable_p): New function.
8434 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8435 but without exporting it to Lisp.
8437 * doc.c (Fdocumentation, store_function_docstring):
8438 * data.c (Finteractive_form): Handle closures.
8440 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8443 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8445 (exec_byte_code): New function extracted from Fbyte_code to handle new
8446 calling convention for byte-code-functions. Add new byte-codes.
8448 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8450 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8452 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8454 * xdisp.c (redisplay_internal): Fix prototype.
8456 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8458 * xdisp.c (SCROLL_LIMIT): New macro.
8459 (try_scrolling): Use it when setting scroll_limit.
8460 Limit scrolling to 100 screen lines.
8461 (redisplay_window): Even when falling back on "recentering",
8462 position point in the window according to scroll-conservatively,
8463 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8465 (try_scrolling): When point is above the window, allow searching
8466 as far as scroll_max, or one screenful, to compute vertical
8467 distance from PT to the scroll margin position. This prevents
8468 try_scrolling from unnecessarily failing when
8469 scroll-conservatively is set to a value slightly larger than the
8470 window height. Clean up the case of PT below the margin at bottom
8471 of window: scroll_max can no longer be INT_MAX. When aggressive
8472 scrolling is in use, don't let point enter the opposite scroll
8473 margin as result of the scroll.
8474 (syms_of_xdisp) <scroll-conservatively>: Document the
8475 threshold of 100 lines for never-recentering scrolling.
8477 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8479 * dispextern.h (move_it_by_lines):
8480 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8481 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8482 (message_log_check_duplicate): Remove parameters `prev_bol' and
8483 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8484 (redisplay_internal): Remove parameter `preserve_echo_area',
8485 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8487 * indent.c (Fvertical_motion):
8488 * window.c (window_scroll_pixel_based, Frecenter):
8489 Don't pass `need_y_p' to `move_it_by_lines'.
8491 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8493 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8494 steal a few bits to be more compact.
8495 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8496 Remove unneeded casts.
8498 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8500 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8502 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8503 binding" message (bug#7967).
8505 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8507 Fix more problems found by GCC 4.6.0's static checks.
8509 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8510 Remove unused local var.
8512 * editfns.c (Fmessage_box): Remove unused local var.
8514 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8515 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8516 Omit unused local vars.
8517 * window.c (shrink_windows): Omit unused local var.
8518 * menu.c (digest_single_submenu): Omit unused local var.
8519 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8520 Omit unused local var.
8522 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8523 Don't assume string length fits in int.
8524 (keyremap_step, read_key_sequence): Use size_t for sizes.
8525 (read_key_sequence): Don't check last_real_key_start redundantly.
8527 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8528 instead of alloca (Bug#8344).
8530 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8531 (Fbacktrace_frame): Don't assume nframes fits in int.
8533 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8535 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8538 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8540 * cm.c (calccost): Turn while-do into do-while, for clarity.
8542 * keyboard.c (syms_of_keyboard): Use the same style as later
8543 in this function when indexing through an array. This also
8544 works around GCC bug 48267.
8546 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8548 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8550 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8551 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8553 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8554 This avoids undefined behavior on integer overflow, and is a bit
8555 more convenient anyway since it is compared to a size_t variable.
8557 Variadic C functions now count arguments with size_t, not int.
8558 This avoids an unnecessary limitation on 64-bit machines, which
8559 caused (substring ...) to crash on large vectors (Bug#8344).
8560 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8561 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8562 All variadic functions and their callers changed accordingly.
8563 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8564 * data.c (arith_driver, float_arith_driver): Likewise.
8565 * editfns.c (general_insert_function): Likewise.
8566 * eval.c (struct backtrace.nargs, interactive_p)
8567 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8568 (funcall_lambda, mark_backtrace): Likewise.
8569 * fns.c (concat): Likewise.
8570 * frame.c (x_set_frame_parameters): Likewise.
8571 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8572 0 if not found, not -1. All callers changed.
8574 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8575 (stack_copy_size): Now size_t, not int.
8576 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8578 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8580 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8581 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8582 All callers changed.
8584 * lisp.h (multibyte_char_to_unibyte):
8585 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8586 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8587 * character.h (CHAR_TO_BYTE8):
8588 * cmds.c (internal_self_insert):
8589 * editfns.c (general_insert_function):
8590 * keymap.c (push_key_description):
8591 * search.c (Freplace_match):
8592 * xdisp.c (message_dolog, set_message_1): All callers changed.
8594 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8596 * keyboard.c (safe_run_hook_funcall): New function.
8597 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8598 don't set the hook to nil, but remove the offending function instead.
8599 (Qcommand_hook_internal): Remove, unused.
8600 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8601 Vcommand_hook_internal.
8603 * eval.c (enum run_hooks_condition): Remove.
8604 (funcall_nil, funcall_not): New functions.
8605 (run_hook_with_args): Call each function through a `funcall' argument.
8606 Remove `cond' argument, now redundant.
8607 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8608 (Frun_hook_with_args_until_failure): Adjust accordingly.
8609 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8611 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8613 * dispextern.h (string_buffer_position): Remove declaration.
8615 * print.c (strout): Remove parameter `multibyte', unused since
8616 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8618 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8619 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8620 All callers changed.
8622 * w32.c (_wsa_errlist): Use braces for struct initializers.
8624 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8625 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8626 All callers changed.
8627 (string_buffer_position): Likewise. Also, make static (it's never
8628 used outside xdisp.c).
8629 (cursor_row_p): Remove parameter `w', unused since
8630 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8631 (decode_mode_spec): Remove parameter `precision', introduced during
8632 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8633 All callers changed.
8635 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8637 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8639 2011-03-27 Anders Lindgren <andlind@gmail.com>
8641 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8642 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8643 (ns_update_auto_hide_menu_bar): New functions.
8644 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8645 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8646 ns_constrain_all_frames.
8647 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8648 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8650 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8652 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8654 2011-03-27 Glenn Morris <rgm@gnu.org>
8656 * syssignal.h: Replace RETSIGTYPE with void.
8657 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8658 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8659 Replace SIGTYPE with void everywhere.
8660 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8661 * s/template.h (SIGTYPE): Remove commented out definition.
8663 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8665 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8666 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8668 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8670 * w32.c (read_unc_volume): Use parameter `henum', instead of
8671 global variable `wget_enum_handle'.
8673 * keymap.c (describe_vector): Remove parameters `indices' and
8674 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8675 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8677 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8679 * keyboard.c (timer_check): Remove parameter `do_it_now',
8680 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8681 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8682 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8684 * keyboard.c (read_char):
8685 * w32menu.c (w32_menu_display_help):
8686 * xmenu.c (show_help_event, menu_help_callback):
8687 Adjust calls to `show_help_echo'.
8689 * gtkutil.c (xg_maybe_add_timer):
8690 * keyboard.c (readable_events):
8691 * process.c (wait_reading_process_output):
8692 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8694 * insdel.c (adjust_markers_gap_motion):
8695 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8696 (gap_left, gap_right): Don't call it.
8698 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8700 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8701 incurred during fontification.
8703 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8705 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8706 (DEFVAR_PER_BUFFER): Don't pass it.
8708 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8709 (scrolling_window): Don't pass it.
8711 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8713 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8715 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8717 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8718 of variables specific to SELinux and computation of `encoded_absname'.
8720 * image.c (XPutPixel): Remove unused variable `height'.
8722 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8724 * unexw32.c (get_section_info): Remove unused variable `section'.
8726 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8727 (system_process_attributes): Remove unused variable `sess'.
8728 (sys_read): Remove unused variable `err'.
8730 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8731 (w32_wnd_proc): Remove unused variable `isdead'.
8732 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8733 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8734 (x_create_tip_frame): Remove unused variable `tem'.
8736 * w32inevt.c (w32_console_read_socket):
8737 Remove unused variable `no_events'.
8739 * w32term.c (x_draw_composite_glyph_string_foreground):
8740 Remove unused variable `width'.
8742 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8744 * w32term.c (x_set_glyph_string_clipping):
8745 Don't pass uninitialized region to CombineRgn.
8747 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8749 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8750 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8751 (Fx_close_connection): Remove unused variable `i'.
8753 * w32font.c (w32font_draw): Return number of glyphs.
8754 (w32font_open_internal): Remove unused variable `i'.
8755 (w32font_driver): Add missing initializer.
8757 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8758 (fill_in_menu): Remove unused variable `items_added'.
8760 * w32term.c (last_mouse_press_frame): Remove static global variable.
8761 (w32_clip_to_row): Remove unused variable `f'.
8762 (x_delete_terminal): Remove unused variable `i'.
8764 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8765 (NOTHING): Remove unused static global variable.
8766 (uniscribe_check_otf): Remove unused variable `table'.
8767 (uniscribe_font_driver): Add missing initializers.
8769 2011-03-23 Julien Danjou <julien@danjou.info>
8771 * term.c (Fsuspend_tty, Fresume_tty):
8772 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8773 * window.c (temp_output_buffer_show):
8774 * insdel.c (signal_before_change):
8775 * frame.c (Fhandle_switch_frame):
8776 * fileio.c (Fdo_auto_save):
8777 * emacs.c (Fkill_emacs):
8778 * editfns.c (save_excursion_restore):
8779 * cmds.c (internal_self_insert):
8780 * callint.c (Fcall_interactively):
8781 * buffer.c (Fkill_all_local_variables):
8782 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8784 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8785 unconditionally since it does the check itself.
8787 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8789 Fix more problems found by GCC 4.5.2's static checks.
8791 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8792 the first time through the loop, since we know p0 < p1 then.
8793 This also avoids a gcc -Wstrict-overflow warning.
8795 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8796 leading to a memory leak, possible in functions like
8797 load_charset_map_from_file that can allocate an unbounded number
8798 of objects (Bug#8318).
8800 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8801 that could (at least in theory) be that large.
8803 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8804 This is less likely to overflow, and avoids undefined behavior if
8805 overflow does occur. All callers changed. Use strtoul to scan
8806 for the unsigned long integer.
8807 (pint2hrstr): Simplify and tune code slightly.
8808 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8810 * scroll.c (do_scrolling): Work around GCC bug 48228.
8811 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8813 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8814 This also avoids a warning with gcc -Wstrict-overflow.
8815 (validate_x_resource_name): Simplify count usage.
8816 This also avoids a warning with gcc -Wstrict-overflow.
8818 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8821 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8823 * process.c (Fmake_network_process): Use socklen_t, not int,
8824 where POSIX says socklen_t is required in portable programs.
8825 This fixes a porting bug on hosts like 64-bit HP-UX, where
8826 socklen_t is wider than int (Bug#8277).
8827 (Fmake_network_process, server_accept_connection):
8828 (wait_reading_process_output, read_process_output):
8831 * process.c: Rename or move locals to avoid shadowing.
8832 (list_processes_1, Fmake_network_process):
8833 (read_process_output_error_handler, exec_sentinel_error_handler):
8834 Rename or move locals.
8835 (Fmake_network_process): Define label "retry_connect" only if needed.
8836 (Fnetwork_interface_info): Fix pointer signedness.
8837 (process_send_signal): Add cast to avoid pointer signedness problem.
8838 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8839 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8841 Make tparam.h and terminfo.c consistent.
8842 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8843 Include tparam.h instead, since it declares them.
8844 * cm.h (PC): Remove extern decl; tparam.h now does this.
8845 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8846 * terminfo.c: Include tparam.h, to check interfaces.
8847 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8848 (tparam): Adjust signature to match interface in tparam.h;
8849 this removes some undefined behavior. Check that outstring and len
8850 are zero, which they always are with Emacs.
8851 * tparam.h (PC, BC, UP): New extern decls.
8853 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8854 (xftfont_open): Rename locals to avoid shadowing.
8856 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8857 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8858 (OTF_TAG_SYM): Omit macro if not needed.
8859 (ftfont_list): Remove unused local.
8860 (get_adstyle_property, ftfont_pattern_entity):
8861 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8862 Rename locals to avoid shadowing.
8864 * xfont.c (xfont_list_family): Mark var as initialized.
8866 * xml.c (make_dom): Now static.
8868 * composite.c (composition_compute_stop_pos): Rename local to
8870 (composition_reseat_it): Remove unused locals.
8871 (find_automatic_composition, composition_adjust_point): Likewise.
8872 (composition_update_it): Mark var as initialized.
8873 (find_automatic_composition): Mark vars as initialized,
8874 with a FIXME (Bug#8290).
8876 character.h: Rename locals to avoid shadowing.
8877 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8878 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8879 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8880 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8883 * textprop.c (property_change_between_p): Remove; unused.
8885 * intervals.c (interval_start_pos): Now static.
8887 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8889 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8890 Rename locals to avoid shadowing.
8892 * sound.c (wav_play, au_play, Fplay_sound_internal):
8893 Fix pointer signedness.
8894 (alsa_choose_format): Remove unused local var.
8895 (wav_play): Initialize a variable to 0, to prevent undefined
8896 behavior (Bug#8278).
8898 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8900 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8902 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8903 clobbering (Bug#8298).
8904 * sysdep.c (sys_subshell): Likewise.
8905 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8907 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8908 This should get cleaned up, so that child_setup has the
8909 same signature on all platforms.
8911 * callproc.c (call_process_cleanup): Now static.
8912 (relocate_fd): Rename locals to avoid shadowing.
8914 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8916 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8917 not to be necessary, and produces flickering.
8919 2011-03-20 Glenn Morris <rgm@gnu.org>
8921 * config.in: Remove file.
8923 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8925 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8926 are now in src/globals.h.
8927 (syms_of_minibuf): Remove spurious & from previous change.
8929 2011-03-20 Leo Liu <sdl.web@gmail.com>
8931 * minibuf.c (completing-read-function): New variable.
8932 (completing-read-default): Rename from completing-read.
8933 (completing-read): Call completing-read-function.
8935 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8937 * xfaces.c (Fx_load_color_file):
8938 Read color file from absolute filename (bug#8250).
8940 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8942 * makefile.w32-in: Update dependencies.
8944 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8946 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8948 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8950 Fix more problems found by GCC 4.5.2's static checks.
8952 * process.c (make_serial_process_unwind, send_process_trap):
8953 (sigchld_handler): Now static.
8955 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8956 That way, the code declares only the vars that it needs.
8957 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8958 * s/cygwin.h (PTY_ITERATION): Likewise.
8959 * s/darwin.h (PTY_ITERATION): Likewise.
8960 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8962 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8963 * process.c (allocate_pty): Don't declare stb unless it's needed.
8965 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8966 (CONSTANTLIM): Remove; unused.
8967 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8968 Define only if needed.
8970 * unexelf.c (unexec): Name an expression,
8971 to avoid gcc -Wbad-function-cast warning.
8972 Use a different way to cause a compilation error if anyone uses
8973 n rather than nn, a way that does not involve shadowing.
8974 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8976 * deps.mk (unexalpha.o): Remove; unused.
8978 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8979 * unexec.h: New file.
8980 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8981 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8983 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8984 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8985 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8986 Change as necessary to match prototype in unexec.h.
8988 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8990 (back_comment, skip_chars): Mark vars as initialized.
8992 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8993 Rename locals to avoid shadowing.
8995 * lread.c (read1): Rewrite so as not to use empty "else".
8996 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8998 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9000 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9001 warning when compiling print.c.
9003 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9004 instead of using an uninitialized var.
9005 (font_sort_entities): Mark var as initialized.
9007 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9009 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9010 pointers to constants.
9011 (font_parse_fcname): Remove unused vars.
9012 (font_delete_unmatched): Now static.
9013 (font_get_spec): Remove; unused.
9014 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9015 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9016 Rename or move locals to avoid shadowing.
9018 * fns.c (require_nesting_list, require_unwind): Now static.
9019 (Ffillarray): Rename locals to avoid shadowing.
9021 * floatfns.c (domain_error2): Define only if needed.
9022 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9024 * alloc.c (mark_backtrace): Move decl from here ...
9025 * lisp.h: ... to here, so that it can be checked.
9027 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9028 (Fdefvar): Rewrite so as not to use empty "else".
9029 (lisp_indirect_variable): Name an expression,
9030 to avoid gcc -Wbad-function-cast warning.
9031 (Fdefvar): Rename locals to avoid shadowing.
9033 * callint.c (quotify_arg, quotify_args): Now static.
9034 (Fcall_interactively): Rename locals to avoid shadowing.
9035 Use const pointer when appropriate.
9037 * lisp.h (get_system_name, get_operating_system_release):
9038 Move decls here, to check interfaces.
9039 * process.c (get_operating_system_release): Move decl to lisp.h.
9040 * xrdb.c (get_system_name): Likewise.
9041 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9042 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9043 some of which prompt warnings from gcc -Wbad-function-cast.
9044 (Fformat_time_string, Fencode_time, Finsert_char):
9045 (Ftranslate_region_internal, Fformat):
9046 Rename or remove local vars to avoid shadowing.
9047 (Ftranslate_region_internal): Mark var as initialized.
9049 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9052 * lisp.h (eassert): Check that the argument compiles, even if
9053 ENABLE_CHECKING is not defined.
9055 * data.c (Findirect_variable): Name an expression, to avoid
9056 gcc -Wbad-function-cast warning.
9057 (default_value, arithcompare, arith_driver, arith_error): Now static.
9058 (store_symval_forwarding): Rename local to avoid shadowing.
9059 (Fmake_variable_buffer_local, Fmake_local_variable):
9060 Mark variables as initialized.
9061 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9063 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9064 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9065 Rename locals to avoid shadowing.
9066 (mark_stack): Move local variables into the #ifdef region where
9068 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9069 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9071 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9072 (GC_STRING_CHARS): Remove; not used.
9073 (Fmemory_limit): Cast sbrk's returned value to char *.
9075 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9076 avoids undefined behavior in theory.
9078 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9080 Use functions, not macros, for up- and down-casing (Bug#8254).
9081 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9082 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9083 to use the following functions instead of these macros.
9084 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9085 EMACS_INT, since callers assume the returned value fits in int.
9086 (upcase1): Likewise, for UPCASE_TABLE.
9087 (uppercasep, lowercasep, upcase): New static inline functions.
9088 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9089 the race-condition problem in the old DOWNCASE.
9091 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9092 Rename locals to avoid shadowing.
9093 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9094 (regex_compile, re_search_2, re_match_2_internal):
9095 Remove unused local vars.
9096 (FREE_VAR): Rewrite so as not to use empty "else",
9097 which gcc can warn about.
9098 (regex_compile, re_match_2_internal): Mark locals as initialized.
9099 (RETALLOC_IF): Define only if needed.
9100 (WORDCHAR_P): Likewise. This one is never needed, but is used
9101 only in a comment talking about a compiler bug, so put inside
9102 the #if 0 of that comment.
9103 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9104 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9107 * search.c (boyer_moore): Rename locals to avoid shadowing.
9108 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9109 (PREV_CHAR_BOUNDARY): Likewise.
9111 * search.c (simple_search): Remove unused var.
9113 * dired.c (compile_pattern): Move decl from here ...
9114 * lisp.h: ... to here, so that it can be checked.
9115 (struct re_registers): New forward decl.
9117 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9119 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9121 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9122 Rename locals to avoid shadowing.
9123 (Fvertical_motion): Mark locals as initialized.
9125 * casefiddle.c (casify_object, casify_region): Now static.
9126 (casify_region): Mark local as initialized.
9128 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9130 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9131 New macros, so that the caller can use some names other than
9132 gcpro1, gcpro2, etc.
9133 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9135 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9136 argument, for consistency with GCPRO2_VAR, etc: it is now the
9137 prefix of the variable, not the variable itself. All uses
9139 * dired.c (directory_files_internal, file_name_completion):
9140 Rename locals to avoid shadowing.
9142 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9143 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9144 dired.c's scmp function, had undefined behavior.
9145 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9146 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9147 * buffer.h: ... to here, because these macros use current_buffer,
9148 and the new implementation with inline functions needs to have
9149 current_buffer in scope now, rather than later when the macros
9151 (downcase, upcase1): New static inline functions.
9152 (DOWNCASE, UPCASE1): Reimplement using these functions.
9153 This avoids undefined behavior in expressions like
9154 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9155 from race conditions in accessing the global variables
9156 case_temp1 and case_temp2.
9157 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9158 * lisp.h (case_temp1, case_temp2): Remove their decls.
9159 * character.h (ASCII_CHAR_P): Move from here ...
9160 * lisp.h: ... to here, so that the inline functions mentioned
9163 * dired.c (directory_files_internal_unwind): Now static.
9165 * fileio.c (file_name_as_directory, directory_file_name):
9166 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9168 (file_name_as_directory): Use const pointers when appropriate.
9169 (Fexpand_file_name): Likewise. In particular, newdir might
9170 point at constant storage, so make it a const pointer.
9171 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9172 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9174 (Fset_file_times, Finsert_file_contents, auto_save_error):
9175 Rename locals to avoid shadowing.
9177 * minibuf.c (choose_minibuf_frame_1): Now static.
9178 (Ftry_completion, Fall_completions): Rename or remove locals
9181 * marker.c (bytepos_to_charpos): Remove; unused.
9183 * lisp.h (verify_bytepos, count_markers): New decls,
9184 so that gcc does not warn that these functions aren't declared.
9186 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9187 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9188 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9189 (copy_text): Remove unused local var.
9191 * filelock.c (within_one_second): Now static.
9192 (lock_file_1): Rename local to avoid shadowing.
9194 * buffer.c (fix_overlays_before): Mark locals as initialized.
9195 (fix_start_end_in_overlays): Likewise. This function should be
9196 simplified by using pointers-to-pointers, but that's a different
9198 (switch_to_buffer_1): Now static.
9199 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9200 (report_overlay_modification): Rename locals to avoid shadowing.
9202 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9203 Fix pointer signedness issue.
9204 (sys_subshell): Mark local as volatile if checking for lint,
9205 to suppress a gcc -Wclobbered warning that does not seem to be right.
9206 (MAXPATHLEN): Define only if needed.
9208 * process.c (serial_open, serial_configure): Move decls from here ...
9209 * systty.h: ... to here, so that they can be checked.
9211 * fns.c (get_random, seed_random): Move extern decls from here ...
9212 * lisp.h: ... to here, so that they can be checked.
9214 * sysdep.c (reset_io): Now static.
9215 (wait_for_termination_signal): Remove; unused.
9217 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9218 (copy_keymap_item, append_key, push_text_char_description):
9220 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9221 (DENSE_TABLE_SIZE): Remove; unused.
9222 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9223 (describe_map_tree):
9224 Rename locals to avoid shadowing.
9226 * keyboard.c: Declare functions static if they are not used elsewhere.
9227 (echo_char, echo_dash, cmd_error, top_level_2):
9228 (poll_for_input, handle_async_input): Now static.
9229 (read_char, kbd_buffer_get_event, make_lispy_position):
9230 (make_lispy_event, make_lispy_movement, apply_modifiers):
9231 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9232 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9233 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9234 (read_key_sequence, read_char): Mark locals as initialized.
9235 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9237 * keyboard.h (make_ctrl_char): New decl.
9238 (mark_kboards): Move decl here ...
9239 * alloc.c (mark_kboards): ... from here.
9241 * lisp.h (force_auto_save_soon): New decl.
9243 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9244 (DEFINE_DUMMY_FUNCTION): New macro.
9245 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9247 (main): Add casts to avoid warnings
9248 if GCC considers string literals to be constants.
9250 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9252 * dbusbind.c: Pointer signedness fixes.
9253 (xd_signature, xd_append_arg, xd_initialize):
9254 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9255 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9256 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9257 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9259 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9260 if GCC considers string literals to be constants.
9261 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9263 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9265 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9266 (print_preprocess, print_object): New macro to fix last change.
9268 * print.c (print_preprocess): Don't forget font objects.
9270 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9272 * emacs.c (USAGE3): Doc fixes.
9274 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9276 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9279 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9281 * lisp.h (VWindow_system, Qfile_name_history):
9282 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9283 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9284 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9286 * w32select.c: Don't #include "keyboard.h".
9287 (run_protected): Add extern declaration for waiting_for_input.
9289 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9290 * w32console.c (detect_input_pending, read_input_pending)
9291 (encode_terminal_code):
9292 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9293 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9294 (w32_system_caret_y, Qfile_name_history):
9295 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9296 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9297 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9298 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9299 * w32proc.c (Qlocal, report_file_error):
9300 * w32term.c (Vwindow_system, updating_frame):
9301 * w32uniscribe.c (initialized, uniscribe_font_driver):
9302 Remove unneeded extern declarations.
9304 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9306 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9308 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9310 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9311 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9312 These macros can no longer be used for assignment.
9314 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9315 Assign struct members directly, instead of using BUF_BEGV etc.
9316 (record_buffer_markers, fetch_buffer_markers): New functions for
9317 recording and fetching special buffer markers.
9318 (set_buffer_internal_1, set_buffer_temp): Use them.
9320 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9322 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9324 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9325 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9327 * xdisp.c (hscroll_window_tree):
9328 (reconsider_clip_changes): Use PT instead of BUF_PT.
9330 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9332 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9333 $(EMACS_ROOT)/lib/intprops.h.
9335 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9337 Fix more problems found by GCC 4.5.2's static checks.
9339 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9340 to unsigned char * to avoid compiler diagnostic.
9341 (xg_free_frame_widgets): Make it clear that a local variable is
9342 needed only if USE_GTK_TOOLTIP.
9343 (gdk_window_get_screen): Make it clear that this macro is needed
9344 only if USE_GTK_TOOLTIP.
9345 (int_gtk_range_get_value): New function, which avoids a diagnostic
9346 from gcc -Wbad-function-cast.
9347 (xg_set_toolkit_scroll_bar_thumb): Use it.
9348 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9349 diagnostic from gcc -Wbad-function-cast.
9350 (get_utf8_string, xg_get_file_with_chooser):
9351 Rename locals to avoid shadowing.
9352 (create_dialog): Move locals to avoid shadowing.
9354 * xgselect.c (xg_select): Remove unused var.
9356 * image.c (four_corners_best): Mark locals as initialized.
9357 (gif_load): Initialize transparent_p to zero (Bug#8238).
9358 Mark another local as initialized.
9359 (my_png_error, my_error_exit): Mark with NO_RETURN.
9361 * image.c (clear_image_cache): Now static.
9362 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9363 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9364 (x_edge_detection): Remove unnecessary cast that
9365 gcc -Wbad-function-cast diagnoses.
9366 (gif_load): Fix pointer signedness.
9367 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9368 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9370 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9372 Improve quality of tests for time stamp overflow.
9373 For example, without this patch (encode-time 0 0 0 1 1
9374 1152921504606846976) returns the obviously-bogus value (-948597
9375 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9376 reports time overflow. See
9377 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9378 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9379 * editfns.c: Include limits.h and intprops.h.
9380 (TIME_T_MIN, TIME_T_MAX): New macros.
9381 (time_overflow): Move earlier, to before first use.
9382 (hi_time, lo_time): New functions, for an accurate test for
9384 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9385 (Fget_internal_run_time): Don't assume time_t fits in int.
9386 (make_time): Use list2 instead of Fcons twice.
9387 (Fdecode_time): More accurate test for out-of-range times.
9388 (check_tm_member): New function.
9389 (Fencode_time): Use it, to test for out-of-range times.
9390 (lisp_time_argument): Don't rely on undefined left-shift and
9391 right-shift behavior when checking for time stamp overflow.
9393 * editfns.c (time_overflow): New function, refactoring common code.
9394 (Fformat_time_string, Fdecode_time, Fencode_time):
9395 (Fcurrent_time_string): Use it.
9397 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9398 * dired.c (make_time): Move to ...
9399 * editfns.c (make_time): ... here.
9400 * systime.h: Note the move.
9402 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9404 * fringe.c (update_window_fringes): Remove unused variables.
9406 * unexmacosx.c (copy_data_segment): Also copy __got section.
9409 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9411 * termcap.c [MSDOS]: Include "msdos.h".
9412 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9413 Constify `char *' arguments and their references according to
9414 prototypes in tparam.h.
9416 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9418 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9419 Adapt all references accordingly.
9421 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9423 2011-03-11 Tom Tromey <tromey@redhat.com>
9425 * buffer.c (syms_of_buffer): Remove obsolete comment.
9427 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9429 * termhooks.h (encode_terminal_code): Declare prototype.
9431 * msdos.c (encode_terminal_code): Don't declare prototype.
9433 * term.c (encode_terminal_code): Now external again, used by
9434 w32console.c and msdos.c.
9436 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9437 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9439 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9441 Fix some minor problems found by GCC 4.5.2's static checks.
9443 * fringe.c (update_window_fringes): Mark locals as initialized
9445 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9447 * alloc.c (mark_fringe_data): Move decl from here ...
9448 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9449 to check its interface.
9450 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9452 * fontset.c (free_realized_fontset): Now static.
9453 (Fset_fontset_font): Rename local to avoid shadowing.
9454 (fontset_font): Mark local as initialized.
9455 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9457 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9459 * xselect.c (x_disown_buffer_selections): Remove; not used.
9460 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9461 (x_own_selection, Fx_disown_selection_internal): Rename locals
9463 (x_handle_dnd_message): Remove local to avoid shadowing.
9465 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9466 so that the caller can use some name other than gcpro1.
9467 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9468 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9469 (Fx_backspace_delete_keys_p):
9470 Use them to avoid shadowing, and rename vars to avoid shadowing.
9471 (x_decode_color, x_set_name, x_window): Now static.
9472 (Fx_create_frame): Add braces to silence GCC warning.
9473 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9474 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9475 Remove unused locals.
9476 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9477 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9478 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9481 * xterm.h (x_mouse_leave): New decl.
9483 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9484 Remove unused functions.
9485 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9486 (x_calc_absolute_position): Now static.
9487 (XTread_socket): Don't define label "out" unless it's used.
9488 Don't declare local "event" unless it's used.
9489 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9490 unless they are used.
9491 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9492 (x_fatal_error_signal): Remove; not used.
9493 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9494 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9495 (x_error_catcher, x_connection_closed, x_error_handler):
9496 (x_error_quitter, xembed_send_message, x_iconify_frame):
9497 (my_log_handler): Rename locals to avoid shadowing.
9498 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9499 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9501 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9502 Rename or move locals to avoid shadowing.
9503 (tty_defined_color, merge_face_heights): Now static.
9504 (free_realized_faces_for_fontset): Remove; not used.
9505 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9506 does not deduce is never used uninitialized.
9507 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9508 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9510 * terminal.c (store_terminal_param): Now static.
9512 * xmenu.c (menu_highlight_callback): Now static.
9513 (set_frame_menubar): Remove unused local.
9514 (xmenu_show): Rename parameter to avoid shadowing.
9515 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9516 since they might point to immutable storage.
9517 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9518 since it's unused otherwise.
9520 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9521 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9522 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9523 avoids a gcc -Wuninitialized diagnostic.
9524 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9525 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9526 does not deduce are never used uninitialized.
9528 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9530 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9531 * window.c (window_loop, size_window):
9532 (run_window_configuration_change_hook, enlarge_window): Likewise.
9534 * window.c (display_buffer): Now static.
9535 (size_window): Mark variables that gcc -Wuninitialized
9536 does not deduce are never used uninitialized.
9537 * window.h (check_all_windows): New decl, to forestall
9538 gcc -Wmissing-prototypes diagnostic.
9539 * dispextern.h (bidi_dump_cached_states): Likewise.
9541 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9543 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9545 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9546 and to avoid gcc -Wuninitialized warning.
9547 (load_charset_map): Mark variables that gcc -Wuninitialized
9548 does not deduce are never used uninitialized.
9549 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9551 * coding.c (coding_set_source, coding_set_destination):
9552 Use "else { /* comment */ }" rather than "else /* comment */;"
9553 for clarity, and to avoid gcc -Wempty-body warning.
9554 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9555 a block, when the outer 'i' will do.
9556 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9557 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9558 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9559 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9560 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9561 Rename locals to avoid shadowing.
9562 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9563 * coding.c (emacs_mule_char, encode_invocation_designation):
9564 Now static, since they're not used elsewhere.
9565 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9566 (decode_coding_object, encode_coding_object, detect_coding_system):
9567 (decode_coding_emacs_mule): Mark variables that gcc
9568 -Wuninitialized does not deduce are never used uninitialized.
9569 (detect_coding_iso_2022): Initialize a local variable that might
9570 be used uninitialized. Leave a FIXME because it's not clear that
9571 this initialization is needed. (Bug#8211)
9572 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9573 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9574 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9575 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9576 Remove unused macros.
9578 * category.c (hash_get_category_set): Remove unused local var.
9579 (copy_category_table): Now static, since it's not used elsewhere.
9580 * character.c (string_count_byte8): Likewise.
9582 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9583 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9585 * chartab.c (copy_sub_char_table): Now static, since it's not used
9587 (sub_char_table_ref_and_range, char_table_ref_and_range):
9588 Rename locals to avoid shadowing.
9589 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9591 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9592 (BIDI_BOB): Remove unused macro.
9594 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9595 deduce are never used uninitialized.
9596 * term.c (encode_terminal_code): Likewise.
9598 * term.c (encode_terminal_code): Now static. Remove unused local.
9600 * tparam.h: New file.
9601 * term.c, tparam.h: Include it.
9602 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9603 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9604 Move these decls to tparam.h, and make them agree with what
9605 is actually in tparam.c. The previous trick of using incompatible
9606 decls in different modules does not conform to the C standard.
9607 All callers of tparam changed to use tparam's actual API.
9608 * tparam.c (tparam1, tparam, tgoto):
9609 Use const pointers where appropriate.
9611 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9612 * cm.h (struct cm): Likewise.
9613 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9614 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9615 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9616 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9617 (turn_on_face, init_tty): Likewise.
9618 * termchar.h (struct tty_display_info): Likewise.
9620 * term.c (term_mouse_position): Rename local to avoid shadowing.
9622 * alloc.c (mark_ttys): Move decl from here ...
9623 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9625 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9627 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9629 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9631 * search.c (compile_pattern_1): Remove argument regp, unused since
9632 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9633 (compile_pattern): Don't pass it.
9635 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9637 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9638 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9640 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9642 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9644 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9645 gdk_window_get_screen, gdk_window_get_geometry,
9646 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9647 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9648 (xg_get_pixbuf_from_pixmap): New function.
9649 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9650 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9651 Call xg_get_pixbuf_from_pixmap instead of
9652 gdk_pixbuf_get_from_drawable.
9653 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9654 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9655 (xg_check_special_colors): Use GtkStyleContext and its functions
9657 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9658 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9659 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9660 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9661 Call gtk_widget_get_preferred_size.
9662 (xg_frame_resized): gdk_window_get_geometry only takes 5
9664 (xg_win_to_widget, xg_event_is_for_menubar):
9665 Call gdk_x11_window_lookup_for_display.
9666 (xg_set_widget_bg): New function.
9667 (delete_cb): New function.
9668 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9669 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9670 (xg_set_background_color): Call xg_set_widget_bg.
9671 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9672 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9673 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9674 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9676 (update_frame_tool_bar): Call gtk_widget_hide.
9677 (xg_initialize): Use GDK_KEY_g.
9679 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9681 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9683 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9684 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9685 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9687 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9689 * w32xfns.c (select_palette): Check success of RealizePalette against
9690 GDI_ERROR, not zero.
9692 See ChangeLog.11 for earlier changes.
9698 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9700 This file is part of GNU Emacs.
9702 GNU Emacs is free software: you can redistribute it and/or modify
9703 it under the terms of the GNU General Public License as published by
9704 the Free Software Foundation, either version 3 of the License, or
9705 (at your option) any later version.
9707 GNU Emacs is distributed in the hope that it will be useful,
9708 but WITHOUT ANY WARRANTY; without even the implied warranty of
9709 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9710 GNU General Public License for more details.
9712 You should have received a copy of the GNU General Public License
9713 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.