1 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3 * makefile.w32-in: Update dependencies.
5 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7 Improve `doprnt' and its usage. (Bug#8545)
8 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9 `format_end'. Remove support for %l as a conversion specifier.
10 Don't use xrealloc. Improve diagnostics when the %l size modifier
11 is used. Update the commentary.
13 * eval.c (verror): Simplify calculation of size_t.
15 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
18 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
20 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
23 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
25 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
26 This makes this file independent of the recent pseudovector change.
28 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
30 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
32 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
33 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
35 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
37 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
38 GCC 4.6.0 optimizes based on type-based alias analysis. For
39 example, if b is of type struct buffer * and v of type struct
40 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
41 != &v->size, and therefore "v->size = 1; b->size = 2; return
42 v->size;" must therefore return 1. This assumption is incorrect
43 for Emacs, since it type-puns struct Lisp_Vector * with many other
44 types. To fix this problem, this patch adds a new type struct
45 vectorlike_header that documents the constraints on layout of vectors
46 and pseudovectors, and helps optimizing compilers not get fooled
47 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
48 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
49 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
51 (XSETPVECTYPE): Rewrite in terms of new macro.
52 (XSETPVECTYPESIZE): New macro, specifying both type and size.
53 This is a bit clearer, and further avoids the possibility of
55 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
56 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
57 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
58 since Lisp_Subr is a special case (no "next" field).
59 (ASIZE): Now uses header.size rather than size. All
60 previous uses of XVECTOR (foo)->size replaced to use this macro,
61 to avoid the hassle of writing XVECTOR (foo)->header.size.
62 (struct vectorlike_header): New type.
63 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
64 object, to help avoid aliasing.
65 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
66 (SUBRP): Likewise, since Lisp_Subr is a special case.
67 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
68 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
69 (struct Lisp_Hash_Table): Combine first two members into a single
70 struct vectorlike_header member. All uses of "size" and "next" members
71 changed to be "header.size" and "header.next".
72 * buffer.h (struct buffer): Likewise.
73 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
74 * frame.h (struct frame): Likewise.
75 * process.h (struct Lisp_Process): Likewise.
76 * termhooks.h (struct terminal): Likewise.
77 * window.c (struct save_window_data, struct saved_window): Likewise.
78 * window.h (struct window): Likewise.
79 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
80 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
81 * buffer.c (init_buffer_once): Likewise.
82 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
84 * process.c (Fformat_network_address): Use local var for size,
87 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
89 Make the Lisp reader and string-to-float more consistent (Bug#8525)
90 * data.c (atof): Remove decl; no longer used or needed.
91 (digit_to_number): Move to lread.c.
92 (Fstring_to_number): Use new string_to_number function, to be
93 consistent with how the Lisp reader treats infinities and NaNs.
94 Do not assume that floating-point numbers represent EMACS_INT
95 without losing information; this is not true on most 64-bit hosts.
96 Avoid double-rounding errors, by insisting on integers when
97 parsing non-base-10 numbers, as the documentation specifies.
98 * lisp.h (string_to_number): New decl, replacing ...
99 (isfloat_string): Remove.
100 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
101 (read1): Do not accept +. and -. as integers; this
102 appears to have been a coding error. Similarly, do not accept
103 strings like +-1e0 as floating point numbers. Do not report
104 overflow for integer overflows unless the base is not 10 which
105 means we have no simple and reliable way to continue.
106 Break out the floating-point parsing into a new
107 function string_to_number, so that Fstring_to_number parses
108 floating point numbers consistently with the Lisp reader.
109 (digit_to_number): Moved here from data.c. Make it static inline.
110 (E_CHAR, EXP_INT): Remove, replacing with ...
111 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
112 (string_to_number): New function, replacing isfloat_string.
113 This function checks for valid syntax and produces the resulting
114 Lisp float number too. Rework it so that string-to-number
115 no longer mishandles examples like "1.0e+". Use strtoumax,
116 so that overflow for non-base-10 numbers is reported only when
117 there's no portable and simple way to convert to floating point.
119 * textprop.c (set_text_properties_1): Rewrite for clarity,
120 and to avoid GCC warning about integer overflow.
122 * intervals.h (struct interval): Use EMACS_INT for members
123 where EMACS_UINT might cause problems. See
124 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
125 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
126 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
128 (offset_intervals): Tell GCC not to worry about length overflow
129 when negating a negative length.
131 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
132 (overrun_check_free): Likewise.
134 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
135 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
138 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
139 (gnutls_make_error): Rename local to avoid shadowing.
140 (gnutls_emacs_global_deinit): ifdef out; not used.
141 (Fgnutls_boot): Use const for pointer to readonly storage.
142 Comment out unused local. Fix pointer signedness problems.
144 * lread.c (openp): Don't stuff size_t into an 'int'.
145 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
146 about possible signed overflow.
148 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
149 (GDK_KEY_g): Don't define if already defined.
150 (xg_prepare_tooltip): Avoid pointer signedness problem.
151 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
153 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
154 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
156 * xfns.c (Fx_window_property): Simplify a bit,
157 to make a bit faster and to avoid GCC 4.6.0 warning.
158 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
160 * fns.c (internal_equal): Don't assume size_t fits in int.
162 * alloc.c (compact_small_strings): Tighten assertion a little.
164 Replace pEd with more-general pI, and fix some printf arg casts.
165 * lisp.h (pI): New macro, generalizing old pEd macro to other
166 conversion specifiers. For example, use "...%"pI"d..." rather
168 (pEd): Remove. All uses replaced with similar uses of pI.
169 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
170 * alloc.c (check_pure_size): Don't overflow by converting size to int.
171 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
172 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
173 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
174 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
175 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
177 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
178 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
179 * print.c (safe_debug_print, print_object): Likewise.
180 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
182 Use pI instead of if-then-else-abort. Use %p to avoid casts,
183 avoiding the 0 flag, which is not portable.
184 * process.c (Fmake_network_process): Use pI to avoid cast.
185 * region-cache.c (pp_cache): Likewise.
186 * xdisp.c (decode_mode_spec): Likewise.
187 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
188 behavior on 64-bit hosts with printf arg.
189 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
190 (x_stop_queuing_selection_requests): Likewise.
191 (x_get_window_property): Don't truncate byte count to an 'int'
194 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
195 here, since it parses constructs like leading '-' and spaces,
196 which are not wanted; and it overflows with large numbers.
197 Instead, simply match F[0-9]+, which is what is wanted anyway.
199 * alloc.c: Remove unportable assumptions about struct layout.
200 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
201 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
202 (allocate_vectorlike, make_pure_vector): Use the new macros,
203 plus offsetof, to remove unportable assumptions about struct layout.
204 These assumptions hold on all porting targets that I know of, but
205 they are not guaranteed, they're easy to remove, and removing them
206 makes further changes easier.
208 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
209 This doesn't fix a bug but makes the code clearer.
210 (string_overrun_cookie): Now const. Use initializers that
211 don't formally overflow signed char, to avoid warnings.
212 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
213 can cause Emacs to crash when string overrun checking is enabled.
214 (allocate_buffer): Don't assume sizeof (struct buffer) is a
215 multiple of sizeof (EMACS_INT); it need not be, if
216 alignof(EMACS_INT) < sizeof (EMACS_INT).
217 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
219 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
221 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
223 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
225 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
226 supposed to be handshaking. (Bug#8556)
227 Reported by Paul Eggert <eggert@cs.ucla.edu>.
229 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
231 * lisp.h (Qdebug): List symbol.
232 * eval.c (Qdebug): Restore global linkage.
233 * keyboard.c (debug-on-event): New variable.
234 (handle_user_signal): Break into debugger when debug-on-event
235 matches the current signal symbol.
237 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
239 * alloc.c (check_sblock, check_string_bytes)
240 (check_string_free_list): Convert to standard C.
242 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
244 * w32.c (emacs_gnutls_push): Fix typo.
246 2011-04-25 Eli Zaretskii <eliz@gnu.org>
248 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
249 "cast to pointer from integer of different size".
251 Improve doprnt and its use in verror. (Bug#8545)
252 * doprnt.c (doprnt): Document the set of format control sequences
253 supported by the function. Use SAFE_ALLOCA instead of always
256 * eval.c (verror): Don't limit the buffer size at size_max-1, that
257 is one byte too soon. Don't use xrealloc; instead xfree and
260 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
262 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
265 * gnutls.c: Renamed global_initialized to
266 gnutls_global_initialized. Added internals for the
267 :verify-hostname-error, :verify-error, and :verify-flags
268 parameters of `gnutls-boot' and documented those parameters in the
269 docstring. Start callback support.
270 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
271 unless a fatal error occured. Call gnutls_alert_send_appropriate
272 on error. Return error code.
273 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
274 (emacs_gnutls_read): Likewise.
275 (Fgnutls_boot): Return handshake error code.
276 (emacs_gnutls_handle_error): New function.
277 (wsaerror_to_errno): Likewise.
279 * w32.h (emacs_gnutls_pull): Add prototype.
280 (emacs_gnutls_push): Likewise.
282 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
283 (emacs_gnutls_push): Likewise.
285 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
287 * process.c (wait_reading_process_output): Check if GnuTLS
288 buffered some data internally if no FDs are set for TLS
291 * makefile.w32-in (OBJ2): Add gnutls.$(O).
292 (LIBS): Link to USER_LIBS.
293 ($(BLD)/gnutls.$(0)): New target.
295 2011-04-24 Eli Zaretskii <eliz@gnu.org>
297 * xdisp.c (handle_single_display_spec): Rename the
298 display_replaced_before_p argument into display_replaced_p, to
299 make it consistent with the commentary. Fix typos in the
302 * textprop.c (syms_of_textprop): Remove dead code.
303 (copy_text_properties): Delete obsolete commentary about an
304 interface that was deleted long ago. Fix typos in the description
307 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
308 to changes in oldXMenu/XMenu.h from 2011-04-16.
309 <menu_help_message, prev_menu_help_message>: Constify.
310 (IT_menu_make_room): menu->help_text is now `const char **';
313 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
314 to changes in oldXMenu/XMenu.h from 2011-04-16.
315 (struct XMenu): Declare `help_text' `const char **'.
317 * xfaces.c <Qunspecified>: Make extern again.
319 * syntax.c: Include sys/types.h before including regex.h, as
322 * doc.c (get_doc_string): Improve the format passed to `error'.
324 * doprnt.c (doprnt): Improve commentary.
326 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
328 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
331 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
332 changes in globals.h immediately force recompilation.
333 (TAGS): Depend on $(CURDIR)/m/intel386.h and
334 $(CURDIR)/s/ms-w32.h.
335 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
337 * character.c (Fchar_direction): Function deleted.
338 (syms_of_character): Don't defsubr it.
339 <char-direction-table>: Deleted.
341 2011-04-23 Eli Zaretskii <eliz@gnu.org>
343 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
344 * doprnt.c: Include limits.h.
345 (SIZE_MAX): New macro.
346 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
347 local variables are now size_t instead of int or unsigned.
348 Improve overflow protection. Support `l' modifier for integer
349 conversions. Support %l conversion. Don't assume an EMACS_INT
350 argument for integer conversions and for %c.
352 * lisp.h (doprnt): Restore prototype.
354 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
357 * Makefile.in (base_obj): Add back doprnt.o.
359 * deps.mk (doprnt.o): Add back prerequisites.
360 (callint.o): Depend on character.h.
362 * eval.c (internal_lisp_condition_case): Include the handler
363 representation in the error message.
364 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
365 when breaking from the loop.
367 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
369 * callint.c (Fcall_interactively): When displaying error message
370 about invalid control letter, pass the character's codepoint, not
371 a pointer to its multibyte form. Improve display of the character
372 in octal and display also its hex code.
374 * character.c (char_string): Use %x to display the (unsigned)
375 codepoint of an invalid character, to avoid displaying a bogus
378 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
379 `error', not SYMBOL_NAME itself.
381 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
382 character arguments to `error'.
384 * charset.c (check_iso_charset_parameter): Fix incorrect argument
385 to `error' in error message about FINAL_CHAR argument. Make sure
386 FINAL_CHAR is a character, and use %c when it is passed as
389 2011-04-23 Eli Zaretskii <eliz@gnu.org>
391 * s/ms-w32.h (localtime): Redirect to sys_localtime.
393 * w32.c: Include <time.h>.
394 (sys_localtime): New function.
396 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
398 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
400 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
402 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
404 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
407 2011-04-19 Eli Zaretskii <eliz@gnu.org>
409 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
410 gl_state.e_property when gl_state.object is Qt.
412 * insdel.c (make_gap_larger): Remove limitation of buffer size
415 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
417 * xdisp.c (lookup_glyphless_char_display)
418 (produce_glyphless_glyph): Handle cons cell entry in
419 glyphless-char-display.
420 (Vglyphless_char_display): Document it.
422 * term.c (produce_glyphless_glyph): Handle cons cell entry in
423 glyphless-char-display.
425 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
427 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
429 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
431 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
432 definition for no-X builds.
434 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
436 Static checks with GCC 4.6.0 and non-default toolkits.
438 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
440 * process.c (keyboard_bit_set): Define only if SIGIO.
441 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
442 (send_process): Repair possible setjmp clobbering.
444 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
446 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
448 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
450 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
451 Define only if needed.
453 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
454 by pacifying GCC about it. Maybe it's time to retire it?
455 * xfaces.c (USG, __TIMEVAL__): Likewise.
457 * dispextern.h (struct redisplay_interface): Rename param
459 * termhooks.h (struct terminal): Likewise.
460 * xterm.c (xembed_send_message): Likewise.
462 * insdel.c (make_gap_smaller): Define only if
463 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
465 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
468 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
469 so that we aren't warned about unused symbols.
471 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
473 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
475 * xfns.c (x_real_positions): Mark locals as initialized.
477 * xmenu.c (xmenu_show): Don't use uninitialized vars.
479 * xterm.c: Fix problems found by static analysis with other toolkits.
480 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
481 (x_dispatch_event): Declare static if USE_GTK, and
482 define if USE_GTK || USE_X_TOOLKIT.
483 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
484 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
485 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
486 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
488 * xmenu.c (menu_help_callback): Pointer type fixes.
489 Use const pointers when pointing at readonly data. Avoid pointer
491 (FALSE): Remove unused macro.
492 (update_frame_menubar): Remove unused decl.
494 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
496 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
497 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
498 (single_menu_item): Rename local to avoid shadowing.
500 * keyboard.c (make_lispy_event): Remove unused local var.
502 * frame.c, frame.h (x_get_resource_string): Bring this back, but
503 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
505 * bitmaps: Change bitmaps from unsigned char back to the X11
506 compatible char. Avoid the old compiler warnings about
507 out-of-range initializers by using, for example, '\xab' rather
510 * xgselect.c (xgselect_initialize): Check vs interface
511 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
513 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
515 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
518 * fns.c (vector): Remove; this old hack is no longer needed.
520 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
522 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
524 * xrdb.c (x_load_resources): Omit unused local.
526 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
527 (x_window): Rename locals to avoid shadowing.
528 (USG): Use the kludged USG macro, to pacify gcc.
530 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
531 (x_term_init): Remove local to avoid shadowing.
533 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
535 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
536 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
538 2011-04-16 Eli Zaretskii <eliz@gnu.org>
540 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
542 Fix regex.c, syntax.c and friends for buffers > 2GB.
543 * syntax.h (struct gl_state_s): Declare character position members
546 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
548 * textprop.c (verify_interval_modification, interval_of): Declare
551 * intervals.c (adjust_intervals_for_insertion): Declare arguments
554 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
556 * indent.c (Fvertical_motion): Local variable it_start is now
559 * regex.c (re_match, re_match_2, re_match_2_internal)
560 (bcmp_translate, regcomp, regexec, print_double_string)
561 (group_in_compile_stack, re_search, re_search_2, regex_compile)
562 (re_compile_pattern, re_exec): Declare arguments and local
563 variables `size_t' and `ssize_t' and return values `regoff_t', as
565 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
566 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
567 <compile_stack_type>: `size' and `avail' are now `size_t'.
569 * regex.h <regoff_t>: Use ssize_t, not int.
570 (re_search, re_search_2, re_match, re_match_2): Arguments that
571 specify buffer/string position and length are now ssize_t and
572 size_t. Return type is regoff_t.
574 2011-04-16 Ben Key <bkey76@gmail.com>
576 * nsfont.m: Fixed bugs in ns_get_family and
577 ns_descriptor_to_entity that were caused by using free to
578 deallocate memory blocks that were allocated by xmalloc (via
579 xstrdup). This caused Emacs to crash when compiled with
580 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
581 --enable-checking=xmallocoverrun). xfree is now used to
582 deallocate these memory blocks.
584 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
586 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
588 emacs_write: Accept and return EMACS_INT for sizes.
589 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
591 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
592 Accept and return EMACS_INT.
593 (emacs_gnutls_write): Return the number of bytes written on
595 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
596 (emacs_read, emacs_write): Remove check for negative size, as the
597 Emacs source code has been audited now.
598 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
599 (emacs_read, emacs_write): Use it.
600 * process.c (send_process): Adjust to the new signatures of
601 emacs_write and emacs_gnutls_write. Do not attempt to store
602 a byte offset into an 'int'; it might overflow.
603 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
605 * sound.c: Don't assume sizes fit in 'int'.
606 (struct sound_device.period_size, alsa_period_size):
607 Return EMACS_INT, not int.
608 (struct sound_device.write, vox_write, alsa_write):
609 Accept EMACS_INT, not int.
610 (wav_play, au_play): Use EMACS_INT to store sizes and to
611 record read return values.
613 2011-04-15 Ben Key <bkey76@gmail.com>
615 * keyboard.c (Qundefined): Don't declare static since it is used
617 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
618 static since they are used in nsfont.m.
620 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
622 * process.c (Qprocessp): Don't declare static.
623 * lisp.h (Qprocessp): Declare again.
625 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
627 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
629 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
631 Improve C-level modularity by making more things 'static'.
633 Don't publish debugger-only interfaces to other modules.
634 * lisp.h (safe_debug_print, debug_output_compilation_hack):
635 (verify_bytepos, count_markers): Move decls to the only modules
637 * region-cache.h (pp_cache): Likewise.
638 * window.h (check_all_windows): Likewise.
639 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
641 * sysdep.c (croak): Now static, if
642 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
643 * syssignal.h (croak): Declare only if not static.
645 * alloc.c (refill_memory_reserve): Now static if
646 !defined REL_ALLOC || defined SYSTEM_MALLOC.
647 * lisp.h (refill_memory_reserve): Declare only if not static.
649 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
650 Define only if USE_LUCID.
652 * xrdb.c (x_customization_string, x_rm_string): Now static.
654 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
655 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
657 * xdisp.c (draw_row_with_mouse_face): Now static.
658 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
660 * window.h (check_all_windows): Mark externally visible.
662 * window.c (window_deletion_count): Now static.
664 * undo.c: Make symbols static if they're not exported.
665 (last_undo_buffer, last_boundary_position, pending_boundary):
668 * textprop.c (interval_insert_behind_hooks): Now static.
669 (interval_insert_in_front_hooks): Likewise.
671 * term.c: Make symbols static if they're not exported.
672 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
673 (max_frame_lines, tty_set_terminal_modes):
674 (tty_reset_terminal_modes, tty_turn_off_highlight):
675 (get_tty_terminal): Now static.
676 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
677 * termhooks.h (term_mouse_moveto): Do not declare if
679 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
680 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
682 * sysdep.c: Make symbols static if they're not exported.
683 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
685 (sigprocmask_set, full_mask): Remove; unused.
686 (wait_debugging): Mark as visible.
687 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
688 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
690 * syntax.c (syntax_temp): Define only if !__GNUC__.
692 * sound.c (current_sound_device, current_sound): Now static.
694 * search.c (searchbufs, searchbuf_head): Now static.
696 * scroll.c (scroll_cost): Remove; unused.
697 * dispextern.h (scroll_cost): Remove decl.
699 * region-cache.h (pp_cache): Mark as externally visible.
701 * process.c: Make symbols static if they're not exported.
702 (process_tick, update_tick, create_process, chan_process):
703 (Vprocess_alist, proc_buffered_char, datagram_access):
704 (fd_callback_data, send_process_frame, process_sent_to): Now static.
705 (deactivate_process): Mark defn as static, as well as decl.
706 * lisp.h (create_process): Remove decl.
707 * process.h (chan_process, Vprocess_alist): Remove decls.
709 * print.c: Make symbols static if they're not exported.
710 (print_depth, new_backquote_output, being_printed, print_buffer):
711 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
712 (print_interval, print_number_index, initial_stderr_stream):
714 * lisp.h (Fprinc): Remove decl.
715 (debug_output_compilation_hack): Mark as externally visible.
717 * sysdep.c (croak): Move decl from here to syssignal.h.
718 * syssignal.h (croak): Put it here, so the API can be checked when
719 'croak' is called from dissociate_if_controlling_tty.
721 * minibuf.c: Make symbols static if they're not exported.
722 (minibuf_save_list, choose_minibuf_frame): Now static.
723 * lisp.h (choose_minibuf_frame): Remove decl.
725 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
727 * lread.c: Make symbols static if they're not exported.
728 (read_objects, initial_obarray, oblookup_last_bucket_number):
730 (make_symbol): Remove; unused.
731 * lisp.h (initial_obarray, make_symbol): Remove decls.
733 * keyboard.c: Make symbols static if they're not exported.
734 (single_kboard, recent_keys_index, total_keys, recent_keys):
735 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
736 (this_single_command_key_start, echoing, last_auto_save):
737 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
738 (command_loop, echo_now, keyboard_init_hook, help_char_p):
739 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
740 (Vlispy_mouse_stem, double_click_count):
742 (force_auto_save_soon): Define only if SIGDANGER.
743 (ignore_mouse_drag_p): Now static if
744 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
745 (print_help): Remove; unused.
746 (stop_character, last_timer_event): Mark as externally visible.
747 * keyboard.h (ignore_mouse_drag_p): Declare only if
748 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
749 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
750 * lisp.h (echoing): Remove decl.
751 (force_auto_save_soon): Declare only if SIGDANGER.
752 * xdisp.c (redisplay_window): Simplify code, to make it more
753 obvious that ignore_mouse_drag_p is not accessed if !defined
754 USE_GTK && !defined HAVE_NS.
756 * intervals.c: Make symbols static if they're not exported.
757 (merge_properties_sticky, merge_interval_right, delete_interval):
759 * intervals.h (merge_interval_right, delete_interval): Remove decls.
761 * insdel.c: Make symbols static if they're not exported.
762 However, leave prepare_to_modify_buffer alone. It's never
763 called from outside this function, but that appears to be a bug.
764 (combine_after_change_list, combine_after_change_buffer):
765 (adjust_after_replace, signal_before_change): Now static.
766 (adjust_after_replace_noundo): Remove; unused.
767 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
768 (signal_before_change): Remove decls.
770 * indent.c (val_compute_motion, val_vmotion): Now static.
772 * image.c: Make symbols static if they're not exported.
773 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
775 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
776 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
778 * fringe.c (standard_bitmaps): Now static.
779 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
781 * frame.c: Make symbols static if they're not exported.
782 (x_report_frame_params, make_terminal_frame): Now static.
783 (get_frame_param): Now static, unless HAVE_NS.
784 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
785 (x_get_resource_string): Remove; not used.
786 * frame.h (make_terminal_frame, x_report_frame_params):
787 (x_get_resource_string); Remove decls.
788 (x_fullscreen_adjust): Declare only if WINDOWSNT.
789 * lisp.h (get_frame_param): Declare only if HAVE_NS.
791 * font.c, fontset.c: Make symbols static if they're not exported.
792 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
793 (FACE_SUITABLE_FOR_CHAR_P): Use it.
794 * font.c (font_close_object): Now static.
795 * font.h (font_close_object): Remove.
796 * fontset.c (FONTSET_OBJLIST): Remove.
797 (free_realized_fontset) #if-0 the body, which does nothing.
798 (face_suitable_for_char_p): #if-0, as it's never called.
799 * fontset.h (face_suitable_for_char_p): Remove decl.
800 * xfaces.c (face_at_string_position): Use
801 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
802 since 0 is always ASCII.
804 * fns.c (weak_hash_tables): Now static.
806 * fileio.c: Make symbols static if they're not exported.
807 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
808 (Vwrite_region_annotation_buffers): Now static.
810 * eval.c: Make symbols static if they're not exported.
811 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
812 * lisp.h (backtrace_list): Remove decl.
814 * emacs.c: Make symbols static if they're not exported.
815 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
816 (fatal_error_code, fatal_error_signal_hook, standard_args):
818 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
819 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
820 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
821 * lisp.h (fatal_error_signal_hook): Remove decl.
822 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
824 * editfns.c: Move a (normally-unused) function to its only use.
825 * editfns.c, lisp.h (get_operating_system_release): Remove.
826 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
827 worth the hassle of breaking this out.
829 * xterm.c: Make symbols static if they're not exported.
830 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
831 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
832 (x_destroy_window, x_delete_display):
834 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
835 (x_mouse_leave): Remove; unused.
836 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
837 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
838 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
840 (x_mouse_leave): Declare only if WINDOWSNT.
841 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
842 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
845 * ftxfont.c: Make symbols static if they're not exported.
846 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
848 * font.h (ftxfont_driver): Likewise.
850 * xfns.c: Make symbols static if they're not exported.
851 (x_last_font_name, x_display_info_for_name):
852 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
853 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
854 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
855 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
856 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
857 (last_show_tip_args): Now static.
858 (xic_defaut_fontset, xic_create_fontsetname): Define only if
859 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
860 (x_screen_planes): Remove; unused.
861 * dispextern.h (x_screen_planes): Remove decl.
863 * dispnew.c: Make symbols static if they're not exported.
864 * dispextern.h (redraw_garbaged_frames, scrolling):
865 (increment_row_positions): Remove.
866 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
867 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
869 (redraw_garbaged_frames): Remove; unused.
871 * xfaces.c: Make symbols static if they're not exported.
872 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
874 * xterm.h (defined_color): Remove decls.
875 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
876 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
877 (menu_face_changed_default, defined_color, free_realized_face):
878 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
879 (ascii_face_of_lisp_face): Remove; unused.
881 * xdisp.c: Make symbols static if they're not exported.
882 * dispextern.h (scratch_glyph_row, window_box_edges):
883 (glyph_to_pixel_coords, set_cursor_from_row):
884 (get_next_display_element, set_iterator_to_next):
885 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
886 (show_mouse_face): Remove decls
887 * frame.h (message_buf_print): Likewise.
888 * lisp.h (pop_message, set_message, check_point_in_composition):
890 * xterm.h (set_vertical_scroll_bar): Likewise.
891 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
892 (message_buf_print, scratch_glyph_row, displayed_buffer):
893 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
894 (get_next_display_element, show_mouse_face, window_box_edges):
895 (frame_to_window_pixel_xy, check_point_in_composition):
896 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
897 (glyph_to_pixel_coords): Remove; unused.
899 * dired.c (file_name_completion): Now static.
901 * dbusbind.c (xd_in_read_queued_messages): Now static.
903 * lisp.h (circular_list_error, FOREACH): Remove; unused.
904 * data.c (circular_list_error): Remove.
906 * commands.h (last_point_position, last_point_position_buffer):
907 (last_point_position_window): Remove decls.
908 * keyboard.c: Make these variables static.
910 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
912 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
913 (iso_code_class, detect_coding, code_convert_region): Now static.
914 (encode_coding_gap): Remove; unused.
916 * chartab.c (chartab_chars, chartab_bits): Now static.
918 * charset.h (charset_iso_8859_1): Remove decl.
919 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
922 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
923 * ccl.c (Vccl_program_table): Now static.
924 (check_ccl_update): Remove; unused.
926 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
927 * category.h: ... from here.
928 * category.c (check_category_table, set_category_set): Now static.
930 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
931 * lisp.h: Remove these decls.
933 * buffer.c (buffer_count): Remove unused var.
935 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
936 so that it's not optimized away.
937 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
938 * dispextern.h (bidi_dump_cached_states): Remove, since it's
939 exported only to the debugger.
941 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
942 * atimer.h (run_all_atimers): Removed; not exported.
944 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
945 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
946 was inaccessible from Lisp.
947 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
948 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
950 alloc.c: Import and export fewer symbols, and remove unused items.
951 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
953 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
954 it's not optimized away by whole-program optimization.
955 (message_enable_multibyte, free_misc): Remove.
956 (catchlist, handlerlist, mark_backtrace):
957 Declare only if BYTE_MARK_STACK.
958 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
959 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
960 (message_enable_multibyte): Remove decl.
961 (free_misc, interval_free_list, float_block, float_block_index):
962 (n_float_blocks, float_free_list, cons_block, cons_block_index):
963 (cons_free_list, last_marked_index):
965 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
966 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
967 (mark_backtrace): Define only if BYTE_MARK_STACK.
968 * xdisp.c (message_enable_multibyte): Now static.
970 Declare Lisp_Object Q* variables to be 'static' if not exported.
971 This makes it easier for human readers (and static analyzers)
972 to see whether these variables are used from other modules.
973 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
974 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
975 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
976 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
977 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
978 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
979 * xmenu.c, xselect.c:
980 Declare Q* vars static if they are not used in other modules.
981 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
982 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
983 Remove decls of unexported vars.
984 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
986 * lisp.h (DEFINE_FUNC): Make sname 'static'.
988 Make Emacs functions such as Fatom 'static' by default.
989 This makes it easier for human readers (and static analyzers)
990 to see whether these functions can be called from other modules.
991 DEFUN now defines a static function. To make the function external
992 so that it can be used in other C modules, use the new macro DEFUE.
993 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
994 (Finit_image_library):
995 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
996 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
997 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
998 Remove decls, since these functions are now static.
999 (Funintern, Fget_internal_run_time): New decls, since these functions
1000 were already external.
1002 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1003 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1004 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1005 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1006 * keyboard.c, keymap.c, lread.c:
1007 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1008 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1009 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1010 Mark functions with DEFUE instead of DEFUN,
1011 if they are used in other modules.
1012 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1013 decls for now-static functions.
1014 * buffer.h (Fdelete_overlay): Remove decl.
1015 * callproc.c (Fgetenv_internal): Mark as internal.
1016 * composite.c (Fremove_list_of_text_properties): Remove decl.
1017 (Fcomposition_get_gstring): New forward static decl.
1018 * composite.h (Fcomposite_get_gstring): Remove decl.
1019 * dired.c (Ffile_attributes): New forward static decl.
1020 * doc.c (Fdocumntation_property): New forward static decl.
1021 * eval.c (Ffetch_bytecode): New forward static decl.
1022 (Funintern): Remove extern decl; now in .h file where it belongs.
1023 * fileio.c (Fmake_symbolic_link): New forward static decl.
1024 * image.c (Finit_image_library): New forward static decl.
1025 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1026 * intervals.h (Fprevious_property_change):
1027 (Fremove_list_of_text_properties): Remove decls.
1028 * keyboard.c (Fthis_command_keys): Remove decl.
1029 (Fcommand_execute): New forward static decl.
1030 * keymap.c (Flookup_key): New forward static decl.
1031 (Fcopy_keymap): Now static.
1032 * keymap.h (Flookup_key): Remove decl.
1033 * process.c (Fget_process): New forward static decl.
1034 (Fprocess_datagram_address): Mark as internal.
1035 * syntax.c (Fsyntax_table_p): New forward static decl.
1036 (skip_chars): Remove duplicate decl.
1037 * textprop.c (Fprevious_property_change): New forward static decl.
1038 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1040 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1041 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1043 * editfns.c (Fformat): Remove unreachable code.
1045 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1047 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1050 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1052 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1053 when at ZV. (Bug#8487)
1055 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1057 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1059 * keyboard.c (parse_tool_bar_item): Likewise.
1060 * sound.c (sound_cleanup, alsa_close): Likewise.
1061 * termcap.c (tgetent): Likewise.
1062 * xfns.c (x_default_font_parameter): Likewise.
1063 * xsettings.c (read_and_apply_settings): Likewise.
1065 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1066 (overrun_check_free): Protoize.
1068 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1070 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1071 since callers should never pass a negative size.
1072 Change the signature to match that of plain 'read' and 'write'; see
1073 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1074 * lisp.h: Update prototypes of emacs_write and emacs_read.
1076 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1078 * xdisp.c (redisplay_window): Don't try to determine the character
1079 position of the scroll margin if the window start point w->startp
1080 is outside the buffer's accessible region. (Bug#8468)
1082 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1084 Fix write-region and its subroutines for buffers > 2GB.
1085 * fileio.c (a_write, e_write): Modify declaration of arguments and
1086 local variables to support buffers larger than 2GB.
1087 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1089 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1090 argument, local variables, and return value.
1092 * lisp.h: Update prototypes of emacs_write and emacs_read.
1094 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1096 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1098 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1100 Fix more problems found by GCC 4.6.0's static checks.
1102 * xdisp.c (vmessage): Use a better test for character truncation.
1104 * charset.c (load_charset_map): <, not <=, for optimization,
1105 and to avoid potential problems with integer overflow.
1106 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1107 * casetab.c (set_identity, shuffle): Likewise.
1108 * editfns.c (Fformat): Likewise.
1109 * syntax.c (skip_chars): Likewise.
1111 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1112 This also lets GCC 4.6.0 generate slightly better loop code.
1114 * callint.c (Fcall_interactively): <, not <=, for optimization.
1115 (Fcall_interactively): Count the number of arguments produced,
1116 not the number of arguments given. This is simpler and lets GCC
1117 4.6.0 generate slightly better code.
1119 * ftfont.c: Distingish more carefully between FcChar8 and char.
1120 The previous code passed unsigned char * to a functions like
1121 strlen and xstrcasecmp that expect char *, which does not
1122 conform to the C standard.
1123 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1124 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1125 char * when the C standard requires it.
1127 * keyboard.c (read_char): Remove unused var.
1129 * eval.c: Port to Windows vsnprintf (Bug#8435).
1131 (SIZE_MAX): Define if the headers do not.
1132 (verror): Do not give up if vsnprintf returns a negative count.
1133 Instead, grow the buffer. This ports to Windows vsnprintf, which
1134 does not conform to C99. Problem reported by Eli Zaretskii.
1135 Also, simplify the allocation scheme, by avoiding the need for
1136 calling realloc, and removing the ALLOCATED variable.
1138 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1140 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1141 But keep the doprint source code for now, as we might revamp it
1142 and use it again (Bug#8435).
1143 * lisp.h (doprnt): Remove.
1144 * Makefile.in (base_obj): Remove doprnt.o.
1145 * deps.mk (doprnt.o): Remove.
1147 error: Print 32- and 64-bit integers portably (Bug#8435).
1148 Without this change, on typical 64-bit hosts error ("...%d...", N)
1149 was used to print both 32- and 64-bit integers N, which relied on
1151 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1153 * lisp.h (error, verror): Mark as printf-like functions.
1154 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1155 Report overflow in size calculations when allocating printf buffer.
1156 Do not truncate output string at its first null byte.
1157 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1158 Truncate the output at a character boundary, since vsnprintf does not
1160 * charset.c (check_iso_charset_parameter): Convert internal
1161 character to string before calling 'error', since %c now has the
1163 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1164 overflow when computing char to be passed to 'error'. Do not
1165 pass Lisp_Object to 'error'; pass the integer instead.
1166 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1167 formatted with plain %d.
1169 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1171 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1173 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1175 * xterm.c (x_catch_errors): Remove duplicate declaration.
1177 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1179 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1181 2011-04-10 Jim Meyering <meyering@redhat.com>
1183 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1184 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1185 return ssize_t not "int", and use size_t as the buffer length.
1186 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1187 * gnutls.h: Update declarations.
1188 * process.c (read_process_output): Use ssize_t, to match.
1189 (send_process): Likewise.
1191 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1193 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1195 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1197 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1198 unsigned char, to match FcChar8 type definition.
1200 * xterm.c (handle_one_xevent):
1201 * xmenu.c (create_and_show_popup_menu):
1202 * xselect.c (x_decline_selection_request)
1203 (x_reply_selection_request): Avoid type-punned deref of X events.
1205 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1207 Fix some uses of `int' instead of EMACS_INT.
1208 * search.c (string_match_1, fast_string_match)
1209 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1210 (scan_buffer, find_next_newline_no_quit)
1211 (find_before_next_newline, search_command, Freplace_match)
1212 (Fmatch_data): Make some `int' variables be EMACS_INT.
1214 * xdisp.c (display_count_lines): 3rd argument and return value now
1215 EMACS_INT. All callers changed.
1216 (pint2hrstr): Last argument is now EMACS_INT.
1218 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1219 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1220 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1221 (decode_coding_utf_16, decode_coding_emacs_mule)
1222 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1223 (decode_coding_ccl, decode_coding_charset)
1224 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1225 (decode_coding_iso_2022, decode_coding_emacs_mule)
1226 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1227 <char_offset, last_offset>: Declare EMACS_INT.
1228 (encode_coding_utf_8, encode_coding_utf_16)
1229 (encode_coding_emacs_mule, encode_invocation_designation)
1230 (encode_designation_at_bol, encode_coding_iso_2022)
1231 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1232 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1234 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1235 (encode_invocation_designation): Last argument P_NCHARS is now
1237 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1238 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1240 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1243 * ccl.c (Fccl_execute_on_string): Declare some variables
1246 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1248 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1250 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1252 * process.c (Fformat_network_address): Doc fix.
1254 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1256 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1258 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1260 * keyboard.c (read_char): Call Lisp function help-form-show,
1261 instead of using internal_with_output_to_temp_buffer.
1262 (Qhelp_form_show): New var.
1263 (syms_of_keyboard): Use DEFSYM macro.
1265 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1267 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1269 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1271 * process.c (Flist_processes): Removed to Lisp.
1272 (list_processes_1): Deleted.
1274 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1276 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1278 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1280 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1282 Fix more problems found by GCC 4.6.0's static checks.
1284 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1286 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1288 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1290 * xdisp.c (vmessage): Mark as a printf-like function.
1292 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1294 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1296 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1297 printf-like functions.
1298 (tiff_load): Add casts to remove these marks before passing them
1299 to system-supplied API.
1301 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1303 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1304 This avoids several warnings with gcc -Wstrict-overflow.
1305 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1306 directly, rather than having caller test rule sign. This avoids
1307 some unnecessary tests.
1308 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1309 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1310 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1312 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1313 (xfont_open): Avoid unnecessary tests.
1315 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1317 * composite.h, composite.c (composition_gstring_put_cache):
1318 Use EMACS_INT, not int, for length.
1320 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1321 breaking out part of COMPOSITION_DECODE_RULE.
1322 (COMPOSITION_DECODE_RULE): Use it.
1323 * composite.c (get_composition_id): Remove unused local vars,
1324 by using the new macro.
1326 * textprop.c (set_text_properties_1): Change while to do-while,
1327 since the condition is always true at first.
1329 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1330 (interval_deletion_adjustment): Return unsigned value.
1333 * process.c (list_processes_1, create_pty, read_process_output):
1334 (exec_sentinel): Remove vars that were set but not used.
1335 (create_pty): Remove unnecessary "volatile"s.
1336 (Fnetwork_interface_info): Avoid possibility of int overflow.
1337 (read_process_output): Do adaptive read buffering even if carryover.
1338 (read_process_output): Simplify nbytes computation if buffered.
1340 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1342 * syntax.c (scan_words): Remove var that was set but not used.
1343 (update_syntax_table): Use unsigned instead of int.
1345 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1346 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1347 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1349 * print.c (print_error_message): Avoid int overflow.
1351 * font.c (font_list_entities): Redo for clarity,
1352 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1354 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1355 (font_score): Avoid potential overflow in diff calculation.
1357 * fns.c (substring_both): Remove var that is set but not used.
1358 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1360 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1362 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1363 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1364 can always succeed if overflow has undefined behavior.
1366 * search.c (boyer_moore, wordify): Remove vars set but not used.
1367 (wordify): Omit three unnecessary tests.
1369 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1370 All callers changed. This avoids the need for an unused var.
1372 * casefiddle.c (casify_region): Remove var that is set but not used.
1374 * dired.c (file_name_completion): Remove var that is set but not used.
1376 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1378 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1379 (Finsert_file_contents): Remove unnecessary code checking fd.
1381 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1382 Check for integer overflow on size calculations.
1384 * buffer.c (Fprevious_overlay_change): Remove var that is set
1387 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1388 Remove vars that are set but not used.
1389 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1390 (timer_check_2): Mark vars as initialized.
1392 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1394 * image.c (lookup_image): Remove var that is set but not used.
1395 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1397 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1398 that are set but not used.
1400 * xfns.c (make_invisible_cursor): Don't return garbage
1401 if XCreateBitmapFromData fails (Bug#8410).
1403 * xselect.c (x_get_local_selection, x_handle_property_notify):
1404 Remove vars that are set but not used.
1406 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1407 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1409 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1410 Remove var that is set but not used.
1411 (scroll_bar_windows_size): Now size_t, not int.
1412 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1415 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1416 (map_tty_color) [!defined MSDOS]: Likewise.
1418 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1420 * coding.c: Remove vars that are set but not used.
1421 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1422 All callers changed.
1423 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1424 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1425 (decode_coding_charset): Remove vars that are set but not used.
1427 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1428 that is set but not used.
1430 * print.c (print_object): Remove var that is set but not used.
1432 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1433 The gnulib version avoids calling malloc in the usual case,
1434 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1435 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1436 * filelock.c (current_lock_owner): Likewise.
1437 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1438 * sysdep.c: Include allocator.h, careadlinkat.h.
1439 (emacs_no_realloc_allocator): New static constant.
1440 (emacs_readlink): New function.
1441 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1442 ../lib/careadlinkat.h.
1444 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1446 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1447 first non-nil return value).
1449 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1451 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1452 if not defined (Bug#8403).
1454 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1456 * xdisp.c (display_count_lines): Remove parameter `start',
1457 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1458 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1459 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1460 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1461 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1462 and thereabouts. All callers changed.
1463 (get_per_char_metric): Remove parameter `f', unused since
1464 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1466 2011-04-02 Jim Meyering <meyering@redhat.com>
1468 do not dereference NULL upon failed strdup
1469 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1470 (ns_get_family): Likewise.
1472 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1474 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1476 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1478 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1481 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1483 Add lexical binding.
1485 * window.c (Ftemp_output_buffer_show): New fun.
1486 (Fsave_window_excursion):
1487 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1489 * lread.c (lisp_file_lexically_bound_p): New function.
1490 (Fload): Bind Qlexical_binding.
1491 (readevalloop): Remove `evalfun' arg.
1492 Bind Qinternal_interpreter_environment.
1493 (Feval_buffer): Bind Qlexical_binding.
1494 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1496 (syms_of_lread): Declare `lexical-binding'.
1498 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1500 * keyboard.c (eval_dyn): New fun.
1501 (menu_item_eval_property): Use it.
1503 * image.c (parse_image_spec): Use Ffunctionp.
1505 * fns.c (concat, mapcar1): Accept byte-code-functions.
1507 * eval.c (Fsetq): Handle lexical vars.
1508 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1509 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1510 (FletX, Flet): Obey lexical binding.
1511 (Fcommandp): Handle closures.
1512 (Feval): New `lexical' arg.
1513 (eval_sub): New function extracted from Feval. Use it almost
1514 everywhere where Feval was used. Look up vars in lexical env.
1516 (Ffunctionp): Move from subr.el.
1517 (Ffuncall): Handle closures.
1518 (apply_lambda): Remove `eval_flags'.
1519 (funcall_lambda): Handle closures and new byte-code-functions.
1520 (Fspecial_variable_p): New function.
1521 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1522 but without exporting it to Lisp.
1524 * doc.c (Fdocumentation, store_function_docstring):
1525 * data.c (Finteractive_form): Handle closures.
1527 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1530 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1532 (exec_byte_code): New function extracted from Fbyte_code to handle new
1533 calling convention for byte-code-functions. Add new byte-codes.
1535 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1537 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1539 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1541 * xdisp.c (redisplay_internal): Fix prototype.
1543 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1545 * xdisp.c (SCROLL_LIMIT): New macro.
1546 (try_scrolling): Use it when setting scroll_limit. Limit
1547 scrolling to 100 screen lines.
1548 (redisplay_window): Even when falling back on "recentering",
1549 position point in the window according to scroll-conservatively,
1550 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1552 (try_scrolling): When point is above the window, allow searching
1553 as far as scroll_max, or one screenful, to compute vertical
1554 distance from PT to the scroll margin position. This prevents
1555 try_scrolling from unnecessarily failing when
1556 scroll-conservatively is set to a value slightly larger than the
1557 window height. Clean up the case of PT below the margin at bottom
1558 of window: scroll_max can no longer be INT_MAX. When aggressive
1559 scrolling is in use, don't let point enter the opposite scroll
1560 margin as result of the scroll.
1561 (syms_of_xdisp) <scroll-conservatively>: Document the
1562 threshold of 100 lines for never-recentering scrolling.
1564 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1566 * dispextern.h (move_it_by_lines):
1567 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1568 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1569 (message_log_check_duplicate): Remove parameters `prev_bol' and
1570 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1571 (redisplay_internal): Remove parameter `preserve_echo_area',
1572 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1574 * indent.c (Fvertical_motion):
1575 * window.c (window_scroll_pixel_based, Frecenter):
1576 Don't pass `need_y_p' to `move_it_by_lines'.
1578 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1580 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1581 steal a few bits to be more compact.
1582 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1583 Remove unneeded casts.
1585 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1587 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1589 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1590 binding" message (bug#7967).
1592 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1594 Fix more problems found by GCC 4.6.0's static checks.
1596 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1597 Remove unused local var.
1599 * editfns.c (Fmessage_box): Remove unused local var.
1601 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1602 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1603 Omit unused local vars.
1604 * window.c (shrink_windows): Omit unused local var.
1605 * menu.c (digest_single_submenu): Omit unused local var.
1606 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1607 Omit unused local var.
1609 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1610 Don't assume string length fits in int.
1611 (keyremap_step, read_key_sequence): Use size_t for sizes.
1612 (read_key_sequence): Don't check last_real_key_start redundantly.
1614 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1615 instead of alloca (Bug#8344).
1617 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1618 (Fbacktrace_frame): Don't assume nframes fits in int.
1620 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1622 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1625 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1627 * cm.c (calccost): Turn while-do into do-while, for clarity.
1629 * keyboard.c (syms_of_keyboard): Use the same style as later
1630 in this function when indexing through an array. This also
1631 works around GCC bug 48267.
1633 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1635 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1637 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1638 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1640 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1641 This avoids undefined behavior on integer overflow, and is a bit
1642 more convenient anyway since it is compared to a size_t variable.
1644 Variadic C functions now count arguments with size_t, not int.
1645 This avoids an unnecessary limitation on 64-bit machines, which
1646 caused (substring ...) to crash on large vectors (Bug#8344).
1647 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1648 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1649 All variadic functions and their callers changed accordingly.
1650 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1651 * data.c (arith_driver, float_arith_driver): Likewise.
1652 * editfns.c (general_insert_function): Likewise.
1653 * eval.c (struct backtrace.nargs, interactive_p)
1654 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1655 (funcall_lambda, mark_backtrace): Likewise.
1656 * fns.c (concat): Likewise.
1657 * frame.c (x_set_frame_parameters): Likewise.
1658 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1659 0 if not found, not -1. All callers changed.
1661 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1662 (stack_copy_size): Now size_t, not int.
1663 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1665 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1667 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1668 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1669 All callers changed.
1671 * lisp.h (multibyte_char_to_unibyte):
1672 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1673 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1674 * character.h (CHAR_TO_BYTE8):
1675 * cmds.c (internal_self_insert):
1676 * editfns.c (general_insert_function):
1677 * keymap.c (push_key_description):
1678 * search.c (Freplace_match):
1679 * xdisp.c (message_dolog, set_message_1): All callers changed.
1681 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1683 * keyboard.c (safe_run_hook_funcall): New function.
1684 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1685 don't set the hook to nil, but remove the offending function instead.
1686 (Qcommand_hook_internal): Remove, unused.
1687 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1688 Vcommand_hook_internal.
1690 * eval.c (enum run_hooks_condition): Remove.
1691 (funcall_nil, funcall_not): New functions.
1692 (run_hook_with_args): Call each function through a `funcall' argument.
1693 Remove `cond' argument, now redundant.
1694 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1695 (Frun_hook_with_args_until_failure): Adjust accordingly.
1696 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1698 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1700 * dispextern.h (string_buffer_position): Remove declaration.
1702 * print.c (strout): Remove parameter `multibyte', unused since
1703 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1705 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1706 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1707 All callers changed.
1709 * w32.c (_wsa_errlist): Use braces for struct initializers.
1711 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1712 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1713 All callers changed.
1714 (string_buffer_position): Likewise. Also, make static (it's never
1715 used outside xdisp.c).
1716 (cursor_row_p): Remove parameter `w', unused since
1717 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1718 (decode_mode_spec): Remove parameter `precision', introduced during
1719 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1720 All callers changed.
1722 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1724 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1726 2011-03-27 Anders Lindgren <andlind@gmail.com>
1728 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1729 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1730 (ns_update_auto_hide_menu_bar): New functions.
1731 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1732 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1733 ns_constrain_all_frames.
1734 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1735 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1737 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1739 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1741 2011-03-27 Glenn Morris <rgm@gnu.org>
1743 * syssignal.h: Replace RETSIGTYPE with void.
1744 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1745 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1746 Replace SIGTYPE with void everywhere.
1747 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1748 * s/template.h (SIGTYPE): Remove commented out definition.
1750 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1752 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1753 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1755 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1757 * w32.c (read_unc_volume): Use parameter `henum', instead of
1758 global variable `wget_enum_handle'.
1760 * keymap.c (describe_vector): Remove parameters `indices' and
1761 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1762 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1764 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1766 * keyboard.c (timer_check): Remove parameter `do_it_now',
1767 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1768 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1769 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1771 * keyboard.c (read_char):
1772 * w32menu.c (w32_menu_display_help):
1773 * xmenu.c (show_help_event, menu_help_callback):
1774 Adjust calls to `show_help_echo'.
1776 * gtkutil.c (xg_maybe_add_timer):
1777 * keyboard.c (readable_events):
1778 * process.c (wait_reading_process_output):
1779 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1781 * insdel.c (adjust_markers_gap_motion):
1782 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1783 (gap_left, gap_right): Don't call it.
1785 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1787 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1788 incurred during fontification.
1790 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1792 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1793 (DEFVAR_PER_BUFFER): Don't pass it.
1795 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1796 (scrolling_window): Don't pass it.
1798 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1800 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1802 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1804 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1805 of variables specific to SELinux and computation of `encoded_absname'.
1807 * image.c (XPutPixel): Remove unused variable `height'.
1809 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1811 * unexw32.c (get_section_info): Remove unused variable `section'.
1813 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1814 (system_process_attributes): Remove unused variable `sess'.
1815 (sys_read): Remove unused variable `err'.
1817 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1818 (w32_wnd_proc): Remove unused variable `isdead'.
1819 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1820 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1821 (x_create_tip_frame): Remove unused variable `tem'.
1823 * w32inevt.c (w32_console_read_socket):
1824 Remove unused variable `no_events'.
1826 * w32term.c (x_draw_composite_glyph_string_foreground):
1827 Remove unused variable `width'.
1829 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1831 * w32term.c (x_set_glyph_string_clipping):
1832 Don't pass uninitialized region to CombineRgn.
1834 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1836 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1837 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1838 (Fx_close_connection): Remove unused variable `i'.
1840 * w32font.c (w32font_draw): Return number of glyphs.
1841 (w32font_open_internal): Remove unused variable `i'.
1842 (w32font_driver): Add missing initializer.
1844 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1845 (fill_in_menu): Remove unused variable `items_added'.
1847 * w32term.c (last_mouse_press_frame): Remove static global variable.
1848 (w32_clip_to_row): Remove unused variable `f'.
1849 (x_delete_terminal): Remove unused variable `i'.
1851 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1852 (NOTHING): Remove unused static global variable.
1853 (uniscribe_check_otf): Remove unused variable `table'.
1854 (uniscribe_font_driver): Add missing initializers.
1856 2011-03-23 Julien Danjou <julien@danjou.info>
1858 * term.c (Fsuspend_tty, Fresume_tty):
1859 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1860 * window.c (temp_output_buffer_show):
1861 * insdel.c (signal_before_change):
1862 * frame.c (Fhandle_switch_frame):
1863 * fileio.c (Fdo_auto_save):
1864 * emacs.c (Fkill_emacs):
1865 * editfns.c (save_excursion_restore):
1866 * cmds.c (internal_self_insert):
1867 * callint.c (Fcall_interactively):
1868 * buffer.c (Fkill_all_local_variables):
1869 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1871 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1872 unconditionnaly since it does the check itself.
1874 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1876 Fix more problems found by GCC 4.5.2's static checks.
1878 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1879 the first time through the loop, since we know p0 < p1 then.
1880 This also avoids a gcc -Wstrict-overflow warning.
1882 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1883 leading to a memory leak, possible in functions like
1884 load_charset_map_from_file that can allocate an unbounded number
1885 of objects (Bug#8318).
1887 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1888 that could (at least in theory) be that large.
1890 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1891 This is less likely to overflow, and avoids undefined behavior if
1892 overflow does occur. All callers changed. Use strtoul to scan
1893 for the unsigned long integer.
1894 (pint2hrstr): Simplify and tune code slightly.
1895 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1897 * scroll.c (do_scrolling): Work around GCC bug 48228.
1898 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1900 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1901 This also avoids a warning with gcc -Wstrict-overflow.
1902 (validate_x_resource_name): Simplify count usage.
1903 This also avoids a warning with gcc -Wstrict-overflow.
1905 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1908 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1910 * process.c (Fmake_network_process): Use socklen_t, not int,
1911 where POSIX says socklen_t is required in portable programs.
1912 This fixes a porting bug on hosts like 64-bit HP-UX, where
1913 socklen_t is wider than int (Bug#8277).
1914 (Fmake_network_process, server_accept_connection):
1915 (wait_reading_process_output, read_process_output):
1918 * process.c: Rename or move locals to avoid shadowing.
1919 (list_processes_1, Fmake_network_process):
1920 (read_process_output_error_handler, exec_sentinel_error_handler):
1921 Rename or move locals.
1922 (Fmake_network_process): Define label "retry_connect" only if needed.
1923 (Fnetwork_interface_info): Fix pointer signedness.
1924 (process_send_signal): Add cast to avoid pointer signedness problem.
1925 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1926 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1928 Make tparam.h and terminfo.c consistent.
1929 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1930 Include tparam.h instead, since it declares them.
1931 * cm.h (PC): Remove extern decl; tparam.h now does this.
1932 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1933 * terminfo.c: Include tparam.h, to check interfaces.
1934 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1935 (tparam): Adjust signature to match interface in tparam.h;
1936 this removes some undefined behavior. Check that outstring and len
1937 are zero, which they always are with Emacs.
1938 * tparam.h (PC, BC, UP): New extern decls.
1940 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1941 (xftfont_open): Rename locals to avoid shadowing.
1943 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1944 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1945 (OTF_TAG_SYM): Omit macro if not needed.
1946 (ftfont_list): Remove unused local.
1947 (get_adstyle_property, ftfont_pattern_entity):
1948 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1949 Rename locals to avoid shadowing.
1951 * xfont.c (xfont_list_family): Mark var as initialized.
1953 * xml.c (make_dom): Now static.
1955 * composite.c (composition_compute_stop_pos): Rename local to
1957 (composition_reseat_it): Remove unused locals.
1958 (find_automatic_composition, composition_adjust_point): Likewise.
1959 (composition_update_it): Mark var as initialized.
1960 (find_automatic_composition): Mark vars as initialized,
1961 with a FIXME (Bug#8290).
1963 character.h: Rename locals to avoid shadowing.
1964 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1965 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1966 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1967 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1970 * textprop.c (property_change_between_p): Remove; unused.
1972 * intervals.c (interval_start_pos): Now static.
1974 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1976 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1977 Rename locals to avoid shadowing.
1979 * sound.c (wav_play, au_play, Fplay_sound_internal):
1980 Fix pointer signedness.
1981 (alsa_choose_format): Remove unused local var.
1982 (wav_play): Initialize a variable to 0, to prevent undefined
1983 behavior (Bug#8278).
1985 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1987 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1989 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1990 clobbering (Bug#8298).
1991 * sysdep.c (sys_subshell): Likewise.
1992 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1994 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1995 This should get cleaned up, so that child_setup has the
1996 same signature on all platforms.
1998 * callproc.c (call_process_cleanup): Now static.
1999 (relocate_fd): Rename locals to avoid shadowing.
2001 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2003 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2004 not to be necessary, and produces flickering.
2006 2011-03-20 Glenn Morris <rgm@gnu.org>
2008 * config.in: Remove file.
2010 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2012 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2013 are now in src/globals.h.
2014 (syms_of_minibuf): Remove spurious & from previous change.
2016 2011-03-20 Leo <sdl.web@gmail.com>
2018 * minibuf.c (completing-read-function): New variable.
2019 (completing-read-default): Rename from completing-read.
2020 (completing-read): Call completing-read-function.
2022 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2024 * xfaces.c (Fx_load_color_file):
2025 Read color file from absolute filename (bug#8250).
2027 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2029 * makefile.w32-in: Update dependencies.
2031 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2033 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2035 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2037 Fix more problems found by GCC 4.5.2's static checks.
2039 * process.c (make_serial_process_unwind, send_process_trap):
2040 (sigchld_handler): Now static.
2042 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2043 That way, the code declares only the vars that it needs.
2044 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2045 * s/cygwin.h (PTY_ITERATION): Likewise.
2046 * s/darwin.h (PTY_ITERATION): Likewise.
2047 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2049 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2050 * process.c (allocate_pty): Don't declare stb unless it's needed.
2052 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2053 (CONSTANTLIM): Remove; unused.
2054 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2055 Define only if needed.
2057 * unexelf.c (unexec): Name an expression,
2058 to avoid gcc -Wbad-function-cast warning.
2059 Use a different way to cause a compilation error if anyone uses
2060 n rather than nn, a way that does not involve shadowing.
2061 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2063 * deps.mk (unexalpha.o): Remove; unused.
2065 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2066 * unexec.h: New file.
2067 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2068 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2070 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2071 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2072 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2073 Change as necessary to match prototype in unexec.h.
2075 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2077 (back_comment, skip_chars): Mark vars as initialized.
2079 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2080 Rename locals to avoid shadowing.
2082 * lread.c (read1): Rewrite so as not to use empty "else".
2083 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2085 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2087 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2088 warning when compiling print.c.
2090 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2091 instead of using an uninitialized var.
2092 (font_sort_entities): Mark var as initialized.
2094 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2096 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2097 pointers to constants.
2098 (font_parse_fcname): Remove unused vars.
2099 (font_delete_unmatched): Now static.
2100 (font_get_spec): Remove; unused.
2101 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2102 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2103 Rename or move locals to avoid shadowing.
2105 * fns.c (require_nesting_list, require_unwind): Now static.
2106 (Ffillarray): Rename locals to avoid shadowing.
2108 * floatfns.c (domain_error2): Define only if needed.
2109 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2111 * alloc.c (mark_backtrace): Move decl from here ...
2112 * lisp.h: ... to here, so that it can be checked.
2114 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2115 (Fdefvar): Rewrite so as not to use empty "else".
2116 (lisp_indirect_variable): Name an expression,
2117 to avoid gcc -Wbad-function-cast warning.
2118 (Fdefvar): Rename locals to avoid shadowing.
2120 * callint.c (quotify_arg, quotify_args): Now static.
2121 (Fcall_interactively): Rename locals to avoid shadowing.
2122 Use const pointer when appropriate.
2124 * lisp.h (get_system_name, get_operating_system_release):
2125 Move decls here, to check interfaces.
2126 * process.c (get_operating_system_release): Move decl to lisp.h.
2127 * xrdb.c (get_system_name): Likewise.
2128 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2129 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2130 some of which prompt warnings from gcc -Wbad-function-cast.
2131 (Fformat_time_string, Fencode_time, Finsert_char):
2132 (Ftranslate_region_internal, Fformat):
2133 Rename or remove local vars to avoid shadowing.
2134 (Ftranslate_region_internal): Mark var as initialized.
2136 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2139 * lisp.h (eassert): Check that the argument compiles, even if
2140 ENABLE_CHECKING is not defined.
2142 * data.c (Findirect_variable): Name an expression, to avoid
2143 gcc -Wbad-function-cast warning.
2144 (default_value, arithcompare, arith_driver, arith_error): Now static.
2145 (store_symval_forwarding): Rename local to avoid shadowing.
2146 (Fmake_variable_buffer_local, Fmake_local_variable):
2147 Mark variables as initialized.
2148 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2150 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2151 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2152 Rename locals to avoid shadowing.
2153 (mark_stack): Move local variables into the #ifdef region where
2155 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2156 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2158 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2159 (GC_STRING_CHARS): Remove; not used.
2160 (Fmemory_limit): Cast sbrk's returned value to char *.
2162 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2163 avoids undefined behavior in theory.
2165 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2167 Use functions, not macros, for up- and down-casing (Bug#8254).
2168 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2169 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2170 to use the following functions instead of these macros.
2171 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2172 EMACS_INT, since callers assume the returned value fits in int.
2173 (upcase1): Likewise, for UPCASE_TABLE.
2174 (uppercasep, lowercasep, upcase): New static inline functions.
2175 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2176 the race-condition problem in the old DOWNCASE.
2178 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2179 Rename locals to avoid shadowing.
2180 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2181 (regex_compile, re_search_2, re_match_2_internal):
2182 Remove unused local vars.
2183 (FREE_VAR): Rewrite so as not to use empty "else",
2184 which gcc can warn about.
2185 (regex_compile, re_match_2_internal): Mark locals as initialized.
2186 (RETALLOC_IF): Define only if needed.
2187 (WORDCHAR_P): Likewise. This one is never needed, but is used
2188 only in a comment talking about a compiler bug, so put inside
2189 the #if 0 of that comment.
2190 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2191 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2194 * search.c (boyer_moore): Rename locals to avoid shadowing.
2195 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2196 (PREV_CHAR_BOUNDARY): Likewise.
2198 * search.c (simple_search): Remove unused var.
2200 * dired.c (compile_pattern): Move decl from here ...
2201 * lisp.h: ... to here, so that it can be checked.
2202 (struct re_registers): New forward decl.
2204 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2206 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2208 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2209 Rename locals to avoid shadowing.
2210 (Fvertical_motion): Mark locals as initialized.
2212 * casefiddle.c (casify_object, casify_region): Now static.
2213 (casify_region): Mark local as initialized.
2215 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2217 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2218 New macros, so that the caller can use some names other than
2219 gcpro1, gcpro2, etc.
2220 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2222 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2223 argument, for consistency with GCPRO2_VAR, etc: it is now the
2224 prefix of the variable, not the variable itself. All uses
2226 * dired.c (directory_files_internal, file_name_completion):
2227 Rename locals to avoid shadowing.
2229 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2230 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2231 dired.c's scmp function, had undefined behavior.
2232 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2233 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2234 * buffer.h: ... to here, because these macros use current_buffer,
2235 and the new implementation with inline functions needs to have
2236 current_buffer in scope now, rather than later when the macros
2238 (downcase, upcase1): New static inline functions.
2239 (DOWNCASE, UPCASE1): Reimplement using these functions.
2240 This avoids undefined behavior in expressions like
2241 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2242 from race conditions in accessing the global variables
2243 case_temp1 and case_temp2.
2244 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2245 * lisp.h (case_temp1, case_temp2): Remove their decls.
2246 * character.h (ASCII_CHAR_P): Move from here ...
2247 * lisp.h: ... to here, so that the inline functions mentioned
2250 * dired.c (directory_files_internal_unwind): Now static.
2252 * fileio.c (file_name_as_directory, directory_file_name):
2253 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2255 (file_name_as_directory): Use const pointers when appropriate.
2256 (Fexpand_file_name): Likewise. In particular, newdir might
2257 point at constant storage, so make it a const pointer.
2258 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2259 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2261 (Fset_file_times, Finsert_file_contents, auto_save_error):
2262 Rename locals to avoid shadowing.
2264 * minibuf.c (choose_minibuf_frame_1): Now static.
2265 (Ftry_completion, Fall_completions): Rename or remove locals
2268 * marker.c (bytepos_to_charpos): Remove; unused.
2270 * lisp.h (verify_bytepos, count_markers): New decls,
2271 so that gcc does not warn that these functions aren't declared.
2273 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2274 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2275 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2276 (copy_text): Remove unused local var.
2278 * filelock.c (within_one_second): Now static.
2279 (lock_file_1): Rename local to avoid shadowing.
2281 * buffer.c (fix_overlays_before): Mark locals as initialized.
2282 (fix_start_end_in_overlays): Likewise. This function should be
2283 simplified by using pointers-to-pointers, but that's a different
2285 (switch_to_buffer_1): Now static.
2286 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2287 (report_overlay_modification): Rename locals to avoid shadowing.
2289 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2290 Fix pointer signedness issue.
2291 (sys_subshell): Mark local as volatile if checking for lint,
2292 to suppress a gcc -Wclobbered warning that does not seem to be right.
2293 (MAXPATHLEN): Define only if needed.
2295 * process.c (serial_open, serial_configure): Move decls from here ...
2296 * systty.h: ... to here, so that they can be checked.
2298 * fns.c (get_random, seed_random): Move extern decls from here ...
2299 * lisp.h: ... to here, so that they can be checked.
2301 * sysdep.c (reset_io): Now static.
2302 (wait_for_termination_signal): Remove; unused.
2304 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2305 (copy_keymap_item, append_key, push_text_char_description):
2307 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2308 (DENSE_TABLE_SIZE): Remove; unused.
2309 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2310 (describe_map_tree):
2311 Rename locals to avoid shadowing.
2313 * keyboard.c: Declare functions static if they are not used elsewhere.
2314 (echo_char, echo_dash, cmd_error, top_level_2):
2315 (poll_for_input, handle_async_input): Now static.
2316 (read_char, kbd_buffer_get_event, make_lispy_position):
2317 (make_lispy_event, make_lispy_movement, apply_modifiers):
2318 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2319 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2320 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2321 (read_key_sequence, read_char): Mark locals as initialized.
2322 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2324 * keyboard.h (make_ctrl_char): New decl.
2325 (mark_kboards): Move decl here ...
2326 * alloc.c (mark_kboards): ... from here.
2328 * lisp.h (force_auto_save_soon): New decl.
2330 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2331 (DEFINE_DUMMY_FUNCTION): New macro.
2332 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2334 (main): Add casts to avoid warnings
2335 if GCC considers string literals to be constants.
2337 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2339 * dbusbind.c: Pointer signedness fixes.
2340 (xd_signature, xd_append_arg, xd_initialize):
2341 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2342 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2343 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2344 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2346 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2347 if GCC considers string literals to be constants.
2348 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2350 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2352 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2353 (print_preprocess, print_object): New macro to fix last change.
2355 * print.c (print_preprocess): Don't forget font objects.
2357 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2359 * emacs.c (USAGE3): Doc fixes.
2361 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2363 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2366 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2368 * lisp.h (VWindow_system, Qfile_name_history):
2369 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2370 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2371 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2373 * w32select.c: Don't #include "keyboard.h".
2374 (run_protected): Add extern declaration for waiting_for_input.
2376 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2377 * w32console.c (detect_input_pending, read_input_pending)
2378 (encode_terminal_code):
2379 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2380 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2381 (w32_system_caret_y, Qfile_name_history):
2382 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2383 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2384 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2385 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2386 * w32proc.c (Qlocal, report_file_error):
2387 * w32term.c (Vwindow_system, updating_frame):
2388 * w32uniscribe.c (initialized, uniscribe_font_driver):
2389 Remove unneeded extern declarations.
2391 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2393 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2395 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2397 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2398 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2399 These macros can no longer be used for assignment.
2401 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2402 Assign struct members directly, instead of using BUF_BEGV etc.
2403 (record_buffer_markers, fetch_buffer_markers): New functions for
2404 recording and fetching special buffer markers.
2405 (set_buffer_internal_1, set_buffer_temp): Use them.
2407 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2409 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2411 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2412 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2414 * xdisp.c (hscroll_window_tree):
2415 (reconsider_clip_changes): Use PT instead of BUF_PT.
2417 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2419 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2420 $(EMACS_ROOT)/lib/intprops.h.
2422 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2424 Fix more problems found by GCC 4.5.2's static checks.
2426 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2427 to unsigned char * to avoid compiler diagnostic.
2428 (xg_free_frame_widgets): Make it clear that a local variable is
2429 needed only if USE_GTK_TOOLTIP.
2430 (gdk_window_get_screen): Make it clear that this macro is needed
2431 only if USE_GTK_TOOLTIP.
2432 (int_gtk_range_get_value): New function, which avoids a diagnostic
2433 from gcc -Wbad-function-cast.
2434 (xg_set_toolkit_scroll_bar_thumb): Use it.
2435 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2436 diagnostic from gcc -Wbad-function-cast.
2437 (get_utf8_string, xg_get_file_with_chooser):
2438 Rename locals to avoid shadowing.
2439 (create_dialog): Move locals to avoid shadowing.
2441 * xgselect.c (xg_select): Remove unused var.
2443 * image.c (four_corners_best): Mark locals as initialized.
2444 (gif_load): Initialize transparent_p to zero (Bug#8238).
2445 Mark another local as initialized.
2446 (my_png_error, my_error_exit): Mark with NO_RETURN.
2448 * image.c (clear_image_cache): Now static.
2449 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2450 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2451 (x_edge_detection): Remove unnecessary cast that
2452 gcc -Wbad-function-cast diagnoses.
2453 (gif_load): Fix pointer signedness.
2454 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2455 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2457 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2459 Improve quality of tests for time stamp overflow.
2460 For example, without this patch (encode-time 0 0 0 1 1
2461 1152921504606846976) returns the obviously-bogus value (-948597
2462 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2463 reports time overflow. See
2464 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2465 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2466 * editfns.c: Include limits.h and intprops.h.
2467 (TIME_T_MIN, TIME_T_MAX): New macros.
2468 (time_overflow): Move earlier, to before first use.
2469 (hi_time, lo_time): New functions, for an accurate test for
2471 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2472 (Fget_internal_run_time): Don't assume time_t fits in int.
2473 (make_time): Use list2 instead of Fcons twice.
2474 (Fdecode_time): More accurate test for out-of-range times.
2475 (check_tm_member): New function.
2476 (Fencode_time): Use it, to test for out-of-range times.
2477 (lisp_time_argument): Don't rely on undefined left-shift and
2478 right-shift behavior when checking for time stamp overflow.
2480 * editfns.c (time_overflow): New function, refactoring common code.
2481 (Fformat_time_string, Fdecode_time, Fencode_time):
2482 (Fcurrent_time_string): Use it.
2484 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2485 * dired.c (make_time): Move to ...
2486 * editfns.c (make_time): ... here.
2487 * systime.h: Note the move.
2489 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2491 * fringe.c (update_window_fringes): Remove unused variables.
2493 * unexmacosx.c (copy_data_segment): Also copy __got section.
2496 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2498 * termcap.c [MSDOS]: Include "msdos.h".
2499 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2500 Constify `char *' arguments and their references according to
2501 prototypes in tparam.h.
2503 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2505 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2506 Adapt all references accordingly.
2508 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2510 2011-03-11 Tom Tromey <tromey@redhat.com>
2512 * buffer.c (syms_of_buffer): Remove obsolete comment.
2514 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2516 * termhooks.h (encode_terminal_code): Declare prototype.
2518 * msdos.c (encode_terminal_code): Don't declare prototype.
2520 * term.c (encode_terminal_code): Now external again, used by
2521 w32console.c and msdos.c.
2523 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2524 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2526 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2528 Fix some minor problems found by GCC 4.5.2's static checks.
2530 * fringe.c (update_window_fringes): Mark locals as initialized
2532 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2534 * alloc.c (mark_fringe_data): Move decl from here ...
2535 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2536 to check its interface.
2537 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2539 * fontset.c (free_realized_fontset): Now static.
2540 (Fset_fontset_font): Rename local to avoid shadowing.
2541 (fontset_font): Mark local as initialized.
2542 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2544 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2546 * xselect.c (x_disown_buffer_selections): Remove; not used.
2547 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2548 (x_own_selection, Fx_disown_selection_internal): Rename locals
2550 (x_handle_dnd_message): Remove local to avoid shadowing.
2552 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2553 so that the caller can use some name other than gcpro1.
2554 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2555 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2556 (Fx_backspace_delete_keys_p):
2557 Use them to avoid shadowing, and rename vars to avoid shadowing.
2558 (x_decode_color, x_set_name, x_window): Now static.
2559 (Fx_create_frame): Add braces to silence GCC warning.
2560 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2561 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2562 Remove unused locals.
2563 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2564 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2565 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2568 * xterm.h (x_mouse_leave): New decl.
2570 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2571 Remove unused functions.
2572 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2573 (x_calc_absolute_position): Now static.
2574 (XTread_socket): Don't define label "out" unless it's used.
2575 Don't declare local "event" unless it's used.
2576 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2577 unless they are used.
2578 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2579 (x_fatal_error_signal): Remove; not used.
2580 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2581 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2582 (x_error_catcher, x_connection_closed, x_error_handler):
2583 (x_error_quitter, xembed_send_message, x_iconify_frame):
2584 (my_log_handler): Rename locals to avoid shadowing.
2585 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2586 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2588 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2589 Rename or move locals to avoid shadowing.
2590 (tty_defined_color, merge_face_heights): Now static.
2591 (free_realized_faces_for_fontset): Remove; not used.
2592 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2593 does not deduce is never used uninitialized.
2594 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2595 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2597 * terminal.c (store_terminal_param): Now static.
2599 * xmenu.c (menu_highlight_callback): Now static.
2600 (set_frame_menubar): Remove unused local.
2601 (xmenu_show): Rename parameter to avoid shadowing.
2602 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2603 since they might point to immutable storage.
2604 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2605 since it's unused otherwise.
2607 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2608 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2609 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2610 avoids a gcc -Wuninitialized diagnostic.
2611 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2612 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2613 does not deduce are never used uninitialized.
2615 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2617 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2618 * window.c (window_loop, size_window):
2619 (run_window_configuration_change_hook, enlarge_window): Likewise.
2621 * window.c (display_buffer): Now static.
2622 (size_window): Mark variables that gcc -Wuninitialized
2623 does not deduce are never used uninitialized.
2624 * window.h (check_all_windows): New decl, to forestall
2625 gcc -Wmissing-prototypes diagnostic.
2626 * dispextern.h (bidi_dump_cached_states): Likewise.
2628 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2630 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2632 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2633 and to avoid gcc -Wuninitialized warning.
2634 (load_charset_map): Mark variables that gcc -Wuninitialized
2635 does not deduce are never used uninitialized.
2636 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2638 * coding.c (coding_set_source, coding_set_destination):
2639 Use "else { /* comment */ }" rather than "else /* comment */;"
2640 for clarity, and to avoid gcc -Wempty-body warning.
2641 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2642 a block, when the outer 'i' will do.
2643 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2644 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2645 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2646 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2647 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2648 Rename locals to avoid shadowing.
2649 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2650 * coding.c (emacs_mule_char, encode_invocation_designation):
2651 Now static, since they're not used elsewhere.
2652 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2653 (decode_coding_object, encode_coding_object, detect_coding_system):
2654 (decode_coding_emacs_mule): Mark variables that gcc
2655 -Wuninitialized does not deduce are never used uninitialized.
2656 (detect_coding_iso_2022): Initialize a local variable that might
2657 be used uninitialized. Leave a FIXME because it's not clear that
2658 this initialization is needed. (Bug#8211)
2659 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2660 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2661 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2662 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2663 Remove unused macros.
2665 * category.c (hash_get_category_set): Remove unused local var.
2666 (copy_category_table): Now static, since it's not used elsewhere.
2667 * character.c (string_count_byte8): Likewise.
2669 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2670 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2672 * chartab.c (copy_sub_char_table): Now static, since it's not used
2674 (sub_char_table_ref_and_range, char_table_ref_and_range):
2675 Rename locals to avoid shadowing.
2676 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2678 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2679 (BIDI_BOB): Remove unused macro.
2681 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2682 deduce are never used uninitialized.
2683 * term.c (encode_terminal_code): Likewise.
2685 * term.c (encode_terminal_code): Now static. Remove unused local.
2687 * tparam.h: New file.
2688 * term.c, tparam.h: Include it.
2689 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2690 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2691 Move these decls to tparam.h, and make them agree with what
2692 is actually in tparam.c. The previous trick of using incompatible
2693 decls in different modules does not conform to the C standard.
2694 All callers of tparam changed to use tparam's actual API.
2695 * tparam.c (tparam1, tparam, tgoto):
2696 Use const pointers where appropriate.
2698 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2699 * cm.h (struct cm): Likewise.
2700 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2701 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2702 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2703 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2704 (turn_on_face, init_tty): Likewise.
2705 * termchar.h (struct tty_display_info): Likewise.
2707 * term.c (term_mouse_position): Rename local to avoid shadowing.
2709 * alloc.c (mark_ttys): Move decl from here ...
2710 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2712 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2714 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2716 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2718 * search.c (compile_pattern_1): Remove argument regp, unused since
2719 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2720 (compile_pattern): Don't pass it.
2722 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2724 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2725 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2727 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2729 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2731 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2732 gdk_window_get_screen, gdk_window_get_geometry,
2733 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2734 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2735 (xg_get_pixbuf_from_pixmap): New function.
2736 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2737 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2738 Call xg_get_pixbuf_from_pixmap instead of
2739 gdk_pixbuf_get_from_drawable.
2740 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2741 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2742 (xg_check_special_colors): Use GtkStyleContext and its functions
2744 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2745 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2746 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2747 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2748 Call gtk_widget_get_preferred_size.
2749 (xg_frame_resized): gdk_window_get_geometry only takes 5
2751 (xg_win_to_widget, xg_event_is_for_menubar):
2752 Call gdk_x11_window_lookup_for_display.
2753 (xg_set_widget_bg): New function.
2754 (delete_cb): New function.
2755 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2756 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2757 (xg_set_background_color): Call xg_set_widget_bg.
2758 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2759 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2760 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2761 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2763 (update_frame_tool_bar): Call gtk_widget_hide.
2764 (xg_initialize): Use GDK_KEY_g.
2766 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2768 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2770 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2771 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2772 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2774 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2776 * w32xfns.c (select_palette): Check success of RealizePalette against
2777 GDI_ERROR, not zero.
2779 See ChangeLog.11 for earlier changes.
2785 Copyright (C) 2011 Free Software Foundation, Inc.
2787 This file is part of GNU Emacs.
2789 GNU Emacs is free software: you can redistribute it and/or modify
2790 it under the terms of the GNU General Public License as published by
2791 the Free Software Foundation, either version 3 of the License, or
2792 (at your option) any later version.
2794 GNU Emacs is distributed in the hope that it will be useful,
2795 but WITHOUT ANY WARRANTY; without even the implied warranty of
2796 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2797 GNU General Public License for more details.
2799 You should have received a copy of the GNU General Public License
2800 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.