1 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (rows_from_pos_range): Handle the case where the
4 highlight ends on a newline. (Bug#10464)
5 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6 he end column for display of highlight that ends on a newline
9 2012-01-11 Glenn Morris <rgm@gnu.org>
11 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
12 from load-path also when installation-directory is nil. (Bug#10208)
14 2012-01-10 Glenn Morris <rgm@gnu.org>
16 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
18 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
19 Update template values to be closer to their typical values these days.
21 2012-01-09 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (rows_from_pos_range): Accept additional argument
24 DISP_STRING, and accept any glyph in a row whose object is that
25 string as eligible for mouse highlight. Fixes mouse highlight of
26 display strings from overlays. (Bug#10464)
28 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
30 emacs: fix an auto-save permissions race condition (Bug#10400)
31 * fileio.c (auto_saving_dir_umask): New static var.
32 (Fmake_directory_internal): Use it.
33 (do_auto_save_make_dir): Set it, instead of invoking chmod after
34 creating the directory. The old code temporarily assigns
35 too-generous permissions to the directory.
36 (do_auto_save_eh): Clear it.
37 (Fdo_auto_save): Catch all errors, not just file errors, so
38 that the var is always cleared.
40 2012-01-07 Eli Zaretskii <eliz@gnu.org>
42 * search.c (scan_buffer): Pass character positions to
43 know_region_cache, not byte positions. (Bug#6540)
45 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
47 * w32.c (sys_rename): Report EXDEV when rename of a directory
48 fails because the target is on another logical disk. (Bug#10284)
50 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
52 * xterm.c (x_embed_request_focus): New function.
54 * xterm.h: Add prototype.
56 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
58 2012-01-05 Glenn Morris <rgm@gnu.org>
60 * emacs.c (emacs_copyright): Update short copyright year to 2012.
62 2012-01-01 Eli Zaretskii <eliz@gnu.org>
64 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
65 Load gnutls_transport_set_lowat only if GnuTLS version is below
67 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
68 GnuTLS versions below 2.11.1.
70 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
72 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
73 to the doc string advising against its use for altering the way
76 2011-12-28 Kenichi Handa <handa@m17n.org>
78 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
79 coding-system ASCII compatible only when it does not produce BOM
80 on encoding (Bug#10383).
82 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
84 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
86 (create_and_show_popup_menu): Always use menu_position_func for
89 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
91 * callint.c (Fcall_interactively): Don't truncate prompt string.
93 2011-12-23 Eli Zaretskii <eliz@gnu.org>
95 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
96 property that ends at ZV, so that the bidi iteration could be
97 resumed from there (after widening). (Bug#10360)
99 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
101 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
103 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
105 * nsterm.m (x_free_frame_resources):
106 Release f->output_data.ns->miniimage.
107 (ns_index_color): Fix indentation. Do not retain
108 color_table->colors[i].
110 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
113 * nsfns.m (x_set_background_color): Assign return value from
114 ns_index_color to face-background instead of NSColor*.
115 (ns_implicitly_set_icon_type): Fix indentation.
116 Change assignment in for loop to comparison.
118 * emacs.c (ns_pool): New variable.
119 (main): Assign ns_pool.
120 (Fkill_emacs): Call ns_release_autorelease_pool.
122 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
123 autorelease fdesc, release fdAttrs and tdict.
124 (ns_get_covering_families): Release charset.
125 (ns_findfonts): Release NSFontDescriptor created with new.
126 (ns_uni_to_glyphs): Fix indentation.
127 (setString): Release attrStr before assigning new value.
129 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
131 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
133 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
134 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
136 2011-12-18 David Reitter <reitter@cmu.edu>
138 * nsterm.m (ns_term_init): Subscribe for notifications
139 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
140 to method trackingNotification in EmacsMenu.
142 * nsmenu.m (trackingMenu): New variable.
143 (trackingNotification): New method (from Aquamacs).
144 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
145 from Aquamacs (Bug#7030).
147 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
149 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
150 (symbol_to_nsstring): Fix indentation.
151 (ns_symbol_to_pb): New function.
152 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
153 (Fns_rotate_cut_buffers_internal): Removed.
154 (Fns_store_selection_internal): Renamed from
155 Fns_store_cut_buffer_internal.
156 (ns_get_foreign_selection, Fx_own_selection_internal)
157 (Fx_disown_selection_internal, Fx_selection_exists_p)
158 (Fns_get_selection_internal, Fns_store_selection_internal):
159 Use ns_symbol_to_pb and check if return value is nil.
160 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
161 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
162 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
163 renamed to Sns_store_selection_internal.
164 (ns_handle_selection_request): Move code to Fx_own_selection_internal
165 and remove this function.
166 (ns_handle_selection_clear): Remove, never used.
167 (Fx_own_selection_internal): Move code from ns_handle_selection_request
170 2011-12-17 Ken Brown <kbrown@cornell.edu>
172 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
173 GID is unknown (Bug#10257).
175 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
177 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
178 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
179 which caused a build failure on GNU/Linux IA-64. This problem was
180 introduced by my 2011-10-07 patch.
182 2011-12-15 Juri Linkov <juri@jurta.org>
184 * image.c (imagemagick_error): New function. (Bug#10112)
185 (imagemagick_load_image): Comment out `MagickSetResolution' call.
186 Use `imagemagick_error' where ImageMagick functions return
188 (Fimagemagick_types): Add `Fnreverse' to return the list in the
191 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
193 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
194 fill background (Bug#8992).
196 2011-12-13 Martin Rudalics <rudalics@gmx.at>
198 * window.c (Vwindow_combination_resize)
199 (Vwindow_combination_limit): Use t instead of non-nil in
201 (Vrecenter_redisplay): Add first sentence of doc-string on
203 (Frecenter): Fix doc-string typo.
205 2011-12-11 Kenichi Handa <handa@m17n.org>
207 * coding.c (Funencodable_char_position): Pay attention to the
208 buffer text relocation (Bug#9389).
210 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
212 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
213 gtk_init (Bug#10100).
215 2011-12-10 Eli Zaretskii <eliz@gnu.org>
217 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
218 IT->string is nil. (Bug#10263)
220 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
222 * nsterm.h (x_free_frame_resources): Declare.
224 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
225 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
227 * nsterm.h (ns_get_defaults_value): Declare.
229 * nsterm.m (ns_default): Call ns_get_defaults_value.
231 2011-12-09 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
236 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
238 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
239 that where the value of an _OBJC_* symbol points to is in the .bss
242 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
244 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
245 after the loop to call ccl_driver at least once (Bug#8619).
247 2011-12-08 Kenichi Handa <handa@m17n.org>
249 * ftfont.c (get_adstyle_property): Fix previous change
252 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
254 * w32.c (init_environment): If no_site_lisp, remove site-lisp
255 dirs from the default value of EMACSLOADPATH (bug#10208).
257 2011-12-07 Glenn Morris <rgm@gnu.org>
259 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
260 installation and source directories as well. (Bug#10208)
262 2011-12-06 Chong Yidong <cyd@gnu.org>
264 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
266 2011-12-06 Glenn Morris <rgm@gnu.org>
268 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
269 as an error, not just -1. (Bug#10217)
271 2011-12-05 Chong Yidong <cyd@gnu.org>
273 * keyboard.c (process_special_events): New function.
274 (swallow_events, Finput_pending_p): Use it (Bug#10195).
276 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
278 * coding.c (encode_designation_at_bol): Don't use uninitialized
279 local variable (Bug#9318).
281 2011-12-05 Kenichi Handa <handa@m17n.org>
283 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
284 return Qnil (Bug#8046, Bug#10193).
286 2011-12-05 Kenichi Handa <handa@m17n.org>
288 * coding.c (encode_designation_at_bol): New args charbuf_end and
289 dst. Return the number of produced bytes. Callers changed.
290 (coding_set_source): Return how many bytes coding->source was
292 (coding_set_destination): Return how many bytes
293 coding->destination was relocated.
294 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
295 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
297 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
299 * coding.c (CODING_CHAR_CHARSET_P): New macro.
300 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
303 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
305 The following changes are to fix Bug#9318.
307 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
308 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
309 (encode_coding_iso_2022, encode_coding_sjis)
310 (encode_coding_big5, encode_coding_charset): Use the above macros.
312 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
314 * lisp.h (process_quit_flag): Fix external declaration.
316 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
318 Don't macro-inline non-performance-critical code.
319 * eval.c (process_quit_flag): New function.
320 * lisp.h (QUIT): Use it.
322 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
324 * nsfns.m (get_geometry_from_preferences): New function.
325 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
327 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
329 * emacs.c (Qkill_emacs): Define.
330 (syms_of_emacs): Initialize it.
331 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
332 Qquit_flag to `kill-emacs' instead.
333 (quit_throw_to_read_char): Add parameter `from_signal'.
334 All callers changed. Call Fkill_emacs if requested and safe.
335 * lisp.h (QUIT): Call Fkill_emacs if requested.
337 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
339 * widget.c (update_wm_hints): Return if wmshell is null.
340 (widget_update_wm_size_hints): New function.
342 * widget.h (widget_update_wm_size_hints): Declare.
344 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
345 widget_update_wm_size_hints (Bug#10104).
347 2011-12-03 Eli Zaretskii <eliz@gnu.org>
349 * xdisp.c (handle_invisible_prop): If the invisible text ends just
350 before a newline, prepare the bidi iterator for consuming the
351 newline, and keep the current paragraph direction. (Bug#10183)
352 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
354 2011-12-02 Juri Linkov <juri@jurta.org>
356 * search.c (Fword_search_regexp): New Lisp function created from
357 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
358 (Fword_search_backward, Fword_search_forward)
359 (Fword_search_backward_lax, Fword_search_forward_lax):
360 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
361 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
363 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
365 * fileio.c (Finsert_file_contents): Move after-change-function call
366 to before the "handled:" label, since all "goto handled" appear in
367 cases where the *-change-functions have already been properly called
370 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
372 * keyboard.c (interrupt_signal): Don't call kill-emacs when
373 waiting for input. (Bug#10169)
375 2011-11-30 Eli Zaretskii <eliz@gnu.org>
377 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
378 verifies glyph row's hash code--we have just reallocated the
379 glyphs, so their contents can be complete garbage. (Bug#10164)
381 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
383 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
385 2011-11-30 Eli Zaretskii <eliz@gnu.org>
387 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
388 attributes are tested _before_ calling verify_row_hash, to protect
389 against GCC re-ordering of the tests. (Bug#10164)
391 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
393 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
395 * xterm.c (handle_one_xevent): Only set async_visible and friends
396 if net_wm_state_hidden_seen is non-zero (Bug#10002)
397 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
398 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
400 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
402 Remove GCPRO-related macros that exist only to avoid shadowing locals.
403 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
404 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
405 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
406 All uses changed to use GCPRO1 etc.
407 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
408 Revert to old implementation (i.e., before 2011-03-11).
410 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
412 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
413 of scroll runs so as to avoid assigning disabled bogus rows and
414 unnecessary graphics copy operations.
416 2011-11-27 Eli Zaretskii <eliz@gnu.org>
418 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
419 (snprintf) [_MSC_VER]: Redirect to _snprintf.
420 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
421 (malloc, free, realloc, calloc): Redirect to e_* only when
424 * lisp.h (GCTYPEBITS): Move before first use.
425 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
426 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
427 this macro definition.
429 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
432 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
434 * gtkutil.c (xg_create_frame_widgets):
435 Call gtk_window_set_has_resize_grip (FALSE) if that function is
436 present with Gtk+ 2.0.
438 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
440 * fileio.c (Finsert_file_contents): Undo previous change; see
441 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
443 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
445 Rename locals to avoid shadowing.
446 * fileio.c (Finsert_file_contents):
447 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
448 * process.c (wait_reading_process_output):
449 Rename inner 'proc' to 'p' to avoid shadowing.
450 Indent for consistency with usual Emacs style.
452 2011-11-25 Eli Zaretskii <eliz@gnu.org>
454 * xdisp.c (redisplay_window): If cursor row is not fully visible
455 after recentering, and scroll-conservatively is set to a large
456 number, scroll window by a few more lines to make the cursor fully
457 visible and out of scroll-margin. (Bug#10105)
458 (start_display): Don't move to the next line if the display should
459 start at a newline that is part of a display vector or an overlay
462 2011-11-24 Juri Linkov <juri@jurta.org>
464 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
465 after the `MagickPingImage' call. (Bug#10112)
467 2011-11-23 Chong Yidong <cyd@gnu.org>
469 * window.c (Fcoordinates_in_window_p): Accept only live windows.
471 2011-11-23 Martin Rudalics <rudalics@gmx.at>
473 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
474 making another buffer current. (Bug#10114)
476 2011-11-23 Glenn Morris <rgm@gnu.org>
478 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
480 2011-11-23 Chong Yidong <cyd@gnu.org>
482 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
485 2011-11-22 Eli Zaretskii <eliz@gnu.org>
487 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
488 and header-lines, as they don't have one computed for them.
491 * .gdbinit (prow): Make displayed values more self-explaining.
494 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
496 * process.c (wait_reading_process_output): Fix asynchrounous
497 GnuTLS socket handling on some versions of the GnuTLS library.
498 (wait_reading_process_output): Add comment and URL.
500 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
502 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
504 2011-11-21 Chong Yidong <cyd@gnu.org>
506 * window.c (Fnext_window, Fprevious_window): Doc fix.
508 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
510 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
512 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
514 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
516 2011-11-20 Martin Rudalics <rudalics@gmx.at>
518 * window.c (Fset_window_combination_limit): Rename argument
520 (Vwindow_combination_limit): Remove "status" from doc-string.
522 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
524 * m/ibms390.h: Remove.
525 * m/ibms390x.h: Don't include "ibms390.h".
527 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
529 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
530 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
532 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
534 * casetab.c (Fset_case_table):
535 * charset.c (Fcharset_after): Fix typos.
537 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
539 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
540 Otherwise, valgrind does not work on some platforms.
541 Problem reported by Andreas Schwab in
542 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
543 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
544 is set, removing the need for VIRT_ADDRESS_VARIES.
545 (PURE_P): Use a more-efficient implementation that needs just one
546 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
547 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
548 to 4 (xorl, subq, cmpq, setbe).
549 * alloc.c (pure): Always extern now, since that's the
550 VIRT_ADDR_VARIES behavior.
551 (PURE_POINTER_P): Use a single comparison, not two, for
552 consistency with the new puresize.h.
553 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
554 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
555 Remove VIRT_ADDR_VARIES no longer needed.
557 2011-11-19 Eli Zaretskii <eliz@gnu.org>
559 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
560 (erase_phys_cursor, update_window_cursor, show_mouse_face)
561 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
562 behave as if the cursor position were at the window margin.
564 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
565 and the cursor position is out of bounds, behave as if the cursor
566 position were at the window margin. (Bug#10075)
568 2011-11-18 Chong Yidong <cyd@gnu.org>
570 * window.c (Fwindow_combination_limit): Make first argument
571 non-optional, since it is meaningless for live windows like the
574 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
576 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
578 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
580 * intervals.c: Fix grafting over the whole buffer (bug#10071).
581 (graft_intervals_into_buffer): Simplify.
583 2011-11-18 Eli Zaretskii <eliz@gnu.org>
585 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
586 hash values of the two rows.
587 (copy_row_except_pointers): Preserve the used[] arrays and the
588 hash values of the two rows. (Bug#10035)
589 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
591 * xdisp.c (row_hash): New function, body extracted from
592 compute_line_metrics.
593 (compute_line_metrics): Call row_hash, instead of computing the
596 * dispnew.c (verify_row_hash): Call row_hash for computing the
597 hash code of a row, instead of duplicating code from xdisp.c.
599 * dispextern.h (row_hash): Add prototype.
601 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
603 * frame.c (delete_frame): Don't delete the terminal when the last
604 X frame is closed if emacs is built with GTK toolkit.
606 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
608 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
610 2011-11-17 Martin Rudalics <rudalics@gmx.at>
612 * window.c (Vwindow_splits): Rename to
613 Vwindow_combination_resize. Suggested by Juri Linkov.
614 (Fsplit_window_internal): Use Vwindow_combination_resize instead
617 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
619 * nsfns.m (Fns_font_name):
620 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
622 2011-11-16 Martin Rudalics <rudalics@gmx.at>
624 * window.h (window): Rename slot "nest" to "combination_limit".
625 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
626 (Fset_window_nest): Rename to Fset_window_combination_limit.
627 (Vwindow_nest): Rename to Vwindow_combination_limit.
628 (recombine_windows, make_parent_window, make_window)
629 (Fsplit_window_internal, saved_window)
630 (Fset_window_configuration, save_window_save): Rename all
631 occurrences of window_nest to window_combination_limit.
633 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
635 * image.c (imagemagick_load_image): Fix typo.
637 2011-11-14 Eli Zaretskii <eliz@gnu.org>
639 * xdisp.c (display_line): Move the call to
640 highlight_trailing_whitespace before the call to
641 compute_line_metrics, since the latter needs to see the final
642 faces of all the glyphs to compute ROW's hash value.
643 Fixes assertion violations in row_equal_p. (Bug#10035)
645 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
647 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
648 just return (bug#10044).
650 2011-11-12 Eli Zaretskii <eliz@gnu.org>
652 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
653 with user-defined heap size. Bump the default size of the temacs
654 heap to 27MB, to avoid memory warning when running temacs.
655 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
657 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
658 current_matrix and desired_matrix. (Bug#9990)
659 (verify_row_hash) [XASSERTS]: New function.
660 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
661 that the hash value of glyph rows is correct.
663 2011-11-12 Martin Rudalics <rudalics@gmx.at>
665 * window.h (window): Remove splits slot.
666 * window.c (Fwindow_splits, Fset_window_splits): Remove.
667 (Fdelete_other_windows_internal, make_parent_window)
668 (make_window, Fsplit_window_internal, Fdelete_window_internal)
669 (Fset_window_configuration, save_window_save): Don't deal with
670 split status of windows.
671 (saved_window): Remove splits slot.
672 (Vwindow_splits): Rewrite doc-string.
674 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
676 * xfns.c (unwind_create_frame):
677 * nsfns.m (unwind_create_frame):
678 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
679 Vframe_list (Bug#9999).
681 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
683 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
685 2011-11-11 Kenichi Handa <handa@m17n.org>
687 * callproc.c (Fcall_process): Set the member dst_multibyte of
690 2011-11-11 Johan Bockgård <bojohan@gnu.org>
692 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
693 avoid a crash (bug#9496).
695 2011-11-09 Chong Yidong <cyd@gnu.org>
697 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
698 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
700 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
702 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
704 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
706 Avoid some portability problems by eschewing 'extern inline' functions.
707 The trivial performance wins aren't worth the portability hassles; see
708 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
710 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
711 (window_box_width, window_box_left, window_box_left_offset)
712 (window_box_right, window_box_right_offset): Undo previous change,
713 by removing the "extern"s.
714 * intervals.c (adjust_intervals_for_insertion)
715 (adjust_intervals_for_deletion): Undo previous change,
716 making these static again.
717 (offset_intervals, temp_set_point_both, temp_set_point)
718 (copy_intervals_to_string): No longer inline.
719 * xdisp.c (window_text_bottom_y, window_box_width)
720 (window_box_height, window_box_left_offset)
721 (window_box_right_offset, window_box_left, window_box_right)
722 (window_box): No longer inline.
724 2011-11-08 Chong Yidong <cyd@gnu.org>
726 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
727 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
728 Signal an error if not a live window.
729 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
730 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
732 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
734 * lisp.h (syms_of_abbrev): Remove declaration.
735 Reported by CHENG Gao <chenggao@royau.me>.
737 2011-11-07 Eli Zaretskii <eliz@gnu.org>
739 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
740 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
741 of temacs in GUI mode.
743 2011-11-07 Martin Rudalics <rudalics@gmx.at>
745 * window.h: Declare delete_all_child_windows instead of
746 delete_all_subwindows.
747 * window.c (Fwindow_nest, Fset_window_nest)
748 (Fset_window_new_total, Fset_window_new_normal)
749 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
750 (delete_all_subwindows): Rename to delete_all_child_windows.
751 (Fdelete_other_windows_internal, Fset_window_configuration):
752 Call delete_all_child_windows instead of delete_all_subwindows.
753 * frame.c (delete_frame): Call delete_all_child_windows instead
754 of delete_all_subwindows.
756 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
758 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
759 This is also needed for porting to any host where GC_MARK_STACK is
760 not GC_MAKE_GCPROS_NOOPS.
761 (which_symbols): Use it.
763 2011-11-07 Kenichi Handa <handa@m17n.org>
765 * coding.c (coding_set_destination): Check coding->src_pos only
766 when coding->src_object is a buffer (bug#9910).
768 * process.c (send_process): Set the member src_multibyte of coding
769 to 0 (bug#9911) when sending a unibyte text.
771 * callproc.c (Fcall_process): Set the member src_multibyte of
772 process_coding to 0 (bug#9912).
774 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
776 * xmenu.c (cleanup_widget_value_tree): New function.
777 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
778 calling free_menubar_widget_value_tree directly (Bug#9830).
780 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
782 Fix some portability problems with 'inline'.
783 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
784 (window_box_width, window_box_left, window_box_left_offset)
785 (window_box_right, window_box_right_offset): Declare extern.
786 Otherwise, these inline functions do not conform to C99 and
787 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
788 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
789 * intervals.c (adjust_intervals_for_insertion)
790 (adjust_intervals_for_deletion): Now extern, because otherwise the
791 extern inline functions 'offset_intervals' couldn't refer to it.
792 (static_offset_intervals): Remove.
793 (offset_intervals): Rewrite using the old contents of
794 static_offset_intervals. The old version didn't conform to C99
795 because an extern inline function contained a reference to an
796 identifier with static linkage.
798 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
800 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
803 2011-11-06 Eli Zaretskii <eliz@gnu.org>
805 * xdisp.c (init_iterator, reseat_to_string): Don't set the
806 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
807 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
808 return Qleft_to_right.
810 2011-11-06 Chong Yidong <cyd@gnu.org>
812 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
813 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
814 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
815 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
816 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
817 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
818 (Fwindow_vscroll): Doc fix.
819 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
820 argument, since it makes no sense to pass a live window and for
821 consistency with window-child.
823 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
825 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
828 2011-11-05 Jason Rumney <jasonr@gnu.org>
830 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
831 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
833 (add_font_entity_to_list): Fix logic errors in mixed boolean and
834 bitwise arithmetic preventing use of unicode-sip and non-truetype
837 2011-11-05 Eli Zaretskii <eliz@gnu.org>
839 * s/ms-w32.h (fstat, stat, utime): Move redirections to
842 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
843 initialization code to keep similarity to xfns.c after changes
846 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
848 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
849 (unwind_create_frame): New function (Bug#9943).
850 (Fx_create_frame): Restructure code to be more similar to the one in
851 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
852 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
853 Move terminal->reference_count++ just before making the frame official
856 * nsterm.m (x_free_frame_resources): New function.
857 (x_destroy_window): Move code to x_free_frame_resources.
859 * xfns.c (unwind_create_frame): Fix comment.
860 (Fx_create_frame, x_create_tip_frame):
861 Move terminal->reference_count++ just before making the frame
862 official. Move initialization of image_cache_refcount and
863 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
865 2011-11-05 Eli Zaretskii <eliz@gnu.org>
867 Support MSVC build with newer versions of Visual Studio.
868 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
869 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
872 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
873 which are not supported by MSVC.
874 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
875 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
877 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
879 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
881 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
883 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
885 Support MSVC build with newer versions of Visual Studio.
886 * w32.c: Don't include w32api.h for MSVC.
887 (init_environment) [_MSC_VER]: Call sys_access, not _access.
889 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
890 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
891 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
892 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
894 (alloca) [_MSC_VER]: Define to _alloca.
896 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
898 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
900 2011-11-04 Eli Zaretskii <eliz@gnu.org>
902 * xdisp.c (note_mouse_highlight): If either of
903 previous/next-single-property-change returns nil, treat that as
904 the beginning or the end of the buffer. (Bug#9955)
906 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
908 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
909 label is not null (Bug#9951).
910 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
913 2011-11-04 Eli Zaretskii <eliz@gnu.org>
915 * window.c (Fwindow_body_size): Mention in the doc string that the
916 return value is in frame's canonical units. (Bug#9949)
918 2011-11-03 Eli Zaretskii <eliz@gnu.org>
920 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
922 * w32fns.c (unwind_create_frame): If needed, free the glyph
923 matrices of the partially constructed frame. (Bug#9943)
924 * xfns.c (unwind_create_frame): Likewise.
926 2011-11-01 Eli Zaretskii <eliz@gnu.org>
928 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
929 Don't stop backward scan on the continuation glyph, even though
930 its CHARPOS is positive.
931 (mouse_face_from_buffer_pos, note_mouse_highlight):
932 Rename cover_string to disp_string.
934 2011-11-01 Martin Rudalics <rudalics@gmx.at>
936 * window.c (temp_output_buffer_show): Don't use
937 Vtemp_buffer_show_specifiers.
938 (Vtemp_buffer_show_specifiers): Remove unused variable.
940 2011-10-30 Eli Zaretskii <eliz@gnu.org>
942 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
943 past the beginning of the current glyph matrix.
945 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
947 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
948 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
949 HAVE_GTK3 (Bug#9869).
951 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
952 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
954 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
956 * xterm.c: Declare x_handle_net_wm_state to return int.
957 (handle_one_xevent): Check if we are iconified but don't have
958 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
959 (get_current_wm_state): Return non-zero if not hidden,
960 check for _NET_WM_STATE_HIDDEN (Bug#9893).
961 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
962 (x_handle_net_wm_state): Return what get_current_wm_state returns.
963 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
965 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
967 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
968 so that this new function doesn't get optimized away by a
969 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
971 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
973 * frame.h (MOUSE_HL_INFO): Remove excess parens.
975 2011-10-29 Eli Zaretskii <eliz@gnu.org>
977 Fix the `xbytecode' command.
978 * .gdbinit (xprintbytestr): New command.
979 (xwhichsymbols): Rename from `which'; all callers changed.
980 (xbytecode): Print the byte-code string as well.
982 2011-10-29 Kim Storm <storm@cua.dk>
984 * alloc.c (which_symbols): New function.
986 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
988 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
991 2011-10-29 Glenn Morris <rgm@gnu.org>
993 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
994 Not clear what it was for, and it causes various bugs. (Bug#9839)
996 2011-10-28 Eli Zaretskii <eliz@gnu.org>
998 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
999 possible random value that matches one of those tested as
1000 condition to clear the mouse face.
1002 2011-10-28 Chong Yidong <cyd@gnu.org>
1004 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1006 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1008 * window.c (make_window): Initialize phys_cursor_on_p.
1010 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1012 * lisp.h (struct Lisp_Symbol): Update comments.
1014 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1016 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1018 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1020 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1021 <oslsachem@gmail.com> for helping to debug this.
1023 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1024 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1025 (g_b_init_get_glyph_outline_w): New static variables.
1026 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1027 (GetGlyphOutlineW_Proc): New typedefs.
1028 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1029 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1031 (w32font_open_internal, compute_metrics):
1032 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1033 instead of calling the "wide" APIs directly.
1035 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1037 * w32.h (syms_of_w32font): Add prototype.
1039 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1041 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1042 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1043 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1044 (Fmove_to_window_line): Doc fix.
1046 2011-10-27 Chong Yidong <cyd@gnu.org>
1048 * process.c (make_process): Set gnutls_state to NULL.
1050 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1051 non-NULL, regardless of GNUTLS_INITSTAGE.
1052 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1053 an error. Set process slots as soon as we allocate them.
1055 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1057 2011-10-27 Chong Yidong <cyd@gnu.org>
1059 * gnutls.c (emacs_gnutls_deinit): New function.
1060 Deallocate credentials structures as well as calling gnutls_deinit.
1061 (Fgnutls_deinit, Fgnutls_boot): Use it.
1063 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1064 (deactivate_process): Call emacs_gnutls_deinit.
1066 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1068 * image.c (x_create_x_image_and_pixmap):
1069 * w32.c (sys_rename, w32_delayed_load):
1070 * w32font.c (fill_in_logfont):
1071 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1073 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1075 * w32fns.c (w32_default_color_map): New function,
1076 extracted from Fw32_default_color_map.
1077 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1079 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1081 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1083 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1085 * keyboard.c (test_undefined): New function (bug#9751).
1086 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1088 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1090 * sysdep.c (init_sys_modes): Fix the check for the controlling
1091 terminal (Bug#6649).
1093 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1095 * dispextern.h (struct bidi_it): New member next_en_type.
1097 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1098 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1099 current character, check also for next_en_type being WEAK_EN.
1100 (bidi_resolve_weak): Don't enter the expensive loop if the current
1101 position is before next_en_pos. Record the bidi type of the first
1102 non-ET, non-BN character we find, in addition to its position.
1103 (bidi_level_of_next_char): Invalidate next_en_type when
1104 next_en_pos is over-stepped.
1106 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1108 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1109 * editfns.c: Rewrite current-time-zone so that it invokes
1110 the equivalent of (format-time-string "%Z") to get the time zone name.
1111 This fixes a bug when the time zone name contains characters that
1112 need converting from the system time locale to Emacs internal format.
1113 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1114 that patch fixed format-time-string to do the conversion, but
1115 I forgot to fix current-time-zone.
1116 (format_time_string): New function, containing most of
1117 what Fformat_time_string used to contain.
1118 (Fformat_time_string): Rewrite in terms of format_time_string.
1119 This doesn't change this function's behavior.
1120 (current-time-zone): Rewrite to use format_time_string.
1121 This fixes the bug reported by Michael Schierl in
1122 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1123 Jason Rumney's 2007-06-07 change worked around this bug, but
1125 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1127 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1129 * xdisp.c (start_display): If the character at POS is displayed
1130 via a display vector, reset IT->current.dpvec_index to zero.
1131 (try_window_reusing_current_matrix): If a line ends in a display
1132 vector or the next line starts in a display vector, continue
1133 redrawing the window even though the character position of
1134 start_row was reached.
1137 2011-10-18 Chong Yidong <cyd@gnu.org>
1139 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1140 with nobreak-char-display too.
1142 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1144 Fix part 3 of bug#9771.
1145 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1146 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1147 non-neutral characters if the current character is a paragraph
1148 separator (a.k.a. Newline). This avoids running the same
1149 expensive loop twice, once when we consume the preceding newline
1150 and the other time when the line actually needs to be displayed.
1151 Avoid the loop when we see neutrals on the base embedding level
1152 following a character whose directionality is the same as the
1153 paragraph's. This avoids running the expensive loop when a line
1154 ends in a long sequence of neutrals, like control characters.
1155 Add assertion against STRONG_AL type. Slightly rearrange code
1156 that determines the type of a neutral given the first non-neutral
1158 (bidi_level_of_next_char): Set next_en_pos to zero when
1159 invalidating its info.
1161 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1163 * xdisp.c (push_display_prop): Determine whether to record string
1164 or buffer position by IT->string, not by IT->method. Allow
1165 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1166 (move_it_vertically_backward): Don't look for character position
1167 immediately after the newline when in a continuation line.
1170 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1172 * window.c (coordinates_in_window): Rewrite and delabelize
1173 vertical border check. (Bug#5357) (Bug#9618)
1175 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1177 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1178 errors in XSetWindowBorder (bug#9310).
1180 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1182 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1183 avoid crash when xmalloc overrun checking is enabled.
1185 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1187 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1188 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1189 cursor motion with <left> and <right> arrow keys.
1191 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1192 some callers set that themselves.
1194 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1196 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1197 display string and the previous row comes from the same string and
1198 is empty. (Bug#9739) (Bug#9738)
1200 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1202 * doc.c (get_doc_string): Encode file name (bug#9735).
1204 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1206 * bidi.c (bidi_level_of_next_char):
1207 * xdisp.c (get_visually_first_element): Remove old incorrect
1208 comments regarding the Unicode Line Separator character.
1210 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1212 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1214 * alloc.c (Fgc_status): Do not access beyond zombies array
1215 boundary if nzombies > MAX_ZOMBIES.
1216 * alloc.c (dump_zombies): Add missing format specifier.
1218 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1220 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1221 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1223 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1224 Some packages use them to denote characters with modifiers.
1226 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1228 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1229 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1230 matching a pp-number. Rename parameter var to var1.
1232 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1234 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1236 2011-10-08 Glenn Morris <rgm@gnu.org>
1238 * callint.c (Fcall_interactively): Give a more explicit error for the
1239 'c' case with a non-character input. (Bug#8479)
1241 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1243 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1245 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1246 lines that are hscrolled on the left.
1248 * dispnew.c (buffer_posn_from_coords): Account for a possible
1249 presence of header-line. (Bug#4426)
1251 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1253 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1254 Don't advertise functionality which we discourage or doesn't work.
1256 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1258 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1259 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1260 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1261 this makes Emacs dump core during garbage collection on rare
1262 occasions. sizeof is obviously inferior to offsetof here, so
1263 stick with offsetof.
1264 (GC_POINTER_ALIGNMENT): New macro.
1265 (mark_memory): Omit 3rd (offset) arg; caller changed.
1266 Don't assume EMACS_INT alignment is the same as pointer alignment.
1268 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1270 * keyboard.c (read_key_sequence_remapped): New var.
1271 (read_key_sequence): Compute remapping in the right buffer.
1272 (command_loop_1): Use read_key_sequence's remapping directly.
1274 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1276 * dired.c (file_name_completion): Don't expand file name.
1277 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1278 before checking file name handler.
1280 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1281 they've been requested explicitly (bug#9591).
1283 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1285 * keymap.c (Fsingle_key_description): Use make_specified_string
1286 instead of build_string to build string from push_key_description.
1289 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1291 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1292 This fixes a Y2038 bug on 64-bit hosts.
1293 * buffer.c (reset_buffer):
1294 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1295 (Fclear_buffer_auto_save_failure):
1296 Use 0, not -1, to represent an unset failure time, since time_t
1297 might not be signed.
1299 Remove dependency on glibc malloc internals.
1300 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1301 Move back here from lisp.h, but with their new implementations.
1302 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1303 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1304 * charset.c (charset_table_init): New static var.
1305 (syms_of_charset): Use it instead of xmalloc. This removes a
1306 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1307 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1308 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1309 Move back to alloc.c.
1310 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1311 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1313 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1315 * nsterm.m (windowDidResize): Call x_set_window_size only when
1316 ns_in_resize is true. Otherwise set pixelwidth/height and
1317 call change_frame_size (Bug#9628).
1319 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1321 Port --enable-checking=all to Fedora 14 x86-64.
1322 * charset.c (syms_of_charset): Also account for glibc malloc's
1323 internal overhead when calculating the initial malloc maximum.
1325 Port --enable-checking=all to Fedora 14 x86.
1326 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1328 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1329 (overrun_check_realloc, overrun_check_free):
1330 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1331 That way, xmalloc returns a properly-aligned pointer even if
1332 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1333 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1334 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1335 into account when calculating the initial malloc maximum.
1336 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1337 Move here from alloc.c, so that charset.c can use it too.
1338 Properly align; the old code wasn't right for common 32-bit hosts
1339 when configured with --enable-checking=all.
1340 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1341 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1343 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1345 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1348 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1350 * xdisp.c (compute_display_string_end): If there's no display
1351 string at CHARPOS, return -1.
1353 * bidi.c (bidi_fetch_char): When compute_display_string_end
1354 returns a negative value, treat the character as a normal
1355 character not covered by a display string. (Bug#9624)
1357 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1359 * lread.c (Fread_from_string): Fix typo in docstring.
1361 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1363 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1364 newline, reseat the iterator instead of bidi-iterating there one
1365 character at a time. (Bug#9610)
1366 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1367 TO_CHARPOS if the bidi iterator is at base embedding level.
1369 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1371 * lread.c (readevalloop): Use correct code for NBSP.
1372 (read1): Likewise. (Bug#9608)
1374 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1376 * dbusbind.c (Fdbus_register_signal): When service is not
1377 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1379 2011-09-25 Glenn Morris <rgm@gnu.org>
1381 * buffer.c (truncate-lines): Doc fix.
1383 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1385 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1386 (Fset_window_next_buffers): Doc fix.
1388 2011-09-24 Glenn Morris <rgm@gnu.org>
1390 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1392 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1394 Fix minor problems found by static checking.
1395 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1396 * indent.c (Fvertical_motion): Fix == vs = typo.
1398 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1400 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1401 Default value is now t. Doc fix.
1403 * indent.c (Fvertical_motion): Compute and apply the overshoot
1404 logic when moving up, not only when moving down. Fix the
1405 confusing name and values of the it_overshoot_expected variable;
1406 logic changes accordingly. (Bug#9254) (Bug#9549)
1408 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1409 CHARPOS is covered by a display string which includes newlines.
1410 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1411 is covered by a display string with embedded newlines.
1413 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1415 * dbusbind.c (Fdbus_register_signal): Add match rule to
1416 Vdbus_registered_objects_table. (Bug#9581)
1417 (Fdbus_register_method, Vdbus_registered_objects_table):
1420 2011-09-24 Jim Meyering <meyering@redhat.com>
1422 do not ignore write error for any output size
1423 The previous change was incomplete.
1424 While it makes emacs --batch detect the vast majority of stdout
1425 write failures, errors were still ignored whenever the output size is
1426 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1427 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1428 && echo FAIL: ignored write error
1429 FAIL: ignored write error
1430 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1431 && echo FAIL: ignored write error
1432 FAIL: ignored write error
1433 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1435 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1437 * emacs.c (Fkill_emacs): In noninteractive mode exit
1438 non-successfully if a write error occurred on stdout. (Bug#9574)
1440 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1442 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1445 * dispextern.h (struct it): Update the comment documenting what
1448 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1450 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1451 a display string, extend search for cursor position to end of row.
1452 (find_row_edges): If the row ends in a newline from a display
1453 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1454 Handle the case of a display string with multiple newlines.
1455 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1456 non-empty line. Fixes confusing cursor motion with arrow keys at
1457 the beginning of a line that starts with whitespace.
1459 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1461 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1464 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1466 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1469 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1471 * xdisp.c (display_line): Record maximum and minimum buffer
1472 positions even if no glyphs were produced (e.g., by a zero-width
1473 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1474 buffer positions that will be removed from the glyph row because
1476 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1477 column is beyond frame width: don't subtract 1 "pixel" when
1478 computing width of the stretch.
1479 (reseat_at_next_visible_line_start): Undo the change made on
1480 2011-09-17 that saved paragraph information and restored it after
1481 the call to `reseat'. (Bug#9545)
1483 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1485 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1486 and turn window cursor on if cleared (Bug#9415).
1488 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1490 * search.c (boyer_moore): Take unibyte characters from pattern
1491 literally. (Bug#9458)
1493 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1495 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1497 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1499 Fix minor problem found by static checking.
1500 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1501 initialized, to pacify gcc -Wuninitialized.
1503 * fileio.c: Report proper errno when syscall falls.
1504 (Finsert_file_contents): Save and restore errno,
1505 so that report_file_error outputs the correct diagnostic.
1506 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1508 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1510 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1512 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1514 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1515 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1517 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1519 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1520 about the current paragraph and restore it after the call to reseat.
1522 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1523 (bidi_find_paragraph_start): Search back for paragraph beginning
1524 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1525 (bidi_move_to_visually_next): Only trigger paragraph-related
1526 computations when the last character is a newline or at EOB, not
1527 just any NEUTRAL_B. (Bug#9470)
1529 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1530 truncated lines if point is covered by a display string. (Bug#9524)
1532 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1534 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1535 (cons_to_x_long): New function.
1536 (lisp_data_to_selection_data): Use it. Correct the test for
1537 short-versus-long data; it was negated. Break out of vector
1538 loop, for efficiency, when a long datum is discovered.
1540 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1542 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1544 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1546 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1547 GCC PR/17406) by declaring this function with external scope.
1549 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1551 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1552 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1554 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1556 * editfns.c (Fformat): Correctly handle text properties on "%%".
1558 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1560 * xterm.c (x_draw_composite_glyph_string_foreground):
1561 * w32term.c (x_draw_composite_glyph_string_foreground):
1562 * term.c (encode_terminal_code):
1563 * composite.c (composition_update_it, get_composition_id):
1564 * xdisp.c (get_next_display_element)
1565 (fill_composite_glyph_string): Add comments about special meaning
1566 of TAB characters in a composition.
1568 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1570 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1571 This occurs when processing a multibyte format.
1572 Problem reported by Wolfgang Jenker.
1574 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1576 * xdisp.c (try_cursor_movement): Only check for exact match if
1577 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1579 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1581 Remove unused external symbols.
1582 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1583 * xdisp.c (calc_pixel_width_or_height): Now static.
1584 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1585 * indent.c (check_display_width):
1586 * w32term.c: Fix comment to match code.
1587 * xterm.c, xterm.h (x_catching_errors): Remove.
1589 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1591 * xselect.c: Use signed conversions more consistently (Bug#9498).
1592 (selection_data_to_lisp_data): Assume incoming selection data are
1593 signed integers, not unsigned. This is to be consistent with
1594 outgoing selection data, which was modified to use signed integers
1595 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1596 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1597 expects long, not unsigned long.
1599 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1601 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1602 computation of loop end. Reported by Johan Bockgård
1605 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1607 * frame.c (Fother_visible_frames_p): Function deleted.
1609 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1611 * indent.c (compute_motion): Process display vector front to back
1612 rather than the other way around. (Bug#2496)
1614 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1616 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1618 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1620 * minibuf.c (Fread_from_minibuffer): Doc fix.
1622 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1624 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1625 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1627 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1629 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1630 value for non-existent files.
1632 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1634 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1635 set its "size" to -1. This will set the modtime_size field of
1636 the corresponding buffer to -1, which is what
1637 verify-visited-file-modtime expects for files that do not exist.
1640 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1642 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1644 * lisp.h: ... from here. push_key_description is no longer
1645 defined in keyboard.c, so its declaration should not be in
1646 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1647 logically belongs with push_key_description.
1649 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1651 * buffer.h: Include <sys/types.h> instead of <time.h>.
1652 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1653 Problem reported by Herbert J. Skuhra.
1655 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1657 * xml.c (parse_region): Make the parsing work for
1658 non-comment-starting XML files again (bug#9144).
1660 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1662 * image.c (gif_load): Fix calculation of bottom and right corner.
1665 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1667 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1668 redisplay in small windows.
1670 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1672 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1674 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1676 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1677 Operate on live windows only.
1679 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1681 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1683 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1685 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1686 only under bidi iteration.
1688 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1690 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1692 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1694 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1695 Without this fix, the command to link temacs failed due to an
1696 undefined symbol __builtin_isnan. This is because
1697 /usr/include/iso/math_c99.h #defines isnan(x) to
1698 __builtin_isnan(x), but the bundled gcc, which identifies itself
1699 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1701 * floatfns.c (isnan): #undef, and then #define to a clone of
1703 (Fisnan): Always define, since it's always available now.
1704 (syms_of_floatfns): Always define isnan at the Lisp level.
1706 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1708 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1710 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1712 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1713 The previous code assumed that file offsets (off_t values) fit in
1714 EMACS_INT variables, which is not true on typical 32-bit hosts.
1715 The code messed up by falsely reporting buffer overflow in cases
1716 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1717 when "big" contains more than 2**29 bytes, even though this
1718 inserts just one byte and does not overflow the buffer.
1719 (Finsert_file_contents): Store file offsets as off_t
1720 values, not as EMACS_INT values. Check for overflow when
1721 converting between EMACS_INT and off_t. When checking for
1722 buffer overflow or for overlap, take the offsets into account.
1723 Don't use EMACS_INT for small values where int suffices.
1724 When checking for overlap, fix a typo: ZV was used where
1725 ZV_BYTE was intended.
1726 (Fwrite_region): Don't assume off_t fits into 'long'.
1727 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1729 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1731 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1733 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1735 sprintf-related integer and memory overflow issues (Bug#9412).
1737 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1738 (esprintf, exprintf, evxprintf): New functions.
1739 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1740 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1741 (modify_event_symbol): Do not assume that the length of
1742 name_alist_or_stem is safe to alloca and fits in int.
1743 (Fexecute_extended_command): Likewise for function name and binding.
1744 (Frecursion_depth): Wrap around reliably on integer overflow.
1745 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1746 since some callers pass EMACS_INT values.
1747 (Fsingle_key_description): Don't crash if symbol name contains more
1748 than MAX_ALLOCA bytes.
1749 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1750 (get_minibuffer): Arg is now EMACS_INT, not int.
1751 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1752 (esprintf, exprintf, evxprintf): New decls.
1753 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1755 * dbusbind.c (signature_cat): New function.
1756 (xd_signature, Fdbus_register_signal):
1757 Do not overrun buffer; instead, report string overflow.
1759 * dispnew.c (add_window_display_history): Don't overrun buffer.
1760 Truncate instead; this is OK since it's just a log.
1762 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1763 even if the time zone offset is outlandishly large.
1764 Don't mishandle offset == INT_MIN.
1766 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1767 when creating daemon; the previous buffer-overflow check was incorrect.
1769 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1770 which has the guts of the old verror function.
1772 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1773 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1775 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1776 (font_unparse_xlfd): Don't blindly alloca long strings.
1777 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1778 fits in int, when using sprintf. Use single snprintf to count
1779 length of string rather than counting it via multiple sprintfs;
1780 that's simpler and more reliable.
1781 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1782 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1783 sprintf, in case result does not fit in int.
1785 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1786 (fontset_from_font): Print it.
1788 * frame.c (tty_frame_count): Now printmax_t, not int.
1789 (make_terminal_frame, set_term_frame_name): Print it.
1790 (x_report_frame_params): In X, window IDs are unsigned long,
1791 not signed long, so print them as unsigned.
1792 (validate_x_resource_name): Check for implausibly long names,
1793 and don't assume name length fits in 'int'.
1794 (x_get_resource_string): Don't blindly alloca invocation name;
1795 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1798 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1799 (xg_check_special_colors, xg_set_geometry):
1800 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1802 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1803 Use esprintf, not sprintf, in case result does not fit in int.
1805 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1806 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1807 it as a large positive number.
1808 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1809 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1811 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1812 in case result does not fit in int.
1814 * print.c (float_to_string): Detect width overflow more reliably.
1815 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1816 buffer overrun. Don't assume list length fits in 'int'. Treat
1817 print length of 0 as 0, not as infinity; to be consistent with other
1818 uses of print length in this function. Don't overflow print length
1819 index. Don't assume hash table size fits in 'long', or that
1820 vectorlike size fits in 'unsigned long'.
1822 * process.c (make_process): Use printmax_t, not int, to format
1823 process-name gensyms.
1825 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1827 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1828 to avoid potential buffer overrun.
1830 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1831 if X resource line is longer than 512 bytes.
1833 * xfns.c (x_window): Make sprintf buffer a bit bigger
1834 to avoid potential buffer overrun.
1836 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1838 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1840 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1842 Integer overflow fixes for scrolling, etc.
1843 Without these, Emacs silently mishandles large integers sometimes.
1844 For example, "C-u 4294967297 M-x recenter" was treated as if
1845 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1847 * xdisp.c (try_window_id): Check Emacs fixnum range before
1848 converting to 'int'.
1850 * window.c (window_scroll_line_based, Frecenter):
1851 Check that an Emacs fixnum is in range before assigning it to 'int'.
1852 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1853 values converted from Emacs fixnums.
1854 (Frecenter): Don't wrap around a line count if it is out of 'int'
1855 range; instead, treat it as an extreme value.
1856 (Fset_window_configuration, compare_window_configurations):
1857 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1859 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1860 that can exceed INT_MAX. Check that EMACS_INT value is in range
1861 before assigning it to the (possibly-narrower) index.
1862 (match_limit): Don't assume that a fixnum can fit in 'int'.
1864 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1867 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1868 (Fvertical_motion): Don't wrap around LINES values that don't fit
1869 in 'int'. Instead, treat them as extreme values. This is good
1870 enough for windows, which can't have more than INT_MAX lines anyway.
1872 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1874 * Require libxml/parser.h to avoid compilation warning.
1876 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1878 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1879 since this reportedly can destroy thread storage.
1881 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1883 * syntax.c (find_defun_start): Update all cache variables if
1884 exiting early (Bug#9401).
1886 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1888 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1890 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1891 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1892 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1894 * term.c (tty_append_glyph): New function.
1895 (produce_stretch_glyph): Static function and its prototype deleted.
1897 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1900 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1902 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1903 when checking :margin (Bug#9390).
1904 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1905 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1906 so that the name doesn't mislead. All uses changed.
1908 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1910 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1913 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1915 * xdisp.c (move_it_to): Don't bail out early when reaching
1916 position beyond to_charpos, if we are scanning backwards.
1917 (move_it_vertically_backward): When DY == 0, make sure we get to
1918 the first character in the line after the newline.
1920 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1922 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1923 (ccl_driver): Do not generate an out-of-range pointer.
1924 (Fccl_execute_on_string): Remove unnecessary check for
1925 integer overflow, noted by Stefan Monnier in
1926 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1927 Remove a FIXME that didn't need fixing.
1928 Simplify the newly-introduced buffer reallocation code.
1930 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1932 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1934 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1936 Integer and memory overflow issues (Bug#9196).
1938 * doc.c (get_doc_string): Rework so that
1939 get_doc_string_buffer_size is the actual buffer size, rather than
1940 being 1 less than the actual buffer size; this makes xpalloc more
1943 * image.c (x_allocate_bitmap_record, cache_image):
1944 * xselect.c (Fx_register_dnd_atom):
1945 Simplify previous changes by using xpalloc.
1947 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1948 since either will do and ptrdiff_t is convenient with xpalloc.
1950 * charset.c (charset_table_size)
1951 (struct charset_sort_data.priority): Now ptrdiff_t.
1952 (charset_compare): Don't overflow if priorities differ greatly.
1953 (Fsort_charsets): Don't assume list length fits in int.
1954 Check for size-calculation overflow when allocating sort data.
1955 (syms_of_charset): Allocate an initial charset table that is
1956 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1958 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1960 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1961 The actual value is always <= INT_MAX, and leaving it unsigned made
1962 overflow checking harder.
1964 * dispextern.h (struct glyph_matrix.rows_allocated)
1965 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1966 with xpalloc. The values are still always <= INT_MAX.
1968 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1970 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1971 (SAFE_NALLOCA): New macro.
1973 * region-cache.c (struct boundary.pos, find_cache_boundary)
1974 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1975 (set_cache_region, invalidate_region_cache)
1976 (revalidate_region_cache, know_region_cache, region_cache_forward)
1977 (region_cache_backward, pp_cache):
1978 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1979 so that ptrdiff_t * can be passed to xpalloc.
1980 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1981 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1982 (pp_cache): Don't assume cache_len fits in int.
1983 * region-cache.h: Adjust extern decls to match.
1985 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1986 EMACS_INT, since either will do, for xpalloc.
1988 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1989 (xnmalloc, xnrealloc, xpalloc): New functions.
1991 * bidi.c (bidi_shelve_header_size): New constant.
1992 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1993 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1995 * bidi.c (bidi_cache_shrink):
1996 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1998 Don't update size of array until after memory allocation succeeds,
1999 because xmalloc/xrealloc may not return.
2000 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2001 now that we have proper integer overflow checking.
2002 (record_overlay_string, overlay_strings): Catch overflows when
2003 calculating size of overlay_str_buf.
2005 * callproc.c (Fcall_process): Check for size overflow when
2006 calculating size of args2.
2007 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2008 Normally we prefer signed values, but sticking with ptrdiff_t would
2009 require adding more-complicated checks.
2011 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2012 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2013 Redo buffer-overflow calculations to avoid integer overflow.
2014 Add a FIXME comment where memory seems to be over-allocated.
2016 * character.c (Fstring): Check for size-calculation overflow.
2018 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2019 unnecessary integer overflow. Check for size overflow.
2020 (encode_coding_object): Don't update size until xmalloc succeeds.
2022 * composite.c (get_composition_id): Check for overflow in glyph
2023 length calculations.
2025 Integer and memory overflow fixes for display code.
2026 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2027 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2028 (scrolling_window): Check for overflow in size calculations.
2029 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2030 Don't assume glyph table len fits in int.
2031 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2032 (row_table_size): Now ptrdiff_t, not int.
2033 (scrolling_window): Avoid overflow in size calculations.
2034 Don't update size until allocation succeeds.
2035 * fns.c (concat): Check for overflow in size calculations.
2036 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2037 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2038 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2040 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2041 (get_doc_string): Check for size calculation overflow.
2042 Don't update size until allocation succeeds.
2043 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2044 EMACS_INT, where ptrdiff_t will do.
2045 (Fsubstitute_command_keys): Check for string overflow.
2047 * editfns.c (set_time_zone_rule): Don't assume environment length
2049 (message_length): Now ptrdiff_t, not int.
2050 (Fmessage_box): Don't update size until allocation succeeds.
2051 Don't assume message length fits in int.
2052 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2054 * emacs.c (main): Do not reallocate argv, since there is a null at
2055 the end that can be overwritten, and this way there's no need to
2056 worry about size-calculation overflow.
2057 (sort_args): Check for size-calculation overflow.
2059 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2061 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2063 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2064 (x_set_scroll_bar_width, x_figure_window_size):
2065 Check for integer overflow.
2066 (x_set_alpha): Do not assume XINT fits in int.
2068 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2069 This is for the members text_lines, text_cols, total_lines, total_cols,
2070 where the system imposes an 'int' limit.
2072 * fringe.c (Fdefine_fringe_bitmap):
2073 Don't update size until alloc works.
2075 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2076 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2078 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2079 Check for size-calculation overflow.
2080 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2081 do, as we prefer signed integers.
2082 (id_to_widget.max_size, id_to_widget.used)
2083 (xg_store_widget_in_map, xg_remove_widget_from_map)
2084 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2085 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2086 Use and return ptrdiff_t, not int.
2087 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2088 * gtkutil.h: Change prototypes to match the above.
2090 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2091 are duplicate now that they've been promoted to lisp.h.
2092 (x_allocate_bitmap_record, x_alloc_image_color)
2093 (make_image_cache, cache_image, xpm_load):
2094 Don't update size until alloc is done.
2095 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2097 Check for size calculation overflow.
2098 (ct_colors_allocated_max): New constant.
2099 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2102 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2103 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2104 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2105 Use ptrdiff_t, not int, to count maps.
2106 (read_char_minibuf_menu_prompt): Check for overflow in size
2107 calculations. Don't update size until allocation succeeds.
2108 Redo calculations to avoid overflow.
2109 * keyboard.h: Change prototypes to match the above.
2111 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2113 (current_minor_maps): Check for size calculation overflow.
2114 * keymap.h: Change prototypes to match the above.
2116 * lread.c (read1, init_obarray): Don't update size until alloc done.
2118 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2119 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2121 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2122 Now ptrdiff_t, not int.
2123 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2124 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2126 * process.c (Fnetwork_interface_list): Check for overflow
2127 in size calculation.
2129 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2131 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2132 overflow. Don't bother calling xmalloc when xrealloc will do.
2134 * search.c (Freplace_match): Check for size calculation overflow.
2135 (Fset_match_data): Don't assume list lengths fit in 'int'.
2137 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2138 for command line length. Do not attempt to address one before the
2139 beginning of an array, as that's not portable.
2141 * term.c (max_frame_lines): Remove; unused.
2142 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2144 (encode_terminal_code, calculate_costs): Check for size
2145 calculation overflow.
2146 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2147 table lengths and related sizes. Don't update size until alloc
2148 done. Redo calculations to avoid overflow.
2149 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2151 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2152 subtracting pointers.
2153 (gobble_line): Check for overflow more carefully. Don't update size
2156 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2157 Don't update size until alloc done.
2158 Redo size calculations to avoid overflow.
2159 Check for size calculation overflow.
2160 (main) [DEBUG]: Fix typo in invoking tparam1.
2162 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2163 Use ptrdiff_t, not int, for sizes.
2164 (store_mode_line_noprop_char): Don't update size until alloc done.
2166 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2167 Use ptrdiff_t, not int, for sizes.
2168 (Finternal_make_lisp_face, cache_face):
2169 Check for size calculation overflow.
2170 (cache_face): Treat size calculation overflows as if they were
2171 memory exhaustion (the usual treatment), rather than aborting.
2173 * xfns.c (x_encode_text, x_set_name_internal)
2174 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2175 sizes, since they can exceed INT_MAX in size. Check for size
2176 calculation overflow.
2178 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2179 (xg_select): Check for size calculation overflow.
2180 Don't update size until alloc done.
2182 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2183 as sprintf is limited to int lengths.
2185 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2186 (X_LONG_MIN): New macros.
2187 Use them to make the following changes clearer.
2188 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2189 This change doesn't affect the value now, but it may help remind
2190 future maintainers not to raise the value too much later.
2191 (SELECTION_QUANTUM): Remove, replacing with ...
2192 (selection_quantum): ... new function, which avoids overflow.
2194 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2195 assumption that selection length fits in 'int'.
2196 (x_reply_selection_request, x_handle_selection_request)
2197 (x_get_window_property, receive_incremental_selection)
2198 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2199 (lisp_data_to_selection_data, clean_local_selection_data):
2200 Use ptrdiff_t, not int, to record length of selection.
2201 (x_reply_selection_request, x_get_window_property)
2202 (receive_incremental_selection, x_property_data_to_lisp):
2203 Redo calculations to avoid overflow.
2204 (x_reply_selection_request): When sending hint, ceiling it at
2205 X_LONG_MAX rather than relying on wraparound overflow to send
2207 (x_get_window_property, receive_incremental_selection)
2208 (lisp_data_to_selection_data, x_property_data_to_lisp):
2209 Check for size-calculation overflow.
2210 (x_get_window_property, receive_incremental_selection)
2211 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2212 Don't store size until memory allocation succeeds.
2213 (x_get_window_property): Plug memory leak on memory exhaustion.
2214 Don't double-block input; malloc is safe here. Don't assume 2**34
2215 - 4 fits in unsigned long. Add an xassert to check
2216 XGetWindowProperty overflow. Be more careful about overflow
2217 calculations, and distinguish size from memory overflow better.
2218 (receive_incremental_selection): When tracing, don't assume
2219 unsigned int is less than INT_MAX.
2220 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2221 harmful) conversions of unsigned short to int.
2222 (lisp_data_to_selection_data): Don't assume that integers
2223 in the range -65535 through -1 fit in an X unsigned short.
2224 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2225 result parameters unless successful. Rely on cons_to_unsigned
2226 to report problems with elements; the old code wasn't right anyway.
2227 (x_check_property_data): Check for int overflow; we cannot use
2228 a wider type due to X limits.
2229 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2231 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2233 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2234 (x_term_init): Check for size calculation overflow.
2235 (x_color_cells): Don't store size until memory allocation succeeds.
2236 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2237 Don't assume alloca size is less than MAX_ALLOCA.
2238 (x_term_init): Don't assume length fits in int (sprintf is limited
2241 Use ptrdiff_t for composition IDs.
2242 * character.c (lisp_string_width):
2243 * composite.c (composition_table_size, n_compositions)
2244 (get_composition_id, composition_gstring_from_id):
2245 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2246 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2247 * window.c (Frecenter):
2248 Use ptrdiff_t, not int, for composition IDs.
2249 * composite.c (get_composition_id): Check for integer overflow.
2250 * composite.h: Adjust prototypes to match the above changes.
2252 Use ptrdiff_t for hash table indexes.
2253 * category.c (hash_get_category_set):
2254 * ccl.c (ccl_driver):
2255 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2256 * coding.c (coding_system_charset_list, detect_coding_system):
2257 * coding.h (struct coding_system.id):
2258 * composite.c (get_composition_id, gstring_lookup_cache):
2259 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2260 * image.c (xpm_get_color_table_h):
2261 * lisp.h (hash_lookup, hash_put):
2262 * minibuf.c (Ftest_completion):
2263 Use ptrdiff_t for hash table indexes, not int (which is too
2264 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2265 32-bit --with-wide-int hosts).
2267 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2268 Add a FIXME comment about memory leaks.
2269 (syms_of_charset): Don't assume xmalloc returns.
2271 Don't assume that stated character widths fit in int.
2272 * character.c (Fchar_width, c_string_width, lisp_string_width):
2273 * character.h (CHAR_WIDTH):
2274 * indent.c (MULTIBYTE_BYTES_WIDTH):
2275 Use sanitize_char_width to avoid undefined and/or bad behavior
2276 with outlandish widths.
2277 * character.h (sanitize_tab_width): Rename from sanitize_width,
2278 now that we have two such functions. All uses changed.
2279 (sanitize_char_width): New inline function.
2281 Don't assume that tab-width fits in int.
2282 * character.h (sanitize_width): New inline function.
2283 (SANE_TAB_WIDTH): New macro.
2284 (ASCII_CHAR_WIDTH): Use it.
2285 * indent.c (sane_tab_width): Remove. All uses replaced by
2286 SANE_TAB_WIDTH (current_buffer).
2287 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2289 * fileio.c: Integer overflow issues with file modes.
2290 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2292 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2293 Remove unreachable code.
2294 (read_hex, load_charset_map_from_file): Check for integer overflow.
2296 * xterm.c: don't go over XClientMessageEvent limit
2297 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2298 (x_send_scroll_bar_event): Likewise. Check that the size does not
2299 exceed limits imposed by XClientMessageEvent, as well as the usual
2300 ptrdiff_t and size_t limits.
2302 * keyboard.c: Overflow, signedness and related fixes.
2303 (make_lispy_movement): Use same integer type in forward decl
2304 that is used in the definition.
2305 (read_key_sequence, keyremap_step):
2306 Change bufsize argument back to int, undoing my 2011-03-30 change.
2307 We prefer signed types, and int is wide enough here.
2308 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2309 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2310 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2311 length, not size_t. Use ptrdiff_t for index, not int.
2312 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2313 possibility of integer overflow.
2315 Overflow, signedness and related fixes for images.
2317 * dispextern.h (struct it.stack[0].u.image.image_id)
2318 (struct_it.image_id, struct image.id, struct image_cache.size)
2319 (struct image_cache.used, struct image_cache.ref_count):
2320 * gtkutil.c (update_frame_tool_bar):
2321 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2322 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2323 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2324 * nsmenu.m (update_frame_tool_bar):
2325 * xdisp.c (calc_pixel_width_or_height):
2326 * xfns.c (image_cache_refcount):
2327 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2328 on typical 64-bit hosts.
2330 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2331 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2332 Omit unnecessary casts to int.
2333 (parse_image_spec): Check that integers fall into 'int' range
2334 when the callers expect that.
2335 (image_ascent): Redo ascent calculation to avoid int overflow.
2336 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2337 (lookup_image): Remove unnecessary tests.
2338 (xbm_image_p): Locals are now of int, not EMACS_INT,
2339 since parse_image_check makes sure they fit into int.
2340 (png_load, gif_load, svg_load_image):
2341 Prefer int to unsigned where either will do.
2342 (tiff_handler): New function, combining the cores of the
2343 old tiff_error_handler and tiff_warning_handler.
2344 This function is rewritten to use vsnprintf and thereby avoid
2345 stack buffer overflows. It uses only the features of vsnprintf
2346 that are common to both POSIX and native Microsoft.
2347 (tiff_error_handler, tiff_warning_handler): Use it.
2348 (tiff_load, gif_load, imagemagick_load_image):
2349 Don't assume :index value fits in 'int'.
2350 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2351 (imagemagick_load_image): Check that crop parameters fit into
2352 the integer types that MagickCropImage accepts. Don't assume
2353 Vimagemagick_render_type has a nonnegative value. Don't assume
2354 size_t fits in 'long'.
2355 (gs_load): Use printmax_t to print the widest integers possible.
2356 Check for integer overflow when computing image height and width.
2358 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2360 * xdisp.c (redisplay_window): Don't force window start if point
2361 will be invisible in the resulting window. (Bug#9324)
2363 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2365 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2366 the display spec is of the form `(space ...)'.
2367 (handle_display_spec): Return the value returned by
2368 handle_single_display_spec, not just 1 or zero.
2369 (handle_single_display_spec): If the display spec is of the form
2370 `(space ...)', and specifies display in the text area, return 2
2372 (try_cursor_movement): Check for the need to scroll more
2373 accurately, and prefer exact match for point under bidi.
2374 Don't advance `row' beyond the last row of the window.
2376 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2377 into disp_prop; all users changed.
2379 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2380 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2381 for the text covered by the display property.
2383 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2385 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2386 Change return value to nil.
2387 (Frecord_buffer): Delete unused function.
2389 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2391 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2392 buffers, return left-to-right.
2393 (set_cursor_from_row): Consider candidate row a win if its glyph
2394 represents a newline and point is on that newline. Fixes cursor
2395 positioning on the newline at EOL of R2L text within L2R
2396 paragraph, and vice versa.
2397 (try_cursor_movement): Check continued rows, in addition to
2398 continuation rows. Fixes unwarranted scroll when point enters a
2399 continued line of R2L text within an L2R paragraph, or vice versa.
2400 (cursor_row_p): Consider the case of point being equal to
2401 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2402 from the end of a short line to the beginning of a continued line
2403 of R2L text within L2R paragraph.
2404 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2405 composed characters.
2407 * bidi.c (bidi_check_type): Use xassert.
2408 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2411 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2413 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2416 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2418 * nsfont.m (ns_otf_to_script): Fix typo.
2420 2011-08-22 Kenichi Handa <handa@m17n.org>
2422 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2423 extra slot even if the purpose is char-code-property-table.
2425 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2427 * xdisp.c (redisplay_window): When computing centering_position,
2428 account for the height of the header line. (Bug#8874)
2430 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2431 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2432 candidate is selected by the mouse, and that candidate has a
2433 composed character under the mouse.
2435 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2436 coordinates reported by pos-visible-in-window-p for a composed
2437 character in column zero.
2439 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2441 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2443 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2445 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2446 consider it a hit if to_charpos is anywhere in the range of the
2447 composed buffer positions.
2449 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2451 * image.c (gif_load): Don't assume that each subimage has the same
2452 dimensions as the base image. Handle disposal method that is
2453 "undefined" by the gif spec (Bug#9335).
2455 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2457 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2458 (Fcondition_case): Document `debug' symbol in error handler.
2460 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2462 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2463 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2464 from an Org mode buffer to a Speedbar frame.
2466 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2467 a composition, take its buffer position from IT->cmp_it.charpos.
2468 Fixes cursor positioning at the beginning of a line that begins
2469 with a composed character.
2471 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2473 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2474 character bidirectional type, use STRONG_L instead. Fixes crashes
2475 in a buffer produced by `describe-categories'.
2477 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2478 members before the level stack, so they would be saved and
2479 restored when copying iterator state. Fixes incorrect reordering
2480 around TABs covered by display properties.
2482 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2484 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2486 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2488 * eval.c (internal_condition_case, internal_condition_case_1)
2489 (internal_condition_case_2, internal_condition_case_n):
2490 Remove unnecessary aborts (Bug#9081).
2492 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2494 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2495 has no `load' handler, try opening the file locally. (Bug#9311)
2497 2011-08-16 Ken Brown <kbrown@cornell.edu>
2499 * gmalloc.c: Expand comment.
2501 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2503 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2504 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2506 2011-08-16 Ken Brown <kbrown@cornell.edu>
2508 Fix memory allocation problems in Cygwin build (Bug#9273).
2510 * unexcw.c ( __malloc_initialized): Declare external variable.
2511 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2513 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2515 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2517 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2519 [CYGWIN] (special_realloc): New function.
2520 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2521 requests to realloc storage in the static heap.
2523 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2525 * bidi.c (bidi_initialize): Remove unused local.
2527 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2530 * biditype.h: Remove file.
2531 * makefile.w32-in ($(BLD)/bidi.$(O)):
2532 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2534 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2536 * chartab.c: Improve commentary for the uniprop_table API.
2538 * bidi.c (bidi_paragraph_init): Support zero value of
2539 bidi_ignore_explicit_marks_for_paragraph_level.
2540 (bidi_initialize): Use uniprop_table instead of including
2541 biditype.h and bidimirror.h.
2543 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2544 coordinates of the iterator when restoring from ppos_it.
2547 2011-08-14 Kenichi Handa <handa@m17n.org>
2549 * process.c (create_process): Call setup_process_coding_systems
2550 after the pid of the process is set to -1 (Bug#8162).
2552 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2554 * xdisp.c (move_it_in_display_line_to): Don't invoke
2555 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2556 ppos_it. Fixes vertical cursor motion when line beginning is
2557 covered by an image. (Bug#9296)
2559 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2561 * nsterm.h (ns_run_ascript): Declare.
2562 (NSAPP_DATA2_RUNASSCRIPT): Define.
2564 * nsfns.m (as_script, as_result, as_status): New static variables.
2565 (ns_run_ascript): New function.
2566 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2567 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2568 the event loop. Get status from as_status (Bug#7276).
2570 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2571 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2572 the event loop (Bug#7276).
2574 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2576 * gnutls.c (QCgnutls_bootprop_priority)
2577 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2578 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2579 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2580 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2581 (QCgnutls_bootprop_verify_hostname_error)
2582 (QCgnutls_bootprop_callbacks_verify): Rename from
2583 Qgnutls_bootprop_..., all uses changed.
2585 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2588 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2590 * xfaces.c (Qframe_set_background_mode): Now static.
2591 * dispextern.h (Qframe_set_background_mode): Remove decl.
2593 * process.c (Fnetwork_interface_info): Declare local only if needed.
2595 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2597 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2598 (Fnetwork_interface_list): Allocate in increments of bytes instead
2599 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2600 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2602 (struct ifflag_def): notrailers is smart on OSX.
2603 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2604 Get hardware address with getifaddrs if available.
2606 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2608 * xdisp.c (iterate_out_of_display_property): xassert that
2609 IT->position is set to within IT->object's boundaries. Break from
2610 the loop as soon as EOB is reached; avoids infloops in redisplay
2611 when IT->position is set up wrongly due to some bug.
2612 Set IT->current to match the bidi iterator unconditionally.
2613 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2614 entry. Force push_it to save on the stack the current
2615 buffer/string position, to be restored by pop_it. Fix flags in
2616 the iterator structure wrt the object coming from a display
2617 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2618 properties. (Bug#9284)
2620 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2622 * fontset.c (fontset_get_font_group): Add proper type checks.
2625 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2627 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2628 and LC_VERSION_MIN_MACOSX.
2629 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2630 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2632 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2634 * xdisp.c (forward_to_next_line_start): Allow to use the
2635 no-display-properties-and-no-overlays under bidi display.
2636 Set disp_pos in the bidi iterator to avoid searches for display
2637 properties and overlays.
2639 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2641 * editfns.c (Fset_time_zone_rule): Document relationship with the
2644 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2645 the font entity extracted from the cache (Bug#8109).
2647 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2649 * composite.c (autocmp_chars): Don't reset point. That is done by
2650 restore_point_unwind (Bug#5984).
2652 2011-08-07 Juri Linkov <juri@jurta.org>
2654 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2655 to show the arg `TIME' instead of `TIMEVAL'.
2657 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2659 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2660 display property strides EOL and includes a newline, as in
2661 longlines-mode. (Bug#9254)
2662 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2663 word-wrap under bidirectional display. (Bug#9224)
2665 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2666 is non-zero, even if the data buffer is NULL. Fixes a crash in
2667 vertical-motion with longlines-mode. (Bug#9254)
2669 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2671 * bidi.c <bidi_cache_total_alloc>: Now static.
2672 (bidi_initialize): Initialize bidi_cache_total_alloc.
2674 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2677 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2678 amount allocated this far in `bidi_cache_total_alloc'.
2679 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2680 non-zero, only free the data buffer without restoring the cache
2681 contents. All callers changed.
2683 * dispextern.h (bidi_unshelve_cache): Update prototype.
2685 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2686 (move_it_in_display_line, move_it_to)
2687 (move_it_vertically_backward, move_it_by_lines): Replace the call
2688 to xfree to an equivalent call to bidi_unshelve_cache.
2689 (move_it_in_display_line_to): Fix logic of returning
2690 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2692 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2694 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2695 came from a string character with a `cursor' property. (Bug#9229)
2697 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2699 * Makefile.in (LIB_PTHREAD): New variable.
2700 (LIBES): Add LIB_PTHREAD (Bug#9216).
2702 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2703 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2705 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2707 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2709 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2711 * xterm.c (x_find_topmost_parent): New function.
2712 (x_set_frame_alpha): Find topmost parent window with
2713 x_find_topmost_parent and set the property there also (bug#9181).
2714 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2716 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2718 * callproc.c (Fcall_process): Avoid vfork clobbering
2719 the local vars buffer, coding_systems, current_dir.
2721 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2723 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2725 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2727 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2728 so that it is not optimized away.
2730 * xdisp.c (compute_display_string_pos): Remove unused local.
2732 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2734 Fix slow cursor motion and scrolling in large buffers with
2735 selective display, like Org Mode buffers. (Bug#9218)
2737 * dispextern.h (struct bidi_it): New member disp_prop_p.
2739 * xdisp.c: Remove one-slot cache of display string positions.
2740 (compute_display_string_pos): Accept an additional argument
2741 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2742 for a display string or property. If found, set DISP_PROP_P
2745 * bidi.c (bidi_fetch_char): Accept an additional argument
2746 DISP_PROP_P, and pass it to compute_display_string_pos.
2747 Only handle text covered by a display string if DISP_PROP_P is returned
2748 non-zero. All callers of bidi_fetch_char changed.
2750 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2752 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2754 2010-12-03 Don March <don@ohspite.net>
2756 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2757 last character M-[char] is translated to ESC [char] (bug#7541).
2759 2011-08-02 Kenichi Handa <handa@m17n.org>
2761 * lisp.h (uniprop_table): Extern it.
2763 * chartab.c (uniprop_table): Make it non-static.
2765 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2767 * xdisp.c (forward_to_next_line_start): Accept additional argument
2768 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2770 (reseat_at_next_visible_line_start): Use the bidi iterator state
2771 returned by forward_to_next_line_start to restore the state of
2772 it->bidi_it after backing up to previous newline. (Bug#9212)
2774 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2776 * regex.c (re_comp): Protoize.
2777 (re_exec): Fix return type.
2778 (regexec): Fix type of `ret'. (Bug#9203)
2780 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2782 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2783 This is needed if max-image-size is a floating-point number.
2785 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2787 * print.c (print_object): Print empty symbol as ##.
2789 * lread.c (read1): Read ## as empty symbol.
2791 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2793 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2794 setting frame foreground color (Bug#9175).
2795 (x_set_background_color): Likewise.
2797 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2798 contents (Bug#9176).
2799 (EmacsTooltip -init): Remove bezels and add shadows to
2802 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2803 or scroll bar (Bug#8470).
2805 * nsfont.m (nsfont_open): Remove assignment to voffset and
2806 unnecessary vars hshink, expand, hd, full_height, min_height.
2807 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2809 * nsterm.h (nsfont_info): Remove voffset field.
2811 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2813 Implement strike-through and overline on NextStep (Bug#8863).
2815 * nsfont.m (nsfont_open): Use underline position provided by font,
2816 instead of hard-coded value of 2.
2817 (nsfont_draw): Call ns_draw_text_decoration instead.
2819 * nsterm.h: Add declaration for ns_draw_text_decoration.
2821 * nsterm.m (ns_draw_text_decoration): New function for drawing
2822 underline, overline, and strike-through.
2823 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2824 ns_draw_text_decoration. Change treatment of cursor drawing to
2825 accommodate underlining, etc.
2827 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2829 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2832 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2834 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2835 Without this fix, if a signal arrives just after memory fills up,
2836 'malloc' might be invoked reentrantly.
2838 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2839 In other words, assume that every image size is allowed, on non-X
2840 hosts. This assumption is probably wrong, but it lets Emacs compile.
2842 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2844 * regex.c (re_iswctype): Convert return values to boolean.
2846 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2848 * xdisp.c (compute_display_string_pos): Don't use cached display
2849 string position if the buffer had its restriction changed.
2852 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2854 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2856 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2858 Integer signedness and overflow and related fixes. (Bug#9079)
2860 * bidi.c: Integer size and overflow fixes.
2861 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2862 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2863 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2864 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2865 (bidi_find_other_level_edge):
2866 Use ptrdiff_t instead of EMACS_INT where either will do.
2867 This works better on 32-bit hosts configured --with-wide-int.
2868 (bidi_cache_ensure_space): Check for size-calculation overflow.
2869 Use % rather than repeated addition, for better worst-case speed.
2870 Don't set bidi_cache_size until after xrealloc returns, because it
2872 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2873 (bidi_cache_ensure_space): Also check that the bidi cache size
2874 does not exceed that of the largest Lisp string or buffer. See Eli
2875 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2877 * alloc.c (__malloc_size_t): Remove.
2878 All uses replaced by size_t. See Andreas Schwab's note
2879 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2881 * image.c: Improve checking for integer overflow.
2882 (check_image_size): Assume that f is nonnull, since
2883 it is always nonnull in practice. This is one less thing to
2884 worry about when checking for integer overflow later.
2885 (x_check_image_size): New function, which checks for integer
2886 overflow issues inside X.
2887 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2888 This removes the need for a memory_full check.
2889 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2890 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2891 (xbm_read_bitmap_data): Change locals back to 'int', since
2892 their values must fit in 'int'.
2893 (xpm_load_image, png_load, tiff_load):
2894 Invoke x_create_x_image_and_pixmap earlier,
2895 to avoid much needless work if the image is too large.
2896 (tiff_load): Treat overly large images as if
2897 x_create_x_image_and_pixmap failed, not as malloc failures.
2898 (gs_load): Use x_check_image_size.
2900 * gtkutil.c: Omit integer casts.
2901 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2902 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2904 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2906 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2907 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2908 would wrongly return t on a 64-bit host.
2910 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2911 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2912 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2913 and therefore cause GCC to emit a bogus diagnostic in some cases.
2915 * image.c: Integer signedness and overflow and related fixes.
2916 This is not an exhaustive set of fixes, but it's time to
2917 record what I've got.
2918 (lookup_pixel_color, check_image_size): Remove redundant decls.
2919 (check_image_size): Don't assume that arbitrary EMACS_INT values
2920 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2921 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2922 (tiff_load, imagemagick_load_image):
2923 Check for overflow in size calculations.
2924 (x_create_x_image_and_pixmap): Remove unnecessary test for
2925 xmalloc returning NULL; that can't happen.
2926 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2927 (xpm_color_bucket): Use better integer hashing function.
2928 (xpm_cache_color): Don't possibly over-allocate memory.
2929 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2930 (gif_memory_source):
2931 Use ptrdiff_t, not int or size_t, to record sizes.
2932 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2933 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2934 either works, as we prefer signed integers.
2935 (tiff_read_from_memory, tiff_write_from_memory):
2936 Return tsize_t, not size_t, since that's what the TIFF API wants.
2937 (tiff_read_from_memory): Don't fail simply because the read would
2938 go past EOF; instead, return a short read.
2939 (tiff_load): Omit no-longer-needed casts.
2940 (Fimagemagick_types): Don't assume size fits into 'int'.
2942 Improve hashing quality when configured --with-wide-int.
2943 * fns.c (hash_string): New function, taken from sxhash_string.
2944 Do not discard information about ASCII character case; this
2945 discarding is no longer needed.
2946 (sxhash-string): Use it. Change sig to match it. Caller changed.
2947 * lisp.h: Declare it.
2948 * lread.c (hash_string): Remove, since we now use fns.c's version.
2949 The fns.c version returns a wider integer if --with-wide-int is
2950 specified, so this should help the quality of the hashing a bit.
2952 * emacs.c: Integer overflow minor fix.
2953 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2954 Define only if GNU_LINUX.
2955 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2957 * dispnew.c: Integer signedness and overflow fixes.
2958 Remove unnecessary forward decls, that were a maintenance hassle.
2959 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2961 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2962 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2963 (prepare_desired_row, line_draw_cost):
2964 Use int, not unsigned, where either works.
2965 (save_current_matrix, restore_current_matrix):
2966 Use ptrdiff_t, not size_t, where either works.
2967 (init_display): Check for overflow more accurately, and without
2968 relying on undefined behavior.
2970 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2971 Remove, replacing with the new symbols in lisp.h. All uses changed.
2972 * fileio.c (make_temp_name):
2973 * filelock.c (lock_file_1, lock_file):
2974 * xdisp.c (message_dolog):
2975 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2976 Use pMd etc. instead.
2977 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2978 replacing the pWIDE etc. symbols removed from editfns.c.
2980 * keyboard.h (num_input_events): Now uintmax_t.
2981 This is (very slightly) less likely to mess up due to wraparound.
2984 * buffer.c: Integer signedness fixes.
2985 (alloc_buffer_text, enlarge_buffer_text):
2986 Use ptrdiff_t rather than size_t when either will do, as we prefer
2989 * alloc.c: Integer signedness and overflow fixes.
2990 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2991 (__malloc_size_t): Default to size_t, not to int.
2992 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2993 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2994 Prefer ptrdiff_t to size_t when either would do, as we prefer
2996 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2997 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2998 Now const. Initialize with values that are in range even if char
3000 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3001 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3002 These functions do the right thing with sizes > 2**32.
3003 (check_depth): Now ptrdiff_t, not int.
3004 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3005 Adjust to new way of storing sizes. Check for size overflow bugs
3007 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3008 slightly wrong anyway, as it missed one instance of
3009 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3010 (refill_memory_reserve): Omit needless cast to size_t.
3011 (mark_object_loop_halt): Mark as externally visible.
3013 * xselect.c: Integer signedness and overflow fixes.
3014 (Fx_register_dnd_atom, x_handle_dnd_message):
3015 Use ptrdiff_t, not size_t, since we prefer signed.
3016 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3017 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3018 x_dnd_atoms_size and x_dnd_atoms_length.
3020 * doprnt.c: Prefer signed to unsigned when either works.
3022 * doprnt.c (doprnt):
3024 * xdisp.c (vmessage):
3025 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3026 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3027 prefer signed arithmetic to avoid comparison confusion.
3028 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3029 but is a bit tricky.
3031 Assume freestanding C89 headers, string.h, stdlib.h.
3032 * data.c, doprnt.c, floatfns.c, print.c:
3033 Include float.h unconditionally.
3034 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3035 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3036 * regex.c: Likewise for stddef.h, string.h.
3037 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3038 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3039 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3040 (STDC_HEADERS): Remove obsolete defines.
3041 * sysdep.c: Include limits.h unconditionally.
3043 Assume support for memcmp, memcpy, memmove, memset.
3044 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3045 * regex.c (memcmp, memcpy):
3046 Remove; we assume C89 now.
3048 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3049 (__malloc_safe_bcopy): Remove; no longer needed.
3051 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3052 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3053 well either way, and we prefer signed to unsigned.
3055 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3057 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3058 closes the connection while we're reading (bug#9182).
3060 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3062 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3063 are specified (Bug#9168).
3065 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3067 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3068 Found by GCC static checking and --with-wide-int on a 32-bit host.
3070 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3072 * xdisp.c (compute_display_string_pos): Fix logic of caching
3073 previous display string position. Initialize cached_prev_pos to
3074 -1. Fixes slow-down at the beginning of a buffer.
3076 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3078 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3079 for attrs[LFACE_FONTSET_INDEX].
3081 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3083 * xml.c (parse_region): Remove unused local
3084 that was recently introduced.
3086 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3088 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3089 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3091 * xdisp.c (move_it_in_display_line_to): Record the best matching
3092 position for TO_CHARPOS while scanning the line, and restore it on
3093 exit if none of the characters scanned was an exact match.
3094 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3095 when exact match is impossible due to invisible text, and the
3096 lines are truncated.
3098 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3100 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3103 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3105 Fix a significant slow-down of cursor motion with C-n, C-p,
3106 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3107 auto-repeat under bidi redisplay in fontified buffers.
3108 * xdisp.c (compute_stop_pos_backwards): New function.
3109 (next_element_from_buffer): Call compute_stop_pos_backwards to
3110 find a suitable prev_stop when we find ourselves before
3112 (reseat): Don't look for prev_stop, as that could mean a very long
3114 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3115 <cached_disp_overlay_modiff>: Cache for last found display string
3117 (compute_display_string_pos): Return the cached position if asked
3118 about the same buffer in the same area of character positions, and
3119 the buffer wasn't changed since the time the display string
3120 position was cached.
3122 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3124 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3125 is an integer, which is important for empty lines. (Bug#9149)
3127 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3129 * frame.c (Fmodify_frame_parameters): In tty case, update the
3130 default face if necessary (Bug#4238).
3132 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3134 * editfns.c (Fstring_to_char): No need to explain what a character
3135 is in the docstring (Bug#6576).
3137 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3139 * xml.c (parse_region): Make sure we always return a tree.
3141 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3143 * xml.c (parse_region): If a document contains only comments,
3146 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3148 * xml.c (make_dom): Return comments, too.
3150 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3153 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3154 and the surrounding thread.
3155 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3156 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3157 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3159 * s/openbsd.h (BROKEN_SIGIO): Define.
3160 * unexelf.c (unexec) [__OpenBSD__]:
3161 Don't update the .mdebug section of the Alpha COFF symbol table.
3163 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3165 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3168 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3170 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3171 This fixes some race conditions on the permissions of any newly
3174 * alloc.c (valid_pointer_p): Use pipe, not open.
3175 This fixes some permissions issues when debugging.
3177 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3178 If fchown fails to set both uid and gid, try to set just gid,
3179 as that is sometimes allowed. Adjust the file's mode to eliminate
3180 setuid or setgid bits that are inappropriate if fchown fails.
3182 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3184 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3185 to compare Lisp_Objects.
3186 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3187 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3188 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3190 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3192 * lread.c (read_integer): Unread even EOF character.
3193 (read1): Likewise. Properly record start position of symbol.
3195 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3196 symbol character follows.
3198 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3200 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3201 This works around a problem with the previous change to Fcopy_file.
3202 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3203 and without this change, GCC might complain about discarding
3204 fchown's return value.
3206 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3208 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3210 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3212 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3214 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3216 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3217 it's used from the C level.
3219 * process.c: Use the same condition for POLL_FOR_INPUT in both
3220 keyboard.c and process.c (bug#1858).
3222 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3224 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3225 (Fgnutls_boot): Use it.
3227 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3229 * doc.c (Fsubstitute_command_keys): Revert last change.
3231 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3233 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3234 quotes the next character, and doesn't affect other longer
3235 sequences (bug#8935).
3237 * lread.c (syms_of_lread): Clarify that is isn't only
3238 `eval-buffer' and `eval-defun' that's affected by
3239 `lexical-binding' (bug#8460).
3241 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3243 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3244 bidi redisplay when a line includes both an image and is truncated.
3246 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3248 Fix minor problems found by static checking.
3249 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3250 (elsz): Now a signed constant, not a size_t var. We prefer signed
3251 types to unsigned, to avoid integer comparison confusion. Without
3252 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3253 "cannot optimize loop, the loop counter may overflow", a symptom
3255 * indent.c (Fvertical_motion): Mark locals as initialized.
3256 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3258 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3260 * search.c (Fre_search_backward): Mention `case-fold-search' in
3261 all the re_search_* functions (bug#8138).
3263 * keyboard.c (Fopen_dribble_file): Document when the file is
3266 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3268 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3271 Support bidi reordering of display and overlay strings.
3272 * xdisp.c (compute_display_string_pos)
3273 (compute_display_string_end): Accept additional argument STRING.
3274 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3275 (reseat_to_string): Initialize bidi_it->string.s and
3276 bidi_it->string.schars.
3277 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3278 NULL (avoids a crash in bidi_paragraph_init).
3279 Initialize itb.string.lstring.
3280 (init_iterator): Call bidi_init_it only of a valid
3281 buffer position was specified. Initialize paragraph_embedding to
3283 (reseat_to_string): Initialize the bidi iterator.
3284 (display_string): If we need to ignore text properties of
3285 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3286 original value of -1 will not work with bidi.)
3287 (compute_display_string_pos): First arg is now struct
3288 `text_pos *'; all callers changed. Support display properties on
3290 (compute_display_string_end): Support display properties on Lisp
3292 (init_iterator, reseat_1, reseat_to_string): Initialize the
3293 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3294 when iterating on a string not from display properties).
3295 (compute_display_string_pos, compute_display_string_end):
3296 Fix calculation of the object to scan. Fixes an error when using
3298 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3299 base_level_stop; instead, set base_level_stop to BEGV.
3300 Fixes crashes in vertical-motion.
3301 (next_element_from_buffer): Improve commentary for when
3302 the iterator is before prev_stop.
3303 (init_iterator): Initialize bidi_p from the default value of
3304 bidi-display-reordering, not from buffer-local value. Use the
3305 buffer-local value only if initializing for buffer iteration.
3306 (handle_invisible_prop): Support invisible properties on strings
3307 that are being bidi-reordered.
3308 (set_iterator_to_next): Support bidi reordering of C strings and
3310 (next_element_from_string): Support bidi reordering of Lisp
3312 (handle_stop_backwards): Support Lisp strings as well.
3313 (display_string): Support display of R2L glyph rows.
3314 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3315 (init_iterator): Don't initialize it->bidi_p for strings
3317 (reseat_to_string): Initialize it->bidi_p for strings here.
3318 (next_element_from_string, next_element_from_c_string)
3319 (next_element_from_buffer): Add xassert's for correspondence
3320 between IT's object being iterated and it->bidi_it.string
3322 (face_before_or_after_it_pos): Support bidi iteration.
3323 (next_element_from_c_string): Handle the case of the first string
3324 character that is not the first one in the visual order.
3325 (get_visually_first_element): New function, refactored from common
3326 parts of next_element_from_buffer, next_element_from_string, and
3327 next_element_from_c_string.
3328 (tool_bar_lines_needed, redisplay_tool_bar)
3329 (display_menu_bar): Force left-to-right direction. Add a FIXME
3330 comment for making that be controlled by a user option.
3331 (push_it, pop_it): Save and restore the state of the
3332 bidi iterator. Save and restore the bidi_p flag.
3333 (pop_it): Iterate out of display property for string iteration as
3335 (iterate_out_of_display_property): Support iteration over strings.
3336 (handle_single_display_spec): Set up it->bidi_it for iteration
3337 over a display string, and call bidi_init_it.
3338 (handle_single_display_spec, next_overlay_string)
3339 (get_overlay_strings_1, push_display_prop): Set up the bidi
3340 iterator for displaying display or overlay strings.
3341 (forward_to_next_line_start): Don't use the shortcut if
3343 (back_to_previous_visible_line_start): If handle_display_prop
3344 pushed the iterator stack, restore the internal state of the bidi
3345 iterator by calling bidi_pop_it same number of times.
3346 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3347 and we are bidi-iterating, don't decrement the iterator position;
3348 instead, set the first_elt flag in the bidi iterator, to produce
3350 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3351 (push_display_prop): xassert that we are iterating a buffer.
3352 (push_it, pop_it): Save and restore paragraph_embedding member.
3353 (handle_single_display_spec, next_overlay_string)
3354 (get_overlay_strings_1, reseat_1, reseat_to_string)
3355 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3356 correctly. Don't assume unibyte strings are not bidi-reordered.
3357 (compute_display_string_pos)
3358 (compute_display_string_end): Fix handling the case of C string.
3359 (push_it, pop_it): Save and restore from_disp_prop_p.
3360 (handle_single_display_spec, push_display_prop): Set the
3361 from_disp_prop_p flag.
3362 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3363 (pop_it): Call iterate_out_of_display_property only if we are
3364 popping after iteration over a string that came from a display
3365 property. Fix a typo in popping stretch info. Add an assertion
3366 for verifying that the iterator position is in sync with the bidi
3368 (handle_single_display_spec, get_overlay_strings_1)
3369 (push_display_prop): Fix initialization of paragraph direction for
3370 string when that of the parent object is not yet determined.
3371 (reseat_1): Call bidi_init_it to resync the bidi
3372 iterator with IT's position. (Bug#7616)
3373 (find_row_edges): If ROW->start.pos gives position
3374 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3375 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3376 Reset the from_disp_prop_p flag.
3377 (SAVE_IT, RESTORE_IT): New macros.
3378 (pos_visible_p, face_before_or_after_it_pos)
3379 (back_to_previous_visible_line_start)
3380 (move_it_in_display_line_to, move_it_in_display_line)
3381 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3382 (try_scrolling, redisplay_window, display_line): Use them when
3383 saving a temporary copy of the iterator and restoring it back.
3384 (back_to_previous_visible_line_start, reseat_1)
3385 (init_iterator): Empty the bidi cache "stack".
3386 (move_it_in_display_line_to): If iterator ended up at
3387 EOL, but we never saw any buffer positions smaller than
3388 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3389 motion in bidi-reordered lines.
3390 (move_it_in_display_line_to): Record prev_method and prev_pos
3391 immediately before the call to set_iterator_to_next. Fixes cursor
3392 motion in bidi-reordered lines with stretch glyphs and strings
3393 displayed in margins. (Bug#8133) (Bug#8867)
3394 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3396 (pos_visible_p): Support positions in bidi-reordered lines.
3397 Save and restore bidi cache.
3399 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3400 (bidi_paragraph_info): Delete unused struct.
3401 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3402 (bidi_cache_start): New variable.
3403 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3405 (bidi_cache_fetch_state, bidi_cache_search)
3406 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3407 (bidi_cache_find, bidi_peek_at_next_level)
3408 (bidi_level_of_next_char, bidi_find_other_level_edge)
3409 (bidi_move_to_visually_next): Compare cache index with
3410 bidi_cache_start rather than with zero.
3411 (bidi_fetch_char): Accept new argument STRING; all callers
3412 changed. Support iteration over a string. Support strings with
3413 display properties. Support unibyte strings. Fix the type of
3414 `len' according to what STRING_CHAR_AND_LENGTH expects.
3415 (bidi_paragraph_init, bidi_resolve_explicit_1)
3416 (bidi_resolve_explicit, bidi_resolve_weak)
3417 (bidi_level_of_next_char, bidi_move_to_visually_next):
3418 Support iteration over a string.
3419 (bidi_set_sor_type, bidi_resolve_explicit_1)
3420 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3421 can now be zero (for strings); special values 0 and -1 were
3422 changed to -1 and -2, respectively.
3423 (bidi_char_at_pos): New function.
3424 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3425 Call it instead of FETCH_MULTIBYTE_CHAR.
3426 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3427 initialized to valid values.
3428 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3430 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3431 the test for valid cached positions. Fix the logic for looking up
3432 the sentinel state in the cache. GCPRO the Lisp string we are
3434 (bidi_push_it, bidi_pop_it): New functions.
3435 (bidi_initialize): Initialize the bidi cache start stack pointer.
3436 (bidi_cache_ensure_space): New function, refactored from part of
3437 bidi_cache_iterator_state. Don't assume the required size is just
3438 one BIDI_CACHE_CHUNK away.
3439 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3440 (bidi_count_bytes, bidi_char_at_pos): New functions.
3441 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3442 always valid if bidi_cache_idx is valid.
3443 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3444 is valid if it's going to be used.
3445 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3446 (bidi_cache_fetch_state, bidi_cache_search)
3447 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3448 (bidi_cache_iterator_state, bidi_cache_find)
3449 (bidi_find_other_level_edge, bidi_cache_start_stack):
3450 All variables related to cache indices are now EMACS_INT.
3452 * dispextern.h (struct bidi_string_data): New structure.
3453 (struct bidi_it): New member `string'. Make flag members be 1-bit
3454 fields, and put them last in the struct.
3455 (compute_display_string_pos, compute_display_string_end):
3457 (bidi_push_it, bidi_pop_it): Add prototypes.
3458 (struct iterator_stack_entry): New members bidi_p,
3459 paragraph_embedding, and from_disp_prop_p.
3460 (struct it): Member bidi_p is now a bit field 1 bit wide.
3461 (bidi_shelve_cache, bidi_unshelve_cache):
3464 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3465 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3466 and vector-like objects.
3468 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3469 cache around display iteration.
3471 * window.c (Fwindow_end, window_scroll_pixel_based)
3472 (displayed_window_lines, Frecenter): Save and restore the bidi
3473 cache around display iteration.
3475 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3477 * editfns.c (Fdelete_region): Clarify the use of the named
3478 parameters (bug#6788).
3480 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3482 * indent.c (Fvertical_motion): Set and restore w->pointm when
3483 saving and restoring the window's buffer (Bug#9006).
3485 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3487 * editfns.c (Fstring_to_char): Clarify just what is returned
3488 (bug#6576). Text by Eli Zaretskii.
3490 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3492 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3494 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3496 * buffer.c (mmap_find): Fix a typo.
3498 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3500 Fix execution of x selection hooks.
3501 * xselect.c (Qx_lost_selection_functions)
3502 (Qx_sent_selection_functions): New vars.
3503 (syms_of_xselect): DEFSYM them.
3504 (x_handle_selection_request): Pass Qx_sent_selection_functions
3505 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3506 (x_handle_selection_clear,x_clear_frame_selections):
3507 Pass Qx_lost_selection_functions rather than
3508 Vx_lost_selection_functions to Frun_hook_with_args.
3510 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3512 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3513 The old code sometimes used this field without initializing it.
3515 * alloc.c (gc_sweep): Don't read past end of array.
3516 In theory, the old code could also have corrupted Emacs internals,
3517 though it'd be very unlikely.
3519 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3521 * character.c (Fcharacterp): Don't advertise optional ignored
3522 argument. (Bug#4026)
3524 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3526 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3529 * window.c (Fset_window_start): Doc fix (bug#4199).
3530 (Fset_window_hscroll): Ditto.
3532 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3534 Fix minor new problems caught by GCC 4.6.1.
3535 * term.c (init_tty): Remove unused local.
3536 * xsettings.c (store_monospaced_changed): Define this function only
3537 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3540 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3542 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3544 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3546 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3547 are the mini-buffer and the echo area (bug#3320).
3549 * term.c (init_tty): Remove support for supdup, c10 and perq
3550 terminals, which are no longer supported (bug#1482).
3552 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3554 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3556 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3558 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3559 for non-popups (Bug#3642).
3561 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3563 * alloc.c (reset_malloc_hooks): Protoize.
3564 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3565 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3566 * cm.c (losecursor): Likewise.
3567 * data.c (fmod): Likewise.
3568 * dispnew.c (swap_glyphs_in_rows): Likewise.
3569 * emacs.c (memory_warning_signal): Likewise.
3570 * floatfns.c (float_error): Likewise.
3571 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3572 (otf_open, font_otf_capability, generate_otf_features)
3573 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3575 * image.c (pbm_read_file): Likewise.
3576 * indent.c (string_display_width): Likewise.
3577 * intervals.c (check_for_interval, search_for_interval)
3578 (inc_interval_count, count_intervals, root_interval)
3579 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3580 * lread.c (defalias): Likewise.
3581 * ralloc.c (r_alloc_check): Likewise.
3582 * regex.c (set_image_of_range_1, set_image_of_range)
3583 (regex_grow_registers): Likewise.
3584 * sysdep.c (strerror): Likewise.
3585 * termcap.c (valid_filename_p, tprint, main): Likewise.
3586 * tparam.c (main): Likewise.
3587 * unexhp9k800.c (run_time_remap, save_data_space)
3588 (update_file_ptrs, read_header, write_header, calculate_checksum)
3589 (copy_file, copy_rest, display_header): Likewise.
3590 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3592 * xdisp.c (check_it): Likewise.
3593 * xfaces.c (register_color, unregister_color, unregister_colors):
3595 * xfns.c (print_fontset_result): Likewise.
3596 * xrdb.c (member, fatal, main): Likewise.
3598 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3600 Fix minor problems found by static checking (Bug#9031).
3601 * chartab.c (char_table_set_range, map_sub_char_table):
3602 Remove unused locals.
3603 (uniprop_table): Now static.
3604 * composite.c (_work_char): Remove unused static var.
3606 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3608 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3610 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3612 * gtkutil.c (qttip_cb): Remove code without function.
3614 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3616 * w32.c (pthread_sigmask): New stub.
3618 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3620 Use pthread_sigmask, not sigprocmask (Bug#9010).
3621 sigprocmask is portable only for single-threaded applications, and
3622 Emacs can be multi-threaded when it uses GTK.
3623 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3625 * callproc.c (Fcall_process):
3626 * process.c (create_process):
3627 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3628 Use pthread_sigmask, not sigprocmask.
3630 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3632 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3633 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3636 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3638 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3639 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3640 (xg_hide_tooltip): Fix comment.
3642 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3643 in registerServicesMenuSendTypes.
3644 (validRequestorForSendType): Don't check ns_return_types.
3646 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3649 2011-07-08 Jason Rumney <jasonr@gnu.org>
3651 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3652 SH_SHOW for hidden windows (Bug#5482).
3654 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3655 frame struct members of non-existent frames (Bug#6284).
3657 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3659 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3660 variable firstTime not needed on OSX >= 10.6.
3661 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3662 >= 10.5. Use setKnobProportion, setDoubleValue.
3664 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3665 (MAC_OS_X_VERSION_10_5): Define if not defined.
3666 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3667 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3668 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3670 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3671 cString and lossyCString on OSX >= 10.4
3673 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3674 sizeToFit on OSX >= 10.2.
3676 * nsimage.m (allocInitFromFile): Don't use deprecated method
3677 bestRepresentationForDevice on OSX >= 10.6.
3679 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3682 * emacs.c: Declare unexec_init_emacs_zone.
3684 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3686 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3688 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3689 on svcsMenu (Bug#8842).
3691 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3693 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3695 * nsterm.m (QUTF8_STRING): Declare.
3696 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3697 (validRequestorForSendType): Return type is (id).
3698 Change indexOfObjectIdenticalTo to indexOfObject.
3699 Check if we have local selection before returning self (Bug#8842).
3700 (writeSelectionToPasteboard): Put local selection into paste board
3701 if we have a local selection (Bug#8842).
3702 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3704 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3705 (ns_get_local_selection): Declare.
3707 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3709 * keymap.c (describe_map_tree): Don't insert a double newline at
3710 the end of the buffer (bug#1169) and return whether we inserted
3713 * callint.c (Fcall_interactively): Change "reading args" to
3714 "providing args" to try to clarify what it does (bug#1010).
3716 2011-07-07 Kenichi Handa <handa@m17n.org>
3718 * composite.c (composition_compute_stop_pos): Ignore a static
3719 composition starting before CHARPOS (Bug#8915).
3721 * xdisp.c (handle_composition_prop): Likewise.
3723 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3725 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3728 2011-07-07 Kenichi Handa <handa@m17n.org>
3730 * character.h (unicode_category_t): New enum type.
3732 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3733 (Qchar_code_property_table): New variable.
3734 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3735 (UNIPROP_COMPRESSED_FORM_P): New macros.
3736 (char_table_ascii): Uncompress the compressed values.
3737 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3738 Uncompress the compressed values.
3739 (sub_char_table_ref_and_range): Likewise.
3740 (char_table_ref_and_range): Uncompress the compressed values.
3741 (sub_char_table_set): New arg is_uniprop. Callers changed.
3742 Uncompress the compressed values.
3743 (sub_char_table_set_range): Args changed. Callers changed.
3744 (char_table_set_range): Adjuted for the above change.
3745 (map_sub_char_table): Delete args default_val and parent. Add arg
3746 top. Give decoded values to a Lisp function.
3747 (map_char_table): Adjust for the above change. Give decoded
3748 values to a Lisp function. Gcpro more variables.
3749 (uniprop_table_uncompress)
3750 (uniprop_decode_value_run_length): New functions.
3751 (uniprop_decoder, uniprop_decoder_count): New variables.
3752 (uniprop_get_decoder, uniprop_encode_value_character)
3753 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3755 (uniprop_encoder, uniprop_encoder_count): New variables.
3756 (uniprop_get_encoder, uniprop_table)
3757 (Funicode_property_table_internal, Fget_unicode_property_internal)
3758 (Fput_unicode_property_internal): New functions.
3759 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3760 Sunicode_property_table_internal, Sget_unicode_property_internal,
3761 and Sput_unicode_property_internal. Defvar_lisp
3762 char-code-property-alist.
3764 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3765 Vunicode_category_table.
3767 * font.c (font_range): Adjust for the change of
3768 Vunicode_category_table.
3770 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3772 * m/iris4d.h: Remove file, move contents ...
3773 * s/irix6-5.h: ... here.
3775 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3777 Remove unportable assumption about struct layout (Bug#8884).
3778 * alloc.c (mark_buffer):
3779 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3780 (clone_per_buffer_values): Don't assume that
3781 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3782 This isn't true in general, and it's particularly not true
3783 if Emacs is configured with --with-wide-int.
3784 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3785 New macros, used in the buffer.c change.
3787 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3789 * xsettings.c: Use both GConf and GSettings if both are available.
3790 (store_config_changed_event): Add comment.
3791 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3792 (store_tool_bar_style_changed): New functions.
3793 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3794 (struct xsettings): Move font inside HAVE_XFT.
3795 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3796 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3797 Move inside HAVE_XFT.
3798 (something_changed_gsettingsCB): Rename from something_changedCB.
3799 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3801 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3802 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3803 (something_changed_gconfCB): Rename from something_changedCB.
3804 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3805 (parse_settings): Move check for font inside HAVE_XFT.
3806 (read_settings, apply_xft_settings): Add comment.
3807 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3808 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3809 call store_font_name_changed.
3810 (xft_settings_event): Add comment.
3811 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3812 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3813 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3814 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3815 (xsettings_initialize): Call init_gsettings last.
3816 (xsettings_get_system_font, xsettings_get_system_normal_font):
3819 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3821 Random fixes. E.g., (random) never returned negative values.
3822 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3823 subseconds part to the entropy, as that's a bit more random.
3824 Prefer signed to unsigned, since the signedness doesn't matter and
3825 in general we prefer signed. When given a limit, use a
3826 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3827 latter isn't right if USE_2_TAGS_FOR_INTS.
3828 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3829 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3831 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3833 * textprop.c (text_property_stickiness):
3834 Obey Vtext_property_default_nonsticky.
3835 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3836 * w32fns.c (syms_of_w32fns):
3837 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3839 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3841 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3842 This is more efficient than Ffile_directory_p and avoids a minor race.
3844 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3846 * buffer.c (Foverlay_put): Say what the return value is
3849 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3850 is a directory before asking whether to use the file name
3852 (barf_or_query_if_file_exists): Make the "File is a directory"
3853 error be more correct.
3855 * fns.c (Frequire): Remove the mention of the .gz files, since
3856 that's installation-specific, but keep the mention of
3857 `get-load-suffixes'.
3859 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3861 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3862 Report string overflow if the output is too long.
3864 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3866 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3867 (syms_of_gnutls): Remove duplicate DEFSYM for
3868 Qgnutls_bootprop_verify_hostname_error, an error for
3869 Qgnutls_bootprop_verify_error (which is no longer used).
3871 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3872 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3873 Also (re)move comments that are misplaced or no longer relevant.
3875 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3877 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3879 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3881 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3882 and background color parameters if they have been changed.
3884 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3886 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3888 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3890 * xsettings.c (SYSTEM_FONT): Define only when used.
3891 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3893 * keymap.c (access_keymap_1): Now static.
3895 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3897 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3898 leave any prefix arg for the up event (Bug#1586).
3900 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3902 * lread.c (syms_of_lread): Mention single symbols defined by
3903 `defvar' or `defconst' (bug#7154).
3905 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3906 (Frequire): Mention get-load-suffixes.
3908 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3910 * window.h (window): Remove clone_number slot.
3911 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3913 (make_parent_window, make_window, saved_window)
3914 (Fset_window_configuration, save_window_save): Don't deal with
3916 * buffer.c (Qclone_number): Remove declaration.
3917 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3919 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3921 Add multiple inheritance to keymaps.
3922 * keymap.c (Fmake_composed_keymap): New function.
3923 (Fset_keymap_parent): Simplify.
3924 (fix_submap_inheritance): Remove.
3925 (access_keymap_1): New function extracted from access_keymap to handle
3926 embedded parents and handle lists of maps.
3927 (access_keymap): Use it.
3928 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3929 (Fcopy_keymap): Handle embedded parents.
3930 (Fcommand_remapping, define_as_prefix): Simplify.
3931 (Fkey_binding): Simplify.
3932 (syms_of_keymap): Move minibuffer-local-completion-map,
3933 minibuffer-local-filename-completion-map,
3934 minibuffer-local-must-match-map, and
3935 minibuffer-local-filename-must-match-map to Elisp.
3936 (syms_of_keymap): Defsubr make-composed-keymap.
3937 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3938 (parse_menu_item): Trivial simplification.
3940 2011-07-01 Glenn Morris <rgm@gnu.org>
3942 * Makefile.in (SETTINGS_LIBS): Fix typo.
3944 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3946 * coding.c (Fencode_coding_string): Record the last coding system
3947 used, as the function doc string says (bug#8738).
3949 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3951 * xsettings.c (store_monospaced_changed): Take new font as arg and
3952 check for change against current_mono_font.
3953 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3954 (emacs_settings_constructor, emacs_settings_get_property)
3955 (emacs_settings_set_property, emacs_settings_class_init)
3956 (emacs_settings_init, gsettings_obj): Remove.
3957 (something_changedCB): New function for HAVE_GSETTINGS.
3958 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3959 with value as argument.
3960 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3961 g_settings_new (Bug#8967). Do not create gsettings_obj.
3962 Remove calls to g_settings_bind. Connect something_changedCB to
3965 * xgselect.c: Add defined (HAVE_GSETTINGS).
3966 (xgselect_initialize): Ditto.
3968 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3969 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3972 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3974 * eval.c (struct backtrace): Simplify and port the data structure.
3975 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3976 signed bit field, as this assumption is not portable and it makes
3977 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3978 "char debug_on_exit : 1" as this is not portable either; instead,
3979 use the portable "unsigned int debug_on_exit : 1". Remove unused
3980 member evalargs. Remove obsolete comments about cc bombing out.
3982 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3984 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3985 Let HAVE_GSETTINGS override HAVE_GCONF.
3986 (store_monospaced_changed): New function.
3987 (EMACS_SETTINGS): A new type derived from GObject to handle
3988 GSettings notifications.
3989 (emacs_settings_constructor, emacs_settings_get_property)
3990 (emacs_settings_set_property, emacs_settings_class_init):
3992 (gsettings_client, gsettings_obj): New variables.
3993 (GSETTINGS_SCHEMA): New define.
3994 (something_changedCB): Call store_monospaced_changed.
3995 (init_gsettings): New function.
3996 (xsettings_initialize): Call init_gsettings.
3997 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4000 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4003 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4005 * window.c (resize_root_window, grow_mini_window)
4006 (shrink_mini_window): Rename Qresize_root_window to
4007 Qwindow_resize_root_window and Qresize_root_window_vertically to
4008 Qwindow_resize_root_window_vertically.
4010 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4012 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4014 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4016 * makefile.w32-in: Redesign dependencies so they reflect more
4017 clearly which files are directly included by each source file,
4018 and not through other includes.
4020 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4022 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4023 (sort_overlays, overlay_strings): When an overlay's clone number
4024 matches the window's clone number process the overlay even if
4025 the overlay's window property doesn't match the current window.
4027 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4028 (Fwindow_hchild): Rename to Fwindow_left_child.
4029 (Fwindow_next): Rename to Fwindow_next_sibling.
4030 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4031 (resize_window_check): Rename to window_resize_check.
4032 (resize_window_apply): Rename to window_resize_apply.
4033 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4034 (Fdelete_other_windows_internal, resize_frame_windows)
4035 (Fsplit_window_internal, Fdelete_window_internal)
4036 (grow_mini_window, shrink_mini_window)
4037 (Fresize_mini_window_internal): Fix callers accordingly.
4039 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4041 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4042 (emacs_fixed_set_min_size): Remove.
4043 (emacs_fixed_new): Take frame as argument.
4045 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4046 (_EmacsFixedPrivate): Remove minwidth/height.
4047 Add struct frame *f.
4048 (emacs_fixed_init): Initialize priv->f.
4049 (get_parent_class, emacs_fixed_set_min_size): Remove.
4050 (emacs_fixed_new): Set priv->f to argument.
4051 (emacs_fixed_get_preferred_width)
4052 (emacs_fixed_get_preferred_height): Use min_width/height from
4053 frames size_hint to set minimum and natural (Bug#8919).
4054 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4055 and use min_width/height from frames size_hint to set
4056 min_width/height (Bug#8919).
4058 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4059 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4062 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4064 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4065 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4068 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4070 * process.c (wait_reading_process_output): Bypass select if
4071 waiting for a cell while ignoring keyboard input, and input is
4072 pending. Suggested by Jan Djärv (Bug#8869).
4074 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4076 Use gnulib's dup2 module instead of rolling our own.
4077 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4079 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4081 * dispnew.c (scrolling_window): Before scrolling, turn off a
4082 mouse-highlight in the window being scrolled.
4084 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4086 Move DEFSYM to lisp.h and use everywhere.
4088 * character.h (DEFSYM): Move declaration...
4089 * lisp.h (DEFSYM): ...here.
4095 * w32select.c: Don't include character.h.
4097 * alloc.c (syms_of_alloc):
4098 * buffer.c (syms_of_buffer):
4099 * bytecode.c (syms_of_bytecode):
4100 * callint.c (syms_of_callint):
4101 * casefiddle.c (syms_of_casefiddle):
4102 * casetab.c (init_casetab_once):
4103 * category.c (init_category_once, syms_of_category):
4104 * ccl.c (syms_of_ccl):
4105 * cmds.c (syms_of_cmds):
4106 * composite.c (syms_of_composite):
4107 * dbusbind.c (syms_of_dbusbind):
4108 * dired.c (syms_of_dired):
4109 * dispnew.c (syms_of_display):
4110 * doc.c (syms_of_doc):
4111 * editfns.c (syms_of_editfns):
4112 * emacs.c (syms_of_emacs):
4113 * eval.c (syms_of_eval):
4114 * fileio.c (syms_of_fileio):
4115 * fns.c (syms_of_fns):
4116 * frame.c (syms_of_frame):
4117 * fringe.c (syms_of_fringe):
4118 * insdel.c (syms_of_insdel):
4119 * keymap.c (syms_of_keymap):
4120 * lread.c (init_obarray, syms_of_lread):
4121 * macros.c (syms_of_macros):
4122 * msdos.c (syms_of_msdos):
4123 * print.c (syms_of_print):
4124 * process.c (syms_of_process):
4125 * search.c (syms_of_search):
4126 * sound.c (syms_of_sound):
4127 * syntax.c (init_syntax_once, syms_of_syntax):
4128 * terminal.c (syms_of_terminal):
4129 * textprop.c (syms_of_textprop):
4130 * undo.c (syms_of_undo):
4131 * w32.c (globals_of_w32):
4132 * window.c (syms_of_window):
4133 * xdisp.c (syms_of_xdisp):
4134 * xfaces.c (syms_of_xfaces):
4135 * xfns.c (syms_of_xfns):
4136 * xmenu.c (syms_of_xmenu):
4137 * xsettings.c (syms_of_xsettings):
4138 * xterm.c (syms_of_xterm): Use DEFSYM.
4140 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4142 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4144 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4146 Integer and buffer overflow fixes (Bug#8873).
4148 * print.c (printchar, strout): Check for string overflow.
4149 (PRINTPREPARE, printchar, strout):
4150 Don't set size unless allocation succeeds.
4152 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4153 for sizes. Check for string overflow more accurately.
4154 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4156 * macros.c: Integer and buffer overflow fixes.
4157 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4158 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4159 Use ptrdiff_t, not int, for sizes.
4160 Don't increment bufsize until after realloc succeeds.
4161 Check for size-calculation overflow.
4162 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4164 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4166 * lread.c: Integer overflow fixes.
4167 (read_integer): Radix is now EMACS_INT, not int,
4168 to improve quality of diagnostics for out-of-range radices.
4169 Calculate buffer size correctly for out-of-range radices.
4170 (read1): Check for integer overflow in radices, and in
4171 read-circle numbers.
4172 (read_escape): Avoid int overflow.
4173 (Fload, openp, read_buffer_size, read1)
4174 (substitute_object_recurse, read_vector, read_list, map_obarray):
4175 Use ptrdiff_t, not int, for sizes.
4176 (read1): Use EMACS_INT, not int, for sizes.
4177 Check for size overflow.
4179 * image.c (cache_image): Check for size arithmetic overflow.
4181 * lread.c: Integer overflow issues.
4182 (saved_doc_string_size, saved_doc_string_length)
4183 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4184 Now ptrdiff_t, not int.
4185 (read1): Don't assume doc string length fits in int. Check for
4186 out-of-range doc string lengths.
4187 (read_list): Don't assume file position fits in int.
4188 (read_escape): Check for hex character overflow.
4190 2011-06-22 Leo Liu <sdl.web@gmail.com>
4192 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4193 Move to minibuffer.el.
4195 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4197 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4198 The following patches are for when GLYPH_DEBUG && !XASSERT.
4199 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4200 * dispnew.c (flush_stdout):
4201 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4202 Mark as externally visible.
4203 * dispnew.c (check_window_matrix_pointers): Now static.
4204 * dispnew.c (window_to_frame_vpos):
4205 * xfns.c (unwind_create_frame):
4206 * xterm.c (x_check_font): Remove unused local.
4207 * scroll.c (CHECK_BOUNDS):
4208 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4209 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4210 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4211 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4212 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4214 (debug_method_add): Use va_list and vsprintf rather than relying
4215 on undefined behavior with wrong number of arguments.
4216 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4217 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4218 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4219 since we're not interested in debugging glyphs with old libraries.
4220 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4221 GCC 4.6.0's static checking.
4223 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4225 Integer overflow and signedness fixes (Bug#8873).
4226 A few related buffer overrun fixes, too.
4228 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4230 * dispextern.h (struct face.stipple):
4231 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4232 (x_bitmap_mask, x_allocate_bitmap_record)
4233 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4234 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4235 (x_create_bitmap_from_xpm_data):
4236 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4237 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4239 * xfaces.c (load_pixmap):
4240 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4241 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4242 (.bitmaps_last, struct x_output.icon_bitmap):
4243 Use ptrdiff_t, not int, for bitmap indexes.
4244 (x_allocate_bitmap_record): Check for size overflow.
4245 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4247 Use ptrdiff_t, not int, for overlay counts.
4248 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4249 * editfns.c (overlays_around, get_pos_property):
4250 * textprop.c (get_char_property_and_overlay):
4251 * xdisp.c (next_overlay_change, note_mouse_highlight):
4252 * xfaces.c (face_at_buffer_position):
4253 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4254 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4255 (Fnext_overlay_change, Fprevious_overlay_change)
4256 (mouse_face_overlay_overlaps, Foverlays_in):
4257 Use ptrdiff_t, not int, for sizes.
4258 (overlays_at, overlays_in): Check for size-calculation overflow.
4260 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4262 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4263 (x_session_initialize): Do not assume string length fits in int.
4265 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4266 This is unlikely, but can occur if DPI is outlandish.
4268 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4269 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4271 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4272 * xrdb.c (magic_file_p, search_magic_path):
4273 Omit last arg SUFFIX; it was always 0. All callers changed.
4274 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4276 * xfont.c (xfont_match): Avoid need for strlen.
4278 * xfns.c: Don't assume strlen fits in int.
4279 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4281 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4282 not unsigned long, as we prefer signed integers. All callers changed.
4283 Detect integer overflow in repeat count.
4284 (message_dolog): Don't assume print length fits in 39 bytes.
4285 (display_mode_element): Don't assume strlen fits in int.
4287 * termcap.c: Don't assume sizes fit in int and never overflow.
4288 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4289 (gobble_line): Check for size-calculation overflow.
4291 * minibuf.c (Fread_buffer):
4292 * lread.c (intern, intern_c_string):
4293 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4294 Don't assume string length fits in int.
4296 * keyboard.c (parse_tool_bar_item):
4297 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4299 * font.c: Don't assume string length fits in int.
4300 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4301 Use ptrdiff_t, not int.
4302 (font_intern_prop): Don't assume string length fits in int.
4303 Don't assume integer property fits in fixnum.
4304 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4306 * filelock.c: Fix some buffer overrun and integer overflow issues.
4307 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4308 Reformulate so as not to need the command string.
4309 Invoke gzip -cd rather than gunzip, as it's more portable.
4310 (lock_info_type, lock_file_1, lock_file):
4311 Don't assume pid_t and time_t fit in unsigned long.
4312 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4313 (current_lock_owner): Prefer signed type for sizes.
4314 Use memcpy, not strncpy, where memcpy is what is really wanted.
4315 Don't assume (via atoi) that time_t and pid_t fit in int.
4316 Check for time_t and/or pid_t out of range, e.g., via a network share.
4317 Don't alloca where an auto var works fine.
4319 * fileio.c: Fix some integer overflow issues.
4320 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4321 Don't assume string length fits in int.
4322 (directory_file_name): Don't assume string length fits in long.
4323 (make_temp_name): Don't assume pid fits in int, or that its print
4324 length is less than 20.
4326 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4328 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4330 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4332 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4333 We prefer signed integers, even for size calculations.
4335 * emacs.c: Don't assume string length fits in 'int'.
4336 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4337 (main): Don't invoke strlen when not needed.
4339 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4340 (XD_DEBUG_MESSAGE): Don't waste a byte.
4342 * callproc.c (getenv_internal_1, getenv_internal)
4344 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4346 * lread.c (invalid_syntax): Omit length argument.
4347 All uses changed. This doesn't fix a bug, but it simplifies the
4348 code away from its former Hollerith-constant appearance, and it's
4349 one less 'int' to worry about when looking at integer-overflow issues.
4350 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4352 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4353 This didn't break anything, but it didn't help either.
4354 It's confusing to put a bogus integer in a place where the actual
4355 value does not matter.
4356 (LIST_END_P): Remove unused macro and its bogus comment.
4357 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4359 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4360 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4362 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4363 We prefer signed types, and the value cannot exceed the EMACS_INT
4364 range anyway (because otherwise the length would not be representable).
4365 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4366 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4367 This avoids a GCC warning when WIDE_EMACS_INT.
4369 * indent.c (sane_tab_width): New function.
4370 (current_column, scan_for_column, Findent_to, position_indentation)
4371 (compute_motion): Use it. This is just for clarity.
4372 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4374 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4376 * lisp.h (lint_assume): New macro.
4377 * composite.c (composition_gstring_put_cache):
4378 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4380 * editfns.c, insdel.c:
4381 Omit unnecessary forward decls, to simplify future changes.
4383 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4385 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4387 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4388 Use much-faster test for byte-length change.
4389 Don't assume string byte-length fits in 'int'.
4390 Check that character arg fits in 'int'.
4391 (mapcar1): Declare byte as byte, for clarity.
4393 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4395 * fns.c (concat): Catch string overflow earlier.
4396 Do not rely on integer wraparound.
4398 * dispextern.h (struct it.overlay_strings_charpos)
4399 (struct it.selective): Now EMACS_INT, not int.
4400 * xdisp.c (forward_to_next_line_start)
4401 (back_to_previous_visible_line_start)
4402 (reseat_at_next_visible_line_start, next_element_from_buffer):
4403 Don't arbitrarily truncate the value of 'selective' to int.
4405 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4407 * composite.c: Don't truncate sizes to 'int'.
4408 (composition_gstring_p, composition_reseat_it)
4409 (composition_adjust_point): Use EMACS_INT, not int.
4410 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4411 not EMACS_UINT, for indexes.
4413 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4415 * buffer.c: Include <verify.h>.
4416 (struct sortvec.priority, struct sortstr.priority):
4417 Now EMACS_INT, not int.
4418 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4419 (struct sortstr.size, record_overlay_string)
4420 (struct sortstrlist.size, struct sortlist.used):
4421 Don't truncate size to int.
4422 (record_overlay_string): Check for size-calculation overflow.
4423 (init_buffer_once): Check at compile-time, not run-time.
4425 2011-06-22 Jim Meyering <meyering@redhat.com>
4427 Don't leak an XBM-image-sized buffer
4428 * image.c (xbm_load): Free the image buffer after using it.
4430 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4433 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4434 that Sun C diagnosed.
4435 * fns.c (secure_hash): Fix pointer signedness issue.
4436 * intervals.c (static_offset_intervals): New function.
4437 (offset_intervals): Use it.
4439 2011-06-21 Leo Liu <sdl.web@gmail.com>
4442 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4445 * fns.c (secure_hash): Rename from crypto_hash_function and change
4446 the first arg to accept symbols.
4447 (Fsecure_hash): New primitive.
4448 (syms_of_fns): New symbols.
4450 2011-06-20 Deniz Dogan <deniz@dogan.se>
4452 * process.c (Fset_process_buffer): Clarify return value in
4455 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4457 * dispnew.c (add_window_display_history): Use BVAR.
4459 * xdisp.c (debug_method_add): Use BVAR.
4460 (check_window_end, dump_glyph_matrix, dump_glyph)
4461 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4463 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4466 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4467 check till after the cache is created in init_frame_faces.
4469 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4471 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4473 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4475 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4476 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4477 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4479 Improve buffer-overflow checking (Bug#8873).
4480 * fileio.c (Finsert_file_contents):
4481 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4482 Remove the old (too-loose) buffer overflow checks.
4483 They weren't needed, since make_gap checks for buffer overflow.
4484 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4485 The old code merely checked for Emacs fixnum overflow, and relied
4486 on undefined (wraparound) behavior. The new code avoids undefined
4487 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4489 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4490 Tune. Don't use wider integers than needed. Don't use alloca.
4491 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4493 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4495 * insdel.c, lisp.h (buffer_overflow): New function.
4496 (insert_from_buffer_1, replace_range, replace_range_2):
4497 * insdel.c (make_gap_larger):
4498 * editfns.c (Finsert_char):
4499 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4501 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4503 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4505 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4507 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4508 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4510 * fileio.c: Don't assume EMACS_INT fits in off_t.
4511 (emacs_lseek): New static function.
4512 (Finsert_file_contents, Fwrite_region): Use it.
4513 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4515 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4517 * fns.c: Don't overflow int when computing a list length.
4518 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4519 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4520 truncation on 64-bit hosts. Check for QUIT every
4521 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4522 faster and is responsive enough.
4523 (Flength): Report an error instead of overflowing an integer.
4524 (Fsafe_length): Return a float if the value is not representable
4525 as a fixnum. This shouldn't happen except in contrived situations.
4526 (Fnthcdr, Fsort): Don't assume list length fits in int.
4527 (Fcopy_sequence): Don't assume vector length fits in int.
4529 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4530 (header_size, word_size): New constants.
4531 (allocate_vectorlike): Don't check size overflow here.
4532 (allocate_vector): Check it here instead, since this is the only
4533 caller of allocate_vectorlike that could cause overflow.
4534 Check that the new vector's length is representable as a fixnum.
4536 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4537 The previous code was bogus. For example, next_almost_prime (32)
4538 returned 39, which is undesirable as it is a multiple of 3; and
4539 next_almost_prime (24) returned 25, which is a multiple of 5 so
4540 why was the code bothering to check for multiples of 7?
4542 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4544 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4546 Variadic C functions now count arguments with ptrdiff_t.
4547 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4548 Back then I didn't know that the Emacs coding style prefers signed int.
4549 Also, in the meantime I found a few more instances where arguments
4550 were being counted with int, which may truncate counts on 64-bit
4551 machines, or EMACS_INT, which may be unnecessarily wide.
4552 * lisp.h (struct Lisp_Subr.function.aMANY)
4553 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4554 Arg counts are now ptrdiff_t, not size_t.
4555 All variadic functions and their callers changed accordingly.
4556 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4557 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4558 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4559 * callint.c (Fcall_interactively): Check arg count for overflow,
4560 to avoid potential buffer overrun. Use signed char, not 'int',
4561 for 'varies' array, so that we needn't bother to check its size
4562 calculation for overflow.
4563 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4564 * eval.c (apply_lambda):
4565 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4566 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4567 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4569 * callint.c (Fcall_interactively): Don't use index var as event count.
4571 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4572 * mem-limits.h (SIZE): Remove; no longer used.
4574 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4576 Remove unnecessary casts.
4577 * xterm.c (x_term_init):
4578 * xfns.c (x_set_border_pixel):
4579 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4580 These aren't needed now that we assume ANSI C.
4582 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4583 It's more likely to cause problems (due to unsigned overflow)
4586 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4588 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4590 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4592 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4594 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4596 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4598 GLYPH_CODE_FACE returns EMACS_INT, not int.
4599 * dispextern.h (merge_faces):
4600 * xfaces.c (merge_faces):
4601 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4602 Don't assume EMACS_INT fits in int.
4604 * character.h (CHAR_VALID_P): Remove unused parameter.
4605 * fontset.c, lisp.h, xdisp.c: All uses changed.
4607 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4609 * fns.c (concat): Minor tuning based on overflow analysis.
4610 This doesn't fix any bugs. Use int to hold character, instead
4611 of constantly refetching from Emacs object. Use XFASTINT, not
4612 XINT, for value known to be a character. Don't bother comparing
4613 a single byte to 0400, as it's always less.
4615 * floatfns.c (Fexpt):
4616 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4618 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4621 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4623 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4624 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4625 incorrectly succeed when S was a string, because 4294967386 was
4626 truncated before it was used.
4628 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4629 Otherwise, an out-of-range integer could cause undefined behavior
4632 * composite.c: Use int, not EMACS_INT, for characters.
4633 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4634 EMACS_INT, for values that are known to be in character range.
4635 This doesn't fix any bugs but is the usual style inside Emacs and
4636 may generate better code on 32-bit machines.
4638 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4639 This is for reasons similar to the recent CHAR_STRING fix.
4640 * charset.c (Fencode_char): Check that character arg is actually
4641 a character. Pass an int to ENCODE_CHAR.
4642 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4643 wider than 'int', as a compile-time check to prevent future regressions
4646 * character.c (char_string): Remove unnecessary casts.
4648 Make sure a 64-bit char is never passed to CHAR_STRING.
4649 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4650 by silently ignoring the top 32 bits, allowing some values
4651 that were far too large to be valid characters.
4652 * character.h: Include <verify.h>.
4653 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4654 arguments are no wider than unsigned, as a compile-time check
4655 to prevent future regressions in this area.
4657 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4658 (Fsubst_char_in_region):
4660 * xdisp.c (decode_mode_spec_coding):
4661 Adjust to CHAR_STRING's new requirement.
4662 * editfns.c (Finsert_char, Fsubst_char_in_region):
4663 * fns.c (concat): Check that character args are actually
4664 characters. Without this test, these functions did the wrong
4665 thing with wildly out-of-range values on 64-bit hosts.
4667 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4668 These casts should not be needed on 32-bit hosts, either.
4669 * keyboard.c (read_char):
4670 * lread.c (Fload): Remove casts to unsigned.
4672 * lisp.h (UNSIGNED_CMP): New macro.
4673 This fixes comparison bugs on 64-bit hosts.
4674 (ASCII_CHAR_P): Use it.
4675 * casefiddle.c (casify_object):
4676 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4677 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4678 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4679 * dispextern.h (FACE_FROM_ID):
4680 * keyboard.c (read_char): Use UNSIGNED_CMP.
4682 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4683 not to EMACS_INT, to avoid GCC warning.
4685 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4687 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4688 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4689 isn't needed on 32-bit machines.
4691 * buffer.c (Fgenerate_new_buffer_name):
4692 Use EMACS_INT for count, not int.
4693 (advance_to_char_boundary): Return EMACS_INT, not int.
4695 * data.c (Qcompiled_function): Now static.
4697 * window.c (window_body_lines): Now static.
4699 * image.c (gif_load): Rename local to avoid shadowing.
4701 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4702 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4703 * alloc.c (make_save_value): Integer argument is now of type
4705 (mark_object): Use ptrdiff_t, not int.
4706 * lisp.h (pD): New macro.
4707 * print.c (print_object): Use it.
4709 * alloc.c: Use EMACS_INT, not int, to count objects.
4710 (total_conses, total_markers, total_symbols, total_vector_size)
4711 (total_free_conses, total_free_markers, total_free_symbols)
4712 (total_free_floats, total_floats, total_free_intervals)
4713 (total_intervals, total_strings, total_free_strings):
4714 Now EMACS_INT, not int. All uses changed.
4715 (Fgarbage_collect): Compute overall total using a double, so that
4716 integer overflow is less likely to be a problem. Check for overflow
4717 when converting back to an integer.
4718 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4719 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4720 These were 'int' variables that could overflow on 64-bit hosts;
4721 they were never used, so remove them instead of repairing them.
4722 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4723 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4724 Previously, this ceilinged at INT_MAX, but that doesn't work on
4726 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4728 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4729 (allocate_vectorlike): Check for ptrdiff_t overflow.
4730 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4731 when a (possibly-narrower) signed value would do just as well.
4732 We prefer using signed arithmetic, to avoid comparison confusion.
4734 * alloc.c: Catch some string size overflows that we were missing.
4735 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4736 for convenience in STRING_BYTES_MAX.
4737 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4738 The definition here is exact; the one in lisp.h was approximate.
4739 (allocate_string_data): Check for string overflow. This catches
4740 some instances we weren't catching before. Also, it catches
4741 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4742 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4743 and ptrdiff_t and EMACS_INT are both 64 bits.
4745 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4746 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4747 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4749 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4751 * alloc.c (Fmake_string): Check for out-of-range init.
4753 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4755 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4757 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4759 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4760 xg_get_default_scrollbar_width.
4762 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4763 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4764 (style_changed_cb): Call update_theme_scrollbar_width and call
4765 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4766 all frames (Bug#8505).
4767 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4768 Call gtk_window_set_resizable if HAVE_GTK3.
4769 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4770 and height if HAVE_GTK3 (Bug#8505).
4771 (scroll_bar_width_for_theme): New variable.
4772 (update_theme_scrollbar_width): New function.
4773 (xg_get_default_scrollbar_width): Move code to
4774 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4775 (xg_initialize): Call update_theme_scrollbar_width.
4777 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4779 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4781 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4783 * frame.c (make_frame): Call other_buffer_safely instead of
4786 * window.c (temp_output_buffer_show): Call display_buffer with
4787 second argument Vtemp_buffer_show_specifiers and reset latter
4788 immediately after the call.
4789 (Vtemp_buffer_show_specifiers): New variable.
4790 (auto_window_vscroll_p, next_screen_context_lines)
4791 (Vscroll_preserve_screen_position): Remove leading asterisks from
4794 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4796 Fix minor problems found by GCC 4.6.0 static checking.
4797 * buffer.c (Qclone_number): Remove for now, as it's unused.
4798 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4799 (record_buffer): Remove unused local.
4800 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4801 (set_frame_buffer_list): Remove; unused.
4802 * frame.h (other_visible_frames): Remove decl.
4803 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4804 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4805 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4807 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4808 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4809 Define only if HAVE_GPM.
4810 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4811 (update_hints_inhibit): Remove; never set. All uses removed.
4812 * widgetprv.h (emacsFrameClassRec): Remove decl.
4813 * window.c (delete_deletable_window): Now returns void, since it
4814 wasn't returning anything.
4815 (compare_window_configurations): Remove unused locals.
4816 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4817 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4818 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4819 the same widths as pointers. This follows up on the 2011-05-06 patch.
4820 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4821 * xterm.h: Likewise.
4822 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4824 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4826 * makefile.w32-in: Update dependencies.
4827 (LISP_H): Add lib/intprops.h.
4829 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4831 * image.c (gif_load): Add animation frame delay to the metadata.
4832 (syms_of_image): Use DEFSYM. New symbol `delay'.
4834 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4836 * window.c (delete_deletable_window): Re-add.
4837 (Fset_window_configuration): Rewrite to handle dead buffers and
4838 consequently deletable windows.
4839 (window_tree, Fwindow_tree): Remove. Supply functionality in
4841 (compare_window_configurations): Simplify code.
4843 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4845 * image.c (imagemagick_load_image): Fix type mismatch.
4846 (Fimagemagick_types): Likewise.
4848 * window.h (replace_buffer_in_windows): Declare.
4850 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4852 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4853 Qclone_number. Remove external declaration of Qdelete_window.
4854 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4856 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4857 Run Qbuffer_list_update_hook if allowed.
4858 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4859 buffer list implementation.
4860 (other_buffer_safely): New function.
4861 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4862 calls to replace_buffer_in_windows and
4863 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4865 (record_buffer): Inhibit quitting and rewrite using quittable
4866 functions. Run Qbuffer_list_update_hook if allowed.
4867 (Frecord_buffer, Funrecord_buffer): New functions.
4868 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4869 Move switch-to-buffer to window.el.
4870 (bury-buffer): Move to window.el.
4871 (Vbuffer_list_update_hook): New variable.
4873 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4876 * window.h (resize_frame_windows): Move up in code.
4877 (Fwindow_frame): Remove EXFUN.
4878 (replace_buffer_in_all_windows): Remove prototype.
4879 (replace_buffer_in_windows_safely): Add prototype.
4881 * window.c: Declare Qdelete_window static again. Move down
4882 declaration of select_count.
4883 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4884 (Fother_window): Move to window.el.
4885 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4886 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4887 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4889 (replace_buffer_in_windows): Implement by calling
4890 Qreplace_buffer_in_windows.
4891 (replace_buffer_in_all_windows): Remove with some functionality
4892 moved into replace_buffer_in_windows_safely.
4893 (replace_buffer_in_windows_safely): New function.
4894 (select_window_norecord, select_frame_norecord): Move in front
4895 of run_window_configuration_change_hook. Remove now obsolete
4897 (Fset_window_buffer): Rewrite doc-string.
4898 Call Qrecord_window_buffer.
4899 (keys_of_window): Move binding for other-window to window.el.
4901 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4903 * dispextern.h (struct image): Replace data member, whose int_val
4904 and ptr_val fields were not used by anything, with a single
4907 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4908 (gif_clear_image, gif_load, imagemagick_load_image)
4909 (gs_clear_image, gs_load): Callers changed.
4911 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4913 * buffer.h: Include <time.h>, for time_t.
4914 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4916 Fix minor problems found by static checking.
4918 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4920 Make identifiers static if they are not used in other modules.
4921 * data.c (Qcompiled_function, Qframe, Qvector):
4922 * image.c (QimageMagick, Qsvg):
4923 * minibuf.c (Qmetadata):
4924 * window.c (resize_window_check, resize_root_window): Now static.
4925 * window.h (resize_window_check, resize_root_window): Remove decls.
4927 * window.c (window_deletion_count, delete_deletable_window):
4929 (window_body_lines): Now static.
4930 (Fdelete_other_windows_internal): Mark vars as initialized.
4931 Make sure 'resize_failed' is initialized.
4932 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4933 (resize_window_apply): Remove unused local.
4934 * window.h (delete_deletable_window): Remove decl.
4936 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4937 (imagemagick_load_image): Fix pointer signedness problem by changing
4938 last arg from unsigned char * to char *. All uses changed.
4939 Also, fix a local for similar reasons.
4940 Remove unused locals. Remove locals to avoid shadowing.
4941 (fn_rsvg_handle_free): Remove; unused.
4942 (svg_load, svg_load_image): Fix pointer signedness problem.
4943 (imagemagick_load_image): Don't use garbage pointer image_wand.
4945 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4947 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4949 * image.c (gif_load): Fix omitted cast error introduced by
4952 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4954 * window.h (resize_proportionally, orig_total_lines)
4955 (orig_top_line): Remove from window structure.
4956 (set_window_height, set_window_width, change_window_heights)
4957 (Fdelete_window): Remove prototypes.
4958 (resize_frame_windows): Remove duplicate declaration.
4960 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4962 * window.h (resize_frame_windows, resize_window_check)
4963 (delete_deletable_window, resize_root_window)
4964 (resize_frame_windows): Declare prototypes.
4966 * window.c (resize_window_apply): Make definition be "static" to
4967 match the prototype.
4969 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4971 * window.c: Remove declarations of Qwindow_size_fixed,
4972 window_min_size_1, window_min_size_2, window_min_size,
4973 size_window, window_fixed_size_p, enlarge_window, delete_window.
4974 Remove static from declaration of Qdelete_window, it's
4975 temporarily needed by Fbury_buffer.
4976 (replace_window): Don't assign orig_top_line and
4978 (Fdelete_window, delete_window): Remove. Window deletion is
4979 handled by window.el.
4980 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4981 Replace Fdelete_window calls with calls to Qdelete_window.
4982 (Fdelete_other_windows): Remove. Deleting other windows is
4983 handled by window.el.
4984 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4985 handled in window.el.
4986 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4987 Window minimum sizes are handled in window.el.
4988 (shrink_windows, size_window, set_window_height)
4989 (set_window_width, change_window_heights, window_height)
4990 (window_width, CURBEG, CURSIZE, enlarge_window)
4991 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4992 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4993 handled in window.el.
4994 (make_dummy_parent): Rename to make_parent_window and give it a
4995 second argument horflag.
4996 (make_window): Don't set resize_proportionally any more.
4997 (Fsplit_window): Remove. Windows are split in window.el.
4998 (save_restore_action, save_restore_orig_size)
4999 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5000 Resize mini windows in window.el.
5001 (grow_mini_window, shrink_mini_window): Implement by calling
5002 Qresize_root_window_vertically, resize_window_check and
5003 resize_window_apply.
5004 (saved_window, Fset_window_configuration, save_window_save):
5005 Do not handle orig_top_line, orig_total_lines, and
5006 resize_proportionally.
5007 (window_min_height, window_min_width): Move to window.el.
5008 (keys_of_window): Move bindings for delete-other-windows,
5009 split-window, delete-window and enlarge-window to window.el.
5011 * buffer.c: Temporarily extern Qdelete_window.
5012 (Fbury_buffer): Temporarily call Qdelete_window instead of
5013 Fdelete_window (Fbury_buffer will move to window.el soon).
5015 * frame.c (set_menu_bar_lines_1): Remove code handling
5016 orig_top_line and orig_total_lines.
5018 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5019 set_window_height but set heights directly.
5020 (change_frame_size_1): Use resize_frame_windows.
5022 * xdisp.c (init_xdisp): Don't use set_window_height but set
5025 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5026 Use resize_frame_windows instead of change_window_heights and run
5027 run_window_configuration_change_hook.
5029 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5030 instead of change_window_heights and run
5031 run_window_configuration_change_hook.
5033 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5035 * window.c (replace_window): Rename second argument REPLACEMENT to
5036 NEW. New third argument SETFLAG. Rewrite.
5037 (delete_window, make_dummy_parent): Call replace_window with
5039 (window_list_1): Move down in code.
5040 (run_window_configuration_change_hook): Move set_buffer part
5041 before select_frame_norecord part in order to unwind correctly.
5042 Rename count1 to count.
5043 (recombine_windows, delete_deletable_window, resize_root_window)
5044 (Fdelete_other_windows_internal)
5045 (Frun_window_configuration_change_hook, make_parent_window)
5046 (resize_window_check, resize_window_apply, Fresize_window_apply)
5047 (resize_frame_windows, Fsplit_window_internal)
5048 (Fdelete_window_internal, Fresize_mini_window_internal):
5050 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5052 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5054 * window.h (window): Add some new members to window structure -
5055 normal_lines, normal_cols, new_total, new_normal, clone_number,
5056 splits, nest, prev_buffers, next_buffers.
5057 (WINDOW_TOTAL_SIZE): Move here from window.c.
5058 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5060 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5062 (make_dummy_parent): Set new members of windows structure.
5063 (make_window): Move down in code. Handle new members of window
5065 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5066 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5067 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5068 (Fset_window_prev_buffers, Fwindow_next_buffers)
5069 (Fset_window_next_buffers, Fset_window_clone_number):
5071 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5072 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5074 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5075 Argument WINDOW can be now internal window too.
5076 (Fwindow_use_time): Move up in code.
5077 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5079 (Fset_window_configuration, saved_window)
5080 (Fcurrent_window_configuration, save_window_save): Handle new
5081 members of window structure.
5082 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5083 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5084 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5085 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5086 Qget_mru_window, Qresize_root_window,
5087 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5088 Qauto_buffer_name; staticpro them.
5090 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5092 * window.c (Fwindow_total_size, Fwindow_left_column)
5093 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5094 (Fwindow_list_1): New functions.
5095 (window_box_text_cols): Replace with window_body_cols.
5096 (Fwindow_width, Fscroll_left, Fscroll_right):
5097 Use window_body_cols instead of window_box_text_cols.
5098 (delete_window, Fset_window_configuration):
5099 Call delete_all_subwindows with window as argument.
5100 (delete_all_subwindows): Take a window as argument and not a
5102 (window_loop): Remove handling of GET_LRU_WINDOW and
5104 (Fget_lru_window, Fget_largest_window): Move to window.el.
5106 * window.h: Extern window_body_cols instead of
5107 window_box_text_cols. delete_all_subwindows now takes a
5108 Lisp_Object as argument.
5110 * indent.c (compute_motion, Fcompute_motion):
5111 Use window_body_cols instead of window_box_text_cols.
5113 * frame.c (delete_frame): Call delete_all_subwindows with root
5116 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5118 * fns.c (Fputhash): Document return value.
5120 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5122 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5124 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5126 Cons<->int and similar integer overflow fixes (Bug#8794).
5128 Check for overflow when converting integer to cons and back.
5129 * charset.c (Fdefine_charset_internal, Fdecode_char):
5130 Use cons_to_unsigned to catch overflow.
5131 (Fencode_char): Use INTEGER_TO_CONS.
5132 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5133 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5134 * data.c (long_to_cons, cons_to_long): Remove.
5135 (cons_to_unsigned, cons_to_signed): New functions.
5136 These signal an error for invalid or out-of-range values.
5137 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5138 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5139 * font.c (Ffont_variation_glyphs):
5140 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5141 * lisp.h: Include <intprops.h>.
5142 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5143 (cons_to_signed, cons_to_unsigned): New decls.
5144 (long_to_cons, cons_to_long): Remove decls.
5145 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5146 (Fprimitive_undo): Use CONS_TO_INTEGER.
5147 * xfns.c (Fx_window_property): Likewise.
5148 * xselect.c: Include <limits.h>.
5149 (x_own_selection, selection_data_to_lisp_data):
5150 Use INTEGER_TO_CONS.
5151 (x_handle_selection_request, x_handle_selection_clear)
5152 (x_get_foreign_selection, Fx_disown_selection_internal)
5153 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5154 (lisp_data_to_selection_data): Use cons_to_unsigned.
5155 (x_fill_property_data): Use cons_to_signed.
5156 Report values out of range.
5158 Check for buffer and string overflow more precisely.
5159 * buffer.h (BUF_BYTES_MAX): New macro.
5160 * lisp.h (STRING_BYTES_MAX): New macro.
5161 * alloc.c (Fmake_string):
5162 * character.c (string_escape_byte8):
5163 * coding.c (coding_alloc_by_realloc):
5164 * doprnt.c (doprnt):
5165 * editfns.c (Fformat):
5167 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5168 since they may not be the same number.
5169 * editfns.c (Finsert_char):
5170 * fileio.c (Finsert_file_contents):
5171 Likewise for BUF_BYTES_MAX.
5173 * image.c: Use ptrdiff_t, not int, for sizes.
5174 (slurp_file): Switch from int to ptrdiff_t.
5176 (slurp_file): Check that file size fits in both size_t (for
5177 malloc) and ptrdiff_t (for sanity and safety).
5179 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5180 if b->modtime has its maximal value.
5182 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5184 Don't assume time_t can fit into int.
5185 * buffer.h (struct buffer.modtime): Now time_t, not int.
5186 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5187 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5189 Minor fixes for signed vs unsigned integers.
5190 * character.h (MAYBE_UNIFY_CHAR):
5191 * charset.c (maybe_unify_char):
5192 * keyboard.c (read_char, reorder_modifiers):
5193 XINT -> XFASTINT, since the integer must be nonnegative.
5194 * ftfont.c (ftfont_spec_pattern):
5195 * keymap.c (access_keymap, silly_event_symbol_error):
5196 XUINT -> XFASTINT, since the integer must be nonnegative.
5197 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5198 since it makes no difference and we prefer signed.
5199 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5200 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5203 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5205 * window.h (Fwindow_frame): Declare.
5207 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5209 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5210 (SPARE_MEMORY): Always define.
5211 (LARGE_REQUEST): Remove.
5212 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5214 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5216 * lisp.h: Move EXFUNS for Fframe_root_window,
5217 Fframe_first_window and Fset_frame_selected_window to window.h.
5219 * window.h: Move EXFUNS for Fframe_root_window,
5220 Fframe_first_window and Fset_frame_selected_window here from
5223 * frame.c (Fwindow_frame, Fframe_first_window)
5224 (Fframe_root_window, Fframe_selected_window)
5225 (Fset_frame_selected_window): Move to window.c.
5226 (Factive_minibuffer_window): Move to minibuf.c.
5227 (Fother_visible_frames_p): New function.
5229 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5231 * window.c (decode_window, decode_any_window): Move up in code.
5232 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5233 (inhibit_frame_unsplittable): Remove unused variable.
5234 (Fwindow_buffer): Move up and rewrite doc-string.
5235 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5236 (Fwindow_prev): New functions.
5237 (Fwindow_frame): Move here from frame.c. Accept any window as
5239 (Fframe_root_window, Fframe_first_window)
5240 (Fframe_selected_window): Move here from frame.c. Accept frame
5241 or arbitrary window as argument. Update doc-strings.
5242 (Fminibuffer_window): Move up in code.
5243 (Fwindow_minibuffer_p): Move up in code and simplify.
5244 (Fset_frame_selected_window): Move here from frame.c.
5246 (Fselected_window, select_window, Fselect_window): Move up in
5247 code. Minor doc-string fixes.
5249 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5251 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5252 Do not assume that spare memory exists; that assumption is valid
5253 only if SYSTEM_MALLOC.
5254 (LARGE_REQUEST): New macro, so that the issue of large requests
5255 is separated from the issue of spare memory.
5257 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5259 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5262 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5264 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5267 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5269 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5271 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5273 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5274 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5276 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5278 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5280 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5282 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5283 (x_clipboard_manager_save): Add return value.
5284 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5286 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5287 Obey Vx_select_enable_clipboard_manager. Catch errors in
5288 x_clipboard_manager_save (Bug#8779).
5289 (Vx_select_enable_clipboard_manager): New variable.
5290 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5292 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5294 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5296 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5298 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5299 in the current matrix if keep_current_p is non-zero.
5301 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5303 * bidi.c (bidi_level_of_next_char): Fix last change.
5305 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5307 Support bidi reordering of text covered by display properties.
5309 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5310 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5311 (bidi_cache_search, bidi_cache_iterator_state)
5312 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5313 (bidi_level_of_next_char, bidi_move_to_visually_next):
5314 Support character positions inside a run of characters covered by a
5316 (bidi_paragraph_init, bidi_resolve_explicit_1)
5317 (bidi_level_of_next_char): Call bidi_fetch_char and
5318 bidi_fetch_char_advance instead of FETCH_CHAR and
5320 (bidi_init_it): Initialize new members.
5321 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5323 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5324 instead of using explicit *_CHAR codes.
5325 (bidi_resolve_explicit, bidi_resolve_weak):
5326 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5327 bidirectional text is supported only in multibyte buffers.
5328 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5329 it to initialize the frame_window_p member of struct bidi_it.
5330 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5331 (bidi_resolve_explicit, bidi_resolve_weak)
5332 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5333 bidi_it->nchars is non-positive.
5334 (bidi_level_of_next_char): Don't try to lookup the cache for the
5335 next/previous character if nothing is cached there yet, or if we
5336 were just reseat()'ed to a new position.
5338 * xdisp.c (set_cursor_from_row): Set start and stop points
5339 according to the row's direction when priming the loop that looks
5340 for the glyph on which to display cursor.
5341 (single_display_spec_intangible_p): Function deleted.
5342 (display_prop_intangible_p): Reimplement to call
5343 handle_display_spec instead of single_display_spec_intangible_p.
5344 Accept 3 additional arguments needed by handle_display_spec.
5345 This fixes incorrect cursor motion across display property with complex
5346 values: lists, `(when COND...)' forms, etc.
5347 (single_display_spec_string_p): Support property values that are
5348 lists with the argument STRING its top-level element.
5349 (display_prop_string_p): Fix the condition for processing a
5350 property that is a list to be consistent with handle_display_spec.
5351 (handle_display_spec): New function, refactored from the
5352 last portion of handle_display_prop.
5353 (compute_display_string_pos): Accept additional argument
5354 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5355 value of a `display' property is a "replacing spec".
5356 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5357 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5358 the display property, but just return a value indicating whether
5359 the display property will replace the characters it covers.
5360 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5361 frame_window_p members of struct bidi_it.
5362 (compute_display_string_pos, compute_display_string_end):
5364 (push_it): Accept second argument POSITION, where pop_it should
5365 jump to continue iteration.
5366 (reseat_1): Initialize bidi_it.disp_pos.
5368 * keyboard.c (adjust_point_for_property): Adjust the call to
5369 display_prop_intangible_p to its new signature.
5371 * dispextern.h (struct bidi_it): New member frame_window_p.
5372 (bidi_init_it): Update prototypes.
5373 (display_prop_intangible_p): Update prototype.
5374 (compute_display_string_pos, compute_display_string_end):
5376 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5379 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5381 Malloc failure behavior now depends on size of allocation.
5382 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5383 * lisp.h: Change signatures accordingly.
5384 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5385 All callers changed. (Bug#8762)
5387 * gnutls.c: Use Emacs's memory allocators.
5388 Without this change, the gnutls library would invoke malloc etc.
5389 directly, which causes problems on non-SYNC_INPUT hosts, and which
5390 runs afoul of improving memory_full behavior. (Bug#8761)
5391 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5392 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5393 xfree instead of the default malloc, realloc, free.
5394 (Fgnutls_boot): No need to check for memory allocation failure,
5395 since xmalloc does that for us.
5397 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5398 * category.c (hash_get_category_set):
5399 * ccl.c (ccl_driver):
5400 * charset.c (Fdefine_charset_internal):
5401 * charset.h (struct charset.hash_index):
5402 * composite.c (get_composition_id, gstring_lookup_cache)
5403 (composition_gstring_put_cache):
5404 * composite.h (struct composition.hash_index):
5405 * dispextern.h (struct image.hash):
5406 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5407 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5408 (hashfn_equal, hashfn_user_defined, make_hash_table)
5409 (maybe_resize_hash_table, hash_lookup, hash_put)
5410 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5411 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5412 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5413 * image.c (make_image, search_image_cache, lookup_image)
5414 (xpm_put_color_table_h):
5415 * lisp.h (struct Lisp_Hash_Table):
5416 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5417 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5418 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5419 * alloc.c (allocate_vectorlike):
5420 Check for overflow in vector size calculations.
5421 * ccl.c (ccl_driver):
5422 Check for overflow when converting EMACS_INT to int.
5423 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5424 need to be updated by these changes.
5425 * fns.c (make_hash_table, maybe_resize_hash_table):
5426 Check for integer overflow with large hash tables.
5427 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5428 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5429 (SXHASH_REDUCE): New macro.
5430 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5431 Use it instead of discarding useful hash info with large hash values.
5432 (sxhash_float): New function.
5433 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5434 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5435 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5436 Rewrite to use FIXNUM_BITS, as this simplifies things.
5437 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5438 Adjust signatures to match updated version of code.
5439 (consing_since_gc): Now EMACS_INT, since a single hash table can
5440 use more than INT_MAX bytes.
5442 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5444 Make it possible to build with GCC-4.6+ -O2 -flto.
5446 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5448 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5450 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5451 Call minibuffer-inactive-mode.
5453 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5455 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5456 Update dependencies.
5458 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5460 * data.c (init_data): Remove code for UTS, this system is not
5463 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5465 Don't force ./temacs to start in terminal mode.
5467 * frame.c (make_initial_frame): Initialize faces in all cases, not
5468 only when CANNOT_DUMP is defined.
5469 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5471 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5473 * dispnew.c (add_window_display_history): Use const for the string
5474 pointer. Remove declaration, not needed.
5476 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5478 Use 'inline', not 'INLINE'.
5479 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5480 * alloc.c, fontset.c (INLINE): Remove.
5481 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5482 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5483 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5484 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5485 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5487 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5489 Make it possible to run ./temacs.
5491 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5492 syms_of_callproc does the same thing. Remove test for
5493 "initialized", do it in the caller.
5494 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5496 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5498 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5499 (read_minibuf): Use get_minibuffer.
5500 (syms_of_minibuf): Use DEFSYM.
5501 (Qmetadata): New var.
5502 * data.c (Qbuffer): Don't make it static.
5503 (syms_of_data): Use DEFSYM.
5505 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5507 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5508 (CCL_CODE_MIN): New macro.
5510 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5512 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5514 * eval.c (Qdebug): Now static.
5515 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5516 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5517 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5519 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5521 * image.c: Various fixes to ImageMagick code comments.
5522 (Fimagemagick_types): Doc fix.
5524 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5526 Minor fixes prompted by GCC 4.6.0 warnings.
5528 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5530 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5531 (x_clipboard_manager_save_all): Move extern decl to ...
5532 * xterm.h: ... here, so that it can be checked for consistency.
5534 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5536 * xselect.c (x_clipboard_manager_save_frame)
5537 (x_clipboard_manager_save_all): New functions.
5538 (Fx_clipboard_manager_save): Lisp function deleted.
5540 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5541 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5543 * xterm.h: Update prototype.
5545 2011-05-28 William Xu <william.xwl@gmail.com>
5547 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5550 2011-05-28 Jim Meyering <meyering@redhat.com>
5552 Avoid a sign-extension bug in crypto_hash_function.
5553 * fns.c (to_uchar): Define.
5554 (crypto_hash_function): Use it to convert some newly-signed
5555 variables to unsigned, to avoid sign-extension bugs. For example,
5556 without this change, (md5 "truc") would evaluate to
5557 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5558 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5559 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5561 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5563 Integer overflow fixes.
5565 * dbusbind.c: Serial number integer overflow fixes.
5566 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5567 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5568 to hold a serial number that is too large for a fixnum.
5569 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5570 Check for serial numbers out of range. Decode any serial number
5571 that was so large that it became a float. (Bug#8722)
5573 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5574 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5575 Use XFASTINT rather than XUINT when numbers are nonnegative.
5576 (xd_append_arg, Fdbus_method_return_internal):
5577 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5578 arguments, check that Lisp number is nonnegative, rather than
5579 silently wrapping negative numbers around. (Bug#8722)
5580 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5583 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5585 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5587 ccl: add integer overflow checks
5588 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5589 (IN_INT_RANGE): New macros.
5590 (ccl_driver): Use them to check for integer overflow when
5591 decoding a CCL program. Many of the new checks are whether XINT (x)
5592 fits in int; it doesn't always, on 64-bit hosts. The new version
5593 doesn't catch all possible integer overflows, but it's an
5594 improvement. (Bug#8719)
5596 * alloc.c (make_event_array): Use XINT, not XUINT.
5597 There's no need for unsigned here.
5599 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5600 This follows up to the 2011-05-06 change that substituted uintptr_t
5601 for EMACS_INT. This case wasn't caught back then.
5603 Rework Fformat to avoid integer overflow issues.
5604 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5605 now (part of C89). Include <verify.h>.
5606 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5607 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5608 (Fformat): Avoid the prepass trying to compute sizes; it was only
5609 approximate and thus did not catch overflow reliably. Instead, walk
5610 through the format just once, formatting and computing sizes as we go,
5611 checking for integer overflow at every step, and allocating a larger
5612 buffer as needed. Keep track separately whether the format is
5613 multibyte. Keep only the most-recently calculated precision, rather
5614 than them all. Record whether each argument has been converted to
5615 string. Use EMACS_INT, not int, for byte and char and arg counts.
5616 Support field widths and precisions larger than INT_MAX. Avoid
5617 sprintf's undefined behavior with conversion specifications such as %#d
5618 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5619 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5620 formatting out-of-range floating point numbers with int
5623 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5625 * data.c: Avoid integer truncation in expressions involving floats.
5626 * data.c: Include <intprops.h>.
5627 (arith_driver): When there's an integer overflow in an expression
5628 involving floating point, convert the integers to floating point
5629 so that the resulting value does not suffer from catastrophic
5630 integer truncation. For example, on a 64-bit host (* 4
5631 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5632 Do not rely on undefined behavior after integer overflow.
5634 merge count_size_as_multibyte, parse_str_to_multibyte
5635 * character.c, character.h (count_size_as_multibyte):
5636 Rename from parse_str_to_multibyte; all uses changed.
5637 Check for integer overflow.
5638 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5639 since it's now a duplicate of the other. This is more of
5640 a character than a buffer op, so better that it's in character.c.
5641 * fns.c, print.c: Adjust to above changes.
5643 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5645 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5647 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5649 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5650 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5651 (x_clipboard_manager_save): Now static.
5652 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5654 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5655 (crypto_hash_function): Now static.
5656 Fix pointer signedness problems. Avoid unnecessary initializations.
5658 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5660 * termhooks.h (Vselection_alist): Make it terminal-local.
5662 * terminal.c (create_terminal): Initialize it.
5664 * xselect.c: Support for clipboard managers.
5665 (Vselection_alist): Move to termhooks.h as terminal-local var.
5666 (LOCAL_SELECTION): New macro.
5667 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5668 (symbol_to_x_atom): Remove gratuitous arg.
5669 (x_handle_selection_request, lisp_data_to_selection_data)
5670 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5671 (x_own_selection, x_get_local_selection, x_convert_selection):
5672 New arg, specifying work frame. Use terminal-local Vselection_alist.
5673 (some_frame_on_display): Delete unused function.
5674 (Fx_own_selection_internal, Fx_get_selection_internal)
5675 (Fx_disown_selection_internal, Fx_selection_owner_p)
5676 (Fx_selection_exists_p): New optional frame arg.
5677 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5678 (x_handle_selection_clear): Don't treat other terminals with the
5679 same keyboard specially. Use the terminal-local Vselection_alist.
5680 (x_clear_frame_selections): Use Frun_hook_with_args.
5682 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5684 * xterm.h: Add support for those atoms.
5686 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5688 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5689 (converted_selections, conversion_fail_tag): New global variables.
5690 (x_selection_request_lisp_error): Free the above.
5691 (x_get_local_selection): Remove unnecessary code.
5692 (x_reply_selection_request): Args changed; handle arbitrary array
5693 of converted selections stored in converted_selections.
5694 Separate the XChangeProperty and SelectionNotify steps.
5695 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5696 (x_convert_selection): New function.
5697 (x_handle_selection_event): Simplify.
5698 (x_get_foreign_selection): Don't ignore incoming requests while
5699 waiting for an answer; this will fail when we implement
5700 SAVE_TARGETS, and seems unnecessary anyway.
5701 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5702 (Vx_sent_selection_functions): Doc fix.
5704 2011-05-26 Leo Liu <sdl.web@gmail.com>
5706 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5708 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5710 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5712 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5713 for fringe update if it has periodic bitmap.
5714 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5715 and fringe_bitmap_periodic_p.
5717 * fringe.c (get_fringe_bitmap_data): New function.
5718 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5719 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5720 row. Mark glyph row for fringe update if periodicity changed.
5722 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5723 for fringe update unless it has periodic bitmap.
5725 2011-05-25 Kenichi Handa <handa@m17n.org>
5727 * xdisp.c (get_next_display_element): Set correct it->face_id for
5728 a static composition.
5730 2011-05-24 Leo Liu <sdl.web@gmail.com>
5733 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5735 * fns.c (crypto_hash_function, Fsha1): New function.
5736 (Fmd5): Use crypto_hash_function.
5737 (syms_of_fns): Add Ssha1.
5739 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5741 * gnutls.c: Remove unused macros.
5742 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5743 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5744 Remove macros that are defined and never used.
5745 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5747 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5749 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5750 (Fx_get_selection_internal): Minor cleanup.
5751 (Fx_own_selection_internal): Rename arguments for consistency with
5754 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5756 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5758 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5760 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5762 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5764 * dispnew.c (scrolling_window): Don't exclude the case that the
5765 last enabled row in the desired matrix touches the bottom boundary.
5767 2011-05-21 Glenn Morris <rgm@gnu.org>
5769 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5770 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5771 and add some more files.
5773 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5775 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5776 report_file_error introduced by the change from 2011-05-07.
5778 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5780 * systime.h (Time): Define only if emacs is defined.
5781 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5782 where the include path doesn't have X11/X.h by default. See
5783 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5785 2011-05-20 Kenichi Handa <handa@m17n.org>
5787 * composite.c (find_automatic_composition): Fix previous change.
5789 2011-05-20 Glenn Morris <rgm@gnu.org>
5791 * lisp.mk: New file, split from Makefile.in.
5792 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5793 (shortlisp): Remove.
5794 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5796 2011-05-19 Glenn Morris <rgm@gnu.org>
5798 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5799 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5800 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5801 (lisp): Set the order to that of loadup.el.
5802 (shortlisp): Make it a copy of $lisp.
5803 (SOME_MACHINE_LISP): Remove.
5804 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5805 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5807 2011-05-18 Kenichi Handa <handa@m17n.org>
5809 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5810 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5811 (find_automatic_composition): Mostly rewrite for efficiency.
5813 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5815 * makefile.w32-in: Update dependencies.
5817 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5819 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5820 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5822 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5824 Fix some integer overflow issues, such as string length overflow.
5826 * insdel.c (count_size_as_multibyte): Check for string overflow.
5828 * character.c (lisp_string_width): Check for string overflow.
5829 Use EMACS_INT, not int, for string indexes and lengths; in
5830 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5831 the resulting string length overflows an EMACS_INT; instead,
5832 report a string overflow if no precision given. When checking for
5833 precision exhaustion, use a check that cannot possibly have
5834 integer overflow. (Bug#8675)
5835 * character.h (lisp_string_width): Adjust to new signature.
5837 * alloc.c (string_overflow): New function.
5838 (Fmake_string): Use it. This doesn't change behavior, but saves
5839 a few bytes and will simplify future changes.
5840 * character.c (string_escape_byte8): Likewise.
5841 * lisp.h (string_overflow): New decl.
5843 Fixups, following up to the user-interface timestamp change.
5844 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5845 for UI timestamps, instead of unsigned long.
5846 * msdos.c (mouse_get_pos): Likewise.
5847 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5848 * w32gui.h (Time): Define by including "systime.h" rather than by
5849 declaring it ourselves. (Bug#8664)
5851 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5852 * image.c (clear_image_cache): Likewise.
5854 * term.c (term_mouse_position): Don't assume time_t wraparound.
5856 Be more systematic about user-interface timestamps.
5857 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5858 and sometimes 'EMACS_UINT', to represent these timestamps.
5859 This change causes it to use 'Time' uniformly, as that's what X uses.
5860 This makes the code easier to follow, and makes it easier to catch
5861 integer overflow bugs such as Bug#8664.
5862 * frame.c (Fmouse_position, Fmouse_pixel_position):
5863 Use Time, not unsigned long, for user-interface timestamps.
5864 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5865 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5866 * keyboard.h (last_event_timestamp): Likewise.
5867 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5868 * menu.h (xmenu_show): Likewise.
5869 * term.c (term_mouse_position): Likewise.
5870 * termhooks.h (struct input_event.timestamp): Likewise.
5871 (struct terminal.mouse_position_hook): Likewise.
5872 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5873 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5874 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5875 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5877 * menu.h, termhooks.h: Include "systime.h", for Time.
5879 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5880 Don't assume that the difference between two unsigned long values
5881 can fit into an integer. At this point, we know button_down_time
5882 <= event->timestamp, so the difference must be nonnegative, so
5883 there's no need to cast the result if double-click-time is
5884 nonnegative, as it should be; check that it's nonnegative, just in
5885 case. This bug is triggered when events are more than 2**31 ms
5886 apart (about 25 days). (Bug#8664)
5888 * xselect.c (last_event_timestamp): Remove duplicate decl.
5889 (x_own_selection): Remove needless cast to unsigned long.
5891 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5892 that always fit in int. Use a sentinel instead of a counter, to
5893 avoid a temp and to allay GCC's concerns about possible int overflow.
5894 * frame.h (struct frame): Use int for menu_bar_items_used
5895 instead of EMACS_INT, since it always fits in int.
5897 * menu.c (grow_menu_items): Check for int overflow.
5899 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5901 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5902 Before, the code was not consistent. These values cannot exceed
5903 2**31 - 1 so there's no need to make them unsigned.
5904 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5905 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5906 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5908 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5910 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5911 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5912 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5913 presumably because the widths might not match.
5915 * window.c (size_window): Avoid needless test at loop start.
5917 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5919 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5921 2011-05-12 Drew Adams <drew.adams@oracle.com>
5923 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5925 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5927 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5928 `width' to `bar_area_x' and `bar_area_width', respectively.
5929 (x_scroll_run): Take account of fringe background extension.
5931 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5932 Rename local vars `left' and `width' to `bar_area_x' and
5933 `bar_area_width', respectively.
5934 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5935 background extension.
5937 2011-05-10 Jim Meyering <meyering@redhat.com>
5939 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5941 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5943 * image.c (Finit_image_library): Return t for built-in image types,
5944 like pbm and xbm. (Bug#8640)
5946 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5948 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5950 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5952 * w32console.c (Fset_screen_color): Doc fix.
5953 (Fget_screen_color): New function.
5954 (syms_of_ntterm): Defsubr it.
5956 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5957 unlink the temporary file if Fcall_process didn't create it in the
5959 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5960 child process will be redirected to a file specified with `:file'.
5961 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5962 cue to call_process_cleanup not to close that handle.
5964 2011-05-07 Ben Key <bkey76@gmail.com>
5966 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5967 one of two shell specific rules, either bootstrap-temacs-CMD or
5968 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5969 to the previous implementation of the bootstrap-temacs rule.
5970 The bootstrap-temacs-CMD rule is similar to the previous
5971 implementation of the bootstrap-temacs rule except that it
5972 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5975 These changes, along with some changes to nt/configure.bat,
5976 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5977 earlier fix to add support for --cflags and --ldflags options
5978 that include quotes so that it works whether make uses cmd or
5981 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5983 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5984 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5986 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5987 a string. Handle both cases.
5988 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5989 (Fdbus_register_method): Use Qinvalid_function.
5991 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5993 * makefile.w32-in: Update dependencies.
5994 (LISP_H): Add inttypes.h and stdin.h.
5995 (PROCESS_H): Add unistd.h.
5997 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5999 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6000 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6002 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6004 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6006 * term.c (vfatal): Remove stray call to va_end.
6007 It's not needed and the C Standard doesn't allow it here anyway.
6009 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6010 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6012 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6015 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6017 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6019 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6021 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6023 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6025 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6026 * charset.c (Fdefine_charset_internal): Don't initialize
6027 charset.code_space[15]. The value was garbage, on hosts with
6028 32-bit int (Bug#8600).
6030 * lread.c (read_integer): Be more consistent with string-to-number.
6031 Use string_to_number to do the actual conversion; this avoids
6032 rounding errors and fixes some other screwups. Without this fix,
6033 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6034 (digit_to_number): Move earlier, for benefit of read_integer.
6035 Return -1 if the digit is out of range for the base, -2 if it is
6036 not a digit in any supported base. (Bug#8602)
6038 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6040 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6041 to match comment at start of function. This also removes a
6042 GCC warning about overflow in a 32+64-bit port.
6044 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6046 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6047 Reported by Stefan Monnier in
6048 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6049 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6050 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6052 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6053 (EMACS_UINTPTR): Likewise, with uintptr_t.
6055 * lisp.h: Prefer 64-bit EMACS_INT if available.
6056 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6057 on 32-bit hosts that have 64-bit int, so that they can access
6059 However, temporarily disable this change unless the temporary
6060 symbol WIDE_EMACS_INT is defined.
6062 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6064 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6065 This removes an assumption that EMACS_INT and long are the same
6066 width as pointers. The assumption is true for Emacs porting targets
6067 now, but we want to make other targets possible.
6068 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6069 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6070 In the rest of the code, change types of integers that hold casted
6071 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6072 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6073 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6074 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6075 No need to cast type when ORing.
6076 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6077 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6078 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6079 assume EMACS_INT is the same width as char *.
6080 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6081 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6082 Remove no-longer-needed casts.
6083 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6084 (xg_tool_bar_help_callback, xg_make_tool_item):
6085 Use EMACS_INTPTR to hold an integer
6086 that will be cast to void *; this can avoid a GCC warning
6087 if EMACS_INT is not the same width as void *.
6088 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6089 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6090 (current_message_1, set_message_1):
6091 Use a local to convert to proper width without a cast.
6092 * xmenu.c (dialog_selection_callback): Likewise.
6094 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6095 Also, don't assume VALBITS / RAND_BITS is less than 5,
6096 and don't rely on undefined behavior when shifting a 1 left into
6098 * lisp.h (get_random): Change signature to match.
6100 * lread.c (hash_string): Use size_t, not int, for hash computation.
6101 Normally we prefer signed values; but hashing is special, because
6102 it's better to use unsigned division on hash table sizes so that
6103 the remainder is nonnegative. Also, size_t is the natural width
6104 for hashing into memory. The previous code used 'int', which doesn't
6105 retain enough info to hash well into very large tables.
6106 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6108 * dbusbind.c: Don't possibly lose pointer info when converting.
6109 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6110 Use XPNTR rather than XHASH, so that the high-order bits of
6111 the pointer aren't lost when converting through void *.
6113 * eval.c (Fautoload): Don't double-shift a pointer.
6115 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6117 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6119 * gnutls.c (DEF_GNUTLS_FN):
6120 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6122 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6124 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6127 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6129 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6130 New version that can reserve upto 2GB of heap space.
6132 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6134 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6136 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6138 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6139 `gnutls_certificate_set_x509_key_file'.
6141 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6143 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6144 Update dependencies.
6146 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6148 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6149 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6150 Remove unused parameter `fildes'.
6151 * process.c (read_process_output, send_process): Don't pass it.
6153 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6155 Fix previous change: the library cache is defined in w32.c.
6156 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6157 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6159 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6161 Implement dynamic loading of GnuTLS on Windows.
6163 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6164 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6165 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6168 * gnutls.c (Qgnutls_dll): Define.
6169 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6170 (gnutls_*): Declare function pointers.
6171 (init_gnutls_functions): New function to initialize function pointers.
6172 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6173 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6174 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6175 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6176 (emacs_gnutls_write, emacs_gnutls_read)
6177 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6178 (Fgnutls_available_p): New function.
6179 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6180 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6181 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6183 * image.c: Include w32.h.
6184 (Vimage_type_cache): Delete.
6185 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6186 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6187 (w32_delayed_load): Move to w32.c.
6189 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6191 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6192 (w32_delayed_load): Move from image.c. When loading a library, record
6193 its filename in the :loaded-from property of the library id.
6194 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6195 Initialize and staticpro them.
6196 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6198 * process.c: Include lisp.h before w32.h, not after.
6199 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6200 instead of gnutls_record_check_pending.
6202 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6204 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6206 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6207 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6210 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6212 * xterm.c (x_set_frame_alpha): Do not set property on anything
6213 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6215 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6217 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6219 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6221 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6222 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6223 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6224 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6225 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6226 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6227 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6228 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6229 (Qgnutls_bootprop_callbacks_verify): Make static.
6231 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6233 * callproc.c: Indentation fixup.
6235 * sysdep.c (wait_for_termination_1): Make static.
6236 (wait_for_termination, interruptible_wait_for_termination):
6237 Move after wait_for_termination_1.
6239 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6241 * sysdep.c (interruptible_wait_for_termination): New function
6242 which is like wait_for_termination, but allows keyboard
6245 * callproc.c (Fcall_process): Add (:file "file") as an option for
6247 (Fcall_process_region): Ditto.
6249 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6251 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6252 rather than `XVECTOR (FOO)->size'.
6254 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6255 inttypes.h, as a gnulib replacement is used if it not available in
6258 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6260 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6261 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6262 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6264 * coding.c (coding_alloc_by_realloc): Error out if destination
6265 will grow beyond MOST_POSITIVE_FIXNUM.
6266 (decode_coding_emacs_mule): Abort if there isn't enough place in
6267 charbuf for the composition carryover bytes. Reserve an extra
6268 space for up to 2 characters produced in a loop.
6269 (decode_coding_iso_2022): Abort if there isn't enough place in
6270 charbuf for the composition carryover bytes.
6272 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6274 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6275 aborting when %lld or %lll format is passed.
6276 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6277 %llo or %llx format is passed. (Bug#8545)
6279 * window.c (window_scroll_line_based): Use a marker instead of
6280 simple variables to record original value of point. (Bug#7952)
6282 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6283 produced by %s or %c overflows available buffer space. (Bug#8545)
6285 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6287 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6288 (SIZE_MAX): Move defn after all includes, as they might #define it.
6290 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6292 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6294 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6296 * keyboard.c (Qdelayed_warnings_hook): Define.
6297 (command_loop_1): Run `delayed-warnings-hook'
6298 if Vdelayed_warnings_list is non-nil.
6299 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6300 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6302 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6304 * doprnt.c (doprnt): Don't return value smaller than the buffer
6305 size if the message was truncated. (Bug#8545).
6307 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6309 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6310 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6312 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6314 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6316 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6318 * makefile.w32-in: Update dependencies.
6320 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6322 Improve `doprnt' and its usage. (Bug#8545)
6323 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6324 `format_end'. Remove support for %l as a conversion specifier.
6325 Don't use xrealloc. Improve diagnostics when the %l size modifier
6326 is used. Update the commentary.
6328 * eval.c (verror): Simplify calculation of size_t.
6330 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6333 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6335 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6338 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6340 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6341 This makes this file independent of the recent pseudovector change.
6343 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6345 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6347 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6348 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6349 Remove unused local.
6350 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6352 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6353 GCC 4.6.0 optimizes based on type-based alias analysis.
6354 For example, if b is of type struct buffer * and v of type struct
6355 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6356 != &v->size, and therefore "v->size = 1; b->size = 2; return
6357 v->size;" must therefore return 1. This assumption is incorrect
6358 for Emacs, since it type-puns struct Lisp_Vector * with many other
6359 types. To fix this problem, this patch adds a new type struct
6360 vectorlike_header that documents the constraints on layout of vectors
6361 and pseudovectors, and helps optimizing compilers not get fooled
6362 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6363 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6364 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6366 (XSETPVECTYPE): Rewrite in terms of new macro.
6367 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6368 This is a bit clearer, and further avoids the possibility of
6369 undesirable aliasing.
6370 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6371 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6372 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6373 since Lisp_Subr is a special case (no "next" field).
6374 (ASIZE): Now uses header.size rather than size.
6375 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6376 to avoid the hassle of writing XVECTOR (foo)->header.size.
6377 (struct vectorlike_header): New type.
6378 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6379 object, to help avoid aliasing.
6380 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6381 (SUBRP): Likewise, since Lisp_Subr is a special case.
6382 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6383 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6384 (struct Lisp_Hash_Table): Combine first two members into a single
6385 struct vectorlike_header member. All uses of "size" and "next" members
6386 changed to be "header.size" and "header.next".
6387 * buffer.h (struct buffer): Likewise.
6388 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6389 * frame.h (struct frame): Likewise.
6390 * process.h (struct Lisp_Process): Likewise.
6391 * termhooks.h (struct terminal): Likewise.
6392 * window.c (struct save_window_data, struct saved_window): Likewise.
6393 * window.h (struct window): Likewise.
6394 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6395 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6396 * buffer.c (init_buffer_once): Likewise.
6397 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6399 * process.c (Fformat_network_address): Use local var for size,
6402 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6404 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6405 * data.c (atof): Remove decl; no longer used or needed.
6406 (digit_to_number): Move to lread.c.
6407 (Fstring_to_number): Use new string_to_number function, to be
6408 consistent with how the Lisp reader treats infinities and NaNs.
6409 Do not assume that floating-point numbers represent EMACS_INT
6410 without losing information; this is not true on most 64-bit hosts.
6411 Avoid double-rounding errors, by insisting on integers when
6412 parsing non-base-10 numbers, as the documentation specifies.
6413 * lisp.h (string_to_number): New decl, replacing ...
6414 (isfloat_string): Remove.
6415 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6416 (read1): Do not accept +. and -. as integers; this
6417 appears to have been a coding error. Similarly, do not accept
6418 strings like +-1e0 as floating point numbers. Do not report
6419 overflow for integer overflows unless the base is not 10 which
6420 means we have no simple and reliable way to continue.
6421 Break out the floating-point parsing into a new
6422 function string_to_number, so that Fstring_to_number parses
6423 floating point numbers consistently with the Lisp reader.
6424 (digit_to_number): Move here from data.c. Make it static inline.
6425 (E_CHAR, EXP_INT): Remove, replacing with ...
6426 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6427 (string_to_number): New function, replacing isfloat_string.
6428 This function checks for valid syntax and produces the resulting
6429 Lisp float number too. Rework it so that string-to-number
6430 no longer mishandles examples like "1.0e+". Use strtoumax,
6431 so that overflow for non-base-10 numbers is reported only when
6432 there's no portable and simple way to convert to floating point.
6434 * textprop.c (set_text_properties_1): Rewrite for clarity,
6435 and to avoid GCC warning about integer overflow.
6437 * intervals.h (struct interval): Use EMACS_INT for members
6438 where EMACS_UINT might cause problems. See
6439 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6440 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6441 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6443 (offset_intervals): Tell GCC not to worry about length overflow
6444 when negating a negative length.
6446 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6447 (overrun_check_free): Likewise.
6449 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6450 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6453 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6454 (gnutls_make_error): Rename local to avoid shadowing.
6455 (gnutls_emacs_global_deinit): ifdef out; not used.
6456 (Fgnutls_boot): Use const for pointer to readonly storage.
6457 Comment out unused local. Fix pointer signedness problems.
6459 * lread.c (openp): Don't stuff size_t into an 'int'.
6460 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6461 about possible signed overflow.
6463 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6464 (GDK_KEY_g): Don't define if already defined.
6465 (xg_prepare_tooltip): Avoid pointer signedness problem.
6466 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6468 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6469 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6471 * xfns.c (Fx_window_property): Simplify a bit,
6472 to make a bit faster and to avoid GCC 4.6.0 warning.
6473 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6475 * fns.c (internal_equal): Don't assume size_t fits in int.
6477 * alloc.c (compact_small_strings): Tighten assertion a little.
6479 Replace pEd with more-general pI, and fix some printf arg casts.
6480 * lisp.h (pI): New macro, generalizing old pEd macro to other
6481 conversion specifiers. For example, use "...%"pI"d..." rather
6482 than "...%"pEd"...".
6483 (pEd): Remove. All uses replaced with similar uses of pI.
6484 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6485 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6486 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6487 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6488 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6489 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6490 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6492 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6493 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6494 * print.c (safe_debug_print, print_object): Likewise.
6495 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6497 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6498 avoiding the 0 flag, which is not portable.
6499 * process.c (Fmake_network_process): Use pI to avoid cast.
6500 * region-cache.c (pp_cache): Likewise.
6501 * xdisp.c (decode_mode_spec): Likewise.
6502 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6503 behavior on 64-bit hosts with printf arg.
6504 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6505 (x_stop_queuing_selection_requests): Likewise.
6506 (x_get_window_property): Don't truncate byte count to an 'int'
6509 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6510 here, since it parses constructs like leading '-' and spaces,
6511 which are not wanted; and it overflows with large numbers.
6512 Instead, simply match F[0-9]+, which is what is wanted anyway.
6514 * alloc.c: Remove unportable assumptions about struct layout.
6515 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6516 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6517 (allocate_vectorlike, make_pure_vector): Use the new macros,
6518 plus offsetof, to remove unportable assumptions about struct layout.
6519 These assumptions hold on all porting targets that I know of, but
6520 they are not guaranteed, they're easy to remove, and removing them
6521 makes further changes easier.
6523 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6524 This doesn't fix a bug but makes the code clearer.
6525 (string_overrun_cookie): Now const. Use initializers that
6526 don't formally overflow signed char, to avoid warnings.
6527 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6528 can cause Emacs to crash when string overrun checking is enabled.
6529 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6530 multiple of sizeof (EMACS_INT); it need not be, if
6531 alignof(EMACS_INT) < sizeof (EMACS_INT).
6532 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6534 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6536 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6538 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6540 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6541 supposed to be handshaking. (Bug#8556)
6542 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6544 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6546 * lisp.h (Qdebug): List symbol.
6547 * eval.c (Qdebug): Restore global linkage.
6548 * keyboard.c (debug-on-event): New variable.
6549 (handle_user_signal): Break into debugger when debug-on-event
6550 matches the current signal symbol.
6552 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6554 * alloc.c (check_sblock, check_string_bytes)
6555 (check_string_free_list): Convert to standard C.
6557 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6559 * w32.c (emacs_gnutls_push): Fix typo.
6561 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6563 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6564 "cast to pointer from integer of different size".
6566 Improve doprnt and its use in verror. (Bug#8545)
6567 * doprnt.c (doprnt): Document the set of format control sequences
6568 supported by the function. Use SAFE_ALLOCA instead of always
6571 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6572 is one byte too soon. Don't use xrealloc; instead xfree and
6575 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6577 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6580 * gnutls.c: Renamed global_initialized to
6581 gnutls_global_initialized. Added internals for the
6582 :verify-hostname-error, :verify-error, and :verify-flags
6583 parameters of `gnutls-boot' and documented those parameters in the
6584 docstring. Start callback support.
6585 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6586 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6587 on error. Return error code.
6588 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6589 (emacs_gnutls_read): Likewise.
6590 (Fgnutls_boot): Return handshake error code.
6591 (emacs_gnutls_handle_error): New function.
6592 (wsaerror_to_errno): Likewise.
6594 * w32.h (emacs_gnutls_pull): Add prototype.
6595 (emacs_gnutls_push): Likewise.
6597 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6598 (emacs_gnutls_push): Likewise.
6600 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6602 * process.c (wait_reading_process_output): Check if GnuTLS
6603 buffered some data internally if no FDs are set for TLS
6606 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6607 (LIBS): Link to USER_LIBS.
6608 ($(BLD)/gnutls.$(0)): New target.
6610 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6612 * xdisp.c (handle_single_display_spec): Rename the
6613 display_replaced_before_p argument into display_replaced_p, to
6614 make it consistent with the commentary. Fix typos in the
6617 * textprop.c (syms_of_textprop): Remove dead code.
6618 (copy_text_properties): Delete obsolete commentary about an
6619 interface that was deleted long ago. Fix typos in the description
6622 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6623 to changes in oldXMenu/XMenu.h from 2011-04-16.
6624 <menu_help_message, prev_menu_help_message>: Constify.
6625 (IT_menu_make_room): menu->help_text is now `const char **';
6628 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6629 to changes in oldXMenu/XMenu.h from 2011-04-16.
6630 (struct XMenu): Declare `help_text' `const char **'.
6632 * xfaces.c <Qunspecified>: Make extern again.
6634 * syntax.c: Include sys/types.h before including regex.h, as
6637 * doc.c (get_doc_string): Improve the format passed to `error'.
6639 * doprnt.c (doprnt): Improve commentary.
6641 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6643 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6646 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6647 changes in globals.h immediately force recompilation.
6648 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6649 $(CURDIR)/s/ms-w32.h.
6650 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6652 * character.c (Fchar_direction): Function deleted.
6653 (syms_of_character): Don't defsubr it.
6654 <char-direction-table>: Deleted.
6656 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6658 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6659 * doprnt.c: Include limits.h.
6660 (SIZE_MAX): New macro.
6661 (doprnt): Return a size_t value. 2nd arg is now size_t.
6662 Many local variables are now size_t instead of int or unsigned.
6663 Improve overflow protection. Support `l' modifier for integer
6664 conversions. Support %l conversion. Don't assume an EMACS_INT
6665 argument for integer conversions and for %c.
6667 * lisp.h (doprnt): Restore prototype.
6669 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6672 * Makefile.in (base_obj): Add back doprnt.o.
6674 * deps.mk (doprnt.o): Add back prerequisites.
6675 (callint.o): Depend on character.h.
6677 * eval.c (internal_lisp_condition_case): Include the handler
6678 representation in the error message.
6679 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6680 when breaking from the loop.
6682 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6684 * callint.c (Fcall_interactively): When displaying error message
6685 about invalid control letter, pass the character's codepoint, not
6686 a pointer to its multibyte form. Improve display of the character
6687 in octal and display also its hex code.
6689 * character.c (char_string): Use %x to display the (unsigned)
6690 codepoint of an invalid character, to avoid displaying a bogus
6693 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6694 `error', not SYMBOL_NAME itself.
6696 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6697 character arguments to `error'.
6699 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6700 to `error' in error message about FINAL_CHAR argument. Make sure
6701 FINAL_CHAR is a character, and use %c when it is passed as
6702 argument to `error'.
6704 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6706 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6708 * w32.c: Include <time.h>.
6709 (sys_localtime): New function.
6711 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6713 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6715 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6717 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6719 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6722 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6724 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6725 gl_state.e_property when gl_state.object is Qt.
6727 * insdel.c (make_gap_larger): Remove limitation of buffer size
6730 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6732 * xdisp.c (lookup_glyphless_char_display)
6733 (produce_glyphless_glyph): Handle cons cell entry in
6734 glyphless-char-display.
6735 (Vglyphless_char_display): Document it.
6737 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6738 glyphless-char-display.
6740 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6742 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6744 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6746 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6747 definition for no-X builds.
6749 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6751 Static checks with GCC 4.6.0 and non-default toolkits.
6753 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6755 * process.c (keyboard_bit_set): Define only if SIGIO.
6756 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6757 (send_process): Repair possible setjmp clobbering.
6759 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6761 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6763 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6765 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6766 Define only if needed.
6768 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6769 by pacifying GCC about it. Maybe it's time to retire it?
6770 * xfaces.c (USG, __TIMEVAL__): Likewise.
6772 * dispextern.h (struct redisplay_interface): Rename param
6774 * termhooks.h (struct terminal): Likewise.
6775 * xterm.c (xembed_send_message): Likewise.
6777 * insdel.c (make_gap_smaller): Define only if
6778 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6780 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6783 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6784 so that we aren't warned about unused symbols.
6786 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6788 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6790 * xfns.c (x_real_positions): Mark locals as initialized.
6792 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6794 * xterm.c: Fix problems found by static analysis with other toolkits.
6795 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6796 (x_dispatch_event): Declare static if USE_GTK, and
6797 define if USE_GTK || USE_X_TOOLKIT.
6798 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6799 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6800 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6801 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6803 * xmenu.c (menu_help_callback): Pointer type fixes.
6804 Use const pointers when pointing at readonly data. Avoid pointer
6806 (FALSE): Remove unused macro.
6807 (update_frame_menubar): Remove unused decl.
6809 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6811 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6812 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6813 (single_menu_item): Rename local to avoid shadowing.
6815 * keyboard.c (make_lispy_event): Remove unused local var.
6817 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6818 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6820 * bitmaps: Change bitmaps from unsigned char back to the X11
6821 compatible char. Avoid the old compiler warnings about
6822 out-of-range initializers by using, for example, '\xab' rather
6825 * xgselect.c (xgselect_initialize): Check vs interface
6826 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6828 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6830 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6831 to read-only memory.
6833 * fns.c (vector): Remove; this old hack is no longer needed.
6835 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6837 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6839 * xrdb.c (x_load_resources): Omit unused local.
6841 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6842 (x_window): Rename locals to avoid shadowing.
6843 (USG): Use the kludged USG macro, to pacify gcc.
6845 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6846 (x_term_init): Remove local to avoid shadowing.
6848 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6850 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6851 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6853 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6855 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6857 Fix regex.c, syntax.c and friends for buffers > 2GB.
6858 * syntax.h (struct gl_state_s): Declare character position members
6861 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6863 * textprop.c (verify_interval_modification, interval_of):
6864 Declare arguments EMACS_INT.
6866 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6869 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6871 * indent.c (Fvertical_motion): Local variable it_start is now
6874 * regex.c (re_match, re_match_2, re_match_2_internal)
6875 (bcmp_translate, regcomp, regexec, print_double_string)
6876 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6877 (re_compile_pattern, re_exec): Declare arguments and local
6878 variables `size_t' and `ssize_t' and return values `regoff_t', as
6880 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6881 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6882 <compile_stack_type>: `size' and `avail' are now `size_t'.
6884 * regex.h <regoff_t>: Use ssize_t, not int.
6885 (re_search, re_search_2, re_match, re_match_2): Arguments that
6886 specify buffer/string position and length are now ssize_t and
6887 size_t. Return type is regoff_t.
6889 2011-04-16 Ben Key <bkey76@gmail.com>
6891 * nsfont.m: Fixed bugs in ns_get_family and
6892 ns_descriptor_to_entity that were caused by using free to
6893 deallocate memory blocks that were allocated by xmalloc (via
6894 xstrdup). This caused Emacs to crash when compiled with
6895 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6896 --enable-checking=xmallocoverrun). xfree is now used to
6897 deallocate these memory blocks.
6899 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6901 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6903 emacs_write: Accept and return EMACS_INT for sizes.
6904 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6906 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6907 Accept and return EMACS_INT.
6908 (emacs_gnutls_write): Return the number of bytes written on
6910 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6911 (emacs_read, emacs_write): Remove check for negative size, as the
6912 Emacs source code has been audited now.
6913 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6914 (emacs_read, emacs_write): Use it.
6915 * process.c (send_process): Adjust to the new signatures of
6916 emacs_write and emacs_gnutls_write. Do not attempt to store
6917 a byte offset into an 'int'; it might overflow.
6918 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6920 * sound.c: Don't assume sizes fit in 'int'.
6921 (struct sound_device.period_size, alsa_period_size):
6922 Return EMACS_INT, not int.
6923 (struct sound_device.write, vox_write, alsa_write):
6924 Accept EMACS_INT, not int.
6925 (wav_play, au_play): Use EMACS_INT to store sizes and to
6926 record read return values.
6928 2011-04-15 Ben Key <bkey76@gmail.com>
6930 * keyboard.c (Qundefined): Don't declare static since it is used
6932 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6933 static since they are used in nsfont.m.
6935 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6937 * process.c (Qprocessp): Don't declare static.
6938 * lisp.h (Qprocessp): Declare again.
6940 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6942 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6944 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6946 Improve C-level modularity by making more things 'static'.
6948 Don't publish debugger-only interfaces to other modules.
6949 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6950 (verify_bytepos, count_markers): Move decls to the only modules
6952 * region-cache.h (pp_cache): Likewise.
6953 * window.h (check_all_windows): Likewise.
6954 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6956 * sysdep.c (croak): Now static, if
6957 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6958 * syssignal.h (croak): Declare only if not static.
6960 * alloc.c (refill_memory_reserve): Now static if
6961 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6962 * lisp.h (refill_memory_reserve): Declare only if not static.
6964 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6965 Define only if USE_LUCID.
6967 * xrdb.c (x_customization_string, x_rm_string): Now static.
6969 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6970 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6972 * xdisp.c (draw_row_with_mouse_face): Now static.
6973 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6975 * window.h (check_all_windows): Mark externally visible.
6977 * window.c (window_deletion_count): Now static.
6979 * undo.c: Make symbols static if they're not exported.
6980 (last_undo_buffer, last_boundary_position, pending_boundary):
6983 * textprop.c (interval_insert_behind_hooks): Now static.
6984 (interval_insert_in_front_hooks): Likewise.
6986 * term.c: Make symbols static if they're not exported.
6987 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6988 (max_frame_lines, tty_set_terminal_modes):
6989 (tty_reset_terminal_modes, tty_turn_off_highlight):
6990 (get_tty_terminal): Now static.
6991 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6992 * termhooks.h (term_mouse_moveto): Do not declare if
6994 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6995 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6997 * sysdep.c: Make symbols static if they're not exported.
6998 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7000 (sigprocmask_set, full_mask): Remove; unused.
7001 (wait_debugging): Mark as visible.
7002 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7003 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7005 * syntax.c (syntax_temp): Define only if !__GNUC__.
7007 * sound.c (current_sound_device, current_sound): Now static.
7009 * search.c (searchbufs, searchbuf_head): Now static.
7011 * scroll.c (scroll_cost): Remove; unused.
7012 * dispextern.h (scroll_cost): Remove decl.
7014 * region-cache.h (pp_cache): Mark as externally visible.
7016 * process.c: Make symbols static if they're not exported.
7017 (process_tick, update_tick, create_process, chan_process):
7018 (Vprocess_alist, proc_buffered_char, datagram_access):
7019 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7020 (deactivate_process): Mark defn as static, as well as decl.
7021 * lisp.h (create_process): Remove decl.
7022 * process.h (chan_process, Vprocess_alist): Remove decls.
7024 * print.c: Make symbols static if they're not exported.
7025 (print_depth, new_backquote_output, being_printed, print_buffer):
7026 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7027 (print_interval, print_number_index, initial_stderr_stream):
7029 * lisp.h (Fprinc): Remove decl.
7030 (debug_output_compilation_hack): Mark as externally visible.
7032 * sysdep.c (croak): Move decl from here to syssignal.h.
7033 * syssignal.h (croak): Put it here, so the API can be checked when
7034 'croak' is called from dissociate_if_controlling_tty.
7036 * minibuf.c: Make symbols static if they're not exported.
7037 (minibuf_save_list, choose_minibuf_frame): Now static.
7038 * lisp.h (choose_minibuf_frame): Remove decl.
7040 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7042 * lread.c: Make symbols static if they're not exported.
7043 (read_objects, initial_obarray, oblookup_last_bucket_number):
7045 (make_symbol): Remove; unused.
7046 * lisp.h (initial_obarray, make_symbol): Remove decls.
7048 * keyboard.c: Make symbols static if they're not exported.
7049 (single_kboard, recent_keys_index, total_keys, recent_keys):
7050 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7051 (this_single_command_key_start, echoing, last_auto_save):
7052 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7053 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7054 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7055 (Vlispy_mouse_stem, double_click_count):
7057 (force_auto_save_soon): Define only if SIGDANGER.
7058 (ignore_mouse_drag_p): Now static if
7059 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7060 (print_help): Remove; unused.
7061 (stop_character, last_timer_event): Mark as externally visible.
7062 * keyboard.h (ignore_mouse_drag_p): Declare only if
7063 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7064 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7065 * lisp.h (echoing): Remove decl.
7066 (force_auto_save_soon): Declare only if SIGDANGER.
7067 * xdisp.c (redisplay_window): Simplify code, to make it more
7068 obvious that ignore_mouse_drag_p is not accessed if !defined
7069 USE_GTK && !defined HAVE_NS.
7071 * intervals.c: Make symbols static if they're not exported.
7072 (merge_properties_sticky, merge_interval_right, delete_interval):
7074 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7076 * insdel.c: Make symbols static if they're not exported.
7077 However, leave prepare_to_modify_buffer alone. It's never
7078 called from outside this function, but that appears to be a bug.
7079 (combine_after_change_list, combine_after_change_buffer):
7080 (adjust_after_replace, signal_before_change): Now static.
7081 (adjust_after_replace_noundo): Remove; unused.
7082 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7083 (signal_before_change): Remove decls.
7085 * indent.c (val_compute_motion, val_vmotion): Now static.
7087 * image.c: Make symbols static if they're not exported.
7088 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7090 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7091 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7093 * fringe.c (standard_bitmaps): Now static.
7094 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7096 * frame.c: Make symbols static if they're not exported.
7097 (x_report_frame_params, make_terminal_frame): Now static.
7098 (get_frame_param): Now static, unless HAVE_NS.
7099 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7100 (x_get_resource_string): Remove; not used.
7101 * frame.h (make_terminal_frame, x_report_frame_params):
7102 (x_get_resource_string); Remove decls.
7103 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7104 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7106 * font.c, fontset.c: Make symbols static if they're not exported.
7107 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7108 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7109 * font.c (font_close_object): Now static.
7110 * font.h (font_close_object): Remove.
7111 * fontset.c (FONTSET_OBJLIST): Remove.
7112 (free_realized_fontset) #if-0 the body, which does nothing.
7113 (face_suitable_for_char_p): #if-0, as it's never called.
7114 * fontset.h (face_suitable_for_char_p): Remove decl.
7115 * xfaces.c (face_at_string_position):
7116 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7117 since 0 is always ASCII.
7119 * fns.c (weak_hash_tables): Now static.
7121 * fileio.c: Make symbols static if they're not exported.
7122 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7123 (Vwrite_region_annotation_buffers): Now static.
7125 * eval.c: Make symbols static if they're not exported.
7126 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7127 * lisp.h (backtrace_list): Remove decl.
7129 * emacs.c: Make symbols static if they're not exported.
7130 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7131 (fatal_error_code, fatal_error_signal_hook, standard_args):
7133 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7134 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7135 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7136 * lisp.h (fatal_error_signal_hook): Remove decl.
7137 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7139 * editfns.c: Move a (normally-unused) function to its only use.
7140 * editfns.c, lisp.h (get_operating_system_release): Remove.
7141 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7142 worth the hassle of breaking this out.
7144 * xterm.c: Make symbols static if they're not exported.
7145 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7146 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7147 (x_destroy_window, x_delete_display):
7149 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7150 (x_mouse_leave): Remove; unused.
7151 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7152 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7153 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7155 (x_mouse_leave): Declare only if WINDOWSNT.
7156 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7157 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7160 * ftxfont.c: Make symbols static if they're not exported.
7161 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7163 * font.h (ftxfont_driver): Likewise.
7165 * xfns.c: Make symbols static if they're not exported.
7166 (x_last_font_name, x_display_info_for_name):
7167 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7168 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7169 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7170 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7171 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7172 (last_show_tip_args): Now static.
7173 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7174 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7175 (x_screen_planes): Remove; unused.
7176 * dispextern.h (x_screen_planes): Remove decl.
7178 * dispnew.c: Make symbols static if they're not exported.
7179 * dispextern.h (redraw_garbaged_frames, scrolling):
7180 (increment_row_positions): Remove.
7181 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7182 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7184 (redraw_garbaged_frames): Remove; unused.
7186 * xfaces.c: Make symbols static if they're not exported.
7187 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7189 * xterm.h (defined_color): Remove decls.
7190 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7191 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7192 (menu_face_changed_default, defined_color, free_realized_face):
7193 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7194 (ascii_face_of_lisp_face): Remove; unused.
7196 * xdisp.c: Make symbols static if they're not exported.
7197 * dispextern.h (scratch_glyph_row, window_box_edges):
7198 (glyph_to_pixel_coords, set_cursor_from_row):
7199 (get_next_display_element, set_iterator_to_next):
7200 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7201 (show_mouse_face): Remove decls
7202 * frame.h (message_buf_print): Likewise.
7203 * lisp.h (pop_message, set_message, check_point_in_composition):
7205 * xterm.h (set_vertical_scroll_bar): Likewise.
7206 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7207 (message_buf_print, scratch_glyph_row, displayed_buffer):
7208 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7209 (get_next_display_element, show_mouse_face, window_box_edges):
7210 (frame_to_window_pixel_xy, check_point_in_composition):
7211 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7212 (glyph_to_pixel_coords): Remove; unused.
7214 * dired.c (file_name_completion): Now static.
7216 * dbusbind.c (xd_in_read_queued_messages): Now static.
7218 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7219 * data.c (circular_list_error): Remove.
7221 * commands.h (last_point_position, last_point_position_buffer):
7222 (last_point_position_window): Remove decls.
7223 * keyboard.c: Make these variables static.
7225 * coding.h (coding, code_convert_region, encode_coding_gap):
7227 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7228 (iso_code_class, detect_coding, code_convert_region): Now static.
7229 (encode_coding_gap): Remove; unused.
7231 * chartab.c (chartab_chars, chartab_bits): Now static.
7233 * charset.h (charset_iso_8859_1): Remove decl.
7234 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7237 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7238 * ccl.c (Vccl_program_table): Now static.
7239 (check_ccl_update): Remove; unused.
7241 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7242 * category.h: ... from here.
7243 * category.c (check_category_table, set_category_set): Now static.
7245 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7246 * lisp.h: Remove these decls.
7248 * buffer.c (buffer_count): Remove unused var.
7250 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7251 so that it's not optimized away.
7252 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7253 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7254 exported only to the debugger.
7256 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7257 * atimer.h (run_all_atimers): Remove; not exported.
7259 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7260 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7261 was inaccessible from Lisp.
7262 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7263 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7265 alloc.c: Import and export fewer symbols, and remove unused items.
7266 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7268 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7269 it's not optimized away by whole-program optimization.
7270 (message_enable_multibyte, free_misc): Remove.
7271 (catchlist, handlerlist, mark_backtrace):
7272 Declare only if BYTE_MARK_STACK.
7273 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7274 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7275 (message_enable_multibyte): Remove decl.
7276 (free_misc, interval_free_list, float_block, float_block_index):
7277 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7278 (cons_free_list, last_marked_index):
7280 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7281 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7282 (mark_backtrace): Define only if BYTE_MARK_STACK.
7283 * xdisp.c (message_enable_multibyte): Now static.
7285 Declare Lisp_Object Q* variables to be 'static' if not exported.
7286 This makes it easier for human readers (and static analyzers)
7287 to see whether these variables are used from other modules.
7288 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7289 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7290 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7291 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7292 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7293 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7294 * xmenu.c, xselect.c:
7295 Declare Q* vars static if they are not used in other modules.
7296 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7297 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7298 Remove decls of unexported vars.
7299 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7301 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7303 Make Emacs functions such as Fatom 'static' by default.
7304 This makes it easier for human readers (and static analyzers)
7305 to see whether these functions can be called from other modules.
7306 DEFUN now defines a static function. To make the function external
7307 so that it can be used in other C modules, use the new macro DEFUE.
7308 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7309 (Finit_image_library):
7310 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7311 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7312 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7313 Remove decls, since these functions are now static.
7314 (Funintern, Fget_internal_run_time): New decls, since these functions
7315 were already external.
7317 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7318 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7319 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7320 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7321 * keyboard.c, keymap.c, lread.c:
7322 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7323 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7324 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7325 Mark functions with DEFUE instead of DEFUN,
7326 if they are used in other modules.
7327 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7328 decls for now-static functions.
7329 * buffer.h (Fdelete_overlay): Remove decl.
7330 * callproc.c (Fgetenv_internal): Mark as internal.
7331 * composite.c (Fremove_list_of_text_properties): Remove decl.
7332 (Fcomposition_get_gstring): New forward static decl.
7333 * composite.h (Fcomposite_get_gstring): Remove decl.
7334 * dired.c (Ffile_attributes): New forward static decl.
7335 * doc.c (Fdocumntation_property): New forward static decl.
7336 * eval.c (Ffetch_bytecode): New forward static decl.
7337 (Funintern): Remove extern decl; now in .h file where it belongs.
7338 * fileio.c (Fmake_symbolic_link): New forward static decl.
7339 * image.c (Finit_image_library): New forward static decl.
7340 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7341 * intervals.h (Fprevious_property_change):
7342 (Fremove_list_of_text_properties): Remove decls.
7343 * keyboard.c (Fthis_command_keys): Remove decl.
7344 (Fcommand_execute): New forward static decl.
7345 * keymap.c (Flookup_key): New forward static decl.
7346 (Fcopy_keymap): Now static.
7347 * keymap.h (Flookup_key): Remove decl.
7348 * process.c (Fget_process): New forward static decl.
7349 (Fprocess_datagram_address): Mark as internal.
7350 * syntax.c (Fsyntax_table_p): New forward static decl.
7351 (skip_chars): Remove duplicate decl.
7352 * textprop.c (Fprevious_property_change): New forward static decl.
7353 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7355 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7356 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7358 * editfns.c (Fformat): Remove unreachable code.
7360 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7362 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7365 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7367 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7368 when at ZV. (Bug#8487)
7370 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7372 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7374 * keyboard.c (parse_tool_bar_item): Likewise.
7375 * sound.c (sound_cleanup, alsa_close): Likewise.
7376 * termcap.c (tgetent): Likewise.
7377 * xfns.c (x_default_font_parameter): Likewise.
7378 * xsettings.c (read_and_apply_settings): Likewise.
7380 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7381 (overrun_check_free): Protoize.
7383 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7385 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7386 since callers should never pass a negative size.
7387 Change the signature to match that of plain 'read' and 'write'; see
7388 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7389 * lisp.h: Update prototypes of emacs_write and emacs_read.
7391 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7393 * xdisp.c (redisplay_window): Don't try to determine the character
7394 position of the scroll margin if the window start point w->startp
7395 is outside the buffer's accessible region. (Bug#8468)
7397 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7399 Fix write-region and its subroutines for buffers > 2GB.
7400 * fileio.c (a_write, e_write): Modify declaration of arguments and
7401 local variables to support buffers larger than 2GB.
7402 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7404 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7405 argument, local variables, and return value.
7407 * lisp.h: Update prototypes of emacs_write and emacs_read.
7409 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7411 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7413 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7415 Fix more problems found by GCC 4.6.0's static checks.
7417 * xdisp.c (vmessage): Use a better test for character truncation.
7419 * charset.c (load_charset_map): <, not <=, for optimization,
7420 and to avoid potential problems with integer overflow.
7421 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7422 * casetab.c (set_identity, shuffle): Likewise.
7423 * editfns.c (Fformat): Likewise.
7424 * syntax.c (skip_chars): Likewise.
7426 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7427 This also lets GCC 4.6.0 generate slightly better loop code.
7429 * callint.c (Fcall_interactively): <, not <=, for optimization.
7430 (Fcall_interactively): Count the number of arguments produced,
7431 not the number of arguments given. This is simpler and lets GCC
7432 4.6.0 generate slightly better code.
7434 * ftfont.c: Distingish more carefully between FcChar8 and char.
7435 The previous code passed unsigned char * to a functions like
7436 strlen and xstrcasecmp that expect char *, which does not
7437 conform to the C standard.
7438 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7439 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7440 char * when the C standard requires it.
7442 * keyboard.c (read_char): Remove unused var.
7444 * eval.c: Port to Windows vsnprintf (Bug#8435).
7446 (SIZE_MAX): Define if the headers do not.
7447 (verror): Do not give up if vsnprintf returns a negative count.
7448 Instead, grow the buffer. This ports to Windows vsnprintf, which
7449 does not conform to C99. Problem reported by Eli Zaretskii.
7450 Also, simplify the allocation scheme, by avoiding the need for
7451 calling realloc, and removing the ALLOCATED variable.
7453 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7455 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7456 But keep the doprint source code for now, as we might revamp it
7457 and use it again (Bug#8435).
7458 * lisp.h (doprnt): Remove.
7459 * Makefile.in (base_obj): Remove doprnt.o.
7460 * deps.mk (doprnt.o): Remove.
7462 error: Print 32- and 64-bit integers portably (Bug#8435).
7463 Without this change, on typical 64-bit hosts error ("...%d...", N)
7464 was used to print both 32- and 64-bit integers N, which relied on
7466 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7468 * lisp.h (error, verror): Mark as printf-like functions.
7469 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7470 Report overflow in size calculations when allocating printf buffer.
7471 Do not truncate output string at its first null byte.
7472 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7473 Truncate the output at a character boundary, since vsnprintf does not
7475 * charset.c (check_iso_charset_parameter): Convert internal
7476 character to string before calling 'error', since %c now has the
7478 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7479 overflow when computing char to be passed to 'error'. Do not
7480 pass Lisp_Object to 'error'; pass the integer instead.
7481 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7482 formatted with plain %d.
7484 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7486 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7488 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7490 * xterm.c (x_catch_errors): Remove duplicate declaration.
7492 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7494 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7496 2011-04-10 Jim Meyering <meyering@redhat.com>
7498 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7499 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7500 return ssize_t not "int", and use size_t as the buffer length.
7501 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7502 * gnutls.h: Update declarations.
7503 * process.c (read_process_output): Use ssize_t, to match.
7504 (send_process): Likewise.
7506 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7508 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7510 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7512 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7513 Use unsigned char, to match FcChar8 type definition.
7515 * xterm.c (handle_one_xevent):
7516 * xmenu.c (create_and_show_popup_menu):
7517 * xselect.c (x_decline_selection_request)
7518 (x_reply_selection_request): Avoid type-punned deref of X events.
7520 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7522 Fix some uses of `int' instead of EMACS_INT.
7523 * search.c (string_match_1, fast_string_match)
7524 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7525 (scan_buffer, find_next_newline_no_quit)
7526 (find_before_next_newline, search_command, Freplace_match)
7527 (Fmatch_data): Make some `int' variables be EMACS_INT.
7529 * xdisp.c (display_count_lines): 3rd argument and return value now
7530 EMACS_INT. All callers changed.
7531 (pint2hrstr): Last argument is now EMACS_INT.
7533 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7534 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7535 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7536 (decode_coding_utf_16, decode_coding_emacs_mule)
7537 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7538 (decode_coding_ccl, decode_coding_charset)
7539 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7540 (decode_coding_iso_2022, decode_coding_emacs_mule)
7541 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7542 <char_offset, last_offset>: Declare EMACS_INT.
7543 (encode_coding_utf_8, encode_coding_utf_16)
7544 (encode_coding_emacs_mule, encode_invocation_designation)
7545 (encode_designation_at_bol, encode_coding_iso_2022)
7546 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7547 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7549 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7550 (encode_invocation_designation): Last argument P_NCHARS is now
7552 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7553 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7555 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7558 * ccl.c (Fccl_execute_on_string): Declare some variables
7561 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7563 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7565 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7567 * process.c (Fformat_network_address): Doc fix.
7569 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7571 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7573 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7575 * keyboard.c (read_char): Call Lisp function help-form-show,
7576 instead of using internal_with_output_to_temp_buffer.
7577 (Qhelp_form_show): New var.
7578 (syms_of_keyboard): Use DEFSYM macro.
7580 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7582 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7584 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7586 * process.c (Flist_processes): Remove to Lisp.
7587 (list_processes_1): Delete.
7589 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7591 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7593 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7595 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7597 Fix more problems found by GCC 4.6.0's static checks.
7599 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7601 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7603 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7605 * xdisp.c (vmessage): Mark as a printf-like function.
7607 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7609 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7611 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7612 printf-like functions.
7613 (tiff_load): Add casts to remove these marks before passing them
7614 to system-supplied API.
7616 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7618 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7619 This avoids several warnings with gcc -Wstrict-overflow.
7620 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7621 directly, rather than having caller test rule sign. This avoids
7622 some unnecessary tests.
7623 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7624 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7625 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7627 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7628 (xfont_open): Avoid unnecessary tests.
7630 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7632 * composite.h, composite.c (composition_gstring_put_cache):
7633 Use EMACS_INT, not int, for length.
7635 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7636 breaking out part of COMPOSITION_DECODE_RULE.
7637 (COMPOSITION_DECODE_RULE): Use it.
7638 * composite.c (get_composition_id): Remove unused local vars,
7639 by using the new macro.
7641 * textprop.c (set_text_properties_1): Change while to do-while,
7642 since the condition is always true at first.
7644 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7645 (interval_deletion_adjustment): Return unsigned value.
7648 * process.c (list_processes_1, create_pty, read_process_output):
7649 (exec_sentinel): Remove vars that were set but not used.
7650 (create_pty): Remove unnecessary "volatile"s.
7651 (Fnetwork_interface_info): Avoid possibility of int overflow.
7652 (read_process_output): Do adaptive read buffering even if carryover.
7653 (read_process_output): Simplify nbytes computation if buffered.
7655 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7657 * syntax.c (scan_words): Remove var that was set but not used.
7658 (update_syntax_table): Use unsigned instead of int.
7660 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7661 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7662 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7664 * print.c (print_error_message): Avoid int overflow.
7666 * font.c (font_list_entities): Redo for clarity,
7667 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7669 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7670 (font_score): Avoid potential overflow in diff calculation.
7672 * fns.c (substring_both): Remove var that is set but not used.
7673 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7675 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7677 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7678 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7679 can always succeed if overflow has undefined behavior.
7681 * search.c (boyer_moore, wordify): Remove vars set but not used.
7682 (wordify): Omit three unnecessary tests.
7684 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7685 All callers changed. This avoids the need for an unused var.
7687 * casefiddle.c (casify_region): Remove var that is set but not used.
7689 * dired.c (file_name_completion): Remove var that is set but not used.
7691 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7693 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7694 (Finsert_file_contents): Remove unnecessary code checking fd.
7696 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7697 Check for integer overflow on size calculations.
7699 * buffer.c (Fprevious_overlay_change): Remove var that is set
7702 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7703 Remove vars that are set but not used.
7704 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7705 (timer_check_2): Mark vars as initialized.
7707 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7709 * image.c (lookup_image): Remove var that is set but not used.
7710 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7712 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7713 that are set but not used.
7715 * xfns.c (make_invisible_cursor): Don't return garbage
7716 if XCreateBitmapFromData fails (Bug#8410).
7718 * xselect.c (x_get_local_selection, x_handle_property_notify):
7719 Remove vars that are set but not used.
7721 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7722 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7724 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7725 Remove var that is set but not used.
7726 (scroll_bar_windows_size): Now size_t, not int.
7727 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7730 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7731 (map_tty_color) [!defined MSDOS]: Likewise.
7733 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7735 * coding.c: Remove vars that are set but not used.
7736 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7737 All callers changed.
7738 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7739 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7740 (decode_coding_charset): Remove vars that are set but not used.
7742 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7743 that is set but not used.
7745 * print.c (print_object): Remove var that is set but not used.
7747 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7748 The gnulib version avoids calling malloc in the usual case,
7749 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7750 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7751 * filelock.c (current_lock_owner): Likewise.
7752 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7753 * sysdep.c: Include allocator.h, careadlinkat.h.
7754 (emacs_no_realloc_allocator): New static constant.
7755 (emacs_readlink): New function.
7756 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7757 ../lib/careadlinkat.h.
7759 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7761 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7762 first non-nil return value).
7764 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7766 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7767 if not defined (Bug#8403).
7769 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7771 * xdisp.c (display_count_lines): Remove parameter `start',
7772 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7773 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7774 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7775 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7776 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7777 and thereabouts. All callers changed.
7778 (get_per_char_metric): Remove parameter `f', unused since
7779 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7781 2011-04-02 Jim Meyering <meyering@redhat.com>
7783 do not dereference NULL upon failed strdup
7784 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7785 (ns_get_family): Likewise.
7787 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7789 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7791 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7793 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7796 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7798 Add lexical binding.
7800 * window.c (Ftemp_output_buffer_show): New fun.
7801 (Fsave_window_excursion):
7802 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7804 * lread.c (lisp_file_lexically_bound_p): New function.
7805 (Fload): Bind Qlexical_binding.
7806 (readevalloop): Remove `evalfun' arg.
7807 Bind Qinternal_interpreter_environment.
7808 (Feval_buffer): Bind Qlexical_binding.
7809 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7811 (syms_of_lread): Declare `lexical-binding'.
7813 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7815 * keyboard.c (eval_dyn): New fun.
7816 (menu_item_eval_property): Use it.
7818 * image.c (parse_image_spec): Use Ffunctionp.
7820 * fns.c (concat, mapcar1): Accept byte-code-functions.
7822 * eval.c (Fsetq): Handle lexical vars.
7823 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7824 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7825 (FletX, Flet): Obey lexical binding.
7826 (Fcommandp): Handle closures.
7827 (Feval): New `lexical' arg.
7828 (eval_sub): New function extracted from Feval. Use it almost
7829 everywhere where Feval was used. Look up vars in lexical env.
7831 (Ffunctionp): Move from subr.el.
7832 (Ffuncall): Handle closures.
7833 (apply_lambda): Remove `eval_flags'.
7834 (funcall_lambda): Handle closures and new byte-code-functions.
7835 (Fspecial_variable_p): New function.
7836 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7837 but without exporting it to Lisp.
7839 * doc.c (Fdocumentation, store_function_docstring):
7840 * data.c (Finteractive_form): Handle closures.
7842 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7845 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7847 (exec_byte_code): New function extracted from Fbyte_code to handle new
7848 calling convention for byte-code-functions. Add new byte-codes.
7850 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7852 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7854 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7856 * xdisp.c (redisplay_internal): Fix prototype.
7858 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7860 * xdisp.c (SCROLL_LIMIT): New macro.
7861 (try_scrolling): Use it when setting scroll_limit.
7862 Limit scrolling to 100 screen lines.
7863 (redisplay_window): Even when falling back on "recentering",
7864 position point in the window according to scroll-conservatively,
7865 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7867 (try_scrolling): When point is above the window, allow searching
7868 as far as scroll_max, or one screenful, to compute vertical
7869 distance from PT to the scroll margin position. This prevents
7870 try_scrolling from unnecessarily failing when
7871 scroll-conservatively is set to a value slightly larger than the
7872 window height. Clean up the case of PT below the margin at bottom
7873 of window: scroll_max can no longer be INT_MAX. When aggressive
7874 scrolling is in use, don't let point enter the opposite scroll
7875 margin as result of the scroll.
7876 (syms_of_xdisp) <scroll-conservatively>: Document the
7877 threshold of 100 lines for never-recentering scrolling.
7879 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7881 * dispextern.h (move_it_by_lines):
7882 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7883 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7884 (message_log_check_duplicate): Remove parameters `prev_bol' and
7885 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7886 (redisplay_internal): Remove parameter `preserve_echo_area',
7887 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7889 * indent.c (Fvertical_motion):
7890 * window.c (window_scroll_pixel_based, Frecenter):
7891 Don't pass `need_y_p' to `move_it_by_lines'.
7893 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7895 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7896 steal a few bits to be more compact.
7897 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7898 Remove unneeded casts.
7900 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7902 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7904 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7905 binding" message (bug#7967).
7907 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7909 Fix more problems found by GCC 4.6.0's static checks.
7911 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7912 Remove unused local var.
7914 * editfns.c (Fmessage_box): Remove unused local var.
7916 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7917 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7918 Omit unused local vars.
7919 * window.c (shrink_windows): Omit unused local var.
7920 * menu.c (digest_single_submenu): Omit unused local var.
7921 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7922 Omit unused local var.
7924 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7925 Don't assume string length fits in int.
7926 (keyremap_step, read_key_sequence): Use size_t for sizes.
7927 (read_key_sequence): Don't check last_real_key_start redundantly.
7929 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7930 instead of alloca (Bug#8344).
7932 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7933 (Fbacktrace_frame): Don't assume nframes fits in int.
7935 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7937 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7940 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7942 * cm.c (calccost): Turn while-do into do-while, for clarity.
7944 * keyboard.c (syms_of_keyboard): Use the same style as later
7945 in this function when indexing through an array. This also
7946 works around GCC bug 48267.
7948 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7950 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7952 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7953 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7955 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7956 This avoids undefined behavior on integer overflow, and is a bit
7957 more convenient anyway since it is compared to a size_t variable.
7959 Variadic C functions now count arguments with size_t, not int.
7960 This avoids an unnecessary limitation on 64-bit machines, which
7961 caused (substring ...) to crash on large vectors (Bug#8344).
7962 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7963 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7964 All variadic functions and their callers changed accordingly.
7965 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7966 * data.c (arith_driver, float_arith_driver): Likewise.
7967 * editfns.c (general_insert_function): Likewise.
7968 * eval.c (struct backtrace.nargs, interactive_p)
7969 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7970 (funcall_lambda, mark_backtrace): Likewise.
7971 * fns.c (concat): Likewise.
7972 * frame.c (x_set_frame_parameters): Likewise.
7973 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7974 0 if not found, not -1. All callers changed.
7976 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7977 (stack_copy_size): Now size_t, not int.
7978 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7980 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7982 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7983 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7984 All callers changed.
7986 * lisp.h (multibyte_char_to_unibyte):
7987 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7988 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7989 * character.h (CHAR_TO_BYTE8):
7990 * cmds.c (internal_self_insert):
7991 * editfns.c (general_insert_function):
7992 * keymap.c (push_key_description):
7993 * search.c (Freplace_match):
7994 * xdisp.c (message_dolog, set_message_1): All callers changed.
7996 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7998 * keyboard.c (safe_run_hook_funcall): New function.
7999 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8000 don't set the hook to nil, but remove the offending function instead.
8001 (Qcommand_hook_internal): Remove, unused.
8002 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8003 Vcommand_hook_internal.
8005 * eval.c (enum run_hooks_condition): Remove.
8006 (funcall_nil, funcall_not): New functions.
8007 (run_hook_with_args): Call each function through a `funcall' argument.
8008 Remove `cond' argument, now redundant.
8009 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8010 (Frun_hook_with_args_until_failure): Adjust accordingly.
8011 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8013 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8015 * dispextern.h (string_buffer_position): Remove declaration.
8017 * print.c (strout): Remove parameter `multibyte', unused since
8018 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8020 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8021 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8022 All callers changed.
8024 * w32.c (_wsa_errlist): Use braces for struct initializers.
8026 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8027 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8028 All callers changed.
8029 (string_buffer_position): Likewise. Also, make static (it's never
8030 used outside xdisp.c).
8031 (cursor_row_p): Remove parameter `w', unused since
8032 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8033 (decode_mode_spec): Remove parameter `precision', introduced during
8034 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8035 All callers changed.
8037 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8039 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8041 2011-03-27 Anders Lindgren <andlind@gmail.com>
8043 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8044 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8045 (ns_update_auto_hide_menu_bar): New functions.
8046 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8047 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8048 ns_constrain_all_frames.
8049 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8050 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8052 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8054 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8056 2011-03-27 Glenn Morris <rgm@gnu.org>
8058 * syssignal.h: Replace RETSIGTYPE with void.
8059 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8060 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8061 Replace SIGTYPE with void everywhere.
8062 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8063 * s/template.h (SIGTYPE): Remove commented out definition.
8065 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8067 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8068 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8070 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8072 * w32.c (read_unc_volume): Use parameter `henum', instead of
8073 global variable `wget_enum_handle'.
8075 * keymap.c (describe_vector): Remove parameters `indices' and
8076 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8077 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8079 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8081 * keyboard.c (timer_check): Remove parameter `do_it_now',
8082 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8083 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8084 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8086 * keyboard.c (read_char):
8087 * w32menu.c (w32_menu_display_help):
8088 * xmenu.c (show_help_event, menu_help_callback):
8089 Adjust calls to `show_help_echo'.
8091 * gtkutil.c (xg_maybe_add_timer):
8092 * keyboard.c (readable_events):
8093 * process.c (wait_reading_process_output):
8094 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8096 * insdel.c (adjust_markers_gap_motion):
8097 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8098 (gap_left, gap_right): Don't call it.
8100 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8102 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8103 incurred during fontification.
8105 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8107 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8108 (DEFVAR_PER_BUFFER): Don't pass it.
8110 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8111 (scrolling_window): Don't pass it.
8113 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8115 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8117 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8119 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8120 of variables specific to SELinux and computation of `encoded_absname'.
8122 * image.c (XPutPixel): Remove unused variable `height'.
8124 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8126 * unexw32.c (get_section_info): Remove unused variable `section'.
8128 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8129 (system_process_attributes): Remove unused variable `sess'.
8130 (sys_read): Remove unused variable `err'.
8132 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8133 (w32_wnd_proc): Remove unused variable `isdead'.
8134 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8135 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8136 (x_create_tip_frame): Remove unused variable `tem'.
8138 * w32inevt.c (w32_console_read_socket):
8139 Remove unused variable `no_events'.
8141 * w32term.c (x_draw_composite_glyph_string_foreground):
8142 Remove unused variable `width'.
8144 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8146 * w32term.c (x_set_glyph_string_clipping):
8147 Don't pass uninitialized region to CombineRgn.
8149 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8151 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8152 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8153 (Fx_close_connection): Remove unused variable `i'.
8155 * w32font.c (w32font_draw): Return number of glyphs.
8156 (w32font_open_internal): Remove unused variable `i'.
8157 (w32font_driver): Add missing initializer.
8159 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8160 (fill_in_menu): Remove unused variable `items_added'.
8162 * w32term.c (last_mouse_press_frame): Remove static global variable.
8163 (w32_clip_to_row): Remove unused variable `f'.
8164 (x_delete_terminal): Remove unused variable `i'.
8166 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8167 (NOTHING): Remove unused static global variable.
8168 (uniscribe_check_otf): Remove unused variable `table'.
8169 (uniscribe_font_driver): Add missing initializers.
8171 2011-03-23 Julien Danjou <julien@danjou.info>
8173 * term.c (Fsuspend_tty, Fresume_tty):
8174 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8175 * window.c (temp_output_buffer_show):
8176 * insdel.c (signal_before_change):
8177 * frame.c (Fhandle_switch_frame):
8178 * fileio.c (Fdo_auto_save):
8179 * emacs.c (Fkill_emacs):
8180 * editfns.c (save_excursion_restore):
8181 * cmds.c (internal_self_insert):
8182 * callint.c (Fcall_interactively):
8183 * buffer.c (Fkill_all_local_variables):
8184 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8186 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8187 unconditionally since it does the check itself.
8189 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8191 Fix more problems found by GCC 4.5.2's static checks.
8193 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8194 the first time through the loop, since we know p0 < p1 then.
8195 This also avoids a gcc -Wstrict-overflow warning.
8197 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8198 leading to a memory leak, possible in functions like
8199 load_charset_map_from_file that can allocate an unbounded number
8200 of objects (Bug#8318).
8202 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8203 that could (at least in theory) be that large.
8205 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8206 This is less likely to overflow, and avoids undefined behavior if
8207 overflow does occur. All callers changed. Use strtoul to scan
8208 for the unsigned long integer.
8209 (pint2hrstr): Simplify and tune code slightly.
8210 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8212 * scroll.c (do_scrolling): Work around GCC bug 48228.
8213 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8215 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8216 This also avoids a warning with gcc -Wstrict-overflow.
8217 (validate_x_resource_name): Simplify count usage.
8218 This also avoids a warning with gcc -Wstrict-overflow.
8220 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8223 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8225 * process.c (Fmake_network_process): Use socklen_t, not int,
8226 where POSIX says socklen_t is required in portable programs.
8227 This fixes a porting bug on hosts like 64-bit HP-UX, where
8228 socklen_t is wider than int (Bug#8277).
8229 (Fmake_network_process, server_accept_connection):
8230 (wait_reading_process_output, read_process_output):
8233 * process.c: Rename or move locals to avoid shadowing.
8234 (list_processes_1, Fmake_network_process):
8235 (read_process_output_error_handler, exec_sentinel_error_handler):
8236 Rename or move locals.
8237 (Fmake_network_process): Define label "retry_connect" only if needed.
8238 (Fnetwork_interface_info): Fix pointer signedness.
8239 (process_send_signal): Add cast to avoid pointer signedness problem.
8240 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8241 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8243 Make tparam.h and terminfo.c consistent.
8244 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8245 Include tparam.h instead, since it declares them.
8246 * cm.h (PC): Remove extern decl; tparam.h now does this.
8247 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8248 * terminfo.c: Include tparam.h, to check interfaces.
8249 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8250 (tparam): Adjust signature to match interface in tparam.h;
8251 this removes some undefined behavior. Check that outstring and len
8252 are zero, which they always are with Emacs.
8253 * tparam.h (PC, BC, UP): New extern decls.
8255 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8256 (xftfont_open): Rename locals to avoid shadowing.
8258 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8259 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8260 (OTF_TAG_SYM): Omit macro if not needed.
8261 (ftfont_list): Remove unused local.
8262 (get_adstyle_property, ftfont_pattern_entity):
8263 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8264 Rename locals to avoid shadowing.
8266 * xfont.c (xfont_list_family): Mark var as initialized.
8268 * xml.c (make_dom): Now static.
8270 * composite.c (composition_compute_stop_pos): Rename local to
8272 (composition_reseat_it): Remove unused locals.
8273 (find_automatic_composition, composition_adjust_point): Likewise.
8274 (composition_update_it): Mark var as initialized.
8275 (find_automatic_composition): Mark vars as initialized,
8276 with a FIXME (Bug#8290).
8278 character.h: Rename locals to avoid shadowing.
8279 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8280 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8281 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8282 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8285 * textprop.c (property_change_between_p): Remove; unused.
8287 * intervals.c (interval_start_pos): Now static.
8289 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8291 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8292 Rename locals to avoid shadowing.
8294 * sound.c (wav_play, au_play, Fplay_sound_internal):
8295 Fix pointer signedness.
8296 (alsa_choose_format): Remove unused local var.
8297 (wav_play): Initialize a variable to 0, to prevent undefined
8298 behavior (Bug#8278).
8300 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8302 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8304 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8305 clobbering (Bug#8298).
8306 * sysdep.c (sys_subshell): Likewise.
8307 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8309 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8310 This should get cleaned up, so that child_setup has the
8311 same signature on all platforms.
8313 * callproc.c (call_process_cleanup): Now static.
8314 (relocate_fd): Rename locals to avoid shadowing.
8316 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8318 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8319 not to be necessary, and produces flickering.
8321 2011-03-20 Glenn Morris <rgm@gnu.org>
8323 * config.in: Remove file.
8325 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8327 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8328 are now in src/globals.h.
8329 (syms_of_minibuf): Remove spurious & from previous change.
8331 2011-03-20 Leo Liu <sdl.web@gmail.com>
8333 * minibuf.c (completing-read-function): New variable.
8334 (completing-read-default): Rename from completing-read.
8335 (completing-read): Call completing-read-function.
8337 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8339 * xfaces.c (Fx_load_color_file):
8340 Read color file from absolute filename (bug#8250).
8342 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8344 * makefile.w32-in: Update dependencies.
8346 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8348 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8350 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8352 Fix more problems found by GCC 4.5.2's static checks.
8354 * process.c (make_serial_process_unwind, send_process_trap):
8355 (sigchld_handler): Now static.
8357 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8358 That way, the code declares only the vars that it needs.
8359 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8360 * s/cygwin.h (PTY_ITERATION): Likewise.
8361 * s/darwin.h (PTY_ITERATION): Likewise.
8362 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8364 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8365 * process.c (allocate_pty): Don't declare stb unless it's needed.
8367 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8368 (CONSTANTLIM): Remove; unused.
8369 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8370 Define only if needed.
8372 * unexelf.c (unexec): Name an expression,
8373 to avoid gcc -Wbad-function-cast warning.
8374 Use a different way to cause a compilation error if anyone uses
8375 n rather than nn, a way that does not involve shadowing.
8376 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8378 * deps.mk (unexalpha.o): Remove; unused.
8380 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8381 * unexec.h: New file.
8382 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8383 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8385 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8386 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8387 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8388 Change as necessary to match prototype in unexec.h.
8390 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8392 (back_comment, skip_chars): Mark vars as initialized.
8394 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8395 Rename locals to avoid shadowing.
8397 * lread.c (read1): Rewrite so as not to use empty "else".
8398 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8400 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8402 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8403 warning when compiling print.c.
8405 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8406 instead of using an uninitialized var.
8407 (font_sort_entities): Mark var as initialized.
8409 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8411 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8412 pointers to constants.
8413 (font_parse_fcname): Remove unused vars.
8414 (font_delete_unmatched): Now static.
8415 (font_get_spec): Remove; unused.
8416 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8417 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8418 Rename or move locals to avoid shadowing.
8420 * fns.c (require_nesting_list, require_unwind): Now static.
8421 (Ffillarray): Rename locals to avoid shadowing.
8423 * floatfns.c (domain_error2): Define only if needed.
8424 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8426 * alloc.c (mark_backtrace): Move decl from here ...
8427 * lisp.h: ... to here, so that it can be checked.
8429 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8430 (Fdefvar): Rewrite so as not to use empty "else".
8431 (lisp_indirect_variable): Name an expression,
8432 to avoid gcc -Wbad-function-cast warning.
8433 (Fdefvar): Rename locals to avoid shadowing.
8435 * callint.c (quotify_arg, quotify_args): Now static.
8436 (Fcall_interactively): Rename locals to avoid shadowing.
8437 Use const pointer when appropriate.
8439 * lisp.h (get_system_name, get_operating_system_release):
8440 Move decls here, to check interfaces.
8441 * process.c (get_operating_system_release): Move decl to lisp.h.
8442 * xrdb.c (get_system_name): Likewise.
8443 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8444 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8445 some of which prompt warnings from gcc -Wbad-function-cast.
8446 (Fformat_time_string, Fencode_time, Finsert_char):
8447 (Ftranslate_region_internal, Fformat):
8448 Rename or remove local vars to avoid shadowing.
8449 (Ftranslate_region_internal): Mark var as initialized.
8451 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8454 * lisp.h (eassert): Check that the argument compiles, even if
8455 ENABLE_CHECKING is not defined.
8457 * data.c (Findirect_variable): Name an expression, to avoid
8458 gcc -Wbad-function-cast warning.
8459 (default_value, arithcompare, arith_driver, arith_error): Now static.
8460 (store_symval_forwarding): Rename local to avoid shadowing.
8461 (Fmake_variable_buffer_local, Fmake_local_variable):
8462 Mark variables as initialized.
8463 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8465 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8466 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8467 Rename locals to avoid shadowing.
8468 (mark_stack): Move local variables into the #ifdef region where
8470 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8471 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8473 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8474 (GC_STRING_CHARS): Remove; not used.
8475 (Fmemory_limit): Cast sbrk's returned value to char *.
8477 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8478 avoids undefined behavior in theory.
8480 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8482 Use functions, not macros, for up- and down-casing (Bug#8254).
8483 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8484 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8485 to use the following functions instead of these macros.
8486 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8487 EMACS_INT, since callers assume the returned value fits in int.
8488 (upcase1): Likewise, for UPCASE_TABLE.
8489 (uppercasep, lowercasep, upcase): New static inline functions.
8490 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8491 the race-condition problem in the old DOWNCASE.
8493 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8494 Rename locals to avoid shadowing.
8495 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8496 (regex_compile, re_search_2, re_match_2_internal):
8497 Remove unused local vars.
8498 (FREE_VAR): Rewrite so as not to use empty "else",
8499 which gcc can warn about.
8500 (regex_compile, re_match_2_internal): Mark locals as initialized.
8501 (RETALLOC_IF): Define only if needed.
8502 (WORDCHAR_P): Likewise. This one is never needed, but is used
8503 only in a comment talking about a compiler bug, so put inside
8504 the #if 0 of that comment.
8505 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8506 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8509 * search.c (boyer_moore): Rename locals to avoid shadowing.
8510 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8511 (PREV_CHAR_BOUNDARY): Likewise.
8513 * search.c (simple_search): Remove unused var.
8515 * dired.c (compile_pattern): Move decl from here ...
8516 * lisp.h: ... to here, so that it can be checked.
8517 (struct re_registers): New forward decl.
8519 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8521 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8523 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8524 Rename locals to avoid shadowing.
8525 (Fvertical_motion): Mark locals as initialized.
8527 * casefiddle.c (casify_object, casify_region): Now static.
8528 (casify_region): Mark local as initialized.
8530 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8532 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8533 New macros, so that the caller can use some names other than
8534 gcpro1, gcpro2, etc.
8535 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8537 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8538 argument, for consistency with GCPRO2_VAR, etc: it is now the
8539 prefix of the variable, not the variable itself. All uses
8541 * dired.c (directory_files_internal, file_name_completion):
8542 Rename locals to avoid shadowing.
8544 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8545 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8546 dired.c's scmp function, had undefined behavior.
8547 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8548 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8549 * buffer.h: ... to here, because these macros use current_buffer,
8550 and the new implementation with inline functions needs to have
8551 current_buffer in scope now, rather than later when the macros
8553 (downcase, upcase1): New static inline functions.
8554 (DOWNCASE, UPCASE1): Reimplement using these functions.
8555 This avoids undefined behavior in expressions like
8556 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8557 from race conditions in accessing the global variables
8558 case_temp1 and case_temp2.
8559 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8560 * lisp.h (case_temp1, case_temp2): Remove their decls.
8561 * character.h (ASCII_CHAR_P): Move from here ...
8562 * lisp.h: ... to here, so that the inline functions mentioned
8565 * dired.c (directory_files_internal_unwind): Now static.
8567 * fileio.c (file_name_as_directory, directory_file_name):
8568 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8570 (file_name_as_directory): Use const pointers when appropriate.
8571 (Fexpand_file_name): Likewise. In particular, newdir might
8572 point at constant storage, so make it a const pointer.
8573 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8574 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8576 (Fset_file_times, Finsert_file_contents, auto_save_error):
8577 Rename locals to avoid shadowing.
8579 * minibuf.c (choose_minibuf_frame_1): Now static.
8580 (Ftry_completion, Fall_completions): Rename or remove locals
8583 * marker.c (bytepos_to_charpos): Remove; unused.
8585 * lisp.h (verify_bytepos, count_markers): New decls,
8586 so that gcc does not warn that these functions aren't declared.
8588 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8589 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8590 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8591 (copy_text): Remove unused local var.
8593 * filelock.c (within_one_second): Now static.
8594 (lock_file_1): Rename local to avoid shadowing.
8596 * buffer.c (fix_overlays_before): Mark locals as initialized.
8597 (fix_start_end_in_overlays): Likewise. This function should be
8598 simplified by using pointers-to-pointers, but that's a different
8600 (switch_to_buffer_1): Now static.
8601 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8602 (report_overlay_modification): Rename locals to avoid shadowing.
8604 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8605 Fix pointer signedness issue.
8606 (sys_subshell): Mark local as volatile if checking for lint,
8607 to suppress a gcc -Wclobbered warning that does not seem to be right.
8608 (MAXPATHLEN): Define only if needed.
8610 * process.c (serial_open, serial_configure): Move decls from here ...
8611 * systty.h: ... to here, so that they can be checked.
8613 * fns.c (get_random, seed_random): Move extern decls from here ...
8614 * lisp.h: ... to here, so that they can be checked.
8616 * sysdep.c (reset_io): Now static.
8617 (wait_for_termination_signal): Remove; unused.
8619 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8620 (copy_keymap_item, append_key, push_text_char_description):
8622 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8623 (DENSE_TABLE_SIZE): Remove; unused.
8624 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8625 (describe_map_tree):
8626 Rename locals to avoid shadowing.
8628 * keyboard.c: Declare functions static if they are not used elsewhere.
8629 (echo_char, echo_dash, cmd_error, top_level_2):
8630 (poll_for_input, handle_async_input): Now static.
8631 (read_char, kbd_buffer_get_event, make_lispy_position):
8632 (make_lispy_event, make_lispy_movement, apply_modifiers):
8633 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8634 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8635 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8636 (read_key_sequence, read_char): Mark locals as initialized.
8637 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8639 * keyboard.h (make_ctrl_char): New decl.
8640 (mark_kboards): Move decl here ...
8641 * alloc.c (mark_kboards): ... from here.
8643 * lisp.h (force_auto_save_soon): New decl.
8645 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8646 (DEFINE_DUMMY_FUNCTION): New macro.
8647 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8649 (main): Add casts to avoid warnings
8650 if GCC considers string literals to be constants.
8652 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8654 * dbusbind.c: Pointer signedness fixes.
8655 (xd_signature, xd_append_arg, xd_initialize):
8656 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8657 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8658 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8659 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8661 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8662 if GCC considers string literals to be constants.
8663 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8665 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8667 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8668 (print_preprocess, print_object): New macro to fix last change.
8670 * print.c (print_preprocess): Don't forget font objects.
8672 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8674 * emacs.c (USAGE3): Doc fixes.
8676 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8678 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8681 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8683 * lisp.h (VWindow_system, Qfile_name_history):
8684 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8685 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8686 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8688 * w32select.c: Don't #include "keyboard.h".
8689 (run_protected): Add extern declaration for waiting_for_input.
8691 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8692 * w32console.c (detect_input_pending, read_input_pending)
8693 (encode_terminal_code):
8694 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8695 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8696 (w32_system_caret_y, Qfile_name_history):
8697 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8698 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8699 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8700 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8701 * w32proc.c (Qlocal, report_file_error):
8702 * w32term.c (Vwindow_system, updating_frame):
8703 * w32uniscribe.c (initialized, uniscribe_font_driver):
8704 Remove unneeded extern declarations.
8706 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8708 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8710 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8712 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8713 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8714 These macros can no longer be used for assignment.
8716 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8717 Assign struct members directly, instead of using BUF_BEGV etc.
8718 (record_buffer_markers, fetch_buffer_markers): New functions for
8719 recording and fetching special buffer markers.
8720 (set_buffer_internal_1, set_buffer_temp): Use them.
8722 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8724 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8726 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8727 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8729 * xdisp.c (hscroll_window_tree):
8730 (reconsider_clip_changes): Use PT instead of BUF_PT.
8732 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8734 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8735 $(EMACS_ROOT)/lib/intprops.h.
8737 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8739 Fix more problems found by GCC 4.5.2's static checks.
8741 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8742 to unsigned char * to avoid compiler diagnostic.
8743 (xg_free_frame_widgets): Make it clear that a local variable is
8744 needed only if USE_GTK_TOOLTIP.
8745 (gdk_window_get_screen): Make it clear that this macro is needed
8746 only if USE_GTK_TOOLTIP.
8747 (int_gtk_range_get_value): New function, which avoids a diagnostic
8748 from gcc -Wbad-function-cast.
8749 (xg_set_toolkit_scroll_bar_thumb): Use it.
8750 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8751 diagnostic from gcc -Wbad-function-cast.
8752 (get_utf8_string, xg_get_file_with_chooser):
8753 Rename locals to avoid shadowing.
8754 (create_dialog): Move locals to avoid shadowing.
8756 * xgselect.c (xg_select): Remove unused var.
8758 * image.c (four_corners_best): Mark locals as initialized.
8759 (gif_load): Initialize transparent_p to zero (Bug#8238).
8760 Mark another local as initialized.
8761 (my_png_error, my_error_exit): Mark with NO_RETURN.
8763 * image.c (clear_image_cache): Now static.
8764 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8765 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8766 (x_edge_detection): Remove unnecessary cast that
8767 gcc -Wbad-function-cast diagnoses.
8768 (gif_load): Fix pointer signedness.
8769 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8770 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8772 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8774 Improve quality of tests for time stamp overflow.
8775 For example, without this patch (encode-time 0 0 0 1 1
8776 1152921504606846976) returns the obviously-bogus value (-948597
8777 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8778 reports time overflow. See
8779 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8780 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8781 * editfns.c: Include limits.h and intprops.h.
8782 (TIME_T_MIN, TIME_T_MAX): New macros.
8783 (time_overflow): Move earlier, to before first use.
8784 (hi_time, lo_time): New functions, for an accurate test for
8786 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8787 (Fget_internal_run_time): Don't assume time_t fits in int.
8788 (make_time): Use list2 instead of Fcons twice.
8789 (Fdecode_time): More accurate test for out-of-range times.
8790 (check_tm_member): New function.
8791 (Fencode_time): Use it, to test for out-of-range times.
8792 (lisp_time_argument): Don't rely on undefined left-shift and
8793 right-shift behavior when checking for time stamp overflow.
8795 * editfns.c (time_overflow): New function, refactoring common code.
8796 (Fformat_time_string, Fdecode_time, Fencode_time):
8797 (Fcurrent_time_string): Use it.
8799 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8800 * dired.c (make_time): Move to ...
8801 * editfns.c (make_time): ... here.
8802 * systime.h: Note the move.
8804 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8806 * fringe.c (update_window_fringes): Remove unused variables.
8808 * unexmacosx.c (copy_data_segment): Also copy __got section.
8811 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8813 * termcap.c [MSDOS]: Include "msdos.h".
8814 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8815 Constify `char *' arguments and their references according to
8816 prototypes in tparam.h.
8818 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8820 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8821 Adapt all references accordingly.
8823 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8825 2011-03-11 Tom Tromey <tromey@redhat.com>
8827 * buffer.c (syms_of_buffer): Remove obsolete comment.
8829 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8831 * termhooks.h (encode_terminal_code): Declare prototype.
8833 * msdos.c (encode_terminal_code): Don't declare prototype.
8835 * term.c (encode_terminal_code): Now external again, used by
8836 w32console.c and msdos.c.
8838 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8839 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8841 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8843 Fix some minor problems found by GCC 4.5.2's static checks.
8845 * fringe.c (update_window_fringes): Mark locals as initialized
8847 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8849 * alloc.c (mark_fringe_data): Move decl from here ...
8850 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8851 to check its interface.
8852 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8854 * fontset.c (free_realized_fontset): Now static.
8855 (Fset_fontset_font): Rename local to avoid shadowing.
8856 (fontset_font): Mark local as initialized.
8857 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8859 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8861 * xselect.c (x_disown_buffer_selections): Remove; not used.
8862 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8863 (x_own_selection, Fx_disown_selection_internal): Rename locals
8865 (x_handle_dnd_message): Remove local to avoid shadowing.
8867 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8868 so that the caller can use some name other than gcpro1.
8869 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8870 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8871 (Fx_backspace_delete_keys_p):
8872 Use them to avoid shadowing, and rename vars to avoid shadowing.
8873 (x_decode_color, x_set_name, x_window): Now static.
8874 (Fx_create_frame): Add braces to silence GCC warning.
8875 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8876 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8877 Remove unused locals.
8878 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8879 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8880 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8883 * xterm.h (x_mouse_leave): New decl.
8885 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8886 Remove unused functions.
8887 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8888 (x_calc_absolute_position): Now static.
8889 (XTread_socket): Don't define label "out" unless it's used.
8890 Don't declare local "event" unless it's used.
8891 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8892 unless they are used.
8893 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8894 (x_fatal_error_signal): Remove; not used.
8895 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8896 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8897 (x_error_catcher, x_connection_closed, x_error_handler):
8898 (x_error_quitter, xembed_send_message, x_iconify_frame):
8899 (my_log_handler): Rename locals to avoid shadowing.
8900 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8901 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8903 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8904 Rename or move locals to avoid shadowing.
8905 (tty_defined_color, merge_face_heights): Now static.
8906 (free_realized_faces_for_fontset): Remove; not used.
8907 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8908 does not deduce is never used uninitialized.
8909 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8910 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8912 * terminal.c (store_terminal_param): Now static.
8914 * xmenu.c (menu_highlight_callback): Now static.
8915 (set_frame_menubar): Remove unused local.
8916 (xmenu_show): Rename parameter to avoid shadowing.
8917 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8918 since they might point to immutable storage.
8919 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8920 since it's unused otherwise.
8922 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8923 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8924 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8925 avoids a gcc -Wuninitialized diagnostic.
8926 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8927 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8928 does not deduce are never used uninitialized.
8930 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8932 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8933 * window.c (window_loop, size_window):
8934 (run_window_configuration_change_hook, enlarge_window): Likewise.
8936 * window.c (display_buffer): Now static.
8937 (size_window): Mark variables that gcc -Wuninitialized
8938 does not deduce are never used uninitialized.
8939 * window.h (check_all_windows): New decl, to forestall
8940 gcc -Wmissing-prototypes diagnostic.
8941 * dispextern.h (bidi_dump_cached_states): Likewise.
8943 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8945 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8947 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8948 and to avoid gcc -Wuninitialized warning.
8949 (load_charset_map): Mark variables that gcc -Wuninitialized
8950 does not deduce are never used uninitialized.
8951 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8953 * coding.c (coding_set_source, coding_set_destination):
8954 Use "else { /* comment */ }" rather than "else /* comment */;"
8955 for clarity, and to avoid gcc -Wempty-body warning.
8956 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8957 a block, when the outer 'i' will do.
8958 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8959 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8960 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8961 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8962 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8963 Rename locals to avoid shadowing.
8964 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8965 * coding.c (emacs_mule_char, encode_invocation_designation):
8966 Now static, since they're not used elsewhere.
8967 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8968 (decode_coding_object, encode_coding_object, detect_coding_system):
8969 (decode_coding_emacs_mule): Mark variables that gcc
8970 -Wuninitialized does not deduce are never used uninitialized.
8971 (detect_coding_iso_2022): Initialize a local variable that might
8972 be used uninitialized. Leave a FIXME because it's not clear that
8973 this initialization is needed. (Bug#8211)
8974 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8975 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8976 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8977 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8978 Remove unused macros.
8980 * category.c (hash_get_category_set): Remove unused local var.
8981 (copy_category_table): Now static, since it's not used elsewhere.
8982 * character.c (string_count_byte8): Likewise.
8984 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8985 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8987 * chartab.c (copy_sub_char_table): Now static, since it's not used
8989 (sub_char_table_ref_and_range, char_table_ref_and_range):
8990 Rename locals to avoid shadowing.
8991 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8993 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8994 (BIDI_BOB): Remove unused macro.
8996 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8997 deduce are never used uninitialized.
8998 * term.c (encode_terminal_code): Likewise.
9000 * term.c (encode_terminal_code): Now static. Remove unused local.
9002 * tparam.h: New file.
9003 * term.c, tparam.h: Include it.
9004 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9005 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9006 Move these decls to tparam.h, and make them agree with what
9007 is actually in tparam.c. The previous trick of using incompatible
9008 decls in different modules does not conform to the C standard.
9009 All callers of tparam changed to use tparam's actual API.
9010 * tparam.c (tparam1, tparam, tgoto):
9011 Use const pointers where appropriate.
9013 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9014 * cm.h (struct cm): Likewise.
9015 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9016 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9017 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9018 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9019 (turn_on_face, init_tty): Likewise.
9020 * termchar.h (struct tty_display_info): Likewise.
9022 * term.c (term_mouse_position): Rename local to avoid shadowing.
9024 * alloc.c (mark_ttys): Move decl from here ...
9025 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9027 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9029 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9031 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9033 * search.c (compile_pattern_1): Remove argument regp, unused since
9034 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9035 (compile_pattern): Don't pass it.
9037 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9039 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9040 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9042 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9044 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9046 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9047 gdk_window_get_screen, gdk_window_get_geometry,
9048 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9049 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9050 (xg_get_pixbuf_from_pixmap): New function.
9051 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9052 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9053 Call xg_get_pixbuf_from_pixmap instead of
9054 gdk_pixbuf_get_from_drawable.
9055 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9056 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9057 (xg_check_special_colors): Use GtkStyleContext and its functions
9059 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9060 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9061 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9062 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9063 Call gtk_widget_get_preferred_size.
9064 (xg_frame_resized): gdk_window_get_geometry only takes 5
9066 (xg_win_to_widget, xg_event_is_for_menubar):
9067 Call gdk_x11_window_lookup_for_display.
9068 (xg_set_widget_bg): New function.
9069 (delete_cb): New function.
9070 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9071 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9072 (xg_set_background_color): Call xg_set_widget_bg.
9073 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9074 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9075 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9076 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9078 (update_frame_tool_bar): Call gtk_widget_hide.
9079 (xg_initialize): Use GDK_KEY_g.
9081 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9083 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9085 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9086 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9087 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9089 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9091 * w32xfns.c (select_palette): Check success of RealizePalette against
9092 GDI_ERROR, not zero.
9094 See ChangeLog.11 for earlier changes.
9100 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9102 This file is part of GNU Emacs.
9104 GNU Emacs is free software: you can redistribute it and/or modify
9105 it under the terms of the GNU General Public License as published by
9106 the Free Software Foundation, either version 3 of the License, or
9107 (at your option) any later version.
9109 GNU Emacs is distributed in the hope that it will be useful,
9110 but WITHOUT ANY WARRANTY; without even the implied warranty of
9111 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9112 GNU General Public License for more details.
9114 You should have received a copy of the GNU General Public License
9115 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.