1 2011-06-19 Paul Eggert <eggert@cs.ucla.edu>
3 * lread.c (invalid_syntax): Omit length argument.
4 All uses changed. This doesn't fix a bug, but it simplifies the
5 code away from its former Hollerith-constant appearance, and it's
6 one less 'int' to worry about when looking at integer-overflow issues.
8 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9 This didn't break anything, but it didn't help either.
10 It's confusing to put a bogus integer in a place where the actual
11 value does not matter.
12 (LIST_END_P): Remove unused macro and its bogus comment.
13 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
15 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
17 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
18 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
20 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
21 We prefer signed types, and the value cannot exceed the EMACS_INT
22 range anyway (because otherwise the length would not be representable).
23 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
24 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
25 This avoids a GCC warning when WIDE_EMACS_INT.
27 * indent.c (sane_tab_width): New function.
28 (current_column, scan_for_column, Findent_to, position_indentation)
29 (compute_motion): Use it. This is just for clarity.
30 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
32 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
34 * lisp.h (lint_assume): New macro.
35 * composite.c (composition_gstring_put_cache):
36 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
38 * editfns.c, insdel.c:
39 Omit unnecessary forward decls, to simplify future changes.
41 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
43 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
45 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
46 Use much-faster test for byte-length change.
47 Don't assume string byte-length fits in 'int'.
48 Check that character arg fits in 'int'.
49 (mapcar1): Declare byte as byte, for clarity.
51 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
53 * fns.c (concat): Catch string overflow earlier.
54 Do not rely on integer wraparound.
56 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
58 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
60 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
61 * xdisp.c (forward_to_next_line_start)
62 (back_to_previous_visible_line_start)
63 (reseat_at_next_visible_line_start, next_element_from_buffer):
64 Don't arbitrarily truncate the value of 'selective' to int.
66 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
68 * composite.c: Don't truncate sizes to 'int'.
69 (composition_gstring_p, composition_reseat_it)
70 (composition_adjust_point): Use EMACS_INT, not int.
71 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
72 not EMACS_UINT, for indexes.
74 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
76 * buffer.c: Include <verify.h>.
77 (struct sortvec.priority, struct sortstr.priority):
78 Now EMACS_INT, not int.
79 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
80 (struct sortstr.size, record_overlay_string)
81 (struct sortstrlist.size, struct sortlist.used):
82 Don't truncate size to int.
83 (record_overlay_string): Check for size-calculation overflow.
84 (init_buffer_once): Check at compile-time, not run-time.
86 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
88 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
89 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
90 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
92 Improve buffer-overflow checking (Bug#8873).
93 * fileio.c (Finsert_file_contents):
94 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
95 Remove the old (too-loose) buffer overflow checks.
96 They weren't needed, since make_gap checks for buffer overflow.
97 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
98 The old code merely checked for Emacs fixnum overflow, and relied
99 on undefined (wraparound) behavior. The new code avoids undefined
100 behavior, and also checks for ptrdiff_t and/or size_t overflow.
102 * editfns.c (Finsert_char): Don't dump core with very negative counts.
103 Tune. Don't use wider integers than needed. Don't use alloca.
104 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
106 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
108 * insdel.c, lisp.h (buffer_overflow): New function.
109 (insert_from_buffer_1, replace_range, replace_range_2):
110 * insdel.c (make_gap_larger):
111 * editfns.c (Finsert_char):
112 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
114 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
116 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
118 Integer overflow and signedness fixes (Bug#8873).
120 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
121 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
123 * fileio.c: Don't assume EMACS_INT fits in off_t.
124 (emacs_lseek): New static function.
125 (Finsert_file_contents, Fwrite_region): Use it.
126 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
128 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
130 * fns.c: Don't overflow int when computing a list length.
131 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
132 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
133 truncation on 64-bit hosts. Check for QUIT every
134 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
135 faster and is responsive enough.
136 (Flength): Report an error instead of overflowing an integer.
137 (Fsafe_length): Return a float if the value is not representable
138 as a fixnum. This shouldn't happen except in contrived situations.
139 (Fnthcdr, Fsort): Don't assume list length fits in int.
140 (Fcopy_sequence): Don't assume vector length fits in int.
142 * alloc.c: Check that resized vectors' lengths fit in fixnums.
143 (header_size, word_size): New constants.
144 (allocate_vectorlike): Don't check size overflow here.
145 (allocate_vector): Check it here instead, since this is the only
146 caller of allocate_vectorlike that could cause overflow.
147 Check that the new vector's length is representable as a fixnum.
149 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
150 The previous code was bogus. For example, next_almost_prime (32)
151 returned 39, which is undesirable as it is a multiple of 3; and
152 next_almost_prime (24) returned 25, which is a multiple of 5 so
153 why was the code bothering to check for multiples of 7?
155 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
157 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
159 Variadic C functions now count arguments with ptrdiff_t.
160 This partly undoes my 2011-03-30 change, which replaced int with size_t.
161 Back then I didn't know that the Emacs coding style prefers signed int.
162 Also, in the meantime I found a few more instances where arguments
163 were being counted with int, which may truncate counts on 64-bit
164 machines, or EMACS_INT, which may be unnecessarily wide.
165 * lisp.h (struct Lisp_Subr.function.aMANY)
166 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
167 Arg counts are now ptrdiff_t, not size_t.
168 All variadic functions and their callers changed accordingly.
169 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
170 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
171 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
172 * callint.c (Fcall_interactively): Check arg count for overflow,
173 to avoid potential buffer overrun. Use signed char, not 'int',
174 for 'varies' array, so that we needn't bother to check its size
175 calculation for overflow.
176 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
177 * eval.c (apply_lambda):
178 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
179 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
180 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
182 * callint.c (Fcall_interactively): Don't use index var as event count.
184 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
185 * mem-limits.h (SIZE): Remove; no longer used.
187 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
189 Remove unnecessary casts.
190 * xterm.c (x_term_init):
191 * xfns.c (x_set_border_pixel):
192 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
193 These aren't needed now that we assume ANSI C.
195 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
196 It's more likely to cause problems (due to unsigned overflow)
199 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
201 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
203 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
205 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
207 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
209 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
211 GLYPH_CODE_FACE returns EMACS_INT, not int.
212 * dispextern.h (merge_faces):
213 * xfaces.c (merge_faces):
214 * xdisp.c (get_next_display_element, next_element_from_display_vector):
215 Don't assume EMACS_INT fits in int.
217 * character.h (CHAR_VALID_P): Remove unused parameter.
218 * fontset.c, lisp.h, xdisp.c: All uses changed.
220 * editfns.c (Ftranslate_region_internal): Omit redundant test.
222 * fns.c (concat): Minor tuning based on overflow analysis.
223 This doesn't fix any bugs. Use int to hold character, instead
224 of constantly refetching from Emacs object. Use XFASTINT, not
225 XINT, for value known to be a character. Don't bother comparing
226 a single byte to 0400, as it's always less.
228 * floatfns.c (Fexpt):
229 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
231 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
234 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
236 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
237 Without this fix, on a 64-bit host (aset S 0 4294967386) would
238 incorrectly succeed when S was a string, because 4294967386 was
239 truncated before it was used.
241 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
242 Otherwise, an out-of-range integer could cause undefined behavior
245 * composite.c: Use int, not EMACS_INT, for characters.
246 (fill_gstring_body, composition_compute_stop_pos): Use int, not
247 EMACS_INT, for values that are known to be in character range.
248 This doesn't fix any bugs but is the usual style inside Emacs and
249 may generate better code on 32-bit machines.
251 Make sure a 64-bit char is never passed to ENCODE_CHAR.
252 This is for reasons similar to the recent CHAR_STRING fix.
253 * charset.c (Fencode_char): Check that character arg is actually
254 a character. Pass an int to ENCODE_CHAR.
255 * charset.h (ENCODE_CHAR): Verify that the character argument is no
256 wider than 'int', as a compile-time check to prevent future regressions
259 * character.c (char_string): Remove unnecessary casts.
261 Make sure a 64-bit char is never passed to CHAR_STRING.
262 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
263 by silently ignoring the top 32 bits, allowing some values
264 that were far too large to be valid characters.
265 * character.h: Include <verify.h>.
266 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
267 arguments are no wider than unsigned, as a compile-time check
268 to prevent future regressions in this area.
270 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
271 (Fsubst_char_in_region):
273 * xdisp.c (decode_mode_spec_coding):
274 Adjust to CHAR_STRING's new requirement.
275 * editfns.c (Finsert_char, Fsubst_char_in_region):
276 * fns.c (concat): Check that character args are actually
277 characters. Without this test, these functions did the wrong
278 thing with wildly out-of-range values on 64-bit hosts.
280 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
281 These casts should not be needed on 32-bit hosts, either.
282 * keyboard.c (read_char):
283 * lread.c (Fload): Remove casts to unsigned.
285 * lisp.h (UNSIGNED_CMP): New macro.
286 This fixes comparison bugs on 64-bit hosts.
287 (ASCII_CHAR_P): Use it.
288 * casefiddle.c (casify_object):
289 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
290 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
291 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
292 * dispextern.h (FACE_FROM_ID):
293 * keyboard.c (read_char): Use UNSIGNED_CMP.
295 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
296 not to EMACS_INT, to avoid GCC warning.
298 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
300 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
301 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
302 isn't needed on 32-bit machines.
304 * buffer.c (Fgenerate_new_buffer_name):
305 Use EMACS_INT for count, not int.
306 (advance_to_char_boundary): Return EMACS_INT, not int.
308 * data.c (Qcompiled_function): Now static.
310 * window.c (window_body_lines): Now static.
312 * image.c (gif_load): Rename local to avoid shadowing.
314 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
315 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
316 * alloc.c (make_save_value): Integer argument is now of type
318 (mark_object): Use ptrdiff_t, not int.
319 * lisp.h (pD): New macro.
320 * print.c (print_object): Use it.
322 * alloc.c: Use EMACS_INT, not int, to count objects.
323 (total_conses, total_markers, total_symbols, total_vector_size)
324 (total_free_conses, total_free_markers, total_free_symbols)
325 (total_free_floats, total_floats, total_free_intervals)
326 (total_intervals, total_strings, total_free_strings):
327 Now EMACS_INT, not int. All uses changed.
328 (Fgarbage_collect): Compute overall total using a double, so that
329 integer overflow is less likely to be a problem. Check for overflow
330 when converting back to an integer.
331 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
332 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
333 These were 'int' variables that could overflow on 64-bit hosts;
334 they were never used, so remove them instead of repairing them.
335 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
336 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
337 Previously, this ceilinged at INT_MAX, but that doesn't work on
339 (allocate_pseudovector): Don't use EMACS_INT when int would do.
341 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
342 (allocate_vectorlike): Check for ptrdiff_t overflow.
343 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
344 when a (possibly-narrower) signed value would do just as well.
345 We prefer using signed arithmetic, to avoid comparison confusion.
347 * alloc.c: Catch some string size overflows that we were missing.
348 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
349 for convenience in STRING_BYTES_MAX.
350 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
351 The definition here is exact; the one in lisp.h was approximate.
352 (allocate_string_data): Check for string overflow. This catches
353 some instances we weren't catching before. Also, it catches
354 size_t overflow on (unusual) hosts where SIZE_MAX <= min
355 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
356 and ptrdiff_t and EMACS_INT are both 64 bits.
358 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
359 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
360 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
362 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
364 * alloc.c (Fmake_string): Check for out-of-range init.
366 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
368 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
370 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
372 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
373 xg_get_default_scrollbar_width.
375 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
376 (int_gtk_range_get_value): Move to the scroll bar part of the file.
377 (style_changed_cb): Call update_theme_scrollbar_width and call
378 x_set_scroll_bar_default_width and xg_frame_set_char_size for
379 all frames (Bug#8505).
380 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
381 Call gtk_window_set_resizable if HAVE_GTK3.
382 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
383 and height if HAVE_GTK3 (Bug#8505).
384 (scroll_bar_width_for_theme): New variable.
385 (update_theme_scrollbar_width): New function.
386 (xg_get_default_scrollbar_width): Move code to
387 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
388 (xg_initialize): Call update_theme_scrollbar_width.
390 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
392 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
394 2011-06-12 Martin Rudalics <rudalics@gmx.at>
396 * frame.c (make_frame): Call other_buffer_safely instead of
399 * window.c (temp_output_buffer_show): Call display_buffer with
400 second argument Vtemp_buffer_show_specifiers and reset latter
401 immediately after the call.
402 (Vtemp_buffer_show_specifiers): New variable.
403 (auto_window_vscroll_p, next_screen_context_lines)
404 (Vscroll_preserve_screen_position): Remove leading asterisks from
407 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
409 Fix minor problems found by GCC 4.6.0 static checking.
410 * buffer.c (Qclone_number): Remove for now, as it's unused.
411 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
412 (record_buffer): Remove unused local.
413 * frame.c (other_visible_frames, frame_buffer_list): Now static.
414 (set_frame_buffer_list): Remove; unused.
415 * frame.h (other_visible_frames): Remove decl.
416 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
417 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
418 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
420 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
421 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
422 Define only if HAVE_GPM.
423 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
424 (update_hints_inhibit): Remove; never set. All uses removed.
425 * widgetprv.h (emacsFrameClassRec): Remove decl.
426 * window.c (delete_deletable_window): Now returns void, since it
427 wasn't returning anything.
428 (compare_window_configurations): Remove unused locals.
429 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
430 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
431 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
432 the same widths as pointers. This follows up on the 2011-05-06 patch.
433 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
435 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
437 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
439 * makefile.w32-in: Update dependencies.
440 (LISP_H): Add lib/intprops.h.
442 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
444 * image.c (gif_load): Add animation frame delay to the metadata.
445 (syms_of_image): Use DEFSYM. New symbol `delay'.
447 2011-06-11 Martin Rudalics <rudalics@gmx.at>
449 * window.c (delete_deletable_window): Re-add.
450 (Fset_window_configuration): Rewrite to handle dead buffers and
451 consequently deletable windows.
452 (window_tree, Fwindow_tree): Remove. Supply functionality in
454 (compare_window_configurations): Simplify code.
456 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
458 * image.c (imagemagick_load_image): Fix type mismatch.
459 (Fimagemagick_types): Likewise.
461 * window.h (replace_buffer_in_windows): Declare.
463 2011-06-11 Martin Rudalics <rudalics@gmx.at>
465 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
466 Qclone_number. Remove external declaration of Qdelete_window.
467 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
469 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
470 Qbuffer_list_update_hook if allowed.
471 (Fother_buffer): Rewrite doc-string. Major rewrite for new
472 buffer list implementation.
473 (other_buffer_safely): New function.
474 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
475 calls to replace_buffer_in_windows and
476 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
478 (record_buffer): Inhibit quitting and rewrite using quittable
479 functions. Run Qbuffer_list_update_hook if allowed.
480 (Frecord_buffer, Funrecord_buffer): New functions.
481 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
482 switch-to-buffer to window.el.
483 (bury-buffer): Move to window.el.
484 (Vbuffer_list_update_hook): New variable.
486 * lisp.h (other_buffer_safely): Add prototype in buffer.c
489 * window.h (resize_frame_windows): Move up in code.
490 (Fwindow_frame): Remove EXFUN.
491 (replace_buffer_in_all_windows): Remove prototype.
492 (replace_buffer_in_windows_safely): Add prototype.
494 * window.c: Declare Qdelete_window static again. Move down
495 declaration of select_count.
496 (Fnext_window, Fprevious_window): Rewrite doc-strings.
497 (Fother_window): Move to window.el.
498 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
499 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
500 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
502 (replace_buffer_in_windows): Implement by calling
503 Qreplace_buffer_in_windows.
504 (replace_buffer_in_all_windows): Remove with some functionality
505 moved into replace_buffer_in_windows_safely.
506 (replace_buffer_in_windows_safely): New function.
507 (select_window_norecord, select_frame_norecord): Move in front
508 of run_window_configuration_change_hook. Remove now obsolete
510 (Fset_window_buffer): Rewrite doc-string. Call
511 Qrecord_window_buffer.
512 (keys_of_window): Move binding for other-window to window.el.
514 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
516 * dispextern.h (struct image): Replace data member, whose int_val
517 and ptr_val fields were not used by anything, with a single
520 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
521 (gif_clear_image, gif_load, imagemagick_load_image)
522 (gs_clear_image, gs_load): Callers changed.
524 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
526 * buffer.h: Include <time.h>, for time_t.
527 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
529 Fix minor problems found by static checking.
531 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
533 Make identifiers static if they are not used in other modules.
534 * data.c (Qcompiled_function, Qframe, Qvector):
535 * image.c (QimageMagick, Qsvg):
536 * minibuf.c (Qmetadata):
537 * window.c (resize_window_check, resize_root_window): Now static.
538 * window.h (resize_window_check, resize_root_window): Remove decls.
540 * window.c (window_deletion_count, delete_deletable_window):
542 (window_body_lines): Now static.
543 (Fdelete_other_windows_internal): Mark vars as initialized.
544 Make sure 'resize_failed' is initialized.
545 (run_window_configuration_change_hook): Rename local to avoid shadowing.
546 (resize_window_apply): Remove unused local.
547 * window.h (delete_deletable_window): Remove decl.
549 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
550 (imagemagick_load_image): Fix pointer signedness problem by changing
551 last arg from unsigned char * to char *. All uses changed.
552 Also, fix a local for similar reasons.
553 Remove unused locals. Remove locals to avoid shadowing.
554 (fn_rsvg_handle_free): Remove; unused.
555 (svg_load, svg_load_image): Fix pointer signedness problem.
556 (imagemagick_load_image): Don't use garbage pointer image_wand.
558 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
560 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
562 * image.c (gif_load): Fix omitted cast error introduced by
565 2011-06-10 Martin Rudalics <rudalics@gmx.at>
567 * window.h (resize_proportionally, orig_total_lines)
568 (orig_top_line): Remove from window structure.
569 (set_window_height, set_window_width, change_window_heights)
570 (Fdelete_window): Remove prototypes.
571 (resize_frame_windows): Remove duplicate declaration.
573 2011-06-10 Eli Zaretskii <eliz@gnu.org>
575 * window.h (resize_frame_windows, resize_window_check)
576 (delete_deletable_window, resize_root_window)
577 (resize_frame_windows): Declare prototypes.
579 * window.c (resize_window_apply): Make definition be "static" to
582 2011-06-10 Martin Rudalics <rudalics@gmx.at>
584 * window.c: Remove declarations of Qwindow_size_fixed,
585 window_min_size_1, window_min_size_2, window_min_size,
586 size_window, window_fixed_size_p, enlarge_window, delete_window.
587 Remove static from declaration of Qdelete_window, it's
588 temporarily needed by Fbury_buffer.
589 (replace_window): Don't assign orig_top_line and
591 (Fdelete_window, delete_window): Remove. Window deletion is
592 handled by window.el.
593 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
594 Fdelete_window calls with calls to Qdelete_window.
595 (Fdelete_other_windows): Remove. Deleting other windows is
596 handled by window.el.
597 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
598 handled in window.el.
599 (window_min_size_2, window_min_size_1, window_min_size): Remove.
600 Window minimum sizes are handled in window.el.
601 (shrink_windows, size_window, set_window_height)
602 (set_window_width, change_window_heights, window_height)
603 (window_width, CURBEG, CURSIZE, enlarge_window)
604 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
605 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
606 handled in window.el.
607 (make_dummy_parent): Rename to make_parent_window and give it a
608 second argument horflag.
609 (make_window): Don't set resize_proportionally any more.
610 (Fsplit_window): Remove. Windows are split in window.el.
611 (save_restore_action, save_restore_orig_size)
612 (shrink_window_lowest_first, save_restore_orig_size): Remove.
613 Resize mini windows in window.el.
614 (grow_mini_window, shrink_mini_window): Implement by calling
615 Qresize_root_window_vertically, resize_window_check and
617 (saved_window, Fset_window_configuration, save_window_save): Do
618 not handle orig_top_line, orig_total_lines, and
619 resize_proportionally.
620 (window_min_height, window_min_width): Move to window.el.
621 (keys_of_window): Move bindings for delete-other-windows,
622 split-window, delete-window and enlarge-window to window.el.
624 * buffer.c: Temporarily extern Qdelete_window.
625 (Fbury_buffer): Temporarily call Qdelete_window instead of
626 Fdelete_window (Fbury_buffer will move to window.el soon).
628 * frame.c (set_menu_bar_lines_1): Remove code handling
629 orig_top_line and orig_total_lines.
631 * dispnew.c (adjust_frame_glyphs_initially): Don't use
632 set_window_height but set heights directly.
633 (change_frame_size_1): Use resize_frame_windows.
635 * xdisp.c (init_xdisp): Don't use set_window_height but set
638 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
639 resize_frame_windows instead of change_window_heights and run
640 run_window_configuration_change_hook.
642 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
643 instead of change_window_heights and run
644 run_window_configuration_change_hook.
646 2011-06-09 Martin Rudalics <rudalics@gmx.at>
648 * window.c (replace_window): Rename second argument REPLACEMENT to
649 NEW. New third argument SETFLAG. Rewrite.
650 (delete_window, make_dummy_parent): Call replace_window with
652 (window_list_1): Move down in code.
653 (run_window_configuration_change_hook): Move set_buffer part
654 before select_frame_norecord part in order to unwind correctly.
655 Rename count1 to count.
656 (recombine_windows, delete_deletable_window, resize_root_window)
657 (Fdelete_other_windows_internal)
658 (Frun_window_configuration_change_hook, make_parent_window)
659 (resize_window_check, resize_window_apply, Fresize_window_apply)
660 (resize_frame_windows, Fsplit_window_internal)
661 (Fdelete_window_internal, Fresize_mini_window_internal): New
663 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
665 2011-06-08 Martin Rudalics <rudalics@gmx.at>
667 * window.h (window): Add some new members to window structure -
668 normal_lines, normal_cols, new_total, new_normal, clone_number,
669 splits, nest, prev_buffers, next_buffers.
670 (WINDOW_TOTAL_SIZE): Move here from window.c.
671 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
673 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
675 (make_dummy_parent): Set new members of windows structure.
676 (make_window): Move down in code. Handle new members of window
678 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
679 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
680 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
681 (Fset_window_prev_buffers, Fwindow_next_buffers)
682 (Fset_window_next_buffers, Fset_window_clone_number): New
684 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
685 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
687 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
688 Argument WINDOW can be now internal window too.
689 (Fwindow_use_time): Move up in code.
690 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
692 (Fset_window_configuration, saved_window)
693 (Fcurrent_window_configuration, save_window_save): Handle new
694 members of window structure.
695 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
696 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
697 (syms_of_window): New Lisp objects Qrecord_window_buffer,
698 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
699 Qget_mru_window, Qresize_root_window,
700 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
701 Qauto_buffer_name; staticpro them.
703 2011-06-07 Martin Rudalics <rudalics@gmx.at>
705 * window.c (Fwindow_total_size, Fwindow_left_column)
706 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
707 (Fwindow_list_1): New functions.
708 (window_box_text_cols): Replace with window_body_cols.
709 (Fwindow_width, Fscroll_left, Fscroll_right): Use
710 window_body_cols instead of window_box_text_cols.
711 (delete_window, Fset_window_configuration): Call
712 delete_all_subwindows with window as argument.
713 (delete_all_subwindows): Take a window as argument and not a
715 (window_loop): Remove handling of GET_LRU_WINDOW and
717 (Fget_lru_window, Fget_largest_window): Move to window.el.
719 * window.h: Extern window_body_cols instead of
720 window_box_text_cols. delete_all_subwindows now takes a
721 Lisp_Object as argument.
723 * indent.c (compute_motion, Fcompute_motion): Use
724 window_body_cols instead of window_box_text_cols.
726 * frame.c (delete_frame): Call delete_all_subwindows with root
729 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
731 * fns.c (Fputhash): Document return value.
733 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
735 * image.c (gif_load): Implement gif89a spec "no disposal" method.
737 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
739 Cons<->int and similar integer overflow fixes (Bug#8794).
741 Check for overflow when converting integer to cons and back.
742 * charset.c (Fdefine_charset_internal, Fdecode_char):
743 Use cons_to_unsigned to catch overflow.
744 (Fencode_char): Use INTEGER_TO_CONS.
745 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
746 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
747 * data.c (long_to_cons, cons_to_long): Remove.
748 (cons_to_unsigned, cons_to_signed): New functions.
749 These signal an error for invalid or out-of-range values.
750 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
751 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
752 * font.c (Ffont_variation_glyphs):
753 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
754 * lisp.h: Include <intprops.h>.
755 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
756 (cons_to_signed, cons_to_unsigned): New decls.
757 (long_to_cons, cons_to_long): Remove decls.
758 * undo.c (record_first_change): Use INTEGER_TO_CONS.
759 (Fprimitive_undo): Use CONS_TO_INTEGER.
760 * xfns.c (Fx_window_property): Likewise.
761 * xselect.c: Include <limits.h>.
762 (x_own_selection, selection_data_to_lisp_data):
764 (x_handle_selection_request, x_handle_selection_clear)
765 (x_get_foreign_selection, Fx_disown_selection_internal)
766 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
767 (lisp_data_to_selection_data): Use cons_to_unsigned.
768 (x_fill_property_data): Use cons_to_signed.
769 Report values out of range.
771 Check for buffer and string overflow more precisely.
772 * buffer.h (BUF_BYTES_MAX): New macro.
773 * lisp.h (STRING_BYTES_MAX): New macro.
774 * alloc.c (Fmake_string):
775 * character.c (string_escape_byte8):
776 * coding.c (coding_alloc_by_realloc):
778 * editfns.c (Fformat):
780 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
781 since they may not be the same number.
782 * editfns.c (Finsert_char):
783 * fileio.c (Finsert_file_contents):
784 Likewise for BUF_BYTES_MAX.
786 * image.c: Use ptrdiff_t, not int, for sizes.
787 (slurp_file): Switch from int to ptrdiff_t.
789 (slurp_file): Check that file size fits in both size_t (for
790 malloc) and ptrdiff_t (for sanity and safety).
792 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
793 if b->modtime has its maximal value.
795 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
797 Don't assume time_t can fit into int.
798 * buffer.h (struct buffer.modtime): Now time_t, not int.
799 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
800 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
802 Minor fixes for signed vs unsigned integers.
803 * character.h (MAYBE_UNIFY_CHAR):
804 * charset.c (maybe_unify_char):
805 * keyboard.c (read_char, reorder_modifiers):
806 XINT -> XFASTINT, since the integer must be nonnegative.
807 * ftfont.c (ftfont_spec_pattern):
808 * keymap.c (access_keymap, silly_event_symbol_error):
809 XUINT -> XFASTINT, since the integer must be nonnegative.
810 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
811 since it makes no difference and we prefer signed.
812 * keyboard.c (record_char): Use XUINT when all the neighbors do.
813 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
816 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
818 * window.h (Fwindow_frame): Declare.
820 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
822 * alloc.c: Simplify handling of large-request failures (Bug#8800).
823 (SPARE_MEMORY): Always define.
824 (LARGE_REQUEST): Remove.
825 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
827 2011-06-06 Martin Rudalics <rudalics@gmx.at>
829 * lisp.h: Move EXFUNS for Fframe_root_window,
830 Fframe_first_window and Fset_frame_selected_window to window.h.
832 * window.h: Move EXFUNS for Fframe_root_window,
833 Fframe_first_window and Fset_frame_selected_window here from
836 * frame.c (Fwindow_frame, Fframe_first_window)
837 (Fframe_root_window, Fframe_selected_window)
838 (Fset_frame_selected_window): Move to window.c.
839 (Factive_minibuffer_window): Move to minibuf.c.
840 (Fother_visible_frames_p): New function.
842 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
844 * window.c (decode_window, decode_any_window): Move up in code.
845 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
846 (inhibit_frame_unsplittable): Remove unused variable.
847 (Fwindow_buffer): Move up and rewrite doc-string.
848 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
849 (Fwindow_prev): New functions.
850 (Fwindow_frame): Move here from frame.c. Accept any window as
852 (Fframe_root_window, Fframe_first_window)
853 (Fframe_selected_window): Move here from frame.c. Accept frame
854 or arbitrary window as argument. Update doc-strings.
855 (Fminibuffer_window): Move up in code.
856 (Fwindow_minibuffer_p): Move up in code and simplify.
857 (Fset_frame_selected_window): Move here from frame.c.
859 (Fselected_window, select_window, Fselect_window): Move up in
860 code. Minor doc-string fixes.
862 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
864 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
865 Do not assume that spare memory exists; that assumption is valid
866 only if SYSTEM_MALLOC.
867 (LARGE_REQUEST): New macro, so that the issue of large requests
868 is separated from the issue of spare memory.
870 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
872 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
875 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
877 * xfns.c (x_set_scroll_bar_default_width): Move declarations
880 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
882 * gtkutil.c (xg_get_default_scrollbar_width): New function.
884 * gtkutil.h: Declare xg_get_default_scrollbar_width.
886 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
887 min width by calling x_set_scroll_bar_default_width (Bug#8505).
889 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
891 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
893 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
895 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
896 (x_clipboard_manager_save): Add return value.
897 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
899 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
900 Obey Vx_select_enable_clipboard_manager. Catch errors in
901 x_clipboard_manager_save (Bug#8779).
902 (Vx_select_enable_clipboard_manager): New variable.
903 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
905 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
907 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
909 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
911 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
912 in the current matrix if keep_current_p is non-zero.
914 2011-06-04 Eli Zaretskii <eliz@gnu.org>
916 * bidi.c (bidi_level_of_next_char): Fix last change.
918 2011-06-03 Eli Zaretskii <eliz@gnu.org>
920 Support bidi reordering of text covered by display properties.
922 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
923 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
924 (bidi_cache_search, bidi_cache_iterator_state)
925 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
926 (bidi_level_of_next_char, bidi_move_to_visually_next):
927 Support character positions inside a run of characters covered by a
929 (bidi_paragraph_init, bidi_resolve_explicit_1)
930 (bidi_level_of_next_char): Call bidi_fetch_char and
931 bidi_fetch_char_advance instead of FETCH_CHAR and
933 (bidi_init_it): Initialize new members.
934 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
936 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
937 instead of using explicit *_CHAR codes.
938 (bidi_resolve_explicit, bidi_resolve_weak):
939 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
940 bidirectional text is supported only in multibyte buffers.
941 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
942 it to initialize the frame_window_p member of struct bidi_it.
943 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
944 (bidi_resolve_explicit, bidi_resolve_weak)
945 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
946 bidi_it->nchars is non-positive.
947 (bidi_level_of_next_char): Don't try to lookup the cache for the
948 next/previous character if nothing is cached there yet, or if we
949 were just reseat()'ed to a new position.
951 * xdisp.c (set_cursor_from_row): Set start and stop points
952 according to the row's direction when priming the loop that looks
953 for the glyph on which to display cursor.
954 (single_display_spec_intangible_p): Function deleted.
955 (display_prop_intangible_p): Reimplement to call
956 handle_display_spec instead of single_display_spec_intangible_p.
957 Accept 3 additional arguments needed by handle_display_spec.
958 This fixes incorrect cursor motion across display property with complex
959 values: lists, `(when COND...)' forms, etc.
960 (single_display_spec_string_p): Support property values that are
961 lists with the argument STRING its top-level element.
962 (display_prop_string_p): Fix the condition for processing a
963 property that is a list to be consistent with handle_display_spec.
964 (handle_display_spec): New function, refactored from the
965 last portion of handle_display_prop.
966 (compute_display_string_pos): Accept additional argument
967 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
968 value of a `display' property is a "replacing spec".
969 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
970 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
971 the display property, but just return a value indicating whether
972 the display property will replace the characters it covers.
973 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
974 frame_window_p members of struct bidi_it.
975 (compute_display_string_pos, compute_display_string_end):
977 (push_it): Accept second argument POSITION, where pop_it should
978 jump to continue iteration.
979 (reseat_1): Initialize bidi_it.disp_pos.
981 * keyboard.c (adjust_point_for_property): Adjust the call to
982 display_prop_intangible_p to its new signature.
984 * dispextern.h (struct bidi_it): New member frame_window_p.
985 (bidi_init_it): Update prototypes.
986 (display_prop_intangible_p): Update prototype.
987 (compute_display_string_pos, compute_display_string_end):
989 (struct bidi_it): New members nchars and disp_pos. ch_len is now
992 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
994 Malloc failure behavior now depends on size of allocation.
995 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
996 * lisp.h: Change signatures accordingly.
997 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
998 All callers changed. (Bug#8762)
1000 * gnutls.c: Use Emacs's memory allocators.
1001 Without this change, the gnutls library would invoke malloc etc.
1002 directly, which causes problems on non-SYNC_INPUT hosts, and which
1003 runs afoul of improving memory_full behavior. (Bug#8761)
1004 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1005 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1006 xfree instead of the default malloc, realloc, free.
1007 (Fgnutls_boot): No need to check for memory allocation failure,
1008 since xmalloc does that for us.
1010 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1011 * category.c (hash_get_category_set):
1012 * ccl.c (ccl_driver):
1013 * charset.c (Fdefine_charset_internal):
1014 * charset.h (struct charset.hash_index):
1015 * composite.c (get_composition_id, gstring_lookup_cache)
1016 (composition_gstring_put_cache):
1017 * composite.h (struct composition.hash_index):
1018 * dispextern.h (struct image.hash):
1019 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1020 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1021 (hashfn_equal, hashfn_user_defined, make_hash_table)
1022 (maybe_resize_hash_table, hash_lookup, hash_put)
1023 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1024 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1025 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1026 * image.c (make_image, search_image_cache, lookup_image)
1027 (xpm_put_color_table_h):
1028 * lisp.h (struct Lisp_Hash_Table):
1029 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1030 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1031 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1032 * alloc.c (allocate_vectorlike):
1033 Check for overflow in vector size calculations.
1034 * ccl.c (ccl_driver):
1035 Check for overflow when converting EMACS_INT to int.
1036 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1037 need to be updated by these changes.
1038 * fns.c (make_hash_table, maybe_resize_hash_table):
1039 Check for integer overflow with large hash tables.
1040 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1041 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1042 (SXHASH_REDUCE): New macro.
1043 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1044 Use it instead of discarding useful hash info with large hash values.
1045 (sxhash_float): New function.
1046 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1047 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1048 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1049 Rewrite to use FIXNUM_BITS, as this simplifies things.
1050 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1051 Adjust signatures to match updated version of code.
1052 (consing_since_gc): Now EMACS_INT, since a single hash table can
1053 use more than INT_MAX bytes.
1055 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1057 Make it possible to build with GCC-4.6+ -O2 -flto.
1059 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1061 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1063 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1064 Call minibuffer-inactive-mode.
1066 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1068 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1069 Update dependencies.
1071 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1073 * data.c (init_data): Remove code for UTS, this system is not
1076 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1078 Don't force ./temacs to start in terminal mode.
1080 * frame.c (make_initial_frame): Initialize faces in all cases, not
1081 only when CANNOT_DUMP is defined.
1082 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1084 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1086 * dispnew.c (add_window_display_history): Use const for the string
1087 pointer. Remove declaration, not needed.
1089 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1091 Use 'inline', not 'INLINE'.
1092 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1093 * alloc.c, fontset.c (INLINE): Remove.
1094 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1095 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1096 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1097 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1098 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1100 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1102 Make it possible to run ./temacs.
1104 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1105 syms_of_callproc does the same thing. Remove test for
1106 "initialized", do it in the caller.
1107 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1109 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1111 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1112 (read_minibuf): Use get_minibuffer.
1113 (syms_of_minibuf): Use DEFSYM.
1114 (Qmetadata): New var.
1115 * data.c (Qbuffer): Don't make it static.
1116 (syms_of_data): Use DEFSYM.
1118 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1120 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1121 (CCL_CODE_MIN): New macro.
1123 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1125 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1127 * eval.c (Qdebug): Now static.
1128 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1129 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1130 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1132 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1134 * image.c: Various fixes to ImageMagick code comments.
1135 (Fimagemagick_types): Doc fix.
1137 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1139 Minor fixes prompted by GCC 4.6.0 warnings.
1141 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1143 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1144 (x_clipboard_manager_save_all): Move extern decl to ...
1145 * xterm.h: ... here, so that it can be checked for consistency.
1147 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1149 * xselect.c (x_clipboard_manager_save_frame)
1150 (x_clipboard_manager_save_all): New functions.
1151 (Fx_clipboard_manager_save): Lisp function deleted.
1153 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1154 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1156 * xterm.h: Update prototype.
1158 2011-05-28 William Xu <william.xwl@gmail.com>
1160 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1163 2011-05-28 Jim Meyering <meyering@redhat.com>
1165 Avoid a sign-extension bug in crypto_hash_function.
1166 * fns.c (to_uchar): Define.
1167 (crypto_hash_function): Use it to convert some newly-signed
1168 variables to unsigned, to avoid sign-extension bugs. For example,
1169 without this change, (md5 "truc") would evaluate to
1170 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1171 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1172 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1174 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1176 Integer overflow fixes.
1178 * dbusbind.c: Serial number integer overflow fixes.
1179 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1180 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1181 to hold a serial number that is too large for a fixnum.
1182 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1183 Check for serial numbers out of range. Decode any serial number
1184 that was so large that it became a float. (Bug#8722)
1186 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1187 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1188 Use XFASTINT rather than XUINT when numbers are nonnegative.
1189 (xd_append_arg, Fdbus_method_return_internal):
1190 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1191 arguments, check that Lisp number is nonnegative, rather than
1192 silently wrapping negative numbers around. (Bug#8722)
1193 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1196 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1198 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1200 ccl: add integer overflow checks
1201 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1202 (IN_INT_RANGE): New macros.
1203 (ccl_driver): Use them to check for integer overflow when
1204 decoding a CCL program. Many of the new checks are whether XINT (x)
1205 fits in int; it doesn't always, on 64-bit hosts. The new version
1206 doesn't catch all possible integer overflows, but it's an
1207 improvement. (Bug#8719)
1209 * alloc.c (make_event_array): Use XINT, not XUINT.
1210 There's no need for unsigned here.
1212 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1213 This follows up to the 2011-05-06 change that substituted uintptr_t
1214 for EMACS_INT. This case wasn't caught back then.
1216 Rework Fformat to avoid integer overflow issues.
1217 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1218 now (part of C89). Include <verify.h>.
1219 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1220 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1221 (Fformat): Avoid the prepass trying to compute sizes; it was only
1222 approximate and thus did not catch overflow reliably. Instead, walk
1223 through the format just once, formatting and computing sizes as we go,
1224 checking for integer overflow at every step, and allocating a larger
1225 buffer as needed. Keep track separately whether the format is
1226 multibyte. Keep only the most-recently calculated precision, rather
1227 than them all. Record whether each argument has been converted to
1228 string. Use EMACS_INT, not int, for byte and char and arg counts.
1229 Support field widths and precisions larger than INT_MAX. Avoid
1230 sprintf's undefined behavior with conversion specifications such as %#d
1231 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1232 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1233 formatting out-of-range floating point numbers with int
1236 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1238 * data.c: Avoid integer truncation in expressions involving floats.
1239 * data.c: Include <intprops.h>.
1240 (arith_driver): When there's an integer overflow in an expression
1241 involving floating point, convert the integers to floating point
1242 so that the resulting value does not suffer from catastrophic
1243 integer truncation. For example, on a 64-bit host (* 4
1244 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1245 Do not rely on undefined behavior after integer overflow.
1247 merge count_size_as_multibyte, parse_str_to_multibyte
1248 * character.c, character.h (count_size_as_multibyte):
1249 Rename from parse_str_to_multibyte; all uses changed.
1250 Check for integer overflow.
1251 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1252 since it's now a duplicate of the other. This is more of
1253 a character than a buffer op, so better that it's in character.c.
1254 * fns.c, print.c: Adjust to above changes.
1256 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1258 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1260 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1262 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1263 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1264 (x_clipboard_manager_save): Now static.
1265 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1267 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1268 (crypto_hash_function): Now static.
1269 Fix pointer signedness problems. Avoid unnecessary initializations.
1271 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1273 * termhooks.h (Vselection_alist): Make it terminal-local.
1275 * terminal.c (create_terminal): Initialize it.
1277 * xselect.c: Support for clipboard managers.
1278 (Vselection_alist): Move to termhooks.h as terminal-local var.
1279 (LOCAL_SELECTION): New macro.
1280 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1281 (symbol_to_x_atom): Remove gratuitous arg.
1282 (x_handle_selection_request, lisp_data_to_selection_data)
1283 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1284 (x_own_selection, x_get_local_selection, x_convert_selection):
1285 New arg, specifying work frame. Use terminal-local Vselection_alist.
1286 (some_frame_on_display): Delete unused function.
1287 (Fx_own_selection_internal, Fx_get_selection_internal)
1288 (Fx_disown_selection_internal, Fx_selection_owner_p)
1289 (Fx_selection_exists_p): New optional frame arg.
1290 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1291 (x_handle_selection_clear): Don't treat other terminals with the
1292 same keyboard specially. Use the terminal-local Vselection_alist.
1293 (x_clear_frame_selections): Use Frun_hook_with_args.
1295 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1297 * xterm.h: Add support for those atoms.
1299 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1301 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1302 (converted_selections, conversion_fail_tag): New global variables.
1303 (x_selection_request_lisp_error): Free the above.
1304 (x_get_local_selection): Remove unnecessary code.
1305 (x_reply_selection_request): Args changed; handle arbitrary array
1306 of converted selections stored in converted_selections.
1307 Separate the XChangeProperty and SelectionNotify steps.
1308 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1309 (x_convert_selection): New function.
1310 (x_handle_selection_event): Simplify.
1311 (x_get_foreign_selection): Don't ignore incoming requests while
1312 waiting for an answer; this will fail when we implement
1313 SAVE_TARGETS, and seems unnecessary anyway.
1314 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1315 (Vx_sent_selection_functions): Doc fix.
1317 2011-05-26 Leo Liu <sdl.web@gmail.com>
1319 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1321 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1323 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1325 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1326 for fringe update if it has periodic bitmap.
1327 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1328 and fringe_bitmap_periodic_p.
1330 * fringe.c (get_fringe_bitmap_data): New function.
1331 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1332 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1333 row. Mark glyph row for fringe update if periodicity changed.
1335 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1336 for fringe update unless it has periodic bitmap.
1338 2011-05-25 Kenichi Handa <handa@m17n.org>
1340 * xdisp.c (get_next_display_element): Set correct it->face_id for
1341 a static composition.
1343 2011-05-24 Leo Liu <sdl.web@gmail.com>
1346 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1348 * fns.c (crypto_hash_function, Fsha1): New function.
1349 (Fmd5): Use crypto_hash_function.
1350 (syms_of_fns): Add Ssha1.
1352 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1354 * gnutls.c: Remove unused macros.
1355 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1356 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1357 Remove macros that are defined and never used.
1358 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1360 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1362 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1363 (Fx_get_selection_internal): Minor cleanup.
1364 (Fx_own_selection_internal): Rename arguments for consistency with
1367 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1369 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1371 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1373 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1375 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1377 * dispnew.c (scrolling_window): Don't exclude the case that the
1378 last enabled row in the desired matrix touches the bottom boundary.
1380 2011-05-21 Glenn Morris <rgm@gnu.org>
1382 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1383 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1384 and add some more files.
1386 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1388 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1389 report_file_error introduced by the change from 2011-05-07.
1391 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1393 * systime.h (Time): Define only if emacs is defined.
1394 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1395 where the include path doesn't have X11/X.h by default. See
1396 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1398 2011-05-20 Kenichi Handa <handa@m17n.org>
1400 * composite.c (find_automatic_composition): Fix previous change.
1402 2011-05-20 Glenn Morris <rgm@gnu.org>
1404 * lisp.mk: New file, split from Makefile.in.
1405 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1406 (shortlisp): Remove.
1407 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1409 2011-05-19 Glenn Morris <rgm@gnu.org>
1411 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1412 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1413 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1414 (lisp): Set the order to that of loadup.el.
1415 (shortlisp): Make it a copy of $lisp.
1416 (SOME_MACHINE_LISP): Remove.
1417 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1418 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1420 2011-05-18 Kenichi Handa <handa@m17n.org>
1422 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1423 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1424 (find_automatic_composition): Mostly rewrite for efficiency.
1426 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1428 * makefile.w32-in: Update dependencies.
1430 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1432 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1433 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1435 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1437 Fix some integer overflow issues, such as string length overflow.
1439 * insdel.c (count_size_as_multibyte): Check for string overflow.
1441 * character.c (lisp_string_width): Check for string overflow.
1442 Use EMACS_INT, not int, for string indexes and lengths; in
1443 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1444 the resulting string length overflows an EMACS_INT; instead,
1445 report a string overflow if no precision given. When checking for
1446 precision exhaustion, use a check that cannot possibly have
1447 integer overflow. (Bug#8675)
1448 * character.h (lisp_string_width): Adjust to new signature.
1450 * alloc.c (string_overflow): New function.
1451 (Fmake_string): Use it. This doesn't change behavior, but saves
1452 a few bytes and will simplify future changes.
1453 * character.c (string_escape_byte8): Likewise.
1454 * lisp.h (string_overflow): New decl.
1456 Fixups, following up to the user-interface timestamp change.
1457 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1458 for UI timestamps, instead of unsigned long.
1459 * msdos.c (mouse_get_pos): Likewise.
1460 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1461 * w32gui.h (Time): Define by including "systime.h" rather than by
1462 declaring it ourselves. (Bug#8664)
1464 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1465 * image.c (clear_image_cache): Likewise.
1467 * term.c (term_mouse_position): Don't assume time_t wraparound.
1469 Be more systematic about user-interface timestamps.
1470 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1471 and sometimes 'EMACS_UINT', to represent these timestamps.
1472 This change causes it to use 'Time' uniformly, as that's what X uses.
1473 This makes the code easier to follow, and makes it easier to catch
1474 integer overflow bugs such as Bug#8664.
1475 * frame.c (Fmouse_position, Fmouse_pixel_position):
1476 Use Time, not unsigned long, for user-interface timestamps.
1477 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1478 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1479 * keyboard.h (last_event_timestamp): Likewise.
1480 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1481 * menu.h (xmenu_show): Likewise.
1482 * term.c (term_mouse_position): Likewise.
1483 * termhooks.h (struct input_event.timestamp): Likewise.
1484 (struct terminal.mouse_position_hook): Likewise.
1485 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1486 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1487 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1488 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1490 * menu.h, termhooks.h: Include "systime.h", for Time.
1492 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1493 Don't assume that the difference between two unsigned long values
1494 can fit into an integer. At this point, we know button_down_time
1495 <= event->timestamp, so the difference must be nonnegative, so
1496 there's no need to cast the result if double-click-time is
1497 nonnegative, as it should be; check that it's nonnegative, just in
1498 case. This bug is triggered when events are more than 2**31 ms
1499 apart (about 25 days). (Bug#8664)
1501 * xselect.c (last_event_timestamp): Remove duplicate decl.
1502 (x_own_selection): Remove needless cast to unsigned long.
1504 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1505 that always fit in int. Use a sentinel instead of a counter, to
1506 avoid a temp and to allay GCC's concerns about possible int overflow.
1507 * frame.h (struct frame): Use int for menu_bar_items_used
1508 instead of EMACS_INT, since it always fits in int.
1510 * menu.c (grow_menu_items): Check for int overflow.
1512 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1514 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1515 Before, the code was not consistent. These values cannot exceed
1516 2**31 - 1 so there's no need to make them unsigned.
1517 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1518 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1519 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1521 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1523 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1524 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1525 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1526 presumably because the widths might not match.
1528 * window.c (size_window): Avoid needless test at loop start.
1530 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1532 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1534 2011-05-12 Drew Adams <drew.adams@oracle.com>
1536 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1538 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1540 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1541 `width' to `bar_area_x' and `bar_area_width', respectively.
1542 (x_scroll_run): Take account of fringe background extension.
1544 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1545 Rename local vars `left' and `width' to `bar_area_x' and
1546 `bar_area_width', respectively.
1547 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1548 background extension.
1550 2011-05-10 Jim Meyering <meyering@redhat.com>
1552 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1554 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1556 * image.c (Finit_image_library): Return t for built-in image types,
1557 like pbm and xbm. (Bug#8640)
1559 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1561 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1563 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1565 * w32console.c (Fset_screen_color): Doc fix.
1566 (Fget_screen_color): New function.
1567 (syms_of_ntterm): Defsubr it.
1569 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1570 unlink the temporary file if Fcall_process didn't create it in the
1572 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1573 child process will be redirected to a file specified with `:file'.
1574 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1575 cue to call_process_cleanup not to close that handle.
1577 2011-05-07 Ben Key <bkey76@gmail.com>
1579 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1580 one of two shell specific rules, either bootstrap-temacs-CMD or
1581 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1582 to the previous implementation of the bootstrap-temacs rule.
1583 The bootstrap-temacs-CMD rule is similar to the previous
1584 implementation of the bootstrap-temacs rule except that it
1585 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1588 These changes, along with some changes to nt/configure.bat,
1589 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1590 earlier fix to add support for --cflags and --ldflags options
1591 that include quotes so that it works whether make uses cmd or
1594 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1596 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1597 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1599 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1600 a string. Handle both cases.
1601 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1602 (Fdbus_register_method): Use Qinvalid_function.
1604 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1606 * makefile.w32-in: Update dependencies.
1607 (LISP_H): Add inttypes.h and stdin.h.
1608 (PROCESS_H): Add unistd.h.
1610 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1612 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1613 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1615 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1617 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1619 * term.c (vfatal): Remove stray call to va_end.
1620 It's not needed and the C Standard doesn't allow it here anyway.
1622 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1623 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1625 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1628 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1630 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1632 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1634 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1636 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1638 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1639 * charset.c (Fdefine_charset_internal): Don't initialize
1640 charset.code_space[15]. The value was garbage, on hosts with
1641 32-bit int (Bug#8600).
1643 * lread.c (read_integer): Be more consistent with string-to-number.
1644 Use string_to_number to do the actual conversion; this avoids
1645 rounding errors and fixes some other screwups. Without this fix,
1646 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1647 (digit_to_number): Move earlier, for benefit of read_integer.
1648 Return -1 if the digit is out of range for the base, -2 if it is
1649 not a digit in any supported base. (Bug#8602)
1651 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1653 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1654 to match comment at start of function. This also removes a
1655 GCC warning about overflow in a 32+64-bit port.
1657 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1659 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1660 Reported by Stefan Monnier in
1661 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1662 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1663 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1665 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1666 (EMACS_UINTPTR): Likewise, with uintptr_t.
1668 * lisp.h: Prefer 64-bit EMACS_INT if available.
1669 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1670 on 32-bit hosts that have 64-bit int, so that they can access
1672 However, temporarily disable this change unless the temporary
1673 symbol WIDE_EMACS_INT is defined.
1675 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1677 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1678 This removes an assumption that EMACS_INT and long are the same
1679 width as pointers. The assumption is true for Emacs porting targets
1680 now, but we want to make other targets possible.
1681 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1682 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1683 In the rest of the code, change types of integers that hold casted
1684 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1685 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1686 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1687 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1688 No need to cast type when ORing.
1689 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1690 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1691 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1692 assume EMACS_INT is the same width as char *.
1693 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1694 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1695 Remove no-longer-needed casts.
1696 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1697 (xg_tool_bar_help_callback, xg_make_tool_item):
1698 Use EMACS_INTPTR to hold an integer
1699 that will be cast to void *; this can avoid a GCC warning
1700 if EMACS_INT is not the same width as void *.
1701 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1702 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1703 (current_message_1, set_message_1):
1704 Use a local to convert to proper width without a cast.
1705 * xmenu.c (dialog_selection_callback): Likewise.
1707 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1708 Also, don't assume VALBITS / RAND_BITS is less than 5,
1709 and don't rely on undefined behavior when shifting a 1 left into
1711 * lisp.h (get_random): Change signature to match.
1713 * lread.c (hash_string): Use size_t, not int, for hash computation.
1714 Normally we prefer signed values; but hashing is special, because
1715 it's better to use unsigned division on hash table sizes so that
1716 the remainder is nonnegative. Also, size_t is the natural width
1717 for hashing into memory. The previous code used 'int', which doesn't
1718 retain enough info to hash well into very large tables.
1719 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1721 * dbusbind.c: Don't possibly lose pointer info when converting.
1722 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1723 Use XPNTR rather than XHASH, so that the high-order bits of
1724 the pointer aren't lost when converting through void *.
1726 * eval.c (Fautoload): Don't double-shift a pointer.
1728 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1730 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1732 * gnutls.c (DEF_GNUTLS_FN):
1733 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1735 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1737 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1740 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1742 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1743 New version that can reserve upto 2GB of heap space.
1745 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1747 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1749 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1751 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1752 `gnutls_certificate_set_x509_key_file'.
1754 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1756 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1757 Update dependencies.
1759 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1761 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1762 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1763 Remove unused parameter `fildes'.
1764 * process.c (read_process_output, send_process): Don't pass it.
1766 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1768 Fix previous change: the library cache is defined in w32.c.
1769 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1770 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1772 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1774 Implement dynamic loading of GnuTLS on Windows.
1776 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1777 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1778 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1781 * gnutls.c (Qgnutls_dll): Define.
1782 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1783 (gnutls_*): Declare function pointers.
1784 (init_gnutls_functions): New function to initialize function pointers.
1785 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1786 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1787 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1788 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1789 (emacs_gnutls_write, emacs_gnutls_read)
1790 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1791 (Fgnutls_available_p): New function.
1792 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1793 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1794 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1796 * image.c: Include w32.h.
1797 (Vimage_type_cache): Delete.
1798 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1799 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1800 (w32_delayed_load): Move to w32.c.
1802 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1804 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1805 (w32_delayed_load): Move from image.c. When loading a library, record
1806 its filename in the :loaded-from property of the library id.
1807 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1808 Initialize and staticpro them.
1809 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1811 * process.c: Include lisp.h before w32.h, not after.
1812 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1813 instead of gnutls_record_check_pending.
1815 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1817 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1819 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1820 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1823 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1825 * xterm.c (x_set_frame_alpha): Do not set property on anything
1826 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1828 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1830 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1832 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1834 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1835 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1836 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1837 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1838 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1839 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1840 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1841 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1842 (Qgnutls_bootprop_callbacks_verify): Make static.
1844 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1846 * callproc.c: Indentation fixup.
1848 * sysdep.c (wait_for_termination_1): Make static.
1849 (wait_for_termination, interruptible_wait_for_termination):
1850 Move after wait_for_termination_1.
1852 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1854 * sysdep.c (interruptible_wait_for_termination): New function
1855 which is like wait_for_termination, but allows keyboard
1858 * callproc.c (Fcall_process): Add (:file "file") as an option for
1860 (Fcall_process_region): Ditto.
1862 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1864 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1865 rather than `XVECTOR (FOO)->size'.
1867 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1868 inttypes.h, as a gnulib replacement is used if it not available in
1871 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1873 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1874 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1875 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1877 * coding.c (coding_alloc_by_realloc): Error out if destination
1878 will grow beyond MOST_POSITIVE_FIXNUM.
1879 (decode_coding_emacs_mule): Abort if there isn't enough place in
1880 charbuf for the composition carryover bytes. Reserve an extra
1881 space for up to 2 characters produced in a loop.
1882 (decode_coding_iso_2022): Abort if there isn't enough place in
1883 charbuf for the composition carryover bytes.
1885 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1887 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1888 aborting when %lld or %lll format is passed.
1889 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1890 %llo or %llx format is passed. (Bug#8545)
1892 * window.c (window_scroll_line_based): Use a marker instead of
1893 simple variables to record original value of point. (Bug#7952)
1895 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1896 produced by %s or %c overflows available buffer space. (Bug#8545)
1898 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1900 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1901 (SIZE_MAX): Move defn after all includes, as they might #define it.
1903 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1905 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1907 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1909 * keyboard.c (Qdelayed_warnings_hook): Define.
1910 (command_loop_1): Run `delayed-warnings-hook'
1911 if Vdelayed_warnings_list is non-nil.
1912 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1913 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1915 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1917 * doprnt.c (doprnt): Don't return value smaller than the buffer
1918 size if the message was truncated. (Bug#8545).
1920 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1922 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1923 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1925 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1927 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1929 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1931 * makefile.w32-in: Update dependencies.
1933 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1935 Improve `doprnt' and its usage. (Bug#8545)
1936 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1937 `format_end'. Remove support for %l as a conversion specifier.
1938 Don't use xrealloc. Improve diagnostics when the %l size modifier
1939 is used. Update the commentary.
1941 * eval.c (verror): Simplify calculation of size_t.
1943 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1946 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1948 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1951 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1953 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1954 This makes this file independent of the recent pseudovector change.
1956 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1958 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1960 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1961 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1962 Remove unused local.
1963 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1965 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1966 GCC 4.6.0 optimizes based on type-based alias analysis.
1967 For example, if b is of type struct buffer * and v of type struct
1968 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1969 != &v->size, and therefore "v->size = 1; b->size = 2; return
1970 v->size;" must therefore return 1. This assumption is incorrect
1971 for Emacs, since it type-puns struct Lisp_Vector * with many other
1972 types. To fix this problem, this patch adds a new type struct
1973 vectorlike_header that documents the constraints on layout of vectors
1974 and pseudovectors, and helps optimizing compilers not get fooled
1975 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1976 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1977 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1979 (XSETPVECTYPE): Rewrite in terms of new macro.
1980 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1981 This is a bit clearer, and further avoids the possibility of
1982 undesirable aliasing.
1983 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1984 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1985 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1986 since Lisp_Subr is a special case (no "next" field).
1987 (ASIZE): Now uses header.size rather than size.
1988 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1989 to avoid the hassle of writing XVECTOR (foo)->header.size.
1990 (struct vectorlike_header): New type.
1991 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1992 object, to help avoid aliasing.
1993 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1994 (SUBRP): Likewise, since Lisp_Subr is a special case.
1995 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1996 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1997 (struct Lisp_Hash_Table): Combine first two members into a single
1998 struct vectorlike_header member. All uses of "size" and "next" members
1999 changed to be "header.size" and "header.next".
2000 * buffer.h (struct buffer): Likewise.
2001 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2002 * frame.h (struct frame): Likewise.
2003 * process.h (struct Lisp_Process): Likewise.
2004 * termhooks.h (struct terminal): Likewise.
2005 * window.c (struct save_window_data, struct saved_window): Likewise.
2006 * window.h (struct window): Likewise.
2007 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2008 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2009 * buffer.c (init_buffer_once): Likewise.
2010 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2012 * process.c (Fformat_network_address): Use local var for size,
2015 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2017 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2018 * data.c (atof): Remove decl; no longer used or needed.
2019 (digit_to_number): Move to lread.c.
2020 (Fstring_to_number): Use new string_to_number function, to be
2021 consistent with how the Lisp reader treats infinities and NaNs.
2022 Do not assume that floating-point numbers represent EMACS_INT
2023 without losing information; this is not true on most 64-bit hosts.
2024 Avoid double-rounding errors, by insisting on integers when
2025 parsing non-base-10 numbers, as the documentation specifies.
2026 * lisp.h (string_to_number): New decl, replacing ...
2027 (isfloat_string): Remove.
2028 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2029 (read1): Do not accept +. and -. as integers; this
2030 appears to have been a coding error. Similarly, do not accept
2031 strings like +-1e0 as floating point numbers. Do not report
2032 overflow for integer overflows unless the base is not 10 which
2033 means we have no simple and reliable way to continue.
2034 Break out the floating-point parsing into a new
2035 function string_to_number, so that Fstring_to_number parses
2036 floating point numbers consistently with the Lisp reader.
2037 (digit_to_number): Move here from data.c. Make it static inline.
2038 (E_CHAR, EXP_INT): Remove, replacing with ...
2039 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2040 (string_to_number): New function, replacing isfloat_string.
2041 This function checks for valid syntax and produces the resulting
2042 Lisp float number too. Rework it so that string-to-number
2043 no longer mishandles examples like "1.0e+". Use strtoumax,
2044 so that overflow for non-base-10 numbers is reported only when
2045 there's no portable and simple way to convert to floating point.
2047 * textprop.c (set_text_properties_1): Rewrite for clarity,
2048 and to avoid GCC warning about integer overflow.
2050 * intervals.h (struct interval): Use EMACS_INT for members
2051 where EMACS_UINT might cause problems. See
2052 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2053 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2054 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2056 (offset_intervals): Tell GCC not to worry about length overflow
2057 when negating a negative length.
2059 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2060 (overrun_check_free): Likewise.
2062 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2063 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2066 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2067 (gnutls_make_error): Rename local to avoid shadowing.
2068 (gnutls_emacs_global_deinit): ifdef out; not used.
2069 (Fgnutls_boot): Use const for pointer to readonly storage.
2070 Comment out unused local. Fix pointer signedness problems.
2072 * lread.c (openp): Don't stuff size_t into an 'int'.
2073 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2074 about possible signed overflow.
2076 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2077 (GDK_KEY_g): Don't define if already defined.
2078 (xg_prepare_tooltip): Avoid pointer signedness problem.
2079 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2081 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2082 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2084 * xfns.c (Fx_window_property): Simplify a bit,
2085 to make a bit faster and to avoid GCC 4.6.0 warning.
2086 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2088 * fns.c (internal_equal): Don't assume size_t fits in int.
2090 * alloc.c (compact_small_strings): Tighten assertion a little.
2092 Replace pEd with more-general pI, and fix some printf arg casts.
2093 * lisp.h (pI): New macro, generalizing old pEd macro to other
2094 conversion specifiers. For example, use "...%"pI"d..." rather
2095 than "...%"pEd"...".
2096 (pEd): Remove. All uses replaced with similar uses of pI.
2097 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2098 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2099 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2100 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2101 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2102 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2103 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2105 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2106 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2107 * print.c (safe_debug_print, print_object): Likewise.
2108 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2110 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2111 avoiding the 0 flag, which is not portable.
2112 * process.c (Fmake_network_process): Use pI to avoid cast.
2113 * region-cache.c (pp_cache): Likewise.
2114 * xdisp.c (decode_mode_spec): Likewise.
2115 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2116 behavior on 64-bit hosts with printf arg.
2117 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2118 (x_stop_queuing_selection_requests): Likewise.
2119 (x_get_window_property): Don't truncate byte count to an 'int'
2122 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2123 here, since it parses constructs like leading '-' and spaces,
2124 which are not wanted; and it overflows with large numbers.
2125 Instead, simply match F[0-9]+, which is what is wanted anyway.
2127 * alloc.c: Remove unportable assumptions about struct layout.
2128 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2129 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2130 (allocate_vectorlike, make_pure_vector): Use the new macros,
2131 plus offsetof, to remove unportable assumptions about struct layout.
2132 These assumptions hold on all porting targets that I know of, but
2133 they are not guaranteed, they're easy to remove, and removing them
2134 makes further changes easier.
2136 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2137 This doesn't fix a bug but makes the code clearer.
2138 (string_overrun_cookie): Now const. Use initializers that
2139 don't formally overflow signed char, to avoid warnings.
2140 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2141 can cause Emacs to crash when string overrun checking is enabled.
2142 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2143 multiple of sizeof (EMACS_INT); it need not be, if
2144 alignof(EMACS_INT) < sizeof (EMACS_INT).
2145 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2147 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2149 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2151 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2153 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2154 supposed to be handshaking. (Bug#8556)
2155 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2157 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2159 * lisp.h (Qdebug): List symbol.
2160 * eval.c (Qdebug): Restore global linkage.
2161 * keyboard.c (debug-on-event): New variable.
2162 (handle_user_signal): Break into debugger when debug-on-event
2163 matches the current signal symbol.
2165 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2167 * alloc.c (check_sblock, check_string_bytes)
2168 (check_string_free_list): Convert to standard C.
2170 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2172 * w32.c (emacs_gnutls_push): Fix typo.
2174 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2176 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2177 "cast to pointer from integer of different size".
2179 Improve doprnt and its use in verror. (Bug#8545)
2180 * doprnt.c (doprnt): Document the set of format control sequences
2181 supported by the function. Use SAFE_ALLOCA instead of always
2184 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2185 is one byte too soon. Don't use xrealloc; instead xfree and
2188 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2190 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2193 * gnutls.c: Renamed global_initialized to
2194 gnutls_global_initialized. Added internals for the
2195 :verify-hostname-error, :verify-error, and :verify-flags
2196 parameters of `gnutls-boot' and documented those parameters in the
2197 docstring. Start callback support.
2198 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2199 unless a fatal error occured. Call gnutls_alert_send_appropriate
2200 on error. Return error code.
2201 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2202 (emacs_gnutls_read): Likewise.
2203 (Fgnutls_boot): Return handshake error code.
2204 (emacs_gnutls_handle_error): New function.
2205 (wsaerror_to_errno): Likewise.
2207 * w32.h (emacs_gnutls_pull): Add prototype.
2208 (emacs_gnutls_push): Likewise.
2210 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2211 (emacs_gnutls_push): Likewise.
2213 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2215 * process.c (wait_reading_process_output): Check if GnuTLS
2216 buffered some data internally if no FDs are set for TLS
2219 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2220 (LIBS): Link to USER_LIBS.
2221 ($(BLD)/gnutls.$(0)): New target.
2223 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2225 * xdisp.c (handle_single_display_spec): Rename the
2226 display_replaced_before_p argument into display_replaced_p, to
2227 make it consistent with the commentary. Fix typos in the
2230 * textprop.c (syms_of_textprop): Remove dead code.
2231 (copy_text_properties): Delete obsolete commentary about an
2232 interface that was deleted long ago. Fix typos in the description
2235 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2236 to changes in oldXMenu/XMenu.h from 2011-04-16.
2237 <menu_help_message, prev_menu_help_message>: Constify.
2238 (IT_menu_make_room): menu->help_text is now `const char **';
2241 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2242 to changes in oldXMenu/XMenu.h from 2011-04-16.
2243 (struct XMenu): Declare `help_text' `const char **'.
2245 * xfaces.c <Qunspecified>: Make extern again.
2247 * syntax.c: Include sys/types.h before including regex.h, as
2250 * doc.c (get_doc_string): Improve the format passed to `error'.
2252 * doprnt.c (doprnt): Improve commentary.
2254 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2256 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2259 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2260 changes in globals.h immediately force recompilation.
2261 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2262 $(CURDIR)/s/ms-w32.h.
2263 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2265 * character.c (Fchar_direction): Function deleted.
2266 (syms_of_character): Don't defsubr it.
2267 <char-direction-table>: Deleted.
2269 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2271 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2272 * doprnt.c: Include limits.h.
2273 (SIZE_MAX): New macro.
2274 (doprnt): Return a size_t value. 2nd arg is now size_t.
2275 Many local variables are now size_t instead of int or unsigned.
2276 Improve overflow protection. Support `l' modifier for integer
2277 conversions. Support %l conversion. Don't assume an EMACS_INT
2278 argument for integer conversions and for %c.
2280 * lisp.h (doprnt): Restore prototype.
2282 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2285 * Makefile.in (base_obj): Add back doprnt.o.
2287 * deps.mk (doprnt.o): Add back prerequisites.
2288 (callint.o): Depend on character.h.
2290 * eval.c (internal_lisp_condition_case): Include the handler
2291 representation in the error message.
2292 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2293 when breaking from the loop.
2295 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2297 * callint.c (Fcall_interactively): When displaying error message
2298 about invalid control letter, pass the character's codepoint, not
2299 a pointer to its multibyte form. Improve display of the character
2300 in octal and display also its hex code.
2302 * character.c (char_string): Use %x to display the (unsigned)
2303 codepoint of an invalid character, to avoid displaying a bogus
2306 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2307 `error', not SYMBOL_NAME itself.
2309 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2310 character arguments to `error'.
2312 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2313 to `error' in error message about FINAL_CHAR argument. Make sure
2314 FINAL_CHAR is a character, and use %c when it is passed as
2315 argument to `error'.
2317 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2319 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2321 * w32.c: Include <time.h>.
2322 (sys_localtime): New function.
2324 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2326 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2328 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2330 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2332 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2335 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2337 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2338 gl_state.e_property when gl_state.object is Qt.
2340 * insdel.c (make_gap_larger): Remove limitation of buffer size
2343 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2345 * xdisp.c (lookup_glyphless_char_display)
2346 (produce_glyphless_glyph): Handle cons cell entry in
2347 glyphless-char-display.
2348 (Vglyphless_char_display): Document it.
2350 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2351 glyphless-char-display.
2353 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2355 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2357 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2359 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2360 definition for no-X builds.
2362 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2364 Static checks with GCC 4.6.0 and non-default toolkits.
2366 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2368 * process.c (keyboard_bit_set): Define only if SIGIO.
2369 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2370 (send_process): Repair possible setjmp clobbering.
2372 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2374 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2376 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2378 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2379 Define only if needed.
2381 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2382 by pacifying GCC about it. Maybe it's time to retire it?
2383 * xfaces.c (USG, __TIMEVAL__): Likewise.
2385 * dispextern.h (struct redisplay_interface): Rename param
2387 * termhooks.h (struct terminal): Likewise.
2388 * xterm.c (xembed_send_message): Likewise.
2390 * insdel.c (make_gap_smaller): Define only if
2391 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2393 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2396 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2397 so that we aren't warned about unused symbols.
2399 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2401 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2403 * xfns.c (x_real_positions): Mark locals as initialized.
2405 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2407 * xterm.c: Fix problems found by static analysis with other toolkits.
2408 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2409 (x_dispatch_event): Declare static if USE_GTK, and
2410 define if USE_GTK || USE_X_TOOLKIT.
2411 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2412 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2413 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2414 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2416 * xmenu.c (menu_help_callback): Pointer type fixes.
2417 Use const pointers when pointing at readonly data. Avoid pointer
2419 (FALSE): Remove unused macro.
2420 (update_frame_menubar): Remove unused decl.
2422 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2424 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2425 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2426 (single_menu_item): Rename local to avoid shadowing.
2428 * keyboard.c (make_lispy_event): Remove unused local var.
2430 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2431 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2433 * bitmaps: Change bitmaps from unsigned char back to the X11
2434 compatible char. Avoid the old compiler warnings about
2435 out-of-range initializers by using, for example, '\xab' rather
2438 * xgselect.c (xgselect_initialize): Check vs interface
2439 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2441 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2443 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2444 to read-only memory.
2446 * fns.c (vector): Remove; this old hack is no longer needed.
2448 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2450 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2452 * xrdb.c (x_load_resources): Omit unused local.
2454 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2455 (x_window): Rename locals to avoid shadowing.
2456 (USG): Use the kludged USG macro, to pacify gcc.
2458 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2459 (x_term_init): Remove local to avoid shadowing.
2461 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2463 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2464 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2466 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2468 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2470 Fix regex.c, syntax.c and friends for buffers > 2GB.
2471 * syntax.h (struct gl_state_s): Declare character position members
2474 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2476 * textprop.c (verify_interval_modification, interval_of):
2477 Declare arguments EMACS_INT.
2479 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2482 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2484 * indent.c (Fvertical_motion): Local variable it_start is now
2487 * regex.c (re_match, re_match_2, re_match_2_internal)
2488 (bcmp_translate, regcomp, regexec, print_double_string)
2489 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2490 (re_compile_pattern, re_exec): Declare arguments and local
2491 variables `size_t' and `ssize_t' and return values `regoff_t', as
2493 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2494 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2495 <compile_stack_type>: `size' and `avail' are now `size_t'.
2497 * regex.h <regoff_t>: Use ssize_t, not int.
2498 (re_search, re_search_2, re_match, re_match_2): Arguments that
2499 specify buffer/string position and length are now ssize_t and
2500 size_t. Return type is regoff_t.
2502 2011-04-16 Ben Key <bkey76@gmail.com>
2504 * nsfont.m: Fixed bugs in ns_get_family and
2505 ns_descriptor_to_entity that were caused by using free to
2506 deallocate memory blocks that were allocated by xmalloc (via
2507 xstrdup). This caused Emacs to crash when compiled with
2508 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2509 --enable-checking=xmallocoverrun). xfree is now used to
2510 deallocate these memory blocks.
2512 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2514 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2516 emacs_write: Accept and return EMACS_INT for sizes.
2517 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2519 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2520 Accept and return EMACS_INT.
2521 (emacs_gnutls_write): Return the number of bytes written on
2523 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2524 (emacs_read, emacs_write): Remove check for negative size, as the
2525 Emacs source code has been audited now.
2526 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2527 (emacs_read, emacs_write): Use it.
2528 * process.c (send_process): Adjust to the new signatures of
2529 emacs_write and emacs_gnutls_write. Do not attempt to store
2530 a byte offset into an 'int'; it might overflow.
2531 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2533 * sound.c: Don't assume sizes fit in 'int'.
2534 (struct sound_device.period_size, alsa_period_size):
2535 Return EMACS_INT, not int.
2536 (struct sound_device.write, vox_write, alsa_write):
2537 Accept EMACS_INT, not int.
2538 (wav_play, au_play): Use EMACS_INT to store sizes and to
2539 record read return values.
2541 2011-04-15 Ben Key <bkey76@gmail.com>
2543 * keyboard.c (Qundefined): Don't declare static since it is used
2545 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2546 static since they are used in nsfont.m.
2548 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2550 * process.c (Qprocessp): Don't declare static.
2551 * lisp.h (Qprocessp): Declare again.
2553 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2555 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2557 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2559 Improve C-level modularity by making more things 'static'.
2561 Don't publish debugger-only interfaces to other modules.
2562 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2563 (verify_bytepos, count_markers): Move decls to the only modules
2565 * region-cache.h (pp_cache): Likewise.
2566 * window.h (check_all_windows): Likewise.
2567 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2569 * sysdep.c (croak): Now static, if
2570 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2571 * syssignal.h (croak): Declare only if not static.
2573 * alloc.c (refill_memory_reserve): Now static if
2574 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2575 * lisp.h (refill_memory_reserve): Declare only if not static.
2577 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2578 Define only if USE_LUCID.
2580 * xrdb.c (x_customization_string, x_rm_string): Now static.
2582 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2583 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2585 * xdisp.c (draw_row_with_mouse_face): Now static.
2586 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2588 * window.h (check_all_windows): Mark externally visible.
2590 * window.c (window_deletion_count): Now static.
2592 * undo.c: Make symbols static if they're not exported.
2593 (last_undo_buffer, last_boundary_position, pending_boundary):
2596 * textprop.c (interval_insert_behind_hooks): Now static.
2597 (interval_insert_in_front_hooks): Likewise.
2599 * term.c: Make symbols static if they're not exported.
2600 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2601 (max_frame_lines, tty_set_terminal_modes):
2602 (tty_reset_terminal_modes, tty_turn_off_highlight):
2603 (get_tty_terminal): Now static.
2604 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2605 * termhooks.h (term_mouse_moveto): Do not declare if
2607 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2608 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2610 * sysdep.c: Make symbols static if they're not exported.
2611 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2613 (sigprocmask_set, full_mask): Remove; unused.
2614 (wait_debugging): Mark as visible.
2615 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2616 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2618 * syntax.c (syntax_temp): Define only if !__GNUC__.
2620 * sound.c (current_sound_device, current_sound): Now static.
2622 * search.c (searchbufs, searchbuf_head): Now static.
2624 * scroll.c (scroll_cost): Remove; unused.
2625 * dispextern.h (scroll_cost): Remove decl.
2627 * region-cache.h (pp_cache): Mark as externally visible.
2629 * process.c: Make symbols static if they're not exported.
2630 (process_tick, update_tick, create_process, chan_process):
2631 (Vprocess_alist, proc_buffered_char, datagram_access):
2632 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2633 (deactivate_process): Mark defn as static, as well as decl.
2634 * lisp.h (create_process): Remove decl.
2635 * process.h (chan_process, Vprocess_alist): Remove decls.
2637 * print.c: Make symbols static if they're not exported.
2638 (print_depth, new_backquote_output, being_printed, print_buffer):
2639 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2640 (print_interval, print_number_index, initial_stderr_stream):
2642 * lisp.h (Fprinc): Remove decl.
2643 (debug_output_compilation_hack): Mark as externally visible.
2645 * sysdep.c (croak): Move decl from here to syssignal.h.
2646 * syssignal.h (croak): Put it here, so the API can be checked when
2647 'croak' is called from dissociate_if_controlling_tty.
2649 * minibuf.c: Make symbols static if they're not exported.
2650 (minibuf_save_list, choose_minibuf_frame): Now static.
2651 * lisp.h (choose_minibuf_frame): Remove decl.
2653 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2655 * lread.c: Make symbols static if they're not exported.
2656 (read_objects, initial_obarray, oblookup_last_bucket_number):
2658 (make_symbol): Remove; unused.
2659 * lisp.h (initial_obarray, make_symbol): Remove decls.
2661 * keyboard.c: Make symbols static if they're not exported.
2662 (single_kboard, recent_keys_index, total_keys, recent_keys):
2663 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2664 (this_single_command_key_start, echoing, last_auto_save):
2665 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2666 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2667 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2668 (Vlispy_mouse_stem, double_click_count):
2670 (force_auto_save_soon): Define only if SIGDANGER.
2671 (ignore_mouse_drag_p): Now static if
2672 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2673 (print_help): Remove; unused.
2674 (stop_character, last_timer_event): Mark as externally visible.
2675 * keyboard.h (ignore_mouse_drag_p): Declare only if
2676 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2677 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2678 * lisp.h (echoing): Remove decl.
2679 (force_auto_save_soon): Declare only if SIGDANGER.
2680 * xdisp.c (redisplay_window): Simplify code, to make it more
2681 obvious that ignore_mouse_drag_p is not accessed if !defined
2682 USE_GTK && !defined HAVE_NS.
2684 * intervals.c: Make symbols static if they're not exported.
2685 (merge_properties_sticky, merge_interval_right, delete_interval):
2687 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2689 * insdel.c: Make symbols static if they're not exported.
2690 However, leave prepare_to_modify_buffer alone. It's never
2691 called from outside this function, but that appears to be a bug.
2692 (combine_after_change_list, combine_after_change_buffer):
2693 (adjust_after_replace, signal_before_change): Now static.
2694 (adjust_after_replace_noundo): Remove; unused.
2695 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2696 (signal_before_change): Remove decls.
2698 * indent.c (val_compute_motion, val_vmotion): Now static.
2700 * image.c: Make symbols static if they're not exported.
2701 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2703 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2704 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2706 * fringe.c (standard_bitmaps): Now static.
2707 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2709 * frame.c: Make symbols static if they're not exported.
2710 (x_report_frame_params, make_terminal_frame): Now static.
2711 (get_frame_param): Now static, unless HAVE_NS.
2712 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2713 (x_get_resource_string): Remove; not used.
2714 * frame.h (make_terminal_frame, x_report_frame_params):
2715 (x_get_resource_string); Remove decls.
2716 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2717 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2719 * font.c, fontset.c: Make symbols static if they're not exported.
2720 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2721 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2722 * font.c (font_close_object): Now static.
2723 * font.h (font_close_object): Remove.
2724 * fontset.c (FONTSET_OBJLIST): Remove.
2725 (free_realized_fontset) #if-0 the body, which does nothing.
2726 (face_suitable_for_char_p): #if-0, as it's never called.
2727 * fontset.h (face_suitable_for_char_p): Remove decl.
2728 * xfaces.c (face_at_string_position):
2729 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2730 since 0 is always ASCII.
2732 * fns.c (weak_hash_tables): Now static.
2734 * fileio.c: Make symbols static if they're not exported.
2735 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2736 (Vwrite_region_annotation_buffers): Now static.
2738 * eval.c: Make symbols static if they're not exported.
2739 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2740 * lisp.h (backtrace_list): Remove decl.
2742 * emacs.c: Make symbols static if they're not exported.
2743 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2744 (fatal_error_code, fatal_error_signal_hook, standard_args):
2746 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2747 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2748 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2749 * lisp.h (fatal_error_signal_hook): Remove decl.
2750 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2752 * editfns.c: Move a (normally-unused) function to its only use.
2753 * editfns.c, lisp.h (get_operating_system_release): Remove.
2754 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2755 worth the hassle of breaking this out.
2757 * xterm.c: Make symbols static if they're not exported.
2758 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2759 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2760 (x_destroy_window, x_delete_display):
2762 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2763 (x_mouse_leave): Remove; unused.
2764 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2765 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2766 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2768 (x_mouse_leave): Declare only if WINDOWSNT.
2769 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2770 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2773 * ftxfont.c: Make symbols static if they're not exported.
2774 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2776 * font.h (ftxfont_driver): Likewise.
2778 * xfns.c: Make symbols static if they're not exported.
2779 (x_last_font_name, x_display_info_for_name):
2780 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2781 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2782 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2783 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2784 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2785 (last_show_tip_args): Now static.
2786 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2787 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2788 (x_screen_planes): Remove; unused.
2789 * dispextern.h (x_screen_planes): Remove decl.
2791 * dispnew.c: Make symbols static if they're not exported.
2792 * dispextern.h (redraw_garbaged_frames, scrolling):
2793 (increment_row_positions): Remove.
2794 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2795 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2797 (redraw_garbaged_frames): Remove; unused.
2799 * xfaces.c: Make symbols static if they're not exported.
2800 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2802 * xterm.h (defined_color): Remove decls.
2803 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2804 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2805 (menu_face_changed_default, defined_color, free_realized_face):
2806 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2807 (ascii_face_of_lisp_face): Remove; unused.
2809 * xdisp.c: Make symbols static if they're not exported.
2810 * dispextern.h (scratch_glyph_row, window_box_edges):
2811 (glyph_to_pixel_coords, set_cursor_from_row):
2812 (get_next_display_element, set_iterator_to_next):
2813 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2814 (show_mouse_face): Remove decls
2815 * frame.h (message_buf_print): Likewise.
2816 * lisp.h (pop_message, set_message, check_point_in_composition):
2818 * xterm.h (set_vertical_scroll_bar): Likewise.
2819 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2820 (message_buf_print, scratch_glyph_row, displayed_buffer):
2821 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2822 (get_next_display_element, show_mouse_face, window_box_edges):
2823 (frame_to_window_pixel_xy, check_point_in_composition):
2824 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2825 (glyph_to_pixel_coords): Remove; unused.
2827 * dired.c (file_name_completion): Now static.
2829 * dbusbind.c (xd_in_read_queued_messages): Now static.
2831 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2832 * data.c (circular_list_error): Remove.
2834 * commands.h (last_point_position, last_point_position_buffer):
2835 (last_point_position_window): Remove decls.
2836 * keyboard.c: Make these variables static.
2838 * coding.h (coding, code_convert_region, encode_coding_gap):
2840 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2841 (iso_code_class, detect_coding, code_convert_region): Now static.
2842 (encode_coding_gap): Remove; unused.
2844 * chartab.c (chartab_chars, chartab_bits): Now static.
2846 * charset.h (charset_iso_8859_1): Remove decl.
2847 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2850 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2851 * ccl.c (Vccl_program_table): Now static.
2852 (check_ccl_update): Remove; unused.
2854 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2855 * category.h: ... from here.
2856 * category.c (check_category_table, set_category_set): Now static.
2858 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2859 * lisp.h: Remove these decls.
2861 * buffer.c (buffer_count): Remove unused var.
2863 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2864 so that it's not optimized away.
2865 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2866 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2867 exported only to the debugger.
2869 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2870 * atimer.h (run_all_atimers): Remove; not exported.
2872 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2873 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2874 was inaccessible from Lisp.
2875 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2876 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2878 alloc.c: Import and export fewer symbols, and remove unused items.
2879 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2881 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2882 it's not optimized away by whole-program optimization.
2883 (message_enable_multibyte, free_misc): Remove.
2884 (catchlist, handlerlist, mark_backtrace):
2885 Declare only if BYTE_MARK_STACK.
2886 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2887 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2888 (message_enable_multibyte): Remove decl.
2889 (free_misc, interval_free_list, float_block, float_block_index):
2890 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2891 (cons_free_list, last_marked_index):
2893 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2894 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2895 (mark_backtrace): Define only if BYTE_MARK_STACK.
2896 * xdisp.c (message_enable_multibyte): Now static.
2898 Declare Lisp_Object Q* variables to be 'static' if not exported.
2899 This makes it easier for human readers (and static analyzers)
2900 to see whether these variables are used from other modules.
2901 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2902 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2903 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2904 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2905 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2906 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2907 * xmenu.c, xselect.c:
2908 Declare Q* vars static if they are not used in other modules.
2909 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2910 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2911 Remove decls of unexported vars.
2912 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2914 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2916 Make Emacs functions such as Fatom 'static' by default.
2917 This makes it easier for human readers (and static analyzers)
2918 to see whether these functions can be called from other modules.
2919 DEFUN now defines a static function. To make the function external
2920 so that it can be used in other C modules, use the new macro DEFUE.
2921 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2922 (Finit_image_library):
2923 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2924 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2925 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2926 Remove decls, since these functions are now static.
2927 (Funintern, Fget_internal_run_time): New decls, since these functions
2928 were already external.
2930 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2931 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2932 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2933 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2934 * keyboard.c, keymap.c, lread.c:
2935 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2936 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2937 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2938 Mark functions with DEFUE instead of DEFUN,
2939 if they are used in other modules.
2940 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2941 decls for now-static functions.
2942 * buffer.h (Fdelete_overlay): Remove decl.
2943 * callproc.c (Fgetenv_internal): Mark as internal.
2944 * composite.c (Fremove_list_of_text_properties): Remove decl.
2945 (Fcomposition_get_gstring): New forward static decl.
2946 * composite.h (Fcomposite_get_gstring): Remove decl.
2947 * dired.c (Ffile_attributes): New forward static decl.
2948 * doc.c (Fdocumntation_property): New forward static decl.
2949 * eval.c (Ffetch_bytecode): New forward static decl.
2950 (Funintern): Remove extern decl; now in .h file where it belongs.
2951 * fileio.c (Fmake_symbolic_link): New forward static decl.
2952 * image.c (Finit_image_library): New forward static decl.
2953 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2954 * intervals.h (Fprevious_property_change):
2955 (Fremove_list_of_text_properties): Remove decls.
2956 * keyboard.c (Fthis_command_keys): Remove decl.
2957 (Fcommand_execute): New forward static decl.
2958 * keymap.c (Flookup_key): New forward static decl.
2959 (Fcopy_keymap): Now static.
2960 * keymap.h (Flookup_key): Remove decl.
2961 * process.c (Fget_process): New forward static decl.
2962 (Fprocess_datagram_address): Mark as internal.
2963 * syntax.c (Fsyntax_table_p): New forward static decl.
2964 (skip_chars): Remove duplicate decl.
2965 * textprop.c (Fprevious_property_change): New forward static decl.
2966 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2968 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2969 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2971 * editfns.c (Fformat): Remove unreachable code.
2973 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2975 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2978 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2980 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2981 when at ZV. (Bug#8487)
2983 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2985 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2987 * keyboard.c (parse_tool_bar_item): Likewise.
2988 * sound.c (sound_cleanup, alsa_close): Likewise.
2989 * termcap.c (tgetent): Likewise.
2990 * xfns.c (x_default_font_parameter): Likewise.
2991 * xsettings.c (read_and_apply_settings): Likewise.
2993 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2994 (overrun_check_free): Protoize.
2996 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2998 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2999 since callers should never pass a negative size.
3000 Change the signature to match that of plain 'read' and 'write'; see
3001 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3002 * lisp.h: Update prototypes of emacs_write and emacs_read.
3004 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3006 * xdisp.c (redisplay_window): Don't try to determine the character
3007 position of the scroll margin if the window start point w->startp
3008 is outside the buffer's accessible region. (Bug#8468)
3010 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3012 Fix write-region and its subroutines for buffers > 2GB.
3013 * fileio.c (a_write, e_write): Modify declaration of arguments and
3014 local variables to support buffers larger than 2GB.
3015 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3017 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3018 argument, local variables, and return value.
3020 * lisp.h: Update prototypes of emacs_write and emacs_read.
3022 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3024 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3026 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3028 Fix more problems found by GCC 4.6.0's static checks.
3030 * xdisp.c (vmessage): Use a better test for character truncation.
3032 * charset.c (load_charset_map): <, not <=, for optimization,
3033 and to avoid potential problems with integer overflow.
3034 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3035 * casetab.c (set_identity, shuffle): Likewise.
3036 * editfns.c (Fformat): Likewise.
3037 * syntax.c (skip_chars): Likewise.
3039 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3040 This also lets GCC 4.6.0 generate slightly better loop code.
3042 * callint.c (Fcall_interactively): <, not <=, for optimization.
3043 (Fcall_interactively): Count the number of arguments produced,
3044 not the number of arguments given. This is simpler and lets GCC
3045 4.6.0 generate slightly better code.
3047 * ftfont.c: Distingish more carefully between FcChar8 and char.
3048 The previous code passed unsigned char * to a functions like
3049 strlen and xstrcasecmp that expect char *, which does not
3050 conform to the C standard.
3051 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3052 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3053 char * when the C standard requires it.
3055 * keyboard.c (read_char): Remove unused var.
3057 * eval.c: Port to Windows vsnprintf (Bug#8435).
3059 (SIZE_MAX): Define if the headers do not.
3060 (verror): Do not give up if vsnprintf returns a negative count.
3061 Instead, grow the buffer. This ports to Windows vsnprintf, which
3062 does not conform to C99. Problem reported by Eli Zaretskii.
3063 Also, simplify the allocation scheme, by avoiding the need for
3064 calling realloc, and removing the ALLOCATED variable.
3066 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3068 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3069 But keep the doprint source code for now, as we might revamp it
3070 and use it again (Bug#8435).
3071 * lisp.h (doprnt): Remove.
3072 * Makefile.in (base_obj): Remove doprnt.o.
3073 * deps.mk (doprnt.o): Remove.
3075 error: Print 32- and 64-bit integers portably (Bug#8435).
3076 Without this change, on typical 64-bit hosts error ("...%d...", N)
3077 was used to print both 32- and 64-bit integers N, which relied on
3079 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3081 * lisp.h (error, verror): Mark as printf-like functions.
3082 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3083 Report overflow in size calculations when allocating printf buffer.
3084 Do not truncate output string at its first null byte.
3085 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3086 Truncate the output at a character boundary, since vsnprintf does not
3088 * charset.c (check_iso_charset_parameter): Convert internal
3089 character to string before calling 'error', since %c now has the
3091 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3092 overflow when computing char to be passed to 'error'. Do not
3093 pass Lisp_Object to 'error'; pass the integer instead.
3094 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3095 formatted with plain %d.
3097 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3099 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3101 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3103 * xterm.c (x_catch_errors): Remove duplicate declaration.
3105 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3107 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3109 2011-04-10 Jim Meyering <meyering@redhat.com>
3111 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3112 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3113 return ssize_t not "int", and use size_t as the buffer length.
3114 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3115 * gnutls.h: Update declarations.
3116 * process.c (read_process_output): Use ssize_t, to match.
3117 (send_process): Likewise.
3119 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3121 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3123 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3125 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3126 Use unsigned char, to match FcChar8 type definition.
3128 * xterm.c (handle_one_xevent):
3129 * xmenu.c (create_and_show_popup_menu):
3130 * xselect.c (x_decline_selection_request)
3131 (x_reply_selection_request): Avoid type-punned deref of X events.
3133 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3135 Fix some uses of `int' instead of EMACS_INT.
3136 * search.c (string_match_1, fast_string_match)
3137 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3138 (scan_buffer, find_next_newline_no_quit)
3139 (find_before_next_newline, search_command, Freplace_match)
3140 (Fmatch_data): Make some `int' variables be EMACS_INT.
3142 * xdisp.c (display_count_lines): 3rd argument and return value now
3143 EMACS_INT. All callers changed.
3144 (pint2hrstr): Last argument is now EMACS_INT.
3146 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3147 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3148 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3149 (decode_coding_utf_16, decode_coding_emacs_mule)
3150 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3151 (decode_coding_ccl, decode_coding_charset)
3152 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3153 (decode_coding_iso_2022, decode_coding_emacs_mule)
3154 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3155 <char_offset, last_offset>: Declare EMACS_INT.
3156 (encode_coding_utf_8, encode_coding_utf_16)
3157 (encode_coding_emacs_mule, encode_invocation_designation)
3158 (encode_designation_at_bol, encode_coding_iso_2022)
3159 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3160 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3162 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3163 (encode_invocation_designation): Last argument P_NCHARS is now
3165 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3166 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3168 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3171 * ccl.c (Fccl_execute_on_string): Declare some variables
3174 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3176 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3178 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3180 * process.c (Fformat_network_address): Doc fix.
3182 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3184 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3186 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3188 * keyboard.c (read_char): Call Lisp function help-form-show,
3189 instead of using internal_with_output_to_temp_buffer.
3190 (Qhelp_form_show): New var.
3191 (syms_of_keyboard): Use DEFSYM macro.
3193 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3195 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3197 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3199 * process.c (Flist_processes): Remove to Lisp.
3200 (list_processes_1): Delete.
3202 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3204 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3206 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3208 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3210 Fix more problems found by GCC 4.6.0's static checks.
3212 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3214 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3216 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3218 * xdisp.c (vmessage): Mark as a printf-like function.
3220 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3222 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3224 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3225 printf-like functions.
3226 (tiff_load): Add casts to remove these marks before passing them
3227 to system-supplied API.
3229 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3231 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3232 This avoids several warnings with gcc -Wstrict-overflow.
3233 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3234 directly, rather than having caller test rule sign. This avoids
3235 some unnecessary tests.
3236 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3237 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3238 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3240 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3241 (xfont_open): Avoid unnecessary tests.
3243 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3245 * composite.h, composite.c (composition_gstring_put_cache):
3246 Use EMACS_INT, not int, for length.
3248 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3249 breaking out part of COMPOSITION_DECODE_RULE.
3250 (COMPOSITION_DECODE_RULE): Use it.
3251 * composite.c (get_composition_id): Remove unused local vars,
3252 by using the new macro.
3254 * textprop.c (set_text_properties_1): Change while to do-while,
3255 since the condition is always true at first.
3257 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3258 (interval_deletion_adjustment): Return unsigned value.
3261 * process.c (list_processes_1, create_pty, read_process_output):
3262 (exec_sentinel): Remove vars that were set but not used.
3263 (create_pty): Remove unnecessary "volatile"s.
3264 (Fnetwork_interface_info): Avoid possibility of int overflow.
3265 (read_process_output): Do adaptive read buffering even if carryover.
3266 (read_process_output): Simplify nbytes computation if buffered.
3268 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3270 * syntax.c (scan_words): Remove var that was set but not used.
3271 (update_syntax_table): Use unsigned instead of int.
3273 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3274 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3275 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3277 * print.c (print_error_message): Avoid int overflow.
3279 * font.c (font_list_entities): Redo for clarity,
3280 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3282 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3283 (font_score): Avoid potential overflow in diff calculation.
3285 * fns.c (substring_both): Remove var that is set but not used.
3286 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3288 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3290 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3291 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3292 can always succeed if overflow has undefined behavior.
3294 * search.c (boyer_moore, wordify): Remove vars set but not used.
3295 (wordify): Omit three unnecessary tests.
3297 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3298 All callers changed. This avoids the need for an unused var.
3300 * casefiddle.c (casify_region): Remove var that is set but not used.
3302 * dired.c (file_name_completion): Remove var that is set but not used.
3304 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3306 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3307 (Finsert_file_contents): Remove unnecessary code checking fd.
3309 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3310 Check for integer overflow on size calculations.
3312 * buffer.c (Fprevious_overlay_change): Remove var that is set
3315 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3316 Remove vars that are set but not used.
3317 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3318 (timer_check_2): Mark vars as initialized.
3320 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3322 * image.c (lookup_image): Remove var that is set but not used.
3323 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3325 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3326 that are set but not used.
3328 * xfns.c (make_invisible_cursor): Don't return garbage
3329 if XCreateBitmapFromData fails (Bug#8410).
3331 * xselect.c (x_get_local_selection, x_handle_property_notify):
3332 Remove vars that are set but not used.
3334 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3335 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3337 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3338 Remove var that is set but not used.
3339 (scroll_bar_windows_size): Now size_t, not int.
3340 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3343 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3344 (map_tty_color) [!defined MSDOS]: Likewise.
3346 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3348 * coding.c: Remove vars that are set but not used.
3349 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3350 All callers changed.
3351 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3352 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3353 (decode_coding_charset): Remove vars that are set but not used.
3355 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3356 that is set but not used.
3358 * print.c (print_object): Remove var that is set but not used.
3360 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3361 The gnulib version avoids calling malloc in the usual case,
3362 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3363 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3364 * filelock.c (current_lock_owner): Likewise.
3365 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3366 * sysdep.c: Include allocator.h, careadlinkat.h.
3367 (emacs_no_realloc_allocator): New static constant.
3368 (emacs_readlink): New function.
3369 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3370 ../lib/careadlinkat.h.
3372 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3374 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3375 first non-nil return value).
3377 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3379 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3380 if not defined (Bug#8403).
3382 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3384 * xdisp.c (display_count_lines): Remove parameter `start',
3385 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3386 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3387 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3388 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3389 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3390 and thereabouts. All callers changed.
3391 (get_per_char_metric): Remove parameter `f', unused since
3392 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3394 2011-04-02 Jim Meyering <meyering@redhat.com>
3396 do not dereference NULL upon failed strdup
3397 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3398 (ns_get_family): Likewise.
3400 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3402 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3404 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3406 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3409 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3411 Add lexical binding.
3413 * window.c (Ftemp_output_buffer_show): New fun.
3414 (Fsave_window_excursion):
3415 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3417 * lread.c (lisp_file_lexically_bound_p): New function.
3418 (Fload): Bind Qlexical_binding.
3419 (readevalloop): Remove `evalfun' arg.
3420 Bind Qinternal_interpreter_environment.
3421 (Feval_buffer): Bind Qlexical_binding.
3422 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3424 (syms_of_lread): Declare `lexical-binding'.
3426 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3428 * keyboard.c (eval_dyn): New fun.
3429 (menu_item_eval_property): Use it.
3431 * image.c (parse_image_spec): Use Ffunctionp.
3433 * fns.c (concat, mapcar1): Accept byte-code-functions.
3435 * eval.c (Fsetq): Handle lexical vars.
3436 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3437 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3438 (FletX, Flet): Obey lexical binding.
3439 (Fcommandp): Handle closures.
3440 (Feval): New `lexical' arg.
3441 (eval_sub): New function extracted from Feval. Use it almost
3442 everywhere where Feval was used. Look up vars in lexical env.
3444 (Ffunctionp): Move from subr.el.
3445 (Ffuncall): Handle closures.
3446 (apply_lambda): Remove `eval_flags'.
3447 (funcall_lambda): Handle closures and new byte-code-functions.
3448 (Fspecial_variable_p): New function.
3449 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3450 but without exporting it to Lisp.
3452 * doc.c (Fdocumentation, store_function_docstring):
3453 * data.c (Finteractive_form): Handle closures.
3455 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3458 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3460 (exec_byte_code): New function extracted from Fbyte_code to handle new
3461 calling convention for byte-code-functions. Add new byte-codes.
3463 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3465 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3467 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3469 * xdisp.c (redisplay_internal): Fix prototype.
3471 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3473 * xdisp.c (SCROLL_LIMIT): New macro.
3474 (try_scrolling): Use it when setting scroll_limit.
3475 Limit scrolling to 100 screen lines.
3476 (redisplay_window): Even when falling back on "recentering",
3477 position point in the window according to scroll-conservatively,
3478 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3480 (try_scrolling): When point is above the window, allow searching
3481 as far as scroll_max, or one screenful, to compute vertical
3482 distance from PT to the scroll margin position. This prevents
3483 try_scrolling from unnecessarily failing when
3484 scroll-conservatively is set to a value slightly larger than the
3485 window height. Clean up the case of PT below the margin at bottom
3486 of window: scroll_max can no longer be INT_MAX. When aggressive
3487 scrolling is in use, don't let point enter the opposite scroll
3488 margin as result of the scroll.
3489 (syms_of_xdisp) <scroll-conservatively>: Document the
3490 threshold of 100 lines for never-recentering scrolling.
3492 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3494 * dispextern.h (move_it_by_lines):
3495 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3496 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3497 (message_log_check_duplicate): Remove parameters `prev_bol' and
3498 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3499 (redisplay_internal): Remove parameter `preserve_echo_area',
3500 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3502 * indent.c (Fvertical_motion):
3503 * window.c (window_scroll_pixel_based, Frecenter):
3504 Don't pass `need_y_p' to `move_it_by_lines'.
3506 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3508 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3509 steal a few bits to be more compact.
3510 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3511 Remove unneeded casts.
3513 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3515 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3517 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3518 binding" message (bug#7967).
3520 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3522 Fix more problems found by GCC 4.6.0's static checks.
3524 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3525 Remove unused local var.
3527 * editfns.c (Fmessage_box): Remove unused local var.
3529 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3530 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3531 Omit unused local vars.
3532 * window.c (shrink_windows): Omit unused local var.
3533 * menu.c (digest_single_submenu): Omit unused local var.
3534 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3535 Omit unused local var.
3537 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3538 Don't assume string length fits in int.
3539 (keyremap_step, read_key_sequence): Use size_t for sizes.
3540 (read_key_sequence): Don't check last_real_key_start redundantly.
3542 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3543 instead of alloca (Bug#8344).
3545 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3546 (Fbacktrace_frame): Don't assume nframes fits in int.
3548 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3550 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3553 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3555 * cm.c (calccost): Turn while-do into do-while, for clarity.
3557 * keyboard.c (syms_of_keyboard): Use the same style as later
3558 in this function when indexing through an array. This also
3559 works around GCC bug 48267.
3561 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3563 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3565 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3566 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3568 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3569 This avoids undefined behavior on integer overflow, and is a bit
3570 more convenient anyway since it is compared to a size_t variable.
3572 Variadic C functions now count arguments with size_t, not int.
3573 This avoids an unnecessary limitation on 64-bit machines, which
3574 caused (substring ...) to crash on large vectors (Bug#8344).
3575 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3576 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3577 All variadic functions and their callers changed accordingly.
3578 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3579 * data.c (arith_driver, float_arith_driver): Likewise.
3580 * editfns.c (general_insert_function): Likewise.
3581 * eval.c (struct backtrace.nargs, interactive_p)
3582 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3583 (funcall_lambda, mark_backtrace): Likewise.
3584 * fns.c (concat): Likewise.
3585 * frame.c (x_set_frame_parameters): Likewise.
3586 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3587 0 if not found, not -1. All callers changed.
3589 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3590 (stack_copy_size): Now size_t, not int.
3591 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3593 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3595 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3596 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3597 All callers changed.
3599 * lisp.h (multibyte_char_to_unibyte):
3600 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3601 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3602 * character.h (CHAR_TO_BYTE8):
3603 * cmds.c (internal_self_insert):
3604 * editfns.c (general_insert_function):
3605 * keymap.c (push_key_description):
3606 * search.c (Freplace_match):
3607 * xdisp.c (message_dolog, set_message_1): All callers changed.
3609 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3611 * keyboard.c (safe_run_hook_funcall): New function.
3612 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3613 don't set the hook to nil, but remove the offending function instead.
3614 (Qcommand_hook_internal): Remove, unused.
3615 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3616 Vcommand_hook_internal.
3618 * eval.c (enum run_hooks_condition): Remove.
3619 (funcall_nil, funcall_not): New functions.
3620 (run_hook_with_args): Call each function through a `funcall' argument.
3621 Remove `cond' argument, now redundant.
3622 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3623 (Frun_hook_with_args_until_failure): Adjust accordingly.
3624 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3626 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3628 * dispextern.h (string_buffer_position): Remove declaration.
3630 * print.c (strout): Remove parameter `multibyte', unused since
3631 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3633 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3634 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3635 All callers changed.
3637 * w32.c (_wsa_errlist): Use braces for struct initializers.
3639 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3640 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3641 All callers changed.
3642 (string_buffer_position): Likewise. Also, make static (it's never
3643 used outside xdisp.c).
3644 (cursor_row_p): Remove parameter `w', unused since
3645 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3646 (decode_mode_spec): Remove parameter `precision', introduced during
3647 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3648 All callers changed.
3650 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3652 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3654 2011-03-27 Anders Lindgren <andlind@gmail.com>
3656 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3657 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3658 (ns_update_auto_hide_menu_bar): New functions.
3659 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3660 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3661 ns_constrain_all_frames.
3662 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3663 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3665 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3667 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3669 2011-03-27 Glenn Morris <rgm@gnu.org>
3671 * syssignal.h: Replace RETSIGTYPE with void.
3672 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3673 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3674 Replace SIGTYPE with void everywhere.
3675 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3676 * s/template.h (SIGTYPE): Remove commented out definition.
3678 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3680 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3681 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3683 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3685 * w32.c (read_unc_volume): Use parameter `henum', instead of
3686 global variable `wget_enum_handle'.
3688 * keymap.c (describe_vector): Remove parameters `indices' and
3689 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3690 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3692 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3694 * keyboard.c (timer_check): Remove parameter `do_it_now',
3695 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3696 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3697 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3699 * keyboard.c (read_char):
3700 * w32menu.c (w32_menu_display_help):
3701 * xmenu.c (show_help_event, menu_help_callback):
3702 Adjust calls to `show_help_echo'.
3704 * gtkutil.c (xg_maybe_add_timer):
3705 * keyboard.c (readable_events):
3706 * process.c (wait_reading_process_output):
3707 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3709 * insdel.c (adjust_markers_gap_motion):
3710 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3711 (gap_left, gap_right): Don't call it.
3713 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3715 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3716 incurred during fontification.
3718 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3720 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3721 (DEFVAR_PER_BUFFER): Don't pass it.
3723 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3724 (scrolling_window): Don't pass it.
3726 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3728 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3730 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3732 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3733 of variables specific to SELinux and computation of `encoded_absname'.
3735 * image.c (XPutPixel): Remove unused variable `height'.
3737 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3739 * unexw32.c (get_section_info): Remove unused variable `section'.
3741 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3742 (system_process_attributes): Remove unused variable `sess'.
3743 (sys_read): Remove unused variable `err'.
3745 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3746 (w32_wnd_proc): Remove unused variable `isdead'.
3747 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3748 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3749 (x_create_tip_frame): Remove unused variable `tem'.
3751 * w32inevt.c (w32_console_read_socket):
3752 Remove unused variable `no_events'.
3754 * w32term.c (x_draw_composite_glyph_string_foreground):
3755 Remove unused variable `width'.
3757 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3759 * w32term.c (x_set_glyph_string_clipping):
3760 Don't pass uninitialized region to CombineRgn.
3762 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3764 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3765 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3766 (Fx_close_connection): Remove unused variable `i'.
3768 * w32font.c (w32font_draw): Return number of glyphs.
3769 (w32font_open_internal): Remove unused variable `i'.
3770 (w32font_driver): Add missing initializer.
3772 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3773 (fill_in_menu): Remove unused variable `items_added'.
3775 * w32term.c (last_mouse_press_frame): Remove static global variable.
3776 (w32_clip_to_row): Remove unused variable `f'.
3777 (x_delete_terminal): Remove unused variable `i'.
3779 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3780 (NOTHING): Remove unused static global variable.
3781 (uniscribe_check_otf): Remove unused variable `table'.
3782 (uniscribe_font_driver): Add missing initializers.
3784 2011-03-23 Julien Danjou <julien@danjou.info>
3786 * term.c (Fsuspend_tty, Fresume_tty):
3787 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3788 * window.c (temp_output_buffer_show):
3789 * insdel.c (signal_before_change):
3790 * frame.c (Fhandle_switch_frame):
3791 * fileio.c (Fdo_auto_save):
3792 * emacs.c (Fkill_emacs):
3793 * editfns.c (save_excursion_restore):
3794 * cmds.c (internal_self_insert):
3795 * callint.c (Fcall_interactively):
3796 * buffer.c (Fkill_all_local_variables):
3797 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3799 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3800 unconditionnaly since it does the check itself.
3802 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3804 Fix more problems found by GCC 4.5.2's static checks.
3806 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3807 the first time through the loop, since we know p0 < p1 then.
3808 This also avoids a gcc -Wstrict-overflow warning.
3810 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3811 leading to a memory leak, possible in functions like
3812 load_charset_map_from_file that can allocate an unbounded number
3813 of objects (Bug#8318).
3815 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3816 that could (at least in theory) be that large.
3818 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3819 This is less likely to overflow, and avoids undefined behavior if
3820 overflow does occur. All callers changed. Use strtoul to scan
3821 for the unsigned long integer.
3822 (pint2hrstr): Simplify and tune code slightly.
3823 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3825 * scroll.c (do_scrolling): Work around GCC bug 48228.
3826 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3828 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3829 This also avoids a warning with gcc -Wstrict-overflow.
3830 (validate_x_resource_name): Simplify count usage.
3831 This also avoids a warning with gcc -Wstrict-overflow.
3833 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3836 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3838 * process.c (Fmake_network_process): Use socklen_t, not int,
3839 where POSIX says socklen_t is required in portable programs.
3840 This fixes a porting bug on hosts like 64-bit HP-UX, where
3841 socklen_t is wider than int (Bug#8277).
3842 (Fmake_network_process, server_accept_connection):
3843 (wait_reading_process_output, read_process_output):
3846 * process.c: Rename or move locals to avoid shadowing.
3847 (list_processes_1, Fmake_network_process):
3848 (read_process_output_error_handler, exec_sentinel_error_handler):
3849 Rename or move locals.
3850 (Fmake_network_process): Define label "retry_connect" only if needed.
3851 (Fnetwork_interface_info): Fix pointer signedness.
3852 (process_send_signal): Add cast to avoid pointer signedness problem.
3853 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3854 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3856 Make tparam.h and terminfo.c consistent.
3857 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3858 Include tparam.h instead, since it declares them.
3859 * cm.h (PC): Remove extern decl; tparam.h now does this.
3860 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3861 * terminfo.c: Include tparam.h, to check interfaces.
3862 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3863 (tparam): Adjust signature to match interface in tparam.h;
3864 this removes some undefined behavior. Check that outstring and len
3865 are zero, which they always are with Emacs.
3866 * tparam.h (PC, BC, UP): New extern decls.
3868 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3869 (xftfont_open): Rename locals to avoid shadowing.
3871 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3872 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3873 (OTF_TAG_SYM): Omit macro if not needed.
3874 (ftfont_list): Remove unused local.
3875 (get_adstyle_property, ftfont_pattern_entity):
3876 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3877 Rename locals to avoid shadowing.
3879 * xfont.c (xfont_list_family): Mark var as initialized.
3881 * xml.c (make_dom): Now static.
3883 * composite.c (composition_compute_stop_pos): Rename local to
3885 (composition_reseat_it): Remove unused locals.
3886 (find_automatic_composition, composition_adjust_point): Likewise.
3887 (composition_update_it): Mark var as initialized.
3888 (find_automatic_composition): Mark vars as initialized,
3889 with a FIXME (Bug#8290).
3891 character.h: Rename locals to avoid shadowing.
3892 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3893 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3894 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3895 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3898 * textprop.c (property_change_between_p): Remove; unused.
3900 * intervals.c (interval_start_pos): Now static.
3902 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3904 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3905 Rename locals to avoid shadowing.
3907 * sound.c (wav_play, au_play, Fplay_sound_internal):
3908 Fix pointer signedness.
3909 (alsa_choose_format): Remove unused local var.
3910 (wav_play): Initialize a variable to 0, to prevent undefined
3911 behavior (Bug#8278).
3913 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3915 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3917 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3918 clobbering (Bug#8298).
3919 * sysdep.c (sys_subshell): Likewise.
3920 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3922 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3923 This should get cleaned up, so that child_setup has the
3924 same signature on all platforms.
3926 * callproc.c (call_process_cleanup): Now static.
3927 (relocate_fd): Rename locals to avoid shadowing.
3929 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3931 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3932 not to be necessary, and produces flickering.
3934 2011-03-20 Glenn Morris <rgm@gnu.org>
3936 * config.in: Remove file.
3938 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3940 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3941 are now in src/globals.h.
3942 (syms_of_minibuf): Remove spurious & from previous change.
3944 2011-03-20 Leo <sdl.web@gmail.com>
3946 * minibuf.c (completing-read-function): New variable.
3947 (completing-read-default): Rename from completing-read.
3948 (completing-read): Call completing-read-function.
3950 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3952 * xfaces.c (Fx_load_color_file):
3953 Read color file from absolute filename (bug#8250).
3955 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3957 * makefile.w32-in: Update dependencies.
3959 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3961 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3963 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3965 Fix more problems found by GCC 4.5.2's static checks.
3967 * process.c (make_serial_process_unwind, send_process_trap):
3968 (sigchld_handler): Now static.
3970 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3971 That way, the code declares only the vars that it needs.
3972 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3973 * s/cygwin.h (PTY_ITERATION): Likewise.
3974 * s/darwin.h (PTY_ITERATION): Likewise.
3975 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3977 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3978 * process.c (allocate_pty): Don't declare stb unless it's needed.
3980 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3981 (CONSTANTLIM): Remove; unused.
3982 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3983 Define only if needed.
3985 * unexelf.c (unexec): Name an expression,
3986 to avoid gcc -Wbad-function-cast warning.
3987 Use a different way to cause a compilation error if anyone uses
3988 n rather than nn, a way that does not involve shadowing.
3989 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3991 * deps.mk (unexalpha.o): Remove; unused.
3993 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3994 * unexec.h: New file.
3995 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3996 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3998 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3999 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4000 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4001 Change as necessary to match prototype in unexec.h.
4003 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4005 (back_comment, skip_chars): Mark vars as initialized.
4007 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4008 Rename locals to avoid shadowing.
4010 * lread.c (read1): Rewrite so as not to use empty "else".
4011 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4013 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4015 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4016 warning when compiling print.c.
4018 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4019 instead of using an uninitialized var.
4020 (font_sort_entities): Mark var as initialized.
4022 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4024 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4025 pointers to constants.
4026 (font_parse_fcname): Remove unused vars.
4027 (font_delete_unmatched): Now static.
4028 (font_get_spec): Remove; unused.
4029 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4030 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4031 Rename or move locals to avoid shadowing.
4033 * fns.c (require_nesting_list, require_unwind): Now static.
4034 (Ffillarray): Rename locals to avoid shadowing.
4036 * floatfns.c (domain_error2): Define only if needed.
4037 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4039 * alloc.c (mark_backtrace): Move decl from here ...
4040 * lisp.h: ... to here, so that it can be checked.
4042 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4043 (Fdefvar): Rewrite so as not to use empty "else".
4044 (lisp_indirect_variable): Name an expression,
4045 to avoid gcc -Wbad-function-cast warning.
4046 (Fdefvar): Rename locals to avoid shadowing.
4048 * callint.c (quotify_arg, quotify_args): Now static.
4049 (Fcall_interactively): Rename locals to avoid shadowing.
4050 Use const pointer when appropriate.
4052 * lisp.h (get_system_name, get_operating_system_release):
4053 Move decls here, to check interfaces.
4054 * process.c (get_operating_system_release): Move decl to lisp.h.
4055 * xrdb.c (get_system_name): Likewise.
4056 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4057 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4058 some of which prompt warnings from gcc -Wbad-function-cast.
4059 (Fformat_time_string, Fencode_time, Finsert_char):
4060 (Ftranslate_region_internal, Fformat):
4061 Rename or remove local vars to avoid shadowing.
4062 (Ftranslate_region_internal): Mark var as initialized.
4064 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4067 * lisp.h (eassert): Check that the argument compiles, even if
4068 ENABLE_CHECKING is not defined.
4070 * data.c (Findirect_variable): Name an expression, to avoid
4071 gcc -Wbad-function-cast warning.
4072 (default_value, arithcompare, arith_driver, arith_error): Now static.
4073 (store_symval_forwarding): Rename local to avoid shadowing.
4074 (Fmake_variable_buffer_local, Fmake_local_variable):
4075 Mark variables as initialized.
4076 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4078 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4079 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4080 Rename locals to avoid shadowing.
4081 (mark_stack): Move local variables into the #ifdef region where
4083 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4084 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4086 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4087 (GC_STRING_CHARS): Remove; not used.
4088 (Fmemory_limit): Cast sbrk's returned value to char *.
4090 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4091 avoids undefined behavior in theory.
4093 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4095 Use functions, not macros, for up- and down-casing (Bug#8254).
4096 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4097 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4098 to use the following functions instead of these macros.
4099 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4100 EMACS_INT, since callers assume the returned value fits in int.
4101 (upcase1): Likewise, for UPCASE_TABLE.
4102 (uppercasep, lowercasep, upcase): New static inline functions.
4103 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4104 the race-condition problem in the old DOWNCASE.
4106 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4107 Rename locals to avoid shadowing.
4108 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4109 (regex_compile, re_search_2, re_match_2_internal):
4110 Remove unused local vars.
4111 (FREE_VAR): Rewrite so as not to use empty "else",
4112 which gcc can warn about.
4113 (regex_compile, re_match_2_internal): Mark locals as initialized.
4114 (RETALLOC_IF): Define only if needed.
4115 (WORDCHAR_P): Likewise. This one is never needed, but is used
4116 only in a comment talking about a compiler bug, so put inside
4117 the #if 0 of that comment.
4118 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4119 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4122 * search.c (boyer_moore): Rename locals to avoid shadowing.
4123 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4124 (PREV_CHAR_BOUNDARY): Likewise.
4126 * search.c (simple_search): Remove unused var.
4128 * dired.c (compile_pattern): Move decl from here ...
4129 * lisp.h: ... to here, so that it can be checked.
4130 (struct re_registers): New forward decl.
4132 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4134 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4136 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4137 Rename locals to avoid shadowing.
4138 (Fvertical_motion): Mark locals as initialized.
4140 * casefiddle.c (casify_object, casify_region): Now static.
4141 (casify_region): Mark local as initialized.
4143 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4145 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4146 New macros, so that the caller can use some names other than
4147 gcpro1, gcpro2, etc.
4148 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4150 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4151 argument, for consistency with GCPRO2_VAR, etc: it is now the
4152 prefix of the variable, not the variable itself. All uses
4154 * dired.c (directory_files_internal, file_name_completion):
4155 Rename locals to avoid shadowing.
4157 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4158 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4159 dired.c's scmp function, had undefined behavior.
4160 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4161 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4162 * buffer.h: ... to here, because these macros use current_buffer,
4163 and the new implementation with inline functions needs to have
4164 current_buffer in scope now, rather than later when the macros
4166 (downcase, upcase1): New static inline functions.
4167 (DOWNCASE, UPCASE1): Reimplement using these functions.
4168 This avoids undefined behavior in expressions like
4169 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4170 from race conditions in accessing the global variables
4171 case_temp1 and case_temp2.
4172 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4173 * lisp.h (case_temp1, case_temp2): Remove their decls.
4174 * character.h (ASCII_CHAR_P): Move from here ...
4175 * lisp.h: ... to here, so that the inline functions mentioned
4178 * dired.c (directory_files_internal_unwind): Now static.
4180 * fileio.c (file_name_as_directory, directory_file_name):
4181 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4183 (file_name_as_directory): Use const pointers when appropriate.
4184 (Fexpand_file_name): Likewise. In particular, newdir might
4185 point at constant storage, so make it a const pointer.
4186 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4187 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4189 (Fset_file_times, Finsert_file_contents, auto_save_error):
4190 Rename locals to avoid shadowing.
4192 * minibuf.c (choose_minibuf_frame_1): Now static.
4193 (Ftry_completion, Fall_completions): Rename or remove locals
4196 * marker.c (bytepos_to_charpos): Remove; unused.
4198 * lisp.h (verify_bytepos, count_markers): New decls,
4199 so that gcc does not warn that these functions aren't declared.
4201 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4202 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4203 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4204 (copy_text): Remove unused local var.
4206 * filelock.c (within_one_second): Now static.
4207 (lock_file_1): Rename local to avoid shadowing.
4209 * buffer.c (fix_overlays_before): Mark locals as initialized.
4210 (fix_start_end_in_overlays): Likewise. This function should be
4211 simplified by using pointers-to-pointers, but that's a different
4213 (switch_to_buffer_1): Now static.
4214 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4215 (report_overlay_modification): Rename locals to avoid shadowing.
4217 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4218 Fix pointer signedness issue.
4219 (sys_subshell): Mark local as volatile if checking for lint,
4220 to suppress a gcc -Wclobbered warning that does not seem to be right.
4221 (MAXPATHLEN): Define only if needed.
4223 * process.c (serial_open, serial_configure): Move decls from here ...
4224 * systty.h: ... to here, so that they can be checked.
4226 * fns.c (get_random, seed_random): Move extern decls from here ...
4227 * lisp.h: ... to here, so that they can be checked.
4229 * sysdep.c (reset_io): Now static.
4230 (wait_for_termination_signal): Remove; unused.
4232 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4233 (copy_keymap_item, append_key, push_text_char_description):
4235 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4236 (DENSE_TABLE_SIZE): Remove; unused.
4237 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4238 (describe_map_tree):
4239 Rename locals to avoid shadowing.
4241 * keyboard.c: Declare functions static if they are not used elsewhere.
4242 (echo_char, echo_dash, cmd_error, top_level_2):
4243 (poll_for_input, handle_async_input): Now static.
4244 (read_char, kbd_buffer_get_event, make_lispy_position):
4245 (make_lispy_event, make_lispy_movement, apply_modifiers):
4246 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4247 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4248 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4249 (read_key_sequence, read_char): Mark locals as initialized.
4250 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4252 * keyboard.h (make_ctrl_char): New decl.
4253 (mark_kboards): Move decl here ...
4254 * alloc.c (mark_kboards): ... from here.
4256 * lisp.h (force_auto_save_soon): New decl.
4258 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4259 (DEFINE_DUMMY_FUNCTION): New macro.
4260 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4262 (main): Add casts to avoid warnings
4263 if GCC considers string literals to be constants.
4265 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4267 * dbusbind.c: Pointer signedness fixes.
4268 (xd_signature, xd_append_arg, xd_initialize):
4269 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4270 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4271 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4272 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4274 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4275 if GCC considers string literals to be constants.
4276 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4278 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4280 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4281 (print_preprocess, print_object): New macro to fix last change.
4283 * print.c (print_preprocess): Don't forget font objects.
4285 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4287 * emacs.c (USAGE3): Doc fixes.
4289 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4291 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4294 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4296 * lisp.h (VWindow_system, Qfile_name_history):
4297 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4298 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4299 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4301 * w32select.c: Don't #include "keyboard.h".
4302 (run_protected): Add extern declaration for waiting_for_input.
4304 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4305 * w32console.c (detect_input_pending, read_input_pending)
4306 (encode_terminal_code):
4307 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4308 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4309 (w32_system_caret_y, Qfile_name_history):
4310 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4311 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4312 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4313 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4314 * w32proc.c (Qlocal, report_file_error):
4315 * w32term.c (Vwindow_system, updating_frame):
4316 * w32uniscribe.c (initialized, uniscribe_font_driver):
4317 Remove unneeded extern declarations.
4319 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4321 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4323 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4325 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4326 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4327 These macros can no longer be used for assignment.
4329 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4330 Assign struct members directly, instead of using BUF_BEGV etc.
4331 (record_buffer_markers, fetch_buffer_markers): New functions for
4332 recording and fetching special buffer markers.
4333 (set_buffer_internal_1, set_buffer_temp): Use them.
4335 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4337 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4339 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4340 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4342 * xdisp.c (hscroll_window_tree):
4343 (reconsider_clip_changes): Use PT instead of BUF_PT.
4345 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4347 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4348 $(EMACS_ROOT)/lib/intprops.h.
4350 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4352 Fix more problems found by GCC 4.5.2's static checks.
4354 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4355 to unsigned char * to avoid compiler diagnostic.
4356 (xg_free_frame_widgets): Make it clear that a local variable is
4357 needed only if USE_GTK_TOOLTIP.
4358 (gdk_window_get_screen): Make it clear that this macro is needed
4359 only if USE_GTK_TOOLTIP.
4360 (int_gtk_range_get_value): New function, which avoids a diagnostic
4361 from gcc -Wbad-function-cast.
4362 (xg_set_toolkit_scroll_bar_thumb): Use it.
4363 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4364 diagnostic from gcc -Wbad-function-cast.
4365 (get_utf8_string, xg_get_file_with_chooser):
4366 Rename locals to avoid shadowing.
4367 (create_dialog): Move locals to avoid shadowing.
4369 * xgselect.c (xg_select): Remove unused var.
4371 * image.c (four_corners_best): Mark locals as initialized.
4372 (gif_load): Initialize transparent_p to zero (Bug#8238).
4373 Mark another local as initialized.
4374 (my_png_error, my_error_exit): Mark with NO_RETURN.
4376 * image.c (clear_image_cache): Now static.
4377 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4378 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4379 (x_edge_detection): Remove unnecessary cast that
4380 gcc -Wbad-function-cast diagnoses.
4381 (gif_load): Fix pointer signedness.
4382 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4383 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4385 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4387 Improve quality of tests for time stamp overflow.
4388 For example, without this patch (encode-time 0 0 0 1 1
4389 1152921504606846976) returns the obviously-bogus value (-948597
4390 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4391 reports time overflow. See
4392 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4393 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4394 * editfns.c: Include limits.h and intprops.h.
4395 (TIME_T_MIN, TIME_T_MAX): New macros.
4396 (time_overflow): Move earlier, to before first use.
4397 (hi_time, lo_time): New functions, for an accurate test for
4399 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4400 (Fget_internal_run_time): Don't assume time_t fits in int.
4401 (make_time): Use list2 instead of Fcons twice.
4402 (Fdecode_time): More accurate test for out-of-range times.
4403 (check_tm_member): New function.
4404 (Fencode_time): Use it, to test for out-of-range times.
4405 (lisp_time_argument): Don't rely on undefined left-shift and
4406 right-shift behavior when checking for time stamp overflow.
4408 * editfns.c (time_overflow): New function, refactoring common code.
4409 (Fformat_time_string, Fdecode_time, Fencode_time):
4410 (Fcurrent_time_string): Use it.
4412 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4413 * dired.c (make_time): Move to ...
4414 * editfns.c (make_time): ... here.
4415 * systime.h: Note the move.
4417 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4419 * fringe.c (update_window_fringes): Remove unused variables.
4421 * unexmacosx.c (copy_data_segment): Also copy __got section.
4424 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4426 * termcap.c [MSDOS]: Include "msdos.h".
4427 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4428 Constify `char *' arguments and their references according to
4429 prototypes in tparam.h.
4431 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4433 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4434 Adapt all references accordingly.
4436 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4438 2011-03-11 Tom Tromey <tromey@redhat.com>
4440 * buffer.c (syms_of_buffer): Remove obsolete comment.
4442 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4444 * termhooks.h (encode_terminal_code): Declare prototype.
4446 * msdos.c (encode_terminal_code): Don't declare prototype.
4448 * term.c (encode_terminal_code): Now external again, used by
4449 w32console.c and msdos.c.
4451 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4452 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4454 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4456 Fix some minor problems found by GCC 4.5.2's static checks.
4458 * fringe.c (update_window_fringes): Mark locals as initialized
4460 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4462 * alloc.c (mark_fringe_data): Move decl from here ...
4463 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4464 to check its interface.
4465 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4467 * fontset.c (free_realized_fontset): Now static.
4468 (Fset_fontset_font): Rename local to avoid shadowing.
4469 (fontset_font): Mark local as initialized.
4470 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4472 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4474 * xselect.c (x_disown_buffer_selections): Remove; not used.
4475 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4476 (x_own_selection, Fx_disown_selection_internal): Rename locals
4478 (x_handle_dnd_message): Remove local to avoid shadowing.
4480 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4481 so that the caller can use some name other than gcpro1.
4482 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4483 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4484 (Fx_backspace_delete_keys_p):
4485 Use them to avoid shadowing, and rename vars to avoid shadowing.
4486 (x_decode_color, x_set_name, x_window): Now static.
4487 (Fx_create_frame): Add braces to silence GCC warning.
4488 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4489 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4490 Remove unused locals.
4491 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4492 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4493 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4496 * xterm.h (x_mouse_leave): New decl.
4498 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4499 Remove unused functions.
4500 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4501 (x_calc_absolute_position): Now static.
4502 (XTread_socket): Don't define label "out" unless it's used.
4503 Don't declare local "event" unless it's used.
4504 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4505 unless they are used.
4506 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4507 (x_fatal_error_signal): Remove; not used.
4508 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4509 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4510 (x_error_catcher, x_connection_closed, x_error_handler):
4511 (x_error_quitter, xembed_send_message, x_iconify_frame):
4512 (my_log_handler): Rename locals to avoid shadowing.
4513 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4514 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4516 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4517 Rename or move locals to avoid shadowing.
4518 (tty_defined_color, merge_face_heights): Now static.
4519 (free_realized_faces_for_fontset): Remove; not used.
4520 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4521 does not deduce is never used uninitialized.
4522 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4523 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4525 * terminal.c (store_terminal_param): Now static.
4527 * xmenu.c (menu_highlight_callback): Now static.
4528 (set_frame_menubar): Remove unused local.
4529 (xmenu_show): Rename parameter to avoid shadowing.
4530 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4531 since they might point to immutable storage.
4532 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4533 since it's unused otherwise.
4535 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4536 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4537 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4538 avoids a gcc -Wuninitialized diagnostic.
4539 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4540 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4541 does not deduce are never used uninitialized.
4543 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4545 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4546 * window.c (window_loop, size_window):
4547 (run_window_configuration_change_hook, enlarge_window): Likewise.
4549 * window.c (display_buffer): Now static.
4550 (size_window): Mark variables that gcc -Wuninitialized
4551 does not deduce are never used uninitialized.
4552 * window.h (check_all_windows): New decl, to forestall
4553 gcc -Wmissing-prototypes diagnostic.
4554 * dispextern.h (bidi_dump_cached_states): Likewise.
4556 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4558 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4560 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4561 and to avoid gcc -Wuninitialized warning.
4562 (load_charset_map): Mark variables that gcc -Wuninitialized
4563 does not deduce are never used uninitialized.
4564 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4566 * coding.c (coding_set_source, coding_set_destination):
4567 Use "else { /* comment */ }" rather than "else /* comment */;"
4568 for clarity, and to avoid gcc -Wempty-body warning.
4569 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4570 a block, when the outer 'i' will do.
4571 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4572 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4573 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4574 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4575 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4576 Rename locals to avoid shadowing.
4577 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4578 * coding.c (emacs_mule_char, encode_invocation_designation):
4579 Now static, since they're not used elsewhere.
4580 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4581 (decode_coding_object, encode_coding_object, detect_coding_system):
4582 (decode_coding_emacs_mule): Mark variables that gcc
4583 -Wuninitialized does not deduce are never used uninitialized.
4584 (detect_coding_iso_2022): Initialize a local variable that might
4585 be used uninitialized. Leave a FIXME because it's not clear that
4586 this initialization is needed. (Bug#8211)
4587 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4588 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4589 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4590 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4591 Remove unused macros.
4593 * category.c (hash_get_category_set): Remove unused local var.
4594 (copy_category_table): Now static, since it's not used elsewhere.
4595 * character.c (string_count_byte8): Likewise.
4597 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4598 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4600 * chartab.c (copy_sub_char_table): Now static, since it's not used
4602 (sub_char_table_ref_and_range, char_table_ref_and_range):
4603 Rename locals to avoid shadowing.
4604 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4606 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4607 (BIDI_BOB): Remove unused macro.
4609 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4610 deduce are never used uninitialized.
4611 * term.c (encode_terminal_code): Likewise.
4613 * term.c (encode_terminal_code): Now static. Remove unused local.
4615 * tparam.h: New file.
4616 * term.c, tparam.h: Include it.
4617 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4618 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4619 Move these decls to tparam.h, and make them agree with what
4620 is actually in tparam.c. The previous trick of using incompatible
4621 decls in different modules does not conform to the C standard.
4622 All callers of tparam changed to use tparam's actual API.
4623 * tparam.c (tparam1, tparam, tgoto):
4624 Use const pointers where appropriate.
4626 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4627 * cm.h (struct cm): Likewise.
4628 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4629 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4630 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4631 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4632 (turn_on_face, init_tty): Likewise.
4633 * termchar.h (struct tty_display_info): Likewise.
4635 * term.c (term_mouse_position): Rename local to avoid shadowing.
4637 * alloc.c (mark_ttys): Move decl from here ...
4638 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4640 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4642 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4644 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4646 * search.c (compile_pattern_1): Remove argument regp, unused since
4647 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4648 (compile_pattern): Don't pass it.
4650 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4652 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4653 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4655 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4657 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4659 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4660 gdk_window_get_screen, gdk_window_get_geometry,
4661 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4662 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4663 (xg_get_pixbuf_from_pixmap): New function.
4664 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4665 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4666 Call xg_get_pixbuf_from_pixmap instead of
4667 gdk_pixbuf_get_from_drawable.
4668 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4669 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4670 (xg_check_special_colors): Use GtkStyleContext and its functions
4672 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4673 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4674 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4675 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4676 Call gtk_widget_get_preferred_size.
4677 (xg_frame_resized): gdk_window_get_geometry only takes 5
4679 (xg_win_to_widget, xg_event_is_for_menubar):
4680 Call gdk_x11_window_lookup_for_display.
4681 (xg_set_widget_bg): New function.
4682 (delete_cb): New function.
4683 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4684 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4685 (xg_set_background_color): Call xg_set_widget_bg.
4686 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4687 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4688 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4689 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4691 (update_frame_tool_bar): Call gtk_widget_hide.
4692 (xg_initialize): Use GDK_KEY_g.
4694 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4696 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4698 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4699 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4700 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4702 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4704 * w32xfns.c (select_palette): Check success of RealizePalette against
4705 GDI_ERROR, not zero.
4707 See ChangeLog.11 for earlier changes.
4713 Copyright (C) 2011 Free Software Foundation, Inc.
4715 This file is part of GNU Emacs.
4717 GNU Emacs is free software: you can redistribute it and/or modify
4718 it under the terms of the GNU General Public License as published by
4719 the Free Software Foundation, either version 3 of the License, or
4720 (at your option) any later version.
4722 GNU Emacs is distributed in the hope that it will be useful,
4723 but WITHOUT ANY WARRANTY; without even the implied warranty of
4724 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4725 GNU General Public License for more details.
4727 You should have received a copy of the GNU General Public License
4728 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.