1 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7 * fileio.c: Fix bugs with large file offsets (Bug#9428).
8 The previous code assumed that file offsets (off_t values) fit in
9 EMACS_INT variables, which is not true on typical 32-bit hosts.
10 The code messed up by falsely reporting buffer overflow in cases
11 such as (insert-file-contents "big" nil 1 2) into an empty buffer
12 when "big" contains more than 2**29 bytes, even though this
13 inserts just one byte and does not overflow the buffer.
14 (Finsert_file_contents): Store file offsets as off_t
15 values, not as EMACS_INT values. Check for overflow when
16 converting between EMACS_INT and off_t. When checking for
17 buffer overflow or for overlap, take the offsets into account.
18 Don't use EMACS_INT for small values where int suffices.
19 When checking for overlap, fix a typo: ZV was used where
21 (Fwrite_region): Don't assume off_t fits into 'long'.
22 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
24 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
26 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
28 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
30 sprintf-related integer and memory overflow issues (Bug#9412).
32 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
33 (esprintf, exprintf, evxprintf): New functions.
34 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
35 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
36 (modify_event_symbol): Do not assume that the length of
37 name_alist_or_stem is safe to alloca and fits in int.
38 (Fexecute_extended_command): Likewise for function name and binding.
39 (Frecursion_depth): Wrap around reliably on integer overflow.
40 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
41 since some callers pass EMACS_INT values.
42 (Fsingle_key_description): Don't crash if symbol name contains more
43 than MAX_ALLOCA bytes.
44 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
45 (get_minibuffer): Arg is now EMACS_INT, not int.
46 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
47 (esprintf, exprintf, evxprintf): New decls.
48 * window.h (command_loop_level, minibuf_level): Reflect API changes.
50 * dbusbind.c (signature_cat): New function.
51 (xd_signature, Fdbus_register_signal):
52 Do not overrun buffer; instead, report string overflow.
54 * dispnew.c (add_window_display_history): Don't overrun buffer.
55 Truncate instead; this is OK since it's just a log.
57 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
58 even if the time zone offset is outlandishly large.
59 Don't mishandle offset == INT_MIN.
61 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
62 when creating daemon; the previous buffer-overflow check was incorrect.
64 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
65 which has the guts of the old verror function.
67 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
68 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
70 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
71 (font_unparse_xlfd): Don't blindly alloca long strings.
72 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
73 fits in int, when using sprintf. Use single snprintf to count
74 length of string rather than counting it via multiple sprintfs;
75 that's simpler and more reliable.
76 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
77 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
78 sprintf, in case result does not fit in int.
80 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
81 (fontset_from_font): Print it.
83 * frame.c (tty_frame_count): Now printmax_t, not int.
84 (make_terminal_frame, set_term_frame_name): Print it.
85 (x_report_frame_params): In X, window IDs are unsigned long,
86 not signed long, so print them as unsigned.
87 (validate_x_resource_name): Check for implausibly long names,
88 and don't assume name length fits in 'int'.
89 (x_get_resource_string): Don't blindly alloca invocation name;
90 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
93 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
94 (xg_check_special_colors, xg_set_geometry):
95 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
97 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
98 Use esprintf, not sprintf, in case result does not fit in int.
100 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
101 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
102 it as a large positive number.
103 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
104 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
106 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
107 in case result does not fit in int.
109 * print.c (float_to_string): Detect width overflow more reliably.
110 (print_object): Make sprintf buffer a bit bigger, to avoid potential
111 buffer overrun. Don't assume list length fits in 'int'. Treat
112 print length of 0 as 0, not as infinity; to be consistent with other
113 uses of print length in this function. Don't overflow print length
114 index. Don't assume hash table size fits in 'long', or that
115 vectorlike size fits in 'unsigned long'.
117 * process.c (make_process): Use printmax_t, not int, to format
118 process-name gensyms.
120 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
122 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
123 to avoid potential buffer overrun.
125 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
126 if X resource line is longer than 512 bytes.
128 * xfns.c (x_window): Make sprintf buffer a bit bigger
129 to avoid potential buffer overrun.
131 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
133 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
135 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
137 Integer overflow fixes for scrolling, etc.
138 Without these, Emacs silently mishandles large integers sometimes.
139 For example, "C-u 4294967297 M-x recenter" was treated as if
140 it were "C-u 1 M-x recenter" on a typical 64-bit host.
142 * xdisp.c (try_window_id): Check Emacs fixnum range before
145 * window.c (window_scroll_line_based, Frecenter):
146 Check that an Emacs fixnum is in range before assigning it to 'int'.
147 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
148 values converted from Emacs fixnums.
149 (Frecenter): Don't wrap around a line count if it is out of 'int'
150 range; instead, treat it as an extreme value.
151 (Fset_window_configuration, compare_window_configurations):
152 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
154 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
155 that can exceed INT_MAX. Check that EMACS_INT value is in range
156 before assigning it to the (possibly-narrower) index.
157 (match_limit): Don't assume that a fixnum can fit in 'int'.
159 * print.c (print_object): Use ptrdiff_t, not int, for index that can
162 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
163 (Fvertical_motion): Don't wrap around LINES values that don't fit
164 in 'int'. Instead, treat them as extreme values. This is good
165 enough for windows, which can't have more than INT_MAX lines anyway.
167 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
169 * Require libxml/parser.h to avoid compilation warning.
171 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
173 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
174 since this reportedly can destroy thread storage.
176 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
178 * syntax.c (find_defun_start): Update all cache variables if
179 exiting early (Bug#9401).
181 2011-08-30 Eli Zaretskii <eliz@gnu.org>
183 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
185 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
186 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
187 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
189 * term.c (tty_append_glyph): New function.
190 (produce_stretch_glyph): Static function and its prototype deleted.
192 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
195 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
197 * image.c (parse_image_spec): Check for nonnegative, not for positive,
198 when checking :margin (Bug#9390).
199 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
200 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
201 so that the name doesn't mislead. All uses changed.
203 2011-08-28 Johan Bockgård <bojohan@gnu.org>
205 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
208 2011-08-27 Eli Zaretskii <eliz@gnu.org>
210 * xdisp.c (move_it_to): Don't bail out early when reaching
211 position beyond to_charpos, if we are scanning backwards.
212 (move_it_vertically_backward): When DY == 0, make sure we get to
213 the first character in the line after the newline.
215 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
217 * ccl.c: Improve and simplify overflow checking (Bug#9196).
218 (ccl_driver): Do not generate an out-of-range pointer.
219 (Fccl_execute_on_string): Remove unnecessary check for
220 integer overflow, noted by Stefan Monnier in
221 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
222 Remove a FIXME that didn't need fixing.
223 Simplify the newly-introduced buffer reallocation code.
225 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
227 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
229 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
231 Integer and memory overflow issues (Bug#9196).
233 * doc.c (get_doc_string): Rework so that
234 get_doc_string_buffer_size is the actual buffer size, rather than
235 being 1 less than the actual buffer size; this makes xpalloc more
238 * image.c (x_allocate_bitmap_record, cache_image):
239 * xselect.c (Fx_register_dnd_atom):
240 Simplify previous changes by using xpalloc.
242 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
243 since either will do and ptrdiff_t is convenient with xpalloc.
245 * charset.c (charset_table_size)
246 (struct charset_sort_data.priority): Now ptrdiff_t.
247 (charset_compare): Don't overflow if priorities differ greatly.
248 (Fsort_charsets): Don't assume list length fits in int.
249 Check for size-calculation overflow when allocating sort data.
250 (syms_of_charset): Allocate an initial charset table that is
251 just under 64 KiB, to avoid problems with glibc malloc and mmap.
253 * cmds.c (internal_self_insert): Check for size-calculation overflow.
255 * composite.h (struct composition.glyph_len): Now int, not unsigned.
256 The actual value is always <= INT_MAX, and leaving it unsigned made
257 overflow checking harder.
259 * dispextern.h (struct glyph_matrix.rows_allocated)
260 (struct face_cache.size): Now ptrdiff_t, for convenience in use
261 with xpalloc. The values are still always <= INT_MAX.
263 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
265 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
266 (SAFE_NALLOCA): New macro.
268 * region-cache.c (struct boundary.pos, find_cache_boundary)
269 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
270 (set_cache_region, invalidate_region_cache)
271 (revalidate_region_cache, know_region_cache, region_cache_forward)
272 (region_cache_backward, pp_cache):
273 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
274 so that ptrdiff_t * can be passed to xpalloc.
275 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
276 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
277 (pp_cache): Don't assume cache_len fits in int.
278 * region-cache.h: Adjust extern decls to match.
280 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
281 EMACS_INT, since either will do, for xpalloc.
283 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
284 (xnmalloc, xnrealloc, xpalloc): New functions.
286 * bidi.c (bidi_shelve_header_size): New constant.
287 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
288 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
290 * bidi.c (bidi_cache_shrink):
291 * buffer.c (overlays_at, overlays_in, record_overlay_string)
293 Don't update size of array until after memory allocation succeeds,
294 because xmalloc/xrealloc may not return.
295 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
296 now that we have proper integer overflow checking.
297 (record_overlay_string, overlay_strings): Catch overflows when
298 calculating size of overlay_str_buf.
300 * callproc.c (Fcall_process): Check for size overflow when
301 calculating size of args2.
302 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
303 Normally we prefer signed values, but sticking with ptrdiff_t would
304 require adding more-complicated checks.
306 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
307 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
308 Redo buffer-overflow calculations to avoid integer overflow.
309 Add a FIXME comment where memory seems to be over-allocated.
311 * character.c (Fstring): Check for size-calculation overflow.
313 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
314 unnecessary integer overflow. Check for size overflow.
315 (encode_coding_object): Don't update size until xmalloc succeeds.
317 * composite.c (get_composition_id): Check for overflow in glyph
320 Integer and memory overflow fixes for display code.
321 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
322 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
323 (scrolling_window): Check for overflow in size calculations.
324 (line_draw_cost, realloc_glyph_pool, add_row_entry):
325 Don't assume glyph table len fits in int.
326 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
327 (row_table_size): Now ptrdiff_t, not int.
328 (scrolling_window): Avoid overflow in size calculations.
329 Don't update size until allocation succeeds.
330 * fns.c (concat): Check for overflow in size calculations.
331 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
332 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
333 (NEXT_ALMOST_PRIME_LIMIT): New constant.
335 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
336 (get_doc_string): Check for size calculation overflow.
337 Don't update size until allocation succeeds.
338 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
339 EMACS_INT, where ptrdiff_t will do.
340 (Fsubstitute_command_keys): Check for string overflow.
342 * editfns.c (set_time_zone_rule): Don't assume environment length
344 (message_length): Now ptrdiff_t, not int.
345 (Fmessage_box): Don't update size until allocation succeeds.
346 Don't assume message length fits in int.
347 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
349 * emacs.c (main): Do not reallocate argv, since there is a null at
350 the end that can be overwritten, and this way there's no need to
351 worry about size-calculation overflow.
352 (sort_args): Check for size-calculation overflow.
354 * eval.c (init_eval_once, grow_specpdl): Don't update size until
356 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
358 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
359 (x_set_scroll_bar_width, x_figure_window_size):
360 Check for integer overflow.
361 (x_set_alpha): Do not assume XINT fits in int.
363 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
364 This is for the members text_lines, text_cols, total_lines, total_cols,
365 where the system imposes an 'int' limit.
367 * fringe.c (Fdefine_fringe_bitmap):
368 Don't update size until alloc works.
370 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
371 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
373 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
374 Check for size-calculation overflow.
375 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
376 do, as we prefer signed integers.
377 (id_to_widget.max_size, id_to_widget.used)
378 (xg_store_widget_in_map, xg_remove_widget_from_map)
379 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
380 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
381 Use and return ptrdiff_t, not int.
382 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
383 * gtkutil.h: Change prototypes to match the above.
385 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
386 are duplicate now that they've been promoted to lisp.h.
387 (x_allocate_bitmap_record, x_alloc_image_color)
388 (make_image_cache, cache_image, xpm_load):
389 Don't update size until alloc is done.
390 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
392 Check for size calculation overflow.
393 (ct_colors_allocated_max): New constant.
394 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
397 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
398 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
399 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
400 Use ptrdiff_t, not int, to count maps.
401 (read_char_minibuf_menu_prompt): Check for overflow in size
402 calculations. Don't update size until allocation succeeds. Redo
403 calculations to avoid overflow.
404 * keyboard.h: Change prototypes to match the above.
406 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
408 (current_minor_maps): Check for size calculation overflow.
409 * keymap.h: Change prototypes to match the above.
411 * lread.c (read1, init_obarray): Don't update size until alloc done.
413 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
414 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
416 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
417 Now ptrdiff_t, not int.
418 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
419 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
421 * process.c (Fnetwork_interface_list): Check for overflow
424 * region-cache.c (move_cache_gap): Check for size calculation overflow.
426 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
427 overflow. Don't bother calling xmalloc when xrealloc will do.
429 * search.c (Freplace_match): Check for size calculation overflow.
430 (Fset_match_data): Don't assume list lengths fit in 'int'.
432 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
433 for command line length. Do not attempt to address one before the
434 beginning of an array, as that's not portable.
436 * term.c (max_frame_lines): Remove; unused.
437 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
439 (encode_terminal_code, calculate_costs): Check for size
440 calculation overflow.
441 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
442 table lengths and related sizes. Don't update size until alloc
443 done. Redo calculations to avoid overflow.
444 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
446 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
447 subtracting pointers.
448 (gobble_line): Check for overflow more carefully. Don't update size
451 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
452 Don't update size until alloc done.
453 Redo size calculations to avoid overflow.
454 Check for size calculation overflow.
455 (main) [DEBUG]: Fix typo in invoking tparam1.
457 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
458 Use ptrdiff_t, not int, for sizes.
459 (store_mode_line_noprop_char): Don't update size until alloc done.
461 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
462 Use ptrdiff_t, not int, for sizes.
463 (Finternal_make_lisp_face, cache_face):
464 Check for size calculation overflow.
465 (cache_face): Treat size calculation overflows as if they were
466 memory exhaustion (the usual treatment), rather than aborting.
468 * xfns.c (x_encode_text, x_set_name_internal)
469 (Fx_change_window_property): Use ptrdiff_t, not int, to count
470 sizes, since they can exceed INT_MAX in size. Check for size
471 calculation overflow.
473 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
474 (xg_select): Check for size calculation overflow.
475 Don't update size until alloc done.
477 * xrdb.c (get_environ_db): Don't assume path length fits in int,
478 as sprintf is limited to int lengths.
480 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
481 (X_LONG_MIN): New macros.
482 Use them to make the following changes clearer.
483 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
484 This change doesn't affect the value now, but it may help remind
485 future maintainers not to raise the value too much later.
486 (SELECTION_QUANTUM): Remove, replacing with ...
487 (selection_quantum): ... new function, which avoids overflow.
489 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
490 assumption that selection length fits in 'int'.
491 (x_reply_selection_request, x_handle_selection_request)
492 (x_get_window_property, receive_incremental_selection)
493 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
494 (lisp_data_to_selection_data, clean_local_selection_data):
495 Use ptrdiff_t, not int, to record length of selection.
496 (x_reply_selection_request, x_get_window_property)
497 (receive_incremental_selection, x_property_data_to_lisp):
498 Redo calculations to avoid overflow.
499 (x_reply_selection_request): When sending hint, ceiling it at
500 X_LONG_MAX rather than relying on wraparound overflow to send
502 (x_get_window_property, receive_incremental_selection)
503 (lisp_data_to_selection_data, x_property_data_to_lisp):
504 Check for size-calculation overflow.
505 (x_get_window_property, receive_incremental_selection)
506 (lisp_data_to_selection_data, Fx_register_dnd_atom):
507 Don't store size until memory allocation succeeds.
508 (x_get_window_property): Plug memory leak on memory exhaustion.
509 Don't double-block input; malloc is safe here. Don't assume 2**34
510 - 4 fits in unsigned long. Add an xassert to check
511 XGetWindowProperty overflow. Be more careful about overflow
512 calculations, and distinguish size from memory overflow better.
513 (receive_incremental_selection): When tracing, don't assume
514 unsigned int is less than INT_MAX.
515 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
516 harmful) conversions of unsigned short to int.
517 (lisp_data_to_selection_data): Don't assume that integers
518 in the range -65535 through -1 fit in an X unsigned short.
519 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
520 result parameters unless successful. Rely on cons_to_unsigned
521 to report problems with elements; the old code wasn't right anyway.
522 (x_check_property_data): Check for int overflow; we cannot use
523 a wider type due to X limits.
524 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
526 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
528 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
529 (x_term_init): Check for size calculation overflow.
530 (x_color_cells): Don't store size until memory allocation succeeds.
531 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
532 Don't assume alloca size is less than MAX_ALLOCA.
533 (x_term_init): Don't assume length fits in int (sprintf is limited
536 Use ptrdiff_t for composition IDs.
537 * character.c (lisp_string_width):
538 * composite.c (composition_table_size, n_compositions)
539 (get_composition_id, composition_gstring_from_id):
540 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
541 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
542 * window.c (Frecenter):
543 Use ptrdiff_t, not int, for composition IDs.
544 * composite.c (get_composition_id): Check for integer overflow.
545 * composite.h: Adjust prototypes to match the above changes.
547 Use ptrdiff_t for hash table indexes.
548 * category.c (hash_get_category_set):
549 * ccl.c (ccl_driver):
550 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
551 * coding.c (coding_system_charset_list, detect_coding_system):
552 * coding.h (struct coding_system.id):
553 * composite.c (get_composition_id, gstring_lookup_cache):
554 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
555 * image.c (xpm_get_color_table_h):
556 * lisp.h (hash_lookup, hash_put):
557 * minibuf.c (Ftest_completion):
558 Use ptrdiff_t for hash table indexes, not int (which is too
559 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
560 32-bit --with-wide-int hosts).
562 * charset.c (Fdefine_charset_internal): Check for integer overflow.
563 Add a FIXME comment about memory leaks.
564 (syms_of_charset): Don't assume xmalloc returns.
566 Don't assume that stated character widths fit in int.
567 * character.c (Fchar_width, c_string_width, lisp_string_width):
568 * character.h (CHAR_WIDTH):
569 * indent.c (MULTIBYTE_BYTES_WIDTH):
570 Use sanitize_char_width to avoid undefined and/or bad behavior
571 with outlandish widths.
572 * character.h (sanitize_tab_width): Renamed from sanitize_width,
573 now that we have two such functions. All uses changed.
574 (sanitize_char_width): New inline function.
576 Don't assume that tab-width fits in int.
577 * character.h (sanitize_width): New inline function.
578 (SANE_TAB_WIDTH): New macro.
579 (ASCII_CHAR_WIDTH): Use it.
580 * indent.c (sane_tab_width): Remove. All uses replaced by
581 SANE_TAB_WIDTH (current_buffer).
582 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
584 * fileio.c: Integer overflow issues with file modes.
585 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
587 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
588 Remove unreachable code.
589 (read_hex, load_charset_map_from_file): Check for integer overflow.
591 * xterm.c: don't go over XClientMessageEvent limit
592 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
593 (x_send_scroll_bar_event): Likewise. Check that the size does not
594 exceed limits imposed by XClientMessageEvent, as well as the usual
595 ptrdiff_t and size_t limits.
597 * keyboard.c: Overflow, signedness and related fixes.
598 (make_lispy_movement): Use same integer type in forward decl
599 that is used in the definition.
600 (read_key_sequence, keyremap_step):
601 Change bufsize argument back to int, undoing my 2011-03-30 change.
602 We prefer signed types, and int is wide enough here.
603 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
604 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
605 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
606 length, not size_t. Use ptrdiff_t for index, not int.
607 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
608 possibility of integer overflow.
610 Overflow, signedness and related fixes for images.
612 * dispextern.h (struct it.stack[0].u.image.image_id)
613 (struct_it.image_id, struct image.id, struct image_cache.size)
614 (struct image_cache.used, struct image_cache.ref_count):
615 * gtkutil.c (update_frame_tool_bar):
616 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
617 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
618 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
619 * nsmenu.m (update_frame_tool_bar):
620 * xdisp.c (calc_pixel_width_or_height):
621 * xfns.c (image_cache_refcount):
622 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
623 on typical 64-bit hosts.
625 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
626 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
627 Omit unnecessary casts to int.
628 (parse_image_spec): Check that integers fall into 'int' range
629 when the callers expect that.
630 (image_ascent): Redo ascent calculation to avoid int overflow.
631 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
632 (lookup_image): Remove unnecessary tests.
633 (xbm_image_p): Locals are now of int, not EMACS_INT,
634 since parse_image_check makes sure they fit into int.
635 (png_load, gif_load, svg_load_image):
636 Prefer int to unsigned where either will do.
637 (tiff_handler): New function, combining the cores of the
638 old tiff_error_handler and tiff_warning_handler. This
639 function is rewritten to use vsnprintf and thereby avoid
640 stack buffer overflows. It uses only the features of vsnprintf
641 that are common to both POSIX and native Microsoft.
642 (tiff_error_handler, tiff_warning_handler): Use it.
643 (tiff_load, gif_load, imagemagick_load_image):
644 Don't assume :index value fits in 'int'.
645 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
646 (imagemagick_load_image): Check that crop parameters fit into
647 the integer types that MagickCropImage accepts. Don't assume
648 Vimagemagick_render_type has a nonnegative value. Don't assume
649 size_t fits in 'long'.
650 (gs_load): Use printmax_t to print the widest integers possible.
651 Check for integer overflow when computing image height and width.
653 2011-08-26 Eli Zaretskii <eliz@gnu.org>
655 * xdisp.c (redisplay_window): Don't force window start if point
656 will be invisible in the resulting window. (Bug#9324)
658 2011-08-25 Eli Zaretskii <eliz@gnu.org>
660 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
661 the display spec is of the form `(space ...)'.
662 (handle_display_spec): Return the value returned by
663 handle_single_display_spec, not just 1 or zero.
664 (handle_single_display_spec): If the display spec is of the form
665 `(space ...)', and specifies display in the text area, return 2
667 (try_cursor_movement): Check for the need to scroll more
668 accurately, and prefer exact match for point under bidi. Don't
669 advance `row' beyond the last row of the window.
671 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
672 into disp_prop; all users changed.
674 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
675 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
676 for the text covered by the display property.
678 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
680 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
681 Change return value to nil.
682 (Frecord_buffer): Delete unused function.
684 2011-08-24 Eli Zaretskii <eliz@gnu.org>
686 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
687 buffers, return left-to-right.
688 (set_cursor_from_row): Consider candidate row a win if its glyph
689 represents a newline and point is on that newline. Fixes cursor
690 positioning on the newline at EOL of R2L text within L2R
691 paragraph, and vice versa.
692 (try_cursor_movement): Check continued rows, in addition to
693 continuation rows. Fixes unwarranted scroll when point enters a
694 continued line of R2L text within an L2R paragraph, or vice versa.
695 (cursor_row_p): Consider the case of point being equal to
696 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
697 from the end of a short line to the beginning of a continued line
698 of R2L text within L2R paragraph.
699 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
702 * bidi.c (bidi_check_type): Use xassert.
703 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
706 2011-08-23 Eli Zaretskii <eliz@gnu.org>
708 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
711 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
713 * nsfont.m (ns_otf_to_script): Fix typo.
715 2011-08-22 Kenichi Handa <handa@m17n.org>
717 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
718 extra slot even if the purpose is char-code-property-table.
720 2011-08-23 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (redisplay_window): When computing centering_position,
723 account for the height of the header line. (Bug#8874)
725 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
726 instead of CHAR_TO_BYTE. Fixes a crash when a completion
727 candidate is selected by the mouse, and that candidate has a
728 composed character under the mouse.
730 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
731 coordinates reported by pos-visible-in-window-p for a composed
732 character in column zero.
734 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
736 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
738 2011-08-22 Eli Zaretskii <eliz@gnu.org>
740 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
741 consider it a hit if to_charpos is anywhere in the range of the
742 composed buffer positions.
744 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
746 * image.c (gif_load): Don't assume that each subimage has the same
747 dimensions as the base image. Handle disposal method that is
748 "undefined" by the gif spec (Bug#9335).
750 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
752 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
753 (Fcondition_case): Document `debug' symbol in error handler.
755 2011-08-19 Eli Zaretskii <eliz@gnu.org>
757 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
758 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
759 from an Org mode buffer to a Speedbar frame.
761 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
762 a composition, take its buffer position from IT->cmp_it.charpos.
763 Fixes cursor positioning at the beginning of a line that begins
764 with a composed character.
766 2011-08-18 Eli Zaretskii <eliz@gnu.org>
768 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
769 character bidirectional type, use STRONG_L instead. Fixes crashes
770 in a buffer produced by `describe-categories'.
772 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
773 members before the level stack, so they would be saved and
774 restored when copying iterator state. Fixes incorrect reordering
775 around TABs covered by display properties.
777 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
779 * process.c (Fnetwork_interface_list): Correctly determine buffer
782 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
784 * eval.c (internal_condition_case, internal_condition_case_1)
785 (internal_condition_case_2, internal_condition_case_n):
786 Remove unnecessary aborts (Bug#9081).
788 2011-08-17 Eli Zaretskii <eliz@gnu.org>
790 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
791 has no `load' handler, try opening the file locally. (Bug#9311)
793 2011-08-16 Ken Brown <kbrown@cornell.edu>
795 * gmalloc.c: Expand comment.
797 2011-08-16 Eli Zaretskii <eliz@gnu.org>
799 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
800 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
802 2011-08-16 Ken Brown <kbrown@cornell.edu>
804 Fix memory allocation problems in Cygwin build (Bug#9273).
806 * unexcw.c ( __malloc_initialized): Declare external variable.
807 (fixup_executable): Force the dumped emacs to reinitialize malloc.
809 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
811 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
813 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
815 [CYGWIN] (special_realloc): New function.
816 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
817 requests to realloc storage in the static heap.
819 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
821 * bidi.c (bidi_initialize): Remove unused local.
823 2011-08-15 Eli Zaretskii <eliz@gnu.org>
825 * biditype.h: File removed.
827 * bidimirror.h: File removed.
829 * deps.mk (bidi.o): Remove biditype.h and
832 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
835 * dispextern.h: Fix a typo in the comment to bidi_type_t.
837 * chartab.c: Improve commentary for the uniprop_table API.
839 * bidi.c (bidi_paragraph_init): Support zero value of
840 bidi_ignore_explicit_marks_for_paragraph_level.
841 (bidi_initialize): Use uniprop_table instead of including
842 biditype.h and bidimirror.h.
844 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
845 coordinates of the iterator when restoring from ppos_it.
848 2011-08-14 Kenichi Handa <handa@m17n.org>
850 * process.c (create_process): Call setup_process_coding_systems
851 after the pid of the process is set to -1 (Bug#8162).
853 2011-08-14 Eli Zaretskii <eliz@gnu.org>
855 * xdisp.c (move_it_in_display_line_to): Don't invoke
856 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
857 ppos_it. Fixes vertical cursor motion when line beginning is
858 covered by an image. (Bug#9296)
860 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
862 * nsterm.h (ns_run_ascript): Declare.
863 (NSAPP_DATA2_RUNASSCRIPT): Define.
865 * nsfns.m (as_script, as_result, as_status): New static variables.
866 (ns_run_ascript): New function.
867 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
868 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
869 the event loop. Get status from as_status (Bug#7276).
871 * nsterm.m (sendEvent): If event is NSApplicationDefined and
872 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
873 the event loop (Bug#7276).
875 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
877 * gnutls.c (QCgnutls_bootprop_priority)
878 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
879 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
880 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
881 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
882 (QCgnutls_bootprop_verify_hostname_error)
883 (QCgnutls_bootprop_callbacks_verify): Rename from
884 Qgnutls_bootprop_..., all uses changed.
886 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
889 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
891 * xfaces.c (Qframe_set_background_mode): Now static.
892 * dispextern.h (Qframe_set_background_mode): Remove decl.
894 * process.c (Fnetwork_interface_info): Declare local only if needed.
896 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
898 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
899 (Fnetwork_interface_list): Allocate in increments of bytes instead
900 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
901 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
903 (struct ifflag_def): notrailers is smart on OSX.
904 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
905 Get hardware address with getifaddrs if available.
907 2011-08-12 Eli Zaretskii <eliz@gnu.org>
909 * xdisp.c (iterate_out_of_display_property): xassert that
910 IT->position is set to within IT->object's boundaries. Break from
911 the loop as soon as EOB is reached; avoids infloops in redisplay
912 when IT->position is set up wrongly due to some bug.
913 Set IT->current to match the bidi iterator unconditionally.
914 (push_display_prop): Allow GET_FROM_STRING as IT->method on
915 entry. Force push_it to save on the stack the current
916 buffer/string position, to be restored by pop_it. Fix flags in
917 the iterator structure wrt the object coming from a display
918 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
919 properties. (Bug#9284)
921 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
923 * fontset.c (fontset_get_font_group): Add proper type checks.
926 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
928 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
929 and LC_VERSION_MIN_MACOSX.
930 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
931 (dump_it) [LC_FUNCTION_STARTS]: Use it.
933 2011-08-08 Eli Zaretskii <eliz@gnu.org>
935 * xdisp.c (forward_to_next_line_start): Allow to use the
936 no-display-properties-and-no-overlays under bidi display.
937 Set disp_pos in the bidi iterator to avoid searches for display
938 properties and overlays.
940 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
942 * editfns.c (Fset_time_zone_rule): Document relationship with the
945 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
946 the font entity extracted from the cache (Bug#8109).
948 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
950 * composite.c (autocmp_chars): Don't reset point. That is done by
951 restore_point_unwind (Bug#5984).
953 2011-08-07 Juri Linkov <juri@jurta.org>
955 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
956 to show the arg `TIME' instead of `TIMEVAL'.
958 2011-08-06 Eli Zaretskii <eliz@gnu.org>
960 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
961 display property strides EOL and includes a newline, as in
962 longlines-mode. (Bug#9254)
963 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
964 word-wrap under bidirectional display. (Bug#9224)
966 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
967 is non-zero, even if the data buffer is NULL. Fixes a crash in
968 vertical-motion with longlines-mode. (Bug#9254)
970 2011-08-05 Eli Zaretskii <eliz@gnu.org>
972 * bidi.c <bidi_cache_total_alloc>: Now static.
973 (bidi_initialize): Initialize bidi_cache_total_alloc.
975 * xdisp.c (display_line): Release buffer allocated for shelved bidi
978 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
979 amount allocated this far in `bidi_cache_total_alloc'.
980 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
981 non-zero, only free the data buffer without restoring the cache
982 contents. All callers changed.
984 * dispextern.h (bidi_unshelve_cache): Update prototype.
986 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
987 (move_it_in_display_line, move_it_to)
988 (move_it_vertically_backward, move_it_by_lines): Replace the call
989 to xfree to an equivalent call to bidi_unshelve_cache.
990 (move_it_in_display_line_to): Fix logic of returning
991 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
993 2011-08-05 Eli Zaretskii <eliz@gnu.org>
995 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
996 came from a string character with a `cursor' property. (Bug#9229)
998 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1000 * Makefile.in (LIB_PTHREAD): New variable.
1001 (LIBES): Add LIB_PTHREAD (Bug#9216).
1003 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1004 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1006 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1008 * regex.c (re_iswctype): Remove some redundant boolean
1011 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1013 * xterm.c (x_find_topmost_parent): New function.
1014 (x_set_frame_alpha): Find topmost parent window with
1015 x_find_topmost_parent and set the property there also (bug#9181).
1016 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1018 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1020 * callproc.c (Fcall_process): Avoid vfork clobbering
1021 the local vars buffer, coding_systems, current_dir.
1023 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1025 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1027 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1029 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1030 so that it is not optimized away.
1032 * xdisp.c (compute_display_string_pos): Remove unused local.
1034 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1036 Fix slow cursor motion and scrolling in large buffers with
1037 selective display, like Org Mode buffers. (Bug#9218)
1039 * dispextern.h (struct bidi_it): New member disp_prop_p.
1041 * xdisp.c: Remove one-slot cache of display string positions.
1042 (compute_display_string_pos): Accept an additional argument
1043 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1044 for a display string or property. If found, set DISP_PROP_P
1047 * bidi.c (bidi_fetch_char): Accept an additional argument
1048 DISP_PROP_P, and pass it to compute_display_string_pos.
1049 Only handle text covered by a display string if DISP_PROP_P is returned
1050 non-zero. All callers of bidi_fetch_char changed.
1052 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1054 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1056 2010-12-03 Don March <don@ohspite.net>
1058 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1059 last character M-[char] is translated to ESC [char] (bug#7541).
1061 2011-08-02 Kenichi Handa <handa@m17n.org>
1063 * lisp.h (uniprop_table): Extern it.
1065 * chartab.c (uniprop_table): Make it non-static.
1067 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1069 * xdisp.c (forward_to_next_line_start): Accept additional argument
1070 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1072 (reseat_at_next_visible_line_start): Use the bidi iterator state
1073 returned by forward_to_next_line_start to restore the state of
1074 it->bidi_it after backing up to previous newline. (Bug#9212)
1076 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1078 * regex.c (re_comp): Protoize.
1079 (re_exec): Fix return type.
1080 (regexec): Fix type of `ret'. (Bug#9203)
1082 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1084 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1085 This is needed if max-image-size is a floating-point number.
1087 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1089 * print.c (print_object): Print empty symbol as ##.
1091 * lread.c (read1): Read ## as empty symbol.
1093 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1095 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1096 setting frame foreground color (Bug#9175).
1097 (x_set_background_color): Likewise.
1099 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1100 contents (Bug#9176).
1101 (EmacsTooltip -init): Remove bezels and add shadows to
1104 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1105 or scroll bar (Bug#8470).
1107 * nsfont.m (nsfont_open): Remove assignment to voffset and
1108 unnecessary vars hshink, expand, hd, full_height, min_height.
1109 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1111 * nsterm.h (nsfont_info): Remove voffset field.
1113 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1115 Implement strike-through and overline on NextStep (Bug#8863).
1117 * nsfont.m (nsfont_open): Use underline position provided by font,
1118 instead of hard-coded value of 2.
1119 (nsfont_draw): Call ns_draw_text_decoration instead.
1121 * nsterm.h: Add declaration for ns_draw_text_decoration.
1123 * nsterm.m (ns_draw_text_decoration): New function for drawing
1124 underline, overline, and strike-through.
1125 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1126 ns_draw_text_decoration. Change treatment of cursor drawing to
1127 accomodate underlining, etc.
1129 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1131 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1134 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1136 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1137 Without this fix, if a signal arrives just after memory fills up,
1138 'malloc' might be invoked reentrantly.
1140 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1141 In other words, assume that every image size is allowed, on non-X
1142 hosts. This assumption is probably wrong, but it lets Emacs compile.
1144 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1146 * regex.c (re_iswctype): Convert return values to boolean.
1148 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1150 * xdisp.c (compute_display_string_pos): Don't use cached display
1151 string position if the buffer had its restriction changed.
1154 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1156 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1158 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1160 Integer signedness and overflow and related fixes. (Bug#9079)
1162 * bidi.c: Integer size and overflow fixes.
1163 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1164 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1165 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1166 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1167 (bidi_find_other_level_edge):
1168 Use ptrdiff_t instead of EMACS_INT where either will do.
1169 This works better on 32-bit hosts configured --with-wide-int.
1170 (bidi_cache_ensure_space): Check for size-calculation overflow.
1171 Use % rather than repeated addition, for better worst-case speed.
1172 Don't set bidi_cache_size until after xrealloc returns, because it
1174 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1175 (bidi_cache_ensure_space): Also check that the bidi cache size
1176 does not exceed that of the largest Lisp string or buffer. See Eli
1177 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1179 * alloc.c (__malloc_size_t): Remove.
1180 All uses replaced by size_t. See Andreas Schwab's note
1181 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1183 * image.c: Improve checking for integer overflow.
1184 (check_image_size): Assume that f is nonnull, since
1185 it is always nonnull in practice. This is one less thing to
1186 worry about when checking for integer overflow later.
1187 (x_check_image_size): New function, which checks for integer
1188 overflow issues inside X.
1189 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1190 This removes the need for a memory_full check.
1191 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1192 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1193 (xbm_read_bitmap_data): Change locals back to 'int', since
1194 their values must fit in 'int'.
1195 (xpm_load_image, png_load, tiff_load):
1196 Invoke x_create_x_image_and_pixmap earlier,
1197 to avoid much needless work if the image is too large.
1198 (tiff_load): Treat overly large images as if
1199 x_create_x_image_and_pixmap failed, not as malloc failures.
1200 (gs_load): Use x_check_image_size.
1202 * gtkutil.c: Omit integer casts.
1203 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1204 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1206 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1208 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1209 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1210 would wrongly return t on a 64-bit host.
1212 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1213 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1214 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1215 and therefore cause GCC to emit a bogus diagnostic in some cases.
1217 * image.c: Integer signedness and overflow and related fixes.
1218 This is not an exhaustive set of fixes, but it's time to
1219 record what I've got.
1220 (lookup_pixel_color, check_image_size): Remove redundant decls.
1221 (check_image_size): Don't assume that arbitrary EMACS_INT values
1222 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1223 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1224 (tiff_load, imagemagick_load_image):
1225 Check for overflow in size calculations.
1226 (x_create_x_image_and_pixmap): Remove unnecessary test for
1227 xmalloc returning NULL; that can't happen.
1228 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1229 (xpm_color_bucket): Use better integer hashing function.
1230 (xpm_cache_color): Don't possibly over-allocate memory.
1231 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1232 (gif_memory_source):
1233 Use ptrdiff_t, not int or size_t, to record sizes.
1234 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1235 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1236 either works, as we prefer signed integers.
1237 (tiff_read_from_memory, tiff_write_from_memory):
1238 Return tsize_t, not size_t, since that's what the TIFF API wants.
1239 (tiff_read_from_memory): Don't fail simply because the read would
1240 go past EOF; instead, return a short read.
1241 (tiff_load): Omit no-longer-needed casts.
1242 (Fimagemagick_types): Don't assume size fits into 'int'.
1244 Improve hashing quality when configured --with-wide-int.
1245 * fns.c (hash_string): New function, taken from sxhash_string.
1246 Do not discard information about ASCII character case; this
1247 discarding is no longer needed.
1248 (sxhash-string): Use it. Change sig to match it. Caller changed.
1249 * lisp.h: Declare it.
1250 * lread.c (hash_string): Remove, since we now use fns.c's version.
1251 The fns.c version returns a wider integer if --with-wide-int is
1252 specified, so this should help the quality of the hashing a bit.
1254 * emacs.c: Integer overflow minor fix.
1255 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1256 Define only if GNU_LINUX.
1257 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1259 * dispnew.c: Integer signedness and overflow fixes.
1260 Remove unnecessary forward decls, that were a maintenance hassle.
1261 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1263 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1264 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1265 (prepare_desired_row, line_draw_cost):
1266 Use int, not unsigned, where either works.
1267 (save_current_matrix, restore_current_matrix):
1268 Use ptrdiff_t, not size_t, where either works.
1269 (init_display): Check for overflow more accurately, and without
1270 relying on undefined behavior.
1272 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1273 Remove, replacing with the new symbols in lisp.h. All uses changed.
1274 * fileio.c (make_temp_name):
1275 * filelock.c (lock_file_1, lock_file):
1276 * xdisp.c (message_dolog):
1277 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1278 Use pMd etc. instead.
1279 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1280 replacing the pWIDE etc. symbols removed from editfns.c.
1282 * keyboard.h (num_input_events): Now uintmax_t.
1283 This is (very slightly) less likely to mess up due to wraparound.
1286 * buffer.c: Integer signedness fixes.
1287 (alloc_buffer_text, enlarge_buffer_text):
1288 Use ptrdiff_t rather than size_t when either will do, as we prefer
1291 * alloc.c: Integer signedness and overflow fixes.
1292 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1293 (__malloc_size_t): Default to size_t, not to int.
1294 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1295 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1296 Prefer ptrdiff_t to size_t when either would do, as we prefer
1298 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1299 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1300 Now const. Initialize with values that are in range even if char
1302 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1303 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1304 These functions do the right thing with sizes > 2**32.
1305 (check_depth): Now ptrdiff_t, not int.
1306 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1307 Adjust to new way of storing sizes. Check for size overflow bugs
1309 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1310 slightly wrong anyway, as it missed one instance of
1311 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1312 (refill_memory_reserve): Omit needless cast to size_t.
1313 (mark_object_loop_halt): Mark as externally visible.
1315 * xselect.c: Integer signedness and overflow fixes.
1316 (Fx_register_dnd_atom, x_handle_dnd_message):
1317 Use ptrdiff_t, not size_t, since we prefer signed.
1318 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1319 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1320 x_dnd_atoms_size and x_dnd_atoms_length.
1322 * doprnt.c: Prefer signed to unsigned when either works.
1324 * doprnt.c (doprnt):
1326 * xdisp.c (vmessage):
1327 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1328 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1329 prefer signed arithmetic to avoid comparison confusion.
1330 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1331 but is a bit tricky.
1333 Assume freestanding C89 headers, string.h, stdlib.h.
1334 * data.c, doprnt.c, floatfns.c, print.c:
1335 Include float.h unconditionally.
1336 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1337 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1338 * regex.c: Likewise for stddef.h, string.h.
1339 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1340 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1341 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1342 (STDC_HEADERS): Remove obsolete defines.
1343 * sysdep.c: Include limits.h unconditionally.
1345 Assume support for memcmp, memcpy, memmove, memset.
1346 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1347 * regex.c (memcmp, memcpy):
1348 Remove; we assume C89 now.
1350 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1351 (__malloc_safe_bcopy): Remove; no longer needed.
1353 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1354 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1355 well either way, and we prefer signed to unsigned.
1357 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1359 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1360 closes the connection while we're reading (bug#9182).
1362 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1364 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1365 are specified (Bug#9168).
1367 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1369 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1370 Found by GCC static checking and --with-wide-int on a 32-bit host.
1372 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1374 * xdisp.c (compute_display_string_pos): Fix logic of caching
1375 previous display string position. Initialize cached_prev_pos to
1376 -1. Fixes slow-down at the beginning of a buffer.
1378 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1380 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1381 for attrs[LFACE_FONTSET_INDEX].
1383 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1385 * xml.c (parse_region): Remove unused local
1386 that was recently introduced.
1388 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1390 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1391 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1393 * xdisp.c (move_it_in_display_line_to): Record the best matching
1394 position for TO_CHARPOS while scanning the line, and restore it on
1395 exit if none of the characters scanned was an exact match.
1396 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1397 when exact match is impossible due to invisible text, and the
1398 lines are truncated.
1400 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1402 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1405 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1407 Fix a significant slow-down of cursor motion with C-n, C-p,
1408 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1409 auto-repeat under bidi redisplay in fontified buffers.
1410 * xdisp.c (compute_stop_pos_backwards): New function.
1411 (next_element_from_buffer): Call compute_stop_pos_backwards to
1412 find a suitable prev_stop when we find ourselves before
1414 (reseat): Don't look for prev_stop, as that could mean a very long
1416 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1417 <cached_disp_overlay_modiff>: Cache for last found display string
1419 (compute_display_string_pos): Return the cached position if asked
1420 about the same buffer in the same area of character positions, and
1421 the buffer wasn't changed since the time the display string
1422 position was cached.
1424 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1426 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1427 is an integer, which is important for empty lines. (Bug#9149)
1429 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1431 * frame.c (Fmodify_frame_parameters): In tty case, update the
1432 default face if necessary (Bug#4238).
1434 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1436 * editfns.c (Fstring_to_char): No need to explain what a character
1437 is in the docstring (Bug#6576).
1439 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1441 * xml.c (parse_region): Make sure we always return a tree.
1443 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1445 * xml.c (parse_region): If a document contains only comments,
1448 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1450 * xml.c (make_dom): Return comments, too.
1452 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1455 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1456 and the surrounding thread.
1457 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1458 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1459 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1461 * s/openbsd.h (BROKEN_SIGIO): Define.
1462 * unexelf.c (unexec) [__OpenBSD__]:
1463 Don't update the .mdebug section of the Alpha COFF symbol table.
1465 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1467 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1470 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1472 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1473 This fixes some race conditions on the permissions of any newly
1476 * alloc.c (valid_pointer_p): Use pipe, not open.
1477 This fixes some permissions issues when debugging.
1479 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1480 If fchown fails to set both uid and gid, try to set just gid,
1481 as that is sometimes allowed. Adjust the file's mode to eliminate
1482 setuid or setgid bits that are inappropriate if fchown fails.
1484 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1486 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1487 to compare Lisp_Objects.
1488 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1489 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1490 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1492 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1494 * lread.c (read_integer): Unread even EOF character.
1495 (read1): Likewise. Properly record start position of symbol.
1497 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1498 symbol character follows.
1500 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1502 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1503 This works around a problem with the previous change to Fcopy_file.
1504 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1505 and without this change, GCC might complain about discarding
1506 fchown's return value.
1508 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1510 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1512 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1514 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1516 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1518 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1519 it's used from the C level.
1521 * process.c: Use the same condition for POLL_FOR_INPUT in both
1522 keyboard.c and process.c (bug#1858).
1524 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1526 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1527 (Fgnutls_boot): Use it.
1529 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1531 * doc.c (Fsubstitute_command_keys): Revert last change.
1533 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1535 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1536 quotes the next character, and doesn't affect other longer
1537 sequences (bug#8935).
1539 * lread.c (syms_of_lread): Clarify that is isn't only
1540 `eval-buffer' and `eval-defun' that's affected by
1541 `lexical-binding' (bug#8460).
1543 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1545 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1546 bidi redisplay when a line includes both an image and is
1549 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1551 Fix minor problems found by static checking.
1552 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1553 (elsz): Now a signed constant, not a size_t var. We prefer signed
1554 types to unsigned, to avoid integer comparison confusion. Without
1555 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1556 "cannot optimize loop, the loop counter may overflow", a symptom
1558 * indent.c (Fvertical_motion): Mark locals as initialized.
1559 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1561 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1563 * search.c (Fre_search_backward): Mention `case-fold-search' in
1564 all the re_search_* functions (bug#8138).
1566 * keyboard.c (Fopen_dribble_file): Document when the file is
1569 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1571 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1574 Support bidi reordering of display and overlay strings.
1575 * xdisp.c (compute_display_string_pos)
1576 (compute_display_string_end): Accept additional argument STRING.
1577 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1578 (reseat_to_string): Initialize bidi_it->string.s and
1579 bidi_it->string.schars.
1580 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1581 NULL (avoids a crash in bidi_paragraph_init).
1582 Initialize itb.string.lstring.
1583 (init_iterator): Call bidi_init_it only of a valid
1584 buffer position was specified. Initialize paragraph_embedding to
1586 (reseat_to_string): Initialize the bidi iterator.
1587 (display_string): If we need to ignore text properties of
1588 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1589 original value of -1 will not work with bidi.)
1590 (compute_display_string_pos): First arg is now struct
1591 `text_pos *'; all callers changed. Support display properties on
1593 (compute_display_string_end): Support display properties on Lisp
1595 (init_iterator, reseat_1, reseat_to_string): Initialize the
1596 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1597 when iterating on a string not from display properties).
1598 (compute_display_string_pos, compute_display_string_end):
1599 Fix calculation of the object to scan. Fixes an error when using
1601 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1602 base_level_stop; instead, set base_level_stop to BEGV.
1603 Fixes crashes in vertical-motion.
1604 (next_element_from_buffer): Improve commentary for when
1605 the iterator is before prev_stop.
1606 (init_iterator): Initialize bidi_p from the default value of
1607 bidi-display-reordering, not from buffer-local value. Use the
1608 buffer-local value only if initializing for buffer iteration.
1609 (handle_invisible_prop): Support invisible properties on strings
1610 that are being bidi-reordered.
1611 (set_iterator_to_next): Support bidi reordering of C strings and
1613 (next_element_from_string): Support bidi reordering of Lisp
1615 (handle_stop_backwards): Support Lisp strings as well.
1616 (display_string): Support display of R2L glyph rows.
1617 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1618 (init_iterator): Don't initialize it->bidi_p for strings
1620 (reseat_to_string): Initialize it->bidi_p for strings here.
1621 (next_element_from_string, next_element_from_c_string)
1622 (next_element_from_buffer): Add xassert's for correspondence
1623 between IT's object being iterated and it->bidi_it.string
1625 (face_before_or_after_it_pos): Support bidi iteration.
1626 (next_element_from_c_string): Handle the case of the first string
1627 character that is not the first one in the visual order.
1628 (get_visually_first_element): New function, refactored from common
1629 parts of next_element_from_buffer, next_element_from_string, and
1630 next_element_from_c_string.
1631 (tool_bar_lines_needed, redisplay_tool_bar)
1632 (display_menu_bar): Force left-to-right direction. Add a FIXME
1633 comment for making that be controlled by a user option.
1634 (push_it, pop_it): Save and restore the state of the
1635 bidi iterator. Save and restore the bidi_p flag.
1636 (pop_it): Iterate out of display property for string iteration as
1638 (iterate_out_of_display_property): Support iteration over strings.
1639 (handle_single_display_spec): Set up it->bidi_it for iteration
1640 over a display string, and call bidi_init_it.
1641 (handle_single_display_spec, next_overlay_string)
1642 (get_overlay_strings_1, push_display_prop): Set up the bidi
1643 iterator for displaying display or overlay strings.
1644 (forward_to_next_line_start): Don't use the shortcut if
1646 (back_to_previous_visible_line_start): If handle_display_prop
1647 pushed the iterator stack, restore the internal state of the bidi
1648 iterator by calling bidi_pop_it same number of times.
1649 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1650 and we are bidi-iterating, don't decrement the iterator position;
1651 instead, set the first_elt flag in the bidi iterator, to produce
1653 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1654 (push_display_prop): xassert that we are iterating a buffer.
1655 (push_it, pop_it): Save and restore paragraph_embedding member.
1656 (handle_single_display_spec, next_overlay_string)
1657 (get_overlay_strings_1, reseat_1, reseat_to_string)
1658 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1659 correctly. Don't assume unibyte strings are not bidi-reordered.
1660 (compute_display_string_pos)
1661 (compute_display_string_end): Fix handling the case of C string.
1662 (push_it, pop_it): Save and restore from_disp_prop_p.
1663 (handle_single_display_spec, push_display_prop): Set the
1664 from_disp_prop_p flag.
1665 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1666 (pop_it): Call iterate_out_of_display_property only if we are
1667 popping after iteration over a string that came from a display
1668 property. Fix a typo in popping stretch info. Add an assertion
1669 for verifying that the iterator position is in sync with the bidi
1671 (handle_single_display_spec, get_overlay_strings_1)
1672 (push_display_prop): Fix initialization of paragraph direction for
1673 string when that of the parent object is not yet determined.
1674 (reseat_1): Call bidi_init_it to resync the bidi
1675 iterator with IT's position. (Bug#7616)
1676 (find_row_edges): If ROW->start.pos gives position
1677 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1678 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1679 Reset the from_disp_prop_p flag.
1680 (SAVE_IT, RESTORE_IT): New macros.
1681 (pos_visible_p, face_before_or_after_it_pos)
1682 (back_to_previous_visible_line_start)
1683 (move_it_in_display_line_to, move_it_in_display_line)
1684 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1685 (try_scrolling, redisplay_window, display_line): Use them when
1686 saving a temporary copy of the iterator and restoring it back.
1687 (back_to_previous_visible_line_start, reseat_1)
1688 (init_iterator): Empty the bidi cache "stack".
1689 (move_it_in_display_line_to): If iterator ended up at
1690 EOL, but we never saw any buffer positions smaller than
1691 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1692 motion in bidi-reordered lines.
1693 (move_it_in_display_line_to): Record prev_method and prev_pos
1694 immediately before the call to set_iterator_to_next. Fixes cursor
1695 motion in bidi-reordered lines with stretch glyphs and strings
1696 displayed in margins. (Bug#8133) (Bug#8867)
1697 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1699 (pos_visible_p): Support positions in bidi-reordered lines.
1700 Save and restore bidi cache.
1702 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1703 (bidi_paragraph_info): Delete unused struct.
1704 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1705 (bidi_cache_start): New variable.
1706 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1708 (bidi_cache_fetch_state, bidi_cache_search)
1709 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1710 (bidi_cache_find, bidi_peek_at_next_level)
1711 (bidi_level_of_next_char, bidi_find_other_level_edge)
1712 (bidi_move_to_visually_next): Compare cache index with
1713 bidi_cache_start rather than with zero.
1714 (bidi_fetch_char): Accept new argument STRING; all callers
1715 changed. Support iteration over a string. Support strings with
1716 display properties. Support unibyte strings. Fix the type of
1717 `len' according to what STRING_CHAR_AND_LENGTH expects.
1718 (bidi_paragraph_init, bidi_resolve_explicit_1)
1719 (bidi_resolve_explicit, bidi_resolve_weak)
1720 (bidi_level_of_next_char, bidi_move_to_visually_next):
1721 Support iteration over a string.
1722 (bidi_set_sor_type, bidi_resolve_explicit_1)
1723 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1724 can now be zero (for strings); special values 0 and -1 were
1725 changed to -1 and -2, respectively.
1726 (bidi_char_at_pos): New function.
1727 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1728 Call it instead of FETCH_MULTIBYTE_CHAR.
1729 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1730 initialized to valid values.
1731 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1733 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1734 the test for valid cached positions. Fix the logic for looking up
1735 the sentinel state in the cache. GCPRO the Lisp string we are
1737 (bidi_push_it, bidi_pop_it): New functions.
1738 (bidi_initialize): Initialize the bidi cache start stack pointer.
1739 (bidi_cache_ensure_space): New function, refactored from part of
1740 bidi_cache_iterator_state. Don't assume the required size is just
1741 one BIDI_CACHE_CHUNK away.
1742 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1743 (bidi_count_bytes, bidi_char_at_pos): New functions.
1744 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1745 always valid if bidi_cache_idx is valid.
1746 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1747 is valid if it's going to be used.
1748 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1749 (bidi_cache_fetch_state, bidi_cache_search)
1750 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1751 (bidi_cache_iterator_state, bidi_cache_find)
1752 (bidi_find_other_level_edge, bidi_cache_start_stack):
1753 All variables related to cache indices are now EMACS_INT.
1755 * dispextern.h (struct bidi_string_data): New structure.
1756 (struct bidi_it): New member `string'. Make flag members be 1-bit
1757 fields, and put them last in the struct.
1758 (compute_display_string_pos, compute_display_string_end):
1760 (bidi_push_it, bidi_pop_it): Add prototypes.
1761 (struct iterator_stack_entry): New members bidi_p,
1762 paragraph_embedding, and from_disp_prop_p.
1763 (struct it): Member bidi_p is now a bit field 1 bit wide.
1764 (bidi_shelve_cache, bidi_unshelve_cache):
1767 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1768 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1769 and vector-like objects.
1771 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1772 cache around display iteration.
1774 * window.c (Fwindow_end, window_scroll_pixel_based)
1775 (displayed_window_lines, Frecenter): Save and restore the bidi
1776 cache around display iteration.
1778 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1780 * editfns.c (Fdelete_region): Clarify the use of the named
1781 parameters (bug#6788).
1783 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1785 * indent.c (Fvertical_motion): Set and restore w->pointm when
1786 saving and restoring the window's buffer (Bug#9006).
1788 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1790 * editfns.c (Fstring_to_char): Clarify just what is returned
1791 (bug#6576). Text by Eli Zaretskii.
1793 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1795 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1797 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1799 * buffer.c (mmap_find): Fix a typo.
1801 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1803 Fix execution of x selection hooks.
1804 * xselect.c (Qx_lost_selection_functions)
1805 (Qx_sent_selection_functions): New vars.
1806 (syms_of_xselect): DEFSYM them.
1807 (x_handle_selection_request): Pass Qx_sent_selection_functions
1808 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1809 (x_handle_selection_clear,x_clear_frame_selections):
1810 Pass Qx_lost_selection_functions rather than
1811 Vx_lost_selection_functions to Frun_hook_with_args.
1813 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1815 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1816 The old code sometimes used this field without initializing it.
1818 * alloc.c (gc_sweep): Don't read past end of array.
1819 In theory, the old code could also have corrupted Emacs internals,
1820 though it'd be very unlikely.
1822 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1824 * character.c (Fcharacterp): Don't advertise optional ignored
1825 argument. (Bug#4026)
1827 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1832 * window.c (Fset_window_start): Doc fix (bug#4199).
1833 (Fset_window_hscroll): Ditto.
1835 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1837 Fix minor new problems caught by GCC 4.6.1.
1838 * term.c (init_tty): Remove unused local.
1839 * xsettings.c (store_monospaced_changed): Define this function only
1840 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1843 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1845 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1847 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1849 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1850 are the mini-buffer and the echo area (bug#3320).
1852 * term.c (init_tty): Remove support for supdup, c10 and perq
1853 terminals, which are no longer supported (bug#1482).
1855 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1857 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1859 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1861 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1862 for non-popups (Bug#3642).
1864 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1866 * alloc.c (reset_malloc_hooks): Protoize.
1867 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1868 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1869 * cm.c (losecursor): Likewise.
1870 * data.c (fmod): Likewise.
1871 * dispnew.c (swap_glyphs_in_rows): Likewise.
1872 * emacs.c (memory_warning_signal): Likewise.
1873 * floatfns.c (float_error): Likewise.
1874 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1875 (otf_open, font_otf_capability, generate_otf_features)
1876 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1878 * image.c (pbm_read_file): Likewise.
1879 * indent.c (string_display_width): Likewise.
1880 * intervals.c (check_for_interval, search_for_interval)
1881 (inc_interval_count, count_intervals, root_interval)
1882 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1883 * lread.c (defalias): Likewise.
1884 * ralloc.c (r_alloc_check): Likewise.
1885 * regex.c (set_image_of_range_1, set_image_of_range)
1886 (regex_grow_registers): Likewise.
1887 * sysdep.c (strerror): Likewise.
1888 * termcap.c (valid_filename_p, tprint, main): Likewise.
1889 * tparam.c (main): Likewise.
1890 * unexhp9k800.c (run_time_remap, save_data_space)
1891 (update_file_ptrs, read_header, write_header, calculate_checksum)
1892 (copy_file, copy_rest, display_header): Likewise.
1893 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1895 * xdisp.c (check_it): Likewise.
1896 * xfaces.c (register_color, unregister_color, unregister_colors):
1898 * xfns.c (print_fontset_result): Likewise.
1899 * xrdb.c (member, fatal, main): Likewise.
1901 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1903 Fix minor problems found by static checking (Bug#9031).
1904 * chartab.c (char_table_set_range, map_sub_char_table):
1905 Remove unused locals.
1906 (uniprop_table): Now static.
1907 * composite.c (_work_char): Remove unused static var.
1909 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1911 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1913 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1915 * gtkutil.c (qttip_cb): Remove code without function.
1917 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1919 * w32.c (pthread_sigmask): New stub.
1921 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1923 Use pthread_sigmask, not sigprocmask (Bug#9010).
1924 sigprocmask is portable only for single-threaded applications, and
1925 Emacs can be multi-threaded when it uses GTK.
1926 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1928 * callproc.c (Fcall_process):
1929 * process.c (create_process):
1930 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1931 Use pthread_sigmask, not sigprocmask.
1933 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1935 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1936 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1939 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1941 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1942 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1943 (xg_hide_tooltip): Fix comment.
1945 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1946 in registerServicesMenuSendTypes.
1947 (validRequestorForSendType): Don't check ns_return_types.
1949 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1952 2011-07-08 Jason Rumney <jasonr@gnu.org>
1954 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1955 frame struct members of non-existent frames (Bug#6284).
1957 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1959 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1960 variable firstTime not needed on OSX >= 10.6.
1961 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1962 >= 10.5. Use setKnobProportion, setDoubleValue.
1964 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1965 (MAC_OS_X_VERSION_10_5): Define if not defined.
1966 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1967 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1968 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1970 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1971 cString and lossyCString on OSX >= 10.4
1973 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1974 sizeToFit on OSX >= 10.2.
1976 * nsimage.m (allocInitFromFile): Don't use deprecated method
1977 bestRepresentationForDevice on OSX >= 10.6.
1979 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1982 * emacs.c: Declare unexec_init_emacs_zone.
1984 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1986 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1988 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1989 on svcsMenu (Bug#8842).
1991 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1993 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1995 * nsterm.m (QUTF8_STRING): Declare.
1996 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1997 (validRequestorForSendType): Return type is (id).
1998 Change indexOfObjectIdenticalTo to indexOfObject.
1999 Check if we have local selection before returning self (Bug#8842).
2000 (writeSelectionToPasteboard): Put local selection into paste board
2001 if we have a local selection (Bug#8842).
2002 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2004 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2005 (ns_get_local_selection): Declare.
2007 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2009 * keymap.c (describe_map_tree): Don't insert a double newline at
2010 the end of the buffer (bug#1169) and return whether we inserted
2013 * callint.c (Fcall_interactively): Change "reading args" to
2014 "providing args" to try to clarify what it does (bug#1010).
2016 2011-07-07 Kenichi Handa <handa@m17n.org>
2018 * composite.c (composition_compute_stop_pos): Ignore a static
2019 composition starting before CHARPOS (Bug#8915).
2021 * xdisp.c (handle_composition_prop): Likewise.
2023 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2025 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2028 2011-07-07 Kenichi Handa <handa@m17n.org>
2030 * character.h (unicode_category_t): New enum type.
2032 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2033 (Qchar_code_property_table): New variable.
2034 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2035 (UNIPROP_COMPRESSED_FORM_P): New macros.
2036 (char_table_ascii): Uncompress the compressed values.
2037 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2038 Uncompress the compressed values.
2039 (sub_char_table_ref_and_range): Likewise.
2040 (char_table_ref_and_range): Uncompress the compressed values.
2041 (sub_char_table_set): New arg is_uniprop. Callers changed.
2042 Uncompress the compressed values.
2043 (sub_char_table_set_range): Args changed. Callers changed.
2044 (char_table_set_range): Adjuted for the above change.
2045 (map_sub_char_table): Delete args default_val and parent. Add arg
2046 top. Give decoded values to a Lisp function.
2047 (map_char_table): Adjust for the above change. Give decoded
2048 values to a Lisp function. Gcpro more variables.
2049 (uniprop_table_uncompress)
2050 (uniprop_decode_value_run_length): New functions.
2051 (uniprop_decoder, uniprop_decoder_count): New variables.
2052 (uniprop_get_decoder, uniprop_encode_value_character)
2053 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2055 (uniprop_encoder, uniprop_encoder_count): New variables.
2056 (uniprop_get_encoder, uniprop_table)
2057 (Funicode_property_table_internal, Fget_unicode_property_internal)
2058 (Fput_unicode_property_internal): New functions.
2059 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2060 Sunicode_property_table_internal, Sget_unicode_property_internal,
2061 and Sput_unicode_property_internal. Defvar_lisp
2062 char-code-property-alist.
2064 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2065 Vunicode_category_table.
2067 * font.c (font_range): Adjust for the change of
2068 Vunicode_category_table.
2070 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2072 * m/iris4d.h: Remove file, move contents ...
2073 * s/irix6-5.h: ... here.
2075 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2077 Remove unportable assumption about struct layout (Bug#8884).
2078 * alloc.c (mark_buffer):
2079 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2080 (clone_per_buffer_values): Don't assume that
2081 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2082 This isn't true in general, and it's particularly not true
2083 if Emacs is configured with --with-wide-int.
2084 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2085 New macros, used in the buffer.c change.
2087 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2089 * xsettings.c: Use both GConf and GSettings if both are available.
2090 (store_config_changed_event): Add comment.
2091 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2092 (store_tool_bar_style_changed): New functions.
2093 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2094 (struct xsettings): Move font inside HAVE_XFT.
2095 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2096 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2097 Move inside HAVE_XFT.
2098 (something_changed_gsettingsCB): Rename from something_changedCB.
2099 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2101 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2102 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2103 (something_changed_gconfCB): Rename from something_changedCB.
2104 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2105 (parse_settings): Move check for font inside HAVE_XFT.
2106 (read_settings, apply_xft_settings): Add comment.
2107 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2108 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2109 call store_font_name_changed.
2110 (xft_settings_event): Add comment.
2111 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2112 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2113 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2114 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2115 (xsettings_initialize): Call init_gsettings last.
2116 (xsettings_get_system_font, xsettings_get_system_normal_font):
2119 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2121 Random fixes. E.g., (random) never returned negative values.
2122 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2123 subseconds part to the entropy, as that's a bit more random.
2124 Prefer signed to unsigned, since the signedness doesn't matter and
2125 in general we prefer signed. When given a limit, use a
2126 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2127 latter isn't right if USE_2_TAGS_FOR_INTS.
2128 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2129 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2131 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2133 * textprop.c (text_property_stickiness):
2134 Obey Vtext_property_default_nonsticky.
2135 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2136 * w32fns.c (syms_of_w32fns):
2137 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2139 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2141 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2142 This is more efficient than Ffile_directory_p and avoids a minor race.
2144 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2146 * buffer.c (Foverlay_put): Say what the return value is
2149 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2150 is a directory before asking whether to use the file name
2152 (barf_or_query_if_file_exists): Make the "File is a directory"
2153 error be more correct.
2155 * fns.c (Frequire): Remove the mention of the .gz files, since
2156 that's installation-specific, but keep the mention of
2157 `get-load-suffixes'.
2159 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2161 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2162 Report string overflow if the output is too long.
2164 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2166 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2167 (syms_of_gnutls): Remove duplicate DEFSYM for
2168 Qgnutls_bootprop_verify_hostname_error, an error for
2169 Qgnutls_bootprop_verify_error (which is no longer used).
2171 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2172 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2173 Also (re)move comments that are misplaced or no longer relevant.
2175 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2177 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2179 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2181 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2182 and background color parameters if they have been changed.
2184 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2186 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2188 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2190 * xsettings.c (SYSTEM_FONT): Define only when used.
2191 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2193 * keymap.c (access_keymap_1): Now static.
2195 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2197 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2198 leave any prefix arg for the up event (Bug#1586).
2200 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2202 * lread.c (syms_of_lread): Mention single symbols defined by
2203 `defvar' or `defconst' (bug#7154).
2205 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2206 (Frequire): Mention get-load-suffixes.
2208 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2210 * window.h (window): Remove clone_number slot.
2211 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2213 (make_parent_window, make_window, saved_window)
2214 (Fset_window_configuration, save_window_save): Don't deal with
2216 * buffer.c (Qclone_number): Remove declaration.
2217 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2219 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2221 Add multiple inheritance to keymaps.
2222 * keymap.c (Fmake_composed_keymap): New function.
2223 (Fset_keymap_parent): Simplify.
2224 (fix_submap_inheritance): Remove.
2225 (access_keymap_1): New function extracted from access_keymap to handle
2226 embedded parents and handle lists of maps.
2227 (access_keymap): Use it.
2228 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2229 (Fcopy_keymap): Handle embedded parents.
2230 (Fcommand_remapping, define_as_prefix): Simplify.
2231 (Fkey_binding): Simplify.
2232 (syms_of_keymap): Move minibuffer-local-completion-map,
2233 minibuffer-local-filename-completion-map,
2234 minibuffer-local-must-match-map, and
2235 minibuffer-local-filename-must-match-map to Elisp.
2236 (syms_of_keymap): Defsubr make-composed-keymap.
2237 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2238 (parse_menu_item): Trivial simplification.
2240 2011-07-01 Glenn Morris <rgm@gnu.org>
2242 * Makefile.in (SETTINGS_LIBS): Fix typo.
2244 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2246 * coding.c (Fencode_coding_string): Record the last coding system
2247 used, as the function doc string says (bug#8738).
2249 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2251 * xsettings.c (store_monospaced_changed): Take new font as arg and
2252 check for change against current_mono_font.
2253 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2254 (emacs_settings_constructor, emacs_settings_get_property)
2255 (emacs_settings_set_property, emacs_settings_class_init)
2256 (emacs_settings_init, gsettings_obj): Remove.
2257 (something_changedCB): New function for HAVE_GSETTINGS.
2258 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2259 with value as argument.
2260 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2261 g_settings_new (Bug#8967). Do not create gsettings_obj.
2262 Remove calls to g_settings_bind. Connect something_changedCB to
2265 * xgselect.c: Add defined (HAVE_GSETTINGS).
2266 (xgselect_initialize): Ditto.
2268 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2269 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2272 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2274 * eval.c (struct backtrace): Simplify and port the data structure.
2275 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2276 signed bit field, as this assumption is not portable and it makes
2277 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2278 "char debug_on_exit : 1" as this is not portable either; instead,
2279 use the portable "unsigned int debug_on_exit : 1". Remove unused
2280 member evalargs. Remove obsolete comments about cc bombing out.
2282 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2284 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2285 Let HAVE_GSETTINGS override HAVE_GCONF.
2286 (store_monospaced_changed): New function.
2287 (EMACS_SETTINGS): A new type derived from GObject to handle
2288 GSettings notifications.
2289 (emacs_settings_constructor, emacs_settings_get_property)
2290 (emacs_settings_set_property, emacs_settings_class_init):
2292 (gsettings_client, gsettings_obj): New variables.
2293 (GSETTINGS_SCHEMA): New define.
2294 (something_changedCB): Call store_monospaced_changed.
2295 (init_gsettings): New function.
2296 (xsettings_initialize): Call init_gsettings.
2297 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2300 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2303 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2305 * window.c (resize_root_window, grow_mini_window)
2306 (shrink_mini_window): Rename Qresize_root_window to
2307 Qwindow_resize_root_window and Qresize_root_window_vertically to
2308 Qwindow_resize_root_window_vertically.
2310 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2312 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2314 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2316 * makefile.w32-in: Redesign dependencies so they reflect more
2317 clearly which files are directly included by each source file,
2318 and not through other includes.
2320 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2322 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2323 (sort_overlays, overlay_strings): When an overlay's clone number
2324 matches the window's clone number process the overlay even if
2325 the overlay's window property doesn't match the current window.
2327 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2328 (Fwindow_hchild): Rename to Fwindow_left_child.
2329 (Fwindow_next): Rename to Fwindow_next_sibling.
2330 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2331 (resize_window_check): Rename to window_resize_check.
2332 (resize_window_apply): Rename to window_resize_apply.
2333 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2334 (Fdelete_other_windows_internal, resize_frame_windows)
2335 (Fsplit_window_internal, Fdelete_window_internal)
2336 (grow_mini_window, shrink_mini_window)
2337 (Fresize_mini_window_internal): Fix callers accordingly.
2339 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2341 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2342 (emacs_fixed_set_min_size): Remove.
2343 (emacs_fixed_new): Take frame as argument.
2345 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2346 (_EmacsFixedPrivate): Remove minwidth/height.
2347 Add struct frame *f.
2348 (emacs_fixed_init): Initialize priv->f.
2349 (get_parent_class, emacs_fixed_set_min_size): Remove.
2350 (emacs_fixed_new): Set priv->f to argument.
2351 (emacs_fixed_get_preferred_width)
2352 (emacs_fixed_get_preferred_height): Use min_width/height from
2353 frames size_hint to set minimum and natural (Bug#8919).
2354 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2355 and use min_width/height from frames size_hint to set
2356 min_width/height (Bug#8919).
2358 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2359 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2362 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2364 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2365 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2368 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2370 * process.c (wait_reading_process_output): Bypass select if
2371 waiting for a cell while ignoring keyboard input, and input is
2372 pending. Suggested by Jan Djärv (Bug#8869).
2374 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2376 Use gnulib's dup2 module instead of rolling our own.
2377 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2379 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2381 * dispnew.c (scrolling_window): Before scrolling, turn off a
2382 mouse-highlight in the window being scrolled.
2384 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2386 Move DEFSYM to lisp.h and use everywhere.
2388 * character.h (DEFSYM): Move declaration...
2389 * lisp.h (DEFSYM): ...here.
2395 * w32select.c: Don't include character.h.
2397 * alloc.c (syms_of_alloc):
2398 * buffer.c (syms_of_buffer):
2399 * bytecode.c (syms_of_bytecode):
2400 * callint.c (syms_of_callint):
2401 * casefiddle.c (syms_of_casefiddle):
2402 * casetab.c (init_casetab_once):
2403 * category.c (init_category_once, syms_of_category):
2404 * ccl.c (syms_of_ccl):
2405 * cmds.c (syms_of_cmds):
2406 * composite.c (syms_of_composite):
2407 * dbusbind.c (syms_of_dbusbind):
2408 * dired.c (syms_of_dired):
2409 * dispnew.c (syms_of_display):
2410 * doc.c (syms_of_doc):
2411 * editfns.c (syms_of_editfns):
2412 * emacs.c (syms_of_emacs):
2413 * eval.c (syms_of_eval):
2414 * fileio.c (syms_of_fileio):
2415 * fns.c (syms_of_fns):
2416 * frame.c (syms_of_frame):
2417 * fringe.c (syms_of_fringe):
2418 * insdel.c (syms_of_insdel):
2419 * keymap.c (syms_of_keymap):
2420 * lread.c (init_obarray, syms_of_lread):
2421 * macros.c (syms_of_macros):
2422 * msdos.c (syms_of_msdos):
2423 * print.c (syms_of_print):
2424 * process.c (syms_of_process):
2425 * search.c (syms_of_search):
2426 * sound.c (syms_of_sound):
2427 * syntax.c (init_syntax_once, syms_of_syntax):
2428 * terminal.c (syms_of_terminal):
2429 * textprop.c (syms_of_textprop):
2430 * undo.c (syms_of_undo):
2431 * w32.c (globals_of_w32):
2432 * window.c (syms_of_window):
2433 * xdisp.c (syms_of_xdisp):
2434 * xfaces.c (syms_of_xfaces):
2435 * xfns.c (syms_of_xfns):
2436 * xmenu.c (syms_of_xmenu):
2437 * xsettings.c (syms_of_xsettings):
2438 * xterm.c (syms_of_xterm): Use DEFSYM.
2440 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2442 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2444 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2446 Integer and buffer overflow fixes (Bug#8873).
2448 * print.c (printchar, strout): Check for string overflow.
2449 (PRINTPREPARE, printchar, strout):
2450 Don't set size unless allocation succeeds.
2452 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2453 for sizes. Check for string overflow more accurately.
2454 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2456 * macros.c: Integer and buffer overflow fixes.
2457 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2458 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2459 Use ptrdiff_t, not int, for sizes.
2460 Don't increment bufsize until after realloc succeeds.
2461 Check for size-calculation overflow.
2462 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2464 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2466 * lread.c: Integer overflow fixes.
2467 (read_integer): Radix is now EMACS_INT, not int,
2468 to improve quality of diagnostics for out-of-range radices.
2469 Calculate buffer size correctly for out-of-range radices.
2470 (read1): Check for integer overflow in radices, and in
2471 read-circle numbers.
2472 (read_escape): Avoid int overflow.
2473 (Fload, openp, read_buffer_size, read1)
2474 (substitute_object_recurse, read_vector, read_list, map_obarray):
2475 Use ptrdiff_t, not int, for sizes.
2476 (read1): Use EMACS_INT, not int, for sizes.
2477 Check for size overflow.
2479 * image.c (cache_image): Check for size arithmetic overflow.
2481 * lread.c: Integer overflow issues.
2482 (saved_doc_string_size, saved_doc_string_length)
2483 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2484 Now ptrdiff_t, not int.
2485 (read1): Don't assume doc string length fits in int. Check for
2486 out-of-range doc string lengths.
2487 (read_list): Don't assume file position fits in int.
2488 (read_escape): Check for hex character overflow.
2490 2011-06-22 Leo Liu <sdl.web@gmail.com>
2492 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2493 Move to minibuffer.el.
2495 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2497 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2498 The following patches are for when GLYPH_DEBUG && !XASSERT.
2499 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2500 * dispnew.c (flush_stdout):
2501 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2502 Mark as externally visible.
2503 * dispnew.c (check_window_matrix_pointers): Now static.
2504 * dispnew.c (window_to_frame_vpos):
2505 * xfns.c (unwind_create_frame):
2506 * xterm.c (x_check_font): Remove unused local.
2507 * scroll.c (CHECK_BOUNDS):
2508 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2509 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2510 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2511 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2512 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2514 (debug_method_add): Use va_list and vsprintf rather than relying
2515 on undefined behavior with wrong number of arguments.
2516 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2517 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2518 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2519 since we're not interested in debugging glyphs with old libraries.
2520 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2521 GCC 4.6.0's static checking.
2523 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2525 Integer overflow and signedness fixes (Bug#8873).
2526 A few related buffer overrun fixes, too.
2528 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2530 * dispextern.h (struct face.stipple):
2531 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2532 (x_bitmap_mask, x_allocate_bitmap_record)
2533 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2534 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2535 (x_create_bitmap_from_xpm_data):
2536 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2537 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2539 * xfaces.c (load_pixmap):
2540 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2541 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2542 (.bitmaps_last, struct x_output.icon_bitmap):
2543 Use ptrdiff_t, not int, for bitmap indexes.
2544 (x_allocate_bitmap_record): Check for size overflow.
2545 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2547 Use ptrdiff_t, not int, for overlay counts.
2548 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2549 * editfns.c (overlays_around, get_pos_property):
2550 * textprop.c (get_char_property_and_overlay):
2551 * xdisp.c (next_overlay_change, note_mouse_highlight):
2552 * xfaces.c (face_at_buffer_position):
2553 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2554 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2555 (Fnext_overlay_change, Fprevious_overlay_change)
2556 (mouse_face_overlay_overlaps, Foverlays_in):
2557 Use ptrdiff_t, not int, for sizes.
2558 (overlays_at, overlays_in): Check for size-calculation overflow.
2560 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2562 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2563 (x_session_initialize): Do not assume string length fits in int.
2565 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2566 This is unlikely, but can occur if DPI is outlandish.
2568 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2569 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2571 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2572 * xrdb.c (magic_file_p, search_magic_path):
2573 Omit last arg SUFFIX; it was always 0. All callers changed.
2574 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2576 * xfont.c (xfont_match): Avoid need for strlen.
2578 * xfns.c: Don't assume strlen fits in int.
2579 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2581 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2582 not unsigned long, as we prefer signed integers. All callers changed.
2583 Detect integer overflow in repeat count.
2584 (message_dolog): Don't assume print length fits in 39 bytes.
2585 (display_mode_element): Don't assume strlen fits in int.
2587 * termcap.c: Don't assume sizes fit in int and never overflow.
2588 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2589 (gobble_line): Check for size-calculation overflow.
2591 * minibuf.c (Fread_buffer):
2592 * lread.c (intern, intern_c_string):
2593 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2594 Don't assume string length fits in int.
2596 * keyboard.c (parse_tool_bar_item):
2597 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2599 * font.c: Don't assume string length fits in int.
2600 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2601 Use ptrdiff_t, not int.
2602 (font_intern_prop): Don't assume string length fits in int.
2603 Don't assume integer property fits in fixnum.
2604 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2606 * filelock.c: Fix some buffer overrun and integer overflow issues.
2607 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2608 Reformulate so as not to need the command string.
2609 Invoke gzip -cd rather than gunzip, as it's more portable.
2610 (lock_info_type, lock_file_1, lock_file):
2611 Don't assume pid_t and time_t fit in unsigned long.
2612 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2613 (current_lock_owner): Prefer signed type for sizes.
2614 Use memcpy, not strncpy, where memcpy is what is really wanted.
2615 Don't assume (via atoi) that time_t and pid_t fit in int.
2616 Check for time_t and/or pid_t out of range, e.g., via a network share.
2617 Don't alloca where an auto var works fine.
2619 * fileio.c: Fix some integer overflow issues.
2620 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2621 Don't assume string length fits in int.
2622 (directory_file_name): Don't assume string length fits in long.
2623 (make_temp_name): Don't assume pid fits in int, or that its print
2624 length is less than 20.
2626 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2628 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2630 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2632 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2633 We prefer signed integers, even for size calculations.
2635 * emacs.c: Don't assume string length fits in 'int'.
2636 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2637 (main): Don't invoke strlen when not needed.
2639 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2640 (XD_DEBUG_MESSAGE): Don't waste a byte.
2642 * callproc.c (getenv_internal_1, getenv_internal)
2644 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2646 * lread.c (invalid_syntax): Omit length argument.
2647 All uses changed. This doesn't fix a bug, but it simplifies the
2648 code away from its former Hollerith-constant appearance, and it's
2649 one less 'int' to worry about when looking at integer-overflow issues.
2650 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2652 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2653 This didn't break anything, but it didn't help either.
2654 It's confusing to put a bogus integer in a place where the actual
2655 value does not matter.
2656 (LIST_END_P): Remove unused macro and its bogus comment.
2657 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2659 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2660 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2662 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2663 We prefer signed types, and the value cannot exceed the EMACS_INT
2664 range anyway (because otherwise the length would not be representable).
2665 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2666 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2667 This avoids a GCC warning when WIDE_EMACS_INT.
2669 * indent.c (sane_tab_width): New function.
2670 (current_column, scan_for_column, Findent_to, position_indentation)
2671 (compute_motion): Use it. This is just for clarity.
2672 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2674 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2676 * lisp.h (lint_assume): New macro.
2677 * composite.c (composition_gstring_put_cache):
2678 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2680 * editfns.c, insdel.c:
2681 Omit unnecessary forward decls, to simplify future changes.
2683 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2685 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2687 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2688 Use much-faster test for byte-length change.
2689 Don't assume string byte-length fits in 'int'.
2690 Check that character arg fits in 'int'.
2691 (mapcar1): Declare byte as byte, for clarity.
2693 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2695 * fns.c (concat): Catch string overflow earlier.
2696 Do not rely on integer wraparound.
2698 * dispextern.h (struct it.overlay_strings_charpos)
2699 (struct it.selective): Now EMACS_INT, not int.
2700 * xdisp.c (forward_to_next_line_start)
2701 (back_to_previous_visible_line_start)
2702 (reseat_at_next_visible_line_start, next_element_from_buffer):
2703 Don't arbitrarily truncate the value of 'selective' to int.
2705 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2707 * composite.c: Don't truncate sizes to 'int'.
2708 (composition_gstring_p, composition_reseat_it)
2709 (composition_adjust_point): Use EMACS_INT, not int.
2710 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2711 not EMACS_UINT, for indexes.
2713 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2715 * buffer.c: Include <verify.h>.
2716 (struct sortvec.priority, struct sortstr.priority):
2717 Now EMACS_INT, not int.
2718 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2719 (struct sortstr.size, record_overlay_string)
2720 (struct sortstrlist.size, struct sortlist.used):
2721 Don't truncate size to int.
2722 (record_overlay_string): Check for size-calculation overflow.
2723 (init_buffer_once): Check at compile-time, not run-time.
2725 2011-06-22 Jim Meyering <meyering@redhat.com>
2727 Don't leak an XBM-image-sized buffer
2728 * image.c (xbm_load): Free the image buffer after using it.
2730 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2733 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2734 that Sun C diagnosed.
2735 * fns.c (secure_hash): Fix pointer signedness issue.
2736 * intervals.c (static_offset_intervals): New function.
2737 (offset_intervals): Use it.
2739 2011-06-21 Leo Liu <sdl.web@gmail.com>
2742 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2745 * fns.c (secure_hash): Rename from crypto_hash_function and change
2746 the first arg to accept symbols.
2747 (Fsecure_hash): New primitive.
2748 (syms_of_fns): New symbols.
2750 2011-06-20 Deniz Dogan <deniz@dogan.se>
2752 * process.c (Fset_process_buffer): Clarify return value in
2755 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2757 * dispnew.c (add_window_display_history): Use BVAR.
2759 * xdisp.c (debug_method_add): Use BVAR.
2760 (check_window_end, dump_glyph_matrix, dump_glyph)
2761 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2763 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2766 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2767 check till after the cache is created in init_frame_faces.
2769 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2771 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2773 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2775 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2776 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2777 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2779 Improve buffer-overflow checking (Bug#8873).
2780 * fileio.c (Finsert_file_contents):
2781 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2782 Remove the old (too-loose) buffer overflow checks.
2783 They weren't needed, since make_gap checks for buffer overflow.
2784 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2785 The old code merely checked for Emacs fixnum overflow, and relied
2786 on undefined (wraparound) behavior. The new code avoids undefined
2787 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2789 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2790 Tune. Don't use wider integers than needed. Don't use alloca.
2791 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2793 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2795 * insdel.c, lisp.h (buffer_overflow): New function.
2796 (insert_from_buffer_1, replace_range, replace_range_2):
2797 * insdel.c (make_gap_larger):
2798 * editfns.c (Finsert_char):
2799 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2801 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2803 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2805 Integer overflow and signedness fixes (Bug#8873).
2807 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2808 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2810 * fileio.c: Don't assume EMACS_INT fits in off_t.
2811 (emacs_lseek): New static function.
2812 (Finsert_file_contents, Fwrite_region): Use it.
2813 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2815 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2817 * fns.c: Don't overflow int when computing a list length.
2818 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2819 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2820 truncation on 64-bit hosts. Check for QUIT every
2821 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2822 faster and is responsive enough.
2823 (Flength): Report an error instead of overflowing an integer.
2824 (Fsafe_length): Return a float if the value is not representable
2825 as a fixnum. This shouldn't happen except in contrived situations.
2826 (Fnthcdr, Fsort): Don't assume list length fits in int.
2827 (Fcopy_sequence): Don't assume vector length fits in int.
2829 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2830 (header_size, word_size): New constants.
2831 (allocate_vectorlike): Don't check size overflow here.
2832 (allocate_vector): Check it here instead, since this is the only
2833 caller of allocate_vectorlike that could cause overflow.
2834 Check that the new vector's length is representable as a fixnum.
2836 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2837 The previous code was bogus. For example, next_almost_prime (32)
2838 returned 39, which is undesirable as it is a multiple of 3; and
2839 next_almost_prime (24) returned 25, which is a multiple of 5 so
2840 why was the code bothering to check for multiples of 7?
2842 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2844 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2846 Variadic C functions now count arguments with ptrdiff_t.
2847 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2848 Back then I didn't know that the Emacs coding style prefers signed int.
2849 Also, in the meantime I found a few more instances where arguments
2850 were being counted with int, which may truncate counts on 64-bit
2851 machines, or EMACS_INT, which may be unnecessarily wide.
2852 * lisp.h (struct Lisp_Subr.function.aMANY)
2853 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2854 Arg counts are now ptrdiff_t, not size_t.
2855 All variadic functions and their callers changed accordingly.
2856 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2857 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2858 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2859 * callint.c (Fcall_interactively): Check arg count for overflow,
2860 to avoid potential buffer overrun. Use signed char, not 'int',
2861 for 'varies' array, so that we needn't bother to check its size
2862 calculation for overflow.
2863 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2864 * eval.c (apply_lambda):
2865 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2866 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2867 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2869 * callint.c (Fcall_interactively): Don't use index var as event count.
2871 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2872 * mem-limits.h (SIZE): Remove; no longer used.
2874 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2876 Remove unnecessary casts.
2877 * xterm.c (x_term_init):
2878 * xfns.c (x_set_border_pixel):
2879 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2880 These aren't needed now that we assume ANSI C.
2882 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2883 It's more likely to cause problems (due to unsigned overflow)
2886 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2888 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2890 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2892 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2894 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2896 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2898 GLYPH_CODE_FACE returns EMACS_INT, not int.
2899 * dispextern.h (merge_faces):
2900 * xfaces.c (merge_faces):
2901 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2902 Don't assume EMACS_INT fits in int.
2904 * character.h (CHAR_VALID_P): Remove unused parameter.
2905 * fontset.c, lisp.h, xdisp.c: All uses changed.
2907 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2909 * fns.c (concat): Minor tuning based on overflow analysis.
2910 This doesn't fix any bugs. Use int to hold character, instead
2911 of constantly refetching from Emacs object. Use XFASTINT, not
2912 XINT, for value known to be a character. Don't bother comparing
2913 a single byte to 0400, as it's always less.
2915 * floatfns.c (Fexpt):
2916 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2918 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2921 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2923 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2924 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2925 incorrectly succeed when S was a string, because 4294967386 was
2926 truncated before it was used.
2928 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2929 Otherwise, an out-of-range integer could cause undefined behavior
2932 * composite.c: Use int, not EMACS_INT, for characters.
2933 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2934 EMACS_INT, for values that are known to be in character range.
2935 This doesn't fix any bugs but is the usual style inside Emacs and
2936 may generate better code on 32-bit machines.
2938 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2939 This is for reasons similar to the recent CHAR_STRING fix.
2940 * charset.c (Fencode_char): Check that character arg is actually
2941 a character. Pass an int to ENCODE_CHAR.
2942 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2943 wider than 'int', as a compile-time check to prevent future regressions
2946 * character.c (char_string): Remove unnecessary casts.
2948 Make sure a 64-bit char is never passed to CHAR_STRING.
2949 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2950 by silently ignoring the top 32 bits, allowing some values
2951 that were far too large to be valid characters.
2952 * character.h: Include <verify.h>.
2953 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2954 arguments are no wider than unsigned, as a compile-time check
2955 to prevent future regressions in this area.
2957 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2958 (Fsubst_char_in_region):
2960 * xdisp.c (decode_mode_spec_coding):
2961 Adjust to CHAR_STRING's new requirement.
2962 * editfns.c (Finsert_char, Fsubst_char_in_region):
2963 * fns.c (concat): Check that character args are actually
2964 characters. Without this test, these functions did the wrong
2965 thing with wildly out-of-range values on 64-bit hosts.
2967 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2968 These casts should not be needed on 32-bit hosts, either.
2969 * keyboard.c (read_char):
2970 * lread.c (Fload): Remove casts to unsigned.
2972 * lisp.h (UNSIGNED_CMP): New macro.
2973 This fixes comparison bugs on 64-bit hosts.
2974 (ASCII_CHAR_P): Use it.
2975 * casefiddle.c (casify_object):
2976 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2977 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2978 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2979 * dispextern.h (FACE_FROM_ID):
2980 * keyboard.c (read_char): Use UNSIGNED_CMP.
2982 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2983 not to EMACS_INT, to avoid GCC warning.
2985 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2987 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2988 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2989 isn't needed on 32-bit machines.
2991 * buffer.c (Fgenerate_new_buffer_name):
2992 Use EMACS_INT for count, not int.
2993 (advance_to_char_boundary): Return EMACS_INT, not int.
2995 * data.c (Qcompiled_function): Now static.
2997 * window.c (window_body_lines): Now static.
2999 * image.c (gif_load): Rename local to avoid shadowing.
3001 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3002 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3003 * alloc.c (make_save_value): Integer argument is now of type
3005 (mark_object): Use ptrdiff_t, not int.
3006 * lisp.h (pD): New macro.
3007 * print.c (print_object): Use it.
3009 * alloc.c: Use EMACS_INT, not int, to count objects.
3010 (total_conses, total_markers, total_symbols, total_vector_size)
3011 (total_free_conses, total_free_markers, total_free_symbols)
3012 (total_free_floats, total_floats, total_free_intervals)
3013 (total_intervals, total_strings, total_free_strings):
3014 Now EMACS_INT, not int. All uses changed.
3015 (Fgarbage_collect): Compute overall total using a double, so that
3016 integer overflow is less likely to be a problem. Check for overflow
3017 when converting back to an integer.
3018 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3019 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3020 These were 'int' variables that could overflow on 64-bit hosts;
3021 they were never used, so remove them instead of repairing them.
3022 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3023 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3024 Previously, this ceilinged at INT_MAX, but that doesn't work on
3026 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3028 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3029 (allocate_vectorlike): Check for ptrdiff_t overflow.
3030 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3031 when a (possibly-narrower) signed value would do just as well.
3032 We prefer using signed arithmetic, to avoid comparison confusion.
3034 * alloc.c: Catch some string size overflows that we were missing.
3035 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3036 for convenience in STRING_BYTES_MAX.
3037 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3038 The definition here is exact; the one in lisp.h was approximate.
3039 (allocate_string_data): Check for string overflow. This catches
3040 some instances we weren't catching before. Also, it catches
3041 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3042 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3043 and ptrdiff_t and EMACS_INT are both 64 bits.
3045 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3046 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3047 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3049 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3051 * alloc.c (Fmake_string): Check for out-of-range init.
3053 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3055 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3057 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3059 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3060 xg_get_default_scrollbar_width.
3062 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3063 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3064 (style_changed_cb): Call update_theme_scrollbar_width and call
3065 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3066 all frames (Bug#8505).
3067 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3068 Call gtk_window_set_resizable if HAVE_GTK3.
3069 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3070 and height if HAVE_GTK3 (Bug#8505).
3071 (scroll_bar_width_for_theme): New variable.
3072 (update_theme_scrollbar_width): New function.
3073 (xg_get_default_scrollbar_width): Move code to
3074 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3075 (xg_initialize): Call update_theme_scrollbar_width.
3077 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3079 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3081 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3083 * frame.c (make_frame): Call other_buffer_safely instead of
3086 * window.c (temp_output_buffer_show): Call display_buffer with
3087 second argument Vtemp_buffer_show_specifiers and reset latter
3088 immediately after the call.
3089 (Vtemp_buffer_show_specifiers): New variable.
3090 (auto_window_vscroll_p, next_screen_context_lines)
3091 (Vscroll_preserve_screen_position): Remove leading asterisks from
3094 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3096 Fix minor problems found by GCC 4.6.0 static checking.
3097 * buffer.c (Qclone_number): Remove for now, as it's unused.
3098 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3099 (record_buffer): Remove unused local.
3100 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3101 (set_frame_buffer_list): Remove; unused.
3102 * frame.h (other_visible_frames): Remove decl.
3103 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3104 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3105 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3107 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3108 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3109 Define only if HAVE_GPM.
3110 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3111 (update_hints_inhibit): Remove; never set. All uses removed.
3112 * widgetprv.h (emacsFrameClassRec): Remove decl.
3113 * window.c (delete_deletable_window): Now returns void, since it
3114 wasn't returning anything.
3115 (compare_window_configurations): Remove unused locals.
3116 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3117 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3118 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3119 the same widths as pointers. This follows up on the 2011-05-06 patch.
3120 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3121 * xterm.h: Likewise.
3122 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3124 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3126 * makefile.w32-in: Update dependencies.
3127 (LISP_H): Add lib/intprops.h.
3129 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3131 * image.c (gif_load): Add animation frame delay to the metadata.
3132 (syms_of_image): Use DEFSYM. New symbol `delay'.
3134 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3136 * window.c (delete_deletable_window): Re-add.
3137 (Fset_window_configuration): Rewrite to handle dead buffers and
3138 consequently deletable windows.
3139 (window_tree, Fwindow_tree): Remove. Supply functionality in
3141 (compare_window_configurations): Simplify code.
3143 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3145 * image.c (imagemagick_load_image): Fix type mismatch.
3146 (Fimagemagick_types): Likewise.
3148 * window.h (replace_buffer_in_windows): Declare.
3150 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3152 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3153 Qclone_number. Remove external declaration of Qdelete_window.
3154 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3156 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3157 Run Qbuffer_list_update_hook if allowed.
3158 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3159 buffer list implementation.
3160 (other_buffer_safely): New function.
3161 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3162 calls to replace_buffer_in_windows and
3163 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3165 (record_buffer): Inhibit quitting and rewrite using quittable
3166 functions. Run Qbuffer_list_update_hook if allowed.
3167 (Frecord_buffer, Funrecord_buffer): New functions.
3168 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3169 Move switch-to-buffer to window.el.
3170 (bury-buffer): Move to window.el.
3171 (Vbuffer_list_update_hook): New variable.
3173 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3176 * window.h (resize_frame_windows): Move up in code.
3177 (Fwindow_frame): Remove EXFUN.
3178 (replace_buffer_in_all_windows): Remove prototype.
3179 (replace_buffer_in_windows_safely): Add prototype.
3181 * window.c: Declare Qdelete_window static again. Move down
3182 declaration of select_count.
3183 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3184 (Fother_window): Move to window.el.
3185 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3186 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3187 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3189 (replace_buffer_in_windows): Implement by calling
3190 Qreplace_buffer_in_windows.
3191 (replace_buffer_in_all_windows): Remove with some functionality
3192 moved into replace_buffer_in_windows_safely.
3193 (replace_buffer_in_windows_safely): New function.
3194 (select_window_norecord, select_frame_norecord): Move in front
3195 of run_window_configuration_change_hook. Remove now obsolete
3197 (Fset_window_buffer): Rewrite doc-string.
3198 Call Qrecord_window_buffer.
3199 (keys_of_window): Move binding for other-window to window.el.
3201 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3203 * dispextern.h (struct image): Replace data member, whose int_val
3204 and ptr_val fields were not used by anything, with a single
3207 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3208 (gif_clear_image, gif_load, imagemagick_load_image)
3209 (gs_clear_image, gs_load): Callers changed.
3211 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3213 * buffer.h: Include <time.h>, for time_t.
3214 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3216 Fix minor problems found by static checking.
3218 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3220 Make identifiers static if they are not used in other modules.
3221 * data.c (Qcompiled_function, Qframe, Qvector):
3222 * image.c (QimageMagick, Qsvg):
3223 * minibuf.c (Qmetadata):
3224 * window.c (resize_window_check, resize_root_window): Now static.
3225 * window.h (resize_window_check, resize_root_window): Remove decls.
3227 * window.c (window_deletion_count, delete_deletable_window):
3229 (window_body_lines): Now static.
3230 (Fdelete_other_windows_internal): Mark vars as initialized.
3231 Make sure 'resize_failed' is initialized.
3232 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3233 (resize_window_apply): Remove unused local.
3234 * window.h (delete_deletable_window): Remove decl.
3236 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3237 (imagemagick_load_image): Fix pointer signedness problem by changing
3238 last arg from unsigned char * to char *. All uses changed.
3239 Also, fix a local for similar reasons.
3240 Remove unused locals. Remove locals to avoid shadowing.
3241 (fn_rsvg_handle_free): Remove; unused.
3242 (svg_load, svg_load_image): Fix pointer signedness problem.
3243 (imagemagick_load_image): Don't use garbage pointer image_wand.
3245 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3247 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3249 * image.c (gif_load): Fix omitted cast error introduced by
3252 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3254 * window.h (resize_proportionally, orig_total_lines)
3255 (orig_top_line): Remove from window structure.
3256 (set_window_height, set_window_width, change_window_heights)
3257 (Fdelete_window): Remove prototypes.
3258 (resize_frame_windows): Remove duplicate declaration.
3260 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3262 * window.h (resize_frame_windows, resize_window_check)
3263 (delete_deletable_window, resize_root_window)
3264 (resize_frame_windows): Declare prototypes.
3266 * window.c (resize_window_apply): Make definition be "static" to
3267 match the prototype.
3269 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3271 * window.c: Remove declarations of Qwindow_size_fixed,
3272 window_min_size_1, window_min_size_2, window_min_size,
3273 size_window, window_fixed_size_p, enlarge_window, delete_window.
3274 Remove static from declaration of Qdelete_window, it's
3275 temporarily needed by Fbury_buffer.
3276 (replace_window): Don't assign orig_top_line and
3278 (Fdelete_window, delete_window): Remove. Window deletion is
3279 handled by window.el.
3280 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3281 Replace Fdelete_window calls with calls to Qdelete_window.
3282 (Fdelete_other_windows): Remove. Deleting other windows is
3283 handled by window.el.
3284 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3285 handled in window.el.
3286 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3287 Window minimum sizes are handled in window.el.
3288 (shrink_windows, size_window, set_window_height)
3289 (set_window_width, change_window_heights, window_height)
3290 (window_width, CURBEG, CURSIZE, enlarge_window)
3291 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3292 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3293 handled in window.el.
3294 (make_dummy_parent): Rename to make_parent_window and give it a
3295 second argument horflag.
3296 (make_window): Don't set resize_proportionally any more.
3297 (Fsplit_window): Remove. Windows are split in window.el.
3298 (save_restore_action, save_restore_orig_size)
3299 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3300 Resize mini windows in window.el.
3301 (grow_mini_window, shrink_mini_window): Implement by calling
3302 Qresize_root_window_vertically, resize_window_check and
3303 resize_window_apply.
3304 (saved_window, Fset_window_configuration, save_window_save):
3305 Do not handle orig_top_line, orig_total_lines, and
3306 resize_proportionally.
3307 (window_min_height, window_min_width): Move to window.el.
3308 (keys_of_window): Move bindings for delete-other-windows,
3309 split-window, delete-window and enlarge-window to window.el.
3311 * buffer.c: Temporarily extern Qdelete_window.
3312 (Fbury_buffer): Temporarily call Qdelete_window instead of
3313 Fdelete_window (Fbury_buffer will move to window.el soon).
3315 * frame.c (set_menu_bar_lines_1): Remove code handling
3316 orig_top_line and orig_total_lines.
3318 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3319 set_window_height but set heights directly.
3320 (change_frame_size_1): Use resize_frame_windows.
3322 * xdisp.c (init_xdisp): Don't use set_window_height but set
3325 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3326 Use resize_frame_windows instead of change_window_heights and run
3327 run_window_configuration_change_hook.
3329 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3330 instead of change_window_heights and run
3331 run_window_configuration_change_hook.
3333 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3335 * window.c (replace_window): Rename second argument REPLACEMENT to
3336 NEW. New third argument SETFLAG. Rewrite.
3337 (delete_window, make_dummy_parent): Call replace_window with
3339 (window_list_1): Move down in code.
3340 (run_window_configuration_change_hook): Move set_buffer part
3341 before select_frame_norecord part in order to unwind correctly.
3342 Rename count1 to count.
3343 (recombine_windows, delete_deletable_window, resize_root_window)
3344 (Fdelete_other_windows_internal)
3345 (Frun_window_configuration_change_hook, make_parent_window)
3346 (resize_window_check, resize_window_apply, Fresize_window_apply)
3347 (resize_frame_windows, Fsplit_window_internal)
3348 (Fdelete_window_internal, Fresize_mini_window_internal):
3350 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3352 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3354 * window.h (window): Add some new members to window structure -
3355 normal_lines, normal_cols, new_total, new_normal, clone_number,
3356 splits, nest, prev_buffers, next_buffers.
3357 (WINDOW_TOTAL_SIZE): Move here from window.c.
3358 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3360 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3362 (make_dummy_parent): Set new members of windows structure.
3363 (make_window): Move down in code. Handle new members of window
3365 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3366 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3367 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3368 (Fset_window_prev_buffers, Fwindow_next_buffers)
3369 (Fset_window_next_buffers, Fset_window_clone_number):
3371 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3372 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3374 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3375 Argument WINDOW can be now internal window too.
3376 (Fwindow_use_time): Move up in code.
3377 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3379 (Fset_window_configuration, saved_window)
3380 (Fcurrent_window_configuration, save_window_save): Handle new
3381 members of window structure.
3382 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3383 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3384 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3385 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3386 Qget_mru_window, Qresize_root_window,
3387 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3388 Qauto_buffer_name; staticpro them.
3390 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3392 * window.c (Fwindow_total_size, Fwindow_left_column)
3393 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3394 (Fwindow_list_1): New functions.
3395 (window_box_text_cols): Replace with window_body_cols.
3396 (Fwindow_width, Fscroll_left, Fscroll_right):
3397 Use window_body_cols instead of window_box_text_cols.
3398 (delete_window, Fset_window_configuration):
3399 Call delete_all_subwindows with window as argument.
3400 (delete_all_subwindows): Take a window as argument and not a
3402 (window_loop): Remove handling of GET_LRU_WINDOW and
3404 (Fget_lru_window, Fget_largest_window): Move to window.el.
3406 * window.h: Extern window_body_cols instead of
3407 window_box_text_cols. delete_all_subwindows now takes a
3408 Lisp_Object as argument.
3410 * indent.c (compute_motion, Fcompute_motion):
3411 Use window_body_cols instead of window_box_text_cols.
3413 * frame.c (delete_frame): Call delete_all_subwindows with root
3416 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3418 * fns.c (Fputhash): Document return value.
3420 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3422 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3424 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3426 Cons<->int and similar integer overflow fixes (Bug#8794).
3428 Check for overflow when converting integer to cons and back.
3429 * charset.c (Fdefine_charset_internal, Fdecode_char):
3430 Use cons_to_unsigned to catch overflow.
3431 (Fencode_char): Use INTEGER_TO_CONS.
3432 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3433 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3434 * data.c (long_to_cons, cons_to_long): Remove.
3435 (cons_to_unsigned, cons_to_signed): New functions.
3436 These signal an error for invalid or out-of-range values.
3437 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3438 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3439 * font.c (Ffont_variation_glyphs):
3440 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3441 * lisp.h: Include <intprops.h>.
3442 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3443 (cons_to_signed, cons_to_unsigned): New decls.
3444 (long_to_cons, cons_to_long): Remove decls.
3445 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3446 (Fprimitive_undo): Use CONS_TO_INTEGER.
3447 * xfns.c (Fx_window_property): Likewise.
3448 * xselect.c: Include <limits.h>.
3449 (x_own_selection, selection_data_to_lisp_data):
3450 Use INTEGER_TO_CONS.
3451 (x_handle_selection_request, x_handle_selection_clear)
3452 (x_get_foreign_selection, Fx_disown_selection_internal)
3453 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3454 (lisp_data_to_selection_data): Use cons_to_unsigned.
3455 (x_fill_property_data): Use cons_to_signed.
3456 Report values out of range.
3458 Check for buffer and string overflow more precisely.
3459 * buffer.h (BUF_BYTES_MAX): New macro.
3460 * lisp.h (STRING_BYTES_MAX): New macro.
3461 * alloc.c (Fmake_string):
3462 * character.c (string_escape_byte8):
3463 * coding.c (coding_alloc_by_realloc):
3464 * doprnt.c (doprnt):
3465 * editfns.c (Fformat):
3467 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3468 since they may not be the same number.
3469 * editfns.c (Finsert_char):
3470 * fileio.c (Finsert_file_contents):
3471 Likewise for BUF_BYTES_MAX.
3473 * image.c: Use ptrdiff_t, not int, for sizes.
3474 (slurp_file): Switch from int to ptrdiff_t.
3476 (slurp_file): Check that file size fits in both size_t (for
3477 malloc) and ptrdiff_t (for sanity and safety).
3479 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3480 if b->modtime has its maximal value.
3482 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3484 Don't assume time_t can fit into int.
3485 * buffer.h (struct buffer.modtime): Now time_t, not int.
3486 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3487 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3489 Minor fixes for signed vs unsigned integers.
3490 * character.h (MAYBE_UNIFY_CHAR):
3491 * charset.c (maybe_unify_char):
3492 * keyboard.c (read_char, reorder_modifiers):
3493 XINT -> XFASTINT, since the integer must be nonnegative.
3494 * ftfont.c (ftfont_spec_pattern):
3495 * keymap.c (access_keymap, silly_event_symbol_error):
3496 XUINT -> XFASTINT, since the integer must be nonnegative.
3497 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3498 since it makes no difference and we prefer signed.
3499 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3500 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3503 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3505 * window.h (Fwindow_frame): Declare.
3507 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3509 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3510 (SPARE_MEMORY): Always define.
3511 (LARGE_REQUEST): Remove.
3512 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3514 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3516 * lisp.h: Move EXFUNS for Fframe_root_window,
3517 Fframe_first_window and Fset_frame_selected_window to window.h.
3519 * window.h: Move EXFUNS for Fframe_root_window,
3520 Fframe_first_window and Fset_frame_selected_window here from
3523 * frame.c (Fwindow_frame, Fframe_first_window)
3524 (Fframe_root_window, Fframe_selected_window)
3525 (Fset_frame_selected_window): Move to window.c.
3526 (Factive_minibuffer_window): Move to minibuf.c.
3527 (Fother_visible_frames_p): New function.
3529 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3531 * window.c (decode_window, decode_any_window): Move up in code.
3532 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3533 (inhibit_frame_unsplittable): Remove unused variable.
3534 (Fwindow_buffer): Move up and rewrite doc-string.
3535 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3536 (Fwindow_prev): New functions.
3537 (Fwindow_frame): Move here from frame.c. Accept any window as
3539 (Fframe_root_window, Fframe_first_window)
3540 (Fframe_selected_window): Move here from frame.c. Accept frame
3541 or arbitrary window as argument. Update doc-strings.
3542 (Fminibuffer_window): Move up in code.
3543 (Fwindow_minibuffer_p): Move up in code and simplify.
3544 (Fset_frame_selected_window): Move here from frame.c.
3546 (Fselected_window, select_window, Fselect_window): Move up in
3547 code. Minor doc-string fixes.
3549 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3551 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3552 Do not assume that spare memory exists; that assumption is valid
3553 only if SYSTEM_MALLOC.
3554 (LARGE_REQUEST): New macro, so that the issue of large requests
3555 is separated from the issue of spare memory.
3557 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3559 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3562 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3564 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3567 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3569 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3571 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3573 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3574 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3576 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3578 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3580 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3582 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3583 (x_clipboard_manager_save): Add return value.
3584 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3586 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3587 Obey Vx_select_enable_clipboard_manager. Catch errors in
3588 x_clipboard_manager_save (Bug#8779).
3589 (Vx_select_enable_clipboard_manager): New variable.
3590 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3592 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3594 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3596 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3598 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3599 in the current matrix if keep_current_p is non-zero.
3601 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3603 * bidi.c (bidi_level_of_next_char): Fix last change.
3605 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3607 Support bidi reordering of text covered by display properties.
3609 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3610 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3611 (bidi_cache_search, bidi_cache_iterator_state)
3612 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3613 (bidi_level_of_next_char, bidi_move_to_visually_next):
3614 Support character positions inside a run of characters covered by a
3616 (bidi_paragraph_init, bidi_resolve_explicit_1)
3617 (bidi_level_of_next_char): Call bidi_fetch_char and
3618 bidi_fetch_char_advance instead of FETCH_CHAR and
3620 (bidi_init_it): Initialize new members.
3621 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3623 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3624 instead of using explicit *_CHAR codes.
3625 (bidi_resolve_explicit, bidi_resolve_weak):
3626 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3627 bidirectional text is supported only in multibyte buffers.
3628 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3629 it to initialize the frame_window_p member of struct bidi_it.
3630 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3631 (bidi_resolve_explicit, bidi_resolve_weak)
3632 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3633 bidi_it->nchars is non-positive.
3634 (bidi_level_of_next_char): Don't try to lookup the cache for the
3635 next/previous character if nothing is cached there yet, or if we
3636 were just reseat()'ed to a new position.
3638 * xdisp.c (set_cursor_from_row): Set start and stop points
3639 according to the row's direction when priming the loop that looks
3640 for the glyph on which to display cursor.
3641 (single_display_spec_intangible_p): Function deleted.
3642 (display_prop_intangible_p): Reimplement to call
3643 handle_display_spec instead of single_display_spec_intangible_p.
3644 Accept 3 additional arguments needed by handle_display_spec.
3645 This fixes incorrect cursor motion across display property with complex
3646 values: lists, `(when COND...)' forms, etc.
3647 (single_display_spec_string_p): Support property values that are
3648 lists with the argument STRING its top-level element.
3649 (display_prop_string_p): Fix the condition for processing a
3650 property that is a list to be consistent with handle_display_spec.
3651 (handle_display_spec): New function, refactored from the
3652 last portion of handle_display_prop.
3653 (compute_display_string_pos): Accept additional argument
3654 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3655 value of a `display' property is a "replacing spec".
3656 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3657 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3658 the display property, but just return a value indicating whether
3659 the display property will replace the characters it covers.
3660 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3661 frame_window_p members of struct bidi_it.
3662 (compute_display_string_pos, compute_display_string_end):
3664 (push_it): Accept second argument POSITION, where pop_it should
3665 jump to continue iteration.
3666 (reseat_1): Initialize bidi_it.disp_pos.
3668 * keyboard.c (adjust_point_for_property): Adjust the call to
3669 display_prop_intangible_p to its new signature.
3671 * dispextern.h (struct bidi_it): New member frame_window_p.
3672 (bidi_init_it): Update prototypes.
3673 (display_prop_intangible_p): Update prototype.
3674 (compute_display_string_pos, compute_display_string_end):
3676 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3679 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3681 Malloc failure behavior now depends on size of allocation.
3682 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3683 * lisp.h: Change signatures accordingly.
3684 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3685 All callers changed. (Bug#8762)
3687 * gnutls.c: Use Emacs's memory allocators.
3688 Without this change, the gnutls library would invoke malloc etc.
3689 directly, which causes problems on non-SYNC_INPUT hosts, and which
3690 runs afoul of improving memory_full behavior. (Bug#8761)
3691 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3692 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3693 xfree instead of the default malloc, realloc, free.
3694 (Fgnutls_boot): No need to check for memory allocation failure,
3695 since xmalloc does that for us.
3697 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3698 * category.c (hash_get_category_set):
3699 * ccl.c (ccl_driver):
3700 * charset.c (Fdefine_charset_internal):
3701 * charset.h (struct charset.hash_index):
3702 * composite.c (get_composition_id, gstring_lookup_cache)
3703 (composition_gstring_put_cache):
3704 * composite.h (struct composition.hash_index):
3705 * dispextern.h (struct image.hash):
3706 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3707 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3708 (hashfn_equal, hashfn_user_defined, make_hash_table)
3709 (maybe_resize_hash_table, hash_lookup, hash_put)
3710 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3711 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3712 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3713 * image.c (make_image, search_image_cache, lookup_image)
3714 (xpm_put_color_table_h):
3715 * lisp.h (struct Lisp_Hash_Table):
3716 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3717 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3718 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3719 * alloc.c (allocate_vectorlike):
3720 Check for overflow in vector size calculations.
3721 * ccl.c (ccl_driver):
3722 Check for overflow when converting EMACS_INT to int.
3723 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3724 need to be updated by these changes.
3725 * fns.c (make_hash_table, maybe_resize_hash_table):
3726 Check for integer overflow with large hash tables.
3727 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3728 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3729 (SXHASH_REDUCE): New macro.
3730 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3731 Use it instead of discarding useful hash info with large hash values.
3732 (sxhash_float): New function.
3733 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3734 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3735 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3736 Rewrite to use FIXNUM_BITS, as this simplifies things.
3737 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3738 Adjust signatures to match updated version of code.
3739 (consing_since_gc): Now EMACS_INT, since a single hash table can
3740 use more than INT_MAX bytes.
3742 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3744 Make it possible to build with GCC-4.6+ -O2 -flto.
3746 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3748 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3750 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3751 Call minibuffer-inactive-mode.
3753 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3755 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3756 Update dependencies.
3758 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3760 * data.c (init_data): Remove code for UTS, this system is not
3763 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3765 Don't force ./temacs to start in terminal mode.
3767 * frame.c (make_initial_frame): Initialize faces in all cases, not
3768 only when CANNOT_DUMP is defined.
3769 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3771 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3773 * dispnew.c (add_window_display_history): Use const for the string
3774 pointer. Remove declaration, not needed.
3776 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3778 Use 'inline', not 'INLINE'.
3779 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3780 * alloc.c, fontset.c (INLINE): Remove.
3781 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3782 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3783 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3784 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3785 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3787 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3789 Make it possible to run ./temacs.
3791 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3792 syms_of_callproc does the same thing. Remove test for
3793 "initialized", do it in the caller.
3794 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3796 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3798 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3799 (read_minibuf): Use get_minibuffer.
3800 (syms_of_minibuf): Use DEFSYM.
3801 (Qmetadata): New var.
3802 * data.c (Qbuffer): Don't make it static.
3803 (syms_of_data): Use DEFSYM.
3805 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3807 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3808 (CCL_CODE_MIN): New macro.
3810 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3812 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3814 * eval.c (Qdebug): Now static.
3815 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3816 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3817 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3819 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3821 * image.c: Various fixes to ImageMagick code comments.
3822 (Fimagemagick_types): Doc fix.
3824 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3826 Minor fixes prompted by GCC 4.6.0 warnings.
3828 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3830 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3831 (x_clipboard_manager_save_all): Move extern decl to ...
3832 * xterm.h: ... here, so that it can be checked for consistency.
3834 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3836 * xselect.c (x_clipboard_manager_save_frame)
3837 (x_clipboard_manager_save_all): New functions.
3838 (Fx_clipboard_manager_save): Lisp function deleted.
3840 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3841 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3843 * xterm.h: Update prototype.
3845 2011-05-28 William Xu <william.xwl@gmail.com>
3847 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3850 2011-05-28 Jim Meyering <meyering@redhat.com>
3852 Avoid a sign-extension bug in crypto_hash_function.
3853 * fns.c (to_uchar): Define.
3854 (crypto_hash_function): Use it to convert some newly-signed
3855 variables to unsigned, to avoid sign-extension bugs. For example,
3856 without this change, (md5 "truc") would evaluate to
3857 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3858 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3859 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3861 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3863 Integer overflow fixes.
3865 * dbusbind.c: Serial number integer overflow fixes.
3866 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3867 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3868 to hold a serial number that is too large for a fixnum.
3869 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3870 Check for serial numbers out of range. Decode any serial number
3871 that was so large that it became a float. (Bug#8722)
3873 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3874 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3875 Use XFASTINT rather than XUINT when numbers are nonnegative.
3876 (xd_append_arg, Fdbus_method_return_internal):
3877 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3878 arguments, check that Lisp number is nonnegative, rather than
3879 silently wrapping negative numbers around. (Bug#8722)
3880 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3883 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3885 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3887 ccl: add integer overflow checks
3888 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3889 (IN_INT_RANGE): New macros.
3890 (ccl_driver): Use them to check for integer overflow when
3891 decoding a CCL program. Many of the new checks are whether XINT (x)
3892 fits in int; it doesn't always, on 64-bit hosts. The new version
3893 doesn't catch all possible integer overflows, but it's an
3894 improvement. (Bug#8719)
3896 * alloc.c (make_event_array): Use XINT, not XUINT.
3897 There's no need for unsigned here.
3899 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3900 This follows up to the 2011-05-06 change that substituted uintptr_t
3901 for EMACS_INT. This case wasn't caught back then.
3903 Rework Fformat to avoid integer overflow issues.
3904 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3905 now (part of C89). Include <verify.h>.
3906 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3907 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3908 (Fformat): Avoid the prepass trying to compute sizes; it was only
3909 approximate and thus did not catch overflow reliably. Instead, walk
3910 through the format just once, formatting and computing sizes as we go,
3911 checking for integer overflow at every step, and allocating a larger
3912 buffer as needed. Keep track separately whether the format is
3913 multibyte. Keep only the most-recently calculated precision, rather
3914 than them all. Record whether each argument has been converted to
3915 string. Use EMACS_INT, not int, for byte and char and arg counts.
3916 Support field widths and precisions larger than INT_MAX. Avoid
3917 sprintf's undefined behavior with conversion specifications such as %#d
3918 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3919 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3920 formatting out-of-range floating point numbers with int
3923 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3925 * data.c: Avoid integer truncation in expressions involving floats.
3926 * data.c: Include <intprops.h>.
3927 (arith_driver): When there's an integer overflow in an expression
3928 involving floating point, convert the integers to floating point
3929 so that the resulting value does not suffer from catastrophic
3930 integer truncation. For example, on a 64-bit host (* 4
3931 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3932 Do not rely on undefined behavior after integer overflow.
3934 merge count_size_as_multibyte, parse_str_to_multibyte
3935 * character.c, character.h (count_size_as_multibyte):
3936 Rename from parse_str_to_multibyte; all uses changed.
3937 Check for integer overflow.
3938 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3939 since it's now a duplicate of the other. This is more of
3940 a character than a buffer op, so better that it's in character.c.
3941 * fns.c, print.c: Adjust to above changes.
3943 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3945 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3947 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3949 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3950 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3951 (x_clipboard_manager_save): Now static.
3952 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3954 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3955 (crypto_hash_function): Now static.
3956 Fix pointer signedness problems. Avoid unnecessary initializations.
3958 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3960 * termhooks.h (Vselection_alist): Make it terminal-local.
3962 * terminal.c (create_terminal): Initialize it.
3964 * xselect.c: Support for clipboard managers.
3965 (Vselection_alist): Move to termhooks.h as terminal-local var.
3966 (LOCAL_SELECTION): New macro.
3967 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3968 (symbol_to_x_atom): Remove gratuitous arg.
3969 (x_handle_selection_request, lisp_data_to_selection_data)
3970 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3971 (x_own_selection, x_get_local_selection, x_convert_selection):
3972 New arg, specifying work frame. Use terminal-local Vselection_alist.
3973 (some_frame_on_display): Delete unused function.
3974 (Fx_own_selection_internal, Fx_get_selection_internal)
3975 (Fx_disown_selection_internal, Fx_selection_owner_p)
3976 (Fx_selection_exists_p): New optional frame arg.
3977 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3978 (x_handle_selection_clear): Don't treat other terminals with the
3979 same keyboard specially. Use the terminal-local Vselection_alist.
3980 (x_clear_frame_selections): Use Frun_hook_with_args.
3982 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3984 * xterm.h: Add support for those atoms.
3986 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3988 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3989 (converted_selections, conversion_fail_tag): New global variables.
3990 (x_selection_request_lisp_error): Free the above.
3991 (x_get_local_selection): Remove unnecessary code.
3992 (x_reply_selection_request): Args changed; handle arbitrary array
3993 of converted selections stored in converted_selections.
3994 Separate the XChangeProperty and SelectionNotify steps.
3995 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3996 (x_convert_selection): New function.
3997 (x_handle_selection_event): Simplify.
3998 (x_get_foreign_selection): Don't ignore incoming requests while
3999 waiting for an answer; this will fail when we implement
4000 SAVE_TARGETS, and seems unnecessary anyway.
4001 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4002 (Vx_sent_selection_functions): Doc fix.
4004 2011-05-26 Leo Liu <sdl.web@gmail.com>
4006 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4008 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4010 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4012 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4013 for fringe update if it has periodic bitmap.
4014 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4015 and fringe_bitmap_periodic_p.
4017 * fringe.c (get_fringe_bitmap_data): New function.
4018 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4019 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4020 row. Mark glyph row for fringe update if periodicity changed.
4022 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4023 for fringe update unless it has periodic bitmap.
4025 2011-05-25 Kenichi Handa <handa@m17n.org>
4027 * xdisp.c (get_next_display_element): Set correct it->face_id for
4028 a static composition.
4030 2011-05-24 Leo Liu <sdl.web@gmail.com>
4033 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4035 * fns.c (crypto_hash_function, Fsha1): New function.
4036 (Fmd5): Use crypto_hash_function.
4037 (syms_of_fns): Add Ssha1.
4039 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4041 * gnutls.c: Remove unused macros.
4042 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4043 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4044 Remove macros that are defined and never used.
4045 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4047 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4049 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4050 (Fx_get_selection_internal): Minor cleanup.
4051 (Fx_own_selection_internal): Rename arguments for consistency with
4054 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4056 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4058 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4060 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4062 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4064 * dispnew.c (scrolling_window): Don't exclude the case that the
4065 last enabled row in the desired matrix touches the bottom boundary.
4067 2011-05-21 Glenn Morris <rgm@gnu.org>
4069 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4070 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4071 and add some more files.
4073 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4075 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4076 report_file_error introduced by the change from 2011-05-07.
4078 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4080 * systime.h (Time): Define only if emacs is defined.
4081 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4082 where the include path doesn't have X11/X.h by default. See
4083 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4085 2011-05-20 Kenichi Handa <handa@m17n.org>
4087 * composite.c (find_automatic_composition): Fix previous change.
4089 2011-05-20 Glenn Morris <rgm@gnu.org>
4091 * lisp.mk: New file, split from Makefile.in.
4092 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4093 (shortlisp): Remove.
4094 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4096 2011-05-19 Glenn Morris <rgm@gnu.org>
4098 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4099 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4100 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4101 (lisp): Set the order to that of loadup.el.
4102 (shortlisp): Make it a copy of $lisp.
4103 (SOME_MACHINE_LISP): Remove.
4104 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4105 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4107 2011-05-18 Kenichi Handa <handa@m17n.org>
4109 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4110 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4111 (find_automatic_composition): Mostly rewrite for efficiency.
4113 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4115 * makefile.w32-in: Update dependencies.
4117 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4119 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4120 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4122 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4124 Fix some integer overflow issues, such as string length overflow.
4126 * insdel.c (count_size_as_multibyte): Check for string overflow.
4128 * character.c (lisp_string_width): Check for string overflow.
4129 Use EMACS_INT, not int, for string indexes and lengths; in
4130 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4131 the resulting string length overflows an EMACS_INT; instead,
4132 report a string overflow if no precision given. When checking for
4133 precision exhaustion, use a check that cannot possibly have
4134 integer overflow. (Bug#8675)
4135 * character.h (lisp_string_width): Adjust to new signature.
4137 * alloc.c (string_overflow): New function.
4138 (Fmake_string): Use it. This doesn't change behavior, but saves
4139 a few bytes and will simplify future changes.
4140 * character.c (string_escape_byte8): Likewise.
4141 * lisp.h (string_overflow): New decl.
4143 Fixups, following up to the user-interface timestamp change.
4144 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4145 for UI timestamps, instead of unsigned long.
4146 * msdos.c (mouse_get_pos): Likewise.
4147 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4148 * w32gui.h (Time): Define by including "systime.h" rather than by
4149 declaring it ourselves. (Bug#8664)
4151 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4152 * image.c (clear_image_cache): Likewise.
4154 * term.c (term_mouse_position): Don't assume time_t wraparound.
4156 Be more systematic about user-interface timestamps.
4157 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4158 and sometimes 'EMACS_UINT', to represent these timestamps.
4159 This change causes it to use 'Time' uniformly, as that's what X uses.
4160 This makes the code easier to follow, and makes it easier to catch
4161 integer overflow bugs such as Bug#8664.
4162 * frame.c (Fmouse_position, Fmouse_pixel_position):
4163 Use Time, not unsigned long, for user-interface timestamps.
4164 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4165 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4166 * keyboard.h (last_event_timestamp): Likewise.
4167 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4168 * menu.h (xmenu_show): Likewise.
4169 * term.c (term_mouse_position): Likewise.
4170 * termhooks.h (struct input_event.timestamp): Likewise.
4171 (struct terminal.mouse_position_hook): Likewise.
4172 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4173 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4174 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4175 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4177 * menu.h, termhooks.h: Include "systime.h", for Time.
4179 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4180 Don't assume that the difference between two unsigned long values
4181 can fit into an integer. At this point, we know button_down_time
4182 <= event->timestamp, so the difference must be nonnegative, so
4183 there's no need to cast the result if double-click-time is
4184 nonnegative, as it should be; check that it's nonnegative, just in
4185 case. This bug is triggered when events are more than 2**31 ms
4186 apart (about 25 days). (Bug#8664)
4188 * xselect.c (last_event_timestamp): Remove duplicate decl.
4189 (x_own_selection): Remove needless cast to unsigned long.
4191 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4192 that always fit in int. Use a sentinel instead of a counter, to
4193 avoid a temp and to allay GCC's concerns about possible int overflow.
4194 * frame.h (struct frame): Use int for menu_bar_items_used
4195 instead of EMACS_INT, since it always fits in int.
4197 * menu.c (grow_menu_items): Check for int overflow.
4199 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4201 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4202 Before, the code was not consistent. These values cannot exceed
4203 2**31 - 1 so there's no need to make them unsigned.
4204 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4205 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4206 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4208 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4210 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4211 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4212 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4213 presumably because the widths might not match.
4215 * window.c (size_window): Avoid needless test at loop start.
4217 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4219 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4221 2011-05-12 Drew Adams <drew.adams@oracle.com>
4223 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4225 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4227 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4228 `width' to `bar_area_x' and `bar_area_width', respectively.
4229 (x_scroll_run): Take account of fringe background extension.
4231 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4232 Rename local vars `left' and `width' to `bar_area_x' and
4233 `bar_area_width', respectively.
4234 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4235 background extension.
4237 2011-05-10 Jim Meyering <meyering@redhat.com>
4239 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4241 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4243 * image.c (Finit_image_library): Return t for built-in image types,
4244 like pbm and xbm. (Bug#8640)
4246 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4248 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4250 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4252 * w32console.c (Fset_screen_color): Doc fix.
4253 (Fget_screen_color): New function.
4254 (syms_of_ntterm): Defsubr it.
4256 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4257 unlink the temporary file if Fcall_process didn't create it in the
4259 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4260 child process will be redirected to a file specified with `:file'.
4261 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4262 cue to call_process_cleanup not to close that handle.
4264 2011-05-07 Ben Key <bkey76@gmail.com>
4266 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4267 one of two shell specific rules, either bootstrap-temacs-CMD or
4268 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4269 to the previous implementation of the bootstrap-temacs rule.
4270 The bootstrap-temacs-CMD rule is similar to the previous
4271 implementation of the bootstrap-temacs rule except that it
4272 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4275 These changes, along with some changes to nt/configure.bat,
4276 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4277 earlier fix to add support for --cflags and --ldflags options
4278 that include quotes so that it works whether make uses cmd or
4281 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4283 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4284 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4286 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4287 a string. Handle both cases.
4288 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4289 (Fdbus_register_method): Use Qinvalid_function.
4291 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4293 * makefile.w32-in: Update dependencies.
4294 (LISP_H): Add inttypes.h and stdin.h.
4295 (PROCESS_H): Add unistd.h.
4297 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4299 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4300 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4302 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4304 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4306 * term.c (vfatal): Remove stray call to va_end.
4307 It's not needed and the C Standard doesn't allow it here anyway.
4309 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4310 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4312 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4315 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4317 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4319 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4321 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4323 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4325 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4326 * charset.c (Fdefine_charset_internal): Don't initialize
4327 charset.code_space[15]. The value was garbage, on hosts with
4328 32-bit int (Bug#8600).
4330 * lread.c (read_integer): Be more consistent with string-to-number.
4331 Use string_to_number to do the actual conversion; this avoids
4332 rounding errors and fixes some other screwups. Without this fix,
4333 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4334 (digit_to_number): Move earlier, for benefit of read_integer.
4335 Return -1 if the digit is out of range for the base, -2 if it is
4336 not a digit in any supported base. (Bug#8602)
4338 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4340 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4341 to match comment at start of function. This also removes a
4342 GCC warning about overflow in a 32+64-bit port.
4344 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4346 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4347 Reported by Stefan Monnier in
4348 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4349 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4350 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4352 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4353 (EMACS_UINTPTR): Likewise, with uintptr_t.
4355 * lisp.h: Prefer 64-bit EMACS_INT if available.
4356 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4357 on 32-bit hosts that have 64-bit int, so that they can access
4359 However, temporarily disable this change unless the temporary
4360 symbol WIDE_EMACS_INT is defined.
4362 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4364 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4365 This removes an assumption that EMACS_INT and long are the same
4366 width as pointers. The assumption is true for Emacs porting targets
4367 now, but we want to make other targets possible.
4368 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4369 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4370 In the rest of the code, change types of integers that hold casted
4371 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4372 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4373 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4374 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4375 No need to cast type when ORing.
4376 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4377 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4378 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4379 assume EMACS_INT is the same width as char *.
4380 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4381 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4382 Remove no-longer-needed casts.
4383 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4384 (xg_tool_bar_help_callback, xg_make_tool_item):
4385 Use EMACS_INTPTR to hold an integer
4386 that will be cast to void *; this can avoid a GCC warning
4387 if EMACS_INT is not the same width as void *.
4388 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4389 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4390 (current_message_1, set_message_1):
4391 Use a local to convert to proper width without a cast.
4392 * xmenu.c (dialog_selection_callback): Likewise.
4394 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4395 Also, don't assume VALBITS / RAND_BITS is less than 5,
4396 and don't rely on undefined behavior when shifting a 1 left into
4398 * lisp.h (get_random): Change signature to match.
4400 * lread.c (hash_string): Use size_t, not int, for hash computation.
4401 Normally we prefer signed values; but hashing is special, because
4402 it's better to use unsigned division on hash table sizes so that
4403 the remainder is nonnegative. Also, size_t is the natural width
4404 for hashing into memory. The previous code used 'int', which doesn't
4405 retain enough info to hash well into very large tables.
4406 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4408 * dbusbind.c: Don't possibly lose pointer info when converting.
4409 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4410 Use XPNTR rather than XHASH, so that the high-order bits of
4411 the pointer aren't lost when converting through void *.
4413 * eval.c (Fautoload): Don't double-shift a pointer.
4415 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4417 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4419 * gnutls.c (DEF_GNUTLS_FN):
4420 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4422 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4424 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4427 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4429 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4430 New version that can reserve upto 2GB of heap space.
4432 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4434 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4436 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4438 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4439 `gnutls_certificate_set_x509_key_file'.
4441 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4443 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4444 Update dependencies.
4446 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4448 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4449 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4450 Remove unused parameter `fildes'.
4451 * process.c (read_process_output, send_process): Don't pass it.
4453 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4455 Fix previous change: the library cache is defined in w32.c.
4456 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4457 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4459 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4461 Implement dynamic loading of GnuTLS on Windows.
4463 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4464 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4465 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4468 * gnutls.c (Qgnutls_dll): Define.
4469 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4470 (gnutls_*): Declare function pointers.
4471 (init_gnutls_functions): New function to initialize function pointers.
4472 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4473 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4474 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4475 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4476 (emacs_gnutls_write, emacs_gnutls_read)
4477 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4478 (Fgnutls_available_p): New function.
4479 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4480 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4481 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4483 * image.c: Include w32.h.
4484 (Vimage_type_cache): Delete.
4485 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4486 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4487 (w32_delayed_load): Move to w32.c.
4489 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4491 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4492 (w32_delayed_load): Move from image.c. When loading a library, record
4493 its filename in the :loaded-from property of the library id.
4494 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4495 Initialize and staticpro them.
4496 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4498 * process.c: Include lisp.h before w32.h, not after.
4499 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4500 instead of gnutls_record_check_pending.
4502 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4504 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4506 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4507 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4510 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4512 * xterm.c (x_set_frame_alpha): Do not set property on anything
4513 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4515 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4517 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4519 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4521 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4522 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4523 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4524 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4525 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4526 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4527 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4528 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4529 (Qgnutls_bootprop_callbacks_verify): Make static.
4531 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4533 * callproc.c: Indentation fixup.
4535 * sysdep.c (wait_for_termination_1): Make static.
4536 (wait_for_termination, interruptible_wait_for_termination):
4537 Move after wait_for_termination_1.
4539 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4541 * sysdep.c (interruptible_wait_for_termination): New function
4542 which is like wait_for_termination, but allows keyboard
4545 * callproc.c (Fcall_process): Add (:file "file") as an option for
4547 (Fcall_process_region): Ditto.
4549 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4551 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4552 rather than `XVECTOR (FOO)->size'.
4554 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4555 inttypes.h, as a gnulib replacement is used if it not available in
4558 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4560 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4561 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4562 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4564 * coding.c (coding_alloc_by_realloc): Error out if destination
4565 will grow beyond MOST_POSITIVE_FIXNUM.
4566 (decode_coding_emacs_mule): Abort if there isn't enough place in
4567 charbuf for the composition carryover bytes. Reserve an extra
4568 space for up to 2 characters produced in a loop.
4569 (decode_coding_iso_2022): Abort if there isn't enough place in
4570 charbuf for the composition carryover bytes.
4572 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4574 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4575 aborting when %lld or %lll format is passed.
4576 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4577 %llo or %llx format is passed. (Bug#8545)
4579 * window.c (window_scroll_line_based): Use a marker instead of
4580 simple variables to record original value of point. (Bug#7952)
4582 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4583 produced by %s or %c overflows available buffer space. (Bug#8545)
4585 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4587 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4588 (SIZE_MAX): Move defn after all includes, as they might #define it.
4590 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4592 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4594 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4596 * keyboard.c (Qdelayed_warnings_hook): Define.
4597 (command_loop_1): Run `delayed-warnings-hook'
4598 if Vdelayed_warnings_list is non-nil.
4599 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4600 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4602 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4604 * doprnt.c (doprnt): Don't return value smaller than the buffer
4605 size if the message was truncated. (Bug#8545).
4607 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4609 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4610 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4612 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4614 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4616 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4618 * makefile.w32-in: Update dependencies.
4620 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4622 Improve `doprnt' and its usage. (Bug#8545)
4623 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4624 `format_end'. Remove support for %l as a conversion specifier.
4625 Don't use xrealloc. Improve diagnostics when the %l size modifier
4626 is used. Update the commentary.
4628 * eval.c (verror): Simplify calculation of size_t.
4630 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4633 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4635 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4638 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4640 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4641 This makes this file independent of the recent pseudovector change.
4643 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4645 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4647 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4648 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4649 Remove unused local.
4650 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4652 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4653 GCC 4.6.0 optimizes based on type-based alias analysis.
4654 For example, if b is of type struct buffer * and v of type struct
4655 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4656 != &v->size, and therefore "v->size = 1; b->size = 2; return
4657 v->size;" must therefore return 1. This assumption is incorrect
4658 for Emacs, since it type-puns struct Lisp_Vector * with many other
4659 types. To fix this problem, this patch adds a new type struct
4660 vectorlike_header that documents the constraints on layout of vectors
4661 and pseudovectors, and helps optimizing compilers not get fooled
4662 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4663 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4664 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4666 (XSETPVECTYPE): Rewrite in terms of new macro.
4667 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4668 This is a bit clearer, and further avoids the possibility of
4669 undesirable aliasing.
4670 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4671 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4672 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4673 since Lisp_Subr is a special case (no "next" field).
4674 (ASIZE): Now uses header.size rather than size.
4675 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4676 to avoid the hassle of writing XVECTOR (foo)->header.size.
4677 (struct vectorlike_header): New type.
4678 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4679 object, to help avoid aliasing.
4680 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4681 (SUBRP): Likewise, since Lisp_Subr is a special case.
4682 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4683 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4684 (struct Lisp_Hash_Table): Combine first two members into a single
4685 struct vectorlike_header member. All uses of "size" and "next" members
4686 changed to be "header.size" and "header.next".
4687 * buffer.h (struct buffer): Likewise.
4688 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4689 * frame.h (struct frame): Likewise.
4690 * process.h (struct Lisp_Process): Likewise.
4691 * termhooks.h (struct terminal): Likewise.
4692 * window.c (struct save_window_data, struct saved_window): Likewise.
4693 * window.h (struct window): Likewise.
4694 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4695 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4696 * buffer.c (init_buffer_once): Likewise.
4697 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4699 * process.c (Fformat_network_address): Use local var for size,
4702 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4704 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4705 * data.c (atof): Remove decl; no longer used or needed.
4706 (digit_to_number): Move to lread.c.
4707 (Fstring_to_number): Use new string_to_number function, to be
4708 consistent with how the Lisp reader treats infinities and NaNs.
4709 Do not assume that floating-point numbers represent EMACS_INT
4710 without losing information; this is not true on most 64-bit hosts.
4711 Avoid double-rounding errors, by insisting on integers when
4712 parsing non-base-10 numbers, as the documentation specifies.
4713 * lisp.h (string_to_number): New decl, replacing ...
4714 (isfloat_string): Remove.
4715 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4716 (read1): Do not accept +. and -. as integers; this
4717 appears to have been a coding error. Similarly, do not accept
4718 strings like +-1e0 as floating point numbers. Do not report
4719 overflow for integer overflows unless the base is not 10 which
4720 means we have no simple and reliable way to continue.
4721 Break out the floating-point parsing into a new
4722 function string_to_number, so that Fstring_to_number parses
4723 floating point numbers consistently with the Lisp reader.
4724 (digit_to_number): Move here from data.c. Make it static inline.
4725 (E_CHAR, EXP_INT): Remove, replacing with ...
4726 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4727 (string_to_number): New function, replacing isfloat_string.
4728 This function checks for valid syntax and produces the resulting
4729 Lisp float number too. Rework it so that string-to-number
4730 no longer mishandles examples like "1.0e+". Use strtoumax,
4731 so that overflow for non-base-10 numbers is reported only when
4732 there's no portable and simple way to convert to floating point.
4734 * textprop.c (set_text_properties_1): Rewrite for clarity,
4735 and to avoid GCC warning about integer overflow.
4737 * intervals.h (struct interval): Use EMACS_INT for members
4738 where EMACS_UINT might cause problems. See
4739 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4740 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4741 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4743 (offset_intervals): Tell GCC not to worry about length overflow
4744 when negating a negative length.
4746 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4747 (overrun_check_free): Likewise.
4749 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4750 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4753 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4754 (gnutls_make_error): Rename local to avoid shadowing.
4755 (gnutls_emacs_global_deinit): ifdef out; not used.
4756 (Fgnutls_boot): Use const for pointer to readonly storage.
4757 Comment out unused local. Fix pointer signedness problems.
4759 * lread.c (openp): Don't stuff size_t into an 'int'.
4760 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4761 about possible signed overflow.
4763 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4764 (GDK_KEY_g): Don't define if already defined.
4765 (xg_prepare_tooltip): Avoid pointer signedness problem.
4766 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4768 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4769 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4771 * xfns.c (Fx_window_property): Simplify a bit,
4772 to make a bit faster and to avoid GCC 4.6.0 warning.
4773 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4775 * fns.c (internal_equal): Don't assume size_t fits in int.
4777 * alloc.c (compact_small_strings): Tighten assertion a little.
4779 Replace pEd with more-general pI, and fix some printf arg casts.
4780 * lisp.h (pI): New macro, generalizing old pEd macro to other
4781 conversion specifiers. For example, use "...%"pI"d..." rather
4782 than "...%"pEd"...".
4783 (pEd): Remove. All uses replaced with similar uses of pI.
4784 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4785 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4786 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4787 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4788 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4789 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4790 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4792 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4793 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4794 * print.c (safe_debug_print, print_object): Likewise.
4795 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4797 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4798 avoiding the 0 flag, which is not portable.
4799 * process.c (Fmake_network_process): Use pI to avoid cast.
4800 * region-cache.c (pp_cache): Likewise.
4801 * xdisp.c (decode_mode_spec): Likewise.
4802 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4803 behavior on 64-bit hosts with printf arg.
4804 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4805 (x_stop_queuing_selection_requests): Likewise.
4806 (x_get_window_property): Don't truncate byte count to an 'int'
4809 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4810 here, since it parses constructs like leading '-' and spaces,
4811 which are not wanted; and it overflows with large numbers.
4812 Instead, simply match F[0-9]+, which is what is wanted anyway.
4814 * alloc.c: Remove unportable assumptions about struct layout.
4815 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4816 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4817 (allocate_vectorlike, make_pure_vector): Use the new macros,
4818 plus offsetof, to remove unportable assumptions about struct layout.
4819 These assumptions hold on all porting targets that I know of, but
4820 they are not guaranteed, they're easy to remove, and removing them
4821 makes further changes easier.
4823 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4824 This doesn't fix a bug but makes the code clearer.
4825 (string_overrun_cookie): Now const. Use initializers that
4826 don't formally overflow signed char, to avoid warnings.
4827 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4828 can cause Emacs to crash when string overrun checking is enabled.
4829 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4830 multiple of sizeof (EMACS_INT); it need not be, if
4831 alignof(EMACS_INT) < sizeof (EMACS_INT).
4832 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4834 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4836 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4838 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4840 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4841 supposed to be handshaking. (Bug#8556)
4842 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4844 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4846 * lisp.h (Qdebug): List symbol.
4847 * eval.c (Qdebug): Restore global linkage.
4848 * keyboard.c (debug-on-event): New variable.
4849 (handle_user_signal): Break into debugger when debug-on-event
4850 matches the current signal symbol.
4852 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4854 * alloc.c (check_sblock, check_string_bytes)
4855 (check_string_free_list): Convert to standard C.
4857 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4859 * w32.c (emacs_gnutls_push): Fix typo.
4861 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4863 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4864 "cast to pointer from integer of different size".
4866 Improve doprnt and its use in verror. (Bug#8545)
4867 * doprnt.c (doprnt): Document the set of format control sequences
4868 supported by the function. Use SAFE_ALLOCA instead of always
4871 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4872 is one byte too soon. Don't use xrealloc; instead xfree and
4875 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4877 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4880 * gnutls.c: Renamed global_initialized to
4881 gnutls_global_initialized. Added internals for the
4882 :verify-hostname-error, :verify-error, and :verify-flags
4883 parameters of `gnutls-boot' and documented those parameters in the
4884 docstring. Start callback support.
4885 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4886 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4887 on error. Return error code.
4888 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4889 (emacs_gnutls_read): Likewise.
4890 (Fgnutls_boot): Return handshake error code.
4891 (emacs_gnutls_handle_error): New function.
4892 (wsaerror_to_errno): Likewise.
4894 * w32.h (emacs_gnutls_pull): Add prototype.
4895 (emacs_gnutls_push): Likewise.
4897 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4898 (emacs_gnutls_push): Likewise.
4900 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4902 * process.c (wait_reading_process_output): Check if GnuTLS
4903 buffered some data internally if no FDs are set for TLS
4906 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4907 (LIBS): Link to USER_LIBS.
4908 ($(BLD)/gnutls.$(0)): New target.
4910 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4912 * xdisp.c (handle_single_display_spec): Rename the
4913 display_replaced_before_p argument into display_replaced_p, to
4914 make it consistent with the commentary. Fix typos in the
4917 * textprop.c (syms_of_textprop): Remove dead code.
4918 (copy_text_properties): Delete obsolete commentary about an
4919 interface that was deleted long ago. Fix typos in the description
4922 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4923 to changes in oldXMenu/XMenu.h from 2011-04-16.
4924 <menu_help_message, prev_menu_help_message>: Constify.
4925 (IT_menu_make_room): menu->help_text is now `const char **';
4928 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4929 to changes in oldXMenu/XMenu.h from 2011-04-16.
4930 (struct XMenu): Declare `help_text' `const char **'.
4932 * xfaces.c <Qunspecified>: Make extern again.
4934 * syntax.c: Include sys/types.h before including regex.h, as
4937 * doc.c (get_doc_string): Improve the format passed to `error'.
4939 * doprnt.c (doprnt): Improve commentary.
4941 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4943 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4946 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4947 changes in globals.h immediately force recompilation.
4948 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4949 $(CURDIR)/s/ms-w32.h.
4950 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4952 * character.c (Fchar_direction): Function deleted.
4953 (syms_of_character): Don't defsubr it.
4954 <char-direction-table>: Deleted.
4956 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4958 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4959 * doprnt.c: Include limits.h.
4960 (SIZE_MAX): New macro.
4961 (doprnt): Return a size_t value. 2nd arg is now size_t.
4962 Many local variables are now size_t instead of int or unsigned.
4963 Improve overflow protection. Support `l' modifier for integer
4964 conversions. Support %l conversion. Don't assume an EMACS_INT
4965 argument for integer conversions and for %c.
4967 * lisp.h (doprnt): Restore prototype.
4969 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4972 * Makefile.in (base_obj): Add back doprnt.o.
4974 * deps.mk (doprnt.o): Add back prerequisites.
4975 (callint.o): Depend on character.h.
4977 * eval.c (internal_lisp_condition_case): Include the handler
4978 representation in the error message.
4979 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4980 when breaking from the loop.
4982 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4984 * callint.c (Fcall_interactively): When displaying error message
4985 about invalid control letter, pass the character's codepoint, not
4986 a pointer to its multibyte form. Improve display of the character
4987 in octal and display also its hex code.
4989 * character.c (char_string): Use %x to display the (unsigned)
4990 codepoint of an invalid character, to avoid displaying a bogus
4993 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4994 `error', not SYMBOL_NAME itself.
4996 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4997 character arguments to `error'.
4999 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5000 to `error' in error message about FINAL_CHAR argument. Make sure
5001 FINAL_CHAR is a character, and use %c when it is passed as
5002 argument to `error'.
5004 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5006 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5008 * w32.c: Include <time.h>.
5009 (sys_localtime): New function.
5011 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5013 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5015 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5017 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5019 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5022 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5024 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5025 gl_state.e_property when gl_state.object is Qt.
5027 * insdel.c (make_gap_larger): Remove limitation of buffer size
5030 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5032 * xdisp.c (lookup_glyphless_char_display)
5033 (produce_glyphless_glyph): Handle cons cell entry in
5034 glyphless-char-display.
5035 (Vglyphless_char_display): Document it.
5037 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5038 glyphless-char-display.
5040 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5042 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5044 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5046 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5047 definition for no-X builds.
5049 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5051 Static checks with GCC 4.6.0 and non-default toolkits.
5053 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5055 * process.c (keyboard_bit_set): Define only if SIGIO.
5056 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5057 (send_process): Repair possible setjmp clobbering.
5059 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5061 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5063 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5065 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5066 Define only if needed.
5068 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5069 by pacifying GCC about it. Maybe it's time to retire it?
5070 * xfaces.c (USG, __TIMEVAL__): Likewise.
5072 * dispextern.h (struct redisplay_interface): Rename param
5074 * termhooks.h (struct terminal): Likewise.
5075 * xterm.c (xembed_send_message): Likewise.
5077 * insdel.c (make_gap_smaller): Define only if
5078 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5080 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5083 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5084 so that we aren't warned about unused symbols.
5086 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5088 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5090 * xfns.c (x_real_positions): Mark locals as initialized.
5092 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5094 * xterm.c: Fix problems found by static analysis with other toolkits.
5095 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5096 (x_dispatch_event): Declare static if USE_GTK, and
5097 define if USE_GTK || USE_X_TOOLKIT.
5098 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5099 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5100 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5101 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5103 * xmenu.c (menu_help_callback): Pointer type fixes.
5104 Use const pointers when pointing at readonly data. Avoid pointer
5106 (FALSE): Remove unused macro.
5107 (update_frame_menubar): Remove unused decl.
5109 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5111 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5112 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5113 (single_menu_item): Rename local to avoid shadowing.
5115 * keyboard.c (make_lispy_event): Remove unused local var.
5117 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5118 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5120 * bitmaps: Change bitmaps from unsigned char back to the X11
5121 compatible char. Avoid the old compiler warnings about
5122 out-of-range initializers by using, for example, '\xab' rather
5125 * xgselect.c (xgselect_initialize): Check vs interface
5126 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5128 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5130 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5131 to read-only memory.
5133 * fns.c (vector): Remove; this old hack is no longer needed.
5135 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5137 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5139 * xrdb.c (x_load_resources): Omit unused local.
5141 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5142 (x_window): Rename locals to avoid shadowing.
5143 (USG): Use the kludged USG macro, to pacify gcc.
5145 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5146 (x_term_init): Remove local to avoid shadowing.
5148 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5150 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5151 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5153 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5155 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5157 Fix regex.c, syntax.c and friends for buffers > 2GB.
5158 * syntax.h (struct gl_state_s): Declare character position members
5161 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5163 * textprop.c (verify_interval_modification, interval_of):
5164 Declare arguments EMACS_INT.
5166 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5169 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5171 * indent.c (Fvertical_motion): Local variable it_start is now
5174 * regex.c (re_match, re_match_2, re_match_2_internal)
5175 (bcmp_translate, regcomp, regexec, print_double_string)
5176 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5177 (re_compile_pattern, re_exec): Declare arguments and local
5178 variables `size_t' and `ssize_t' and return values `regoff_t', as
5180 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5181 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5182 <compile_stack_type>: `size' and `avail' are now `size_t'.
5184 * regex.h <regoff_t>: Use ssize_t, not int.
5185 (re_search, re_search_2, re_match, re_match_2): Arguments that
5186 specify buffer/string position and length are now ssize_t and
5187 size_t. Return type is regoff_t.
5189 2011-04-16 Ben Key <bkey76@gmail.com>
5191 * nsfont.m: Fixed bugs in ns_get_family and
5192 ns_descriptor_to_entity that were caused by using free to
5193 deallocate memory blocks that were allocated by xmalloc (via
5194 xstrdup). This caused Emacs to crash when compiled with
5195 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5196 --enable-checking=xmallocoverrun). xfree is now used to
5197 deallocate these memory blocks.
5199 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5201 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5203 emacs_write: Accept and return EMACS_INT for sizes.
5204 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5206 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5207 Accept and return EMACS_INT.
5208 (emacs_gnutls_write): Return the number of bytes written on
5210 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5211 (emacs_read, emacs_write): Remove check for negative size, as the
5212 Emacs source code has been audited now.
5213 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5214 (emacs_read, emacs_write): Use it.
5215 * process.c (send_process): Adjust to the new signatures of
5216 emacs_write and emacs_gnutls_write. Do not attempt to store
5217 a byte offset into an 'int'; it might overflow.
5218 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5220 * sound.c: Don't assume sizes fit in 'int'.
5221 (struct sound_device.period_size, alsa_period_size):
5222 Return EMACS_INT, not int.
5223 (struct sound_device.write, vox_write, alsa_write):
5224 Accept EMACS_INT, not int.
5225 (wav_play, au_play): Use EMACS_INT to store sizes and to
5226 record read return values.
5228 2011-04-15 Ben Key <bkey76@gmail.com>
5230 * keyboard.c (Qundefined): Don't declare static since it is used
5232 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5233 static since they are used in nsfont.m.
5235 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5237 * process.c (Qprocessp): Don't declare static.
5238 * lisp.h (Qprocessp): Declare again.
5240 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5242 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5244 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5246 Improve C-level modularity by making more things 'static'.
5248 Don't publish debugger-only interfaces to other modules.
5249 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5250 (verify_bytepos, count_markers): Move decls to the only modules
5252 * region-cache.h (pp_cache): Likewise.
5253 * window.h (check_all_windows): Likewise.
5254 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5256 * sysdep.c (croak): Now static, if
5257 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5258 * syssignal.h (croak): Declare only if not static.
5260 * alloc.c (refill_memory_reserve): Now static if
5261 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5262 * lisp.h (refill_memory_reserve): Declare only if not static.
5264 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5265 Define only if USE_LUCID.
5267 * xrdb.c (x_customization_string, x_rm_string): Now static.
5269 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5270 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5272 * xdisp.c (draw_row_with_mouse_face): Now static.
5273 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5275 * window.h (check_all_windows): Mark externally visible.
5277 * window.c (window_deletion_count): Now static.
5279 * undo.c: Make symbols static if they're not exported.
5280 (last_undo_buffer, last_boundary_position, pending_boundary):
5283 * textprop.c (interval_insert_behind_hooks): Now static.
5284 (interval_insert_in_front_hooks): Likewise.
5286 * term.c: Make symbols static if they're not exported.
5287 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5288 (max_frame_lines, tty_set_terminal_modes):
5289 (tty_reset_terminal_modes, tty_turn_off_highlight):
5290 (get_tty_terminal): Now static.
5291 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5292 * termhooks.h (term_mouse_moveto): Do not declare if
5294 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5295 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5297 * sysdep.c: Make symbols static if they're not exported.
5298 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5300 (sigprocmask_set, full_mask): Remove; unused.
5301 (wait_debugging): Mark as visible.
5302 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5303 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5305 * syntax.c (syntax_temp): Define only if !__GNUC__.
5307 * sound.c (current_sound_device, current_sound): Now static.
5309 * search.c (searchbufs, searchbuf_head): Now static.
5311 * scroll.c (scroll_cost): Remove; unused.
5312 * dispextern.h (scroll_cost): Remove decl.
5314 * region-cache.h (pp_cache): Mark as externally visible.
5316 * process.c: Make symbols static if they're not exported.
5317 (process_tick, update_tick, create_process, chan_process):
5318 (Vprocess_alist, proc_buffered_char, datagram_access):
5319 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5320 (deactivate_process): Mark defn as static, as well as decl.
5321 * lisp.h (create_process): Remove decl.
5322 * process.h (chan_process, Vprocess_alist): Remove decls.
5324 * print.c: Make symbols static if they're not exported.
5325 (print_depth, new_backquote_output, being_printed, print_buffer):
5326 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5327 (print_interval, print_number_index, initial_stderr_stream):
5329 * lisp.h (Fprinc): Remove decl.
5330 (debug_output_compilation_hack): Mark as externally visible.
5332 * sysdep.c (croak): Move decl from here to syssignal.h.
5333 * syssignal.h (croak): Put it here, so the API can be checked when
5334 'croak' is called from dissociate_if_controlling_tty.
5336 * minibuf.c: Make symbols static if they're not exported.
5337 (minibuf_save_list, choose_minibuf_frame): Now static.
5338 * lisp.h (choose_minibuf_frame): Remove decl.
5340 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5342 * lread.c: Make symbols static if they're not exported.
5343 (read_objects, initial_obarray, oblookup_last_bucket_number):
5345 (make_symbol): Remove; unused.
5346 * lisp.h (initial_obarray, make_symbol): Remove decls.
5348 * keyboard.c: Make symbols static if they're not exported.
5349 (single_kboard, recent_keys_index, total_keys, recent_keys):
5350 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5351 (this_single_command_key_start, echoing, last_auto_save):
5352 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5353 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5354 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5355 (Vlispy_mouse_stem, double_click_count):
5357 (force_auto_save_soon): Define only if SIGDANGER.
5358 (ignore_mouse_drag_p): Now static if
5359 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5360 (print_help): Remove; unused.
5361 (stop_character, last_timer_event): Mark as externally visible.
5362 * keyboard.h (ignore_mouse_drag_p): Declare only if
5363 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5364 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5365 * lisp.h (echoing): Remove decl.
5366 (force_auto_save_soon): Declare only if SIGDANGER.
5367 * xdisp.c (redisplay_window): Simplify code, to make it more
5368 obvious that ignore_mouse_drag_p is not accessed if !defined
5369 USE_GTK && !defined HAVE_NS.
5371 * intervals.c: Make symbols static if they're not exported.
5372 (merge_properties_sticky, merge_interval_right, delete_interval):
5374 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5376 * insdel.c: Make symbols static if they're not exported.
5377 However, leave prepare_to_modify_buffer alone. It's never
5378 called from outside this function, but that appears to be a bug.
5379 (combine_after_change_list, combine_after_change_buffer):
5380 (adjust_after_replace, signal_before_change): Now static.
5381 (adjust_after_replace_noundo): Remove; unused.
5382 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5383 (signal_before_change): Remove decls.
5385 * indent.c (val_compute_motion, val_vmotion): Now static.
5387 * image.c: Make symbols static if they're not exported.
5388 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5390 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5391 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5393 * fringe.c (standard_bitmaps): Now static.
5394 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5396 * frame.c: Make symbols static if they're not exported.
5397 (x_report_frame_params, make_terminal_frame): Now static.
5398 (get_frame_param): Now static, unless HAVE_NS.
5399 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5400 (x_get_resource_string): Remove; not used.
5401 * frame.h (make_terminal_frame, x_report_frame_params):
5402 (x_get_resource_string); Remove decls.
5403 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5404 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5406 * font.c, fontset.c: Make symbols static if they're not exported.
5407 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5408 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5409 * font.c (font_close_object): Now static.
5410 * font.h (font_close_object): Remove.
5411 * fontset.c (FONTSET_OBJLIST): Remove.
5412 (free_realized_fontset) #if-0 the body, which does nothing.
5413 (face_suitable_for_char_p): #if-0, as it's never called.
5414 * fontset.h (face_suitable_for_char_p): Remove decl.
5415 * xfaces.c (face_at_string_position):
5416 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5417 since 0 is always ASCII.
5419 * fns.c (weak_hash_tables): Now static.
5421 * fileio.c: Make symbols static if they're not exported.
5422 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5423 (Vwrite_region_annotation_buffers): Now static.
5425 * eval.c: Make symbols static if they're not exported.
5426 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5427 * lisp.h (backtrace_list): Remove decl.
5429 * emacs.c: Make symbols static if they're not exported.
5430 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5431 (fatal_error_code, fatal_error_signal_hook, standard_args):
5433 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5434 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5435 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5436 * lisp.h (fatal_error_signal_hook): Remove decl.
5437 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5439 * editfns.c: Move a (normally-unused) function to its only use.
5440 * editfns.c, lisp.h (get_operating_system_release): Remove.
5441 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5442 worth the hassle of breaking this out.
5444 * xterm.c: Make symbols static if they're not exported.
5445 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5446 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5447 (x_destroy_window, x_delete_display):
5449 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5450 (x_mouse_leave): Remove; unused.
5451 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5452 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5453 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5455 (x_mouse_leave): Declare only if WINDOWSNT.
5456 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5457 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5460 * ftxfont.c: Make symbols static if they're not exported.
5461 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5463 * font.h (ftxfont_driver): Likewise.
5465 * xfns.c: Make symbols static if they're not exported.
5466 (x_last_font_name, x_display_info_for_name):
5467 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5468 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5469 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5470 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5471 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5472 (last_show_tip_args): Now static.
5473 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5474 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5475 (x_screen_planes): Remove; unused.
5476 * dispextern.h (x_screen_planes): Remove decl.
5478 * dispnew.c: Make symbols static if they're not exported.
5479 * dispextern.h (redraw_garbaged_frames, scrolling):
5480 (increment_row_positions): Remove.
5481 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5482 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5484 (redraw_garbaged_frames): Remove; unused.
5486 * xfaces.c: Make symbols static if they're not exported.
5487 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5489 * xterm.h (defined_color): Remove decls.
5490 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5491 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5492 (menu_face_changed_default, defined_color, free_realized_face):
5493 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5494 (ascii_face_of_lisp_face): Remove; unused.
5496 * xdisp.c: Make symbols static if they're not exported.
5497 * dispextern.h (scratch_glyph_row, window_box_edges):
5498 (glyph_to_pixel_coords, set_cursor_from_row):
5499 (get_next_display_element, set_iterator_to_next):
5500 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5501 (show_mouse_face): Remove decls
5502 * frame.h (message_buf_print): Likewise.
5503 * lisp.h (pop_message, set_message, check_point_in_composition):
5505 * xterm.h (set_vertical_scroll_bar): Likewise.
5506 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5507 (message_buf_print, scratch_glyph_row, displayed_buffer):
5508 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5509 (get_next_display_element, show_mouse_face, window_box_edges):
5510 (frame_to_window_pixel_xy, check_point_in_composition):
5511 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5512 (glyph_to_pixel_coords): Remove; unused.
5514 * dired.c (file_name_completion): Now static.
5516 * dbusbind.c (xd_in_read_queued_messages): Now static.
5518 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5519 * data.c (circular_list_error): Remove.
5521 * commands.h (last_point_position, last_point_position_buffer):
5522 (last_point_position_window): Remove decls.
5523 * keyboard.c: Make these variables static.
5525 * coding.h (coding, code_convert_region, encode_coding_gap):
5527 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5528 (iso_code_class, detect_coding, code_convert_region): Now static.
5529 (encode_coding_gap): Remove; unused.
5531 * chartab.c (chartab_chars, chartab_bits): Now static.
5533 * charset.h (charset_iso_8859_1): Remove decl.
5534 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5537 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5538 * ccl.c (Vccl_program_table): Now static.
5539 (check_ccl_update): Remove; unused.
5541 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5542 * category.h: ... from here.
5543 * category.c (check_category_table, set_category_set): Now static.
5545 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5546 * lisp.h: Remove these decls.
5548 * buffer.c (buffer_count): Remove unused var.
5550 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5551 so that it's not optimized away.
5552 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5553 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5554 exported only to the debugger.
5556 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5557 * atimer.h (run_all_atimers): Remove; not exported.
5559 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5560 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5561 was inaccessible from Lisp.
5562 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5563 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5565 alloc.c: Import and export fewer symbols, and remove unused items.
5566 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5568 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5569 it's not optimized away by whole-program optimization.
5570 (message_enable_multibyte, free_misc): Remove.
5571 (catchlist, handlerlist, mark_backtrace):
5572 Declare only if BYTE_MARK_STACK.
5573 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5574 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5575 (message_enable_multibyte): Remove decl.
5576 (free_misc, interval_free_list, float_block, float_block_index):
5577 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5578 (cons_free_list, last_marked_index):
5580 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5581 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5582 (mark_backtrace): Define only if BYTE_MARK_STACK.
5583 * xdisp.c (message_enable_multibyte): Now static.
5585 Declare Lisp_Object Q* variables to be 'static' if not exported.
5586 This makes it easier for human readers (and static analyzers)
5587 to see whether these variables are used from other modules.
5588 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5589 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5590 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5591 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5592 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5593 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5594 * xmenu.c, xselect.c:
5595 Declare Q* vars static if they are not used in other modules.
5596 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5597 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5598 Remove decls of unexported vars.
5599 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5601 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5603 Make Emacs functions such as Fatom 'static' by default.
5604 This makes it easier for human readers (and static analyzers)
5605 to see whether these functions can be called from other modules.
5606 DEFUN now defines a static function. To make the function external
5607 so that it can be used in other C modules, use the new macro DEFUE.
5608 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5609 (Finit_image_library):
5610 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5611 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5612 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5613 Remove decls, since these functions are now static.
5614 (Funintern, Fget_internal_run_time): New decls, since these functions
5615 were already external.
5617 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5618 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5619 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5620 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5621 * keyboard.c, keymap.c, lread.c:
5622 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5623 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5624 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5625 Mark functions with DEFUE instead of DEFUN,
5626 if they are used in other modules.
5627 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5628 decls for now-static functions.
5629 * buffer.h (Fdelete_overlay): Remove decl.
5630 * callproc.c (Fgetenv_internal): Mark as internal.
5631 * composite.c (Fremove_list_of_text_properties): Remove decl.
5632 (Fcomposition_get_gstring): New forward static decl.
5633 * composite.h (Fcomposite_get_gstring): Remove decl.
5634 * dired.c (Ffile_attributes): New forward static decl.
5635 * doc.c (Fdocumntation_property): New forward static decl.
5636 * eval.c (Ffetch_bytecode): New forward static decl.
5637 (Funintern): Remove extern decl; now in .h file where it belongs.
5638 * fileio.c (Fmake_symbolic_link): New forward static decl.
5639 * image.c (Finit_image_library): New forward static decl.
5640 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5641 * intervals.h (Fprevious_property_change):
5642 (Fremove_list_of_text_properties): Remove decls.
5643 * keyboard.c (Fthis_command_keys): Remove decl.
5644 (Fcommand_execute): New forward static decl.
5645 * keymap.c (Flookup_key): New forward static decl.
5646 (Fcopy_keymap): Now static.
5647 * keymap.h (Flookup_key): Remove decl.
5648 * process.c (Fget_process): New forward static decl.
5649 (Fprocess_datagram_address): Mark as internal.
5650 * syntax.c (Fsyntax_table_p): New forward static decl.
5651 (skip_chars): Remove duplicate decl.
5652 * textprop.c (Fprevious_property_change): New forward static decl.
5653 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5655 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5656 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5658 * editfns.c (Fformat): Remove unreachable code.
5660 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5662 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5665 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5667 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5668 when at ZV. (Bug#8487)
5670 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5672 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5674 * keyboard.c (parse_tool_bar_item): Likewise.
5675 * sound.c (sound_cleanup, alsa_close): Likewise.
5676 * termcap.c (tgetent): Likewise.
5677 * xfns.c (x_default_font_parameter): Likewise.
5678 * xsettings.c (read_and_apply_settings): Likewise.
5680 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5681 (overrun_check_free): Protoize.
5683 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5685 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5686 since callers should never pass a negative size.
5687 Change the signature to match that of plain 'read' and 'write'; see
5688 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5689 * lisp.h: Update prototypes of emacs_write and emacs_read.
5691 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5693 * xdisp.c (redisplay_window): Don't try to determine the character
5694 position of the scroll margin if the window start point w->startp
5695 is outside the buffer's accessible region. (Bug#8468)
5697 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5699 Fix write-region and its subroutines for buffers > 2GB.
5700 * fileio.c (a_write, e_write): Modify declaration of arguments and
5701 local variables to support buffers larger than 2GB.
5702 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5704 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5705 argument, local variables, and return value.
5707 * lisp.h: Update prototypes of emacs_write and emacs_read.
5709 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5711 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5713 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5715 Fix more problems found by GCC 4.6.0's static checks.
5717 * xdisp.c (vmessage): Use a better test for character truncation.
5719 * charset.c (load_charset_map): <, not <=, for optimization,
5720 and to avoid potential problems with integer overflow.
5721 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5722 * casetab.c (set_identity, shuffle): Likewise.
5723 * editfns.c (Fformat): Likewise.
5724 * syntax.c (skip_chars): Likewise.
5726 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5727 This also lets GCC 4.6.0 generate slightly better loop code.
5729 * callint.c (Fcall_interactively): <, not <=, for optimization.
5730 (Fcall_interactively): Count the number of arguments produced,
5731 not the number of arguments given. This is simpler and lets GCC
5732 4.6.0 generate slightly better code.
5734 * ftfont.c: Distingish more carefully between FcChar8 and char.
5735 The previous code passed unsigned char * to a functions like
5736 strlen and xstrcasecmp that expect char *, which does not
5737 conform to the C standard.
5738 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5739 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5740 char * when the C standard requires it.
5742 * keyboard.c (read_char): Remove unused var.
5744 * eval.c: Port to Windows vsnprintf (Bug#8435).
5746 (SIZE_MAX): Define if the headers do not.
5747 (verror): Do not give up if vsnprintf returns a negative count.
5748 Instead, grow the buffer. This ports to Windows vsnprintf, which
5749 does not conform to C99. Problem reported by Eli Zaretskii.
5750 Also, simplify the allocation scheme, by avoiding the need for
5751 calling realloc, and removing the ALLOCATED variable.
5753 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5755 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5756 But keep the doprint source code for now, as we might revamp it
5757 and use it again (Bug#8435).
5758 * lisp.h (doprnt): Remove.
5759 * Makefile.in (base_obj): Remove doprnt.o.
5760 * deps.mk (doprnt.o): Remove.
5762 error: Print 32- and 64-bit integers portably (Bug#8435).
5763 Without this change, on typical 64-bit hosts error ("...%d...", N)
5764 was used to print both 32- and 64-bit integers N, which relied on
5766 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5768 * lisp.h (error, verror): Mark as printf-like functions.
5769 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5770 Report overflow in size calculations when allocating printf buffer.
5771 Do not truncate output string at its first null byte.
5772 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5773 Truncate the output at a character boundary, since vsnprintf does not
5775 * charset.c (check_iso_charset_parameter): Convert internal
5776 character to string before calling 'error', since %c now has the
5778 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5779 overflow when computing char to be passed to 'error'. Do not
5780 pass Lisp_Object to 'error'; pass the integer instead.
5781 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5782 formatted with plain %d.
5784 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5786 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5788 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5790 * xterm.c (x_catch_errors): Remove duplicate declaration.
5792 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5794 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5796 2011-04-10 Jim Meyering <meyering@redhat.com>
5798 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5799 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5800 return ssize_t not "int", and use size_t as the buffer length.
5801 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5802 * gnutls.h: Update declarations.
5803 * process.c (read_process_output): Use ssize_t, to match.
5804 (send_process): Likewise.
5806 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5808 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5810 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5812 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5813 Use unsigned char, to match FcChar8 type definition.
5815 * xterm.c (handle_one_xevent):
5816 * xmenu.c (create_and_show_popup_menu):
5817 * xselect.c (x_decline_selection_request)
5818 (x_reply_selection_request): Avoid type-punned deref of X events.
5820 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5822 Fix some uses of `int' instead of EMACS_INT.
5823 * search.c (string_match_1, fast_string_match)
5824 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5825 (scan_buffer, find_next_newline_no_quit)
5826 (find_before_next_newline, search_command, Freplace_match)
5827 (Fmatch_data): Make some `int' variables be EMACS_INT.
5829 * xdisp.c (display_count_lines): 3rd argument and return value now
5830 EMACS_INT. All callers changed.
5831 (pint2hrstr): Last argument is now EMACS_INT.
5833 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5834 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5835 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5836 (decode_coding_utf_16, decode_coding_emacs_mule)
5837 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5838 (decode_coding_ccl, decode_coding_charset)
5839 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5840 (decode_coding_iso_2022, decode_coding_emacs_mule)
5841 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5842 <char_offset, last_offset>: Declare EMACS_INT.
5843 (encode_coding_utf_8, encode_coding_utf_16)
5844 (encode_coding_emacs_mule, encode_invocation_designation)
5845 (encode_designation_at_bol, encode_coding_iso_2022)
5846 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5847 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5849 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5850 (encode_invocation_designation): Last argument P_NCHARS is now
5852 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5853 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5855 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5858 * ccl.c (Fccl_execute_on_string): Declare some variables
5861 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5863 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5865 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5867 * process.c (Fformat_network_address): Doc fix.
5869 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5871 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5873 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5875 * keyboard.c (read_char): Call Lisp function help-form-show,
5876 instead of using internal_with_output_to_temp_buffer.
5877 (Qhelp_form_show): New var.
5878 (syms_of_keyboard): Use DEFSYM macro.
5880 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5882 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5884 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5886 * process.c (Flist_processes): Remove to Lisp.
5887 (list_processes_1): Delete.
5889 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5891 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5893 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5895 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5897 Fix more problems found by GCC 4.6.0's static checks.
5899 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5901 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5903 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5905 * xdisp.c (vmessage): Mark as a printf-like function.
5907 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5909 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5911 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5912 printf-like functions.
5913 (tiff_load): Add casts to remove these marks before passing them
5914 to system-supplied API.
5916 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5918 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5919 This avoids several warnings with gcc -Wstrict-overflow.
5920 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5921 directly, rather than having caller test rule sign. This avoids
5922 some unnecessary tests.
5923 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5924 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5925 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5927 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5928 (xfont_open): Avoid unnecessary tests.
5930 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5932 * composite.h, composite.c (composition_gstring_put_cache):
5933 Use EMACS_INT, not int, for length.
5935 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5936 breaking out part of COMPOSITION_DECODE_RULE.
5937 (COMPOSITION_DECODE_RULE): Use it.
5938 * composite.c (get_composition_id): Remove unused local vars,
5939 by using the new macro.
5941 * textprop.c (set_text_properties_1): Change while to do-while,
5942 since the condition is always true at first.
5944 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5945 (interval_deletion_adjustment): Return unsigned value.
5948 * process.c (list_processes_1, create_pty, read_process_output):
5949 (exec_sentinel): Remove vars that were set but not used.
5950 (create_pty): Remove unnecessary "volatile"s.
5951 (Fnetwork_interface_info): Avoid possibility of int overflow.
5952 (read_process_output): Do adaptive read buffering even if carryover.
5953 (read_process_output): Simplify nbytes computation if buffered.
5955 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5957 * syntax.c (scan_words): Remove var that was set but not used.
5958 (update_syntax_table): Use unsigned instead of int.
5960 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5961 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5962 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5964 * print.c (print_error_message): Avoid int overflow.
5966 * font.c (font_list_entities): Redo for clarity,
5967 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5969 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5970 (font_score): Avoid potential overflow in diff calculation.
5972 * fns.c (substring_both): Remove var that is set but not used.
5973 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5975 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5977 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5978 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5979 can always succeed if overflow has undefined behavior.
5981 * search.c (boyer_moore, wordify): Remove vars set but not used.
5982 (wordify): Omit three unnecessary tests.
5984 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5985 All callers changed. This avoids the need for an unused var.
5987 * casefiddle.c (casify_region): Remove var that is set but not used.
5989 * dired.c (file_name_completion): Remove var that is set but not used.
5991 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5993 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5994 (Finsert_file_contents): Remove unnecessary code checking fd.
5996 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5997 Check for integer overflow on size calculations.
5999 * buffer.c (Fprevious_overlay_change): Remove var that is set
6002 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6003 Remove vars that are set but not used.
6004 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6005 (timer_check_2): Mark vars as initialized.
6007 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6009 * image.c (lookup_image): Remove var that is set but not used.
6010 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6012 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6013 that are set but not used.
6015 * xfns.c (make_invisible_cursor): Don't return garbage
6016 if XCreateBitmapFromData fails (Bug#8410).
6018 * xselect.c (x_get_local_selection, x_handle_property_notify):
6019 Remove vars that are set but not used.
6021 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6022 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6024 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6025 Remove var that is set but not used.
6026 (scroll_bar_windows_size): Now size_t, not int.
6027 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6030 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6031 (map_tty_color) [!defined MSDOS]: Likewise.
6033 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6035 * coding.c: Remove vars that are set but not used.
6036 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6037 All callers changed.
6038 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6039 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6040 (decode_coding_charset): Remove vars that are set but not used.
6042 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6043 that is set but not used.
6045 * print.c (print_object): Remove var that is set but not used.
6047 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6048 The gnulib version avoids calling malloc in the usual case,
6049 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6050 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6051 * filelock.c (current_lock_owner): Likewise.
6052 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6053 * sysdep.c: Include allocator.h, careadlinkat.h.
6054 (emacs_no_realloc_allocator): New static constant.
6055 (emacs_readlink): New function.
6056 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6057 ../lib/careadlinkat.h.
6059 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6061 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6062 first non-nil return value).
6064 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6066 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6067 if not defined (Bug#8403).
6069 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6071 * xdisp.c (display_count_lines): Remove parameter `start',
6072 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6073 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6074 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6075 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6076 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6077 and thereabouts. All callers changed.
6078 (get_per_char_metric): Remove parameter `f', unused since
6079 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6081 2011-04-02 Jim Meyering <meyering@redhat.com>
6083 do not dereference NULL upon failed strdup
6084 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6085 (ns_get_family): Likewise.
6087 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6089 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6091 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6093 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6096 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6098 Add lexical binding.
6100 * window.c (Ftemp_output_buffer_show): New fun.
6101 (Fsave_window_excursion):
6102 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6104 * lread.c (lisp_file_lexically_bound_p): New function.
6105 (Fload): Bind Qlexical_binding.
6106 (readevalloop): Remove `evalfun' arg.
6107 Bind Qinternal_interpreter_environment.
6108 (Feval_buffer): Bind Qlexical_binding.
6109 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6111 (syms_of_lread): Declare `lexical-binding'.
6113 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6115 * keyboard.c (eval_dyn): New fun.
6116 (menu_item_eval_property): Use it.
6118 * image.c (parse_image_spec): Use Ffunctionp.
6120 * fns.c (concat, mapcar1): Accept byte-code-functions.
6122 * eval.c (Fsetq): Handle lexical vars.
6123 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6124 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6125 (FletX, Flet): Obey lexical binding.
6126 (Fcommandp): Handle closures.
6127 (Feval): New `lexical' arg.
6128 (eval_sub): New function extracted from Feval. Use it almost
6129 everywhere where Feval was used. Look up vars in lexical env.
6131 (Ffunctionp): Move from subr.el.
6132 (Ffuncall): Handle closures.
6133 (apply_lambda): Remove `eval_flags'.
6134 (funcall_lambda): Handle closures and new byte-code-functions.
6135 (Fspecial_variable_p): New function.
6136 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6137 but without exporting it to Lisp.
6139 * doc.c (Fdocumentation, store_function_docstring):
6140 * data.c (Finteractive_form): Handle closures.
6142 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6145 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6147 (exec_byte_code): New function extracted from Fbyte_code to handle new
6148 calling convention for byte-code-functions. Add new byte-codes.
6150 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6152 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6154 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6156 * xdisp.c (redisplay_internal): Fix prototype.
6158 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6160 * xdisp.c (SCROLL_LIMIT): New macro.
6161 (try_scrolling): Use it when setting scroll_limit.
6162 Limit scrolling to 100 screen lines.
6163 (redisplay_window): Even when falling back on "recentering",
6164 position point in the window according to scroll-conservatively,
6165 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6167 (try_scrolling): When point is above the window, allow searching
6168 as far as scroll_max, or one screenful, to compute vertical
6169 distance from PT to the scroll margin position. This prevents
6170 try_scrolling from unnecessarily failing when
6171 scroll-conservatively is set to a value slightly larger than the
6172 window height. Clean up the case of PT below the margin at bottom
6173 of window: scroll_max can no longer be INT_MAX. When aggressive
6174 scrolling is in use, don't let point enter the opposite scroll
6175 margin as result of the scroll.
6176 (syms_of_xdisp) <scroll-conservatively>: Document the
6177 threshold of 100 lines for never-recentering scrolling.
6179 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6181 * dispextern.h (move_it_by_lines):
6182 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6183 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6184 (message_log_check_duplicate): Remove parameters `prev_bol' and
6185 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6186 (redisplay_internal): Remove parameter `preserve_echo_area',
6187 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6189 * indent.c (Fvertical_motion):
6190 * window.c (window_scroll_pixel_based, Frecenter):
6191 Don't pass `need_y_p' to `move_it_by_lines'.
6193 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6195 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6196 steal a few bits to be more compact.
6197 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6198 Remove unneeded casts.
6200 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6202 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6204 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6205 binding" message (bug#7967).
6207 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6209 Fix more problems found by GCC 4.6.0's static checks.
6211 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6212 Remove unused local var.
6214 * editfns.c (Fmessage_box): Remove unused local var.
6216 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6217 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6218 Omit unused local vars.
6219 * window.c (shrink_windows): Omit unused local var.
6220 * menu.c (digest_single_submenu): Omit unused local var.
6221 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6222 Omit unused local var.
6224 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6225 Don't assume string length fits in int.
6226 (keyremap_step, read_key_sequence): Use size_t for sizes.
6227 (read_key_sequence): Don't check last_real_key_start redundantly.
6229 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6230 instead of alloca (Bug#8344).
6232 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6233 (Fbacktrace_frame): Don't assume nframes fits in int.
6235 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6237 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6240 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6242 * cm.c (calccost): Turn while-do into do-while, for clarity.
6244 * keyboard.c (syms_of_keyboard): Use the same style as later
6245 in this function when indexing through an array. This also
6246 works around GCC bug 48267.
6248 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6250 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6252 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6253 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6255 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6256 This avoids undefined behavior on integer overflow, and is a bit
6257 more convenient anyway since it is compared to a size_t variable.
6259 Variadic C functions now count arguments with size_t, not int.
6260 This avoids an unnecessary limitation on 64-bit machines, which
6261 caused (substring ...) to crash on large vectors (Bug#8344).
6262 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6263 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6264 All variadic functions and their callers changed accordingly.
6265 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6266 * data.c (arith_driver, float_arith_driver): Likewise.
6267 * editfns.c (general_insert_function): Likewise.
6268 * eval.c (struct backtrace.nargs, interactive_p)
6269 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6270 (funcall_lambda, mark_backtrace): Likewise.
6271 * fns.c (concat): Likewise.
6272 * frame.c (x_set_frame_parameters): Likewise.
6273 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6274 0 if not found, not -1. All callers changed.
6276 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6277 (stack_copy_size): Now size_t, not int.
6278 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6280 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6282 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6283 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6284 All callers changed.
6286 * lisp.h (multibyte_char_to_unibyte):
6287 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6288 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6289 * character.h (CHAR_TO_BYTE8):
6290 * cmds.c (internal_self_insert):
6291 * editfns.c (general_insert_function):
6292 * keymap.c (push_key_description):
6293 * search.c (Freplace_match):
6294 * xdisp.c (message_dolog, set_message_1): All callers changed.
6296 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6298 * keyboard.c (safe_run_hook_funcall): New function.
6299 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6300 don't set the hook to nil, but remove the offending function instead.
6301 (Qcommand_hook_internal): Remove, unused.
6302 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6303 Vcommand_hook_internal.
6305 * eval.c (enum run_hooks_condition): Remove.
6306 (funcall_nil, funcall_not): New functions.
6307 (run_hook_with_args): Call each function through a `funcall' argument.
6308 Remove `cond' argument, now redundant.
6309 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6310 (Frun_hook_with_args_until_failure): Adjust accordingly.
6311 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6313 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6315 * dispextern.h (string_buffer_position): Remove declaration.
6317 * print.c (strout): Remove parameter `multibyte', unused since
6318 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6320 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6321 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6322 All callers changed.
6324 * w32.c (_wsa_errlist): Use braces for struct initializers.
6326 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6327 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6328 All callers changed.
6329 (string_buffer_position): Likewise. Also, make static (it's never
6330 used outside xdisp.c).
6331 (cursor_row_p): Remove parameter `w', unused since
6332 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6333 (decode_mode_spec): Remove parameter `precision', introduced during
6334 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6335 All callers changed.
6337 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6339 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6341 2011-03-27 Anders Lindgren <andlind@gmail.com>
6343 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6344 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6345 (ns_update_auto_hide_menu_bar): New functions.
6346 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6347 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6348 ns_constrain_all_frames.
6349 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6350 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6352 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6354 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6356 2011-03-27 Glenn Morris <rgm@gnu.org>
6358 * syssignal.h: Replace RETSIGTYPE with void.
6359 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6360 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6361 Replace SIGTYPE with void everywhere.
6362 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6363 * s/template.h (SIGTYPE): Remove commented out definition.
6365 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6367 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6368 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6370 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6372 * w32.c (read_unc_volume): Use parameter `henum', instead of
6373 global variable `wget_enum_handle'.
6375 * keymap.c (describe_vector): Remove parameters `indices' and
6376 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6377 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6379 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6381 * keyboard.c (timer_check): Remove parameter `do_it_now',
6382 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6383 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6384 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6386 * keyboard.c (read_char):
6387 * w32menu.c (w32_menu_display_help):
6388 * xmenu.c (show_help_event, menu_help_callback):
6389 Adjust calls to `show_help_echo'.
6391 * gtkutil.c (xg_maybe_add_timer):
6392 * keyboard.c (readable_events):
6393 * process.c (wait_reading_process_output):
6394 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6396 * insdel.c (adjust_markers_gap_motion):
6397 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6398 (gap_left, gap_right): Don't call it.
6400 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6402 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6403 incurred during fontification.
6405 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6407 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6408 (DEFVAR_PER_BUFFER): Don't pass it.
6410 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6411 (scrolling_window): Don't pass it.
6413 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6415 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6417 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6419 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6420 of variables specific to SELinux and computation of `encoded_absname'.
6422 * image.c (XPutPixel): Remove unused variable `height'.
6424 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6426 * unexw32.c (get_section_info): Remove unused variable `section'.
6428 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6429 (system_process_attributes): Remove unused variable `sess'.
6430 (sys_read): Remove unused variable `err'.
6432 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6433 (w32_wnd_proc): Remove unused variable `isdead'.
6434 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6435 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6436 (x_create_tip_frame): Remove unused variable `tem'.
6438 * w32inevt.c (w32_console_read_socket):
6439 Remove unused variable `no_events'.
6441 * w32term.c (x_draw_composite_glyph_string_foreground):
6442 Remove unused variable `width'.
6444 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6446 * w32term.c (x_set_glyph_string_clipping):
6447 Don't pass uninitialized region to CombineRgn.
6449 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6451 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6452 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6453 (Fx_close_connection): Remove unused variable `i'.
6455 * w32font.c (w32font_draw): Return number of glyphs.
6456 (w32font_open_internal): Remove unused variable `i'.
6457 (w32font_driver): Add missing initializer.
6459 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6460 (fill_in_menu): Remove unused variable `items_added'.
6462 * w32term.c (last_mouse_press_frame): Remove static global variable.
6463 (w32_clip_to_row): Remove unused variable `f'.
6464 (x_delete_terminal): Remove unused variable `i'.
6466 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6467 (NOTHING): Remove unused static global variable.
6468 (uniscribe_check_otf): Remove unused variable `table'.
6469 (uniscribe_font_driver): Add missing initializers.
6471 2011-03-23 Julien Danjou <julien@danjou.info>
6473 * term.c (Fsuspend_tty, Fresume_tty):
6474 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6475 * window.c (temp_output_buffer_show):
6476 * insdel.c (signal_before_change):
6477 * frame.c (Fhandle_switch_frame):
6478 * fileio.c (Fdo_auto_save):
6479 * emacs.c (Fkill_emacs):
6480 * editfns.c (save_excursion_restore):
6481 * cmds.c (internal_self_insert):
6482 * callint.c (Fcall_interactively):
6483 * buffer.c (Fkill_all_local_variables):
6484 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6486 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6487 unconditionnaly since it does the check itself.
6489 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6491 Fix more problems found by GCC 4.5.2's static checks.
6493 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6494 the first time through the loop, since we know p0 < p1 then.
6495 This also avoids a gcc -Wstrict-overflow warning.
6497 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6498 leading to a memory leak, possible in functions like
6499 load_charset_map_from_file that can allocate an unbounded number
6500 of objects (Bug#8318).
6502 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6503 that could (at least in theory) be that large.
6505 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6506 This is less likely to overflow, and avoids undefined behavior if
6507 overflow does occur. All callers changed. Use strtoul to scan
6508 for the unsigned long integer.
6509 (pint2hrstr): Simplify and tune code slightly.
6510 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6512 * scroll.c (do_scrolling): Work around GCC bug 48228.
6513 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6515 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6516 This also avoids a warning with gcc -Wstrict-overflow.
6517 (validate_x_resource_name): Simplify count usage.
6518 This also avoids a warning with gcc -Wstrict-overflow.
6520 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6523 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6525 * process.c (Fmake_network_process): Use socklen_t, not int,
6526 where POSIX says socklen_t is required in portable programs.
6527 This fixes a porting bug on hosts like 64-bit HP-UX, where
6528 socklen_t is wider than int (Bug#8277).
6529 (Fmake_network_process, server_accept_connection):
6530 (wait_reading_process_output, read_process_output):
6533 * process.c: Rename or move locals to avoid shadowing.
6534 (list_processes_1, Fmake_network_process):
6535 (read_process_output_error_handler, exec_sentinel_error_handler):
6536 Rename or move locals.
6537 (Fmake_network_process): Define label "retry_connect" only if needed.
6538 (Fnetwork_interface_info): Fix pointer signedness.
6539 (process_send_signal): Add cast to avoid pointer signedness problem.
6540 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6541 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6543 Make tparam.h and terminfo.c consistent.
6544 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6545 Include tparam.h instead, since it declares them.
6546 * cm.h (PC): Remove extern decl; tparam.h now does this.
6547 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6548 * terminfo.c: Include tparam.h, to check interfaces.
6549 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6550 (tparam): Adjust signature to match interface in tparam.h;
6551 this removes some undefined behavior. Check that outstring and len
6552 are zero, which they always are with Emacs.
6553 * tparam.h (PC, BC, UP): New extern decls.
6555 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6556 (xftfont_open): Rename locals to avoid shadowing.
6558 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6559 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6560 (OTF_TAG_SYM): Omit macro if not needed.
6561 (ftfont_list): Remove unused local.
6562 (get_adstyle_property, ftfont_pattern_entity):
6563 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6564 Rename locals to avoid shadowing.
6566 * xfont.c (xfont_list_family): Mark var as initialized.
6568 * xml.c (make_dom): Now static.
6570 * composite.c (composition_compute_stop_pos): Rename local to
6572 (composition_reseat_it): Remove unused locals.
6573 (find_automatic_composition, composition_adjust_point): Likewise.
6574 (composition_update_it): Mark var as initialized.
6575 (find_automatic_composition): Mark vars as initialized,
6576 with a FIXME (Bug#8290).
6578 character.h: Rename locals to avoid shadowing.
6579 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6580 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6581 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6582 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6585 * textprop.c (property_change_between_p): Remove; unused.
6587 * intervals.c (interval_start_pos): Now static.
6589 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6591 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6592 Rename locals to avoid shadowing.
6594 * sound.c (wav_play, au_play, Fplay_sound_internal):
6595 Fix pointer signedness.
6596 (alsa_choose_format): Remove unused local var.
6597 (wav_play): Initialize a variable to 0, to prevent undefined
6598 behavior (Bug#8278).
6600 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6602 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6604 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6605 clobbering (Bug#8298).
6606 * sysdep.c (sys_subshell): Likewise.
6607 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6609 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6610 This should get cleaned up, so that child_setup has the
6611 same signature on all platforms.
6613 * callproc.c (call_process_cleanup): Now static.
6614 (relocate_fd): Rename locals to avoid shadowing.
6616 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6618 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6619 not to be necessary, and produces flickering.
6621 2011-03-20 Glenn Morris <rgm@gnu.org>
6623 * config.in: Remove file.
6625 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6627 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6628 are now in src/globals.h.
6629 (syms_of_minibuf): Remove spurious & from previous change.
6631 2011-03-20 Leo <sdl.web@gmail.com>
6633 * minibuf.c (completing-read-function): New variable.
6634 (completing-read-default): Rename from completing-read.
6635 (completing-read): Call completing-read-function.
6637 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6639 * xfaces.c (Fx_load_color_file):
6640 Read color file from absolute filename (bug#8250).
6642 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6644 * makefile.w32-in: Update dependencies.
6646 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6648 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6650 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6652 Fix more problems found by GCC 4.5.2's static checks.
6654 * process.c (make_serial_process_unwind, send_process_trap):
6655 (sigchld_handler): Now static.
6657 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6658 That way, the code declares only the vars that it needs.
6659 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6660 * s/cygwin.h (PTY_ITERATION): Likewise.
6661 * s/darwin.h (PTY_ITERATION): Likewise.
6662 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6664 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6665 * process.c (allocate_pty): Don't declare stb unless it's needed.
6667 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6668 (CONSTANTLIM): Remove; unused.
6669 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6670 Define only if needed.
6672 * unexelf.c (unexec): Name an expression,
6673 to avoid gcc -Wbad-function-cast warning.
6674 Use a different way to cause a compilation error if anyone uses
6675 n rather than nn, a way that does not involve shadowing.
6676 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6678 * deps.mk (unexalpha.o): Remove; unused.
6680 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6681 * unexec.h: New file.
6682 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6683 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6685 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6686 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6687 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6688 Change as necessary to match prototype in unexec.h.
6690 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6692 (back_comment, skip_chars): Mark vars as initialized.
6694 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6695 Rename locals to avoid shadowing.
6697 * lread.c (read1): Rewrite so as not to use empty "else".
6698 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6700 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6702 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6703 warning when compiling print.c.
6705 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6706 instead of using an uninitialized var.
6707 (font_sort_entities): Mark var as initialized.
6709 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6711 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6712 pointers to constants.
6713 (font_parse_fcname): Remove unused vars.
6714 (font_delete_unmatched): Now static.
6715 (font_get_spec): Remove; unused.
6716 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6717 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6718 Rename or move locals to avoid shadowing.
6720 * fns.c (require_nesting_list, require_unwind): Now static.
6721 (Ffillarray): Rename locals to avoid shadowing.
6723 * floatfns.c (domain_error2): Define only if needed.
6724 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6726 * alloc.c (mark_backtrace): Move decl from here ...
6727 * lisp.h: ... to here, so that it can be checked.
6729 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6730 (Fdefvar): Rewrite so as not to use empty "else".
6731 (lisp_indirect_variable): Name an expression,
6732 to avoid gcc -Wbad-function-cast warning.
6733 (Fdefvar): Rename locals to avoid shadowing.
6735 * callint.c (quotify_arg, quotify_args): Now static.
6736 (Fcall_interactively): Rename locals to avoid shadowing.
6737 Use const pointer when appropriate.
6739 * lisp.h (get_system_name, get_operating_system_release):
6740 Move decls here, to check interfaces.
6741 * process.c (get_operating_system_release): Move decl to lisp.h.
6742 * xrdb.c (get_system_name): Likewise.
6743 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6744 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6745 some of which prompt warnings from gcc -Wbad-function-cast.
6746 (Fformat_time_string, Fencode_time, Finsert_char):
6747 (Ftranslate_region_internal, Fformat):
6748 Rename or remove local vars to avoid shadowing.
6749 (Ftranslate_region_internal): Mark var as initialized.
6751 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6754 * lisp.h (eassert): Check that the argument compiles, even if
6755 ENABLE_CHECKING is not defined.
6757 * data.c (Findirect_variable): Name an expression, to avoid
6758 gcc -Wbad-function-cast warning.
6759 (default_value, arithcompare, arith_driver, arith_error): Now static.
6760 (store_symval_forwarding): Rename local to avoid shadowing.
6761 (Fmake_variable_buffer_local, Fmake_local_variable):
6762 Mark variables as initialized.
6763 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6765 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6766 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6767 Rename locals to avoid shadowing.
6768 (mark_stack): Move local variables into the #ifdef region where
6770 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6771 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6773 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6774 (GC_STRING_CHARS): Remove; not used.
6775 (Fmemory_limit): Cast sbrk's returned value to char *.
6777 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6778 avoids undefined behavior in theory.
6780 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6782 Use functions, not macros, for up- and down-casing (Bug#8254).
6783 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6784 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6785 to use the following functions instead of these macros.
6786 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6787 EMACS_INT, since callers assume the returned value fits in int.
6788 (upcase1): Likewise, for UPCASE_TABLE.
6789 (uppercasep, lowercasep, upcase): New static inline functions.
6790 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6791 the race-condition problem in the old DOWNCASE.
6793 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6794 Rename locals to avoid shadowing.
6795 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6796 (regex_compile, re_search_2, re_match_2_internal):
6797 Remove unused local vars.
6798 (FREE_VAR): Rewrite so as not to use empty "else",
6799 which gcc can warn about.
6800 (regex_compile, re_match_2_internal): Mark locals as initialized.
6801 (RETALLOC_IF): Define only if needed.
6802 (WORDCHAR_P): Likewise. This one is never needed, but is used
6803 only in a comment talking about a compiler bug, so put inside
6804 the #if 0 of that comment.
6805 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6806 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6809 * search.c (boyer_moore): Rename locals to avoid shadowing.
6810 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6811 (PREV_CHAR_BOUNDARY): Likewise.
6813 * search.c (simple_search): Remove unused var.
6815 * dired.c (compile_pattern): Move decl from here ...
6816 * lisp.h: ... to here, so that it can be checked.
6817 (struct re_registers): New forward decl.
6819 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6821 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6823 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6824 Rename locals to avoid shadowing.
6825 (Fvertical_motion): Mark locals as initialized.
6827 * casefiddle.c (casify_object, casify_region): Now static.
6828 (casify_region): Mark local as initialized.
6830 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6832 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6833 New macros, so that the caller can use some names other than
6834 gcpro1, gcpro2, etc.
6835 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6837 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6838 argument, for consistency with GCPRO2_VAR, etc: it is now the
6839 prefix of the variable, not the variable itself. All uses
6841 * dired.c (directory_files_internal, file_name_completion):
6842 Rename locals to avoid shadowing.
6844 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6845 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6846 dired.c's scmp function, had undefined behavior.
6847 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6848 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6849 * buffer.h: ... to here, because these macros use current_buffer,
6850 and the new implementation with inline functions needs to have
6851 current_buffer in scope now, rather than later when the macros
6853 (downcase, upcase1): New static inline functions.
6854 (DOWNCASE, UPCASE1): Reimplement using these functions.
6855 This avoids undefined behavior in expressions like
6856 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6857 from race conditions in accessing the global variables
6858 case_temp1 and case_temp2.
6859 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6860 * lisp.h (case_temp1, case_temp2): Remove their decls.
6861 * character.h (ASCII_CHAR_P): Move from here ...
6862 * lisp.h: ... to here, so that the inline functions mentioned
6865 * dired.c (directory_files_internal_unwind): Now static.
6867 * fileio.c (file_name_as_directory, directory_file_name):
6868 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6870 (file_name_as_directory): Use const pointers when appropriate.
6871 (Fexpand_file_name): Likewise. In particular, newdir might
6872 point at constant storage, so make it a const pointer.
6873 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6874 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6876 (Fset_file_times, Finsert_file_contents, auto_save_error):
6877 Rename locals to avoid shadowing.
6879 * minibuf.c (choose_minibuf_frame_1): Now static.
6880 (Ftry_completion, Fall_completions): Rename or remove locals
6883 * marker.c (bytepos_to_charpos): Remove; unused.
6885 * lisp.h (verify_bytepos, count_markers): New decls,
6886 so that gcc does not warn that these functions aren't declared.
6888 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6889 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6890 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6891 (copy_text): Remove unused local var.
6893 * filelock.c (within_one_second): Now static.
6894 (lock_file_1): Rename local to avoid shadowing.
6896 * buffer.c (fix_overlays_before): Mark locals as initialized.
6897 (fix_start_end_in_overlays): Likewise. This function should be
6898 simplified by using pointers-to-pointers, but that's a different
6900 (switch_to_buffer_1): Now static.
6901 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6902 (report_overlay_modification): Rename locals to avoid shadowing.
6904 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6905 Fix pointer signedness issue.
6906 (sys_subshell): Mark local as volatile if checking for lint,
6907 to suppress a gcc -Wclobbered warning that does not seem to be right.
6908 (MAXPATHLEN): Define only if needed.
6910 * process.c (serial_open, serial_configure): Move decls from here ...
6911 * systty.h: ... to here, so that they can be checked.
6913 * fns.c (get_random, seed_random): Move extern decls from here ...
6914 * lisp.h: ... to here, so that they can be checked.
6916 * sysdep.c (reset_io): Now static.
6917 (wait_for_termination_signal): Remove; unused.
6919 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6920 (copy_keymap_item, append_key, push_text_char_description):
6922 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6923 (DENSE_TABLE_SIZE): Remove; unused.
6924 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6925 (describe_map_tree):
6926 Rename locals to avoid shadowing.
6928 * keyboard.c: Declare functions static if they are not used elsewhere.
6929 (echo_char, echo_dash, cmd_error, top_level_2):
6930 (poll_for_input, handle_async_input): Now static.
6931 (read_char, kbd_buffer_get_event, make_lispy_position):
6932 (make_lispy_event, make_lispy_movement, apply_modifiers):
6933 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6934 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6935 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6936 (read_key_sequence, read_char): Mark locals as initialized.
6937 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6939 * keyboard.h (make_ctrl_char): New decl.
6940 (mark_kboards): Move decl here ...
6941 * alloc.c (mark_kboards): ... from here.
6943 * lisp.h (force_auto_save_soon): New decl.
6945 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6946 (DEFINE_DUMMY_FUNCTION): New macro.
6947 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6949 (main): Add casts to avoid warnings
6950 if GCC considers string literals to be constants.
6952 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6954 * dbusbind.c: Pointer signedness fixes.
6955 (xd_signature, xd_append_arg, xd_initialize):
6956 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6957 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6958 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6959 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6961 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6962 if GCC considers string literals to be constants.
6963 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6965 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6967 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6968 (print_preprocess, print_object): New macro to fix last change.
6970 * print.c (print_preprocess): Don't forget font objects.
6972 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6974 * emacs.c (USAGE3): Doc fixes.
6976 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6978 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6981 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6983 * lisp.h (VWindow_system, Qfile_name_history):
6984 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6985 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6986 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6988 * w32select.c: Don't #include "keyboard.h".
6989 (run_protected): Add extern declaration for waiting_for_input.
6991 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6992 * w32console.c (detect_input_pending, read_input_pending)
6993 (encode_terminal_code):
6994 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6995 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6996 (w32_system_caret_y, Qfile_name_history):
6997 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6998 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6999 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7000 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7001 * w32proc.c (Qlocal, report_file_error):
7002 * w32term.c (Vwindow_system, updating_frame):
7003 * w32uniscribe.c (initialized, uniscribe_font_driver):
7004 Remove unneeded extern declarations.
7006 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7008 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7010 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7012 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7013 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7014 These macros can no longer be used for assignment.
7016 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7017 Assign struct members directly, instead of using BUF_BEGV etc.
7018 (record_buffer_markers, fetch_buffer_markers): New functions for
7019 recording and fetching special buffer markers.
7020 (set_buffer_internal_1, set_buffer_temp): Use them.
7022 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7024 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7026 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7027 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7029 * xdisp.c (hscroll_window_tree):
7030 (reconsider_clip_changes): Use PT instead of BUF_PT.
7032 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7034 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7035 $(EMACS_ROOT)/lib/intprops.h.
7037 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7039 Fix more problems found by GCC 4.5.2's static checks.
7041 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7042 to unsigned char * to avoid compiler diagnostic.
7043 (xg_free_frame_widgets): Make it clear that a local variable is
7044 needed only if USE_GTK_TOOLTIP.
7045 (gdk_window_get_screen): Make it clear that this macro is needed
7046 only if USE_GTK_TOOLTIP.
7047 (int_gtk_range_get_value): New function, which avoids a diagnostic
7048 from gcc -Wbad-function-cast.
7049 (xg_set_toolkit_scroll_bar_thumb): Use it.
7050 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7051 diagnostic from gcc -Wbad-function-cast.
7052 (get_utf8_string, xg_get_file_with_chooser):
7053 Rename locals to avoid shadowing.
7054 (create_dialog): Move locals to avoid shadowing.
7056 * xgselect.c (xg_select): Remove unused var.
7058 * image.c (four_corners_best): Mark locals as initialized.
7059 (gif_load): Initialize transparent_p to zero (Bug#8238).
7060 Mark another local as initialized.
7061 (my_png_error, my_error_exit): Mark with NO_RETURN.
7063 * image.c (clear_image_cache): Now static.
7064 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7065 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7066 (x_edge_detection): Remove unnecessary cast that
7067 gcc -Wbad-function-cast diagnoses.
7068 (gif_load): Fix pointer signedness.
7069 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7070 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7072 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7074 Improve quality of tests for time stamp overflow.
7075 For example, without this patch (encode-time 0 0 0 1 1
7076 1152921504606846976) returns the obviously-bogus value (-948597
7077 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7078 reports time overflow. See
7079 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7080 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7081 * editfns.c: Include limits.h and intprops.h.
7082 (TIME_T_MIN, TIME_T_MAX): New macros.
7083 (time_overflow): Move earlier, to before first use.
7084 (hi_time, lo_time): New functions, for an accurate test for
7086 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7087 (Fget_internal_run_time): Don't assume time_t fits in int.
7088 (make_time): Use list2 instead of Fcons twice.
7089 (Fdecode_time): More accurate test for out-of-range times.
7090 (check_tm_member): New function.
7091 (Fencode_time): Use it, to test for out-of-range times.
7092 (lisp_time_argument): Don't rely on undefined left-shift and
7093 right-shift behavior when checking for time stamp overflow.
7095 * editfns.c (time_overflow): New function, refactoring common code.
7096 (Fformat_time_string, Fdecode_time, Fencode_time):
7097 (Fcurrent_time_string): Use it.
7099 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7100 * dired.c (make_time): Move to ...
7101 * editfns.c (make_time): ... here.
7102 * systime.h: Note the move.
7104 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7106 * fringe.c (update_window_fringes): Remove unused variables.
7108 * unexmacosx.c (copy_data_segment): Also copy __got section.
7111 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7113 * termcap.c [MSDOS]: Include "msdos.h".
7114 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7115 Constify `char *' arguments and their references according to
7116 prototypes in tparam.h.
7118 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7120 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7121 Adapt all references accordingly.
7123 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7125 2011-03-11 Tom Tromey <tromey@redhat.com>
7127 * buffer.c (syms_of_buffer): Remove obsolete comment.
7129 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7131 * termhooks.h (encode_terminal_code): Declare prototype.
7133 * msdos.c (encode_terminal_code): Don't declare prototype.
7135 * term.c (encode_terminal_code): Now external again, used by
7136 w32console.c and msdos.c.
7138 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7139 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7141 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7143 Fix some minor problems found by GCC 4.5.2's static checks.
7145 * fringe.c (update_window_fringes): Mark locals as initialized
7147 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7149 * alloc.c (mark_fringe_data): Move decl from here ...
7150 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7151 to check its interface.
7152 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7154 * fontset.c (free_realized_fontset): Now static.
7155 (Fset_fontset_font): Rename local to avoid shadowing.
7156 (fontset_font): Mark local as initialized.
7157 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7159 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7161 * xselect.c (x_disown_buffer_selections): Remove; not used.
7162 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7163 (x_own_selection, Fx_disown_selection_internal): Rename locals
7165 (x_handle_dnd_message): Remove local to avoid shadowing.
7167 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7168 so that the caller can use some name other than gcpro1.
7169 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7170 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7171 (Fx_backspace_delete_keys_p):
7172 Use them to avoid shadowing, and rename vars to avoid shadowing.
7173 (x_decode_color, x_set_name, x_window): Now static.
7174 (Fx_create_frame): Add braces to silence GCC warning.
7175 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7176 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7177 Remove unused locals.
7178 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7179 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7180 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7183 * xterm.h (x_mouse_leave): New decl.
7185 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7186 Remove unused functions.
7187 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7188 (x_calc_absolute_position): Now static.
7189 (XTread_socket): Don't define label "out" unless it's used.
7190 Don't declare local "event" unless it's used.
7191 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7192 unless they are used.
7193 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7194 (x_fatal_error_signal): Remove; not used.
7195 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7196 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7197 (x_error_catcher, x_connection_closed, x_error_handler):
7198 (x_error_quitter, xembed_send_message, x_iconify_frame):
7199 (my_log_handler): Rename locals to avoid shadowing.
7200 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7201 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7203 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7204 Rename or move locals to avoid shadowing.
7205 (tty_defined_color, merge_face_heights): Now static.
7206 (free_realized_faces_for_fontset): Remove; not used.
7207 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7208 does not deduce is never used uninitialized.
7209 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7210 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7212 * terminal.c (store_terminal_param): Now static.
7214 * xmenu.c (menu_highlight_callback): Now static.
7215 (set_frame_menubar): Remove unused local.
7216 (xmenu_show): Rename parameter to avoid shadowing.
7217 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7218 since they might point to immutable storage.
7219 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7220 since it's unused otherwise.
7222 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7223 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7224 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7225 avoids a gcc -Wuninitialized diagnostic.
7226 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7227 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7228 does not deduce are never used uninitialized.
7230 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7232 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7233 * window.c (window_loop, size_window):
7234 (run_window_configuration_change_hook, enlarge_window): Likewise.
7236 * window.c (display_buffer): Now static.
7237 (size_window): Mark variables that gcc -Wuninitialized
7238 does not deduce are never used uninitialized.
7239 * window.h (check_all_windows): New decl, to forestall
7240 gcc -Wmissing-prototypes diagnostic.
7241 * dispextern.h (bidi_dump_cached_states): Likewise.
7243 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7245 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7247 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7248 and to avoid gcc -Wuninitialized warning.
7249 (load_charset_map): Mark variables that gcc -Wuninitialized
7250 does not deduce are never used uninitialized.
7251 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7253 * coding.c (coding_set_source, coding_set_destination):
7254 Use "else { /* comment */ }" rather than "else /* comment */;"
7255 for clarity, and to avoid gcc -Wempty-body warning.
7256 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7257 a block, when the outer 'i' will do.
7258 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7259 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7260 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7261 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7262 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7263 Rename locals to avoid shadowing.
7264 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7265 * coding.c (emacs_mule_char, encode_invocation_designation):
7266 Now static, since they're not used elsewhere.
7267 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7268 (decode_coding_object, encode_coding_object, detect_coding_system):
7269 (decode_coding_emacs_mule): Mark variables that gcc
7270 -Wuninitialized does not deduce are never used uninitialized.
7271 (detect_coding_iso_2022): Initialize a local variable that might
7272 be used uninitialized. Leave a FIXME because it's not clear that
7273 this initialization is needed. (Bug#8211)
7274 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7275 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7276 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7277 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7278 Remove unused macros.
7280 * category.c (hash_get_category_set): Remove unused local var.
7281 (copy_category_table): Now static, since it's not used elsewhere.
7282 * character.c (string_count_byte8): Likewise.
7284 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7285 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7287 * chartab.c (copy_sub_char_table): Now static, since it's not used
7289 (sub_char_table_ref_and_range, char_table_ref_and_range):
7290 Rename locals to avoid shadowing.
7291 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7293 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7294 (BIDI_BOB): Remove unused macro.
7296 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7297 deduce are never used uninitialized.
7298 * term.c (encode_terminal_code): Likewise.
7300 * term.c (encode_terminal_code): Now static. Remove unused local.
7302 * tparam.h: New file.
7303 * term.c, tparam.h: Include it.
7304 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7305 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7306 Move these decls to tparam.h, and make them agree with what
7307 is actually in tparam.c. The previous trick of using incompatible
7308 decls in different modules does not conform to the C standard.
7309 All callers of tparam changed to use tparam's actual API.
7310 * tparam.c (tparam1, tparam, tgoto):
7311 Use const pointers where appropriate.
7313 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7314 * cm.h (struct cm): Likewise.
7315 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7316 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7317 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7318 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7319 (turn_on_face, init_tty): Likewise.
7320 * termchar.h (struct tty_display_info): Likewise.
7322 * term.c (term_mouse_position): Rename local to avoid shadowing.
7324 * alloc.c (mark_ttys): Move decl from here ...
7325 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7327 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7329 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7331 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7333 * search.c (compile_pattern_1): Remove argument regp, unused since
7334 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7335 (compile_pattern): Don't pass it.
7337 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7339 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7340 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7342 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7344 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7346 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7347 gdk_window_get_screen, gdk_window_get_geometry,
7348 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7349 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7350 (xg_get_pixbuf_from_pixmap): New function.
7351 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7352 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7353 Call xg_get_pixbuf_from_pixmap instead of
7354 gdk_pixbuf_get_from_drawable.
7355 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7356 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7357 (xg_check_special_colors): Use GtkStyleContext and its functions
7359 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7360 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7361 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7362 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7363 Call gtk_widget_get_preferred_size.
7364 (xg_frame_resized): gdk_window_get_geometry only takes 5
7366 (xg_win_to_widget, xg_event_is_for_menubar):
7367 Call gdk_x11_window_lookup_for_display.
7368 (xg_set_widget_bg): New function.
7369 (delete_cb): New function.
7370 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7371 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7372 (xg_set_background_color): Call xg_set_widget_bg.
7373 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7374 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7375 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7376 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7378 (update_frame_tool_bar): Call gtk_widget_hide.
7379 (xg_initialize): Use GDK_KEY_g.
7381 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7383 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7385 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7386 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7387 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7389 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7391 * w32xfns.c (select_palette): Check success of RealizePalette against
7392 GDI_ERROR, not zero.
7394 See ChangeLog.11 for earlier changes.
7400 Copyright (C) 2011 Free Software Foundation, Inc.
7402 This file is part of GNU Emacs.
7404 GNU Emacs is free software: you can redistribute it and/or modify
7405 it under the terms of the GNU General Public License as published by
7406 the Free Software Foundation, either version 3 of the License, or
7407 (at your option) any later version.
7409 GNU Emacs is distributed in the hope that it will be useful,
7410 but WITHOUT ANY WARRANTY; without even the implied warranty of
7411 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7412 GNU General Public License for more details.
7414 You should have received a copy of the GNU General Public License
7415 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.