1 2012-07-03 Glenn Morris <rgm@gnu.org>
3 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
4 and did not make it into globals.h).
6 2012-07-03 Tom Tromey <tromey@redhat.com>
8 * window.c (Fset_window_margins, Fset_window_fringes)
9 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
10 * textprop.c (Fprevious_property_change): No longer static.
11 * syntax.c (Fsyntax_table_p): No longer static.
12 * process.c (Fget_process, Fprocess_datagram_address): No longer
14 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
15 * keyboard.c (Fcommand_execute): No longer static.
17 * insdel.c (Fcombine_after_change_execute): No longer static.
18 * image.c (Finit_image_library): No longer static.
19 * fileio.c (Fmake_symbolic_link): No longer static.
20 * eval.c (Ffetch_bytecode): No longer static.
21 * editfns.c (Fuser_full_name): No longer static.
22 * doc.c: (Fdocumentation_property, Fsnarf_documentation): No
24 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
26 * dired.c (Ffile_attributes): No longer static.
27 * composite.c (Fcomposition_get_gstring): No longer static.
28 * callproc.c (Fgetenv_internal): No longer static.
30 * ccl.h: Remove EXFUNs.
31 * buffer.h: Remove EXFUNs.
32 * dispextern.h: Remove EXFUNs.
33 * intervals.h: Remove EXFUNs.
34 * fontset.h: Remove EXFUN.
35 * font.h: Remove EXFUNs.
36 * dosfns.c (system_process_attributes): Remove EXFUN.
37 * keymap.h: Remove EXFUNs.
38 * lisp.h: Remove EXFUNs.
39 * w32term.h: Remove EXFUNs.
40 * window.h: Remove EXFUNs.
41 * xsettings.h: Remove EXFUN.
42 * xterm.h: Remove EXFUN.
44 2012-07-03 Glenn Morris <rgm@gnu.org>
46 * lisp.h (Frandom): Make it visible to C.
47 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
48 buffer for invisible buffers. (Bug#1229)
50 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
52 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
53 values which aren't power of 2.
54 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
55 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
58 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
60 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
62 * alloc.c (mark_object): Revert part of last patch to use `switch'.
64 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
66 * alloc.c (allocate_vector_block): Remove redundant
67 calls to mallopt if DOUG_LEA_MALLOC is defined.
68 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
69 avoid calls to mallopt if zero_vector is returned.
71 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
73 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
74 is enabled, avoid dereferencing NULL current_sblock if
77 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
79 Cleanup basic buffer management.
80 * buffer.h (struct buffer): Change layout to use generic vector
81 marking code. Fix some comments. Change type of 'clip_changed'
82 to bitfield. Remove unused #ifndef old.
83 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
84 (GET_OVERLAYS_AT): Fix indentation.
85 (for_each_per_buffer_object_at): New macro.
86 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
87 (Fbuffer_local_variables): Use it.
88 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
89 * alloc.c (allocate_buffer): Adjust to match new layout of
90 struct buffer. Fix comment.
91 (mark_overlay): New function.
92 (mark_buffer): Use it. Use mark_vectorlike to mark normal
93 Lisp area of struct buffer.
94 (mark_object): Use it. Adjust marking of misc objects
97 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
99 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
100 wrapper that is not needed because the wrapped code is a no-op (zero
101 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
102 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
104 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
106 * alloc.c (mark_buffer): Simplify. Remove prototype.
107 (mark_object): Add comment. Reorganize marking of vector-like
108 objects. Use CHECK_LIVE for all vector-like objects except buffers
109 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
110 redundant calls to mark_vectorlike for bool vectors.
112 2012-06-30 Glenn Morris <rgm@gnu.org>
114 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
116 * epaths.in (PATH_SITELOADSEARCH): New.
117 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
118 This is rather than relying on --enable-locallisppath elements
119 having "site-lisp" in their names. (Bug#10208#25, 11658)
121 2012-06-30 Eli Zaretskii <eliz@gnu.org>
123 * w32proc.c (sys_select): Accept and ignore one more argument.
125 * w32.c (emacs_gnutls_pull): Call select with one more argument.
127 * sysselect.h [DOS_NT]: Don't include sys/select.h.
128 (pselect) [!MS_DOS]: Redirect to sys_select.
130 * sysdep.c: Don't include dos.h and dosfns.h.
132 * process.c (sys_select):
133 * msdos.c (sys_select): Accept one more argument and ignore it.
135 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
136 adapt data types and code to that.
139 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
140 which clashes with the gnulib function of the same name.
142 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
144 * font.c (font_style_to_value, font_style_symbolic)
145 (font_prop_validate_style): Add type checks for values in
148 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
150 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
153 2012-06-29 Eli Zaretskii <eliz@gnu.org>
155 * xdisp.c (try_window_id): Undo last change.
157 * w32.c (getwd): Adjust commentary about startup_dir.
158 (init_environment): Always call sys_access, even in non-MSVC
159 builds. Don't chdir to the directory of the Emacs executable.
160 This undoes code from 1997 which was justified by the need to
161 "avoid conflicts when removing and renaming directories". But its
162 downside was that every relative file name was being interpreted
163 relative to the directory of the Emacs executable, which can never
164 be TRT. In particular, it broke sys_access when called with
166 (sys_access): Map GetLastError to errno.
168 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
170 * window.h (struct window): Change type of 'fringes_outside_margins'
171 to bitfield. Fix comment. Adjust users accordingly.
172 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
174 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
177 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
179 * gnutls.c (emacs_gnutls_handshake):
180 Add QUIT to make the loop interruptible.
182 2012-06-29 Glenn Morris <rgm@gnu.org>
184 * charset.c (init_charset): Make lack of etc/charsets fatal.
186 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
188 * editfns.c (region_limit): Fix type mismatch.
190 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
192 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
193 undefined. Convert from xassert to eassert.
194 * nsmenu.m: Convert from xassert to eassert.
195 * nsterm.m: Likewise.
197 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
199 * editfns.c (region_limit): Clip to narrowing (bug#11770).
201 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
203 Avoid integer overflow on scroll-left and scroll-right.
204 * window.c (HSCROLL_MAX): New macro.
205 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
206 overflow when requested scroll falls outside ptrdiff_t range.
208 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
210 * window.h (struct window): Change type of 'hscroll',
211 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
212 'last_modified' and 'last_overlay_modified' to EMACS_INT.
213 Adjust users accordingly.
214 * xdisp.c (try_cursor_movement): Replace type check with eassert.
215 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
216 from EMACS_INT to ptrdiff_t.
217 (make_window): Omit redundant initialization.
219 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
221 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
223 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
225 * window.h (struct window): Change type of 'use_time' and
226 'sequence_number' from Lisp_Object to int.
227 * frame.c (make_frame): Adjust users accordingly.
228 * print.c (print_object): Likewise.
229 * window.c (select_window, Fwindow_use_time, make_parent_window)
230 (make_window): Likewise.
232 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
234 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
235 enabled with --enable-checking=[all,glyphs] configure option.
236 Fix GLYPH_DEBUG usage assuming that it may be undefined,
237 adjust comments accordingly.
238 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
239 undefined, adjust comments accordingly.
241 * scroll.c: Likewise.
242 * w32fns.c: Likewise.
243 * w32term.c: Likewise.
245 * xfaces.c: Likewise.
249 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
251 Generalize run-time debugging checks.
252 * dispextern.h (XASSERTS): Remove.
253 * fontset.c (xassert): Remove.
254 Convert from xassert to eassert.
255 * alloc.c: Convert from xassert to eassert.
257 * dispnew.c: Likewise.
259 * fringe.c: Likewise.
260 * ftfont.c: Likewise.
261 * gtkutil.c: Likewise.
263 * keyboard.c: Likewise.
265 * process.c: Likewise.
266 * scroll.c: Likewise.
269 * w32console.c: Likewise.
270 * w32fns.c: Likewise.
271 * w32term.c: Likewise.
272 * window.c: Likewise.
274 * xfaces.c: Likewise.
276 * xselect.c: Likewise.
279 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
281 * fns.c (maybe_resize_hash_table): Output message when growing the
284 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
286 * alloc.c (allocate_string_data): Remove dead code.
287 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
288 avoid GCC warning about unused macro.
290 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
292 * alloc.c (allocate_string): Omit intervals initialization.
293 * alloc.c (make_uninit_multibyte_string): Initialize intervals
294 as in make_pure_string and make_pure_c_string.
296 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
298 * alloc.c (allocate_string): Fix last change.
300 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
302 * alloc.c (allocate_string): Remove two redundant calls
303 to memset, add explicit initialization where appropriate.
305 2012-06-27 Glenn Morris <rgm@gnu.org>
307 * lisp.mk (lisp): Remove paths.elc.
309 2012-06-27 Chong Yidong <cyd@gnu.org>
311 * doc.c (Fsubstitute_command_keys): Fix punctuation.
313 2012-06-26 John Wiegley <johnw@newartisans.com>
315 * unexmacosx.c (copy_data_segment): Add two section names used
316 on Mac OS X Lion: __mod_init_func and __mod_term_func.
318 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
319 when building with Clang.
321 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
323 * eval.c (Fapply): Allow calling it with a single argument.
325 2012-06-26 Eli Zaretskii <eliz@gnu.org>
327 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
328 _stricmp and _strnicmp.
329 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
331 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
333 * alloc.c (allocate_window): Zero out non-Lisp part of newly
335 (allocate_process): Likewise for new process.
336 (allocate_terminal): Change to use offsetof.
337 (allocate_frame): Likewise.
338 * frame.c (make_frame): Omit redundant initialization.
339 * window.c (make_parent_window): Use memset.
340 (make_window): Omit redundant initialization.
341 * process.c (make_process): Omit redundant initialization.
342 * terminal.c (create_terminal): Likewise.
344 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
346 * term.c (delete_tty): Remove redundant call to memset.
348 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
350 * alloc.c: Remove build_string.
351 * lisp.h: Define build_string as static inline. This provides
352 a better opportunity to optimize away calls to strlen when the
353 function is called with compile-time constant argument.
354 * image.c (imagemagick_error): Convert to build_string.
355 * w32proc.c (sys_spawnve): Likewise.
356 * xterm.c (x_term_init): Likewise.
358 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
360 Use sprintf return value instead of invoking strlen on result.
361 In the old days this wasn't portable, since some sprintf
362 implementations returned char *. But they died out years ago and
363 Emacs already assumes sprintf returns int.
364 Similarly for float_to_string.
365 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
366 * ccl.c (ccl_driver):
367 * character.c (string_escape_byte8):
368 * data.c (Fnumber_to_string):
370 * print.c (print_object):
371 * xdisp.c (message_dolog):
372 * xfns.c (syms_of_xfns):
373 Use sprintf or float_to_string result to avoid need to call strlen.
374 * data.c (Fnumber_to_string):
375 Use make_unibyte_string, since the string must be ASCII.
376 * lisp.h, print.c (float_to_string): Now returns int length.
377 * term.c (produce_glyphless_glyph):
378 Use sprintf result rather than recomputing it.
380 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
381 * Makefile.in (ALL_CFLAGS):
382 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
383 * gmalloc.c, regex.c: Include <config.h> unconditionally.
385 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
387 * dispextern.h (xstrcasecmp): Define to library function
388 strcasecmp if available.
389 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
391 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
393 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
394 Avoid comma operator.
395 * menu.c (push_submenu_start, push_submenu_end)
396 (push_left_right_boundary, push_menu_pane): Likewise.
397 * msdos.c (dos_rawgetc): Likewise.
399 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
401 * xfns.c (xic_create_fontsetname): Remove redundant calls
404 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
406 * gtkutil.c (get_utf8_string): Remove redundant assignment.
407 sprintf already null-terminates its output.
409 * xfns.c (x_window): Remove redundant cast.
411 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
413 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
414 `const char *' to `char *' to avoid compiler warning.
416 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
418 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
419 instead of truncating it to 63 (admittedly a generous limit).
421 * process.c: Fix spelling and caps in comments.
423 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
425 * emacs.c (setpgrp): Remove definition, unused.
426 * sysdep.c (setpgrp): Remove definition, not used in this file.
428 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
430 * makefile.w32-in: Update dependencies.
432 2012-06-24 Eli Zaretskii <eliz@gnu.org>
434 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
435 (SYSTIME_H): Add nt/inc/sys/time.h.
437 * systime.h [WINDOWSNT]: Include sys/time.h.
439 * s/ms-w32.h (struct timespec): Definition moved from
440 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
442 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
444 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
445 * buffer.h (buffer_slot_type_mismatch):
446 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
447 * eval.c (unwind_to_catch):
448 * image.c (my_png_error, my_error_exit):
449 * keyboard.c (quit_throw_to_read_char, user_error)
450 (Fexit_recursive_edit, Fabort_recursive_edit):
451 * lisp.h (die, args_out_of_range, args_out_of_range_3)
452 (wrong_type_argument, buffer_overflow, __executable_start)
453 (memory_full, buffer_memory_full, string_overflow, Fthrow)
454 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
455 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
457 (child_setup) [!DOS_NT]:
458 * lread.c (end_of_file_error, invalid_syntax):
459 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
460 * puresize.h (pure_write_error):
461 * search.c (matcher_overflow):
462 * sound.c (sound_perror, alsa_sound_perror):
463 * sysdep.c, syssignal.h (croak):
464 * term.c (maybe_fatal, vfatal):
465 * textprop.c (text_read_only):
466 * undo.c (user_error):
467 * unexmacosx.c (unexec_error):
468 * xterm.c (x_ins_del_lines, x_delete_glyphs):
469 Use _Noreturn rather than NO_RETURN.
470 No need for separate decl merely because of _Noreturn.
471 * sound.c (sound_warning, parse_sound):
472 Remove unnecessary forward decls.
474 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
476 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
477 * lisp.h (WAIT_READING_MAX): New macro.
478 * dispnew.c (Fsleep_for, sit_for):
479 * keyboard.c (kbd_buffer_get_event):
480 * process.c (Faccept_process_output):
481 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
482 This improves on the previous patch, which introduced a bug
483 when time_t is unsigned and as wide as intmax_t.
484 See <http://bugs.gnu.org/9000#51>.
486 2012-06-23 Eli Zaretskii <eliz@gnu.org>
488 * dispnew.c (sit_for, Fsleep_for):
489 * keyboard.c (kbd_buffer_get_event):
490 * process.c (Faccept_process_output): Avoid compiler warnings when
491 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
493 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
495 * makefile.w32-in: Update dependencies.
497 * w32.c (ltime): Add return type and declare static.
498 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
500 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
502 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
503 Privately reported by Herbert J. Skuhra.
504 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
506 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
507 not make_lisp_timeval, when the argument is of type EMACS_TIME.
509 2012-06-23 Eli Zaretskii <eliz@gnu.org>
511 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
512 last argument of make_unibyte_string.
514 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
515 language ID in the event parameters.
517 * w32term.c (w32_read_socket): Put the new keyboard codepage into
518 event.code, not the obscure "character set ID".
520 2012-06-23 Chong Yidong <cyd@gnu.org>
522 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
524 2012-06-23 Eli Zaretskii <eliz@gnu.org>
526 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
527 * w32.c (fdutimens): New function.
529 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
531 * s/ms-w32.h (pselect): Redirect to sys_select.
533 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
535 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
536 in the logic of incrementing and decrementing the value of
537 use_relocatable_buffers.
539 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
541 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
542 Privately reported by Herbert J. Skuhra.
543 [__FreeBSD__]: Remove "*/" typo after "#include".
544 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
545 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
546 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
547 Don't assume EMACS_TIME and struct timeval are the same type.
549 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
551 Support higher-resolution time stamps (Bug#9000).
552 The time stamps are only nanosecond-resolution at the C level,
553 since that's the best that any real-world system supports now.
554 But they are picosecond-resolution at the Lisp level, as that's
555 easy, and leaves room for future OS improvements.
557 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
560 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
561 Don't get current time unless it's needed.
563 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
564 now provides it if it's absent.
565 (start_atimer): Port to higher-res time stamps.
566 Check for time stamp overflow. Don't get current time more
567 often than is needed.
569 * buffer.h (struct buffer): Buffer modtime now has high resolution.
570 Include systime.h, not time.h.
571 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
573 * dired.c: Include stat-time.h.
574 (Ffile-attributes): File times now have higher resolution.
576 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
577 (struct image): Timestamp now has higher resolution.
579 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
580 has at least microseconds now. All uses removed.
581 (update_frame, update_single_window, update_window, update_frame_1)
582 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
584 * editfns.c (time_overflow): Now extern.
585 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
586 (float-time, Fformat_time_string, Fcurrent_time_string)
587 (Fcurrent_time_zone): Accept and generate higher-resolution
589 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
590 (decode_time_components, lisp_seconds_argument): New functions.
591 (make_time): Now static.
592 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
593 Report an error if the time is invalid, rather than having the caller
596 * fileio.c: Include <stat-time.h>
597 (Fcopy_file): Copy higher-resolution time stamps.
598 Prefer to set the time stamp via a file descriptor if that works.
599 (Fset_file_times, Finsert_file_contents, Fwrite_region)
600 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
601 (Fvisited_file_modtime, Fset_visited_file_modtime):
602 Support higher-resolution time stamps.
604 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
606 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
608 * image.c (prepare_image_for_display, clear_image_cache)
609 (lookup_image): Port to higer-resolution time stamps.
611 * keyboard.c (start_polling, bind_polling_period):
612 Check for time stamp overflow.
613 (read_char, kbd_buffer_get_event, timer_start_idle)
614 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
615 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
616 Port to higher-resolution time stamps. Do not assume time_t is signed.
617 (decode_timer): New function. Timers are now vectors of length 9,
618 not 8, to accommodate the picosecond component.
619 (timer_check_2): Use it.
621 * nsterm.m (select_timeout, timeval_subtract): Remove.
622 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
623 as they're a bit more accurate and handle overflow better.
624 (ns_select): Change prototype to be compatible with pselect.
625 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
626 * nsterm.h (ns_select): Adjust prototype.
628 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
629 us-resolution time stamps.
630 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
632 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
634 * lisp.h (time_overflow): New decl.
635 (wait_reading_process_output): First arg is now intmax_t, not int,
636 to accommodate larger waits.
638 * process.h (struct Lisp_Process.read_output_delay):
639 Now counts nanoseconds, not microseconds.
640 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
642 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
643 (wait_reading_process_output):
644 Port to ns-resolution time stamps.
645 (Faccept_process_output, wait_reading_process_output):
646 Check for time stamp overflow. Do not assume time_t is signed.
647 (select_wrapper): Remove; we now use pselect.
648 (Fprocess_attributes): Now generates ns-resolution time stamps.
650 * sysdep.c: Include utimens.h. Don't include utime.h
651 or worry about struct utimbuf; gnulib does that for us now.
652 (gettimeofday): Remove; gnulib provides a substitute.
653 (make_timeval): New function.
654 (set_file_times): Now sets ns-resolution time stamps.
655 New arg FD; all uses changed.
656 (time_from_jiffies, ltime_from_jiffies, get_up_time)
657 (system_process_attributes):
658 Now returns ns-resolution time stamp. All uses changed.
659 Check for time stamp overflow.
661 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
662 provides a substitute now.
664 * systime.h: Include timespec.h rather than sys/time.h and time.h,
665 since it guarantees struct timespec.
666 (EMACS_TIME): Now struct timespec, so that we can support
667 ns-resolution time stamps.
668 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
669 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
670 (EMACS_USECS): Remove.
671 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
672 so multiply the arg by 1000 before storing it.
673 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
675 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
676 Port to ns-resolution time stamps.
677 (EMACS_TIME_NEG_P): Remove; replaced by....
678 (EMACS_TIME_SIGN): New macro.
679 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
680 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
681 (set_file_times, make_time, lisp_time_argument): Adjust signature.
682 (make_timeval, make_lisp_time, decode_time_components): New decls.
683 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
684 that it mishandled time_t overflow. You can't compare by subtracting!
685 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
686 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
688 * term.c: Include <sys/time.h>.
689 (timeval_to_Time): New function, for proper overflow wraparound.
690 (term_mouse_position, term_mouse_click): Use it.
692 * undo.c (record_first_change): Support higher-resolution time stamps
694 (Fprimitive_undo): Use them when restoring time stamps.
696 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
697 (w32_get_internal_run_time):
698 Port to higher-resolution Emacs time stamps.
699 (ltime): Now accepts single 64-bit integer, as that's more convenient
702 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
704 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
705 for compatibility with pselect. Support ns-resolution time stamps.
707 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
709 * xselect.c (wait_for_property_change, x_get_foreign_selection):
710 Check for time stamp overflow, and support ns-resolution time stamps.
712 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
713 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
714 (timeval_subtract): Remove; no longer needed.
715 (XTflash, XTring_bell, x_wait_for_event):
716 Port to ns-resolution time stamps. Don't assume time_t is signed.
718 2012-06-22 Chong Yidong <cyd@gnu.org>
720 * xdisp.c (x_consider_frame_title): Revert last change.
722 2012-06-22 Eli Zaretskii <eliz@gnu.org>
724 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
725 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
726 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
727 staticidx goes up to 1597 out of 1600 = 0x640.)
729 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
731 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
732 Otherwise, the umask might be mistakenly 0 while handling input signals.
734 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
736 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
738 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
740 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
741 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
742 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
743 access to `contents' member of Lisp_Vector objects with AREF and ASET
746 2012-06-19 Chong Yidong <cyd@gnu.org>
748 * frame.c (delete_frame): When selecting a frame on a different
749 text terminal, do not alter the terminal's top-frame.
751 * xdisp.c (format_mode_line_unwind_data): Record the target
752 frame's selected window and its terminal's top-frame.
753 (unwind_format_mode_line): Restore them.
754 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
756 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
757 since tty frames can be explicitly named.
758 (prepare_menu_bars): Likewise.
760 * term.c (Ftty_top_frame): New function.
762 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
764 Port byte-code-meter to modern targets.
765 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
766 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
767 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
768 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
769 (METER_1, METER_2): Simplify.
771 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
773 * data.c (Fdefalias): Return `symbol' (bug#11686).
775 2012-06-18 Martin Rudalics <rudalics@gmx.at>
777 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
778 gets killed during executing of this function (Bug#11665).
779 Try to always return Qt when the buffer has been actually killed.
780 (Vkill_buffer_query_functions): In doc-string say that functions
781 run by this hook should not change the current buffer.
783 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
785 Fix recently-introduced process.c problems found by static checking.
786 * process.c (write_queue_push, write_queue_pop, send_process):
787 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
788 (write_queue_pop): Fix pointer signedness problem.
789 (send_process): Remove unused local.
791 2012-06-17 Chong Yidong <cyd@gnu.org>
793 * xdisp.c (redisplay_internal): No need to redisplay terminal
794 frames that are not on top.
796 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
798 * process.c (make_process): Initialize write_queue.
799 (write_queue_push, write_queue_pop): New functions.
800 (send_process): Use them to maintain correct ordering of process
803 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
805 * lisp.h (eassert): Assume C89 or later.
806 This removes the need for CHECK.
807 (CHECK): Remove. Its comments about always evaluating its
808 argument were confusing, as 'eassert' typically does not evaluate
811 * coding.c (produce_chars): Use ptrdiff_t, not int.
813 * xterm.c (x_draw_underwave): Check for integer overflow.
814 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
816 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
818 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
819 referenced (Bug#11583).
821 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
823 Implement wave-style variant of underlining.
824 * dispextern.h (face_underline_type): New enum.
825 (face): Add field for underline type.
826 * nsterm.m (ns_draw_underwave): New function.
827 (ns_draw_text_decoration): Use it.
828 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
830 (x_draw_glyph_string): Use them.
831 * xfaces.c (Qline, Qwave): New Lisp objects.
832 (check_lface_attrs, merge_face_ref)
833 (Finternal_set_lisp_face_attribute, realize_x_face):
834 Handle wave-style underline face attributes.
835 * xterm.c (x_draw_underwave): New function.
836 (x_draw_glyph_string): Use it.
838 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
840 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
841 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
842 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
843 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
844 ($(BLD)/w32select.$(O)): Update dependencies.
846 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
848 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
849 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
850 * character.c (_fetch_multibyte_char_p): Remove.
851 * alloc.c: Include "character.h" before "buffer.h".
853 * buffer.c: Likewise.
854 * bytecode.c: Likewise.
855 * callint.c: Likewise.
856 * callproc.c: Likewise.
857 * casefiddle.c: Likewise.
858 * casetab.c: Likewise.
859 * category.c: Likewise.
861 * coding.c: Likewise.
862 * composite.c: Likewise.
864 * dispnew.c: Likewise.
866 * dosfns.c: Likewise.
867 * editfns.c: Likewise.
869 * fileio.c: Likewise.
870 * filelock.c: Likewise.
872 * fontset.c: Likewise.
873 * fringe.c: Likewise.
874 * indent.c: Likewise.
875 * insdel.c: Likewise.
876 * intervals.c: Likewise.
877 * keyboard.c: Likewise.
878 * keymap.c: Likewise.
880 * macros.c: Likewise.
881 * marker.c: Likewise.
882 * minibuf.c: Likewise.
884 * nsmenu.m: Likewise.
886 * process.c: Likewise.
888 * region-cache.c: Likewise.
889 * search.c: Likewise.
890 * syntax.c: Likewise.
892 * textprop.c: Likewise.
894 * unexsol.c: Likewise.
895 * w16select.c: Likewise.
896 * w32fns.c: Likewise.
897 * w32menu.c: Likewise.
898 * window.c: Likewise.
903 * xselect.c: Likewise.
905 2012-06-16 Eli Zaretskii <eliz@gnu.org>
907 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
908 If all the glyphs of the glyph row came from strings, and we have no
909 cursor positioning clues, put the cursor on the first glyph of the
911 (handle_face_prop): Use chunk-relative overlay string index when
912 indexing into it->string_overlays array. (Bug#11653)
913 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
914 the rightmost. (Bug#11720)
916 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
918 * category.h (CHAR_HAS_CATEGORY): Define as inline.
919 (CATEGORY_MEMBER): Enforce 1/0 value.
920 * category.c (_temp_category_set): Remove.
922 2012-06-16 Eli Zaretskii <eliz@gnu.org>
924 * window.c (Fdelete_other_windows_internal)
925 (Fdelete_window_internal): Don't access frame's mouse highlight
926 info of the initial frame. (Bug#11677)
928 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
930 * .gdbinit (xgetint): Fix recently-introduced paren typo.
931 Assume USE_2_TAGS_FOR_INTS.
932 (xreload): Adjust $tagmask width to match recent lisp.h change.
934 Simplify lisp.h in minor ways that should not affect code.
935 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
936 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
937 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
938 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
939 (INTTYPEBITS): New macro, for clarity.
940 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
941 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
942 Simplify now that USE_LSB_TAG is always defined.
943 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
944 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
946 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
948 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
950 2012-06-13 Glenn Morris <rgm@gnu.org>
952 * s/bsd-common.h (BSD4_3):
953 * s/usg5-4-common.h (USG5_4): No longer define; unused.
955 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
957 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
960 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
962 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
963 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
964 * alloc.c (widen_to_Lisp_Object): Remove.
965 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
966 * frame.c (delete_frame): Remove outdated comment.
967 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
969 (Fw32_unregister_hot_key): Likewise.
970 (Fw32_toggle_lock_key): Likewise.
971 * w32menu.c (add_menu_item): Likewise.
972 (w32_menu_display_help): Use XIL instead of checking
974 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
975 (init_heap): Likewise.
976 * w32term.c (w32_read_socket): Update comment.
978 2012-06-13 Glenn Morris <rgm@gnu.org>
980 * s/usg5-4-common.h, src/s/unixware.h:
981 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
983 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
985 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
987 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
988 * alloc.c (make_number) [!defined make_number]:
989 Remove, as lisp.h always defines this now.
990 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
991 (roundup_size): Verify that it is a power of 2.
992 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
993 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
994 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
995 -DUSE_LSB_TAG=0, to override the automatically-selected default.
996 USE_LSB_TAG now is always defined to be either 0 or 1.
998 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
999 code works fine either way, and efficiency is not a concern here,
1000 as the union type is for debugging, not for production.
1001 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1002 Use an inline function on all platforms when using the union type,
1003 since this is simpler and 'static inline' can be used portably
1005 (LISP_INITIALLY_ZERO): New macro.
1006 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1007 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1009 2012-06-12 Glenn Morris <rgm@gnu.org>
1011 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1013 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1015 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1016 Move BROKEN_SIGIO to configure.
1018 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1019 Move NO_TERMIO to configure.
1021 2012-06-12 Chong Yidong <cyd@gnu.org>
1023 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1024 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1025 MagickExportImagePixels is undefined.
1027 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1029 * image.c (imagemagick_load_image): Remove unused label.
1031 2012-06-11 Glenn Morris <rgm@gnu.org>
1033 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1034 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1035 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1036 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1038 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1040 * alloc.c (make_byte_code): New function.
1041 (Fmake_byte_code): Use it. Don't purify here.
1042 * lread.c (read1): Use it as well to avoid extra allocation.
1044 2012-06-11 Chong Yidong <cyd@gnu.org>
1046 * image.c (imagemagick_load_image): Implement transparency.
1048 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1050 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1051 account for preceding backslashes. (Bug#11663)
1053 2012-06-09 Chong Yidong <cyd@gnu.org>
1055 * term.c: Support italics in capable terminals (Bug#9652).
1056 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1057 (turn_on_face): Output using TS_enter_italic_mode if available.
1058 Don't handle unused blinking and alt-charset cases.
1059 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1060 and tty_alt_charset_p cases.
1061 (tty_capable_p, init_tty): Support italics.
1063 * termchar.h (struct tty_display_info): Add field for italics.
1064 Remove unused blink field.
1066 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1069 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1070 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1071 tty_alt_charset_p. Add tty_italic_p.
1073 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1075 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1076 dbus_type_is_basic if available.
1077 (xd_extract_signed, xd_extract_unsigned): Rename from
1078 extract_signed and extract_unsigned, respectively. Adapt callers.
1080 2012-06-09 Chong Yidong <cyd@gnu.org>
1082 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1084 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1087 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1089 * xdisp.c (vmessage): Treat frame message as multibyte.
1090 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1091 would generate the diagnostic "Making \302\247 buffer-local while
1094 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1096 * dispnew.c (showing_window_margins_p): Undo last change, which
1097 was done due to an inadvertent commit.
1098 (adjust_frame_glyphs_for_frame_redisplay): Do call
1099 showing_window_margins_p.
1101 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1103 * eval.c (Fmake_var_non_special): New primitive.
1104 (syms_of_eval): Defsubr it.
1105 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1107 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1109 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1110 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1112 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1114 * alloc.c (allocate_vectorlike): Fix last change.
1116 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1118 Block-based vector allocation of small vectors.
1119 * lisp.h (struct vectorlike_header): New field `nbytes',
1120 adjust comment accordingly.
1121 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1122 to denote vector blocks. Adjust users (live_vector_p,
1123 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1124 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1125 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1126 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1127 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1128 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1129 (roundup_size): New constant.
1130 (struct vector_block): New data type.
1131 (vector_blocks, vector_free_lists, zero_vector): New variables.
1132 (all_vectors): Rename to `large_vectors'.
1133 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1134 (sweep_vectors): New functions.
1135 (allocate_vectorlike): Return `zero_vector' as the only vector of
1136 0 items. Allocate new vector from block if vector size is less than
1137 or equal to VBLOCK_BYTES_MAX.
1138 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1139 (init_alloc_once): Add call to init_vectors.
1141 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1143 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1145 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1147 * doprnt.c (doprnt): Truncate multibyte char correctly.
1148 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1149 would mishandle a string argument "Xc" if X was a multibyte
1150 character of length 2: it would truncate after X's first byte
1151 rather than including all of X.
1153 2012-06-06 Chong Yidong <cyd@gnu.org>
1155 * buffer.c (word_wrap): Doc fix.
1157 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1159 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1161 2012-06-03 Glenn Morris <rgm@gnu.org>
1163 * xdisp.c (tool-bar-style): Doc fix.
1165 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1167 * Makefile.in (PAXCTL): Define.
1168 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1169 binary via PaX flags if the paxctl utility is available.
1170 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1171 Restore PaX flags to their default. (Bug#11398)
1173 2012-06-03 Chong Yidong <cyd@gnu.org>
1175 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1178 2012-06-03 Chong Yidong <cyd@gnu.org>
1180 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1181 (note_mode_line_or_margin_highlight): If there is no help echo,
1182 use mode-line-default-help-echo. Handle the case where the mouse
1183 position is past the end of the mode line string.
1185 * buffer.c (buffer_local_value_1): New function, split from
1186 Fbuffer_local_value; can return Qunbound.
1187 (Fbuffer_local_value): Use it.
1188 (Vmode_line_format): Docstring tweaks.
1190 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1192 * sysdep.c (system_process_attributes): Improve comment.
1194 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1196 * keyboard.c: Export real-this-command to Elisp.
1197 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1198 and DEFVAR it. Update all users.
1200 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1202 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1204 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1205 Convert pctcpu and pctmem to Lisp float properly.
1206 Let the compiler fold better, as 100.0/0x8000 is exact.
1208 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1210 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1213 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1215 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1217 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1219 For a 'struct window', replace some Lisp_Object fields to
1220 bitfields where appropriate, remove unused fields.
1221 * window.h (struct window): Remove unused 'last_mark_x' and
1222 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1223 change it's type from Lisp_Object to bitfield.
1224 Change type of 'force_start', 'optional_new_start',
1225 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1226 fields from Lisp_Object to bitfield. Adjust users accordingly.
1228 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1230 Pacify gcc -Wdouble-precision when using Xaw.
1231 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1232 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1233 Use 'float' consistently, rather than 'float' in most places
1234 and 'double' in a couple of places.
1236 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1238 * xdisp.c (handle_stop): Detect whether we have overlay strings
1239 loaded by testing it->current.overlay_string_index to be
1240 non-negative, instead of checking whether n_overlay_strings is
1241 positive. (Bug#11587)
1243 2012-05-31 Chong Yidong <cyd@gnu.org>
1245 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1247 * doc.c (Fsubstitute_command_keys): Doc fix.
1249 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1251 * search.c (search_buffer): Remove calls to
1252 r_alloc_inhibit_buffer_relocation, as it is now called by
1253 maybe_unify_char, which was the cause of relocation of buffer text
1256 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1258 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1259 for the duration of call to load_charset, to avoid problems with
1260 callers of maybe_unify_char that access buffer text through C
1263 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1264 decrement the inhibition flag, instead of just setting or
1267 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1269 Remove obsolete '#define static' cruft.
1270 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1271 This #undef was "temporary" in 2000; it is no longer needed
1272 now that '#define static' has gone away.
1273 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1274 (gray_bitmap_bits): Remove; no longer needed.
1275 All uses replaced with definiens.
1276 * xterm.c: Include "bitmaps/gray.xbm".
1278 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1280 Clean up __executable_start, monstartup when --enable-profiling.
1281 The following changes affect the code only when profiling.
1282 * dispnew.c (__executable_start): Rename from safe_bcopy.
1283 Define only on platforms that need it.
1284 * emacs.c: Include <sys/gmon.h> when profiling.
1285 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1286 (__executable_start): Remove decl, since lisp.h does it now.
1287 (safe_bcopy): Remove decl; no longer has that name.
1288 (main): Coalesce #if into single bit of code, for simplicity.
1289 Cast pointers to uintptr_t, since standard libraries want integers
1291 * lisp.h (__executable_start): New decl.
1293 2012-05-31 Glenn Morris <rgm@gnu.org>
1295 * image.c (Fimagemagick_types): Doc fix.
1297 2012-05-30 Jim Meyering <meyering@redhat.com>
1299 * callproc.c (Fcall_process_region): Include directory component
1300 in mkstemp error message (Bug#11586).
1302 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1304 * alloc.c, lisp.h (make_pure_vector): Now static.
1306 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1308 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1309 Move to byte-run.el.
1310 (Fautoload): Do the hash-doc more carefully.
1311 * data.c (Fdefalias): Purify definition, except for keymaps.
1312 (Qdefun): Move from eval.c.
1313 * lisp.h (Qdefun): Remove.
1314 * lread.c (read1): Tiny simplification.
1316 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1318 Do not create empty overlays with the evaporate property (Bug#9642).
1319 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1320 Bug#9642, but explicitly check that the buffer the overlay would
1321 be moved to is live and rearrange lines to make sure that errors
1322 will not put the overlay in an inconsistent state.
1323 (Fdelete_overlay): Cosmetics.
1325 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1327 * w32term.c (my_bring_window_to_top): New function.
1328 (x_raise_frame): Use handle returned by DeferWindowPos, which
1329 could be different from the original one.
1330 Call my_bring_window_to_top instead of my_set_foreground_window.
1333 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1334 by calling BringWindowToTop.
1336 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1337 (WM_EMACS_END): Increase by one.
1339 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1341 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1342 This avoids undefined behavior that might cause the eassert
1343 to not catch an out-of-range value.
1345 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1347 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1348 Update dependencies.
1350 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1352 * bidi.c (bidi_mirror_char): Fix last change.
1354 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1356 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1357 when referring to sectname field in printf format.
1359 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1361 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1362 Only r_alloc_inhibit_buffer_relocation needed to be added;
1363 the others were already declared.
1365 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1366 before checking whether it's out of range. Put the check inside
1368 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1370 2012-05-27 Ken Brown <kbrown@cornell.edu>
1372 * callproc.c (Fcall_process): Restore a line that was accidentally
1373 commented out in the 2011-02-13 change (bug#11547).
1375 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1377 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1378 defined on ralloc.c.
1380 * buffer.c [REL_ALLOC]: Remove prototypes of
1381 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1382 they are now on lisp.h.
1384 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1386 * search.c (search_buffer): Use it to inhibit relocation of buffer
1387 text while re_search_2 is doing its job, because re_search_2 is
1388 passed C pointers to buffer text. (Bug#11519)
1390 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1393 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1394 state after an additional call to move_it_in_display_line_to, keep
1395 the values of it->max_ascent and it->max_descent found for the
1397 (pos_visible_p): Revert the comparison against bottom_y to what it
1398 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1401 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1403 Fix coding-related core dumps with gcc -ftrapv.
1404 The code was computing A - B, where A and B are pointers, and B is
1405 random garbage. This can lead to core dumps on platforms that
1406 have special pointer registers, and it also leads to core dumps on
1407 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1408 A - B only when B is initialized properly.
1409 * coding.c (coding_set_source, coding_set_destination): Return void.
1410 (coding_change_source, coding_change_destinations): New functions,
1411 with the old behaviors of coding_set_source and coding_set_destination.
1412 All callers that need an offset changed to use these new functions.
1414 2012-05-26 Glenn Morris <rgm@gnu.org>
1416 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1418 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1420 Extend mouse support on W32 text-mode console.
1421 * xdisp.c (draw_row_with_mouse_face):
1422 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1424 * w32console.c: Include window.h.
1425 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1427 (initialize_w32_display): Initialize mouse-highlight data.
1429 * w32inevt.c: Include termchar.h and window.h.
1430 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1431 moves, call note_mouse_highlight. If help_echo changed, call
1432 gen_help_event to produce help-echo message in the echo area.
1433 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1436 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1438 * lread.c (read1): Simplify slightly to avoid an overflow warning
1439 with GCC 4.7.0 on x86-64.
1441 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1443 * bidi.c (bidi_mirror_char): Revert last change: an int is
1444 definitely wide enough here.
1446 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1448 Fix integer width and related bugs (Bug#9874).
1449 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1450 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1451 (string_bytes, check_sblock, allocate_string_data):
1452 (compact_small_strings, Fmake_bool_vector, make_string)
1453 (make_unibyte_string, make_multibyte_string)
1454 (make_string_from_bytes, make_specified_string)
1455 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1456 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1459 (allocate_pseudovector):
1460 Use int, not EMACS_INT, where int is wide enough.
1461 (inhibit_garbage_collection, Fgarbage_collect):
1462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1463 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1464 int might not be wide enough.
1465 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1466 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1467 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1468 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1469 (bidi_level_of_next_char, bidi_move_to_visually_next):
1470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1471 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1472 (Fkill_buffer, Fset_buffer_major_mode)
1473 (advance_to_char_boundary, Fbuffer_swap_text)
1474 (Fset_buffer_multibyte, overlays_at, overlays_in)
1475 (overlay_touches_p, struct sortvec, record_overlay_string)
1476 (overlay_strings, recenter_overlay_lists)
1477 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1478 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1479 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1480 (Foverlay_recenter, last_overlay_modification_hooks_used)
1481 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1483 (validate_region): Omit unnecessary test for b <= e,
1484 since that's guaranteed by the previous test.
1485 (adjust_overlays_for_delete): Avoid pos + length overflow.
1486 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1487 (report_overlay_modification):
1488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1489 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1490 Omit pointer cast, which isn't needed anyway, and doesn't work
1491 after the EMACS_INT -> ptrdiff_t change.
1492 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1493 * buffer.h: Adjust decls to match defn changes elsewhere.
1494 (struct buffer_text, struct buffer):
1495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1496 Use EMACS_INT, not int, where int might not be wide enough.
1497 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1498 not int, to avoid needless 32-bit limit on 64-bit hosts.
1499 (exec_byte_code): Use tighter memory-full test, one that checks
1500 for alloca overflow. Don't compute the address of the object just
1501 before an array, as that's not portable. Use EMACS_INT, not
1502 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1503 * callint.c (Fcall_interactively):
1504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1505 * callproc.c (call_process_kill, Fcall_process):
1506 Don't assume pid_t fits into an Emacs fixnum.
1507 (call_process_cleanup, Fcall_process, child_setup):
1508 Don't assume pid_t fits into int.
1509 (call_process_cleanup, Fcall_process, delete_temp_file)
1510 (Fcall_process_region):
1511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1512 (Fcall_process): Simplify handling of volatile integers.
1513 Use int, not EMACS_INT, where int will do.
1514 * casefiddle.c (casify_object, casify_region, operate_on_word)
1515 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1517 (casify_object): Avoid integer overflow when overallocating buffer.
1518 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1519 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1520 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1521 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1522 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1523 integers are now checked earlier. All uses replaced with XINT.
1525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1526 For CCL_MapSingle, check that content and value are in int range.
1527 (ccl_driver, Fregister_code_conversion_map):
1528 Check that Vcode_version_map_vector is a vector.
1529 (resolve_symbol_ccl_program): Check that vector header is in range.
1530 Always copy the vector, so that we can check its contents reliably
1531 now rather than having to recheck each instruction as it's being
1532 executed. Check that vector words fit in 'int'.
1533 (ccl_get_compiled_code, Fregister_ccl_program)
1534 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1535 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1536 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1537 contents are in range.
1538 (Fccl_execute_on_string): Check that status is in range.
1539 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1540 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1541 Accept and return EMACS_INT, not int, because callers can pass values
1543 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1544 (multibyte_chars_in_text, parse_str_as_multibyte)
1545 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1546 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1547 (string_escape_byte8, Fget_byte):
1548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1549 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1550 avoid mishandling large integers.
1551 * character.h: Adjust decls to match defn changes elsewhere.
1552 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1553 (Ffind_charset_region):
1554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1555 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1556 (load_charset_map_from_vector, Fdefine_charset_internal):
1557 Don't assume fixnum fits in int.
1558 (load_charset_map_from_vector, Fmap_charset_chars):
1559 Remove now-unnecessary CHECK_NATNUMs.
1560 (Fdefine_charset_internal): Check ranges here, more carefully.
1561 Don't rely on undefined behavior with signed left shift overflow.
1562 Don't assume unsigned int fits into fixnum, or that fixnum fits
1563 into unsigned int. Don't require max_code to be a valid fixnum;
1564 that's not true for gb10830 4-byte on a 32-bit host. Allow
1565 invalid_code to be a cons, for the same reason. Require code_offset
1566 to be a character. Avoid int overflow if max_char is close
1568 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1569 this is intended anyway and avoids some undefined behavior.
1570 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1571 INDEX_TO_CODE_POINT, as that's what it expects.
1572 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1573 * charset.h (DECODE_CHAR): Return int, not unsigned;
1574 this is what was intended anyway, and it avoids undefined behavior.
1575 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1576 integer-overflow issues.
1577 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1578 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1579 where the argument is EMACS_INT, and this behavior is not intended.
1580 * chartab.c (Fmake_char_table, Fset_char_table_range)
1581 (uniprop_get_decoder, uniprop_get_encoder):
1582 Don't assume fixnum fits in int.
1583 * cmds.c (move_point): New function, that does the gist of
1584 Fforward_char and Fbackward_char, but does so while checking
1585 for integer overflow more accurately.
1586 (Fforward_char, Fbackward_char): Use it.
1587 (Fforward_line, Fend_of_line, internal_self_insert)
1588 (internal_self_insert):
1589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1590 Fix a FIXME, by checking for integer overflow when calculating
1591 target_clm and actual_clm.
1592 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1593 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1594 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1595 (coding_alloc_by_making_gap, alloc_destination)
1596 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1597 (encode_coding_utf_16, detect_coding_emacs_mule)
1598 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1599 (detect_coding_iso_2022, decode_coding_iso_2022)
1600 (encode_invocation_designation, encode_designation_at_bol)
1601 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1602 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1603 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1604 (encode_coding_ccl, encode_coding_raw_text)
1605 (detect_coding_charset, decode_coding_charset)
1606 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1607 (produce_composition, produce_charset, produce_annotation)
1608 (decode_coding, handle_composition_annotation)
1609 (handle_charset_annotation, consume_chars, decode_coding_gap)
1610 (decode_coding_object, encode_coding_object, detect_coding_system)
1611 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1612 (code_convert_region, code_convert_string)
1613 (Fdefine_coding_system_internal)
1614 (coding_set_source, coding_set_destination):
1615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1616 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1617 (Fdefine_coding_system_internal):
1618 Don't assume fixnums fit in int.
1619 (decode_coding_gap, decode_coding_object, encode_coding_object)
1620 (Fread_coding_system, Fdetect_coding_region)
1621 (Funencodable_char_position, Fcheck_coding_systems_region)
1622 (get_translation, handle_composition_annotation, consume_chars):
1623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1624 (consume_chars): Rewrite to not calculate an address outside buffer.
1625 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1626 Don't access memory outside of the args array.
1627 (Fdefine_coding_system_internal): Check for charset-id overflow.
1628 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1629 result of ENCODE_CHAR.
1630 * coding.h: Adjust decls to match defn changes elsewhere.
1631 (struct coding_system):
1632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1633 * composite.c (get_composition_id, find_composition)
1634 (run_composition_function, update_compositions)
1635 (compose_text, composition_gstring_put_cache)
1636 (composition_gstring_p, composition_gstring_width)
1637 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1638 (composition_compute_stop_pos, composition_reseat_it)
1639 (composition_update_it, struct position_record)
1640 (find_automatic_composition, composition_adjust_point)
1641 (Fcomposition_get_gstring, Ffind_composition_internal):
1642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1643 (update_compositions):
1644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1645 * composite.h: Adjust decls to match defn changes elsewhere.
1646 (struct composition):
1647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1648 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1649 Do not attempt to compute the address of the object just before a
1650 buffer; this is not portable.
1652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1653 (Faset): Use int, not EMACS_INT, where int is wide enough.
1654 (Fstring_to_number): Don't assume fixnums fit in int.
1655 (Frem): Don't assume arg is nonnegative.
1656 * dbusbind.c (xd_append_arg): Check for integers out of range.
1657 (Fdbus_call_method): Don't overflow the timeout int.
1658 (extract_signed, extract_unsigned): New functions.
1659 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1660 (xd_get_connection_references): Return ptrdiff_t, not int.
1662 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1663 (xd_read_message_1):
1664 Use int, not unsigned, where the dbus API uses int.
1665 (Fdbus_message_internal): Don't overflow mtype.
1666 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1667 * dired.c (directory_files_internal, file_name_completion, scmp)
1668 (file_name_completion_stat):
1669 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1670 (file_name_completion): Don't overflow matchcount.
1671 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1672 * dispextern.h: Adjust decls to match defn changes elsewhere.
1673 (struct text_pos, struct glyph, struct bidi_saved_info)
1674 (struct bidi_string_data, struct bidi_it, struct composition_it)
1676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1677 (struct display_pos, struct composition_it, struct it):
1678 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1679 * dispnew.c (increment_matrix_positions)
1680 (increment_row_positions, mode_line_string)
1681 (marginal_area_string):
1682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1683 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1684 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1685 (duration_to_sec_usec): New function, to check for overflow better.
1686 (Fsleep_for, sit_for): Use it.
1687 * doc.c (get_doc_string, store_function_docstring):
1688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1689 (get_doc_string, Fsnarf_documentation):
1690 Use int, not EMACS_INT, where int is wide enough.
1692 Use SAFE_ALLOCA, not alloca.
1693 Check for overflow when converting EMACS_INT to off_t.
1694 * doprnt.c (doprnt):
1695 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1696 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1697 Don't assume uid_t fits into fixnum.
1698 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1699 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1700 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1701 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1702 (general_insert_function)
1703 (Finsert_char, make_buffer_string, make_buffer_string_both)
1704 (update_buffer_properties, Fbuffer_substring)
1705 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1706 (Fsubst_char_in_region, check_translation)
1707 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1708 (transpose_markers, Ftranspose_regions):
1709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1710 (clip_to_bounds): Move to lisp.h as an inline function).
1711 (Fconstrain_to_field): Don't assume integers are nonnegative.
1712 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1713 (Fsubst_char_in_region, Fsave_restriction):
1714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1715 (Femacs_pid): Don't assume pid_t fits into fixnum.
1716 (lo_time): Use int, not EMACS_INT, when int suffices.
1717 (lisp_time_argument): Check for usec out of range.
1718 (Fencode_time): Don't assume fixnum fits in int.
1719 (Fuser_login_name, Fuser_full_name): Signal an error
1720 if a uid argument is out of range, rather than relying on
1722 (Fformat_time_string): Remove now-unnecessary check.
1723 lisp_time_argument checks for out-of-range usec now.
1724 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1725 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1726 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1727 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1728 (init_cmdargs, Fdump_emacs):
1729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1730 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1731 the bottom (typically) 32 bits of the fixnum.
1732 * eval.c (specpdl_size, call_debugger):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 (when_entered_debugger, Fbacktrace_debug):
1735 Don't assume fixnum can fit in int.
1736 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1737 the object just before a buffer; this is not portable.
1738 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1739 (grow_specpdl, unbind_to):
1740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1741 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1742 (grow_specpdl): Simplify allocation by using xpalloc.
1743 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1744 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1745 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1747 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1750 (Fcopy_file, non_regular_nbytes, read_non_regular)
1751 (Finsert_file_contents):
1752 Use int, not EMACS_INT, where int is wide enough.
1753 (READ_BUF_SIZE): Verify that it fits in int.
1754 (Finsert_file_contents): Check that counts are in proper range,
1755 rather than assuming fixnums fit into ptrdiff_t etc.
1756 Don't assume fixnums fit into int.
1757 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1758 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1759 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1760 (string_char_to_byte, string_byte_to_char)
1761 (string_make_multibyte, string_to_multibyte)
1762 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1763 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1764 (substring_both, Fdelete, internal_equal, Ffillarray)
1765 (Fclear_string, mapcar1)
1766 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1767 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1768 (larger_vector, make_hash_table, maybe_resize_hash_table)
1769 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1770 (Fmaphash, secure_hash):
1771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1772 (concat): Check for string index and length overflow.
1773 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1776 (larger_vector): New API (vec, incr_min, size_max) replaces old
1777 one (vec, new_size, init). This catches size overflow.
1778 INIT was removed because it was always Qnil.
1779 All callers changed.
1780 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1781 the upper bound on a hash table index size.
1782 (make_hash_table, maybe_resize_hash_table): Use it.
1783 (secure_hash): Computer start_byte and end_byte only after
1784 they're known to be in ptrdiff_t range.
1785 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1786 (Ffont_get_glyphs, Ffont_at):
1787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1788 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1789 (Flist_fonts, Fopen_font):
1790 Don't assume fixnum can fit in int.
1791 (check_gstring): Don't assume index can fit in int.
1792 (font_match_p): Check that fixnum is a character, not a nonnegative
1793 fixnum, since the later code needs to stuff it into an int.
1794 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1795 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1796 conversion overflow issues.
1797 (Fopen_font): Check for integer out of range.
1798 (Ffont_get_glyphs): Don't assume index can fit in int.
1799 * font.h: Adjust decls to match defn changes elsewhere.
1800 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1802 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1803 printmax_t, where ptrdiff_t is wide enough.
1804 (Finternal_char_font):
1805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1806 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1807 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1808 (Fset_frame_position, x_set_frame_parameters)
1809 (x_set_line_spacing, x_set_border_width)
1810 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1811 Check that fixnums are in proper range for system types.
1812 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1814 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1815 Use SAFE_ALLOCA_LISP, not alloca.
1816 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1817 intptr_t is wide enough.
1818 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1819 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1820 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1821 Check for fixnum out of range.
1822 * ftfont.c (ftfont_list): Don't assume index fits in int.
1823 Check that fixnums are in proper range for system types.
1824 (ftfont_shape_by_flt):
1825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1826 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1829 Check that fixnums are in proper range for system types.
1830 * gnutls.h: Adjust decls to match defn changes elsewhere.
1831 * gtkutil.c (xg_dialog_run):
1832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1833 (update_frame_tool_bar):
1834 Check that fixnums are in proper range for system types.
1835 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1836 (lookup_image): Check that fixnums are in range for system types.
1837 * indent.c (last_known_column, last_known_column_point):
1838 (current_column_bol_cache):
1839 (skip_invisible, current_column, check_display_width):
1840 (check_display_width, scan_for_column, current_column_1)
1841 (Findent_to, Fcurrent_indentation, position_indentation)
1842 (indented_beyond_p, Fmove_to_column, compute_motion):
1843 (Fcompute_motion, Fvertical_motion):
1844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1845 (last_known_column_modified): Use EMACS_INT, not int.
1846 (check_display_width):
1848 Check that fixnums and floats are in proper range for system types.
1849 (compute_motion): Don't assume index or fixnum fits in int.
1850 (compute_motion, Fcompute_motion):
1851 Use int, not EMACS_INT, when it is wide enough.
1852 (vmotion): Omit local var start_hpos that is always 0; that way
1853 we don't need to worry about overflow in expressions involving it.
1854 * indent.h: Adjust decls to match defn changes elsewhere.
1856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1857 Use int, not EMACS_INT, where int is wide enough.
1858 Remove unused members ovstring_chars_done and tab_offset;
1860 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1861 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1862 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1863 (make_gap, copy_text, insert, insert_and_inherit)
1864 (insert_before_markers, insert_before_markers_and_inherit)
1865 (insert_1, count_combining_before, count_combining_after)
1866 (insert_1_both, insert_from_string)
1867 (insert_from_string_before_markers, insert_from_string_1)
1868 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1869 (adjust_after_replace, adjust_after_insert, replace_range)
1870 (replace_range_2, del_range, del_range_1, del_range_byte)
1871 (del_range_both, del_range_2, modify_region)
1872 (prepare_to_modify_buffer, signal_before_change)
1873 (signal_after_change, Fcombine_after_change_execute):
1874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1875 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1876 (balance_an_interval, split_interval_right, split_interval_left)
1877 (find_interval, next_interval, update_interval)
1878 (adjust_intervals_for_insertion, delete_node, delete_interval)
1879 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1880 (static_offset_intervals, offset_intervals)
1881 (merge_interval_right, merge_interval_left, make_new_interval)
1882 (graft_intervals_into_buffer, temp_set_point_both)
1883 (temp_set_point, set_point, adjust_for_invis_intang)
1884 (set_point_both, move_if_not_intangible, get_property_and_range)
1885 (get_local_map, copy_intervals, copy_intervals_to_string)
1886 (compare_string_intervals, set_intervals_multibyte_1):
1887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1888 * intervals.h: Adjust decls to match defn changes elsewhere.
1890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1891 * keyboard.c (this_command_key_count, this_single_command_key_start)
1892 (before_command_key_count, before_command_echo_length, echo_now)
1893 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1894 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1895 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1896 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1898 (last_non_minibuf_size, last_point_position, echo_truncate)
1899 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1900 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1901 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1902 (stuff_buffered_input):
1903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1904 (last_auto_save, command_loop_1, read_char):
1905 Use EMACS_INT, not int, to avoid integer overflow.
1906 (record_char): Avoid overflow in total_keys computation.
1907 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1908 * keyboard.h: Adjust decls to match defn changes elsewhere.
1909 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1910 (Fkey_description, Fdescribe_vector, Flookup_key):
1911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1912 (click_position): New function, to check that positions are in range.
1913 (Fcurrent_active_maps):
1915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1916 (Faccessible_keymaps, Fkey_description):
1917 (preferred_sequence_p):
1918 Don't assume fixnum can fit into int.
1919 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1920 Check for integer overflow in size calculations.
1921 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1922 avoid mishandling large integers.
1923 * lisp.h: Adjust decls to match defn changes elsewhere.
1924 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1925 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1926 (struct Lisp_Marker):
1927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1928 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1929 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1930 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1931 All callers changed.
1932 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1933 Assume the arg has valid form, since it always does.
1934 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1935 unsigned integer system type.
1936 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1937 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1939 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1940 (duration_to_sec_usec): New decl.
1941 * lread.c (read_from_string_index, read_from_string_index_byte)
1942 (read_from_string_limit, readchar, unreadchar, openp)
1943 (read_internal_start, read1, oblookup):
1944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1945 (Fload, readevalloop, Feval_buffer, Feval_region):
1946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1947 (openp): Check for out-of-range argument to 'access'.
1948 (read1): Use int, not EMACS_INT, where int is wide enough.
1949 Don't assume fixnum fits into int.
1950 Fix off-by-one error that can read outside a buffer.
1951 (read_filtered_event): Use duration_to_sec_usec
1952 to do proper overflow checking on durations.
1953 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1954 in size calculation.
1955 (Fexecute_kbd_macro):
1956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1957 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1958 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1959 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1960 (set_marker_both, set_marker_restricted_both, marker_position)
1961 (marker_byte_position, Fbuffer_has_markers_at):
1962 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1963 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1964 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1965 It now merely ensures that the menu is large enough, without
1966 necessarily growing it, as this avoids some integer overflow issues.
1967 All callers changed.
1968 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1970 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1971 Use SAFE_ALLOCA_LISP, not alloca.
1972 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1973 to EMACS_INT. Check that fixnums are in proper range for system types.
1974 * minibuf.c (minibuf_prompt_width, string_to_object)
1975 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1976 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1978 (get_minibuffer, read_minibuf_unwind):
1979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1980 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1981 this simplifies overflow checking. All callers changed.
1982 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1985 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1986 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1987 Check that fixnums are in proper range for system types.
1988 (Fx_create_frame, Fx_show_tip):
1989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1990 * nsfont.m (ns_findfonts, nsfont_list_family):
1991 Don't assume fixnum fits in long.
1992 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1994 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1996 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1998 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1999 (PRINTDECLARE, PRINTPREPARE):
2000 (strout, print_string):
2001 (print, print_preprocess, print_check_string_charset_prop)
2003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2005 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2007 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2008 (printchar, strout): Use xpalloc to catch size calculation overflow.
2009 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2010 (print_error_message): Use SAFE_ALLOCA, not alloca.
2011 (print_object): Use int, not EMACS_INT, where int is wide enough.
2012 (print_depth, new_backquote_output, print_number_index):
2013 Use ptrdiff_t, not int, where int might not be wide enough.
2014 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2015 (Fset_process_window_size, Fformat_network_address)
2016 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2018 Check that fixnums are in proper range for system types.
2019 (Fsignal_process): Simplify by avoiding a goto.
2020 Check for process-ids out of pid_t range rather than relying on
2022 (process_tick, update_tick): Use EMACS_INT, not int.
2023 (Fformat_network_address, read_process_output, send_process)
2024 (Fprocess_send_region, status_notify):
2025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2026 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2027 (wait_reading_process_output, read_process_output, exec_sentinel):
2028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2029 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2030 (Faccept_process_output): Use duration_to_sec_usec to do proper
2031 overflow checking on durations.
2032 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2033 Don't assume pid_t fits in int.
2034 * process.h (struct Lisp_Process): Members tick and update_tick
2035 are now of type EMACS_INT, not int.
2036 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2037 configured --with-wide-int.
2038 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2039 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2040 * search.c (looking_at_1, string_match_1):
2041 (fast_string_match, fast_c_string_match_ignore_case)
2042 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2043 (scan_newline, find_before_next_newline, search_command)
2044 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2045 (set_search_regs, wordify):
2048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2049 (string_match_1, search_buffer, set_search_regs):
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (wordify): Check for overflow in size calculation.
2053 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2054 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2055 Check that fixnums are in proper range for system types.
2056 * sound.c (struct sound_device)
2057 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 (Fplay_sound_internal):
2060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2061 * syntax.c (struct lisp_parse_state, find_start_modiff)
2062 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2063 (Fparse_partial_sexp):
2064 Don't assume fixnums can fit in int.
2065 (struct lisp_parse_state, find_start_pos, find_start_value)
2066 (find_start_value_byte, find_start_begv)
2067 (update_syntax_table, char_quoted, dec_bytepos)
2068 (find_defun_start, prev_char_comend_first, back_comment):
2069 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2070 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2072 (Finternal_describe_syntax_value): Check that match_lisp is a
2073 character, not an integer, since the code stuffs it into int.
2074 (scan_words, scan_sexps_forward):
2075 Check that fixnums are in proper range for system types.
2077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2078 (scan_sexps_forward):
2079 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2080 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2081 * syntax.h: Adjust decls to match defn changes elsewhere.
2082 (struct gl_state_s):
2083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2084 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2085 MOST_POSITIVE_FIXNUM.
2086 * sysdep.c (wait_for_termination_1, wait_for_termination)
2087 (interruptible_wait_for_termination, mkdir):
2088 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2089 (emacs_read, emacs_write):
2090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2091 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2092 and double all fit in int.
2093 * term.c (set_tty_color_mode):
2094 Check that fixnums are in proper range for system types.
2095 * termhooks.h (struct input_event):
2096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2097 * textprop.c (validate_interval_range, interval_of)
2098 (Fadd_text_properties, set_text_properties_1)
2099 (Fremove_text_properties, Fremove_list_of_text_properties)
2100 (Ftext_property_any, Ftext_property_not_all)
2101 (copy_text_properties, text_property_list, extend_property_ranges)
2102 (verify_interval_modification):
2103 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2104 (Fnext_single_char_property_change)
2105 (Fprevious_single_char_property_change):
2106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2107 (copy_text_properties):
2108 Check for integer overflow in index calculation.
2109 * undo.c (last_boundary_position, record_point, record_insert)
2110 (record_delete, record_marker_adjustment, record_change)
2111 (record_property_change):
2112 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2113 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2115 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2116 (Fx_hide_tip, Fx_file_dialog):
2117 * w32menu.c (set_frame_menubar):
2118 Use ptrdiff_t, not int, for consistency with rest of code.
2119 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2120 (select_window, Fdelete_other_windows_internal)
2121 (window_scroll_pixel_based, window_scroll_line_based)
2122 (Frecenter, Fset_window_configuration):
2123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2124 (Fset_window_hscroll, run_window_configuration_change_hook)
2125 (set_window_buffer, temp_output_buffer_show, scroll_command)
2126 (Fscroll_other_window, Frecenter):
2127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2128 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2129 Don't assume fixnum fits in int.
2130 (Fset_window_scroll_bars):
2131 Check that fixnums are in proper range for system types.
2132 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2133 (string_pos, c_string_pos, number_of_chars, init_iterator)
2134 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2135 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2136 (compute_display_string_end, handle_face_prop)
2137 (face_before_or_after_it_pos, handle_invisible_prop)
2138 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2139 (display_prop_intangible_p, string_buffer_position_lim)
2140 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2141 (get_overlay_strings_1, get_overlay_strings)
2142 (iterate_out_of_display_property, forward_to_next_line_start)
2143 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2144 (get_next_display_element, set_iterator_to_next)
2145 (get_visually_first_element, compute_stop_pos_backwards)
2146 (handle_stop_backwards, next_element_from_buffer)
2147 (move_it_in_display_line_to, move_it_in_display_line)
2148 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2149 (add_to_log, message_dolog, message_log_check_duplicate)
2150 (message2, message2_nolog, message3, message3_nolog
2151 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2152 (current_message_1, truncate_echo_area, truncate_message_1)
2153 (set_message, set_message_1, store_mode_line_noprop)
2154 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2155 (text_outside_line_unchanged_p, check_point_in_composition)
2156 (reconsider_clip_changes)
2157 (redisplay_internal, set_cursor_from_row, try_scrolling)
2158 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2159 (redisplay_window, find_last_unchanged_at_beg_row)
2160 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2161 (trailing_whitespace_p, find_row_edges, display_line)
2162 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2163 (display_mode_element, store_mode_line_string)
2164 (pint2str, pint2hrstr, decode_mode_spec)
2165 (display_count_lines, display_string, draw_glyphs)
2166 (x_produce_glyphs, x_insert_glyphs)
2167 (rows_from_pos_range, mouse_face_from_buffer_pos)
2168 (fast_find_string_pos, mouse_face_from_string_pos)
2169 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2171 (safe_call, init_from_display_pos, handle_fontified_prop)
2172 (handle_single_display_spec, load_overlay_strings)
2173 (with_echo_area_buffer, setup_echo_area_for_printing)
2174 (display_echo_area, echo_area_display)
2175 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2176 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2177 (redisplay_window, dump_glyph_row, display_mode_line)
2178 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2179 (handle_display_spec, display_prop_string_p):
2180 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2181 (handle_single_display_spec, build_desired_tool_bar_string)
2182 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2183 (get_specified_cursor_type):
2184 Check that fixnums are in proper range for system types.
2185 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2186 (Flookup_image_map):
2187 Don't assume fixnums fit in int.
2188 (compare_overlay_entries):
2189 Avoid mishandling comparisons due to subtraction overflow.
2190 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2191 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2192 (handle_tool_bar_click):
2193 Use int, not unsigned, since we prefer signed and the signedness
2194 doesn't matter here.
2195 (get_next_display_element, next_element_from_display_vector):
2196 Use int, not EMACS_INT, when int is wide enough.
2197 (start_hourglass): Use duration_to_sec_usec to do proper
2198 overflow checking on durations.
2199 * xfaces.c (Fbitmap_spec_p):
2200 Check that fixnums are in proper range for system types.
2201 (compare_fonts_by_sort_order):
2202 Avoid mishandling comparisons due to subtraction overflow.
2203 (Fx_family_fonts, realize_basic_faces):
2204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2206 Don't assume fixnum fits in int.
2207 Use SAFE_ALLOCA_LISP, not alloca.
2208 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2209 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2210 (face_at_buffer_position, face_for_overlay_string)
2211 (face_at_string_position):
2212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2213 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2214 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2216 Check that fixnums are in proper range for system types.
2217 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2218 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2220 (Fx_change_window_property): Don't assume fixnums fit in int.
2221 * xfont.c (xfont_chars_supported):
2222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2223 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2224 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2226 * xml.c (parse_region):
2227 * xrdb.c (magic_file_p):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2230 (x_get_local_selection, x_reply_selection_request)
2231 (x_handle_selection_request, wait_for_property_change):
2232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2233 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2234 short is wide enough.
2235 (x_send_client_event): Don't assume fixnum fits in int.
2236 * xterm.c (x_x_to_emacs_modifiers):
2237 Don't assume EMACS_INT overflows nicely into int.
2238 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2240 (handle_one_xevent): NATNUMP can eval its arg twice.
2241 (x_connection_closed):
2242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2243 * xterm.h: Adjust decls to match defn changes elsewhere.
2244 (struct scroll_bar): Use struct vectorlike_header
2245 rather than rolling our own approximation.
2246 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2248 2012-05-25 Glenn Morris <rgm@gnu.org>
2250 * lisp.mk (lisp): Update for more files being compiled now.
2252 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2254 * lread.c: Remove `read_pure' which makes no difference.
2255 (read_pure): Remove var.
2256 (unreadpure): Remove function.
2257 (readevalloop): Don't call read_list with -1 flag.
2258 (read1, read_vector): Don't test read_pure any more.
2259 (read_list): Simplify.
2261 * fileio.c, character.h: Minor style tweaks.
2263 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2265 * window.h (clip_changed): Remove useless declaration.
2267 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2269 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2270 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2272 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2275 This directory predates autoconf and is no longer needed nowadays.
2276 Move its few remaining bits of functionality to where they're needed.
2277 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2278 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2279 * m/template.h: Remove.
2280 * Makefile.in (M_FILE): Remove. All uses removed.
2281 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2282 * lisp.h (USE_LSB_TAG):
2283 * mem-limits.h (EXCEEDS_LISP_PTR):
2284 Use VAL_MAX, not VALBITS, in #if.
2285 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2286 (EMACS_UINT): Define unconditionally now.
2287 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2288 (BITS_PER_EMACS_INT): New constants, replacing
2289 what used to be in config.h, but not useful in #if.
2290 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2291 define them any more.
2292 (VAL_MAX): New macro.
2294 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2295 BITS_PER_EMACS_INT, in #if.
2296 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2297 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2298 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2299 * s/ms-w32.h (DATA_START):
2300 Move here from removed file m/intel386.h.
2301 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2302 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2304 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2306 Assume C89 or later.
2307 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2308 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2310 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2311 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2312 * textprop.c, tparam.c (NULL): Remove.
2313 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2314 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2315 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2316 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2317 * xterm.c (input_signal_count): Assume volatile works.
2319 2012-05-21 Ken Brown <kbrown@cornell.edu>
2321 * xgselect.c (xg_select): Fix first argument in call to 'select'
2324 2012-05-20 Ken Brown <kbrown@cornell.edu>
2326 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2327 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2329 2012-05-19 Ken Brown <kbrown@cornell.edu>
2331 * xfns.c (x_in_use): Remove `static' qualifier.
2332 * xterm.h (x_in_use): Declare.
2333 * xgselect.c: Include xterm.h.
2334 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2335 and `display_arg' (bug#9754).
2337 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2339 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2341 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2342 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2344 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2346 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2348 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2349 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2351 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2352 reference to image_cache->refcount.
2353 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2355 2012-05-17 Juri Linkov <juri@jurta.org>
2357 * search.c (Fword_search_regexp, Fword_search_backward)
2358 (Fword_search_forward, Fword_search_backward_lax)
2359 (Fword_search_forward_lax): Move functions to isearch.el
2360 (bug#10145, bug#11381).
2362 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2364 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2366 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2368 * lread.c (init_obarray): Declare Qt and Qnil as special.
2370 2012-05-14 Glenn Morris <rgm@gnu.org>
2372 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2373 Put "libexec" before "bin", for the sake of init_callproc_1.
2375 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2377 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2379 * unexaix.c: Port to more-recent AIX compilers.
2380 (report_error, report_error_1, make_hdr, copy_sym)
2381 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2382 Make arguments const char *, not char *, to avoid violations of C
2383 standard and to fix some AIX warnings reported by Gilles Pion.
2385 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2387 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2388 already have overlays loaded.
2389 (handle_single_display_spec): Before returning without displaying
2390 fringe bitmap, synchronize the bidi iterator with the main display
2391 iterator, by calling iterate_out_of_display_property.
2392 (iterate_out_of_display_property): Detect buffer iteration by
2393 testing that it->string is a Lisp string.
2394 (get_next_display_element): When the current object is exhausted,
2395 and there's something on it->stack, call set_iterator_to_next to
2396 proceed with what's on the stack, instead of returning zero.
2397 (set_iterator_to_next): If called at the end of a Lisp string,
2398 proceed to consider_string_end without incrementing string
2399 position. Don't increment display vector index past the end of
2400 the display vector. (Bug#11417)
2401 (pos_visible_p): Don't report a position visible when move_it_to
2402 stopped at the last line of window, which happens to be scanned
2403 backwards by the bidi iteration. (Bug#11464)
2405 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2407 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2408 and right-margin display specs even if the spec is invalid or we
2409 are on a TTY, and thus unable to display on the fringes.
2410 That's because the text with the property will not be displayed anyway,
2411 so we need to signal to the caller that this is a "replacing"
2412 display spec. This fixes display when the spec is invalid or we
2415 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2417 * unexaix.c (make_hdr): Fix typo in prototype.
2418 This bug broke the build on AIX. Problem reported by Gilles Pion.
2420 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2422 * keyboard.c (kbd_buffer_get_event): Read special events also in
2423 batch mode. (Bug#11415)
2425 2012-05-12 Glenn Morris <rgm@gnu.org>
2427 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2429 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2431 * lisp.mk (lisp): Add newcomment.elc.
2433 2012-05-12 Glenn Morris <rgm@gnu.org>
2435 * Makefile.in (MKDIR_P): New, set by configure.
2436 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2438 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2440 Remove unused function hourglass_started.
2441 * dispextern.h (hourglass_started):
2442 * w32fns.c (hourglass_started):
2443 * xdisp.c (hourglass_started): Remove.
2445 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2447 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2448 Update dependencies.
2450 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2452 * xgselect.c (xg_select): Put maxfds+1 into a var.
2453 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2455 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2457 2012-05-10 Dave Abrahams <dave@boostpro.com>
2459 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2460 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2462 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2464 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2465 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2466 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2467 Initialize xd_registered_buses.
2469 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2471 Untag more efficiently if USE_LSB_TAG.
2472 This is based on a proposal by YAMAMOTO Mitsuharu in
2473 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2474 For an admittedly artificial (nth 8000 longlist) benchmark on
2475 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2476 Emacs's overall text size by 1%.
2477 * lisp.h (XUNTAG): New macro.
2478 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2479 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2480 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2481 * eval.c (Fautoload):
2482 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2483 * frame.h (XFRAME): Use XUNTAG.
2485 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2486 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2487 Remove unportable assumptions about print widths of types like
2489 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2490 intptr_t when converting between pointer and integer, to avoid GCC
2491 warnings about wrong width.
2493 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2495 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2496 stack for each reader_thread, instead of defaulting to 8MB
2497 determined by the linker. This avoids failures in creating
2498 subprocesses on Windows 7, see the discussion in this thread:
2499 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2501 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2503 Fix up display of the *Minibuf-0* buffer in the mini window.
2504 * keyboard.c (read_char): Don't clear the echo area if there's no
2506 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2507 contents of *Minibuf-0*) if there's no message displayed in its stead.
2509 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2511 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2514 2012-05-06 Chong Yidong <cyd@gnu.org>
2516 * lisp.mk (lisp): Update.
2518 2012-05-05 Jim Meyering <meyering@redhat.com>
2520 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2522 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2524 * data.c (PUT_ERROR): New macro.
2525 (syms_of_data): Use it. Add new error type `user-error'.
2526 * undo.c (user_error): New function.
2527 (Fprimitive_undo): Use it.
2528 * print.c (print_error_message): Adjust print style for `user-error'.
2529 * keyboard.c (user_error): New function.
2530 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2532 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2534 Do not limit current-time-string to years 1000..9999.
2535 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2536 (Fcurrent_time_string): Support any year that is supported by the
2537 underlying localtime representation. Don't use asctime, as it
2538 has undefined behavior for years outside the range -999..9999.
2540 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2542 Fix race conditions involving setenv, gmtime, localtime, asctime.
2543 Without this fix, interrupts could mess up code that uses these
2544 nonreentrant functions, since setting TZ invalidates existing
2545 tm_zone or tzname values, and since most of these functions return
2546 pointers to static storage.
2547 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2548 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2549 Grow the critical sections to include not just invoking
2550 localtime/gmtime, but also accessing these functions' results
2551 including their tm_zone values if any, and any related TZ setting.
2552 (format_time_string): Last arg is now struct tm *, not struct tm **,
2553 so that the struct tm is saved in the critical section.
2554 All callers changed. Simplify allocation of initial buffer, partly
2555 motivated by the fact that memory allocation needs to be outside
2556 the critical section.
2558 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2560 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2561 with RESET_INTERVAL.
2563 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2564 Remove duplicated buffer name initialization.
2566 2012-05-02 Jim Meyering <jim@meyering.net>
2568 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2570 * xfns.c (x_window): Use xstrdup (Bug#11375).
2572 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2574 * xdisp.c (pos_visible_p): If already at a newline from the
2575 display string before the 'while' loop, don't walk back the glyphs
2576 from it3.glyph_row. Solves assertion violation when the display
2577 string begins with a newline (egg.el). (Bug#11367)
2579 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2581 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2584 2012-05-01 Glenn Morris <rgm@gnu.org>
2586 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2587 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2588 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2589 All were removed before 23.1.
2591 * dispnew.c: Remove HAVE_LIBNCURSES test;
2592 it is always true on relevant platforms.
2594 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2595 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2597 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2599 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2601 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2602 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2605 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2607 Do not avoid creating empty evaporating overlays (Bug#9642).
2608 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2609 That is, do not delete an evaporating overlay if it becomes
2610 empty after its bounds are adjusted to fit within its buffer.
2611 This fix caused other problems, and I'm reverting it until we get
2612 to the bottom of them.
2614 2012-04-27 Chong Yidong <cyd@gnu.org>
2616 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2618 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2620 * xdisp.c (pos_visible_p): If the window start position is beyond
2621 ZV, start the display from buffer beginning. Prevents assertion
2622 violation in init_iterator when the minibuffer window is scrolled
2625 * window.c (window_scroll_pixel_based): Likewise.
2627 2012-04-27 Chong Yidong <cyd@gnu.org>
2629 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2631 2012-04-27 Glenn Morris <rgm@gnu.org>
2633 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2634 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2636 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2638 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2639 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2641 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2643 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2644 display element, check also the underlying string or buffer
2645 character. (Bug#11341)
2647 * w32menu.c: Include w32heap.h.
2648 (add_menu_item): If the call to AppendMenuW (via
2649 unicode_append_menu) fails, disable Unicode menus only if we are
2650 running on Windows 9X/Me.
2652 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2654 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2655 (xgetint): Add missing shift for LSB tags.
2657 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2659 * keyboard.c (read_char): Don't wipe echo area for select window
2660 events: These might get delayed via `mouse-autoselect-window'
2663 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2665 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2666 manipulation of :loaded-from data.
2668 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2670 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2671 now a cons (bug#11311).
2673 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2675 Do not create empty overlays with the evaporate property (Bug#9642).
2676 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2677 if it becomes empty after its bounds are adjusted to fit within
2678 its buffer. Without this fix, in a nonempty buffer (let ((o
2679 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2680 yields an empty overlay that has the evaporate property, which is
2681 not supposed to happen.
2683 Fix minor GTK3 problems found by static checking.
2684 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2685 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2686 (struct _EmacsFixedClass, emacs_fixed_get_type):
2687 Move decls here from emacsgtkfixed.h, since they needn't be public.
2688 (emacs_fixed_get_type): Now static.
2689 (emacs_fixed_class_init): Omit unused local.
2690 (emacs_fixed_child_type): Remove; unused.
2691 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2692 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2693 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2694 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2695 (EMACS_FIXED_GET_CLASS): Remove; unused.
2696 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2698 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2699 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2701 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2703 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2704 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2705 (__malloc_size_t, __malloc_ptrdiff_t):
2706 Remove. All uses removed, replaced by the definiens if needed,
2707 since we can assume C89 or better now.
2708 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2709 (protect_malloc_state, align, get_contiguous_space)
2710 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2711 (malloc_atfork_handler_child, malloc_enable_thread)
2712 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2713 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2714 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2715 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2716 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2717 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2718 Define using prototypes, not old style.
2719 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2720 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2721 (align): Don't assume that signed integer overflow wraps around.
2722 Omit unused local var.
2723 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2724 (_free_internal_nolock, memalign, mallochook, reallochook):
2725 Omit no-longer-needed casts.
2726 (valloc): Use getpagesize, not __getpagesize.
2727 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2728 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2730 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2732 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2734 Move functions from C to Lisp. Make non-blocking method calls
2735 the default. Implement further D-Bus standard interfaces.
2737 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2738 (QCdbus_request_name_allow_replacement)
2739 (QCdbus_request_name_replace_existing)
2740 (QCdbus_request_name_do_not_queue)
2741 (QCdbus_request_name_reply_primary_owner)
2742 (QCdbus_request_name_reply_in_queue)
2743 (QCdbus_request_name_reply_exists)
2744 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2745 (QCdbus_registered_serial, QCdbus_registered_method)
2746 (QCdbus_registered_signal): New Lisp objects.
2747 (XD_DEBUG_MESSAGE): Use sizeof.
2748 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2749 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2750 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2751 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2752 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2753 (xd_signature, xd_append_arg): Allow float for integer types.
2754 (xd_get_connection_references): New function.
2755 (xd_get_connection_address): Rename from xd_initialize.
2756 Return cached address.
2757 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2758 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2760 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2761 Return number of refcounts.
2762 (Fdbus_get_unique_name): Make stronger parameter check.
2763 (Fdbus_message_internal): New defun.
2764 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2765 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2766 (Fdbus_send_signal, Fdbus_register_service)
2767 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2768 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2769 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2770 (Vdbus_compiled_version, Vdbus_runtime_version)
2771 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2772 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2773 (Vdbus_message_type_signal): New defvars.
2774 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2777 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2779 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2780 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2781 Do not assume ptrdiff_t is the same width as 'int'.
2783 * alloc.c: Handle unusual debugging option combinations.
2784 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2785 since the two debugging options are incompatible.
2786 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2788 (mem_init, mem_insert, mem_insert_fixup):
2789 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2790 (NEED_MEM_INSERT): Remove; no longer needed.
2792 2012-04-22 Leo Liu <sdl.web@gmail.com>
2794 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2796 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2798 * sysdep.c [__FreeBSD__]: Minor cleanups.
2799 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2800 Use Emacs indenting style more consistently. Avoid some casts.
2801 Use 'double' consistently rather than mixing 'float' and 'double'.
2803 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2805 * sysdep.c (list_system_processes, system_process_attributes):
2806 Add implementation for FreeBSD (Bug#5243).
2808 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2810 * lisp.mk (lisp): Update.
2812 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2814 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2815 It is never used otherwise.
2817 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2819 * print.c (print_preprocess): Only check print_depth if print-circle
2821 (print_object): Check for cycles even when print-circle is nil and
2822 print-gensym is t, but only check print_depth if print-circle is nil.
2824 2012-04-20 Chong Yidong <cyd@gnu.org>
2826 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2827 set the status to "failed" and ensure that sentinel is run.
2829 2012-04-20 Glenn Morris <rgm@gnu.org>
2831 * process.c (Fset_process_inherit_coding_system_flag)
2832 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2833 (Fmake_network_process, Fmake_serial_process): Doc fix.
2835 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2837 * xdisp.c (string_buffer_position_lim): Limit starting position to
2839 (set_cursor_from_row): If called for a mode-line or header-line
2840 row, return zero immediately.
2841 (try_cursor_movement): If inside continuation line, don't back up
2842 farther than the first row after the header line, if any.
2843 Don't consider the header-line row as "partially visible", even if
2844 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2846 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2848 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2851 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2852 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2854 configure: new option --enable-gcc-warnings (Bug#11207)
2855 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2856 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2857 (ALL_CFLAGS): Use new macros rather than old.
2858 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2859 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2860 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2861 -Wunused-result, -Wunused-variable. This should go away once
2862 the Emacs and Gnulib regex code is merged.
2863 (xmalloc, xrealloc): Now static.
2865 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2867 * dired.c (Fsystem_groups): Remove unused local.
2869 2012-04-17 Glenn Morris <rgm@gnu.org>
2871 * dired.c (Fsystem_users): Doc fix.
2873 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2875 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2876 (syms_of_dired): Add them.
2878 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2880 Fix minor alloc.c problems found by static checking.
2881 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2882 New extern decls, to avoid calling undeclared functions.
2883 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2884 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2885 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2886 (NEED_MEM_INSERT): New macro.
2887 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2888 Remove one incorrect comment and fix another.
2890 Fix minor ralloc.c problems found by static checking.
2891 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2892 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2893 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2894 (r_alloc_sbrk): Now static.
2896 Improve ralloc.c interface checking.
2897 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2898 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2899 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2900 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2901 [REL_ALLOC]: ... to here, to check interface.
2902 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2903 Remove decls. This fixes an "It stinks!".
2905 * alloc.c (which_symbols): Fix alignment issue / type clash.
2907 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2909 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2910 (struct Lisp_Misc_Any): Likewise.
2911 (struct Lisp_Free): Likewise.
2912 * alloc.c (union aligned_Lisp_Symbol): Define.
2913 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2914 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2915 (union aligned_Lisp_Misc): Define.
2916 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2917 aligned_Lisp_Misc instead of union Lisp_Misc.
2918 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2920 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2922 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2923 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2924 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2925 * s/netbsd.h, s/sol2-6.h:
2926 Remove definition of GC_MARK_STACK, since the default now works.
2927 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2928 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2929 no longer the default.
2930 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2932 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2934 * lread.c (lisp_file_lexically_bound_p):
2935 Fix hang at ";-*-\n" (bug#11238).
2937 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2939 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2940 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2942 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2944 * nsterm.m (constrainFrameRect): Always constrain when there is only
2945 one screen (Bug#10962).
2947 2012-04-13 Ken Brown <kbrown@cornell.edu>
2949 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2951 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2953 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2955 2012-04-11 Daniel Colascione <dancol@dancol.org>
2957 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2958 against is gone. It's better to use vfork now so that when Cygwin
2959 gains a new, working vfork, we use it automatically (bug#10398).
2961 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2963 * window.c (save_window_save): Obey window-point-insertion-type.
2965 2012-04-11 Glenn Morris <rgm@gnu.org>
2967 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2969 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2971 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2973 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2975 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2976 (force_quit_count): New var.
2977 (handle_interrupt): Use it.
2979 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2981 * w32.c (w32_delayed_load): Record the full path of the library
2982 being loaded (bug#10424).
2984 2012-04-09 Glenn Morris <rgm@gnu.org>
2986 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2987 not just in the obarray, before snarfing them. (Bug#11036)
2989 * Makefile.in ($(leimdir)/leim-list.el):
2990 Pass EMACS rather than BUILT_EMACS.
2992 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2994 * process.c (make_process):
2995 * process.h: Add integer `gnutls_handshakes_tried' member to
2998 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2999 Add convenience `GNUTLS_LOG2i' macro.
3001 * gnutls.c (gnutls_log_function2i): Convenience log function.
3002 (emacs_gnutls_read): Use new log functions,
3003 `gnutls_handshakes_tried' process member, and
3004 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3005 attempts per process (connection).
3007 2012-04-09 Chong Yidong <cyd@gnu.org>
3009 * eval.c (Fuser_variable_p, user_variable_p_eh)
3010 (lisp_indirect_variable): Functions deleted.
3011 (Fdefvar): Caller changed.
3013 * callint.c (Finteractive, Fcall_interactively):
3014 * minibuf.c (Fread_variable): Callers changed.
3016 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3018 * xdisp.c (set_cursor_from_row): If the display string appears in
3019 the buffer at position that is closer to point than the position
3020 after the display string, display the cursor on the first glyph of
3021 the display string. Fixes cursor display when a 'display' text
3022 property immediately follows invisible text. (Bug#11094)
3024 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3026 composite.c: use 'double' consistently
3027 * composite.c (get_composition_id): Use 'double' consistently
3028 instead of converting 'float' to 'double' and vice versa; this is
3029 easier to understand and avoids a GCC warning.
3031 2012-04-09 Glenn Morris <rgm@gnu.org>
3033 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3034 preparation for dumping it with emacs. (Bug#4789)
3035 (leimdir): New variable.
3036 ($(leimdir)/leim-list.el): New rule.
3037 (emacs$(EXEEXT)): Depend on leim-list.el.
3039 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3040 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3041 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3043 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3045 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3048 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3050 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3051 Remove unused local variable.
3053 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3055 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3056 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3057 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3058 objects, as mark_maybe_pointer will catch them otherwise.
3059 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3060 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3062 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3064 Fix typo that broke non-Windows builds.
3065 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3067 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3069 Support building on MS-Windows with libxml2.
3071 * makefile.w32-in (OBJ2): Add xml.$(O).
3072 (GLOBAL_SOURCES): Add xml.c.
3073 ($(BLD)/xml.$(O)): New dependency list.
3075 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3076 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3077 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3078 [!WINDOWSNT]: New macros.
3079 (init_libxml2_functions, libxml2_loaded_p): New functions.
3080 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3081 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3082 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3083 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3085 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3086 Call init_libxml2_functions before calling libxml2 functions.
3087 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3089 * emacs.c: Don't include libxml/parser.h.
3090 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3091 xmlCleanupParser directly.
3093 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3095 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3097 * indent.c (Fvertical_motion): If there is a display string at
3098 point, use it.vpos to compute how many lines to backtrack after
3099 move_it_to point. (Bug#11133)
3101 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3103 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3104 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3105 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3106 macros related to unification of CJK characters. For the details,
3107 see the discussion following the message here:
3108 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3110 2012-04-04 Chong Yidong <cyd@gnu.org>
3112 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3114 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3116 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3117 instead of alloca. (Bug#11138)
3119 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3121 * w32menu.c (is_simple_dialog): Properly check lisp types.
3124 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3126 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3127 position we get to after a call to move_it_to fails the
3128 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3129 only if we wind up in a string from display property. (Bug#11063)
3131 * window.c (Fdelete_other_windows_internal): Invalidate the row
3132 and column information about mouse highlight, so that redisplay
3133 restores it after reallocating the glyph matrices. (Bug#7464)
3135 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3136 string comes from a `display' text property, use the buffer
3137 position of that property as if we actually saw that position in
3139 (move_it_by_lines): Remove the assertion that
3140 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3141 violated when there's a before-string at the beginning of a line.
3144 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3146 * xdisp.c (append_space_for_newline): If the default face was
3147 remapped, use the remapped face for the appended newline.
3148 (extend_face_to_end_of_line): Use the remapped default face for
3149 extending the face to the end of the line.
3150 (display_line): Call extend_face_to_end_of_line when the default
3151 face was remapped. (Bug#11068)
3153 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3155 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3157 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3159 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3161 2012-03-27 Glenn Morris <rgm@gnu.org>
3163 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3166 2012-03-26 Kenichi Handa <handa@m17n.org>
3168 * dispextern.h (struct glyph): Fix previous change. Change the
3169 bit length of glyphless.ch to 25 (Bug#11082).
3171 2012-03-26 Chong Yidong <cyd@gnu.org>
3173 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3174 (command_loop_1): Use it; inhibit selection update for
3175 handle-select-window too (Bug#8996).
3177 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3179 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3181 2012-03-25 Kenichi Handa <handa@m17n.org>
3183 * dispextern.h (struct glyph): Change the bit length of
3184 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3186 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3188 * s/ms-w32.h (tzname): Include time.h before redirecting to
3189 _tzname. Fixes the MSVC build. (Bug#9960)
3191 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3193 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3196 * xterm.c (XTread_socket): Only modify handling_signal if
3197 !SYNC_INPUT. (Bug#11080)
3199 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3201 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3202 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3203 when fetching a multibyte character consumes more bytes than
3204 CHAR_BYTES returns, due to unification of CJK characters in
3205 string_char. (Bug#11073)
3207 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3209 * process.c (wait_reading_process_output): Handle pty disconnect
3210 by refraining from sending oneself a SIGCHLD (bug#10933).
3212 2012-03-22 Chong Yidong <cyd@gnu.org>
3214 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3216 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3217 Mark string as coming from a prefix property.
3218 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3219 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3221 2012-03-21 Chong Yidong <cyd@gnu.org>
3223 * xfaces.c (Vface_remapping_alist): Doc fix.
3225 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3227 * w32proc.c (Fw32_set_console_codepage)
3228 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3231 2012-03-20 Chong Yidong <cyd@gnu.org>
3233 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3234 to reflect default non-nil value of redisplay-dont-pause.
3236 2012-03-19 Kenichi Handa <handa@m17n.org>
3238 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3239 it fit in a valid range (Bug#11003).
3241 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3243 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3244 that is not from display property, accept the row as a "cursor
3245 row" if one of the string's character has a non-nil `cursor'
3246 property. Fixes cursor positioning when there are newlines in
3247 overlay strings, e.g. in icomplete.el. (Bug#11035)
3249 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3251 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3253 2012-03-12 Chong Yidong <cyd@gnu.org>
3255 * eval.c (inhibit_lisp_code): Rename from
3256 inhibit_window_configuration_change_hook; move from window.c.
3258 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3259 * window.c (run_window_configuration_change_hook)
3260 (syms_of_window): Callers changed.
3262 2012-03-11 Chong Yidong <cyd@gnu.org>
3264 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3266 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3268 2012-03-10 Chong Yidong <cyd@gnu.org>
3270 * frame.c (other_visible_frames): Don't assume the selected frame
3271 is visible (Bug#10955).
3273 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3275 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3277 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3279 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3280 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3283 2012-03-03 Glenn Morris <rgm@gnu.org>
3285 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3287 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3289 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3290 position past the first glyph_row that ends at ZV. (Bug#10902)
3291 (redisplay_window, next_element_from_string): Fix typos in
3293 (redisplay_window): Pass to move_it_vertically the margin in
3294 pixels, not in screen lines.
3296 2012-03-02 Glenn Morris <rgm@gnu.org>
3298 * buffer.c (buffer-list-update-hook): Doc fix.
3300 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3302 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3303 push_it before setting up the iterator for the first overlay
3304 string, even if we have an empty string loaded.
3305 (next_overlay_string): If there's an empty string on the iterator
3306 stack, pop the stack. (Bug#10903)
3308 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3310 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3311 Suggested by Stefan Monnier in
3312 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3313 * alloc.c (widen_to_Lisp_Object): New static function.
3314 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3315 and widening them to Lisp_Objects. This would work even if
3316 USE_LSB_TAG is defined and wide integers are used, which might
3317 happen in a future version of Emacs.
3319 2012-02-25 Chong Yidong <cyd@gnu.org>
3321 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3324 * xselect.c (Fx_selection_exists_p): Doc fix.
3325 (x_clipboard_manager_save_all): Print an informative message
3326 before saving to clipboard manager.
3328 2012-02-24 Chong Yidong <cyd@gnu.org>
3330 * keyboard.c (process_special_events): Handle all X selection
3331 requests in kbd_buffer, not just the next one (Bug#8869).
3333 2012-02-23 Chong Yidong <cyd@gnu.org>
3335 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3336 call when setting menu-bar-lines and tool-bar-lines parameters.
3337 (unwind_create_frame_1): New helper function.
3339 * window.c (inhibit_window_configuration_change_hook): New var.
3340 (run_window_configuration_change_hook): Obey it.
3341 (syms_of_window): Initialize it.
3343 2012-02-22 Chong Yidong <cyd@gnu.org>
3345 * xterm.c (x_draw_image_relief): Add missing type check for
3346 Vtool_bar_button_margin (Bug#10743).
3348 2012-02-21 Chong Yidong <cyd@gnu.org>
3350 * fileio.c (Vfile_name_handler_alist): Doc fix.
3352 * buffer.c (Fget_file_buffer): Protect against invalid file
3353 handler return value.
3355 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3357 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3358 when computing $valmask.
3360 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3361 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3362 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3363 It's useless in that case, and it can cause problems on hosts
3364 that allocate halves of EMACS_INT values separately.
3365 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3366 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3367 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3368 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3369 it avoids undefined behavior on hosts where shifting right by more
3370 than the word width has undefined behavior.
3372 2012-02-19 Chong Yidong <cyd@gnu.org>
3374 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3375 (Funhandled_file_name_directory, Ffile_name_as_directory)
3376 (Fdirectory_file_name, Fexpand_file_name)
3377 (Fsubstitute_in_file_name): Protect against invalid file handler
3378 return values (Bug#10845).
3380 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3382 * .gdbinit (pitx): Fix incorrect references to fields of the
3385 2012-02-17 Chong Yidong <cyd@gnu.org>
3387 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3389 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3391 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3392 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3394 2012-02-15 Chong Yidong <cyd@gnu.org>
3396 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3397 marked as special. Also, starting docstrings with * is obsolete.
3399 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3401 * gnutls.c (emacs_gnutls_write): Fix last change.
3403 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3405 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3408 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3410 * keymap.c (Fsingle_key_description): Handle char ranges.
3412 2012-02-12 Chong Yidong <cyd@gnu.org>
3414 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3415 as that creates a dangerous corner case.
3417 * window.c (Fdelete_window_internal): Invalidate the mouse
3418 highlight (Bug#9904).
3420 2012-02-12 Glenn Morris <rgm@gnu.org>
3422 * xselect.c (Fx_own_selection_internal)
3423 (Fx_get_selection_internal, Fx_disown_selection_internal)
3424 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3425 * nsselect.m (Fx_own_selection_internal)
3426 (Fx_disown_selection_internal, Fx_selection_exists_p)
3427 (Fx_selection_owner_p, Fx_get_selection_internal):
3428 Sync docs and argument specs with the xselect.c versions.
3430 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3432 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3434 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3436 * w32select.c (Fx_selection_exists_p): Sync doc string and
3437 argument list with xselect.c. (Bug#10783)
3439 * w16select.c (Fx_selection_exists_p): Sync doc string and
3440 argument list with xselect.c. (Bug#10783)
3442 2012-02-10 Glenn Morris <rgm@gnu.org>
3444 * fns.c (Fsecure_hash): Doc fix.
3446 2012-02-09 Kenichi Handa <handa@m17n.org>
3448 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3450 2012-02-07 Chong Yidong <cyd@gnu.org>
3452 * buffer.c (Fbuffer_local_variables)
3453 (buffer_lisp_local_variables): Handle unbound vars correctly;
3454 don't let Qunbound leak into Lisp.
3456 2012-02-07 Glenn Morris <rgm@gnu.org>
3458 * image.c (Fimagemagick_types): Doc fix.
3460 * image.c (imagemagick-render-type): Change it from a lisp object
3461 to an integer. Move the doc here from the lisp manual.
3462 Treat all values not equal to 0 the same.
3464 2012-02-06 Chong Yidong <cyd@gnu.org>
3466 * doc.c (store_function_docstring): Avoid applying docstring of
3467 alias to base function (Bug#2603).
3469 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3471 * .gdbinit (pp1, pv1): Remove redundant defines.
3474 2012-02-04 Chong Yidong <cyd@gnu.org>
3476 * nsterm.m: Declare a global (Bug#10694).
3478 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3480 * w32.c (get_emacs_configuration_options):
3481 Include --enable-checking, if specified, in the return value.
3483 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3485 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3486 after rounding frame sizes. (Bug#9723)
3488 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3490 * keyboard.c (adjust_point_for_property): Don't position point
3491 before BEGV. (Bug#10696)
3493 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3495 Handle overflow when computing char display width (Bug#9496).
3496 * character.c (char_width): Return EMACS_INT, not int.
3497 (char_width, c_string_width): Check for overflow when
3498 computing the width; this is possible now that individual
3499 characters can have unbounded width. Problem introduced
3500 by merge from Emacs 23 on 2012-01-19.
3502 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3504 * dbusbind.c (Fdbus_register_method): Mention the return value
3505 :ignore in the docstring.
3507 2012-02-02 Glenn Morris <rgm@gnu.org>
3509 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3511 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3512 Unconditionally set to t. (Bug#10673)
3513 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3514 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3515 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3517 2012-02-02 Kenichi Handa <handa@m17n.org>
3519 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3520 0, do not call append_composite_glyph.
3522 2012-02-02 Kenichi Handa <handa@m17n.org>
3524 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3526 (x_produce_glyphs): If the component of a composition is a null
3527 string, set it->pixel_width to 1 to avoid zero-width glyph.
3529 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3531 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3532 first 2 arguments are identical. This makes inserting large
3533 output from a subprocess an order of magnitude faster on
3534 MS-Windows, where all sbrk'ed memory is always contiguous.
3536 2012-01-31 Glenn Morris <rgm@gnu.org>
3538 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3539 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3540 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3542 2012-01-29 Glenn Morris <rgm@gnu.org>
3544 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3546 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3548 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3550 2012-01-28 Chong Yidong <cyd@gnu.org>
3552 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3554 2012-01-26 Chong Yidong <cyd@gnu.org>
3556 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3558 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3559 repeat counts (Bug#10507).
3561 2012-01-26 Glenn Morris <rgm@gnu.org>
3563 * lread.c (syms_of_lread): Doc fix.
3565 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3567 * coding.c (encode_designation_at_bol): Change return value to
3570 2012-01-25 Chong Yidong <cyd@gnu.org>
3572 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3574 2012-01-21 Chong Yidong <cyd@gnu.org>
3576 * floatfns.c (Fcopysign): Make the second argument non-optional,
3577 since nil is not allowed anyway.
3579 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3581 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3582 (send_process): Likewise.
3584 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3586 * window.c (save_window_save, Fcurrent_window_configuration)
3587 (Vwindow_persistent_parameters): Do not use Qstate.
3588 Rewrite doc-strings.
3590 2012-01-19 Kenichi Handa <handa@m17n.org>
3592 * character.c (char_width): New function.
3593 (Fchar_width, c_string_width, lisp_string_width):
3594 Use char_width (Bug#9496).
3596 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3598 * window.c (Vwindow_persistent_parameters): New variable.
3599 (Fset_window_configuration, save_window_save): Handle persistent
3602 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3604 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3605 thrashing the stack of the thread. (Bug#9087)
3607 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3609 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3611 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3613 * xdisp.c (rows_from_pos_range): Handle the case where the
3614 highlight ends on a newline. (Bug#10464)
3615 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3616 he end column for display of highlight that ends on a newline
3619 2012-01-11 Glenn Morris <rgm@gnu.org>
3621 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3622 from load-path also when installation-directory is nil. (Bug#10208)
3624 2012-01-10 Glenn Morris <rgm@gnu.org>
3626 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3628 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3629 Update template values to be closer to their typical values these days.
3631 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (rows_from_pos_range): Accept additional argument
3634 DISP_STRING, and accept any glyph in a row whose object is that
3635 string as eligible for mouse highlight. Fixes mouse highlight of
3636 display strings from overlays. (Bug#10464)
3638 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3640 emacs: fix an auto-save permissions race condition (Bug#10400)
3641 * fileio.c (auto_saving_dir_umask): New static var.
3642 (Fmake_directory_internal): Use it.
3643 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3644 creating the directory. The old code temporarily assigns
3645 too-generous permissions to the directory.
3646 (do_auto_save_eh): Clear it.
3647 (Fdo_auto_save): Catch all errors, not just file errors, so
3648 that the var is always cleared.
3650 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3652 * search.c (scan_buffer): Pass character positions to
3653 know_region_cache, not byte positions. (Bug#6540)
3655 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3657 * w32.c (sys_rename): Report EXDEV when rename of a directory
3658 fails because the target is on another logical disk. (Bug#10284)
3660 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3662 * xterm.c (x_embed_request_focus): New function.
3664 * xterm.h: Add prototype.
3666 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3668 2012-01-05 Glenn Morris <rgm@gnu.org>
3670 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3672 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3674 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3675 Load gnutls_transport_set_lowat only if GnuTLS version is below
3677 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3678 GnuTLS versions below 2.11.1.
3680 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3682 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3683 to the doc string advising against its use for altering the way
3684 windows are scrolled.
3686 2011-12-28 Kenichi Handa <handa@m17n.org>
3688 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3689 coding-system ASCII compatible only when it does not produce BOM
3690 on encoding (Bug#10383).
3692 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3694 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3696 (create_and_show_popup_menu): Always use menu_position_func for
3699 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3701 * callint.c (Fcall_interactively): Don't truncate prompt string.
3703 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3705 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3706 property that ends at ZV, so that the bidi iteration could be
3707 resumed from there (after widening). (Bug#10360)
3709 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3711 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3713 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3715 * nsterm.m (x_free_frame_resources):
3716 Release f->output_data.ns->miniimage.
3717 (ns_index_color): Fix indentation. Do not retain
3718 color_table->colors[i].
3720 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3723 * nsfns.m (x_set_background_color): Assign return value from
3724 ns_index_color to face-background instead of NSColor*.
3725 (ns_implicitly_set_icon_type): Fix indentation.
3726 Change assignment in for loop to comparison.
3728 * emacs.c (ns_pool): New variable.
3729 (main): Assign ns_pool.
3730 (Fkill_emacs): Call ns_release_autorelease_pool.
3732 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3733 autorelease fdesc, release fdAttrs and tdict.
3734 (ns_get_covering_families): Release charset.
3735 (ns_findfonts): Release NSFontDescriptor created with new.
3736 (ns_uni_to_glyphs): Fix indentation.
3737 (setString): Release attrStr before assigning new value.
3739 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3741 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3743 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3744 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3746 2011-12-18 David Reitter <reitter@cmu.edu>
3748 * nsterm.m (ns_term_init): Subscribe for notifications
3749 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3750 to method trackingNotification in EmacsMenu.
3752 * nsmenu.m (trackingMenu): New variable.
3753 (trackingNotification): New method (from Aquamacs).
3754 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3755 from Aquamacs (Bug#7030).
3757 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3759 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3760 (symbol_to_nsstring): Fix indentation.
3761 (ns_symbol_to_pb): New function.
3762 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3763 (Fns_rotate_cut_buffers_internal): Remove.
3764 (Fns_store_selection_internal): Rename from
3765 Fns_store_cut_buffer_internal.
3766 (ns_get_foreign_selection, Fx_own_selection_internal)
3767 (Fx_disown_selection_internal, Fx_selection_exists_p)
3768 (Fns_get_selection_internal, Fns_store_selection_internal):
3769 Use ns_symbol_to_pb and check if return value is nil.
3770 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3771 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3772 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3773 renamed to Sns_store_selection_internal.
3774 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3775 and remove this function.
3776 (ns_handle_selection_clear): Remove, never used.
3777 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3780 2011-12-17 Ken Brown <kbrown@cornell.edu>
3782 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3783 GID is unknown (Bug#10257).
3785 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3787 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3788 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3789 which caused a build failure on GNU/Linux IA-64. This problem was
3790 introduced by my 2011-10-07 patch.
3792 2011-12-15 Juri Linkov <juri@jurta.org>
3794 * image.c (imagemagick_error): New function. (Bug#10112)
3795 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3796 Use `imagemagick_error' where ImageMagick functions return
3798 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3801 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3803 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3804 fill background (Bug#8992).
3806 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3808 * window.c (Vwindow_combination_resize)
3809 (Vwindow_combination_limit): Use t instead of non-nil in
3811 (Vrecenter_redisplay): Add first sentence of doc-string on
3813 (Frecenter): Fix doc-string typo.
3815 2011-12-11 Kenichi Handa <handa@m17n.org>
3817 * coding.c (Funencodable_char_position): Pay attention to the
3818 buffer text relocation (Bug#9389).
3820 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3822 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3823 gtk_init (Bug#10100).
3825 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3827 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3828 IT->string is nil. (Bug#10263)
3830 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3832 * nsterm.h (x_free_frame_resources): Declare.
3834 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3835 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3837 * nsterm.h (ns_get_defaults_value): Declare.
3839 * nsterm.m (ns_default): Call ns_get_defaults_value.
3841 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3843 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3846 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3848 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3849 that where the value of an _OBJC_* symbol points to is in the .bss
3850 section (Bug#10240).
3852 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3854 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3855 after the loop to call ccl_driver at least once (Bug#8619).
3857 2011-12-08 Kenichi Handa <handa@m17n.org>
3859 * ftfont.c (get_adstyle_property): Fix previous change
3862 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3864 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3865 dirs from the default value of EMACSLOADPATH (bug#10208).
3867 2011-12-07 Glenn Morris <rgm@gnu.org>
3869 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3870 installation and source directories as well. (Bug#10208)
3872 2011-12-06 Chong Yidong <cyd@gnu.org>
3874 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3876 2011-12-06 Glenn Morris <rgm@gnu.org>
3878 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3879 as an error, not just -1. (Bug#10217)
3881 2011-12-05 Chong Yidong <cyd@gnu.org>
3883 * keyboard.c (process_special_events): New function.
3884 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3886 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3888 * coding.c (encode_designation_at_bol): Don't use uninitialized
3889 local variable (Bug#9318).
3891 2011-12-05 Kenichi Handa <handa@m17n.org>
3893 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3894 return Qnil (Bug#8046, Bug#10193).
3896 2011-12-05 Kenichi Handa <handa@m17n.org>
3898 * coding.c (encode_designation_at_bol): New args charbuf_end and
3899 dst. Return the number of produced bytes. Callers changed.
3900 (coding_set_source): Return how many bytes coding->source was
3902 (coding_set_destination): Return how many bytes
3903 coding->destination was relocated.
3904 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3905 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3907 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3909 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3910 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3913 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3915 The following changes are to fix Bug#9318.
3917 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3918 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3919 (encode_coding_iso_2022, encode_coding_sjis)
3920 (encode_coding_big5, encode_coding_charset): Use the above macros.
3922 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3924 * lisp.h (process_quit_flag): Fix external declaration.
3926 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3928 Don't macro-inline non-performance-critical code.
3929 * eval.c (process_quit_flag): New function.
3930 * lisp.h (QUIT): Use it.
3932 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3934 * nsfns.m (get_geometry_from_preferences): New function.
3935 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3937 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3939 * emacs.c (Qkill_emacs): Define.
3940 (syms_of_emacs): Initialize it.
3941 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3942 Qquit_flag to `kill-emacs' instead.
3943 (quit_throw_to_read_char): Add parameter `from_signal'.
3944 All callers changed. Call Fkill_emacs if requested and safe.
3945 * lisp.h (QUIT): Call Fkill_emacs if requested.
3947 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3949 * widget.c (update_wm_hints): Return if wmshell is null.
3950 (widget_update_wm_size_hints): New function.
3952 * widget.h (widget_update_wm_size_hints): Declare.
3954 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3955 widget_update_wm_size_hints (Bug#10104).
3957 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3959 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3960 before a newline, prepare the bidi iterator for consuming the
3961 newline, and keep the current paragraph direction. (Bug#10183)
3962 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3964 2011-12-02 Juri Linkov <juri@jurta.org>
3966 * search.c (Fword_search_regexp): New Lisp function created from
3967 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3968 (Fword_search_backward, Fword_search_forward)
3969 (Fword_search_backward_lax, Fword_search_forward_lax):
3970 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3971 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3973 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3975 * fileio.c (Finsert_file_contents): Move after-change-function call
3976 to before the "handled:" label, since all "goto handled" appear in
3977 cases where the *-change-functions have already been properly called
3980 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3982 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3983 waiting for input. (Bug#10169)
3985 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3987 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3988 verifies glyph row's hash code--we have just reallocated the
3989 glyphs, so their contents can be complete garbage. (Bug#10164)
3991 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3993 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3995 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3997 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3998 attributes are tested _before_ calling verify_row_hash, to protect
3999 against GCC re-ordering of the tests. (Bug#10164)
4001 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4003 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4005 * xterm.c (handle_one_xevent): Only set async_visible and friends
4006 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4007 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4008 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4010 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4012 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4013 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4014 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4015 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4016 All uses changed to use GCPRO1 etc.
4017 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4018 Revert to old implementation (i.e., before 2011-03-11).
4020 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4022 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4023 of scroll runs so as to avoid assigning disabled bogus rows and
4024 unnecessary graphics copy operations.
4026 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4028 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4029 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4030 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4031 (malloc, free, realloc, calloc): Redirect to e_* only when
4034 * lisp.h (GCTYPEBITS): Move before first use.
4035 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4036 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4037 this macro definition.
4039 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4042 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4044 * gtkutil.c (xg_create_frame_widgets):
4045 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4046 present with Gtk+ 2.0.
4048 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4050 * fileio.c (Finsert_file_contents): Undo previous change; see
4051 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4053 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4055 Rename locals to avoid shadowing.
4056 * fileio.c (Finsert_file_contents):
4057 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4058 * process.c (wait_reading_process_output):
4059 Rename inner 'proc' to 'p' to avoid shadowing.
4060 Indent for consistency with usual Emacs style.
4062 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4064 * xdisp.c (redisplay_window): If cursor row is not fully visible
4065 after recentering, and scroll-conservatively is set to a large
4066 number, scroll window by a few more lines to make the cursor fully
4067 visible and out of scroll-margin. (Bug#10105)
4068 (start_display): Don't move to the next line if the display should
4069 start at a newline that is part of a display vector or an overlay
4072 2011-11-24 Juri Linkov <juri@jurta.org>
4074 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4075 after the `MagickPingImage' call. (Bug#10112)
4077 2011-11-23 Chong Yidong <cyd@gnu.org>
4079 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4081 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4083 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4084 making another buffer current. (Bug#10114)
4086 2011-11-23 Glenn Morris <rgm@gnu.org>
4088 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4090 2011-11-23 Chong Yidong <cyd@gnu.org>
4092 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4093 using it (Bug#5984).
4095 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4097 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4098 and header-lines, as they don't have one computed for them.
4101 * .gdbinit (prow): Make displayed values more self-explaining.
4102 Add row's hash code.
4104 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4106 * process.c (wait_reading_process_output): Fix asynchrounous
4107 GnuTLS socket handling on some versions of the GnuTLS library.
4108 (wait_reading_process_output): Add comment and URL.
4110 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4112 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4114 2011-11-21 Chong Yidong <cyd@gnu.org>
4116 * window.c (Fnext_window, Fprevious_window): Doc fix.
4118 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4120 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4122 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4124 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4126 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4128 * window.c (Fset_window_combination_limit): Rename argument
4130 (Vwindow_combination_limit): Remove "status" from doc-string.
4132 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4134 * m/ibms390.h: Remove.
4135 * m/ibms390x.h: Don't include "ibms390.h".
4137 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4139 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4140 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4142 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4144 * casetab.c (Fset_case_table):
4145 * charset.c (Fcharset_after): Fix typos.
4147 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4149 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4150 Otherwise, valgrind does not work on some platforms.
4151 Problem reported by Andreas Schwab in
4152 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4153 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4154 is set, removing the need for VIRT_ADDRESS_VARIES.
4155 (PURE_P): Use a more-efficient implementation that needs just one
4156 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4157 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4158 to 4 (xorl, subq, cmpq, setbe).
4159 * alloc.c (pure): Always extern now, since that's the
4160 VIRT_ADDR_VARIES behavior.
4161 (PURE_POINTER_P): Use a single comparison, not two, for
4162 consistency with the new puresize.h.
4163 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4164 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4165 Remove VIRT_ADDR_VARIES no longer needed.
4167 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4169 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4170 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4171 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4172 behave as if the cursor position were at the window margin.
4174 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4175 and the cursor position is out of bounds, behave as if the cursor
4176 position were at the window margin. (Bug#10075)
4178 2011-11-18 Chong Yidong <cyd@gnu.org>
4180 * window.c (Fwindow_combination_limit): Make first argument
4181 non-optional, since it is meaningless for live windows like the
4184 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4186 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4188 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4190 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4191 (graft_intervals_into_buffer): Simplify.
4193 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4195 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4196 hash values of the two rows.
4197 (copy_row_except_pointers): Preserve the used[] arrays and the
4198 hash values of the two rows. (Bug#10035)
4199 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4201 * xdisp.c (row_hash): New function, body extracted from
4202 compute_line_metrics.
4203 (compute_line_metrics): Call row_hash, instead of computing the
4206 * dispnew.c (verify_row_hash): Call row_hash for computing the
4207 hash code of a row, instead of duplicating code from xdisp.c.
4209 * dispextern.h (row_hash): Add prototype.
4211 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4213 * frame.c (delete_frame): Don't delete the terminal when the last
4214 X frame is closed if emacs is built with GTK toolkit.
4216 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4218 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4220 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4222 * window.c (Vwindow_splits): Rename to
4223 Vwindow_combination_resize. Suggested by Juri Linkov.
4224 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4227 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4229 * nsfns.m (Fns_font_name):
4230 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4232 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4234 * window.h (window): Rename slot "nest" to "combination_limit".
4235 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4236 (Fset_window_nest): Rename to Fset_window_combination_limit.
4237 (Vwindow_nest): Rename to Vwindow_combination_limit.
4238 (recombine_windows, make_parent_window, make_window)
4239 (Fsplit_window_internal, saved_window)
4240 (Fset_window_configuration, save_window_save): Rename all
4241 occurrences of window_nest to window_combination_limit.
4243 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4245 * image.c (imagemagick_load_image): Fix typo.
4247 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4249 * xdisp.c (display_line): Move the call to
4250 highlight_trailing_whitespace before the call to
4251 compute_line_metrics, since the latter needs to see the final
4252 faces of all the glyphs to compute ROW's hash value.
4253 Fixes assertion violations in row_equal_p. (Bug#10035)
4255 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4257 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4258 just return (bug#10044).
4260 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4262 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4263 with user-defined heap size. Bump the default size of the temacs
4264 heap to 27MB, to avoid memory warning when running temacs.
4265 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4267 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4268 current_matrix and desired_matrix. (Bug#9990)
4269 (verify_row_hash) [XASSERTS]: New function.
4270 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4271 that the hash value of glyph rows is correct.
4273 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4275 * window.h (window): Remove splits slot.
4276 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4277 (Fdelete_other_windows_internal, make_parent_window)
4278 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4279 (Fset_window_configuration, save_window_save): Don't deal with
4280 split status of windows.
4281 (saved_window): Remove splits slot.
4282 (Vwindow_splits): Rewrite doc-string.
4284 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4286 * xfns.c (unwind_create_frame):
4287 * nsfns.m (unwind_create_frame):
4288 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4289 Vframe_list (Bug#9999).
4291 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4293 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4295 2011-11-11 Kenichi Handa <handa@m17n.org>
4297 * callproc.c (Fcall_process): Set the member dst_multibyte of
4300 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4302 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4303 avoid a crash (bug#9496).
4305 2011-11-09 Chong Yidong <cyd@gnu.org>
4307 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4308 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4310 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4312 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4314 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4316 Avoid some portability problems by eschewing 'extern inline' functions.
4317 The trivial performance wins aren't worth the portability hassles; see
4318 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4320 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4321 (window_box_width, window_box_left, window_box_left_offset)
4322 (window_box_right, window_box_right_offset): Undo previous change,
4323 by removing the "extern"s.
4324 * intervals.c (adjust_intervals_for_insertion)
4325 (adjust_intervals_for_deletion): Undo previous change,
4326 making these static again.
4327 (offset_intervals, temp_set_point_both, temp_set_point)
4328 (copy_intervals_to_string): No longer inline.
4329 * xdisp.c (window_text_bottom_y, window_box_width)
4330 (window_box_height, window_box_left_offset)
4331 (window_box_right_offset, window_box_left, window_box_right)
4332 (window_box): No longer inline.
4334 2011-11-08 Chong Yidong <cyd@gnu.org>
4336 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4337 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4338 Signal an error if not a live window.
4339 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4340 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4342 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4344 * lisp.h (syms_of_abbrev): Remove declaration.
4345 Reported by CHENG Gao <chenggao@royau.me>.
4347 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4349 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4350 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4351 of temacs in GUI mode.
4353 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4355 * window.h: Declare delete_all_child_windows instead of
4356 delete_all_subwindows.
4357 * window.c (Fwindow_nest, Fset_window_nest)
4358 (Fset_window_new_total, Fset_window_new_normal)
4359 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4360 (delete_all_subwindows): Rename to delete_all_child_windows.
4361 (Fdelete_other_windows_internal, Fset_window_configuration):
4362 Call delete_all_child_windows instead of delete_all_subwindows.
4363 * frame.c (delete_frame): Call delete_all_child_windows instead
4364 of delete_all_subwindows.
4366 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4368 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4369 This is also needed for porting to any host where GC_MARK_STACK is
4370 not GC_MAKE_GCPROS_NOOPS.
4371 (which_symbols): Use it.
4373 2011-11-07 Kenichi Handa <handa@m17n.org>
4375 * coding.c (coding_set_destination): Check coding->src_pos only
4376 when coding->src_object is a buffer (bug#9910).
4378 * process.c (send_process): Set the member src_multibyte of coding
4379 to 0 (bug#9911) when sending a unibyte text.
4381 * callproc.c (Fcall_process): Set the member src_multibyte of
4382 process_coding to 0 (bug#9912).
4384 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4386 * xmenu.c (cleanup_widget_value_tree): New function.
4387 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4388 calling free_menubar_widget_value_tree directly (Bug#9830).
4390 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4392 Fix some portability problems with 'inline'.
4393 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4394 (window_box_width, window_box_left, window_box_left_offset)
4395 (window_box_right, window_box_right_offset): Declare extern.
4396 Otherwise, these inline functions do not conform to C99 and
4397 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4398 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4399 * intervals.c (adjust_intervals_for_insertion)
4400 (adjust_intervals_for_deletion): Now extern, because otherwise the
4401 extern inline functions 'offset_intervals' couldn't refer to it.
4402 (static_offset_intervals): Remove.
4403 (offset_intervals): Rewrite using the old contents of
4404 static_offset_intervals. The old version didn't conform to C99
4405 because an extern inline function contained a reference to an
4406 identifier with static linkage.
4408 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4410 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4413 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4415 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4416 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4417 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4418 return Qleft_to_right.
4420 2011-11-06 Chong Yidong <cyd@gnu.org>
4422 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4423 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4424 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4425 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4426 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4427 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4428 (Fwindow_vscroll): Doc fix.
4429 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4430 argument, since it makes no sense to pass a live window and for
4431 consistency with window-child.
4433 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4435 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4438 2011-11-05 Jason Rumney <jasonr@gnu.org>
4440 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4441 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4443 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4444 bitwise arithmetic preventing use of unicode-sip and non-truetype
4447 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4449 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4452 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4453 initialization code to keep similarity to xfns.c after changes
4456 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4458 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4459 (unwind_create_frame): New function (Bug#9943).
4460 (Fx_create_frame): Restructure code to be more similar to the one in
4461 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4462 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4463 Move terminal->reference_count++ just before making the frame official
4466 * nsterm.m (x_free_frame_resources): New function.
4467 (x_destroy_window): Move code to x_free_frame_resources.
4469 * xfns.c (unwind_create_frame): Fix comment.
4470 (Fx_create_frame, x_create_tip_frame):
4471 Move terminal->reference_count++ just before making the frame
4472 official. Move initialization of image_cache_refcount and
4473 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4475 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4477 Support MSVC build with newer versions of Visual Studio.
4478 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4479 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4482 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4483 which are not supported by MSVC.
4484 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4485 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4487 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4489 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4491 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4493 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4495 Support MSVC build with newer versions of Visual Studio.
4496 * w32.c: Don't include w32api.h for MSVC.
4497 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4499 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4500 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4501 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4502 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4504 (alloca) [_MSC_VER]: Define to _alloca.
4506 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4508 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4510 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4512 * xdisp.c (note_mouse_highlight): If either of
4513 previous/next-single-property-change returns nil, treat that as
4514 the beginning or the end of the buffer. (Bug#9955)
4516 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4518 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4519 label is not null (Bug#9951).
4520 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4523 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4525 * window.c (Fwindow_body_size): Mention in the doc string that the
4526 return value is in frame's canonical units. (Bug#9949)
4528 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4530 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4532 * w32fns.c (unwind_create_frame): If needed, free the glyph
4533 matrices of the partially constructed frame. (Bug#9943)
4534 * xfns.c (unwind_create_frame): Likewise.
4536 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4538 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4539 Don't stop backward scan on the continuation glyph, even though
4540 its CHARPOS is positive.
4541 (mouse_face_from_buffer_pos, note_mouse_highlight):
4542 Rename cover_string to disp_string.
4544 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4546 * window.c (temp_output_buffer_show): Don't use
4547 Vtemp_buffer_show_specifiers.
4548 (Vtemp_buffer_show_specifiers): Remove unused variable.
4550 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4552 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4553 past the beginning of the current glyph matrix.
4555 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4557 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4558 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4559 HAVE_GTK3 (Bug#9869).
4561 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4562 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4564 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4566 * xterm.c: Declare x_handle_net_wm_state to return int.
4567 (handle_one_xevent): Check if we are iconified but don't have
4568 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4569 (get_current_wm_state): Return non-zero if not hidden,
4570 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4571 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4572 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4573 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4575 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4577 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4578 so that this new function doesn't get optimized away by a
4579 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4581 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4583 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4585 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4587 Fix the `xbytecode' command.
4588 * .gdbinit (xprintbytestr): New command.
4589 (xwhichsymbols): Rename from `which'; all callers changed.
4590 (xbytecode): Print the byte-code string as well.
4592 2011-10-29 Kim Storm <storm@cua.dk>
4594 * alloc.c (which_symbols): New function.
4596 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4598 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4601 2011-10-29 Glenn Morris <rgm@gnu.org>
4603 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4604 Not clear what it was for, and it causes various bugs. (Bug#9839)
4606 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4608 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4609 possible random value that matches one of those tested as
4610 condition to clear the mouse face.
4612 2011-10-28 Chong Yidong <cyd@gnu.org>
4614 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4616 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4618 * window.c (make_window): Initialize phys_cursor_on_p.
4620 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4622 * lisp.h (struct Lisp_Symbol): Update comments.
4624 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4626 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4628 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4630 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4631 <oslsachem@gmail.com> for helping to debug this.
4633 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4634 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4635 (g_b_init_get_glyph_outline_w): New static variables.
4636 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4637 (GetGlyphOutlineW_Proc): New typedefs.
4638 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4639 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4641 (w32font_open_internal, compute_metrics):
4642 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4643 instead of calling the "wide" APIs directly.
4645 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4647 * w32.h (syms_of_w32font): Add prototype.
4649 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4651 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4652 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4653 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4654 (Fmove_to_window_line): Doc fix.
4656 2011-10-27 Chong Yidong <cyd@gnu.org>
4658 * process.c (make_process): Set gnutls_state to NULL.
4660 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4661 non-NULL, regardless of GNUTLS_INITSTAGE.
4662 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4663 an error. Set process slots as soon as we allocate them.
4665 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4667 2011-10-27 Chong Yidong <cyd@gnu.org>
4669 * gnutls.c (emacs_gnutls_deinit): New function.
4670 Deallocate credentials structures as well as calling gnutls_deinit.
4671 (Fgnutls_deinit, Fgnutls_boot): Use it.
4673 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4674 (deactivate_process): Call emacs_gnutls_deinit.
4676 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4678 * image.c (x_create_x_image_and_pixmap):
4679 * w32.c (sys_rename, w32_delayed_load):
4680 * w32font.c (fill_in_logfont):
4681 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4683 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4685 * w32fns.c (w32_default_color_map): New function,
4686 extracted from Fw32_default_color_map.
4687 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4689 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4691 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4693 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4695 * keyboard.c (test_undefined): New function (bug#9751).
4696 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4698 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4700 * sysdep.c (init_sys_modes): Fix the check for the controlling
4701 terminal (Bug#6649).
4703 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4705 * dispextern.h (struct bidi_it): New member next_en_type.
4707 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4708 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4709 current character, check also for next_en_type being WEAK_EN.
4710 (bidi_resolve_weak): Don't enter the expensive loop if the current
4711 position is before next_en_pos. Record the bidi type of the first
4712 non-ET, non-BN character we find, in addition to its position.
4713 (bidi_level_of_next_char): Invalidate next_en_type when
4714 next_en_pos is over-stepped.
4716 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4718 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4719 * editfns.c: Rewrite current-time-zone so that it invokes
4720 the equivalent of (format-time-string "%Z") to get the time zone name.
4721 This fixes a bug when the time zone name contains characters that
4722 need converting from the system time locale to Emacs internal format.
4723 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4724 that patch fixed format-time-string to do the conversion, but
4725 I forgot to fix current-time-zone.
4726 (format_time_string): New function, containing most of
4727 what Fformat_time_string used to contain.
4728 (Fformat_time_string): Rewrite in terms of format_time_string.
4729 This doesn't change this function's behavior.
4730 (current-time-zone): Rewrite to use format_time_string.
4731 This fixes the bug reported by Michael Schierl in
4732 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4733 Jason Rumney's 2007-06-07 change worked around this bug, but
4735 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4737 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4739 * xdisp.c (start_display): If the character at POS is displayed
4740 via a display vector, reset IT->current.dpvec_index to zero.
4741 (try_window_reusing_current_matrix): If a line ends in a display
4742 vector or the next line starts in a display vector, continue
4743 redrawing the window even though the character position of
4744 start_row was reached.
4747 2011-10-18 Chong Yidong <cyd@gnu.org>
4749 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4750 with nobreak-char-display too.
4752 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4754 Fix part 3 of bug#9771.
4755 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4756 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4757 non-neutral characters if the current character is a paragraph
4758 separator (a.k.a. Newline). This avoids running the same
4759 expensive loop twice, once when we consume the preceding newline
4760 and the other time when the line actually needs to be displayed.
4761 Avoid the loop when we see neutrals on the base embedding level
4762 following a character whose directionality is the same as the
4763 paragraph's. This avoids running the expensive loop when a line
4764 ends in a long sequence of neutrals, like control characters.
4765 Add assertion against STRONG_AL type. Slightly rearrange code
4766 that determines the type of a neutral given the first non-neutral
4768 (bidi_level_of_next_char): Set next_en_pos to zero when
4769 invalidating its info.
4771 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4773 * xdisp.c (push_display_prop): Determine whether to record string
4774 or buffer position by IT->string, not by IT->method. Allow
4775 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4776 (move_it_vertically_backward): Don't look for character position
4777 immediately after the newline when in a continuation line.
4780 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4782 * window.c (coordinates_in_window): Rewrite and delabelize
4783 vertical border check. (Bug#5357) (Bug#9618)
4785 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4787 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4788 errors in XSetWindowBorder (bug#9310).
4790 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4792 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4793 avoid crash when xmalloc overrun checking is enabled.
4795 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4797 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4798 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4799 cursor motion with <left> and <right> arrow keys.
4801 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4802 some callers set that themselves.
4804 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4806 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4807 display string and the previous row comes from the same string and
4808 is empty. (Bug#9739) (Bug#9738)
4810 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4812 * doc.c (get_doc_string): Encode file name (bug#9735).
4814 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4816 * bidi.c (bidi_level_of_next_char):
4817 * xdisp.c (get_visually_first_element): Remove old incorrect
4818 comments regarding the Unicode Line Separator character.
4820 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4822 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4824 * alloc.c (Fgc_status): Do not access beyond zombies array
4825 boundary if nzombies > MAX_ZOMBIES.
4826 * alloc.c (dump_zombies): Add missing format specifier.
4828 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4830 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4831 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4833 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4834 Some packages use them to denote characters with modifiers.
4836 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4838 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4839 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4840 matching a pp-number. Rename parameter var to var1.
4842 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4844 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4846 2011-10-08 Glenn Morris <rgm@gnu.org>
4848 * callint.c (Fcall_interactively): Give a more explicit error for the
4849 'c' case with a non-character input. (Bug#8479)
4851 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4853 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4855 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4856 lines that are hscrolled on the left.
4858 * dispnew.c (buffer_posn_from_coords): Account for a possible
4859 presence of header-line. (Bug#4426)
4861 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4863 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4864 Don't advertise functionality which we discourage or doesn't work.
4866 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4868 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4869 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4870 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4871 this makes Emacs dump core during garbage collection on rare
4872 occasions. sizeof is obviously inferior to offsetof here, so
4873 stick with offsetof.
4874 (GC_POINTER_ALIGNMENT): New macro.
4875 (mark_memory): Omit 3rd (offset) arg; caller changed.
4876 Don't assume EMACS_INT alignment is the same as pointer alignment.
4878 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4880 * keyboard.c (read_key_sequence_remapped): New var.
4881 (read_key_sequence): Compute remapping in the right buffer.
4882 (command_loop_1): Use read_key_sequence's remapping directly.
4884 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4886 * dired.c (file_name_completion): Don't expand file name.
4887 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4888 before checking file name handler.
4890 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4891 they've been requested explicitly (bug#9591).
4893 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4895 * keymap.c (Fsingle_key_description): Use make_specified_string
4896 instead of build_string to build string from push_key_description.
4899 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4901 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4902 This fixes a Y2038 bug on 64-bit hosts.
4903 * buffer.c (reset_buffer):
4904 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4905 (Fclear_buffer_auto_save_failure):
4906 Use 0, not -1, to represent an unset failure time, since time_t
4907 might not be signed.
4909 Remove dependency on glibc malloc internals.
4910 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4911 Move back here from lisp.h, but with their new implementations.
4912 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4913 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4914 * charset.c (charset_table_init): New static var.
4915 (syms_of_charset): Use it instead of xmalloc. This removes a
4916 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4917 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4918 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4919 Move back to alloc.c.
4920 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4921 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4923 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4925 * nsterm.m (windowDidResize): Call x_set_window_size only when
4926 ns_in_resize is true. Otherwise set pixelwidth/height and
4927 call change_frame_size (Bug#9628).
4929 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4931 Port --enable-checking=all to Fedora 14 x86-64.
4932 * charset.c (syms_of_charset): Also account for glibc malloc's
4933 internal overhead when calculating the initial malloc maximum.
4935 Port --enable-checking=all to Fedora 14 x86.
4936 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4938 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4939 (overrun_check_realloc, overrun_check_free):
4940 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4941 That way, xmalloc returns a properly-aligned pointer even if
4942 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4943 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4944 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4945 into account when calculating the initial malloc maximum.
4946 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4947 Move here from alloc.c, so that charset.c can use it too.
4948 Properly align; the old code wasn't right for common 32-bit hosts
4949 when configured with --enable-checking=all.
4950 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4951 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4953 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4955 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4958 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4960 * xdisp.c (compute_display_string_end): If there's no display
4961 string at CHARPOS, return -1.
4963 * bidi.c (bidi_fetch_char): When compute_display_string_end
4964 returns a negative value, treat the character as a normal
4965 character not covered by a display string. (Bug#9624)
4967 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4969 * lread.c (Fread_from_string): Fix typo in docstring.
4971 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4973 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4974 newline, reseat the iterator instead of bidi-iterating there one
4975 character at a time. (Bug#9610)
4976 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4977 TO_CHARPOS if the bidi iterator is at base embedding level.
4979 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4981 * lread.c (readevalloop): Use correct code for NBSP.
4982 (read1): Likewise. (Bug#9608)
4984 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4986 * dbusbind.c (Fdbus_register_signal): When service is not
4987 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4989 2011-09-25 Glenn Morris <rgm@gnu.org>
4991 * buffer.c (truncate-lines): Doc fix.
4993 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4995 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4996 (Fset_window_next_buffers): Doc fix.
4998 2011-09-24 Glenn Morris <rgm@gnu.org>
5000 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5002 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5004 Fix minor problems found by static checking.
5005 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5006 * indent.c (Fvertical_motion): Fix == vs = typo.
5008 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5010 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5011 Default value is now t. Doc fix.
5013 * indent.c (Fvertical_motion): Compute and apply the overshoot
5014 logic when moving up, not only when moving down. Fix the
5015 confusing name and values of the it_overshoot_expected variable;
5016 logic changes accordingly. (Bug#9254) (Bug#9549)
5018 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5019 CHARPOS is covered by a display string which includes newlines.
5020 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5021 is covered by a display string with embedded newlines.
5023 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5025 * dbusbind.c (Fdbus_register_signal): Add match rule to
5026 Vdbus_registered_objects_table. (Bug#9581)
5027 (Fdbus_register_method, Vdbus_registered_objects_table):
5030 2011-09-24 Jim Meyering <meyering@redhat.com>
5032 do not ignore write error for any output size
5033 The previous change was incomplete.
5034 While it makes emacs --batch detect the vast majority of stdout
5035 write failures, errors were still ignored whenever the output size is
5036 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5037 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5038 && echo FAIL: ignored write error
5039 FAIL: ignored write error
5040 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5041 && echo FAIL: ignored write error
5042 FAIL: ignored write error
5043 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5045 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5047 * emacs.c (Fkill_emacs): In noninteractive mode exit
5048 non-successfully if a write error occurred on stdout. (Bug#9574)
5050 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5052 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5055 * dispextern.h (struct it): Update the comment documenting what
5058 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5060 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5061 a display string, extend search for cursor position to end of row.
5062 (find_row_edges): If the row ends in a newline from a display
5063 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5064 Handle the case of a display string with multiple newlines.
5065 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5066 non-empty line. Fixes confusing cursor motion with arrow keys at
5067 the beginning of a line that starts with whitespace.
5069 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5071 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5074 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5076 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5079 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5081 * xdisp.c (display_line): Record maximum and minimum buffer
5082 positions even if no glyphs were produced (e.g., by a zero-width
5083 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5084 buffer positions that will be removed from the glyph row because
5086 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5087 column is beyond frame width: don't subtract 1 "pixel" when
5088 computing width of the stretch.
5089 (reseat_at_next_visible_line_start): Undo the change made on
5090 2011-09-17 that saved paragraph information and restored it after
5091 the call to `reseat'. (Bug#9545)
5093 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5095 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5096 and turn window cursor on if cleared (Bug#9415).
5098 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5100 * search.c (boyer_moore): Take unibyte characters from pattern
5101 literally. (Bug#9458)
5103 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5105 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5107 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5109 Fix minor problem found by static checking.
5110 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5111 initialized, to pacify gcc -Wuninitialized.
5113 * fileio.c: Report proper errno when syscall falls.
5114 (Finsert_file_contents): Save and restore errno,
5115 so that report_file_error outputs the correct diagnostic.
5116 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5118 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5120 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5122 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5124 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5125 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5127 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5129 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5130 about the current paragraph and restore it after the call to reseat.
5132 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5133 (bidi_find_paragraph_start): Search back for paragraph beginning
5134 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5135 (bidi_move_to_visually_next): Only trigger paragraph-related
5136 computations when the last character is a newline or at EOB, not
5137 just any NEUTRAL_B. (Bug#9470)
5139 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5140 truncated lines if point is covered by a display string. (Bug#9524)
5142 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5144 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5145 (cons_to_x_long): New function.
5146 (lisp_data_to_selection_data): Use it. Correct the test for
5147 short-versus-long data; it was negated. Break out of vector
5148 loop, for efficiency, when a long datum is discovered.
5150 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5152 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5154 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5156 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5157 GCC PR/17406) by declaring this function with external scope.
5159 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5161 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5162 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5164 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5166 * editfns.c (Fformat): Correctly handle text properties on "%%".
5168 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5170 * xterm.c (x_draw_composite_glyph_string_foreground):
5171 * w32term.c (x_draw_composite_glyph_string_foreground):
5172 * term.c (encode_terminal_code):
5173 * composite.c (composition_update_it, get_composition_id):
5174 * xdisp.c (get_next_display_element)
5175 (fill_composite_glyph_string): Add comments about special meaning
5176 of TAB characters in a composition.
5178 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5180 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5181 This occurs when processing a multibyte format.
5182 Problem reported by Wolfgang Jenker.
5184 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5186 * xdisp.c (try_cursor_movement): Only check for exact match if
5187 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5189 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5191 Remove unused external symbols.
5192 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5193 * xdisp.c (calc_pixel_width_or_height): Now static.
5194 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5195 * indent.c (check_display_width):
5196 * w32term.c: Fix comment to match code.
5197 * xterm.c, xterm.h (x_catching_errors): Remove.
5199 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5201 * xselect.c: Use signed conversions more consistently (Bug#9498).
5202 (selection_data_to_lisp_data): Assume incoming selection data are
5203 signed integers, not unsigned. This is to be consistent with
5204 outgoing selection data, which was modified to use signed integers
5205 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5206 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5207 expects long, not unsigned long.
5209 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5211 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5212 computation of loop end. Reported by Johan Bockgård
5215 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5217 * frame.c (Fother_visible_frames_p): Function deleted.
5219 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5221 * indent.c (compute_motion): Process display vector front to back
5222 rather than the other way around. (Bug#2496)
5224 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5226 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5228 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5230 * minibuf.c (Fread_from_minibuffer): Doc fix.
5232 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5234 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5235 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5237 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5239 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5240 value for non-existent files.
5242 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5244 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5245 set its "size" to -1. This will set the modtime_size field of
5246 the corresponding buffer to -1, which is what
5247 verify-visited-file-modtime expects for files that do not exist.
5250 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5252 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5254 * lisp.h: ... from here. push_key_description is no longer
5255 defined in keyboard.c, so its declaration should not be in
5256 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5257 logically belongs with push_key_description.
5259 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5261 * buffer.h: Include <sys/types.h> instead of <time.h>.
5262 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5263 Problem reported by Herbert J. Skuhra.
5265 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5267 * xml.c (parse_region): Make the parsing work for
5268 non-comment-starting XML files again (bug#9144).
5270 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5272 * image.c (gif_load): Fix calculation of bottom and right corner.
5275 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5277 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5278 redisplay in small windows.
5280 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5282 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5284 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5286 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5287 Operate on live windows only.
5289 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5291 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5293 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5295 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5296 only under bidi iteration.
5298 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5300 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5302 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5304 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5305 Without this fix, the command to link temacs failed due to an
5306 undefined symbol __builtin_isnan. This is because
5307 /usr/include/iso/math_c99.h #defines isnan(x) to
5308 __builtin_isnan(x), but the bundled gcc, which identifies itself
5309 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5311 * floatfns.c (isnan): #undef, and then #define to a clone of
5313 (Fisnan): Always define, since it's always available now.
5314 (syms_of_floatfns): Always define isnan at the Lisp level.
5316 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5318 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5320 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5322 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5323 The previous code assumed that file offsets (off_t values) fit in
5324 EMACS_INT variables, which is not true on typical 32-bit hosts.
5325 The code messed up by falsely reporting buffer overflow in cases
5326 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5327 when "big" contains more than 2**29 bytes, even though this
5328 inserts just one byte and does not overflow the buffer.
5329 (Finsert_file_contents): Store file offsets as off_t
5330 values, not as EMACS_INT values. Check for overflow when
5331 converting between EMACS_INT and off_t. When checking for
5332 buffer overflow or for overlap, take the offsets into account.
5333 Don't use EMACS_INT for small values where int suffices.
5334 When checking for overlap, fix a typo: ZV was used where
5335 ZV_BYTE was intended.
5336 (Fwrite_region): Don't assume off_t fits into 'long'.
5337 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5339 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5341 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5343 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5345 sprintf-related integer and memory overflow issues (Bug#9412).
5347 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5348 (esprintf, exprintf, evxprintf): New functions.
5349 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5350 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5351 (modify_event_symbol): Do not assume that the length of
5352 name_alist_or_stem is safe to alloca and fits in int.
5353 (Fexecute_extended_command): Likewise for function name and binding.
5354 (Frecursion_depth): Wrap around reliably on integer overflow.
5355 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5356 since some callers pass EMACS_INT values.
5357 (Fsingle_key_description): Don't crash if symbol name contains more
5358 than MAX_ALLOCA bytes.
5359 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5360 (get_minibuffer): Arg is now EMACS_INT, not int.
5361 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5362 (esprintf, exprintf, evxprintf): New decls.
5363 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5365 * dbusbind.c (signature_cat): New function.
5366 (xd_signature, Fdbus_register_signal):
5367 Do not overrun buffer; instead, report string overflow.
5369 * dispnew.c (add_window_display_history): Don't overrun buffer.
5370 Truncate instead; this is OK since it's just a log.
5372 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5373 even if the time zone offset is outlandishly large.
5374 Don't mishandle offset == INT_MIN.
5376 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5377 when creating daemon; the previous buffer-overflow check was incorrect.
5379 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5380 which has the guts of the old verror function.
5382 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5383 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5385 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5386 (font_unparse_xlfd): Don't blindly alloca long strings.
5387 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5388 fits in int, when using sprintf. Use single snprintf to count
5389 length of string rather than counting it via multiple sprintfs;
5390 that's simpler and more reliable.
5391 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5392 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5393 sprintf, in case result does not fit in int.
5395 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5396 (fontset_from_font): Print it.
5398 * frame.c (tty_frame_count): Now printmax_t, not int.
5399 (make_terminal_frame, set_term_frame_name): Print it.
5400 (x_report_frame_params): In X, window IDs are unsigned long,
5401 not signed long, so print them as unsigned.
5402 (validate_x_resource_name): Check for implausibly long names,
5403 and don't assume name length fits in 'int'.
5404 (x_get_resource_string): Don't blindly alloca invocation name;
5405 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5408 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5409 (xg_check_special_colors, xg_set_geometry):
5410 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5412 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5413 Use esprintf, not sprintf, in case result does not fit in int.
5415 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5416 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5417 it as a large positive number.
5418 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5419 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5421 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5422 in case result does not fit in int.
5424 * print.c (float_to_string): Detect width overflow more reliably.
5425 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5426 buffer overrun. Don't assume list length fits in 'int'. Treat
5427 print length of 0 as 0, not as infinity; to be consistent with other
5428 uses of print length in this function. Don't overflow print length
5429 index. Don't assume hash table size fits in 'long', or that
5430 vectorlike size fits in 'unsigned long'.
5432 * process.c (make_process): Use printmax_t, not int, to format
5433 process-name gensyms.
5435 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5437 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5438 to avoid potential buffer overrun.
5440 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5441 if X resource line is longer than 512 bytes.
5443 * xfns.c (x_window): Make sprintf buffer a bit bigger
5444 to avoid potential buffer overrun.
5446 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5448 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5450 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5452 Integer overflow fixes for scrolling, etc.
5453 Without these, Emacs silently mishandles large integers sometimes.
5454 For example, "C-u 4294967297 M-x recenter" was treated as if
5455 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5457 * xdisp.c (try_window_id): Check Emacs fixnum range before
5458 converting to 'int'.
5460 * window.c (window_scroll_line_based, Frecenter):
5461 Check that an Emacs fixnum is in range before assigning it to 'int'.
5462 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5463 values converted from Emacs fixnums.
5464 (Frecenter): Don't wrap around a line count if it is out of 'int'
5465 range; instead, treat it as an extreme value.
5466 (Fset_window_configuration, compare_window_configurations):
5467 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5469 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5470 that can exceed INT_MAX. Check that EMACS_INT value is in range
5471 before assigning it to the (possibly-narrower) index.
5472 (match_limit): Don't assume that a fixnum can fit in 'int'.
5474 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5477 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5478 (Fvertical_motion): Don't wrap around LINES values that don't fit
5479 in 'int'. Instead, treat them as extreme values. This is good
5480 enough for windows, which can't have more than INT_MAX lines anyway.
5482 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5484 * Require libxml/parser.h to avoid compilation warning.
5486 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5488 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5489 since this reportedly can destroy thread storage.
5491 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5493 * syntax.c (find_defun_start): Update all cache variables if
5494 exiting early (Bug#9401).
5496 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5498 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5500 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5501 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5502 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5504 * term.c (tty_append_glyph): New function.
5505 (produce_stretch_glyph): Static function and its prototype deleted.
5507 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5510 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5512 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5513 when checking :margin (Bug#9390).
5514 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5515 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5516 so that the name doesn't mislead. All uses changed.
5518 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5520 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5523 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5525 * xdisp.c (move_it_to): Don't bail out early when reaching
5526 position beyond to_charpos, if we are scanning backwards.
5527 (move_it_vertically_backward): When DY == 0, make sure we get to
5528 the first character in the line after the newline.
5530 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5532 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5533 (ccl_driver): Do not generate an out-of-range pointer.
5534 (Fccl_execute_on_string): Remove unnecessary check for
5535 integer overflow, noted by Stefan Monnier in
5536 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5537 Remove a FIXME that didn't need fixing.
5538 Simplify the newly-introduced buffer reallocation code.
5540 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5542 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5544 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5546 Integer and memory overflow issues (Bug#9196).
5548 * doc.c (get_doc_string): Rework so that
5549 get_doc_string_buffer_size is the actual buffer size, rather than
5550 being 1 less than the actual buffer size; this makes xpalloc more
5553 * image.c (x_allocate_bitmap_record, cache_image):
5554 * xselect.c (Fx_register_dnd_atom):
5555 Simplify previous changes by using xpalloc.
5557 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5558 since either will do and ptrdiff_t is convenient with xpalloc.
5560 * charset.c (charset_table_size)
5561 (struct charset_sort_data.priority): Now ptrdiff_t.
5562 (charset_compare): Don't overflow if priorities differ greatly.
5563 (Fsort_charsets): Don't assume list length fits in int.
5564 Check for size-calculation overflow when allocating sort data.
5565 (syms_of_charset): Allocate an initial charset table that is
5566 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5568 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5570 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5571 The actual value is always <= INT_MAX, and leaving it unsigned made
5572 overflow checking harder.
5574 * dispextern.h (struct glyph_matrix.rows_allocated)
5575 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5576 with xpalloc. The values are still always <= INT_MAX.
5578 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5580 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5581 (SAFE_NALLOCA): New macro.
5583 * region-cache.c (struct boundary.pos, find_cache_boundary)
5584 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5585 (set_cache_region, invalidate_region_cache)
5586 (revalidate_region_cache, know_region_cache, region_cache_forward)
5587 (region_cache_backward, pp_cache):
5588 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5589 so that ptrdiff_t * can be passed to xpalloc.
5590 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5591 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5592 (pp_cache): Don't assume cache_len fits in int.
5593 * region-cache.h: Adjust extern decls to match.
5595 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5596 EMACS_INT, since either will do, for xpalloc.
5598 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5599 (xnmalloc, xnrealloc, xpalloc): New functions.
5601 * bidi.c (bidi_shelve_header_size): New constant.
5602 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5603 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5605 * bidi.c (bidi_cache_shrink):
5606 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5608 Don't update size of array until after memory allocation succeeds,
5609 because xmalloc/xrealloc may not return.
5610 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5611 now that we have proper integer overflow checking.
5612 (record_overlay_string, overlay_strings): Catch overflows when
5613 calculating size of overlay_str_buf.
5615 * callproc.c (Fcall_process): Check for size overflow when
5616 calculating size of args2.
5617 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5618 Normally we prefer signed values, but sticking with ptrdiff_t would
5619 require adding more-complicated checks.
5621 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5622 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5623 Redo buffer-overflow calculations to avoid integer overflow.
5624 Add a FIXME comment where memory seems to be over-allocated.
5626 * character.c (Fstring): Check for size-calculation overflow.
5628 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5629 unnecessary integer overflow. Check for size overflow.
5630 (encode_coding_object): Don't update size until xmalloc succeeds.
5632 * composite.c (get_composition_id): Check for overflow in glyph
5633 length calculations.
5635 Integer and memory overflow fixes for display code.
5636 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5637 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5638 (scrolling_window): Check for overflow in size calculations.
5639 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5640 Don't assume glyph table len fits in int.
5641 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5642 (row_table_size): Now ptrdiff_t, not int.
5643 (scrolling_window): Avoid overflow in size calculations.
5644 Don't update size until allocation succeeds.
5645 * fns.c (concat): Check for overflow in size calculations.
5646 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5647 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5648 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5650 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5651 (get_doc_string): Check for size calculation overflow.
5652 Don't update size until allocation succeeds.
5653 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5654 EMACS_INT, where ptrdiff_t will do.
5655 (Fsubstitute_command_keys): Check for string overflow.
5657 * editfns.c (set_time_zone_rule): Don't assume environment length
5659 (message_length): Now ptrdiff_t, not int.
5660 (Fmessage_box): Don't update size until allocation succeeds.
5661 Don't assume message length fits in int.
5662 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5664 * emacs.c (main): Do not reallocate argv, since there is a null at
5665 the end that can be overwritten, and this way there's no need to
5666 worry about size-calculation overflow.
5667 (sort_args): Check for size-calculation overflow.
5669 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5671 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5673 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5674 (x_set_scroll_bar_width, x_figure_window_size):
5675 Check for integer overflow.
5676 (x_set_alpha): Do not assume XINT fits in int.
5678 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5679 This is for the members text_lines, text_cols, total_lines, total_cols,
5680 where the system imposes an 'int' limit.
5682 * fringe.c (Fdefine_fringe_bitmap):
5683 Don't update size until alloc works.
5685 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5686 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5688 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5689 Check for size-calculation overflow.
5690 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5691 do, as we prefer signed integers.
5692 (id_to_widget.max_size, id_to_widget.used)
5693 (xg_store_widget_in_map, xg_remove_widget_from_map)
5694 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5695 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5696 Use and return ptrdiff_t, not int.
5697 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5698 * gtkutil.h: Change prototypes to match the above.
5700 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5701 are duplicate now that they've been promoted to lisp.h.
5702 (x_allocate_bitmap_record, x_alloc_image_color)
5703 (make_image_cache, cache_image, xpm_load):
5704 Don't update size until alloc is done.
5705 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5707 Check for size calculation overflow.
5708 (ct_colors_allocated_max): New constant.
5709 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5712 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5713 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5714 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5715 Use ptrdiff_t, not int, to count maps.
5716 (read_char_minibuf_menu_prompt): Check for overflow in size
5717 calculations. Don't update size until allocation succeeds.
5718 Redo calculations to avoid overflow.
5719 * keyboard.h: Change prototypes to match the above.
5721 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5723 (current_minor_maps): Check for size calculation overflow.
5724 * keymap.h: Change prototypes to match the above.
5726 * lread.c (read1, init_obarray): Don't update size until alloc done.
5728 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5729 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5731 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5732 Now ptrdiff_t, not int.
5733 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5734 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5736 * process.c (Fnetwork_interface_list): Check for overflow
5737 in size calculation.
5739 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5741 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5742 overflow. Don't bother calling xmalloc when xrealloc will do.
5744 * search.c (Freplace_match): Check for size calculation overflow.
5745 (Fset_match_data): Don't assume list lengths fit in 'int'.
5747 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5748 for command line length. Do not attempt to address one before the
5749 beginning of an array, as that's not portable.
5751 * term.c (max_frame_lines): Remove; unused.
5752 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5754 (encode_terminal_code, calculate_costs): Check for size
5755 calculation overflow.
5756 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5757 table lengths and related sizes. Don't update size until alloc
5758 done. Redo calculations to avoid overflow.
5759 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5761 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5762 subtracting pointers.
5763 (gobble_line): Check for overflow more carefully. Don't update size
5766 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5767 Don't update size until alloc done.
5768 Redo size calculations to avoid overflow.
5769 Check for size calculation overflow.
5770 (main) [DEBUG]: Fix typo in invoking tparam1.
5772 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5773 Use ptrdiff_t, not int, for sizes.
5774 (store_mode_line_noprop_char): Don't update size until alloc done.
5776 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5777 Use ptrdiff_t, not int, for sizes.
5778 (Finternal_make_lisp_face, cache_face):
5779 Check for size calculation overflow.
5780 (cache_face): Treat size calculation overflows as if they were
5781 memory exhaustion (the usual treatment), rather than aborting.
5783 * xfns.c (x_encode_text, x_set_name_internal)
5784 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5785 sizes, since they can exceed INT_MAX in size. Check for size
5786 calculation overflow.
5788 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5789 (xg_select): Check for size calculation overflow.
5790 Don't update size until alloc done.
5792 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5793 as sprintf is limited to int lengths.
5795 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5796 (X_LONG_MIN): New macros.
5797 Use them to make the following changes clearer.
5798 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5799 This change doesn't affect the value now, but it may help remind
5800 future maintainers not to raise the value too much later.
5801 (SELECTION_QUANTUM): Remove, replacing with ...
5802 (selection_quantum): ... new function, which avoids overflow.
5804 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5805 assumption that selection length fits in 'int'.
5806 (x_reply_selection_request, x_handle_selection_request)
5807 (x_get_window_property, receive_incremental_selection)
5808 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5809 (lisp_data_to_selection_data, clean_local_selection_data):
5810 Use ptrdiff_t, not int, to record length of selection.
5811 (x_reply_selection_request, x_get_window_property)
5812 (receive_incremental_selection, x_property_data_to_lisp):
5813 Redo calculations to avoid overflow.
5814 (x_reply_selection_request): When sending hint, ceiling it at
5815 X_LONG_MAX rather than relying on wraparound overflow to send
5817 (x_get_window_property, receive_incremental_selection)
5818 (lisp_data_to_selection_data, x_property_data_to_lisp):
5819 Check for size-calculation overflow.
5820 (x_get_window_property, receive_incremental_selection)
5821 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5822 Don't store size until memory allocation succeeds.
5823 (x_get_window_property): Plug memory leak on memory exhaustion.
5824 Don't double-block input; malloc is safe here. Don't assume 2**34
5825 - 4 fits in unsigned long. Add an xassert to check
5826 XGetWindowProperty overflow. Be more careful about overflow
5827 calculations, and distinguish size from memory overflow better.
5828 (receive_incremental_selection): When tracing, don't assume
5829 unsigned int is less than INT_MAX.
5830 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5831 harmful) conversions of unsigned short to int.
5832 (lisp_data_to_selection_data): Don't assume that integers
5833 in the range -65535 through -1 fit in an X unsigned short.
5834 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5835 result parameters unless successful. Rely on cons_to_unsigned
5836 to report problems with elements; the old code wasn't right anyway.
5837 (x_check_property_data): Check for int overflow; we cannot use
5838 a wider type due to X limits.
5839 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5841 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5843 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5844 (x_term_init): Check for size calculation overflow.
5845 (x_color_cells): Don't store size until memory allocation succeeds.
5846 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5847 Don't assume alloca size is less than MAX_ALLOCA.
5848 (x_term_init): Don't assume length fits in int (sprintf is limited
5851 Use ptrdiff_t for composition IDs.
5852 * character.c (lisp_string_width):
5853 * composite.c (composition_table_size, n_compositions)
5854 (get_composition_id, composition_gstring_from_id):
5855 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5856 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5857 * window.c (Frecenter):
5858 Use ptrdiff_t, not int, for composition IDs.
5859 * composite.c (get_composition_id): Check for integer overflow.
5860 * composite.h: Adjust prototypes to match the above changes.
5862 Use ptrdiff_t for hash table indexes.
5863 * category.c (hash_get_category_set):
5864 * ccl.c (ccl_driver):
5865 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5866 * coding.c (coding_system_charset_list, detect_coding_system):
5867 * coding.h (struct coding_system.id):
5868 * composite.c (get_composition_id, gstring_lookup_cache):
5869 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5870 * image.c (xpm_get_color_table_h):
5871 * lisp.h (hash_lookup, hash_put):
5872 * minibuf.c (Ftest_completion):
5873 Use ptrdiff_t for hash table indexes, not int (which is too
5874 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5875 32-bit --with-wide-int hosts).
5877 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5878 Add a FIXME comment about memory leaks.
5879 (syms_of_charset): Don't assume xmalloc returns.
5881 Don't assume that stated character widths fit in int.
5882 * character.c (Fchar_width, c_string_width, lisp_string_width):
5883 * character.h (CHAR_WIDTH):
5884 * indent.c (MULTIBYTE_BYTES_WIDTH):
5885 Use sanitize_char_width to avoid undefined and/or bad behavior
5886 with outlandish widths.
5887 * character.h (sanitize_tab_width): Rename from sanitize_width,
5888 now that we have two such functions. All uses changed.
5889 (sanitize_char_width): New inline function.
5891 Don't assume that tab-width fits in int.
5892 * character.h (sanitize_width): New inline function.
5893 (SANE_TAB_WIDTH): New macro.
5894 (ASCII_CHAR_WIDTH): Use it.
5895 * indent.c (sane_tab_width): Remove. All uses replaced by
5896 SANE_TAB_WIDTH (current_buffer).
5897 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5899 * fileio.c: Integer overflow issues with file modes.
5900 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5902 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5903 Remove unreachable code.
5904 (read_hex, load_charset_map_from_file): Check for integer overflow.
5906 * xterm.c: Don't go over XClientMessageEvent limit.
5907 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5908 (x_send_scroll_bar_event): Likewise. Check that the size does not
5909 exceed limits imposed by XClientMessageEvent, as well as the usual
5910 ptrdiff_t and size_t limits.
5912 * keyboard.c: Overflow, signedness and related fixes.
5913 (make_lispy_movement): Use same integer type in forward decl
5914 that is used in the definition.
5915 (read_key_sequence, keyremap_step):
5916 Change bufsize argument back to int, undoing my 2011-03-30 change.
5917 We prefer signed types, and int is wide enough here.
5918 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5919 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5920 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5921 length, not size_t. Use ptrdiff_t for index, not int.
5922 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5923 possibility of integer overflow.
5925 Overflow, signedness and related fixes for images.
5927 * dispextern.h (struct it.stack[0].u.image.image_id)
5928 (struct_it.image_id, struct image.id, struct image_cache.size)
5929 (struct image_cache.used, struct image_cache.ref_count):
5930 * gtkutil.c (update_frame_tool_bar):
5931 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5932 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5933 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5934 * nsmenu.m (update_frame_tool_bar):
5935 * xdisp.c (calc_pixel_width_or_height):
5936 * xfns.c (image_cache_refcount):
5937 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5938 on typical 64-bit hosts.
5940 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5941 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5942 Omit unnecessary casts to int.
5943 (parse_image_spec): Check that integers fall into 'int' range
5944 when the callers expect that.
5945 (image_ascent): Redo ascent calculation to avoid int overflow.
5946 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5947 (lookup_image): Remove unnecessary tests.
5948 (xbm_image_p): Locals are now of int, not EMACS_INT,
5949 since parse_image_check makes sure they fit into int.
5950 (png_load, gif_load, svg_load_image):
5951 Prefer int to unsigned where either will do.
5952 (tiff_handler): New function, combining the cores of the
5953 old tiff_error_handler and tiff_warning_handler.
5954 This function is rewritten to use vsnprintf and thereby avoid
5955 stack buffer overflows. It uses only the features of vsnprintf
5956 that are common to both POSIX and native Microsoft.
5957 (tiff_error_handler, tiff_warning_handler): Use it.
5958 (tiff_load, gif_load, imagemagick_load_image):
5959 Don't assume :index value fits in 'int'.
5960 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5961 (imagemagick_load_image): Check that crop parameters fit into
5962 the integer types that MagickCropImage accepts. Don't assume
5963 Vimagemagick_render_type has a nonnegative value. Don't assume
5964 size_t fits in 'long'.
5965 (gs_load): Use printmax_t to print the widest integers possible.
5966 Check for integer overflow when computing image height and width.
5968 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5970 * xdisp.c (redisplay_window): Don't force window start if point
5971 will be invisible in the resulting window. (Bug#9324)
5973 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5975 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5976 the display spec is of the form `(space ...)'.
5977 (handle_display_spec): Return the value returned by
5978 handle_single_display_spec, not just 1 or zero.
5979 (handle_single_display_spec): If the display spec is of the form
5980 `(space ...)', and specifies display in the text area, return 2
5982 (try_cursor_movement): Check for the need to scroll more
5983 accurately, and prefer exact match for point under bidi.
5984 Don't advance `row' beyond the last row of the window.
5986 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5987 into disp_prop; all users changed.
5989 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5990 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5991 for the text covered by the display property.
5993 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5995 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5996 Change return value to nil.
5997 (Frecord_buffer): Delete unused function.
5999 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6001 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6002 buffers, return left-to-right.
6003 (set_cursor_from_row): Consider candidate row a win if its glyph
6004 represents a newline and point is on that newline. Fixes cursor
6005 positioning on the newline at EOL of R2L text within L2R
6006 paragraph, and vice versa.
6007 (try_cursor_movement): Check continued rows, in addition to
6008 continuation rows. Fixes unwarranted scroll when point enters a
6009 continued line of R2L text within an L2R paragraph, or vice versa.
6010 (cursor_row_p): Consider the case of point being equal to
6011 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6012 from the end of a short line to the beginning of a continued line
6013 of R2L text within L2R paragraph.
6014 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6015 composed characters.
6017 * bidi.c (bidi_check_type): Use xassert.
6018 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6021 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6023 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6026 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6028 * nsfont.m (ns_otf_to_script): Fix typo.
6030 2011-08-22 Kenichi Handa <handa@m17n.org>
6032 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6033 extra slot even if the purpose is char-code-property-table.
6035 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6037 * xdisp.c (redisplay_window): When computing centering_position,
6038 account for the height of the header line. (Bug#8874)
6040 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6041 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6042 candidate is selected by the mouse, and that candidate has a
6043 composed character under the mouse.
6045 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6046 coordinates reported by pos-visible-in-window-p for a composed
6047 character in column zero.
6049 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6051 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6053 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6055 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6056 consider it a hit if to_charpos is anywhere in the range of the
6057 composed buffer positions.
6059 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6061 * image.c (gif_load): Don't assume that each subimage has the same
6062 dimensions as the base image. Handle disposal method that is
6063 "undefined" by the gif spec (Bug#9335).
6065 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6067 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6068 (Fcondition_case): Document `debug' symbol in error handler.
6070 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6072 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6073 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6074 from an Org mode buffer to a Speedbar frame.
6076 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6077 a composition, take its buffer position from IT->cmp_it.charpos.
6078 Fixes cursor positioning at the beginning of a line that begins
6079 with a composed character.
6081 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6083 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6084 character bidirectional type, use STRONG_L instead. Fixes crashes
6085 in a buffer produced by `describe-categories'.
6087 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6088 members before the level stack, so they would be saved and
6089 restored when copying iterator state. Fixes incorrect reordering
6090 around TABs covered by display properties.
6092 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6094 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6096 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6098 * eval.c (internal_condition_case, internal_condition_case_1)
6099 (internal_condition_case_2, internal_condition_case_n):
6100 Remove unnecessary aborts (Bug#9081).
6102 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6104 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6105 has no `load' handler, try opening the file locally. (Bug#9311)
6107 2011-08-16 Ken Brown <kbrown@cornell.edu>
6109 * gmalloc.c: Expand comment.
6111 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6113 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6114 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6116 2011-08-16 Ken Brown <kbrown@cornell.edu>
6118 Fix memory allocation problems in Cygwin build (Bug#9273).
6120 * unexcw.c ( __malloc_initialized): Declare external variable.
6121 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6123 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6125 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6127 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6129 [CYGWIN] (special_realloc): New function.
6130 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6131 requests to realloc storage in the static heap.
6133 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6135 * bidi.c (bidi_initialize): Remove unused local.
6137 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6140 * biditype.h: Remove file.
6141 * makefile.w32-in ($(BLD)/bidi.$(O)):
6142 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6144 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6146 * chartab.c: Improve commentary for the uniprop_table API.
6148 * bidi.c (bidi_paragraph_init): Support zero value of
6149 bidi_ignore_explicit_marks_for_paragraph_level.
6150 (bidi_initialize): Use uniprop_table instead of including
6151 biditype.h and bidimirror.h.
6153 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6154 coordinates of the iterator when restoring from ppos_it.
6157 2011-08-14 Kenichi Handa <handa@m17n.org>
6159 * process.c (create_process): Call setup_process_coding_systems
6160 after the pid of the process is set to -1 (Bug#8162).
6162 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6164 * xdisp.c (move_it_in_display_line_to): Don't invoke
6165 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6166 ppos_it. Fixes vertical cursor motion when line beginning is
6167 covered by an image. (Bug#9296)
6169 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6171 * nsterm.h (ns_run_ascript): Declare.
6172 (NSAPP_DATA2_RUNASSCRIPT): Define.
6174 * nsfns.m (as_script, as_result, as_status): New static variables.
6175 (ns_run_ascript): New function.
6176 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6177 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6178 the event loop. Get status from as_status (Bug#7276).
6180 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6181 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6182 the event loop (Bug#7276).
6184 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6186 * gnutls.c (QCgnutls_bootprop_priority)
6187 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6188 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6189 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6190 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6191 (QCgnutls_bootprop_verify_hostname_error)
6192 (QCgnutls_bootprop_callbacks_verify): Rename from
6193 Qgnutls_bootprop_..., all uses changed.
6195 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6198 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6200 * xfaces.c (Qframe_set_background_mode): Now static.
6201 * dispextern.h (Qframe_set_background_mode): Remove decl.
6203 * process.c (Fnetwork_interface_info): Declare local only if needed.
6205 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6207 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6208 (Fnetwork_interface_list): Allocate in increments of bytes instead
6209 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6210 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6212 (struct ifflag_def): notrailers is smart on OSX.
6213 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6214 Get hardware address with getifaddrs if available.
6216 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6218 * xdisp.c (iterate_out_of_display_property): xassert that
6219 IT->position is set to within IT->object's boundaries. Break from
6220 the loop as soon as EOB is reached; avoids infloops in redisplay
6221 when IT->position is set up wrongly due to some bug.
6222 Set IT->current to match the bidi iterator unconditionally.
6223 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6224 entry. Force push_it to save on the stack the current
6225 buffer/string position, to be restored by pop_it. Fix flags in
6226 the iterator structure wrt the object coming from a display
6227 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6228 properties. (Bug#9284)
6230 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6232 * fontset.c (fontset_get_font_group): Add proper type checks.
6235 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6237 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6238 and LC_VERSION_MIN_MACOSX.
6239 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6240 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6242 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6244 * xdisp.c (forward_to_next_line_start): Allow to use the
6245 no-display-properties-and-no-overlays under bidi display.
6246 Set disp_pos in the bidi iterator to avoid searches for display
6247 properties and overlays.
6249 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6251 * editfns.c (Fset_time_zone_rule): Document relationship with the
6254 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6255 the font entity extracted from the cache (Bug#8109).
6257 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6259 * composite.c (autocmp_chars): Don't reset point. That is done by
6260 restore_point_unwind (Bug#5984).
6262 2011-08-07 Juri Linkov <juri@jurta.org>
6264 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6265 to show the arg `TIME' instead of `TIMEVAL'.
6267 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6269 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6270 display property strides EOL and includes a newline, as in
6271 longlines-mode. (Bug#9254)
6272 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6273 word-wrap under bidirectional display. (Bug#9224)
6275 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6276 is non-zero, even if the data buffer is NULL. Fixes a crash in
6277 vertical-motion with longlines-mode. (Bug#9254)
6279 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6281 * bidi.c <bidi_cache_total_alloc>: Now static.
6282 (bidi_initialize): Initialize bidi_cache_total_alloc.
6284 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6287 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6288 amount allocated this far in `bidi_cache_total_alloc'.
6289 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6290 non-zero, only free the data buffer without restoring the cache
6291 contents. All callers changed.
6293 * dispextern.h (bidi_unshelve_cache): Update prototype.
6295 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6296 (move_it_in_display_line, move_it_to)
6297 (move_it_vertically_backward, move_it_by_lines): Replace the call
6298 to xfree to an equivalent call to bidi_unshelve_cache.
6299 (move_it_in_display_line_to): Fix logic of returning
6300 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6302 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6304 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6305 came from a string character with a `cursor' property. (Bug#9229)
6307 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6309 * Makefile.in (LIB_PTHREAD): New variable.
6310 (LIBES): Add LIB_PTHREAD (Bug#9216).
6312 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6313 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6315 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6317 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6319 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6321 * xterm.c (x_find_topmost_parent): New function.
6322 (x_set_frame_alpha): Find topmost parent window with
6323 x_find_topmost_parent and set the property there also (bug#9181).
6324 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6326 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6328 * callproc.c (Fcall_process): Avoid vfork clobbering
6329 the local vars buffer, coding_systems, current_dir.
6331 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6333 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6335 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6337 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6338 so that it is not optimized away.
6340 * xdisp.c (compute_display_string_pos): Remove unused local.
6342 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6344 Fix slow cursor motion and scrolling in large buffers with
6345 selective display, like Org Mode buffers. (Bug#9218)
6347 * dispextern.h (struct bidi_it): New member disp_prop_p.
6349 * xdisp.c: Remove one-slot cache of display string positions.
6350 (compute_display_string_pos): Accept an additional argument
6351 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6352 for a display string or property. If found, set DISP_PROP_P
6355 * bidi.c (bidi_fetch_char): Accept an additional argument
6356 DISP_PROP_P, and pass it to compute_display_string_pos.
6357 Only handle text covered by a display string if DISP_PROP_P is returned
6358 non-zero. All callers of bidi_fetch_char changed.
6360 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6362 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6364 2010-12-03 Don March <don@ohspite.net>
6366 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6367 last character M-[char] is translated to ESC [char] (bug#7541).
6369 2011-08-02 Kenichi Handa <handa@m17n.org>
6371 * lisp.h (uniprop_table): Extern it.
6373 * chartab.c (uniprop_table): Make it non-static.
6375 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6377 * xdisp.c (forward_to_next_line_start): Accept additional argument
6378 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6380 (reseat_at_next_visible_line_start): Use the bidi iterator state
6381 returned by forward_to_next_line_start to restore the state of
6382 it->bidi_it after backing up to previous newline. (Bug#9212)
6384 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6386 * regex.c (re_comp): Protoize.
6387 (re_exec): Fix return type.
6388 (regexec): Fix type of `ret'. (Bug#9203)
6390 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6392 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6393 This is needed if max-image-size is a floating-point number.
6395 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6397 * print.c (print_object): Print empty symbol as ##.
6399 * lread.c (read1): Read ## as empty symbol.
6401 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6403 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6404 setting frame foreground color (Bug#9175).
6405 (x_set_background_color): Likewise.
6407 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6408 contents (Bug#9176).
6409 (EmacsTooltip -init): Remove bezels and add shadows to
6412 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6413 or scroll bar (Bug#8470).
6415 * nsfont.m (nsfont_open): Remove assignment to voffset and
6416 unnecessary vars hshink, expand, hd, full_height, min_height.
6417 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6419 * nsterm.h (nsfont_info): Remove voffset field.
6421 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6423 Implement strike-through and overline on NextStep (Bug#8863).
6425 * nsfont.m (nsfont_open): Use underline position provided by font,
6426 instead of hard-coded value of 2.
6427 (nsfont_draw): Call ns_draw_text_decoration instead.
6429 * nsterm.h: Add declaration for ns_draw_text_decoration.
6431 * nsterm.m (ns_draw_text_decoration): New function for drawing
6432 underline, overline, and strike-through.
6433 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6434 ns_draw_text_decoration. Change treatment of cursor drawing to
6435 accommodate underlining, etc.
6437 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6439 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6442 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6444 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6445 Without this fix, if a signal arrives just after memory fills up,
6446 'malloc' might be invoked reentrantly.
6448 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6449 In other words, assume that every image size is allowed, on non-X
6450 hosts. This assumption is probably wrong, but it lets Emacs compile.
6452 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6454 * regex.c (re_iswctype): Convert return values to boolean.
6456 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6458 * xdisp.c (compute_display_string_pos): Don't use cached display
6459 string position if the buffer had its restriction changed.
6462 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6464 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6466 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6468 Integer signedness and overflow and related fixes. (Bug#9079)
6470 * bidi.c: Integer size and overflow fixes.
6471 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6472 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6473 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6474 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6475 (bidi_find_other_level_edge):
6476 Use ptrdiff_t instead of EMACS_INT where either will do.
6477 This works better on 32-bit hosts configured --with-wide-int.
6478 (bidi_cache_ensure_space): Check for size-calculation overflow.
6479 Use % rather than repeated addition, for better worst-case speed.
6480 Don't set bidi_cache_size until after xrealloc returns, because it
6482 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6483 (bidi_cache_ensure_space): Also check that the bidi cache size
6484 does not exceed that of the largest Lisp string or buffer. See Eli
6485 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6487 * alloc.c (__malloc_size_t): Remove.
6488 All uses replaced by size_t. See Andreas Schwab's note
6489 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6491 * image.c: Improve checking for integer overflow.
6492 (check_image_size): Assume that f is nonnull, since
6493 it is always nonnull in practice. This is one less thing to
6494 worry about when checking for integer overflow later.
6495 (x_check_image_size): New function, which checks for integer
6496 overflow issues inside X.
6497 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6498 This removes the need for a memory_full check.
6499 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6500 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6501 (xbm_read_bitmap_data): Change locals back to 'int', since
6502 their values must fit in 'int'.
6503 (xpm_load_image, png_load, tiff_load):
6504 Invoke x_create_x_image_and_pixmap earlier,
6505 to avoid much needless work if the image is too large.
6506 (tiff_load): Treat overly large images as if
6507 x_create_x_image_and_pixmap failed, not as malloc failures.
6508 (gs_load): Use x_check_image_size.
6510 * gtkutil.c: Omit integer casts.
6511 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6512 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6514 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6516 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6517 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6518 would wrongly return t on a 64-bit host.
6520 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6521 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6522 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6523 and therefore cause GCC to emit a bogus diagnostic in some cases.
6525 * image.c: Integer signedness and overflow and related fixes.
6526 This is not an exhaustive set of fixes, but it's time to
6527 record what I've got.
6528 (lookup_pixel_color, check_image_size): Remove redundant decls.
6529 (check_image_size): Don't assume that arbitrary EMACS_INT values
6530 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6531 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6532 (tiff_load, imagemagick_load_image):
6533 Check for overflow in size calculations.
6534 (x_create_x_image_and_pixmap): Remove unnecessary test for
6535 xmalloc returning NULL; that can't happen.
6536 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6537 (xpm_color_bucket): Use better integer hashing function.
6538 (xpm_cache_color): Don't possibly over-allocate memory.
6539 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6540 (gif_memory_source):
6541 Use ptrdiff_t, not int or size_t, to record sizes.
6542 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6543 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6544 either works, as we prefer signed integers.
6545 (tiff_read_from_memory, tiff_write_from_memory):
6546 Return tsize_t, not size_t, since that's what the TIFF API wants.
6547 (tiff_read_from_memory): Don't fail simply because the read would
6548 go past EOF; instead, return a short read.
6549 (tiff_load): Omit no-longer-needed casts.
6550 (Fimagemagick_types): Don't assume size fits into 'int'.
6552 Improve hashing quality when configured --with-wide-int.
6553 * fns.c (hash_string): New function, taken from sxhash_string.
6554 Do not discard information about ASCII character case; this
6555 discarding is no longer needed.
6556 (sxhash-string): Use it. Change sig to match it. Caller changed.
6557 * lisp.h: Declare it.
6558 * lread.c (hash_string): Remove, since we now use fns.c's version.
6559 The fns.c version returns a wider integer if --with-wide-int is
6560 specified, so this should help the quality of the hashing a bit.
6562 * emacs.c: Integer overflow minor fix.
6563 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6564 Define only if GNU_LINUX.
6565 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6567 * dispnew.c: Integer signedness and overflow fixes.
6568 Remove unnecessary forward decls, that were a maintenance hassle.
6569 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6571 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6572 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6573 (prepare_desired_row, line_draw_cost):
6574 Use int, not unsigned, where either works.
6575 (save_current_matrix, restore_current_matrix):
6576 Use ptrdiff_t, not size_t, where either works.
6577 (init_display): Check for overflow more accurately, and without
6578 relying on undefined behavior.
6580 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6581 Remove, replacing with the new symbols in lisp.h. All uses changed.
6582 * fileio.c (make_temp_name):
6583 * filelock.c (lock_file_1, lock_file):
6584 * xdisp.c (message_dolog):
6585 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6586 Use pMd etc. instead.
6587 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6588 replacing the pWIDE etc. symbols removed from editfns.c.
6590 * keyboard.h (num_input_events): Now uintmax_t.
6591 This is (very slightly) less likely to mess up due to wraparound.
6594 * buffer.c: Integer signedness fixes.
6595 (alloc_buffer_text, enlarge_buffer_text):
6596 Use ptrdiff_t rather than size_t when either will do, as we prefer
6599 * alloc.c: Integer signedness and overflow fixes.
6600 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6601 (__malloc_size_t): Default to size_t, not to int.
6602 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6603 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6604 Prefer ptrdiff_t to size_t when either would do, as we prefer
6606 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6607 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6608 Now const. Initialize with values that are in range even if char
6610 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6611 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6612 These functions do the right thing with sizes > 2**32.
6613 (check_depth): Now ptrdiff_t, not int.
6614 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6615 Adjust to new way of storing sizes. Check for size overflow bugs
6617 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6618 slightly wrong anyway, as it missed one instance of
6619 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6620 (refill_memory_reserve): Omit needless cast to size_t.
6621 (mark_object_loop_halt): Mark as externally visible.
6623 * xselect.c: Integer signedness and overflow fixes.
6624 (Fx_register_dnd_atom, x_handle_dnd_message):
6625 Use ptrdiff_t, not size_t, since we prefer signed.
6626 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6627 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6628 x_dnd_atoms_size and x_dnd_atoms_length.
6630 * doprnt.c: Prefer signed to unsigned when either works.
6632 * doprnt.c (doprnt):
6634 * xdisp.c (vmessage):
6635 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6636 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6637 prefer signed arithmetic to avoid comparison confusion.
6638 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6639 but is a bit tricky.
6641 Assume freestanding C89 headers, string.h, stdlib.h.
6642 * data.c, doprnt.c, floatfns.c, print.c:
6643 Include float.h unconditionally.
6644 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6645 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6646 * regex.c: Likewise for stddef.h, string.h.
6647 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6648 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6649 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6650 (STDC_HEADERS): Remove obsolete defines.
6651 * sysdep.c: Include limits.h unconditionally.
6653 Assume support for memcmp, memcpy, memmove, memset.
6654 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6655 * regex.c (memcmp, memcpy):
6656 Remove; we assume C89 now.
6658 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6659 (__malloc_safe_bcopy): Remove; no longer needed.
6661 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6662 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6663 well either way, and we prefer signed to unsigned.
6665 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6667 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6668 closes the connection while we're reading (bug#9182).
6670 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6672 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6673 are specified (Bug#9168).
6675 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6677 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6678 Found by GCC static checking and --with-wide-int on a 32-bit host.
6680 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6682 * xdisp.c (compute_display_string_pos): Fix logic of caching
6683 previous display string position. Initialize cached_prev_pos to
6684 -1. Fixes slow-down at the beginning of a buffer.
6686 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6688 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6689 for attrs[LFACE_FONTSET_INDEX].
6691 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6693 * xml.c (parse_region): Remove unused local
6694 that was recently introduced.
6696 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6698 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6699 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6701 * xdisp.c (move_it_in_display_line_to): Record the best matching
6702 position for TO_CHARPOS while scanning the line, and restore it on
6703 exit if none of the characters scanned was an exact match.
6704 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6705 when exact match is impossible due to invisible text, and the
6706 lines are truncated.
6708 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6710 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6713 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6715 Fix a significant slow-down of cursor motion with C-n, C-p,
6716 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6717 auto-repeat under bidi redisplay in fontified buffers.
6718 * xdisp.c (compute_stop_pos_backwards): New function.
6719 (next_element_from_buffer): Call compute_stop_pos_backwards to
6720 find a suitable prev_stop when we find ourselves before
6722 (reseat): Don't look for prev_stop, as that could mean a very long
6724 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6725 <cached_disp_overlay_modiff>: Cache for last found display string
6727 (compute_display_string_pos): Return the cached position if asked
6728 about the same buffer in the same area of character positions, and
6729 the buffer wasn't changed since the time the display string
6730 position was cached.
6732 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6734 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6735 is an integer, which is important for empty lines. (Bug#9149)
6737 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6739 * frame.c (Fmodify_frame_parameters): In tty case, update the
6740 default face if necessary (Bug#4238).
6742 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6744 * editfns.c (Fstring_to_char): No need to explain what a character
6745 is in the docstring (Bug#6576).
6747 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6749 * xml.c (parse_region): Make sure we always return a tree.
6751 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6753 * xml.c (parse_region): If a document contains only comments,
6756 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6758 * xml.c (make_dom): Return comments, too.
6760 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6763 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6764 and the surrounding thread.
6765 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6766 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6767 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6769 * s/openbsd.h (BROKEN_SIGIO): Define.
6770 * unexelf.c (unexec) [__OpenBSD__]:
6771 Don't update the .mdebug section of the Alpha COFF symbol table.
6773 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6775 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6778 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6780 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6781 This fixes some race conditions on the permissions of any newly
6784 * alloc.c (valid_pointer_p): Use pipe, not open.
6785 This fixes some permissions issues when debugging.
6787 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6788 If fchown fails to set both uid and gid, try to set just gid,
6789 as that is sometimes allowed. Adjust the file's mode to eliminate
6790 setuid or setgid bits that are inappropriate if fchown fails.
6792 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6794 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6795 to compare Lisp_Objects.
6796 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6797 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6798 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6800 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6802 * lread.c (read_integer): Unread even EOF character.
6803 (read1): Likewise. Properly record start position of symbol.
6805 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6806 symbol character follows.
6808 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6810 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6811 This works around a problem with the previous change to Fcopy_file.
6812 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6813 and without this change, GCC might complain about discarding
6814 fchown's return value.
6816 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6818 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6820 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6822 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6824 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6826 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6827 it's used from the C level.
6829 * process.c: Use the same condition for POLL_FOR_INPUT in both
6830 keyboard.c and process.c (bug#1858).
6832 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6834 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6835 (Fgnutls_boot): Use it.
6837 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6839 * doc.c (Fsubstitute_command_keys): Revert last change.
6841 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6843 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6844 quotes the next character, and doesn't affect other longer
6845 sequences (bug#8935).
6847 * lread.c (syms_of_lread): Clarify that is isn't only
6848 `eval-buffer' and `eval-defun' that's affected by
6849 `lexical-binding' (bug#8460).
6851 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6853 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6854 bidi redisplay when a line includes both an image and is truncated.
6856 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6858 Fix minor problems found by static checking.
6859 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6860 (elsz): Now a signed constant, not a size_t var. We prefer signed
6861 types to unsigned, to avoid integer comparison confusion. Without
6862 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6863 "cannot optimize loop, the loop counter may overflow", a symptom
6865 * indent.c (Fvertical_motion): Mark locals as initialized.
6866 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6868 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6870 * search.c (Fre_search_backward): Mention `case-fold-search' in
6871 all the re_search_* functions (bug#8138).
6873 * keyboard.c (Fopen_dribble_file): Document when the file is
6876 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6878 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6881 Support bidi reordering of display and overlay strings.
6882 * xdisp.c (compute_display_string_pos)
6883 (compute_display_string_end): Accept additional argument STRING.
6884 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6885 (reseat_to_string): Initialize bidi_it->string.s and
6886 bidi_it->string.schars.
6887 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6888 NULL (avoids a crash in bidi_paragraph_init).
6889 Initialize itb.string.lstring.
6890 (init_iterator): Call bidi_init_it only of a valid
6891 buffer position was specified. Initialize paragraph_embedding to
6893 (reseat_to_string): Initialize the bidi iterator.
6894 (display_string): If we need to ignore text properties of
6895 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6896 original value of -1 will not work with bidi.)
6897 (compute_display_string_pos): First arg is now struct
6898 `text_pos *'; all callers changed. Support display properties on
6900 (compute_display_string_end): Support display properties on Lisp
6902 (init_iterator, reseat_1, reseat_to_string): Initialize the
6903 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6904 when iterating on a string not from display properties).
6905 (compute_display_string_pos, compute_display_string_end):
6906 Fix calculation of the object to scan. Fixes an error when using
6908 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6909 base_level_stop; instead, set base_level_stop to BEGV.
6910 Fixes crashes in vertical-motion.
6911 (next_element_from_buffer): Improve commentary for when
6912 the iterator is before prev_stop.
6913 (init_iterator): Initialize bidi_p from the default value of
6914 bidi-display-reordering, not from buffer-local value. Use the
6915 buffer-local value only if initializing for buffer iteration.
6916 (handle_invisible_prop): Support invisible properties on strings
6917 that are being bidi-reordered.
6918 (set_iterator_to_next): Support bidi reordering of C strings and
6920 (next_element_from_string): Support bidi reordering of Lisp
6922 (handle_stop_backwards): Support Lisp strings as well.
6923 (display_string): Support display of R2L glyph rows.
6924 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6925 (init_iterator): Don't initialize it->bidi_p for strings
6927 (reseat_to_string): Initialize it->bidi_p for strings here.
6928 (next_element_from_string, next_element_from_c_string)
6929 (next_element_from_buffer): Add xassert's for correspondence
6930 between IT's object being iterated and it->bidi_it.string
6932 (face_before_or_after_it_pos): Support bidi iteration.
6933 (next_element_from_c_string): Handle the case of the first string
6934 character that is not the first one in the visual order.
6935 (get_visually_first_element): New function, refactored from common
6936 parts of next_element_from_buffer, next_element_from_string, and
6937 next_element_from_c_string.
6938 (tool_bar_lines_needed, redisplay_tool_bar)
6939 (display_menu_bar): Force left-to-right direction. Add a FIXME
6940 comment for making that be controlled by a user option.
6941 (push_it, pop_it): Save and restore the state of the
6942 bidi iterator. Save and restore the bidi_p flag.
6943 (pop_it): Iterate out of display property for string iteration as
6945 (iterate_out_of_display_property): Support iteration over strings.
6946 (handle_single_display_spec): Set up it->bidi_it for iteration
6947 over a display string, and call bidi_init_it.
6948 (handle_single_display_spec, next_overlay_string)
6949 (get_overlay_strings_1, push_display_prop): Set up the bidi
6950 iterator for displaying display or overlay strings.
6951 (forward_to_next_line_start): Don't use the shortcut if
6953 (back_to_previous_visible_line_start): If handle_display_prop
6954 pushed the iterator stack, restore the internal state of the bidi
6955 iterator by calling bidi_pop_it same number of times.
6956 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6957 and we are bidi-iterating, don't decrement the iterator position;
6958 instead, set the first_elt flag in the bidi iterator, to produce
6960 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6961 (push_display_prop): xassert that we are iterating a buffer.
6962 (push_it, pop_it): Save and restore paragraph_embedding member.
6963 (handle_single_display_spec, next_overlay_string)
6964 (get_overlay_strings_1, reseat_1, reseat_to_string)
6965 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6966 correctly. Don't assume unibyte strings are not bidi-reordered.
6967 (compute_display_string_pos)
6968 (compute_display_string_end): Fix handling the case of C string.
6969 (push_it, pop_it): Save and restore from_disp_prop_p.
6970 (handle_single_display_spec, push_display_prop): Set the
6971 from_disp_prop_p flag.
6972 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6973 (pop_it): Call iterate_out_of_display_property only if we are
6974 popping after iteration over a string that came from a display
6975 property. Fix a typo in popping stretch info. Add an assertion
6976 for verifying that the iterator position is in sync with the bidi
6978 (handle_single_display_spec, get_overlay_strings_1)
6979 (push_display_prop): Fix initialization of paragraph direction for
6980 string when that of the parent object is not yet determined.
6981 (reseat_1): Call bidi_init_it to resync the bidi
6982 iterator with IT's position. (Bug#7616)
6983 (find_row_edges): If ROW->start.pos gives position
6984 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6985 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6986 Reset the from_disp_prop_p flag.
6987 (SAVE_IT, RESTORE_IT): New macros.
6988 (pos_visible_p, face_before_or_after_it_pos)
6989 (back_to_previous_visible_line_start)
6990 (move_it_in_display_line_to, move_it_in_display_line)
6991 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6992 (try_scrolling, redisplay_window, display_line): Use them when
6993 saving a temporary copy of the iterator and restoring it back.
6994 (back_to_previous_visible_line_start, reseat_1)
6995 (init_iterator): Empty the bidi cache "stack".
6996 (move_it_in_display_line_to): If iterator ended up at
6997 EOL, but we never saw any buffer positions smaller than
6998 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6999 motion in bidi-reordered lines.
7000 (move_it_in_display_line_to): Record prev_method and prev_pos
7001 immediately before the call to set_iterator_to_next. Fixes cursor
7002 motion in bidi-reordered lines with stretch glyphs and strings
7003 displayed in margins. (Bug#8133) (Bug#8867)
7004 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7006 (pos_visible_p): Support positions in bidi-reordered lines.
7007 Save and restore bidi cache.
7009 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7010 (bidi_paragraph_info): Delete unused struct.
7011 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7012 (bidi_cache_start): New variable.
7013 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7015 (bidi_cache_fetch_state, bidi_cache_search)
7016 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7017 (bidi_cache_find, bidi_peek_at_next_level)
7018 (bidi_level_of_next_char, bidi_find_other_level_edge)
7019 (bidi_move_to_visually_next): Compare cache index with
7020 bidi_cache_start rather than with zero.
7021 (bidi_fetch_char): Accept new argument STRING; all callers
7022 changed. Support iteration over a string. Support strings with
7023 display properties. Support unibyte strings. Fix the type of
7024 `len' according to what STRING_CHAR_AND_LENGTH expects.
7025 (bidi_paragraph_init, bidi_resolve_explicit_1)
7026 (bidi_resolve_explicit, bidi_resolve_weak)
7027 (bidi_level_of_next_char, bidi_move_to_visually_next):
7028 Support iteration over a string.
7029 (bidi_set_sor_type, bidi_resolve_explicit_1)
7030 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7031 can now be zero (for strings); special values 0 and -1 were
7032 changed to -1 and -2, respectively.
7033 (bidi_char_at_pos): New function.
7034 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7035 Call it instead of FETCH_MULTIBYTE_CHAR.
7036 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7037 initialized to valid values.
7038 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7040 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7041 the test for valid cached positions. Fix the logic for looking up
7042 the sentinel state in the cache. GCPRO the Lisp string we are
7044 (bidi_push_it, bidi_pop_it): New functions.
7045 (bidi_initialize): Initialize the bidi cache start stack pointer.
7046 (bidi_cache_ensure_space): New function, refactored from part of
7047 bidi_cache_iterator_state. Don't assume the required size is just
7048 one BIDI_CACHE_CHUNK away.
7049 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7050 (bidi_count_bytes, bidi_char_at_pos): New functions.
7051 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7052 always valid if bidi_cache_idx is valid.
7053 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7054 is valid if it's going to be used.
7055 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7056 (bidi_cache_fetch_state, bidi_cache_search)
7057 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7058 (bidi_cache_iterator_state, bidi_cache_find)
7059 (bidi_find_other_level_edge, bidi_cache_start_stack):
7060 All variables related to cache indices are now EMACS_INT.
7062 * dispextern.h (struct bidi_string_data): New structure.
7063 (struct bidi_it): New member `string'. Make flag members be 1-bit
7064 fields, and put them last in the struct.
7065 (compute_display_string_pos, compute_display_string_end):
7067 (bidi_push_it, bidi_pop_it): Add prototypes.
7068 (struct iterator_stack_entry): New members bidi_p,
7069 paragraph_embedding, and from_disp_prop_p.
7070 (struct it): Member bidi_p is now a bit field 1 bit wide.
7071 (bidi_shelve_cache, bidi_unshelve_cache):
7074 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7075 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7076 and vector-like objects.
7078 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7079 cache around display iteration.
7081 * window.c (Fwindow_end, window_scroll_pixel_based)
7082 (displayed_window_lines, Frecenter): Save and restore the bidi
7083 cache around display iteration.
7085 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7087 * editfns.c (Fdelete_region): Clarify the use of the named
7088 parameters (bug#6788).
7090 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7092 * indent.c (Fvertical_motion): Set and restore w->pointm when
7093 saving and restoring the window's buffer (Bug#9006).
7095 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7097 * editfns.c (Fstring_to_char): Clarify just what is returned
7098 (bug#6576). Text by Eli Zaretskii.
7100 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7102 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7104 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7106 * buffer.c (mmap_find): Fix a typo.
7108 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7110 Fix execution of x selection hooks.
7111 * xselect.c (Qx_lost_selection_functions)
7112 (Qx_sent_selection_functions): New vars.
7113 (syms_of_xselect): DEFSYM them.
7114 (x_handle_selection_request): Pass Qx_sent_selection_functions
7115 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7116 (x_handle_selection_clear,x_clear_frame_selections):
7117 Pass Qx_lost_selection_functions rather than
7118 Vx_lost_selection_functions to Frun_hook_with_args.
7120 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7122 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7123 The old code sometimes used this field without initializing it.
7125 * alloc.c (gc_sweep): Don't read past end of array.
7126 In theory, the old code could also have corrupted Emacs internals,
7127 though it'd be very unlikely.
7129 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7131 * character.c (Fcharacterp): Don't advertise optional ignored
7132 argument. (Bug#4026)
7134 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7136 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7139 * window.c (Fset_window_start): Doc fix (bug#4199).
7140 (Fset_window_hscroll): Ditto.
7142 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7144 Fix minor new problems caught by GCC 4.6.1.
7145 * term.c (init_tty): Remove unused local.
7146 * xsettings.c (store_monospaced_changed): Define this function only
7147 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7150 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7152 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7154 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7156 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7157 are the mini-buffer and the echo area (bug#3320).
7159 * term.c (init_tty): Remove support for supdup, c10 and perq
7160 terminals, which are no longer supported (bug#1482).
7162 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7164 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7166 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7168 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7169 for non-popups (Bug#3642).
7171 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7173 * alloc.c (reset_malloc_hooks): Protoize.
7174 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7175 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7176 * cm.c (losecursor): Likewise.
7177 * data.c (fmod): Likewise.
7178 * dispnew.c (swap_glyphs_in_rows): Likewise.
7179 * emacs.c (memory_warning_signal): Likewise.
7180 * floatfns.c (float_error): Likewise.
7181 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7182 (otf_open, font_otf_capability, generate_otf_features)
7183 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7185 * image.c (pbm_read_file): Likewise.
7186 * indent.c (string_display_width): Likewise.
7187 * intervals.c (check_for_interval, search_for_interval)
7188 (inc_interval_count, count_intervals, root_interval)
7189 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7190 * lread.c (defalias): Likewise.
7191 * ralloc.c (r_alloc_check): Likewise.
7192 * regex.c (set_image_of_range_1, set_image_of_range)
7193 (regex_grow_registers): Likewise.
7194 * sysdep.c (strerror): Likewise.
7195 * termcap.c (valid_filename_p, tprint, main): Likewise.
7196 * tparam.c (main): Likewise.
7197 * unexhp9k800.c (run_time_remap, save_data_space)
7198 (update_file_ptrs, read_header, write_header, calculate_checksum)
7199 (copy_file, copy_rest, display_header): Likewise.
7200 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7202 * xdisp.c (check_it): Likewise.
7203 * xfaces.c (register_color, unregister_color, unregister_colors):
7205 * xfns.c (print_fontset_result): Likewise.
7206 * xrdb.c (member, fatal, main): Likewise.
7208 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7210 Fix minor problems found by static checking (Bug#9031).
7211 * chartab.c (char_table_set_range, map_sub_char_table):
7212 Remove unused locals.
7213 (uniprop_table): Now static.
7214 * composite.c (_work_char): Remove unused static var.
7216 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7218 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7220 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7222 * gtkutil.c (qttip_cb): Remove code without function.
7224 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7226 * w32.c (pthread_sigmask): New stub.
7228 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7230 Use pthread_sigmask, not sigprocmask (Bug#9010).
7231 sigprocmask is portable only for single-threaded applications, and
7232 Emacs can be multi-threaded when it uses GTK.
7233 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7235 * callproc.c (Fcall_process):
7236 * process.c (create_process):
7237 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7238 Use pthread_sigmask, not sigprocmask.
7240 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7242 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7243 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7246 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7248 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7249 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7250 (xg_hide_tooltip): Fix comment.
7252 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7253 in registerServicesMenuSendTypes.
7254 (validRequestorForSendType): Don't check ns_return_types.
7256 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7259 2011-07-08 Jason Rumney <jasonr@gnu.org>
7261 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7262 SH_SHOW for hidden windows (Bug#5482).
7264 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7265 frame struct members of non-existent frames (Bug#6284).
7267 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7269 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7270 variable firstTime not needed on OSX >= 10.6.
7271 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7272 >= 10.5. Use setKnobProportion, setDoubleValue.
7274 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7275 (MAC_OS_X_VERSION_10_5): Define if not defined.
7276 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7277 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7278 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7280 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7281 cString and lossyCString on OSX >= 10.4
7283 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7284 sizeToFit on OSX >= 10.2.
7286 * nsimage.m (allocInitFromFile): Don't use deprecated method
7287 bestRepresentationForDevice on OSX >= 10.6.
7289 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7292 * emacs.c: Declare unexec_init_emacs_zone.
7294 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7296 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7298 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7299 on svcsMenu (Bug#8842).
7301 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7303 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7305 * nsterm.m (QUTF8_STRING): Declare.
7306 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7307 (validRequestorForSendType): Return type is (id).
7308 Change indexOfObjectIdenticalTo to indexOfObject.
7309 Check if we have local selection before returning self (Bug#8842).
7310 (writeSelectionToPasteboard): Put local selection into paste board
7311 if we have a local selection (Bug#8842).
7312 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7314 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7315 (ns_get_local_selection): Declare.
7317 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7319 * keymap.c (describe_map_tree): Don't insert a double newline at
7320 the end of the buffer (bug#1169) and return whether we inserted
7323 * callint.c (Fcall_interactively): Change "reading args" to
7324 "providing args" to try to clarify what it does (bug#1010).
7326 2011-07-07 Kenichi Handa <handa@m17n.org>
7328 * composite.c (composition_compute_stop_pos): Ignore a static
7329 composition starting before CHARPOS (Bug#8915).
7331 * xdisp.c (handle_composition_prop): Likewise.
7333 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7335 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7338 2011-07-07 Kenichi Handa <handa@m17n.org>
7340 * character.h (unicode_category_t): New enum type.
7342 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7343 (Qchar_code_property_table): New variable.
7344 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7345 (UNIPROP_COMPRESSED_FORM_P): New macros.
7346 (char_table_ascii): Uncompress the compressed values.
7347 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7348 Uncompress the compressed values.
7349 (sub_char_table_ref_and_range): Likewise.
7350 (char_table_ref_and_range): Uncompress the compressed values.
7351 (sub_char_table_set): New arg is_uniprop. Callers changed.
7352 Uncompress the compressed values.
7353 (sub_char_table_set_range): Args changed. Callers changed.
7354 (char_table_set_range): Adjuted for the above change.
7355 (map_sub_char_table): Delete args default_val and parent. Add arg
7356 top. Give decoded values to a Lisp function.
7357 (map_char_table): Adjust for the above change. Give decoded
7358 values to a Lisp function. Gcpro more variables.
7359 (uniprop_table_uncompress)
7360 (uniprop_decode_value_run_length): New functions.
7361 (uniprop_decoder, uniprop_decoder_count): New variables.
7362 (uniprop_get_decoder, uniprop_encode_value_character)
7363 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7365 (uniprop_encoder, uniprop_encoder_count): New variables.
7366 (uniprop_get_encoder, uniprop_table)
7367 (Funicode_property_table_internal, Fget_unicode_property_internal)
7368 (Fput_unicode_property_internal): New functions.
7369 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7370 Sunicode_property_table_internal, Sget_unicode_property_internal,
7371 and Sput_unicode_property_internal. Defvar_lisp
7372 char-code-property-alist.
7374 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7375 Vunicode_category_table.
7377 * font.c (font_range): Adjust for the change of
7378 Vunicode_category_table.
7380 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7382 * m/iris4d.h: Remove file, move contents ...
7383 * s/irix6-5.h: ... here.
7385 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7387 Remove unportable assumption about struct layout (Bug#8884).
7388 * alloc.c (mark_buffer):
7389 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7390 (clone_per_buffer_values): Don't assume that
7391 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7392 This isn't true in general, and it's particularly not true
7393 if Emacs is configured with --with-wide-int.
7394 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7395 New macros, used in the buffer.c change.
7397 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7399 * xsettings.c: Use both GConf and GSettings if both are available.
7400 (store_config_changed_event): Add comment.
7401 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7402 (store_tool_bar_style_changed): New functions.
7403 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7404 (struct xsettings): Move font inside HAVE_XFT.
7405 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7406 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7407 Move inside HAVE_XFT.
7408 (something_changed_gsettingsCB): Rename from something_changedCB.
7409 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7411 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7412 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7413 (something_changed_gconfCB): Rename from something_changedCB.
7414 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7415 (parse_settings): Move check for font inside HAVE_XFT.
7416 (read_settings, apply_xft_settings): Add comment.
7417 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7418 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7419 call store_font_name_changed.
7420 (xft_settings_event): Add comment.
7421 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7422 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7423 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7424 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7425 (xsettings_initialize): Call init_gsettings last.
7426 (xsettings_get_system_font, xsettings_get_system_normal_font):
7429 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7431 Random fixes. E.g., (random) never returned negative values.
7432 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7433 subseconds part to the entropy, as that's a bit more random.
7434 Prefer signed to unsigned, since the signedness doesn't matter and
7435 in general we prefer signed. When given a limit, use a
7436 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7437 latter isn't right if USE_2_TAGS_FOR_INTS.
7438 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7439 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7441 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7443 * textprop.c (text_property_stickiness):
7444 Obey Vtext_property_default_nonsticky.
7445 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7446 * w32fns.c (syms_of_w32fns):
7447 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7449 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7451 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7452 This is more efficient than Ffile_directory_p and avoids a minor race.
7454 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7456 * buffer.c (Foverlay_put): Say what the return value is
7459 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7460 is a directory before asking whether to use the file name
7462 (barf_or_query_if_file_exists): Make the "File is a directory"
7463 error be more correct.
7465 * fns.c (Frequire): Remove the mention of the .gz files, since
7466 that's installation-specific, but keep the mention of
7467 `get-load-suffixes'.
7469 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7471 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7472 Report string overflow if the output is too long.
7474 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7476 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7477 (syms_of_gnutls): Remove duplicate DEFSYM for
7478 Qgnutls_bootprop_verify_hostname_error, an error for
7479 Qgnutls_bootprop_verify_error (which is no longer used).
7481 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7482 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7483 Also (re)move comments that are misplaced or no longer relevant.
7485 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7487 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7489 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7491 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7492 and background color parameters if they have been changed.
7494 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7496 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7498 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7500 * xsettings.c (SYSTEM_FONT): Define only when used.
7501 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7503 * keymap.c (access_keymap_1): Now static.
7505 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7507 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7508 leave any prefix arg for the up event (Bug#1586).
7510 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7512 * lread.c (syms_of_lread): Mention single symbols defined by
7513 `defvar' or `defconst' (bug#7154).
7515 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7516 (Frequire): Mention get-load-suffixes.
7518 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7520 * window.h (window): Remove clone_number slot.
7521 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7523 (make_parent_window, make_window, saved_window)
7524 (Fset_window_configuration, save_window_save): Don't deal with
7526 * buffer.c (Qclone_number): Remove declaration.
7527 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7529 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7531 Add multiple inheritance to keymaps.
7532 * keymap.c (Fmake_composed_keymap): New function.
7533 (Fset_keymap_parent): Simplify.
7534 (fix_submap_inheritance): Remove.
7535 (access_keymap_1): New function extracted from access_keymap to handle
7536 embedded parents and handle lists of maps.
7537 (access_keymap): Use it.
7538 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7539 (Fcopy_keymap): Handle embedded parents.
7540 (Fcommand_remapping, define_as_prefix): Simplify.
7541 (Fkey_binding): Simplify.
7542 (syms_of_keymap): Move minibuffer-local-completion-map,
7543 minibuffer-local-filename-completion-map,
7544 minibuffer-local-must-match-map, and
7545 minibuffer-local-filename-must-match-map to Elisp.
7546 (syms_of_keymap): Defsubr make-composed-keymap.
7547 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7548 (parse_menu_item): Trivial simplification.
7550 2011-07-01 Glenn Morris <rgm@gnu.org>
7552 * Makefile.in (SETTINGS_LIBS): Fix typo.
7554 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7556 * coding.c (Fencode_coding_string): Record the last coding system
7557 used, as the function doc string says (bug#8738).
7559 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7561 * xsettings.c (store_monospaced_changed): Take new font as arg and
7562 check for change against current_mono_font.
7563 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7564 (emacs_settings_constructor, emacs_settings_get_property)
7565 (emacs_settings_set_property, emacs_settings_class_init)
7566 (emacs_settings_init, gsettings_obj): Remove.
7567 (something_changedCB): New function for HAVE_GSETTINGS.
7568 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7569 with value as argument.
7570 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7571 g_settings_new (Bug#8967). Do not create gsettings_obj.
7572 Remove calls to g_settings_bind. Connect something_changedCB to
7575 * xgselect.c: Add defined (HAVE_GSETTINGS).
7576 (xgselect_initialize): Ditto.
7578 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7579 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7582 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7584 * eval.c (struct backtrace): Simplify and port the data structure.
7585 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7586 signed bit field, as this assumption is not portable and it makes
7587 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7588 "char debug_on_exit : 1" as this is not portable either; instead,
7589 use the portable "unsigned int debug_on_exit : 1". Remove unused
7590 member evalargs. Remove obsolete comments about cc bombing out.
7592 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7594 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7595 Let HAVE_GSETTINGS override HAVE_GCONF.
7596 (store_monospaced_changed): New function.
7597 (EMACS_SETTINGS): A new type derived from GObject to handle
7598 GSettings notifications.
7599 (emacs_settings_constructor, emacs_settings_get_property)
7600 (emacs_settings_set_property, emacs_settings_class_init):
7602 (gsettings_client, gsettings_obj): New variables.
7603 (GSETTINGS_SCHEMA): New define.
7604 (something_changedCB): Call store_monospaced_changed.
7605 (init_gsettings): New function.
7606 (xsettings_initialize): Call init_gsettings.
7607 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7610 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7613 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7615 * window.c (resize_root_window, grow_mini_window)
7616 (shrink_mini_window): Rename Qresize_root_window to
7617 Qwindow_resize_root_window and Qresize_root_window_vertically to
7618 Qwindow_resize_root_window_vertically.
7620 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7622 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7624 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7626 * makefile.w32-in: Redesign dependencies so they reflect more
7627 clearly which files are directly included by each source file,
7628 and not through other includes.
7630 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7632 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7633 (sort_overlays, overlay_strings): When an overlay's clone number
7634 matches the window's clone number process the overlay even if
7635 the overlay's window property doesn't match the current window.
7637 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7638 (Fwindow_hchild): Rename to Fwindow_left_child.
7639 (Fwindow_next): Rename to Fwindow_next_sibling.
7640 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7641 (resize_window_check): Rename to window_resize_check.
7642 (resize_window_apply): Rename to window_resize_apply.
7643 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7644 (Fdelete_other_windows_internal, resize_frame_windows)
7645 (Fsplit_window_internal, Fdelete_window_internal)
7646 (grow_mini_window, shrink_mini_window)
7647 (Fresize_mini_window_internal): Fix callers accordingly.
7649 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7651 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7652 (emacs_fixed_set_min_size): Remove.
7653 (emacs_fixed_new): Take frame as argument.
7655 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7656 (_EmacsFixedPrivate): Remove minwidth/height.
7657 Add struct frame *f.
7658 (emacs_fixed_init): Initialize priv->f.
7659 (get_parent_class, emacs_fixed_set_min_size): Remove.
7660 (emacs_fixed_new): Set priv->f to argument.
7661 (emacs_fixed_get_preferred_width)
7662 (emacs_fixed_get_preferred_height): Use min_width/height from
7663 frames size_hint to set minimum and natural (Bug#8919).
7664 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7665 and use min_width/height from frames size_hint to set
7666 min_width/height (Bug#8919).
7668 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7669 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7672 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7674 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7675 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7678 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7680 * process.c (wait_reading_process_output): Bypass select if
7681 waiting for a cell while ignoring keyboard input, and input is
7682 pending. Suggested by Jan Djärv (Bug#8869).
7684 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7686 Use gnulib's dup2 module instead of rolling our own.
7687 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7689 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7691 * dispnew.c (scrolling_window): Before scrolling, turn off a
7692 mouse-highlight in the window being scrolled.
7694 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7696 Move DEFSYM to lisp.h and use everywhere.
7698 * character.h (DEFSYM): Move declaration...
7699 * lisp.h (DEFSYM): ...here.
7705 * w32select.c: Don't include character.h.
7707 * alloc.c (syms_of_alloc):
7708 * buffer.c (syms_of_buffer):
7709 * bytecode.c (syms_of_bytecode):
7710 * callint.c (syms_of_callint):
7711 * casefiddle.c (syms_of_casefiddle):
7712 * casetab.c (init_casetab_once):
7713 * category.c (init_category_once, syms_of_category):
7714 * ccl.c (syms_of_ccl):
7715 * cmds.c (syms_of_cmds):
7716 * composite.c (syms_of_composite):
7717 * dbusbind.c (syms_of_dbusbind):
7718 * dired.c (syms_of_dired):
7719 * dispnew.c (syms_of_display):
7720 * doc.c (syms_of_doc):
7721 * editfns.c (syms_of_editfns):
7722 * emacs.c (syms_of_emacs):
7723 * eval.c (syms_of_eval):
7724 * fileio.c (syms_of_fileio):
7725 * fns.c (syms_of_fns):
7726 * frame.c (syms_of_frame):
7727 * fringe.c (syms_of_fringe):
7728 * insdel.c (syms_of_insdel):
7729 * keymap.c (syms_of_keymap):
7730 * lread.c (init_obarray, syms_of_lread):
7731 * macros.c (syms_of_macros):
7732 * msdos.c (syms_of_msdos):
7733 * print.c (syms_of_print):
7734 * process.c (syms_of_process):
7735 * search.c (syms_of_search):
7736 * sound.c (syms_of_sound):
7737 * syntax.c (init_syntax_once, syms_of_syntax):
7738 * terminal.c (syms_of_terminal):
7739 * textprop.c (syms_of_textprop):
7740 * undo.c (syms_of_undo):
7741 * w32.c (globals_of_w32):
7742 * window.c (syms_of_window):
7743 * xdisp.c (syms_of_xdisp):
7744 * xfaces.c (syms_of_xfaces):
7745 * xfns.c (syms_of_xfns):
7746 * xmenu.c (syms_of_xmenu):
7747 * xsettings.c (syms_of_xsettings):
7748 * xterm.c (syms_of_xterm): Use DEFSYM.
7750 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7752 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7754 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7756 Integer and buffer overflow fixes (Bug#8873).
7758 * print.c (printchar, strout): Check for string overflow.
7759 (PRINTPREPARE, printchar, strout):
7760 Don't set size unless allocation succeeds.
7762 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7763 for sizes. Check for string overflow more accurately.
7764 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7766 * macros.c: Integer and buffer overflow fixes.
7767 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7768 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7769 Use ptrdiff_t, not int, for sizes.
7770 Don't increment bufsize until after realloc succeeds.
7771 Check for size-calculation overflow.
7772 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7774 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7776 * lread.c: Integer overflow fixes.
7777 (read_integer): Radix is now EMACS_INT, not int,
7778 to improve quality of diagnostics for out-of-range radices.
7779 Calculate buffer size correctly for out-of-range radices.
7780 (read1): Check for integer overflow in radices, and in
7781 read-circle numbers.
7782 (read_escape): Avoid int overflow.
7783 (Fload, openp, read_buffer_size, read1)
7784 (substitute_object_recurse, read_vector, read_list, map_obarray):
7785 Use ptrdiff_t, not int, for sizes.
7786 (read1): Use EMACS_INT, not int, for sizes.
7787 Check for size overflow.
7789 * image.c (cache_image): Check for size arithmetic overflow.
7791 * lread.c: Integer overflow issues.
7792 (saved_doc_string_size, saved_doc_string_length)
7793 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7794 Now ptrdiff_t, not int.
7795 (read1): Don't assume doc string length fits in int. Check for
7796 out-of-range doc string lengths.
7797 (read_list): Don't assume file position fits in int.
7798 (read_escape): Check for hex character overflow.
7800 2011-06-22 Leo Liu <sdl.web@gmail.com>
7802 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7803 Move to minibuffer.el.
7805 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7807 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7808 The following patches are for when GLYPH_DEBUG && !XASSERT.
7809 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7810 * dispnew.c (flush_stdout):
7811 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7812 Mark as externally visible.
7813 * dispnew.c (check_window_matrix_pointers): Now static.
7814 * dispnew.c (window_to_frame_vpos):
7815 * xfns.c (unwind_create_frame):
7816 * xterm.c (x_check_font): Remove unused local.
7817 * scroll.c (CHECK_BOUNDS):
7818 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7819 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7820 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7821 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7822 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7824 (debug_method_add): Use va_list and vsprintf rather than relying
7825 on undefined behavior with wrong number of arguments.
7826 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7827 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7828 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7829 since we're not interested in debugging glyphs with old libraries.
7830 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7831 GCC 4.6.0's static checking.
7833 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7835 Integer overflow and signedness fixes (Bug#8873).
7836 A few related buffer overrun fixes, too.
7838 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7840 * dispextern.h (struct face.stipple):
7841 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7842 (x_bitmap_mask, x_allocate_bitmap_record)
7843 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7844 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7845 (x_create_bitmap_from_xpm_data):
7846 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7847 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7849 * xfaces.c (load_pixmap):
7850 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7851 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7852 (.bitmaps_last, struct x_output.icon_bitmap):
7853 Use ptrdiff_t, not int, for bitmap indexes.
7854 (x_allocate_bitmap_record): Check for size overflow.
7855 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7857 Use ptrdiff_t, not int, for overlay counts.
7858 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7859 * editfns.c (overlays_around, get_pos_property):
7860 * textprop.c (get_char_property_and_overlay):
7861 * xdisp.c (next_overlay_change, note_mouse_highlight):
7862 * xfaces.c (face_at_buffer_position):
7863 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7864 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7865 (Fnext_overlay_change, Fprevious_overlay_change)
7866 (mouse_face_overlay_overlaps, Foverlays_in):
7867 Use ptrdiff_t, not int, for sizes.
7868 (overlays_at, overlays_in): Check for size-calculation overflow.
7870 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7872 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7873 (x_session_initialize): Do not assume string length fits in int.
7875 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7876 This is unlikely, but can occur if DPI is outlandish.
7878 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7879 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7881 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7882 * xrdb.c (magic_file_p, search_magic_path):
7883 Omit last arg SUFFIX; it was always 0. All callers changed.
7884 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7886 * xfont.c (xfont_match): Avoid need for strlen.
7888 * xfns.c: Don't assume strlen fits in int.
7889 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7891 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7892 not unsigned long, as we prefer signed integers. All callers changed.
7893 Detect integer overflow in repeat count.
7894 (message_dolog): Don't assume print length fits in 39 bytes.
7895 (display_mode_element): Don't assume strlen fits in int.
7897 * termcap.c: Don't assume sizes fit in int and never overflow.
7898 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7899 (gobble_line): Check for size-calculation overflow.
7901 * minibuf.c (Fread_buffer):
7902 * lread.c (intern, intern_c_string):
7903 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7904 Don't assume string length fits in int.
7906 * keyboard.c (parse_tool_bar_item):
7907 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7909 * font.c: Don't assume string length fits in int.
7910 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7911 Use ptrdiff_t, not int.
7912 (font_intern_prop): Don't assume string length fits in int.
7913 Don't assume integer property fits in fixnum.
7914 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7916 * filelock.c: Fix some buffer overrun and integer overflow issues.
7917 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7918 Reformulate so as not to need the command string.
7919 Invoke gzip -cd rather than gunzip, as it's more portable.
7920 (lock_info_type, lock_file_1, lock_file):
7921 Don't assume pid_t and time_t fit in unsigned long.
7922 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7923 (current_lock_owner): Prefer signed type for sizes.
7924 Use memcpy, not strncpy, where memcpy is what is really wanted.
7925 Don't assume (via atoi) that time_t and pid_t fit in int.
7926 Check for time_t and/or pid_t out of range, e.g., via a network share.
7927 Don't alloca where an auto var works fine.
7929 * fileio.c: Fix some integer overflow issues.
7930 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7931 Don't assume string length fits in int.
7932 (directory_file_name): Don't assume string length fits in long.
7933 (make_temp_name): Don't assume pid fits in int, or that its print
7934 length is less than 20.
7936 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7938 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7940 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7942 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7943 We prefer signed integers, even for size calculations.
7945 * emacs.c: Don't assume string length fits in 'int'.
7946 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7947 (main): Don't invoke strlen when not needed.
7949 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7950 (XD_DEBUG_MESSAGE): Don't waste a byte.
7952 * callproc.c (getenv_internal_1, getenv_internal)
7954 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7956 * lread.c (invalid_syntax): Omit length argument.
7957 All uses changed. This doesn't fix a bug, but it simplifies the
7958 code away from its former Hollerith-constant appearance, and it's
7959 one less 'int' to worry about when looking at integer-overflow issues.
7960 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7962 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7963 This didn't break anything, but it didn't help either.
7964 It's confusing to put a bogus integer in a place where the actual
7965 value does not matter.
7966 (LIST_END_P): Remove unused macro and its bogus comment.
7967 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7969 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7970 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7972 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7973 We prefer signed types, and the value cannot exceed the EMACS_INT
7974 range anyway (because otherwise the length would not be representable).
7975 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7976 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7977 This avoids a GCC warning when WIDE_EMACS_INT.
7979 * indent.c (sane_tab_width): New function.
7980 (current_column, scan_for_column, Findent_to, position_indentation)
7981 (compute_motion): Use it. This is just for clarity.
7982 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7984 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7986 * lisp.h (lint_assume): New macro.
7987 * composite.c (composition_gstring_put_cache):
7988 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7990 * editfns.c, insdel.c:
7991 Omit unnecessary forward decls, to simplify future changes.
7993 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7995 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7997 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7998 Use much-faster test for byte-length change.
7999 Don't assume string byte-length fits in 'int'.
8000 Check that character arg fits in 'int'.
8001 (mapcar1): Declare byte as byte, for clarity.
8003 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8005 * fns.c (concat): Catch string overflow earlier.
8006 Do not rely on integer wraparound.
8008 * dispextern.h (struct it.overlay_strings_charpos)
8009 (struct it.selective): Now EMACS_INT, not int.
8010 * xdisp.c (forward_to_next_line_start)
8011 (back_to_previous_visible_line_start)
8012 (reseat_at_next_visible_line_start, next_element_from_buffer):
8013 Don't arbitrarily truncate the value of 'selective' to int.
8015 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8017 * composite.c: Don't truncate sizes to 'int'.
8018 (composition_gstring_p, composition_reseat_it)
8019 (composition_adjust_point): Use EMACS_INT, not int.
8020 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8021 not EMACS_UINT, for indexes.
8023 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8025 * buffer.c: Include <verify.h>.
8026 (struct sortvec.priority, struct sortstr.priority):
8027 Now EMACS_INT, not int.
8028 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8029 (struct sortstr.size, record_overlay_string)
8030 (struct sortstrlist.size, struct sortlist.used):
8031 Don't truncate size to int.
8032 (record_overlay_string): Check for size-calculation overflow.
8033 (init_buffer_once): Check at compile-time, not run-time.
8035 2011-06-22 Jim Meyering <meyering@redhat.com>
8037 Don't leak an XBM-image-sized buffer
8038 * image.c (xbm_load): Free the image buffer after using it.
8040 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8043 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8044 that Sun C diagnosed.
8045 * fns.c (secure_hash): Fix pointer signedness issue.
8046 * intervals.c (static_offset_intervals): New function.
8047 (offset_intervals): Use it.
8049 2011-06-21 Leo Liu <sdl.web@gmail.com>
8052 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8055 * fns.c (secure_hash): Rename from crypto_hash_function and change
8056 the first arg to accept symbols.
8057 (Fsecure_hash): New primitive.
8058 (syms_of_fns): New symbols.
8060 2011-06-20 Deniz Dogan <deniz@dogan.se>
8062 * process.c (Fset_process_buffer): Clarify return value in
8065 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8067 * dispnew.c (add_window_display_history): Use BVAR.
8069 * xdisp.c (debug_method_add): Use BVAR.
8070 (check_window_end, dump_glyph_matrix, dump_glyph)
8071 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8073 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8076 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8077 check till after the cache is created in init_frame_faces.
8079 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8081 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8083 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8085 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8086 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8087 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8089 Improve buffer-overflow checking (Bug#8873).
8090 * fileio.c (Finsert_file_contents):
8091 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8092 Remove the old (too-loose) buffer overflow checks.
8093 They weren't needed, since make_gap checks for buffer overflow.
8094 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8095 The old code merely checked for Emacs fixnum overflow, and relied
8096 on undefined (wraparound) behavior. The new code avoids undefined
8097 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8099 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8100 Tune. Don't use wider integers than needed. Don't use alloca.
8101 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8103 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8105 * insdel.c, lisp.h (buffer_overflow): New function.
8106 (insert_from_buffer_1, replace_range, replace_range_2):
8107 * insdel.c (make_gap_larger):
8108 * editfns.c (Finsert_char):
8109 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8111 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8113 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8115 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8117 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8118 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8120 * fileio.c: Don't assume EMACS_INT fits in off_t.
8121 (emacs_lseek): New static function.
8122 (Finsert_file_contents, Fwrite_region): Use it.
8123 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8125 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8127 * fns.c: Don't overflow int when computing a list length.
8128 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8129 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8130 truncation on 64-bit hosts. Check for QUIT every
8131 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8132 faster and is responsive enough.
8133 (Flength): Report an error instead of overflowing an integer.
8134 (Fsafe_length): Return a float if the value is not representable
8135 as a fixnum. This shouldn't happen except in contrived situations.
8136 (Fnthcdr, Fsort): Don't assume list length fits in int.
8137 (Fcopy_sequence): Don't assume vector length fits in int.
8139 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8140 (header_size, word_size): New constants.
8141 (allocate_vectorlike): Don't check size overflow here.
8142 (allocate_vector): Check it here instead, since this is the only
8143 caller of allocate_vectorlike that could cause overflow.
8144 Check that the new vector's length is representable as a fixnum.
8146 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8147 The previous code was bogus. For example, next_almost_prime (32)
8148 returned 39, which is undesirable as it is a multiple of 3; and
8149 next_almost_prime (24) returned 25, which is a multiple of 5 so
8150 why was the code bothering to check for multiples of 7?
8152 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8154 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8156 Variadic C functions now count arguments with ptrdiff_t.
8157 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8158 Back then I didn't know that the Emacs coding style prefers signed int.
8159 Also, in the meantime I found a few more instances where arguments
8160 were being counted with int, which may truncate counts on 64-bit
8161 machines, or EMACS_INT, which may be unnecessarily wide.
8162 * lisp.h (struct Lisp_Subr.function.aMANY)
8163 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8164 Arg counts are now ptrdiff_t, not size_t.
8165 All variadic functions and their callers changed accordingly.
8166 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8167 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8168 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8169 * callint.c (Fcall_interactively): Check arg count for overflow,
8170 to avoid potential buffer overrun. Use signed char, not 'int',
8171 for 'varies' array, so that we needn't bother to check its size
8172 calculation for overflow.
8173 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8174 * eval.c (apply_lambda):
8175 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8176 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8177 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8179 * callint.c (Fcall_interactively): Don't use index var as event count.
8181 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8182 * mem-limits.h (SIZE): Remove; no longer used.
8184 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8186 Remove unnecessary casts.
8187 * xterm.c (x_term_init):
8188 * xfns.c (x_set_border_pixel):
8189 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8190 These aren't needed now that we assume ANSI C.
8192 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8193 It's more likely to cause problems (due to unsigned overflow)
8196 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8198 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8200 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8202 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8204 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8206 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8208 GLYPH_CODE_FACE returns EMACS_INT, not int.
8209 * dispextern.h (merge_faces):
8210 * xfaces.c (merge_faces):
8211 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8212 Don't assume EMACS_INT fits in int.
8214 * character.h (CHAR_VALID_P): Remove unused parameter.
8215 * fontset.c, lisp.h, xdisp.c: All uses changed.
8217 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8219 * fns.c (concat): Minor tuning based on overflow analysis.
8220 This doesn't fix any bugs. Use int to hold character, instead
8221 of constantly refetching from Emacs object. Use XFASTINT, not
8222 XINT, for value known to be a character. Don't bother comparing
8223 a single byte to 0400, as it's always less.
8225 * floatfns.c (Fexpt):
8226 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8228 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8231 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8233 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8234 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8235 incorrectly succeed when S was a string, because 4294967386 was
8236 truncated before it was used.
8238 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8239 Otherwise, an out-of-range integer could cause undefined behavior
8242 * composite.c: Use int, not EMACS_INT, for characters.
8243 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8244 EMACS_INT, for values that are known to be in character range.
8245 This doesn't fix any bugs but is the usual style inside Emacs and
8246 may generate better code on 32-bit machines.
8248 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8249 This is for reasons similar to the recent CHAR_STRING fix.
8250 * charset.c (Fencode_char): Check that character arg is actually
8251 a character. Pass an int to ENCODE_CHAR.
8252 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8253 wider than 'int', as a compile-time check to prevent future regressions
8256 * character.c (char_string): Remove unnecessary casts.
8258 Make sure a 64-bit char is never passed to CHAR_STRING.
8259 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8260 by silently ignoring the top 32 bits, allowing some values
8261 that were far too large to be valid characters.
8262 * character.h: Include <verify.h>.
8263 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8264 arguments are no wider than unsigned, as a compile-time check
8265 to prevent future regressions in this area.
8267 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8268 (Fsubst_char_in_region):
8270 * xdisp.c (decode_mode_spec_coding):
8271 Adjust to CHAR_STRING's new requirement.
8272 * editfns.c (Finsert_char, Fsubst_char_in_region):
8273 * fns.c (concat): Check that character args are actually
8274 characters. Without this test, these functions did the wrong
8275 thing with wildly out-of-range values on 64-bit hosts.
8277 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8278 These casts should not be needed on 32-bit hosts, either.
8279 * keyboard.c (read_char):
8280 * lread.c (Fload): Remove casts to unsigned.
8282 * lisp.h (UNSIGNED_CMP): New macro.
8283 This fixes comparison bugs on 64-bit hosts.
8284 (ASCII_CHAR_P): Use it.
8285 * casefiddle.c (casify_object):
8286 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8287 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8288 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8289 * dispextern.h (FACE_FROM_ID):
8290 * keyboard.c (read_char): Use UNSIGNED_CMP.
8292 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8293 not to EMACS_INT, to avoid GCC warning.
8295 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8297 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8298 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8299 isn't needed on 32-bit machines.
8301 * buffer.c (Fgenerate_new_buffer_name):
8302 Use EMACS_INT for count, not int.
8303 (advance_to_char_boundary): Return EMACS_INT, not int.
8305 * data.c (Qcompiled_function): Now static.
8307 * window.c (window_body_lines): Now static.
8309 * image.c (gif_load): Rename local to avoid shadowing.
8311 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8312 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8313 * alloc.c (make_save_value): Integer argument is now of type
8315 (mark_object): Use ptrdiff_t, not int.
8316 * lisp.h (pD): New macro.
8317 * print.c (print_object): Use it.
8319 * alloc.c: Use EMACS_INT, not int, to count objects.
8320 (total_conses, total_markers, total_symbols, total_vector_size)
8321 (total_free_conses, total_free_markers, total_free_symbols)
8322 (total_free_floats, total_floats, total_free_intervals)
8323 (total_intervals, total_strings, total_free_strings):
8324 Now EMACS_INT, not int. All uses changed.
8325 (Fgarbage_collect): Compute overall total using a double, so that
8326 integer overflow is less likely to be a problem. Check for overflow
8327 when converting back to an integer.
8328 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8329 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8330 These were 'int' variables that could overflow on 64-bit hosts;
8331 they were never used, so remove them instead of repairing them.
8332 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8333 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8334 Previously, this ceilinged at INT_MAX, but that doesn't work on
8336 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8338 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8339 (allocate_vectorlike): Check for ptrdiff_t overflow.
8340 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8341 when a (possibly-narrower) signed value would do just as well.
8342 We prefer using signed arithmetic, to avoid comparison confusion.
8344 * alloc.c: Catch some string size overflows that we were missing.
8345 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8346 for convenience in STRING_BYTES_MAX.
8347 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8348 The definition here is exact; the one in lisp.h was approximate.
8349 (allocate_string_data): Check for string overflow. This catches
8350 some instances we weren't catching before. Also, it catches
8351 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8352 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8353 and ptrdiff_t and EMACS_INT are both 64 bits.
8355 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8356 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8357 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8359 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8361 * alloc.c (Fmake_string): Check for out-of-range init.
8363 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8365 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8367 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8369 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8370 xg_get_default_scrollbar_width.
8372 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8373 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8374 (style_changed_cb): Call update_theme_scrollbar_width and call
8375 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8376 all frames (Bug#8505).
8377 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8378 Call gtk_window_set_resizable if HAVE_GTK3.
8379 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8380 and height if HAVE_GTK3 (Bug#8505).
8381 (scroll_bar_width_for_theme): New variable.
8382 (update_theme_scrollbar_width): New function.
8383 (xg_get_default_scrollbar_width): Move code to
8384 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8385 (xg_initialize): Call update_theme_scrollbar_width.
8387 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8389 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8391 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8393 * frame.c (make_frame): Call other_buffer_safely instead of
8396 * window.c (temp_output_buffer_show): Call display_buffer with
8397 second argument Vtemp_buffer_show_specifiers and reset latter
8398 immediately after the call.
8399 (Vtemp_buffer_show_specifiers): New variable.
8400 (auto_window_vscroll_p, next_screen_context_lines)
8401 (Vscroll_preserve_screen_position): Remove leading asterisks from
8404 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8406 Fix minor problems found by GCC 4.6.0 static checking.
8407 * buffer.c (Qclone_number): Remove for now, as it's unused.
8408 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8409 (record_buffer): Remove unused local.
8410 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8411 (set_frame_buffer_list): Remove; unused.
8412 * frame.h (other_visible_frames): Remove decl.
8413 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8414 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8415 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8417 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8418 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8419 Define only if HAVE_GPM.
8420 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8421 (update_hints_inhibit): Remove; never set. All uses removed.
8422 * widgetprv.h (emacsFrameClassRec): Remove decl.
8423 * window.c (delete_deletable_window): Now returns void, since it
8424 wasn't returning anything.
8425 (compare_window_configurations): Remove unused locals.
8426 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8427 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8428 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8429 the same widths as pointers. This follows up on the 2011-05-06 patch.
8430 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8431 * xterm.h: Likewise.
8432 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8434 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8436 * makefile.w32-in: Update dependencies.
8437 (LISP_H): Add lib/intprops.h.
8439 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8441 * image.c (gif_load): Add animation frame delay to the metadata.
8442 (syms_of_image): Use DEFSYM. New symbol `delay'.
8444 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8446 * window.c (delete_deletable_window): Re-add.
8447 (Fset_window_configuration): Rewrite to handle dead buffers and
8448 consequently deletable windows.
8449 (window_tree, Fwindow_tree): Remove. Supply functionality in
8451 (compare_window_configurations): Simplify code.
8453 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8455 * image.c (imagemagick_load_image): Fix type mismatch.
8456 (Fimagemagick_types): Likewise.
8458 * window.h (replace_buffer_in_windows): Declare.
8460 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8462 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8463 Qclone_number. Remove external declaration of Qdelete_window.
8464 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8466 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8467 Run Qbuffer_list_update_hook if allowed.
8468 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8469 buffer list implementation.
8470 (other_buffer_safely): New function.
8471 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8472 calls to replace_buffer_in_windows and
8473 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8475 (record_buffer): Inhibit quitting and rewrite using quittable
8476 functions. Run Qbuffer_list_update_hook if allowed.
8477 (Frecord_buffer, Funrecord_buffer): New functions.
8478 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8479 Move switch-to-buffer to window.el.
8480 (bury-buffer): Move to window.el.
8481 (Vbuffer_list_update_hook): New variable.
8483 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8486 * window.h (resize_frame_windows): Move up in code.
8487 (Fwindow_frame): Remove EXFUN.
8488 (replace_buffer_in_all_windows): Remove prototype.
8489 (replace_buffer_in_windows_safely): Add prototype.
8491 * window.c: Declare Qdelete_window static again. Move down
8492 declaration of select_count.
8493 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8494 (Fother_window): Move to window.el.
8495 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8496 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8497 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8499 (replace_buffer_in_windows): Implement by calling
8500 Qreplace_buffer_in_windows.
8501 (replace_buffer_in_all_windows): Remove with some functionality
8502 moved into replace_buffer_in_windows_safely.
8503 (replace_buffer_in_windows_safely): New function.
8504 (select_window_norecord, select_frame_norecord): Move in front
8505 of run_window_configuration_change_hook. Remove now obsolete
8507 (Fset_window_buffer): Rewrite doc-string.
8508 Call Qrecord_window_buffer.
8509 (keys_of_window): Move binding for other-window to window.el.
8511 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8513 * dispextern.h (struct image): Replace data member, whose int_val
8514 and ptr_val fields were not used by anything, with a single
8517 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8518 (gif_clear_image, gif_load, imagemagick_load_image)
8519 (gs_clear_image, gs_load): Callers changed.
8521 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8523 * buffer.h: Include <time.h>, for time_t.
8524 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8526 Fix minor problems found by static checking.
8528 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8530 Make identifiers static if they are not used in other modules.
8531 * data.c (Qcompiled_function, Qframe, Qvector):
8532 * image.c (QimageMagick, Qsvg):
8533 * minibuf.c (Qmetadata):
8534 * window.c (resize_window_check, resize_root_window): Now static.
8535 * window.h (resize_window_check, resize_root_window): Remove decls.
8537 * window.c (window_deletion_count, delete_deletable_window):
8539 (window_body_lines): Now static.
8540 (Fdelete_other_windows_internal): Mark vars as initialized.
8541 Make sure 'resize_failed' is initialized.
8542 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8543 (resize_window_apply): Remove unused local.
8544 * window.h (delete_deletable_window): Remove decl.
8546 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8547 (imagemagick_load_image): Fix pointer signedness problem by changing
8548 last arg from unsigned char * to char *. All uses changed.
8549 Also, fix a local for similar reasons.
8550 Remove unused locals. Remove locals to avoid shadowing.
8551 (fn_rsvg_handle_free): Remove; unused.
8552 (svg_load, svg_load_image): Fix pointer signedness problem.
8553 (imagemagick_load_image): Don't use garbage pointer image_wand.
8555 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8557 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8559 * image.c (gif_load): Fix omitted cast error introduced by
8562 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8564 * window.h (resize_proportionally, orig_total_lines)
8565 (orig_top_line): Remove from window structure.
8566 (set_window_height, set_window_width, change_window_heights)
8567 (Fdelete_window): Remove prototypes.
8568 (resize_frame_windows): Remove duplicate declaration.
8570 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8572 * window.h (resize_frame_windows, resize_window_check)
8573 (delete_deletable_window, resize_root_window)
8574 (resize_frame_windows): Declare prototypes.
8576 * window.c (resize_window_apply): Make definition be "static" to
8577 match the prototype.
8579 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8581 * window.c: Remove declarations of Qwindow_size_fixed,
8582 window_min_size_1, window_min_size_2, window_min_size,
8583 size_window, window_fixed_size_p, enlarge_window, delete_window.
8584 Remove static from declaration of Qdelete_window, it's
8585 temporarily needed by Fbury_buffer.
8586 (replace_window): Don't assign orig_top_line and
8588 (Fdelete_window, delete_window): Remove. Window deletion is
8589 handled by window.el.
8590 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8591 Replace Fdelete_window calls with calls to Qdelete_window.
8592 (Fdelete_other_windows): Remove. Deleting other windows is
8593 handled by window.el.
8594 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8595 handled in window.el.
8596 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8597 Window minimum sizes are handled in window.el.
8598 (shrink_windows, size_window, set_window_height)
8599 (set_window_width, change_window_heights, window_height)
8600 (window_width, CURBEG, CURSIZE, enlarge_window)
8601 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8602 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8603 handled in window.el.
8604 (make_dummy_parent): Rename to make_parent_window and give it a
8605 second argument horflag.
8606 (make_window): Don't set resize_proportionally any more.
8607 (Fsplit_window): Remove. Windows are split in window.el.
8608 (save_restore_action, save_restore_orig_size)
8609 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8610 Resize mini windows in window.el.
8611 (grow_mini_window, shrink_mini_window): Implement by calling
8612 Qresize_root_window_vertically, resize_window_check and
8613 resize_window_apply.
8614 (saved_window, Fset_window_configuration, save_window_save):
8615 Do not handle orig_top_line, orig_total_lines, and
8616 resize_proportionally.
8617 (window_min_height, window_min_width): Move to window.el.
8618 (keys_of_window): Move bindings for delete-other-windows,
8619 split-window, delete-window and enlarge-window to window.el.
8621 * buffer.c: Temporarily extern Qdelete_window.
8622 (Fbury_buffer): Temporarily call Qdelete_window instead of
8623 Fdelete_window (Fbury_buffer will move to window.el soon).
8625 * frame.c (set_menu_bar_lines_1): Remove code handling
8626 orig_top_line and orig_total_lines.
8628 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8629 set_window_height but set heights directly.
8630 (change_frame_size_1): Use resize_frame_windows.
8632 * xdisp.c (init_xdisp): Don't use set_window_height but set
8635 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8636 Use resize_frame_windows instead of change_window_heights and run
8637 run_window_configuration_change_hook.
8639 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8640 instead of change_window_heights and run
8641 run_window_configuration_change_hook.
8643 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8645 * window.c (replace_window): Rename second argument REPLACEMENT to
8646 NEW. New third argument SETFLAG. Rewrite.
8647 (delete_window, make_dummy_parent): Call replace_window with
8649 (window_list_1): Move down in code.
8650 (run_window_configuration_change_hook): Move set_buffer part
8651 before select_frame_norecord part in order to unwind correctly.
8652 Rename count1 to count.
8653 (recombine_windows, delete_deletable_window, resize_root_window)
8654 (Fdelete_other_windows_internal)
8655 (Frun_window_configuration_change_hook, make_parent_window)
8656 (resize_window_check, resize_window_apply, Fresize_window_apply)
8657 (resize_frame_windows, Fsplit_window_internal)
8658 (Fdelete_window_internal, Fresize_mini_window_internal):
8660 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8662 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8664 * window.h (window): Add some new members to window structure -
8665 normal_lines, normal_cols, new_total, new_normal, clone_number,
8666 splits, nest, prev_buffers, next_buffers.
8667 (WINDOW_TOTAL_SIZE): Move here from window.c.
8668 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8670 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8672 (make_dummy_parent): Set new members of windows structure.
8673 (make_window): Move down in code. Handle new members of window
8675 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8676 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8677 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8678 (Fset_window_prev_buffers, Fwindow_next_buffers)
8679 (Fset_window_next_buffers, Fset_window_clone_number):
8681 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8682 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8684 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8685 Argument WINDOW can be now internal window too.
8686 (Fwindow_use_time): Move up in code.
8687 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8689 (Fset_window_configuration, saved_window)
8690 (Fcurrent_window_configuration, save_window_save): Handle new
8691 members of window structure.
8692 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8693 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8694 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8695 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8696 Qget_mru_window, Qresize_root_window,
8697 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8698 Qauto_buffer_name; staticpro them.
8700 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8702 * window.c (Fwindow_total_size, Fwindow_left_column)
8703 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8704 (Fwindow_list_1): New functions.
8705 (window_box_text_cols): Replace with window_body_cols.
8706 (Fwindow_width, Fscroll_left, Fscroll_right):
8707 Use window_body_cols instead of window_box_text_cols.
8708 (delete_window, Fset_window_configuration):
8709 Call delete_all_subwindows with window as argument.
8710 (delete_all_subwindows): Take a window as argument and not a
8712 (window_loop): Remove handling of GET_LRU_WINDOW and
8714 (Fget_lru_window, Fget_largest_window): Move to window.el.
8716 * window.h: Extern window_body_cols instead of
8717 window_box_text_cols. delete_all_subwindows now takes a
8718 Lisp_Object as argument.
8720 * indent.c (compute_motion, Fcompute_motion):
8721 Use window_body_cols instead of window_box_text_cols.
8723 * frame.c (delete_frame): Call delete_all_subwindows with root
8726 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8728 * fns.c (Fputhash): Document return value.
8730 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8732 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8734 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8736 Cons<->int and similar integer overflow fixes (Bug#8794).
8738 Check for overflow when converting integer to cons and back.
8739 * charset.c (Fdefine_charset_internal, Fdecode_char):
8740 Use cons_to_unsigned to catch overflow.
8741 (Fencode_char): Use INTEGER_TO_CONS.
8742 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8743 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8744 * data.c (long_to_cons, cons_to_long): Remove.
8745 (cons_to_unsigned, cons_to_signed): New functions.
8746 These signal an error for invalid or out-of-range values.
8747 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8748 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8749 * font.c (Ffont_variation_glyphs):
8750 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8751 * lisp.h: Include <intprops.h>.
8752 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8753 (cons_to_signed, cons_to_unsigned): New decls.
8754 (long_to_cons, cons_to_long): Remove decls.
8755 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8756 (Fprimitive_undo): Use CONS_TO_INTEGER.
8757 * xfns.c (Fx_window_property): Likewise.
8758 * xselect.c: Include <limits.h>.
8759 (x_own_selection, selection_data_to_lisp_data):
8760 Use INTEGER_TO_CONS.
8761 (x_handle_selection_request, x_handle_selection_clear)
8762 (x_get_foreign_selection, Fx_disown_selection_internal)
8763 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8764 (lisp_data_to_selection_data): Use cons_to_unsigned.
8765 (x_fill_property_data): Use cons_to_signed.
8766 Report values out of range.
8768 Check for buffer and string overflow more precisely.
8769 * buffer.h (BUF_BYTES_MAX): New macro.
8770 * lisp.h (STRING_BYTES_MAX): New macro.
8771 * alloc.c (Fmake_string):
8772 * character.c (string_escape_byte8):
8773 * coding.c (coding_alloc_by_realloc):
8774 * doprnt.c (doprnt):
8775 * editfns.c (Fformat):
8777 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8778 since they may not be the same number.
8779 * editfns.c (Finsert_char):
8780 * fileio.c (Finsert_file_contents):
8781 Likewise for BUF_BYTES_MAX.
8783 * image.c: Use ptrdiff_t, not int, for sizes.
8784 (slurp_file): Switch from int to ptrdiff_t.
8786 (slurp_file): Check that file size fits in both size_t (for
8787 malloc) and ptrdiff_t (for sanity and safety).
8789 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8790 if b->modtime has its maximal value.
8792 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8794 Don't assume time_t can fit into int.
8795 * buffer.h (struct buffer.modtime): Now time_t, not int.
8796 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8797 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8799 Minor fixes for signed vs unsigned integers.
8800 * character.h (MAYBE_UNIFY_CHAR):
8801 * charset.c (maybe_unify_char):
8802 * keyboard.c (read_char, reorder_modifiers):
8803 XINT -> XFASTINT, since the integer must be nonnegative.
8804 * ftfont.c (ftfont_spec_pattern):
8805 * keymap.c (access_keymap, silly_event_symbol_error):
8806 XUINT -> XFASTINT, since the integer must be nonnegative.
8807 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8808 since it makes no difference and we prefer signed.
8809 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8810 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8813 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8815 * window.h (Fwindow_frame): Declare.
8817 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8819 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8820 (SPARE_MEMORY): Always define.
8821 (LARGE_REQUEST): Remove.
8822 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8824 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8826 * lisp.h: Move EXFUNS for Fframe_root_window,
8827 Fframe_first_window and Fset_frame_selected_window to window.h.
8829 * window.h: Move EXFUNS for Fframe_root_window,
8830 Fframe_first_window and Fset_frame_selected_window here from
8833 * frame.c (Fwindow_frame, Fframe_first_window)
8834 (Fframe_root_window, Fframe_selected_window)
8835 (Fset_frame_selected_window): Move to window.c.
8836 (Factive_minibuffer_window): Move to minibuf.c.
8837 (Fother_visible_frames_p): New function.
8839 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8841 * window.c (decode_window, decode_any_window): Move up in code.
8842 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8843 (inhibit_frame_unsplittable): Remove unused variable.
8844 (Fwindow_buffer): Move up and rewrite doc-string.
8845 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8846 (Fwindow_prev): New functions.
8847 (Fwindow_frame): Move here from frame.c. Accept any window as
8849 (Fframe_root_window, Fframe_first_window)
8850 (Fframe_selected_window): Move here from frame.c. Accept frame
8851 or arbitrary window as argument. Update doc-strings.
8852 (Fminibuffer_window): Move up in code.
8853 (Fwindow_minibuffer_p): Move up in code and simplify.
8854 (Fset_frame_selected_window): Move here from frame.c.
8856 (Fselected_window, select_window, Fselect_window): Move up in
8857 code. Minor doc-string fixes.
8859 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8861 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8862 Do not assume that spare memory exists; that assumption is valid
8863 only if SYSTEM_MALLOC.
8864 (LARGE_REQUEST): New macro, so that the issue of large requests
8865 is separated from the issue of spare memory.
8867 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8869 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8872 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8874 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8877 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8879 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8881 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8883 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8884 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8886 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8888 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8890 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8892 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8893 (x_clipboard_manager_save): Add return value.
8894 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8896 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8897 Obey Vx_select_enable_clipboard_manager. Catch errors in
8898 x_clipboard_manager_save (Bug#8779).
8899 (Vx_select_enable_clipboard_manager): New variable.
8900 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8902 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8904 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8906 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8908 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8909 in the current matrix if keep_current_p is non-zero.
8911 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8913 * bidi.c (bidi_level_of_next_char): Fix last change.
8915 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8917 Support bidi reordering of text covered by display properties.
8919 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8920 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8921 (bidi_cache_search, bidi_cache_iterator_state)
8922 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8923 (bidi_level_of_next_char, bidi_move_to_visually_next):
8924 Support character positions inside a run of characters covered by a
8926 (bidi_paragraph_init, bidi_resolve_explicit_1)
8927 (bidi_level_of_next_char): Call bidi_fetch_char and
8928 bidi_fetch_char_advance instead of FETCH_CHAR and
8930 (bidi_init_it): Initialize new members.
8931 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8933 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8934 instead of using explicit *_CHAR codes.
8935 (bidi_resolve_explicit, bidi_resolve_weak):
8936 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8937 bidirectional text is supported only in multibyte buffers.
8938 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8939 it to initialize the frame_window_p member of struct bidi_it.
8940 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8941 (bidi_resolve_explicit, bidi_resolve_weak)
8942 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8943 bidi_it->nchars is non-positive.
8944 (bidi_level_of_next_char): Don't try to lookup the cache for the
8945 next/previous character if nothing is cached there yet, or if we
8946 were just reseat()'ed to a new position.
8948 * xdisp.c (set_cursor_from_row): Set start and stop points
8949 according to the row's direction when priming the loop that looks
8950 for the glyph on which to display cursor.
8951 (single_display_spec_intangible_p): Function deleted.
8952 (display_prop_intangible_p): Reimplement to call
8953 handle_display_spec instead of single_display_spec_intangible_p.
8954 Accept 3 additional arguments needed by handle_display_spec.
8955 This fixes incorrect cursor motion across display property with complex
8956 values: lists, `(when COND...)' forms, etc.
8957 (single_display_spec_string_p): Support property values that are
8958 lists with the argument STRING its top-level element.
8959 (display_prop_string_p): Fix the condition for processing a
8960 property that is a list to be consistent with handle_display_spec.
8961 (handle_display_spec): New function, refactored from the
8962 last portion of handle_display_prop.
8963 (compute_display_string_pos): Accept additional argument
8964 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8965 value of a `display' property is a "replacing spec".
8966 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8967 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8968 the display property, but just return a value indicating whether
8969 the display property will replace the characters it covers.
8970 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8971 frame_window_p members of struct bidi_it.
8972 (compute_display_string_pos, compute_display_string_end):
8974 (push_it): Accept second argument POSITION, where pop_it should
8975 jump to continue iteration.
8976 (reseat_1): Initialize bidi_it.disp_pos.
8978 * keyboard.c (adjust_point_for_property): Adjust the call to
8979 display_prop_intangible_p to its new signature.
8981 * dispextern.h (struct bidi_it): New member frame_window_p.
8982 (bidi_init_it): Update prototypes.
8983 (display_prop_intangible_p): Update prototype.
8984 (compute_display_string_pos, compute_display_string_end):
8986 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8989 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8991 Malloc failure behavior now depends on size of allocation.
8992 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8993 * lisp.h: Change signatures accordingly.
8994 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8995 All callers changed. (Bug#8762)
8997 * gnutls.c: Use Emacs's memory allocators.
8998 Without this change, the gnutls library would invoke malloc etc.
8999 directly, which causes problems on non-SYNC_INPUT hosts, and which
9000 runs afoul of improving memory_full behavior. (Bug#8761)
9001 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9002 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9003 xfree instead of the default malloc, realloc, free.
9004 (Fgnutls_boot): No need to check for memory allocation failure,
9005 since xmalloc does that for us.
9007 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9008 * category.c (hash_get_category_set):
9009 * ccl.c (ccl_driver):
9010 * charset.c (Fdefine_charset_internal):
9011 * charset.h (struct charset.hash_index):
9012 * composite.c (get_composition_id, gstring_lookup_cache)
9013 (composition_gstring_put_cache):
9014 * composite.h (struct composition.hash_index):
9015 * dispextern.h (struct image.hash):
9016 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9017 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9018 (hashfn_equal, hashfn_user_defined, make_hash_table)
9019 (maybe_resize_hash_table, hash_lookup, hash_put)
9020 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9021 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9022 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9023 * image.c (make_image, search_image_cache, lookup_image)
9024 (xpm_put_color_table_h):
9025 * lisp.h (struct Lisp_Hash_Table):
9026 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9027 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9028 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9029 * alloc.c (allocate_vectorlike):
9030 Check for overflow in vector size calculations.
9031 * ccl.c (ccl_driver):
9032 Check for overflow when converting EMACS_INT to int.
9033 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9034 need to be updated by these changes.
9035 * fns.c (make_hash_table, maybe_resize_hash_table):
9036 Check for integer overflow with large hash tables.
9037 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9038 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9039 (SXHASH_REDUCE): New macro.
9040 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9041 Use it instead of discarding useful hash info with large hash values.
9042 (sxhash_float): New function.
9043 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9044 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9045 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9046 Rewrite to use FIXNUM_BITS, as this simplifies things.
9047 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9048 Adjust signatures to match updated version of code.
9049 (consing_since_gc): Now EMACS_INT, since a single hash table can
9050 use more than INT_MAX bytes.
9052 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9054 Make it possible to build with GCC-4.6+ -O2 -flto.
9056 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9058 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9060 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9061 Call minibuffer-inactive-mode.
9063 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9065 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9066 Update dependencies.
9068 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9070 * data.c (init_data): Remove code for UTS, this system is not
9073 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9075 Don't force ./temacs to start in terminal mode.
9077 * frame.c (make_initial_frame): Initialize faces in all cases, not
9078 only when CANNOT_DUMP is defined.
9079 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9081 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9083 * dispnew.c (add_window_display_history): Use const for the string
9084 pointer. Remove declaration, not needed.
9086 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9088 Use 'inline', not 'INLINE'.
9089 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9090 * alloc.c, fontset.c (INLINE): Remove.
9091 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9092 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9093 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9094 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9095 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9097 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9099 Make it possible to run ./temacs.
9101 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9102 syms_of_callproc does the same thing. Remove test for
9103 "initialized", do it in the caller.
9104 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9106 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9108 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9109 (read_minibuf): Use get_minibuffer.
9110 (syms_of_minibuf): Use DEFSYM.
9111 (Qmetadata): New var.
9112 * data.c (Qbuffer): Don't make it static.
9113 (syms_of_data): Use DEFSYM.
9115 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9117 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9118 (CCL_CODE_MIN): New macro.
9120 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9122 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9124 * eval.c (Qdebug): Now static.
9125 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9126 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9127 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9129 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9131 * image.c: Various fixes to ImageMagick code comments.
9132 (Fimagemagick_types): Doc fix.
9134 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9136 Minor fixes prompted by GCC 4.6.0 warnings.
9138 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9140 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9141 (x_clipboard_manager_save_all): Move extern decl to ...
9142 * xterm.h: ... here, so that it can be checked for consistency.
9144 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9146 * xselect.c (x_clipboard_manager_save_frame)
9147 (x_clipboard_manager_save_all): New functions.
9148 (Fx_clipboard_manager_save): Lisp function deleted.
9150 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9151 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9153 * xterm.h: Update prototype.
9155 2011-05-28 William Xu <william.xwl@gmail.com>
9157 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9160 2011-05-28 Jim Meyering <meyering@redhat.com>
9162 Avoid a sign-extension bug in crypto_hash_function.
9163 * fns.c (to_uchar): Define.
9164 (crypto_hash_function): Use it to convert some newly-signed
9165 variables to unsigned, to avoid sign-extension bugs. For example,
9166 without this change, (md5 "truc") would evaluate to
9167 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9168 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9169 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9171 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9173 Integer overflow fixes.
9175 * dbusbind.c: Serial number integer overflow fixes.
9176 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9177 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9178 to hold a serial number that is too large for a fixnum.
9179 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9180 Check for serial numbers out of range. Decode any serial number
9181 that was so large that it became a float. (Bug#8722)
9183 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9184 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9185 Use XFASTINT rather than XUINT when numbers are nonnegative.
9186 (xd_append_arg, Fdbus_method_return_internal):
9187 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9188 arguments, check that Lisp number is nonnegative, rather than
9189 silently wrapping negative numbers around. (Bug#8722)
9190 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9193 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9195 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9197 ccl: Add integer overflow checks.
9198 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9199 (IN_INT_RANGE): New macros.
9200 (ccl_driver): Use them to check for integer overflow when
9201 decoding a CCL program. Many of the new checks are whether XINT (x)
9202 fits in int; it doesn't always, on 64-bit hosts. The new version
9203 doesn't catch all possible integer overflows, but it's an
9204 improvement. (Bug#8719)
9206 * alloc.c (make_event_array): Use XINT, not XUINT.
9207 There's no need for unsigned here.
9209 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9210 This follows up to the 2011-05-06 change that substituted uintptr_t
9211 for EMACS_INT. This case wasn't caught back then.
9213 Rework Fformat to avoid integer overflow issues.
9214 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9215 now (part of C89). Include <verify.h>.
9216 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9217 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9218 (Fformat): Avoid the prepass trying to compute sizes; it was only
9219 approximate and thus did not catch overflow reliably. Instead, walk
9220 through the format just once, formatting and computing sizes as we go,
9221 checking for integer overflow at every step, and allocating a larger
9222 buffer as needed. Keep track separately whether the format is
9223 multibyte. Keep only the most-recently calculated precision, rather
9224 than them all. Record whether each argument has been converted to
9225 string. Use EMACS_INT, not int, for byte and char and arg counts.
9226 Support field widths and precisions larger than INT_MAX. Avoid
9227 sprintf's undefined behavior with conversion specifications such as %#d
9228 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9229 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9230 formatting out-of-range floating point numbers with int
9233 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9235 * data.c: Avoid integer truncation in expressions involving floats.
9236 * data.c: Include <intprops.h>.
9237 (arith_driver): When there's an integer overflow in an expression
9238 involving floating point, convert the integers to floating point
9239 so that the resulting value does not suffer from catastrophic
9240 integer truncation. For example, on a 64-bit host (* 4
9241 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9242 Do not rely on undefined behavior after integer overflow.
9244 merge count_size_as_multibyte, parse_str_to_multibyte
9245 * character.c, character.h (count_size_as_multibyte):
9246 Rename from parse_str_to_multibyte; all uses changed.
9247 Check for integer overflow.
9248 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9249 since it's now a duplicate of the other. This is more of
9250 a character than a buffer op, so better that it's in character.c.
9251 * fns.c, print.c: Adjust to above changes.
9253 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9255 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9257 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9259 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9260 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9261 (x_clipboard_manager_save): Now static.
9262 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9264 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9265 (crypto_hash_function): Now static.
9266 Fix pointer signedness problems. Avoid unnecessary initializations.
9268 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9270 * termhooks.h (Vselection_alist): Make it terminal-local.
9272 * terminal.c (create_terminal): Initialize it.
9274 * xselect.c: Support for clipboard managers.
9275 (Vselection_alist): Move to termhooks.h as terminal-local var.
9276 (LOCAL_SELECTION): New macro.
9277 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9278 (symbol_to_x_atom): Remove gratuitous arg.
9279 (x_handle_selection_request, lisp_data_to_selection_data)
9280 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9281 (x_own_selection, x_get_local_selection, x_convert_selection):
9282 New arg, specifying work frame. Use terminal-local Vselection_alist.
9283 (some_frame_on_display): Delete unused function.
9284 (Fx_own_selection_internal, Fx_get_selection_internal)
9285 (Fx_disown_selection_internal, Fx_selection_owner_p)
9286 (Fx_selection_exists_p): New optional frame arg.
9287 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9288 (x_handle_selection_clear): Don't treat other terminals with the
9289 same keyboard specially. Use the terminal-local Vselection_alist.
9290 (x_clear_frame_selections): Use Frun_hook_with_args.
9292 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9294 * xterm.h: Add support for those atoms.
9296 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9298 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9299 (converted_selections, conversion_fail_tag): New global variables.
9300 (x_selection_request_lisp_error): Free the above.
9301 (x_get_local_selection): Remove unnecessary code.
9302 (x_reply_selection_request): Args changed; handle arbitrary array
9303 of converted selections stored in converted_selections.
9304 Separate the XChangeProperty and SelectionNotify steps.
9305 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9306 (x_convert_selection): New function.
9307 (x_handle_selection_event): Simplify.
9308 (x_get_foreign_selection): Don't ignore incoming requests while
9309 waiting for an answer; this will fail when we implement
9310 SAVE_TARGETS, and seems unnecessary anyway.
9311 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9312 (Vx_sent_selection_functions): Doc fix.
9314 2011-05-26 Leo Liu <sdl.web@gmail.com>
9316 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9318 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9320 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9322 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9323 for fringe update if it has periodic bitmap.
9324 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9325 and fringe_bitmap_periodic_p.
9327 * fringe.c (get_fringe_bitmap_data): New function.
9328 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9329 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9330 row. Mark glyph row for fringe update if periodicity changed.
9332 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9333 for fringe update unless it has periodic bitmap.
9335 2011-05-25 Kenichi Handa <handa@m17n.org>
9337 * xdisp.c (get_next_display_element): Set correct it->face_id for
9338 a static composition.
9340 2011-05-24 Leo Liu <sdl.web@gmail.com>
9343 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9345 * fns.c (crypto_hash_function, Fsha1): New function.
9346 (Fmd5): Use crypto_hash_function.
9347 (syms_of_fns): Add Ssha1.
9349 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9351 * gnutls.c: Remove unused macros.
9352 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9353 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9354 Remove macros that are defined and never used.
9355 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9357 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9359 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9360 (Fx_get_selection_internal): Minor cleanup.
9361 (Fx_own_selection_internal): Rename arguments for consistency with
9364 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9366 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9368 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9370 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9372 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9374 * dispnew.c (scrolling_window): Don't exclude the case that the
9375 last enabled row in the desired matrix touches the bottom boundary.
9377 2011-05-21 Glenn Morris <rgm@gnu.org>
9379 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9380 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9381 and add some more files.
9383 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9385 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9386 report_file_error introduced by the change from 2011-05-07.
9388 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9390 * systime.h (Time): Define only if emacs is defined.
9391 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9392 where the include path doesn't have X11/X.h by default. See
9393 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9395 2011-05-20 Kenichi Handa <handa@m17n.org>
9397 * composite.c (find_automatic_composition): Fix previous change.
9399 2011-05-20 Glenn Morris <rgm@gnu.org>
9401 * lisp.mk: New file, split from Makefile.in.
9402 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9403 (shortlisp): Remove.
9404 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9406 2011-05-19 Glenn Morris <rgm@gnu.org>
9408 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9409 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9410 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9411 (lisp): Set the order to that of loadup.el.
9412 (shortlisp): Make it a copy of $lisp.
9413 (SOME_MACHINE_LISP): Remove.
9414 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9415 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9417 2011-05-18 Kenichi Handa <handa@m17n.org>
9419 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9420 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9421 (find_automatic_composition): Mostly rewrite for efficiency.
9423 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9425 * makefile.w32-in: Update dependencies.
9427 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9429 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9430 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9432 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9434 Fix some integer overflow issues, such as string length overflow.
9436 * insdel.c (count_size_as_multibyte): Check for string overflow.
9438 * character.c (lisp_string_width): Check for string overflow.
9439 Use EMACS_INT, not int, for string indexes and lengths; in
9440 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9441 the resulting string length overflows an EMACS_INT; instead,
9442 report a string overflow if no precision given. When checking for
9443 precision exhaustion, use a check that cannot possibly have
9444 integer overflow. (Bug#8675)
9445 * character.h (lisp_string_width): Adjust to new signature.
9447 * alloc.c (string_overflow): New function.
9448 (Fmake_string): Use it. This doesn't change behavior, but saves
9449 a few bytes and will simplify future changes.
9450 * character.c (string_escape_byte8): Likewise.
9451 * lisp.h (string_overflow): New decl.
9453 Fixups, following up to the user-interface timestamp change.
9454 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9455 for UI timestamps, instead of unsigned long.
9456 * msdos.c (mouse_get_pos): Likewise.
9457 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9458 * w32gui.h (Time): Define by including "systime.h" rather than by
9459 declaring it ourselves. (Bug#8664)
9461 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9462 * image.c (clear_image_cache): Likewise.
9464 * term.c (term_mouse_position): Don't assume time_t wraparound.
9466 Be more systematic about user-interface timestamps.
9467 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9468 and sometimes 'EMACS_UINT', to represent these timestamps.
9469 This change causes it to use 'Time' uniformly, as that's what X uses.
9470 This makes the code easier to follow, and makes it easier to catch
9471 integer overflow bugs such as Bug#8664.
9472 * frame.c (Fmouse_position, Fmouse_pixel_position):
9473 Use Time, not unsigned long, for user-interface timestamps.
9474 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9475 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9476 * keyboard.h (last_event_timestamp): Likewise.
9477 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9478 * menu.h (xmenu_show): Likewise.
9479 * term.c (term_mouse_position): Likewise.
9480 * termhooks.h (struct input_event.timestamp): Likewise.
9481 (struct terminal.mouse_position_hook): Likewise.
9482 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9483 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9484 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9485 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9487 * menu.h, termhooks.h: Include "systime.h", for Time.
9489 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9490 Don't assume that the difference between two unsigned long values
9491 can fit into an integer. At this point, we know button_down_time
9492 <= event->timestamp, so the difference must be nonnegative, so
9493 there's no need to cast the result if double-click-time is
9494 nonnegative, as it should be; check that it's nonnegative, just in
9495 case. This bug is triggered when events are more than 2**31 ms
9496 apart (about 25 days). (Bug#8664)
9498 * xselect.c (last_event_timestamp): Remove duplicate decl.
9499 (x_own_selection): Remove needless cast to unsigned long.
9501 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9502 that always fit in int. Use a sentinel instead of a counter, to
9503 avoid a temp and to allay GCC's concerns about possible int overflow.
9504 * frame.h (struct frame): Use int for menu_bar_items_used
9505 instead of EMACS_INT, since it always fits in int.
9507 * menu.c (grow_menu_items): Check for int overflow.
9509 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9511 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9512 Before, the code was not consistent. These values cannot exceed
9513 2**31 - 1 so there's no need to make them unsigned.
9514 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9515 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9516 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9518 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9520 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9521 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9522 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9523 presumably because the widths might not match.
9525 * window.c (size_window): Avoid needless test at loop start.
9527 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9529 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9531 2011-05-12 Drew Adams <drew.adams@oracle.com>
9533 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9535 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9537 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9538 `width' to `bar_area_x' and `bar_area_width', respectively.
9539 (x_scroll_run): Take account of fringe background extension.
9541 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9542 Rename local vars `left' and `width' to `bar_area_x' and
9543 `bar_area_width', respectively.
9544 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9545 background extension.
9547 2011-05-10 Jim Meyering <meyering@redhat.com>
9549 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9551 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9553 * image.c (Finit_image_library): Return t for built-in image types,
9554 like pbm and xbm. (Bug#8640)
9556 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9558 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9560 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9562 * w32console.c (Fset_screen_color): Doc fix.
9563 (Fget_screen_color): New function.
9564 (syms_of_ntterm): Defsubr it.
9566 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9567 unlink the temporary file if Fcall_process didn't create it in the
9569 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9570 child process will be redirected to a file specified with `:file'.
9571 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9572 cue to call_process_cleanup not to close that handle.
9574 2011-05-07 Ben Key <bkey76@gmail.com>
9576 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9577 one of two shell specific rules, either bootstrap-temacs-CMD or
9578 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9579 to the previous implementation of the bootstrap-temacs rule.
9580 The bootstrap-temacs-CMD rule is similar to the previous
9581 implementation of the bootstrap-temacs rule except that it
9582 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9585 These changes, along with some changes to nt/configure.bat,
9586 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9587 earlier fix to add support for --cflags and --ldflags options
9588 that include quotes so that it works whether make uses cmd or
9591 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9593 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9594 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9596 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9597 a string. Handle both cases.
9598 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9599 (Fdbus_register_method): Use Qinvalid_function.
9601 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9603 * makefile.w32-in: Update dependencies.
9604 (LISP_H): Add inttypes.h and stdin.h.
9605 (PROCESS_H): Add unistd.h.
9607 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9609 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9610 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9612 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9614 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9616 * term.c (vfatal): Remove stray call to va_end.
9617 It's not needed and the C Standard doesn't allow it here anyway.
9619 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9620 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9622 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9625 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9627 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9629 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9631 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9633 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9635 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9636 * charset.c (Fdefine_charset_internal): Don't initialize
9637 charset.code_space[15]. The value was garbage, on hosts with
9638 32-bit int (Bug#8600).
9640 * lread.c (read_integer): Be more consistent with string-to-number.
9641 Use string_to_number to do the actual conversion; this avoids
9642 rounding errors and fixes some other screwups. Without this fix,
9643 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9644 (digit_to_number): Move earlier, for benefit of read_integer.
9645 Return -1 if the digit is out of range for the base, -2 if it is
9646 not a digit in any supported base. (Bug#8602)
9648 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9650 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9651 to match comment at start of function. This also removes a
9652 GCC warning about overflow in a 32+64-bit port.
9654 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9656 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9657 Reported by Stefan Monnier in
9658 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9659 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9660 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9662 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9663 (EMACS_UINTPTR): Likewise, with uintptr_t.
9665 * lisp.h: Prefer 64-bit EMACS_INT if available.
9666 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9667 on 32-bit hosts that have 64-bit int, so that they can access
9669 However, temporarily disable this change unless the temporary
9670 symbol WIDE_EMACS_INT is defined.
9672 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9674 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9675 This removes an assumption that EMACS_INT and long are the same
9676 width as pointers. The assumption is true for Emacs porting targets
9677 now, but we want to make other targets possible.
9678 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9679 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9680 In the rest of the code, change types of integers that hold casted
9681 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9682 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9683 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9684 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9685 No need to cast type when ORing.
9686 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9687 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9688 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9689 assume EMACS_INT is the same width as char *.
9690 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9691 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9692 Remove no-longer-needed casts.
9693 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9694 (xg_tool_bar_help_callback, xg_make_tool_item):
9695 Use EMACS_INTPTR to hold an integer
9696 that will be cast to void *; this can avoid a GCC warning
9697 if EMACS_INT is not the same width as void *.
9698 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9699 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9700 (current_message_1, set_message_1):
9701 Use a local to convert to proper width without a cast.
9702 * xmenu.c (dialog_selection_callback): Likewise.
9704 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9705 Also, don't assume VALBITS / RAND_BITS is less than 5,
9706 and don't rely on undefined behavior when shifting a 1 left into
9708 * lisp.h (get_random): Change signature to match.
9710 * lread.c (hash_string): Use size_t, not int, for hash computation.
9711 Normally we prefer signed values; but hashing is special, because
9712 it's better to use unsigned division on hash table sizes so that
9713 the remainder is nonnegative. Also, size_t is the natural width
9714 for hashing into memory. The previous code used 'int', which doesn't
9715 retain enough info to hash well into very large tables.
9716 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9718 * dbusbind.c: Don't possibly lose pointer info when converting.
9719 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9720 Use XPNTR rather than XHASH, so that the high-order bits of
9721 the pointer aren't lost when converting through void *.
9723 * eval.c (Fautoload): Don't double-shift a pointer.
9725 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9727 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9729 * gnutls.c (DEF_GNUTLS_FN):
9730 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9732 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9734 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9737 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9739 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9740 New version that can reserve upto 2GB of heap space.
9742 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9744 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9746 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9748 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9749 `gnutls_certificate_set_x509_key_file'.
9751 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9753 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9754 Update dependencies.
9756 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9758 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9759 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9760 Remove unused parameter `fildes'.
9761 * process.c (read_process_output, send_process): Don't pass it.
9763 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9765 Fix previous change: the library cache is defined in w32.c.
9766 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9767 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9769 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9771 Implement dynamic loading of GnuTLS on Windows.
9773 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9774 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9775 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9778 * gnutls.c (Qgnutls_dll): Define.
9779 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9780 (gnutls_*): Declare function pointers.
9781 (init_gnutls_functions): New function to initialize function pointers.
9782 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9783 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9784 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9785 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9786 (emacs_gnutls_write, emacs_gnutls_read)
9787 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9788 (Fgnutls_available_p): New function.
9789 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9790 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9791 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9793 * image.c: Include w32.h.
9794 (Vimage_type_cache): Delete.
9795 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9796 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9797 (w32_delayed_load): Move to w32.c.
9799 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9801 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9802 (w32_delayed_load): Move from image.c. When loading a library, record
9803 its filename in the :loaded-from property of the library id.
9804 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9805 Initialize and staticpro them.
9806 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9808 * process.c: Include lisp.h before w32.h, not after.
9809 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9810 instead of gnutls_record_check_pending.
9812 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9814 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9816 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9817 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9820 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9822 * xterm.c (x_set_frame_alpha): Do not set property on anything
9823 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9825 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9827 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9829 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9831 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9832 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9833 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9834 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9835 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9836 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9837 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9838 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9839 (Qgnutls_bootprop_callbacks_verify): Make static.
9841 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9843 * callproc.c: Indentation fixup.
9845 * sysdep.c (wait_for_termination_1): Make static.
9846 (wait_for_termination, interruptible_wait_for_termination):
9847 Move after wait_for_termination_1.
9849 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9851 * sysdep.c (interruptible_wait_for_termination): New function
9852 which is like wait_for_termination, but allows keyboard
9855 * callproc.c (Fcall_process): Add (:file "file") as an option for
9857 (Fcall_process_region): Ditto.
9859 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9861 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9862 rather than `XVECTOR (FOO)->size'.
9864 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9865 inttypes.h, as a gnulib replacement is used if it not available in
9868 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9870 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9871 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9872 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9874 * coding.c (coding_alloc_by_realloc): Error out if destination
9875 will grow beyond MOST_POSITIVE_FIXNUM.
9876 (decode_coding_emacs_mule): Abort if there isn't enough place in
9877 charbuf for the composition carryover bytes. Reserve an extra
9878 space for up to 2 characters produced in a loop.
9879 (decode_coding_iso_2022): Abort if there isn't enough place in
9880 charbuf for the composition carryover bytes.
9882 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9884 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9885 aborting when %lld or %lll format is passed.
9886 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9887 %llo or %llx format is passed. (Bug#8545)
9889 * window.c (window_scroll_line_based): Use a marker instead of
9890 simple variables to record original value of point. (Bug#7952)
9892 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9893 produced by %s or %c overflows available buffer space. (Bug#8545)
9895 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9897 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9898 (SIZE_MAX): Move defn after all includes, as they might #define it.
9900 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9902 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9904 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9906 * keyboard.c (Qdelayed_warnings_hook): Define.
9907 (command_loop_1): Run `delayed-warnings-hook'
9908 if Vdelayed_warnings_list is non-nil.
9909 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9910 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9912 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9914 * doprnt.c (doprnt): Don't return value smaller than the buffer
9915 size if the message was truncated. (Bug#8545).
9917 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9919 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9920 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9922 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9924 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9926 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9928 * makefile.w32-in: Update dependencies.
9930 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9932 Improve `doprnt' and its usage. (Bug#8545)
9933 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9934 `format_end'. Remove support for %l as a conversion specifier.
9935 Don't use xrealloc. Improve diagnostics when the %l size modifier
9936 is used. Update the commentary.
9938 * eval.c (verror): Simplify calculation of size_t.
9940 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9943 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9945 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9948 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9950 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9951 This makes this file independent of the recent pseudovector change.
9953 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9955 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9957 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9958 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9959 Remove unused local.
9960 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9962 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9963 GCC 4.6.0 optimizes based on type-based alias analysis.
9964 For example, if b is of type struct buffer * and v of type struct
9965 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9966 != &v->size, and therefore "v->size = 1; b->size = 2; return
9967 v->size;" must therefore return 1. This assumption is incorrect
9968 for Emacs, since it type-puns struct Lisp_Vector * with many other
9969 types. To fix this problem, this patch adds a new type struct
9970 vectorlike_header that documents the constraints on layout of vectors
9971 and pseudovectors, and helps optimizing compilers not get fooled
9972 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9973 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9974 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9976 (XSETPVECTYPE): Rewrite in terms of new macro.
9977 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9978 This is a bit clearer, and further avoids the possibility of
9979 undesirable aliasing.
9980 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9981 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9982 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9983 since Lisp_Subr is a special case (no "next" field).
9984 (ASIZE): Now uses header.size rather than size.
9985 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9986 to avoid the hassle of writing XVECTOR (foo)->header.size.
9987 (struct vectorlike_header): New type.
9988 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9989 object, to help avoid aliasing.
9990 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9991 (SUBRP): Likewise, since Lisp_Subr is a special case.
9992 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9993 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9994 (struct Lisp_Hash_Table): Combine first two members into a single
9995 struct vectorlike_header member. All uses of "size" and "next" members
9996 changed to be "header.size" and "header.next".
9997 * buffer.h (struct buffer): Likewise.
9998 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9999 * frame.h (struct frame): Likewise.
10000 * process.h (struct Lisp_Process): Likewise.
10001 * termhooks.h (struct terminal): Likewise.
10002 * window.c (struct save_window_data, struct saved_window): Likewise.
10003 * window.h (struct window): Likewise.
10004 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10005 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10006 * buffer.c (init_buffer_once): Likewise.
10007 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10009 * process.c (Fformat_network_address): Use local var for size,
10012 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10014 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10015 * data.c (atof): Remove decl; no longer used or needed.
10016 (digit_to_number): Move to lread.c.
10017 (Fstring_to_number): Use new string_to_number function, to be
10018 consistent with how the Lisp reader treats infinities and NaNs.
10019 Do not assume that floating-point numbers represent EMACS_INT
10020 without losing information; this is not true on most 64-bit hosts.
10021 Avoid double-rounding errors, by insisting on integers when
10022 parsing non-base-10 numbers, as the documentation specifies.
10023 * lisp.h (string_to_number): New decl, replacing ...
10024 (isfloat_string): Remove.
10025 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10026 (read1): Do not accept +. and -. as integers; this
10027 appears to have been a coding error. Similarly, do not accept
10028 strings like +-1e0 as floating point numbers. Do not report
10029 overflow for integer overflows unless the base is not 10 which
10030 means we have no simple and reliable way to continue.
10031 Break out the floating-point parsing into a new
10032 function string_to_number, so that Fstring_to_number parses
10033 floating point numbers consistently with the Lisp reader.
10034 (digit_to_number): Move here from data.c. Make it static inline.
10035 (E_CHAR, EXP_INT): Remove, replacing with ...
10036 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10037 (string_to_number): New function, replacing isfloat_string.
10038 This function checks for valid syntax and produces the resulting
10039 Lisp float number too. Rework it so that string-to-number
10040 no longer mishandles examples like "1.0e+". Use strtoumax,
10041 so that overflow for non-base-10 numbers is reported only when
10042 there's no portable and simple way to convert to floating point.
10044 * textprop.c (set_text_properties_1): Rewrite for clarity,
10045 and to avoid GCC warning about integer overflow.
10047 * intervals.h (struct interval): Use EMACS_INT for members
10048 where EMACS_UINT might cause problems. See
10049 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10050 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10051 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10053 (offset_intervals): Tell GCC not to worry about length overflow
10054 when negating a negative length.
10056 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10057 (overrun_check_free): Likewise.
10059 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10060 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10063 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10064 (gnutls_make_error): Rename local to avoid shadowing.
10065 (gnutls_emacs_global_deinit): ifdef out; not used.
10066 (Fgnutls_boot): Use const for pointer to readonly storage.
10067 Comment out unused local. Fix pointer signedness problems.
10069 * lread.c (openp): Don't stuff size_t into an 'int'.
10070 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10071 about possible signed overflow.
10073 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10074 (GDK_KEY_g): Don't define if already defined.
10075 (xg_prepare_tooltip): Avoid pointer signedness problem.
10076 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10078 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10079 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10081 * xfns.c (Fx_window_property): Simplify a bit,
10082 to make a bit faster and to avoid GCC 4.6.0 warning.
10083 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10085 * fns.c (internal_equal): Don't assume size_t fits in int.
10087 * alloc.c (compact_small_strings): Tighten assertion a little.
10089 Replace pEd with more-general pI, and fix some printf arg casts.
10090 * lisp.h (pI): New macro, generalizing old pEd macro to other
10091 conversion specifiers. For example, use "...%"pI"d..." rather
10092 than "...%"pEd"...".
10093 (pEd): Remove. All uses replaced with similar uses of pI.
10094 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10095 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10096 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10097 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10098 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10099 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10100 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10102 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10103 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10104 * print.c (safe_debug_print, print_object): Likewise.
10105 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10107 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10108 avoiding the 0 flag, which is not portable.
10109 * process.c (Fmake_network_process): Use pI to avoid cast.
10110 * region-cache.c (pp_cache): Likewise.
10111 * xdisp.c (decode_mode_spec): Likewise.
10112 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10113 behavior on 64-bit hosts with printf arg.
10114 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10115 (x_stop_queuing_selection_requests): Likewise.
10116 (x_get_window_property): Don't truncate byte count to an 'int'
10119 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10120 here, since it parses constructs like leading '-' and spaces,
10121 which are not wanted; and it overflows with large numbers.
10122 Instead, simply match F[0-9]+, which is what is wanted anyway.
10124 * alloc.c: Remove unportable assumptions about struct layout.
10125 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10126 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10127 (allocate_vectorlike, make_pure_vector): Use the new macros,
10128 plus offsetof, to remove unportable assumptions about struct layout.
10129 These assumptions hold on all porting targets that I know of, but
10130 they are not guaranteed, they're easy to remove, and removing them
10131 makes further changes easier.
10133 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10134 This doesn't fix a bug but makes the code clearer.
10135 (string_overrun_cookie): Now const. Use initializers that
10136 don't formally overflow signed char, to avoid warnings.
10137 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10138 can cause Emacs to crash when string overrun checking is enabled.
10139 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10140 multiple of sizeof (EMACS_INT); it need not be, if
10141 alignof(EMACS_INT) < sizeof (EMACS_INT).
10142 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10144 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10146 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10148 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10150 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10151 supposed to be handshaking. (Bug#8556)
10152 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10154 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10156 * lisp.h (Qdebug): List symbol.
10157 * eval.c (Qdebug): Restore global linkage.
10158 * keyboard.c (debug-on-event): New variable.
10159 (handle_user_signal): Break into debugger when debug-on-event
10160 matches the current signal symbol.
10162 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10164 * alloc.c (check_sblock, check_string_bytes)
10165 (check_string_free_list): Convert to standard C.
10167 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10169 * w32.c (emacs_gnutls_push): Fix typo.
10171 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10173 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10174 "cast to pointer from integer of different size".
10176 Improve doprnt and its use in verror. (Bug#8545)
10177 * doprnt.c (doprnt): Document the set of format control sequences
10178 supported by the function. Use SAFE_ALLOCA instead of always
10181 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10182 is one byte too soon. Don't use xrealloc; instead xfree and
10185 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10187 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10190 * gnutls.c: Renamed global_initialized to
10191 gnutls_global_initialized. Added internals for the
10192 :verify-hostname-error, :verify-error, and :verify-flags
10193 parameters of `gnutls-boot' and documented those parameters in the
10194 docstring. Start callback support.
10195 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10196 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10197 on error. Return error code.
10198 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10199 (emacs_gnutls_read): Likewise.
10200 (Fgnutls_boot): Return handshake error code.
10201 (emacs_gnutls_handle_error): New function.
10202 (wsaerror_to_errno): Likewise.
10204 * w32.h (emacs_gnutls_pull): Add prototype.
10205 (emacs_gnutls_push): Likewise.
10207 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10208 (emacs_gnutls_push): Likewise.
10210 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10212 * process.c (wait_reading_process_output): Check if GnuTLS
10213 buffered some data internally if no FDs are set for TLS
10216 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10217 (LIBS): Link to USER_LIBS.
10218 ($(BLD)/gnutls.$(0)): New target.
10220 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10222 * xdisp.c (handle_single_display_spec): Rename the
10223 display_replaced_before_p argument into display_replaced_p, to
10224 make it consistent with the commentary. Fix typos in the
10227 * textprop.c (syms_of_textprop): Remove dead code.
10228 (copy_text_properties): Delete obsolete commentary about an
10229 interface that was deleted long ago. Fix typos in the description
10232 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10233 to changes in oldXMenu/XMenu.h from 2011-04-16.
10234 <menu_help_message, prev_menu_help_message>: Constify.
10235 (IT_menu_make_room): menu->help_text is now `const char **';
10238 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10239 to changes in oldXMenu/XMenu.h from 2011-04-16.
10240 (struct XMenu): Declare `help_text' `const char **'.
10242 * xfaces.c <Qunspecified>: Make extern again.
10244 * syntax.c: Include sys/types.h before including regex.h, as
10247 * doc.c (get_doc_string): Improve the format passed to `error'.
10249 * doprnt.c (doprnt): Improve commentary.
10251 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10253 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10256 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10257 changes in globals.h immediately force recompilation.
10258 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10259 $(CURDIR)/s/ms-w32.h.
10260 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10262 * character.c (Fchar_direction): Function deleted.
10263 (syms_of_character): Don't defsubr it.
10264 <char-direction-table>: Deleted.
10266 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10268 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10269 * doprnt.c: Include limits.h.
10270 (SIZE_MAX): New macro.
10271 (doprnt): Return a size_t value. 2nd arg is now size_t.
10272 Many local variables are now size_t instead of int or unsigned.
10273 Improve overflow protection. Support `l' modifier for integer
10274 conversions. Support %l conversion. Don't assume an EMACS_INT
10275 argument for integer conversions and for %c.
10277 * lisp.h (doprnt): Restore prototype.
10279 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10280 $(SRC)/character.h.
10282 * Makefile.in (base_obj): Add back doprnt.o.
10284 * deps.mk (doprnt.o): Add back prerequisites.
10285 (callint.o): Depend on character.h.
10287 * eval.c (internal_lisp_condition_case): Include the handler
10288 representation in the error message.
10289 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10290 when breaking from the loop.
10292 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10294 * callint.c (Fcall_interactively): When displaying error message
10295 about invalid control letter, pass the character's codepoint, not
10296 a pointer to its multibyte form. Improve display of the character
10297 in octal and display also its hex code.
10299 * character.c (char_string): Use %x to display the (unsigned)
10300 codepoint of an invalid character, to avoid displaying a bogus
10303 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10304 `error', not SYMBOL_NAME itself.
10306 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10307 character arguments to `error'.
10309 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10310 to `error' in error message about FINAL_CHAR argument. Make sure
10311 FINAL_CHAR is a character, and use %c when it is passed as
10312 argument to `error'.
10314 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10316 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10318 * w32.c: Include <time.h>.
10319 (sys_localtime): New function.
10321 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10323 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10325 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10327 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10329 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10330 zombies (Bug#8467).
10332 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10334 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10335 gl_state.e_property when gl_state.object is Qt.
10337 * insdel.c (make_gap_larger): Remove limitation of buffer size
10340 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10342 * xdisp.c (lookup_glyphless_char_display)
10343 (produce_glyphless_glyph): Handle cons cell entry in
10344 glyphless-char-display.
10345 (Vglyphless_char_display): Document it.
10347 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10348 glyphless-char-display.
10350 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10352 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10354 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10356 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10357 definition for no-X builds.
10359 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10361 Static checks with GCC 4.6.0 and non-default toolkits.
10363 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10365 * process.c (keyboard_bit_set): Define only if SIGIO.
10366 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10367 (send_process): Repair possible setjmp clobbering.
10369 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10371 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10373 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10375 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10376 Define only if needed.
10378 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10379 by pacifying GCC about it. Maybe it's time to retire it?
10380 * xfaces.c (USG, __TIMEVAL__): Likewise.
10382 * dispextern.h (struct redisplay_interface): Rename param
10383 to avoid shadowing.
10384 * termhooks.h (struct terminal): Likewise.
10385 * xterm.c (xembed_send_message): Likewise.
10387 * insdel.c (make_gap_smaller): Define only if
10388 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10390 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10393 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10394 so that we aren't warned about unused symbols.
10396 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10398 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10400 * xfns.c (x_real_positions): Mark locals as initialized.
10402 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10404 * xterm.c: Fix problems found by static analysis with other toolkits.
10405 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10406 (x_dispatch_event): Declare static if USE_GTK, and
10407 define if USE_GTK || USE_X_TOOLKIT.
10408 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10409 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10410 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10411 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10413 * xmenu.c (menu_help_callback): Pointer type fixes.
10414 Use const pointers when pointing at readonly data. Avoid pointer
10415 signedness clashes.
10416 (FALSE): Remove unused macro.
10417 (update_frame_menubar): Remove unused decl.
10419 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10421 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10422 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10423 (single_menu_item): Rename local to avoid shadowing.
10425 * keyboard.c (make_lispy_event): Remove unused local var.
10427 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10428 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10430 * bitmaps: Change bitmaps from unsigned char back to the X11
10431 compatible char. Avoid the old compiler warnings about
10432 out-of-range initializers by using, for example, '\xab' rather
10435 * xgselect.c (xgselect_initialize): Check vs interface
10436 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10438 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10440 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10441 to read-only memory.
10443 * fns.c (vector): Remove; this old hack is no longer needed.
10445 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10447 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10449 * xrdb.c (x_load_resources): Omit unused local.
10451 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10452 (x_window): Rename locals to avoid shadowing.
10453 (USG): Use the kludged USG macro, to pacify gcc.
10455 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10456 (x_term_init): Remove local to avoid shadowing.
10458 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10460 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10461 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10463 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10465 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10467 Fix regex.c, syntax.c and friends for buffers > 2GB.
10468 * syntax.h (struct gl_state_s): Declare character position members
10471 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10473 * textprop.c (verify_interval_modification, interval_of):
10474 Declare arguments EMACS_INT.
10476 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10479 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10481 * indent.c (Fvertical_motion): Local variable it_start is now
10484 * regex.c (re_match, re_match_2, re_match_2_internal)
10485 (bcmp_translate, regcomp, regexec, print_double_string)
10486 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10487 (re_compile_pattern, re_exec): Declare arguments and local
10488 variables `size_t' and `ssize_t' and return values `regoff_t', as
10490 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10491 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10492 <compile_stack_type>: `size' and `avail' are now `size_t'.
10494 * regex.h <regoff_t>: Use ssize_t, not int.
10495 (re_search, re_search_2, re_match, re_match_2): Arguments that
10496 specify buffer/string position and length are now ssize_t and
10497 size_t. Return type is regoff_t.
10499 2011-04-16 Ben Key <bkey76@gmail.com>
10501 * nsfont.m: Fixed bugs in ns_get_family and
10502 ns_descriptor_to_entity that were caused by using free to
10503 deallocate memory blocks that were allocated by xmalloc (via
10504 xstrdup). This caused Emacs to crash when compiled with
10505 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10506 --enable-checking=xmallocoverrun). xfree is now used to
10507 deallocate these memory blocks.
10509 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10511 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10513 emacs_write: Accept and return EMACS_INT for sizes.
10514 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10516 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10517 Accept and return EMACS_INT.
10518 (emacs_gnutls_write): Return the number of bytes written on
10520 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10521 (emacs_read, emacs_write): Remove check for negative size, as the
10522 Emacs source code has been audited now.
10523 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10524 (emacs_read, emacs_write): Use it.
10525 * process.c (send_process): Adjust to the new signatures of
10526 emacs_write and emacs_gnutls_write. Do not attempt to store
10527 a byte offset into an 'int'; it might overflow.
10528 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10530 * sound.c: Don't assume sizes fit in 'int'.
10531 (struct sound_device.period_size, alsa_period_size):
10532 Return EMACS_INT, not int.
10533 (struct sound_device.write, vox_write, alsa_write):
10534 Accept EMACS_INT, not int.
10535 (wav_play, au_play): Use EMACS_INT to store sizes and to
10536 record read return values.
10538 2011-04-15 Ben Key <bkey76@gmail.com>
10540 * keyboard.c (Qundefined): Don't declare static since it is used
10542 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10543 static since they are used in nsfont.m.
10545 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10547 * process.c (Qprocessp): Don't declare static.
10548 * lisp.h (Qprocessp): Declare again.
10550 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10552 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10554 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10556 Improve C-level modularity by making more things 'static'.
10558 Don't publish debugger-only interfaces to other modules.
10559 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10560 (verify_bytepos, count_markers): Move decls to the only modules
10562 * region-cache.h (pp_cache): Likewise.
10563 * window.h (check_all_windows): Likewise.
10564 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10566 * sysdep.c (croak): Now static, if
10567 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10568 * syssignal.h (croak): Declare only if not static.
10570 * alloc.c (refill_memory_reserve): Now static if
10571 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10572 * lisp.h (refill_memory_reserve): Declare only if not static.
10574 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10575 Define only if USE_LUCID.
10577 * xrdb.c (x_customization_string, x_rm_string): Now static.
10579 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10580 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10582 * xdisp.c (draw_row_with_mouse_face): Now static.
10583 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10585 * window.h (check_all_windows): Mark externally visible.
10587 * window.c (window_deletion_count): Now static.
10589 * undo.c: Make symbols static if they're not exported.
10590 (last_undo_buffer, last_boundary_position, pending_boundary):
10593 * textprop.c (interval_insert_behind_hooks): Now static.
10594 (interval_insert_in_front_hooks): Likewise.
10596 * term.c: Make symbols static if they're not exported.
10597 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10598 (max_frame_lines, tty_set_terminal_modes):
10599 (tty_reset_terminal_modes, tty_turn_off_highlight):
10600 (get_tty_terminal): Now static.
10601 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10602 * termhooks.h (term_mouse_moveto): Do not declare if
10603 HAVE_WINDOW_SYSTEM.
10604 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10605 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10607 * sysdep.c: Make symbols static if they're not exported.
10608 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10610 (sigprocmask_set, full_mask): Remove; unused.
10611 (wait_debugging): Mark as visible.
10612 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10613 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10615 * syntax.c (syntax_temp): Define only if !__GNUC__.
10617 * sound.c (current_sound_device, current_sound): Now static.
10619 * search.c (searchbufs, searchbuf_head): Now static.
10621 * scroll.c (scroll_cost): Remove; unused.
10622 * dispextern.h (scroll_cost): Remove decl.
10624 * region-cache.h (pp_cache): Mark as externally visible.
10626 * process.c: Make symbols static if they're not exported.
10627 (process_tick, update_tick, create_process, chan_process):
10628 (Vprocess_alist, proc_buffered_char, datagram_access):
10629 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10630 (deactivate_process): Mark defn as static, as well as decl.
10631 * lisp.h (create_process): Remove decl.
10632 * process.h (chan_process, Vprocess_alist): Remove decls.
10634 * print.c: Make symbols static if they're not exported.
10635 (print_depth, new_backquote_output, being_printed, print_buffer):
10636 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10637 (print_interval, print_number_index, initial_stderr_stream):
10639 * lisp.h (Fprinc): Remove decl.
10640 (debug_output_compilation_hack): Mark as externally visible.
10642 * sysdep.c (croak): Move decl from here to syssignal.h.
10643 * syssignal.h (croak): Put it here, so the API can be checked when
10644 'croak' is called from dissociate_if_controlling_tty.
10646 * minibuf.c: Make symbols static if they're not exported.
10647 (minibuf_save_list, choose_minibuf_frame): Now static.
10648 * lisp.h (choose_minibuf_frame): Remove decl.
10650 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10652 * lread.c: Make symbols static if they're not exported.
10653 (read_objects, initial_obarray, oblookup_last_bucket_number):
10655 (make_symbol): Remove; unused.
10656 * lisp.h (initial_obarray, make_symbol): Remove decls.
10658 * keyboard.c: Make symbols static if they're not exported.
10659 (single_kboard, recent_keys_index, total_keys, recent_keys):
10660 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10661 (this_single_command_key_start, echoing, last_auto_save):
10662 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10663 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10664 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10665 (Vlispy_mouse_stem, double_click_count):
10667 (force_auto_save_soon): Define only if SIGDANGER.
10668 (ignore_mouse_drag_p): Now static if
10669 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10670 (print_help): Remove; unused.
10671 (stop_character, last_timer_event): Mark as externally visible.
10672 * keyboard.h (ignore_mouse_drag_p): Declare only if
10673 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10674 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10675 * lisp.h (echoing): Remove decl.
10676 (force_auto_save_soon): Declare only if SIGDANGER.
10677 * xdisp.c (redisplay_window): Simplify code, to make it more
10678 obvious that ignore_mouse_drag_p is not accessed if !defined
10679 USE_GTK && !defined HAVE_NS.
10681 * intervals.c: Make symbols static if they're not exported.
10682 (merge_properties_sticky, merge_interval_right, delete_interval):
10684 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10686 * insdel.c: Make symbols static if they're not exported.
10687 However, leave prepare_to_modify_buffer alone. It's never
10688 called from outside this function, but that appears to be a bug.
10689 (combine_after_change_list, combine_after_change_buffer):
10690 (adjust_after_replace, signal_before_change): Now static.
10691 (adjust_after_replace_noundo): Remove; unused.
10692 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10693 (signal_before_change): Remove decls.
10695 * indent.c (val_compute_motion, val_vmotion): Now static.
10697 * image.c: Make symbols static if they're not exported.
10698 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10700 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10701 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10703 * fringe.c (standard_bitmaps): Now static.
10704 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10706 * frame.c: Make symbols static if they're not exported.
10707 (x_report_frame_params, make_terminal_frame): Now static.
10708 (get_frame_param): Now static, unless HAVE_NS.
10709 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10710 (x_get_resource_string): Remove; not used.
10711 * frame.h (make_terminal_frame, x_report_frame_params):
10712 (x_get_resource_string); Remove decls.
10713 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10714 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10716 * font.c, fontset.c: Make symbols static if they're not exported.
10717 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10718 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10719 * font.c (font_close_object): Now static.
10720 * font.h (font_close_object): Remove.
10721 * fontset.c (FONTSET_OBJLIST): Remove.
10722 (free_realized_fontset) #if-0 the body, which does nothing.
10723 (face_suitable_for_char_p): #if-0, as it's never called.
10724 * fontset.h (face_suitable_for_char_p): Remove decl.
10725 * xfaces.c (face_at_string_position):
10726 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10727 since 0 is always ASCII.
10729 * fns.c (weak_hash_tables): Now static.
10731 * fileio.c: Make symbols static if they're not exported.
10732 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10733 (Vwrite_region_annotation_buffers): Now static.
10735 * eval.c: Make symbols static if they're not exported.
10736 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10737 * lisp.h (backtrace_list): Remove decl.
10739 * emacs.c: Make symbols static if they're not exported.
10740 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10741 (fatal_error_code, fatal_error_signal_hook, standard_args):
10743 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10744 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10745 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10746 * lisp.h (fatal_error_signal_hook): Remove decl.
10747 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10749 * editfns.c: Move a (normally-unused) function to its only use.
10750 * editfns.c, lisp.h (get_operating_system_release): Remove.
10751 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10752 worth the hassle of breaking this out.
10754 * xterm.c: Make symbols static if they're not exported.
10755 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10756 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10757 (x_destroy_window, x_delete_display):
10759 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10760 (x_mouse_leave): Remove; unused.
10761 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10762 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10763 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10765 (x_mouse_leave): Declare only if WINDOWSNT.
10766 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10767 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10770 * ftxfont.c: Make symbols static if they're not exported.
10771 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10773 * font.h (ftxfont_driver): Likewise.
10775 * xfns.c: Make symbols static if they're not exported.
10776 (x_last_font_name, x_display_info_for_name):
10777 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10778 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10779 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10780 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10781 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10782 (last_show_tip_args): Now static.
10783 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10784 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10785 (x_screen_planes): Remove; unused.
10786 * dispextern.h (x_screen_planes): Remove decl.
10788 * dispnew.c: Make symbols static if they're not exported.
10789 * dispextern.h (redraw_garbaged_frames, scrolling):
10790 (increment_row_positions): Remove.
10791 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10792 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10794 (redraw_garbaged_frames): Remove; unused.
10796 * xfaces.c: Make symbols static if they're not exported.
10797 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10799 * xterm.h (defined_color): Remove decls.
10800 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10801 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10802 (menu_face_changed_default, defined_color, free_realized_face):
10803 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10804 (ascii_face_of_lisp_face): Remove; unused.
10806 * xdisp.c: Make symbols static if they're not exported.
10807 * dispextern.h (scratch_glyph_row, window_box_edges):
10808 (glyph_to_pixel_coords, set_cursor_from_row):
10809 (get_next_display_element, set_iterator_to_next):
10810 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10811 (show_mouse_face): Remove decls
10812 * frame.h (message_buf_print): Likewise.
10813 * lisp.h (pop_message, set_message, check_point_in_composition):
10815 * xterm.h (set_vertical_scroll_bar): Likewise.
10816 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10817 (message_buf_print, scratch_glyph_row, displayed_buffer):
10818 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10819 (get_next_display_element, show_mouse_face, window_box_edges):
10820 (frame_to_window_pixel_xy, check_point_in_composition):
10821 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10822 (glyph_to_pixel_coords): Remove; unused.
10824 * dired.c (file_name_completion): Now static.
10826 * dbusbind.c (xd_in_read_queued_messages): Now static.
10828 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10829 * data.c (circular_list_error): Remove.
10831 * commands.h (last_point_position, last_point_position_buffer):
10832 (last_point_position_window): Remove decls.
10833 * keyboard.c: Make these variables static.
10835 * coding.h (coding, code_convert_region, encode_coding_gap):
10837 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10838 (iso_code_class, detect_coding, code_convert_region): Now static.
10839 (encode_coding_gap): Remove; unused.
10841 * chartab.c (chartab_chars, chartab_bits): Now static.
10843 * charset.h (charset_iso_8859_1): Remove decl.
10844 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10847 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10848 * ccl.c (Vccl_program_table): Now static.
10849 (check_ccl_update): Remove; unused.
10851 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10852 * category.h: ... from here.
10853 * category.c (check_category_table, set_category_set): Now static.
10855 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10856 * lisp.h: Remove these decls.
10858 * buffer.c (buffer_count): Remove unused var.
10860 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10861 so that it's not optimized away.
10862 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10863 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10864 exported only to the debugger.
10866 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10867 * atimer.h (run_all_atimers): Remove; not exported.
10869 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10870 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10871 was inaccessible from Lisp.
10872 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10873 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10875 alloc.c: Import and export fewer symbols, and remove unused items.
10876 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10878 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10879 it's not optimized away by whole-program optimization.
10880 (message_enable_multibyte, free_misc): Remove.
10881 (catchlist, handlerlist, mark_backtrace):
10882 Declare only if BYTE_MARK_STACK.
10883 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10884 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10885 (message_enable_multibyte): Remove decl.
10886 (free_misc, interval_free_list, float_block, float_block_index):
10887 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10888 (cons_free_list, last_marked_index):
10890 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10891 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10892 (mark_backtrace): Define only if BYTE_MARK_STACK.
10893 * xdisp.c (message_enable_multibyte): Now static.
10895 Declare Lisp_Object Q* variables to be 'static' if not exported.
10896 This makes it easier for human readers (and static analyzers)
10897 to see whether these variables are used from other modules.
10898 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10899 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10900 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10901 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10902 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10903 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10904 * xmenu.c, xselect.c:
10905 Declare Q* vars static if they are not used in other modules.
10906 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10907 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10908 Remove decls of unexported vars.
10909 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10911 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10913 Make Emacs functions such as Fatom 'static' by default.
10914 This makes it easier for human readers (and static analyzers)
10915 to see whether these functions can be called from other modules.
10916 DEFUN now defines a static function. To make the function external
10917 so that it can be used in other C modules, use the new macro DEFUE.
10918 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10919 (Finit_image_library):
10920 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10921 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10922 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10923 Remove decls, since these functions are now static.
10924 (Funintern, Fget_internal_run_time): New decls, since these functions
10925 were already external.
10927 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10928 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10929 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10930 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10931 * keyboard.c, keymap.c, lread.c:
10932 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10933 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10934 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10935 Mark functions with DEFUE instead of DEFUN,
10936 if they are used in other modules.
10937 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10938 decls for now-static functions.
10939 * buffer.h (Fdelete_overlay): Remove decl.
10940 * callproc.c (Fgetenv_internal): Mark as internal.
10941 * composite.c (Fremove_list_of_text_properties): Remove decl.
10942 (Fcomposition_get_gstring): New forward static decl.
10943 * composite.h (Fcomposite_get_gstring): Remove decl.
10944 * dired.c (Ffile_attributes): New forward static decl.
10945 * doc.c (Fdocumntation_property): New forward static decl.
10946 * eval.c (Ffetch_bytecode): New forward static decl.
10947 (Funintern): Remove extern decl; now in .h file where it belongs.
10948 * fileio.c (Fmake_symbolic_link): New forward static decl.
10949 * image.c (Finit_image_library): New forward static decl.
10950 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10951 * intervals.h (Fprevious_property_change):
10952 (Fremove_list_of_text_properties): Remove decls.
10953 * keyboard.c (Fthis_command_keys): Remove decl.
10954 (Fcommand_execute): New forward static decl.
10955 * keymap.c (Flookup_key): New forward static decl.
10956 (Fcopy_keymap): Now static.
10957 * keymap.h (Flookup_key): Remove decl.
10958 * process.c (Fget_process): New forward static decl.
10959 (Fprocess_datagram_address): Mark as internal.
10960 * syntax.c (Fsyntax_table_p): New forward static decl.
10961 (skip_chars): Remove duplicate decl.
10962 * textprop.c (Fprevious_property_change): New forward static decl.
10963 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10965 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10966 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10968 * editfns.c (Fformat): Remove unreachable code.
10970 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10972 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10975 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10977 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10978 when at ZV. (Bug#8487)
10980 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10982 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10984 * keyboard.c (parse_tool_bar_item): Likewise.
10985 * sound.c (sound_cleanup, alsa_close): Likewise.
10986 * termcap.c (tgetent): Likewise.
10987 * xfns.c (x_default_font_parameter): Likewise.
10988 * xsettings.c (read_and_apply_settings): Likewise.
10990 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10991 (overrun_check_free): Protoize.
10993 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10995 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10996 since callers should never pass a negative size.
10997 Change the signature to match that of plain 'read' and 'write'; see
10998 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10999 * lisp.h: Update prototypes of emacs_write and emacs_read.
11001 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11003 * xdisp.c (redisplay_window): Don't try to determine the character
11004 position of the scroll margin if the window start point w->startp
11005 is outside the buffer's accessible region. (Bug#8468)
11007 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11009 Fix write-region and its subroutines for buffers > 2GB.
11010 * fileio.c (a_write, e_write): Modify declaration of arguments and
11011 local variables to support buffers larger than 2GB.
11012 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11014 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11015 argument, local variables, and return value.
11017 * lisp.h: Update prototypes of emacs_write and emacs_read.
11019 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11021 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11023 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11025 Fix more problems found by GCC 4.6.0's static checks.
11027 * xdisp.c (vmessage): Use a better test for character truncation.
11029 * charset.c (load_charset_map): <, not <=, for optimization,
11030 and to avoid potential problems with integer overflow.
11031 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11032 * casetab.c (set_identity, shuffle): Likewise.
11033 * editfns.c (Fformat): Likewise.
11034 * syntax.c (skip_chars): Likewise.
11036 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11037 This also lets GCC 4.6.0 generate slightly better loop code.
11039 * callint.c (Fcall_interactively): <, not <=, for optimization.
11040 (Fcall_interactively): Count the number of arguments produced,
11041 not the number of arguments given. This is simpler and lets GCC
11042 4.6.0 generate slightly better code.
11044 * ftfont.c: Distingish more carefully between FcChar8 and char.
11045 The previous code passed unsigned char * to a functions like
11046 strlen and xstrcasecmp that expect char *, which does not
11047 conform to the C standard.
11048 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11049 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11050 char * when the C standard requires it.
11052 * keyboard.c (read_char): Remove unused var.
11054 * eval.c: Port to Windows vsnprintf (Bug#8435).
11055 Include <limits.h>.
11056 (SIZE_MAX): Define if the headers do not.
11057 (verror): Do not give up if vsnprintf returns a negative count.
11058 Instead, grow the buffer. This ports to Windows vsnprintf, which
11059 does not conform to C99. Problem reported by Eli Zaretskii.
11060 Also, simplify the allocation scheme, by avoiding the need for
11061 calling realloc, and removing the ALLOCATED variable.
11063 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11065 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11066 But keep the doprint source code for now, as we might revamp it
11067 and use it again (Bug#8435).
11068 * lisp.h (doprnt): Remove.
11069 * Makefile.in (base_obj): Remove doprnt.o.
11070 * deps.mk (doprnt.o): Remove.
11072 error: Print 32- and 64-bit integers portably (Bug#8435).
11073 Without this change, on typical 64-bit hosts error ("...%d...", N)
11074 was used to print both 32- and 64-bit integers N, which relied on
11075 undefined behavior.
11076 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11077 * lisp.h (error, verror): Mark as printf-like functions.
11078 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11079 Report overflow in size calculations when allocating printf buffer.
11080 Do not truncate output string at its first null byte.
11081 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11082 Truncate the output at a character boundary, since vsnprintf does not
11084 * charset.c (check_iso_charset_parameter): Convert internal
11085 character to string before calling 'error', since %c now has the
11087 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11088 overflow when computing char to be passed to 'error'. Do not
11089 pass Lisp_Object to 'error'; pass the integer instead.
11090 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11091 formatted with plain %d.
11093 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11095 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11097 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11099 * xterm.c (x_catch_errors): Remove duplicate declaration.
11101 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11103 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11105 2011-04-10 Jim Meyering <meyering@redhat.com>
11107 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11108 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11109 return ssize_t not "int", and use size_t as the buffer length.
11110 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11111 * gnutls.h: Update declarations.
11112 * process.c (read_process_output): Use ssize_t, to match.
11113 (send_process): Likewise.
11115 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11117 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11119 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11121 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11122 Use unsigned char, to match FcChar8 type definition.
11124 * xterm.c (handle_one_xevent):
11125 * xmenu.c (create_and_show_popup_menu):
11126 * xselect.c (x_decline_selection_request)
11127 (x_reply_selection_request): Avoid type-punned deref of X events.
11129 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11131 Fix some uses of `int' instead of EMACS_INT.
11132 * search.c (string_match_1, fast_string_match)
11133 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11134 (scan_buffer, find_next_newline_no_quit)
11135 (find_before_next_newline, search_command, Freplace_match)
11136 (Fmatch_data): Make some `int' variables be EMACS_INT.
11138 * xdisp.c (display_count_lines): 3rd argument and return value now
11139 EMACS_INT. All callers changed.
11140 (pint2hrstr): Last argument is now EMACS_INT.
11142 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11143 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11144 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11145 (decode_coding_utf_16, decode_coding_emacs_mule)
11146 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11147 (decode_coding_ccl, decode_coding_charset)
11148 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11149 (decode_coding_iso_2022, decode_coding_emacs_mule)
11150 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11151 <char_offset, last_offset>: Declare EMACS_INT.
11152 (encode_coding_utf_8, encode_coding_utf_16)
11153 (encode_coding_emacs_mule, encode_invocation_designation)
11154 (encode_designation_at_bol, encode_coding_iso_2022)
11155 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11156 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11158 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11159 (encode_invocation_designation): Last argument P_NCHARS is now
11161 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11162 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11164 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11167 * ccl.c (Fccl_execute_on_string): Declare some variables
11170 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11172 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11174 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11176 * process.c (Fformat_network_address): Doc fix.
11178 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11180 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11182 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11184 * keyboard.c (read_char): Call Lisp function help-form-show,
11185 instead of using internal_with_output_to_temp_buffer.
11186 (Qhelp_form_show): New var.
11187 (syms_of_keyboard): Use DEFSYM macro.
11189 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11191 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11193 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11195 * process.c (Flist_processes): Remove to Lisp.
11196 (list_processes_1): Delete.
11198 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11200 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11202 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11204 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11206 Fix more problems found by GCC 4.6.0's static checks.
11208 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11210 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11212 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11214 * xdisp.c (vmessage): Mark as a printf-like function.
11216 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11218 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11220 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11221 printf-like functions.
11222 (tiff_load): Add casts to remove these marks before passing them
11223 to system-supplied API.
11225 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11227 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11228 This avoids several warnings with gcc -Wstrict-overflow.
11229 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11230 directly, rather than having caller test rule sign. This avoids
11231 some unnecessary tests.
11232 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11233 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11234 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11236 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11237 (xfont_open): Avoid unnecessary tests.
11239 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11241 * composite.h, composite.c (composition_gstring_put_cache):
11242 Use EMACS_INT, not int, for length.
11244 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11245 breaking out part of COMPOSITION_DECODE_RULE.
11246 (COMPOSITION_DECODE_RULE): Use it.
11247 * composite.c (get_composition_id): Remove unused local vars,
11248 by using the new macro.
11250 * textprop.c (set_text_properties_1): Change while to do-while,
11251 since the condition is always true at first.
11253 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11254 (interval_deletion_adjustment): Return unsigned value.
11257 * process.c (list_processes_1, create_pty, read_process_output):
11258 (exec_sentinel): Remove vars that were set but not used.
11259 (create_pty): Remove unnecessary "volatile"s.
11260 (Fnetwork_interface_info): Avoid possibility of int overflow.
11261 (read_process_output): Do adaptive read buffering even if carryover.
11262 (read_process_output): Simplify nbytes computation if buffered.
11264 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11266 * syntax.c (scan_words): Remove var that was set but not used.
11267 (update_syntax_table): Use unsigned instead of int.
11269 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11270 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11271 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11273 * print.c (print_error_message): Avoid int overflow.
11275 * font.c (font_list_entities): Redo for clarity,
11276 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11278 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11279 (font_score): Avoid potential overflow in diff calculation.
11281 * fns.c (substring_both): Remove var that is set but not used.
11282 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11284 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11286 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11287 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11288 can always succeed if overflow has undefined behavior.
11290 * search.c (boyer_moore, wordify): Remove vars set but not used.
11291 (wordify): Omit three unnecessary tests.
11293 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11294 All callers changed. This avoids the need for an unused var.
11296 * casefiddle.c (casify_region): Remove var that is set but not used.
11298 * dired.c (file_name_completion): Remove var that is set but not used.
11300 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11302 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11303 (Finsert_file_contents): Remove unnecessary code checking fd.
11305 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11306 Check for integer overflow on size calculations.
11308 * buffer.c (Fprevious_overlay_change): Remove var that is set
11311 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11312 Remove vars that are set but not used.
11313 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11314 (timer_check_2): Mark vars as initialized.
11316 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11318 * image.c (lookup_image): Remove var that is set but not used.
11319 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11321 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11322 that are set but not used.
11324 * xfns.c (make_invisible_cursor): Don't return garbage
11325 if XCreateBitmapFromData fails (Bug#8410).
11327 * xselect.c (x_get_local_selection, x_handle_property_notify):
11328 Remove vars that are set but not used.
11330 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11331 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11333 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11334 Remove var that is set but not used.
11335 (scroll_bar_windows_size): Now size_t, not int.
11336 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11337 Check for overflow.
11339 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11340 (map_tty_color) [!defined MSDOS]: Likewise.
11342 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11344 * coding.c: Remove vars that are set but not used.
11345 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11346 All callers changed.
11347 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11348 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11349 (decode_coding_charset): Remove vars that are set but not used.
11351 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11352 that is set but not used.
11354 * print.c (print_object): Remove var that is set but not used.
11356 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11357 The gnulib version avoids calling malloc in the usual case,
11358 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11359 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11360 * filelock.c (current_lock_owner): Likewise.
11361 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11362 * sysdep.c: Include allocator.h, careadlinkat.h.
11363 (emacs_no_realloc_allocator): New static constant.
11364 (emacs_readlink): New function.
11365 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11366 ../lib/careadlinkat.h.
11368 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11370 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11371 first non-nil return value).
11373 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11375 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11376 if not defined (Bug#8403).
11378 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11380 * xdisp.c (display_count_lines): Remove parameter `start',
11381 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11382 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11383 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11384 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11385 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11386 and thereabouts. All callers changed.
11387 (get_per_char_metric): Remove parameter `f', unused since
11388 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11390 2011-04-02 Jim Meyering <meyering@redhat.com>
11392 do not dereference NULL upon failed strdup
11393 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11394 (ns_get_family): Likewise.
11396 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11398 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11400 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11402 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11405 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11407 Add lexical binding.
11409 * window.c (Ftemp_output_buffer_show): New fun.
11410 (Fsave_window_excursion):
11411 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11413 * lread.c (lisp_file_lexically_bound_p): New function.
11414 (Fload): Bind Qlexical_binding.
11415 (readevalloop): Remove `evalfun' arg.
11416 Bind Qinternal_interpreter_environment.
11417 (Feval_buffer): Bind Qlexical_binding.
11418 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11420 (syms_of_lread): Declare `lexical-binding'.
11422 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11424 * keyboard.c (eval_dyn): New fun.
11425 (menu_item_eval_property): Use it.
11427 * image.c (parse_image_spec): Use Ffunctionp.
11429 * fns.c (concat, mapcar1): Accept byte-code-functions.
11431 * eval.c (Fsetq): Handle lexical vars.
11432 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11433 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11434 (FletX, Flet): Obey lexical binding.
11435 (Fcommandp): Handle closures.
11436 (Feval): New `lexical' arg.
11437 (eval_sub): New function extracted from Feval. Use it almost
11438 everywhere where Feval was used. Look up vars in lexical env.
11440 (Ffunctionp): Move from subr.el.
11441 (Ffuncall): Handle closures.
11442 (apply_lambda): Remove `eval_flags'.
11443 (funcall_lambda): Handle closures and new byte-code-functions.
11444 (Fspecial_variable_p): New function.
11445 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11446 but without exporting it to Lisp.
11448 * doc.c (Fdocumentation, store_function_docstring):
11449 * data.c (Finteractive_form): Handle closures.
11451 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11454 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11456 (exec_byte_code): New function extracted from Fbyte_code to handle new
11457 calling convention for byte-code-functions. Add new byte-codes.
11459 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11461 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11463 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11465 * xdisp.c (redisplay_internal): Fix prototype.
11467 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11469 * xdisp.c (SCROLL_LIMIT): New macro.
11470 (try_scrolling): Use it when setting scroll_limit.
11471 Limit scrolling to 100 screen lines.
11472 (redisplay_window): Even when falling back on "recentering",
11473 position point in the window according to scroll-conservatively,
11474 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11476 (try_scrolling): When point is above the window, allow searching
11477 as far as scroll_max, or one screenful, to compute vertical
11478 distance from PT to the scroll margin position. This prevents
11479 try_scrolling from unnecessarily failing when
11480 scroll-conservatively is set to a value slightly larger than the
11481 window height. Clean up the case of PT below the margin at bottom
11482 of window: scroll_max can no longer be INT_MAX. When aggressive
11483 scrolling is in use, don't let point enter the opposite scroll
11484 margin as result of the scroll.
11485 (syms_of_xdisp) <scroll-conservatively>: Document the
11486 threshold of 100 lines for never-recentering scrolling.
11488 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11490 * dispextern.h (move_it_by_lines):
11491 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11492 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11493 (message_log_check_duplicate): Remove parameters `prev_bol' and
11494 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11495 (redisplay_internal): Remove parameter `preserve_echo_area',
11496 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11498 * indent.c (Fvertical_motion):
11499 * window.c (window_scroll_pixel_based, Frecenter):
11500 Don't pass `need_y_p' to `move_it_by_lines'.
11502 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11504 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11505 steal a few bits to be more compact.
11506 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11507 Remove unneeded casts.
11509 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11511 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11513 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11514 binding" message (bug#7967).
11516 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11518 Fix more problems found by GCC 4.6.0's static checks.
11520 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11521 Remove unused local var.
11523 * editfns.c (Fmessage_box): Remove unused local var.
11525 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11526 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11527 Omit unused local vars.
11528 * window.c (shrink_windows): Omit unused local var.
11529 * menu.c (digest_single_submenu): Omit unused local var.
11530 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11531 Omit unused local var.
11533 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11534 Don't assume string length fits in int.
11535 (keyremap_step, read_key_sequence): Use size_t for sizes.
11536 (read_key_sequence): Don't check last_real_key_start redundantly.
11538 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11539 instead of alloca (Bug#8344).
11541 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11542 (Fbacktrace_frame): Don't assume nframes fits in int.
11544 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11546 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11549 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11551 * cm.c (calccost): Turn while-do into do-while, for clarity.
11553 * keyboard.c (syms_of_keyboard): Use the same style as later
11554 in this function when indexing through an array. This also
11555 works around GCC bug 48267.
11557 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11559 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11561 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11562 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11564 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11565 This avoids undefined behavior on integer overflow, and is a bit
11566 more convenient anyway since it is compared to a size_t variable.
11568 Variadic C functions now count arguments with size_t, not int.
11569 This avoids an unnecessary limitation on 64-bit machines, which
11570 caused (substring ...) to crash on large vectors (Bug#8344).
11571 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11572 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11573 All variadic functions and their callers changed accordingly.
11574 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11575 * data.c (arith_driver, float_arith_driver): Likewise.
11576 * editfns.c (general_insert_function): Likewise.
11577 * eval.c (struct backtrace.nargs, interactive_p)
11578 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11579 (funcall_lambda, mark_backtrace): Likewise.
11580 * fns.c (concat): Likewise.
11581 * frame.c (x_set_frame_parameters): Likewise.
11582 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11583 0 if not found, not -1. All callers changed.
11585 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11586 (stack_copy_size): Now size_t, not int.
11587 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11589 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11591 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11592 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11593 All callers changed.
11595 * lisp.h (multibyte_char_to_unibyte):
11596 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11597 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11598 * character.h (CHAR_TO_BYTE8):
11599 * cmds.c (internal_self_insert):
11600 * editfns.c (general_insert_function):
11601 * keymap.c (push_key_description):
11602 * search.c (Freplace_match):
11603 * xdisp.c (message_dolog, set_message_1): All callers changed.
11605 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11607 * keyboard.c (safe_run_hook_funcall): New function.
11608 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11609 don't set the hook to nil, but remove the offending function instead.
11610 (Qcommand_hook_internal): Remove, unused.
11611 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11612 Vcommand_hook_internal.
11614 * eval.c (enum run_hooks_condition): Remove.
11615 (funcall_nil, funcall_not): New functions.
11616 (run_hook_with_args): Call each function through a `funcall' argument.
11617 Remove `cond' argument, now redundant.
11618 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11619 (Frun_hook_with_args_until_failure): Adjust accordingly.
11620 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11622 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11624 * dispextern.h (string_buffer_position): Remove declaration.
11626 * print.c (strout): Remove parameter `multibyte', unused since
11627 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11629 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11630 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11631 All callers changed.
11633 * w32.c (_wsa_errlist): Use braces for struct initializers.
11635 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11636 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11637 All callers changed.
11638 (string_buffer_position): Likewise. Also, make static (it's never
11639 used outside xdisp.c).
11640 (cursor_row_p): Remove parameter `w', unused since
11641 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11642 (decode_mode_spec): Remove parameter `precision', introduced during
11643 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11644 All callers changed.
11646 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11648 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11650 2011-03-27 Anders Lindgren <andlind@gmail.com>
11652 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11653 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11654 (ns_update_auto_hide_menu_bar): New functions.
11655 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11656 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11657 ns_constrain_all_frames.
11658 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11659 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11661 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11663 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11665 2011-03-27 Glenn Morris <rgm@gnu.org>
11667 * syssignal.h: Replace RETSIGTYPE with void.
11668 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11669 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11670 Replace SIGTYPE with void everywhere.
11671 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11672 * s/template.h (SIGTYPE): Remove commented out definition.
11674 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11676 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11677 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11679 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11681 * w32.c (read_unc_volume): Use parameter `henum', instead of
11682 global variable `wget_enum_handle'.
11684 * keymap.c (describe_vector): Remove parameters `indices' and
11685 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11686 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11688 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11690 * keyboard.c (timer_check): Remove parameter `do_it_now',
11691 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11692 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11693 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11695 * keyboard.c (read_char):
11696 * w32menu.c (w32_menu_display_help):
11697 * xmenu.c (show_help_event, menu_help_callback):
11698 Adjust calls to `show_help_echo'.
11700 * gtkutil.c (xg_maybe_add_timer):
11701 * keyboard.c (readable_events):
11702 * process.c (wait_reading_process_output):
11703 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11705 * insdel.c (adjust_markers_gap_motion):
11706 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11707 (gap_left, gap_right): Don't call it.
11709 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11711 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11712 incurred during fontification.
11714 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11716 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11717 (DEFVAR_PER_BUFFER): Don't pass it.
11719 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11720 (scrolling_window): Don't pass it.
11722 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11724 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11726 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11728 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11729 of variables specific to SELinux and computation of `encoded_absname'.
11731 * image.c (XPutPixel): Remove unused variable `height'.
11733 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11735 * unexw32.c (get_section_info): Remove unused variable `section'.
11737 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11738 (system_process_attributes): Remove unused variable `sess'.
11739 (sys_read): Remove unused variable `err'.
11741 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11742 (w32_wnd_proc): Remove unused variable `isdead'.
11743 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11744 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11745 (x_create_tip_frame): Remove unused variable `tem'.
11747 * w32inevt.c (w32_console_read_socket):
11748 Remove unused variable `no_events'.
11750 * w32term.c (x_draw_composite_glyph_string_foreground):
11751 Remove unused variable `width'.
11753 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11755 * w32term.c (x_set_glyph_string_clipping):
11756 Don't pass uninitialized region to CombineRgn.
11758 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11760 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11761 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11762 (Fx_close_connection): Remove unused variable `i'.
11764 * w32font.c (w32font_draw): Return number of glyphs.
11765 (w32font_open_internal): Remove unused variable `i'.
11766 (w32font_driver): Add missing initializer.
11768 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11769 (fill_in_menu): Remove unused variable `items_added'.
11771 * w32term.c (last_mouse_press_frame): Remove static global variable.
11772 (w32_clip_to_row): Remove unused variable `f'.
11773 (x_delete_terminal): Remove unused variable `i'.
11775 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11776 (NOTHING): Remove unused static global variable.
11777 (uniscribe_check_otf): Remove unused variable `table'.
11778 (uniscribe_font_driver): Add missing initializers.
11780 2011-03-23 Julien Danjou <julien@danjou.info>
11782 * term.c (Fsuspend_tty, Fresume_tty):
11783 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11784 * window.c (temp_output_buffer_show):
11785 * insdel.c (signal_before_change):
11786 * frame.c (Fhandle_switch_frame):
11787 * fileio.c (Fdo_auto_save):
11788 * emacs.c (Fkill_emacs):
11789 * editfns.c (save_excursion_restore):
11790 * cmds.c (internal_self_insert):
11791 * callint.c (Fcall_interactively):
11792 * buffer.c (Fkill_all_local_variables):
11793 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11795 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11796 unconditionally since it does the check itself.
11798 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11800 Fix more problems found by GCC 4.5.2's static checks.
11802 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11803 the first time through the loop, since we know p0 < p1 then.
11804 This also avoids a gcc -Wstrict-overflow warning.
11806 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11807 leading to a memory leak, possible in functions like
11808 load_charset_map_from_file that can allocate an unbounded number
11809 of objects (Bug#8318).
11811 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11812 that could (at least in theory) be that large.
11814 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11815 This is less likely to overflow, and avoids undefined behavior if
11816 overflow does occur. All callers changed. Use strtoul to scan
11817 for the unsigned long integer.
11818 (pint2hrstr): Simplify and tune code slightly.
11819 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11821 * scroll.c (do_scrolling): Work around GCC bug 48228.
11822 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11824 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11825 This also avoids a warning with gcc -Wstrict-overflow.
11826 (validate_x_resource_name): Simplify count usage.
11827 This also avoids a warning with gcc -Wstrict-overflow.
11829 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11832 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11834 * process.c (Fmake_network_process): Use socklen_t, not int,
11835 where POSIX says socklen_t is required in portable programs.
11836 This fixes a porting bug on hosts like 64-bit HP-UX, where
11837 socklen_t is wider than int (Bug#8277).
11838 (Fmake_network_process, server_accept_connection):
11839 (wait_reading_process_output, read_process_output):
11842 * process.c: Rename or move locals to avoid shadowing.
11843 (list_processes_1, Fmake_network_process):
11844 (read_process_output_error_handler, exec_sentinel_error_handler):
11845 Rename or move locals.
11846 (Fmake_network_process): Define label "retry_connect" only if needed.
11847 (Fnetwork_interface_info): Fix pointer signedness.
11848 (process_send_signal): Add cast to avoid pointer signedness problem.
11849 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11850 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11852 Make tparam.h and terminfo.c consistent.
11853 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11854 Include tparam.h instead, since it declares them.
11855 * cm.h (PC): Remove extern decl; tparam.h now does this.
11856 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11857 * terminfo.c: Include tparam.h, to check interfaces.
11858 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11859 (tparam): Adjust signature to match interface in tparam.h;
11860 this removes some undefined behavior. Check that outstring and len
11861 are zero, which they always are with Emacs.
11862 * tparam.h (PC, BC, UP): New extern decls.
11864 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11865 (xftfont_open): Rename locals to avoid shadowing.
11867 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11868 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11869 (OTF_TAG_SYM): Omit macro if not needed.
11870 (ftfont_list): Remove unused local.
11871 (get_adstyle_property, ftfont_pattern_entity):
11872 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11873 Rename locals to avoid shadowing.
11875 * xfont.c (xfont_list_family): Mark var as initialized.
11877 * xml.c (make_dom): Now static.
11879 * composite.c (composition_compute_stop_pos): Rename local to
11881 (composition_reseat_it): Remove unused locals.
11882 (find_automatic_composition, composition_adjust_point): Likewise.
11883 (composition_update_it): Mark var as initialized.
11884 (find_automatic_composition): Mark vars as initialized,
11885 with a FIXME (Bug#8290).
11887 character.h: Rename locals to avoid shadowing.
11888 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11889 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11890 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11891 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11892 to avoid shadowing.
11894 * textprop.c (property_change_between_p): Remove; unused.
11896 * intervals.c (interval_start_pos): Now static.
11898 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11900 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11901 Rename locals to avoid shadowing.
11903 * sound.c (wav_play, au_play, Fplay_sound_internal):
11904 Fix pointer signedness.
11905 (alsa_choose_format): Remove unused local var.
11906 (wav_play): Initialize a variable to 0, to prevent undefined
11907 behavior (Bug#8278).
11909 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11911 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11913 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11914 clobbering (Bug#8298).
11915 * sysdep.c (sys_subshell): Likewise.
11916 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11918 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11919 This should get cleaned up, so that child_setup has the
11920 same signature on all platforms.
11922 * callproc.c (call_process_cleanup): Now static.
11923 (relocate_fd): Rename locals to avoid shadowing.
11925 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11927 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11928 not to be necessary, and produces flickering.
11930 2011-03-20 Glenn Morris <rgm@gnu.org>
11932 * config.in: Remove file.
11934 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11936 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11937 are now in src/globals.h.
11938 (syms_of_minibuf): Remove spurious & from previous change.
11940 2011-03-20 Leo Liu <sdl.web@gmail.com>
11942 * minibuf.c (completing-read-function): New variable.
11943 (completing-read-default): Rename from completing-read.
11944 (completing-read): Call completing-read-function.
11946 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11948 * xfaces.c (Fx_load_color_file):
11949 Read color file from absolute filename (bug#8250).
11951 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11953 * makefile.w32-in: Update dependencies.
11955 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11957 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11959 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11961 Fix more problems found by GCC 4.5.2's static checks.
11963 * process.c (make_serial_process_unwind, send_process_trap):
11964 (sigchld_handler): Now static.
11966 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11967 That way, the code declares only the vars that it needs.
11968 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11969 * s/cygwin.h (PTY_ITERATION): Likewise.
11970 * s/darwin.h (PTY_ITERATION): Likewise.
11971 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11973 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11974 * process.c (allocate_pty): Don't declare stb unless it's needed.
11976 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11977 (CONSTANTLIM): Remove; unused.
11978 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11979 Define only if needed.
11981 * unexelf.c (unexec): Name an expression,
11982 to avoid gcc -Wbad-function-cast warning.
11983 Use a different way to cause a compilation error if anyone uses
11984 n rather than nn, a way that does not involve shadowing.
11985 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11987 * deps.mk (unexalpha.o): Remove; unused.
11989 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11990 * unexec.h: New file.
11991 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11992 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11993 Depend on unexec.h.
11994 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11995 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11996 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11997 Change as necessary to match prototype in unexec.h.
11999 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12001 (back_comment, skip_chars): Mark vars as initialized.
12003 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12004 Rename locals to avoid shadowing.
12006 * lread.c (read1): Rewrite so as not to use empty "else".
12007 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12009 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12011 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12012 warning when compiling print.c.
12014 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12015 instead of using an uninitialized var.
12016 (font_sort_entities): Mark var as initialized.
12018 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12020 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12021 pointers to constants.
12022 (font_parse_fcname): Remove unused vars.
12023 (font_delete_unmatched): Now static.
12024 (font_get_spec): Remove; unused.
12025 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12026 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12027 Rename or move locals to avoid shadowing.
12029 * fns.c (require_nesting_list, require_unwind): Now static.
12030 (Ffillarray): Rename locals to avoid shadowing.
12032 * floatfns.c (domain_error2): Define only if needed.
12033 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12035 * alloc.c (mark_backtrace): Move decl from here ...
12036 * lisp.h: ... to here, so that it can be checked.
12038 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12039 (Fdefvar): Rewrite so as not to use empty "else".
12040 (lisp_indirect_variable): Name an expression,
12041 to avoid gcc -Wbad-function-cast warning.
12042 (Fdefvar): Rename locals to avoid shadowing.
12044 * callint.c (quotify_arg, quotify_args): Now static.
12045 (Fcall_interactively): Rename locals to avoid shadowing.
12046 Use const pointer when appropriate.
12048 * lisp.h (get_system_name, get_operating_system_release):
12049 Move decls here, to check interfaces.
12050 * process.c (get_operating_system_release): Move decl to lisp.h.
12051 * xrdb.c (get_system_name): Likewise.
12052 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12053 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12054 some of which prompt warnings from gcc -Wbad-function-cast.
12055 (Fformat_time_string, Fencode_time, Finsert_char):
12056 (Ftranslate_region_internal, Fformat):
12057 Rename or remove local vars to avoid shadowing.
12058 (Ftranslate_region_internal): Mark var as initialized.
12060 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12063 * lisp.h (eassert): Check that the argument compiles, even if
12064 ENABLE_CHECKING is not defined.
12066 * data.c (Findirect_variable): Name an expression, to avoid
12067 gcc -Wbad-function-cast warning.
12068 (default_value, arithcompare, arith_driver, arith_error): Now static.
12069 (store_symval_forwarding): Rename local to avoid shadowing.
12070 (Fmake_variable_buffer_local, Fmake_local_variable):
12071 Mark variables as initialized.
12072 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12074 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12075 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12076 Rename locals to avoid shadowing.
12077 (mark_stack): Move local variables into the #ifdef region where
12079 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12080 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12082 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12083 (GC_STRING_CHARS): Remove; not used.
12084 (Fmemory_limit): Cast sbrk's returned value to char *.
12086 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12087 avoids undefined behavior in theory.
12089 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12091 Use functions, not macros, for up- and down-casing (Bug#8254).
12092 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12093 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12094 to use the following functions instead of these macros.
12095 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12096 EMACS_INT, since callers assume the returned value fits in int.
12097 (upcase1): Likewise, for UPCASE_TABLE.
12098 (uppercasep, lowercasep, upcase): New static inline functions.
12099 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12100 the race-condition problem in the old DOWNCASE.
12102 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12103 Rename locals to avoid shadowing.
12104 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12105 (regex_compile, re_search_2, re_match_2_internal):
12106 Remove unused local vars.
12107 (FREE_VAR): Rewrite so as not to use empty "else",
12108 which gcc can warn about.
12109 (regex_compile, re_match_2_internal): Mark locals as initialized.
12110 (RETALLOC_IF): Define only if needed.
12111 (WORDCHAR_P): Likewise. This one is never needed, but is used
12112 only in a comment talking about a compiler bug, so put inside
12113 the #if 0 of that comment.
12114 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12115 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12118 * search.c (boyer_moore): Rename locals to avoid shadowing.
12119 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12120 (PREV_CHAR_BOUNDARY): Likewise.
12122 * search.c (simple_search): Remove unused var.
12124 * dired.c (compile_pattern): Move decl from here ...
12125 * lisp.h: ... to here, so that it can be checked.
12126 (struct re_registers): New forward decl.
12128 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12130 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12132 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12133 Rename locals to avoid shadowing.
12134 (Fvertical_motion): Mark locals as initialized.
12136 * casefiddle.c (casify_object, casify_region): Now static.
12137 (casify_region): Mark local as initialized.
12139 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12141 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12142 New macros, so that the caller can use some names other than
12143 gcpro1, gcpro2, etc.
12144 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12146 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12147 argument, for consistency with GCPRO2_VAR, etc: it is now the
12148 prefix of the variable, not the variable itself. All uses
12150 * dired.c (directory_files_internal, file_name_completion):
12151 Rename locals to avoid shadowing.
12153 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12154 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12155 dired.c's scmp function, had undefined behavior.
12156 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12157 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12158 * buffer.h: ... to here, because these macros use current_buffer,
12159 and the new implementation with inline functions needs to have
12160 current_buffer in scope now, rather than later when the macros
12162 (downcase, upcase1): New static inline functions.
12163 (DOWNCASE, UPCASE1): Reimplement using these functions.
12164 This avoids undefined behavior in expressions like
12165 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12166 from race conditions in accessing the global variables
12167 case_temp1 and case_temp2.
12168 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12169 * lisp.h (case_temp1, case_temp2): Remove their decls.
12170 * character.h (ASCII_CHAR_P): Move from here ...
12171 * lisp.h: ... to here, so that the inline functions mentioned
12172 above can use them.
12174 * dired.c (directory_files_internal_unwind): Now static.
12176 * fileio.c (file_name_as_directory, directory_file_name):
12177 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12179 (file_name_as_directory): Use const pointers when appropriate.
12180 (Fexpand_file_name): Likewise. In particular, newdir might
12181 point at constant storage, so make it a const pointer.
12182 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12183 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12185 (Fset_file_times, Finsert_file_contents, auto_save_error):
12186 Rename locals to avoid shadowing.
12188 * minibuf.c (choose_minibuf_frame_1): Now static.
12189 (Ftry_completion, Fall_completions): Rename or remove locals
12190 to avoid shadowing.
12192 * marker.c (bytepos_to_charpos): Remove; unused.
12194 * lisp.h (verify_bytepos, count_markers): New decls,
12195 so that gcc does not warn that these functions aren't declared.
12197 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12198 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12199 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12200 (copy_text): Remove unused local var.
12202 * filelock.c (within_one_second): Now static.
12203 (lock_file_1): Rename local to avoid shadowing.
12205 * buffer.c (fix_overlays_before): Mark locals as initialized.
12206 (fix_start_end_in_overlays): Likewise. This function should be
12207 simplified by using pointers-to-pointers, but that's a different
12209 (switch_to_buffer_1): Now static.
12210 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12211 (report_overlay_modification): Rename locals to avoid shadowing.
12213 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12214 Fix pointer signedness issue.
12215 (sys_subshell): Mark local as volatile if checking for lint,
12216 to suppress a gcc -Wclobbered warning that does not seem to be right.
12217 (MAXPATHLEN): Define only if needed.
12219 * process.c (serial_open, serial_configure): Move decls from here ...
12220 * systty.h: ... to here, so that they can be checked.
12222 * fns.c (get_random, seed_random): Move extern decls from here ...
12223 * lisp.h: ... to here, so that they can be checked.
12225 * sysdep.c (reset_io): Now static.
12226 (wait_for_termination_signal): Remove; unused.
12228 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12229 (copy_keymap_item, append_key, push_text_char_description):
12231 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12232 (DENSE_TABLE_SIZE): Remove; unused.
12233 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12234 (describe_map_tree):
12235 Rename locals to avoid shadowing.
12237 * keyboard.c: Declare functions static if they are not used elsewhere.
12238 (echo_char, echo_dash, cmd_error, top_level_2):
12239 (poll_for_input, handle_async_input): Now static.
12240 (read_char, kbd_buffer_get_event, make_lispy_position):
12241 (make_lispy_event, make_lispy_movement, apply_modifiers):
12242 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12243 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12244 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12245 (read_key_sequence, read_char): Mark locals as initialized.
12246 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12248 * keyboard.h (make_ctrl_char): New decl.
12249 (mark_kboards): Move decl here ...
12250 * alloc.c (mark_kboards): ... from here.
12252 * lisp.h (force_auto_save_soon): New decl.
12254 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12255 (DEFINE_DUMMY_FUNCTION): New macro.
12256 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12258 (main): Add casts to avoid warnings
12259 if GCC considers string literals to be constants.
12261 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12263 * dbusbind.c: Pointer signedness fixes.
12264 (xd_signature, xd_append_arg, xd_initialize):
12265 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12266 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12267 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12268 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12270 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12271 if GCC considers string literals to be constants.
12272 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12274 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12276 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12277 (print_preprocess, print_object): New macro to fix last change.
12279 * print.c (print_preprocess): Don't forget font objects.
12281 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12283 * emacs.c (USAGE3): Doc fixes.
12285 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12287 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12290 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12292 * lisp.h (VWindow_system, Qfile_name_history):
12293 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12294 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12295 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12297 * w32select.c: Don't #include "keyboard.h".
12298 (run_protected): Add extern declaration for waiting_for_input.
12300 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12301 * w32console.c (detect_input_pending, read_input_pending)
12302 (encode_terminal_code):
12303 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12304 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12305 (w32_system_caret_y, Qfile_name_history):
12306 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12307 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12308 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12309 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12310 * w32proc.c (Qlocal, report_file_error):
12311 * w32term.c (Vwindow_system, updating_frame):
12312 * w32uniscribe.c (initialized, uniscribe_font_driver):
12313 Remove unneeded extern declarations.
12315 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12317 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12319 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12321 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12322 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12323 These macros can no longer be used for assignment.
12325 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12326 Assign struct members directly, instead of using BUF_BEGV etc.
12327 (record_buffer_markers, fetch_buffer_markers): New functions for
12328 recording and fetching special buffer markers.
12329 (set_buffer_internal_1, set_buffer_temp): Use them.
12331 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12333 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12335 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12336 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12338 * xdisp.c (hscroll_window_tree):
12339 (reconsider_clip_changes): Use PT instead of BUF_PT.
12341 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12343 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12344 $(EMACS_ROOT)/lib/intprops.h.
12346 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12348 Fix more problems found by GCC 4.5.2's static checks.
12350 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12351 to unsigned char * to avoid compiler diagnostic.
12352 (xg_free_frame_widgets): Make it clear that a local variable is
12353 needed only if USE_GTK_TOOLTIP.
12354 (gdk_window_get_screen): Make it clear that this macro is needed
12355 only if USE_GTK_TOOLTIP.
12356 (int_gtk_range_get_value): New function, which avoids a diagnostic
12357 from gcc -Wbad-function-cast.
12358 (xg_set_toolkit_scroll_bar_thumb): Use it.
12359 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12360 diagnostic from gcc -Wbad-function-cast.
12361 (get_utf8_string, xg_get_file_with_chooser):
12362 Rename locals to avoid shadowing.
12363 (create_dialog): Move locals to avoid shadowing.
12365 * xgselect.c (xg_select): Remove unused var.
12367 * image.c (four_corners_best): Mark locals as initialized.
12368 (gif_load): Initialize transparent_p to zero (Bug#8238).
12369 Mark another local as initialized.
12370 (my_png_error, my_error_exit): Mark with NO_RETURN.
12372 * image.c (clear_image_cache): Now static.
12373 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12374 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12375 (x_edge_detection): Remove unnecessary cast that
12376 gcc -Wbad-function-cast diagnoses.
12377 (gif_load): Fix pointer signedness.
12378 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12379 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12381 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12383 Improve quality of tests for time stamp overflow.
12384 For example, without this patch (encode-time 0 0 0 1 1
12385 1152921504606846976) returns the obviously-bogus value (-948597
12386 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12387 reports time overflow. See
12388 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12389 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12390 * editfns.c: Include limits.h and intprops.h.
12391 (TIME_T_MIN, TIME_T_MAX): New macros.
12392 (time_overflow): Move earlier, to before first use.
12393 (hi_time, lo_time): New functions, for an accurate test for
12394 out-of-range times.
12395 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12396 (Fget_internal_run_time): Don't assume time_t fits in int.
12397 (make_time): Use list2 instead of Fcons twice.
12398 (Fdecode_time): More accurate test for out-of-range times.
12399 (check_tm_member): New function.
12400 (Fencode_time): Use it, to test for out-of-range times.
12401 (lisp_time_argument): Don't rely on undefined left-shift and
12402 right-shift behavior when checking for time stamp overflow.
12404 * editfns.c (time_overflow): New function, refactoring common code.
12405 (Fformat_time_string, Fdecode_time, Fencode_time):
12406 (Fcurrent_time_string): Use it.
12408 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12409 * dired.c (make_time): Move to ...
12410 * editfns.c (make_time): ... here.
12411 * systime.h: Note the move.
12413 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12415 * fringe.c (update_window_fringes): Remove unused variables.
12417 * unexmacosx.c (copy_data_segment): Also copy __got section.
12420 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12422 * termcap.c [MSDOS]: Include "msdos.h".
12423 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12424 Constify `char *' arguments and their references according to
12425 prototypes in tparam.h.
12427 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12429 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12430 Adapt all references accordingly.
12432 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12434 2011-03-11 Tom Tromey <tromey@redhat.com>
12436 * buffer.c (syms_of_buffer): Remove obsolete comment.
12438 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12440 * termhooks.h (encode_terminal_code): Declare prototype.
12442 * msdos.c (encode_terminal_code): Don't declare prototype.
12444 * term.c (encode_terminal_code): Now external again, used by
12445 w32console.c and msdos.c.
12447 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12448 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12450 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12452 Fix some minor problems found by GCC 4.5.2's static checks.
12454 * fringe.c (update_window_fringes): Mark locals as initialized
12456 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12458 * alloc.c (mark_fringe_data): Move decl from here ...
12459 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12460 to check its interface.
12461 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12463 * fontset.c (free_realized_fontset): Now static.
12464 (Fset_fontset_font): Rename local to avoid shadowing.
12465 (fontset_font): Mark local as initialized.
12466 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12468 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12470 * xselect.c (x_disown_buffer_selections): Remove; not used.
12471 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12472 (x_own_selection, Fx_disown_selection_internal): Rename locals
12473 to avoid shadowing.
12474 (x_handle_dnd_message): Remove local to avoid shadowing.
12476 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12477 so that the caller can use some name other than gcpro1.
12478 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12479 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12480 (Fx_backspace_delete_keys_p):
12481 Use them to avoid shadowing, and rename vars to avoid shadowing.
12482 (x_decode_color, x_set_name, x_window): Now static.
12483 (Fx_create_frame): Add braces to silence GCC warning.
12484 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12485 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12486 Remove unused locals.
12487 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12488 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12489 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12492 * xterm.h (x_mouse_leave): New decl.
12494 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12495 Remove unused functions.
12496 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12497 (x_calc_absolute_position): Now static.
12498 (XTread_socket): Don't define label "out" unless it's used.
12499 Don't declare local "event" unless it's used.
12500 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12501 unless they are used.
12502 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12503 (x_fatal_error_signal): Remove; not used.
12504 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12505 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12506 (x_error_catcher, x_connection_closed, x_error_handler):
12507 (x_error_quitter, xembed_send_message, x_iconify_frame):
12508 (my_log_handler): Rename locals to avoid shadowing.
12509 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12510 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12512 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12513 Rename or move locals to avoid shadowing.
12514 (tty_defined_color, merge_face_heights): Now static.
12515 (free_realized_faces_for_fontset): Remove; not used.
12516 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12517 does not deduce is never used uninitialized.
12518 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12519 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12521 * terminal.c (store_terminal_param): Now static.
12523 * xmenu.c (menu_highlight_callback): Now static.
12524 (set_frame_menubar): Remove unused local.
12525 (xmenu_show): Rename parameter to avoid shadowing.
12526 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12527 since they might point to immutable storage.
12528 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12529 since it's unused otherwise.
12531 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12532 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12533 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12534 avoids a gcc -Wuninitialized diagnostic.
12535 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12536 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12537 does not deduce are never used uninitialized.
12539 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12541 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12542 * window.c (window_loop, size_window):
12543 (run_window_configuration_change_hook, enlarge_window): Likewise.
12545 * window.c (display_buffer): Now static.
12546 (size_window): Mark variables that gcc -Wuninitialized
12547 does not deduce are never used uninitialized.
12548 * window.h (check_all_windows): New decl, to forestall
12549 gcc -Wmissing-prototypes diagnostic.
12550 * dispextern.h (bidi_dump_cached_states): Likewise.
12552 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12554 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12555 Include <limits.h>.
12556 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12557 and to avoid gcc -Wuninitialized warning.
12558 (load_charset_map): Mark variables that gcc -Wuninitialized
12559 does not deduce are never used uninitialized.
12560 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12562 * coding.c (coding_set_source, coding_set_destination):
12563 Use "else { /* comment */ }" rather than "else /* comment */;"
12564 for clarity, and to avoid gcc -Wempty-body warning.
12565 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12566 a block, when the outer 'i' will do.
12567 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12568 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12569 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12570 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12571 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12572 Rename locals to avoid shadowing.
12573 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12574 * coding.c (emacs_mule_char, encode_invocation_designation):
12575 Now static, since they're not used elsewhere.
12576 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12577 (decode_coding_object, encode_coding_object, detect_coding_system):
12578 (decode_coding_emacs_mule): Mark variables that gcc
12579 -Wuninitialized does not deduce are never used uninitialized.
12580 (detect_coding_iso_2022): Initialize a local variable that might
12581 be used uninitialized. Leave a FIXME because it's not clear that
12582 this initialization is needed. (Bug#8211)
12583 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12584 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12585 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12586 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12587 Remove unused macros.
12589 * category.c (hash_get_category_set): Remove unused local var.
12590 (copy_category_table): Now static, since it's not used elsewhere.
12591 * character.c (string_count_byte8): Likewise.
12593 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12594 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12596 * chartab.c (copy_sub_char_table): Now static, since it's not used
12598 (sub_char_table_ref_and_range, char_table_ref_and_range):
12599 Rename locals to avoid shadowing.
12600 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12602 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12603 (BIDI_BOB): Remove unused macro.
12605 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12606 deduce are never used uninitialized.
12607 * term.c (encode_terminal_code): Likewise.
12609 * term.c (encode_terminal_code): Now static. Remove unused local.
12611 * tparam.h: New file.
12612 * term.c, tparam.h: Include it.
12613 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12614 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12615 Move these decls to tparam.h, and make them agree with what
12616 is actually in tparam.c. The previous trick of using incompatible
12617 decls in different modules does not conform to the C standard.
12618 All callers of tparam changed to use tparam's actual API.
12619 * tparam.c (tparam1, tparam, tgoto):
12620 Use const pointers where appropriate.
12622 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12623 * cm.h (struct cm): Likewise.
12624 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12625 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12626 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12627 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12628 (turn_on_face, init_tty): Likewise.
12629 * termchar.h (struct tty_display_info): Likewise.
12631 * term.c (term_mouse_position): Rename local to avoid shadowing.
12633 * alloc.c (mark_ttys): Move decl from here ...
12634 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12636 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12638 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12640 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12642 * search.c (compile_pattern_1): Remove argument regp, unused since
12643 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12644 (compile_pattern): Don't pass it.
12646 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12648 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12649 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12651 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12653 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12655 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12656 gdk_window_get_screen, gdk_window_get_geometry,
12657 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12658 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12659 (xg_get_pixbuf_from_pixmap): New function.
12660 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12661 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12662 Call xg_get_pixbuf_from_pixmap instead of
12663 gdk_pixbuf_get_from_drawable.
12664 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12665 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12666 (xg_check_special_colors): Use GtkStyleContext and its functions
12668 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12669 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12670 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12671 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12672 Call gtk_widget_get_preferred_size.
12673 (xg_frame_resized): gdk_window_get_geometry only takes 5
12675 (xg_win_to_widget, xg_event_is_for_menubar):
12676 Call gdk_x11_window_lookup_for_display.
12677 (xg_set_widget_bg): New function.
12678 (delete_cb): New function.
12679 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12680 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12681 (xg_set_background_color): Call xg_set_widget_bg.
12682 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12683 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12684 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12685 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12687 (update_frame_tool_bar): Call gtk_widget_hide.
12688 (xg_initialize): Use GDK_KEY_g.
12690 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12692 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12694 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12695 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12696 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12698 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12700 * w32xfns.c (select_palette): Check success of RealizePalette against
12701 GDI_ERROR, not zero.
12703 See ChangeLog.11 for earlier changes.
12705 ;; Local Variables:
12709 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12711 This file is part of GNU Emacs.
12713 GNU Emacs is free software: you can redistribute it and/or modify
12714 it under the terms of the GNU General Public License as published by
12715 the Free Software Foundation, either version 3 of the License, or
12716 (at your option) any later version.
12718 GNU Emacs is distributed in the hope that it will be useful,
12719 but WITHOUT ANY WARRANTY; without even the implied warranty of
12720 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12721 GNU General Public License for more details.
12723 You should have received a copy of the GNU General Public License
12724 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.