1 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3 Integer overflow and signedness fixes.
5 * fileio.c: Don't assume EMACS_INT fits in off_t.
6 (emacs_lseek): New static function.
7 (Finsert_file_contents, Fwrite_region): Use it.
8 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
12 * fns.c: Don't overflow int when computing a list length.
13 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
14 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
15 truncation on 64-bit hosts. Check for QUIT every
16 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
17 faster and is responsive enough.
18 (Flength): Report an error instead of overflowing an integer.
19 (Fsafe_length): Return a float if the value is not representable
20 as a fixnum. This shouldn't happen except in contrived situations.
21 (Fnthcdr, Fsort): Don't assume list length fits in int.
22 (Fcopy_sequence): Don't assume vector length fits in int.
24 * alloc.c: Check that resized vectors' lengths fit in fixnums.
25 (header_size, word_size): New constants.
26 (allocate_vectorlike): Don't check size overflow here.
27 (allocate_vector): Check it here instead, since this is the only
28 caller of allocate_vectorlike that could cause overflow.
29 Check that the new vector's length is representable as a fixnum.
31 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
32 The previous code was bogus. For example, next_almost_prime (32)
33 returned 39, which is undesirable as it is a multiple of 3; and
34 next_almost_prime (24) returned 25, which is a multiple of 5 so
35 why was the code bothering to check for multiples of 7?
37 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
39 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
41 Variadic C functions now count arguments with ptrdiff_t.
42 This partly undoes my 2011-03-30 change, which replaced int with size_t.
43 Back then I didn't know that the Emacs coding style prefers signed int.
44 Also, in the meantime I found a few more instances where arguments
45 were being counted with int, which may truncate counts on 64-bit
46 machines, or EMACS_INT, which may be unnecessarily wide.
47 * lisp.h (struct Lisp_Subr.function.aMANY)
48 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
49 Arg counts are now ptrdiff_t, not size_t.
50 All variadic functions and their callers changed accordingly.
51 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
52 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
53 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
54 * callint.c (Fcall_interactively): Check arg count for overflow,
55 to avoid potential buffer overrun. Use signed char, not 'int',
56 for 'varies' array, so that we needn't bother to check its size
57 calculation for overflow.
58 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
59 * eval.c (apply_lambda):
60 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
61 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
62 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
64 * callint.c (Fcall_interactively): Don't use index var as event count.
66 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
67 * mem-limits.h (SIZE): Remove; no longer used.
69 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
71 Remove unnecessary casts.
72 * xterm.c (x_term_init):
73 * xfns.c (x_set_border_pixel):
74 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
75 These aren't needed now that we assume ANSI C.
77 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
78 It's more likely to cause problems (due to unsigned overflow)
81 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
83 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
85 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
87 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
89 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
91 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
93 GLYPH_CODE_FACE returns EMACS_INT, not int.
94 * dispextern.h (merge_faces):
95 * xfaces.c (merge_faces):
96 * xdisp.c (get_next_display_element, next_element_from_display_vector):
97 Don't assume EMACS_INT fits in int.
99 * character.h (CHAR_VALID_P): Remove unused parameter.
100 * fontset.c, lisp.h, xdisp.c: All uses changed.
102 * editfns.c (Ftranslate_region_internal): Omit redundant test.
104 * fns.c (concat): Minor tuning based on overflow analysis.
105 This doesn't fix any bugs. Use int to hold character, instead
106 of constantly refetching from Emacs object. Use XFASTINT, not
107 XINT, for value known to be a character. Don't bother comparing
108 a single byte to 0400, as it's always less.
110 * floatfns.c (Fexpt):
111 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
113 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
116 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
118 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
119 Without this fix, on a 64-bit host (aset S 0 4294967386) would
120 incorrectly succeed when S was a string, because 4294967386 was
121 truncated before it was used.
123 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
124 Otherwise, an out-of-range integer could cause undefined behavior
127 * composite.c: Use int, not EMACS_INT, for characters.
128 (fill_gstring_body, composition_compute_stop_pos): Use int, not
129 EMACS_INT, for values that are known to be in character range.
130 This doesn't fix any bugs but is the usual style inside Emacs and
131 may generate better code on 32-bit machines.
133 Make sure a 64-bit char is never passed to ENCODE_CHAR.
134 This is for reasons similar to the recent CHAR_STRING fix.
135 * charset.c (Fencode_char): Check that character arg is actually
136 a character. Pass an int to ENCODE_CHAR.
137 * charset.h (ENCODE_CHAR): Verify that the character argument is no
138 wider than 'int', as a compile-time check to prevent future regressions
141 * character.c (char_string): Remove unnecessary casts.
143 Make sure a 64-bit char is never passed to CHAR_STRING.
144 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
145 by silently ignoring the top 32 bits, allowing some values
146 that were far too large to be valid characters.
147 * character.h: Include <verify.h>.
148 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
149 arguments are no wider than unsigned, as a compile-time check
150 to prevent future regressions in this area.
152 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
153 (Fsubst_char_in_region):
155 * xdisp.c (decode_mode_spec_coding):
156 Adjust to CHAR_STRING's new requirement.
157 * editfns.c (Finsert_char, Fsubst_char_in_region):
158 * fns.c (concat): Check that character args are actually
159 characters. Without this test, these functions did the wrong
160 thing with wildly out-of-range values on 64-bit hosts.
162 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
163 These casts should not be needed on 32-bit hosts, either.
164 * keyboard.c (read_char):
165 * lread.c (Fload): Remove casts to unsigned.
167 * lisp.h (UNSIGNED_CMP): New macro.
168 This fixes comparison bugs on 64-bit hosts.
169 (ASCII_CHAR_P): Use it.
170 * casefiddle.c (casify_object):
171 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
172 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
173 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
174 * dispextern.h (FACE_FROM_ID):
175 * keyboard.c (read_char): Use UNSIGNED_CMP.
177 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
178 not to EMACS_INT, to avoid GCC warning.
180 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
182 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
183 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
184 isn't needed on 32-bit machines.
186 * buffer.c (Fgenerate_new_buffer_name):
187 Use EMACS_INT for count, not int.
188 (advance_to_char_boundary): Return EMACS_INT, not int.
190 * data.c (Qcompiled_function): Now static.
192 * window.c (window_body_lines): Now static.
194 * image.c (gif_load): Rename local to avoid shadowing.
196 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
197 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
198 * alloc.c (make_save_value): Integer argument is now of type
200 (mark_object): Use ptrdiff_t, not int.
201 * lisp.h (pD): New macro.
202 * print.c (print_object): Use it.
204 * alloc.c: Use EMACS_INT, not int, to count objects.
205 (total_conses, total_markers, total_symbols, total_vector_size)
206 (total_free_conses, total_free_markers, total_free_symbols)
207 (total_free_floats, total_floats, total_free_intervals)
208 (total_intervals, total_strings, total_free_strings):
209 Now EMACS_INT, not int. All uses changed.
210 (Fgarbage_collect): Compute overall total using a double, so that
211 integer overflow is less likely to be a problem. Check for overflow
212 when converting back to an integer.
213 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
214 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
215 These were 'int' variables that could overflow on 64-bit hosts;
216 they were never used, so remove them instead of repairing them.
217 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
218 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
219 Previously, this ceilinged at INT_MAX, but that doesn't work on
221 (allocate_pseudovector): Don't use EMACS_INT when int would do.
223 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
224 (allocate_vectorlike): Check for ptrdiff_t overflow.
225 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
226 when a (possibly-narrower) signed value would do just as well.
227 We prefer using signed arithmetic, to avoid comparison confusion.
229 * alloc.c: Catch some string size overflows that we were missing.
230 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
231 for convenience in STRING_BYTES_MAX.
232 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
233 The definition here is exact; the one in lisp.h was approximate.
234 (allocate_string_data): Check for string overflow. This catches
235 some instances we weren't catching before. Also, it catches
236 size_t overflow on (unusual) hosts where SIZE_MAX <= min
237 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
238 and ptrdiff_t and EMACS_INT are both 64 bits.
240 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
241 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
242 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
244 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
246 * alloc.c (Fmake_string): Check for out-of-range init.
248 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
250 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
252 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
254 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
255 xg_get_default_scrollbar_width.
257 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
258 (int_gtk_range_get_value): Move to the scroll bar part of the file.
259 (style_changed_cb): Call update_theme_scrollbar_width and call
260 x_set_scroll_bar_default_width and xg_frame_set_char_size for
261 all frames (Bug#8505).
262 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
263 Call gtk_window_set_resizable if HAVE_GTK3.
264 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
265 and height if HAVE_GTK3 (Bug#8505).
266 (scroll_bar_width_for_theme): New variable.
267 (update_theme_scrollbar_width): New function.
268 (xg_get_default_scrollbar_width): Move code to
269 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
270 (xg_initialize): Call update_theme_scrollbar_width.
272 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
274 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
276 2011-06-12 Martin Rudalics <rudalics@gmx.at>
278 * frame.c (make_frame): Call other_buffer_safely instead of
281 * window.c (temp_output_buffer_show): Call display_buffer with
282 second argument Vtemp_buffer_show_specifiers and reset latter
283 immediately after the call.
284 (Vtemp_buffer_show_specifiers): New variable.
285 (auto_window_vscroll_p, next_screen_context_lines)
286 (Vscroll_preserve_screen_position): Remove leading asterisks from
289 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
291 Fix minor problems found by GCC 4.6.0 static checking.
292 * buffer.c (Qclone_number): Remove for now, as it's unused.
293 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
294 (record_buffer): Remove unused local.
295 * frame.c (other_visible_frames, frame_buffer_list): Now static.
296 (set_frame_buffer_list): Remove; unused.
297 * frame.h (other_visible_frames): Remove decl.
298 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
299 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
300 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
302 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
303 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
304 Define only if HAVE_GPM.
305 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
306 (update_hints_inhibit): Remove; never set. All uses removed.
307 * widgetprv.h (emacsFrameClassRec): Remove decl.
308 * window.c (delete_deletable_window): Now returns void, since it
309 wasn't returning anything.
310 (compare_window_configurations): Remove unused locals.
311 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
312 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
313 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
314 the same widths as pointers. This follows up on the 2011-05-06 patch.
315 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
317 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
319 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
321 * makefile.w32-in: Update dependencies.
322 (LISP_H): Add lib/intprops.h.
324 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
326 * image.c (gif_load): Add animation frame delay to the metadata.
327 (syms_of_image): Use DEFSYM. New symbol `delay'.
329 2011-06-11 Martin Rudalics <rudalics@gmx.at>
331 * window.c (delete_deletable_window): Re-add.
332 (Fset_window_configuration): Rewrite to handle dead buffers and
333 consequently deletable windows.
334 (window_tree, Fwindow_tree): Remove. Supply functionality in
336 (compare_window_configurations): Simplify code.
338 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
340 * image.c (imagemagick_load_image): Fix type mismatch.
341 (Fimagemagick_types): Likewise.
343 * window.h (replace_buffer_in_windows): Declare.
345 2011-06-11 Martin Rudalics <rudalics@gmx.at>
347 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
348 Qclone_number. Remove external declaration of Qdelete_window.
349 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
351 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
352 Qbuffer_list_update_hook if allowed.
353 (Fother_buffer): Rewrite doc-string. Major rewrite for new
354 buffer list implementation.
355 (other_buffer_safely): New function.
356 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
357 calls to replace_buffer_in_windows and
358 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
360 (record_buffer): Inhibit quitting and rewrite using quittable
361 functions. Run Qbuffer_list_update_hook if allowed.
362 (Frecord_buffer, Funrecord_buffer): New functions.
363 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
364 switch-to-buffer to window.el.
365 (bury-buffer): Move to window.el.
366 (Vbuffer_list_update_hook): New variable.
368 * lisp.h (other_buffer_safely): Add prototype in buffer.c
371 * window.h (resize_frame_windows): Move up in code.
372 (Fwindow_frame): Remove EXFUN.
373 (replace_buffer_in_all_windows): Remove prototype.
374 (replace_buffer_in_windows_safely): Add prototype.
376 * window.c: Declare Qdelete_window static again. Move down
377 declaration of select_count.
378 (Fnext_window, Fprevious_window): Rewrite doc-strings.
379 (Fother_window): Move to window.el.
380 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
381 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
382 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
384 (replace_buffer_in_windows): Implement by calling
385 Qreplace_buffer_in_windows.
386 (replace_buffer_in_all_windows): Remove with some functionality
387 moved into replace_buffer_in_windows_safely.
388 (replace_buffer_in_windows_safely): New function.
389 (select_window_norecord, select_frame_norecord): Move in front
390 of run_window_configuration_change_hook. Remove now obsolete
392 (Fset_window_buffer): Rewrite doc-string. Call
393 Qrecord_window_buffer.
394 (keys_of_window): Move binding for other-window to window.el.
396 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
398 * dispextern.h (struct image): Replace data member, whose int_val
399 and ptr_val fields were not used by anything, with a single
402 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
403 (gif_clear_image, gif_load, imagemagick_load_image)
404 (gs_clear_image, gs_load): Callers changed.
406 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
408 * buffer.h: Include <time.h>, for time_t.
409 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
411 Fix minor problems found by static checking.
413 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
415 Make identifiers static if they are not used in other modules.
416 * data.c (Qcompiled_function, Qframe, Qvector):
417 * image.c (QimageMagick, Qsvg):
418 * minibuf.c (Qmetadata):
419 * window.c (resize_window_check, resize_root_window): Now static.
420 * window.h (resize_window_check, resize_root_window): Remove decls.
422 * window.c (window_deletion_count, delete_deletable_window):
424 (window_body_lines): Now static.
425 (Fdelete_other_windows_internal): Mark vars as initialized.
426 Make sure 'resize_failed' is initialized.
427 (run_window_configuration_change_hook): Rename local to avoid shadowing.
428 (resize_window_apply): Remove unused local.
429 * window.h (delete_deletable_window): Remove decl.
431 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
432 (imagemagick_load_image): Fix pointer signedness problem by changing
433 last arg from unsigned char * to char *. All uses changed.
434 Also, fix a local for similar reasons.
435 Remove unused locals. Remove locals to avoid shadowing.
436 (fn_rsvg_handle_free): Remove; unused.
437 (svg_load, svg_load_image): Fix pointer signedness problem.
438 (imagemagick_load_image): Don't use garbage pointer image_wand.
440 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
442 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
444 * image.c (gif_load): Fix omitted cast error introduced by
447 2011-06-10 Martin Rudalics <rudalics@gmx.at>
449 * window.h (resize_proportionally, orig_total_lines)
450 (orig_top_line): Remove from window structure.
451 (set_window_height, set_window_width, change_window_heights)
452 (Fdelete_window): Remove prototypes.
453 (resize_frame_windows): Remove duplicate declaration.
455 2011-06-10 Eli Zaretskii <eliz@gnu.org>
457 * window.h (resize_frame_windows, resize_window_check)
458 (delete_deletable_window, resize_root_window)
459 (resize_frame_windows): Declare prototypes.
461 * window.c (resize_window_apply): Make definition be "static" to
464 2011-06-10 Martin Rudalics <rudalics@gmx.at>
466 * window.c: Remove declarations of Qwindow_size_fixed,
467 window_min_size_1, window_min_size_2, window_min_size,
468 size_window, window_fixed_size_p, enlarge_window, delete_window.
469 Remove static from declaration of Qdelete_window, it's
470 temporarily needed by Fbury_buffer.
471 (replace_window): Don't assign orig_top_line and
473 (Fdelete_window, delete_window): Remove. Window deletion is
474 handled by window.el.
475 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
476 Fdelete_window calls with calls to Qdelete_window.
477 (Fdelete_other_windows): Remove. Deleting other windows is
478 handled by window.el.
479 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
480 handled in window.el.
481 (window_min_size_2, window_min_size_1, window_min_size): Remove.
482 Window minimum sizes are handled in window.el.
483 (shrink_windows, size_window, set_window_height)
484 (set_window_width, change_window_heights, window_height)
485 (window_width, CURBEG, CURSIZE, enlarge_window)
486 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
487 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
488 handled in window.el.
489 (make_dummy_parent): Rename to make_parent_window and give it a
490 second argument horflag.
491 (make_window): Don't set resize_proportionally any more.
492 (Fsplit_window): Remove. Windows are split in window.el.
493 (save_restore_action, save_restore_orig_size)
494 (shrink_window_lowest_first, save_restore_orig_size): Remove.
495 Resize mini windows in window.el.
496 (grow_mini_window, shrink_mini_window): Implement by calling
497 Qresize_root_window_vertically, resize_window_check and
499 (saved_window, Fset_window_configuration, save_window_save): Do
500 not handle orig_top_line, orig_total_lines, and
501 resize_proportionally.
502 (window_min_height, window_min_width): Move to window.el.
503 (keys_of_window): Move bindings for delete-other-windows,
504 split-window, delete-window and enlarge-window to window.el.
506 * buffer.c: Temporarily extern Qdelete_window.
507 (Fbury_buffer): Temporarily call Qdelete_window instead of
508 Fdelete_window (Fbury_buffer will move to window.el soon).
510 * frame.c (set_menu_bar_lines_1): Remove code handling
511 orig_top_line and orig_total_lines.
513 * dispnew.c (adjust_frame_glyphs_initially): Don't use
514 set_window_height but set heights directly.
515 (change_frame_size_1): Use resize_frame_windows.
517 * xdisp.c (init_xdisp): Don't use set_window_height but set
520 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
521 resize_frame_windows instead of change_window_heights and run
522 run_window_configuration_change_hook.
524 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
525 instead of change_window_heights and run
526 run_window_configuration_change_hook.
528 2011-06-09 Martin Rudalics <rudalics@gmx.at>
530 * window.c (replace_window): Rename second argument REPLACEMENT to
531 NEW. New third argument SETFLAG. Rewrite.
532 (delete_window, make_dummy_parent): Call replace_window with
534 (window_list_1): Move down in code.
535 (run_window_configuration_change_hook): Move set_buffer part
536 before select_frame_norecord part in order to unwind correctly.
537 Rename count1 to count.
538 (recombine_windows, delete_deletable_window, resize_root_window)
539 (Fdelete_other_windows_internal)
540 (Frun_window_configuration_change_hook, make_parent_window)
541 (resize_window_check, resize_window_apply, Fresize_window_apply)
542 (resize_frame_windows, Fsplit_window_internal)
543 (Fdelete_window_internal, Fresize_mini_window_internal): New
545 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
547 2011-06-08 Martin Rudalics <rudalics@gmx.at>
549 * window.h (window): Add some new members to window structure -
550 normal_lines, normal_cols, new_total, new_normal, clone_number,
551 splits, nest, prev_buffers, next_buffers.
552 (WINDOW_TOTAL_SIZE): Move here from window.c.
553 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
555 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
557 (make_dummy_parent): Set new members of windows structure.
558 (make_window): Move down in code. Handle new members of window
560 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
561 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
562 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
563 (Fset_window_prev_buffers, Fwindow_next_buffers)
564 (Fset_window_next_buffers, Fset_window_clone_number): New
566 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
567 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
569 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
570 Argument WINDOW can be now internal window too.
571 (Fwindow_use_time): Move up in code.
572 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
574 (Fset_window_configuration, saved_window)
575 (Fcurrent_window_configuration, save_window_save): Handle new
576 members of window structure.
577 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
578 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
579 (syms_of_window): New Lisp objects Qrecord_window_buffer,
580 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
581 Qget_mru_window, Qresize_root_window,
582 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
583 Qauto_buffer_name; staticpro them.
585 2011-06-07 Martin Rudalics <rudalics@gmx.at>
587 * window.c (Fwindow_total_size, Fwindow_left_column)
588 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
589 (Fwindow_list_1): New functions.
590 (window_box_text_cols): Replace with window_body_cols.
591 (Fwindow_width, Fscroll_left, Fscroll_right): Use
592 window_body_cols instead of window_box_text_cols.
593 (delete_window, Fset_window_configuration): Call
594 delete_all_subwindows with window as argument.
595 (delete_all_subwindows): Take a window as argument and not a
597 (window_loop): Remove handling of GET_LRU_WINDOW and
599 (Fget_lru_window, Fget_largest_window): Move to window.el.
601 * window.h: Extern window_body_cols instead of
602 window_box_text_cols. delete_all_subwindows now takes a
603 Lisp_Object as argument.
605 * indent.c (compute_motion, Fcompute_motion): Use
606 window_body_cols instead of window_box_text_cols.
608 * frame.c (delete_frame): Call delete_all_subwindows with root
611 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
613 * fns.c (Fputhash): Document return value.
615 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
617 * image.c (gif_load): Implement gif89a spec "no disposal" method.
619 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
621 Cons<->int and similar integer overflow fixes (Bug#8794).
623 Check for overflow when converting integer to cons and back.
624 * charset.c (Fdefine_charset_internal, Fdecode_char):
625 Use cons_to_unsigned to catch overflow.
626 (Fencode_char): Use INTEGER_TO_CONS.
627 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
628 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
629 * data.c (long_to_cons, cons_to_long): Remove.
630 (cons_to_unsigned, cons_to_signed): New functions.
631 These signal an error for invalid or out-of-range values.
632 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
633 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
634 * font.c (Ffont_variation_glyphs):
635 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
636 * lisp.h: Include <intprops.h>.
637 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
638 (cons_to_signed, cons_to_unsigned): New decls.
639 (long_to_cons, cons_to_long): Remove decls.
640 * undo.c (record_first_change): Use INTEGER_TO_CONS.
641 (Fprimitive_undo): Use CONS_TO_INTEGER.
642 * xfns.c (Fx_window_property): Likewise.
643 * xselect.c: Include <limits.h>.
644 (x_own_selection, selection_data_to_lisp_data):
646 (x_handle_selection_request, x_handle_selection_clear)
647 (x_get_foreign_selection, Fx_disown_selection_internal)
648 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
649 (lisp_data_to_selection_data): Use cons_to_unsigned.
650 (x_fill_property_data): Use cons_to_signed.
651 Report values out of range.
653 Check for buffer and string overflow more precisely.
654 * buffer.h (BUF_BYTES_MAX): New macro.
655 * lisp.h (STRING_BYTES_MAX): New macro.
656 * alloc.c (Fmake_string):
657 * character.c (string_escape_byte8):
658 * coding.c (coding_alloc_by_realloc):
660 * editfns.c (Fformat):
662 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
663 since they may not be the same number.
664 * editfns.c (Finsert_char):
665 * fileio.c (Finsert_file_contents):
666 Likewise for BUF_BYTES_MAX.
668 * image.c: Use ptrdiff_t, not int, for sizes.
669 (slurp_file): Switch from int to ptrdiff_t.
671 (slurp_file): Check that file size fits in both size_t (for
672 malloc) and ptrdiff_t (for sanity and safety).
674 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
675 if b->modtime has its maximal value.
677 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
679 Don't assume time_t can fit into int.
680 * buffer.h (struct buffer.modtime): Now time_t, not int.
681 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
682 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
684 Minor fixes for signed vs unsigned integers.
685 * character.h (MAYBE_UNIFY_CHAR):
686 * charset.c (maybe_unify_char):
687 * keyboard.c (read_char, reorder_modifiers):
688 XINT -> XFASTINT, since the integer must be nonnegative.
689 * ftfont.c (ftfont_spec_pattern):
690 * keymap.c (access_keymap, silly_event_symbol_error):
691 XUINT -> XFASTINT, since the integer must be nonnegative.
692 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
693 since it makes no difference and we prefer signed.
694 * keyboard.c (record_char): Use XUINT when all the neighbors do.
695 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
698 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
700 * window.h (Fwindow_frame): Declare.
702 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
704 * alloc.c: Simplify handling of large-request failures (Bug#8800).
705 (SPARE_MEMORY): Always define.
706 (LARGE_REQUEST): Remove.
707 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
709 2011-06-06 Martin Rudalics <rudalics@gmx.at>
711 * lisp.h: Move EXFUNS for Fframe_root_window,
712 Fframe_first_window and Fset_frame_selected_window to window.h.
714 * window.h: Move EXFUNS for Fframe_root_window,
715 Fframe_first_window and Fset_frame_selected_window here from
718 * frame.c (Fwindow_frame, Fframe_first_window)
719 (Fframe_root_window, Fframe_selected_window)
720 (Fset_frame_selected_window): Move to window.c.
721 (Factive_minibuffer_window): Move to minibuf.c.
722 (Fother_visible_frames_p): New function.
724 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
726 * window.c (decode_window, decode_any_window): Move up in code.
727 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
728 (inhibit_frame_unsplittable): Remove unused variable.
729 (Fwindow_buffer): Move up and rewrite doc-string.
730 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
731 (Fwindow_prev): New functions.
732 (Fwindow_frame): Move here from frame.c. Accept any window as
734 (Fframe_root_window, Fframe_first_window)
735 (Fframe_selected_window): Move here from frame.c. Accept frame
736 or arbitrary window as argument. Update doc-strings.
737 (Fminibuffer_window): Move up in code.
738 (Fwindow_minibuffer_p): Move up in code and simplify.
739 (Fset_frame_selected_window): Move here from frame.c.
741 (Fselected_window, select_window, Fselect_window): Move up in
742 code. Minor doc-string fixes.
744 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
746 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
747 Do not assume that spare memory exists; that assumption is valid
748 only if SYSTEM_MALLOC.
749 (LARGE_REQUEST): New macro, so that the issue of large requests
750 is separated from the issue of spare memory.
752 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
754 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
757 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
759 * xfns.c (x_set_scroll_bar_default_width): Move declarations
762 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
764 * gtkutil.c (xg_get_default_scrollbar_width): New function.
766 * gtkutil.h: Declare xg_get_default_scrollbar_width.
768 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
769 min width by calling x_set_scroll_bar_default_width (Bug#8505).
771 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
773 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
775 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
777 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
778 (x_clipboard_manager_save): Add return value.
779 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
781 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
782 Obey Vx_select_enable_clipboard_manager. Catch errors in
783 x_clipboard_manager_save (Bug#8779).
784 (Vx_select_enable_clipboard_manager): New variable.
785 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
787 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
789 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
791 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
793 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
794 in the current matrix if keep_current_p is non-zero.
796 2011-06-04 Eli Zaretskii <eliz@gnu.org>
798 * bidi.c (bidi_level_of_next_char): Fix last change.
800 2011-06-03 Eli Zaretskii <eliz@gnu.org>
802 Support bidi reordering of text covered by display properties.
804 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
805 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
806 (bidi_cache_search, bidi_cache_iterator_state)
807 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
808 (bidi_level_of_next_char, bidi_move_to_visually_next):
809 Support character positions inside a run of characters covered by a
811 (bidi_paragraph_init, bidi_resolve_explicit_1)
812 (bidi_level_of_next_char): Call bidi_fetch_char and
813 bidi_fetch_char_advance instead of FETCH_CHAR and
815 (bidi_init_it): Initialize new members.
816 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
818 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
819 instead of using explicit *_CHAR codes.
820 (bidi_resolve_explicit, bidi_resolve_weak):
821 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
822 bidirectional text is supported only in multibyte buffers.
823 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
824 it to initialize the frame_window_p member of struct bidi_it.
825 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
826 (bidi_resolve_explicit, bidi_resolve_weak)
827 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
828 bidi_it->nchars is non-positive.
829 (bidi_level_of_next_char): Don't try to lookup the cache for the
830 next/previous character if nothing is cached there yet, or if we
831 were just reseat()'ed to a new position.
833 * xdisp.c (set_cursor_from_row): Set start and stop points
834 according to the row's direction when priming the loop that looks
835 for the glyph on which to display cursor.
836 (single_display_spec_intangible_p): Function deleted.
837 (display_prop_intangible_p): Reimplement to call
838 handle_display_spec instead of single_display_spec_intangible_p.
839 Accept 3 additional arguments needed by handle_display_spec.
840 This fixes incorrect cursor motion across display property with complex
841 values: lists, `(when COND...)' forms, etc.
842 (single_display_spec_string_p): Support property values that are
843 lists with the argument STRING its top-level element.
844 (display_prop_string_p): Fix the condition for processing a
845 property that is a list to be consistent with handle_display_spec.
846 (handle_display_spec): New function, refactored from the
847 last portion of handle_display_prop.
848 (compute_display_string_pos): Accept additional argument
849 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
850 value of a `display' property is a "replacing spec".
851 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
852 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
853 the display property, but just return a value indicating whether
854 the display property will replace the characters it covers.
855 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
856 frame_window_p members of struct bidi_it.
857 (compute_display_string_pos, compute_display_string_end):
859 (push_it): Accept second argument POSITION, where pop_it should
860 jump to continue iteration.
861 (reseat_1): Initialize bidi_it.disp_pos.
863 * keyboard.c (adjust_point_for_property): Adjust the call to
864 display_prop_intangible_p to its new signature.
866 * dispextern.h (struct bidi_it): New member frame_window_p.
867 (bidi_init_it): Update prototypes.
868 (display_prop_intangible_p): Update prototype.
869 (compute_display_string_pos, compute_display_string_end):
871 (struct bidi_it): New members nchars and disp_pos. ch_len is now
874 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
876 Malloc failure behavior now depends on size of allocation.
877 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
878 * lisp.h: Change signatures accordingly.
879 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
880 All callers changed. (Bug#8762)
882 * gnutls.c: Use Emacs's memory allocators.
883 Without this change, the gnutls library would invoke malloc etc.
884 directly, which causes problems on non-SYNC_INPUT hosts, and which
885 runs afoul of improving memory_full behavior. (Bug#8761)
886 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
887 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
888 xfree instead of the default malloc, realloc, free.
889 (Fgnutls_boot): No need to check for memory allocation failure,
890 since xmalloc does that for us.
892 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
893 * category.c (hash_get_category_set):
894 * ccl.c (ccl_driver):
895 * charset.c (Fdefine_charset_internal):
896 * charset.h (struct charset.hash_index):
897 * composite.c (get_composition_id, gstring_lookup_cache)
898 (composition_gstring_put_cache):
899 * composite.h (struct composition.hash_index):
900 * dispextern.h (struct image.hash):
901 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
902 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
903 (hashfn_equal, hashfn_user_defined, make_hash_table)
904 (maybe_resize_hash_table, hash_lookup, hash_put)
905 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
906 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
907 (Fsxhash, Fgethash, Fputhash, Fmaphash):
908 * image.c (make_image, search_image_cache, lookup_image)
909 (xpm_put_color_table_h):
910 * lisp.h (struct Lisp_Hash_Table):
911 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
912 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
913 for hashes and hash indexes, instead of 'unsigned' and 'int'.
914 * alloc.c (allocate_vectorlike):
915 Check for overflow in vector size calculations.
916 * ccl.c (ccl_driver):
917 Check for overflow when converting EMACS_INT to int.
918 * fns.c, image.c: Remove unnecessary static decls that would otherwise
919 need to be updated by these changes.
920 * fns.c (make_hash_table, maybe_resize_hash_table):
921 Check for integer overflow with large hash tables.
922 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
923 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
924 (SXHASH_REDUCE): New macro.
925 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
926 Use it instead of discarding useful hash info with large hash values.
927 (sxhash_float): New function.
928 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
929 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
930 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
931 Rewrite to use FIXNUM_BITS, as this simplifies things.
932 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
933 Adjust signatures to match updated version of code.
934 (consing_since_gc): Now EMACS_INT, since a single hash table can
935 use more than INT_MAX bytes.
937 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
939 Make it possible to build with GCC-4.6+ -O2 -flto.
941 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
943 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
945 * minibuf.c (get_minibuffer, read_minibuf_unwind):
946 Call minibuffer-inactive-mode.
948 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
950 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
953 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
955 * data.c (init_data): Remove code for UTS, this system is not
958 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
960 Don't force ./temacs to start in terminal mode.
962 * frame.c (make_initial_frame): Initialize faces in all cases, not
963 only when CANNOT_DUMP is defined.
964 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
966 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
968 * dispnew.c (add_window_display_history): Use const for the string
969 pointer. Remove declaration, not needed.
971 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
973 Use 'inline', not 'INLINE'.
974 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
975 * alloc.c, fontset.c (INLINE): Remove.
976 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
977 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
978 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
979 * gmalloc.c (register_heapinfo): Use inline unconditionally.
980 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
982 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
984 Make it possible to run ./temacs.
986 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
987 syms_of_callproc does the same thing. Remove test for
988 "initialized", do it in the caller.
989 * emacs.c (main): Avoid calling set_initial_environment when dumping.
991 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
993 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
994 (read_minibuf): Use get_minibuffer.
995 (syms_of_minibuf): Use DEFSYM.
996 (Qmetadata): New var.
997 * data.c (Qbuffer): Don't make it static.
998 (syms_of_data): Use DEFSYM.
1000 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1002 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1003 (CCL_CODE_MIN): New macro.
1005 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1007 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1009 * eval.c (Qdebug): Now static.
1010 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1011 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1012 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1014 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1016 * image.c: Various fixes to ImageMagick code comments.
1017 (Fimagemagick_types): Doc fix.
1019 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1021 Minor fixes prompted by GCC 4.6.0 warnings.
1023 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1025 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1026 (x_clipboard_manager_save_all): Move extern decl to ...
1027 * xterm.h: ... here, so that it can be checked for consistency.
1029 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1031 * xselect.c (x_clipboard_manager_save_frame)
1032 (x_clipboard_manager_save_all): New functions.
1033 (Fx_clipboard_manager_save): Lisp function deleted.
1035 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1036 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1038 * xterm.h: Update prototype.
1040 2011-05-28 William Xu <william.xwl@gmail.com>
1042 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1045 2011-05-28 Jim Meyering <meyering@redhat.com>
1047 Avoid a sign-extension bug in crypto_hash_function.
1048 * fns.c (to_uchar): Define.
1049 (crypto_hash_function): Use it to convert some newly-signed
1050 variables to unsigned, to avoid sign-extension bugs. For example,
1051 without this change, (md5 "truc") would evaluate to
1052 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1053 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1054 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1056 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1058 Integer overflow fixes.
1060 * dbusbind.c: Serial number integer overflow fixes.
1061 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1062 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1063 to hold a serial number that is too large for a fixnum.
1064 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1065 Check for serial numbers out of range. Decode any serial number
1066 that was so large that it became a float. (Bug#8722)
1068 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1069 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1070 Use XFASTINT rather than XUINT when numbers are nonnegative.
1071 (xd_append_arg, Fdbus_method_return_internal):
1072 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1073 arguments, check that Lisp number is nonnegative, rather than
1074 silently wrapping negative numbers around. (Bug#8722)
1075 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1078 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1080 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1082 ccl: add integer overflow checks
1083 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1084 (IN_INT_RANGE): New macros.
1085 (ccl_driver): Use them to check for integer overflow when
1086 decoding a CCL program. Many of the new checks are whether XINT (x)
1087 fits in int; it doesn't always, on 64-bit hosts. The new version
1088 doesn't catch all possible integer overflows, but it's an
1089 improvement. (Bug#8719)
1091 * alloc.c (make_event_array): Use XINT, not XUINT.
1092 There's no need for unsigned here.
1094 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1095 This follows up to the 2011-05-06 change that substituted uintptr_t
1096 for EMACS_INT. This case wasn't caught back then.
1098 Rework Fformat to avoid integer overflow issues.
1099 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1100 now (part of C89). Include <verify.h>.
1101 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1102 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1103 (Fformat): Avoid the prepass trying to compute sizes; it was only
1104 approximate and thus did not catch overflow reliably. Instead, walk
1105 through the format just once, formatting and computing sizes as we go,
1106 checking for integer overflow at every step, and allocating a larger
1107 buffer as needed. Keep track separately whether the format is
1108 multibyte. Keep only the most-recently calculated precision, rather
1109 than them all. Record whether each argument has been converted to
1110 string. Use EMACS_INT, not int, for byte and char and arg counts.
1111 Support field widths and precisions larger than INT_MAX. Avoid
1112 sprintf's undefined behavior with conversion specifications such as %#d
1113 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1114 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1115 formatting out-of-range floating point numbers with int
1118 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1120 * data.c: Avoid integer truncation in expressions involving floats.
1121 * data.c: Include <intprops.h>.
1122 (arith_driver): When there's an integer overflow in an expression
1123 involving floating point, convert the integers to floating point
1124 so that the resulting value does not suffer from catastrophic
1125 integer truncation. For example, on a 64-bit host (* 4
1126 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1127 Do not rely on undefined behavior after integer overflow.
1129 merge count_size_as_multibyte, parse_str_to_multibyte
1130 * character.c, character.h (count_size_as_multibyte):
1131 Rename from parse_str_to_multibyte; all uses changed.
1132 Check for integer overflow.
1133 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1134 since it's now a duplicate of the other. This is more of
1135 a character than a buffer op, so better that it's in character.c.
1136 * fns.c, print.c: Adjust to above changes.
1138 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1140 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1142 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1144 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1145 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1146 (x_clipboard_manager_save): Now static.
1147 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1149 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1150 (crypto_hash_function): Now static.
1151 Fix pointer signedness problems. Avoid unnecessary initializations.
1153 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1155 * termhooks.h (Vselection_alist): Make it terminal-local.
1157 * terminal.c (create_terminal): Initialize it.
1159 * xselect.c: Support for clipboard managers.
1160 (Vselection_alist): Move to termhooks.h as terminal-local var.
1161 (LOCAL_SELECTION): New macro.
1162 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1163 (symbol_to_x_atom): Remove gratuitous arg.
1164 (x_handle_selection_request, lisp_data_to_selection_data)
1165 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1166 (x_own_selection, x_get_local_selection, x_convert_selection):
1167 New arg, specifying work frame. Use terminal-local Vselection_alist.
1168 (some_frame_on_display): Delete unused function.
1169 (Fx_own_selection_internal, Fx_get_selection_internal)
1170 (Fx_disown_selection_internal, Fx_selection_owner_p)
1171 (Fx_selection_exists_p): New optional frame arg.
1172 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1173 (x_handle_selection_clear): Don't treat other terminals with the
1174 same keyboard specially. Use the terminal-local Vselection_alist.
1175 (x_clear_frame_selections): Use Frun_hook_with_args.
1177 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1179 * xterm.h: Add support for those atoms.
1181 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1183 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1184 (converted_selections, conversion_fail_tag): New global variables.
1185 (x_selection_request_lisp_error): Free the above.
1186 (x_get_local_selection): Remove unnecessary code.
1187 (x_reply_selection_request): Args changed; handle arbitrary array
1188 of converted selections stored in converted_selections.
1189 Separate the XChangeProperty and SelectionNotify steps.
1190 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1191 (x_convert_selection): New function.
1192 (x_handle_selection_event): Simplify.
1193 (x_get_foreign_selection): Don't ignore incoming requests while
1194 waiting for an answer; this will fail when we implement
1195 SAVE_TARGETS, and seems unnecessary anyway.
1196 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1197 (Vx_sent_selection_functions): Doc fix.
1199 2011-05-26 Leo Liu <sdl.web@gmail.com>
1201 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1203 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1205 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1207 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1208 for fringe update if it has periodic bitmap.
1209 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1210 and fringe_bitmap_periodic_p.
1212 * fringe.c (get_fringe_bitmap_data): New function.
1213 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1214 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1215 row. Mark glyph row for fringe update if periodicity changed.
1217 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1218 for fringe update unless it has periodic bitmap.
1220 2011-05-25 Kenichi Handa <handa@m17n.org>
1222 * xdisp.c (get_next_display_element): Set correct it->face_id for
1223 a static composition.
1225 2011-05-24 Leo Liu <sdl.web@gmail.com>
1228 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1230 * fns.c (crypto_hash_function, Fsha1): New function.
1231 (Fmd5): Use crypto_hash_function.
1232 (syms_of_fns): Add Ssha1.
1234 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1236 * gnutls.c: Remove unused macros.
1237 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1238 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1239 Remove macros that are defined and never used.
1240 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1242 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1244 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1245 (Fx_get_selection_internal): Minor cleanup.
1246 (Fx_own_selection_internal): Rename arguments for consistency with
1249 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1251 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1253 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1255 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1257 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1259 * dispnew.c (scrolling_window): Don't exclude the case that the
1260 last enabled row in the desired matrix touches the bottom boundary.
1262 2011-05-21 Glenn Morris <rgm@gnu.org>
1264 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1265 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1266 and add some more files.
1268 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1270 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1271 report_file_error introduced by the change from 2011-05-07.
1273 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1275 * systime.h (Time): Define only if emacs is defined.
1276 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1277 where the include path doesn't have X11/X.h by default. See
1278 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1280 2011-05-20 Kenichi Handa <handa@m17n.org>
1282 * composite.c (find_automatic_composition): Fix previous change.
1284 2011-05-20 Glenn Morris <rgm@gnu.org>
1286 * lisp.mk: New file, split from Makefile.in.
1287 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1288 (shortlisp): Remove.
1289 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1291 2011-05-19 Glenn Morris <rgm@gnu.org>
1293 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1294 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1295 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1296 (lisp): Set the order to that of loadup.el.
1297 (shortlisp): Make it a copy of $lisp.
1298 (SOME_MACHINE_LISP): Remove.
1299 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1300 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1302 2011-05-18 Kenichi Handa <handa@m17n.org>
1304 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1305 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1306 (find_automatic_composition): Mostly rewrite for efficiency.
1308 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1310 * makefile.w32-in: Update dependencies.
1312 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1314 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1317 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1319 Fix some integer overflow issues, such as string length overflow.
1321 * insdel.c (count_size_as_multibyte): Check for string overflow.
1323 * character.c (lisp_string_width): Check for string overflow.
1324 Use EMACS_INT, not int, for string indexes and lengths; in
1325 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1326 the resulting string length overflows an EMACS_INT; instead,
1327 report a string overflow if no precision given. When checking for
1328 precision exhaustion, use a check that cannot possibly have
1329 integer overflow. (Bug#8675)
1330 * character.h (lisp_string_width): Adjust to new signature.
1332 * alloc.c (string_overflow): New function.
1333 (Fmake_string): Use it. This doesn't change behavior, but saves
1334 a few bytes and will simplify future changes.
1335 * character.c (string_escape_byte8): Likewise.
1336 * lisp.h (string_overflow): New decl.
1338 Fixups, following up to the user-interface timestamp change.
1339 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1340 for UI timestamps, instead of unsigned long.
1341 * msdos.c (mouse_get_pos): Likewise.
1342 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1343 * w32gui.h (Time): Define by including "systime.h" rather than by
1344 declaring it ourselves. (Bug#8664)
1346 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1347 * image.c (clear_image_cache): Likewise.
1349 * term.c (term_mouse_position): Don't assume time_t wraparound.
1351 Be more systematic about user-interface timestamps.
1352 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1353 and sometimes 'EMACS_UINT', to represent these timestamps.
1354 This change causes it to use 'Time' uniformly, as that's what X uses.
1355 This makes the code easier to follow, and makes it easier to catch
1356 integer overflow bugs such as Bug#8664.
1357 * frame.c (Fmouse_position, Fmouse_pixel_position):
1358 Use Time, not unsigned long, for user-interface timestamps.
1359 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1360 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1361 * keyboard.h (last_event_timestamp): Likewise.
1362 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1363 * menu.h (xmenu_show): Likewise.
1364 * term.c (term_mouse_position): Likewise.
1365 * termhooks.h (struct input_event.timestamp): Likewise.
1366 (struct terminal.mouse_position_hook): Likewise.
1367 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1368 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1369 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1370 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1372 * menu.h, termhooks.h: Include "systime.h", for Time.
1374 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1375 Don't assume that the difference between two unsigned long values
1376 can fit into an integer. At this point, we know button_down_time
1377 <= event->timestamp, so the difference must be nonnegative, so
1378 there's no need to cast the result if double-click-time is
1379 nonnegative, as it should be; check that it's nonnegative, just in
1380 case. This bug is triggered when events are more than 2**31 ms
1381 apart (about 25 days). (Bug#8664)
1383 * xselect.c (last_event_timestamp): Remove duplicate decl.
1384 (x_own_selection): Remove needless cast to unsigned long.
1386 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1387 that always fit in int. Use a sentinel instead of a counter, to
1388 avoid a temp and to allay GCC's concerns about possible int overflow.
1389 * frame.h (struct frame): Use int for menu_bar_items_used
1390 instead of EMACS_INT, since it always fits in int.
1392 * menu.c (grow_menu_items): Check for int overflow.
1394 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1396 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1397 Before, the code was not consistent. These values cannot exceed
1398 2**31 - 1 so there's no need to make them unsigned.
1399 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1400 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1401 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1403 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1405 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1406 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1407 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1408 presumably because the widths might not match.
1410 * window.c (size_window): Avoid needless test at loop start.
1412 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1414 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1416 2011-05-12 Drew Adams <drew.adams@oracle.com>
1418 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1420 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1422 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1423 `width' to `bar_area_x' and `bar_area_width', respectively.
1424 (x_scroll_run): Take account of fringe background extension.
1426 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1427 Rename local vars `left' and `width' to `bar_area_x' and
1428 `bar_area_width', respectively.
1429 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1430 background extension.
1432 2011-05-10 Jim Meyering <meyering@redhat.com>
1434 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1436 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1438 * image.c (Finit_image_library): Return t for built-in image types,
1439 like pbm and xbm. (Bug#8640)
1441 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1443 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1445 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1447 * w32console.c (Fset_screen_color): Doc fix.
1448 (Fget_screen_color): New function.
1449 (syms_of_ntterm): Defsubr it.
1451 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1452 unlink the temporary file if Fcall_process didn't create it in the
1454 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1455 child process will be redirected to a file specified with `:file'.
1456 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1457 cue to call_process_cleanup not to close that handle.
1459 2011-05-07 Ben Key <bkey76@gmail.com>
1461 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1462 one of two shell specific rules, either bootstrap-temacs-CMD or
1463 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1464 to the previous implementation of the bootstrap-temacs rule.
1465 The bootstrap-temacs-CMD rule is similar to the previous
1466 implementation of the bootstrap-temacs rule except that it
1467 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1470 These changes, along with some changes to nt/configure.bat,
1471 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1472 earlier fix to add support for --cflags and --ldflags options
1473 that include quotes so that it works whether make uses cmd or
1476 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1478 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1479 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1481 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1482 a string. Handle both cases.
1483 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1484 (Fdbus_register_method): Use Qinvalid_function.
1486 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1488 * makefile.w32-in: Update dependencies.
1489 (LISP_H): Add inttypes.h and stdin.h.
1490 (PROCESS_H): Add unistd.h.
1492 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1494 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1495 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1497 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1499 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1501 * term.c (vfatal): Remove stray call to va_end.
1502 It's not needed and the C Standard doesn't allow it here anyway.
1504 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1505 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1507 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1510 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1512 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1514 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1516 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1518 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1520 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1521 * charset.c (Fdefine_charset_internal): Don't initialize
1522 charset.code_space[15]. The value was garbage, on hosts with
1523 32-bit int (Bug#8600).
1525 * lread.c (read_integer): Be more consistent with string-to-number.
1526 Use string_to_number to do the actual conversion; this avoids
1527 rounding errors and fixes some other screwups. Without this fix,
1528 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1529 (digit_to_number): Move earlier, for benefit of read_integer.
1530 Return -1 if the digit is out of range for the base, -2 if it is
1531 not a digit in any supported base. (Bug#8602)
1533 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1535 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1536 to match comment at start of function. This also removes a
1537 GCC warning about overflow in a 32+64-bit port.
1539 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1541 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1542 Reported by Stefan Monnier in
1543 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1544 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1545 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1547 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1548 (EMACS_UINTPTR): Likewise, with uintptr_t.
1550 * lisp.h: Prefer 64-bit EMACS_INT if available.
1551 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1552 on 32-bit hosts that have 64-bit int, so that they can access
1554 However, temporarily disable this change unless the temporary
1555 symbol WIDE_EMACS_INT is defined.
1557 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1559 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1560 This removes an assumption that EMACS_INT and long are the same
1561 width as pointers. The assumption is true for Emacs porting targets
1562 now, but we want to make other targets possible.
1563 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1564 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1565 In the rest of the code, change types of integers that hold casted
1566 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1567 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1568 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1569 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1570 No need to cast type when ORing.
1571 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1572 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1573 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1574 assume EMACS_INT is the same width as char *.
1575 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1576 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1577 Remove no-longer-needed casts.
1578 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1579 (xg_tool_bar_help_callback, xg_make_tool_item):
1580 Use EMACS_INTPTR to hold an integer
1581 that will be cast to void *; this can avoid a GCC warning
1582 if EMACS_INT is not the same width as void *.
1583 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1584 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1585 (current_message_1, set_message_1):
1586 Use a local to convert to proper width without a cast.
1587 * xmenu.c (dialog_selection_callback): Likewise.
1589 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1590 Also, don't assume VALBITS / RAND_BITS is less than 5,
1591 and don't rely on undefined behavior when shifting a 1 left into
1593 * lisp.h (get_random): Change signature to match.
1595 * lread.c (hash_string): Use size_t, not int, for hash computation.
1596 Normally we prefer signed values; but hashing is special, because
1597 it's better to use unsigned division on hash table sizes so that
1598 the remainder is nonnegative. Also, size_t is the natural width
1599 for hashing into memory. The previous code used 'int', which doesn't
1600 retain enough info to hash well into very large tables.
1601 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1603 * dbusbind.c: Don't possibly lose pointer info when converting.
1604 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1605 Use XPNTR rather than XHASH, so that the high-order bits of
1606 the pointer aren't lost when converting through void *.
1608 * eval.c (Fautoload): Don't double-shift a pointer.
1610 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1612 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1614 * gnutls.c (DEF_GNUTLS_FN):
1615 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1617 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1619 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1622 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1624 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1625 New version that can reserve upto 2GB of heap space.
1627 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1629 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1631 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1633 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1634 `gnutls_certificate_set_x509_key_file'.
1636 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1638 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1639 Update dependencies.
1641 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1643 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1644 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1645 Remove unused parameter `fildes'.
1646 * process.c (read_process_output, send_process): Don't pass it.
1648 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1650 Fix previous change: the library cache is defined in w32.c.
1651 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1652 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1654 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1656 Implement dynamic loading of GnuTLS on Windows.
1658 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1659 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1660 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1663 * gnutls.c (Qgnutls_dll): Define.
1664 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1665 (gnutls_*): Declare function pointers.
1666 (init_gnutls_functions): New function to initialize function pointers.
1667 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1668 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1669 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1670 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1671 (emacs_gnutls_write, emacs_gnutls_read)
1672 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1673 (Fgnutls_available_p): New function.
1674 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1675 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1676 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1678 * image.c: Include w32.h.
1679 (Vimage_type_cache): Delete.
1680 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1681 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1682 (w32_delayed_load): Move to w32.c.
1684 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1686 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1687 (w32_delayed_load): Move from image.c. When loading a library, record
1688 its filename in the :loaded-from property of the library id.
1689 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1690 Initialize and staticpro them.
1691 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1693 * process.c: Include lisp.h before w32.h, not after.
1694 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1695 instead of gnutls_record_check_pending.
1697 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1699 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1701 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1702 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1705 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1707 * xterm.c (x_set_frame_alpha): Do not set property on anything
1708 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1710 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1712 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1714 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1716 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1717 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1718 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1719 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1720 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1721 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1722 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1723 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1724 (Qgnutls_bootprop_callbacks_verify): Make static.
1726 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1728 * callproc.c: Indentation fixup.
1730 * sysdep.c (wait_for_termination_1): Make static.
1731 (wait_for_termination, interruptible_wait_for_termination):
1732 Move after wait_for_termination_1.
1734 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1736 * sysdep.c (interruptible_wait_for_termination): New function
1737 which is like wait_for_termination, but allows keyboard
1740 * callproc.c (Fcall_process): Add (:file "file") as an option for
1742 (Fcall_process_region): Ditto.
1744 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1746 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1747 rather than `XVECTOR (FOO)->size'.
1749 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1750 inttypes.h, as a gnulib replacement is used if it not available in
1753 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1755 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1756 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1757 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1759 * coding.c (coding_alloc_by_realloc): Error out if destination
1760 will grow beyond MOST_POSITIVE_FIXNUM.
1761 (decode_coding_emacs_mule): Abort if there isn't enough place in
1762 charbuf for the composition carryover bytes. Reserve an extra
1763 space for up to 2 characters produced in a loop.
1764 (decode_coding_iso_2022): Abort if there isn't enough place in
1765 charbuf for the composition carryover bytes.
1767 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1769 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1770 aborting when %lld or %lll format is passed.
1771 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1772 %llo or %llx format is passed. (Bug#8545)
1774 * window.c (window_scroll_line_based): Use a marker instead of
1775 simple variables to record original value of point. (Bug#7952)
1777 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1778 produced by %s or %c overflows available buffer space. (Bug#8545)
1780 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1782 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1783 (SIZE_MAX): Move defn after all includes, as they might #define it.
1785 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1787 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1789 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1791 * keyboard.c (Qdelayed_warnings_hook): Define.
1792 (command_loop_1): Run `delayed-warnings-hook'
1793 if Vdelayed_warnings_list is non-nil.
1794 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1795 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1797 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1799 * doprnt.c (doprnt): Don't return value smaller than the buffer
1800 size if the message was truncated. (Bug#8545).
1802 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1804 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1805 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1807 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1809 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1811 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1813 * makefile.w32-in: Update dependencies.
1815 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1817 Improve `doprnt' and its usage. (Bug#8545)
1818 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1819 `format_end'. Remove support for %l as a conversion specifier.
1820 Don't use xrealloc. Improve diagnostics when the %l size modifier
1821 is used. Update the commentary.
1823 * eval.c (verror): Simplify calculation of size_t.
1825 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1828 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1830 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1833 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1835 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1836 This makes this file independent of the recent pseudovector change.
1838 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1840 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1842 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1843 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1844 Remove unused local.
1845 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1847 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1848 GCC 4.6.0 optimizes based on type-based alias analysis.
1849 For example, if b is of type struct buffer * and v of type struct
1850 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1851 != &v->size, and therefore "v->size = 1; b->size = 2; return
1852 v->size;" must therefore return 1. This assumption is incorrect
1853 for Emacs, since it type-puns struct Lisp_Vector * with many other
1854 types. To fix this problem, this patch adds a new type struct
1855 vectorlike_header that documents the constraints on layout of vectors
1856 and pseudovectors, and helps optimizing compilers not get fooled
1857 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1858 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1859 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1861 (XSETPVECTYPE): Rewrite in terms of new macro.
1862 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1863 This is a bit clearer, and further avoids the possibility of
1864 undesirable aliasing.
1865 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1866 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1867 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1868 since Lisp_Subr is a special case (no "next" field).
1869 (ASIZE): Now uses header.size rather than size.
1870 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1871 to avoid the hassle of writing XVECTOR (foo)->header.size.
1872 (struct vectorlike_header): New type.
1873 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1874 object, to help avoid aliasing.
1875 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1876 (SUBRP): Likewise, since Lisp_Subr is a special case.
1877 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1878 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1879 (struct Lisp_Hash_Table): Combine first two members into a single
1880 struct vectorlike_header member. All uses of "size" and "next" members
1881 changed to be "header.size" and "header.next".
1882 * buffer.h (struct buffer): Likewise.
1883 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1884 * frame.h (struct frame): Likewise.
1885 * process.h (struct Lisp_Process): Likewise.
1886 * termhooks.h (struct terminal): Likewise.
1887 * window.c (struct save_window_data, struct saved_window): Likewise.
1888 * window.h (struct window): Likewise.
1889 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1890 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1891 * buffer.c (init_buffer_once): Likewise.
1892 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1894 * process.c (Fformat_network_address): Use local var for size,
1897 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1899 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1900 * data.c (atof): Remove decl; no longer used or needed.
1901 (digit_to_number): Move to lread.c.
1902 (Fstring_to_number): Use new string_to_number function, to be
1903 consistent with how the Lisp reader treats infinities and NaNs.
1904 Do not assume that floating-point numbers represent EMACS_INT
1905 without losing information; this is not true on most 64-bit hosts.
1906 Avoid double-rounding errors, by insisting on integers when
1907 parsing non-base-10 numbers, as the documentation specifies.
1908 * lisp.h (string_to_number): New decl, replacing ...
1909 (isfloat_string): Remove.
1910 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1911 (read1): Do not accept +. and -. as integers; this
1912 appears to have been a coding error. Similarly, do not accept
1913 strings like +-1e0 as floating point numbers. Do not report
1914 overflow for integer overflows unless the base is not 10 which
1915 means we have no simple and reliable way to continue.
1916 Break out the floating-point parsing into a new
1917 function string_to_number, so that Fstring_to_number parses
1918 floating point numbers consistently with the Lisp reader.
1919 (digit_to_number): Move here from data.c. Make it static inline.
1920 (E_CHAR, EXP_INT): Remove, replacing with ...
1921 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1922 (string_to_number): New function, replacing isfloat_string.
1923 This function checks for valid syntax and produces the resulting
1924 Lisp float number too. Rework it so that string-to-number
1925 no longer mishandles examples like "1.0e+". Use strtoumax,
1926 so that overflow for non-base-10 numbers is reported only when
1927 there's no portable and simple way to convert to floating point.
1929 * textprop.c (set_text_properties_1): Rewrite for clarity,
1930 and to avoid GCC warning about integer overflow.
1932 * intervals.h (struct interval): Use EMACS_INT for members
1933 where EMACS_UINT might cause problems. See
1934 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1935 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1936 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1938 (offset_intervals): Tell GCC not to worry about length overflow
1939 when negating a negative length.
1941 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1942 (overrun_check_free): Likewise.
1944 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1945 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1948 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1949 (gnutls_make_error): Rename local to avoid shadowing.
1950 (gnutls_emacs_global_deinit): ifdef out; not used.
1951 (Fgnutls_boot): Use const for pointer to readonly storage.
1952 Comment out unused local. Fix pointer signedness problems.
1954 * lread.c (openp): Don't stuff size_t into an 'int'.
1955 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1956 about possible signed overflow.
1958 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1959 (GDK_KEY_g): Don't define if already defined.
1960 (xg_prepare_tooltip): Avoid pointer signedness problem.
1961 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1963 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1964 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1966 * xfns.c (Fx_window_property): Simplify a bit,
1967 to make a bit faster and to avoid GCC 4.6.0 warning.
1968 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1970 * fns.c (internal_equal): Don't assume size_t fits in int.
1972 * alloc.c (compact_small_strings): Tighten assertion a little.
1974 Replace pEd with more-general pI, and fix some printf arg casts.
1975 * lisp.h (pI): New macro, generalizing old pEd macro to other
1976 conversion specifiers. For example, use "...%"pI"d..." rather
1977 than "...%"pEd"...".
1978 (pEd): Remove. All uses replaced with similar uses of pI.
1979 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1980 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1981 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1982 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1983 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1984 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1985 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1987 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1988 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1989 * print.c (safe_debug_print, print_object): Likewise.
1990 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1992 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1993 avoiding the 0 flag, which is not portable.
1994 * process.c (Fmake_network_process): Use pI to avoid cast.
1995 * region-cache.c (pp_cache): Likewise.
1996 * xdisp.c (decode_mode_spec): Likewise.
1997 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1998 behavior on 64-bit hosts with printf arg.
1999 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2000 (x_stop_queuing_selection_requests): Likewise.
2001 (x_get_window_property): Don't truncate byte count to an 'int'
2004 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2005 here, since it parses constructs like leading '-' and spaces,
2006 which are not wanted; and it overflows with large numbers.
2007 Instead, simply match F[0-9]+, which is what is wanted anyway.
2009 * alloc.c: Remove unportable assumptions about struct layout.
2010 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2011 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2012 (allocate_vectorlike, make_pure_vector): Use the new macros,
2013 plus offsetof, to remove unportable assumptions about struct layout.
2014 These assumptions hold on all porting targets that I know of, but
2015 they are not guaranteed, they're easy to remove, and removing them
2016 makes further changes easier.
2018 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2019 This doesn't fix a bug but makes the code clearer.
2020 (string_overrun_cookie): Now const. Use initializers that
2021 don't formally overflow signed char, to avoid warnings.
2022 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2023 can cause Emacs to crash when string overrun checking is enabled.
2024 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2025 multiple of sizeof (EMACS_INT); it need not be, if
2026 alignof(EMACS_INT) < sizeof (EMACS_INT).
2027 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2029 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2031 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2033 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2035 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2036 supposed to be handshaking. (Bug#8556)
2037 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2039 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2041 * lisp.h (Qdebug): List symbol.
2042 * eval.c (Qdebug): Restore global linkage.
2043 * keyboard.c (debug-on-event): New variable.
2044 (handle_user_signal): Break into debugger when debug-on-event
2045 matches the current signal symbol.
2047 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2049 * alloc.c (check_sblock, check_string_bytes)
2050 (check_string_free_list): Convert to standard C.
2052 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2054 * w32.c (emacs_gnutls_push): Fix typo.
2056 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2058 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2059 "cast to pointer from integer of different size".
2061 Improve doprnt and its use in verror. (Bug#8545)
2062 * doprnt.c (doprnt): Document the set of format control sequences
2063 supported by the function. Use SAFE_ALLOCA instead of always
2066 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2067 is one byte too soon. Don't use xrealloc; instead xfree and
2070 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2072 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2075 * gnutls.c: Renamed global_initialized to
2076 gnutls_global_initialized. Added internals for the
2077 :verify-hostname-error, :verify-error, and :verify-flags
2078 parameters of `gnutls-boot' and documented those parameters in the
2079 docstring. Start callback support.
2080 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2081 unless a fatal error occured. Call gnutls_alert_send_appropriate
2082 on error. Return error code.
2083 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2084 (emacs_gnutls_read): Likewise.
2085 (Fgnutls_boot): Return handshake error code.
2086 (emacs_gnutls_handle_error): New function.
2087 (wsaerror_to_errno): Likewise.
2089 * w32.h (emacs_gnutls_pull): Add prototype.
2090 (emacs_gnutls_push): Likewise.
2092 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2093 (emacs_gnutls_push): Likewise.
2095 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2097 * process.c (wait_reading_process_output): Check if GnuTLS
2098 buffered some data internally if no FDs are set for TLS
2101 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2102 (LIBS): Link to USER_LIBS.
2103 ($(BLD)/gnutls.$(0)): New target.
2105 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2107 * xdisp.c (handle_single_display_spec): Rename the
2108 display_replaced_before_p argument into display_replaced_p, to
2109 make it consistent with the commentary. Fix typos in the
2112 * textprop.c (syms_of_textprop): Remove dead code.
2113 (copy_text_properties): Delete obsolete commentary about an
2114 interface that was deleted long ago. Fix typos in the description
2117 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2118 to changes in oldXMenu/XMenu.h from 2011-04-16.
2119 <menu_help_message, prev_menu_help_message>: Constify.
2120 (IT_menu_make_room): menu->help_text is now `const char **';
2123 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2124 to changes in oldXMenu/XMenu.h from 2011-04-16.
2125 (struct XMenu): Declare `help_text' `const char **'.
2127 * xfaces.c <Qunspecified>: Make extern again.
2129 * syntax.c: Include sys/types.h before including regex.h, as
2132 * doc.c (get_doc_string): Improve the format passed to `error'.
2134 * doprnt.c (doprnt): Improve commentary.
2136 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2138 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2141 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2142 changes in globals.h immediately force recompilation.
2143 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2144 $(CURDIR)/s/ms-w32.h.
2145 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2147 * character.c (Fchar_direction): Function deleted.
2148 (syms_of_character): Don't defsubr it.
2149 <char-direction-table>: Deleted.
2151 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2153 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2154 * doprnt.c: Include limits.h.
2155 (SIZE_MAX): New macro.
2156 (doprnt): Return a size_t value. 2nd arg is now size_t.
2157 Many local variables are now size_t instead of int or unsigned.
2158 Improve overflow protection. Support `l' modifier for integer
2159 conversions. Support %l conversion. Don't assume an EMACS_INT
2160 argument for integer conversions and for %c.
2162 * lisp.h (doprnt): Restore prototype.
2164 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2167 * Makefile.in (base_obj): Add back doprnt.o.
2169 * deps.mk (doprnt.o): Add back prerequisites.
2170 (callint.o): Depend on character.h.
2172 * eval.c (internal_lisp_condition_case): Include the handler
2173 representation in the error message.
2174 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2175 when breaking from the loop.
2177 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2179 * callint.c (Fcall_interactively): When displaying error message
2180 about invalid control letter, pass the character's codepoint, not
2181 a pointer to its multibyte form. Improve display of the character
2182 in octal and display also its hex code.
2184 * character.c (char_string): Use %x to display the (unsigned)
2185 codepoint of an invalid character, to avoid displaying a bogus
2188 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2189 `error', not SYMBOL_NAME itself.
2191 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2192 character arguments to `error'.
2194 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2195 to `error' in error message about FINAL_CHAR argument. Make sure
2196 FINAL_CHAR is a character, and use %c when it is passed as
2197 argument to `error'.
2199 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2201 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2203 * w32.c: Include <time.h>.
2204 (sys_localtime): New function.
2206 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2208 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2210 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2212 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2214 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2217 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2219 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2220 gl_state.e_property when gl_state.object is Qt.
2222 * insdel.c (make_gap_larger): Remove limitation of buffer size
2225 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2227 * xdisp.c (lookup_glyphless_char_display)
2228 (produce_glyphless_glyph): Handle cons cell entry in
2229 glyphless-char-display.
2230 (Vglyphless_char_display): Document it.
2232 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2233 glyphless-char-display.
2235 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2237 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2239 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2241 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2242 definition for no-X builds.
2244 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2246 Static checks with GCC 4.6.0 and non-default toolkits.
2248 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2250 * process.c (keyboard_bit_set): Define only if SIGIO.
2251 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2252 (send_process): Repair possible setjmp clobbering.
2254 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2256 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2258 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2260 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2261 Define only if needed.
2263 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2264 by pacifying GCC about it. Maybe it's time to retire it?
2265 * xfaces.c (USG, __TIMEVAL__): Likewise.
2267 * dispextern.h (struct redisplay_interface): Rename param
2269 * termhooks.h (struct terminal): Likewise.
2270 * xterm.c (xembed_send_message): Likewise.
2272 * insdel.c (make_gap_smaller): Define only if
2273 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2275 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2278 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2279 so that we aren't warned about unused symbols.
2281 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2283 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2285 * xfns.c (x_real_positions): Mark locals as initialized.
2287 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2289 * xterm.c: Fix problems found by static analysis with other toolkits.
2290 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2291 (x_dispatch_event): Declare static if USE_GTK, and
2292 define if USE_GTK || USE_X_TOOLKIT.
2293 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2294 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2295 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2296 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2298 * xmenu.c (menu_help_callback): Pointer type fixes.
2299 Use const pointers when pointing at readonly data. Avoid pointer
2301 (FALSE): Remove unused macro.
2302 (update_frame_menubar): Remove unused decl.
2304 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2306 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2307 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2308 (single_menu_item): Rename local to avoid shadowing.
2310 * keyboard.c (make_lispy_event): Remove unused local var.
2312 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2313 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2315 * bitmaps: Change bitmaps from unsigned char back to the X11
2316 compatible char. Avoid the old compiler warnings about
2317 out-of-range initializers by using, for example, '\xab' rather
2320 * xgselect.c (xgselect_initialize): Check vs interface
2321 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2323 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2325 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2326 to read-only memory.
2328 * fns.c (vector): Remove; this old hack is no longer needed.
2330 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2332 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2334 * xrdb.c (x_load_resources): Omit unused local.
2336 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2337 (x_window): Rename locals to avoid shadowing.
2338 (USG): Use the kludged USG macro, to pacify gcc.
2340 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2341 (x_term_init): Remove local to avoid shadowing.
2343 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2345 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2346 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2348 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2350 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2352 Fix regex.c, syntax.c and friends for buffers > 2GB.
2353 * syntax.h (struct gl_state_s): Declare character position members
2356 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2358 * textprop.c (verify_interval_modification, interval_of):
2359 Declare arguments EMACS_INT.
2361 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2364 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2366 * indent.c (Fvertical_motion): Local variable it_start is now
2369 * regex.c (re_match, re_match_2, re_match_2_internal)
2370 (bcmp_translate, regcomp, regexec, print_double_string)
2371 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2372 (re_compile_pattern, re_exec): Declare arguments and local
2373 variables `size_t' and `ssize_t' and return values `regoff_t', as
2375 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2376 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2377 <compile_stack_type>: `size' and `avail' are now `size_t'.
2379 * regex.h <regoff_t>: Use ssize_t, not int.
2380 (re_search, re_search_2, re_match, re_match_2): Arguments that
2381 specify buffer/string position and length are now ssize_t and
2382 size_t. Return type is regoff_t.
2384 2011-04-16 Ben Key <bkey76@gmail.com>
2386 * nsfont.m: Fixed bugs in ns_get_family and
2387 ns_descriptor_to_entity that were caused by using free to
2388 deallocate memory blocks that were allocated by xmalloc (via
2389 xstrdup). This caused Emacs to crash when compiled with
2390 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2391 --enable-checking=xmallocoverrun). xfree is now used to
2392 deallocate these memory blocks.
2394 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2396 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2398 emacs_write: Accept and return EMACS_INT for sizes.
2399 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2401 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2402 Accept and return EMACS_INT.
2403 (emacs_gnutls_write): Return the number of bytes written on
2405 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2406 (emacs_read, emacs_write): Remove check for negative size, as the
2407 Emacs source code has been audited now.
2408 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2409 (emacs_read, emacs_write): Use it.
2410 * process.c (send_process): Adjust to the new signatures of
2411 emacs_write and emacs_gnutls_write. Do not attempt to store
2412 a byte offset into an 'int'; it might overflow.
2413 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2415 * sound.c: Don't assume sizes fit in 'int'.
2416 (struct sound_device.period_size, alsa_period_size):
2417 Return EMACS_INT, not int.
2418 (struct sound_device.write, vox_write, alsa_write):
2419 Accept EMACS_INT, not int.
2420 (wav_play, au_play): Use EMACS_INT to store sizes and to
2421 record read return values.
2423 2011-04-15 Ben Key <bkey76@gmail.com>
2425 * keyboard.c (Qundefined): Don't declare static since it is used
2427 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2428 static since they are used in nsfont.m.
2430 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2432 * process.c (Qprocessp): Don't declare static.
2433 * lisp.h (Qprocessp): Declare again.
2435 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2437 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2439 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2441 Improve C-level modularity by making more things 'static'.
2443 Don't publish debugger-only interfaces to other modules.
2444 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2445 (verify_bytepos, count_markers): Move decls to the only modules
2447 * region-cache.h (pp_cache): Likewise.
2448 * window.h (check_all_windows): Likewise.
2449 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2451 * sysdep.c (croak): Now static, if
2452 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2453 * syssignal.h (croak): Declare only if not static.
2455 * alloc.c (refill_memory_reserve): Now static if
2456 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2457 * lisp.h (refill_memory_reserve): Declare only if not static.
2459 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2460 Define only if USE_LUCID.
2462 * xrdb.c (x_customization_string, x_rm_string): Now static.
2464 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2465 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2467 * xdisp.c (draw_row_with_mouse_face): Now static.
2468 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2470 * window.h (check_all_windows): Mark externally visible.
2472 * window.c (window_deletion_count): Now static.
2474 * undo.c: Make symbols static if they're not exported.
2475 (last_undo_buffer, last_boundary_position, pending_boundary):
2478 * textprop.c (interval_insert_behind_hooks): Now static.
2479 (interval_insert_in_front_hooks): Likewise.
2481 * term.c: Make symbols static if they're not exported.
2482 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2483 (max_frame_lines, tty_set_terminal_modes):
2484 (tty_reset_terminal_modes, tty_turn_off_highlight):
2485 (get_tty_terminal): Now static.
2486 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2487 * termhooks.h (term_mouse_moveto): Do not declare if
2489 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2490 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2492 * sysdep.c: Make symbols static if they're not exported.
2493 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2495 (sigprocmask_set, full_mask): Remove; unused.
2496 (wait_debugging): Mark as visible.
2497 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2498 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2500 * syntax.c (syntax_temp): Define only if !__GNUC__.
2502 * sound.c (current_sound_device, current_sound): Now static.
2504 * search.c (searchbufs, searchbuf_head): Now static.
2506 * scroll.c (scroll_cost): Remove; unused.
2507 * dispextern.h (scroll_cost): Remove decl.
2509 * region-cache.h (pp_cache): Mark as externally visible.
2511 * process.c: Make symbols static if they're not exported.
2512 (process_tick, update_tick, create_process, chan_process):
2513 (Vprocess_alist, proc_buffered_char, datagram_access):
2514 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2515 (deactivate_process): Mark defn as static, as well as decl.
2516 * lisp.h (create_process): Remove decl.
2517 * process.h (chan_process, Vprocess_alist): Remove decls.
2519 * print.c: Make symbols static if they're not exported.
2520 (print_depth, new_backquote_output, being_printed, print_buffer):
2521 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2522 (print_interval, print_number_index, initial_stderr_stream):
2524 * lisp.h (Fprinc): Remove decl.
2525 (debug_output_compilation_hack): Mark as externally visible.
2527 * sysdep.c (croak): Move decl from here to syssignal.h.
2528 * syssignal.h (croak): Put it here, so the API can be checked when
2529 'croak' is called from dissociate_if_controlling_tty.
2531 * minibuf.c: Make symbols static if they're not exported.
2532 (minibuf_save_list, choose_minibuf_frame): Now static.
2533 * lisp.h (choose_minibuf_frame): Remove decl.
2535 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2537 * lread.c: Make symbols static if they're not exported.
2538 (read_objects, initial_obarray, oblookup_last_bucket_number):
2540 (make_symbol): Remove; unused.
2541 * lisp.h (initial_obarray, make_symbol): Remove decls.
2543 * keyboard.c: Make symbols static if they're not exported.
2544 (single_kboard, recent_keys_index, total_keys, recent_keys):
2545 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2546 (this_single_command_key_start, echoing, last_auto_save):
2547 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2548 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2549 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2550 (Vlispy_mouse_stem, double_click_count):
2552 (force_auto_save_soon): Define only if SIGDANGER.
2553 (ignore_mouse_drag_p): Now static if
2554 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2555 (print_help): Remove; unused.
2556 (stop_character, last_timer_event): Mark as externally visible.
2557 * keyboard.h (ignore_mouse_drag_p): Declare only if
2558 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2559 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2560 * lisp.h (echoing): Remove decl.
2561 (force_auto_save_soon): Declare only if SIGDANGER.
2562 * xdisp.c (redisplay_window): Simplify code, to make it more
2563 obvious that ignore_mouse_drag_p is not accessed if !defined
2564 USE_GTK && !defined HAVE_NS.
2566 * intervals.c: Make symbols static if they're not exported.
2567 (merge_properties_sticky, merge_interval_right, delete_interval):
2569 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2571 * insdel.c: Make symbols static if they're not exported.
2572 However, leave prepare_to_modify_buffer alone. It's never
2573 called from outside this function, but that appears to be a bug.
2574 (combine_after_change_list, combine_after_change_buffer):
2575 (adjust_after_replace, signal_before_change): Now static.
2576 (adjust_after_replace_noundo): Remove; unused.
2577 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2578 (signal_before_change): Remove decls.
2580 * indent.c (val_compute_motion, val_vmotion): Now static.
2582 * image.c: Make symbols static if they're not exported.
2583 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2585 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2586 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2588 * fringe.c (standard_bitmaps): Now static.
2589 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2591 * frame.c: Make symbols static if they're not exported.
2592 (x_report_frame_params, make_terminal_frame): Now static.
2593 (get_frame_param): Now static, unless HAVE_NS.
2594 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2595 (x_get_resource_string): Remove; not used.
2596 * frame.h (make_terminal_frame, x_report_frame_params):
2597 (x_get_resource_string); Remove decls.
2598 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2599 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2601 * font.c, fontset.c: Make symbols static if they're not exported.
2602 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2603 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2604 * font.c (font_close_object): Now static.
2605 * font.h (font_close_object): Remove.
2606 * fontset.c (FONTSET_OBJLIST): Remove.
2607 (free_realized_fontset) #if-0 the body, which does nothing.
2608 (face_suitable_for_char_p): #if-0, as it's never called.
2609 * fontset.h (face_suitable_for_char_p): Remove decl.
2610 * xfaces.c (face_at_string_position):
2611 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2612 since 0 is always ASCII.
2614 * fns.c (weak_hash_tables): Now static.
2616 * fileio.c: Make symbols static if they're not exported.
2617 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2618 (Vwrite_region_annotation_buffers): Now static.
2620 * eval.c: Make symbols static if they're not exported.
2621 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2622 * lisp.h (backtrace_list): Remove decl.
2624 * emacs.c: Make symbols static if they're not exported.
2625 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2626 (fatal_error_code, fatal_error_signal_hook, standard_args):
2628 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2629 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2630 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2631 * lisp.h (fatal_error_signal_hook): Remove decl.
2632 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2634 * editfns.c: Move a (normally-unused) function to its only use.
2635 * editfns.c, lisp.h (get_operating_system_release): Remove.
2636 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2637 worth the hassle of breaking this out.
2639 * xterm.c: Make symbols static if they're not exported.
2640 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2641 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2642 (x_destroy_window, x_delete_display):
2644 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2645 (x_mouse_leave): Remove; unused.
2646 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2647 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2648 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2650 (x_mouse_leave): Declare only if WINDOWSNT.
2651 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2652 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2655 * ftxfont.c: Make symbols static if they're not exported.
2656 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2658 * font.h (ftxfont_driver): Likewise.
2660 * xfns.c: Make symbols static if they're not exported.
2661 (x_last_font_name, x_display_info_for_name):
2662 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2663 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2664 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2665 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2666 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2667 (last_show_tip_args): Now static.
2668 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2669 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2670 (x_screen_planes): Remove; unused.
2671 * dispextern.h (x_screen_planes): Remove decl.
2673 * dispnew.c: Make symbols static if they're not exported.
2674 * dispextern.h (redraw_garbaged_frames, scrolling):
2675 (increment_row_positions): Remove.
2676 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2677 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2679 (redraw_garbaged_frames): Remove; unused.
2681 * xfaces.c: Make symbols static if they're not exported.
2682 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2684 * xterm.h (defined_color): Remove decls.
2685 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2686 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2687 (menu_face_changed_default, defined_color, free_realized_face):
2688 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2689 (ascii_face_of_lisp_face): Remove; unused.
2691 * xdisp.c: Make symbols static if they're not exported.
2692 * dispextern.h (scratch_glyph_row, window_box_edges):
2693 (glyph_to_pixel_coords, set_cursor_from_row):
2694 (get_next_display_element, set_iterator_to_next):
2695 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2696 (show_mouse_face): Remove decls
2697 * frame.h (message_buf_print): Likewise.
2698 * lisp.h (pop_message, set_message, check_point_in_composition):
2700 * xterm.h (set_vertical_scroll_bar): Likewise.
2701 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2702 (message_buf_print, scratch_glyph_row, displayed_buffer):
2703 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2704 (get_next_display_element, show_mouse_face, window_box_edges):
2705 (frame_to_window_pixel_xy, check_point_in_composition):
2706 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2707 (glyph_to_pixel_coords): Remove; unused.
2709 * dired.c (file_name_completion): Now static.
2711 * dbusbind.c (xd_in_read_queued_messages): Now static.
2713 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2714 * data.c (circular_list_error): Remove.
2716 * commands.h (last_point_position, last_point_position_buffer):
2717 (last_point_position_window): Remove decls.
2718 * keyboard.c: Make these variables static.
2720 * coding.h (coding, code_convert_region, encode_coding_gap):
2722 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2723 (iso_code_class, detect_coding, code_convert_region): Now static.
2724 (encode_coding_gap): Remove; unused.
2726 * chartab.c (chartab_chars, chartab_bits): Now static.
2728 * charset.h (charset_iso_8859_1): Remove decl.
2729 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2732 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2733 * ccl.c (Vccl_program_table): Now static.
2734 (check_ccl_update): Remove; unused.
2736 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2737 * category.h: ... from here.
2738 * category.c (check_category_table, set_category_set): Now static.
2740 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2741 * lisp.h: Remove these decls.
2743 * buffer.c (buffer_count): Remove unused var.
2745 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2746 so that it's not optimized away.
2747 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2748 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2749 exported only to the debugger.
2751 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2752 * atimer.h (run_all_atimers): Remove; not exported.
2754 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2755 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2756 was inaccessible from Lisp.
2757 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2758 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2760 alloc.c: Import and export fewer symbols, and remove unused items.
2761 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2763 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2764 it's not optimized away by whole-program optimization.
2765 (message_enable_multibyte, free_misc): Remove.
2766 (catchlist, handlerlist, mark_backtrace):
2767 Declare only if BYTE_MARK_STACK.
2768 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2769 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2770 (message_enable_multibyte): Remove decl.
2771 (free_misc, interval_free_list, float_block, float_block_index):
2772 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2773 (cons_free_list, last_marked_index):
2775 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2776 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2777 (mark_backtrace): Define only if BYTE_MARK_STACK.
2778 * xdisp.c (message_enable_multibyte): Now static.
2780 Declare Lisp_Object Q* variables to be 'static' if not exported.
2781 This makes it easier for human readers (and static analyzers)
2782 to see whether these variables are used from other modules.
2783 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2784 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2785 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2786 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2787 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2788 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2789 * xmenu.c, xselect.c:
2790 Declare Q* vars static if they are not used in other modules.
2791 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2792 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2793 Remove decls of unexported vars.
2794 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2796 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2798 Make Emacs functions such as Fatom 'static' by default.
2799 This makes it easier for human readers (and static analyzers)
2800 to see whether these functions can be called from other modules.
2801 DEFUN now defines a static function. To make the function external
2802 so that it can be used in other C modules, use the new macro DEFUE.
2803 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2804 (Finit_image_library):
2805 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2806 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2807 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2808 Remove decls, since these functions are now static.
2809 (Funintern, Fget_internal_run_time): New decls, since these functions
2810 were already external.
2812 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2813 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2814 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2815 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2816 * keyboard.c, keymap.c, lread.c:
2817 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2818 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2819 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2820 Mark functions with DEFUE instead of DEFUN,
2821 if they are used in other modules.
2822 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2823 decls for now-static functions.
2824 * buffer.h (Fdelete_overlay): Remove decl.
2825 * callproc.c (Fgetenv_internal): Mark as internal.
2826 * composite.c (Fremove_list_of_text_properties): Remove decl.
2827 (Fcomposition_get_gstring): New forward static decl.
2828 * composite.h (Fcomposite_get_gstring): Remove decl.
2829 * dired.c (Ffile_attributes): New forward static decl.
2830 * doc.c (Fdocumntation_property): New forward static decl.
2831 * eval.c (Ffetch_bytecode): New forward static decl.
2832 (Funintern): Remove extern decl; now in .h file where it belongs.
2833 * fileio.c (Fmake_symbolic_link): New forward static decl.
2834 * image.c (Finit_image_library): New forward static decl.
2835 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2836 * intervals.h (Fprevious_property_change):
2837 (Fremove_list_of_text_properties): Remove decls.
2838 * keyboard.c (Fthis_command_keys): Remove decl.
2839 (Fcommand_execute): New forward static decl.
2840 * keymap.c (Flookup_key): New forward static decl.
2841 (Fcopy_keymap): Now static.
2842 * keymap.h (Flookup_key): Remove decl.
2843 * process.c (Fget_process): New forward static decl.
2844 (Fprocess_datagram_address): Mark as internal.
2845 * syntax.c (Fsyntax_table_p): New forward static decl.
2846 (skip_chars): Remove duplicate decl.
2847 * textprop.c (Fprevious_property_change): New forward static decl.
2848 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2850 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2851 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2853 * editfns.c (Fformat): Remove unreachable code.
2855 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2857 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2860 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2862 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2863 when at ZV. (Bug#8487)
2865 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2867 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2869 * keyboard.c (parse_tool_bar_item): Likewise.
2870 * sound.c (sound_cleanup, alsa_close): Likewise.
2871 * termcap.c (tgetent): Likewise.
2872 * xfns.c (x_default_font_parameter): Likewise.
2873 * xsettings.c (read_and_apply_settings): Likewise.
2875 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2876 (overrun_check_free): Protoize.
2878 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2880 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2881 since callers should never pass a negative size.
2882 Change the signature to match that of plain 'read' and 'write'; see
2883 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2884 * lisp.h: Update prototypes of emacs_write and emacs_read.
2886 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2888 * xdisp.c (redisplay_window): Don't try to determine the character
2889 position of the scroll margin if the window start point w->startp
2890 is outside the buffer's accessible region. (Bug#8468)
2892 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2894 Fix write-region and its subroutines for buffers > 2GB.
2895 * fileio.c (a_write, e_write): Modify declaration of arguments and
2896 local variables to support buffers larger than 2GB.
2897 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2899 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2900 argument, local variables, and return value.
2902 * lisp.h: Update prototypes of emacs_write and emacs_read.
2904 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2906 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2908 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2910 Fix more problems found by GCC 4.6.0's static checks.
2912 * xdisp.c (vmessage): Use a better test for character truncation.
2914 * charset.c (load_charset_map): <, not <=, for optimization,
2915 and to avoid potential problems with integer overflow.
2916 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2917 * casetab.c (set_identity, shuffle): Likewise.
2918 * editfns.c (Fformat): Likewise.
2919 * syntax.c (skip_chars): Likewise.
2921 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2922 This also lets GCC 4.6.0 generate slightly better loop code.
2924 * callint.c (Fcall_interactively): <, not <=, for optimization.
2925 (Fcall_interactively): Count the number of arguments produced,
2926 not the number of arguments given. This is simpler and lets GCC
2927 4.6.0 generate slightly better code.
2929 * ftfont.c: Distingish more carefully between FcChar8 and char.
2930 The previous code passed unsigned char * to a functions like
2931 strlen and xstrcasecmp that expect char *, which does not
2932 conform to the C standard.
2933 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2934 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2935 char * when the C standard requires it.
2937 * keyboard.c (read_char): Remove unused var.
2939 * eval.c: Port to Windows vsnprintf (Bug#8435).
2941 (SIZE_MAX): Define if the headers do not.
2942 (verror): Do not give up if vsnprintf returns a negative count.
2943 Instead, grow the buffer. This ports to Windows vsnprintf, which
2944 does not conform to C99. Problem reported by Eli Zaretskii.
2945 Also, simplify the allocation scheme, by avoiding the need for
2946 calling realloc, and removing the ALLOCATED variable.
2948 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2950 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2951 But keep the doprint source code for now, as we might revamp it
2952 and use it again (Bug#8435).
2953 * lisp.h (doprnt): Remove.
2954 * Makefile.in (base_obj): Remove doprnt.o.
2955 * deps.mk (doprnt.o): Remove.
2957 error: Print 32- and 64-bit integers portably (Bug#8435).
2958 Without this change, on typical 64-bit hosts error ("...%d...", N)
2959 was used to print both 32- and 64-bit integers N, which relied on
2961 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2963 * lisp.h (error, verror): Mark as printf-like functions.
2964 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2965 Report overflow in size calculations when allocating printf buffer.
2966 Do not truncate output string at its first null byte.
2967 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2968 Truncate the output at a character boundary, since vsnprintf does not
2970 * charset.c (check_iso_charset_parameter): Convert internal
2971 character to string before calling 'error', since %c now has the
2973 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2974 overflow when computing char to be passed to 'error'. Do not
2975 pass Lisp_Object to 'error'; pass the integer instead.
2976 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2977 formatted with plain %d.
2979 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2981 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2983 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2985 * xterm.c (x_catch_errors): Remove duplicate declaration.
2987 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2989 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2991 2011-04-10 Jim Meyering <meyering@redhat.com>
2993 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2994 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2995 return ssize_t not "int", and use size_t as the buffer length.
2996 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2997 * gnutls.h: Update declarations.
2998 * process.c (read_process_output): Use ssize_t, to match.
2999 (send_process): Likewise.
3001 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3003 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3005 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3007 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3008 Use unsigned char, to match FcChar8 type definition.
3010 * xterm.c (handle_one_xevent):
3011 * xmenu.c (create_and_show_popup_menu):
3012 * xselect.c (x_decline_selection_request)
3013 (x_reply_selection_request): Avoid type-punned deref of X events.
3015 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3017 Fix some uses of `int' instead of EMACS_INT.
3018 * search.c (string_match_1, fast_string_match)
3019 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3020 (scan_buffer, find_next_newline_no_quit)
3021 (find_before_next_newline, search_command, Freplace_match)
3022 (Fmatch_data): Make some `int' variables be EMACS_INT.
3024 * xdisp.c (display_count_lines): 3rd argument and return value now
3025 EMACS_INT. All callers changed.
3026 (pint2hrstr): Last argument is now EMACS_INT.
3028 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3029 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3030 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3031 (decode_coding_utf_16, decode_coding_emacs_mule)
3032 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3033 (decode_coding_ccl, decode_coding_charset)
3034 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3035 (decode_coding_iso_2022, decode_coding_emacs_mule)
3036 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3037 <char_offset, last_offset>: Declare EMACS_INT.
3038 (encode_coding_utf_8, encode_coding_utf_16)
3039 (encode_coding_emacs_mule, encode_invocation_designation)
3040 (encode_designation_at_bol, encode_coding_iso_2022)
3041 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3042 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3044 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3045 (encode_invocation_designation): Last argument P_NCHARS is now
3047 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3048 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3050 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3053 * ccl.c (Fccl_execute_on_string): Declare some variables
3056 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3058 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3060 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3062 * process.c (Fformat_network_address): Doc fix.
3064 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3066 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3068 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3070 * keyboard.c (read_char): Call Lisp function help-form-show,
3071 instead of using internal_with_output_to_temp_buffer.
3072 (Qhelp_form_show): New var.
3073 (syms_of_keyboard): Use DEFSYM macro.
3075 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3077 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3079 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3081 * process.c (Flist_processes): Remove to Lisp.
3082 (list_processes_1): Delete.
3084 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3086 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3088 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3090 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3092 Fix more problems found by GCC 4.6.0's static checks.
3094 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3096 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3098 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3100 * xdisp.c (vmessage): Mark as a printf-like function.
3102 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3104 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3106 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3107 printf-like functions.
3108 (tiff_load): Add casts to remove these marks before passing them
3109 to system-supplied API.
3111 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3113 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3114 This avoids several warnings with gcc -Wstrict-overflow.
3115 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3116 directly, rather than having caller test rule sign. This avoids
3117 some unnecessary tests.
3118 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3119 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3120 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3122 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3123 (xfont_open): Avoid unnecessary tests.
3125 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3127 * composite.h, composite.c (composition_gstring_put_cache):
3128 Use EMACS_INT, not int, for length.
3130 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3131 breaking out part of COMPOSITION_DECODE_RULE.
3132 (COMPOSITION_DECODE_RULE): Use it.
3133 * composite.c (get_composition_id): Remove unused local vars,
3134 by using the new macro.
3136 * textprop.c (set_text_properties_1): Change while to do-while,
3137 since the condition is always true at first.
3139 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3140 (interval_deletion_adjustment): Return unsigned value.
3143 * process.c (list_processes_1, create_pty, read_process_output):
3144 (exec_sentinel): Remove vars that were set but not used.
3145 (create_pty): Remove unnecessary "volatile"s.
3146 (Fnetwork_interface_info): Avoid possibility of int overflow.
3147 (read_process_output): Do adaptive read buffering even if carryover.
3148 (read_process_output): Simplify nbytes computation if buffered.
3150 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3152 * syntax.c (scan_words): Remove var that was set but not used.
3153 (update_syntax_table): Use unsigned instead of int.
3155 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3156 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3157 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3159 * print.c (print_error_message): Avoid int overflow.
3161 * font.c (font_list_entities): Redo for clarity,
3162 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3164 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3165 (font_score): Avoid potential overflow in diff calculation.
3167 * fns.c (substring_both): Remove var that is set but not used.
3168 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3170 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3172 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3173 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3174 can always succeed if overflow has undefined behavior.
3176 * search.c (boyer_moore, wordify): Remove vars set but not used.
3177 (wordify): Omit three unnecessary tests.
3179 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3180 All callers changed. This avoids the need for an unused var.
3182 * casefiddle.c (casify_region): Remove var that is set but not used.
3184 * dired.c (file_name_completion): Remove var that is set but not used.
3186 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3188 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3189 (Finsert_file_contents): Remove unnecessary code checking fd.
3191 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3192 Check for integer overflow on size calculations.
3194 * buffer.c (Fprevious_overlay_change): Remove var that is set
3197 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3198 Remove vars that are set but not used.
3199 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3200 (timer_check_2): Mark vars as initialized.
3202 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3204 * image.c (lookup_image): Remove var that is set but not used.
3205 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3207 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3208 that are set but not used.
3210 * xfns.c (make_invisible_cursor): Don't return garbage
3211 if XCreateBitmapFromData fails (Bug#8410).
3213 * xselect.c (x_get_local_selection, x_handle_property_notify):
3214 Remove vars that are set but not used.
3216 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3217 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3219 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3220 Remove var that is set but not used.
3221 (scroll_bar_windows_size): Now size_t, not int.
3222 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3225 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3226 (map_tty_color) [!defined MSDOS]: Likewise.
3228 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3230 * coding.c: Remove vars that are set but not used.
3231 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3232 All callers changed.
3233 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3234 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3235 (decode_coding_charset): Remove vars that are set but not used.
3237 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3238 that is set but not used.
3240 * print.c (print_object): Remove var that is set but not used.
3242 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3243 The gnulib version avoids calling malloc in the usual case,
3244 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3245 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3246 * filelock.c (current_lock_owner): Likewise.
3247 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3248 * sysdep.c: Include allocator.h, careadlinkat.h.
3249 (emacs_no_realloc_allocator): New static constant.
3250 (emacs_readlink): New function.
3251 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3252 ../lib/careadlinkat.h.
3254 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3256 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3257 first non-nil return value).
3259 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3261 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3262 if not defined (Bug#8403).
3264 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3266 * xdisp.c (display_count_lines): Remove parameter `start',
3267 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3268 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3269 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3270 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3271 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3272 and thereabouts. All callers changed.
3273 (get_per_char_metric): Remove parameter `f', unused since
3274 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3276 2011-04-02 Jim Meyering <meyering@redhat.com>
3278 do not dereference NULL upon failed strdup
3279 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3280 (ns_get_family): Likewise.
3282 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3284 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3286 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3288 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3291 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3293 Add lexical binding.
3295 * window.c (Ftemp_output_buffer_show): New fun.
3296 (Fsave_window_excursion):
3297 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3299 * lread.c (lisp_file_lexically_bound_p): New function.
3300 (Fload): Bind Qlexical_binding.
3301 (readevalloop): Remove `evalfun' arg.
3302 Bind Qinternal_interpreter_environment.
3303 (Feval_buffer): Bind Qlexical_binding.
3304 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3306 (syms_of_lread): Declare `lexical-binding'.
3308 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3310 * keyboard.c (eval_dyn): New fun.
3311 (menu_item_eval_property): Use it.
3313 * image.c (parse_image_spec): Use Ffunctionp.
3315 * fns.c (concat, mapcar1): Accept byte-code-functions.
3317 * eval.c (Fsetq): Handle lexical vars.
3318 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3319 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3320 (FletX, Flet): Obey lexical binding.
3321 (Fcommandp): Handle closures.
3322 (Feval): New `lexical' arg.
3323 (eval_sub): New function extracted from Feval. Use it almost
3324 everywhere where Feval was used. Look up vars in lexical env.
3326 (Ffunctionp): Move from subr.el.
3327 (Ffuncall): Handle closures.
3328 (apply_lambda): Remove `eval_flags'.
3329 (funcall_lambda): Handle closures and new byte-code-functions.
3330 (Fspecial_variable_p): New function.
3331 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3332 but without exporting it to Lisp.
3334 * doc.c (Fdocumentation, store_function_docstring):
3335 * data.c (Finteractive_form): Handle closures.
3337 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3340 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3342 (exec_byte_code): New function extracted from Fbyte_code to handle new
3343 calling convention for byte-code-functions. Add new byte-codes.
3345 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3347 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3349 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3351 * xdisp.c (redisplay_internal): Fix prototype.
3353 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3355 * xdisp.c (SCROLL_LIMIT): New macro.
3356 (try_scrolling): Use it when setting scroll_limit.
3357 Limit scrolling to 100 screen lines.
3358 (redisplay_window): Even when falling back on "recentering",
3359 position point in the window according to scroll-conservatively,
3360 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3362 (try_scrolling): When point is above the window, allow searching
3363 as far as scroll_max, or one screenful, to compute vertical
3364 distance from PT to the scroll margin position. This prevents
3365 try_scrolling from unnecessarily failing when
3366 scroll-conservatively is set to a value slightly larger than the
3367 window height. Clean up the case of PT below the margin at bottom
3368 of window: scroll_max can no longer be INT_MAX. When aggressive
3369 scrolling is in use, don't let point enter the opposite scroll
3370 margin as result of the scroll.
3371 (syms_of_xdisp) <scroll-conservatively>: Document the
3372 threshold of 100 lines for never-recentering scrolling.
3374 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3376 * dispextern.h (move_it_by_lines):
3377 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3378 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3379 (message_log_check_duplicate): Remove parameters `prev_bol' and
3380 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3381 (redisplay_internal): Remove parameter `preserve_echo_area',
3382 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3384 * indent.c (Fvertical_motion):
3385 * window.c (window_scroll_pixel_based, Frecenter):
3386 Don't pass `need_y_p' to `move_it_by_lines'.
3388 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3390 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3391 steal a few bits to be more compact.
3392 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3393 Remove unneeded casts.
3395 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3397 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3399 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3400 binding" message (bug#7967).
3402 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3404 Fix more problems found by GCC 4.6.0's static checks.
3406 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3407 Remove unused local var.
3409 * editfns.c (Fmessage_box): Remove unused local var.
3411 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3412 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3413 Omit unused local vars.
3414 * window.c (shrink_windows): Omit unused local var.
3415 * menu.c (digest_single_submenu): Omit unused local var.
3416 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3417 Omit unused local var.
3419 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3420 Don't assume string length fits in int.
3421 (keyremap_step, read_key_sequence): Use size_t for sizes.
3422 (read_key_sequence): Don't check last_real_key_start redundantly.
3424 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3425 instead of alloca (Bug#8344).
3427 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3428 (Fbacktrace_frame): Don't assume nframes fits in int.
3430 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3432 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3435 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3437 * cm.c (calccost): Turn while-do into do-while, for clarity.
3439 * keyboard.c (syms_of_keyboard): Use the same style as later
3440 in this function when indexing through an array. This also
3441 works around GCC bug 48267.
3443 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3445 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3447 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3448 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3450 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3451 This avoids undefined behavior on integer overflow, and is a bit
3452 more convenient anyway since it is compared to a size_t variable.
3454 Variadic C functions now count arguments with size_t, not int.
3455 This avoids an unnecessary limitation on 64-bit machines, which
3456 caused (substring ...) to crash on large vectors (Bug#8344).
3457 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3458 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3459 All variadic functions and their callers changed accordingly.
3460 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3461 * data.c (arith_driver, float_arith_driver): Likewise.
3462 * editfns.c (general_insert_function): Likewise.
3463 * eval.c (struct backtrace.nargs, interactive_p)
3464 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3465 (funcall_lambda, mark_backtrace): Likewise.
3466 * fns.c (concat): Likewise.
3467 * frame.c (x_set_frame_parameters): Likewise.
3468 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3469 0 if not found, not -1. All callers changed.
3471 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3472 (stack_copy_size): Now size_t, not int.
3473 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3475 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3477 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3478 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3479 All callers changed.
3481 * lisp.h (multibyte_char_to_unibyte):
3482 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3483 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3484 * character.h (CHAR_TO_BYTE8):
3485 * cmds.c (internal_self_insert):
3486 * editfns.c (general_insert_function):
3487 * keymap.c (push_key_description):
3488 * search.c (Freplace_match):
3489 * xdisp.c (message_dolog, set_message_1): All callers changed.
3491 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3493 * keyboard.c (safe_run_hook_funcall): New function.
3494 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3495 don't set the hook to nil, but remove the offending function instead.
3496 (Qcommand_hook_internal): Remove, unused.
3497 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3498 Vcommand_hook_internal.
3500 * eval.c (enum run_hooks_condition): Remove.
3501 (funcall_nil, funcall_not): New functions.
3502 (run_hook_with_args): Call each function through a `funcall' argument.
3503 Remove `cond' argument, now redundant.
3504 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3505 (Frun_hook_with_args_until_failure): Adjust accordingly.
3506 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3508 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3510 * dispextern.h (string_buffer_position): Remove declaration.
3512 * print.c (strout): Remove parameter `multibyte', unused since
3513 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3515 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3516 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3517 All callers changed.
3519 * w32.c (_wsa_errlist): Use braces for struct initializers.
3521 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3522 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3523 All callers changed.
3524 (string_buffer_position): Likewise. Also, make static (it's never
3525 used outside xdisp.c).
3526 (cursor_row_p): Remove parameter `w', unused since
3527 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3528 (decode_mode_spec): Remove parameter `precision', introduced during
3529 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3530 All callers changed.
3532 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3534 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3536 2011-03-27 Anders Lindgren <andlind@gmail.com>
3538 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3539 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3540 (ns_update_auto_hide_menu_bar): New functions.
3541 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3542 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3543 ns_constrain_all_frames.
3544 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3545 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3547 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3549 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3551 2011-03-27 Glenn Morris <rgm@gnu.org>
3553 * syssignal.h: Replace RETSIGTYPE with void.
3554 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3555 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3556 Replace SIGTYPE with void everywhere.
3557 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3558 * s/template.h (SIGTYPE): Remove commented out definition.
3560 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3562 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3563 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3565 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3567 * w32.c (read_unc_volume): Use parameter `henum', instead of
3568 global variable `wget_enum_handle'.
3570 * keymap.c (describe_vector): Remove parameters `indices' and
3571 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3572 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3574 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3576 * keyboard.c (timer_check): Remove parameter `do_it_now',
3577 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3578 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3579 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3581 * keyboard.c (read_char):
3582 * w32menu.c (w32_menu_display_help):
3583 * xmenu.c (show_help_event, menu_help_callback):
3584 Adjust calls to `show_help_echo'.
3586 * gtkutil.c (xg_maybe_add_timer):
3587 * keyboard.c (readable_events):
3588 * process.c (wait_reading_process_output):
3589 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3591 * insdel.c (adjust_markers_gap_motion):
3592 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3593 (gap_left, gap_right): Don't call it.
3595 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3597 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3598 incurred during fontification.
3600 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3602 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3603 (DEFVAR_PER_BUFFER): Don't pass it.
3605 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3606 (scrolling_window): Don't pass it.
3608 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3610 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3612 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3614 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3615 of variables specific to SELinux and computation of `encoded_absname'.
3617 * image.c (XPutPixel): Remove unused variable `height'.
3619 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3621 * unexw32.c (get_section_info): Remove unused variable `section'.
3623 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3624 (system_process_attributes): Remove unused variable `sess'.
3625 (sys_read): Remove unused variable `err'.
3627 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3628 (w32_wnd_proc): Remove unused variable `isdead'.
3629 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3630 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3631 (x_create_tip_frame): Remove unused variable `tem'.
3633 * w32inevt.c (w32_console_read_socket):
3634 Remove unused variable `no_events'.
3636 * w32term.c (x_draw_composite_glyph_string_foreground):
3637 Remove unused variable `width'.
3639 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3641 * w32term.c (x_set_glyph_string_clipping):
3642 Don't pass uninitialized region to CombineRgn.
3644 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3646 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3647 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3648 (Fx_close_connection): Remove unused variable `i'.
3650 * w32font.c (w32font_draw): Return number of glyphs.
3651 (w32font_open_internal): Remove unused variable `i'.
3652 (w32font_driver): Add missing initializer.
3654 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3655 (fill_in_menu): Remove unused variable `items_added'.
3657 * w32term.c (last_mouse_press_frame): Remove static global variable.
3658 (w32_clip_to_row): Remove unused variable `f'.
3659 (x_delete_terminal): Remove unused variable `i'.
3661 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3662 (NOTHING): Remove unused static global variable.
3663 (uniscribe_check_otf): Remove unused variable `table'.
3664 (uniscribe_font_driver): Add missing initializers.
3666 2011-03-23 Julien Danjou <julien@danjou.info>
3668 * term.c (Fsuspend_tty, Fresume_tty):
3669 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3670 * window.c (temp_output_buffer_show):
3671 * insdel.c (signal_before_change):
3672 * frame.c (Fhandle_switch_frame):
3673 * fileio.c (Fdo_auto_save):
3674 * emacs.c (Fkill_emacs):
3675 * editfns.c (save_excursion_restore):
3676 * cmds.c (internal_self_insert):
3677 * callint.c (Fcall_interactively):
3678 * buffer.c (Fkill_all_local_variables):
3679 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3681 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3682 unconditionnaly since it does the check itself.
3684 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3686 Fix more problems found by GCC 4.5.2's static checks.
3688 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3689 the first time through the loop, since we know p0 < p1 then.
3690 This also avoids a gcc -Wstrict-overflow warning.
3692 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3693 leading to a memory leak, possible in functions like
3694 load_charset_map_from_file that can allocate an unbounded number
3695 of objects (Bug#8318).
3697 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3698 that could (at least in theory) be that large.
3700 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3701 This is less likely to overflow, and avoids undefined behavior if
3702 overflow does occur. All callers changed. Use strtoul to scan
3703 for the unsigned long integer.
3704 (pint2hrstr): Simplify and tune code slightly.
3705 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3707 * scroll.c (do_scrolling): Work around GCC bug 48228.
3708 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3710 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3711 This also avoids a warning with gcc -Wstrict-overflow.
3712 (validate_x_resource_name): Simplify count usage.
3713 This also avoids a warning with gcc -Wstrict-overflow.
3715 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3718 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3720 * process.c (Fmake_network_process): Use socklen_t, not int,
3721 where POSIX says socklen_t is required in portable programs.
3722 This fixes a porting bug on hosts like 64-bit HP-UX, where
3723 socklen_t is wider than int (Bug#8277).
3724 (Fmake_network_process, server_accept_connection):
3725 (wait_reading_process_output, read_process_output):
3728 * process.c: Rename or move locals to avoid shadowing.
3729 (list_processes_1, Fmake_network_process):
3730 (read_process_output_error_handler, exec_sentinel_error_handler):
3731 Rename or move locals.
3732 (Fmake_network_process): Define label "retry_connect" only if needed.
3733 (Fnetwork_interface_info): Fix pointer signedness.
3734 (process_send_signal): Add cast to avoid pointer signedness problem.
3735 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3736 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3738 Make tparam.h and terminfo.c consistent.
3739 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3740 Include tparam.h instead, since it declares them.
3741 * cm.h (PC): Remove extern decl; tparam.h now does this.
3742 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3743 * terminfo.c: Include tparam.h, to check interfaces.
3744 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3745 (tparam): Adjust signature to match interface in tparam.h;
3746 this removes some undefined behavior. Check that outstring and len
3747 are zero, which they always are with Emacs.
3748 * tparam.h (PC, BC, UP): New extern decls.
3750 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3751 (xftfont_open): Rename locals to avoid shadowing.
3753 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3754 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3755 (OTF_TAG_SYM): Omit macro if not needed.
3756 (ftfont_list): Remove unused local.
3757 (get_adstyle_property, ftfont_pattern_entity):
3758 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3759 Rename locals to avoid shadowing.
3761 * xfont.c (xfont_list_family): Mark var as initialized.
3763 * xml.c (make_dom): Now static.
3765 * composite.c (composition_compute_stop_pos): Rename local to
3767 (composition_reseat_it): Remove unused locals.
3768 (find_automatic_composition, composition_adjust_point): Likewise.
3769 (composition_update_it): Mark var as initialized.
3770 (find_automatic_composition): Mark vars as initialized,
3771 with a FIXME (Bug#8290).
3773 character.h: Rename locals to avoid shadowing.
3774 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3775 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3776 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3777 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3780 * textprop.c (property_change_between_p): Remove; unused.
3782 * intervals.c (interval_start_pos): Now static.
3784 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3786 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3787 Rename locals to avoid shadowing.
3789 * sound.c (wav_play, au_play, Fplay_sound_internal):
3790 Fix pointer signedness.
3791 (alsa_choose_format): Remove unused local var.
3792 (wav_play): Initialize a variable to 0, to prevent undefined
3793 behavior (Bug#8278).
3795 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3797 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3799 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3800 clobbering (Bug#8298).
3801 * sysdep.c (sys_subshell): Likewise.
3802 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3804 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3805 This should get cleaned up, so that child_setup has the
3806 same signature on all platforms.
3808 * callproc.c (call_process_cleanup): Now static.
3809 (relocate_fd): Rename locals to avoid shadowing.
3811 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3813 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3814 not to be necessary, and produces flickering.
3816 2011-03-20 Glenn Morris <rgm@gnu.org>
3818 * config.in: Remove file.
3820 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3822 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3823 are now in src/globals.h.
3824 (syms_of_minibuf): Remove spurious & from previous change.
3826 2011-03-20 Leo <sdl.web@gmail.com>
3828 * minibuf.c (completing-read-function): New variable.
3829 (completing-read-default): Rename from completing-read.
3830 (completing-read): Call completing-read-function.
3832 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3834 * xfaces.c (Fx_load_color_file):
3835 Read color file from absolute filename (bug#8250).
3837 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3839 * makefile.w32-in: Update dependencies.
3841 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3843 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3845 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3847 Fix more problems found by GCC 4.5.2's static checks.
3849 * process.c (make_serial_process_unwind, send_process_trap):
3850 (sigchld_handler): Now static.
3852 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3853 That way, the code declares only the vars that it needs.
3854 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3855 * s/cygwin.h (PTY_ITERATION): Likewise.
3856 * s/darwin.h (PTY_ITERATION): Likewise.
3857 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3859 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3860 * process.c (allocate_pty): Don't declare stb unless it's needed.
3862 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3863 (CONSTANTLIM): Remove; unused.
3864 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3865 Define only if needed.
3867 * unexelf.c (unexec): Name an expression,
3868 to avoid gcc -Wbad-function-cast warning.
3869 Use a different way to cause a compilation error if anyone uses
3870 n rather than nn, a way that does not involve shadowing.
3871 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3873 * deps.mk (unexalpha.o): Remove; unused.
3875 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3876 * unexec.h: New file.
3877 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3878 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3880 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3881 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3882 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3883 Change as necessary to match prototype in unexec.h.
3885 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3887 (back_comment, skip_chars): Mark vars as initialized.
3889 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3890 Rename locals to avoid shadowing.
3892 * lread.c (read1): Rewrite so as not to use empty "else".
3893 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3895 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3897 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3898 warning when compiling print.c.
3900 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3901 instead of using an uninitialized var.
3902 (font_sort_entities): Mark var as initialized.
3904 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3906 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3907 pointers to constants.
3908 (font_parse_fcname): Remove unused vars.
3909 (font_delete_unmatched): Now static.
3910 (font_get_spec): Remove; unused.
3911 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3912 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3913 Rename or move locals to avoid shadowing.
3915 * fns.c (require_nesting_list, require_unwind): Now static.
3916 (Ffillarray): Rename locals to avoid shadowing.
3918 * floatfns.c (domain_error2): Define only if needed.
3919 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3921 * alloc.c (mark_backtrace): Move decl from here ...
3922 * lisp.h: ... to here, so that it can be checked.
3924 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3925 (Fdefvar): Rewrite so as not to use empty "else".
3926 (lisp_indirect_variable): Name an expression,
3927 to avoid gcc -Wbad-function-cast warning.
3928 (Fdefvar): Rename locals to avoid shadowing.
3930 * callint.c (quotify_arg, quotify_args): Now static.
3931 (Fcall_interactively): Rename locals to avoid shadowing.
3932 Use const pointer when appropriate.
3934 * lisp.h (get_system_name, get_operating_system_release):
3935 Move decls here, to check interfaces.
3936 * process.c (get_operating_system_release): Move decl to lisp.h.
3937 * xrdb.c (get_system_name): Likewise.
3938 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3939 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3940 some of which prompt warnings from gcc -Wbad-function-cast.
3941 (Fformat_time_string, Fencode_time, Finsert_char):
3942 (Ftranslate_region_internal, Fformat):
3943 Rename or remove local vars to avoid shadowing.
3944 (Ftranslate_region_internal): Mark var as initialized.
3946 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3949 * lisp.h (eassert): Check that the argument compiles, even if
3950 ENABLE_CHECKING is not defined.
3952 * data.c (Findirect_variable): Name an expression, to avoid
3953 gcc -Wbad-function-cast warning.
3954 (default_value, arithcompare, arith_driver, arith_error): Now static.
3955 (store_symval_forwarding): Rename local to avoid shadowing.
3956 (Fmake_variable_buffer_local, Fmake_local_variable):
3957 Mark variables as initialized.
3958 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3960 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3961 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3962 Rename locals to avoid shadowing.
3963 (mark_stack): Move local variables into the #ifdef region where
3965 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3966 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3968 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3969 (GC_STRING_CHARS): Remove; not used.
3970 (Fmemory_limit): Cast sbrk's returned value to char *.
3972 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3973 avoids undefined behavior in theory.
3975 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3977 Use functions, not macros, for up- and down-casing (Bug#8254).
3978 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3979 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3980 to use the following functions instead of these macros.
3981 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3982 EMACS_INT, since callers assume the returned value fits in int.
3983 (upcase1): Likewise, for UPCASE_TABLE.
3984 (uppercasep, lowercasep, upcase): New static inline functions.
3985 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3986 the race-condition problem in the old DOWNCASE.
3988 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3989 Rename locals to avoid shadowing.
3990 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3991 (regex_compile, re_search_2, re_match_2_internal):
3992 Remove unused local vars.
3993 (FREE_VAR): Rewrite so as not to use empty "else",
3994 which gcc can warn about.
3995 (regex_compile, re_match_2_internal): Mark locals as initialized.
3996 (RETALLOC_IF): Define only if needed.
3997 (WORDCHAR_P): Likewise. This one is never needed, but is used
3998 only in a comment talking about a compiler bug, so put inside
3999 the #if 0 of that comment.
4000 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4001 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4004 * search.c (boyer_moore): Rename locals to avoid shadowing.
4005 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4006 (PREV_CHAR_BOUNDARY): Likewise.
4008 * search.c (simple_search): Remove unused var.
4010 * dired.c (compile_pattern): Move decl from here ...
4011 * lisp.h: ... to here, so that it can be checked.
4012 (struct re_registers): New forward decl.
4014 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4016 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4018 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4019 Rename locals to avoid shadowing.
4020 (Fvertical_motion): Mark locals as initialized.
4022 * casefiddle.c (casify_object, casify_region): Now static.
4023 (casify_region): Mark local as initialized.
4025 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4027 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4028 New macros, so that the caller can use some names other than
4029 gcpro1, gcpro2, etc.
4030 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4032 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4033 argument, for consistency with GCPRO2_VAR, etc: it is now the
4034 prefix of the variable, not the variable itself. All uses
4036 * dired.c (directory_files_internal, file_name_completion):
4037 Rename locals to avoid shadowing.
4039 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4040 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4041 dired.c's scmp function, had undefined behavior.
4042 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4043 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4044 * buffer.h: ... to here, because these macros use current_buffer,
4045 and the new implementation with inline functions needs to have
4046 current_buffer in scope now, rather than later when the macros
4048 (downcase, upcase1): New static inline functions.
4049 (DOWNCASE, UPCASE1): Reimplement using these functions.
4050 This avoids undefined behavior in expressions like
4051 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4052 from race conditions in accessing the global variables
4053 case_temp1 and case_temp2.
4054 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4055 * lisp.h (case_temp1, case_temp2): Remove their decls.
4056 * character.h (ASCII_CHAR_P): Move from here ...
4057 * lisp.h: ... to here, so that the inline functions mentioned
4060 * dired.c (directory_files_internal_unwind): Now static.
4062 * fileio.c (file_name_as_directory, directory_file_name):
4063 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4065 (file_name_as_directory): Use const pointers when appropriate.
4066 (Fexpand_file_name): Likewise. In particular, newdir might
4067 point at constant storage, so make it a const pointer.
4068 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4069 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4071 (Fset_file_times, Finsert_file_contents, auto_save_error):
4072 Rename locals to avoid shadowing.
4074 * minibuf.c (choose_minibuf_frame_1): Now static.
4075 (Ftry_completion, Fall_completions): Rename or remove locals
4078 * marker.c (bytepos_to_charpos): Remove; unused.
4080 * lisp.h (verify_bytepos, count_markers): New decls,
4081 so that gcc does not warn that these functions aren't declared.
4083 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4084 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4085 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4086 (copy_text): Remove unused local var.
4088 * filelock.c (within_one_second): Now static.
4089 (lock_file_1): Rename local to avoid shadowing.
4091 * buffer.c (fix_overlays_before): Mark locals as initialized.
4092 (fix_start_end_in_overlays): Likewise. This function should be
4093 simplified by using pointers-to-pointers, but that's a different
4095 (switch_to_buffer_1): Now static.
4096 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4097 (report_overlay_modification): Rename locals to avoid shadowing.
4099 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4100 Fix pointer signedness issue.
4101 (sys_subshell): Mark local as volatile if checking for lint,
4102 to suppress a gcc -Wclobbered warning that does not seem to be right.
4103 (MAXPATHLEN): Define only if needed.
4105 * process.c (serial_open, serial_configure): Move decls from here ...
4106 * systty.h: ... to here, so that they can be checked.
4108 * fns.c (get_random, seed_random): Move extern decls from here ...
4109 * lisp.h: ... to here, so that they can be checked.
4111 * sysdep.c (reset_io): Now static.
4112 (wait_for_termination_signal): Remove; unused.
4114 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4115 (copy_keymap_item, append_key, push_text_char_description):
4117 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4118 (DENSE_TABLE_SIZE): Remove; unused.
4119 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4120 (describe_map_tree):
4121 Rename locals to avoid shadowing.
4123 * keyboard.c: Declare functions static if they are not used elsewhere.
4124 (echo_char, echo_dash, cmd_error, top_level_2):
4125 (poll_for_input, handle_async_input): Now static.
4126 (read_char, kbd_buffer_get_event, make_lispy_position):
4127 (make_lispy_event, make_lispy_movement, apply_modifiers):
4128 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4129 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4130 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4131 (read_key_sequence, read_char): Mark locals as initialized.
4132 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4134 * keyboard.h (make_ctrl_char): New decl.
4135 (mark_kboards): Move decl here ...
4136 * alloc.c (mark_kboards): ... from here.
4138 * lisp.h (force_auto_save_soon): New decl.
4140 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4141 (DEFINE_DUMMY_FUNCTION): New macro.
4142 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4144 (main): Add casts to avoid warnings
4145 if GCC considers string literals to be constants.
4147 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4149 * dbusbind.c: Pointer signedness fixes.
4150 (xd_signature, xd_append_arg, xd_initialize):
4151 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4152 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4153 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4154 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4156 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4157 if GCC considers string literals to be constants.
4158 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4160 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4162 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4163 (print_preprocess, print_object): New macro to fix last change.
4165 * print.c (print_preprocess): Don't forget font objects.
4167 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4169 * emacs.c (USAGE3): Doc fixes.
4171 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4173 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4176 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4178 * lisp.h (VWindow_system, Qfile_name_history):
4179 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4180 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4181 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4183 * w32select.c: Don't #include "keyboard.h".
4184 (run_protected): Add extern declaration for waiting_for_input.
4186 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4187 * w32console.c (detect_input_pending, read_input_pending)
4188 (encode_terminal_code):
4189 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4190 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4191 (w32_system_caret_y, Qfile_name_history):
4192 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4193 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4194 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4195 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4196 * w32proc.c (Qlocal, report_file_error):
4197 * w32term.c (Vwindow_system, updating_frame):
4198 * w32uniscribe.c (initialized, uniscribe_font_driver):
4199 Remove unneeded extern declarations.
4201 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4203 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4205 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4207 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4208 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4209 These macros can no longer be used for assignment.
4211 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4212 Assign struct members directly, instead of using BUF_BEGV etc.
4213 (record_buffer_markers, fetch_buffer_markers): New functions for
4214 recording and fetching special buffer markers.
4215 (set_buffer_internal_1, set_buffer_temp): Use them.
4217 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4219 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4221 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4222 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4224 * xdisp.c (hscroll_window_tree):
4225 (reconsider_clip_changes): Use PT instead of BUF_PT.
4227 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4229 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4230 $(EMACS_ROOT)/lib/intprops.h.
4232 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4234 Fix more problems found by GCC 4.5.2's static checks.
4236 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4237 to unsigned char * to avoid compiler diagnostic.
4238 (xg_free_frame_widgets): Make it clear that a local variable is
4239 needed only if USE_GTK_TOOLTIP.
4240 (gdk_window_get_screen): Make it clear that this macro is needed
4241 only if USE_GTK_TOOLTIP.
4242 (int_gtk_range_get_value): New function, which avoids a diagnostic
4243 from gcc -Wbad-function-cast.
4244 (xg_set_toolkit_scroll_bar_thumb): Use it.
4245 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4246 diagnostic from gcc -Wbad-function-cast.
4247 (get_utf8_string, xg_get_file_with_chooser):
4248 Rename locals to avoid shadowing.
4249 (create_dialog): Move locals to avoid shadowing.
4251 * xgselect.c (xg_select): Remove unused var.
4253 * image.c (four_corners_best): Mark locals as initialized.
4254 (gif_load): Initialize transparent_p to zero (Bug#8238).
4255 Mark another local as initialized.
4256 (my_png_error, my_error_exit): Mark with NO_RETURN.
4258 * image.c (clear_image_cache): Now static.
4259 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4260 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4261 (x_edge_detection): Remove unnecessary cast that
4262 gcc -Wbad-function-cast diagnoses.
4263 (gif_load): Fix pointer signedness.
4264 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4265 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4267 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4269 Improve quality of tests for time stamp overflow.
4270 For example, without this patch (encode-time 0 0 0 1 1
4271 1152921504606846976) returns the obviously-bogus value (-948597
4272 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4273 reports time overflow. See
4274 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4275 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4276 * editfns.c: Include limits.h and intprops.h.
4277 (TIME_T_MIN, TIME_T_MAX): New macros.
4278 (time_overflow): Move earlier, to before first use.
4279 (hi_time, lo_time): New functions, for an accurate test for
4281 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4282 (Fget_internal_run_time): Don't assume time_t fits in int.
4283 (make_time): Use list2 instead of Fcons twice.
4284 (Fdecode_time): More accurate test for out-of-range times.
4285 (check_tm_member): New function.
4286 (Fencode_time): Use it, to test for out-of-range times.
4287 (lisp_time_argument): Don't rely on undefined left-shift and
4288 right-shift behavior when checking for time stamp overflow.
4290 * editfns.c (time_overflow): New function, refactoring common code.
4291 (Fformat_time_string, Fdecode_time, Fencode_time):
4292 (Fcurrent_time_string): Use it.
4294 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4295 * dired.c (make_time): Move to ...
4296 * editfns.c (make_time): ... here.
4297 * systime.h: Note the move.
4299 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4301 * fringe.c (update_window_fringes): Remove unused variables.
4303 * unexmacosx.c (copy_data_segment): Also copy __got section.
4306 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4308 * termcap.c [MSDOS]: Include "msdos.h".
4309 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4310 Constify `char *' arguments and their references according to
4311 prototypes in tparam.h.
4313 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4315 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4316 Adapt all references accordingly.
4318 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4320 2011-03-11 Tom Tromey <tromey@redhat.com>
4322 * buffer.c (syms_of_buffer): Remove obsolete comment.
4324 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4326 * termhooks.h (encode_terminal_code): Declare prototype.
4328 * msdos.c (encode_terminal_code): Don't declare prototype.
4330 * term.c (encode_terminal_code): Now external again, used by
4331 w32console.c and msdos.c.
4333 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4334 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4336 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4338 Fix some minor problems found by GCC 4.5.2's static checks.
4340 * fringe.c (update_window_fringes): Mark locals as initialized
4342 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4344 * alloc.c (mark_fringe_data): Move decl from here ...
4345 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4346 to check its interface.
4347 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4349 * fontset.c (free_realized_fontset): Now static.
4350 (Fset_fontset_font): Rename local to avoid shadowing.
4351 (fontset_font): Mark local as initialized.
4352 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4354 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4356 * xselect.c (x_disown_buffer_selections): Remove; not used.
4357 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4358 (x_own_selection, Fx_disown_selection_internal): Rename locals
4360 (x_handle_dnd_message): Remove local to avoid shadowing.
4362 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4363 so that the caller can use some name other than gcpro1.
4364 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4365 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4366 (Fx_backspace_delete_keys_p):
4367 Use them to avoid shadowing, and rename vars to avoid shadowing.
4368 (x_decode_color, x_set_name, x_window): Now static.
4369 (Fx_create_frame): Add braces to silence GCC warning.
4370 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4371 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4372 Remove unused locals.
4373 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4374 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4375 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4378 * xterm.h (x_mouse_leave): New decl.
4380 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4381 Remove unused functions.
4382 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4383 (x_calc_absolute_position): Now static.
4384 (XTread_socket): Don't define label "out" unless it's used.
4385 Don't declare local "event" unless it's used.
4386 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4387 unless they are used.
4388 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4389 (x_fatal_error_signal): Remove; not used.
4390 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4391 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4392 (x_error_catcher, x_connection_closed, x_error_handler):
4393 (x_error_quitter, xembed_send_message, x_iconify_frame):
4394 (my_log_handler): Rename locals to avoid shadowing.
4395 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4396 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4398 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4399 Rename or move locals to avoid shadowing.
4400 (tty_defined_color, merge_face_heights): Now static.
4401 (free_realized_faces_for_fontset): Remove; not used.
4402 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4403 does not deduce is never used uninitialized.
4404 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4405 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4407 * terminal.c (store_terminal_param): Now static.
4409 * xmenu.c (menu_highlight_callback): Now static.
4410 (set_frame_menubar): Remove unused local.
4411 (xmenu_show): Rename parameter to avoid shadowing.
4412 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4413 since they might point to immutable storage.
4414 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4415 since it's unused otherwise.
4417 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4418 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4419 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4420 avoids a gcc -Wuninitialized diagnostic.
4421 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4422 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4423 does not deduce are never used uninitialized.
4425 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4427 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4428 * window.c (window_loop, size_window):
4429 (run_window_configuration_change_hook, enlarge_window): Likewise.
4431 * window.c (display_buffer): Now static.
4432 (size_window): Mark variables that gcc -Wuninitialized
4433 does not deduce are never used uninitialized.
4434 * window.h (check_all_windows): New decl, to forestall
4435 gcc -Wmissing-prototypes diagnostic.
4436 * dispextern.h (bidi_dump_cached_states): Likewise.
4438 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4440 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4442 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4443 and to avoid gcc -Wuninitialized warning.
4444 (load_charset_map): Mark variables that gcc -Wuninitialized
4445 does not deduce are never used uninitialized.
4446 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4448 * coding.c (coding_set_source, coding_set_destination):
4449 Use "else { /* comment */ }" rather than "else /* comment */;"
4450 for clarity, and to avoid gcc -Wempty-body warning.
4451 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4452 a block, when the outer 'i' will do.
4453 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4454 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4455 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4456 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4457 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4458 Rename locals to avoid shadowing.
4459 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4460 * coding.c (emacs_mule_char, encode_invocation_designation):
4461 Now static, since they're not used elsewhere.
4462 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4463 (decode_coding_object, encode_coding_object, detect_coding_system):
4464 (decode_coding_emacs_mule): Mark variables that gcc
4465 -Wuninitialized does not deduce are never used uninitialized.
4466 (detect_coding_iso_2022): Initialize a local variable that might
4467 be used uninitialized. Leave a FIXME because it's not clear that
4468 this initialization is needed. (Bug#8211)
4469 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4470 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4471 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4472 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4473 Remove unused macros.
4475 * category.c (hash_get_category_set): Remove unused local var.
4476 (copy_category_table): Now static, since it's not used elsewhere.
4477 * character.c (string_count_byte8): Likewise.
4479 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4480 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4482 * chartab.c (copy_sub_char_table): Now static, since it's not used
4484 (sub_char_table_ref_and_range, char_table_ref_and_range):
4485 Rename locals to avoid shadowing.
4486 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4488 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4489 (BIDI_BOB): Remove unused macro.
4491 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4492 deduce are never used uninitialized.
4493 * term.c (encode_terminal_code): Likewise.
4495 * term.c (encode_terminal_code): Now static. Remove unused local.
4497 * tparam.h: New file.
4498 * term.c, tparam.h: Include it.
4499 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4500 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4501 Move these decls to tparam.h, and make them agree with what
4502 is actually in tparam.c. The previous trick of using incompatible
4503 decls in different modules does not conform to the C standard.
4504 All callers of tparam changed to use tparam's actual API.
4505 * tparam.c (tparam1, tparam, tgoto):
4506 Use const pointers where appropriate.
4508 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4509 * cm.h (struct cm): Likewise.
4510 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4511 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4512 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4513 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4514 (turn_on_face, init_tty): Likewise.
4515 * termchar.h (struct tty_display_info): Likewise.
4517 * term.c (term_mouse_position): Rename local to avoid shadowing.
4519 * alloc.c (mark_ttys): Move decl from here ...
4520 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4522 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4524 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4526 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4528 * search.c (compile_pattern_1): Remove argument regp, unused since
4529 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4530 (compile_pattern): Don't pass it.
4532 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4534 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4535 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4537 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4539 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4541 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4542 gdk_window_get_screen, gdk_window_get_geometry,
4543 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4544 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4545 (xg_get_pixbuf_from_pixmap): New function.
4546 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4547 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4548 Call xg_get_pixbuf_from_pixmap instead of
4549 gdk_pixbuf_get_from_drawable.
4550 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4551 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4552 (xg_check_special_colors): Use GtkStyleContext and its functions
4554 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4555 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4556 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4557 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4558 Call gtk_widget_get_preferred_size.
4559 (xg_frame_resized): gdk_window_get_geometry only takes 5
4561 (xg_win_to_widget, xg_event_is_for_menubar):
4562 Call gdk_x11_window_lookup_for_display.
4563 (xg_set_widget_bg): New function.
4564 (delete_cb): New function.
4565 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4566 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4567 (xg_set_background_color): Call xg_set_widget_bg.
4568 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4569 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4570 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4571 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4573 (update_frame_tool_bar): Call gtk_widget_hide.
4574 (xg_initialize): Use GDK_KEY_g.
4576 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4578 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4580 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4581 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4582 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4584 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4586 * w32xfns.c (select_palette): Check success of RealizePalette against
4587 GDI_ERROR, not zero.
4589 See ChangeLog.11 for earlier changes.
4595 Copyright (C) 2011 Free Software Foundation, Inc.
4597 This file is part of GNU Emacs.
4599 GNU Emacs is free software: you can redistribute it and/or modify
4600 it under the terms of the GNU General Public License as published by
4601 the Free Software Foundation, either version 3 of the License, or
4602 (at your option) any later version.
4604 GNU Emacs is distributed in the hope that it will be useful,
4605 but WITHOUT ANY WARRANTY; without even the implied warranty of
4606 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4607 GNU General Public License for more details.
4609 You should have received a copy of the GNU General Public License
4610 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.