1 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
5 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
7 * doprnt.c (doprnt): Truncate multibyte char correctly.
8 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
9 would mishandle a string argument "Xc" if X was a multibyte
10 character of length 2: it would truncate after X's first byte
11 rather than including all of X.
13 2012-06-06 Chong Yidong <cyd@gnu.org>
15 * buffer.c (word_wrap): Doc fix.
17 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
19 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
21 2012-06-03 Glenn Morris <rgm@gnu.org>
23 * xdisp.c (tool-bar-style): Doc fix.
25 2012-06-03 Ulrich Müller <ulm@gentoo.org>
27 * Makefile.in (PAXCTL): Define.
28 (temacs$(EXEEXT)): Disable memory randomization for the temacs
29 binary via PaX flags if the paxctl utility is available.
30 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
31 Restore PaX flags to their default. (Bug#11398)
33 2012-06-03 Chong Yidong <cyd@gnu.org>
35 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
38 2012-06-03 Chong Yidong <cyd@gnu.org>
40 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
41 (note_mode_line_or_margin_highlight): If there is no help echo,
42 use mode-line-default-help-echo. Handle the case where the mouse
43 position is past the end of the mode line string.
45 * buffer.c (buffer_local_value_1): New function, split from
46 Fbuffer_local_value; can return Qunbound.
47 (Fbuffer_local_value): Use it.
48 (Vmode_line_format): Docstring tweaks.
50 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
52 * sysdep.c (system_process_attributes): Improve comment.
54 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
56 * keyboard.c: Export real-this-command to Elisp.
57 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
58 and DEFVAR it. Update all users.
60 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
62 * minibuf.c (Fassoc_string): Remove duplicate declaration.
64 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
65 Convert pctcpu and pctmem to Lisp float properly.
66 Let the compiler fold better, as 100.0/0x8000 is exact.
68 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
70 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
73 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
75 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
77 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
79 For a 'struct window', replace some Lisp_Object fields to
80 bitfields where appropriate, remove unused fields.
81 * window.h (struct window): Remove unused 'last_mark_x' and
82 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
83 change it's type from Lisp_Object to bitfield.
84 Change type of 'force_start', 'optional_new_start',
85 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
86 fields from Lisp_Object to bitfield. Adjust users accordingly.
88 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
90 Pacify gcc -Wdouble-precision when using Xaw.
91 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
92 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
93 Use 'float' consistently, rather than 'float' in most places
94 and 'double' in a couple of places.
96 2012-05-31 Eli Zaretskii <eliz@gnu.org>
98 * xdisp.c (handle_stop): Detect whether we have overlay strings
99 loaded by testing it->current.overlay_string_index to be
100 non-negative, instead of checking whether n_overlay_strings is
101 positive. (Bug#11587)
103 2012-05-31 Chong Yidong <cyd@gnu.org>
105 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
107 * doc.c (Fsubstitute_command_keys): Doc fix.
109 2012-05-31 Eli Zaretskii <eliz@gnu.org>
111 * search.c (search_buffer): Remove calls to
112 r_alloc_inhibit_buffer_relocation, as it is now called by
113 maybe_unify_char, which was the cause of relocation of buffer text
116 2012-05-31 Eli Zaretskii <eliz@gnu.org>
118 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
119 for the duration of call to load_charset, to avoid problems with
120 callers of maybe_unify_char that access buffer text through C
123 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
124 decrement the inhibition flag, instead of just setting or
127 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
129 Remove obsolete '#define static' cruft.
130 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
131 This #undef was "temporary" in 2000; it is no longer needed
132 now that '#define static' has gone away.
133 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
134 (gray_bitmap_bits): Remove; no longer needed.
135 All uses replaced with definiens.
136 * xterm.c: Include "bitmaps/gray.xbm".
138 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
140 Clean up __executable_start, monstartup when --enable-profiling.
141 The following changes affect the code only when profiling.
142 * dispnew.c (__executable_start): Rename from safe_bcopy.
143 Define only on platforms that need it.
144 * emacs.c: Include <sys/gmon.h> when profiling.
145 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
146 (__executable_start): Remove decl, since lisp.h does it now.
147 (safe_bcopy): Remove decl; no longer has that name.
148 (main): Coalesce #if into single bit of code, for simplicity.
149 Cast pointers to uintptr_t, since standard libraries want integers
151 * lisp.h (__executable_start): New decl.
153 2012-05-31 Glenn Morris <rgm@gnu.org>
155 * image.c (Fimagemagick_types): Doc fix.
157 2012-05-30 Jim Meyering <meyering@redhat.com>
159 * callproc.c (Fcall_process_region): Include directory component
160 in mkstemp error message (Bug#11586).
162 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
164 * alloc.c, lisp.h (make_pure_vector): Now static.
166 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
168 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
170 (Fautoload): Do the hash-doc more carefully.
171 * data.c (Fdefalias): Purify definition, except for keymaps.
172 (Qdefun): Move from eval.c.
173 * lisp.h (Qdefun): Remove.
174 * lread.c (read1): Tiny simplification.
176 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
178 Do not create empty overlays with the evaporate property (Bug#9642).
179 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
180 Bug#9642, but explicitly check that the buffer the overlay would
181 be moved to is live and rearrange lines to make sure that errors
182 will not put the overlay in an inconsistent state.
183 (Fdelete_overlay): Cosmetics.
185 2012-05-28 Eli Zaretskii <eliz@gnu.org>
187 * w32term.c (my_bring_window_to_top): New function.
188 (x_raise_frame): Use handle returned by DeferWindowPos, which
189 could be different from the original one.
190 Call my_bring_window_to_top instead of my_set_foreground_window.
193 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
194 by calling BringWindowToTop.
196 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
197 (WM_EMACS_END): Increase by one.
199 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
201 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
202 This avoids undefined behavior that might cause the eassert
203 to not catch an out-of-range value.
205 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
207 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
210 2012-05-27 Eli Zaretskii <eliz@gnu.org>
212 * bidi.c (bidi_mirror_char): Fix last change.
214 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
216 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
217 when referring to sectname field in printf format.
219 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
221 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
222 Only r_alloc_inhibit_buffer_relocation needed to be added;
223 the others were already declared.
225 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
226 before checking whether it's out of range. Put the check inside
228 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
230 2012-05-27 Ken Brown <kbrown@cornell.edu>
232 * callproc.c (Fcall_process): Restore a line that was accidentally
233 commented out in the 2011-02-13 change (bug#11547).
235 2012-05-27 Eli Zaretskii <eliz@gnu.org>
237 * lisp.h [REL_ALLOC]: Add prototypes for external functions
240 * buffer.c [REL_ALLOC]: Remove prototypes of
241 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
242 they are now on lisp.h.
244 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
246 * search.c (search_buffer): Use it to inhibit relocation of buffer
247 text while re_search_2 is doing its job, because re_search_2 is
248 passed C pointers to buffer text. (Bug#11519)
250 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
253 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
254 state after an additional call to move_it_in_display_line_to, keep
255 the values of it->max_ascent and it->max_descent found for the
257 (pos_visible_p): Revert the comparison against bottom_y to what it
258 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
261 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
263 Fix coding-related core dumps with gcc -ftrapv.
264 The code was computing A - B, where A and B are pointers, and B is
265 random garbage. This can lead to core dumps on platforms that
266 have special pointer registers, and it also leads to core dumps on
267 x86-64 when compiled with gcc -ftrapv. The fix is to compute
268 A - B only when B is initialized properly.
269 * coding.c (coding_set_source, coding_set_destination): Return void.
270 (coding_change_source, coding_change_destinations): New functions,
271 with the old behaviors of coding_set_source and coding_set_destination.
272 All callers that need an offset changed to use these new functions.
274 2012-05-26 Glenn Morris <rgm@gnu.org>
276 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
278 2012-05-26 Eli Zaretskii <eliz@gnu.org>
280 Extend mouse support on W32 text-mode console.
281 * xdisp.c (draw_row_with_mouse_face):
282 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
284 * w32console.c: Include window.h.
285 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
287 (initialize_w32_display): Initialize mouse-highlight data.
289 * w32inevt.c: Include termchar.h and window.h.
290 (do_mouse_event): Support mouse-autoselect-window. When the mouse
291 moves, call note_mouse_highlight. If help_echo changed, call
292 gen_help_event to produce help-echo message in the echo area.
293 Call clear_mouse_face if mouse_face_hidden is set in the mouse
296 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
298 * lread.c (read1): Simplify slightly to avoid an overflow warning
299 with GCC 4.7.0 on x86-64.
301 2012-05-26 Eli Zaretskii <eliz@gnu.org>
303 * bidi.c (bidi_mirror_char): Revert last change: an int is
304 definitely wide enough here.
306 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
308 Fix integer width and related bugs (Bug#9874).
309 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
310 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
311 (string_bytes, check_sblock, allocate_string_data):
312 (compact_small_strings, Fmake_bool_vector, make_string)
313 (make_unibyte_string, make_multibyte_string)
314 (make_string_from_bytes, make_specified_string)
315 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
316 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
319 (allocate_pseudovector):
320 Use int, not EMACS_INT, where int is wide enough.
321 (inhibit_garbage_collection, Fgarbage_collect):
322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
323 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
324 int might not be wide enough.
325 (bidi_cache_search, bidi_cache_find, bidi_init_it)
326 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
327 (bidi_at_paragraph_end, bidi_find_paragraph_start)
328 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
329 (bidi_level_of_next_char, bidi_move_to_visually_next):
330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
331 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
332 (Fkill_buffer, Fset_buffer_major_mode)
333 (advance_to_char_boundary, Fbuffer_swap_text)
334 (Fset_buffer_multibyte, overlays_at, overlays_in)
335 (overlay_touches_p, struct sortvec, record_overlay_string)
336 (overlay_strings, recenter_overlay_lists)
337 (adjust_overlays_for_insert, adjust_overlays_for_delete)
338 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
339 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
340 (Foverlay_recenter, last_overlay_modification_hooks_used)
341 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
343 (validate_region): Omit unnecessary test for b <= e,
344 since that's guaranteed by the previous test.
345 (adjust_overlays_for_delete): Avoid pos + length overflow.
346 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
347 (report_overlay_modification):
348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
349 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
350 Omit pointer cast, which isn't needed anyway, and doesn't work
351 after the EMACS_INT -> ptrdiff_t change.
352 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
353 * buffer.h: Adjust decls to match defn changes elsewhere.
354 (struct buffer_text, struct buffer):
355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
356 Use EMACS_INT, not int, where int might not be wide enough.
357 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
358 not int, to avoid needless 32-bit limit on 64-bit hosts.
359 (exec_byte_code): Use tighter memory-full test, one that checks
360 for alloca overflow. Don't compute the address of the object just
361 before an array, as that's not portable. Use EMACS_INT, not
362 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
363 * callint.c (Fcall_interactively):
364 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
365 * callproc.c (call_process_kill, Fcall_process):
366 Don't assume pid_t fits into an Emacs fixnum.
367 (call_process_cleanup, Fcall_process, child_setup):
368 Don't assume pid_t fits into int.
369 (call_process_cleanup, Fcall_process, delete_temp_file)
370 (Fcall_process_region):
371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
372 (Fcall_process): Simplify handling of volatile integers.
373 Use int, not EMACS_INT, where int will do.
374 * casefiddle.c (casify_object, casify_region, operate_on_word)
375 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
376 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
377 (casify_object): Avoid integer overflow when overallocating buffer.
378 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
379 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
380 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
381 * category.h (CATEGORYP): Don't assume arg is nonnegative.
382 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
383 integers are now checked earlier. All uses replaced with XINT.
385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
386 For CCL_MapSingle, check that content and value are in int range.
387 (ccl_driver, Fregister_code_conversion_map):
388 Check that Vcode_version_map_vector is a vector.
389 (resolve_symbol_ccl_program): Check that vector header is in range.
390 Always copy the vector, so that we can check its contents reliably
391 now rather than having to recheck each instruction as it's being
392 executed. Check that vector words fit in 'int'.
393 (ccl_get_compiled_code, Fregister_ccl_program)
394 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
395 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
396 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
397 contents are in range.
398 (Fccl_execute_on_string): Check that status is in range.
399 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
400 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
401 Accept and return EMACS_INT, not int, because callers can pass values
403 (c_string_width, strwidth, lisp_string_width, chars_in_text)
404 (multibyte_chars_in_text, parse_str_as_multibyte)
405 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
406 (str_as_unibyte, str_to_unibyte, string_count_byte8)
407 (string_escape_byte8, Fget_byte):
408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
409 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
410 avoid mishandling large integers.
411 * character.h: Adjust decls to match defn changes elsewhere.
412 * charset.c (load_charset_map_from_file, find_charsets_in_text)
413 (Ffind_charset_region):
414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
415 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
416 (load_charset_map_from_vector, Fdefine_charset_internal):
417 Don't assume fixnum fits in int.
418 (load_charset_map_from_vector, Fmap_charset_chars):
419 Remove now-unnecessary CHECK_NATNUMs.
420 (Fdefine_charset_internal): Check ranges here, more carefully.
421 Don't rely on undefined behavior with signed left shift overflow.
422 Don't assume unsigned int fits into fixnum, or that fixnum fits
423 into unsigned int. Don't require max_code to be a valid fixnum;
424 that's not true for gb10830 4-byte on a 32-bit host. Allow
425 invalid_code to be a cons, for the same reason. Require code_offset
426 to be a character. Avoid int overflow if max_char is close
428 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
429 this is intended anyway and avoids some undefined behavior.
430 (load_charset_map): Pass unsigned, not int, as 2nd arg of
431 INDEX_TO_CODE_POINT, as that's what it expects.
432 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
433 * charset.h (DECODE_CHAR): Return int, not unsigned;
434 this is what was intended anyway, and it avoids undefined behavior.
435 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
436 integer-overflow issues.
437 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
438 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
439 where the argument is EMACS_INT, and this behavior is not intended.
440 * chartab.c (Fmake_char_table, Fset_char_table_range)
441 (uniprop_get_decoder, uniprop_get_encoder):
442 Don't assume fixnum fits in int.
443 * cmds.c (move_point): New function, that does the gist of
444 Fforward_char and Fbackward_char, but does so while checking
445 for integer overflow more accurately.
446 (Fforward_char, Fbackward_char): Use it.
447 (Fforward_line, Fend_of_line, internal_self_insert)
448 (internal_self_insert):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 Fix a FIXME, by checking for integer overflow when calculating
451 target_clm and actual_clm.
452 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
453 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
454 (ASSURE_DESTINATION, coding_alloc_by_realloc)
455 (coding_alloc_by_making_gap, alloc_destination)
456 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
457 (encode_coding_utf_16, detect_coding_emacs_mule)
458 (decode_coding_emacs_mule, encode_coding_emacs_mule)
459 (detect_coding_iso_2022, decode_coding_iso_2022)
460 (encode_invocation_designation, encode_designation_at_bol)
461 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
462 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
463 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
464 (encode_coding_ccl, encode_coding_raw_text)
465 (detect_coding_charset, decode_coding_charset)
466 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
467 (produce_composition, produce_charset, produce_annotation)
468 (decode_coding, handle_composition_annotation)
469 (handle_charset_annotation, consume_chars, decode_coding_gap)
470 (decode_coding_object, encode_coding_object, detect_coding_system)
471 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
472 (code_convert_region, code_convert_string)
473 (Fdefine_coding_system_internal)
474 (coding_set_source, coding_set_destination):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
477 (Fdefine_coding_system_internal):
478 Don't assume fixnums fit in int.
479 (decode_coding_gap, decode_coding_object, encode_coding_object)
480 (Fread_coding_system, Fdetect_coding_region)
481 (Funencodable_char_position, Fcheck_coding_systems_region)
482 (get_translation, handle_composition_annotation, consume_chars):
483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
484 (consume_chars): Rewrite to not calculate an address outside buffer.
485 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
486 Don't access memory outside of the args array.
487 (Fdefine_coding_system_internal): Check for charset-id overflow.
488 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
489 result of ENCODE_CHAR.
490 * coding.h: Adjust decls to match defn changes elsewhere.
491 (struct coding_system):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 * composite.c (get_composition_id, find_composition)
494 (run_composition_function, update_compositions)
495 (compose_text, composition_gstring_put_cache)
496 (composition_gstring_p, composition_gstring_width)
497 (fill_gstring_header, fill_gstring_body, autocmp_chars)
498 (composition_compute_stop_pos, composition_reseat_it)
499 (composition_update_it, struct position_record)
500 (find_automatic_composition, composition_adjust_point)
501 (Fcomposition_get_gstring, Ffind_composition_internal):
502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
503 (update_compositions):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 * composite.h: Adjust decls to match defn changes elsewhere.
506 (struct composition):
507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
508 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
509 Do not attempt to compute the address of the object just before a
510 buffer; this is not portable.
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 (Faset): Use int, not EMACS_INT, where int is wide enough.
514 (Fstring_to_number): Don't assume fixnums fit in int.
515 (Frem): Don't assume arg is nonnegative.
516 * dbusbind.c (xd_append_arg): Check for integers out of range.
517 (Fdbus_call_method): Don't overflow the timeout int.
518 (extract_signed, extract_unsigned): New functions.
519 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
520 (xd_get_connection_references): Return ptrdiff_t, not int.
522 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
524 Use int, not unsigned, where the dbus API uses int.
525 (Fdbus_message_internal): Don't overflow mtype.
526 (syms_of_dbusbind): Allocate right-sized buffer for integers.
527 * dired.c (directory_files_internal, file_name_completion, scmp)
528 (file_name_completion_stat):
529 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
530 (file_name_completion): Don't overflow matchcount.
531 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
532 * dispextern.h: Adjust decls to match defn changes elsewhere.
533 (struct text_pos, struct glyph, struct bidi_saved_info)
534 (struct bidi_string_data, struct bidi_it, struct composition_it)
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (struct display_pos, struct composition_it, struct it):
538 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
539 * dispnew.c (increment_matrix_positions)
540 (increment_row_positions, mode_line_string)
541 (marginal_area_string):
542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
543 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
544 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
545 (duration_to_sec_usec): New function, to check for overflow better.
546 (Fsleep_for, sit_for): Use it.
547 * doc.c (get_doc_string, store_function_docstring):
548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
549 (get_doc_string, Fsnarf_documentation):
550 Use int, not EMACS_INT, where int is wide enough.
552 Use SAFE_ALLOCA, not alloca.
553 Check for overflow when converting EMACS_INT to off_t.
555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
556 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
557 Don't assume uid_t fits into fixnum.
558 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
559 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
560 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
561 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
562 (general_insert_function)
563 (Finsert_char, make_buffer_string, make_buffer_string_both)
564 (update_buffer_properties, Fbuffer_substring)
565 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
566 (Fsubst_char_in_region, check_translation)
567 (Ftranslate_region_internal, save_restriction_restore, Fformat)
568 (transpose_markers, Ftranspose_regions):
569 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
570 (clip_to_bounds): Move to lisp.h as an inline function).
571 (Fconstrain_to_field): Don't assume integers are nonnegative.
572 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
573 (Fsubst_char_in_region, Fsave_restriction):
574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
575 (Femacs_pid): Don't assume pid_t fits into fixnum.
576 (lo_time): Use int, not EMACS_INT, when int suffices.
577 (lisp_time_argument): Check for usec out of range.
578 (Fencode_time): Don't assume fixnum fits in int.
579 (Fuser_login_name, Fuser_full_name): Signal an error
580 if a uid argument is out of range, rather than relying on
582 (Fformat_time_string): Remove now-unnecessary check.
583 lisp_time_argument checks for out-of-range usec now.
584 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
585 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
586 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
587 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
588 (init_cmdargs, Fdump_emacs):
589 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
590 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
591 the bottom (typically) 32 bits of the fixnum.
592 * eval.c (specpdl_size, call_debugger):
593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
594 (when_entered_debugger, Fbacktrace_debug):
595 Don't assume fixnum can fit in int.
596 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
597 the object just before a buffer; this is not portable.
598 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
599 (grow_specpdl, unbind_to):
600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
601 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
602 (grow_specpdl): Simplify allocation by using xpalloc.
603 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
604 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
605 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
607 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
610 (Fcopy_file, non_regular_nbytes, read_non_regular)
611 (Finsert_file_contents):
612 Use int, not EMACS_INT, where int is wide enough.
613 (READ_BUF_SIZE): Verify that it fits in int.
614 (Finsert_file_contents): Check that counts are in proper range,
615 rather than assuming fixnums fit into ptrdiff_t etc.
616 Don't assume fixnums fit into int.
617 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
618 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
619 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
620 (string_char_to_byte, string_byte_to_char)
621 (string_make_multibyte, string_to_multibyte)
622 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
623 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
624 (substring_both, Fdelete, internal_equal, Ffillarray)
625 (Fclear_string, mapcar1)
626 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
627 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
628 (larger_vector, make_hash_table, maybe_resize_hash_table)
629 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
630 (Fmaphash, secure_hash):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (concat): Check for string index and length overflow.
633 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 (larger_vector): New API (vec, incr_min, size_max) replaces old
637 one (vec, new_size, init). This catches size overflow.
638 INIT was removed because it was always Qnil.
640 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
641 the upper bound on a hash table index size.
642 (make_hash_table, maybe_resize_hash_table): Use it.
643 (secure_hash): Computer start_byte and end_byte only after
644 they're known to be in ptrdiff_t range.
645 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
646 (Ffont_get_glyphs, Ffont_at):
647 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
648 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
649 (Flist_fonts, Fopen_font):
650 Don't assume fixnum can fit in int.
651 (check_gstring): Don't assume index can fit in int.
652 (font_match_p): Check that fixnum is a character, not a nonnegative
653 fixnum, since the later code needs to stuff it into an int.
654 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
655 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
656 conversion overflow issues.
657 (Fopen_font): Check for integer out of range.
658 (Ffont_get_glyphs): Don't assume index can fit in int.
659 * font.h: Adjust decls to match defn changes elsewhere.
660 * fontset.c (reorder_font_vector): Redo score calculation to avoid
662 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
663 printmax_t, where ptrdiff_t is wide enough.
664 (Finternal_char_font):
665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
666 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
667 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
668 (Fset_frame_position, x_set_frame_parameters)
669 (x_set_line_spacing, x_set_border_width)
670 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
671 Check that fixnums are in proper range for system types.
672 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
674 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
675 Use SAFE_ALLOCA_LISP, not alloca.
676 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
677 intptr_t is wide enough.
678 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
679 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
680 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
681 Check for fixnum out of range.
682 * ftfont.c (ftfont_list): Don't assume index fits in int.
683 Check that fixnums are in proper range for system types.
684 (ftfont_shape_by_flt):
685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
686 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
688 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
689 Check that fixnums are in proper range for system types.
690 * gnutls.h: Adjust decls to match defn changes elsewhere.
691 * gtkutil.c (xg_dialog_run):
692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
693 (update_frame_tool_bar):
694 Check that fixnums are in proper range for system types.
695 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
696 (lookup_image): Check that fixnums are in range for system types.
697 * indent.c (last_known_column, last_known_column_point):
698 (current_column_bol_cache):
699 (skip_invisible, current_column, check_display_width):
700 (check_display_width, scan_for_column, current_column_1)
701 (Findent_to, Fcurrent_indentation, position_indentation)
702 (indented_beyond_p, Fmove_to_column, compute_motion):
703 (Fcompute_motion, Fvertical_motion):
704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
705 (last_known_column_modified): Use EMACS_INT, not int.
706 (check_display_width):
708 Check that fixnums and floats are in proper range for system types.
709 (compute_motion): Don't assume index or fixnum fits in int.
710 (compute_motion, Fcompute_motion):
711 Use int, not EMACS_INT, when it is wide enough.
712 (vmotion): Omit local var start_hpos that is always 0; that way
713 we don't need to worry about overflow in expressions involving it.
714 * indent.h: Adjust decls to match defn changes elsewhere.
716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
717 Use int, not EMACS_INT, where int is wide enough.
718 Remove unused members ovstring_chars_done and tab_offset;
720 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
721 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
722 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
723 (make_gap, copy_text, insert, insert_and_inherit)
724 (insert_before_markers, insert_before_markers_and_inherit)
725 (insert_1, count_combining_before, count_combining_after)
726 (insert_1_both, insert_from_string)
727 (insert_from_string_before_markers, insert_from_string_1)
728 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
729 (adjust_after_replace, adjust_after_insert, replace_range)
730 (replace_range_2, del_range, del_range_1, del_range_byte)
731 (del_range_both, del_range_2, modify_region)
732 (prepare_to_modify_buffer, signal_before_change)
733 (signal_after_change, Fcombine_after_change_execute):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 * intervals.c (traverse_intervals, rotate_right, rotate_left)
736 (balance_an_interval, split_interval_right, split_interval_left)
737 (find_interval, next_interval, update_interval)
738 (adjust_intervals_for_insertion, delete_node, delete_interval)
739 (interval_deletion_adjustment, adjust_intervals_for_deletion)
740 (static_offset_intervals, offset_intervals)
741 (merge_interval_right, merge_interval_left, make_new_interval)
742 (graft_intervals_into_buffer, temp_set_point_both)
743 (temp_set_point, set_point, adjust_for_invis_intang)
744 (set_point_both, move_if_not_intangible, get_property_and_range)
745 (get_local_map, copy_intervals, copy_intervals_to_string)
746 (compare_string_intervals, set_intervals_multibyte_1):
747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
748 * intervals.h: Adjust decls to match defn changes elsewhere.
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 * keyboard.c (this_command_key_count, this_single_command_key_start)
752 (before_command_key_count, before_command_echo_length, echo_now)
753 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
754 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
755 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
756 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 (last_non_minibuf_size, last_point_position, echo_truncate)
759 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
760 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
761 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
762 (stuff_buffered_input):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (last_auto_save, command_loop_1, read_char):
765 Use EMACS_INT, not int, to avoid integer overflow.
766 (record_char): Avoid overflow in total_keys computation.
767 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
768 * keyboard.h: Adjust decls to match defn changes elsewhere.
769 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
770 (Fkey_description, Fdescribe_vector, Flookup_key):
771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
772 (click_position): New function, to check that positions are in range.
773 (Fcurrent_active_maps):
775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
776 (Faccessible_keymaps, Fkey_description):
777 (preferred_sequence_p):
778 Don't assume fixnum can fit into int.
779 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
780 Check for integer overflow in size calculations.
781 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
782 avoid mishandling large integers.
783 * lisp.h: Adjust decls to match defn changes elsewhere.
784 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
785 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
786 (struct Lisp_Marker):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
788 (clip_to_bounds): Now an inline function, moved here from editfns.c.
789 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
790 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
792 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
793 Assume the arg has valid form, since it always does.
794 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
795 unsigned integer system type.
796 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
797 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
799 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
800 (duration_to_sec_usec): New decl.
801 * lread.c (read_from_string_index, read_from_string_index_byte)
802 (read_from_string_limit, readchar, unreadchar, openp)
803 (read_internal_start, read1, oblookup):
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
805 (Fload, readevalloop, Feval_buffer, Feval_region):
806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
807 (openp): Check for out-of-range argument to 'access'.
808 (read1): Use int, not EMACS_INT, where int is wide enough.
809 Don't assume fixnum fits into int.
810 Fix off-by-one error that can read outside a buffer.
811 (read_filtered_event): Use duration_to_sec_usec
812 to do proper overflow checking on durations.
813 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
815 (Fexecute_kbd_macro):
816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
817 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
818 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
819 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
820 (set_marker_both, set_marker_restricted_both, marker_position)
821 (marker_byte_position, Fbuffer_has_markers_at):
822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
823 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
824 * menu.c (ensure_menu_items): Rename from grow_menu_items.
825 It now merely ensures that the menu is large enough, without
826 necessarily growing it, as this avoids some integer overflow issues.
828 (keymap_panes, parse_single_submenu, Fx_popup_menu):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
831 Use SAFE_ALLOCA_LISP, not alloca.
832 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
833 to EMACS_INT. Check that fixnums are in proper range for system types.
834 * minibuf.c (minibuf_prompt_width, string_to_object)
835 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
836 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
837 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
838 (get_minibuffer, read_minibuf_unwind):
839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
840 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
841 this simplifies overflow checking. All callers changed.
842 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
845 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
846 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
847 Check that fixnums are in proper range for system types.
848 (Fx_create_frame, Fx_show_tip):
849 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
850 * nsfont.m (ns_findfonts, nsfont_list_family):
851 Don't assume fixnum fits in long.
852 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
854 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
856 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
858 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
859 (PRINTDECLARE, PRINTPREPARE):
860 (strout, print_string):
861 (print, print_preprocess, print_check_string_charset_prop)
863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
865 (temp_output_buffer_setup, Fprin1_to_string, print_object):
866 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
867 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
868 (printchar, strout): Use xpalloc to catch size calculation overflow.
869 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
870 (print_error_message): Use SAFE_ALLOCA, not alloca.
871 (print_object): Use int, not EMACS_INT, where int is wide enough.
872 (print_depth, new_backquote_output, print_number_index):
873 Use ptrdiff_t, not int, where int might not be wide enough.
874 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
875 (Fset_process_window_size, Fformat_network_address)
876 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
878 Check that fixnums are in proper range for system types.
879 (Fsignal_process): Simplify by avoiding a goto.
880 Check for process-ids out of pid_t range rather than relying on
882 (process_tick, update_tick): Use EMACS_INT, not int.
883 (Fformat_network_address, read_process_output, send_process)
884 (Fprocess_send_region, status_notify):
885 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
886 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
887 (wait_reading_process_output, read_process_output, exec_sentinel):
888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
889 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
890 (Faccept_process_output): Use duration_to_sec_usec to do proper
891 overflow checking on durations.
892 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
893 Don't assume pid_t fits in int.
894 * process.h (struct Lisp_Process): Members tick and update_tick
895 are now of type EMACS_INT, not int.
896 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
897 configured --with-wide-int.
898 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
899 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
900 * search.c (looking_at_1, string_match_1):
901 (fast_string_match, fast_c_string_match_ignore_case)
902 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
903 (scan_newline, find_before_next_newline, search_command)
904 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
905 (set_search_regs, wordify):
908 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
909 (string_match_1, search_buffer, set_search_regs):
911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
912 (wordify): Check for overflow in size calculation.
913 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
914 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
915 Check that fixnums are in proper range for system types.
916 * sound.c (struct sound_device)
917 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
919 (Fplay_sound_internal):
920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
921 * syntax.c (struct lisp_parse_state, find_start_modiff)
922 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
923 (Fparse_partial_sexp):
924 Don't assume fixnums can fit in int.
925 (struct lisp_parse_state, find_start_pos, find_start_value)
926 (find_start_value_byte, find_start_begv)
927 (update_syntax_table, char_quoted, dec_bytepos)
928 (find_defun_start, prev_char_comend_first, back_comment):
929 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
930 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
931 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
932 (Finternal_describe_syntax_value): Check that match_lisp is a
933 character, not an integer, since the code stuffs it into int.
934 (scan_words, scan_sexps_forward):
935 Check that fixnums are in proper range for system types.
937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
938 (scan_sexps_forward):
939 Use CHARACTERP, not INTEGERP, since the value must fit into int.
940 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
941 * syntax.h: Adjust decls to match defn changes elsewhere.
943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
944 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
945 MOST_POSITIVE_FIXNUM.
946 * sysdep.c (wait_for_termination_1, wait_for_termination)
947 (interruptible_wait_for_termination, mkdir):
948 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
949 (emacs_read, emacs_write):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
952 and double all fit in int.
953 * term.c (set_tty_color_mode):
954 Check that fixnums are in proper range for system types.
955 * termhooks.h (struct input_event):
956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
957 * textprop.c (validate_interval_range, interval_of)
958 (Fadd_text_properties, set_text_properties_1)
959 (Fremove_text_properties, Fremove_list_of_text_properties)
960 (Ftext_property_any, Ftext_property_not_all)
961 (copy_text_properties, text_property_list, extend_property_ranges)
962 (verify_interval_modification):
963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
964 (Fnext_single_char_property_change)
965 (Fprevious_single_char_property_change):
966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (copy_text_properties):
968 Check for integer overflow in index calculation.
969 * undo.c (last_boundary_position, record_point, record_insert)
970 (record_delete, record_marker_adjustment, record_change)
971 (record_property_change):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
975 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
976 (Fx_hide_tip, Fx_file_dialog):
977 * w32menu.c (set_frame_menubar):
978 Use ptrdiff_t, not int, for consistency with rest of code.
979 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
980 (select_window, Fdelete_other_windows_internal)
981 (window_scroll_pixel_based, window_scroll_line_based)
982 (Frecenter, Fset_window_configuration):
983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
984 (Fset_window_hscroll, run_window_configuration_change_hook)
985 (set_window_buffer, temp_output_buffer_show, scroll_command)
986 (Fscroll_other_window, Frecenter):
987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
988 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
989 Don't assume fixnum fits in int.
990 (Fset_window_scroll_bars):
991 Check that fixnums are in proper range for system types.
992 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
993 (string_pos, c_string_pos, number_of_chars, init_iterator)
994 (in_ellipses_for_invisible_text_p, init_from_display_pos)
995 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
996 (compute_display_string_end, handle_face_prop)
997 (face_before_or_after_it_pos, handle_invisible_prop)
998 (handle_display_prop, handle_display_spec, handle_single_display_spec)
999 (display_prop_intangible_p, string_buffer_position_lim)
1000 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1001 (get_overlay_strings_1, get_overlay_strings)
1002 (iterate_out_of_display_property, forward_to_next_line_start)
1003 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1004 (get_next_display_element, set_iterator_to_next)
1005 (get_visually_first_element, compute_stop_pos_backwards)
1006 (handle_stop_backwards, next_element_from_buffer)
1007 (move_it_in_display_line_to, move_it_in_display_line)
1008 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1009 (add_to_log, message_dolog, message_log_check_duplicate)
1010 (message2, message2_nolog, message3, message3_nolog
1011 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1012 (current_message_1, truncate_echo_area, truncate_message_1)
1013 (set_message, set_message_1, store_mode_line_noprop)
1014 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1015 (text_outside_line_unchanged_p, check_point_in_composition)
1016 (reconsider_clip_changes)
1017 (redisplay_internal, set_cursor_from_row, try_scrolling)
1018 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1019 (redisplay_window, find_last_unchanged_at_beg_row)
1020 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1021 (trailing_whitespace_p, find_row_edges, display_line)
1022 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1023 (display_mode_element, store_mode_line_string)
1024 (pint2str, pint2hrstr, decode_mode_spec)
1025 (display_count_lines, display_string, draw_glyphs)
1026 (x_produce_glyphs, x_insert_glyphs)
1027 (rows_from_pos_range, mouse_face_from_buffer_pos)
1028 (fast_find_string_pos, mouse_face_from_string_pos)
1029 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1031 (safe_call, init_from_display_pos, handle_fontified_prop)
1032 (handle_single_display_spec, load_overlay_strings)
1033 (with_echo_area_buffer, setup_echo_area_for_printing)
1034 (display_echo_area, echo_area_display)
1035 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1036 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1037 (redisplay_window, dump_glyph_row, display_mode_line)
1038 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1039 (handle_display_spec, display_prop_string_p):
1040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1041 (handle_single_display_spec, build_desired_tool_bar_string)
1042 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1043 (get_specified_cursor_type):
1044 Check that fixnums are in proper range for system types.
1045 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1046 (Flookup_image_map):
1047 Don't assume fixnums fit in int.
1048 (compare_overlay_entries):
1049 Avoid mishandling comparisons due to subtraction overflow.
1050 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1051 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1052 (handle_tool_bar_click):
1053 Use int, not unsigned, since we prefer signed and the signedness
1054 doesn't matter here.
1055 (get_next_display_element, next_element_from_display_vector):
1056 Use int, not EMACS_INT, when int is wide enough.
1057 (start_hourglass): Use duration_to_sec_usec to do proper
1058 overflow checking on durations.
1059 * xfaces.c (Fbitmap_spec_p):
1060 Check that fixnums are in proper range for system types.
1061 (compare_fonts_by_sort_order):
1062 Avoid mishandling comparisons due to subtraction overflow.
1063 (Fx_family_fonts, realize_basic_faces):
1064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1066 Don't assume fixnum fits in int.
1067 Use SAFE_ALLOCA_LISP, not alloca.
1068 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1069 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1070 (face_at_buffer_position, face_for_overlay_string)
1071 (face_at_string_position):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1074 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1076 Check that fixnums are in proper range for system types.
1077 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1078 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1080 (Fx_change_window_property): Don't assume fixnums fit in int.
1081 * xfont.c (xfont_chars_supported):
1082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1083 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1084 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1086 * xml.c (parse_region):
1087 * xrdb.c (magic_file_p):
1088 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1089 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1090 (x_get_local_selection, x_reply_selection_request)
1091 (x_handle_selection_request, wait_for_property_change):
1092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1093 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1094 short is wide enough.
1095 (x_send_client_event): Don't assume fixnum fits in int.
1096 * xterm.c (x_x_to_emacs_modifiers):
1097 Don't assume EMACS_INT overflows nicely into int.
1098 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1100 (handle_one_xevent): NATNUMP can eval its arg twice.
1101 (x_connection_closed):
1102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1103 * xterm.h: Adjust decls to match defn changes elsewhere.
1104 (struct scroll_bar): Use struct vectorlike_header
1105 rather than rolling our own approximation.
1106 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1108 2012-05-25 Glenn Morris <rgm@gnu.org>
1110 * lisp.mk (lisp): Update for more files being compiled now.
1112 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1114 * lread.c: Remove `read_pure' which makes no difference.
1115 (read_pure): Remove var.
1116 (unreadpure): Remove function.
1117 (readevalloop): Don't call read_list with -1 flag.
1118 (read1, read_vector): Don't test read_pure any more.
1119 (read_list): Simplify.
1121 * fileio.c, character.h: Minor style tweaks.
1123 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1125 * window.h (clip_changed): Remove useless declaration.
1127 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1129 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1130 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1132 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1135 This directory predates autoconf and is no longer needed nowadays.
1136 Move its few remaining bits of functionality to where they're needed.
1137 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1138 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1139 * m/template.h: Remove.
1140 * Makefile.in (M_FILE): Remove. All uses removed.
1141 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1142 * lisp.h (USE_LSB_TAG):
1143 * mem-limits.h (EXCEEDS_LISP_PTR):
1144 Use VAL_MAX, not VALBITS, in #if.
1145 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1146 (EMACS_UINT): Define unconditionally now.
1147 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1148 (BITS_PER_EMACS_INT): New constants, replacing
1149 what used to be in config.h, but not useful in #if.
1150 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1151 define them any more.
1152 (VAL_MAX): New macro.
1154 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1155 BITS_PER_EMACS_INT, in #if.
1156 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1157 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1158 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1159 * s/ms-w32.h (DATA_START):
1160 Move here from removed file m/intel386.h.
1161 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1162 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1164 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1166 Assume C89 or later.
1167 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1168 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1170 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1171 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1172 * textprop.c, tparam.c (NULL): Remove.
1173 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1174 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1175 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1176 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1177 * xterm.c (input_signal_count): Assume volatile works.
1179 2012-05-21 Ken Brown <kbrown@cornell.edu>
1181 * xgselect.c (xg_select): Fix first argument in call to 'select'
1184 2012-05-20 Ken Brown <kbrown@cornell.edu>
1186 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1187 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1189 2012-05-19 Ken Brown <kbrown@cornell.edu>
1191 * xfns.c (x_in_use): Remove `static' qualifier.
1192 * xterm.h (x_in_use): Declare.
1193 * xgselect.c: Include xterm.h.
1194 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1195 and `display_arg' (bug#9754).
1197 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1199 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1201 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1202 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1204 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1206 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1208 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1209 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1211 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1212 reference to image_cache->refcount.
1213 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1215 2012-05-17 Juri Linkov <juri@jurta.org>
1217 * search.c (Fword_search_regexp, Fword_search_backward)
1218 (Fword_search_forward, Fword_search_backward_lax)
1219 (Fword_search_forward_lax): Move functions to isearch.el
1220 (bug#10145, bug#11381).
1222 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1224 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1226 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1228 * lread.c (init_obarray): Declare Qt and Qnil as special.
1230 2012-05-14 Glenn Morris <rgm@gnu.org>
1232 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1233 Put "libexec" before "bin", for the sake of init_callproc_1.
1235 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1237 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1239 * unexaix.c: Port to more-recent AIX compilers.
1240 (report_error, report_error_1, make_hdr, copy_sym)
1241 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1242 Make arguments const char *, not char *, to avoid violations of C
1243 standard and to fix some AIX warnings reported by Gilles Pion.
1245 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1247 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1248 already have overlays loaded.
1249 (handle_single_display_spec): Before returning without displaying
1250 fringe bitmap, synchronize the bidi iterator with the main display
1251 iterator, by calling iterate_out_of_display_property.
1252 (iterate_out_of_display_property): Detect buffer iteration by
1253 testing that it->string is a Lisp string.
1254 (get_next_display_element): When the current object is exhausted,
1255 and there's something on it->stack, call set_iterator_to_next to
1256 proceed with what's on the stack, instead of returning zero.
1257 (set_iterator_to_next): If called at the end of a Lisp string,
1258 proceed to consider_string_end without incrementing string
1259 position. Don't increment display vector index past the end of
1260 the display vector. (Bug#11417)
1261 (pos_visible_p): Don't report a position visible when move_it_to
1262 stopped at the last line of window, which happens to be scanned
1263 backwards by the bidi iteration. (Bug#11464)
1265 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1267 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1268 and right-margin display specs even if the spec is invalid or we
1269 are on a TTY, and thus unable to display on the fringes.
1270 That's because the text with the property will not be displayed anyway,
1271 so we need to signal to the caller that this is a "replacing"
1272 display spec. This fixes display when the spec is invalid or we
1275 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1277 * unexaix.c (make_hdr): Fix typo in prototype.
1278 This bug broke the build on AIX. Problem reported by Gilles Pion.
1280 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1282 * keyboard.c (kbd_buffer_get_event): Read special events also in
1283 batch mode. (Bug#11415)
1285 2012-05-12 Glenn Morris <rgm@gnu.org>
1287 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1289 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1291 * lisp.mk (lisp): Add newcomment.elc.
1293 2012-05-12 Glenn Morris <rgm@gnu.org>
1295 * Makefile.in (MKDIR_P): New, set by configure.
1296 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1298 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1300 Remove unused function hourglass_started.
1301 * dispextern.h (hourglass_started):
1302 * w32fns.c (hourglass_started):
1303 * xdisp.c (hourglass_started): Remove.
1305 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1307 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1308 Update dependencies.
1310 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1312 * xgselect.c (xg_select): Put maxfds+1 into a var.
1313 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1315 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1317 2012-05-10 Dave Abrahams <dave@boostpro.com>
1319 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1320 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1322 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1324 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1325 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1326 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1327 Initialize xd_registered_buses.
1329 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1331 Untag more efficiently if USE_LSB_TAG.
1332 This is based on a proposal by YAMAMOTO Mitsuharu in
1333 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1334 For an admittedly artificial (nth 8000 longlist) benchmark on
1335 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1336 Emacs's overall text size by 1%.
1337 * lisp.h (XUNTAG): New macro.
1338 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1339 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1340 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1341 * eval.c (Fautoload):
1342 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1343 * frame.h (XFRAME): Use XUNTAG.
1345 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1346 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1347 Remove unportable assumptions about print widths of types like
1349 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1350 intptr_t when converting between pointer and integer, to avoid GCC
1351 warnings about wrong width.
1353 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1355 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1356 stack for each reader_thread, instead of defaulting to 8MB
1357 determined by the linker. This avoids failures in creating
1358 subprocesses on Windows 7, see the discussion in this thread:
1359 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1361 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1363 Fix up display of the *Minibuf-0* buffer in the mini window.
1364 * keyboard.c (read_char): Don't clear the echo area if there's no
1366 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1367 contents of *Minibuf-0*) if there's no message displayed in its stead.
1369 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1371 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1374 2012-05-06 Chong Yidong <cyd@gnu.org>
1376 * lisp.mk (lisp): Update.
1378 2012-05-05 Jim Meyering <meyering@redhat.com>
1380 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1382 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1384 * data.c (PUT_ERROR): New macro.
1385 (syms_of_data): Use it. Add new error type `user-error'.
1386 * undo.c (user_error): New function.
1387 (Fprimitive_undo): Use it.
1388 * print.c (print_error_message): Adjust print style for `user-error'.
1389 * keyboard.c (user_error): New function.
1390 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1392 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1394 Do not limit current-time-string to years 1000..9999.
1395 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1396 (Fcurrent_time_string): Support any year that is supported by the
1397 underlying localtime representation. Don't use asctime, as it
1398 has undefined behavior for years outside the range -999..9999.
1400 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1402 Fix race conditions involving setenv, gmtime, localtime, asctime.
1403 Without this fix, interrupts could mess up code that uses these
1404 nonreentrant functions, since setting TZ invalidates existing
1405 tm_zone or tzname values, and since most of these functions return
1406 pointers to static storage.
1407 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1408 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1409 Grow the critical sections to include not just invoking
1410 localtime/gmtime, but also accessing these functions' results
1411 including their tm_zone values if any, and any related TZ setting.
1412 (format_time_string): Last arg is now struct tm *, not struct tm **,
1413 so that the struct tm is saved in the critical section.
1414 All callers changed. Simplify allocation of initial buffer, partly
1415 motivated by the fact that memory allocation needs to be outside
1416 the critical section.
1418 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1420 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1421 with RESET_INTERVAL.
1423 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1424 Remove duplicated buffer name initialization.
1426 2012-05-02 Jim Meyering <jim@meyering.net>
1428 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1430 * xfns.c (x_window): Use xstrdup (Bug#11375).
1432 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1434 * xdisp.c (pos_visible_p): If already at a newline from the
1435 display string before the 'while' loop, don't walk back the glyphs
1436 from it3.glyph_row. Solves assertion violation when the display
1437 string begins with a newline (egg.el). (Bug#11367)
1439 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1441 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1444 2012-05-01 Glenn Morris <rgm@gnu.org>
1446 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1447 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1448 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1449 All were removed before 23.1.
1451 * dispnew.c: Remove HAVE_LIBNCURSES test;
1452 it is always true on relevant platforms.
1454 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1455 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1457 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1459 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1461 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1462 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1465 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1467 Do not avoid creating empty evaporating overlays (Bug#9642).
1468 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1469 That is, do not delete an evaporating overlay if it becomes
1470 empty after its bounds are adjusted to fit within its buffer.
1471 This fix caused other problems, and I'm reverting it until we get
1472 to the bottom of them.
1474 2012-04-27 Chong Yidong <cyd@gnu.org>
1476 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1478 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1480 * xdisp.c (pos_visible_p): If the window start position is beyond
1481 ZV, start the display from buffer beginning. Prevents assertion
1482 violation in init_iterator when the minibuffer window is scrolled
1485 * window.c (window_scroll_pixel_based): Likewise.
1487 2012-04-27 Chong Yidong <cyd@gnu.org>
1489 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1491 2012-04-27 Glenn Morris <rgm@gnu.org>
1493 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1494 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1496 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1498 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1499 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1501 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1503 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1504 display element, check also the underlying string or buffer
1505 character. (Bug#11341)
1507 * w32menu.c: Include w32heap.h.
1508 (add_menu_item): If the call to AppendMenuW (via
1509 unicode_append_menu) fails, disable Unicode menus only if we are
1510 running on Windows 9X/Me.
1512 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1514 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1515 (xgetint): Add missing shift for LSB tags.
1517 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1519 * keyboard.c (read_char): Don't wipe echo area for select window
1520 events: These might get delayed via `mouse-autoselect-window'
1523 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1525 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1526 manipulation of :loaded-from data.
1528 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1530 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1531 now a cons (bug#11311).
1533 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1535 Do not create empty overlays with the evaporate property (Bug#9642).
1536 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1537 if it becomes empty after its bounds are adjusted to fit within
1538 its buffer. Without this fix, in a nonempty buffer (let ((o
1539 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1540 yields an empty overlay that has the evaporate property, which is
1541 not supposed to happen.
1543 Fix minor GTK3 problems found by static checking.
1544 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1545 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1546 (struct _EmacsFixedClass, emacs_fixed_get_type):
1547 Move decls here from emacsgtkfixed.h, since they needn't be public.
1548 (emacs_fixed_get_type): Now static.
1549 (emacs_fixed_class_init): Omit unused local.
1550 (emacs_fixed_child_type): Remove; unused.
1551 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1552 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1553 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1554 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1555 (EMACS_FIXED_GET_CLASS): Remove; unused.
1556 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1558 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1559 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1561 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1563 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1564 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1565 (__malloc_size_t, __malloc_ptrdiff_t):
1566 Remove. All uses removed, replaced by the definiens if needed,
1567 since we can assume C89 or better now.
1568 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1569 (protect_malloc_state, align, get_contiguous_space)
1570 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1571 (malloc_atfork_handler_child, malloc_enable_thread)
1572 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1573 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1574 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1575 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1576 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1577 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1578 Define using prototypes, not old style.
1579 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1580 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1581 (align): Don't assume that signed integer overflow wraps around.
1582 Omit unused local var.
1583 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1584 (_free_internal_nolock, memalign, mallochook, reallochook):
1585 Omit no-longer-needed casts.
1586 (valloc): Use getpagesize, not __getpagesize.
1587 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1588 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1590 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1592 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1594 Move functions from C to Lisp. Make non-blocking method calls
1595 the default. Implement further D-Bus standard interfaces.
1597 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1598 (QCdbus_request_name_allow_replacement)
1599 (QCdbus_request_name_replace_existing)
1600 (QCdbus_request_name_do_not_queue)
1601 (QCdbus_request_name_reply_primary_owner)
1602 (QCdbus_request_name_reply_in_queue)
1603 (QCdbus_request_name_reply_exists)
1604 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1605 (QCdbus_registered_serial, QCdbus_registered_method)
1606 (QCdbus_registered_signal): New Lisp objects.
1607 (XD_DEBUG_MESSAGE): Use sizeof.
1608 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1609 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1610 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1611 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1612 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1613 (xd_signature, xd_append_arg): Allow float for integer types.
1614 (xd_get_connection_references): New function.
1615 (xd_get_connection_address): Rename from xd_initialize.
1616 Return cached address.
1617 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1618 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1620 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1621 Return number of refcounts.
1622 (Fdbus_get_unique_name): Make stronger parameter check.
1623 (Fdbus_message_internal): New defun.
1624 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1625 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1626 (Fdbus_send_signal, Fdbus_register_service)
1627 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1628 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1629 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1630 (Vdbus_compiled_version, Vdbus_runtime_version)
1631 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1632 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1633 (Vdbus_message_type_signal): New defvars.
1634 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1637 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1639 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1640 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1641 Do not assume ptrdiff_t is the same width as 'int'.
1643 * alloc.c: Handle unusual debugging option combinations.
1644 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1645 since the two debugging options are incompatible.
1646 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1648 (mem_init, mem_insert, mem_insert_fixup):
1649 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1650 (NEED_MEM_INSERT): Remove; no longer needed.
1652 2012-04-22 Leo Liu <sdl.web@gmail.com>
1654 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1656 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1658 * sysdep.c [__FreeBSD__]: Minor cleanups.
1659 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1660 Use Emacs indenting style more consistently. Avoid some casts.
1661 Use 'double' consistently rather than mixing 'float' and 'double'.
1663 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1665 * sysdep.c (list_system_processes, system_process_attributes):
1666 Add implementation for FreeBSD (Bug#5243).
1668 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1670 * lisp.mk (lisp): Update.
1672 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1674 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1675 It is never used otherwise.
1677 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1679 * print.c (print_preprocess): Only check print_depth if print-circle
1681 (print_object): Check for cycles even when print-circle is nil and
1682 print-gensym is t, but only check print_depth if print-circle is nil.
1684 2012-04-20 Chong Yidong <cyd@gnu.org>
1686 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1687 set the status to "failed" and ensure that sentinel is run.
1689 2012-04-20 Glenn Morris <rgm@gnu.org>
1691 * process.c (Fset_process_inherit_coding_system_flag)
1692 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1693 (Fmake_network_process, Fmake_serial_process): Doc fix.
1695 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1697 * xdisp.c (string_buffer_position_lim): Limit starting position to
1699 (set_cursor_from_row): If called for a mode-line or header-line
1700 row, return zero immediately.
1701 (try_cursor_movement): If inside continuation line, don't back up
1702 farther than the first row after the header line, if any.
1703 Don't consider the header-line row as "partially visible", even if
1704 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1706 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1708 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1711 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1712 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1714 configure: new option --enable-gcc-warnings (Bug#11207)
1715 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1716 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1717 (ALL_CFLAGS): Use new macros rather than old.
1718 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1719 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1720 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1721 -Wunused-result, -Wunused-variable. This should go away once
1722 the Emacs and Gnulib regex code is merged.
1723 (xmalloc, xrealloc): Now static.
1725 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1727 * dired.c (Fsystem_groups): Remove unused local.
1729 2012-04-17 Glenn Morris <rgm@gnu.org>
1731 * dired.c (Fsystem_users): Doc fix.
1733 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1735 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1736 (syms_of_dired): Add them.
1738 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1740 Fix minor alloc.c problems found by static checking.
1741 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1742 New extern decls, to avoid calling undeclared functions.
1743 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1744 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1745 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1746 (NEED_MEM_INSERT): New macro.
1747 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1748 Remove one incorrect comment and fix another.
1750 Fix minor ralloc.c problems found by static checking.
1751 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1752 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1753 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1754 (r_alloc_sbrk): Now static.
1756 Improve ralloc.c interface checking.
1757 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1758 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1759 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1760 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1761 [REL_ALLOC]: ... to here, to check interface.
1762 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1763 Remove decls. This fixes an "It stinks!".
1765 * alloc.c (which_symbols): Fix alignment issue / type clash.
1767 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1769 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1770 (struct Lisp_Misc_Any): Likewise.
1771 (struct Lisp_Free): Likewise.
1772 * alloc.c (union aligned_Lisp_Symbol): Define.
1773 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1774 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1775 (union aligned_Lisp_Misc): Define.
1776 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1777 aligned_Lisp_Misc instead of union Lisp_Misc.
1778 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1780 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1782 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1783 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1784 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1785 * s/netbsd.h, s/sol2-6.h:
1786 Remove definition of GC_MARK_STACK, since the default now works.
1787 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1788 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1789 no longer the default.
1790 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1792 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1794 * lread.c (lisp_file_lexically_bound_p):
1795 Fix hang at ";-*-\n" (bug#11238).
1797 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1799 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1800 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1802 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1804 * nsterm.m (constrainFrameRect): Always constrain when there is only
1805 one screen (Bug#10962).
1807 2012-04-13 Ken Brown <kbrown@cornell.edu>
1809 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1811 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1813 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1815 2012-04-11 Daniel Colascione <dancol@dancol.org>
1817 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1818 against is gone. It's better to use vfork now so that when Cygwin
1819 gains a new, working vfork, we use it automatically (bug#10398).
1821 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1823 * window.c (save_window_save): Obey window-point-insertion-type.
1825 2012-04-11 Glenn Morris <rgm@gnu.org>
1827 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1829 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1831 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1833 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1835 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1836 (force_quit_count): New var.
1837 (handle_interrupt): Use it.
1839 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1841 * w32.c (w32_delayed_load): Record the full path of the library
1842 being loaded (bug#10424).
1844 2012-04-09 Glenn Morris <rgm@gnu.org>
1846 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1847 not just in the obarray, before snarfing them. (Bug#11036)
1849 * Makefile.in ($(leimdir)/leim-list.el):
1850 Pass EMACS rather than BUILT_EMACS.
1852 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1854 * process.c (make_process):
1855 * process.h: Add integer `gnutls_handshakes_tried' member to
1858 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1859 Add convenience `GNUTLS_LOG2i' macro.
1861 * gnutls.c (gnutls_log_function2i): Convenience log function.
1862 (emacs_gnutls_read): Use new log functions,
1863 `gnutls_handshakes_tried' process member, and
1864 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1865 attempts per process (connection).
1867 2012-04-09 Chong Yidong <cyd@gnu.org>
1869 * eval.c (Fuser_variable_p, user_variable_p_eh)
1870 (lisp_indirect_variable): Functions deleted.
1871 (Fdefvar): Caller changed.
1873 * callint.c (Finteractive, Fcall_interactively):
1874 * minibuf.c (Fread_variable): Callers changed.
1876 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1878 * xdisp.c (set_cursor_from_row): If the display string appears in
1879 the buffer at position that is closer to point than the position
1880 after the display string, display the cursor on the first glyph of
1881 the display string. Fixes cursor display when a 'display' text
1882 property immediately follows invisible text. (Bug#11094)
1884 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1886 composite.c: use 'double' consistently
1887 * composite.c (get_composition_id): Use 'double' consistently
1888 instead of converting 'float' to 'double' and vice versa; this is
1889 easier to understand and avoids a GCC warning.
1891 2012-04-09 Glenn Morris <rgm@gnu.org>
1893 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1894 preparation for dumping it with emacs. (Bug#4789)
1895 (leimdir): New variable.
1896 ($(leimdir)/leim-list.el): New rule.
1897 (emacs$(EXEEXT)): Depend on leim-list.el.
1899 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1900 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1901 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1903 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1905 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1908 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1910 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1911 Remove unused local variable.
1913 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1915 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1916 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1917 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1918 objects, as mark_maybe_pointer will catch them otherwise.
1919 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1920 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1922 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1924 Fix typo that broke non-Windows builds.
1925 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1927 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1929 Support building on MS-Windows with libxml2.
1931 * makefile.w32-in (OBJ2): Add xml.$(O).
1932 (GLOBAL_SOURCES): Add xml.c.
1933 ($(BLD)/xml.$(O)): New dependency list.
1935 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1936 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1937 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1938 [!WINDOWSNT]: New macros.
1939 (init_libxml2_functions, libxml2_loaded_p): New functions.
1940 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1941 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1942 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1943 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1945 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1946 Call init_libxml2_functions before calling libxml2 functions.
1947 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1949 * emacs.c: Don't include libxml/parser.h.
1950 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1951 xmlCleanupParser directly.
1953 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1955 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1957 * indent.c (Fvertical_motion): If there is a display string at
1958 point, use it.vpos to compute how many lines to backtrack after
1959 move_it_to point. (Bug#11133)
1961 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1963 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1964 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1965 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1966 macros related to unification of CJK characters. For the details,
1967 see the discussion following the message here:
1968 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1970 2012-04-04 Chong Yidong <cyd@gnu.org>
1972 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1974 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1976 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1977 instead of alloca. (Bug#11138)
1979 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1981 * w32menu.c (is_simple_dialog): Properly check lisp types.
1984 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1986 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1987 position we get to after a call to move_it_to fails the
1988 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1989 only if we wind up in a string from display property. (Bug#11063)
1991 * window.c (Fdelete_other_windows_internal): Invalidate the row
1992 and column information about mouse highlight, so that redisplay
1993 restores it after reallocating the glyph matrices. (Bug#7464)
1995 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1996 string comes from a `display' text property, use the buffer
1997 position of that property as if we actually saw that position in
1999 (move_it_by_lines): Remove the assertion that
2000 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2001 violated when there's a before-string at the beginning of a line.
2004 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2006 * xdisp.c (append_space_for_newline): If the default face was
2007 remapped, use the remapped face for the appended newline.
2008 (extend_face_to_end_of_line): Use the remapped default face for
2009 extending the face to the end of the line.
2010 (display_line): Call extend_face_to_end_of_line when the default
2011 face was remapped. (Bug#11068)
2013 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2015 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2017 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2019 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2021 2012-03-27 Glenn Morris <rgm@gnu.org>
2023 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2026 2012-03-26 Kenichi Handa <handa@m17n.org>
2028 * dispextern.h (struct glyph): Fix previous change. Change the
2029 bit length of glyphless.ch to 25 (Bug#11082).
2031 2012-03-26 Chong Yidong <cyd@gnu.org>
2033 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2034 (command_loop_1): Use it; inhibit selection update for
2035 handle-select-window too (Bug#8996).
2037 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2039 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2041 2012-03-25 Kenichi Handa <handa@m17n.org>
2043 * dispextern.h (struct glyph): Change the bit length of
2044 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2046 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2048 * s/ms-w32.h (tzname): Include time.h before redirecting to
2049 _tzname. Fixes the MSVC build. (Bug#9960)
2051 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2053 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2056 * xterm.c (XTread_socket): Only modify handling_signal if
2057 !SYNC_INPUT. (Bug#11080)
2059 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2061 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2062 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2063 when fetching a multibyte character consumes more bytes than
2064 CHAR_BYTES returns, due to unification of CJK characters in
2065 string_char. (Bug#11073)
2067 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2069 * process.c (wait_reading_process_output): Handle pty disconnect
2070 by refraining from sending oneself a SIGCHLD (bug#10933).
2072 2012-03-22 Chong Yidong <cyd@gnu.org>
2074 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2076 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2077 Mark string as coming from a prefix property.
2078 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2079 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2081 2012-03-21 Chong Yidong <cyd@gnu.org>
2083 * xfaces.c (Vface_remapping_alist): Doc fix.
2085 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2087 * w32proc.c (Fw32_set_console_codepage)
2088 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2091 2012-03-20 Chong Yidong <cyd@gnu.org>
2093 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2094 to reflect default non-nil value of redisplay-dont-pause.
2096 2012-03-19 Kenichi Handa <handa@m17n.org>
2098 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2099 it fit in a valid range (Bug#11003).
2101 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2104 that is not from display property, accept the row as a "cursor
2105 row" if one of the string's character has a non-nil `cursor'
2106 property. Fixes cursor positioning when there are newlines in
2107 overlay strings, e.g. in icomplete.el. (Bug#11035)
2109 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2111 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2113 2012-03-12 Chong Yidong <cyd@gnu.org>
2115 * eval.c (inhibit_lisp_code): Rename from
2116 inhibit_window_configuration_change_hook; move from window.c.
2118 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2119 * window.c (run_window_configuration_change_hook)
2120 (syms_of_window): Callers changed.
2122 2012-03-11 Chong Yidong <cyd@gnu.org>
2124 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2126 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2128 2012-03-10 Chong Yidong <cyd@gnu.org>
2130 * frame.c (other_visible_frames): Don't assume the selected frame
2131 is visible (Bug#10955).
2133 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2135 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2137 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2139 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2140 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2143 2012-03-03 Glenn Morris <rgm@gnu.org>
2145 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2147 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2149 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2150 position past the first glyph_row that ends at ZV. (Bug#10902)
2151 (redisplay_window, next_element_from_string): Fix typos in
2153 (redisplay_window): Pass to move_it_vertically the margin in
2154 pixels, not in screen lines.
2156 2012-03-02 Glenn Morris <rgm@gnu.org>
2158 * buffer.c (buffer-list-update-hook): Doc fix.
2160 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2162 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2163 push_it before setting up the iterator for the first overlay
2164 string, even if we have an empty string loaded.
2165 (next_overlay_string): If there's an empty string on the iterator
2166 stack, pop the stack. (Bug#10903)
2168 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2170 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2171 Suggested by Stefan Monnier in
2172 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2173 * alloc.c (widen_to_Lisp_Object): New static function.
2174 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2175 and widening them to Lisp_Objects. This would work even if
2176 USE_LSB_TAG is defined and wide integers are used, which might
2177 happen in a future version of Emacs.
2179 2012-02-25 Chong Yidong <cyd@gnu.org>
2181 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2184 * xselect.c (Fx_selection_exists_p): Doc fix.
2185 (x_clipboard_manager_save_all): Print an informative message
2186 before saving to clipboard manager.
2188 2012-02-24 Chong Yidong <cyd@gnu.org>
2190 * keyboard.c (process_special_events): Handle all X selection
2191 requests in kbd_buffer, not just the next one (Bug#8869).
2193 2012-02-23 Chong Yidong <cyd@gnu.org>
2195 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2196 call when setting menu-bar-lines and tool-bar-lines parameters.
2197 (unwind_create_frame_1): New helper function.
2199 * window.c (inhibit_window_configuration_change_hook): New var.
2200 (run_window_configuration_change_hook): Obey it.
2201 (syms_of_window): Initialize it.
2203 2012-02-22 Chong Yidong <cyd@gnu.org>
2205 * xterm.c (x_draw_image_relief): Add missing type check for
2206 Vtool_bar_button_margin (Bug#10743).
2208 2012-02-21 Chong Yidong <cyd@gnu.org>
2210 * fileio.c (Vfile_name_handler_alist): Doc fix.
2212 * buffer.c (Fget_file_buffer): Protect against invalid file
2213 handler return value.
2215 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2217 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2218 when computing $valmask.
2220 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2221 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2222 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2223 It's useless in that case, and it can cause problems on hosts
2224 that allocate halves of EMACS_INT values separately.
2225 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2226 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2227 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2228 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2229 it avoids undefined behavior on hosts where shifting right by more
2230 than the word width has undefined behavior.
2232 2012-02-19 Chong Yidong <cyd@gnu.org>
2234 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2235 (Funhandled_file_name_directory, Ffile_name_as_directory)
2236 (Fdirectory_file_name, Fexpand_file_name)
2237 (Fsubstitute_in_file_name): Protect against invalid file handler
2238 return values (Bug#10845).
2240 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2242 * .gdbinit (pitx): Fix incorrect references to fields of the
2245 2012-02-17 Chong Yidong <cyd@gnu.org>
2247 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2249 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2251 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2252 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2254 2012-02-15 Chong Yidong <cyd@gnu.org>
2256 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2257 marked as special. Also, starting docstrings with * is obsolete.
2259 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2261 * gnutls.c (emacs_gnutls_write): Fix last change.
2263 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2265 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2268 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2270 * keymap.c (Fsingle_key_description): Handle char ranges.
2272 2012-02-12 Chong Yidong <cyd@gnu.org>
2274 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2275 as that creates a dangerous corner case.
2277 * window.c (Fdelete_window_internal): Invalidate the mouse
2278 highlight (Bug#9904).
2280 2012-02-12 Glenn Morris <rgm@gnu.org>
2282 * xselect.c (Fx_own_selection_internal)
2283 (Fx_get_selection_internal, Fx_disown_selection_internal)
2284 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2285 * nsselect.m (Fx_own_selection_internal)
2286 (Fx_disown_selection_internal, Fx_selection_exists_p)
2287 (Fx_selection_owner_p, Fx_get_selection_internal):
2288 Sync docs and argument specs with the xselect.c versions.
2290 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2292 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2294 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2296 * w32select.c (Fx_selection_exists_p): Sync doc string and
2297 argument list with xselect.c. (Bug#10783)
2299 * w16select.c (Fx_selection_exists_p): Sync doc string and
2300 argument list with xselect.c. (Bug#10783)
2302 2012-02-10 Glenn Morris <rgm@gnu.org>
2304 * fns.c (Fsecure_hash): Doc fix.
2306 2012-02-09 Kenichi Handa <handa@m17n.org>
2308 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2310 2012-02-07 Chong Yidong <cyd@gnu.org>
2312 * buffer.c (Fbuffer_local_variables)
2313 (buffer_lisp_local_variables): Handle unbound vars correctly;
2314 don't let Qunbound leak into Lisp.
2316 2012-02-07 Glenn Morris <rgm@gnu.org>
2318 * image.c (Fimagemagick_types): Doc fix.
2320 * image.c (imagemagick-render-type): Change it from a lisp object
2321 to an integer. Move the doc here from the lisp manual.
2322 Treat all values not equal to 0 the same.
2324 2012-02-06 Chong Yidong <cyd@gnu.org>
2326 * doc.c (store_function_docstring): Avoid applying docstring of
2327 alias to base function (Bug#2603).
2329 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2331 * .gdbinit (pp1, pv1): Remove redundant defines.
2334 2012-02-04 Chong Yidong <cyd@gnu.org>
2336 * nsterm.m: Declare a global (Bug#10694).
2338 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2340 * w32.c (get_emacs_configuration_options):
2341 Include --enable-checking, if specified, in the return value.
2343 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2345 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2346 after rounding frame sizes. (Bug#9723)
2348 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2350 * keyboard.c (adjust_point_for_property): Don't position point
2351 before BEGV. (Bug#10696)
2353 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2355 Handle overflow when computing char display width (Bug#9496).
2356 * character.c (char_width): Return EMACS_INT, not int.
2357 (char_width, c_string_width): Check for overflow when
2358 computing the width; this is possible now that individual
2359 characters can have unbounded width. Problem introduced
2360 by merge from Emacs 23 on 2012-01-19.
2362 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2364 * dbusbind.c (Fdbus_register_method): Mention the return value
2365 :ignore in the docstring.
2367 2012-02-02 Glenn Morris <rgm@gnu.org>
2369 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2371 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2372 Unconditionally set to t. (Bug#10673)
2373 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2374 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2375 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2377 2012-02-02 Kenichi Handa <handa@m17n.org>
2379 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2380 0, do not call append_composite_glyph.
2382 2012-02-02 Kenichi Handa <handa@m17n.org>
2384 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2386 (x_produce_glyphs): If the component of a composition is a null
2387 string, set it->pixel_width to 1 to avoid zero-width glyph.
2389 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2391 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2392 first 2 arguments are identical. This makes inserting large
2393 output from a subprocess an order of magnitude faster on
2394 MS-Windows, where all sbrk'ed memory is always contiguous.
2396 2012-01-31 Glenn Morris <rgm@gnu.org>
2398 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2399 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2400 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2402 2012-01-29 Glenn Morris <rgm@gnu.org>
2404 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2406 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2408 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2410 2012-01-28 Chong Yidong <cyd@gnu.org>
2412 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2414 2012-01-26 Chong Yidong <cyd@gnu.org>
2416 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2418 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2419 repeat counts (Bug#10507).
2421 2012-01-26 Glenn Morris <rgm@gnu.org>
2423 * lread.c (syms_of_lread): Doc fix.
2425 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2427 * coding.c (encode_designation_at_bol): Change return value to
2430 2012-01-25 Chong Yidong <cyd@gnu.org>
2432 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2434 2012-01-21 Chong Yidong <cyd@gnu.org>
2436 * floatfns.c (Fcopysign): Make the second argument non-optional,
2437 since nil is not allowed anyway.
2439 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2441 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2442 (send_process): Likewise.
2444 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2446 * window.c (save_window_save, Fcurrent_window_configuration)
2447 (Vwindow_persistent_parameters): Do not use Qstate.
2448 Rewrite doc-strings.
2450 2012-01-19 Kenichi Handa <handa@m17n.org>
2452 * character.c (char_width): New function.
2453 (Fchar_width, c_string_width, lisp_string_width):
2454 Use char_width (Bug#9496).
2456 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2458 * window.c (Vwindow_persistent_parameters): New variable.
2459 (Fset_window_configuration, save_window_save): Handle persistent
2462 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2464 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2465 thrashing the stack of the thread. (Bug#9087)
2467 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2469 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2471 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2473 * xdisp.c (rows_from_pos_range): Handle the case where the
2474 highlight ends on a newline. (Bug#10464)
2475 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2476 he end column for display of highlight that ends on a newline
2479 2012-01-11 Glenn Morris <rgm@gnu.org>
2481 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2482 from load-path also when installation-directory is nil. (Bug#10208)
2484 2012-01-10 Glenn Morris <rgm@gnu.org>
2486 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2488 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2489 Update template values to be closer to their typical values these days.
2491 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2493 * xdisp.c (rows_from_pos_range): Accept additional argument
2494 DISP_STRING, and accept any glyph in a row whose object is that
2495 string as eligible for mouse highlight. Fixes mouse highlight of
2496 display strings from overlays. (Bug#10464)
2498 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2500 emacs: fix an auto-save permissions race condition (Bug#10400)
2501 * fileio.c (auto_saving_dir_umask): New static var.
2502 (Fmake_directory_internal): Use it.
2503 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2504 creating the directory. The old code temporarily assigns
2505 too-generous permissions to the directory.
2506 (do_auto_save_eh): Clear it.
2507 (Fdo_auto_save): Catch all errors, not just file errors, so
2508 that the var is always cleared.
2510 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2512 * search.c (scan_buffer): Pass character positions to
2513 know_region_cache, not byte positions. (Bug#6540)
2515 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2517 * w32.c (sys_rename): Report EXDEV when rename of a directory
2518 fails because the target is on another logical disk. (Bug#10284)
2520 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2522 * xterm.c (x_embed_request_focus): New function.
2524 * xterm.h: Add prototype.
2526 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2528 2012-01-05 Glenn Morris <rgm@gnu.org>
2530 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2532 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2534 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2535 Load gnutls_transport_set_lowat only if GnuTLS version is below
2537 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2538 GnuTLS versions below 2.11.1.
2540 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2542 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2543 to the doc string advising against its use for altering the way
2544 windows are scrolled.
2546 2011-12-28 Kenichi Handa <handa@m17n.org>
2548 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2549 coding-system ASCII compatible only when it does not produce BOM
2550 on encoding (Bug#10383).
2552 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2554 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2556 (create_and_show_popup_menu): Always use menu_position_func for
2559 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2561 * callint.c (Fcall_interactively): Don't truncate prompt string.
2563 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2565 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2566 property that ends at ZV, so that the bidi iteration could be
2567 resumed from there (after widening). (Bug#10360)
2569 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2571 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2573 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2575 * nsterm.m (x_free_frame_resources):
2576 Release f->output_data.ns->miniimage.
2577 (ns_index_color): Fix indentation. Do not retain
2578 color_table->colors[i].
2580 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2583 * nsfns.m (x_set_background_color): Assign return value from
2584 ns_index_color to face-background instead of NSColor*.
2585 (ns_implicitly_set_icon_type): Fix indentation.
2586 Change assignment in for loop to comparison.
2588 * emacs.c (ns_pool): New variable.
2589 (main): Assign ns_pool.
2590 (Fkill_emacs): Call ns_release_autorelease_pool.
2592 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2593 autorelease fdesc, release fdAttrs and tdict.
2594 (ns_get_covering_families): Release charset.
2595 (ns_findfonts): Release NSFontDescriptor created with new.
2596 (ns_uni_to_glyphs): Fix indentation.
2597 (setString): Release attrStr before assigning new value.
2599 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2601 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2603 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2604 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2606 2011-12-18 David Reitter <reitter@cmu.edu>
2608 * nsterm.m (ns_term_init): Subscribe for notifications
2609 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2610 to method trackingNotification in EmacsMenu.
2612 * nsmenu.m (trackingMenu): New variable.
2613 (trackingNotification): New method (from Aquamacs).
2614 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2615 from Aquamacs (Bug#7030).
2617 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2619 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2620 (symbol_to_nsstring): Fix indentation.
2621 (ns_symbol_to_pb): New function.
2622 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2623 (Fns_rotate_cut_buffers_internal): Remove.
2624 (Fns_store_selection_internal): Rename from
2625 Fns_store_cut_buffer_internal.
2626 (ns_get_foreign_selection, Fx_own_selection_internal)
2627 (Fx_disown_selection_internal, Fx_selection_exists_p)
2628 (Fns_get_selection_internal, Fns_store_selection_internal):
2629 Use ns_symbol_to_pb and check if return value is nil.
2630 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2631 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2632 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2633 renamed to Sns_store_selection_internal.
2634 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2635 and remove this function.
2636 (ns_handle_selection_clear): Remove, never used.
2637 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2640 2011-12-17 Ken Brown <kbrown@cornell.edu>
2642 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2643 GID is unknown (Bug#10257).
2645 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2647 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2648 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2649 which caused a build failure on GNU/Linux IA-64. This problem was
2650 introduced by my 2011-10-07 patch.
2652 2011-12-15 Juri Linkov <juri@jurta.org>
2654 * image.c (imagemagick_error): New function. (Bug#10112)
2655 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2656 Use `imagemagick_error' where ImageMagick functions return
2658 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2661 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2663 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2664 fill background (Bug#8992).
2666 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2668 * window.c (Vwindow_combination_resize)
2669 (Vwindow_combination_limit): Use t instead of non-nil in
2671 (Vrecenter_redisplay): Add first sentence of doc-string on
2673 (Frecenter): Fix doc-string typo.
2675 2011-12-11 Kenichi Handa <handa@m17n.org>
2677 * coding.c (Funencodable_char_position): Pay attention to the
2678 buffer text relocation (Bug#9389).
2680 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2682 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2683 gtk_init (Bug#10100).
2685 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2687 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2688 IT->string is nil. (Bug#10263)
2690 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2692 * nsterm.h (x_free_frame_resources): Declare.
2694 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2695 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2697 * nsterm.h (ns_get_defaults_value): Declare.
2699 * nsterm.m (ns_default): Call ns_get_defaults_value.
2701 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2703 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2706 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2708 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2709 that where the value of an _OBJC_* symbol points to is in the .bss
2710 section (Bug#10240).
2712 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2714 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2715 after the loop to call ccl_driver at least once (Bug#8619).
2717 2011-12-08 Kenichi Handa <handa@m17n.org>
2719 * ftfont.c (get_adstyle_property): Fix previous change
2722 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2724 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2725 dirs from the default value of EMACSLOADPATH (bug#10208).
2727 2011-12-07 Glenn Morris <rgm@gnu.org>
2729 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2730 installation and source directories as well. (Bug#10208)
2732 2011-12-06 Chong Yidong <cyd@gnu.org>
2734 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2736 2011-12-06 Glenn Morris <rgm@gnu.org>
2738 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2739 as an error, not just -1. (Bug#10217)
2741 2011-12-05 Chong Yidong <cyd@gnu.org>
2743 * keyboard.c (process_special_events): New function.
2744 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2746 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2748 * coding.c (encode_designation_at_bol): Don't use uninitialized
2749 local variable (Bug#9318).
2751 2011-12-05 Kenichi Handa <handa@m17n.org>
2753 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2754 return Qnil (Bug#8046, Bug#10193).
2756 2011-12-05 Kenichi Handa <handa@m17n.org>
2758 * coding.c (encode_designation_at_bol): New args charbuf_end and
2759 dst. Return the number of produced bytes. Callers changed.
2760 (coding_set_source): Return how many bytes coding->source was
2762 (coding_set_destination): Return how many bytes
2763 coding->destination was relocated.
2764 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2765 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2767 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2769 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2770 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2773 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2775 The following changes are to fix Bug#9318.
2777 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2778 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2779 (encode_coding_iso_2022, encode_coding_sjis)
2780 (encode_coding_big5, encode_coding_charset): Use the above macros.
2782 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2784 * lisp.h (process_quit_flag): Fix external declaration.
2786 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2788 Don't macro-inline non-performance-critical code.
2789 * eval.c (process_quit_flag): New function.
2790 * lisp.h (QUIT): Use it.
2792 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2794 * nsfns.m (get_geometry_from_preferences): New function.
2795 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2797 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2799 * emacs.c (Qkill_emacs): Define.
2800 (syms_of_emacs): Initialize it.
2801 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2802 Qquit_flag to `kill-emacs' instead.
2803 (quit_throw_to_read_char): Add parameter `from_signal'.
2804 All callers changed. Call Fkill_emacs if requested and safe.
2805 * lisp.h (QUIT): Call Fkill_emacs if requested.
2807 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2809 * widget.c (update_wm_hints): Return if wmshell is null.
2810 (widget_update_wm_size_hints): New function.
2812 * widget.h (widget_update_wm_size_hints): Declare.
2814 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2815 widget_update_wm_size_hints (Bug#10104).
2817 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2819 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2820 before a newline, prepare the bidi iterator for consuming the
2821 newline, and keep the current paragraph direction. (Bug#10183)
2822 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2824 2011-12-02 Juri Linkov <juri@jurta.org>
2826 * search.c (Fword_search_regexp): New Lisp function created from
2827 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2828 (Fword_search_backward, Fword_search_forward)
2829 (Fword_search_backward_lax, Fword_search_forward_lax):
2830 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2831 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2833 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2835 * fileio.c (Finsert_file_contents): Move after-change-function call
2836 to before the "handled:" label, since all "goto handled" appear in
2837 cases where the *-change-functions have already been properly called
2840 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2842 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2843 waiting for input. (Bug#10169)
2845 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2847 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2848 verifies glyph row's hash code--we have just reallocated the
2849 glyphs, so their contents can be complete garbage. (Bug#10164)
2851 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2853 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2855 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2857 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2858 attributes are tested _before_ calling verify_row_hash, to protect
2859 against GCC re-ordering of the tests. (Bug#10164)
2861 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2863 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2865 * xterm.c (handle_one_xevent): Only set async_visible and friends
2866 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2867 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2868 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2870 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2872 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2873 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2874 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2875 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2876 All uses changed to use GCPRO1 etc.
2877 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2878 Revert to old implementation (i.e., before 2011-03-11).
2880 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2882 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2883 of scroll runs so as to avoid assigning disabled bogus rows and
2884 unnecessary graphics copy operations.
2886 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2888 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2889 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2890 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2891 (malloc, free, realloc, calloc): Redirect to e_* only when
2894 * lisp.h (GCTYPEBITS): Move before first use.
2895 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2896 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2897 this macro definition.
2899 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2902 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2904 * gtkutil.c (xg_create_frame_widgets):
2905 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2906 present with Gtk+ 2.0.
2908 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2910 * fileio.c (Finsert_file_contents): Undo previous change; see
2911 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2913 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2915 Rename locals to avoid shadowing.
2916 * fileio.c (Finsert_file_contents):
2917 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2918 * process.c (wait_reading_process_output):
2919 Rename inner 'proc' to 'p' to avoid shadowing.
2920 Indent for consistency with usual Emacs style.
2922 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2924 * xdisp.c (redisplay_window): If cursor row is not fully visible
2925 after recentering, and scroll-conservatively is set to a large
2926 number, scroll window by a few more lines to make the cursor fully
2927 visible and out of scroll-margin. (Bug#10105)
2928 (start_display): Don't move to the next line if the display should
2929 start at a newline that is part of a display vector or an overlay
2932 2011-11-24 Juri Linkov <juri@jurta.org>
2934 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2935 after the `MagickPingImage' call. (Bug#10112)
2937 2011-11-23 Chong Yidong <cyd@gnu.org>
2939 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2941 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2943 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2944 making another buffer current. (Bug#10114)
2946 2011-11-23 Glenn Morris <rgm@gnu.org>
2948 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2950 2011-11-23 Chong Yidong <cyd@gnu.org>
2952 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2953 using it (Bug#5984).
2955 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2957 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2958 and header-lines, as they don't have one computed for them.
2961 * .gdbinit (prow): Make displayed values more self-explaining.
2962 Add row's hash code.
2964 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2966 * process.c (wait_reading_process_output): Fix asynchrounous
2967 GnuTLS socket handling on some versions of the GnuTLS library.
2968 (wait_reading_process_output): Add comment and URL.
2970 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2972 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2974 2011-11-21 Chong Yidong <cyd@gnu.org>
2976 * window.c (Fnext_window, Fprevious_window): Doc fix.
2978 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2980 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2982 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2984 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2986 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2988 * window.c (Fset_window_combination_limit): Rename argument
2990 (Vwindow_combination_limit): Remove "status" from doc-string.
2992 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2994 * m/ibms390.h: Remove.
2995 * m/ibms390x.h: Don't include "ibms390.h".
2997 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2999 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3000 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3002 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3004 * casetab.c (Fset_case_table):
3005 * charset.c (Fcharset_after): Fix typos.
3007 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3009 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3010 Otherwise, valgrind does not work on some platforms.
3011 Problem reported by Andreas Schwab in
3012 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3013 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3014 is set, removing the need for VIRT_ADDRESS_VARIES.
3015 (PURE_P): Use a more-efficient implementation that needs just one
3016 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3017 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3018 to 4 (xorl, subq, cmpq, setbe).
3019 * alloc.c (pure): Always extern now, since that's the
3020 VIRT_ADDR_VARIES behavior.
3021 (PURE_POINTER_P): Use a single comparison, not two, for
3022 consistency with the new puresize.h.
3023 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3024 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3025 Remove VIRT_ADDR_VARIES no longer needed.
3027 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3029 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3030 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3031 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3032 behave as if the cursor position were at the window margin.
3034 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3035 and the cursor position is out of bounds, behave as if the cursor
3036 position were at the window margin. (Bug#10075)
3038 2011-11-18 Chong Yidong <cyd@gnu.org>
3040 * window.c (Fwindow_combination_limit): Make first argument
3041 non-optional, since it is meaningless for live windows like the
3044 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3046 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3048 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3050 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3051 (graft_intervals_into_buffer): Simplify.
3053 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3055 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3056 hash values of the two rows.
3057 (copy_row_except_pointers): Preserve the used[] arrays and the
3058 hash values of the two rows. (Bug#10035)
3059 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3061 * xdisp.c (row_hash): New function, body extracted from
3062 compute_line_metrics.
3063 (compute_line_metrics): Call row_hash, instead of computing the
3066 * dispnew.c (verify_row_hash): Call row_hash for computing the
3067 hash code of a row, instead of duplicating code from xdisp.c.
3069 * dispextern.h (row_hash): Add prototype.
3071 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3073 * frame.c (delete_frame): Don't delete the terminal when the last
3074 X frame is closed if emacs is built with GTK toolkit.
3076 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3078 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3080 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3082 * window.c (Vwindow_splits): Rename to
3083 Vwindow_combination_resize. Suggested by Juri Linkov.
3084 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3087 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3089 * nsfns.m (Fns_font_name):
3090 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3092 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3094 * window.h (window): Rename slot "nest" to "combination_limit".
3095 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3096 (Fset_window_nest): Rename to Fset_window_combination_limit.
3097 (Vwindow_nest): Rename to Vwindow_combination_limit.
3098 (recombine_windows, make_parent_window, make_window)
3099 (Fsplit_window_internal, saved_window)
3100 (Fset_window_configuration, save_window_save): Rename all
3101 occurrences of window_nest to window_combination_limit.
3103 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3105 * image.c (imagemagick_load_image): Fix typo.
3107 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3109 * xdisp.c (display_line): Move the call to
3110 highlight_trailing_whitespace before the call to
3111 compute_line_metrics, since the latter needs to see the final
3112 faces of all the glyphs to compute ROW's hash value.
3113 Fixes assertion violations in row_equal_p. (Bug#10035)
3115 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3117 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3118 just return (bug#10044).
3120 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3122 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3123 with user-defined heap size. Bump the default size of the temacs
3124 heap to 27MB, to avoid memory warning when running temacs.
3125 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3127 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3128 current_matrix and desired_matrix. (Bug#9990)
3129 (verify_row_hash) [XASSERTS]: New function.
3130 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3131 that the hash value of glyph rows is correct.
3133 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3135 * window.h (window): Remove splits slot.
3136 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3137 (Fdelete_other_windows_internal, make_parent_window)
3138 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3139 (Fset_window_configuration, save_window_save): Don't deal with
3140 split status of windows.
3141 (saved_window): Remove splits slot.
3142 (Vwindow_splits): Rewrite doc-string.
3144 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3146 * xfns.c (unwind_create_frame):
3147 * nsfns.m (unwind_create_frame):
3148 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3149 Vframe_list (Bug#9999).
3151 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3153 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3155 2011-11-11 Kenichi Handa <handa@m17n.org>
3157 * callproc.c (Fcall_process): Set the member dst_multibyte of
3160 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3162 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3163 avoid a crash (bug#9496).
3165 2011-11-09 Chong Yidong <cyd@gnu.org>
3167 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3168 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3170 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3172 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3174 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3176 Avoid some portability problems by eschewing 'extern inline' functions.
3177 The trivial performance wins aren't worth the portability hassles; see
3178 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3180 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3181 (window_box_width, window_box_left, window_box_left_offset)
3182 (window_box_right, window_box_right_offset): Undo previous change,
3183 by removing the "extern"s.
3184 * intervals.c (adjust_intervals_for_insertion)
3185 (adjust_intervals_for_deletion): Undo previous change,
3186 making these static again.
3187 (offset_intervals, temp_set_point_both, temp_set_point)
3188 (copy_intervals_to_string): No longer inline.
3189 * xdisp.c (window_text_bottom_y, window_box_width)
3190 (window_box_height, window_box_left_offset)
3191 (window_box_right_offset, window_box_left, window_box_right)
3192 (window_box): No longer inline.
3194 2011-11-08 Chong Yidong <cyd@gnu.org>
3196 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3197 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3198 Signal an error if not a live window.
3199 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3200 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3202 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3204 * lisp.h (syms_of_abbrev): Remove declaration.
3205 Reported by CHENG Gao <chenggao@royau.me>.
3207 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3209 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3210 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3211 of temacs in GUI mode.
3213 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3215 * window.h: Declare delete_all_child_windows instead of
3216 delete_all_subwindows.
3217 * window.c (Fwindow_nest, Fset_window_nest)
3218 (Fset_window_new_total, Fset_window_new_normal)
3219 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3220 (delete_all_subwindows): Rename to delete_all_child_windows.
3221 (Fdelete_other_windows_internal, Fset_window_configuration):
3222 Call delete_all_child_windows instead of delete_all_subwindows.
3223 * frame.c (delete_frame): Call delete_all_child_windows instead
3224 of delete_all_subwindows.
3226 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3228 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3229 This is also needed for porting to any host where GC_MARK_STACK is
3230 not GC_MAKE_GCPROS_NOOPS.
3231 (which_symbols): Use it.
3233 2011-11-07 Kenichi Handa <handa@m17n.org>
3235 * coding.c (coding_set_destination): Check coding->src_pos only
3236 when coding->src_object is a buffer (bug#9910).
3238 * process.c (send_process): Set the member src_multibyte of coding
3239 to 0 (bug#9911) when sending a unibyte text.
3241 * callproc.c (Fcall_process): Set the member src_multibyte of
3242 process_coding to 0 (bug#9912).
3244 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3246 * xmenu.c (cleanup_widget_value_tree): New function.
3247 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3248 calling free_menubar_widget_value_tree directly (Bug#9830).
3250 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3252 Fix some portability problems with 'inline'.
3253 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3254 (window_box_width, window_box_left, window_box_left_offset)
3255 (window_box_right, window_box_right_offset): Declare extern.
3256 Otherwise, these inline functions do not conform to C99 and
3257 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3258 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3259 * intervals.c (adjust_intervals_for_insertion)
3260 (adjust_intervals_for_deletion): Now extern, because otherwise the
3261 extern inline functions 'offset_intervals' couldn't refer to it.
3262 (static_offset_intervals): Remove.
3263 (offset_intervals): Rewrite using the old contents of
3264 static_offset_intervals. The old version didn't conform to C99
3265 because an extern inline function contained a reference to an
3266 identifier with static linkage.
3268 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3270 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3273 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3275 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3276 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3277 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3278 return Qleft_to_right.
3280 2011-11-06 Chong Yidong <cyd@gnu.org>
3282 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3283 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3284 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3285 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3286 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3287 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3288 (Fwindow_vscroll): Doc fix.
3289 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3290 argument, since it makes no sense to pass a live window and for
3291 consistency with window-child.
3293 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3295 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3298 2011-11-05 Jason Rumney <jasonr@gnu.org>
3300 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3301 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3303 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3304 bitwise arithmetic preventing use of unicode-sip and non-truetype
3307 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3309 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3312 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3313 initialization code to keep similarity to xfns.c after changes
3316 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3318 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3319 (unwind_create_frame): New function (Bug#9943).
3320 (Fx_create_frame): Restructure code to be more similar to the one in
3321 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3322 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3323 Move terminal->reference_count++ just before making the frame official
3326 * nsterm.m (x_free_frame_resources): New function.
3327 (x_destroy_window): Move code to x_free_frame_resources.
3329 * xfns.c (unwind_create_frame): Fix comment.
3330 (Fx_create_frame, x_create_tip_frame):
3331 Move terminal->reference_count++ just before making the frame
3332 official. Move initialization of image_cache_refcount and
3333 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3335 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3337 Support MSVC build with newer versions of Visual Studio.
3338 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3339 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3342 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3343 which are not supported by MSVC.
3344 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3345 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3347 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3349 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3351 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3353 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3355 Support MSVC build with newer versions of Visual Studio.
3356 * w32.c: Don't include w32api.h for MSVC.
3357 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3359 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3360 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3361 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3362 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3364 (alloca) [_MSC_VER]: Define to _alloca.
3366 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3368 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3370 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3372 * xdisp.c (note_mouse_highlight): If either of
3373 previous/next-single-property-change returns nil, treat that as
3374 the beginning or the end of the buffer. (Bug#9955)
3376 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3378 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3379 label is not null (Bug#9951).
3380 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3383 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3385 * window.c (Fwindow_body_size): Mention in the doc string that the
3386 return value is in frame's canonical units. (Bug#9949)
3388 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3390 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3392 * w32fns.c (unwind_create_frame): If needed, free the glyph
3393 matrices of the partially constructed frame. (Bug#9943)
3394 * xfns.c (unwind_create_frame): Likewise.
3396 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3398 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3399 Don't stop backward scan on the continuation glyph, even though
3400 its CHARPOS is positive.
3401 (mouse_face_from_buffer_pos, note_mouse_highlight):
3402 Rename cover_string to disp_string.
3404 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3406 * window.c (temp_output_buffer_show): Don't use
3407 Vtemp_buffer_show_specifiers.
3408 (Vtemp_buffer_show_specifiers): Remove unused variable.
3410 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3412 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3413 past the beginning of the current glyph matrix.
3415 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3417 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3418 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3419 HAVE_GTK3 (Bug#9869).
3421 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3422 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3424 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3426 * xterm.c: Declare x_handle_net_wm_state to return int.
3427 (handle_one_xevent): Check if we are iconified but don't have
3428 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3429 (get_current_wm_state): Return non-zero if not hidden,
3430 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3431 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3432 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3433 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3435 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3437 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3438 so that this new function doesn't get optimized away by a
3439 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3441 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3443 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3445 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3447 Fix the `xbytecode' command.
3448 * .gdbinit (xprintbytestr): New command.
3449 (xwhichsymbols): Rename from `which'; all callers changed.
3450 (xbytecode): Print the byte-code string as well.
3452 2011-10-29 Kim Storm <storm@cua.dk>
3454 * alloc.c (which_symbols): New function.
3456 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3458 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3461 2011-10-29 Glenn Morris <rgm@gnu.org>
3463 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3464 Not clear what it was for, and it causes various bugs. (Bug#9839)
3466 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3468 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3469 possible random value that matches one of those tested as
3470 condition to clear the mouse face.
3472 2011-10-28 Chong Yidong <cyd@gnu.org>
3474 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3476 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3478 * window.c (make_window): Initialize phys_cursor_on_p.
3480 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3482 * lisp.h (struct Lisp_Symbol): Update comments.
3484 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3486 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3488 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3490 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3491 <oslsachem@gmail.com> for helping to debug this.
3493 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3494 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3495 (g_b_init_get_glyph_outline_w): New static variables.
3496 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3497 (GetGlyphOutlineW_Proc): New typedefs.
3498 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3499 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3501 (w32font_open_internal, compute_metrics):
3502 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3503 instead of calling the "wide" APIs directly.
3505 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3507 * w32.h (syms_of_w32font): Add prototype.
3509 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3511 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3512 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3513 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3514 (Fmove_to_window_line): Doc fix.
3516 2011-10-27 Chong Yidong <cyd@gnu.org>
3518 * process.c (make_process): Set gnutls_state to NULL.
3520 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3521 non-NULL, regardless of GNUTLS_INITSTAGE.
3522 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3523 an error. Set process slots as soon as we allocate them.
3525 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3527 2011-10-27 Chong Yidong <cyd@gnu.org>
3529 * gnutls.c (emacs_gnutls_deinit): New function.
3530 Deallocate credentials structures as well as calling gnutls_deinit.
3531 (Fgnutls_deinit, Fgnutls_boot): Use it.
3533 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3534 (deactivate_process): Call emacs_gnutls_deinit.
3536 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3538 * image.c (x_create_x_image_and_pixmap):
3539 * w32.c (sys_rename, w32_delayed_load):
3540 * w32font.c (fill_in_logfont):
3541 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3543 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3545 * w32fns.c (w32_default_color_map): New function,
3546 extracted from Fw32_default_color_map.
3547 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3549 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3551 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3553 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3555 * keyboard.c (test_undefined): New function (bug#9751).
3556 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3558 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3560 * sysdep.c (init_sys_modes): Fix the check for the controlling
3561 terminal (Bug#6649).
3563 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3565 * dispextern.h (struct bidi_it): New member next_en_type.
3567 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3568 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3569 current character, check also for next_en_type being WEAK_EN.
3570 (bidi_resolve_weak): Don't enter the expensive loop if the current
3571 position is before next_en_pos. Record the bidi type of the first
3572 non-ET, non-BN character we find, in addition to its position.
3573 (bidi_level_of_next_char): Invalidate next_en_type when
3574 next_en_pos is over-stepped.
3576 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3578 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3579 * editfns.c: Rewrite current-time-zone so that it invokes
3580 the equivalent of (format-time-string "%Z") to get the time zone name.
3581 This fixes a bug when the time zone name contains characters that
3582 need converting from the system time locale to Emacs internal format.
3583 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3584 that patch fixed format-time-string to do the conversion, but
3585 I forgot to fix current-time-zone.
3586 (format_time_string): New function, containing most of
3587 what Fformat_time_string used to contain.
3588 (Fformat_time_string): Rewrite in terms of format_time_string.
3589 This doesn't change this function's behavior.
3590 (current-time-zone): Rewrite to use format_time_string.
3591 This fixes the bug reported by Michael Schierl in
3592 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3593 Jason Rumney's 2007-06-07 change worked around this bug, but
3595 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3597 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3599 * xdisp.c (start_display): If the character at POS is displayed
3600 via a display vector, reset IT->current.dpvec_index to zero.
3601 (try_window_reusing_current_matrix): If a line ends in a display
3602 vector or the next line starts in a display vector, continue
3603 redrawing the window even though the character position of
3604 start_row was reached.
3607 2011-10-18 Chong Yidong <cyd@gnu.org>
3609 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3610 with nobreak-char-display too.
3612 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3614 Fix part 3 of bug#9771.
3615 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3616 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3617 non-neutral characters if the current character is a paragraph
3618 separator (a.k.a. Newline). This avoids running the same
3619 expensive loop twice, once when we consume the preceding newline
3620 and the other time when the line actually needs to be displayed.
3621 Avoid the loop when we see neutrals on the base embedding level
3622 following a character whose directionality is the same as the
3623 paragraph's. This avoids running the expensive loop when a line
3624 ends in a long sequence of neutrals, like control characters.
3625 Add assertion against STRONG_AL type. Slightly rearrange code
3626 that determines the type of a neutral given the first non-neutral
3628 (bidi_level_of_next_char): Set next_en_pos to zero when
3629 invalidating its info.
3631 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (push_display_prop): Determine whether to record string
3634 or buffer position by IT->string, not by IT->method. Allow
3635 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3636 (move_it_vertically_backward): Don't look for character position
3637 immediately after the newline when in a continuation line.
3640 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3642 * window.c (coordinates_in_window): Rewrite and delabelize
3643 vertical border check. (Bug#5357) (Bug#9618)
3645 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3647 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3648 errors in XSetWindowBorder (bug#9310).
3650 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3652 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3653 avoid crash when xmalloc overrun checking is enabled.
3655 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3657 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3658 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3659 cursor motion with <left> and <right> arrow keys.
3661 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3662 some callers set that themselves.
3664 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3666 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3667 display string and the previous row comes from the same string and
3668 is empty. (Bug#9739) (Bug#9738)
3670 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3672 * doc.c (get_doc_string): Encode file name (bug#9735).
3674 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3676 * bidi.c (bidi_level_of_next_char):
3677 * xdisp.c (get_visually_first_element): Remove old incorrect
3678 comments regarding the Unicode Line Separator character.
3680 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3682 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3684 * alloc.c (Fgc_status): Do not access beyond zombies array
3685 boundary if nzombies > MAX_ZOMBIES.
3686 * alloc.c (dump_zombies): Add missing format specifier.
3688 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3690 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3691 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3693 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3694 Some packages use them to denote characters with modifiers.
3696 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3698 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3699 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3700 matching a pp-number. Rename parameter var to var1.
3702 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3704 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3706 2011-10-08 Glenn Morris <rgm@gnu.org>
3708 * callint.c (Fcall_interactively): Give a more explicit error for the
3709 'c' case with a non-character input. (Bug#8479)
3711 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3713 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3715 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3716 lines that are hscrolled on the left.
3718 * dispnew.c (buffer_posn_from_coords): Account for a possible
3719 presence of header-line. (Bug#4426)
3721 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3723 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3724 Don't advertise functionality which we discourage or doesn't work.
3726 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3728 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3729 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3730 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3731 this makes Emacs dump core during garbage collection on rare
3732 occasions. sizeof is obviously inferior to offsetof here, so
3733 stick with offsetof.
3734 (GC_POINTER_ALIGNMENT): New macro.
3735 (mark_memory): Omit 3rd (offset) arg; caller changed.
3736 Don't assume EMACS_INT alignment is the same as pointer alignment.
3738 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3740 * keyboard.c (read_key_sequence_remapped): New var.
3741 (read_key_sequence): Compute remapping in the right buffer.
3742 (command_loop_1): Use read_key_sequence's remapping directly.
3744 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3746 * dired.c (file_name_completion): Don't expand file name.
3747 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3748 before checking file name handler.
3750 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3751 they've been requested explicitly (bug#9591).
3753 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3755 * keymap.c (Fsingle_key_description): Use make_specified_string
3756 instead of build_string to build string from push_key_description.
3759 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3761 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3762 This fixes a Y2038 bug on 64-bit hosts.
3763 * buffer.c (reset_buffer):
3764 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3765 (Fclear_buffer_auto_save_failure):
3766 Use 0, not -1, to represent an unset failure time, since time_t
3767 might not be signed.
3769 Remove dependency on glibc malloc internals.
3770 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3771 Move back here from lisp.h, but with their new implementations.
3772 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3773 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3774 * charset.c (charset_table_init): New static var.
3775 (syms_of_charset): Use it instead of xmalloc. This removes a
3776 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3777 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3778 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3779 Move back to alloc.c.
3780 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3781 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3783 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3785 * nsterm.m (windowDidResize): Call x_set_window_size only when
3786 ns_in_resize is true. Otherwise set pixelwidth/height and
3787 call change_frame_size (Bug#9628).
3789 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3791 Port --enable-checking=all to Fedora 14 x86-64.
3792 * charset.c (syms_of_charset): Also account for glibc malloc's
3793 internal overhead when calculating the initial malloc maximum.
3795 Port --enable-checking=all to Fedora 14 x86.
3796 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3798 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3799 (overrun_check_realloc, overrun_check_free):
3800 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3801 That way, xmalloc returns a properly-aligned pointer even if
3802 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3803 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3804 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3805 into account when calculating the initial malloc maximum.
3806 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3807 Move here from alloc.c, so that charset.c can use it too.
3808 Properly align; the old code wasn't right for common 32-bit hosts
3809 when configured with --enable-checking=all.
3810 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3811 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3813 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3815 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3818 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3820 * xdisp.c (compute_display_string_end): If there's no display
3821 string at CHARPOS, return -1.
3823 * bidi.c (bidi_fetch_char): When compute_display_string_end
3824 returns a negative value, treat the character as a normal
3825 character not covered by a display string. (Bug#9624)
3827 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3829 * lread.c (Fread_from_string): Fix typo in docstring.
3831 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3833 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3834 newline, reseat the iterator instead of bidi-iterating there one
3835 character at a time. (Bug#9610)
3836 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3837 TO_CHARPOS if the bidi iterator is at base embedding level.
3839 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3841 * lread.c (readevalloop): Use correct code for NBSP.
3842 (read1): Likewise. (Bug#9608)
3844 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3846 * dbusbind.c (Fdbus_register_signal): When service is not
3847 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3849 2011-09-25 Glenn Morris <rgm@gnu.org>
3851 * buffer.c (truncate-lines): Doc fix.
3853 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3855 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3856 (Fset_window_next_buffers): Doc fix.
3858 2011-09-24 Glenn Morris <rgm@gnu.org>
3860 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3862 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3864 Fix minor problems found by static checking.
3865 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3866 * indent.c (Fvertical_motion): Fix == vs = typo.
3868 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3870 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3871 Default value is now t. Doc fix.
3873 * indent.c (Fvertical_motion): Compute and apply the overshoot
3874 logic when moving up, not only when moving down. Fix the
3875 confusing name and values of the it_overshoot_expected variable;
3876 logic changes accordingly. (Bug#9254) (Bug#9549)
3878 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3879 CHARPOS is covered by a display string which includes newlines.
3880 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3881 is covered by a display string with embedded newlines.
3883 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3885 * dbusbind.c (Fdbus_register_signal): Add match rule to
3886 Vdbus_registered_objects_table. (Bug#9581)
3887 (Fdbus_register_method, Vdbus_registered_objects_table):
3890 2011-09-24 Jim Meyering <meyering@redhat.com>
3892 do not ignore write error for any output size
3893 The previous change was incomplete.
3894 While it makes emacs --batch detect the vast majority of stdout
3895 write failures, errors were still ignored whenever the output size is
3896 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3897 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3898 && echo FAIL: ignored write error
3899 FAIL: ignored write error
3900 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3901 && echo FAIL: ignored write error
3902 FAIL: ignored write error
3903 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3905 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3907 * emacs.c (Fkill_emacs): In noninteractive mode exit
3908 non-successfully if a write error occurred on stdout. (Bug#9574)
3910 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3912 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3915 * dispextern.h (struct it): Update the comment documenting what
3918 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3920 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3921 a display string, extend search for cursor position to end of row.
3922 (find_row_edges): If the row ends in a newline from a display
3923 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3924 Handle the case of a display string with multiple newlines.
3925 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3926 non-empty line. Fixes confusing cursor motion with arrow keys at
3927 the beginning of a line that starts with whitespace.
3929 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3931 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3934 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3936 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3939 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3941 * xdisp.c (display_line): Record maximum and minimum buffer
3942 positions even if no glyphs were produced (e.g., by a zero-width
3943 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3944 buffer positions that will be removed from the glyph row because
3946 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3947 column is beyond frame width: don't subtract 1 "pixel" when
3948 computing width of the stretch.
3949 (reseat_at_next_visible_line_start): Undo the change made on
3950 2011-09-17 that saved paragraph information and restored it after
3951 the call to `reseat'. (Bug#9545)
3953 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3955 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3956 and turn window cursor on if cleared (Bug#9415).
3958 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3960 * search.c (boyer_moore): Take unibyte characters from pattern
3961 literally. (Bug#9458)
3963 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3965 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3967 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3969 Fix minor problem found by static checking.
3970 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3971 initialized, to pacify gcc -Wuninitialized.
3973 * fileio.c: Report proper errno when syscall falls.
3974 (Finsert_file_contents): Save and restore errno,
3975 so that report_file_error outputs the correct diagnostic.
3976 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3978 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3980 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3982 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3984 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3985 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3987 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3989 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3990 about the current paragraph and restore it after the call to reseat.
3992 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3993 (bidi_find_paragraph_start): Search back for paragraph beginning
3994 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3995 (bidi_move_to_visually_next): Only trigger paragraph-related
3996 computations when the last character is a newline or at EOB, not
3997 just any NEUTRAL_B. (Bug#9470)
3999 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4000 truncated lines if point is covered by a display string. (Bug#9524)
4002 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4004 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4005 (cons_to_x_long): New function.
4006 (lisp_data_to_selection_data): Use it. Correct the test for
4007 short-versus-long data; it was negated. Break out of vector
4008 loop, for efficiency, when a long datum is discovered.
4010 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4012 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4014 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4016 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4017 GCC PR/17406) by declaring this function with external scope.
4019 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4021 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4022 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4024 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4026 * editfns.c (Fformat): Correctly handle text properties on "%%".
4028 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4030 * xterm.c (x_draw_composite_glyph_string_foreground):
4031 * w32term.c (x_draw_composite_glyph_string_foreground):
4032 * term.c (encode_terminal_code):
4033 * composite.c (composition_update_it, get_composition_id):
4034 * xdisp.c (get_next_display_element)
4035 (fill_composite_glyph_string): Add comments about special meaning
4036 of TAB characters in a composition.
4038 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4040 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4041 This occurs when processing a multibyte format.
4042 Problem reported by Wolfgang Jenker.
4044 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4046 * xdisp.c (try_cursor_movement): Only check for exact match if
4047 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4049 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4051 Remove unused external symbols.
4052 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4053 * xdisp.c (calc_pixel_width_or_height): Now static.
4054 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4055 * indent.c (check_display_width):
4056 * w32term.c: Fix comment to match code.
4057 * xterm.c, xterm.h (x_catching_errors): Remove.
4059 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4061 * xselect.c: Use signed conversions more consistently (Bug#9498).
4062 (selection_data_to_lisp_data): Assume incoming selection data are
4063 signed integers, not unsigned. This is to be consistent with
4064 outgoing selection data, which was modified to use signed integers
4065 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4066 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4067 expects long, not unsigned long.
4069 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4071 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4072 computation of loop end. Reported by Johan Bockgård
4075 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4077 * frame.c (Fother_visible_frames_p): Function deleted.
4079 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4081 * indent.c (compute_motion): Process display vector front to back
4082 rather than the other way around. (Bug#2496)
4084 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4086 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4088 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4090 * minibuf.c (Fread_from_minibuffer): Doc fix.
4092 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4094 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4095 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4097 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4099 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4100 value for non-existent files.
4102 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4104 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4105 set its "size" to -1. This will set the modtime_size field of
4106 the corresponding buffer to -1, which is what
4107 verify-visited-file-modtime expects for files that do not exist.
4110 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4112 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4114 * lisp.h: ... from here. push_key_description is no longer
4115 defined in keyboard.c, so its declaration should not be in
4116 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4117 logically belongs with push_key_description.
4119 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4121 * buffer.h: Include <sys/types.h> instead of <time.h>.
4122 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4123 Problem reported by Herbert J. Skuhra.
4125 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4127 * xml.c (parse_region): Make the parsing work for
4128 non-comment-starting XML files again (bug#9144).
4130 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4132 * image.c (gif_load): Fix calculation of bottom and right corner.
4135 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4137 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4138 redisplay in small windows.
4140 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4142 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4144 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4146 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4147 Operate on live windows only.
4149 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4151 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4153 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4155 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4156 only under bidi iteration.
4158 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4160 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4162 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4164 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4165 Without this fix, the command to link temacs failed due to an
4166 undefined symbol __builtin_isnan. This is because
4167 /usr/include/iso/math_c99.h #defines isnan(x) to
4168 __builtin_isnan(x), but the bundled gcc, which identifies itself
4169 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4171 * floatfns.c (isnan): #undef, and then #define to a clone of
4173 (Fisnan): Always define, since it's always available now.
4174 (syms_of_floatfns): Always define isnan at the Lisp level.
4176 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4178 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4180 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4182 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4183 The previous code assumed that file offsets (off_t values) fit in
4184 EMACS_INT variables, which is not true on typical 32-bit hosts.
4185 The code messed up by falsely reporting buffer overflow in cases
4186 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4187 when "big" contains more than 2**29 bytes, even though this
4188 inserts just one byte and does not overflow the buffer.
4189 (Finsert_file_contents): Store file offsets as off_t
4190 values, not as EMACS_INT values. Check for overflow when
4191 converting between EMACS_INT and off_t. When checking for
4192 buffer overflow or for overlap, take the offsets into account.
4193 Don't use EMACS_INT for small values where int suffices.
4194 When checking for overlap, fix a typo: ZV was used where
4195 ZV_BYTE was intended.
4196 (Fwrite_region): Don't assume off_t fits into 'long'.
4197 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4199 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4201 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4203 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4205 sprintf-related integer and memory overflow issues (Bug#9412).
4207 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4208 (esprintf, exprintf, evxprintf): New functions.
4209 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4210 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4211 (modify_event_symbol): Do not assume that the length of
4212 name_alist_or_stem is safe to alloca and fits in int.
4213 (Fexecute_extended_command): Likewise for function name and binding.
4214 (Frecursion_depth): Wrap around reliably on integer overflow.
4215 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4216 since some callers pass EMACS_INT values.
4217 (Fsingle_key_description): Don't crash if symbol name contains more
4218 than MAX_ALLOCA bytes.
4219 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4220 (get_minibuffer): Arg is now EMACS_INT, not int.
4221 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4222 (esprintf, exprintf, evxprintf): New decls.
4223 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4225 * dbusbind.c (signature_cat): New function.
4226 (xd_signature, Fdbus_register_signal):
4227 Do not overrun buffer; instead, report string overflow.
4229 * dispnew.c (add_window_display_history): Don't overrun buffer.
4230 Truncate instead; this is OK since it's just a log.
4232 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4233 even if the time zone offset is outlandishly large.
4234 Don't mishandle offset == INT_MIN.
4236 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4237 when creating daemon; the previous buffer-overflow check was incorrect.
4239 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4240 which has the guts of the old verror function.
4242 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4243 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4245 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4246 (font_unparse_xlfd): Don't blindly alloca long strings.
4247 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4248 fits in int, when using sprintf. Use single snprintf to count
4249 length of string rather than counting it via multiple sprintfs;
4250 that's simpler and more reliable.
4251 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4252 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4253 sprintf, in case result does not fit in int.
4255 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4256 (fontset_from_font): Print it.
4258 * frame.c (tty_frame_count): Now printmax_t, not int.
4259 (make_terminal_frame, set_term_frame_name): Print it.
4260 (x_report_frame_params): In X, window IDs are unsigned long,
4261 not signed long, so print them as unsigned.
4262 (validate_x_resource_name): Check for implausibly long names,
4263 and don't assume name length fits in 'int'.
4264 (x_get_resource_string): Don't blindly alloca invocation name;
4265 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4268 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4269 (xg_check_special_colors, xg_set_geometry):
4270 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4272 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4273 Use esprintf, not sprintf, in case result does not fit in int.
4275 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4276 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4277 it as a large positive number.
4278 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4279 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4281 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4282 in case result does not fit in int.
4284 * print.c (float_to_string): Detect width overflow more reliably.
4285 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4286 buffer overrun. Don't assume list length fits in 'int'. Treat
4287 print length of 0 as 0, not as infinity; to be consistent with other
4288 uses of print length in this function. Don't overflow print length
4289 index. Don't assume hash table size fits in 'long', or that
4290 vectorlike size fits in 'unsigned long'.
4292 * process.c (make_process): Use printmax_t, not int, to format
4293 process-name gensyms.
4295 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4297 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4298 to avoid potential buffer overrun.
4300 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4301 if X resource line is longer than 512 bytes.
4303 * xfns.c (x_window): Make sprintf buffer a bit bigger
4304 to avoid potential buffer overrun.
4306 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4308 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4310 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4312 Integer overflow fixes for scrolling, etc.
4313 Without these, Emacs silently mishandles large integers sometimes.
4314 For example, "C-u 4294967297 M-x recenter" was treated as if
4315 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4317 * xdisp.c (try_window_id): Check Emacs fixnum range before
4318 converting to 'int'.
4320 * window.c (window_scroll_line_based, Frecenter):
4321 Check that an Emacs fixnum is in range before assigning it to 'int'.
4322 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4323 values converted from Emacs fixnums.
4324 (Frecenter): Don't wrap around a line count if it is out of 'int'
4325 range; instead, treat it as an extreme value.
4326 (Fset_window_configuration, compare_window_configurations):
4327 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4329 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4330 that can exceed INT_MAX. Check that EMACS_INT value is in range
4331 before assigning it to the (possibly-narrower) index.
4332 (match_limit): Don't assume that a fixnum can fit in 'int'.
4334 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4337 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4338 (Fvertical_motion): Don't wrap around LINES values that don't fit
4339 in 'int'. Instead, treat them as extreme values. This is good
4340 enough for windows, which can't have more than INT_MAX lines anyway.
4342 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4344 * Require libxml/parser.h to avoid compilation warning.
4346 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4348 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4349 since this reportedly can destroy thread storage.
4351 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4353 * syntax.c (find_defun_start): Update all cache variables if
4354 exiting early (Bug#9401).
4356 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4358 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4360 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4361 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4362 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4364 * term.c (tty_append_glyph): New function.
4365 (produce_stretch_glyph): Static function and its prototype deleted.
4367 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4370 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4372 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4373 when checking :margin (Bug#9390).
4374 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4375 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4376 so that the name doesn't mislead. All uses changed.
4378 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4380 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4383 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4385 * xdisp.c (move_it_to): Don't bail out early when reaching
4386 position beyond to_charpos, if we are scanning backwards.
4387 (move_it_vertically_backward): When DY == 0, make sure we get to
4388 the first character in the line after the newline.
4390 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4392 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4393 (ccl_driver): Do not generate an out-of-range pointer.
4394 (Fccl_execute_on_string): Remove unnecessary check for
4395 integer overflow, noted by Stefan Monnier in
4396 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4397 Remove a FIXME that didn't need fixing.
4398 Simplify the newly-introduced buffer reallocation code.
4400 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4402 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4404 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4406 Integer and memory overflow issues (Bug#9196).
4408 * doc.c (get_doc_string): Rework so that
4409 get_doc_string_buffer_size is the actual buffer size, rather than
4410 being 1 less than the actual buffer size; this makes xpalloc more
4413 * image.c (x_allocate_bitmap_record, cache_image):
4414 * xselect.c (Fx_register_dnd_atom):
4415 Simplify previous changes by using xpalloc.
4417 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4418 since either will do and ptrdiff_t is convenient with xpalloc.
4420 * charset.c (charset_table_size)
4421 (struct charset_sort_data.priority): Now ptrdiff_t.
4422 (charset_compare): Don't overflow if priorities differ greatly.
4423 (Fsort_charsets): Don't assume list length fits in int.
4424 Check for size-calculation overflow when allocating sort data.
4425 (syms_of_charset): Allocate an initial charset table that is
4426 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4428 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4430 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4431 The actual value is always <= INT_MAX, and leaving it unsigned made
4432 overflow checking harder.
4434 * dispextern.h (struct glyph_matrix.rows_allocated)
4435 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4436 with xpalloc. The values are still always <= INT_MAX.
4438 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4440 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4441 (SAFE_NALLOCA): New macro.
4443 * region-cache.c (struct boundary.pos, find_cache_boundary)
4444 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4445 (set_cache_region, invalidate_region_cache)
4446 (revalidate_region_cache, know_region_cache, region_cache_forward)
4447 (region_cache_backward, pp_cache):
4448 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4449 so that ptrdiff_t * can be passed to xpalloc.
4450 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4451 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4452 (pp_cache): Don't assume cache_len fits in int.
4453 * region-cache.h: Adjust extern decls to match.
4455 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4456 EMACS_INT, since either will do, for xpalloc.
4458 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4459 (xnmalloc, xnrealloc, xpalloc): New functions.
4461 * bidi.c (bidi_shelve_header_size): New constant.
4462 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4463 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4465 * bidi.c (bidi_cache_shrink):
4466 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4468 Don't update size of array until after memory allocation succeeds,
4469 because xmalloc/xrealloc may not return.
4470 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4471 now that we have proper integer overflow checking.
4472 (record_overlay_string, overlay_strings): Catch overflows when
4473 calculating size of overlay_str_buf.
4475 * callproc.c (Fcall_process): Check for size overflow when
4476 calculating size of args2.
4477 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4478 Normally we prefer signed values, but sticking with ptrdiff_t would
4479 require adding more-complicated checks.
4481 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4482 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4483 Redo buffer-overflow calculations to avoid integer overflow.
4484 Add a FIXME comment where memory seems to be over-allocated.
4486 * character.c (Fstring): Check for size-calculation overflow.
4488 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4489 unnecessary integer overflow. Check for size overflow.
4490 (encode_coding_object): Don't update size until xmalloc succeeds.
4492 * composite.c (get_composition_id): Check for overflow in glyph
4493 length calculations.
4495 Integer and memory overflow fixes for display code.
4496 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4497 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4498 (scrolling_window): Check for overflow in size calculations.
4499 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4500 Don't assume glyph table len fits in int.
4501 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4502 (row_table_size): Now ptrdiff_t, not int.
4503 (scrolling_window): Avoid overflow in size calculations.
4504 Don't update size until allocation succeeds.
4505 * fns.c (concat): Check for overflow in size calculations.
4506 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4507 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4508 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4510 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4511 (get_doc_string): Check for size calculation overflow.
4512 Don't update size until allocation succeeds.
4513 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4514 EMACS_INT, where ptrdiff_t will do.
4515 (Fsubstitute_command_keys): Check for string overflow.
4517 * editfns.c (set_time_zone_rule): Don't assume environment length
4519 (message_length): Now ptrdiff_t, not int.
4520 (Fmessage_box): Don't update size until allocation succeeds.
4521 Don't assume message length fits in int.
4522 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4524 * emacs.c (main): Do not reallocate argv, since there is a null at
4525 the end that can be overwritten, and this way there's no need to
4526 worry about size-calculation overflow.
4527 (sort_args): Check for size-calculation overflow.
4529 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4531 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4533 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4534 (x_set_scroll_bar_width, x_figure_window_size):
4535 Check for integer overflow.
4536 (x_set_alpha): Do not assume XINT fits in int.
4538 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4539 This is for the members text_lines, text_cols, total_lines, total_cols,
4540 where the system imposes an 'int' limit.
4542 * fringe.c (Fdefine_fringe_bitmap):
4543 Don't update size until alloc works.
4545 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4546 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4548 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4549 Check for size-calculation overflow.
4550 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4551 do, as we prefer signed integers.
4552 (id_to_widget.max_size, id_to_widget.used)
4553 (xg_store_widget_in_map, xg_remove_widget_from_map)
4554 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4555 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4556 Use and return ptrdiff_t, not int.
4557 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4558 * gtkutil.h: Change prototypes to match the above.
4560 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4561 are duplicate now that they've been promoted to lisp.h.
4562 (x_allocate_bitmap_record, x_alloc_image_color)
4563 (make_image_cache, cache_image, xpm_load):
4564 Don't update size until alloc is done.
4565 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4567 Check for size calculation overflow.
4568 (ct_colors_allocated_max): New constant.
4569 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4572 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4573 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4574 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4575 Use ptrdiff_t, not int, to count maps.
4576 (read_char_minibuf_menu_prompt): Check for overflow in size
4577 calculations. Don't update size until allocation succeeds.
4578 Redo calculations to avoid overflow.
4579 * keyboard.h: Change prototypes to match the above.
4581 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4583 (current_minor_maps): Check for size calculation overflow.
4584 * keymap.h: Change prototypes to match the above.
4586 * lread.c (read1, init_obarray): Don't update size until alloc done.
4588 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4589 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4591 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4592 Now ptrdiff_t, not int.
4593 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4594 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4596 * process.c (Fnetwork_interface_list): Check for overflow
4597 in size calculation.
4599 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4601 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4602 overflow. Don't bother calling xmalloc when xrealloc will do.
4604 * search.c (Freplace_match): Check for size calculation overflow.
4605 (Fset_match_data): Don't assume list lengths fit in 'int'.
4607 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4608 for command line length. Do not attempt to address one before the
4609 beginning of an array, as that's not portable.
4611 * term.c (max_frame_lines): Remove; unused.
4612 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4614 (encode_terminal_code, calculate_costs): Check for size
4615 calculation overflow.
4616 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4617 table lengths and related sizes. Don't update size until alloc
4618 done. Redo calculations to avoid overflow.
4619 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4621 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4622 subtracting pointers.
4623 (gobble_line): Check for overflow more carefully. Don't update size
4626 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4627 Don't update size until alloc done.
4628 Redo size calculations to avoid overflow.
4629 Check for size calculation overflow.
4630 (main) [DEBUG]: Fix typo in invoking tparam1.
4632 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4633 Use ptrdiff_t, not int, for sizes.
4634 (store_mode_line_noprop_char): Don't update size until alloc done.
4636 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4637 Use ptrdiff_t, not int, for sizes.
4638 (Finternal_make_lisp_face, cache_face):
4639 Check for size calculation overflow.
4640 (cache_face): Treat size calculation overflows as if they were
4641 memory exhaustion (the usual treatment), rather than aborting.
4643 * xfns.c (x_encode_text, x_set_name_internal)
4644 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4645 sizes, since they can exceed INT_MAX in size. Check for size
4646 calculation overflow.
4648 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4649 (xg_select): Check for size calculation overflow.
4650 Don't update size until alloc done.
4652 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4653 as sprintf is limited to int lengths.
4655 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4656 (X_LONG_MIN): New macros.
4657 Use them to make the following changes clearer.
4658 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4659 This change doesn't affect the value now, but it may help remind
4660 future maintainers not to raise the value too much later.
4661 (SELECTION_QUANTUM): Remove, replacing with ...
4662 (selection_quantum): ... new function, which avoids overflow.
4664 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4665 assumption that selection length fits in 'int'.
4666 (x_reply_selection_request, x_handle_selection_request)
4667 (x_get_window_property, receive_incremental_selection)
4668 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4669 (lisp_data_to_selection_data, clean_local_selection_data):
4670 Use ptrdiff_t, not int, to record length of selection.
4671 (x_reply_selection_request, x_get_window_property)
4672 (receive_incremental_selection, x_property_data_to_lisp):
4673 Redo calculations to avoid overflow.
4674 (x_reply_selection_request): When sending hint, ceiling it at
4675 X_LONG_MAX rather than relying on wraparound overflow to send
4677 (x_get_window_property, receive_incremental_selection)
4678 (lisp_data_to_selection_data, x_property_data_to_lisp):
4679 Check for size-calculation overflow.
4680 (x_get_window_property, receive_incremental_selection)
4681 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4682 Don't store size until memory allocation succeeds.
4683 (x_get_window_property): Plug memory leak on memory exhaustion.
4684 Don't double-block input; malloc is safe here. Don't assume 2**34
4685 - 4 fits in unsigned long. Add an xassert to check
4686 XGetWindowProperty overflow. Be more careful about overflow
4687 calculations, and distinguish size from memory overflow better.
4688 (receive_incremental_selection): When tracing, don't assume
4689 unsigned int is less than INT_MAX.
4690 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4691 harmful) conversions of unsigned short to int.
4692 (lisp_data_to_selection_data): Don't assume that integers
4693 in the range -65535 through -1 fit in an X unsigned short.
4694 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4695 result parameters unless successful. Rely on cons_to_unsigned
4696 to report problems with elements; the old code wasn't right anyway.
4697 (x_check_property_data): Check for int overflow; we cannot use
4698 a wider type due to X limits.
4699 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4701 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4703 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4704 (x_term_init): Check for size calculation overflow.
4705 (x_color_cells): Don't store size until memory allocation succeeds.
4706 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4707 Don't assume alloca size is less than MAX_ALLOCA.
4708 (x_term_init): Don't assume length fits in int (sprintf is limited
4711 Use ptrdiff_t for composition IDs.
4712 * character.c (lisp_string_width):
4713 * composite.c (composition_table_size, n_compositions)
4714 (get_composition_id, composition_gstring_from_id):
4715 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4716 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4717 * window.c (Frecenter):
4718 Use ptrdiff_t, not int, for composition IDs.
4719 * composite.c (get_composition_id): Check for integer overflow.
4720 * composite.h: Adjust prototypes to match the above changes.
4722 Use ptrdiff_t for hash table indexes.
4723 * category.c (hash_get_category_set):
4724 * ccl.c (ccl_driver):
4725 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4726 * coding.c (coding_system_charset_list, detect_coding_system):
4727 * coding.h (struct coding_system.id):
4728 * composite.c (get_composition_id, gstring_lookup_cache):
4729 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4730 * image.c (xpm_get_color_table_h):
4731 * lisp.h (hash_lookup, hash_put):
4732 * minibuf.c (Ftest_completion):
4733 Use ptrdiff_t for hash table indexes, not int (which is too
4734 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4735 32-bit --with-wide-int hosts).
4737 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4738 Add a FIXME comment about memory leaks.
4739 (syms_of_charset): Don't assume xmalloc returns.
4741 Don't assume that stated character widths fit in int.
4742 * character.c (Fchar_width, c_string_width, lisp_string_width):
4743 * character.h (CHAR_WIDTH):
4744 * indent.c (MULTIBYTE_BYTES_WIDTH):
4745 Use sanitize_char_width to avoid undefined and/or bad behavior
4746 with outlandish widths.
4747 * character.h (sanitize_tab_width): Rename from sanitize_width,
4748 now that we have two such functions. All uses changed.
4749 (sanitize_char_width): New inline function.
4751 Don't assume that tab-width fits in int.
4752 * character.h (sanitize_width): New inline function.
4753 (SANE_TAB_WIDTH): New macro.
4754 (ASCII_CHAR_WIDTH): Use it.
4755 * indent.c (sane_tab_width): Remove. All uses replaced by
4756 SANE_TAB_WIDTH (current_buffer).
4757 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4759 * fileio.c: Integer overflow issues with file modes.
4760 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4762 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4763 Remove unreachable code.
4764 (read_hex, load_charset_map_from_file): Check for integer overflow.
4766 * xterm.c: Don't go over XClientMessageEvent limit.
4767 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4768 (x_send_scroll_bar_event): Likewise. Check that the size does not
4769 exceed limits imposed by XClientMessageEvent, as well as the usual
4770 ptrdiff_t and size_t limits.
4772 * keyboard.c: Overflow, signedness and related fixes.
4773 (make_lispy_movement): Use same integer type in forward decl
4774 that is used in the definition.
4775 (read_key_sequence, keyremap_step):
4776 Change bufsize argument back to int, undoing my 2011-03-30 change.
4777 We prefer signed types, and int is wide enough here.
4778 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4779 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4780 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4781 length, not size_t. Use ptrdiff_t for index, not int.
4782 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4783 possibility of integer overflow.
4785 Overflow, signedness and related fixes for images.
4787 * dispextern.h (struct it.stack[0].u.image.image_id)
4788 (struct_it.image_id, struct image.id, struct image_cache.size)
4789 (struct image_cache.used, struct image_cache.ref_count):
4790 * gtkutil.c (update_frame_tool_bar):
4791 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4792 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4793 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4794 * nsmenu.m (update_frame_tool_bar):
4795 * xdisp.c (calc_pixel_width_or_height):
4796 * xfns.c (image_cache_refcount):
4797 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4798 on typical 64-bit hosts.
4800 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4801 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4802 Omit unnecessary casts to int.
4803 (parse_image_spec): Check that integers fall into 'int' range
4804 when the callers expect that.
4805 (image_ascent): Redo ascent calculation to avoid int overflow.
4806 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4807 (lookup_image): Remove unnecessary tests.
4808 (xbm_image_p): Locals are now of int, not EMACS_INT,
4809 since parse_image_check makes sure they fit into int.
4810 (png_load, gif_load, svg_load_image):
4811 Prefer int to unsigned where either will do.
4812 (tiff_handler): New function, combining the cores of the
4813 old tiff_error_handler and tiff_warning_handler.
4814 This function is rewritten to use vsnprintf and thereby avoid
4815 stack buffer overflows. It uses only the features of vsnprintf
4816 that are common to both POSIX and native Microsoft.
4817 (tiff_error_handler, tiff_warning_handler): Use it.
4818 (tiff_load, gif_load, imagemagick_load_image):
4819 Don't assume :index value fits in 'int'.
4820 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4821 (imagemagick_load_image): Check that crop parameters fit into
4822 the integer types that MagickCropImage accepts. Don't assume
4823 Vimagemagick_render_type has a nonnegative value. Don't assume
4824 size_t fits in 'long'.
4825 (gs_load): Use printmax_t to print the widest integers possible.
4826 Check for integer overflow when computing image height and width.
4828 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4830 * xdisp.c (redisplay_window): Don't force window start if point
4831 will be invisible in the resulting window. (Bug#9324)
4833 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4835 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4836 the display spec is of the form `(space ...)'.
4837 (handle_display_spec): Return the value returned by
4838 handle_single_display_spec, not just 1 or zero.
4839 (handle_single_display_spec): If the display spec is of the form
4840 `(space ...)', and specifies display in the text area, return 2
4842 (try_cursor_movement): Check for the need to scroll more
4843 accurately, and prefer exact match for point under bidi.
4844 Don't advance `row' beyond the last row of the window.
4846 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4847 into disp_prop; all users changed.
4849 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4850 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4851 for the text covered by the display property.
4853 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4855 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4856 Change return value to nil.
4857 (Frecord_buffer): Delete unused function.
4859 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4861 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4862 buffers, return left-to-right.
4863 (set_cursor_from_row): Consider candidate row a win if its glyph
4864 represents a newline and point is on that newline. Fixes cursor
4865 positioning on the newline at EOL of R2L text within L2R
4866 paragraph, and vice versa.
4867 (try_cursor_movement): Check continued rows, in addition to
4868 continuation rows. Fixes unwarranted scroll when point enters a
4869 continued line of R2L text within an L2R paragraph, or vice versa.
4870 (cursor_row_p): Consider the case of point being equal to
4871 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4872 from the end of a short line to the beginning of a continued line
4873 of R2L text within L2R paragraph.
4874 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4875 composed characters.
4877 * bidi.c (bidi_check_type): Use xassert.
4878 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4881 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4883 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4886 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4888 * nsfont.m (ns_otf_to_script): Fix typo.
4890 2011-08-22 Kenichi Handa <handa@m17n.org>
4892 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4893 extra slot even if the purpose is char-code-property-table.
4895 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4897 * xdisp.c (redisplay_window): When computing centering_position,
4898 account for the height of the header line. (Bug#8874)
4900 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4901 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4902 candidate is selected by the mouse, and that candidate has a
4903 composed character under the mouse.
4905 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4906 coordinates reported by pos-visible-in-window-p for a composed
4907 character in column zero.
4909 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4911 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4913 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4915 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4916 consider it a hit if to_charpos is anywhere in the range of the
4917 composed buffer positions.
4919 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4921 * image.c (gif_load): Don't assume that each subimage has the same
4922 dimensions as the base image. Handle disposal method that is
4923 "undefined" by the gif spec (Bug#9335).
4925 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4927 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4928 (Fcondition_case): Document `debug' symbol in error handler.
4930 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4932 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4933 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4934 from an Org mode buffer to a Speedbar frame.
4936 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4937 a composition, take its buffer position from IT->cmp_it.charpos.
4938 Fixes cursor positioning at the beginning of a line that begins
4939 with a composed character.
4941 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4943 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4944 character bidirectional type, use STRONG_L instead. Fixes crashes
4945 in a buffer produced by `describe-categories'.
4947 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4948 members before the level stack, so they would be saved and
4949 restored when copying iterator state. Fixes incorrect reordering
4950 around TABs covered by display properties.
4952 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4954 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4956 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4958 * eval.c (internal_condition_case, internal_condition_case_1)
4959 (internal_condition_case_2, internal_condition_case_n):
4960 Remove unnecessary aborts (Bug#9081).
4962 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4964 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4965 has no `load' handler, try opening the file locally. (Bug#9311)
4967 2011-08-16 Ken Brown <kbrown@cornell.edu>
4969 * gmalloc.c: Expand comment.
4971 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4973 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4974 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4976 2011-08-16 Ken Brown <kbrown@cornell.edu>
4978 Fix memory allocation problems in Cygwin build (Bug#9273).
4980 * unexcw.c ( __malloc_initialized): Declare external variable.
4981 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4983 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4985 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4987 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4989 [CYGWIN] (special_realloc): New function.
4990 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4991 requests to realloc storage in the static heap.
4993 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4995 * bidi.c (bidi_initialize): Remove unused local.
4997 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5000 * biditype.h: Remove file.
5001 * makefile.w32-in ($(BLD)/bidi.$(O)):
5002 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5004 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5006 * chartab.c: Improve commentary for the uniprop_table API.
5008 * bidi.c (bidi_paragraph_init): Support zero value of
5009 bidi_ignore_explicit_marks_for_paragraph_level.
5010 (bidi_initialize): Use uniprop_table instead of including
5011 biditype.h and bidimirror.h.
5013 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5014 coordinates of the iterator when restoring from ppos_it.
5017 2011-08-14 Kenichi Handa <handa@m17n.org>
5019 * process.c (create_process): Call setup_process_coding_systems
5020 after the pid of the process is set to -1 (Bug#8162).
5022 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5024 * xdisp.c (move_it_in_display_line_to): Don't invoke
5025 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5026 ppos_it. Fixes vertical cursor motion when line beginning is
5027 covered by an image. (Bug#9296)
5029 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5031 * nsterm.h (ns_run_ascript): Declare.
5032 (NSAPP_DATA2_RUNASSCRIPT): Define.
5034 * nsfns.m (as_script, as_result, as_status): New static variables.
5035 (ns_run_ascript): New function.
5036 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5037 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5038 the event loop. Get status from as_status (Bug#7276).
5040 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5041 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5042 the event loop (Bug#7276).
5044 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5046 * gnutls.c (QCgnutls_bootprop_priority)
5047 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5048 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5049 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5050 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5051 (QCgnutls_bootprop_verify_hostname_error)
5052 (QCgnutls_bootprop_callbacks_verify): Rename from
5053 Qgnutls_bootprop_..., all uses changed.
5055 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5058 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5060 * xfaces.c (Qframe_set_background_mode): Now static.
5061 * dispextern.h (Qframe_set_background_mode): Remove decl.
5063 * process.c (Fnetwork_interface_info): Declare local only if needed.
5065 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5067 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5068 (Fnetwork_interface_list): Allocate in increments of bytes instead
5069 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5070 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5072 (struct ifflag_def): notrailers is smart on OSX.
5073 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5074 Get hardware address with getifaddrs if available.
5076 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5078 * xdisp.c (iterate_out_of_display_property): xassert that
5079 IT->position is set to within IT->object's boundaries. Break from
5080 the loop as soon as EOB is reached; avoids infloops in redisplay
5081 when IT->position is set up wrongly due to some bug.
5082 Set IT->current to match the bidi iterator unconditionally.
5083 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5084 entry. Force push_it to save on the stack the current
5085 buffer/string position, to be restored by pop_it. Fix flags in
5086 the iterator structure wrt the object coming from a display
5087 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5088 properties. (Bug#9284)
5090 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5092 * fontset.c (fontset_get_font_group): Add proper type checks.
5095 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5097 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5098 and LC_VERSION_MIN_MACOSX.
5099 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5100 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5102 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5104 * xdisp.c (forward_to_next_line_start): Allow to use the
5105 no-display-properties-and-no-overlays under bidi display.
5106 Set disp_pos in the bidi iterator to avoid searches for display
5107 properties and overlays.
5109 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5111 * editfns.c (Fset_time_zone_rule): Document relationship with the
5114 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5115 the font entity extracted from the cache (Bug#8109).
5117 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5119 * composite.c (autocmp_chars): Don't reset point. That is done by
5120 restore_point_unwind (Bug#5984).
5122 2011-08-07 Juri Linkov <juri@jurta.org>
5124 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5125 to show the arg `TIME' instead of `TIMEVAL'.
5127 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5129 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5130 display property strides EOL and includes a newline, as in
5131 longlines-mode. (Bug#9254)
5132 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5133 word-wrap under bidirectional display. (Bug#9224)
5135 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5136 is non-zero, even if the data buffer is NULL. Fixes a crash in
5137 vertical-motion with longlines-mode. (Bug#9254)
5139 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5141 * bidi.c <bidi_cache_total_alloc>: Now static.
5142 (bidi_initialize): Initialize bidi_cache_total_alloc.
5144 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5147 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5148 amount allocated this far in `bidi_cache_total_alloc'.
5149 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5150 non-zero, only free the data buffer without restoring the cache
5151 contents. All callers changed.
5153 * dispextern.h (bidi_unshelve_cache): Update prototype.
5155 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5156 (move_it_in_display_line, move_it_to)
5157 (move_it_vertically_backward, move_it_by_lines): Replace the call
5158 to xfree to an equivalent call to bidi_unshelve_cache.
5159 (move_it_in_display_line_to): Fix logic of returning
5160 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5162 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5164 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5165 came from a string character with a `cursor' property. (Bug#9229)
5167 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5169 * Makefile.in (LIB_PTHREAD): New variable.
5170 (LIBES): Add LIB_PTHREAD (Bug#9216).
5172 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5173 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5175 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5177 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5179 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5181 * xterm.c (x_find_topmost_parent): New function.
5182 (x_set_frame_alpha): Find topmost parent window with
5183 x_find_topmost_parent and set the property there also (bug#9181).
5184 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5186 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5188 * callproc.c (Fcall_process): Avoid vfork clobbering
5189 the local vars buffer, coding_systems, current_dir.
5191 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5193 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5195 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5197 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5198 so that it is not optimized away.
5200 * xdisp.c (compute_display_string_pos): Remove unused local.
5202 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5204 Fix slow cursor motion and scrolling in large buffers with
5205 selective display, like Org Mode buffers. (Bug#9218)
5207 * dispextern.h (struct bidi_it): New member disp_prop_p.
5209 * xdisp.c: Remove one-slot cache of display string positions.
5210 (compute_display_string_pos): Accept an additional argument
5211 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5212 for a display string or property. If found, set DISP_PROP_P
5215 * bidi.c (bidi_fetch_char): Accept an additional argument
5216 DISP_PROP_P, and pass it to compute_display_string_pos.
5217 Only handle text covered by a display string if DISP_PROP_P is returned
5218 non-zero. All callers of bidi_fetch_char changed.
5220 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5222 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5224 2010-12-03 Don March <don@ohspite.net>
5226 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5227 last character M-[char] is translated to ESC [char] (bug#7541).
5229 2011-08-02 Kenichi Handa <handa@m17n.org>
5231 * lisp.h (uniprop_table): Extern it.
5233 * chartab.c (uniprop_table): Make it non-static.
5235 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5237 * xdisp.c (forward_to_next_line_start): Accept additional argument
5238 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5240 (reseat_at_next_visible_line_start): Use the bidi iterator state
5241 returned by forward_to_next_line_start to restore the state of
5242 it->bidi_it after backing up to previous newline. (Bug#9212)
5244 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5246 * regex.c (re_comp): Protoize.
5247 (re_exec): Fix return type.
5248 (regexec): Fix type of `ret'. (Bug#9203)
5250 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5252 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5253 This is needed if max-image-size is a floating-point number.
5255 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5257 * print.c (print_object): Print empty symbol as ##.
5259 * lread.c (read1): Read ## as empty symbol.
5261 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5263 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5264 setting frame foreground color (Bug#9175).
5265 (x_set_background_color): Likewise.
5267 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5268 contents (Bug#9176).
5269 (EmacsTooltip -init): Remove bezels and add shadows to
5272 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5273 or scroll bar (Bug#8470).
5275 * nsfont.m (nsfont_open): Remove assignment to voffset and
5276 unnecessary vars hshink, expand, hd, full_height, min_height.
5277 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5279 * nsterm.h (nsfont_info): Remove voffset field.
5281 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5283 Implement strike-through and overline on NextStep (Bug#8863).
5285 * nsfont.m (nsfont_open): Use underline position provided by font,
5286 instead of hard-coded value of 2.
5287 (nsfont_draw): Call ns_draw_text_decoration instead.
5289 * nsterm.h: Add declaration for ns_draw_text_decoration.
5291 * nsterm.m (ns_draw_text_decoration): New function for drawing
5292 underline, overline, and strike-through.
5293 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5294 ns_draw_text_decoration. Change treatment of cursor drawing to
5295 accommodate underlining, etc.
5297 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5299 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5302 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5304 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5305 Without this fix, if a signal arrives just after memory fills up,
5306 'malloc' might be invoked reentrantly.
5308 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5309 In other words, assume that every image size is allowed, on non-X
5310 hosts. This assumption is probably wrong, but it lets Emacs compile.
5312 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5314 * regex.c (re_iswctype): Convert return values to boolean.
5316 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5318 * xdisp.c (compute_display_string_pos): Don't use cached display
5319 string position if the buffer had its restriction changed.
5322 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5324 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5326 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5328 Integer signedness and overflow and related fixes. (Bug#9079)
5330 * bidi.c: Integer size and overflow fixes.
5331 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5332 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5333 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5334 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5335 (bidi_find_other_level_edge):
5336 Use ptrdiff_t instead of EMACS_INT where either will do.
5337 This works better on 32-bit hosts configured --with-wide-int.
5338 (bidi_cache_ensure_space): Check for size-calculation overflow.
5339 Use % rather than repeated addition, for better worst-case speed.
5340 Don't set bidi_cache_size until after xrealloc returns, because it
5342 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5343 (bidi_cache_ensure_space): Also check that the bidi cache size
5344 does not exceed that of the largest Lisp string or buffer. See Eli
5345 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5347 * alloc.c (__malloc_size_t): Remove.
5348 All uses replaced by size_t. See Andreas Schwab's note
5349 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5351 * image.c: Improve checking for integer overflow.
5352 (check_image_size): Assume that f is nonnull, since
5353 it is always nonnull in practice. This is one less thing to
5354 worry about when checking for integer overflow later.
5355 (x_check_image_size): New function, which checks for integer
5356 overflow issues inside X.
5357 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5358 This removes the need for a memory_full check.
5359 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5360 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5361 (xbm_read_bitmap_data): Change locals back to 'int', since
5362 their values must fit in 'int'.
5363 (xpm_load_image, png_load, tiff_load):
5364 Invoke x_create_x_image_and_pixmap earlier,
5365 to avoid much needless work if the image is too large.
5366 (tiff_load): Treat overly large images as if
5367 x_create_x_image_and_pixmap failed, not as malloc failures.
5368 (gs_load): Use x_check_image_size.
5370 * gtkutil.c: Omit integer casts.
5371 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5372 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5374 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5376 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5377 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5378 would wrongly return t on a 64-bit host.
5380 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5381 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5382 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5383 and therefore cause GCC to emit a bogus diagnostic in some cases.
5385 * image.c: Integer signedness and overflow and related fixes.
5386 This is not an exhaustive set of fixes, but it's time to
5387 record what I've got.
5388 (lookup_pixel_color, check_image_size): Remove redundant decls.
5389 (check_image_size): Don't assume that arbitrary EMACS_INT values
5390 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5391 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5392 (tiff_load, imagemagick_load_image):
5393 Check for overflow in size calculations.
5394 (x_create_x_image_and_pixmap): Remove unnecessary test for
5395 xmalloc returning NULL; that can't happen.
5396 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5397 (xpm_color_bucket): Use better integer hashing function.
5398 (xpm_cache_color): Don't possibly over-allocate memory.
5399 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5400 (gif_memory_source):
5401 Use ptrdiff_t, not int or size_t, to record sizes.
5402 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5403 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5404 either works, as we prefer signed integers.
5405 (tiff_read_from_memory, tiff_write_from_memory):
5406 Return tsize_t, not size_t, since that's what the TIFF API wants.
5407 (tiff_read_from_memory): Don't fail simply because the read would
5408 go past EOF; instead, return a short read.
5409 (tiff_load): Omit no-longer-needed casts.
5410 (Fimagemagick_types): Don't assume size fits into 'int'.
5412 Improve hashing quality when configured --with-wide-int.
5413 * fns.c (hash_string): New function, taken from sxhash_string.
5414 Do not discard information about ASCII character case; this
5415 discarding is no longer needed.
5416 (sxhash-string): Use it. Change sig to match it. Caller changed.
5417 * lisp.h: Declare it.
5418 * lread.c (hash_string): Remove, since we now use fns.c's version.
5419 The fns.c version returns a wider integer if --with-wide-int is
5420 specified, so this should help the quality of the hashing a bit.
5422 * emacs.c: Integer overflow minor fix.
5423 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5424 Define only if GNU_LINUX.
5425 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5427 * dispnew.c: Integer signedness and overflow fixes.
5428 Remove unnecessary forward decls, that were a maintenance hassle.
5429 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5431 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5432 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5433 (prepare_desired_row, line_draw_cost):
5434 Use int, not unsigned, where either works.
5435 (save_current_matrix, restore_current_matrix):
5436 Use ptrdiff_t, not size_t, where either works.
5437 (init_display): Check for overflow more accurately, and without
5438 relying on undefined behavior.
5440 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5441 Remove, replacing with the new symbols in lisp.h. All uses changed.
5442 * fileio.c (make_temp_name):
5443 * filelock.c (lock_file_1, lock_file):
5444 * xdisp.c (message_dolog):
5445 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5446 Use pMd etc. instead.
5447 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5448 replacing the pWIDE etc. symbols removed from editfns.c.
5450 * keyboard.h (num_input_events): Now uintmax_t.
5451 This is (very slightly) less likely to mess up due to wraparound.
5454 * buffer.c: Integer signedness fixes.
5455 (alloc_buffer_text, enlarge_buffer_text):
5456 Use ptrdiff_t rather than size_t when either will do, as we prefer
5459 * alloc.c: Integer signedness and overflow fixes.
5460 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5461 (__malloc_size_t): Default to size_t, not to int.
5462 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5463 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5464 Prefer ptrdiff_t to size_t when either would do, as we prefer
5466 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5467 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5468 Now const. Initialize with values that are in range even if char
5470 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5471 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5472 These functions do the right thing with sizes > 2**32.
5473 (check_depth): Now ptrdiff_t, not int.
5474 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5475 Adjust to new way of storing sizes. Check for size overflow bugs
5477 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5478 slightly wrong anyway, as it missed one instance of
5479 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5480 (refill_memory_reserve): Omit needless cast to size_t.
5481 (mark_object_loop_halt): Mark as externally visible.
5483 * xselect.c: Integer signedness and overflow fixes.
5484 (Fx_register_dnd_atom, x_handle_dnd_message):
5485 Use ptrdiff_t, not size_t, since we prefer signed.
5486 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5487 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5488 x_dnd_atoms_size and x_dnd_atoms_length.
5490 * doprnt.c: Prefer signed to unsigned when either works.
5492 * doprnt.c (doprnt):
5494 * xdisp.c (vmessage):
5495 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5496 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5497 prefer signed arithmetic to avoid comparison confusion.
5498 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5499 but is a bit tricky.
5501 Assume freestanding C89 headers, string.h, stdlib.h.
5502 * data.c, doprnt.c, floatfns.c, print.c:
5503 Include float.h unconditionally.
5504 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5505 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5506 * regex.c: Likewise for stddef.h, string.h.
5507 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5508 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5509 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5510 (STDC_HEADERS): Remove obsolete defines.
5511 * sysdep.c: Include limits.h unconditionally.
5513 Assume support for memcmp, memcpy, memmove, memset.
5514 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5515 * regex.c (memcmp, memcpy):
5516 Remove; we assume C89 now.
5518 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5519 (__malloc_safe_bcopy): Remove; no longer needed.
5521 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5522 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5523 well either way, and we prefer signed to unsigned.
5525 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5527 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5528 closes the connection while we're reading (bug#9182).
5530 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5532 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5533 are specified (Bug#9168).
5535 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5537 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5538 Found by GCC static checking and --with-wide-int on a 32-bit host.
5540 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5542 * xdisp.c (compute_display_string_pos): Fix logic of caching
5543 previous display string position. Initialize cached_prev_pos to
5544 -1. Fixes slow-down at the beginning of a buffer.
5546 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5548 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5549 for attrs[LFACE_FONTSET_INDEX].
5551 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5553 * xml.c (parse_region): Remove unused local
5554 that was recently introduced.
5556 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5558 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5559 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5561 * xdisp.c (move_it_in_display_line_to): Record the best matching
5562 position for TO_CHARPOS while scanning the line, and restore it on
5563 exit if none of the characters scanned was an exact match.
5564 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5565 when exact match is impossible due to invisible text, and the
5566 lines are truncated.
5568 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5570 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5573 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5575 Fix a significant slow-down of cursor motion with C-n, C-p,
5576 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5577 auto-repeat under bidi redisplay in fontified buffers.
5578 * xdisp.c (compute_stop_pos_backwards): New function.
5579 (next_element_from_buffer): Call compute_stop_pos_backwards to
5580 find a suitable prev_stop when we find ourselves before
5582 (reseat): Don't look for prev_stop, as that could mean a very long
5584 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5585 <cached_disp_overlay_modiff>: Cache for last found display string
5587 (compute_display_string_pos): Return the cached position if asked
5588 about the same buffer in the same area of character positions, and
5589 the buffer wasn't changed since the time the display string
5590 position was cached.
5592 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5594 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5595 is an integer, which is important for empty lines. (Bug#9149)
5597 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5599 * frame.c (Fmodify_frame_parameters): In tty case, update the
5600 default face if necessary (Bug#4238).
5602 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5604 * editfns.c (Fstring_to_char): No need to explain what a character
5605 is in the docstring (Bug#6576).
5607 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5609 * xml.c (parse_region): Make sure we always return a tree.
5611 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5613 * xml.c (parse_region): If a document contains only comments,
5616 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5618 * xml.c (make_dom): Return comments, too.
5620 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5623 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5624 and the surrounding thread.
5625 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5626 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5627 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5629 * s/openbsd.h (BROKEN_SIGIO): Define.
5630 * unexelf.c (unexec) [__OpenBSD__]:
5631 Don't update the .mdebug section of the Alpha COFF symbol table.
5633 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5635 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5638 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5640 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5641 This fixes some race conditions on the permissions of any newly
5644 * alloc.c (valid_pointer_p): Use pipe, not open.
5645 This fixes some permissions issues when debugging.
5647 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5648 If fchown fails to set both uid and gid, try to set just gid,
5649 as that is sometimes allowed. Adjust the file's mode to eliminate
5650 setuid or setgid bits that are inappropriate if fchown fails.
5652 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5654 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5655 to compare Lisp_Objects.
5656 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5657 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5658 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5660 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5662 * lread.c (read_integer): Unread even EOF character.
5663 (read1): Likewise. Properly record start position of symbol.
5665 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5666 symbol character follows.
5668 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5670 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5671 This works around a problem with the previous change to Fcopy_file.
5672 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5673 and without this change, GCC might complain about discarding
5674 fchown's return value.
5676 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5678 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5680 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5682 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5684 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5686 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5687 it's used from the C level.
5689 * process.c: Use the same condition for POLL_FOR_INPUT in both
5690 keyboard.c and process.c (bug#1858).
5692 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5694 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5695 (Fgnutls_boot): Use it.
5697 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5699 * doc.c (Fsubstitute_command_keys): Revert last change.
5701 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5703 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5704 quotes the next character, and doesn't affect other longer
5705 sequences (bug#8935).
5707 * lread.c (syms_of_lread): Clarify that is isn't only
5708 `eval-buffer' and `eval-defun' that's affected by
5709 `lexical-binding' (bug#8460).
5711 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5713 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5714 bidi redisplay when a line includes both an image and is truncated.
5716 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5718 Fix minor problems found by static checking.
5719 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5720 (elsz): Now a signed constant, not a size_t var. We prefer signed
5721 types to unsigned, to avoid integer comparison confusion. Without
5722 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5723 "cannot optimize loop, the loop counter may overflow", a symptom
5725 * indent.c (Fvertical_motion): Mark locals as initialized.
5726 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5728 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5730 * search.c (Fre_search_backward): Mention `case-fold-search' in
5731 all the re_search_* functions (bug#8138).
5733 * keyboard.c (Fopen_dribble_file): Document when the file is
5736 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5738 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5741 Support bidi reordering of display and overlay strings.
5742 * xdisp.c (compute_display_string_pos)
5743 (compute_display_string_end): Accept additional argument STRING.
5744 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5745 (reseat_to_string): Initialize bidi_it->string.s and
5746 bidi_it->string.schars.
5747 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5748 NULL (avoids a crash in bidi_paragraph_init).
5749 Initialize itb.string.lstring.
5750 (init_iterator): Call bidi_init_it only of a valid
5751 buffer position was specified. Initialize paragraph_embedding to
5753 (reseat_to_string): Initialize the bidi iterator.
5754 (display_string): If we need to ignore text properties of
5755 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5756 original value of -1 will not work with bidi.)
5757 (compute_display_string_pos): First arg is now struct
5758 `text_pos *'; all callers changed. Support display properties on
5760 (compute_display_string_end): Support display properties on Lisp
5762 (init_iterator, reseat_1, reseat_to_string): Initialize the
5763 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5764 when iterating on a string not from display properties).
5765 (compute_display_string_pos, compute_display_string_end):
5766 Fix calculation of the object to scan. Fixes an error when using
5768 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5769 base_level_stop; instead, set base_level_stop to BEGV.
5770 Fixes crashes in vertical-motion.
5771 (next_element_from_buffer): Improve commentary for when
5772 the iterator is before prev_stop.
5773 (init_iterator): Initialize bidi_p from the default value of
5774 bidi-display-reordering, not from buffer-local value. Use the
5775 buffer-local value only if initializing for buffer iteration.
5776 (handle_invisible_prop): Support invisible properties on strings
5777 that are being bidi-reordered.
5778 (set_iterator_to_next): Support bidi reordering of C strings and
5780 (next_element_from_string): Support bidi reordering of Lisp
5782 (handle_stop_backwards): Support Lisp strings as well.
5783 (display_string): Support display of R2L glyph rows.
5784 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5785 (init_iterator): Don't initialize it->bidi_p for strings
5787 (reseat_to_string): Initialize it->bidi_p for strings here.
5788 (next_element_from_string, next_element_from_c_string)
5789 (next_element_from_buffer): Add xassert's for correspondence
5790 between IT's object being iterated and it->bidi_it.string
5792 (face_before_or_after_it_pos): Support bidi iteration.
5793 (next_element_from_c_string): Handle the case of the first string
5794 character that is not the first one in the visual order.
5795 (get_visually_first_element): New function, refactored from common
5796 parts of next_element_from_buffer, next_element_from_string, and
5797 next_element_from_c_string.
5798 (tool_bar_lines_needed, redisplay_tool_bar)
5799 (display_menu_bar): Force left-to-right direction. Add a FIXME
5800 comment for making that be controlled by a user option.
5801 (push_it, pop_it): Save and restore the state of the
5802 bidi iterator. Save and restore the bidi_p flag.
5803 (pop_it): Iterate out of display property for string iteration as
5805 (iterate_out_of_display_property): Support iteration over strings.
5806 (handle_single_display_spec): Set up it->bidi_it for iteration
5807 over a display string, and call bidi_init_it.
5808 (handle_single_display_spec, next_overlay_string)
5809 (get_overlay_strings_1, push_display_prop): Set up the bidi
5810 iterator for displaying display or overlay strings.
5811 (forward_to_next_line_start): Don't use the shortcut if
5813 (back_to_previous_visible_line_start): If handle_display_prop
5814 pushed the iterator stack, restore the internal state of the bidi
5815 iterator by calling bidi_pop_it same number of times.
5816 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5817 and we are bidi-iterating, don't decrement the iterator position;
5818 instead, set the first_elt flag in the bidi iterator, to produce
5820 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5821 (push_display_prop): xassert that we are iterating a buffer.
5822 (push_it, pop_it): Save and restore paragraph_embedding member.
5823 (handle_single_display_spec, next_overlay_string)
5824 (get_overlay_strings_1, reseat_1, reseat_to_string)
5825 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5826 correctly. Don't assume unibyte strings are not bidi-reordered.
5827 (compute_display_string_pos)
5828 (compute_display_string_end): Fix handling the case of C string.
5829 (push_it, pop_it): Save and restore from_disp_prop_p.
5830 (handle_single_display_spec, push_display_prop): Set the
5831 from_disp_prop_p flag.
5832 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5833 (pop_it): Call iterate_out_of_display_property only if we are
5834 popping after iteration over a string that came from a display
5835 property. Fix a typo in popping stretch info. Add an assertion
5836 for verifying that the iterator position is in sync with the bidi
5838 (handle_single_display_spec, get_overlay_strings_1)
5839 (push_display_prop): Fix initialization of paragraph direction for
5840 string when that of the parent object is not yet determined.
5841 (reseat_1): Call bidi_init_it to resync the bidi
5842 iterator with IT's position. (Bug#7616)
5843 (find_row_edges): If ROW->start.pos gives position
5844 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5845 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5846 Reset the from_disp_prop_p flag.
5847 (SAVE_IT, RESTORE_IT): New macros.
5848 (pos_visible_p, face_before_or_after_it_pos)
5849 (back_to_previous_visible_line_start)
5850 (move_it_in_display_line_to, move_it_in_display_line)
5851 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5852 (try_scrolling, redisplay_window, display_line): Use them when
5853 saving a temporary copy of the iterator and restoring it back.
5854 (back_to_previous_visible_line_start, reseat_1)
5855 (init_iterator): Empty the bidi cache "stack".
5856 (move_it_in_display_line_to): If iterator ended up at
5857 EOL, but we never saw any buffer positions smaller than
5858 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5859 motion in bidi-reordered lines.
5860 (move_it_in_display_line_to): Record prev_method and prev_pos
5861 immediately before the call to set_iterator_to_next. Fixes cursor
5862 motion in bidi-reordered lines with stretch glyphs and strings
5863 displayed in margins. (Bug#8133) (Bug#8867)
5864 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5866 (pos_visible_p): Support positions in bidi-reordered lines.
5867 Save and restore bidi cache.
5869 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5870 (bidi_paragraph_info): Delete unused struct.
5871 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5872 (bidi_cache_start): New variable.
5873 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5875 (bidi_cache_fetch_state, bidi_cache_search)
5876 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5877 (bidi_cache_find, bidi_peek_at_next_level)
5878 (bidi_level_of_next_char, bidi_find_other_level_edge)
5879 (bidi_move_to_visually_next): Compare cache index with
5880 bidi_cache_start rather than with zero.
5881 (bidi_fetch_char): Accept new argument STRING; all callers
5882 changed. Support iteration over a string. Support strings with
5883 display properties. Support unibyte strings. Fix the type of
5884 `len' according to what STRING_CHAR_AND_LENGTH expects.
5885 (bidi_paragraph_init, bidi_resolve_explicit_1)
5886 (bidi_resolve_explicit, bidi_resolve_weak)
5887 (bidi_level_of_next_char, bidi_move_to_visually_next):
5888 Support iteration over a string.
5889 (bidi_set_sor_type, bidi_resolve_explicit_1)
5890 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5891 can now be zero (for strings); special values 0 and -1 were
5892 changed to -1 and -2, respectively.
5893 (bidi_char_at_pos): New function.
5894 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5895 Call it instead of FETCH_MULTIBYTE_CHAR.
5896 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5897 initialized to valid values.
5898 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5900 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5901 the test for valid cached positions. Fix the logic for looking up
5902 the sentinel state in the cache. GCPRO the Lisp string we are
5904 (bidi_push_it, bidi_pop_it): New functions.
5905 (bidi_initialize): Initialize the bidi cache start stack pointer.
5906 (bidi_cache_ensure_space): New function, refactored from part of
5907 bidi_cache_iterator_state. Don't assume the required size is just
5908 one BIDI_CACHE_CHUNK away.
5909 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5910 (bidi_count_bytes, bidi_char_at_pos): New functions.
5911 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5912 always valid if bidi_cache_idx is valid.
5913 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5914 is valid if it's going to be used.
5915 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5916 (bidi_cache_fetch_state, bidi_cache_search)
5917 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5918 (bidi_cache_iterator_state, bidi_cache_find)
5919 (bidi_find_other_level_edge, bidi_cache_start_stack):
5920 All variables related to cache indices are now EMACS_INT.
5922 * dispextern.h (struct bidi_string_data): New structure.
5923 (struct bidi_it): New member `string'. Make flag members be 1-bit
5924 fields, and put them last in the struct.
5925 (compute_display_string_pos, compute_display_string_end):
5927 (bidi_push_it, bidi_pop_it): Add prototypes.
5928 (struct iterator_stack_entry): New members bidi_p,
5929 paragraph_embedding, and from_disp_prop_p.
5930 (struct it): Member bidi_p is now a bit field 1 bit wide.
5931 (bidi_shelve_cache, bidi_unshelve_cache):
5934 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5935 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5936 and vector-like objects.
5938 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5939 cache around display iteration.
5941 * window.c (Fwindow_end, window_scroll_pixel_based)
5942 (displayed_window_lines, Frecenter): Save and restore the bidi
5943 cache around display iteration.
5945 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5947 * editfns.c (Fdelete_region): Clarify the use of the named
5948 parameters (bug#6788).
5950 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5952 * indent.c (Fvertical_motion): Set and restore w->pointm when
5953 saving and restoring the window's buffer (Bug#9006).
5955 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5957 * editfns.c (Fstring_to_char): Clarify just what is returned
5958 (bug#6576). Text by Eli Zaretskii.
5960 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5962 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5964 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5966 * buffer.c (mmap_find): Fix a typo.
5968 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5970 Fix execution of x selection hooks.
5971 * xselect.c (Qx_lost_selection_functions)
5972 (Qx_sent_selection_functions): New vars.
5973 (syms_of_xselect): DEFSYM them.
5974 (x_handle_selection_request): Pass Qx_sent_selection_functions
5975 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5976 (x_handle_selection_clear,x_clear_frame_selections):
5977 Pass Qx_lost_selection_functions rather than
5978 Vx_lost_selection_functions to Frun_hook_with_args.
5980 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5982 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5983 The old code sometimes used this field without initializing it.
5985 * alloc.c (gc_sweep): Don't read past end of array.
5986 In theory, the old code could also have corrupted Emacs internals,
5987 though it'd be very unlikely.
5989 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5991 * character.c (Fcharacterp): Don't advertise optional ignored
5992 argument. (Bug#4026)
5994 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5996 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5999 * window.c (Fset_window_start): Doc fix (bug#4199).
6000 (Fset_window_hscroll): Ditto.
6002 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6004 Fix minor new problems caught by GCC 4.6.1.
6005 * term.c (init_tty): Remove unused local.
6006 * xsettings.c (store_monospaced_changed): Define this function only
6007 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6010 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6012 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6014 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6016 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6017 are the mini-buffer and the echo area (bug#3320).
6019 * term.c (init_tty): Remove support for supdup, c10 and perq
6020 terminals, which are no longer supported (bug#1482).
6022 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6024 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6026 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6028 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6029 for non-popups (Bug#3642).
6031 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6033 * alloc.c (reset_malloc_hooks): Protoize.
6034 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6035 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6036 * cm.c (losecursor): Likewise.
6037 * data.c (fmod): Likewise.
6038 * dispnew.c (swap_glyphs_in_rows): Likewise.
6039 * emacs.c (memory_warning_signal): Likewise.
6040 * floatfns.c (float_error): Likewise.
6041 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6042 (otf_open, font_otf_capability, generate_otf_features)
6043 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6045 * image.c (pbm_read_file): Likewise.
6046 * indent.c (string_display_width): Likewise.
6047 * intervals.c (check_for_interval, search_for_interval)
6048 (inc_interval_count, count_intervals, root_interval)
6049 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6050 * lread.c (defalias): Likewise.
6051 * ralloc.c (r_alloc_check): Likewise.
6052 * regex.c (set_image_of_range_1, set_image_of_range)
6053 (regex_grow_registers): Likewise.
6054 * sysdep.c (strerror): Likewise.
6055 * termcap.c (valid_filename_p, tprint, main): Likewise.
6056 * tparam.c (main): Likewise.
6057 * unexhp9k800.c (run_time_remap, save_data_space)
6058 (update_file_ptrs, read_header, write_header, calculate_checksum)
6059 (copy_file, copy_rest, display_header): Likewise.
6060 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6062 * xdisp.c (check_it): Likewise.
6063 * xfaces.c (register_color, unregister_color, unregister_colors):
6065 * xfns.c (print_fontset_result): Likewise.
6066 * xrdb.c (member, fatal, main): Likewise.
6068 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6070 Fix minor problems found by static checking (Bug#9031).
6071 * chartab.c (char_table_set_range, map_sub_char_table):
6072 Remove unused locals.
6073 (uniprop_table): Now static.
6074 * composite.c (_work_char): Remove unused static var.
6076 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6078 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6080 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6082 * gtkutil.c (qttip_cb): Remove code without function.
6084 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6086 * w32.c (pthread_sigmask): New stub.
6088 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6090 Use pthread_sigmask, not sigprocmask (Bug#9010).
6091 sigprocmask is portable only for single-threaded applications, and
6092 Emacs can be multi-threaded when it uses GTK.
6093 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6095 * callproc.c (Fcall_process):
6096 * process.c (create_process):
6097 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6098 Use pthread_sigmask, not sigprocmask.
6100 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6102 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6103 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6106 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6108 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6109 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6110 (xg_hide_tooltip): Fix comment.
6112 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6113 in registerServicesMenuSendTypes.
6114 (validRequestorForSendType): Don't check ns_return_types.
6116 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6119 2011-07-08 Jason Rumney <jasonr@gnu.org>
6121 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6122 SH_SHOW for hidden windows (Bug#5482).
6124 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6125 frame struct members of non-existent frames (Bug#6284).
6127 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6129 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6130 variable firstTime not needed on OSX >= 10.6.
6131 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6132 >= 10.5. Use setKnobProportion, setDoubleValue.
6134 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6135 (MAC_OS_X_VERSION_10_5): Define if not defined.
6136 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6137 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6138 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6140 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6141 cString and lossyCString on OSX >= 10.4
6143 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6144 sizeToFit on OSX >= 10.2.
6146 * nsimage.m (allocInitFromFile): Don't use deprecated method
6147 bestRepresentationForDevice on OSX >= 10.6.
6149 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6152 * emacs.c: Declare unexec_init_emacs_zone.
6154 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6156 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6158 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6159 on svcsMenu (Bug#8842).
6161 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6163 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6165 * nsterm.m (QUTF8_STRING): Declare.
6166 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6167 (validRequestorForSendType): Return type is (id).
6168 Change indexOfObjectIdenticalTo to indexOfObject.
6169 Check if we have local selection before returning self (Bug#8842).
6170 (writeSelectionToPasteboard): Put local selection into paste board
6171 if we have a local selection (Bug#8842).
6172 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6174 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6175 (ns_get_local_selection): Declare.
6177 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6179 * keymap.c (describe_map_tree): Don't insert a double newline at
6180 the end of the buffer (bug#1169) and return whether we inserted
6183 * callint.c (Fcall_interactively): Change "reading args" to
6184 "providing args" to try to clarify what it does (bug#1010).
6186 2011-07-07 Kenichi Handa <handa@m17n.org>
6188 * composite.c (composition_compute_stop_pos): Ignore a static
6189 composition starting before CHARPOS (Bug#8915).
6191 * xdisp.c (handle_composition_prop): Likewise.
6193 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6195 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6198 2011-07-07 Kenichi Handa <handa@m17n.org>
6200 * character.h (unicode_category_t): New enum type.
6202 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6203 (Qchar_code_property_table): New variable.
6204 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6205 (UNIPROP_COMPRESSED_FORM_P): New macros.
6206 (char_table_ascii): Uncompress the compressed values.
6207 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6208 Uncompress the compressed values.
6209 (sub_char_table_ref_and_range): Likewise.
6210 (char_table_ref_and_range): Uncompress the compressed values.
6211 (sub_char_table_set): New arg is_uniprop. Callers changed.
6212 Uncompress the compressed values.
6213 (sub_char_table_set_range): Args changed. Callers changed.
6214 (char_table_set_range): Adjuted for the above change.
6215 (map_sub_char_table): Delete args default_val and parent. Add arg
6216 top. Give decoded values to a Lisp function.
6217 (map_char_table): Adjust for the above change. Give decoded
6218 values to a Lisp function. Gcpro more variables.
6219 (uniprop_table_uncompress)
6220 (uniprop_decode_value_run_length): New functions.
6221 (uniprop_decoder, uniprop_decoder_count): New variables.
6222 (uniprop_get_decoder, uniprop_encode_value_character)
6223 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6225 (uniprop_encoder, uniprop_encoder_count): New variables.
6226 (uniprop_get_encoder, uniprop_table)
6227 (Funicode_property_table_internal, Fget_unicode_property_internal)
6228 (Fput_unicode_property_internal): New functions.
6229 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6230 Sunicode_property_table_internal, Sget_unicode_property_internal,
6231 and Sput_unicode_property_internal. Defvar_lisp
6232 char-code-property-alist.
6234 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6235 Vunicode_category_table.
6237 * font.c (font_range): Adjust for the change of
6238 Vunicode_category_table.
6240 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6242 * m/iris4d.h: Remove file, move contents ...
6243 * s/irix6-5.h: ... here.
6245 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6247 Remove unportable assumption about struct layout (Bug#8884).
6248 * alloc.c (mark_buffer):
6249 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6250 (clone_per_buffer_values): Don't assume that
6251 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6252 This isn't true in general, and it's particularly not true
6253 if Emacs is configured with --with-wide-int.
6254 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6255 New macros, used in the buffer.c change.
6257 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6259 * xsettings.c: Use both GConf and GSettings if both are available.
6260 (store_config_changed_event): Add comment.
6261 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6262 (store_tool_bar_style_changed): New functions.
6263 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6264 (struct xsettings): Move font inside HAVE_XFT.
6265 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6266 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6267 Move inside HAVE_XFT.
6268 (something_changed_gsettingsCB): Rename from something_changedCB.
6269 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6271 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6272 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6273 (something_changed_gconfCB): Rename from something_changedCB.
6274 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6275 (parse_settings): Move check for font inside HAVE_XFT.
6276 (read_settings, apply_xft_settings): Add comment.
6277 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6278 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6279 call store_font_name_changed.
6280 (xft_settings_event): Add comment.
6281 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6282 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6283 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6284 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6285 (xsettings_initialize): Call init_gsettings last.
6286 (xsettings_get_system_font, xsettings_get_system_normal_font):
6289 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6291 Random fixes. E.g., (random) never returned negative values.
6292 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6293 subseconds part to the entropy, as that's a bit more random.
6294 Prefer signed to unsigned, since the signedness doesn't matter and
6295 in general we prefer signed. When given a limit, use a
6296 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6297 latter isn't right if USE_2_TAGS_FOR_INTS.
6298 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6299 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6301 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6303 * textprop.c (text_property_stickiness):
6304 Obey Vtext_property_default_nonsticky.
6305 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6306 * w32fns.c (syms_of_w32fns):
6307 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6309 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6311 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6312 This is more efficient than Ffile_directory_p and avoids a minor race.
6314 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6316 * buffer.c (Foverlay_put): Say what the return value is
6319 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6320 is a directory before asking whether to use the file name
6322 (barf_or_query_if_file_exists): Make the "File is a directory"
6323 error be more correct.
6325 * fns.c (Frequire): Remove the mention of the .gz files, since
6326 that's installation-specific, but keep the mention of
6327 `get-load-suffixes'.
6329 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6331 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6332 Report string overflow if the output is too long.
6334 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6336 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6337 (syms_of_gnutls): Remove duplicate DEFSYM for
6338 Qgnutls_bootprop_verify_hostname_error, an error for
6339 Qgnutls_bootprop_verify_error (which is no longer used).
6341 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6342 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6343 Also (re)move comments that are misplaced or no longer relevant.
6345 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6347 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6349 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6351 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6352 and background color parameters if they have been changed.
6354 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6356 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6358 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6360 * xsettings.c (SYSTEM_FONT): Define only when used.
6361 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6363 * keymap.c (access_keymap_1): Now static.
6365 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6367 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6368 leave any prefix arg for the up event (Bug#1586).
6370 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6372 * lread.c (syms_of_lread): Mention single symbols defined by
6373 `defvar' or `defconst' (bug#7154).
6375 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6376 (Frequire): Mention get-load-suffixes.
6378 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6380 * window.h (window): Remove clone_number slot.
6381 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6383 (make_parent_window, make_window, saved_window)
6384 (Fset_window_configuration, save_window_save): Don't deal with
6386 * buffer.c (Qclone_number): Remove declaration.
6387 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6389 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6391 Add multiple inheritance to keymaps.
6392 * keymap.c (Fmake_composed_keymap): New function.
6393 (Fset_keymap_parent): Simplify.
6394 (fix_submap_inheritance): Remove.
6395 (access_keymap_1): New function extracted from access_keymap to handle
6396 embedded parents and handle lists of maps.
6397 (access_keymap): Use it.
6398 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6399 (Fcopy_keymap): Handle embedded parents.
6400 (Fcommand_remapping, define_as_prefix): Simplify.
6401 (Fkey_binding): Simplify.
6402 (syms_of_keymap): Move minibuffer-local-completion-map,
6403 minibuffer-local-filename-completion-map,
6404 minibuffer-local-must-match-map, and
6405 minibuffer-local-filename-must-match-map to Elisp.
6406 (syms_of_keymap): Defsubr make-composed-keymap.
6407 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6408 (parse_menu_item): Trivial simplification.
6410 2011-07-01 Glenn Morris <rgm@gnu.org>
6412 * Makefile.in (SETTINGS_LIBS): Fix typo.
6414 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6416 * coding.c (Fencode_coding_string): Record the last coding system
6417 used, as the function doc string says (bug#8738).
6419 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6421 * xsettings.c (store_monospaced_changed): Take new font as arg and
6422 check for change against current_mono_font.
6423 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6424 (emacs_settings_constructor, emacs_settings_get_property)
6425 (emacs_settings_set_property, emacs_settings_class_init)
6426 (emacs_settings_init, gsettings_obj): Remove.
6427 (something_changedCB): New function for HAVE_GSETTINGS.
6428 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6429 with value as argument.
6430 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6431 g_settings_new (Bug#8967). Do not create gsettings_obj.
6432 Remove calls to g_settings_bind. Connect something_changedCB to
6435 * xgselect.c: Add defined (HAVE_GSETTINGS).
6436 (xgselect_initialize): Ditto.
6438 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6439 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6442 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6444 * eval.c (struct backtrace): Simplify and port the data structure.
6445 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6446 signed bit field, as this assumption is not portable and it makes
6447 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6448 "char debug_on_exit : 1" as this is not portable either; instead,
6449 use the portable "unsigned int debug_on_exit : 1". Remove unused
6450 member evalargs. Remove obsolete comments about cc bombing out.
6452 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6454 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6455 Let HAVE_GSETTINGS override HAVE_GCONF.
6456 (store_monospaced_changed): New function.
6457 (EMACS_SETTINGS): A new type derived from GObject to handle
6458 GSettings notifications.
6459 (emacs_settings_constructor, emacs_settings_get_property)
6460 (emacs_settings_set_property, emacs_settings_class_init):
6462 (gsettings_client, gsettings_obj): New variables.
6463 (GSETTINGS_SCHEMA): New define.
6464 (something_changedCB): Call store_monospaced_changed.
6465 (init_gsettings): New function.
6466 (xsettings_initialize): Call init_gsettings.
6467 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6470 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6473 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6475 * window.c (resize_root_window, grow_mini_window)
6476 (shrink_mini_window): Rename Qresize_root_window to
6477 Qwindow_resize_root_window and Qresize_root_window_vertically to
6478 Qwindow_resize_root_window_vertically.
6480 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6482 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6484 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6486 * makefile.w32-in: Redesign dependencies so they reflect more
6487 clearly which files are directly included by each source file,
6488 and not through other includes.
6490 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6492 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6493 (sort_overlays, overlay_strings): When an overlay's clone number
6494 matches the window's clone number process the overlay even if
6495 the overlay's window property doesn't match the current window.
6497 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6498 (Fwindow_hchild): Rename to Fwindow_left_child.
6499 (Fwindow_next): Rename to Fwindow_next_sibling.
6500 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6501 (resize_window_check): Rename to window_resize_check.
6502 (resize_window_apply): Rename to window_resize_apply.
6503 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6504 (Fdelete_other_windows_internal, resize_frame_windows)
6505 (Fsplit_window_internal, Fdelete_window_internal)
6506 (grow_mini_window, shrink_mini_window)
6507 (Fresize_mini_window_internal): Fix callers accordingly.
6509 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6511 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6512 (emacs_fixed_set_min_size): Remove.
6513 (emacs_fixed_new): Take frame as argument.
6515 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6516 (_EmacsFixedPrivate): Remove minwidth/height.
6517 Add struct frame *f.
6518 (emacs_fixed_init): Initialize priv->f.
6519 (get_parent_class, emacs_fixed_set_min_size): Remove.
6520 (emacs_fixed_new): Set priv->f to argument.
6521 (emacs_fixed_get_preferred_width)
6522 (emacs_fixed_get_preferred_height): Use min_width/height from
6523 frames size_hint to set minimum and natural (Bug#8919).
6524 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6525 and use min_width/height from frames size_hint to set
6526 min_width/height (Bug#8919).
6528 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6529 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6532 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6534 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6535 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6538 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6540 * process.c (wait_reading_process_output): Bypass select if
6541 waiting for a cell while ignoring keyboard input, and input is
6542 pending. Suggested by Jan Djärv (Bug#8869).
6544 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6546 Use gnulib's dup2 module instead of rolling our own.
6547 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6549 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6551 * dispnew.c (scrolling_window): Before scrolling, turn off a
6552 mouse-highlight in the window being scrolled.
6554 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6556 Move DEFSYM to lisp.h and use everywhere.
6558 * character.h (DEFSYM): Move declaration...
6559 * lisp.h (DEFSYM): ...here.
6565 * w32select.c: Don't include character.h.
6567 * alloc.c (syms_of_alloc):
6568 * buffer.c (syms_of_buffer):
6569 * bytecode.c (syms_of_bytecode):
6570 * callint.c (syms_of_callint):
6571 * casefiddle.c (syms_of_casefiddle):
6572 * casetab.c (init_casetab_once):
6573 * category.c (init_category_once, syms_of_category):
6574 * ccl.c (syms_of_ccl):
6575 * cmds.c (syms_of_cmds):
6576 * composite.c (syms_of_composite):
6577 * dbusbind.c (syms_of_dbusbind):
6578 * dired.c (syms_of_dired):
6579 * dispnew.c (syms_of_display):
6580 * doc.c (syms_of_doc):
6581 * editfns.c (syms_of_editfns):
6582 * emacs.c (syms_of_emacs):
6583 * eval.c (syms_of_eval):
6584 * fileio.c (syms_of_fileio):
6585 * fns.c (syms_of_fns):
6586 * frame.c (syms_of_frame):
6587 * fringe.c (syms_of_fringe):
6588 * insdel.c (syms_of_insdel):
6589 * keymap.c (syms_of_keymap):
6590 * lread.c (init_obarray, syms_of_lread):
6591 * macros.c (syms_of_macros):
6592 * msdos.c (syms_of_msdos):
6593 * print.c (syms_of_print):
6594 * process.c (syms_of_process):
6595 * search.c (syms_of_search):
6596 * sound.c (syms_of_sound):
6597 * syntax.c (init_syntax_once, syms_of_syntax):
6598 * terminal.c (syms_of_terminal):
6599 * textprop.c (syms_of_textprop):
6600 * undo.c (syms_of_undo):
6601 * w32.c (globals_of_w32):
6602 * window.c (syms_of_window):
6603 * xdisp.c (syms_of_xdisp):
6604 * xfaces.c (syms_of_xfaces):
6605 * xfns.c (syms_of_xfns):
6606 * xmenu.c (syms_of_xmenu):
6607 * xsettings.c (syms_of_xsettings):
6608 * xterm.c (syms_of_xterm): Use DEFSYM.
6610 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6612 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6614 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6616 Integer and buffer overflow fixes (Bug#8873).
6618 * print.c (printchar, strout): Check for string overflow.
6619 (PRINTPREPARE, printchar, strout):
6620 Don't set size unless allocation succeeds.
6622 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6623 for sizes. Check for string overflow more accurately.
6624 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6626 * macros.c: Integer and buffer overflow fixes.
6627 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6628 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6629 Use ptrdiff_t, not int, for sizes.
6630 Don't increment bufsize until after realloc succeeds.
6631 Check for size-calculation overflow.
6632 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6634 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6636 * lread.c: Integer overflow fixes.
6637 (read_integer): Radix is now EMACS_INT, not int,
6638 to improve quality of diagnostics for out-of-range radices.
6639 Calculate buffer size correctly for out-of-range radices.
6640 (read1): Check for integer overflow in radices, and in
6641 read-circle numbers.
6642 (read_escape): Avoid int overflow.
6643 (Fload, openp, read_buffer_size, read1)
6644 (substitute_object_recurse, read_vector, read_list, map_obarray):
6645 Use ptrdiff_t, not int, for sizes.
6646 (read1): Use EMACS_INT, not int, for sizes.
6647 Check for size overflow.
6649 * image.c (cache_image): Check for size arithmetic overflow.
6651 * lread.c: Integer overflow issues.
6652 (saved_doc_string_size, saved_doc_string_length)
6653 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6654 Now ptrdiff_t, not int.
6655 (read1): Don't assume doc string length fits in int. Check for
6656 out-of-range doc string lengths.
6657 (read_list): Don't assume file position fits in int.
6658 (read_escape): Check for hex character overflow.
6660 2011-06-22 Leo Liu <sdl.web@gmail.com>
6662 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6663 Move to minibuffer.el.
6665 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6667 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6668 The following patches are for when GLYPH_DEBUG && !XASSERT.
6669 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6670 * dispnew.c (flush_stdout):
6671 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6672 Mark as externally visible.
6673 * dispnew.c (check_window_matrix_pointers): Now static.
6674 * dispnew.c (window_to_frame_vpos):
6675 * xfns.c (unwind_create_frame):
6676 * xterm.c (x_check_font): Remove unused local.
6677 * scroll.c (CHECK_BOUNDS):
6678 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6679 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6680 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6681 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6682 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6684 (debug_method_add): Use va_list and vsprintf rather than relying
6685 on undefined behavior with wrong number of arguments.
6686 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6687 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6688 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6689 since we're not interested in debugging glyphs with old libraries.
6690 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6691 GCC 4.6.0's static checking.
6693 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6695 Integer overflow and signedness fixes (Bug#8873).
6696 A few related buffer overrun fixes, too.
6698 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6700 * dispextern.h (struct face.stipple):
6701 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6702 (x_bitmap_mask, x_allocate_bitmap_record)
6703 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6704 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6705 (x_create_bitmap_from_xpm_data):
6706 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6707 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6709 * xfaces.c (load_pixmap):
6710 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6711 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6712 (.bitmaps_last, struct x_output.icon_bitmap):
6713 Use ptrdiff_t, not int, for bitmap indexes.
6714 (x_allocate_bitmap_record): Check for size overflow.
6715 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6717 Use ptrdiff_t, not int, for overlay counts.
6718 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6719 * editfns.c (overlays_around, get_pos_property):
6720 * textprop.c (get_char_property_and_overlay):
6721 * xdisp.c (next_overlay_change, note_mouse_highlight):
6722 * xfaces.c (face_at_buffer_position):
6723 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6724 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6725 (Fnext_overlay_change, Fprevious_overlay_change)
6726 (mouse_face_overlay_overlaps, Foverlays_in):
6727 Use ptrdiff_t, not int, for sizes.
6728 (overlays_at, overlays_in): Check for size-calculation overflow.
6730 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6732 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6733 (x_session_initialize): Do not assume string length fits in int.
6735 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6736 This is unlikely, but can occur if DPI is outlandish.
6738 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6739 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6741 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6742 * xrdb.c (magic_file_p, search_magic_path):
6743 Omit last arg SUFFIX; it was always 0. All callers changed.
6744 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6746 * xfont.c (xfont_match): Avoid need for strlen.
6748 * xfns.c: Don't assume strlen fits in int.
6749 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6751 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6752 not unsigned long, as we prefer signed integers. All callers changed.
6753 Detect integer overflow in repeat count.
6754 (message_dolog): Don't assume print length fits in 39 bytes.
6755 (display_mode_element): Don't assume strlen fits in int.
6757 * termcap.c: Don't assume sizes fit in int and never overflow.
6758 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6759 (gobble_line): Check for size-calculation overflow.
6761 * minibuf.c (Fread_buffer):
6762 * lread.c (intern, intern_c_string):
6763 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6764 Don't assume string length fits in int.
6766 * keyboard.c (parse_tool_bar_item):
6767 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6769 * font.c: Don't assume string length fits in int.
6770 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6771 Use ptrdiff_t, not int.
6772 (font_intern_prop): Don't assume string length fits in int.
6773 Don't assume integer property fits in fixnum.
6774 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6776 * filelock.c: Fix some buffer overrun and integer overflow issues.
6777 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6778 Reformulate so as not to need the command string.
6779 Invoke gzip -cd rather than gunzip, as it's more portable.
6780 (lock_info_type, lock_file_1, lock_file):
6781 Don't assume pid_t and time_t fit in unsigned long.
6782 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6783 (current_lock_owner): Prefer signed type for sizes.
6784 Use memcpy, not strncpy, where memcpy is what is really wanted.
6785 Don't assume (via atoi) that time_t and pid_t fit in int.
6786 Check for time_t and/or pid_t out of range, e.g., via a network share.
6787 Don't alloca where an auto var works fine.
6789 * fileio.c: Fix some integer overflow issues.
6790 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6791 Don't assume string length fits in int.
6792 (directory_file_name): Don't assume string length fits in long.
6793 (make_temp_name): Don't assume pid fits in int, or that its print
6794 length is less than 20.
6796 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6798 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6800 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6802 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6803 We prefer signed integers, even for size calculations.
6805 * emacs.c: Don't assume string length fits in 'int'.
6806 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6807 (main): Don't invoke strlen when not needed.
6809 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6810 (XD_DEBUG_MESSAGE): Don't waste a byte.
6812 * callproc.c (getenv_internal_1, getenv_internal)
6814 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6816 * lread.c (invalid_syntax): Omit length argument.
6817 All uses changed. This doesn't fix a bug, but it simplifies the
6818 code away from its former Hollerith-constant appearance, and it's
6819 one less 'int' to worry about when looking at integer-overflow issues.
6820 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6822 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6823 This didn't break anything, but it didn't help either.
6824 It's confusing to put a bogus integer in a place where the actual
6825 value does not matter.
6826 (LIST_END_P): Remove unused macro and its bogus comment.
6827 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6829 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6830 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6832 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6833 We prefer signed types, and the value cannot exceed the EMACS_INT
6834 range anyway (because otherwise the length would not be representable).
6835 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6836 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6837 This avoids a GCC warning when WIDE_EMACS_INT.
6839 * indent.c (sane_tab_width): New function.
6840 (current_column, scan_for_column, Findent_to, position_indentation)
6841 (compute_motion): Use it. This is just for clarity.
6842 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6844 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6846 * lisp.h (lint_assume): New macro.
6847 * composite.c (composition_gstring_put_cache):
6848 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6850 * editfns.c, insdel.c:
6851 Omit unnecessary forward decls, to simplify future changes.
6853 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6855 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6857 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6858 Use much-faster test for byte-length change.
6859 Don't assume string byte-length fits in 'int'.
6860 Check that character arg fits in 'int'.
6861 (mapcar1): Declare byte as byte, for clarity.
6863 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6865 * fns.c (concat): Catch string overflow earlier.
6866 Do not rely on integer wraparound.
6868 * dispextern.h (struct it.overlay_strings_charpos)
6869 (struct it.selective): Now EMACS_INT, not int.
6870 * xdisp.c (forward_to_next_line_start)
6871 (back_to_previous_visible_line_start)
6872 (reseat_at_next_visible_line_start, next_element_from_buffer):
6873 Don't arbitrarily truncate the value of 'selective' to int.
6875 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6877 * composite.c: Don't truncate sizes to 'int'.
6878 (composition_gstring_p, composition_reseat_it)
6879 (composition_adjust_point): Use EMACS_INT, not int.
6880 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6881 not EMACS_UINT, for indexes.
6883 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6885 * buffer.c: Include <verify.h>.
6886 (struct sortvec.priority, struct sortstr.priority):
6887 Now EMACS_INT, not int.
6888 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6889 (struct sortstr.size, record_overlay_string)
6890 (struct sortstrlist.size, struct sortlist.used):
6891 Don't truncate size to int.
6892 (record_overlay_string): Check for size-calculation overflow.
6893 (init_buffer_once): Check at compile-time, not run-time.
6895 2011-06-22 Jim Meyering <meyering@redhat.com>
6897 Don't leak an XBM-image-sized buffer
6898 * image.c (xbm_load): Free the image buffer after using it.
6900 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6903 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6904 that Sun C diagnosed.
6905 * fns.c (secure_hash): Fix pointer signedness issue.
6906 * intervals.c (static_offset_intervals): New function.
6907 (offset_intervals): Use it.
6909 2011-06-21 Leo Liu <sdl.web@gmail.com>
6912 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6915 * fns.c (secure_hash): Rename from crypto_hash_function and change
6916 the first arg to accept symbols.
6917 (Fsecure_hash): New primitive.
6918 (syms_of_fns): New symbols.
6920 2011-06-20 Deniz Dogan <deniz@dogan.se>
6922 * process.c (Fset_process_buffer): Clarify return value in
6925 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6927 * dispnew.c (add_window_display_history): Use BVAR.
6929 * xdisp.c (debug_method_add): Use BVAR.
6930 (check_window_end, dump_glyph_matrix, dump_glyph)
6931 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6933 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6936 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6937 check till after the cache is created in init_frame_faces.
6939 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6941 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6943 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6945 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6946 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6947 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6949 Improve buffer-overflow checking (Bug#8873).
6950 * fileio.c (Finsert_file_contents):
6951 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6952 Remove the old (too-loose) buffer overflow checks.
6953 They weren't needed, since make_gap checks for buffer overflow.
6954 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6955 The old code merely checked for Emacs fixnum overflow, and relied
6956 on undefined (wraparound) behavior. The new code avoids undefined
6957 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6959 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6960 Tune. Don't use wider integers than needed. Don't use alloca.
6961 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6963 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6965 * insdel.c, lisp.h (buffer_overflow): New function.
6966 (insert_from_buffer_1, replace_range, replace_range_2):
6967 * insdel.c (make_gap_larger):
6968 * editfns.c (Finsert_char):
6969 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6971 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6973 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6975 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6977 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6978 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6980 * fileio.c: Don't assume EMACS_INT fits in off_t.
6981 (emacs_lseek): New static function.
6982 (Finsert_file_contents, Fwrite_region): Use it.
6983 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6985 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6987 * fns.c: Don't overflow int when computing a list length.
6988 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6989 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6990 truncation on 64-bit hosts. Check for QUIT every
6991 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6992 faster and is responsive enough.
6993 (Flength): Report an error instead of overflowing an integer.
6994 (Fsafe_length): Return a float if the value is not representable
6995 as a fixnum. This shouldn't happen except in contrived situations.
6996 (Fnthcdr, Fsort): Don't assume list length fits in int.
6997 (Fcopy_sequence): Don't assume vector length fits in int.
6999 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7000 (header_size, word_size): New constants.
7001 (allocate_vectorlike): Don't check size overflow here.
7002 (allocate_vector): Check it here instead, since this is the only
7003 caller of allocate_vectorlike that could cause overflow.
7004 Check that the new vector's length is representable as a fixnum.
7006 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7007 The previous code was bogus. For example, next_almost_prime (32)
7008 returned 39, which is undesirable as it is a multiple of 3; and
7009 next_almost_prime (24) returned 25, which is a multiple of 5 so
7010 why was the code bothering to check for multiples of 7?
7012 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7014 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7016 Variadic C functions now count arguments with ptrdiff_t.
7017 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7018 Back then I didn't know that the Emacs coding style prefers signed int.
7019 Also, in the meantime I found a few more instances where arguments
7020 were being counted with int, which may truncate counts on 64-bit
7021 machines, or EMACS_INT, which may be unnecessarily wide.
7022 * lisp.h (struct Lisp_Subr.function.aMANY)
7023 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7024 Arg counts are now ptrdiff_t, not size_t.
7025 All variadic functions and their callers changed accordingly.
7026 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7027 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7028 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7029 * callint.c (Fcall_interactively): Check arg count for overflow,
7030 to avoid potential buffer overrun. Use signed char, not 'int',
7031 for 'varies' array, so that we needn't bother to check its size
7032 calculation for overflow.
7033 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7034 * eval.c (apply_lambda):
7035 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7036 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7037 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7039 * callint.c (Fcall_interactively): Don't use index var as event count.
7041 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7042 * mem-limits.h (SIZE): Remove; no longer used.
7044 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7046 Remove unnecessary casts.
7047 * xterm.c (x_term_init):
7048 * xfns.c (x_set_border_pixel):
7049 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7050 These aren't needed now that we assume ANSI C.
7052 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7053 It's more likely to cause problems (due to unsigned overflow)
7056 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7058 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7060 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7062 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7064 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7066 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7068 GLYPH_CODE_FACE returns EMACS_INT, not int.
7069 * dispextern.h (merge_faces):
7070 * xfaces.c (merge_faces):
7071 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7072 Don't assume EMACS_INT fits in int.
7074 * character.h (CHAR_VALID_P): Remove unused parameter.
7075 * fontset.c, lisp.h, xdisp.c: All uses changed.
7077 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7079 * fns.c (concat): Minor tuning based on overflow analysis.
7080 This doesn't fix any bugs. Use int to hold character, instead
7081 of constantly refetching from Emacs object. Use XFASTINT, not
7082 XINT, for value known to be a character. Don't bother comparing
7083 a single byte to 0400, as it's always less.
7085 * floatfns.c (Fexpt):
7086 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7088 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7091 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7093 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7094 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7095 incorrectly succeed when S was a string, because 4294967386 was
7096 truncated before it was used.
7098 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7099 Otherwise, an out-of-range integer could cause undefined behavior
7102 * composite.c: Use int, not EMACS_INT, for characters.
7103 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7104 EMACS_INT, for values that are known to be in character range.
7105 This doesn't fix any bugs but is the usual style inside Emacs and
7106 may generate better code on 32-bit machines.
7108 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7109 This is for reasons similar to the recent CHAR_STRING fix.
7110 * charset.c (Fencode_char): Check that character arg is actually
7111 a character. Pass an int to ENCODE_CHAR.
7112 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7113 wider than 'int', as a compile-time check to prevent future regressions
7116 * character.c (char_string): Remove unnecessary casts.
7118 Make sure a 64-bit char is never passed to CHAR_STRING.
7119 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7120 by silently ignoring the top 32 bits, allowing some values
7121 that were far too large to be valid characters.
7122 * character.h: Include <verify.h>.
7123 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7124 arguments are no wider than unsigned, as a compile-time check
7125 to prevent future regressions in this area.
7127 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7128 (Fsubst_char_in_region):
7130 * xdisp.c (decode_mode_spec_coding):
7131 Adjust to CHAR_STRING's new requirement.
7132 * editfns.c (Finsert_char, Fsubst_char_in_region):
7133 * fns.c (concat): Check that character args are actually
7134 characters. Without this test, these functions did the wrong
7135 thing with wildly out-of-range values on 64-bit hosts.
7137 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7138 These casts should not be needed on 32-bit hosts, either.
7139 * keyboard.c (read_char):
7140 * lread.c (Fload): Remove casts to unsigned.
7142 * lisp.h (UNSIGNED_CMP): New macro.
7143 This fixes comparison bugs on 64-bit hosts.
7144 (ASCII_CHAR_P): Use it.
7145 * casefiddle.c (casify_object):
7146 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7147 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7148 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7149 * dispextern.h (FACE_FROM_ID):
7150 * keyboard.c (read_char): Use UNSIGNED_CMP.
7152 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7153 not to EMACS_INT, to avoid GCC warning.
7155 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7157 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7158 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7159 isn't needed on 32-bit machines.
7161 * buffer.c (Fgenerate_new_buffer_name):
7162 Use EMACS_INT for count, not int.
7163 (advance_to_char_boundary): Return EMACS_INT, not int.
7165 * data.c (Qcompiled_function): Now static.
7167 * window.c (window_body_lines): Now static.
7169 * image.c (gif_load): Rename local to avoid shadowing.
7171 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7172 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7173 * alloc.c (make_save_value): Integer argument is now of type
7175 (mark_object): Use ptrdiff_t, not int.
7176 * lisp.h (pD): New macro.
7177 * print.c (print_object): Use it.
7179 * alloc.c: Use EMACS_INT, not int, to count objects.
7180 (total_conses, total_markers, total_symbols, total_vector_size)
7181 (total_free_conses, total_free_markers, total_free_symbols)
7182 (total_free_floats, total_floats, total_free_intervals)
7183 (total_intervals, total_strings, total_free_strings):
7184 Now EMACS_INT, not int. All uses changed.
7185 (Fgarbage_collect): Compute overall total using a double, so that
7186 integer overflow is less likely to be a problem. Check for overflow
7187 when converting back to an integer.
7188 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7189 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7190 These were 'int' variables that could overflow on 64-bit hosts;
7191 they were never used, so remove them instead of repairing them.
7192 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7193 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7194 Previously, this ceilinged at INT_MAX, but that doesn't work on
7196 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7198 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7199 (allocate_vectorlike): Check for ptrdiff_t overflow.
7200 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7201 when a (possibly-narrower) signed value would do just as well.
7202 We prefer using signed arithmetic, to avoid comparison confusion.
7204 * alloc.c: Catch some string size overflows that we were missing.
7205 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7206 for convenience in STRING_BYTES_MAX.
7207 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7208 The definition here is exact; the one in lisp.h was approximate.
7209 (allocate_string_data): Check for string overflow. This catches
7210 some instances we weren't catching before. Also, it catches
7211 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7212 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7213 and ptrdiff_t and EMACS_INT are both 64 bits.
7215 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7216 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7217 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7219 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7221 * alloc.c (Fmake_string): Check for out-of-range init.
7223 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7225 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7227 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7229 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7230 xg_get_default_scrollbar_width.
7232 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7233 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7234 (style_changed_cb): Call update_theme_scrollbar_width and call
7235 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7236 all frames (Bug#8505).
7237 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7238 Call gtk_window_set_resizable if HAVE_GTK3.
7239 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7240 and height if HAVE_GTK3 (Bug#8505).
7241 (scroll_bar_width_for_theme): New variable.
7242 (update_theme_scrollbar_width): New function.
7243 (xg_get_default_scrollbar_width): Move code to
7244 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7245 (xg_initialize): Call update_theme_scrollbar_width.
7247 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7249 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7251 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7253 * frame.c (make_frame): Call other_buffer_safely instead of
7256 * window.c (temp_output_buffer_show): Call display_buffer with
7257 second argument Vtemp_buffer_show_specifiers and reset latter
7258 immediately after the call.
7259 (Vtemp_buffer_show_specifiers): New variable.
7260 (auto_window_vscroll_p, next_screen_context_lines)
7261 (Vscroll_preserve_screen_position): Remove leading asterisks from
7264 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7266 Fix minor problems found by GCC 4.6.0 static checking.
7267 * buffer.c (Qclone_number): Remove for now, as it's unused.
7268 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7269 (record_buffer): Remove unused local.
7270 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7271 (set_frame_buffer_list): Remove; unused.
7272 * frame.h (other_visible_frames): Remove decl.
7273 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7274 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7275 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7277 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7278 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7279 Define only if HAVE_GPM.
7280 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7281 (update_hints_inhibit): Remove; never set. All uses removed.
7282 * widgetprv.h (emacsFrameClassRec): Remove decl.
7283 * window.c (delete_deletable_window): Now returns void, since it
7284 wasn't returning anything.
7285 (compare_window_configurations): Remove unused locals.
7286 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7287 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7288 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7289 the same widths as pointers. This follows up on the 2011-05-06 patch.
7290 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7291 * xterm.h: Likewise.
7292 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7294 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7296 * makefile.w32-in: Update dependencies.
7297 (LISP_H): Add lib/intprops.h.
7299 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7301 * image.c (gif_load): Add animation frame delay to the metadata.
7302 (syms_of_image): Use DEFSYM. New symbol `delay'.
7304 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7306 * window.c (delete_deletable_window): Re-add.
7307 (Fset_window_configuration): Rewrite to handle dead buffers and
7308 consequently deletable windows.
7309 (window_tree, Fwindow_tree): Remove. Supply functionality in
7311 (compare_window_configurations): Simplify code.
7313 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7315 * image.c (imagemagick_load_image): Fix type mismatch.
7316 (Fimagemagick_types): Likewise.
7318 * window.h (replace_buffer_in_windows): Declare.
7320 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7322 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7323 Qclone_number. Remove external declaration of Qdelete_window.
7324 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7326 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7327 Run Qbuffer_list_update_hook if allowed.
7328 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7329 buffer list implementation.
7330 (other_buffer_safely): New function.
7331 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7332 calls to replace_buffer_in_windows and
7333 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7335 (record_buffer): Inhibit quitting and rewrite using quittable
7336 functions. Run Qbuffer_list_update_hook if allowed.
7337 (Frecord_buffer, Funrecord_buffer): New functions.
7338 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7339 Move switch-to-buffer to window.el.
7340 (bury-buffer): Move to window.el.
7341 (Vbuffer_list_update_hook): New variable.
7343 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7346 * window.h (resize_frame_windows): Move up in code.
7347 (Fwindow_frame): Remove EXFUN.
7348 (replace_buffer_in_all_windows): Remove prototype.
7349 (replace_buffer_in_windows_safely): Add prototype.
7351 * window.c: Declare Qdelete_window static again. Move down
7352 declaration of select_count.
7353 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7354 (Fother_window): Move to window.el.
7355 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7356 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7357 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7359 (replace_buffer_in_windows): Implement by calling
7360 Qreplace_buffer_in_windows.
7361 (replace_buffer_in_all_windows): Remove with some functionality
7362 moved into replace_buffer_in_windows_safely.
7363 (replace_buffer_in_windows_safely): New function.
7364 (select_window_norecord, select_frame_norecord): Move in front
7365 of run_window_configuration_change_hook. Remove now obsolete
7367 (Fset_window_buffer): Rewrite doc-string.
7368 Call Qrecord_window_buffer.
7369 (keys_of_window): Move binding for other-window to window.el.
7371 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7373 * dispextern.h (struct image): Replace data member, whose int_val
7374 and ptr_val fields were not used by anything, with a single
7377 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7378 (gif_clear_image, gif_load, imagemagick_load_image)
7379 (gs_clear_image, gs_load): Callers changed.
7381 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7383 * buffer.h: Include <time.h>, for time_t.
7384 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7386 Fix minor problems found by static checking.
7388 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7390 Make identifiers static if they are not used in other modules.
7391 * data.c (Qcompiled_function, Qframe, Qvector):
7392 * image.c (QimageMagick, Qsvg):
7393 * minibuf.c (Qmetadata):
7394 * window.c (resize_window_check, resize_root_window): Now static.
7395 * window.h (resize_window_check, resize_root_window): Remove decls.
7397 * window.c (window_deletion_count, delete_deletable_window):
7399 (window_body_lines): Now static.
7400 (Fdelete_other_windows_internal): Mark vars as initialized.
7401 Make sure 'resize_failed' is initialized.
7402 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7403 (resize_window_apply): Remove unused local.
7404 * window.h (delete_deletable_window): Remove decl.
7406 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7407 (imagemagick_load_image): Fix pointer signedness problem by changing
7408 last arg from unsigned char * to char *. All uses changed.
7409 Also, fix a local for similar reasons.
7410 Remove unused locals. Remove locals to avoid shadowing.
7411 (fn_rsvg_handle_free): Remove; unused.
7412 (svg_load, svg_load_image): Fix pointer signedness problem.
7413 (imagemagick_load_image): Don't use garbage pointer image_wand.
7415 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7417 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7419 * image.c (gif_load): Fix omitted cast error introduced by
7422 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7424 * window.h (resize_proportionally, orig_total_lines)
7425 (orig_top_line): Remove from window structure.
7426 (set_window_height, set_window_width, change_window_heights)
7427 (Fdelete_window): Remove prototypes.
7428 (resize_frame_windows): Remove duplicate declaration.
7430 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7432 * window.h (resize_frame_windows, resize_window_check)
7433 (delete_deletable_window, resize_root_window)
7434 (resize_frame_windows): Declare prototypes.
7436 * window.c (resize_window_apply): Make definition be "static" to
7437 match the prototype.
7439 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7441 * window.c: Remove declarations of Qwindow_size_fixed,
7442 window_min_size_1, window_min_size_2, window_min_size,
7443 size_window, window_fixed_size_p, enlarge_window, delete_window.
7444 Remove static from declaration of Qdelete_window, it's
7445 temporarily needed by Fbury_buffer.
7446 (replace_window): Don't assign orig_top_line and
7448 (Fdelete_window, delete_window): Remove. Window deletion is
7449 handled by window.el.
7450 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7451 Replace Fdelete_window calls with calls to Qdelete_window.
7452 (Fdelete_other_windows): Remove. Deleting other windows is
7453 handled by window.el.
7454 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7455 handled in window.el.
7456 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7457 Window minimum sizes are handled in window.el.
7458 (shrink_windows, size_window, set_window_height)
7459 (set_window_width, change_window_heights, window_height)
7460 (window_width, CURBEG, CURSIZE, enlarge_window)
7461 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7462 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7463 handled in window.el.
7464 (make_dummy_parent): Rename to make_parent_window and give it a
7465 second argument horflag.
7466 (make_window): Don't set resize_proportionally any more.
7467 (Fsplit_window): Remove. Windows are split in window.el.
7468 (save_restore_action, save_restore_orig_size)
7469 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7470 Resize mini windows in window.el.
7471 (grow_mini_window, shrink_mini_window): Implement by calling
7472 Qresize_root_window_vertically, resize_window_check and
7473 resize_window_apply.
7474 (saved_window, Fset_window_configuration, save_window_save):
7475 Do not handle orig_top_line, orig_total_lines, and
7476 resize_proportionally.
7477 (window_min_height, window_min_width): Move to window.el.
7478 (keys_of_window): Move bindings for delete-other-windows,
7479 split-window, delete-window and enlarge-window to window.el.
7481 * buffer.c: Temporarily extern Qdelete_window.
7482 (Fbury_buffer): Temporarily call Qdelete_window instead of
7483 Fdelete_window (Fbury_buffer will move to window.el soon).
7485 * frame.c (set_menu_bar_lines_1): Remove code handling
7486 orig_top_line and orig_total_lines.
7488 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7489 set_window_height but set heights directly.
7490 (change_frame_size_1): Use resize_frame_windows.
7492 * xdisp.c (init_xdisp): Don't use set_window_height but set
7495 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7496 Use resize_frame_windows instead of change_window_heights and run
7497 run_window_configuration_change_hook.
7499 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7500 instead of change_window_heights and run
7501 run_window_configuration_change_hook.
7503 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7505 * window.c (replace_window): Rename second argument REPLACEMENT to
7506 NEW. New third argument SETFLAG. Rewrite.
7507 (delete_window, make_dummy_parent): Call replace_window with
7509 (window_list_1): Move down in code.
7510 (run_window_configuration_change_hook): Move set_buffer part
7511 before select_frame_norecord part in order to unwind correctly.
7512 Rename count1 to count.
7513 (recombine_windows, delete_deletable_window, resize_root_window)
7514 (Fdelete_other_windows_internal)
7515 (Frun_window_configuration_change_hook, make_parent_window)
7516 (resize_window_check, resize_window_apply, Fresize_window_apply)
7517 (resize_frame_windows, Fsplit_window_internal)
7518 (Fdelete_window_internal, Fresize_mini_window_internal):
7520 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7522 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7524 * window.h (window): Add some new members to window structure -
7525 normal_lines, normal_cols, new_total, new_normal, clone_number,
7526 splits, nest, prev_buffers, next_buffers.
7527 (WINDOW_TOTAL_SIZE): Move here from window.c.
7528 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7530 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7532 (make_dummy_parent): Set new members of windows structure.
7533 (make_window): Move down in code. Handle new members of window
7535 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7536 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7537 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7538 (Fset_window_prev_buffers, Fwindow_next_buffers)
7539 (Fset_window_next_buffers, Fset_window_clone_number):
7541 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7542 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7544 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7545 Argument WINDOW can be now internal window too.
7546 (Fwindow_use_time): Move up in code.
7547 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7549 (Fset_window_configuration, saved_window)
7550 (Fcurrent_window_configuration, save_window_save): Handle new
7551 members of window structure.
7552 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7553 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7554 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7555 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7556 Qget_mru_window, Qresize_root_window,
7557 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7558 Qauto_buffer_name; staticpro them.
7560 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7562 * window.c (Fwindow_total_size, Fwindow_left_column)
7563 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7564 (Fwindow_list_1): New functions.
7565 (window_box_text_cols): Replace with window_body_cols.
7566 (Fwindow_width, Fscroll_left, Fscroll_right):
7567 Use window_body_cols instead of window_box_text_cols.
7568 (delete_window, Fset_window_configuration):
7569 Call delete_all_subwindows with window as argument.
7570 (delete_all_subwindows): Take a window as argument and not a
7572 (window_loop): Remove handling of GET_LRU_WINDOW and
7574 (Fget_lru_window, Fget_largest_window): Move to window.el.
7576 * window.h: Extern window_body_cols instead of
7577 window_box_text_cols. delete_all_subwindows now takes a
7578 Lisp_Object as argument.
7580 * indent.c (compute_motion, Fcompute_motion):
7581 Use window_body_cols instead of window_box_text_cols.
7583 * frame.c (delete_frame): Call delete_all_subwindows with root
7586 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7588 * fns.c (Fputhash): Document return value.
7590 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7592 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7594 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7596 Cons<->int and similar integer overflow fixes (Bug#8794).
7598 Check for overflow when converting integer to cons and back.
7599 * charset.c (Fdefine_charset_internal, Fdecode_char):
7600 Use cons_to_unsigned to catch overflow.
7601 (Fencode_char): Use INTEGER_TO_CONS.
7602 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7603 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7604 * data.c (long_to_cons, cons_to_long): Remove.
7605 (cons_to_unsigned, cons_to_signed): New functions.
7606 These signal an error for invalid or out-of-range values.
7607 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7608 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7609 * font.c (Ffont_variation_glyphs):
7610 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7611 * lisp.h: Include <intprops.h>.
7612 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7613 (cons_to_signed, cons_to_unsigned): New decls.
7614 (long_to_cons, cons_to_long): Remove decls.
7615 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7616 (Fprimitive_undo): Use CONS_TO_INTEGER.
7617 * xfns.c (Fx_window_property): Likewise.
7618 * xselect.c: Include <limits.h>.
7619 (x_own_selection, selection_data_to_lisp_data):
7620 Use INTEGER_TO_CONS.
7621 (x_handle_selection_request, x_handle_selection_clear)
7622 (x_get_foreign_selection, Fx_disown_selection_internal)
7623 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7624 (lisp_data_to_selection_data): Use cons_to_unsigned.
7625 (x_fill_property_data): Use cons_to_signed.
7626 Report values out of range.
7628 Check for buffer and string overflow more precisely.
7629 * buffer.h (BUF_BYTES_MAX): New macro.
7630 * lisp.h (STRING_BYTES_MAX): New macro.
7631 * alloc.c (Fmake_string):
7632 * character.c (string_escape_byte8):
7633 * coding.c (coding_alloc_by_realloc):
7634 * doprnt.c (doprnt):
7635 * editfns.c (Fformat):
7637 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7638 since they may not be the same number.
7639 * editfns.c (Finsert_char):
7640 * fileio.c (Finsert_file_contents):
7641 Likewise for BUF_BYTES_MAX.
7643 * image.c: Use ptrdiff_t, not int, for sizes.
7644 (slurp_file): Switch from int to ptrdiff_t.
7646 (slurp_file): Check that file size fits in both size_t (for
7647 malloc) and ptrdiff_t (for sanity and safety).
7649 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7650 if b->modtime has its maximal value.
7652 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7654 Don't assume time_t can fit into int.
7655 * buffer.h (struct buffer.modtime): Now time_t, not int.
7656 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7657 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7659 Minor fixes for signed vs unsigned integers.
7660 * character.h (MAYBE_UNIFY_CHAR):
7661 * charset.c (maybe_unify_char):
7662 * keyboard.c (read_char, reorder_modifiers):
7663 XINT -> XFASTINT, since the integer must be nonnegative.
7664 * ftfont.c (ftfont_spec_pattern):
7665 * keymap.c (access_keymap, silly_event_symbol_error):
7666 XUINT -> XFASTINT, since the integer must be nonnegative.
7667 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7668 since it makes no difference and we prefer signed.
7669 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7670 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7673 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7675 * window.h (Fwindow_frame): Declare.
7677 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7679 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7680 (SPARE_MEMORY): Always define.
7681 (LARGE_REQUEST): Remove.
7682 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7684 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7686 * lisp.h: Move EXFUNS for Fframe_root_window,
7687 Fframe_first_window and Fset_frame_selected_window to window.h.
7689 * window.h: Move EXFUNS for Fframe_root_window,
7690 Fframe_first_window and Fset_frame_selected_window here from
7693 * frame.c (Fwindow_frame, Fframe_first_window)
7694 (Fframe_root_window, Fframe_selected_window)
7695 (Fset_frame_selected_window): Move to window.c.
7696 (Factive_minibuffer_window): Move to minibuf.c.
7697 (Fother_visible_frames_p): New function.
7699 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7701 * window.c (decode_window, decode_any_window): Move up in code.
7702 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7703 (inhibit_frame_unsplittable): Remove unused variable.
7704 (Fwindow_buffer): Move up and rewrite doc-string.
7705 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7706 (Fwindow_prev): New functions.
7707 (Fwindow_frame): Move here from frame.c. Accept any window as
7709 (Fframe_root_window, Fframe_first_window)
7710 (Fframe_selected_window): Move here from frame.c. Accept frame
7711 or arbitrary window as argument. Update doc-strings.
7712 (Fminibuffer_window): Move up in code.
7713 (Fwindow_minibuffer_p): Move up in code and simplify.
7714 (Fset_frame_selected_window): Move here from frame.c.
7716 (Fselected_window, select_window, Fselect_window): Move up in
7717 code. Minor doc-string fixes.
7719 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7721 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7722 Do not assume that spare memory exists; that assumption is valid
7723 only if SYSTEM_MALLOC.
7724 (LARGE_REQUEST): New macro, so that the issue of large requests
7725 is separated from the issue of spare memory.
7727 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7729 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7732 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7734 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7737 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7739 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7741 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7743 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7744 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7746 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7748 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7750 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7752 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7753 (x_clipboard_manager_save): Add return value.
7754 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7756 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7757 Obey Vx_select_enable_clipboard_manager. Catch errors in
7758 x_clipboard_manager_save (Bug#8779).
7759 (Vx_select_enable_clipboard_manager): New variable.
7760 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7762 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7764 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7766 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7768 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7769 in the current matrix if keep_current_p is non-zero.
7771 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7773 * bidi.c (bidi_level_of_next_char): Fix last change.
7775 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7777 Support bidi reordering of text covered by display properties.
7779 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7780 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7781 (bidi_cache_search, bidi_cache_iterator_state)
7782 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7783 (bidi_level_of_next_char, bidi_move_to_visually_next):
7784 Support character positions inside a run of characters covered by a
7786 (bidi_paragraph_init, bidi_resolve_explicit_1)
7787 (bidi_level_of_next_char): Call bidi_fetch_char and
7788 bidi_fetch_char_advance instead of FETCH_CHAR and
7790 (bidi_init_it): Initialize new members.
7791 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7793 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7794 instead of using explicit *_CHAR codes.
7795 (bidi_resolve_explicit, bidi_resolve_weak):
7796 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7797 bidirectional text is supported only in multibyte buffers.
7798 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7799 it to initialize the frame_window_p member of struct bidi_it.
7800 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7801 (bidi_resolve_explicit, bidi_resolve_weak)
7802 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7803 bidi_it->nchars is non-positive.
7804 (bidi_level_of_next_char): Don't try to lookup the cache for the
7805 next/previous character if nothing is cached there yet, or if we
7806 were just reseat()'ed to a new position.
7808 * xdisp.c (set_cursor_from_row): Set start and stop points
7809 according to the row's direction when priming the loop that looks
7810 for the glyph on which to display cursor.
7811 (single_display_spec_intangible_p): Function deleted.
7812 (display_prop_intangible_p): Reimplement to call
7813 handle_display_spec instead of single_display_spec_intangible_p.
7814 Accept 3 additional arguments needed by handle_display_spec.
7815 This fixes incorrect cursor motion across display property with complex
7816 values: lists, `(when COND...)' forms, etc.
7817 (single_display_spec_string_p): Support property values that are
7818 lists with the argument STRING its top-level element.
7819 (display_prop_string_p): Fix the condition for processing a
7820 property that is a list to be consistent with handle_display_spec.
7821 (handle_display_spec): New function, refactored from the
7822 last portion of handle_display_prop.
7823 (compute_display_string_pos): Accept additional argument
7824 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7825 value of a `display' property is a "replacing spec".
7826 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7827 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7828 the display property, but just return a value indicating whether
7829 the display property will replace the characters it covers.
7830 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7831 frame_window_p members of struct bidi_it.
7832 (compute_display_string_pos, compute_display_string_end):
7834 (push_it): Accept second argument POSITION, where pop_it should
7835 jump to continue iteration.
7836 (reseat_1): Initialize bidi_it.disp_pos.
7838 * keyboard.c (adjust_point_for_property): Adjust the call to
7839 display_prop_intangible_p to its new signature.
7841 * dispextern.h (struct bidi_it): New member frame_window_p.
7842 (bidi_init_it): Update prototypes.
7843 (display_prop_intangible_p): Update prototype.
7844 (compute_display_string_pos, compute_display_string_end):
7846 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7849 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7851 Malloc failure behavior now depends on size of allocation.
7852 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7853 * lisp.h: Change signatures accordingly.
7854 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7855 All callers changed. (Bug#8762)
7857 * gnutls.c: Use Emacs's memory allocators.
7858 Without this change, the gnutls library would invoke malloc etc.
7859 directly, which causes problems on non-SYNC_INPUT hosts, and which
7860 runs afoul of improving memory_full behavior. (Bug#8761)
7861 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7862 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7863 xfree instead of the default malloc, realloc, free.
7864 (Fgnutls_boot): No need to check for memory allocation failure,
7865 since xmalloc does that for us.
7867 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7868 * category.c (hash_get_category_set):
7869 * ccl.c (ccl_driver):
7870 * charset.c (Fdefine_charset_internal):
7871 * charset.h (struct charset.hash_index):
7872 * composite.c (get_composition_id, gstring_lookup_cache)
7873 (composition_gstring_put_cache):
7874 * composite.h (struct composition.hash_index):
7875 * dispextern.h (struct image.hash):
7876 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7877 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7878 (hashfn_equal, hashfn_user_defined, make_hash_table)
7879 (maybe_resize_hash_table, hash_lookup, hash_put)
7880 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7881 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7882 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7883 * image.c (make_image, search_image_cache, lookup_image)
7884 (xpm_put_color_table_h):
7885 * lisp.h (struct Lisp_Hash_Table):
7886 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7887 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7888 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7889 * alloc.c (allocate_vectorlike):
7890 Check for overflow in vector size calculations.
7891 * ccl.c (ccl_driver):
7892 Check for overflow when converting EMACS_INT to int.
7893 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7894 need to be updated by these changes.
7895 * fns.c (make_hash_table, maybe_resize_hash_table):
7896 Check for integer overflow with large hash tables.
7897 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7898 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7899 (SXHASH_REDUCE): New macro.
7900 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7901 Use it instead of discarding useful hash info with large hash values.
7902 (sxhash_float): New function.
7903 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7904 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7905 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7906 Rewrite to use FIXNUM_BITS, as this simplifies things.
7907 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7908 Adjust signatures to match updated version of code.
7909 (consing_since_gc): Now EMACS_INT, since a single hash table can
7910 use more than INT_MAX bytes.
7912 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7914 Make it possible to build with GCC-4.6+ -O2 -flto.
7916 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7918 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7920 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7921 Call minibuffer-inactive-mode.
7923 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7925 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7926 Update dependencies.
7928 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7930 * data.c (init_data): Remove code for UTS, this system is not
7933 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7935 Don't force ./temacs to start in terminal mode.
7937 * frame.c (make_initial_frame): Initialize faces in all cases, not
7938 only when CANNOT_DUMP is defined.
7939 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7941 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7943 * dispnew.c (add_window_display_history): Use const for the string
7944 pointer. Remove declaration, not needed.
7946 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7948 Use 'inline', not 'INLINE'.
7949 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7950 * alloc.c, fontset.c (INLINE): Remove.
7951 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7952 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7953 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7954 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7955 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7957 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7959 Make it possible to run ./temacs.
7961 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7962 syms_of_callproc does the same thing. Remove test for
7963 "initialized", do it in the caller.
7964 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7966 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7968 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7969 (read_minibuf): Use get_minibuffer.
7970 (syms_of_minibuf): Use DEFSYM.
7971 (Qmetadata): New var.
7972 * data.c (Qbuffer): Don't make it static.
7973 (syms_of_data): Use DEFSYM.
7975 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7977 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7978 (CCL_CODE_MIN): New macro.
7980 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7982 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7984 * eval.c (Qdebug): Now static.
7985 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7986 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7987 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7989 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7991 * image.c: Various fixes to ImageMagick code comments.
7992 (Fimagemagick_types): Doc fix.
7994 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7996 Minor fixes prompted by GCC 4.6.0 warnings.
7998 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8000 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8001 (x_clipboard_manager_save_all): Move extern decl to ...
8002 * xterm.h: ... here, so that it can be checked for consistency.
8004 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8006 * xselect.c (x_clipboard_manager_save_frame)
8007 (x_clipboard_manager_save_all): New functions.
8008 (Fx_clipboard_manager_save): Lisp function deleted.
8010 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8011 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8013 * xterm.h: Update prototype.
8015 2011-05-28 William Xu <william.xwl@gmail.com>
8017 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8020 2011-05-28 Jim Meyering <meyering@redhat.com>
8022 Avoid a sign-extension bug in crypto_hash_function.
8023 * fns.c (to_uchar): Define.
8024 (crypto_hash_function): Use it to convert some newly-signed
8025 variables to unsigned, to avoid sign-extension bugs. For example,
8026 without this change, (md5 "truc") would evaluate to
8027 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8028 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8029 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8031 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8033 Integer overflow fixes.
8035 * dbusbind.c: Serial number integer overflow fixes.
8036 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8037 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8038 to hold a serial number that is too large for a fixnum.
8039 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8040 Check for serial numbers out of range. Decode any serial number
8041 that was so large that it became a float. (Bug#8722)
8043 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8044 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8045 Use XFASTINT rather than XUINT when numbers are nonnegative.
8046 (xd_append_arg, Fdbus_method_return_internal):
8047 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8048 arguments, check that Lisp number is nonnegative, rather than
8049 silently wrapping negative numbers around. (Bug#8722)
8050 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8053 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8055 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8057 ccl: Add integer overflow checks.
8058 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8059 (IN_INT_RANGE): New macros.
8060 (ccl_driver): Use them to check for integer overflow when
8061 decoding a CCL program. Many of the new checks are whether XINT (x)
8062 fits in int; it doesn't always, on 64-bit hosts. The new version
8063 doesn't catch all possible integer overflows, but it's an
8064 improvement. (Bug#8719)
8066 * alloc.c (make_event_array): Use XINT, not XUINT.
8067 There's no need for unsigned here.
8069 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8070 This follows up to the 2011-05-06 change that substituted uintptr_t
8071 for EMACS_INT. This case wasn't caught back then.
8073 Rework Fformat to avoid integer overflow issues.
8074 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8075 now (part of C89). Include <verify.h>.
8076 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8077 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8078 (Fformat): Avoid the prepass trying to compute sizes; it was only
8079 approximate and thus did not catch overflow reliably. Instead, walk
8080 through the format just once, formatting and computing sizes as we go,
8081 checking for integer overflow at every step, and allocating a larger
8082 buffer as needed. Keep track separately whether the format is
8083 multibyte. Keep only the most-recently calculated precision, rather
8084 than them all. Record whether each argument has been converted to
8085 string. Use EMACS_INT, not int, for byte and char and arg counts.
8086 Support field widths and precisions larger than INT_MAX. Avoid
8087 sprintf's undefined behavior with conversion specifications such as %#d
8088 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8089 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8090 formatting out-of-range floating point numbers with int
8093 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8095 * data.c: Avoid integer truncation in expressions involving floats.
8096 * data.c: Include <intprops.h>.
8097 (arith_driver): When there's an integer overflow in an expression
8098 involving floating point, convert the integers to floating point
8099 so that the resulting value does not suffer from catastrophic
8100 integer truncation. For example, on a 64-bit host (* 4
8101 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8102 Do not rely on undefined behavior after integer overflow.
8104 merge count_size_as_multibyte, parse_str_to_multibyte
8105 * character.c, character.h (count_size_as_multibyte):
8106 Rename from parse_str_to_multibyte; all uses changed.
8107 Check for integer overflow.
8108 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8109 since it's now a duplicate of the other. This is more of
8110 a character than a buffer op, so better that it's in character.c.
8111 * fns.c, print.c: Adjust to above changes.
8113 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8115 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8117 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8119 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8120 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8121 (x_clipboard_manager_save): Now static.
8122 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8124 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8125 (crypto_hash_function): Now static.
8126 Fix pointer signedness problems. Avoid unnecessary initializations.
8128 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8130 * termhooks.h (Vselection_alist): Make it terminal-local.
8132 * terminal.c (create_terminal): Initialize it.
8134 * xselect.c: Support for clipboard managers.
8135 (Vselection_alist): Move to termhooks.h as terminal-local var.
8136 (LOCAL_SELECTION): New macro.
8137 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8138 (symbol_to_x_atom): Remove gratuitous arg.
8139 (x_handle_selection_request, lisp_data_to_selection_data)
8140 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8141 (x_own_selection, x_get_local_selection, x_convert_selection):
8142 New arg, specifying work frame. Use terminal-local Vselection_alist.
8143 (some_frame_on_display): Delete unused function.
8144 (Fx_own_selection_internal, Fx_get_selection_internal)
8145 (Fx_disown_selection_internal, Fx_selection_owner_p)
8146 (Fx_selection_exists_p): New optional frame arg.
8147 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8148 (x_handle_selection_clear): Don't treat other terminals with the
8149 same keyboard specially. Use the terminal-local Vselection_alist.
8150 (x_clear_frame_selections): Use Frun_hook_with_args.
8152 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8154 * xterm.h: Add support for those atoms.
8156 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8158 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8159 (converted_selections, conversion_fail_tag): New global variables.
8160 (x_selection_request_lisp_error): Free the above.
8161 (x_get_local_selection): Remove unnecessary code.
8162 (x_reply_selection_request): Args changed; handle arbitrary array
8163 of converted selections stored in converted_selections.
8164 Separate the XChangeProperty and SelectionNotify steps.
8165 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8166 (x_convert_selection): New function.
8167 (x_handle_selection_event): Simplify.
8168 (x_get_foreign_selection): Don't ignore incoming requests while
8169 waiting for an answer; this will fail when we implement
8170 SAVE_TARGETS, and seems unnecessary anyway.
8171 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8172 (Vx_sent_selection_functions): Doc fix.
8174 2011-05-26 Leo Liu <sdl.web@gmail.com>
8176 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8178 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8180 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8182 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8183 for fringe update if it has periodic bitmap.
8184 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8185 and fringe_bitmap_periodic_p.
8187 * fringe.c (get_fringe_bitmap_data): New function.
8188 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8189 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8190 row. Mark glyph row for fringe update if periodicity changed.
8192 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8193 for fringe update unless it has periodic bitmap.
8195 2011-05-25 Kenichi Handa <handa@m17n.org>
8197 * xdisp.c (get_next_display_element): Set correct it->face_id for
8198 a static composition.
8200 2011-05-24 Leo Liu <sdl.web@gmail.com>
8203 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8205 * fns.c (crypto_hash_function, Fsha1): New function.
8206 (Fmd5): Use crypto_hash_function.
8207 (syms_of_fns): Add Ssha1.
8209 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8211 * gnutls.c: Remove unused macros.
8212 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8213 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8214 Remove macros that are defined and never used.
8215 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8217 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8219 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8220 (Fx_get_selection_internal): Minor cleanup.
8221 (Fx_own_selection_internal): Rename arguments for consistency with
8224 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8226 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8228 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8230 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8232 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8234 * dispnew.c (scrolling_window): Don't exclude the case that the
8235 last enabled row in the desired matrix touches the bottom boundary.
8237 2011-05-21 Glenn Morris <rgm@gnu.org>
8239 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8240 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8241 and add some more files.
8243 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8245 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8246 report_file_error introduced by the change from 2011-05-07.
8248 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8250 * systime.h (Time): Define only if emacs is defined.
8251 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8252 where the include path doesn't have X11/X.h by default. See
8253 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8255 2011-05-20 Kenichi Handa <handa@m17n.org>
8257 * composite.c (find_automatic_composition): Fix previous change.
8259 2011-05-20 Glenn Morris <rgm@gnu.org>
8261 * lisp.mk: New file, split from Makefile.in.
8262 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8263 (shortlisp): Remove.
8264 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8266 2011-05-19 Glenn Morris <rgm@gnu.org>
8268 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8269 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8270 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8271 (lisp): Set the order to that of loadup.el.
8272 (shortlisp): Make it a copy of $lisp.
8273 (SOME_MACHINE_LISP): Remove.
8274 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8275 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8277 2011-05-18 Kenichi Handa <handa@m17n.org>
8279 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8280 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8281 (find_automatic_composition): Mostly rewrite for efficiency.
8283 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8285 * makefile.w32-in: Update dependencies.
8287 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8289 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8290 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8292 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8294 Fix some integer overflow issues, such as string length overflow.
8296 * insdel.c (count_size_as_multibyte): Check for string overflow.
8298 * character.c (lisp_string_width): Check for string overflow.
8299 Use EMACS_INT, not int, for string indexes and lengths; in
8300 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8301 the resulting string length overflows an EMACS_INT; instead,
8302 report a string overflow if no precision given. When checking for
8303 precision exhaustion, use a check that cannot possibly have
8304 integer overflow. (Bug#8675)
8305 * character.h (lisp_string_width): Adjust to new signature.
8307 * alloc.c (string_overflow): New function.
8308 (Fmake_string): Use it. This doesn't change behavior, but saves
8309 a few bytes and will simplify future changes.
8310 * character.c (string_escape_byte8): Likewise.
8311 * lisp.h (string_overflow): New decl.
8313 Fixups, following up to the user-interface timestamp change.
8314 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8315 for UI timestamps, instead of unsigned long.
8316 * msdos.c (mouse_get_pos): Likewise.
8317 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8318 * w32gui.h (Time): Define by including "systime.h" rather than by
8319 declaring it ourselves. (Bug#8664)
8321 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8322 * image.c (clear_image_cache): Likewise.
8324 * term.c (term_mouse_position): Don't assume time_t wraparound.
8326 Be more systematic about user-interface timestamps.
8327 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8328 and sometimes 'EMACS_UINT', to represent these timestamps.
8329 This change causes it to use 'Time' uniformly, as that's what X uses.
8330 This makes the code easier to follow, and makes it easier to catch
8331 integer overflow bugs such as Bug#8664.
8332 * frame.c (Fmouse_position, Fmouse_pixel_position):
8333 Use Time, not unsigned long, for user-interface timestamps.
8334 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8335 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8336 * keyboard.h (last_event_timestamp): Likewise.
8337 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8338 * menu.h (xmenu_show): Likewise.
8339 * term.c (term_mouse_position): Likewise.
8340 * termhooks.h (struct input_event.timestamp): Likewise.
8341 (struct terminal.mouse_position_hook): Likewise.
8342 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8343 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8344 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8345 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8347 * menu.h, termhooks.h: Include "systime.h", for Time.
8349 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8350 Don't assume that the difference between two unsigned long values
8351 can fit into an integer. At this point, we know button_down_time
8352 <= event->timestamp, so the difference must be nonnegative, so
8353 there's no need to cast the result if double-click-time is
8354 nonnegative, as it should be; check that it's nonnegative, just in
8355 case. This bug is triggered when events are more than 2**31 ms
8356 apart (about 25 days). (Bug#8664)
8358 * xselect.c (last_event_timestamp): Remove duplicate decl.
8359 (x_own_selection): Remove needless cast to unsigned long.
8361 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8362 that always fit in int. Use a sentinel instead of a counter, to
8363 avoid a temp and to allay GCC's concerns about possible int overflow.
8364 * frame.h (struct frame): Use int for menu_bar_items_used
8365 instead of EMACS_INT, since it always fits in int.
8367 * menu.c (grow_menu_items): Check for int overflow.
8369 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8371 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8372 Before, the code was not consistent. These values cannot exceed
8373 2**31 - 1 so there's no need to make them unsigned.
8374 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8375 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8376 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8378 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8380 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8381 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8382 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8383 presumably because the widths might not match.
8385 * window.c (size_window): Avoid needless test at loop start.
8387 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8389 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8391 2011-05-12 Drew Adams <drew.adams@oracle.com>
8393 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8395 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8397 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8398 `width' to `bar_area_x' and `bar_area_width', respectively.
8399 (x_scroll_run): Take account of fringe background extension.
8401 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8402 Rename local vars `left' and `width' to `bar_area_x' and
8403 `bar_area_width', respectively.
8404 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8405 background extension.
8407 2011-05-10 Jim Meyering <meyering@redhat.com>
8409 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8411 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8413 * image.c (Finit_image_library): Return t for built-in image types,
8414 like pbm and xbm. (Bug#8640)
8416 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8418 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8420 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8422 * w32console.c (Fset_screen_color): Doc fix.
8423 (Fget_screen_color): New function.
8424 (syms_of_ntterm): Defsubr it.
8426 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8427 unlink the temporary file if Fcall_process didn't create it in the
8429 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8430 child process will be redirected to a file specified with `:file'.
8431 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8432 cue to call_process_cleanup not to close that handle.
8434 2011-05-07 Ben Key <bkey76@gmail.com>
8436 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8437 one of two shell specific rules, either bootstrap-temacs-CMD or
8438 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8439 to the previous implementation of the bootstrap-temacs rule.
8440 The bootstrap-temacs-CMD rule is similar to the previous
8441 implementation of the bootstrap-temacs rule except that it
8442 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8445 These changes, along with some changes to nt/configure.bat,
8446 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8447 earlier fix to add support for --cflags and --ldflags options
8448 that include quotes so that it works whether make uses cmd or
8451 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8453 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8454 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8456 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8457 a string. Handle both cases.
8458 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8459 (Fdbus_register_method): Use Qinvalid_function.
8461 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8463 * makefile.w32-in: Update dependencies.
8464 (LISP_H): Add inttypes.h and stdin.h.
8465 (PROCESS_H): Add unistd.h.
8467 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8469 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8470 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8472 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8474 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8476 * term.c (vfatal): Remove stray call to va_end.
8477 It's not needed and the C Standard doesn't allow it here anyway.
8479 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8480 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8482 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8485 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8487 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8489 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8491 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8493 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8495 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8496 * charset.c (Fdefine_charset_internal): Don't initialize
8497 charset.code_space[15]. The value was garbage, on hosts with
8498 32-bit int (Bug#8600).
8500 * lread.c (read_integer): Be more consistent with string-to-number.
8501 Use string_to_number to do the actual conversion; this avoids
8502 rounding errors and fixes some other screwups. Without this fix,
8503 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8504 (digit_to_number): Move earlier, for benefit of read_integer.
8505 Return -1 if the digit is out of range for the base, -2 if it is
8506 not a digit in any supported base. (Bug#8602)
8508 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8510 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8511 to match comment at start of function. This also removes a
8512 GCC warning about overflow in a 32+64-bit port.
8514 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8516 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8517 Reported by Stefan Monnier in
8518 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8519 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8520 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8522 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8523 (EMACS_UINTPTR): Likewise, with uintptr_t.
8525 * lisp.h: Prefer 64-bit EMACS_INT if available.
8526 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8527 on 32-bit hosts that have 64-bit int, so that they can access
8529 However, temporarily disable this change unless the temporary
8530 symbol WIDE_EMACS_INT is defined.
8532 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8534 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8535 This removes an assumption that EMACS_INT and long are the same
8536 width as pointers. The assumption is true for Emacs porting targets
8537 now, but we want to make other targets possible.
8538 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8539 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8540 In the rest of the code, change types of integers that hold casted
8541 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8542 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8543 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8544 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8545 No need to cast type when ORing.
8546 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8547 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8548 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8549 assume EMACS_INT is the same width as char *.
8550 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8551 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8552 Remove no-longer-needed casts.
8553 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8554 (xg_tool_bar_help_callback, xg_make_tool_item):
8555 Use EMACS_INTPTR to hold an integer
8556 that will be cast to void *; this can avoid a GCC warning
8557 if EMACS_INT is not the same width as void *.
8558 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8559 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8560 (current_message_1, set_message_1):
8561 Use a local to convert to proper width without a cast.
8562 * xmenu.c (dialog_selection_callback): Likewise.
8564 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8565 Also, don't assume VALBITS / RAND_BITS is less than 5,
8566 and don't rely on undefined behavior when shifting a 1 left into
8568 * lisp.h (get_random): Change signature to match.
8570 * lread.c (hash_string): Use size_t, not int, for hash computation.
8571 Normally we prefer signed values; but hashing is special, because
8572 it's better to use unsigned division on hash table sizes so that
8573 the remainder is nonnegative. Also, size_t is the natural width
8574 for hashing into memory. The previous code used 'int', which doesn't
8575 retain enough info to hash well into very large tables.
8576 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8578 * dbusbind.c: Don't possibly lose pointer info when converting.
8579 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8580 Use XPNTR rather than XHASH, so that the high-order bits of
8581 the pointer aren't lost when converting through void *.
8583 * eval.c (Fautoload): Don't double-shift a pointer.
8585 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8587 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8589 * gnutls.c (DEF_GNUTLS_FN):
8590 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8592 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8594 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8597 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8599 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8600 New version that can reserve upto 2GB of heap space.
8602 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8604 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8606 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8608 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8609 `gnutls_certificate_set_x509_key_file'.
8611 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8613 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8614 Update dependencies.
8616 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8618 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8619 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8620 Remove unused parameter `fildes'.
8621 * process.c (read_process_output, send_process): Don't pass it.
8623 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8625 Fix previous change: the library cache is defined in w32.c.
8626 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8627 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8629 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8631 Implement dynamic loading of GnuTLS on Windows.
8633 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8634 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8635 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8638 * gnutls.c (Qgnutls_dll): Define.
8639 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8640 (gnutls_*): Declare function pointers.
8641 (init_gnutls_functions): New function to initialize function pointers.
8642 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8643 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8644 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8645 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8646 (emacs_gnutls_write, emacs_gnutls_read)
8647 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8648 (Fgnutls_available_p): New function.
8649 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8650 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8651 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8653 * image.c: Include w32.h.
8654 (Vimage_type_cache): Delete.
8655 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8656 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8657 (w32_delayed_load): Move to w32.c.
8659 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8661 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8662 (w32_delayed_load): Move from image.c. When loading a library, record
8663 its filename in the :loaded-from property of the library id.
8664 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8665 Initialize and staticpro them.
8666 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8668 * process.c: Include lisp.h before w32.h, not after.
8669 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8670 instead of gnutls_record_check_pending.
8672 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8674 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8676 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8677 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8680 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8682 * xterm.c (x_set_frame_alpha): Do not set property on anything
8683 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8685 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8687 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8689 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8691 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8692 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8693 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8694 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8695 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8696 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8697 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8698 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8699 (Qgnutls_bootprop_callbacks_verify): Make static.
8701 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8703 * callproc.c: Indentation fixup.
8705 * sysdep.c (wait_for_termination_1): Make static.
8706 (wait_for_termination, interruptible_wait_for_termination):
8707 Move after wait_for_termination_1.
8709 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8711 * sysdep.c (interruptible_wait_for_termination): New function
8712 which is like wait_for_termination, but allows keyboard
8715 * callproc.c (Fcall_process): Add (:file "file") as an option for
8717 (Fcall_process_region): Ditto.
8719 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8721 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8722 rather than `XVECTOR (FOO)->size'.
8724 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8725 inttypes.h, as a gnulib replacement is used if it not available in
8728 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8730 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8731 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8732 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8734 * coding.c (coding_alloc_by_realloc): Error out if destination
8735 will grow beyond MOST_POSITIVE_FIXNUM.
8736 (decode_coding_emacs_mule): Abort if there isn't enough place in
8737 charbuf for the composition carryover bytes. Reserve an extra
8738 space for up to 2 characters produced in a loop.
8739 (decode_coding_iso_2022): Abort if there isn't enough place in
8740 charbuf for the composition carryover bytes.
8742 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8744 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8745 aborting when %lld or %lll format is passed.
8746 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8747 %llo or %llx format is passed. (Bug#8545)
8749 * window.c (window_scroll_line_based): Use a marker instead of
8750 simple variables to record original value of point. (Bug#7952)
8752 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8753 produced by %s or %c overflows available buffer space. (Bug#8545)
8755 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8757 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8758 (SIZE_MAX): Move defn after all includes, as they might #define it.
8760 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8762 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8764 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8766 * keyboard.c (Qdelayed_warnings_hook): Define.
8767 (command_loop_1): Run `delayed-warnings-hook'
8768 if Vdelayed_warnings_list is non-nil.
8769 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8770 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8772 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8774 * doprnt.c (doprnt): Don't return value smaller than the buffer
8775 size if the message was truncated. (Bug#8545).
8777 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8779 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8780 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8782 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8784 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8786 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8788 * makefile.w32-in: Update dependencies.
8790 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8792 Improve `doprnt' and its usage. (Bug#8545)
8793 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8794 `format_end'. Remove support for %l as a conversion specifier.
8795 Don't use xrealloc. Improve diagnostics when the %l size modifier
8796 is used. Update the commentary.
8798 * eval.c (verror): Simplify calculation of size_t.
8800 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8803 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8805 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8808 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8810 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8811 This makes this file independent of the recent pseudovector change.
8813 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8815 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8817 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8818 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8819 Remove unused local.
8820 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8822 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8823 GCC 4.6.0 optimizes based on type-based alias analysis.
8824 For example, if b is of type struct buffer * and v of type struct
8825 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8826 != &v->size, and therefore "v->size = 1; b->size = 2; return
8827 v->size;" must therefore return 1. This assumption is incorrect
8828 for Emacs, since it type-puns struct Lisp_Vector * with many other
8829 types. To fix this problem, this patch adds a new type struct
8830 vectorlike_header that documents the constraints on layout of vectors
8831 and pseudovectors, and helps optimizing compilers not get fooled
8832 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8833 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8834 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8836 (XSETPVECTYPE): Rewrite in terms of new macro.
8837 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8838 This is a bit clearer, and further avoids the possibility of
8839 undesirable aliasing.
8840 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8841 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8842 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8843 since Lisp_Subr is a special case (no "next" field).
8844 (ASIZE): Now uses header.size rather than size.
8845 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8846 to avoid the hassle of writing XVECTOR (foo)->header.size.
8847 (struct vectorlike_header): New type.
8848 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8849 object, to help avoid aliasing.
8850 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8851 (SUBRP): Likewise, since Lisp_Subr is a special case.
8852 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8853 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8854 (struct Lisp_Hash_Table): Combine first two members into a single
8855 struct vectorlike_header member. All uses of "size" and "next" members
8856 changed to be "header.size" and "header.next".
8857 * buffer.h (struct buffer): Likewise.
8858 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8859 * frame.h (struct frame): Likewise.
8860 * process.h (struct Lisp_Process): Likewise.
8861 * termhooks.h (struct terminal): Likewise.
8862 * window.c (struct save_window_data, struct saved_window): Likewise.
8863 * window.h (struct window): Likewise.
8864 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8865 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8866 * buffer.c (init_buffer_once): Likewise.
8867 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8869 * process.c (Fformat_network_address): Use local var for size,
8872 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8874 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8875 * data.c (atof): Remove decl; no longer used or needed.
8876 (digit_to_number): Move to lread.c.
8877 (Fstring_to_number): Use new string_to_number function, to be
8878 consistent with how the Lisp reader treats infinities and NaNs.
8879 Do not assume that floating-point numbers represent EMACS_INT
8880 without losing information; this is not true on most 64-bit hosts.
8881 Avoid double-rounding errors, by insisting on integers when
8882 parsing non-base-10 numbers, as the documentation specifies.
8883 * lisp.h (string_to_number): New decl, replacing ...
8884 (isfloat_string): Remove.
8885 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8886 (read1): Do not accept +. and -. as integers; this
8887 appears to have been a coding error. Similarly, do not accept
8888 strings like +-1e0 as floating point numbers. Do not report
8889 overflow for integer overflows unless the base is not 10 which
8890 means we have no simple and reliable way to continue.
8891 Break out the floating-point parsing into a new
8892 function string_to_number, so that Fstring_to_number parses
8893 floating point numbers consistently with the Lisp reader.
8894 (digit_to_number): Move here from data.c. Make it static inline.
8895 (E_CHAR, EXP_INT): Remove, replacing with ...
8896 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8897 (string_to_number): New function, replacing isfloat_string.
8898 This function checks for valid syntax and produces the resulting
8899 Lisp float number too. Rework it so that string-to-number
8900 no longer mishandles examples like "1.0e+". Use strtoumax,
8901 so that overflow for non-base-10 numbers is reported only when
8902 there's no portable and simple way to convert to floating point.
8904 * textprop.c (set_text_properties_1): Rewrite for clarity,
8905 and to avoid GCC warning about integer overflow.
8907 * intervals.h (struct interval): Use EMACS_INT for members
8908 where EMACS_UINT might cause problems. See
8909 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8910 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8911 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8913 (offset_intervals): Tell GCC not to worry about length overflow
8914 when negating a negative length.
8916 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8917 (overrun_check_free): Likewise.
8919 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8920 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8923 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8924 (gnutls_make_error): Rename local to avoid shadowing.
8925 (gnutls_emacs_global_deinit): ifdef out; not used.
8926 (Fgnutls_boot): Use const for pointer to readonly storage.
8927 Comment out unused local. Fix pointer signedness problems.
8929 * lread.c (openp): Don't stuff size_t into an 'int'.
8930 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8931 about possible signed overflow.
8933 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8934 (GDK_KEY_g): Don't define if already defined.
8935 (xg_prepare_tooltip): Avoid pointer signedness problem.
8936 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8938 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8939 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8941 * xfns.c (Fx_window_property): Simplify a bit,
8942 to make a bit faster and to avoid GCC 4.6.0 warning.
8943 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8945 * fns.c (internal_equal): Don't assume size_t fits in int.
8947 * alloc.c (compact_small_strings): Tighten assertion a little.
8949 Replace pEd with more-general pI, and fix some printf arg casts.
8950 * lisp.h (pI): New macro, generalizing old pEd macro to other
8951 conversion specifiers. For example, use "...%"pI"d..." rather
8952 than "...%"pEd"...".
8953 (pEd): Remove. All uses replaced with similar uses of pI.
8954 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8955 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8956 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8957 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8958 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8959 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8960 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8962 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8963 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8964 * print.c (safe_debug_print, print_object): Likewise.
8965 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8967 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8968 avoiding the 0 flag, which is not portable.
8969 * process.c (Fmake_network_process): Use pI to avoid cast.
8970 * region-cache.c (pp_cache): Likewise.
8971 * xdisp.c (decode_mode_spec): Likewise.
8972 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8973 behavior on 64-bit hosts with printf arg.
8974 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8975 (x_stop_queuing_selection_requests): Likewise.
8976 (x_get_window_property): Don't truncate byte count to an 'int'
8979 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8980 here, since it parses constructs like leading '-' and spaces,
8981 which are not wanted; and it overflows with large numbers.
8982 Instead, simply match F[0-9]+, which is what is wanted anyway.
8984 * alloc.c: Remove unportable assumptions about struct layout.
8985 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8986 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8987 (allocate_vectorlike, make_pure_vector): Use the new macros,
8988 plus offsetof, to remove unportable assumptions about struct layout.
8989 These assumptions hold on all porting targets that I know of, but
8990 they are not guaranteed, they're easy to remove, and removing them
8991 makes further changes easier.
8993 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8994 This doesn't fix a bug but makes the code clearer.
8995 (string_overrun_cookie): Now const. Use initializers that
8996 don't formally overflow signed char, to avoid warnings.
8997 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8998 can cause Emacs to crash when string overrun checking is enabled.
8999 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9000 multiple of sizeof (EMACS_INT); it need not be, if
9001 alignof(EMACS_INT) < sizeof (EMACS_INT).
9002 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9004 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9006 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9008 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9010 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9011 supposed to be handshaking. (Bug#8556)
9012 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9014 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9016 * lisp.h (Qdebug): List symbol.
9017 * eval.c (Qdebug): Restore global linkage.
9018 * keyboard.c (debug-on-event): New variable.
9019 (handle_user_signal): Break into debugger when debug-on-event
9020 matches the current signal symbol.
9022 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9024 * alloc.c (check_sblock, check_string_bytes)
9025 (check_string_free_list): Convert to standard C.
9027 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9029 * w32.c (emacs_gnutls_push): Fix typo.
9031 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9033 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9034 "cast to pointer from integer of different size".
9036 Improve doprnt and its use in verror. (Bug#8545)
9037 * doprnt.c (doprnt): Document the set of format control sequences
9038 supported by the function. Use SAFE_ALLOCA instead of always
9041 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9042 is one byte too soon. Don't use xrealloc; instead xfree and
9045 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9047 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9050 * gnutls.c: Renamed global_initialized to
9051 gnutls_global_initialized. Added internals for the
9052 :verify-hostname-error, :verify-error, and :verify-flags
9053 parameters of `gnutls-boot' and documented those parameters in the
9054 docstring. Start callback support.
9055 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9056 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9057 on error. Return error code.
9058 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9059 (emacs_gnutls_read): Likewise.
9060 (Fgnutls_boot): Return handshake error code.
9061 (emacs_gnutls_handle_error): New function.
9062 (wsaerror_to_errno): Likewise.
9064 * w32.h (emacs_gnutls_pull): Add prototype.
9065 (emacs_gnutls_push): Likewise.
9067 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9068 (emacs_gnutls_push): Likewise.
9070 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9072 * process.c (wait_reading_process_output): Check if GnuTLS
9073 buffered some data internally if no FDs are set for TLS
9076 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9077 (LIBS): Link to USER_LIBS.
9078 ($(BLD)/gnutls.$(0)): New target.
9080 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9082 * xdisp.c (handle_single_display_spec): Rename the
9083 display_replaced_before_p argument into display_replaced_p, to
9084 make it consistent with the commentary. Fix typos in the
9087 * textprop.c (syms_of_textprop): Remove dead code.
9088 (copy_text_properties): Delete obsolete commentary about an
9089 interface that was deleted long ago. Fix typos in the description
9092 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9093 to changes in oldXMenu/XMenu.h from 2011-04-16.
9094 <menu_help_message, prev_menu_help_message>: Constify.
9095 (IT_menu_make_room): menu->help_text is now `const char **';
9098 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9099 to changes in oldXMenu/XMenu.h from 2011-04-16.
9100 (struct XMenu): Declare `help_text' `const char **'.
9102 * xfaces.c <Qunspecified>: Make extern again.
9104 * syntax.c: Include sys/types.h before including regex.h, as
9107 * doc.c (get_doc_string): Improve the format passed to `error'.
9109 * doprnt.c (doprnt): Improve commentary.
9111 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9113 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9116 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9117 changes in globals.h immediately force recompilation.
9118 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9119 $(CURDIR)/s/ms-w32.h.
9120 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9122 * character.c (Fchar_direction): Function deleted.
9123 (syms_of_character): Don't defsubr it.
9124 <char-direction-table>: Deleted.
9126 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9128 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9129 * doprnt.c: Include limits.h.
9130 (SIZE_MAX): New macro.
9131 (doprnt): Return a size_t value. 2nd arg is now size_t.
9132 Many local variables are now size_t instead of int or unsigned.
9133 Improve overflow protection. Support `l' modifier for integer
9134 conversions. Support %l conversion. Don't assume an EMACS_INT
9135 argument for integer conversions and for %c.
9137 * lisp.h (doprnt): Restore prototype.
9139 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9142 * Makefile.in (base_obj): Add back doprnt.o.
9144 * deps.mk (doprnt.o): Add back prerequisites.
9145 (callint.o): Depend on character.h.
9147 * eval.c (internal_lisp_condition_case): Include the handler
9148 representation in the error message.
9149 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9150 when breaking from the loop.
9152 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9154 * callint.c (Fcall_interactively): When displaying error message
9155 about invalid control letter, pass the character's codepoint, not
9156 a pointer to its multibyte form. Improve display of the character
9157 in octal and display also its hex code.
9159 * character.c (char_string): Use %x to display the (unsigned)
9160 codepoint of an invalid character, to avoid displaying a bogus
9163 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9164 `error', not SYMBOL_NAME itself.
9166 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9167 character arguments to `error'.
9169 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9170 to `error' in error message about FINAL_CHAR argument. Make sure
9171 FINAL_CHAR is a character, and use %c when it is passed as
9172 argument to `error'.
9174 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9176 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9178 * w32.c: Include <time.h>.
9179 (sys_localtime): New function.
9181 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9183 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9185 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9187 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9189 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9192 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9194 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9195 gl_state.e_property when gl_state.object is Qt.
9197 * insdel.c (make_gap_larger): Remove limitation of buffer size
9200 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9202 * xdisp.c (lookup_glyphless_char_display)
9203 (produce_glyphless_glyph): Handle cons cell entry in
9204 glyphless-char-display.
9205 (Vglyphless_char_display): Document it.
9207 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9208 glyphless-char-display.
9210 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9212 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9214 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9216 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9217 definition for no-X builds.
9219 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9221 Static checks with GCC 4.6.0 and non-default toolkits.
9223 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9225 * process.c (keyboard_bit_set): Define only if SIGIO.
9226 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9227 (send_process): Repair possible setjmp clobbering.
9229 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9231 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9233 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9235 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9236 Define only if needed.
9238 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9239 by pacifying GCC about it. Maybe it's time to retire it?
9240 * xfaces.c (USG, __TIMEVAL__): Likewise.
9242 * dispextern.h (struct redisplay_interface): Rename param
9244 * termhooks.h (struct terminal): Likewise.
9245 * xterm.c (xembed_send_message): Likewise.
9247 * insdel.c (make_gap_smaller): Define only if
9248 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9250 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9253 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9254 so that we aren't warned about unused symbols.
9256 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9258 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9260 * xfns.c (x_real_positions): Mark locals as initialized.
9262 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9264 * xterm.c: Fix problems found by static analysis with other toolkits.
9265 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9266 (x_dispatch_event): Declare static if USE_GTK, and
9267 define if USE_GTK || USE_X_TOOLKIT.
9268 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9269 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9270 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9271 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9273 * xmenu.c (menu_help_callback): Pointer type fixes.
9274 Use const pointers when pointing at readonly data. Avoid pointer
9276 (FALSE): Remove unused macro.
9277 (update_frame_menubar): Remove unused decl.
9279 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9281 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9282 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9283 (single_menu_item): Rename local to avoid shadowing.
9285 * keyboard.c (make_lispy_event): Remove unused local var.
9287 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9288 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9290 * bitmaps: Change bitmaps from unsigned char back to the X11
9291 compatible char. Avoid the old compiler warnings about
9292 out-of-range initializers by using, for example, '\xab' rather
9295 * xgselect.c (xgselect_initialize): Check vs interface
9296 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9298 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9300 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9301 to read-only memory.
9303 * fns.c (vector): Remove; this old hack is no longer needed.
9305 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9307 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9309 * xrdb.c (x_load_resources): Omit unused local.
9311 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9312 (x_window): Rename locals to avoid shadowing.
9313 (USG): Use the kludged USG macro, to pacify gcc.
9315 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9316 (x_term_init): Remove local to avoid shadowing.
9318 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9320 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9321 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9323 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9325 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9327 Fix regex.c, syntax.c and friends for buffers > 2GB.
9328 * syntax.h (struct gl_state_s): Declare character position members
9331 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9333 * textprop.c (verify_interval_modification, interval_of):
9334 Declare arguments EMACS_INT.
9336 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9339 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9341 * indent.c (Fvertical_motion): Local variable it_start is now
9344 * regex.c (re_match, re_match_2, re_match_2_internal)
9345 (bcmp_translate, regcomp, regexec, print_double_string)
9346 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9347 (re_compile_pattern, re_exec): Declare arguments and local
9348 variables `size_t' and `ssize_t' and return values `regoff_t', as
9350 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9351 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9352 <compile_stack_type>: `size' and `avail' are now `size_t'.
9354 * regex.h <regoff_t>: Use ssize_t, not int.
9355 (re_search, re_search_2, re_match, re_match_2): Arguments that
9356 specify buffer/string position and length are now ssize_t and
9357 size_t. Return type is regoff_t.
9359 2011-04-16 Ben Key <bkey76@gmail.com>
9361 * nsfont.m: Fixed bugs in ns_get_family and
9362 ns_descriptor_to_entity that were caused by using free to
9363 deallocate memory blocks that were allocated by xmalloc (via
9364 xstrdup). This caused Emacs to crash when compiled with
9365 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9366 --enable-checking=xmallocoverrun). xfree is now used to
9367 deallocate these memory blocks.
9369 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9371 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9373 emacs_write: Accept and return EMACS_INT for sizes.
9374 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9376 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9377 Accept and return EMACS_INT.
9378 (emacs_gnutls_write): Return the number of bytes written on
9380 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9381 (emacs_read, emacs_write): Remove check for negative size, as the
9382 Emacs source code has been audited now.
9383 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9384 (emacs_read, emacs_write): Use it.
9385 * process.c (send_process): Adjust to the new signatures of
9386 emacs_write and emacs_gnutls_write. Do not attempt to store
9387 a byte offset into an 'int'; it might overflow.
9388 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9390 * sound.c: Don't assume sizes fit in 'int'.
9391 (struct sound_device.period_size, alsa_period_size):
9392 Return EMACS_INT, not int.
9393 (struct sound_device.write, vox_write, alsa_write):
9394 Accept EMACS_INT, not int.
9395 (wav_play, au_play): Use EMACS_INT to store sizes and to
9396 record read return values.
9398 2011-04-15 Ben Key <bkey76@gmail.com>
9400 * keyboard.c (Qundefined): Don't declare static since it is used
9402 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9403 static since they are used in nsfont.m.
9405 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9407 * process.c (Qprocessp): Don't declare static.
9408 * lisp.h (Qprocessp): Declare again.
9410 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9412 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9414 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9416 Improve C-level modularity by making more things 'static'.
9418 Don't publish debugger-only interfaces to other modules.
9419 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9420 (verify_bytepos, count_markers): Move decls to the only modules
9422 * region-cache.h (pp_cache): Likewise.
9423 * window.h (check_all_windows): Likewise.
9424 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9426 * sysdep.c (croak): Now static, if
9427 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9428 * syssignal.h (croak): Declare only if not static.
9430 * alloc.c (refill_memory_reserve): Now static if
9431 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9432 * lisp.h (refill_memory_reserve): Declare only if not static.
9434 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9435 Define only if USE_LUCID.
9437 * xrdb.c (x_customization_string, x_rm_string): Now static.
9439 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9440 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9442 * xdisp.c (draw_row_with_mouse_face): Now static.
9443 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9445 * window.h (check_all_windows): Mark externally visible.
9447 * window.c (window_deletion_count): Now static.
9449 * undo.c: Make symbols static if they're not exported.
9450 (last_undo_buffer, last_boundary_position, pending_boundary):
9453 * textprop.c (interval_insert_behind_hooks): Now static.
9454 (interval_insert_in_front_hooks): Likewise.
9456 * term.c: Make symbols static if they're not exported.
9457 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9458 (max_frame_lines, tty_set_terminal_modes):
9459 (tty_reset_terminal_modes, tty_turn_off_highlight):
9460 (get_tty_terminal): Now static.
9461 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9462 * termhooks.h (term_mouse_moveto): Do not declare if
9464 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9465 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9467 * sysdep.c: Make symbols static if they're not exported.
9468 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9470 (sigprocmask_set, full_mask): Remove; unused.
9471 (wait_debugging): Mark as visible.
9472 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9473 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9475 * syntax.c (syntax_temp): Define only if !__GNUC__.
9477 * sound.c (current_sound_device, current_sound): Now static.
9479 * search.c (searchbufs, searchbuf_head): Now static.
9481 * scroll.c (scroll_cost): Remove; unused.
9482 * dispextern.h (scroll_cost): Remove decl.
9484 * region-cache.h (pp_cache): Mark as externally visible.
9486 * process.c: Make symbols static if they're not exported.
9487 (process_tick, update_tick, create_process, chan_process):
9488 (Vprocess_alist, proc_buffered_char, datagram_access):
9489 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9490 (deactivate_process): Mark defn as static, as well as decl.
9491 * lisp.h (create_process): Remove decl.
9492 * process.h (chan_process, Vprocess_alist): Remove decls.
9494 * print.c: Make symbols static if they're not exported.
9495 (print_depth, new_backquote_output, being_printed, print_buffer):
9496 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9497 (print_interval, print_number_index, initial_stderr_stream):
9499 * lisp.h (Fprinc): Remove decl.
9500 (debug_output_compilation_hack): Mark as externally visible.
9502 * sysdep.c (croak): Move decl from here to syssignal.h.
9503 * syssignal.h (croak): Put it here, so the API can be checked when
9504 'croak' is called from dissociate_if_controlling_tty.
9506 * minibuf.c: Make symbols static if they're not exported.
9507 (minibuf_save_list, choose_minibuf_frame): Now static.
9508 * lisp.h (choose_minibuf_frame): Remove decl.
9510 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9512 * lread.c: Make symbols static if they're not exported.
9513 (read_objects, initial_obarray, oblookup_last_bucket_number):
9515 (make_symbol): Remove; unused.
9516 * lisp.h (initial_obarray, make_symbol): Remove decls.
9518 * keyboard.c: Make symbols static if they're not exported.
9519 (single_kboard, recent_keys_index, total_keys, recent_keys):
9520 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9521 (this_single_command_key_start, echoing, last_auto_save):
9522 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9523 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9524 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9525 (Vlispy_mouse_stem, double_click_count):
9527 (force_auto_save_soon): Define only if SIGDANGER.
9528 (ignore_mouse_drag_p): Now static if
9529 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9530 (print_help): Remove; unused.
9531 (stop_character, last_timer_event): Mark as externally visible.
9532 * keyboard.h (ignore_mouse_drag_p): Declare only if
9533 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9534 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9535 * lisp.h (echoing): Remove decl.
9536 (force_auto_save_soon): Declare only if SIGDANGER.
9537 * xdisp.c (redisplay_window): Simplify code, to make it more
9538 obvious that ignore_mouse_drag_p is not accessed if !defined
9539 USE_GTK && !defined HAVE_NS.
9541 * intervals.c: Make symbols static if they're not exported.
9542 (merge_properties_sticky, merge_interval_right, delete_interval):
9544 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9546 * insdel.c: Make symbols static if they're not exported.
9547 However, leave prepare_to_modify_buffer alone. It's never
9548 called from outside this function, but that appears to be a bug.
9549 (combine_after_change_list, combine_after_change_buffer):
9550 (adjust_after_replace, signal_before_change): Now static.
9551 (adjust_after_replace_noundo): Remove; unused.
9552 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9553 (signal_before_change): Remove decls.
9555 * indent.c (val_compute_motion, val_vmotion): Now static.
9557 * image.c: Make symbols static if they're not exported.
9558 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9560 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9561 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9563 * fringe.c (standard_bitmaps): Now static.
9564 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9566 * frame.c: Make symbols static if they're not exported.
9567 (x_report_frame_params, make_terminal_frame): Now static.
9568 (get_frame_param): Now static, unless HAVE_NS.
9569 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9570 (x_get_resource_string): Remove; not used.
9571 * frame.h (make_terminal_frame, x_report_frame_params):
9572 (x_get_resource_string); Remove decls.
9573 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9574 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9576 * font.c, fontset.c: Make symbols static if they're not exported.
9577 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9578 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9579 * font.c (font_close_object): Now static.
9580 * font.h (font_close_object): Remove.
9581 * fontset.c (FONTSET_OBJLIST): Remove.
9582 (free_realized_fontset) #if-0 the body, which does nothing.
9583 (face_suitable_for_char_p): #if-0, as it's never called.
9584 * fontset.h (face_suitable_for_char_p): Remove decl.
9585 * xfaces.c (face_at_string_position):
9586 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9587 since 0 is always ASCII.
9589 * fns.c (weak_hash_tables): Now static.
9591 * fileio.c: Make symbols static if they're not exported.
9592 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9593 (Vwrite_region_annotation_buffers): Now static.
9595 * eval.c: Make symbols static if they're not exported.
9596 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9597 * lisp.h (backtrace_list): Remove decl.
9599 * emacs.c: Make symbols static if they're not exported.
9600 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9601 (fatal_error_code, fatal_error_signal_hook, standard_args):
9603 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9604 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9605 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9606 * lisp.h (fatal_error_signal_hook): Remove decl.
9607 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9609 * editfns.c: Move a (normally-unused) function to its only use.
9610 * editfns.c, lisp.h (get_operating_system_release): Remove.
9611 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9612 worth the hassle of breaking this out.
9614 * xterm.c: Make symbols static if they're not exported.
9615 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9616 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9617 (x_destroy_window, x_delete_display):
9619 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9620 (x_mouse_leave): Remove; unused.
9621 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9622 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9623 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9625 (x_mouse_leave): Declare only if WINDOWSNT.
9626 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9627 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9630 * ftxfont.c: Make symbols static if they're not exported.
9631 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9633 * font.h (ftxfont_driver): Likewise.
9635 * xfns.c: Make symbols static if they're not exported.
9636 (x_last_font_name, x_display_info_for_name):
9637 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9638 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9639 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9640 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9641 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9642 (last_show_tip_args): Now static.
9643 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9644 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9645 (x_screen_planes): Remove; unused.
9646 * dispextern.h (x_screen_planes): Remove decl.
9648 * dispnew.c: Make symbols static if they're not exported.
9649 * dispextern.h (redraw_garbaged_frames, scrolling):
9650 (increment_row_positions): Remove.
9651 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9652 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9654 (redraw_garbaged_frames): Remove; unused.
9656 * xfaces.c: Make symbols static if they're not exported.
9657 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9659 * xterm.h (defined_color): Remove decls.
9660 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9661 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9662 (menu_face_changed_default, defined_color, free_realized_face):
9663 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9664 (ascii_face_of_lisp_face): Remove; unused.
9666 * xdisp.c: Make symbols static if they're not exported.
9667 * dispextern.h (scratch_glyph_row, window_box_edges):
9668 (glyph_to_pixel_coords, set_cursor_from_row):
9669 (get_next_display_element, set_iterator_to_next):
9670 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9671 (show_mouse_face): Remove decls
9672 * frame.h (message_buf_print): Likewise.
9673 * lisp.h (pop_message, set_message, check_point_in_composition):
9675 * xterm.h (set_vertical_scroll_bar): Likewise.
9676 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9677 (message_buf_print, scratch_glyph_row, displayed_buffer):
9678 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9679 (get_next_display_element, show_mouse_face, window_box_edges):
9680 (frame_to_window_pixel_xy, check_point_in_composition):
9681 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9682 (glyph_to_pixel_coords): Remove; unused.
9684 * dired.c (file_name_completion): Now static.
9686 * dbusbind.c (xd_in_read_queued_messages): Now static.
9688 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9689 * data.c (circular_list_error): Remove.
9691 * commands.h (last_point_position, last_point_position_buffer):
9692 (last_point_position_window): Remove decls.
9693 * keyboard.c: Make these variables static.
9695 * coding.h (coding, code_convert_region, encode_coding_gap):
9697 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9698 (iso_code_class, detect_coding, code_convert_region): Now static.
9699 (encode_coding_gap): Remove; unused.
9701 * chartab.c (chartab_chars, chartab_bits): Now static.
9703 * charset.h (charset_iso_8859_1): Remove decl.
9704 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9707 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9708 * ccl.c (Vccl_program_table): Now static.
9709 (check_ccl_update): Remove; unused.
9711 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9712 * category.h: ... from here.
9713 * category.c (check_category_table, set_category_set): Now static.
9715 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9716 * lisp.h: Remove these decls.
9718 * buffer.c (buffer_count): Remove unused var.
9720 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9721 so that it's not optimized away.
9722 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9723 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9724 exported only to the debugger.
9726 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9727 * atimer.h (run_all_atimers): Remove; not exported.
9729 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9730 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9731 was inaccessible from Lisp.
9732 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9733 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9735 alloc.c: Import and export fewer symbols, and remove unused items.
9736 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9738 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9739 it's not optimized away by whole-program optimization.
9740 (message_enable_multibyte, free_misc): Remove.
9741 (catchlist, handlerlist, mark_backtrace):
9742 Declare only if BYTE_MARK_STACK.
9743 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9744 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9745 (message_enable_multibyte): Remove decl.
9746 (free_misc, interval_free_list, float_block, float_block_index):
9747 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9748 (cons_free_list, last_marked_index):
9750 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9751 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9752 (mark_backtrace): Define only if BYTE_MARK_STACK.
9753 * xdisp.c (message_enable_multibyte): Now static.
9755 Declare Lisp_Object Q* variables to be 'static' if not exported.
9756 This makes it easier for human readers (and static analyzers)
9757 to see whether these variables are used from other modules.
9758 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9759 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9760 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9761 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9762 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9763 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9764 * xmenu.c, xselect.c:
9765 Declare Q* vars static if they are not used in other modules.
9766 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9767 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9768 Remove decls of unexported vars.
9769 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9771 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9773 Make Emacs functions such as Fatom 'static' by default.
9774 This makes it easier for human readers (and static analyzers)
9775 to see whether these functions can be called from other modules.
9776 DEFUN now defines a static function. To make the function external
9777 so that it can be used in other C modules, use the new macro DEFUE.
9778 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9779 (Finit_image_library):
9780 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9781 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9782 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9783 Remove decls, since these functions are now static.
9784 (Funintern, Fget_internal_run_time): New decls, since these functions
9785 were already external.
9787 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9788 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9789 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9790 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9791 * keyboard.c, keymap.c, lread.c:
9792 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9793 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9794 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9795 Mark functions with DEFUE instead of DEFUN,
9796 if they are used in other modules.
9797 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9798 decls for now-static functions.
9799 * buffer.h (Fdelete_overlay): Remove decl.
9800 * callproc.c (Fgetenv_internal): Mark as internal.
9801 * composite.c (Fremove_list_of_text_properties): Remove decl.
9802 (Fcomposition_get_gstring): New forward static decl.
9803 * composite.h (Fcomposite_get_gstring): Remove decl.
9804 * dired.c (Ffile_attributes): New forward static decl.
9805 * doc.c (Fdocumntation_property): New forward static decl.
9806 * eval.c (Ffetch_bytecode): New forward static decl.
9807 (Funintern): Remove extern decl; now in .h file where it belongs.
9808 * fileio.c (Fmake_symbolic_link): New forward static decl.
9809 * image.c (Finit_image_library): New forward static decl.
9810 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9811 * intervals.h (Fprevious_property_change):
9812 (Fremove_list_of_text_properties): Remove decls.
9813 * keyboard.c (Fthis_command_keys): Remove decl.
9814 (Fcommand_execute): New forward static decl.
9815 * keymap.c (Flookup_key): New forward static decl.
9816 (Fcopy_keymap): Now static.
9817 * keymap.h (Flookup_key): Remove decl.
9818 * process.c (Fget_process): New forward static decl.
9819 (Fprocess_datagram_address): Mark as internal.
9820 * syntax.c (Fsyntax_table_p): New forward static decl.
9821 (skip_chars): Remove duplicate decl.
9822 * textprop.c (Fprevious_property_change): New forward static decl.
9823 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9825 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9826 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9828 * editfns.c (Fformat): Remove unreachable code.
9830 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9832 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9835 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9837 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9838 when at ZV. (Bug#8487)
9840 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9842 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9844 * keyboard.c (parse_tool_bar_item): Likewise.
9845 * sound.c (sound_cleanup, alsa_close): Likewise.
9846 * termcap.c (tgetent): Likewise.
9847 * xfns.c (x_default_font_parameter): Likewise.
9848 * xsettings.c (read_and_apply_settings): Likewise.
9850 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9851 (overrun_check_free): Protoize.
9853 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9855 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9856 since callers should never pass a negative size.
9857 Change the signature to match that of plain 'read' and 'write'; see
9858 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9859 * lisp.h: Update prototypes of emacs_write and emacs_read.
9861 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9863 * xdisp.c (redisplay_window): Don't try to determine the character
9864 position of the scroll margin if the window start point w->startp
9865 is outside the buffer's accessible region. (Bug#8468)
9867 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9869 Fix write-region and its subroutines for buffers > 2GB.
9870 * fileio.c (a_write, e_write): Modify declaration of arguments and
9871 local variables to support buffers larger than 2GB.
9872 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9874 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9875 argument, local variables, and return value.
9877 * lisp.h: Update prototypes of emacs_write and emacs_read.
9879 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9881 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9883 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9885 Fix more problems found by GCC 4.6.0's static checks.
9887 * xdisp.c (vmessage): Use a better test for character truncation.
9889 * charset.c (load_charset_map): <, not <=, for optimization,
9890 and to avoid potential problems with integer overflow.
9891 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9892 * casetab.c (set_identity, shuffle): Likewise.
9893 * editfns.c (Fformat): Likewise.
9894 * syntax.c (skip_chars): Likewise.
9896 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9897 This also lets GCC 4.6.0 generate slightly better loop code.
9899 * callint.c (Fcall_interactively): <, not <=, for optimization.
9900 (Fcall_interactively): Count the number of arguments produced,
9901 not the number of arguments given. This is simpler and lets GCC
9902 4.6.0 generate slightly better code.
9904 * ftfont.c: Distingish more carefully between FcChar8 and char.
9905 The previous code passed unsigned char * to a functions like
9906 strlen and xstrcasecmp that expect char *, which does not
9907 conform to the C standard.
9908 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9909 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9910 char * when the C standard requires it.
9912 * keyboard.c (read_char): Remove unused var.
9914 * eval.c: Port to Windows vsnprintf (Bug#8435).
9916 (SIZE_MAX): Define if the headers do not.
9917 (verror): Do not give up if vsnprintf returns a negative count.
9918 Instead, grow the buffer. This ports to Windows vsnprintf, which
9919 does not conform to C99. Problem reported by Eli Zaretskii.
9920 Also, simplify the allocation scheme, by avoiding the need for
9921 calling realloc, and removing the ALLOCATED variable.
9923 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9925 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9926 But keep the doprint source code for now, as we might revamp it
9927 and use it again (Bug#8435).
9928 * lisp.h (doprnt): Remove.
9929 * Makefile.in (base_obj): Remove doprnt.o.
9930 * deps.mk (doprnt.o): Remove.
9932 error: Print 32- and 64-bit integers portably (Bug#8435).
9933 Without this change, on typical 64-bit hosts error ("...%d...", N)
9934 was used to print both 32- and 64-bit integers N, which relied on
9936 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9937 * lisp.h (error, verror): Mark as printf-like functions.
9938 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9939 Report overflow in size calculations when allocating printf buffer.
9940 Do not truncate output string at its first null byte.
9941 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9942 Truncate the output at a character boundary, since vsnprintf does not
9944 * charset.c (check_iso_charset_parameter): Convert internal
9945 character to string before calling 'error', since %c now has the
9947 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9948 overflow when computing char to be passed to 'error'. Do not
9949 pass Lisp_Object to 'error'; pass the integer instead.
9950 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9951 formatted with plain %d.
9953 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9955 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9957 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9959 * xterm.c (x_catch_errors): Remove duplicate declaration.
9961 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9963 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9965 2011-04-10 Jim Meyering <meyering@redhat.com>
9967 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9968 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9969 return ssize_t not "int", and use size_t as the buffer length.
9970 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9971 * gnutls.h: Update declarations.
9972 * process.c (read_process_output): Use ssize_t, to match.
9973 (send_process): Likewise.
9975 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9977 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9979 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9981 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9982 Use unsigned char, to match FcChar8 type definition.
9984 * xterm.c (handle_one_xevent):
9985 * xmenu.c (create_and_show_popup_menu):
9986 * xselect.c (x_decline_selection_request)
9987 (x_reply_selection_request): Avoid type-punned deref of X events.
9989 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9991 Fix some uses of `int' instead of EMACS_INT.
9992 * search.c (string_match_1, fast_string_match)
9993 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9994 (scan_buffer, find_next_newline_no_quit)
9995 (find_before_next_newline, search_command, Freplace_match)
9996 (Fmatch_data): Make some `int' variables be EMACS_INT.
9998 * xdisp.c (display_count_lines): 3rd argument and return value now
9999 EMACS_INT. All callers changed.
10000 (pint2hrstr): Last argument is now EMACS_INT.
10002 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10003 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10004 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10005 (decode_coding_utf_16, decode_coding_emacs_mule)
10006 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10007 (decode_coding_ccl, decode_coding_charset)
10008 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10009 (decode_coding_iso_2022, decode_coding_emacs_mule)
10010 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10011 <char_offset, last_offset>: Declare EMACS_INT.
10012 (encode_coding_utf_8, encode_coding_utf_16)
10013 (encode_coding_emacs_mule, encode_invocation_designation)
10014 (encode_designation_at_bol, encode_coding_iso_2022)
10015 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10016 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10018 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10019 (encode_invocation_designation): Last argument P_NCHARS is now
10021 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10022 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10024 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10027 * ccl.c (Fccl_execute_on_string): Declare some variables
10030 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10032 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10034 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10036 * process.c (Fformat_network_address): Doc fix.
10038 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10040 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10042 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10044 * keyboard.c (read_char): Call Lisp function help-form-show,
10045 instead of using internal_with_output_to_temp_buffer.
10046 (Qhelp_form_show): New var.
10047 (syms_of_keyboard): Use DEFSYM macro.
10049 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10051 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10053 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10055 * process.c (Flist_processes): Remove to Lisp.
10056 (list_processes_1): Delete.
10058 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10060 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10062 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10064 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10066 Fix more problems found by GCC 4.6.0's static checks.
10068 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10070 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10072 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10074 * xdisp.c (vmessage): Mark as a printf-like function.
10076 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10078 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10080 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10081 printf-like functions.
10082 (tiff_load): Add casts to remove these marks before passing them
10083 to system-supplied API.
10085 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10087 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10088 This avoids several warnings with gcc -Wstrict-overflow.
10089 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10090 directly, rather than having caller test rule sign. This avoids
10091 some unnecessary tests.
10092 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10093 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10094 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10096 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10097 (xfont_open): Avoid unnecessary tests.
10099 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10101 * composite.h, composite.c (composition_gstring_put_cache):
10102 Use EMACS_INT, not int, for length.
10104 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10105 breaking out part of COMPOSITION_DECODE_RULE.
10106 (COMPOSITION_DECODE_RULE): Use it.
10107 * composite.c (get_composition_id): Remove unused local vars,
10108 by using the new macro.
10110 * textprop.c (set_text_properties_1): Change while to do-while,
10111 since the condition is always true at first.
10113 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10114 (interval_deletion_adjustment): Return unsigned value.
10117 * process.c (list_processes_1, create_pty, read_process_output):
10118 (exec_sentinel): Remove vars that were set but not used.
10119 (create_pty): Remove unnecessary "volatile"s.
10120 (Fnetwork_interface_info): Avoid possibility of int overflow.
10121 (read_process_output): Do adaptive read buffering even if carryover.
10122 (read_process_output): Simplify nbytes computation if buffered.
10124 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10126 * syntax.c (scan_words): Remove var that was set but not used.
10127 (update_syntax_table): Use unsigned instead of int.
10129 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10130 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10131 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10133 * print.c (print_error_message): Avoid int overflow.
10135 * font.c (font_list_entities): Redo for clarity,
10136 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10138 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10139 (font_score): Avoid potential overflow in diff calculation.
10141 * fns.c (substring_both): Remove var that is set but not used.
10142 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10144 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10146 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10147 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10148 can always succeed if overflow has undefined behavior.
10150 * search.c (boyer_moore, wordify): Remove vars set but not used.
10151 (wordify): Omit three unnecessary tests.
10153 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10154 All callers changed. This avoids the need for an unused var.
10156 * casefiddle.c (casify_region): Remove var that is set but not used.
10158 * dired.c (file_name_completion): Remove var that is set but not used.
10160 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10162 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10163 (Finsert_file_contents): Remove unnecessary code checking fd.
10165 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10166 Check for integer overflow on size calculations.
10168 * buffer.c (Fprevious_overlay_change): Remove var that is set
10171 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10172 Remove vars that are set but not used.
10173 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10174 (timer_check_2): Mark vars as initialized.
10176 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10178 * image.c (lookup_image): Remove var that is set but not used.
10179 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10181 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10182 that are set but not used.
10184 * xfns.c (make_invisible_cursor): Don't return garbage
10185 if XCreateBitmapFromData fails (Bug#8410).
10187 * xselect.c (x_get_local_selection, x_handle_property_notify):
10188 Remove vars that are set but not used.
10190 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10191 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10193 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10194 Remove var that is set but not used.
10195 (scroll_bar_windows_size): Now size_t, not int.
10196 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10197 Check for overflow.
10199 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10200 (map_tty_color) [!defined MSDOS]: Likewise.
10202 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10204 * coding.c: Remove vars that are set but not used.
10205 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10206 All callers changed.
10207 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10208 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10209 (decode_coding_charset): Remove vars that are set but not used.
10211 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10212 that is set but not used.
10214 * print.c (print_object): Remove var that is set but not used.
10216 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10217 The gnulib version avoids calling malloc in the usual case,
10218 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10219 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10220 * filelock.c (current_lock_owner): Likewise.
10221 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10222 * sysdep.c: Include allocator.h, careadlinkat.h.
10223 (emacs_no_realloc_allocator): New static constant.
10224 (emacs_readlink): New function.
10225 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10226 ../lib/careadlinkat.h.
10228 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10230 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10231 first non-nil return value).
10233 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10235 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10236 if not defined (Bug#8403).
10238 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10240 * xdisp.c (display_count_lines): Remove parameter `start',
10241 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10242 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10243 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10244 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10245 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10246 and thereabouts. All callers changed.
10247 (get_per_char_metric): Remove parameter `f', unused since
10248 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10250 2011-04-02 Jim Meyering <meyering@redhat.com>
10252 do not dereference NULL upon failed strdup
10253 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10254 (ns_get_family): Likewise.
10256 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10258 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10260 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10262 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10265 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10267 Add lexical binding.
10269 * window.c (Ftemp_output_buffer_show): New fun.
10270 (Fsave_window_excursion):
10271 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10273 * lread.c (lisp_file_lexically_bound_p): New function.
10274 (Fload): Bind Qlexical_binding.
10275 (readevalloop): Remove `evalfun' arg.
10276 Bind Qinternal_interpreter_environment.
10277 (Feval_buffer): Bind Qlexical_binding.
10278 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10280 (syms_of_lread): Declare `lexical-binding'.
10282 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10284 * keyboard.c (eval_dyn): New fun.
10285 (menu_item_eval_property): Use it.
10287 * image.c (parse_image_spec): Use Ffunctionp.
10289 * fns.c (concat, mapcar1): Accept byte-code-functions.
10291 * eval.c (Fsetq): Handle lexical vars.
10292 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10293 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10294 (FletX, Flet): Obey lexical binding.
10295 (Fcommandp): Handle closures.
10296 (Feval): New `lexical' arg.
10297 (eval_sub): New function extracted from Feval. Use it almost
10298 everywhere where Feval was used. Look up vars in lexical env.
10300 (Ffunctionp): Move from subr.el.
10301 (Ffuncall): Handle closures.
10302 (apply_lambda): Remove `eval_flags'.
10303 (funcall_lambda): Handle closures and new byte-code-functions.
10304 (Fspecial_variable_p): New function.
10305 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10306 but without exporting it to Lisp.
10308 * doc.c (Fdocumentation, store_function_docstring):
10309 * data.c (Finteractive_form): Handle closures.
10311 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10314 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10316 (exec_byte_code): New function extracted from Fbyte_code to handle new
10317 calling convention for byte-code-functions. Add new byte-codes.
10319 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10321 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10323 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10325 * xdisp.c (redisplay_internal): Fix prototype.
10327 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10329 * xdisp.c (SCROLL_LIMIT): New macro.
10330 (try_scrolling): Use it when setting scroll_limit.
10331 Limit scrolling to 100 screen lines.
10332 (redisplay_window): Even when falling back on "recentering",
10333 position point in the window according to scroll-conservatively,
10334 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10336 (try_scrolling): When point is above the window, allow searching
10337 as far as scroll_max, or one screenful, to compute vertical
10338 distance from PT to the scroll margin position. This prevents
10339 try_scrolling from unnecessarily failing when
10340 scroll-conservatively is set to a value slightly larger than the
10341 window height. Clean up the case of PT below the margin at bottom
10342 of window: scroll_max can no longer be INT_MAX. When aggressive
10343 scrolling is in use, don't let point enter the opposite scroll
10344 margin as result of the scroll.
10345 (syms_of_xdisp) <scroll-conservatively>: Document the
10346 threshold of 100 lines for never-recentering scrolling.
10348 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10350 * dispextern.h (move_it_by_lines):
10351 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10352 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10353 (message_log_check_duplicate): Remove parameters `prev_bol' and
10354 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10355 (redisplay_internal): Remove parameter `preserve_echo_area',
10356 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10358 * indent.c (Fvertical_motion):
10359 * window.c (window_scroll_pixel_based, Frecenter):
10360 Don't pass `need_y_p' to `move_it_by_lines'.
10362 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10364 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10365 steal a few bits to be more compact.
10366 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10367 Remove unneeded casts.
10369 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10371 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10373 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10374 binding" message (bug#7967).
10376 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10378 Fix more problems found by GCC 4.6.0's static checks.
10380 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10381 Remove unused local var.
10383 * editfns.c (Fmessage_box): Remove unused local var.
10385 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10386 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10387 Omit unused local vars.
10388 * window.c (shrink_windows): Omit unused local var.
10389 * menu.c (digest_single_submenu): Omit unused local var.
10390 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10391 Omit unused local var.
10393 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10394 Don't assume string length fits in int.
10395 (keyremap_step, read_key_sequence): Use size_t for sizes.
10396 (read_key_sequence): Don't check last_real_key_start redundantly.
10398 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10399 instead of alloca (Bug#8344).
10401 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10402 (Fbacktrace_frame): Don't assume nframes fits in int.
10404 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10406 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10409 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10411 * cm.c (calccost): Turn while-do into do-while, for clarity.
10413 * keyboard.c (syms_of_keyboard): Use the same style as later
10414 in this function when indexing through an array. This also
10415 works around GCC bug 48267.
10417 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10419 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10421 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10422 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10424 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10425 This avoids undefined behavior on integer overflow, and is a bit
10426 more convenient anyway since it is compared to a size_t variable.
10428 Variadic C functions now count arguments with size_t, not int.
10429 This avoids an unnecessary limitation on 64-bit machines, which
10430 caused (substring ...) to crash on large vectors (Bug#8344).
10431 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10432 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10433 All variadic functions and their callers changed accordingly.
10434 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10435 * data.c (arith_driver, float_arith_driver): Likewise.
10436 * editfns.c (general_insert_function): Likewise.
10437 * eval.c (struct backtrace.nargs, interactive_p)
10438 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10439 (funcall_lambda, mark_backtrace): Likewise.
10440 * fns.c (concat): Likewise.
10441 * frame.c (x_set_frame_parameters): Likewise.
10442 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10443 0 if not found, not -1. All callers changed.
10445 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10446 (stack_copy_size): Now size_t, not int.
10447 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10449 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10451 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10452 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10453 All callers changed.
10455 * lisp.h (multibyte_char_to_unibyte):
10456 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10457 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10458 * character.h (CHAR_TO_BYTE8):
10459 * cmds.c (internal_self_insert):
10460 * editfns.c (general_insert_function):
10461 * keymap.c (push_key_description):
10462 * search.c (Freplace_match):
10463 * xdisp.c (message_dolog, set_message_1): All callers changed.
10465 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10467 * keyboard.c (safe_run_hook_funcall): New function.
10468 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10469 don't set the hook to nil, but remove the offending function instead.
10470 (Qcommand_hook_internal): Remove, unused.
10471 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10472 Vcommand_hook_internal.
10474 * eval.c (enum run_hooks_condition): Remove.
10475 (funcall_nil, funcall_not): New functions.
10476 (run_hook_with_args): Call each function through a `funcall' argument.
10477 Remove `cond' argument, now redundant.
10478 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10479 (Frun_hook_with_args_until_failure): Adjust accordingly.
10480 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10482 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10484 * dispextern.h (string_buffer_position): Remove declaration.
10486 * print.c (strout): Remove parameter `multibyte', unused since
10487 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10489 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10490 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10491 All callers changed.
10493 * w32.c (_wsa_errlist): Use braces for struct initializers.
10495 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10496 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10497 All callers changed.
10498 (string_buffer_position): Likewise. Also, make static (it's never
10499 used outside xdisp.c).
10500 (cursor_row_p): Remove parameter `w', unused since
10501 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10502 (decode_mode_spec): Remove parameter `precision', introduced during
10503 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10504 All callers changed.
10506 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10508 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10510 2011-03-27 Anders Lindgren <andlind@gmail.com>
10512 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10513 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10514 (ns_update_auto_hide_menu_bar): New functions.
10515 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10516 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10517 ns_constrain_all_frames.
10518 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10519 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10521 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10523 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10525 2011-03-27 Glenn Morris <rgm@gnu.org>
10527 * syssignal.h: Replace RETSIGTYPE with void.
10528 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10529 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10530 Replace SIGTYPE with void everywhere.
10531 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10532 * s/template.h (SIGTYPE): Remove commented out definition.
10534 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10536 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10537 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10539 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10541 * w32.c (read_unc_volume): Use parameter `henum', instead of
10542 global variable `wget_enum_handle'.
10544 * keymap.c (describe_vector): Remove parameters `indices' and
10545 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10546 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10548 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10550 * keyboard.c (timer_check): Remove parameter `do_it_now',
10551 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10552 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10553 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10555 * keyboard.c (read_char):
10556 * w32menu.c (w32_menu_display_help):
10557 * xmenu.c (show_help_event, menu_help_callback):
10558 Adjust calls to `show_help_echo'.
10560 * gtkutil.c (xg_maybe_add_timer):
10561 * keyboard.c (readable_events):
10562 * process.c (wait_reading_process_output):
10563 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10565 * insdel.c (adjust_markers_gap_motion):
10566 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10567 (gap_left, gap_right): Don't call it.
10569 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10571 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10572 incurred during fontification.
10574 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10576 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10577 (DEFVAR_PER_BUFFER): Don't pass it.
10579 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10580 (scrolling_window): Don't pass it.
10582 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10584 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10586 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10588 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10589 of variables specific to SELinux and computation of `encoded_absname'.
10591 * image.c (XPutPixel): Remove unused variable `height'.
10593 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10595 * unexw32.c (get_section_info): Remove unused variable `section'.
10597 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10598 (system_process_attributes): Remove unused variable `sess'.
10599 (sys_read): Remove unused variable `err'.
10601 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10602 (w32_wnd_proc): Remove unused variable `isdead'.
10603 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10604 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10605 (x_create_tip_frame): Remove unused variable `tem'.
10607 * w32inevt.c (w32_console_read_socket):
10608 Remove unused variable `no_events'.
10610 * w32term.c (x_draw_composite_glyph_string_foreground):
10611 Remove unused variable `width'.
10613 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10615 * w32term.c (x_set_glyph_string_clipping):
10616 Don't pass uninitialized region to CombineRgn.
10618 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10620 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10621 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10622 (Fx_close_connection): Remove unused variable `i'.
10624 * w32font.c (w32font_draw): Return number of glyphs.
10625 (w32font_open_internal): Remove unused variable `i'.
10626 (w32font_driver): Add missing initializer.
10628 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10629 (fill_in_menu): Remove unused variable `items_added'.
10631 * w32term.c (last_mouse_press_frame): Remove static global variable.
10632 (w32_clip_to_row): Remove unused variable `f'.
10633 (x_delete_terminal): Remove unused variable `i'.
10635 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10636 (NOTHING): Remove unused static global variable.
10637 (uniscribe_check_otf): Remove unused variable `table'.
10638 (uniscribe_font_driver): Add missing initializers.
10640 2011-03-23 Julien Danjou <julien@danjou.info>
10642 * term.c (Fsuspend_tty, Fresume_tty):
10643 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10644 * window.c (temp_output_buffer_show):
10645 * insdel.c (signal_before_change):
10646 * frame.c (Fhandle_switch_frame):
10647 * fileio.c (Fdo_auto_save):
10648 * emacs.c (Fkill_emacs):
10649 * editfns.c (save_excursion_restore):
10650 * cmds.c (internal_self_insert):
10651 * callint.c (Fcall_interactively):
10652 * buffer.c (Fkill_all_local_variables):
10653 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10655 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10656 unconditionally since it does the check itself.
10658 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10660 Fix more problems found by GCC 4.5.2's static checks.
10662 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10663 the first time through the loop, since we know p0 < p1 then.
10664 This also avoids a gcc -Wstrict-overflow warning.
10666 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10667 leading to a memory leak, possible in functions like
10668 load_charset_map_from_file that can allocate an unbounded number
10669 of objects (Bug#8318).
10671 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10672 that could (at least in theory) be that large.
10674 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10675 This is less likely to overflow, and avoids undefined behavior if
10676 overflow does occur. All callers changed. Use strtoul to scan
10677 for the unsigned long integer.
10678 (pint2hrstr): Simplify and tune code slightly.
10679 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10681 * scroll.c (do_scrolling): Work around GCC bug 48228.
10682 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10684 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10685 This also avoids a warning with gcc -Wstrict-overflow.
10686 (validate_x_resource_name): Simplify count usage.
10687 This also avoids a warning with gcc -Wstrict-overflow.
10689 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10692 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10694 * process.c (Fmake_network_process): Use socklen_t, not int,
10695 where POSIX says socklen_t is required in portable programs.
10696 This fixes a porting bug on hosts like 64-bit HP-UX, where
10697 socklen_t is wider than int (Bug#8277).
10698 (Fmake_network_process, server_accept_connection):
10699 (wait_reading_process_output, read_process_output):
10702 * process.c: Rename or move locals to avoid shadowing.
10703 (list_processes_1, Fmake_network_process):
10704 (read_process_output_error_handler, exec_sentinel_error_handler):
10705 Rename or move locals.
10706 (Fmake_network_process): Define label "retry_connect" only if needed.
10707 (Fnetwork_interface_info): Fix pointer signedness.
10708 (process_send_signal): Add cast to avoid pointer signedness problem.
10709 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10710 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10712 Make tparam.h and terminfo.c consistent.
10713 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10714 Include tparam.h instead, since it declares them.
10715 * cm.h (PC): Remove extern decl; tparam.h now does this.
10716 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10717 * terminfo.c: Include tparam.h, to check interfaces.
10718 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10719 (tparam): Adjust signature to match interface in tparam.h;
10720 this removes some undefined behavior. Check that outstring and len
10721 are zero, which they always are with Emacs.
10722 * tparam.h (PC, BC, UP): New extern decls.
10724 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10725 (xftfont_open): Rename locals to avoid shadowing.
10727 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10728 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10729 (OTF_TAG_SYM): Omit macro if not needed.
10730 (ftfont_list): Remove unused local.
10731 (get_adstyle_property, ftfont_pattern_entity):
10732 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10733 Rename locals to avoid shadowing.
10735 * xfont.c (xfont_list_family): Mark var as initialized.
10737 * xml.c (make_dom): Now static.
10739 * composite.c (composition_compute_stop_pos): Rename local to
10741 (composition_reseat_it): Remove unused locals.
10742 (find_automatic_composition, composition_adjust_point): Likewise.
10743 (composition_update_it): Mark var as initialized.
10744 (find_automatic_composition): Mark vars as initialized,
10745 with a FIXME (Bug#8290).
10747 character.h: Rename locals to avoid shadowing.
10748 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10749 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10750 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10751 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10752 to avoid shadowing.
10754 * textprop.c (property_change_between_p): Remove; unused.
10756 * intervals.c (interval_start_pos): Now static.
10758 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10760 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10761 Rename locals to avoid shadowing.
10763 * sound.c (wav_play, au_play, Fplay_sound_internal):
10764 Fix pointer signedness.
10765 (alsa_choose_format): Remove unused local var.
10766 (wav_play): Initialize a variable to 0, to prevent undefined
10767 behavior (Bug#8278).
10769 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10771 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10773 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10774 clobbering (Bug#8298).
10775 * sysdep.c (sys_subshell): Likewise.
10776 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10778 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10779 This should get cleaned up, so that child_setup has the
10780 same signature on all platforms.
10782 * callproc.c (call_process_cleanup): Now static.
10783 (relocate_fd): Rename locals to avoid shadowing.
10785 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10787 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10788 not to be necessary, and produces flickering.
10790 2011-03-20 Glenn Morris <rgm@gnu.org>
10792 * config.in: Remove file.
10794 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10796 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10797 are now in src/globals.h.
10798 (syms_of_minibuf): Remove spurious & from previous change.
10800 2011-03-20 Leo Liu <sdl.web@gmail.com>
10802 * minibuf.c (completing-read-function): New variable.
10803 (completing-read-default): Rename from completing-read.
10804 (completing-read): Call completing-read-function.
10806 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10808 * xfaces.c (Fx_load_color_file):
10809 Read color file from absolute filename (bug#8250).
10811 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10813 * makefile.w32-in: Update dependencies.
10815 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10817 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10819 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10821 Fix more problems found by GCC 4.5.2's static checks.
10823 * process.c (make_serial_process_unwind, send_process_trap):
10824 (sigchld_handler): Now static.
10826 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10827 That way, the code declares only the vars that it needs.
10828 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10829 * s/cygwin.h (PTY_ITERATION): Likewise.
10830 * s/darwin.h (PTY_ITERATION): Likewise.
10831 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10833 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10834 * process.c (allocate_pty): Don't declare stb unless it's needed.
10836 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10837 (CONSTANTLIM): Remove; unused.
10838 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10839 Define only if needed.
10841 * unexelf.c (unexec): Name an expression,
10842 to avoid gcc -Wbad-function-cast warning.
10843 Use a different way to cause a compilation error if anyone uses
10844 n rather than nn, a way that does not involve shadowing.
10845 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10847 * deps.mk (unexalpha.o): Remove; unused.
10849 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10850 * unexec.h: New file.
10851 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10852 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10853 Depend on unexec.h.
10854 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10855 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10856 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10857 Change as necessary to match prototype in unexec.h.
10859 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10861 (back_comment, skip_chars): Mark vars as initialized.
10863 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10864 Rename locals to avoid shadowing.
10866 * lread.c (read1): Rewrite so as not to use empty "else".
10867 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10869 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10871 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10872 warning when compiling print.c.
10874 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10875 instead of using an uninitialized var.
10876 (font_sort_entities): Mark var as initialized.
10878 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10880 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10881 pointers to constants.
10882 (font_parse_fcname): Remove unused vars.
10883 (font_delete_unmatched): Now static.
10884 (font_get_spec): Remove; unused.
10885 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10886 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10887 Rename or move locals to avoid shadowing.
10889 * fns.c (require_nesting_list, require_unwind): Now static.
10890 (Ffillarray): Rename locals to avoid shadowing.
10892 * floatfns.c (domain_error2): Define only if needed.
10893 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10895 * alloc.c (mark_backtrace): Move decl from here ...
10896 * lisp.h: ... to here, so that it can be checked.
10898 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10899 (Fdefvar): Rewrite so as not to use empty "else".
10900 (lisp_indirect_variable): Name an expression,
10901 to avoid gcc -Wbad-function-cast warning.
10902 (Fdefvar): Rename locals to avoid shadowing.
10904 * callint.c (quotify_arg, quotify_args): Now static.
10905 (Fcall_interactively): Rename locals to avoid shadowing.
10906 Use const pointer when appropriate.
10908 * lisp.h (get_system_name, get_operating_system_release):
10909 Move decls here, to check interfaces.
10910 * process.c (get_operating_system_release): Move decl to lisp.h.
10911 * xrdb.c (get_system_name): Likewise.
10912 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10913 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10914 some of which prompt warnings from gcc -Wbad-function-cast.
10915 (Fformat_time_string, Fencode_time, Finsert_char):
10916 (Ftranslate_region_internal, Fformat):
10917 Rename or remove local vars to avoid shadowing.
10918 (Ftranslate_region_internal): Mark var as initialized.
10920 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10923 * lisp.h (eassert): Check that the argument compiles, even if
10924 ENABLE_CHECKING is not defined.
10926 * data.c (Findirect_variable): Name an expression, to avoid
10927 gcc -Wbad-function-cast warning.
10928 (default_value, arithcompare, arith_driver, arith_error): Now static.
10929 (store_symval_forwarding): Rename local to avoid shadowing.
10930 (Fmake_variable_buffer_local, Fmake_local_variable):
10931 Mark variables as initialized.
10932 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10934 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10935 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10936 Rename locals to avoid shadowing.
10937 (mark_stack): Move local variables into the #ifdef region where
10939 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10940 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10942 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10943 (GC_STRING_CHARS): Remove; not used.
10944 (Fmemory_limit): Cast sbrk's returned value to char *.
10946 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10947 avoids undefined behavior in theory.
10949 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10951 Use functions, not macros, for up- and down-casing (Bug#8254).
10952 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10953 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10954 to use the following functions instead of these macros.
10955 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10956 EMACS_INT, since callers assume the returned value fits in int.
10957 (upcase1): Likewise, for UPCASE_TABLE.
10958 (uppercasep, lowercasep, upcase): New static inline functions.
10959 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10960 the race-condition problem in the old DOWNCASE.
10962 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10963 Rename locals to avoid shadowing.
10964 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10965 (regex_compile, re_search_2, re_match_2_internal):
10966 Remove unused local vars.
10967 (FREE_VAR): Rewrite so as not to use empty "else",
10968 which gcc can warn about.
10969 (regex_compile, re_match_2_internal): Mark locals as initialized.
10970 (RETALLOC_IF): Define only if needed.
10971 (WORDCHAR_P): Likewise. This one is never needed, but is used
10972 only in a comment talking about a compiler bug, so put inside
10973 the #if 0 of that comment.
10974 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10975 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10978 * search.c (boyer_moore): Rename locals to avoid shadowing.
10979 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10980 (PREV_CHAR_BOUNDARY): Likewise.
10982 * search.c (simple_search): Remove unused var.
10984 * dired.c (compile_pattern): Move decl from here ...
10985 * lisp.h: ... to here, so that it can be checked.
10986 (struct re_registers): New forward decl.
10988 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10990 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10992 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10993 Rename locals to avoid shadowing.
10994 (Fvertical_motion): Mark locals as initialized.
10996 * casefiddle.c (casify_object, casify_region): Now static.
10997 (casify_region): Mark local as initialized.
10999 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11001 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11002 New macros, so that the caller can use some names other than
11003 gcpro1, gcpro2, etc.
11004 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11006 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11007 argument, for consistency with GCPRO2_VAR, etc: it is now the
11008 prefix of the variable, not the variable itself. All uses
11010 * dired.c (directory_files_internal, file_name_completion):
11011 Rename locals to avoid shadowing.
11013 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11014 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11015 dired.c's scmp function, had undefined behavior.
11016 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11018 * buffer.h: ... to here, because these macros use current_buffer,
11019 and the new implementation with inline functions needs to have
11020 current_buffer in scope now, rather than later when the macros
11022 (downcase, upcase1): New static inline functions.
11023 (DOWNCASE, UPCASE1): Reimplement using these functions.
11024 This avoids undefined behavior in expressions like
11025 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11026 from race conditions in accessing the global variables
11027 case_temp1 and case_temp2.
11028 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11029 * lisp.h (case_temp1, case_temp2): Remove their decls.
11030 * character.h (ASCII_CHAR_P): Move from here ...
11031 * lisp.h: ... to here, so that the inline functions mentioned
11032 above can use them.
11034 * dired.c (directory_files_internal_unwind): Now static.
11036 * fileio.c (file_name_as_directory, directory_file_name):
11037 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11039 (file_name_as_directory): Use const pointers when appropriate.
11040 (Fexpand_file_name): Likewise. In particular, newdir might
11041 point at constant storage, so make it a const pointer.
11042 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11043 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11045 (Fset_file_times, Finsert_file_contents, auto_save_error):
11046 Rename locals to avoid shadowing.
11048 * minibuf.c (choose_minibuf_frame_1): Now static.
11049 (Ftry_completion, Fall_completions): Rename or remove locals
11050 to avoid shadowing.
11052 * marker.c (bytepos_to_charpos): Remove; unused.
11054 * lisp.h (verify_bytepos, count_markers): New decls,
11055 so that gcc does not warn that these functions aren't declared.
11057 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11058 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11059 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11060 (copy_text): Remove unused local var.
11062 * filelock.c (within_one_second): Now static.
11063 (lock_file_1): Rename local to avoid shadowing.
11065 * buffer.c (fix_overlays_before): Mark locals as initialized.
11066 (fix_start_end_in_overlays): Likewise. This function should be
11067 simplified by using pointers-to-pointers, but that's a different
11069 (switch_to_buffer_1): Now static.
11070 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11071 (report_overlay_modification): Rename locals to avoid shadowing.
11073 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11074 Fix pointer signedness issue.
11075 (sys_subshell): Mark local as volatile if checking for lint,
11076 to suppress a gcc -Wclobbered warning that does not seem to be right.
11077 (MAXPATHLEN): Define only if needed.
11079 * process.c (serial_open, serial_configure): Move decls from here ...
11080 * systty.h: ... to here, so that they can be checked.
11082 * fns.c (get_random, seed_random): Move extern decls from here ...
11083 * lisp.h: ... to here, so that they can be checked.
11085 * sysdep.c (reset_io): Now static.
11086 (wait_for_termination_signal): Remove; unused.
11088 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11089 (copy_keymap_item, append_key, push_text_char_description):
11091 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11092 (DENSE_TABLE_SIZE): Remove; unused.
11093 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11094 (describe_map_tree):
11095 Rename locals to avoid shadowing.
11097 * keyboard.c: Declare functions static if they are not used elsewhere.
11098 (echo_char, echo_dash, cmd_error, top_level_2):
11099 (poll_for_input, handle_async_input): Now static.
11100 (read_char, kbd_buffer_get_event, make_lispy_position):
11101 (make_lispy_event, make_lispy_movement, apply_modifiers):
11102 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11103 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11104 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11105 (read_key_sequence, read_char): Mark locals as initialized.
11106 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11108 * keyboard.h (make_ctrl_char): New decl.
11109 (mark_kboards): Move decl here ...
11110 * alloc.c (mark_kboards): ... from here.
11112 * lisp.h (force_auto_save_soon): New decl.
11114 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11115 (DEFINE_DUMMY_FUNCTION): New macro.
11116 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11118 (main): Add casts to avoid warnings
11119 if GCC considers string literals to be constants.
11121 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11123 * dbusbind.c: Pointer signedness fixes.
11124 (xd_signature, xd_append_arg, xd_initialize):
11125 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11126 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11127 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11128 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11130 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11131 if GCC considers string literals to be constants.
11132 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11134 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11136 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11137 (print_preprocess, print_object): New macro to fix last change.
11139 * print.c (print_preprocess): Don't forget font objects.
11141 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11143 * emacs.c (USAGE3): Doc fixes.
11145 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11147 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11150 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11152 * lisp.h (VWindow_system, Qfile_name_history):
11153 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11154 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11155 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11157 * w32select.c: Don't #include "keyboard.h".
11158 (run_protected): Add extern declaration for waiting_for_input.
11160 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11161 * w32console.c (detect_input_pending, read_input_pending)
11162 (encode_terminal_code):
11163 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11164 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11165 (w32_system_caret_y, Qfile_name_history):
11166 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11167 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11168 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11169 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11170 * w32proc.c (Qlocal, report_file_error):
11171 * w32term.c (Vwindow_system, updating_frame):
11172 * w32uniscribe.c (initialized, uniscribe_font_driver):
11173 Remove unneeded extern declarations.
11175 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11177 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11179 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11181 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11182 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11183 These macros can no longer be used for assignment.
11185 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11186 Assign struct members directly, instead of using BUF_BEGV etc.
11187 (record_buffer_markers, fetch_buffer_markers): New functions for
11188 recording and fetching special buffer markers.
11189 (set_buffer_internal_1, set_buffer_temp): Use them.
11191 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11193 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11195 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11196 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11198 * xdisp.c (hscroll_window_tree):
11199 (reconsider_clip_changes): Use PT instead of BUF_PT.
11201 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11203 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11204 $(EMACS_ROOT)/lib/intprops.h.
11206 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11208 Fix more problems found by GCC 4.5.2's static checks.
11210 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11211 to unsigned char * to avoid compiler diagnostic.
11212 (xg_free_frame_widgets): Make it clear that a local variable is
11213 needed only if USE_GTK_TOOLTIP.
11214 (gdk_window_get_screen): Make it clear that this macro is needed
11215 only if USE_GTK_TOOLTIP.
11216 (int_gtk_range_get_value): New function, which avoids a diagnostic
11217 from gcc -Wbad-function-cast.
11218 (xg_set_toolkit_scroll_bar_thumb): Use it.
11219 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11220 diagnostic from gcc -Wbad-function-cast.
11221 (get_utf8_string, xg_get_file_with_chooser):
11222 Rename locals to avoid shadowing.
11223 (create_dialog): Move locals to avoid shadowing.
11225 * xgselect.c (xg_select): Remove unused var.
11227 * image.c (four_corners_best): Mark locals as initialized.
11228 (gif_load): Initialize transparent_p to zero (Bug#8238).
11229 Mark another local as initialized.
11230 (my_png_error, my_error_exit): Mark with NO_RETURN.
11232 * image.c (clear_image_cache): Now static.
11233 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11234 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11235 (x_edge_detection): Remove unnecessary cast that
11236 gcc -Wbad-function-cast diagnoses.
11237 (gif_load): Fix pointer signedness.
11238 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11239 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11241 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11243 Improve quality of tests for time stamp overflow.
11244 For example, without this patch (encode-time 0 0 0 1 1
11245 1152921504606846976) returns the obviously-bogus value (-948597
11246 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11247 reports time overflow. See
11248 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11249 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11250 * editfns.c: Include limits.h and intprops.h.
11251 (TIME_T_MIN, TIME_T_MAX): New macros.
11252 (time_overflow): Move earlier, to before first use.
11253 (hi_time, lo_time): New functions, for an accurate test for
11254 out-of-range times.
11255 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11256 (Fget_internal_run_time): Don't assume time_t fits in int.
11257 (make_time): Use list2 instead of Fcons twice.
11258 (Fdecode_time): More accurate test for out-of-range times.
11259 (check_tm_member): New function.
11260 (Fencode_time): Use it, to test for out-of-range times.
11261 (lisp_time_argument): Don't rely on undefined left-shift and
11262 right-shift behavior when checking for time stamp overflow.
11264 * editfns.c (time_overflow): New function, refactoring common code.
11265 (Fformat_time_string, Fdecode_time, Fencode_time):
11266 (Fcurrent_time_string): Use it.
11268 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11269 * dired.c (make_time): Move to ...
11270 * editfns.c (make_time): ... here.
11271 * systime.h: Note the move.
11273 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11275 * fringe.c (update_window_fringes): Remove unused variables.
11277 * unexmacosx.c (copy_data_segment): Also copy __got section.
11280 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11282 * termcap.c [MSDOS]: Include "msdos.h".
11283 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11284 Constify `char *' arguments and their references according to
11285 prototypes in tparam.h.
11287 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11289 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11290 Adapt all references accordingly.
11292 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11294 2011-03-11 Tom Tromey <tromey@redhat.com>
11296 * buffer.c (syms_of_buffer): Remove obsolete comment.
11298 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11300 * termhooks.h (encode_terminal_code): Declare prototype.
11302 * msdos.c (encode_terminal_code): Don't declare prototype.
11304 * term.c (encode_terminal_code): Now external again, used by
11305 w32console.c and msdos.c.
11307 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11308 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11310 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11312 Fix some minor problems found by GCC 4.5.2's static checks.
11314 * fringe.c (update_window_fringes): Mark locals as initialized
11316 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11318 * alloc.c (mark_fringe_data): Move decl from here ...
11319 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11320 to check its interface.
11321 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11323 * fontset.c (free_realized_fontset): Now static.
11324 (Fset_fontset_font): Rename local to avoid shadowing.
11325 (fontset_font): Mark local as initialized.
11326 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11328 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11330 * xselect.c (x_disown_buffer_selections): Remove; not used.
11331 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11332 (x_own_selection, Fx_disown_selection_internal): Rename locals
11333 to avoid shadowing.
11334 (x_handle_dnd_message): Remove local to avoid shadowing.
11336 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11337 so that the caller can use some name other than gcpro1.
11338 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11339 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11340 (Fx_backspace_delete_keys_p):
11341 Use them to avoid shadowing, and rename vars to avoid shadowing.
11342 (x_decode_color, x_set_name, x_window): Now static.
11343 (Fx_create_frame): Add braces to silence GCC warning.
11344 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11345 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11346 Remove unused locals.
11347 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11348 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11349 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11352 * xterm.h (x_mouse_leave): New decl.
11354 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11355 Remove unused functions.
11356 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11357 (x_calc_absolute_position): Now static.
11358 (XTread_socket): Don't define label "out" unless it's used.
11359 Don't declare local "event" unless it's used.
11360 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11361 unless they are used.
11362 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11363 (x_fatal_error_signal): Remove; not used.
11364 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11365 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11366 (x_error_catcher, x_connection_closed, x_error_handler):
11367 (x_error_quitter, xembed_send_message, x_iconify_frame):
11368 (my_log_handler): Rename locals to avoid shadowing.
11369 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11370 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11372 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11373 Rename or move locals to avoid shadowing.
11374 (tty_defined_color, merge_face_heights): Now static.
11375 (free_realized_faces_for_fontset): Remove; not used.
11376 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11377 does not deduce is never used uninitialized.
11378 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11379 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11381 * terminal.c (store_terminal_param): Now static.
11383 * xmenu.c (menu_highlight_callback): Now static.
11384 (set_frame_menubar): Remove unused local.
11385 (xmenu_show): Rename parameter to avoid shadowing.
11386 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11387 since they might point to immutable storage.
11388 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11389 since it's unused otherwise.
11391 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11392 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11393 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11394 avoids a gcc -Wuninitialized diagnostic.
11395 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11396 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11397 does not deduce are never used uninitialized.
11399 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11401 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11402 * window.c (window_loop, size_window):
11403 (run_window_configuration_change_hook, enlarge_window): Likewise.
11405 * window.c (display_buffer): Now static.
11406 (size_window): Mark variables that gcc -Wuninitialized
11407 does not deduce are never used uninitialized.
11408 * window.h (check_all_windows): New decl, to forestall
11409 gcc -Wmissing-prototypes diagnostic.
11410 * dispextern.h (bidi_dump_cached_states): Likewise.
11412 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11414 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11415 Include <limits.h>.
11416 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11417 and to avoid gcc -Wuninitialized warning.
11418 (load_charset_map): Mark variables that gcc -Wuninitialized
11419 does not deduce are never used uninitialized.
11420 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11422 * coding.c (coding_set_source, coding_set_destination):
11423 Use "else { /* comment */ }" rather than "else /* comment */;"
11424 for clarity, and to avoid gcc -Wempty-body warning.
11425 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11426 a block, when the outer 'i' will do.
11427 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11428 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11429 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11430 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11431 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11432 Rename locals to avoid shadowing.
11433 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11434 * coding.c (emacs_mule_char, encode_invocation_designation):
11435 Now static, since they're not used elsewhere.
11436 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11437 (decode_coding_object, encode_coding_object, detect_coding_system):
11438 (decode_coding_emacs_mule): Mark variables that gcc
11439 -Wuninitialized does not deduce are never used uninitialized.
11440 (detect_coding_iso_2022): Initialize a local variable that might
11441 be used uninitialized. Leave a FIXME because it's not clear that
11442 this initialization is needed. (Bug#8211)
11443 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11444 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11445 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11446 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11447 Remove unused macros.
11449 * category.c (hash_get_category_set): Remove unused local var.
11450 (copy_category_table): Now static, since it's not used elsewhere.
11451 * character.c (string_count_byte8): Likewise.
11453 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11454 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11456 * chartab.c (copy_sub_char_table): Now static, since it's not used
11458 (sub_char_table_ref_and_range, char_table_ref_and_range):
11459 Rename locals to avoid shadowing.
11460 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11462 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11463 (BIDI_BOB): Remove unused macro.
11465 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11466 deduce are never used uninitialized.
11467 * term.c (encode_terminal_code): Likewise.
11469 * term.c (encode_terminal_code): Now static. Remove unused local.
11471 * tparam.h: New file.
11472 * term.c, tparam.h: Include it.
11473 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11474 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11475 Move these decls to tparam.h, and make them agree with what
11476 is actually in tparam.c. The previous trick of using incompatible
11477 decls in different modules does not conform to the C standard.
11478 All callers of tparam changed to use tparam's actual API.
11479 * tparam.c (tparam1, tparam, tgoto):
11480 Use const pointers where appropriate.
11482 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11483 * cm.h (struct cm): Likewise.
11484 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11485 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11486 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11487 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11488 (turn_on_face, init_tty): Likewise.
11489 * termchar.h (struct tty_display_info): Likewise.
11491 * term.c (term_mouse_position): Rename local to avoid shadowing.
11493 * alloc.c (mark_ttys): Move decl from here ...
11494 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11496 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11498 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11500 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11502 * search.c (compile_pattern_1): Remove argument regp, unused since
11503 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11504 (compile_pattern): Don't pass it.
11506 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11508 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11509 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11511 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11513 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11515 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11516 gdk_window_get_screen, gdk_window_get_geometry,
11517 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11518 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11519 (xg_get_pixbuf_from_pixmap): New function.
11520 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11521 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11522 Call xg_get_pixbuf_from_pixmap instead of
11523 gdk_pixbuf_get_from_drawable.
11524 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11525 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11526 (xg_check_special_colors): Use GtkStyleContext and its functions
11528 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11529 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11530 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11531 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11532 Call gtk_widget_get_preferred_size.
11533 (xg_frame_resized): gdk_window_get_geometry only takes 5
11535 (xg_win_to_widget, xg_event_is_for_menubar):
11536 Call gdk_x11_window_lookup_for_display.
11537 (xg_set_widget_bg): New function.
11538 (delete_cb): New function.
11539 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11540 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11541 (xg_set_background_color): Call xg_set_widget_bg.
11542 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11543 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11544 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11545 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11547 (update_frame_tool_bar): Call gtk_widget_hide.
11548 (xg_initialize): Use GDK_KEY_g.
11550 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11552 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11554 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11555 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11556 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11558 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11560 * w32xfns.c (select_palette): Check success of RealizePalette against
11561 GDI_ERROR, not zero.
11563 See ChangeLog.11 for earlier changes.
11565 ;; Local Variables:
11569 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11571 This file is part of GNU Emacs.
11573 GNU Emacs is free software: you can redistribute it and/or modify
11574 it under the terms of the GNU General Public License as published by
11575 the Free Software Foundation, either version 3 of the License, or
11576 (at your option) any later version.
11578 GNU Emacs is distributed in the hope that it will be useful,
11579 but WITHOUT ANY WARRANTY; without even the implied warranty of
11580 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11581 GNU General Public License for more details.
11583 You should have received a copy of the GNU General Public License
11584 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.