1 2012-01-11 Glenn Morris <rgm@gnu.org>
3 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4 from load-path also when installation-directory is nil. (Bug#10208)
6 2012-01-10 Glenn Morris <rgm@gnu.org>
8 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
10 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
11 Update template values to be closer to their typical values these days.
13 2012-01-09 Eli Zaretskii <eliz@gnu.org>
15 * xdisp.c (rows_from_pos_range): Accept additional argument
16 DISP_STRING, and accept any glyph in a row whose object is that
17 string as eligible for mouse highlight. Fixes mouse highlight of
18 display strings from overlays. (Bug#10464)
20 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
22 emacs: fix an auto-save permissions race condition (Bug#10400)
23 * fileio.c (auto_saving_dir_umask): New static var.
24 (Fmake_directory_internal): Use it.
25 (do_auto_save_make_dir): Set it, instead of invoking chmod after
26 creating the directory. The old code temporarily assigns
27 too-generous permissions to the directory.
28 (do_auto_save_eh): Clear it.
29 (Fdo_auto_save): Catch all errors, not just file errors, so
30 that the var is always cleared.
32 2012-01-07 Eli Zaretskii <eliz@gnu.org>
34 * search.c (scan_buffer): Pass character positions to
35 know_region_cache, not byte positions. (Bug#6540)
37 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
39 * w32.c (sys_rename): Report EXDEV when rename of a directory
40 fails because the target is on another logical disk. (Bug#10284)
42 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
44 * xterm.c (x_embed_request_focus): New function.
46 * xterm.h: Add prototype.
48 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
50 2012-01-05 Glenn Morris <rgm@gnu.org>
52 * emacs.c (emacs_copyright): Update short copyright year to 2012.
54 2012-01-01 Eli Zaretskii <eliz@gnu.org>
56 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
57 Load gnutls_transport_set_lowat only if GnuTLS version is below
59 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
60 GnuTLS versions below 2.11.1.
62 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
64 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
65 to the doc string advising against its use for altering the way
68 2011-12-28 Kenichi Handa <handa@m17n.org>
70 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
71 coding-system ASCII compatible only when it does not produce BOM
72 on encoding (Bug#10383).
74 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
76 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
78 (create_and_show_popup_menu): Always use menu_position_func for
81 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
83 * callint.c (Fcall_interactively): Don't truncate prompt string.
85 2011-12-23 Eli Zaretskii <eliz@gnu.org>
87 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
88 property that ends at ZV, so that the bidi iteration could be
89 resumed from there (after widening). (Bug#10360)
91 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
93 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
95 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
97 * nsterm.m (x_free_frame_resources):
98 Release f->output_data.ns->miniimage.
99 (ns_index_color): Fix indentation. Do not retain
100 color_table->colors[i].
102 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
105 * nsfns.m (x_set_background_color): Assign return value from
106 ns_index_color to face-background instead of NSColor*.
107 (ns_implicitly_set_icon_type): Fix indentation.
108 Change assignment in for loop to comparison.
110 * emacs.c (ns_pool): New variable.
111 (main): Assign ns_pool.
112 (Fkill_emacs): Call ns_release_autorelease_pool.
114 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
115 autorelease fdesc, release fdAttrs and tdict.
116 (ns_get_covering_families): Release charset.
117 (ns_findfonts): Release NSFontDescriptor created with new.
118 (ns_uni_to_glyphs): Fix indentation.
119 (setString): Release attrStr before assigning new value.
121 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
123 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
125 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
126 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
128 2011-12-18 David Reitter <reitter@cmu.edu>
130 * nsterm.m (ns_term_init): Subscribe for notifications
131 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
132 to method trackingNotification in EmacsMenu.
134 * nsmenu.m (trackingMenu): New variable.
135 (trackingNotification): New method (from Aquamacs).
136 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
137 from Aquamacs (Bug#7030).
139 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
141 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
142 (symbol_to_nsstring): Fix indentation.
143 (ns_symbol_to_pb): New function.
144 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
145 (Fns_rotate_cut_buffers_internal): Removed.
146 (Fns_store_selection_internal): Renamed from
147 Fns_store_cut_buffer_internal.
148 (ns_get_foreign_selection, Fx_own_selection_internal)
149 (Fx_disown_selection_internal, Fx_selection_exists_p)
150 (Fns_get_selection_internal, Fns_store_selection_internal):
151 Use ns_symbol_to_pb and check if return value is nil.
152 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
153 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
154 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
155 renamed to Sns_store_selection_internal.
156 (ns_handle_selection_request): Move code to Fx_own_selection_internal
157 and remove this function.
158 (ns_handle_selection_clear): Remove, never used.
159 (Fx_own_selection_internal): Move code from ns_handle_selection_request
162 2011-12-17 Ken Brown <kbrown@cornell.edu>
164 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
165 GID is unknown (Bug#10257).
167 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
169 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
170 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
171 which caused a build failure on GNU/Linux IA-64. This problem was
172 introduced by my 2011-10-07 patch.
174 2011-12-15 Juri Linkov <juri@jurta.org>
176 * image.c (imagemagick_error): New function. (Bug#10112)
177 (imagemagick_load_image): Comment out `MagickSetResolution' call.
178 Use `imagemagick_error' where ImageMagick functions return
180 (Fimagemagick_types): Add `Fnreverse' to return the list in the
183 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
185 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
186 fill background (Bug#8992).
188 2011-12-13 Martin Rudalics <rudalics@gmx.at>
190 * window.c (Vwindow_combination_resize)
191 (Vwindow_combination_limit): Use t instead of non-nil in
193 (Vrecenter_redisplay): Add first sentence of doc-string on
195 (Frecenter): Fix doc-string typo.
197 2011-12-11 Kenichi Handa <handa@m17n.org>
199 * coding.c (Funencodable_char_position): Pay attention to the
200 buffer text relocation (Bug#9389).
202 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
204 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
205 gtk_init (Bug#10100).
207 2011-12-10 Eli Zaretskii <eliz@gnu.org>
209 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
210 IT->string is nil. (Bug#10263)
212 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
214 * nsterm.h (x_free_frame_resources): Declare.
216 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
217 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
219 * nsterm.h (ns_get_defaults_value): Declare.
221 * nsterm.m (ns_default): Call ns_get_defaults_value.
223 2011-12-09 Eli Zaretskii <eliz@gnu.org>
225 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
228 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
230 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
231 that where the value of an _OBJC_* symbol points to is in the .bss
234 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
236 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
237 after the loop to call ccl_driver at least once (Bug#8619).
239 2011-12-08 Kenichi Handa <handa@m17n.org>
241 * ftfont.c (get_adstyle_property): Fix previous change
244 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
246 * w32.c (init_environment): If no_site_lisp, remove site-lisp
247 dirs from the default value of EMACSLOADPATH (bug#10208).
249 2011-12-07 Glenn Morris <rgm@gnu.org>
251 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
252 installation and source directories as well. (Bug#10208)
254 2011-12-06 Chong Yidong <cyd@gnu.org>
256 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
258 2011-12-06 Glenn Morris <rgm@gnu.org>
260 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
261 as an error, not just -1. (Bug#10217)
263 2011-12-05 Chong Yidong <cyd@gnu.org>
265 * keyboard.c (process_special_events): New function.
266 (swallow_events, Finput_pending_p): Use it (Bug#10195).
268 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
270 * coding.c (encode_designation_at_bol): Don't use uninitialized
271 local variable (Bug#9318).
273 2011-12-05 Kenichi Handa <handa@m17n.org>
275 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
276 return Qnil (Bug#8046, Bug#10193).
278 2011-12-05 Kenichi Handa <handa@m17n.org>
280 * coding.c (encode_designation_at_bol): New args charbuf_end and
281 dst. Return the number of produced bytes. Callers changed.
282 (coding_set_source): Return how many bytes coding->source was
284 (coding_set_destination): Return how many bytes
285 coding->destination was relocated.
286 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
287 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
289 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
291 * coding.c (CODING_CHAR_CHARSET_P): New macro.
292 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
295 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
297 The following changes are to fix Bug#9318.
299 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
300 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
301 (encode_coding_iso_2022, encode_coding_sjis)
302 (encode_coding_big5, encode_coding_charset): Use the above macros.
304 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
306 * lisp.h (process_quit_flag): Fix external declaration.
308 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
310 Don't macro-inline non-performance-critical code.
311 * eval.c (process_quit_flag): New function.
312 * lisp.h (QUIT): Use it.
314 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
316 * nsfns.m (get_geometry_from_preferences): New function.
317 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
319 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
321 * emacs.c (Qkill_emacs): Define.
322 (syms_of_emacs): Initialize it.
323 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
324 Qquit_flag to `kill-emacs' instead.
325 (quit_throw_to_read_char): Add parameter `from_signal'.
326 All callers changed. Call Fkill_emacs if requested and safe.
327 * lisp.h (QUIT): Call Fkill_emacs if requested.
329 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
331 * widget.c (update_wm_hints): Return if wmshell is null.
332 (widget_update_wm_size_hints): New function.
334 * widget.h (widget_update_wm_size_hints): Declare.
336 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
337 widget_update_wm_size_hints (Bug#10104).
339 2011-12-03 Eli Zaretskii <eliz@gnu.org>
341 * xdisp.c (handle_invisible_prop): If the invisible text ends just
342 before a newline, prepare the bidi iterator for consuming the
343 newline, and keep the current paragraph direction. (Bug#10183)
344 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
346 2011-12-02 Juri Linkov <juri@jurta.org>
348 * search.c (Fword_search_regexp): New Lisp function created from
349 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
350 (Fword_search_backward, Fword_search_forward)
351 (Fword_search_backward_lax, Fword_search_forward_lax):
352 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
353 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
355 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
357 * fileio.c (Finsert_file_contents): Move after-change-function call
358 to before the "handled:" label, since all "goto handled" appear in
359 cases where the *-change-functions have already been properly called
362 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
364 * keyboard.c (interrupt_signal): Don't call kill-emacs when
365 waiting for input. (Bug#10169)
367 2011-11-30 Eli Zaretskii <eliz@gnu.org>
369 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
370 verifies glyph row's hash code--we have just reallocated the
371 glyphs, so their contents can be complete garbage. (Bug#10164)
373 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
375 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
377 2011-11-30 Eli Zaretskii <eliz@gnu.org>
379 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
380 attributes are tested _before_ calling verify_row_hash, to protect
381 against GCC re-ordering of the tests. (Bug#10164)
383 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
385 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
387 * xterm.c (handle_one_xevent): Only set async_visible and friends
388 if net_wm_state_hidden_seen is non-zero (Bug#10002)
389 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
390 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
392 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
394 Remove GCPRO-related macros that exist only to avoid shadowing locals.
395 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
396 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
397 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
398 All uses changed to use GCPRO1 etc.
399 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
400 Revert to old implementation (i.e., before 2011-03-11).
402 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
404 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
405 of scroll runs so as to avoid assigning disabled bogus rows and
406 unnecessary graphics copy operations.
408 2011-11-27 Eli Zaretskii <eliz@gnu.org>
410 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
411 (snprintf) [_MSC_VER]: Redirect to _snprintf.
412 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
413 (malloc, free, realloc, calloc): Redirect to e_* only when
416 * lisp.h (GCTYPEBITS): Move before first use.
417 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
418 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
419 this macro definition.
421 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
424 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
426 * gtkutil.c (xg_create_frame_widgets):
427 Call gtk_window_set_has_resize_grip (FALSE) if that function is
428 present with Gtk+ 2.0.
430 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
432 * fileio.c (Finsert_file_contents): Undo previous change; see
433 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
435 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
437 Rename locals to avoid shadowing.
438 * fileio.c (Finsert_file_contents):
439 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
440 * process.c (wait_reading_process_output):
441 Rename inner 'proc' to 'p' to avoid shadowing.
442 Indent for consistency with usual Emacs style.
444 2011-11-25 Eli Zaretskii <eliz@gnu.org>
446 * xdisp.c (redisplay_window): If cursor row is not fully visible
447 after recentering, and scroll-conservatively is set to a large
448 number, scroll window by a few more lines to make the cursor fully
449 visible and out of scroll-margin. (Bug#10105)
450 (start_display): Don't move to the next line if the display should
451 start at a newline that is part of a display vector or an overlay
454 2011-11-24 Juri Linkov <juri@jurta.org>
456 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
457 after the `MagickPingImage' call. (Bug#10112)
459 2011-11-23 Chong Yidong <cyd@gnu.org>
461 * window.c (Fcoordinates_in_window_p): Accept only live windows.
463 2011-11-23 Martin Rudalics <rudalics@gmx.at>
465 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
466 making another buffer current. (Bug#10114)
468 2011-11-23 Glenn Morris <rgm@gnu.org>
470 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
472 2011-11-23 Chong Yidong <cyd@gnu.org>
474 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
477 2011-11-22 Eli Zaretskii <eliz@gnu.org>
479 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
480 and header-lines, as they don't have one computed for them.
483 * .gdbinit (prow): Make displayed values more self-explaining.
486 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
488 * process.c (wait_reading_process_output): Fix asynchrounous
489 GnuTLS socket handling on some versions of the GnuTLS library.
490 (wait_reading_process_output): Add comment and URL.
492 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
494 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
496 2011-11-21 Chong Yidong <cyd@gnu.org>
498 * window.c (Fnext_window, Fprevious_window): Doc fix.
500 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
502 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
504 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
506 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
508 2011-11-20 Martin Rudalics <rudalics@gmx.at>
510 * window.c (Fset_window_combination_limit): Rename argument
512 (Vwindow_combination_limit): Remove "status" from doc-string.
514 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
516 * m/ibms390.h: Remove.
517 * m/ibms390x.h: Don't include "ibms390.h".
519 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
521 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
522 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
524 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
526 * casetab.c (Fset_case_table):
527 * charset.c (Fcharset_after): Fix typos.
529 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
531 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
532 Otherwise, valgrind does not work on some platforms.
533 Problem reported by Andreas Schwab in
534 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
535 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
536 is set, removing the need for VIRT_ADDRESS_VARIES.
537 (PURE_P): Use a more-efficient implementation that needs just one
538 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
539 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
540 to 4 (xorl, subq, cmpq, setbe).
541 * alloc.c (pure): Always extern now, since that's the
542 VIRT_ADDR_VARIES behavior.
543 (PURE_POINTER_P): Use a single comparison, not two, for
544 consistency with the new puresize.h.
545 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
546 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
547 Remove VIRT_ADDR_VARIES no longer needed.
549 2011-11-19 Eli Zaretskii <eliz@gnu.org>
551 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
552 (erase_phys_cursor, update_window_cursor, show_mouse_face)
553 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
554 behave as if the cursor position were at the window margin.
556 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
557 and the cursor position is out of bounds, behave as if the cursor
558 position were at the window margin. (Bug#10075)
560 2011-11-18 Chong Yidong <cyd@gnu.org>
562 * window.c (Fwindow_combination_limit): Make first argument
563 non-optional, since it is meaningless for live windows like the
566 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
568 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
570 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
572 * intervals.c: Fix grafting over the whole buffer (bug#10071).
573 (graft_intervals_into_buffer): Simplify.
575 2011-11-18 Eli Zaretskii <eliz@gnu.org>
577 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
578 hash values of the two rows.
579 (copy_row_except_pointers): Preserve the used[] arrays and the
580 hash values of the two rows. (Bug#10035)
581 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
583 * xdisp.c (row_hash): New function, body extracted from
584 compute_line_metrics.
585 (compute_line_metrics): Call row_hash, instead of computing the
588 * dispnew.c (verify_row_hash): Call row_hash for computing the
589 hash code of a row, instead of duplicating code from xdisp.c.
591 * dispextern.h (row_hash): Add prototype.
593 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
595 * frame.c (delete_frame): Don't delete the terminal when the last
596 X frame is closed if emacs is built with GTK toolkit.
598 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
600 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
602 2011-11-17 Martin Rudalics <rudalics@gmx.at>
604 * window.c (Vwindow_splits): Rename to
605 Vwindow_combination_resize. Suggested by Juri Linkov.
606 (Fsplit_window_internal): Use Vwindow_combination_resize instead
609 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
611 * nsfns.m (Fns_font_name):
612 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
614 2011-11-16 Martin Rudalics <rudalics@gmx.at>
616 * window.h (window): Rename slot "nest" to "combination_limit".
617 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
618 (Fset_window_nest): Rename to Fset_window_combination_limit.
619 (Vwindow_nest): Rename to Vwindow_combination_limit.
620 (recombine_windows, make_parent_window, make_window)
621 (Fsplit_window_internal, saved_window)
622 (Fset_window_configuration, save_window_save): Rename all
623 occurrences of window_nest to window_combination_limit.
625 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
627 * image.c (imagemagick_load_image): Fix typo.
629 2011-11-14 Eli Zaretskii <eliz@gnu.org>
631 * xdisp.c (display_line): Move the call to
632 highlight_trailing_whitespace before the call to
633 compute_line_metrics, since the latter needs to see the final
634 faces of all the glyphs to compute ROW's hash value.
635 Fixes assertion violations in row_equal_p. (Bug#10035)
637 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
639 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
640 just return (bug#10044).
642 2011-11-12 Eli Zaretskii <eliz@gnu.org>
644 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
645 with user-defined heap size. Bump the default size of the temacs
646 heap to 27MB, to avoid memory warning when running temacs.
647 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
649 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
650 current_matrix and desired_matrix. (Bug#9990)
651 (verify_row_hash) [XASSERTS]: New function.
652 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
653 that the hash value of glyph rows is correct.
655 2011-11-12 Martin Rudalics <rudalics@gmx.at>
657 * window.h (window): Remove splits slot.
658 * window.c (Fwindow_splits, Fset_window_splits): Remove.
659 (Fdelete_other_windows_internal, make_parent_window)
660 (make_window, Fsplit_window_internal, Fdelete_window_internal)
661 (Fset_window_configuration, save_window_save): Don't deal with
662 split status of windows.
663 (saved_window): Remove splits slot.
664 (Vwindow_splits): Rewrite doc-string.
666 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
668 * xfns.c (unwind_create_frame):
669 * nsfns.m (unwind_create_frame):
670 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
671 Vframe_list (Bug#9999).
673 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
675 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
677 2011-11-11 Kenichi Handa <handa@m17n.org>
679 * callproc.c (Fcall_process): Set the member dst_multibyte of
682 2011-11-11 Johan Bockgård <bojohan@gnu.org>
684 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
685 avoid a crash (bug#9496).
687 2011-11-09 Chong Yidong <cyd@gnu.org>
689 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
690 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
692 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
694 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
696 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
698 Avoid some portability problems by eschewing 'extern inline' functions.
699 The trivial performance wins aren't worth the portability hassles; see
700 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
702 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
703 (window_box_width, window_box_left, window_box_left_offset)
704 (window_box_right, window_box_right_offset): Undo previous change,
705 by removing the "extern"s.
706 * intervals.c (adjust_intervals_for_insertion)
707 (adjust_intervals_for_deletion): Undo previous change,
708 making these static again.
709 (offset_intervals, temp_set_point_both, temp_set_point)
710 (copy_intervals_to_string): No longer inline.
711 * xdisp.c (window_text_bottom_y, window_box_width)
712 (window_box_height, window_box_left_offset)
713 (window_box_right_offset, window_box_left, window_box_right)
714 (window_box): No longer inline.
716 2011-11-08 Chong Yidong <cyd@gnu.org>
718 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
719 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
720 Signal an error if not a live window.
721 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
722 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
724 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
726 * lisp.h (syms_of_abbrev): Remove declaration.
727 Reported by CHENG Gao <chenggao@royau.me>.
729 2011-11-07 Eli Zaretskii <eliz@gnu.org>
731 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
732 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
733 of temacs in GUI mode.
735 2011-11-07 Martin Rudalics <rudalics@gmx.at>
737 * window.h: Declare delete_all_child_windows instead of
738 delete_all_subwindows.
739 * window.c (Fwindow_nest, Fset_window_nest)
740 (Fset_window_new_total, Fset_window_new_normal)
741 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
742 (delete_all_subwindows): Rename to delete_all_child_windows.
743 (Fdelete_other_windows_internal, Fset_window_configuration):
744 Call delete_all_child_windows instead of delete_all_subwindows.
745 * frame.c (delete_frame): Call delete_all_child_windows instead
746 of delete_all_subwindows.
748 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
750 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
751 This is also needed for porting to any host where GC_MARK_STACK is
752 not GC_MAKE_GCPROS_NOOPS.
753 (which_symbols): Use it.
755 2011-11-07 Kenichi Handa <handa@m17n.org>
757 * coding.c (coding_set_destination): Check coding->src_pos only
758 when coding->src_object is a buffer (bug#9910).
760 * process.c (send_process): Set the member src_multibyte of coding
761 to 0 (bug#9911) when sending a unibyte text.
763 * callproc.c (Fcall_process): Set the member src_multibyte of
764 process_coding to 0 (bug#9912).
766 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
768 * xmenu.c (cleanup_widget_value_tree): New function.
769 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
770 calling free_menubar_widget_value_tree directly (Bug#9830).
772 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
774 Fix some portability problems with 'inline'.
775 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
776 (window_box_width, window_box_left, window_box_left_offset)
777 (window_box_right, window_box_right_offset): Declare extern.
778 Otherwise, these inline functions do not conform to C99 and
779 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
780 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
781 * intervals.c (adjust_intervals_for_insertion)
782 (adjust_intervals_for_deletion): Now extern, because otherwise the
783 extern inline functions 'offset_intervals' couldn't refer to it.
784 (static_offset_intervals): Remove.
785 (offset_intervals): Rewrite using the old contents of
786 static_offset_intervals. The old version didn't conform to C99
787 because an extern inline function contained a reference to an
788 identifier with static linkage.
790 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
792 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
795 2011-11-06 Eli Zaretskii <eliz@gnu.org>
797 * xdisp.c (init_iterator, reseat_to_string): Don't set the
798 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
799 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
800 return Qleft_to_right.
802 2011-11-06 Chong Yidong <cyd@gnu.org>
804 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
805 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
806 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
807 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
808 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
809 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
810 (Fwindow_vscroll): Doc fix.
811 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
812 argument, since it makes no sense to pass a live window and for
813 consistency with window-child.
815 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
817 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
820 2011-11-05 Jason Rumney <jasonr@gnu.org>
822 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
823 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
825 (add_font_entity_to_list): Fix logic errors in mixed boolean and
826 bitwise arithmetic preventing use of unicode-sip and non-truetype
829 2011-11-05 Eli Zaretskii <eliz@gnu.org>
831 * s/ms-w32.h (fstat, stat, utime): Move redirections to
834 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
835 initialization code to keep similarity to xfns.c after changes
838 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
840 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
841 (unwind_create_frame): New function (Bug#9943).
842 (Fx_create_frame): Restructure code to be more similar to the one in
843 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
844 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
845 Move terminal->reference_count++ just before making the frame official
848 * nsterm.m (x_free_frame_resources): New function.
849 (x_destroy_window): Move code to x_free_frame_resources.
851 * xfns.c (unwind_create_frame): Fix comment.
852 (Fx_create_frame, x_create_tip_frame):
853 Move terminal->reference_count++ just before making the frame
854 official. Move initialization of image_cache_refcount and
855 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
857 2011-11-05 Eli Zaretskii <eliz@gnu.org>
859 Support MSVC build with newer versions of Visual Studio.
860 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
861 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
864 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
865 which are not supported by MSVC.
866 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
867 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
869 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
871 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
873 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
875 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
877 Support MSVC build with newer versions of Visual Studio.
878 * w32.c: Don't include w32api.h for MSVC.
879 (init_environment) [_MSC_VER]: Call sys_access, not _access.
881 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
882 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
883 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
884 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
886 (alloca) [_MSC_VER]: Define to _alloca.
888 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
890 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
892 2011-11-04 Eli Zaretskii <eliz@gnu.org>
894 * xdisp.c (note_mouse_highlight): If either of
895 previous/next-single-property-change returns nil, treat that as
896 the beginning or the end of the buffer. (Bug#9955)
898 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
900 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
901 label is not null (Bug#9951).
902 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
905 2011-11-04 Eli Zaretskii <eliz@gnu.org>
907 * window.c (Fwindow_body_size): Mention in the doc string that the
908 return value is in frame's canonical units. (Bug#9949)
910 2011-11-03 Eli Zaretskii <eliz@gnu.org>
912 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
914 * w32fns.c (unwind_create_frame): If needed, free the glyph
915 matrices of the partially constructed frame. (Bug#9943)
916 * xfns.c (unwind_create_frame): Likewise.
918 2011-11-01 Eli Zaretskii <eliz@gnu.org>
920 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
921 Don't stop backward scan on the continuation glyph, even though
922 its CHARPOS is positive.
923 (mouse_face_from_buffer_pos, note_mouse_highlight):
924 Rename cover_string to disp_string.
926 2011-11-01 Martin Rudalics <rudalics@gmx.at>
928 * window.c (temp_output_buffer_show): Don't use
929 Vtemp_buffer_show_specifiers.
930 (Vtemp_buffer_show_specifiers): Remove unused variable.
932 2011-10-30 Eli Zaretskii <eliz@gnu.org>
934 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
935 past the beginning of the current glyph matrix.
937 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
939 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
940 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
941 HAVE_GTK3 (Bug#9869).
943 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
944 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
946 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
948 * xterm.c: Declare x_handle_net_wm_state to return int.
949 (handle_one_xevent): Check if we are iconified but don't have
950 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
951 (get_current_wm_state): Return non-zero if not hidden,
952 check for _NET_WM_STATE_HIDDEN (Bug#9893).
953 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
954 (x_handle_net_wm_state): Return what get_current_wm_state returns.
955 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
957 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
959 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
960 so that this new function doesn't get optimized away by a
961 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
963 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
965 * frame.h (MOUSE_HL_INFO): Remove excess parens.
967 2011-10-29 Eli Zaretskii <eliz@gnu.org>
969 Fix the `xbytecode' command.
970 * .gdbinit (xprintbytestr): New command.
971 (xwhichsymbols): Rename from `which'; all callers changed.
972 (xbytecode): Print the byte-code string as well.
974 2011-10-29 Kim Storm <storm@cua.dk>
976 * alloc.c (which_symbols): New function.
978 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
980 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
983 2011-10-29 Glenn Morris <rgm@gnu.org>
985 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
986 Not clear what it was for, and it causes various bugs. (Bug#9839)
988 2011-10-28 Eli Zaretskii <eliz@gnu.org>
990 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
991 possible random value that matches one of those tested as
992 condition to clear the mouse face.
994 2011-10-28 Chong Yidong <cyd@gnu.org>
996 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
998 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1000 * window.c (make_window): Initialize phys_cursor_on_p.
1002 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1004 * lisp.h (struct Lisp_Symbol): Update comments.
1006 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1008 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1010 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1012 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1013 <oslsachem@gmail.com> for helping to debug this.
1015 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1016 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1017 (g_b_init_get_glyph_outline_w): New static variables.
1018 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1019 (GetGlyphOutlineW_Proc): New typedefs.
1020 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1021 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1023 (w32font_open_internal, compute_metrics):
1024 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1025 instead of calling the "wide" APIs directly.
1027 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1029 * w32.h (syms_of_w32font): Add prototype.
1031 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1033 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1034 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1035 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1036 (Fmove_to_window_line): Doc fix.
1038 2011-10-27 Chong Yidong <cyd@gnu.org>
1040 * process.c (make_process): Set gnutls_state to NULL.
1042 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1043 non-NULL, regardless of GNUTLS_INITSTAGE.
1044 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1045 an error. Set process slots as soon as we allocate them.
1047 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1049 2011-10-27 Chong Yidong <cyd@gnu.org>
1051 * gnutls.c (emacs_gnutls_deinit): New function.
1052 Deallocate credentials structures as well as calling gnutls_deinit.
1053 (Fgnutls_deinit, Fgnutls_boot): Use it.
1055 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1056 (deactivate_process): Call emacs_gnutls_deinit.
1058 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1060 * image.c (x_create_x_image_and_pixmap):
1061 * w32.c (sys_rename, w32_delayed_load):
1062 * w32font.c (fill_in_logfont):
1063 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1065 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1067 * w32fns.c (w32_default_color_map): New function,
1068 extracted from Fw32_default_color_map.
1069 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1071 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1073 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1075 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1077 * keyboard.c (test_undefined): New function (bug#9751).
1078 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1080 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1082 * sysdep.c (init_sys_modes): Fix the check for the controlling
1083 terminal (Bug#6649).
1085 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1087 * dispextern.h (struct bidi_it): New member next_en_type.
1089 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1090 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1091 current character, check also for next_en_type being WEAK_EN.
1092 (bidi_resolve_weak): Don't enter the expensive loop if the current
1093 position is before next_en_pos. Record the bidi type of the first
1094 non-ET, non-BN character we find, in addition to its position.
1095 (bidi_level_of_next_char): Invalidate next_en_type when
1096 next_en_pos is over-stepped.
1098 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1100 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1101 * editfns.c: Rewrite current-time-zone so that it invokes
1102 the equivalent of (format-time-string "%Z") to get the time zone name.
1103 This fixes a bug when the time zone name contains characters that
1104 need converting from the system time locale to Emacs internal format.
1105 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1106 that patch fixed format-time-string to do the conversion, but
1107 I forgot to fix current-time-zone.
1108 (format_time_string): New function, containing most of
1109 what Fformat_time_string used to contain.
1110 (Fformat_time_string): Rewrite in terms of format_time_string.
1111 This doesn't change this function's behavior.
1112 (current-time-zone): Rewrite to use format_time_string.
1113 This fixes the bug reported by Michael Schierl in
1114 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1115 Jason Rumney's 2007-06-07 change worked around this bug, but
1117 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1119 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1121 * xdisp.c (start_display): If the character at POS is displayed
1122 via a display vector, reset IT->current.dpvec_index to zero.
1123 (try_window_reusing_current_matrix): If a line ends in a display
1124 vector or the next line starts in a display vector, continue
1125 redrawing the window even though the character position of
1126 start_row was reached.
1129 2011-10-18 Chong Yidong <cyd@gnu.org>
1131 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1132 with nobreak-char-display too.
1134 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1136 Fix part 3 of bug#9771.
1137 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1138 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1139 non-neutral characters if the current character is a paragraph
1140 separator (a.k.a. Newline). This avoids running the same
1141 expensive loop twice, once when we consume the preceding newline
1142 and the other time when the line actually needs to be displayed.
1143 Avoid the loop when we see neutrals on the base embedding level
1144 following a character whose directionality is the same as the
1145 paragraph's. This avoids running the expensive loop when a line
1146 ends in a long sequence of neutrals, like control characters.
1147 Add assertion against STRONG_AL type. Slightly rearrange code
1148 that determines the type of a neutral given the first non-neutral
1150 (bidi_level_of_next_char): Set next_en_pos to zero when
1151 invalidating its info.
1153 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1155 * xdisp.c (push_display_prop): Determine whether to record string
1156 or buffer position by IT->string, not by IT->method. Allow
1157 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1158 (move_it_vertically_backward): Don't look for character position
1159 immediately after the newline when in a continuation line.
1162 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1164 * window.c (coordinates_in_window): Rewrite and delabelize
1165 vertical border check. (Bug#5357) (Bug#9618)
1167 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1169 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1170 errors in XSetWindowBorder (bug#9310).
1172 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1174 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1175 avoid crash when xmalloc overrun checking is enabled.
1177 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1179 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1180 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1181 cursor motion with <left> and <right> arrow keys.
1183 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1184 some callers set that themselves.
1186 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1188 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1189 display string and the previous row comes from the same string and
1190 is empty. (Bug#9739) (Bug#9738)
1192 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1194 * doc.c (get_doc_string): Encode file name (bug#9735).
1196 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1198 * bidi.c (bidi_level_of_next_char):
1199 * xdisp.c (get_visually_first_element): Remove old incorrect
1200 comments regarding the Unicode Line Separator character.
1202 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1204 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1206 * alloc.c (Fgc_status): Do not access beyond zombies array
1207 boundary if nzombies > MAX_ZOMBIES.
1208 * alloc.c (dump_zombies): Add missing format specifier.
1210 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1212 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1213 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1215 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1216 Some packages use them to denote characters with modifiers.
1218 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1220 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1221 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1222 matching a pp-number. Rename parameter var to var1.
1224 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1226 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1228 2011-10-08 Glenn Morris <rgm@gnu.org>
1230 * callint.c (Fcall_interactively): Give a more explicit error for the
1231 'c' case with a non-character input. (Bug#8479)
1233 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1237 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1238 lines that are hscrolled on the left.
1240 * dispnew.c (buffer_posn_from_coords): Account for a possible
1241 presence of header-line. (Bug#4426)
1243 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1245 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1246 Don't advertise functionality which we discourage or doesn't work.
1248 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1250 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1251 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1252 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1253 this makes Emacs dump core during garbage collection on rare
1254 occasions. sizeof is obviously inferior to offsetof here, so
1255 stick with offsetof.
1256 (GC_POINTER_ALIGNMENT): New macro.
1257 (mark_memory): Omit 3rd (offset) arg; caller changed.
1258 Don't assume EMACS_INT alignment is the same as pointer alignment.
1260 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1262 * keyboard.c (read_key_sequence_remapped): New var.
1263 (read_key_sequence): Compute remapping in the right buffer.
1264 (command_loop_1): Use read_key_sequence's remapping directly.
1266 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1268 * dired.c (file_name_completion): Don't expand file name.
1269 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1270 before checking file name handler.
1272 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1273 they've been requested explicitly (bug#9591).
1275 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1277 * keymap.c (Fsingle_key_description): Use make_specified_string
1278 instead of build_string to build string from push_key_description.
1281 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1283 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1284 This fixes a Y2038 bug on 64-bit hosts.
1285 * buffer.c (reset_buffer):
1286 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1287 (Fclear_buffer_auto_save_failure):
1288 Use 0, not -1, to represent an unset failure time, since time_t
1289 might not be signed.
1291 Remove dependency on glibc malloc internals.
1292 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1293 Move back here from lisp.h, but with their new implementations.
1294 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1295 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1296 * charset.c (charset_table_init): New static var.
1297 (syms_of_charset): Use it instead of xmalloc. This removes a
1298 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1299 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1300 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1301 Move back to alloc.c.
1302 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1303 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1305 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1307 * nsterm.m (windowDidResize): Call x_set_window_size only when
1308 ns_in_resize is true. Otherwise set pixelwidth/height and
1309 call change_frame_size (Bug#9628).
1311 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1313 Port --enable-checking=all to Fedora 14 x86-64.
1314 * charset.c (syms_of_charset): Also account for glibc malloc's
1315 internal overhead when calculating the initial malloc maximum.
1317 Port --enable-checking=all to Fedora 14 x86.
1318 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1320 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1321 (overrun_check_realloc, overrun_check_free):
1322 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1323 That way, xmalloc returns a properly-aligned pointer even if
1324 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1325 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1326 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1327 into account when calculating the initial malloc maximum.
1328 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1329 Move here from alloc.c, so that charset.c can use it too.
1330 Properly align; the old code wasn't right for common 32-bit hosts
1331 when configured with --enable-checking=all.
1332 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1333 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1335 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1337 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1340 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1342 * xdisp.c (compute_display_string_end): If there's no display
1343 string at CHARPOS, return -1.
1345 * bidi.c (bidi_fetch_char): When compute_display_string_end
1346 returns a negative value, treat the character as a normal
1347 character not covered by a display string. (Bug#9624)
1349 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1351 * lread.c (Fread_from_string): Fix typo in docstring.
1353 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1355 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1356 newline, reseat the iterator instead of bidi-iterating there one
1357 character at a time. (Bug#9610)
1358 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1359 TO_CHARPOS if the bidi iterator is at base embedding level.
1361 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1363 * lread.c (readevalloop): Use correct code for NBSP.
1364 (read1): Likewise. (Bug#9608)
1366 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1368 * dbusbind.c (Fdbus_register_signal): When service is not
1369 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1371 2011-09-25 Glenn Morris <rgm@gnu.org>
1373 * buffer.c (truncate-lines): Doc fix.
1375 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1377 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1378 (Fset_window_next_buffers): Doc fix.
1380 2011-09-24 Glenn Morris <rgm@gnu.org>
1382 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1384 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1386 Fix minor problems found by static checking.
1387 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1388 * indent.c (Fvertical_motion): Fix == vs = typo.
1390 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1392 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1393 Default value is now t. Doc fix.
1395 * indent.c (Fvertical_motion): Compute and apply the overshoot
1396 logic when moving up, not only when moving down. Fix the
1397 confusing name and values of the it_overshoot_expected variable;
1398 logic changes accordingly. (Bug#9254) (Bug#9549)
1400 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1401 CHARPOS is covered by a display string which includes newlines.
1402 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1403 is covered by a display string with embedded newlines.
1405 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1407 * dbusbind.c (Fdbus_register_signal): Add match rule to
1408 Vdbus_registered_objects_table. (Bug#9581)
1409 (Fdbus_register_method, Vdbus_registered_objects_table):
1412 2011-09-24 Jim Meyering <meyering@redhat.com>
1414 do not ignore write error for any output size
1415 The previous change was incomplete.
1416 While it makes emacs --batch detect the vast majority of stdout
1417 write failures, errors were still ignored whenever the output size is
1418 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1419 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1420 && echo FAIL: ignored write error
1421 FAIL: ignored write error
1422 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1423 && echo FAIL: ignored write error
1424 FAIL: ignored write error
1425 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1427 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1429 * emacs.c (Fkill_emacs): In noninteractive mode exit
1430 non-successfully if a write error occurred on stdout. (Bug#9574)
1432 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1434 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1437 * dispextern.h (struct it): Update the comment documenting what
1440 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1442 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1443 a display string, extend search for cursor position to end of row.
1444 (find_row_edges): If the row ends in a newline from a display
1445 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1446 Handle the case of a display string with multiple newlines.
1447 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1448 non-empty line. Fixes confusing cursor motion with arrow keys at
1449 the beginning of a line that starts with whitespace.
1451 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1453 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1456 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1458 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1461 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1463 * xdisp.c (display_line): Record maximum and minimum buffer
1464 positions even if no glyphs were produced (e.g., by a zero-width
1465 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1466 buffer positions that will be removed from the glyph row because
1468 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1469 column is beyond frame width: don't subtract 1 "pixel" when
1470 computing width of the stretch.
1471 (reseat_at_next_visible_line_start): Undo the change made on
1472 2011-09-17 that saved paragraph information and restored it after
1473 the call to `reseat'. (Bug#9545)
1475 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1477 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1478 and turn window cursor on if cleared (Bug#9415).
1480 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1482 * search.c (boyer_moore): Take unibyte characters from pattern
1483 literally. (Bug#9458)
1485 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1487 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1489 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1491 Fix minor problem found by static checking.
1492 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1493 initialized, to pacify gcc -Wuninitialized.
1495 * fileio.c: Report proper errno when syscall falls.
1496 (Finsert_file_contents): Save and restore errno,
1497 so that report_file_error outputs the correct diagnostic.
1498 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1500 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1502 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1504 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1506 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1507 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1509 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1511 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1512 about the current paragraph and restore it after the call to reseat.
1514 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1515 (bidi_find_paragraph_start): Search back for paragraph beginning
1516 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1517 (bidi_move_to_visually_next): Only trigger paragraph-related
1518 computations when the last character is a newline or at EOB, not
1519 just any NEUTRAL_B. (Bug#9470)
1521 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1522 truncated lines if point is covered by a display string. (Bug#9524)
1524 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1526 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1527 (cons_to_x_long): New function.
1528 (lisp_data_to_selection_data): Use it. Correct the test for
1529 short-versus-long data; it was negated. Break out of vector
1530 loop, for efficiency, when a long datum is discovered.
1532 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1534 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1536 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1538 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1539 GCC PR/17406) by declaring this function with external scope.
1541 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1543 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1544 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1546 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1548 * editfns.c (Fformat): Correctly handle text properties on "%%".
1550 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1552 * xterm.c (x_draw_composite_glyph_string_foreground):
1553 * w32term.c (x_draw_composite_glyph_string_foreground):
1554 * term.c (encode_terminal_code):
1555 * composite.c (composition_update_it, get_composition_id):
1556 * xdisp.c (get_next_display_element)
1557 (fill_composite_glyph_string): Add comments about special meaning
1558 of TAB characters in a composition.
1560 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1562 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1563 This occurs when processing a multibyte format.
1564 Problem reported by Wolfgang Jenker.
1566 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1568 * xdisp.c (try_cursor_movement): Only check for exact match if
1569 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1571 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1573 Remove unused external symbols.
1574 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1575 * xdisp.c (calc_pixel_width_or_height): Now static.
1576 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1577 * indent.c (check_display_width):
1578 * w32term.c: Fix comment to match code.
1579 * xterm.c, xterm.h (x_catching_errors): Remove.
1581 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1583 * xselect.c: Use signed conversions more consistently (Bug#9498).
1584 (selection_data_to_lisp_data): Assume incoming selection data are
1585 signed integers, not unsigned. This is to be consistent with
1586 outgoing selection data, which was modified to use signed integers
1587 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1588 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1589 expects long, not unsigned long.
1591 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1593 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1594 computation of loop end. Reported by Johan Bockgård
1597 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1599 * frame.c (Fother_visible_frames_p): Function deleted.
1601 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1603 * indent.c (compute_motion): Process display vector front to back
1604 rather than the other way around. (Bug#2496)
1606 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1608 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1610 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1612 * minibuf.c (Fread_from_minibuffer): Doc fix.
1614 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1616 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1617 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1619 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1621 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1622 value for non-existent files.
1624 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1626 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1627 set its "size" to -1. This will set the modtime_size field of
1628 the corresponding buffer to -1, which is what
1629 verify-visited-file-modtime expects for files that do not exist.
1632 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1634 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1636 * lisp.h: ... from here. push_key_description is no longer
1637 defined in keyboard.c, so its declaration should not be in
1638 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1639 logically belongs with push_key_description.
1641 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1643 * buffer.h: Include <sys/types.h> instead of <time.h>.
1644 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1645 Problem reported by Herbert J. Skuhra.
1647 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1649 * xml.c (parse_region): Make the parsing work for
1650 non-comment-starting XML files again (bug#9144).
1652 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1654 * image.c (gif_load): Fix calculation of bottom and right corner.
1657 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1659 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1660 redisplay in small windows.
1662 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1664 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1666 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1668 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1669 Operate on live windows only.
1671 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1673 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1675 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1677 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1678 only under bidi iteration.
1680 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1682 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1684 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1686 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1687 Without this fix, the command to link temacs failed due to an
1688 undefined symbol __builtin_isnan. This is because
1689 /usr/include/iso/math_c99.h #defines isnan(x) to
1690 __builtin_isnan(x), but the bundled gcc, which identifies itself
1691 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1693 * floatfns.c (isnan): #undef, and then #define to a clone of
1695 (Fisnan): Always define, since it's always available now.
1696 (syms_of_floatfns): Always define isnan at the Lisp level.
1698 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1700 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1702 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1704 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1705 The previous code assumed that file offsets (off_t values) fit in
1706 EMACS_INT variables, which is not true on typical 32-bit hosts.
1707 The code messed up by falsely reporting buffer overflow in cases
1708 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1709 when "big" contains more than 2**29 bytes, even though this
1710 inserts just one byte and does not overflow the buffer.
1711 (Finsert_file_contents): Store file offsets as off_t
1712 values, not as EMACS_INT values. Check for overflow when
1713 converting between EMACS_INT and off_t. When checking for
1714 buffer overflow or for overlap, take the offsets into account.
1715 Don't use EMACS_INT for small values where int suffices.
1716 When checking for overlap, fix a typo: ZV was used where
1717 ZV_BYTE was intended.
1718 (Fwrite_region): Don't assume off_t fits into 'long'.
1719 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1721 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1723 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1725 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1727 sprintf-related integer and memory overflow issues (Bug#9412).
1729 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1730 (esprintf, exprintf, evxprintf): New functions.
1731 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1732 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1733 (modify_event_symbol): Do not assume that the length of
1734 name_alist_or_stem is safe to alloca and fits in int.
1735 (Fexecute_extended_command): Likewise for function name and binding.
1736 (Frecursion_depth): Wrap around reliably on integer overflow.
1737 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1738 since some callers pass EMACS_INT values.
1739 (Fsingle_key_description): Don't crash if symbol name contains more
1740 than MAX_ALLOCA bytes.
1741 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1742 (get_minibuffer): Arg is now EMACS_INT, not int.
1743 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1744 (esprintf, exprintf, evxprintf): New decls.
1745 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1747 * dbusbind.c (signature_cat): New function.
1748 (xd_signature, Fdbus_register_signal):
1749 Do not overrun buffer; instead, report string overflow.
1751 * dispnew.c (add_window_display_history): Don't overrun buffer.
1752 Truncate instead; this is OK since it's just a log.
1754 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1755 even if the time zone offset is outlandishly large.
1756 Don't mishandle offset == INT_MIN.
1758 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1759 when creating daemon; the previous buffer-overflow check was incorrect.
1761 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1762 which has the guts of the old verror function.
1764 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1765 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1767 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1768 (font_unparse_xlfd): Don't blindly alloca long strings.
1769 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1770 fits in int, when using sprintf. Use single snprintf to count
1771 length of string rather than counting it via multiple sprintfs;
1772 that's simpler and more reliable.
1773 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1774 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1775 sprintf, in case result does not fit in int.
1777 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1778 (fontset_from_font): Print it.
1780 * frame.c (tty_frame_count): Now printmax_t, not int.
1781 (make_terminal_frame, set_term_frame_name): Print it.
1782 (x_report_frame_params): In X, window IDs are unsigned long,
1783 not signed long, so print them as unsigned.
1784 (validate_x_resource_name): Check for implausibly long names,
1785 and don't assume name length fits in 'int'.
1786 (x_get_resource_string): Don't blindly alloca invocation name;
1787 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1790 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1791 (xg_check_special_colors, xg_set_geometry):
1792 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1794 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1795 Use esprintf, not sprintf, in case result does not fit in int.
1797 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1798 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1799 it as a large positive number.
1800 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1801 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1803 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1804 in case result does not fit in int.
1806 * print.c (float_to_string): Detect width overflow more reliably.
1807 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1808 buffer overrun. Don't assume list length fits in 'int'. Treat
1809 print length of 0 as 0, not as infinity; to be consistent with other
1810 uses of print length in this function. Don't overflow print length
1811 index. Don't assume hash table size fits in 'long', or that
1812 vectorlike size fits in 'unsigned long'.
1814 * process.c (make_process): Use printmax_t, not int, to format
1815 process-name gensyms.
1817 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1819 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1820 to avoid potential buffer overrun.
1822 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1823 if X resource line is longer than 512 bytes.
1825 * xfns.c (x_window): Make sprintf buffer a bit bigger
1826 to avoid potential buffer overrun.
1828 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1830 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1832 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1834 Integer overflow fixes for scrolling, etc.
1835 Without these, Emacs silently mishandles large integers sometimes.
1836 For example, "C-u 4294967297 M-x recenter" was treated as if
1837 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1839 * xdisp.c (try_window_id): Check Emacs fixnum range before
1840 converting to 'int'.
1842 * window.c (window_scroll_line_based, Frecenter):
1843 Check that an Emacs fixnum is in range before assigning it to 'int'.
1844 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1845 values converted from Emacs fixnums.
1846 (Frecenter): Don't wrap around a line count if it is out of 'int'
1847 range; instead, treat it as an extreme value.
1848 (Fset_window_configuration, compare_window_configurations):
1849 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1851 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1852 that can exceed INT_MAX. Check that EMACS_INT value is in range
1853 before assigning it to the (possibly-narrower) index.
1854 (match_limit): Don't assume that a fixnum can fit in 'int'.
1856 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1859 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1860 (Fvertical_motion): Don't wrap around LINES values that don't fit
1861 in 'int'. Instead, treat them as extreme values. This is good
1862 enough for windows, which can't have more than INT_MAX lines anyway.
1864 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1866 * Require libxml/parser.h to avoid compilation warning.
1868 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1870 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1871 since this reportedly can destroy thread storage.
1873 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1875 * syntax.c (find_defun_start): Update all cache variables if
1876 exiting early (Bug#9401).
1878 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1880 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1882 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1883 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1884 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1886 * term.c (tty_append_glyph): New function.
1887 (produce_stretch_glyph): Static function and its prototype deleted.
1889 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1892 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1894 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1895 when checking :margin (Bug#9390).
1896 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1897 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1898 so that the name doesn't mislead. All uses changed.
1900 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1902 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1905 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1907 * xdisp.c (move_it_to): Don't bail out early when reaching
1908 position beyond to_charpos, if we are scanning backwards.
1909 (move_it_vertically_backward): When DY == 0, make sure we get to
1910 the first character in the line after the newline.
1912 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1914 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1915 (ccl_driver): Do not generate an out-of-range pointer.
1916 (Fccl_execute_on_string): Remove unnecessary check for
1917 integer overflow, noted by Stefan Monnier in
1918 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1919 Remove a FIXME that didn't need fixing.
1920 Simplify the newly-introduced buffer reallocation code.
1922 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1924 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1926 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1928 Integer and memory overflow issues (Bug#9196).
1930 * doc.c (get_doc_string): Rework so that
1931 get_doc_string_buffer_size is the actual buffer size, rather than
1932 being 1 less than the actual buffer size; this makes xpalloc more
1935 * image.c (x_allocate_bitmap_record, cache_image):
1936 * xselect.c (Fx_register_dnd_atom):
1937 Simplify previous changes by using xpalloc.
1939 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1940 since either will do and ptrdiff_t is convenient with xpalloc.
1942 * charset.c (charset_table_size)
1943 (struct charset_sort_data.priority): Now ptrdiff_t.
1944 (charset_compare): Don't overflow if priorities differ greatly.
1945 (Fsort_charsets): Don't assume list length fits in int.
1946 Check for size-calculation overflow when allocating sort data.
1947 (syms_of_charset): Allocate an initial charset table that is
1948 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1950 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1952 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1953 The actual value is always <= INT_MAX, and leaving it unsigned made
1954 overflow checking harder.
1956 * dispextern.h (struct glyph_matrix.rows_allocated)
1957 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1958 with xpalloc. The values are still always <= INT_MAX.
1960 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1962 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1963 (SAFE_NALLOCA): New macro.
1965 * region-cache.c (struct boundary.pos, find_cache_boundary)
1966 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1967 (set_cache_region, invalidate_region_cache)
1968 (revalidate_region_cache, know_region_cache, region_cache_forward)
1969 (region_cache_backward, pp_cache):
1970 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1971 so that ptrdiff_t * can be passed to xpalloc.
1972 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1973 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1974 (pp_cache): Don't assume cache_len fits in int.
1975 * region-cache.h: Adjust extern decls to match.
1977 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1978 EMACS_INT, since either will do, for xpalloc.
1980 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1981 (xnmalloc, xnrealloc, xpalloc): New functions.
1983 * bidi.c (bidi_shelve_header_size): New constant.
1984 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1985 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1987 * bidi.c (bidi_cache_shrink):
1988 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1990 Don't update size of array until after memory allocation succeeds,
1991 because xmalloc/xrealloc may not return.
1992 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1993 now that we have proper integer overflow checking.
1994 (record_overlay_string, overlay_strings): Catch overflows when
1995 calculating size of overlay_str_buf.
1997 * callproc.c (Fcall_process): Check for size overflow when
1998 calculating size of args2.
1999 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2000 Normally we prefer signed values, but sticking with ptrdiff_t would
2001 require adding more-complicated checks.
2003 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2004 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2005 Redo buffer-overflow calculations to avoid integer overflow.
2006 Add a FIXME comment where memory seems to be over-allocated.
2008 * character.c (Fstring): Check for size-calculation overflow.
2010 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2011 unnecessary integer overflow. Check for size overflow.
2012 (encode_coding_object): Don't update size until xmalloc succeeds.
2014 * composite.c (get_composition_id): Check for overflow in glyph
2015 length calculations.
2017 Integer and memory overflow fixes for display code.
2018 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2019 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2020 (scrolling_window): Check for overflow in size calculations.
2021 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2022 Don't assume glyph table len fits in int.
2023 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2024 (row_table_size): Now ptrdiff_t, not int.
2025 (scrolling_window): Avoid overflow in size calculations.
2026 Don't update size until allocation succeeds.
2027 * fns.c (concat): Check for overflow in size calculations.
2028 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2029 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2030 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2032 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2033 (get_doc_string): Check for size calculation overflow.
2034 Don't update size until allocation succeeds.
2035 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2036 EMACS_INT, where ptrdiff_t will do.
2037 (Fsubstitute_command_keys): Check for string overflow.
2039 * editfns.c (set_time_zone_rule): Don't assume environment length
2041 (message_length): Now ptrdiff_t, not int.
2042 (Fmessage_box): Don't update size until allocation succeeds.
2043 Don't assume message length fits in int.
2044 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2046 * emacs.c (main): Do not reallocate argv, since there is a null at
2047 the end that can be overwritten, and this way there's no need to
2048 worry about size-calculation overflow.
2049 (sort_args): Check for size-calculation overflow.
2051 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2053 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2055 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2056 (x_set_scroll_bar_width, x_figure_window_size):
2057 Check for integer overflow.
2058 (x_set_alpha): Do not assume XINT fits in int.
2060 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2061 This is for the members text_lines, text_cols, total_lines, total_cols,
2062 where the system imposes an 'int' limit.
2064 * fringe.c (Fdefine_fringe_bitmap):
2065 Don't update size until alloc works.
2067 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2068 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2070 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2071 Check for size-calculation overflow.
2072 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2073 do, as we prefer signed integers.
2074 (id_to_widget.max_size, id_to_widget.used)
2075 (xg_store_widget_in_map, xg_remove_widget_from_map)
2076 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2077 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2078 Use and return ptrdiff_t, not int.
2079 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2080 * gtkutil.h: Change prototypes to match the above.
2082 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2083 are duplicate now that they've been promoted to lisp.h.
2084 (x_allocate_bitmap_record, x_alloc_image_color)
2085 (make_image_cache, cache_image, xpm_load):
2086 Don't update size until alloc is done.
2087 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2089 Check for size calculation overflow.
2090 (ct_colors_allocated_max): New constant.
2091 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2094 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2095 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2096 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2097 Use ptrdiff_t, not int, to count maps.
2098 (read_char_minibuf_menu_prompt): Check for overflow in size
2099 calculations. Don't update size until allocation succeeds.
2100 Redo calculations to avoid overflow.
2101 * keyboard.h: Change prototypes to match the above.
2103 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2105 (current_minor_maps): Check for size calculation overflow.
2106 * keymap.h: Change prototypes to match the above.
2108 * lread.c (read1, init_obarray): Don't update size until alloc done.
2110 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2111 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2113 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2114 Now ptrdiff_t, not int.
2115 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2116 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2118 * process.c (Fnetwork_interface_list): Check for overflow
2119 in size calculation.
2121 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2123 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2124 overflow. Don't bother calling xmalloc when xrealloc will do.
2126 * search.c (Freplace_match): Check for size calculation overflow.
2127 (Fset_match_data): Don't assume list lengths fit in 'int'.
2129 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2130 for command line length. Do not attempt to address one before the
2131 beginning of an array, as that's not portable.
2133 * term.c (max_frame_lines): Remove; unused.
2134 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2136 (encode_terminal_code, calculate_costs): Check for size
2137 calculation overflow.
2138 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2139 table lengths and related sizes. Don't update size until alloc
2140 done. Redo calculations to avoid overflow.
2141 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2143 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2144 subtracting pointers.
2145 (gobble_line): Check for overflow more carefully. Don't update size
2148 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2149 Don't update size until alloc done.
2150 Redo size calculations to avoid overflow.
2151 Check for size calculation overflow.
2152 (main) [DEBUG]: Fix typo in invoking tparam1.
2154 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2155 Use ptrdiff_t, not int, for sizes.
2156 (store_mode_line_noprop_char): Don't update size until alloc done.
2158 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2159 Use ptrdiff_t, not int, for sizes.
2160 (Finternal_make_lisp_face, cache_face):
2161 Check for size calculation overflow.
2162 (cache_face): Treat size calculation overflows as if they were
2163 memory exhaustion (the usual treatment), rather than aborting.
2165 * xfns.c (x_encode_text, x_set_name_internal)
2166 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2167 sizes, since they can exceed INT_MAX in size. Check for size
2168 calculation overflow.
2170 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2171 (xg_select): Check for size calculation overflow.
2172 Don't update size until alloc done.
2174 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2175 as sprintf is limited to int lengths.
2177 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2178 (X_LONG_MIN): New macros.
2179 Use them to make the following changes clearer.
2180 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2181 This change doesn't affect the value now, but it may help remind
2182 future maintainers not to raise the value too much later.
2183 (SELECTION_QUANTUM): Remove, replacing with ...
2184 (selection_quantum): ... new function, which avoids overflow.
2186 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2187 assumption that selection length fits in 'int'.
2188 (x_reply_selection_request, x_handle_selection_request)
2189 (x_get_window_property, receive_incremental_selection)
2190 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2191 (lisp_data_to_selection_data, clean_local_selection_data):
2192 Use ptrdiff_t, not int, to record length of selection.
2193 (x_reply_selection_request, x_get_window_property)
2194 (receive_incremental_selection, x_property_data_to_lisp):
2195 Redo calculations to avoid overflow.
2196 (x_reply_selection_request): When sending hint, ceiling it at
2197 X_LONG_MAX rather than relying on wraparound overflow to send
2199 (x_get_window_property, receive_incremental_selection)
2200 (lisp_data_to_selection_data, x_property_data_to_lisp):
2201 Check for size-calculation overflow.
2202 (x_get_window_property, receive_incremental_selection)
2203 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2204 Don't store size until memory allocation succeeds.
2205 (x_get_window_property): Plug memory leak on memory exhaustion.
2206 Don't double-block input; malloc is safe here. Don't assume 2**34
2207 - 4 fits in unsigned long. Add an xassert to check
2208 XGetWindowProperty overflow. Be more careful about overflow
2209 calculations, and distinguish size from memory overflow better.
2210 (receive_incremental_selection): When tracing, don't assume
2211 unsigned int is less than INT_MAX.
2212 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2213 harmful) conversions of unsigned short to int.
2214 (lisp_data_to_selection_data): Don't assume that integers
2215 in the range -65535 through -1 fit in an X unsigned short.
2216 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2217 result parameters unless successful. Rely on cons_to_unsigned
2218 to report problems with elements; the old code wasn't right anyway.
2219 (x_check_property_data): Check for int overflow; we cannot use
2220 a wider type due to X limits.
2221 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2223 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2225 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2226 (x_term_init): Check for size calculation overflow.
2227 (x_color_cells): Don't store size until memory allocation succeeds.
2228 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2229 Don't assume alloca size is less than MAX_ALLOCA.
2230 (x_term_init): Don't assume length fits in int (sprintf is limited
2233 Use ptrdiff_t for composition IDs.
2234 * character.c (lisp_string_width):
2235 * composite.c (composition_table_size, n_compositions)
2236 (get_composition_id, composition_gstring_from_id):
2237 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2238 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2239 * window.c (Frecenter):
2240 Use ptrdiff_t, not int, for composition IDs.
2241 * composite.c (get_composition_id): Check for integer overflow.
2242 * composite.h: Adjust prototypes to match the above changes.
2244 Use ptrdiff_t for hash table indexes.
2245 * category.c (hash_get_category_set):
2246 * ccl.c (ccl_driver):
2247 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2248 * coding.c (coding_system_charset_list, detect_coding_system):
2249 * coding.h (struct coding_system.id):
2250 * composite.c (get_composition_id, gstring_lookup_cache):
2251 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2252 * image.c (xpm_get_color_table_h):
2253 * lisp.h (hash_lookup, hash_put):
2254 * minibuf.c (Ftest_completion):
2255 Use ptrdiff_t for hash table indexes, not int (which is too
2256 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2257 32-bit --with-wide-int hosts).
2259 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2260 Add a FIXME comment about memory leaks.
2261 (syms_of_charset): Don't assume xmalloc returns.
2263 Don't assume that stated character widths fit in int.
2264 * character.c (Fchar_width, c_string_width, lisp_string_width):
2265 * character.h (CHAR_WIDTH):
2266 * indent.c (MULTIBYTE_BYTES_WIDTH):
2267 Use sanitize_char_width to avoid undefined and/or bad behavior
2268 with outlandish widths.
2269 * character.h (sanitize_tab_width): Rename from sanitize_width,
2270 now that we have two such functions. All uses changed.
2271 (sanitize_char_width): New inline function.
2273 Don't assume that tab-width fits in int.
2274 * character.h (sanitize_width): New inline function.
2275 (SANE_TAB_WIDTH): New macro.
2276 (ASCII_CHAR_WIDTH): Use it.
2277 * indent.c (sane_tab_width): Remove. All uses replaced by
2278 SANE_TAB_WIDTH (current_buffer).
2279 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2281 * fileio.c: Integer overflow issues with file modes.
2282 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2284 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2285 Remove unreachable code.
2286 (read_hex, load_charset_map_from_file): Check for integer overflow.
2288 * xterm.c: don't go over XClientMessageEvent limit
2289 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2290 (x_send_scroll_bar_event): Likewise. Check that the size does not
2291 exceed limits imposed by XClientMessageEvent, as well as the usual
2292 ptrdiff_t and size_t limits.
2294 * keyboard.c: Overflow, signedness and related fixes.
2295 (make_lispy_movement): Use same integer type in forward decl
2296 that is used in the definition.
2297 (read_key_sequence, keyremap_step):
2298 Change bufsize argument back to int, undoing my 2011-03-30 change.
2299 We prefer signed types, and int is wide enough here.
2300 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2301 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2302 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2303 length, not size_t. Use ptrdiff_t for index, not int.
2304 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2305 possibility of integer overflow.
2307 Overflow, signedness and related fixes for images.
2309 * dispextern.h (struct it.stack[0].u.image.image_id)
2310 (struct_it.image_id, struct image.id, struct image_cache.size)
2311 (struct image_cache.used, struct image_cache.ref_count):
2312 * gtkutil.c (update_frame_tool_bar):
2313 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2314 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2315 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2316 * nsmenu.m (update_frame_tool_bar):
2317 * xdisp.c (calc_pixel_width_or_height):
2318 * xfns.c (image_cache_refcount):
2319 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2320 on typical 64-bit hosts.
2322 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2323 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2324 Omit unnecessary casts to int.
2325 (parse_image_spec): Check that integers fall into 'int' range
2326 when the callers expect that.
2327 (image_ascent): Redo ascent calculation to avoid int overflow.
2328 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2329 (lookup_image): Remove unnecessary tests.
2330 (xbm_image_p): Locals are now of int, not EMACS_INT,
2331 since parse_image_check makes sure they fit into int.
2332 (png_load, gif_load, svg_load_image):
2333 Prefer int to unsigned where either will do.
2334 (tiff_handler): New function, combining the cores of the
2335 old tiff_error_handler and tiff_warning_handler.
2336 This function is rewritten to use vsnprintf and thereby avoid
2337 stack buffer overflows. It uses only the features of vsnprintf
2338 that are common to both POSIX and native Microsoft.
2339 (tiff_error_handler, tiff_warning_handler): Use it.
2340 (tiff_load, gif_load, imagemagick_load_image):
2341 Don't assume :index value fits in 'int'.
2342 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2343 (imagemagick_load_image): Check that crop parameters fit into
2344 the integer types that MagickCropImage accepts. Don't assume
2345 Vimagemagick_render_type has a nonnegative value. Don't assume
2346 size_t fits in 'long'.
2347 (gs_load): Use printmax_t to print the widest integers possible.
2348 Check for integer overflow when computing image height and width.
2350 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2352 * xdisp.c (redisplay_window): Don't force window start if point
2353 will be invisible in the resulting window. (Bug#9324)
2355 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2357 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2358 the display spec is of the form `(space ...)'.
2359 (handle_display_spec): Return the value returned by
2360 handle_single_display_spec, not just 1 or zero.
2361 (handle_single_display_spec): If the display spec is of the form
2362 `(space ...)', and specifies display in the text area, return 2
2364 (try_cursor_movement): Check for the need to scroll more
2365 accurately, and prefer exact match for point under bidi.
2366 Don't advance `row' beyond the last row of the window.
2368 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2369 into disp_prop; all users changed.
2371 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2372 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2373 for the text covered by the display property.
2375 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2377 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2378 Change return value to nil.
2379 (Frecord_buffer): Delete unused function.
2381 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2383 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2384 buffers, return left-to-right.
2385 (set_cursor_from_row): Consider candidate row a win if its glyph
2386 represents a newline and point is on that newline. Fixes cursor
2387 positioning on the newline at EOL of R2L text within L2R
2388 paragraph, and vice versa.
2389 (try_cursor_movement): Check continued rows, in addition to
2390 continuation rows. Fixes unwarranted scroll when point enters a
2391 continued line of R2L text within an L2R paragraph, or vice versa.
2392 (cursor_row_p): Consider the case of point being equal to
2393 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2394 from the end of a short line to the beginning of a continued line
2395 of R2L text within L2R paragraph.
2396 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2397 composed characters.
2399 * bidi.c (bidi_check_type): Use xassert.
2400 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2403 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2405 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2408 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2410 * nsfont.m (ns_otf_to_script): Fix typo.
2412 2011-08-22 Kenichi Handa <handa@m17n.org>
2414 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2415 extra slot even if the purpose is char-code-property-table.
2417 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2419 * xdisp.c (redisplay_window): When computing centering_position,
2420 account for the height of the header line. (Bug#8874)
2422 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2423 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2424 candidate is selected by the mouse, and that candidate has a
2425 composed character under the mouse.
2427 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2428 coordinates reported by pos-visible-in-window-p for a composed
2429 character in column zero.
2431 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2433 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2435 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2437 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2438 consider it a hit if to_charpos is anywhere in the range of the
2439 composed buffer positions.
2441 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2443 * image.c (gif_load): Don't assume that each subimage has the same
2444 dimensions as the base image. Handle disposal method that is
2445 "undefined" by the gif spec (Bug#9335).
2447 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2449 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2450 (Fcondition_case): Document `debug' symbol in error handler.
2452 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2454 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2455 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2456 from an Org mode buffer to a Speedbar frame.
2458 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2459 a composition, take its buffer position from IT->cmp_it.charpos.
2460 Fixes cursor positioning at the beginning of a line that begins
2461 with a composed character.
2463 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2465 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2466 character bidirectional type, use STRONG_L instead. Fixes crashes
2467 in a buffer produced by `describe-categories'.
2469 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2470 members before the level stack, so they would be saved and
2471 restored when copying iterator state. Fixes incorrect reordering
2472 around TABs covered by display properties.
2474 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2476 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2478 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2480 * eval.c (internal_condition_case, internal_condition_case_1)
2481 (internal_condition_case_2, internal_condition_case_n):
2482 Remove unnecessary aborts (Bug#9081).
2484 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2486 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2487 has no `load' handler, try opening the file locally. (Bug#9311)
2489 2011-08-16 Ken Brown <kbrown@cornell.edu>
2491 * gmalloc.c: Expand comment.
2493 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2495 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2496 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2498 2011-08-16 Ken Brown <kbrown@cornell.edu>
2500 Fix memory allocation problems in Cygwin build (Bug#9273).
2502 * unexcw.c ( __malloc_initialized): Declare external variable.
2503 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2505 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2507 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2509 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2511 [CYGWIN] (special_realloc): New function.
2512 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2513 requests to realloc storage in the static heap.
2515 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2517 * bidi.c (bidi_initialize): Remove unused local.
2519 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2522 * biditype.h: Remove file.
2523 * makefile.w32-in ($(BLD)/bidi.$(O)):
2524 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2526 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2528 * chartab.c: Improve commentary for the uniprop_table API.
2530 * bidi.c (bidi_paragraph_init): Support zero value of
2531 bidi_ignore_explicit_marks_for_paragraph_level.
2532 (bidi_initialize): Use uniprop_table instead of including
2533 biditype.h and bidimirror.h.
2535 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2536 coordinates of the iterator when restoring from ppos_it.
2539 2011-08-14 Kenichi Handa <handa@m17n.org>
2541 * process.c (create_process): Call setup_process_coding_systems
2542 after the pid of the process is set to -1 (Bug#8162).
2544 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2546 * xdisp.c (move_it_in_display_line_to): Don't invoke
2547 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2548 ppos_it. Fixes vertical cursor motion when line beginning is
2549 covered by an image. (Bug#9296)
2551 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2553 * nsterm.h (ns_run_ascript): Declare.
2554 (NSAPP_DATA2_RUNASSCRIPT): Define.
2556 * nsfns.m (as_script, as_result, as_status): New static variables.
2557 (ns_run_ascript): New function.
2558 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2559 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2560 the event loop. Get status from as_status (Bug#7276).
2562 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2563 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2564 the event loop (Bug#7276).
2566 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2568 * gnutls.c (QCgnutls_bootprop_priority)
2569 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2570 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2571 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2572 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2573 (QCgnutls_bootprop_verify_hostname_error)
2574 (QCgnutls_bootprop_callbacks_verify): Rename from
2575 Qgnutls_bootprop_..., all uses changed.
2577 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2580 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2582 * xfaces.c (Qframe_set_background_mode): Now static.
2583 * dispextern.h (Qframe_set_background_mode): Remove decl.
2585 * process.c (Fnetwork_interface_info): Declare local only if needed.
2587 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2589 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2590 (Fnetwork_interface_list): Allocate in increments of bytes instead
2591 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2592 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2594 (struct ifflag_def): notrailers is smart on OSX.
2595 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2596 Get hardware address with getifaddrs if available.
2598 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2600 * xdisp.c (iterate_out_of_display_property): xassert that
2601 IT->position is set to within IT->object's boundaries. Break from
2602 the loop as soon as EOB is reached; avoids infloops in redisplay
2603 when IT->position is set up wrongly due to some bug.
2604 Set IT->current to match the bidi iterator unconditionally.
2605 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2606 entry. Force push_it to save on the stack the current
2607 buffer/string position, to be restored by pop_it. Fix flags in
2608 the iterator structure wrt the object coming from a display
2609 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2610 properties. (Bug#9284)
2612 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2614 * fontset.c (fontset_get_font_group): Add proper type checks.
2617 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2619 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2620 and LC_VERSION_MIN_MACOSX.
2621 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2622 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2624 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2626 * xdisp.c (forward_to_next_line_start): Allow to use the
2627 no-display-properties-and-no-overlays under bidi display.
2628 Set disp_pos in the bidi iterator to avoid searches for display
2629 properties and overlays.
2631 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2633 * editfns.c (Fset_time_zone_rule): Document relationship with the
2636 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2637 the font entity extracted from the cache (Bug#8109).
2639 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2641 * composite.c (autocmp_chars): Don't reset point. That is done by
2642 restore_point_unwind (Bug#5984).
2644 2011-08-07 Juri Linkov <juri@jurta.org>
2646 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2647 to show the arg `TIME' instead of `TIMEVAL'.
2649 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2651 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2652 display property strides EOL and includes a newline, as in
2653 longlines-mode. (Bug#9254)
2654 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2655 word-wrap under bidirectional display. (Bug#9224)
2657 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2658 is non-zero, even if the data buffer is NULL. Fixes a crash in
2659 vertical-motion with longlines-mode. (Bug#9254)
2661 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2663 * bidi.c <bidi_cache_total_alloc>: Now static.
2664 (bidi_initialize): Initialize bidi_cache_total_alloc.
2666 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2669 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2670 amount allocated this far in `bidi_cache_total_alloc'.
2671 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2672 non-zero, only free the data buffer without restoring the cache
2673 contents. All callers changed.
2675 * dispextern.h (bidi_unshelve_cache): Update prototype.
2677 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2678 (move_it_in_display_line, move_it_to)
2679 (move_it_vertically_backward, move_it_by_lines): Replace the call
2680 to xfree to an equivalent call to bidi_unshelve_cache.
2681 (move_it_in_display_line_to): Fix logic of returning
2682 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2684 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2686 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2687 came from a string character with a `cursor' property. (Bug#9229)
2689 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2691 * Makefile.in (LIB_PTHREAD): New variable.
2692 (LIBES): Add LIB_PTHREAD (Bug#9216).
2694 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2695 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2697 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2699 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2701 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2703 * xterm.c (x_find_topmost_parent): New function.
2704 (x_set_frame_alpha): Find topmost parent window with
2705 x_find_topmost_parent and set the property there also (bug#9181).
2706 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2708 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2710 * callproc.c (Fcall_process): Avoid vfork clobbering
2711 the local vars buffer, coding_systems, current_dir.
2713 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2715 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2717 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2719 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2720 so that it is not optimized away.
2722 * xdisp.c (compute_display_string_pos): Remove unused local.
2724 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2726 Fix slow cursor motion and scrolling in large buffers with
2727 selective display, like Org Mode buffers. (Bug#9218)
2729 * dispextern.h (struct bidi_it): New member disp_prop_p.
2731 * xdisp.c: Remove one-slot cache of display string positions.
2732 (compute_display_string_pos): Accept an additional argument
2733 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2734 for a display string or property. If found, set DISP_PROP_P
2737 * bidi.c (bidi_fetch_char): Accept an additional argument
2738 DISP_PROP_P, and pass it to compute_display_string_pos.
2739 Only handle text covered by a display string if DISP_PROP_P is returned
2740 non-zero. All callers of bidi_fetch_char changed.
2742 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2744 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2746 2010-12-03 Don March <don@ohspite.net>
2748 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2749 last character M-[char] is translated to ESC [char] (bug#7541).
2751 2011-08-02 Kenichi Handa <handa@m17n.org>
2753 * lisp.h (uniprop_table): Extern it.
2755 * chartab.c (uniprop_table): Make it non-static.
2757 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2759 * xdisp.c (forward_to_next_line_start): Accept additional argument
2760 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2762 (reseat_at_next_visible_line_start): Use the bidi iterator state
2763 returned by forward_to_next_line_start to restore the state of
2764 it->bidi_it after backing up to previous newline. (Bug#9212)
2766 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2768 * regex.c (re_comp): Protoize.
2769 (re_exec): Fix return type.
2770 (regexec): Fix type of `ret'. (Bug#9203)
2772 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2774 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2775 This is needed if max-image-size is a floating-point number.
2777 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2779 * print.c (print_object): Print empty symbol as ##.
2781 * lread.c (read1): Read ## as empty symbol.
2783 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2785 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2786 setting frame foreground color (Bug#9175).
2787 (x_set_background_color): Likewise.
2789 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2790 contents (Bug#9176).
2791 (EmacsTooltip -init): Remove bezels and add shadows to
2794 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2795 or scroll bar (Bug#8470).
2797 * nsfont.m (nsfont_open): Remove assignment to voffset and
2798 unnecessary vars hshink, expand, hd, full_height, min_height.
2799 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2801 * nsterm.h (nsfont_info): Remove voffset field.
2803 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2805 Implement strike-through and overline on NextStep (Bug#8863).
2807 * nsfont.m (nsfont_open): Use underline position provided by font,
2808 instead of hard-coded value of 2.
2809 (nsfont_draw): Call ns_draw_text_decoration instead.
2811 * nsterm.h: Add declaration for ns_draw_text_decoration.
2813 * nsterm.m (ns_draw_text_decoration): New function for drawing
2814 underline, overline, and strike-through.
2815 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2816 ns_draw_text_decoration. Change treatment of cursor drawing to
2817 accommodate underlining, etc.
2819 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2821 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2824 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2826 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2827 Without this fix, if a signal arrives just after memory fills up,
2828 'malloc' might be invoked reentrantly.
2830 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2831 In other words, assume that every image size is allowed, on non-X
2832 hosts. This assumption is probably wrong, but it lets Emacs compile.
2834 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2836 * regex.c (re_iswctype): Convert return values to boolean.
2838 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2840 * xdisp.c (compute_display_string_pos): Don't use cached display
2841 string position if the buffer had its restriction changed.
2844 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2846 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2848 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2850 Integer signedness and overflow and related fixes. (Bug#9079)
2852 * bidi.c: Integer size and overflow fixes.
2853 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2854 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2855 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2856 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2857 (bidi_find_other_level_edge):
2858 Use ptrdiff_t instead of EMACS_INT where either will do.
2859 This works better on 32-bit hosts configured --with-wide-int.
2860 (bidi_cache_ensure_space): Check for size-calculation overflow.
2861 Use % rather than repeated addition, for better worst-case speed.
2862 Don't set bidi_cache_size until after xrealloc returns, because it
2864 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2865 (bidi_cache_ensure_space): Also check that the bidi cache size
2866 does not exceed that of the largest Lisp string or buffer. See Eli
2867 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2869 * alloc.c (__malloc_size_t): Remove.
2870 All uses replaced by size_t. See Andreas Schwab's note
2871 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2873 * image.c: Improve checking for integer overflow.
2874 (check_image_size): Assume that f is nonnull, since
2875 it is always nonnull in practice. This is one less thing to
2876 worry about when checking for integer overflow later.
2877 (x_check_image_size): New function, which checks for integer
2878 overflow issues inside X.
2879 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2880 This removes the need for a memory_full check.
2881 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2882 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2883 (xbm_read_bitmap_data): Change locals back to 'int', since
2884 their values must fit in 'int'.
2885 (xpm_load_image, png_load, tiff_load):
2886 Invoke x_create_x_image_and_pixmap earlier,
2887 to avoid much needless work if the image is too large.
2888 (tiff_load): Treat overly large images as if
2889 x_create_x_image_and_pixmap failed, not as malloc failures.
2890 (gs_load): Use x_check_image_size.
2892 * gtkutil.c: Omit integer casts.
2893 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2894 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2896 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2898 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2899 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2900 would wrongly return t on a 64-bit host.
2902 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2903 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2904 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2905 and therefore cause GCC to emit a bogus diagnostic in some cases.
2907 * image.c: Integer signedness and overflow and related fixes.
2908 This is not an exhaustive set of fixes, but it's time to
2909 record what I've got.
2910 (lookup_pixel_color, check_image_size): Remove redundant decls.
2911 (check_image_size): Don't assume that arbitrary EMACS_INT values
2912 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2913 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2914 (tiff_load, imagemagick_load_image):
2915 Check for overflow in size calculations.
2916 (x_create_x_image_and_pixmap): Remove unnecessary test for
2917 xmalloc returning NULL; that can't happen.
2918 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2919 (xpm_color_bucket): Use better integer hashing function.
2920 (xpm_cache_color): Don't possibly over-allocate memory.
2921 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2922 (gif_memory_source):
2923 Use ptrdiff_t, not int or size_t, to record sizes.
2924 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2925 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2926 either works, as we prefer signed integers.
2927 (tiff_read_from_memory, tiff_write_from_memory):
2928 Return tsize_t, not size_t, since that's what the TIFF API wants.
2929 (tiff_read_from_memory): Don't fail simply because the read would
2930 go past EOF; instead, return a short read.
2931 (tiff_load): Omit no-longer-needed casts.
2932 (Fimagemagick_types): Don't assume size fits into 'int'.
2934 Improve hashing quality when configured --with-wide-int.
2935 * fns.c (hash_string): New function, taken from sxhash_string.
2936 Do not discard information about ASCII character case; this
2937 discarding is no longer needed.
2938 (sxhash-string): Use it. Change sig to match it. Caller changed.
2939 * lisp.h: Declare it.
2940 * lread.c (hash_string): Remove, since we now use fns.c's version.
2941 The fns.c version returns a wider integer if --with-wide-int is
2942 specified, so this should help the quality of the hashing a bit.
2944 * emacs.c: Integer overflow minor fix.
2945 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2946 Define only if GNU_LINUX.
2947 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2949 * dispnew.c: Integer signedness and overflow fixes.
2950 Remove unnecessary forward decls, that were a maintenance hassle.
2951 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2953 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2954 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2955 (prepare_desired_row, line_draw_cost):
2956 Use int, not unsigned, where either works.
2957 (save_current_matrix, restore_current_matrix):
2958 Use ptrdiff_t, not size_t, where either works.
2959 (init_display): Check for overflow more accurately, and without
2960 relying on undefined behavior.
2962 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2963 Remove, replacing with the new symbols in lisp.h. All uses changed.
2964 * fileio.c (make_temp_name):
2965 * filelock.c (lock_file_1, lock_file):
2966 * xdisp.c (message_dolog):
2967 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2968 Use pMd etc. instead.
2969 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2970 replacing the pWIDE etc. symbols removed from editfns.c.
2972 * keyboard.h (num_input_events): Now uintmax_t.
2973 This is (very slightly) less likely to mess up due to wraparound.
2976 * buffer.c: Integer signedness fixes.
2977 (alloc_buffer_text, enlarge_buffer_text):
2978 Use ptrdiff_t rather than size_t when either will do, as we prefer
2981 * alloc.c: Integer signedness and overflow fixes.
2982 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2983 (__malloc_size_t): Default to size_t, not to int.
2984 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2985 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2986 Prefer ptrdiff_t to size_t when either would do, as we prefer
2988 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2989 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2990 Now const. Initialize with values that are in range even if char
2992 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2993 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2994 These functions do the right thing with sizes > 2**32.
2995 (check_depth): Now ptrdiff_t, not int.
2996 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2997 Adjust to new way of storing sizes. Check for size overflow bugs
2999 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3000 slightly wrong anyway, as it missed one instance of
3001 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3002 (refill_memory_reserve): Omit needless cast to size_t.
3003 (mark_object_loop_halt): Mark as externally visible.
3005 * xselect.c: Integer signedness and overflow fixes.
3006 (Fx_register_dnd_atom, x_handle_dnd_message):
3007 Use ptrdiff_t, not size_t, since we prefer signed.
3008 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3009 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3010 x_dnd_atoms_size and x_dnd_atoms_length.
3012 * doprnt.c: Prefer signed to unsigned when either works.
3014 * doprnt.c (doprnt):
3016 * xdisp.c (vmessage):
3017 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3018 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3019 prefer signed arithmetic to avoid comparison confusion.
3020 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3021 but is a bit tricky.
3023 Assume freestanding C89 headers, string.h, stdlib.h.
3024 * data.c, doprnt.c, floatfns.c, print.c:
3025 Include float.h unconditionally.
3026 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3027 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3028 * regex.c: Likewise for stddef.h, string.h.
3029 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3030 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3031 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3032 (STDC_HEADERS): Remove obsolete defines.
3033 * sysdep.c: Include limits.h unconditionally.
3035 Assume support for memcmp, memcpy, memmove, memset.
3036 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3037 * regex.c (memcmp, memcpy):
3038 Remove; we assume C89 now.
3040 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3041 (__malloc_safe_bcopy): Remove; no longer needed.
3043 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3044 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3045 well either way, and we prefer signed to unsigned.
3047 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3049 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3050 closes the connection while we're reading (bug#9182).
3052 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3054 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3055 are specified (Bug#9168).
3057 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3059 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3060 Found by GCC static checking and --with-wide-int on a 32-bit host.
3062 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3064 * xdisp.c (compute_display_string_pos): Fix logic of caching
3065 previous display string position. Initialize cached_prev_pos to
3066 -1. Fixes slow-down at the beginning of a buffer.
3068 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3070 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3071 for attrs[LFACE_FONTSET_INDEX].
3073 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3075 * xml.c (parse_region): Remove unused local
3076 that was recently introduced.
3078 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3080 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3081 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3083 * xdisp.c (move_it_in_display_line_to): Record the best matching
3084 position for TO_CHARPOS while scanning the line, and restore it on
3085 exit if none of the characters scanned was an exact match.
3086 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3087 when exact match is impossible due to invisible text, and the
3088 lines are truncated.
3090 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3092 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3095 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3097 Fix a significant slow-down of cursor motion with C-n, C-p,
3098 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3099 auto-repeat under bidi redisplay in fontified buffers.
3100 * xdisp.c (compute_stop_pos_backwards): New function.
3101 (next_element_from_buffer): Call compute_stop_pos_backwards to
3102 find a suitable prev_stop when we find ourselves before
3104 (reseat): Don't look for prev_stop, as that could mean a very long
3106 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3107 <cached_disp_overlay_modiff>: Cache for last found display string
3109 (compute_display_string_pos): Return the cached position if asked
3110 about the same buffer in the same area of character positions, and
3111 the buffer wasn't changed since the time the display string
3112 position was cached.
3114 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3116 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3117 is an integer, which is important for empty lines. (Bug#9149)
3119 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3121 * frame.c (Fmodify_frame_parameters): In tty case, update the
3122 default face if necessary (Bug#4238).
3124 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3126 * editfns.c (Fstring_to_char): No need to explain what a character
3127 is in the docstring (Bug#6576).
3129 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3131 * xml.c (parse_region): Make sure we always return a tree.
3133 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3135 * xml.c (parse_region): If a document contains only comments,
3138 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3140 * xml.c (make_dom): Return comments, too.
3142 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3145 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3146 and the surrounding thread.
3147 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3148 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3149 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3151 * s/openbsd.h (BROKEN_SIGIO): Define.
3152 * unexelf.c (unexec) [__OpenBSD__]:
3153 Don't update the .mdebug section of the Alpha COFF symbol table.
3155 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3157 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3160 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3162 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3163 This fixes some race conditions on the permissions of any newly
3166 * alloc.c (valid_pointer_p): Use pipe, not open.
3167 This fixes some permissions issues when debugging.
3169 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3170 If fchown fails to set both uid and gid, try to set just gid,
3171 as that is sometimes allowed. Adjust the file's mode to eliminate
3172 setuid or setgid bits that are inappropriate if fchown fails.
3174 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3176 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3177 to compare Lisp_Objects.
3178 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3179 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3180 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3182 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3184 * lread.c (read_integer): Unread even EOF character.
3185 (read1): Likewise. Properly record start position of symbol.
3187 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3188 symbol character follows.
3190 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3192 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3193 This works around a problem with the previous change to Fcopy_file.
3194 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3195 and without this change, GCC might complain about discarding
3196 fchown's return value.
3198 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3200 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3202 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3204 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3206 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3208 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3209 it's used from the C level.
3211 * process.c: Use the same condition for POLL_FOR_INPUT in both
3212 keyboard.c and process.c (bug#1858).
3214 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3216 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3217 (Fgnutls_boot): Use it.
3219 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3221 * doc.c (Fsubstitute_command_keys): Revert last change.
3223 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3225 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3226 quotes the next character, and doesn't affect other longer
3227 sequences (bug#8935).
3229 * lread.c (syms_of_lread): Clarify that is isn't only
3230 `eval-buffer' and `eval-defun' that's affected by
3231 `lexical-binding' (bug#8460).
3233 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3235 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3236 bidi redisplay when a line includes both an image and is truncated.
3238 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3240 Fix minor problems found by static checking.
3241 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3242 (elsz): Now a signed constant, not a size_t var. We prefer signed
3243 types to unsigned, to avoid integer comparison confusion. Without
3244 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3245 "cannot optimize loop, the loop counter may overflow", a symptom
3247 * indent.c (Fvertical_motion): Mark locals as initialized.
3248 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3250 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3252 * search.c (Fre_search_backward): Mention `case-fold-search' in
3253 all the re_search_* functions (bug#8138).
3255 * keyboard.c (Fopen_dribble_file): Document when the file is
3258 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3260 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3263 Support bidi reordering of display and overlay strings.
3264 * xdisp.c (compute_display_string_pos)
3265 (compute_display_string_end): Accept additional argument STRING.
3266 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3267 (reseat_to_string): Initialize bidi_it->string.s and
3268 bidi_it->string.schars.
3269 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3270 NULL (avoids a crash in bidi_paragraph_init).
3271 Initialize itb.string.lstring.
3272 (init_iterator): Call bidi_init_it only of a valid
3273 buffer position was specified. Initialize paragraph_embedding to
3275 (reseat_to_string): Initialize the bidi iterator.
3276 (display_string): If we need to ignore text properties of
3277 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3278 original value of -1 will not work with bidi.)
3279 (compute_display_string_pos): First arg is now struct
3280 `text_pos *'; all callers changed. Support display properties on
3282 (compute_display_string_end): Support display properties on Lisp
3284 (init_iterator, reseat_1, reseat_to_string): Initialize the
3285 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3286 when iterating on a string not from display properties).
3287 (compute_display_string_pos, compute_display_string_end):
3288 Fix calculation of the object to scan. Fixes an error when using
3290 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3291 base_level_stop; instead, set base_level_stop to BEGV.
3292 Fixes crashes in vertical-motion.
3293 (next_element_from_buffer): Improve commentary for when
3294 the iterator is before prev_stop.
3295 (init_iterator): Initialize bidi_p from the default value of
3296 bidi-display-reordering, not from buffer-local value. Use the
3297 buffer-local value only if initializing for buffer iteration.
3298 (handle_invisible_prop): Support invisible properties on strings
3299 that are being bidi-reordered.
3300 (set_iterator_to_next): Support bidi reordering of C strings and
3302 (next_element_from_string): Support bidi reordering of Lisp
3304 (handle_stop_backwards): Support Lisp strings as well.
3305 (display_string): Support display of R2L glyph rows.
3306 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3307 (init_iterator): Don't initialize it->bidi_p for strings
3309 (reseat_to_string): Initialize it->bidi_p for strings here.
3310 (next_element_from_string, next_element_from_c_string)
3311 (next_element_from_buffer): Add xassert's for correspondence
3312 between IT's object being iterated and it->bidi_it.string
3314 (face_before_or_after_it_pos): Support bidi iteration.
3315 (next_element_from_c_string): Handle the case of the first string
3316 character that is not the first one in the visual order.
3317 (get_visually_first_element): New function, refactored from common
3318 parts of next_element_from_buffer, next_element_from_string, and
3319 next_element_from_c_string.
3320 (tool_bar_lines_needed, redisplay_tool_bar)
3321 (display_menu_bar): Force left-to-right direction. Add a FIXME
3322 comment for making that be controlled by a user option.
3323 (push_it, pop_it): Save and restore the state of the
3324 bidi iterator. Save and restore the bidi_p flag.
3325 (pop_it): Iterate out of display property for string iteration as
3327 (iterate_out_of_display_property): Support iteration over strings.
3328 (handle_single_display_spec): Set up it->bidi_it for iteration
3329 over a display string, and call bidi_init_it.
3330 (handle_single_display_spec, next_overlay_string)
3331 (get_overlay_strings_1, push_display_prop): Set up the bidi
3332 iterator for displaying display or overlay strings.
3333 (forward_to_next_line_start): Don't use the shortcut if
3335 (back_to_previous_visible_line_start): If handle_display_prop
3336 pushed the iterator stack, restore the internal state of the bidi
3337 iterator by calling bidi_pop_it same number of times.
3338 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3339 and we are bidi-iterating, don't decrement the iterator position;
3340 instead, set the first_elt flag in the bidi iterator, to produce
3342 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3343 (push_display_prop): xassert that we are iterating a buffer.
3344 (push_it, pop_it): Save and restore paragraph_embedding member.
3345 (handle_single_display_spec, next_overlay_string)
3346 (get_overlay_strings_1, reseat_1, reseat_to_string)
3347 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3348 correctly. Don't assume unibyte strings are not bidi-reordered.
3349 (compute_display_string_pos)
3350 (compute_display_string_end): Fix handling the case of C string.
3351 (push_it, pop_it): Save and restore from_disp_prop_p.
3352 (handle_single_display_spec, push_display_prop): Set the
3353 from_disp_prop_p flag.
3354 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3355 (pop_it): Call iterate_out_of_display_property only if we are
3356 popping after iteration over a string that came from a display
3357 property. Fix a typo in popping stretch info. Add an assertion
3358 for verifying that the iterator position is in sync with the bidi
3360 (handle_single_display_spec, get_overlay_strings_1)
3361 (push_display_prop): Fix initialization of paragraph direction for
3362 string when that of the parent object is not yet determined.
3363 (reseat_1): Call bidi_init_it to resync the bidi
3364 iterator with IT's position. (Bug#7616)
3365 (find_row_edges): If ROW->start.pos gives position
3366 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3367 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3368 Reset the from_disp_prop_p flag.
3369 (SAVE_IT, RESTORE_IT): New macros.
3370 (pos_visible_p, face_before_or_after_it_pos)
3371 (back_to_previous_visible_line_start)
3372 (move_it_in_display_line_to, move_it_in_display_line)
3373 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3374 (try_scrolling, redisplay_window, display_line): Use them when
3375 saving a temporary copy of the iterator and restoring it back.
3376 (back_to_previous_visible_line_start, reseat_1)
3377 (init_iterator): Empty the bidi cache "stack".
3378 (move_it_in_display_line_to): If iterator ended up at
3379 EOL, but we never saw any buffer positions smaller than
3380 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3381 motion in bidi-reordered lines.
3382 (move_it_in_display_line_to): Record prev_method and prev_pos
3383 immediately before the call to set_iterator_to_next. Fixes cursor
3384 motion in bidi-reordered lines with stretch glyphs and strings
3385 displayed in margins. (Bug#8133) (Bug#8867)
3386 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3388 (pos_visible_p): Support positions in bidi-reordered lines.
3389 Save and restore bidi cache.
3391 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3392 (bidi_paragraph_info): Delete unused struct.
3393 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3394 (bidi_cache_start): New variable.
3395 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3397 (bidi_cache_fetch_state, bidi_cache_search)
3398 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3399 (bidi_cache_find, bidi_peek_at_next_level)
3400 (bidi_level_of_next_char, bidi_find_other_level_edge)
3401 (bidi_move_to_visually_next): Compare cache index with
3402 bidi_cache_start rather than with zero.
3403 (bidi_fetch_char): Accept new argument STRING; all callers
3404 changed. Support iteration over a string. Support strings with
3405 display properties. Support unibyte strings. Fix the type of
3406 `len' according to what STRING_CHAR_AND_LENGTH expects.
3407 (bidi_paragraph_init, bidi_resolve_explicit_1)
3408 (bidi_resolve_explicit, bidi_resolve_weak)
3409 (bidi_level_of_next_char, bidi_move_to_visually_next):
3410 Support iteration over a string.
3411 (bidi_set_sor_type, bidi_resolve_explicit_1)
3412 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3413 can now be zero (for strings); special values 0 and -1 were
3414 changed to -1 and -2, respectively.
3415 (bidi_char_at_pos): New function.
3416 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3417 Call it instead of FETCH_MULTIBYTE_CHAR.
3418 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3419 initialized to valid values.
3420 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3422 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3423 the test for valid cached positions. Fix the logic for looking up
3424 the sentinel state in the cache. GCPRO the Lisp string we are
3426 (bidi_push_it, bidi_pop_it): New functions.
3427 (bidi_initialize): Initialize the bidi cache start stack pointer.
3428 (bidi_cache_ensure_space): New function, refactored from part of
3429 bidi_cache_iterator_state. Don't assume the required size is just
3430 one BIDI_CACHE_CHUNK away.
3431 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3432 (bidi_count_bytes, bidi_char_at_pos): New functions.
3433 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3434 always valid if bidi_cache_idx is valid.
3435 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3436 is valid if it's going to be used.
3437 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3438 (bidi_cache_fetch_state, bidi_cache_search)
3439 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3440 (bidi_cache_iterator_state, bidi_cache_find)
3441 (bidi_find_other_level_edge, bidi_cache_start_stack):
3442 All variables related to cache indices are now EMACS_INT.
3444 * dispextern.h (struct bidi_string_data): New structure.
3445 (struct bidi_it): New member `string'. Make flag members be 1-bit
3446 fields, and put them last in the struct.
3447 (compute_display_string_pos, compute_display_string_end):
3449 (bidi_push_it, bidi_pop_it): Add prototypes.
3450 (struct iterator_stack_entry): New members bidi_p,
3451 paragraph_embedding, and from_disp_prop_p.
3452 (struct it): Member bidi_p is now a bit field 1 bit wide.
3453 (bidi_shelve_cache, bidi_unshelve_cache):
3456 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3457 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3458 and vector-like objects.
3460 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3461 cache around display iteration.
3463 * window.c (Fwindow_end, window_scroll_pixel_based)
3464 (displayed_window_lines, Frecenter): Save and restore the bidi
3465 cache around display iteration.
3467 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3469 * editfns.c (Fdelete_region): Clarify the use of the named
3470 parameters (bug#6788).
3472 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3474 * indent.c (Fvertical_motion): Set and restore w->pointm when
3475 saving and restoring the window's buffer (Bug#9006).
3477 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3479 * editfns.c (Fstring_to_char): Clarify just what is returned
3480 (bug#6576). Text by Eli Zaretskii.
3482 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3484 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3486 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3488 * buffer.c (mmap_find): Fix a typo.
3490 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3492 Fix execution of x selection hooks.
3493 * xselect.c (Qx_lost_selection_functions)
3494 (Qx_sent_selection_functions): New vars.
3495 (syms_of_xselect): DEFSYM them.
3496 (x_handle_selection_request): Pass Qx_sent_selection_functions
3497 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3498 (x_handle_selection_clear,x_clear_frame_selections):
3499 Pass Qx_lost_selection_functions rather than
3500 Vx_lost_selection_functions to Frun_hook_with_args.
3502 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3504 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3505 The old code sometimes used this field without initializing it.
3507 * alloc.c (gc_sweep): Don't read past end of array.
3508 In theory, the old code could also have corrupted Emacs internals,
3509 though it'd be very unlikely.
3511 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3513 * character.c (Fcharacterp): Don't advertise optional ignored
3514 argument. (Bug#4026)
3516 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3518 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3521 * window.c (Fset_window_start): Doc fix (bug#4199).
3522 (Fset_window_hscroll): Ditto.
3524 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3526 Fix minor new problems caught by GCC 4.6.1.
3527 * term.c (init_tty): Remove unused local.
3528 * xsettings.c (store_monospaced_changed): Define this function only
3529 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3532 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3534 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3536 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3538 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3539 are the mini-buffer and the echo area (bug#3320).
3541 * term.c (init_tty): Remove support for supdup, c10 and perq
3542 terminals, which are no longer supported (bug#1482).
3544 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3546 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3548 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3550 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3551 for non-popups (Bug#3642).
3553 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3555 * alloc.c (reset_malloc_hooks): Protoize.
3556 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3557 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3558 * cm.c (losecursor): Likewise.
3559 * data.c (fmod): Likewise.
3560 * dispnew.c (swap_glyphs_in_rows): Likewise.
3561 * emacs.c (memory_warning_signal): Likewise.
3562 * floatfns.c (float_error): Likewise.
3563 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3564 (otf_open, font_otf_capability, generate_otf_features)
3565 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3567 * image.c (pbm_read_file): Likewise.
3568 * indent.c (string_display_width): Likewise.
3569 * intervals.c (check_for_interval, search_for_interval)
3570 (inc_interval_count, count_intervals, root_interval)
3571 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3572 * lread.c (defalias): Likewise.
3573 * ralloc.c (r_alloc_check): Likewise.
3574 * regex.c (set_image_of_range_1, set_image_of_range)
3575 (regex_grow_registers): Likewise.
3576 * sysdep.c (strerror): Likewise.
3577 * termcap.c (valid_filename_p, tprint, main): Likewise.
3578 * tparam.c (main): Likewise.
3579 * unexhp9k800.c (run_time_remap, save_data_space)
3580 (update_file_ptrs, read_header, write_header, calculate_checksum)
3581 (copy_file, copy_rest, display_header): Likewise.
3582 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3584 * xdisp.c (check_it): Likewise.
3585 * xfaces.c (register_color, unregister_color, unregister_colors):
3587 * xfns.c (print_fontset_result): Likewise.
3588 * xrdb.c (member, fatal, main): Likewise.
3590 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3592 Fix minor problems found by static checking (Bug#9031).
3593 * chartab.c (char_table_set_range, map_sub_char_table):
3594 Remove unused locals.
3595 (uniprop_table): Now static.
3596 * composite.c (_work_char): Remove unused static var.
3598 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3600 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3602 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3604 * gtkutil.c (qttip_cb): Remove code without function.
3606 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3608 * w32.c (pthread_sigmask): New stub.
3610 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3612 Use pthread_sigmask, not sigprocmask (Bug#9010).
3613 sigprocmask is portable only for single-threaded applications, and
3614 Emacs can be multi-threaded when it uses GTK.
3615 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3617 * callproc.c (Fcall_process):
3618 * process.c (create_process):
3619 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3620 Use pthread_sigmask, not sigprocmask.
3622 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3624 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3625 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3628 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3630 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3631 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3632 (xg_hide_tooltip): Fix comment.
3634 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3635 in registerServicesMenuSendTypes.
3636 (validRequestorForSendType): Don't check ns_return_types.
3638 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3641 2011-07-08 Jason Rumney <jasonr@gnu.org>
3643 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3644 SH_SHOW for hidden windows (Bug#5482).
3646 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3647 frame struct members of non-existent frames (Bug#6284).
3649 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3651 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3652 variable firstTime not needed on OSX >= 10.6.
3653 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3654 >= 10.5. Use setKnobProportion, setDoubleValue.
3656 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3657 (MAC_OS_X_VERSION_10_5): Define if not defined.
3658 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3659 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3660 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3662 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3663 cString and lossyCString on OSX >= 10.4
3665 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3666 sizeToFit on OSX >= 10.2.
3668 * nsimage.m (allocInitFromFile): Don't use deprecated method
3669 bestRepresentationForDevice on OSX >= 10.6.
3671 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3674 * emacs.c: Declare unexec_init_emacs_zone.
3676 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3678 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3680 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3681 on svcsMenu (Bug#8842).
3683 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3685 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3687 * nsterm.m (QUTF8_STRING): Declare.
3688 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3689 (validRequestorForSendType): Return type is (id).
3690 Change indexOfObjectIdenticalTo to indexOfObject.
3691 Check if we have local selection before returning self (Bug#8842).
3692 (writeSelectionToPasteboard): Put local selection into paste board
3693 if we have a local selection (Bug#8842).
3694 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3696 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3697 (ns_get_local_selection): Declare.
3699 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3701 * keymap.c (describe_map_tree): Don't insert a double newline at
3702 the end of the buffer (bug#1169) and return whether we inserted
3705 * callint.c (Fcall_interactively): Change "reading args" to
3706 "providing args" to try to clarify what it does (bug#1010).
3708 2011-07-07 Kenichi Handa <handa@m17n.org>
3710 * composite.c (composition_compute_stop_pos): Ignore a static
3711 composition starting before CHARPOS (Bug#8915).
3713 * xdisp.c (handle_composition_prop): Likewise.
3715 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3717 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3720 2011-07-07 Kenichi Handa <handa@m17n.org>
3722 * character.h (unicode_category_t): New enum type.
3724 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3725 (Qchar_code_property_table): New variable.
3726 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3727 (UNIPROP_COMPRESSED_FORM_P): New macros.
3728 (char_table_ascii): Uncompress the compressed values.
3729 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3730 Uncompress the compressed values.
3731 (sub_char_table_ref_and_range): Likewise.
3732 (char_table_ref_and_range): Uncompress the compressed values.
3733 (sub_char_table_set): New arg is_uniprop. Callers changed.
3734 Uncompress the compressed values.
3735 (sub_char_table_set_range): Args changed. Callers changed.
3736 (char_table_set_range): Adjuted for the above change.
3737 (map_sub_char_table): Delete args default_val and parent. Add arg
3738 top. Give decoded values to a Lisp function.
3739 (map_char_table): Adjust for the above change. Give decoded
3740 values to a Lisp function. Gcpro more variables.
3741 (uniprop_table_uncompress)
3742 (uniprop_decode_value_run_length): New functions.
3743 (uniprop_decoder, uniprop_decoder_count): New variables.
3744 (uniprop_get_decoder, uniprop_encode_value_character)
3745 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3747 (uniprop_encoder, uniprop_encoder_count): New variables.
3748 (uniprop_get_encoder, uniprop_table)
3749 (Funicode_property_table_internal, Fget_unicode_property_internal)
3750 (Fput_unicode_property_internal): New functions.
3751 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3752 Sunicode_property_table_internal, Sget_unicode_property_internal,
3753 and Sput_unicode_property_internal. Defvar_lisp
3754 char-code-property-alist.
3756 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3757 Vunicode_category_table.
3759 * font.c (font_range): Adjust for the change of
3760 Vunicode_category_table.
3762 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3764 * m/iris4d.h: Remove file, move contents ...
3765 * s/irix6-5.h: ... here.
3767 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3769 Remove unportable assumption about struct layout (Bug#8884).
3770 * alloc.c (mark_buffer):
3771 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3772 (clone_per_buffer_values): Don't assume that
3773 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3774 This isn't true in general, and it's particularly not true
3775 if Emacs is configured with --with-wide-int.
3776 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3777 New macros, used in the buffer.c change.
3779 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3781 * xsettings.c: Use both GConf and GSettings if both are available.
3782 (store_config_changed_event): Add comment.
3783 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3784 (store_tool_bar_style_changed): New functions.
3785 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3786 (struct xsettings): Move font inside HAVE_XFT.
3787 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3788 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3789 Move inside HAVE_XFT.
3790 (something_changed_gsettingsCB): Rename from something_changedCB.
3791 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3793 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3794 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3795 (something_changed_gconfCB): Rename from something_changedCB.
3796 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3797 (parse_settings): Move check for font inside HAVE_XFT.
3798 (read_settings, apply_xft_settings): Add comment.
3799 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3800 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3801 call store_font_name_changed.
3802 (xft_settings_event): Add comment.
3803 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3804 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3805 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3806 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3807 (xsettings_initialize): Call init_gsettings last.
3808 (xsettings_get_system_font, xsettings_get_system_normal_font):
3811 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3813 Random fixes. E.g., (random) never returned negative values.
3814 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3815 subseconds part to the entropy, as that's a bit more random.
3816 Prefer signed to unsigned, since the signedness doesn't matter and
3817 in general we prefer signed. When given a limit, use a
3818 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3819 latter isn't right if USE_2_TAGS_FOR_INTS.
3820 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3821 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3823 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3825 * textprop.c (text_property_stickiness):
3826 Obey Vtext_property_default_nonsticky.
3827 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3828 * w32fns.c (syms_of_w32fns):
3829 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3831 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3833 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3834 This is more efficient than Ffile_directory_p and avoids a minor race.
3836 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3838 * buffer.c (Foverlay_put): Say what the return value is
3841 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3842 is a directory before asking whether to use the file name
3844 (barf_or_query_if_file_exists): Make the "File is a directory"
3845 error be more correct.
3847 * fns.c (Frequire): Remove the mention of the .gz files, since
3848 that's installation-specific, but keep the mention of
3849 `get-load-suffixes'.
3851 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3853 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3854 Report string overflow if the output is too long.
3856 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3858 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3859 (syms_of_gnutls): Remove duplicate DEFSYM for
3860 Qgnutls_bootprop_verify_hostname_error, an error for
3861 Qgnutls_bootprop_verify_error (which is no longer used).
3863 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3864 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3865 Also (re)move comments that are misplaced or no longer relevant.
3867 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3869 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3871 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3873 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3874 and background color parameters if they have been changed.
3876 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3878 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3880 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3882 * xsettings.c (SYSTEM_FONT): Define only when used.
3883 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3885 * keymap.c (access_keymap_1): Now static.
3887 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3889 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3890 leave any prefix arg for the up event (Bug#1586).
3892 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3894 * lread.c (syms_of_lread): Mention single symbols defined by
3895 `defvar' or `defconst' (bug#7154).
3897 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3898 (Frequire): Mention get-load-suffixes.
3900 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3902 * window.h (window): Remove clone_number slot.
3903 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3905 (make_parent_window, make_window, saved_window)
3906 (Fset_window_configuration, save_window_save): Don't deal with
3908 * buffer.c (Qclone_number): Remove declaration.
3909 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3911 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3913 Add multiple inheritance to keymaps.
3914 * keymap.c (Fmake_composed_keymap): New function.
3915 (Fset_keymap_parent): Simplify.
3916 (fix_submap_inheritance): Remove.
3917 (access_keymap_1): New function extracted from access_keymap to handle
3918 embedded parents and handle lists of maps.
3919 (access_keymap): Use it.
3920 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3921 (Fcopy_keymap): Handle embedded parents.
3922 (Fcommand_remapping, define_as_prefix): Simplify.
3923 (Fkey_binding): Simplify.
3924 (syms_of_keymap): Move minibuffer-local-completion-map,
3925 minibuffer-local-filename-completion-map,
3926 minibuffer-local-must-match-map, and
3927 minibuffer-local-filename-must-match-map to Elisp.
3928 (syms_of_keymap): Defsubr make-composed-keymap.
3929 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3930 (parse_menu_item): Trivial simplification.
3932 2011-07-01 Glenn Morris <rgm@gnu.org>
3934 * Makefile.in (SETTINGS_LIBS): Fix typo.
3936 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3938 * coding.c (Fencode_coding_string): Record the last coding system
3939 used, as the function doc string says (bug#8738).
3941 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3943 * xsettings.c (store_monospaced_changed): Take new font as arg and
3944 check for change against current_mono_font.
3945 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3946 (emacs_settings_constructor, emacs_settings_get_property)
3947 (emacs_settings_set_property, emacs_settings_class_init)
3948 (emacs_settings_init, gsettings_obj): Remove.
3949 (something_changedCB): New function for HAVE_GSETTINGS.
3950 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3951 with value as argument.
3952 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3953 g_settings_new (Bug#8967). Do not create gsettings_obj.
3954 Remove calls to g_settings_bind. Connect something_changedCB to
3957 * xgselect.c: Add defined (HAVE_GSETTINGS).
3958 (xgselect_initialize): Ditto.
3960 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3961 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3964 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3966 * eval.c (struct backtrace): Simplify and port the data structure.
3967 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3968 signed bit field, as this assumption is not portable and it makes
3969 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3970 "char debug_on_exit : 1" as this is not portable either; instead,
3971 use the portable "unsigned int debug_on_exit : 1". Remove unused
3972 member evalargs. Remove obsolete comments about cc bombing out.
3974 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3976 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3977 Let HAVE_GSETTINGS override HAVE_GCONF.
3978 (store_monospaced_changed): New function.
3979 (EMACS_SETTINGS): A new type derived from GObject to handle
3980 GSettings notifications.
3981 (emacs_settings_constructor, emacs_settings_get_property)
3982 (emacs_settings_set_property, emacs_settings_class_init):
3984 (gsettings_client, gsettings_obj): New variables.
3985 (GSETTINGS_SCHEMA): New define.
3986 (something_changedCB): Call store_monospaced_changed.
3987 (init_gsettings): New function.
3988 (xsettings_initialize): Call init_gsettings.
3989 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3992 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3995 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3997 * window.c (resize_root_window, grow_mini_window)
3998 (shrink_mini_window): Rename Qresize_root_window to
3999 Qwindow_resize_root_window and Qresize_root_window_vertically to
4000 Qwindow_resize_root_window_vertically.
4002 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4004 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4006 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4008 * makefile.w32-in: Redesign dependencies so they reflect more
4009 clearly which files are directly included by each source file,
4010 and not through other includes.
4012 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4014 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4015 (sort_overlays, overlay_strings): When an overlay's clone number
4016 matches the window's clone number process the overlay even if
4017 the overlay's window property doesn't match the current window.
4019 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4020 (Fwindow_hchild): Rename to Fwindow_left_child.
4021 (Fwindow_next): Rename to Fwindow_next_sibling.
4022 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4023 (resize_window_check): Rename to window_resize_check.
4024 (resize_window_apply): Rename to window_resize_apply.
4025 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4026 (Fdelete_other_windows_internal, resize_frame_windows)
4027 (Fsplit_window_internal, Fdelete_window_internal)
4028 (grow_mini_window, shrink_mini_window)
4029 (Fresize_mini_window_internal): Fix callers accordingly.
4031 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4033 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4034 (emacs_fixed_set_min_size): Remove.
4035 (emacs_fixed_new): Take frame as argument.
4037 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4038 (_EmacsFixedPrivate): Remove minwidth/height.
4039 Add struct frame *f.
4040 (emacs_fixed_init): Initialize priv->f.
4041 (get_parent_class, emacs_fixed_set_min_size): Remove.
4042 (emacs_fixed_new): Set priv->f to argument.
4043 (emacs_fixed_get_preferred_width)
4044 (emacs_fixed_get_preferred_height): Use min_width/height from
4045 frames size_hint to set minimum and natural (Bug#8919).
4046 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4047 and use min_width/height from frames size_hint to set
4048 min_width/height (Bug#8919).
4050 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4051 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4054 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4056 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4057 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4060 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4062 * process.c (wait_reading_process_output): Bypass select if
4063 waiting for a cell while ignoring keyboard input, and input is
4064 pending. Suggested by Jan Djärv (Bug#8869).
4066 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4068 Use gnulib's dup2 module instead of rolling our own.
4069 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4071 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4073 * dispnew.c (scrolling_window): Before scrolling, turn off a
4074 mouse-highlight in the window being scrolled.
4076 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4078 Move DEFSYM to lisp.h and use everywhere.
4080 * character.h (DEFSYM): Move declaration...
4081 * lisp.h (DEFSYM): ...here.
4087 * w32select.c: Don't include character.h.
4089 * alloc.c (syms_of_alloc):
4090 * buffer.c (syms_of_buffer):
4091 * bytecode.c (syms_of_bytecode):
4092 * callint.c (syms_of_callint):
4093 * casefiddle.c (syms_of_casefiddle):
4094 * casetab.c (init_casetab_once):
4095 * category.c (init_category_once, syms_of_category):
4096 * ccl.c (syms_of_ccl):
4097 * cmds.c (syms_of_cmds):
4098 * composite.c (syms_of_composite):
4099 * dbusbind.c (syms_of_dbusbind):
4100 * dired.c (syms_of_dired):
4101 * dispnew.c (syms_of_display):
4102 * doc.c (syms_of_doc):
4103 * editfns.c (syms_of_editfns):
4104 * emacs.c (syms_of_emacs):
4105 * eval.c (syms_of_eval):
4106 * fileio.c (syms_of_fileio):
4107 * fns.c (syms_of_fns):
4108 * frame.c (syms_of_frame):
4109 * fringe.c (syms_of_fringe):
4110 * insdel.c (syms_of_insdel):
4111 * keymap.c (syms_of_keymap):
4112 * lread.c (init_obarray, syms_of_lread):
4113 * macros.c (syms_of_macros):
4114 * msdos.c (syms_of_msdos):
4115 * print.c (syms_of_print):
4116 * process.c (syms_of_process):
4117 * search.c (syms_of_search):
4118 * sound.c (syms_of_sound):
4119 * syntax.c (init_syntax_once, syms_of_syntax):
4120 * terminal.c (syms_of_terminal):
4121 * textprop.c (syms_of_textprop):
4122 * undo.c (syms_of_undo):
4123 * w32.c (globals_of_w32):
4124 * window.c (syms_of_window):
4125 * xdisp.c (syms_of_xdisp):
4126 * xfaces.c (syms_of_xfaces):
4127 * xfns.c (syms_of_xfns):
4128 * xmenu.c (syms_of_xmenu):
4129 * xsettings.c (syms_of_xsettings):
4130 * xterm.c (syms_of_xterm): Use DEFSYM.
4132 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4134 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4136 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4138 Integer and buffer overflow fixes (Bug#8873).
4140 * print.c (printchar, strout): Check for string overflow.
4141 (PRINTPREPARE, printchar, strout):
4142 Don't set size unless allocation succeeds.
4144 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4145 for sizes. Check for string overflow more accurately.
4146 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4148 * macros.c: Integer and buffer overflow fixes.
4149 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4150 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4151 Use ptrdiff_t, not int, for sizes.
4152 Don't increment bufsize until after realloc succeeds.
4153 Check for size-calculation overflow.
4154 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4156 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4158 * lread.c: Integer overflow fixes.
4159 (read_integer): Radix is now EMACS_INT, not int,
4160 to improve quality of diagnostics for out-of-range radices.
4161 Calculate buffer size correctly for out-of-range radices.
4162 (read1): Check for integer overflow in radices, and in
4163 read-circle numbers.
4164 (read_escape): Avoid int overflow.
4165 (Fload, openp, read_buffer_size, read1)
4166 (substitute_object_recurse, read_vector, read_list, map_obarray):
4167 Use ptrdiff_t, not int, for sizes.
4168 (read1): Use EMACS_INT, not int, for sizes.
4169 Check for size overflow.
4171 * image.c (cache_image): Check for size arithmetic overflow.
4173 * lread.c: Integer overflow issues.
4174 (saved_doc_string_size, saved_doc_string_length)
4175 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4176 Now ptrdiff_t, not int.
4177 (read1): Don't assume doc string length fits in int. Check for
4178 out-of-range doc string lengths.
4179 (read_list): Don't assume file position fits in int.
4180 (read_escape): Check for hex character overflow.
4182 2011-06-22 Leo Liu <sdl.web@gmail.com>
4184 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4185 Move to minibuffer.el.
4187 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4189 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4190 The following patches are for when GLYPH_DEBUG && !XASSERT.
4191 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4192 * dispnew.c (flush_stdout):
4193 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4194 Mark as externally visible.
4195 * dispnew.c (check_window_matrix_pointers): Now static.
4196 * dispnew.c (window_to_frame_vpos):
4197 * xfns.c (unwind_create_frame):
4198 * xterm.c (x_check_font): Remove unused local.
4199 * scroll.c (CHECK_BOUNDS):
4200 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4201 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4202 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4203 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4204 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4206 (debug_method_add): Use va_list and vsprintf rather than relying
4207 on undefined behavior with wrong number of arguments.
4208 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4209 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4210 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4211 since we're not interested in debugging glyphs with old libraries.
4212 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4213 GCC 4.6.0's static checking.
4215 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4217 Integer overflow and signedness fixes (Bug#8873).
4218 A few related buffer overrun fixes, too.
4220 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4222 * dispextern.h (struct face.stipple):
4223 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4224 (x_bitmap_mask, x_allocate_bitmap_record)
4225 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4226 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4227 (x_create_bitmap_from_xpm_data):
4228 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4229 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4231 * xfaces.c (load_pixmap):
4232 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4233 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4234 (.bitmaps_last, struct x_output.icon_bitmap):
4235 Use ptrdiff_t, not int, for bitmap indexes.
4236 (x_allocate_bitmap_record): Check for size overflow.
4237 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4239 Use ptrdiff_t, not int, for overlay counts.
4240 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4241 * editfns.c (overlays_around, get_pos_property):
4242 * textprop.c (get_char_property_and_overlay):
4243 * xdisp.c (next_overlay_change, note_mouse_highlight):
4244 * xfaces.c (face_at_buffer_position):
4245 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4246 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4247 (Fnext_overlay_change, Fprevious_overlay_change)
4248 (mouse_face_overlay_overlaps, Foverlays_in):
4249 Use ptrdiff_t, not int, for sizes.
4250 (overlays_at, overlays_in): Check for size-calculation overflow.
4252 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4254 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4255 (x_session_initialize): Do not assume string length fits in int.
4257 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4258 This is unlikely, but can occur if DPI is outlandish.
4260 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4261 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4263 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4264 * xrdb.c (magic_file_p, search_magic_path):
4265 Omit last arg SUFFIX; it was always 0. All callers changed.
4266 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4268 * xfont.c (xfont_match): Avoid need for strlen.
4270 * xfns.c: Don't assume strlen fits in int.
4271 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4273 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4274 not unsigned long, as we prefer signed integers. All callers changed.
4275 Detect integer overflow in repeat count.
4276 (message_dolog): Don't assume print length fits in 39 bytes.
4277 (display_mode_element): Don't assume strlen fits in int.
4279 * termcap.c: Don't assume sizes fit in int and never overflow.
4280 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4281 (gobble_line): Check for size-calculation overflow.
4283 * minibuf.c (Fread_buffer):
4284 * lread.c (intern, intern_c_string):
4285 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4286 Don't assume string length fits in int.
4288 * keyboard.c (parse_tool_bar_item):
4289 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4291 * font.c: Don't assume string length fits in int.
4292 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4293 Use ptrdiff_t, not int.
4294 (font_intern_prop): Don't assume string length fits in int.
4295 Don't assume integer property fits in fixnum.
4296 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4298 * filelock.c: Fix some buffer overrun and integer overflow issues.
4299 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4300 Reformulate so as not to need the command string.
4301 Invoke gzip -cd rather than gunzip, as it's more portable.
4302 (lock_info_type, lock_file_1, lock_file):
4303 Don't assume pid_t and time_t fit in unsigned long.
4304 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4305 (current_lock_owner): Prefer signed type for sizes.
4306 Use memcpy, not strncpy, where memcpy is what is really wanted.
4307 Don't assume (via atoi) that time_t and pid_t fit in int.
4308 Check for time_t and/or pid_t out of range, e.g., via a network share.
4309 Don't alloca where an auto var works fine.
4311 * fileio.c: Fix some integer overflow issues.
4312 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4313 Don't assume string length fits in int.
4314 (directory_file_name): Don't assume string length fits in long.
4315 (make_temp_name): Don't assume pid fits in int, or that its print
4316 length is less than 20.
4318 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4320 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4322 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4324 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4325 We prefer signed integers, even for size calculations.
4327 * emacs.c: Don't assume string length fits in 'int'.
4328 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4329 (main): Don't invoke strlen when not needed.
4331 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4332 (XD_DEBUG_MESSAGE): Don't waste a byte.
4334 * callproc.c (getenv_internal_1, getenv_internal)
4336 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4338 * lread.c (invalid_syntax): Omit length argument.
4339 All uses changed. This doesn't fix a bug, but it simplifies the
4340 code away from its former Hollerith-constant appearance, and it's
4341 one less 'int' to worry about when looking at integer-overflow issues.
4342 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4344 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4345 This didn't break anything, but it didn't help either.
4346 It's confusing to put a bogus integer in a place where the actual
4347 value does not matter.
4348 (LIST_END_P): Remove unused macro and its bogus comment.
4349 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4351 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4352 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4354 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4355 We prefer signed types, and the value cannot exceed the EMACS_INT
4356 range anyway (because otherwise the length would not be representable).
4357 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4358 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4359 This avoids a GCC warning when WIDE_EMACS_INT.
4361 * indent.c (sane_tab_width): New function.
4362 (current_column, scan_for_column, Findent_to, position_indentation)
4363 (compute_motion): Use it. This is just for clarity.
4364 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4366 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4368 * lisp.h (lint_assume): New macro.
4369 * composite.c (composition_gstring_put_cache):
4370 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4372 * editfns.c, insdel.c:
4373 Omit unnecessary forward decls, to simplify future changes.
4375 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4377 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4379 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4380 Use much-faster test for byte-length change.
4381 Don't assume string byte-length fits in 'int'.
4382 Check that character arg fits in 'int'.
4383 (mapcar1): Declare byte as byte, for clarity.
4385 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4387 * fns.c (concat): Catch string overflow earlier.
4388 Do not rely on integer wraparound.
4390 * dispextern.h (struct it.overlay_strings_charpos)
4391 (struct it.selective): Now EMACS_INT, not int.
4392 * xdisp.c (forward_to_next_line_start)
4393 (back_to_previous_visible_line_start)
4394 (reseat_at_next_visible_line_start, next_element_from_buffer):
4395 Don't arbitrarily truncate the value of 'selective' to int.
4397 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4399 * composite.c: Don't truncate sizes to 'int'.
4400 (composition_gstring_p, composition_reseat_it)
4401 (composition_adjust_point): Use EMACS_INT, not int.
4402 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4403 not EMACS_UINT, for indexes.
4405 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4407 * buffer.c: Include <verify.h>.
4408 (struct sortvec.priority, struct sortstr.priority):
4409 Now EMACS_INT, not int.
4410 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4411 (struct sortstr.size, record_overlay_string)
4412 (struct sortstrlist.size, struct sortlist.used):
4413 Don't truncate size to int.
4414 (record_overlay_string): Check for size-calculation overflow.
4415 (init_buffer_once): Check at compile-time, not run-time.
4417 2011-06-22 Jim Meyering <meyering@redhat.com>
4419 Don't leak an XBM-image-sized buffer
4420 * image.c (xbm_load): Free the image buffer after using it.
4422 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4425 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4426 that Sun C diagnosed.
4427 * fns.c (secure_hash): Fix pointer signedness issue.
4428 * intervals.c (static_offset_intervals): New function.
4429 (offset_intervals): Use it.
4431 2011-06-21 Leo Liu <sdl.web@gmail.com>
4434 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4437 * fns.c (secure_hash): Rename from crypto_hash_function and change
4438 the first arg to accept symbols.
4439 (Fsecure_hash): New primitive.
4440 (syms_of_fns): New symbols.
4442 2011-06-20 Deniz Dogan <deniz@dogan.se>
4444 * process.c (Fset_process_buffer): Clarify return value in
4447 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4449 * dispnew.c (add_window_display_history): Use BVAR.
4451 * xdisp.c (debug_method_add): Use BVAR.
4452 (check_window_end, dump_glyph_matrix, dump_glyph)
4453 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4455 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4458 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4459 check till after the cache is created in init_frame_faces.
4461 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4463 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4465 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4467 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4468 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4469 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4471 Improve buffer-overflow checking (Bug#8873).
4472 * fileio.c (Finsert_file_contents):
4473 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4474 Remove the old (too-loose) buffer overflow checks.
4475 They weren't needed, since make_gap checks for buffer overflow.
4476 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4477 The old code merely checked for Emacs fixnum overflow, and relied
4478 on undefined (wraparound) behavior. The new code avoids undefined
4479 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4481 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4482 Tune. Don't use wider integers than needed. Don't use alloca.
4483 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4485 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4487 * insdel.c, lisp.h (buffer_overflow): New function.
4488 (insert_from_buffer_1, replace_range, replace_range_2):
4489 * insdel.c (make_gap_larger):
4490 * editfns.c (Finsert_char):
4491 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4493 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4495 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4497 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4499 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4500 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4502 * fileio.c: Don't assume EMACS_INT fits in off_t.
4503 (emacs_lseek): New static function.
4504 (Finsert_file_contents, Fwrite_region): Use it.
4505 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4507 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4509 * fns.c: Don't overflow int when computing a list length.
4510 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4511 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4512 truncation on 64-bit hosts. Check for QUIT every
4513 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4514 faster and is responsive enough.
4515 (Flength): Report an error instead of overflowing an integer.
4516 (Fsafe_length): Return a float if the value is not representable
4517 as a fixnum. This shouldn't happen except in contrived situations.
4518 (Fnthcdr, Fsort): Don't assume list length fits in int.
4519 (Fcopy_sequence): Don't assume vector length fits in int.
4521 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4522 (header_size, word_size): New constants.
4523 (allocate_vectorlike): Don't check size overflow here.
4524 (allocate_vector): Check it here instead, since this is the only
4525 caller of allocate_vectorlike that could cause overflow.
4526 Check that the new vector's length is representable as a fixnum.
4528 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4529 The previous code was bogus. For example, next_almost_prime (32)
4530 returned 39, which is undesirable as it is a multiple of 3; and
4531 next_almost_prime (24) returned 25, which is a multiple of 5 so
4532 why was the code bothering to check for multiples of 7?
4534 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4536 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4538 Variadic C functions now count arguments with ptrdiff_t.
4539 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4540 Back then I didn't know that the Emacs coding style prefers signed int.
4541 Also, in the meantime I found a few more instances where arguments
4542 were being counted with int, which may truncate counts on 64-bit
4543 machines, or EMACS_INT, which may be unnecessarily wide.
4544 * lisp.h (struct Lisp_Subr.function.aMANY)
4545 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4546 Arg counts are now ptrdiff_t, not size_t.
4547 All variadic functions and their callers changed accordingly.
4548 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4549 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4550 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4551 * callint.c (Fcall_interactively): Check arg count for overflow,
4552 to avoid potential buffer overrun. Use signed char, not 'int',
4553 for 'varies' array, so that we needn't bother to check its size
4554 calculation for overflow.
4555 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4556 * eval.c (apply_lambda):
4557 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4558 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4559 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4561 * callint.c (Fcall_interactively): Don't use index var as event count.
4563 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4564 * mem-limits.h (SIZE): Remove; no longer used.
4566 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4568 Remove unnecessary casts.
4569 * xterm.c (x_term_init):
4570 * xfns.c (x_set_border_pixel):
4571 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4572 These aren't needed now that we assume ANSI C.
4574 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4575 It's more likely to cause problems (due to unsigned overflow)
4578 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4580 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4582 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4584 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4586 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4588 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4590 GLYPH_CODE_FACE returns EMACS_INT, not int.
4591 * dispextern.h (merge_faces):
4592 * xfaces.c (merge_faces):
4593 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4594 Don't assume EMACS_INT fits in int.
4596 * character.h (CHAR_VALID_P): Remove unused parameter.
4597 * fontset.c, lisp.h, xdisp.c: All uses changed.
4599 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4601 * fns.c (concat): Minor tuning based on overflow analysis.
4602 This doesn't fix any bugs. Use int to hold character, instead
4603 of constantly refetching from Emacs object. Use XFASTINT, not
4604 XINT, for value known to be a character. Don't bother comparing
4605 a single byte to 0400, as it's always less.
4607 * floatfns.c (Fexpt):
4608 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4610 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4613 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4615 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4616 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4617 incorrectly succeed when S was a string, because 4294967386 was
4618 truncated before it was used.
4620 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4621 Otherwise, an out-of-range integer could cause undefined behavior
4624 * composite.c: Use int, not EMACS_INT, for characters.
4625 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4626 EMACS_INT, for values that are known to be in character range.
4627 This doesn't fix any bugs but is the usual style inside Emacs and
4628 may generate better code on 32-bit machines.
4630 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4631 This is for reasons similar to the recent CHAR_STRING fix.
4632 * charset.c (Fencode_char): Check that character arg is actually
4633 a character. Pass an int to ENCODE_CHAR.
4634 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4635 wider than 'int', as a compile-time check to prevent future regressions
4638 * character.c (char_string): Remove unnecessary casts.
4640 Make sure a 64-bit char is never passed to CHAR_STRING.
4641 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4642 by silently ignoring the top 32 bits, allowing some values
4643 that were far too large to be valid characters.
4644 * character.h: Include <verify.h>.
4645 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4646 arguments are no wider than unsigned, as a compile-time check
4647 to prevent future regressions in this area.
4649 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4650 (Fsubst_char_in_region):
4652 * xdisp.c (decode_mode_spec_coding):
4653 Adjust to CHAR_STRING's new requirement.
4654 * editfns.c (Finsert_char, Fsubst_char_in_region):
4655 * fns.c (concat): Check that character args are actually
4656 characters. Without this test, these functions did the wrong
4657 thing with wildly out-of-range values on 64-bit hosts.
4659 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4660 These casts should not be needed on 32-bit hosts, either.
4661 * keyboard.c (read_char):
4662 * lread.c (Fload): Remove casts to unsigned.
4664 * lisp.h (UNSIGNED_CMP): New macro.
4665 This fixes comparison bugs on 64-bit hosts.
4666 (ASCII_CHAR_P): Use it.
4667 * casefiddle.c (casify_object):
4668 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4669 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4670 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4671 * dispextern.h (FACE_FROM_ID):
4672 * keyboard.c (read_char): Use UNSIGNED_CMP.
4674 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4675 not to EMACS_INT, to avoid GCC warning.
4677 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4679 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4680 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4681 isn't needed on 32-bit machines.
4683 * buffer.c (Fgenerate_new_buffer_name):
4684 Use EMACS_INT for count, not int.
4685 (advance_to_char_boundary): Return EMACS_INT, not int.
4687 * data.c (Qcompiled_function): Now static.
4689 * window.c (window_body_lines): Now static.
4691 * image.c (gif_load): Rename local to avoid shadowing.
4693 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4694 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4695 * alloc.c (make_save_value): Integer argument is now of type
4697 (mark_object): Use ptrdiff_t, not int.
4698 * lisp.h (pD): New macro.
4699 * print.c (print_object): Use it.
4701 * alloc.c: Use EMACS_INT, not int, to count objects.
4702 (total_conses, total_markers, total_symbols, total_vector_size)
4703 (total_free_conses, total_free_markers, total_free_symbols)
4704 (total_free_floats, total_floats, total_free_intervals)
4705 (total_intervals, total_strings, total_free_strings):
4706 Now EMACS_INT, not int. All uses changed.
4707 (Fgarbage_collect): Compute overall total using a double, so that
4708 integer overflow is less likely to be a problem. Check for overflow
4709 when converting back to an integer.
4710 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4711 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4712 These were 'int' variables that could overflow on 64-bit hosts;
4713 they were never used, so remove them instead of repairing them.
4714 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4715 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4716 Previously, this ceilinged at INT_MAX, but that doesn't work on
4718 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4720 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4721 (allocate_vectorlike): Check for ptrdiff_t overflow.
4722 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4723 when a (possibly-narrower) signed value would do just as well.
4724 We prefer using signed arithmetic, to avoid comparison confusion.
4726 * alloc.c: Catch some string size overflows that we were missing.
4727 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4728 for convenience in STRING_BYTES_MAX.
4729 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4730 The definition here is exact; the one in lisp.h was approximate.
4731 (allocate_string_data): Check for string overflow. This catches
4732 some instances we weren't catching before. Also, it catches
4733 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4734 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4735 and ptrdiff_t and EMACS_INT are both 64 bits.
4737 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4738 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4739 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4741 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4743 * alloc.c (Fmake_string): Check for out-of-range init.
4745 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4747 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4749 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4751 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4752 xg_get_default_scrollbar_width.
4754 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4755 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4756 (style_changed_cb): Call update_theme_scrollbar_width and call
4757 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4758 all frames (Bug#8505).
4759 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4760 Call gtk_window_set_resizable if HAVE_GTK3.
4761 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4762 and height if HAVE_GTK3 (Bug#8505).
4763 (scroll_bar_width_for_theme): New variable.
4764 (update_theme_scrollbar_width): New function.
4765 (xg_get_default_scrollbar_width): Move code to
4766 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4767 (xg_initialize): Call update_theme_scrollbar_width.
4769 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4771 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4773 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4775 * frame.c (make_frame): Call other_buffer_safely instead of
4778 * window.c (temp_output_buffer_show): Call display_buffer with
4779 second argument Vtemp_buffer_show_specifiers and reset latter
4780 immediately after the call.
4781 (Vtemp_buffer_show_specifiers): New variable.
4782 (auto_window_vscroll_p, next_screen_context_lines)
4783 (Vscroll_preserve_screen_position): Remove leading asterisks from
4786 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4788 Fix minor problems found by GCC 4.6.0 static checking.
4789 * buffer.c (Qclone_number): Remove for now, as it's unused.
4790 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4791 (record_buffer): Remove unused local.
4792 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4793 (set_frame_buffer_list): Remove; unused.
4794 * frame.h (other_visible_frames): Remove decl.
4795 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4796 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4797 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4799 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4800 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4801 Define only if HAVE_GPM.
4802 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4803 (update_hints_inhibit): Remove; never set. All uses removed.
4804 * widgetprv.h (emacsFrameClassRec): Remove decl.
4805 * window.c (delete_deletable_window): Now returns void, since it
4806 wasn't returning anything.
4807 (compare_window_configurations): Remove unused locals.
4808 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4809 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4810 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4811 the same widths as pointers. This follows up on the 2011-05-06 patch.
4812 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4813 * xterm.h: Likewise.
4814 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4816 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4818 * makefile.w32-in: Update dependencies.
4819 (LISP_H): Add lib/intprops.h.
4821 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4823 * image.c (gif_load): Add animation frame delay to the metadata.
4824 (syms_of_image): Use DEFSYM. New symbol `delay'.
4826 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4828 * window.c (delete_deletable_window): Re-add.
4829 (Fset_window_configuration): Rewrite to handle dead buffers and
4830 consequently deletable windows.
4831 (window_tree, Fwindow_tree): Remove. Supply functionality in
4833 (compare_window_configurations): Simplify code.
4835 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4837 * image.c (imagemagick_load_image): Fix type mismatch.
4838 (Fimagemagick_types): Likewise.
4840 * window.h (replace_buffer_in_windows): Declare.
4842 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4844 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4845 Qclone_number. Remove external declaration of Qdelete_window.
4846 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4848 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4849 Run Qbuffer_list_update_hook if allowed.
4850 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4851 buffer list implementation.
4852 (other_buffer_safely): New function.
4853 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4854 calls to replace_buffer_in_windows and
4855 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4857 (record_buffer): Inhibit quitting and rewrite using quittable
4858 functions. Run Qbuffer_list_update_hook if allowed.
4859 (Frecord_buffer, Funrecord_buffer): New functions.
4860 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4861 Move switch-to-buffer to window.el.
4862 (bury-buffer): Move to window.el.
4863 (Vbuffer_list_update_hook): New variable.
4865 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4868 * window.h (resize_frame_windows): Move up in code.
4869 (Fwindow_frame): Remove EXFUN.
4870 (replace_buffer_in_all_windows): Remove prototype.
4871 (replace_buffer_in_windows_safely): Add prototype.
4873 * window.c: Declare Qdelete_window static again. Move down
4874 declaration of select_count.
4875 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4876 (Fother_window): Move to window.el.
4877 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4878 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4879 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4881 (replace_buffer_in_windows): Implement by calling
4882 Qreplace_buffer_in_windows.
4883 (replace_buffer_in_all_windows): Remove with some functionality
4884 moved into replace_buffer_in_windows_safely.
4885 (replace_buffer_in_windows_safely): New function.
4886 (select_window_norecord, select_frame_norecord): Move in front
4887 of run_window_configuration_change_hook. Remove now obsolete
4889 (Fset_window_buffer): Rewrite doc-string.
4890 Call Qrecord_window_buffer.
4891 (keys_of_window): Move binding for other-window to window.el.
4893 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4895 * dispextern.h (struct image): Replace data member, whose int_val
4896 and ptr_val fields were not used by anything, with a single
4899 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4900 (gif_clear_image, gif_load, imagemagick_load_image)
4901 (gs_clear_image, gs_load): Callers changed.
4903 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4905 * buffer.h: Include <time.h>, for time_t.
4906 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4908 Fix minor problems found by static checking.
4910 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4912 Make identifiers static if they are not used in other modules.
4913 * data.c (Qcompiled_function, Qframe, Qvector):
4914 * image.c (QimageMagick, Qsvg):
4915 * minibuf.c (Qmetadata):
4916 * window.c (resize_window_check, resize_root_window): Now static.
4917 * window.h (resize_window_check, resize_root_window): Remove decls.
4919 * window.c (window_deletion_count, delete_deletable_window):
4921 (window_body_lines): Now static.
4922 (Fdelete_other_windows_internal): Mark vars as initialized.
4923 Make sure 'resize_failed' is initialized.
4924 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4925 (resize_window_apply): Remove unused local.
4926 * window.h (delete_deletable_window): Remove decl.
4928 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4929 (imagemagick_load_image): Fix pointer signedness problem by changing
4930 last arg from unsigned char * to char *. All uses changed.
4931 Also, fix a local for similar reasons.
4932 Remove unused locals. Remove locals to avoid shadowing.
4933 (fn_rsvg_handle_free): Remove; unused.
4934 (svg_load, svg_load_image): Fix pointer signedness problem.
4935 (imagemagick_load_image): Don't use garbage pointer image_wand.
4937 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4939 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4941 * image.c (gif_load): Fix omitted cast error introduced by
4944 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4946 * window.h (resize_proportionally, orig_total_lines)
4947 (orig_top_line): Remove from window structure.
4948 (set_window_height, set_window_width, change_window_heights)
4949 (Fdelete_window): Remove prototypes.
4950 (resize_frame_windows): Remove duplicate declaration.
4952 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4954 * window.h (resize_frame_windows, resize_window_check)
4955 (delete_deletable_window, resize_root_window)
4956 (resize_frame_windows): Declare prototypes.
4958 * window.c (resize_window_apply): Make definition be "static" to
4959 match the prototype.
4961 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4963 * window.c: Remove declarations of Qwindow_size_fixed,
4964 window_min_size_1, window_min_size_2, window_min_size,
4965 size_window, window_fixed_size_p, enlarge_window, delete_window.
4966 Remove static from declaration of Qdelete_window, it's
4967 temporarily needed by Fbury_buffer.
4968 (replace_window): Don't assign orig_top_line and
4970 (Fdelete_window, delete_window): Remove. Window deletion is
4971 handled by window.el.
4972 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4973 Replace Fdelete_window calls with calls to Qdelete_window.
4974 (Fdelete_other_windows): Remove. Deleting other windows is
4975 handled by window.el.
4976 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4977 handled in window.el.
4978 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4979 Window minimum sizes are handled in window.el.
4980 (shrink_windows, size_window, set_window_height)
4981 (set_window_width, change_window_heights, window_height)
4982 (window_width, CURBEG, CURSIZE, enlarge_window)
4983 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4984 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4985 handled in window.el.
4986 (make_dummy_parent): Rename to make_parent_window and give it a
4987 second argument horflag.
4988 (make_window): Don't set resize_proportionally any more.
4989 (Fsplit_window): Remove. Windows are split in window.el.
4990 (save_restore_action, save_restore_orig_size)
4991 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4992 Resize mini windows in window.el.
4993 (grow_mini_window, shrink_mini_window): Implement by calling
4994 Qresize_root_window_vertically, resize_window_check and
4995 resize_window_apply.
4996 (saved_window, Fset_window_configuration, save_window_save):
4997 Do not handle orig_top_line, orig_total_lines, and
4998 resize_proportionally.
4999 (window_min_height, window_min_width): Move to window.el.
5000 (keys_of_window): Move bindings for delete-other-windows,
5001 split-window, delete-window and enlarge-window to window.el.
5003 * buffer.c: Temporarily extern Qdelete_window.
5004 (Fbury_buffer): Temporarily call Qdelete_window instead of
5005 Fdelete_window (Fbury_buffer will move to window.el soon).
5007 * frame.c (set_menu_bar_lines_1): Remove code handling
5008 orig_top_line and orig_total_lines.
5010 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5011 set_window_height but set heights directly.
5012 (change_frame_size_1): Use resize_frame_windows.
5014 * xdisp.c (init_xdisp): Don't use set_window_height but set
5017 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5018 Use resize_frame_windows instead of change_window_heights and run
5019 run_window_configuration_change_hook.
5021 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5022 instead of change_window_heights and run
5023 run_window_configuration_change_hook.
5025 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5027 * window.c (replace_window): Rename second argument REPLACEMENT to
5028 NEW. New third argument SETFLAG. Rewrite.
5029 (delete_window, make_dummy_parent): Call replace_window with
5031 (window_list_1): Move down in code.
5032 (run_window_configuration_change_hook): Move set_buffer part
5033 before select_frame_norecord part in order to unwind correctly.
5034 Rename count1 to count.
5035 (recombine_windows, delete_deletable_window, resize_root_window)
5036 (Fdelete_other_windows_internal)
5037 (Frun_window_configuration_change_hook, make_parent_window)
5038 (resize_window_check, resize_window_apply, Fresize_window_apply)
5039 (resize_frame_windows, Fsplit_window_internal)
5040 (Fdelete_window_internal, Fresize_mini_window_internal):
5042 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5044 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5046 * window.h (window): Add some new members to window structure -
5047 normal_lines, normal_cols, new_total, new_normal, clone_number,
5048 splits, nest, prev_buffers, next_buffers.
5049 (WINDOW_TOTAL_SIZE): Move here from window.c.
5050 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5052 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5054 (make_dummy_parent): Set new members of windows structure.
5055 (make_window): Move down in code. Handle new members of window
5057 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5058 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5059 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5060 (Fset_window_prev_buffers, Fwindow_next_buffers)
5061 (Fset_window_next_buffers, Fset_window_clone_number):
5063 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5064 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5066 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5067 Argument WINDOW can be now internal window too.
5068 (Fwindow_use_time): Move up in code.
5069 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5071 (Fset_window_configuration, saved_window)
5072 (Fcurrent_window_configuration, save_window_save): Handle new
5073 members of window structure.
5074 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5075 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5076 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5077 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5078 Qget_mru_window, Qresize_root_window,
5079 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5080 Qauto_buffer_name; staticpro them.
5082 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5084 * window.c (Fwindow_total_size, Fwindow_left_column)
5085 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5086 (Fwindow_list_1): New functions.
5087 (window_box_text_cols): Replace with window_body_cols.
5088 (Fwindow_width, Fscroll_left, Fscroll_right):
5089 Use window_body_cols instead of window_box_text_cols.
5090 (delete_window, Fset_window_configuration):
5091 Call delete_all_subwindows with window as argument.
5092 (delete_all_subwindows): Take a window as argument and not a
5094 (window_loop): Remove handling of GET_LRU_WINDOW and
5096 (Fget_lru_window, Fget_largest_window): Move to window.el.
5098 * window.h: Extern window_body_cols instead of
5099 window_box_text_cols. delete_all_subwindows now takes a
5100 Lisp_Object as argument.
5102 * indent.c (compute_motion, Fcompute_motion):
5103 Use window_body_cols instead of window_box_text_cols.
5105 * frame.c (delete_frame): Call delete_all_subwindows with root
5108 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5110 * fns.c (Fputhash): Document return value.
5112 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5114 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5116 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5118 Cons<->int and similar integer overflow fixes (Bug#8794).
5120 Check for overflow when converting integer to cons and back.
5121 * charset.c (Fdefine_charset_internal, Fdecode_char):
5122 Use cons_to_unsigned to catch overflow.
5123 (Fencode_char): Use INTEGER_TO_CONS.
5124 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5125 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5126 * data.c (long_to_cons, cons_to_long): Remove.
5127 (cons_to_unsigned, cons_to_signed): New functions.
5128 These signal an error for invalid or out-of-range values.
5129 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5130 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5131 * font.c (Ffont_variation_glyphs):
5132 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5133 * lisp.h: Include <intprops.h>.
5134 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5135 (cons_to_signed, cons_to_unsigned): New decls.
5136 (long_to_cons, cons_to_long): Remove decls.
5137 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5138 (Fprimitive_undo): Use CONS_TO_INTEGER.
5139 * xfns.c (Fx_window_property): Likewise.
5140 * xselect.c: Include <limits.h>.
5141 (x_own_selection, selection_data_to_lisp_data):
5142 Use INTEGER_TO_CONS.
5143 (x_handle_selection_request, x_handle_selection_clear)
5144 (x_get_foreign_selection, Fx_disown_selection_internal)
5145 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5146 (lisp_data_to_selection_data): Use cons_to_unsigned.
5147 (x_fill_property_data): Use cons_to_signed.
5148 Report values out of range.
5150 Check for buffer and string overflow more precisely.
5151 * buffer.h (BUF_BYTES_MAX): New macro.
5152 * lisp.h (STRING_BYTES_MAX): New macro.
5153 * alloc.c (Fmake_string):
5154 * character.c (string_escape_byte8):
5155 * coding.c (coding_alloc_by_realloc):
5156 * doprnt.c (doprnt):
5157 * editfns.c (Fformat):
5159 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5160 since they may not be the same number.
5161 * editfns.c (Finsert_char):
5162 * fileio.c (Finsert_file_contents):
5163 Likewise for BUF_BYTES_MAX.
5165 * image.c: Use ptrdiff_t, not int, for sizes.
5166 (slurp_file): Switch from int to ptrdiff_t.
5168 (slurp_file): Check that file size fits in both size_t (for
5169 malloc) and ptrdiff_t (for sanity and safety).
5171 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5172 if b->modtime has its maximal value.
5174 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5176 Don't assume time_t can fit into int.
5177 * buffer.h (struct buffer.modtime): Now time_t, not int.
5178 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5179 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5181 Minor fixes for signed vs unsigned integers.
5182 * character.h (MAYBE_UNIFY_CHAR):
5183 * charset.c (maybe_unify_char):
5184 * keyboard.c (read_char, reorder_modifiers):
5185 XINT -> XFASTINT, since the integer must be nonnegative.
5186 * ftfont.c (ftfont_spec_pattern):
5187 * keymap.c (access_keymap, silly_event_symbol_error):
5188 XUINT -> XFASTINT, since the integer must be nonnegative.
5189 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5190 since it makes no difference and we prefer signed.
5191 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5192 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5195 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5197 * window.h (Fwindow_frame): Declare.
5199 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5201 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5202 (SPARE_MEMORY): Always define.
5203 (LARGE_REQUEST): Remove.
5204 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5206 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5208 * lisp.h: Move EXFUNS for Fframe_root_window,
5209 Fframe_first_window and Fset_frame_selected_window to window.h.
5211 * window.h: Move EXFUNS for Fframe_root_window,
5212 Fframe_first_window and Fset_frame_selected_window here from
5215 * frame.c (Fwindow_frame, Fframe_first_window)
5216 (Fframe_root_window, Fframe_selected_window)
5217 (Fset_frame_selected_window): Move to window.c.
5218 (Factive_minibuffer_window): Move to minibuf.c.
5219 (Fother_visible_frames_p): New function.
5221 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5223 * window.c (decode_window, decode_any_window): Move up in code.
5224 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5225 (inhibit_frame_unsplittable): Remove unused variable.
5226 (Fwindow_buffer): Move up and rewrite doc-string.
5227 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5228 (Fwindow_prev): New functions.
5229 (Fwindow_frame): Move here from frame.c. Accept any window as
5231 (Fframe_root_window, Fframe_first_window)
5232 (Fframe_selected_window): Move here from frame.c. Accept frame
5233 or arbitrary window as argument. Update doc-strings.
5234 (Fminibuffer_window): Move up in code.
5235 (Fwindow_minibuffer_p): Move up in code and simplify.
5236 (Fset_frame_selected_window): Move here from frame.c.
5238 (Fselected_window, select_window, Fselect_window): Move up in
5239 code. Minor doc-string fixes.
5241 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5243 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5244 Do not assume that spare memory exists; that assumption is valid
5245 only if SYSTEM_MALLOC.
5246 (LARGE_REQUEST): New macro, so that the issue of large requests
5247 is separated from the issue of spare memory.
5249 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5251 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5254 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5256 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5259 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5261 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5263 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5265 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5266 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5268 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5270 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5272 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5274 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5275 (x_clipboard_manager_save): Add return value.
5276 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5278 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5279 Obey Vx_select_enable_clipboard_manager. Catch errors in
5280 x_clipboard_manager_save (Bug#8779).
5281 (Vx_select_enable_clipboard_manager): New variable.
5282 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5284 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5286 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5288 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5290 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5291 in the current matrix if keep_current_p is non-zero.
5293 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5295 * bidi.c (bidi_level_of_next_char): Fix last change.
5297 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5299 Support bidi reordering of text covered by display properties.
5301 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5302 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5303 (bidi_cache_search, bidi_cache_iterator_state)
5304 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5305 (bidi_level_of_next_char, bidi_move_to_visually_next):
5306 Support character positions inside a run of characters covered by a
5308 (bidi_paragraph_init, bidi_resolve_explicit_1)
5309 (bidi_level_of_next_char): Call bidi_fetch_char and
5310 bidi_fetch_char_advance instead of FETCH_CHAR and
5312 (bidi_init_it): Initialize new members.
5313 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5315 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5316 instead of using explicit *_CHAR codes.
5317 (bidi_resolve_explicit, bidi_resolve_weak):
5318 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5319 bidirectional text is supported only in multibyte buffers.
5320 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5321 it to initialize the frame_window_p member of struct bidi_it.
5322 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5323 (bidi_resolve_explicit, bidi_resolve_weak)
5324 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5325 bidi_it->nchars is non-positive.
5326 (bidi_level_of_next_char): Don't try to lookup the cache for the
5327 next/previous character if nothing is cached there yet, or if we
5328 were just reseat()'ed to a new position.
5330 * xdisp.c (set_cursor_from_row): Set start and stop points
5331 according to the row's direction when priming the loop that looks
5332 for the glyph on which to display cursor.
5333 (single_display_spec_intangible_p): Function deleted.
5334 (display_prop_intangible_p): Reimplement to call
5335 handle_display_spec instead of single_display_spec_intangible_p.
5336 Accept 3 additional arguments needed by handle_display_spec.
5337 This fixes incorrect cursor motion across display property with complex
5338 values: lists, `(when COND...)' forms, etc.
5339 (single_display_spec_string_p): Support property values that are
5340 lists with the argument STRING its top-level element.
5341 (display_prop_string_p): Fix the condition for processing a
5342 property that is a list to be consistent with handle_display_spec.
5343 (handle_display_spec): New function, refactored from the
5344 last portion of handle_display_prop.
5345 (compute_display_string_pos): Accept additional argument
5346 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5347 value of a `display' property is a "replacing spec".
5348 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5349 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5350 the display property, but just return a value indicating whether
5351 the display property will replace the characters it covers.
5352 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5353 frame_window_p members of struct bidi_it.
5354 (compute_display_string_pos, compute_display_string_end):
5356 (push_it): Accept second argument POSITION, where pop_it should
5357 jump to continue iteration.
5358 (reseat_1): Initialize bidi_it.disp_pos.
5360 * keyboard.c (adjust_point_for_property): Adjust the call to
5361 display_prop_intangible_p to its new signature.
5363 * dispextern.h (struct bidi_it): New member frame_window_p.
5364 (bidi_init_it): Update prototypes.
5365 (display_prop_intangible_p): Update prototype.
5366 (compute_display_string_pos, compute_display_string_end):
5368 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5371 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5373 Malloc failure behavior now depends on size of allocation.
5374 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5375 * lisp.h: Change signatures accordingly.
5376 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5377 All callers changed. (Bug#8762)
5379 * gnutls.c: Use Emacs's memory allocators.
5380 Without this change, the gnutls library would invoke malloc etc.
5381 directly, which causes problems on non-SYNC_INPUT hosts, and which
5382 runs afoul of improving memory_full behavior. (Bug#8761)
5383 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5384 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5385 xfree instead of the default malloc, realloc, free.
5386 (Fgnutls_boot): No need to check for memory allocation failure,
5387 since xmalloc does that for us.
5389 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5390 * category.c (hash_get_category_set):
5391 * ccl.c (ccl_driver):
5392 * charset.c (Fdefine_charset_internal):
5393 * charset.h (struct charset.hash_index):
5394 * composite.c (get_composition_id, gstring_lookup_cache)
5395 (composition_gstring_put_cache):
5396 * composite.h (struct composition.hash_index):
5397 * dispextern.h (struct image.hash):
5398 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5399 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5400 (hashfn_equal, hashfn_user_defined, make_hash_table)
5401 (maybe_resize_hash_table, hash_lookup, hash_put)
5402 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5403 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5404 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5405 * image.c (make_image, search_image_cache, lookup_image)
5406 (xpm_put_color_table_h):
5407 * lisp.h (struct Lisp_Hash_Table):
5408 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5409 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5410 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5411 * alloc.c (allocate_vectorlike):
5412 Check for overflow in vector size calculations.
5413 * ccl.c (ccl_driver):
5414 Check for overflow when converting EMACS_INT to int.
5415 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5416 need to be updated by these changes.
5417 * fns.c (make_hash_table, maybe_resize_hash_table):
5418 Check for integer overflow with large hash tables.
5419 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5420 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5421 (SXHASH_REDUCE): New macro.
5422 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5423 Use it instead of discarding useful hash info with large hash values.
5424 (sxhash_float): New function.
5425 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5426 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5427 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5428 Rewrite to use FIXNUM_BITS, as this simplifies things.
5429 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5430 Adjust signatures to match updated version of code.
5431 (consing_since_gc): Now EMACS_INT, since a single hash table can
5432 use more than INT_MAX bytes.
5434 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5436 Make it possible to build with GCC-4.6+ -O2 -flto.
5438 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5440 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5442 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5443 Call minibuffer-inactive-mode.
5445 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5447 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5448 Update dependencies.
5450 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5452 * data.c (init_data): Remove code for UTS, this system is not
5455 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5457 Don't force ./temacs to start in terminal mode.
5459 * frame.c (make_initial_frame): Initialize faces in all cases, not
5460 only when CANNOT_DUMP is defined.
5461 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5463 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5465 * dispnew.c (add_window_display_history): Use const for the string
5466 pointer. Remove declaration, not needed.
5468 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5470 Use 'inline', not 'INLINE'.
5471 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5472 * alloc.c, fontset.c (INLINE): Remove.
5473 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5474 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5475 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5476 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5477 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5479 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5481 Make it possible to run ./temacs.
5483 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5484 syms_of_callproc does the same thing. Remove test for
5485 "initialized", do it in the caller.
5486 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5488 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5490 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5491 (read_minibuf): Use get_minibuffer.
5492 (syms_of_minibuf): Use DEFSYM.
5493 (Qmetadata): New var.
5494 * data.c (Qbuffer): Don't make it static.
5495 (syms_of_data): Use DEFSYM.
5497 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5499 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5500 (CCL_CODE_MIN): New macro.
5502 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5504 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5506 * eval.c (Qdebug): Now static.
5507 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5508 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5509 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5511 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5513 * image.c: Various fixes to ImageMagick code comments.
5514 (Fimagemagick_types): Doc fix.
5516 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5518 Minor fixes prompted by GCC 4.6.0 warnings.
5520 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5522 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5523 (x_clipboard_manager_save_all): Move extern decl to ...
5524 * xterm.h: ... here, so that it can be checked for consistency.
5526 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5528 * xselect.c (x_clipboard_manager_save_frame)
5529 (x_clipboard_manager_save_all): New functions.
5530 (Fx_clipboard_manager_save): Lisp function deleted.
5532 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5533 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5535 * xterm.h: Update prototype.
5537 2011-05-28 William Xu <william.xwl@gmail.com>
5539 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5542 2011-05-28 Jim Meyering <meyering@redhat.com>
5544 Avoid a sign-extension bug in crypto_hash_function.
5545 * fns.c (to_uchar): Define.
5546 (crypto_hash_function): Use it to convert some newly-signed
5547 variables to unsigned, to avoid sign-extension bugs. For example,
5548 without this change, (md5 "truc") would evaluate to
5549 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5550 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5551 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5553 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5555 Integer overflow fixes.
5557 * dbusbind.c: Serial number integer overflow fixes.
5558 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5559 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5560 to hold a serial number that is too large for a fixnum.
5561 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5562 Check for serial numbers out of range. Decode any serial number
5563 that was so large that it became a float. (Bug#8722)
5565 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5566 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5567 Use XFASTINT rather than XUINT when numbers are nonnegative.
5568 (xd_append_arg, Fdbus_method_return_internal):
5569 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5570 arguments, check that Lisp number is nonnegative, rather than
5571 silently wrapping negative numbers around. (Bug#8722)
5572 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5575 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5577 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5579 ccl: add integer overflow checks
5580 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5581 (IN_INT_RANGE): New macros.
5582 (ccl_driver): Use them to check for integer overflow when
5583 decoding a CCL program. Many of the new checks are whether XINT (x)
5584 fits in int; it doesn't always, on 64-bit hosts. The new version
5585 doesn't catch all possible integer overflows, but it's an
5586 improvement. (Bug#8719)
5588 * alloc.c (make_event_array): Use XINT, not XUINT.
5589 There's no need for unsigned here.
5591 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5592 This follows up to the 2011-05-06 change that substituted uintptr_t
5593 for EMACS_INT. This case wasn't caught back then.
5595 Rework Fformat to avoid integer overflow issues.
5596 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5597 now (part of C89). Include <verify.h>.
5598 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5599 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5600 (Fformat): Avoid the prepass trying to compute sizes; it was only
5601 approximate and thus did not catch overflow reliably. Instead, walk
5602 through the format just once, formatting and computing sizes as we go,
5603 checking for integer overflow at every step, and allocating a larger
5604 buffer as needed. Keep track separately whether the format is
5605 multibyte. Keep only the most-recently calculated precision, rather
5606 than them all. Record whether each argument has been converted to
5607 string. Use EMACS_INT, not int, for byte and char and arg counts.
5608 Support field widths and precisions larger than INT_MAX. Avoid
5609 sprintf's undefined behavior with conversion specifications such as %#d
5610 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5611 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5612 formatting out-of-range floating point numbers with int
5615 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5617 * data.c: Avoid integer truncation in expressions involving floats.
5618 * data.c: Include <intprops.h>.
5619 (arith_driver): When there's an integer overflow in an expression
5620 involving floating point, convert the integers to floating point
5621 so that the resulting value does not suffer from catastrophic
5622 integer truncation. For example, on a 64-bit host (* 4
5623 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5624 Do not rely on undefined behavior after integer overflow.
5626 merge count_size_as_multibyte, parse_str_to_multibyte
5627 * character.c, character.h (count_size_as_multibyte):
5628 Rename from parse_str_to_multibyte; all uses changed.
5629 Check for integer overflow.
5630 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5631 since it's now a duplicate of the other. This is more of
5632 a character than a buffer op, so better that it's in character.c.
5633 * fns.c, print.c: Adjust to above changes.
5635 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5637 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5639 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5641 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5642 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5643 (x_clipboard_manager_save): Now static.
5644 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5646 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5647 (crypto_hash_function): Now static.
5648 Fix pointer signedness problems. Avoid unnecessary initializations.
5650 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5652 * termhooks.h (Vselection_alist): Make it terminal-local.
5654 * terminal.c (create_terminal): Initialize it.
5656 * xselect.c: Support for clipboard managers.
5657 (Vselection_alist): Move to termhooks.h as terminal-local var.
5658 (LOCAL_SELECTION): New macro.
5659 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5660 (symbol_to_x_atom): Remove gratuitous arg.
5661 (x_handle_selection_request, lisp_data_to_selection_data)
5662 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5663 (x_own_selection, x_get_local_selection, x_convert_selection):
5664 New arg, specifying work frame. Use terminal-local Vselection_alist.
5665 (some_frame_on_display): Delete unused function.
5666 (Fx_own_selection_internal, Fx_get_selection_internal)
5667 (Fx_disown_selection_internal, Fx_selection_owner_p)
5668 (Fx_selection_exists_p): New optional frame arg.
5669 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5670 (x_handle_selection_clear): Don't treat other terminals with the
5671 same keyboard specially. Use the terminal-local Vselection_alist.
5672 (x_clear_frame_selections): Use Frun_hook_with_args.
5674 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5676 * xterm.h: Add support for those atoms.
5678 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5680 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5681 (converted_selections, conversion_fail_tag): New global variables.
5682 (x_selection_request_lisp_error): Free the above.
5683 (x_get_local_selection): Remove unnecessary code.
5684 (x_reply_selection_request): Args changed; handle arbitrary array
5685 of converted selections stored in converted_selections.
5686 Separate the XChangeProperty and SelectionNotify steps.
5687 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5688 (x_convert_selection): New function.
5689 (x_handle_selection_event): Simplify.
5690 (x_get_foreign_selection): Don't ignore incoming requests while
5691 waiting for an answer; this will fail when we implement
5692 SAVE_TARGETS, and seems unnecessary anyway.
5693 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5694 (Vx_sent_selection_functions): Doc fix.
5696 2011-05-26 Leo Liu <sdl.web@gmail.com>
5698 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5700 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5702 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5704 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5705 for fringe update if it has periodic bitmap.
5706 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5707 and fringe_bitmap_periodic_p.
5709 * fringe.c (get_fringe_bitmap_data): New function.
5710 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5711 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5712 row. Mark glyph row for fringe update if periodicity changed.
5714 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5715 for fringe update unless it has periodic bitmap.
5717 2011-05-25 Kenichi Handa <handa@m17n.org>
5719 * xdisp.c (get_next_display_element): Set correct it->face_id for
5720 a static composition.
5722 2011-05-24 Leo Liu <sdl.web@gmail.com>
5725 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5727 * fns.c (crypto_hash_function, Fsha1): New function.
5728 (Fmd5): Use crypto_hash_function.
5729 (syms_of_fns): Add Ssha1.
5731 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5733 * gnutls.c: Remove unused macros.
5734 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5735 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5736 Remove macros that are defined and never used.
5737 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5739 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5741 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5742 (Fx_get_selection_internal): Minor cleanup.
5743 (Fx_own_selection_internal): Rename arguments for consistency with
5746 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5748 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5750 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5752 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5754 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5756 * dispnew.c (scrolling_window): Don't exclude the case that the
5757 last enabled row in the desired matrix touches the bottom boundary.
5759 2011-05-21 Glenn Morris <rgm@gnu.org>
5761 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5762 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5763 and add some more files.
5765 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5767 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5768 report_file_error introduced by the change from 2011-05-07.
5770 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5772 * systime.h (Time): Define only if emacs is defined.
5773 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5774 where the include path doesn't have X11/X.h by default. See
5775 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5777 2011-05-20 Kenichi Handa <handa@m17n.org>
5779 * composite.c (find_automatic_composition): Fix previous change.
5781 2011-05-20 Glenn Morris <rgm@gnu.org>
5783 * lisp.mk: New file, split from Makefile.in.
5784 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5785 (shortlisp): Remove.
5786 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5788 2011-05-19 Glenn Morris <rgm@gnu.org>
5790 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5791 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5792 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5793 (lisp): Set the order to that of loadup.el.
5794 (shortlisp): Make it a copy of $lisp.
5795 (SOME_MACHINE_LISP): Remove.
5796 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5797 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5799 2011-05-18 Kenichi Handa <handa@m17n.org>
5801 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5802 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5803 (find_automatic_composition): Mostly rewrite for efficiency.
5805 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5807 * makefile.w32-in: Update dependencies.
5809 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5811 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5812 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5814 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5816 Fix some integer overflow issues, such as string length overflow.
5818 * insdel.c (count_size_as_multibyte): Check for string overflow.
5820 * character.c (lisp_string_width): Check for string overflow.
5821 Use EMACS_INT, not int, for string indexes and lengths; in
5822 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5823 the resulting string length overflows an EMACS_INT; instead,
5824 report a string overflow if no precision given. When checking for
5825 precision exhaustion, use a check that cannot possibly have
5826 integer overflow. (Bug#8675)
5827 * character.h (lisp_string_width): Adjust to new signature.
5829 * alloc.c (string_overflow): New function.
5830 (Fmake_string): Use it. This doesn't change behavior, but saves
5831 a few bytes and will simplify future changes.
5832 * character.c (string_escape_byte8): Likewise.
5833 * lisp.h (string_overflow): New decl.
5835 Fixups, following up to the user-interface timestamp change.
5836 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5837 for UI timestamps, instead of unsigned long.
5838 * msdos.c (mouse_get_pos): Likewise.
5839 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5840 * w32gui.h (Time): Define by including "systime.h" rather than by
5841 declaring it ourselves. (Bug#8664)
5843 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5844 * image.c (clear_image_cache): Likewise.
5846 * term.c (term_mouse_position): Don't assume time_t wraparound.
5848 Be more systematic about user-interface timestamps.
5849 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5850 and sometimes 'EMACS_UINT', to represent these timestamps.
5851 This change causes it to use 'Time' uniformly, as that's what X uses.
5852 This makes the code easier to follow, and makes it easier to catch
5853 integer overflow bugs such as Bug#8664.
5854 * frame.c (Fmouse_position, Fmouse_pixel_position):
5855 Use Time, not unsigned long, for user-interface timestamps.
5856 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5857 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5858 * keyboard.h (last_event_timestamp): Likewise.
5859 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5860 * menu.h (xmenu_show): Likewise.
5861 * term.c (term_mouse_position): Likewise.
5862 * termhooks.h (struct input_event.timestamp): Likewise.
5863 (struct terminal.mouse_position_hook): Likewise.
5864 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5865 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5866 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5867 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5869 * menu.h, termhooks.h: Include "systime.h", for Time.
5871 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5872 Don't assume that the difference between two unsigned long values
5873 can fit into an integer. At this point, we know button_down_time
5874 <= event->timestamp, so the difference must be nonnegative, so
5875 there's no need to cast the result if double-click-time is
5876 nonnegative, as it should be; check that it's nonnegative, just in
5877 case. This bug is triggered when events are more than 2**31 ms
5878 apart (about 25 days). (Bug#8664)
5880 * xselect.c (last_event_timestamp): Remove duplicate decl.
5881 (x_own_selection): Remove needless cast to unsigned long.
5883 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5884 that always fit in int. Use a sentinel instead of a counter, to
5885 avoid a temp and to allay GCC's concerns about possible int overflow.
5886 * frame.h (struct frame): Use int for menu_bar_items_used
5887 instead of EMACS_INT, since it always fits in int.
5889 * menu.c (grow_menu_items): Check for int overflow.
5891 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5893 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5894 Before, the code was not consistent. These values cannot exceed
5895 2**31 - 1 so there's no need to make them unsigned.
5896 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5897 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5898 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5900 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5902 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5903 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5904 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5905 presumably because the widths might not match.
5907 * window.c (size_window): Avoid needless test at loop start.
5909 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5911 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5913 2011-05-12 Drew Adams <drew.adams@oracle.com>
5915 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5917 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5919 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5920 `width' to `bar_area_x' and `bar_area_width', respectively.
5921 (x_scroll_run): Take account of fringe background extension.
5923 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5924 Rename local vars `left' and `width' to `bar_area_x' and
5925 `bar_area_width', respectively.
5926 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5927 background extension.
5929 2011-05-10 Jim Meyering <meyering@redhat.com>
5931 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5933 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5935 * image.c (Finit_image_library): Return t for built-in image types,
5936 like pbm and xbm. (Bug#8640)
5938 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5940 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5942 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5944 * w32console.c (Fset_screen_color): Doc fix.
5945 (Fget_screen_color): New function.
5946 (syms_of_ntterm): Defsubr it.
5948 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5949 unlink the temporary file if Fcall_process didn't create it in the
5951 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5952 child process will be redirected to a file specified with `:file'.
5953 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5954 cue to call_process_cleanup not to close that handle.
5956 2011-05-07 Ben Key <bkey76@gmail.com>
5958 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5959 one of two shell specific rules, either bootstrap-temacs-CMD or
5960 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5961 to the previous implementation of the bootstrap-temacs rule.
5962 The bootstrap-temacs-CMD rule is similar to the previous
5963 implementation of the bootstrap-temacs rule except that it
5964 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5967 These changes, along with some changes to nt/configure.bat,
5968 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5969 earlier fix to add support for --cflags and --ldflags options
5970 that include quotes so that it works whether make uses cmd or
5973 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5975 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5976 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5978 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5979 a string. Handle both cases.
5980 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5981 (Fdbus_register_method): Use Qinvalid_function.
5983 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5985 * makefile.w32-in: Update dependencies.
5986 (LISP_H): Add inttypes.h and stdin.h.
5987 (PROCESS_H): Add unistd.h.
5989 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5991 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5992 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5994 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5996 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5998 * term.c (vfatal): Remove stray call to va_end.
5999 It's not needed and the C Standard doesn't allow it here anyway.
6001 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6002 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6004 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6007 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6009 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6011 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6013 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6015 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6017 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6018 * charset.c (Fdefine_charset_internal): Don't initialize
6019 charset.code_space[15]. The value was garbage, on hosts with
6020 32-bit int (Bug#8600).
6022 * lread.c (read_integer): Be more consistent with string-to-number.
6023 Use string_to_number to do the actual conversion; this avoids
6024 rounding errors and fixes some other screwups. Without this fix,
6025 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6026 (digit_to_number): Move earlier, for benefit of read_integer.
6027 Return -1 if the digit is out of range for the base, -2 if it is
6028 not a digit in any supported base. (Bug#8602)
6030 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6032 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6033 to match comment at start of function. This also removes a
6034 GCC warning about overflow in a 32+64-bit port.
6036 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6038 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6039 Reported by Stefan Monnier in
6040 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6041 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6042 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6044 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6045 (EMACS_UINTPTR): Likewise, with uintptr_t.
6047 * lisp.h: Prefer 64-bit EMACS_INT if available.
6048 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6049 on 32-bit hosts that have 64-bit int, so that they can access
6051 However, temporarily disable this change unless the temporary
6052 symbol WIDE_EMACS_INT is defined.
6054 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6056 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6057 This removes an assumption that EMACS_INT and long are the same
6058 width as pointers. The assumption is true for Emacs porting targets
6059 now, but we want to make other targets possible.
6060 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6061 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6062 In the rest of the code, change types of integers that hold casted
6063 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6064 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6065 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6066 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6067 No need to cast type when ORing.
6068 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6069 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6070 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6071 assume EMACS_INT is the same width as char *.
6072 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6073 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6074 Remove no-longer-needed casts.
6075 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6076 (xg_tool_bar_help_callback, xg_make_tool_item):
6077 Use EMACS_INTPTR to hold an integer
6078 that will be cast to void *; this can avoid a GCC warning
6079 if EMACS_INT is not the same width as void *.
6080 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6081 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6082 (current_message_1, set_message_1):
6083 Use a local to convert to proper width without a cast.
6084 * xmenu.c (dialog_selection_callback): Likewise.
6086 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6087 Also, don't assume VALBITS / RAND_BITS is less than 5,
6088 and don't rely on undefined behavior when shifting a 1 left into
6090 * lisp.h (get_random): Change signature to match.
6092 * lread.c (hash_string): Use size_t, not int, for hash computation.
6093 Normally we prefer signed values; but hashing is special, because
6094 it's better to use unsigned division on hash table sizes so that
6095 the remainder is nonnegative. Also, size_t is the natural width
6096 for hashing into memory. The previous code used 'int', which doesn't
6097 retain enough info to hash well into very large tables.
6098 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6100 * dbusbind.c: Don't possibly lose pointer info when converting.
6101 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6102 Use XPNTR rather than XHASH, so that the high-order bits of
6103 the pointer aren't lost when converting through void *.
6105 * eval.c (Fautoload): Don't double-shift a pointer.
6107 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6109 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6111 * gnutls.c (DEF_GNUTLS_FN):
6112 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6114 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6116 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6119 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6121 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6122 New version that can reserve upto 2GB of heap space.
6124 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6126 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6128 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6130 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6131 `gnutls_certificate_set_x509_key_file'.
6133 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6135 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6136 Update dependencies.
6138 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6140 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6141 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6142 Remove unused parameter `fildes'.
6143 * process.c (read_process_output, send_process): Don't pass it.
6145 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6147 Fix previous change: the library cache is defined in w32.c.
6148 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6149 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6151 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6153 Implement dynamic loading of GnuTLS on Windows.
6155 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6156 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6157 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6160 * gnutls.c (Qgnutls_dll): Define.
6161 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6162 (gnutls_*): Declare function pointers.
6163 (init_gnutls_functions): New function to initialize function pointers.
6164 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6165 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6166 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6167 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6168 (emacs_gnutls_write, emacs_gnutls_read)
6169 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6170 (Fgnutls_available_p): New function.
6171 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6172 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6173 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6175 * image.c: Include w32.h.
6176 (Vimage_type_cache): Delete.
6177 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6178 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6179 (w32_delayed_load): Move to w32.c.
6181 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6183 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6184 (w32_delayed_load): Move from image.c. When loading a library, record
6185 its filename in the :loaded-from property of the library id.
6186 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6187 Initialize and staticpro them.
6188 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6190 * process.c: Include lisp.h before w32.h, not after.
6191 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6192 instead of gnutls_record_check_pending.
6194 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6196 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6198 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6199 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6202 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6204 * xterm.c (x_set_frame_alpha): Do not set property on anything
6205 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6207 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6209 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6211 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6213 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6214 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6215 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6216 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6217 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6218 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6219 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6220 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6221 (Qgnutls_bootprop_callbacks_verify): Make static.
6223 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6225 * callproc.c: Indentation fixup.
6227 * sysdep.c (wait_for_termination_1): Make static.
6228 (wait_for_termination, interruptible_wait_for_termination):
6229 Move after wait_for_termination_1.
6231 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6233 * sysdep.c (interruptible_wait_for_termination): New function
6234 which is like wait_for_termination, but allows keyboard
6237 * callproc.c (Fcall_process): Add (:file "file") as an option for
6239 (Fcall_process_region): Ditto.
6241 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6243 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6244 rather than `XVECTOR (FOO)->size'.
6246 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6247 inttypes.h, as a gnulib replacement is used if it not available in
6250 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6252 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6253 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6254 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6256 * coding.c (coding_alloc_by_realloc): Error out if destination
6257 will grow beyond MOST_POSITIVE_FIXNUM.
6258 (decode_coding_emacs_mule): Abort if there isn't enough place in
6259 charbuf for the composition carryover bytes. Reserve an extra
6260 space for up to 2 characters produced in a loop.
6261 (decode_coding_iso_2022): Abort if there isn't enough place in
6262 charbuf for the composition carryover bytes.
6264 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6266 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6267 aborting when %lld or %lll format is passed.
6268 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6269 %llo or %llx format is passed. (Bug#8545)
6271 * window.c (window_scroll_line_based): Use a marker instead of
6272 simple variables to record original value of point. (Bug#7952)
6274 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6275 produced by %s or %c overflows available buffer space. (Bug#8545)
6277 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6279 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6280 (SIZE_MAX): Move defn after all includes, as they might #define it.
6282 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6284 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6286 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6288 * keyboard.c (Qdelayed_warnings_hook): Define.
6289 (command_loop_1): Run `delayed-warnings-hook'
6290 if Vdelayed_warnings_list is non-nil.
6291 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6292 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6294 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6296 * doprnt.c (doprnt): Don't return value smaller than the buffer
6297 size if the message was truncated. (Bug#8545).
6299 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6301 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6302 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6304 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6306 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6308 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6310 * makefile.w32-in: Update dependencies.
6312 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6314 Improve `doprnt' and its usage. (Bug#8545)
6315 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6316 `format_end'. Remove support for %l as a conversion specifier.
6317 Don't use xrealloc. Improve diagnostics when the %l size modifier
6318 is used. Update the commentary.
6320 * eval.c (verror): Simplify calculation of size_t.
6322 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6325 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6327 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6330 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6332 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6333 This makes this file independent of the recent pseudovector change.
6335 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6337 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6339 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6340 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6341 Remove unused local.
6342 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6344 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6345 GCC 4.6.0 optimizes based on type-based alias analysis.
6346 For example, if b is of type struct buffer * and v of type struct
6347 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6348 != &v->size, and therefore "v->size = 1; b->size = 2; return
6349 v->size;" must therefore return 1. This assumption is incorrect
6350 for Emacs, since it type-puns struct Lisp_Vector * with many other
6351 types. To fix this problem, this patch adds a new type struct
6352 vectorlike_header that documents the constraints on layout of vectors
6353 and pseudovectors, and helps optimizing compilers not get fooled
6354 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6355 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6356 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6358 (XSETPVECTYPE): Rewrite in terms of new macro.
6359 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6360 This is a bit clearer, and further avoids the possibility of
6361 undesirable aliasing.
6362 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6363 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6364 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6365 since Lisp_Subr is a special case (no "next" field).
6366 (ASIZE): Now uses header.size rather than size.
6367 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6368 to avoid the hassle of writing XVECTOR (foo)->header.size.
6369 (struct vectorlike_header): New type.
6370 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6371 object, to help avoid aliasing.
6372 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6373 (SUBRP): Likewise, since Lisp_Subr is a special case.
6374 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6375 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6376 (struct Lisp_Hash_Table): Combine first two members into a single
6377 struct vectorlike_header member. All uses of "size" and "next" members
6378 changed to be "header.size" and "header.next".
6379 * buffer.h (struct buffer): Likewise.
6380 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6381 * frame.h (struct frame): Likewise.
6382 * process.h (struct Lisp_Process): Likewise.
6383 * termhooks.h (struct terminal): Likewise.
6384 * window.c (struct save_window_data, struct saved_window): Likewise.
6385 * window.h (struct window): Likewise.
6386 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6387 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6388 * buffer.c (init_buffer_once): Likewise.
6389 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6391 * process.c (Fformat_network_address): Use local var for size,
6394 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6396 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6397 * data.c (atof): Remove decl; no longer used or needed.
6398 (digit_to_number): Move to lread.c.
6399 (Fstring_to_number): Use new string_to_number function, to be
6400 consistent with how the Lisp reader treats infinities and NaNs.
6401 Do not assume that floating-point numbers represent EMACS_INT
6402 without losing information; this is not true on most 64-bit hosts.
6403 Avoid double-rounding errors, by insisting on integers when
6404 parsing non-base-10 numbers, as the documentation specifies.
6405 * lisp.h (string_to_number): New decl, replacing ...
6406 (isfloat_string): Remove.
6407 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6408 (read1): Do not accept +. and -. as integers; this
6409 appears to have been a coding error. Similarly, do not accept
6410 strings like +-1e0 as floating point numbers. Do not report
6411 overflow for integer overflows unless the base is not 10 which
6412 means we have no simple and reliable way to continue.
6413 Break out the floating-point parsing into a new
6414 function string_to_number, so that Fstring_to_number parses
6415 floating point numbers consistently with the Lisp reader.
6416 (digit_to_number): Move here from data.c. Make it static inline.
6417 (E_CHAR, EXP_INT): Remove, replacing with ...
6418 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6419 (string_to_number): New function, replacing isfloat_string.
6420 This function checks for valid syntax and produces the resulting
6421 Lisp float number too. Rework it so that string-to-number
6422 no longer mishandles examples like "1.0e+". Use strtoumax,
6423 so that overflow for non-base-10 numbers is reported only when
6424 there's no portable and simple way to convert to floating point.
6426 * textprop.c (set_text_properties_1): Rewrite for clarity,
6427 and to avoid GCC warning about integer overflow.
6429 * intervals.h (struct interval): Use EMACS_INT for members
6430 where EMACS_UINT might cause problems. See
6431 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6432 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6433 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6435 (offset_intervals): Tell GCC not to worry about length overflow
6436 when negating a negative length.
6438 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6439 (overrun_check_free): Likewise.
6441 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6442 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6445 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6446 (gnutls_make_error): Rename local to avoid shadowing.
6447 (gnutls_emacs_global_deinit): ifdef out; not used.
6448 (Fgnutls_boot): Use const for pointer to readonly storage.
6449 Comment out unused local. Fix pointer signedness problems.
6451 * lread.c (openp): Don't stuff size_t into an 'int'.
6452 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6453 about possible signed overflow.
6455 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6456 (GDK_KEY_g): Don't define if already defined.
6457 (xg_prepare_tooltip): Avoid pointer signedness problem.
6458 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6460 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6461 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6463 * xfns.c (Fx_window_property): Simplify a bit,
6464 to make a bit faster and to avoid GCC 4.6.0 warning.
6465 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6467 * fns.c (internal_equal): Don't assume size_t fits in int.
6469 * alloc.c (compact_small_strings): Tighten assertion a little.
6471 Replace pEd with more-general pI, and fix some printf arg casts.
6472 * lisp.h (pI): New macro, generalizing old pEd macro to other
6473 conversion specifiers. For example, use "...%"pI"d..." rather
6474 than "...%"pEd"...".
6475 (pEd): Remove. All uses replaced with similar uses of pI.
6476 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6477 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6478 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6479 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6480 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6481 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6482 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6484 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6485 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6486 * print.c (safe_debug_print, print_object): Likewise.
6487 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6489 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6490 avoiding the 0 flag, which is not portable.
6491 * process.c (Fmake_network_process): Use pI to avoid cast.
6492 * region-cache.c (pp_cache): Likewise.
6493 * xdisp.c (decode_mode_spec): Likewise.
6494 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6495 behavior on 64-bit hosts with printf arg.
6496 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6497 (x_stop_queuing_selection_requests): Likewise.
6498 (x_get_window_property): Don't truncate byte count to an 'int'
6501 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6502 here, since it parses constructs like leading '-' and spaces,
6503 which are not wanted; and it overflows with large numbers.
6504 Instead, simply match F[0-9]+, which is what is wanted anyway.
6506 * alloc.c: Remove unportable assumptions about struct layout.
6507 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6508 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6509 (allocate_vectorlike, make_pure_vector): Use the new macros,
6510 plus offsetof, to remove unportable assumptions about struct layout.
6511 These assumptions hold on all porting targets that I know of, but
6512 they are not guaranteed, they're easy to remove, and removing them
6513 makes further changes easier.
6515 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6516 This doesn't fix a bug but makes the code clearer.
6517 (string_overrun_cookie): Now const. Use initializers that
6518 don't formally overflow signed char, to avoid warnings.
6519 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6520 can cause Emacs to crash when string overrun checking is enabled.
6521 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6522 multiple of sizeof (EMACS_INT); it need not be, if
6523 alignof(EMACS_INT) < sizeof (EMACS_INT).
6524 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6526 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6528 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6530 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6532 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6533 supposed to be handshaking. (Bug#8556)
6534 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6536 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6538 * lisp.h (Qdebug): List symbol.
6539 * eval.c (Qdebug): Restore global linkage.
6540 * keyboard.c (debug-on-event): New variable.
6541 (handle_user_signal): Break into debugger when debug-on-event
6542 matches the current signal symbol.
6544 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6546 * alloc.c (check_sblock, check_string_bytes)
6547 (check_string_free_list): Convert to standard C.
6549 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6551 * w32.c (emacs_gnutls_push): Fix typo.
6553 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6555 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6556 "cast to pointer from integer of different size".
6558 Improve doprnt and its use in verror. (Bug#8545)
6559 * doprnt.c (doprnt): Document the set of format control sequences
6560 supported by the function. Use SAFE_ALLOCA instead of always
6563 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6564 is one byte too soon. Don't use xrealloc; instead xfree and
6567 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6569 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6572 * gnutls.c: Renamed global_initialized to
6573 gnutls_global_initialized. Added internals for the
6574 :verify-hostname-error, :verify-error, and :verify-flags
6575 parameters of `gnutls-boot' and documented those parameters in the
6576 docstring. Start callback support.
6577 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6578 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6579 on error. Return error code.
6580 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6581 (emacs_gnutls_read): Likewise.
6582 (Fgnutls_boot): Return handshake error code.
6583 (emacs_gnutls_handle_error): New function.
6584 (wsaerror_to_errno): Likewise.
6586 * w32.h (emacs_gnutls_pull): Add prototype.
6587 (emacs_gnutls_push): Likewise.
6589 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6590 (emacs_gnutls_push): Likewise.
6592 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6594 * process.c (wait_reading_process_output): Check if GnuTLS
6595 buffered some data internally if no FDs are set for TLS
6598 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6599 (LIBS): Link to USER_LIBS.
6600 ($(BLD)/gnutls.$(0)): New target.
6602 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6604 * xdisp.c (handle_single_display_spec): Rename the
6605 display_replaced_before_p argument into display_replaced_p, to
6606 make it consistent with the commentary. Fix typos in the
6609 * textprop.c (syms_of_textprop): Remove dead code.
6610 (copy_text_properties): Delete obsolete commentary about an
6611 interface that was deleted long ago. Fix typos in the description
6614 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6615 to changes in oldXMenu/XMenu.h from 2011-04-16.
6616 <menu_help_message, prev_menu_help_message>: Constify.
6617 (IT_menu_make_room): menu->help_text is now `const char **';
6620 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6621 to changes in oldXMenu/XMenu.h from 2011-04-16.
6622 (struct XMenu): Declare `help_text' `const char **'.
6624 * xfaces.c <Qunspecified>: Make extern again.
6626 * syntax.c: Include sys/types.h before including regex.h, as
6629 * doc.c (get_doc_string): Improve the format passed to `error'.
6631 * doprnt.c (doprnt): Improve commentary.
6633 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6635 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6638 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6639 changes in globals.h immediately force recompilation.
6640 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6641 $(CURDIR)/s/ms-w32.h.
6642 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6644 * character.c (Fchar_direction): Function deleted.
6645 (syms_of_character): Don't defsubr it.
6646 <char-direction-table>: Deleted.
6648 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6650 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6651 * doprnt.c: Include limits.h.
6652 (SIZE_MAX): New macro.
6653 (doprnt): Return a size_t value. 2nd arg is now size_t.
6654 Many local variables are now size_t instead of int or unsigned.
6655 Improve overflow protection. Support `l' modifier for integer
6656 conversions. Support %l conversion. Don't assume an EMACS_INT
6657 argument for integer conversions and for %c.
6659 * lisp.h (doprnt): Restore prototype.
6661 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6664 * Makefile.in (base_obj): Add back doprnt.o.
6666 * deps.mk (doprnt.o): Add back prerequisites.
6667 (callint.o): Depend on character.h.
6669 * eval.c (internal_lisp_condition_case): Include the handler
6670 representation in the error message.
6671 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6672 when breaking from the loop.
6674 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6676 * callint.c (Fcall_interactively): When displaying error message
6677 about invalid control letter, pass the character's codepoint, not
6678 a pointer to its multibyte form. Improve display of the character
6679 in octal and display also its hex code.
6681 * character.c (char_string): Use %x to display the (unsigned)
6682 codepoint of an invalid character, to avoid displaying a bogus
6685 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6686 `error', not SYMBOL_NAME itself.
6688 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6689 character arguments to `error'.
6691 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6692 to `error' in error message about FINAL_CHAR argument. Make sure
6693 FINAL_CHAR is a character, and use %c when it is passed as
6694 argument to `error'.
6696 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6698 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6700 * w32.c: Include <time.h>.
6701 (sys_localtime): New function.
6703 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6705 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6707 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6709 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6711 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6714 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6716 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6717 gl_state.e_property when gl_state.object is Qt.
6719 * insdel.c (make_gap_larger): Remove limitation of buffer size
6722 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6724 * xdisp.c (lookup_glyphless_char_display)
6725 (produce_glyphless_glyph): Handle cons cell entry in
6726 glyphless-char-display.
6727 (Vglyphless_char_display): Document it.
6729 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6730 glyphless-char-display.
6732 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6734 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6736 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6738 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6739 definition for no-X builds.
6741 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6743 Static checks with GCC 4.6.0 and non-default toolkits.
6745 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6747 * process.c (keyboard_bit_set): Define only if SIGIO.
6748 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6749 (send_process): Repair possible setjmp clobbering.
6751 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6753 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6755 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6757 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6758 Define only if needed.
6760 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6761 by pacifying GCC about it. Maybe it's time to retire it?
6762 * xfaces.c (USG, __TIMEVAL__): Likewise.
6764 * dispextern.h (struct redisplay_interface): Rename param
6766 * termhooks.h (struct terminal): Likewise.
6767 * xterm.c (xembed_send_message): Likewise.
6769 * insdel.c (make_gap_smaller): Define only if
6770 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6772 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6775 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6776 so that we aren't warned about unused symbols.
6778 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6780 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6782 * xfns.c (x_real_positions): Mark locals as initialized.
6784 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6786 * xterm.c: Fix problems found by static analysis with other toolkits.
6787 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6788 (x_dispatch_event): Declare static if USE_GTK, and
6789 define if USE_GTK || USE_X_TOOLKIT.
6790 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6791 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6792 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6793 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6795 * xmenu.c (menu_help_callback): Pointer type fixes.
6796 Use const pointers when pointing at readonly data. Avoid pointer
6798 (FALSE): Remove unused macro.
6799 (update_frame_menubar): Remove unused decl.
6801 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6803 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6804 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6805 (single_menu_item): Rename local to avoid shadowing.
6807 * keyboard.c (make_lispy_event): Remove unused local var.
6809 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6810 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6812 * bitmaps: Change bitmaps from unsigned char back to the X11
6813 compatible char. Avoid the old compiler warnings about
6814 out-of-range initializers by using, for example, '\xab' rather
6817 * xgselect.c (xgselect_initialize): Check vs interface
6818 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6820 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6822 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6823 to read-only memory.
6825 * fns.c (vector): Remove; this old hack is no longer needed.
6827 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6829 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6831 * xrdb.c (x_load_resources): Omit unused local.
6833 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6834 (x_window): Rename locals to avoid shadowing.
6835 (USG): Use the kludged USG macro, to pacify gcc.
6837 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6838 (x_term_init): Remove local to avoid shadowing.
6840 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6842 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6843 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6845 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6847 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6849 Fix regex.c, syntax.c and friends for buffers > 2GB.
6850 * syntax.h (struct gl_state_s): Declare character position members
6853 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6855 * textprop.c (verify_interval_modification, interval_of):
6856 Declare arguments EMACS_INT.
6858 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6861 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6863 * indent.c (Fvertical_motion): Local variable it_start is now
6866 * regex.c (re_match, re_match_2, re_match_2_internal)
6867 (bcmp_translate, regcomp, regexec, print_double_string)
6868 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6869 (re_compile_pattern, re_exec): Declare arguments and local
6870 variables `size_t' and `ssize_t' and return values `regoff_t', as
6872 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6873 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6874 <compile_stack_type>: `size' and `avail' are now `size_t'.
6876 * regex.h <regoff_t>: Use ssize_t, not int.
6877 (re_search, re_search_2, re_match, re_match_2): Arguments that
6878 specify buffer/string position and length are now ssize_t and
6879 size_t. Return type is regoff_t.
6881 2011-04-16 Ben Key <bkey76@gmail.com>
6883 * nsfont.m: Fixed bugs in ns_get_family and
6884 ns_descriptor_to_entity that were caused by using free to
6885 deallocate memory blocks that were allocated by xmalloc (via
6886 xstrdup). This caused Emacs to crash when compiled with
6887 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6888 --enable-checking=xmallocoverrun). xfree is now used to
6889 deallocate these memory blocks.
6891 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6893 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6895 emacs_write: Accept and return EMACS_INT for sizes.
6896 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6898 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6899 Accept and return EMACS_INT.
6900 (emacs_gnutls_write): Return the number of bytes written on
6902 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6903 (emacs_read, emacs_write): Remove check for negative size, as the
6904 Emacs source code has been audited now.
6905 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6906 (emacs_read, emacs_write): Use it.
6907 * process.c (send_process): Adjust to the new signatures of
6908 emacs_write and emacs_gnutls_write. Do not attempt to store
6909 a byte offset into an 'int'; it might overflow.
6910 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6912 * sound.c: Don't assume sizes fit in 'int'.
6913 (struct sound_device.period_size, alsa_period_size):
6914 Return EMACS_INT, not int.
6915 (struct sound_device.write, vox_write, alsa_write):
6916 Accept EMACS_INT, not int.
6917 (wav_play, au_play): Use EMACS_INT to store sizes and to
6918 record read return values.
6920 2011-04-15 Ben Key <bkey76@gmail.com>
6922 * keyboard.c (Qundefined): Don't declare static since it is used
6924 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6925 static since they are used in nsfont.m.
6927 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6929 * process.c (Qprocessp): Don't declare static.
6930 * lisp.h (Qprocessp): Declare again.
6932 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6934 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6936 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6938 Improve C-level modularity by making more things 'static'.
6940 Don't publish debugger-only interfaces to other modules.
6941 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6942 (verify_bytepos, count_markers): Move decls to the only modules
6944 * region-cache.h (pp_cache): Likewise.
6945 * window.h (check_all_windows): Likewise.
6946 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6948 * sysdep.c (croak): Now static, if
6949 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6950 * syssignal.h (croak): Declare only if not static.
6952 * alloc.c (refill_memory_reserve): Now static if
6953 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6954 * lisp.h (refill_memory_reserve): Declare only if not static.
6956 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6957 Define only if USE_LUCID.
6959 * xrdb.c (x_customization_string, x_rm_string): Now static.
6961 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6962 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6964 * xdisp.c (draw_row_with_mouse_face): Now static.
6965 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6967 * window.h (check_all_windows): Mark externally visible.
6969 * window.c (window_deletion_count): Now static.
6971 * undo.c: Make symbols static if they're not exported.
6972 (last_undo_buffer, last_boundary_position, pending_boundary):
6975 * textprop.c (interval_insert_behind_hooks): Now static.
6976 (interval_insert_in_front_hooks): Likewise.
6978 * term.c: Make symbols static if they're not exported.
6979 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6980 (max_frame_lines, tty_set_terminal_modes):
6981 (tty_reset_terminal_modes, tty_turn_off_highlight):
6982 (get_tty_terminal): Now static.
6983 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6984 * termhooks.h (term_mouse_moveto): Do not declare if
6986 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6987 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6989 * sysdep.c: Make symbols static if they're not exported.
6990 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6992 (sigprocmask_set, full_mask): Remove; unused.
6993 (wait_debugging): Mark as visible.
6994 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6995 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6997 * syntax.c (syntax_temp): Define only if !__GNUC__.
6999 * sound.c (current_sound_device, current_sound): Now static.
7001 * search.c (searchbufs, searchbuf_head): Now static.
7003 * scroll.c (scroll_cost): Remove; unused.
7004 * dispextern.h (scroll_cost): Remove decl.
7006 * region-cache.h (pp_cache): Mark as externally visible.
7008 * process.c: Make symbols static if they're not exported.
7009 (process_tick, update_tick, create_process, chan_process):
7010 (Vprocess_alist, proc_buffered_char, datagram_access):
7011 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7012 (deactivate_process): Mark defn as static, as well as decl.
7013 * lisp.h (create_process): Remove decl.
7014 * process.h (chan_process, Vprocess_alist): Remove decls.
7016 * print.c: Make symbols static if they're not exported.
7017 (print_depth, new_backquote_output, being_printed, print_buffer):
7018 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7019 (print_interval, print_number_index, initial_stderr_stream):
7021 * lisp.h (Fprinc): Remove decl.
7022 (debug_output_compilation_hack): Mark as externally visible.
7024 * sysdep.c (croak): Move decl from here to syssignal.h.
7025 * syssignal.h (croak): Put it here, so the API can be checked when
7026 'croak' is called from dissociate_if_controlling_tty.
7028 * minibuf.c: Make symbols static if they're not exported.
7029 (minibuf_save_list, choose_minibuf_frame): Now static.
7030 * lisp.h (choose_minibuf_frame): Remove decl.
7032 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7034 * lread.c: Make symbols static if they're not exported.
7035 (read_objects, initial_obarray, oblookup_last_bucket_number):
7037 (make_symbol): Remove; unused.
7038 * lisp.h (initial_obarray, make_symbol): Remove decls.
7040 * keyboard.c: Make symbols static if they're not exported.
7041 (single_kboard, recent_keys_index, total_keys, recent_keys):
7042 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7043 (this_single_command_key_start, echoing, last_auto_save):
7044 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7045 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7046 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7047 (Vlispy_mouse_stem, double_click_count):
7049 (force_auto_save_soon): Define only if SIGDANGER.
7050 (ignore_mouse_drag_p): Now static if
7051 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7052 (print_help): Remove; unused.
7053 (stop_character, last_timer_event): Mark as externally visible.
7054 * keyboard.h (ignore_mouse_drag_p): Declare only if
7055 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7056 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7057 * lisp.h (echoing): Remove decl.
7058 (force_auto_save_soon): Declare only if SIGDANGER.
7059 * xdisp.c (redisplay_window): Simplify code, to make it more
7060 obvious that ignore_mouse_drag_p is not accessed if !defined
7061 USE_GTK && !defined HAVE_NS.
7063 * intervals.c: Make symbols static if they're not exported.
7064 (merge_properties_sticky, merge_interval_right, delete_interval):
7066 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7068 * insdel.c: Make symbols static if they're not exported.
7069 However, leave prepare_to_modify_buffer alone. It's never
7070 called from outside this function, but that appears to be a bug.
7071 (combine_after_change_list, combine_after_change_buffer):
7072 (adjust_after_replace, signal_before_change): Now static.
7073 (adjust_after_replace_noundo): Remove; unused.
7074 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7075 (signal_before_change): Remove decls.
7077 * indent.c (val_compute_motion, val_vmotion): Now static.
7079 * image.c: Make symbols static if they're not exported.
7080 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7082 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7083 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7085 * fringe.c (standard_bitmaps): Now static.
7086 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7088 * frame.c: Make symbols static if they're not exported.
7089 (x_report_frame_params, make_terminal_frame): Now static.
7090 (get_frame_param): Now static, unless HAVE_NS.
7091 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7092 (x_get_resource_string): Remove; not used.
7093 * frame.h (make_terminal_frame, x_report_frame_params):
7094 (x_get_resource_string); Remove decls.
7095 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7096 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7098 * font.c, fontset.c: Make symbols static if they're not exported.
7099 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7100 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7101 * font.c (font_close_object): Now static.
7102 * font.h (font_close_object): Remove.
7103 * fontset.c (FONTSET_OBJLIST): Remove.
7104 (free_realized_fontset) #if-0 the body, which does nothing.
7105 (face_suitable_for_char_p): #if-0, as it's never called.
7106 * fontset.h (face_suitable_for_char_p): Remove decl.
7107 * xfaces.c (face_at_string_position):
7108 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7109 since 0 is always ASCII.
7111 * fns.c (weak_hash_tables): Now static.
7113 * fileio.c: Make symbols static if they're not exported.
7114 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7115 (Vwrite_region_annotation_buffers): Now static.
7117 * eval.c: Make symbols static if they're not exported.
7118 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7119 * lisp.h (backtrace_list): Remove decl.
7121 * emacs.c: Make symbols static if they're not exported.
7122 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7123 (fatal_error_code, fatal_error_signal_hook, standard_args):
7125 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7126 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7127 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7128 * lisp.h (fatal_error_signal_hook): Remove decl.
7129 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7131 * editfns.c: Move a (normally-unused) function to its only use.
7132 * editfns.c, lisp.h (get_operating_system_release): Remove.
7133 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7134 worth the hassle of breaking this out.
7136 * xterm.c: Make symbols static if they're not exported.
7137 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7138 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7139 (x_destroy_window, x_delete_display):
7141 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7142 (x_mouse_leave): Remove; unused.
7143 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7144 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7145 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7147 (x_mouse_leave): Declare only if WINDOWSNT.
7148 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7149 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7152 * ftxfont.c: Make symbols static if they're not exported.
7153 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7155 * font.h (ftxfont_driver): Likewise.
7157 * xfns.c: Make symbols static if they're not exported.
7158 (x_last_font_name, x_display_info_for_name):
7159 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7160 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7161 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7162 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7163 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7164 (last_show_tip_args): Now static.
7165 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7166 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7167 (x_screen_planes): Remove; unused.
7168 * dispextern.h (x_screen_planes): Remove decl.
7170 * dispnew.c: Make symbols static if they're not exported.
7171 * dispextern.h (redraw_garbaged_frames, scrolling):
7172 (increment_row_positions): Remove.
7173 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7174 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7176 (redraw_garbaged_frames): Remove; unused.
7178 * xfaces.c: Make symbols static if they're not exported.
7179 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7181 * xterm.h (defined_color): Remove decls.
7182 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7183 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7184 (menu_face_changed_default, defined_color, free_realized_face):
7185 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7186 (ascii_face_of_lisp_face): Remove; unused.
7188 * xdisp.c: Make symbols static if they're not exported.
7189 * dispextern.h (scratch_glyph_row, window_box_edges):
7190 (glyph_to_pixel_coords, set_cursor_from_row):
7191 (get_next_display_element, set_iterator_to_next):
7192 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7193 (show_mouse_face): Remove decls
7194 * frame.h (message_buf_print): Likewise.
7195 * lisp.h (pop_message, set_message, check_point_in_composition):
7197 * xterm.h (set_vertical_scroll_bar): Likewise.
7198 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7199 (message_buf_print, scratch_glyph_row, displayed_buffer):
7200 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7201 (get_next_display_element, show_mouse_face, window_box_edges):
7202 (frame_to_window_pixel_xy, check_point_in_composition):
7203 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7204 (glyph_to_pixel_coords): Remove; unused.
7206 * dired.c (file_name_completion): Now static.
7208 * dbusbind.c (xd_in_read_queued_messages): Now static.
7210 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7211 * data.c (circular_list_error): Remove.
7213 * commands.h (last_point_position, last_point_position_buffer):
7214 (last_point_position_window): Remove decls.
7215 * keyboard.c: Make these variables static.
7217 * coding.h (coding, code_convert_region, encode_coding_gap):
7219 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7220 (iso_code_class, detect_coding, code_convert_region): Now static.
7221 (encode_coding_gap): Remove; unused.
7223 * chartab.c (chartab_chars, chartab_bits): Now static.
7225 * charset.h (charset_iso_8859_1): Remove decl.
7226 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7229 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7230 * ccl.c (Vccl_program_table): Now static.
7231 (check_ccl_update): Remove; unused.
7233 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7234 * category.h: ... from here.
7235 * category.c (check_category_table, set_category_set): Now static.
7237 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7238 * lisp.h: Remove these decls.
7240 * buffer.c (buffer_count): Remove unused var.
7242 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7243 so that it's not optimized away.
7244 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7245 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7246 exported only to the debugger.
7248 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7249 * atimer.h (run_all_atimers): Remove; not exported.
7251 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7252 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7253 was inaccessible from Lisp.
7254 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7255 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7257 alloc.c: Import and export fewer symbols, and remove unused items.
7258 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7260 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7261 it's not optimized away by whole-program optimization.
7262 (message_enable_multibyte, free_misc): Remove.
7263 (catchlist, handlerlist, mark_backtrace):
7264 Declare only if BYTE_MARK_STACK.
7265 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7266 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7267 (message_enable_multibyte): Remove decl.
7268 (free_misc, interval_free_list, float_block, float_block_index):
7269 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7270 (cons_free_list, last_marked_index):
7272 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7273 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7274 (mark_backtrace): Define only if BYTE_MARK_STACK.
7275 * xdisp.c (message_enable_multibyte): Now static.
7277 Declare Lisp_Object Q* variables to be 'static' if not exported.
7278 This makes it easier for human readers (and static analyzers)
7279 to see whether these variables are used from other modules.
7280 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7281 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7282 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7283 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7284 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7285 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7286 * xmenu.c, xselect.c:
7287 Declare Q* vars static if they are not used in other modules.
7288 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7289 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7290 Remove decls of unexported vars.
7291 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7293 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7295 Make Emacs functions such as Fatom 'static' by default.
7296 This makes it easier for human readers (and static analyzers)
7297 to see whether these functions can be called from other modules.
7298 DEFUN now defines a static function. To make the function external
7299 so that it can be used in other C modules, use the new macro DEFUE.
7300 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7301 (Finit_image_library):
7302 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7303 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7304 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7305 Remove decls, since these functions are now static.
7306 (Funintern, Fget_internal_run_time): New decls, since these functions
7307 were already external.
7309 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7310 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7311 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7312 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7313 * keyboard.c, keymap.c, lread.c:
7314 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7315 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7316 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7317 Mark functions with DEFUE instead of DEFUN,
7318 if they are used in other modules.
7319 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7320 decls for now-static functions.
7321 * buffer.h (Fdelete_overlay): Remove decl.
7322 * callproc.c (Fgetenv_internal): Mark as internal.
7323 * composite.c (Fremove_list_of_text_properties): Remove decl.
7324 (Fcomposition_get_gstring): New forward static decl.
7325 * composite.h (Fcomposite_get_gstring): Remove decl.
7326 * dired.c (Ffile_attributes): New forward static decl.
7327 * doc.c (Fdocumntation_property): New forward static decl.
7328 * eval.c (Ffetch_bytecode): New forward static decl.
7329 (Funintern): Remove extern decl; now in .h file where it belongs.
7330 * fileio.c (Fmake_symbolic_link): New forward static decl.
7331 * image.c (Finit_image_library): New forward static decl.
7332 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7333 * intervals.h (Fprevious_property_change):
7334 (Fremove_list_of_text_properties): Remove decls.
7335 * keyboard.c (Fthis_command_keys): Remove decl.
7336 (Fcommand_execute): New forward static decl.
7337 * keymap.c (Flookup_key): New forward static decl.
7338 (Fcopy_keymap): Now static.
7339 * keymap.h (Flookup_key): Remove decl.
7340 * process.c (Fget_process): New forward static decl.
7341 (Fprocess_datagram_address): Mark as internal.
7342 * syntax.c (Fsyntax_table_p): New forward static decl.
7343 (skip_chars): Remove duplicate decl.
7344 * textprop.c (Fprevious_property_change): New forward static decl.
7345 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7347 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7348 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7350 * editfns.c (Fformat): Remove unreachable code.
7352 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7354 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7357 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7359 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7360 when at ZV. (Bug#8487)
7362 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7364 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7366 * keyboard.c (parse_tool_bar_item): Likewise.
7367 * sound.c (sound_cleanup, alsa_close): Likewise.
7368 * termcap.c (tgetent): Likewise.
7369 * xfns.c (x_default_font_parameter): Likewise.
7370 * xsettings.c (read_and_apply_settings): Likewise.
7372 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7373 (overrun_check_free): Protoize.
7375 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7377 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7378 since callers should never pass a negative size.
7379 Change the signature to match that of plain 'read' and 'write'; see
7380 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7381 * lisp.h: Update prototypes of emacs_write and emacs_read.
7383 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7385 * xdisp.c (redisplay_window): Don't try to determine the character
7386 position of the scroll margin if the window start point w->startp
7387 is outside the buffer's accessible region. (Bug#8468)
7389 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7391 Fix write-region and its subroutines for buffers > 2GB.
7392 * fileio.c (a_write, e_write): Modify declaration of arguments and
7393 local variables to support buffers larger than 2GB.
7394 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7396 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7397 argument, local variables, and return value.
7399 * lisp.h: Update prototypes of emacs_write and emacs_read.
7401 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7403 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7405 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7407 Fix more problems found by GCC 4.6.0's static checks.
7409 * xdisp.c (vmessage): Use a better test for character truncation.
7411 * charset.c (load_charset_map): <, not <=, for optimization,
7412 and to avoid potential problems with integer overflow.
7413 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7414 * casetab.c (set_identity, shuffle): Likewise.
7415 * editfns.c (Fformat): Likewise.
7416 * syntax.c (skip_chars): Likewise.
7418 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7419 This also lets GCC 4.6.0 generate slightly better loop code.
7421 * callint.c (Fcall_interactively): <, not <=, for optimization.
7422 (Fcall_interactively): Count the number of arguments produced,
7423 not the number of arguments given. This is simpler and lets GCC
7424 4.6.0 generate slightly better code.
7426 * ftfont.c: Distingish more carefully between FcChar8 and char.
7427 The previous code passed unsigned char * to a functions like
7428 strlen and xstrcasecmp that expect char *, which does not
7429 conform to the C standard.
7430 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7431 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7432 char * when the C standard requires it.
7434 * keyboard.c (read_char): Remove unused var.
7436 * eval.c: Port to Windows vsnprintf (Bug#8435).
7438 (SIZE_MAX): Define if the headers do not.
7439 (verror): Do not give up if vsnprintf returns a negative count.
7440 Instead, grow the buffer. This ports to Windows vsnprintf, which
7441 does not conform to C99. Problem reported by Eli Zaretskii.
7442 Also, simplify the allocation scheme, by avoiding the need for
7443 calling realloc, and removing the ALLOCATED variable.
7445 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7447 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7448 But keep the doprint source code for now, as we might revamp it
7449 and use it again (Bug#8435).
7450 * lisp.h (doprnt): Remove.
7451 * Makefile.in (base_obj): Remove doprnt.o.
7452 * deps.mk (doprnt.o): Remove.
7454 error: Print 32- and 64-bit integers portably (Bug#8435).
7455 Without this change, on typical 64-bit hosts error ("...%d...", N)
7456 was used to print both 32- and 64-bit integers N, which relied on
7458 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7460 * lisp.h (error, verror): Mark as printf-like functions.
7461 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7462 Report overflow in size calculations when allocating printf buffer.
7463 Do not truncate output string at its first null byte.
7464 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7465 Truncate the output at a character boundary, since vsnprintf does not
7467 * charset.c (check_iso_charset_parameter): Convert internal
7468 character to string before calling 'error', since %c now has the
7470 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7471 overflow when computing char to be passed to 'error'. Do not
7472 pass Lisp_Object to 'error'; pass the integer instead.
7473 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7474 formatted with plain %d.
7476 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7478 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7480 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7482 * xterm.c (x_catch_errors): Remove duplicate declaration.
7484 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7486 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7488 2011-04-10 Jim Meyering <meyering@redhat.com>
7490 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7491 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7492 return ssize_t not "int", and use size_t as the buffer length.
7493 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7494 * gnutls.h: Update declarations.
7495 * process.c (read_process_output): Use ssize_t, to match.
7496 (send_process): Likewise.
7498 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7500 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7502 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7504 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7505 Use unsigned char, to match FcChar8 type definition.
7507 * xterm.c (handle_one_xevent):
7508 * xmenu.c (create_and_show_popup_menu):
7509 * xselect.c (x_decline_selection_request)
7510 (x_reply_selection_request): Avoid type-punned deref of X events.
7512 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7514 Fix some uses of `int' instead of EMACS_INT.
7515 * search.c (string_match_1, fast_string_match)
7516 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7517 (scan_buffer, find_next_newline_no_quit)
7518 (find_before_next_newline, search_command, Freplace_match)
7519 (Fmatch_data): Make some `int' variables be EMACS_INT.
7521 * xdisp.c (display_count_lines): 3rd argument and return value now
7522 EMACS_INT. All callers changed.
7523 (pint2hrstr): Last argument is now EMACS_INT.
7525 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7526 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7527 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7528 (decode_coding_utf_16, decode_coding_emacs_mule)
7529 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7530 (decode_coding_ccl, decode_coding_charset)
7531 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7532 (decode_coding_iso_2022, decode_coding_emacs_mule)
7533 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7534 <char_offset, last_offset>: Declare EMACS_INT.
7535 (encode_coding_utf_8, encode_coding_utf_16)
7536 (encode_coding_emacs_mule, encode_invocation_designation)
7537 (encode_designation_at_bol, encode_coding_iso_2022)
7538 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7539 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7541 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7542 (encode_invocation_designation): Last argument P_NCHARS is now
7544 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7545 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7547 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7550 * ccl.c (Fccl_execute_on_string): Declare some variables
7553 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7555 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7557 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7559 * process.c (Fformat_network_address): Doc fix.
7561 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7563 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7565 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7567 * keyboard.c (read_char): Call Lisp function help-form-show,
7568 instead of using internal_with_output_to_temp_buffer.
7569 (Qhelp_form_show): New var.
7570 (syms_of_keyboard): Use DEFSYM macro.
7572 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7574 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7576 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7578 * process.c (Flist_processes): Remove to Lisp.
7579 (list_processes_1): Delete.
7581 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7583 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7585 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7587 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7589 Fix more problems found by GCC 4.6.0's static checks.
7591 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7593 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7595 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7597 * xdisp.c (vmessage): Mark as a printf-like function.
7599 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7601 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7603 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7604 printf-like functions.
7605 (tiff_load): Add casts to remove these marks before passing them
7606 to system-supplied API.
7608 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7610 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7611 This avoids several warnings with gcc -Wstrict-overflow.
7612 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7613 directly, rather than having caller test rule sign. This avoids
7614 some unnecessary tests.
7615 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7616 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7617 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7619 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7620 (xfont_open): Avoid unnecessary tests.
7622 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7624 * composite.h, composite.c (composition_gstring_put_cache):
7625 Use EMACS_INT, not int, for length.
7627 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7628 breaking out part of COMPOSITION_DECODE_RULE.
7629 (COMPOSITION_DECODE_RULE): Use it.
7630 * composite.c (get_composition_id): Remove unused local vars,
7631 by using the new macro.
7633 * textprop.c (set_text_properties_1): Change while to do-while,
7634 since the condition is always true at first.
7636 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7637 (interval_deletion_adjustment): Return unsigned value.
7640 * process.c (list_processes_1, create_pty, read_process_output):
7641 (exec_sentinel): Remove vars that were set but not used.
7642 (create_pty): Remove unnecessary "volatile"s.
7643 (Fnetwork_interface_info): Avoid possibility of int overflow.
7644 (read_process_output): Do adaptive read buffering even if carryover.
7645 (read_process_output): Simplify nbytes computation if buffered.
7647 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7649 * syntax.c (scan_words): Remove var that was set but not used.
7650 (update_syntax_table): Use unsigned instead of int.
7652 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7653 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7654 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7656 * print.c (print_error_message): Avoid int overflow.
7658 * font.c (font_list_entities): Redo for clarity,
7659 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7661 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7662 (font_score): Avoid potential overflow in diff calculation.
7664 * fns.c (substring_both): Remove var that is set but not used.
7665 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7667 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7669 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7670 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7671 can always succeed if overflow has undefined behavior.
7673 * search.c (boyer_moore, wordify): Remove vars set but not used.
7674 (wordify): Omit three unnecessary tests.
7676 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7677 All callers changed. This avoids the need for an unused var.
7679 * casefiddle.c (casify_region): Remove var that is set but not used.
7681 * dired.c (file_name_completion): Remove var that is set but not used.
7683 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7685 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7686 (Finsert_file_contents): Remove unnecessary code checking fd.
7688 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7689 Check for integer overflow on size calculations.
7691 * buffer.c (Fprevious_overlay_change): Remove var that is set
7694 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7695 Remove vars that are set but not used.
7696 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7697 (timer_check_2): Mark vars as initialized.
7699 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7701 * image.c (lookup_image): Remove var that is set but not used.
7702 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7704 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7705 that are set but not used.
7707 * xfns.c (make_invisible_cursor): Don't return garbage
7708 if XCreateBitmapFromData fails (Bug#8410).
7710 * xselect.c (x_get_local_selection, x_handle_property_notify):
7711 Remove vars that are set but not used.
7713 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7714 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7716 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7717 Remove var that is set but not used.
7718 (scroll_bar_windows_size): Now size_t, not int.
7719 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7722 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7723 (map_tty_color) [!defined MSDOS]: Likewise.
7725 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7727 * coding.c: Remove vars that are set but not used.
7728 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7729 All callers changed.
7730 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7731 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7732 (decode_coding_charset): Remove vars that are set but not used.
7734 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7735 that is set but not used.
7737 * print.c (print_object): Remove var that is set but not used.
7739 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7740 The gnulib version avoids calling malloc in the usual case,
7741 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7742 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7743 * filelock.c (current_lock_owner): Likewise.
7744 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7745 * sysdep.c: Include allocator.h, careadlinkat.h.
7746 (emacs_no_realloc_allocator): New static constant.
7747 (emacs_readlink): New function.
7748 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7749 ../lib/careadlinkat.h.
7751 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7753 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7754 first non-nil return value).
7756 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7758 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7759 if not defined (Bug#8403).
7761 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7763 * xdisp.c (display_count_lines): Remove parameter `start',
7764 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7765 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7766 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7767 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7768 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7769 and thereabouts. All callers changed.
7770 (get_per_char_metric): Remove parameter `f', unused since
7771 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7773 2011-04-02 Jim Meyering <meyering@redhat.com>
7775 do not dereference NULL upon failed strdup
7776 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7777 (ns_get_family): Likewise.
7779 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7781 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7783 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7785 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7788 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7790 Add lexical binding.
7792 * window.c (Ftemp_output_buffer_show): New fun.
7793 (Fsave_window_excursion):
7794 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7796 * lread.c (lisp_file_lexically_bound_p): New function.
7797 (Fload): Bind Qlexical_binding.
7798 (readevalloop): Remove `evalfun' arg.
7799 Bind Qinternal_interpreter_environment.
7800 (Feval_buffer): Bind Qlexical_binding.
7801 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7803 (syms_of_lread): Declare `lexical-binding'.
7805 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7807 * keyboard.c (eval_dyn): New fun.
7808 (menu_item_eval_property): Use it.
7810 * image.c (parse_image_spec): Use Ffunctionp.
7812 * fns.c (concat, mapcar1): Accept byte-code-functions.
7814 * eval.c (Fsetq): Handle lexical vars.
7815 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7816 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7817 (FletX, Flet): Obey lexical binding.
7818 (Fcommandp): Handle closures.
7819 (Feval): New `lexical' arg.
7820 (eval_sub): New function extracted from Feval. Use it almost
7821 everywhere where Feval was used. Look up vars in lexical env.
7823 (Ffunctionp): Move from subr.el.
7824 (Ffuncall): Handle closures.
7825 (apply_lambda): Remove `eval_flags'.
7826 (funcall_lambda): Handle closures and new byte-code-functions.
7827 (Fspecial_variable_p): New function.
7828 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7829 but without exporting it to Lisp.
7831 * doc.c (Fdocumentation, store_function_docstring):
7832 * data.c (Finteractive_form): Handle closures.
7834 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7837 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7839 (exec_byte_code): New function extracted from Fbyte_code to handle new
7840 calling convention for byte-code-functions. Add new byte-codes.
7842 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7844 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7846 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7848 * xdisp.c (redisplay_internal): Fix prototype.
7850 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7852 * xdisp.c (SCROLL_LIMIT): New macro.
7853 (try_scrolling): Use it when setting scroll_limit.
7854 Limit scrolling to 100 screen lines.
7855 (redisplay_window): Even when falling back on "recentering",
7856 position point in the window according to scroll-conservatively,
7857 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7859 (try_scrolling): When point is above the window, allow searching
7860 as far as scroll_max, or one screenful, to compute vertical
7861 distance from PT to the scroll margin position. This prevents
7862 try_scrolling from unnecessarily failing when
7863 scroll-conservatively is set to a value slightly larger than the
7864 window height. Clean up the case of PT below the margin at bottom
7865 of window: scroll_max can no longer be INT_MAX. When aggressive
7866 scrolling is in use, don't let point enter the opposite scroll
7867 margin as result of the scroll.
7868 (syms_of_xdisp) <scroll-conservatively>: Document the
7869 threshold of 100 lines for never-recentering scrolling.
7871 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7873 * dispextern.h (move_it_by_lines):
7874 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7875 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7876 (message_log_check_duplicate): Remove parameters `prev_bol' and
7877 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7878 (redisplay_internal): Remove parameter `preserve_echo_area',
7879 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7881 * indent.c (Fvertical_motion):
7882 * window.c (window_scroll_pixel_based, Frecenter):
7883 Don't pass `need_y_p' to `move_it_by_lines'.
7885 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7887 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7888 steal a few bits to be more compact.
7889 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7890 Remove unneeded casts.
7892 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7894 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7896 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7897 binding" message (bug#7967).
7899 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7901 Fix more problems found by GCC 4.6.0's static checks.
7903 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7904 Remove unused local var.
7906 * editfns.c (Fmessage_box): Remove unused local var.
7908 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7909 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7910 Omit unused local vars.
7911 * window.c (shrink_windows): Omit unused local var.
7912 * menu.c (digest_single_submenu): Omit unused local var.
7913 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7914 Omit unused local var.
7916 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7917 Don't assume string length fits in int.
7918 (keyremap_step, read_key_sequence): Use size_t for sizes.
7919 (read_key_sequence): Don't check last_real_key_start redundantly.
7921 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7922 instead of alloca (Bug#8344).
7924 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7925 (Fbacktrace_frame): Don't assume nframes fits in int.
7927 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7929 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7932 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7934 * cm.c (calccost): Turn while-do into do-while, for clarity.
7936 * keyboard.c (syms_of_keyboard): Use the same style as later
7937 in this function when indexing through an array. This also
7938 works around GCC bug 48267.
7940 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7942 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7944 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7945 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7947 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7948 This avoids undefined behavior on integer overflow, and is a bit
7949 more convenient anyway since it is compared to a size_t variable.
7951 Variadic C functions now count arguments with size_t, not int.
7952 This avoids an unnecessary limitation on 64-bit machines, which
7953 caused (substring ...) to crash on large vectors (Bug#8344).
7954 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7955 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7956 All variadic functions and their callers changed accordingly.
7957 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7958 * data.c (arith_driver, float_arith_driver): Likewise.
7959 * editfns.c (general_insert_function): Likewise.
7960 * eval.c (struct backtrace.nargs, interactive_p)
7961 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7962 (funcall_lambda, mark_backtrace): Likewise.
7963 * fns.c (concat): Likewise.
7964 * frame.c (x_set_frame_parameters): Likewise.
7965 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7966 0 if not found, not -1. All callers changed.
7968 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7969 (stack_copy_size): Now size_t, not int.
7970 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7972 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7974 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7975 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7976 All callers changed.
7978 * lisp.h (multibyte_char_to_unibyte):
7979 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7980 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7981 * character.h (CHAR_TO_BYTE8):
7982 * cmds.c (internal_self_insert):
7983 * editfns.c (general_insert_function):
7984 * keymap.c (push_key_description):
7985 * search.c (Freplace_match):
7986 * xdisp.c (message_dolog, set_message_1): All callers changed.
7988 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7990 * keyboard.c (safe_run_hook_funcall): New function.
7991 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7992 don't set the hook to nil, but remove the offending function instead.
7993 (Qcommand_hook_internal): Remove, unused.
7994 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7995 Vcommand_hook_internal.
7997 * eval.c (enum run_hooks_condition): Remove.
7998 (funcall_nil, funcall_not): New functions.
7999 (run_hook_with_args): Call each function through a `funcall' argument.
8000 Remove `cond' argument, now redundant.
8001 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8002 (Frun_hook_with_args_until_failure): Adjust accordingly.
8003 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8005 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8007 * dispextern.h (string_buffer_position): Remove declaration.
8009 * print.c (strout): Remove parameter `multibyte', unused since
8010 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8012 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8013 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8014 All callers changed.
8016 * w32.c (_wsa_errlist): Use braces for struct initializers.
8018 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8019 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8020 All callers changed.
8021 (string_buffer_position): Likewise. Also, make static (it's never
8022 used outside xdisp.c).
8023 (cursor_row_p): Remove parameter `w', unused since
8024 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8025 (decode_mode_spec): Remove parameter `precision', introduced during
8026 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8027 All callers changed.
8029 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8031 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8033 2011-03-27 Anders Lindgren <andlind@gmail.com>
8035 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8036 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8037 (ns_update_auto_hide_menu_bar): New functions.
8038 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8039 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8040 ns_constrain_all_frames.
8041 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8042 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8044 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8046 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8048 2011-03-27 Glenn Morris <rgm@gnu.org>
8050 * syssignal.h: Replace RETSIGTYPE with void.
8051 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8052 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8053 Replace SIGTYPE with void everywhere.
8054 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8055 * s/template.h (SIGTYPE): Remove commented out definition.
8057 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8059 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8060 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8062 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8064 * w32.c (read_unc_volume): Use parameter `henum', instead of
8065 global variable `wget_enum_handle'.
8067 * keymap.c (describe_vector): Remove parameters `indices' and
8068 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8069 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8071 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8073 * keyboard.c (timer_check): Remove parameter `do_it_now',
8074 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8075 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8076 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8078 * keyboard.c (read_char):
8079 * w32menu.c (w32_menu_display_help):
8080 * xmenu.c (show_help_event, menu_help_callback):
8081 Adjust calls to `show_help_echo'.
8083 * gtkutil.c (xg_maybe_add_timer):
8084 * keyboard.c (readable_events):
8085 * process.c (wait_reading_process_output):
8086 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8088 * insdel.c (adjust_markers_gap_motion):
8089 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8090 (gap_left, gap_right): Don't call it.
8092 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8094 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8095 incurred during fontification.
8097 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8099 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8100 (DEFVAR_PER_BUFFER): Don't pass it.
8102 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8103 (scrolling_window): Don't pass it.
8105 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8107 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8109 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8111 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8112 of variables specific to SELinux and computation of `encoded_absname'.
8114 * image.c (XPutPixel): Remove unused variable `height'.
8116 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8118 * unexw32.c (get_section_info): Remove unused variable `section'.
8120 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8121 (system_process_attributes): Remove unused variable `sess'.
8122 (sys_read): Remove unused variable `err'.
8124 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8125 (w32_wnd_proc): Remove unused variable `isdead'.
8126 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8127 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8128 (x_create_tip_frame): Remove unused variable `tem'.
8130 * w32inevt.c (w32_console_read_socket):
8131 Remove unused variable `no_events'.
8133 * w32term.c (x_draw_composite_glyph_string_foreground):
8134 Remove unused variable `width'.
8136 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8138 * w32term.c (x_set_glyph_string_clipping):
8139 Don't pass uninitialized region to CombineRgn.
8141 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8143 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8144 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8145 (Fx_close_connection): Remove unused variable `i'.
8147 * w32font.c (w32font_draw): Return number of glyphs.
8148 (w32font_open_internal): Remove unused variable `i'.
8149 (w32font_driver): Add missing initializer.
8151 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8152 (fill_in_menu): Remove unused variable `items_added'.
8154 * w32term.c (last_mouse_press_frame): Remove static global variable.
8155 (w32_clip_to_row): Remove unused variable `f'.
8156 (x_delete_terminal): Remove unused variable `i'.
8158 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8159 (NOTHING): Remove unused static global variable.
8160 (uniscribe_check_otf): Remove unused variable `table'.
8161 (uniscribe_font_driver): Add missing initializers.
8163 2011-03-23 Julien Danjou <julien@danjou.info>
8165 * term.c (Fsuspend_tty, Fresume_tty):
8166 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8167 * window.c (temp_output_buffer_show):
8168 * insdel.c (signal_before_change):
8169 * frame.c (Fhandle_switch_frame):
8170 * fileio.c (Fdo_auto_save):
8171 * emacs.c (Fkill_emacs):
8172 * editfns.c (save_excursion_restore):
8173 * cmds.c (internal_self_insert):
8174 * callint.c (Fcall_interactively):
8175 * buffer.c (Fkill_all_local_variables):
8176 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8178 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8179 unconditionally since it does the check itself.
8181 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8183 Fix more problems found by GCC 4.5.2's static checks.
8185 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8186 the first time through the loop, since we know p0 < p1 then.
8187 This also avoids a gcc -Wstrict-overflow warning.
8189 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8190 leading to a memory leak, possible in functions like
8191 load_charset_map_from_file that can allocate an unbounded number
8192 of objects (Bug#8318).
8194 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8195 that could (at least in theory) be that large.
8197 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8198 This is less likely to overflow, and avoids undefined behavior if
8199 overflow does occur. All callers changed. Use strtoul to scan
8200 for the unsigned long integer.
8201 (pint2hrstr): Simplify and tune code slightly.
8202 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8204 * scroll.c (do_scrolling): Work around GCC bug 48228.
8205 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8207 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8208 This also avoids a warning with gcc -Wstrict-overflow.
8209 (validate_x_resource_name): Simplify count usage.
8210 This also avoids a warning with gcc -Wstrict-overflow.
8212 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8215 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8217 * process.c (Fmake_network_process): Use socklen_t, not int,
8218 where POSIX says socklen_t is required in portable programs.
8219 This fixes a porting bug on hosts like 64-bit HP-UX, where
8220 socklen_t is wider than int (Bug#8277).
8221 (Fmake_network_process, server_accept_connection):
8222 (wait_reading_process_output, read_process_output):
8225 * process.c: Rename or move locals to avoid shadowing.
8226 (list_processes_1, Fmake_network_process):
8227 (read_process_output_error_handler, exec_sentinel_error_handler):
8228 Rename or move locals.
8229 (Fmake_network_process): Define label "retry_connect" only if needed.
8230 (Fnetwork_interface_info): Fix pointer signedness.
8231 (process_send_signal): Add cast to avoid pointer signedness problem.
8232 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8233 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8235 Make tparam.h and terminfo.c consistent.
8236 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8237 Include tparam.h instead, since it declares them.
8238 * cm.h (PC): Remove extern decl; tparam.h now does this.
8239 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8240 * terminfo.c: Include tparam.h, to check interfaces.
8241 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8242 (tparam): Adjust signature to match interface in tparam.h;
8243 this removes some undefined behavior. Check that outstring and len
8244 are zero, which they always are with Emacs.
8245 * tparam.h (PC, BC, UP): New extern decls.
8247 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8248 (xftfont_open): Rename locals to avoid shadowing.
8250 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8251 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8252 (OTF_TAG_SYM): Omit macro if not needed.
8253 (ftfont_list): Remove unused local.
8254 (get_adstyle_property, ftfont_pattern_entity):
8255 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8256 Rename locals to avoid shadowing.
8258 * xfont.c (xfont_list_family): Mark var as initialized.
8260 * xml.c (make_dom): Now static.
8262 * composite.c (composition_compute_stop_pos): Rename local to
8264 (composition_reseat_it): Remove unused locals.
8265 (find_automatic_composition, composition_adjust_point): Likewise.
8266 (composition_update_it): Mark var as initialized.
8267 (find_automatic_composition): Mark vars as initialized,
8268 with a FIXME (Bug#8290).
8270 character.h: Rename locals to avoid shadowing.
8271 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8272 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8273 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8274 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8277 * textprop.c (property_change_between_p): Remove; unused.
8279 * intervals.c (interval_start_pos): Now static.
8281 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8283 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8284 Rename locals to avoid shadowing.
8286 * sound.c (wav_play, au_play, Fplay_sound_internal):
8287 Fix pointer signedness.
8288 (alsa_choose_format): Remove unused local var.
8289 (wav_play): Initialize a variable to 0, to prevent undefined
8290 behavior (Bug#8278).
8292 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8294 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8296 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8297 clobbering (Bug#8298).
8298 * sysdep.c (sys_subshell): Likewise.
8299 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8301 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8302 This should get cleaned up, so that child_setup has the
8303 same signature on all platforms.
8305 * callproc.c (call_process_cleanup): Now static.
8306 (relocate_fd): Rename locals to avoid shadowing.
8308 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8310 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8311 not to be necessary, and produces flickering.
8313 2011-03-20 Glenn Morris <rgm@gnu.org>
8315 * config.in: Remove file.
8317 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8319 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8320 are now in src/globals.h.
8321 (syms_of_minibuf): Remove spurious & from previous change.
8323 2011-03-20 Leo Liu <sdl.web@gmail.com>
8325 * minibuf.c (completing-read-function): New variable.
8326 (completing-read-default): Rename from completing-read.
8327 (completing-read): Call completing-read-function.
8329 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8331 * xfaces.c (Fx_load_color_file):
8332 Read color file from absolute filename (bug#8250).
8334 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8336 * makefile.w32-in: Update dependencies.
8338 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8340 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8342 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8344 Fix more problems found by GCC 4.5.2's static checks.
8346 * process.c (make_serial_process_unwind, send_process_trap):
8347 (sigchld_handler): Now static.
8349 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8350 That way, the code declares only the vars that it needs.
8351 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8352 * s/cygwin.h (PTY_ITERATION): Likewise.
8353 * s/darwin.h (PTY_ITERATION): Likewise.
8354 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8356 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8357 * process.c (allocate_pty): Don't declare stb unless it's needed.
8359 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8360 (CONSTANTLIM): Remove; unused.
8361 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8362 Define only if needed.
8364 * unexelf.c (unexec): Name an expression,
8365 to avoid gcc -Wbad-function-cast warning.
8366 Use a different way to cause a compilation error if anyone uses
8367 n rather than nn, a way that does not involve shadowing.
8368 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8370 * deps.mk (unexalpha.o): Remove; unused.
8372 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8373 * unexec.h: New file.
8374 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8375 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8377 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8378 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8379 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8380 Change as necessary to match prototype in unexec.h.
8382 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8384 (back_comment, skip_chars): Mark vars as initialized.
8386 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8387 Rename locals to avoid shadowing.
8389 * lread.c (read1): Rewrite so as not to use empty "else".
8390 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8392 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8394 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8395 warning when compiling print.c.
8397 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8398 instead of using an uninitialized var.
8399 (font_sort_entities): Mark var as initialized.
8401 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8403 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8404 pointers to constants.
8405 (font_parse_fcname): Remove unused vars.
8406 (font_delete_unmatched): Now static.
8407 (font_get_spec): Remove; unused.
8408 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8409 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8410 Rename or move locals to avoid shadowing.
8412 * fns.c (require_nesting_list, require_unwind): Now static.
8413 (Ffillarray): Rename locals to avoid shadowing.
8415 * floatfns.c (domain_error2): Define only if needed.
8416 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8418 * alloc.c (mark_backtrace): Move decl from here ...
8419 * lisp.h: ... to here, so that it can be checked.
8421 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8422 (Fdefvar): Rewrite so as not to use empty "else".
8423 (lisp_indirect_variable): Name an expression,
8424 to avoid gcc -Wbad-function-cast warning.
8425 (Fdefvar): Rename locals to avoid shadowing.
8427 * callint.c (quotify_arg, quotify_args): Now static.
8428 (Fcall_interactively): Rename locals to avoid shadowing.
8429 Use const pointer when appropriate.
8431 * lisp.h (get_system_name, get_operating_system_release):
8432 Move decls here, to check interfaces.
8433 * process.c (get_operating_system_release): Move decl to lisp.h.
8434 * xrdb.c (get_system_name): Likewise.
8435 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8436 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8437 some of which prompt warnings from gcc -Wbad-function-cast.
8438 (Fformat_time_string, Fencode_time, Finsert_char):
8439 (Ftranslate_region_internal, Fformat):
8440 Rename or remove local vars to avoid shadowing.
8441 (Ftranslate_region_internal): Mark var as initialized.
8443 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8446 * lisp.h (eassert): Check that the argument compiles, even if
8447 ENABLE_CHECKING is not defined.
8449 * data.c (Findirect_variable): Name an expression, to avoid
8450 gcc -Wbad-function-cast warning.
8451 (default_value, arithcompare, arith_driver, arith_error): Now static.
8452 (store_symval_forwarding): Rename local to avoid shadowing.
8453 (Fmake_variable_buffer_local, Fmake_local_variable):
8454 Mark variables as initialized.
8455 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8457 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8458 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8459 Rename locals to avoid shadowing.
8460 (mark_stack): Move local variables into the #ifdef region where
8462 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8463 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8465 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8466 (GC_STRING_CHARS): Remove; not used.
8467 (Fmemory_limit): Cast sbrk's returned value to char *.
8469 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8470 avoids undefined behavior in theory.
8472 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8474 Use functions, not macros, for up- and down-casing (Bug#8254).
8475 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8476 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8477 to use the following functions instead of these macros.
8478 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8479 EMACS_INT, since callers assume the returned value fits in int.
8480 (upcase1): Likewise, for UPCASE_TABLE.
8481 (uppercasep, lowercasep, upcase): New static inline functions.
8482 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8483 the race-condition problem in the old DOWNCASE.
8485 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8486 Rename locals to avoid shadowing.
8487 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8488 (regex_compile, re_search_2, re_match_2_internal):
8489 Remove unused local vars.
8490 (FREE_VAR): Rewrite so as not to use empty "else",
8491 which gcc can warn about.
8492 (regex_compile, re_match_2_internal): Mark locals as initialized.
8493 (RETALLOC_IF): Define only if needed.
8494 (WORDCHAR_P): Likewise. This one is never needed, but is used
8495 only in a comment talking about a compiler bug, so put inside
8496 the #if 0 of that comment.
8497 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8498 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8501 * search.c (boyer_moore): Rename locals to avoid shadowing.
8502 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8503 (PREV_CHAR_BOUNDARY): Likewise.
8505 * search.c (simple_search): Remove unused var.
8507 * dired.c (compile_pattern): Move decl from here ...
8508 * lisp.h: ... to here, so that it can be checked.
8509 (struct re_registers): New forward decl.
8511 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8513 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8515 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8516 Rename locals to avoid shadowing.
8517 (Fvertical_motion): Mark locals as initialized.
8519 * casefiddle.c (casify_object, casify_region): Now static.
8520 (casify_region): Mark local as initialized.
8522 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8524 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8525 New macros, so that the caller can use some names other than
8526 gcpro1, gcpro2, etc.
8527 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8529 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8530 argument, for consistency with GCPRO2_VAR, etc: it is now the
8531 prefix of the variable, not the variable itself. All uses
8533 * dired.c (directory_files_internal, file_name_completion):
8534 Rename locals to avoid shadowing.
8536 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8537 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8538 dired.c's scmp function, had undefined behavior.
8539 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8540 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8541 * buffer.h: ... to here, because these macros use current_buffer,
8542 and the new implementation with inline functions needs to have
8543 current_buffer in scope now, rather than later when the macros
8545 (downcase, upcase1): New static inline functions.
8546 (DOWNCASE, UPCASE1): Reimplement using these functions.
8547 This avoids undefined behavior in expressions like
8548 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8549 from race conditions in accessing the global variables
8550 case_temp1 and case_temp2.
8551 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8552 * lisp.h (case_temp1, case_temp2): Remove their decls.
8553 * character.h (ASCII_CHAR_P): Move from here ...
8554 * lisp.h: ... to here, so that the inline functions mentioned
8557 * dired.c (directory_files_internal_unwind): Now static.
8559 * fileio.c (file_name_as_directory, directory_file_name):
8560 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8562 (file_name_as_directory): Use const pointers when appropriate.
8563 (Fexpand_file_name): Likewise. In particular, newdir might
8564 point at constant storage, so make it a const pointer.
8565 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8566 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8568 (Fset_file_times, Finsert_file_contents, auto_save_error):
8569 Rename locals to avoid shadowing.
8571 * minibuf.c (choose_minibuf_frame_1): Now static.
8572 (Ftry_completion, Fall_completions): Rename or remove locals
8575 * marker.c (bytepos_to_charpos): Remove; unused.
8577 * lisp.h (verify_bytepos, count_markers): New decls,
8578 so that gcc does not warn that these functions aren't declared.
8580 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8581 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8582 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8583 (copy_text): Remove unused local var.
8585 * filelock.c (within_one_second): Now static.
8586 (lock_file_1): Rename local to avoid shadowing.
8588 * buffer.c (fix_overlays_before): Mark locals as initialized.
8589 (fix_start_end_in_overlays): Likewise. This function should be
8590 simplified by using pointers-to-pointers, but that's a different
8592 (switch_to_buffer_1): Now static.
8593 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8594 (report_overlay_modification): Rename locals to avoid shadowing.
8596 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8597 Fix pointer signedness issue.
8598 (sys_subshell): Mark local as volatile if checking for lint,
8599 to suppress a gcc -Wclobbered warning that does not seem to be right.
8600 (MAXPATHLEN): Define only if needed.
8602 * process.c (serial_open, serial_configure): Move decls from here ...
8603 * systty.h: ... to here, so that they can be checked.
8605 * fns.c (get_random, seed_random): Move extern decls from here ...
8606 * lisp.h: ... to here, so that they can be checked.
8608 * sysdep.c (reset_io): Now static.
8609 (wait_for_termination_signal): Remove; unused.
8611 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8612 (copy_keymap_item, append_key, push_text_char_description):
8614 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8615 (DENSE_TABLE_SIZE): Remove; unused.
8616 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8617 (describe_map_tree):
8618 Rename locals to avoid shadowing.
8620 * keyboard.c: Declare functions static if they are not used elsewhere.
8621 (echo_char, echo_dash, cmd_error, top_level_2):
8622 (poll_for_input, handle_async_input): Now static.
8623 (read_char, kbd_buffer_get_event, make_lispy_position):
8624 (make_lispy_event, make_lispy_movement, apply_modifiers):
8625 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8626 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8627 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8628 (read_key_sequence, read_char): Mark locals as initialized.
8629 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8631 * keyboard.h (make_ctrl_char): New decl.
8632 (mark_kboards): Move decl here ...
8633 * alloc.c (mark_kboards): ... from here.
8635 * lisp.h (force_auto_save_soon): New decl.
8637 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8638 (DEFINE_DUMMY_FUNCTION): New macro.
8639 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8641 (main): Add casts to avoid warnings
8642 if GCC considers string literals to be constants.
8644 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8646 * dbusbind.c: Pointer signedness fixes.
8647 (xd_signature, xd_append_arg, xd_initialize):
8648 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8649 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8650 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8651 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8653 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8654 if GCC considers string literals to be constants.
8655 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8657 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8659 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8660 (print_preprocess, print_object): New macro to fix last change.
8662 * print.c (print_preprocess): Don't forget font objects.
8664 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8666 * emacs.c (USAGE3): Doc fixes.
8668 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8670 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8673 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8675 * lisp.h (VWindow_system, Qfile_name_history):
8676 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8677 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8678 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8680 * w32select.c: Don't #include "keyboard.h".
8681 (run_protected): Add extern declaration for waiting_for_input.
8683 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8684 * w32console.c (detect_input_pending, read_input_pending)
8685 (encode_terminal_code):
8686 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8687 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8688 (w32_system_caret_y, Qfile_name_history):
8689 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8690 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8691 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8692 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8693 * w32proc.c (Qlocal, report_file_error):
8694 * w32term.c (Vwindow_system, updating_frame):
8695 * w32uniscribe.c (initialized, uniscribe_font_driver):
8696 Remove unneeded extern declarations.
8698 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8700 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8702 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8704 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8705 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8706 These macros can no longer be used for assignment.
8708 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8709 Assign struct members directly, instead of using BUF_BEGV etc.
8710 (record_buffer_markers, fetch_buffer_markers): New functions for
8711 recording and fetching special buffer markers.
8712 (set_buffer_internal_1, set_buffer_temp): Use them.
8714 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8716 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8718 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8719 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8721 * xdisp.c (hscroll_window_tree):
8722 (reconsider_clip_changes): Use PT instead of BUF_PT.
8724 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8726 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8727 $(EMACS_ROOT)/lib/intprops.h.
8729 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8731 Fix more problems found by GCC 4.5.2's static checks.
8733 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8734 to unsigned char * to avoid compiler diagnostic.
8735 (xg_free_frame_widgets): Make it clear that a local variable is
8736 needed only if USE_GTK_TOOLTIP.
8737 (gdk_window_get_screen): Make it clear that this macro is needed
8738 only if USE_GTK_TOOLTIP.
8739 (int_gtk_range_get_value): New function, which avoids a diagnostic
8740 from gcc -Wbad-function-cast.
8741 (xg_set_toolkit_scroll_bar_thumb): Use it.
8742 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8743 diagnostic from gcc -Wbad-function-cast.
8744 (get_utf8_string, xg_get_file_with_chooser):
8745 Rename locals to avoid shadowing.
8746 (create_dialog): Move locals to avoid shadowing.
8748 * xgselect.c (xg_select): Remove unused var.
8750 * image.c (four_corners_best): Mark locals as initialized.
8751 (gif_load): Initialize transparent_p to zero (Bug#8238).
8752 Mark another local as initialized.
8753 (my_png_error, my_error_exit): Mark with NO_RETURN.
8755 * image.c (clear_image_cache): Now static.
8756 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8757 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8758 (x_edge_detection): Remove unnecessary cast that
8759 gcc -Wbad-function-cast diagnoses.
8760 (gif_load): Fix pointer signedness.
8761 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8762 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8764 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8766 Improve quality of tests for time stamp overflow.
8767 For example, without this patch (encode-time 0 0 0 1 1
8768 1152921504606846976) returns the obviously-bogus value (-948597
8769 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8770 reports time overflow. See
8771 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8772 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8773 * editfns.c: Include limits.h and intprops.h.
8774 (TIME_T_MIN, TIME_T_MAX): New macros.
8775 (time_overflow): Move earlier, to before first use.
8776 (hi_time, lo_time): New functions, for an accurate test for
8778 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8779 (Fget_internal_run_time): Don't assume time_t fits in int.
8780 (make_time): Use list2 instead of Fcons twice.
8781 (Fdecode_time): More accurate test for out-of-range times.
8782 (check_tm_member): New function.
8783 (Fencode_time): Use it, to test for out-of-range times.
8784 (lisp_time_argument): Don't rely on undefined left-shift and
8785 right-shift behavior when checking for time stamp overflow.
8787 * editfns.c (time_overflow): New function, refactoring common code.
8788 (Fformat_time_string, Fdecode_time, Fencode_time):
8789 (Fcurrent_time_string): Use it.
8791 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8792 * dired.c (make_time): Move to ...
8793 * editfns.c (make_time): ... here.
8794 * systime.h: Note the move.
8796 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8798 * fringe.c (update_window_fringes): Remove unused variables.
8800 * unexmacosx.c (copy_data_segment): Also copy __got section.
8803 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8805 * termcap.c [MSDOS]: Include "msdos.h".
8806 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8807 Constify `char *' arguments and their references according to
8808 prototypes in tparam.h.
8810 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8812 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8813 Adapt all references accordingly.
8815 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8817 2011-03-11 Tom Tromey <tromey@redhat.com>
8819 * buffer.c (syms_of_buffer): Remove obsolete comment.
8821 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8823 * termhooks.h (encode_terminal_code): Declare prototype.
8825 * msdos.c (encode_terminal_code): Don't declare prototype.
8827 * term.c (encode_terminal_code): Now external again, used by
8828 w32console.c and msdos.c.
8830 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8831 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8833 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8835 Fix some minor problems found by GCC 4.5.2's static checks.
8837 * fringe.c (update_window_fringes): Mark locals as initialized
8839 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8841 * alloc.c (mark_fringe_data): Move decl from here ...
8842 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8843 to check its interface.
8844 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8846 * fontset.c (free_realized_fontset): Now static.
8847 (Fset_fontset_font): Rename local to avoid shadowing.
8848 (fontset_font): Mark local as initialized.
8849 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8851 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8853 * xselect.c (x_disown_buffer_selections): Remove; not used.
8854 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8855 (x_own_selection, Fx_disown_selection_internal): Rename locals
8857 (x_handle_dnd_message): Remove local to avoid shadowing.
8859 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8860 so that the caller can use some name other than gcpro1.
8861 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8862 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8863 (Fx_backspace_delete_keys_p):
8864 Use them to avoid shadowing, and rename vars to avoid shadowing.
8865 (x_decode_color, x_set_name, x_window): Now static.
8866 (Fx_create_frame): Add braces to silence GCC warning.
8867 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8868 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8869 Remove unused locals.
8870 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8871 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8872 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8875 * xterm.h (x_mouse_leave): New decl.
8877 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8878 Remove unused functions.
8879 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8880 (x_calc_absolute_position): Now static.
8881 (XTread_socket): Don't define label "out" unless it's used.
8882 Don't declare local "event" unless it's used.
8883 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8884 unless they are used.
8885 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8886 (x_fatal_error_signal): Remove; not used.
8887 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8888 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8889 (x_error_catcher, x_connection_closed, x_error_handler):
8890 (x_error_quitter, xembed_send_message, x_iconify_frame):
8891 (my_log_handler): Rename locals to avoid shadowing.
8892 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8893 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8895 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8896 Rename or move locals to avoid shadowing.
8897 (tty_defined_color, merge_face_heights): Now static.
8898 (free_realized_faces_for_fontset): Remove; not used.
8899 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8900 does not deduce is never used uninitialized.
8901 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8902 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8904 * terminal.c (store_terminal_param): Now static.
8906 * xmenu.c (menu_highlight_callback): Now static.
8907 (set_frame_menubar): Remove unused local.
8908 (xmenu_show): Rename parameter to avoid shadowing.
8909 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8910 since they might point to immutable storage.
8911 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8912 since it's unused otherwise.
8914 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8915 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8916 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8917 avoids a gcc -Wuninitialized diagnostic.
8918 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8919 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8920 does not deduce are never used uninitialized.
8922 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8924 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8925 * window.c (window_loop, size_window):
8926 (run_window_configuration_change_hook, enlarge_window): Likewise.
8928 * window.c (display_buffer): Now static.
8929 (size_window): Mark variables that gcc -Wuninitialized
8930 does not deduce are never used uninitialized.
8931 * window.h (check_all_windows): New decl, to forestall
8932 gcc -Wmissing-prototypes diagnostic.
8933 * dispextern.h (bidi_dump_cached_states): Likewise.
8935 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8937 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8939 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8940 and to avoid gcc -Wuninitialized warning.
8941 (load_charset_map): Mark variables that gcc -Wuninitialized
8942 does not deduce are never used uninitialized.
8943 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8945 * coding.c (coding_set_source, coding_set_destination):
8946 Use "else { /* comment */ }" rather than "else /* comment */;"
8947 for clarity, and to avoid gcc -Wempty-body warning.
8948 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8949 a block, when the outer 'i' will do.
8950 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8951 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8952 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8953 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8954 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8955 Rename locals to avoid shadowing.
8956 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8957 * coding.c (emacs_mule_char, encode_invocation_designation):
8958 Now static, since they're not used elsewhere.
8959 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8960 (decode_coding_object, encode_coding_object, detect_coding_system):
8961 (decode_coding_emacs_mule): Mark variables that gcc
8962 -Wuninitialized does not deduce are never used uninitialized.
8963 (detect_coding_iso_2022): Initialize a local variable that might
8964 be used uninitialized. Leave a FIXME because it's not clear that
8965 this initialization is needed. (Bug#8211)
8966 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8967 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8968 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8969 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8970 Remove unused macros.
8972 * category.c (hash_get_category_set): Remove unused local var.
8973 (copy_category_table): Now static, since it's not used elsewhere.
8974 * character.c (string_count_byte8): Likewise.
8976 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8977 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8979 * chartab.c (copy_sub_char_table): Now static, since it's not used
8981 (sub_char_table_ref_and_range, char_table_ref_and_range):
8982 Rename locals to avoid shadowing.
8983 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8985 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8986 (BIDI_BOB): Remove unused macro.
8988 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8989 deduce are never used uninitialized.
8990 * term.c (encode_terminal_code): Likewise.
8992 * term.c (encode_terminal_code): Now static. Remove unused local.
8994 * tparam.h: New file.
8995 * term.c, tparam.h: Include it.
8996 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8997 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8998 Move these decls to tparam.h, and make them agree with what
8999 is actually in tparam.c. The previous trick of using incompatible
9000 decls in different modules does not conform to the C standard.
9001 All callers of tparam changed to use tparam's actual API.
9002 * tparam.c (tparam1, tparam, tgoto):
9003 Use const pointers where appropriate.
9005 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9006 * cm.h (struct cm): Likewise.
9007 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9008 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9009 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9010 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9011 (turn_on_face, init_tty): Likewise.
9012 * termchar.h (struct tty_display_info): Likewise.
9014 * term.c (term_mouse_position): Rename local to avoid shadowing.
9016 * alloc.c (mark_ttys): Move decl from here ...
9017 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9019 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9021 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9023 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9025 * search.c (compile_pattern_1): Remove argument regp, unused since
9026 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9027 (compile_pattern): Don't pass it.
9029 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9031 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9032 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9034 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9036 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9038 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9039 gdk_window_get_screen, gdk_window_get_geometry,
9040 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9041 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9042 (xg_get_pixbuf_from_pixmap): New function.
9043 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9044 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9045 Call xg_get_pixbuf_from_pixmap instead of
9046 gdk_pixbuf_get_from_drawable.
9047 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9048 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9049 (xg_check_special_colors): Use GtkStyleContext and its functions
9051 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9052 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9053 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9054 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9055 Call gtk_widget_get_preferred_size.
9056 (xg_frame_resized): gdk_window_get_geometry only takes 5
9058 (xg_win_to_widget, xg_event_is_for_menubar):
9059 Call gdk_x11_window_lookup_for_display.
9060 (xg_set_widget_bg): New function.
9061 (delete_cb): New function.
9062 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9063 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9064 (xg_set_background_color): Call xg_set_widget_bg.
9065 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9066 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9067 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9068 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9070 (update_frame_tool_bar): Call gtk_widget_hide.
9071 (xg_initialize): Use GDK_KEY_g.
9073 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9075 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9077 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9078 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9079 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9081 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9083 * w32xfns.c (select_palette): Check success of RealizePalette against
9084 GDI_ERROR, not zero.
9086 See ChangeLog.11 for earlier changes.
9092 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9094 This file is part of GNU Emacs.
9096 GNU Emacs is free software: you can redistribute it and/or modify
9097 it under the terms of the GNU General Public License as published by
9098 the Free Software Foundation, either version 3 of the License, or
9099 (at your option) any later version.
9101 GNU Emacs is distributed in the hope that it will be useful,
9102 but WITHOUT ANY WARRANTY; without even the implied warranty of
9103 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9104 GNU General Public License for more details.
9106 You should have received a copy of the GNU General Public License
9107 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.