1 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3 Avoid calls to strlen in miscellaneous functions.
4 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
5 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
6 * lread.c (openp): Likewise.
8 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
10 Avoid calls to strlen in path processing functions.
11 * fileio.c (file_name_as_directory): Add comment. Change to add
12 srclen argument and return the length of result. Adjust users
14 (directory_file_name): Fix comment. Change to add srclen argument,
15 swap 1st and 2nd arguments to obey the common convention. Adjust
17 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
19 2012-07-10 Glenn Morris <rgm@gnu.org>
21 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
22 Move PENDING_OUTPUT_COUNT definition to configure.
24 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
25 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
26 * s/gnu.h (DATA_START): Move definitions to configure.
28 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
29 We include usg5-4-common.h, which defines them both.
31 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
32 O_RDONLY already includes it).
34 Stop ns builds setting the EMACSLOADPATH environment variable.
35 * nsterm.m (ns_load_path): Rename from ns_init_paths.
36 Now it does not set EMACSLOADPATH, just returns the load-path string.
37 * nsterm.h: Update accordingly.
38 * lread.c [HAVE_NS]: Include nsterm.h.
39 (init_lread) [HAVE_NS]: Use ns_load_path.
40 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
42 2012-07-09 Glenn Morris <rgm@gnu.org>
44 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
45 since the included bsd-common.h does so.
47 Stop ns builds setting the EMACSPATH environment variable.
48 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
49 (ns_init_paths): Do not set EMACSPATH.
50 * nsterm.h (ns_exec_path): Add it.
51 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
54 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
56 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
58 * process.c (wait_reading_process_output): 'waitchannels' was unset
59 when read_kbd || !NILP (wait_for_cell); fix this.
61 Add GCC-style 'const' attribute to functions that can use it.
62 * character.h (char_resolve_modifier_mask):
63 * keyboard.h (make_ctrl_char):
64 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
65 (init_character_once, next_almost_prime, init_fns, init_image)
66 (flush_pending_output, init_sound):
67 * mem-limits.h (start_of_data):
68 * menu.h (finish_menu_items):
70 * emacs.c (DEFINE_DUMMY_FUNCTION):
71 Declare the dummy function with ATTRIBUTE_CONST.
72 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
73 Add decls with ATTRIBUTE_CONST.
75 Minor improvements to make_formatted_string.
76 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
77 where int is good enough, as vsprintf returns an int.
78 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
80 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
82 Use make_formatted_string to avoid double length calculation.
83 * lisp.h (make_formatted_string): New prototype.
84 * alloc.c (make_formatted_string): New function.
85 * buffer.c (Fgenerate_new_buffer_name): Use it.
86 * dbus.c (syms_of_dbusbind): Likewise.
87 * editfns.c (Fcurrent_time_zone): Likewise.
88 * filelock.c (get_boot_time): Likewise.
89 * frame.c (make_terminal_frame, set_term_frame_name)
90 (x_report_frame_params): Likewise.
91 * image.c (gs_load): Likewise.
92 * minibuf.c (get_minibuffer): Likewise.
93 * msdos.c (dos_set_window_size): Likewise.
94 * process.c (make_process): Likewise.
95 * xdisp.c (ensure_echo_area_buffers): Likewise.
96 * xsettings.c (apply_xft_settings): Likewise.
98 2012-07-09 Glenn Morris <rgm@gnu.org>
100 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
101 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
102 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
103 * nsterm.h (ns_etc_directory): Add it.
104 * callproc.c [HAVE_NS]: Include nsterm.h.
105 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
107 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
109 Move marker debugging code under MARKER_DEBUG.
110 * marker.c (MARKER_DEBUG): Move marker debugging code under
111 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
112 for bootstrap with --enable-checking (~3x slowdown reported
113 by Juanma Barranquero <lekktu@gmail.com>).
114 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
116 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
118 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
119 See <http://bugs.gnu.org/11825#29>.
121 2012-07-08 Eli Zaretskii <eliz@gnu.org>
123 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
124 has no font, use the frame's font. (Bug#11813)
125 (display_line): Add commentary about displaying truncation glyphs
127 (produce_special_glyphs): Move here from term.c.
129 * term.c (produce_special_glyphs): Move to xdisp.c.
131 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
134 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
136 * xdisp.c (display_line): Avoid warning about implicit declaration
139 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
141 * lisp.h: Remove empty conditional.
143 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
145 * lread.c (load_path_check): Now static.
147 Fix some minor --with-ns problems found by static checking.
148 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
149 (x_set_font) [!HAVE_X_WINDOWS]:
150 * image.c (xpm_load_image) [HAVE_NS]:
151 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
152 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
154 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
155 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
156 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
157 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
158 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
159 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
160 Fix pointer signedness problem.
161 * xfaces.c (FRAME_X_FONT_TABLE):
162 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
164 2012-07-07 Glenn Morris <rgm@gnu.org>
166 * lread.c (load_path_check): New function, split from init_lread.
167 (init_lread): Reorganize. Motivation:
168 If EMACSLOADPATH is set, check/warn about that rather than the
169 defaults, which we are not going to use. Hence we can remove
170 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
171 Don't warn if site-lisp directories are missing.
172 If not installed, start from a blank load-path, since
173 PATH_LOADSEARCH refers to the eventual installation directories.
175 2012-07-07 Eli Zaretskii <eliz@gnu.org>
177 Support truncation and continuation glyphs on GUI frames, when
178 fringes are disabled. (Bug#11832)
179 * xdisp.c (init_iterator): Get dimensions of truncation and
180 continuation glyphs even if on GUI frames. Adjust
181 it->last_visible_x on GUI frames when the left or right fringes,
183 (start_display, move_it_in_display_line_to): Handle the case of a
184 GUI frame without a fringe to display continuation or truncation
186 (insert_left_trunc_glyphs): Support GUI frames: make sure
187 truncation glyphs overwrite enough glyphs from the current line to
188 have sufficient space in pixels.
189 (display_line): Support truncation and continuation glyphs on GUI
190 frames. If some spare pixels are left on the line after inserting
191 the truncation glyphs, fill that space with a stretch glyph of a
192 suitably computed width.
194 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
195 produce_glyphs, to support GUI sessions.
197 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
199 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
201 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
203 Do not require float-time's arg to fit in time_t (Bug#11825).
204 This works better on hosts where time_t is unsigned, and where
205 float-time is applied to the (negative) difference between two times.
206 * editfns.c (decode_time_components): Last arg is now double *,
207 not int *, and means to store all the result as a double, without
208 worrying about whether the seconds part fits in time_t.
210 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
212 (Ffloat_time): Do not fail merely because the specified time falls
213 outside of time_t range.
215 2012-07-07 Glenn Morris <rgm@gnu.org>
217 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
218 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
219 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
221 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
223 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
226 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
228 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
230 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
231 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
232 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
233 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
234 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
235 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
237 * xfont.c (compare_font_names): Redo to omit the need for casts.
239 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
241 * xfns.c (Fx_change_window_property): Doc fix.
242 * w32fns.c (Fx_change_window_property): Doc fix.
244 * w32fns.c (Fx_window_property): Accept the same arguments as the
245 X Windows version. Doc fix.
246 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
248 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
249 Eli Zaretskii <eliz@gnu.org>
251 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
252 Windows-specific code from nt/config.nt moved here.
253 Obsolete settings removed.
255 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
257 * process.c: Avoid unnecessary calls to gettime.
258 (wait_reading_process_output): Don't get the time of day
259 when gobbling data immediately and not waiting, as there's no need
260 for it in that case. This removes a FIXME.
262 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
264 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
265 is defined (Bug#11768).
267 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
269 Fix marker debugging code.
270 * marker.c (byte_char_debug_check): Do not perform the check
271 if buffer is not multibyte.
272 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
273 Call byte_char_debug_check with correct arguments.
275 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
277 Compile marker debugging code only if ENABLE_CHECKING is defined.
278 * marker.c (byte_char_debug_check, count_markers):
279 Use only if ENABLE_CHECKING is defined.
280 (byte_debug_flag): Remove.
281 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
282 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
284 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
286 Avoid code repetition in marker-related functions.
287 * marker.c (attach_marker): New function.
288 (Fset_marker, set_marker_restricted, set_marker_both)
289 (set_marker_restricted_both): Use it.
290 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
291 Consistently rename charno to charpos.
292 (marker_position): Add eassert.
293 (marker_byte_position): Convert to eassert.
295 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
297 Simplify list operations in unchain_overlay and unchain_marker.
298 * buffer.c (unchain_overlay): Simplify. Add comment.
299 * marker.c (unchain_marker): Simplify. Fix comments.
301 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
303 Introduce fast path for the widely used marker operation.
304 * alloc.c (build_marker): New function.
305 * lisp.h (build_marker): New prototype.
306 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
307 * composite.c (autocmp_chars): Likewise.
308 * editfns.c (buildmark): Remove.
309 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
310 (save_restriction_save): Use build_marker.
311 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
312 * window.c (save_window_save): Likewise.
314 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
316 Do not use Fdelete_overlay in delete_all_overlays
317 to avoid redundant calls to unchain_overlay.
318 * buffer.c (drop_overlay): New function.
319 (delete_all_overlays, Fdelete_overlay): Use it.
320 * minibuf.c (get_minibuffer): Fix comment.
322 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
324 Port to OpenBSD 5.1 amd64.
325 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
326 This is needed for OpenBSD, and should be harmless on all BSD systems.
327 Also, include <sys/sysctl.h>, as it should be available on all
328 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
329 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
330 use p_pid member, not kp_proc.pid.
332 2012-07-06 Glenn Morris <rgm@gnu.org>
334 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
336 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
338 More xmalloc and related cleanup.
339 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
340 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
341 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
342 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
343 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
344 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
345 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
346 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
347 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
349 Omit needless casts involving void * pointers and allocation.
350 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
351 as the former is more robust if P's type is changed.
352 Prefer xzalloc to xmalloc + memset 0.
353 Simplify malloc-or-realloc to realloc.
354 Don't worry about xmalloc returning a null pointer.
355 Prefer xstrdup to xmalloc + strcpy.
356 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
358 * keyboard.c (apply_modifiers_uncached): Prefer local array to
359 alloca of a constant.
361 2012-07-05 Eli Zaretskii <eliz@gnu.org>
363 * xdisp.c (display_line): Fix horizontal pixel coordinates when
364 hscroll is larger than the line width. Fixes long and futile
365 looping inside extend_face_to_end_of_line (on a TTY) producing
366 glyphs that are not needed and thrown away.
368 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
370 * marker.c (set_marker_restricted_both): Simplify by using
373 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
375 * editfns.c (region_limit): Simplify by using clip_to_bounds.
377 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
379 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
380 not defined (Bug#11768).
381 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
382 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
383 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
384 followed by gtk_box_set_homogeneous (Bug#11768).
385 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
386 (update_theme_scrollbar_width, xg_create_scroll_bar):
387 Use gtk_scrollbar_new (Bug#11768).
388 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
389 (is_box_type): New function (Bug#11768).
390 (xg_tool_item_stale_p): Call is_box_type.
391 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
392 with default display (Bug#11768).
394 2012-07-05 Eli Zaretskii <eliz@gnu.org>
396 * xdisp.c (window_hscroll_limited): New function.
397 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
398 coordinates when window's hscroll is set to insanely large
401 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
403 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
404 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
406 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
409 * lisp.h (xzalloc): New prototype. Omit needless casts.
410 * alloc.c (xzalloc): New function. Omit needless casts.
411 * charset.c: Omit needless casts. Convert all calls to
412 xmalloc with following memset to xzalloc.
413 * dispnew.c: Likewise.
414 * fringe.c: Likewise.
418 * w32fns.c: Likewise.
419 * w32font.c: Likewise.
420 * w32term.c: Likewise.
421 * xfaces.c: Likewise.
424 * atimer.c: Omit needless casts.
425 * buffer.c: Likewise.
426 * callproc.c: Likewise.
428 * coding.c: Likewise.
429 * composite.c: Likewise.
431 * doprnt.c: Likewise.
432 * editfns.c: Likewise.
435 * filelock.c: Likewise.
437 * gtkutil.c: Likewise.
438 * keyboard.c: Likewise.
441 * minibuf.c: Likewise.
444 * process.c: Likewise.
445 * region-cache.c: Likewise.
446 * search.c: Likewise.
447 * sysdep.c: Likewise.
448 * termcap.c: Likewise.
449 * terminal.c: Likewise.
450 * tparam.c: Likewise.
451 * w16select.c: Likewise.
453 * w32reg.c: Likewise.
454 * w32select.c: Likewise.
455 * w32uniscribe.c: Likewise.
456 * widget.c: Likewise.
460 * xselect.c: Likewise.
462 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
464 * fileio.c (time_error_value): Check the right error number.
465 Problem reported by Troels Nielsen in
466 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
468 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
470 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
471 This should be fixed in a better way; see Eli Zaretskii in
472 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
473 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
475 * fileio.c (time_error_value): Rename from special_mtime.
476 The old name's problems were noted by Eli Zaretskii in
477 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
479 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
480 This variable's comment says Emacs needs at least one GDB-visible
481 symbol of type enum pvec_type, to work around GDB problems.
482 The symbol's value doesn't matter.
484 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
485 that causes compilation to fail on pre-C99 compilers.
487 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
489 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
490 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
492 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
494 * buffer.c (init_buffer_once): Fix initialization of
495 headers for buffer_defaults and buffer_local_symbols.
496 Reported by Juanma Barranquero <lekktu@gmail.com>.
498 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
500 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
501 * lisp.h (enum pvec_type): Use fewer bits.
502 (PSEUDOVECTOR_SIZE_BITS): New constant.
503 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
504 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
506 (PSEUDOVECTOR_TYPEP): New macro.
507 (TYPED_PSEUDOVECTORP): Use it.
508 * fns.c (internal_equal): Adapt code to extract pvectype.
509 * emacs.c (gdb_pvec_type): Update type.
510 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
511 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
512 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
513 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
514 (sweep_vectors): Use it. Use local var `total_bytes' instead of
515 abusing vector->header.next.nbytes.
516 (live_vector_p): Use PVEC_TYPE.
517 (mark_object): Adapt code to extract pvectype. Use switch.
519 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
521 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
522 Tighten new eassert a bit.
524 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
526 Fix compilation with --enable-gcc-warnings and -O1
528 * doprnt.c (doprnt): Change type of tem to int, initialize
529 to avoid compiler warning. Add eassert.
530 * search.c (simple_search): Initialize match_byte to avoid
531 compiler warning. Add eassert.
533 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
535 Avoid weird behavior with large horizontal scrolls.
536 Without this change, for example, large hscroll values would
537 mess up Emacs's display on Fedora 15 x86, presumably due to
538 overflows in int calculations in the display code.
539 Also, if buffers had long lines, Emacs would freeze.
540 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
541 (set_window_hscroll): New function, containing the old guts of
542 Fset_window_hscroll. Return the clipped value.
543 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
544 This avoids the need to check against PTRDIFF_MAX.
546 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
548 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
550 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
552 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
554 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
555 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
556 since GCC 4.4.6 issues a bogus warning for them.
558 Fix bugs in file timestamp newness comparisons.
559 * fileio.c (Ffile_newer_than_file_p):
560 * lread.c (Fload): Use full timestamp resolution of files,
561 not just the 1-second resolution, so that files that are only
562 slightly newer still count as newer.
563 * fileio.c (Ffile_newer_than_file_p): Don't assume file
564 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
566 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
568 * fileio.c: Improve handling of file time marker. (Bug#11852)
569 (special_mtime): New function.
570 (Finsert_file_contents, Fverify_visited_file_modtime):
571 Use it to set special mtime values consistently.
573 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
575 * fileio.c (Finsert_file_contents): Properly handle st_mtime
576 marker for non-existing file. (Bug#11852)
578 2012-07-03 Glenn Morris <rgm@gnu.org>
580 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
581 and did not make it into globals.h).
583 2012-07-03 Tom Tromey <tromey@redhat.com>
585 * window.c (Fset_window_margins, Fset_window_fringes)
586 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
587 * textprop.c (Fprevious_property_change): No longer static.
588 * syntax.c (Fsyntax_table_p): No longer static.
589 * process.c (Fget_process, Fprocess_datagram_address): No longer
591 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
592 * keyboard.c (Fcommand_execute): No longer static.
594 * insdel.c (Fcombine_after_change_execute): No longer static.
595 * image.c (Finit_image_library): No longer static.
596 * fileio.c (Fmake_symbolic_link): No longer static.
597 * eval.c (Ffetch_bytecode): No longer static.
598 * editfns.c (Fuser_full_name): No longer static.
599 * doc.c (Fdocumentation_property, Fsnarf_documentation):
601 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
603 * dired.c (Ffile_attributes): No longer static.
604 * composite.c (Fcomposition_get_gstring): No longer static.
605 * callproc.c (Fgetenv_internal): No longer static.
607 * ccl.h: Remove EXFUNs.
608 * buffer.h: Remove EXFUNs.
609 * dispextern.h: Remove EXFUNs.
610 * intervals.h: Remove EXFUNs.
611 * fontset.h: Remove EXFUN.
612 * font.h: Remove EXFUNs.
613 * dosfns.c (system_process_attributes): Remove EXFUN.
614 * keymap.h: Remove EXFUNs.
615 * lisp.h: Remove EXFUNs.
616 * w32term.h: Remove EXFUNs.
617 * window.h: Remove EXFUNs.
618 * xsettings.h: Remove EXFUN.
619 * xterm.h: Remove EXFUN.
621 2012-07-03 Glenn Morris <rgm@gnu.org>
623 * lisp.h (Frandom): Make it visible to C.
624 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
625 buffer for invisible buffers. (Bug#1229)
627 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
629 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
630 values which aren't power of 2.
631 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
632 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
635 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
637 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
639 * alloc.c (mark_object): Revert part of last patch to use `switch'.
641 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
643 * alloc.c (allocate_vector_block): Remove redundant
644 calls to mallopt if DOUG_LEA_MALLOC is defined.
645 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
646 avoid calls to mallopt if zero_vector is returned.
648 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
650 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
651 is enabled, avoid dereferencing NULL current_sblock if
654 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
656 Cleanup basic buffer management.
657 * buffer.h (struct buffer): Change layout to use generic vector
658 marking code. Fix some comments. Change type of 'clip_changed'
659 to bitfield. Remove unused #ifndef old.
660 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
661 (GET_OVERLAYS_AT): Fix indentation.
662 (for_each_per_buffer_object_at): New macro.
663 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
664 (Fbuffer_local_variables): Use it.
665 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
666 * alloc.c (allocate_buffer): Adjust to match new layout of
667 struct buffer. Fix comment.
668 (mark_overlay): New function.
669 (mark_buffer): Use it. Use mark_vectorlike to mark normal
670 Lisp area of struct buffer.
671 (mark_object): Use it. Adjust marking of misc objects
672 and related comments.
674 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
676 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
677 wrapper that is not needed because the wrapped code is a no-op (zero
678 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
679 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
681 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
683 * alloc.c (mark_buffer): Simplify. Remove prototype.
684 (mark_object): Add comment. Reorganize marking of vector-like
685 objects. Use CHECK_LIVE for all vector-like objects except buffers
686 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
687 redundant calls to mark_vectorlike for bool vectors.
689 2012-06-30 Glenn Morris <rgm@gnu.org>
691 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
693 * epaths.in (PATH_SITELOADSEARCH): New.
694 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
695 This is rather than relying on --enable-locallisppath elements
696 having "site-lisp" in their names. (Bug#10208#25, 11658)
698 2012-06-30 Eli Zaretskii <eliz@gnu.org>
700 * w32proc.c (sys_select): Accept and ignore one more argument.
702 * w32.c (emacs_gnutls_pull): Call select with one more argument.
704 * sysselect.h [DOS_NT]: Don't include sys/select.h.
705 (pselect) [!MS_DOS]: Redirect to sys_select.
707 * sysdep.c: Don't include dos.h and dosfns.h.
709 * process.c (sys_select):
710 * msdos.c (sys_select): Accept one more argument and ignore it.
712 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
713 adapt data types and code to that.
716 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
717 which clashes with the gnulib function of the same name.
719 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
721 * font.c (font_style_to_value, font_style_symbolic)
722 (font_prop_validate_style): Add type checks for values in
725 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
727 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
730 2012-06-29 Eli Zaretskii <eliz@gnu.org>
732 * xdisp.c (try_window_id): Undo last change.
734 * w32.c (getwd): Adjust commentary about startup_dir.
735 (init_environment): Always call sys_access, even in non-MSVC
736 builds. Don't chdir to the directory of the Emacs executable.
737 This undoes code from 1997 which was justified by the need to
738 "avoid conflicts when removing and renaming directories". But its
739 downside was that every relative file name was being interpreted
740 relative to the directory of the Emacs executable, which can never
741 be TRT. In particular, it broke sys_access when called with
743 (sys_access): Map GetLastError to errno.
745 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
747 * window.h (struct window): Change type of 'fringes_outside_margins'
748 to bitfield. Fix comment. Adjust users accordingly.
749 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
751 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
754 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
756 * gnutls.c (emacs_gnutls_handshake):
757 Add QUIT to make the loop interruptible.
759 2012-06-29 Glenn Morris <rgm@gnu.org>
761 * charset.c (init_charset): Make lack of etc/charsets fatal.
763 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
765 * editfns.c (region_limit): Fix type mismatch.
767 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
769 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
770 undefined. Convert from xassert to eassert.
771 * nsmenu.m: Convert from xassert to eassert.
772 * nsterm.m: Likewise.
774 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
776 * editfns.c (region_limit): Clip to narrowing (bug#11770).
778 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
780 Avoid integer overflow on scroll-left and scroll-right.
781 * window.c (HSCROLL_MAX): New macro.
782 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
783 overflow when requested scroll falls outside ptrdiff_t range.
785 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
787 * window.h (struct window): Change type of 'hscroll',
788 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
789 'last_modified' and 'last_overlay_modified' to EMACS_INT.
790 Adjust users accordingly.
791 * xdisp.c (try_cursor_movement): Replace type check with eassert.
792 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
793 from EMACS_INT to ptrdiff_t.
794 (make_window): Omit redundant initialization.
796 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
798 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
800 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
802 * window.h (struct window): Change type of 'use_time' and
803 'sequence_number' from Lisp_Object to int.
804 * frame.c (make_frame): Adjust users accordingly.
805 * print.c (print_object): Likewise.
806 * window.c (select_window, Fwindow_use_time, make_parent_window)
807 (make_window): Likewise.
809 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
811 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
812 enabled with --enable-checking=[all,glyphs] configure option.
813 Fix GLYPH_DEBUG usage assuming that it may be undefined,
814 adjust comments accordingly.
815 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
816 undefined, adjust comments accordingly.
818 * scroll.c: Likewise.
819 * w32fns.c: Likewise.
820 * w32term.c: Likewise.
822 * xfaces.c: Likewise.
826 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
828 Generalize run-time debugging checks.
829 * dispextern.h (XASSERTS): Remove.
830 * fontset.c (xassert): Remove.
831 Convert from xassert to eassert.
832 * alloc.c: Convert from xassert to eassert.
834 * dispnew.c: Likewise.
836 * fringe.c: Likewise.
837 * ftfont.c: Likewise.
838 * gtkutil.c: Likewise.
840 * keyboard.c: Likewise.
842 * process.c: Likewise.
843 * scroll.c: Likewise.
846 * w32console.c: Likewise.
847 * w32fns.c: Likewise.
848 * w32term.c: Likewise.
849 * window.c: Likewise.
851 * xfaces.c: Likewise.
853 * xselect.c: Likewise.
856 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
858 * fns.c (maybe_resize_hash_table): Output message when growing the
861 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
863 * alloc.c (allocate_string_data): Remove dead code.
864 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
865 avoid GCC warning about unused macro.
867 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
869 * alloc.c (allocate_string): Omit intervals initialization.
870 * alloc.c (make_uninit_multibyte_string): Initialize intervals
871 as in make_pure_string and make_pure_c_string.
873 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
875 * alloc.c (allocate_string): Fix last change.
877 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
879 * alloc.c (allocate_string): Remove two redundant calls
880 to memset, add explicit initialization where appropriate.
882 2012-06-27 Glenn Morris <rgm@gnu.org>
884 * lisp.mk (lisp): Remove paths.elc.
886 2012-06-27 Chong Yidong <cyd@gnu.org>
888 * doc.c (Fsubstitute_command_keys): Fix punctuation.
890 2012-06-26 John Wiegley <johnw@newartisans.com>
892 * unexmacosx.c (copy_data_segment): Add two section names used
893 on Mac OS X Lion: __mod_init_func and __mod_term_func.
895 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
896 when building with Clang.
898 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
900 * eval.c (Fapply): Allow calling it with a single argument.
902 2012-06-26 Eli Zaretskii <eliz@gnu.org>
904 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
905 _stricmp and _strnicmp.
906 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
908 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
910 * alloc.c (allocate_window): Zero out non-Lisp part of newly
912 (allocate_process): Likewise for new process.
913 (allocate_terminal): Change to use offsetof.
914 (allocate_frame): Likewise.
915 * frame.c (make_frame): Omit redundant initialization.
916 * window.c (make_parent_window): Use memset.
917 (make_window): Omit redundant initialization.
918 * process.c (make_process): Omit redundant initialization.
919 * terminal.c (create_terminal): Likewise.
921 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
923 * term.c (delete_tty): Remove redundant call to memset.
925 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
927 * alloc.c: Remove build_string.
928 * lisp.h: Define build_string as static inline. This provides
929 a better opportunity to optimize away calls to strlen when the
930 function is called with compile-time constant argument.
931 * image.c (imagemagick_error): Convert to build_string.
932 * w32proc.c (sys_spawnve): Likewise.
933 * xterm.c (x_term_init): Likewise.
935 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
937 Use sprintf return value instead of invoking strlen on result.
938 In the old days this wasn't portable, since some sprintf
939 implementations returned char *. But they died out years ago and
940 Emacs already assumes sprintf returns int.
941 Similarly for float_to_string.
942 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
943 * ccl.c (ccl_driver):
944 * character.c (string_escape_byte8):
945 * data.c (Fnumber_to_string):
947 * print.c (print_object):
948 * xdisp.c (message_dolog):
949 * xfns.c (syms_of_xfns):
950 Use sprintf or float_to_string result to avoid need to call strlen.
951 * data.c (Fnumber_to_string):
952 Use make_unibyte_string, since the string must be ASCII.
953 * lisp.h, print.c (float_to_string): Now returns int length.
954 * term.c (produce_glyphless_glyph):
955 Use sprintf result rather than recomputing it.
957 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
958 * Makefile.in (ALL_CFLAGS):
959 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
960 * gmalloc.c, regex.c: Include <config.h> unconditionally.
962 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
964 * dispextern.h (xstrcasecmp): Define to library function
965 strcasecmp if available.
966 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
968 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
970 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
971 Avoid comma operator.
972 * menu.c (push_submenu_start, push_submenu_end)
973 (push_left_right_boundary, push_menu_pane): Likewise.
974 * msdos.c (dos_rawgetc): Likewise.
976 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
978 * xfns.c (xic_create_fontsetname): Remove redundant calls
981 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
983 * gtkutil.c (get_utf8_string): Remove redundant assignment.
984 sprintf already null-terminates its output.
986 * xfns.c (x_window): Remove redundant cast.
988 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
990 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
991 `const char *' to `char *' to avoid compiler warning.
993 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
995 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
996 instead of truncating it to 63 (admittedly a generous limit).
998 * process.c: Fix spelling and caps in comments.
1000 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1002 * emacs.c (setpgrp): Remove definition, unused.
1003 * sysdep.c (setpgrp): Remove definition, not used in this file.
1005 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1007 * makefile.w32-in: Update dependencies.
1009 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1011 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1012 (SYSTIME_H): Add nt/inc/sys/time.h.
1014 * systime.h [WINDOWSNT]: Include sys/time.h.
1016 * s/ms-w32.h (struct timespec): Definition moved from
1017 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1019 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1021 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1022 * buffer.h (buffer_slot_type_mismatch):
1023 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1024 * eval.c (unwind_to_catch):
1025 * image.c (my_png_error, my_error_exit):
1026 * keyboard.c (quit_throw_to_read_char, user_error)
1027 (Fexit_recursive_edit, Fabort_recursive_edit):
1028 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1029 (wrong_type_argument, buffer_overflow, __executable_start)
1030 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1031 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1032 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1034 (child_setup) [!DOS_NT]:
1035 * lread.c (end_of_file_error, invalid_syntax):
1036 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1037 * puresize.h (pure_write_error):
1038 * search.c (matcher_overflow):
1039 * sound.c (sound_perror, alsa_sound_perror):
1040 * sysdep.c, syssignal.h (croak):
1041 * term.c (maybe_fatal, vfatal):
1042 * textprop.c (text_read_only):
1043 * undo.c (user_error):
1044 * unexmacosx.c (unexec_error):
1045 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1046 Use _Noreturn rather than NO_RETURN.
1047 No need for separate decl merely because of _Noreturn.
1048 * sound.c (sound_warning, parse_sound):
1049 Remove unnecessary forward decls.
1051 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1053 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1054 * lisp.h (WAIT_READING_MAX): New macro.
1055 * dispnew.c (Fsleep_for, sit_for):
1056 * keyboard.c (kbd_buffer_get_event):
1057 * process.c (Faccept_process_output):
1058 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1059 This improves on the previous patch, which introduced a bug
1060 when time_t is unsigned and as wide as intmax_t.
1061 See <http://bugs.gnu.org/9000#51>.
1063 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1065 * dispnew.c (sit_for, Fsleep_for):
1066 * keyboard.c (kbd_buffer_get_event):
1067 * process.c (Faccept_process_output): Avoid compiler warnings when
1068 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1070 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1072 * makefile.w32-in: Update dependencies.
1074 * w32.c (ltime): Add return type and declare static.
1075 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1077 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1079 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1080 Privately reported by Herbert J. Skuhra.
1081 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1083 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1084 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1086 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1088 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1089 last argument of make_unibyte_string.
1091 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1092 language ID in the event parameters.
1094 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1095 event.code, not the obscure "character set ID".
1097 2012-06-23 Chong Yidong <cyd@gnu.org>
1099 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1101 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1103 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1104 * w32.c (fdutimens): New function.
1106 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1108 * s/ms-w32.h (pselect): Redirect to sys_select.
1110 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1112 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1113 in the logic of incrementing and decrementing the value of
1114 use_relocatable_buffers.
1116 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1118 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1119 Privately reported by Herbert J. Skuhra.
1120 [__FreeBSD__]: Remove "*/" typo after "#include".
1121 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1122 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1123 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1124 Don't assume EMACS_TIME and struct timeval are the same type.
1126 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1128 Support higher-resolution time stamps (Bug#9000).
1129 The time stamps are only nanosecond-resolution at the C level,
1130 since that's the best that any real-world system supports now.
1131 But they are picosecond-resolution at the Lisp level, as that's
1132 easy, and leaves room for future OS improvements.
1134 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1137 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1138 Don't get current time unless it's needed.
1140 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1141 now provides it if it's absent.
1142 (start_atimer): Port to higher-res time stamps.
1143 Check for time stamp overflow. Don't get current time more
1144 often than is needed.
1146 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1147 Include systime.h, not time.h.
1148 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1150 * dired.c: Include stat-time.h.
1151 (Ffile-attributes): File times now have higher resolution.
1153 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1154 (struct image): Timestamp now has higher resolution.
1156 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1157 has at least microseconds now. All uses removed.
1158 (update_frame, update_single_window, update_window, update_frame_1)
1159 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1161 * editfns.c (time_overflow): Now extern.
1162 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1163 (float-time, Fformat_time_string, Fcurrent_time_string)
1164 (Fcurrent_time_zone): Accept and generate higher-resolution
1166 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1167 (decode_time_components, lisp_seconds_argument): New functions.
1168 (make_time): Now static.
1169 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1170 Report an error if the time is invalid, rather than having the caller
1173 * fileio.c: Include <stat-time.h>
1174 (Fcopy_file): Copy higher-resolution time stamps.
1175 Prefer to set the time stamp via a file descriptor if that works.
1176 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1177 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1178 (Fvisited_file_modtime, Fset_visited_file_modtime):
1179 Support higher-resolution time stamps.
1181 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1183 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1185 * image.c (prepare_image_for_display, clear_image_cache)
1186 (lookup_image): Port to higer-resolution time stamps.
1188 * keyboard.c (start_polling, bind_polling_period):
1189 Check for time stamp overflow.
1190 (read_char, kbd_buffer_get_event, timer_start_idle)
1191 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1192 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1193 Port to higher-resolution time stamps. Do not assume time_t is signed.
1194 (decode_timer): New function. Timers are now vectors of length 9,
1195 not 8, to accommodate the picosecond component.
1196 (timer_check_2): Use it.
1198 * nsterm.m (select_timeout, timeval_subtract): Remove.
1199 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1200 as they're a bit more accurate and handle overflow better.
1201 (ns_select): Change prototype to be compatible with pselect.
1202 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1203 * nsterm.h (ns_select): Adjust prototype.
1205 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1206 us-resolution time stamps.
1207 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1209 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1211 * lisp.h (time_overflow): New decl.
1212 (wait_reading_process_output): First arg is now intmax_t, not int,
1213 to accommodate larger waits.
1215 * process.h (struct Lisp_Process.read_output_delay):
1216 Now counts nanoseconds, not microseconds.
1217 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1219 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1220 (wait_reading_process_output):
1221 Port to ns-resolution time stamps.
1222 (Faccept_process_output, wait_reading_process_output):
1223 Check for time stamp overflow. Do not assume time_t is signed.
1224 (select_wrapper): Remove; we now use pselect.
1225 (Fprocess_attributes): Now generates ns-resolution time stamps.
1227 * sysdep.c: Include utimens.h. Don't include utime.h
1228 or worry about struct utimbuf; gnulib does that for us now.
1229 (gettimeofday): Remove; gnulib provides a substitute.
1230 (make_timeval): New function.
1231 (set_file_times): Now sets ns-resolution time stamps.
1232 New arg FD; all uses changed.
1233 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1234 (system_process_attributes):
1235 Now returns ns-resolution time stamp. All uses changed.
1236 Check for time stamp overflow.
1238 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1239 provides a substitute now.
1241 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1242 since it guarantees struct timespec.
1243 (EMACS_TIME): Now struct timespec, so that we can support
1244 ns-resolution time stamps.
1245 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1246 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1247 (EMACS_USECS): Remove.
1248 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1249 so multiply the arg by 1000 before storing it.
1250 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1252 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1253 Port to ns-resolution time stamps.
1254 (EMACS_TIME_NEG_P): Remove; replaced by....
1255 (EMACS_TIME_SIGN): New macro.
1256 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1257 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1258 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1259 (make_timeval, make_lisp_time, decode_time_components): New decls.
1260 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1261 that it mishandled time_t overflow. You can't compare by subtracting!
1262 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1263 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1265 * term.c: Include <sys/time.h>.
1266 (timeval_to_Time): New function, for proper overflow wraparound.
1267 (term_mouse_position, term_mouse_click): Use it.
1269 * undo.c (record_first_change): Support higher-resolution time stamps
1271 (Fprimitive_undo): Use them when restoring time stamps.
1273 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1274 (w32_get_internal_run_time):
1275 Port to higher-resolution Emacs time stamps.
1276 (ltime): Now accepts single 64-bit integer, as that's more convenient
1279 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1281 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1282 for compatibility with pselect. Support ns-resolution time stamps.
1284 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1286 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1287 Check for time stamp overflow, and support ns-resolution time stamps.
1289 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1290 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1291 (timeval_subtract): Remove; no longer needed.
1292 (XTflash, XTring_bell, x_wait_for_event):
1293 Port to ns-resolution time stamps. Don't assume time_t is signed.
1295 2012-06-22 Chong Yidong <cyd@gnu.org>
1297 * xdisp.c (x_consider_frame_title): Revert last change.
1299 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1301 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1302 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1303 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1304 staticidx goes up to 1597 out of 1600 = 0x640.)
1306 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1308 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1309 Otherwise, the umask might be mistakenly 0 while handling input signals.
1311 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1313 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1315 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1317 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1318 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1319 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1320 access to `contents' member of Lisp_Vector objects with AREF and ASET
1323 2012-06-19 Chong Yidong <cyd@gnu.org>
1325 * frame.c (delete_frame): When selecting a frame on a different
1326 text terminal, do not alter the terminal's top-frame.
1328 * xdisp.c (format_mode_line_unwind_data): Record the target
1329 frame's selected window and its terminal's top-frame.
1330 (unwind_format_mode_line): Restore them.
1331 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1333 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1334 since tty frames can be explicitly named.
1335 (prepare_menu_bars): Likewise.
1337 * term.c (Ftty_top_frame): New function.
1339 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1341 Port byte-code-meter to modern targets.
1342 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1343 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1344 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1345 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1346 (METER_1, METER_2): Simplify.
1348 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1350 * data.c (Fdefalias): Return `symbol' (bug#11686).
1352 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1354 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1355 gets killed during executing of this function (Bug#11665).
1356 Try to always return Qt when the buffer has been actually killed.
1357 (Vkill_buffer_query_functions): In doc-string say that functions
1358 run by this hook should not change the current buffer.
1360 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1362 Fix recently-introduced process.c problems found by static checking.
1363 * process.c (write_queue_push, write_queue_pop, send_process):
1364 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1365 (write_queue_pop): Fix pointer signedness problem.
1366 (send_process): Remove unused local.
1368 2012-06-17 Chong Yidong <cyd@gnu.org>
1370 * xdisp.c (redisplay_internal): No need to redisplay terminal
1371 frames that are not on top.
1373 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1375 * process.c (make_process): Initialize write_queue.
1376 (write_queue_push, write_queue_pop): New functions.
1377 (send_process): Use them to maintain correct ordering of process
1380 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1382 * lisp.h (eassert): Assume C89 or later.
1383 This removes the need for CHECK.
1384 (CHECK): Remove. Its comments about always evaluating its
1385 argument were confusing, as 'eassert' typically does not evaluate
1388 * coding.c (produce_chars): Use ptrdiff_t, not int.
1390 * xterm.c (x_draw_underwave): Check for integer overflow.
1391 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1393 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1395 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1396 referenced (Bug#11583).
1398 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1400 Implement wave-style variant of underlining.
1401 * dispextern.h (face_underline_type): New enum.
1402 (face): Add field for underline type.
1403 * nsterm.m (ns_draw_underwave): New function.
1404 (ns_draw_text_decoration): Use it.
1405 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1407 (x_draw_glyph_string): Use them.
1408 * xfaces.c (Qline, Qwave): New Lisp objects.
1409 (check_lface_attrs, merge_face_ref)
1410 (Finternal_set_lisp_face_attribute, realize_x_face):
1411 Handle wave-style underline face attributes.
1412 * xterm.c (x_draw_underwave): New function.
1413 (x_draw_glyph_string): Use it.
1415 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1417 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1418 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1419 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1420 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1421 ($(BLD)/w32select.$(O)): Update dependencies.
1423 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1425 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1426 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1427 * character.c (_fetch_multibyte_char_p): Remove.
1428 * alloc.c: Include "character.h" before "buffer.h".
1430 * buffer.c: Likewise.
1431 * bytecode.c: Likewise.
1432 * callint.c: Likewise.
1433 * callproc.c: Likewise.
1434 * casefiddle.c: Likewise.
1435 * casetab.c: Likewise.
1436 * category.c: Likewise.
1438 * coding.c: Likewise.
1439 * composite.c: Likewise.
1440 * dired.c: Likewise.
1441 * dispnew.c: Likewise.
1443 * dosfns.c: Likewise.
1444 * editfns.c: Likewise.
1445 * emacs.c: Likewise.
1446 * fileio.c: Likewise.
1447 * filelock.c: Likewise.
1449 * fontset.c: Likewise.
1450 * fringe.c: Likewise.
1451 * indent.c: Likewise.
1452 * insdel.c: Likewise.
1453 * intervals.c: Likewise.
1454 * keyboard.c: Likewise.
1455 * keymap.c: Likewise.
1456 * lread.c: Likewise.
1457 * macros.c: Likewise.
1458 * marker.c: Likewise.
1459 * minibuf.c: Likewise.
1460 * nsfns.m: Likewise.
1461 * nsmenu.m: Likewise.
1462 * print.c: Likewise.
1463 * process.c: Likewise.
1464 * regex.c: Likewise.
1465 * region-cache.c: Likewise.
1466 * search.c: Likewise.
1467 * syntax.c: Likewise.
1469 * textprop.c: Likewise.
1471 * unexsol.c: Likewise.
1472 * w16select.c: Likewise.
1473 * w32fns.c: Likewise.
1474 * w32menu.c: Likewise.
1475 * window.c: Likewise.
1476 * xdisp.c: Likewise.
1478 * xmenu.c: Likewise.
1480 * xselect.c: Likewise.
1482 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1484 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1485 If all the glyphs of the glyph row came from strings, and we have no
1486 cursor positioning clues, put the cursor on the first glyph of the
1488 (handle_face_prop): Use chunk-relative overlay string index when
1489 indexing into it->string_overlays array. (Bug#11653)
1490 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1491 the rightmost. (Bug#11720)
1493 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1495 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1496 (CATEGORY_MEMBER): Enforce 1/0 value.
1497 * category.c (_temp_category_set): Remove.
1499 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1501 * window.c (Fdelete_other_windows_internal)
1502 (Fdelete_window_internal): Don't access frame's mouse highlight
1503 info of the initial frame. (Bug#11677)
1505 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1507 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1508 Assume USE_2_TAGS_FOR_INTS.
1509 (xreload): Adjust $tagmask width to match recent lisp.h change.
1511 Simplify lisp.h in minor ways that should not affect code.
1512 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1513 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1514 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1515 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1516 (INTTYPEBITS): New macro, for clarity.
1517 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1518 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1519 Simplify now that USE_LSB_TAG is always defined.
1520 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1521 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1523 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1525 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1527 2012-06-13 Glenn Morris <rgm@gnu.org>
1529 * s/bsd-common.h (BSD4_3):
1530 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1532 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1534 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1537 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1539 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1540 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1541 * alloc.c (widen_to_Lisp_Object): Remove.
1542 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1543 * frame.c (delete_frame): Remove outdated comment.
1544 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1545 USE_LISP_UNION_TYPE.
1546 (Fw32_unregister_hot_key): Likewise.
1547 (Fw32_toggle_lock_key): Likewise.
1548 * w32menu.c (add_menu_item): Likewise.
1549 (w32_menu_display_help): Use XIL instead of checking
1550 USE_LISP_UNION_TYPE.
1551 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1552 (init_heap): Likewise.
1553 * w32term.c (w32_read_socket): Update comment.
1555 2012-06-13 Glenn Morris <rgm@gnu.org>
1557 * s/usg5-4-common.h, src/s/unixware.h:
1558 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1560 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1562 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1564 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1565 * alloc.c (make_number) [!defined make_number]:
1566 Remove, as lisp.h always defines this now.
1567 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1568 (roundup_size): Verify that it is a power of 2.
1569 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1570 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1571 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1572 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1573 USE_LSB_TAG now is always defined to be either 0 or 1.
1575 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1576 code works fine either way, and efficiency is not a concern here,
1577 as the union type is for debugging, not for production.
1578 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1579 Use an inline function on all platforms when using the union type,
1580 since this is simpler and 'static inline' can be used portably
1582 (LISP_INITIALLY_ZERO): New macro.
1583 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1584 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1586 2012-06-12 Glenn Morris <rgm@gnu.org>
1588 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1590 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1592 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1593 Move BROKEN_SIGIO to configure.
1595 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1596 Move NO_TERMIO to configure.
1598 2012-06-12 Chong Yidong <cyd@gnu.org>
1600 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1601 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1602 MagickExportImagePixels is undefined.
1604 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1606 * image.c (imagemagick_load_image): Remove unused label.
1608 2012-06-11 Glenn Morris <rgm@gnu.org>
1610 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1611 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1612 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1613 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1615 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1617 * alloc.c (make_byte_code): New function.
1618 (Fmake_byte_code): Use it. Don't purify here.
1619 * lread.c (read1): Use it as well to avoid extra allocation.
1621 2012-06-11 Chong Yidong <cyd@gnu.org>
1623 * image.c (imagemagick_load_image): Implement transparency.
1625 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1627 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1628 account for preceding backslashes. (Bug#11663)
1630 2012-06-09 Chong Yidong <cyd@gnu.org>
1632 * term.c: Support italics in capable terminals (Bug#9652).
1633 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1634 (turn_on_face): Output using TS_enter_italic_mode if available.
1635 Don't handle unused blinking and alt-charset cases.
1636 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1637 and tty_alt_charset_p cases.
1638 (tty_capable_p, init_tty): Support italics.
1640 * termchar.h (struct tty_display_info): Add field for italics.
1641 Remove unused blink field.
1643 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1646 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1647 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1648 tty_alt_charset_p. Add tty_italic_p.
1650 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1652 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1653 dbus_type_is_basic if available.
1654 (xd_extract_signed, xd_extract_unsigned): Rename from
1655 extract_signed and extract_unsigned, respectively. Adapt callers.
1657 2012-06-09 Chong Yidong <cyd@gnu.org>
1659 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1661 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1664 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1666 * xdisp.c (vmessage): Treat frame message as multibyte.
1667 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1668 would generate the diagnostic "Making \302\247 buffer-local while
1671 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1673 * dispnew.c (showing_window_margins_p): Undo last change, which
1674 was done due to an inadvertent commit.
1675 (adjust_frame_glyphs_for_frame_redisplay): Do call
1676 showing_window_margins_p.
1678 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1680 * eval.c (Fmake_var_non_special): New primitive.
1681 (syms_of_eval): Defsubr it.
1682 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1684 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1686 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1687 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1689 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1691 * alloc.c (allocate_vectorlike): Fix last change.
1693 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1695 Block-based vector allocation of small vectors.
1696 * lisp.h (struct vectorlike_header): New field `nbytes',
1697 adjust comment accordingly.
1698 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1699 to denote vector blocks. Adjust users (live_vector_p,
1700 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1701 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1702 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1703 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1704 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1705 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1706 (roundup_size): New constant.
1707 (struct vector_block): New data type.
1708 (vector_blocks, vector_free_lists, zero_vector): New variables.
1709 (all_vectors): Rename to `large_vectors'.
1710 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1711 (sweep_vectors): New functions.
1712 (allocate_vectorlike): Return `zero_vector' as the only vector of
1713 0 items. Allocate new vector from block if vector size is less than
1714 or equal to VBLOCK_BYTES_MAX.
1715 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1716 (init_alloc_once): Add call to init_vectors.
1718 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1720 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1722 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1724 * doprnt.c (doprnt): Truncate multibyte char correctly.
1725 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1726 would mishandle a string argument "Xc" if X was a multibyte
1727 character of length 2: it would truncate after X's first byte
1728 rather than including all of X.
1730 2012-06-06 Chong Yidong <cyd@gnu.org>
1732 * buffer.c (word_wrap): Doc fix.
1734 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1736 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1738 2012-06-03 Glenn Morris <rgm@gnu.org>
1740 * xdisp.c (tool-bar-style): Doc fix.
1742 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1744 * Makefile.in (PAXCTL): Define.
1745 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1746 binary via PaX flags if the paxctl utility is available.
1747 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1748 Restore PaX flags to their default. (Bug#11398)
1750 2012-06-03 Chong Yidong <cyd@gnu.org>
1752 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1755 2012-06-03 Chong Yidong <cyd@gnu.org>
1757 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1758 (note_mode_line_or_margin_highlight): If there is no help echo,
1759 use mode-line-default-help-echo. Handle the case where the mouse
1760 position is past the end of the mode line string.
1762 * buffer.c (buffer_local_value_1): New function, split from
1763 Fbuffer_local_value; can return Qunbound.
1764 (Fbuffer_local_value): Use it.
1765 (Vmode_line_format): Docstring tweaks.
1767 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1769 * sysdep.c (system_process_attributes): Improve comment.
1771 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1773 * keyboard.c: Export real-this-command to Elisp.
1774 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1775 and DEFVAR it. Update all users.
1777 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1779 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1781 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1782 Convert pctcpu and pctmem to Lisp float properly.
1783 Let the compiler fold better, as 100.0/0x8000 is exact.
1785 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1787 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1790 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1792 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1794 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1796 For a 'struct window', replace some Lisp_Object fields to
1797 bitfields where appropriate, remove unused fields.
1798 * window.h (struct window): Remove unused 'last_mark_x' and
1799 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1800 change it's type from Lisp_Object to bitfield.
1801 Change type of 'force_start', 'optional_new_start',
1802 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1803 fields from Lisp_Object to bitfield. Adjust users accordingly.
1805 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1807 Pacify gcc -Wdouble-precision when using Xaw.
1808 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1809 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1810 Use 'float' consistently, rather than 'float' in most places
1811 and 'double' in a couple of places.
1813 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1815 * xdisp.c (handle_stop): Detect whether we have overlay strings
1816 loaded by testing it->current.overlay_string_index to be
1817 non-negative, instead of checking whether n_overlay_strings is
1818 positive. (Bug#11587)
1820 2012-05-31 Chong Yidong <cyd@gnu.org>
1822 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1824 * doc.c (Fsubstitute_command_keys): Doc fix.
1826 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1828 * search.c (search_buffer): Remove calls to
1829 r_alloc_inhibit_buffer_relocation, as it is now called by
1830 maybe_unify_char, which was the cause of relocation of buffer text
1833 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1835 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1836 for the duration of call to load_charset, to avoid problems with
1837 callers of maybe_unify_char that access buffer text through C
1840 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1841 decrement the inhibition flag, instead of just setting or
1844 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1846 Remove obsolete '#define static' cruft.
1847 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1848 This #undef was "temporary" in 2000; it is no longer needed
1849 now that '#define static' has gone away.
1850 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1851 (gray_bitmap_bits): Remove; no longer needed.
1852 All uses replaced with definiens.
1853 * xterm.c: Include "bitmaps/gray.xbm".
1855 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1857 Clean up __executable_start, monstartup when --enable-profiling.
1858 The following changes affect the code only when profiling.
1859 * dispnew.c (__executable_start): Rename from safe_bcopy.
1860 Define only on platforms that need it.
1861 * emacs.c: Include <sys/gmon.h> when profiling.
1862 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1863 (__executable_start): Remove decl, since lisp.h does it now.
1864 (safe_bcopy): Remove decl; no longer has that name.
1865 (main): Coalesce #if into single bit of code, for simplicity.
1866 Cast pointers to uintptr_t, since standard libraries want integers
1868 * lisp.h (__executable_start): New decl.
1870 2012-05-31 Glenn Morris <rgm@gnu.org>
1872 * image.c (Fimagemagick_types): Doc fix.
1874 2012-05-30 Jim Meyering <meyering@redhat.com>
1876 * callproc.c (Fcall_process_region): Include directory component
1877 in mkstemp error message (Bug#11586).
1879 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1881 * alloc.c, lisp.h (make_pure_vector): Now static.
1883 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1885 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1886 Move to byte-run.el.
1887 (Fautoload): Do the hash-doc more carefully.
1888 * data.c (Fdefalias): Purify definition, except for keymaps.
1889 (Qdefun): Move from eval.c.
1890 * lisp.h (Qdefun): Remove.
1891 * lread.c (read1): Tiny simplification.
1893 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1895 Do not create empty overlays with the evaporate property (Bug#9642).
1896 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1897 Bug#9642, but explicitly check that the buffer the overlay would
1898 be moved to is live and rearrange lines to make sure that errors
1899 will not put the overlay in an inconsistent state.
1900 (Fdelete_overlay): Cosmetics.
1902 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1904 * w32term.c (my_bring_window_to_top): New function.
1905 (x_raise_frame): Use handle returned by DeferWindowPos, which
1906 could be different from the original one.
1907 Call my_bring_window_to_top instead of my_set_foreground_window.
1910 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1911 by calling BringWindowToTop.
1913 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1914 (WM_EMACS_END): Increase by one.
1916 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1918 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1919 This avoids undefined behavior that might cause the eassert
1920 to not catch an out-of-range value.
1922 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1924 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1925 Update dependencies.
1927 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1929 * bidi.c (bidi_mirror_char): Fix last change.
1931 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1933 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1934 when referring to sectname field in printf format.
1936 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1938 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1939 Only r_alloc_inhibit_buffer_relocation needed to be added;
1940 the others were already declared.
1942 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1943 before checking whether it's out of range. Put the check inside
1945 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1947 2012-05-27 Ken Brown <kbrown@cornell.edu>
1949 * callproc.c (Fcall_process): Restore a line that was accidentally
1950 commented out in the 2011-02-13 change (bug#11547).
1952 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1954 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1955 defined on ralloc.c.
1957 * buffer.c [REL_ALLOC]: Remove prototypes of
1958 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1959 they are now on lisp.h.
1961 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1963 * search.c (search_buffer): Use it to inhibit relocation of buffer
1964 text while re_search_2 is doing its job, because re_search_2 is
1965 passed C pointers to buffer text. (Bug#11519)
1967 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1970 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1971 state after an additional call to move_it_in_display_line_to, keep
1972 the values of it->max_ascent and it->max_descent found for the
1974 (pos_visible_p): Revert the comparison against bottom_y to what it
1975 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1978 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1980 Fix coding-related core dumps with gcc -ftrapv.
1981 The code was computing A - B, where A and B are pointers, and B is
1982 random garbage. This can lead to core dumps on platforms that
1983 have special pointer registers, and it also leads to core dumps on
1984 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1985 A - B only when B is initialized properly.
1986 * coding.c (coding_set_source, coding_set_destination): Return void.
1987 (coding_change_source, coding_change_destinations): New functions,
1988 with the old behaviors of coding_set_source and coding_set_destination.
1989 All callers that need an offset changed to use these new functions.
1991 2012-05-26 Glenn Morris <rgm@gnu.org>
1993 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1995 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1997 Extend mouse support on W32 text-mode console.
1998 * xdisp.c (draw_row_with_mouse_face):
1999 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2001 * w32console.c: Include window.h.
2002 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2004 (initialize_w32_display): Initialize mouse-highlight data.
2006 * w32inevt.c: Include termchar.h and window.h.
2007 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2008 moves, call note_mouse_highlight. If help_echo changed, call
2009 gen_help_event to produce help-echo message in the echo area.
2010 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2013 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2015 * lread.c (read1): Simplify slightly to avoid an overflow warning
2016 with GCC 4.7.0 on x86-64.
2018 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2020 * bidi.c (bidi_mirror_char): Revert last change: an int is
2021 definitely wide enough here.
2023 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2025 Fix integer width and related bugs (Bug#9874).
2026 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2027 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2028 (string_bytes, check_sblock, allocate_string_data):
2029 (compact_small_strings, Fmake_bool_vector, make_string)
2030 (make_unibyte_string, make_multibyte_string)
2031 (make_string_from_bytes, make_specified_string)
2032 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2033 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2036 (allocate_pseudovector):
2037 Use int, not EMACS_INT, where int is wide enough.
2038 (inhibit_garbage_collection, Fgarbage_collect):
2039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2040 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2041 int might not be wide enough.
2042 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2043 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2044 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2045 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2046 (bidi_level_of_next_char, bidi_move_to_visually_next):
2047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2048 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2049 (Fkill_buffer, Fset_buffer_major_mode)
2050 (advance_to_char_boundary, Fbuffer_swap_text)
2051 (Fset_buffer_multibyte, overlays_at, overlays_in)
2052 (overlay_touches_p, struct sortvec, record_overlay_string)
2053 (overlay_strings, recenter_overlay_lists)
2054 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2055 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2056 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2057 (Foverlay_recenter, last_overlay_modification_hooks_used)
2058 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2060 (validate_region): Omit unnecessary test for b <= e,
2061 since that's guaranteed by the previous test.
2062 (adjust_overlays_for_delete): Avoid pos + length overflow.
2063 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2064 (report_overlay_modification):
2065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2067 Omit pointer cast, which isn't needed anyway, and doesn't work
2068 after the EMACS_INT -> ptrdiff_t change.
2069 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2070 * buffer.h: Adjust decls to match defn changes elsewhere.
2071 (struct buffer_text, struct buffer):
2072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2073 Use EMACS_INT, not int, where int might not be wide enough.
2074 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2075 not int, to avoid needless 32-bit limit on 64-bit hosts.
2076 (exec_byte_code): Use tighter memory-full test, one that checks
2077 for alloca overflow. Don't compute the address of the object just
2078 before an array, as that's not portable. Use EMACS_INT, not
2079 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2080 * callint.c (Fcall_interactively):
2081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2082 * callproc.c (call_process_kill, Fcall_process):
2083 Don't assume pid_t fits into an Emacs fixnum.
2084 (call_process_cleanup, Fcall_process, child_setup):
2085 Don't assume pid_t fits into int.
2086 (call_process_cleanup, Fcall_process, delete_temp_file)
2087 (Fcall_process_region):
2088 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2089 (Fcall_process): Simplify handling of volatile integers.
2090 Use int, not EMACS_INT, where int will do.
2091 * casefiddle.c (casify_object, casify_region, operate_on_word)
2092 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2094 (casify_object): Avoid integer overflow when overallocating buffer.
2095 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2096 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2097 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2098 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2099 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2100 integers are now checked earlier. All uses replaced with XINT.
2102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2103 For CCL_MapSingle, check that content and value are in int range.
2104 (ccl_driver, Fregister_code_conversion_map):
2105 Check that Vcode_version_map_vector is a vector.
2106 (resolve_symbol_ccl_program): Check that vector header is in range.
2107 Always copy the vector, so that we can check its contents reliably
2108 now rather than having to recheck each instruction as it's being
2109 executed. Check that vector words fit in 'int'.
2110 (ccl_get_compiled_code, Fregister_ccl_program)
2111 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2112 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2113 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2114 contents are in range.
2115 (Fccl_execute_on_string): Check that status is in range.
2116 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2117 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2118 Accept and return EMACS_INT, not int, because callers can pass values
2120 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2121 (multibyte_chars_in_text, parse_str_as_multibyte)
2122 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2123 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2124 (string_escape_byte8, Fget_byte):
2125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2126 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2127 avoid mishandling large integers.
2128 * character.h: Adjust decls to match defn changes elsewhere.
2129 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2130 (Ffind_charset_region):
2131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2132 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2133 (load_charset_map_from_vector, Fdefine_charset_internal):
2134 Don't assume fixnum fits in int.
2135 (load_charset_map_from_vector, Fmap_charset_chars):
2136 Remove now-unnecessary CHECK_NATNUMs.
2137 (Fdefine_charset_internal): Check ranges here, more carefully.
2138 Don't rely on undefined behavior with signed left shift overflow.
2139 Don't assume unsigned int fits into fixnum, or that fixnum fits
2140 into unsigned int. Don't require max_code to be a valid fixnum;
2141 that's not true for gb10830 4-byte on a 32-bit host. Allow
2142 invalid_code to be a cons, for the same reason. Require code_offset
2143 to be a character. Avoid int overflow if max_char is close
2145 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2146 this is intended anyway and avoids some undefined behavior.
2147 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2148 INDEX_TO_CODE_POINT, as that's what it expects.
2149 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2150 * charset.h (DECODE_CHAR): Return int, not unsigned;
2151 this is what was intended anyway, and it avoids undefined behavior.
2152 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2153 integer-overflow issues.
2154 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2155 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2156 where the argument is EMACS_INT, and this behavior is not intended.
2157 * chartab.c (Fmake_char_table, Fset_char_table_range)
2158 (uniprop_get_decoder, uniprop_get_encoder):
2159 Don't assume fixnum fits in int.
2160 * cmds.c (move_point): New function, that does the gist of
2161 Fforward_char and Fbackward_char, but does so while checking
2162 for integer overflow more accurately.
2163 (Fforward_char, Fbackward_char): Use it.
2164 (Fforward_line, Fend_of_line, internal_self_insert)
2165 (internal_self_insert):
2166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2167 Fix a FIXME, by checking for integer overflow when calculating
2168 target_clm and actual_clm.
2169 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2170 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2171 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2172 (coding_alloc_by_making_gap, alloc_destination)
2173 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2174 (encode_coding_utf_16, detect_coding_emacs_mule)
2175 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2176 (detect_coding_iso_2022, decode_coding_iso_2022)
2177 (encode_invocation_designation, encode_designation_at_bol)
2178 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2179 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2180 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2181 (encode_coding_ccl, encode_coding_raw_text)
2182 (detect_coding_charset, decode_coding_charset)
2183 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2184 (produce_composition, produce_charset, produce_annotation)
2185 (decode_coding, handle_composition_annotation)
2186 (handle_charset_annotation, consume_chars, decode_coding_gap)
2187 (decode_coding_object, encode_coding_object, detect_coding_system)
2188 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2189 (code_convert_region, code_convert_string)
2190 (Fdefine_coding_system_internal)
2191 (coding_set_source, coding_set_destination):
2192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2193 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2194 (Fdefine_coding_system_internal):
2195 Don't assume fixnums fit in int.
2196 (decode_coding_gap, decode_coding_object, encode_coding_object)
2197 (Fread_coding_system, Fdetect_coding_region)
2198 (Funencodable_char_position, Fcheck_coding_systems_region)
2199 (get_translation, handle_composition_annotation, consume_chars):
2200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2201 (consume_chars): Rewrite to not calculate an address outside buffer.
2202 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2203 Don't access memory outside of the args array.
2204 (Fdefine_coding_system_internal): Check for charset-id overflow.
2205 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2206 result of ENCODE_CHAR.
2207 * coding.h: Adjust decls to match defn changes elsewhere.
2208 (struct coding_system):
2209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2210 * composite.c (get_composition_id, find_composition)
2211 (run_composition_function, update_compositions)
2212 (compose_text, composition_gstring_put_cache)
2213 (composition_gstring_p, composition_gstring_width)
2214 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2215 (composition_compute_stop_pos, composition_reseat_it)
2216 (composition_update_it, struct position_record)
2217 (find_automatic_composition, composition_adjust_point)
2218 (Fcomposition_get_gstring, Ffind_composition_internal):
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2220 (update_compositions):
2221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2222 * composite.h: Adjust decls to match defn changes elsewhere.
2223 (struct composition):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2226 Do not attempt to compute the address of the object just before a
2227 buffer; this is not portable.
2229 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2230 (Faset): Use int, not EMACS_INT, where int is wide enough.
2231 (Fstring_to_number): Don't assume fixnums fit in int.
2232 (Frem): Don't assume arg is nonnegative.
2233 * dbusbind.c (xd_append_arg): Check for integers out of range.
2234 (Fdbus_call_method): Don't overflow the timeout int.
2235 (extract_signed, extract_unsigned): New functions.
2236 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2237 (xd_get_connection_references): Return ptrdiff_t, not int.
2239 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2240 (xd_read_message_1):
2241 Use int, not unsigned, where the dbus API uses int.
2242 (Fdbus_message_internal): Don't overflow mtype.
2243 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2244 * dired.c (directory_files_internal, file_name_completion, scmp)
2245 (file_name_completion_stat):
2246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2247 (file_name_completion): Don't overflow matchcount.
2248 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2249 * dispextern.h: Adjust decls to match defn changes elsewhere.
2250 (struct text_pos, struct glyph, struct bidi_saved_info)
2251 (struct bidi_string_data, struct bidi_it, struct composition_it)
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 (struct display_pos, struct composition_it, struct it):
2255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2256 * dispnew.c (increment_matrix_positions)
2257 (increment_row_positions, mode_line_string)
2258 (marginal_area_string):
2259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2260 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2262 (duration_to_sec_usec): New function, to check for overflow better.
2263 (Fsleep_for, sit_for): Use it.
2264 * doc.c (get_doc_string, store_function_docstring):
2265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2266 (get_doc_string, Fsnarf_documentation):
2267 Use int, not EMACS_INT, where int is wide enough.
2269 Use SAFE_ALLOCA, not alloca.
2270 Check for overflow when converting EMACS_INT to off_t.
2271 * doprnt.c (doprnt):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2273 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2274 Don't assume uid_t fits into fixnum.
2275 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2276 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2277 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2278 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2279 (general_insert_function)
2280 (Finsert_char, make_buffer_string, make_buffer_string_both)
2281 (update_buffer_properties, Fbuffer_substring)
2282 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2283 (Fsubst_char_in_region, check_translation)
2284 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2285 (transpose_markers, Ftranspose_regions):
2286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2287 (clip_to_bounds): Move to lisp.h as an inline function).
2288 (Fconstrain_to_field): Don't assume integers are nonnegative.
2289 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2290 (Fsubst_char_in_region, Fsave_restriction):
2291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2292 (Femacs_pid): Don't assume pid_t fits into fixnum.
2293 (lo_time): Use int, not EMACS_INT, when int suffices.
2294 (lisp_time_argument): Check for usec out of range.
2295 (Fencode_time): Don't assume fixnum fits in int.
2296 (Fuser_login_name, Fuser_full_name): Signal an error
2297 if a uid argument is out of range, rather than relying on
2299 (Fformat_time_string): Remove now-unnecessary check.
2300 lisp_time_argument checks for out-of-range usec now.
2301 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2302 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2303 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2304 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2305 (init_cmdargs, Fdump_emacs):
2306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2307 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2308 the bottom (typically) 32 bits of the fixnum.
2309 * eval.c (specpdl_size, call_debugger):
2310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2311 (when_entered_debugger, Fbacktrace_debug):
2312 Don't assume fixnum can fit in int.
2313 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2314 the object just before a buffer; this is not portable.
2315 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2316 (grow_specpdl, unbind_to):
2317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2318 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2319 (grow_specpdl): Simplify allocation by using xpalloc.
2320 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2321 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2322 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2324 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2327 (Fcopy_file, non_regular_nbytes, read_non_regular)
2328 (Finsert_file_contents):
2329 Use int, not EMACS_INT, where int is wide enough.
2330 (READ_BUF_SIZE): Verify that it fits in int.
2331 (Finsert_file_contents): Check that counts are in proper range,
2332 rather than assuming fixnums fit into ptrdiff_t etc.
2333 Don't assume fixnums fit into int.
2334 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2335 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2336 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2337 (string_char_to_byte, string_byte_to_char)
2338 (string_make_multibyte, string_to_multibyte)
2339 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2340 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2341 (substring_both, Fdelete, internal_equal, Ffillarray)
2342 (Fclear_string, mapcar1)
2343 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2344 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2345 (larger_vector, make_hash_table, maybe_resize_hash_table)
2346 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2347 (Fmaphash, secure_hash):
2348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2349 (concat): Check for string index and length overflow.
2350 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2353 (larger_vector): New API (vec, incr_min, size_max) replaces old
2354 one (vec, new_size, init). This catches size overflow.
2355 INIT was removed because it was always Qnil.
2356 All callers changed.
2357 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2358 the upper bound on a hash table index size.
2359 (make_hash_table, maybe_resize_hash_table): Use it.
2360 (secure_hash): Computer start_byte and end_byte only after
2361 they're known to be in ptrdiff_t range.
2362 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2363 (Ffont_get_glyphs, Ffont_at):
2364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2365 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2366 (Flist_fonts, Fopen_font):
2367 Don't assume fixnum can fit in int.
2368 (check_gstring): Don't assume index can fit in int.
2369 (font_match_p): Check that fixnum is a character, not a nonnegative
2370 fixnum, since the later code needs to stuff it into an int.
2371 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2372 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2373 conversion overflow issues.
2374 (Fopen_font): Check for integer out of range.
2375 (Ffont_get_glyphs): Don't assume index can fit in int.
2376 * font.h: Adjust decls to match defn changes elsewhere.
2377 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2379 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2380 printmax_t, where ptrdiff_t is wide enough.
2381 (Finternal_char_font):
2382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2383 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2384 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2385 (Fset_frame_position, x_set_frame_parameters)
2386 (x_set_line_spacing, x_set_border_width)
2387 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2388 Check that fixnums are in proper range for system types.
2389 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2391 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2392 Use SAFE_ALLOCA_LISP, not alloca.
2393 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2394 intptr_t is wide enough.
2395 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2396 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2397 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2398 Check for fixnum out of range.
2399 * ftfont.c (ftfont_list): Don't assume index fits in int.
2400 Check that fixnums are in proper range for system types.
2401 (ftfont_shape_by_flt):
2402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2403 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2405 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2406 Check that fixnums are in proper range for system types.
2407 * gnutls.h: Adjust decls to match defn changes elsewhere.
2408 * gtkutil.c (xg_dialog_run):
2409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2410 (update_frame_tool_bar):
2411 Check that fixnums are in proper range for system types.
2412 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2413 (lookup_image): Check that fixnums are in range for system types.
2414 * indent.c (last_known_column, last_known_column_point):
2415 (current_column_bol_cache):
2416 (skip_invisible, current_column, check_display_width):
2417 (check_display_width, scan_for_column, current_column_1)
2418 (Findent_to, Fcurrent_indentation, position_indentation)
2419 (indented_beyond_p, Fmove_to_column, compute_motion):
2420 (Fcompute_motion, Fvertical_motion):
2421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2422 (last_known_column_modified): Use EMACS_INT, not int.
2423 (check_display_width):
2425 Check that fixnums and floats are in proper range for system types.
2426 (compute_motion): Don't assume index or fixnum fits in int.
2427 (compute_motion, Fcompute_motion):
2428 Use int, not EMACS_INT, when it is wide enough.
2429 (vmotion): Omit local var start_hpos that is always 0; that way
2430 we don't need to worry about overflow in expressions involving it.
2431 * indent.h: Adjust decls to match defn changes elsewhere.
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 Use int, not EMACS_INT, where int is wide enough.
2435 Remove unused members ovstring_chars_done and tab_offset;
2437 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2438 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2439 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2440 (make_gap, copy_text, insert, insert_and_inherit)
2441 (insert_before_markers, insert_before_markers_and_inherit)
2442 (insert_1, count_combining_before, count_combining_after)
2443 (insert_1_both, insert_from_string)
2444 (insert_from_string_before_markers, insert_from_string_1)
2445 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2446 (adjust_after_replace, adjust_after_insert, replace_range)
2447 (replace_range_2, del_range, del_range_1, del_range_byte)
2448 (del_range_both, del_range_2, modify_region)
2449 (prepare_to_modify_buffer, signal_before_change)
2450 (signal_after_change, Fcombine_after_change_execute):
2451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2452 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2453 (balance_an_interval, split_interval_right, split_interval_left)
2454 (find_interval, next_interval, update_interval)
2455 (adjust_intervals_for_insertion, delete_node, delete_interval)
2456 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2457 (static_offset_intervals, offset_intervals)
2458 (merge_interval_right, merge_interval_left, make_new_interval)
2459 (graft_intervals_into_buffer, temp_set_point_both)
2460 (temp_set_point, set_point, adjust_for_invis_intang)
2461 (set_point_both, move_if_not_intangible, get_property_and_range)
2462 (get_local_map, copy_intervals, copy_intervals_to_string)
2463 (compare_string_intervals, set_intervals_multibyte_1):
2464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2465 * intervals.h: Adjust decls to match defn changes elsewhere.
2467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2468 * keyboard.c (this_command_key_count, this_single_command_key_start)
2469 (before_command_key_count, before_command_echo_length, echo_now)
2470 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2471 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2472 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2473 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2475 (last_non_minibuf_size, last_point_position, echo_truncate)
2476 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2477 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2478 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2479 (stuff_buffered_input):
2480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2481 (last_auto_save, command_loop_1, read_char):
2482 Use EMACS_INT, not int, to avoid integer overflow.
2483 (record_char): Avoid overflow in total_keys computation.
2484 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2485 * keyboard.h: Adjust decls to match defn changes elsewhere.
2486 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2487 (Fkey_description, Fdescribe_vector, Flookup_key):
2488 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2489 (click_position): New function, to check that positions are in range.
2490 (Fcurrent_active_maps):
2492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2493 (Faccessible_keymaps, Fkey_description):
2494 (preferred_sequence_p):
2495 Don't assume fixnum can fit into int.
2496 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2497 Check for integer overflow in size calculations.
2498 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2499 avoid mishandling large integers.
2500 * lisp.h: Adjust decls to match defn changes elsewhere.
2501 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2502 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2503 (struct Lisp_Marker):
2504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2505 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2506 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2507 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2508 All callers changed.
2509 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2510 Assume the arg has valid form, since it always does.
2511 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2512 unsigned integer system type.
2513 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2514 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2517 (duration_to_sec_usec): New decl.
2518 * lread.c (read_from_string_index, read_from_string_index_byte)
2519 (read_from_string_limit, readchar, unreadchar, openp)
2520 (read_internal_start, read1, oblookup):
2521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2522 (Fload, readevalloop, Feval_buffer, Feval_region):
2523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2524 (openp): Check for out-of-range argument to 'access'.
2525 (read1): Use int, not EMACS_INT, where int is wide enough.
2526 Don't assume fixnum fits into int.
2527 Fix off-by-one error that can read outside a buffer.
2528 (read_filtered_event): Use duration_to_sec_usec
2529 to do proper overflow checking on durations.
2530 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2531 in size calculation.
2532 (Fexecute_kbd_macro):
2533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2534 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2535 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2536 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2537 (set_marker_both, set_marker_restricted_both, marker_position)
2538 (marker_byte_position, Fbuffer_has_markers_at):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2541 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2542 It now merely ensures that the menu is large enough, without
2543 necessarily growing it, as this avoids some integer overflow issues.
2544 All callers changed.
2545 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2548 Use SAFE_ALLOCA_LISP, not alloca.
2549 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2550 to EMACS_INT. Check that fixnums are in proper range for system types.
2551 * minibuf.c (minibuf_prompt_width, string_to_object)
2552 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2553 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2555 (get_minibuffer, read_minibuf_unwind):
2556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2557 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2558 this simplifies overflow checking. All callers changed.
2559 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2562 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2563 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2564 Check that fixnums are in proper range for system types.
2565 (Fx_create_frame, Fx_show_tip):
2566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2567 * nsfont.m (ns_findfonts, nsfont_list_family):
2568 Don't assume fixnum fits in long.
2569 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2570 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2571 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2573 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2575 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2576 (PRINTDECLARE, PRINTPREPARE):
2577 (strout, print_string):
2578 (print, print_preprocess, print_check_string_charset_prop)
2580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2582 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2583 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2584 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2585 (printchar, strout): Use xpalloc to catch size calculation overflow.
2586 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2587 (print_error_message): Use SAFE_ALLOCA, not alloca.
2588 (print_object): Use int, not EMACS_INT, where int is wide enough.
2589 (print_depth, new_backquote_output, print_number_index):
2590 Use ptrdiff_t, not int, where int might not be wide enough.
2591 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2592 (Fset_process_window_size, Fformat_network_address)
2593 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2595 Check that fixnums are in proper range for system types.
2596 (Fsignal_process): Simplify by avoiding a goto.
2597 Check for process-ids out of pid_t range rather than relying on
2599 (process_tick, update_tick): Use EMACS_INT, not int.
2600 (Fformat_network_address, read_process_output, send_process)
2601 (Fprocess_send_region, status_notify):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2603 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2604 (wait_reading_process_output, read_process_output, exec_sentinel):
2605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2606 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2607 (Faccept_process_output): Use duration_to_sec_usec to do proper
2608 overflow checking on durations.
2609 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2610 Don't assume pid_t fits in int.
2611 * process.h (struct Lisp_Process): Members tick and update_tick
2612 are now of type EMACS_INT, not int.
2613 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2614 configured --with-wide-int.
2615 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2616 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2617 * search.c (looking_at_1, string_match_1):
2618 (fast_string_match, fast_c_string_match_ignore_case)
2619 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2620 (scan_newline, find_before_next_newline, search_command)
2621 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2622 (set_search_regs, wordify):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (string_match_1, search_buffer, set_search_regs):
2628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2629 (wordify): Check for overflow in size calculation.
2630 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2631 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2632 Check that fixnums are in proper range for system types.
2633 * sound.c (struct sound_device)
2634 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2636 (Fplay_sound_internal):
2637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2638 * syntax.c (struct lisp_parse_state, find_start_modiff)
2639 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2640 (Fparse_partial_sexp):
2641 Don't assume fixnums can fit in int.
2642 (struct lisp_parse_state, find_start_pos, find_start_value)
2643 (find_start_value_byte, find_start_begv)
2644 (update_syntax_table, char_quoted, dec_bytepos)
2645 (find_defun_start, prev_char_comend_first, back_comment):
2646 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2647 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 (Finternal_describe_syntax_value): Check that match_lisp is a
2650 character, not an integer, since the code stuffs it into int.
2651 (scan_words, scan_sexps_forward):
2652 Check that fixnums are in proper range for system types.
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 (scan_sexps_forward):
2656 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2657 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2658 * syntax.h: Adjust decls to match defn changes elsewhere.
2659 (struct gl_state_s):
2660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2661 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2662 MOST_POSITIVE_FIXNUM.
2663 * sysdep.c (wait_for_termination_1, wait_for_termination)
2664 (interruptible_wait_for_termination, mkdir):
2665 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2666 (emacs_read, emacs_write):
2667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2668 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2669 and double all fit in int.
2670 * term.c (set_tty_color_mode):
2671 Check that fixnums are in proper range for system types.
2672 * termhooks.h (struct input_event):
2673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2674 * textprop.c (validate_interval_range, interval_of)
2675 (Fadd_text_properties, set_text_properties_1)
2676 (Fremove_text_properties, Fremove_list_of_text_properties)
2677 (Ftext_property_any, Ftext_property_not_all)
2678 (copy_text_properties, text_property_list, extend_property_ranges)
2679 (verify_interval_modification):
2680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2681 (Fnext_single_char_property_change)
2682 (Fprevious_single_char_property_change):
2683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2684 (copy_text_properties):
2685 Check for integer overflow in index calculation.
2686 * undo.c (last_boundary_position, record_point, record_insert)
2687 (record_delete, record_marker_adjustment, record_change)
2688 (record_property_change):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2692 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2693 (Fx_hide_tip, Fx_file_dialog):
2694 * w32menu.c (set_frame_menubar):
2695 Use ptrdiff_t, not int, for consistency with rest of code.
2696 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2697 (select_window, Fdelete_other_windows_internal)
2698 (window_scroll_pixel_based, window_scroll_line_based)
2699 (Frecenter, Fset_window_configuration):
2700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2701 (Fset_window_hscroll, run_window_configuration_change_hook)
2702 (set_window_buffer, temp_output_buffer_show, scroll_command)
2703 (Fscroll_other_window, Frecenter):
2704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2705 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2706 Don't assume fixnum fits in int.
2707 (Fset_window_scroll_bars):
2708 Check that fixnums are in proper range for system types.
2709 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2710 (string_pos, c_string_pos, number_of_chars, init_iterator)
2711 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2712 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2713 (compute_display_string_end, handle_face_prop)
2714 (face_before_or_after_it_pos, handle_invisible_prop)
2715 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2716 (display_prop_intangible_p, string_buffer_position_lim)
2717 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2718 (get_overlay_strings_1, get_overlay_strings)
2719 (iterate_out_of_display_property, forward_to_next_line_start)
2720 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2721 (get_next_display_element, set_iterator_to_next)
2722 (get_visually_first_element, compute_stop_pos_backwards)
2723 (handle_stop_backwards, next_element_from_buffer)
2724 (move_it_in_display_line_to, move_it_in_display_line)
2725 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2726 (add_to_log, message_dolog, message_log_check_duplicate)
2727 (message2, message2_nolog, message3, message3_nolog
2728 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2729 (current_message_1, truncate_echo_area, truncate_message_1)
2730 (set_message, set_message_1, store_mode_line_noprop)
2731 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2732 (text_outside_line_unchanged_p, check_point_in_composition)
2733 (reconsider_clip_changes)
2734 (redisplay_internal, set_cursor_from_row, try_scrolling)
2735 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2736 (redisplay_window, find_last_unchanged_at_beg_row)
2737 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2738 (trailing_whitespace_p, find_row_edges, display_line)
2739 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2740 (display_mode_element, store_mode_line_string)
2741 (pint2str, pint2hrstr, decode_mode_spec)
2742 (display_count_lines, display_string, draw_glyphs)
2743 (x_produce_glyphs, x_insert_glyphs)
2744 (rows_from_pos_range, mouse_face_from_buffer_pos)
2745 (fast_find_string_pos, mouse_face_from_string_pos)
2746 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2748 (safe_call, init_from_display_pos, handle_fontified_prop)
2749 (handle_single_display_spec, load_overlay_strings)
2750 (with_echo_area_buffer, setup_echo_area_for_printing)
2751 (display_echo_area, echo_area_display)
2752 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2753 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2754 (redisplay_window, dump_glyph_row, display_mode_line)
2755 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2756 (handle_display_spec, display_prop_string_p):
2757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2758 (handle_single_display_spec, build_desired_tool_bar_string)
2759 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2760 (get_specified_cursor_type):
2761 Check that fixnums are in proper range for system types.
2762 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2763 (Flookup_image_map):
2764 Don't assume fixnums fit in int.
2765 (compare_overlay_entries):
2766 Avoid mishandling comparisons due to subtraction overflow.
2767 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2768 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2769 (handle_tool_bar_click):
2770 Use int, not unsigned, since we prefer signed and the signedness
2771 doesn't matter here.
2772 (get_next_display_element, next_element_from_display_vector):
2773 Use int, not EMACS_INT, when int is wide enough.
2774 (start_hourglass): Use duration_to_sec_usec to do proper
2775 overflow checking on durations.
2776 * xfaces.c (Fbitmap_spec_p):
2777 Check that fixnums are in proper range for system types.
2778 (compare_fonts_by_sort_order):
2779 Avoid mishandling comparisons due to subtraction overflow.
2780 (Fx_family_fonts, realize_basic_faces):
2781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2783 Don't assume fixnum fits in int.
2784 Use SAFE_ALLOCA_LISP, not alloca.
2785 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2786 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2787 (face_at_buffer_position, face_for_overlay_string)
2788 (face_at_string_position):
2789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2790 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2791 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2793 Check that fixnums are in proper range for system types.
2794 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2795 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 (Fx_change_window_property): Don't assume fixnums fit in int.
2798 * xfont.c (xfont_chars_supported):
2799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2800 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2801 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2803 * xml.c (parse_region):
2804 * xrdb.c (magic_file_p):
2805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2806 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2807 (x_get_local_selection, x_reply_selection_request)
2808 (x_handle_selection_request, wait_for_property_change):
2809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2810 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2811 short is wide enough.
2812 (x_send_client_event): Don't assume fixnum fits in int.
2813 * xterm.c (x_x_to_emacs_modifiers):
2814 Don't assume EMACS_INT overflows nicely into int.
2815 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2817 (handle_one_xevent): NATNUMP can eval its arg twice.
2818 (x_connection_closed):
2819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2820 * xterm.h: Adjust decls to match defn changes elsewhere.
2821 (struct scroll_bar): Use struct vectorlike_header
2822 rather than rolling our own approximation.
2823 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2825 2012-05-25 Glenn Morris <rgm@gnu.org>
2827 * lisp.mk (lisp): Update for more files being compiled now.
2829 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2831 * lread.c: Remove `read_pure' which makes no difference.
2832 (read_pure): Remove var.
2833 (unreadpure): Remove function.
2834 (readevalloop): Don't call read_list with -1 flag.
2835 (read1, read_vector): Don't test read_pure any more.
2836 (read_list): Simplify.
2838 * fileio.c, character.h: Minor style tweaks.
2840 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2842 * window.h (clip_changed): Remove useless declaration.
2844 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2846 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2847 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2849 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2852 This directory predates autoconf and is no longer needed nowadays.
2853 Move its few remaining bits of functionality to where they're needed.
2854 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2855 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2856 * m/template.h: Remove.
2857 * Makefile.in (M_FILE): Remove. All uses removed.
2858 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2859 * lisp.h (USE_LSB_TAG):
2860 * mem-limits.h (EXCEEDS_LISP_PTR):
2861 Use VAL_MAX, not VALBITS, in #if.
2862 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2863 (EMACS_UINT): Define unconditionally now.
2864 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2865 (BITS_PER_EMACS_INT): New constants, replacing
2866 what used to be in config.h, but not useful in #if.
2867 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2868 define them any more.
2869 (VAL_MAX): New macro.
2871 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2872 BITS_PER_EMACS_INT, in #if.
2873 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2874 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2875 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2876 * s/ms-w32.h (DATA_START):
2877 Move here from removed file m/intel386.h.
2878 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2879 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2881 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2883 Assume C89 or later.
2884 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2885 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2887 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2888 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2889 * textprop.c, tparam.c (NULL): Remove.
2890 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2891 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2892 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2893 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2894 * xterm.c (input_signal_count): Assume volatile works.
2896 2012-05-21 Ken Brown <kbrown@cornell.edu>
2898 * xgselect.c (xg_select): Fix first argument in call to 'select'
2901 2012-05-20 Ken Brown <kbrown@cornell.edu>
2903 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2904 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2906 2012-05-19 Ken Brown <kbrown@cornell.edu>
2908 * xfns.c (x_in_use): Remove `static' qualifier.
2909 * xterm.h (x_in_use): Declare.
2910 * xgselect.c: Include xterm.h.
2911 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2912 and `display_arg' (bug#9754).
2914 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2916 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2918 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2919 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2921 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2923 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2925 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2926 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2928 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2929 reference to image_cache->refcount.
2930 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2932 2012-05-17 Juri Linkov <juri@jurta.org>
2934 * search.c (Fword_search_regexp, Fword_search_backward)
2935 (Fword_search_forward, Fword_search_backward_lax)
2936 (Fword_search_forward_lax): Move functions to isearch.el
2937 (bug#10145, bug#11381).
2939 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2941 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2943 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2945 * lread.c (init_obarray): Declare Qt and Qnil as special.
2947 2012-05-14 Glenn Morris <rgm@gnu.org>
2949 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2950 Put "libexec" before "bin", for the sake of init_callproc_1.
2952 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2954 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2956 * unexaix.c: Port to more-recent AIX compilers.
2957 (report_error, report_error_1, make_hdr, copy_sym)
2958 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2959 Make arguments const char *, not char *, to avoid violations of C
2960 standard and to fix some AIX warnings reported by Gilles Pion.
2962 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2964 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2965 already have overlays loaded.
2966 (handle_single_display_spec): Before returning without displaying
2967 fringe bitmap, synchronize the bidi iterator with the main display
2968 iterator, by calling iterate_out_of_display_property.
2969 (iterate_out_of_display_property): Detect buffer iteration by
2970 testing that it->string is a Lisp string.
2971 (get_next_display_element): When the current object is exhausted,
2972 and there's something on it->stack, call set_iterator_to_next to
2973 proceed with what's on the stack, instead of returning zero.
2974 (set_iterator_to_next): If called at the end of a Lisp string,
2975 proceed to consider_string_end without incrementing string
2976 position. Don't increment display vector index past the end of
2977 the display vector. (Bug#11417)
2978 (pos_visible_p): Don't report a position visible when move_it_to
2979 stopped at the last line of window, which happens to be scanned
2980 backwards by the bidi iteration. (Bug#11464)
2982 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2984 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2985 and right-margin display specs even if the spec is invalid or we
2986 are on a TTY, and thus unable to display on the fringes.
2987 That's because the text with the property will not be displayed anyway,
2988 so we need to signal to the caller that this is a "replacing"
2989 display spec. This fixes display when the spec is invalid or we
2992 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2994 * unexaix.c (make_hdr): Fix typo in prototype.
2995 This bug broke the build on AIX. Problem reported by Gilles Pion.
2997 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2999 * keyboard.c (kbd_buffer_get_event): Read special events also in
3000 batch mode. (Bug#11415)
3002 2012-05-12 Glenn Morris <rgm@gnu.org>
3004 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3006 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3008 * lisp.mk (lisp): Add newcomment.elc.
3010 2012-05-12 Glenn Morris <rgm@gnu.org>
3012 * Makefile.in (MKDIR_P): New, set by configure.
3013 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3015 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3017 Remove unused function hourglass_started.
3018 * dispextern.h (hourglass_started):
3019 * w32fns.c (hourglass_started):
3020 * xdisp.c (hourglass_started): Remove.
3022 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3024 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3025 Update dependencies.
3027 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3029 * xgselect.c (xg_select): Put maxfds+1 into a var.
3030 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3032 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3034 2012-05-10 Dave Abrahams <dave@boostpro.com>
3036 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3037 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3039 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3041 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3042 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3043 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3044 Initialize xd_registered_buses.
3046 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3048 Untag more efficiently if USE_LSB_TAG.
3049 This is based on a proposal by YAMAMOTO Mitsuharu in
3050 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3051 For an admittedly artificial (nth 8000 longlist) benchmark on
3052 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3053 Emacs's overall text size by 1%.
3054 * lisp.h (XUNTAG): New macro.
3055 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3056 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3057 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3058 * eval.c (Fautoload):
3059 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3060 * frame.h (XFRAME): Use XUNTAG.
3062 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3063 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3064 Remove unportable assumptions about print widths of types like
3066 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3067 intptr_t when converting between pointer and integer, to avoid GCC
3068 warnings about wrong width.
3070 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3072 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3073 stack for each reader_thread, instead of defaulting to 8MB
3074 determined by the linker. This avoids failures in creating
3075 subprocesses on Windows 7, see the discussion in this thread:
3076 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3078 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3080 Fix up display of the *Minibuf-0* buffer in the mini window.
3081 * keyboard.c (read_char): Don't clear the echo area if there's no
3083 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3084 contents of *Minibuf-0*) if there's no message displayed in its stead.
3086 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3088 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3091 2012-05-06 Chong Yidong <cyd@gnu.org>
3093 * lisp.mk (lisp): Update.
3095 2012-05-05 Jim Meyering <meyering@redhat.com>
3097 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3099 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3101 * data.c (PUT_ERROR): New macro.
3102 (syms_of_data): Use it. Add new error type `user-error'.
3103 * undo.c (user_error): New function.
3104 (Fprimitive_undo): Use it.
3105 * print.c (print_error_message): Adjust print style for `user-error'.
3106 * keyboard.c (user_error): New function.
3107 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3109 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3111 Do not limit current-time-string to years 1000..9999.
3112 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3113 (Fcurrent_time_string): Support any year that is supported by the
3114 underlying localtime representation. Don't use asctime, as it
3115 has undefined behavior for years outside the range -999..9999.
3117 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3119 Fix race conditions involving setenv, gmtime, localtime, asctime.
3120 Without this fix, interrupts could mess up code that uses these
3121 nonreentrant functions, since setting TZ invalidates existing
3122 tm_zone or tzname values, and since most of these functions return
3123 pointers to static storage.
3124 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3125 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3126 Grow the critical sections to include not just invoking
3127 localtime/gmtime, but also accessing these functions' results
3128 including their tm_zone values if any, and any related TZ setting.
3129 (format_time_string): Last arg is now struct tm *, not struct tm **,
3130 so that the struct tm is saved in the critical section.
3131 All callers changed. Simplify allocation of initial buffer, partly
3132 motivated by the fact that memory allocation needs to be outside
3133 the critical section.
3135 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3137 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3138 with RESET_INTERVAL.
3140 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3141 Remove duplicated buffer name initialization.
3143 2012-05-02 Jim Meyering <jim@meyering.net>
3145 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3147 * xfns.c (x_window): Use xstrdup (Bug#11375).
3149 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3151 * xdisp.c (pos_visible_p): If already at a newline from the
3152 display string before the 'while' loop, don't walk back the glyphs
3153 from it3.glyph_row. Solves assertion violation when the display
3154 string begins with a newline (egg.el). (Bug#11367)
3156 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3158 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3161 2012-05-01 Glenn Morris <rgm@gnu.org>
3163 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3164 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3165 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3166 All were removed before 23.1.
3168 * dispnew.c: Remove HAVE_LIBNCURSES test;
3169 it is always true on relevant platforms.
3171 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3172 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3174 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3176 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3178 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3179 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3182 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3184 Do not avoid creating empty evaporating overlays (Bug#9642).
3185 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3186 That is, do not delete an evaporating overlay if it becomes
3187 empty after its bounds are adjusted to fit within its buffer.
3188 This fix caused other problems, and I'm reverting it until we get
3189 to the bottom of them.
3191 2012-04-27 Chong Yidong <cyd@gnu.org>
3193 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3195 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3197 * xdisp.c (pos_visible_p): If the window start position is beyond
3198 ZV, start the display from buffer beginning. Prevents assertion
3199 violation in init_iterator when the minibuffer window is scrolled
3202 * window.c (window_scroll_pixel_based): Likewise.
3204 2012-04-27 Chong Yidong <cyd@gnu.org>
3206 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3208 2012-04-27 Glenn Morris <rgm@gnu.org>
3210 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3211 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3213 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3215 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3216 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3218 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3220 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3221 display element, check also the underlying string or buffer
3222 character. (Bug#11341)
3224 * w32menu.c: Include w32heap.h.
3225 (add_menu_item): If the call to AppendMenuW (via
3226 unicode_append_menu) fails, disable Unicode menus only if we are
3227 running on Windows 9X/Me.
3229 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3231 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3232 (xgetint): Add missing shift for LSB tags.
3234 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3236 * keyboard.c (read_char): Don't wipe echo area for select window
3237 events: These might get delayed via `mouse-autoselect-window'
3240 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3242 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3243 manipulation of :loaded-from data.
3245 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3247 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3248 now a cons (bug#11311).
3250 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3252 Do not create empty overlays with the evaporate property (Bug#9642).
3253 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3254 if it becomes empty after its bounds are adjusted to fit within
3255 its buffer. Without this fix, in a nonempty buffer (let ((o
3256 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3257 yields an empty overlay that has the evaporate property, which is
3258 not supposed to happen.
3260 Fix minor GTK3 problems found by static checking.
3261 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3262 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3263 (struct _EmacsFixedClass, emacs_fixed_get_type):
3264 Move decls here from emacsgtkfixed.h, since they needn't be public.
3265 (emacs_fixed_get_type): Now static.
3266 (emacs_fixed_class_init): Omit unused local.
3267 (emacs_fixed_child_type): Remove; unused.
3268 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3269 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3270 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3271 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3272 (EMACS_FIXED_GET_CLASS): Remove; unused.
3273 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3275 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3276 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3278 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3280 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3281 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3282 (__malloc_size_t, __malloc_ptrdiff_t):
3283 Remove. All uses removed, replaced by the definiens if needed,
3284 since we can assume C89 or better now.
3285 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3286 (protect_malloc_state, align, get_contiguous_space)
3287 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3288 (malloc_atfork_handler_child, malloc_enable_thread)
3289 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3290 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3291 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3292 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3293 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3294 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3295 Define using prototypes, not old style.
3296 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3297 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3298 (align): Don't assume that signed integer overflow wraps around.
3299 Omit unused local var.
3300 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3301 (_free_internal_nolock, memalign, mallochook, reallochook):
3302 Omit no-longer-needed casts.
3303 (valloc): Use getpagesize, not __getpagesize.
3304 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3305 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3307 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3309 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3311 Move functions from C to Lisp. Make non-blocking method calls
3312 the default. Implement further D-Bus standard interfaces.
3314 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3315 (QCdbus_request_name_allow_replacement)
3316 (QCdbus_request_name_replace_existing)
3317 (QCdbus_request_name_do_not_queue)
3318 (QCdbus_request_name_reply_primary_owner)
3319 (QCdbus_request_name_reply_in_queue)
3320 (QCdbus_request_name_reply_exists)
3321 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3322 (QCdbus_registered_serial, QCdbus_registered_method)
3323 (QCdbus_registered_signal): New Lisp objects.
3324 (XD_DEBUG_MESSAGE): Use sizeof.
3325 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3326 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3327 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3328 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3329 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3330 (xd_signature, xd_append_arg): Allow float for integer types.
3331 (xd_get_connection_references): New function.
3332 (xd_get_connection_address): Rename from xd_initialize.
3333 Return cached address.
3334 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3335 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3337 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3338 Return number of refcounts.
3339 (Fdbus_get_unique_name): Make stronger parameter check.
3340 (Fdbus_message_internal): New defun.
3341 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3342 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3343 (Fdbus_send_signal, Fdbus_register_service)
3344 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3345 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3346 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3347 (Vdbus_compiled_version, Vdbus_runtime_version)
3348 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3349 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3350 (Vdbus_message_type_signal): New defvars.
3351 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3354 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3356 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3357 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3358 Do not assume ptrdiff_t is the same width as 'int'.
3360 * alloc.c: Handle unusual debugging option combinations.
3361 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3362 since the two debugging options are incompatible.
3363 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3365 (mem_init, mem_insert, mem_insert_fixup):
3366 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3367 (NEED_MEM_INSERT): Remove; no longer needed.
3369 2012-04-22 Leo Liu <sdl.web@gmail.com>
3371 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3373 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3375 * sysdep.c [__FreeBSD__]: Minor cleanups.
3376 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3377 Use Emacs indenting style more consistently. Avoid some casts.
3378 Use 'double' consistently rather than mixing 'float' and 'double'.
3380 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3382 * sysdep.c (list_system_processes, system_process_attributes):
3383 Add implementation for FreeBSD (Bug#5243).
3385 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3387 * lisp.mk (lisp): Update.
3389 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3391 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3392 It is never used otherwise.
3394 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3396 * print.c (print_preprocess): Only check print_depth if print-circle
3398 (print_object): Check for cycles even when print-circle is nil and
3399 print-gensym is t, but only check print_depth if print-circle is nil.
3401 2012-04-20 Chong Yidong <cyd@gnu.org>
3403 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3404 set the status to "failed" and ensure that sentinel is run.
3406 2012-04-20 Glenn Morris <rgm@gnu.org>
3408 * process.c (Fset_process_inherit_coding_system_flag)
3409 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3410 (Fmake_network_process, Fmake_serial_process): Doc fix.
3412 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3414 * xdisp.c (string_buffer_position_lim): Limit starting position to
3416 (set_cursor_from_row): If called for a mode-line or header-line
3417 row, return zero immediately.
3418 (try_cursor_movement): If inside continuation line, don't back up
3419 farther than the first row after the header line, if any.
3420 Don't consider the header-line row as "partially visible", even if
3421 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3423 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3425 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3428 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3429 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3431 configure: new option --enable-gcc-warnings (Bug#11207)
3432 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3433 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3434 (ALL_CFLAGS): Use new macros rather than old.
3435 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3436 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3437 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3438 -Wunused-result, -Wunused-variable. This should go away once
3439 the Emacs and Gnulib regex code is merged.
3440 (xmalloc, xrealloc): Now static.
3442 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3444 * dired.c (Fsystem_groups): Remove unused local.
3446 2012-04-17 Glenn Morris <rgm@gnu.org>
3448 * dired.c (Fsystem_users): Doc fix.
3450 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3452 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3453 (syms_of_dired): Add them.
3455 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3457 Fix minor alloc.c problems found by static checking.
3458 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3459 New extern decls, to avoid calling undeclared functions.
3460 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3461 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3462 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3463 (NEED_MEM_INSERT): New macro.
3464 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3465 Remove one incorrect comment and fix another.
3467 Fix minor ralloc.c problems found by static checking.
3468 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3469 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3470 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3471 (r_alloc_sbrk): Now static.
3473 Improve ralloc.c interface checking.
3474 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3475 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3476 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3477 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3478 [REL_ALLOC]: ... to here, to check interface.
3479 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3480 Remove decls. This fixes an "It stinks!".
3482 * alloc.c (which_symbols): Fix alignment issue / type clash.
3484 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3486 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3487 (struct Lisp_Misc_Any): Likewise.
3488 (struct Lisp_Free): Likewise.
3489 * alloc.c (union aligned_Lisp_Symbol): Define.
3490 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3491 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3492 (union aligned_Lisp_Misc): Define.
3493 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3494 aligned_Lisp_Misc instead of union Lisp_Misc.
3495 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3497 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3499 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3500 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3501 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3502 * s/netbsd.h, s/sol2-6.h:
3503 Remove definition of GC_MARK_STACK, since the default now works.
3504 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3505 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3506 no longer the default.
3507 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3509 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3511 * lread.c (lisp_file_lexically_bound_p):
3512 Fix hang at ";-*-\n" (bug#11238).
3514 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3516 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3517 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3519 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3521 * nsterm.m (constrainFrameRect): Always constrain when there is only
3522 one screen (Bug#10962).
3524 2012-04-13 Ken Brown <kbrown@cornell.edu>
3526 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3528 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3530 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3532 2012-04-11 Daniel Colascione <dancol@dancol.org>
3534 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3535 against is gone. It's better to use vfork now so that when Cygwin
3536 gains a new, working vfork, we use it automatically (bug#10398).
3538 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3540 * window.c (save_window_save): Obey window-point-insertion-type.
3542 2012-04-11 Glenn Morris <rgm@gnu.org>
3544 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3546 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3548 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3550 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3552 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3553 (force_quit_count): New var.
3554 (handle_interrupt): Use it.
3556 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3558 * w32.c (w32_delayed_load): Record the full path of the library
3559 being loaded (bug#10424).
3561 2012-04-09 Glenn Morris <rgm@gnu.org>
3563 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3564 not just in the obarray, before snarfing them. (Bug#11036)
3566 * Makefile.in ($(leimdir)/leim-list.el):
3567 Pass EMACS rather than BUILT_EMACS.
3569 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3571 * process.c (make_process):
3572 * process.h: Add integer `gnutls_handshakes_tried' member to
3575 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3576 Add convenience `GNUTLS_LOG2i' macro.
3578 * gnutls.c (gnutls_log_function2i): Convenience log function.
3579 (emacs_gnutls_read): Use new log functions,
3580 `gnutls_handshakes_tried' process member, and
3581 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3582 attempts per process (connection).
3584 2012-04-09 Chong Yidong <cyd@gnu.org>
3586 * eval.c (Fuser_variable_p, user_variable_p_eh)
3587 (lisp_indirect_variable): Functions deleted.
3588 (Fdefvar): Caller changed.
3590 * callint.c (Finteractive, Fcall_interactively):
3591 * minibuf.c (Fread_variable): Callers changed.
3593 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3595 * xdisp.c (set_cursor_from_row): If the display string appears in
3596 the buffer at position that is closer to point than the position
3597 after the display string, display the cursor on the first glyph of
3598 the display string. Fixes cursor display when a 'display' text
3599 property immediately follows invisible text. (Bug#11094)
3601 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3603 composite.c: use 'double' consistently
3604 * composite.c (get_composition_id): Use 'double' consistently
3605 instead of converting 'float' to 'double' and vice versa; this is
3606 easier to understand and avoids a GCC warning.
3608 2012-04-09 Glenn Morris <rgm@gnu.org>
3610 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3611 preparation for dumping it with emacs. (Bug#4789)
3612 (leimdir): New variable.
3613 ($(leimdir)/leim-list.el): New rule.
3614 (emacs$(EXEEXT)): Depend on leim-list.el.
3616 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3617 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3618 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3620 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3622 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3625 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3627 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3628 Remove unused local variable.
3630 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3632 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3633 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3634 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3635 objects, as mark_maybe_pointer will catch them otherwise.
3636 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3637 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3639 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3641 Fix typo that broke non-Windows builds.
3642 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3644 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3646 Support building on MS-Windows with libxml2.
3648 * makefile.w32-in (OBJ2): Add xml.$(O).
3649 (GLOBAL_SOURCES): Add xml.c.
3650 ($(BLD)/xml.$(O)): New dependency list.
3652 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3653 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3654 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3655 [!WINDOWSNT]: New macros.
3656 (init_libxml2_functions, libxml2_loaded_p): New functions.
3657 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3658 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3659 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3660 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3662 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3663 Call init_libxml2_functions before calling libxml2 functions.
3664 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3666 * emacs.c: Don't include libxml/parser.h.
3667 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3668 xmlCleanupParser directly.
3670 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3672 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3674 * indent.c (Fvertical_motion): If there is a display string at
3675 point, use it.vpos to compute how many lines to backtrack after
3676 move_it_to point. (Bug#11133)
3678 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3680 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3681 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3682 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3683 macros related to unification of CJK characters. For the details,
3684 see the discussion following the message here:
3685 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3687 2012-04-04 Chong Yidong <cyd@gnu.org>
3689 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3691 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3693 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3694 instead of alloca. (Bug#11138)
3696 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3698 * w32menu.c (is_simple_dialog): Properly check lisp types.
3701 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3703 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3704 position we get to after a call to move_it_to fails the
3705 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3706 only if we wind up in a string from display property. (Bug#11063)
3708 * window.c (Fdelete_other_windows_internal): Invalidate the row
3709 and column information about mouse highlight, so that redisplay
3710 restores it after reallocating the glyph matrices. (Bug#7464)
3712 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3713 string comes from a `display' text property, use the buffer
3714 position of that property as if we actually saw that position in
3716 (move_it_by_lines): Remove the assertion that
3717 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3718 violated when there's a before-string at the beginning of a line.
3721 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3723 * xdisp.c (append_space_for_newline): If the default face was
3724 remapped, use the remapped face for the appended newline.
3725 (extend_face_to_end_of_line): Use the remapped default face for
3726 extending the face to the end of the line.
3727 (display_line): Call extend_face_to_end_of_line when the default
3728 face was remapped. (Bug#11068)
3730 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3732 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3734 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3736 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3738 2012-03-27 Glenn Morris <rgm@gnu.org>
3740 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3743 2012-03-26 Kenichi Handa <handa@m17n.org>
3745 * dispextern.h (struct glyph): Fix previous change. Change the
3746 bit length of glyphless.ch to 25 (Bug#11082).
3748 2012-03-26 Chong Yidong <cyd@gnu.org>
3750 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3751 (command_loop_1): Use it; inhibit selection update for
3752 handle-select-window too (Bug#8996).
3754 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3756 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3758 2012-03-25 Kenichi Handa <handa@m17n.org>
3760 * dispextern.h (struct glyph): Change the bit length of
3761 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3763 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3765 * s/ms-w32.h (tzname): Include time.h before redirecting to
3766 _tzname. Fixes the MSVC build. (Bug#9960)
3768 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3770 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3773 * xterm.c (XTread_socket): Only modify handling_signal if
3774 !SYNC_INPUT. (Bug#11080)
3776 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3778 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3779 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3780 when fetching a multibyte character consumes more bytes than
3781 CHAR_BYTES returns, due to unification of CJK characters in
3782 string_char. (Bug#11073)
3784 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3786 * process.c (wait_reading_process_output): Handle pty disconnect
3787 by refraining from sending oneself a SIGCHLD (bug#10933).
3789 2012-03-22 Chong Yidong <cyd@gnu.org>
3791 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3793 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3794 Mark string as coming from a prefix property.
3795 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3796 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3798 2012-03-21 Chong Yidong <cyd@gnu.org>
3800 * xfaces.c (Vface_remapping_alist): Doc fix.
3802 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3804 * w32proc.c (Fw32_set_console_codepage)
3805 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3808 2012-03-20 Chong Yidong <cyd@gnu.org>
3810 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3811 to reflect default non-nil value of redisplay-dont-pause.
3813 2012-03-19 Kenichi Handa <handa@m17n.org>
3815 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3816 it fit in a valid range (Bug#11003).
3818 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3820 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3821 that is not from display property, accept the row as a "cursor
3822 row" if one of the string's character has a non-nil `cursor'
3823 property. Fixes cursor positioning when there are newlines in
3824 overlay strings, e.g. in icomplete.el. (Bug#11035)
3826 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3828 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3830 2012-03-12 Chong Yidong <cyd@gnu.org>
3832 * eval.c (inhibit_lisp_code): Rename from
3833 inhibit_window_configuration_change_hook; move from window.c.
3835 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3836 * window.c (run_window_configuration_change_hook)
3837 (syms_of_window): Callers changed.
3839 2012-03-11 Chong Yidong <cyd@gnu.org>
3841 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3843 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3845 2012-03-10 Chong Yidong <cyd@gnu.org>
3847 * frame.c (other_visible_frames): Don't assume the selected frame
3848 is visible (Bug#10955).
3850 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3852 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3854 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3856 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3857 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3860 2012-03-03 Glenn Morris <rgm@gnu.org>
3862 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3864 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3866 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3867 position past the first glyph_row that ends at ZV. (Bug#10902)
3868 (redisplay_window, next_element_from_string): Fix typos in
3870 (redisplay_window): Pass to move_it_vertically the margin in
3871 pixels, not in screen lines.
3873 2012-03-02 Glenn Morris <rgm@gnu.org>
3875 * buffer.c (buffer-list-update-hook): Doc fix.
3877 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3879 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3880 push_it before setting up the iterator for the first overlay
3881 string, even if we have an empty string loaded.
3882 (next_overlay_string): If there's an empty string on the iterator
3883 stack, pop the stack. (Bug#10903)
3885 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3887 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3888 Suggested by Stefan Monnier in
3889 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3890 * alloc.c (widen_to_Lisp_Object): New static function.
3891 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3892 and widening them to Lisp_Objects. This would work even if
3893 USE_LSB_TAG is defined and wide integers are used, which might
3894 happen in a future version of Emacs.
3896 2012-02-25 Chong Yidong <cyd@gnu.org>
3898 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3901 * xselect.c (Fx_selection_exists_p): Doc fix.
3902 (x_clipboard_manager_save_all): Print an informative message
3903 before saving to clipboard manager.
3905 2012-02-24 Chong Yidong <cyd@gnu.org>
3907 * keyboard.c (process_special_events): Handle all X selection
3908 requests in kbd_buffer, not just the next one (Bug#8869).
3910 2012-02-23 Chong Yidong <cyd@gnu.org>
3912 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3913 call when setting menu-bar-lines and tool-bar-lines parameters.
3914 (unwind_create_frame_1): New helper function.
3916 * window.c (inhibit_window_configuration_change_hook): New var.
3917 (run_window_configuration_change_hook): Obey it.
3918 (syms_of_window): Initialize it.
3920 2012-02-22 Chong Yidong <cyd@gnu.org>
3922 * xterm.c (x_draw_image_relief): Add missing type check for
3923 Vtool_bar_button_margin (Bug#10743).
3925 2012-02-21 Chong Yidong <cyd@gnu.org>
3927 * fileio.c (Vfile_name_handler_alist): Doc fix.
3929 * buffer.c (Fget_file_buffer): Protect against invalid file
3930 handler return value.
3932 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3934 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3935 when computing $valmask.
3937 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3938 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3939 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3940 It's useless in that case, and it can cause problems on hosts
3941 that allocate halves of EMACS_INT values separately.
3942 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3943 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3944 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3945 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3946 it avoids undefined behavior on hosts where shifting right by more
3947 than the word width has undefined behavior.
3949 2012-02-19 Chong Yidong <cyd@gnu.org>
3951 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3952 (Funhandled_file_name_directory, Ffile_name_as_directory)
3953 (Fdirectory_file_name, Fexpand_file_name)
3954 (Fsubstitute_in_file_name): Protect against invalid file handler
3955 return values (Bug#10845).
3957 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3959 * .gdbinit (pitx): Fix incorrect references to fields of the
3962 2012-02-17 Chong Yidong <cyd@gnu.org>
3964 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3966 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3968 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3969 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3971 2012-02-15 Chong Yidong <cyd@gnu.org>
3973 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3974 marked as special. Also, starting docstrings with * is obsolete.
3976 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3978 * gnutls.c (emacs_gnutls_write): Fix last change.
3980 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3982 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3985 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3987 * keymap.c (Fsingle_key_description): Handle char ranges.
3989 2012-02-12 Chong Yidong <cyd@gnu.org>
3991 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3992 as that creates a dangerous corner case.
3994 * window.c (Fdelete_window_internal): Invalidate the mouse
3995 highlight (Bug#9904).
3997 2012-02-12 Glenn Morris <rgm@gnu.org>
3999 * xselect.c (Fx_own_selection_internal)
4000 (Fx_get_selection_internal, Fx_disown_selection_internal)
4001 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4002 * nsselect.m (Fx_own_selection_internal)
4003 (Fx_disown_selection_internal, Fx_selection_exists_p)
4004 (Fx_selection_owner_p, Fx_get_selection_internal):
4005 Sync docs and argument specs with the xselect.c versions.
4007 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4009 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4011 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4013 * w32select.c (Fx_selection_exists_p): Sync doc string and
4014 argument list with xselect.c. (Bug#10783)
4016 * w16select.c (Fx_selection_exists_p): Sync doc string and
4017 argument list with xselect.c. (Bug#10783)
4019 2012-02-10 Glenn Morris <rgm@gnu.org>
4021 * fns.c (Fsecure_hash): Doc fix.
4023 2012-02-09 Kenichi Handa <handa@m17n.org>
4025 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4027 2012-02-07 Chong Yidong <cyd@gnu.org>
4029 * buffer.c (Fbuffer_local_variables)
4030 (buffer_lisp_local_variables): Handle unbound vars correctly;
4031 don't let Qunbound leak into Lisp.
4033 2012-02-07 Glenn Morris <rgm@gnu.org>
4035 * image.c (Fimagemagick_types): Doc fix.
4037 * image.c (imagemagick-render-type): Change it from a lisp object
4038 to an integer. Move the doc here from the lisp manual.
4039 Treat all values not equal to 0 the same.
4041 2012-02-06 Chong Yidong <cyd@gnu.org>
4043 * doc.c (store_function_docstring): Avoid applying docstring of
4044 alias to base function (Bug#2603).
4046 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4048 * .gdbinit (pp1, pv1): Remove redundant defines.
4051 2012-02-04 Chong Yidong <cyd@gnu.org>
4053 * nsterm.m: Declare a global (Bug#10694).
4055 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4057 * w32.c (get_emacs_configuration_options):
4058 Include --enable-checking, if specified, in the return value.
4060 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4062 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4063 after rounding frame sizes. (Bug#9723)
4065 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4067 * keyboard.c (adjust_point_for_property): Don't position point
4068 before BEGV. (Bug#10696)
4070 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4072 Handle overflow when computing char display width (Bug#9496).
4073 * character.c (char_width): Return EMACS_INT, not int.
4074 (char_width, c_string_width): Check for overflow when
4075 computing the width; this is possible now that individual
4076 characters can have unbounded width. Problem introduced
4077 by merge from Emacs 23 on 2012-01-19.
4079 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4081 * dbusbind.c (Fdbus_register_method): Mention the return value
4082 :ignore in the docstring.
4084 2012-02-02 Glenn Morris <rgm@gnu.org>
4086 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4088 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4089 Unconditionally set to t. (Bug#10673)
4090 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4091 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4092 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4094 2012-02-02 Kenichi Handa <handa@m17n.org>
4096 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4097 0, do not call append_composite_glyph.
4099 2012-02-02 Kenichi Handa <handa@m17n.org>
4101 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4103 (x_produce_glyphs): If the component of a composition is a null
4104 string, set it->pixel_width to 1 to avoid zero-width glyph.
4106 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4108 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4109 first 2 arguments are identical. This makes inserting large
4110 output from a subprocess an order of magnitude faster on
4111 MS-Windows, where all sbrk'ed memory is always contiguous.
4113 2012-01-31 Glenn Morris <rgm@gnu.org>
4115 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4116 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4117 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4119 2012-01-29 Glenn Morris <rgm@gnu.org>
4121 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4123 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4125 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4127 2012-01-28 Chong Yidong <cyd@gnu.org>
4129 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4131 2012-01-26 Chong Yidong <cyd@gnu.org>
4133 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4135 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4136 repeat counts (Bug#10507).
4138 2012-01-26 Glenn Morris <rgm@gnu.org>
4140 * lread.c (syms_of_lread): Doc fix.
4142 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4144 * coding.c (encode_designation_at_bol): Change return value to
4147 2012-01-25 Chong Yidong <cyd@gnu.org>
4149 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4151 2012-01-21 Chong Yidong <cyd@gnu.org>
4153 * floatfns.c (Fcopysign): Make the second argument non-optional,
4154 since nil is not allowed anyway.
4156 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4158 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4159 (send_process): Likewise.
4161 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4163 * window.c (save_window_save, Fcurrent_window_configuration)
4164 (Vwindow_persistent_parameters): Do not use Qstate.
4165 Rewrite doc-strings.
4167 2012-01-19 Kenichi Handa <handa@m17n.org>
4169 * character.c (char_width): New function.
4170 (Fchar_width, c_string_width, lisp_string_width):
4171 Use char_width (Bug#9496).
4173 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4175 * window.c (Vwindow_persistent_parameters): New variable.
4176 (Fset_window_configuration, save_window_save): Handle persistent
4179 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4181 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4182 thrashing the stack of the thread. (Bug#9087)
4184 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4186 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4188 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4190 * xdisp.c (rows_from_pos_range): Handle the case where the
4191 highlight ends on a newline. (Bug#10464)
4192 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4193 he end column for display of highlight that ends on a newline
4196 2012-01-11 Glenn Morris <rgm@gnu.org>
4198 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4199 from load-path also when installation-directory is nil. (Bug#10208)
4201 2012-01-10 Glenn Morris <rgm@gnu.org>
4203 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4205 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4206 Update template values to be closer to their typical values these days.
4208 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4210 * xdisp.c (rows_from_pos_range): Accept additional argument
4211 DISP_STRING, and accept any glyph in a row whose object is that
4212 string as eligible for mouse highlight. Fixes mouse highlight of
4213 display strings from overlays. (Bug#10464)
4215 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4217 emacs: fix an auto-save permissions race condition (Bug#10400)
4218 * fileio.c (auto_saving_dir_umask): New static var.
4219 (Fmake_directory_internal): Use it.
4220 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4221 creating the directory. The old code temporarily assigns
4222 too-generous permissions to the directory.
4223 (do_auto_save_eh): Clear it.
4224 (Fdo_auto_save): Catch all errors, not just file errors, so
4225 that the var is always cleared.
4227 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4229 * search.c (scan_buffer): Pass character positions to
4230 know_region_cache, not byte positions. (Bug#6540)
4232 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4234 * w32.c (sys_rename): Report EXDEV when rename of a directory
4235 fails because the target is on another logical disk. (Bug#10284)
4237 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4239 * xterm.c (x_embed_request_focus): New function.
4241 * xterm.h: Add prototype.
4243 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4245 2012-01-05 Glenn Morris <rgm@gnu.org>
4247 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4249 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4251 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4252 Load gnutls_transport_set_lowat only if GnuTLS version is below
4254 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4255 GnuTLS versions below 2.11.1.
4257 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4259 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4260 to the doc string advising against its use for altering the way
4261 windows are scrolled.
4263 2011-12-28 Kenichi Handa <handa@m17n.org>
4265 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4266 coding-system ASCII compatible only when it does not produce BOM
4267 on encoding (Bug#10383).
4269 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4271 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4273 (create_and_show_popup_menu): Always use menu_position_func for
4276 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4278 * callint.c (Fcall_interactively): Don't truncate prompt string.
4280 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4282 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4283 property that ends at ZV, so that the bidi iteration could be
4284 resumed from there (after widening). (Bug#10360)
4286 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4288 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4290 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4292 * nsterm.m (x_free_frame_resources):
4293 Release f->output_data.ns->miniimage.
4294 (ns_index_color): Fix indentation. Do not retain
4295 color_table->colors[i].
4297 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4300 * nsfns.m (x_set_background_color): Assign return value from
4301 ns_index_color to face-background instead of NSColor*.
4302 (ns_implicitly_set_icon_type): Fix indentation.
4303 Change assignment in for loop to comparison.
4305 * emacs.c (ns_pool): New variable.
4306 (main): Assign ns_pool.
4307 (Fkill_emacs): Call ns_release_autorelease_pool.
4309 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4310 autorelease fdesc, release fdAttrs and tdict.
4311 (ns_get_covering_families): Release charset.
4312 (ns_findfonts): Release NSFontDescriptor created with new.
4313 (ns_uni_to_glyphs): Fix indentation.
4314 (setString): Release attrStr before assigning new value.
4316 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4318 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4320 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4321 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4323 2011-12-18 David Reitter <reitter@cmu.edu>
4325 * nsterm.m (ns_term_init): Subscribe for notifications
4326 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4327 to method trackingNotification in EmacsMenu.
4329 * nsmenu.m (trackingMenu): New variable.
4330 (trackingNotification): New method (from Aquamacs).
4331 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4332 from Aquamacs (Bug#7030).
4334 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4336 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4337 (symbol_to_nsstring): Fix indentation.
4338 (ns_symbol_to_pb): New function.
4339 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4340 (Fns_rotate_cut_buffers_internal): Remove.
4341 (Fns_store_selection_internal): Rename from
4342 Fns_store_cut_buffer_internal.
4343 (ns_get_foreign_selection, Fx_own_selection_internal)
4344 (Fx_disown_selection_internal, Fx_selection_exists_p)
4345 (Fns_get_selection_internal, Fns_store_selection_internal):
4346 Use ns_symbol_to_pb and check if return value is nil.
4347 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4348 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4349 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4350 renamed to Sns_store_selection_internal.
4351 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4352 and remove this function.
4353 (ns_handle_selection_clear): Remove, never used.
4354 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4357 2011-12-17 Ken Brown <kbrown@cornell.edu>
4359 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4360 GID is unknown (Bug#10257).
4362 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4364 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4365 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4366 which caused a build failure on GNU/Linux IA-64. This problem was
4367 introduced by my 2011-10-07 patch.
4369 2011-12-15 Juri Linkov <juri@jurta.org>
4371 * image.c (imagemagick_error): New function. (Bug#10112)
4372 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4373 Use `imagemagick_error' where ImageMagick functions return
4375 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4378 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4380 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4381 fill background (Bug#8992).
4383 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4385 * window.c (Vwindow_combination_resize)
4386 (Vwindow_combination_limit): Use t instead of non-nil in
4388 (Vrecenter_redisplay): Add first sentence of doc-string on
4390 (Frecenter): Fix doc-string typo.
4392 2011-12-11 Kenichi Handa <handa@m17n.org>
4394 * coding.c (Funencodable_char_position): Pay attention to the
4395 buffer text relocation (Bug#9389).
4397 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4399 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4400 gtk_init (Bug#10100).
4402 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4404 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4405 IT->string is nil. (Bug#10263)
4407 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4409 * nsterm.h (x_free_frame_resources): Declare.
4411 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4412 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4414 * nsterm.h (ns_get_defaults_value): Declare.
4416 * nsterm.m (ns_default): Call ns_get_defaults_value.
4418 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4420 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4423 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4425 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4426 that where the value of an _OBJC_* symbol points to is in the .bss
4427 section (Bug#10240).
4429 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4431 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4432 after the loop to call ccl_driver at least once (Bug#8619).
4434 2011-12-08 Kenichi Handa <handa@m17n.org>
4436 * ftfont.c (get_adstyle_property): Fix previous change
4439 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4441 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4442 dirs from the default value of EMACSLOADPATH (bug#10208).
4444 2011-12-07 Glenn Morris <rgm@gnu.org>
4446 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4447 installation and source directories as well. (Bug#10208)
4449 2011-12-06 Chong Yidong <cyd@gnu.org>
4451 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4453 2011-12-06 Glenn Morris <rgm@gnu.org>
4455 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4456 as an error, not just -1. (Bug#10217)
4458 2011-12-05 Chong Yidong <cyd@gnu.org>
4460 * keyboard.c (process_special_events): New function.
4461 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4463 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4465 * coding.c (encode_designation_at_bol): Don't use uninitialized
4466 local variable (Bug#9318).
4468 2011-12-05 Kenichi Handa <handa@m17n.org>
4470 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4471 return Qnil (Bug#8046, Bug#10193).
4473 2011-12-05 Kenichi Handa <handa@m17n.org>
4475 * coding.c (encode_designation_at_bol): New args charbuf_end and
4476 dst. Return the number of produced bytes. Callers changed.
4477 (coding_set_source): Return how many bytes coding->source was
4479 (coding_set_destination): Return how many bytes
4480 coding->destination was relocated.
4481 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4482 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4484 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4486 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4487 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4490 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4492 The following changes are to fix Bug#9318.
4494 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4495 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4496 (encode_coding_iso_2022, encode_coding_sjis)
4497 (encode_coding_big5, encode_coding_charset): Use the above macros.
4499 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4501 * lisp.h (process_quit_flag): Fix external declaration.
4503 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4505 Don't macro-inline non-performance-critical code.
4506 * eval.c (process_quit_flag): New function.
4507 * lisp.h (QUIT): Use it.
4509 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4511 * nsfns.m (get_geometry_from_preferences): New function.
4512 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4514 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4516 * emacs.c (Qkill_emacs): Define.
4517 (syms_of_emacs): Initialize it.
4518 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4519 Qquit_flag to `kill-emacs' instead.
4520 (quit_throw_to_read_char): Add parameter `from_signal'.
4521 All callers changed. Call Fkill_emacs if requested and safe.
4522 * lisp.h (QUIT): Call Fkill_emacs if requested.
4524 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4526 * widget.c (update_wm_hints): Return if wmshell is null.
4527 (widget_update_wm_size_hints): New function.
4529 * widget.h (widget_update_wm_size_hints): Declare.
4531 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4532 widget_update_wm_size_hints (Bug#10104).
4534 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4536 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4537 before a newline, prepare the bidi iterator for consuming the
4538 newline, and keep the current paragraph direction. (Bug#10183)
4539 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4541 2011-12-02 Juri Linkov <juri@jurta.org>
4543 * search.c (Fword_search_regexp): New Lisp function created from
4544 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4545 (Fword_search_backward, Fword_search_forward)
4546 (Fword_search_backward_lax, Fword_search_forward_lax):
4547 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4548 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4550 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4552 * fileio.c (Finsert_file_contents): Move after-change-function call
4553 to before the "handled:" label, since all "goto handled" appear in
4554 cases where the *-change-functions have already been properly called
4557 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4559 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4560 waiting for input. (Bug#10169)
4562 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4564 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4565 verifies glyph row's hash code--we have just reallocated the
4566 glyphs, so their contents can be complete garbage. (Bug#10164)
4568 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4570 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4572 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4574 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4575 attributes are tested _before_ calling verify_row_hash, to protect
4576 against GCC re-ordering of the tests. (Bug#10164)
4578 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4580 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4582 * xterm.c (handle_one_xevent): Only set async_visible and friends
4583 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4584 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4585 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4587 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4589 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4590 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4591 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4592 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4593 All uses changed to use GCPRO1 etc.
4594 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4595 Revert to old implementation (i.e., before 2011-03-11).
4597 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4599 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4600 of scroll runs so as to avoid assigning disabled bogus rows and
4601 unnecessary graphics copy operations.
4603 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4605 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4606 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4607 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4608 (malloc, free, realloc, calloc): Redirect to e_* only when
4611 * lisp.h (GCTYPEBITS): Move before first use.
4612 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4613 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4614 this macro definition.
4616 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4619 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4621 * gtkutil.c (xg_create_frame_widgets):
4622 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4623 present with Gtk+ 2.0.
4625 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4627 * fileio.c (Finsert_file_contents): Undo previous change; see
4628 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4630 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4632 Rename locals to avoid shadowing.
4633 * fileio.c (Finsert_file_contents):
4634 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4635 * process.c (wait_reading_process_output):
4636 Rename inner 'proc' to 'p' to avoid shadowing.
4637 Indent for consistency with usual Emacs style.
4639 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4641 * xdisp.c (redisplay_window): If cursor row is not fully visible
4642 after recentering, and scroll-conservatively is set to a large
4643 number, scroll window by a few more lines to make the cursor fully
4644 visible and out of scroll-margin. (Bug#10105)
4645 (start_display): Don't move to the next line if the display should
4646 start at a newline that is part of a display vector or an overlay
4649 2011-11-24 Juri Linkov <juri@jurta.org>
4651 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4652 after the `MagickPingImage' call. (Bug#10112)
4654 2011-11-23 Chong Yidong <cyd@gnu.org>
4656 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4658 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4660 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4661 making another buffer current. (Bug#10114)
4663 2011-11-23 Glenn Morris <rgm@gnu.org>
4665 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4667 2011-11-23 Chong Yidong <cyd@gnu.org>
4669 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4670 using it (Bug#5984).
4672 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4674 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4675 and header-lines, as they don't have one computed for them.
4678 * .gdbinit (prow): Make displayed values more self-explaining.
4679 Add row's hash code.
4681 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4683 * process.c (wait_reading_process_output): Fix asynchrounous
4684 GnuTLS socket handling on some versions of the GnuTLS library.
4685 (wait_reading_process_output): Add comment and URL.
4687 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4689 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4691 2011-11-21 Chong Yidong <cyd@gnu.org>
4693 * window.c (Fnext_window, Fprevious_window): Doc fix.
4695 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4697 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4699 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4701 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4703 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4705 * window.c (Fset_window_combination_limit): Rename argument
4707 (Vwindow_combination_limit): Remove "status" from doc-string.
4709 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4711 * m/ibms390.h: Remove.
4712 * m/ibms390x.h: Don't include "ibms390.h".
4714 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4716 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4717 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4719 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4721 * casetab.c (Fset_case_table):
4722 * charset.c (Fcharset_after): Fix typos.
4724 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4726 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4727 Otherwise, valgrind does not work on some platforms.
4728 Problem reported by Andreas Schwab in
4729 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4730 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4731 is set, removing the need for VIRT_ADDRESS_VARIES.
4732 (PURE_P): Use a more-efficient implementation that needs just one
4733 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4734 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4735 to 4 (xorl, subq, cmpq, setbe).
4736 * alloc.c (pure): Always extern now, since that's the
4737 VIRT_ADDR_VARIES behavior.
4738 (PURE_POINTER_P): Use a single comparison, not two, for
4739 consistency with the new puresize.h.
4740 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4741 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4742 Remove VIRT_ADDR_VARIES no longer needed.
4744 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4746 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4747 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4748 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4749 behave as if the cursor position were at the window margin.
4751 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4752 and the cursor position is out of bounds, behave as if the cursor
4753 position were at the window margin. (Bug#10075)
4755 2011-11-18 Chong Yidong <cyd@gnu.org>
4757 * window.c (Fwindow_combination_limit): Make first argument
4758 non-optional, since it is meaningless for live windows like the
4761 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4763 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4765 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4767 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4768 (graft_intervals_into_buffer): Simplify.
4770 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4772 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4773 hash values of the two rows.
4774 (copy_row_except_pointers): Preserve the used[] arrays and the
4775 hash values of the two rows. (Bug#10035)
4776 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4778 * xdisp.c (row_hash): New function, body extracted from
4779 compute_line_metrics.
4780 (compute_line_metrics): Call row_hash, instead of computing the
4783 * dispnew.c (verify_row_hash): Call row_hash for computing the
4784 hash code of a row, instead of duplicating code from xdisp.c.
4786 * dispextern.h (row_hash): Add prototype.
4788 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4790 * frame.c (delete_frame): Don't delete the terminal when the last
4791 X frame is closed if emacs is built with GTK toolkit.
4793 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4795 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4797 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4799 * window.c (Vwindow_splits): Rename to
4800 Vwindow_combination_resize. Suggested by Juri Linkov.
4801 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4804 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4806 * nsfns.m (Fns_font_name):
4807 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4809 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4811 * window.h (window): Rename slot "nest" to "combination_limit".
4812 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4813 (Fset_window_nest): Rename to Fset_window_combination_limit.
4814 (Vwindow_nest): Rename to Vwindow_combination_limit.
4815 (recombine_windows, make_parent_window, make_window)
4816 (Fsplit_window_internal, saved_window)
4817 (Fset_window_configuration, save_window_save): Rename all
4818 occurrences of window_nest to window_combination_limit.
4820 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4822 * image.c (imagemagick_load_image): Fix typo.
4824 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4826 * xdisp.c (display_line): Move the call to
4827 highlight_trailing_whitespace before the call to
4828 compute_line_metrics, since the latter needs to see the final
4829 faces of all the glyphs to compute ROW's hash value.
4830 Fixes assertion violations in row_equal_p. (Bug#10035)
4832 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4834 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4835 just return (bug#10044).
4837 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4839 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4840 with user-defined heap size. Bump the default size of the temacs
4841 heap to 27MB, to avoid memory warning when running temacs.
4842 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4844 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4845 current_matrix and desired_matrix. (Bug#9990)
4846 (verify_row_hash) [XASSERTS]: New function.
4847 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4848 that the hash value of glyph rows is correct.
4850 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4852 * window.h (window): Remove splits slot.
4853 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4854 (Fdelete_other_windows_internal, make_parent_window)
4855 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4856 (Fset_window_configuration, save_window_save): Don't deal with
4857 split status of windows.
4858 (saved_window): Remove splits slot.
4859 (Vwindow_splits): Rewrite doc-string.
4861 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4863 * xfns.c (unwind_create_frame):
4864 * nsfns.m (unwind_create_frame):
4865 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4866 Vframe_list (Bug#9999).
4868 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4870 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4872 2011-11-11 Kenichi Handa <handa@m17n.org>
4874 * callproc.c (Fcall_process): Set the member dst_multibyte of
4877 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4879 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4880 avoid a crash (bug#9496).
4882 2011-11-09 Chong Yidong <cyd@gnu.org>
4884 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4885 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4887 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4889 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4891 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4893 Avoid some portability problems by eschewing 'extern inline' functions.
4894 The trivial performance wins aren't worth the portability hassles; see
4895 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4897 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4898 (window_box_width, window_box_left, window_box_left_offset)
4899 (window_box_right, window_box_right_offset): Undo previous change,
4900 by removing the "extern"s.
4901 * intervals.c (adjust_intervals_for_insertion)
4902 (adjust_intervals_for_deletion): Undo previous change,
4903 making these static again.
4904 (offset_intervals, temp_set_point_both, temp_set_point)
4905 (copy_intervals_to_string): No longer inline.
4906 * xdisp.c (window_text_bottom_y, window_box_width)
4907 (window_box_height, window_box_left_offset)
4908 (window_box_right_offset, window_box_left, window_box_right)
4909 (window_box): No longer inline.
4911 2011-11-08 Chong Yidong <cyd@gnu.org>
4913 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4914 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4915 Signal an error if not a live window.
4916 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4917 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4919 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4921 * lisp.h (syms_of_abbrev): Remove declaration.
4922 Reported by CHENG Gao <chenggao@royau.me>.
4924 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4926 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4927 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4928 of temacs in GUI mode.
4930 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4932 * window.h: Declare delete_all_child_windows instead of
4933 delete_all_subwindows.
4934 * window.c (Fwindow_nest, Fset_window_nest)
4935 (Fset_window_new_total, Fset_window_new_normal)
4936 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4937 (delete_all_subwindows): Rename to delete_all_child_windows.
4938 (Fdelete_other_windows_internal, Fset_window_configuration):
4939 Call delete_all_child_windows instead of delete_all_subwindows.
4940 * frame.c (delete_frame): Call delete_all_child_windows instead
4941 of delete_all_subwindows.
4943 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4945 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4946 This is also needed for porting to any host where GC_MARK_STACK is
4947 not GC_MAKE_GCPROS_NOOPS.
4948 (which_symbols): Use it.
4950 2011-11-07 Kenichi Handa <handa@m17n.org>
4952 * coding.c (coding_set_destination): Check coding->src_pos only
4953 when coding->src_object is a buffer (bug#9910).
4955 * process.c (send_process): Set the member src_multibyte of coding
4956 to 0 (bug#9911) when sending a unibyte text.
4958 * callproc.c (Fcall_process): Set the member src_multibyte of
4959 process_coding to 0 (bug#9912).
4961 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4963 * xmenu.c (cleanup_widget_value_tree): New function.
4964 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4965 calling free_menubar_widget_value_tree directly (Bug#9830).
4967 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4969 Fix some portability problems with 'inline'.
4970 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4971 (window_box_width, window_box_left, window_box_left_offset)
4972 (window_box_right, window_box_right_offset): Declare extern.
4973 Otherwise, these inline functions do not conform to C99 and
4974 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4975 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4976 * intervals.c (adjust_intervals_for_insertion)
4977 (adjust_intervals_for_deletion): Now extern, because otherwise the
4978 extern inline functions 'offset_intervals' couldn't refer to it.
4979 (static_offset_intervals): Remove.
4980 (offset_intervals): Rewrite using the old contents of
4981 static_offset_intervals. The old version didn't conform to C99
4982 because an extern inline function contained a reference to an
4983 identifier with static linkage.
4985 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4987 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4990 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4992 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4993 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4994 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4995 return Qleft_to_right.
4997 2011-11-06 Chong Yidong <cyd@gnu.org>
4999 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5000 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5001 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5002 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5003 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5004 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5005 (Fwindow_vscroll): Doc fix.
5006 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5007 argument, since it makes no sense to pass a live window and for
5008 consistency with window-child.
5010 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5012 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5015 2011-11-05 Jason Rumney <jasonr@gnu.org>
5017 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5018 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5020 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5021 bitwise arithmetic preventing use of unicode-sip and non-truetype
5024 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5026 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5029 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5030 initialization code to keep similarity to xfns.c after changes
5033 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5035 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5036 (unwind_create_frame): New function (Bug#9943).
5037 (Fx_create_frame): Restructure code to be more similar to the one in
5038 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5039 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5040 Move terminal->reference_count++ just before making the frame official
5043 * nsterm.m (x_free_frame_resources): New function.
5044 (x_destroy_window): Move code to x_free_frame_resources.
5046 * xfns.c (unwind_create_frame): Fix comment.
5047 (Fx_create_frame, x_create_tip_frame):
5048 Move terminal->reference_count++ just before making the frame
5049 official. Move initialization of image_cache_refcount and
5050 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5052 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5054 Support MSVC build with newer versions of Visual Studio.
5055 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5056 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5059 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5060 which are not supported by MSVC.
5061 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5062 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5064 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5066 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5068 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5070 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5072 Support MSVC build with newer versions of Visual Studio.
5073 * w32.c: Don't include w32api.h for MSVC.
5074 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5076 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5077 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5078 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5079 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5081 (alloca) [_MSC_VER]: Define to _alloca.
5083 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5085 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5087 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5089 * xdisp.c (note_mouse_highlight): If either of
5090 previous/next-single-property-change returns nil, treat that as
5091 the beginning or the end of the buffer. (Bug#9955)
5093 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5095 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5096 label is not null (Bug#9951).
5097 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5100 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5102 * window.c (Fwindow_body_size): Mention in the doc string that the
5103 return value is in frame's canonical units. (Bug#9949)
5105 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5107 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5109 * w32fns.c (unwind_create_frame): If needed, free the glyph
5110 matrices of the partially constructed frame. (Bug#9943)
5111 * xfns.c (unwind_create_frame): Likewise.
5113 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5115 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5116 Don't stop backward scan on the continuation glyph, even though
5117 its CHARPOS is positive.
5118 (mouse_face_from_buffer_pos, note_mouse_highlight):
5119 Rename cover_string to disp_string.
5121 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5123 * window.c (temp_output_buffer_show): Don't use
5124 Vtemp_buffer_show_specifiers.
5125 (Vtemp_buffer_show_specifiers): Remove unused variable.
5127 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5129 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5130 past the beginning of the current glyph matrix.
5132 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5134 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5135 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5136 HAVE_GTK3 (Bug#9869).
5138 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5139 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5141 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5143 * xterm.c: Declare x_handle_net_wm_state to return int.
5144 (handle_one_xevent): Check if we are iconified but don't have
5145 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5146 (get_current_wm_state): Return non-zero if not hidden,
5147 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5148 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5149 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5150 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5152 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5154 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5155 so that this new function doesn't get optimized away by a
5156 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5158 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5160 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5162 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5164 Fix the `xbytecode' command.
5165 * .gdbinit (xprintbytestr): New command.
5166 (xwhichsymbols): Rename from `which'; all callers changed.
5167 (xbytecode): Print the byte-code string as well.
5169 2011-10-29 Kim Storm <storm@cua.dk>
5171 * alloc.c (which_symbols): New function.
5173 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5175 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5178 2011-10-29 Glenn Morris <rgm@gnu.org>
5180 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5181 Not clear what it was for, and it causes various bugs. (Bug#9839)
5183 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5185 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5186 possible random value that matches one of those tested as
5187 condition to clear the mouse face.
5189 2011-10-28 Chong Yidong <cyd@gnu.org>
5191 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5193 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5195 * window.c (make_window): Initialize phys_cursor_on_p.
5197 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5199 * lisp.h (struct Lisp_Symbol): Update comments.
5201 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5203 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5205 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5207 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5208 <oslsachem@gmail.com> for helping to debug this.
5210 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5211 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5212 (g_b_init_get_glyph_outline_w): New static variables.
5213 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5214 (GetGlyphOutlineW_Proc): New typedefs.
5215 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5216 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5218 (w32font_open_internal, compute_metrics):
5219 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5220 instead of calling the "wide" APIs directly.
5222 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5224 * w32.h (syms_of_w32font): Add prototype.
5226 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5228 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5229 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5230 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5231 (Fmove_to_window_line): Doc fix.
5233 2011-10-27 Chong Yidong <cyd@gnu.org>
5235 * process.c (make_process): Set gnutls_state to NULL.
5237 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5238 non-NULL, regardless of GNUTLS_INITSTAGE.
5239 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5240 an error. Set process slots as soon as we allocate them.
5242 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5244 2011-10-27 Chong Yidong <cyd@gnu.org>
5246 * gnutls.c (emacs_gnutls_deinit): New function.
5247 Deallocate credentials structures as well as calling gnutls_deinit.
5248 (Fgnutls_deinit, Fgnutls_boot): Use it.
5250 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5251 (deactivate_process): Call emacs_gnutls_deinit.
5253 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5255 * image.c (x_create_x_image_and_pixmap):
5256 * w32.c (sys_rename, w32_delayed_load):
5257 * w32font.c (fill_in_logfont):
5258 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5260 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5262 * w32fns.c (w32_default_color_map): New function,
5263 extracted from Fw32_default_color_map.
5264 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5266 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5268 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5270 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5272 * keyboard.c (test_undefined): New function (bug#9751).
5273 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5275 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5277 * sysdep.c (init_sys_modes): Fix the check for the controlling
5278 terminal (Bug#6649).
5280 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5282 * dispextern.h (struct bidi_it): New member next_en_type.
5284 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5285 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5286 current character, check also for next_en_type being WEAK_EN.
5287 (bidi_resolve_weak): Don't enter the expensive loop if the current
5288 position is before next_en_pos. Record the bidi type of the first
5289 non-ET, non-BN character we find, in addition to its position.
5290 (bidi_level_of_next_char): Invalidate next_en_type when
5291 next_en_pos is over-stepped.
5293 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5295 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5296 * editfns.c: Rewrite current-time-zone so that it invokes
5297 the equivalent of (format-time-string "%Z") to get the time zone name.
5298 This fixes a bug when the time zone name contains characters that
5299 need converting from the system time locale to Emacs internal format.
5300 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5301 that patch fixed format-time-string to do the conversion, but
5302 I forgot to fix current-time-zone.
5303 (format_time_string): New function, containing most of
5304 what Fformat_time_string used to contain.
5305 (Fformat_time_string): Rewrite in terms of format_time_string.
5306 This doesn't change this function's behavior.
5307 (current-time-zone): Rewrite to use format_time_string.
5308 This fixes the bug reported by Michael Schierl in
5309 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5310 Jason Rumney's 2007-06-07 change worked around this bug, but
5312 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5314 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5316 * xdisp.c (start_display): If the character at POS is displayed
5317 via a display vector, reset IT->current.dpvec_index to zero.
5318 (try_window_reusing_current_matrix): If a line ends in a display
5319 vector or the next line starts in a display vector, continue
5320 redrawing the window even though the character position of
5321 start_row was reached.
5324 2011-10-18 Chong Yidong <cyd@gnu.org>
5326 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5327 with nobreak-char-display too.
5329 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5331 Fix part 3 of bug#9771.
5332 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5333 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5334 non-neutral characters if the current character is a paragraph
5335 separator (a.k.a. Newline). This avoids running the same
5336 expensive loop twice, once when we consume the preceding newline
5337 and the other time when the line actually needs to be displayed.
5338 Avoid the loop when we see neutrals on the base embedding level
5339 following a character whose directionality is the same as the
5340 paragraph's. This avoids running the expensive loop when a line
5341 ends in a long sequence of neutrals, like control characters.
5342 Add assertion against STRONG_AL type. Slightly rearrange code
5343 that determines the type of a neutral given the first non-neutral
5345 (bidi_level_of_next_char): Set next_en_pos to zero when
5346 invalidating its info.
5348 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5350 * xdisp.c (push_display_prop): Determine whether to record string
5351 or buffer position by IT->string, not by IT->method. Allow
5352 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5353 (move_it_vertically_backward): Don't look for character position
5354 immediately after the newline when in a continuation line.
5357 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5359 * window.c (coordinates_in_window): Rewrite and delabelize
5360 vertical border check. (Bug#5357) (Bug#9618)
5362 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5364 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5365 errors in XSetWindowBorder (bug#9310).
5367 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5369 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5370 avoid crash when xmalloc overrun checking is enabled.
5372 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5374 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5375 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5376 cursor motion with <left> and <right> arrow keys.
5378 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5379 some callers set that themselves.
5381 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5383 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5384 display string and the previous row comes from the same string and
5385 is empty. (Bug#9739) (Bug#9738)
5387 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5389 * doc.c (get_doc_string): Encode file name (bug#9735).
5391 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5393 * bidi.c (bidi_level_of_next_char):
5394 * xdisp.c (get_visually_first_element): Remove old incorrect
5395 comments regarding the Unicode Line Separator character.
5397 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5399 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5401 * alloc.c (Fgc_status): Do not access beyond zombies array
5402 boundary if nzombies > MAX_ZOMBIES.
5403 * alloc.c (dump_zombies): Add missing format specifier.
5405 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5407 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5408 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5410 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5411 Some packages use them to denote characters with modifiers.
5413 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5415 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5416 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5417 matching a pp-number. Rename parameter var to var1.
5419 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5421 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5423 2011-10-08 Glenn Morris <rgm@gnu.org>
5425 * callint.c (Fcall_interactively): Give a more explicit error for the
5426 'c' case with a non-character input. (Bug#8479)
5428 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5430 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5432 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5433 lines that are hscrolled on the left.
5435 * dispnew.c (buffer_posn_from_coords): Account for a possible
5436 presence of header-line. (Bug#4426)
5438 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5440 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5441 Don't advertise functionality which we discourage or doesn't work.
5443 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5445 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5446 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5447 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5448 this makes Emacs dump core during garbage collection on rare
5449 occasions. sizeof is obviously inferior to offsetof here, so
5450 stick with offsetof.
5451 (GC_POINTER_ALIGNMENT): New macro.
5452 (mark_memory): Omit 3rd (offset) arg; caller changed.
5453 Don't assume EMACS_INT alignment is the same as pointer alignment.
5455 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5457 * keyboard.c (read_key_sequence_remapped): New var.
5458 (read_key_sequence): Compute remapping in the right buffer.
5459 (command_loop_1): Use read_key_sequence's remapping directly.
5461 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5463 * dired.c (file_name_completion): Don't expand file name.
5464 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5465 before checking file name handler.
5467 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5468 they've been requested explicitly (bug#9591).
5470 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5472 * keymap.c (Fsingle_key_description): Use make_specified_string
5473 instead of build_string to build string from push_key_description.
5476 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5478 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5479 This fixes a Y2038 bug on 64-bit hosts.
5480 * buffer.c (reset_buffer):
5481 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5482 (Fclear_buffer_auto_save_failure):
5483 Use 0, not -1, to represent an unset failure time, since time_t
5484 might not be signed.
5486 Remove dependency on glibc malloc internals.
5487 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5488 Move back here from lisp.h, but with their new implementations.
5489 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5490 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5491 * charset.c (charset_table_init): New static var.
5492 (syms_of_charset): Use it instead of xmalloc. This removes a
5493 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5494 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5495 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5496 Move back to alloc.c.
5497 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5498 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5500 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5502 * nsterm.m (windowDidResize): Call x_set_window_size only when
5503 ns_in_resize is true. Otherwise set pixelwidth/height and
5504 call change_frame_size (Bug#9628).
5506 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5508 Port --enable-checking=all to Fedora 14 x86-64.
5509 * charset.c (syms_of_charset): Also account for glibc malloc's
5510 internal overhead when calculating the initial malloc maximum.
5512 Port --enable-checking=all to Fedora 14 x86.
5513 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5515 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5516 (overrun_check_realloc, overrun_check_free):
5517 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5518 That way, xmalloc returns a properly-aligned pointer even if
5519 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5520 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5521 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5522 into account when calculating the initial malloc maximum.
5523 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5524 Move here from alloc.c, so that charset.c can use it too.
5525 Properly align; the old code wasn't right for common 32-bit hosts
5526 when configured with --enable-checking=all.
5527 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5528 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5530 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5532 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5535 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5537 * xdisp.c (compute_display_string_end): If there's no display
5538 string at CHARPOS, return -1.
5540 * bidi.c (bidi_fetch_char): When compute_display_string_end
5541 returns a negative value, treat the character as a normal
5542 character not covered by a display string. (Bug#9624)
5544 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5546 * lread.c (Fread_from_string): Fix typo in docstring.
5548 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5550 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5551 newline, reseat the iterator instead of bidi-iterating there one
5552 character at a time. (Bug#9610)
5553 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5554 TO_CHARPOS if the bidi iterator is at base embedding level.
5556 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5558 * lread.c (readevalloop): Use correct code for NBSP.
5559 (read1): Likewise. (Bug#9608)
5561 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5563 * dbusbind.c (Fdbus_register_signal): When service is not
5564 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5566 2011-09-25 Glenn Morris <rgm@gnu.org>
5568 * buffer.c (truncate-lines): Doc fix.
5570 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5572 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5573 (Fset_window_next_buffers): Doc fix.
5575 2011-09-24 Glenn Morris <rgm@gnu.org>
5577 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5579 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5581 Fix minor problems found by static checking.
5582 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5583 * indent.c (Fvertical_motion): Fix == vs = typo.
5585 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5587 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5588 Default value is now t. Doc fix.
5590 * indent.c (Fvertical_motion): Compute and apply the overshoot
5591 logic when moving up, not only when moving down. Fix the
5592 confusing name and values of the it_overshoot_expected variable;
5593 logic changes accordingly. (Bug#9254) (Bug#9549)
5595 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5596 CHARPOS is covered by a display string which includes newlines.
5597 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5598 is covered by a display string with embedded newlines.
5600 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5602 * dbusbind.c (Fdbus_register_signal): Add match rule to
5603 Vdbus_registered_objects_table. (Bug#9581)
5604 (Fdbus_register_method, Vdbus_registered_objects_table):
5607 2011-09-24 Jim Meyering <meyering@redhat.com>
5609 do not ignore write error for any output size
5610 The previous change was incomplete.
5611 While it makes emacs --batch detect the vast majority of stdout
5612 write failures, errors were still ignored whenever the output size is
5613 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5614 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5615 && echo FAIL: ignored write error
5616 FAIL: ignored write error
5617 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5618 && echo FAIL: ignored write error
5619 FAIL: ignored write error
5620 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5622 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5624 * emacs.c (Fkill_emacs): In noninteractive mode exit
5625 non-successfully if a write error occurred on stdout. (Bug#9574)
5627 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5629 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5632 * dispextern.h (struct it): Update the comment documenting what
5635 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5637 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5638 a display string, extend search for cursor position to end of row.
5639 (find_row_edges): If the row ends in a newline from a display
5640 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5641 Handle the case of a display string with multiple newlines.
5642 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5643 non-empty line. Fixes confusing cursor motion with arrow keys at
5644 the beginning of a line that starts with whitespace.
5646 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5648 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5651 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5653 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5656 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5658 * xdisp.c (display_line): Record maximum and minimum buffer
5659 positions even if no glyphs were produced (e.g., by a zero-width
5660 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5661 buffer positions that will be removed from the glyph row because
5663 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5664 column is beyond frame width: don't subtract 1 "pixel" when
5665 computing width of the stretch.
5666 (reseat_at_next_visible_line_start): Undo the change made on
5667 2011-09-17 that saved paragraph information and restored it after
5668 the call to `reseat'. (Bug#9545)
5670 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5672 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5673 and turn window cursor on if cleared (Bug#9415).
5675 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5677 * search.c (boyer_moore): Take unibyte characters from pattern
5678 literally. (Bug#9458)
5680 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5682 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5684 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5686 Fix minor problem found by static checking.
5687 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5688 initialized, to pacify gcc -Wuninitialized.
5690 * fileio.c: Report proper errno when syscall falls.
5691 (Finsert_file_contents): Save and restore errno,
5692 so that report_file_error outputs the correct diagnostic.
5693 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5695 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5697 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5699 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5701 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5702 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5704 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5706 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5707 about the current paragraph and restore it after the call to reseat.
5709 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5710 (bidi_find_paragraph_start): Search back for paragraph beginning
5711 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5712 (bidi_move_to_visually_next): Only trigger paragraph-related
5713 computations when the last character is a newline or at EOB, not
5714 just any NEUTRAL_B. (Bug#9470)
5716 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5717 truncated lines if point is covered by a display string. (Bug#9524)
5719 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5721 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5722 (cons_to_x_long): New function.
5723 (lisp_data_to_selection_data): Use it. Correct the test for
5724 short-versus-long data; it was negated. Break out of vector
5725 loop, for efficiency, when a long datum is discovered.
5727 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5729 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5731 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5733 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5734 GCC PR/17406) by declaring this function with external scope.
5736 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5738 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5739 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5741 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5743 * editfns.c (Fformat): Correctly handle text properties on "%%".
5745 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5747 * xterm.c (x_draw_composite_glyph_string_foreground):
5748 * w32term.c (x_draw_composite_glyph_string_foreground):
5749 * term.c (encode_terminal_code):
5750 * composite.c (composition_update_it, get_composition_id):
5751 * xdisp.c (get_next_display_element)
5752 (fill_composite_glyph_string): Add comments about special meaning
5753 of TAB characters in a composition.
5755 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5757 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5758 This occurs when processing a multibyte format.
5759 Problem reported by Wolfgang Jenker.
5761 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5763 * xdisp.c (try_cursor_movement): Only check for exact match if
5764 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5766 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5768 Remove unused external symbols.
5769 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5770 * xdisp.c (calc_pixel_width_or_height): Now static.
5771 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5772 * indent.c (check_display_width):
5773 * w32term.c: Fix comment to match code.
5774 * xterm.c, xterm.h (x_catching_errors): Remove.
5776 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5778 * xselect.c: Use signed conversions more consistently (Bug#9498).
5779 (selection_data_to_lisp_data): Assume incoming selection data are
5780 signed integers, not unsigned. This is to be consistent with
5781 outgoing selection data, which was modified to use signed integers
5782 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5783 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5784 expects long, not unsigned long.
5786 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5788 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5789 computation of loop end. Reported by Johan Bockgård
5792 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5794 * frame.c (Fother_visible_frames_p): Function deleted.
5796 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5798 * indent.c (compute_motion): Process display vector front to back
5799 rather than the other way around. (Bug#2496)
5801 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5803 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5805 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5807 * minibuf.c (Fread_from_minibuffer): Doc fix.
5809 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5811 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5812 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5814 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5816 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5817 value for non-existent files.
5819 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5821 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5822 set its "size" to -1. This will set the modtime_size field of
5823 the corresponding buffer to -1, which is what
5824 verify-visited-file-modtime expects for files that do not exist.
5827 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5829 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5831 * lisp.h: ... from here. push_key_description is no longer
5832 defined in keyboard.c, so its declaration should not be in
5833 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5834 logically belongs with push_key_description.
5836 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5838 * buffer.h: Include <sys/types.h> instead of <time.h>.
5839 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5840 Problem reported by Herbert J. Skuhra.
5842 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5844 * xml.c (parse_region): Make the parsing work for
5845 non-comment-starting XML files again (bug#9144).
5847 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5849 * image.c (gif_load): Fix calculation of bottom and right corner.
5852 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5854 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5855 redisplay in small windows.
5857 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5859 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5861 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5863 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5864 Operate on live windows only.
5866 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5868 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5870 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5872 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5873 only under bidi iteration.
5875 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5877 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5879 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5881 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5882 Without this fix, the command to link temacs failed due to an
5883 undefined symbol __builtin_isnan. This is because
5884 /usr/include/iso/math_c99.h #defines isnan(x) to
5885 __builtin_isnan(x), but the bundled gcc, which identifies itself
5886 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5888 * floatfns.c (isnan): #undef, and then #define to a clone of
5890 (Fisnan): Always define, since it's always available now.
5891 (syms_of_floatfns): Always define isnan at the Lisp level.
5893 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5895 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5897 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5899 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5900 The previous code assumed that file offsets (off_t values) fit in
5901 EMACS_INT variables, which is not true on typical 32-bit hosts.
5902 The code messed up by falsely reporting buffer overflow in cases
5903 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5904 when "big" contains more than 2**29 bytes, even though this
5905 inserts just one byte and does not overflow the buffer.
5906 (Finsert_file_contents): Store file offsets as off_t
5907 values, not as EMACS_INT values. Check for overflow when
5908 converting between EMACS_INT and off_t. When checking for
5909 buffer overflow or for overlap, take the offsets into account.
5910 Don't use EMACS_INT for small values where int suffices.
5911 When checking for overlap, fix a typo: ZV was used where
5912 ZV_BYTE was intended.
5913 (Fwrite_region): Don't assume off_t fits into 'long'.
5914 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5916 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5918 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5920 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5922 sprintf-related integer and memory overflow issues (Bug#9412).
5924 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5925 (esprintf, exprintf, evxprintf): New functions.
5926 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5927 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5928 (modify_event_symbol): Do not assume that the length of
5929 name_alist_or_stem is safe to alloca and fits in int.
5930 (Fexecute_extended_command): Likewise for function name and binding.
5931 (Frecursion_depth): Wrap around reliably on integer overflow.
5932 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5933 since some callers pass EMACS_INT values.
5934 (Fsingle_key_description): Don't crash if symbol name contains more
5935 than MAX_ALLOCA bytes.
5936 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5937 (get_minibuffer): Arg is now EMACS_INT, not int.
5938 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5939 (esprintf, exprintf, evxprintf): New decls.
5940 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5942 * dbusbind.c (signature_cat): New function.
5943 (xd_signature, Fdbus_register_signal):
5944 Do not overrun buffer; instead, report string overflow.
5946 * dispnew.c (add_window_display_history): Don't overrun buffer.
5947 Truncate instead; this is OK since it's just a log.
5949 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5950 even if the time zone offset is outlandishly large.
5951 Don't mishandle offset == INT_MIN.
5953 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5954 when creating daemon; the previous buffer-overflow check was incorrect.
5956 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5957 which has the guts of the old verror function.
5959 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5960 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5962 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5963 (font_unparse_xlfd): Don't blindly alloca long strings.
5964 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5965 fits in int, when using sprintf. Use single snprintf to count
5966 length of string rather than counting it via multiple sprintfs;
5967 that's simpler and more reliable.
5968 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5969 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5970 sprintf, in case result does not fit in int.
5972 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5973 (fontset_from_font): Print it.
5975 * frame.c (tty_frame_count): Now printmax_t, not int.
5976 (make_terminal_frame, set_term_frame_name): Print it.
5977 (x_report_frame_params): In X, window IDs are unsigned long,
5978 not signed long, so print them as unsigned.
5979 (validate_x_resource_name): Check for implausibly long names,
5980 and don't assume name length fits in 'int'.
5981 (x_get_resource_string): Don't blindly alloca invocation name;
5982 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5985 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5986 (xg_check_special_colors, xg_set_geometry):
5987 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5989 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5990 Use esprintf, not sprintf, in case result does not fit in int.
5992 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5993 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5994 it as a large positive number.
5995 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5996 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5998 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5999 in case result does not fit in int.
6001 * print.c (float_to_string): Detect width overflow more reliably.
6002 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6003 buffer overrun. Don't assume list length fits in 'int'. Treat
6004 print length of 0 as 0, not as infinity; to be consistent with other
6005 uses of print length in this function. Don't overflow print length
6006 index. Don't assume hash table size fits in 'long', or that
6007 vectorlike size fits in 'unsigned long'.
6009 * process.c (make_process): Use printmax_t, not int, to format
6010 process-name gensyms.
6012 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6014 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6015 to avoid potential buffer overrun.
6017 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6018 if X resource line is longer than 512 bytes.
6020 * xfns.c (x_window): Make sprintf buffer a bit bigger
6021 to avoid potential buffer overrun.
6023 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6025 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6027 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6029 Integer overflow fixes for scrolling, etc.
6030 Without these, Emacs silently mishandles large integers sometimes.
6031 For example, "C-u 4294967297 M-x recenter" was treated as if
6032 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6034 * xdisp.c (try_window_id): Check Emacs fixnum range before
6035 converting to 'int'.
6037 * window.c (window_scroll_line_based, Frecenter):
6038 Check that an Emacs fixnum is in range before assigning it to 'int'.
6039 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6040 values converted from Emacs fixnums.
6041 (Frecenter): Don't wrap around a line count if it is out of 'int'
6042 range; instead, treat it as an extreme value.
6043 (Fset_window_configuration, compare_window_configurations):
6044 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6046 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6047 that can exceed INT_MAX. Check that EMACS_INT value is in range
6048 before assigning it to the (possibly-narrower) index.
6049 (match_limit): Don't assume that a fixnum can fit in 'int'.
6051 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6054 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6055 (Fvertical_motion): Don't wrap around LINES values that don't fit
6056 in 'int'. Instead, treat them as extreme values. This is good
6057 enough for windows, which can't have more than INT_MAX lines anyway.
6059 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6061 * Require libxml/parser.h to avoid compilation warning.
6063 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6065 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6066 since this reportedly can destroy thread storage.
6068 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6070 * syntax.c (find_defun_start): Update all cache variables if
6071 exiting early (Bug#9401).
6073 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6075 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6077 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6078 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6079 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6081 * term.c (tty_append_glyph): New function.
6082 (produce_stretch_glyph): Static function and its prototype deleted.
6084 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6087 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6089 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6090 when checking :margin (Bug#9390).
6091 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6092 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6093 so that the name doesn't mislead. All uses changed.
6095 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6097 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6100 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6102 * xdisp.c (move_it_to): Don't bail out early when reaching
6103 position beyond to_charpos, if we are scanning backwards.
6104 (move_it_vertically_backward): When DY == 0, make sure we get to
6105 the first character in the line after the newline.
6107 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6109 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6110 (ccl_driver): Do not generate an out-of-range pointer.
6111 (Fccl_execute_on_string): Remove unnecessary check for
6112 integer overflow, noted by Stefan Monnier in
6113 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6114 Remove a FIXME that didn't need fixing.
6115 Simplify the newly-introduced buffer reallocation code.
6117 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6119 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6121 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6123 Integer and memory overflow issues (Bug#9196).
6125 * doc.c (get_doc_string): Rework so that
6126 get_doc_string_buffer_size is the actual buffer size, rather than
6127 being 1 less than the actual buffer size; this makes xpalloc more
6130 * image.c (x_allocate_bitmap_record, cache_image):
6131 * xselect.c (Fx_register_dnd_atom):
6132 Simplify previous changes by using xpalloc.
6134 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6135 since either will do and ptrdiff_t is convenient with xpalloc.
6137 * charset.c (charset_table_size)
6138 (struct charset_sort_data.priority): Now ptrdiff_t.
6139 (charset_compare): Don't overflow if priorities differ greatly.
6140 (Fsort_charsets): Don't assume list length fits in int.
6141 Check for size-calculation overflow when allocating sort data.
6142 (syms_of_charset): Allocate an initial charset table that is
6143 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6145 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6147 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6148 The actual value is always <= INT_MAX, and leaving it unsigned made
6149 overflow checking harder.
6151 * dispextern.h (struct glyph_matrix.rows_allocated)
6152 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6153 with xpalloc. The values are still always <= INT_MAX.
6155 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6157 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6158 (SAFE_NALLOCA): New macro.
6160 * region-cache.c (struct boundary.pos, find_cache_boundary)
6161 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6162 (set_cache_region, invalidate_region_cache)
6163 (revalidate_region_cache, know_region_cache, region_cache_forward)
6164 (region_cache_backward, pp_cache):
6165 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6166 so that ptrdiff_t * can be passed to xpalloc.
6167 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6168 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6169 (pp_cache): Don't assume cache_len fits in int.
6170 * region-cache.h: Adjust extern decls to match.
6172 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6173 EMACS_INT, since either will do, for xpalloc.
6175 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6176 (xnmalloc, xnrealloc, xpalloc): New functions.
6178 * bidi.c (bidi_shelve_header_size): New constant.
6179 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6180 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6182 * bidi.c (bidi_cache_shrink):
6183 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6185 Don't update size of array until after memory allocation succeeds,
6186 because xmalloc/xrealloc may not return.
6187 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6188 now that we have proper integer overflow checking.
6189 (record_overlay_string, overlay_strings): Catch overflows when
6190 calculating size of overlay_str_buf.
6192 * callproc.c (Fcall_process): Check for size overflow when
6193 calculating size of args2.
6194 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6195 Normally we prefer signed values, but sticking with ptrdiff_t would
6196 require adding more-complicated checks.
6198 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6199 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6200 Redo buffer-overflow calculations to avoid integer overflow.
6201 Add a FIXME comment where memory seems to be over-allocated.
6203 * character.c (Fstring): Check for size-calculation overflow.
6205 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6206 unnecessary integer overflow. Check for size overflow.
6207 (encode_coding_object): Don't update size until xmalloc succeeds.
6209 * composite.c (get_composition_id): Check for overflow in glyph
6210 length calculations.
6212 Integer and memory overflow fixes for display code.
6213 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6214 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6215 (scrolling_window): Check for overflow in size calculations.
6216 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6217 Don't assume glyph table len fits in int.
6218 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6219 (row_table_size): Now ptrdiff_t, not int.
6220 (scrolling_window): Avoid overflow in size calculations.
6221 Don't update size until allocation succeeds.
6222 * fns.c (concat): Check for overflow in size calculations.
6223 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6224 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6225 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6227 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6228 (get_doc_string): Check for size calculation overflow.
6229 Don't update size until allocation succeeds.
6230 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6231 EMACS_INT, where ptrdiff_t will do.
6232 (Fsubstitute_command_keys): Check for string overflow.
6234 * editfns.c (set_time_zone_rule): Don't assume environment length
6236 (message_length): Now ptrdiff_t, not int.
6237 (Fmessage_box): Don't update size until allocation succeeds.
6238 Don't assume message length fits in int.
6239 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6241 * emacs.c (main): Do not reallocate argv, since there is a null at
6242 the end that can be overwritten, and this way there's no need to
6243 worry about size-calculation overflow.
6244 (sort_args): Check for size-calculation overflow.
6246 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6248 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6250 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6251 (x_set_scroll_bar_width, x_figure_window_size):
6252 Check for integer overflow.
6253 (x_set_alpha): Do not assume XINT fits in int.
6255 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6256 This is for the members text_lines, text_cols, total_lines, total_cols,
6257 where the system imposes an 'int' limit.
6259 * fringe.c (Fdefine_fringe_bitmap):
6260 Don't update size until alloc works.
6262 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6263 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6265 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6266 Check for size-calculation overflow.
6267 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6268 do, as we prefer signed integers.
6269 (id_to_widget.max_size, id_to_widget.used)
6270 (xg_store_widget_in_map, xg_remove_widget_from_map)
6271 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6272 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6273 Use and return ptrdiff_t, not int.
6274 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6275 * gtkutil.h: Change prototypes to match the above.
6277 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6278 are duplicate now that they've been promoted to lisp.h.
6279 (x_allocate_bitmap_record, x_alloc_image_color)
6280 (make_image_cache, cache_image, xpm_load):
6281 Don't update size until alloc is done.
6282 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6284 Check for size calculation overflow.
6285 (ct_colors_allocated_max): New constant.
6286 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6289 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6290 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6291 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6292 Use ptrdiff_t, not int, to count maps.
6293 (read_char_minibuf_menu_prompt): Check for overflow in size
6294 calculations. Don't update size until allocation succeeds.
6295 Redo calculations to avoid overflow.
6296 * keyboard.h: Change prototypes to match the above.
6298 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6300 (current_minor_maps): Check for size calculation overflow.
6301 * keymap.h: Change prototypes to match the above.
6303 * lread.c (read1, init_obarray): Don't update size until alloc done.
6305 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6306 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6308 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6309 Now ptrdiff_t, not int.
6310 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6311 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6313 * process.c (Fnetwork_interface_list): Check for overflow
6314 in size calculation.
6316 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6318 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6319 overflow. Don't bother calling xmalloc when xrealloc will do.
6321 * search.c (Freplace_match): Check for size calculation overflow.
6322 (Fset_match_data): Don't assume list lengths fit in 'int'.
6324 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6325 for command line length. Do not attempt to address one before the
6326 beginning of an array, as that's not portable.
6328 * term.c (max_frame_lines): Remove; unused.
6329 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6331 (encode_terminal_code, calculate_costs): Check for size
6332 calculation overflow.
6333 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6334 table lengths and related sizes. Don't update size until alloc
6335 done. Redo calculations to avoid overflow.
6336 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6338 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6339 subtracting pointers.
6340 (gobble_line): Check for overflow more carefully. Don't update size
6343 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6344 Don't update size until alloc done.
6345 Redo size calculations to avoid overflow.
6346 Check for size calculation overflow.
6347 (main) [DEBUG]: Fix typo in invoking tparam1.
6349 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6350 Use ptrdiff_t, not int, for sizes.
6351 (store_mode_line_noprop_char): Don't update size until alloc done.
6353 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6354 Use ptrdiff_t, not int, for sizes.
6355 (Finternal_make_lisp_face, cache_face):
6356 Check for size calculation overflow.
6357 (cache_face): Treat size calculation overflows as if they were
6358 memory exhaustion (the usual treatment), rather than aborting.
6360 * xfns.c (x_encode_text, x_set_name_internal)
6361 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6362 sizes, since they can exceed INT_MAX in size. Check for size
6363 calculation overflow.
6365 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6366 (xg_select): Check for size calculation overflow.
6367 Don't update size until alloc done.
6369 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6370 as sprintf is limited to int lengths.
6372 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6373 (X_LONG_MIN): New macros.
6374 Use them to make the following changes clearer.
6375 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6376 This change doesn't affect the value now, but it may help remind
6377 future maintainers not to raise the value too much later.
6378 (SELECTION_QUANTUM): Remove, replacing with ...
6379 (selection_quantum): ... new function, which avoids overflow.
6381 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6382 assumption that selection length fits in 'int'.
6383 (x_reply_selection_request, x_handle_selection_request)
6384 (x_get_window_property, receive_incremental_selection)
6385 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6386 (lisp_data_to_selection_data, clean_local_selection_data):
6387 Use ptrdiff_t, not int, to record length of selection.
6388 (x_reply_selection_request, x_get_window_property)
6389 (receive_incremental_selection, x_property_data_to_lisp):
6390 Redo calculations to avoid overflow.
6391 (x_reply_selection_request): When sending hint, ceiling it at
6392 X_LONG_MAX rather than relying on wraparound overflow to send
6394 (x_get_window_property, receive_incremental_selection)
6395 (lisp_data_to_selection_data, x_property_data_to_lisp):
6396 Check for size-calculation overflow.
6397 (x_get_window_property, receive_incremental_selection)
6398 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6399 Don't store size until memory allocation succeeds.
6400 (x_get_window_property): Plug memory leak on memory exhaustion.
6401 Don't double-block input; malloc is safe here. Don't assume 2**34
6402 - 4 fits in unsigned long. Add an xassert to check
6403 XGetWindowProperty overflow. Be more careful about overflow
6404 calculations, and distinguish size from memory overflow better.
6405 (receive_incremental_selection): When tracing, don't assume
6406 unsigned int is less than INT_MAX.
6407 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6408 harmful) conversions of unsigned short to int.
6409 (lisp_data_to_selection_data): Don't assume that integers
6410 in the range -65535 through -1 fit in an X unsigned short.
6411 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6412 result parameters unless successful. Rely on cons_to_unsigned
6413 to report problems with elements; the old code wasn't right anyway.
6414 (x_check_property_data): Check for int overflow; we cannot use
6415 a wider type due to X limits.
6416 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6418 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6420 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6421 (x_term_init): Check for size calculation overflow.
6422 (x_color_cells): Don't store size until memory allocation succeeds.
6423 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6424 Don't assume alloca size is less than MAX_ALLOCA.
6425 (x_term_init): Don't assume length fits in int (sprintf is limited
6428 Use ptrdiff_t for composition IDs.
6429 * character.c (lisp_string_width):
6430 * composite.c (composition_table_size, n_compositions)
6431 (get_composition_id, composition_gstring_from_id):
6432 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6433 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6434 * window.c (Frecenter):
6435 Use ptrdiff_t, not int, for composition IDs.
6436 * composite.c (get_composition_id): Check for integer overflow.
6437 * composite.h: Adjust prototypes to match the above changes.
6439 Use ptrdiff_t for hash table indexes.
6440 * category.c (hash_get_category_set):
6441 * ccl.c (ccl_driver):
6442 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6443 * coding.c (coding_system_charset_list, detect_coding_system):
6444 * coding.h (struct coding_system.id):
6445 * composite.c (get_composition_id, gstring_lookup_cache):
6446 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6447 * image.c (xpm_get_color_table_h):
6448 * lisp.h (hash_lookup, hash_put):
6449 * minibuf.c (Ftest_completion):
6450 Use ptrdiff_t for hash table indexes, not int (which is too
6451 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6452 32-bit --with-wide-int hosts).
6454 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6455 Add a FIXME comment about memory leaks.
6456 (syms_of_charset): Don't assume xmalloc returns.
6458 Don't assume that stated character widths fit in int.
6459 * character.c (Fchar_width, c_string_width, lisp_string_width):
6460 * character.h (CHAR_WIDTH):
6461 * indent.c (MULTIBYTE_BYTES_WIDTH):
6462 Use sanitize_char_width to avoid undefined and/or bad behavior
6463 with outlandish widths.
6464 * character.h (sanitize_tab_width): Rename from sanitize_width,
6465 now that we have two such functions. All uses changed.
6466 (sanitize_char_width): New inline function.
6468 Don't assume that tab-width fits in int.
6469 * character.h (sanitize_width): New inline function.
6470 (SANE_TAB_WIDTH): New macro.
6471 (ASCII_CHAR_WIDTH): Use it.
6472 * indent.c (sane_tab_width): Remove. All uses replaced by
6473 SANE_TAB_WIDTH (current_buffer).
6474 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6476 * fileio.c: Integer overflow issues with file modes.
6477 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6479 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6480 Remove unreachable code.
6481 (read_hex, load_charset_map_from_file): Check for integer overflow.
6483 * xterm.c: Don't go over XClientMessageEvent limit.
6484 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6485 (x_send_scroll_bar_event): Likewise. Check that the size does not
6486 exceed limits imposed by XClientMessageEvent, as well as the usual
6487 ptrdiff_t and size_t limits.
6489 * keyboard.c: Overflow, signedness and related fixes.
6490 (make_lispy_movement): Use same integer type in forward decl
6491 that is used in the definition.
6492 (read_key_sequence, keyremap_step):
6493 Change bufsize argument back to int, undoing my 2011-03-30 change.
6494 We prefer signed types, and int is wide enough here.
6495 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6496 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6497 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6498 length, not size_t. Use ptrdiff_t for index, not int.
6499 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6500 possibility of integer overflow.
6502 Overflow, signedness and related fixes for images.
6504 * dispextern.h (struct it.stack[0].u.image.image_id)
6505 (struct_it.image_id, struct image.id, struct image_cache.size)
6506 (struct image_cache.used, struct image_cache.ref_count):
6507 * gtkutil.c (update_frame_tool_bar):
6508 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6509 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6510 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6511 * nsmenu.m (update_frame_tool_bar):
6512 * xdisp.c (calc_pixel_width_or_height):
6513 * xfns.c (image_cache_refcount):
6514 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6515 on typical 64-bit hosts.
6517 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6518 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6519 Omit unnecessary casts to int.
6520 (parse_image_spec): Check that integers fall into 'int' range
6521 when the callers expect that.
6522 (image_ascent): Redo ascent calculation to avoid int overflow.
6523 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6524 (lookup_image): Remove unnecessary tests.
6525 (xbm_image_p): Locals are now of int, not EMACS_INT,
6526 since parse_image_check makes sure they fit into int.
6527 (png_load, gif_load, svg_load_image):
6528 Prefer int to unsigned where either will do.
6529 (tiff_handler): New function, combining the cores of the
6530 old tiff_error_handler and tiff_warning_handler.
6531 This function is rewritten to use vsnprintf and thereby avoid
6532 stack buffer overflows. It uses only the features of vsnprintf
6533 that are common to both POSIX and native Microsoft.
6534 (tiff_error_handler, tiff_warning_handler): Use it.
6535 (tiff_load, gif_load, imagemagick_load_image):
6536 Don't assume :index value fits in 'int'.
6537 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6538 (imagemagick_load_image): Check that crop parameters fit into
6539 the integer types that MagickCropImage accepts. Don't assume
6540 Vimagemagick_render_type has a nonnegative value. Don't assume
6541 size_t fits in 'long'.
6542 (gs_load): Use printmax_t to print the widest integers possible.
6543 Check for integer overflow when computing image height and width.
6545 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6547 * xdisp.c (redisplay_window): Don't force window start if point
6548 will be invisible in the resulting window. (Bug#9324)
6550 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6552 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6553 the display spec is of the form `(space ...)'.
6554 (handle_display_spec): Return the value returned by
6555 handle_single_display_spec, not just 1 or zero.
6556 (handle_single_display_spec): If the display spec is of the form
6557 `(space ...)', and specifies display in the text area, return 2
6559 (try_cursor_movement): Check for the need to scroll more
6560 accurately, and prefer exact match for point under bidi.
6561 Don't advance `row' beyond the last row of the window.
6563 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6564 into disp_prop; all users changed.
6566 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6567 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6568 for the text covered by the display property.
6570 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6572 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6573 Change return value to nil.
6574 (Frecord_buffer): Delete unused function.
6576 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6578 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6579 buffers, return left-to-right.
6580 (set_cursor_from_row): Consider candidate row a win if its glyph
6581 represents a newline and point is on that newline. Fixes cursor
6582 positioning on the newline at EOL of R2L text within L2R
6583 paragraph, and vice versa.
6584 (try_cursor_movement): Check continued rows, in addition to
6585 continuation rows. Fixes unwarranted scroll when point enters a
6586 continued line of R2L text within an L2R paragraph, or vice versa.
6587 (cursor_row_p): Consider the case of point being equal to
6588 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6589 from the end of a short line to the beginning of a continued line
6590 of R2L text within L2R paragraph.
6591 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6592 composed characters.
6594 * bidi.c (bidi_check_type): Use xassert.
6595 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6598 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6600 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6603 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6605 * nsfont.m (ns_otf_to_script): Fix typo.
6607 2011-08-22 Kenichi Handa <handa@m17n.org>
6609 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6610 extra slot even if the purpose is char-code-property-table.
6612 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6614 * xdisp.c (redisplay_window): When computing centering_position,
6615 account for the height of the header line. (Bug#8874)
6617 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6618 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6619 candidate is selected by the mouse, and that candidate has a
6620 composed character under the mouse.
6622 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6623 coordinates reported by pos-visible-in-window-p for a composed
6624 character in column zero.
6626 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6628 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6630 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6632 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6633 consider it a hit if to_charpos is anywhere in the range of the
6634 composed buffer positions.
6636 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6638 * image.c (gif_load): Don't assume that each subimage has the same
6639 dimensions as the base image. Handle disposal method that is
6640 "undefined" by the gif spec (Bug#9335).
6642 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6644 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6645 (Fcondition_case): Document `debug' symbol in error handler.
6647 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6649 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6650 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6651 from an Org mode buffer to a Speedbar frame.
6653 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6654 a composition, take its buffer position from IT->cmp_it.charpos.
6655 Fixes cursor positioning at the beginning of a line that begins
6656 with a composed character.
6658 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6660 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6661 character bidirectional type, use STRONG_L instead. Fixes crashes
6662 in a buffer produced by `describe-categories'.
6664 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6665 members before the level stack, so they would be saved and
6666 restored when copying iterator state. Fixes incorrect reordering
6667 around TABs covered by display properties.
6669 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6671 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6673 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6675 * eval.c (internal_condition_case, internal_condition_case_1)
6676 (internal_condition_case_2, internal_condition_case_n):
6677 Remove unnecessary aborts (Bug#9081).
6679 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6681 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6682 has no `load' handler, try opening the file locally. (Bug#9311)
6684 2011-08-16 Ken Brown <kbrown@cornell.edu>
6686 * gmalloc.c: Expand comment.
6688 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6690 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6691 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6693 2011-08-16 Ken Brown <kbrown@cornell.edu>
6695 Fix memory allocation problems in Cygwin build (Bug#9273).
6697 * unexcw.c ( __malloc_initialized): Declare external variable.
6698 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6700 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6702 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6704 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6706 [CYGWIN] (special_realloc): New function.
6707 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6708 requests to realloc storage in the static heap.
6710 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6712 * bidi.c (bidi_initialize): Remove unused local.
6714 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6717 * biditype.h: Remove file.
6718 * makefile.w32-in ($(BLD)/bidi.$(O)):
6719 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6721 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6723 * chartab.c: Improve commentary for the uniprop_table API.
6725 * bidi.c (bidi_paragraph_init): Support zero value of
6726 bidi_ignore_explicit_marks_for_paragraph_level.
6727 (bidi_initialize): Use uniprop_table instead of including
6728 biditype.h and bidimirror.h.
6730 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6731 coordinates of the iterator when restoring from ppos_it.
6734 2011-08-14 Kenichi Handa <handa@m17n.org>
6736 * process.c (create_process): Call setup_process_coding_systems
6737 after the pid of the process is set to -1 (Bug#8162).
6739 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6741 * xdisp.c (move_it_in_display_line_to): Don't invoke
6742 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6743 ppos_it. Fixes vertical cursor motion when line beginning is
6744 covered by an image. (Bug#9296)
6746 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6748 * nsterm.h (ns_run_ascript): Declare.
6749 (NSAPP_DATA2_RUNASSCRIPT): Define.
6751 * nsfns.m (as_script, as_result, as_status): New static variables.
6752 (ns_run_ascript): New function.
6753 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6754 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6755 the event loop. Get status from as_status (Bug#7276).
6757 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6758 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6759 the event loop (Bug#7276).
6761 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6763 * gnutls.c (QCgnutls_bootprop_priority)
6764 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6765 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6766 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6767 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6768 (QCgnutls_bootprop_verify_hostname_error)
6769 (QCgnutls_bootprop_callbacks_verify): Rename from
6770 Qgnutls_bootprop_..., all uses changed.
6772 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6775 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6777 * xfaces.c (Qframe_set_background_mode): Now static.
6778 * dispextern.h (Qframe_set_background_mode): Remove decl.
6780 * process.c (Fnetwork_interface_info): Declare local only if needed.
6782 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6784 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6785 (Fnetwork_interface_list): Allocate in increments of bytes instead
6786 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6787 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6789 (struct ifflag_def): notrailers is smart on OSX.
6790 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6791 Get hardware address with getifaddrs if available.
6793 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6795 * xdisp.c (iterate_out_of_display_property): xassert that
6796 IT->position is set to within IT->object's boundaries. Break from
6797 the loop as soon as EOB is reached; avoids infloops in redisplay
6798 when IT->position is set up wrongly due to some bug.
6799 Set IT->current to match the bidi iterator unconditionally.
6800 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6801 entry. Force push_it to save on the stack the current
6802 buffer/string position, to be restored by pop_it. Fix flags in
6803 the iterator structure wrt the object coming from a display
6804 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6805 properties. (Bug#9284)
6807 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6809 * fontset.c (fontset_get_font_group): Add proper type checks.
6812 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6814 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6815 and LC_VERSION_MIN_MACOSX.
6816 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6817 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6819 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6821 * xdisp.c (forward_to_next_line_start): Allow to use the
6822 no-display-properties-and-no-overlays under bidi display.
6823 Set disp_pos in the bidi iterator to avoid searches for display
6824 properties and overlays.
6826 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6828 * editfns.c (Fset_time_zone_rule): Document relationship with the
6831 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6832 the font entity extracted from the cache (Bug#8109).
6834 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6836 * composite.c (autocmp_chars): Don't reset point. That is done by
6837 restore_point_unwind (Bug#5984).
6839 2011-08-07 Juri Linkov <juri@jurta.org>
6841 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6842 to show the arg `TIME' instead of `TIMEVAL'.
6844 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6846 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6847 display property strides EOL and includes a newline, as in
6848 longlines-mode. (Bug#9254)
6849 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6850 word-wrap under bidirectional display. (Bug#9224)
6852 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6853 is non-zero, even if the data buffer is NULL. Fixes a crash in
6854 vertical-motion with longlines-mode. (Bug#9254)
6856 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6858 * bidi.c <bidi_cache_total_alloc>: Now static.
6859 (bidi_initialize): Initialize bidi_cache_total_alloc.
6861 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6864 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6865 amount allocated this far in `bidi_cache_total_alloc'.
6866 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6867 non-zero, only free the data buffer without restoring the cache
6868 contents. All callers changed.
6870 * dispextern.h (bidi_unshelve_cache): Update prototype.
6872 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6873 (move_it_in_display_line, move_it_to)
6874 (move_it_vertically_backward, move_it_by_lines): Replace the call
6875 to xfree to an equivalent call to bidi_unshelve_cache.
6876 (move_it_in_display_line_to): Fix logic of returning
6877 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6879 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6881 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6882 came from a string character with a `cursor' property. (Bug#9229)
6884 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6886 * Makefile.in (LIB_PTHREAD): New variable.
6887 (LIBES): Add LIB_PTHREAD (Bug#9216).
6889 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6890 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6892 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6894 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6896 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6898 * xterm.c (x_find_topmost_parent): New function.
6899 (x_set_frame_alpha): Find topmost parent window with
6900 x_find_topmost_parent and set the property there also (bug#9181).
6901 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6903 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6905 * callproc.c (Fcall_process): Avoid vfork clobbering
6906 the local vars buffer, coding_systems, current_dir.
6908 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6910 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6912 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6914 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6915 so that it is not optimized away.
6917 * xdisp.c (compute_display_string_pos): Remove unused local.
6919 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6921 Fix slow cursor motion and scrolling in large buffers with
6922 selective display, like Org Mode buffers. (Bug#9218)
6924 * dispextern.h (struct bidi_it): New member disp_prop_p.
6926 * xdisp.c: Remove one-slot cache of display string positions.
6927 (compute_display_string_pos): Accept an additional argument
6928 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6929 for a display string or property. If found, set DISP_PROP_P
6932 * bidi.c (bidi_fetch_char): Accept an additional argument
6933 DISP_PROP_P, and pass it to compute_display_string_pos.
6934 Only handle text covered by a display string if DISP_PROP_P is returned
6935 non-zero. All callers of bidi_fetch_char changed.
6937 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6939 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6941 2010-12-03 Don March <don@ohspite.net>
6943 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6944 last character M-[char] is translated to ESC [char] (bug#7541).
6946 2011-08-02 Kenichi Handa <handa@m17n.org>
6948 * lisp.h (uniprop_table): Extern it.
6950 * chartab.c (uniprop_table): Make it non-static.
6952 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6954 * xdisp.c (forward_to_next_line_start): Accept additional argument
6955 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6957 (reseat_at_next_visible_line_start): Use the bidi iterator state
6958 returned by forward_to_next_line_start to restore the state of
6959 it->bidi_it after backing up to previous newline. (Bug#9212)
6961 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6963 * regex.c (re_comp): Protoize.
6964 (re_exec): Fix return type.
6965 (regexec): Fix type of `ret'. (Bug#9203)
6967 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6969 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6970 This is needed if max-image-size is a floating-point number.
6972 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6974 * print.c (print_object): Print empty symbol as ##.
6976 * lread.c (read1): Read ## as empty symbol.
6978 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6980 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6981 setting frame foreground color (Bug#9175).
6982 (x_set_background_color): Likewise.
6984 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6985 contents (Bug#9176).
6986 (EmacsTooltip -init): Remove bezels and add shadows to
6989 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6990 or scroll bar (Bug#8470).
6992 * nsfont.m (nsfont_open): Remove assignment to voffset and
6993 unnecessary vars hshink, expand, hd, full_height, min_height.
6994 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6996 * nsterm.h (nsfont_info): Remove voffset field.
6998 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7000 Implement strike-through and overline on NextStep (Bug#8863).
7002 * nsfont.m (nsfont_open): Use underline position provided by font,
7003 instead of hard-coded value of 2.
7004 (nsfont_draw): Call ns_draw_text_decoration instead.
7006 * nsterm.h: Add declaration for ns_draw_text_decoration.
7008 * nsterm.m (ns_draw_text_decoration): New function for drawing
7009 underline, overline, and strike-through.
7010 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7011 ns_draw_text_decoration. Change treatment of cursor drawing to
7012 accommodate underlining, etc.
7014 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7016 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7019 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7021 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7022 Without this fix, if a signal arrives just after memory fills up,
7023 'malloc' might be invoked reentrantly.
7025 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7026 In other words, assume that every image size is allowed, on non-X
7027 hosts. This assumption is probably wrong, but it lets Emacs compile.
7029 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7031 * regex.c (re_iswctype): Convert return values to boolean.
7033 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7035 * xdisp.c (compute_display_string_pos): Don't use cached display
7036 string position if the buffer had its restriction changed.
7039 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7041 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7043 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7045 Integer signedness and overflow and related fixes. (Bug#9079)
7047 * bidi.c: Integer size and overflow fixes.
7048 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7049 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7050 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7051 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7052 (bidi_find_other_level_edge):
7053 Use ptrdiff_t instead of EMACS_INT where either will do.
7054 This works better on 32-bit hosts configured --with-wide-int.
7055 (bidi_cache_ensure_space): Check for size-calculation overflow.
7056 Use % rather than repeated addition, for better worst-case speed.
7057 Don't set bidi_cache_size until after xrealloc returns, because it
7059 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7060 (bidi_cache_ensure_space): Also check that the bidi cache size
7061 does not exceed that of the largest Lisp string or buffer. See Eli
7062 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7064 * alloc.c (__malloc_size_t): Remove.
7065 All uses replaced by size_t. See Andreas Schwab's note
7066 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7068 * image.c: Improve checking for integer overflow.
7069 (check_image_size): Assume that f is nonnull, since
7070 it is always nonnull in practice. This is one less thing to
7071 worry about when checking for integer overflow later.
7072 (x_check_image_size): New function, which checks for integer
7073 overflow issues inside X.
7074 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7075 This removes the need for a memory_full check.
7076 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7077 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7078 (xbm_read_bitmap_data): Change locals back to 'int', since
7079 their values must fit in 'int'.
7080 (xpm_load_image, png_load, tiff_load):
7081 Invoke x_create_x_image_and_pixmap earlier,
7082 to avoid much needless work if the image is too large.
7083 (tiff_load): Treat overly large images as if
7084 x_create_x_image_and_pixmap failed, not as malloc failures.
7085 (gs_load): Use x_check_image_size.
7087 * gtkutil.c: Omit integer casts.
7088 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7089 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7091 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7093 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7094 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7095 would wrongly return t on a 64-bit host.
7097 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7098 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7099 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7100 and therefore cause GCC to emit a bogus diagnostic in some cases.
7102 * image.c: Integer signedness and overflow and related fixes.
7103 This is not an exhaustive set of fixes, but it's time to
7104 record what I've got.
7105 (lookup_pixel_color, check_image_size): Remove redundant decls.
7106 (check_image_size): Don't assume that arbitrary EMACS_INT values
7107 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7108 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7109 (tiff_load, imagemagick_load_image):
7110 Check for overflow in size calculations.
7111 (x_create_x_image_and_pixmap): Remove unnecessary test for
7112 xmalloc returning NULL; that can't happen.
7113 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7114 (xpm_color_bucket): Use better integer hashing function.
7115 (xpm_cache_color): Don't possibly over-allocate memory.
7116 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7117 (gif_memory_source):
7118 Use ptrdiff_t, not int or size_t, to record sizes.
7119 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7120 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7121 either works, as we prefer signed integers.
7122 (tiff_read_from_memory, tiff_write_from_memory):
7123 Return tsize_t, not size_t, since that's what the TIFF API wants.
7124 (tiff_read_from_memory): Don't fail simply because the read would
7125 go past EOF; instead, return a short read.
7126 (tiff_load): Omit no-longer-needed casts.
7127 (Fimagemagick_types): Don't assume size fits into 'int'.
7129 Improve hashing quality when configured --with-wide-int.
7130 * fns.c (hash_string): New function, taken from sxhash_string.
7131 Do not discard information about ASCII character case; this
7132 discarding is no longer needed.
7133 (sxhash-string): Use it. Change sig to match it. Caller changed.
7134 * lisp.h: Declare it.
7135 * lread.c (hash_string): Remove, since we now use fns.c's version.
7136 The fns.c version returns a wider integer if --with-wide-int is
7137 specified, so this should help the quality of the hashing a bit.
7139 * emacs.c: Integer overflow minor fix.
7140 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7141 Define only if GNU_LINUX.
7142 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7144 * dispnew.c: Integer signedness and overflow fixes.
7145 Remove unnecessary forward decls, that were a maintenance hassle.
7146 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7148 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7149 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7150 (prepare_desired_row, line_draw_cost):
7151 Use int, not unsigned, where either works.
7152 (save_current_matrix, restore_current_matrix):
7153 Use ptrdiff_t, not size_t, where either works.
7154 (init_display): Check for overflow more accurately, and without
7155 relying on undefined behavior.
7157 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7158 Remove, replacing with the new symbols in lisp.h. All uses changed.
7159 * fileio.c (make_temp_name):
7160 * filelock.c (lock_file_1, lock_file):
7161 * xdisp.c (message_dolog):
7162 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7163 Use pMd etc. instead.
7164 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7165 replacing the pWIDE etc. symbols removed from editfns.c.
7167 * keyboard.h (num_input_events): Now uintmax_t.
7168 This is (very slightly) less likely to mess up due to wraparound.
7171 * buffer.c: Integer signedness fixes.
7172 (alloc_buffer_text, enlarge_buffer_text):
7173 Use ptrdiff_t rather than size_t when either will do, as we prefer
7176 * alloc.c: Integer signedness and overflow fixes.
7177 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7178 (__malloc_size_t): Default to size_t, not to int.
7179 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7180 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7181 Prefer ptrdiff_t to size_t when either would do, as we prefer
7183 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7184 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7185 Now const. Initialize with values that are in range even if char
7187 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7188 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7189 These functions do the right thing with sizes > 2**32.
7190 (check_depth): Now ptrdiff_t, not int.
7191 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7192 Adjust to new way of storing sizes. Check for size overflow bugs
7194 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7195 slightly wrong anyway, as it missed one instance of
7196 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7197 (refill_memory_reserve): Omit needless cast to size_t.
7198 (mark_object_loop_halt): Mark as externally visible.
7200 * xselect.c: Integer signedness and overflow fixes.
7201 (Fx_register_dnd_atom, x_handle_dnd_message):
7202 Use ptrdiff_t, not size_t, since we prefer signed.
7203 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7204 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7205 x_dnd_atoms_size and x_dnd_atoms_length.
7207 * doprnt.c: Prefer signed to unsigned when either works.
7209 * doprnt.c (doprnt):
7211 * xdisp.c (vmessage):
7212 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7213 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7214 prefer signed arithmetic to avoid comparison confusion.
7215 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7216 but is a bit tricky.
7218 Assume freestanding C89 headers, string.h, stdlib.h.
7219 * data.c, doprnt.c, floatfns.c, print.c:
7220 Include float.h unconditionally.
7221 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7222 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7223 * regex.c: Likewise for stddef.h, string.h.
7224 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7225 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7226 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7227 (STDC_HEADERS): Remove obsolete defines.
7228 * sysdep.c: Include limits.h unconditionally.
7230 Assume support for memcmp, memcpy, memmove, memset.
7231 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7232 * regex.c (memcmp, memcpy):
7233 Remove; we assume C89 now.
7235 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7236 (__malloc_safe_bcopy): Remove; no longer needed.
7238 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7239 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7240 well either way, and we prefer signed to unsigned.
7242 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7244 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7245 closes the connection while we're reading (bug#9182).
7247 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7249 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7250 are specified (Bug#9168).
7252 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7254 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7255 Found by GCC static checking and --with-wide-int on a 32-bit host.
7257 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7259 * xdisp.c (compute_display_string_pos): Fix logic of caching
7260 previous display string position. Initialize cached_prev_pos to
7261 -1. Fixes slow-down at the beginning of a buffer.
7263 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7265 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7266 for attrs[LFACE_FONTSET_INDEX].
7268 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7270 * xml.c (parse_region): Remove unused local
7271 that was recently introduced.
7273 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7275 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7276 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7278 * xdisp.c (move_it_in_display_line_to): Record the best matching
7279 position for TO_CHARPOS while scanning the line, and restore it on
7280 exit if none of the characters scanned was an exact match.
7281 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7282 when exact match is impossible due to invisible text, and the
7283 lines are truncated.
7285 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7287 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7290 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7292 Fix a significant slow-down of cursor motion with C-n, C-p,
7293 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7294 auto-repeat under bidi redisplay in fontified buffers.
7295 * xdisp.c (compute_stop_pos_backwards): New function.
7296 (next_element_from_buffer): Call compute_stop_pos_backwards to
7297 find a suitable prev_stop when we find ourselves before
7299 (reseat): Don't look for prev_stop, as that could mean a very long
7301 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7302 <cached_disp_overlay_modiff>: Cache for last found display string
7304 (compute_display_string_pos): Return the cached position if asked
7305 about the same buffer in the same area of character positions, and
7306 the buffer wasn't changed since the time the display string
7307 position was cached.
7309 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7311 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7312 is an integer, which is important for empty lines. (Bug#9149)
7314 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7316 * frame.c (Fmodify_frame_parameters): In tty case, update the
7317 default face if necessary (Bug#4238).
7319 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7321 * editfns.c (Fstring_to_char): No need to explain what a character
7322 is in the docstring (Bug#6576).
7324 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7326 * xml.c (parse_region): Make sure we always return a tree.
7328 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7330 * xml.c (parse_region): If a document contains only comments,
7333 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7335 * xml.c (make_dom): Return comments, too.
7337 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7340 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7341 and the surrounding thread.
7342 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7343 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7344 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7346 * s/openbsd.h (BROKEN_SIGIO): Define.
7347 * unexelf.c (unexec) [__OpenBSD__]:
7348 Don't update the .mdebug section of the Alpha COFF symbol table.
7350 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7355 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7357 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7358 This fixes some race conditions on the permissions of any newly
7361 * alloc.c (valid_pointer_p): Use pipe, not open.
7362 This fixes some permissions issues when debugging.
7364 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7365 If fchown fails to set both uid and gid, try to set just gid,
7366 as that is sometimes allowed. Adjust the file's mode to eliminate
7367 setuid or setgid bits that are inappropriate if fchown fails.
7369 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7371 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7372 to compare Lisp_Objects.
7373 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7374 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7375 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7377 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7379 * lread.c (read_integer): Unread even EOF character.
7380 (read1): Likewise. Properly record start position of symbol.
7382 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7383 symbol character follows.
7385 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7387 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7388 This works around a problem with the previous change to Fcopy_file.
7389 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7390 and without this change, GCC might complain about discarding
7391 fchown's return value.
7393 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7395 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7397 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7399 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7401 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7403 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7404 it's used from the C level.
7406 * process.c: Use the same condition for POLL_FOR_INPUT in both
7407 keyboard.c and process.c (bug#1858).
7409 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7411 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7412 (Fgnutls_boot): Use it.
7414 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7416 * doc.c (Fsubstitute_command_keys): Revert last change.
7418 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7420 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7421 quotes the next character, and doesn't affect other longer
7422 sequences (bug#8935).
7424 * lread.c (syms_of_lread): Clarify that is isn't only
7425 `eval-buffer' and `eval-defun' that's affected by
7426 `lexical-binding' (bug#8460).
7428 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7430 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7431 bidi redisplay when a line includes both an image and is truncated.
7433 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7435 Fix minor problems found by static checking.
7436 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7437 (elsz): Now a signed constant, not a size_t var. We prefer signed
7438 types to unsigned, to avoid integer comparison confusion. Without
7439 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7440 "cannot optimize loop, the loop counter may overflow", a symptom
7442 * indent.c (Fvertical_motion): Mark locals as initialized.
7443 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7445 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7447 * search.c (Fre_search_backward): Mention `case-fold-search' in
7448 all the re_search_* functions (bug#8138).
7450 * keyboard.c (Fopen_dribble_file): Document when the file is
7453 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7455 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7458 Support bidi reordering of display and overlay strings.
7459 * xdisp.c (compute_display_string_pos)
7460 (compute_display_string_end): Accept additional argument STRING.
7461 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7462 (reseat_to_string): Initialize bidi_it->string.s and
7463 bidi_it->string.schars.
7464 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7465 NULL (avoids a crash in bidi_paragraph_init).
7466 Initialize itb.string.lstring.
7467 (init_iterator): Call bidi_init_it only of a valid
7468 buffer position was specified. Initialize paragraph_embedding to
7470 (reseat_to_string): Initialize the bidi iterator.
7471 (display_string): If we need to ignore text properties of
7472 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7473 original value of -1 will not work with bidi.)
7474 (compute_display_string_pos): First arg is now struct
7475 `text_pos *'; all callers changed. Support display properties on
7477 (compute_display_string_end): Support display properties on Lisp
7479 (init_iterator, reseat_1, reseat_to_string): Initialize the
7480 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7481 when iterating on a string not from display properties).
7482 (compute_display_string_pos, compute_display_string_end):
7483 Fix calculation of the object to scan. Fixes an error when using
7485 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7486 base_level_stop; instead, set base_level_stop to BEGV.
7487 Fixes crashes in vertical-motion.
7488 (next_element_from_buffer): Improve commentary for when
7489 the iterator is before prev_stop.
7490 (init_iterator): Initialize bidi_p from the default value of
7491 bidi-display-reordering, not from buffer-local value. Use the
7492 buffer-local value only if initializing for buffer iteration.
7493 (handle_invisible_prop): Support invisible properties on strings
7494 that are being bidi-reordered.
7495 (set_iterator_to_next): Support bidi reordering of C strings and
7497 (next_element_from_string): Support bidi reordering of Lisp
7499 (handle_stop_backwards): Support Lisp strings as well.
7500 (display_string): Support display of R2L glyph rows.
7501 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7502 (init_iterator): Don't initialize it->bidi_p for strings
7504 (reseat_to_string): Initialize it->bidi_p for strings here.
7505 (next_element_from_string, next_element_from_c_string)
7506 (next_element_from_buffer): Add xassert's for correspondence
7507 between IT's object being iterated and it->bidi_it.string
7509 (face_before_or_after_it_pos): Support bidi iteration.
7510 (next_element_from_c_string): Handle the case of the first string
7511 character that is not the first one in the visual order.
7512 (get_visually_first_element): New function, refactored from common
7513 parts of next_element_from_buffer, next_element_from_string, and
7514 next_element_from_c_string.
7515 (tool_bar_lines_needed, redisplay_tool_bar)
7516 (display_menu_bar): Force left-to-right direction. Add a FIXME
7517 comment for making that be controlled by a user option.
7518 (push_it, pop_it): Save and restore the state of the
7519 bidi iterator. Save and restore the bidi_p flag.
7520 (pop_it): Iterate out of display property for string iteration as
7522 (iterate_out_of_display_property): Support iteration over strings.
7523 (handle_single_display_spec): Set up it->bidi_it for iteration
7524 over a display string, and call bidi_init_it.
7525 (handle_single_display_spec, next_overlay_string)
7526 (get_overlay_strings_1, push_display_prop): Set up the bidi
7527 iterator for displaying display or overlay strings.
7528 (forward_to_next_line_start): Don't use the shortcut if
7530 (back_to_previous_visible_line_start): If handle_display_prop
7531 pushed the iterator stack, restore the internal state of the bidi
7532 iterator by calling bidi_pop_it same number of times.
7533 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7534 and we are bidi-iterating, don't decrement the iterator position;
7535 instead, set the first_elt flag in the bidi iterator, to produce
7537 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7538 (push_display_prop): xassert that we are iterating a buffer.
7539 (push_it, pop_it): Save and restore paragraph_embedding member.
7540 (handle_single_display_spec, next_overlay_string)
7541 (get_overlay_strings_1, reseat_1, reseat_to_string)
7542 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7543 correctly. Don't assume unibyte strings are not bidi-reordered.
7544 (compute_display_string_pos)
7545 (compute_display_string_end): Fix handling the case of C string.
7546 (push_it, pop_it): Save and restore from_disp_prop_p.
7547 (handle_single_display_spec, push_display_prop): Set the
7548 from_disp_prop_p flag.
7549 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7550 (pop_it): Call iterate_out_of_display_property only if we are
7551 popping after iteration over a string that came from a display
7552 property. Fix a typo in popping stretch info. Add an assertion
7553 for verifying that the iterator position is in sync with the bidi
7555 (handle_single_display_spec, get_overlay_strings_1)
7556 (push_display_prop): Fix initialization of paragraph direction for
7557 string when that of the parent object is not yet determined.
7558 (reseat_1): Call bidi_init_it to resync the bidi
7559 iterator with IT's position. (Bug#7616)
7560 (find_row_edges): If ROW->start.pos gives position
7561 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7562 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7563 Reset the from_disp_prop_p flag.
7564 (SAVE_IT, RESTORE_IT): New macros.
7565 (pos_visible_p, face_before_or_after_it_pos)
7566 (back_to_previous_visible_line_start)
7567 (move_it_in_display_line_to, move_it_in_display_line)
7568 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7569 (try_scrolling, redisplay_window, display_line): Use them when
7570 saving a temporary copy of the iterator and restoring it back.
7571 (back_to_previous_visible_line_start, reseat_1)
7572 (init_iterator): Empty the bidi cache "stack".
7573 (move_it_in_display_line_to): If iterator ended up at
7574 EOL, but we never saw any buffer positions smaller than
7575 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7576 motion in bidi-reordered lines.
7577 (move_it_in_display_line_to): Record prev_method and prev_pos
7578 immediately before the call to set_iterator_to_next. Fixes cursor
7579 motion in bidi-reordered lines with stretch glyphs and strings
7580 displayed in margins. (Bug#8133) (Bug#8867)
7581 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7583 (pos_visible_p): Support positions in bidi-reordered lines.
7584 Save and restore bidi cache.
7586 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7587 (bidi_paragraph_info): Delete unused struct.
7588 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7589 (bidi_cache_start): New variable.
7590 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7592 (bidi_cache_fetch_state, bidi_cache_search)
7593 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7594 (bidi_cache_find, bidi_peek_at_next_level)
7595 (bidi_level_of_next_char, bidi_find_other_level_edge)
7596 (bidi_move_to_visually_next): Compare cache index with
7597 bidi_cache_start rather than with zero.
7598 (bidi_fetch_char): Accept new argument STRING; all callers
7599 changed. Support iteration over a string. Support strings with
7600 display properties. Support unibyte strings. Fix the type of
7601 `len' according to what STRING_CHAR_AND_LENGTH expects.
7602 (bidi_paragraph_init, bidi_resolve_explicit_1)
7603 (bidi_resolve_explicit, bidi_resolve_weak)
7604 (bidi_level_of_next_char, bidi_move_to_visually_next):
7605 Support iteration over a string.
7606 (bidi_set_sor_type, bidi_resolve_explicit_1)
7607 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7608 can now be zero (for strings); special values 0 and -1 were
7609 changed to -1 and -2, respectively.
7610 (bidi_char_at_pos): New function.
7611 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7612 Call it instead of FETCH_MULTIBYTE_CHAR.
7613 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7614 initialized to valid values.
7615 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7617 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7618 the test for valid cached positions. Fix the logic for looking up
7619 the sentinel state in the cache. GCPRO the Lisp string we are
7621 (bidi_push_it, bidi_pop_it): New functions.
7622 (bidi_initialize): Initialize the bidi cache start stack pointer.
7623 (bidi_cache_ensure_space): New function, refactored from part of
7624 bidi_cache_iterator_state. Don't assume the required size is just
7625 one BIDI_CACHE_CHUNK away.
7626 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7627 (bidi_count_bytes, bidi_char_at_pos): New functions.
7628 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7629 always valid if bidi_cache_idx is valid.
7630 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7631 is valid if it's going to be used.
7632 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7633 (bidi_cache_fetch_state, bidi_cache_search)
7634 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7635 (bidi_cache_iterator_state, bidi_cache_find)
7636 (bidi_find_other_level_edge, bidi_cache_start_stack):
7637 All variables related to cache indices are now EMACS_INT.
7639 * dispextern.h (struct bidi_string_data): New structure.
7640 (struct bidi_it): New member `string'. Make flag members be 1-bit
7641 fields, and put them last in the struct.
7642 (compute_display_string_pos, compute_display_string_end):
7644 (bidi_push_it, bidi_pop_it): Add prototypes.
7645 (struct iterator_stack_entry): New members bidi_p,
7646 paragraph_embedding, and from_disp_prop_p.
7647 (struct it): Member bidi_p is now a bit field 1 bit wide.
7648 (bidi_shelve_cache, bidi_unshelve_cache):
7651 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7652 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7653 and vector-like objects.
7655 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7656 cache around display iteration.
7658 * window.c (Fwindow_end, window_scroll_pixel_based)
7659 (displayed_window_lines, Frecenter): Save and restore the bidi
7660 cache around display iteration.
7662 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7664 * editfns.c (Fdelete_region): Clarify the use of the named
7665 parameters (bug#6788).
7667 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7669 * indent.c (Fvertical_motion): Set and restore w->pointm when
7670 saving and restoring the window's buffer (Bug#9006).
7672 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7674 * editfns.c (Fstring_to_char): Clarify just what is returned
7675 (bug#6576). Text by Eli Zaretskii.
7677 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7679 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7681 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7683 * buffer.c (mmap_find): Fix a typo.
7685 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7687 Fix execution of x selection hooks.
7688 * xselect.c (Qx_lost_selection_functions)
7689 (Qx_sent_selection_functions): New vars.
7690 (syms_of_xselect): DEFSYM them.
7691 (x_handle_selection_request): Pass Qx_sent_selection_functions
7692 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7693 (x_handle_selection_clear,x_clear_frame_selections):
7694 Pass Qx_lost_selection_functions rather than
7695 Vx_lost_selection_functions to Frun_hook_with_args.
7697 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7699 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7700 The old code sometimes used this field without initializing it.
7702 * alloc.c (gc_sweep): Don't read past end of array.
7703 In theory, the old code could also have corrupted Emacs internals,
7704 though it'd be very unlikely.
7706 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7708 * character.c (Fcharacterp): Don't advertise optional ignored
7709 argument. (Bug#4026)
7711 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7713 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7716 * window.c (Fset_window_start): Doc fix (bug#4199).
7717 (Fset_window_hscroll): Ditto.
7719 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7721 Fix minor new problems caught by GCC 4.6.1.
7722 * term.c (init_tty): Remove unused local.
7723 * xsettings.c (store_monospaced_changed): Define this function only
7724 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7727 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7729 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7731 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7733 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7734 are the mini-buffer and the echo area (bug#3320).
7736 * term.c (init_tty): Remove support for supdup, c10 and perq
7737 terminals, which are no longer supported (bug#1482).
7739 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7741 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7743 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7745 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7746 for non-popups (Bug#3642).
7748 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7750 * alloc.c (reset_malloc_hooks): Protoize.
7751 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7752 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7753 * cm.c (losecursor): Likewise.
7754 * data.c (fmod): Likewise.
7755 * dispnew.c (swap_glyphs_in_rows): Likewise.
7756 * emacs.c (memory_warning_signal): Likewise.
7757 * floatfns.c (float_error): Likewise.
7758 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7759 (otf_open, font_otf_capability, generate_otf_features)
7760 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7762 * image.c (pbm_read_file): Likewise.
7763 * indent.c (string_display_width): Likewise.
7764 * intervals.c (check_for_interval, search_for_interval)
7765 (inc_interval_count, count_intervals, root_interval)
7766 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7767 * lread.c (defalias): Likewise.
7768 * ralloc.c (r_alloc_check): Likewise.
7769 * regex.c (set_image_of_range_1, set_image_of_range)
7770 (regex_grow_registers): Likewise.
7771 * sysdep.c (strerror): Likewise.
7772 * termcap.c (valid_filename_p, tprint, main): Likewise.
7773 * tparam.c (main): Likewise.
7774 * unexhp9k800.c (run_time_remap, save_data_space)
7775 (update_file_ptrs, read_header, write_header, calculate_checksum)
7776 (copy_file, copy_rest, display_header): Likewise.
7777 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7779 * xdisp.c (check_it): Likewise.
7780 * xfaces.c (register_color, unregister_color, unregister_colors):
7782 * xfns.c (print_fontset_result): Likewise.
7783 * xrdb.c (member, fatal, main): Likewise.
7785 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7787 Fix minor problems found by static checking (Bug#9031).
7788 * chartab.c (char_table_set_range, map_sub_char_table):
7789 Remove unused locals.
7790 (uniprop_table): Now static.
7791 * composite.c (_work_char): Remove unused static var.
7793 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7795 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7797 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7799 * gtkutil.c (qttip_cb): Remove code without function.
7801 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7803 * w32.c (pthread_sigmask): New stub.
7805 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7807 Use pthread_sigmask, not sigprocmask (Bug#9010).
7808 sigprocmask is portable only for single-threaded applications, and
7809 Emacs can be multi-threaded when it uses GTK.
7810 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7812 * callproc.c (Fcall_process):
7813 * process.c (create_process):
7814 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7815 Use pthread_sigmask, not sigprocmask.
7817 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7819 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7820 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7823 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7825 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7826 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7827 (xg_hide_tooltip): Fix comment.
7829 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7830 in registerServicesMenuSendTypes.
7831 (validRequestorForSendType): Don't check ns_return_types.
7833 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7836 2011-07-08 Jason Rumney <jasonr@gnu.org>
7838 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7839 SH_SHOW for hidden windows (Bug#5482).
7841 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7842 frame struct members of non-existent frames (Bug#6284).
7844 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7846 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7847 variable firstTime not needed on OSX >= 10.6.
7848 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7849 >= 10.5. Use setKnobProportion, setDoubleValue.
7851 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7852 (MAC_OS_X_VERSION_10_5): Define if not defined.
7853 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7854 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7855 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7857 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7858 cString and lossyCString on OSX >= 10.4.
7860 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7861 sizeToFit on OSX >= 10.2.
7863 * nsimage.m (allocInitFromFile): Don't use deprecated method
7864 bestRepresentationForDevice on OSX >= 10.6.
7866 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7869 * emacs.c: Declare unexec_init_emacs_zone.
7871 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7873 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7875 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7876 on svcsMenu (Bug#8842).
7878 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7880 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7882 * nsterm.m (QUTF8_STRING): Declare.
7883 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7884 (validRequestorForSendType): Return type is (id).
7885 Change indexOfObjectIdenticalTo to indexOfObject.
7886 Check if we have local selection before returning self (Bug#8842).
7887 (writeSelectionToPasteboard): Put local selection into paste board
7888 if we have a local selection (Bug#8842).
7889 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7891 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7892 (ns_get_local_selection): Declare.
7894 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7896 * keymap.c (describe_map_tree): Don't insert a double newline at
7897 the end of the buffer (bug#1169) and return whether we inserted
7900 * callint.c (Fcall_interactively): Change "reading args" to
7901 "providing args" to try to clarify what it does (bug#1010).
7903 2011-07-07 Kenichi Handa <handa@m17n.org>
7905 * composite.c (composition_compute_stop_pos): Ignore a static
7906 composition starting before CHARPOS (Bug#8915).
7908 * xdisp.c (handle_composition_prop): Likewise.
7910 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7912 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7915 2011-07-07 Kenichi Handa <handa@m17n.org>
7917 * character.h (unicode_category_t): New enum type.
7919 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7920 (Qchar_code_property_table): New variable.
7921 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7922 (UNIPROP_COMPRESSED_FORM_P): New macros.
7923 (char_table_ascii): Uncompress the compressed values.
7924 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7925 Uncompress the compressed values.
7926 (sub_char_table_ref_and_range): Likewise.
7927 (char_table_ref_and_range): Uncompress the compressed values.
7928 (sub_char_table_set): New arg is_uniprop. Callers changed.
7929 Uncompress the compressed values.
7930 (sub_char_table_set_range): Args changed. Callers changed.
7931 (char_table_set_range): Adjuted for the above change.
7932 (map_sub_char_table): Delete args default_val and parent. Add arg
7933 top. Give decoded values to a Lisp function.
7934 (map_char_table): Adjust for the above change. Give decoded
7935 values to a Lisp function. Gcpro more variables.
7936 (uniprop_table_uncompress)
7937 (uniprop_decode_value_run_length): New functions.
7938 (uniprop_decoder, uniprop_decoder_count): New variables.
7939 (uniprop_get_decoder, uniprop_encode_value_character)
7940 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7942 (uniprop_encoder, uniprop_encoder_count): New variables.
7943 (uniprop_get_encoder, uniprop_table)
7944 (Funicode_property_table_internal, Fget_unicode_property_internal)
7945 (Fput_unicode_property_internal): New functions.
7946 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7947 Sunicode_property_table_internal, Sget_unicode_property_internal,
7948 and Sput_unicode_property_internal. Defvar_lisp
7949 char-code-property-alist.
7951 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7952 Vunicode_category_table.
7954 * font.c (font_range): Adjust for the change of
7955 Vunicode_category_table.
7957 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7959 * m/iris4d.h: Remove file, move contents ...
7960 * s/irix6-5.h: ... here.
7962 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7964 Remove unportable assumption about struct layout (Bug#8884).
7965 * alloc.c (mark_buffer):
7966 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7967 (clone_per_buffer_values): Don't assume that
7968 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7969 This isn't true in general, and it's particularly not true
7970 if Emacs is configured with --with-wide-int.
7971 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7972 New macros, used in the buffer.c change.
7974 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7976 * xsettings.c: Use both GConf and GSettings if both are available.
7977 (store_config_changed_event): Add comment.
7978 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7979 (store_tool_bar_style_changed): New functions.
7980 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7981 (struct xsettings): Move font inside HAVE_XFT.
7982 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7983 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7984 Move inside HAVE_XFT.
7985 (something_changed_gsettingsCB): Rename from something_changedCB.
7986 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7988 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7989 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7990 (something_changed_gconfCB): Rename from something_changedCB.
7991 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7992 (parse_settings): Move check for font inside HAVE_XFT.
7993 (read_settings, apply_xft_settings): Add comment.
7994 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7995 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7996 call store_font_name_changed.
7997 (xft_settings_event): Add comment.
7998 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7999 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8000 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8001 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8002 (xsettings_initialize): Call init_gsettings last.
8003 (xsettings_get_system_font, xsettings_get_system_normal_font):
8006 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8008 Random fixes. E.g., (random) never returned negative values.
8009 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8010 subseconds part to the entropy, as that's a bit more random.
8011 Prefer signed to unsigned, since the signedness doesn't matter and
8012 in general we prefer signed. When given a limit, use a
8013 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8014 latter isn't right if USE_2_TAGS_FOR_INTS.
8015 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8016 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8018 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8020 * textprop.c (text_property_stickiness):
8021 Obey Vtext_property_default_nonsticky.
8022 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8023 * w32fns.c (syms_of_w32fns):
8024 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8026 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8028 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8029 This is more efficient than Ffile_directory_p and avoids a minor race.
8031 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8033 * buffer.c (Foverlay_put): Say what the return value is
8036 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8037 is a directory before asking whether to use the file name
8039 (barf_or_query_if_file_exists): Make the "File is a directory"
8040 error be more correct.
8042 * fns.c (Frequire): Remove the mention of the .gz files, since
8043 that's installation-specific, but keep the mention of
8044 `get-load-suffixes'.
8046 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8048 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8049 Report string overflow if the output is too long.
8051 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8053 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8054 (syms_of_gnutls): Remove duplicate DEFSYM for
8055 Qgnutls_bootprop_verify_hostname_error, an error for
8056 Qgnutls_bootprop_verify_error (which is no longer used).
8058 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8059 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8060 Also (re)move comments that are misplaced or no longer relevant.
8062 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8064 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8066 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8068 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8069 and background color parameters if they have been changed.
8071 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8073 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8075 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8077 * xsettings.c (SYSTEM_FONT): Define only when used.
8078 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8080 * keymap.c (access_keymap_1): Now static.
8082 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8084 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8085 leave any prefix arg for the up event (Bug#1586).
8087 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8089 * lread.c (syms_of_lread): Mention single symbols defined by
8090 `defvar' or `defconst' (bug#7154).
8092 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8093 (Frequire): Mention get-load-suffixes.
8095 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8097 * window.h (window): Remove clone_number slot.
8098 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8100 (make_parent_window, make_window, saved_window)
8101 (Fset_window_configuration, save_window_save): Don't deal with
8103 * buffer.c (Qclone_number): Remove declaration.
8104 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8106 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8108 Add multiple inheritance to keymaps.
8109 * keymap.c (Fmake_composed_keymap): New function.
8110 (Fset_keymap_parent): Simplify.
8111 (fix_submap_inheritance): Remove.
8112 (access_keymap_1): New function extracted from access_keymap to handle
8113 embedded parents and handle lists of maps.
8114 (access_keymap): Use it.
8115 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8116 (Fcopy_keymap): Handle embedded parents.
8117 (Fcommand_remapping, define_as_prefix): Simplify.
8118 (Fkey_binding): Simplify.
8119 (syms_of_keymap): Move minibuffer-local-completion-map,
8120 minibuffer-local-filename-completion-map,
8121 minibuffer-local-must-match-map, and
8122 minibuffer-local-filename-must-match-map to Elisp.
8123 (syms_of_keymap): Defsubr make-composed-keymap.
8124 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8125 (parse_menu_item): Trivial simplification.
8127 2011-07-01 Glenn Morris <rgm@gnu.org>
8129 * Makefile.in (SETTINGS_LIBS): Fix typo.
8131 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8133 * coding.c (Fencode_coding_string): Record the last coding system
8134 used, as the function doc string says (bug#8738).
8136 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8138 * xsettings.c (store_monospaced_changed): Take new font as arg and
8139 check for change against current_mono_font.
8140 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8141 (emacs_settings_constructor, emacs_settings_get_property)
8142 (emacs_settings_set_property, emacs_settings_class_init)
8143 (emacs_settings_init, gsettings_obj): Remove.
8144 (something_changedCB): New function for HAVE_GSETTINGS.
8145 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8146 with value as argument.
8147 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8148 g_settings_new (Bug#8967). Do not create gsettings_obj.
8149 Remove calls to g_settings_bind. Connect something_changedCB to
8152 * xgselect.c: Add defined (HAVE_GSETTINGS).
8153 (xgselect_initialize): Ditto.
8155 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8156 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8159 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8161 * eval.c (struct backtrace): Simplify and port the data structure.
8162 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8163 signed bit field, as this assumption is not portable and it makes
8164 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8165 "char debug_on_exit : 1" as this is not portable either; instead,
8166 use the portable "unsigned int debug_on_exit : 1". Remove unused
8167 member evalargs. Remove obsolete comments about cc bombing out.
8169 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8171 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8172 Let HAVE_GSETTINGS override HAVE_GCONF.
8173 (store_monospaced_changed): New function.
8174 (EMACS_SETTINGS): A new type derived from GObject to handle
8175 GSettings notifications.
8176 (emacs_settings_constructor, emacs_settings_get_property)
8177 (emacs_settings_set_property, emacs_settings_class_init):
8179 (gsettings_client, gsettings_obj): New variables.
8180 (GSETTINGS_SCHEMA): New define.
8181 (something_changedCB): Call store_monospaced_changed.
8182 (init_gsettings): New function.
8183 (xsettings_initialize): Call init_gsettings.
8184 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8187 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8190 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8192 * window.c (resize_root_window, grow_mini_window)
8193 (shrink_mini_window): Rename Qresize_root_window to
8194 Qwindow_resize_root_window and Qresize_root_window_vertically to
8195 Qwindow_resize_root_window_vertically.
8197 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8199 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8201 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8203 * makefile.w32-in: Redesign dependencies so they reflect more
8204 clearly which files are directly included by each source file,
8205 and not through other includes.
8207 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8209 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8210 (sort_overlays, overlay_strings): When an overlay's clone number
8211 matches the window's clone number process the overlay even if
8212 the overlay's window property doesn't match the current window.
8214 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8215 (Fwindow_hchild): Rename to Fwindow_left_child.
8216 (Fwindow_next): Rename to Fwindow_next_sibling.
8217 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8218 (resize_window_check): Rename to window_resize_check.
8219 (resize_window_apply): Rename to window_resize_apply.
8220 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8221 (Fdelete_other_windows_internal, resize_frame_windows)
8222 (Fsplit_window_internal, Fdelete_window_internal)
8223 (grow_mini_window, shrink_mini_window)
8224 (Fresize_mini_window_internal): Fix callers accordingly.
8226 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8228 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8229 (emacs_fixed_set_min_size): Remove.
8230 (emacs_fixed_new): Take frame as argument.
8232 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8233 (_EmacsFixedPrivate): Remove minwidth/height.
8234 Add struct frame *f.
8235 (emacs_fixed_init): Initialize priv->f.
8236 (get_parent_class, emacs_fixed_set_min_size): Remove.
8237 (emacs_fixed_new): Set priv->f to argument.
8238 (emacs_fixed_get_preferred_width)
8239 (emacs_fixed_get_preferred_height): Use min_width/height from
8240 frames size_hint to set minimum and natural (Bug#8919).
8241 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8242 and use min_width/height from frames size_hint to set
8243 min_width/height (Bug#8919).
8245 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8246 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8249 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8251 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8252 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8255 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8257 * process.c (wait_reading_process_output): Bypass select if
8258 waiting for a cell while ignoring keyboard input, and input is
8259 pending. Suggested by Jan Djärv (Bug#8869).
8261 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8263 Use gnulib's dup2 module instead of rolling our own.
8264 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8266 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8268 * dispnew.c (scrolling_window): Before scrolling, turn off a
8269 mouse-highlight in the window being scrolled.
8271 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8273 Move DEFSYM to lisp.h and use everywhere.
8275 * character.h (DEFSYM): Move declaration...
8276 * lisp.h (DEFSYM): ...here.
8282 * w32select.c: Don't include character.h.
8284 * alloc.c (syms_of_alloc):
8285 * buffer.c (syms_of_buffer):
8286 * bytecode.c (syms_of_bytecode):
8287 * callint.c (syms_of_callint):
8288 * casefiddle.c (syms_of_casefiddle):
8289 * casetab.c (init_casetab_once):
8290 * category.c (init_category_once, syms_of_category):
8291 * ccl.c (syms_of_ccl):
8292 * cmds.c (syms_of_cmds):
8293 * composite.c (syms_of_composite):
8294 * dbusbind.c (syms_of_dbusbind):
8295 * dired.c (syms_of_dired):
8296 * dispnew.c (syms_of_display):
8297 * doc.c (syms_of_doc):
8298 * editfns.c (syms_of_editfns):
8299 * emacs.c (syms_of_emacs):
8300 * eval.c (syms_of_eval):
8301 * fileio.c (syms_of_fileio):
8302 * fns.c (syms_of_fns):
8303 * frame.c (syms_of_frame):
8304 * fringe.c (syms_of_fringe):
8305 * insdel.c (syms_of_insdel):
8306 * keymap.c (syms_of_keymap):
8307 * lread.c (init_obarray, syms_of_lread):
8308 * macros.c (syms_of_macros):
8309 * msdos.c (syms_of_msdos):
8310 * print.c (syms_of_print):
8311 * process.c (syms_of_process):
8312 * search.c (syms_of_search):
8313 * sound.c (syms_of_sound):
8314 * syntax.c (init_syntax_once, syms_of_syntax):
8315 * terminal.c (syms_of_terminal):
8316 * textprop.c (syms_of_textprop):
8317 * undo.c (syms_of_undo):
8318 * w32.c (globals_of_w32):
8319 * window.c (syms_of_window):
8320 * xdisp.c (syms_of_xdisp):
8321 * xfaces.c (syms_of_xfaces):
8322 * xfns.c (syms_of_xfns):
8323 * xmenu.c (syms_of_xmenu):
8324 * xsettings.c (syms_of_xsettings):
8325 * xterm.c (syms_of_xterm): Use DEFSYM.
8327 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8329 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8331 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8333 Integer and buffer overflow fixes (Bug#8873).
8335 * print.c (printchar, strout): Check for string overflow.
8336 (PRINTPREPARE, printchar, strout):
8337 Don't set size unless allocation succeeds.
8339 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8340 for sizes. Check for string overflow more accurately.
8341 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8343 * macros.c: Integer and buffer overflow fixes.
8344 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8345 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8346 Use ptrdiff_t, not int, for sizes.
8347 Don't increment bufsize until after realloc succeeds.
8348 Check for size-calculation overflow.
8349 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8351 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8353 * lread.c: Integer overflow fixes.
8354 (read_integer): Radix is now EMACS_INT, not int,
8355 to improve quality of diagnostics for out-of-range radices.
8356 Calculate buffer size correctly for out-of-range radices.
8357 (read1): Check for integer overflow in radices, and in
8358 read-circle numbers.
8359 (read_escape): Avoid int overflow.
8360 (Fload, openp, read_buffer_size, read1)
8361 (substitute_object_recurse, read_vector, read_list, map_obarray):
8362 Use ptrdiff_t, not int, for sizes.
8363 (read1): Use EMACS_INT, not int, for sizes.
8364 Check for size overflow.
8366 * image.c (cache_image): Check for size arithmetic overflow.
8368 * lread.c: Integer overflow issues.
8369 (saved_doc_string_size, saved_doc_string_length)
8370 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8371 Now ptrdiff_t, not int.
8372 (read1): Don't assume doc string length fits in int. Check for
8373 out-of-range doc string lengths.
8374 (read_list): Don't assume file position fits in int.
8375 (read_escape): Check for hex character overflow.
8377 2011-06-22 Leo Liu <sdl.web@gmail.com>
8379 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8380 Move to minibuffer.el.
8382 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8384 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8385 The following patches are for when GLYPH_DEBUG && !XASSERT.
8386 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8387 * dispnew.c (flush_stdout):
8388 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8389 Mark as externally visible.
8390 * dispnew.c (check_window_matrix_pointers): Now static.
8391 * dispnew.c (window_to_frame_vpos):
8392 * xfns.c (unwind_create_frame):
8393 * xterm.c (x_check_font): Remove unused local.
8394 * scroll.c (CHECK_BOUNDS):
8395 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8396 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8397 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8398 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8399 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8401 (debug_method_add): Use va_list and vsprintf rather than relying
8402 on undefined behavior with wrong number of arguments.
8403 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8404 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8405 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8406 since we're not interested in debugging glyphs with old libraries.
8407 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8408 GCC 4.6.0's static checking.
8410 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8412 Integer overflow and signedness fixes (Bug#8873).
8413 A few related buffer overrun fixes, too.
8415 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8417 * dispextern.h (struct face.stipple):
8418 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8419 (x_bitmap_mask, x_allocate_bitmap_record)
8420 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8421 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8422 (x_create_bitmap_from_xpm_data):
8423 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8424 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8426 * xfaces.c (load_pixmap):
8427 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8428 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8429 (.bitmaps_last, struct x_output.icon_bitmap):
8430 Use ptrdiff_t, not int, for bitmap indexes.
8431 (x_allocate_bitmap_record): Check for size overflow.
8432 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8434 Use ptrdiff_t, not int, for overlay counts.
8435 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8436 * editfns.c (overlays_around, get_pos_property):
8437 * textprop.c (get_char_property_and_overlay):
8438 * xdisp.c (next_overlay_change, note_mouse_highlight):
8439 * xfaces.c (face_at_buffer_position):
8440 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8441 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8442 (Fnext_overlay_change, Fprevious_overlay_change)
8443 (mouse_face_overlay_overlaps, Foverlays_in):
8444 Use ptrdiff_t, not int, for sizes.
8445 (overlays_at, overlays_in): Check for size-calculation overflow.
8447 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8449 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8450 (x_session_initialize): Do not assume string length fits in int.
8452 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8453 This is unlikely, but can occur if DPI is outlandish.
8455 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8456 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8458 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8459 * xrdb.c (magic_file_p, search_magic_path):
8460 Omit last arg SUFFIX; it was always 0. All callers changed.
8461 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8463 * xfont.c (xfont_match): Avoid need for strlen.
8465 * xfns.c: Don't assume strlen fits in int.
8466 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8468 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8469 not unsigned long, as we prefer signed integers. All callers changed.
8470 Detect integer overflow in repeat count.
8471 (message_dolog): Don't assume print length fits in 39 bytes.
8472 (display_mode_element): Don't assume strlen fits in int.
8474 * termcap.c: Don't assume sizes fit in int and never overflow.
8475 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8476 (gobble_line): Check for size-calculation overflow.
8478 * minibuf.c (Fread_buffer):
8479 * lread.c (intern, intern_c_string):
8480 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8481 Don't assume string length fits in int.
8483 * keyboard.c (parse_tool_bar_item):
8484 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8486 * font.c: Don't assume string length fits in int.
8487 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8488 Use ptrdiff_t, not int.
8489 (font_intern_prop): Don't assume string length fits in int.
8490 Don't assume integer property fits in fixnum.
8491 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8493 * filelock.c: Fix some buffer overrun and integer overflow issues.
8494 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8495 Reformulate so as not to need the command string.
8496 Invoke gzip -cd rather than gunzip, as it's more portable.
8497 (lock_info_type, lock_file_1, lock_file):
8498 Don't assume pid_t and time_t fit in unsigned long.
8499 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8500 (current_lock_owner): Prefer signed type for sizes.
8501 Use memcpy, not strncpy, where memcpy is what is really wanted.
8502 Don't assume (via atoi) that time_t and pid_t fit in int.
8503 Check for time_t and/or pid_t out of range, e.g., via a network share.
8504 Don't alloca where an auto var works fine.
8506 * fileio.c: Fix some integer overflow issues.
8507 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8508 Don't assume string length fits in int.
8509 (directory_file_name): Don't assume string length fits in long.
8510 (make_temp_name): Don't assume pid fits in int, or that its print
8511 length is less than 20.
8513 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8515 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8517 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8519 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8520 We prefer signed integers, even for size calculations.
8522 * emacs.c: Don't assume string length fits in 'int'.
8523 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8524 (main): Don't invoke strlen when not needed.
8526 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8527 (XD_DEBUG_MESSAGE): Don't waste a byte.
8529 * callproc.c (getenv_internal_1, getenv_internal)
8531 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8533 * lread.c (invalid_syntax): Omit length argument.
8534 All uses changed. This doesn't fix a bug, but it simplifies the
8535 code away from its former Hollerith-constant appearance, and it's
8536 one less 'int' to worry about when looking at integer-overflow issues.
8537 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8539 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8540 This didn't break anything, but it didn't help either.
8541 It's confusing to put a bogus integer in a place where the actual
8542 value does not matter.
8543 (LIST_END_P): Remove unused macro and its bogus comment.
8544 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8546 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8547 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8549 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8550 We prefer signed types, and the value cannot exceed the EMACS_INT
8551 range anyway (because otherwise the length would not be representable).
8552 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8553 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8554 This avoids a GCC warning when WIDE_EMACS_INT.
8556 * indent.c (sane_tab_width): New function.
8557 (current_column, scan_for_column, Findent_to, position_indentation)
8558 (compute_motion): Use it. This is just for clarity.
8559 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8561 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8563 * lisp.h (lint_assume): New macro.
8564 * composite.c (composition_gstring_put_cache):
8565 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8567 * editfns.c, insdel.c:
8568 Omit unnecessary forward decls, to simplify future changes.
8570 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8572 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8574 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8575 Use much-faster test for byte-length change.
8576 Don't assume string byte-length fits in 'int'.
8577 Check that character arg fits in 'int'.
8578 (mapcar1): Declare byte as byte, for clarity.
8580 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8582 * fns.c (concat): Catch string overflow earlier.
8583 Do not rely on integer wraparound.
8585 * dispextern.h (struct it.overlay_strings_charpos)
8586 (struct it.selective): Now EMACS_INT, not int.
8587 * xdisp.c (forward_to_next_line_start)
8588 (back_to_previous_visible_line_start)
8589 (reseat_at_next_visible_line_start, next_element_from_buffer):
8590 Don't arbitrarily truncate the value of 'selective' to int.
8592 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8594 * composite.c: Don't truncate sizes to 'int'.
8595 (composition_gstring_p, composition_reseat_it)
8596 (composition_adjust_point): Use EMACS_INT, not int.
8597 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8598 not EMACS_UINT, for indexes.
8600 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8602 * buffer.c: Include <verify.h>.
8603 (struct sortvec.priority, struct sortstr.priority):
8604 Now EMACS_INT, not int.
8605 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8606 (struct sortstr.size, record_overlay_string)
8607 (struct sortstrlist.size, struct sortlist.used):
8608 Don't truncate size to int.
8609 (record_overlay_string): Check for size-calculation overflow.
8610 (init_buffer_once): Check at compile-time, not run-time.
8612 2011-06-22 Jim Meyering <meyering@redhat.com>
8614 Don't leak an XBM-image-sized buffer
8615 * image.c (xbm_load): Free the image buffer after using it.
8617 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8620 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8621 that Sun C diagnosed.
8622 * fns.c (secure_hash): Fix pointer signedness issue.
8623 * intervals.c (static_offset_intervals): New function.
8624 (offset_intervals): Use it.
8626 2011-06-21 Leo Liu <sdl.web@gmail.com>
8629 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8632 * fns.c (secure_hash): Rename from crypto_hash_function and change
8633 the first arg to accept symbols.
8634 (Fsecure_hash): New primitive.
8635 (syms_of_fns): New symbols.
8637 2011-06-20 Deniz Dogan <deniz@dogan.se>
8639 * process.c (Fset_process_buffer): Clarify return value in
8642 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8644 * dispnew.c (add_window_display_history): Use BVAR.
8646 * xdisp.c (debug_method_add): Use BVAR.
8647 (check_window_end, dump_glyph_matrix, dump_glyph)
8648 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8650 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8653 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8654 check till after the cache is created in init_frame_faces.
8656 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8658 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8660 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8662 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8663 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8664 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8666 Improve buffer-overflow checking (Bug#8873).
8667 * fileio.c (Finsert_file_contents):
8668 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8669 Remove the old (too-loose) buffer overflow checks.
8670 They weren't needed, since make_gap checks for buffer overflow.
8671 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8672 The old code merely checked for Emacs fixnum overflow, and relied
8673 on undefined (wraparound) behavior. The new code avoids undefined
8674 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8676 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8677 Tune. Don't use wider integers than needed. Don't use alloca.
8678 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8680 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8682 * insdel.c, lisp.h (buffer_overflow): New function.
8683 (insert_from_buffer_1, replace_range, replace_range_2):
8684 * insdel.c (make_gap_larger):
8685 * editfns.c (Finsert_char):
8686 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8688 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8690 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8692 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8694 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8695 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8697 * fileio.c: Don't assume EMACS_INT fits in off_t.
8698 (emacs_lseek): New static function.
8699 (Finsert_file_contents, Fwrite_region): Use it.
8700 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8702 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8704 * fns.c: Don't overflow int when computing a list length.
8705 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8706 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8707 truncation on 64-bit hosts. Check for QUIT every
8708 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8709 faster and is responsive enough.
8710 (Flength): Report an error instead of overflowing an integer.
8711 (Fsafe_length): Return a float if the value is not representable
8712 as a fixnum. This shouldn't happen except in contrived situations.
8713 (Fnthcdr, Fsort): Don't assume list length fits in int.
8714 (Fcopy_sequence): Don't assume vector length fits in int.
8716 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8717 (header_size, word_size): New constants.
8718 (allocate_vectorlike): Don't check size overflow here.
8719 (allocate_vector): Check it here instead, since this is the only
8720 caller of allocate_vectorlike that could cause overflow.
8721 Check that the new vector's length is representable as a fixnum.
8723 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8724 The previous code was bogus. For example, next_almost_prime (32)
8725 returned 39, which is undesirable as it is a multiple of 3; and
8726 next_almost_prime (24) returned 25, which is a multiple of 5 so
8727 why was the code bothering to check for multiples of 7?
8729 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8731 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8733 Variadic C functions now count arguments with ptrdiff_t.
8734 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8735 Back then I didn't know that the Emacs coding style prefers signed int.
8736 Also, in the meantime I found a few more instances where arguments
8737 were being counted with int, which may truncate counts on 64-bit
8738 machines, or EMACS_INT, which may be unnecessarily wide.
8739 * lisp.h (struct Lisp_Subr.function.aMANY)
8740 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8741 Arg counts are now ptrdiff_t, not size_t.
8742 All variadic functions and their callers changed accordingly.
8743 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8744 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8745 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8746 * callint.c (Fcall_interactively): Check arg count for overflow,
8747 to avoid potential buffer overrun. Use signed char, not 'int',
8748 for 'varies' array, so that we needn't bother to check its size
8749 calculation for overflow.
8750 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8751 * eval.c (apply_lambda):
8752 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8753 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8754 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8756 * callint.c (Fcall_interactively): Don't use index var as event count.
8758 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8759 * mem-limits.h (SIZE): Remove; no longer used.
8761 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8763 Remove unnecessary casts.
8764 * xterm.c (x_term_init):
8765 * xfns.c (x_set_border_pixel):
8766 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8767 These aren't needed now that we assume ANSI C.
8769 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8770 It's more likely to cause problems (due to unsigned overflow)
8773 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8775 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8777 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8779 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8781 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8783 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8785 GLYPH_CODE_FACE returns EMACS_INT, not int.
8786 * dispextern.h (merge_faces):
8787 * xfaces.c (merge_faces):
8788 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8789 Don't assume EMACS_INT fits in int.
8791 * character.h (CHAR_VALID_P): Remove unused parameter.
8792 * fontset.c, lisp.h, xdisp.c: All uses changed.
8794 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8796 * fns.c (concat): Minor tuning based on overflow analysis.
8797 This doesn't fix any bugs. Use int to hold character, instead
8798 of constantly refetching from Emacs object. Use XFASTINT, not
8799 XINT, for value known to be a character. Don't bother comparing
8800 a single byte to 0400, as it's always less.
8802 * floatfns.c (Fexpt):
8803 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8805 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8808 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8810 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8811 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8812 incorrectly succeed when S was a string, because 4294967386 was
8813 truncated before it was used.
8815 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8816 Otherwise, an out-of-range integer could cause undefined behavior
8819 * composite.c: Use int, not EMACS_INT, for characters.
8820 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8821 EMACS_INT, for values that are known to be in character range.
8822 This doesn't fix any bugs but is the usual style inside Emacs and
8823 may generate better code on 32-bit machines.
8825 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8826 This is for reasons similar to the recent CHAR_STRING fix.
8827 * charset.c (Fencode_char): Check that character arg is actually
8828 a character. Pass an int to ENCODE_CHAR.
8829 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8830 wider than 'int', as a compile-time check to prevent future regressions
8833 * character.c (char_string): Remove unnecessary casts.
8835 Make sure a 64-bit char is never passed to CHAR_STRING.
8836 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8837 by silently ignoring the top 32 bits, allowing some values
8838 that were far too large to be valid characters.
8839 * character.h: Include <verify.h>.
8840 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8841 arguments are no wider than unsigned, as a compile-time check
8842 to prevent future regressions in this area.
8844 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8845 (Fsubst_char_in_region):
8847 * xdisp.c (decode_mode_spec_coding):
8848 Adjust to CHAR_STRING's new requirement.
8849 * editfns.c (Finsert_char, Fsubst_char_in_region):
8850 * fns.c (concat): Check that character args are actually
8851 characters. Without this test, these functions did the wrong
8852 thing with wildly out-of-range values on 64-bit hosts.
8854 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8855 These casts should not be needed on 32-bit hosts, either.
8856 * keyboard.c (read_char):
8857 * lread.c (Fload): Remove casts to unsigned.
8859 * lisp.h (UNSIGNED_CMP): New macro.
8860 This fixes comparison bugs on 64-bit hosts.
8861 (ASCII_CHAR_P): Use it.
8862 * casefiddle.c (casify_object):
8863 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8864 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8865 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8866 * dispextern.h (FACE_FROM_ID):
8867 * keyboard.c (read_char): Use UNSIGNED_CMP.
8869 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8870 not to EMACS_INT, to avoid GCC warning.
8872 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8874 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8875 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8876 isn't needed on 32-bit machines.
8878 * buffer.c (Fgenerate_new_buffer_name):
8879 Use EMACS_INT for count, not int.
8880 (advance_to_char_boundary): Return EMACS_INT, not int.
8882 * data.c (Qcompiled_function): Now static.
8884 * window.c (window_body_lines): Now static.
8886 * image.c (gif_load): Rename local to avoid shadowing.
8888 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8889 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8890 * alloc.c (make_save_value): Integer argument is now of type
8892 (mark_object): Use ptrdiff_t, not int.
8893 * lisp.h (pD): New macro.
8894 * print.c (print_object): Use it.
8896 * alloc.c: Use EMACS_INT, not int, to count objects.
8897 (total_conses, total_markers, total_symbols, total_vector_size)
8898 (total_free_conses, total_free_markers, total_free_symbols)
8899 (total_free_floats, total_floats, total_free_intervals)
8900 (total_intervals, total_strings, total_free_strings):
8901 Now EMACS_INT, not int. All uses changed.
8902 (Fgarbage_collect): Compute overall total using a double, so that
8903 integer overflow is less likely to be a problem. Check for overflow
8904 when converting back to an integer.
8905 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8906 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8907 These were 'int' variables that could overflow on 64-bit hosts;
8908 they were never used, so remove them instead of repairing them.
8909 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8910 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8911 Previously, this ceilinged at INT_MAX, but that doesn't work on
8913 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8915 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8916 (allocate_vectorlike): Check for ptrdiff_t overflow.
8917 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8918 when a (possibly-narrower) signed value would do just as well.
8919 We prefer using signed arithmetic, to avoid comparison confusion.
8921 * alloc.c: Catch some string size overflows that we were missing.
8922 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8923 for convenience in STRING_BYTES_MAX.
8924 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8925 The definition here is exact; the one in lisp.h was approximate.
8926 (allocate_string_data): Check for string overflow. This catches
8927 some instances we weren't catching before. Also, it catches
8928 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8929 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8930 and ptrdiff_t and EMACS_INT are both 64 bits.
8932 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8933 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8934 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8936 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8938 * alloc.c (Fmake_string): Check for out-of-range init.
8940 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8942 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8944 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8946 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8947 xg_get_default_scrollbar_width.
8949 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8950 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8951 (style_changed_cb): Call update_theme_scrollbar_width and call
8952 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8953 all frames (Bug#8505).
8954 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8955 Call gtk_window_set_resizable if HAVE_GTK3.
8956 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8957 and height if HAVE_GTK3 (Bug#8505).
8958 (scroll_bar_width_for_theme): New variable.
8959 (update_theme_scrollbar_width): New function.
8960 (xg_get_default_scrollbar_width): Move code to
8961 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8962 (xg_initialize): Call update_theme_scrollbar_width.
8964 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8966 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8968 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8970 * frame.c (make_frame): Call other_buffer_safely instead of
8973 * window.c (temp_output_buffer_show): Call display_buffer with
8974 second argument Vtemp_buffer_show_specifiers and reset latter
8975 immediately after the call.
8976 (Vtemp_buffer_show_specifiers): New variable.
8977 (auto_window_vscroll_p, next_screen_context_lines)
8978 (Vscroll_preserve_screen_position): Remove leading asterisks from
8981 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8983 Fix minor problems found by GCC 4.6.0 static checking.
8984 * buffer.c (Qclone_number): Remove for now, as it's unused.
8985 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8986 (record_buffer): Remove unused local.
8987 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8988 (set_frame_buffer_list): Remove; unused.
8989 * frame.h (other_visible_frames): Remove decl.
8990 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8991 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8992 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8994 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8995 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8996 Define only if HAVE_GPM.
8997 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8998 (update_hints_inhibit): Remove; never set. All uses removed.
8999 * widgetprv.h (emacsFrameClassRec): Remove decl.
9000 * window.c (delete_deletable_window): Now returns void, since it
9001 wasn't returning anything.
9002 (compare_window_configurations): Remove unused locals.
9003 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9004 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9005 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9006 the same widths as pointers. This follows up on the 2011-05-06 patch.
9007 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9008 * xterm.h: Likewise.
9009 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9011 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9013 * makefile.w32-in: Update dependencies.
9014 (LISP_H): Add lib/intprops.h.
9016 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9018 * image.c (gif_load): Add animation frame delay to the metadata.
9019 (syms_of_image): Use DEFSYM. New symbol `delay'.
9021 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9023 * window.c (delete_deletable_window): Re-add.
9024 (Fset_window_configuration): Rewrite to handle dead buffers and
9025 consequently deletable windows.
9026 (window_tree, Fwindow_tree): Remove. Supply functionality in
9028 (compare_window_configurations): Simplify code.
9030 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9032 * image.c (imagemagick_load_image): Fix type mismatch.
9033 (Fimagemagick_types): Likewise.
9035 * window.h (replace_buffer_in_windows): Declare.
9037 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9039 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9040 Qclone_number. Remove external declaration of Qdelete_window.
9041 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9043 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9044 Run Qbuffer_list_update_hook if allowed.
9045 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9046 buffer list implementation.
9047 (other_buffer_safely): New function.
9048 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9049 calls to replace_buffer_in_windows and
9050 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9052 (record_buffer): Inhibit quitting and rewrite using quittable
9053 functions. Run Qbuffer_list_update_hook if allowed.
9054 (Frecord_buffer, Funrecord_buffer): New functions.
9055 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9056 Move switch-to-buffer to window.el.
9057 (bury-buffer): Move to window.el.
9058 (Vbuffer_list_update_hook): New variable.
9060 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9063 * window.h (resize_frame_windows): Move up in code.
9064 (Fwindow_frame): Remove EXFUN.
9065 (replace_buffer_in_all_windows): Remove prototype.
9066 (replace_buffer_in_windows_safely): Add prototype.
9068 * window.c: Declare Qdelete_window static again. Move down
9069 declaration of select_count.
9070 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9071 (Fother_window): Move to window.el.
9072 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9073 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9074 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9076 (replace_buffer_in_windows): Implement by calling
9077 Qreplace_buffer_in_windows.
9078 (replace_buffer_in_all_windows): Remove with some functionality
9079 moved into replace_buffer_in_windows_safely.
9080 (replace_buffer_in_windows_safely): New function.
9081 (select_window_norecord, select_frame_norecord): Move in front
9082 of run_window_configuration_change_hook. Remove now obsolete
9084 (Fset_window_buffer): Rewrite doc-string.
9085 Call Qrecord_window_buffer.
9086 (keys_of_window): Move binding for other-window to window.el.
9088 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9090 * dispextern.h (struct image): Replace data member, whose int_val
9091 and ptr_val fields were not used by anything, with a single
9094 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9095 (gif_clear_image, gif_load, imagemagick_load_image)
9096 (gs_clear_image, gs_load): Callers changed.
9098 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9100 * buffer.h: Include <time.h>, for time_t.
9101 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9103 Fix minor problems found by static checking.
9105 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9107 Make identifiers static if they are not used in other modules.
9108 * data.c (Qcompiled_function, Qframe, Qvector):
9109 * image.c (QimageMagick, Qsvg):
9110 * minibuf.c (Qmetadata):
9111 * window.c (resize_window_check, resize_root_window): Now static.
9112 * window.h (resize_window_check, resize_root_window): Remove decls.
9114 * window.c (window_deletion_count, delete_deletable_window):
9116 (window_body_lines): Now static.
9117 (Fdelete_other_windows_internal): Mark vars as initialized.
9118 Make sure 'resize_failed' is initialized.
9119 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9120 (resize_window_apply): Remove unused local.
9121 * window.h (delete_deletable_window): Remove decl.
9123 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9124 (imagemagick_load_image): Fix pointer signedness problem by changing
9125 last arg from unsigned char * to char *. All uses changed.
9126 Also, fix a local for similar reasons.
9127 Remove unused locals. Remove locals to avoid shadowing.
9128 (fn_rsvg_handle_free): Remove; unused.
9129 (svg_load, svg_load_image): Fix pointer signedness problem.
9130 (imagemagick_load_image): Don't use garbage pointer image_wand.
9132 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9134 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9136 * image.c (gif_load): Fix omitted cast error introduced by
9139 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9141 * window.h (resize_proportionally, orig_total_lines)
9142 (orig_top_line): Remove from window structure.
9143 (set_window_height, set_window_width, change_window_heights)
9144 (Fdelete_window): Remove prototypes.
9145 (resize_frame_windows): Remove duplicate declaration.
9147 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9149 * window.h (resize_frame_windows, resize_window_check)
9150 (delete_deletable_window, resize_root_window)
9151 (resize_frame_windows): Declare prototypes.
9153 * window.c (resize_window_apply): Make definition be "static" to
9154 match the prototype.
9156 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9158 * window.c: Remove declarations of Qwindow_size_fixed,
9159 window_min_size_1, window_min_size_2, window_min_size,
9160 size_window, window_fixed_size_p, enlarge_window, delete_window.
9161 Remove static from declaration of Qdelete_window, it's
9162 temporarily needed by Fbury_buffer.
9163 (replace_window): Don't assign orig_top_line and
9165 (Fdelete_window, delete_window): Remove. Window deletion is
9166 handled by window.el.
9167 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9168 Replace Fdelete_window calls with calls to Qdelete_window.
9169 (Fdelete_other_windows): Remove. Deleting other windows is
9170 handled by window.el.
9171 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9172 handled in window.el.
9173 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9174 Window minimum sizes are handled in window.el.
9175 (shrink_windows, size_window, set_window_height)
9176 (set_window_width, change_window_heights, window_height)
9177 (window_width, CURBEG, CURSIZE, enlarge_window)
9178 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9179 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9180 handled in window.el.
9181 (make_dummy_parent): Rename to make_parent_window and give it a
9182 second argument horflag.
9183 (make_window): Don't set resize_proportionally any more.
9184 (Fsplit_window): Remove. Windows are split in window.el.
9185 (save_restore_action, save_restore_orig_size)
9186 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9187 Resize mini windows in window.el.
9188 (grow_mini_window, shrink_mini_window): Implement by calling
9189 Qresize_root_window_vertically, resize_window_check and
9190 resize_window_apply.
9191 (saved_window, Fset_window_configuration, save_window_save):
9192 Do not handle orig_top_line, orig_total_lines, and
9193 resize_proportionally.
9194 (window_min_height, window_min_width): Move to window.el.
9195 (keys_of_window): Move bindings for delete-other-windows,
9196 split-window, delete-window and enlarge-window to window.el.
9198 * buffer.c: Temporarily extern Qdelete_window.
9199 (Fbury_buffer): Temporarily call Qdelete_window instead of
9200 Fdelete_window (Fbury_buffer will move to window.el soon).
9202 * frame.c (set_menu_bar_lines_1): Remove code handling
9203 orig_top_line and orig_total_lines.
9205 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9206 set_window_height but set heights directly.
9207 (change_frame_size_1): Use resize_frame_windows.
9209 * xdisp.c (init_xdisp): Don't use set_window_height but set
9212 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9213 Use resize_frame_windows instead of change_window_heights and run
9214 run_window_configuration_change_hook.
9216 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9217 instead of change_window_heights and run
9218 run_window_configuration_change_hook.
9220 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9222 * window.c (replace_window): Rename second argument REPLACEMENT to
9223 NEW. New third argument SETFLAG. Rewrite.
9224 (delete_window, make_dummy_parent): Call replace_window with
9226 (window_list_1): Move down in code.
9227 (run_window_configuration_change_hook): Move set_buffer part
9228 before select_frame_norecord part in order to unwind correctly.
9229 Rename count1 to count.
9230 (recombine_windows, delete_deletable_window, resize_root_window)
9231 (Fdelete_other_windows_internal)
9232 (Frun_window_configuration_change_hook, make_parent_window)
9233 (resize_window_check, resize_window_apply, Fresize_window_apply)
9234 (resize_frame_windows, Fsplit_window_internal)
9235 (Fdelete_window_internal, Fresize_mini_window_internal):
9237 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9239 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9241 * window.h (window): Add some new members to window structure -
9242 normal_lines, normal_cols, new_total, new_normal, clone_number,
9243 splits, nest, prev_buffers, next_buffers.
9244 (WINDOW_TOTAL_SIZE): Move here from window.c.
9245 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9247 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9249 (make_dummy_parent): Set new members of windows structure.
9250 (make_window): Move down in code. Handle new members of window
9252 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9253 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9254 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9255 (Fset_window_prev_buffers, Fwindow_next_buffers)
9256 (Fset_window_next_buffers, Fset_window_clone_number):
9258 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9259 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9261 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9262 Argument WINDOW can be now internal window too.
9263 (Fwindow_use_time): Move up in code.
9264 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9266 (Fset_window_configuration, saved_window)
9267 (Fcurrent_window_configuration, save_window_save): Handle new
9268 members of window structure.
9269 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9270 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9271 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9272 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9273 Qget_mru_window, Qresize_root_window,
9274 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9275 Qauto_buffer_name; staticpro them.
9277 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9279 * window.c (Fwindow_total_size, Fwindow_left_column)
9280 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9281 (Fwindow_list_1): New functions.
9282 (window_box_text_cols): Replace with window_body_cols.
9283 (Fwindow_width, Fscroll_left, Fscroll_right):
9284 Use window_body_cols instead of window_box_text_cols.
9285 (delete_window, Fset_window_configuration):
9286 Call delete_all_subwindows with window as argument.
9287 (delete_all_subwindows): Take a window as argument and not a
9289 (window_loop): Remove handling of GET_LRU_WINDOW and
9291 (Fget_lru_window, Fget_largest_window): Move to window.el.
9293 * window.h: Extern window_body_cols instead of
9294 window_box_text_cols. delete_all_subwindows now takes a
9295 Lisp_Object as argument.
9297 * indent.c (compute_motion, Fcompute_motion):
9298 Use window_body_cols instead of window_box_text_cols.
9300 * frame.c (delete_frame): Call delete_all_subwindows with root
9303 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9305 * fns.c (Fputhash): Document return value.
9307 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9309 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9311 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9313 Cons<->int and similar integer overflow fixes (Bug#8794).
9315 Check for overflow when converting integer to cons and back.
9316 * charset.c (Fdefine_charset_internal, Fdecode_char):
9317 Use cons_to_unsigned to catch overflow.
9318 (Fencode_char): Use INTEGER_TO_CONS.
9319 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9320 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9321 * data.c (long_to_cons, cons_to_long): Remove.
9322 (cons_to_unsigned, cons_to_signed): New functions.
9323 These signal an error for invalid or out-of-range values.
9324 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9325 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9326 * font.c (Ffont_variation_glyphs):
9327 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9328 * lisp.h: Include <intprops.h>.
9329 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9330 (cons_to_signed, cons_to_unsigned): New decls.
9331 (long_to_cons, cons_to_long): Remove decls.
9332 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9333 (Fprimitive_undo): Use CONS_TO_INTEGER.
9334 * xfns.c (Fx_window_property): Likewise.
9335 * xselect.c: Include <limits.h>.
9336 (x_own_selection, selection_data_to_lisp_data):
9337 Use INTEGER_TO_CONS.
9338 (x_handle_selection_request, x_handle_selection_clear)
9339 (x_get_foreign_selection, Fx_disown_selection_internal)
9340 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9341 (lisp_data_to_selection_data): Use cons_to_unsigned.
9342 (x_fill_property_data): Use cons_to_signed.
9343 Report values out of range.
9345 Check for buffer and string overflow more precisely.
9346 * buffer.h (BUF_BYTES_MAX): New macro.
9347 * lisp.h (STRING_BYTES_MAX): New macro.
9348 * alloc.c (Fmake_string):
9349 * character.c (string_escape_byte8):
9350 * coding.c (coding_alloc_by_realloc):
9351 * doprnt.c (doprnt):
9352 * editfns.c (Fformat):
9354 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9355 since they may not be the same number.
9356 * editfns.c (Finsert_char):
9357 * fileio.c (Finsert_file_contents):
9358 Likewise for BUF_BYTES_MAX.
9360 * image.c: Use ptrdiff_t, not int, for sizes.
9361 (slurp_file): Switch from int to ptrdiff_t.
9363 (slurp_file): Check that file size fits in both size_t (for
9364 malloc) and ptrdiff_t (for sanity and safety).
9366 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9367 if b->modtime has its maximal value.
9369 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9371 Don't assume time_t can fit into int.
9372 * buffer.h (struct buffer.modtime): Now time_t, not int.
9373 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9374 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9376 Minor fixes for signed vs unsigned integers.
9377 * character.h (MAYBE_UNIFY_CHAR):
9378 * charset.c (maybe_unify_char):
9379 * keyboard.c (read_char, reorder_modifiers):
9380 XINT -> XFASTINT, since the integer must be nonnegative.
9381 * ftfont.c (ftfont_spec_pattern):
9382 * keymap.c (access_keymap, silly_event_symbol_error):
9383 XUINT -> XFASTINT, since the integer must be nonnegative.
9384 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9385 since it makes no difference and we prefer signed.
9386 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9387 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9390 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9392 * window.h (Fwindow_frame): Declare.
9394 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9396 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9397 (SPARE_MEMORY): Always define.
9398 (LARGE_REQUEST): Remove.
9399 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9401 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9403 * lisp.h: Move EXFUNS for Fframe_root_window,
9404 Fframe_first_window and Fset_frame_selected_window to window.h.
9406 * window.h: Move EXFUNS for Fframe_root_window,
9407 Fframe_first_window and Fset_frame_selected_window here from
9410 * frame.c (Fwindow_frame, Fframe_first_window)
9411 (Fframe_root_window, Fframe_selected_window)
9412 (Fset_frame_selected_window): Move to window.c.
9413 (Factive_minibuffer_window): Move to minibuf.c.
9414 (Fother_visible_frames_p): New function.
9416 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9418 * window.c (decode_window, decode_any_window): Move up in code.
9419 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9420 (inhibit_frame_unsplittable): Remove unused variable.
9421 (Fwindow_buffer): Move up and rewrite doc-string.
9422 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9423 (Fwindow_prev): New functions.
9424 (Fwindow_frame): Move here from frame.c. Accept any window as
9426 (Fframe_root_window, Fframe_first_window)
9427 (Fframe_selected_window): Move here from frame.c. Accept frame
9428 or arbitrary window as argument. Update doc-strings.
9429 (Fminibuffer_window): Move up in code.
9430 (Fwindow_minibuffer_p): Move up in code and simplify.
9431 (Fset_frame_selected_window): Move here from frame.c.
9433 (Fselected_window, select_window, Fselect_window): Move up in
9434 code. Minor doc-string fixes.
9436 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9438 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9439 Do not assume that spare memory exists; that assumption is valid
9440 only if SYSTEM_MALLOC.
9441 (LARGE_REQUEST): New macro, so that the issue of large requests
9442 is separated from the issue of spare memory.
9444 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9446 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9449 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9451 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9454 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9456 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9458 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9460 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9461 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9463 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9465 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9467 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9469 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9470 (x_clipboard_manager_save): Add return value.
9471 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9473 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9474 Obey Vx_select_enable_clipboard_manager. Catch errors in
9475 x_clipboard_manager_save (Bug#8779).
9476 (Vx_select_enable_clipboard_manager): New variable.
9477 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9479 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9481 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9483 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9485 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9486 in the current matrix if keep_current_p is non-zero.
9488 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9490 * bidi.c (bidi_level_of_next_char): Fix last change.
9492 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9494 Support bidi reordering of text covered by display properties.
9496 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9497 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9498 (bidi_cache_search, bidi_cache_iterator_state)
9499 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9500 (bidi_level_of_next_char, bidi_move_to_visually_next):
9501 Support character positions inside a run of characters covered by a
9503 (bidi_paragraph_init, bidi_resolve_explicit_1)
9504 (bidi_level_of_next_char): Call bidi_fetch_char and
9505 bidi_fetch_char_advance instead of FETCH_CHAR and
9507 (bidi_init_it): Initialize new members.
9508 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9510 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9511 instead of using explicit *_CHAR codes.
9512 (bidi_resolve_explicit, bidi_resolve_weak):
9513 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9514 bidirectional text is supported only in multibyte buffers.
9515 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9516 it to initialize the frame_window_p member of struct bidi_it.
9517 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9518 (bidi_resolve_explicit, bidi_resolve_weak)
9519 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9520 bidi_it->nchars is non-positive.
9521 (bidi_level_of_next_char): Don't try to lookup the cache for the
9522 next/previous character if nothing is cached there yet, or if we
9523 were just reseat()'ed to a new position.
9525 * xdisp.c (set_cursor_from_row): Set start and stop points
9526 according to the row's direction when priming the loop that looks
9527 for the glyph on which to display cursor.
9528 (single_display_spec_intangible_p): Function deleted.
9529 (display_prop_intangible_p): Reimplement to call
9530 handle_display_spec instead of single_display_spec_intangible_p.
9531 Accept 3 additional arguments needed by handle_display_spec.
9532 This fixes incorrect cursor motion across display property with complex
9533 values: lists, `(when COND...)' forms, etc.
9534 (single_display_spec_string_p): Support property values that are
9535 lists with the argument STRING its top-level element.
9536 (display_prop_string_p): Fix the condition for processing a
9537 property that is a list to be consistent with handle_display_spec.
9538 (handle_display_spec): New function, refactored from the
9539 last portion of handle_display_prop.
9540 (compute_display_string_pos): Accept additional argument
9541 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9542 value of a `display' property is a "replacing spec".
9543 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9544 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9545 the display property, but just return a value indicating whether
9546 the display property will replace the characters it covers.
9547 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9548 frame_window_p members of struct bidi_it.
9549 (compute_display_string_pos, compute_display_string_end):
9551 (push_it): Accept second argument POSITION, where pop_it should
9552 jump to continue iteration.
9553 (reseat_1): Initialize bidi_it.disp_pos.
9555 * keyboard.c (adjust_point_for_property): Adjust the call to
9556 display_prop_intangible_p to its new signature.
9558 * dispextern.h (struct bidi_it): New member frame_window_p.
9559 (bidi_init_it): Update prototypes.
9560 (display_prop_intangible_p): Update prototype.
9561 (compute_display_string_pos, compute_display_string_end):
9563 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9566 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9568 Malloc failure behavior now depends on size of allocation.
9569 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9570 * lisp.h: Change signatures accordingly.
9571 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9572 All callers changed. (Bug#8762)
9574 * gnutls.c: Use Emacs's memory allocators.
9575 Without this change, the gnutls library would invoke malloc etc.
9576 directly, which causes problems on non-SYNC_INPUT hosts, and which
9577 runs afoul of improving memory_full behavior. (Bug#8761)
9578 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9579 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9580 xfree instead of the default malloc, realloc, free.
9581 (Fgnutls_boot): No need to check for memory allocation failure,
9582 since xmalloc does that for us.
9584 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9585 * category.c (hash_get_category_set):
9586 * ccl.c (ccl_driver):
9587 * charset.c (Fdefine_charset_internal):
9588 * charset.h (struct charset.hash_index):
9589 * composite.c (get_composition_id, gstring_lookup_cache)
9590 (composition_gstring_put_cache):
9591 * composite.h (struct composition.hash_index):
9592 * dispextern.h (struct image.hash):
9593 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9594 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9595 (hashfn_equal, hashfn_user_defined, make_hash_table)
9596 (maybe_resize_hash_table, hash_lookup, hash_put)
9597 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9598 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9599 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9600 * image.c (make_image, search_image_cache, lookup_image)
9601 (xpm_put_color_table_h):
9602 * lisp.h (struct Lisp_Hash_Table):
9603 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9604 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9605 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9606 * alloc.c (allocate_vectorlike):
9607 Check for overflow in vector size calculations.
9608 * ccl.c (ccl_driver):
9609 Check for overflow when converting EMACS_INT to int.
9610 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9611 need to be updated by these changes.
9612 * fns.c (make_hash_table, maybe_resize_hash_table):
9613 Check for integer overflow with large hash tables.
9614 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9615 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9616 (SXHASH_REDUCE): New macro.
9617 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9618 Use it instead of discarding useful hash info with large hash values.
9619 (sxhash_float): New function.
9620 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9621 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9622 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9623 Rewrite to use FIXNUM_BITS, as this simplifies things.
9624 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9625 Adjust signatures to match updated version of code.
9626 (consing_since_gc): Now EMACS_INT, since a single hash table can
9627 use more than INT_MAX bytes.
9629 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9631 Make it possible to build with GCC-4.6+ -O2 -flto.
9633 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9635 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9637 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9638 Call minibuffer-inactive-mode.
9640 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9642 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9643 Update dependencies.
9645 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9647 * data.c (init_data): Remove code for UTS, this system is not
9650 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9652 Don't force ./temacs to start in terminal mode.
9654 * frame.c (make_initial_frame): Initialize faces in all cases, not
9655 only when CANNOT_DUMP is defined.
9656 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9658 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9660 * dispnew.c (add_window_display_history): Use const for the string
9661 pointer. Remove declaration, not needed.
9663 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9665 Use 'inline', not 'INLINE'.
9666 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9667 * alloc.c, fontset.c (INLINE): Remove.
9668 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9669 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9670 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9671 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9672 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9674 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9676 Make it possible to run ./temacs.
9678 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9679 syms_of_callproc does the same thing. Remove test for
9680 "initialized", do it in the caller.
9681 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9683 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9685 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9686 (read_minibuf): Use get_minibuffer.
9687 (syms_of_minibuf): Use DEFSYM.
9688 (Qmetadata): New var.
9689 * data.c (Qbuffer): Don't make it static.
9690 (syms_of_data): Use DEFSYM.
9692 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9694 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9695 (CCL_CODE_MIN): New macro.
9697 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9699 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9701 * eval.c (Qdebug): Now static.
9702 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9703 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9704 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9706 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9708 * image.c: Various fixes to ImageMagick code comments.
9709 (Fimagemagick_types): Doc fix.
9711 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9713 Minor fixes prompted by GCC 4.6.0 warnings.
9715 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9717 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9718 (x_clipboard_manager_save_all): Move extern decl to ...
9719 * xterm.h: ... here, so that it can be checked for consistency.
9721 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9723 * xselect.c (x_clipboard_manager_save_frame)
9724 (x_clipboard_manager_save_all): New functions.
9725 (Fx_clipboard_manager_save): Lisp function deleted.
9727 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9728 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9730 * xterm.h: Update prototype.
9732 2011-05-28 William Xu <william.xwl@gmail.com>
9734 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9737 2011-05-28 Jim Meyering <meyering@redhat.com>
9739 Avoid a sign-extension bug in crypto_hash_function.
9740 * fns.c (to_uchar): Define.
9741 (crypto_hash_function): Use it to convert some newly-signed
9742 variables to unsigned, to avoid sign-extension bugs. For example,
9743 without this change, (md5 "truc") would evaluate to
9744 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9745 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9746 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9748 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9750 Integer overflow fixes.
9752 * dbusbind.c: Serial number integer overflow fixes.
9753 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9754 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9755 to hold a serial number that is too large for a fixnum.
9756 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9757 Check for serial numbers out of range. Decode any serial number
9758 that was so large that it became a float. (Bug#8722)
9760 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9761 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9762 Use XFASTINT rather than XUINT when numbers are nonnegative.
9763 (xd_append_arg, Fdbus_method_return_internal):
9764 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9765 arguments, check that Lisp number is nonnegative, rather than
9766 silently wrapping negative numbers around. (Bug#8722)
9767 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9770 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9772 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9774 ccl: Add integer overflow checks.
9775 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9776 (IN_INT_RANGE): New macros.
9777 (ccl_driver): Use them to check for integer overflow when
9778 decoding a CCL program. Many of the new checks are whether XINT (x)
9779 fits in int; it doesn't always, on 64-bit hosts. The new version
9780 doesn't catch all possible integer overflows, but it's an
9781 improvement. (Bug#8719)
9783 * alloc.c (make_event_array): Use XINT, not XUINT.
9784 There's no need for unsigned here.
9786 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9787 This follows up to the 2011-05-06 change that substituted uintptr_t
9788 for EMACS_INT. This case wasn't caught back then.
9790 Rework Fformat to avoid integer overflow issues.
9791 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9792 now (part of C89). Include <verify.h>.
9793 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9794 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9795 (Fformat): Avoid the prepass trying to compute sizes; it was only
9796 approximate and thus did not catch overflow reliably. Instead, walk
9797 through the format just once, formatting and computing sizes as we go,
9798 checking for integer overflow at every step, and allocating a larger
9799 buffer as needed. Keep track separately whether the format is
9800 multibyte. Keep only the most-recently calculated precision, rather
9801 than them all. Record whether each argument has been converted to
9802 string. Use EMACS_INT, not int, for byte and char and arg counts.
9803 Support field widths and precisions larger than INT_MAX. Avoid
9804 sprintf's undefined behavior with conversion specifications such as %#d
9805 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9806 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9807 formatting out-of-range floating point numbers with int
9810 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9812 * data.c: Avoid integer truncation in expressions involving floats.
9813 * data.c: Include <intprops.h>.
9814 (arith_driver): When there's an integer overflow in an expression
9815 involving floating point, convert the integers to floating point
9816 so that the resulting value does not suffer from catastrophic
9817 integer truncation. For example, on a 64-bit host (* 4
9818 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9819 Do not rely on undefined behavior after integer overflow.
9821 merge count_size_as_multibyte, parse_str_to_multibyte
9822 * character.c, character.h (count_size_as_multibyte):
9823 Rename from parse_str_to_multibyte; all uses changed.
9824 Check for integer overflow.
9825 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9826 since it's now a duplicate of the other. This is more of
9827 a character than a buffer op, so better that it's in character.c.
9828 * fns.c, print.c: Adjust to above changes.
9830 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9832 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9834 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9836 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9837 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9838 (x_clipboard_manager_save): Now static.
9839 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9841 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9842 (crypto_hash_function): Now static.
9843 Fix pointer signedness problems. Avoid unnecessary initializations.
9845 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9847 * termhooks.h (Vselection_alist): Make it terminal-local.
9849 * terminal.c (create_terminal): Initialize it.
9851 * xselect.c: Support for clipboard managers.
9852 (Vselection_alist): Move to termhooks.h as terminal-local var.
9853 (LOCAL_SELECTION): New macro.
9854 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9855 (symbol_to_x_atom): Remove gratuitous arg.
9856 (x_handle_selection_request, lisp_data_to_selection_data)
9857 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9858 (x_own_selection, x_get_local_selection, x_convert_selection):
9859 New arg, specifying work frame. Use terminal-local Vselection_alist.
9860 (some_frame_on_display): Delete unused function.
9861 (Fx_own_selection_internal, Fx_get_selection_internal)
9862 (Fx_disown_selection_internal, Fx_selection_owner_p)
9863 (Fx_selection_exists_p): New optional frame arg.
9864 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9865 (x_handle_selection_clear): Don't treat other terminals with the
9866 same keyboard specially. Use the terminal-local Vselection_alist.
9867 (x_clear_frame_selections): Use Frun_hook_with_args.
9869 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9871 * xterm.h: Add support for those atoms.
9873 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9875 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9876 (converted_selections, conversion_fail_tag): New global variables.
9877 (x_selection_request_lisp_error): Free the above.
9878 (x_get_local_selection): Remove unnecessary code.
9879 (x_reply_selection_request): Args changed; handle arbitrary array
9880 of converted selections stored in converted_selections.
9881 Separate the XChangeProperty and SelectionNotify steps.
9882 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9883 (x_convert_selection): New function.
9884 (x_handle_selection_event): Simplify.
9885 (x_get_foreign_selection): Don't ignore incoming requests while
9886 waiting for an answer; this will fail when we implement
9887 SAVE_TARGETS, and seems unnecessary anyway.
9888 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9889 (Vx_sent_selection_functions): Doc fix.
9891 2011-05-26 Leo Liu <sdl.web@gmail.com>
9893 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9895 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9897 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9899 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9900 for fringe update if it has periodic bitmap.
9901 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9902 and fringe_bitmap_periodic_p.
9904 * fringe.c (get_fringe_bitmap_data): New function.
9905 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9906 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9907 row. Mark glyph row for fringe update if periodicity changed.
9909 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9910 for fringe update unless it has periodic bitmap.
9912 2011-05-25 Kenichi Handa <handa@m17n.org>
9914 * xdisp.c (get_next_display_element): Set correct it->face_id for
9915 a static composition.
9917 2011-05-24 Leo Liu <sdl.web@gmail.com>
9920 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9922 * fns.c (crypto_hash_function, Fsha1): New function.
9923 (Fmd5): Use crypto_hash_function.
9924 (syms_of_fns): Add Ssha1.
9926 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9928 * gnutls.c: Remove unused macros.
9929 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9930 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9931 Remove macros that are defined and never used.
9932 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9934 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9936 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9937 (Fx_get_selection_internal): Minor cleanup.
9938 (Fx_own_selection_internal): Rename arguments for consistency with
9941 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9943 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9945 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9947 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9949 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9951 * dispnew.c (scrolling_window): Don't exclude the case that the
9952 last enabled row in the desired matrix touches the bottom boundary.
9954 2011-05-21 Glenn Morris <rgm@gnu.org>
9956 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9957 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9958 and add some more files.
9960 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9962 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9963 report_file_error introduced by the change from 2011-05-07.
9965 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9967 * systime.h (Time): Define only if emacs is defined.
9968 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9969 where the include path doesn't have X11/X.h by default. See
9970 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9972 2011-05-20 Kenichi Handa <handa@m17n.org>
9974 * composite.c (find_automatic_composition): Fix previous change.
9976 2011-05-20 Glenn Morris <rgm@gnu.org>
9978 * lisp.mk: New file, split from Makefile.in.
9979 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9980 (shortlisp): Remove.
9981 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9983 2011-05-19 Glenn Morris <rgm@gnu.org>
9985 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9986 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9987 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9988 (lisp): Set the order to that of loadup.el.
9989 (shortlisp): Make it a copy of $lisp.
9990 (SOME_MACHINE_LISP): Remove.
9991 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9992 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9994 2011-05-18 Kenichi Handa <handa@m17n.org>
9996 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9997 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9998 (find_automatic_composition): Mostly rewrite for efficiency.
10000 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10002 * makefile.w32-in: Update dependencies.
10004 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10006 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10007 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10009 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10011 Fix some integer overflow issues, such as string length overflow.
10013 * insdel.c (count_size_as_multibyte): Check for string overflow.
10015 * character.c (lisp_string_width): Check for string overflow.
10016 Use EMACS_INT, not int, for string indexes and lengths; in
10017 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10018 the resulting string length overflows an EMACS_INT; instead,
10019 report a string overflow if no precision given. When checking for
10020 precision exhaustion, use a check that cannot possibly have
10021 integer overflow. (Bug#8675)
10022 * character.h (lisp_string_width): Adjust to new signature.
10024 * alloc.c (string_overflow): New function.
10025 (Fmake_string): Use it. This doesn't change behavior, but saves
10026 a few bytes and will simplify future changes.
10027 * character.c (string_escape_byte8): Likewise.
10028 * lisp.h (string_overflow): New decl.
10030 Fixups, following up to the user-interface timestamp change.
10031 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10032 for UI timestamps, instead of unsigned long.
10033 * msdos.c (mouse_get_pos): Likewise.
10034 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10035 * w32gui.h (Time): Define by including "systime.h" rather than by
10036 declaring it ourselves. (Bug#8664)
10038 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10039 * image.c (clear_image_cache): Likewise.
10041 * term.c (term_mouse_position): Don't assume time_t wraparound.
10043 Be more systematic about user-interface timestamps.
10044 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10045 and sometimes 'EMACS_UINT', to represent these timestamps.
10046 This change causes it to use 'Time' uniformly, as that's what X uses.
10047 This makes the code easier to follow, and makes it easier to catch
10048 integer overflow bugs such as Bug#8664.
10049 * frame.c (Fmouse_position, Fmouse_pixel_position):
10050 Use Time, not unsigned long, for user-interface timestamps.
10051 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10052 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10053 * keyboard.h (last_event_timestamp): Likewise.
10054 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10055 * menu.h (xmenu_show): Likewise.
10056 * term.c (term_mouse_position): Likewise.
10057 * termhooks.h (struct input_event.timestamp): Likewise.
10058 (struct terminal.mouse_position_hook): Likewise.
10059 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10060 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10061 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10062 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10063 what it was before.
10064 * menu.h, termhooks.h: Include "systime.h", for Time.
10066 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10067 Don't assume that the difference between two unsigned long values
10068 can fit into an integer. At this point, we know button_down_time
10069 <= event->timestamp, so the difference must be nonnegative, so
10070 there's no need to cast the result if double-click-time is
10071 nonnegative, as it should be; check that it's nonnegative, just in
10072 case. This bug is triggered when events are more than 2**31 ms
10073 apart (about 25 days). (Bug#8664)
10075 * xselect.c (last_event_timestamp): Remove duplicate decl.
10076 (x_own_selection): Remove needless cast to unsigned long.
10078 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10079 that always fit in int. Use a sentinel instead of a counter, to
10080 avoid a temp and to allay GCC's concerns about possible int overflow.
10081 * frame.h (struct frame): Use int for menu_bar_items_used
10082 instead of EMACS_INT, since it always fits in int.
10084 * menu.c (grow_menu_items): Check for int overflow.
10086 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10088 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10089 Before, the code was not consistent. These values cannot exceed
10090 2**31 - 1 so there's no need to make them unsigned.
10091 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10092 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10093 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10095 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10097 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10098 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10099 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10100 presumably because the widths might not match.
10102 * window.c (size_window): Avoid needless test at loop start.
10104 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10106 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10108 2011-05-12 Drew Adams <drew.adams@oracle.com>
10110 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10112 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10114 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10115 `width' to `bar_area_x' and `bar_area_width', respectively.
10116 (x_scroll_run): Take account of fringe background extension.
10118 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10119 Rename local vars `left' and `width' to `bar_area_x' and
10120 `bar_area_width', respectively.
10121 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10122 background extension.
10124 2011-05-10 Jim Meyering <meyering@redhat.com>
10126 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10128 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10130 * image.c (Finit_image_library): Return t for built-in image types,
10131 like pbm and xbm. (Bug#8640)
10133 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10135 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10137 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10139 * w32console.c (Fset_screen_color): Doc fix.
10140 (Fget_screen_color): New function.
10141 (syms_of_ntterm): Defsubr it.
10143 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10144 unlink the temporary file if Fcall_process didn't create it in the
10146 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10147 child process will be redirected to a file specified with `:file'.
10148 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10149 cue to call_process_cleanup not to close that handle.
10151 2011-05-07 Ben Key <bkey76@gmail.com>
10153 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10154 one of two shell specific rules, either bootstrap-temacs-CMD or
10155 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10156 to the previous implementation of the bootstrap-temacs rule.
10157 The bootstrap-temacs-CMD rule is similar to the previous
10158 implementation of the bootstrap-temacs rule except that it
10159 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10162 These changes, along with some changes to nt/configure.bat,
10163 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10164 earlier fix to add support for --cflags and --ldflags options
10165 that include quotes so that it works whether make uses cmd or
10168 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10170 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10171 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10173 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10174 a string. Handle both cases.
10175 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10176 (Fdbus_register_method): Use Qinvalid_function.
10178 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10180 * makefile.w32-in: Update dependencies.
10181 (LISP_H): Add inttypes.h and stdin.h.
10182 (PROCESS_H): Add unistd.h.
10184 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10186 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10187 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10189 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10191 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10193 * term.c (vfatal): Remove stray call to va_end.
10194 It's not needed and the C Standard doesn't allow it here anyway.
10196 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10197 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10199 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10202 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10204 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10206 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10208 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10210 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10212 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10213 * charset.c (Fdefine_charset_internal): Don't initialize
10214 charset.code_space[15]. The value was garbage, on hosts with
10215 32-bit int (Bug#8600).
10217 * lread.c (read_integer): Be more consistent with string-to-number.
10218 Use string_to_number to do the actual conversion; this avoids
10219 rounding errors and fixes some other screwups. Without this fix,
10220 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10221 (digit_to_number): Move earlier, for benefit of read_integer.
10222 Return -1 if the digit is out of range for the base, -2 if it is
10223 not a digit in any supported base. (Bug#8602)
10225 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10227 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10228 to match comment at start of function. This also removes a
10229 GCC warning about overflow in a 32+64-bit port.
10231 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10233 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10234 Reported by Stefan Monnier in
10235 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10236 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10237 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10239 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10240 (EMACS_UINTPTR): Likewise, with uintptr_t.
10242 * lisp.h: Prefer 64-bit EMACS_INT if available.
10243 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10244 on 32-bit hosts that have 64-bit int, so that they can access
10246 However, temporarily disable this change unless the temporary
10247 symbol WIDE_EMACS_INT is defined.
10249 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10251 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10252 This removes an assumption that EMACS_INT and long are the same
10253 width as pointers. The assumption is true for Emacs porting targets
10254 now, but we want to make other targets possible.
10255 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10256 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10257 In the rest of the code, change types of integers that hold casted
10258 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10259 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10260 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10261 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10262 No need to cast type when ORing.
10263 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10264 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10265 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10266 assume EMACS_INT is the same width as char *.
10267 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10268 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10269 Remove no-longer-needed casts.
10270 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10271 (xg_tool_bar_help_callback, xg_make_tool_item):
10272 Use EMACS_INTPTR to hold an integer
10273 that will be cast to void *; this can avoid a GCC warning
10274 if EMACS_INT is not the same width as void *.
10275 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10276 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10277 (current_message_1, set_message_1):
10278 Use a local to convert to proper width without a cast.
10279 * xmenu.c (dialog_selection_callback): Likewise.
10281 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10282 Also, don't assume VALBITS / RAND_BITS is less than 5,
10283 and don't rely on undefined behavior when shifting a 1 left into
10285 * lisp.h (get_random): Change signature to match.
10287 * lread.c (hash_string): Use size_t, not int, for hash computation.
10288 Normally we prefer signed values; but hashing is special, because
10289 it's better to use unsigned division on hash table sizes so that
10290 the remainder is nonnegative. Also, size_t is the natural width
10291 for hashing into memory. The previous code used 'int', which doesn't
10292 retain enough info to hash well into very large tables.
10293 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10295 * dbusbind.c: Don't possibly lose pointer info when converting.
10296 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10297 Use XPNTR rather than XHASH, so that the high-order bits of
10298 the pointer aren't lost when converting through void *.
10300 * eval.c (Fautoload): Don't double-shift a pointer.
10302 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10304 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10306 * gnutls.c (DEF_GNUTLS_FN):
10307 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10309 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10311 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10314 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10316 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10317 New version that can reserve upto 2GB of heap space.
10319 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10321 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10323 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10325 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10326 `gnutls_certificate_set_x509_key_file'.
10328 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10330 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10331 Update dependencies.
10333 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10335 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10336 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10337 Remove unused parameter `fildes'.
10338 * process.c (read_process_output, send_process): Don't pass it.
10340 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10342 Fix previous change: the library cache is defined in w32.c.
10343 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10344 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10346 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10348 Implement dynamic loading of GnuTLS on Windows.
10350 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10351 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10352 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10355 * gnutls.c (Qgnutls_dll): Define.
10356 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10357 (gnutls_*): Declare function pointers.
10358 (init_gnutls_functions): New function to initialize function pointers.
10359 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10360 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10361 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10362 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10363 (emacs_gnutls_write, emacs_gnutls_read)
10364 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10365 (Fgnutls_available_p): New function.
10366 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10367 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10368 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10370 * image.c: Include w32.h.
10371 (Vimage_type_cache): Delete.
10372 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10373 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10374 (w32_delayed_load): Move to w32.c.
10376 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10378 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10379 (w32_delayed_load): Move from image.c. When loading a library, record
10380 its filename in the :loaded-from property of the library id.
10381 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10382 Initialize and staticpro them.
10383 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10385 * process.c: Include lisp.h before w32.h, not after.
10386 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10387 instead of gnutls_record_check_pending.
10389 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10391 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10393 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10394 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10397 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10399 * xterm.c (x_set_frame_alpha): Do not set property on anything
10400 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10402 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10404 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10406 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10408 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10409 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10410 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10411 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10412 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10413 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10414 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10415 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10416 (Qgnutls_bootprop_callbacks_verify): Make static.
10418 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10420 * callproc.c: Indentation fixup.
10422 * sysdep.c (wait_for_termination_1): Make static.
10423 (wait_for_termination, interruptible_wait_for_termination):
10424 Move after wait_for_termination_1.
10426 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10428 * sysdep.c (interruptible_wait_for_termination): New function
10429 which is like wait_for_termination, but allows keyboard
10432 * callproc.c (Fcall_process): Add (:file "file") as an option for
10434 (Fcall_process_region): Ditto.
10436 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10438 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10439 rather than `XVECTOR (FOO)->size'.
10441 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10442 inttypes.h, as a gnulib replacement is used if it not available in
10445 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10447 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10448 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10449 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10451 * coding.c (coding_alloc_by_realloc): Error out if destination
10452 will grow beyond MOST_POSITIVE_FIXNUM.
10453 (decode_coding_emacs_mule): Abort if there isn't enough place in
10454 charbuf for the composition carryover bytes. Reserve an extra
10455 space for up to 2 characters produced in a loop.
10456 (decode_coding_iso_2022): Abort if there isn't enough place in
10457 charbuf for the composition carryover bytes.
10459 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10461 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10462 aborting when %lld or %lll format is passed.
10463 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10464 %llo or %llx format is passed. (Bug#8545)
10466 * window.c (window_scroll_line_based): Use a marker instead of
10467 simple variables to record original value of point. (Bug#7952)
10469 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10470 produced by %s or %c overflows available buffer space. (Bug#8545)
10472 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10474 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10475 (SIZE_MAX): Move defn after all includes, as they might #define it.
10477 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10479 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10481 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10483 * keyboard.c (Qdelayed_warnings_hook): Define.
10484 (command_loop_1): Run `delayed-warnings-hook'
10485 if Vdelayed_warnings_list is non-nil.
10486 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10487 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10489 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10491 * doprnt.c (doprnt): Don't return value smaller than the buffer
10492 size if the message was truncated. (Bug#8545).
10494 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10496 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10497 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10499 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10501 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10503 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10505 * makefile.w32-in: Update dependencies.
10507 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10509 Improve `doprnt' and its usage. (Bug#8545)
10510 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10511 `format_end'. Remove support for %l as a conversion specifier.
10512 Don't use xrealloc. Improve diagnostics when the %l size modifier
10513 is used. Update the commentary.
10515 * eval.c (verror): Simplify calculation of size_t.
10517 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10520 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10522 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10525 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10527 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10528 This makes this file independent of the recent pseudovector change.
10530 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10532 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10534 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10535 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10536 Remove unused local.
10537 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10539 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10540 GCC 4.6.0 optimizes based on type-based alias analysis.
10541 For example, if b is of type struct buffer * and v of type struct
10542 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10543 != &v->size, and therefore "v->size = 1; b->size = 2; return
10544 v->size;" must therefore return 1. This assumption is incorrect
10545 for Emacs, since it type-puns struct Lisp_Vector * with many other
10546 types. To fix this problem, this patch adds a new type struct
10547 vectorlike_header that documents the constraints on layout of vectors
10548 and pseudovectors, and helps optimizing compilers not get fooled
10549 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10550 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10551 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10553 (XSETPVECTYPE): Rewrite in terms of new macro.
10554 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10555 This is a bit clearer, and further avoids the possibility of
10556 undesirable aliasing.
10557 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10558 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10559 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10560 since Lisp_Subr is a special case (no "next" field).
10561 (ASIZE): Now uses header.size rather than size.
10562 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10563 to avoid the hassle of writing XVECTOR (foo)->header.size.
10564 (struct vectorlike_header): New type.
10565 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10566 object, to help avoid aliasing.
10567 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10568 (SUBRP): Likewise, since Lisp_Subr is a special case.
10569 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10570 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10571 (struct Lisp_Hash_Table): Combine first two members into a single
10572 struct vectorlike_header member. All uses of "size" and "next" members
10573 changed to be "header.size" and "header.next".
10574 * buffer.h (struct buffer): Likewise.
10575 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10576 * frame.h (struct frame): Likewise.
10577 * process.h (struct Lisp_Process): Likewise.
10578 * termhooks.h (struct terminal): Likewise.
10579 * window.c (struct save_window_data, struct saved_window): Likewise.
10580 * window.h (struct window): Likewise.
10581 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10582 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10583 * buffer.c (init_buffer_once): Likewise.
10584 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10586 * process.c (Fformat_network_address): Use local var for size,
10589 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10591 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10592 * data.c (atof): Remove decl; no longer used or needed.
10593 (digit_to_number): Move to lread.c.
10594 (Fstring_to_number): Use new string_to_number function, to be
10595 consistent with how the Lisp reader treats infinities and NaNs.
10596 Do not assume that floating-point numbers represent EMACS_INT
10597 without losing information; this is not true on most 64-bit hosts.
10598 Avoid double-rounding errors, by insisting on integers when
10599 parsing non-base-10 numbers, as the documentation specifies.
10600 * lisp.h (string_to_number): New decl, replacing ...
10601 (isfloat_string): Remove.
10602 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10603 (read1): Do not accept +. and -. as integers; this
10604 appears to have been a coding error. Similarly, do not accept
10605 strings like +-1e0 as floating point numbers. Do not report
10606 overflow for integer overflows unless the base is not 10 which
10607 means we have no simple and reliable way to continue.
10608 Break out the floating-point parsing into a new
10609 function string_to_number, so that Fstring_to_number parses
10610 floating point numbers consistently with the Lisp reader.
10611 (digit_to_number): Move here from data.c. Make it static inline.
10612 (E_CHAR, EXP_INT): Remove, replacing with ...
10613 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10614 (string_to_number): New function, replacing isfloat_string.
10615 This function checks for valid syntax and produces the resulting
10616 Lisp float number too. Rework it so that string-to-number
10617 no longer mishandles examples like "1.0e+". Use strtoumax,
10618 so that overflow for non-base-10 numbers is reported only when
10619 there's no portable and simple way to convert to floating point.
10621 * textprop.c (set_text_properties_1): Rewrite for clarity,
10622 and to avoid GCC warning about integer overflow.
10624 * intervals.h (struct interval): Use EMACS_INT for members
10625 where EMACS_UINT might cause problems. See
10626 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10627 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10628 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10630 (offset_intervals): Tell GCC not to worry about length overflow
10631 when negating a negative length.
10633 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10634 (overrun_check_free): Likewise.
10636 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10637 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10640 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10641 (gnutls_make_error): Rename local to avoid shadowing.
10642 (gnutls_emacs_global_deinit): ifdef out; not used.
10643 (Fgnutls_boot): Use const for pointer to readonly storage.
10644 Comment out unused local. Fix pointer signedness problems.
10646 * lread.c (openp): Don't stuff size_t into an 'int'.
10647 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10648 about possible signed overflow.
10650 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10651 (GDK_KEY_g): Don't define if already defined.
10652 (xg_prepare_tooltip): Avoid pointer signedness problem.
10653 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10655 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10656 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10658 * xfns.c (Fx_window_property): Simplify a bit,
10659 to make a bit faster and to avoid GCC 4.6.0 warning.
10660 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10662 * fns.c (internal_equal): Don't assume size_t fits in int.
10664 * alloc.c (compact_small_strings): Tighten assertion a little.
10666 Replace pEd with more-general pI, and fix some printf arg casts.
10667 * lisp.h (pI): New macro, generalizing old pEd macro to other
10668 conversion specifiers. For example, use "...%"pI"d..." rather
10669 than "...%"pEd"...".
10670 (pEd): Remove. All uses replaced with similar uses of pI.
10671 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10672 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10673 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10674 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10675 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10676 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10677 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10679 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10680 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10681 * print.c (safe_debug_print, print_object): Likewise.
10682 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10684 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10685 avoiding the 0 flag, which is not portable.
10686 * process.c (Fmake_network_process): Use pI to avoid cast.
10687 * region-cache.c (pp_cache): Likewise.
10688 * xdisp.c (decode_mode_spec): Likewise.
10689 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10690 behavior on 64-bit hosts with printf arg.
10691 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10692 (x_stop_queuing_selection_requests): Likewise.
10693 (x_get_window_property): Don't truncate byte count to an 'int'
10696 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10697 here, since it parses constructs like leading '-' and spaces,
10698 which are not wanted; and it overflows with large numbers.
10699 Instead, simply match F[0-9]+, which is what is wanted anyway.
10701 * alloc.c: Remove unportable assumptions about struct layout.
10702 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10703 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10704 (allocate_vectorlike, make_pure_vector): Use the new macros,
10705 plus offsetof, to remove unportable assumptions about struct layout.
10706 These assumptions hold on all porting targets that I know of, but
10707 they are not guaranteed, they're easy to remove, and removing them
10708 makes further changes easier.
10710 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10711 This doesn't fix a bug but makes the code clearer.
10712 (string_overrun_cookie): Now const. Use initializers that
10713 don't formally overflow signed char, to avoid warnings.
10714 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10715 can cause Emacs to crash when string overrun checking is enabled.
10716 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10717 multiple of sizeof (EMACS_INT); it need not be, if
10718 alignof(EMACS_INT) < sizeof (EMACS_INT).
10719 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10721 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10723 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10725 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10727 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10728 supposed to be handshaking. (Bug#8556)
10729 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10731 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10733 * lisp.h (Qdebug): List symbol.
10734 * eval.c (Qdebug): Restore global linkage.
10735 * keyboard.c (debug-on-event): New variable.
10736 (handle_user_signal): Break into debugger when debug-on-event
10737 matches the current signal symbol.
10739 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10741 * alloc.c (check_sblock, check_string_bytes)
10742 (check_string_free_list): Convert to standard C.
10744 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10746 * w32.c (emacs_gnutls_push): Fix typo.
10748 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10750 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10751 "cast to pointer from integer of different size".
10753 Improve doprnt and its use in verror. (Bug#8545)
10754 * doprnt.c (doprnt): Document the set of format control sequences
10755 supported by the function. Use SAFE_ALLOCA instead of always
10758 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10759 is one byte too soon. Don't use xrealloc; instead xfree and
10762 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10764 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10767 * gnutls.c: Renamed global_initialized to
10768 gnutls_global_initialized. Added internals for the
10769 :verify-hostname-error, :verify-error, and :verify-flags
10770 parameters of `gnutls-boot' and documented those parameters in the
10771 docstring. Start callback support.
10772 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10773 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10774 on error. Return error code.
10775 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10776 (emacs_gnutls_read): Likewise.
10777 (Fgnutls_boot): Return handshake error code.
10778 (emacs_gnutls_handle_error): New function.
10779 (wsaerror_to_errno): Likewise.
10781 * w32.h (emacs_gnutls_pull): Add prototype.
10782 (emacs_gnutls_push): Likewise.
10784 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10785 (emacs_gnutls_push): Likewise.
10787 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10789 * process.c (wait_reading_process_output): Check if GnuTLS
10790 buffered some data internally if no FDs are set for TLS
10793 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10794 (LIBS): Link to USER_LIBS.
10795 ($(BLD)/gnutls.$(0)): New target.
10797 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10799 * xdisp.c (handle_single_display_spec): Rename the
10800 display_replaced_before_p argument into display_replaced_p, to
10801 make it consistent with the commentary. Fix typos in the
10804 * textprop.c (syms_of_textprop): Remove dead code.
10805 (copy_text_properties): Delete obsolete commentary about an
10806 interface that was deleted long ago. Fix typos in the description
10809 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10810 to changes in oldXMenu/XMenu.h from 2011-04-16.
10811 <menu_help_message, prev_menu_help_message>: Constify.
10812 (IT_menu_make_room): menu->help_text is now `const char **';
10815 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10816 to changes in oldXMenu/XMenu.h from 2011-04-16.
10817 (struct XMenu): Declare `help_text' `const char **'.
10819 * xfaces.c <Qunspecified>: Make extern again.
10821 * syntax.c: Include sys/types.h before including regex.h, as
10824 * doc.c (get_doc_string): Improve the format passed to `error'.
10826 * doprnt.c (doprnt): Improve commentary.
10828 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10830 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10833 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10834 changes in globals.h immediately force recompilation.
10835 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10836 $(CURDIR)/s/ms-w32.h.
10837 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10839 * character.c (Fchar_direction): Function deleted.
10840 (syms_of_character): Don't defsubr it.
10841 <char-direction-table>: Deleted.
10843 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10845 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10846 * doprnt.c: Include limits.h.
10847 (SIZE_MAX): New macro.
10848 (doprnt): Return a size_t value. 2nd arg is now size_t.
10849 Many local variables are now size_t instead of int or unsigned.
10850 Improve overflow protection. Support `l' modifier for integer
10851 conversions. Support %l conversion. Don't assume an EMACS_INT
10852 argument for integer conversions and for %c.
10854 * lisp.h (doprnt): Restore prototype.
10856 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10857 $(SRC)/character.h.
10859 * Makefile.in (base_obj): Add back doprnt.o.
10861 * deps.mk (doprnt.o): Add back prerequisites.
10862 (callint.o): Depend on character.h.
10864 * eval.c (internal_lisp_condition_case): Include the handler
10865 representation in the error message.
10866 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10867 when breaking from the loop.
10869 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10871 * callint.c (Fcall_interactively): When displaying error message
10872 about invalid control letter, pass the character's codepoint, not
10873 a pointer to its multibyte form. Improve display of the character
10874 in octal and display also its hex code.
10876 * character.c (char_string): Use %x to display the (unsigned)
10877 codepoint of an invalid character, to avoid displaying a bogus
10880 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10881 `error', not SYMBOL_NAME itself.
10883 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10884 character arguments to `error'.
10886 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10887 to `error' in error message about FINAL_CHAR argument. Make sure
10888 FINAL_CHAR is a character, and use %c when it is passed as
10889 argument to `error'.
10891 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10893 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10895 * w32.c: Include <time.h>.
10896 (sys_localtime): New function.
10898 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10900 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10902 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10904 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10906 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10907 zombies (Bug#8467).
10909 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10911 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10912 gl_state.e_property when gl_state.object is Qt.
10914 * insdel.c (make_gap_larger): Remove limitation of buffer size
10917 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10919 * xdisp.c (lookup_glyphless_char_display)
10920 (produce_glyphless_glyph): Handle cons cell entry in
10921 glyphless-char-display.
10922 (Vglyphless_char_display): Document it.
10924 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10925 glyphless-char-display.
10927 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10929 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10931 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10933 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10934 definition for no-X builds.
10936 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10938 Static checks with GCC 4.6.0 and non-default toolkits.
10940 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10942 * process.c (keyboard_bit_set): Define only if SIGIO.
10943 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10944 (send_process): Repair possible setjmp clobbering.
10946 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10948 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10950 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10952 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10953 Define only if needed.
10955 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10956 by pacifying GCC about it. Maybe it's time to retire it?
10957 * xfaces.c (USG, __TIMEVAL__): Likewise.
10959 * dispextern.h (struct redisplay_interface): Rename param
10960 to avoid shadowing.
10961 * termhooks.h (struct terminal): Likewise.
10962 * xterm.c (xembed_send_message): Likewise.
10964 * insdel.c (make_gap_smaller): Define only if
10965 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10967 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10970 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10971 so that we aren't warned about unused symbols.
10973 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10975 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10977 * xfns.c (x_real_positions): Mark locals as initialized.
10979 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10981 * xterm.c: Fix problems found by static analysis with other toolkits.
10982 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10983 (x_dispatch_event): Declare static if USE_GTK, and
10984 define if USE_GTK || USE_X_TOOLKIT.
10985 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10986 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10987 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10988 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10990 * xmenu.c (menu_help_callback): Pointer type fixes.
10991 Use const pointers when pointing at readonly data. Avoid pointer
10992 signedness clashes.
10993 (FALSE): Remove unused macro.
10994 (update_frame_menubar): Remove unused decl.
10996 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10998 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10999 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11000 (single_menu_item): Rename local to avoid shadowing.
11002 * keyboard.c (make_lispy_event): Remove unused local var.
11004 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11005 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11007 * bitmaps: Change bitmaps from unsigned char back to the X11
11008 compatible char. Avoid the old compiler warnings about
11009 out-of-range initializers by using, for example, '\xab' rather
11012 * xgselect.c (xgselect_initialize): Check vs interface
11013 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11015 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11017 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11018 to read-only memory.
11020 * fns.c (vector): Remove; this old hack is no longer needed.
11022 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11024 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11026 * xrdb.c (x_load_resources): Omit unused local.
11028 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11029 (x_window): Rename locals to avoid shadowing.
11030 (USG): Use the kludged USG macro, to pacify gcc.
11032 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11033 (x_term_init): Remove local to avoid shadowing.
11035 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11037 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11038 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11040 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11042 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11044 Fix regex.c, syntax.c and friends for buffers > 2GB.
11045 * syntax.h (struct gl_state_s): Declare character position members
11048 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11050 * textprop.c (verify_interval_modification, interval_of):
11051 Declare arguments EMACS_INT.
11053 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11056 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11058 * indent.c (Fvertical_motion): Local variable it_start is now
11061 * regex.c (re_match, re_match_2, re_match_2_internal)
11062 (bcmp_translate, regcomp, regexec, print_double_string)
11063 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11064 (re_compile_pattern, re_exec): Declare arguments and local
11065 variables `size_t' and `ssize_t' and return values `regoff_t', as
11067 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11068 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11069 <compile_stack_type>: `size' and `avail' are now `size_t'.
11071 * regex.h <regoff_t>: Use ssize_t, not int.
11072 (re_search, re_search_2, re_match, re_match_2): Arguments that
11073 specify buffer/string position and length are now ssize_t and
11074 size_t. Return type is regoff_t.
11076 2011-04-16 Ben Key <bkey76@gmail.com>
11078 * nsfont.m: Fixed bugs in ns_get_family and
11079 ns_descriptor_to_entity that were caused by using free to
11080 deallocate memory blocks that were allocated by xmalloc (via
11081 xstrdup). This caused Emacs to crash when compiled with
11082 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11083 --enable-checking=xmallocoverrun). xfree is now used to
11084 deallocate these memory blocks.
11086 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11088 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11090 emacs_write: Accept and return EMACS_INT for sizes.
11091 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11093 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11094 Accept and return EMACS_INT.
11095 (emacs_gnutls_write): Return the number of bytes written on
11097 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11098 (emacs_read, emacs_write): Remove check for negative size, as the
11099 Emacs source code has been audited now.
11100 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11101 (emacs_read, emacs_write): Use it.
11102 * process.c (send_process): Adjust to the new signatures of
11103 emacs_write and emacs_gnutls_write. Do not attempt to store
11104 a byte offset into an 'int'; it might overflow.
11105 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11107 * sound.c: Don't assume sizes fit in 'int'.
11108 (struct sound_device.period_size, alsa_period_size):
11109 Return EMACS_INT, not int.
11110 (struct sound_device.write, vox_write, alsa_write):
11111 Accept EMACS_INT, not int.
11112 (wav_play, au_play): Use EMACS_INT to store sizes and to
11113 record read return values.
11115 2011-04-15 Ben Key <bkey76@gmail.com>
11117 * keyboard.c (Qundefined): Don't declare static since it is used
11119 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11120 static since they are used in nsfont.m.
11122 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11124 * process.c (Qprocessp): Don't declare static.
11125 * lisp.h (Qprocessp): Declare again.
11127 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11129 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11131 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11133 Improve C-level modularity by making more things 'static'.
11135 Don't publish debugger-only interfaces to other modules.
11136 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11137 (verify_bytepos, count_markers): Move decls to the only modules
11139 * region-cache.h (pp_cache): Likewise.
11140 * window.h (check_all_windows): Likewise.
11141 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11143 * sysdep.c (croak): Now static, if
11144 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11145 * syssignal.h (croak): Declare only if not static.
11147 * alloc.c (refill_memory_reserve): Now static if
11148 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11149 * lisp.h (refill_memory_reserve): Declare only if not static.
11151 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11152 Define only if USE_LUCID.
11154 * xrdb.c (x_customization_string, x_rm_string): Now static.
11156 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11157 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11159 * xdisp.c (draw_row_with_mouse_face): Now static.
11160 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11162 * window.h (check_all_windows): Mark externally visible.
11164 * window.c (window_deletion_count): Now static.
11166 * undo.c: Make symbols static if they're not exported.
11167 (last_undo_buffer, last_boundary_position, pending_boundary):
11170 * textprop.c (interval_insert_behind_hooks): Now static.
11171 (interval_insert_in_front_hooks): Likewise.
11173 * term.c: Make symbols static if they're not exported.
11174 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11175 (max_frame_lines, tty_set_terminal_modes):
11176 (tty_reset_terminal_modes, tty_turn_off_highlight):
11177 (get_tty_terminal): Now static.
11178 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11179 * termhooks.h (term_mouse_moveto): Do not declare if
11180 HAVE_WINDOW_SYSTEM.
11181 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11182 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11184 * sysdep.c: Make symbols static if they're not exported.
11185 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11187 (sigprocmask_set, full_mask): Remove; unused.
11188 (wait_debugging): Mark as visible.
11189 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11190 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11192 * syntax.c (syntax_temp): Define only if !__GNUC__.
11194 * sound.c (current_sound_device, current_sound): Now static.
11196 * search.c (searchbufs, searchbuf_head): Now static.
11198 * scroll.c (scroll_cost): Remove; unused.
11199 * dispextern.h (scroll_cost): Remove decl.
11201 * region-cache.h (pp_cache): Mark as externally visible.
11203 * process.c: Make symbols static if they're not exported.
11204 (process_tick, update_tick, create_process, chan_process):
11205 (Vprocess_alist, proc_buffered_char, datagram_access):
11206 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11207 (deactivate_process): Mark defn as static, as well as decl.
11208 * lisp.h (create_process): Remove decl.
11209 * process.h (chan_process, Vprocess_alist): Remove decls.
11211 * print.c: Make symbols static if they're not exported.
11212 (print_depth, new_backquote_output, being_printed, print_buffer):
11213 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11214 (print_interval, print_number_index, initial_stderr_stream):
11216 * lisp.h (Fprinc): Remove decl.
11217 (debug_output_compilation_hack): Mark as externally visible.
11219 * sysdep.c (croak): Move decl from here to syssignal.h.
11220 * syssignal.h (croak): Put it here, so the API can be checked when
11221 'croak' is called from dissociate_if_controlling_tty.
11223 * minibuf.c: Make symbols static if they're not exported.
11224 (minibuf_save_list, choose_minibuf_frame): Now static.
11225 * lisp.h (choose_minibuf_frame): Remove decl.
11227 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11229 * lread.c: Make symbols static if they're not exported.
11230 (read_objects, initial_obarray, oblookup_last_bucket_number):
11232 (make_symbol): Remove; unused.
11233 * lisp.h (initial_obarray, make_symbol): Remove decls.
11235 * keyboard.c: Make symbols static if they're not exported.
11236 (single_kboard, recent_keys_index, total_keys, recent_keys):
11237 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11238 (this_single_command_key_start, echoing, last_auto_save):
11239 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11240 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11241 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11242 (Vlispy_mouse_stem, double_click_count):
11244 (force_auto_save_soon): Define only if SIGDANGER.
11245 (ignore_mouse_drag_p): Now static if
11246 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11247 (print_help): Remove; unused.
11248 (stop_character, last_timer_event): Mark as externally visible.
11249 * keyboard.h (ignore_mouse_drag_p): Declare only if
11250 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11251 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11252 * lisp.h (echoing): Remove decl.
11253 (force_auto_save_soon): Declare only if SIGDANGER.
11254 * xdisp.c (redisplay_window): Simplify code, to make it more
11255 obvious that ignore_mouse_drag_p is not accessed if !defined
11256 USE_GTK && !defined HAVE_NS.
11258 * intervals.c: Make symbols static if they're not exported.
11259 (merge_properties_sticky, merge_interval_right, delete_interval):
11261 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11263 * insdel.c: Make symbols static if they're not exported.
11264 However, leave prepare_to_modify_buffer alone. It's never
11265 called from outside this function, but that appears to be a bug.
11266 (combine_after_change_list, combine_after_change_buffer):
11267 (adjust_after_replace, signal_before_change): Now static.
11268 (adjust_after_replace_noundo): Remove; unused.
11269 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11270 (signal_before_change): Remove decls.
11272 * indent.c (val_compute_motion, val_vmotion): Now static.
11274 * image.c: Make symbols static if they're not exported.
11275 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11277 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11278 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11280 * fringe.c (standard_bitmaps): Now static.
11281 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11283 * frame.c: Make symbols static if they're not exported.
11284 (x_report_frame_params, make_terminal_frame): Now static.
11285 (get_frame_param): Now static, unless HAVE_NS.
11286 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11287 (x_get_resource_string): Remove; not used.
11288 * frame.h (make_terminal_frame, x_report_frame_params):
11289 (x_get_resource_string); Remove decls.
11290 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11291 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11293 * font.c, fontset.c: Make symbols static if they're not exported.
11294 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11295 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11296 * font.c (font_close_object): Now static.
11297 * font.h (font_close_object): Remove.
11298 * fontset.c (FONTSET_OBJLIST): Remove.
11299 (free_realized_fontset) #if-0 the body, which does nothing.
11300 (face_suitable_for_char_p): #if-0, as it's never called.
11301 * fontset.h (face_suitable_for_char_p): Remove decl.
11302 * xfaces.c (face_at_string_position):
11303 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11304 since 0 is always ASCII.
11306 * fns.c (weak_hash_tables): Now static.
11308 * fileio.c: Make symbols static if they're not exported.
11309 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11310 (Vwrite_region_annotation_buffers): Now static.
11312 * eval.c: Make symbols static if they're not exported.
11313 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11314 * lisp.h (backtrace_list): Remove decl.
11316 * emacs.c: Make symbols static if they're not exported.
11317 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11318 (fatal_error_code, fatal_error_signal_hook, standard_args):
11320 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11321 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11322 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11323 * lisp.h (fatal_error_signal_hook): Remove decl.
11324 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11326 * editfns.c: Move a (normally-unused) function to its only use.
11327 * editfns.c, lisp.h (get_operating_system_release): Remove.
11328 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11329 worth the hassle of breaking this out.
11331 * xterm.c: Make symbols static if they're not exported.
11332 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11333 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11334 (x_destroy_window, x_delete_display):
11336 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11337 (x_mouse_leave): Remove; unused.
11338 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11339 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11340 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11342 (x_mouse_leave): Declare only if WINDOWSNT.
11343 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11344 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11347 * ftxfont.c: Make symbols static if they're not exported.
11348 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11350 * font.h (ftxfont_driver): Likewise.
11352 * xfns.c: Make symbols static if they're not exported.
11353 (x_last_font_name, x_display_info_for_name):
11354 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11355 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11356 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11357 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11358 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11359 (last_show_tip_args): Now static.
11360 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11361 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11362 (x_screen_planes): Remove; unused.
11363 * dispextern.h (x_screen_planes): Remove decl.
11365 * dispnew.c: Make symbols static if they're not exported.
11366 * dispextern.h (redraw_garbaged_frames, scrolling):
11367 (increment_row_positions): Remove.
11368 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11369 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11371 (redraw_garbaged_frames): Remove; unused.
11373 * xfaces.c: Make symbols static if they're not exported.
11374 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11376 * xterm.h (defined_color): Remove decls.
11377 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11378 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11379 (menu_face_changed_default, defined_color, free_realized_face):
11380 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11381 (ascii_face_of_lisp_face): Remove; unused.
11383 * xdisp.c: Make symbols static if they're not exported.
11384 * dispextern.h (scratch_glyph_row, window_box_edges):
11385 (glyph_to_pixel_coords, set_cursor_from_row):
11386 (get_next_display_element, set_iterator_to_next):
11387 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11388 (show_mouse_face): Remove decls
11389 * frame.h (message_buf_print): Likewise.
11390 * lisp.h (pop_message, set_message, check_point_in_composition):
11392 * xterm.h (set_vertical_scroll_bar): Likewise.
11393 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11394 (message_buf_print, scratch_glyph_row, displayed_buffer):
11395 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11396 (get_next_display_element, show_mouse_face, window_box_edges):
11397 (frame_to_window_pixel_xy, check_point_in_composition):
11398 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11399 (glyph_to_pixel_coords): Remove; unused.
11401 * dired.c (file_name_completion): Now static.
11403 * dbusbind.c (xd_in_read_queued_messages): Now static.
11405 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11406 * data.c (circular_list_error): Remove.
11408 * commands.h (last_point_position, last_point_position_buffer):
11409 (last_point_position_window): Remove decls.
11410 * keyboard.c: Make these variables static.
11412 * coding.h (coding, code_convert_region, encode_coding_gap):
11414 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11415 (iso_code_class, detect_coding, code_convert_region): Now static.
11416 (encode_coding_gap): Remove; unused.
11418 * chartab.c (chartab_chars, chartab_bits): Now static.
11420 * charset.h (charset_iso_8859_1): Remove decl.
11421 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11424 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11425 * ccl.c (Vccl_program_table): Now static.
11426 (check_ccl_update): Remove; unused.
11428 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11429 * category.h: ... from here.
11430 * category.c (check_category_table, set_category_set): Now static.
11432 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11433 * lisp.h: Remove these decls.
11435 * buffer.c (buffer_count): Remove unused var.
11437 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11438 so that it's not optimized away.
11439 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11440 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11441 exported only to the debugger.
11443 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11444 * atimer.h (run_all_atimers): Remove; not exported.
11446 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11447 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11448 was inaccessible from Lisp.
11449 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11450 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11452 alloc.c: Import and export fewer symbols, and remove unused items.
11453 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11455 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11456 it's not optimized away by whole-program optimization.
11457 (message_enable_multibyte, free_misc): Remove.
11458 (catchlist, handlerlist, mark_backtrace):
11459 Declare only if BYTE_MARK_STACK.
11460 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11461 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11462 (message_enable_multibyte): Remove decl.
11463 (free_misc, interval_free_list, float_block, float_block_index):
11464 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11465 (cons_free_list, last_marked_index):
11467 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11468 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11469 (mark_backtrace): Define only if BYTE_MARK_STACK.
11470 * xdisp.c (message_enable_multibyte): Now static.
11472 Declare Lisp_Object Q* variables to be 'static' if not exported.
11473 This makes it easier for human readers (and static analyzers)
11474 to see whether these variables are used from other modules.
11475 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11476 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11477 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11478 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11479 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11480 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11481 * xmenu.c, xselect.c:
11482 Declare Q* vars static if they are not used in other modules.
11483 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11484 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11485 Remove decls of unexported vars.
11486 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11488 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11490 Make Emacs functions such as Fatom 'static' by default.
11491 This makes it easier for human readers (and static analyzers)
11492 to see whether these functions can be called from other modules.
11493 DEFUN now defines a static function. To make the function external
11494 so that it can be used in other C modules, use the new macro DEFUE.
11495 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11496 (Finit_image_library):
11497 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11498 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11499 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11500 Remove decls, since these functions are now static.
11501 (Funintern, Fget_internal_run_time): New decls, since these functions
11502 were already external.
11504 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11505 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11506 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11507 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11508 * keyboard.c, keymap.c, lread.c:
11509 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11510 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11511 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11512 Mark functions with DEFUE instead of DEFUN,
11513 if they are used in other modules.
11514 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11515 decls for now-static functions.
11516 * buffer.h (Fdelete_overlay): Remove decl.
11517 * callproc.c (Fgetenv_internal): Mark as internal.
11518 * composite.c (Fremove_list_of_text_properties): Remove decl.
11519 (Fcomposition_get_gstring): New forward static decl.
11520 * composite.h (Fcomposite_get_gstring): Remove decl.
11521 * dired.c (Ffile_attributes): New forward static decl.
11522 * doc.c (Fdocumntation_property): New forward static decl.
11523 * eval.c (Ffetch_bytecode): New forward static decl.
11524 (Funintern): Remove extern decl; now in .h file where it belongs.
11525 * fileio.c (Fmake_symbolic_link): New forward static decl.
11526 * image.c (Finit_image_library): New forward static decl.
11527 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11528 * intervals.h (Fprevious_property_change):
11529 (Fremove_list_of_text_properties): Remove decls.
11530 * keyboard.c (Fthis_command_keys): Remove decl.
11531 (Fcommand_execute): New forward static decl.
11532 * keymap.c (Flookup_key): New forward static decl.
11533 (Fcopy_keymap): Now static.
11534 * keymap.h (Flookup_key): Remove decl.
11535 * process.c (Fget_process): New forward static decl.
11536 (Fprocess_datagram_address): Mark as internal.
11537 * syntax.c (Fsyntax_table_p): New forward static decl.
11538 (skip_chars): Remove duplicate decl.
11539 * textprop.c (Fprevious_property_change): New forward static decl.
11540 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11542 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11543 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11545 * editfns.c (Fformat): Remove unreachable code.
11547 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11549 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11552 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11554 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11555 when at ZV. (Bug#8487)
11557 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11559 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11561 * keyboard.c (parse_tool_bar_item): Likewise.
11562 * sound.c (sound_cleanup, alsa_close): Likewise.
11563 * termcap.c (tgetent): Likewise.
11564 * xfns.c (x_default_font_parameter): Likewise.
11565 * xsettings.c (read_and_apply_settings): Likewise.
11567 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11568 (overrun_check_free): Protoize.
11570 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11572 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11573 since callers should never pass a negative size.
11574 Change the signature to match that of plain 'read' and 'write'; see
11575 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11576 * lisp.h: Update prototypes of emacs_write and emacs_read.
11578 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11580 * xdisp.c (redisplay_window): Don't try to determine the character
11581 position of the scroll margin if the window start point w->startp
11582 is outside the buffer's accessible region. (Bug#8468)
11584 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11586 Fix write-region and its subroutines for buffers > 2GB.
11587 * fileio.c (a_write, e_write): Modify declaration of arguments and
11588 local variables to support buffers larger than 2GB.
11589 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11591 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11592 argument, local variables, and return value.
11594 * lisp.h: Update prototypes of emacs_write and emacs_read.
11596 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11598 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11600 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11602 Fix more problems found by GCC 4.6.0's static checks.
11604 * xdisp.c (vmessage): Use a better test for character truncation.
11606 * charset.c (load_charset_map): <, not <=, for optimization,
11607 and to avoid potential problems with integer overflow.
11608 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11609 * casetab.c (set_identity, shuffle): Likewise.
11610 * editfns.c (Fformat): Likewise.
11611 * syntax.c (skip_chars): Likewise.
11613 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11614 This also lets GCC 4.6.0 generate slightly better loop code.
11616 * callint.c (Fcall_interactively): <, not <=, for optimization.
11617 (Fcall_interactively): Count the number of arguments produced,
11618 not the number of arguments given. This is simpler and lets GCC
11619 4.6.0 generate slightly better code.
11621 * ftfont.c: Distingish more carefully between FcChar8 and char.
11622 The previous code passed unsigned char * to a functions like
11623 strlen and xstrcasecmp that expect char *, which does not
11624 conform to the C standard.
11625 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11626 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11627 char * when the C standard requires it.
11629 * keyboard.c (read_char): Remove unused var.
11631 * eval.c: Port to Windows vsnprintf (Bug#8435).
11632 Include <limits.h>.
11633 (SIZE_MAX): Define if the headers do not.
11634 (verror): Do not give up if vsnprintf returns a negative count.
11635 Instead, grow the buffer. This ports to Windows vsnprintf, which
11636 does not conform to C99. Problem reported by Eli Zaretskii.
11637 Also, simplify the allocation scheme, by avoiding the need for
11638 calling realloc, and removing the ALLOCATED variable.
11640 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11642 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11643 But keep the doprint source code for now, as we might revamp it
11644 and use it again (Bug#8435).
11645 * lisp.h (doprnt): Remove.
11646 * Makefile.in (base_obj): Remove doprnt.o.
11647 * deps.mk (doprnt.o): Remove.
11649 error: Print 32- and 64-bit integers portably (Bug#8435).
11650 Without this change, on typical 64-bit hosts error ("...%d...", N)
11651 was used to print both 32- and 64-bit integers N, which relied on
11652 undefined behavior.
11653 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11654 * lisp.h (error, verror): Mark as printf-like functions.
11655 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11656 Report overflow in size calculations when allocating printf buffer.
11657 Do not truncate output string at its first null byte.
11658 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11659 Truncate the output at a character boundary, since vsnprintf does not
11661 * charset.c (check_iso_charset_parameter): Convert internal
11662 character to string before calling 'error', since %c now has the
11664 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11665 overflow when computing char to be passed to 'error'. Do not
11666 pass Lisp_Object to 'error'; pass the integer instead.
11667 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11668 formatted with plain %d.
11670 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11672 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11674 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11676 * xterm.c (x_catch_errors): Remove duplicate declaration.
11678 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11680 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11682 2011-04-10 Jim Meyering <meyering@redhat.com>
11684 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11685 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11686 return ssize_t not "int", and use size_t as the buffer length.
11687 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11688 * gnutls.h: Update declarations.
11689 * process.c (read_process_output): Use ssize_t, to match.
11690 (send_process): Likewise.
11692 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11694 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11696 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11698 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11699 Use unsigned char, to match FcChar8 type definition.
11701 * xterm.c (handle_one_xevent):
11702 * xmenu.c (create_and_show_popup_menu):
11703 * xselect.c (x_decline_selection_request)
11704 (x_reply_selection_request): Avoid type-punned deref of X events.
11706 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11708 Fix some uses of `int' instead of EMACS_INT.
11709 * search.c (string_match_1, fast_string_match)
11710 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11711 (scan_buffer, find_next_newline_no_quit)
11712 (find_before_next_newline, search_command, Freplace_match)
11713 (Fmatch_data): Make some `int' variables be EMACS_INT.
11715 * xdisp.c (display_count_lines): 3rd argument and return value now
11716 EMACS_INT. All callers changed.
11717 (pint2hrstr): Last argument is now EMACS_INT.
11719 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11720 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11721 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11722 (decode_coding_utf_16, decode_coding_emacs_mule)
11723 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11724 (decode_coding_ccl, decode_coding_charset)
11725 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11726 (decode_coding_iso_2022, decode_coding_emacs_mule)
11727 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11728 <char_offset, last_offset>: Declare EMACS_INT.
11729 (encode_coding_utf_8, encode_coding_utf_16)
11730 (encode_coding_emacs_mule, encode_invocation_designation)
11731 (encode_designation_at_bol, encode_coding_iso_2022)
11732 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11733 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11735 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11736 (encode_invocation_designation): Last argument P_NCHARS is now
11738 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11739 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11741 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11744 * ccl.c (Fccl_execute_on_string): Declare some variables
11747 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11749 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11751 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11753 * process.c (Fformat_network_address): Doc fix.
11755 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11757 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11759 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11761 * keyboard.c (read_char): Call Lisp function help-form-show,
11762 instead of using internal_with_output_to_temp_buffer.
11763 (Qhelp_form_show): New var.
11764 (syms_of_keyboard): Use DEFSYM macro.
11766 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11768 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11770 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11772 * process.c (Flist_processes): Remove to Lisp.
11773 (list_processes_1): Delete.
11775 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11777 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11779 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11781 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11783 Fix more problems found by GCC 4.6.0's static checks.
11785 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11787 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11789 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11791 * xdisp.c (vmessage): Mark as a printf-like function.
11793 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11795 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11797 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11798 printf-like functions.
11799 (tiff_load): Add casts to remove these marks before passing them
11800 to system-supplied API.
11802 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11804 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11805 This avoids several warnings with gcc -Wstrict-overflow.
11806 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11807 directly, rather than having caller test rule sign. This avoids
11808 some unnecessary tests.
11809 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11810 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11811 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11813 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11814 (xfont_open): Avoid unnecessary tests.
11816 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11818 * composite.h, composite.c (composition_gstring_put_cache):
11819 Use EMACS_INT, not int, for length.
11821 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11822 breaking out part of COMPOSITION_DECODE_RULE.
11823 (COMPOSITION_DECODE_RULE): Use it.
11824 * composite.c (get_composition_id): Remove unused local vars,
11825 by using the new macro.
11827 * textprop.c (set_text_properties_1): Change while to do-while,
11828 since the condition is always true at first.
11830 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11831 (interval_deletion_adjustment): Return unsigned value.
11834 * process.c (list_processes_1, create_pty, read_process_output):
11835 (exec_sentinel): Remove vars that were set but not used.
11836 (create_pty): Remove unnecessary "volatile"s.
11837 (Fnetwork_interface_info): Avoid possibility of int overflow.
11838 (read_process_output): Do adaptive read buffering even if carryover.
11839 (read_process_output): Simplify nbytes computation if buffered.
11841 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11843 * syntax.c (scan_words): Remove var that was set but not used.
11844 (update_syntax_table): Use unsigned instead of int.
11846 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11847 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11848 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11850 * print.c (print_error_message): Avoid int overflow.
11852 * font.c (font_list_entities): Redo for clarity,
11853 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11855 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11856 (font_score): Avoid potential overflow in diff calculation.
11858 * fns.c (substring_both): Remove var that is set but not used.
11859 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11861 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11863 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11864 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11865 can always succeed if overflow has undefined behavior.
11867 * search.c (boyer_moore, wordify): Remove vars set but not used.
11868 (wordify): Omit three unnecessary tests.
11870 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11871 All callers changed. This avoids the need for an unused var.
11873 * casefiddle.c (casify_region): Remove var that is set but not used.
11875 * dired.c (file_name_completion): Remove var that is set but not used.
11877 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11879 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11880 (Finsert_file_contents): Remove unnecessary code checking fd.
11882 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11883 Check for integer overflow on size calculations.
11885 * buffer.c (Fprevious_overlay_change): Remove var that is set
11888 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11889 Remove vars that are set but not used.
11890 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11891 (timer_check_2): Mark vars as initialized.
11893 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11895 * image.c (lookup_image): Remove var that is set but not used.
11896 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11898 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11899 that are set but not used.
11901 * xfns.c (make_invisible_cursor): Don't return garbage
11902 if XCreateBitmapFromData fails (Bug#8410).
11904 * xselect.c (x_get_local_selection, x_handle_property_notify):
11905 Remove vars that are set but not used.
11907 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11908 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11910 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11911 Remove var that is set but not used.
11912 (scroll_bar_windows_size): Now size_t, not int.
11913 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11914 Check for overflow.
11916 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11917 (map_tty_color) [!defined MSDOS]: Likewise.
11919 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11921 * coding.c: Remove vars that are set but not used.
11922 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11923 All callers changed.
11924 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11925 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11926 (decode_coding_charset): Remove vars that are set but not used.
11928 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11929 that is set but not used.
11931 * print.c (print_object): Remove var that is set but not used.
11933 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11934 The gnulib version avoids calling malloc in the usual case,
11935 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11936 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11937 * filelock.c (current_lock_owner): Likewise.
11938 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11939 * sysdep.c: Include allocator.h, careadlinkat.h.
11940 (emacs_no_realloc_allocator): New static constant.
11941 (emacs_readlink): New function.
11942 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11943 ../lib/careadlinkat.h.
11945 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11947 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11948 first non-nil return value).
11950 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11952 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11953 if not defined (Bug#8403).
11955 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11957 * xdisp.c (display_count_lines): Remove parameter `start',
11958 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11959 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11960 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11961 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11962 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11963 and thereabouts. All callers changed.
11964 (get_per_char_metric): Remove parameter `f', unused since
11965 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11967 2011-04-02 Jim Meyering <meyering@redhat.com>
11969 do not dereference NULL upon failed strdup
11970 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11971 (ns_get_family): Likewise.
11973 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11975 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11977 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11979 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11982 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11984 Add lexical binding.
11986 * window.c (Ftemp_output_buffer_show): New fun.
11987 (Fsave_window_excursion):
11988 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11990 * lread.c (lisp_file_lexically_bound_p): New function.
11991 (Fload): Bind Qlexical_binding.
11992 (readevalloop): Remove `evalfun' arg.
11993 Bind Qinternal_interpreter_environment.
11994 (Feval_buffer): Bind Qlexical_binding.
11995 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11997 (syms_of_lread): Declare `lexical-binding'.
11999 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12001 * keyboard.c (eval_dyn): New fun.
12002 (menu_item_eval_property): Use it.
12004 * image.c (parse_image_spec): Use Ffunctionp.
12006 * fns.c (concat, mapcar1): Accept byte-code-functions.
12008 * eval.c (Fsetq): Handle lexical vars.
12009 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12010 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12011 (FletX, Flet): Obey lexical binding.
12012 (Fcommandp): Handle closures.
12013 (Feval): New `lexical' arg.
12014 (eval_sub): New function extracted from Feval. Use it almost
12015 everywhere where Feval was used. Look up vars in lexical env.
12017 (Ffunctionp): Move from subr.el.
12018 (Ffuncall): Handle closures.
12019 (apply_lambda): Remove `eval_flags'.
12020 (funcall_lambda): Handle closures and new byte-code-functions.
12021 (Fspecial_variable_p): New function.
12022 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12023 but without exporting it to Lisp.
12025 * doc.c (Fdocumentation, store_function_docstring):
12026 * data.c (Finteractive_form): Handle closures.
12028 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12031 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12033 (exec_byte_code): New function extracted from Fbyte_code to handle new
12034 calling convention for byte-code-functions. Add new byte-codes.
12036 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12038 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12040 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12042 * xdisp.c (redisplay_internal): Fix prototype.
12044 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12046 * xdisp.c (SCROLL_LIMIT): New macro.
12047 (try_scrolling): Use it when setting scroll_limit.
12048 Limit scrolling to 100 screen lines.
12049 (redisplay_window): Even when falling back on "recentering",
12050 position point in the window according to scroll-conservatively,
12051 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12053 (try_scrolling): When point is above the window, allow searching
12054 as far as scroll_max, or one screenful, to compute vertical
12055 distance from PT to the scroll margin position. This prevents
12056 try_scrolling from unnecessarily failing when
12057 scroll-conservatively is set to a value slightly larger than the
12058 window height. Clean up the case of PT below the margin at bottom
12059 of window: scroll_max can no longer be INT_MAX. When aggressive
12060 scrolling is in use, don't let point enter the opposite scroll
12061 margin as result of the scroll.
12062 (syms_of_xdisp) <scroll-conservatively>: Document the
12063 threshold of 100 lines for never-recentering scrolling.
12065 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12067 * dispextern.h (move_it_by_lines):
12068 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12069 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12070 (message_log_check_duplicate): Remove parameters `prev_bol' and
12071 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12072 (redisplay_internal): Remove parameter `preserve_echo_area',
12073 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12075 * indent.c (Fvertical_motion):
12076 * window.c (window_scroll_pixel_based, Frecenter):
12077 Don't pass `need_y_p' to `move_it_by_lines'.
12079 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12081 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12082 steal a few bits to be more compact.
12083 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12084 Remove unneeded casts.
12086 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12088 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12090 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12091 binding" message (bug#7967).
12093 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12095 Fix more problems found by GCC 4.6.0's static checks.
12097 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12098 Remove unused local var.
12100 * editfns.c (Fmessage_box): Remove unused local var.
12102 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12103 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12104 Omit unused local vars.
12105 * window.c (shrink_windows): Omit unused local var.
12106 * menu.c (digest_single_submenu): Omit unused local var.
12107 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12108 Omit unused local var.
12110 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12111 Don't assume string length fits in int.
12112 (keyremap_step, read_key_sequence): Use size_t for sizes.
12113 (read_key_sequence): Don't check last_real_key_start redundantly.
12115 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12116 instead of alloca (Bug#8344).
12118 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12119 (Fbacktrace_frame): Don't assume nframes fits in int.
12121 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12123 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12126 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12128 * cm.c (calccost): Turn while-do into do-while, for clarity.
12130 * keyboard.c (syms_of_keyboard): Use the same style as later
12131 in this function when indexing through an array. This also
12132 works around GCC bug 48267.
12134 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12136 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12138 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12139 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12141 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12142 This avoids undefined behavior on integer overflow, and is a bit
12143 more convenient anyway since it is compared to a size_t variable.
12145 Variadic C functions now count arguments with size_t, not int.
12146 This avoids an unnecessary limitation on 64-bit machines, which
12147 caused (substring ...) to crash on large vectors (Bug#8344).
12148 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12149 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12150 All variadic functions and their callers changed accordingly.
12151 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12152 * data.c (arith_driver, float_arith_driver): Likewise.
12153 * editfns.c (general_insert_function): Likewise.
12154 * eval.c (struct backtrace.nargs, interactive_p)
12155 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12156 (funcall_lambda, mark_backtrace): Likewise.
12157 * fns.c (concat): Likewise.
12158 * frame.c (x_set_frame_parameters): Likewise.
12159 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12160 0 if not found, not -1. All callers changed.
12162 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12163 (stack_copy_size): Now size_t, not int.
12164 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12166 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12168 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12169 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12170 All callers changed.
12172 * lisp.h (multibyte_char_to_unibyte):
12173 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12174 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12175 * character.h (CHAR_TO_BYTE8):
12176 * cmds.c (internal_self_insert):
12177 * editfns.c (general_insert_function):
12178 * keymap.c (push_key_description):
12179 * search.c (Freplace_match):
12180 * xdisp.c (message_dolog, set_message_1): All callers changed.
12182 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12184 * keyboard.c (safe_run_hook_funcall): New function.
12185 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12186 don't set the hook to nil, but remove the offending function instead.
12187 (Qcommand_hook_internal): Remove, unused.
12188 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12189 Vcommand_hook_internal.
12191 * eval.c (enum run_hooks_condition): Remove.
12192 (funcall_nil, funcall_not): New functions.
12193 (run_hook_with_args): Call each function through a `funcall' argument.
12194 Remove `cond' argument, now redundant.
12195 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12196 (Frun_hook_with_args_until_failure): Adjust accordingly.
12197 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12199 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12201 * dispextern.h (string_buffer_position): Remove declaration.
12203 * print.c (strout): Remove parameter `multibyte', unused since
12204 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12206 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12207 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12208 All callers changed.
12210 * w32.c (_wsa_errlist): Use braces for struct initializers.
12212 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12213 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12214 All callers changed.
12215 (string_buffer_position): Likewise. Also, make static (it's never
12216 used outside xdisp.c).
12217 (cursor_row_p): Remove parameter `w', unused since
12218 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12219 (decode_mode_spec): Remove parameter `precision', introduced during
12220 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12221 All callers changed.
12223 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12225 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12227 2011-03-27 Anders Lindgren <andlind@gmail.com>
12229 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12230 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12231 (ns_update_auto_hide_menu_bar): New functions.
12232 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12233 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12234 ns_constrain_all_frames.
12235 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12236 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12238 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12240 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12242 2011-03-27 Glenn Morris <rgm@gnu.org>
12244 * syssignal.h: Replace RETSIGTYPE with void.
12245 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12246 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12247 Replace SIGTYPE with void everywhere.
12248 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12249 * s/template.h (SIGTYPE): Remove commented out definition.
12251 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12253 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12254 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12256 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12258 * w32.c (read_unc_volume): Use parameter `henum', instead of
12259 global variable `wget_enum_handle'.
12261 * keymap.c (describe_vector): Remove parameters `indices' and
12262 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12263 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12265 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12267 * keyboard.c (timer_check): Remove parameter `do_it_now',
12268 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12269 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12270 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12272 * keyboard.c (read_char):
12273 * w32menu.c (w32_menu_display_help):
12274 * xmenu.c (show_help_event, menu_help_callback):
12275 Adjust calls to `show_help_echo'.
12277 * gtkutil.c (xg_maybe_add_timer):
12278 * keyboard.c (readable_events):
12279 * process.c (wait_reading_process_output):
12280 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12282 * insdel.c (adjust_markers_gap_motion):
12283 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12284 (gap_left, gap_right): Don't call it.
12286 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12288 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12289 incurred during fontification.
12291 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12293 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12294 (DEFVAR_PER_BUFFER): Don't pass it.
12296 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12297 (scrolling_window): Don't pass it.
12299 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12301 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12303 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12305 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12306 of variables specific to SELinux and computation of `encoded_absname'.
12308 * image.c (XPutPixel): Remove unused variable `height'.
12310 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12312 * unexw32.c (get_section_info): Remove unused variable `section'.
12314 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12315 (system_process_attributes): Remove unused variable `sess'.
12316 (sys_read): Remove unused variable `err'.
12318 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12319 (w32_wnd_proc): Remove unused variable `isdead'.
12320 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12321 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12322 (x_create_tip_frame): Remove unused variable `tem'.
12324 * w32inevt.c (w32_console_read_socket):
12325 Remove unused variable `no_events'.
12327 * w32term.c (x_draw_composite_glyph_string_foreground):
12328 Remove unused variable `width'.
12330 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12332 * w32term.c (x_set_glyph_string_clipping):
12333 Don't pass uninitialized region to CombineRgn.
12335 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12337 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12338 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12339 (Fx_close_connection): Remove unused variable `i'.
12341 * w32font.c (w32font_draw): Return number of glyphs.
12342 (w32font_open_internal): Remove unused variable `i'.
12343 (w32font_driver): Add missing initializer.
12345 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12346 (fill_in_menu): Remove unused variable `items_added'.
12348 * w32term.c (last_mouse_press_frame): Remove static global variable.
12349 (w32_clip_to_row): Remove unused variable `f'.
12350 (x_delete_terminal): Remove unused variable `i'.
12352 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12353 (NOTHING): Remove unused static global variable.
12354 (uniscribe_check_otf): Remove unused variable `table'.
12355 (uniscribe_font_driver): Add missing initializers.
12357 2011-03-23 Julien Danjou <julien@danjou.info>
12359 * term.c (Fsuspend_tty, Fresume_tty):
12360 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12361 * window.c (temp_output_buffer_show):
12362 * insdel.c (signal_before_change):
12363 * frame.c (Fhandle_switch_frame):
12364 * fileio.c (Fdo_auto_save):
12365 * emacs.c (Fkill_emacs):
12366 * editfns.c (save_excursion_restore):
12367 * cmds.c (internal_self_insert):
12368 * callint.c (Fcall_interactively):
12369 * buffer.c (Fkill_all_local_variables):
12370 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12372 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12373 unconditionally since it does the check itself.
12375 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12377 Fix more problems found by GCC 4.5.2's static checks.
12379 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12380 the first time through the loop, since we know p0 < p1 then.
12381 This also avoids a gcc -Wstrict-overflow warning.
12383 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12384 leading to a memory leak, possible in functions like
12385 load_charset_map_from_file that can allocate an unbounded number
12386 of objects (Bug#8318).
12388 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12389 that could (at least in theory) be that large.
12391 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12392 This is less likely to overflow, and avoids undefined behavior if
12393 overflow does occur. All callers changed. Use strtoul to scan
12394 for the unsigned long integer.
12395 (pint2hrstr): Simplify and tune code slightly.
12396 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12398 * scroll.c (do_scrolling): Work around GCC bug 48228.
12399 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12401 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12402 This also avoids a warning with gcc -Wstrict-overflow.
12403 (validate_x_resource_name): Simplify count usage.
12404 This also avoids a warning with gcc -Wstrict-overflow.
12406 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12409 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12411 * process.c (Fmake_network_process): Use socklen_t, not int,
12412 where POSIX says socklen_t is required in portable programs.
12413 This fixes a porting bug on hosts like 64-bit HP-UX, where
12414 socklen_t is wider than int (Bug#8277).
12415 (Fmake_network_process, server_accept_connection):
12416 (wait_reading_process_output, read_process_output):
12419 * process.c: Rename or move locals to avoid shadowing.
12420 (list_processes_1, Fmake_network_process):
12421 (read_process_output_error_handler, exec_sentinel_error_handler):
12422 Rename or move locals.
12423 (Fmake_network_process): Define label "retry_connect" only if needed.
12424 (Fnetwork_interface_info): Fix pointer signedness.
12425 (process_send_signal): Add cast to avoid pointer signedness problem.
12426 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12427 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12429 Make tparam.h and terminfo.c consistent.
12430 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12431 Include tparam.h instead, since it declares them.
12432 * cm.h (PC): Remove extern decl; tparam.h now does this.
12433 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12434 * terminfo.c: Include tparam.h, to check interfaces.
12435 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12436 (tparam): Adjust signature to match interface in tparam.h;
12437 this removes some undefined behavior. Check that outstring and len
12438 are zero, which they always are with Emacs.
12439 * tparam.h (PC, BC, UP): New extern decls.
12441 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12442 (xftfont_open): Rename locals to avoid shadowing.
12444 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12445 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12446 (OTF_TAG_SYM): Omit macro if not needed.
12447 (ftfont_list): Remove unused local.
12448 (get_adstyle_property, ftfont_pattern_entity):
12449 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12450 Rename locals to avoid shadowing.
12452 * xfont.c (xfont_list_family): Mark var as initialized.
12454 * xml.c (make_dom): Now static.
12456 * composite.c (composition_compute_stop_pos): Rename local to
12458 (composition_reseat_it): Remove unused locals.
12459 (find_automatic_composition, composition_adjust_point): Likewise.
12460 (composition_update_it): Mark var as initialized.
12461 (find_automatic_composition): Mark vars as initialized,
12462 with a FIXME (Bug#8290).
12464 character.h: Rename locals to avoid shadowing.
12465 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12466 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12467 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12468 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12469 to avoid shadowing.
12471 * textprop.c (property_change_between_p): Remove; unused.
12473 * intervals.c (interval_start_pos): Now static.
12475 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12477 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12478 Rename locals to avoid shadowing.
12480 * sound.c (wav_play, au_play, Fplay_sound_internal):
12481 Fix pointer signedness.
12482 (alsa_choose_format): Remove unused local var.
12483 (wav_play): Initialize a variable to 0, to prevent undefined
12484 behavior (Bug#8278).
12486 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12488 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12490 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12491 clobbering (Bug#8298).
12492 * sysdep.c (sys_subshell): Likewise.
12493 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12495 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12496 This should get cleaned up, so that child_setup has the
12497 same signature on all platforms.
12499 * callproc.c (call_process_cleanup): Now static.
12500 (relocate_fd): Rename locals to avoid shadowing.
12502 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12504 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12505 not to be necessary, and produces flickering.
12507 2011-03-20 Glenn Morris <rgm@gnu.org>
12509 * config.in: Remove file.
12511 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12513 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12514 are now in src/globals.h.
12515 (syms_of_minibuf): Remove spurious & from previous change.
12517 2011-03-20 Leo Liu <sdl.web@gmail.com>
12519 * minibuf.c (completing-read-function): New variable.
12520 (completing-read-default): Rename from completing-read.
12521 (completing-read): Call completing-read-function.
12523 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12525 * xfaces.c (Fx_load_color_file):
12526 Read color file from absolute filename (bug#8250).
12528 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12530 * makefile.w32-in: Update dependencies.
12532 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12534 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12536 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12538 Fix more problems found by GCC 4.5.2's static checks.
12540 * process.c (make_serial_process_unwind, send_process_trap):
12541 (sigchld_handler): Now static.
12543 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12544 That way, the code declares only the vars that it needs.
12545 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12546 * s/cygwin.h (PTY_ITERATION): Likewise.
12547 * s/darwin.h (PTY_ITERATION): Likewise.
12548 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12550 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12551 * process.c (allocate_pty): Don't declare stb unless it's needed.
12553 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12554 (CONSTANTLIM): Remove; unused.
12555 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12556 Define only if needed.
12558 * unexelf.c (unexec): Name an expression,
12559 to avoid gcc -Wbad-function-cast warning.
12560 Use a different way to cause a compilation error if anyone uses
12561 n rather than nn, a way that does not involve shadowing.
12562 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12564 * deps.mk (unexalpha.o): Remove; unused.
12566 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12567 * unexec.h: New file.
12568 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12569 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12570 Depend on unexec.h.
12571 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12572 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12573 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12574 Change as necessary to match prototype in unexec.h.
12576 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12578 (back_comment, skip_chars): Mark vars as initialized.
12580 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12581 Rename locals to avoid shadowing.
12583 * lread.c (read1): Rewrite so as not to use empty "else".
12584 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12586 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12588 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12589 warning when compiling print.c.
12591 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12592 instead of using an uninitialized var.
12593 (font_sort_entities): Mark var as initialized.
12595 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12597 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12598 pointers to constants.
12599 (font_parse_fcname): Remove unused vars.
12600 (font_delete_unmatched): Now static.
12601 (font_get_spec): Remove; unused.
12602 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12603 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12604 Rename or move locals to avoid shadowing.
12606 * fns.c (require_nesting_list, require_unwind): Now static.
12607 (Ffillarray): Rename locals to avoid shadowing.
12609 * floatfns.c (domain_error2): Define only if needed.
12610 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12612 * alloc.c (mark_backtrace): Move decl from here ...
12613 * lisp.h: ... to here, so that it can be checked.
12615 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12616 (Fdefvar): Rewrite so as not to use empty "else".
12617 (lisp_indirect_variable): Name an expression,
12618 to avoid gcc -Wbad-function-cast warning.
12619 (Fdefvar): Rename locals to avoid shadowing.
12621 * callint.c (quotify_arg, quotify_args): Now static.
12622 (Fcall_interactively): Rename locals to avoid shadowing.
12623 Use const pointer when appropriate.
12625 * lisp.h (get_system_name, get_operating_system_release):
12626 Move decls here, to check interfaces.
12627 * process.c (get_operating_system_release): Move decl to lisp.h.
12628 * xrdb.c (get_system_name): Likewise.
12629 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12630 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12631 some of which prompt warnings from gcc -Wbad-function-cast.
12632 (Fformat_time_string, Fencode_time, Finsert_char):
12633 (Ftranslate_region_internal, Fformat):
12634 Rename or remove local vars to avoid shadowing.
12635 (Ftranslate_region_internal): Mark var as initialized.
12637 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12640 * lisp.h (eassert): Check that the argument compiles, even if
12641 ENABLE_CHECKING is not defined.
12643 * data.c (Findirect_variable): Name an expression, to avoid
12644 gcc -Wbad-function-cast warning.
12645 (default_value, arithcompare, arith_driver, arith_error): Now static.
12646 (store_symval_forwarding): Rename local to avoid shadowing.
12647 (Fmake_variable_buffer_local, Fmake_local_variable):
12648 Mark variables as initialized.
12649 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12651 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12652 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12653 Rename locals to avoid shadowing.
12654 (mark_stack): Move local variables into the #ifdef region where
12656 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12657 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12659 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12660 (GC_STRING_CHARS): Remove; not used.
12661 (Fmemory_limit): Cast sbrk's returned value to char *.
12663 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12664 avoids undefined behavior in theory.
12666 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12668 Use functions, not macros, for up- and down-casing (Bug#8254).
12669 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12670 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12671 to use the following functions instead of these macros.
12672 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12673 EMACS_INT, since callers assume the returned value fits in int.
12674 (upcase1): Likewise, for UPCASE_TABLE.
12675 (uppercasep, lowercasep, upcase): New static inline functions.
12676 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12677 the race-condition problem in the old DOWNCASE.
12679 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12680 Rename locals to avoid shadowing.
12681 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12682 (regex_compile, re_search_2, re_match_2_internal):
12683 Remove unused local vars.
12684 (FREE_VAR): Rewrite so as not to use empty "else",
12685 which gcc can warn about.
12686 (regex_compile, re_match_2_internal): Mark locals as initialized.
12687 (RETALLOC_IF): Define only if needed.
12688 (WORDCHAR_P): Likewise. This one is never needed, but is used
12689 only in a comment talking about a compiler bug, so put inside
12690 the #if 0 of that comment.
12691 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12692 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12695 * search.c (boyer_moore): Rename locals to avoid shadowing.
12696 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12697 (PREV_CHAR_BOUNDARY): Likewise.
12699 * search.c (simple_search): Remove unused var.
12701 * dired.c (compile_pattern): Move decl from here ...
12702 * lisp.h: ... to here, so that it can be checked.
12703 (struct re_registers): New forward decl.
12705 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12707 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12709 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12710 Rename locals to avoid shadowing.
12711 (Fvertical_motion): Mark locals as initialized.
12713 * casefiddle.c (casify_object, casify_region): Now static.
12714 (casify_region): Mark local as initialized.
12716 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12718 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12719 New macros, so that the caller can use some names other than
12720 gcpro1, gcpro2, etc.
12721 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12723 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12724 argument, for consistency with GCPRO2_VAR, etc: it is now the
12725 prefix of the variable, not the variable itself. All uses
12727 * dired.c (directory_files_internal, file_name_completion):
12728 Rename locals to avoid shadowing.
12730 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12731 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12732 dired.c's scmp function, had undefined behavior.
12733 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12734 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12735 * buffer.h: ... to here, because these macros use current_buffer,
12736 and the new implementation with inline functions needs to have
12737 current_buffer in scope now, rather than later when the macros
12739 (downcase, upcase1): New static inline functions.
12740 (DOWNCASE, UPCASE1): Reimplement using these functions.
12741 This avoids undefined behavior in expressions like
12742 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12743 from race conditions in accessing the global variables
12744 case_temp1 and case_temp2.
12745 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12746 * lisp.h (case_temp1, case_temp2): Remove their decls.
12747 * character.h (ASCII_CHAR_P): Move from here ...
12748 * lisp.h: ... to here, so that the inline functions mentioned
12749 above can use them.
12751 * dired.c (directory_files_internal_unwind): Now static.
12753 * fileio.c (file_name_as_directory, directory_file_name):
12754 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12756 (file_name_as_directory): Use const pointers when appropriate.
12757 (Fexpand_file_name): Likewise. In particular, newdir might
12758 point at constant storage, so make it a const pointer.
12759 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12760 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12762 (Fset_file_times, Finsert_file_contents, auto_save_error):
12763 Rename locals to avoid shadowing.
12765 * minibuf.c (choose_minibuf_frame_1): Now static.
12766 (Ftry_completion, Fall_completions): Rename or remove locals
12767 to avoid shadowing.
12769 * marker.c (bytepos_to_charpos): Remove; unused.
12771 * lisp.h (verify_bytepos, count_markers): New decls,
12772 so that gcc does not warn that these functions aren't declared.
12774 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12775 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12776 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12777 (copy_text): Remove unused local var.
12779 * filelock.c (within_one_second): Now static.
12780 (lock_file_1): Rename local to avoid shadowing.
12782 * buffer.c (fix_overlays_before): Mark locals as initialized.
12783 (fix_start_end_in_overlays): Likewise. This function should be
12784 simplified by using pointers-to-pointers, but that's a different
12786 (switch_to_buffer_1): Now static.
12787 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12788 (report_overlay_modification): Rename locals to avoid shadowing.
12790 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12791 Fix pointer signedness issue.
12792 (sys_subshell): Mark local as volatile if checking for lint,
12793 to suppress a gcc -Wclobbered warning that does not seem to be right.
12794 (MAXPATHLEN): Define only if needed.
12796 * process.c (serial_open, serial_configure): Move decls from here ...
12797 * systty.h: ... to here, so that they can be checked.
12799 * fns.c (get_random, seed_random): Move extern decls from here ...
12800 * lisp.h: ... to here, so that they can be checked.
12802 * sysdep.c (reset_io): Now static.
12803 (wait_for_termination_signal): Remove; unused.
12805 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12806 (copy_keymap_item, append_key, push_text_char_description):
12808 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12809 (DENSE_TABLE_SIZE): Remove; unused.
12810 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12811 (describe_map_tree):
12812 Rename locals to avoid shadowing.
12814 * keyboard.c: Declare functions static if they are not used elsewhere.
12815 (echo_char, echo_dash, cmd_error, top_level_2):
12816 (poll_for_input, handle_async_input): Now static.
12817 (read_char, kbd_buffer_get_event, make_lispy_position):
12818 (make_lispy_event, make_lispy_movement, apply_modifiers):
12819 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12820 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12821 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12822 (read_key_sequence, read_char): Mark locals as initialized.
12823 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12825 * keyboard.h (make_ctrl_char): New decl.
12826 (mark_kboards): Move decl here ...
12827 * alloc.c (mark_kboards): ... from here.
12829 * lisp.h (force_auto_save_soon): New decl.
12831 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12832 (DEFINE_DUMMY_FUNCTION): New macro.
12833 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12835 (main): Add casts to avoid warnings
12836 if GCC considers string literals to be constants.
12838 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12840 * dbusbind.c: Pointer signedness fixes.
12841 (xd_signature, xd_append_arg, xd_initialize):
12842 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12843 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12844 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12845 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12847 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12848 if GCC considers string literals to be constants.
12849 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12851 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12853 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12854 (print_preprocess, print_object): New macro to fix last change.
12856 * print.c (print_preprocess): Don't forget font objects.
12858 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12860 * emacs.c (USAGE3): Doc fixes.
12862 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12864 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12867 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12869 * lisp.h (VWindow_system, Qfile_name_history):
12870 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12871 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12872 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12874 * w32select.c: Don't #include "keyboard.h".
12875 (run_protected): Add extern declaration for waiting_for_input.
12877 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12878 * w32console.c (detect_input_pending, read_input_pending)
12879 (encode_terminal_code):
12880 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12881 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12882 (w32_system_caret_y, Qfile_name_history):
12883 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12884 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12885 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12886 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12887 * w32proc.c (Qlocal, report_file_error):
12888 * w32term.c (Vwindow_system, updating_frame):
12889 * w32uniscribe.c (initialized, uniscribe_font_driver):
12890 Remove unneeded extern declarations.
12892 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12894 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12896 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12898 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12899 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12900 These macros can no longer be used for assignment.
12902 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12903 Assign struct members directly, instead of using BUF_BEGV etc.
12904 (record_buffer_markers, fetch_buffer_markers): New functions for
12905 recording and fetching special buffer markers.
12906 (set_buffer_internal_1, set_buffer_temp): Use them.
12908 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12910 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12912 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12913 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12915 * xdisp.c (hscroll_window_tree):
12916 (reconsider_clip_changes): Use PT instead of BUF_PT.
12918 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12920 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12921 $(EMACS_ROOT)/lib/intprops.h.
12923 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12925 Fix more problems found by GCC 4.5.2's static checks.
12927 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12928 to unsigned char * to avoid compiler diagnostic.
12929 (xg_free_frame_widgets): Make it clear that a local variable is
12930 needed only if USE_GTK_TOOLTIP.
12931 (gdk_window_get_screen): Make it clear that this macro is needed
12932 only if USE_GTK_TOOLTIP.
12933 (int_gtk_range_get_value): New function, which avoids a diagnostic
12934 from gcc -Wbad-function-cast.
12935 (xg_set_toolkit_scroll_bar_thumb): Use it.
12936 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12937 diagnostic from gcc -Wbad-function-cast.
12938 (get_utf8_string, xg_get_file_with_chooser):
12939 Rename locals to avoid shadowing.
12940 (create_dialog): Move locals to avoid shadowing.
12942 * xgselect.c (xg_select): Remove unused var.
12944 * image.c (four_corners_best): Mark locals as initialized.
12945 (gif_load): Initialize transparent_p to zero (Bug#8238).
12946 Mark another local as initialized.
12947 (my_png_error, my_error_exit): Mark with NO_RETURN.
12949 * image.c (clear_image_cache): Now static.
12950 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12951 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12952 (x_edge_detection): Remove unnecessary cast that
12953 gcc -Wbad-function-cast diagnoses.
12954 (gif_load): Fix pointer signedness.
12955 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12956 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12958 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12960 Improve quality of tests for time stamp overflow.
12961 For example, without this patch (encode-time 0 0 0 1 1
12962 1152921504606846976) returns the obviously-bogus value (-948597
12963 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12964 reports time overflow. See
12965 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12966 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12967 * editfns.c: Include limits.h and intprops.h.
12968 (TIME_T_MIN, TIME_T_MAX): New macros.
12969 (time_overflow): Move earlier, to before first use.
12970 (hi_time, lo_time): New functions, for an accurate test for
12971 out-of-range times.
12972 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12973 (Fget_internal_run_time): Don't assume time_t fits in int.
12974 (make_time): Use list2 instead of Fcons twice.
12975 (Fdecode_time): More accurate test for out-of-range times.
12976 (check_tm_member): New function.
12977 (Fencode_time): Use it, to test for out-of-range times.
12978 (lisp_time_argument): Don't rely on undefined left-shift and
12979 right-shift behavior when checking for time stamp overflow.
12981 * editfns.c (time_overflow): New function, refactoring common code.
12982 (Fformat_time_string, Fdecode_time, Fencode_time):
12983 (Fcurrent_time_string): Use it.
12985 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12986 * dired.c (make_time): Move to ...
12987 * editfns.c (make_time): ... here.
12988 * systime.h: Note the move.
12990 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12992 * fringe.c (update_window_fringes): Remove unused variables.
12994 * unexmacosx.c (copy_data_segment): Also copy __got section.
12997 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12999 * termcap.c [MSDOS]: Include "msdos.h".
13000 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13001 Constify `char *' arguments and their references according to
13002 prototypes in tparam.h.
13004 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13006 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13007 Adapt all references accordingly.
13009 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13011 2011-03-11 Tom Tromey <tromey@redhat.com>
13013 * buffer.c (syms_of_buffer): Remove obsolete comment.
13015 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13017 * termhooks.h (encode_terminal_code): Declare prototype.
13019 * msdos.c (encode_terminal_code): Don't declare prototype.
13021 * term.c (encode_terminal_code): Now external again, used by
13022 w32console.c and msdos.c.
13024 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13025 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13027 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13029 Fix some minor problems found by GCC 4.5.2's static checks.
13031 * fringe.c (update_window_fringes): Mark locals as initialized
13033 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13035 * alloc.c (mark_fringe_data): Move decl from here ...
13036 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13037 to check its interface.
13038 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13040 * fontset.c (free_realized_fontset): Now static.
13041 (Fset_fontset_font): Rename local to avoid shadowing.
13042 (fontset_font): Mark local as initialized.
13043 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13045 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13047 * xselect.c (x_disown_buffer_selections): Remove; not used.
13048 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13049 (x_own_selection, Fx_disown_selection_internal): Rename locals
13050 to avoid shadowing.
13051 (x_handle_dnd_message): Remove local to avoid shadowing.
13053 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13054 so that the caller can use some name other than gcpro1.
13055 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13056 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13057 (Fx_backspace_delete_keys_p):
13058 Use them to avoid shadowing, and rename vars to avoid shadowing.
13059 (x_decode_color, x_set_name, x_window): Now static.
13060 (Fx_create_frame): Add braces to silence GCC warning.
13061 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13062 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13063 Remove unused locals.
13064 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13065 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13066 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13069 * xterm.h (x_mouse_leave): New decl.
13071 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13072 Remove unused functions.
13073 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13074 (x_calc_absolute_position): Now static.
13075 (XTread_socket): Don't define label "out" unless it's used.
13076 Don't declare local "event" unless it's used.
13077 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13078 unless they are used.
13079 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13080 (x_fatal_error_signal): Remove; not used.
13081 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13082 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13083 (x_error_catcher, x_connection_closed, x_error_handler):
13084 (x_error_quitter, xembed_send_message, x_iconify_frame):
13085 (my_log_handler): Rename locals to avoid shadowing.
13086 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13087 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13089 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13090 Rename or move locals to avoid shadowing.
13091 (tty_defined_color, merge_face_heights): Now static.
13092 (free_realized_faces_for_fontset): Remove; not used.
13093 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13094 does not deduce is never used uninitialized.
13095 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13096 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13098 * terminal.c (store_terminal_param): Now static.
13100 * xmenu.c (menu_highlight_callback): Now static.
13101 (set_frame_menubar): Remove unused local.
13102 (xmenu_show): Rename parameter to avoid shadowing.
13103 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13104 since they might point to immutable storage.
13105 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13106 since it's unused otherwise.
13108 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13109 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13110 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13111 avoids a gcc -Wuninitialized diagnostic.
13112 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13113 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13114 does not deduce are never used uninitialized.
13116 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13118 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13119 * window.c (window_loop, size_window):
13120 (run_window_configuration_change_hook, enlarge_window): Likewise.
13122 * window.c (display_buffer): Now static.
13123 (size_window): Mark variables that gcc -Wuninitialized
13124 does not deduce are never used uninitialized.
13125 * window.h (check_all_windows): New decl, to forestall
13126 gcc -Wmissing-prototypes diagnostic.
13127 * dispextern.h (bidi_dump_cached_states): Likewise.
13129 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13131 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13132 Include <limits.h>.
13133 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13134 and to avoid gcc -Wuninitialized warning.
13135 (load_charset_map): Mark variables that gcc -Wuninitialized
13136 does not deduce are never used uninitialized.
13137 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13139 * coding.c (coding_set_source, coding_set_destination):
13140 Use "else { /* comment */ }" rather than "else /* comment */;"
13141 for clarity, and to avoid gcc -Wempty-body warning.
13142 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13143 a block, when the outer 'i' will do.
13144 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13145 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13146 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13147 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13148 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13149 Rename locals to avoid shadowing.
13150 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13151 * coding.c (emacs_mule_char, encode_invocation_designation):
13152 Now static, since they're not used elsewhere.
13153 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13154 (decode_coding_object, encode_coding_object, detect_coding_system):
13155 (decode_coding_emacs_mule): Mark variables that gcc
13156 -Wuninitialized does not deduce are never used uninitialized.
13157 (detect_coding_iso_2022): Initialize a local variable that might
13158 be used uninitialized. Leave a FIXME because it's not clear that
13159 this initialization is needed. (Bug#8211)
13160 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13161 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13162 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13163 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13164 Remove unused macros.
13166 * category.c (hash_get_category_set): Remove unused local var.
13167 (copy_category_table): Now static, since it's not used elsewhere.
13168 * character.c (string_count_byte8): Likewise.
13170 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13171 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13173 * chartab.c (copy_sub_char_table): Now static, since it's not used
13175 (sub_char_table_ref_and_range, char_table_ref_and_range):
13176 Rename locals to avoid shadowing.
13177 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13179 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13180 (BIDI_BOB): Remove unused macro.
13182 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13183 deduce are never used uninitialized.
13184 * term.c (encode_terminal_code): Likewise.
13186 * term.c (encode_terminal_code): Now static. Remove unused local.
13188 * tparam.h: New file.
13189 * term.c, tparam.h: Include it.
13190 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13191 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13192 Move these decls to tparam.h, and make them agree with what
13193 is actually in tparam.c. The previous trick of using incompatible
13194 decls in different modules does not conform to the C standard.
13195 All callers of tparam changed to use tparam's actual API.
13196 * tparam.c (tparam1, tparam, tgoto):
13197 Use const pointers where appropriate.
13199 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13200 * cm.h (struct cm): Likewise.
13201 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13202 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13203 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13204 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13205 (turn_on_face, init_tty): Likewise.
13206 * termchar.h (struct tty_display_info): Likewise.
13208 * term.c (term_mouse_position): Rename local to avoid shadowing.
13210 * alloc.c (mark_ttys): Move decl from here ...
13211 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13213 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13215 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13217 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13219 * search.c (compile_pattern_1): Remove argument regp, unused since
13220 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13221 (compile_pattern): Don't pass it.
13223 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13225 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13226 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13228 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13230 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13232 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13233 gdk_window_get_screen, gdk_window_get_geometry,
13234 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13235 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13236 (xg_get_pixbuf_from_pixmap): New function.
13237 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13238 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13239 Call xg_get_pixbuf_from_pixmap instead of
13240 gdk_pixbuf_get_from_drawable.
13241 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13242 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13243 (xg_check_special_colors): Use GtkStyleContext and its functions
13245 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13246 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13247 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13248 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13249 Call gtk_widget_get_preferred_size.
13250 (xg_frame_resized): gdk_window_get_geometry only takes 5
13252 (xg_win_to_widget, xg_event_is_for_menubar):
13253 Call gdk_x11_window_lookup_for_display.
13254 (xg_set_widget_bg): New function.
13255 (delete_cb): New function.
13256 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13257 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13258 (xg_set_background_color): Call xg_set_widget_bg.
13259 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13260 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13261 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13262 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13264 (update_frame_tool_bar): Call gtk_widget_hide.
13265 (xg_initialize): Use GDK_KEY_g.
13267 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13269 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13271 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13272 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13273 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13275 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13277 * w32xfns.c (select_palette): Check success of RealizePalette against
13278 GDI_ERROR, not zero.
13280 See ChangeLog.11 for earlier changes.
13282 ;; Local Variables:
13286 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13288 This file is part of GNU Emacs.
13290 GNU Emacs is free software: you can redistribute it and/or modify
13291 it under the terms of the GNU General Public License as published by
13292 the Free Software Foundation, either version 3 of the License, or
13293 (at your option) any later version.
13295 GNU Emacs is distributed in the hope that it will be useful,
13296 but WITHOUT ANY WARRANTY; without even the implied warranty of
13297 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13298 GNU General Public License for more details.
13300 You should have received a copy of the GNU General Public License
13301 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.