1 2012-05-02 Jim Meyering <jim@meyering.net>
3 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5 * xfns.c (x_window): Use xstrdup (Bug#11375).
7 2012-05-02 Eli Zaretskii <eliz@gnu.org>
9 * xdisp.c (pos_visible_p): If already at a newline from the
10 display string before the 'while' loop, don't walk back the glyphs
11 from it3.glyph_row. Solves assertion violation when the display
12 string begins with a newline (egg.el). (Bug#11367)
14 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
16 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
19 2012-05-01 Glenn Morris <rgm@gnu.org>
21 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
22 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
23 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
24 All were removed before 23.1.
26 * dispnew.c: Remove HAVE_LIBNCURSES test;
27 it is always true on relevant platforms.
29 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
30 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
32 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
34 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
36 * .gdbinit (xpr): Remove checks for no longer existing misc types.
37 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
40 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
42 Do not avoid creating empty evaporating overlays (Bug#9642).
43 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
44 That is, do not delete an evaporating overlay if it becomes
45 empty after its bounds are adjusted to fit within its buffer.
46 This fix caused other problems, and I'm reverting it until we get
47 to the bottom of them.
49 2012-04-27 Chong Yidong <cyd@gnu.org>
51 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
53 2012-04-27 Eli Zaretskii <eliz@gnu.org>
55 * xdisp.c (pos_visible_p): If the window start position is beyond
56 ZV, start the display from buffer beginning. Prevents assertion
57 violation in init_iterator when the minibuffer window is scrolled
60 * window.c (window_scroll_pixel_based): Likewise.
62 2012-04-27 Chong Yidong <cyd@gnu.org>
64 * keymap.c (where_is_internal): Doc fix (Bug#10872).
66 2012-04-27 Glenn Morris <rgm@gnu.org>
68 * fileio.c (Fcopy_file, Fset_file_selinux_context):
69 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
71 2012-04-27 Eli Zaretskii <eliz@gnu.org>
73 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
74 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
76 2012-04-26 Eli Zaretskii <eliz@gnu.org>
78 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
79 display element, check also the underlying string or buffer
80 character. (Bug#11341)
82 * w32menu.c: Include w32heap.h.
83 (add_menu_item): If the call to AppendMenuW (via
84 unicode_append_menu) fails, disable Unicode menus only if we are
85 running on Windows 9X/Me.
87 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
89 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
90 (xgetint): Add missing shift for LSB tags.
92 2012-04-24 Martin Rudalics <rudalics@gmx.at>
94 * keyboard.c (read_char): Don't wipe echo area for select window
95 events: These might get delayed via `mouse-autoselect-window'
98 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
100 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
101 manipulation of :loaded-from data.
103 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
105 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
106 now a cons (bug#11311).
108 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
110 Do not create empty overlays with the evaporate property (Bug#9642).
111 * buffer.c (Fmove_overlay): Delete an evaporating overlay
112 if it becomes empty after its bounds are adjusted to fit within
113 its buffer. Without this fix, in a nonempty buffer (let ((o
114 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
115 yields an empty overlay that has the evaporate property, which is
116 not supposed to happen.
118 Fix minor GTK3 problems found by static checking.
119 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
120 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
121 (struct _EmacsFixedClass, emacs_fixed_get_type):
122 Move decls here from emacsgtkfixed.h, since they needn't be public.
123 (emacs_fixed_get_type): Now static.
124 (emacs_fixed_class_init): Omit unused local.
125 (emacs_fixed_child_type): Remove; unused.
126 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
127 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
128 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
129 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
130 (EMACS_FIXED_GET_CLASS): Remove; unused.
131 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
133 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
134 Problem reported by Juanma Barranquero for Windows -Wunused-function.
136 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
138 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
139 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
140 (__malloc_size_t, __malloc_ptrdiff_t):
141 Remove. All uses removed, replaced by the definiens if needed,
142 since we can assume C89 or better now.
143 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
144 (protect_malloc_state, align, get_contiguous_space)
145 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
146 (malloc_atfork_handler_child, malloc_enable_thread)
147 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
148 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
149 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
150 (special_realloc, _realloc_internal_nolock, _realloc_internal)
151 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
152 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
153 Define using prototypes, not old style.
154 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
155 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
156 (align): Don't assume that signed integer overflow wraps around.
157 Omit unused local var.
158 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
159 (_free_internal_nolock, memalign, mallochook, reallochook):
160 Omit no-longer-needed casts.
161 (valloc): Use getpagesize, not __getpagesize.
162 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
163 (struct hdr): The 'magic' member is now size_t, not unsigned long.
165 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
167 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
169 Move functions from C to Lisp. Make non-blocking method calls
170 the default. Implement further D-Bus standard interfaces.
172 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
173 (QCdbus_request_name_allow_replacement)
174 (QCdbus_request_name_replace_existing)
175 (QCdbus_request_name_do_not_queue)
176 (QCdbus_request_name_reply_primary_owner)
177 (QCdbus_request_name_reply_in_queue)
178 (QCdbus_request_name_reply_exists)
179 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
180 (QCdbus_registered_serial, QCdbus_registered_method)
181 (QCdbus_registered_signal): New Lisp objects.
182 (XD_DEBUG_MESSAGE): Use sizeof.
183 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
184 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
185 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
186 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
187 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
188 (xd_signature, xd_append_arg): Allow float for integer types.
189 (xd_get_connection_references): New function.
190 (xd_get_connection_address): Rename from xd_initialize.
191 Return cached address.
192 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
193 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
195 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
196 Return number of recounts.
197 (Fdbus_get_unique_name): Make stronger parameter check.
198 (Fdbus_message_internal): New defun.
199 (Fdbus_call_method, Fdbus_call_method_asynchronously)
200 (Fdbus_method_return_internal, Fdbus_method_error_internal)
201 (Fdbus_send_signal, Fdbus_register_service)
202 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
203 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
204 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
205 (Vdbus_compiled_version, Vdbus_runtime_version)
206 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
207 (Vdbus_message_type_method_return, Vdbus_message_type_error)
208 (Vdbus_message_type_signal): New defvars.
209 (Vdbus_registered_buses, Vdbus_registered_objects_table):
212 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
214 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
215 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
216 Do not assume ptrdiff_t is the same width as 'int'.
218 * alloc.c: Handle unusual debugging option combinations.
219 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
220 since the two debugging options are incompatible.
221 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
223 (mem_init, mem_insert, mem_insert_fixup):
224 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
225 (NEED_MEM_INSERT): Remove; no longer needed.
227 2012-04-22 Leo Liu <sdl.web@gmail.com>
229 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
231 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
233 * sysdep.c [__FreeBSD__]: Minor cleanups.
234 (list_system_processes, system_process_attributes) [__FreeBSD__]:
235 Use Emacs indenting style more consistently. Avoid some casts.
236 Use 'double' consistently rather than mixing 'float' and 'double'.
238 2012-04-21 Eduard Wiebe <usenet@pusto.de>
240 * sysdep.c (list_system_processes, system_process_attributes):
241 Add implementation for FreeBSD (Bug#5243).
243 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
245 * lisp.mk (lisp): Update.
247 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
249 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
250 It is never used otherwise.
252 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
254 * print.c (print_preprocess): Only check print_depth if print-circle
256 (print_object): Check for cycles even when print-circle is nil and
257 print-gensym is t, but only check print_depth if print-circle is nil.
259 2012-04-20 Chong Yidong <cyd@gnu.org>
261 * process.c (wait_reading_process_output): If EIO occurs on a pty,
262 set the status to "failed" and ensure that sentinel is run.
264 2012-04-20 Glenn Morris <rgm@gnu.org>
266 * process.c (Fset_process_inherit_coding_system_flag)
267 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
268 (Fmake_network_process, Fmake_serial_process): Doc fix.
270 2012-04-20 Eli Zaretskii <eliz@gnu.org>
272 * xdisp.c (string_buffer_position_lim): Limit starting position to
274 (set_cursor_from_row): If called for a mode-line or header-line
275 row, return zero immediately.
276 (try_cursor_movement): If inside continuation line, don't back up
277 farther than the first row after the header line, if any.
278 Don't consider the header-line row as "partially visible", even if
279 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
281 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
283 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
286 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
287 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
289 configure: new option --enable-gcc-warnings (Bug#11207)
290 * Makefile.in (C_WARNINGS_SWITCH): Remove.
291 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
292 (ALL_CFLAGS): Use new macros rather than old.
293 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
294 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
295 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
296 -Wunused-result, -Wunused-variable. This should go away once
297 the Emacs and Gnulib regex code is merged.
298 (xmalloc, xrealloc): Now static.
300 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
302 * dired.c (Fsystem_groups): Remove unused local.
304 2012-04-17 Glenn Morris <rgm@gnu.org>
306 * dired.c (Fsystem_users): Doc fix.
308 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
310 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
311 (syms_of_dired): Add them.
313 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
315 Fix minor alloc.c problems found by static checking.
316 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
317 New extern decls, to avoid calling undeclared functions.
318 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
319 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
320 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
321 (NEED_MEM_INSERT): New macro.
322 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
323 Remove one incorrect comment and fix another.
325 Fix minor ralloc.c problems found by static checking.
326 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
327 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
328 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
329 (r_alloc_sbrk): Now static.
331 Improve ralloc.c interface checking.
332 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
333 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
334 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
335 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
336 [REL_ALLOC]: ... to here, to check interface.
337 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
338 Remove decls. This fixes an "It stinks!".
340 * alloc.c (which_symbols): Fix alignment issue / type clash.
342 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
344 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
345 (struct Lisp_Misc_Any): Likewise.
346 (struct Lisp_Free): Likewise.
347 * alloc.c (union aligned_Lisp_Symbol): Define.
348 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
349 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
350 (union aligned_Lisp_Misc): Define.
351 (MARKER_BLOCK_SIZE, struct marker_block): Use union
352 aligned_Lisp_Misc instead of union Lisp_Misc.
353 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
355 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
357 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
358 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
359 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
360 * s/netbsd.h, s/sol2-6.h:
361 Remove definition of GC_MARK_STACK, since the default now works.
362 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
363 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
364 no longer the default.
365 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
367 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
369 * lread.c (lisp_file_lexically_bound_p):
370 Fix hang at ";-*-\n" (bug#11238).
372 2012-04-14 Eli Zaretskii <eliz@gnu.org>
374 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
375 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
377 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
379 * nsterm.m (constrainFrameRect): Always constrain when there is only
380 one screen (Bug#10962).
382 2012-04-13 Ken Brown <kbrown@cornell.edu>
384 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
386 2012-04-13 Reuben Thomas <rrt@sc3d.org>
388 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
390 2012-04-11 Daniel Colascione <dancol@dancol.org>
392 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
393 against is gone. It's better to use vfork now so that when Cygwin
394 gains a new, working vfork, we use it automatically (bug#10398).
396 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
398 * window.c (save_window_save): Obey window-point-insertion-type.
400 2012-04-11 Glenn Morris <rgm@gnu.org>
402 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
404 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
406 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
408 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
410 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
411 (force_quit_count): New var.
412 (handle_interrupt): Use it.
414 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
416 * w32.c (w32_delayed_load): Record the full path of the library
417 being loaded (bug#10424).
419 2012-04-09 Glenn Morris <rgm@gnu.org>
421 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
422 not just in the obarray, before snarfing them. (Bug#11036)
424 * Makefile.in ($(leimdir)/leim-list.el):
425 Pass EMACS rather than BUILT_EMACS.
427 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
429 * process.c (make_process):
430 * process.h: Add integer `gnutls_handshakes_tried' member to
433 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
434 Add convenience `GNUTLS_LOG2i' macro.
436 * gnutls.c (gnutls_log_function2i): Convenience log function.
437 (emacs_gnutls_read): Use new log functions,
438 `gnutls_handshakes_tried' process member, and
439 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
440 attempts per process (connection).
442 2012-04-09 Chong Yidong <cyd@gnu.org>
444 * eval.c (Fuser_variable_p, user_variable_p_eh)
445 (lisp_indirect_variable): Functions deleted.
446 (Fdefvar): Caller changed.
448 * callint.c (Finteractive, Fcall_interactively):
449 * minibuf.c (Fread_variable): Callers changed.
451 2012-04-09 Eli Zaretskii <eliz@gnu.org>
453 * xdisp.c (set_cursor_from_row): If the display string appears in
454 the buffer at position that is closer to point than the position
455 after the display string, display the cursor on the first glyph of
456 the display string. Fixes cursor display when a 'display' text
457 property immediately follows invisible text. (Bug#11094)
459 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
461 composite.c: use 'double' consistently
462 * composite.c (get_composition_id): Use 'double' consistently
463 instead of converting 'float' to 'double' and vice versa; this is
464 easier to understand and avoids a GCC warning.
466 2012-04-09 Glenn Morris <rgm@gnu.org>
468 * Makefile.in: Generate leim-list with bootstrap-emacs, in
469 preparation for dumping it with emacs. (Bug#4789)
470 (leimdir): New variable.
471 ($(leimdir)/leim-list.el): New rule.
472 (emacs$(EXEEXT)): Depend on leim-list.el.
474 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
475 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
476 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
478 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
480 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
483 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
485 * xml.c (init_libxml2_functions) [WINDOWSNT]:
486 Remove unused local variable.
488 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
490 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
491 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
492 (mark_memory): Mark Lisp_Objects only if pointers might hide in
493 objects, as mark_maybe_pointer will catch them otherwise.
494 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
495 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
497 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
499 Fix typo that broke non-Windows builds.
500 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
502 2012-04-07 Eli Zaretskii <eliz@gnu.org>
504 Support building on MS-Windows with libxml2.
506 * makefile.w32-in (OBJ2): Add xml.$(O).
507 (GLOBAL_SOURCES): Add xml.c.
508 ($(BLD)/xml.$(O)): New dependency list.
510 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
511 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
512 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
513 [!WINDOWSNT]: New macros.
514 (init_libxml2_functions, libxml2_loaded_p): New functions.
515 (parse_region): Call fn_xmlCheckVersion instead of using the macro
516 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
517 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
518 Calls xmlCleanupParser only if libxml2 was loaded (or statically
520 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
521 Call init_libxml2_functions before calling libxml2 functions.
522 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
524 * emacs.c: Don't include libxml/parser.h.
525 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
526 xmlCleanupParser directly.
528 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
530 2012-04-07 Eli Zaretskii <eliz@gnu.org>
532 * indent.c (Fvertical_motion): If there is a display string at
533 point, use it.vpos to compute how many lines to backtrack after
534 move_it_to point. (Bug#11133)
536 2012-04-06 Eli Zaretskii <eliz@gnu.org>
538 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
539 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
540 about subtle differences between FETCH_CHAR* and STRING_CHAR*
541 macros related to unification of CJK characters. For the details,
542 see the discussion following the message here:
543 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
545 2012-04-04 Chong Yidong <cyd@gnu.org>
547 * keyboard.c (Vdelayed_warnings_list): Doc fix.
549 2012-04-01 Eli Zaretskii <eliz@gnu.org>
551 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
552 instead of alloca. (Bug#11138)
554 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
556 * w32menu.c (is_simple_dialog): Properly check lisp types.
559 2012-03-31 Eli Zaretskii <eliz@gnu.org>
561 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
562 position we get to after a call to move_it_to fails the
563 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
564 only if we wind up in a string from display property. (Bug#11063)
566 * window.c (Fdelete_other_windows_internal): Invalidate the row
567 and column information about mouse highlight, so that redisplay
568 restores it after reallocating the glyph matrices. (Bug#7464)
570 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
571 string comes from a `display' text property, use the buffer
572 position of that property as if we actually saw that position in
574 (move_it_by_lines): Remove the assertion that
575 "it->current_x == 0 && it->hpos == 0" which can be legitimately
576 violated when there's a before-string at the beginning of a line.
579 2012-03-30 Eli Zaretskii <eliz@gnu.org>
581 * xdisp.c (append_space_for_newline): If the default face was
582 remapped, use the remapped face for the appended newline.
583 (extend_face_to_end_of_line): Use the remapped default face for
584 extending the face to the end of the line.
585 (display_line): Call extend_face_to_end_of_line when the default
586 face was remapped. (Bug#11068)
588 2012-03-29 Eli Zaretskii <eliz@gnu.org>
590 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
592 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
594 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
596 2012-03-27 Glenn Morris <rgm@gnu.org>
598 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
601 2012-03-26 Kenichi Handa <handa@m17n.org>
603 * dispextern.h (struct glyph): Fix previous change. Change the
604 bit length of glyphless.ch to 25 (Bug#11082).
606 2012-03-26 Chong Yidong <cyd@gnu.org>
608 * keyboard.c (Vselection_inhibit_update_commands): New variable.
609 (command_loop_1): Use it; inhibit selection update for
610 handle-select-window too (Bug#8996).
612 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
614 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
616 2012-03-25 Kenichi Handa <handa@m17n.org>
618 * dispextern.h (struct glyph): Change the bit length of
619 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
621 2012-03-24 Eli Zaretskii <eliz@gnu.org>
623 * s/ms-w32.h (tzname): Include time.h before redirecting to
624 _tzname. Fixes the MSVC build. (Bug#9960)
626 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
628 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
631 * xterm.c (XTread_socket): Only modify handling_signal if
632 !SYNC_INPUT. (Bug#11080)
634 2012-03-23 Eli Zaretskii <eliz@gnu.org>
636 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
637 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
638 when fetching a multibyte character consumes more bytes than
639 CHAR_BYTES returns, due to unification of CJK characters in
640 string_char. (Bug#11073)
642 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
644 * process.c (wait_reading_process_output): Handle pty disconnect
645 by refraining from sending oneself a SIGCHLD (bug#10933).
647 2012-03-22 Chong Yidong <cyd@gnu.org>
649 * dispextern.h (struct it): New member string_from_prefix_prop_p.
651 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
652 Mark string as coming from a prefix property.
653 (handle_face_prop): Use default face for prefix strings (Bug#4281).
654 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
656 2012-03-21 Chong Yidong <cyd@gnu.org>
658 * xfaces.c (Vface_remapping_alist): Doc fix.
660 2012-03-20 Eli Zaretskii <eliz@gnu.org>
662 * w32proc.c (Fw32_set_console_codepage)
663 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
666 2012-03-20 Chong Yidong <cyd@gnu.org>
668 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
669 to reflect default non-nil value of redisplay-dont-pause.
671 2012-03-19 Kenichi Handa <handa@m17n.org>
673 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
674 it fit in a valid range (Bug#11003).
676 2012-03-18 Eli Zaretskii <eliz@gnu.org>
678 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
679 that is not from display property, accept the row as a "cursor
680 row" if one of the string's character has a non-nil `cursor'
681 property. Fixes cursor positioning when there are newlines in
682 overlay strings, e.g. in icomplete.el. (Bug#11035)
684 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
686 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
688 2012-03-12 Chong Yidong <cyd@gnu.org>
690 * eval.c (inhibit_lisp_code): Rename from
691 inhibit_window_configuration_change_hook; move from window.c.
693 * xfns.c (unwind_create_frame_1, Fx_create_frame):
694 * window.c (run_window_configuration_change_hook)
695 (syms_of_window): Callers changed.
697 2012-03-11 Chong Yidong <cyd@gnu.org>
699 * keymap.c (Fkey_description): Doc fix (Bug#9700).
701 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
703 2012-03-10 Chong Yidong <cyd@gnu.org>
705 * frame.c (other_visible_frames): Don't assume the selected frame
706 is visible (Bug#10955).
708 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
710 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
712 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
714 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
715 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
718 2012-03-03 Glenn Morris <rgm@gnu.org>
720 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
722 2012-03-02 Eli Zaretskii <eliz@gnu.org>
724 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
725 position past the first glyph_row that ends at ZV. (Bug#10902)
726 (redisplay_window, next_element_from_string): Fix typos in
728 (redisplay_window): Pass to move_it_vertically the margin in
729 pixels, not in screen lines.
731 2012-03-02 Glenn Morris <rgm@gnu.org>
733 * buffer.c (buffer-list-update-hook): Doc fix.
735 2012-02-29 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
738 push_it before setting up the iterator for the first overlay
739 string, even if we have an empty string loaded.
740 (next_overlay_string): If there's an empty string on the iterator
741 stack, pop the stack. (Bug#10903)
743 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
745 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
746 Suggested by Stefan Monnier in
747 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
748 * alloc.c (widen_to_Lisp_Object): New static function.
749 (mark_memory): Also mark Lisp_Objects by fetching pointer words
750 and widening them to Lisp_Objects. This would work even if
751 USE_LSB_TAG is defined and wide integers are used, which might
752 happen in a future version of Emacs.
754 2012-02-25 Chong Yidong <cyd@gnu.org>
756 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
759 * xselect.c (Fx_selection_exists_p): Doc fix.
760 (x_clipboard_manager_save_all): Print an informative message
761 before saving to clipboard manager.
763 2012-02-24 Chong Yidong <cyd@gnu.org>
765 * keyboard.c (process_special_events): Handle all X selection
766 requests in kbd_buffer, not just the next one (Bug#8869).
768 2012-02-23 Chong Yidong <cyd@gnu.org>
770 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
771 call when setting menu-bar-lines and tool-bar-lines parameters.
772 (unwind_create_frame_1): New helper function.
774 * window.c (inhibit_window_configuration_change_hook): New var.
775 (run_window_configuration_change_hook): Obey it.
776 (syms_of_window): Initialize it.
778 2012-02-22 Chong Yidong <cyd@gnu.org>
780 * xterm.c (x_draw_image_relief): Add missing type check for
781 Vtool_bar_button_margin (Bug#10743).
783 2012-02-21 Chong Yidong <cyd@gnu.org>
785 * fileio.c (Vfile_name_handler_alist): Doc fix.
787 * buffer.c (Fget_file_buffer): Protect against invalid file
788 handler return value.
790 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
792 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
793 when computing $valmask.
795 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
796 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
797 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
798 It's useless in that case, and it can cause problems on hosts
799 that allocate halves of EMACS_INT values separately.
800 Reported by Dan Horák. Diagnosed by Andreas Schwab in
801 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
802 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
803 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
804 it avoids undefined behavior on hosts where shifting right by more
805 than the word width has undefined behavior.
807 2012-02-19 Chong Yidong <cyd@gnu.org>
809 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
810 (Funhandled_file_name_directory, Ffile_name_as_directory)
811 (Fdirectory_file_name, Fexpand_file_name)
812 (Fsubstitute_in_file_name): Protect against invalid file handler
813 return values (Bug#10845).
815 2012-02-18 Eli Zaretskii <eliz@gnu.org>
817 * .gdbinit (pitx): Fix incorrect references to fields of the
820 2012-02-17 Chong Yidong <cyd@gnu.org>
822 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
824 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
826 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
827 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
829 2012-02-15 Chong Yidong <cyd@gnu.org>
831 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
832 marked as special. Also, starting docstrings with * is obsolete.
834 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
836 * gnutls.c (emacs_gnutls_write): Fix last change.
838 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
840 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
843 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
845 * keymap.c (Fsingle_key_description): Handle char ranges.
847 2012-02-12 Chong Yidong <cyd@gnu.org>
849 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
850 as that creates a dangerous corner case.
852 * window.c (Fdelete_window_internal): Invalidate the mouse
853 highlight (Bug#9904).
855 2012-02-12 Glenn Morris <rgm@gnu.org>
857 * xselect.c (Fx_own_selection_internal)
858 (Fx_get_selection_internal, Fx_disown_selection_internal)
859 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
860 * nsselect.m (Fx_own_selection_internal)
861 (Fx_disown_selection_internal, Fx_selection_exists_p)
862 (Fx_selection_owner_p, Fx_get_selection_internal):
863 Sync docs and argument specs with the xselect.c versions.
865 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
867 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
869 2012-02-11 Eli Zaretskii <eliz@gnu.org>
871 * w32select.c (Fx_selection_exists_p): Sync doc string and
872 argument list with xselect.c. (Bug#10783)
874 * w16select.c (Fx_selection_exists_p): Sync doc string and
875 argument list with xselect.c. (Bug#10783)
877 2012-02-10 Glenn Morris <rgm@gnu.org>
879 * fns.c (Fsecure_hash): Doc fix.
881 2012-02-09 Kenichi Handa <handa@m17n.org>
883 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
885 2012-02-07 Chong Yidong <cyd@gnu.org>
887 * buffer.c (Fbuffer_local_variables)
888 (buffer_lisp_local_variables): Handle unbound vars correctly;
889 don't let Qunbound leak into Lisp.
891 2012-02-07 Glenn Morris <rgm@gnu.org>
893 * image.c (Fimagemagick_types): Doc fix.
895 * image.c (imagemagick-render-type): Change it from a lisp object
896 to an integer. Move the doc here from the lisp manual.
897 Treat all values not equal to 0 the same.
899 2012-02-06 Chong Yidong <cyd@gnu.org>
901 * doc.c (store_function_docstring): Avoid applying docstring of
902 alias to base function (Bug#2603).
904 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
906 * .gdbinit (pp1, pv1): Remove redundant defines.
909 2012-02-04 Chong Yidong <cyd@gnu.org>
911 * nsterm.m: Declare a global (Bug#10694).
913 2012-02-04 Eli Zaretskii <eliz@gnu.org>
915 * w32.c (get_emacs_configuration_options):
916 Include --enable-checking, if specified, in the return value.
918 2012-02-04 Martin Rudalics <rudalics@gmx.at>
920 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
921 after rounding frame sizes. (Bug#9723)
923 2012-02-04 Eli Zaretskii <eliz@gnu.org>
925 * keyboard.c (adjust_point_for_property): Don't position point
926 before BEGV. (Bug#10696)
928 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
930 Handle overflow when computing char display width (Bug#9496).
931 * character.c (char_width): Return EMACS_INT, not int.
932 (char_width, c_string_width): Check for overflow when
933 computing the width; this is possible now that individual
934 characters can have unbounded width. Problem introduced
935 by merge from Emacs 23 on 2012-01-19.
937 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
939 * dbusbind.c (Fdbus_register_method): Mention the return value
940 :ignore in the docstring.
942 2012-02-02 Glenn Morris <rgm@gnu.org>
944 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
946 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
947 Unconditionally set to t. (Bug#10673)
948 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
949 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
950 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
952 2012-02-02 Kenichi Handa <handa@m17n.org>
954 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
955 0, do not call append_composite_glyph.
957 2012-02-02 Kenichi Handa <handa@m17n.org>
959 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
961 (x_produce_glyphs): If the component of a composition is a null
962 string, set it->pixel_width to 1 to avoid zero-width glyph.
964 2012-02-01 Eli Zaretskii <eliz@gnu.org>
966 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
967 first 2 arguments are identical. This makes inserting large
968 output from a subprocess an order of magnitude faster on
969 MS-Windows, where all sbrk'ed memory is always contiguous.
971 2012-01-31 Glenn Morris <rgm@gnu.org>
973 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
974 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
975 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
977 2012-01-29 Glenn Morris <rgm@gnu.org>
979 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
981 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
983 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
985 2012-01-28 Chong Yidong <cyd@gnu.org>
987 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
989 2012-01-26 Chong Yidong <cyd@gnu.org>
991 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
993 * search.c (Fsearch_forward, Fsearch_backward): Document negative
994 repeat counts (Bug#10507).
996 2012-01-26 Glenn Morris <rgm@gnu.org>
998 * lread.c (syms_of_lread): Doc fix.
1000 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1002 * coding.c (encode_designation_at_bol): Change return value to
1005 2012-01-25 Chong Yidong <cyd@gnu.org>
1007 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1009 2012-01-21 Chong Yidong <cyd@gnu.org>
1011 * floatfns.c (Fcopysign): Make the second argument non-optional,
1012 since nil is not allowed anyway.
1014 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1016 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1017 (send_process): Likewise.
1019 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1021 * window.c (save_window_save, Fcurrent_window_configuration)
1022 (Vwindow_persistent_parameters): Do not use Qstate.
1023 Rewrite doc-strings.
1025 2012-01-19 Kenichi Handa <handa@m17n.org>
1027 * character.c (char_width): New function.
1028 (Fchar_width, c_string_width, lisp_string_width):
1029 Use char_width (Bug#9496).
1031 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1033 * window.c (Vwindow_persistent_parameters): New variable.
1034 (Fset_window_configuration, save_window_save): Handle persistent
1037 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1039 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1040 thrashing the stack of the thread. (Bug#9087)
1042 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1044 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1046 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1048 * xdisp.c (rows_from_pos_range): Handle the case where the
1049 highlight ends on a newline. (Bug#10464)
1050 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1051 he end column for display of highlight that ends on a newline
1054 2012-01-11 Glenn Morris <rgm@gnu.org>
1056 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1057 from load-path also when installation-directory is nil. (Bug#10208)
1059 2012-01-10 Glenn Morris <rgm@gnu.org>
1061 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1063 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1064 Update template values to be closer to their typical values these days.
1066 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1068 * xdisp.c (rows_from_pos_range): Accept additional argument
1069 DISP_STRING, and accept any glyph in a row whose object is that
1070 string as eligible for mouse highlight. Fixes mouse highlight of
1071 display strings from overlays. (Bug#10464)
1073 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1075 emacs: fix an auto-save permissions race condition (Bug#10400)
1076 * fileio.c (auto_saving_dir_umask): New static var.
1077 (Fmake_directory_internal): Use it.
1078 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1079 creating the directory. The old code temporarily assigns
1080 too-generous permissions to the directory.
1081 (do_auto_save_eh): Clear it.
1082 (Fdo_auto_save): Catch all errors, not just file errors, so
1083 that the var is always cleared.
1085 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1087 * search.c (scan_buffer): Pass character positions to
1088 know_region_cache, not byte positions. (Bug#6540)
1090 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1092 * w32.c (sys_rename): Report EXDEV when rename of a directory
1093 fails because the target is on another logical disk. (Bug#10284)
1095 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1097 * xterm.c (x_embed_request_focus): New function.
1099 * xterm.h: Add prototype.
1101 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1103 2012-01-05 Glenn Morris <rgm@gnu.org>
1105 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1107 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1109 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1110 Load gnutls_transport_set_lowat only if GnuTLS version is below
1112 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1113 GnuTLS versions below 2.11.1.
1115 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1117 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1118 to the doc string advising against its use for altering the way
1119 windows are scrolled.
1121 2011-12-28 Kenichi Handa <handa@m17n.org>
1123 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1124 coding-system ASCII compatible only when it does not produce BOM
1125 on encoding (Bug#10383).
1127 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1129 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1131 (create_and_show_popup_menu): Always use menu_position_func for
1134 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1136 * callint.c (Fcall_interactively): Don't truncate prompt string.
1138 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1140 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1141 property that ends at ZV, so that the bidi iteration could be
1142 resumed from there (after widening). (Bug#10360)
1144 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1146 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1148 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1150 * nsterm.m (x_free_frame_resources):
1151 Release f->output_data.ns->miniimage.
1152 (ns_index_color): Fix indentation. Do not retain
1153 color_table->colors[i].
1155 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1158 * nsfns.m (x_set_background_color): Assign return value from
1159 ns_index_color to face-background instead of NSColor*.
1160 (ns_implicitly_set_icon_type): Fix indentation.
1161 Change assignment in for loop to comparison.
1163 * emacs.c (ns_pool): New variable.
1164 (main): Assign ns_pool.
1165 (Fkill_emacs): Call ns_release_autorelease_pool.
1167 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1168 autorelease fdesc, release fdAttrs and tdict.
1169 (ns_get_covering_families): Release charset.
1170 (ns_findfonts): Release NSFontDescriptor created with new.
1171 (ns_uni_to_glyphs): Fix indentation.
1172 (setString): Release attrStr before assigning new value.
1174 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1176 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1178 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1179 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1181 2011-12-18 David Reitter <reitter@cmu.edu>
1183 * nsterm.m (ns_term_init): Subscribe for notifications
1184 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1185 to method trackingNotification in EmacsMenu.
1187 * nsmenu.m (trackingMenu): New variable.
1188 (trackingNotification): New method (from Aquamacs).
1189 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1190 from Aquamacs (Bug#7030).
1192 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1194 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1195 (symbol_to_nsstring): Fix indentation.
1196 (ns_symbol_to_pb): New function.
1197 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1198 (Fns_rotate_cut_buffers_internal): Remove.
1199 (Fns_store_selection_internal): Rename from
1200 Fns_store_cut_buffer_internal.
1201 (ns_get_foreign_selection, Fx_own_selection_internal)
1202 (Fx_disown_selection_internal, Fx_selection_exists_p)
1203 (Fns_get_selection_internal, Fns_store_selection_internal):
1204 Use ns_symbol_to_pb and check if return value is nil.
1205 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1206 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1207 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1208 renamed to Sns_store_selection_internal.
1209 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1210 and remove this function.
1211 (ns_handle_selection_clear): Remove, never used.
1212 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1215 2011-12-17 Ken Brown <kbrown@cornell.edu>
1217 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1218 GID is unknown (Bug#10257).
1220 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1222 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1223 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1224 which caused a build failure on GNU/Linux IA-64. This problem was
1225 introduced by my 2011-10-07 patch.
1227 2011-12-15 Juri Linkov <juri@jurta.org>
1229 * image.c (imagemagick_error): New function. (Bug#10112)
1230 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1231 Use `imagemagick_error' where ImageMagick functions return
1233 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1236 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1238 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1239 fill background (Bug#8992).
1241 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1243 * window.c (Vwindow_combination_resize)
1244 (Vwindow_combination_limit): Use t instead of non-nil in
1246 (Vrecenter_redisplay): Add first sentence of doc-string on
1248 (Frecenter): Fix doc-string typo.
1250 2011-12-11 Kenichi Handa <handa@m17n.org>
1252 * coding.c (Funencodable_char_position): Pay attention to the
1253 buffer text relocation (Bug#9389).
1255 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1257 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1258 gtk_init (Bug#10100).
1260 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1262 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1263 IT->string is nil. (Bug#10263)
1265 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1267 * nsterm.h (x_free_frame_resources): Declare.
1269 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1270 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1272 * nsterm.h (ns_get_defaults_value): Declare.
1274 * nsterm.m (ns_default): Call ns_get_defaults_value.
1276 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1278 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1281 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1283 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1284 that where the value of an _OBJC_* symbol points to is in the .bss
1285 section (Bug#10240).
1287 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1289 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1290 after the loop to call ccl_driver at least once (Bug#8619).
1292 2011-12-08 Kenichi Handa <handa@m17n.org>
1294 * ftfont.c (get_adstyle_property): Fix previous change
1297 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1299 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1300 dirs from the default value of EMACSLOADPATH (bug#10208).
1302 2011-12-07 Glenn Morris <rgm@gnu.org>
1304 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1305 installation and source directories as well. (Bug#10208)
1307 2011-12-06 Chong Yidong <cyd@gnu.org>
1309 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1311 2011-12-06 Glenn Morris <rgm@gnu.org>
1313 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1314 as an error, not just -1. (Bug#10217)
1316 2011-12-05 Chong Yidong <cyd@gnu.org>
1318 * keyboard.c (process_special_events): New function.
1319 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1321 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1323 * coding.c (encode_designation_at_bol): Don't use uninitialized
1324 local variable (Bug#9318).
1326 2011-12-05 Kenichi Handa <handa@m17n.org>
1328 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1329 return Qnil (Bug#8046, Bug#10193).
1331 2011-12-05 Kenichi Handa <handa@m17n.org>
1333 * coding.c (encode_designation_at_bol): New args charbuf_end and
1334 dst. Return the number of produced bytes. Callers changed.
1335 (coding_set_source): Return how many bytes coding->source was
1337 (coding_set_destination): Return how many bytes
1338 coding->destination was relocated.
1339 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1340 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1342 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1344 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1345 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1348 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1350 The following changes are to fix Bug#9318.
1352 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1353 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1354 (encode_coding_iso_2022, encode_coding_sjis)
1355 (encode_coding_big5, encode_coding_charset): Use the above macros.
1357 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1359 * lisp.h (process_quit_flag): Fix external declaration.
1361 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1363 Don't macro-inline non-performance-critical code.
1364 * eval.c (process_quit_flag): New function.
1365 * lisp.h (QUIT): Use it.
1367 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1369 * nsfns.m (get_geometry_from_preferences): New function.
1370 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1372 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1374 * emacs.c (Qkill_emacs): Define.
1375 (syms_of_emacs): Initialize it.
1376 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1377 Qquit_flag to `kill-emacs' instead.
1378 (quit_throw_to_read_char): Add parameter `from_signal'.
1379 All callers changed. Call Fkill_emacs if requested and safe.
1380 * lisp.h (QUIT): Call Fkill_emacs if requested.
1382 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1384 * widget.c (update_wm_hints): Return if wmshell is null.
1385 (widget_update_wm_size_hints): New function.
1387 * widget.h (widget_update_wm_size_hints): Declare.
1389 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1390 widget_update_wm_size_hints (Bug#10104).
1392 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1394 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1395 before a newline, prepare the bidi iterator for consuming the
1396 newline, and keep the current paragraph direction. (Bug#10183)
1397 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1399 2011-12-02 Juri Linkov <juri@jurta.org>
1401 * search.c (Fword_search_regexp): New Lisp function created from
1402 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1403 (Fword_search_backward, Fword_search_forward)
1404 (Fword_search_backward_lax, Fword_search_forward_lax):
1405 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1406 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1408 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1410 * fileio.c (Finsert_file_contents): Move after-change-function call
1411 to before the "handled:" label, since all "goto handled" appear in
1412 cases where the *-change-functions have already been properly called
1415 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1417 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1418 waiting for input. (Bug#10169)
1420 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1422 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1423 verifies glyph row's hash code--we have just reallocated the
1424 glyphs, so their contents can be complete garbage. (Bug#10164)
1426 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1428 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1430 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1432 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1433 attributes are tested _before_ calling verify_row_hash, to protect
1434 against GCC re-ordering of the tests. (Bug#10164)
1436 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1438 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1440 * xterm.c (handle_one_xevent): Only set async_visible and friends
1441 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1442 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1443 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1445 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1447 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1448 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1449 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1450 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1451 All uses changed to use GCPRO1 etc.
1452 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1453 Revert to old implementation (i.e., before 2011-03-11).
1455 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1457 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1458 of scroll runs so as to avoid assigning disabled bogus rows and
1459 unnecessary graphics copy operations.
1461 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1463 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1464 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1465 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1466 (malloc, free, realloc, calloc): Redirect to e_* only when
1469 * lisp.h (GCTYPEBITS): Move before first use.
1470 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1471 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1472 this macro definition.
1474 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1477 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1479 * gtkutil.c (xg_create_frame_widgets):
1480 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1481 present with Gtk+ 2.0.
1483 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1485 * fileio.c (Finsert_file_contents): Undo previous change; see
1486 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1488 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1490 Rename locals to avoid shadowing.
1491 * fileio.c (Finsert_file_contents):
1492 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1493 * process.c (wait_reading_process_output):
1494 Rename inner 'proc' to 'p' to avoid shadowing.
1495 Indent for consistency with usual Emacs style.
1497 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1499 * xdisp.c (redisplay_window): If cursor row is not fully visible
1500 after recentering, and scroll-conservatively is set to a large
1501 number, scroll window by a few more lines to make the cursor fully
1502 visible and out of scroll-margin. (Bug#10105)
1503 (start_display): Don't move to the next line if the display should
1504 start at a newline that is part of a display vector or an overlay
1507 2011-11-24 Juri Linkov <juri@jurta.org>
1509 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1510 after the `MagickPingImage' call. (Bug#10112)
1512 2011-11-23 Chong Yidong <cyd@gnu.org>
1514 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1516 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1518 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1519 making another buffer current. (Bug#10114)
1521 2011-11-23 Glenn Morris <rgm@gnu.org>
1523 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1525 2011-11-23 Chong Yidong <cyd@gnu.org>
1527 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1528 using it (Bug#5984).
1530 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1532 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1533 and header-lines, as they don't have one computed for them.
1536 * .gdbinit (prow): Make displayed values more self-explaining.
1537 Add row's hash code.
1539 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1541 * process.c (wait_reading_process_output): Fix asynchrounous
1542 GnuTLS socket handling on some versions of the GnuTLS library.
1543 (wait_reading_process_output): Add comment and URL.
1545 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1547 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1549 2011-11-21 Chong Yidong <cyd@gnu.org>
1551 * window.c (Fnext_window, Fprevious_window): Doc fix.
1553 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1555 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1557 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1559 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1561 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1563 * window.c (Fset_window_combination_limit): Rename argument
1565 (Vwindow_combination_limit): Remove "status" from doc-string.
1567 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1569 * m/ibms390.h: Remove.
1570 * m/ibms390x.h: Don't include "ibms390.h".
1572 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1574 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1575 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1577 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1579 * casetab.c (Fset_case_table):
1580 * charset.c (Fcharset_after): Fix typos.
1582 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1584 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1585 Otherwise, valgrind does not work on some platforms.
1586 Problem reported by Andreas Schwab in
1587 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1588 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1589 is set, removing the need for VIRT_ADDRESS_VARIES.
1590 (PURE_P): Use a more-efficient implementation that needs just one
1591 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1592 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1593 to 4 (xorl, subq, cmpq, setbe).
1594 * alloc.c (pure): Always extern now, since that's the
1595 VIRT_ADDR_VARIES behavior.
1596 (PURE_POINTER_P): Use a single comparison, not two, for
1597 consistency with the new puresize.h.
1598 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1599 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1600 Remove VIRT_ADDR_VARIES no longer needed.
1602 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1604 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1605 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1606 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1607 behave as if the cursor position were at the window margin.
1609 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1610 and the cursor position is out of bounds, behave as if the cursor
1611 position were at the window margin. (Bug#10075)
1613 2011-11-18 Chong Yidong <cyd@gnu.org>
1615 * window.c (Fwindow_combination_limit): Make first argument
1616 non-optional, since it is meaningless for live windows like the
1619 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1621 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1623 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1625 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1626 (graft_intervals_into_buffer): Simplify.
1628 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1630 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1631 hash values of the two rows.
1632 (copy_row_except_pointers): Preserve the used[] arrays and the
1633 hash values of the two rows. (Bug#10035)
1634 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1636 * xdisp.c (row_hash): New function, body extracted from
1637 compute_line_metrics.
1638 (compute_line_metrics): Call row_hash, instead of computing the
1641 * dispnew.c (verify_row_hash): Call row_hash for computing the
1642 hash code of a row, instead of duplicating code from xdisp.c.
1644 * dispextern.h (row_hash): Add prototype.
1646 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1648 * frame.c (delete_frame): Don't delete the terminal when the last
1649 X frame is closed if emacs is built with GTK toolkit.
1651 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1653 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1655 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1657 * window.c (Vwindow_splits): Rename to
1658 Vwindow_combination_resize. Suggested by Juri Linkov.
1659 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1662 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1664 * nsfns.m (Fns_font_name):
1665 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1667 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1669 * window.h (window): Rename slot "nest" to "combination_limit".
1670 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1671 (Fset_window_nest): Rename to Fset_window_combination_limit.
1672 (Vwindow_nest): Rename to Vwindow_combination_limit.
1673 (recombine_windows, make_parent_window, make_window)
1674 (Fsplit_window_internal, saved_window)
1675 (Fset_window_configuration, save_window_save): Rename all
1676 occurrences of window_nest to window_combination_limit.
1678 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1680 * image.c (imagemagick_load_image): Fix typo.
1682 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1684 * xdisp.c (display_line): Move the call to
1685 highlight_trailing_whitespace before the call to
1686 compute_line_metrics, since the latter needs to see the final
1687 faces of all the glyphs to compute ROW's hash value.
1688 Fixes assertion violations in row_equal_p. (Bug#10035)
1690 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1692 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1693 just return (bug#10044).
1695 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1697 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1698 with user-defined heap size. Bump the default size of the temacs
1699 heap to 27MB, to avoid memory warning when running temacs.
1700 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1702 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1703 current_matrix and desired_matrix. (Bug#9990)
1704 (verify_row_hash) [XASSERTS]: New function.
1705 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1706 that the hash value of glyph rows is correct.
1708 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1710 * window.h (window): Remove splits slot.
1711 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1712 (Fdelete_other_windows_internal, make_parent_window)
1713 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1714 (Fset_window_configuration, save_window_save): Don't deal with
1715 split status of windows.
1716 (saved_window): Remove splits slot.
1717 (Vwindow_splits): Rewrite doc-string.
1719 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1721 * xfns.c (unwind_create_frame):
1722 * nsfns.m (unwind_create_frame):
1723 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1724 Vframe_list (Bug#9999).
1726 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1728 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1730 2011-11-11 Kenichi Handa <handa@m17n.org>
1732 * callproc.c (Fcall_process): Set the member dst_multibyte of
1735 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1737 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1738 avoid a crash (bug#9496).
1740 2011-11-09 Chong Yidong <cyd@gnu.org>
1742 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1743 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1745 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1747 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1749 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1751 Avoid some portability problems by eschewing 'extern inline' functions.
1752 The trivial performance wins aren't worth the portability hassles; see
1753 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1755 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1756 (window_box_width, window_box_left, window_box_left_offset)
1757 (window_box_right, window_box_right_offset): Undo previous change,
1758 by removing the "extern"s.
1759 * intervals.c (adjust_intervals_for_insertion)
1760 (adjust_intervals_for_deletion): Undo previous change,
1761 making these static again.
1762 (offset_intervals, temp_set_point_both, temp_set_point)
1763 (copy_intervals_to_string): No longer inline.
1764 * xdisp.c (window_text_bottom_y, window_box_width)
1765 (window_box_height, window_box_left_offset)
1766 (window_box_right_offset, window_box_left, window_box_right)
1767 (window_box): No longer inline.
1769 2011-11-08 Chong Yidong <cyd@gnu.org>
1771 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1772 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1773 Signal an error if not a live window.
1774 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1775 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1777 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1779 * lisp.h (syms_of_abbrev): Remove declaration.
1780 Reported by CHENG Gao <chenggao@royau.me>.
1782 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1784 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1785 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1786 of temacs in GUI mode.
1788 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1790 * window.h: Declare delete_all_child_windows instead of
1791 delete_all_subwindows.
1792 * window.c (Fwindow_nest, Fset_window_nest)
1793 (Fset_window_new_total, Fset_window_new_normal)
1794 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1795 (delete_all_subwindows): Rename to delete_all_child_windows.
1796 (Fdelete_other_windows_internal, Fset_window_configuration):
1797 Call delete_all_child_windows instead of delete_all_subwindows.
1798 * frame.c (delete_frame): Call delete_all_child_windows instead
1799 of delete_all_subwindows.
1801 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1803 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1804 This is also needed for porting to any host where GC_MARK_STACK is
1805 not GC_MAKE_GCPROS_NOOPS.
1806 (which_symbols): Use it.
1808 2011-11-07 Kenichi Handa <handa@m17n.org>
1810 * coding.c (coding_set_destination): Check coding->src_pos only
1811 when coding->src_object is a buffer (bug#9910).
1813 * process.c (send_process): Set the member src_multibyte of coding
1814 to 0 (bug#9911) when sending a unibyte text.
1816 * callproc.c (Fcall_process): Set the member src_multibyte of
1817 process_coding to 0 (bug#9912).
1819 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1821 * xmenu.c (cleanup_widget_value_tree): New function.
1822 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1823 calling free_menubar_widget_value_tree directly (Bug#9830).
1825 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1827 Fix some portability problems with 'inline'.
1828 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1829 (window_box_width, window_box_left, window_box_left_offset)
1830 (window_box_right, window_box_right_offset): Declare extern.
1831 Otherwise, these inline functions do not conform to C99 and
1832 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1833 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1834 * intervals.c (adjust_intervals_for_insertion)
1835 (adjust_intervals_for_deletion): Now extern, because otherwise the
1836 extern inline functions 'offset_intervals' couldn't refer to it.
1837 (static_offset_intervals): Remove.
1838 (offset_intervals): Rewrite using the old contents of
1839 static_offset_intervals. The old version didn't conform to C99
1840 because an extern inline function contained a reference to an
1841 identifier with static linkage.
1843 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1845 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1848 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1851 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1852 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1853 return Qleft_to_right.
1855 2011-11-06 Chong Yidong <cyd@gnu.org>
1857 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1858 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1859 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1860 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1861 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1862 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1863 (Fwindow_vscroll): Doc fix.
1864 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1865 argument, since it makes no sense to pass a live window and for
1866 consistency with window-child.
1868 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1870 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1873 2011-11-05 Jason Rumney <jasonr@gnu.org>
1875 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1876 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1878 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1879 bitwise arithmetic preventing use of unicode-sip and non-truetype
1882 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1884 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1887 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1888 initialization code to keep similarity to xfns.c after changes
1891 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1893 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1894 (unwind_create_frame): New function (Bug#9943).
1895 (Fx_create_frame): Restructure code to be more similar to the one in
1896 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1897 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1898 Move terminal->reference_count++ just before making the frame official
1901 * nsterm.m (x_free_frame_resources): New function.
1902 (x_destroy_window): Move code to x_free_frame_resources.
1904 * xfns.c (unwind_create_frame): Fix comment.
1905 (Fx_create_frame, x_create_tip_frame):
1906 Move terminal->reference_count++ just before making the frame
1907 official. Move initialization of image_cache_refcount and
1908 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1910 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1912 Support MSVC build with newer versions of Visual Studio.
1913 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1914 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1917 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1918 which are not supported by MSVC.
1919 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1920 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1922 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1924 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1926 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1928 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1930 Support MSVC build with newer versions of Visual Studio.
1931 * w32.c: Don't include w32api.h for MSVC.
1932 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1934 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1935 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1936 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1937 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1939 (alloca) [_MSC_VER]: Define to _alloca.
1941 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1943 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1945 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (note_mouse_highlight): If either of
1948 previous/next-single-property-change returns nil, treat that as
1949 the beginning or the end of the buffer. (Bug#9955)
1951 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1953 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1954 label is not null (Bug#9951).
1955 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1958 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1960 * window.c (Fwindow_body_size): Mention in the doc string that the
1961 return value is in frame's canonical units. (Bug#9949)
1963 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1965 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1967 * w32fns.c (unwind_create_frame): If needed, free the glyph
1968 matrices of the partially constructed frame. (Bug#9943)
1969 * xfns.c (unwind_create_frame): Likewise.
1971 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1973 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1974 Don't stop backward scan on the continuation glyph, even though
1975 its CHARPOS is positive.
1976 (mouse_face_from_buffer_pos, note_mouse_highlight):
1977 Rename cover_string to disp_string.
1979 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1981 * window.c (temp_output_buffer_show): Don't use
1982 Vtemp_buffer_show_specifiers.
1983 (Vtemp_buffer_show_specifiers): Remove unused variable.
1985 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1987 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1988 past the beginning of the current glyph matrix.
1990 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1992 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1993 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1994 HAVE_GTK3 (Bug#9869).
1996 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1997 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1999 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2001 * xterm.c: Declare x_handle_net_wm_state to return int.
2002 (handle_one_xevent): Check if we are iconified but don't have
2003 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2004 (get_current_wm_state): Return non-zero if not hidden,
2005 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2006 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2007 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2008 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2010 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2012 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2013 so that this new function doesn't get optimized away by a
2014 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2016 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2018 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2020 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2022 Fix the `xbytecode' command.
2023 * .gdbinit (xprintbytestr): New command.
2024 (xwhichsymbols): Rename from `which'; all callers changed.
2025 (xbytecode): Print the byte-code string as well.
2027 2011-10-29 Kim Storm <storm@cua.dk>
2029 * alloc.c (which_symbols): New function.
2031 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2033 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2036 2011-10-29 Glenn Morris <rgm@gnu.org>
2038 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2039 Not clear what it was for, and it causes various bugs. (Bug#9839)
2041 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2043 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2044 possible random value that matches one of those tested as
2045 condition to clear the mouse face.
2047 2011-10-28 Chong Yidong <cyd@gnu.org>
2049 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2051 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2053 * window.c (make_window): Initialize phys_cursor_on_p.
2055 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2057 * lisp.h (struct Lisp_Symbol): Update comments.
2059 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2061 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2063 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2065 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2066 <oslsachem@gmail.com> for helping to debug this.
2068 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2069 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2070 (g_b_init_get_glyph_outline_w): New static variables.
2071 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2072 (GetGlyphOutlineW_Proc): New typedefs.
2073 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2074 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2076 (w32font_open_internal, compute_metrics):
2077 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2078 instead of calling the "wide" APIs directly.
2080 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2082 * w32.h (syms_of_w32font): Add prototype.
2084 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2086 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2087 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2088 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2089 (Fmove_to_window_line): Doc fix.
2091 2011-10-27 Chong Yidong <cyd@gnu.org>
2093 * process.c (make_process): Set gnutls_state to NULL.
2095 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2096 non-NULL, regardless of GNUTLS_INITSTAGE.
2097 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2098 an error. Set process slots as soon as we allocate them.
2100 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2102 2011-10-27 Chong Yidong <cyd@gnu.org>
2104 * gnutls.c (emacs_gnutls_deinit): New function.
2105 Deallocate credentials structures as well as calling gnutls_deinit.
2106 (Fgnutls_deinit, Fgnutls_boot): Use it.
2108 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2109 (deactivate_process): Call emacs_gnutls_deinit.
2111 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2113 * image.c (x_create_x_image_and_pixmap):
2114 * w32.c (sys_rename, w32_delayed_load):
2115 * w32font.c (fill_in_logfont):
2116 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2118 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2120 * w32fns.c (w32_default_color_map): New function,
2121 extracted from Fw32_default_color_map.
2122 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2124 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2126 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2128 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2130 * keyboard.c (test_undefined): New function (bug#9751).
2131 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2133 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2135 * sysdep.c (init_sys_modes): Fix the check for the controlling
2136 terminal (Bug#6649).
2138 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2140 * dispextern.h (struct bidi_it): New member next_en_type.
2142 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2143 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2144 current character, check also for next_en_type being WEAK_EN.
2145 (bidi_resolve_weak): Don't enter the expensive loop if the current
2146 position is before next_en_pos. Record the bidi type of the first
2147 non-ET, non-BN character we find, in addition to its position.
2148 (bidi_level_of_next_char): Invalidate next_en_type when
2149 next_en_pos is over-stepped.
2151 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2153 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2154 * editfns.c: Rewrite current-time-zone so that it invokes
2155 the equivalent of (format-time-string "%Z") to get the time zone name.
2156 This fixes a bug when the time zone name contains characters that
2157 need converting from the system time locale to Emacs internal format.
2158 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2159 that patch fixed format-time-string to do the conversion, but
2160 I forgot to fix current-time-zone.
2161 (format_time_string): New function, containing most of
2162 what Fformat_time_string used to contain.
2163 (Fformat_time_string): Rewrite in terms of format_time_string.
2164 This doesn't change this function's behavior.
2165 (current-time-zone): Rewrite to use format_time_string.
2166 This fixes the bug reported by Michael Schierl in
2167 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2168 Jason Rumney's 2007-06-07 change worked around this bug, but
2170 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2172 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2174 * xdisp.c (start_display): If the character at POS is displayed
2175 via a display vector, reset IT->current.dpvec_index to zero.
2176 (try_window_reusing_current_matrix): If a line ends in a display
2177 vector or the next line starts in a display vector, continue
2178 redrawing the window even though the character position of
2179 start_row was reached.
2182 2011-10-18 Chong Yidong <cyd@gnu.org>
2184 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2185 with nobreak-char-display too.
2187 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2189 Fix part 3 of bug#9771.
2190 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2191 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2192 non-neutral characters if the current character is a paragraph
2193 separator (a.k.a. Newline). This avoids running the same
2194 expensive loop twice, once when we consume the preceding newline
2195 and the other time when the line actually needs to be displayed.
2196 Avoid the loop when we see neutrals on the base embedding level
2197 following a character whose directionality is the same as the
2198 paragraph's. This avoids running the expensive loop when a line
2199 ends in a long sequence of neutrals, like control characters.
2200 Add assertion against STRONG_AL type. Slightly rearrange code
2201 that determines the type of a neutral given the first non-neutral
2203 (bidi_level_of_next_char): Set next_en_pos to zero when
2204 invalidating its info.
2206 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2208 * xdisp.c (push_display_prop): Determine whether to record string
2209 or buffer position by IT->string, not by IT->method. Allow
2210 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2211 (move_it_vertically_backward): Don't look for character position
2212 immediately after the newline when in a continuation line.
2215 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2217 * window.c (coordinates_in_window): Rewrite and delabelize
2218 vertical border check. (Bug#5357) (Bug#9618)
2220 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2222 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2223 errors in XSetWindowBorder (bug#9310).
2225 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2227 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2228 avoid crash when xmalloc overrun checking is enabled.
2230 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2232 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2233 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2234 cursor motion with <left> and <right> arrow keys.
2236 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2237 some callers set that themselves.
2239 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2241 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2242 display string and the previous row comes from the same string and
2243 is empty. (Bug#9739) (Bug#9738)
2245 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2247 * doc.c (get_doc_string): Encode file name (bug#9735).
2249 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2251 * bidi.c (bidi_level_of_next_char):
2252 * xdisp.c (get_visually_first_element): Remove old incorrect
2253 comments regarding the Unicode Line Separator character.
2255 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2257 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2259 * alloc.c (Fgc_status): Do not access beyond zombies array
2260 boundary if nzombies > MAX_ZOMBIES.
2261 * alloc.c (dump_zombies): Add missing format specifier.
2263 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2265 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2266 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2268 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2269 Some packages use them to denote characters with modifiers.
2271 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2273 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2274 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2275 matching a pp-number. Rename parameter var to var1.
2277 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2279 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2281 2011-10-08 Glenn Morris <rgm@gnu.org>
2283 * callint.c (Fcall_interactively): Give a more explicit error for the
2284 'c' case with a non-character input. (Bug#8479)
2286 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2288 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2290 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2291 lines that are hscrolled on the left.
2293 * dispnew.c (buffer_posn_from_coords): Account for a possible
2294 presence of header-line. (Bug#4426)
2296 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2298 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2299 Don't advertise functionality which we discourage or doesn't work.
2301 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2303 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2304 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2305 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2306 this makes Emacs dump core during garbage collection on rare
2307 occasions. sizeof is obviously inferior to offsetof here, so
2308 stick with offsetof.
2309 (GC_POINTER_ALIGNMENT): New macro.
2310 (mark_memory): Omit 3rd (offset) arg; caller changed.
2311 Don't assume EMACS_INT alignment is the same as pointer alignment.
2313 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2315 * keyboard.c (read_key_sequence_remapped): New var.
2316 (read_key_sequence): Compute remapping in the right buffer.
2317 (command_loop_1): Use read_key_sequence's remapping directly.
2319 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2321 * dired.c (file_name_completion): Don't expand file name.
2322 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2323 before checking file name handler.
2325 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2326 they've been requested explicitly (bug#9591).
2328 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2330 * keymap.c (Fsingle_key_description): Use make_specified_string
2331 instead of build_string to build string from push_key_description.
2334 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2336 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2337 This fixes a Y2038 bug on 64-bit hosts.
2338 * buffer.c (reset_buffer):
2339 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2340 (Fclear_buffer_auto_save_failure):
2341 Use 0, not -1, to represent an unset failure time, since time_t
2342 might not be signed.
2344 Remove dependency on glibc malloc internals.
2345 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2346 Move back here from lisp.h, but with their new implementations.
2347 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2348 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2349 * charset.c (charset_table_init): New static var.
2350 (syms_of_charset): Use it instead of xmalloc. This removes a
2351 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2352 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2353 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2354 Move back to alloc.c.
2355 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2356 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2358 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2360 * nsterm.m (windowDidResize): Call x_set_window_size only when
2361 ns_in_resize is true. Otherwise set pixelwidth/height and
2362 call change_frame_size (Bug#9628).
2364 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2366 Port --enable-checking=all to Fedora 14 x86-64.
2367 * charset.c (syms_of_charset): Also account for glibc malloc's
2368 internal overhead when calculating the initial malloc maximum.
2370 Port --enable-checking=all to Fedora 14 x86.
2371 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2373 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2374 (overrun_check_realloc, overrun_check_free):
2375 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2376 That way, xmalloc returns a properly-aligned pointer even if
2377 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2378 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2379 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2380 into account when calculating the initial malloc maximum.
2381 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2382 Move here from alloc.c, so that charset.c can use it too.
2383 Properly align; the old code wasn't right for common 32-bit hosts
2384 when configured with --enable-checking=all.
2385 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2386 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2388 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2390 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2393 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2395 * xdisp.c (compute_display_string_end): If there's no display
2396 string at CHARPOS, return -1.
2398 * bidi.c (bidi_fetch_char): When compute_display_string_end
2399 returns a negative value, treat the character as a normal
2400 character not covered by a display string. (Bug#9624)
2402 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2404 * lread.c (Fread_from_string): Fix typo in docstring.
2406 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2408 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2409 newline, reseat the iterator instead of bidi-iterating there one
2410 character at a time. (Bug#9610)
2411 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2412 TO_CHARPOS if the bidi iterator is at base embedding level.
2414 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2416 * lread.c (readevalloop): Use correct code for NBSP.
2417 (read1): Likewise. (Bug#9608)
2419 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2421 * dbusbind.c (Fdbus_register_signal): When service is not
2422 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2424 2011-09-25 Glenn Morris <rgm@gnu.org>
2426 * buffer.c (truncate-lines): Doc fix.
2428 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2430 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2431 (Fset_window_next_buffers): Doc fix.
2433 2011-09-24 Glenn Morris <rgm@gnu.org>
2435 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2437 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2439 Fix minor problems found by static checking.
2440 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2441 * indent.c (Fvertical_motion): Fix == vs = typo.
2443 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2445 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2446 Default value is now t. Doc fix.
2448 * indent.c (Fvertical_motion): Compute and apply the overshoot
2449 logic when moving up, not only when moving down. Fix the
2450 confusing name and values of the it_overshoot_expected variable;
2451 logic changes accordingly. (Bug#9254) (Bug#9549)
2453 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2454 CHARPOS is covered by a display string which includes newlines.
2455 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2456 is covered by a display string with embedded newlines.
2458 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2460 * dbusbind.c (Fdbus_register_signal): Add match rule to
2461 Vdbus_registered_objects_table. (Bug#9581)
2462 (Fdbus_register_method, Vdbus_registered_objects_table):
2465 2011-09-24 Jim Meyering <meyering@redhat.com>
2467 do not ignore write error for any output size
2468 The previous change was incomplete.
2469 While it makes emacs --batch detect the vast majority of stdout
2470 write failures, errors were still ignored whenever the output size is
2471 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2472 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2473 && echo FAIL: ignored write error
2474 FAIL: ignored write error
2475 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2476 && echo FAIL: ignored write error
2477 FAIL: ignored write error
2478 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2480 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2482 * emacs.c (Fkill_emacs): In noninteractive mode exit
2483 non-successfully if a write error occurred on stdout. (Bug#9574)
2485 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2487 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2490 * dispextern.h (struct it): Update the comment documenting what
2493 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2495 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2496 a display string, extend search for cursor position to end of row.
2497 (find_row_edges): If the row ends in a newline from a display
2498 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2499 Handle the case of a display string with multiple newlines.
2500 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2501 non-empty line. Fixes confusing cursor motion with arrow keys at
2502 the beginning of a line that starts with whitespace.
2504 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2506 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2509 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2511 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2514 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2516 * xdisp.c (display_line): Record maximum and minimum buffer
2517 positions even if no glyphs were produced (e.g., by a zero-width
2518 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2519 buffer positions that will be removed from the glyph row because
2521 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2522 column is beyond frame width: don't subtract 1 "pixel" when
2523 computing width of the stretch.
2524 (reseat_at_next_visible_line_start): Undo the change made on
2525 2011-09-17 that saved paragraph information and restored it after
2526 the call to `reseat'. (Bug#9545)
2528 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2530 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2531 and turn window cursor on if cleared (Bug#9415).
2533 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2535 * search.c (boyer_moore): Take unibyte characters from pattern
2536 literally. (Bug#9458)
2538 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2540 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2542 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2544 Fix minor problem found by static checking.
2545 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2546 initialized, to pacify gcc -Wuninitialized.
2548 * fileio.c: Report proper errno when syscall falls.
2549 (Finsert_file_contents): Save and restore errno,
2550 so that report_file_error outputs the correct diagnostic.
2551 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2553 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2555 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2557 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2559 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2560 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2562 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2564 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2565 about the current paragraph and restore it after the call to reseat.
2567 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2568 (bidi_find_paragraph_start): Search back for paragraph beginning
2569 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2570 (bidi_move_to_visually_next): Only trigger paragraph-related
2571 computations when the last character is a newline or at EOB, not
2572 just any NEUTRAL_B. (Bug#9470)
2574 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2575 truncated lines if point is covered by a display string. (Bug#9524)
2577 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2579 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2580 (cons_to_x_long): New function.
2581 (lisp_data_to_selection_data): Use it. Correct the test for
2582 short-versus-long data; it was negated. Break out of vector
2583 loop, for efficiency, when a long datum is discovered.
2585 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2587 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2589 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2591 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2592 GCC PR/17406) by declaring this function with external scope.
2594 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2596 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2597 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2599 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2601 * editfns.c (Fformat): Correctly handle text properties on "%%".
2603 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2605 * xterm.c (x_draw_composite_glyph_string_foreground):
2606 * w32term.c (x_draw_composite_glyph_string_foreground):
2607 * term.c (encode_terminal_code):
2608 * composite.c (composition_update_it, get_composition_id):
2609 * xdisp.c (get_next_display_element)
2610 (fill_composite_glyph_string): Add comments about special meaning
2611 of TAB characters in a composition.
2613 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2615 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2616 This occurs when processing a multibyte format.
2617 Problem reported by Wolfgang Jenker.
2619 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2621 * xdisp.c (try_cursor_movement): Only check for exact match if
2622 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2624 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2626 Remove unused external symbols.
2627 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2628 * xdisp.c (calc_pixel_width_or_height): Now static.
2629 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2630 * indent.c (check_display_width):
2631 * w32term.c: Fix comment to match code.
2632 * xterm.c, xterm.h (x_catching_errors): Remove.
2634 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2636 * xselect.c: Use signed conversions more consistently (Bug#9498).
2637 (selection_data_to_lisp_data): Assume incoming selection data are
2638 signed integers, not unsigned. This is to be consistent with
2639 outgoing selection data, which was modified to use signed integers
2640 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2641 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2642 expects long, not unsigned long.
2644 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2646 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2647 computation of loop end. Reported by Johan Bockgård
2650 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2652 * frame.c (Fother_visible_frames_p): Function deleted.
2654 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2656 * indent.c (compute_motion): Process display vector front to back
2657 rather than the other way around. (Bug#2496)
2659 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2661 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2663 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2665 * minibuf.c (Fread_from_minibuffer): Doc fix.
2667 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2669 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2670 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2672 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2674 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2675 value for non-existent files.
2677 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2679 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2680 set its "size" to -1. This will set the modtime_size field of
2681 the corresponding buffer to -1, which is what
2682 verify-visited-file-modtime expects for files that do not exist.
2685 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2687 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2689 * lisp.h: ... from here. push_key_description is no longer
2690 defined in keyboard.c, so its declaration should not be in
2691 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2692 logically belongs with push_key_description.
2694 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2696 * buffer.h: Include <sys/types.h> instead of <time.h>.
2697 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2698 Problem reported by Herbert J. Skuhra.
2700 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2702 * xml.c (parse_region): Make the parsing work for
2703 non-comment-starting XML files again (bug#9144).
2705 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2707 * image.c (gif_load): Fix calculation of bottom and right corner.
2710 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2712 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2713 redisplay in small windows.
2715 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2717 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2719 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2721 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2722 Operate on live windows only.
2724 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2726 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2728 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2730 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2731 only under bidi iteration.
2733 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2735 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2737 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2739 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2740 Without this fix, the command to link temacs failed due to an
2741 undefined symbol __builtin_isnan. This is because
2742 /usr/include/iso/math_c99.h #defines isnan(x) to
2743 __builtin_isnan(x), but the bundled gcc, which identifies itself
2744 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2746 * floatfns.c (isnan): #undef, and then #define to a clone of
2748 (Fisnan): Always define, since it's always available now.
2749 (syms_of_floatfns): Always define isnan at the Lisp level.
2751 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2753 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2755 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2757 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2758 The previous code assumed that file offsets (off_t values) fit in
2759 EMACS_INT variables, which is not true on typical 32-bit hosts.
2760 The code messed up by falsely reporting buffer overflow in cases
2761 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2762 when "big" contains more than 2**29 bytes, even though this
2763 inserts just one byte and does not overflow the buffer.
2764 (Finsert_file_contents): Store file offsets as off_t
2765 values, not as EMACS_INT values. Check for overflow when
2766 converting between EMACS_INT and off_t. When checking for
2767 buffer overflow or for overlap, take the offsets into account.
2768 Don't use EMACS_INT for small values where int suffices.
2769 When checking for overlap, fix a typo: ZV was used where
2770 ZV_BYTE was intended.
2771 (Fwrite_region): Don't assume off_t fits into 'long'.
2772 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2774 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2776 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2778 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2780 sprintf-related integer and memory overflow issues (Bug#9412).
2782 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2783 (esprintf, exprintf, evxprintf): New functions.
2784 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2785 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2786 (modify_event_symbol): Do not assume that the length of
2787 name_alist_or_stem is safe to alloca and fits in int.
2788 (Fexecute_extended_command): Likewise for function name and binding.
2789 (Frecursion_depth): Wrap around reliably on integer overflow.
2790 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2791 since some callers pass EMACS_INT values.
2792 (Fsingle_key_description): Don't crash if symbol name contains more
2793 than MAX_ALLOCA bytes.
2794 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2795 (get_minibuffer): Arg is now EMACS_INT, not int.
2796 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2797 (esprintf, exprintf, evxprintf): New decls.
2798 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2800 * dbusbind.c (signature_cat): New function.
2801 (xd_signature, Fdbus_register_signal):
2802 Do not overrun buffer; instead, report string overflow.
2804 * dispnew.c (add_window_display_history): Don't overrun buffer.
2805 Truncate instead; this is OK since it's just a log.
2807 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2808 even if the time zone offset is outlandishly large.
2809 Don't mishandle offset == INT_MIN.
2811 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2812 when creating daemon; the previous buffer-overflow check was incorrect.
2814 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2815 which has the guts of the old verror function.
2817 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2818 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2820 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2821 (font_unparse_xlfd): Don't blindly alloca long strings.
2822 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2823 fits in int, when using sprintf. Use single snprintf to count
2824 length of string rather than counting it via multiple sprintfs;
2825 that's simpler and more reliable.
2826 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2827 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2828 sprintf, in case result does not fit in int.
2830 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2831 (fontset_from_font): Print it.
2833 * frame.c (tty_frame_count): Now printmax_t, not int.
2834 (make_terminal_frame, set_term_frame_name): Print it.
2835 (x_report_frame_params): In X, window IDs are unsigned long,
2836 not signed long, so print them as unsigned.
2837 (validate_x_resource_name): Check for implausibly long names,
2838 and don't assume name length fits in 'int'.
2839 (x_get_resource_string): Don't blindly alloca invocation name;
2840 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2843 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2844 (xg_check_special_colors, xg_set_geometry):
2845 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2847 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2848 Use esprintf, not sprintf, in case result does not fit in int.
2850 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2851 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2852 it as a large positive number.
2853 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2854 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2856 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2857 in case result does not fit in int.
2859 * print.c (float_to_string): Detect width overflow more reliably.
2860 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2861 buffer overrun. Don't assume list length fits in 'int'. Treat
2862 print length of 0 as 0, not as infinity; to be consistent with other
2863 uses of print length in this function. Don't overflow print length
2864 index. Don't assume hash table size fits in 'long', or that
2865 vectorlike size fits in 'unsigned long'.
2867 * process.c (make_process): Use printmax_t, not int, to format
2868 process-name gensyms.
2870 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2872 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2873 to avoid potential buffer overrun.
2875 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2876 if X resource line is longer than 512 bytes.
2878 * xfns.c (x_window): Make sprintf buffer a bit bigger
2879 to avoid potential buffer overrun.
2881 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2883 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2885 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2887 Integer overflow fixes for scrolling, etc.
2888 Without these, Emacs silently mishandles large integers sometimes.
2889 For example, "C-u 4294967297 M-x recenter" was treated as if
2890 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2892 * xdisp.c (try_window_id): Check Emacs fixnum range before
2893 converting to 'int'.
2895 * window.c (window_scroll_line_based, Frecenter):
2896 Check that an Emacs fixnum is in range before assigning it to 'int'.
2897 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2898 values converted from Emacs fixnums.
2899 (Frecenter): Don't wrap around a line count if it is out of 'int'
2900 range; instead, treat it as an extreme value.
2901 (Fset_window_configuration, compare_window_configurations):
2902 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2904 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2905 that can exceed INT_MAX. Check that EMACS_INT value is in range
2906 before assigning it to the (possibly-narrower) index.
2907 (match_limit): Don't assume that a fixnum can fit in 'int'.
2909 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2912 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2913 (Fvertical_motion): Don't wrap around LINES values that don't fit
2914 in 'int'. Instead, treat them as extreme values. This is good
2915 enough for windows, which can't have more than INT_MAX lines anyway.
2917 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2919 * Require libxml/parser.h to avoid compilation warning.
2921 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2923 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2924 since this reportedly can destroy thread storage.
2926 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2928 * syntax.c (find_defun_start): Update all cache variables if
2929 exiting early (Bug#9401).
2931 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2933 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2935 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2936 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2937 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2939 * term.c (tty_append_glyph): New function.
2940 (produce_stretch_glyph): Static function and its prototype deleted.
2942 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2945 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2947 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2948 when checking :margin (Bug#9390).
2949 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2950 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2951 so that the name doesn't mislead. All uses changed.
2953 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2955 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2958 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2960 * xdisp.c (move_it_to): Don't bail out early when reaching
2961 position beyond to_charpos, if we are scanning backwards.
2962 (move_it_vertically_backward): When DY == 0, make sure we get to
2963 the first character in the line after the newline.
2965 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2967 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2968 (ccl_driver): Do not generate an out-of-range pointer.
2969 (Fccl_execute_on_string): Remove unnecessary check for
2970 integer overflow, noted by Stefan Monnier in
2971 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2972 Remove a FIXME that didn't need fixing.
2973 Simplify the newly-introduced buffer reallocation code.
2975 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2977 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2979 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2981 Integer and memory overflow issues (Bug#9196).
2983 * doc.c (get_doc_string): Rework so that
2984 get_doc_string_buffer_size is the actual buffer size, rather than
2985 being 1 less than the actual buffer size; this makes xpalloc more
2988 * image.c (x_allocate_bitmap_record, cache_image):
2989 * xselect.c (Fx_register_dnd_atom):
2990 Simplify previous changes by using xpalloc.
2992 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2993 since either will do and ptrdiff_t is convenient with xpalloc.
2995 * charset.c (charset_table_size)
2996 (struct charset_sort_data.priority): Now ptrdiff_t.
2997 (charset_compare): Don't overflow if priorities differ greatly.
2998 (Fsort_charsets): Don't assume list length fits in int.
2999 Check for size-calculation overflow when allocating sort data.
3000 (syms_of_charset): Allocate an initial charset table that is
3001 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3003 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3005 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3006 The actual value is always <= INT_MAX, and leaving it unsigned made
3007 overflow checking harder.
3009 * dispextern.h (struct glyph_matrix.rows_allocated)
3010 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3011 with xpalloc. The values are still always <= INT_MAX.
3013 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3015 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3016 (SAFE_NALLOCA): New macro.
3018 * region-cache.c (struct boundary.pos, find_cache_boundary)
3019 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3020 (set_cache_region, invalidate_region_cache)
3021 (revalidate_region_cache, know_region_cache, region_cache_forward)
3022 (region_cache_backward, pp_cache):
3023 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3024 so that ptrdiff_t * can be passed to xpalloc.
3025 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3026 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3027 (pp_cache): Don't assume cache_len fits in int.
3028 * region-cache.h: Adjust extern decls to match.
3030 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3031 EMACS_INT, since either will do, for xpalloc.
3033 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3034 (xnmalloc, xnrealloc, xpalloc): New functions.
3036 * bidi.c (bidi_shelve_header_size): New constant.
3037 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3038 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3040 * bidi.c (bidi_cache_shrink):
3041 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3043 Don't update size of array until after memory allocation succeeds,
3044 because xmalloc/xrealloc may not return.
3045 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3046 now that we have proper integer overflow checking.
3047 (record_overlay_string, overlay_strings): Catch overflows when
3048 calculating size of overlay_str_buf.
3050 * callproc.c (Fcall_process): Check for size overflow when
3051 calculating size of args2.
3052 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3053 Normally we prefer signed values, but sticking with ptrdiff_t would
3054 require adding more-complicated checks.
3056 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3057 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3058 Redo buffer-overflow calculations to avoid integer overflow.
3059 Add a FIXME comment where memory seems to be over-allocated.
3061 * character.c (Fstring): Check for size-calculation overflow.
3063 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3064 unnecessary integer overflow. Check for size overflow.
3065 (encode_coding_object): Don't update size until xmalloc succeeds.
3067 * composite.c (get_composition_id): Check for overflow in glyph
3068 length calculations.
3070 Integer and memory overflow fixes for display code.
3071 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3072 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3073 (scrolling_window): Check for overflow in size calculations.
3074 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3075 Don't assume glyph table len fits in int.
3076 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3077 (row_table_size): Now ptrdiff_t, not int.
3078 (scrolling_window): Avoid overflow in size calculations.
3079 Don't update size until allocation succeeds.
3080 * fns.c (concat): Check for overflow in size calculations.
3081 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3082 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3083 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3085 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3086 (get_doc_string): Check for size calculation overflow.
3087 Don't update size until allocation succeeds.
3088 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3089 EMACS_INT, where ptrdiff_t will do.
3090 (Fsubstitute_command_keys): Check for string overflow.
3092 * editfns.c (set_time_zone_rule): Don't assume environment length
3094 (message_length): Now ptrdiff_t, not int.
3095 (Fmessage_box): Don't update size until allocation succeeds.
3096 Don't assume message length fits in int.
3097 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3099 * emacs.c (main): Do not reallocate argv, since there is a null at
3100 the end that can be overwritten, and this way there's no need to
3101 worry about size-calculation overflow.
3102 (sort_args): Check for size-calculation overflow.
3104 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3106 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3108 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3109 (x_set_scroll_bar_width, x_figure_window_size):
3110 Check for integer overflow.
3111 (x_set_alpha): Do not assume XINT fits in int.
3113 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3114 This is for the members text_lines, text_cols, total_lines, total_cols,
3115 where the system imposes an 'int' limit.
3117 * fringe.c (Fdefine_fringe_bitmap):
3118 Don't update size until alloc works.
3120 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3121 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3123 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3124 Check for size-calculation overflow.
3125 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3126 do, as we prefer signed integers.
3127 (id_to_widget.max_size, id_to_widget.used)
3128 (xg_store_widget_in_map, xg_remove_widget_from_map)
3129 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3130 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3131 Use and return ptrdiff_t, not int.
3132 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3133 * gtkutil.h: Change prototypes to match the above.
3135 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3136 are duplicate now that they've been promoted to lisp.h.
3137 (x_allocate_bitmap_record, x_alloc_image_color)
3138 (make_image_cache, cache_image, xpm_load):
3139 Don't update size until alloc is done.
3140 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3142 Check for size calculation overflow.
3143 (ct_colors_allocated_max): New constant.
3144 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3147 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3148 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3149 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3150 Use ptrdiff_t, not int, to count maps.
3151 (read_char_minibuf_menu_prompt): Check for overflow in size
3152 calculations. Don't update size until allocation succeeds.
3153 Redo calculations to avoid overflow.
3154 * keyboard.h: Change prototypes to match the above.
3156 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3158 (current_minor_maps): Check for size calculation overflow.
3159 * keymap.h: Change prototypes to match the above.
3161 * lread.c (read1, init_obarray): Don't update size until alloc done.
3163 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3164 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3166 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3167 Now ptrdiff_t, not int.
3168 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3169 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3171 * process.c (Fnetwork_interface_list): Check for overflow
3172 in size calculation.
3174 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3176 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3177 overflow. Don't bother calling xmalloc when xrealloc will do.
3179 * search.c (Freplace_match): Check for size calculation overflow.
3180 (Fset_match_data): Don't assume list lengths fit in 'int'.
3182 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3183 for command line length. Do not attempt to address one before the
3184 beginning of an array, as that's not portable.
3186 * term.c (max_frame_lines): Remove; unused.
3187 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3189 (encode_terminal_code, calculate_costs): Check for size
3190 calculation overflow.
3191 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3192 table lengths and related sizes. Don't update size until alloc
3193 done. Redo calculations to avoid overflow.
3194 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3196 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3197 subtracting pointers.
3198 (gobble_line): Check for overflow more carefully. Don't update size
3201 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3202 Don't update size until alloc done.
3203 Redo size calculations to avoid overflow.
3204 Check for size calculation overflow.
3205 (main) [DEBUG]: Fix typo in invoking tparam1.
3207 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3208 Use ptrdiff_t, not int, for sizes.
3209 (store_mode_line_noprop_char): Don't update size until alloc done.
3211 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3212 Use ptrdiff_t, not int, for sizes.
3213 (Finternal_make_lisp_face, cache_face):
3214 Check for size calculation overflow.
3215 (cache_face): Treat size calculation overflows as if they were
3216 memory exhaustion (the usual treatment), rather than aborting.
3218 * xfns.c (x_encode_text, x_set_name_internal)
3219 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3220 sizes, since they can exceed INT_MAX in size. Check for size
3221 calculation overflow.
3223 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3224 (xg_select): Check for size calculation overflow.
3225 Don't update size until alloc done.
3227 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3228 as sprintf is limited to int lengths.
3230 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3231 (X_LONG_MIN): New macros.
3232 Use them to make the following changes clearer.
3233 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3234 This change doesn't affect the value now, but it may help remind
3235 future maintainers not to raise the value too much later.
3236 (SELECTION_QUANTUM): Remove, replacing with ...
3237 (selection_quantum): ... new function, which avoids overflow.
3239 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3240 assumption that selection length fits in 'int'.
3241 (x_reply_selection_request, x_handle_selection_request)
3242 (x_get_window_property, receive_incremental_selection)
3243 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3244 (lisp_data_to_selection_data, clean_local_selection_data):
3245 Use ptrdiff_t, not int, to record length of selection.
3246 (x_reply_selection_request, x_get_window_property)
3247 (receive_incremental_selection, x_property_data_to_lisp):
3248 Redo calculations to avoid overflow.
3249 (x_reply_selection_request): When sending hint, ceiling it at
3250 X_LONG_MAX rather than relying on wraparound overflow to send
3252 (x_get_window_property, receive_incremental_selection)
3253 (lisp_data_to_selection_data, x_property_data_to_lisp):
3254 Check for size-calculation overflow.
3255 (x_get_window_property, receive_incremental_selection)
3256 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3257 Don't store size until memory allocation succeeds.
3258 (x_get_window_property): Plug memory leak on memory exhaustion.
3259 Don't double-block input; malloc is safe here. Don't assume 2**34
3260 - 4 fits in unsigned long. Add an xassert to check
3261 XGetWindowProperty overflow. Be more careful about overflow
3262 calculations, and distinguish size from memory overflow better.
3263 (receive_incremental_selection): When tracing, don't assume
3264 unsigned int is less than INT_MAX.
3265 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3266 harmful) conversions of unsigned short to int.
3267 (lisp_data_to_selection_data): Don't assume that integers
3268 in the range -65535 through -1 fit in an X unsigned short.
3269 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3270 result parameters unless successful. Rely on cons_to_unsigned
3271 to report problems with elements; the old code wasn't right anyway.
3272 (x_check_property_data): Check for int overflow; we cannot use
3273 a wider type due to X limits.
3274 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3276 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3278 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3279 (x_term_init): Check for size calculation overflow.
3280 (x_color_cells): Don't store size until memory allocation succeeds.
3281 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3282 Don't assume alloca size is less than MAX_ALLOCA.
3283 (x_term_init): Don't assume length fits in int (sprintf is limited
3286 Use ptrdiff_t for composition IDs.
3287 * character.c (lisp_string_width):
3288 * composite.c (composition_table_size, n_compositions)
3289 (get_composition_id, composition_gstring_from_id):
3290 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3291 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3292 * window.c (Frecenter):
3293 Use ptrdiff_t, not int, for composition IDs.
3294 * composite.c (get_composition_id): Check for integer overflow.
3295 * composite.h: Adjust prototypes to match the above changes.
3297 Use ptrdiff_t for hash table indexes.
3298 * category.c (hash_get_category_set):
3299 * ccl.c (ccl_driver):
3300 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3301 * coding.c (coding_system_charset_list, detect_coding_system):
3302 * coding.h (struct coding_system.id):
3303 * composite.c (get_composition_id, gstring_lookup_cache):
3304 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3305 * image.c (xpm_get_color_table_h):
3306 * lisp.h (hash_lookup, hash_put):
3307 * minibuf.c (Ftest_completion):
3308 Use ptrdiff_t for hash table indexes, not int (which is too
3309 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3310 32-bit --with-wide-int hosts).
3312 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3313 Add a FIXME comment about memory leaks.
3314 (syms_of_charset): Don't assume xmalloc returns.
3316 Don't assume that stated character widths fit in int.
3317 * character.c (Fchar_width, c_string_width, lisp_string_width):
3318 * character.h (CHAR_WIDTH):
3319 * indent.c (MULTIBYTE_BYTES_WIDTH):
3320 Use sanitize_char_width to avoid undefined and/or bad behavior
3321 with outlandish widths.
3322 * character.h (sanitize_tab_width): Rename from sanitize_width,
3323 now that we have two such functions. All uses changed.
3324 (sanitize_char_width): New inline function.
3326 Don't assume that tab-width fits in int.
3327 * character.h (sanitize_width): New inline function.
3328 (SANE_TAB_WIDTH): New macro.
3329 (ASCII_CHAR_WIDTH): Use it.
3330 * indent.c (sane_tab_width): Remove. All uses replaced by
3331 SANE_TAB_WIDTH (current_buffer).
3332 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3334 * fileio.c: Integer overflow issues with file modes.
3335 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3337 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3338 Remove unreachable code.
3339 (read_hex, load_charset_map_from_file): Check for integer overflow.
3341 * xterm.c: Don't go over XClientMessageEvent limit.
3342 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3343 (x_send_scroll_bar_event): Likewise. Check that the size does not
3344 exceed limits imposed by XClientMessageEvent, as well as the usual
3345 ptrdiff_t and size_t limits.
3347 * keyboard.c: Overflow, signedness and related fixes.
3348 (make_lispy_movement): Use same integer type in forward decl
3349 that is used in the definition.
3350 (read_key_sequence, keyremap_step):
3351 Change bufsize argument back to int, undoing my 2011-03-30 change.
3352 We prefer signed types, and int is wide enough here.
3353 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3354 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3355 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3356 length, not size_t. Use ptrdiff_t for index, not int.
3357 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3358 possibility of integer overflow.
3360 Overflow, signedness and related fixes for images.
3362 * dispextern.h (struct it.stack[0].u.image.image_id)
3363 (struct_it.image_id, struct image.id, struct image_cache.size)
3364 (struct image_cache.used, struct image_cache.ref_count):
3365 * gtkutil.c (update_frame_tool_bar):
3366 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3367 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3368 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3369 * nsmenu.m (update_frame_tool_bar):
3370 * xdisp.c (calc_pixel_width_or_height):
3371 * xfns.c (image_cache_refcount):
3372 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3373 on typical 64-bit hosts.
3375 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3376 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3377 Omit unnecessary casts to int.
3378 (parse_image_spec): Check that integers fall into 'int' range
3379 when the callers expect that.
3380 (image_ascent): Redo ascent calculation to avoid int overflow.
3381 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3382 (lookup_image): Remove unnecessary tests.
3383 (xbm_image_p): Locals are now of int, not EMACS_INT,
3384 since parse_image_check makes sure they fit into int.
3385 (png_load, gif_load, svg_load_image):
3386 Prefer int to unsigned where either will do.
3387 (tiff_handler): New function, combining the cores of the
3388 old tiff_error_handler and tiff_warning_handler.
3389 This function is rewritten to use vsnprintf and thereby avoid
3390 stack buffer overflows. It uses only the features of vsnprintf
3391 that are common to both POSIX and native Microsoft.
3392 (tiff_error_handler, tiff_warning_handler): Use it.
3393 (tiff_load, gif_load, imagemagick_load_image):
3394 Don't assume :index value fits in 'int'.
3395 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3396 (imagemagick_load_image): Check that crop parameters fit into
3397 the integer types that MagickCropImage accepts. Don't assume
3398 Vimagemagick_render_type has a nonnegative value. Don't assume
3399 size_t fits in 'long'.
3400 (gs_load): Use printmax_t to print the widest integers possible.
3401 Check for integer overflow when computing image height and width.
3403 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3405 * xdisp.c (redisplay_window): Don't force window start if point
3406 will be invisible in the resulting window. (Bug#9324)
3408 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3410 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3411 the display spec is of the form `(space ...)'.
3412 (handle_display_spec): Return the value returned by
3413 handle_single_display_spec, not just 1 or zero.
3414 (handle_single_display_spec): If the display spec is of the form
3415 `(space ...)', and specifies display in the text area, return 2
3417 (try_cursor_movement): Check for the need to scroll more
3418 accurately, and prefer exact match for point under bidi.
3419 Don't advance `row' beyond the last row of the window.
3421 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3422 into disp_prop; all users changed.
3424 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3425 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3426 for the text covered by the display property.
3428 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3430 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3431 Change return value to nil.
3432 (Frecord_buffer): Delete unused function.
3434 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3436 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3437 buffers, return left-to-right.
3438 (set_cursor_from_row): Consider candidate row a win if its glyph
3439 represents a newline and point is on that newline. Fixes cursor
3440 positioning on the newline at EOL of R2L text within L2R
3441 paragraph, and vice versa.
3442 (try_cursor_movement): Check continued rows, in addition to
3443 continuation rows. Fixes unwarranted scroll when point enters a
3444 continued line of R2L text within an L2R paragraph, or vice versa.
3445 (cursor_row_p): Consider the case of point being equal to
3446 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3447 from the end of a short line to the beginning of a continued line
3448 of R2L text within L2R paragraph.
3449 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3450 composed characters.
3452 * bidi.c (bidi_check_type): Use xassert.
3453 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3456 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3458 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3461 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3463 * nsfont.m (ns_otf_to_script): Fix typo.
3465 2011-08-22 Kenichi Handa <handa@m17n.org>
3467 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3468 extra slot even if the purpose is char-code-property-table.
3470 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3472 * xdisp.c (redisplay_window): When computing centering_position,
3473 account for the height of the header line. (Bug#8874)
3475 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3476 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3477 candidate is selected by the mouse, and that candidate has a
3478 composed character under the mouse.
3480 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3481 coordinates reported by pos-visible-in-window-p for a composed
3482 character in column zero.
3484 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3486 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3488 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3490 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3491 consider it a hit if to_charpos is anywhere in the range of the
3492 composed buffer positions.
3494 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3496 * image.c (gif_load): Don't assume that each subimage has the same
3497 dimensions as the base image. Handle disposal method that is
3498 "undefined" by the gif spec (Bug#9335).
3500 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3502 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3503 (Fcondition_case): Document `debug' symbol in error handler.
3505 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3507 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3508 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3509 from an Org mode buffer to a Speedbar frame.
3511 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3512 a composition, take its buffer position from IT->cmp_it.charpos.
3513 Fixes cursor positioning at the beginning of a line that begins
3514 with a composed character.
3516 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3518 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3519 character bidirectional type, use STRONG_L instead. Fixes crashes
3520 in a buffer produced by `describe-categories'.
3522 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3523 members before the level stack, so they would be saved and
3524 restored when copying iterator state. Fixes incorrect reordering
3525 around TABs covered by display properties.
3527 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3529 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3531 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3533 * eval.c (internal_condition_case, internal_condition_case_1)
3534 (internal_condition_case_2, internal_condition_case_n):
3535 Remove unnecessary aborts (Bug#9081).
3537 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3539 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3540 has no `load' handler, try opening the file locally. (Bug#9311)
3542 2011-08-16 Ken Brown <kbrown@cornell.edu>
3544 * gmalloc.c: Expand comment.
3546 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3548 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3549 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3551 2011-08-16 Ken Brown <kbrown@cornell.edu>
3553 Fix memory allocation problems in Cygwin build (Bug#9273).
3555 * unexcw.c ( __malloc_initialized): Declare external variable.
3556 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3558 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3560 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3562 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3564 [CYGWIN] (special_realloc): New function.
3565 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3566 requests to realloc storage in the static heap.
3568 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3570 * bidi.c (bidi_initialize): Remove unused local.
3572 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3575 * biditype.h: Remove file.
3576 * makefile.w32-in ($(BLD)/bidi.$(O)):
3577 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3579 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3581 * chartab.c: Improve commentary for the uniprop_table API.
3583 * bidi.c (bidi_paragraph_init): Support zero value of
3584 bidi_ignore_explicit_marks_for_paragraph_level.
3585 (bidi_initialize): Use uniprop_table instead of including
3586 biditype.h and bidimirror.h.
3588 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3589 coordinates of the iterator when restoring from ppos_it.
3592 2011-08-14 Kenichi Handa <handa@m17n.org>
3594 * process.c (create_process): Call setup_process_coding_systems
3595 after the pid of the process is set to -1 (Bug#8162).
3597 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3599 * xdisp.c (move_it_in_display_line_to): Don't invoke
3600 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3601 ppos_it. Fixes vertical cursor motion when line beginning is
3602 covered by an image. (Bug#9296)
3604 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3606 * nsterm.h (ns_run_ascript): Declare.
3607 (NSAPP_DATA2_RUNASSCRIPT): Define.
3609 * nsfns.m (as_script, as_result, as_status): New static variables.
3610 (ns_run_ascript): New function.
3611 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3612 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3613 the event loop. Get status from as_status (Bug#7276).
3615 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3616 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3617 the event loop (Bug#7276).
3619 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3621 * gnutls.c (QCgnutls_bootprop_priority)
3622 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3623 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3624 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3625 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3626 (QCgnutls_bootprop_verify_hostname_error)
3627 (QCgnutls_bootprop_callbacks_verify): Rename from
3628 Qgnutls_bootprop_..., all uses changed.
3630 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3633 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3635 * xfaces.c (Qframe_set_background_mode): Now static.
3636 * dispextern.h (Qframe_set_background_mode): Remove decl.
3638 * process.c (Fnetwork_interface_info): Declare local only if needed.
3640 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3642 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3643 (Fnetwork_interface_list): Allocate in increments of bytes instead
3644 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3645 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3647 (struct ifflag_def): notrailers is smart on OSX.
3648 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3649 Get hardware address with getifaddrs if available.
3651 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3653 * xdisp.c (iterate_out_of_display_property): xassert that
3654 IT->position is set to within IT->object's boundaries. Break from
3655 the loop as soon as EOB is reached; avoids infloops in redisplay
3656 when IT->position is set up wrongly due to some bug.
3657 Set IT->current to match the bidi iterator unconditionally.
3658 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3659 entry. Force push_it to save on the stack the current
3660 buffer/string position, to be restored by pop_it. Fix flags in
3661 the iterator structure wrt the object coming from a display
3662 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3663 properties. (Bug#9284)
3665 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3667 * fontset.c (fontset_get_font_group): Add proper type checks.
3670 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3672 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3673 and LC_VERSION_MIN_MACOSX.
3674 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3675 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3677 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3679 * xdisp.c (forward_to_next_line_start): Allow to use the
3680 no-display-properties-and-no-overlays under bidi display.
3681 Set disp_pos in the bidi iterator to avoid searches for display
3682 properties and overlays.
3684 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3686 * editfns.c (Fset_time_zone_rule): Document relationship with the
3689 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3690 the font entity extracted from the cache (Bug#8109).
3692 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3694 * composite.c (autocmp_chars): Don't reset point. That is done by
3695 restore_point_unwind (Bug#5984).
3697 2011-08-07 Juri Linkov <juri@jurta.org>
3699 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3700 to show the arg `TIME' instead of `TIMEVAL'.
3702 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3704 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3705 display property strides EOL and includes a newline, as in
3706 longlines-mode. (Bug#9254)
3707 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3708 word-wrap under bidirectional display. (Bug#9224)
3710 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3711 is non-zero, even if the data buffer is NULL. Fixes a crash in
3712 vertical-motion with longlines-mode. (Bug#9254)
3714 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3716 * bidi.c <bidi_cache_total_alloc>: Now static.
3717 (bidi_initialize): Initialize bidi_cache_total_alloc.
3719 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3722 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3723 amount allocated this far in `bidi_cache_total_alloc'.
3724 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3725 non-zero, only free the data buffer without restoring the cache
3726 contents. All callers changed.
3728 * dispextern.h (bidi_unshelve_cache): Update prototype.
3730 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3731 (move_it_in_display_line, move_it_to)
3732 (move_it_vertically_backward, move_it_by_lines): Replace the call
3733 to xfree to an equivalent call to bidi_unshelve_cache.
3734 (move_it_in_display_line_to): Fix logic of returning
3735 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3737 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3739 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3740 came from a string character with a `cursor' property. (Bug#9229)
3742 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3744 * Makefile.in (LIB_PTHREAD): New variable.
3745 (LIBES): Add LIB_PTHREAD (Bug#9216).
3747 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3748 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3750 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3752 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3754 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3756 * xterm.c (x_find_topmost_parent): New function.
3757 (x_set_frame_alpha): Find topmost parent window with
3758 x_find_topmost_parent and set the property there also (bug#9181).
3759 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3761 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3763 * callproc.c (Fcall_process): Avoid vfork clobbering
3764 the local vars buffer, coding_systems, current_dir.
3766 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3768 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3770 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3772 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3773 so that it is not optimized away.
3775 * xdisp.c (compute_display_string_pos): Remove unused local.
3777 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3779 Fix slow cursor motion and scrolling in large buffers with
3780 selective display, like Org Mode buffers. (Bug#9218)
3782 * dispextern.h (struct bidi_it): New member disp_prop_p.
3784 * xdisp.c: Remove one-slot cache of display string positions.
3785 (compute_display_string_pos): Accept an additional argument
3786 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3787 for a display string or property. If found, set DISP_PROP_P
3790 * bidi.c (bidi_fetch_char): Accept an additional argument
3791 DISP_PROP_P, and pass it to compute_display_string_pos.
3792 Only handle text covered by a display string if DISP_PROP_P is returned
3793 non-zero. All callers of bidi_fetch_char changed.
3795 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3797 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3799 2010-12-03 Don March <don@ohspite.net>
3801 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3802 last character M-[char] is translated to ESC [char] (bug#7541).
3804 2011-08-02 Kenichi Handa <handa@m17n.org>
3806 * lisp.h (uniprop_table): Extern it.
3808 * chartab.c (uniprop_table): Make it non-static.
3810 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3812 * xdisp.c (forward_to_next_line_start): Accept additional argument
3813 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3815 (reseat_at_next_visible_line_start): Use the bidi iterator state
3816 returned by forward_to_next_line_start to restore the state of
3817 it->bidi_it after backing up to previous newline. (Bug#9212)
3819 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3821 * regex.c (re_comp): Protoize.
3822 (re_exec): Fix return type.
3823 (regexec): Fix type of `ret'. (Bug#9203)
3825 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3827 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3828 This is needed if max-image-size is a floating-point number.
3830 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3832 * print.c (print_object): Print empty symbol as ##.
3834 * lread.c (read1): Read ## as empty symbol.
3836 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3838 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3839 setting frame foreground color (Bug#9175).
3840 (x_set_background_color): Likewise.
3842 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3843 contents (Bug#9176).
3844 (EmacsTooltip -init): Remove bezels and add shadows to
3847 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3848 or scroll bar (Bug#8470).
3850 * nsfont.m (nsfont_open): Remove assignment to voffset and
3851 unnecessary vars hshink, expand, hd, full_height, min_height.
3852 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3854 * nsterm.h (nsfont_info): Remove voffset field.
3856 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3858 Implement strike-through and overline on NextStep (Bug#8863).
3860 * nsfont.m (nsfont_open): Use underline position provided by font,
3861 instead of hard-coded value of 2.
3862 (nsfont_draw): Call ns_draw_text_decoration instead.
3864 * nsterm.h: Add declaration for ns_draw_text_decoration.
3866 * nsterm.m (ns_draw_text_decoration): New function for drawing
3867 underline, overline, and strike-through.
3868 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3869 ns_draw_text_decoration. Change treatment of cursor drawing to
3870 accommodate underlining, etc.
3872 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3874 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3877 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3879 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3880 Without this fix, if a signal arrives just after memory fills up,
3881 'malloc' might be invoked reentrantly.
3883 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3884 In other words, assume that every image size is allowed, on non-X
3885 hosts. This assumption is probably wrong, but it lets Emacs compile.
3887 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3889 * regex.c (re_iswctype): Convert return values to boolean.
3891 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3893 * xdisp.c (compute_display_string_pos): Don't use cached display
3894 string position if the buffer had its restriction changed.
3897 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3899 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3901 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3903 Integer signedness and overflow and related fixes. (Bug#9079)
3905 * bidi.c: Integer size and overflow fixes.
3906 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3907 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3908 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3909 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3910 (bidi_find_other_level_edge):
3911 Use ptrdiff_t instead of EMACS_INT where either will do.
3912 This works better on 32-bit hosts configured --with-wide-int.
3913 (bidi_cache_ensure_space): Check for size-calculation overflow.
3914 Use % rather than repeated addition, for better worst-case speed.
3915 Don't set bidi_cache_size until after xrealloc returns, because it
3917 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3918 (bidi_cache_ensure_space): Also check that the bidi cache size
3919 does not exceed that of the largest Lisp string or buffer. See Eli
3920 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3922 * alloc.c (__malloc_size_t): Remove.
3923 All uses replaced by size_t. See Andreas Schwab's note
3924 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3926 * image.c: Improve checking for integer overflow.
3927 (check_image_size): Assume that f is nonnull, since
3928 it is always nonnull in practice. This is one less thing to
3929 worry about when checking for integer overflow later.
3930 (x_check_image_size): New function, which checks for integer
3931 overflow issues inside X.
3932 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3933 This removes the need for a memory_full check.
3934 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3935 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3936 (xbm_read_bitmap_data): Change locals back to 'int', since
3937 their values must fit in 'int'.
3938 (xpm_load_image, png_load, tiff_load):
3939 Invoke x_create_x_image_and_pixmap earlier,
3940 to avoid much needless work if the image is too large.
3941 (tiff_load): Treat overly large images as if
3942 x_create_x_image_and_pixmap failed, not as malloc failures.
3943 (gs_load): Use x_check_image_size.
3945 * gtkutil.c: Omit integer casts.
3946 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3947 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3949 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3951 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3952 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3953 would wrongly return t on a 64-bit host.
3955 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3956 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3957 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3958 and therefore cause GCC to emit a bogus diagnostic in some cases.
3960 * image.c: Integer signedness and overflow and related fixes.
3961 This is not an exhaustive set of fixes, but it's time to
3962 record what I've got.
3963 (lookup_pixel_color, check_image_size): Remove redundant decls.
3964 (check_image_size): Don't assume that arbitrary EMACS_INT values
3965 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3966 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3967 (tiff_load, imagemagick_load_image):
3968 Check for overflow in size calculations.
3969 (x_create_x_image_and_pixmap): Remove unnecessary test for
3970 xmalloc returning NULL; that can't happen.
3971 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3972 (xpm_color_bucket): Use better integer hashing function.
3973 (xpm_cache_color): Don't possibly over-allocate memory.
3974 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3975 (gif_memory_source):
3976 Use ptrdiff_t, not int or size_t, to record sizes.
3977 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3978 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3979 either works, as we prefer signed integers.
3980 (tiff_read_from_memory, tiff_write_from_memory):
3981 Return tsize_t, not size_t, since that's what the TIFF API wants.
3982 (tiff_read_from_memory): Don't fail simply because the read would
3983 go past EOF; instead, return a short read.
3984 (tiff_load): Omit no-longer-needed casts.
3985 (Fimagemagick_types): Don't assume size fits into 'int'.
3987 Improve hashing quality when configured --with-wide-int.
3988 * fns.c (hash_string): New function, taken from sxhash_string.
3989 Do not discard information about ASCII character case; this
3990 discarding is no longer needed.
3991 (sxhash-string): Use it. Change sig to match it. Caller changed.
3992 * lisp.h: Declare it.
3993 * lread.c (hash_string): Remove, since we now use fns.c's version.
3994 The fns.c version returns a wider integer if --with-wide-int is
3995 specified, so this should help the quality of the hashing a bit.
3997 * emacs.c: Integer overflow minor fix.
3998 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3999 Define only if GNU_LINUX.
4000 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4002 * dispnew.c: Integer signedness and overflow fixes.
4003 Remove unnecessary forward decls, that were a maintenance hassle.
4004 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4006 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4007 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4008 (prepare_desired_row, line_draw_cost):
4009 Use int, not unsigned, where either works.
4010 (save_current_matrix, restore_current_matrix):
4011 Use ptrdiff_t, not size_t, where either works.
4012 (init_display): Check for overflow more accurately, and without
4013 relying on undefined behavior.
4015 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4016 Remove, replacing with the new symbols in lisp.h. All uses changed.
4017 * fileio.c (make_temp_name):
4018 * filelock.c (lock_file_1, lock_file):
4019 * xdisp.c (message_dolog):
4020 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4021 Use pMd etc. instead.
4022 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4023 replacing the pWIDE etc. symbols removed from editfns.c.
4025 * keyboard.h (num_input_events): Now uintmax_t.
4026 This is (very slightly) less likely to mess up due to wraparound.
4029 * buffer.c: Integer signedness fixes.
4030 (alloc_buffer_text, enlarge_buffer_text):
4031 Use ptrdiff_t rather than size_t when either will do, as we prefer
4034 * alloc.c: Integer signedness and overflow fixes.
4035 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4036 (__malloc_size_t): Default to size_t, not to int.
4037 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4038 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4039 Prefer ptrdiff_t to size_t when either would do, as we prefer
4041 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4042 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4043 Now const. Initialize with values that are in range even if char
4045 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4046 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4047 These functions do the right thing with sizes > 2**32.
4048 (check_depth): Now ptrdiff_t, not int.
4049 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4050 Adjust to new way of storing sizes. Check for size overflow bugs
4052 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4053 slightly wrong anyway, as it missed one instance of
4054 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4055 (refill_memory_reserve): Omit needless cast to size_t.
4056 (mark_object_loop_halt): Mark as externally visible.
4058 * xselect.c: Integer signedness and overflow fixes.
4059 (Fx_register_dnd_atom, x_handle_dnd_message):
4060 Use ptrdiff_t, not size_t, since we prefer signed.
4061 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4062 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4063 x_dnd_atoms_size and x_dnd_atoms_length.
4065 * doprnt.c: Prefer signed to unsigned when either works.
4067 * doprnt.c (doprnt):
4069 * xdisp.c (vmessage):
4070 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4071 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4072 prefer signed arithmetic to avoid comparison confusion.
4073 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4074 but is a bit tricky.
4076 Assume freestanding C89 headers, string.h, stdlib.h.
4077 * data.c, doprnt.c, floatfns.c, print.c:
4078 Include float.h unconditionally.
4079 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4080 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4081 * regex.c: Likewise for stddef.h, string.h.
4082 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4083 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4084 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4085 (STDC_HEADERS): Remove obsolete defines.
4086 * sysdep.c: Include limits.h unconditionally.
4088 Assume support for memcmp, memcpy, memmove, memset.
4089 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4090 * regex.c (memcmp, memcpy):
4091 Remove; we assume C89 now.
4093 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4094 (__malloc_safe_bcopy): Remove; no longer needed.
4096 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4097 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4098 well either way, and we prefer signed to unsigned.
4100 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4102 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4103 closes the connection while we're reading (bug#9182).
4105 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4107 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4108 are specified (Bug#9168).
4110 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4112 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4113 Found by GCC static checking and --with-wide-int on a 32-bit host.
4115 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4117 * xdisp.c (compute_display_string_pos): Fix logic of caching
4118 previous display string position. Initialize cached_prev_pos to
4119 -1. Fixes slow-down at the beginning of a buffer.
4121 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4123 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4124 for attrs[LFACE_FONTSET_INDEX].
4126 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4128 * xml.c (parse_region): Remove unused local
4129 that was recently introduced.
4131 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4133 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4134 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4136 * xdisp.c (move_it_in_display_line_to): Record the best matching
4137 position for TO_CHARPOS while scanning the line, and restore it on
4138 exit if none of the characters scanned was an exact match.
4139 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4140 when exact match is impossible due to invisible text, and the
4141 lines are truncated.
4143 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4145 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4148 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4150 Fix a significant slow-down of cursor motion with C-n, C-p,
4151 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4152 auto-repeat under bidi redisplay in fontified buffers.
4153 * xdisp.c (compute_stop_pos_backwards): New function.
4154 (next_element_from_buffer): Call compute_stop_pos_backwards to
4155 find a suitable prev_stop when we find ourselves before
4157 (reseat): Don't look for prev_stop, as that could mean a very long
4159 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4160 <cached_disp_overlay_modiff>: Cache for last found display string
4162 (compute_display_string_pos): Return the cached position if asked
4163 about the same buffer in the same area of character positions, and
4164 the buffer wasn't changed since the time the display string
4165 position was cached.
4167 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4169 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4170 is an integer, which is important for empty lines. (Bug#9149)
4172 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4174 * frame.c (Fmodify_frame_parameters): In tty case, update the
4175 default face if necessary (Bug#4238).
4177 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4179 * editfns.c (Fstring_to_char): No need to explain what a character
4180 is in the docstring (Bug#6576).
4182 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4184 * xml.c (parse_region): Make sure we always return a tree.
4186 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4188 * xml.c (parse_region): If a document contains only comments,
4191 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4193 * xml.c (make_dom): Return comments, too.
4195 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4198 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4199 and the surrounding thread.
4200 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4201 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4202 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4204 * s/openbsd.h (BROKEN_SIGIO): Define.
4205 * unexelf.c (unexec) [__OpenBSD__]:
4206 Don't update the .mdebug section of the Alpha COFF symbol table.
4208 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4210 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4213 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4215 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4216 This fixes some race conditions on the permissions of any newly
4219 * alloc.c (valid_pointer_p): Use pipe, not open.
4220 This fixes some permissions issues when debugging.
4222 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4223 If fchown fails to set both uid and gid, try to set just gid,
4224 as that is sometimes allowed. Adjust the file's mode to eliminate
4225 setuid or setgid bits that are inappropriate if fchown fails.
4227 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4229 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4230 to compare Lisp_Objects.
4231 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4232 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4233 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4235 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4237 * lread.c (read_integer): Unread even EOF character.
4238 (read1): Likewise. Properly record start position of symbol.
4240 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4241 symbol character follows.
4243 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4245 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4246 This works around a problem with the previous change to Fcopy_file.
4247 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4248 and without this change, GCC might complain about discarding
4249 fchown's return value.
4251 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4253 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4255 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4257 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4259 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4261 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4262 it's used from the C level.
4264 * process.c: Use the same condition for POLL_FOR_INPUT in both
4265 keyboard.c and process.c (bug#1858).
4267 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4269 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4270 (Fgnutls_boot): Use it.
4272 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4274 * doc.c (Fsubstitute_command_keys): Revert last change.
4276 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4278 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4279 quotes the next character, and doesn't affect other longer
4280 sequences (bug#8935).
4282 * lread.c (syms_of_lread): Clarify that is isn't only
4283 `eval-buffer' and `eval-defun' that's affected by
4284 `lexical-binding' (bug#8460).
4286 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4288 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4289 bidi redisplay when a line includes both an image and is truncated.
4291 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4293 Fix minor problems found by static checking.
4294 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4295 (elsz): Now a signed constant, not a size_t var. We prefer signed
4296 types to unsigned, to avoid integer comparison confusion. Without
4297 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4298 "cannot optimize loop, the loop counter may overflow", a symptom
4300 * indent.c (Fvertical_motion): Mark locals as initialized.
4301 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4303 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4305 * search.c (Fre_search_backward): Mention `case-fold-search' in
4306 all the re_search_* functions (bug#8138).
4308 * keyboard.c (Fopen_dribble_file): Document when the file is
4311 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4313 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4316 Support bidi reordering of display and overlay strings.
4317 * xdisp.c (compute_display_string_pos)
4318 (compute_display_string_end): Accept additional argument STRING.
4319 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4320 (reseat_to_string): Initialize bidi_it->string.s and
4321 bidi_it->string.schars.
4322 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4323 NULL (avoids a crash in bidi_paragraph_init).
4324 Initialize itb.string.lstring.
4325 (init_iterator): Call bidi_init_it only of a valid
4326 buffer position was specified. Initialize paragraph_embedding to
4328 (reseat_to_string): Initialize the bidi iterator.
4329 (display_string): If we need to ignore text properties of
4330 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4331 original value of -1 will not work with bidi.)
4332 (compute_display_string_pos): First arg is now struct
4333 `text_pos *'; all callers changed. Support display properties on
4335 (compute_display_string_end): Support display properties on Lisp
4337 (init_iterator, reseat_1, reseat_to_string): Initialize the
4338 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4339 when iterating on a string not from display properties).
4340 (compute_display_string_pos, compute_display_string_end):
4341 Fix calculation of the object to scan. Fixes an error when using
4343 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4344 base_level_stop; instead, set base_level_stop to BEGV.
4345 Fixes crashes in vertical-motion.
4346 (next_element_from_buffer): Improve commentary for when
4347 the iterator is before prev_stop.
4348 (init_iterator): Initialize bidi_p from the default value of
4349 bidi-display-reordering, not from buffer-local value. Use the
4350 buffer-local value only if initializing for buffer iteration.
4351 (handle_invisible_prop): Support invisible properties on strings
4352 that are being bidi-reordered.
4353 (set_iterator_to_next): Support bidi reordering of C strings and
4355 (next_element_from_string): Support bidi reordering of Lisp
4357 (handle_stop_backwards): Support Lisp strings as well.
4358 (display_string): Support display of R2L glyph rows.
4359 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4360 (init_iterator): Don't initialize it->bidi_p for strings
4362 (reseat_to_string): Initialize it->bidi_p for strings here.
4363 (next_element_from_string, next_element_from_c_string)
4364 (next_element_from_buffer): Add xassert's for correspondence
4365 between IT's object being iterated and it->bidi_it.string
4367 (face_before_or_after_it_pos): Support bidi iteration.
4368 (next_element_from_c_string): Handle the case of the first string
4369 character that is not the first one in the visual order.
4370 (get_visually_first_element): New function, refactored from common
4371 parts of next_element_from_buffer, next_element_from_string, and
4372 next_element_from_c_string.
4373 (tool_bar_lines_needed, redisplay_tool_bar)
4374 (display_menu_bar): Force left-to-right direction. Add a FIXME
4375 comment for making that be controlled by a user option.
4376 (push_it, pop_it): Save and restore the state of the
4377 bidi iterator. Save and restore the bidi_p flag.
4378 (pop_it): Iterate out of display property for string iteration as
4380 (iterate_out_of_display_property): Support iteration over strings.
4381 (handle_single_display_spec): Set up it->bidi_it for iteration
4382 over a display string, and call bidi_init_it.
4383 (handle_single_display_spec, next_overlay_string)
4384 (get_overlay_strings_1, push_display_prop): Set up the bidi
4385 iterator for displaying display or overlay strings.
4386 (forward_to_next_line_start): Don't use the shortcut if
4388 (back_to_previous_visible_line_start): If handle_display_prop
4389 pushed the iterator stack, restore the internal state of the bidi
4390 iterator by calling bidi_pop_it same number of times.
4391 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4392 and we are bidi-iterating, don't decrement the iterator position;
4393 instead, set the first_elt flag in the bidi iterator, to produce
4395 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4396 (push_display_prop): xassert that we are iterating a buffer.
4397 (push_it, pop_it): Save and restore paragraph_embedding member.
4398 (handle_single_display_spec, next_overlay_string)
4399 (get_overlay_strings_1, reseat_1, reseat_to_string)
4400 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4401 correctly. Don't assume unibyte strings are not bidi-reordered.
4402 (compute_display_string_pos)
4403 (compute_display_string_end): Fix handling the case of C string.
4404 (push_it, pop_it): Save and restore from_disp_prop_p.
4405 (handle_single_display_spec, push_display_prop): Set the
4406 from_disp_prop_p flag.
4407 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4408 (pop_it): Call iterate_out_of_display_property only if we are
4409 popping after iteration over a string that came from a display
4410 property. Fix a typo in popping stretch info. Add an assertion
4411 for verifying that the iterator position is in sync with the bidi
4413 (handle_single_display_spec, get_overlay_strings_1)
4414 (push_display_prop): Fix initialization of paragraph direction for
4415 string when that of the parent object is not yet determined.
4416 (reseat_1): Call bidi_init_it to resync the bidi
4417 iterator with IT's position. (Bug#7616)
4418 (find_row_edges): If ROW->start.pos gives position
4419 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4420 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4421 Reset the from_disp_prop_p flag.
4422 (SAVE_IT, RESTORE_IT): New macros.
4423 (pos_visible_p, face_before_or_after_it_pos)
4424 (back_to_previous_visible_line_start)
4425 (move_it_in_display_line_to, move_it_in_display_line)
4426 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4427 (try_scrolling, redisplay_window, display_line): Use them when
4428 saving a temporary copy of the iterator and restoring it back.
4429 (back_to_previous_visible_line_start, reseat_1)
4430 (init_iterator): Empty the bidi cache "stack".
4431 (move_it_in_display_line_to): If iterator ended up at
4432 EOL, but we never saw any buffer positions smaller than
4433 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4434 motion in bidi-reordered lines.
4435 (move_it_in_display_line_to): Record prev_method and prev_pos
4436 immediately before the call to set_iterator_to_next. Fixes cursor
4437 motion in bidi-reordered lines with stretch glyphs and strings
4438 displayed in margins. (Bug#8133) (Bug#8867)
4439 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4441 (pos_visible_p): Support positions in bidi-reordered lines.
4442 Save and restore bidi cache.
4444 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4445 (bidi_paragraph_info): Delete unused struct.
4446 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4447 (bidi_cache_start): New variable.
4448 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4450 (bidi_cache_fetch_state, bidi_cache_search)
4451 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4452 (bidi_cache_find, bidi_peek_at_next_level)
4453 (bidi_level_of_next_char, bidi_find_other_level_edge)
4454 (bidi_move_to_visually_next): Compare cache index with
4455 bidi_cache_start rather than with zero.
4456 (bidi_fetch_char): Accept new argument STRING; all callers
4457 changed. Support iteration over a string. Support strings with
4458 display properties. Support unibyte strings. Fix the type of
4459 `len' according to what STRING_CHAR_AND_LENGTH expects.
4460 (bidi_paragraph_init, bidi_resolve_explicit_1)
4461 (bidi_resolve_explicit, bidi_resolve_weak)
4462 (bidi_level_of_next_char, bidi_move_to_visually_next):
4463 Support iteration over a string.
4464 (bidi_set_sor_type, bidi_resolve_explicit_1)
4465 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4466 can now be zero (for strings); special values 0 and -1 were
4467 changed to -1 and -2, respectively.
4468 (bidi_char_at_pos): New function.
4469 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4470 Call it instead of FETCH_MULTIBYTE_CHAR.
4471 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4472 initialized to valid values.
4473 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4475 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4476 the test for valid cached positions. Fix the logic for looking up
4477 the sentinel state in the cache. GCPRO the Lisp string we are
4479 (bidi_push_it, bidi_pop_it): New functions.
4480 (bidi_initialize): Initialize the bidi cache start stack pointer.
4481 (bidi_cache_ensure_space): New function, refactored from part of
4482 bidi_cache_iterator_state. Don't assume the required size is just
4483 one BIDI_CACHE_CHUNK away.
4484 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4485 (bidi_count_bytes, bidi_char_at_pos): New functions.
4486 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4487 always valid if bidi_cache_idx is valid.
4488 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4489 is valid if it's going to be used.
4490 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4491 (bidi_cache_fetch_state, bidi_cache_search)
4492 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4493 (bidi_cache_iterator_state, bidi_cache_find)
4494 (bidi_find_other_level_edge, bidi_cache_start_stack):
4495 All variables related to cache indices are now EMACS_INT.
4497 * dispextern.h (struct bidi_string_data): New structure.
4498 (struct bidi_it): New member `string'. Make flag members be 1-bit
4499 fields, and put them last in the struct.
4500 (compute_display_string_pos, compute_display_string_end):
4502 (bidi_push_it, bidi_pop_it): Add prototypes.
4503 (struct iterator_stack_entry): New members bidi_p,
4504 paragraph_embedding, and from_disp_prop_p.
4505 (struct it): Member bidi_p is now a bit field 1 bit wide.
4506 (bidi_shelve_cache, bidi_unshelve_cache):
4509 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4510 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4511 and vector-like objects.
4513 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4514 cache around display iteration.
4516 * window.c (Fwindow_end, window_scroll_pixel_based)
4517 (displayed_window_lines, Frecenter): Save and restore the bidi
4518 cache around display iteration.
4520 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4522 * editfns.c (Fdelete_region): Clarify the use of the named
4523 parameters (bug#6788).
4525 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4527 * indent.c (Fvertical_motion): Set and restore w->pointm when
4528 saving and restoring the window's buffer (Bug#9006).
4530 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4532 * editfns.c (Fstring_to_char): Clarify just what is returned
4533 (bug#6576). Text by Eli Zaretskii.
4535 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4537 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4539 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4541 * buffer.c (mmap_find): Fix a typo.
4543 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4545 Fix execution of x selection hooks.
4546 * xselect.c (Qx_lost_selection_functions)
4547 (Qx_sent_selection_functions): New vars.
4548 (syms_of_xselect): DEFSYM them.
4549 (x_handle_selection_request): Pass Qx_sent_selection_functions
4550 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4551 (x_handle_selection_clear,x_clear_frame_selections):
4552 Pass Qx_lost_selection_functions rather than
4553 Vx_lost_selection_functions to Frun_hook_with_args.
4555 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4557 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4558 The old code sometimes used this field without initializing it.
4560 * alloc.c (gc_sweep): Don't read past end of array.
4561 In theory, the old code could also have corrupted Emacs internals,
4562 though it'd be very unlikely.
4564 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4566 * character.c (Fcharacterp): Don't advertise optional ignored
4567 argument. (Bug#4026)
4569 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4571 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4574 * window.c (Fset_window_start): Doc fix (bug#4199).
4575 (Fset_window_hscroll): Ditto.
4577 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4579 Fix minor new problems caught by GCC 4.6.1.
4580 * term.c (init_tty): Remove unused local.
4581 * xsettings.c (store_monospaced_changed): Define this function only
4582 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4585 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4587 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4589 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4591 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4592 are the mini-buffer and the echo area (bug#3320).
4594 * term.c (init_tty): Remove support for supdup, c10 and perq
4595 terminals, which are no longer supported (bug#1482).
4597 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4599 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4601 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4603 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4604 for non-popups (Bug#3642).
4606 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4608 * alloc.c (reset_malloc_hooks): Protoize.
4609 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4610 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4611 * cm.c (losecursor): Likewise.
4612 * data.c (fmod): Likewise.
4613 * dispnew.c (swap_glyphs_in_rows): Likewise.
4614 * emacs.c (memory_warning_signal): Likewise.
4615 * floatfns.c (float_error): Likewise.
4616 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4617 (otf_open, font_otf_capability, generate_otf_features)
4618 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4620 * image.c (pbm_read_file): Likewise.
4621 * indent.c (string_display_width): Likewise.
4622 * intervals.c (check_for_interval, search_for_interval)
4623 (inc_interval_count, count_intervals, root_interval)
4624 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4625 * lread.c (defalias): Likewise.
4626 * ralloc.c (r_alloc_check): Likewise.
4627 * regex.c (set_image_of_range_1, set_image_of_range)
4628 (regex_grow_registers): Likewise.
4629 * sysdep.c (strerror): Likewise.
4630 * termcap.c (valid_filename_p, tprint, main): Likewise.
4631 * tparam.c (main): Likewise.
4632 * unexhp9k800.c (run_time_remap, save_data_space)
4633 (update_file_ptrs, read_header, write_header, calculate_checksum)
4634 (copy_file, copy_rest, display_header): Likewise.
4635 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4637 * xdisp.c (check_it): Likewise.
4638 * xfaces.c (register_color, unregister_color, unregister_colors):
4640 * xfns.c (print_fontset_result): Likewise.
4641 * xrdb.c (member, fatal, main): Likewise.
4643 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4645 Fix minor problems found by static checking (Bug#9031).
4646 * chartab.c (char_table_set_range, map_sub_char_table):
4647 Remove unused locals.
4648 (uniprop_table): Now static.
4649 * composite.c (_work_char): Remove unused static var.
4651 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4653 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4655 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4657 * gtkutil.c (qttip_cb): Remove code without function.
4659 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4661 * w32.c (pthread_sigmask): New stub.
4663 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4665 Use pthread_sigmask, not sigprocmask (Bug#9010).
4666 sigprocmask is portable only for single-threaded applications, and
4667 Emacs can be multi-threaded when it uses GTK.
4668 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4670 * callproc.c (Fcall_process):
4671 * process.c (create_process):
4672 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4673 Use pthread_sigmask, not sigprocmask.
4675 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4677 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4678 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4681 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4683 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4684 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4685 (xg_hide_tooltip): Fix comment.
4687 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4688 in registerServicesMenuSendTypes.
4689 (validRequestorForSendType): Don't check ns_return_types.
4691 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4694 2011-07-08 Jason Rumney <jasonr@gnu.org>
4696 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4697 SH_SHOW for hidden windows (Bug#5482).
4699 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4700 frame struct members of non-existent frames (Bug#6284).
4702 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4704 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4705 variable firstTime not needed on OSX >= 10.6.
4706 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4707 >= 10.5. Use setKnobProportion, setDoubleValue.
4709 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4710 (MAC_OS_X_VERSION_10_5): Define if not defined.
4711 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4712 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4713 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4715 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4716 cString and lossyCString on OSX >= 10.4
4718 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4719 sizeToFit on OSX >= 10.2.
4721 * nsimage.m (allocInitFromFile): Don't use deprecated method
4722 bestRepresentationForDevice on OSX >= 10.6.
4724 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4727 * emacs.c: Declare unexec_init_emacs_zone.
4729 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4731 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4733 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4734 on svcsMenu (Bug#8842).
4736 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4738 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4740 * nsterm.m (QUTF8_STRING): Declare.
4741 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4742 (validRequestorForSendType): Return type is (id).
4743 Change indexOfObjectIdenticalTo to indexOfObject.
4744 Check if we have local selection before returning self (Bug#8842).
4745 (writeSelectionToPasteboard): Put local selection into paste board
4746 if we have a local selection (Bug#8842).
4747 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4749 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4750 (ns_get_local_selection): Declare.
4752 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4754 * keymap.c (describe_map_tree): Don't insert a double newline at
4755 the end of the buffer (bug#1169) and return whether we inserted
4758 * callint.c (Fcall_interactively): Change "reading args" to
4759 "providing args" to try to clarify what it does (bug#1010).
4761 2011-07-07 Kenichi Handa <handa@m17n.org>
4763 * composite.c (composition_compute_stop_pos): Ignore a static
4764 composition starting before CHARPOS (Bug#8915).
4766 * xdisp.c (handle_composition_prop): Likewise.
4768 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4770 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4773 2011-07-07 Kenichi Handa <handa@m17n.org>
4775 * character.h (unicode_category_t): New enum type.
4777 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4778 (Qchar_code_property_table): New variable.
4779 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4780 (UNIPROP_COMPRESSED_FORM_P): New macros.
4781 (char_table_ascii): Uncompress the compressed values.
4782 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4783 Uncompress the compressed values.
4784 (sub_char_table_ref_and_range): Likewise.
4785 (char_table_ref_and_range): Uncompress the compressed values.
4786 (sub_char_table_set): New arg is_uniprop. Callers changed.
4787 Uncompress the compressed values.
4788 (sub_char_table_set_range): Args changed. Callers changed.
4789 (char_table_set_range): Adjuted for the above change.
4790 (map_sub_char_table): Delete args default_val and parent. Add arg
4791 top. Give decoded values to a Lisp function.
4792 (map_char_table): Adjust for the above change. Give decoded
4793 values to a Lisp function. Gcpro more variables.
4794 (uniprop_table_uncompress)
4795 (uniprop_decode_value_run_length): New functions.
4796 (uniprop_decoder, uniprop_decoder_count): New variables.
4797 (uniprop_get_decoder, uniprop_encode_value_character)
4798 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4800 (uniprop_encoder, uniprop_encoder_count): New variables.
4801 (uniprop_get_encoder, uniprop_table)
4802 (Funicode_property_table_internal, Fget_unicode_property_internal)
4803 (Fput_unicode_property_internal): New functions.
4804 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4805 Sunicode_property_table_internal, Sget_unicode_property_internal,
4806 and Sput_unicode_property_internal. Defvar_lisp
4807 char-code-property-alist.
4809 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4810 Vunicode_category_table.
4812 * font.c (font_range): Adjust for the change of
4813 Vunicode_category_table.
4815 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4817 * m/iris4d.h: Remove file, move contents ...
4818 * s/irix6-5.h: ... here.
4820 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4822 Remove unportable assumption about struct layout (Bug#8884).
4823 * alloc.c (mark_buffer):
4824 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4825 (clone_per_buffer_values): Don't assume that
4826 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4827 This isn't true in general, and it's particularly not true
4828 if Emacs is configured with --with-wide-int.
4829 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4830 New macros, used in the buffer.c change.
4832 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4834 * xsettings.c: Use both GConf and GSettings if both are available.
4835 (store_config_changed_event): Add comment.
4836 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4837 (store_tool_bar_style_changed): New functions.
4838 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4839 (struct xsettings): Move font inside HAVE_XFT.
4840 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4841 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4842 Move inside HAVE_XFT.
4843 (something_changed_gsettingsCB): Rename from something_changedCB.
4844 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4846 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4847 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4848 (something_changed_gconfCB): Rename from something_changedCB.
4849 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4850 (parse_settings): Move check for font inside HAVE_XFT.
4851 (read_settings, apply_xft_settings): Add comment.
4852 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4853 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4854 call store_font_name_changed.
4855 (xft_settings_event): Add comment.
4856 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4857 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4858 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4859 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4860 (xsettings_initialize): Call init_gsettings last.
4861 (xsettings_get_system_font, xsettings_get_system_normal_font):
4864 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4866 Random fixes. E.g., (random) never returned negative values.
4867 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4868 subseconds part to the entropy, as that's a bit more random.
4869 Prefer signed to unsigned, since the signedness doesn't matter and
4870 in general we prefer signed. When given a limit, use a
4871 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4872 latter isn't right if USE_2_TAGS_FOR_INTS.
4873 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4874 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4876 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4878 * textprop.c (text_property_stickiness):
4879 Obey Vtext_property_default_nonsticky.
4880 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4881 * w32fns.c (syms_of_w32fns):
4882 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4884 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4886 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4887 This is more efficient than Ffile_directory_p and avoids a minor race.
4889 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4891 * buffer.c (Foverlay_put): Say what the return value is
4894 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4895 is a directory before asking whether to use the file name
4897 (barf_or_query_if_file_exists): Make the "File is a directory"
4898 error be more correct.
4900 * fns.c (Frequire): Remove the mention of the .gz files, since
4901 that's installation-specific, but keep the mention of
4902 `get-load-suffixes'.
4904 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4906 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4907 Report string overflow if the output is too long.
4909 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4911 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4912 (syms_of_gnutls): Remove duplicate DEFSYM for
4913 Qgnutls_bootprop_verify_hostname_error, an error for
4914 Qgnutls_bootprop_verify_error (which is no longer used).
4916 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4917 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4918 Also (re)move comments that are misplaced or no longer relevant.
4920 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4922 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4924 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4926 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4927 and background color parameters if they have been changed.
4929 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4931 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4933 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4935 * xsettings.c (SYSTEM_FONT): Define only when used.
4936 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4938 * keymap.c (access_keymap_1): Now static.
4940 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4942 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4943 leave any prefix arg for the up event (Bug#1586).
4945 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4947 * lread.c (syms_of_lread): Mention single symbols defined by
4948 `defvar' or `defconst' (bug#7154).
4950 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4951 (Frequire): Mention get-load-suffixes.
4953 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4955 * window.h (window): Remove clone_number slot.
4956 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4958 (make_parent_window, make_window, saved_window)
4959 (Fset_window_configuration, save_window_save): Don't deal with
4961 * buffer.c (Qclone_number): Remove declaration.
4962 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4964 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4966 Add multiple inheritance to keymaps.
4967 * keymap.c (Fmake_composed_keymap): New function.
4968 (Fset_keymap_parent): Simplify.
4969 (fix_submap_inheritance): Remove.
4970 (access_keymap_1): New function extracted from access_keymap to handle
4971 embedded parents and handle lists of maps.
4972 (access_keymap): Use it.
4973 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4974 (Fcopy_keymap): Handle embedded parents.
4975 (Fcommand_remapping, define_as_prefix): Simplify.
4976 (Fkey_binding): Simplify.
4977 (syms_of_keymap): Move minibuffer-local-completion-map,
4978 minibuffer-local-filename-completion-map,
4979 minibuffer-local-must-match-map, and
4980 minibuffer-local-filename-must-match-map to Elisp.
4981 (syms_of_keymap): Defsubr make-composed-keymap.
4982 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4983 (parse_menu_item): Trivial simplification.
4985 2011-07-01 Glenn Morris <rgm@gnu.org>
4987 * Makefile.in (SETTINGS_LIBS): Fix typo.
4989 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4991 * coding.c (Fencode_coding_string): Record the last coding system
4992 used, as the function doc string says (bug#8738).
4994 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4996 * xsettings.c (store_monospaced_changed): Take new font as arg and
4997 check for change against current_mono_font.
4998 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4999 (emacs_settings_constructor, emacs_settings_get_property)
5000 (emacs_settings_set_property, emacs_settings_class_init)
5001 (emacs_settings_init, gsettings_obj): Remove.
5002 (something_changedCB): New function for HAVE_GSETTINGS.
5003 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5004 with value as argument.
5005 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5006 g_settings_new (Bug#8967). Do not create gsettings_obj.
5007 Remove calls to g_settings_bind. Connect something_changedCB to
5010 * xgselect.c: Add defined (HAVE_GSETTINGS).
5011 (xgselect_initialize): Ditto.
5013 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5014 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5017 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5019 * eval.c (struct backtrace): Simplify and port the data structure.
5020 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5021 signed bit field, as this assumption is not portable and it makes
5022 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5023 "char debug_on_exit : 1" as this is not portable either; instead,
5024 use the portable "unsigned int debug_on_exit : 1". Remove unused
5025 member evalargs. Remove obsolete comments about cc bombing out.
5027 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5029 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5030 Let HAVE_GSETTINGS override HAVE_GCONF.
5031 (store_monospaced_changed): New function.
5032 (EMACS_SETTINGS): A new type derived from GObject to handle
5033 GSettings notifications.
5034 (emacs_settings_constructor, emacs_settings_get_property)
5035 (emacs_settings_set_property, emacs_settings_class_init):
5037 (gsettings_client, gsettings_obj): New variables.
5038 (GSETTINGS_SCHEMA): New define.
5039 (something_changedCB): Call store_monospaced_changed.
5040 (init_gsettings): New function.
5041 (xsettings_initialize): Call init_gsettings.
5042 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5045 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5048 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5050 * window.c (resize_root_window, grow_mini_window)
5051 (shrink_mini_window): Rename Qresize_root_window to
5052 Qwindow_resize_root_window and Qresize_root_window_vertically to
5053 Qwindow_resize_root_window_vertically.
5055 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5057 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5059 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5061 * makefile.w32-in: Redesign dependencies so they reflect more
5062 clearly which files are directly included by each source file,
5063 and not through other includes.
5065 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5067 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5068 (sort_overlays, overlay_strings): When an overlay's clone number
5069 matches the window's clone number process the overlay even if
5070 the overlay's window property doesn't match the current window.
5072 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5073 (Fwindow_hchild): Rename to Fwindow_left_child.
5074 (Fwindow_next): Rename to Fwindow_next_sibling.
5075 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5076 (resize_window_check): Rename to window_resize_check.
5077 (resize_window_apply): Rename to window_resize_apply.
5078 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5079 (Fdelete_other_windows_internal, resize_frame_windows)
5080 (Fsplit_window_internal, Fdelete_window_internal)
5081 (grow_mini_window, shrink_mini_window)
5082 (Fresize_mini_window_internal): Fix callers accordingly.
5084 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5086 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5087 (emacs_fixed_set_min_size): Remove.
5088 (emacs_fixed_new): Take frame as argument.
5090 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5091 (_EmacsFixedPrivate): Remove minwidth/height.
5092 Add struct frame *f.
5093 (emacs_fixed_init): Initialize priv->f.
5094 (get_parent_class, emacs_fixed_set_min_size): Remove.
5095 (emacs_fixed_new): Set priv->f to argument.
5096 (emacs_fixed_get_preferred_width)
5097 (emacs_fixed_get_preferred_height): Use min_width/height from
5098 frames size_hint to set minimum and natural (Bug#8919).
5099 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5100 and use min_width/height from frames size_hint to set
5101 min_width/height (Bug#8919).
5103 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5104 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5107 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5109 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5110 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5113 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5115 * process.c (wait_reading_process_output): Bypass select if
5116 waiting for a cell while ignoring keyboard input, and input is
5117 pending. Suggested by Jan Djärv (Bug#8869).
5119 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5121 Use gnulib's dup2 module instead of rolling our own.
5122 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5124 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5126 * dispnew.c (scrolling_window): Before scrolling, turn off a
5127 mouse-highlight in the window being scrolled.
5129 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5131 Move DEFSYM to lisp.h and use everywhere.
5133 * character.h (DEFSYM): Move declaration...
5134 * lisp.h (DEFSYM): ...here.
5140 * w32select.c: Don't include character.h.
5142 * alloc.c (syms_of_alloc):
5143 * buffer.c (syms_of_buffer):
5144 * bytecode.c (syms_of_bytecode):
5145 * callint.c (syms_of_callint):
5146 * casefiddle.c (syms_of_casefiddle):
5147 * casetab.c (init_casetab_once):
5148 * category.c (init_category_once, syms_of_category):
5149 * ccl.c (syms_of_ccl):
5150 * cmds.c (syms_of_cmds):
5151 * composite.c (syms_of_composite):
5152 * dbusbind.c (syms_of_dbusbind):
5153 * dired.c (syms_of_dired):
5154 * dispnew.c (syms_of_display):
5155 * doc.c (syms_of_doc):
5156 * editfns.c (syms_of_editfns):
5157 * emacs.c (syms_of_emacs):
5158 * eval.c (syms_of_eval):
5159 * fileio.c (syms_of_fileio):
5160 * fns.c (syms_of_fns):
5161 * frame.c (syms_of_frame):
5162 * fringe.c (syms_of_fringe):
5163 * insdel.c (syms_of_insdel):
5164 * keymap.c (syms_of_keymap):
5165 * lread.c (init_obarray, syms_of_lread):
5166 * macros.c (syms_of_macros):
5167 * msdos.c (syms_of_msdos):
5168 * print.c (syms_of_print):
5169 * process.c (syms_of_process):
5170 * search.c (syms_of_search):
5171 * sound.c (syms_of_sound):
5172 * syntax.c (init_syntax_once, syms_of_syntax):
5173 * terminal.c (syms_of_terminal):
5174 * textprop.c (syms_of_textprop):
5175 * undo.c (syms_of_undo):
5176 * w32.c (globals_of_w32):
5177 * window.c (syms_of_window):
5178 * xdisp.c (syms_of_xdisp):
5179 * xfaces.c (syms_of_xfaces):
5180 * xfns.c (syms_of_xfns):
5181 * xmenu.c (syms_of_xmenu):
5182 * xsettings.c (syms_of_xsettings):
5183 * xterm.c (syms_of_xterm): Use DEFSYM.
5185 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5187 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5189 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5191 Integer and buffer overflow fixes (Bug#8873).
5193 * print.c (printchar, strout): Check for string overflow.
5194 (PRINTPREPARE, printchar, strout):
5195 Don't set size unless allocation succeeds.
5197 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5198 for sizes. Check for string overflow more accurately.
5199 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5201 * macros.c: Integer and buffer overflow fixes.
5202 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5203 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5204 Use ptrdiff_t, not int, for sizes.
5205 Don't increment bufsize until after realloc succeeds.
5206 Check for size-calculation overflow.
5207 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5209 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5211 * lread.c: Integer overflow fixes.
5212 (read_integer): Radix is now EMACS_INT, not int,
5213 to improve quality of diagnostics for out-of-range radices.
5214 Calculate buffer size correctly for out-of-range radices.
5215 (read1): Check for integer overflow in radices, and in
5216 read-circle numbers.
5217 (read_escape): Avoid int overflow.
5218 (Fload, openp, read_buffer_size, read1)
5219 (substitute_object_recurse, read_vector, read_list, map_obarray):
5220 Use ptrdiff_t, not int, for sizes.
5221 (read1): Use EMACS_INT, not int, for sizes.
5222 Check for size overflow.
5224 * image.c (cache_image): Check for size arithmetic overflow.
5226 * lread.c: Integer overflow issues.
5227 (saved_doc_string_size, saved_doc_string_length)
5228 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5229 Now ptrdiff_t, not int.
5230 (read1): Don't assume doc string length fits in int. Check for
5231 out-of-range doc string lengths.
5232 (read_list): Don't assume file position fits in int.
5233 (read_escape): Check for hex character overflow.
5235 2011-06-22 Leo Liu <sdl.web@gmail.com>
5237 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5238 Move to minibuffer.el.
5240 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5242 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5243 The following patches are for when GLYPH_DEBUG && !XASSERT.
5244 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5245 * dispnew.c (flush_stdout):
5246 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5247 Mark as externally visible.
5248 * dispnew.c (check_window_matrix_pointers): Now static.
5249 * dispnew.c (window_to_frame_vpos):
5250 * xfns.c (unwind_create_frame):
5251 * xterm.c (x_check_font): Remove unused local.
5252 * scroll.c (CHECK_BOUNDS):
5253 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5254 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5255 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5256 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5257 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5259 (debug_method_add): Use va_list and vsprintf rather than relying
5260 on undefined behavior with wrong number of arguments.
5261 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5262 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5263 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5264 since we're not interested in debugging glyphs with old libraries.
5265 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5266 GCC 4.6.0's static checking.
5268 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5270 Integer overflow and signedness fixes (Bug#8873).
5271 A few related buffer overrun fixes, too.
5273 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5275 * dispextern.h (struct face.stipple):
5276 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5277 (x_bitmap_mask, x_allocate_bitmap_record)
5278 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5279 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5280 (x_create_bitmap_from_xpm_data):
5281 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5282 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5284 * xfaces.c (load_pixmap):
5285 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5286 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5287 (.bitmaps_last, struct x_output.icon_bitmap):
5288 Use ptrdiff_t, not int, for bitmap indexes.
5289 (x_allocate_bitmap_record): Check for size overflow.
5290 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5292 Use ptrdiff_t, not int, for overlay counts.
5293 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5294 * editfns.c (overlays_around, get_pos_property):
5295 * textprop.c (get_char_property_and_overlay):
5296 * xdisp.c (next_overlay_change, note_mouse_highlight):
5297 * xfaces.c (face_at_buffer_position):
5298 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5299 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5300 (Fnext_overlay_change, Fprevious_overlay_change)
5301 (mouse_face_overlay_overlaps, Foverlays_in):
5302 Use ptrdiff_t, not int, for sizes.
5303 (overlays_at, overlays_in): Check for size-calculation overflow.
5305 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5307 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5308 (x_session_initialize): Do not assume string length fits in int.
5310 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5311 This is unlikely, but can occur if DPI is outlandish.
5313 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5314 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5316 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5317 * xrdb.c (magic_file_p, search_magic_path):
5318 Omit last arg SUFFIX; it was always 0. All callers changed.
5319 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5321 * xfont.c (xfont_match): Avoid need for strlen.
5323 * xfns.c: Don't assume strlen fits in int.
5324 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5326 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5327 not unsigned long, as we prefer signed integers. All callers changed.
5328 Detect integer overflow in repeat count.
5329 (message_dolog): Don't assume print length fits in 39 bytes.
5330 (display_mode_element): Don't assume strlen fits in int.
5332 * termcap.c: Don't assume sizes fit in int and never overflow.
5333 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5334 (gobble_line): Check for size-calculation overflow.
5336 * minibuf.c (Fread_buffer):
5337 * lread.c (intern, intern_c_string):
5338 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5339 Don't assume string length fits in int.
5341 * keyboard.c (parse_tool_bar_item):
5342 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5344 * font.c: Don't assume string length fits in int.
5345 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5346 Use ptrdiff_t, not int.
5347 (font_intern_prop): Don't assume string length fits in int.
5348 Don't assume integer property fits in fixnum.
5349 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5351 * filelock.c: Fix some buffer overrun and integer overflow issues.
5352 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5353 Reformulate so as not to need the command string.
5354 Invoke gzip -cd rather than gunzip, as it's more portable.
5355 (lock_info_type, lock_file_1, lock_file):
5356 Don't assume pid_t and time_t fit in unsigned long.
5357 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5358 (current_lock_owner): Prefer signed type for sizes.
5359 Use memcpy, not strncpy, where memcpy is what is really wanted.
5360 Don't assume (via atoi) that time_t and pid_t fit in int.
5361 Check for time_t and/or pid_t out of range, e.g., via a network share.
5362 Don't alloca where an auto var works fine.
5364 * fileio.c: Fix some integer overflow issues.
5365 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5366 Don't assume string length fits in int.
5367 (directory_file_name): Don't assume string length fits in long.
5368 (make_temp_name): Don't assume pid fits in int, or that its print
5369 length is less than 20.
5371 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5373 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5375 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5377 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5378 We prefer signed integers, even for size calculations.
5380 * emacs.c: Don't assume string length fits in 'int'.
5381 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5382 (main): Don't invoke strlen when not needed.
5384 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5385 (XD_DEBUG_MESSAGE): Don't waste a byte.
5387 * callproc.c (getenv_internal_1, getenv_internal)
5389 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5391 * lread.c (invalid_syntax): Omit length argument.
5392 All uses changed. This doesn't fix a bug, but it simplifies the
5393 code away from its former Hollerith-constant appearance, and it's
5394 one less 'int' to worry about when looking at integer-overflow issues.
5395 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5397 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5398 This didn't break anything, but it didn't help either.
5399 It's confusing to put a bogus integer in a place where the actual
5400 value does not matter.
5401 (LIST_END_P): Remove unused macro and its bogus comment.
5402 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5404 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5405 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5407 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5408 We prefer signed types, and the value cannot exceed the EMACS_INT
5409 range anyway (because otherwise the length would not be representable).
5410 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5411 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5412 This avoids a GCC warning when WIDE_EMACS_INT.
5414 * indent.c (sane_tab_width): New function.
5415 (current_column, scan_for_column, Findent_to, position_indentation)
5416 (compute_motion): Use it. This is just for clarity.
5417 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5419 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5421 * lisp.h (lint_assume): New macro.
5422 * composite.c (composition_gstring_put_cache):
5423 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5425 * editfns.c, insdel.c:
5426 Omit unnecessary forward decls, to simplify future changes.
5428 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5430 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5432 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5433 Use much-faster test for byte-length change.
5434 Don't assume string byte-length fits in 'int'.
5435 Check that character arg fits in 'int'.
5436 (mapcar1): Declare byte as byte, for clarity.
5438 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5440 * fns.c (concat): Catch string overflow earlier.
5441 Do not rely on integer wraparound.
5443 * dispextern.h (struct it.overlay_strings_charpos)
5444 (struct it.selective): Now EMACS_INT, not int.
5445 * xdisp.c (forward_to_next_line_start)
5446 (back_to_previous_visible_line_start)
5447 (reseat_at_next_visible_line_start, next_element_from_buffer):
5448 Don't arbitrarily truncate the value of 'selective' to int.
5450 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5452 * composite.c: Don't truncate sizes to 'int'.
5453 (composition_gstring_p, composition_reseat_it)
5454 (composition_adjust_point): Use EMACS_INT, not int.
5455 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5456 not EMACS_UINT, for indexes.
5458 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5460 * buffer.c: Include <verify.h>.
5461 (struct sortvec.priority, struct sortstr.priority):
5462 Now EMACS_INT, not int.
5463 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5464 (struct sortstr.size, record_overlay_string)
5465 (struct sortstrlist.size, struct sortlist.used):
5466 Don't truncate size to int.
5467 (record_overlay_string): Check for size-calculation overflow.
5468 (init_buffer_once): Check at compile-time, not run-time.
5470 2011-06-22 Jim Meyering <meyering@redhat.com>
5472 Don't leak an XBM-image-sized buffer
5473 * image.c (xbm_load): Free the image buffer after using it.
5475 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5478 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5479 that Sun C diagnosed.
5480 * fns.c (secure_hash): Fix pointer signedness issue.
5481 * intervals.c (static_offset_intervals): New function.
5482 (offset_intervals): Use it.
5484 2011-06-21 Leo Liu <sdl.web@gmail.com>
5487 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5490 * fns.c (secure_hash): Rename from crypto_hash_function and change
5491 the first arg to accept symbols.
5492 (Fsecure_hash): New primitive.
5493 (syms_of_fns): New symbols.
5495 2011-06-20 Deniz Dogan <deniz@dogan.se>
5497 * process.c (Fset_process_buffer): Clarify return value in
5500 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5502 * dispnew.c (add_window_display_history): Use BVAR.
5504 * xdisp.c (debug_method_add): Use BVAR.
5505 (check_window_end, dump_glyph_matrix, dump_glyph)
5506 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5508 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5511 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5512 check till after the cache is created in init_frame_faces.
5514 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5516 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5518 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5520 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5521 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5522 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5524 Improve buffer-overflow checking (Bug#8873).
5525 * fileio.c (Finsert_file_contents):
5526 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5527 Remove the old (too-loose) buffer overflow checks.
5528 They weren't needed, since make_gap checks for buffer overflow.
5529 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5530 The old code merely checked for Emacs fixnum overflow, and relied
5531 on undefined (wraparound) behavior. The new code avoids undefined
5532 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5534 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5535 Tune. Don't use wider integers than needed. Don't use alloca.
5536 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5538 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5540 * insdel.c, lisp.h (buffer_overflow): New function.
5541 (insert_from_buffer_1, replace_range, replace_range_2):
5542 * insdel.c (make_gap_larger):
5543 * editfns.c (Finsert_char):
5544 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5546 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5548 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5550 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5552 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5553 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5555 * fileio.c: Don't assume EMACS_INT fits in off_t.
5556 (emacs_lseek): New static function.
5557 (Finsert_file_contents, Fwrite_region): Use it.
5558 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5560 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5562 * fns.c: Don't overflow int when computing a list length.
5563 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5564 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5565 truncation on 64-bit hosts. Check for QUIT every
5566 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5567 faster and is responsive enough.
5568 (Flength): Report an error instead of overflowing an integer.
5569 (Fsafe_length): Return a float if the value is not representable
5570 as a fixnum. This shouldn't happen except in contrived situations.
5571 (Fnthcdr, Fsort): Don't assume list length fits in int.
5572 (Fcopy_sequence): Don't assume vector length fits in int.
5574 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5575 (header_size, word_size): New constants.
5576 (allocate_vectorlike): Don't check size overflow here.
5577 (allocate_vector): Check it here instead, since this is the only
5578 caller of allocate_vectorlike that could cause overflow.
5579 Check that the new vector's length is representable as a fixnum.
5581 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5582 The previous code was bogus. For example, next_almost_prime (32)
5583 returned 39, which is undesirable as it is a multiple of 3; and
5584 next_almost_prime (24) returned 25, which is a multiple of 5 so
5585 why was the code bothering to check for multiples of 7?
5587 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5589 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5591 Variadic C functions now count arguments with ptrdiff_t.
5592 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5593 Back then I didn't know that the Emacs coding style prefers signed int.
5594 Also, in the meantime I found a few more instances where arguments
5595 were being counted with int, which may truncate counts on 64-bit
5596 machines, or EMACS_INT, which may be unnecessarily wide.
5597 * lisp.h (struct Lisp_Subr.function.aMANY)
5598 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5599 Arg counts are now ptrdiff_t, not size_t.
5600 All variadic functions and their callers changed accordingly.
5601 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5602 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5603 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5604 * callint.c (Fcall_interactively): Check arg count for overflow,
5605 to avoid potential buffer overrun. Use signed char, not 'int',
5606 for 'varies' array, so that we needn't bother to check its size
5607 calculation for overflow.
5608 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5609 * eval.c (apply_lambda):
5610 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5611 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5612 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5614 * callint.c (Fcall_interactively): Don't use index var as event count.
5616 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5617 * mem-limits.h (SIZE): Remove; no longer used.
5619 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5621 Remove unnecessary casts.
5622 * xterm.c (x_term_init):
5623 * xfns.c (x_set_border_pixel):
5624 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5625 These aren't needed now that we assume ANSI C.
5627 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5628 It's more likely to cause problems (due to unsigned overflow)
5631 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5633 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5635 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5637 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5639 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5641 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5643 GLYPH_CODE_FACE returns EMACS_INT, not int.
5644 * dispextern.h (merge_faces):
5645 * xfaces.c (merge_faces):
5646 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5647 Don't assume EMACS_INT fits in int.
5649 * character.h (CHAR_VALID_P): Remove unused parameter.
5650 * fontset.c, lisp.h, xdisp.c: All uses changed.
5652 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5654 * fns.c (concat): Minor tuning based on overflow analysis.
5655 This doesn't fix any bugs. Use int to hold character, instead
5656 of constantly refetching from Emacs object. Use XFASTINT, not
5657 XINT, for value known to be a character. Don't bother comparing
5658 a single byte to 0400, as it's always less.
5660 * floatfns.c (Fexpt):
5661 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5663 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5666 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5668 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5669 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5670 incorrectly succeed when S was a string, because 4294967386 was
5671 truncated before it was used.
5673 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5674 Otherwise, an out-of-range integer could cause undefined behavior
5677 * composite.c: Use int, not EMACS_INT, for characters.
5678 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5679 EMACS_INT, for values that are known to be in character range.
5680 This doesn't fix any bugs but is the usual style inside Emacs and
5681 may generate better code on 32-bit machines.
5683 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5684 This is for reasons similar to the recent CHAR_STRING fix.
5685 * charset.c (Fencode_char): Check that character arg is actually
5686 a character. Pass an int to ENCODE_CHAR.
5687 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5688 wider than 'int', as a compile-time check to prevent future regressions
5691 * character.c (char_string): Remove unnecessary casts.
5693 Make sure a 64-bit char is never passed to CHAR_STRING.
5694 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5695 by silently ignoring the top 32 bits, allowing some values
5696 that were far too large to be valid characters.
5697 * character.h: Include <verify.h>.
5698 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5699 arguments are no wider than unsigned, as a compile-time check
5700 to prevent future regressions in this area.
5702 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5703 (Fsubst_char_in_region):
5705 * xdisp.c (decode_mode_spec_coding):
5706 Adjust to CHAR_STRING's new requirement.
5707 * editfns.c (Finsert_char, Fsubst_char_in_region):
5708 * fns.c (concat): Check that character args are actually
5709 characters. Without this test, these functions did the wrong
5710 thing with wildly out-of-range values on 64-bit hosts.
5712 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5713 These casts should not be needed on 32-bit hosts, either.
5714 * keyboard.c (read_char):
5715 * lread.c (Fload): Remove casts to unsigned.
5717 * lisp.h (UNSIGNED_CMP): New macro.
5718 This fixes comparison bugs on 64-bit hosts.
5719 (ASCII_CHAR_P): Use it.
5720 * casefiddle.c (casify_object):
5721 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5722 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5723 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5724 * dispextern.h (FACE_FROM_ID):
5725 * keyboard.c (read_char): Use UNSIGNED_CMP.
5727 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5728 not to EMACS_INT, to avoid GCC warning.
5730 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5732 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5733 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5734 isn't needed on 32-bit machines.
5736 * buffer.c (Fgenerate_new_buffer_name):
5737 Use EMACS_INT for count, not int.
5738 (advance_to_char_boundary): Return EMACS_INT, not int.
5740 * data.c (Qcompiled_function): Now static.
5742 * window.c (window_body_lines): Now static.
5744 * image.c (gif_load): Rename local to avoid shadowing.
5746 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5747 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5748 * alloc.c (make_save_value): Integer argument is now of type
5750 (mark_object): Use ptrdiff_t, not int.
5751 * lisp.h (pD): New macro.
5752 * print.c (print_object): Use it.
5754 * alloc.c: Use EMACS_INT, not int, to count objects.
5755 (total_conses, total_markers, total_symbols, total_vector_size)
5756 (total_free_conses, total_free_markers, total_free_symbols)
5757 (total_free_floats, total_floats, total_free_intervals)
5758 (total_intervals, total_strings, total_free_strings):
5759 Now EMACS_INT, not int. All uses changed.
5760 (Fgarbage_collect): Compute overall total using a double, so that
5761 integer overflow is less likely to be a problem. Check for overflow
5762 when converting back to an integer.
5763 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5764 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5765 These were 'int' variables that could overflow on 64-bit hosts;
5766 they were never used, so remove them instead of repairing them.
5767 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5768 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5769 Previously, this ceilinged at INT_MAX, but that doesn't work on
5771 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5773 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5774 (allocate_vectorlike): Check for ptrdiff_t overflow.
5775 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5776 when a (possibly-narrower) signed value would do just as well.
5777 We prefer using signed arithmetic, to avoid comparison confusion.
5779 * alloc.c: Catch some string size overflows that we were missing.
5780 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5781 for convenience in STRING_BYTES_MAX.
5782 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5783 The definition here is exact; the one in lisp.h was approximate.
5784 (allocate_string_data): Check for string overflow. This catches
5785 some instances we weren't catching before. Also, it catches
5786 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5787 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5788 and ptrdiff_t and EMACS_INT are both 64 bits.
5790 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5791 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5792 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5794 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5796 * alloc.c (Fmake_string): Check for out-of-range init.
5798 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5800 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5802 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5804 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5805 xg_get_default_scrollbar_width.
5807 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5808 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5809 (style_changed_cb): Call update_theme_scrollbar_width and call
5810 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5811 all frames (Bug#8505).
5812 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5813 Call gtk_window_set_resizable if HAVE_GTK3.
5814 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5815 and height if HAVE_GTK3 (Bug#8505).
5816 (scroll_bar_width_for_theme): New variable.
5817 (update_theme_scrollbar_width): New function.
5818 (xg_get_default_scrollbar_width): Move code to
5819 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5820 (xg_initialize): Call update_theme_scrollbar_width.
5822 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5824 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5826 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5828 * frame.c (make_frame): Call other_buffer_safely instead of
5831 * window.c (temp_output_buffer_show): Call display_buffer with
5832 second argument Vtemp_buffer_show_specifiers and reset latter
5833 immediately after the call.
5834 (Vtemp_buffer_show_specifiers): New variable.
5835 (auto_window_vscroll_p, next_screen_context_lines)
5836 (Vscroll_preserve_screen_position): Remove leading asterisks from
5839 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5841 Fix minor problems found by GCC 4.6.0 static checking.
5842 * buffer.c (Qclone_number): Remove for now, as it's unused.
5843 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5844 (record_buffer): Remove unused local.
5845 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5846 (set_frame_buffer_list): Remove; unused.
5847 * frame.h (other_visible_frames): Remove decl.
5848 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5849 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5850 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5852 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5853 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5854 Define only if HAVE_GPM.
5855 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5856 (update_hints_inhibit): Remove; never set. All uses removed.
5857 * widgetprv.h (emacsFrameClassRec): Remove decl.
5858 * window.c (delete_deletable_window): Now returns void, since it
5859 wasn't returning anything.
5860 (compare_window_configurations): Remove unused locals.
5861 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5862 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5863 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5864 the same widths as pointers. This follows up on the 2011-05-06 patch.
5865 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5866 * xterm.h: Likewise.
5867 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5869 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5871 * makefile.w32-in: Update dependencies.
5872 (LISP_H): Add lib/intprops.h.
5874 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5876 * image.c (gif_load): Add animation frame delay to the metadata.
5877 (syms_of_image): Use DEFSYM. New symbol `delay'.
5879 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5881 * window.c (delete_deletable_window): Re-add.
5882 (Fset_window_configuration): Rewrite to handle dead buffers and
5883 consequently deletable windows.
5884 (window_tree, Fwindow_tree): Remove. Supply functionality in
5886 (compare_window_configurations): Simplify code.
5888 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5890 * image.c (imagemagick_load_image): Fix type mismatch.
5891 (Fimagemagick_types): Likewise.
5893 * window.h (replace_buffer_in_windows): Declare.
5895 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5897 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5898 Qclone_number. Remove external declaration of Qdelete_window.
5899 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5901 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5902 Run Qbuffer_list_update_hook if allowed.
5903 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5904 buffer list implementation.
5905 (other_buffer_safely): New function.
5906 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5907 calls to replace_buffer_in_windows and
5908 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5910 (record_buffer): Inhibit quitting and rewrite using quittable
5911 functions. Run Qbuffer_list_update_hook if allowed.
5912 (Frecord_buffer, Funrecord_buffer): New functions.
5913 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5914 Move switch-to-buffer to window.el.
5915 (bury-buffer): Move to window.el.
5916 (Vbuffer_list_update_hook): New variable.
5918 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5921 * window.h (resize_frame_windows): Move up in code.
5922 (Fwindow_frame): Remove EXFUN.
5923 (replace_buffer_in_all_windows): Remove prototype.
5924 (replace_buffer_in_windows_safely): Add prototype.
5926 * window.c: Declare Qdelete_window static again. Move down
5927 declaration of select_count.
5928 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5929 (Fother_window): Move to window.el.
5930 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5931 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5932 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5934 (replace_buffer_in_windows): Implement by calling
5935 Qreplace_buffer_in_windows.
5936 (replace_buffer_in_all_windows): Remove with some functionality
5937 moved into replace_buffer_in_windows_safely.
5938 (replace_buffer_in_windows_safely): New function.
5939 (select_window_norecord, select_frame_norecord): Move in front
5940 of run_window_configuration_change_hook. Remove now obsolete
5942 (Fset_window_buffer): Rewrite doc-string.
5943 Call Qrecord_window_buffer.
5944 (keys_of_window): Move binding for other-window to window.el.
5946 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5948 * dispextern.h (struct image): Replace data member, whose int_val
5949 and ptr_val fields were not used by anything, with a single
5952 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5953 (gif_clear_image, gif_load, imagemagick_load_image)
5954 (gs_clear_image, gs_load): Callers changed.
5956 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5958 * buffer.h: Include <time.h>, for time_t.
5959 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5961 Fix minor problems found by static checking.
5963 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5965 Make identifiers static if they are not used in other modules.
5966 * data.c (Qcompiled_function, Qframe, Qvector):
5967 * image.c (QimageMagick, Qsvg):
5968 * minibuf.c (Qmetadata):
5969 * window.c (resize_window_check, resize_root_window): Now static.
5970 * window.h (resize_window_check, resize_root_window): Remove decls.
5972 * window.c (window_deletion_count, delete_deletable_window):
5974 (window_body_lines): Now static.
5975 (Fdelete_other_windows_internal): Mark vars as initialized.
5976 Make sure 'resize_failed' is initialized.
5977 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5978 (resize_window_apply): Remove unused local.
5979 * window.h (delete_deletable_window): Remove decl.
5981 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5982 (imagemagick_load_image): Fix pointer signedness problem by changing
5983 last arg from unsigned char * to char *. All uses changed.
5984 Also, fix a local for similar reasons.
5985 Remove unused locals. Remove locals to avoid shadowing.
5986 (fn_rsvg_handle_free): Remove; unused.
5987 (svg_load, svg_load_image): Fix pointer signedness problem.
5988 (imagemagick_load_image): Don't use garbage pointer image_wand.
5990 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5992 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5994 * image.c (gif_load): Fix omitted cast error introduced by
5997 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5999 * window.h (resize_proportionally, orig_total_lines)
6000 (orig_top_line): Remove from window structure.
6001 (set_window_height, set_window_width, change_window_heights)
6002 (Fdelete_window): Remove prototypes.
6003 (resize_frame_windows): Remove duplicate declaration.
6005 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6007 * window.h (resize_frame_windows, resize_window_check)
6008 (delete_deletable_window, resize_root_window)
6009 (resize_frame_windows): Declare prototypes.
6011 * window.c (resize_window_apply): Make definition be "static" to
6012 match the prototype.
6014 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6016 * window.c: Remove declarations of Qwindow_size_fixed,
6017 window_min_size_1, window_min_size_2, window_min_size,
6018 size_window, window_fixed_size_p, enlarge_window, delete_window.
6019 Remove static from declaration of Qdelete_window, it's
6020 temporarily needed by Fbury_buffer.
6021 (replace_window): Don't assign orig_top_line and
6023 (Fdelete_window, delete_window): Remove. Window deletion is
6024 handled by window.el.
6025 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6026 Replace Fdelete_window calls with calls to Qdelete_window.
6027 (Fdelete_other_windows): Remove. Deleting other windows is
6028 handled by window.el.
6029 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6030 handled in window.el.
6031 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6032 Window minimum sizes are handled in window.el.
6033 (shrink_windows, size_window, set_window_height)
6034 (set_window_width, change_window_heights, window_height)
6035 (window_width, CURBEG, CURSIZE, enlarge_window)
6036 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6037 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6038 handled in window.el.
6039 (make_dummy_parent): Rename to make_parent_window and give it a
6040 second argument horflag.
6041 (make_window): Don't set resize_proportionally any more.
6042 (Fsplit_window): Remove. Windows are split in window.el.
6043 (save_restore_action, save_restore_orig_size)
6044 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6045 Resize mini windows in window.el.
6046 (grow_mini_window, shrink_mini_window): Implement by calling
6047 Qresize_root_window_vertically, resize_window_check and
6048 resize_window_apply.
6049 (saved_window, Fset_window_configuration, save_window_save):
6050 Do not handle orig_top_line, orig_total_lines, and
6051 resize_proportionally.
6052 (window_min_height, window_min_width): Move to window.el.
6053 (keys_of_window): Move bindings for delete-other-windows,
6054 split-window, delete-window and enlarge-window to window.el.
6056 * buffer.c: Temporarily extern Qdelete_window.
6057 (Fbury_buffer): Temporarily call Qdelete_window instead of
6058 Fdelete_window (Fbury_buffer will move to window.el soon).
6060 * frame.c (set_menu_bar_lines_1): Remove code handling
6061 orig_top_line and orig_total_lines.
6063 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6064 set_window_height but set heights directly.
6065 (change_frame_size_1): Use resize_frame_windows.
6067 * xdisp.c (init_xdisp): Don't use set_window_height but set
6070 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6071 Use resize_frame_windows instead of change_window_heights and run
6072 run_window_configuration_change_hook.
6074 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6075 instead of change_window_heights and run
6076 run_window_configuration_change_hook.
6078 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6080 * window.c (replace_window): Rename second argument REPLACEMENT to
6081 NEW. New third argument SETFLAG. Rewrite.
6082 (delete_window, make_dummy_parent): Call replace_window with
6084 (window_list_1): Move down in code.
6085 (run_window_configuration_change_hook): Move set_buffer part
6086 before select_frame_norecord part in order to unwind correctly.
6087 Rename count1 to count.
6088 (recombine_windows, delete_deletable_window, resize_root_window)
6089 (Fdelete_other_windows_internal)
6090 (Frun_window_configuration_change_hook, make_parent_window)
6091 (resize_window_check, resize_window_apply, Fresize_window_apply)
6092 (resize_frame_windows, Fsplit_window_internal)
6093 (Fdelete_window_internal, Fresize_mini_window_internal):
6095 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6097 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6099 * window.h (window): Add some new members to window structure -
6100 normal_lines, normal_cols, new_total, new_normal, clone_number,
6101 splits, nest, prev_buffers, next_buffers.
6102 (WINDOW_TOTAL_SIZE): Move here from window.c.
6103 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6105 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6107 (make_dummy_parent): Set new members of windows structure.
6108 (make_window): Move down in code. Handle new members of window
6110 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6111 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6112 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6113 (Fset_window_prev_buffers, Fwindow_next_buffers)
6114 (Fset_window_next_buffers, Fset_window_clone_number):
6116 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6117 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6119 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6120 Argument WINDOW can be now internal window too.
6121 (Fwindow_use_time): Move up in code.
6122 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6124 (Fset_window_configuration, saved_window)
6125 (Fcurrent_window_configuration, save_window_save): Handle new
6126 members of window structure.
6127 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6128 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6129 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6130 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6131 Qget_mru_window, Qresize_root_window,
6132 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6133 Qauto_buffer_name; staticpro them.
6135 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6137 * window.c (Fwindow_total_size, Fwindow_left_column)
6138 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6139 (Fwindow_list_1): New functions.
6140 (window_box_text_cols): Replace with window_body_cols.
6141 (Fwindow_width, Fscroll_left, Fscroll_right):
6142 Use window_body_cols instead of window_box_text_cols.
6143 (delete_window, Fset_window_configuration):
6144 Call delete_all_subwindows with window as argument.
6145 (delete_all_subwindows): Take a window as argument and not a
6147 (window_loop): Remove handling of GET_LRU_WINDOW and
6149 (Fget_lru_window, Fget_largest_window): Move to window.el.
6151 * window.h: Extern window_body_cols instead of
6152 window_box_text_cols. delete_all_subwindows now takes a
6153 Lisp_Object as argument.
6155 * indent.c (compute_motion, Fcompute_motion):
6156 Use window_body_cols instead of window_box_text_cols.
6158 * frame.c (delete_frame): Call delete_all_subwindows with root
6161 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6163 * fns.c (Fputhash): Document return value.
6165 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6167 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6169 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6171 Cons<->int and similar integer overflow fixes (Bug#8794).
6173 Check for overflow when converting integer to cons and back.
6174 * charset.c (Fdefine_charset_internal, Fdecode_char):
6175 Use cons_to_unsigned to catch overflow.
6176 (Fencode_char): Use INTEGER_TO_CONS.
6177 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6178 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6179 * data.c (long_to_cons, cons_to_long): Remove.
6180 (cons_to_unsigned, cons_to_signed): New functions.
6181 These signal an error for invalid or out-of-range values.
6182 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6183 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6184 * font.c (Ffont_variation_glyphs):
6185 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6186 * lisp.h: Include <intprops.h>.
6187 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6188 (cons_to_signed, cons_to_unsigned): New decls.
6189 (long_to_cons, cons_to_long): Remove decls.
6190 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6191 (Fprimitive_undo): Use CONS_TO_INTEGER.
6192 * xfns.c (Fx_window_property): Likewise.
6193 * xselect.c: Include <limits.h>.
6194 (x_own_selection, selection_data_to_lisp_data):
6195 Use INTEGER_TO_CONS.
6196 (x_handle_selection_request, x_handle_selection_clear)
6197 (x_get_foreign_selection, Fx_disown_selection_internal)
6198 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6199 (lisp_data_to_selection_data): Use cons_to_unsigned.
6200 (x_fill_property_data): Use cons_to_signed.
6201 Report values out of range.
6203 Check for buffer and string overflow more precisely.
6204 * buffer.h (BUF_BYTES_MAX): New macro.
6205 * lisp.h (STRING_BYTES_MAX): New macro.
6206 * alloc.c (Fmake_string):
6207 * character.c (string_escape_byte8):
6208 * coding.c (coding_alloc_by_realloc):
6209 * doprnt.c (doprnt):
6210 * editfns.c (Fformat):
6212 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6213 since they may not be the same number.
6214 * editfns.c (Finsert_char):
6215 * fileio.c (Finsert_file_contents):
6216 Likewise for BUF_BYTES_MAX.
6218 * image.c: Use ptrdiff_t, not int, for sizes.
6219 (slurp_file): Switch from int to ptrdiff_t.
6221 (slurp_file): Check that file size fits in both size_t (for
6222 malloc) and ptrdiff_t (for sanity and safety).
6224 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6225 if b->modtime has its maximal value.
6227 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6229 Don't assume time_t can fit into int.
6230 * buffer.h (struct buffer.modtime): Now time_t, not int.
6231 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6232 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6234 Minor fixes for signed vs unsigned integers.
6235 * character.h (MAYBE_UNIFY_CHAR):
6236 * charset.c (maybe_unify_char):
6237 * keyboard.c (read_char, reorder_modifiers):
6238 XINT -> XFASTINT, since the integer must be nonnegative.
6239 * ftfont.c (ftfont_spec_pattern):
6240 * keymap.c (access_keymap, silly_event_symbol_error):
6241 XUINT -> XFASTINT, since the integer must be nonnegative.
6242 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6243 since it makes no difference and we prefer signed.
6244 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6245 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6248 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6250 * window.h (Fwindow_frame): Declare.
6252 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6254 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6255 (SPARE_MEMORY): Always define.
6256 (LARGE_REQUEST): Remove.
6257 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6259 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6261 * lisp.h: Move EXFUNS for Fframe_root_window,
6262 Fframe_first_window and Fset_frame_selected_window to window.h.
6264 * window.h: Move EXFUNS for Fframe_root_window,
6265 Fframe_first_window and Fset_frame_selected_window here from
6268 * frame.c (Fwindow_frame, Fframe_first_window)
6269 (Fframe_root_window, Fframe_selected_window)
6270 (Fset_frame_selected_window): Move to window.c.
6271 (Factive_minibuffer_window): Move to minibuf.c.
6272 (Fother_visible_frames_p): New function.
6274 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6276 * window.c (decode_window, decode_any_window): Move up in code.
6277 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6278 (inhibit_frame_unsplittable): Remove unused variable.
6279 (Fwindow_buffer): Move up and rewrite doc-string.
6280 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6281 (Fwindow_prev): New functions.
6282 (Fwindow_frame): Move here from frame.c. Accept any window as
6284 (Fframe_root_window, Fframe_first_window)
6285 (Fframe_selected_window): Move here from frame.c. Accept frame
6286 or arbitrary window as argument. Update doc-strings.
6287 (Fminibuffer_window): Move up in code.
6288 (Fwindow_minibuffer_p): Move up in code and simplify.
6289 (Fset_frame_selected_window): Move here from frame.c.
6291 (Fselected_window, select_window, Fselect_window): Move up in
6292 code. Minor doc-string fixes.
6294 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6296 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6297 Do not assume that spare memory exists; that assumption is valid
6298 only if SYSTEM_MALLOC.
6299 (LARGE_REQUEST): New macro, so that the issue of large requests
6300 is separated from the issue of spare memory.
6302 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6304 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6307 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6309 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6312 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6314 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6316 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6318 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6319 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6321 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6323 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6325 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6327 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6328 (x_clipboard_manager_save): Add return value.
6329 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6331 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6332 Obey Vx_select_enable_clipboard_manager. Catch errors in
6333 x_clipboard_manager_save (Bug#8779).
6334 (Vx_select_enable_clipboard_manager): New variable.
6335 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6337 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6339 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6341 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6343 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6344 in the current matrix if keep_current_p is non-zero.
6346 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6348 * bidi.c (bidi_level_of_next_char): Fix last change.
6350 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6352 Support bidi reordering of text covered by display properties.
6354 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6355 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6356 (bidi_cache_search, bidi_cache_iterator_state)
6357 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6358 (bidi_level_of_next_char, bidi_move_to_visually_next):
6359 Support character positions inside a run of characters covered by a
6361 (bidi_paragraph_init, bidi_resolve_explicit_1)
6362 (bidi_level_of_next_char): Call bidi_fetch_char and
6363 bidi_fetch_char_advance instead of FETCH_CHAR and
6365 (bidi_init_it): Initialize new members.
6366 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6368 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6369 instead of using explicit *_CHAR codes.
6370 (bidi_resolve_explicit, bidi_resolve_weak):
6371 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6372 bidirectional text is supported only in multibyte buffers.
6373 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6374 it to initialize the frame_window_p member of struct bidi_it.
6375 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6376 (bidi_resolve_explicit, bidi_resolve_weak)
6377 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6378 bidi_it->nchars is non-positive.
6379 (bidi_level_of_next_char): Don't try to lookup the cache for the
6380 next/previous character if nothing is cached there yet, or if we
6381 were just reseat()'ed to a new position.
6383 * xdisp.c (set_cursor_from_row): Set start and stop points
6384 according to the row's direction when priming the loop that looks
6385 for the glyph on which to display cursor.
6386 (single_display_spec_intangible_p): Function deleted.
6387 (display_prop_intangible_p): Reimplement to call
6388 handle_display_spec instead of single_display_spec_intangible_p.
6389 Accept 3 additional arguments needed by handle_display_spec.
6390 This fixes incorrect cursor motion across display property with complex
6391 values: lists, `(when COND...)' forms, etc.
6392 (single_display_spec_string_p): Support property values that are
6393 lists with the argument STRING its top-level element.
6394 (display_prop_string_p): Fix the condition for processing a
6395 property that is a list to be consistent with handle_display_spec.
6396 (handle_display_spec): New function, refactored from the
6397 last portion of handle_display_prop.
6398 (compute_display_string_pos): Accept additional argument
6399 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6400 value of a `display' property is a "replacing spec".
6401 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6402 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6403 the display property, but just return a value indicating whether
6404 the display property will replace the characters it covers.
6405 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6406 frame_window_p members of struct bidi_it.
6407 (compute_display_string_pos, compute_display_string_end):
6409 (push_it): Accept second argument POSITION, where pop_it should
6410 jump to continue iteration.
6411 (reseat_1): Initialize bidi_it.disp_pos.
6413 * keyboard.c (adjust_point_for_property): Adjust the call to
6414 display_prop_intangible_p to its new signature.
6416 * dispextern.h (struct bidi_it): New member frame_window_p.
6417 (bidi_init_it): Update prototypes.
6418 (display_prop_intangible_p): Update prototype.
6419 (compute_display_string_pos, compute_display_string_end):
6421 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6424 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6426 Malloc failure behavior now depends on size of allocation.
6427 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6428 * lisp.h: Change signatures accordingly.
6429 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6430 All callers changed. (Bug#8762)
6432 * gnutls.c: Use Emacs's memory allocators.
6433 Without this change, the gnutls library would invoke malloc etc.
6434 directly, which causes problems on non-SYNC_INPUT hosts, and which
6435 runs afoul of improving memory_full behavior. (Bug#8761)
6436 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6437 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6438 xfree instead of the default malloc, realloc, free.
6439 (Fgnutls_boot): No need to check for memory allocation failure,
6440 since xmalloc does that for us.
6442 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6443 * category.c (hash_get_category_set):
6444 * ccl.c (ccl_driver):
6445 * charset.c (Fdefine_charset_internal):
6446 * charset.h (struct charset.hash_index):
6447 * composite.c (get_composition_id, gstring_lookup_cache)
6448 (composition_gstring_put_cache):
6449 * composite.h (struct composition.hash_index):
6450 * dispextern.h (struct image.hash):
6451 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6452 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6453 (hashfn_equal, hashfn_user_defined, make_hash_table)
6454 (maybe_resize_hash_table, hash_lookup, hash_put)
6455 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6456 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6457 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6458 * image.c (make_image, search_image_cache, lookup_image)
6459 (xpm_put_color_table_h):
6460 * lisp.h (struct Lisp_Hash_Table):
6461 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6462 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6463 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6464 * alloc.c (allocate_vectorlike):
6465 Check for overflow in vector size calculations.
6466 * ccl.c (ccl_driver):
6467 Check for overflow when converting EMACS_INT to int.
6468 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6469 need to be updated by these changes.
6470 * fns.c (make_hash_table, maybe_resize_hash_table):
6471 Check for integer overflow with large hash tables.
6472 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6473 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6474 (SXHASH_REDUCE): New macro.
6475 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6476 Use it instead of discarding useful hash info with large hash values.
6477 (sxhash_float): New function.
6478 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6479 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6480 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6481 Rewrite to use FIXNUM_BITS, as this simplifies things.
6482 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6483 Adjust signatures to match updated version of code.
6484 (consing_since_gc): Now EMACS_INT, since a single hash table can
6485 use more than INT_MAX bytes.
6487 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6489 Make it possible to build with GCC-4.6+ -O2 -flto.
6491 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6493 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6495 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6496 Call minibuffer-inactive-mode.
6498 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6500 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6501 Update dependencies.
6503 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6505 * data.c (init_data): Remove code for UTS, this system is not
6508 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6510 Don't force ./temacs to start in terminal mode.
6512 * frame.c (make_initial_frame): Initialize faces in all cases, not
6513 only when CANNOT_DUMP is defined.
6514 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6516 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6518 * dispnew.c (add_window_display_history): Use const for the string
6519 pointer. Remove declaration, not needed.
6521 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6523 Use 'inline', not 'INLINE'.
6524 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6525 * alloc.c, fontset.c (INLINE): Remove.
6526 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6527 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6528 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6529 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6530 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6532 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6534 Make it possible to run ./temacs.
6536 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6537 syms_of_callproc does the same thing. Remove test for
6538 "initialized", do it in the caller.
6539 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6541 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6543 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6544 (read_minibuf): Use get_minibuffer.
6545 (syms_of_minibuf): Use DEFSYM.
6546 (Qmetadata): New var.
6547 * data.c (Qbuffer): Don't make it static.
6548 (syms_of_data): Use DEFSYM.
6550 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6552 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6553 (CCL_CODE_MIN): New macro.
6555 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6557 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6559 * eval.c (Qdebug): Now static.
6560 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6561 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6562 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6564 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6566 * image.c: Various fixes to ImageMagick code comments.
6567 (Fimagemagick_types): Doc fix.
6569 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6571 Minor fixes prompted by GCC 4.6.0 warnings.
6573 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6575 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6576 (x_clipboard_manager_save_all): Move extern decl to ...
6577 * xterm.h: ... here, so that it can be checked for consistency.
6579 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6581 * xselect.c (x_clipboard_manager_save_frame)
6582 (x_clipboard_manager_save_all): New functions.
6583 (Fx_clipboard_manager_save): Lisp function deleted.
6585 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6586 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6588 * xterm.h: Update prototype.
6590 2011-05-28 William Xu <william.xwl@gmail.com>
6592 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6595 2011-05-28 Jim Meyering <meyering@redhat.com>
6597 Avoid a sign-extension bug in crypto_hash_function.
6598 * fns.c (to_uchar): Define.
6599 (crypto_hash_function): Use it to convert some newly-signed
6600 variables to unsigned, to avoid sign-extension bugs. For example,
6601 without this change, (md5 "truc") would evaluate to
6602 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6603 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6604 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6606 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6608 Integer overflow fixes.
6610 * dbusbind.c: Serial number integer overflow fixes.
6611 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6612 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6613 to hold a serial number that is too large for a fixnum.
6614 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6615 Check for serial numbers out of range. Decode any serial number
6616 that was so large that it became a float. (Bug#8722)
6618 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6619 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6620 Use XFASTINT rather than XUINT when numbers are nonnegative.
6621 (xd_append_arg, Fdbus_method_return_internal):
6622 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6623 arguments, check that Lisp number is nonnegative, rather than
6624 silently wrapping negative numbers around. (Bug#8722)
6625 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6628 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6630 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6632 ccl: Add integer overflow checks.
6633 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6634 (IN_INT_RANGE): New macros.
6635 (ccl_driver): Use them to check for integer overflow when
6636 decoding a CCL program. Many of the new checks are whether XINT (x)
6637 fits in int; it doesn't always, on 64-bit hosts. The new version
6638 doesn't catch all possible integer overflows, but it's an
6639 improvement. (Bug#8719)
6641 * alloc.c (make_event_array): Use XINT, not XUINT.
6642 There's no need for unsigned here.
6644 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6645 This follows up to the 2011-05-06 change that substituted uintptr_t
6646 for EMACS_INT. This case wasn't caught back then.
6648 Rework Fformat to avoid integer overflow issues.
6649 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6650 now (part of C89). Include <verify.h>.
6651 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6652 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6653 (Fformat): Avoid the prepass trying to compute sizes; it was only
6654 approximate and thus did not catch overflow reliably. Instead, walk
6655 through the format just once, formatting and computing sizes as we go,
6656 checking for integer overflow at every step, and allocating a larger
6657 buffer as needed. Keep track separately whether the format is
6658 multibyte. Keep only the most-recently calculated precision, rather
6659 than them all. Record whether each argument has been converted to
6660 string. Use EMACS_INT, not int, for byte and char and arg counts.
6661 Support field widths and precisions larger than INT_MAX. Avoid
6662 sprintf's undefined behavior with conversion specifications such as %#d
6663 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6664 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6665 formatting out-of-range floating point numbers with int
6668 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6670 * data.c: Avoid integer truncation in expressions involving floats.
6671 * data.c: Include <intprops.h>.
6672 (arith_driver): When there's an integer overflow in an expression
6673 involving floating point, convert the integers to floating point
6674 so that the resulting value does not suffer from catastrophic
6675 integer truncation. For example, on a 64-bit host (* 4
6676 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6677 Do not rely on undefined behavior after integer overflow.
6679 merge count_size_as_multibyte, parse_str_to_multibyte
6680 * character.c, character.h (count_size_as_multibyte):
6681 Rename from parse_str_to_multibyte; all uses changed.
6682 Check for integer overflow.
6683 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6684 since it's now a duplicate of the other. This is more of
6685 a character than a buffer op, so better that it's in character.c.
6686 * fns.c, print.c: Adjust to above changes.
6688 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6690 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6692 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6694 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6695 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6696 (x_clipboard_manager_save): Now static.
6697 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6699 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6700 (crypto_hash_function): Now static.
6701 Fix pointer signedness problems. Avoid unnecessary initializations.
6703 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6705 * termhooks.h (Vselection_alist): Make it terminal-local.
6707 * terminal.c (create_terminal): Initialize it.
6709 * xselect.c: Support for clipboard managers.
6710 (Vselection_alist): Move to termhooks.h as terminal-local var.
6711 (LOCAL_SELECTION): New macro.
6712 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6713 (symbol_to_x_atom): Remove gratuitous arg.
6714 (x_handle_selection_request, lisp_data_to_selection_data)
6715 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6716 (x_own_selection, x_get_local_selection, x_convert_selection):
6717 New arg, specifying work frame. Use terminal-local Vselection_alist.
6718 (some_frame_on_display): Delete unused function.
6719 (Fx_own_selection_internal, Fx_get_selection_internal)
6720 (Fx_disown_selection_internal, Fx_selection_owner_p)
6721 (Fx_selection_exists_p): New optional frame arg.
6722 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6723 (x_handle_selection_clear): Don't treat other terminals with the
6724 same keyboard specially. Use the terminal-local Vselection_alist.
6725 (x_clear_frame_selections): Use Frun_hook_with_args.
6727 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6729 * xterm.h: Add support for those atoms.
6731 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6733 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6734 (converted_selections, conversion_fail_tag): New global variables.
6735 (x_selection_request_lisp_error): Free the above.
6736 (x_get_local_selection): Remove unnecessary code.
6737 (x_reply_selection_request): Args changed; handle arbitrary array
6738 of converted selections stored in converted_selections.
6739 Separate the XChangeProperty and SelectionNotify steps.
6740 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6741 (x_convert_selection): New function.
6742 (x_handle_selection_event): Simplify.
6743 (x_get_foreign_selection): Don't ignore incoming requests while
6744 waiting for an answer; this will fail when we implement
6745 SAVE_TARGETS, and seems unnecessary anyway.
6746 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6747 (Vx_sent_selection_functions): Doc fix.
6749 2011-05-26 Leo Liu <sdl.web@gmail.com>
6751 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6753 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6755 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6757 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6758 for fringe update if it has periodic bitmap.
6759 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6760 and fringe_bitmap_periodic_p.
6762 * fringe.c (get_fringe_bitmap_data): New function.
6763 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6764 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6765 row. Mark glyph row for fringe update if periodicity changed.
6767 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6768 for fringe update unless it has periodic bitmap.
6770 2011-05-25 Kenichi Handa <handa@m17n.org>
6772 * xdisp.c (get_next_display_element): Set correct it->face_id for
6773 a static composition.
6775 2011-05-24 Leo Liu <sdl.web@gmail.com>
6778 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6780 * fns.c (crypto_hash_function, Fsha1): New function.
6781 (Fmd5): Use crypto_hash_function.
6782 (syms_of_fns): Add Ssha1.
6784 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6786 * gnutls.c: Remove unused macros.
6787 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6788 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6789 Remove macros that are defined and never used.
6790 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6792 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6794 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6795 (Fx_get_selection_internal): Minor cleanup.
6796 (Fx_own_selection_internal): Rename arguments for consistency with
6799 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6801 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6803 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6805 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6807 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6809 * dispnew.c (scrolling_window): Don't exclude the case that the
6810 last enabled row in the desired matrix touches the bottom boundary.
6812 2011-05-21 Glenn Morris <rgm@gnu.org>
6814 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6815 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6816 and add some more files.
6818 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6820 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6821 report_file_error introduced by the change from 2011-05-07.
6823 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6825 * systime.h (Time): Define only if emacs is defined.
6826 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6827 where the include path doesn't have X11/X.h by default. See
6828 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6830 2011-05-20 Kenichi Handa <handa@m17n.org>
6832 * composite.c (find_automatic_composition): Fix previous change.
6834 2011-05-20 Glenn Morris <rgm@gnu.org>
6836 * lisp.mk: New file, split from Makefile.in.
6837 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6838 (shortlisp): Remove.
6839 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6841 2011-05-19 Glenn Morris <rgm@gnu.org>
6843 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6844 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6845 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6846 (lisp): Set the order to that of loadup.el.
6847 (shortlisp): Make it a copy of $lisp.
6848 (SOME_MACHINE_LISP): Remove.
6849 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6850 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6852 2011-05-18 Kenichi Handa <handa@m17n.org>
6854 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6855 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6856 (find_automatic_composition): Mostly rewrite for efficiency.
6858 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6860 * makefile.w32-in: Update dependencies.
6862 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6864 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6865 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6867 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6869 Fix some integer overflow issues, such as string length overflow.
6871 * insdel.c (count_size_as_multibyte): Check for string overflow.
6873 * character.c (lisp_string_width): Check for string overflow.
6874 Use EMACS_INT, not int, for string indexes and lengths; in
6875 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6876 the resulting string length overflows an EMACS_INT; instead,
6877 report a string overflow if no precision given. When checking for
6878 precision exhaustion, use a check that cannot possibly have
6879 integer overflow. (Bug#8675)
6880 * character.h (lisp_string_width): Adjust to new signature.
6882 * alloc.c (string_overflow): New function.
6883 (Fmake_string): Use it. This doesn't change behavior, but saves
6884 a few bytes and will simplify future changes.
6885 * character.c (string_escape_byte8): Likewise.
6886 * lisp.h (string_overflow): New decl.
6888 Fixups, following up to the user-interface timestamp change.
6889 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6890 for UI timestamps, instead of unsigned long.
6891 * msdos.c (mouse_get_pos): Likewise.
6892 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6893 * w32gui.h (Time): Define by including "systime.h" rather than by
6894 declaring it ourselves. (Bug#8664)
6896 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6897 * image.c (clear_image_cache): Likewise.
6899 * term.c (term_mouse_position): Don't assume time_t wraparound.
6901 Be more systematic about user-interface timestamps.
6902 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6903 and sometimes 'EMACS_UINT', to represent these timestamps.
6904 This change causes it to use 'Time' uniformly, as that's what X uses.
6905 This makes the code easier to follow, and makes it easier to catch
6906 integer overflow bugs such as Bug#8664.
6907 * frame.c (Fmouse_position, Fmouse_pixel_position):
6908 Use Time, not unsigned long, for user-interface timestamps.
6909 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6910 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6911 * keyboard.h (last_event_timestamp): Likewise.
6912 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6913 * menu.h (xmenu_show): Likewise.
6914 * term.c (term_mouse_position): Likewise.
6915 * termhooks.h (struct input_event.timestamp): Likewise.
6916 (struct terminal.mouse_position_hook): Likewise.
6917 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6918 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6919 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6920 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6922 * menu.h, termhooks.h: Include "systime.h", for Time.
6924 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6925 Don't assume that the difference between two unsigned long values
6926 can fit into an integer. At this point, we know button_down_time
6927 <= event->timestamp, so the difference must be nonnegative, so
6928 there's no need to cast the result if double-click-time is
6929 nonnegative, as it should be; check that it's nonnegative, just in
6930 case. This bug is triggered when events are more than 2**31 ms
6931 apart (about 25 days). (Bug#8664)
6933 * xselect.c (last_event_timestamp): Remove duplicate decl.
6934 (x_own_selection): Remove needless cast to unsigned long.
6936 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6937 that always fit in int. Use a sentinel instead of a counter, to
6938 avoid a temp and to allay GCC's concerns about possible int overflow.
6939 * frame.h (struct frame): Use int for menu_bar_items_used
6940 instead of EMACS_INT, since it always fits in int.
6942 * menu.c (grow_menu_items): Check for int overflow.
6944 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6946 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6947 Before, the code was not consistent. These values cannot exceed
6948 2**31 - 1 so there's no need to make them unsigned.
6949 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6950 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6951 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6953 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6955 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6956 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6957 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6958 presumably because the widths might not match.
6960 * window.c (size_window): Avoid needless test at loop start.
6962 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6964 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6966 2011-05-12 Drew Adams <drew.adams@oracle.com>
6968 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6970 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6972 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6973 `width' to `bar_area_x' and `bar_area_width', respectively.
6974 (x_scroll_run): Take account of fringe background extension.
6976 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6977 Rename local vars `left' and `width' to `bar_area_x' and
6978 `bar_area_width', respectively.
6979 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6980 background extension.
6982 2011-05-10 Jim Meyering <meyering@redhat.com>
6984 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6986 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6988 * image.c (Finit_image_library): Return t for built-in image types,
6989 like pbm and xbm. (Bug#8640)
6991 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6993 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6995 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6997 * w32console.c (Fset_screen_color): Doc fix.
6998 (Fget_screen_color): New function.
6999 (syms_of_ntterm): Defsubr it.
7001 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7002 unlink the temporary file if Fcall_process didn't create it in the
7004 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7005 child process will be redirected to a file specified with `:file'.
7006 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7007 cue to call_process_cleanup not to close that handle.
7009 2011-05-07 Ben Key <bkey76@gmail.com>
7011 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7012 one of two shell specific rules, either bootstrap-temacs-CMD or
7013 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7014 to the previous implementation of the bootstrap-temacs rule.
7015 The bootstrap-temacs-CMD rule is similar to the previous
7016 implementation of the bootstrap-temacs rule except that it
7017 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7020 These changes, along with some changes to nt/configure.bat,
7021 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7022 earlier fix to add support for --cflags and --ldflags options
7023 that include quotes so that it works whether make uses cmd or
7026 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7028 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7029 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7031 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7032 a string. Handle both cases.
7033 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7034 (Fdbus_register_method): Use Qinvalid_function.
7036 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7038 * makefile.w32-in: Update dependencies.
7039 (LISP_H): Add inttypes.h and stdin.h.
7040 (PROCESS_H): Add unistd.h.
7042 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7044 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7045 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7047 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7049 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7051 * term.c (vfatal): Remove stray call to va_end.
7052 It's not needed and the C Standard doesn't allow it here anyway.
7054 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7055 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7057 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7060 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7062 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7064 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7066 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7068 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7070 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7071 * charset.c (Fdefine_charset_internal): Don't initialize
7072 charset.code_space[15]. The value was garbage, on hosts with
7073 32-bit int (Bug#8600).
7075 * lread.c (read_integer): Be more consistent with string-to-number.
7076 Use string_to_number to do the actual conversion; this avoids
7077 rounding errors and fixes some other screwups. Without this fix,
7078 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7079 (digit_to_number): Move earlier, for benefit of read_integer.
7080 Return -1 if the digit is out of range for the base, -2 if it is
7081 not a digit in any supported base. (Bug#8602)
7083 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7085 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7086 to match comment at start of function. This also removes a
7087 GCC warning about overflow in a 32+64-bit port.
7089 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7091 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7092 Reported by Stefan Monnier in
7093 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7094 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7095 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7097 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7098 (EMACS_UINTPTR): Likewise, with uintptr_t.
7100 * lisp.h: Prefer 64-bit EMACS_INT if available.
7101 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7102 on 32-bit hosts that have 64-bit int, so that they can access
7104 However, temporarily disable this change unless the temporary
7105 symbol WIDE_EMACS_INT is defined.
7107 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7109 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7110 This removes an assumption that EMACS_INT and long are the same
7111 width as pointers. The assumption is true for Emacs porting targets
7112 now, but we want to make other targets possible.
7113 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7114 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7115 In the rest of the code, change types of integers that hold casted
7116 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7117 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7118 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7119 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7120 No need to cast type when ORing.
7121 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7122 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7123 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7124 assume EMACS_INT is the same width as char *.
7125 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7126 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7127 Remove no-longer-needed casts.
7128 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7129 (xg_tool_bar_help_callback, xg_make_tool_item):
7130 Use EMACS_INTPTR to hold an integer
7131 that will be cast to void *; this can avoid a GCC warning
7132 if EMACS_INT is not the same width as void *.
7133 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7134 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7135 (current_message_1, set_message_1):
7136 Use a local to convert to proper width without a cast.
7137 * xmenu.c (dialog_selection_callback): Likewise.
7139 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7140 Also, don't assume VALBITS / RAND_BITS is less than 5,
7141 and don't rely on undefined behavior when shifting a 1 left into
7143 * lisp.h (get_random): Change signature to match.
7145 * lread.c (hash_string): Use size_t, not int, for hash computation.
7146 Normally we prefer signed values; but hashing is special, because
7147 it's better to use unsigned division on hash table sizes so that
7148 the remainder is nonnegative. Also, size_t is the natural width
7149 for hashing into memory. The previous code used 'int', which doesn't
7150 retain enough info to hash well into very large tables.
7151 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7153 * dbusbind.c: Don't possibly lose pointer info when converting.
7154 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7155 Use XPNTR rather than XHASH, so that the high-order bits of
7156 the pointer aren't lost when converting through void *.
7158 * eval.c (Fautoload): Don't double-shift a pointer.
7160 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7162 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7164 * gnutls.c (DEF_GNUTLS_FN):
7165 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7167 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7169 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7172 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7174 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7175 New version that can reserve upto 2GB of heap space.
7177 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7179 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7181 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7183 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7184 `gnutls_certificate_set_x509_key_file'.
7186 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7188 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7189 Update dependencies.
7191 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7193 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7194 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7195 Remove unused parameter `fildes'.
7196 * process.c (read_process_output, send_process): Don't pass it.
7198 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7200 Fix previous change: the library cache is defined in w32.c.
7201 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7202 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7204 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7206 Implement dynamic loading of GnuTLS on Windows.
7208 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7209 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7210 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7213 * gnutls.c (Qgnutls_dll): Define.
7214 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7215 (gnutls_*): Declare function pointers.
7216 (init_gnutls_functions): New function to initialize function pointers.
7217 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7218 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7219 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7220 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7221 (emacs_gnutls_write, emacs_gnutls_read)
7222 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7223 (Fgnutls_available_p): New function.
7224 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7225 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7226 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7228 * image.c: Include w32.h.
7229 (Vimage_type_cache): Delete.
7230 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7231 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7232 (w32_delayed_load): Move to w32.c.
7234 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7236 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7237 (w32_delayed_load): Move from image.c. When loading a library, record
7238 its filename in the :loaded-from property of the library id.
7239 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7240 Initialize and staticpro them.
7241 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7243 * process.c: Include lisp.h before w32.h, not after.
7244 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7245 instead of gnutls_record_check_pending.
7247 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7249 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7251 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7252 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7255 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7257 * xterm.c (x_set_frame_alpha): Do not set property on anything
7258 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7260 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7262 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7264 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7266 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7267 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7268 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7269 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7270 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7271 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7272 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7273 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7274 (Qgnutls_bootprop_callbacks_verify): Make static.
7276 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7278 * callproc.c: Indentation fixup.
7280 * sysdep.c (wait_for_termination_1): Make static.
7281 (wait_for_termination, interruptible_wait_for_termination):
7282 Move after wait_for_termination_1.
7284 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7286 * sysdep.c (interruptible_wait_for_termination): New function
7287 which is like wait_for_termination, but allows keyboard
7290 * callproc.c (Fcall_process): Add (:file "file") as an option for
7292 (Fcall_process_region): Ditto.
7294 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7296 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7297 rather than `XVECTOR (FOO)->size'.
7299 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7300 inttypes.h, as a gnulib replacement is used if it not available in
7303 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7305 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7306 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7307 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7309 * coding.c (coding_alloc_by_realloc): Error out if destination
7310 will grow beyond MOST_POSITIVE_FIXNUM.
7311 (decode_coding_emacs_mule): Abort if there isn't enough place in
7312 charbuf for the composition carryover bytes. Reserve an extra
7313 space for up to 2 characters produced in a loop.
7314 (decode_coding_iso_2022): Abort if there isn't enough place in
7315 charbuf for the composition carryover bytes.
7317 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7319 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7320 aborting when %lld or %lll format is passed.
7321 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7322 %llo or %llx format is passed. (Bug#8545)
7324 * window.c (window_scroll_line_based): Use a marker instead of
7325 simple variables to record original value of point. (Bug#7952)
7327 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7328 produced by %s or %c overflows available buffer space. (Bug#8545)
7330 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7332 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7333 (SIZE_MAX): Move defn after all includes, as they might #define it.
7335 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7337 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7339 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7341 * keyboard.c (Qdelayed_warnings_hook): Define.
7342 (command_loop_1): Run `delayed-warnings-hook'
7343 if Vdelayed_warnings_list is non-nil.
7344 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7345 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7347 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7349 * doprnt.c (doprnt): Don't return value smaller than the buffer
7350 size if the message was truncated. (Bug#8545).
7352 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7354 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7355 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7357 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7359 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7361 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7363 * makefile.w32-in: Update dependencies.
7365 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7367 Improve `doprnt' and its usage. (Bug#8545)
7368 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7369 `format_end'. Remove support for %l as a conversion specifier.
7370 Don't use xrealloc. Improve diagnostics when the %l size modifier
7371 is used. Update the commentary.
7373 * eval.c (verror): Simplify calculation of size_t.
7375 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7378 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7380 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7383 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7385 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7386 This makes this file independent of the recent pseudovector change.
7388 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7390 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7392 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7393 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7394 Remove unused local.
7395 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7397 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7398 GCC 4.6.0 optimizes based on type-based alias analysis.
7399 For example, if b is of type struct buffer * and v of type struct
7400 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7401 != &v->size, and therefore "v->size = 1; b->size = 2; return
7402 v->size;" must therefore return 1. This assumption is incorrect
7403 for Emacs, since it type-puns struct Lisp_Vector * with many other
7404 types. To fix this problem, this patch adds a new type struct
7405 vectorlike_header that documents the constraints on layout of vectors
7406 and pseudovectors, and helps optimizing compilers not get fooled
7407 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7408 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7409 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7411 (XSETPVECTYPE): Rewrite in terms of new macro.
7412 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7413 This is a bit clearer, and further avoids the possibility of
7414 undesirable aliasing.
7415 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7416 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7417 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7418 since Lisp_Subr is a special case (no "next" field).
7419 (ASIZE): Now uses header.size rather than size.
7420 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7421 to avoid the hassle of writing XVECTOR (foo)->header.size.
7422 (struct vectorlike_header): New type.
7423 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7424 object, to help avoid aliasing.
7425 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7426 (SUBRP): Likewise, since Lisp_Subr is a special case.
7427 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7428 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7429 (struct Lisp_Hash_Table): Combine first two members into a single
7430 struct vectorlike_header member. All uses of "size" and "next" members
7431 changed to be "header.size" and "header.next".
7432 * buffer.h (struct buffer): Likewise.
7433 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7434 * frame.h (struct frame): Likewise.
7435 * process.h (struct Lisp_Process): Likewise.
7436 * termhooks.h (struct terminal): Likewise.
7437 * window.c (struct save_window_data, struct saved_window): Likewise.
7438 * window.h (struct window): Likewise.
7439 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7440 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7441 * buffer.c (init_buffer_once): Likewise.
7442 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7444 * process.c (Fformat_network_address): Use local var for size,
7447 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7449 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7450 * data.c (atof): Remove decl; no longer used or needed.
7451 (digit_to_number): Move to lread.c.
7452 (Fstring_to_number): Use new string_to_number function, to be
7453 consistent with how the Lisp reader treats infinities and NaNs.
7454 Do not assume that floating-point numbers represent EMACS_INT
7455 without losing information; this is not true on most 64-bit hosts.
7456 Avoid double-rounding errors, by insisting on integers when
7457 parsing non-base-10 numbers, as the documentation specifies.
7458 * lisp.h (string_to_number): New decl, replacing ...
7459 (isfloat_string): Remove.
7460 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7461 (read1): Do not accept +. and -. as integers; this
7462 appears to have been a coding error. Similarly, do not accept
7463 strings like +-1e0 as floating point numbers. Do not report
7464 overflow for integer overflows unless the base is not 10 which
7465 means we have no simple and reliable way to continue.
7466 Break out the floating-point parsing into a new
7467 function string_to_number, so that Fstring_to_number parses
7468 floating point numbers consistently with the Lisp reader.
7469 (digit_to_number): Move here from data.c. Make it static inline.
7470 (E_CHAR, EXP_INT): Remove, replacing with ...
7471 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7472 (string_to_number): New function, replacing isfloat_string.
7473 This function checks for valid syntax and produces the resulting
7474 Lisp float number too. Rework it so that string-to-number
7475 no longer mishandles examples like "1.0e+". Use strtoumax,
7476 so that overflow for non-base-10 numbers is reported only when
7477 there's no portable and simple way to convert to floating point.
7479 * textprop.c (set_text_properties_1): Rewrite for clarity,
7480 and to avoid GCC warning about integer overflow.
7482 * intervals.h (struct interval): Use EMACS_INT for members
7483 where EMACS_UINT might cause problems. See
7484 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7485 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7486 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7488 (offset_intervals): Tell GCC not to worry about length overflow
7489 when negating a negative length.
7491 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7492 (overrun_check_free): Likewise.
7494 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7495 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7498 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7499 (gnutls_make_error): Rename local to avoid shadowing.
7500 (gnutls_emacs_global_deinit): ifdef out; not used.
7501 (Fgnutls_boot): Use const for pointer to readonly storage.
7502 Comment out unused local. Fix pointer signedness problems.
7504 * lread.c (openp): Don't stuff size_t into an 'int'.
7505 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7506 about possible signed overflow.
7508 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7509 (GDK_KEY_g): Don't define if already defined.
7510 (xg_prepare_tooltip): Avoid pointer signedness problem.
7511 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7513 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7514 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7516 * xfns.c (Fx_window_property): Simplify a bit,
7517 to make a bit faster and to avoid GCC 4.6.0 warning.
7518 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7520 * fns.c (internal_equal): Don't assume size_t fits in int.
7522 * alloc.c (compact_small_strings): Tighten assertion a little.
7524 Replace pEd with more-general pI, and fix some printf arg casts.
7525 * lisp.h (pI): New macro, generalizing old pEd macro to other
7526 conversion specifiers. For example, use "...%"pI"d..." rather
7527 than "...%"pEd"...".
7528 (pEd): Remove. All uses replaced with similar uses of pI.
7529 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7530 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7531 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7532 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7533 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7534 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7535 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7537 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7538 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7539 * print.c (safe_debug_print, print_object): Likewise.
7540 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7542 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7543 avoiding the 0 flag, which is not portable.
7544 * process.c (Fmake_network_process): Use pI to avoid cast.
7545 * region-cache.c (pp_cache): Likewise.
7546 * xdisp.c (decode_mode_spec): Likewise.
7547 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7548 behavior on 64-bit hosts with printf arg.
7549 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7550 (x_stop_queuing_selection_requests): Likewise.
7551 (x_get_window_property): Don't truncate byte count to an 'int'
7554 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7555 here, since it parses constructs like leading '-' and spaces,
7556 which are not wanted; and it overflows with large numbers.
7557 Instead, simply match F[0-9]+, which is what is wanted anyway.
7559 * alloc.c: Remove unportable assumptions about struct layout.
7560 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7561 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7562 (allocate_vectorlike, make_pure_vector): Use the new macros,
7563 plus offsetof, to remove unportable assumptions about struct layout.
7564 These assumptions hold on all porting targets that I know of, but
7565 they are not guaranteed, they're easy to remove, and removing them
7566 makes further changes easier.
7568 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7569 This doesn't fix a bug but makes the code clearer.
7570 (string_overrun_cookie): Now const. Use initializers that
7571 don't formally overflow signed char, to avoid warnings.
7572 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7573 can cause Emacs to crash when string overrun checking is enabled.
7574 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7575 multiple of sizeof (EMACS_INT); it need not be, if
7576 alignof(EMACS_INT) < sizeof (EMACS_INT).
7577 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7579 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7581 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7583 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7585 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7586 supposed to be handshaking. (Bug#8556)
7587 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7589 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7591 * lisp.h (Qdebug): List symbol.
7592 * eval.c (Qdebug): Restore global linkage.
7593 * keyboard.c (debug-on-event): New variable.
7594 (handle_user_signal): Break into debugger when debug-on-event
7595 matches the current signal symbol.
7597 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7599 * alloc.c (check_sblock, check_string_bytes)
7600 (check_string_free_list): Convert to standard C.
7602 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7604 * w32.c (emacs_gnutls_push): Fix typo.
7606 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7608 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7609 "cast to pointer from integer of different size".
7611 Improve doprnt and its use in verror. (Bug#8545)
7612 * doprnt.c (doprnt): Document the set of format control sequences
7613 supported by the function. Use SAFE_ALLOCA instead of always
7616 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7617 is one byte too soon. Don't use xrealloc; instead xfree and
7620 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7622 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7625 * gnutls.c: Renamed global_initialized to
7626 gnutls_global_initialized. Added internals for the
7627 :verify-hostname-error, :verify-error, and :verify-flags
7628 parameters of `gnutls-boot' and documented those parameters in the
7629 docstring. Start callback support.
7630 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7631 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7632 on error. Return error code.
7633 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7634 (emacs_gnutls_read): Likewise.
7635 (Fgnutls_boot): Return handshake error code.
7636 (emacs_gnutls_handle_error): New function.
7637 (wsaerror_to_errno): Likewise.
7639 * w32.h (emacs_gnutls_pull): Add prototype.
7640 (emacs_gnutls_push): Likewise.
7642 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7643 (emacs_gnutls_push): Likewise.
7645 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7647 * process.c (wait_reading_process_output): Check if GnuTLS
7648 buffered some data internally if no FDs are set for TLS
7651 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7652 (LIBS): Link to USER_LIBS.
7653 ($(BLD)/gnutls.$(0)): New target.
7655 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7657 * xdisp.c (handle_single_display_spec): Rename the
7658 display_replaced_before_p argument into display_replaced_p, to
7659 make it consistent with the commentary. Fix typos in the
7662 * textprop.c (syms_of_textprop): Remove dead code.
7663 (copy_text_properties): Delete obsolete commentary about an
7664 interface that was deleted long ago. Fix typos in the description
7667 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7668 to changes in oldXMenu/XMenu.h from 2011-04-16.
7669 <menu_help_message, prev_menu_help_message>: Constify.
7670 (IT_menu_make_room): menu->help_text is now `const char **';
7673 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7674 to changes in oldXMenu/XMenu.h from 2011-04-16.
7675 (struct XMenu): Declare `help_text' `const char **'.
7677 * xfaces.c <Qunspecified>: Make extern again.
7679 * syntax.c: Include sys/types.h before including regex.h, as
7682 * doc.c (get_doc_string): Improve the format passed to `error'.
7684 * doprnt.c (doprnt): Improve commentary.
7686 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7688 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7691 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7692 changes in globals.h immediately force recompilation.
7693 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7694 $(CURDIR)/s/ms-w32.h.
7695 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7697 * character.c (Fchar_direction): Function deleted.
7698 (syms_of_character): Don't defsubr it.
7699 <char-direction-table>: Deleted.
7701 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7703 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7704 * doprnt.c: Include limits.h.
7705 (SIZE_MAX): New macro.
7706 (doprnt): Return a size_t value. 2nd arg is now size_t.
7707 Many local variables are now size_t instead of int or unsigned.
7708 Improve overflow protection. Support `l' modifier for integer
7709 conversions. Support %l conversion. Don't assume an EMACS_INT
7710 argument for integer conversions and for %c.
7712 * lisp.h (doprnt): Restore prototype.
7714 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7717 * Makefile.in (base_obj): Add back doprnt.o.
7719 * deps.mk (doprnt.o): Add back prerequisites.
7720 (callint.o): Depend on character.h.
7722 * eval.c (internal_lisp_condition_case): Include the handler
7723 representation in the error message.
7724 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7725 when breaking from the loop.
7727 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7729 * callint.c (Fcall_interactively): When displaying error message
7730 about invalid control letter, pass the character's codepoint, not
7731 a pointer to its multibyte form. Improve display of the character
7732 in octal and display also its hex code.
7734 * character.c (char_string): Use %x to display the (unsigned)
7735 codepoint of an invalid character, to avoid displaying a bogus
7738 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7739 `error', not SYMBOL_NAME itself.
7741 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7742 character arguments to `error'.
7744 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7745 to `error' in error message about FINAL_CHAR argument. Make sure
7746 FINAL_CHAR is a character, and use %c when it is passed as
7747 argument to `error'.
7749 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7751 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7753 * w32.c: Include <time.h>.
7754 (sys_localtime): New function.
7756 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7758 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7760 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7762 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7764 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7767 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7769 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7770 gl_state.e_property when gl_state.object is Qt.
7772 * insdel.c (make_gap_larger): Remove limitation of buffer size
7775 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7777 * xdisp.c (lookup_glyphless_char_display)
7778 (produce_glyphless_glyph): Handle cons cell entry in
7779 glyphless-char-display.
7780 (Vglyphless_char_display): Document it.
7782 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7783 glyphless-char-display.
7785 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7787 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7789 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7791 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7792 definition for no-X builds.
7794 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7796 Static checks with GCC 4.6.0 and non-default toolkits.
7798 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7800 * process.c (keyboard_bit_set): Define only if SIGIO.
7801 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7802 (send_process): Repair possible setjmp clobbering.
7804 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7806 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7808 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7810 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7811 Define only if needed.
7813 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7814 by pacifying GCC about it. Maybe it's time to retire it?
7815 * xfaces.c (USG, __TIMEVAL__): Likewise.
7817 * dispextern.h (struct redisplay_interface): Rename param
7819 * termhooks.h (struct terminal): Likewise.
7820 * xterm.c (xembed_send_message): Likewise.
7822 * insdel.c (make_gap_smaller): Define only if
7823 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7825 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7828 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7829 so that we aren't warned about unused symbols.
7831 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7833 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7835 * xfns.c (x_real_positions): Mark locals as initialized.
7837 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7839 * xterm.c: Fix problems found by static analysis with other toolkits.
7840 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7841 (x_dispatch_event): Declare static if USE_GTK, and
7842 define if USE_GTK || USE_X_TOOLKIT.
7843 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7844 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7845 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7846 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7848 * xmenu.c (menu_help_callback): Pointer type fixes.
7849 Use const pointers when pointing at readonly data. Avoid pointer
7851 (FALSE): Remove unused macro.
7852 (update_frame_menubar): Remove unused decl.
7854 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7856 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7857 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7858 (single_menu_item): Rename local to avoid shadowing.
7860 * keyboard.c (make_lispy_event): Remove unused local var.
7862 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7863 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7865 * bitmaps: Change bitmaps from unsigned char back to the X11
7866 compatible char. Avoid the old compiler warnings about
7867 out-of-range initializers by using, for example, '\xab' rather
7870 * xgselect.c (xgselect_initialize): Check vs interface
7871 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7873 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7875 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7876 to read-only memory.
7878 * fns.c (vector): Remove; this old hack is no longer needed.
7880 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7882 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7884 * xrdb.c (x_load_resources): Omit unused local.
7886 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7887 (x_window): Rename locals to avoid shadowing.
7888 (USG): Use the kludged USG macro, to pacify gcc.
7890 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7891 (x_term_init): Remove local to avoid shadowing.
7893 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7895 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7896 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7898 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7900 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7902 Fix regex.c, syntax.c and friends for buffers > 2GB.
7903 * syntax.h (struct gl_state_s): Declare character position members
7906 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7908 * textprop.c (verify_interval_modification, interval_of):
7909 Declare arguments EMACS_INT.
7911 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7914 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7916 * indent.c (Fvertical_motion): Local variable it_start is now
7919 * regex.c (re_match, re_match_2, re_match_2_internal)
7920 (bcmp_translate, regcomp, regexec, print_double_string)
7921 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7922 (re_compile_pattern, re_exec): Declare arguments and local
7923 variables `size_t' and `ssize_t' and return values `regoff_t', as
7925 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7926 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7927 <compile_stack_type>: `size' and `avail' are now `size_t'.
7929 * regex.h <regoff_t>: Use ssize_t, not int.
7930 (re_search, re_search_2, re_match, re_match_2): Arguments that
7931 specify buffer/string position and length are now ssize_t and
7932 size_t. Return type is regoff_t.
7934 2011-04-16 Ben Key <bkey76@gmail.com>
7936 * nsfont.m: Fixed bugs in ns_get_family and
7937 ns_descriptor_to_entity that were caused by using free to
7938 deallocate memory blocks that were allocated by xmalloc (via
7939 xstrdup). This caused Emacs to crash when compiled with
7940 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7941 --enable-checking=xmallocoverrun). xfree is now used to
7942 deallocate these memory blocks.
7944 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7946 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7948 emacs_write: Accept and return EMACS_INT for sizes.
7949 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7951 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7952 Accept and return EMACS_INT.
7953 (emacs_gnutls_write): Return the number of bytes written on
7955 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7956 (emacs_read, emacs_write): Remove check for negative size, as the
7957 Emacs source code has been audited now.
7958 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7959 (emacs_read, emacs_write): Use it.
7960 * process.c (send_process): Adjust to the new signatures of
7961 emacs_write and emacs_gnutls_write. Do not attempt to store
7962 a byte offset into an 'int'; it might overflow.
7963 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7965 * sound.c: Don't assume sizes fit in 'int'.
7966 (struct sound_device.period_size, alsa_period_size):
7967 Return EMACS_INT, not int.
7968 (struct sound_device.write, vox_write, alsa_write):
7969 Accept EMACS_INT, not int.
7970 (wav_play, au_play): Use EMACS_INT to store sizes and to
7971 record read return values.
7973 2011-04-15 Ben Key <bkey76@gmail.com>
7975 * keyboard.c (Qundefined): Don't declare static since it is used
7977 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7978 static since they are used in nsfont.m.
7980 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7982 * process.c (Qprocessp): Don't declare static.
7983 * lisp.h (Qprocessp): Declare again.
7985 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7987 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7989 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7991 Improve C-level modularity by making more things 'static'.
7993 Don't publish debugger-only interfaces to other modules.
7994 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7995 (verify_bytepos, count_markers): Move decls to the only modules
7997 * region-cache.h (pp_cache): Likewise.
7998 * window.h (check_all_windows): Likewise.
7999 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8001 * sysdep.c (croak): Now static, if
8002 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8003 * syssignal.h (croak): Declare only if not static.
8005 * alloc.c (refill_memory_reserve): Now static if
8006 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8007 * lisp.h (refill_memory_reserve): Declare only if not static.
8009 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8010 Define only if USE_LUCID.
8012 * xrdb.c (x_customization_string, x_rm_string): Now static.
8014 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8015 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8017 * xdisp.c (draw_row_with_mouse_face): Now static.
8018 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8020 * window.h (check_all_windows): Mark externally visible.
8022 * window.c (window_deletion_count): Now static.
8024 * undo.c: Make symbols static if they're not exported.
8025 (last_undo_buffer, last_boundary_position, pending_boundary):
8028 * textprop.c (interval_insert_behind_hooks): Now static.
8029 (interval_insert_in_front_hooks): Likewise.
8031 * term.c: Make symbols static if they're not exported.
8032 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8033 (max_frame_lines, tty_set_terminal_modes):
8034 (tty_reset_terminal_modes, tty_turn_off_highlight):
8035 (get_tty_terminal): Now static.
8036 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8037 * termhooks.h (term_mouse_moveto): Do not declare if
8039 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8040 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8042 * sysdep.c: Make symbols static if they're not exported.
8043 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8045 (sigprocmask_set, full_mask): Remove; unused.
8046 (wait_debugging): Mark as visible.
8047 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8048 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8050 * syntax.c (syntax_temp): Define only if !__GNUC__.
8052 * sound.c (current_sound_device, current_sound): Now static.
8054 * search.c (searchbufs, searchbuf_head): Now static.
8056 * scroll.c (scroll_cost): Remove; unused.
8057 * dispextern.h (scroll_cost): Remove decl.
8059 * region-cache.h (pp_cache): Mark as externally visible.
8061 * process.c: Make symbols static if they're not exported.
8062 (process_tick, update_tick, create_process, chan_process):
8063 (Vprocess_alist, proc_buffered_char, datagram_access):
8064 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8065 (deactivate_process): Mark defn as static, as well as decl.
8066 * lisp.h (create_process): Remove decl.
8067 * process.h (chan_process, Vprocess_alist): Remove decls.
8069 * print.c: Make symbols static if they're not exported.
8070 (print_depth, new_backquote_output, being_printed, print_buffer):
8071 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8072 (print_interval, print_number_index, initial_stderr_stream):
8074 * lisp.h (Fprinc): Remove decl.
8075 (debug_output_compilation_hack): Mark as externally visible.
8077 * sysdep.c (croak): Move decl from here to syssignal.h.
8078 * syssignal.h (croak): Put it here, so the API can be checked when
8079 'croak' is called from dissociate_if_controlling_tty.
8081 * minibuf.c: Make symbols static if they're not exported.
8082 (minibuf_save_list, choose_minibuf_frame): Now static.
8083 * lisp.h (choose_minibuf_frame): Remove decl.
8085 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8087 * lread.c: Make symbols static if they're not exported.
8088 (read_objects, initial_obarray, oblookup_last_bucket_number):
8090 (make_symbol): Remove; unused.
8091 * lisp.h (initial_obarray, make_symbol): Remove decls.
8093 * keyboard.c: Make symbols static if they're not exported.
8094 (single_kboard, recent_keys_index, total_keys, recent_keys):
8095 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8096 (this_single_command_key_start, echoing, last_auto_save):
8097 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8098 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8099 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8100 (Vlispy_mouse_stem, double_click_count):
8102 (force_auto_save_soon): Define only if SIGDANGER.
8103 (ignore_mouse_drag_p): Now static if
8104 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8105 (print_help): Remove; unused.
8106 (stop_character, last_timer_event): Mark as externally visible.
8107 * keyboard.h (ignore_mouse_drag_p): Declare only if
8108 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8109 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8110 * lisp.h (echoing): Remove decl.
8111 (force_auto_save_soon): Declare only if SIGDANGER.
8112 * xdisp.c (redisplay_window): Simplify code, to make it more
8113 obvious that ignore_mouse_drag_p is not accessed if !defined
8114 USE_GTK && !defined HAVE_NS.
8116 * intervals.c: Make symbols static if they're not exported.
8117 (merge_properties_sticky, merge_interval_right, delete_interval):
8119 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8121 * insdel.c: Make symbols static if they're not exported.
8122 However, leave prepare_to_modify_buffer alone. It's never
8123 called from outside this function, but that appears to be a bug.
8124 (combine_after_change_list, combine_after_change_buffer):
8125 (adjust_after_replace, signal_before_change): Now static.
8126 (adjust_after_replace_noundo): Remove; unused.
8127 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8128 (signal_before_change): Remove decls.
8130 * indent.c (val_compute_motion, val_vmotion): Now static.
8132 * image.c: Make symbols static if they're not exported.
8133 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8135 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8136 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8138 * fringe.c (standard_bitmaps): Now static.
8139 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8141 * frame.c: Make symbols static if they're not exported.
8142 (x_report_frame_params, make_terminal_frame): Now static.
8143 (get_frame_param): Now static, unless HAVE_NS.
8144 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8145 (x_get_resource_string): Remove; not used.
8146 * frame.h (make_terminal_frame, x_report_frame_params):
8147 (x_get_resource_string); Remove decls.
8148 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8149 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8151 * font.c, fontset.c: Make symbols static if they're not exported.
8152 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8153 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8154 * font.c (font_close_object): Now static.
8155 * font.h (font_close_object): Remove.
8156 * fontset.c (FONTSET_OBJLIST): Remove.
8157 (free_realized_fontset) #if-0 the body, which does nothing.
8158 (face_suitable_for_char_p): #if-0, as it's never called.
8159 * fontset.h (face_suitable_for_char_p): Remove decl.
8160 * xfaces.c (face_at_string_position):
8161 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8162 since 0 is always ASCII.
8164 * fns.c (weak_hash_tables): Now static.
8166 * fileio.c: Make symbols static if they're not exported.
8167 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8168 (Vwrite_region_annotation_buffers): Now static.
8170 * eval.c: Make symbols static if they're not exported.
8171 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8172 * lisp.h (backtrace_list): Remove decl.
8174 * emacs.c: Make symbols static if they're not exported.
8175 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8176 (fatal_error_code, fatal_error_signal_hook, standard_args):
8178 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8179 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8180 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8181 * lisp.h (fatal_error_signal_hook): Remove decl.
8182 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8184 * editfns.c: Move a (normally-unused) function to its only use.
8185 * editfns.c, lisp.h (get_operating_system_release): Remove.
8186 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8187 worth the hassle of breaking this out.
8189 * xterm.c: Make symbols static if they're not exported.
8190 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8191 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8192 (x_destroy_window, x_delete_display):
8194 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8195 (x_mouse_leave): Remove; unused.
8196 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8197 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8198 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8200 (x_mouse_leave): Declare only if WINDOWSNT.
8201 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8202 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8205 * ftxfont.c: Make symbols static if they're not exported.
8206 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8208 * font.h (ftxfont_driver): Likewise.
8210 * xfns.c: Make symbols static if they're not exported.
8211 (x_last_font_name, x_display_info_for_name):
8212 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8213 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8214 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8215 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8216 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8217 (last_show_tip_args): Now static.
8218 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8219 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8220 (x_screen_planes): Remove; unused.
8221 * dispextern.h (x_screen_planes): Remove decl.
8223 * dispnew.c: Make symbols static if they're not exported.
8224 * dispextern.h (redraw_garbaged_frames, scrolling):
8225 (increment_row_positions): Remove.
8226 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8227 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8229 (redraw_garbaged_frames): Remove; unused.
8231 * xfaces.c: Make symbols static if they're not exported.
8232 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8234 * xterm.h (defined_color): Remove decls.
8235 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8236 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8237 (menu_face_changed_default, defined_color, free_realized_face):
8238 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8239 (ascii_face_of_lisp_face): Remove; unused.
8241 * xdisp.c: Make symbols static if they're not exported.
8242 * dispextern.h (scratch_glyph_row, window_box_edges):
8243 (glyph_to_pixel_coords, set_cursor_from_row):
8244 (get_next_display_element, set_iterator_to_next):
8245 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8246 (show_mouse_face): Remove decls
8247 * frame.h (message_buf_print): Likewise.
8248 * lisp.h (pop_message, set_message, check_point_in_composition):
8250 * xterm.h (set_vertical_scroll_bar): Likewise.
8251 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8252 (message_buf_print, scratch_glyph_row, displayed_buffer):
8253 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8254 (get_next_display_element, show_mouse_face, window_box_edges):
8255 (frame_to_window_pixel_xy, check_point_in_composition):
8256 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8257 (glyph_to_pixel_coords): Remove; unused.
8259 * dired.c (file_name_completion): Now static.
8261 * dbusbind.c (xd_in_read_queued_messages): Now static.
8263 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8264 * data.c (circular_list_error): Remove.
8266 * commands.h (last_point_position, last_point_position_buffer):
8267 (last_point_position_window): Remove decls.
8268 * keyboard.c: Make these variables static.
8270 * coding.h (coding, code_convert_region, encode_coding_gap):
8272 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8273 (iso_code_class, detect_coding, code_convert_region): Now static.
8274 (encode_coding_gap): Remove; unused.
8276 * chartab.c (chartab_chars, chartab_bits): Now static.
8278 * charset.h (charset_iso_8859_1): Remove decl.
8279 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8282 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8283 * ccl.c (Vccl_program_table): Now static.
8284 (check_ccl_update): Remove; unused.
8286 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8287 * category.h: ... from here.
8288 * category.c (check_category_table, set_category_set): Now static.
8290 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8291 * lisp.h: Remove these decls.
8293 * buffer.c (buffer_count): Remove unused var.
8295 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8296 so that it's not optimized away.
8297 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8298 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8299 exported only to the debugger.
8301 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8302 * atimer.h (run_all_atimers): Remove; not exported.
8304 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8305 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8306 was inaccessible from Lisp.
8307 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8308 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8310 alloc.c: Import and export fewer symbols, and remove unused items.
8311 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8313 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8314 it's not optimized away by whole-program optimization.
8315 (message_enable_multibyte, free_misc): Remove.
8316 (catchlist, handlerlist, mark_backtrace):
8317 Declare only if BYTE_MARK_STACK.
8318 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8319 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8320 (message_enable_multibyte): Remove decl.
8321 (free_misc, interval_free_list, float_block, float_block_index):
8322 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8323 (cons_free_list, last_marked_index):
8325 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8326 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8327 (mark_backtrace): Define only if BYTE_MARK_STACK.
8328 * xdisp.c (message_enable_multibyte): Now static.
8330 Declare Lisp_Object Q* variables to be 'static' if not exported.
8331 This makes it easier for human readers (and static analyzers)
8332 to see whether these variables are used from other modules.
8333 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8334 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8335 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8336 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8337 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8338 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8339 * xmenu.c, xselect.c:
8340 Declare Q* vars static if they are not used in other modules.
8341 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8342 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8343 Remove decls of unexported vars.
8344 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8346 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8348 Make Emacs functions such as Fatom 'static' by default.
8349 This makes it easier for human readers (and static analyzers)
8350 to see whether these functions can be called from other modules.
8351 DEFUN now defines a static function. To make the function external
8352 so that it can be used in other C modules, use the new macro DEFUE.
8353 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8354 (Finit_image_library):
8355 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8356 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8357 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8358 Remove decls, since these functions are now static.
8359 (Funintern, Fget_internal_run_time): New decls, since these functions
8360 were already external.
8362 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8363 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8364 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8365 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8366 * keyboard.c, keymap.c, lread.c:
8367 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8368 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8369 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8370 Mark functions with DEFUE instead of DEFUN,
8371 if they are used in other modules.
8372 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8373 decls for now-static functions.
8374 * buffer.h (Fdelete_overlay): Remove decl.
8375 * callproc.c (Fgetenv_internal): Mark as internal.
8376 * composite.c (Fremove_list_of_text_properties): Remove decl.
8377 (Fcomposition_get_gstring): New forward static decl.
8378 * composite.h (Fcomposite_get_gstring): Remove decl.
8379 * dired.c (Ffile_attributes): New forward static decl.
8380 * doc.c (Fdocumntation_property): New forward static decl.
8381 * eval.c (Ffetch_bytecode): New forward static decl.
8382 (Funintern): Remove extern decl; now in .h file where it belongs.
8383 * fileio.c (Fmake_symbolic_link): New forward static decl.
8384 * image.c (Finit_image_library): New forward static decl.
8385 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8386 * intervals.h (Fprevious_property_change):
8387 (Fremove_list_of_text_properties): Remove decls.
8388 * keyboard.c (Fthis_command_keys): Remove decl.
8389 (Fcommand_execute): New forward static decl.
8390 * keymap.c (Flookup_key): New forward static decl.
8391 (Fcopy_keymap): Now static.
8392 * keymap.h (Flookup_key): Remove decl.
8393 * process.c (Fget_process): New forward static decl.
8394 (Fprocess_datagram_address): Mark as internal.
8395 * syntax.c (Fsyntax_table_p): New forward static decl.
8396 (skip_chars): Remove duplicate decl.
8397 * textprop.c (Fprevious_property_change): New forward static decl.
8398 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8400 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8401 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8403 * editfns.c (Fformat): Remove unreachable code.
8405 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8407 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8410 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8412 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8413 when at ZV. (Bug#8487)
8415 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8417 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8419 * keyboard.c (parse_tool_bar_item): Likewise.
8420 * sound.c (sound_cleanup, alsa_close): Likewise.
8421 * termcap.c (tgetent): Likewise.
8422 * xfns.c (x_default_font_parameter): Likewise.
8423 * xsettings.c (read_and_apply_settings): Likewise.
8425 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8426 (overrun_check_free): Protoize.
8428 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8430 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8431 since callers should never pass a negative size.
8432 Change the signature to match that of plain 'read' and 'write'; see
8433 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8434 * lisp.h: Update prototypes of emacs_write and emacs_read.
8436 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8438 * xdisp.c (redisplay_window): Don't try to determine the character
8439 position of the scroll margin if the window start point w->startp
8440 is outside the buffer's accessible region. (Bug#8468)
8442 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8444 Fix write-region and its subroutines for buffers > 2GB.
8445 * fileio.c (a_write, e_write): Modify declaration of arguments and
8446 local variables to support buffers larger than 2GB.
8447 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8449 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8450 argument, local variables, and return value.
8452 * lisp.h: Update prototypes of emacs_write and emacs_read.
8454 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8456 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8458 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8460 Fix more problems found by GCC 4.6.0's static checks.
8462 * xdisp.c (vmessage): Use a better test for character truncation.
8464 * charset.c (load_charset_map): <, not <=, for optimization,
8465 and to avoid potential problems with integer overflow.
8466 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8467 * casetab.c (set_identity, shuffle): Likewise.
8468 * editfns.c (Fformat): Likewise.
8469 * syntax.c (skip_chars): Likewise.
8471 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8472 This also lets GCC 4.6.0 generate slightly better loop code.
8474 * callint.c (Fcall_interactively): <, not <=, for optimization.
8475 (Fcall_interactively): Count the number of arguments produced,
8476 not the number of arguments given. This is simpler and lets GCC
8477 4.6.0 generate slightly better code.
8479 * ftfont.c: Distingish more carefully between FcChar8 and char.
8480 The previous code passed unsigned char * to a functions like
8481 strlen and xstrcasecmp that expect char *, which does not
8482 conform to the C standard.
8483 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8484 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8485 char * when the C standard requires it.
8487 * keyboard.c (read_char): Remove unused var.
8489 * eval.c: Port to Windows vsnprintf (Bug#8435).
8491 (SIZE_MAX): Define if the headers do not.
8492 (verror): Do not give up if vsnprintf returns a negative count.
8493 Instead, grow the buffer. This ports to Windows vsnprintf, which
8494 does not conform to C99. Problem reported by Eli Zaretskii.
8495 Also, simplify the allocation scheme, by avoiding the need for
8496 calling realloc, and removing the ALLOCATED variable.
8498 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8500 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8501 But keep the doprint source code for now, as we might revamp it
8502 and use it again (Bug#8435).
8503 * lisp.h (doprnt): Remove.
8504 * Makefile.in (base_obj): Remove doprnt.o.
8505 * deps.mk (doprnt.o): Remove.
8507 error: Print 32- and 64-bit integers portably (Bug#8435).
8508 Without this change, on typical 64-bit hosts error ("...%d...", N)
8509 was used to print both 32- and 64-bit integers N, which relied on
8511 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8512 * lisp.h (error, verror): Mark as printf-like functions.
8513 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8514 Report overflow in size calculations when allocating printf buffer.
8515 Do not truncate output string at its first null byte.
8516 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8517 Truncate the output at a character boundary, since vsnprintf does not
8519 * charset.c (check_iso_charset_parameter): Convert internal
8520 character to string before calling 'error', since %c now has the
8522 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8523 overflow when computing char to be passed to 'error'. Do not
8524 pass Lisp_Object to 'error'; pass the integer instead.
8525 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8526 formatted with plain %d.
8528 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8530 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8532 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8534 * xterm.c (x_catch_errors): Remove duplicate declaration.
8536 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8538 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8540 2011-04-10 Jim Meyering <meyering@redhat.com>
8542 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8543 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8544 return ssize_t not "int", and use size_t as the buffer length.
8545 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8546 * gnutls.h: Update declarations.
8547 * process.c (read_process_output): Use ssize_t, to match.
8548 (send_process): Likewise.
8550 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8552 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8554 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8556 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8557 Use unsigned char, to match FcChar8 type definition.
8559 * xterm.c (handle_one_xevent):
8560 * xmenu.c (create_and_show_popup_menu):
8561 * xselect.c (x_decline_selection_request)
8562 (x_reply_selection_request): Avoid type-punned deref of X events.
8564 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8566 Fix some uses of `int' instead of EMACS_INT.
8567 * search.c (string_match_1, fast_string_match)
8568 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8569 (scan_buffer, find_next_newline_no_quit)
8570 (find_before_next_newline, search_command, Freplace_match)
8571 (Fmatch_data): Make some `int' variables be EMACS_INT.
8573 * xdisp.c (display_count_lines): 3rd argument and return value now
8574 EMACS_INT. All callers changed.
8575 (pint2hrstr): Last argument is now EMACS_INT.
8577 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8578 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8579 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8580 (decode_coding_utf_16, decode_coding_emacs_mule)
8581 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8582 (decode_coding_ccl, decode_coding_charset)
8583 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8584 (decode_coding_iso_2022, decode_coding_emacs_mule)
8585 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8586 <char_offset, last_offset>: Declare EMACS_INT.
8587 (encode_coding_utf_8, encode_coding_utf_16)
8588 (encode_coding_emacs_mule, encode_invocation_designation)
8589 (encode_designation_at_bol, encode_coding_iso_2022)
8590 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8591 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8593 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8594 (encode_invocation_designation): Last argument P_NCHARS is now
8596 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8597 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8599 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8602 * ccl.c (Fccl_execute_on_string): Declare some variables
8605 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8607 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8609 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8611 * process.c (Fformat_network_address): Doc fix.
8613 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8615 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8617 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8619 * keyboard.c (read_char): Call Lisp function help-form-show,
8620 instead of using internal_with_output_to_temp_buffer.
8621 (Qhelp_form_show): New var.
8622 (syms_of_keyboard): Use DEFSYM macro.
8624 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8626 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8628 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8630 * process.c (Flist_processes): Remove to Lisp.
8631 (list_processes_1): Delete.
8633 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8635 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8637 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8639 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8641 Fix more problems found by GCC 4.6.0's static checks.
8643 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8645 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8647 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8649 * xdisp.c (vmessage): Mark as a printf-like function.
8651 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8653 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8655 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8656 printf-like functions.
8657 (tiff_load): Add casts to remove these marks before passing them
8658 to system-supplied API.
8660 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8662 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8663 This avoids several warnings with gcc -Wstrict-overflow.
8664 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8665 directly, rather than having caller test rule sign. This avoids
8666 some unnecessary tests.
8667 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8668 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8669 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8671 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8672 (xfont_open): Avoid unnecessary tests.
8674 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8676 * composite.h, composite.c (composition_gstring_put_cache):
8677 Use EMACS_INT, not int, for length.
8679 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8680 breaking out part of COMPOSITION_DECODE_RULE.
8681 (COMPOSITION_DECODE_RULE): Use it.
8682 * composite.c (get_composition_id): Remove unused local vars,
8683 by using the new macro.
8685 * textprop.c (set_text_properties_1): Change while to do-while,
8686 since the condition is always true at first.
8688 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8689 (interval_deletion_adjustment): Return unsigned value.
8692 * process.c (list_processes_1, create_pty, read_process_output):
8693 (exec_sentinel): Remove vars that were set but not used.
8694 (create_pty): Remove unnecessary "volatile"s.
8695 (Fnetwork_interface_info): Avoid possibility of int overflow.
8696 (read_process_output): Do adaptive read buffering even if carryover.
8697 (read_process_output): Simplify nbytes computation if buffered.
8699 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8701 * syntax.c (scan_words): Remove var that was set but not used.
8702 (update_syntax_table): Use unsigned instead of int.
8704 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8705 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8706 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8708 * print.c (print_error_message): Avoid int overflow.
8710 * font.c (font_list_entities): Redo for clarity,
8711 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8713 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8714 (font_score): Avoid potential overflow in diff calculation.
8716 * fns.c (substring_both): Remove var that is set but not used.
8717 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8719 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8721 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8722 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8723 can always succeed if overflow has undefined behavior.
8725 * search.c (boyer_moore, wordify): Remove vars set but not used.
8726 (wordify): Omit three unnecessary tests.
8728 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8729 All callers changed. This avoids the need for an unused var.
8731 * casefiddle.c (casify_region): Remove var that is set but not used.
8733 * dired.c (file_name_completion): Remove var that is set but not used.
8735 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8737 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8738 (Finsert_file_contents): Remove unnecessary code checking fd.
8740 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8741 Check for integer overflow on size calculations.
8743 * buffer.c (Fprevious_overlay_change): Remove var that is set
8746 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8747 Remove vars that are set but not used.
8748 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8749 (timer_check_2): Mark vars as initialized.
8751 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8753 * image.c (lookup_image): Remove var that is set but not used.
8754 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8756 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8757 that are set but not used.
8759 * xfns.c (make_invisible_cursor): Don't return garbage
8760 if XCreateBitmapFromData fails (Bug#8410).
8762 * xselect.c (x_get_local_selection, x_handle_property_notify):
8763 Remove vars that are set but not used.
8765 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8766 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8768 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8769 Remove var that is set but not used.
8770 (scroll_bar_windows_size): Now size_t, not int.
8771 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8774 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8775 (map_tty_color) [!defined MSDOS]: Likewise.
8777 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8779 * coding.c: Remove vars that are set but not used.
8780 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8781 All callers changed.
8782 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8783 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8784 (decode_coding_charset): Remove vars that are set but not used.
8786 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8787 that is set but not used.
8789 * print.c (print_object): Remove var that is set but not used.
8791 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8792 The gnulib version avoids calling malloc in the usual case,
8793 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8794 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8795 * filelock.c (current_lock_owner): Likewise.
8796 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8797 * sysdep.c: Include allocator.h, careadlinkat.h.
8798 (emacs_no_realloc_allocator): New static constant.
8799 (emacs_readlink): New function.
8800 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8801 ../lib/careadlinkat.h.
8803 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8805 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8806 first non-nil return value).
8808 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8810 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8811 if not defined (Bug#8403).
8813 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8815 * xdisp.c (display_count_lines): Remove parameter `start',
8816 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8817 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8818 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8819 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8820 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8821 and thereabouts. All callers changed.
8822 (get_per_char_metric): Remove parameter `f', unused since
8823 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8825 2011-04-02 Jim Meyering <meyering@redhat.com>
8827 do not dereference NULL upon failed strdup
8828 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8829 (ns_get_family): Likewise.
8831 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8833 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8835 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8837 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8840 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8842 Add lexical binding.
8844 * window.c (Ftemp_output_buffer_show): New fun.
8845 (Fsave_window_excursion):
8846 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8848 * lread.c (lisp_file_lexically_bound_p): New function.
8849 (Fload): Bind Qlexical_binding.
8850 (readevalloop): Remove `evalfun' arg.
8851 Bind Qinternal_interpreter_environment.
8852 (Feval_buffer): Bind Qlexical_binding.
8853 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8855 (syms_of_lread): Declare `lexical-binding'.
8857 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8859 * keyboard.c (eval_dyn): New fun.
8860 (menu_item_eval_property): Use it.
8862 * image.c (parse_image_spec): Use Ffunctionp.
8864 * fns.c (concat, mapcar1): Accept byte-code-functions.
8866 * eval.c (Fsetq): Handle lexical vars.
8867 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8868 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8869 (FletX, Flet): Obey lexical binding.
8870 (Fcommandp): Handle closures.
8871 (Feval): New `lexical' arg.
8872 (eval_sub): New function extracted from Feval. Use it almost
8873 everywhere where Feval was used. Look up vars in lexical env.
8875 (Ffunctionp): Move from subr.el.
8876 (Ffuncall): Handle closures.
8877 (apply_lambda): Remove `eval_flags'.
8878 (funcall_lambda): Handle closures and new byte-code-functions.
8879 (Fspecial_variable_p): New function.
8880 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8881 but without exporting it to Lisp.
8883 * doc.c (Fdocumentation, store_function_docstring):
8884 * data.c (Finteractive_form): Handle closures.
8886 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8889 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8891 (exec_byte_code): New function extracted from Fbyte_code to handle new
8892 calling convention for byte-code-functions. Add new byte-codes.
8894 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8896 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8898 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8900 * xdisp.c (redisplay_internal): Fix prototype.
8902 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8904 * xdisp.c (SCROLL_LIMIT): New macro.
8905 (try_scrolling): Use it when setting scroll_limit.
8906 Limit scrolling to 100 screen lines.
8907 (redisplay_window): Even when falling back on "recentering",
8908 position point in the window according to scroll-conservatively,
8909 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8911 (try_scrolling): When point is above the window, allow searching
8912 as far as scroll_max, or one screenful, to compute vertical
8913 distance from PT to the scroll margin position. This prevents
8914 try_scrolling from unnecessarily failing when
8915 scroll-conservatively is set to a value slightly larger than the
8916 window height. Clean up the case of PT below the margin at bottom
8917 of window: scroll_max can no longer be INT_MAX. When aggressive
8918 scrolling is in use, don't let point enter the opposite scroll
8919 margin as result of the scroll.
8920 (syms_of_xdisp) <scroll-conservatively>: Document the
8921 threshold of 100 lines for never-recentering scrolling.
8923 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8925 * dispextern.h (move_it_by_lines):
8926 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8927 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8928 (message_log_check_duplicate): Remove parameters `prev_bol' and
8929 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8930 (redisplay_internal): Remove parameter `preserve_echo_area',
8931 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8933 * indent.c (Fvertical_motion):
8934 * window.c (window_scroll_pixel_based, Frecenter):
8935 Don't pass `need_y_p' to `move_it_by_lines'.
8937 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8939 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8940 steal a few bits to be more compact.
8941 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8942 Remove unneeded casts.
8944 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8946 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8948 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8949 binding" message (bug#7967).
8951 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8953 Fix more problems found by GCC 4.6.0's static checks.
8955 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8956 Remove unused local var.
8958 * editfns.c (Fmessage_box): Remove unused local var.
8960 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8961 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8962 Omit unused local vars.
8963 * window.c (shrink_windows): Omit unused local var.
8964 * menu.c (digest_single_submenu): Omit unused local var.
8965 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8966 Omit unused local var.
8968 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8969 Don't assume string length fits in int.
8970 (keyremap_step, read_key_sequence): Use size_t for sizes.
8971 (read_key_sequence): Don't check last_real_key_start redundantly.
8973 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8974 instead of alloca (Bug#8344).
8976 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8977 (Fbacktrace_frame): Don't assume nframes fits in int.
8979 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8981 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8984 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8986 * cm.c (calccost): Turn while-do into do-while, for clarity.
8988 * keyboard.c (syms_of_keyboard): Use the same style as later
8989 in this function when indexing through an array. This also
8990 works around GCC bug 48267.
8992 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8994 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8996 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8997 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8999 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9000 This avoids undefined behavior on integer overflow, and is a bit
9001 more convenient anyway since it is compared to a size_t variable.
9003 Variadic C functions now count arguments with size_t, not int.
9004 This avoids an unnecessary limitation on 64-bit machines, which
9005 caused (substring ...) to crash on large vectors (Bug#8344).
9006 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9007 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9008 All variadic functions and their callers changed accordingly.
9009 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9010 * data.c (arith_driver, float_arith_driver): Likewise.
9011 * editfns.c (general_insert_function): Likewise.
9012 * eval.c (struct backtrace.nargs, interactive_p)
9013 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9014 (funcall_lambda, mark_backtrace): Likewise.
9015 * fns.c (concat): Likewise.
9016 * frame.c (x_set_frame_parameters): Likewise.
9017 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9018 0 if not found, not -1. All callers changed.
9020 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9021 (stack_copy_size): Now size_t, not int.
9022 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9024 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9026 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9027 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9028 All callers changed.
9030 * lisp.h (multibyte_char_to_unibyte):
9031 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9032 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9033 * character.h (CHAR_TO_BYTE8):
9034 * cmds.c (internal_self_insert):
9035 * editfns.c (general_insert_function):
9036 * keymap.c (push_key_description):
9037 * search.c (Freplace_match):
9038 * xdisp.c (message_dolog, set_message_1): All callers changed.
9040 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9042 * keyboard.c (safe_run_hook_funcall): New function.
9043 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9044 don't set the hook to nil, but remove the offending function instead.
9045 (Qcommand_hook_internal): Remove, unused.
9046 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9047 Vcommand_hook_internal.
9049 * eval.c (enum run_hooks_condition): Remove.
9050 (funcall_nil, funcall_not): New functions.
9051 (run_hook_with_args): Call each function through a `funcall' argument.
9052 Remove `cond' argument, now redundant.
9053 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9054 (Frun_hook_with_args_until_failure): Adjust accordingly.
9055 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9057 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9059 * dispextern.h (string_buffer_position): Remove declaration.
9061 * print.c (strout): Remove parameter `multibyte', unused since
9062 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9064 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9065 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9066 All callers changed.
9068 * w32.c (_wsa_errlist): Use braces for struct initializers.
9070 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9071 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9072 All callers changed.
9073 (string_buffer_position): Likewise. Also, make static (it's never
9074 used outside xdisp.c).
9075 (cursor_row_p): Remove parameter `w', unused since
9076 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9077 (decode_mode_spec): Remove parameter `precision', introduced during
9078 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9079 All callers changed.
9081 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9083 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9085 2011-03-27 Anders Lindgren <andlind@gmail.com>
9087 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9088 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9089 (ns_update_auto_hide_menu_bar): New functions.
9090 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9091 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9092 ns_constrain_all_frames.
9093 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9094 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9096 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9098 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9100 2011-03-27 Glenn Morris <rgm@gnu.org>
9102 * syssignal.h: Replace RETSIGTYPE with void.
9103 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9104 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9105 Replace SIGTYPE with void everywhere.
9106 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9107 * s/template.h (SIGTYPE): Remove commented out definition.
9109 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9111 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9112 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9114 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9116 * w32.c (read_unc_volume): Use parameter `henum', instead of
9117 global variable `wget_enum_handle'.
9119 * keymap.c (describe_vector): Remove parameters `indices' and
9120 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9121 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9123 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9125 * keyboard.c (timer_check): Remove parameter `do_it_now',
9126 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9127 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9128 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9130 * keyboard.c (read_char):
9131 * w32menu.c (w32_menu_display_help):
9132 * xmenu.c (show_help_event, menu_help_callback):
9133 Adjust calls to `show_help_echo'.
9135 * gtkutil.c (xg_maybe_add_timer):
9136 * keyboard.c (readable_events):
9137 * process.c (wait_reading_process_output):
9138 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9140 * insdel.c (adjust_markers_gap_motion):
9141 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9142 (gap_left, gap_right): Don't call it.
9144 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9146 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9147 incurred during fontification.
9149 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9151 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9152 (DEFVAR_PER_BUFFER): Don't pass it.
9154 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9155 (scrolling_window): Don't pass it.
9157 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9159 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9161 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9163 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9164 of variables specific to SELinux and computation of `encoded_absname'.
9166 * image.c (XPutPixel): Remove unused variable `height'.
9168 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9170 * unexw32.c (get_section_info): Remove unused variable `section'.
9172 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9173 (system_process_attributes): Remove unused variable `sess'.
9174 (sys_read): Remove unused variable `err'.
9176 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9177 (w32_wnd_proc): Remove unused variable `isdead'.
9178 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9179 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9180 (x_create_tip_frame): Remove unused variable `tem'.
9182 * w32inevt.c (w32_console_read_socket):
9183 Remove unused variable `no_events'.
9185 * w32term.c (x_draw_composite_glyph_string_foreground):
9186 Remove unused variable `width'.
9188 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9190 * w32term.c (x_set_glyph_string_clipping):
9191 Don't pass uninitialized region to CombineRgn.
9193 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9195 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9196 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9197 (Fx_close_connection): Remove unused variable `i'.
9199 * w32font.c (w32font_draw): Return number of glyphs.
9200 (w32font_open_internal): Remove unused variable `i'.
9201 (w32font_driver): Add missing initializer.
9203 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9204 (fill_in_menu): Remove unused variable `items_added'.
9206 * w32term.c (last_mouse_press_frame): Remove static global variable.
9207 (w32_clip_to_row): Remove unused variable `f'.
9208 (x_delete_terminal): Remove unused variable `i'.
9210 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9211 (NOTHING): Remove unused static global variable.
9212 (uniscribe_check_otf): Remove unused variable `table'.
9213 (uniscribe_font_driver): Add missing initializers.
9215 2011-03-23 Julien Danjou <julien@danjou.info>
9217 * term.c (Fsuspend_tty, Fresume_tty):
9218 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9219 * window.c (temp_output_buffer_show):
9220 * insdel.c (signal_before_change):
9221 * frame.c (Fhandle_switch_frame):
9222 * fileio.c (Fdo_auto_save):
9223 * emacs.c (Fkill_emacs):
9224 * editfns.c (save_excursion_restore):
9225 * cmds.c (internal_self_insert):
9226 * callint.c (Fcall_interactively):
9227 * buffer.c (Fkill_all_local_variables):
9228 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9230 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9231 unconditionally since it does the check itself.
9233 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9235 Fix more problems found by GCC 4.5.2's static checks.
9237 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9238 the first time through the loop, since we know p0 < p1 then.
9239 This also avoids a gcc -Wstrict-overflow warning.
9241 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9242 leading to a memory leak, possible in functions like
9243 load_charset_map_from_file that can allocate an unbounded number
9244 of objects (Bug#8318).
9246 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9247 that could (at least in theory) be that large.
9249 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9250 This is less likely to overflow, and avoids undefined behavior if
9251 overflow does occur. All callers changed. Use strtoul to scan
9252 for the unsigned long integer.
9253 (pint2hrstr): Simplify and tune code slightly.
9254 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9256 * scroll.c (do_scrolling): Work around GCC bug 48228.
9257 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9259 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9260 This also avoids a warning with gcc -Wstrict-overflow.
9261 (validate_x_resource_name): Simplify count usage.
9262 This also avoids a warning with gcc -Wstrict-overflow.
9264 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9267 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9269 * process.c (Fmake_network_process): Use socklen_t, not int,
9270 where POSIX says socklen_t is required in portable programs.
9271 This fixes a porting bug on hosts like 64-bit HP-UX, where
9272 socklen_t is wider than int (Bug#8277).
9273 (Fmake_network_process, server_accept_connection):
9274 (wait_reading_process_output, read_process_output):
9277 * process.c: Rename or move locals to avoid shadowing.
9278 (list_processes_1, Fmake_network_process):
9279 (read_process_output_error_handler, exec_sentinel_error_handler):
9280 Rename or move locals.
9281 (Fmake_network_process): Define label "retry_connect" only if needed.
9282 (Fnetwork_interface_info): Fix pointer signedness.
9283 (process_send_signal): Add cast to avoid pointer signedness problem.
9284 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9285 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9287 Make tparam.h and terminfo.c consistent.
9288 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9289 Include tparam.h instead, since it declares them.
9290 * cm.h (PC): Remove extern decl; tparam.h now does this.
9291 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9292 * terminfo.c: Include tparam.h, to check interfaces.
9293 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9294 (tparam): Adjust signature to match interface in tparam.h;
9295 this removes some undefined behavior. Check that outstring and len
9296 are zero, which they always are with Emacs.
9297 * tparam.h (PC, BC, UP): New extern decls.
9299 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9300 (xftfont_open): Rename locals to avoid shadowing.
9302 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9303 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9304 (OTF_TAG_SYM): Omit macro if not needed.
9305 (ftfont_list): Remove unused local.
9306 (get_adstyle_property, ftfont_pattern_entity):
9307 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9308 Rename locals to avoid shadowing.
9310 * xfont.c (xfont_list_family): Mark var as initialized.
9312 * xml.c (make_dom): Now static.
9314 * composite.c (composition_compute_stop_pos): Rename local to
9316 (composition_reseat_it): Remove unused locals.
9317 (find_automatic_composition, composition_adjust_point): Likewise.
9318 (composition_update_it): Mark var as initialized.
9319 (find_automatic_composition): Mark vars as initialized,
9320 with a FIXME (Bug#8290).
9322 character.h: Rename locals to avoid shadowing.
9323 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9324 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9325 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9326 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9329 * textprop.c (property_change_between_p): Remove; unused.
9331 * intervals.c (interval_start_pos): Now static.
9333 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9335 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9336 Rename locals to avoid shadowing.
9338 * sound.c (wav_play, au_play, Fplay_sound_internal):
9339 Fix pointer signedness.
9340 (alsa_choose_format): Remove unused local var.
9341 (wav_play): Initialize a variable to 0, to prevent undefined
9342 behavior (Bug#8278).
9344 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9346 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9348 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9349 clobbering (Bug#8298).
9350 * sysdep.c (sys_subshell): Likewise.
9351 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9353 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9354 This should get cleaned up, so that child_setup has the
9355 same signature on all platforms.
9357 * callproc.c (call_process_cleanup): Now static.
9358 (relocate_fd): Rename locals to avoid shadowing.
9360 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9362 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9363 not to be necessary, and produces flickering.
9365 2011-03-20 Glenn Morris <rgm@gnu.org>
9367 * config.in: Remove file.
9369 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9371 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9372 are now in src/globals.h.
9373 (syms_of_minibuf): Remove spurious & from previous change.
9375 2011-03-20 Leo Liu <sdl.web@gmail.com>
9377 * minibuf.c (completing-read-function): New variable.
9378 (completing-read-default): Rename from completing-read.
9379 (completing-read): Call completing-read-function.
9381 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9383 * xfaces.c (Fx_load_color_file):
9384 Read color file from absolute filename (bug#8250).
9386 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9388 * makefile.w32-in: Update dependencies.
9390 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9392 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9394 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9396 Fix more problems found by GCC 4.5.2's static checks.
9398 * process.c (make_serial_process_unwind, send_process_trap):
9399 (sigchld_handler): Now static.
9401 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9402 That way, the code declares only the vars that it needs.
9403 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9404 * s/cygwin.h (PTY_ITERATION): Likewise.
9405 * s/darwin.h (PTY_ITERATION): Likewise.
9406 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9408 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9409 * process.c (allocate_pty): Don't declare stb unless it's needed.
9411 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9412 (CONSTANTLIM): Remove; unused.
9413 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9414 Define only if needed.
9416 * unexelf.c (unexec): Name an expression,
9417 to avoid gcc -Wbad-function-cast warning.
9418 Use a different way to cause a compilation error if anyone uses
9419 n rather than nn, a way that does not involve shadowing.
9420 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9422 * deps.mk (unexalpha.o): Remove; unused.
9424 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9425 * unexec.h: New file.
9426 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9427 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9429 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9430 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9431 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9432 Change as necessary to match prototype in unexec.h.
9434 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9436 (back_comment, skip_chars): Mark vars as initialized.
9438 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9439 Rename locals to avoid shadowing.
9441 * lread.c (read1): Rewrite so as not to use empty "else".
9442 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9444 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9446 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9447 warning when compiling print.c.
9449 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9450 instead of using an uninitialized var.
9451 (font_sort_entities): Mark var as initialized.
9453 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9455 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9456 pointers to constants.
9457 (font_parse_fcname): Remove unused vars.
9458 (font_delete_unmatched): Now static.
9459 (font_get_spec): Remove; unused.
9460 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9461 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9462 Rename or move locals to avoid shadowing.
9464 * fns.c (require_nesting_list, require_unwind): Now static.
9465 (Ffillarray): Rename locals to avoid shadowing.
9467 * floatfns.c (domain_error2): Define only if needed.
9468 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9470 * alloc.c (mark_backtrace): Move decl from here ...
9471 * lisp.h: ... to here, so that it can be checked.
9473 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9474 (Fdefvar): Rewrite so as not to use empty "else".
9475 (lisp_indirect_variable): Name an expression,
9476 to avoid gcc -Wbad-function-cast warning.
9477 (Fdefvar): Rename locals to avoid shadowing.
9479 * callint.c (quotify_arg, quotify_args): Now static.
9480 (Fcall_interactively): Rename locals to avoid shadowing.
9481 Use const pointer when appropriate.
9483 * lisp.h (get_system_name, get_operating_system_release):
9484 Move decls here, to check interfaces.
9485 * process.c (get_operating_system_release): Move decl to lisp.h.
9486 * xrdb.c (get_system_name): Likewise.
9487 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9488 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9489 some of which prompt warnings from gcc -Wbad-function-cast.
9490 (Fformat_time_string, Fencode_time, Finsert_char):
9491 (Ftranslate_region_internal, Fformat):
9492 Rename or remove local vars to avoid shadowing.
9493 (Ftranslate_region_internal): Mark var as initialized.
9495 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9498 * lisp.h (eassert): Check that the argument compiles, even if
9499 ENABLE_CHECKING is not defined.
9501 * data.c (Findirect_variable): Name an expression, to avoid
9502 gcc -Wbad-function-cast warning.
9503 (default_value, arithcompare, arith_driver, arith_error): Now static.
9504 (store_symval_forwarding): Rename local to avoid shadowing.
9505 (Fmake_variable_buffer_local, Fmake_local_variable):
9506 Mark variables as initialized.
9507 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9509 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9510 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9511 Rename locals to avoid shadowing.
9512 (mark_stack): Move local variables into the #ifdef region where
9514 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9515 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9517 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9518 (GC_STRING_CHARS): Remove; not used.
9519 (Fmemory_limit): Cast sbrk's returned value to char *.
9521 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9522 avoids undefined behavior in theory.
9524 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9526 Use functions, not macros, for up- and down-casing (Bug#8254).
9527 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9528 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9529 to use the following functions instead of these macros.
9530 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9531 EMACS_INT, since callers assume the returned value fits in int.
9532 (upcase1): Likewise, for UPCASE_TABLE.
9533 (uppercasep, lowercasep, upcase): New static inline functions.
9534 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9535 the race-condition problem in the old DOWNCASE.
9537 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9538 Rename locals to avoid shadowing.
9539 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9540 (regex_compile, re_search_2, re_match_2_internal):
9541 Remove unused local vars.
9542 (FREE_VAR): Rewrite so as not to use empty "else",
9543 which gcc can warn about.
9544 (regex_compile, re_match_2_internal): Mark locals as initialized.
9545 (RETALLOC_IF): Define only if needed.
9546 (WORDCHAR_P): Likewise. This one is never needed, but is used
9547 only in a comment talking about a compiler bug, so put inside
9548 the #if 0 of that comment.
9549 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9550 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9553 * search.c (boyer_moore): Rename locals to avoid shadowing.
9554 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9555 (PREV_CHAR_BOUNDARY): Likewise.
9557 * search.c (simple_search): Remove unused var.
9559 * dired.c (compile_pattern): Move decl from here ...
9560 * lisp.h: ... to here, so that it can be checked.
9561 (struct re_registers): New forward decl.
9563 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9565 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9567 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9568 Rename locals to avoid shadowing.
9569 (Fvertical_motion): Mark locals as initialized.
9571 * casefiddle.c (casify_object, casify_region): Now static.
9572 (casify_region): Mark local as initialized.
9574 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9576 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9577 New macros, so that the caller can use some names other than
9578 gcpro1, gcpro2, etc.
9579 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9581 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9582 argument, for consistency with GCPRO2_VAR, etc: it is now the
9583 prefix of the variable, not the variable itself. All uses
9585 * dired.c (directory_files_internal, file_name_completion):
9586 Rename locals to avoid shadowing.
9588 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9589 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9590 dired.c's scmp function, had undefined behavior.
9591 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9592 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9593 * buffer.h: ... to here, because these macros use current_buffer,
9594 and the new implementation with inline functions needs to have
9595 current_buffer in scope now, rather than later when the macros
9597 (downcase, upcase1): New static inline functions.
9598 (DOWNCASE, UPCASE1): Reimplement using these functions.
9599 This avoids undefined behavior in expressions like
9600 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9601 from race conditions in accessing the global variables
9602 case_temp1 and case_temp2.
9603 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9604 * lisp.h (case_temp1, case_temp2): Remove their decls.
9605 * character.h (ASCII_CHAR_P): Move from here ...
9606 * lisp.h: ... to here, so that the inline functions mentioned
9609 * dired.c (directory_files_internal_unwind): Now static.
9611 * fileio.c (file_name_as_directory, directory_file_name):
9612 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9614 (file_name_as_directory): Use const pointers when appropriate.
9615 (Fexpand_file_name): Likewise. In particular, newdir might
9616 point at constant storage, so make it a const pointer.
9617 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9618 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9620 (Fset_file_times, Finsert_file_contents, auto_save_error):
9621 Rename locals to avoid shadowing.
9623 * minibuf.c (choose_minibuf_frame_1): Now static.
9624 (Ftry_completion, Fall_completions): Rename or remove locals
9627 * marker.c (bytepos_to_charpos): Remove; unused.
9629 * lisp.h (verify_bytepos, count_markers): New decls,
9630 so that gcc does not warn that these functions aren't declared.
9632 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9633 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9634 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9635 (copy_text): Remove unused local var.
9637 * filelock.c (within_one_second): Now static.
9638 (lock_file_1): Rename local to avoid shadowing.
9640 * buffer.c (fix_overlays_before): Mark locals as initialized.
9641 (fix_start_end_in_overlays): Likewise. This function should be
9642 simplified by using pointers-to-pointers, but that's a different
9644 (switch_to_buffer_1): Now static.
9645 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9646 (report_overlay_modification): Rename locals to avoid shadowing.
9648 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9649 Fix pointer signedness issue.
9650 (sys_subshell): Mark local as volatile if checking for lint,
9651 to suppress a gcc -Wclobbered warning that does not seem to be right.
9652 (MAXPATHLEN): Define only if needed.
9654 * process.c (serial_open, serial_configure): Move decls from here ...
9655 * systty.h: ... to here, so that they can be checked.
9657 * fns.c (get_random, seed_random): Move extern decls from here ...
9658 * lisp.h: ... to here, so that they can be checked.
9660 * sysdep.c (reset_io): Now static.
9661 (wait_for_termination_signal): Remove; unused.
9663 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9664 (copy_keymap_item, append_key, push_text_char_description):
9666 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9667 (DENSE_TABLE_SIZE): Remove; unused.
9668 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9669 (describe_map_tree):
9670 Rename locals to avoid shadowing.
9672 * keyboard.c: Declare functions static if they are not used elsewhere.
9673 (echo_char, echo_dash, cmd_error, top_level_2):
9674 (poll_for_input, handle_async_input): Now static.
9675 (read_char, kbd_buffer_get_event, make_lispy_position):
9676 (make_lispy_event, make_lispy_movement, apply_modifiers):
9677 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9678 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9679 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9680 (read_key_sequence, read_char): Mark locals as initialized.
9681 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9683 * keyboard.h (make_ctrl_char): New decl.
9684 (mark_kboards): Move decl here ...
9685 * alloc.c (mark_kboards): ... from here.
9687 * lisp.h (force_auto_save_soon): New decl.
9689 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9690 (DEFINE_DUMMY_FUNCTION): New macro.
9691 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9693 (main): Add casts to avoid warnings
9694 if GCC considers string literals to be constants.
9696 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9698 * dbusbind.c: Pointer signedness fixes.
9699 (xd_signature, xd_append_arg, xd_initialize):
9700 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9701 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9702 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9703 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9705 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9706 if GCC considers string literals to be constants.
9707 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9709 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9711 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9712 (print_preprocess, print_object): New macro to fix last change.
9714 * print.c (print_preprocess): Don't forget font objects.
9716 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9718 * emacs.c (USAGE3): Doc fixes.
9720 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9722 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9725 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9727 * lisp.h (VWindow_system, Qfile_name_history):
9728 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9729 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9730 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9732 * w32select.c: Don't #include "keyboard.h".
9733 (run_protected): Add extern declaration for waiting_for_input.
9735 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9736 * w32console.c (detect_input_pending, read_input_pending)
9737 (encode_terminal_code):
9738 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9739 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9740 (w32_system_caret_y, Qfile_name_history):
9741 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9742 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9743 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9744 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9745 * w32proc.c (Qlocal, report_file_error):
9746 * w32term.c (Vwindow_system, updating_frame):
9747 * w32uniscribe.c (initialized, uniscribe_font_driver):
9748 Remove unneeded extern declarations.
9750 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9752 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9754 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9756 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9757 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9758 These macros can no longer be used for assignment.
9760 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9761 Assign struct members directly, instead of using BUF_BEGV etc.
9762 (record_buffer_markers, fetch_buffer_markers): New functions for
9763 recording and fetching special buffer markers.
9764 (set_buffer_internal_1, set_buffer_temp): Use them.
9766 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9768 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9770 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9771 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9773 * xdisp.c (hscroll_window_tree):
9774 (reconsider_clip_changes): Use PT instead of BUF_PT.
9776 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9778 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9779 $(EMACS_ROOT)/lib/intprops.h.
9781 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9783 Fix more problems found by GCC 4.5.2's static checks.
9785 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9786 to unsigned char * to avoid compiler diagnostic.
9787 (xg_free_frame_widgets): Make it clear that a local variable is
9788 needed only if USE_GTK_TOOLTIP.
9789 (gdk_window_get_screen): Make it clear that this macro is needed
9790 only if USE_GTK_TOOLTIP.
9791 (int_gtk_range_get_value): New function, which avoids a diagnostic
9792 from gcc -Wbad-function-cast.
9793 (xg_set_toolkit_scroll_bar_thumb): Use it.
9794 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9795 diagnostic from gcc -Wbad-function-cast.
9796 (get_utf8_string, xg_get_file_with_chooser):
9797 Rename locals to avoid shadowing.
9798 (create_dialog): Move locals to avoid shadowing.
9800 * xgselect.c (xg_select): Remove unused var.
9802 * image.c (four_corners_best): Mark locals as initialized.
9803 (gif_load): Initialize transparent_p to zero (Bug#8238).
9804 Mark another local as initialized.
9805 (my_png_error, my_error_exit): Mark with NO_RETURN.
9807 * image.c (clear_image_cache): Now static.
9808 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9809 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9810 (x_edge_detection): Remove unnecessary cast that
9811 gcc -Wbad-function-cast diagnoses.
9812 (gif_load): Fix pointer signedness.
9813 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9814 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9816 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9818 Improve quality of tests for time stamp overflow.
9819 For example, without this patch (encode-time 0 0 0 1 1
9820 1152921504606846976) returns the obviously-bogus value (-948597
9821 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9822 reports time overflow. See
9823 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9824 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9825 * editfns.c: Include limits.h and intprops.h.
9826 (TIME_T_MIN, TIME_T_MAX): New macros.
9827 (time_overflow): Move earlier, to before first use.
9828 (hi_time, lo_time): New functions, for an accurate test for
9830 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9831 (Fget_internal_run_time): Don't assume time_t fits in int.
9832 (make_time): Use list2 instead of Fcons twice.
9833 (Fdecode_time): More accurate test for out-of-range times.
9834 (check_tm_member): New function.
9835 (Fencode_time): Use it, to test for out-of-range times.
9836 (lisp_time_argument): Don't rely on undefined left-shift and
9837 right-shift behavior when checking for time stamp overflow.
9839 * editfns.c (time_overflow): New function, refactoring common code.
9840 (Fformat_time_string, Fdecode_time, Fencode_time):
9841 (Fcurrent_time_string): Use it.
9843 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9844 * dired.c (make_time): Move to ...
9845 * editfns.c (make_time): ... here.
9846 * systime.h: Note the move.
9848 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9850 * fringe.c (update_window_fringes): Remove unused variables.
9852 * unexmacosx.c (copy_data_segment): Also copy __got section.
9855 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9857 * termcap.c [MSDOS]: Include "msdos.h".
9858 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9859 Constify `char *' arguments and their references according to
9860 prototypes in tparam.h.
9862 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9864 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9865 Adapt all references accordingly.
9867 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9869 2011-03-11 Tom Tromey <tromey@redhat.com>
9871 * buffer.c (syms_of_buffer): Remove obsolete comment.
9873 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9875 * termhooks.h (encode_terminal_code): Declare prototype.
9877 * msdos.c (encode_terminal_code): Don't declare prototype.
9879 * term.c (encode_terminal_code): Now external again, used by
9880 w32console.c and msdos.c.
9882 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9883 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9885 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9887 Fix some minor problems found by GCC 4.5.2's static checks.
9889 * fringe.c (update_window_fringes): Mark locals as initialized
9891 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9893 * alloc.c (mark_fringe_data): Move decl from here ...
9894 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9895 to check its interface.
9896 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9898 * fontset.c (free_realized_fontset): Now static.
9899 (Fset_fontset_font): Rename local to avoid shadowing.
9900 (fontset_font): Mark local as initialized.
9901 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9903 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9905 * xselect.c (x_disown_buffer_selections): Remove; not used.
9906 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9907 (x_own_selection, Fx_disown_selection_internal): Rename locals
9909 (x_handle_dnd_message): Remove local to avoid shadowing.
9911 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9912 so that the caller can use some name other than gcpro1.
9913 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9914 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9915 (Fx_backspace_delete_keys_p):
9916 Use them to avoid shadowing, and rename vars to avoid shadowing.
9917 (x_decode_color, x_set_name, x_window): Now static.
9918 (Fx_create_frame): Add braces to silence GCC warning.
9919 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9920 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9921 Remove unused locals.
9922 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9923 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9924 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9927 * xterm.h (x_mouse_leave): New decl.
9929 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9930 Remove unused functions.
9931 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9932 (x_calc_absolute_position): Now static.
9933 (XTread_socket): Don't define label "out" unless it's used.
9934 Don't declare local "event" unless it's used.
9935 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9936 unless they are used.
9937 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9938 (x_fatal_error_signal): Remove; not used.
9939 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9940 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9941 (x_error_catcher, x_connection_closed, x_error_handler):
9942 (x_error_quitter, xembed_send_message, x_iconify_frame):
9943 (my_log_handler): Rename locals to avoid shadowing.
9944 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9945 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9947 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9948 Rename or move locals to avoid shadowing.
9949 (tty_defined_color, merge_face_heights): Now static.
9950 (free_realized_faces_for_fontset): Remove; not used.
9951 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9952 does not deduce is never used uninitialized.
9953 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9954 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9956 * terminal.c (store_terminal_param): Now static.
9958 * xmenu.c (menu_highlight_callback): Now static.
9959 (set_frame_menubar): Remove unused local.
9960 (xmenu_show): Rename parameter to avoid shadowing.
9961 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9962 since they might point to immutable storage.
9963 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9964 since it's unused otherwise.
9966 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9967 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9968 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9969 avoids a gcc -Wuninitialized diagnostic.
9970 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9971 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9972 does not deduce are never used uninitialized.
9974 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9976 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9977 * window.c (window_loop, size_window):
9978 (run_window_configuration_change_hook, enlarge_window): Likewise.
9980 * window.c (display_buffer): Now static.
9981 (size_window): Mark variables that gcc -Wuninitialized
9982 does not deduce are never used uninitialized.
9983 * window.h (check_all_windows): New decl, to forestall
9984 gcc -Wmissing-prototypes diagnostic.
9985 * dispextern.h (bidi_dump_cached_states): Likewise.
9987 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9989 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9991 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9992 and to avoid gcc -Wuninitialized warning.
9993 (load_charset_map): Mark variables that gcc -Wuninitialized
9994 does not deduce are never used uninitialized.
9995 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9997 * coding.c (coding_set_source, coding_set_destination):
9998 Use "else { /* comment */ }" rather than "else /* comment */;"
9999 for clarity, and to avoid gcc -Wempty-body warning.
10000 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10001 a block, when the outer 'i' will do.
10002 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10003 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10004 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10005 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10006 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10007 Rename locals to avoid shadowing.
10008 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10009 * coding.c (emacs_mule_char, encode_invocation_designation):
10010 Now static, since they're not used elsewhere.
10011 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10012 (decode_coding_object, encode_coding_object, detect_coding_system):
10013 (decode_coding_emacs_mule): Mark variables that gcc
10014 -Wuninitialized does not deduce are never used uninitialized.
10015 (detect_coding_iso_2022): Initialize a local variable that might
10016 be used uninitialized. Leave a FIXME because it's not clear that
10017 this initialization is needed. (Bug#8211)
10018 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10019 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10020 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10021 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10022 Remove unused macros.
10024 * category.c (hash_get_category_set): Remove unused local var.
10025 (copy_category_table): Now static, since it's not used elsewhere.
10026 * character.c (string_count_byte8): Likewise.
10028 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10029 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10031 * chartab.c (copy_sub_char_table): Now static, since it's not used
10033 (sub_char_table_ref_and_range, char_table_ref_and_range):
10034 Rename locals to avoid shadowing.
10035 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10037 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10038 (BIDI_BOB): Remove unused macro.
10040 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10041 deduce are never used uninitialized.
10042 * term.c (encode_terminal_code): Likewise.
10044 * term.c (encode_terminal_code): Now static. Remove unused local.
10046 * tparam.h: New file.
10047 * term.c, tparam.h: Include it.
10048 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10049 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10050 Move these decls to tparam.h, and make them agree with what
10051 is actually in tparam.c. The previous trick of using incompatible
10052 decls in different modules does not conform to the C standard.
10053 All callers of tparam changed to use tparam's actual API.
10054 * tparam.c (tparam1, tparam, tgoto):
10055 Use const pointers where appropriate.
10057 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10058 * cm.h (struct cm): Likewise.
10059 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10060 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10061 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10062 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10063 (turn_on_face, init_tty): Likewise.
10064 * termchar.h (struct tty_display_info): Likewise.
10066 * term.c (term_mouse_position): Rename local to avoid shadowing.
10068 * alloc.c (mark_ttys): Move decl from here ...
10069 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10071 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10073 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10075 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10077 * search.c (compile_pattern_1): Remove argument regp, unused since
10078 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10079 (compile_pattern): Don't pass it.
10081 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10083 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10084 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10086 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10088 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10090 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10091 gdk_window_get_screen, gdk_window_get_geometry,
10092 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10093 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10094 (xg_get_pixbuf_from_pixmap): New function.
10095 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10096 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10097 Call xg_get_pixbuf_from_pixmap instead of
10098 gdk_pixbuf_get_from_drawable.
10099 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10100 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10101 (xg_check_special_colors): Use GtkStyleContext and its functions
10103 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10104 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10105 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10106 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10107 Call gtk_widget_get_preferred_size.
10108 (xg_frame_resized): gdk_window_get_geometry only takes 5
10110 (xg_win_to_widget, xg_event_is_for_menubar):
10111 Call gdk_x11_window_lookup_for_display.
10112 (xg_set_widget_bg): New function.
10113 (delete_cb): New function.
10114 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10115 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10116 (xg_set_background_color): Call xg_set_widget_bg.
10117 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10118 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10119 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10120 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10122 (update_frame_tool_bar): Call gtk_widget_hide.
10123 (xg_initialize): Use GDK_KEY_g.
10125 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10127 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10129 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10130 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10131 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10133 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10135 * w32xfns.c (select_palette): Check success of RealizePalette against
10136 GDI_ERROR, not zero.
10138 See ChangeLog.11 for earlier changes.
10140 ;; Local Variables:
10144 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10146 This file is part of GNU Emacs.
10148 GNU Emacs is free software: you can redistribute it and/or modify
10149 it under the terms of the GNU General Public License as published by
10150 the Free Software Foundation, either version 3 of the License, or
10151 (at your option) any later version.
10153 GNU Emacs is distributed in the hope that it will be useful,
10154 but WITHOUT ANY WARRANTY; without even the implied warranty of
10155 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10156 GNU General Public License for more details.
10158 You should have received a copy of the GNU General Public License
10159 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.