1 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7 2011-11-07 Martin Rudalics <rudalics@gmx.at>
9 * window.h: Declare delete_all_child_windows instead of
10 delete_all_subwindows.
11 * window.c (Fwindow_nest, Fset_window_nest)
12 (Fset_window_new_total, Fset_window_new_normal)
13 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
14 (delete_all_subwindows): Rename to delete_all_child_windows.
15 (Fdelete_other_windows_internal, Fset_window_configuration):
16 Call delete_all_child_windows instead of delete_all_subwindows.
17 * frame.c (delete_frame): Call delete_all_child_windows instead
18 of delete_all_subwindows.
20 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
22 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
23 This is also needed for porting to any host where GC_MARK_STACK is
24 not GC_MAKE_GCPROS_NOOPS.
25 (which_symbols): Use it.
27 2011-11-07 Kenichi Handa <handa@m17n.org>
29 * coding.c (coding_set_destination): Check coding->src_pos only
30 when coding->src_object is a buffer (bug#9910).
32 * process.c (send_process): Set the member src_multibyte of coding
33 to 0 (bug#9911) when sending a unibyte text.
35 * callproc.c (Fcall_process): Set the member src_multibyte of
36 process_coding to 0 (bug#9912).
38 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
40 * xmenu.c (cleanup_widget_value_tree): New function.
41 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
42 calling free_menubar_widget_value_tree directly (Bug#9830).
44 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
46 Fix some portability problems with 'inline'.
47 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
48 (window_box_width, window_box_left, window_box_left_offset)
49 (window_box_right, window_box_right_offset): Declare extern.
50 Otherwise, these inline functions do not conform to C99 and
51 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
52 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
53 * intervals.c (adjust_intervals_for_insertion)
54 (adjust_intervals_for_deletion): Now extern, because otherwise the
55 extern inline functions 'offset_intervals' couldn't refer to it.
56 (static_offset_intervals): Remove.
57 (offset_intervals): Rewrite using the old contents of
58 static_offset_intervals. The old version didn't conform to C99
59 because an extern inline function contained a reference to an
60 identifier with static linkage.
62 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
64 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
67 2011-11-06 Eli Zaretskii <eliz@gnu.org>
69 * xdisp.c (init_iterator, reseat_to_string): Don't set the
70 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
71 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
72 return Qleft_to_right.
74 2011-11-06 Chong Yidong <cyd@gnu.org>
76 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
77 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
78 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
79 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
80 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
81 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
82 (Fwindow_vscroll): Doc fix.
83 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
84 argument, since it makes no sense to pass a live window and for
85 consistency with window-child.
87 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
89 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
92 2011-11-05 Jason Rumney <jasonr@gnu.org>
94 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
95 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
97 (add_font_entity_to_list): Fix logic errors in mixed boolean and
98 bitwise arithmetic preventing use of unicode-sip and non-truetype
101 2011-11-05 Eli Zaretskii <eliz@gnu.org>
103 * s/ms-w32.h (fstat, stat, utime): Move redirections to
106 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
107 initialization code to keep similarity to xfns.c after changes
110 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
112 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
113 (unwind_create_frame): New function (Bug#9943).
114 (Fx_create_frame): Restructure code to be more similar to the one in
115 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
116 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
117 Move terminal->reference_count++ just before making the frame official
120 * nsterm.m (x_free_frame_resources): New function.
121 (x_destroy_window): Move code to x_free_frame_resources.
123 * xfns.c (unwind_create_frame): Fix comment.
124 (Fx_create_frame, x_create_tip_frame): Move
125 terminal->reference_count++ just before making the frame
126 official. Move initialization of image_cache_refcount and
127 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
129 2011-11-05 Eli Zaretskii <eliz@gnu.org>
131 Support MSVC build with newer versions of Visual Studio.
132 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
133 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
136 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
137 which are not supported by MSVC.
138 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
139 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
141 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
143 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
145 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
147 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
149 Support MSVC build with newer versions of Visual Studio.
150 * w32.c: Don't include w32api.h for MSVC.
151 (init_environment) [_MSC_VER]: Call sys_access, not _access.
153 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
154 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
155 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
156 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
158 (alloca) [_MSC_VER]: Define to _alloca.
160 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
162 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
164 2011-11-04 Eli Zaretskii <eliz@gnu.org>
166 * xdisp.c (note_mouse_highlight): If either of
167 previous/next-single-property-change returns nil, treat that as
168 the beginning or the end of the buffer. (Bug#9955)
170 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
172 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
173 label is not null (Bug#9951).
174 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
177 2011-11-04 Eli Zaretskii <eliz@gnu.org>
179 * window.c (Fwindow_body_size): Mention in the doc string that the
180 return value is in frame's canonical units. (Bug#9949)
182 2011-11-03 Eli Zaretskii <eliz@gnu.org>
184 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
186 * w32fns.c (unwind_create_frame): If needed, free the glyph
187 matrices of the partially constructed frame. (Bug#9943)
188 * xfns.c (unwind_create_frame): Likewise.
190 2011-11-01 Eli Zaretskii <eliz@gnu.org>
192 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
193 Don't stop backward scan on the continuation glyph, even though
194 its CHARPOS is positive.
195 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
196 cover_string to disp_string.
198 2011-11-01 Martin Rudalics <rudalics@gmx.at>
200 * window.c (temp_output_buffer_show): Don't use
201 Vtemp_buffer_show_specifiers.
202 (Vtemp_buffer_show_specifiers): Remove unused variable.
204 2011-10-30 Eli Zaretskii <eliz@gnu.org>
206 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
207 past the beginning of the current glyph matrix.
209 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
211 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
212 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
213 HAVE_GTK3 (Bug#9869).
215 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
216 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
218 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
220 * xterm.c: Declare x_handle_net_wm_state to return int.
221 (handle_one_xevent): Check if we are iconified but don't have
222 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
223 (get_current_wm_state): Return non-zero if not hidden,
224 check for _NET_WM_STATE_HIDDEN (Bug#9893).
225 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
226 (x_handle_net_wm_state): Return what get_current_wm_state returns.
227 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
229 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
231 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
232 so that this new function doesn't get optimized away by a
233 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
235 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
237 * frame.h (MOUSE_HL_INFO): Remove excess parens.
239 2011-10-29 Eli Zaretskii <eliz@gnu.org>
241 Fix the `xbytecode' command.
242 * .gdbinit (xprintbytestr): New command.
243 (xwhichsymbols): Renamed from `which'; all callers changed.
244 (xbytecode): Print the byte-code string as well.
246 2011-10-29 Kim Storm <storm@cua.dk>
248 * alloc.c (which_symbols): New function.
250 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
252 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
255 2011-10-29 Glenn Morris <rgm@gnu.org>
257 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
258 Not clear what it was for, and it causes various bugs. (Bug#9839)
260 2011-10-28 Eli Zaretskii <eliz@gnu.org>
262 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
263 possible random value that matches one of those tested as
264 condition to clear the mouse face.
266 2011-10-28 Chong Yidong <cyd@gnu.org>
268 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
270 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
272 * window.c (make_window): Initialize phys_cursor_on_p.
274 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
276 * lisp.h (struct Lisp_Symbol): Update comments.
278 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
280 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
282 2011-10-28 Eli Zaretskii <eliz@gnu.org>
284 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
285 <oslsachem@gmail.com> for helping to debug this.
287 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
288 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
289 (g_b_init_get_glyph_outline_w): New static variables.
290 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
291 (GetGlyphOutlineW_Proc): New typedefs.
292 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
293 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
295 (w32font_open_internal, compute_metrics):
296 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
297 instead of calling the "wide" APIs directly.
299 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
301 * w32.h (syms_of_w32font): Add prototype.
303 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
305 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
306 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
307 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
308 (Fmove_to_window_line): Doc fix.
310 2011-10-27 Chong Yidong <cyd@gnu.org>
312 * process.c (make_process): Set gnutls_state to NULL.
314 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
315 non-NULL, regardless of GNUTLS_INITSTAGE.
316 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
317 an error. Set process slots as soon as we allocate them.
319 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
321 2011-10-27 Chong Yidong <cyd@gnu.org>
323 * gnutls.c (emacs_gnutls_deinit): New function.
324 Deallocate credentials structures as well as calling gnutls_deinit.
325 (Fgnutls_deinit, Fgnutls_boot): Use it.
327 * process.c (make_process): Initialize GnuTLS credentials to NULL.
328 (deactivate_process): Call emacs_gnutls_deinit.
330 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
332 * image.c (x_create_x_image_and_pixmap):
333 * w32.c (sys_rename, w32_delayed_load):
334 * w32font.c (fill_in_logfont):
335 * w32reg.c (x_get_string_resource): Silence compiler warnings.
337 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
339 * w32fns.c (w32_default_color_map): New function,
340 extracted from Fw32_default_color_map.
341 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
343 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
345 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
347 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
349 * keyboard.c (test_undefined): New function (bug#9751).
350 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
352 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
354 * sysdep.c (init_sys_modes): Fix the check for the controlling
357 2011-10-20 Eli Zaretskii <eliz@gnu.org>
359 * dispextern.h (struct bidi_it): New member next_en_type.
361 * bidi.c (bidi_line_init): Initialize the next_en_type member.
362 (bidi_resolve_explicit_1): When next_en_pos is valid for the
363 current character, check also for next_en_type being WEAK_EN.
364 (bidi_resolve_weak): Don't enter the expensive loop if the current
365 position is before next_en_pos. Record the bidi type of the first
366 non-ET, non-BN character we find, in addition to its position.
367 (bidi_level_of_next_char): Invalidate next_en_type when
368 next_en_pos is over-stepped.
370 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
372 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
373 * editfns.c: Rewrite current-time-zone so that it invokes
374 the equivalent of (format-time-string "%Z") to get the time zone name.
375 This fixes a bug when the time zone name contains characters that
376 need converting from the system time locale to Emacs internal format.
377 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
378 that patch fixed format-time-string to do the conversion, but
379 I forgot to fix current-time-zone.
380 (format_time_string): New function, containing most of
381 what Fformat_time_string used to contain.
382 (Fformat_time_string): Rewrite in terms of format_time_string.
383 This doesn't change this function's behavior.
384 (current-time-zone): Rewrite to use format_time_string.
385 This fixes the bug reported by Michael Schierl in
386 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
387 Jason Rumney's 2007-06-07 change worked around this bug, but
389 * systime.h (tzname, timezone): Remove no-longer-used declarations.
391 2011-10-19 Eli Zaretskii <eliz@gnu.org>
393 * xdisp.c (start_display): If the character at POS is displayed
394 via a display vector, reset IT->current.dpvec_index to zero.
395 (try_window_reusing_current_matrix): If a line ends in a display
396 vector or the next line starts in a display vector, continue
397 redrawing the window even though the character position of
398 start_row was reached.
401 2011-10-18 Chong Yidong <cyd@gnu.org>
403 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
404 with nobreak-char-display too.
406 2011-10-18 Eli Zaretskii <eliz@gnu.org>
408 Fix part 3 of bug#9771.
409 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
410 (bidi_resolve_neutral): Don't enter the expensive loop looking for
411 non-neutral characters if the current character is a paragraph
412 separator (a.k.a. Newline). This avoids running the same
413 expensive loop twice, once when we consume the preceding newline
414 and the other time when the line actually needs to be displayed.
415 Avoid the loop when we see neutrals on the base embedding level
416 following a character whose directionality is the same as the
417 paragraph's. This avoids running the expensive loop when a line
418 ends in a long sequence of neutrals, like control characters.
419 Add assertion against STRONG_AL type. Slightly rearrange code
420 that determines the type of a neutral given the first non-neutral
422 (bidi_level_of_next_char): Set next_en_pos to zero when
423 invalidating its info.
425 2011-10-17 Eli Zaretskii <eliz@gnu.org>
427 * xdisp.c (push_display_prop): Determine whether to record string
428 or buffer position by IT->string, not by IT->method. Allow
429 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
430 (move_it_vertically_backward): Don't look for character position
431 immediately after the newline when in a continuation line.
434 2011-10-15 Martin Rudalics <rudalics@gmx.at>
436 * window.c (coordinates_in_window): Rewrite and delabelize
437 vertical border check. (Bug#5357) (Bug#9618)
439 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
441 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
442 errors in XSetWindowBorder (bug#9310).
444 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
446 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
447 avoid crash when xmalloc overrun checking is enabled.
449 2011-10-13 Eli Zaretskii <eliz@gnu.org>
451 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
452 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
453 cursor motion with <left> and <right> arrow keys.
455 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
456 some callers set that themselves.
458 2011-10-12 Eli Zaretskii <eliz@gnu.org>
460 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
461 display string and the previous row comes from the same string and
462 is empty. (Bug#9739) (Bug#9738)
464 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
466 * doc.c (get_doc_string): Encode file name (bug#9735).
468 2011-10-12 Eli Zaretskii <eliz@gnu.org>
470 * bidi.c (bidi_level_of_next_char):
471 * xdisp.c (get_visually_first_element): Remove old incorrect
472 comments regarding the Unicode Line Separator character.
474 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
476 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
478 * alloc.c (Fgc_status): Do not access beyond zombies array
479 boundary if nzombies > MAX_ZOMBIES.
480 * alloc.c (dump_zombies): Add missing format specifier.
482 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
484 * xdisp.c (set_cursor_from_row): Simplify conditionals,
485 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
487 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
488 Some packages use them to denote characters with modifiers.
490 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
492 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
493 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
494 matching a pp-number. Rename parameter var to var1.
496 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
498 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
500 2011-10-08 Glenn Morris <rgm@gnu.org>
502 * callint.c (Fcall_interactively): Give a more explicit error for the
503 'c' case with a non-character input. (Bug#8479)
505 2011-10-08 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
509 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
510 lines that are hscrolled on the left.
512 * dispnew.c (buffer_posn_from_coords): Account for a possible
513 presence of header-line. (Bug#4426)
515 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
517 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
518 Don't advertise functionality which we discourage or doesn't work.
520 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
522 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
523 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
524 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
525 this makes Emacs dump core during garbage collection on rare
526 occasions. sizeof is obviously inferior to offsetof here, so
528 (GC_POINTER_ALIGNMENT): New macro.
529 (mark_memory): Omit 3rd (offset) arg; caller changed.
530 Don't assume EMACS_INT alignment is the same as pointer alignment.
532 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
534 * keyboard.c (read_key_sequence_remapped): New var.
535 (read_key_sequence): Compute remapping in the right buffer.
536 (command_loop_1): Use read_key_sequence's remapping directly.
538 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
540 * dired.c (file_name_completion): Don't expand file name.
541 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
542 before checking file name handler.
544 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
545 they've been requested explicitly (bug#9591).
547 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
549 * keymap.c (Fsingle_key_description): Use make_specified_string
550 instead of build_string to build string from push_key_description.
553 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
555 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
556 This fixes a Y2038 bug on 64-bit hosts.
557 * buffer.c (reset_buffer):
558 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
559 (Fclear_buffer_auto_save_failure):
560 Use 0, not -1, to represent an unset failure time, since time_t
563 Remove dependency on glibc malloc internals.
564 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
565 Move back here from lisp.h, but with their new implementations.
566 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
567 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
568 * charset.c (charset_table_init): New static var.
569 (syms_of_charset): Use it instead of xmalloc. This removes a
570 dependency on glibc malloc internals. See Eli Zaretskii's comment in
571 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
572 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
573 Move back to alloc.c.
574 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
575 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
577 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
579 * nsterm.m (windowDidResize): Call x_set_window_size only when
580 ns_in_resize is true. Otherwise set pixelwidth/height and
581 call change_frame_size (Bug#9628).
583 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
585 Port --enable-checking=all to Fedora 14 x86-64.
586 * charset.c (syms_of_charset): Also account for glibc malloc's
587 internal overhead when calculating the initial malloc maximum.
589 Port --enable-checking=all to Fedora 14 x86.
590 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
592 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
593 (overrun_check_realloc, overrun_check_free):
594 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
595 That way, xmalloc returns a properly-aligned pointer even if
596 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
597 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
598 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
599 into account when calculating the initial malloc maximum.
600 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
601 Move here from alloc.c, so that charset.c can use it too.
602 Properly align; the old code wasn't right for common 32-bit hosts
603 when configured with --enable-checking=all.
604 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
605 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
607 2011-09-29 Eli Zaretskii <eliz@gnu.org>
609 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
612 2011-09-28 Eli Zaretskii <eliz@gnu.org>
614 * xdisp.c (compute_display_string_end): If there's no display
615 string at CHARPOS, return -1.
617 * bidi.c (bidi_fetch_char): When compute_display_string_end
618 returns a negative value, treat the character as a normal
619 character not covered by a display string. (Bug#9624)
621 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
623 * lread.c (Fread_from_string): Fix typo in docstring.
625 2011-09-27 Eli Zaretskii <eliz@gnu.org>
627 * xdisp.c (handle_invisible_prop): If invisible text ends on a
628 newline, reseat the iterator instead of bidi-iterating there one
629 character at a time. (Bug#9610)
630 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
631 TO_CHARPOS if the bidi iterator is at base embedding level.
633 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
635 * lread.c (readevalloop): Use correct code for NBSP.
636 (read1): Likewise. (Bug#9608)
638 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
640 * dbusbind.c (Fdbus_register_signal): When service is not
641 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
643 2011-09-25 Glenn Morris <rgm@gnu.org>
645 * buffer.c (truncate-lines): Doc fix.
647 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
649 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
650 (Fset_window_next_buffers): Doc fix.
652 2011-09-24 Glenn Morris <rgm@gnu.org>
654 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
656 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
658 Fix minor problems found by static checking.
659 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
660 * indent.c (Fvertical_motion): Fix == vs = typo.
662 2011-09-24 Eli Zaretskii <eliz@gnu.org>
664 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
665 Default value is now t. Doc fix.
667 * indent.c (Fvertical_motion): Compute and apply the overshoot
668 logic when moving up, not only when moving down. Fix the
669 confusing name and values of the it_overshoot_expected variable;
670 logic changes accordingly. (Bug#9254) (Bug#9549)
672 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
673 CHARPOS is covered by a display string which includes newlines.
674 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
675 is covered by a display string with embedded newlines.
677 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
679 * dbusbind.c (Fdbus_register_signal): Add match rule to
680 Vdbus_registered_objects_table. (Bug#9581)
681 (Fdbus_register_method, Vdbus_registered_objects_table):
684 2011-09-24 Jim Meyering <meyering@redhat.com>
686 do not ignore write error for any output size
687 The previous change was incomplete.
688 While it makes emacs --batch detect the vast majority of stdout
689 write failures, errors were still ignored whenever the output size is
690 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
691 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
692 && echo FAIL: ignored write error
693 FAIL: ignored write error
694 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
695 && echo FAIL: ignored write error
696 FAIL: ignored write error
697 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
699 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
701 * emacs.c (Fkill_emacs): In noninteractive mode exit
702 non-successfully if a write error occurred on stdout. (Bug#9574)
704 2011-09-21 Eli Zaretskii <eliz@gnu.org>
706 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
709 * dispextern.h (struct it): Update the comment documenting what
712 2011-09-20 Eli Zaretskii <eliz@gnu.org>
714 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
715 a display string, extend search for cursor position to end of row.
716 (find_row_edges): If the row ends in a newline from a display
717 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
718 Handle the case of a display string with multiple newlines.
719 (Fcurrent_bidi_paragraph_direction): Fix search for previous
720 non-empty line. Fixes confusing cursor motion with arrow keys at
721 the beginning of a line that starts with whitespace.
723 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
725 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
728 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
730 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
733 2011-09-18 Eli Zaretskii <eliz@gnu.org>
735 * xdisp.c (display_line): Record maximum and minimum buffer
736 positions even if no glyphs were produced (e.g., by a zero-width
737 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
738 buffer positions that will be removed from the glyph row because
740 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
741 column is beyond frame width: don't subtract 1 "pixel" when
742 computing width of the stretch.
743 (reseat_at_next_visible_line_start): Undo the change made on
744 2011-09-17 that saved paragraph information and restored it after
745 the call to `reseat'. (Bug#9545)
747 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
749 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
750 and turn window cursor on if cleared (Bug#9415).
752 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
754 * search.c (boyer_moore): Take unibyte characters from pattern
755 literally. (Bug#9458)
757 2011-09-18 Eli Zaretskii <eliz@gnu.org>
759 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
761 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
763 Fix minor problem found by static checking.
764 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
765 initialized, to pacify gcc -Wuninitialized.
767 * fileio.c: Report proper errno when syscall falls.
768 (Finsert_file_contents): Save and restore errno,
769 so that report_file_error outputs the correct diagnostic.
770 (Fwrite_region) [CLASH_DETECTION]: Likewise.
772 2011-09-18 Eli Zaretskii <eliz@gnu.org>
774 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
776 2011-09-17 Eli Zaretskii <eliz@gnu.org>
778 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
779 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
781 2011-09-17 Eli Zaretskii <eliz@gnu.org>
783 * xdisp.c (reseat_at_next_visible_line_start): Keep information
784 about the current paragraph and restore it after the call to reseat.
786 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
787 (bidi_find_paragraph_start): Search back for paragraph beginning
788 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
789 (bidi_move_to_visually_next): Only trigger paragraph-related
790 computations when the last character is a newline or at EOB, not
791 just any NEUTRAL_B. (Bug#9470)
793 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
794 truncated lines if point is covered by a display string. (Bug#9524)
796 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
798 * xselect.c: Relax test for outgoing X longs (Bug#9498).
799 (cons_to_x_long): New function.
800 (lisp_data_to_selection_data): Use it. Correct the test for
801 short-versus-long data; it was negated. Break out of vector
802 loop, for efficiency, when a long datum is discovered.
804 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
806 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
808 2011-09-16 Eli Zaretskii <eliz@gnu.org>
810 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
811 GCC PR/17406) by declaring this function with external scope.
813 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
815 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
816 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
818 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
820 * editfns.c (Fformat): Correctly handle text properties on "%%".
822 2011-09-15 Eli Zaretskii <eliz@gnu.org>
824 * xterm.c (x_draw_composite_glyph_string_foreground):
825 * w32term.c (x_draw_composite_glyph_string_foreground):
826 * term.c (encode_terminal_code):
827 * composite.c (composition_update_it, get_composition_id):
828 * xdisp.c (get_next_display_element)
829 (fill_composite_glyph_string): Add comments about special meaning
830 of TAB characters in a composition.
832 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
834 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
835 This occurs when processing a multibyte format.
836 Problem reported by Wolfgang Jenker.
838 2011-09-15 Johan Bockgård <bojohan@gnu.org>
840 * xdisp.c (try_cursor_movement): Only check for exact match if
841 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
843 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
845 Remove unused external symbols.
846 * dispextern.h (calc_pixel_width_or_height): Remove decl.
847 * xdisp.c (calc_pixel_width_or_height): Now static.
848 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
849 * indent.c (check_display_width):
850 * w32term.c: Fix comment to match code.
851 * xterm.c, xterm.h (x_catching_errors): Remove.
853 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
855 * xselect.c: Use signed conversions more consistently (Bug#9498).
856 (selection_data_to_lisp_data): Assume incoming selection data are
857 signed integers, not unsigned. This is to be consistent with
858 outgoing selection data, which was modified to use signed integers
859 in as part of the fix to Bug#9196 in response to Jan D.'s comment
860 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
861 expects long, not unsigned long.
863 2011-09-14 Eli Zaretskii <eliz@gnu.org>
865 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
866 computation of loop end. Reported by Johan Bockgård
869 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
871 * frame.c (Fother_visible_frames_p): Function deleted.
873 2011-09-12 Eli Zaretskii <eliz@gnu.org>
875 * indent.c (compute_motion): Process display vector front to back
876 rather than the other way around. (Bug#2496)
878 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
880 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
882 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
884 * minibuf.c (Fread_from_minibuffer): Doc fix.
886 2011-09-11 Eli Zaretskii <eliz@gnu.org>
888 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
889 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
891 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
893 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
894 value for non-existent files.
896 2011-09-11 Eli Zaretskii <eliz@gnu.org>
898 * fileio.c (Finsert_file_contents): If the file cannot be opened,
899 set its "size" to -1. This will set the modtime_size field of
900 the corresponding buffer to -1, which is what
901 verify-visited-file-modtime expects for files that do not exist.
904 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
906 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
908 * lisp.h: ... from here. push_key_description is no longer
909 defined in keyboard.c, so its declaration should not be in
910 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
911 logically belongs with push_key_description.
913 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
915 * buffer.h: Include <sys/types.h> instead of <time.h>.
916 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
917 Problem reported by Herbert J. Skuhra.
919 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
921 * xml.c (parse_region): Make the parsing work for
922 non-comment-starting XML files again (bug#9144).
924 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
926 * image.c (gif_load): Fix calculation of bottom and right corner.
929 2011-09-10 Eli Zaretskii <eliz@gnu.org>
931 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
932 redisplay in small windows.
934 2011-09-09 Eli Zaretskii <eliz@gnu.org>
936 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
938 2011-09-08 Martin Rudalics <rudalics@gmx.at>
940 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
941 Operate on live windows only.
943 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
945 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
947 2011-09-07 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
950 only under bidi iteration.
952 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
954 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
956 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
958 isnan: Fix porting problem to Solaris 10 with bundled gcc.
959 Without this fix, the command to link temacs failed due to an
960 undefined symbol __builtin_isnan. This is because
961 /usr/include/iso/math_c99.h #defines isnan(x) to
962 __builtin_isnan(x), but the bundled gcc, which identifies itself
963 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
965 * floatfns.c (isnan): #undef, and then #define to a clone of
967 (Fisnan): Always define, since it's always available now.
968 (syms_of_floatfns): Always define isnan at the Lisp level.
970 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
972 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
974 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
976 * fileio.c: Fix bugs with large file offsets (Bug#9428).
977 The previous code assumed that file offsets (off_t values) fit in
978 EMACS_INT variables, which is not true on typical 32-bit hosts.
979 The code messed up by falsely reporting buffer overflow in cases
980 such as (insert-file-contents "big" nil 1 2) into an empty buffer
981 when "big" contains more than 2**29 bytes, even though this
982 inserts just one byte and does not overflow the buffer.
983 (Finsert_file_contents): Store file offsets as off_t
984 values, not as EMACS_INT values. Check for overflow when
985 converting between EMACS_INT and off_t. When checking for
986 buffer overflow or for overlap, take the offsets into account.
987 Don't use EMACS_INT for small values where int suffices.
988 When checking for overlap, fix a typo: ZV was used where
989 ZV_BYTE was intended.
990 (Fwrite_region): Don't assume off_t fits into 'long'.
991 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
993 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
995 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
997 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
999 sprintf-related integer and memory overflow issues (Bug#9412).
1001 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1002 (esprintf, exprintf, evxprintf): New functions.
1003 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1004 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1005 (modify_event_symbol): Do not assume that the length of
1006 name_alist_or_stem is safe to alloca and fits in int.
1007 (Fexecute_extended_command): Likewise for function name and binding.
1008 (Frecursion_depth): Wrap around reliably on integer overflow.
1009 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1010 since some callers pass EMACS_INT values.
1011 (Fsingle_key_description): Don't crash if symbol name contains more
1012 than MAX_ALLOCA bytes.
1013 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1014 (get_minibuffer): Arg is now EMACS_INT, not int.
1015 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1016 (esprintf, exprintf, evxprintf): New decls.
1017 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1019 * dbusbind.c (signature_cat): New function.
1020 (xd_signature, Fdbus_register_signal):
1021 Do not overrun buffer; instead, report string overflow.
1023 * dispnew.c (add_window_display_history): Don't overrun buffer.
1024 Truncate instead; this is OK since it's just a log.
1026 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1027 even if the time zone offset is outlandishly large.
1028 Don't mishandle offset == INT_MIN.
1030 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1031 when creating daemon; the previous buffer-overflow check was incorrect.
1033 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1034 which has the guts of the old verror function.
1036 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1037 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1039 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1040 (font_unparse_xlfd): Don't blindly alloca long strings.
1041 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1042 fits in int, when using sprintf. Use single snprintf to count
1043 length of string rather than counting it via multiple sprintfs;
1044 that's simpler and more reliable.
1045 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1046 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1047 sprintf, in case result does not fit in int.
1049 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1050 (fontset_from_font): Print it.
1052 * frame.c (tty_frame_count): Now printmax_t, not int.
1053 (make_terminal_frame, set_term_frame_name): Print it.
1054 (x_report_frame_params): In X, window IDs are unsigned long,
1055 not signed long, so print them as unsigned.
1056 (validate_x_resource_name): Check for implausibly long names,
1057 and don't assume name length fits in 'int'.
1058 (x_get_resource_string): Don't blindly alloca invocation name;
1059 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1062 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1063 (xg_check_special_colors, xg_set_geometry):
1064 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1066 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1067 Use esprintf, not sprintf, in case result does not fit in int.
1069 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1070 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1071 it as a large positive number.
1072 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1073 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1075 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1076 in case result does not fit in int.
1078 * print.c (float_to_string): Detect width overflow more reliably.
1079 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1080 buffer overrun. Don't assume list length fits in 'int'. Treat
1081 print length of 0 as 0, not as infinity; to be consistent with other
1082 uses of print length in this function. Don't overflow print length
1083 index. Don't assume hash table size fits in 'long', or that
1084 vectorlike size fits in 'unsigned long'.
1086 * process.c (make_process): Use printmax_t, not int, to format
1087 process-name gensyms.
1089 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1091 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1092 to avoid potential buffer overrun.
1094 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1095 if X resource line is longer than 512 bytes.
1097 * xfns.c (x_window): Make sprintf buffer a bit bigger
1098 to avoid potential buffer overrun.
1100 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1102 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1104 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1106 Integer overflow fixes for scrolling, etc.
1107 Without these, Emacs silently mishandles large integers sometimes.
1108 For example, "C-u 4294967297 M-x recenter" was treated as if
1109 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1111 * xdisp.c (try_window_id): Check Emacs fixnum range before
1112 converting to 'int'.
1114 * window.c (window_scroll_line_based, Frecenter):
1115 Check that an Emacs fixnum is in range before assigning it to 'int'.
1116 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1117 values converted from Emacs fixnums.
1118 (Frecenter): Don't wrap around a line count if it is out of 'int'
1119 range; instead, treat it as an extreme value.
1120 (Fset_window_configuration, compare_window_configurations):
1121 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1123 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1124 that can exceed INT_MAX. Check that EMACS_INT value is in range
1125 before assigning it to the (possibly-narrower) index.
1126 (match_limit): Don't assume that a fixnum can fit in 'int'.
1128 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1131 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1132 (Fvertical_motion): Don't wrap around LINES values that don't fit
1133 in 'int'. Instead, treat them as extreme values. This is good
1134 enough for windows, which can't have more than INT_MAX lines anyway.
1136 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1138 * Require libxml/parser.h to avoid compilation warning.
1140 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1142 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1143 since this reportedly can destroy thread storage.
1145 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1147 * syntax.c (find_defun_start): Update all cache variables if
1148 exiting early (Bug#9401).
1150 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1152 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1154 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1155 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1156 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1158 * term.c (tty_append_glyph): New function.
1159 (produce_stretch_glyph): Static function and its prototype deleted.
1161 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1164 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1166 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1167 when checking :margin (Bug#9390).
1168 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1169 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1170 so that the name doesn't mislead. All uses changed.
1172 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1174 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1177 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1179 * xdisp.c (move_it_to): Don't bail out early when reaching
1180 position beyond to_charpos, if we are scanning backwards.
1181 (move_it_vertically_backward): When DY == 0, make sure we get to
1182 the first character in the line after the newline.
1184 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1186 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1187 (ccl_driver): Do not generate an out-of-range pointer.
1188 (Fccl_execute_on_string): Remove unnecessary check for
1189 integer overflow, noted by Stefan Monnier in
1190 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1191 Remove a FIXME that didn't need fixing.
1192 Simplify the newly-introduced buffer reallocation code.
1194 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1196 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1198 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1200 Integer and memory overflow issues (Bug#9196).
1202 * doc.c (get_doc_string): Rework so that
1203 get_doc_string_buffer_size is the actual buffer size, rather than
1204 being 1 less than the actual buffer size; this makes xpalloc more
1207 * image.c (x_allocate_bitmap_record, cache_image):
1208 * xselect.c (Fx_register_dnd_atom):
1209 Simplify previous changes by using xpalloc.
1211 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1212 since either will do and ptrdiff_t is convenient with xpalloc.
1214 * charset.c (charset_table_size)
1215 (struct charset_sort_data.priority): Now ptrdiff_t.
1216 (charset_compare): Don't overflow if priorities differ greatly.
1217 (Fsort_charsets): Don't assume list length fits in int.
1218 Check for size-calculation overflow when allocating sort data.
1219 (syms_of_charset): Allocate an initial charset table that is
1220 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1222 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1224 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1225 The actual value is always <= INT_MAX, and leaving it unsigned made
1226 overflow checking harder.
1228 * dispextern.h (struct glyph_matrix.rows_allocated)
1229 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1230 with xpalloc. The values are still always <= INT_MAX.
1232 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1234 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1235 (SAFE_NALLOCA): New macro.
1237 * region-cache.c (struct boundary.pos, find_cache_boundary)
1238 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1239 (set_cache_region, invalidate_region_cache)
1240 (revalidate_region_cache, know_region_cache, region_cache_forward)
1241 (region_cache_backward, pp_cache):
1242 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1243 so that ptrdiff_t * can be passed to xpalloc.
1244 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1245 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1246 (pp_cache): Don't assume cache_len fits in int.
1247 * region-cache.h: Adjust extern decls to match.
1249 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1250 EMACS_INT, since either will do, for xpalloc.
1252 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1253 (xnmalloc, xnrealloc, xpalloc): New functions.
1255 * bidi.c (bidi_shelve_header_size): New constant.
1256 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1257 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1259 * bidi.c (bidi_cache_shrink):
1260 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1262 Don't update size of array until after memory allocation succeeds,
1263 because xmalloc/xrealloc may not return.
1264 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1265 now that we have proper integer overflow checking.
1266 (record_overlay_string, overlay_strings): Catch overflows when
1267 calculating size of overlay_str_buf.
1269 * callproc.c (Fcall_process): Check for size overflow when
1270 calculating size of args2.
1271 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1272 Normally we prefer signed values, but sticking with ptrdiff_t would
1273 require adding more-complicated checks.
1275 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1276 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1277 Redo buffer-overflow calculations to avoid integer overflow.
1278 Add a FIXME comment where memory seems to be over-allocated.
1280 * character.c (Fstring): Check for size-calculation overflow.
1282 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1283 unnecessary integer overflow. Check for size overflow.
1284 (encode_coding_object): Don't update size until xmalloc succeeds.
1286 * composite.c (get_composition_id): Check for overflow in glyph
1287 length calculations.
1289 Integer and memory overflow fixes for display code.
1290 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1291 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1292 (scrolling_window): Check for overflow in size calculations.
1293 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1294 Don't assume glyph table len fits in int.
1295 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1296 (row_table_size): Now ptrdiff_t, not int.
1297 (scrolling_window): Avoid overflow in size calculations.
1298 Don't update size until allocation succeeds.
1299 * fns.c (concat): Check for overflow in size calculations.
1300 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1301 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1302 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1304 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1305 (get_doc_string): Check for size calculation overflow.
1306 Don't update size until allocation succeeds.
1307 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1308 EMACS_INT, where ptrdiff_t will do.
1309 (Fsubstitute_command_keys): Check for string overflow.
1311 * editfns.c (set_time_zone_rule): Don't assume environment length
1313 (message_length): Now ptrdiff_t, not int.
1314 (Fmessage_box): Don't update size until allocation succeeds.
1315 Don't assume message length fits in int.
1316 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1318 * emacs.c (main): Do not reallocate argv, since there is a null at
1319 the end that can be overwritten, and this way there's no need to
1320 worry about size-calculation overflow.
1321 (sort_args): Check for size-calculation overflow.
1323 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1325 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1327 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1328 (x_set_scroll_bar_width, x_figure_window_size):
1329 Check for integer overflow.
1330 (x_set_alpha): Do not assume XINT fits in int.
1332 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1333 This is for the members text_lines, text_cols, total_lines, total_cols,
1334 where the system imposes an 'int' limit.
1336 * fringe.c (Fdefine_fringe_bitmap):
1337 Don't update size until alloc works.
1339 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1340 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1342 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1343 Check for size-calculation overflow.
1344 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1345 do, as we prefer signed integers.
1346 (id_to_widget.max_size, id_to_widget.used)
1347 (xg_store_widget_in_map, xg_remove_widget_from_map)
1348 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1349 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1350 Use and return ptrdiff_t, not int.
1351 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1352 * gtkutil.h: Change prototypes to match the above.
1354 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1355 are duplicate now that they've been promoted to lisp.h.
1356 (x_allocate_bitmap_record, x_alloc_image_color)
1357 (make_image_cache, cache_image, xpm_load):
1358 Don't update size until alloc is done.
1359 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1361 Check for size calculation overflow.
1362 (ct_colors_allocated_max): New constant.
1363 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1366 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1367 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1368 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1369 Use ptrdiff_t, not int, to count maps.
1370 (read_char_minibuf_menu_prompt): Check for overflow in size
1371 calculations. Don't update size until allocation succeeds.
1372 Redo calculations to avoid overflow.
1373 * keyboard.h: Change prototypes to match the above.
1375 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1377 (current_minor_maps): Check for size calculation overflow.
1378 * keymap.h: Change prototypes to match the above.
1380 * lread.c (read1, init_obarray): Don't update size until alloc done.
1382 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1383 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1385 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1386 Now ptrdiff_t, not int.
1387 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1388 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1390 * process.c (Fnetwork_interface_list): Check for overflow
1391 in size calculation.
1393 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1395 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1396 overflow. Don't bother calling xmalloc when xrealloc will do.
1398 * search.c (Freplace_match): Check for size calculation overflow.
1399 (Fset_match_data): Don't assume list lengths fit in 'int'.
1401 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1402 for command line length. Do not attempt to address one before the
1403 beginning of an array, as that's not portable.
1405 * term.c (max_frame_lines): Remove; unused.
1406 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1408 (encode_terminal_code, calculate_costs): Check for size
1409 calculation overflow.
1410 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1411 table lengths and related sizes. Don't update size until alloc
1412 done. Redo calculations to avoid overflow.
1413 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1415 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1416 subtracting pointers.
1417 (gobble_line): Check for overflow more carefully. Don't update size
1420 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1421 Don't update size until alloc done.
1422 Redo size calculations to avoid overflow.
1423 Check for size calculation overflow.
1424 (main) [DEBUG]: Fix typo in invoking tparam1.
1426 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1427 Use ptrdiff_t, not int, for sizes.
1428 (store_mode_line_noprop_char): Don't update size until alloc done.
1430 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1431 Use ptrdiff_t, not int, for sizes.
1432 (Finternal_make_lisp_face, cache_face):
1433 Check for size calculation overflow.
1434 (cache_face): Treat size calculation overflows as if they were
1435 memory exhaustion (the usual treatment), rather than aborting.
1437 * xfns.c (x_encode_text, x_set_name_internal)
1438 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1439 sizes, since they can exceed INT_MAX in size. Check for size
1440 calculation overflow.
1442 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1443 (xg_select): Check for size calculation overflow.
1444 Don't update size until alloc done.
1446 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1447 as sprintf is limited to int lengths.
1449 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1450 (X_LONG_MIN): New macros.
1451 Use them to make the following changes clearer.
1452 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1453 This change doesn't affect the value now, but it may help remind
1454 future maintainers not to raise the value too much later.
1455 (SELECTION_QUANTUM): Remove, replacing with ...
1456 (selection_quantum): ... new function, which avoids overflow.
1458 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1459 assumption that selection length fits in 'int'.
1460 (x_reply_selection_request, x_handle_selection_request)
1461 (x_get_window_property, receive_incremental_selection)
1462 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1463 (lisp_data_to_selection_data, clean_local_selection_data):
1464 Use ptrdiff_t, not int, to record length of selection.
1465 (x_reply_selection_request, x_get_window_property)
1466 (receive_incremental_selection, x_property_data_to_lisp):
1467 Redo calculations to avoid overflow.
1468 (x_reply_selection_request): When sending hint, ceiling it at
1469 X_LONG_MAX rather than relying on wraparound overflow to send
1471 (x_get_window_property, receive_incremental_selection)
1472 (lisp_data_to_selection_data, x_property_data_to_lisp):
1473 Check for size-calculation overflow.
1474 (x_get_window_property, receive_incremental_selection)
1475 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1476 Don't store size until memory allocation succeeds.
1477 (x_get_window_property): Plug memory leak on memory exhaustion.
1478 Don't double-block input; malloc is safe here. Don't assume 2**34
1479 - 4 fits in unsigned long. Add an xassert to check
1480 XGetWindowProperty overflow. Be more careful about overflow
1481 calculations, and distinguish size from memory overflow better.
1482 (receive_incremental_selection): When tracing, don't assume
1483 unsigned int is less than INT_MAX.
1484 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1485 harmful) conversions of unsigned short to int.
1486 (lisp_data_to_selection_data): Don't assume that integers
1487 in the range -65535 through -1 fit in an X unsigned short.
1488 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1489 result parameters unless successful. Rely on cons_to_unsigned
1490 to report problems with elements; the old code wasn't right anyway.
1491 (x_check_property_data): Check for int overflow; we cannot use
1492 a wider type due to X limits.
1493 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1495 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1497 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1498 (x_term_init): Check for size calculation overflow.
1499 (x_color_cells): Don't store size until memory allocation succeeds.
1500 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1501 Don't assume alloca size is less than MAX_ALLOCA.
1502 (x_term_init): Don't assume length fits in int (sprintf is limited
1505 Use ptrdiff_t for composition IDs.
1506 * character.c (lisp_string_width):
1507 * composite.c (composition_table_size, n_compositions)
1508 (get_composition_id, composition_gstring_from_id):
1509 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1510 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1511 * window.c (Frecenter):
1512 Use ptrdiff_t, not int, for composition IDs.
1513 * composite.c (get_composition_id): Check for integer overflow.
1514 * composite.h: Adjust prototypes to match the above changes.
1516 Use ptrdiff_t for hash table indexes.
1517 * category.c (hash_get_category_set):
1518 * ccl.c (ccl_driver):
1519 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1520 * coding.c (coding_system_charset_list, detect_coding_system):
1521 * coding.h (struct coding_system.id):
1522 * composite.c (get_composition_id, gstring_lookup_cache):
1523 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1524 * image.c (xpm_get_color_table_h):
1525 * lisp.h (hash_lookup, hash_put):
1526 * minibuf.c (Ftest_completion):
1527 Use ptrdiff_t for hash table indexes, not int (which is too
1528 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1529 32-bit --with-wide-int hosts).
1531 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1532 Add a FIXME comment about memory leaks.
1533 (syms_of_charset): Don't assume xmalloc returns.
1535 Don't assume that stated character widths fit in int.
1536 * character.c (Fchar_width, c_string_width, lisp_string_width):
1537 * character.h (CHAR_WIDTH):
1538 * indent.c (MULTIBYTE_BYTES_WIDTH):
1539 Use sanitize_char_width to avoid undefined and/or bad behavior
1540 with outlandish widths.
1541 * character.h (sanitize_tab_width): Rename from sanitize_width,
1542 now that we have two such functions. All uses changed.
1543 (sanitize_char_width): New inline function.
1545 Don't assume that tab-width fits in int.
1546 * character.h (sanitize_width): New inline function.
1547 (SANE_TAB_WIDTH): New macro.
1548 (ASCII_CHAR_WIDTH): Use it.
1549 * indent.c (sane_tab_width): Remove. All uses replaced by
1550 SANE_TAB_WIDTH (current_buffer).
1551 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1553 * fileio.c: Integer overflow issues with file modes.
1554 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1556 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1557 Remove unreachable code.
1558 (read_hex, load_charset_map_from_file): Check for integer overflow.
1560 * xterm.c: don't go over XClientMessageEvent limit
1561 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1562 (x_send_scroll_bar_event): Likewise. Check that the size does not
1563 exceed limits imposed by XClientMessageEvent, as well as the usual
1564 ptrdiff_t and size_t limits.
1566 * keyboard.c: Overflow, signedness and related fixes.
1567 (make_lispy_movement): Use same integer type in forward decl
1568 that is used in the definition.
1569 (read_key_sequence, keyremap_step):
1570 Change bufsize argument back to int, undoing my 2011-03-30 change.
1571 We prefer signed types, and int is wide enough here.
1572 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1573 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1574 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1575 length, not size_t. Use ptrdiff_t for index, not int.
1576 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1577 possibility of integer overflow.
1579 Overflow, signedness and related fixes for images.
1581 * dispextern.h (struct it.stack[0].u.image.image_id)
1582 (struct_it.image_id, struct image.id, struct image_cache.size)
1583 (struct image_cache.used, struct image_cache.ref_count):
1584 * gtkutil.c (update_frame_tool_bar):
1585 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1586 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1587 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1588 * nsmenu.m (update_frame_tool_bar):
1589 * xdisp.c (calc_pixel_width_or_height):
1590 * xfns.c (image_cache_refcount):
1591 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1592 on typical 64-bit hosts.
1594 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1595 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1596 Omit unnecessary casts to int.
1597 (parse_image_spec): Check that integers fall into 'int' range
1598 when the callers expect that.
1599 (image_ascent): Redo ascent calculation to avoid int overflow.
1600 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1601 (lookup_image): Remove unnecessary tests.
1602 (xbm_image_p): Locals are now of int, not EMACS_INT,
1603 since parse_image_check makes sure they fit into int.
1604 (png_load, gif_load, svg_load_image):
1605 Prefer int to unsigned where either will do.
1606 (tiff_handler): New function, combining the cores of the
1607 old tiff_error_handler and tiff_warning_handler.
1608 This function is rewritten to use vsnprintf and thereby avoid
1609 stack buffer overflows. It uses only the features of vsnprintf
1610 that are common to both POSIX and native Microsoft.
1611 (tiff_error_handler, tiff_warning_handler): Use it.
1612 (tiff_load, gif_load, imagemagick_load_image):
1613 Don't assume :index value fits in 'int'.
1614 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1615 (imagemagick_load_image): Check that crop parameters fit into
1616 the integer types that MagickCropImage accepts. Don't assume
1617 Vimagemagick_render_type has a nonnegative value. Don't assume
1618 size_t fits in 'long'.
1619 (gs_load): Use printmax_t to print the widest integers possible.
1620 Check for integer overflow when computing image height and width.
1622 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1624 * xdisp.c (redisplay_window): Don't force window start if point
1625 will be invisible in the resulting window. (Bug#9324)
1627 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1629 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1630 the display spec is of the form `(space ...)'.
1631 (handle_display_spec): Return the value returned by
1632 handle_single_display_spec, not just 1 or zero.
1633 (handle_single_display_spec): If the display spec is of the form
1634 `(space ...)', and specifies display in the text area, return 2
1636 (try_cursor_movement): Check for the need to scroll more
1637 accurately, and prefer exact match for point under bidi.
1638 Don't advance `row' beyond the last row of the window.
1640 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1641 into disp_prop; all users changed.
1643 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1644 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1645 for the text covered by the display property.
1647 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1649 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1650 Change return value to nil.
1651 (Frecord_buffer): Delete unused function.
1653 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1655 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1656 buffers, return left-to-right.
1657 (set_cursor_from_row): Consider candidate row a win if its glyph
1658 represents a newline and point is on that newline. Fixes cursor
1659 positioning on the newline at EOL of R2L text within L2R
1660 paragraph, and vice versa.
1661 (try_cursor_movement): Check continued rows, in addition to
1662 continuation rows. Fixes unwarranted scroll when point enters a
1663 continued line of R2L text within an L2R paragraph, or vice versa.
1664 (cursor_row_p): Consider the case of point being equal to
1665 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1666 from the end of a short line to the beginning of a continued line
1667 of R2L text within L2R paragraph.
1668 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1669 composed characters.
1671 * bidi.c (bidi_check_type): Use xassert.
1672 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1675 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1677 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1680 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1682 * nsfont.m (ns_otf_to_script): Fix typo.
1684 2011-08-22 Kenichi Handa <handa@m17n.org>
1686 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1687 extra slot even if the purpose is char-code-property-table.
1689 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1691 * xdisp.c (redisplay_window): When computing centering_position,
1692 account for the height of the header line. (Bug#8874)
1694 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1695 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1696 candidate is selected by the mouse, and that candidate has a
1697 composed character under the mouse.
1699 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1700 coordinates reported by pos-visible-in-window-p for a composed
1701 character in column zero.
1703 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1705 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1707 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1709 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1710 consider it a hit if to_charpos is anywhere in the range of the
1711 composed buffer positions.
1713 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1715 * image.c (gif_load): Don't assume that each subimage has the same
1716 dimensions as the base image. Handle disposal method that is
1717 "undefined" by the gif spec (Bug#9335).
1719 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1721 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1722 (Fcondition_case): Document `debug' symbol in error handler.
1724 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1726 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1727 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1728 from an Org mode buffer to a Speedbar frame.
1730 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1731 a composition, take its buffer position from IT->cmp_it.charpos.
1732 Fixes cursor positioning at the beginning of a line that begins
1733 with a composed character.
1735 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1737 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1738 character bidirectional type, use STRONG_L instead. Fixes crashes
1739 in a buffer produced by `describe-categories'.
1741 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1742 members before the level stack, so they would be saved and
1743 restored when copying iterator state. Fixes incorrect reordering
1744 around TABs covered by display properties.
1746 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1748 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1750 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1752 * eval.c (internal_condition_case, internal_condition_case_1)
1753 (internal_condition_case_2, internal_condition_case_n):
1754 Remove unnecessary aborts (Bug#9081).
1756 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1758 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1759 has no `load' handler, try opening the file locally. (Bug#9311)
1761 2011-08-16 Ken Brown <kbrown@cornell.edu>
1763 * gmalloc.c: Expand comment.
1765 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1767 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1768 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1770 2011-08-16 Ken Brown <kbrown@cornell.edu>
1772 Fix memory allocation problems in Cygwin build (Bug#9273).
1774 * unexcw.c ( __malloc_initialized): Declare external variable.
1775 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1777 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1779 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1781 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1783 [CYGWIN] (special_realloc): New function.
1784 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1785 requests to realloc storage in the static heap.
1787 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1789 * bidi.c (bidi_initialize): Remove unused local.
1791 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1794 * biditype.h: Remove file.
1795 * makefile.w32-in ($(BLD)/bidi.$(O)):
1796 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1798 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1800 * chartab.c: Improve commentary for the uniprop_table API.
1802 * bidi.c (bidi_paragraph_init): Support zero value of
1803 bidi_ignore_explicit_marks_for_paragraph_level.
1804 (bidi_initialize): Use uniprop_table instead of including
1805 biditype.h and bidimirror.h.
1807 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1808 coordinates of the iterator when restoring from ppos_it.
1811 2011-08-14 Kenichi Handa <handa@m17n.org>
1813 * process.c (create_process): Call setup_process_coding_systems
1814 after the pid of the process is set to -1 (Bug#8162).
1816 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1818 * xdisp.c (move_it_in_display_line_to): Don't invoke
1819 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1820 ppos_it. Fixes vertical cursor motion when line beginning is
1821 covered by an image. (Bug#9296)
1823 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1825 * nsterm.h (ns_run_ascript): Declare.
1826 (NSAPP_DATA2_RUNASSCRIPT): Define.
1828 * nsfns.m (as_script, as_result, as_status): New static variables.
1829 (ns_run_ascript): New function.
1830 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1831 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1832 the event loop. Get status from as_status (Bug#7276).
1834 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1835 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1836 the event loop (Bug#7276).
1838 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1840 * gnutls.c (QCgnutls_bootprop_priority)
1841 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1842 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1843 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1844 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1845 (QCgnutls_bootprop_verify_hostname_error)
1846 (QCgnutls_bootprop_callbacks_verify): Rename from
1847 Qgnutls_bootprop_..., all uses changed.
1849 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1852 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1854 * xfaces.c (Qframe_set_background_mode): Now static.
1855 * dispextern.h (Qframe_set_background_mode): Remove decl.
1857 * process.c (Fnetwork_interface_info): Declare local only if needed.
1859 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1861 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1862 (Fnetwork_interface_list): Allocate in increments of bytes instead
1863 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1864 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1866 (struct ifflag_def): notrailers is smart on OSX.
1867 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1868 Get hardware address with getifaddrs if available.
1870 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (iterate_out_of_display_property): xassert that
1873 IT->position is set to within IT->object's boundaries. Break from
1874 the loop as soon as EOB is reached; avoids infloops in redisplay
1875 when IT->position is set up wrongly due to some bug.
1876 Set IT->current to match the bidi iterator unconditionally.
1877 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1878 entry. Force push_it to save on the stack the current
1879 buffer/string position, to be restored by pop_it. Fix flags in
1880 the iterator structure wrt the object coming from a display
1881 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1882 properties. (Bug#9284)
1884 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1886 * fontset.c (fontset_get_font_group): Add proper type checks.
1889 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1891 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1892 and LC_VERSION_MIN_MACOSX.
1893 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1894 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1896 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1898 * xdisp.c (forward_to_next_line_start): Allow to use the
1899 no-display-properties-and-no-overlays under bidi display.
1900 Set disp_pos in the bidi iterator to avoid searches for display
1901 properties and overlays.
1903 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1905 * editfns.c (Fset_time_zone_rule): Document relationship with the
1908 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1909 the font entity extracted from the cache (Bug#8109).
1911 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1913 * composite.c (autocmp_chars): Don't reset point. That is done by
1914 restore_point_unwind (Bug#5984).
1916 2011-08-07 Juri Linkov <juri@jurta.org>
1918 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1919 to show the arg `TIME' instead of `TIMEVAL'.
1921 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1923 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1924 display property strides EOL and includes a newline, as in
1925 longlines-mode. (Bug#9254)
1926 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1927 word-wrap under bidirectional display. (Bug#9224)
1929 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1930 is non-zero, even if the data buffer is NULL. Fixes a crash in
1931 vertical-motion with longlines-mode. (Bug#9254)
1933 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1935 * bidi.c <bidi_cache_total_alloc>: Now static.
1936 (bidi_initialize): Initialize bidi_cache_total_alloc.
1938 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1941 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1942 amount allocated this far in `bidi_cache_total_alloc'.
1943 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1944 non-zero, only free the data buffer without restoring the cache
1945 contents. All callers changed.
1947 * dispextern.h (bidi_unshelve_cache): Update prototype.
1949 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1950 (move_it_in_display_line, move_it_to)
1951 (move_it_vertically_backward, move_it_by_lines): Replace the call
1952 to xfree to an equivalent call to bidi_unshelve_cache.
1953 (move_it_in_display_line_to): Fix logic of returning
1954 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1956 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1958 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1959 came from a string character with a `cursor' property. (Bug#9229)
1961 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1963 * Makefile.in (LIB_PTHREAD): New variable.
1964 (LIBES): Add LIB_PTHREAD (Bug#9216).
1966 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1967 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1969 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1971 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1973 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1975 * xterm.c (x_find_topmost_parent): New function.
1976 (x_set_frame_alpha): Find topmost parent window with
1977 x_find_topmost_parent and set the property there also (bug#9181).
1978 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1980 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1982 * callproc.c (Fcall_process): Avoid vfork clobbering
1983 the local vars buffer, coding_systems, current_dir.
1985 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1987 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1989 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1991 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1992 so that it is not optimized away.
1994 * xdisp.c (compute_display_string_pos): Remove unused local.
1996 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1998 Fix slow cursor motion and scrolling in large buffers with
1999 selective display, like Org Mode buffers. (Bug#9218)
2001 * dispextern.h (struct bidi_it): New member disp_prop_p.
2003 * xdisp.c: Remove one-slot cache of display string positions.
2004 (compute_display_string_pos): Accept an additional argument
2005 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2006 for a display string or property. If found, set DISP_PROP_P
2009 * bidi.c (bidi_fetch_char): Accept an additional argument
2010 DISP_PROP_P, and pass it to compute_display_string_pos.
2011 Only handle text covered by a display string if DISP_PROP_P is returned
2012 non-zero. All callers of bidi_fetch_char changed.
2014 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2016 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2018 2010-12-03 Don March <don@ohspite.net>
2020 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2021 last character M-[char] is translated to ESC [char] (bug#7541).
2023 2011-08-02 Kenichi Handa <handa@m17n.org>
2025 * lisp.h (uniprop_table): Extern it.
2027 * chartab.c (uniprop_table): Make it non-static.
2029 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2031 * xdisp.c (forward_to_next_line_start): Accept additional argument
2032 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2034 (reseat_at_next_visible_line_start): Use the bidi iterator state
2035 returned by forward_to_next_line_start to restore the state of
2036 it->bidi_it after backing up to previous newline. (Bug#9212)
2038 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2040 * regex.c (re_comp): Protoize.
2041 (re_exec): Fix return type.
2042 (regexec): Fix type of `ret'. (Bug#9203)
2044 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2046 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2047 This is needed if max-image-size is a floating-point number.
2049 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2051 * print.c (print_object): Print empty symbol as ##.
2053 * lread.c (read1): Read ## as empty symbol.
2055 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2057 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2058 setting frame foreground color (Bug#9175).
2059 (x_set_background_color): Likewise.
2061 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2062 contents (Bug#9176).
2063 (EmacsTooltip -init): Remove bezels and add shadows to
2066 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2067 or scroll bar (Bug#8470).
2069 * nsfont.m (nsfont_open): Remove assignment to voffset and
2070 unnecessary vars hshink, expand, hd, full_height, min_height.
2071 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2073 * nsterm.h (nsfont_info): Remove voffset field.
2075 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2077 Implement strike-through and overline on NextStep (Bug#8863).
2079 * nsfont.m (nsfont_open): Use underline position provided by font,
2080 instead of hard-coded value of 2.
2081 (nsfont_draw): Call ns_draw_text_decoration instead.
2083 * nsterm.h: Add declaration for ns_draw_text_decoration.
2085 * nsterm.m (ns_draw_text_decoration): New function for drawing
2086 underline, overline, and strike-through.
2087 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2088 ns_draw_text_decoration. Change treatment of cursor drawing to
2089 accommodate underlining, etc.
2091 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2093 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2096 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2098 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2099 Without this fix, if a signal arrives just after memory fills up,
2100 'malloc' might be invoked reentrantly.
2102 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2103 In other words, assume that every image size is allowed, on non-X
2104 hosts. This assumption is probably wrong, but it lets Emacs compile.
2106 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2108 * regex.c (re_iswctype): Convert return values to boolean.
2110 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2112 * xdisp.c (compute_display_string_pos): Don't use cached display
2113 string position if the buffer had its restriction changed.
2116 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2118 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2120 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2122 Integer signedness and overflow and related fixes. (Bug#9079)
2124 * bidi.c: Integer size and overflow fixes.
2125 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2126 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2127 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2128 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2129 (bidi_find_other_level_edge):
2130 Use ptrdiff_t instead of EMACS_INT where either will do.
2131 This works better on 32-bit hosts configured --with-wide-int.
2132 (bidi_cache_ensure_space): Check for size-calculation overflow.
2133 Use % rather than repeated addition, for better worst-case speed.
2134 Don't set bidi_cache_size until after xrealloc returns, because it
2136 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2137 (bidi_cache_ensure_space): Also check that the bidi cache size
2138 does not exceed that of the largest Lisp string or buffer. See Eli
2139 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2141 * alloc.c (__malloc_size_t): Remove.
2142 All uses replaced by size_t. See Andreas Schwab's note
2143 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2145 * image.c: Improve checking for integer overflow.
2146 (check_image_size): Assume that f is nonnull, since
2147 it is always nonnull in practice. This is one less thing to
2148 worry about when checking for integer overflow later.
2149 (x_check_image_size): New function, which checks for integer
2150 overflow issues inside X.
2151 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2152 This removes the need for a memory_full check.
2153 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2154 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2155 (xbm_read_bitmap_data): Change locals back to 'int', since
2156 their values must fit in 'int'.
2157 (xpm_load_image, png_load, tiff_load):
2158 Invoke x_create_x_image_and_pixmap earlier,
2159 to avoid much needless work if the image is too large.
2160 (tiff_load): Treat overly large images as if
2161 x_create_x_image_and_pixmap failed, not as malloc failures.
2162 (gs_load): Use x_check_image_size.
2164 * gtkutil.c: Omit integer casts.
2165 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2166 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2168 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2170 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2171 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2172 would wrongly return t on a 64-bit host.
2174 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2175 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2176 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2177 and therefore cause GCC to emit a bogus diagnostic in some cases.
2179 * image.c: Integer signedness and overflow and related fixes.
2180 This is not an exhaustive set of fixes, but it's time to
2181 record what I've got.
2182 (lookup_pixel_color, check_image_size): Remove redundant decls.
2183 (check_image_size): Don't assume that arbitrary EMACS_INT values
2184 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2185 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2186 (tiff_load, imagemagick_load_image):
2187 Check for overflow in size calculations.
2188 (x_create_x_image_and_pixmap): Remove unnecessary test for
2189 xmalloc returning NULL; that can't happen.
2190 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2191 (xpm_color_bucket): Use better integer hashing function.
2192 (xpm_cache_color): Don't possibly over-allocate memory.
2193 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2194 (gif_memory_source):
2195 Use ptrdiff_t, not int or size_t, to record sizes.
2196 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2197 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2198 either works, as we prefer signed integers.
2199 (tiff_read_from_memory, tiff_write_from_memory):
2200 Return tsize_t, not size_t, since that's what the TIFF API wants.
2201 (tiff_read_from_memory): Don't fail simply because the read would
2202 go past EOF; instead, return a short read.
2203 (tiff_load): Omit no-longer-needed casts.
2204 (Fimagemagick_types): Don't assume size fits into 'int'.
2206 Improve hashing quality when configured --with-wide-int.
2207 * fns.c (hash_string): New function, taken from sxhash_string.
2208 Do not discard information about ASCII character case; this
2209 discarding is no longer needed.
2210 (sxhash-string): Use it. Change sig to match it. Caller changed.
2211 * lisp.h: Declare it.
2212 * lread.c (hash_string): Remove, since we now use fns.c's version.
2213 The fns.c version returns a wider integer if --with-wide-int is
2214 specified, so this should help the quality of the hashing a bit.
2216 * emacs.c: Integer overflow minor fix.
2217 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2218 Define only if GNU_LINUX.
2219 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2221 * dispnew.c: Integer signedness and overflow fixes.
2222 Remove unnecessary forward decls, that were a maintenance hassle.
2223 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2225 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2226 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2227 (prepare_desired_row, line_draw_cost):
2228 Use int, not unsigned, where either works.
2229 (save_current_matrix, restore_current_matrix):
2230 Use ptrdiff_t, not size_t, where either works.
2231 (init_display): Check for overflow more accurately, and without
2232 relying on undefined behavior.
2234 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2235 Remove, replacing with the new symbols in lisp.h. All uses changed.
2236 * fileio.c (make_temp_name):
2237 * filelock.c (lock_file_1, lock_file):
2238 * xdisp.c (message_dolog):
2239 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2240 Use pMd etc. instead.
2241 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2242 replacing the pWIDE etc. symbols removed from editfns.c.
2244 * keyboard.h (num_input_events): Now uintmax_t.
2245 This is (very slightly) less likely to mess up due to wraparound.
2248 * buffer.c: Integer signedness fixes.
2249 (alloc_buffer_text, enlarge_buffer_text):
2250 Use ptrdiff_t rather than size_t when either will do, as we prefer
2253 * alloc.c: Integer signedness and overflow fixes.
2254 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2255 (__malloc_size_t): Default to size_t, not to int.
2256 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2257 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2258 Prefer ptrdiff_t to size_t when either would do, as we prefer
2260 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2261 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2262 Now const. Initialize with values that are in range even if char
2264 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2265 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2266 These functions do the right thing with sizes > 2**32.
2267 (check_depth): Now ptrdiff_t, not int.
2268 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2269 Adjust to new way of storing sizes. Check for size overflow bugs
2271 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2272 slightly wrong anyway, as it missed one instance of
2273 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2274 (refill_memory_reserve): Omit needless cast to size_t.
2275 (mark_object_loop_halt): Mark as externally visible.
2277 * xselect.c: Integer signedness and overflow fixes.
2278 (Fx_register_dnd_atom, x_handle_dnd_message):
2279 Use ptrdiff_t, not size_t, since we prefer signed.
2280 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2281 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2282 x_dnd_atoms_size and x_dnd_atoms_length.
2284 * doprnt.c: Prefer signed to unsigned when either works.
2286 * doprnt.c (doprnt):
2288 * xdisp.c (vmessage):
2289 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2290 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2291 prefer signed arithmetic to avoid comparison confusion.
2292 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2293 but is a bit tricky.
2295 Assume freestanding C89 headers, string.h, stdlib.h.
2296 * data.c, doprnt.c, floatfns.c, print.c:
2297 Include float.h unconditionally.
2298 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2299 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2300 * regex.c: Likewise for stddef.h, string.h.
2301 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2302 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2303 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2304 (STDC_HEADERS): Remove obsolete defines.
2305 * sysdep.c: Include limits.h unconditionally.
2307 Assume support for memcmp, memcpy, memmove, memset.
2308 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2309 * regex.c (memcmp, memcpy):
2310 Remove; we assume C89 now.
2312 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2313 (__malloc_safe_bcopy): Remove; no longer needed.
2315 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2316 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2317 well either way, and we prefer signed to unsigned.
2319 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2321 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2322 closes the connection while we're reading (bug#9182).
2324 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2326 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2327 are specified (Bug#9168).
2329 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2331 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2332 Found by GCC static checking and --with-wide-int on a 32-bit host.
2334 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2336 * xdisp.c (compute_display_string_pos): Fix logic of caching
2337 previous display string position. Initialize cached_prev_pos to
2338 -1. Fixes slow-down at the beginning of a buffer.
2340 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2342 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2343 for attrs[LFACE_FONTSET_INDEX].
2345 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2347 * xml.c (parse_region): Remove unused local
2348 that was recently introduced.
2350 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2352 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2353 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2355 * xdisp.c (move_it_in_display_line_to): Record the best matching
2356 position for TO_CHARPOS while scanning the line, and restore it on
2357 exit if none of the characters scanned was an exact match.
2358 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2359 when exact match is impossible due to invisible text, and the
2360 lines are truncated.
2362 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2364 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2367 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2369 Fix a significant slow-down of cursor motion with C-n, C-p,
2370 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2371 auto-repeat under bidi redisplay in fontified buffers.
2372 * xdisp.c (compute_stop_pos_backwards): New function.
2373 (next_element_from_buffer): Call compute_stop_pos_backwards to
2374 find a suitable prev_stop when we find ourselves before
2376 (reseat): Don't look for prev_stop, as that could mean a very long
2378 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2379 <cached_disp_overlay_modiff>: Cache for last found display string
2381 (compute_display_string_pos): Return the cached position if asked
2382 about the same buffer in the same area of character positions, and
2383 the buffer wasn't changed since the time the display string
2384 position was cached.
2386 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2388 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2389 is an integer, which is important for empty lines. (Bug#9149)
2391 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2393 * frame.c (Fmodify_frame_parameters): In tty case, update the
2394 default face if necessary (Bug#4238).
2396 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2398 * editfns.c (Fstring_to_char): No need to explain what a character
2399 is in the docstring (Bug#6576).
2401 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2403 * xml.c (parse_region): Make sure we always return a tree.
2405 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2407 * xml.c (parse_region): If a document contains only comments,
2410 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2412 * xml.c (make_dom): Return comments, too.
2414 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2417 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2418 and the surrounding thread.
2419 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2420 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2421 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2423 * s/openbsd.h (BROKEN_SIGIO): Define.
2424 * unexelf.c (unexec) [__OpenBSD__]:
2425 Don't update the .mdebug section of the Alpha COFF symbol table.
2427 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2429 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2432 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2434 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2435 This fixes some race conditions on the permissions of any newly
2438 * alloc.c (valid_pointer_p): Use pipe, not open.
2439 This fixes some permissions issues when debugging.
2441 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2442 If fchown fails to set both uid and gid, try to set just gid,
2443 as that is sometimes allowed. Adjust the file's mode to eliminate
2444 setuid or setgid bits that are inappropriate if fchown fails.
2446 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2448 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2449 to compare Lisp_Objects.
2450 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2451 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2452 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2454 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2456 * lread.c (read_integer): Unread even EOF character.
2457 (read1): Likewise. Properly record start position of symbol.
2459 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2460 symbol character follows.
2462 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2464 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2465 This works around a problem with the previous change to Fcopy_file.
2466 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2467 and without this change, GCC might complain about discarding
2468 fchown's return value.
2470 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2472 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2474 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2476 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2478 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2481 it's used from the C level.
2483 * process.c: Use the same condition for POLL_FOR_INPUT in both
2484 keyboard.c and process.c (bug#1858).
2486 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2488 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2489 (Fgnutls_boot): Use it.
2491 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2493 * doc.c (Fsubstitute_command_keys): Revert last change.
2495 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2497 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2498 quotes the next character, and doesn't affect other longer
2499 sequences (bug#8935).
2501 * lread.c (syms_of_lread): Clarify that is isn't only
2502 `eval-buffer' and `eval-defun' that's affected by
2503 `lexical-binding' (bug#8460).
2505 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2507 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2508 bidi redisplay when a line includes both an image and is truncated.
2510 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2512 Fix minor problems found by static checking.
2513 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2514 (elsz): Now a signed constant, not a size_t var. We prefer signed
2515 types to unsigned, to avoid integer comparison confusion. Without
2516 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2517 "cannot optimize loop, the loop counter may overflow", a symptom
2519 * indent.c (Fvertical_motion): Mark locals as initialized.
2520 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2522 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2524 * search.c (Fre_search_backward): Mention `case-fold-search' in
2525 all the re_search_* functions (bug#8138).
2527 * keyboard.c (Fopen_dribble_file): Document when the file is
2530 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2532 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2535 Support bidi reordering of display and overlay strings.
2536 * xdisp.c (compute_display_string_pos)
2537 (compute_display_string_end): Accept additional argument STRING.
2538 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2539 (reseat_to_string): Initialize bidi_it->string.s and
2540 bidi_it->string.schars.
2541 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2542 NULL (avoids a crash in bidi_paragraph_init).
2543 Initialize itb.string.lstring.
2544 (init_iterator): Call bidi_init_it only of a valid
2545 buffer position was specified. Initialize paragraph_embedding to
2547 (reseat_to_string): Initialize the bidi iterator.
2548 (display_string): If we need to ignore text properties of
2549 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2550 original value of -1 will not work with bidi.)
2551 (compute_display_string_pos): First arg is now struct
2552 `text_pos *'; all callers changed. Support display properties on
2554 (compute_display_string_end): Support display properties on Lisp
2556 (init_iterator, reseat_1, reseat_to_string): Initialize the
2557 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2558 when iterating on a string not from display properties).
2559 (compute_display_string_pos, compute_display_string_end):
2560 Fix calculation of the object to scan. Fixes an error when using
2562 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2563 base_level_stop; instead, set base_level_stop to BEGV.
2564 Fixes crashes in vertical-motion.
2565 (next_element_from_buffer): Improve commentary for when
2566 the iterator is before prev_stop.
2567 (init_iterator): Initialize bidi_p from the default value of
2568 bidi-display-reordering, not from buffer-local value. Use the
2569 buffer-local value only if initializing for buffer iteration.
2570 (handle_invisible_prop): Support invisible properties on strings
2571 that are being bidi-reordered.
2572 (set_iterator_to_next): Support bidi reordering of C strings and
2574 (next_element_from_string): Support bidi reordering of Lisp
2576 (handle_stop_backwards): Support Lisp strings as well.
2577 (display_string): Support display of R2L glyph rows.
2578 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2579 (init_iterator): Don't initialize it->bidi_p for strings
2581 (reseat_to_string): Initialize it->bidi_p for strings here.
2582 (next_element_from_string, next_element_from_c_string)
2583 (next_element_from_buffer): Add xassert's for correspondence
2584 between IT's object being iterated and it->bidi_it.string
2586 (face_before_or_after_it_pos): Support bidi iteration.
2587 (next_element_from_c_string): Handle the case of the first string
2588 character that is not the first one in the visual order.
2589 (get_visually_first_element): New function, refactored from common
2590 parts of next_element_from_buffer, next_element_from_string, and
2591 next_element_from_c_string.
2592 (tool_bar_lines_needed, redisplay_tool_bar)
2593 (display_menu_bar): Force left-to-right direction. Add a FIXME
2594 comment for making that be controlled by a user option.
2595 (push_it, pop_it): Save and restore the state of the
2596 bidi iterator. Save and restore the bidi_p flag.
2597 (pop_it): Iterate out of display property for string iteration as
2599 (iterate_out_of_display_property): Support iteration over strings.
2600 (handle_single_display_spec): Set up it->bidi_it for iteration
2601 over a display string, and call bidi_init_it.
2602 (handle_single_display_spec, next_overlay_string)
2603 (get_overlay_strings_1, push_display_prop): Set up the bidi
2604 iterator for displaying display or overlay strings.
2605 (forward_to_next_line_start): Don't use the shortcut if
2607 (back_to_previous_visible_line_start): If handle_display_prop
2608 pushed the iterator stack, restore the internal state of the bidi
2609 iterator by calling bidi_pop_it same number of times.
2610 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2611 and we are bidi-iterating, don't decrement the iterator position;
2612 instead, set the first_elt flag in the bidi iterator, to produce
2614 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2615 (push_display_prop): xassert that we are iterating a buffer.
2616 (push_it, pop_it): Save and restore paragraph_embedding member.
2617 (handle_single_display_spec, next_overlay_string)
2618 (get_overlay_strings_1, reseat_1, reseat_to_string)
2619 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2620 correctly. Don't assume unibyte strings are not bidi-reordered.
2621 (compute_display_string_pos)
2622 (compute_display_string_end): Fix handling the case of C string.
2623 (push_it, pop_it): Save and restore from_disp_prop_p.
2624 (handle_single_display_spec, push_display_prop): Set the
2625 from_disp_prop_p flag.
2626 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2627 (pop_it): Call iterate_out_of_display_property only if we are
2628 popping after iteration over a string that came from a display
2629 property. Fix a typo in popping stretch info. Add an assertion
2630 for verifying that the iterator position is in sync with the bidi
2632 (handle_single_display_spec, get_overlay_strings_1)
2633 (push_display_prop): Fix initialization of paragraph direction for
2634 string when that of the parent object is not yet determined.
2635 (reseat_1): Call bidi_init_it to resync the bidi
2636 iterator with IT's position. (Bug#7616)
2637 (find_row_edges): If ROW->start.pos gives position
2638 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2639 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2640 Reset the from_disp_prop_p flag.
2641 (SAVE_IT, RESTORE_IT): New macros.
2642 (pos_visible_p, face_before_or_after_it_pos)
2643 (back_to_previous_visible_line_start)
2644 (move_it_in_display_line_to, move_it_in_display_line)
2645 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2646 (try_scrolling, redisplay_window, display_line): Use them when
2647 saving a temporary copy of the iterator and restoring it back.
2648 (back_to_previous_visible_line_start, reseat_1)
2649 (init_iterator): Empty the bidi cache "stack".
2650 (move_it_in_display_line_to): If iterator ended up at
2651 EOL, but we never saw any buffer positions smaller than
2652 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2653 motion in bidi-reordered lines.
2654 (move_it_in_display_line_to): Record prev_method and prev_pos
2655 immediately before the call to set_iterator_to_next. Fixes cursor
2656 motion in bidi-reordered lines with stretch glyphs and strings
2657 displayed in margins. (Bug#8133) (Bug#8867)
2658 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2660 (pos_visible_p): Support positions in bidi-reordered lines.
2661 Save and restore bidi cache.
2663 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2664 (bidi_paragraph_info): Delete unused struct.
2665 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2666 (bidi_cache_start): New variable.
2667 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2669 (bidi_cache_fetch_state, bidi_cache_search)
2670 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2671 (bidi_cache_find, bidi_peek_at_next_level)
2672 (bidi_level_of_next_char, bidi_find_other_level_edge)
2673 (bidi_move_to_visually_next): Compare cache index with
2674 bidi_cache_start rather than with zero.
2675 (bidi_fetch_char): Accept new argument STRING; all callers
2676 changed. Support iteration over a string. Support strings with
2677 display properties. Support unibyte strings. Fix the type of
2678 `len' according to what STRING_CHAR_AND_LENGTH expects.
2679 (bidi_paragraph_init, bidi_resolve_explicit_1)
2680 (bidi_resolve_explicit, bidi_resolve_weak)
2681 (bidi_level_of_next_char, bidi_move_to_visually_next):
2682 Support iteration over a string.
2683 (bidi_set_sor_type, bidi_resolve_explicit_1)
2684 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2685 can now be zero (for strings); special values 0 and -1 were
2686 changed to -1 and -2, respectively.
2687 (bidi_char_at_pos): New function.
2688 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2689 Call it instead of FETCH_MULTIBYTE_CHAR.
2690 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2691 initialized to valid values.
2692 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2694 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2695 the test for valid cached positions. Fix the logic for looking up
2696 the sentinel state in the cache. GCPRO the Lisp string we are
2698 (bidi_push_it, bidi_pop_it): New functions.
2699 (bidi_initialize): Initialize the bidi cache start stack pointer.
2700 (bidi_cache_ensure_space): New function, refactored from part of
2701 bidi_cache_iterator_state. Don't assume the required size is just
2702 one BIDI_CACHE_CHUNK away.
2703 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2704 (bidi_count_bytes, bidi_char_at_pos): New functions.
2705 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2706 always valid if bidi_cache_idx is valid.
2707 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2708 is valid if it's going to be used.
2709 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2710 (bidi_cache_fetch_state, bidi_cache_search)
2711 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2712 (bidi_cache_iterator_state, bidi_cache_find)
2713 (bidi_find_other_level_edge, bidi_cache_start_stack):
2714 All variables related to cache indices are now EMACS_INT.
2716 * dispextern.h (struct bidi_string_data): New structure.
2717 (struct bidi_it): New member `string'. Make flag members be 1-bit
2718 fields, and put them last in the struct.
2719 (compute_display_string_pos, compute_display_string_end):
2721 (bidi_push_it, bidi_pop_it): Add prototypes.
2722 (struct iterator_stack_entry): New members bidi_p,
2723 paragraph_embedding, and from_disp_prop_p.
2724 (struct it): Member bidi_p is now a bit field 1 bit wide.
2725 (bidi_shelve_cache, bidi_unshelve_cache):
2728 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2729 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2730 and vector-like objects.
2732 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2733 cache around display iteration.
2735 * window.c (Fwindow_end, window_scroll_pixel_based)
2736 (displayed_window_lines, Frecenter): Save and restore the bidi
2737 cache around display iteration.
2739 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2741 * editfns.c (Fdelete_region): Clarify the use of the named
2742 parameters (bug#6788).
2744 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2746 * indent.c (Fvertical_motion): Set and restore w->pointm when
2747 saving and restoring the window's buffer (Bug#9006).
2749 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2751 * editfns.c (Fstring_to_char): Clarify just what is returned
2752 (bug#6576). Text by Eli Zaretskii.
2754 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2756 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2758 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2760 * buffer.c (mmap_find): Fix a typo.
2762 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2764 Fix execution of x selection hooks.
2765 * xselect.c (Qx_lost_selection_functions)
2766 (Qx_sent_selection_functions): New vars.
2767 (syms_of_xselect): DEFSYM them.
2768 (x_handle_selection_request): Pass Qx_sent_selection_functions
2769 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2770 (x_handle_selection_clear,x_clear_frame_selections):
2771 Pass Qx_lost_selection_functions rather than
2772 Vx_lost_selection_functions to Frun_hook_with_args.
2774 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2776 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2777 The old code sometimes used this field without initializing it.
2779 * alloc.c (gc_sweep): Don't read past end of array.
2780 In theory, the old code could also have corrupted Emacs internals,
2781 though it'd be very unlikely.
2783 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2785 * character.c (Fcharacterp): Don't advertise optional ignored
2786 argument. (Bug#4026)
2788 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2790 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2793 * window.c (Fset_window_start): Doc fix (bug#4199).
2794 (Fset_window_hscroll): Ditto.
2796 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2798 Fix minor new problems caught by GCC 4.6.1.
2799 * term.c (init_tty): Remove unused local.
2800 * xsettings.c (store_monospaced_changed): Define this function only
2801 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2804 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2806 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2808 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2810 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2811 are the mini-buffer and the echo area (bug#3320).
2813 * term.c (init_tty): Remove support for supdup, c10 and perq
2814 terminals, which are no longer supported (bug#1482).
2816 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2818 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2820 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2822 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2823 for non-popups (Bug#3642).
2825 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2827 * alloc.c (reset_malloc_hooks): Protoize.
2828 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2829 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2830 * cm.c (losecursor): Likewise.
2831 * data.c (fmod): Likewise.
2832 * dispnew.c (swap_glyphs_in_rows): Likewise.
2833 * emacs.c (memory_warning_signal): Likewise.
2834 * floatfns.c (float_error): Likewise.
2835 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2836 (otf_open, font_otf_capability, generate_otf_features)
2837 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2839 * image.c (pbm_read_file): Likewise.
2840 * indent.c (string_display_width): Likewise.
2841 * intervals.c (check_for_interval, search_for_interval)
2842 (inc_interval_count, count_intervals, root_interval)
2843 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2844 * lread.c (defalias): Likewise.
2845 * ralloc.c (r_alloc_check): Likewise.
2846 * regex.c (set_image_of_range_1, set_image_of_range)
2847 (regex_grow_registers): Likewise.
2848 * sysdep.c (strerror): Likewise.
2849 * termcap.c (valid_filename_p, tprint, main): Likewise.
2850 * tparam.c (main): Likewise.
2851 * unexhp9k800.c (run_time_remap, save_data_space)
2852 (update_file_ptrs, read_header, write_header, calculate_checksum)
2853 (copy_file, copy_rest, display_header): Likewise.
2854 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2856 * xdisp.c (check_it): Likewise.
2857 * xfaces.c (register_color, unregister_color, unregister_colors):
2859 * xfns.c (print_fontset_result): Likewise.
2860 * xrdb.c (member, fatal, main): Likewise.
2862 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2864 Fix minor problems found by static checking (Bug#9031).
2865 * chartab.c (char_table_set_range, map_sub_char_table):
2866 Remove unused locals.
2867 (uniprop_table): Now static.
2868 * composite.c (_work_char): Remove unused static var.
2870 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2872 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2874 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2876 * gtkutil.c (qttip_cb): Remove code without function.
2878 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2880 * w32.c (pthread_sigmask): New stub.
2882 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2884 Use pthread_sigmask, not sigprocmask (Bug#9010).
2885 sigprocmask is portable only for single-threaded applications, and
2886 Emacs can be multi-threaded when it uses GTK.
2887 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2889 * callproc.c (Fcall_process):
2890 * process.c (create_process):
2891 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2892 Use pthread_sigmask, not sigprocmask.
2894 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2896 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2897 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2900 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2902 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2903 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2904 (xg_hide_tooltip): Fix comment.
2906 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2907 in registerServicesMenuSendTypes.
2908 (validRequestorForSendType): Don't check ns_return_types.
2910 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2913 2011-07-08 Jason Rumney <jasonr@gnu.org>
2915 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2916 SH_SHOW for hidden windows (Bug#5482).
2918 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2919 frame struct members of non-existent frames (Bug#6284).
2921 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2923 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2924 variable firstTime not needed on OSX >= 10.6.
2925 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2926 >= 10.5. Use setKnobProportion, setDoubleValue.
2928 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2929 (MAC_OS_X_VERSION_10_5): Define if not defined.
2930 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2931 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2932 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2934 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2935 cString and lossyCString on OSX >= 10.4
2937 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2938 sizeToFit on OSX >= 10.2.
2940 * nsimage.m (allocInitFromFile): Don't use deprecated method
2941 bestRepresentationForDevice on OSX >= 10.6.
2943 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2946 * emacs.c: Declare unexec_init_emacs_zone.
2948 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2950 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2952 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2953 on svcsMenu (Bug#8842).
2955 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2957 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2959 * nsterm.m (QUTF8_STRING): Declare.
2960 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2961 (validRequestorForSendType): Return type is (id).
2962 Change indexOfObjectIdenticalTo to indexOfObject.
2963 Check if we have local selection before returning self (Bug#8842).
2964 (writeSelectionToPasteboard): Put local selection into paste board
2965 if we have a local selection (Bug#8842).
2966 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2968 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2969 (ns_get_local_selection): Declare.
2971 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2973 * keymap.c (describe_map_tree): Don't insert a double newline at
2974 the end of the buffer (bug#1169) and return whether we inserted
2977 * callint.c (Fcall_interactively): Change "reading args" to
2978 "providing args" to try to clarify what it does (bug#1010).
2980 2011-07-07 Kenichi Handa <handa@m17n.org>
2982 * composite.c (composition_compute_stop_pos): Ignore a static
2983 composition starting before CHARPOS (Bug#8915).
2985 * xdisp.c (handle_composition_prop): Likewise.
2987 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2989 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2992 2011-07-07 Kenichi Handa <handa@m17n.org>
2994 * character.h (unicode_category_t): New enum type.
2996 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2997 (Qchar_code_property_table): New variable.
2998 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2999 (UNIPROP_COMPRESSED_FORM_P): New macros.
3000 (char_table_ascii): Uncompress the compressed values.
3001 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3002 Uncompress the compressed values.
3003 (sub_char_table_ref_and_range): Likewise.
3004 (char_table_ref_and_range): Uncompress the compressed values.
3005 (sub_char_table_set): New arg is_uniprop. Callers changed.
3006 Uncompress the compressed values.
3007 (sub_char_table_set_range): Args changed. Callers changed.
3008 (char_table_set_range): Adjuted for the above change.
3009 (map_sub_char_table): Delete args default_val and parent. Add arg
3010 top. Give decoded values to a Lisp function.
3011 (map_char_table): Adjust for the above change. Give decoded
3012 values to a Lisp function. Gcpro more variables.
3013 (uniprop_table_uncompress)
3014 (uniprop_decode_value_run_length): New functions.
3015 (uniprop_decoder, uniprop_decoder_count): New variables.
3016 (uniprop_get_decoder, uniprop_encode_value_character)
3017 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3019 (uniprop_encoder, uniprop_encoder_count): New variables.
3020 (uniprop_get_encoder, uniprop_table)
3021 (Funicode_property_table_internal, Fget_unicode_property_internal)
3022 (Fput_unicode_property_internal): New functions.
3023 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3024 Sunicode_property_table_internal, Sget_unicode_property_internal,
3025 and Sput_unicode_property_internal. Defvar_lisp
3026 char-code-property-alist.
3028 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3029 Vunicode_category_table.
3031 * font.c (font_range): Adjust for the change of
3032 Vunicode_category_table.
3034 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3036 * m/iris4d.h: Remove file, move contents ...
3037 * s/irix6-5.h: ... here.
3039 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3041 Remove unportable assumption about struct layout (Bug#8884).
3042 * alloc.c (mark_buffer):
3043 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3044 (clone_per_buffer_values): Don't assume that
3045 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3046 This isn't true in general, and it's particularly not true
3047 if Emacs is configured with --with-wide-int.
3048 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3049 New macros, used in the buffer.c change.
3051 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3053 * xsettings.c: Use both GConf and GSettings if both are available.
3054 (store_config_changed_event): Add comment.
3055 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3056 (store_tool_bar_style_changed): New functions.
3057 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3058 (struct xsettings): Move font inside HAVE_XFT.
3059 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3060 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3061 Move inside HAVE_XFT.
3062 (something_changed_gsettingsCB): Rename from something_changedCB.
3063 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3065 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3066 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3067 (something_changed_gconfCB): Rename from something_changedCB.
3068 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3069 (parse_settings): Move check for font inside HAVE_XFT.
3070 (read_settings, apply_xft_settings): Add comment.
3071 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3072 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3073 call store_font_name_changed.
3074 (xft_settings_event): Add comment.
3075 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3076 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3077 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3078 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3079 (xsettings_initialize): Call init_gsettings last.
3080 (xsettings_get_system_font, xsettings_get_system_normal_font):
3083 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3085 Random fixes. E.g., (random) never returned negative values.
3086 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3087 subseconds part to the entropy, as that's a bit more random.
3088 Prefer signed to unsigned, since the signedness doesn't matter and
3089 in general we prefer signed. When given a limit, use a
3090 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3091 latter isn't right if USE_2_TAGS_FOR_INTS.
3092 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3093 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3095 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3097 * textprop.c (text_property_stickiness):
3098 Obey Vtext_property_default_nonsticky.
3099 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3100 * w32fns.c (syms_of_w32fns):
3101 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3103 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3105 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3106 This is more efficient than Ffile_directory_p and avoids a minor race.
3108 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3110 * buffer.c (Foverlay_put): Say what the return value is
3113 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3114 is a directory before asking whether to use the file name
3116 (barf_or_query_if_file_exists): Make the "File is a directory"
3117 error be more correct.
3119 * fns.c (Frequire): Remove the mention of the .gz files, since
3120 that's installation-specific, but keep the mention of
3121 `get-load-suffixes'.
3123 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3125 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3126 Report string overflow if the output is too long.
3128 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3130 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3131 (syms_of_gnutls): Remove duplicate DEFSYM for
3132 Qgnutls_bootprop_verify_hostname_error, an error for
3133 Qgnutls_bootprop_verify_error (which is no longer used).
3135 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3136 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3137 Also (re)move comments that are misplaced or no longer relevant.
3139 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3141 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3143 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3145 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3146 and background color parameters if they have been changed.
3148 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3150 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3152 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3154 * xsettings.c (SYSTEM_FONT): Define only when used.
3155 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3157 * keymap.c (access_keymap_1): Now static.
3159 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3161 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3162 leave any prefix arg for the up event (Bug#1586).
3164 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3166 * lread.c (syms_of_lread): Mention single symbols defined by
3167 `defvar' or `defconst' (bug#7154).
3169 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3170 (Frequire): Mention get-load-suffixes.
3172 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3174 * window.h (window): Remove clone_number slot.
3175 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3177 (make_parent_window, make_window, saved_window)
3178 (Fset_window_configuration, save_window_save): Don't deal with
3180 * buffer.c (Qclone_number): Remove declaration.
3181 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3183 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3185 Add multiple inheritance to keymaps.
3186 * keymap.c (Fmake_composed_keymap): New function.
3187 (Fset_keymap_parent): Simplify.
3188 (fix_submap_inheritance): Remove.
3189 (access_keymap_1): New function extracted from access_keymap to handle
3190 embedded parents and handle lists of maps.
3191 (access_keymap): Use it.
3192 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3193 (Fcopy_keymap): Handle embedded parents.
3194 (Fcommand_remapping, define_as_prefix): Simplify.
3195 (Fkey_binding): Simplify.
3196 (syms_of_keymap): Move minibuffer-local-completion-map,
3197 minibuffer-local-filename-completion-map,
3198 minibuffer-local-must-match-map, and
3199 minibuffer-local-filename-must-match-map to Elisp.
3200 (syms_of_keymap): Defsubr make-composed-keymap.
3201 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3202 (parse_menu_item): Trivial simplification.
3204 2011-07-01 Glenn Morris <rgm@gnu.org>
3206 * Makefile.in (SETTINGS_LIBS): Fix typo.
3208 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3210 * coding.c (Fencode_coding_string): Record the last coding system
3211 used, as the function doc string says (bug#8738).
3213 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3215 * xsettings.c (store_monospaced_changed): Take new font as arg and
3216 check for change against current_mono_font.
3217 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3218 (emacs_settings_constructor, emacs_settings_get_property)
3219 (emacs_settings_set_property, emacs_settings_class_init)
3220 (emacs_settings_init, gsettings_obj): Remove.
3221 (something_changedCB): New function for HAVE_GSETTINGS.
3222 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3223 with value as argument.
3224 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3225 g_settings_new (Bug#8967). Do not create gsettings_obj.
3226 Remove calls to g_settings_bind. Connect something_changedCB to
3229 * xgselect.c: Add defined (HAVE_GSETTINGS).
3230 (xgselect_initialize): Ditto.
3232 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3233 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3236 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3238 * eval.c (struct backtrace): Simplify and port the data structure.
3239 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3240 signed bit field, as this assumption is not portable and it makes
3241 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3242 "char debug_on_exit : 1" as this is not portable either; instead,
3243 use the portable "unsigned int debug_on_exit : 1". Remove unused
3244 member evalargs. Remove obsolete comments about cc bombing out.
3246 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3248 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3249 Let HAVE_GSETTINGS override HAVE_GCONF.
3250 (store_monospaced_changed): New function.
3251 (EMACS_SETTINGS): A new type derived from GObject to handle
3252 GSettings notifications.
3253 (emacs_settings_constructor, emacs_settings_get_property)
3254 (emacs_settings_set_property, emacs_settings_class_init):
3256 (gsettings_client, gsettings_obj): New variables.
3257 (GSETTINGS_SCHEMA): New define.
3258 (something_changedCB): Call store_monospaced_changed.
3259 (init_gsettings): New function.
3260 (xsettings_initialize): Call init_gsettings.
3261 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3264 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3267 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3269 * window.c (resize_root_window, grow_mini_window)
3270 (shrink_mini_window): Rename Qresize_root_window to
3271 Qwindow_resize_root_window and Qresize_root_window_vertically to
3272 Qwindow_resize_root_window_vertically.
3274 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3276 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3278 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3280 * makefile.w32-in: Redesign dependencies so they reflect more
3281 clearly which files are directly included by each source file,
3282 and not through other includes.
3284 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3286 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3287 (sort_overlays, overlay_strings): When an overlay's clone number
3288 matches the window's clone number process the overlay even if
3289 the overlay's window property doesn't match the current window.
3291 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3292 (Fwindow_hchild): Rename to Fwindow_left_child.
3293 (Fwindow_next): Rename to Fwindow_next_sibling.
3294 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3295 (resize_window_check): Rename to window_resize_check.
3296 (resize_window_apply): Rename to window_resize_apply.
3297 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3298 (Fdelete_other_windows_internal, resize_frame_windows)
3299 (Fsplit_window_internal, Fdelete_window_internal)
3300 (grow_mini_window, shrink_mini_window)
3301 (Fresize_mini_window_internal): Fix callers accordingly.
3303 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3305 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3306 (emacs_fixed_set_min_size): Remove.
3307 (emacs_fixed_new): Take frame as argument.
3309 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3310 (_EmacsFixedPrivate): Remove minwidth/height.
3311 Add struct frame *f.
3312 (emacs_fixed_init): Initialize priv->f.
3313 (get_parent_class, emacs_fixed_set_min_size): Remove.
3314 (emacs_fixed_new): Set priv->f to argument.
3315 (emacs_fixed_get_preferred_width)
3316 (emacs_fixed_get_preferred_height): Use min_width/height from
3317 frames size_hint to set minimum and natural (Bug#8919).
3318 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3319 and use min_width/height from frames size_hint to set
3320 min_width/height (Bug#8919).
3322 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3323 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3326 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3328 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3329 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3332 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3334 * process.c (wait_reading_process_output): Bypass select if
3335 waiting for a cell while ignoring keyboard input, and input is
3336 pending. Suggested by Jan Djärv (Bug#8869).
3338 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3340 Use gnulib's dup2 module instead of rolling our own.
3341 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3343 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3345 * dispnew.c (scrolling_window): Before scrolling, turn off a
3346 mouse-highlight in the window being scrolled.
3348 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3350 Move DEFSYM to lisp.h and use everywhere.
3352 * character.h (DEFSYM): Move declaration...
3353 * lisp.h (DEFSYM): ...here.
3359 * w32select.c: Don't include character.h.
3361 * alloc.c (syms_of_alloc):
3362 * buffer.c (syms_of_buffer):
3363 * bytecode.c (syms_of_bytecode):
3364 * callint.c (syms_of_callint):
3365 * casefiddle.c (syms_of_casefiddle):
3366 * casetab.c (init_casetab_once):
3367 * category.c (init_category_once, syms_of_category):
3368 * ccl.c (syms_of_ccl):
3369 * cmds.c (syms_of_cmds):
3370 * composite.c (syms_of_composite):
3371 * dbusbind.c (syms_of_dbusbind):
3372 * dired.c (syms_of_dired):
3373 * dispnew.c (syms_of_display):
3374 * doc.c (syms_of_doc):
3375 * editfns.c (syms_of_editfns):
3376 * emacs.c (syms_of_emacs):
3377 * eval.c (syms_of_eval):
3378 * fileio.c (syms_of_fileio):
3379 * fns.c (syms_of_fns):
3380 * frame.c (syms_of_frame):
3381 * fringe.c (syms_of_fringe):
3382 * insdel.c (syms_of_insdel):
3383 * keymap.c (syms_of_keymap):
3384 * lread.c (init_obarray, syms_of_lread):
3385 * macros.c (syms_of_macros):
3386 * msdos.c (syms_of_msdos):
3387 * print.c (syms_of_print):
3388 * process.c (syms_of_process):
3389 * search.c (syms_of_search):
3390 * sound.c (syms_of_sound):
3391 * syntax.c (init_syntax_once, syms_of_syntax):
3392 * terminal.c (syms_of_terminal):
3393 * textprop.c (syms_of_textprop):
3394 * undo.c (syms_of_undo):
3395 * w32.c (globals_of_w32):
3396 * window.c (syms_of_window):
3397 * xdisp.c (syms_of_xdisp):
3398 * xfaces.c (syms_of_xfaces):
3399 * xfns.c (syms_of_xfns):
3400 * xmenu.c (syms_of_xmenu):
3401 * xsettings.c (syms_of_xsettings):
3402 * xterm.c (syms_of_xterm): Use DEFSYM.
3404 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3406 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3408 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3410 Integer and buffer overflow fixes (Bug#8873).
3412 * print.c (printchar, strout): Check for string overflow.
3413 (PRINTPREPARE, printchar, strout):
3414 Don't set size unless allocation succeeds.
3416 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3417 for sizes. Check for string overflow more accurately.
3418 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3420 * macros.c: Integer and buffer overflow fixes.
3421 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3422 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3423 Use ptrdiff_t, not int, for sizes.
3424 Don't increment bufsize until after realloc succeeds.
3425 Check for size-calculation overflow.
3426 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3428 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3430 * lread.c: Integer overflow fixes.
3431 (read_integer): Radix is now EMACS_INT, not int,
3432 to improve quality of diagnostics for out-of-range radices.
3433 Calculate buffer size correctly for out-of-range radices.
3434 (read1): Check for integer overflow in radices, and in
3435 read-circle numbers.
3436 (read_escape): Avoid int overflow.
3437 (Fload, openp, read_buffer_size, read1)
3438 (substitute_object_recurse, read_vector, read_list, map_obarray):
3439 Use ptrdiff_t, not int, for sizes.
3440 (read1): Use EMACS_INT, not int, for sizes.
3441 Check for size overflow.
3443 * image.c (cache_image): Check for size arithmetic overflow.
3445 * lread.c: Integer overflow issues.
3446 (saved_doc_string_size, saved_doc_string_length)
3447 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3448 Now ptrdiff_t, not int.
3449 (read1): Don't assume doc string length fits in int. Check for
3450 out-of-range doc string lengths.
3451 (read_list): Don't assume file position fits in int.
3452 (read_escape): Check for hex character overflow.
3454 2011-06-22 Leo Liu <sdl.web@gmail.com>
3456 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3457 Move to minibuffer.el.
3459 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3461 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3462 The following patches are for when GLYPH_DEBUG && !XASSERT.
3463 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3464 * dispnew.c (flush_stdout):
3465 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3466 Mark as externally visible.
3467 * dispnew.c (check_window_matrix_pointers): Now static.
3468 * dispnew.c (window_to_frame_vpos):
3469 * xfns.c (unwind_create_frame):
3470 * xterm.c (x_check_font): Remove unused local.
3471 * scroll.c (CHECK_BOUNDS):
3472 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3473 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3474 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3475 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3476 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3478 (debug_method_add): Use va_list and vsprintf rather than relying
3479 on undefined behavior with wrong number of arguments.
3480 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3481 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3482 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3483 since we're not interested in debugging glyphs with old libraries.
3484 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3485 GCC 4.6.0's static checking.
3487 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3489 Integer overflow and signedness fixes (Bug#8873).
3490 A few related buffer overrun fixes, too.
3492 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3494 * dispextern.h (struct face.stipple):
3495 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3496 (x_bitmap_mask, x_allocate_bitmap_record)
3497 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3498 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3499 (x_create_bitmap_from_xpm_data):
3500 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3501 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3503 * xfaces.c (load_pixmap):
3504 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3505 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3506 (.bitmaps_last, struct x_output.icon_bitmap):
3507 Use ptrdiff_t, not int, for bitmap indexes.
3508 (x_allocate_bitmap_record): Check for size overflow.
3509 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3511 Use ptrdiff_t, not int, for overlay counts.
3512 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3513 * editfns.c (overlays_around, get_pos_property):
3514 * textprop.c (get_char_property_and_overlay):
3515 * xdisp.c (next_overlay_change, note_mouse_highlight):
3516 * xfaces.c (face_at_buffer_position):
3517 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3518 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3519 (Fnext_overlay_change, Fprevious_overlay_change)
3520 (mouse_face_overlay_overlaps, Foverlays_in):
3521 Use ptrdiff_t, not int, for sizes.
3522 (overlays_at, overlays_in): Check for size-calculation overflow.
3524 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3526 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3527 (x_session_initialize): Do not assume string length fits in int.
3529 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3530 This is unlikely, but can occur if DPI is outlandish.
3532 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3533 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3535 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3536 * xrdb.c (magic_file_p, search_magic_path):
3537 Omit last arg SUFFIX; it was always 0. All callers changed.
3538 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3540 * xfont.c (xfont_match): Avoid need for strlen.
3542 * xfns.c: Don't assume strlen fits in int.
3543 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3545 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3546 not unsigned long, as we prefer signed integers. All callers changed.
3547 Detect integer overflow in repeat count.
3548 (message_dolog): Don't assume print length fits in 39 bytes.
3549 (display_mode_element): Don't assume strlen fits in int.
3551 * termcap.c: Don't assume sizes fit in int and never overflow.
3552 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3553 (gobble_line): Check for size-calculation overflow.
3555 * minibuf.c (Fread_buffer):
3556 * lread.c (intern, intern_c_string):
3557 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3558 Don't assume string length fits in int.
3560 * keyboard.c (parse_tool_bar_item):
3561 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3563 * font.c: Don't assume string length fits in int.
3564 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3565 Use ptrdiff_t, not int.
3566 (font_intern_prop): Don't assume string length fits in int.
3567 Don't assume integer property fits in fixnum.
3568 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3570 * filelock.c: Fix some buffer overrun and integer overflow issues.
3571 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3572 Reformulate so as not to need the command string.
3573 Invoke gzip -cd rather than gunzip, as it's more portable.
3574 (lock_info_type, lock_file_1, lock_file):
3575 Don't assume pid_t and time_t fit in unsigned long.
3576 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3577 (current_lock_owner): Prefer signed type for sizes.
3578 Use memcpy, not strncpy, where memcpy is what is really wanted.
3579 Don't assume (via atoi) that time_t and pid_t fit in int.
3580 Check for time_t and/or pid_t out of range, e.g., via a network share.
3581 Don't alloca where an auto var works fine.
3583 * fileio.c: Fix some integer overflow issues.
3584 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3585 Don't assume string length fits in int.
3586 (directory_file_name): Don't assume string length fits in long.
3587 (make_temp_name): Don't assume pid fits in int, or that its print
3588 length is less than 20.
3590 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3592 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3594 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3596 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3597 We prefer signed integers, even for size calculations.
3599 * emacs.c: Don't assume string length fits in 'int'.
3600 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3601 (main): Don't invoke strlen when not needed.
3603 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3604 (XD_DEBUG_MESSAGE): Don't waste a byte.
3606 * callproc.c (getenv_internal_1, getenv_internal)
3608 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3610 * lread.c (invalid_syntax): Omit length argument.
3611 All uses changed. This doesn't fix a bug, but it simplifies the
3612 code away from its former Hollerith-constant appearance, and it's
3613 one less 'int' to worry about when looking at integer-overflow issues.
3614 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3616 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3617 This didn't break anything, but it didn't help either.
3618 It's confusing to put a bogus integer in a place where the actual
3619 value does not matter.
3620 (LIST_END_P): Remove unused macro and its bogus comment.
3621 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3623 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3624 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3626 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3627 We prefer signed types, and the value cannot exceed the EMACS_INT
3628 range anyway (because otherwise the length would not be representable).
3629 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3630 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3631 This avoids a GCC warning when WIDE_EMACS_INT.
3633 * indent.c (sane_tab_width): New function.
3634 (current_column, scan_for_column, Findent_to, position_indentation)
3635 (compute_motion): Use it. This is just for clarity.
3636 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3638 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3640 * lisp.h (lint_assume): New macro.
3641 * composite.c (composition_gstring_put_cache):
3642 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3644 * editfns.c, insdel.c:
3645 Omit unnecessary forward decls, to simplify future changes.
3647 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3649 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3651 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3652 Use much-faster test for byte-length change.
3653 Don't assume string byte-length fits in 'int'.
3654 Check that character arg fits in 'int'.
3655 (mapcar1): Declare byte as byte, for clarity.
3657 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3659 * fns.c (concat): Catch string overflow earlier.
3660 Do not rely on integer wraparound.
3662 * dispextern.h (struct it.overlay_strings_charpos)
3663 (struct it.selective): Now EMACS_INT, not int.
3664 * xdisp.c (forward_to_next_line_start)
3665 (back_to_previous_visible_line_start)
3666 (reseat_at_next_visible_line_start, next_element_from_buffer):
3667 Don't arbitrarily truncate the value of 'selective' to int.
3669 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3671 * composite.c: Don't truncate sizes to 'int'.
3672 (composition_gstring_p, composition_reseat_it)
3673 (composition_adjust_point): Use EMACS_INT, not int.
3674 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3675 not EMACS_UINT, for indexes.
3677 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3679 * buffer.c: Include <verify.h>.
3680 (struct sortvec.priority, struct sortstr.priority):
3681 Now EMACS_INT, not int.
3682 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3683 (struct sortstr.size, record_overlay_string)
3684 (struct sortstrlist.size, struct sortlist.used):
3685 Don't truncate size to int.
3686 (record_overlay_string): Check for size-calculation overflow.
3687 (init_buffer_once): Check at compile-time, not run-time.
3689 2011-06-22 Jim Meyering <meyering@redhat.com>
3691 Don't leak an XBM-image-sized buffer
3692 * image.c (xbm_load): Free the image buffer after using it.
3694 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3697 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3698 that Sun C diagnosed.
3699 * fns.c (secure_hash): Fix pointer signedness issue.
3700 * intervals.c (static_offset_intervals): New function.
3701 (offset_intervals): Use it.
3703 2011-06-21 Leo Liu <sdl.web@gmail.com>
3706 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3709 * fns.c (secure_hash): Rename from crypto_hash_function and change
3710 the first arg to accept symbols.
3711 (Fsecure_hash): New primitive.
3712 (syms_of_fns): New symbols.
3714 2011-06-20 Deniz Dogan <deniz@dogan.se>
3716 * process.c (Fset_process_buffer): Clarify return value in
3719 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3721 * dispnew.c (add_window_display_history): Use BVAR.
3723 * xdisp.c (debug_method_add): Use BVAR.
3724 (check_window_end, dump_glyph_matrix, dump_glyph)
3725 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3727 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3730 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3731 check till after the cache is created in init_frame_faces.
3733 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3735 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3737 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3739 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3740 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3741 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3743 Improve buffer-overflow checking (Bug#8873).
3744 * fileio.c (Finsert_file_contents):
3745 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3746 Remove the old (too-loose) buffer overflow checks.
3747 They weren't needed, since make_gap checks for buffer overflow.
3748 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3749 The old code merely checked for Emacs fixnum overflow, and relied
3750 on undefined (wraparound) behavior. The new code avoids undefined
3751 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3753 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3754 Tune. Don't use wider integers than needed. Don't use alloca.
3755 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3757 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3759 * insdel.c, lisp.h (buffer_overflow): New function.
3760 (insert_from_buffer_1, replace_range, replace_range_2):
3761 * insdel.c (make_gap_larger):
3762 * editfns.c (Finsert_char):
3763 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3765 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3767 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3769 Integer overflow and signedness fixes (Bug#8873).
3771 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3772 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3774 * fileio.c: Don't assume EMACS_INT fits in off_t.
3775 (emacs_lseek): New static function.
3776 (Finsert_file_contents, Fwrite_region): Use it.
3777 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3779 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3781 * fns.c: Don't overflow int when computing a list length.
3782 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3783 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3784 truncation on 64-bit hosts. Check for QUIT every
3785 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3786 faster and is responsive enough.
3787 (Flength): Report an error instead of overflowing an integer.
3788 (Fsafe_length): Return a float if the value is not representable
3789 as a fixnum. This shouldn't happen except in contrived situations.
3790 (Fnthcdr, Fsort): Don't assume list length fits in int.
3791 (Fcopy_sequence): Don't assume vector length fits in int.
3793 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3794 (header_size, word_size): New constants.
3795 (allocate_vectorlike): Don't check size overflow here.
3796 (allocate_vector): Check it here instead, since this is the only
3797 caller of allocate_vectorlike that could cause overflow.
3798 Check that the new vector's length is representable as a fixnum.
3800 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3801 The previous code was bogus. For example, next_almost_prime (32)
3802 returned 39, which is undesirable as it is a multiple of 3; and
3803 next_almost_prime (24) returned 25, which is a multiple of 5 so
3804 why was the code bothering to check for multiples of 7?
3806 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3808 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3810 Variadic C functions now count arguments with ptrdiff_t.
3811 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3812 Back then I didn't know that the Emacs coding style prefers signed int.
3813 Also, in the meantime I found a few more instances where arguments
3814 were being counted with int, which may truncate counts on 64-bit
3815 machines, or EMACS_INT, which may be unnecessarily wide.
3816 * lisp.h (struct Lisp_Subr.function.aMANY)
3817 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3818 Arg counts are now ptrdiff_t, not size_t.
3819 All variadic functions and their callers changed accordingly.
3820 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3821 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3822 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3823 * callint.c (Fcall_interactively): Check arg count for overflow,
3824 to avoid potential buffer overrun. Use signed char, not 'int',
3825 for 'varies' array, so that we needn't bother to check its size
3826 calculation for overflow.
3827 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3828 * eval.c (apply_lambda):
3829 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3830 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3831 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3833 * callint.c (Fcall_interactively): Don't use index var as event count.
3835 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3836 * mem-limits.h (SIZE): Remove; no longer used.
3838 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3840 Remove unnecessary casts.
3841 * xterm.c (x_term_init):
3842 * xfns.c (x_set_border_pixel):
3843 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3844 These aren't needed now that we assume ANSI C.
3846 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3847 It's more likely to cause problems (due to unsigned overflow)
3850 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3852 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3854 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3856 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3858 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3860 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3862 GLYPH_CODE_FACE returns EMACS_INT, not int.
3863 * dispextern.h (merge_faces):
3864 * xfaces.c (merge_faces):
3865 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3866 Don't assume EMACS_INT fits in int.
3868 * character.h (CHAR_VALID_P): Remove unused parameter.
3869 * fontset.c, lisp.h, xdisp.c: All uses changed.
3871 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3873 * fns.c (concat): Minor tuning based on overflow analysis.
3874 This doesn't fix any bugs. Use int to hold character, instead
3875 of constantly refetching from Emacs object. Use XFASTINT, not
3876 XINT, for value known to be a character. Don't bother comparing
3877 a single byte to 0400, as it's always less.
3879 * floatfns.c (Fexpt):
3880 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3882 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3885 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3887 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3888 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3889 incorrectly succeed when S was a string, because 4294967386 was
3890 truncated before it was used.
3892 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3893 Otherwise, an out-of-range integer could cause undefined behavior
3896 * composite.c: Use int, not EMACS_INT, for characters.
3897 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3898 EMACS_INT, for values that are known to be in character range.
3899 This doesn't fix any bugs but is the usual style inside Emacs and
3900 may generate better code on 32-bit machines.
3902 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3903 This is for reasons similar to the recent CHAR_STRING fix.
3904 * charset.c (Fencode_char): Check that character arg is actually
3905 a character. Pass an int to ENCODE_CHAR.
3906 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3907 wider than 'int', as a compile-time check to prevent future regressions
3910 * character.c (char_string): Remove unnecessary casts.
3912 Make sure a 64-bit char is never passed to CHAR_STRING.
3913 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3914 by silently ignoring the top 32 bits, allowing some values
3915 that were far too large to be valid characters.
3916 * character.h: Include <verify.h>.
3917 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3918 arguments are no wider than unsigned, as a compile-time check
3919 to prevent future regressions in this area.
3921 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3922 (Fsubst_char_in_region):
3924 * xdisp.c (decode_mode_spec_coding):
3925 Adjust to CHAR_STRING's new requirement.
3926 * editfns.c (Finsert_char, Fsubst_char_in_region):
3927 * fns.c (concat): Check that character args are actually
3928 characters. Without this test, these functions did the wrong
3929 thing with wildly out-of-range values on 64-bit hosts.
3931 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3932 These casts should not be needed on 32-bit hosts, either.
3933 * keyboard.c (read_char):
3934 * lread.c (Fload): Remove casts to unsigned.
3936 * lisp.h (UNSIGNED_CMP): New macro.
3937 This fixes comparison bugs on 64-bit hosts.
3938 (ASCII_CHAR_P): Use it.
3939 * casefiddle.c (casify_object):
3940 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3941 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3942 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3943 * dispextern.h (FACE_FROM_ID):
3944 * keyboard.c (read_char): Use UNSIGNED_CMP.
3946 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3947 not to EMACS_INT, to avoid GCC warning.
3949 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3951 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3952 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3953 isn't needed on 32-bit machines.
3955 * buffer.c (Fgenerate_new_buffer_name):
3956 Use EMACS_INT for count, not int.
3957 (advance_to_char_boundary): Return EMACS_INT, not int.
3959 * data.c (Qcompiled_function): Now static.
3961 * window.c (window_body_lines): Now static.
3963 * image.c (gif_load): Rename local to avoid shadowing.
3965 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3966 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3967 * alloc.c (make_save_value): Integer argument is now of type
3969 (mark_object): Use ptrdiff_t, not int.
3970 * lisp.h (pD): New macro.
3971 * print.c (print_object): Use it.
3973 * alloc.c: Use EMACS_INT, not int, to count objects.
3974 (total_conses, total_markers, total_symbols, total_vector_size)
3975 (total_free_conses, total_free_markers, total_free_symbols)
3976 (total_free_floats, total_floats, total_free_intervals)
3977 (total_intervals, total_strings, total_free_strings):
3978 Now EMACS_INT, not int. All uses changed.
3979 (Fgarbage_collect): Compute overall total using a double, so that
3980 integer overflow is less likely to be a problem. Check for overflow
3981 when converting back to an integer.
3982 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3983 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3984 These were 'int' variables that could overflow on 64-bit hosts;
3985 they were never used, so remove them instead of repairing them.
3986 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3987 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3988 Previously, this ceilinged at INT_MAX, but that doesn't work on
3990 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3992 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3993 (allocate_vectorlike): Check for ptrdiff_t overflow.
3994 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3995 when a (possibly-narrower) signed value would do just as well.
3996 We prefer using signed arithmetic, to avoid comparison confusion.
3998 * alloc.c: Catch some string size overflows that we were missing.
3999 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4000 for convenience in STRING_BYTES_MAX.
4001 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4002 The definition here is exact; the one in lisp.h was approximate.
4003 (allocate_string_data): Check for string overflow. This catches
4004 some instances we weren't catching before. Also, it catches
4005 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4006 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4007 and ptrdiff_t and EMACS_INT are both 64 bits.
4009 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4010 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4011 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4013 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4015 * alloc.c (Fmake_string): Check for out-of-range init.
4017 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4019 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4021 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4023 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4024 xg_get_default_scrollbar_width.
4026 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4027 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4028 (style_changed_cb): Call update_theme_scrollbar_width and call
4029 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4030 all frames (Bug#8505).
4031 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4032 Call gtk_window_set_resizable if HAVE_GTK3.
4033 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4034 and height if HAVE_GTK3 (Bug#8505).
4035 (scroll_bar_width_for_theme): New variable.
4036 (update_theme_scrollbar_width): New function.
4037 (xg_get_default_scrollbar_width): Move code to
4038 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4039 (xg_initialize): Call update_theme_scrollbar_width.
4041 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4043 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4045 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4047 * frame.c (make_frame): Call other_buffer_safely instead of
4050 * window.c (temp_output_buffer_show): Call display_buffer with
4051 second argument Vtemp_buffer_show_specifiers and reset latter
4052 immediately after the call.
4053 (Vtemp_buffer_show_specifiers): New variable.
4054 (auto_window_vscroll_p, next_screen_context_lines)
4055 (Vscroll_preserve_screen_position): Remove leading asterisks from
4058 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4060 Fix minor problems found by GCC 4.6.0 static checking.
4061 * buffer.c (Qclone_number): Remove for now, as it's unused.
4062 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4063 (record_buffer): Remove unused local.
4064 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4065 (set_frame_buffer_list): Remove; unused.
4066 * frame.h (other_visible_frames): Remove decl.
4067 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4068 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4069 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4071 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4072 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4073 Define only if HAVE_GPM.
4074 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4075 (update_hints_inhibit): Remove; never set. All uses removed.
4076 * widgetprv.h (emacsFrameClassRec): Remove decl.
4077 * window.c (delete_deletable_window): Now returns void, since it
4078 wasn't returning anything.
4079 (compare_window_configurations): Remove unused locals.
4080 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4081 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4082 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4083 the same widths as pointers. This follows up on the 2011-05-06 patch.
4084 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4085 * xterm.h: Likewise.
4086 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4088 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4090 * makefile.w32-in: Update dependencies.
4091 (LISP_H): Add lib/intprops.h.
4093 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4095 * image.c (gif_load): Add animation frame delay to the metadata.
4096 (syms_of_image): Use DEFSYM. New symbol `delay'.
4098 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4100 * window.c (delete_deletable_window): Re-add.
4101 (Fset_window_configuration): Rewrite to handle dead buffers and
4102 consequently deletable windows.
4103 (window_tree, Fwindow_tree): Remove. Supply functionality in
4105 (compare_window_configurations): Simplify code.
4107 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4109 * image.c (imagemagick_load_image): Fix type mismatch.
4110 (Fimagemagick_types): Likewise.
4112 * window.h (replace_buffer_in_windows): Declare.
4114 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4116 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4117 Qclone_number. Remove external declaration of Qdelete_window.
4118 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4120 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4121 Run Qbuffer_list_update_hook if allowed.
4122 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4123 buffer list implementation.
4124 (other_buffer_safely): New function.
4125 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4126 calls to replace_buffer_in_windows and
4127 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4129 (record_buffer): Inhibit quitting and rewrite using quittable
4130 functions. Run Qbuffer_list_update_hook if allowed.
4131 (Frecord_buffer, Funrecord_buffer): New functions.
4132 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4133 Move switch-to-buffer to window.el.
4134 (bury-buffer): Move to window.el.
4135 (Vbuffer_list_update_hook): New variable.
4137 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4140 * window.h (resize_frame_windows): Move up in code.
4141 (Fwindow_frame): Remove EXFUN.
4142 (replace_buffer_in_all_windows): Remove prototype.
4143 (replace_buffer_in_windows_safely): Add prototype.
4145 * window.c: Declare Qdelete_window static again. Move down
4146 declaration of select_count.
4147 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4148 (Fother_window): Move to window.el.
4149 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4150 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4151 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4153 (replace_buffer_in_windows): Implement by calling
4154 Qreplace_buffer_in_windows.
4155 (replace_buffer_in_all_windows): Remove with some functionality
4156 moved into replace_buffer_in_windows_safely.
4157 (replace_buffer_in_windows_safely): New function.
4158 (select_window_norecord, select_frame_norecord): Move in front
4159 of run_window_configuration_change_hook. Remove now obsolete
4161 (Fset_window_buffer): Rewrite doc-string.
4162 Call Qrecord_window_buffer.
4163 (keys_of_window): Move binding for other-window to window.el.
4165 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4167 * dispextern.h (struct image): Replace data member, whose int_val
4168 and ptr_val fields were not used by anything, with a single
4171 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4172 (gif_clear_image, gif_load, imagemagick_load_image)
4173 (gs_clear_image, gs_load): Callers changed.
4175 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4177 * buffer.h: Include <time.h>, for time_t.
4178 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4180 Fix minor problems found by static checking.
4182 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4184 Make identifiers static if they are not used in other modules.
4185 * data.c (Qcompiled_function, Qframe, Qvector):
4186 * image.c (QimageMagick, Qsvg):
4187 * minibuf.c (Qmetadata):
4188 * window.c (resize_window_check, resize_root_window): Now static.
4189 * window.h (resize_window_check, resize_root_window): Remove decls.
4191 * window.c (window_deletion_count, delete_deletable_window):
4193 (window_body_lines): Now static.
4194 (Fdelete_other_windows_internal): Mark vars as initialized.
4195 Make sure 'resize_failed' is initialized.
4196 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4197 (resize_window_apply): Remove unused local.
4198 * window.h (delete_deletable_window): Remove decl.
4200 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4201 (imagemagick_load_image): Fix pointer signedness problem by changing
4202 last arg from unsigned char * to char *. All uses changed.
4203 Also, fix a local for similar reasons.
4204 Remove unused locals. Remove locals to avoid shadowing.
4205 (fn_rsvg_handle_free): Remove; unused.
4206 (svg_load, svg_load_image): Fix pointer signedness problem.
4207 (imagemagick_load_image): Don't use garbage pointer image_wand.
4209 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4211 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4213 * image.c (gif_load): Fix omitted cast error introduced by
4216 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4218 * window.h (resize_proportionally, orig_total_lines)
4219 (orig_top_line): Remove from window structure.
4220 (set_window_height, set_window_width, change_window_heights)
4221 (Fdelete_window): Remove prototypes.
4222 (resize_frame_windows): Remove duplicate declaration.
4224 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4226 * window.h (resize_frame_windows, resize_window_check)
4227 (delete_deletable_window, resize_root_window)
4228 (resize_frame_windows): Declare prototypes.
4230 * window.c (resize_window_apply): Make definition be "static" to
4231 match the prototype.
4233 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4235 * window.c: Remove declarations of Qwindow_size_fixed,
4236 window_min_size_1, window_min_size_2, window_min_size,
4237 size_window, window_fixed_size_p, enlarge_window, delete_window.
4238 Remove static from declaration of Qdelete_window, it's
4239 temporarily needed by Fbury_buffer.
4240 (replace_window): Don't assign orig_top_line and
4242 (Fdelete_window, delete_window): Remove. Window deletion is
4243 handled by window.el.
4244 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4245 Replace Fdelete_window calls with calls to Qdelete_window.
4246 (Fdelete_other_windows): Remove. Deleting other windows is
4247 handled by window.el.
4248 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4249 handled in window.el.
4250 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4251 Window minimum sizes are handled in window.el.
4252 (shrink_windows, size_window, set_window_height)
4253 (set_window_width, change_window_heights, window_height)
4254 (window_width, CURBEG, CURSIZE, enlarge_window)
4255 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4256 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4257 handled in window.el.
4258 (make_dummy_parent): Rename to make_parent_window and give it a
4259 second argument horflag.
4260 (make_window): Don't set resize_proportionally any more.
4261 (Fsplit_window): Remove. Windows are split in window.el.
4262 (save_restore_action, save_restore_orig_size)
4263 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4264 Resize mini windows in window.el.
4265 (grow_mini_window, shrink_mini_window): Implement by calling
4266 Qresize_root_window_vertically, resize_window_check and
4267 resize_window_apply.
4268 (saved_window, Fset_window_configuration, save_window_save):
4269 Do not handle orig_top_line, orig_total_lines, and
4270 resize_proportionally.
4271 (window_min_height, window_min_width): Move to window.el.
4272 (keys_of_window): Move bindings for delete-other-windows,
4273 split-window, delete-window and enlarge-window to window.el.
4275 * buffer.c: Temporarily extern Qdelete_window.
4276 (Fbury_buffer): Temporarily call Qdelete_window instead of
4277 Fdelete_window (Fbury_buffer will move to window.el soon).
4279 * frame.c (set_menu_bar_lines_1): Remove code handling
4280 orig_top_line and orig_total_lines.
4282 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4283 set_window_height but set heights directly.
4284 (change_frame_size_1): Use resize_frame_windows.
4286 * xdisp.c (init_xdisp): Don't use set_window_height but set
4289 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4290 Use resize_frame_windows instead of change_window_heights and run
4291 run_window_configuration_change_hook.
4293 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4294 instead of change_window_heights and run
4295 run_window_configuration_change_hook.
4297 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4299 * window.c (replace_window): Rename second argument REPLACEMENT to
4300 NEW. New third argument SETFLAG. Rewrite.
4301 (delete_window, make_dummy_parent): Call replace_window with
4303 (window_list_1): Move down in code.
4304 (run_window_configuration_change_hook): Move set_buffer part
4305 before select_frame_norecord part in order to unwind correctly.
4306 Rename count1 to count.
4307 (recombine_windows, delete_deletable_window, resize_root_window)
4308 (Fdelete_other_windows_internal)
4309 (Frun_window_configuration_change_hook, make_parent_window)
4310 (resize_window_check, resize_window_apply, Fresize_window_apply)
4311 (resize_frame_windows, Fsplit_window_internal)
4312 (Fdelete_window_internal, Fresize_mini_window_internal):
4314 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4316 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4318 * window.h (window): Add some new members to window structure -
4319 normal_lines, normal_cols, new_total, new_normal, clone_number,
4320 splits, nest, prev_buffers, next_buffers.
4321 (WINDOW_TOTAL_SIZE): Move here from window.c.
4322 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4324 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4326 (make_dummy_parent): Set new members of windows structure.
4327 (make_window): Move down in code. Handle new members of window
4329 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4330 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4331 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4332 (Fset_window_prev_buffers, Fwindow_next_buffers)
4333 (Fset_window_next_buffers, Fset_window_clone_number):
4335 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4336 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4338 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4339 Argument WINDOW can be now internal window too.
4340 (Fwindow_use_time): Move up in code.
4341 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4343 (Fset_window_configuration, saved_window)
4344 (Fcurrent_window_configuration, save_window_save): Handle new
4345 members of window structure.
4346 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4347 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4348 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4349 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4350 Qget_mru_window, Qresize_root_window,
4351 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4352 Qauto_buffer_name; staticpro them.
4354 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4356 * window.c (Fwindow_total_size, Fwindow_left_column)
4357 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4358 (Fwindow_list_1): New functions.
4359 (window_box_text_cols): Replace with window_body_cols.
4360 (Fwindow_width, Fscroll_left, Fscroll_right):
4361 Use window_body_cols instead of window_box_text_cols.
4362 (delete_window, Fset_window_configuration):
4363 Call delete_all_subwindows with window as argument.
4364 (delete_all_subwindows): Take a window as argument and not a
4366 (window_loop): Remove handling of GET_LRU_WINDOW and
4368 (Fget_lru_window, Fget_largest_window): Move to window.el.
4370 * window.h: Extern window_body_cols instead of
4371 window_box_text_cols. delete_all_subwindows now takes a
4372 Lisp_Object as argument.
4374 * indent.c (compute_motion, Fcompute_motion):
4375 Use window_body_cols instead of window_box_text_cols.
4377 * frame.c (delete_frame): Call delete_all_subwindows with root
4380 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4382 * fns.c (Fputhash): Document return value.
4384 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4386 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4388 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4390 Cons<->int and similar integer overflow fixes (Bug#8794).
4392 Check for overflow when converting integer to cons and back.
4393 * charset.c (Fdefine_charset_internal, Fdecode_char):
4394 Use cons_to_unsigned to catch overflow.
4395 (Fencode_char): Use INTEGER_TO_CONS.
4396 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4397 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4398 * data.c (long_to_cons, cons_to_long): Remove.
4399 (cons_to_unsigned, cons_to_signed): New functions.
4400 These signal an error for invalid or out-of-range values.
4401 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4402 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4403 * font.c (Ffont_variation_glyphs):
4404 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4405 * lisp.h: Include <intprops.h>.
4406 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4407 (cons_to_signed, cons_to_unsigned): New decls.
4408 (long_to_cons, cons_to_long): Remove decls.
4409 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4410 (Fprimitive_undo): Use CONS_TO_INTEGER.
4411 * xfns.c (Fx_window_property): Likewise.
4412 * xselect.c: Include <limits.h>.
4413 (x_own_selection, selection_data_to_lisp_data):
4414 Use INTEGER_TO_CONS.
4415 (x_handle_selection_request, x_handle_selection_clear)
4416 (x_get_foreign_selection, Fx_disown_selection_internal)
4417 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4418 (lisp_data_to_selection_data): Use cons_to_unsigned.
4419 (x_fill_property_data): Use cons_to_signed.
4420 Report values out of range.
4422 Check for buffer and string overflow more precisely.
4423 * buffer.h (BUF_BYTES_MAX): New macro.
4424 * lisp.h (STRING_BYTES_MAX): New macro.
4425 * alloc.c (Fmake_string):
4426 * character.c (string_escape_byte8):
4427 * coding.c (coding_alloc_by_realloc):
4428 * doprnt.c (doprnt):
4429 * editfns.c (Fformat):
4431 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4432 since they may not be the same number.
4433 * editfns.c (Finsert_char):
4434 * fileio.c (Finsert_file_contents):
4435 Likewise for BUF_BYTES_MAX.
4437 * image.c: Use ptrdiff_t, not int, for sizes.
4438 (slurp_file): Switch from int to ptrdiff_t.
4440 (slurp_file): Check that file size fits in both size_t (for
4441 malloc) and ptrdiff_t (for sanity and safety).
4443 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4444 if b->modtime has its maximal value.
4446 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4448 Don't assume time_t can fit into int.
4449 * buffer.h (struct buffer.modtime): Now time_t, not int.
4450 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4451 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4453 Minor fixes for signed vs unsigned integers.
4454 * character.h (MAYBE_UNIFY_CHAR):
4455 * charset.c (maybe_unify_char):
4456 * keyboard.c (read_char, reorder_modifiers):
4457 XINT -> XFASTINT, since the integer must be nonnegative.
4458 * ftfont.c (ftfont_spec_pattern):
4459 * keymap.c (access_keymap, silly_event_symbol_error):
4460 XUINT -> XFASTINT, since the integer must be nonnegative.
4461 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4462 since it makes no difference and we prefer signed.
4463 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4464 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4467 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4469 * window.h (Fwindow_frame): Declare.
4471 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4473 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4474 (SPARE_MEMORY): Always define.
4475 (LARGE_REQUEST): Remove.
4476 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4478 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4480 * lisp.h: Move EXFUNS for Fframe_root_window,
4481 Fframe_first_window and Fset_frame_selected_window to window.h.
4483 * window.h: Move EXFUNS for Fframe_root_window,
4484 Fframe_first_window and Fset_frame_selected_window here from
4487 * frame.c (Fwindow_frame, Fframe_first_window)
4488 (Fframe_root_window, Fframe_selected_window)
4489 (Fset_frame_selected_window): Move to window.c.
4490 (Factive_minibuffer_window): Move to minibuf.c.
4491 (Fother_visible_frames_p): New function.
4493 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4495 * window.c (decode_window, decode_any_window): Move up in code.
4496 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4497 (inhibit_frame_unsplittable): Remove unused variable.
4498 (Fwindow_buffer): Move up and rewrite doc-string.
4499 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4500 (Fwindow_prev): New functions.
4501 (Fwindow_frame): Move here from frame.c. Accept any window as
4503 (Fframe_root_window, Fframe_first_window)
4504 (Fframe_selected_window): Move here from frame.c. Accept frame
4505 or arbitrary window as argument. Update doc-strings.
4506 (Fminibuffer_window): Move up in code.
4507 (Fwindow_minibuffer_p): Move up in code and simplify.
4508 (Fset_frame_selected_window): Move here from frame.c.
4510 (Fselected_window, select_window, Fselect_window): Move up in
4511 code. Minor doc-string fixes.
4513 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4515 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4516 Do not assume that spare memory exists; that assumption is valid
4517 only if SYSTEM_MALLOC.
4518 (LARGE_REQUEST): New macro, so that the issue of large requests
4519 is separated from the issue of spare memory.
4521 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4523 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4526 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4528 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4531 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4533 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4535 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4537 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4538 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4540 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4542 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4544 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4546 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4547 (x_clipboard_manager_save): Add return value.
4548 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4550 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4551 Obey Vx_select_enable_clipboard_manager. Catch errors in
4552 x_clipboard_manager_save (Bug#8779).
4553 (Vx_select_enable_clipboard_manager): New variable.
4554 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4556 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4558 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4560 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4562 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4563 in the current matrix if keep_current_p is non-zero.
4565 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4567 * bidi.c (bidi_level_of_next_char): Fix last change.
4569 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4571 Support bidi reordering of text covered by display properties.
4573 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4574 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4575 (bidi_cache_search, bidi_cache_iterator_state)
4576 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4577 (bidi_level_of_next_char, bidi_move_to_visually_next):
4578 Support character positions inside a run of characters covered by a
4580 (bidi_paragraph_init, bidi_resolve_explicit_1)
4581 (bidi_level_of_next_char): Call bidi_fetch_char and
4582 bidi_fetch_char_advance instead of FETCH_CHAR and
4584 (bidi_init_it): Initialize new members.
4585 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4587 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4588 instead of using explicit *_CHAR codes.
4589 (bidi_resolve_explicit, bidi_resolve_weak):
4590 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4591 bidirectional text is supported only in multibyte buffers.
4592 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4593 it to initialize the frame_window_p member of struct bidi_it.
4594 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4595 (bidi_resolve_explicit, bidi_resolve_weak)
4596 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4597 bidi_it->nchars is non-positive.
4598 (bidi_level_of_next_char): Don't try to lookup the cache for the
4599 next/previous character if nothing is cached there yet, or if we
4600 were just reseat()'ed to a new position.
4602 * xdisp.c (set_cursor_from_row): Set start and stop points
4603 according to the row's direction when priming the loop that looks
4604 for the glyph on which to display cursor.
4605 (single_display_spec_intangible_p): Function deleted.
4606 (display_prop_intangible_p): Reimplement to call
4607 handle_display_spec instead of single_display_spec_intangible_p.
4608 Accept 3 additional arguments needed by handle_display_spec.
4609 This fixes incorrect cursor motion across display property with complex
4610 values: lists, `(when COND...)' forms, etc.
4611 (single_display_spec_string_p): Support property values that are
4612 lists with the argument STRING its top-level element.
4613 (display_prop_string_p): Fix the condition for processing a
4614 property that is a list to be consistent with handle_display_spec.
4615 (handle_display_spec): New function, refactored from the
4616 last portion of handle_display_prop.
4617 (compute_display_string_pos): Accept additional argument
4618 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4619 value of a `display' property is a "replacing spec".
4620 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4621 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4622 the display property, but just return a value indicating whether
4623 the display property will replace the characters it covers.
4624 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4625 frame_window_p members of struct bidi_it.
4626 (compute_display_string_pos, compute_display_string_end):
4628 (push_it): Accept second argument POSITION, where pop_it should
4629 jump to continue iteration.
4630 (reseat_1): Initialize bidi_it.disp_pos.
4632 * keyboard.c (adjust_point_for_property): Adjust the call to
4633 display_prop_intangible_p to its new signature.
4635 * dispextern.h (struct bidi_it): New member frame_window_p.
4636 (bidi_init_it): Update prototypes.
4637 (display_prop_intangible_p): Update prototype.
4638 (compute_display_string_pos, compute_display_string_end):
4640 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4643 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4645 Malloc failure behavior now depends on size of allocation.
4646 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4647 * lisp.h: Change signatures accordingly.
4648 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4649 All callers changed. (Bug#8762)
4651 * gnutls.c: Use Emacs's memory allocators.
4652 Without this change, the gnutls library would invoke malloc etc.
4653 directly, which causes problems on non-SYNC_INPUT hosts, and which
4654 runs afoul of improving memory_full behavior. (Bug#8761)
4655 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4656 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4657 xfree instead of the default malloc, realloc, free.
4658 (Fgnutls_boot): No need to check for memory allocation failure,
4659 since xmalloc does that for us.
4661 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4662 * category.c (hash_get_category_set):
4663 * ccl.c (ccl_driver):
4664 * charset.c (Fdefine_charset_internal):
4665 * charset.h (struct charset.hash_index):
4666 * composite.c (get_composition_id, gstring_lookup_cache)
4667 (composition_gstring_put_cache):
4668 * composite.h (struct composition.hash_index):
4669 * dispextern.h (struct image.hash):
4670 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4671 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4672 (hashfn_equal, hashfn_user_defined, make_hash_table)
4673 (maybe_resize_hash_table, hash_lookup, hash_put)
4674 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4675 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4676 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4677 * image.c (make_image, search_image_cache, lookup_image)
4678 (xpm_put_color_table_h):
4679 * lisp.h (struct Lisp_Hash_Table):
4680 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4681 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4682 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4683 * alloc.c (allocate_vectorlike):
4684 Check for overflow in vector size calculations.
4685 * ccl.c (ccl_driver):
4686 Check for overflow when converting EMACS_INT to int.
4687 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4688 need to be updated by these changes.
4689 * fns.c (make_hash_table, maybe_resize_hash_table):
4690 Check for integer overflow with large hash tables.
4691 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4692 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4693 (SXHASH_REDUCE): New macro.
4694 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4695 Use it instead of discarding useful hash info with large hash values.
4696 (sxhash_float): New function.
4697 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4698 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4699 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4700 Rewrite to use FIXNUM_BITS, as this simplifies things.
4701 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4702 Adjust signatures to match updated version of code.
4703 (consing_since_gc): Now EMACS_INT, since a single hash table can
4704 use more than INT_MAX bytes.
4706 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4708 Make it possible to build with GCC-4.6+ -O2 -flto.
4710 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4712 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4714 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4715 Call minibuffer-inactive-mode.
4717 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4719 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4720 Update dependencies.
4722 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4724 * data.c (init_data): Remove code for UTS, this system is not
4727 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4729 Don't force ./temacs to start in terminal mode.
4731 * frame.c (make_initial_frame): Initialize faces in all cases, not
4732 only when CANNOT_DUMP is defined.
4733 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4735 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4737 * dispnew.c (add_window_display_history): Use const for the string
4738 pointer. Remove declaration, not needed.
4740 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4742 Use 'inline', not 'INLINE'.
4743 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4744 * alloc.c, fontset.c (INLINE): Remove.
4745 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4746 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4747 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4748 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4749 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4751 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4753 Make it possible to run ./temacs.
4755 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4756 syms_of_callproc does the same thing. Remove test for
4757 "initialized", do it in the caller.
4758 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4760 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4762 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4763 (read_minibuf): Use get_minibuffer.
4764 (syms_of_minibuf): Use DEFSYM.
4765 (Qmetadata): New var.
4766 * data.c (Qbuffer): Don't make it static.
4767 (syms_of_data): Use DEFSYM.
4769 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4771 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4772 (CCL_CODE_MIN): New macro.
4774 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4776 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4778 * eval.c (Qdebug): Now static.
4779 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4780 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4781 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4783 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4785 * image.c: Various fixes to ImageMagick code comments.
4786 (Fimagemagick_types): Doc fix.
4788 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4790 Minor fixes prompted by GCC 4.6.0 warnings.
4792 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4794 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4795 (x_clipboard_manager_save_all): Move extern decl to ...
4796 * xterm.h: ... here, so that it can be checked for consistency.
4798 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4800 * xselect.c (x_clipboard_manager_save_frame)
4801 (x_clipboard_manager_save_all): New functions.
4802 (Fx_clipboard_manager_save): Lisp function deleted.
4804 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4805 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4807 * xterm.h: Update prototype.
4809 2011-05-28 William Xu <william.xwl@gmail.com>
4811 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4814 2011-05-28 Jim Meyering <meyering@redhat.com>
4816 Avoid a sign-extension bug in crypto_hash_function.
4817 * fns.c (to_uchar): Define.
4818 (crypto_hash_function): Use it to convert some newly-signed
4819 variables to unsigned, to avoid sign-extension bugs. For example,
4820 without this change, (md5 "truc") would evaluate to
4821 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4822 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4823 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4825 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4827 Integer overflow fixes.
4829 * dbusbind.c: Serial number integer overflow fixes.
4830 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4831 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4832 to hold a serial number that is too large for a fixnum.
4833 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4834 Check for serial numbers out of range. Decode any serial number
4835 that was so large that it became a float. (Bug#8722)
4837 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4838 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4839 Use XFASTINT rather than XUINT when numbers are nonnegative.
4840 (xd_append_arg, Fdbus_method_return_internal):
4841 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4842 arguments, check that Lisp number is nonnegative, rather than
4843 silently wrapping negative numbers around. (Bug#8722)
4844 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4847 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4849 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4851 ccl: add integer overflow checks
4852 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4853 (IN_INT_RANGE): New macros.
4854 (ccl_driver): Use them to check for integer overflow when
4855 decoding a CCL program. Many of the new checks are whether XINT (x)
4856 fits in int; it doesn't always, on 64-bit hosts. The new version
4857 doesn't catch all possible integer overflows, but it's an
4858 improvement. (Bug#8719)
4860 * alloc.c (make_event_array): Use XINT, not XUINT.
4861 There's no need for unsigned here.
4863 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4864 This follows up to the 2011-05-06 change that substituted uintptr_t
4865 for EMACS_INT. This case wasn't caught back then.
4867 Rework Fformat to avoid integer overflow issues.
4868 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4869 now (part of C89). Include <verify.h>.
4870 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4871 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4872 (Fformat): Avoid the prepass trying to compute sizes; it was only
4873 approximate and thus did not catch overflow reliably. Instead, walk
4874 through the format just once, formatting and computing sizes as we go,
4875 checking for integer overflow at every step, and allocating a larger
4876 buffer as needed. Keep track separately whether the format is
4877 multibyte. Keep only the most-recently calculated precision, rather
4878 than them all. Record whether each argument has been converted to
4879 string. Use EMACS_INT, not int, for byte and char and arg counts.
4880 Support field widths and precisions larger than INT_MAX. Avoid
4881 sprintf's undefined behavior with conversion specifications such as %#d
4882 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4883 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4884 formatting out-of-range floating point numbers with int
4887 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4889 * data.c: Avoid integer truncation in expressions involving floats.
4890 * data.c: Include <intprops.h>.
4891 (arith_driver): When there's an integer overflow in an expression
4892 involving floating point, convert the integers to floating point
4893 so that the resulting value does not suffer from catastrophic
4894 integer truncation. For example, on a 64-bit host (* 4
4895 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4896 Do not rely on undefined behavior after integer overflow.
4898 merge count_size_as_multibyte, parse_str_to_multibyte
4899 * character.c, character.h (count_size_as_multibyte):
4900 Rename from parse_str_to_multibyte; all uses changed.
4901 Check for integer overflow.
4902 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4903 since it's now a duplicate of the other. This is more of
4904 a character than a buffer op, so better that it's in character.c.
4905 * fns.c, print.c: Adjust to above changes.
4907 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4909 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4911 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4913 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4914 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4915 (x_clipboard_manager_save): Now static.
4916 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4918 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4919 (crypto_hash_function): Now static.
4920 Fix pointer signedness problems. Avoid unnecessary initializations.
4922 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4924 * termhooks.h (Vselection_alist): Make it terminal-local.
4926 * terminal.c (create_terminal): Initialize it.
4928 * xselect.c: Support for clipboard managers.
4929 (Vselection_alist): Move to termhooks.h as terminal-local var.
4930 (LOCAL_SELECTION): New macro.
4931 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4932 (symbol_to_x_atom): Remove gratuitous arg.
4933 (x_handle_selection_request, lisp_data_to_selection_data)
4934 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4935 (x_own_selection, x_get_local_selection, x_convert_selection):
4936 New arg, specifying work frame. Use terminal-local Vselection_alist.
4937 (some_frame_on_display): Delete unused function.
4938 (Fx_own_selection_internal, Fx_get_selection_internal)
4939 (Fx_disown_selection_internal, Fx_selection_owner_p)
4940 (Fx_selection_exists_p): New optional frame arg.
4941 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4942 (x_handle_selection_clear): Don't treat other terminals with the
4943 same keyboard specially. Use the terminal-local Vselection_alist.
4944 (x_clear_frame_selections): Use Frun_hook_with_args.
4946 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4948 * xterm.h: Add support for those atoms.
4950 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4952 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4953 (converted_selections, conversion_fail_tag): New global variables.
4954 (x_selection_request_lisp_error): Free the above.
4955 (x_get_local_selection): Remove unnecessary code.
4956 (x_reply_selection_request): Args changed; handle arbitrary array
4957 of converted selections stored in converted_selections.
4958 Separate the XChangeProperty and SelectionNotify steps.
4959 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4960 (x_convert_selection): New function.
4961 (x_handle_selection_event): Simplify.
4962 (x_get_foreign_selection): Don't ignore incoming requests while
4963 waiting for an answer; this will fail when we implement
4964 SAVE_TARGETS, and seems unnecessary anyway.
4965 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4966 (Vx_sent_selection_functions): Doc fix.
4968 2011-05-26 Leo Liu <sdl.web@gmail.com>
4970 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4972 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4974 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4976 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4977 for fringe update if it has periodic bitmap.
4978 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4979 and fringe_bitmap_periodic_p.
4981 * fringe.c (get_fringe_bitmap_data): New function.
4982 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4983 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4984 row. Mark glyph row for fringe update if periodicity changed.
4986 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4987 for fringe update unless it has periodic bitmap.
4989 2011-05-25 Kenichi Handa <handa@m17n.org>
4991 * xdisp.c (get_next_display_element): Set correct it->face_id for
4992 a static composition.
4994 2011-05-24 Leo Liu <sdl.web@gmail.com>
4997 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4999 * fns.c (crypto_hash_function, Fsha1): New function.
5000 (Fmd5): Use crypto_hash_function.
5001 (syms_of_fns): Add Ssha1.
5003 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5005 * gnutls.c: Remove unused macros.
5006 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5007 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5008 Remove macros that are defined and never used.
5009 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5011 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5013 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5014 (Fx_get_selection_internal): Minor cleanup.
5015 (Fx_own_selection_internal): Rename arguments for consistency with
5018 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5020 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5022 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5024 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5026 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5028 * dispnew.c (scrolling_window): Don't exclude the case that the
5029 last enabled row in the desired matrix touches the bottom boundary.
5031 2011-05-21 Glenn Morris <rgm@gnu.org>
5033 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5034 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5035 and add some more files.
5037 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5039 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5040 report_file_error introduced by the change from 2011-05-07.
5042 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5044 * systime.h (Time): Define only if emacs is defined.
5045 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5046 where the include path doesn't have X11/X.h by default. See
5047 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5049 2011-05-20 Kenichi Handa <handa@m17n.org>
5051 * composite.c (find_automatic_composition): Fix previous change.
5053 2011-05-20 Glenn Morris <rgm@gnu.org>
5055 * lisp.mk: New file, split from Makefile.in.
5056 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5057 (shortlisp): Remove.
5058 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5060 2011-05-19 Glenn Morris <rgm@gnu.org>
5062 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5063 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5064 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5065 (lisp): Set the order to that of loadup.el.
5066 (shortlisp): Make it a copy of $lisp.
5067 (SOME_MACHINE_LISP): Remove.
5068 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5069 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5071 2011-05-18 Kenichi Handa <handa@m17n.org>
5073 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5074 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5075 (find_automatic_composition): Mostly rewrite for efficiency.
5077 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5079 * makefile.w32-in: Update dependencies.
5081 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5083 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5084 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5086 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5088 Fix some integer overflow issues, such as string length overflow.
5090 * insdel.c (count_size_as_multibyte): Check for string overflow.
5092 * character.c (lisp_string_width): Check for string overflow.
5093 Use EMACS_INT, not int, for string indexes and lengths; in
5094 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5095 the resulting string length overflows an EMACS_INT; instead,
5096 report a string overflow if no precision given. When checking for
5097 precision exhaustion, use a check that cannot possibly have
5098 integer overflow. (Bug#8675)
5099 * character.h (lisp_string_width): Adjust to new signature.
5101 * alloc.c (string_overflow): New function.
5102 (Fmake_string): Use it. This doesn't change behavior, but saves
5103 a few bytes and will simplify future changes.
5104 * character.c (string_escape_byte8): Likewise.
5105 * lisp.h (string_overflow): New decl.
5107 Fixups, following up to the user-interface timestamp change.
5108 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5109 for UI timestamps, instead of unsigned long.
5110 * msdos.c (mouse_get_pos): Likewise.
5111 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5112 * w32gui.h (Time): Define by including "systime.h" rather than by
5113 declaring it ourselves. (Bug#8664)
5115 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5116 * image.c (clear_image_cache): Likewise.
5118 * term.c (term_mouse_position): Don't assume time_t wraparound.
5120 Be more systematic about user-interface timestamps.
5121 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5122 and sometimes 'EMACS_UINT', to represent these timestamps.
5123 This change causes it to use 'Time' uniformly, as that's what X uses.
5124 This makes the code easier to follow, and makes it easier to catch
5125 integer overflow bugs such as Bug#8664.
5126 * frame.c (Fmouse_position, Fmouse_pixel_position):
5127 Use Time, not unsigned long, for user-interface timestamps.
5128 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5129 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5130 * keyboard.h (last_event_timestamp): Likewise.
5131 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5132 * menu.h (xmenu_show): Likewise.
5133 * term.c (term_mouse_position): Likewise.
5134 * termhooks.h (struct input_event.timestamp): Likewise.
5135 (struct terminal.mouse_position_hook): Likewise.
5136 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5137 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5138 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5139 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5141 * menu.h, termhooks.h: Include "systime.h", for Time.
5143 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5144 Don't assume that the difference between two unsigned long values
5145 can fit into an integer. At this point, we know button_down_time
5146 <= event->timestamp, so the difference must be nonnegative, so
5147 there's no need to cast the result if double-click-time is
5148 nonnegative, as it should be; check that it's nonnegative, just in
5149 case. This bug is triggered when events are more than 2**31 ms
5150 apart (about 25 days). (Bug#8664)
5152 * xselect.c (last_event_timestamp): Remove duplicate decl.
5153 (x_own_selection): Remove needless cast to unsigned long.
5155 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5156 that always fit in int. Use a sentinel instead of a counter, to
5157 avoid a temp and to allay GCC's concerns about possible int overflow.
5158 * frame.h (struct frame): Use int for menu_bar_items_used
5159 instead of EMACS_INT, since it always fits in int.
5161 * menu.c (grow_menu_items): Check for int overflow.
5163 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5165 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5166 Before, the code was not consistent. These values cannot exceed
5167 2**31 - 1 so there's no need to make them unsigned.
5168 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5169 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5170 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5172 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5174 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5175 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5176 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5177 presumably because the widths might not match.
5179 * window.c (size_window): Avoid needless test at loop start.
5181 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5183 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5185 2011-05-12 Drew Adams <drew.adams@oracle.com>
5187 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5189 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5191 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5192 `width' to `bar_area_x' and `bar_area_width', respectively.
5193 (x_scroll_run): Take account of fringe background extension.
5195 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5196 Rename local vars `left' and `width' to `bar_area_x' and
5197 `bar_area_width', respectively.
5198 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5199 background extension.
5201 2011-05-10 Jim Meyering <meyering@redhat.com>
5203 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5205 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5207 * image.c (Finit_image_library): Return t for built-in image types,
5208 like pbm and xbm. (Bug#8640)
5210 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5212 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5214 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5216 * w32console.c (Fset_screen_color): Doc fix.
5217 (Fget_screen_color): New function.
5218 (syms_of_ntterm): Defsubr it.
5220 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5221 unlink the temporary file if Fcall_process didn't create it in the
5223 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5224 child process will be redirected to a file specified with `:file'.
5225 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5226 cue to call_process_cleanup not to close that handle.
5228 2011-05-07 Ben Key <bkey76@gmail.com>
5230 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5231 one of two shell specific rules, either bootstrap-temacs-CMD or
5232 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5233 to the previous implementation of the bootstrap-temacs rule.
5234 The bootstrap-temacs-CMD rule is similar to the previous
5235 implementation of the bootstrap-temacs rule except that it
5236 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5239 These changes, along with some changes to nt/configure.bat,
5240 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5241 earlier fix to add support for --cflags and --ldflags options
5242 that include quotes so that it works whether make uses cmd or
5245 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5247 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5248 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5250 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5251 a string. Handle both cases.
5252 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5253 (Fdbus_register_method): Use Qinvalid_function.
5255 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5257 * makefile.w32-in: Update dependencies.
5258 (LISP_H): Add inttypes.h and stdin.h.
5259 (PROCESS_H): Add unistd.h.
5261 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5263 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5264 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5266 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5268 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5270 * term.c (vfatal): Remove stray call to va_end.
5271 It's not needed and the C Standard doesn't allow it here anyway.
5273 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5274 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5276 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5279 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5281 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5283 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5285 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5287 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5289 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5290 * charset.c (Fdefine_charset_internal): Don't initialize
5291 charset.code_space[15]. The value was garbage, on hosts with
5292 32-bit int (Bug#8600).
5294 * lread.c (read_integer): Be more consistent with string-to-number.
5295 Use string_to_number to do the actual conversion; this avoids
5296 rounding errors and fixes some other screwups. Without this fix,
5297 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5298 (digit_to_number): Move earlier, for benefit of read_integer.
5299 Return -1 if the digit is out of range for the base, -2 if it is
5300 not a digit in any supported base. (Bug#8602)
5302 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5304 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5305 to match comment at start of function. This also removes a
5306 GCC warning about overflow in a 32+64-bit port.
5308 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5310 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5311 Reported by Stefan Monnier in
5312 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5313 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5314 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5316 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5317 (EMACS_UINTPTR): Likewise, with uintptr_t.
5319 * lisp.h: Prefer 64-bit EMACS_INT if available.
5320 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5321 on 32-bit hosts that have 64-bit int, so that they can access
5323 However, temporarily disable this change unless the temporary
5324 symbol WIDE_EMACS_INT is defined.
5326 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5328 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5329 This removes an assumption that EMACS_INT and long are the same
5330 width as pointers. The assumption is true for Emacs porting targets
5331 now, but we want to make other targets possible.
5332 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5333 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5334 In the rest of the code, change types of integers that hold casted
5335 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5336 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5337 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5338 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5339 No need to cast type when ORing.
5340 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5341 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5342 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5343 assume EMACS_INT is the same width as char *.
5344 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5345 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5346 Remove no-longer-needed casts.
5347 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5348 (xg_tool_bar_help_callback, xg_make_tool_item):
5349 Use EMACS_INTPTR to hold an integer
5350 that will be cast to void *; this can avoid a GCC warning
5351 if EMACS_INT is not the same width as void *.
5352 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5353 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5354 (current_message_1, set_message_1):
5355 Use a local to convert to proper width without a cast.
5356 * xmenu.c (dialog_selection_callback): Likewise.
5358 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5359 Also, don't assume VALBITS / RAND_BITS is less than 5,
5360 and don't rely on undefined behavior when shifting a 1 left into
5362 * lisp.h (get_random): Change signature to match.
5364 * lread.c (hash_string): Use size_t, not int, for hash computation.
5365 Normally we prefer signed values; but hashing is special, because
5366 it's better to use unsigned division on hash table sizes so that
5367 the remainder is nonnegative. Also, size_t is the natural width
5368 for hashing into memory. The previous code used 'int', which doesn't
5369 retain enough info to hash well into very large tables.
5370 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5372 * dbusbind.c: Don't possibly lose pointer info when converting.
5373 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5374 Use XPNTR rather than XHASH, so that the high-order bits of
5375 the pointer aren't lost when converting through void *.
5377 * eval.c (Fautoload): Don't double-shift a pointer.
5379 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5381 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5383 * gnutls.c (DEF_GNUTLS_FN):
5384 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5386 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5388 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5391 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5393 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5394 New version that can reserve upto 2GB of heap space.
5396 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5398 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5400 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5402 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5403 `gnutls_certificate_set_x509_key_file'.
5405 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5407 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5408 Update dependencies.
5410 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5412 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5413 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5414 Remove unused parameter `fildes'.
5415 * process.c (read_process_output, send_process): Don't pass it.
5417 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5419 Fix previous change: the library cache is defined in w32.c.
5420 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5421 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5423 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5425 Implement dynamic loading of GnuTLS on Windows.
5427 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5428 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5429 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5432 * gnutls.c (Qgnutls_dll): Define.
5433 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5434 (gnutls_*): Declare function pointers.
5435 (init_gnutls_functions): New function to initialize function pointers.
5436 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5437 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5438 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5439 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5440 (emacs_gnutls_write, emacs_gnutls_read)
5441 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5442 (Fgnutls_available_p): New function.
5443 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5444 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5445 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5447 * image.c: Include w32.h.
5448 (Vimage_type_cache): Delete.
5449 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5450 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5451 (w32_delayed_load): Move to w32.c.
5453 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5455 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5456 (w32_delayed_load): Move from image.c. When loading a library, record
5457 its filename in the :loaded-from property of the library id.
5458 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5459 Initialize and staticpro them.
5460 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5462 * process.c: Include lisp.h before w32.h, not after.
5463 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5464 instead of gnutls_record_check_pending.
5466 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5468 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5470 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5471 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5474 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5476 * xterm.c (x_set_frame_alpha): Do not set property on anything
5477 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5479 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5481 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5483 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5485 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5486 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5487 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5488 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5489 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5490 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5491 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5492 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5493 (Qgnutls_bootprop_callbacks_verify): Make static.
5495 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5497 * callproc.c: Indentation fixup.
5499 * sysdep.c (wait_for_termination_1): Make static.
5500 (wait_for_termination, interruptible_wait_for_termination):
5501 Move after wait_for_termination_1.
5503 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5505 * sysdep.c (interruptible_wait_for_termination): New function
5506 which is like wait_for_termination, but allows keyboard
5509 * callproc.c (Fcall_process): Add (:file "file") as an option for
5511 (Fcall_process_region): Ditto.
5513 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5515 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5516 rather than `XVECTOR (FOO)->size'.
5518 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5519 inttypes.h, as a gnulib replacement is used if it not available in
5522 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5524 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5525 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5526 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5528 * coding.c (coding_alloc_by_realloc): Error out if destination
5529 will grow beyond MOST_POSITIVE_FIXNUM.
5530 (decode_coding_emacs_mule): Abort if there isn't enough place in
5531 charbuf for the composition carryover bytes. Reserve an extra
5532 space for up to 2 characters produced in a loop.
5533 (decode_coding_iso_2022): Abort if there isn't enough place in
5534 charbuf for the composition carryover bytes.
5536 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5538 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5539 aborting when %lld or %lll format is passed.
5540 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5541 %llo or %llx format is passed. (Bug#8545)
5543 * window.c (window_scroll_line_based): Use a marker instead of
5544 simple variables to record original value of point. (Bug#7952)
5546 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5547 produced by %s or %c overflows available buffer space. (Bug#8545)
5549 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5551 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5552 (SIZE_MAX): Move defn after all includes, as they might #define it.
5554 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5556 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5558 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5560 * keyboard.c (Qdelayed_warnings_hook): Define.
5561 (command_loop_1): Run `delayed-warnings-hook'
5562 if Vdelayed_warnings_list is non-nil.
5563 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5564 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5566 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5568 * doprnt.c (doprnt): Don't return value smaller than the buffer
5569 size if the message was truncated. (Bug#8545).
5571 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5573 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5574 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5576 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5578 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5580 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5582 * makefile.w32-in: Update dependencies.
5584 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5586 Improve `doprnt' and its usage. (Bug#8545)
5587 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5588 `format_end'. Remove support for %l as a conversion specifier.
5589 Don't use xrealloc. Improve diagnostics when the %l size modifier
5590 is used. Update the commentary.
5592 * eval.c (verror): Simplify calculation of size_t.
5594 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5597 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5599 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5602 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5604 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5605 This makes this file independent of the recent pseudovector change.
5607 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5609 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5611 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5612 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5613 Remove unused local.
5614 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5616 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5617 GCC 4.6.0 optimizes based on type-based alias analysis.
5618 For example, if b is of type struct buffer * and v of type struct
5619 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5620 != &v->size, and therefore "v->size = 1; b->size = 2; return
5621 v->size;" must therefore return 1. This assumption is incorrect
5622 for Emacs, since it type-puns struct Lisp_Vector * with many other
5623 types. To fix this problem, this patch adds a new type struct
5624 vectorlike_header that documents the constraints on layout of vectors
5625 and pseudovectors, and helps optimizing compilers not get fooled
5626 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5627 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5628 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5630 (XSETPVECTYPE): Rewrite in terms of new macro.
5631 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5632 This is a bit clearer, and further avoids the possibility of
5633 undesirable aliasing.
5634 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5635 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5636 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5637 since Lisp_Subr is a special case (no "next" field).
5638 (ASIZE): Now uses header.size rather than size.
5639 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5640 to avoid the hassle of writing XVECTOR (foo)->header.size.
5641 (struct vectorlike_header): New type.
5642 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5643 object, to help avoid aliasing.
5644 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5645 (SUBRP): Likewise, since Lisp_Subr is a special case.
5646 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5647 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5648 (struct Lisp_Hash_Table): Combine first two members into a single
5649 struct vectorlike_header member. All uses of "size" and "next" members
5650 changed to be "header.size" and "header.next".
5651 * buffer.h (struct buffer): Likewise.
5652 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5653 * frame.h (struct frame): Likewise.
5654 * process.h (struct Lisp_Process): Likewise.
5655 * termhooks.h (struct terminal): Likewise.
5656 * window.c (struct save_window_data, struct saved_window): Likewise.
5657 * window.h (struct window): Likewise.
5658 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5659 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5660 * buffer.c (init_buffer_once): Likewise.
5661 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5663 * process.c (Fformat_network_address): Use local var for size,
5666 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5668 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5669 * data.c (atof): Remove decl; no longer used or needed.
5670 (digit_to_number): Move to lread.c.
5671 (Fstring_to_number): Use new string_to_number function, to be
5672 consistent with how the Lisp reader treats infinities and NaNs.
5673 Do not assume that floating-point numbers represent EMACS_INT
5674 without losing information; this is not true on most 64-bit hosts.
5675 Avoid double-rounding errors, by insisting on integers when
5676 parsing non-base-10 numbers, as the documentation specifies.
5677 * lisp.h (string_to_number): New decl, replacing ...
5678 (isfloat_string): Remove.
5679 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5680 (read1): Do not accept +. and -. as integers; this
5681 appears to have been a coding error. Similarly, do not accept
5682 strings like +-1e0 as floating point numbers. Do not report
5683 overflow for integer overflows unless the base is not 10 which
5684 means we have no simple and reliable way to continue.
5685 Break out the floating-point parsing into a new
5686 function string_to_number, so that Fstring_to_number parses
5687 floating point numbers consistently with the Lisp reader.
5688 (digit_to_number): Move here from data.c. Make it static inline.
5689 (E_CHAR, EXP_INT): Remove, replacing with ...
5690 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5691 (string_to_number): New function, replacing isfloat_string.
5692 This function checks for valid syntax and produces the resulting
5693 Lisp float number too. Rework it so that string-to-number
5694 no longer mishandles examples like "1.0e+". Use strtoumax,
5695 so that overflow for non-base-10 numbers is reported only when
5696 there's no portable and simple way to convert to floating point.
5698 * textprop.c (set_text_properties_1): Rewrite for clarity,
5699 and to avoid GCC warning about integer overflow.
5701 * intervals.h (struct interval): Use EMACS_INT for members
5702 where EMACS_UINT might cause problems. See
5703 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5704 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5705 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5707 (offset_intervals): Tell GCC not to worry about length overflow
5708 when negating a negative length.
5710 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5711 (overrun_check_free): Likewise.
5713 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5714 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5717 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5718 (gnutls_make_error): Rename local to avoid shadowing.
5719 (gnutls_emacs_global_deinit): ifdef out; not used.
5720 (Fgnutls_boot): Use const for pointer to readonly storage.
5721 Comment out unused local. Fix pointer signedness problems.
5723 * lread.c (openp): Don't stuff size_t into an 'int'.
5724 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5725 about possible signed overflow.
5727 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5728 (GDK_KEY_g): Don't define if already defined.
5729 (xg_prepare_tooltip): Avoid pointer signedness problem.
5730 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5732 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5733 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5735 * xfns.c (Fx_window_property): Simplify a bit,
5736 to make a bit faster and to avoid GCC 4.6.0 warning.
5737 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5739 * fns.c (internal_equal): Don't assume size_t fits in int.
5741 * alloc.c (compact_small_strings): Tighten assertion a little.
5743 Replace pEd with more-general pI, and fix some printf arg casts.
5744 * lisp.h (pI): New macro, generalizing old pEd macro to other
5745 conversion specifiers. For example, use "...%"pI"d..." rather
5746 than "...%"pEd"...".
5747 (pEd): Remove. All uses replaced with similar uses of pI.
5748 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5749 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5750 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5751 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5752 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5753 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5754 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5756 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5757 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5758 * print.c (safe_debug_print, print_object): Likewise.
5759 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5761 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5762 avoiding the 0 flag, which is not portable.
5763 * process.c (Fmake_network_process): Use pI to avoid cast.
5764 * region-cache.c (pp_cache): Likewise.
5765 * xdisp.c (decode_mode_spec): Likewise.
5766 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5767 behavior on 64-bit hosts with printf arg.
5768 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5769 (x_stop_queuing_selection_requests): Likewise.
5770 (x_get_window_property): Don't truncate byte count to an 'int'
5773 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5774 here, since it parses constructs like leading '-' and spaces,
5775 which are not wanted; and it overflows with large numbers.
5776 Instead, simply match F[0-9]+, which is what is wanted anyway.
5778 * alloc.c: Remove unportable assumptions about struct layout.
5779 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5780 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5781 (allocate_vectorlike, make_pure_vector): Use the new macros,
5782 plus offsetof, to remove unportable assumptions about struct layout.
5783 These assumptions hold on all porting targets that I know of, but
5784 they are not guaranteed, they're easy to remove, and removing them
5785 makes further changes easier.
5787 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5788 This doesn't fix a bug but makes the code clearer.
5789 (string_overrun_cookie): Now const. Use initializers that
5790 don't formally overflow signed char, to avoid warnings.
5791 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5792 can cause Emacs to crash when string overrun checking is enabled.
5793 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5794 multiple of sizeof (EMACS_INT); it need not be, if
5795 alignof(EMACS_INT) < sizeof (EMACS_INT).
5796 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5798 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5800 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5802 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5804 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5805 supposed to be handshaking. (Bug#8556)
5806 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5808 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5810 * lisp.h (Qdebug): List symbol.
5811 * eval.c (Qdebug): Restore global linkage.
5812 * keyboard.c (debug-on-event): New variable.
5813 (handle_user_signal): Break into debugger when debug-on-event
5814 matches the current signal symbol.
5816 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5818 * alloc.c (check_sblock, check_string_bytes)
5819 (check_string_free_list): Convert to standard C.
5821 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5823 * w32.c (emacs_gnutls_push): Fix typo.
5825 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5827 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5828 "cast to pointer from integer of different size".
5830 Improve doprnt and its use in verror. (Bug#8545)
5831 * doprnt.c (doprnt): Document the set of format control sequences
5832 supported by the function. Use SAFE_ALLOCA instead of always
5835 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5836 is one byte too soon. Don't use xrealloc; instead xfree and
5839 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5841 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5844 * gnutls.c: Renamed global_initialized to
5845 gnutls_global_initialized. Added internals for the
5846 :verify-hostname-error, :verify-error, and :verify-flags
5847 parameters of `gnutls-boot' and documented those parameters in the
5848 docstring. Start callback support.
5849 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5850 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5851 on error. Return error code.
5852 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5853 (emacs_gnutls_read): Likewise.
5854 (Fgnutls_boot): Return handshake error code.
5855 (emacs_gnutls_handle_error): New function.
5856 (wsaerror_to_errno): Likewise.
5858 * w32.h (emacs_gnutls_pull): Add prototype.
5859 (emacs_gnutls_push): Likewise.
5861 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5862 (emacs_gnutls_push): Likewise.
5864 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5866 * process.c (wait_reading_process_output): Check if GnuTLS
5867 buffered some data internally if no FDs are set for TLS
5870 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5871 (LIBS): Link to USER_LIBS.
5872 ($(BLD)/gnutls.$(0)): New target.
5874 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5876 * xdisp.c (handle_single_display_spec): Rename the
5877 display_replaced_before_p argument into display_replaced_p, to
5878 make it consistent with the commentary. Fix typos in the
5881 * textprop.c (syms_of_textprop): Remove dead code.
5882 (copy_text_properties): Delete obsolete commentary about an
5883 interface that was deleted long ago. Fix typos in the description
5886 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5887 to changes in oldXMenu/XMenu.h from 2011-04-16.
5888 <menu_help_message, prev_menu_help_message>: Constify.
5889 (IT_menu_make_room): menu->help_text is now `const char **';
5892 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5893 to changes in oldXMenu/XMenu.h from 2011-04-16.
5894 (struct XMenu): Declare `help_text' `const char **'.
5896 * xfaces.c <Qunspecified>: Make extern again.
5898 * syntax.c: Include sys/types.h before including regex.h, as
5901 * doc.c (get_doc_string): Improve the format passed to `error'.
5903 * doprnt.c (doprnt): Improve commentary.
5905 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5907 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5910 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5911 changes in globals.h immediately force recompilation.
5912 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5913 $(CURDIR)/s/ms-w32.h.
5914 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5916 * character.c (Fchar_direction): Function deleted.
5917 (syms_of_character): Don't defsubr it.
5918 <char-direction-table>: Deleted.
5920 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5922 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5923 * doprnt.c: Include limits.h.
5924 (SIZE_MAX): New macro.
5925 (doprnt): Return a size_t value. 2nd arg is now size_t.
5926 Many local variables are now size_t instead of int or unsigned.
5927 Improve overflow protection. Support `l' modifier for integer
5928 conversions. Support %l conversion. Don't assume an EMACS_INT
5929 argument for integer conversions and for %c.
5931 * lisp.h (doprnt): Restore prototype.
5933 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5936 * Makefile.in (base_obj): Add back doprnt.o.
5938 * deps.mk (doprnt.o): Add back prerequisites.
5939 (callint.o): Depend on character.h.
5941 * eval.c (internal_lisp_condition_case): Include the handler
5942 representation in the error message.
5943 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5944 when breaking from the loop.
5946 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5948 * callint.c (Fcall_interactively): When displaying error message
5949 about invalid control letter, pass the character's codepoint, not
5950 a pointer to its multibyte form. Improve display of the character
5951 in octal and display also its hex code.
5953 * character.c (char_string): Use %x to display the (unsigned)
5954 codepoint of an invalid character, to avoid displaying a bogus
5957 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5958 `error', not SYMBOL_NAME itself.
5960 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5961 character arguments to `error'.
5963 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5964 to `error' in error message about FINAL_CHAR argument. Make sure
5965 FINAL_CHAR is a character, and use %c when it is passed as
5966 argument to `error'.
5968 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5970 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5972 * w32.c: Include <time.h>.
5973 (sys_localtime): New function.
5975 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5977 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5979 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5981 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5983 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5986 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5988 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5989 gl_state.e_property when gl_state.object is Qt.
5991 * insdel.c (make_gap_larger): Remove limitation of buffer size
5994 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5996 * xdisp.c (lookup_glyphless_char_display)
5997 (produce_glyphless_glyph): Handle cons cell entry in
5998 glyphless-char-display.
5999 (Vglyphless_char_display): Document it.
6001 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6002 glyphless-char-display.
6004 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6006 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6008 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6010 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6011 definition for no-X builds.
6013 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6015 Static checks with GCC 4.6.0 and non-default toolkits.
6017 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6019 * process.c (keyboard_bit_set): Define only if SIGIO.
6020 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6021 (send_process): Repair possible setjmp clobbering.
6023 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6025 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6027 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6029 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6030 Define only if needed.
6032 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6033 by pacifying GCC about it. Maybe it's time to retire it?
6034 * xfaces.c (USG, __TIMEVAL__): Likewise.
6036 * dispextern.h (struct redisplay_interface): Rename param
6038 * termhooks.h (struct terminal): Likewise.
6039 * xterm.c (xembed_send_message): Likewise.
6041 * insdel.c (make_gap_smaller): Define only if
6042 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6044 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6047 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6048 so that we aren't warned about unused symbols.
6050 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6052 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6054 * xfns.c (x_real_positions): Mark locals as initialized.
6056 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6058 * xterm.c: Fix problems found by static analysis with other toolkits.
6059 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6060 (x_dispatch_event): Declare static if USE_GTK, and
6061 define if USE_GTK || USE_X_TOOLKIT.
6062 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6063 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6064 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6065 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6067 * xmenu.c (menu_help_callback): Pointer type fixes.
6068 Use const pointers when pointing at readonly data. Avoid pointer
6070 (FALSE): Remove unused macro.
6071 (update_frame_menubar): Remove unused decl.
6073 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6075 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6076 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6077 (single_menu_item): Rename local to avoid shadowing.
6079 * keyboard.c (make_lispy_event): Remove unused local var.
6081 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6082 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6084 * bitmaps: Change bitmaps from unsigned char back to the X11
6085 compatible char. Avoid the old compiler warnings about
6086 out-of-range initializers by using, for example, '\xab' rather
6089 * xgselect.c (xgselect_initialize): Check vs interface
6090 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6092 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6094 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6095 to read-only memory.
6097 * fns.c (vector): Remove; this old hack is no longer needed.
6099 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6101 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6103 * xrdb.c (x_load_resources): Omit unused local.
6105 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6106 (x_window): Rename locals to avoid shadowing.
6107 (USG): Use the kludged USG macro, to pacify gcc.
6109 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6110 (x_term_init): Remove local to avoid shadowing.
6112 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6114 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6115 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6117 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6119 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6121 Fix regex.c, syntax.c and friends for buffers > 2GB.
6122 * syntax.h (struct gl_state_s): Declare character position members
6125 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6127 * textprop.c (verify_interval_modification, interval_of):
6128 Declare arguments EMACS_INT.
6130 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6133 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6135 * indent.c (Fvertical_motion): Local variable it_start is now
6138 * regex.c (re_match, re_match_2, re_match_2_internal)
6139 (bcmp_translate, regcomp, regexec, print_double_string)
6140 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6141 (re_compile_pattern, re_exec): Declare arguments and local
6142 variables `size_t' and `ssize_t' and return values `regoff_t', as
6144 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6145 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6146 <compile_stack_type>: `size' and `avail' are now `size_t'.
6148 * regex.h <regoff_t>: Use ssize_t, not int.
6149 (re_search, re_search_2, re_match, re_match_2): Arguments that
6150 specify buffer/string position and length are now ssize_t and
6151 size_t. Return type is regoff_t.
6153 2011-04-16 Ben Key <bkey76@gmail.com>
6155 * nsfont.m: Fixed bugs in ns_get_family and
6156 ns_descriptor_to_entity that were caused by using free to
6157 deallocate memory blocks that were allocated by xmalloc (via
6158 xstrdup). This caused Emacs to crash when compiled with
6159 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6160 --enable-checking=xmallocoverrun). xfree is now used to
6161 deallocate these memory blocks.
6163 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6165 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6167 emacs_write: Accept and return EMACS_INT for sizes.
6168 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6170 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6171 Accept and return EMACS_INT.
6172 (emacs_gnutls_write): Return the number of bytes written on
6174 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6175 (emacs_read, emacs_write): Remove check for negative size, as the
6176 Emacs source code has been audited now.
6177 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6178 (emacs_read, emacs_write): Use it.
6179 * process.c (send_process): Adjust to the new signatures of
6180 emacs_write and emacs_gnutls_write. Do not attempt to store
6181 a byte offset into an 'int'; it might overflow.
6182 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6184 * sound.c: Don't assume sizes fit in 'int'.
6185 (struct sound_device.period_size, alsa_period_size):
6186 Return EMACS_INT, not int.
6187 (struct sound_device.write, vox_write, alsa_write):
6188 Accept EMACS_INT, not int.
6189 (wav_play, au_play): Use EMACS_INT to store sizes and to
6190 record read return values.
6192 2011-04-15 Ben Key <bkey76@gmail.com>
6194 * keyboard.c (Qundefined): Don't declare static since it is used
6196 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6197 static since they are used in nsfont.m.
6199 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6201 * process.c (Qprocessp): Don't declare static.
6202 * lisp.h (Qprocessp): Declare again.
6204 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6206 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6208 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6210 Improve C-level modularity by making more things 'static'.
6212 Don't publish debugger-only interfaces to other modules.
6213 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6214 (verify_bytepos, count_markers): Move decls to the only modules
6216 * region-cache.h (pp_cache): Likewise.
6217 * window.h (check_all_windows): Likewise.
6218 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6220 * sysdep.c (croak): Now static, if
6221 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6222 * syssignal.h (croak): Declare only if not static.
6224 * alloc.c (refill_memory_reserve): Now static if
6225 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6226 * lisp.h (refill_memory_reserve): Declare only if not static.
6228 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6229 Define only if USE_LUCID.
6231 * xrdb.c (x_customization_string, x_rm_string): Now static.
6233 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6234 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6236 * xdisp.c (draw_row_with_mouse_face): Now static.
6237 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6239 * window.h (check_all_windows): Mark externally visible.
6241 * window.c (window_deletion_count): Now static.
6243 * undo.c: Make symbols static if they're not exported.
6244 (last_undo_buffer, last_boundary_position, pending_boundary):
6247 * textprop.c (interval_insert_behind_hooks): Now static.
6248 (interval_insert_in_front_hooks): Likewise.
6250 * term.c: Make symbols static if they're not exported.
6251 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6252 (max_frame_lines, tty_set_terminal_modes):
6253 (tty_reset_terminal_modes, tty_turn_off_highlight):
6254 (get_tty_terminal): Now static.
6255 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6256 * termhooks.h (term_mouse_moveto): Do not declare if
6258 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6259 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6261 * sysdep.c: Make symbols static if they're not exported.
6262 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6264 (sigprocmask_set, full_mask): Remove; unused.
6265 (wait_debugging): Mark as visible.
6266 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6267 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6269 * syntax.c (syntax_temp): Define only if !__GNUC__.
6271 * sound.c (current_sound_device, current_sound): Now static.
6273 * search.c (searchbufs, searchbuf_head): Now static.
6275 * scroll.c (scroll_cost): Remove; unused.
6276 * dispextern.h (scroll_cost): Remove decl.
6278 * region-cache.h (pp_cache): Mark as externally visible.
6280 * process.c: Make symbols static if they're not exported.
6281 (process_tick, update_tick, create_process, chan_process):
6282 (Vprocess_alist, proc_buffered_char, datagram_access):
6283 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6284 (deactivate_process): Mark defn as static, as well as decl.
6285 * lisp.h (create_process): Remove decl.
6286 * process.h (chan_process, Vprocess_alist): Remove decls.
6288 * print.c: Make symbols static if they're not exported.
6289 (print_depth, new_backquote_output, being_printed, print_buffer):
6290 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6291 (print_interval, print_number_index, initial_stderr_stream):
6293 * lisp.h (Fprinc): Remove decl.
6294 (debug_output_compilation_hack): Mark as externally visible.
6296 * sysdep.c (croak): Move decl from here to syssignal.h.
6297 * syssignal.h (croak): Put it here, so the API can be checked when
6298 'croak' is called from dissociate_if_controlling_tty.
6300 * minibuf.c: Make symbols static if they're not exported.
6301 (minibuf_save_list, choose_minibuf_frame): Now static.
6302 * lisp.h (choose_minibuf_frame): Remove decl.
6304 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6306 * lread.c: Make symbols static if they're not exported.
6307 (read_objects, initial_obarray, oblookup_last_bucket_number):
6309 (make_symbol): Remove; unused.
6310 * lisp.h (initial_obarray, make_symbol): Remove decls.
6312 * keyboard.c: Make symbols static if they're not exported.
6313 (single_kboard, recent_keys_index, total_keys, recent_keys):
6314 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6315 (this_single_command_key_start, echoing, last_auto_save):
6316 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6317 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6318 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6319 (Vlispy_mouse_stem, double_click_count):
6321 (force_auto_save_soon): Define only if SIGDANGER.
6322 (ignore_mouse_drag_p): Now static if
6323 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6324 (print_help): Remove; unused.
6325 (stop_character, last_timer_event): Mark as externally visible.
6326 * keyboard.h (ignore_mouse_drag_p): Declare only if
6327 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6328 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6329 * lisp.h (echoing): Remove decl.
6330 (force_auto_save_soon): Declare only if SIGDANGER.
6331 * xdisp.c (redisplay_window): Simplify code, to make it more
6332 obvious that ignore_mouse_drag_p is not accessed if !defined
6333 USE_GTK && !defined HAVE_NS.
6335 * intervals.c: Make symbols static if they're not exported.
6336 (merge_properties_sticky, merge_interval_right, delete_interval):
6338 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6340 * insdel.c: Make symbols static if they're not exported.
6341 However, leave prepare_to_modify_buffer alone. It's never
6342 called from outside this function, but that appears to be a bug.
6343 (combine_after_change_list, combine_after_change_buffer):
6344 (adjust_after_replace, signal_before_change): Now static.
6345 (adjust_after_replace_noundo): Remove; unused.
6346 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6347 (signal_before_change): Remove decls.
6349 * indent.c (val_compute_motion, val_vmotion): Now static.
6351 * image.c: Make symbols static if they're not exported.
6352 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6354 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6355 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6357 * fringe.c (standard_bitmaps): Now static.
6358 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6360 * frame.c: Make symbols static if they're not exported.
6361 (x_report_frame_params, make_terminal_frame): Now static.
6362 (get_frame_param): Now static, unless HAVE_NS.
6363 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6364 (x_get_resource_string): Remove; not used.
6365 * frame.h (make_terminal_frame, x_report_frame_params):
6366 (x_get_resource_string); Remove decls.
6367 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6368 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6370 * font.c, fontset.c: Make symbols static if they're not exported.
6371 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6372 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6373 * font.c (font_close_object): Now static.
6374 * font.h (font_close_object): Remove.
6375 * fontset.c (FONTSET_OBJLIST): Remove.
6376 (free_realized_fontset) #if-0 the body, which does nothing.
6377 (face_suitable_for_char_p): #if-0, as it's never called.
6378 * fontset.h (face_suitable_for_char_p): Remove decl.
6379 * xfaces.c (face_at_string_position):
6380 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6381 since 0 is always ASCII.
6383 * fns.c (weak_hash_tables): Now static.
6385 * fileio.c: Make symbols static if they're not exported.
6386 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6387 (Vwrite_region_annotation_buffers): Now static.
6389 * eval.c: Make symbols static if they're not exported.
6390 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6391 * lisp.h (backtrace_list): Remove decl.
6393 * emacs.c: Make symbols static if they're not exported.
6394 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6395 (fatal_error_code, fatal_error_signal_hook, standard_args):
6397 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6398 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6399 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6400 * lisp.h (fatal_error_signal_hook): Remove decl.
6401 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6403 * editfns.c: Move a (normally-unused) function to its only use.
6404 * editfns.c, lisp.h (get_operating_system_release): Remove.
6405 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6406 worth the hassle of breaking this out.
6408 * xterm.c: Make symbols static if they're not exported.
6409 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6410 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6411 (x_destroy_window, x_delete_display):
6413 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6414 (x_mouse_leave): Remove; unused.
6415 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6416 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6417 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6419 (x_mouse_leave): Declare only if WINDOWSNT.
6420 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6421 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6424 * ftxfont.c: Make symbols static if they're not exported.
6425 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6427 * font.h (ftxfont_driver): Likewise.
6429 * xfns.c: Make symbols static if they're not exported.
6430 (x_last_font_name, x_display_info_for_name):
6431 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6432 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6433 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6434 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6435 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6436 (last_show_tip_args): Now static.
6437 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6438 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6439 (x_screen_planes): Remove; unused.
6440 * dispextern.h (x_screen_planes): Remove decl.
6442 * dispnew.c: Make symbols static if they're not exported.
6443 * dispextern.h (redraw_garbaged_frames, scrolling):
6444 (increment_row_positions): Remove.
6445 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6446 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6448 (redraw_garbaged_frames): Remove; unused.
6450 * xfaces.c: Make symbols static if they're not exported.
6451 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6453 * xterm.h (defined_color): Remove decls.
6454 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6455 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6456 (menu_face_changed_default, defined_color, free_realized_face):
6457 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6458 (ascii_face_of_lisp_face): Remove; unused.
6460 * xdisp.c: Make symbols static if they're not exported.
6461 * dispextern.h (scratch_glyph_row, window_box_edges):
6462 (glyph_to_pixel_coords, set_cursor_from_row):
6463 (get_next_display_element, set_iterator_to_next):
6464 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6465 (show_mouse_face): Remove decls
6466 * frame.h (message_buf_print): Likewise.
6467 * lisp.h (pop_message, set_message, check_point_in_composition):
6469 * xterm.h (set_vertical_scroll_bar): Likewise.
6470 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6471 (message_buf_print, scratch_glyph_row, displayed_buffer):
6472 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6473 (get_next_display_element, show_mouse_face, window_box_edges):
6474 (frame_to_window_pixel_xy, check_point_in_composition):
6475 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6476 (glyph_to_pixel_coords): Remove; unused.
6478 * dired.c (file_name_completion): Now static.
6480 * dbusbind.c (xd_in_read_queued_messages): Now static.
6482 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6483 * data.c (circular_list_error): Remove.
6485 * commands.h (last_point_position, last_point_position_buffer):
6486 (last_point_position_window): Remove decls.
6487 * keyboard.c: Make these variables static.
6489 * coding.h (coding, code_convert_region, encode_coding_gap):
6491 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6492 (iso_code_class, detect_coding, code_convert_region): Now static.
6493 (encode_coding_gap): Remove; unused.
6495 * chartab.c (chartab_chars, chartab_bits): Now static.
6497 * charset.h (charset_iso_8859_1): Remove decl.
6498 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6501 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6502 * ccl.c (Vccl_program_table): Now static.
6503 (check_ccl_update): Remove; unused.
6505 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6506 * category.h: ... from here.
6507 * category.c (check_category_table, set_category_set): Now static.
6509 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6510 * lisp.h: Remove these decls.
6512 * buffer.c (buffer_count): Remove unused var.
6514 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6515 so that it's not optimized away.
6516 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6517 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6518 exported only to the debugger.
6520 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6521 * atimer.h (run_all_atimers): Remove; not exported.
6523 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6524 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6525 was inaccessible from Lisp.
6526 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6527 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6529 alloc.c: Import and export fewer symbols, and remove unused items.
6530 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6532 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6533 it's not optimized away by whole-program optimization.
6534 (message_enable_multibyte, free_misc): Remove.
6535 (catchlist, handlerlist, mark_backtrace):
6536 Declare only if BYTE_MARK_STACK.
6537 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6538 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6539 (message_enable_multibyte): Remove decl.
6540 (free_misc, interval_free_list, float_block, float_block_index):
6541 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6542 (cons_free_list, last_marked_index):
6544 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6545 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6546 (mark_backtrace): Define only if BYTE_MARK_STACK.
6547 * xdisp.c (message_enable_multibyte): Now static.
6549 Declare Lisp_Object Q* variables to be 'static' if not exported.
6550 This makes it easier for human readers (and static analyzers)
6551 to see whether these variables are used from other modules.
6552 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6553 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6554 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6555 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6556 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6557 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6558 * xmenu.c, xselect.c:
6559 Declare Q* vars static if they are not used in other modules.
6560 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6561 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6562 Remove decls of unexported vars.
6563 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6565 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6567 Make Emacs functions such as Fatom 'static' by default.
6568 This makes it easier for human readers (and static analyzers)
6569 to see whether these functions can be called from other modules.
6570 DEFUN now defines a static function. To make the function external
6571 so that it can be used in other C modules, use the new macro DEFUE.
6572 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6573 (Finit_image_library):
6574 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6575 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6576 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6577 Remove decls, since these functions are now static.
6578 (Funintern, Fget_internal_run_time): New decls, since these functions
6579 were already external.
6581 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6582 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6583 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6584 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6585 * keyboard.c, keymap.c, lread.c:
6586 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6587 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6588 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6589 Mark functions with DEFUE instead of DEFUN,
6590 if they are used in other modules.
6591 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6592 decls for now-static functions.
6593 * buffer.h (Fdelete_overlay): Remove decl.
6594 * callproc.c (Fgetenv_internal): Mark as internal.
6595 * composite.c (Fremove_list_of_text_properties): Remove decl.
6596 (Fcomposition_get_gstring): New forward static decl.
6597 * composite.h (Fcomposite_get_gstring): Remove decl.
6598 * dired.c (Ffile_attributes): New forward static decl.
6599 * doc.c (Fdocumntation_property): New forward static decl.
6600 * eval.c (Ffetch_bytecode): New forward static decl.
6601 (Funintern): Remove extern decl; now in .h file where it belongs.
6602 * fileio.c (Fmake_symbolic_link): New forward static decl.
6603 * image.c (Finit_image_library): New forward static decl.
6604 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6605 * intervals.h (Fprevious_property_change):
6606 (Fremove_list_of_text_properties): Remove decls.
6607 * keyboard.c (Fthis_command_keys): Remove decl.
6608 (Fcommand_execute): New forward static decl.
6609 * keymap.c (Flookup_key): New forward static decl.
6610 (Fcopy_keymap): Now static.
6611 * keymap.h (Flookup_key): Remove decl.
6612 * process.c (Fget_process): New forward static decl.
6613 (Fprocess_datagram_address): Mark as internal.
6614 * syntax.c (Fsyntax_table_p): New forward static decl.
6615 (skip_chars): Remove duplicate decl.
6616 * textprop.c (Fprevious_property_change): New forward static decl.
6617 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6619 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6620 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6622 * editfns.c (Fformat): Remove unreachable code.
6624 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6626 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6629 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6631 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6632 when at ZV. (Bug#8487)
6634 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6636 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6638 * keyboard.c (parse_tool_bar_item): Likewise.
6639 * sound.c (sound_cleanup, alsa_close): Likewise.
6640 * termcap.c (tgetent): Likewise.
6641 * xfns.c (x_default_font_parameter): Likewise.
6642 * xsettings.c (read_and_apply_settings): Likewise.
6644 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6645 (overrun_check_free): Protoize.
6647 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6649 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6650 since callers should never pass a negative size.
6651 Change the signature to match that of plain 'read' and 'write'; see
6652 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6653 * lisp.h: Update prototypes of emacs_write and emacs_read.
6655 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6657 * xdisp.c (redisplay_window): Don't try to determine the character
6658 position of the scroll margin if the window start point w->startp
6659 is outside the buffer's accessible region. (Bug#8468)
6661 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6663 Fix write-region and its subroutines for buffers > 2GB.
6664 * fileio.c (a_write, e_write): Modify declaration of arguments and
6665 local variables to support buffers larger than 2GB.
6666 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6668 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6669 argument, local variables, and return value.
6671 * lisp.h: Update prototypes of emacs_write and emacs_read.
6673 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6675 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6677 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6679 Fix more problems found by GCC 4.6.0's static checks.
6681 * xdisp.c (vmessage): Use a better test for character truncation.
6683 * charset.c (load_charset_map): <, not <=, for optimization,
6684 and to avoid potential problems with integer overflow.
6685 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6686 * casetab.c (set_identity, shuffle): Likewise.
6687 * editfns.c (Fformat): Likewise.
6688 * syntax.c (skip_chars): Likewise.
6690 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6691 This also lets GCC 4.6.0 generate slightly better loop code.
6693 * callint.c (Fcall_interactively): <, not <=, for optimization.
6694 (Fcall_interactively): Count the number of arguments produced,
6695 not the number of arguments given. This is simpler and lets GCC
6696 4.6.0 generate slightly better code.
6698 * ftfont.c: Distingish more carefully between FcChar8 and char.
6699 The previous code passed unsigned char * to a functions like
6700 strlen and xstrcasecmp that expect char *, which does not
6701 conform to the C standard.
6702 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6703 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6704 char * when the C standard requires it.
6706 * keyboard.c (read_char): Remove unused var.
6708 * eval.c: Port to Windows vsnprintf (Bug#8435).
6710 (SIZE_MAX): Define if the headers do not.
6711 (verror): Do not give up if vsnprintf returns a negative count.
6712 Instead, grow the buffer. This ports to Windows vsnprintf, which
6713 does not conform to C99. Problem reported by Eli Zaretskii.
6714 Also, simplify the allocation scheme, by avoiding the need for
6715 calling realloc, and removing the ALLOCATED variable.
6717 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6719 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6720 But keep the doprint source code for now, as we might revamp it
6721 and use it again (Bug#8435).
6722 * lisp.h (doprnt): Remove.
6723 * Makefile.in (base_obj): Remove doprnt.o.
6724 * deps.mk (doprnt.o): Remove.
6726 error: Print 32- and 64-bit integers portably (Bug#8435).
6727 Without this change, on typical 64-bit hosts error ("...%d...", N)
6728 was used to print both 32- and 64-bit integers N, which relied on
6730 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6732 * lisp.h (error, verror): Mark as printf-like functions.
6733 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6734 Report overflow in size calculations when allocating printf buffer.
6735 Do not truncate output string at its first null byte.
6736 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6737 Truncate the output at a character boundary, since vsnprintf does not
6739 * charset.c (check_iso_charset_parameter): Convert internal
6740 character to string before calling 'error', since %c now has the
6742 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6743 overflow when computing char to be passed to 'error'. Do not
6744 pass Lisp_Object to 'error'; pass the integer instead.
6745 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6746 formatted with plain %d.
6748 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6750 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6752 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6754 * xterm.c (x_catch_errors): Remove duplicate declaration.
6756 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6758 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6760 2011-04-10 Jim Meyering <meyering@redhat.com>
6762 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6763 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6764 return ssize_t not "int", and use size_t as the buffer length.
6765 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6766 * gnutls.h: Update declarations.
6767 * process.c (read_process_output): Use ssize_t, to match.
6768 (send_process): Likewise.
6770 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6772 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6774 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6776 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6777 Use unsigned char, to match FcChar8 type definition.
6779 * xterm.c (handle_one_xevent):
6780 * xmenu.c (create_and_show_popup_menu):
6781 * xselect.c (x_decline_selection_request)
6782 (x_reply_selection_request): Avoid type-punned deref of X events.
6784 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6786 Fix some uses of `int' instead of EMACS_INT.
6787 * search.c (string_match_1, fast_string_match)
6788 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6789 (scan_buffer, find_next_newline_no_quit)
6790 (find_before_next_newline, search_command, Freplace_match)
6791 (Fmatch_data): Make some `int' variables be EMACS_INT.
6793 * xdisp.c (display_count_lines): 3rd argument and return value now
6794 EMACS_INT. All callers changed.
6795 (pint2hrstr): Last argument is now EMACS_INT.
6797 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6798 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6799 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6800 (decode_coding_utf_16, decode_coding_emacs_mule)
6801 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6802 (decode_coding_ccl, decode_coding_charset)
6803 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6804 (decode_coding_iso_2022, decode_coding_emacs_mule)
6805 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6806 <char_offset, last_offset>: Declare EMACS_INT.
6807 (encode_coding_utf_8, encode_coding_utf_16)
6808 (encode_coding_emacs_mule, encode_invocation_designation)
6809 (encode_designation_at_bol, encode_coding_iso_2022)
6810 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6811 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6813 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6814 (encode_invocation_designation): Last argument P_NCHARS is now
6816 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6817 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6819 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6822 * ccl.c (Fccl_execute_on_string): Declare some variables
6825 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6827 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6829 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6831 * process.c (Fformat_network_address): Doc fix.
6833 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6835 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6837 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6839 * keyboard.c (read_char): Call Lisp function help-form-show,
6840 instead of using internal_with_output_to_temp_buffer.
6841 (Qhelp_form_show): New var.
6842 (syms_of_keyboard): Use DEFSYM macro.
6844 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6846 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6848 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6850 * process.c (Flist_processes): Remove to Lisp.
6851 (list_processes_1): Delete.
6853 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6855 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6857 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6859 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6861 Fix more problems found by GCC 4.6.0's static checks.
6863 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6865 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6867 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6869 * xdisp.c (vmessage): Mark as a printf-like function.
6871 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6873 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6875 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6876 printf-like functions.
6877 (tiff_load): Add casts to remove these marks before passing them
6878 to system-supplied API.
6880 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6882 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6883 This avoids several warnings with gcc -Wstrict-overflow.
6884 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6885 directly, rather than having caller test rule sign. This avoids
6886 some unnecessary tests.
6887 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6888 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6889 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6891 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6892 (xfont_open): Avoid unnecessary tests.
6894 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6896 * composite.h, composite.c (composition_gstring_put_cache):
6897 Use EMACS_INT, not int, for length.
6899 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6900 breaking out part of COMPOSITION_DECODE_RULE.
6901 (COMPOSITION_DECODE_RULE): Use it.
6902 * composite.c (get_composition_id): Remove unused local vars,
6903 by using the new macro.
6905 * textprop.c (set_text_properties_1): Change while to do-while,
6906 since the condition is always true at first.
6908 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6909 (interval_deletion_adjustment): Return unsigned value.
6912 * process.c (list_processes_1, create_pty, read_process_output):
6913 (exec_sentinel): Remove vars that were set but not used.
6914 (create_pty): Remove unnecessary "volatile"s.
6915 (Fnetwork_interface_info): Avoid possibility of int overflow.
6916 (read_process_output): Do adaptive read buffering even if carryover.
6917 (read_process_output): Simplify nbytes computation if buffered.
6919 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6921 * syntax.c (scan_words): Remove var that was set but not used.
6922 (update_syntax_table): Use unsigned instead of int.
6924 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6925 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6926 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6928 * print.c (print_error_message): Avoid int overflow.
6930 * font.c (font_list_entities): Redo for clarity,
6931 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6933 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6934 (font_score): Avoid potential overflow in diff calculation.
6936 * fns.c (substring_both): Remove var that is set but not used.
6937 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6939 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6941 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6942 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6943 can always succeed if overflow has undefined behavior.
6945 * search.c (boyer_moore, wordify): Remove vars set but not used.
6946 (wordify): Omit three unnecessary tests.
6948 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6949 All callers changed. This avoids the need for an unused var.
6951 * casefiddle.c (casify_region): Remove var that is set but not used.
6953 * dired.c (file_name_completion): Remove var that is set but not used.
6955 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6957 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6958 (Finsert_file_contents): Remove unnecessary code checking fd.
6960 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6961 Check for integer overflow on size calculations.
6963 * buffer.c (Fprevious_overlay_change): Remove var that is set
6966 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6967 Remove vars that are set but not used.
6968 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6969 (timer_check_2): Mark vars as initialized.
6971 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6973 * image.c (lookup_image): Remove var that is set but not used.
6974 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6976 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6977 that are set but not used.
6979 * xfns.c (make_invisible_cursor): Don't return garbage
6980 if XCreateBitmapFromData fails (Bug#8410).
6982 * xselect.c (x_get_local_selection, x_handle_property_notify):
6983 Remove vars that are set but not used.
6985 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6986 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6988 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6989 Remove var that is set but not used.
6990 (scroll_bar_windows_size): Now size_t, not int.
6991 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6994 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6995 (map_tty_color) [!defined MSDOS]: Likewise.
6997 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6999 * coding.c: Remove vars that are set but not used.
7000 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7001 All callers changed.
7002 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7003 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7004 (decode_coding_charset): Remove vars that are set but not used.
7006 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7007 that is set but not used.
7009 * print.c (print_object): Remove var that is set but not used.
7011 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7012 The gnulib version avoids calling malloc in the usual case,
7013 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7014 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7015 * filelock.c (current_lock_owner): Likewise.
7016 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7017 * sysdep.c: Include allocator.h, careadlinkat.h.
7018 (emacs_no_realloc_allocator): New static constant.
7019 (emacs_readlink): New function.
7020 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7021 ../lib/careadlinkat.h.
7023 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7025 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7026 first non-nil return value).
7028 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7030 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7031 if not defined (Bug#8403).
7033 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7035 * xdisp.c (display_count_lines): Remove parameter `start',
7036 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7037 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7038 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7039 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7040 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7041 and thereabouts. All callers changed.
7042 (get_per_char_metric): Remove parameter `f', unused since
7043 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7045 2011-04-02 Jim Meyering <meyering@redhat.com>
7047 do not dereference NULL upon failed strdup
7048 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7049 (ns_get_family): Likewise.
7051 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7053 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7055 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7057 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7060 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7062 Add lexical binding.
7064 * window.c (Ftemp_output_buffer_show): New fun.
7065 (Fsave_window_excursion):
7066 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7068 * lread.c (lisp_file_lexically_bound_p): New function.
7069 (Fload): Bind Qlexical_binding.
7070 (readevalloop): Remove `evalfun' arg.
7071 Bind Qinternal_interpreter_environment.
7072 (Feval_buffer): Bind Qlexical_binding.
7073 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7075 (syms_of_lread): Declare `lexical-binding'.
7077 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7079 * keyboard.c (eval_dyn): New fun.
7080 (menu_item_eval_property): Use it.
7082 * image.c (parse_image_spec): Use Ffunctionp.
7084 * fns.c (concat, mapcar1): Accept byte-code-functions.
7086 * eval.c (Fsetq): Handle lexical vars.
7087 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7088 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7089 (FletX, Flet): Obey lexical binding.
7090 (Fcommandp): Handle closures.
7091 (Feval): New `lexical' arg.
7092 (eval_sub): New function extracted from Feval. Use it almost
7093 everywhere where Feval was used. Look up vars in lexical env.
7095 (Ffunctionp): Move from subr.el.
7096 (Ffuncall): Handle closures.
7097 (apply_lambda): Remove `eval_flags'.
7098 (funcall_lambda): Handle closures and new byte-code-functions.
7099 (Fspecial_variable_p): New function.
7100 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7101 but without exporting it to Lisp.
7103 * doc.c (Fdocumentation, store_function_docstring):
7104 * data.c (Finteractive_form): Handle closures.
7106 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7109 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7111 (exec_byte_code): New function extracted from Fbyte_code to handle new
7112 calling convention for byte-code-functions. Add new byte-codes.
7114 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7116 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7118 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7120 * xdisp.c (redisplay_internal): Fix prototype.
7122 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7124 * xdisp.c (SCROLL_LIMIT): New macro.
7125 (try_scrolling): Use it when setting scroll_limit.
7126 Limit scrolling to 100 screen lines.
7127 (redisplay_window): Even when falling back on "recentering",
7128 position point in the window according to scroll-conservatively,
7129 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7131 (try_scrolling): When point is above the window, allow searching
7132 as far as scroll_max, or one screenful, to compute vertical
7133 distance from PT to the scroll margin position. This prevents
7134 try_scrolling from unnecessarily failing when
7135 scroll-conservatively is set to a value slightly larger than the
7136 window height. Clean up the case of PT below the margin at bottom
7137 of window: scroll_max can no longer be INT_MAX. When aggressive
7138 scrolling is in use, don't let point enter the opposite scroll
7139 margin as result of the scroll.
7140 (syms_of_xdisp) <scroll-conservatively>: Document the
7141 threshold of 100 lines for never-recentering scrolling.
7143 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7145 * dispextern.h (move_it_by_lines):
7146 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7147 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7148 (message_log_check_duplicate): Remove parameters `prev_bol' and
7149 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7150 (redisplay_internal): Remove parameter `preserve_echo_area',
7151 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7153 * indent.c (Fvertical_motion):
7154 * window.c (window_scroll_pixel_based, Frecenter):
7155 Don't pass `need_y_p' to `move_it_by_lines'.
7157 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7159 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7160 steal a few bits to be more compact.
7161 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7162 Remove unneeded casts.
7164 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7166 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7168 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7169 binding" message (bug#7967).
7171 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7173 Fix more problems found by GCC 4.6.0's static checks.
7175 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7176 Remove unused local var.
7178 * editfns.c (Fmessage_box): Remove unused local var.
7180 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7181 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7182 Omit unused local vars.
7183 * window.c (shrink_windows): Omit unused local var.
7184 * menu.c (digest_single_submenu): Omit unused local var.
7185 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7186 Omit unused local var.
7188 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7189 Don't assume string length fits in int.
7190 (keyremap_step, read_key_sequence): Use size_t for sizes.
7191 (read_key_sequence): Don't check last_real_key_start redundantly.
7193 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7194 instead of alloca (Bug#8344).
7196 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7197 (Fbacktrace_frame): Don't assume nframes fits in int.
7199 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7201 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7204 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7206 * cm.c (calccost): Turn while-do into do-while, for clarity.
7208 * keyboard.c (syms_of_keyboard): Use the same style as later
7209 in this function when indexing through an array. This also
7210 works around GCC bug 48267.
7212 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7214 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7216 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7217 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7219 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7220 This avoids undefined behavior on integer overflow, and is a bit
7221 more convenient anyway since it is compared to a size_t variable.
7223 Variadic C functions now count arguments with size_t, not int.
7224 This avoids an unnecessary limitation on 64-bit machines, which
7225 caused (substring ...) to crash on large vectors (Bug#8344).
7226 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7227 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7228 All variadic functions and their callers changed accordingly.
7229 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7230 * data.c (arith_driver, float_arith_driver): Likewise.
7231 * editfns.c (general_insert_function): Likewise.
7232 * eval.c (struct backtrace.nargs, interactive_p)
7233 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7234 (funcall_lambda, mark_backtrace): Likewise.
7235 * fns.c (concat): Likewise.
7236 * frame.c (x_set_frame_parameters): Likewise.
7237 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7238 0 if not found, not -1. All callers changed.
7240 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7241 (stack_copy_size): Now size_t, not int.
7242 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7244 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7246 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7247 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7248 All callers changed.
7250 * lisp.h (multibyte_char_to_unibyte):
7251 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7252 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7253 * character.h (CHAR_TO_BYTE8):
7254 * cmds.c (internal_self_insert):
7255 * editfns.c (general_insert_function):
7256 * keymap.c (push_key_description):
7257 * search.c (Freplace_match):
7258 * xdisp.c (message_dolog, set_message_1): All callers changed.
7260 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7262 * keyboard.c (safe_run_hook_funcall): New function.
7263 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7264 don't set the hook to nil, but remove the offending function instead.
7265 (Qcommand_hook_internal): Remove, unused.
7266 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7267 Vcommand_hook_internal.
7269 * eval.c (enum run_hooks_condition): Remove.
7270 (funcall_nil, funcall_not): New functions.
7271 (run_hook_with_args): Call each function through a `funcall' argument.
7272 Remove `cond' argument, now redundant.
7273 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7274 (Frun_hook_with_args_until_failure): Adjust accordingly.
7275 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7277 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7279 * dispextern.h (string_buffer_position): Remove declaration.
7281 * print.c (strout): Remove parameter `multibyte', unused since
7282 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7284 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7285 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7286 All callers changed.
7288 * w32.c (_wsa_errlist): Use braces for struct initializers.
7290 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7291 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7292 All callers changed.
7293 (string_buffer_position): Likewise. Also, make static (it's never
7294 used outside xdisp.c).
7295 (cursor_row_p): Remove parameter `w', unused since
7296 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7297 (decode_mode_spec): Remove parameter `precision', introduced during
7298 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7299 All callers changed.
7301 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7303 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7305 2011-03-27 Anders Lindgren <andlind@gmail.com>
7307 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7308 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7309 (ns_update_auto_hide_menu_bar): New functions.
7310 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7311 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7312 ns_constrain_all_frames.
7313 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7314 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7316 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7318 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7320 2011-03-27 Glenn Morris <rgm@gnu.org>
7322 * syssignal.h: Replace RETSIGTYPE with void.
7323 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7324 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7325 Replace SIGTYPE with void everywhere.
7326 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7327 * s/template.h (SIGTYPE): Remove commented out definition.
7329 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7331 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7332 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7334 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7336 * w32.c (read_unc_volume): Use parameter `henum', instead of
7337 global variable `wget_enum_handle'.
7339 * keymap.c (describe_vector): Remove parameters `indices' and
7340 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7341 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7343 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7345 * keyboard.c (timer_check): Remove parameter `do_it_now',
7346 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7347 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7348 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7350 * keyboard.c (read_char):
7351 * w32menu.c (w32_menu_display_help):
7352 * xmenu.c (show_help_event, menu_help_callback):
7353 Adjust calls to `show_help_echo'.
7355 * gtkutil.c (xg_maybe_add_timer):
7356 * keyboard.c (readable_events):
7357 * process.c (wait_reading_process_output):
7358 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7360 * insdel.c (adjust_markers_gap_motion):
7361 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7362 (gap_left, gap_right): Don't call it.
7364 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7366 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7367 incurred during fontification.
7369 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7371 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7372 (DEFVAR_PER_BUFFER): Don't pass it.
7374 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7375 (scrolling_window): Don't pass it.
7377 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7379 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7381 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7383 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7384 of variables specific to SELinux and computation of `encoded_absname'.
7386 * image.c (XPutPixel): Remove unused variable `height'.
7388 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7390 * unexw32.c (get_section_info): Remove unused variable `section'.
7392 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7393 (system_process_attributes): Remove unused variable `sess'.
7394 (sys_read): Remove unused variable `err'.
7396 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7397 (w32_wnd_proc): Remove unused variable `isdead'.
7398 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7399 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7400 (x_create_tip_frame): Remove unused variable `tem'.
7402 * w32inevt.c (w32_console_read_socket):
7403 Remove unused variable `no_events'.
7405 * w32term.c (x_draw_composite_glyph_string_foreground):
7406 Remove unused variable `width'.
7408 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7410 * w32term.c (x_set_glyph_string_clipping):
7411 Don't pass uninitialized region to CombineRgn.
7413 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7415 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7416 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7417 (Fx_close_connection): Remove unused variable `i'.
7419 * w32font.c (w32font_draw): Return number of glyphs.
7420 (w32font_open_internal): Remove unused variable `i'.
7421 (w32font_driver): Add missing initializer.
7423 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7424 (fill_in_menu): Remove unused variable `items_added'.
7426 * w32term.c (last_mouse_press_frame): Remove static global variable.
7427 (w32_clip_to_row): Remove unused variable `f'.
7428 (x_delete_terminal): Remove unused variable `i'.
7430 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7431 (NOTHING): Remove unused static global variable.
7432 (uniscribe_check_otf): Remove unused variable `table'.
7433 (uniscribe_font_driver): Add missing initializers.
7435 2011-03-23 Julien Danjou <julien@danjou.info>
7437 * term.c (Fsuspend_tty, Fresume_tty):
7438 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7439 * window.c (temp_output_buffer_show):
7440 * insdel.c (signal_before_change):
7441 * frame.c (Fhandle_switch_frame):
7442 * fileio.c (Fdo_auto_save):
7443 * emacs.c (Fkill_emacs):
7444 * editfns.c (save_excursion_restore):
7445 * cmds.c (internal_self_insert):
7446 * callint.c (Fcall_interactively):
7447 * buffer.c (Fkill_all_local_variables):
7448 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7450 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7451 unconditionnaly since it does the check itself.
7453 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7455 Fix more problems found by GCC 4.5.2's static checks.
7457 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7458 the first time through the loop, since we know p0 < p1 then.
7459 This also avoids a gcc -Wstrict-overflow warning.
7461 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7462 leading to a memory leak, possible in functions like
7463 load_charset_map_from_file that can allocate an unbounded number
7464 of objects (Bug#8318).
7466 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7467 that could (at least in theory) be that large.
7469 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7470 This is less likely to overflow, and avoids undefined behavior if
7471 overflow does occur. All callers changed. Use strtoul to scan
7472 for the unsigned long integer.
7473 (pint2hrstr): Simplify and tune code slightly.
7474 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7476 * scroll.c (do_scrolling): Work around GCC bug 48228.
7477 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7479 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7480 This also avoids a warning with gcc -Wstrict-overflow.
7481 (validate_x_resource_name): Simplify count usage.
7482 This also avoids a warning with gcc -Wstrict-overflow.
7484 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7487 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7489 * process.c (Fmake_network_process): Use socklen_t, not int,
7490 where POSIX says socklen_t is required in portable programs.
7491 This fixes a porting bug on hosts like 64-bit HP-UX, where
7492 socklen_t is wider than int (Bug#8277).
7493 (Fmake_network_process, server_accept_connection):
7494 (wait_reading_process_output, read_process_output):
7497 * process.c: Rename or move locals to avoid shadowing.
7498 (list_processes_1, Fmake_network_process):
7499 (read_process_output_error_handler, exec_sentinel_error_handler):
7500 Rename or move locals.
7501 (Fmake_network_process): Define label "retry_connect" only if needed.
7502 (Fnetwork_interface_info): Fix pointer signedness.
7503 (process_send_signal): Add cast to avoid pointer signedness problem.
7504 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7505 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7507 Make tparam.h and terminfo.c consistent.
7508 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7509 Include tparam.h instead, since it declares them.
7510 * cm.h (PC): Remove extern decl; tparam.h now does this.
7511 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7512 * terminfo.c: Include tparam.h, to check interfaces.
7513 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7514 (tparam): Adjust signature to match interface in tparam.h;
7515 this removes some undefined behavior. Check that outstring and len
7516 are zero, which they always are with Emacs.
7517 * tparam.h (PC, BC, UP): New extern decls.
7519 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7520 (xftfont_open): Rename locals to avoid shadowing.
7522 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7523 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7524 (OTF_TAG_SYM): Omit macro if not needed.
7525 (ftfont_list): Remove unused local.
7526 (get_adstyle_property, ftfont_pattern_entity):
7527 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7528 Rename locals to avoid shadowing.
7530 * xfont.c (xfont_list_family): Mark var as initialized.
7532 * xml.c (make_dom): Now static.
7534 * composite.c (composition_compute_stop_pos): Rename local to
7536 (composition_reseat_it): Remove unused locals.
7537 (find_automatic_composition, composition_adjust_point): Likewise.
7538 (composition_update_it): Mark var as initialized.
7539 (find_automatic_composition): Mark vars as initialized,
7540 with a FIXME (Bug#8290).
7542 character.h: Rename locals to avoid shadowing.
7543 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7544 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7545 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7546 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7549 * textprop.c (property_change_between_p): Remove; unused.
7551 * intervals.c (interval_start_pos): Now static.
7553 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7555 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7556 Rename locals to avoid shadowing.
7558 * sound.c (wav_play, au_play, Fplay_sound_internal):
7559 Fix pointer signedness.
7560 (alsa_choose_format): Remove unused local var.
7561 (wav_play): Initialize a variable to 0, to prevent undefined
7562 behavior (Bug#8278).
7564 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7566 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7568 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7569 clobbering (Bug#8298).
7570 * sysdep.c (sys_subshell): Likewise.
7571 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7573 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7574 This should get cleaned up, so that child_setup has the
7575 same signature on all platforms.
7577 * callproc.c (call_process_cleanup): Now static.
7578 (relocate_fd): Rename locals to avoid shadowing.
7580 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7582 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7583 not to be necessary, and produces flickering.
7585 2011-03-20 Glenn Morris <rgm@gnu.org>
7587 * config.in: Remove file.
7589 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7591 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7592 are now in src/globals.h.
7593 (syms_of_minibuf): Remove spurious & from previous change.
7595 2011-03-20 Leo <sdl.web@gmail.com>
7597 * minibuf.c (completing-read-function): New variable.
7598 (completing-read-default): Rename from completing-read.
7599 (completing-read): Call completing-read-function.
7601 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7603 * xfaces.c (Fx_load_color_file):
7604 Read color file from absolute filename (bug#8250).
7606 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7608 * makefile.w32-in: Update dependencies.
7610 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7612 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7614 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7616 Fix more problems found by GCC 4.5.2's static checks.
7618 * process.c (make_serial_process_unwind, send_process_trap):
7619 (sigchld_handler): Now static.
7621 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7622 That way, the code declares only the vars that it needs.
7623 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7624 * s/cygwin.h (PTY_ITERATION): Likewise.
7625 * s/darwin.h (PTY_ITERATION): Likewise.
7626 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7628 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7629 * process.c (allocate_pty): Don't declare stb unless it's needed.
7631 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7632 (CONSTANTLIM): Remove; unused.
7633 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7634 Define only if needed.
7636 * unexelf.c (unexec): Name an expression,
7637 to avoid gcc -Wbad-function-cast warning.
7638 Use a different way to cause a compilation error if anyone uses
7639 n rather than nn, a way that does not involve shadowing.
7640 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7642 * deps.mk (unexalpha.o): Remove; unused.
7644 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7645 * unexec.h: New file.
7646 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7647 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7649 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7650 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7651 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7652 Change as necessary to match prototype in unexec.h.
7654 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7656 (back_comment, skip_chars): Mark vars as initialized.
7658 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7659 Rename locals to avoid shadowing.
7661 * lread.c (read1): Rewrite so as not to use empty "else".
7662 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7664 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7666 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7667 warning when compiling print.c.
7669 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7670 instead of using an uninitialized var.
7671 (font_sort_entities): Mark var as initialized.
7673 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7675 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7676 pointers to constants.
7677 (font_parse_fcname): Remove unused vars.
7678 (font_delete_unmatched): Now static.
7679 (font_get_spec): Remove; unused.
7680 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7681 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7682 Rename or move locals to avoid shadowing.
7684 * fns.c (require_nesting_list, require_unwind): Now static.
7685 (Ffillarray): Rename locals to avoid shadowing.
7687 * floatfns.c (domain_error2): Define only if needed.
7688 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7690 * alloc.c (mark_backtrace): Move decl from here ...
7691 * lisp.h: ... to here, so that it can be checked.
7693 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7694 (Fdefvar): Rewrite so as not to use empty "else".
7695 (lisp_indirect_variable): Name an expression,
7696 to avoid gcc -Wbad-function-cast warning.
7697 (Fdefvar): Rename locals to avoid shadowing.
7699 * callint.c (quotify_arg, quotify_args): Now static.
7700 (Fcall_interactively): Rename locals to avoid shadowing.
7701 Use const pointer when appropriate.
7703 * lisp.h (get_system_name, get_operating_system_release):
7704 Move decls here, to check interfaces.
7705 * process.c (get_operating_system_release): Move decl to lisp.h.
7706 * xrdb.c (get_system_name): Likewise.
7707 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7708 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7709 some of which prompt warnings from gcc -Wbad-function-cast.
7710 (Fformat_time_string, Fencode_time, Finsert_char):
7711 (Ftranslate_region_internal, Fformat):
7712 Rename or remove local vars to avoid shadowing.
7713 (Ftranslate_region_internal): Mark var as initialized.
7715 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7718 * lisp.h (eassert): Check that the argument compiles, even if
7719 ENABLE_CHECKING is not defined.
7721 * data.c (Findirect_variable): Name an expression, to avoid
7722 gcc -Wbad-function-cast warning.
7723 (default_value, arithcompare, arith_driver, arith_error): Now static.
7724 (store_symval_forwarding): Rename local to avoid shadowing.
7725 (Fmake_variable_buffer_local, Fmake_local_variable):
7726 Mark variables as initialized.
7727 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7729 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7730 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7731 Rename locals to avoid shadowing.
7732 (mark_stack): Move local variables into the #ifdef region where
7734 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7735 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7737 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7738 (GC_STRING_CHARS): Remove; not used.
7739 (Fmemory_limit): Cast sbrk's returned value to char *.
7741 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7742 avoids undefined behavior in theory.
7744 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7746 Use functions, not macros, for up- and down-casing (Bug#8254).
7747 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7748 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7749 to use the following functions instead of these macros.
7750 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7751 EMACS_INT, since callers assume the returned value fits in int.
7752 (upcase1): Likewise, for UPCASE_TABLE.
7753 (uppercasep, lowercasep, upcase): New static inline functions.
7754 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7755 the race-condition problem in the old DOWNCASE.
7757 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7758 Rename locals to avoid shadowing.
7759 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7760 (regex_compile, re_search_2, re_match_2_internal):
7761 Remove unused local vars.
7762 (FREE_VAR): Rewrite so as not to use empty "else",
7763 which gcc can warn about.
7764 (regex_compile, re_match_2_internal): Mark locals as initialized.
7765 (RETALLOC_IF): Define only if needed.
7766 (WORDCHAR_P): Likewise. This one is never needed, but is used
7767 only in a comment talking about a compiler bug, so put inside
7768 the #if 0 of that comment.
7769 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7770 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7773 * search.c (boyer_moore): Rename locals to avoid shadowing.
7774 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7775 (PREV_CHAR_BOUNDARY): Likewise.
7777 * search.c (simple_search): Remove unused var.
7779 * dired.c (compile_pattern): Move decl from here ...
7780 * lisp.h: ... to here, so that it can be checked.
7781 (struct re_registers): New forward decl.
7783 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7785 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7787 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7788 Rename locals to avoid shadowing.
7789 (Fvertical_motion): Mark locals as initialized.
7791 * casefiddle.c (casify_object, casify_region): Now static.
7792 (casify_region): Mark local as initialized.
7794 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7796 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7797 New macros, so that the caller can use some names other than
7798 gcpro1, gcpro2, etc.
7799 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7801 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7802 argument, for consistency with GCPRO2_VAR, etc: it is now the
7803 prefix of the variable, not the variable itself. All uses
7805 * dired.c (directory_files_internal, file_name_completion):
7806 Rename locals to avoid shadowing.
7808 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7809 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7810 dired.c's scmp function, had undefined behavior.
7811 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7812 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7813 * buffer.h: ... to here, because these macros use current_buffer,
7814 and the new implementation with inline functions needs to have
7815 current_buffer in scope now, rather than later when the macros
7817 (downcase, upcase1): New static inline functions.
7818 (DOWNCASE, UPCASE1): Reimplement using these functions.
7819 This avoids undefined behavior in expressions like
7820 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7821 from race conditions in accessing the global variables
7822 case_temp1 and case_temp2.
7823 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7824 * lisp.h (case_temp1, case_temp2): Remove their decls.
7825 * character.h (ASCII_CHAR_P): Move from here ...
7826 * lisp.h: ... to here, so that the inline functions mentioned
7829 * dired.c (directory_files_internal_unwind): Now static.
7831 * fileio.c (file_name_as_directory, directory_file_name):
7832 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7834 (file_name_as_directory): Use const pointers when appropriate.
7835 (Fexpand_file_name): Likewise. In particular, newdir might
7836 point at constant storage, so make it a const pointer.
7837 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7838 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7840 (Fset_file_times, Finsert_file_contents, auto_save_error):
7841 Rename locals to avoid shadowing.
7843 * minibuf.c (choose_minibuf_frame_1): Now static.
7844 (Ftry_completion, Fall_completions): Rename or remove locals
7847 * marker.c (bytepos_to_charpos): Remove; unused.
7849 * lisp.h (verify_bytepos, count_markers): New decls,
7850 so that gcc does not warn that these functions aren't declared.
7852 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7853 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7854 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7855 (copy_text): Remove unused local var.
7857 * filelock.c (within_one_second): Now static.
7858 (lock_file_1): Rename local to avoid shadowing.
7860 * buffer.c (fix_overlays_before): Mark locals as initialized.
7861 (fix_start_end_in_overlays): Likewise. This function should be
7862 simplified by using pointers-to-pointers, but that's a different
7864 (switch_to_buffer_1): Now static.
7865 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7866 (report_overlay_modification): Rename locals to avoid shadowing.
7868 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7869 Fix pointer signedness issue.
7870 (sys_subshell): Mark local as volatile if checking for lint,
7871 to suppress a gcc -Wclobbered warning that does not seem to be right.
7872 (MAXPATHLEN): Define only if needed.
7874 * process.c (serial_open, serial_configure): Move decls from here ...
7875 * systty.h: ... to here, so that they can be checked.
7877 * fns.c (get_random, seed_random): Move extern decls from here ...
7878 * lisp.h: ... to here, so that they can be checked.
7880 * sysdep.c (reset_io): Now static.
7881 (wait_for_termination_signal): Remove; unused.
7883 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7884 (copy_keymap_item, append_key, push_text_char_description):
7886 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7887 (DENSE_TABLE_SIZE): Remove; unused.
7888 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7889 (describe_map_tree):
7890 Rename locals to avoid shadowing.
7892 * keyboard.c: Declare functions static if they are not used elsewhere.
7893 (echo_char, echo_dash, cmd_error, top_level_2):
7894 (poll_for_input, handle_async_input): Now static.
7895 (read_char, kbd_buffer_get_event, make_lispy_position):
7896 (make_lispy_event, make_lispy_movement, apply_modifiers):
7897 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7898 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7899 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7900 (read_key_sequence, read_char): Mark locals as initialized.
7901 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7903 * keyboard.h (make_ctrl_char): New decl.
7904 (mark_kboards): Move decl here ...
7905 * alloc.c (mark_kboards): ... from here.
7907 * lisp.h (force_auto_save_soon): New decl.
7909 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7910 (DEFINE_DUMMY_FUNCTION): New macro.
7911 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7913 (main): Add casts to avoid warnings
7914 if GCC considers string literals to be constants.
7916 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7918 * dbusbind.c: Pointer signedness fixes.
7919 (xd_signature, xd_append_arg, xd_initialize):
7920 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7921 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7922 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7923 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7925 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7926 if GCC considers string literals to be constants.
7927 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7929 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7931 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7932 (print_preprocess, print_object): New macro to fix last change.
7934 * print.c (print_preprocess): Don't forget font objects.
7936 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7938 * emacs.c (USAGE3): Doc fixes.
7940 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7942 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7945 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7947 * lisp.h (VWindow_system, Qfile_name_history):
7948 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7949 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7950 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7952 * w32select.c: Don't #include "keyboard.h".
7953 (run_protected): Add extern declaration for waiting_for_input.
7955 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7956 * w32console.c (detect_input_pending, read_input_pending)
7957 (encode_terminal_code):
7958 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7959 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7960 (w32_system_caret_y, Qfile_name_history):
7961 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7962 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7963 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7964 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7965 * w32proc.c (Qlocal, report_file_error):
7966 * w32term.c (Vwindow_system, updating_frame):
7967 * w32uniscribe.c (initialized, uniscribe_font_driver):
7968 Remove unneeded extern declarations.
7970 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7972 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7974 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7976 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7977 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7978 These macros can no longer be used for assignment.
7980 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7981 Assign struct members directly, instead of using BUF_BEGV etc.
7982 (record_buffer_markers, fetch_buffer_markers): New functions for
7983 recording and fetching special buffer markers.
7984 (set_buffer_internal_1, set_buffer_temp): Use them.
7986 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7988 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7990 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7991 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7993 * xdisp.c (hscroll_window_tree):
7994 (reconsider_clip_changes): Use PT instead of BUF_PT.
7996 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7998 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7999 $(EMACS_ROOT)/lib/intprops.h.
8001 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8003 Fix more problems found by GCC 4.5.2's static checks.
8005 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8006 to unsigned char * to avoid compiler diagnostic.
8007 (xg_free_frame_widgets): Make it clear that a local variable is
8008 needed only if USE_GTK_TOOLTIP.
8009 (gdk_window_get_screen): Make it clear that this macro is needed
8010 only if USE_GTK_TOOLTIP.
8011 (int_gtk_range_get_value): New function, which avoids a diagnostic
8012 from gcc -Wbad-function-cast.
8013 (xg_set_toolkit_scroll_bar_thumb): Use it.
8014 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8015 diagnostic from gcc -Wbad-function-cast.
8016 (get_utf8_string, xg_get_file_with_chooser):
8017 Rename locals to avoid shadowing.
8018 (create_dialog): Move locals to avoid shadowing.
8020 * xgselect.c (xg_select): Remove unused var.
8022 * image.c (four_corners_best): Mark locals as initialized.
8023 (gif_load): Initialize transparent_p to zero (Bug#8238).
8024 Mark another local as initialized.
8025 (my_png_error, my_error_exit): Mark with NO_RETURN.
8027 * image.c (clear_image_cache): Now static.
8028 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8029 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8030 (x_edge_detection): Remove unnecessary cast that
8031 gcc -Wbad-function-cast diagnoses.
8032 (gif_load): Fix pointer signedness.
8033 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8034 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8036 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8038 Improve quality of tests for time stamp overflow.
8039 For example, without this patch (encode-time 0 0 0 1 1
8040 1152921504606846976) returns the obviously-bogus value (-948597
8041 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8042 reports time overflow. See
8043 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8044 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8045 * editfns.c: Include limits.h and intprops.h.
8046 (TIME_T_MIN, TIME_T_MAX): New macros.
8047 (time_overflow): Move earlier, to before first use.
8048 (hi_time, lo_time): New functions, for an accurate test for
8050 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8051 (Fget_internal_run_time): Don't assume time_t fits in int.
8052 (make_time): Use list2 instead of Fcons twice.
8053 (Fdecode_time): More accurate test for out-of-range times.
8054 (check_tm_member): New function.
8055 (Fencode_time): Use it, to test for out-of-range times.
8056 (lisp_time_argument): Don't rely on undefined left-shift and
8057 right-shift behavior when checking for time stamp overflow.
8059 * editfns.c (time_overflow): New function, refactoring common code.
8060 (Fformat_time_string, Fdecode_time, Fencode_time):
8061 (Fcurrent_time_string): Use it.
8063 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8064 * dired.c (make_time): Move to ...
8065 * editfns.c (make_time): ... here.
8066 * systime.h: Note the move.
8068 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8070 * fringe.c (update_window_fringes): Remove unused variables.
8072 * unexmacosx.c (copy_data_segment): Also copy __got section.
8075 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8077 * termcap.c [MSDOS]: Include "msdos.h".
8078 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8079 Constify `char *' arguments and their references according to
8080 prototypes in tparam.h.
8082 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8084 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8085 Adapt all references accordingly.
8087 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8089 2011-03-11 Tom Tromey <tromey@redhat.com>
8091 * buffer.c (syms_of_buffer): Remove obsolete comment.
8093 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8095 * termhooks.h (encode_terminal_code): Declare prototype.
8097 * msdos.c (encode_terminal_code): Don't declare prototype.
8099 * term.c (encode_terminal_code): Now external again, used by
8100 w32console.c and msdos.c.
8102 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8103 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8105 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8107 Fix some minor problems found by GCC 4.5.2's static checks.
8109 * fringe.c (update_window_fringes): Mark locals as initialized
8111 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8113 * alloc.c (mark_fringe_data): Move decl from here ...
8114 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8115 to check its interface.
8116 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8118 * fontset.c (free_realized_fontset): Now static.
8119 (Fset_fontset_font): Rename local to avoid shadowing.
8120 (fontset_font): Mark local as initialized.
8121 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8123 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8125 * xselect.c (x_disown_buffer_selections): Remove; not used.
8126 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8127 (x_own_selection, Fx_disown_selection_internal): Rename locals
8129 (x_handle_dnd_message): Remove local to avoid shadowing.
8131 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8132 so that the caller can use some name other than gcpro1.
8133 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8134 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8135 (Fx_backspace_delete_keys_p):
8136 Use them to avoid shadowing, and rename vars to avoid shadowing.
8137 (x_decode_color, x_set_name, x_window): Now static.
8138 (Fx_create_frame): Add braces to silence GCC warning.
8139 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8140 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8141 Remove unused locals.
8142 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8143 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8144 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8147 * xterm.h (x_mouse_leave): New decl.
8149 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8150 Remove unused functions.
8151 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8152 (x_calc_absolute_position): Now static.
8153 (XTread_socket): Don't define label "out" unless it's used.
8154 Don't declare local "event" unless it's used.
8155 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8156 unless they are used.
8157 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8158 (x_fatal_error_signal): Remove; not used.
8159 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8160 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8161 (x_error_catcher, x_connection_closed, x_error_handler):
8162 (x_error_quitter, xembed_send_message, x_iconify_frame):
8163 (my_log_handler): Rename locals to avoid shadowing.
8164 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8165 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8167 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8168 Rename or move locals to avoid shadowing.
8169 (tty_defined_color, merge_face_heights): Now static.
8170 (free_realized_faces_for_fontset): Remove; not used.
8171 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8172 does not deduce is never used uninitialized.
8173 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8174 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8176 * terminal.c (store_terminal_param): Now static.
8178 * xmenu.c (menu_highlight_callback): Now static.
8179 (set_frame_menubar): Remove unused local.
8180 (xmenu_show): Rename parameter to avoid shadowing.
8181 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8182 since they might point to immutable storage.
8183 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8184 since it's unused otherwise.
8186 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8187 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8188 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8189 avoids a gcc -Wuninitialized diagnostic.
8190 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8191 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8192 does not deduce are never used uninitialized.
8194 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8196 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8197 * window.c (window_loop, size_window):
8198 (run_window_configuration_change_hook, enlarge_window): Likewise.
8200 * window.c (display_buffer): Now static.
8201 (size_window): Mark variables that gcc -Wuninitialized
8202 does not deduce are never used uninitialized.
8203 * window.h (check_all_windows): New decl, to forestall
8204 gcc -Wmissing-prototypes diagnostic.
8205 * dispextern.h (bidi_dump_cached_states): Likewise.
8207 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8209 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8211 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8212 and to avoid gcc -Wuninitialized warning.
8213 (load_charset_map): Mark variables that gcc -Wuninitialized
8214 does not deduce are never used uninitialized.
8215 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8217 * coding.c (coding_set_source, coding_set_destination):
8218 Use "else { /* comment */ }" rather than "else /* comment */;"
8219 for clarity, and to avoid gcc -Wempty-body warning.
8220 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8221 a block, when the outer 'i' will do.
8222 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8223 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8224 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8225 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8226 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8227 Rename locals to avoid shadowing.
8228 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8229 * coding.c (emacs_mule_char, encode_invocation_designation):
8230 Now static, since they're not used elsewhere.
8231 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8232 (decode_coding_object, encode_coding_object, detect_coding_system):
8233 (decode_coding_emacs_mule): Mark variables that gcc
8234 -Wuninitialized does not deduce are never used uninitialized.
8235 (detect_coding_iso_2022): Initialize a local variable that might
8236 be used uninitialized. Leave a FIXME because it's not clear that
8237 this initialization is needed. (Bug#8211)
8238 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8239 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8240 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8241 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8242 Remove unused macros.
8244 * category.c (hash_get_category_set): Remove unused local var.
8245 (copy_category_table): Now static, since it's not used elsewhere.
8246 * character.c (string_count_byte8): Likewise.
8248 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8249 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8251 * chartab.c (copy_sub_char_table): Now static, since it's not used
8253 (sub_char_table_ref_and_range, char_table_ref_and_range):
8254 Rename locals to avoid shadowing.
8255 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8257 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8258 (BIDI_BOB): Remove unused macro.
8260 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8261 deduce are never used uninitialized.
8262 * term.c (encode_terminal_code): Likewise.
8264 * term.c (encode_terminal_code): Now static. Remove unused local.
8266 * tparam.h: New file.
8267 * term.c, tparam.h: Include it.
8268 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8269 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8270 Move these decls to tparam.h, and make them agree with what
8271 is actually in tparam.c. The previous trick of using incompatible
8272 decls in different modules does not conform to the C standard.
8273 All callers of tparam changed to use tparam's actual API.
8274 * tparam.c (tparam1, tparam, tgoto):
8275 Use const pointers where appropriate.
8277 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8278 * cm.h (struct cm): Likewise.
8279 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8280 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8281 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8282 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8283 (turn_on_face, init_tty): Likewise.
8284 * termchar.h (struct tty_display_info): Likewise.
8286 * term.c (term_mouse_position): Rename local to avoid shadowing.
8288 * alloc.c (mark_ttys): Move decl from here ...
8289 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8291 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8293 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8295 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8297 * search.c (compile_pattern_1): Remove argument regp, unused since
8298 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8299 (compile_pattern): Don't pass it.
8301 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8303 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8304 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8306 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8308 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8310 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8311 gdk_window_get_screen, gdk_window_get_geometry,
8312 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8313 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8314 (xg_get_pixbuf_from_pixmap): New function.
8315 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8316 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8317 Call xg_get_pixbuf_from_pixmap instead of
8318 gdk_pixbuf_get_from_drawable.
8319 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8320 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8321 (xg_check_special_colors): Use GtkStyleContext and its functions
8323 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8324 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8325 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8326 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8327 Call gtk_widget_get_preferred_size.
8328 (xg_frame_resized): gdk_window_get_geometry only takes 5
8330 (xg_win_to_widget, xg_event_is_for_menubar):
8331 Call gdk_x11_window_lookup_for_display.
8332 (xg_set_widget_bg): New function.
8333 (delete_cb): New function.
8334 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8335 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8336 (xg_set_background_color): Call xg_set_widget_bg.
8337 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8338 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8339 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8340 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8342 (update_frame_tool_bar): Call gtk_widget_hide.
8343 (xg_initialize): Use GDK_KEY_g.
8345 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8347 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8349 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8350 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8351 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8353 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8355 * w32xfns.c (select_palette): Check success of RealizePalette against
8356 GDI_ERROR, not zero.
8358 See ChangeLog.11 for earlier changes.
8364 Copyright (C) 2011 Free Software Foundation, Inc.
8366 This file is part of GNU Emacs.
8368 GNU Emacs is free software: you can redistribute it and/or modify
8369 it under the terms of the GNU General Public License as published by
8370 the Free Software Foundation, either version 3 of the License, or
8371 (at your option) any later version.
8373 GNU Emacs is distributed in the hope that it will be useful,
8374 but WITHOUT ANY WARRANTY; without even the implied warranty of
8375 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8376 GNU General Public License for more details.
8378 You should have received a copy of the GNU General Public License
8379 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.