1 2012-05-25 Glenn Morris <rgm@gnu.org>
3 * lisp.mk (lisp): Update for more files being compiled now.
5 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7 * lread.c: Remove `read_pure' which makes no difference.
8 (read_pure): Remove var.
9 (unreadpure): Remove function.
10 (readevalloop): Don't call read_list with -1 flag.
11 (read1, read_vector): Don't test read_pure any more.
12 (read_list): Simplify.
14 * fileio.c, character.h: Minor style tweaks.
16 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
18 * window.h (clip_changed): Remove useless declaration.
20 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
22 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
23 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
25 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
28 This directory predates autoconf and is no longer needed nowadays.
29 Move its few remaining bits of functionality to where they're needed.
30 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
31 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
32 * m/template.h: Remove.
33 * Makefile.in (M_FILE): Remove. All uses removed.
34 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
35 * lisp.h (USE_LSB_TAG):
36 * mem-limits.h (EXCEEDS_LISP_PTR):
37 Use VAL_MAX, not VALBITS, in #if.
38 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
39 (EMACS_UINT): Define unconditionally now.
40 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
41 (BITS_PER_EMACS_INT): New constants, replacing
42 what used to be in config.h, but not useful in #if.
43 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
47 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
48 BITS_PER_EMACS_INT, in #if.
49 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
50 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
51 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
52 * s/ms-w32.h (DATA_START):
53 Move here from removed file m/intel386.h.
54 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
55 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
57 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
60 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
61 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
63 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
64 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
65 * textprop.c, tparam.c (NULL): Remove.
66 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
67 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
68 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
69 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
70 * xterm.c (input_signal_count): Assume volatile works.
72 2012-05-21 Ken Brown <kbrown@cornell.edu>
74 * xgselect.c (xg_select): Fix first argument in call to 'select'
77 2012-05-20 Ken Brown <kbrown@cornell.edu>
79 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
80 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
82 2012-05-19 Ken Brown <kbrown@cornell.edu>
84 * xfns.c (x_in_use): Remove `static' qualifier.
85 * xterm.h (x_in_use): Declare.
86 * xgselect.c: Include xterm.h.
87 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
88 and `display_arg' (bug#9754).
90 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
92 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
94 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
95 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
97 2012-05-18 Eli Zaretskii <eliz@gnu.org>
99 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
101 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
102 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
104 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
105 reference to image_cache->refcount.
106 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
108 2012-05-17 Juri Linkov <juri@jurta.org>
110 * search.c (Fword_search_regexp, Fword_search_backward)
111 (Fword_search_forward, Fword_search_backward_lax)
112 (Fword_search_forward_lax): Move functions to isearch.el
113 (bug#10145, bug#11381).
115 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
117 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
119 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
121 * lread.c (init_obarray): Declare Qt and Qnil as special.
123 2012-05-14 Glenn Morris <rgm@gnu.org>
125 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
126 Put "libexec" before "bin", for the sake of init_callproc_1.
128 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
130 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
132 * unexaix.c: Port to more-recent AIX compilers.
133 (report_error, report_error_1, make_hdr, copy_sym)
134 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
135 Make arguments const char *, not char *, to avoid violations of C
136 standard and to fix some AIX warnings reported by Gilles Pion.
138 2012-05-14 Eli Zaretskii <eliz@gnu.org>
140 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
141 already have overlays loaded.
142 (handle_single_display_spec): Before returning without displaying
143 fringe bitmap, synchronize the bidi iterator with the main display
144 iterator, by calling iterate_out_of_display_property.
145 (iterate_out_of_display_property): Detect buffer iteration by
146 testing that it->string is a Lisp string.
147 (get_next_display_element): When the current object is exhausted,
148 and there's something on it->stack, call set_iterator_to_next to
149 proceed with what's on the stack, instead of returning zero.
150 (set_iterator_to_next): If called at the end of a Lisp string,
151 proceed to consider_string_end without incrementing string
152 position. Don't increment display vector index past the end of
153 the display vector. (Bug#11417)
154 (pos_visible_p): Don't report a position visible when move_it_to
155 stopped at the last line of window, which happens to be scanned
156 backwards by the bidi iteration. (Bug#11464)
158 2012-05-14 Eli Zaretskii <eliz@gnu.org>
160 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
161 and right-margin display specs even if the spec is invalid or we
162 are on a TTY, and thus unable to display on the fringes. That's
163 because the text with the property will not be displayed anyway,
164 so we need to signal to the caller that this is a "replacing"
165 display spec. This fixes display when the spec is invalid or we
168 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
170 * unexaix.c (make_hdr): Fix typo in prototype.
171 This bug broke the build on AIX. Problem reported by Gilles Pion.
173 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
175 * keyboard.c (kbd_buffer_get_event): Read special events also in
176 batch mode. (Bug#11415)
178 2012-05-12 Glenn Morris <rgm@gnu.org>
180 * ns.mk: Update for ns_appbindir no longer having trailing "/".
182 2012-05-12 Eli Zaretskii <eliz@gnu.org>
184 * lisp.mk (lisp): Add newcomment.elc.
186 2012-05-12 Glenn Morris <rgm@gnu.org>
188 * Makefile.in (MKDIR_P): New, set by configure.
189 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
191 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
193 Remove unused function hourglass_started.
194 * dispextern.h (hourglass_started):
195 * w32fns.c (hourglass_started):
196 * xdisp.c (hourglass_started): Remove.
198 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
200 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
203 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
205 * xgselect.c (xg_select): Put maxfds+1 into a var.
206 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
208 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
210 2012-05-10 Dave Abrahams <dave@boostpro.com>
212 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
213 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
215 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
217 * dbusbind.c (xd_registered_buses): New internal Lisp object.
218 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
219 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
220 Initialize xd_registered_buses.
222 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
224 Untag more efficiently if USE_LSB_TAG.
225 This is based on a proposal by YAMAMOTO Mitsuharu in
226 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
227 For an admittedly artificial (nth 8000 longlist) benchmark on
228 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
229 Emacs's overall text size by 1%.
230 * lisp.h (XUNTAG): New macro.
231 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
232 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
233 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
234 * eval.c (Fautoload):
235 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
236 * frame.h (XFRAME): Use XUNTAG.
238 Port recent dbusbind.c changes to 32-bit --with-wide-int.
239 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
240 Remove unportable assumptions about print widths of types like
242 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
243 intptr_t when converting between pointer and integer, to avoid GCC
244 warnings about wrong width.
246 2012-05-09 Eli Zaretskii <eliz@gnu.org>
248 * w32proc.c (new_child): Force Windows to reserve only 64KB of
249 stack for each reader_thread, instead of defaulting to 8MB
250 determined by the linker. This avoids failures in creating
251 subprocesses on Windows 7, see the discussion in this thread:
252 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
254 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
256 Fix up display of the *Minibuf-0* buffer in the mini window.
257 * keyboard.c (read_char): Don't clear the echo area if there's no
259 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
260 contents of *Minibuf-0*) if there's no message displayed in its stead.
262 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
264 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
267 2012-05-06 Chong Yidong <cyd@gnu.org>
269 * lisp.mk (lisp): Update.
271 2012-05-05 Jim Meyering <meyering@redhat.com>
273 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
275 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
277 * data.c (PUT_ERROR): New macro.
278 (syms_of_data): Use it. Add new error type `user-error'.
279 * undo.c (user_error): New function.
280 (Fprimitive_undo): Use it.
281 * print.c (print_error_message): Adjust print style for `user-error'.
282 * keyboard.c (user_error): New function.
283 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
285 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
287 Do not limit current-time-string to years 1000..9999.
288 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
289 (Fcurrent_time_string): Support any year that is supported by the
290 underlying localtime representation. Don't use asctime, as it
291 has undefined behavior for years outside the range -999..9999.
293 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
295 Fix race conditions involving setenv, gmtime, localtime, asctime.
296 Without this fix, interrupts could mess up code that uses these
297 nonreentrant functions, since setting TZ invalidates existing
298 tm_zone or tzname values, and since most of these functions return
299 pointers to static storage.
300 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
301 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
302 Grow the critical sections to include not just invoking
303 localtime/gmtime, but also accessing these functions' results
304 including their tm_zone values if any, and any related TZ setting.
305 (format_time_string): Last arg is now struct tm *, not struct tm **,
306 so that the struct tm is saved in the critical section.
307 All callers changed. Simplify allocation of initial buffer, partly
308 motivated by the fact that memory allocation needs to be outside
309 the critical section.
311 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
313 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
316 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
317 Remove duplicated buffer name initialization.
319 2012-05-02 Jim Meyering <jim@meyering.net>
321 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
323 * xfns.c (x_window): Use xstrdup (Bug#11375).
325 2012-05-02 Eli Zaretskii <eliz@gnu.org>
327 * xdisp.c (pos_visible_p): If already at a newline from the
328 display string before the 'while' loop, don't walk back the glyphs
329 from it3.glyph_row. Solves assertion violation when the display
330 string begins with a newline (egg.el). (Bug#11367)
332 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
334 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
337 2012-05-01 Glenn Morris <rgm@gnu.org>
339 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
340 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
341 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
342 All were removed before 23.1.
344 * dispnew.c: Remove HAVE_LIBNCURSES test;
345 it is always true on relevant platforms.
347 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
348 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
350 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
352 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
354 * .gdbinit (xpr): Remove checks for no longer existing misc types.
355 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
358 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
360 Do not avoid creating empty evaporating overlays (Bug#9642).
361 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
362 That is, do not delete an evaporating overlay if it becomes
363 empty after its bounds are adjusted to fit within its buffer.
364 This fix caused other problems, and I'm reverting it until we get
365 to the bottom of them.
367 2012-04-27 Chong Yidong <cyd@gnu.org>
369 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
371 2012-04-27 Eli Zaretskii <eliz@gnu.org>
373 * xdisp.c (pos_visible_p): If the window start position is beyond
374 ZV, start the display from buffer beginning. Prevents assertion
375 violation in init_iterator when the minibuffer window is scrolled
378 * window.c (window_scroll_pixel_based): Likewise.
380 2012-04-27 Chong Yidong <cyd@gnu.org>
382 * keymap.c (where_is_internal): Doc fix (Bug#10872).
384 2012-04-27 Glenn Morris <rgm@gnu.org>
386 * fileio.c (Fcopy_file, Fset_file_selinux_context):
387 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
389 2012-04-27 Eli Zaretskii <eliz@gnu.org>
391 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
392 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
394 2012-04-26 Eli Zaretskii <eliz@gnu.org>
396 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
397 display element, check also the underlying string or buffer
398 character. (Bug#11341)
400 * w32menu.c: Include w32heap.h.
401 (add_menu_item): If the call to AppendMenuW (via
402 unicode_append_menu) fails, disable Unicode menus only if we are
403 running on Windows 9X/Me.
405 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
407 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
408 (xgetint): Add missing shift for LSB tags.
410 2012-04-24 Martin Rudalics <rudalics@gmx.at>
412 * keyboard.c (read_char): Don't wipe echo area for select window
413 events: These might get delayed via `mouse-autoselect-window'
416 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
418 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
419 manipulation of :loaded-from data.
421 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
423 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
424 now a cons (bug#11311).
426 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
428 Do not create empty overlays with the evaporate property (Bug#9642).
429 * buffer.c (Fmove_overlay): Delete an evaporating overlay
430 if it becomes empty after its bounds are adjusted to fit within
431 its buffer. Without this fix, in a nonempty buffer (let ((o
432 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
433 yields an empty overlay that has the evaporate property, which is
434 not supposed to happen.
436 Fix minor GTK3 problems found by static checking.
437 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
438 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
439 (struct _EmacsFixedClass, emacs_fixed_get_type):
440 Move decls here from emacsgtkfixed.h, since they needn't be public.
441 (emacs_fixed_get_type): Now static.
442 (emacs_fixed_class_init): Omit unused local.
443 (emacs_fixed_child_type): Remove; unused.
444 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
445 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
446 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
447 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
448 (EMACS_FIXED_GET_CLASS): Remove; unused.
449 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
451 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
452 Problem reported by Juanma Barranquero for Windows -Wunused-function.
454 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
456 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
457 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
458 (__malloc_size_t, __malloc_ptrdiff_t):
459 Remove. All uses removed, replaced by the definiens if needed,
460 since we can assume C89 or better now.
461 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
462 (protect_malloc_state, align, get_contiguous_space)
463 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
464 (malloc_atfork_handler_child, malloc_enable_thread)
465 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
466 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
467 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
468 (special_realloc, _realloc_internal_nolock, _realloc_internal)
469 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
470 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
471 Define using prototypes, not old style.
472 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
473 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
474 (align): Don't assume that signed integer overflow wraps around.
475 Omit unused local var.
476 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
477 (_free_internal_nolock, memalign, mallochook, reallochook):
478 Omit no-longer-needed casts.
479 (valloc): Use getpagesize, not __getpagesize.
480 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
481 (struct hdr): The 'magic' member is now size_t, not unsigned long.
483 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
485 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
487 Move functions from C to Lisp. Make non-blocking method calls
488 the default. Implement further D-Bus standard interfaces.
490 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
491 (QCdbus_request_name_allow_replacement)
492 (QCdbus_request_name_replace_existing)
493 (QCdbus_request_name_do_not_queue)
494 (QCdbus_request_name_reply_primary_owner)
495 (QCdbus_request_name_reply_in_queue)
496 (QCdbus_request_name_reply_exists)
497 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
498 (QCdbus_registered_serial, QCdbus_registered_method)
499 (QCdbus_registered_signal): New Lisp objects.
500 (XD_DEBUG_MESSAGE): Use sizeof.
501 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
502 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
503 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
504 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
505 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
506 (xd_signature, xd_append_arg): Allow float for integer types.
507 (xd_get_connection_references): New function.
508 (xd_get_connection_address): Rename from xd_initialize.
509 Return cached address.
510 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
511 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
513 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
514 Return number of refcounts.
515 (Fdbus_get_unique_name): Make stronger parameter check.
516 (Fdbus_message_internal): New defun.
517 (Fdbus_call_method, Fdbus_call_method_asynchronously)
518 (Fdbus_method_return_internal, Fdbus_method_error_internal)
519 (Fdbus_send_signal, Fdbus_register_service)
520 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
521 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
522 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
523 (Vdbus_compiled_version, Vdbus_runtime_version)
524 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
525 (Vdbus_message_type_method_return, Vdbus_message_type_error)
526 (Vdbus_message_type_signal): New defvars.
527 (Vdbus_registered_buses, Vdbus_registered_objects_table):
530 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
532 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
533 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
534 Do not assume ptrdiff_t is the same width as 'int'.
536 * alloc.c: Handle unusual debugging option combinations.
537 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
538 since the two debugging options are incompatible.
539 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
541 (mem_init, mem_insert, mem_insert_fixup):
542 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
543 (NEED_MEM_INSERT): Remove; no longer needed.
545 2012-04-22 Leo Liu <sdl.web@gmail.com>
547 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
549 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
551 * sysdep.c [__FreeBSD__]: Minor cleanups.
552 (list_system_processes, system_process_attributes) [__FreeBSD__]:
553 Use Emacs indenting style more consistently. Avoid some casts.
554 Use 'double' consistently rather than mixing 'float' and 'double'.
556 2012-04-21 Eduard Wiebe <usenet@pusto.de>
558 * sysdep.c (list_system_processes, system_process_attributes):
559 Add implementation for FreeBSD (Bug#5243).
561 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
563 * lisp.mk (lisp): Update.
565 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
567 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
568 It is never used otherwise.
570 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
572 * print.c (print_preprocess): Only check print_depth if print-circle
574 (print_object): Check for cycles even when print-circle is nil and
575 print-gensym is t, but only check print_depth if print-circle is nil.
577 2012-04-20 Chong Yidong <cyd@gnu.org>
579 * process.c (wait_reading_process_output): If EIO occurs on a pty,
580 set the status to "failed" and ensure that sentinel is run.
582 2012-04-20 Glenn Morris <rgm@gnu.org>
584 * process.c (Fset_process_inherit_coding_system_flag)
585 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
586 (Fmake_network_process, Fmake_serial_process): Doc fix.
588 2012-04-20 Eli Zaretskii <eliz@gnu.org>
590 * xdisp.c (string_buffer_position_lim): Limit starting position to
592 (set_cursor_from_row): If called for a mode-line or header-line
593 row, return zero immediately.
594 (try_cursor_movement): If inside continuation line, don't back up
595 farther than the first row after the header line, if any.
596 Don't consider the header-line row as "partially visible", even if
597 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
599 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
601 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
604 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
605 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
607 configure: new option --enable-gcc-warnings (Bug#11207)
608 * Makefile.in (C_WARNINGS_SWITCH): Remove.
609 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
610 (ALL_CFLAGS): Use new macros rather than old.
611 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
612 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
613 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
614 -Wunused-result, -Wunused-variable. This should go away once
615 the Emacs and Gnulib regex code is merged.
616 (xmalloc, xrealloc): Now static.
618 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
620 * dired.c (Fsystem_groups): Remove unused local.
622 2012-04-17 Glenn Morris <rgm@gnu.org>
624 * dired.c (Fsystem_users): Doc fix.
626 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
628 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
629 (syms_of_dired): Add them.
631 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
633 Fix minor alloc.c problems found by static checking.
634 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
635 New extern decls, to avoid calling undeclared functions.
636 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
637 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
638 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
639 (NEED_MEM_INSERT): New macro.
640 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
641 Remove one incorrect comment and fix another.
643 Fix minor ralloc.c problems found by static checking.
644 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
645 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
646 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
647 (r_alloc_sbrk): Now static.
649 Improve ralloc.c interface checking.
650 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
651 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
652 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
653 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
654 [REL_ALLOC]: ... to here, to check interface.
655 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
656 Remove decls. This fixes an "It stinks!".
658 * alloc.c (which_symbols): Fix alignment issue / type clash.
660 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
662 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
663 (struct Lisp_Misc_Any): Likewise.
664 (struct Lisp_Free): Likewise.
665 * alloc.c (union aligned_Lisp_Symbol): Define.
666 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
667 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
668 (union aligned_Lisp_Misc): Define.
669 (MARKER_BLOCK_SIZE, struct marker_block): Use union
670 aligned_Lisp_Misc instead of union Lisp_Misc.
671 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
673 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
675 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
676 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
677 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
678 * s/netbsd.h, s/sol2-6.h:
679 Remove definition of GC_MARK_STACK, since the default now works.
680 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
681 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
682 no longer the default.
683 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
685 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
687 * lread.c (lisp_file_lexically_bound_p):
688 Fix hang at ";-*-\n" (bug#11238).
690 2012-04-14 Eli Zaretskii <eliz@gnu.org>
692 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
693 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
695 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
697 * nsterm.m (constrainFrameRect): Always constrain when there is only
698 one screen (Bug#10962).
700 2012-04-13 Ken Brown <kbrown@cornell.edu>
702 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
704 2012-04-13 Reuben Thomas <rrt@sc3d.org>
706 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
708 2012-04-11 Daniel Colascione <dancol@dancol.org>
710 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
711 against is gone. It's better to use vfork now so that when Cygwin
712 gains a new, working vfork, we use it automatically (bug#10398).
714 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
716 * window.c (save_window_save): Obey window-point-insertion-type.
718 2012-04-11 Glenn Morris <rgm@gnu.org>
720 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
722 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
724 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
726 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
728 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
729 (force_quit_count): New var.
730 (handle_interrupt): Use it.
732 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
734 * w32.c (w32_delayed_load): Record the full path of the library
735 being loaded (bug#10424).
737 2012-04-09 Glenn Morris <rgm@gnu.org>
739 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
740 not just in the obarray, before snarfing them. (Bug#11036)
742 * Makefile.in ($(leimdir)/leim-list.el):
743 Pass EMACS rather than BUILT_EMACS.
745 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
747 * process.c (make_process):
748 * process.h: Add integer `gnutls_handshakes_tried' member to
751 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
752 Add convenience `GNUTLS_LOG2i' macro.
754 * gnutls.c (gnutls_log_function2i): Convenience log function.
755 (emacs_gnutls_read): Use new log functions,
756 `gnutls_handshakes_tried' process member, and
757 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
758 attempts per process (connection).
760 2012-04-09 Chong Yidong <cyd@gnu.org>
762 * eval.c (Fuser_variable_p, user_variable_p_eh)
763 (lisp_indirect_variable): Functions deleted.
764 (Fdefvar): Caller changed.
766 * callint.c (Finteractive, Fcall_interactively):
767 * minibuf.c (Fread_variable): Callers changed.
769 2012-04-09 Eli Zaretskii <eliz@gnu.org>
771 * xdisp.c (set_cursor_from_row): If the display string appears in
772 the buffer at position that is closer to point than the position
773 after the display string, display the cursor on the first glyph of
774 the display string. Fixes cursor display when a 'display' text
775 property immediately follows invisible text. (Bug#11094)
777 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
779 composite.c: use 'double' consistently
780 * composite.c (get_composition_id): Use 'double' consistently
781 instead of converting 'float' to 'double' and vice versa; this is
782 easier to understand and avoids a GCC warning.
784 2012-04-09 Glenn Morris <rgm@gnu.org>
786 * Makefile.in: Generate leim-list with bootstrap-emacs, in
787 preparation for dumping it with emacs. (Bug#4789)
788 (leimdir): New variable.
789 ($(leimdir)/leim-list.el): New rule.
790 (emacs$(EXEEXT)): Depend on leim-list.el.
792 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
793 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
794 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
796 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
798 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
801 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
803 * xml.c (init_libxml2_functions) [WINDOWSNT]:
804 Remove unused local variable.
806 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
808 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
809 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
810 (mark_memory): Mark Lisp_Objects only if pointers might hide in
811 objects, as mark_maybe_pointer will catch them otherwise.
812 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
813 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
815 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
817 Fix typo that broke non-Windows builds.
818 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
820 2012-04-07 Eli Zaretskii <eliz@gnu.org>
822 Support building on MS-Windows with libxml2.
824 * makefile.w32-in (OBJ2): Add xml.$(O).
825 (GLOBAL_SOURCES): Add xml.c.
826 ($(BLD)/xml.$(O)): New dependency list.
828 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
829 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
830 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
831 [!WINDOWSNT]: New macros.
832 (init_libxml2_functions, libxml2_loaded_p): New functions.
833 (parse_region): Call fn_xmlCheckVersion instead of using the macro
834 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
835 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
836 Calls xmlCleanupParser only if libxml2 was loaded (or statically
838 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
839 Call init_libxml2_functions before calling libxml2 functions.
840 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
842 * emacs.c: Don't include libxml/parser.h.
843 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
844 xmlCleanupParser directly.
846 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
848 2012-04-07 Eli Zaretskii <eliz@gnu.org>
850 * indent.c (Fvertical_motion): If there is a display string at
851 point, use it.vpos to compute how many lines to backtrack after
852 move_it_to point. (Bug#11133)
854 2012-04-06 Eli Zaretskii <eliz@gnu.org>
856 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
857 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
858 about subtle differences between FETCH_CHAR* and STRING_CHAR*
859 macros related to unification of CJK characters. For the details,
860 see the discussion following the message here:
861 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
863 2012-04-04 Chong Yidong <cyd@gnu.org>
865 * keyboard.c (Vdelayed_warnings_list): Doc fix.
867 2012-04-01 Eli Zaretskii <eliz@gnu.org>
869 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
870 instead of alloca. (Bug#11138)
872 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
874 * w32menu.c (is_simple_dialog): Properly check lisp types.
877 2012-03-31 Eli Zaretskii <eliz@gnu.org>
879 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
880 position we get to after a call to move_it_to fails the
881 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
882 only if we wind up in a string from display property. (Bug#11063)
884 * window.c (Fdelete_other_windows_internal): Invalidate the row
885 and column information about mouse highlight, so that redisplay
886 restores it after reallocating the glyph matrices. (Bug#7464)
888 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
889 string comes from a `display' text property, use the buffer
890 position of that property as if we actually saw that position in
892 (move_it_by_lines): Remove the assertion that
893 "it->current_x == 0 && it->hpos == 0" which can be legitimately
894 violated when there's a before-string at the beginning of a line.
897 2012-03-30 Eli Zaretskii <eliz@gnu.org>
899 * xdisp.c (append_space_for_newline): If the default face was
900 remapped, use the remapped face for the appended newline.
901 (extend_face_to_end_of_line): Use the remapped default face for
902 extending the face to the end of the line.
903 (display_line): Call extend_face_to_end_of_line when the default
904 face was remapped. (Bug#11068)
906 2012-03-29 Eli Zaretskii <eliz@gnu.org>
908 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
910 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
912 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
914 2012-03-27 Glenn Morris <rgm@gnu.org>
916 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
919 2012-03-26 Kenichi Handa <handa@m17n.org>
921 * dispextern.h (struct glyph): Fix previous change. Change the
922 bit length of glyphless.ch to 25 (Bug#11082).
924 2012-03-26 Chong Yidong <cyd@gnu.org>
926 * keyboard.c (Vselection_inhibit_update_commands): New variable.
927 (command_loop_1): Use it; inhibit selection update for
928 handle-select-window too (Bug#8996).
930 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
932 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
934 2012-03-25 Kenichi Handa <handa@m17n.org>
936 * dispextern.h (struct glyph): Change the bit length of
937 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
939 2012-03-24 Eli Zaretskii <eliz@gnu.org>
941 * s/ms-w32.h (tzname): Include time.h before redirecting to
942 _tzname. Fixes the MSVC build. (Bug#9960)
944 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
946 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
949 * xterm.c (XTread_socket): Only modify handling_signal if
950 !SYNC_INPUT. (Bug#11080)
952 2012-03-23 Eli Zaretskii <eliz@gnu.org>
954 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
955 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
956 when fetching a multibyte character consumes more bytes than
957 CHAR_BYTES returns, due to unification of CJK characters in
958 string_char. (Bug#11073)
960 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
962 * process.c (wait_reading_process_output): Handle pty disconnect
963 by refraining from sending oneself a SIGCHLD (bug#10933).
965 2012-03-22 Chong Yidong <cyd@gnu.org>
967 * dispextern.h (struct it): New member string_from_prefix_prop_p.
969 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
970 Mark string as coming from a prefix property.
971 (handle_face_prop): Use default face for prefix strings (Bug#4281).
972 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
974 2012-03-21 Chong Yidong <cyd@gnu.org>
976 * xfaces.c (Vface_remapping_alist): Doc fix.
978 2012-03-20 Eli Zaretskii <eliz@gnu.org>
980 * w32proc.c (Fw32_set_console_codepage)
981 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
984 2012-03-20 Chong Yidong <cyd@gnu.org>
986 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
987 to reflect default non-nil value of redisplay-dont-pause.
989 2012-03-19 Kenichi Handa <handa@m17n.org>
991 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
992 it fit in a valid range (Bug#11003).
994 2012-03-18 Eli Zaretskii <eliz@gnu.org>
996 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
997 that is not from display property, accept the row as a "cursor
998 row" if one of the string's character has a non-nil `cursor'
999 property. Fixes cursor positioning when there are newlines in
1000 overlay strings, e.g. in icomplete.el. (Bug#11035)
1002 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1004 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1006 2012-03-12 Chong Yidong <cyd@gnu.org>
1008 * eval.c (inhibit_lisp_code): Rename from
1009 inhibit_window_configuration_change_hook; move from window.c.
1011 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1012 * window.c (run_window_configuration_change_hook)
1013 (syms_of_window): Callers changed.
1015 2012-03-11 Chong Yidong <cyd@gnu.org>
1017 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1019 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1021 2012-03-10 Chong Yidong <cyd@gnu.org>
1023 * frame.c (other_visible_frames): Don't assume the selected frame
1024 is visible (Bug#10955).
1026 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1028 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1030 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1032 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1033 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1036 2012-03-03 Glenn Morris <rgm@gnu.org>
1038 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1040 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1042 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1043 position past the first glyph_row that ends at ZV. (Bug#10902)
1044 (redisplay_window, next_element_from_string): Fix typos in
1046 (redisplay_window): Pass to move_it_vertically the margin in
1047 pixels, not in screen lines.
1049 2012-03-02 Glenn Morris <rgm@gnu.org>
1051 * buffer.c (buffer-list-update-hook): Doc fix.
1053 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1055 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1056 push_it before setting up the iterator for the first overlay
1057 string, even if we have an empty string loaded.
1058 (next_overlay_string): If there's an empty string on the iterator
1059 stack, pop the stack. (Bug#10903)
1061 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1063 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1064 Suggested by Stefan Monnier in
1065 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1066 * alloc.c (widen_to_Lisp_Object): New static function.
1067 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1068 and widening them to Lisp_Objects. This would work even if
1069 USE_LSB_TAG is defined and wide integers are used, which might
1070 happen in a future version of Emacs.
1072 2012-02-25 Chong Yidong <cyd@gnu.org>
1074 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1077 * xselect.c (Fx_selection_exists_p): Doc fix.
1078 (x_clipboard_manager_save_all): Print an informative message
1079 before saving to clipboard manager.
1081 2012-02-24 Chong Yidong <cyd@gnu.org>
1083 * keyboard.c (process_special_events): Handle all X selection
1084 requests in kbd_buffer, not just the next one (Bug#8869).
1086 2012-02-23 Chong Yidong <cyd@gnu.org>
1088 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1089 call when setting menu-bar-lines and tool-bar-lines parameters.
1090 (unwind_create_frame_1): New helper function.
1092 * window.c (inhibit_window_configuration_change_hook): New var.
1093 (run_window_configuration_change_hook): Obey it.
1094 (syms_of_window): Initialize it.
1096 2012-02-22 Chong Yidong <cyd@gnu.org>
1098 * xterm.c (x_draw_image_relief): Add missing type check for
1099 Vtool_bar_button_margin (Bug#10743).
1101 2012-02-21 Chong Yidong <cyd@gnu.org>
1103 * fileio.c (Vfile_name_handler_alist): Doc fix.
1105 * buffer.c (Fget_file_buffer): Protect against invalid file
1106 handler return value.
1108 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1110 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1111 when computing $valmask.
1113 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1114 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
1115 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
1116 It's useless in that case, and it can cause problems on hosts
1117 that allocate halves of EMACS_INT values separately.
1118 Reported by Dan Horák. Diagnosed by Andreas Schwab in
1119 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
1120 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
1121 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1122 it avoids undefined behavior on hosts where shifting right by more
1123 than the word width has undefined behavior.
1125 2012-02-19 Chong Yidong <cyd@gnu.org>
1127 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1128 (Funhandled_file_name_directory, Ffile_name_as_directory)
1129 (Fdirectory_file_name, Fexpand_file_name)
1130 (Fsubstitute_in_file_name): Protect against invalid file handler
1131 return values (Bug#10845).
1133 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1135 * .gdbinit (pitx): Fix incorrect references to fields of the
1138 2012-02-17 Chong Yidong <cyd@gnu.org>
1140 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1142 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1144 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1145 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1147 2012-02-15 Chong Yidong <cyd@gnu.org>
1149 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1150 marked as special. Also, starting docstrings with * is obsolete.
1152 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1154 * gnutls.c (emacs_gnutls_write): Fix last change.
1156 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1158 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1161 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1163 * keymap.c (Fsingle_key_description): Handle char ranges.
1165 2012-02-12 Chong Yidong <cyd@gnu.org>
1167 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1168 as that creates a dangerous corner case.
1170 * window.c (Fdelete_window_internal): Invalidate the mouse
1171 highlight (Bug#9904).
1173 2012-02-12 Glenn Morris <rgm@gnu.org>
1175 * xselect.c (Fx_own_selection_internal)
1176 (Fx_get_selection_internal, Fx_disown_selection_internal)
1177 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1178 * nsselect.m (Fx_own_selection_internal)
1179 (Fx_disown_selection_internal, Fx_selection_exists_p)
1180 (Fx_selection_owner_p, Fx_get_selection_internal):
1181 Sync docs and argument specs with the xselect.c versions.
1183 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1185 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1187 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1189 * w32select.c (Fx_selection_exists_p): Sync doc string and
1190 argument list with xselect.c. (Bug#10783)
1192 * w16select.c (Fx_selection_exists_p): Sync doc string and
1193 argument list with xselect.c. (Bug#10783)
1195 2012-02-10 Glenn Morris <rgm@gnu.org>
1197 * fns.c (Fsecure_hash): Doc fix.
1199 2012-02-09 Kenichi Handa <handa@m17n.org>
1201 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1203 2012-02-07 Chong Yidong <cyd@gnu.org>
1205 * buffer.c (Fbuffer_local_variables)
1206 (buffer_lisp_local_variables): Handle unbound vars correctly;
1207 don't let Qunbound leak into Lisp.
1209 2012-02-07 Glenn Morris <rgm@gnu.org>
1211 * image.c (Fimagemagick_types): Doc fix.
1213 * image.c (imagemagick-render-type): Change it from a lisp object
1214 to an integer. Move the doc here from the lisp manual.
1215 Treat all values not equal to 0 the same.
1217 2012-02-06 Chong Yidong <cyd@gnu.org>
1219 * doc.c (store_function_docstring): Avoid applying docstring of
1220 alias to base function (Bug#2603).
1222 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1224 * .gdbinit (pp1, pv1): Remove redundant defines.
1227 2012-02-04 Chong Yidong <cyd@gnu.org>
1229 * nsterm.m: Declare a global (Bug#10694).
1231 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1233 * w32.c (get_emacs_configuration_options):
1234 Include --enable-checking, if specified, in the return value.
1236 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1238 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1239 after rounding frame sizes. (Bug#9723)
1241 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1243 * keyboard.c (adjust_point_for_property): Don't position point
1244 before BEGV. (Bug#10696)
1246 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1248 Handle overflow when computing char display width (Bug#9496).
1249 * character.c (char_width): Return EMACS_INT, not int.
1250 (char_width, c_string_width): Check for overflow when
1251 computing the width; this is possible now that individual
1252 characters can have unbounded width. Problem introduced
1253 by merge from Emacs 23 on 2012-01-19.
1255 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1257 * dbusbind.c (Fdbus_register_method): Mention the return value
1258 :ignore in the docstring.
1260 2012-02-02 Glenn Morris <rgm@gnu.org>
1262 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1264 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1265 Unconditionally set to t. (Bug#10673)
1266 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1267 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1268 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1270 2012-02-02 Kenichi Handa <handa@m17n.org>
1272 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1273 0, do not call append_composite_glyph.
1275 2012-02-02 Kenichi Handa <handa@m17n.org>
1277 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1279 (x_produce_glyphs): If the component of a composition is a null
1280 string, set it->pixel_width to 1 to avoid zero-width glyph.
1282 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1284 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1285 first 2 arguments are identical. This makes inserting large
1286 output from a subprocess an order of magnitude faster on
1287 MS-Windows, where all sbrk'ed memory is always contiguous.
1289 2012-01-31 Glenn Morris <rgm@gnu.org>
1291 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1292 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1293 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1295 2012-01-29 Glenn Morris <rgm@gnu.org>
1297 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1299 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1301 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1303 2012-01-28 Chong Yidong <cyd@gnu.org>
1305 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1307 2012-01-26 Chong Yidong <cyd@gnu.org>
1309 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1311 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1312 repeat counts (Bug#10507).
1314 2012-01-26 Glenn Morris <rgm@gnu.org>
1316 * lread.c (syms_of_lread): Doc fix.
1318 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1320 * coding.c (encode_designation_at_bol): Change return value to
1323 2012-01-25 Chong Yidong <cyd@gnu.org>
1325 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1327 2012-01-21 Chong Yidong <cyd@gnu.org>
1329 * floatfns.c (Fcopysign): Make the second argument non-optional,
1330 since nil is not allowed anyway.
1332 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1334 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1335 (send_process): Likewise.
1337 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1339 * window.c (save_window_save, Fcurrent_window_configuration)
1340 (Vwindow_persistent_parameters): Do not use Qstate.
1341 Rewrite doc-strings.
1343 2012-01-19 Kenichi Handa <handa@m17n.org>
1345 * character.c (char_width): New function.
1346 (Fchar_width, c_string_width, lisp_string_width):
1347 Use char_width (Bug#9496).
1349 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1351 * window.c (Vwindow_persistent_parameters): New variable.
1352 (Fset_window_configuration, save_window_save): Handle persistent
1355 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1357 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1358 thrashing the stack of the thread. (Bug#9087)
1360 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1362 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1364 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1366 * xdisp.c (rows_from_pos_range): Handle the case where the
1367 highlight ends on a newline. (Bug#10464)
1368 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1369 he end column for display of highlight that ends on a newline
1372 2012-01-11 Glenn Morris <rgm@gnu.org>
1374 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1375 from load-path also when installation-directory is nil. (Bug#10208)
1377 2012-01-10 Glenn Morris <rgm@gnu.org>
1379 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1381 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1382 Update template values to be closer to their typical values these days.
1384 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1386 * xdisp.c (rows_from_pos_range): Accept additional argument
1387 DISP_STRING, and accept any glyph in a row whose object is that
1388 string as eligible for mouse highlight. Fixes mouse highlight of
1389 display strings from overlays. (Bug#10464)
1391 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1393 emacs: fix an auto-save permissions race condition (Bug#10400)
1394 * fileio.c (auto_saving_dir_umask): New static var.
1395 (Fmake_directory_internal): Use it.
1396 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1397 creating the directory. The old code temporarily assigns
1398 too-generous permissions to the directory.
1399 (do_auto_save_eh): Clear it.
1400 (Fdo_auto_save): Catch all errors, not just file errors, so
1401 that the var is always cleared.
1403 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1405 * search.c (scan_buffer): Pass character positions to
1406 know_region_cache, not byte positions. (Bug#6540)
1408 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1410 * w32.c (sys_rename): Report EXDEV when rename of a directory
1411 fails because the target is on another logical disk. (Bug#10284)
1413 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1415 * xterm.c (x_embed_request_focus): New function.
1417 * xterm.h: Add prototype.
1419 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1421 2012-01-05 Glenn Morris <rgm@gnu.org>
1423 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1425 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1427 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1428 Load gnutls_transport_set_lowat only if GnuTLS version is below
1430 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1431 GnuTLS versions below 2.11.1.
1433 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1435 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1436 to the doc string advising against its use for altering the way
1437 windows are scrolled.
1439 2011-12-28 Kenichi Handa <handa@m17n.org>
1441 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1442 coding-system ASCII compatible only when it does not produce BOM
1443 on encoding (Bug#10383).
1445 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1447 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1449 (create_and_show_popup_menu): Always use menu_position_func for
1452 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1454 * callint.c (Fcall_interactively): Don't truncate prompt string.
1456 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1458 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1459 property that ends at ZV, so that the bidi iteration could be
1460 resumed from there (after widening). (Bug#10360)
1462 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1464 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1466 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1468 * nsterm.m (x_free_frame_resources):
1469 Release f->output_data.ns->miniimage.
1470 (ns_index_color): Fix indentation. Do not retain
1471 color_table->colors[i].
1473 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1476 * nsfns.m (x_set_background_color): Assign return value from
1477 ns_index_color to face-background instead of NSColor*.
1478 (ns_implicitly_set_icon_type): Fix indentation.
1479 Change assignment in for loop to comparison.
1481 * emacs.c (ns_pool): New variable.
1482 (main): Assign ns_pool.
1483 (Fkill_emacs): Call ns_release_autorelease_pool.
1485 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1486 autorelease fdesc, release fdAttrs and tdict.
1487 (ns_get_covering_families): Release charset.
1488 (ns_findfonts): Release NSFontDescriptor created with new.
1489 (ns_uni_to_glyphs): Fix indentation.
1490 (setString): Release attrStr before assigning new value.
1492 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1494 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1496 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1497 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1499 2011-12-18 David Reitter <reitter@cmu.edu>
1501 * nsterm.m (ns_term_init): Subscribe for notifications
1502 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1503 to method trackingNotification in EmacsMenu.
1505 * nsmenu.m (trackingMenu): New variable.
1506 (trackingNotification): New method (from Aquamacs).
1507 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1508 from Aquamacs (Bug#7030).
1510 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1512 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1513 (symbol_to_nsstring): Fix indentation.
1514 (ns_symbol_to_pb): New function.
1515 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1516 (Fns_rotate_cut_buffers_internal): Remove.
1517 (Fns_store_selection_internal): Rename from
1518 Fns_store_cut_buffer_internal.
1519 (ns_get_foreign_selection, Fx_own_selection_internal)
1520 (Fx_disown_selection_internal, Fx_selection_exists_p)
1521 (Fns_get_selection_internal, Fns_store_selection_internal):
1522 Use ns_symbol_to_pb and check if return value is nil.
1523 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1524 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1525 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1526 renamed to Sns_store_selection_internal.
1527 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1528 and remove this function.
1529 (ns_handle_selection_clear): Remove, never used.
1530 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1533 2011-12-17 Ken Brown <kbrown@cornell.edu>
1535 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1536 GID is unknown (Bug#10257).
1538 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1540 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1541 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1542 which caused a build failure on GNU/Linux IA-64. This problem was
1543 introduced by my 2011-10-07 patch.
1545 2011-12-15 Juri Linkov <juri@jurta.org>
1547 * image.c (imagemagick_error): New function. (Bug#10112)
1548 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1549 Use `imagemagick_error' where ImageMagick functions return
1551 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1554 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1556 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1557 fill background (Bug#8992).
1559 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1561 * window.c (Vwindow_combination_resize)
1562 (Vwindow_combination_limit): Use t instead of non-nil in
1564 (Vrecenter_redisplay): Add first sentence of doc-string on
1566 (Frecenter): Fix doc-string typo.
1568 2011-12-11 Kenichi Handa <handa@m17n.org>
1570 * coding.c (Funencodable_char_position): Pay attention to the
1571 buffer text relocation (Bug#9389).
1573 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1575 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1576 gtk_init (Bug#10100).
1578 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1580 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1581 IT->string is nil. (Bug#10263)
1583 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1585 * nsterm.h (x_free_frame_resources): Declare.
1587 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1588 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1590 * nsterm.h (ns_get_defaults_value): Declare.
1592 * nsterm.m (ns_default): Call ns_get_defaults_value.
1594 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1596 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1599 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1601 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1602 that where the value of an _OBJC_* symbol points to is in the .bss
1603 section (Bug#10240).
1605 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1607 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1608 after the loop to call ccl_driver at least once (Bug#8619).
1610 2011-12-08 Kenichi Handa <handa@m17n.org>
1612 * ftfont.c (get_adstyle_property): Fix previous change
1615 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1617 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1618 dirs from the default value of EMACSLOADPATH (bug#10208).
1620 2011-12-07 Glenn Morris <rgm@gnu.org>
1622 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1623 installation and source directories as well. (Bug#10208)
1625 2011-12-06 Chong Yidong <cyd@gnu.org>
1627 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1629 2011-12-06 Glenn Morris <rgm@gnu.org>
1631 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1632 as an error, not just -1. (Bug#10217)
1634 2011-12-05 Chong Yidong <cyd@gnu.org>
1636 * keyboard.c (process_special_events): New function.
1637 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1639 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1641 * coding.c (encode_designation_at_bol): Don't use uninitialized
1642 local variable (Bug#9318).
1644 2011-12-05 Kenichi Handa <handa@m17n.org>
1646 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1647 return Qnil (Bug#8046, Bug#10193).
1649 2011-12-05 Kenichi Handa <handa@m17n.org>
1651 * coding.c (encode_designation_at_bol): New args charbuf_end and
1652 dst. Return the number of produced bytes. Callers changed.
1653 (coding_set_source): Return how many bytes coding->source was
1655 (coding_set_destination): Return how many bytes
1656 coding->destination was relocated.
1657 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1658 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1660 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1662 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1663 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1666 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1668 The following changes are to fix Bug#9318.
1670 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1671 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1672 (encode_coding_iso_2022, encode_coding_sjis)
1673 (encode_coding_big5, encode_coding_charset): Use the above macros.
1675 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1677 * lisp.h (process_quit_flag): Fix external declaration.
1679 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1681 Don't macro-inline non-performance-critical code.
1682 * eval.c (process_quit_flag): New function.
1683 * lisp.h (QUIT): Use it.
1685 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1687 * nsfns.m (get_geometry_from_preferences): New function.
1688 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1690 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1692 * emacs.c (Qkill_emacs): Define.
1693 (syms_of_emacs): Initialize it.
1694 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1695 Qquit_flag to `kill-emacs' instead.
1696 (quit_throw_to_read_char): Add parameter `from_signal'.
1697 All callers changed. Call Fkill_emacs if requested and safe.
1698 * lisp.h (QUIT): Call Fkill_emacs if requested.
1700 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1702 * widget.c (update_wm_hints): Return if wmshell is null.
1703 (widget_update_wm_size_hints): New function.
1705 * widget.h (widget_update_wm_size_hints): Declare.
1707 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1708 widget_update_wm_size_hints (Bug#10104).
1710 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1712 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1713 before a newline, prepare the bidi iterator for consuming the
1714 newline, and keep the current paragraph direction. (Bug#10183)
1715 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1717 2011-12-02 Juri Linkov <juri@jurta.org>
1719 * search.c (Fword_search_regexp): New Lisp function created from
1720 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1721 (Fword_search_backward, Fword_search_forward)
1722 (Fword_search_backward_lax, Fword_search_forward_lax):
1723 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1724 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1726 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1728 * fileio.c (Finsert_file_contents): Move after-change-function call
1729 to before the "handled:" label, since all "goto handled" appear in
1730 cases where the *-change-functions have already been properly called
1733 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1735 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1736 waiting for input. (Bug#10169)
1738 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1740 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1741 verifies glyph row's hash code--we have just reallocated the
1742 glyphs, so their contents can be complete garbage. (Bug#10164)
1744 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1746 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1748 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1750 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1751 attributes are tested _before_ calling verify_row_hash, to protect
1752 against GCC re-ordering of the tests. (Bug#10164)
1754 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1756 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1758 * xterm.c (handle_one_xevent): Only set async_visible and friends
1759 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1760 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1761 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1763 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1765 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1766 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1767 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1768 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1769 All uses changed to use GCPRO1 etc.
1770 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1771 Revert to old implementation (i.e., before 2011-03-11).
1773 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1775 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1776 of scroll runs so as to avoid assigning disabled bogus rows and
1777 unnecessary graphics copy operations.
1779 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1781 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1782 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1783 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1784 (malloc, free, realloc, calloc): Redirect to e_* only when
1787 * lisp.h (GCTYPEBITS): Move before first use.
1788 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1789 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1790 this macro definition.
1792 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1795 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1797 * gtkutil.c (xg_create_frame_widgets):
1798 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1799 present with Gtk+ 2.0.
1801 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1803 * fileio.c (Finsert_file_contents): Undo previous change; see
1804 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1806 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1808 Rename locals to avoid shadowing.
1809 * fileio.c (Finsert_file_contents):
1810 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1811 * process.c (wait_reading_process_output):
1812 Rename inner 'proc' to 'p' to avoid shadowing.
1813 Indent for consistency with usual Emacs style.
1815 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1817 * xdisp.c (redisplay_window): If cursor row is not fully visible
1818 after recentering, and scroll-conservatively is set to a large
1819 number, scroll window by a few more lines to make the cursor fully
1820 visible and out of scroll-margin. (Bug#10105)
1821 (start_display): Don't move to the next line if the display should
1822 start at a newline that is part of a display vector or an overlay
1825 2011-11-24 Juri Linkov <juri@jurta.org>
1827 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1828 after the `MagickPingImage' call. (Bug#10112)
1830 2011-11-23 Chong Yidong <cyd@gnu.org>
1832 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1834 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1836 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1837 making another buffer current. (Bug#10114)
1839 2011-11-23 Glenn Morris <rgm@gnu.org>
1841 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1843 2011-11-23 Chong Yidong <cyd@gnu.org>
1845 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1846 using it (Bug#5984).
1848 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1850 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1851 and header-lines, as they don't have one computed for them.
1854 * .gdbinit (prow): Make displayed values more self-explaining.
1855 Add row's hash code.
1857 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1859 * process.c (wait_reading_process_output): Fix asynchrounous
1860 GnuTLS socket handling on some versions of the GnuTLS library.
1861 (wait_reading_process_output): Add comment and URL.
1863 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1865 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1867 2011-11-21 Chong Yidong <cyd@gnu.org>
1869 * window.c (Fnext_window, Fprevious_window): Doc fix.
1871 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1873 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1875 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1877 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1879 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1881 * window.c (Fset_window_combination_limit): Rename argument
1883 (Vwindow_combination_limit): Remove "status" from doc-string.
1885 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1887 * m/ibms390.h: Remove.
1888 * m/ibms390x.h: Don't include "ibms390.h".
1890 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1892 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1893 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1895 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1897 * casetab.c (Fset_case_table):
1898 * charset.c (Fcharset_after): Fix typos.
1900 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1902 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1903 Otherwise, valgrind does not work on some platforms.
1904 Problem reported by Andreas Schwab in
1905 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1906 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1907 is set, removing the need for VIRT_ADDRESS_VARIES.
1908 (PURE_P): Use a more-efficient implementation that needs just one
1909 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1910 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1911 to 4 (xorl, subq, cmpq, setbe).
1912 * alloc.c (pure): Always extern now, since that's the
1913 VIRT_ADDR_VARIES behavior.
1914 (PURE_POINTER_P): Use a single comparison, not two, for
1915 consistency with the new puresize.h.
1916 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1917 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1918 Remove VIRT_ADDR_VARIES no longer needed.
1920 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1922 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1923 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1924 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1925 behave as if the cursor position were at the window margin.
1927 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1928 and the cursor position is out of bounds, behave as if the cursor
1929 position were at the window margin. (Bug#10075)
1931 2011-11-18 Chong Yidong <cyd@gnu.org>
1933 * window.c (Fwindow_combination_limit): Make first argument
1934 non-optional, since it is meaningless for live windows like the
1937 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1939 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1941 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1943 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1944 (graft_intervals_into_buffer): Simplify.
1946 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1948 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1949 hash values of the two rows.
1950 (copy_row_except_pointers): Preserve the used[] arrays and the
1951 hash values of the two rows. (Bug#10035)
1952 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1954 * xdisp.c (row_hash): New function, body extracted from
1955 compute_line_metrics.
1956 (compute_line_metrics): Call row_hash, instead of computing the
1959 * dispnew.c (verify_row_hash): Call row_hash for computing the
1960 hash code of a row, instead of duplicating code from xdisp.c.
1962 * dispextern.h (row_hash): Add prototype.
1964 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1966 * frame.c (delete_frame): Don't delete the terminal when the last
1967 X frame is closed if emacs is built with GTK toolkit.
1969 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1971 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1973 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1975 * window.c (Vwindow_splits): Rename to
1976 Vwindow_combination_resize. Suggested by Juri Linkov.
1977 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1980 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1982 * nsfns.m (Fns_font_name):
1983 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1985 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1987 * window.h (window): Rename slot "nest" to "combination_limit".
1988 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1989 (Fset_window_nest): Rename to Fset_window_combination_limit.
1990 (Vwindow_nest): Rename to Vwindow_combination_limit.
1991 (recombine_windows, make_parent_window, make_window)
1992 (Fsplit_window_internal, saved_window)
1993 (Fset_window_configuration, save_window_save): Rename all
1994 occurrences of window_nest to window_combination_limit.
1996 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1998 * image.c (imagemagick_load_image): Fix typo.
2000 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2002 * xdisp.c (display_line): Move the call to
2003 highlight_trailing_whitespace before the call to
2004 compute_line_metrics, since the latter needs to see the final
2005 faces of all the glyphs to compute ROW's hash value.
2006 Fixes assertion violations in row_equal_p. (Bug#10035)
2008 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2010 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2011 just return (bug#10044).
2013 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2015 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2016 with user-defined heap size. Bump the default size of the temacs
2017 heap to 27MB, to avoid memory warning when running temacs.
2018 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2020 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2021 current_matrix and desired_matrix. (Bug#9990)
2022 (verify_row_hash) [XASSERTS]: New function.
2023 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2024 that the hash value of glyph rows is correct.
2026 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2028 * window.h (window): Remove splits slot.
2029 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2030 (Fdelete_other_windows_internal, make_parent_window)
2031 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2032 (Fset_window_configuration, save_window_save): Don't deal with
2033 split status of windows.
2034 (saved_window): Remove splits slot.
2035 (Vwindow_splits): Rewrite doc-string.
2037 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2039 * xfns.c (unwind_create_frame):
2040 * nsfns.m (unwind_create_frame):
2041 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2042 Vframe_list (Bug#9999).
2044 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2046 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2048 2011-11-11 Kenichi Handa <handa@m17n.org>
2050 * callproc.c (Fcall_process): Set the member dst_multibyte of
2053 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2055 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2056 avoid a crash (bug#9496).
2058 2011-11-09 Chong Yidong <cyd@gnu.org>
2060 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2061 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2063 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2065 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2067 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2069 Avoid some portability problems by eschewing 'extern inline' functions.
2070 The trivial performance wins aren't worth the portability hassles; see
2071 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2073 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2074 (window_box_width, window_box_left, window_box_left_offset)
2075 (window_box_right, window_box_right_offset): Undo previous change,
2076 by removing the "extern"s.
2077 * intervals.c (adjust_intervals_for_insertion)
2078 (adjust_intervals_for_deletion): Undo previous change,
2079 making these static again.
2080 (offset_intervals, temp_set_point_both, temp_set_point)
2081 (copy_intervals_to_string): No longer inline.
2082 * xdisp.c (window_text_bottom_y, window_box_width)
2083 (window_box_height, window_box_left_offset)
2084 (window_box_right_offset, window_box_left, window_box_right)
2085 (window_box): No longer inline.
2087 2011-11-08 Chong Yidong <cyd@gnu.org>
2089 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2090 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2091 Signal an error if not a live window.
2092 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2093 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2095 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2097 * lisp.h (syms_of_abbrev): Remove declaration.
2098 Reported by CHENG Gao <chenggao@royau.me>.
2100 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2102 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2103 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2104 of temacs in GUI mode.
2106 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2108 * window.h: Declare delete_all_child_windows instead of
2109 delete_all_subwindows.
2110 * window.c (Fwindow_nest, Fset_window_nest)
2111 (Fset_window_new_total, Fset_window_new_normal)
2112 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2113 (delete_all_subwindows): Rename to delete_all_child_windows.
2114 (Fdelete_other_windows_internal, Fset_window_configuration):
2115 Call delete_all_child_windows instead of delete_all_subwindows.
2116 * frame.c (delete_frame): Call delete_all_child_windows instead
2117 of delete_all_subwindows.
2119 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
2121 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2122 This is also needed for porting to any host where GC_MARK_STACK is
2123 not GC_MAKE_GCPROS_NOOPS.
2124 (which_symbols): Use it.
2126 2011-11-07 Kenichi Handa <handa@m17n.org>
2128 * coding.c (coding_set_destination): Check coding->src_pos only
2129 when coding->src_object is a buffer (bug#9910).
2131 * process.c (send_process): Set the member src_multibyte of coding
2132 to 0 (bug#9911) when sending a unibyte text.
2134 * callproc.c (Fcall_process): Set the member src_multibyte of
2135 process_coding to 0 (bug#9912).
2137 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2139 * xmenu.c (cleanup_widget_value_tree): New function.
2140 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2141 calling free_menubar_widget_value_tree directly (Bug#9830).
2143 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2145 Fix some portability problems with 'inline'.
2146 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2147 (window_box_width, window_box_left, window_box_left_offset)
2148 (window_box_right, window_box_right_offset): Declare extern.
2149 Otherwise, these inline functions do not conform to C99 and
2150 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2151 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2152 * intervals.c (adjust_intervals_for_insertion)
2153 (adjust_intervals_for_deletion): Now extern, because otherwise the
2154 extern inline functions 'offset_intervals' couldn't refer to it.
2155 (static_offset_intervals): Remove.
2156 (offset_intervals): Rewrite using the old contents of
2157 static_offset_intervals. The old version didn't conform to C99
2158 because an extern inline function contained a reference to an
2159 identifier with static linkage.
2161 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2163 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2166 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2168 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2169 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2170 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2171 return Qleft_to_right.
2173 2011-11-06 Chong Yidong <cyd@gnu.org>
2175 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2176 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2177 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2178 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2179 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2180 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2181 (Fwindow_vscroll): Doc fix.
2182 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2183 argument, since it makes no sense to pass a live window and for
2184 consistency with window-child.
2186 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2188 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2191 2011-11-05 Jason Rumney <jasonr@gnu.org>
2193 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2194 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2196 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2197 bitwise arithmetic preventing use of unicode-sip and non-truetype
2200 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2202 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2205 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2206 initialization code to keep similarity to xfns.c after changes
2209 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2211 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2212 (unwind_create_frame): New function (Bug#9943).
2213 (Fx_create_frame): Restructure code to be more similar to the one in
2214 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2215 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2216 Move terminal->reference_count++ just before making the frame official
2219 * nsterm.m (x_free_frame_resources): New function.
2220 (x_destroy_window): Move code to x_free_frame_resources.
2222 * xfns.c (unwind_create_frame): Fix comment.
2223 (Fx_create_frame, x_create_tip_frame):
2224 Move terminal->reference_count++ just before making the frame
2225 official. Move initialization of image_cache_refcount and
2226 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2228 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2230 Support MSVC build with newer versions of Visual Studio.
2231 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2232 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2235 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2236 which are not supported by MSVC.
2237 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2238 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2240 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2242 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2244 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2246 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2248 Support MSVC build with newer versions of Visual Studio.
2249 * w32.c: Don't include w32api.h for MSVC.
2250 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2252 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2253 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2254 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2255 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2257 (alloca) [_MSC_VER]: Define to _alloca.
2259 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2261 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2263 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2265 * xdisp.c (note_mouse_highlight): If either of
2266 previous/next-single-property-change returns nil, treat that as
2267 the beginning or the end of the buffer. (Bug#9955)
2269 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2271 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2272 label is not null (Bug#9951).
2273 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2276 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2278 * window.c (Fwindow_body_size): Mention in the doc string that the
2279 return value is in frame's canonical units. (Bug#9949)
2281 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2283 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2285 * w32fns.c (unwind_create_frame): If needed, free the glyph
2286 matrices of the partially constructed frame. (Bug#9943)
2287 * xfns.c (unwind_create_frame): Likewise.
2289 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2291 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2292 Don't stop backward scan on the continuation glyph, even though
2293 its CHARPOS is positive.
2294 (mouse_face_from_buffer_pos, note_mouse_highlight):
2295 Rename cover_string to disp_string.
2297 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2299 * window.c (temp_output_buffer_show): Don't use
2300 Vtemp_buffer_show_specifiers.
2301 (Vtemp_buffer_show_specifiers): Remove unused variable.
2303 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2305 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2306 past the beginning of the current glyph matrix.
2308 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2310 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2311 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2312 HAVE_GTK3 (Bug#9869).
2314 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2315 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2317 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2319 * xterm.c: Declare x_handle_net_wm_state to return int.
2320 (handle_one_xevent): Check if we are iconified but don't have
2321 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2322 (get_current_wm_state): Return non-zero if not hidden,
2323 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2324 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2325 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2326 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2328 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2330 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2331 so that this new function doesn't get optimized away by a
2332 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2334 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2336 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2338 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2340 Fix the `xbytecode' command.
2341 * .gdbinit (xprintbytestr): New command.
2342 (xwhichsymbols): Rename from `which'; all callers changed.
2343 (xbytecode): Print the byte-code string as well.
2345 2011-10-29 Kim Storm <storm@cua.dk>
2347 * alloc.c (which_symbols): New function.
2349 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2351 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2354 2011-10-29 Glenn Morris <rgm@gnu.org>
2356 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2357 Not clear what it was for, and it causes various bugs. (Bug#9839)
2359 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2361 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2362 possible random value that matches one of those tested as
2363 condition to clear the mouse face.
2365 2011-10-28 Chong Yidong <cyd@gnu.org>
2367 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2369 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2371 * window.c (make_window): Initialize phys_cursor_on_p.
2373 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2375 * lisp.h (struct Lisp_Symbol): Update comments.
2377 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2379 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2381 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2383 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2384 <oslsachem@gmail.com> for helping to debug this.
2386 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2387 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2388 (g_b_init_get_glyph_outline_w): New static variables.
2389 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2390 (GetGlyphOutlineW_Proc): New typedefs.
2391 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2392 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2394 (w32font_open_internal, compute_metrics):
2395 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2396 instead of calling the "wide" APIs directly.
2398 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2400 * w32.h (syms_of_w32font): Add prototype.
2402 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2404 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2405 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2406 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2407 (Fmove_to_window_line): Doc fix.
2409 2011-10-27 Chong Yidong <cyd@gnu.org>
2411 * process.c (make_process): Set gnutls_state to NULL.
2413 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2414 non-NULL, regardless of GNUTLS_INITSTAGE.
2415 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2416 an error. Set process slots as soon as we allocate them.
2418 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2420 2011-10-27 Chong Yidong <cyd@gnu.org>
2422 * gnutls.c (emacs_gnutls_deinit): New function.
2423 Deallocate credentials structures as well as calling gnutls_deinit.
2424 (Fgnutls_deinit, Fgnutls_boot): Use it.
2426 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2427 (deactivate_process): Call emacs_gnutls_deinit.
2429 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2431 * image.c (x_create_x_image_and_pixmap):
2432 * w32.c (sys_rename, w32_delayed_load):
2433 * w32font.c (fill_in_logfont):
2434 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2436 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2438 * w32fns.c (w32_default_color_map): New function,
2439 extracted from Fw32_default_color_map.
2440 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2442 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2444 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2446 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2448 * keyboard.c (test_undefined): New function (bug#9751).
2449 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2451 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2453 * sysdep.c (init_sys_modes): Fix the check for the controlling
2454 terminal (Bug#6649).
2456 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2458 * dispextern.h (struct bidi_it): New member next_en_type.
2460 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2461 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2462 current character, check also for next_en_type being WEAK_EN.
2463 (bidi_resolve_weak): Don't enter the expensive loop if the current
2464 position is before next_en_pos. Record the bidi type of the first
2465 non-ET, non-BN character we find, in addition to its position.
2466 (bidi_level_of_next_char): Invalidate next_en_type when
2467 next_en_pos is over-stepped.
2469 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2471 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2472 * editfns.c: Rewrite current-time-zone so that it invokes
2473 the equivalent of (format-time-string "%Z") to get the time zone name.
2474 This fixes a bug when the time zone name contains characters that
2475 need converting from the system time locale to Emacs internal format.
2476 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2477 that patch fixed format-time-string to do the conversion, but
2478 I forgot to fix current-time-zone.
2479 (format_time_string): New function, containing most of
2480 what Fformat_time_string used to contain.
2481 (Fformat_time_string): Rewrite in terms of format_time_string.
2482 This doesn't change this function's behavior.
2483 (current-time-zone): Rewrite to use format_time_string.
2484 This fixes the bug reported by Michael Schierl in
2485 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2486 Jason Rumney's 2007-06-07 change worked around this bug, but
2488 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2490 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2492 * xdisp.c (start_display): If the character at POS is displayed
2493 via a display vector, reset IT->current.dpvec_index to zero.
2494 (try_window_reusing_current_matrix): If a line ends in a display
2495 vector or the next line starts in a display vector, continue
2496 redrawing the window even though the character position of
2497 start_row was reached.
2500 2011-10-18 Chong Yidong <cyd@gnu.org>
2502 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2503 with nobreak-char-display too.
2505 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2507 Fix part 3 of bug#9771.
2508 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2509 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2510 non-neutral characters if the current character is a paragraph
2511 separator (a.k.a. Newline). This avoids running the same
2512 expensive loop twice, once when we consume the preceding newline
2513 and the other time when the line actually needs to be displayed.
2514 Avoid the loop when we see neutrals on the base embedding level
2515 following a character whose directionality is the same as the
2516 paragraph's. This avoids running the expensive loop when a line
2517 ends in a long sequence of neutrals, like control characters.
2518 Add assertion against STRONG_AL type. Slightly rearrange code
2519 that determines the type of a neutral given the first non-neutral
2521 (bidi_level_of_next_char): Set next_en_pos to zero when
2522 invalidating its info.
2524 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2526 * xdisp.c (push_display_prop): Determine whether to record string
2527 or buffer position by IT->string, not by IT->method. Allow
2528 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2529 (move_it_vertically_backward): Don't look for character position
2530 immediately after the newline when in a continuation line.
2533 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2535 * window.c (coordinates_in_window): Rewrite and delabelize
2536 vertical border check. (Bug#5357) (Bug#9618)
2538 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2540 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2541 errors in XSetWindowBorder (bug#9310).
2543 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2545 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2546 avoid crash when xmalloc overrun checking is enabled.
2548 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2550 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2551 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2552 cursor motion with <left> and <right> arrow keys.
2554 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2555 some callers set that themselves.
2557 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2559 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2560 display string and the previous row comes from the same string and
2561 is empty. (Bug#9739) (Bug#9738)
2563 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2565 * doc.c (get_doc_string): Encode file name (bug#9735).
2567 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2569 * bidi.c (bidi_level_of_next_char):
2570 * xdisp.c (get_visually_first_element): Remove old incorrect
2571 comments regarding the Unicode Line Separator character.
2573 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2575 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2577 * alloc.c (Fgc_status): Do not access beyond zombies array
2578 boundary if nzombies > MAX_ZOMBIES.
2579 * alloc.c (dump_zombies): Add missing format specifier.
2581 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2583 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2584 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2586 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2587 Some packages use them to denote characters with modifiers.
2589 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2591 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2592 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2593 matching a pp-number. Rename parameter var to var1.
2595 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2597 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2599 2011-10-08 Glenn Morris <rgm@gnu.org>
2601 * callint.c (Fcall_interactively): Give a more explicit error for the
2602 'c' case with a non-character input. (Bug#8479)
2604 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2606 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2608 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2609 lines that are hscrolled on the left.
2611 * dispnew.c (buffer_posn_from_coords): Account for a possible
2612 presence of header-line. (Bug#4426)
2614 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2616 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2617 Don't advertise functionality which we discourage or doesn't work.
2619 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2621 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2622 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2623 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2624 this makes Emacs dump core during garbage collection on rare
2625 occasions. sizeof is obviously inferior to offsetof here, so
2626 stick with offsetof.
2627 (GC_POINTER_ALIGNMENT): New macro.
2628 (mark_memory): Omit 3rd (offset) arg; caller changed.
2629 Don't assume EMACS_INT alignment is the same as pointer alignment.
2631 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2633 * keyboard.c (read_key_sequence_remapped): New var.
2634 (read_key_sequence): Compute remapping in the right buffer.
2635 (command_loop_1): Use read_key_sequence's remapping directly.
2637 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2639 * dired.c (file_name_completion): Don't expand file name.
2640 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2641 before checking file name handler.
2643 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2644 they've been requested explicitly (bug#9591).
2646 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2648 * keymap.c (Fsingle_key_description): Use make_specified_string
2649 instead of build_string to build string from push_key_description.
2652 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2654 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2655 This fixes a Y2038 bug on 64-bit hosts.
2656 * buffer.c (reset_buffer):
2657 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2658 (Fclear_buffer_auto_save_failure):
2659 Use 0, not -1, to represent an unset failure time, since time_t
2660 might not be signed.
2662 Remove dependency on glibc malloc internals.
2663 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2664 Move back here from lisp.h, but with their new implementations.
2665 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2666 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2667 * charset.c (charset_table_init): New static var.
2668 (syms_of_charset): Use it instead of xmalloc. This removes a
2669 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2670 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2671 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2672 Move back to alloc.c.
2673 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2674 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2676 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2678 * nsterm.m (windowDidResize): Call x_set_window_size only when
2679 ns_in_resize is true. Otherwise set pixelwidth/height and
2680 call change_frame_size (Bug#9628).
2682 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2684 Port --enable-checking=all to Fedora 14 x86-64.
2685 * charset.c (syms_of_charset): Also account for glibc malloc's
2686 internal overhead when calculating the initial malloc maximum.
2688 Port --enable-checking=all to Fedora 14 x86.
2689 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2691 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2692 (overrun_check_realloc, overrun_check_free):
2693 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2694 That way, xmalloc returns a properly-aligned pointer even if
2695 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2696 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2697 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2698 into account when calculating the initial malloc maximum.
2699 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2700 Move here from alloc.c, so that charset.c can use it too.
2701 Properly align; the old code wasn't right for common 32-bit hosts
2702 when configured with --enable-checking=all.
2703 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2704 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2706 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2708 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2711 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2713 * xdisp.c (compute_display_string_end): If there's no display
2714 string at CHARPOS, return -1.
2716 * bidi.c (bidi_fetch_char): When compute_display_string_end
2717 returns a negative value, treat the character as a normal
2718 character not covered by a display string. (Bug#9624)
2720 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2722 * lread.c (Fread_from_string): Fix typo in docstring.
2724 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2726 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2727 newline, reseat the iterator instead of bidi-iterating there one
2728 character at a time. (Bug#9610)
2729 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2730 TO_CHARPOS if the bidi iterator is at base embedding level.
2732 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2734 * lread.c (readevalloop): Use correct code for NBSP.
2735 (read1): Likewise. (Bug#9608)
2737 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2739 * dbusbind.c (Fdbus_register_signal): When service is not
2740 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2742 2011-09-25 Glenn Morris <rgm@gnu.org>
2744 * buffer.c (truncate-lines): Doc fix.
2746 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2748 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2749 (Fset_window_next_buffers): Doc fix.
2751 2011-09-24 Glenn Morris <rgm@gnu.org>
2753 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2755 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2757 Fix minor problems found by static checking.
2758 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2759 * indent.c (Fvertical_motion): Fix == vs = typo.
2761 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2763 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2764 Default value is now t. Doc fix.
2766 * indent.c (Fvertical_motion): Compute and apply the overshoot
2767 logic when moving up, not only when moving down. Fix the
2768 confusing name and values of the it_overshoot_expected variable;
2769 logic changes accordingly. (Bug#9254) (Bug#9549)
2771 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2772 CHARPOS is covered by a display string which includes newlines.
2773 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2774 is covered by a display string with embedded newlines.
2776 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2778 * dbusbind.c (Fdbus_register_signal): Add match rule to
2779 Vdbus_registered_objects_table. (Bug#9581)
2780 (Fdbus_register_method, Vdbus_registered_objects_table):
2783 2011-09-24 Jim Meyering <meyering@redhat.com>
2785 do not ignore write error for any output size
2786 The previous change was incomplete.
2787 While it makes emacs --batch detect the vast majority of stdout
2788 write failures, errors were still ignored whenever the output size is
2789 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2790 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2791 && echo FAIL: ignored write error
2792 FAIL: ignored write error
2793 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2794 && echo FAIL: ignored write error
2795 FAIL: ignored write error
2796 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2798 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2800 * emacs.c (Fkill_emacs): In noninteractive mode exit
2801 non-successfully if a write error occurred on stdout. (Bug#9574)
2803 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2805 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2808 * dispextern.h (struct it): Update the comment documenting what
2811 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2813 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2814 a display string, extend search for cursor position to end of row.
2815 (find_row_edges): If the row ends in a newline from a display
2816 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2817 Handle the case of a display string with multiple newlines.
2818 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2819 non-empty line. Fixes confusing cursor motion with arrow keys at
2820 the beginning of a line that starts with whitespace.
2822 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2824 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2827 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2829 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2832 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2834 * xdisp.c (display_line): Record maximum and minimum buffer
2835 positions even if no glyphs were produced (e.g., by a zero-width
2836 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2837 buffer positions that will be removed from the glyph row because
2839 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2840 column is beyond frame width: don't subtract 1 "pixel" when
2841 computing width of the stretch.
2842 (reseat_at_next_visible_line_start): Undo the change made on
2843 2011-09-17 that saved paragraph information and restored it after
2844 the call to `reseat'. (Bug#9545)
2846 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2848 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2849 and turn window cursor on if cleared (Bug#9415).
2851 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2853 * search.c (boyer_moore): Take unibyte characters from pattern
2854 literally. (Bug#9458)
2856 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2858 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2860 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2862 Fix minor problem found by static checking.
2863 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2864 initialized, to pacify gcc -Wuninitialized.
2866 * fileio.c: Report proper errno when syscall falls.
2867 (Finsert_file_contents): Save and restore errno,
2868 so that report_file_error outputs the correct diagnostic.
2869 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2871 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2873 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2875 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2877 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2878 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2880 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2882 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2883 about the current paragraph and restore it after the call to reseat.
2885 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2886 (bidi_find_paragraph_start): Search back for paragraph beginning
2887 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2888 (bidi_move_to_visually_next): Only trigger paragraph-related
2889 computations when the last character is a newline or at EOB, not
2890 just any NEUTRAL_B. (Bug#9470)
2892 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2893 truncated lines if point is covered by a display string. (Bug#9524)
2895 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2897 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2898 (cons_to_x_long): New function.
2899 (lisp_data_to_selection_data): Use it. Correct the test for
2900 short-versus-long data; it was negated. Break out of vector
2901 loop, for efficiency, when a long datum is discovered.
2903 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2905 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2907 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2909 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2910 GCC PR/17406) by declaring this function with external scope.
2912 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2914 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2915 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2917 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2919 * editfns.c (Fformat): Correctly handle text properties on "%%".
2921 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2923 * xterm.c (x_draw_composite_glyph_string_foreground):
2924 * w32term.c (x_draw_composite_glyph_string_foreground):
2925 * term.c (encode_terminal_code):
2926 * composite.c (composition_update_it, get_composition_id):
2927 * xdisp.c (get_next_display_element)
2928 (fill_composite_glyph_string): Add comments about special meaning
2929 of TAB characters in a composition.
2931 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2933 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2934 This occurs when processing a multibyte format.
2935 Problem reported by Wolfgang Jenker.
2937 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2939 * xdisp.c (try_cursor_movement): Only check for exact match if
2940 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2942 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2944 Remove unused external symbols.
2945 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2946 * xdisp.c (calc_pixel_width_or_height): Now static.
2947 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2948 * indent.c (check_display_width):
2949 * w32term.c: Fix comment to match code.
2950 * xterm.c, xterm.h (x_catching_errors): Remove.
2952 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2954 * xselect.c: Use signed conversions more consistently (Bug#9498).
2955 (selection_data_to_lisp_data): Assume incoming selection data are
2956 signed integers, not unsigned. This is to be consistent with
2957 outgoing selection data, which was modified to use signed integers
2958 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2959 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2960 expects long, not unsigned long.
2962 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2964 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2965 computation of loop end. Reported by Johan Bockgård
2968 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2970 * frame.c (Fother_visible_frames_p): Function deleted.
2972 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2974 * indent.c (compute_motion): Process display vector front to back
2975 rather than the other way around. (Bug#2496)
2977 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2979 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2981 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2983 * minibuf.c (Fread_from_minibuffer): Doc fix.
2985 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2987 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2988 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2990 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2992 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2993 value for non-existent files.
2995 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2997 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2998 set its "size" to -1. This will set the modtime_size field of
2999 the corresponding buffer to -1, which is what
3000 verify-visited-file-modtime expects for files that do not exist.
3003 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3005 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3007 * lisp.h: ... from here. push_key_description is no longer
3008 defined in keyboard.c, so its declaration should not be in
3009 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3010 logically belongs with push_key_description.
3012 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3014 * buffer.h: Include <sys/types.h> instead of <time.h>.
3015 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3016 Problem reported by Herbert J. Skuhra.
3018 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3020 * xml.c (parse_region): Make the parsing work for
3021 non-comment-starting XML files again (bug#9144).
3023 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3025 * image.c (gif_load): Fix calculation of bottom and right corner.
3028 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3030 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3031 redisplay in small windows.
3033 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3035 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3037 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3039 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3040 Operate on live windows only.
3042 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3044 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3046 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3048 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3049 only under bidi iteration.
3051 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3053 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3055 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3057 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3058 Without this fix, the command to link temacs failed due to an
3059 undefined symbol __builtin_isnan. This is because
3060 /usr/include/iso/math_c99.h #defines isnan(x) to
3061 __builtin_isnan(x), but the bundled gcc, which identifies itself
3062 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3064 * floatfns.c (isnan): #undef, and then #define to a clone of
3066 (Fisnan): Always define, since it's always available now.
3067 (syms_of_floatfns): Always define isnan at the Lisp level.
3069 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3071 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3073 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3075 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3076 The previous code assumed that file offsets (off_t values) fit in
3077 EMACS_INT variables, which is not true on typical 32-bit hosts.
3078 The code messed up by falsely reporting buffer overflow in cases
3079 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3080 when "big" contains more than 2**29 bytes, even though this
3081 inserts just one byte and does not overflow the buffer.
3082 (Finsert_file_contents): Store file offsets as off_t
3083 values, not as EMACS_INT values. Check for overflow when
3084 converting between EMACS_INT and off_t. When checking for
3085 buffer overflow or for overlap, take the offsets into account.
3086 Don't use EMACS_INT for small values where int suffices.
3087 When checking for overlap, fix a typo: ZV was used where
3088 ZV_BYTE was intended.
3089 (Fwrite_region): Don't assume off_t fits into 'long'.
3090 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3092 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3094 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3096 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3098 sprintf-related integer and memory overflow issues (Bug#9412).
3100 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3101 (esprintf, exprintf, evxprintf): New functions.
3102 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3103 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3104 (modify_event_symbol): Do not assume that the length of
3105 name_alist_or_stem is safe to alloca and fits in int.
3106 (Fexecute_extended_command): Likewise for function name and binding.
3107 (Frecursion_depth): Wrap around reliably on integer overflow.
3108 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3109 since some callers pass EMACS_INT values.
3110 (Fsingle_key_description): Don't crash if symbol name contains more
3111 than MAX_ALLOCA bytes.
3112 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3113 (get_minibuffer): Arg is now EMACS_INT, not int.
3114 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
3115 (esprintf, exprintf, evxprintf): New decls.
3116 * window.h (command_loop_level, minibuf_level): Reflect API changes.
3118 * dbusbind.c (signature_cat): New function.
3119 (xd_signature, Fdbus_register_signal):
3120 Do not overrun buffer; instead, report string overflow.
3122 * dispnew.c (add_window_display_history): Don't overrun buffer.
3123 Truncate instead; this is OK since it's just a log.
3125 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3126 even if the time zone offset is outlandishly large.
3127 Don't mishandle offset == INT_MIN.
3129 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3130 when creating daemon; the previous buffer-overflow check was incorrect.
3132 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3133 which has the guts of the old verror function.
3135 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3136 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3138 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3139 (font_unparse_xlfd): Don't blindly alloca long strings.
3140 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3141 fits in int, when using sprintf. Use single snprintf to count
3142 length of string rather than counting it via multiple sprintfs;
3143 that's simpler and more reliable.
3144 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3145 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3146 sprintf, in case result does not fit in int.
3148 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3149 (fontset_from_font): Print it.
3151 * frame.c (tty_frame_count): Now printmax_t, not int.
3152 (make_terminal_frame, set_term_frame_name): Print it.
3153 (x_report_frame_params): In X, window IDs are unsigned long,
3154 not signed long, so print them as unsigned.
3155 (validate_x_resource_name): Check for implausibly long names,
3156 and don't assume name length fits in 'int'.
3157 (x_get_resource_string): Don't blindly alloca invocation name;
3158 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3161 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3162 (xg_check_special_colors, xg_set_geometry):
3163 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3165 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3166 Use esprintf, not sprintf, in case result does not fit in int.
3168 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3169 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3170 it as a large positive number.
3171 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3172 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3174 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3175 in case result does not fit in int.
3177 * print.c (float_to_string): Detect width overflow more reliably.
3178 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3179 buffer overrun. Don't assume list length fits in 'int'. Treat
3180 print length of 0 as 0, not as infinity; to be consistent with other
3181 uses of print length in this function. Don't overflow print length
3182 index. Don't assume hash table size fits in 'long', or that
3183 vectorlike size fits in 'unsigned long'.
3185 * process.c (make_process): Use printmax_t, not int, to format
3186 process-name gensyms.
3188 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3190 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3191 to avoid potential buffer overrun.
3193 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3194 if X resource line is longer than 512 bytes.
3196 * xfns.c (x_window): Make sprintf buffer a bit bigger
3197 to avoid potential buffer overrun.
3199 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3201 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3203 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3205 Integer overflow fixes for scrolling, etc.
3206 Without these, Emacs silently mishandles large integers sometimes.
3207 For example, "C-u 4294967297 M-x recenter" was treated as if
3208 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3210 * xdisp.c (try_window_id): Check Emacs fixnum range before
3211 converting to 'int'.
3213 * window.c (window_scroll_line_based, Frecenter):
3214 Check that an Emacs fixnum is in range before assigning it to 'int'.
3215 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3216 values converted from Emacs fixnums.
3217 (Frecenter): Don't wrap around a line count if it is out of 'int'
3218 range; instead, treat it as an extreme value.
3219 (Fset_window_configuration, compare_window_configurations):
3220 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3222 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3223 that can exceed INT_MAX. Check that EMACS_INT value is in range
3224 before assigning it to the (possibly-narrower) index.
3225 (match_limit): Don't assume that a fixnum can fit in 'int'.
3227 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3230 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3231 (Fvertical_motion): Don't wrap around LINES values that don't fit
3232 in 'int'. Instead, treat them as extreme values. This is good
3233 enough for windows, which can't have more than INT_MAX lines anyway.
3235 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3237 * Require libxml/parser.h to avoid compilation warning.
3239 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3241 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3242 since this reportedly can destroy thread storage.
3244 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3246 * syntax.c (find_defun_start): Update all cache variables if
3247 exiting early (Bug#9401).
3249 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3251 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3253 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3254 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3255 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3257 * term.c (tty_append_glyph): New function.
3258 (produce_stretch_glyph): Static function and its prototype deleted.
3260 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3263 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3265 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3266 when checking :margin (Bug#9390).
3267 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3268 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3269 so that the name doesn't mislead. All uses changed.
3271 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3273 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3276 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3278 * xdisp.c (move_it_to): Don't bail out early when reaching
3279 position beyond to_charpos, if we are scanning backwards.
3280 (move_it_vertically_backward): When DY == 0, make sure we get to
3281 the first character in the line after the newline.
3283 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3285 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3286 (ccl_driver): Do not generate an out-of-range pointer.
3287 (Fccl_execute_on_string): Remove unnecessary check for
3288 integer overflow, noted by Stefan Monnier in
3289 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3290 Remove a FIXME that didn't need fixing.
3291 Simplify the newly-introduced buffer reallocation code.
3293 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3295 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3297 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3299 Integer and memory overflow issues (Bug#9196).
3301 * doc.c (get_doc_string): Rework so that
3302 get_doc_string_buffer_size is the actual buffer size, rather than
3303 being 1 less than the actual buffer size; this makes xpalloc more
3306 * image.c (x_allocate_bitmap_record, cache_image):
3307 * xselect.c (Fx_register_dnd_atom):
3308 Simplify previous changes by using xpalloc.
3310 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3311 since either will do and ptrdiff_t is convenient with xpalloc.
3313 * charset.c (charset_table_size)
3314 (struct charset_sort_data.priority): Now ptrdiff_t.
3315 (charset_compare): Don't overflow if priorities differ greatly.
3316 (Fsort_charsets): Don't assume list length fits in int.
3317 Check for size-calculation overflow when allocating sort data.
3318 (syms_of_charset): Allocate an initial charset table that is
3319 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3321 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3323 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3324 The actual value is always <= INT_MAX, and leaving it unsigned made
3325 overflow checking harder.
3327 * dispextern.h (struct glyph_matrix.rows_allocated)
3328 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3329 with xpalloc. The values are still always <= INT_MAX.
3331 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3333 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3334 (SAFE_NALLOCA): New macro.
3336 * region-cache.c (struct boundary.pos, find_cache_boundary)
3337 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3338 (set_cache_region, invalidate_region_cache)
3339 (revalidate_region_cache, know_region_cache, region_cache_forward)
3340 (region_cache_backward, pp_cache):
3341 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3342 so that ptrdiff_t * can be passed to xpalloc.
3343 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3344 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3345 (pp_cache): Don't assume cache_len fits in int.
3346 * region-cache.h: Adjust extern decls to match.
3348 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3349 EMACS_INT, since either will do, for xpalloc.
3351 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3352 (xnmalloc, xnrealloc, xpalloc): New functions.
3354 * bidi.c (bidi_shelve_header_size): New constant.
3355 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3356 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3358 * bidi.c (bidi_cache_shrink):
3359 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3361 Don't update size of array until after memory allocation succeeds,
3362 because xmalloc/xrealloc may not return.
3363 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3364 now that we have proper integer overflow checking.
3365 (record_overlay_string, overlay_strings): Catch overflows when
3366 calculating size of overlay_str_buf.
3368 * callproc.c (Fcall_process): Check for size overflow when
3369 calculating size of args2.
3370 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3371 Normally we prefer signed values, but sticking with ptrdiff_t would
3372 require adding more-complicated checks.
3374 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3375 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3376 Redo buffer-overflow calculations to avoid integer overflow.
3377 Add a FIXME comment where memory seems to be over-allocated.
3379 * character.c (Fstring): Check for size-calculation overflow.
3381 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3382 unnecessary integer overflow. Check for size overflow.
3383 (encode_coding_object): Don't update size until xmalloc succeeds.
3385 * composite.c (get_composition_id): Check for overflow in glyph
3386 length calculations.
3388 Integer and memory overflow fixes for display code.
3389 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3390 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3391 (scrolling_window): Check for overflow in size calculations.
3392 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3393 Don't assume glyph table len fits in int.
3394 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3395 (row_table_size): Now ptrdiff_t, not int.
3396 (scrolling_window): Avoid overflow in size calculations.
3397 Don't update size until allocation succeeds.
3398 * fns.c (concat): Check for overflow in size calculations.
3399 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3400 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3401 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3403 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3404 (get_doc_string): Check for size calculation overflow.
3405 Don't update size until allocation succeeds.
3406 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3407 EMACS_INT, where ptrdiff_t will do.
3408 (Fsubstitute_command_keys): Check for string overflow.
3410 * editfns.c (set_time_zone_rule): Don't assume environment length
3412 (message_length): Now ptrdiff_t, not int.
3413 (Fmessage_box): Don't update size until allocation succeeds.
3414 Don't assume message length fits in int.
3415 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3417 * emacs.c (main): Do not reallocate argv, since there is a null at
3418 the end that can be overwritten, and this way there's no need to
3419 worry about size-calculation overflow.
3420 (sort_args): Check for size-calculation overflow.
3422 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3424 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3426 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3427 (x_set_scroll_bar_width, x_figure_window_size):
3428 Check for integer overflow.
3429 (x_set_alpha): Do not assume XINT fits in int.
3431 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3432 This is for the members text_lines, text_cols, total_lines, total_cols,
3433 where the system imposes an 'int' limit.
3435 * fringe.c (Fdefine_fringe_bitmap):
3436 Don't update size until alloc works.
3438 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3439 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3441 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3442 Check for size-calculation overflow.
3443 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3444 do, as we prefer signed integers.
3445 (id_to_widget.max_size, id_to_widget.used)
3446 (xg_store_widget_in_map, xg_remove_widget_from_map)
3447 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3448 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3449 Use and return ptrdiff_t, not int.
3450 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3451 * gtkutil.h: Change prototypes to match the above.
3453 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3454 are duplicate now that they've been promoted to lisp.h.
3455 (x_allocate_bitmap_record, x_alloc_image_color)
3456 (make_image_cache, cache_image, xpm_load):
3457 Don't update size until alloc is done.
3458 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3460 Check for size calculation overflow.
3461 (ct_colors_allocated_max): New constant.
3462 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3465 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3466 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3467 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3468 Use ptrdiff_t, not int, to count maps.
3469 (read_char_minibuf_menu_prompt): Check for overflow in size
3470 calculations. Don't update size until allocation succeeds.
3471 Redo calculations to avoid overflow.
3472 * keyboard.h: Change prototypes to match the above.
3474 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3476 (current_minor_maps): Check for size calculation overflow.
3477 * keymap.h: Change prototypes to match the above.
3479 * lread.c (read1, init_obarray): Don't update size until alloc done.
3481 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3482 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3484 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3485 Now ptrdiff_t, not int.
3486 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3487 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3489 * process.c (Fnetwork_interface_list): Check for overflow
3490 in size calculation.
3492 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3494 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3495 overflow. Don't bother calling xmalloc when xrealloc will do.
3497 * search.c (Freplace_match): Check for size calculation overflow.
3498 (Fset_match_data): Don't assume list lengths fit in 'int'.
3500 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3501 for command line length. Do not attempt to address one before the
3502 beginning of an array, as that's not portable.
3504 * term.c (max_frame_lines): Remove; unused.
3505 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3507 (encode_terminal_code, calculate_costs): Check for size
3508 calculation overflow.
3509 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3510 table lengths and related sizes. Don't update size until alloc
3511 done. Redo calculations to avoid overflow.
3512 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3514 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3515 subtracting pointers.
3516 (gobble_line): Check for overflow more carefully. Don't update size
3519 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3520 Don't update size until alloc done.
3521 Redo size calculations to avoid overflow.
3522 Check for size calculation overflow.
3523 (main) [DEBUG]: Fix typo in invoking tparam1.
3525 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3526 Use ptrdiff_t, not int, for sizes.
3527 (store_mode_line_noprop_char): Don't update size until alloc done.
3529 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3530 Use ptrdiff_t, not int, for sizes.
3531 (Finternal_make_lisp_face, cache_face):
3532 Check for size calculation overflow.
3533 (cache_face): Treat size calculation overflows as if they were
3534 memory exhaustion (the usual treatment), rather than aborting.
3536 * xfns.c (x_encode_text, x_set_name_internal)
3537 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3538 sizes, since they can exceed INT_MAX in size. Check for size
3539 calculation overflow.
3541 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3542 (xg_select): Check for size calculation overflow.
3543 Don't update size until alloc done.
3545 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3546 as sprintf is limited to int lengths.
3548 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3549 (X_LONG_MIN): New macros.
3550 Use them to make the following changes clearer.
3551 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3552 This change doesn't affect the value now, but it may help remind
3553 future maintainers not to raise the value too much later.
3554 (SELECTION_QUANTUM): Remove, replacing with ...
3555 (selection_quantum): ... new function, which avoids overflow.
3557 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3558 assumption that selection length fits in 'int'.
3559 (x_reply_selection_request, x_handle_selection_request)
3560 (x_get_window_property, receive_incremental_selection)
3561 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3562 (lisp_data_to_selection_data, clean_local_selection_data):
3563 Use ptrdiff_t, not int, to record length of selection.
3564 (x_reply_selection_request, x_get_window_property)
3565 (receive_incremental_selection, x_property_data_to_lisp):
3566 Redo calculations to avoid overflow.
3567 (x_reply_selection_request): When sending hint, ceiling it at
3568 X_LONG_MAX rather than relying on wraparound overflow to send
3570 (x_get_window_property, receive_incremental_selection)
3571 (lisp_data_to_selection_data, x_property_data_to_lisp):
3572 Check for size-calculation overflow.
3573 (x_get_window_property, receive_incremental_selection)
3574 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3575 Don't store size until memory allocation succeeds.
3576 (x_get_window_property): Plug memory leak on memory exhaustion.
3577 Don't double-block input; malloc is safe here. Don't assume 2**34
3578 - 4 fits in unsigned long. Add an xassert to check
3579 XGetWindowProperty overflow. Be more careful about overflow
3580 calculations, and distinguish size from memory overflow better.
3581 (receive_incremental_selection): When tracing, don't assume
3582 unsigned int is less than INT_MAX.
3583 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3584 harmful) conversions of unsigned short to int.
3585 (lisp_data_to_selection_data): Don't assume that integers
3586 in the range -65535 through -1 fit in an X unsigned short.
3587 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3588 result parameters unless successful. Rely on cons_to_unsigned
3589 to report problems with elements; the old code wasn't right anyway.
3590 (x_check_property_data): Check for int overflow; we cannot use
3591 a wider type due to X limits.
3592 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3594 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3596 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3597 (x_term_init): Check for size calculation overflow.
3598 (x_color_cells): Don't store size until memory allocation succeeds.
3599 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3600 Don't assume alloca size is less than MAX_ALLOCA.
3601 (x_term_init): Don't assume length fits in int (sprintf is limited
3604 Use ptrdiff_t for composition IDs.
3605 * character.c (lisp_string_width):
3606 * composite.c (composition_table_size, n_compositions)
3607 (get_composition_id, composition_gstring_from_id):
3608 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3609 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3610 * window.c (Frecenter):
3611 Use ptrdiff_t, not int, for composition IDs.
3612 * composite.c (get_composition_id): Check for integer overflow.
3613 * composite.h: Adjust prototypes to match the above changes.
3615 Use ptrdiff_t for hash table indexes.
3616 * category.c (hash_get_category_set):
3617 * ccl.c (ccl_driver):
3618 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3619 * coding.c (coding_system_charset_list, detect_coding_system):
3620 * coding.h (struct coding_system.id):
3621 * composite.c (get_composition_id, gstring_lookup_cache):
3622 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3623 * image.c (xpm_get_color_table_h):
3624 * lisp.h (hash_lookup, hash_put):
3625 * minibuf.c (Ftest_completion):
3626 Use ptrdiff_t for hash table indexes, not int (which is too
3627 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3628 32-bit --with-wide-int hosts).
3630 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3631 Add a FIXME comment about memory leaks.
3632 (syms_of_charset): Don't assume xmalloc returns.
3634 Don't assume that stated character widths fit in int.
3635 * character.c (Fchar_width, c_string_width, lisp_string_width):
3636 * character.h (CHAR_WIDTH):
3637 * indent.c (MULTIBYTE_BYTES_WIDTH):
3638 Use sanitize_char_width to avoid undefined and/or bad behavior
3639 with outlandish widths.
3640 * character.h (sanitize_tab_width): Rename from sanitize_width,
3641 now that we have two such functions. All uses changed.
3642 (sanitize_char_width): New inline function.
3644 Don't assume that tab-width fits in int.
3645 * character.h (sanitize_width): New inline function.
3646 (SANE_TAB_WIDTH): New macro.
3647 (ASCII_CHAR_WIDTH): Use it.
3648 * indent.c (sane_tab_width): Remove. All uses replaced by
3649 SANE_TAB_WIDTH (current_buffer).
3650 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3652 * fileio.c: Integer overflow issues with file modes.
3653 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3655 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3656 Remove unreachable code.
3657 (read_hex, load_charset_map_from_file): Check for integer overflow.
3659 * xterm.c: Don't go over XClientMessageEvent limit.
3660 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3661 (x_send_scroll_bar_event): Likewise. Check that the size does not
3662 exceed limits imposed by XClientMessageEvent, as well as the usual
3663 ptrdiff_t and size_t limits.
3665 * keyboard.c: Overflow, signedness and related fixes.
3666 (make_lispy_movement): Use same integer type in forward decl
3667 that is used in the definition.
3668 (read_key_sequence, keyremap_step):
3669 Change bufsize argument back to int, undoing my 2011-03-30 change.
3670 We prefer signed types, and int is wide enough here.
3671 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3672 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3673 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3674 length, not size_t. Use ptrdiff_t for index, not int.
3675 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3676 possibility of integer overflow.
3678 Overflow, signedness and related fixes for images.
3680 * dispextern.h (struct it.stack[0].u.image.image_id)
3681 (struct_it.image_id, struct image.id, struct image_cache.size)
3682 (struct image_cache.used, struct image_cache.ref_count):
3683 * gtkutil.c (update_frame_tool_bar):
3684 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3685 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3686 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3687 * nsmenu.m (update_frame_tool_bar):
3688 * xdisp.c (calc_pixel_width_or_height):
3689 * xfns.c (image_cache_refcount):
3690 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3691 on typical 64-bit hosts.
3693 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3694 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3695 Omit unnecessary casts to int.
3696 (parse_image_spec): Check that integers fall into 'int' range
3697 when the callers expect that.
3698 (image_ascent): Redo ascent calculation to avoid int overflow.
3699 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3700 (lookup_image): Remove unnecessary tests.
3701 (xbm_image_p): Locals are now of int, not EMACS_INT,
3702 since parse_image_check makes sure they fit into int.
3703 (png_load, gif_load, svg_load_image):
3704 Prefer int to unsigned where either will do.
3705 (tiff_handler): New function, combining the cores of the
3706 old tiff_error_handler and tiff_warning_handler.
3707 This function is rewritten to use vsnprintf and thereby avoid
3708 stack buffer overflows. It uses only the features of vsnprintf
3709 that are common to both POSIX and native Microsoft.
3710 (tiff_error_handler, tiff_warning_handler): Use it.
3711 (tiff_load, gif_load, imagemagick_load_image):
3712 Don't assume :index value fits in 'int'.
3713 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3714 (imagemagick_load_image): Check that crop parameters fit into
3715 the integer types that MagickCropImage accepts. Don't assume
3716 Vimagemagick_render_type has a nonnegative value. Don't assume
3717 size_t fits in 'long'.
3718 (gs_load): Use printmax_t to print the widest integers possible.
3719 Check for integer overflow when computing image height and width.
3721 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3723 * xdisp.c (redisplay_window): Don't force window start if point
3724 will be invisible in the resulting window. (Bug#9324)
3726 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3728 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3729 the display spec is of the form `(space ...)'.
3730 (handle_display_spec): Return the value returned by
3731 handle_single_display_spec, not just 1 or zero.
3732 (handle_single_display_spec): If the display spec is of the form
3733 `(space ...)', and specifies display in the text area, return 2
3735 (try_cursor_movement): Check for the need to scroll more
3736 accurately, and prefer exact match for point under bidi.
3737 Don't advance `row' beyond the last row of the window.
3739 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3740 into disp_prop; all users changed.
3742 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3743 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3744 for the text covered by the display property.
3746 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3748 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3749 Change return value to nil.
3750 (Frecord_buffer): Delete unused function.
3752 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3754 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3755 buffers, return left-to-right.
3756 (set_cursor_from_row): Consider candidate row a win if its glyph
3757 represents a newline and point is on that newline. Fixes cursor
3758 positioning on the newline at EOL of R2L text within L2R
3759 paragraph, and vice versa.
3760 (try_cursor_movement): Check continued rows, in addition to
3761 continuation rows. Fixes unwarranted scroll when point enters a
3762 continued line of R2L text within an L2R paragraph, or vice versa.
3763 (cursor_row_p): Consider the case of point being equal to
3764 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3765 from the end of a short line to the beginning of a continued line
3766 of R2L text within L2R paragraph.
3767 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3768 composed characters.
3770 * bidi.c (bidi_check_type): Use xassert.
3771 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3774 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3776 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3779 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3781 * nsfont.m (ns_otf_to_script): Fix typo.
3783 2011-08-22 Kenichi Handa <handa@m17n.org>
3785 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3786 extra slot even if the purpose is char-code-property-table.
3788 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3790 * xdisp.c (redisplay_window): When computing centering_position,
3791 account for the height of the header line. (Bug#8874)
3793 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3794 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3795 candidate is selected by the mouse, and that candidate has a
3796 composed character under the mouse.
3798 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3799 coordinates reported by pos-visible-in-window-p for a composed
3800 character in column zero.
3802 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3804 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3806 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3808 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3809 consider it a hit if to_charpos is anywhere in the range of the
3810 composed buffer positions.
3812 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3814 * image.c (gif_load): Don't assume that each subimage has the same
3815 dimensions as the base image. Handle disposal method that is
3816 "undefined" by the gif spec (Bug#9335).
3818 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3820 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3821 (Fcondition_case): Document `debug' symbol in error handler.
3823 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3825 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3826 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3827 from an Org mode buffer to a Speedbar frame.
3829 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3830 a composition, take its buffer position from IT->cmp_it.charpos.
3831 Fixes cursor positioning at the beginning of a line that begins
3832 with a composed character.
3834 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3836 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3837 character bidirectional type, use STRONG_L instead. Fixes crashes
3838 in a buffer produced by `describe-categories'.
3840 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3841 members before the level stack, so they would be saved and
3842 restored when copying iterator state. Fixes incorrect reordering
3843 around TABs covered by display properties.
3845 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3847 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3849 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3851 * eval.c (internal_condition_case, internal_condition_case_1)
3852 (internal_condition_case_2, internal_condition_case_n):
3853 Remove unnecessary aborts (Bug#9081).
3855 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3857 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3858 has no `load' handler, try opening the file locally. (Bug#9311)
3860 2011-08-16 Ken Brown <kbrown@cornell.edu>
3862 * gmalloc.c: Expand comment.
3864 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3866 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3867 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3869 2011-08-16 Ken Brown <kbrown@cornell.edu>
3871 Fix memory allocation problems in Cygwin build (Bug#9273).
3873 * unexcw.c ( __malloc_initialized): Declare external variable.
3874 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3876 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3878 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3880 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3882 [CYGWIN] (special_realloc): New function.
3883 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3884 requests to realloc storage in the static heap.
3886 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3888 * bidi.c (bidi_initialize): Remove unused local.
3890 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3893 * biditype.h: Remove file.
3894 * makefile.w32-in ($(BLD)/bidi.$(O)):
3895 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3897 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3899 * chartab.c: Improve commentary for the uniprop_table API.
3901 * bidi.c (bidi_paragraph_init): Support zero value of
3902 bidi_ignore_explicit_marks_for_paragraph_level.
3903 (bidi_initialize): Use uniprop_table instead of including
3904 biditype.h and bidimirror.h.
3906 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3907 coordinates of the iterator when restoring from ppos_it.
3910 2011-08-14 Kenichi Handa <handa@m17n.org>
3912 * process.c (create_process): Call setup_process_coding_systems
3913 after the pid of the process is set to -1 (Bug#8162).
3915 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3917 * xdisp.c (move_it_in_display_line_to): Don't invoke
3918 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3919 ppos_it. Fixes vertical cursor motion when line beginning is
3920 covered by an image. (Bug#9296)
3922 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3924 * nsterm.h (ns_run_ascript): Declare.
3925 (NSAPP_DATA2_RUNASSCRIPT): Define.
3927 * nsfns.m (as_script, as_result, as_status): New static variables.
3928 (ns_run_ascript): New function.
3929 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3930 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3931 the event loop. Get status from as_status (Bug#7276).
3933 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3934 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3935 the event loop (Bug#7276).
3937 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3939 * gnutls.c (QCgnutls_bootprop_priority)
3940 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3941 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3942 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3943 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3944 (QCgnutls_bootprop_verify_hostname_error)
3945 (QCgnutls_bootprop_callbacks_verify): Rename from
3946 Qgnutls_bootprop_..., all uses changed.
3948 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3951 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3953 * xfaces.c (Qframe_set_background_mode): Now static.
3954 * dispextern.h (Qframe_set_background_mode): Remove decl.
3956 * process.c (Fnetwork_interface_info): Declare local only if needed.
3958 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3960 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3961 (Fnetwork_interface_list): Allocate in increments of bytes instead
3962 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3963 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3965 (struct ifflag_def): notrailers is smart on OSX.
3966 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3967 Get hardware address with getifaddrs if available.
3969 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3971 * xdisp.c (iterate_out_of_display_property): xassert that
3972 IT->position is set to within IT->object's boundaries. Break from
3973 the loop as soon as EOB is reached; avoids infloops in redisplay
3974 when IT->position is set up wrongly due to some bug.
3975 Set IT->current to match the bidi iterator unconditionally.
3976 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3977 entry. Force push_it to save on the stack the current
3978 buffer/string position, to be restored by pop_it. Fix flags in
3979 the iterator structure wrt the object coming from a display
3980 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3981 properties. (Bug#9284)
3983 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3985 * fontset.c (fontset_get_font_group): Add proper type checks.
3988 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3990 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3991 and LC_VERSION_MIN_MACOSX.
3992 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3993 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3995 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3997 * xdisp.c (forward_to_next_line_start): Allow to use the
3998 no-display-properties-and-no-overlays under bidi display.
3999 Set disp_pos in the bidi iterator to avoid searches for display
4000 properties and overlays.
4002 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4004 * editfns.c (Fset_time_zone_rule): Document relationship with the
4007 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4008 the font entity extracted from the cache (Bug#8109).
4010 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4012 * composite.c (autocmp_chars): Don't reset point. That is done by
4013 restore_point_unwind (Bug#5984).
4015 2011-08-07 Juri Linkov <juri@jurta.org>
4017 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4018 to show the arg `TIME' instead of `TIMEVAL'.
4020 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4022 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4023 display property strides EOL and includes a newline, as in
4024 longlines-mode. (Bug#9254)
4025 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4026 word-wrap under bidirectional display. (Bug#9224)
4028 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4029 is non-zero, even if the data buffer is NULL. Fixes a crash in
4030 vertical-motion with longlines-mode. (Bug#9254)
4032 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4034 * bidi.c <bidi_cache_total_alloc>: Now static.
4035 (bidi_initialize): Initialize bidi_cache_total_alloc.
4037 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4040 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4041 amount allocated this far in `bidi_cache_total_alloc'.
4042 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4043 non-zero, only free the data buffer without restoring the cache
4044 contents. All callers changed.
4046 * dispextern.h (bidi_unshelve_cache): Update prototype.
4048 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4049 (move_it_in_display_line, move_it_to)
4050 (move_it_vertically_backward, move_it_by_lines): Replace the call
4051 to xfree to an equivalent call to bidi_unshelve_cache.
4052 (move_it_in_display_line_to): Fix logic of returning
4053 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4055 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4057 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4058 came from a string character with a `cursor' property. (Bug#9229)
4060 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4062 * Makefile.in (LIB_PTHREAD): New variable.
4063 (LIBES): Add LIB_PTHREAD (Bug#9216).
4065 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4066 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4068 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4070 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4072 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4074 * xterm.c (x_find_topmost_parent): New function.
4075 (x_set_frame_alpha): Find topmost parent window with
4076 x_find_topmost_parent and set the property there also (bug#9181).
4077 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4079 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4081 * callproc.c (Fcall_process): Avoid vfork clobbering
4082 the local vars buffer, coding_systems, current_dir.
4084 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4086 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4088 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4090 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4091 so that it is not optimized away.
4093 * xdisp.c (compute_display_string_pos): Remove unused local.
4095 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4097 Fix slow cursor motion and scrolling in large buffers with
4098 selective display, like Org Mode buffers. (Bug#9218)
4100 * dispextern.h (struct bidi_it): New member disp_prop_p.
4102 * xdisp.c: Remove one-slot cache of display string positions.
4103 (compute_display_string_pos): Accept an additional argument
4104 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4105 for a display string or property. If found, set DISP_PROP_P
4108 * bidi.c (bidi_fetch_char): Accept an additional argument
4109 DISP_PROP_P, and pass it to compute_display_string_pos.
4110 Only handle text covered by a display string if DISP_PROP_P is returned
4111 non-zero. All callers of bidi_fetch_char changed.
4113 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
4115 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
4117 2010-12-03 Don March <don@ohspite.net>
4119 * keymap.c (Fdefine_key): Fix non-prefix key error message when
4120 last character M-[char] is translated to ESC [char] (bug#7541).
4122 2011-08-02 Kenichi Handa <handa@m17n.org>
4124 * lisp.h (uniprop_table): Extern it.
4126 * chartab.c (uniprop_table): Make it non-static.
4128 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4130 * xdisp.c (forward_to_next_line_start): Accept additional argument
4131 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4133 (reseat_at_next_visible_line_start): Use the bidi iterator state
4134 returned by forward_to_next_line_start to restore the state of
4135 it->bidi_it after backing up to previous newline. (Bug#9212)
4137 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4139 * regex.c (re_comp): Protoize.
4140 (re_exec): Fix return type.
4141 (regexec): Fix type of `ret'. (Bug#9203)
4143 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4145 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4146 This is needed if max-image-size is a floating-point number.
4148 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4150 * print.c (print_object): Print empty symbol as ##.
4152 * lread.c (read1): Read ## as empty symbol.
4154 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4156 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4157 setting frame foreground color (Bug#9175).
4158 (x_set_background_color): Likewise.
4160 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4161 contents (Bug#9176).
4162 (EmacsTooltip -init): Remove bezels and add shadows to
4165 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4166 or scroll bar (Bug#8470).
4168 * nsfont.m (nsfont_open): Remove assignment to voffset and
4169 unnecessary vars hshink, expand, hd, full_height, min_height.
4170 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4172 * nsterm.h (nsfont_info): Remove voffset field.
4174 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4176 Implement strike-through and overline on NextStep (Bug#8863).
4178 * nsfont.m (nsfont_open): Use underline position provided by font,
4179 instead of hard-coded value of 2.
4180 (nsfont_draw): Call ns_draw_text_decoration instead.
4182 * nsterm.h: Add declaration for ns_draw_text_decoration.
4184 * nsterm.m (ns_draw_text_decoration): New function for drawing
4185 underline, overline, and strike-through.
4186 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4187 ns_draw_text_decoration. Change treatment of cursor drawing to
4188 accommodate underlining, etc.
4190 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4192 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4195 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4197 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4198 Without this fix, if a signal arrives just after memory fills up,
4199 'malloc' might be invoked reentrantly.
4201 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4202 In other words, assume that every image size is allowed, on non-X
4203 hosts. This assumption is probably wrong, but it lets Emacs compile.
4205 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4207 * regex.c (re_iswctype): Convert return values to boolean.
4209 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4211 * xdisp.c (compute_display_string_pos): Don't use cached display
4212 string position if the buffer had its restriction changed.
4215 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4217 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4219 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4221 Integer signedness and overflow and related fixes. (Bug#9079)
4223 * bidi.c: Integer size and overflow fixes.
4224 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4225 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4226 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4227 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4228 (bidi_find_other_level_edge):
4229 Use ptrdiff_t instead of EMACS_INT where either will do.
4230 This works better on 32-bit hosts configured --with-wide-int.
4231 (bidi_cache_ensure_space): Check for size-calculation overflow.
4232 Use % rather than repeated addition, for better worst-case speed.
4233 Don't set bidi_cache_size until after xrealloc returns, because it
4235 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4236 (bidi_cache_ensure_space): Also check that the bidi cache size
4237 does not exceed that of the largest Lisp string or buffer. See Eli
4238 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4240 * alloc.c (__malloc_size_t): Remove.
4241 All uses replaced by size_t. See Andreas Schwab's note
4242 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4244 * image.c: Improve checking for integer overflow.
4245 (check_image_size): Assume that f is nonnull, since
4246 it is always nonnull in practice. This is one less thing to
4247 worry about when checking for integer overflow later.
4248 (x_check_image_size): New function, which checks for integer
4249 overflow issues inside X.
4250 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4251 This removes the need for a memory_full check.
4252 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4253 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4254 (xbm_read_bitmap_data): Change locals back to 'int', since
4255 their values must fit in 'int'.
4256 (xpm_load_image, png_load, tiff_load):
4257 Invoke x_create_x_image_and_pixmap earlier,
4258 to avoid much needless work if the image is too large.
4259 (tiff_load): Treat overly large images as if
4260 x_create_x_image_and_pixmap failed, not as malloc failures.
4261 (gs_load): Use x_check_image_size.
4263 * gtkutil.c: Omit integer casts.
4264 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4265 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4267 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4269 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4270 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4271 would wrongly return t on a 64-bit host.
4273 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4274 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4275 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4276 and therefore cause GCC to emit a bogus diagnostic in some cases.
4278 * image.c: Integer signedness and overflow and related fixes.
4279 This is not an exhaustive set of fixes, but it's time to
4280 record what I've got.
4281 (lookup_pixel_color, check_image_size): Remove redundant decls.
4282 (check_image_size): Don't assume that arbitrary EMACS_INT values
4283 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4284 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4285 (tiff_load, imagemagick_load_image):
4286 Check for overflow in size calculations.
4287 (x_create_x_image_and_pixmap): Remove unnecessary test for
4288 xmalloc returning NULL; that can't happen.
4289 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4290 (xpm_color_bucket): Use better integer hashing function.
4291 (xpm_cache_color): Don't possibly over-allocate memory.
4292 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4293 (gif_memory_source):
4294 Use ptrdiff_t, not int or size_t, to record sizes.
4295 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4296 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4297 either works, as we prefer signed integers.
4298 (tiff_read_from_memory, tiff_write_from_memory):
4299 Return tsize_t, not size_t, since that's what the TIFF API wants.
4300 (tiff_read_from_memory): Don't fail simply because the read would
4301 go past EOF; instead, return a short read.
4302 (tiff_load): Omit no-longer-needed casts.
4303 (Fimagemagick_types): Don't assume size fits into 'int'.
4305 Improve hashing quality when configured --with-wide-int.
4306 * fns.c (hash_string): New function, taken from sxhash_string.
4307 Do not discard information about ASCII character case; this
4308 discarding is no longer needed.
4309 (sxhash-string): Use it. Change sig to match it. Caller changed.
4310 * lisp.h: Declare it.
4311 * lread.c (hash_string): Remove, since we now use fns.c's version.
4312 The fns.c version returns a wider integer if --with-wide-int is
4313 specified, so this should help the quality of the hashing a bit.
4315 * emacs.c: Integer overflow minor fix.
4316 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4317 Define only if GNU_LINUX.
4318 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4320 * dispnew.c: Integer signedness and overflow fixes.
4321 Remove unnecessary forward decls, that were a maintenance hassle.
4322 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4324 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4325 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4326 (prepare_desired_row, line_draw_cost):
4327 Use int, not unsigned, where either works.
4328 (save_current_matrix, restore_current_matrix):
4329 Use ptrdiff_t, not size_t, where either works.
4330 (init_display): Check for overflow more accurately, and without
4331 relying on undefined behavior.
4333 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4334 Remove, replacing with the new symbols in lisp.h. All uses changed.
4335 * fileio.c (make_temp_name):
4336 * filelock.c (lock_file_1, lock_file):
4337 * xdisp.c (message_dolog):
4338 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4339 Use pMd etc. instead.
4340 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4341 replacing the pWIDE etc. symbols removed from editfns.c.
4343 * keyboard.h (num_input_events): Now uintmax_t.
4344 This is (very slightly) less likely to mess up due to wraparound.
4347 * buffer.c: Integer signedness fixes.
4348 (alloc_buffer_text, enlarge_buffer_text):
4349 Use ptrdiff_t rather than size_t when either will do, as we prefer
4352 * alloc.c: Integer signedness and overflow fixes.
4353 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4354 (__malloc_size_t): Default to size_t, not to int.
4355 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4356 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4357 Prefer ptrdiff_t to size_t when either would do, as we prefer
4359 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4360 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4361 Now const. Initialize with values that are in range even if char
4363 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4364 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4365 These functions do the right thing with sizes > 2**32.
4366 (check_depth): Now ptrdiff_t, not int.
4367 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4368 Adjust to new way of storing sizes. Check for size overflow bugs
4370 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4371 slightly wrong anyway, as it missed one instance of
4372 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4373 (refill_memory_reserve): Omit needless cast to size_t.
4374 (mark_object_loop_halt): Mark as externally visible.
4376 * xselect.c: Integer signedness and overflow fixes.
4377 (Fx_register_dnd_atom, x_handle_dnd_message):
4378 Use ptrdiff_t, not size_t, since we prefer signed.
4379 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4380 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4381 x_dnd_atoms_size and x_dnd_atoms_length.
4383 * doprnt.c: Prefer signed to unsigned when either works.
4385 * doprnt.c (doprnt):
4387 * xdisp.c (vmessage):
4388 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4389 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4390 prefer signed arithmetic to avoid comparison confusion.
4391 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4392 but is a bit tricky.
4394 Assume freestanding C89 headers, string.h, stdlib.h.
4395 * data.c, doprnt.c, floatfns.c, print.c:
4396 Include float.h unconditionally.
4397 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4398 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4399 * regex.c: Likewise for stddef.h, string.h.
4400 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4401 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4402 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4403 (STDC_HEADERS): Remove obsolete defines.
4404 * sysdep.c: Include limits.h unconditionally.
4406 Assume support for memcmp, memcpy, memmove, memset.
4407 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4408 * regex.c (memcmp, memcpy):
4409 Remove; we assume C89 now.
4411 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4412 (__malloc_safe_bcopy): Remove; no longer needed.
4414 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4415 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4416 well either way, and we prefer signed to unsigned.
4418 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4420 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4421 closes the connection while we're reading (bug#9182).
4423 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4425 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4426 are specified (Bug#9168).
4428 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4430 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4431 Found by GCC static checking and --with-wide-int on a 32-bit host.
4433 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4435 * xdisp.c (compute_display_string_pos): Fix logic of caching
4436 previous display string position. Initialize cached_prev_pos to
4437 -1. Fixes slow-down at the beginning of a buffer.
4439 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4441 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4442 for attrs[LFACE_FONTSET_INDEX].
4444 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4446 * xml.c (parse_region): Remove unused local
4447 that was recently introduced.
4449 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4451 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4452 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4454 * xdisp.c (move_it_in_display_line_to): Record the best matching
4455 position for TO_CHARPOS while scanning the line, and restore it on
4456 exit if none of the characters scanned was an exact match.
4457 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4458 when exact match is impossible due to invisible text, and the
4459 lines are truncated.
4461 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4463 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4466 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4468 Fix a significant slow-down of cursor motion with C-n, C-p,
4469 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4470 auto-repeat under bidi redisplay in fontified buffers.
4471 * xdisp.c (compute_stop_pos_backwards): New function.
4472 (next_element_from_buffer): Call compute_stop_pos_backwards to
4473 find a suitable prev_stop when we find ourselves before
4475 (reseat): Don't look for prev_stop, as that could mean a very long
4477 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4478 <cached_disp_overlay_modiff>: Cache for last found display string
4480 (compute_display_string_pos): Return the cached position if asked
4481 about the same buffer in the same area of character positions, and
4482 the buffer wasn't changed since the time the display string
4483 position was cached.
4485 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4487 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4488 is an integer, which is important for empty lines. (Bug#9149)
4490 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4492 * frame.c (Fmodify_frame_parameters): In tty case, update the
4493 default face if necessary (Bug#4238).
4495 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4497 * editfns.c (Fstring_to_char): No need to explain what a character
4498 is in the docstring (Bug#6576).
4500 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4502 * xml.c (parse_region): Make sure we always return a tree.
4504 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4506 * xml.c (parse_region): If a document contains only comments,
4509 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4511 * xml.c (make_dom): Return comments, too.
4513 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4516 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4517 and the surrounding thread.
4518 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4519 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4520 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4522 * s/openbsd.h (BROKEN_SIGIO): Define.
4523 * unexelf.c (unexec) [__OpenBSD__]:
4524 Don't update the .mdebug section of the Alpha COFF symbol table.
4526 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4528 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4531 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4533 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4534 This fixes some race conditions on the permissions of any newly
4537 * alloc.c (valid_pointer_p): Use pipe, not open.
4538 This fixes some permissions issues when debugging.
4540 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4541 If fchown fails to set both uid and gid, try to set just gid,
4542 as that is sometimes allowed. Adjust the file's mode to eliminate
4543 setuid or setgid bits that are inappropriate if fchown fails.
4545 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4547 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4548 to compare Lisp_Objects.
4549 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4550 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4551 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4553 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4555 * lread.c (read_integer): Unread even EOF character.
4556 (read1): Likewise. Properly record start position of symbol.
4558 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4559 symbol character follows.
4561 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4563 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4564 This works around a problem with the previous change to Fcopy_file.
4565 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4566 and without this change, GCC might complain about discarding
4567 fchown's return value.
4569 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4571 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4573 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4575 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4577 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4579 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4580 it's used from the C level.
4582 * process.c: Use the same condition for POLL_FOR_INPUT in both
4583 keyboard.c and process.c (bug#1858).
4585 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4587 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4588 (Fgnutls_boot): Use it.
4590 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4592 * doc.c (Fsubstitute_command_keys): Revert last change.
4594 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4596 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4597 quotes the next character, and doesn't affect other longer
4598 sequences (bug#8935).
4600 * lread.c (syms_of_lread): Clarify that is isn't only
4601 `eval-buffer' and `eval-defun' that's affected by
4602 `lexical-binding' (bug#8460).
4604 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4606 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4607 bidi redisplay when a line includes both an image and is truncated.
4609 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4611 Fix minor problems found by static checking.
4612 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4613 (elsz): Now a signed constant, not a size_t var. We prefer signed
4614 types to unsigned, to avoid integer comparison confusion. Without
4615 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4616 "cannot optimize loop, the loop counter may overflow", a symptom
4618 * indent.c (Fvertical_motion): Mark locals as initialized.
4619 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4621 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4623 * search.c (Fre_search_backward): Mention `case-fold-search' in
4624 all the re_search_* functions (bug#8138).
4626 * keyboard.c (Fopen_dribble_file): Document when the file is
4629 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4631 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4634 Support bidi reordering of display and overlay strings.
4635 * xdisp.c (compute_display_string_pos)
4636 (compute_display_string_end): Accept additional argument STRING.
4637 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4638 (reseat_to_string): Initialize bidi_it->string.s and
4639 bidi_it->string.schars.
4640 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4641 NULL (avoids a crash in bidi_paragraph_init).
4642 Initialize itb.string.lstring.
4643 (init_iterator): Call bidi_init_it only of a valid
4644 buffer position was specified. Initialize paragraph_embedding to
4646 (reseat_to_string): Initialize the bidi iterator.
4647 (display_string): If we need to ignore text properties of
4648 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4649 original value of -1 will not work with bidi.)
4650 (compute_display_string_pos): First arg is now struct
4651 `text_pos *'; all callers changed. Support display properties on
4653 (compute_display_string_end): Support display properties on Lisp
4655 (init_iterator, reseat_1, reseat_to_string): Initialize the
4656 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4657 when iterating on a string not from display properties).
4658 (compute_display_string_pos, compute_display_string_end):
4659 Fix calculation of the object to scan. Fixes an error when using
4661 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4662 base_level_stop; instead, set base_level_stop to BEGV.
4663 Fixes crashes in vertical-motion.
4664 (next_element_from_buffer): Improve commentary for when
4665 the iterator is before prev_stop.
4666 (init_iterator): Initialize bidi_p from the default value of
4667 bidi-display-reordering, not from buffer-local value. Use the
4668 buffer-local value only if initializing for buffer iteration.
4669 (handle_invisible_prop): Support invisible properties on strings
4670 that are being bidi-reordered.
4671 (set_iterator_to_next): Support bidi reordering of C strings and
4673 (next_element_from_string): Support bidi reordering of Lisp
4675 (handle_stop_backwards): Support Lisp strings as well.
4676 (display_string): Support display of R2L glyph rows.
4677 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4678 (init_iterator): Don't initialize it->bidi_p for strings
4680 (reseat_to_string): Initialize it->bidi_p for strings here.
4681 (next_element_from_string, next_element_from_c_string)
4682 (next_element_from_buffer): Add xassert's for correspondence
4683 between IT's object being iterated and it->bidi_it.string
4685 (face_before_or_after_it_pos): Support bidi iteration.
4686 (next_element_from_c_string): Handle the case of the first string
4687 character that is not the first one in the visual order.
4688 (get_visually_first_element): New function, refactored from common
4689 parts of next_element_from_buffer, next_element_from_string, and
4690 next_element_from_c_string.
4691 (tool_bar_lines_needed, redisplay_tool_bar)
4692 (display_menu_bar): Force left-to-right direction. Add a FIXME
4693 comment for making that be controlled by a user option.
4694 (push_it, pop_it): Save and restore the state of the
4695 bidi iterator. Save and restore the bidi_p flag.
4696 (pop_it): Iterate out of display property for string iteration as
4698 (iterate_out_of_display_property): Support iteration over strings.
4699 (handle_single_display_spec): Set up it->bidi_it for iteration
4700 over a display string, and call bidi_init_it.
4701 (handle_single_display_spec, next_overlay_string)
4702 (get_overlay_strings_1, push_display_prop): Set up the bidi
4703 iterator for displaying display or overlay strings.
4704 (forward_to_next_line_start): Don't use the shortcut if
4706 (back_to_previous_visible_line_start): If handle_display_prop
4707 pushed the iterator stack, restore the internal state of the bidi
4708 iterator by calling bidi_pop_it same number of times.
4709 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4710 and we are bidi-iterating, don't decrement the iterator position;
4711 instead, set the first_elt flag in the bidi iterator, to produce
4713 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4714 (push_display_prop): xassert that we are iterating a buffer.
4715 (push_it, pop_it): Save and restore paragraph_embedding member.
4716 (handle_single_display_spec, next_overlay_string)
4717 (get_overlay_strings_1, reseat_1, reseat_to_string)
4718 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4719 correctly. Don't assume unibyte strings are not bidi-reordered.
4720 (compute_display_string_pos)
4721 (compute_display_string_end): Fix handling the case of C string.
4722 (push_it, pop_it): Save and restore from_disp_prop_p.
4723 (handle_single_display_spec, push_display_prop): Set the
4724 from_disp_prop_p flag.
4725 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4726 (pop_it): Call iterate_out_of_display_property only if we are
4727 popping after iteration over a string that came from a display
4728 property. Fix a typo in popping stretch info. Add an assertion
4729 for verifying that the iterator position is in sync with the bidi
4731 (handle_single_display_spec, get_overlay_strings_1)
4732 (push_display_prop): Fix initialization of paragraph direction for
4733 string when that of the parent object is not yet determined.
4734 (reseat_1): Call bidi_init_it to resync the bidi
4735 iterator with IT's position. (Bug#7616)
4736 (find_row_edges): If ROW->start.pos gives position
4737 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4738 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4739 Reset the from_disp_prop_p flag.
4740 (SAVE_IT, RESTORE_IT): New macros.
4741 (pos_visible_p, face_before_or_after_it_pos)
4742 (back_to_previous_visible_line_start)
4743 (move_it_in_display_line_to, move_it_in_display_line)
4744 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4745 (try_scrolling, redisplay_window, display_line): Use them when
4746 saving a temporary copy of the iterator and restoring it back.
4747 (back_to_previous_visible_line_start, reseat_1)
4748 (init_iterator): Empty the bidi cache "stack".
4749 (move_it_in_display_line_to): If iterator ended up at
4750 EOL, but we never saw any buffer positions smaller than
4751 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4752 motion in bidi-reordered lines.
4753 (move_it_in_display_line_to): Record prev_method and prev_pos
4754 immediately before the call to set_iterator_to_next. Fixes cursor
4755 motion in bidi-reordered lines with stretch glyphs and strings
4756 displayed in margins. (Bug#8133) (Bug#8867)
4757 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4759 (pos_visible_p): Support positions in bidi-reordered lines.
4760 Save and restore bidi cache.
4762 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4763 (bidi_paragraph_info): Delete unused struct.
4764 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4765 (bidi_cache_start): New variable.
4766 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4768 (bidi_cache_fetch_state, bidi_cache_search)
4769 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4770 (bidi_cache_find, bidi_peek_at_next_level)
4771 (bidi_level_of_next_char, bidi_find_other_level_edge)
4772 (bidi_move_to_visually_next): Compare cache index with
4773 bidi_cache_start rather than with zero.
4774 (bidi_fetch_char): Accept new argument STRING; all callers
4775 changed. Support iteration over a string. Support strings with
4776 display properties. Support unibyte strings. Fix the type of
4777 `len' according to what STRING_CHAR_AND_LENGTH expects.
4778 (bidi_paragraph_init, bidi_resolve_explicit_1)
4779 (bidi_resolve_explicit, bidi_resolve_weak)
4780 (bidi_level_of_next_char, bidi_move_to_visually_next):
4781 Support iteration over a string.
4782 (bidi_set_sor_type, bidi_resolve_explicit_1)
4783 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4784 can now be zero (for strings); special values 0 and -1 were
4785 changed to -1 and -2, respectively.
4786 (bidi_char_at_pos): New function.
4787 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4788 Call it instead of FETCH_MULTIBYTE_CHAR.
4789 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4790 initialized to valid values.
4791 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4793 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4794 the test for valid cached positions. Fix the logic for looking up
4795 the sentinel state in the cache. GCPRO the Lisp string we are
4797 (bidi_push_it, bidi_pop_it): New functions.
4798 (bidi_initialize): Initialize the bidi cache start stack pointer.
4799 (bidi_cache_ensure_space): New function, refactored from part of
4800 bidi_cache_iterator_state. Don't assume the required size is just
4801 one BIDI_CACHE_CHUNK away.
4802 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4803 (bidi_count_bytes, bidi_char_at_pos): New functions.
4804 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4805 always valid if bidi_cache_idx is valid.
4806 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4807 is valid if it's going to be used.
4808 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4809 (bidi_cache_fetch_state, bidi_cache_search)
4810 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4811 (bidi_cache_iterator_state, bidi_cache_find)
4812 (bidi_find_other_level_edge, bidi_cache_start_stack):
4813 All variables related to cache indices are now EMACS_INT.
4815 * dispextern.h (struct bidi_string_data): New structure.
4816 (struct bidi_it): New member `string'. Make flag members be 1-bit
4817 fields, and put them last in the struct.
4818 (compute_display_string_pos, compute_display_string_end):
4820 (bidi_push_it, bidi_pop_it): Add prototypes.
4821 (struct iterator_stack_entry): New members bidi_p,
4822 paragraph_embedding, and from_disp_prop_p.
4823 (struct it): Member bidi_p is now a bit field 1 bit wide.
4824 (bidi_shelve_cache, bidi_unshelve_cache):
4827 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4828 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4829 and vector-like objects.
4831 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4832 cache around display iteration.
4834 * window.c (Fwindow_end, window_scroll_pixel_based)
4835 (displayed_window_lines, Frecenter): Save and restore the bidi
4836 cache around display iteration.
4838 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4840 * editfns.c (Fdelete_region): Clarify the use of the named
4841 parameters (bug#6788).
4843 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4845 * indent.c (Fvertical_motion): Set and restore w->pointm when
4846 saving and restoring the window's buffer (Bug#9006).
4848 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4850 * editfns.c (Fstring_to_char): Clarify just what is returned
4851 (bug#6576). Text by Eli Zaretskii.
4853 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4855 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4857 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4859 * buffer.c (mmap_find): Fix a typo.
4861 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4863 Fix execution of x selection hooks.
4864 * xselect.c (Qx_lost_selection_functions)
4865 (Qx_sent_selection_functions): New vars.
4866 (syms_of_xselect): DEFSYM them.
4867 (x_handle_selection_request): Pass Qx_sent_selection_functions
4868 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4869 (x_handle_selection_clear,x_clear_frame_selections):
4870 Pass Qx_lost_selection_functions rather than
4871 Vx_lost_selection_functions to Frun_hook_with_args.
4873 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4875 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4876 The old code sometimes used this field without initializing it.
4878 * alloc.c (gc_sweep): Don't read past end of array.
4879 In theory, the old code could also have corrupted Emacs internals,
4880 though it'd be very unlikely.
4882 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4884 * character.c (Fcharacterp): Don't advertise optional ignored
4885 argument. (Bug#4026)
4887 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4889 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4892 * window.c (Fset_window_start): Doc fix (bug#4199).
4893 (Fset_window_hscroll): Ditto.
4895 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4897 Fix minor new problems caught by GCC 4.6.1.
4898 * term.c (init_tty): Remove unused local.
4899 * xsettings.c (store_monospaced_changed): Define this function only
4900 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4903 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4905 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4907 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4909 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4910 are the mini-buffer and the echo area (bug#3320).
4912 * term.c (init_tty): Remove support for supdup, c10 and perq
4913 terminals, which are no longer supported (bug#1482).
4915 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4917 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4919 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4921 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4922 for non-popups (Bug#3642).
4924 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4926 * alloc.c (reset_malloc_hooks): Protoize.
4927 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4928 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4929 * cm.c (losecursor): Likewise.
4930 * data.c (fmod): Likewise.
4931 * dispnew.c (swap_glyphs_in_rows): Likewise.
4932 * emacs.c (memory_warning_signal): Likewise.
4933 * floatfns.c (float_error): Likewise.
4934 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4935 (otf_open, font_otf_capability, generate_otf_features)
4936 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4938 * image.c (pbm_read_file): Likewise.
4939 * indent.c (string_display_width): Likewise.
4940 * intervals.c (check_for_interval, search_for_interval)
4941 (inc_interval_count, count_intervals, root_interval)
4942 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4943 * lread.c (defalias): Likewise.
4944 * ralloc.c (r_alloc_check): Likewise.
4945 * regex.c (set_image_of_range_1, set_image_of_range)
4946 (regex_grow_registers): Likewise.
4947 * sysdep.c (strerror): Likewise.
4948 * termcap.c (valid_filename_p, tprint, main): Likewise.
4949 * tparam.c (main): Likewise.
4950 * unexhp9k800.c (run_time_remap, save_data_space)
4951 (update_file_ptrs, read_header, write_header, calculate_checksum)
4952 (copy_file, copy_rest, display_header): Likewise.
4953 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4955 * xdisp.c (check_it): Likewise.
4956 * xfaces.c (register_color, unregister_color, unregister_colors):
4958 * xfns.c (print_fontset_result): Likewise.
4959 * xrdb.c (member, fatal, main): Likewise.
4961 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4963 Fix minor problems found by static checking (Bug#9031).
4964 * chartab.c (char_table_set_range, map_sub_char_table):
4965 Remove unused locals.
4966 (uniprop_table): Now static.
4967 * composite.c (_work_char): Remove unused static var.
4969 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4971 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4973 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4975 * gtkutil.c (qttip_cb): Remove code without function.
4977 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4979 * w32.c (pthread_sigmask): New stub.
4981 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4983 Use pthread_sigmask, not sigprocmask (Bug#9010).
4984 sigprocmask is portable only for single-threaded applications, and
4985 Emacs can be multi-threaded when it uses GTK.
4986 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4988 * callproc.c (Fcall_process):
4989 * process.c (create_process):
4990 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4991 Use pthread_sigmask, not sigprocmask.
4993 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4995 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4996 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4999 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5001 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5002 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5003 (xg_hide_tooltip): Fix comment.
5005 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5006 in registerServicesMenuSendTypes.
5007 (validRequestorForSendType): Don't check ns_return_types.
5009 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5012 2011-07-08 Jason Rumney <jasonr@gnu.org>
5014 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5015 SH_SHOW for hidden windows (Bug#5482).
5017 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5018 frame struct members of non-existent frames (Bug#6284).
5020 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5022 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5023 variable firstTime not needed on OSX >= 10.6.
5024 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5025 >= 10.5. Use setKnobProportion, setDoubleValue.
5027 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5028 (MAC_OS_X_VERSION_10_5): Define if not defined.
5029 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5030 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5031 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5033 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5034 cString and lossyCString on OSX >= 10.4
5036 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5037 sizeToFit on OSX >= 10.2.
5039 * nsimage.m (allocInitFromFile): Don't use deprecated method
5040 bestRepresentationForDevice on OSX >= 10.6.
5042 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5045 * emacs.c: Declare unexec_init_emacs_zone.
5047 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5049 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5051 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5052 on svcsMenu (Bug#8842).
5054 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5056 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5058 * nsterm.m (QUTF8_STRING): Declare.
5059 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5060 (validRequestorForSendType): Return type is (id).
5061 Change indexOfObjectIdenticalTo to indexOfObject.
5062 Check if we have local selection before returning self (Bug#8842).
5063 (writeSelectionToPasteboard): Put local selection into paste board
5064 if we have a local selection (Bug#8842).
5065 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5067 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5068 (ns_get_local_selection): Declare.
5070 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5072 * keymap.c (describe_map_tree): Don't insert a double newline at
5073 the end of the buffer (bug#1169) and return whether we inserted
5076 * callint.c (Fcall_interactively): Change "reading args" to
5077 "providing args" to try to clarify what it does (bug#1010).
5079 2011-07-07 Kenichi Handa <handa@m17n.org>
5081 * composite.c (composition_compute_stop_pos): Ignore a static
5082 composition starting before CHARPOS (Bug#8915).
5084 * xdisp.c (handle_composition_prop): Likewise.
5086 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5088 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5091 2011-07-07 Kenichi Handa <handa@m17n.org>
5093 * character.h (unicode_category_t): New enum type.
5095 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5096 (Qchar_code_property_table): New variable.
5097 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5098 (UNIPROP_COMPRESSED_FORM_P): New macros.
5099 (char_table_ascii): Uncompress the compressed values.
5100 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5101 Uncompress the compressed values.
5102 (sub_char_table_ref_and_range): Likewise.
5103 (char_table_ref_and_range): Uncompress the compressed values.
5104 (sub_char_table_set): New arg is_uniprop. Callers changed.
5105 Uncompress the compressed values.
5106 (sub_char_table_set_range): Args changed. Callers changed.
5107 (char_table_set_range): Adjuted for the above change.
5108 (map_sub_char_table): Delete args default_val and parent. Add arg
5109 top. Give decoded values to a Lisp function.
5110 (map_char_table): Adjust for the above change. Give decoded
5111 values to a Lisp function. Gcpro more variables.
5112 (uniprop_table_uncompress)
5113 (uniprop_decode_value_run_length): New functions.
5114 (uniprop_decoder, uniprop_decoder_count): New variables.
5115 (uniprop_get_decoder, uniprop_encode_value_character)
5116 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
5118 (uniprop_encoder, uniprop_encoder_count): New variables.
5119 (uniprop_get_encoder, uniprop_table)
5120 (Funicode_property_table_internal, Fget_unicode_property_internal)
5121 (Fput_unicode_property_internal): New functions.
5122 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5123 Sunicode_property_table_internal, Sget_unicode_property_internal,
5124 and Sput_unicode_property_internal. Defvar_lisp
5125 char-code-property-alist.
5127 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5128 Vunicode_category_table.
5130 * font.c (font_range): Adjust for the change of
5131 Vunicode_category_table.
5133 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5135 * m/iris4d.h: Remove file, move contents ...
5136 * s/irix6-5.h: ... here.
5138 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5140 Remove unportable assumption about struct layout (Bug#8884).
5141 * alloc.c (mark_buffer):
5142 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5143 (clone_per_buffer_values): Don't assume that
5144 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5145 This isn't true in general, and it's particularly not true
5146 if Emacs is configured with --with-wide-int.
5147 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5148 New macros, used in the buffer.c change.
5150 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5152 * xsettings.c: Use both GConf and GSettings if both are available.
5153 (store_config_changed_event): Add comment.
5154 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5155 (store_tool_bar_style_changed): New functions.
5156 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5157 (struct xsettings): Move font inside HAVE_XFT.
5158 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5159 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5160 Move inside HAVE_XFT.
5161 (something_changed_gsettingsCB): Rename from something_changedCB.
5162 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5164 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5165 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5166 (something_changed_gconfCB): Rename from something_changedCB.
5167 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5168 (parse_settings): Move check for font inside HAVE_XFT.
5169 (read_settings, apply_xft_settings): Add comment.
5170 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5171 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5172 call store_font_name_changed.
5173 (xft_settings_event): Add comment.
5174 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5175 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5176 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5177 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5178 (xsettings_initialize): Call init_gsettings last.
5179 (xsettings_get_system_font, xsettings_get_system_normal_font):
5182 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5184 Random fixes. E.g., (random) never returned negative values.
5185 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5186 subseconds part to the entropy, as that's a bit more random.
5187 Prefer signed to unsigned, since the signedness doesn't matter and
5188 in general we prefer signed. When given a limit, use a
5189 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5190 latter isn't right if USE_2_TAGS_FOR_INTS.
5191 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5192 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5194 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5196 * textprop.c (text_property_stickiness):
5197 Obey Vtext_property_default_nonsticky.
5198 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5199 * w32fns.c (syms_of_w32fns):
5200 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5202 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5204 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5205 This is more efficient than Ffile_directory_p and avoids a minor race.
5207 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5209 * buffer.c (Foverlay_put): Say what the return value is
5212 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5213 is a directory before asking whether to use the file name
5215 (barf_or_query_if_file_exists): Make the "File is a directory"
5216 error be more correct.
5218 * fns.c (Frequire): Remove the mention of the .gz files, since
5219 that's installation-specific, but keep the mention of
5220 `get-load-suffixes'.
5222 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5224 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5225 Report string overflow if the output is too long.
5227 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5229 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5230 (syms_of_gnutls): Remove duplicate DEFSYM for
5231 Qgnutls_bootprop_verify_hostname_error, an error for
5232 Qgnutls_bootprop_verify_error (which is no longer used).
5234 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5235 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5236 Also (re)move comments that are misplaced or no longer relevant.
5238 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5240 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5242 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5244 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5245 and background color parameters if they have been changed.
5247 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5249 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5251 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5253 * xsettings.c (SYSTEM_FONT): Define only when used.
5254 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5256 * keymap.c (access_keymap_1): Now static.
5258 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5260 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5261 leave any prefix arg for the up event (Bug#1586).
5263 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5265 * lread.c (syms_of_lread): Mention single symbols defined by
5266 `defvar' or `defconst' (bug#7154).
5268 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5269 (Frequire): Mention get-load-suffixes.
5271 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5273 * window.h (window): Remove clone_number slot.
5274 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5276 (make_parent_window, make_window, saved_window)
5277 (Fset_window_configuration, save_window_save): Don't deal with
5279 * buffer.c (Qclone_number): Remove declaration.
5280 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5282 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5284 Add multiple inheritance to keymaps.
5285 * keymap.c (Fmake_composed_keymap): New function.
5286 (Fset_keymap_parent): Simplify.
5287 (fix_submap_inheritance): Remove.
5288 (access_keymap_1): New function extracted from access_keymap to handle
5289 embedded parents and handle lists of maps.
5290 (access_keymap): Use it.
5291 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5292 (Fcopy_keymap): Handle embedded parents.
5293 (Fcommand_remapping, define_as_prefix): Simplify.
5294 (Fkey_binding): Simplify.
5295 (syms_of_keymap): Move minibuffer-local-completion-map,
5296 minibuffer-local-filename-completion-map,
5297 minibuffer-local-must-match-map, and
5298 minibuffer-local-filename-must-match-map to Elisp.
5299 (syms_of_keymap): Defsubr make-composed-keymap.
5300 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5301 (parse_menu_item): Trivial simplification.
5303 2011-07-01 Glenn Morris <rgm@gnu.org>
5305 * Makefile.in (SETTINGS_LIBS): Fix typo.
5307 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5309 * coding.c (Fencode_coding_string): Record the last coding system
5310 used, as the function doc string says (bug#8738).
5312 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5314 * xsettings.c (store_monospaced_changed): Take new font as arg and
5315 check for change against current_mono_font.
5316 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5317 (emacs_settings_constructor, emacs_settings_get_property)
5318 (emacs_settings_set_property, emacs_settings_class_init)
5319 (emacs_settings_init, gsettings_obj): Remove.
5320 (something_changedCB): New function for HAVE_GSETTINGS.
5321 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5322 with value as argument.
5323 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5324 g_settings_new (Bug#8967). Do not create gsettings_obj.
5325 Remove calls to g_settings_bind. Connect something_changedCB to
5328 * xgselect.c: Add defined (HAVE_GSETTINGS).
5329 (xgselect_initialize): Ditto.
5331 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5332 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5335 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5337 * eval.c (struct backtrace): Simplify and port the data structure.
5338 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5339 signed bit field, as this assumption is not portable and it makes
5340 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5341 "char debug_on_exit : 1" as this is not portable either; instead,
5342 use the portable "unsigned int debug_on_exit : 1". Remove unused
5343 member evalargs. Remove obsolete comments about cc bombing out.
5345 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5347 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5348 Let HAVE_GSETTINGS override HAVE_GCONF.
5349 (store_monospaced_changed): New function.
5350 (EMACS_SETTINGS): A new type derived from GObject to handle
5351 GSettings notifications.
5352 (emacs_settings_constructor, emacs_settings_get_property)
5353 (emacs_settings_set_property, emacs_settings_class_init):
5355 (gsettings_client, gsettings_obj): New variables.
5356 (GSETTINGS_SCHEMA): New define.
5357 (something_changedCB): Call store_monospaced_changed.
5358 (init_gsettings): New function.
5359 (xsettings_initialize): Call init_gsettings.
5360 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5363 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5366 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5368 * window.c (resize_root_window, grow_mini_window)
5369 (shrink_mini_window): Rename Qresize_root_window to
5370 Qwindow_resize_root_window and Qresize_root_window_vertically to
5371 Qwindow_resize_root_window_vertically.
5373 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5375 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5377 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5379 * makefile.w32-in: Redesign dependencies so they reflect more
5380 clearly which files are directly included by each source file,
5381 and not through other includes.
5383 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5385 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5386 (sort_overlays, overlay_strings): When an overlay's clone number
5387 matches the window's clone number process the overlay even if
5388 the overlay's window property doesn't match the current window.
5390 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5391 (Fwindow_hchild): Rename to Fwindow_left_child.
5392 (Fwindow_next): Rename to Fwindow_next_sibling.
5393 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5394 (resize_window_check): Rename to window_resize_check.
5395 (resize_window_apply): Rename to window_resize_apply.
5396 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5397 (Fdelete_other_windows_internal, resize_frame_windows)
5398 (Fsplit_window_internal, Fdelete_window_internal)
5399 (grow_mini_window, shrink_mini_window)
5400 (Fresize_mini_window_internal): Fix callers accordingly.
5402 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5404 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5405 (emacs_fixed_set_min_size): Remove.
5406 (emacs_fixed_new): Take frame as argument.
5408 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5409 (_EmacsFixedPrivate): Remove minwidth/height.
5410 Add struct frame *f.
5411 (emacs_fixed_init): Initialize priv->f.
5412 (get_parent_class, emacs_fixed_set_min_size): Remove.
5413 (emacs_fixed_new): Set priv->f to argument.
5414 (emacs_fixed_get_preferred_width)
5415 (emacs_fixed_get_preferred_height): Use min_width/height from
5416 frames size_hint to set minimum and natural (Bug#8919).
5417 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5418 and use min_width/height from frames size_hint to set
5419 min_width/height (Bug#8919).
5421 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5422 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5425 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5427 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5428 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5431 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5433 * process.c (wait_reading_process_output): Bypass select if
5434 waiting for a cell while ignoring keyboard input, and input is
5435 pending. Suggested by Jan Djärv (Bug#8869).
5437 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5439 Use gnulib's dup2 module instead of rolling our own.
5440 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5442 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5444 * dispnew.c (scrolling_window): Before scrolling, turn off a
5445 mouse-highlight in the window being scrolled.
5447 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5449 Move DEFSYM to lisp.h and use everywhere.
5451 * character.h (DEFSYM): Move declaration...
5452 * lisp.h (DEFSYM): ...here.
5458 * w32select.c: Don't include character.h.
5460 * alloc.c (syms_of_alloc):
5461 * buffer.c (syms_of_buffer):
5462 * bytecode.c (syms_of_bytecode):
5463 * callint.c (syms_of_callint):
5464 * casefiddle.c (syms_of_casefiddle):
5465 * casetab.c (init_casetab_once):
5466 * category.c (init_category_once, syms_of_category):
5467 * ccl.c (syms_of_ccl):
5468 * cmds.c (syms_of_cmds):
5469 * composite.c (syms_of_composite):
5470 * dbusbind.c (syms_of_dbusbind):
5471 * dired.c (syms_of_dired):
5472 * dispnew.c (syms_of_display):
5473 * doc.c (syms_of_doc):
5474 * editfns.c (syms_of_editfns):
5475 * emacs.c (syms_of_emacs):
5476 * eval.c (syms_of_eval):
5477 * fileio.c (syms_of_fileio):
5478 * fns.c (syms_of_fns):
5479 * frame.c (syms_of_frame):
5480 * fringe.c (syms_of_fringe):
5481 * insdel.c (syms_of_insdel):
5482 * keymap.c (syms_of_keymap):
5483 * lread.c (init_obarray, syms_of_lread):
5484 * macros.c (syms_of_macros):
5485 * msdos.c (syms_of_msdos):
5486 * print.c (syms_of_print):
5487 * process.c (syms_of_process):
5488 * search.c (syms_of_search):
5489 * sound.c (syms_of_sound):
5490 * syntax.c (init_syntax_once, syms_of_syntax):
5491 * terminal.c (syms_of_terminal):
5492 * textprop.c (syms_of_textprop):
5493 * undo.c (syms_of_undo):
5494 * w32.c (globals_of_w32):
5495 * window.c (syms_of_window):
5496 * xdisp.c (syms_of_xdisp):
5497 * xfaces.c (syms_of_xfaces):
5498 * xfns.c (syms_of_xfns):
5499 * xmenu.c (syms_of_xmenu):
5500 * xsettings.c (syms_of_xsettings):
5501 * xterm.c (syms_of_xterm): Use DEFSYM.
5503 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5505 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5507 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5509 Integer and buffer overflow fixes (Bug#8873).
5511 * print.c (printchar, strout): Check for string overflow.
5512 (PRINTPREPARE, printchar, strout):
5513 Don't set size unless allocation succeeds.
5515 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5516 for sizes. Check for string overflow more accurately.
5517 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5519 * macros.c: Integer and buffer overflow fixes.
5520 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5521 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5522 Use ptrdiff_t, not int, for sizes.
5523 Don't increment bufsize until after realloc succeeds.
5524 Check for size-calculation overflow.
5525 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5527 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5529 * lread.c: Integer overflow fixes.
5530 (read_integer): Radix is now EMACS_INT, not int,
5531 to improve quality of diagnostics for out-of-range radices.
5532 Calculate buffer size correctly for out-of-range radices.
5533 (read1): Check for integer overflow in radices, and in
5534 read-circle numbers.
5535 (read_escape): Avoid int overflow.
5536 (Fload, openp, read_buffer_size, read1)
5537 (substitute_object_recurse, read_vector, read_list, map_obarray):
5538 Use ptrdiff_t, not int, for sizes.
5539 (read1): Use EMACS_INT, not int, for sizes.
5540 Check for size overflow.
5542 * image.c (cache_image): Check for size arithmetic overflow.
5544 * lread.c: Integer overflow issues.
5545 (saved_doc_string_size, saved_doc_string_length)
5546 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5547 Now ptrdiff_t, not int.
5548 (read1): Don't assume doc string length fits in int. Check for
5549 out-of-range doc string lengths.
5550 (read_list): Don't assume file position fits in int.
5551 (read_escape): Check for hex character overflow.
5553 2011-06-22 Leo Liu <sdl.web@gmail.com>
5555 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5556 Move to minibuffer.el.
5558 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5560 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5561 The following patches are for when GLYPH_DEBUG && !XASSERT.
5562 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5563 * dispnew.c (flush_stdout):
5564 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5565 Mark as externally visible.
5566 * dispnew.c (check_window_matrix_pointers): Now static.
5567 * dispnew.c (window_to_frame_vpos):
5568 * xfns.c (unwind_create_frame):
5569 * xterm.c (x_check_font): Remove unused local.
5570 * scroll.c (CHECK_BOUNDS):
5571 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5572 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5573 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5574 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5575 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5577 (debug_method_add): Use va_list and vsprintf rather than relying
5578 on undefined behavior with wrong number of arguments.
5579 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5580 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5581 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5582 since we're not interested in debugging glyphs with old libraries.
5583 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5584 GCC 4.6.0's static checking.
5586 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5588 Integer overflow and signedness fixes (Bug#8873).
5589 A few related buffer overrun fixes, too.
5591 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5593 * dispextern.h (struct face.stipple):
5594 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5595 (x_bitmap_mask, x_allocate_bitmap_record)
5596 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5597 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5598 (x_create_bitmap_from_xpm_data):
5599 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5600 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5602 * xfaces.c (load_pixmap):
5603 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5604 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5605 (.bitmaps_last, struct x_output.icon_bitmap):
5606 Use ptrdiff_t, not int, for bitmap indexes.
5607 (x_allocate_bitmap_record): Check for size overflow.
5608 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5610 Use ptrdiff_t, not int, for overlay counts.
5611 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5612 * editfns.c (overlays_around, get_pos_property):
5613 * textprop.c (get_char_property_and_overlay):
5614 * xdisp.c (next_overlay_change, note_mouse_highlight):
5615 * xfaces.c (face_at_buffer_position):
5616 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5617 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5618 (Fnext_overlay_change, Fprevious_overlay_change)
5619 (mouse_face_overlay_overlaps, Foverlays_in):
5620 Use ptrdiff_t, not int, for sizes.
5621 (overlays_at, overlays_in): Check for size-calculation overflow.
5623 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5625 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5626 (x_session_initialize): Do not assume string length fits in int.
5628 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5629 This is unlikely, but can occur if DPI is outlandish.
5631 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5632 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5634 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5635 * xrdb.c (magic_file_p, search_magic_path):
5636 Omit last arg SUFFIX; it was always 0. All callers changed.
5637 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5639 * xfont.c (xfont_match): Avoid need for strlen.
5641 * xfns.c: Don't assume strlen fits in int.
5642 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5644 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5645 not unsigned long, as we prefer signed integers. All callers changed.
5646 Detect integer overflow in repeat count.
5647 (message_dolog): Don't assume print length fits in 39 bytes.
5648 (display_mode_element): Don't assume strlen fits in int.
5650 * termcap.c: Don't assume sizes fit in int and never overflow.
5651 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5652 (gobble_line): Check for size-calculation overflow.
5654 * minibuf.c (Fread_buffer):
5655 * lread.c (intern, intern_c_string):
5656 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5657 Don't assume string length fits in int.
5659 * keyboard.c (parse_tool_bar_item):
5660 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5662 * font.c: Don't assume string length fits in int.
5663 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5664 Use ptrdiff_t, not int.
5665 (font_intern_prop): Don't assume string length fits in int.
5666 Don't assume integer property fits in fixnum.
5667 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5669 * filelock.c: Fix some buffer overrun and integer overflow issues.
5670 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5671 Reformulate so as not to need the command string.
5672 Invoke gzip -cd rather than gunzip, as it's more portable.
5673 (lock_info_type, lock_file_1, lock_file):
5674 Don't assume pid_t and time_t fit in unsigned long.
5675 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5676 (current_lock_owner): Prefer signed type for sizes.
5677 Use memcpy, not strncpy, where memcpy is what is really wanted.
5678 Don't assume (via atoi) that time_t and pid_t fit in int.
5679 Check for time_t and/or pid_t out of range, e.g., via a network share.
5680 Don't alloca where an auto var works fine.
5682 * fileio.c: Fix some integer overflow issues.
5683 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5684 Don't assume string length fits in int.
5685 (directory_file_name): Don't assume string length fits in long.
5686 (make_temp_name): Don't assume pid fits in int, or that its print
5687 length is less than 20.
5689 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5691 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5693 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5695 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5696 We prefer signed integers, even for size calculations.
5698 * emacs.c: Don't assume string length fits in 'int'.
5699 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5700 (main): Don't invoke strlen when not needed.
5702 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5703 (XD_DEBUG_MESSAGE): Don't waste a byte.
5705 * callproc.c (getenv_internal_1, getenv_internal)
5707 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5709 * lread.c (invalid_syntax): Omit length argument.
5710 All uses changed. This doesn't fix a bug, but it simplifies the
5711 code away from its former Hollerith-constant appearance, and it's
5712 one less 'int' to worry about when looking at integer-overflow issues.
5713 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5715 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5716 This didn't break anything, but it didn't help either.
5717 It's confusing to put a bogus integer in a place where the actual
5718 value does not matter.
5719 (LIST_END_P): Remove unused macro and its bogus comment.
5720 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5722 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5723 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5725 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5726 We prefer signed types, and the value cannot exceed the EMACS_INT
5727 range anyway (because otherwise the length would not be representable).
5728 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5729 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5730 This avoids a GCC warning when WIDE_EMACS_INT.
5732 * indent.c (sane_tab_width): New function.
5733 (current_column, scan_for_column, Findent_to, position_indentation)
5734 (compute_motion): Use it. This is just for clarity.
5735 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5737 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5739 * lisp.h (lint_assume): New macro.
5740 * composite.c (composition_gstring_put_cache):
5741 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5743 * editfns.c, insdel.c:
5744 Omit unnecessary forward decls, to simplify future changes.
5746 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5748 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5750 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5751 Use much-faster test for byte-length change.
5752 Don't assume string byte-length fits in 'int'.
5753 Check that character arg fits in 'int'.
5754 (mapcar1): Declare byte as byte, for clarity.
5756 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5758 * fns.c (concat): Catch string overflow earlier.
5759 Do not rely on integer wraparound.
5761 * dispextern.h (struct it.overlay_strings_charpos)
5762 (struct it.selective): Now EMACS_INT, not int.
5763 * xdisp.c (forward_to_next_line_start)
5764 (back_to_previous_visible_line_start)
5765 (reseat_at_next_visible_line_start, next_element_from_buffer):
5766 Don't arbitrarily truncate the value of 'selective' to int.
5768 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5770 * composite.c: Don't truncate sizes to 'int'.
5771 (composition_gstring_p, composition_reseat_it)
5772 (composition_adjust_point): Use EMACS_INT, not int.
5773 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5774 not EMACS_UINT, for indexes.
5776 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5778 * buffer.c: Include <verify.h>.
5779 (struct sortvec.priority, struct sortstr.priority):
5780 Now EMACS_INT, not int.
5781 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5782 (struct sortstr.size, record_overlay_string)
5783 (struct sortstrlist.size, struct sortlist.used):
5784 Don't truncate size to int.
5785 (record_overlay_string): Check for size-calculation overflow.
5786 (init_buffer_once): Check at compile-time, not run-time.
5788 2011-06-22 Jim Meyering <meyering@redhat.com>
5790 Don't leak an XBM-image-sized buffer
5791 * image.c (xbm_load): Free the image buffer after using it.
5793 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5796 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5797 that Sun C diagnosed.
5798 * fns.c (secure_hash): Fix pointer signedness issue.
5799 * intervals.c (static_offset_intervals): New function.
5800 (offset_intervals): Use it.
5802 2011-06-21 Leo Liu <sdl.web@gmail.com>
5805 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5808 * fns.c (secure_hash): Rename from crypto_hash_function and change
5809 the first arg to accept symbols.
5810 (Fsecure_hash): New primitive.
5811 (syms_of_fns): New symbols.
5813 2011-06-20 Deniz Dogan <deniz@dogan.se>
5815 * process.c (Fset_process_buffer): Clarify return value in
5818 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5820 * dispnew.c (add_window_display_history): Use BVAR.
5822 * xdisp.c (debug_method_add): Use BVAR.
5823 (check_window_end, dump_glyph_matrix, dump_glyph)
5824 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5826 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5829 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5830 check till after the cache is created in init_frame_faces.
5832 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5834 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5836 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5838 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5839 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5840 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5842 Improve buffer-overflow checking (Bug#8873).
5843 * fileio.c (Finsert_file_contents):
5844 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5845 Remove the old (too-loose) buffer overflow checks.
5846 They weren't needed, since make_gap checks for buffer overflow.
5847 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5848 The old code merely checked for Emacs fixnum overflow, and relied
5849 on undefined (wraparound) behavior. The new code avoids undefined
5850 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5852 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5853 Tune. Don't use wider integers than needed. Don't use alloca.
5854 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5856 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5858 * insdel.c, lisp.h (buffer_overflow): New function.
5859 (insert_from_buffer_1, replace_range, replace_range_2):
5860 * insdel.c (make_gap_larger):
5861 * editfns.c (Finsert_char):
5862 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5864 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5866 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5868 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5870 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5871 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5873 * fileio.c: Don't assume EMACS_INT fits in off_t.
5874 (emacs_lseek): New static function.
5875 (Finsert_file_contents, Fwrite_region): Use it.
5876 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5878 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5880 * fns.c: Don't overflow int when computing a list length.
5881 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5882 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5883 truncation on 64-bit hosts. Check for QUIT every
5884 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5885 faster and is responsive enough.
5886 (Flength): Report an error instead of overflowing an integer.
5887 (Fsafe_length): Return a float if the value is not representable
5888 as a fixnum. This shouldn't happen except in contrived situations.
5889 (Fnthcdr, Fsort): Don't assume list length fits in int.
5890 (Fcopy_sequence): Don't assume vector length fits in int.
5892 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5893 (header_size, word_size): New constants.
5894 (allocate_vectorlike): Don't check size overflow here.
5895 (allocate_vector): Check it here instead, since this is the only
5896 caller of allocate_vectorlike that could cause overflow.
5897 Check that the new vector's length is representable as a fixnum.
5899 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5900 The previous code was bogus. For example, next_almost_prime (32)
5901 returned 39, which is undesirable as it is a multiple of 3; and
5902 next_almost_prime (24) returned 25, which is a multiple of 5 so
5903 why was the code bothering to check for multiples of 7?
5905 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5907 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5909 Variadic C functions now count arguments with ptrdiff_t.
5910 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5911 Back then I didn't know that the Emacs coding style prefers signed int.
5912 Also, in the meantime I found a few more instances where arguments
5913 were being counted with int, which may truncate counts on 64-bit
5914 machines, or EMACS_INT, which may be unnecessarily wide.
5915 * lisp.h (struct Lisp_Subr.function.aMANY)
5916 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5917 Arg counts are now ptrdiff_t, not size_t.
5918 All variadic functions and their callers changed accordingly.
5919 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5920 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5921 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5922 * callint.c (Fcall_interactively): Check arg count for overflow,
5923 to avoid potential buffer overrun. Use signed char, not 'int',
5924 for 'varies' array, so that we needn't bother to check its size
5925 calculation for overflow.
5926 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5927 * eval.c (apply_lambda):
5928 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5929 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5930 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5932 * callint.c (Fcall_interactively): Don't use index var as event count.
5934 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5935 * mem-limits.h (SIZE): Remove; no longer used.
5937 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5939 Remove unnecessary casts.
5940 * xterm.c (x_term_init):
5941 * xfns.c (x_set_border_pixel):
5942 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5943 These aren't needed now that we assume ANSI C.
5945 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5946 It's more likely to cause problems (due to unsigned overflow)
5949 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5951 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5953 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5955 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5957 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5959 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5961 GLYPH_CODE_FACE returns EMACS_INT, not int.
5962 * dispextern.h (merge_faces):
5963 * xfaces.c (merge_faces):
5964 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5965 Don't assume EMACS_INT fits in int.
5967 * character.h (CHAR_VALID_P): Remove unused parameter.
5968 * fontset.c, lisp.h, xdisp.c: All uses changed.
5970 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5972 * fns.c (concat): Minor tuning based on overflow analysis.
5973 This doesn't fix any bugs. Use int to hold character, instead
5974 of constantly refetching from Emacs object. Use XFASTINT, not
5975 XINT, for value known to be a character. Don't bother comparing
5976 a single byte to 0400, as it's always less.
5978 * floatfns.c (Fexpt):
5979 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5981 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5984 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5986 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5987 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5988 incorrectly succeed when S was a string, because 4294967386 was
5989 truncated before it was used.
5991 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5992 Otherwise, an out-of-range integer could cause undefined behavior
5995 * composite.c: Use int, not EMACS_INT, for characters.
5996 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5997 EMACS_INT, for values that are known to be in character range.
5998 This doesn't fix any bugs but is the usual style inside Emacs and
5999 may generate better code on 32-bit machines.
6001 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6002 This is for reasons similar to the recent CHAR_STRING fix.
6003 * charset.c (Fencode_char): Check that character arg is actually
6004 a character. Pass an int to ENCODE_CHAR.
6005 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6006 wider than 'int', as a compile-time check to prevent future regressions
6009 * character.c (char_string): Remove unnecessary casts.
6011 Make sure a 64-bit char is never passed to CHAR_STRING.
6012 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6013 by silently ignoring the top 32 bits, allowing some values
6014 that were far too large to be valid characters.
6015 * character.h: Include <verify.h>.
6016 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6017 arguments are no wider than unsigned, as a compile-time check
6018 to prevent future regressions in this area.
6020 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6021 (Fsubst_char_in_region):
6023 * xdisp.c (decode_mode_spec_coding):
6024 Adjust to CHAR_STRING's new requirement.
6025 * editfns.c (Finsert_char, Fsubst_char_in_region):
6026 * fns.c (concat): Check that character args are actually
6027 characters. Without this test, these functions did the wrong
6028 thing with wildly out-of-range values on 64-bit hosts.
6030 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6031 These casts should not be needed on 32-bit hosts, either.
6032 * keyboard.c (read_char):
6033 * lread.c (Fload): Remove casts to unsigned.
6035 * lisp.h (UNSIGNED_CMP): New macro.
6036 This fixes comparison bugs on 64-bit hosts.
6037 (ASCII_CHAR_P): Use it.
6038 * casefiddle.c (casify_object):
6039 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6040 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6041 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6042 * dispextern.h (FACE_FROM_ID):
6043 * keyboard.c (read_char): Use UNSIGNED_CMP.
6045 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6046 not to EMACS_INT, to avoid GCC warning.
6048 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6050 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6051 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6052 isn't needed on 32-bit machines.
6054 * buffer.c (Fgenerate_new_buffer_name):
6055 Use EMACS_INT for count, not int.
6056 (advance_to_char_boundary): Return EMACS_INT, not int.
6058 * data.c (Qcompiled_function): Now static.
6060 * window.c (window_body_lines): Now static.
6062 * image.c (gif_load): Rename local to avoid shadowing.
6064 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6065 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6066 * alloc.c (make_save_value): Integer argument is now of type
6068 (mark_object): Use ptrdiff_t, not int.
6069 * lisp.h (pD): New macro.
6070 * print.c (print_object): Use it.
6072 * alloc.c: Use EMACS_INT, not int, to count objects.
6073 (total_conses, total_markers, total_symbols, total_vector_size)
6074 (total_free_conses, total_free_markers, total_free_symbols)
6075 (total_free_floats, total_floats, total_free_intervals)
6076 (total_intervals, total_strings, total_free_strings):
6077 Now EMACS_INT, not int. All uses changed.
6078 (Fgarbage_collect): Compute overall total using a double, so that
6079 integer overflow is less likely to be a problem. Check for overflow
6080 when converting back to an integer.
6081 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6082 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6083 These were 'int' variables that could overflow on 64-bit hosts;
6084 they were never used, so remove them instead of repairing them.
6085 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6086 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6087 Previously, this ceilinged at INT_MAX, but that doesn't work on
6089 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6091 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6092 (allocate_vectorlike): Check for ptrdiff_t overflow.
6093 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6094 when a (possibly-narrower) signed value would do just as well.
6095 We prefer using signed arithmetic, to avoid comparison confusion.
6097 * alloc.c: Catch some string size overflows that we were missing.
6098 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6099 for convenience in STRING_BYTES_MAX.
6100 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6101 The definition here is exact; the one in lisp.h was approximate.
6102 (allocate_string_data): Check for string overflow. This catches
6103 some instances we weren't catching before. Also, it catches
6104 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6105 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6106 and ptrdiff_t and EMACS_INT are both 64 bits.
6108 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6109 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6110 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6112 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6114 * alloc.c (Fmake_string): Check for out-of-range init.
6116 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
6118 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
6120 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6122 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6123 xg_get_default_scrollbar_width.
6125 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6126 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6127 (style_changed_cb): Call update_theme_scrollbar_width and call
6128 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6129 all frames (Bug#8505).
6130 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6131 Call gtk_window_set_resizable if HAVE_GTK3.
6132 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6133 and height if HAVE_GTK3 (Bug#8505).
6134 (scroll_bar_width_for_theme): New variable.
6135 (update_theme_scrollbar_width): New function.
6136 (xg_get_default_scrollbar_width): Move code to
6137 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6138 (xg_initialize): Call update_theme_scrollbar_width.
6140 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6142 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6144 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6146 * frame.c (make_frame): Call other_buffer_safely instead of
6149 * window.c (temp_output_buffer_show): Call display_buffer with
6150 second argument Vtemp_buffer_show_specifiers and reset latter
6151 immediately after the call.
6152 (Vtemp_buffer_show_specifiers): New variable.
6153 (auto_window_vscroll_p, next_screen_context_lines)
6154 (Vscroll_preserve_screen_position): Remove leading asterisks from
6157 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6159 Fix minor problems found by GCC 4.6.0 static checking.
6160 * buffer.c (Qclone_number): Remove for now, as it's unused.
6161 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6162 (record_buffer): Remove unused local.
6163 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6164 (set_frame_buffer_list): Remove; unused.
6165 * frame.h (other_visible_frames): Remove decl.
6166 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6167 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6168 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6170 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6171 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6172 Define only if HAVE_GPM.
6173 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6174 (update_hints_inhibit): Remove; never set. All uses removed.
6175 * widgetprv.h (emacsFrameClassRec): Remove decl.
6176 * window.c (delete_deletable_window): Now returns void, since it
6177 wasn't returning anything.
6178 (compare_window_configurations): Remove unused locals.
6179 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6180 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6181 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6182 the same widths as pointers. This follows up on the 2011-05-06 patch.
6183 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6184 * xterm.h: Likewise.
6185 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6187 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6189 * makefile.w32-in: Update dependencies.
6190 (LISP_H): Add lib/intprops.h.
6192 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6194 * image.c (gif_load): Add animation frame delay to the metadata.
6195 (syms_of_image): Use DEFSYM. New symbol `delay'.
6197 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6199 * window.c (delete_deletable_window): Re-add.
6200 (Fset_window_configuration): Rewrite to handle dead buffers and
6201 consequently deletable windows.
6202 (window_tree, Fwindow_tree): Remove. Supply functionality in
6204 (compare_window_configurations): Simplify code.
6206 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6208 * image.c (imagemagick_load_image): Fix type mismatch.
6209 (Fimagemagick_types): Likewise.
6211 * window.h (replace_buffer_in_windows): Declare.
6213 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6215 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6216 Qclone_number. Remove external declaration of Qdelete_window.
6217 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6219 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6220 Run Qbuffer_list_update_hook if allowed.
6221 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6222 buffer list implementation.
6223 (other_buffer_safely): New function.
6224 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6225 calls to replace_buffer_in_windows and
6226 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6228 (record_buffer): Inhibit quitting and rewrite using quittable
6229 functions. Run Qbuffer_list_update_hook if allowed.
6230 (Frecord_buffer, Funrecord_buffer): New functions.
6231 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6232 Move switch-to-buffer to window.el.
6233 (bury-buffer): Move to window.el.
6234 (Vbuffer_list_update_hook): New variable.
6236 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6239 * window.h (resize_frame_windows): Move up in code.
6240 (Fwindow_frame): Remove EXFUN.
6241 (replace_buffer_in_all_windows): Remove prototype.
6242 (replace_buffer_in_windows_safely): Add prototype.
6244 * window.c: Declare Qdelete_window static again. Move down
6245 declaration of select_count.
6246 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6247 (Fother_window): Move to window.el.
6248 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6249 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6250 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6252 (replace_buffer_in_windows): Implement by calling
6253 Qreplace_buffer_in_windows.
6254 (replace_buffer_in_all_windows): Remove with some functionality
6255 moved into replace_buffer_in_windows_safely.
6256 (replace_buffer_in_windows_safely): New function.
6257 (select_window_norecord, select_frame_norecord): Move in front
6258 of run_window_configuration_change_hook. Remove now obsolete
6260 (Fset_window_buffer): Rewrite doc-string.
6261 Call Qrecord_window_buffer.
6262 (keys_of_window): Move binding for other-window to window.el.
6264 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6266 * dispextern.h (struct image): Replace data member, whose int_val
6267 and ptr_val fields were not used by anything, with a single
6270 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6271 (gif_clear_image, gif_load, imagemagick_load_image)
6272 (gs_clear_image, gs_load): Callers changed.
6274 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6276 * buffer.h: Include <time.h>, for time_t.
6277 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6279 Fix minor problems found by static checking.
6281 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6283 Make identifiers static if they are not used in other modules.
6284 * data.c (Qcompiled_function, Qframe, Qvector):
6285 * image.c (QimageMagick, Qsvg):
6286 * minibuf.c (Qmetadata):
6287 * window.c (resize_window_check, resize_root_window): Now static.
6288 * window.h (resize_window_check, resize_root_window): Remove decls.
6290 * window.c (window_deletion_count, delete_deletable_window):
6292 (window_body_lines): Now static.
6293 (Fdelete_other_windows_internal): Mark vars as initialized.
6294 Make sure 'resize_failed' is initialized.
6295 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6296 (resize_window_apply): Remove unused local.
6297 * window.h (delete_deletable_window): Remove decl.
6299 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6300 (imagemagick_load_image): Fix pointer signedness problem by changing
6301 last arg from unsigned char * to char *. All uses changed.
6302 Also, fix a local for similar reasons.
6303 Remove unused locals. Remove locals to avoid shadowing.
6304 (fn_rsvg_handle_free): Remove; unused.
6305 (svg_load, svg_load_image): Fix pointer signedness problem.
6306 (imagemagick_load_image): Don't use garbage pointer image_wand.
6308 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6310 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6312 * image.c (gif_load): Fix omitted cast error introduced by
6315 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6317 * window.h (resize_proportionally, orig_total_lines)
6318 (orig_top_line): Remove from window structure.
6319 (set_window_height, set_window_width, change_window_heights)
6320 (Fdelete_window): Remove prototypes.
6321 (resize_frame_windows): Remove duplicate declaration.
6323 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6325 * window.h (resize_frame_windows, resize_window_check)
6326 (delete_deletable_window, resize_root_window)
6327 (resize_frame_windows): Declare prototypes.
6329 * window.c (resize_window_apply): Make definition be "static" to
6330 match the prototype.
6332 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6334 * window.c: Remove declarations of Qwindow_size_fixed,
6335 window_min_size_1, window_min_size_2, window_min_size,
6336 size_window, window_fixed_size_p, enlarge_window, delete_window.
6337 Remove static from declaration of Qdelete_window, it's
6338 temporarily needed by Fbury_buffer.
6339 (replace_window): Don't assign orig_top_line and
6341 (Fdelete_window, delete_window): Remove. Window deletion is
6342 handled by window.el.
6343 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6344 Replace Fdelete_window calls with calls to Qdelete_window.
6345 (Fdelete_other_windows): Remove. Deleting other windows is
6346 handled by window.el.
6347 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6348 handled in window.el.
6349 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6350 Window minimum sizes are handled in window.el.
6351 (shrink_windows, size_window, set_window_height)
6352 (set_window_width, change_window_heights, window_height)
6353 (window_width, CURBEG, CURSIZE, enlarge_window)
6354 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6355 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6356 handled in window.el.
6357 (make_dummy_parent): Rename to make_parent_window and give it a
6358 second argument horflag.
6359 (make_window): Don't set resize_proportionally any more.
6360 (Fsplit_window): Remove. Windows are split in window.el.
6361 (save_restore_action, save_restore_orig_size)
6362 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6363 Resize mini windows in window.el.
6364 (grow_mini_window, shrink_mini_window): Implement by calling
6365 Qresize_root_window_vertically, resize_window_check and
6366 resize_window_apply.
6367 (saved_window, Fset_window_configuration, save_window_save):
6368 Do not handle orig_top_line, orig_total_lines, and
6369 resize_proportionally.
6370 (window_min_height, window_min_width): Move to window.el.
6371 (keys_of_window): Move bindings for delete-other-windows,
6372 split-window, delete-window and enlarge-window to window.el.
6374 * buffer.c: Temporarily extern Qdelete_window.
6375 (Fbury_buffer): Temporarily call Qdelete_window instead of
6376 Fdelete_window (Fbury_buffer will move to window.el soon).
6378 * frame.c (set_menu_bar_lines_1): Remove code handling
6379 orig_top_line and orig_total_lines.
6381 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6382 set_window_height but set heights directly.
6383 (change_frame_size_1): Use resize_frame_windows.
6385 * xdisp.c (init_xdisp): Don't use set_window_height but set
6388 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6389 Use resize_frame_windows instead of change_window_heights and run
6390 run_window_configuration_change_hook.
6392 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6393 instead of change_window_heights and run
6394 run_window_configuration_change_hook.
6396 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6398 * window.c (replace_window): Rename second argument REPLACEMENT to
6399 NEW. New third argument SETFLAG. Rewrite.
6400 (delete_window, make_dummy_parent): Call replace_window with
6402 (window_list_1): Move down in code.
6403 (run_window_configuration_change_hook): Move set_buffer part
6404 before select_frame_norecord part in order to unwind correctly.
6405 Rename count1 to count.
6406 (recombine_windows, delete_deletable_window, resize_root_window)
6407 (Fdelete_other_windows_internal)
6408 (Frun_window_configuration_change_hook, make_parent_window)
6409 (resize_window_check, resize_window_apply, Fresize_window_apply)
6410 (resize_frame_windows, Fsplit_window_internal)
6411 (Fdelete_window_internal, Fresize_mini_window_internal):
6413 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6415 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6417 * window.h (window): Add some new members to window structure -
6418 normal_lines, normal_cols, new_total, new_normal, clone_number,
6419 splits, nest, prev_buffers, next_buffers.
6420 (WINDOW_TOTAL_SIZE): Move here from window.c.
6421 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6423 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6425 (make_dummy_parent): Set new members of windows structure.
6426 (make_window): Move down in code. Handle new members of window
6428 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6429 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6430 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6431 (Fset_window_prev_buffers, Fwindow_next_buffers)
6432 (Fset_window_next_buffers, Fset_window_clone_number):
6434 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6435 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6437 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6438 Argument WINDOW can be now internal window too.
6439 (Fwindow_use_time): Move up in code.
6440 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6442 (Fset_window_configuration, saved_window)
6443 (Fcurrent_window_configuration, save_window_save): Handle new
6444 members of window structure.
6445 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6446 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6447 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6448 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6449 Qget_mru_window, Qresize_root_window,
6450 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6451 Qauto_buffer_name; staticpro them.
6453 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6455 * window.c (Fwindow_total_size, Fwindow_left_column)
6456 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6457 (Fwindow_list_1): New functions.
6458 (window_box_text_cols): Replace with window_body_cols.
6459 (Fwindow_width, Fscroll_left, Fscroll_right):
6460 Use window_body_cols instead of window_box_text_cols.
6461 (delete_window, Fset_window_configuration):
6462 Call delete_all_subwindows with window as argument.
6463 (delete_all_subwindows): Take a window as argument and not a
6465 (window_loop): Remove handling of GET_LRU_WINDOW and
6467 (Fget_lru_window, Fget_largest_window): Move to window.el.
6469 * window.h: Extern window_body_cols instead of
6470 window_box_text_cols. delete_all_subwindows now takes a
6471 Lisp_Object as argument.
6473 * indent.c (compute_motion, Fcompute_motion):
6474 Use window_body_cols instead of window_box_text_cols.
6476 * frame.c (delete_frame): Call delete_all_subwindows with root
6479 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6481 * fns.c (Fputhash): Document return value.
6483 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6485 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6487 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6489 Cons<->int and similar integer overflow fixes (Bug#8794).
6491 Check for overflow when converting integer to cons and back.
6492 * charset.c (Fdefine_charset_internal, Fdecode_char):
6493 Use cons_to_unsigned to catch overflow.
6494 (Fencode_char): Use INTEGER_TO_CONS.
6495 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6496 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6497 * data.c (long_to_cons, cons_to_long): Remove.
6498 (cons_to_unsigned, cons_to_signed): New functions.
6499 These signal an error for invalid or out-of-range values.
6500 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6501 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6502 * font.c (Ffont_variation_glyphs):
6503 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6504 * lisp.h: Include <intprops.h>.
6505 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6506 (cons_to_signed, cons_to_unsigned): New decls.
6507 (long_to_cons, cons_to_long): Remove decls.
6508 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6509 (Fprimitive_undo): Use CONS_TO_INTEGER.
6510 * xfns.c (Fx_window_property): Likewise.
6511 * xselect.c: Include <limits.h>.
6512 (x_own_selection, selection_data_to_lisp_data):
6513 Use INTEGER_TO_CONS.
6514 (x_handle_selection_request, x_handle_selection_clear)
6515 (x_get_foreign_selection, Fx_disown_selection_internal)
6516 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6517 (lisp_data_to_selection_data): Use cons_to_unsigned.
6518 (x_fill_property_data): Use cons_to_signed.
6519 Report values out of range.
6521 Check for buffer and string overflow more precisely.
6522 * buffer.h (BUF_BYTES_MAX): New macro.
6523 * lisp.h (STRING_BYTES_MAX): New macro.
6524 * alloc.c (Fmake_string):
6525 * character.c (string_escape_byte8):
6526 * coding.c (coding_alloc_by_realloc):
6527 * doprnt.c (doprnt):
6528 * editfns.c (Fformat):
6530 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6531 since they may not be the same number.
6532 * editfns.c (Finsert_char):
6533 * fileio.c (Finsert_file_contents):
6534 Likewise for BUF_BYTES_MAX.
6536 * image.c: Use ptrdiff_t, not int, for sizes.
6537 (slurp_file): Switch from int to ptrdiff_t.
6539 (slurp_file): Check that file size fits in both size_t (for
6540 malloc) and ptrdiff_t (for sanity and safety).
6542 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6543 if b->modtime has its maximal value.
6545 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6547 Don't assume time_t can fit into int.
6548 * buffer.h (struct buffer.modtime): Now time_t, not int.
6549 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6550 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6552 Minor fixes for signed vs unsigned integers.
6553 * character.h (MAYBE_UNIFY_CHAR):
6554 * charset.c (maybe_unify_char):
6555 * keyboard.c (read_char, reorder_modifiers):
6556 XINT -> XFASTINT, since the integer must be nonnegative.
6557 * ftfont.c (ftfont_spec_pattern):
6558 * keymap.c (access_keymap, silly_event_symbol_error):
6559 XUINT -> XFASTINT, since the integer must be nonnegative.
6560 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6561 since it makes no difference and we prefer signed.
6562 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6563 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6566 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6568 * window.h (Fwindow_frame): Declare.
6570 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6572 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6573 (SPARE_MEMORY): Always define.
6574 (LARGE_REQUEST): Remove.
6575 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6577 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6579 * lisp.h: Move EXFUNS for Fframe_root_window,
6580 Fframe_first_window and Fset_frame_selected_window to window.h.
6582 * window.h: Move EXFUNS for Fframe_root_window,
6583 Fframe_first_window and Fset_frame_selected_window here from
6586 * frame.c (Fwindow_frame, Fframe_first_window)
6587 (Fframe_root_window, Fframe_selected_window)
6588 (Fset_frame_selected_window): Move to window.c.
6589 (Factive_minibuffer_window): Move to minibuf.c.
6590 (Fother_visible_frames_p): New function.
6592 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6594 * window.c (decode_window, decode_any_window): Move up in code.
6595 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6596 (inhibit_frame_unsplittable): Remove unused variable.
6597 (Fwindow_buffer): Move up and rewrite doc-string.
6598 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6599 (Fwindow_prev): New functions.
6600 (Fwindow_frame): Move here from frame.c. Accept any window as
6602 (Fframe_root_window, Fframe_first_window)
6603 (Fframe_selected_window): Move here from frame.c. Accept frame
6604 or arbitrary window as argument. Update doc-strings.
6605 (Fminibuffer_window): Move up in code.
6606 (Fwindow_minibuffer_p): Move up in code and simplify.
6607 (Fset_frame_selected_window): Move here from frame.c.
6609 (Fselected_window, select_window, Fselect_window): Move up in
6610 code. Minor doc-string fixes.
6612 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6614 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6615 Do not assume that spare memory exists; that assumption is valid
6616 only if SYSTEM_MALLOC.
6617 (LARGE_REQUEST): New macro, so that the issue of large requests
6618 is separated from the issue of spare memory.
6620 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6622 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6625 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6627 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6630 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6632 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6634 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6636 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6637 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6639 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6641 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6643 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6645 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6646 (x_clipboard_manager_save): Add return value.
6647 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6649 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6650 Obey Vx_select_enable_clipboard_manager. Catch errors in
6651 x_clipboard_manager_save (Bug#8779).
6652 (Vx_select_enable_clipboard_manager): New variable.
6653 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6655 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6657 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6659 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6661 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6662 in the current matrix if keep_current_p is non-zero.
6664 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6666 * bidi.c (bidi_level_of_next_char): Fix last change.
6668 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6670 Support bidi reordering of text covered by display properties.
6672 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6673 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6674 (bidi_cache_search, bidi_cache_iterator_state)
6675 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6676 (bidi_level_of_next_char, bidi_move_to_visually_next):
6677 Support character positions inside a run of characters covered by a
6679 (bidi_paragraph_init, bidi_resolve_explicit_1)
6680 (bidi_level_of_next_char): Call bidi_fetch_char and
6681 bidi_fetch_char_advance instead of FETCH_CHAR and
6683 (bidi_init_it): Initialize new members.
6684 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6686 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6687 instead of using explicit *_CHAR codes.
6688 (bidi_resolve_explicit, bidi_resolve_weak):
6689 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6690 bidirectional text is supported only in multibyte buffers.
6691 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6692 it to initialize the frame_window_p member of struct bidi_it.
6693 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6694 (bidi_resolve_explicit, bidi_resolve_weak)
6695 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6696 bidi_it->nchars is non-positive.
6697 (bidi_level_of_next_char): Don't try to lookup the cache for the
6698 next/previous character if nothing is cached there yet, or if we
6699 were just reseat()'ed to a new position.
6701 * xdisp.c (set_cursor_from_row): Set start and stop points
6702 according to the row's direction when priming the loop that looks
6703 for the glyph on which to display cursor.
6704 (single_display_spec_intangible_p): Function deleted.
6705 (display_prop_intangible_p): Reimplement to call
6706 handle_display_spec instead of single_display_spec_intangible_p.
6707 Accept 3 additional arguments needed by handle_display_spec.
6708 This fixes incorrect cursor motion across display property with complex
6709 values: lists, `(when COND...)' forms, etc.
6710 (single_display_spec_string_p): Support property values that are
6711 lists with the argument STRING its top-level element.
6712 (display_prop_string_p): Fix the condition for processing a
6713 property that is a list to be consistent with handle_display_spec.
6714 (handle_display_spec): New function, refactored from the
6715 last portion of handle_display_prop.
6716 (compute_display_string_pos): Accept additional argument
6717 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6718 value of a `display' property is a "replacing spec".
6719 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6720 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6721 the display property, but just return a value indicating whether
6722 the display property will replace the characters it covers.
6723 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6724 frame_window_p members of struct bidi_it.
6725 (compute_display_string_pos, compute_display_string_end):
6727 (push_it): Accept second argument POSITION, where pop_it should
6728 jump to continue iteration.
6729 (reseat_1): Initialize bidi_it.disp_pos.
6731 * keyboard.c (adjust_point_for_property): Adjust the call to
6732 display_prop_intangible_p to its new signature.
6734 * dispextern.h (struct bidi_it): New member frame_window_p.
6735 (bidi_init_it): Update prototypes.
6736 (display_prop_intangible_p): Update prototype.
6737 (compute_display_string_pos, compute_display_string_end):
6739 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6742 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6744 Malloc failure behavior now depends on size of allocation.
6745 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6746 * lisp.h: Change signatures accordingly.
6747 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6748 All callers changed. (Bug#8762)
6750 * gnutls.c: Use Emacs's memory allocators.
6751 Without this change, the gnutls library would invoke malloc etc.
6752 directly, which causes problems on non-SYNC_INPUT hosts, and which
6753 runs afoul of improving memory_full behavior. (Bug#8761)
6754 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6755 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6756 xfree instead of the default malloc, realloc, free.
6757 (Fgnutls_boot): No need to check for memory allocation failure,
6758 since xmalloc does that for us.
6760 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6761 * category.c (hash_get_category_set):
6762 * ccl.c (ccl_driver):
6763 * charset.c (Fdefine_charset_internal):
6764 * charset.h (struct charset.hash_index):
6765 * composite.c (get_composition_id, gstring_lookup_cache)
6766 (composition_gstring_put_cache):
6767 * composite.h (struct composition.hash_index):
6768 * dispextern.h (struct image.hash):
6769 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6770 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6771 (hashfn_equal, hashfn_user_defined, make_hash_table)
6772 (maybe_resize_hash_table, hash_lookup, hash_put)
6773 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6774 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6775 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6776 * image.c (make_image, search_image_cache, lookup_image)
6777 (xpm_put_color_table_h):
6778 * lisp.h (struct Lisp_Hash_Table):
6779 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6780 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6781 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6782 * alloc.c (allocate_vectorlike):
6783 Check for overflow in vector size calculations.
6784 * ccl.c (ccl_driver):
6785 Check for overflow when converting EMACS_INT to int.
6786 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6787 need to be updated by these changes.
6788 * fns.c (make_hash_table, maybe_resize_hash_table):
6789 Check for integer overflow with large hash tables.
6790 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6791 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6792 (SXHASH_REDUCE): New macro.
6793 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6794 Use it instead of discarding useful hash info with large hash values.
6795 (sxhash_float): New function.
6796 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6797 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6798 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6799 Rewrite to use FIXNUM_BITS, as this simplifies things.
6800 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6801 Adjust signatures to match updated version of code.
6802 (consing_since_gc): Now EMACS_INT, since a single hash table can
6803 use more than INT_MAX bytes.
6805 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6807 Make it possible to build with GCC-4.6+ -O2 -flto.
6809 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6811 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6813 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6814 Call minibuffer-inactive-mode.
6816 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6818 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6819 Update dependencies.
6821 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6823 * data.c (init_data): Remove code for UTS, this system is not
6826 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6828 Don't force ./temacs to start in terminal mode.
6830 * frame.c (make_initial_frame): Initialize faces in all cases, not
6831 only when CANNOT_DUMP is defined.
6832 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6834 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6836 * dispnew.c (add_window_display_history): Use const for the string
6837 pointer. Remove declaration, not needed.
6839 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6841 Use 'inline', not 'INLINE'.
6842 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6843 * alloc.c, fontset.c (INLINE): Remove.
6844 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6845 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6846 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6847 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6848 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6850 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6852 Make it possible to run ./temacs.
6854 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6855 syms_of_callproc does the same thing. Remove test for
6856 "initialized", do it in the caller.
6857 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6859 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6861 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6862 (read_minibuf): Use get_minibuffer.
6863 (syms_of_minibuf): Use DEFSYM.
6864 (Qmetadata): New var.
6865 * data.c (Qbuffer): Don't make it static.
6866 (syms_of_data): Use DEFSYM.
6868 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6870 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6871 (CCL_CODE_MIN): New macro.
6873 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6875 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6877 * eval.c (Qdebug): Now static.
6878 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6879 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6880 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6882 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6884 * image.c: Various fixes to ImageMagick code comments.
6885 (Fimagemagick_types): Doc fix.
6887 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6889 Minor fixes prompted by GCC 4.6.0 warnings.
6891 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6893 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6894 (x_clipboard_manager_save_all): Move extern decl to ...
6895 * xterm.h: ... here, so that it can be checked for consistency.
6897 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6899 * xselect.c (x_clipboard_manager_save_frame)
6900 (x_clipboard_manager_save_all): New functions.
6901 (Fx_clipboard_manager_save): Lisp function deleted.
6903 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6904 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6906 * xterm.h: Update prototype.
6908 2011-05-28 William Xu <william.xwl@gmail.com>
6910 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6913 2011-05-28 Jim Meyering <meyering@redhat.com>
6915 Avoid a sign-extension bug in crypto_hash_function.
6916 * fns.c (to_uchar): Define.
6917 (crypto_hash_function): Use it to convert some newly-signed
6918 variables to unsigned, to avoid sign-extension bugs. For example,
6919 without this change, (md5 "truc") would evaluate to
6920 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6921 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6922 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6924 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6926 Integer overflow fixes.
6928 * dbusbind.c: Serial number integer overflow fixes.
6929 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6930 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6931 to hold a serial number that is too large for a fixnum.
6932 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6933 Check for serial numbers out of range. Decode any serial number
6934 that was so large that it became a float. (Bug#8722)
6936 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6937 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6938 Use XFASTINT rather than XUINT when numbers are nonnegative.
6939 (xd_append_arg, Fdbus_method_return_internal):
6940 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6941 arguments, check that Lisp number is nonnegative, rather than
6942 silently wrapping negative numbers around. (Bug#8722)
6943 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6946 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6948 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6950 ccl: Add integer overflow checks.
6951 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6952 (IN_INT_RANGE): New macros.
6953 (ccl_driver): Use them to check for integer overflow when
6954 decoding a CCL program. Many of the new checks are whether XINT (x)
6955 fits in int; it doesn't always, on 64-bit hosts. The new version
6956 doesn't catch all possible integer overflows, but it's an
6957 improvement. (Bug#8719)
6959 * alloc.c (make_event_array): Use XINT, not XUINT.
6960 There's no need for unsigned here.
6962 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6963 This follows up to the 2011-05-06 change that substituted uintptr_t
6964 for EMACS_INT. This case wasn't caught back then.
6966 Rework Fformat to avoid integer overflow issues.
6967 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6968 now (part of C89). Include <verify.h>.
6969 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6970 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6971 (Fformat): Avoid the prepass trying to compute sizes; it was only
6972 approximate and thus did not catch overflow reliably. Instead, walk
6973 through the format just once, formatting and computing sizes as we go,
6974 checking for integer overflow at every step, and allocating a larger
6975 buffer as needed. Keep track separately whether the format is
6976 multibyte. Keep only the most-recently calculated precision, rather
6977 than them all. Record whether each argument has been converted to
6978 string. Use EMACS_INT, not int, for byte and char and arg counts.
6979 Support field widths and precisions larger than INT_MAX. Avoid
6980 sprintf's undefined behavior with conversion specifications such as %#d
6981 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6982 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6983 formatting out-of-range floating point numbers with int
6986 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6988 * data.c: Avoid integer truncation in expressions involving floats.
6989 * data.c: Include <intprops.h>.
6990 (arith_driver): When there's an integer overflow in an expression
6991 involving floating point, convert the integers to floating point
6992 so that the resulting value does not suffer from catastrophic
6993 integer truncation. For example, on a 64-bit host (* 4
6994 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6995 Do not rely on undefined behavior after integer overflow.
6997 merge count_size_as_multibyte, parse_str_to_multibyte
6998 * character.c, character.h (count_size_as_multibyte):
6999 Rename from parse_str_to_multibyte; all uses changed.
7000 Check for integer overflow.
7001 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7002 since it's now a duplicate of the other. This is more of
7003 a character than a buffer op, so better that it's in character.c.
7004 * fns.c, print.c: Adjust to above changes.
7006 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7008 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7010 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7012 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7013 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7014 (x_clipboard_manager_save): Now static.
7015 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7017 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7018 (crypto_hash_function): Now static.
7019 Fix pointer signedness problems. Avoid unnecessary initializations.
7021 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7023 * termhooks.h (Vselection_alist): Make it terminal-local.
7025 * terminal.c (create_terminal): Initialize it.
7027 * xselect.c: Support for clipboard managers.
7028 (Vselection_alist): Move to termhooks.h as terminal-local var.
7029 (LOCAL_SELECTION): New macro.
7030 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7031 (symbol_to_x_atom): Remove gratuitous arg.
7032 (x_handle_selection_request, lisp_data_to_selection_data)
7033 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7034 (x_own_selection, x_get_local_selection, x_convert_selection):
7035 New arg, specifying work frame. Use terminal-local Vselection_alist.
7036 (some_frame_on_display): Delete unused function.
7037 (Fx_own_selection_internal, Fx_get_selection_internal)
7038 (Fx_disown_selection_internal, Fx_selection_owner_p)
7039 (Fx_selection_exists_p): New optional frame arg.
7040 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7041 (x_handle_selection_clear): Don't treat other terminals with the
7042 same keyboard specially. Use the terminal-local Vselection_alist.
7043 (x_clear_frame_selections): Use Frun_hook_with_args.
7045 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7047 * xterm.h: Add support for those atoms.
7049 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7051 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7052 (converted_selections, conversion_fail_tag): New global variables.
7053 (x_selection_request_lisp_error): Free the above.
7054 (x_get_local_selection): Remove unnecessary code.
7055 (x_reply_selection_request): Args changed; handle arbitrary array
7056 of converted selections stored in converted_selections.
7057 Separate the XChangeProperty and SelectionNotify steps.
7058 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7059 (x_convert_selection): New function.
7060 (x_handle_selection_event): Simplify.
7061 (x_get_foreign_selection): Don't ignore incoming requests while
7062 waiting for an answer; this will fail when we implement
7063 SAVE_TARGETS, and seems unnecessary anyway.
7064 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7065 (Vx_sent_selection_functions): Doc fix.
7067 2011-05-26 Leo Liu <sdl.web@gmail.com>
7069 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7071 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7073 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7075 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7076 for fringe update if it has periodic bitmap.
7077 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7078 and fringe_bitmap_periodic_p.
7080 * fringe.c (get_fringe_bitmap_data): New function.
7081 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7082 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7083 row. Mark glyph row for fringe update if periodicity changed.
7085 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7086 for fringe update unless it has periodic bitmap.
7088 2011-05-25 Kenichi Handa <handa@m17n.org>
7090 * xdisp.c (get_next_display_element): Set correct it->face_id for
7091 a static composition.
7093 2011-05-24 Leo Liu <sdl.web@gmail.com>
7096 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7098 * fns.c (crypto_hash_function, Fsha1): New function.
7099 (Fmd5): Use crypto_hash_function.
7100 (syms_of_fns): Add Ssha1.
7102 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7104 * gnutls.c: Remove unused macros.
7105 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7106 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7107 Remove macros that are defined and never used.
7108 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7110 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7112 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7113 (Fx_get_selection_internal): Minor cleanup.
7114 (Fx_own_selection_internal): Rename arguments for consistency with
7117 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7119 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
7121 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7123 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7125 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7127 * dispnew.c (scrolling_window): Don't exclude the case that the
7128 last enabled row in the desired matrix touches the bottom boundary.
7130 2011-05-21 Glenn Morris <rgm@gnu.org>
7132 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7133 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7134 and add some more files.
7136 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7138 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7139 report_file_error introduced by the change from 2011-05-07.
7141 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7143 * systime.h (Time): Define only if emacs is defined.
7144 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7145 where the include path doesn't have X11/X.h by default. See
7146 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7148 2011-05-20 Kenichi Handa <handa@m17n.org>
7150 * composite.c (find_automatic_composition): Fix previous change.
7152 2011-05-20 Glenn Morris <rgm@gnu.org>
7154 * lisp.mk: New file, split from Makefile.in.
7155 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7156 (shortlisp): Remove.
7157 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7159 2011-05-19 Glenn Morris <rgm@gnu.org>
7161 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7162 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7163 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7164 (lisp): Set the order to that of loadup.el.
7165 (shortlisp): Make it a copy of $lisp.
7166 (SOME_MACHINE_LISP): Remove.
7167 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7168 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7170 2011-05-18 Kenichi Handa <handa@m17n.org>
7172 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7173 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7174 (find_automatic_composition): Mostly rewrite for efficiency.
7176 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7178 * makefile.w32-in: Update dependencies.
7180 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7182 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7183 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7185 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7187 Fix some integer overflow issues, such as string length overflow.
7189 * insdel.c (count_size_as_multibyte): Check for string overflow.
7191 * character.c (lisp_string_width): Check for string overflow.
7192 Use EMACS_INT, not int, for string indexes and lengths; in
7193 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7194 the resulting string length overflows an EMACS_INT; instead,
7195 report a string overflow if no precision given. When checking for
7196 precision exhaustion, use a check that cannot possibly have
7197 integer overflow. (Bug#8675)
7198 * character.h (lisp_string_width): Adjust to new signature.
7200 * alloc.c (string_overflow): New function.
7201 (Fmake_string): Use it. This doesn't change behavior, but saves
7202 a few bytes and will simplify future changes.
7203 * character.c (string_escape_byte8): Likewise.
7204 * lisp.h (string_overflow): New decl.
7206 Fixups, following up to the user-interface timestamp change.
7207 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7208 for UI timestamps, instead of unsigned long.
7209 * msdos.c (mouse_get_pos): Likewise.
7210 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7211 * w32gui.h (Time): Define by including "systime.h" rather than by
7212 declaring it ourselves. (Bug#8664)
7214 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7215 * image.c (clear_image_cache): Likewise.
7217 * term.c (term_mouse_position): Don't assume time_t wraparound.
7219 Be more systematic about user-interface timestamps.
7220 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7221 and sometimes 'EMACS_UINT', to represent these timestamps.
7222 This change causes it to use 'Time' uniformly, as that's what X uses.
7223 This makes the code easier to follow, and makes it easier to catch
7224 integer overflow bugs such as Bug#8664.
7225 * frame.c (Fmouse_position, Fmouse_pixel_position):
7226 Use Time, not unsigned long, for user-interface timestamps.
7227 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7228 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7229 * keyboard.h (last_event_timestamp): Likewise.
7230 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7231 * menu.h (xmenu_show): Likewise.
7232 * term.c (term_mouse_position): Likewise.
7233 * termhooks.h (struct input_event.timestamp): Likewise.
7234 (struct terminal.mouse_position_hook): Likewise.
7235 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7236 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7237 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7238 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7240 * menu.h, termhooks.h: Include "systime.h", for Time.
7242 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7243 Don't assume that the difference between two unsigned long values
7244 can fit into an integer. At this point, we know button_down_time
7245 <= event->timestamp, so the difference must be nonnegative, so
7246 there's no need to cast the result if double-click-time is
7247 nonnegative, as it should be; check that it's nonnegative, just in
7248 case. This bug is triggered when events are more than 2**31 ms
7249 apart (about 25 days). (Bug#8664)
7251 * xselect.c (last_event_timestamp): Remove duplicate decl.
7252 (x_own_selection): Remove needless cast to unsigned long.
7254 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7255 that always fit in int. Use a sentinel instead of a counter, to
7256 avoid a temp and to allay GCC's concerns about possible int overflow.
7257 * frame.h (struct frame): Use int for menu_bar_items_used
7258 instead of EMACS_INT, since it always fits in int.
7260 * menu.c (grow_menu_items): Check for int overflow.
7262 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7264 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7265 Before, the code was not consistent. These values cannot exceed
7266 2**31 - 1 so there's no need to make them unsigned.
7267 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7268 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7269 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7271 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7273 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7274 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7275 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7276 presumably because the widths might not match.
7278 * window.c (size_window): Avoid needless test at loop start.
7280 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7282 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7284 2011-05-12 Drew Adams <drew.adams@oracle.com>
7286 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7288 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7290 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7291 `width' to `bar_area_x' and `bar_area_width', respectively.
7292 (x_scroll_run): Take account of fringe background extension.
7294 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7295 Rename local vars `left' and `width' to `bar_area_x' and
7296 `bar_area_width', respectively.
7297 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7298 background extension.
7300 2011-05-10 Jim Meyering <meyering@redhat.com>
7302 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7304 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7306 * image.c (Finit_image_library): Return t for built-in image types,
7307 like pbm and xbm. (Bug#8640)
7309 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7311 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7313 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7315 * w32console.c (Fset_screen_color): Doc fix.
7316 (Fget_screen_color): New function.
7317 (syms_of_ntterm): Defsubr it.
7319 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7320 unlink the temporary file if Fcall_process didn't create it in the
7322 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7323 child process will be redirected to a file specified with `:file'.
7324 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7325 cue to call_process_cleanup not to close that handle.
7327 2011-05-07 Ben Key <bkey76@gmail.com>
7329 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7330 one of two shell specific rules, either bootstrap-temacs-CMD or
7331 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7332 to the previous implementation of the bootstrap-temacs rule.
7333 The bootstrap-temacs-CMD rule is similar to the previous
7334 implementation of the bootstrap-temacs rule except that it
7335 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7338 These changes, along with some changes to nt/configure.bat,
7339 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7340 earlier fix to add support for --cflags and --ldflags options
7341 that include quotes so that it works whether make uses cmd or
7344 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7346 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7347 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7349 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7350 a string. Handle both cases.
7351 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7352 (Fdbus_register_method): Use Qinvalid_function.
7354 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7356 * makefile.w32-in: Update dependencies.
7357 (LISP_H): Add inttypes.h and stdin.h.
7358 (PROCESS_H): Add unistd.h.
7360 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7362 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7363 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7365 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7367 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7369 * term.c (vfatal): Remove stray call to va_end.
7370 It's not needed and the C Standard doesn't allow it here anyway.
7372 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7373 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7375 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7378 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7380 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7382 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7384 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7386 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7388 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7389 * charset.c (Fdefine_charset_internal): Don't initialize
7390 charset.code_space[15]. The value was garbage, on hosts with
7391 32-bit int (Bug#8600).
7393 * lread.c (read_integer): Be more consistent with string-to-number.
7394 Use string_to_number to do the actual conversion; this avoids
7395 rounding errors and fixes some other screwups. Without this fix,
7396 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7397 (digit_to_number): Move earlier, for benefit of read_integer.
7398 Return -1 if the digit is out of range for the base, -2 if it is
7399 not a digit in any supported base. (Bug#8602)
7401 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7403 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7404 to match comment at start of function. This also removes a
7405 GCC warning about overflow in a 32+64-bit port.
7407 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7409 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7410 Reported by Stefan Monnier in
7411 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7412 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7413 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7415 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7416 (EMACS_UINTPTR): Likewise, with uintptr_t.
7418 * lisp.h: Prefer 64-bit EMACS_INT if available.
7419 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7420 on 32-bit hosts that have 64-bit int, so that they can access
7422 However, temporarily disable this change unless the temporary
7423 symbol WIDE_EMACS_INT is defined.
7425 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7427 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7428 This removes an assumption that EMACS_INT and long are the same
7429 width as pointers. The assumption is true for Emacs porting targets
7430 now, but we want to make other targets possible.
7431 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7432 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7433 In the rest of the code, change types of integers that hold casted
7434 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7435 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7436 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7437 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7438 No need to cast type when ORing.
7439 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7440 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7441 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7442 assume EMACS_INT is the same width as char *.
7443 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7444 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7445 Remove no-longer-needed casts.
7446 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7447 (xg_tool_bar_help_callback, xg_make_tool_item):
7448 Use EMACS_INTPTR to hold an integer
7449 that will be cast to void *; this can avoid a GCC warning
7450 if EMACS_INT is not the same width as void *.
7451 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7452 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7453 (current_message_1, set_message_1):
7454 Use a local to convert to proper width without a cast.
7455 * xmenu.c (dialog_selection_callback): Likewise.
7457 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7458 Also, don't assume VALBITS / RAND_BITS is less than 5,
7459 and don't rely on undefined behavior when shifting a 1 left into
7461 * lisp.h (get_random): Change signature to match.
7463 * lread.c (hash_string): Use size_t, not int, for hash computation.
7464 Normally we prefer signed values; but hashing is special, because
7465 it's better to use unsigned division on hash table sizes so that
7466 the remainder is nonnegative. Also, size_t is the natural width
7467 for hashing into memory. The previous code used 'int', which doesn't
7468 retain enough info to hash well into very large tables.
7469 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7471 * dbusbind.c: Don't possibly lose pointer info when converting.
7472 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7473 Use XPNTR rather than XHASH, so that the high-order bits of
7474 the pointer aren't lost when converting through void *.
7476 * eval.c (Fautoload): Don't double-shift a pointer.
7478 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7480 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7482 * gnutls.c (DEF_GNUTLS_FN):
7483 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7485 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7487 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7490 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7492 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7493 New version that can reserve upto 2GB of heap space.
7495 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7497 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7499 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7501 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7502 `gnutls_certificate_set_x509_key_file'.
7504 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7506 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7507 Update dependencies.
7509 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7511 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7512 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7513 Remove unused parameter `fildes'.
7514 * process.c (read_process_output, send_process): Don't pass it.
7516 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7518 Fix previous change: the library cache is defined in w32.c.
7519 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7520 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7522 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7524 Implement dynamic loading of GnuTLS on Windows.
7526 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7527 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7528 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7531 * gnutls.c (Qgnutls_dll): Define.
7532 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7533 (gnutls_*): Declare function pointers.
7534 (init_gnutls_functions): New function to initialize function pointers.
7535 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7536 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7537 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7538 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7539 (emacs_gnutls_write, emacs_gnutls_read)
7540 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7541 (Fgnutls_available_p): New function.
7542 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7543 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7544 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7546 * image.c: Include w32.h.
7547 (Vimage_type_cache): Delete.
7548 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7549 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7550 (w32_delayed_load): Move to w32.c.
7552 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7554 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7555 (w32_delayed_load): Move from image.c. When loading a library, record
7556 its filename in the :loaded-from property of the library id.
7557 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7558 Initialize and staticpro them.
7559 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7561 * process.c: Include lisp.h before w32.h, not after.
7562 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7563 instead of gnutls_record_check_pending.
7565 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7567 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7569 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7570 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7573 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7575 * xterm.c (x_set_frame_alpha): Do not set property on anything
7576 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7578 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7580 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7582 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7584 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7585 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7586 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7587 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7588 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7589 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7590 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7591 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7592 (Qgnutls_bootprop_callbacks_verify): Make static.
7594 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7596 * callproc.c: Indentation fixup.
7598 * sysdep.c (wait_for_termination_1): Make static.
7599 (wait_for_termination, interruptible_wait_for_termination):
7600 Move after wait_for_termination_1.
7602 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7604 * sysdep.c (interruptible_wait_for_termination): New function
7605 which is like wait_for_termination, but allows keyboard
7608 * callproc.c (Fcall_process): Add (:file "file") as an option for
7610 (Fcall_process_region): Ditto.
7612 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7614 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7615 rather than `XVECTOR (FOO)->size'.
7617 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7618 inttypes.h, as a gnulib replacement is used if it not available in
7621 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7623 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7624 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7625 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7627 * coding.c (coding_alloc_by_realloc): Error out if destination
7628 will grow beyond MOST_POSITIVE_FIXNUM.
7629 (decode_coding_emacs_mule): Abort if there isn't enough place in
7630 charbuf for the composition carryover bytes. Reserve an extra
7631 space for up to 2 characters produced in a loop.
7632 (decode_coding_iso_2022): Abort if there isn't enough place in
7633 charbuf for the composition carryover bytes.
7635 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7637 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7638 aborting when %lld or %lll format is passed.
7639 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7640 %llo or %llx format is passed. (Bug#8545)
7642 * window.c (window_scroll_line_based): Use a marker instead of
7643 simple variables to record original value of point. (Bug#7952)
7645 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7646 produced by %s or %c overflows available buffer space. (Bug#8545)
7648 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7650 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7651 (SIZE_MAX): Move defn after all includes, as they might #define it.
7653 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7655 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7657 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7659 * keyboard.c (Qdelayed_warnings_hook): Define.
7660 (command_loop_1): Run `delayed-warnings-hook'
7661 if Vdelayed_warnings_list is non-nil.
7662 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7663 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7665 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7667 * doprnt.c (doprnt): Don't return value smaller than the buffer
7668 size if the message was truncated. (Bug#8545).
7670 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7672 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7673 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7675 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7677 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7679 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7681 * makefile.w32-in: Update dependencies.
7683 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7685 Improve `doprnt' and its usage. (Bug#8545)
7686 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7687 `format_end'. Remove support for %l as a conversion specifier.
7688 Don't use xrealloc. Improve diagnostics when the %l size modifier
7689 is used. Update the commentary.
7691 * eval.c (verror): Simplify calculation of size_t.
7693 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7696 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7698 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7701 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7703 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7704 This makes this file independent of the recent pseudovector change.
7706 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7708 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7710 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7711 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7712 Remove unused local.
7713 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7715 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7716 GCC 4.6.0 optimizes based on type-based alias analysis.
7717 For example, if b is of type struct buffer * and v of type struct
7718 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7719 != &v->size, and therefore "v->size = 1; b->size = 2; return
7720 v->size;" must therefore return 1. This assumption is incorrect
7721 for Emacs, since it type-puns struct Lisp_Vector * with many other
7722 types. To fix this problem, this patch adds a new type struct
7723 vectorlike_header that documents the constraints on layout of vectors
7724 and pseudovectors, and helps optimizing compilers not get fooled
7725 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7726 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7727 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7729 (XSETPVECTYPE): Rewrite in terms of new macro.
7730 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7731 This is a bit clearer, and further avoids the possibility of
7732 undesirable aliasing.
7733 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7734 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7735 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7736 since Lisp_Subr is a special case (no "next" field).
7737 (ASIZE): Now uses header.size rather than size.
7738 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7739 to avoid the hassle of writing XVECTOR (foo)->header.size.
7740 (struct vectorlike_header): New type.
7741 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7742 object, to help avoid aliasing.
7743 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7744 (SUBRP): Likewise, since Lisp_Subr is a special case.
7745 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7746 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7747 (struct Lisp_Hash_Table): Combine first two members into a single
7748 struct vectorlike_header member. All uses of "size" and "next" members
7749 changed to be "header.size" and "header.next".
7750 * buffer.h (struct buffer): Likewise.
7751 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7752 * frame.h (struct frame): Likewise.
7753 * process.h (struct Lisp_Process): Likewise.
7754 * termhooks.h (struct terminal): Likewise.
7755 * window.c (struct save_window_data, struct saved_window): Likewise.
7756 * window.h (struct window): Likewise.
7757 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7758 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7759 * buffer.c (init_buffer_once): Likewise.
7760 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7762 * process.c (Fformat_network_address): Use local var for size,
7765 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7767 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7768 * data.c (atof): Remove decl; no longer used or needed.
7769 (digit_to_number): Move to lread.c.
7770 (Fstring_to_number): Use new string_to_number function, to be
7771 consistent with how the Lisp reader treats infinities and NaNs.
7772 Do not assume that floating-point numbers represent EMACS_INT
7773 without losing information; this is not true on most 64-bit hosts.
7774 Avoid double-rounding errors, by insisting on integers when
7775 parsing non-base-10 numbers, as the documentation specifies.
7776 * lisp.h (string_to_number): New decl, replacing ...
7777 (isfloat_string): Remove.
7778 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7779 (read1): Do not accept +. and -. as integers; this
7780 appears to have been a coding error. Similarly, do not accept
7781 strings like +-1e0 as floating point numbers. Do not report
7782 overflow for integer overflows unless the base is not 10 which
7783 means we have no simple and reliable way to continue.
7784 Break out the floating-point parsing into a new
7785 function string_to_number, so that Fstring_to_number parses
7786 floating point numbers consistently with the Lisp reader.
7787 (digit_to_number): Move here from data.c. Make it static inline.
7788 (E_CHAR, EXP_INT): Remove, replacing with ...
7789 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7790 (string_to_number): New function, replacing isfloat_string.
7791 This function checks for valid syntax and produces the resulting
7792 Lisp float number too. Rework it so that string-to-number
7793 no longer mishandles examples like "1.0e+". Use strtoumax,
7794 so that overflow for non-base-10 numbers is reported only when
7795 there's no portable and simple way to convert to floating point.
7797 * textprop.c (set_text_properties_1): Rewrite for clarity,
7798 and to avoid GCC warning about integer overflow.
7800 * intervals.h (struct interval): Use EMACS_INT for members
7801 where EMACS_UINT might cause problems. See
7802 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7803 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7804 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7806 (offset_intervals): Tell GCC not to worry about length overflow
7807 when negating a negative length.
7809 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7810 (overrun_check_free): Likewise.
7812 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7813 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7816 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7817 (gnutls_make_error): Rename local to avoid shadowing.
7818 (gnutls_emacs_global_deinit): ifdef out; not used.
7819 (Fgnutls_boot): Use const for pointer to readonly storage.
7820 Comment out unused local. Fix pointer signedness problems.
7822 * lread.c (openp): Don't stuff size_t into an 'int'.
7823 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7824 about possible signed overflow.
7826 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7827 (GDK_KEY_g): Don't define if already defined.
7828 (xg_prepare_tooltip): Avoid pointer signedness problem.
7829 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7831 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7832 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7834 * xfns.c (Fx_window_property): Simplify a bit,
7835 to make a bit faster and to avoid GCC 4.6.0 warning.
7836 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7838 * fns.c (internal_equal): Don't assume size_t fits in int.
7840 * alloc.c (compact_small_strings): Tighten assertion a little.
7842 Replace pEd with more-general pI, and fix some printf arg casts.
7843 * lisp.h (pI): New macro, generalizing old pEd macro to other
7844 conversion specifiers. For example, use "...%"pI"d..." rather
7845 than "...%"pEd"...".
7846 (pEd): Remove. All uses replaced with similar uses of pI.
7847 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7848 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7849 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7850 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7851 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7852 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7853 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7855 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7856 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7857 * print.c (safe_debug_print, print_object): Likewise.
7858 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7860 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7861 avoiding the 0 flag, which is not portable.
7862 * process.c (Fmake_network_process): Use pI to avoid cast.
7863 * region-cache.c (pp_cache): Likewise.
7864 * xdisp.c (decode_mode_spec): Likewise.
7865 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7866 behavior on 64-bit hosts with printf arg.
7867 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7868 (x_stop_queuing_selection_requests): Likewise.
7869 (x_get_window_property): Don't truncate byte count to an 'int'
7872 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7873 here, since it parses constructs like leading '-' and spaces,
7874 which are not wanted; and it overflows with large numbers.
7875 Instead, simply match F[0-9]+, which is what is wanted anyway.
7877 * alloc.c: Remove unportable assumptions about struct layout.
7878 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7879 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7880 (allocate_vectorlike, make_pure_vector): Use the new macros,
7881 plus offsetof, to remove unportable assumptions about struct layout.
7882 These assumptions hold on all porting targets that I know of, but
7883 they are not guaranteed, they're easy to remove, and removing them
7884 makes further changes easier.
7886 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7887 This doesn't fix a bug but makes the code clearer.
7888 (string_overrun_cookie): Now const. Use initializers that
7889 don't formally overflow signed char, to avoid warnings.
7890 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7891 can cause Emacs to crash when string overrun checking is enabled.
7892 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7893 multiple of sizeof (EMACS_INT); it need not be, if
7894 alignof(EMACS_INT) < sizeof (EMACS_INT).
7895 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7897 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7899 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7901 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7903 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7904 supposed to be handshaking. (Bug#8556)
7905 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7907 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7909 * lisp.h (Qdebug): List symbol.
7910 * eval.c (Qdebug): Restore global linkage.
7911 * keyboard.c (debug-on-event): New variable.
7912 (handle_user_signal): Break into debugger when debug-on-event
7913 matches the current signal symbol.
7915 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7917 * alloc.c (check_sblock, check_string_bytes)
7918 (check_string_free_list): Convert to standard C.
7920 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7922 * w32.c (emacs_gnutls_push): Fix typo.
7924 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7926 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7927 "cast to pointer from integer of different size".
7929 Improve doprnt and its use in verror. (Bug#8545)
7930 * doprnt.c (doprnt): Document the set of format control sequences
7931 supported by the function. Use SAFE_ALLOCA instead of always
7934 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7935 is one byte too soon. Don't use xrealloc; instead xfree and
7938 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7940 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7943 * gnutls.c: Renamed global_initialized to
7944 gnutls_global_initialized. Added internals for the
7945 :verify-hostname-error, :verify-error, and :verify-flags
7946 parameters of `gnutls-boot' and documented those parameters in the
7947 docstring. Start callback support.
7948 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7949 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7950 on error. Return error code.
7951 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7952 (emacs_gnutls_read): Likewise.
7953 (Fgnutls_boot): Return handshake error code.
7954 (emacs_gnutls_handle_error): New function.
7955 (wsaerror_to_errno): Likewise.
7957 * w32.h (emacs_gnutls_pull): Add prototype.
7958 (emacs_gnutls_push): Likewise.
7960 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7961 (emacs_gnutls_push): Likewise.
7963 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7965 * process.c (wait_reading_process_output): Check if GnuTLS
7966 buffered some data internally if no FDs are set for TLS
7969 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7970 (LIBS): Link to USER_LIBS.
7971 ($(BLD)/gnutls.$(0)): New target.
7973 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7975 * xdisp.c (handle_single_display_spec): Rename the
7976 display_replaced_before_p argument into display_replaced_p, to
7977 make it consistent with the commentary. Fix typos in the
7980 * textprop.c (syms_of_textprop): Remove dead code.
7981 (copy_text_properties): Delete obsolete commentary about an
7982 interface that was deleted long ago. Fix typos in the description
7985 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7986 to changes in oldXMenu/XMenu.h from 2011-04-16.
7987 <menu_help_message, prev_menu_help_message>: Constify.
7988 (IT_menu_make_room): menu->help_text is now `const char **';
7991 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7992 to changes in oldXMenu/XMenu.h from 2011-04-16.
7993 (struct XMenu): Declare `help_text' `const char **'.
7995 * xfaces.c <Qunspecified>: Make extern again.
7997 * syntax.c: Include sys/types.h before including regex.h, as
8000 * doc.c (get_doc_string): Improve the format passed to `error'.
8002 * doprnt.c (doprnt): Improve commentary.
8004 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8006 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8009 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8010 changes in globals.h immediately force recompilation.
8011 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8012 $(CURDIR)/s/ms-w32.h.
8013 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8015 * character.c (Fchar_direction): Function deleted.
8016 (syms_of_character): Don't defsubr it.
8017 <char-direction-table>: Deleted.
8019 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8021 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8022 * doprnt.c: Include limits.h.
8023 (SIZE_MAX): New macro.
8024 (doprnt): Return a size_t value. 2nd arg is now size_t.
8025 Many local variables are now size_t instead of int or unsigned.
8026 Improve overflow protection. Support `l' modifier for integer
8027 conversions. Support %l conversion. Don't assume an EMACS_INT
8028 argument for integer conversions and for %c.
8030 * lisp.h (doprnt): Restore prototype.
8032 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8035 * Makefile.in (base_obj): Add back doprnt.o.
8037 * deps.mk (doprnt.o): Add back prerequisites.
8038 (callint.o): Depend on character.h.
8040 * eval.c (internal_lisp_condition_case): Include the handler
8041 representation in the error message.
8042 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8043 when breaking from the loop.
8045 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8047 * callint.c (Fcall_interactively): When displaying error message
8048 about invalid control letter, pass the character's codepoint, not
8049 a pointer to its multibyte form. Improve display of the character
8050 in octal and display also its hex code.
8052 * character.c (char_string): Use %x to display the (unsigned)
8053 codepoint of an invalid character, to avoid displaying a bogus
8056 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8057 `error', not SYMBOL_NAME itself.
8059 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8060 character arguments to `error'.
8062 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8063 to `error' in error message about FINAL_CHAR argument. Make sure
8064 FINAL_CHAR is a character, and use %c when it is passed as
8065 argument to `error'.
8067 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8069 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8071 * w32.c: Include <time.h>.
8072 (sys_localtime): New function.
8074 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8076 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8078 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8080 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8082 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8085 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8087 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8088 gl_state.e_property when gl_state.object is Qt.
8090 * insdel.c (make_gap_larger): Remove limitation of buffer size
8093 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8095 * xdisp.c (lookup_glyphless_char_display)
8096 (produce_glyphless_glyph): Handle cons cell entry in
8097 glyphless-char-display.
8098 (Vglyphless_char_display): Document it.
8100 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8101 glyphless-char-display.
8103 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8105 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8107 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8109 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8110 definition for no-X builds.
8112 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8114 Static checks with GCC 4.6.0 and non-default toolkits.
8116 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
8118 * process.c (keyboard_bit_set): Define only if SIGIO.
8119 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
8120 (send_process): Repair possible setjmp clobbering.
8122 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8124 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8126 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8128 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8129 Define only if needed.
8131 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8132 by pacifying GCC about it. Maybe it's time to retire it?
8133 * xfaces.c (USG, __TIMEVAL__): Likewise.
8135 * dispextern.h (struct redisplay_interface): Rename param
8137 * termhooks.h (struct terminal): Likewise.
8138 * xterm.c (xembed_send_message): Likewise.
8140 * insdel.c (make_gap_smaller): Define only if
8141 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8143 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8146 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8147 so that we aren't warned about unused symbols.
8149 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8151 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8153 * xfns.c (x_real_positions): Mark locals as initialized.
8155 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8157 * xterm.c: Fix problems found by static analysis with other toolkits.
8158 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8159 (x_dispatch_event): Declare static if USE_GTK, and
8160 define if USE_GTK || USE_X_TOOLKIT.
8161 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8162 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8163 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8164 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8166 * xmenu.c (menu_help_callback): Pointer type fixes.
8167 Use const pointers when pointing at readonly data. Avoid pointer
8169 (FALSE): Remove unused macro.
8170 (update_frame_menubar): Remove unused decl.
8172 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8174 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8175 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8176 (single_menu_item): Rename local to avoid shadowing.
8178 * keyboard.c (make_lispy_event): Remove unused local var.
8180 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8181 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8183 * bitmaps: Change bitmaps from unsigned char back to the X11
8184 compatible char. Avoid the old compiler warnings about
8185 out-of-range initializers by using, for example, '\xab' rather
8188 * xgselect.c (xgselect_initialize): Check vs interface
8189 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8191 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8193 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8194 to read-only memory.
8196 * fns.c (vector): Remove; this old hack is no longer needed.
8198 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8200 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8202 * xrdb.c (x_load_resources): Omit unused local.
8204 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8205 (x_window): Rename locals to avoid shadowing.
8206 (USG): Use the kludged USG macro, to pacify gcc.
8208 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8209 (x_term_init): Remove local to avoid shadowing.
8211 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8213 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8214 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8216 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8218 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8220 Fix regex.c, syntax.c and friends for buffers > 2GB.
8221 * syntax.h (struct gl_state_s): Declare character position members
8224 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8226 * textprop.c (verify_interval_modification, interval_of):
8227 Declare arguments EMACS_INT.
8229 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8232 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8234 * indent.c (Fvertical_motion): Local variable it_start is now
8237 * regex.c (re_match, re_match_2, re_match_2_internal)
8238 (bcmp_translate, regcomp, regexec, print_double_string)
8239 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8240 (re_compile_pattern, re_exec): Declare arguments and local
8241 variables `size_t' and `ssize_t' and return values `regoff_t', as
8243 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8244 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8245 <compile_stack_type>: `size' and `avail' are now `size_t'.
8247 * regex.h <regoff_t>: Use ssize_t, not int.
8248 (re_search, re_search_2, re_match, re_match_2): Arguments that
8249 specify buffer/string position and length are now ssize_t and
8250 size_t. Return type is regoff_t.
8252 2011-04-16 Ben Key <bkey76@gmail.com>
8254 * nsfont.m: Fixed bugs in ns_get_family and
8255 ns_descriptor_to_entity that were caused by using free to
8256 deallocate memory blocks that were allocated by xmalloc (via
8257 xstrdup). This caused Emacs to crash when compiled with
8258 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8259 --enable-checking=xmallocoverrun). xfree is now used to
8260 deallocate these memory blocks.
8262 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8264 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8266 emacs_write: Accept and return EMACS_INT for sizes.
8267 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8269 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8270 Accept and return EMACS_INT.
8271 (emacs_gnutls_write): Return the number of bytes written on
8273 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8274 (emacs_read, emacs_write): Remove check for negative size, as the
8275 Emacs source code has been audited now.
8276 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8277 (emacs_read, emacs_write): Use it.
8278 * process.c (send_process): Adjust to the new signatures of
8279 emacs_write and emacs_gnutls_write. Do not attempt to store
8280 a byte offset into an 'int'; it might overflow.
8281 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8283 * sound.c: Don't assume sizes fit in 'int'.
8284 (struct sound_device.period_size, alsa_period_size):
8285 Return EMACS_INT, not int.
8286 (struct sound_device.write, vox_write, alsa_write):
8287 Accept EMACS_INT, not int.
8288 (wav_play, au_play): Use EMACS_INT to store sizes and to
8289 record read return values.
8291 2011-04-15 Ben Key <bkey76@gmail.com>
8293 * keyboard.c (Qundefined): Don't declare static since it is used
8295 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8296 static since they are used in nsfont.m.
8298 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8300 * process.c (Qprocessp): Don't declare static.
8301 * lisp.h (Qprocessp): Declare again.
8303 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8305 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8307 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8309 Improve C-level modularity by making more things 'static'.
8311 Don't publish debugger-only interfaces to other modules.
8312 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8313 (verify_bytepos, count_markers): Move decls to the only modules
8315 * region-cache.h (pp_cache): Likewise.
8316 * window.h (check_all_windows): Likewise.
8317 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8319 * sysdep.c (croak): Now static, if
8320 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8321 * syssignal.h (croak): Declare only if not static.
8323 * alloc.c (refill_memory_reserve): Now static if
8324 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8325 * lisp.h (refill_memory_reserve): Declare only if not static.
8327 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8328 Define only if USE_LUCID.
8330 * xrdb.c (x_customization_string, x_rm_string): Now static.
8332 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8333 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8335 * xdisp.c (draw_row_with_mouse_face): Now static.
8336 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8338 * window.h (check_all_windows): Mark externally visible.
8340 * window.c (window_deletion_count): Now static.
8342 * undo.c: Make symbols static if they're not exported.
8343 (last_undo_buffer, last_boundary_position, pending_boundary):
8346 * textprop.c (interval_insert_behind_hooks): Now static.
8347 (interval_insert_in_front_hooks): Likewise.
8349 * term.c: Make symbols static if they're not exported.
8350 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8351 (max_frame_lines, tty_set_terminal_modes):
8352 (tty_reset_terminal_modes, tty_turn_off_highlight):
8353 (get_tty_terminal): Now static.
8354 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8355 * termhooks.h (term_mouse_moveto): Do not declare if
8357 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8358 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8360 * sysdep.c: Make symbols static if they're not exported.
8361 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8363 (sigprocmask_set, full_mask): Remove; unused.
8364 (wait_debugging): Mark as visible.
8365 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8366 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8368 * syntax.c (syntax_temp): Define only if !__GNUC__.
8370 * sound.c (current_sound_device, current_sound): Now static.
8372 * search.c (searchbufs, searchbuf_head): Now static.
8374 * scroll.c (scroll_cost): Remove; unused.
8375 * dispextern.h (scroll_cost): Remove decl.
8377 * region-cache.h (pp_cache): Mark as externally visible.
8379 * process.c: Make symbols static if they're not exported.
8380 (process_tick, update_tick, create_process, chan_process):
8381 (Vprocess_alist, proc_buffered_char, datagram_access):
8382 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8383 (deactivate_process): Mark defn as static, as well as decl.
8384 * lisp.h (create_process): Remove decl.
8385 * process.h (chan_process, Vprocess_alist): Remove decls.
8387 * print.c: Make symbols static if they're not exported.
8388 (print_depth, new_backquote_output, being_printed, print_buffer):
8389 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8390 (print_interval, print_number_index, initial_stderr_stream):
8392 * lisp.h (Fprinc): Remove decl.
8393 (debug_output_compilation_hack): Mark as externally visible.
8395 * sysdep.c (croak): Move decl from here to syssignal.h.
8396 * syssignal.h (croak): Put it here, so the API can be checked when
8397 'croak' is called from dissociate_if_controlling_tty.
8399 * minibuf.c: Make symbols static if they're not exported.
8400 (minibuf_save_list, choose_minibuf_frame): Now static.
8401 * lisp.h (choose_minibuf_frame): Remove decl.
8403 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8405 * lread.c: Make symbols static if they're not exported.
8406 (read_objects, initial_obarray, oblookup_last_bucket_number):
8408 (make_symbol): Remove; unused.
8409 * lisp.h (initial_obarray, make_symbol): Remove decls.
8411 * keyboard.c: Make symbols static if they're not exported.
8412 (single_kboard, recent_keys_index, total_keys, recent_keys):
8413 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8414 (this_single_command_key_start, echoing, last_auto_save):
8415 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8416 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8417 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8418 (Vlispy_mouse_stem, double_click_count):
8420 (force_auto_save_soon): Define only if SIGDANGER.
8421 (ignore_mouse_drag_p): Now static if
8422 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8423 (print_help): Remove; unused.
8424 (stop_character, last_timer_event): Mark as externally visible.
8425 * keyboard.h (ignore_mouse_drag_p): Declare only if
8426 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8427 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8428 * lisp.h (echoing): Remove decl.
8429 (force_auto_save_soon): Declare only if SIGDANGER.
8430 * xdisp.c (redisplay_window): Simplify code, to make it more
8431 obvious that ignore_mouse_drag_p is not accessed if !defined
8432 USE_GTK && !defined HAVE_NS.
8434 * intervals.c: Make symbols static if they're not exported.
8435 (merge_properties_sticky, merge_interval_right, delete_interval):
8437 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8439 * insdel.c: Make symbols static if they're not exported.
8440 However, leave prepare_to_modify_buffer alone. It's never
8441 called from outside this function, but that appears to be a bug.
8442 (combine_after_change_list, combine_after_change_buffer):
8443 (adjust_after_replace, signal_before_change): Now static.
8444 (adjust_after_replace_noundo): Remove; unused.
8445 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8446 (signal_before_change): Remove decls.
8448 * indent.c (val_compute_motion, val_vmotion): Now static.
8450 * image.c: Make symbols static if they're not exported.
8451 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8453 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8454 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8456 * fringe.c (standard_bitmaps): Now static.
8457 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8459 * frame.c: Make symbols static if they're not exported.
8460 (x_report_frame_params, make_terminal_frame): Now static.
8461 (get_frame_param): Now static, unless HAVE_NS.
8462 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8463 (x_get_resource_string): Remove; not used.
8464 * frame.h (make_terminal_frame, x_report_frame_params):
8465 (x_get_resource_string); Remove decls.
8466 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8467 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8469 * font.c, fontset.c: Make symbols static if they're not exported.
8470 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8471 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8472 * font.c (font_close_object): Now static.
8473 * font.h (font_close_object): Remove.
8474 * fontset.c (FONTSET_OBJLIST): Remove.
8475 (free_realized_fontset) #if-0 the body, which does nothing.
8476 (face_suitable_for_char_p): #if-0, as it's never called.
8477 * fontset.h (face_suitable_for_char_p): Remove decl.
8478 * xfaces.c (face_at_string_position):
8479 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8480 since 0 is always ASCII.
8482 * fns.c (weak_hash_tables): Now static.
8484 * fileio.c: Make symbols static if they're not exported.
8485 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8486 (Vwrite_region_annotation_buffers): Now static.
8488 * eval.c: Make symbols static if they're not exported.
8489 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8490 * lisp.h (backtrace_list): Remove decl.
8492 * emacs.c: Make symbols static if they're not exported.
8493 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8494 (fatal_error_code, fatal_error_signal_hook, standard_args):
8496 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8497 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8498 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8499 * lisp.h (fatal_error_signal_hook): Remove decl.
8500 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8502 * editfns.c: Move a (normally-unused) function to its only use.
8503 * editfns.c, lisp.h (get_operating_system_release): Remove.
8504 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8505 worth the hassle of breaking this out.
8507 * xterm.c: Make symbols static if they're not exported.
8508 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8509 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8510 (x_destroy_window, x_delete_display):
8512 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8513 (x_mouse_leave): Remove; unused.
8514 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8515 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8516 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8518 (x_mouse_leave): Declare only if WINDOWSNT.
8519 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8520 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8523 * ftxfont.c: Make symbols static if they're not exported.
8524 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8526 * font.h (ftxfont_driver): Likewise.
8528 * xfns.c: Make symbols static if they're not exported.
8529 (x_last_font_name, x_display_info_for_name):
8530 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8531 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8532 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8533 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8534 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8535 (last_show_tip_args): Now static.
8536 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8537 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8538 (x_screen_planes): Remove; unused.
8539 * dispextern.h (x_screen_planes): Remove decl.
8541 * dispnew.c: Make symbols static if they're not exported.
8542 * dispextern.h (redraw_garbaged_frames, scrolling):
8543 (increment_row_positions): Remove.
8544 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8545 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8547 (redraw_garbaged_frames): Remove; unused.
8549 * xfaces.c: Make symbols static if they're not exported.
8550 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8552 * xterm.h (defined_color): Remove decls.
8553 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8554 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8555 (menu_face_changed_default, defined_color, free_realized_face):
8556 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8557 (ascii_face_of_lisp_face): Remove; unused.
8559 * xdisp.c: Make symbols static if they're not exported.
8560 * dispextern.h (scratch_glyph_row, window_box_edges):
8561 (glyph_to_pixel_coords, set_cursor_from_row):
8562 (get_next_display_element, set_iterator_to_next):
8563 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8564 (show_mouse_face): Remove decls
8565 * frame.h (message_buf_print): Likewise.
8566 * lisp.h (pop_message, set_message, check_point_in_composition):
8568 * xterm.h (set_vertical_scroll_bar): Likewise.
8569 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8570 (message_buf_print, scratch_glyph_row, displayed_buffer):
8571 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8572 (get_next_display_element, show_mouse_face, window_box_edges):
8573 (frame_to_window_pixel_xy, check_point_in_composition):
8574 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8575 (glyph_to_pixel_coords): Remove; unused.
8577 * dired.c (file_name_completion): Now static.
8579 * dbusbind.c (xd_in_read_queued_messages): Now static.
8581 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8582 * data.c (circular_list_error): Remove.
8584 * commands.h (last_point_position, last_point_position_buffer):
8585 (last_point_position_window): Remove decls.
8586 * keyboard.c: Make these variables static.
8588 * coding.h (coding, code_convert_region, encode_coding_gap):
8590 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8591 (iso_code_class, detect_coding, code_convert_region): Now static.
8592 (encode_coding_gap): Remove; unused.
8594 * chartab.c (chartab_chars, chartab_bits): Now static.
8596 * charset.h (charset_iso_8859_1): Remove decl.
8597 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8600 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8601 * ccl.c (Vccl_program_table): Now static.
8602 (check_ccl_update): Remove; unused.
8604 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8605 * category.h: ... from here.
8606 * category.c (check_category_table, set_category_set): Now static.
8608 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8609 * lisp.h: Remove these decls.
8611 * buffer.c (buffer_count): Remove unused var.
8613 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8614 so that it's not optimized away.
8615 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8616 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8617 exported only to the debugger.
8619 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8620 * atimer.h (run_all_atimers): Remove; not exported.
8622 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8623 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8624 was inaccessible from Lisp.
8625 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8626 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8628 alloc.c: Import and export fewer symbols, and remove unused items.
8629 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8631 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8632 it's not optimized away by whole-program optimization.
8633 (message_enable_multibyte, free_misc): Remove.
8634 (catchlist, handlerlist, mark_backtrace):
8635 Declare only if BYTE_MARK_STACK.
8636 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8637 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8638 (message_enable_multibyte): Remove decl.
8639 (free_misc, interval_free_list, float_block, float_block_index):
8640 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8641 (cons_free_list, last_marked_index):
8643 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8644 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8645 (mark_backtrace): Define only if BYTE_MARK_STACK.
8646 * xdisp.c (message_enable_multibyte): Now static.
8648 Declare Lisp_Object Q* variables to be 'static' if not exported.
8649 This makes it easier for human readers (and static analyzers)
8650 to see whether these variables are used from other modules.
8651 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8652 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8653 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8654 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8655 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8656 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8657 * xmenu.c, xselect.c:
8658 Declare Q* vars static if they are not used in other modules.
8659 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8660 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8661 Remove decls of unexported vars.
8662 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8664 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8666 Make Emacs functions such as Fatom 'static' by default.
8667 This makes it easier for human readers (and static analyzers)
8668 to see whether these functions can be called from other modules.
8669 DEFUN now defines a static function. To make the function external
8670 so that it can be used in other C modules, use the new macro DEFUE.
8671 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8672 (Finit_image_library):
8673 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8674 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8675 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8676 Remove decls, since these functions are now static.
8677 (Funintern, Fget_internal_run_time): New decls, since these functions
8678 were already external.
8680 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8681 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8682 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8683 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8684 * keyboard.c, keymap.c, lread.c:
8685 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8686 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8687 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8688 Mark functions with DEFUE instead of DEFUN,
8689 if they are used in other modules.
8690 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8691 decls for now-static functions.
8692 * buffer.h (Fdelete_overlay): Remove decl.
8693 * callproc.c (Fgetenv_internal): Mark as internal.
8694 * composite.c (Fremove_list_of_text_properties): Remove decl.
8695 (Fcomposition_get_gstring): New forward static decl.
8696 * composite.h (Fcomposite_get_gstring): Remove decl.
8697 * dired.c (Ffile_attributes): New forward static decl.
8698 * doc.c (Fdocumntation_property): New forward static decl.
8699 * eval.c (Ffetch_bytecode): New forward static decl.
8700 (Funintern): Remove extern decl; now in .h file where it belongs.
8701 * fileio.c (Fmake_symbolic_link): New forward static decl.
8702 * image.c (Finit_image_library): New forward static decl.
8703 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8704 * intervals.h (Fprevious_property_change):
8705 (Fremove_list_of_text_properties): Remove decls.
8706 * keyboard.c (Fthis_command_keys): Remove decl.
8707 (Fcommand_execute): New forward static decl.
8708 * keymap.c (Flookup_key): New forward static decl.
8709 (Fcopy_keymap): Now static.
8710 * keymap.h (Flookup_key): Remove decl.
8711 * process.c (Fget_process): New forward static decl.
8712 (Fprocess_datagram_address): Mark as internal.
8713 * syntax.c (Fsyntax_table_p): New forward static decl.
8714 (skip_chars): Remove duplicate decl.
8715 * textprop.c (Fprevious_property_change): New forward static decl.
8716 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8718 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8719 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8721 * editfns.c (Fformat): Remove unreachable code.
8723 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8725 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8728 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8730 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8731 when at ZV. (Bug#8487)
8733 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8735 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8737 * keyboard.c (parse_tool_bar_item): Likewise.
8738 * sound.c (sound_cleanup, alsa_close): Likewise.
8739 * termcap.c (tgetent): Likewise.
8740 * xfns.c (x_default_font_parameter): Likewise.
8741 * xsettings.c (read_and_apply_settings): Likewise.
8743 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8744 (overrun_check_free): Protoize.
8746 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8748 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8749 since callers should never pass a negative size.
8750 Change the signature to match that of plain 'read' and 'write'; see
8751 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8752 * lisp.h: Update prototypes of emacs_write and emacs_read.
8754 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8756 * xdisp.c (redisplay_window): Don't try to determine the character
8757 position of the scroll margin if the window start point w->startp
8758 is outside the buffer's accessible region. (Bug#8468)
8760 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8762 Fix write-region and its subroutines for buffers > 2GB.
8763 * fileio.c (a_write, e_write): Modify declaration of arguments and
8764 local variables to support buffers larger than 2GB.
8765 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8767 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8768 argument, local variables, and return value.
8770 * lisp.h: Update prototypes of emacs_write and emacs_read.
8772 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8774 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8776 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8778 Fix more problems found by GCC 4.6.0's static checks.
8780 * xdisp.c (vmessage): Use a better test for character truncation.
8782 * charset.c (load_charset_map): <, not <=, for optimization,
8783 and to avoid potential problems with integer overflow.
8784 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8785 * casetab.c (set_identity, shuffle): Likewise.
8786 * editfns.c (Fformat): Likewise.
8787 * syntax.c (skip_chars): Likewise.
8789 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8790 This also lets GCC 4.6.0 generate slightly better loop code.
8792 * callint.c (Fcall_interactively): <, not <=, for optimization.
8793 (Fcall_interactively): Count the number of arguments produced,
8794 not the number of arguments given. This is simpler and lets GCC
8795 4.6.0 generate slightly better code.
8797 * ftfont.c: Distingish more carefully between FcChar8 and char.
8798 The previous code passed unsigned char * to a functions like
8799 strlen and xstrcasecmp that expect char *, which does not
8800 conform to the C standard.
8801 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8802 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8803 char * when the C standard requires it.
8805 * keyboard.c (read_char): Remove unused var.
8807 * eval.c: Port to Windows vsnprintf (Bug#8435).
8809 (SIZE_MAX): Define if the headers do not.
8810 (verror): Do not give up if vsnprintf returns a negative count.
8811 Instead, grow the buffer. This ports to Windows vsnprintf, which
8812 does not conform to C99. Problem reported by Eli Zaretskii.
8813 Also, simplify the allocation scheme, by avoiding the need for
8814 calling realloc, and removing the ALLOCATED variable.
8816 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8818 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8819 But keep the doprint source code for now, as we might revamp it
8820 and use it again (Bug#8435).
8821 * lisp.h (doprnt): Remove.
8822 * Makefile.in (base_obj): Remove doprnt.o.
8823 * deps.mk (doprnt.o): Remove.
8825 error: Print 32- and 64-bit integers portably (Bug#8435).
8826 Without this change, on typical 64-bit hosts error ("...%d...", N)
8827 was used to print both 32- and 64-bit integers N, which relied on
8829 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8830 * lisp.h (error, verror): Mark as printf-like functions.
8831 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8832 Report overflow in size calculations when allocating printf buffer.
8833 Do not truncate output string at its first null byte.
8834 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8835 Truncate the output at a character boundary, since vsnprintf does not
8837 * charset.c (check_iso_charset_parameter): Convert internal
8838 character to string before calling 'error', since %c now has the
8840 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8841 overflow when computing char to be passed to 'error'. Do not
8842 pass Lisp_Object to 'error'; pass the integer instead.
8843 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8844 formatted with plain %d.
8846 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8848 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8850 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8852 * xterm.c (x_catch_errors): Remove duplicate declaration.
8854 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8856 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8858 2011-04-10 Jim Meyering <meyering@redhat.com>
8860 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8861 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8862 return ssize_t not "int", and use size_t as the buffer length.
8863 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8864 * gnutls.h: Update declarations.
8865 * process.c (read_process_output): Use ssize_t, to match.
8866 (send_process): Likewise.
8868 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8870 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8872 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8874 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8875 Use unsigned char, to match FcChar8 type definition.
8877 * xterm.c (handle_one_xevent):
8878 * xmenu.c (create_and_show_popup_menu):
8879 * xselect.c (x_decline_selection_request)
8880 (x_reply_selection_request): Avoid type-punned deref of X events.
8882 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8884 Fix some uses of `int' instead of EMACS_INT.
8885 * search.c (string_match_1, fast_string_match)
8886 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8887 (scan_buffer, find_next_newline_no_quit)
8888 (find_before_next_newline, search_command, Freplace_match)
8889 (Fmatch_data): Make some `int' variables be EMACS_INT.
8891 * xdisp.c (display_count_lines): 3rd argument and return value now
8892 EMACS_INT. All callers changed.
8893 (pint2hrstr): Last argument is now EMACS_INT.
8895 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8896 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8897 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8898 (decode_coding_utf_16, decode_coding_emacs_mule)
8899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8900 (decode_coding_ccl, decode_coding_charset)
8901 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8902 (decode_coding_iso_2022, decode_coding_emacs_mule)
8903 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8904 <char_offset, last_offset>: Declare EMACS_INT.
8905 (encode_coding_utf_8, encode_coding_utf_16)
8906 (encode_coding_emacs_mule, encode_invocation_designation)
8907 (encode_designation_at_bol, encode_coding_iso_2022)
8908 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8909 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8911 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8912 (encode_invocation_designation): Last argument P_NCHARS is now
8914 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8915 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8917 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8920 * ccl.c (Fccl_execute_on_string): Declare some variables
8923 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8925 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8927 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8929 * process.c (Fformat_network_address): Doc fix.
8931 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8933 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8935 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8937 * keyboard.c (read_char): Call Lisp function help-form-show,
8938 instead of using internal_with_output_to_temp_buffer.
8939 (Qhelp_form_show): New var.
8940 (syms_of_keyboard): Use DEFSYM macro.
8942 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8944 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8946 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8948 * process.c (Flist_processes): Remove to Lisp.
8949 (list_processes_1): Delete.
8951 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8953 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8955 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8957 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8959 Fix more problems found by GCC 4.6.0's static checks.
8961 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8963 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8965 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8967 * xdisp.c (vmessage): Mark as a printf-like function.
8969 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8971 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8973 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8974 printf-like functions.
8975 (tiff_load): Add casts to remove these marks before passing them
8976 to system-supplied API.
8978 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8980 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8981 This avoids several warnings with gcc -Wstrict-overflow.
8982 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8983 directly, rather than having caller test rule sign. This avoids
8984 some unnecessary tests.
8985 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8986 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8987 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8989 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8990 (xfont_open): Avoid unnecessary tests.
8992 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8994 * composite.h, composite.c (composition_gstring_put_cache):
8995 Use EMACS_INT, not int, for length.
8997 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8998 breaking out part of COMPOSITION_DECODE_RULE.
8999 (COMPOSITION_DECODE_RULE): Use it.
9000 * composite.c (get_composition_id): Remove unused local vars,
9001 by using the new macro.
9003 * textprop.c (set_text_properties_1): Change while to do-while,
9004 since the condition is always true at first.
9006 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9007 (interval_deletion_adjustment): Return unsigned value.
9010 * process.c (list_processes_1, create_pty, read_process_output):
9011 (exec_sentinel): Remove vars that were set but not used.
9012 (create_pty): Remove unnecessary "volatile"s.
9013 (Fnetwork_interface_info): Avoid possibility of int overflow.
9014 (read_process_output): Do adaptive read buffering even if carryover.
9015 (read_process_output): Simplify nbytes computation if buffered.
9017 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9019 * syntax.c (scan_words): Remove var that was set but not used.
9020 (update_syntax_table): Use unsigned instead of int.
9022 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9023 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9024 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9026 * print.c (print_error_message): Avoid int overflow.
9028 * font.c (font_list_entities): Redo for clarity,
9029 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9031 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9032 (font_score): Avoid potential overflow in diff calculation.
9034 * fns.c (substring_both): Remove var that is set but not used.
9035 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9037 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9039 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9040 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9041 can always succeed if overflow has undefined behavior.
9043 * search.c (boyer_moore, wordify): Remove vars set but not used.
9044 (wordify): Omit three unnecessary tests.
9046 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9047 All callers changed. This avoids the need for an unused var.
9049 * casefiddle.c (casify_region): Remove var that is set but not used.
9051 * dired.c (file_name_completion): Remove var that is set but not used.
9053 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9055 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9056 (Finsert_file_contents): Remove unnecessary code checking fd.
9058 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9059 Check for integer overflow on size calculations.
9061 * buffer.c (Fprevious_overlay_change): Remove var that is set
9064 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9065 Remove vars that are set but not used.
9066 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9067 (timer_check_2): Mark vars as initialized.
9069 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9071 * image.c (lookup_image): Remove var that is set but not used.
9072 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9074 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9075 that are set but not used.
9077 * xfns.c (make_invisible_cursor): Don't return garbage
9078 if XCreateBitmapFromData fails (Bug#8410).
9080 * xselect.c (x_get_local_selection, x_handle_property_notify):
9081 Remove vars that are set but not used.
9083 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9084 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9086 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9087 Remove var that is set but not used.
9088 (scroll_bar_windows_size): Now size_t, not int.
9089 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9092 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9093 (map_tty_color) [!defined MSDOS]: Likewise.
9095 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9097 * coding.c: Remove vars that are set but not used.
9098 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9099 All callers changed.
9100 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9101 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9102 (decode_coding_charset): Remove vars that are set but not used.
9104 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9105 that is set but not used.
9107 * print.c (print_object): Remove var that is set but not used.
9109 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9110 The gnulib version avoids calling malloc in the usual case,
9111 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9112 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9113 * filelock.c (current_lock_owner): Likewise.
9114 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
9115 * sysdep.c: Include allocator.h, careadlinkat.h.
9116 (emacs_no_realloc_allocator): New static constant.
9117 (emacs_readlink): New function.
9118 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
9119 ../lib/careadlinkat.h.
9121 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9123 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9124 first non-nil return value).
9126 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9128 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9129 if not defined (Bug#8403).
9131 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9133 * xdisp.c (display_count_lines): Remove parameter `start',
9134 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9135 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9136 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9137 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9138 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9139 and thereabouts. All callers changed.
9140 (get_per_char_metric): Remove parameter `f', unused since
9141 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9143 2011-04-02 Jim Meyering <meyering@redhat.com>
9145 do not dereference NULL upon failed strdup
9146 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9147 (ns_get_family): Likewise.
9149 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9151 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9153 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9155 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9158 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9160 Add lexical binding.
9162 * window.c (Ftemp_output_buffer_show): New fun.
9163 (Fsave_window_excursion):
9164 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9166 * lread.c (lisp_file_lexically_bound_p): New function.
9167 (Fload): Bind Qlexical_binding.
9168 (readevalloop): Remove `evalfun' arg.
9169 Bind Qinternal_interpreter_environment.
9170 (Feval_buffer): Bind Qlexical_binding.
9171 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9173 (syms_of_lread): Declare `lexical-binding'.
9175 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9177 * keyboard.c (eval_dyn): New fun.
9178 (menu_item_eval_property): Use it.
9180 * image.c (parse_image_spec): Use Ffunctionp.
9182 * fns.c (concat, mapcar1): Accept byte-code-functions.
9184 * eval.c (Fsetq): Handle lexical vars.
9185 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9186 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9187 (FletX, Flet): Obey lexical binding.
9188 (Fcommandp): Handle closures.
9189 (Feval): New `lexical' arg.
9190 (eval_sub): New function extracted from Feval. Use it almost
9191 everywhere where Feval was used. Look up vars in lexical env.
9193 (Ffunctionp): Move from subr.el.
9194 (Ffuncall): Handle closures.
9195 (apply_lambda): Remove `eval_flags'.
9196 (funcall_lambda): Handle closures and new byte-code-functions.
9197 (Fspecial_variable_p): New function.
9198 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9199 but without exporting it to Lisp.
9201 * doc.c (Fdocumentation, store_function_docstring):
9202 * data.c (Finteractive_form): Handle closures.
9204 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9207 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9209 (exec_byte_code): New function extracted from Fbyte_code to handle new
9210 calling convention for byte-code-functions. Add new byte-codes.
9212 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9214 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9216 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9218 * xdisp.c (redisplay_internal): Fix prototype.
9220 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9222 * xdisp.c (SCROLL_LIMIT): New macro.
9223 (try_scrolling): Use it when setting scroll_limit.
9224 Limit scrolling to 100 screen lines.
9225 (redisplay_window): Even when falling back on "recentering",
9226 position point in the window according to scroll-conservatively,
9227 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9229 (try_scrolling): When point is above the window, allow searching
9230 as far as scroll_max, or one screenful, to compute vertical
9231 distance from PT to the scroll margin position. This prevents
9232 try_scrolling from unnecessarily failing when
9233 scroll-conservatively is set to a value slightly larger than the
9234 window height. Clean up the case of PT below the margin at bottom
9235 of window: scroll_max can no longer be INT_MAX. When aggressive
9236 scrolling is in use, don't let point enter the opposite scroll
9237 margin as result of the scroll.
9238 (syms_of_xdisp) <scroll-conservatively>: Document the
9239 threshold of 100 lines for never-recentering scrolling.
9241 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9243 * dispextern.h (move_it_by_lines):
9244 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9245 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9246 (message_log_check_duplicate): Remove parameters `prev_bol' and
9247 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9248 (redisplay_internal): Remove parameter `preserve_echo_area',
9249 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9251 * indent.c (Fvertical_motion):
9252 * window.c (window_scroll_pixel_based, Frecenter):
9253 Don't pass `need_y_p' to `move_it_by_lines'.
9255 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9257 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9258 steal a few bits to be more compact.
9259 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9260 Remove unneeded casts.
9262 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9264 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9266 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9267 binding" message (bug#7967).
9269 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9271 Fix more problems found by GCC 4.6.0's static checks.
9273 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9274 Remove unused local var.
9276 * editfns.c (Fmessage_box): Remove unused local var.
9278 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9279 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9280 Omit unused local vars.
9281 * window.c (shrink_windows): Omit unused local var.
9282 * menu.c (digest_single_submenu): Omit unused local var.
9283 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9284 Omit unused local var.
9286 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9287 Don't assume string length fits in int.
9288 (keyremap_step, read_key_sequence): Use size_t for sizes.
9289 (read_key_sequence): Don't check last_real_key_start redundantly.
9291 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9292 instead of alloca (Bug#8344).
9294 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9295 (Fbacktrace_frame): Don't assume nframes fits in int.
9297 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9299 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9302 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9304 * cm.c (calccost): Turn while-do into do-while, for clarity.
9306 * keyboard.c (syms_of_keyboard): Use the same style as later
9307 in this function when indexing through an array. This also
9308 works around GCC bug 48267.
9310 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9312 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9314 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9315 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9317 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9318 This avoids undefined behavior on integer overflow, and is a bit
9319 more convenient anyway since it is compared to a size_t variable.
9321 Variadic C functions now count arguments with size_t, not int.
9322 This avoids an unnecessary limitation on 64-bit machines, which
9323 caused (substring ...) to crash on large vectors (Bug#8344).
9324 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9325 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9326 All variadic functions and their callers changed accordingly.
9327 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9328 * data.c (arith_driver, float_arith_driver): Likewise.
9329 * editfns.c (general_insert_function): Likewise.
9330 * eval.c (struct backtrace.nargs, interactive_p)
9331 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9332 (funcall_lambda, mark_backtrace): Likewise.
9333 * fns.c (concat): Likewise.
9334 * frame.c (x_set_frame_parameters): Likewise.
9335 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9336 0 if not found, not -1. All callers changed.
9338 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9339 (stack_copy_size): Now size_t, not int.
9340 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9342 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9344 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9345 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9346 All callers changed.
9348 * lisp.h (multibyte_char_to_unibyte):
9349 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9350 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9351 * character.h (CHAR_TO_BYTE8):
9352 * cmds.c (internal_self_insert):
9353 * editfns.c (general_insert_function):
9354 * keymap.c (push_key_description):
9355 * search.c (Freplace_match):
9356 * xdisp.c (message_dolog, set_message_1): All callers changed.
9358 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9360 * keyboard.c (safe_run_hook_funcall): New function.
9361 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9362 don't set the hook to nil, but remove the offending function instead.
9363 (Qcommand_hook_internal): Remove, unused.
9364 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9365 Vcommand_hook_internal.
9367 * eval.c (enum run_hooks_condition): Remove.
9368 (funcall_nil, funcall_not): New functions.
9369 (run_hook_with_args): Call each function through a `funcall' argument.
9370 Remove `cond' argument, now redundant.
9371 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9372 (Frun_hook_with_args_until_failure): Adjust accordingly.
9373 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9375 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9377 * dispextern.h (string_buffer_position): Remove declaration.
9379 * print.c (strout): Remove parameter `multibyte', unused since
9380 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9382 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9383 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9384 All callers changed.
9386 * w32.c (_wsa_errlist): Use braces for struct initializers.
9388 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9389 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9390 All callers changed.
9391 (string_buffer_position): Likewise. Also, make static (it's never
9392 used outside xdisp.c).
9393 (cursor_row_p): Remove parameter `w', unused since
9394 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9395 (decode_mode_spec): Remove parameter `precision', introduced during
9396 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9397 All callers changed.
9399 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9401 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9403 2011-03-27 Anders Lindgren <andlind@gmail.com>
9405 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9406 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9407 (ns_update_auto_hide_menu_bar): New functions.
9408 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9409 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9410 ns_constrain_all_frames.
9411 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9412 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9414 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9416 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9418 2011-03-27 Glenn Morris <rgm@gnu.org>
9420 * syssignal.h: Replace RETSIGTYPE with void.
9421 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9422 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9423 Replace SIGTYPE with void everywhere.
9424 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9425 * s/template.h (SIGTYPE): Remove commented out definition.
9427 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9429 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9430 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9432 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9434 * w32.c (read_unc_volume): Use parameter `henum', instead of
9435 global variable `wget_enum_handle'.
9437 * keymap.c (describe_vector): Remove parameters `indices' and
9438 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9439 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9441 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9443 * keyboard.c (timer_check): Remove parameter `do_it_now',
9444 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9445 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9446 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9448 * keyboard.c (read_char):
9449 * w32menu.c (w32_menu_display_help):
9450 * xmenu.c (show_help_event, menu_help_callback):
9451 Adjust calls to `show_help_echo'.
9453 * gtkutil.c (xg_maybe_add_timer):
9454 * keyboard.c (readable_events):
9455 * process.c (wait_reading_process_output):
9456 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9458 * insdel.c (adjust_markers_gap_motion):
9459 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9460 (gap_left, gap_right): Don't call it.
9462 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9464 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9465 incurred during fontification.
9467 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9469 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9470 (DEFVAR_PER_BUFFER): Don't pass it.
9472 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9473 (scrolling_window): Don't pass it.
9475 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9477 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9479 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9481 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9482 of variables specific to SELinux and computation of `encoded_absname'.
9484 * image.c (XPutPixel): Remove unused variable `height'.
9486 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9488 * unexw32.c (get_section_info): Remove unused variable `section'.
9490 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9491 (system_process_attributes): Remove unused variable `sess'.
9492 (sys_read): Remove unused variable `err'.
9494 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9495 (w32_wnd_proc): Remove unused variable `isdead'.
9496 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9497 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9498 (x_create_tip_frame): Remove unused variable `tem'.
9500 * w32inevt.c (w32_console_read_socket):
9501 Remove unused variable `no_events'.
9503 * w32term.c (x_draw_composite_glyph_string_foreground):
9504 Remove unused variable `width'.
9506 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9508 * w32term.c (x_set_glyph_string_clipping):
9509 Don't pass uninitialized region to CombineRgn.
9511 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9513 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9514 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9515 (Fx_close_connection): Remove unused variable `i'.
9517 * w32font.c (w32font_draw): Return number of glyphs.
9518 (w32font_open_internal): Remove unused variable `i'.
9519 (w32font_driver): Add missing initializer.
9521 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9522 (fill_in_menu): Remove unused variable `items_added'.
9524 * w32term.c (last_mouse_press_frame): Remove static global variable.
9525 (w32_clip_to_row): Remove unused variable `f'.
9526 (x_delete_terminal): Remove unused variable `i'.
9528 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9529 (NOTHING): Remove unused static global variable.
9530 (uniscribe_check_otf): Remove unused variable `table'.
9531 (uniscribe_font_driver): Add missing initializers.
9533 2011-03-23 Julien Danjou <julien@danjou.info>
9535 * term.c (Fsuspend_tty, Fresume_tty):
9536 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9537 * window.c (temp_output_buffer_show):
9538 * insdel.c (signal_before_change):
9539 * frame.c (Fhandle_switch_frame):
9540 * fileio.c (Fdo_auto_save):
9541 * emacs.c (Fkill_emacs):
9542 * editfns.c (save_excursion_restore):
9543 * cmds.c (internal_self_insert):
9544 * callint.c (Fcall_interactively):
9545 * buffer.c (Fkill_all_local_variables):
9546 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9548 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9549 unconditionally since it does the check itself.
9551 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9553 Fix more problems found by GCC 4.5.2's static checks.
9555 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9556 the first time through the loop, since we know p0 < p1 then.
9557 This also avoids a gcc -Wstrict-overflow warning.
9559 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9560 leading to a memory leak, possible in functions like
9561 load_charset_map_from_file that can allocate an unbounded number
9562 of objects (Bug#8318).
9564 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9565 that could (at least in theory) be that large.
9567 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9568 This is less likely to overflow, and avoids undefined behavior if
9569 overflow does occur. All callers changed. Use strtoul to scan
9570 for the unsigned long integer.
9571 (pint2hrstr): Simplify and tune code slightly.
9572 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9574 * scroll.c (do_scrolling): Work around GCC bug 48228.
9575 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9577 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9578 This also avoids a warning with gcc -Wstrict-overflow.
9579 (validate_x_resource_name): Simplify count usage.
9580 This also avoids a warning with gcc -Wstrict-overflow.
9582 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9585 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9587 * process.c (Fmake_network_process): Use socklen_t, not int,
9588 where POSIX says socklen_t is required in portable programs.
9589 This fixes a porting bug on hosts like 64-bit HP-UX, where
9590 socklen_t is wider than int (Bug#8277).
9591 (Fmake_network_process, server_accept_connection):
9592 (wait_reading_process_output, read_process_output):
9595 * process.c: Rename or move locals to avoid shadowing.
9596 (list_processes_1, Fmake_network_process):
9597 (read_process_output_error_handler, exec_sentinel_error_handler):
9598 Rename or move locals.
9599 (Fmake_network_process): Define label "retry_connect" only if needed.
9600 (Fnetwork_interface_info): Fix pointer signedness.
9601 (process_send_signal): Add cast to avoid pointer signedness problem.
9602 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9603 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9605 Make tparam.h and terminfo.c consistent.
9606 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9607 Include tparam.h instead, since it declares them.
9608 * cm.h (PC): Remove extern decl; tparam.h now does this.
9609 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9610 * terminfo.c: Include tparam.h, to check interfaces.
9611 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9612 (tparam): Adjust signature to match interface in tparam.h;
9613 this removes some undefined behavior. Check that outstring and len
9614 are zero, which they always are with Emacs.
9615 * tparam.h (PC, BC, UP): New extern decls.
9617 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9618 (xftfont_open): Rename locals to avoid shadowing.
9620 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9621 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9622 (OTF_TAG_SYM): Omit macro if not needed.
9623 (ftfont_list): Remove unused local.
9624 (get_adstyle_property, ftfont_pattern_entity):
9625 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9626 Rename locals to avoid shadowing.
9628 * xfont.c (xfont_list_family): Mark var as initialized.
9630 * xml.c (make_dom): Now static.
9632 * composite.c (composition_compute_stop_pos): Rename local to
9634 (composition_reseat_it): Remove unused locals.
9635 (find_automatic_composition, composition_adjust_point): Likewise.
9636 (composition_update_it): Mark var as initialized.
9637 (find_automatic_composition): Mark vars as initialized,
9638 with a FIXME (Bug#8290).
9640 character.h: Rename locals to avoid shadowing.
9641 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9642 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9643 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9644 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9647 * textprop.c (property_change_between_p): Remove; unused.
9649 * intervals.c (interval_start_pos): Now static.
9651 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9653 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9654 Rename locals to avoid shadowing.
9656 * sound.c (wav_play, au_play, Fplay_sound_internal):
9657 Fix pointer signedness.
9658 (alsa_choose_format): Remove unused local var.
9659 (wav_play): Initialize a variable to 0, to prevent undefined
9660 behavior (Bug#8278).
9662 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9664 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9666 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9667 clobbering (Bug#8298).
9668 * sysdep.c (sys_subshell): Likewise.
9669 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9671 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9672 This should get cleaned up, so that child_setup has the
9673 same signature on all platforms.
9675 * callproc.c (call_process_cleanup): Now static.
9676 (relocate_fd): Rename locals to avoid shadowing.
9678 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9680 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9681 not to be necessary, and produces flickering.
9683 2011-03-20 Glenn Morris <rgm@gnu.org>
9685 * config.in: Remove file.
9687 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9689 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9690 are now in src/globals.h.
9691 (syms_of_minibuf): Remove spurious & from previous change.
9693 2011-03-20 Leo Liu <sdl.web@gmail.com>
9695 * minibuf.c (completing-read-function): New variable.
9696 (completing-read-default): Rename from completing-read.
9697 (completing-read): Call completing-read-function.
9699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9701 * xfaces.c (Fx_load_color_file):
9702 Read color file from absolute filename (bug#8250).
9704 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9706 * makefile.w32-in: Update dependencies.
9708 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9710 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9712 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9714 Fix more problems found by GCC 4.5.2's static checks.
9716 * process.c (make_serial_process_unwind, send_process_trap):
9717 (sigchld_handler): Now static.
9719 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9720 That way, the code declares only the vars that it needs.
9721 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9722 * s/cygwin.h (PTY_ITERATION): Likewise.
9723 * s/darwin.h (PTY_ITERATION): Likewise.
9724 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9726 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9727 * process.c (allocate_pty): Don't declare stb unless it's needed.
9729 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9730 (CONSTANTLIM): Remove; unused.
9731 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9732 Define only if needed.
9734 * unexelf.c (unexec): Name an expression,
9735 to avoid gcc -Wbad-function-cast warning.
9736 Use a different way to cause a compilation error if anyone uses
9737 n rather than nn, a way that does not involve shadowing.
9738 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9740 * deps.mk (unexalpha.o): Remove; unused.
9742 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9743 * unexec.h: New file.
9744 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9745 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9747 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9748 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9749 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9750 Change as necessary to match prototype in unexec.h.
9752 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9754 (back_comment, skip_chars): Mark vars as initialized.
9756 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9757 Rename locals to avoid shadowing.
9759 * lread.c (read1): Rewrite so as not to use empty "else".
9760 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9762 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9764 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9765 warning when compiling print.c.
9767 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9768 instead of using an uninitialized var.
9769 (font_sort_entities): Mark var as initialized.
9771 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9773 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9774 pointers to constants.
9775 (font_parse_fcname): Remove unused vars.
9776 (font_delete_unmatched): Now static.
9777 (font_get_spec): Remove; unused.
9778 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9779 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9780 Rename or move locals to avoid shadowing.
9782 * fns.c (require_nesting_list, require_unwind): Now static.
9783 (Ffillarray): Rename locals to avoid shadowing.
9785 * floatfns.c (domain_error2): Define only if needed.
9786 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9788 * alloc.c (mark_backtrace): Move decl from here ...
9789 * lisp.h: ... to here, so that it can be checked.
9791 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9792 (Fdefvar): Rewrite so as not to use empty "else".
9793 (lisp_indirect_variable): Name an expression,
9794 to avoid gcc -Wbad-function-cast warning.
9795 (Fdefvar): Rename locals to avoid shadowing.
9797 * callint.c (quotify_arg, quotify_args): Now static.
9798 (Fcall_interactively): Rename locals to avoid shadowing.
9799 Use const pointer when appropriate.
9801 * lisp.h (get_system_name, get_operating_system_release):
9802 Move decls here, to check interfaces.
9803 * process.c (get_operating_system_release): Move decl to lisp.h.
9804 * xrdb.c (get_system_name): Likewise.
9805 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9806 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9807 some of which prompt warnings from gcc -Wbad-function-cast.
9808 (Fformat_time_string, Fencode_time, Finsert_char):
9809 (Ftranslate_region_internal, Fformat):
9810 Rename or remove local vars to avoid shadowing.
9811 (Ftranslate_region_internal): Mark var as initialized.
9813 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9816 * lisp.h (eassert): Check that the argument compiles, even if
9817 ENABLE_CHECKING is not defined.
9819 * data.c (Findirect_variable): Name an expression, to avoid
9820 gcc -Wbad-function-cast warning.
9821 (default_value, arithcompare, arith_driver, arith_error): Now static.
9822 (store_symval_forwarding): Rename local to avoid shadowing.
9823 (Fmake_variable_buffer_local, Fmake_local_variable):
9824 Mark variables as initialized.
9825 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9827 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9828 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9829 Rename locals to avoid shadowing.
9830 (mark_stack): Move local variables into the #ifdef region where
9832 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9833 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9835 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9836 (GC_STRING_CHARS): Remove; not used.
9837 (Fmemory_limit): Cast sbrk's returned value to char *.
9839 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9840 avoids undefined behavior in theory.
9842 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9844 Use functions, not macros, for up- and down-casing (Bug#8254).
9845 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9846 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9847 to use the following functions instead of these macros.
9848 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9849 EMACS_INT, since callers assume the returned value fits in int.
9850 (upcase1): Likewise, for UPCASE_TABLE.
9851 (uppercasep, lowercasep, upcase): New static inline functions.
9852 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9853 the race-condition problem in the old DOWNCASE.
9855 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9856 Rename locals to avoid shadowing.
9857 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9858 (regex_compile, re_search_2, re_match_2_internal):
9859 Remove unused local vars.
9860 (FREE_VAR): Rewrite so as not to use empty "else",
9861 which gcc can warn about.
9862 (regex_compile, re_match_2_internal): Mark locals as initialized.
9863 (RETALLOC_IF): Define only if needed.
9864 (WORDCHAR_P): Likewise. This one is never needed, but is used
9865 only in a comment talking about a compiler bug, so put inside
9866 the #if 0 of that comment.
9867 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9868 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9871 * search.c (boyer_moore): Rename locals to avoid shadowing.
9872 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9873 (PREV_CHAR_BOUNDARY): Likewise.
9875 * search.c (simple_search): Remove unused var.
9877 * dired.c (compile_pattern): Move decl from here ...
9878 * lisp.h: ... to here, so that it can be checked.
9879 (struct re_registers): New forward decl.
9881 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9883 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9885 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9886 Rename locals to avoid shadowing.
9887 (Fvertical_motion): Mark locals as initialized.
9889 * casefiddle.c (casify_object, casify_region): Now static.
9890 (casify_region): Mark local as initialized.
9892 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9894 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9895 New macros, so that the caller can use some names other than
9896 gcpro1, gcpro2, etc.
9897 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9899 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9900 argument, for consistency with GCPRO2_VAR, etc: it is now the
9901 prefix of the variable, not the variable itself. All uses
9903 * dired.c (directory_files_internal, file_name_completion):
9904 Rename locals to avoid shadowing.
9906 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9907 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9908 dired.c's scmp function, had undefined behavior.
9909 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9910 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9911 * buffer.h: ... to here, because these macros use current_buffer,
9912 and the new implementation with inline functions needs to have
9913 current_buffer in scope now, rather than later when the macros
9915 (downcase, upcase1): New static inline functions.
9916 (DOWNCASE, UPCASE1): Reimplement using these functions.
9917 This avoids undefined behavior in expressions like
9918 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9919 from race conditions in accessing the global variables
9920 case_temp1 and case_temp2.
9921 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9922 * lisp.h (case_temp1, case_temp2): Remove their decls.
9923 * character.h (ASCII_CHAR_P): Move from here ...
9924 * lisp.h: ... to here, so that the inline functions mentioned
9927 * dired.c (directory_files_internal_unwind): Now static.
9929 * fileio.c (file_name_as_directory, directory_file_name):
9930 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9932 (file_name_as_directory): Use const pointers when appropriate.
9933 (Fexpand_file_name): Likewise. In particular, newdir might
9934 point at constant storage, so make it a const pointer.
9935 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9936 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9938 (Fset_file_times, Finsert_file_contents, auto_save_error):
9939 Rename locals to avoid shadowing.
9941 * minibuf.c (choose_minibuf_frame_1): Now static.
9942 (Ftry_completion, Fall_completions): Rename or remove locals
9945 * marker.c (bytepos_to_charpos): Remove; unused.
9947 * lisp.h (verify_bytepos, count_markers): New decls,
9948 so that gcc does not warn that these functions aren't declared.
9950 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9951 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9952 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9953 (copy_text): Remove unused local var.
9955 * filelock.c (within_one_second): Now static.
9956 (lock_file_1): Rename local to avoid shadowing.
9958 * buffer.c (fix_overlays_before): Mark locals as initialized.
9959 (fix_start_end_in_overlays): Likewise. This function should be
9960 simplified by using pointers-to-pointers, but that's a different
9962 (switch_to_buffer_1): Now static.
9963 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9964 (report_overlay_modification): Rename locals to avoid shadowing.
9966 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9967 Fix pointer signedness issue.
9968 (sys_subshell): Mark local as volatile if checking for lint,
9969 to suppress a gcc -Wclobbered warning that does not seem to be right.
9970 (MAXPATHLEN): Define only if needed.
9972 * process.c (serial_open, serial_configure): Move decls from here ...
9973 * systty.h: ... to here, so that they can be checked.
9975 * fns.c (get_random, seed_random): Move extern decls from here ...
9976 * lisp.h: ... to here, so that they can be checked.
9978 * sysdep.c (reset_io): Now static.
9979 (wait_for_termination_signal): Remove; unused.
9981 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9982 (copy_keymap_item, append_key, push_text_char_description):
9984 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9985 (DENSE_TABLE_SIZE): Remove; unused.
9986 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9987 (describe_map_tree):
9988 Rename locals to avoid shadowing.
9990 * keyboard.c: Declare functions static if they are not used elsewhere.
9991 (echo_char, echo_dash, cmd_error, top_level_2):
9992 (poll_for_input, handle_async_input): Now static.
9993 (read_char, kbd_buffer_get_event, make_lispy_position):
9994 (make_lispy_event, make_lispy_movement, apply_modifiers):
9995 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9996 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9997 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9998 (read_key_sequence, read_char): Mark locals as initialized.
9999 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10001 * keyboard.h (make_ctrl_char): New decl.
10002 (mark_kboards): Move decl here ...
10003 * alloc.c (mark_kboards): ... from here.
10005 * lisp.h (force_auto_save_soon): New decl.
10007 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10008 (DEFINE_DUMMY_FUNCTION): New macro.
10009 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10011 (main): Add casts to avoid warnings
10012 if GCC considers string literals to be constants.
10014 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10016 * dbusbind.c: Pointer signedness fixes.
10017 (xd_signature, xd_append_arg, xd_initialize):
10018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10019 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10020 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10021 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10023 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10024 if GCC considers string literals to be constants.
10025 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10027 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10029 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10030 (print_preprocess, print_object): New macro to fix last change.
10032 * print.c (print_preprocess): Don't forget font objects.
10034 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10036 * emacs.c (USAGE3): Doc fixes.
10038 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10040 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10043 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10045 * lisp.h (VWindow_system, Qfile_name_history):
10046 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10047 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10048 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10050 * w32select.c: Don't #include "keyboard.h".
10051 (run_protected): Add extern declaration for waiting_for_input.
10053 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10054 * w32console.c (detect_input_pending, read_input_pending)
10055 (encode_terminal_code):
10056 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10057 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10058 (w32_system_caret_y, Qfile_name_history):
10059 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10060 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10061 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10062 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10063 * w32proc.c (Qlocal, report_file_error):
10064 * w32term.c (Vwindow_system, updating_frame):
10065 * w32uniscribe.c (initialized, uniscribe_font_driver):
10066 Remove unneeded extern declarations.
10068 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10070 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10072 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10074 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10075 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10076 These macros can no longer be used for assignment.
10078 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10079 Assign struct members directly, instead of using BUF_BEGV etc.
10080 (record_buffer_markers, fetch_buffer_markers): New functions for
10081 recording and fetching special buffer markers.
10082 (set_buffer_internal_1, set_buffer_temp): Use them.
10084 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10086 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10088 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10089 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10091 * xdisp.c (hscroll_window_tree):
10092 (reconsider_clip_changes): Use PT instead of BUF_PT.
10094 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10096 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10097 $(EMACS_ROOT)/lib/intprops.h.
10099 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10101 Fix more problems found by GCC 4.5.2's static checks.
10103 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10104 to unsigned char * to avoid compiler diagnostic.
10105 (xg_free_frame_widgets): Make it clear that a local variable is
10106 needed only if USE_GTK_TOOLTIP.
10107 (gdk_window_get_screen): Make it clear that this macro is needed
10108 only if USE_GTK_TOOLTIP.
10109 (int_gtk_range_get_value): New function, which avoids a diagnostic
10110 from gcc -Wbad-function-cast.
10111 (xg_set_toolkit_scroll_bar_thumb): Use it.
10112 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10113 diagnostic from gcc -Wbad-function-cast.
10114 (get_utf8_string, xg_get_file_with_chooser):
10115 Rename locals to avoid shadowing.
10116 (create_dialog): Move locals to avoid shadowing.
10118 * xgselect.c (xg_select): Remove unused var.
10120 * image.c (four_corners_best): Mark locals as initialized.
10121 (gif_load): Initialize transparent_p to zero (Bug#8238).
10122 Mark another local as initialized.
10123 (my_png_error, my_error_exit): Mark with NO_RETURN.
10125 * image.c (clear_image_cache): Now static.
10126 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10127 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10128 (x_edge_detection): Remove unnecessary cast that
10129 gcc -Wbad-function-cast diagnoses.
10130 (gif_load): Fix pointer signedness.
10131 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10132 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10134 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10136 Improve quality of tests for time stamp overflow.
10137 For example, without this patch (encode-time 0 0 0 1 1
10138 1152921504606846976) returns the obviously-bogus value (-948597
10139 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10140 reports time overflow. See
10141 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10142 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10143 * editfns.c: Include limits.h and intprops.h.
10144 (TIME_T_MIN, TIME_T_MAX): New macros.
10145 (time_overflow): Move earlier, to before first use.
10146 (hi_time, lo_time): New functions, for an accurate test for
10147 out-of-range times.
10148 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10149 (Fget_internal_run_time): Don't assume time_t fits in int.
10150 (make_time): Use list2 instead of Fcons twice.
10151 (Fdecode_time): More accurate test for out-of-range times.
10152 (check_tm_member): New function.
10153 (Fencode_time): Use it, to test for out-of-range times.
10154 (lisp_time_argument): Don't rely on undefined left-shift and
10155 right-shift behavior when checking for time stamp overflow.
10157 * editfns.c (time_overflow): New function, refactoring common code.
10158 (Fformat_time_string, Fdecode_time, Fencode_time):
10159 (Fcurrent_time_string): Use it.
10161 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10162 * dired.c (make_time): Move to ...
10163 * editfns.c (make_time): ... here.
10164 * systime.h: Note the move.
10166 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10168 * fringe.c (update_window_fringes): Remove unused variables.
10170 * unexmacosx.c (copy_data_segment): Also copy __got section.
10173 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10175 * termcap.c [MSDOS]: Include "msdos.h".
10176 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10177 Constify `char *' arguments and their references according to
10178 prototypes in tparam.h.
10180 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10182 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10183 Adapt all references accordingly.
10185 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10187 2011-03-11 Tom Tromey <tromey@redhat.com>
10189 * buffer.c (syms_of_buffer): Remove obsolete comment.
10191 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10193 * termhooks.h (encode_terminal_code): Declare prototype.
10195 * msdos.c (encode_terminal_code): Don't declare prototype.
10197 * term.c (encode_terminal_code): Now external again, used by
10198 w32console.c and msdos.c.
10200 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10201 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10203 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10205 Fix some minor problems found by GCC 4.5.2's static checks.
10207 * fringe.c (update_window_fringes): Mark locals as initialized
10209 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10211 * alloc.c (mark_fringe_data): Move decl from here ...
10212 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10213 to check its interface.
10214 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10216 * fontset.c (free_realized_fontset): Now static.
10217 (Fset_fontset_font): Rename local to avoid shadowing.
10218 (fontset_font): Mark local as initialized.
10219 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10221 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10223 * xselect.c (x_disown_buffer_selections): Remove; not used.
10224 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10225 (x_own_selection, Fx_disown_selection_internal): Rename locals
10226 to avoid shadowing.
10227 (x_handle_dnd_message): Remove local to avoid shadowing.
10229 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10230 so that the caller can use some name other than gcpro1.
10231 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10232 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10233 (Fx_backspace_delete_keys_p):
10234 Use them to avoid shadowing, and rename vars to avoid shadowing.
10235 (x_decode_color, x_set_name, x_window): Now static.
10236 (Fx_create_frame): Add braces to silence GCC warning.
10237 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10238 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10239 Remove unused locals.
10240 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10241 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10242 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10245 * xterm.h (x_mouse_leave): New decl.
10247 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10248 Remove unused functions.
10249 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10250 (x_calc_absolute_position): Now static.
10251 (XTread_socket): Don't define label "out" unless it's used.
10252 Don't declare local "event" unless it's used.
10253 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10254 unless they are used.
10255 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10256 (x_fatal_error_signal): Remove; not used.
10257 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10258 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10259 (x_error_catcher, x_connection_closed, x_error_handler):
10260 (x_error_quitter, xembed_send_message, x_iconify_frame):
10261 (my_log_handler): Rename locals to avoid shadowing.
10262 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10263 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10265 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10266 Rename or move locals to avoid shadowing.
10267 (tty_defined_color, merge_face_heights): Now static.
10268 (free_realized_faces_for_fontset): Remove; not used.
10269 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10270 does not deduce is never used uninitialized.
10271 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10272 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10274 * terminal.c (store_terminal_param): Now static.
10276 * xmenu.c (menu_highlight_callback): Now static.
10277 (set_frame_menubar): Remove unused local.
10278 (xmenu_show): Rename parameter to avoid shadowing.
10279 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10280 since they might point to immutable storage.
10281 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10282 since it's unused otherwise.
10284 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10285 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10286 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10287 avoids a gcc -Wuninitialized diagnostic.
10288 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10289 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10290 does not deduce are never used uninitialized.
10292 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10294 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10295 * window.c (window_loop, size_window):
10296 (run_window_configuration_change_hook, enlarge_window): Likewise.
10298 * window.c (display_buffer): Now static.
10299 (size_window): Mark variables that gcc -Wuninitialized
10300 does not deduce are never used uninitialized.
10301 * window.h (check_all_windows): New decl, to forestall
10302 gcc -Wmissing-prototypes diagnostic.
10303 * dispextern.h (bidi_dump_cached_states): Likewise.
10305 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10307 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10308 Include <limits.h>.
10309 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10310 and to avoid gcc -Wuninitialized warning.
10311 (load_charset_map): Mark variables that gcc -Wuninitialized
10312 does not deduce are never used uninitialized.
10313 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10315 * coding.c (coding_set_source, coding_set_destination):
10316 Use "else { /* comment */ }" rather than "else /* comment */;"
10317 for clarity, and to avoid gcc -Wempty-body warning.
10318 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10319 a block, when the outer 'i' will do.
10320 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10321 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10322 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10323 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10324 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10325 Rename locals to avoid shadowing.
10326 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10327 * coding.c (emacs_mule_char, encode_invocation_designation):
10328 Now static, since they're not used elsewhere.
10329 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10330 (decode_coding_object, encode_coding_object, detect_coding_system):
10331 (decode_coding_emacs_mule): Mark variables that gcc
10332 -Wuninitialized does not deduce are never used uninitialized.
10333 (detect_coding_iso_2022): Initialize a local variable that might
10334 be used uninitialized. Leave a FIXME because it's not clear that
10335 this initialization is needed. (Bug#8211)
10336 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10337 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10338 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10339 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10340 Remove unused macros.
10342 * category.c (hash_get_category_set): Remove unused local var.
10343 (copy_category_table): Now static, since it's not used elsewhere.
10344 * character.c (string_count_byte8): Likewise.
10346 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10347 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10349 * chartab.c (copy_sub_char_table): Now static, since it's not used
10351 (sub_char_table_ref_and_range, char_table_ref_and_range):
10352 Rename locals to avoid shadowing.
10353 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10355 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10356 (BIDI_BOB): Remove unused macro.
10358 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10359 deduce are never used uninitialized.
10360 * term.c (encode_terminal_code): Likewise.
10362 * term.c (encode_terminal_code): Now static. Remove unused local.
10364 * tparam.h: New file.
10365 * term.c, tparam.h: Include it.
10366 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10367 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10368 Move these decls to tparam.h, and make them agree with what
10369 is actually in tparam.c. The previous trick of using incompatible
10370 decls in different modules does not conform to the C standard.
10371 All callers of tparam changed to use tparam's actual API.
10372 * tparam.c (tparam1, tparam, tgoto):
10373 Use const pointers where appropriate.
10375 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10376 * cm.h (struct cm): Likewise.
10377 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10378 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10379 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10380 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10381 (turn_on_face, init_tty): Likewise.
10382 * termchar.h (struct tty_display_info): Likewise.
10384 * term.c (term_mouse_position): Rename local to avoid shadowing.
10386 * alloc.c (mark_ttys): Move decl from here ...
10387 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10389 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10391 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10393 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10395 * search.c (compile_pattern_1): Remove argument regp, unused since
10396 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10397 (compile_pattern): Don't pass it.
10399 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10401 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10402 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10404 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10406 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10408 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10409 gdk_window_get_screen, gdk_window_get_geometry,
10410 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10411 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10412 (xg_get_pixbuf_from_pixmap): New function.
10413 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10414 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10415 Call xg_get_pixbuf_from_pixmap instead of
10416 gdk_pixbuf_get_from_drawable.
10417 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10418 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10419 (xg_check_special_colors): Use GtkStyleContext and its functions
10421 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10422 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10423 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10424 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10425 Call gtk_widget_get_preferred_size.
10426 (xg_frame_resized): gdk_window_get_geometry only takes 5
10428 (xg_win_to_widget, xg_event_is_for_menubar):
10429 Call gdk_x11_window_lookup_for_display.
10430 (xg_set_widget_bg): New function.
10431 (delete_cb): New function.
10432 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10433 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10434 (xg_set_background_color): Call xg_set_widget_bg.
10435 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10436 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10437 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10438 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10440 (update_frame_tool_bar): Call gtk_widget_hide.
10441 (xg_initialize): Use GDK_KEY_g.
10443 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10445 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10447 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10448 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10449 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10451 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10453 * w32xfns.c (select_palette): Check success of RealizePalette against
10454 GDI_ERROR, not zero.
10456 See ChangeLog.11 for earlier changes.
10458 ;; Local Variables:
10462 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10464 This file is part of GNU Emacs.
10466 GNU Emacs is free software: you can redistribute it and/or modify
10467 it under the terms of the GNU General Public License as published by
10468 the Free Software Foundation, either version 3 of the License, or
10469 (at your option) any later version.
10471 GNU Emacs is distributed in the hope that it will be useful,
10472 but WITHOUT ANY WARRANTY; without even the implied warranty of
10473 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10474 GNU General Public License for more details.
10476 You should have received a copy of the GNU General Public License
10477 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.