1 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.c (struct sortvec.priority, struct sortstr.priority):
4 Now EMACS_INT, not int.
5 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
11 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13 Improve buffer-overflow checking (Bug#8873).
14 * fileio.c (Finsert_file_contents):
15 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
16 Remove the old (too-loose) buffer overflow checks.
17 They weren't needed, since make_gap checks for buffer overflow.
18 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
19 The old code merely checked for Emacs fixnum overflow, and relied
20 on undefined (wraparound) behavior. The new code avoids undefined
21 behavior, and also checks for ptrdiff_t and/or size_t overflow.
23 * editfns.c (Finsert_char): Don't dump core with very negative counts.
24 Tune. Don't use wider integers than needed. Don't use alloca.
25 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
27 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
29 * insdel.c, lisp.h (buffer_overflow): New function.
30 (insert_from_buffer_1, replace_range, replace_range_2):
31 * insdel.c (make_gap_larger):
32 * editfns.c (Finsert_char):
33 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
35 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
37 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
39 Integer overflow and signedness fixes (Bug#8873).
41 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
42 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
44 * fileio.c: Don't assume EMACS_INT fits in off_t.
45 (emacs_lseek): New static function.
46 (Finsert_file_contents, Fwrite_region): Use it.
47 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
49 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
51 * fns.c: Don't overflow int when computing a list length.
52 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
53 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
54 truncation on 64-bit hosts. Check for QUIT every
55 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
56 faster and is responsive enough.
57 (Flength): Report an error instead of overflowing an integer.
58 (Fsafe_length): Return a float if the value is not representable
59 as a fixnum. This shouldn't happen except in contrived situations.
60 (Fnthcdr, Fsort): Don't assume list length fits in int.
61 (Fcopy_sequence): Don't assume vector length fits in int.
63 * alloc.c: Check that resized vectors' lengths fit in fixnums.
64 (header_size, word_size): New constants.
65 (allocate_vectorlike): Don't check size overflow here.
66 (allocate_vector): Check it here instead, since this is the only
67 caller of allocate_vectorlike that could cause overflow.
68 Check that the new vector's length is representable as a fixnum.
70 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
71 The previous code was bogus. For example, next_almost_prime (32)
72 returned 39, which is undesirable as it is a multiple of 3; and
73 next_almost_prime (24) returned 25, which is a multiple of 5 so
74 why was the code bothering to check for multiples of 7?
76 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
78 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
80 Variadic C functions now count arguments with ptrdiff_t.
81 This partly undoes my 2011-03-30 change, which replaced int with size_t.
82 Back then I didn't know that the Emacs coding style prefers signed int.
83 Also, in the meantime I found a few more instances where arguments
84 were being counted with int, which may truncate counts on 64-bit
85 machines, or EMACS_INT, which may be unnecessarily wide.
86 * lisp.h (struct Lisp_Subr.function.aMANY)
87 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
88 Arg counts are now ptrdiff_t, not size_t.
89 All variadic functions and their callers changed accordingly.
90 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
91 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
92 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
93 * callint.c (Fcall_interactively): Check arg count for overflow,
94 to avoid potential buffer overrun. Use signed char, not 'int',
95 for 'varies' array, so that we needn't bother to check its size
96 calculation for overflow.
97 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
98 * eval.c (apply_lambda):
99 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
100 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
101 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
103 * callint.c (Fcall_interactively): Don't use index var as event count.
105 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
106 * mem-limits.h (SIZE): Remove; no longer used.
108 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
110 Remove unnecessary casts.
111 * xterm.c (x_term_init):
112 * xfns.c (x_set_border_pixel):
113 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
114 These aren't needed now that we assume ANSI C.
116 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
117 It's more likely to cause problems (due to unsigned overflow)
120 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
122 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
124 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
126 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
128 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
130 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
132 GLYPH_CODE_FACE returns EMACS_INT, not int.
133 * dispextern.h (merge_faces):
134 * xfaces.c (merge_faces):
135 * xdisp.c (get_next_display_element, next_element_from_display_vector):
136 Don't assume EMACS_INT fits in int.
138 * character.h (CHAR_VALID_P): Remove unused parameter.
139 * fontset.c, lisp.h, xdisp.c: All uses changed.
141 * editfns.c (Ftranslate_region_internal): Omit redundant test.
143 * fns.c (concat): Minor tuning based on overflow analysis.
144 This doesn't fix any bugs. Use int to hold character, instead
145 of constantly refetching from Emacs object. Use XFASTINT, not
146 XINT, for value known to be a character. Don't bother comparing
147 a single byte to 0400, as it's always less.
149 * floatfns.c (Fexpt):
150 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
152 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
155 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
157 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
158 Without this fix, on a 64-bit host (aset S 0 4294967386) would
159 incorrectly succeed when S was a string, because 4294967386 was
160 truncated before it was used.
162 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
163 Otherwise, an out-of-range integer could cause undefined behavior
166 * composite.c: Use int, not EMACS_INT, for characters.
167 (fill_gstring_body, composition_compute_stop_pos): Use int, not
168 EMACS_INT, for values that are known to be in character range.
169 This doesn't fix any bugs but is the usual style inside Emacs and
170 may generate better code on 32-bit machines.
172 Make sure a 64-bit char is never passed to ENCODE_CHAR.
173 This is for reasons similar to the recent CHAR_STRING fix.
174 * charset.c (Fencode_char): Check that character arg is actually
175 a character. Pass an int to ENCODE_CHAR.
176 * charset.h (ENCODE_CHAR): Verify that the character argument is no
177 wider than 'int', as a compile-time check to prevent future regressions
180 * character.c (char_string): Remove unnecessary casts.
182 Make sure a 64-bit char is never passed to CHAR_STRING.
183 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
184 by silently ignoring the top 32 bits, allowing some values
185 that were far too large to be valid characters.
186 * character.h: Include <verify.h>.
187 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
188 arguments are no wider than unsigned, as a compile-time check
189 to prevent future regressions in this area.
191 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
192 (Fsubst_char_in_region):
194 * xdisp.c (decode_mode_spec_coding):
195 Adjust to CHAR_STRING's new requirement.
196 * editfns.c (Finsert_char, Fsubst_char_in_region):
197 * fns.c (concat): Check that character args are actually
198 characters. Without this test, these functions did the wrong
199 thing with wildly out-of-range values on 64-bit hosts.
201 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
202 These casts should not be needed on 32-bit hosts, either.
203 * keyboard.c (read_char):
204 * lread.c (Fload): Remove casts to unsigned.
206 * lisp.h (UNSIGNED_CMP): New macro.
207 This fixes comparison bugs on 64-bit hosts.
208 (ASCII_CHAR_P): Use it.
209 * casefiddle.c (casify_object):
210 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
211 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
212 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
213 * dispextern.h (FACE_FROM_ID):
214 * keyboard.c (read_char): Use UNSIGNED_CMP.
216 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
217 not to EMACS_INT, to avoid GCC warning.
219 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
221 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
222 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
223 isn't needed on 32-bit machines.
225 * buffer.c (Fgenerate_new_buffer_name):
226 Use EMACS_INT for count, not int.
227 (advance_to_char_boundary): Return EMACS_INT, not int.
229 * data.c (Qcompiled_function): Now static.
231 * window.c (window_body_lines): Now static.
233 * image.c (gif_load): Rename local to avoid shadowing.
235 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
236 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
237 * alloc.c (make_save_value): Integer argument is now of type
239 (mark_object): Use ptrdiff_t, not int.
240 * lisp.h (pD): New macro.
241 * print.c (print_object): Use it.
243 * alloc.c: Use EMACS_INT, not int, to count objects.
244 (total_conses, total_markers, total_symbols, total_vector_size)
245 (total_free_conses, total_free_markers, total_free_symbols)
246 (total_free_floats, total_floats, total_free_intervals)
247 (total_intervals, total_strings, total_free_strings):
248 Now EMACS_INT, not int. All uses changed.
249 (Fgarbage_collect): Compute overall total using a double, so that
250 integer overflow is less likely to be a problem. Check for overflow
251 when converting back to an integer.
252 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
253 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
254 These were 'int' variables that could overflow on 64-bit hosts;
255 they were never used, so remove them instead of repairing them.
256 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
257 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
258 Previously, this ceilinged at INT_MAX, but that doesn't work on
260 (allocate_pseudovector): Don't use EMACS_INT when int would do.
262 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
263 (allocate_vectorlike): Check for ptrdiff_t overflow.
264 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
265 when a (possibly-narrower) signed value would do just as well.
266 We prefer using signed arithmetic, to avoid comparison confusion.
268 * alloc.c: Catch some string size overflows that we were missing.
269 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
270 for convenience in STRING_BYTES_MAX.
271 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
272 The definition here is exact; the one in lisp.h was approximate.
273 (allocate_string_data): Check for string overflow. This catches
274 some instances we weren't catching before. Also, it catches
275 size_t overflow on (unusual) hosts where SIZE_MAX <= min
276 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
277 and ptrdiff_t and EMACS_INT are both 64 bits.
279 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
280 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
281 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
283 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
285 * alloc.c (Fmake_string): Check for out-of-range init.
287 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
289 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
291 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
293 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
294 xg_get_default_scrollbar_width.
296 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
297 (int_gtk_range_get_value): Move to the scroll bar part of the file.
298 (style_changed_cb): Call update_theme_scrollbar_width and call
299 x_set_scroll_bar_default_width and xg_frame_set_char_size for
300 all frames (Bug#8505).
301 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
302 Call gtk_window_set_resizable if HAVE_GTK3.
303 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
304 and height if HAVE_GTK3 (Bug#8505).
305 (scroll_bar_width_for_theme): New variable.
306 (update_theme_scrollbar_width): New function.
307 (xg_get_default_scrollbar_width): Move code to
308 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
309 (xg_initialize): Call update_theme_scrollbar_width.
311 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
313 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
315 2011-06-12 Martin Rudalics <rudalics@gmx.at>
317 * frame.c (make_frame): Call other_buffer_safely instead of
320 * window.c (temp_output_buffer_show): Call display_buffer with
321 second argument Vtemp_buffer_show_specifiers and reset latter
322 immediately after the call.
323 (Vtemp_buffer_show_specifiers): New variable.
324 (auto_window_vscroll_p, next_screen_context_lines)
325 (Vscroll_preserve_screen_position): Remove leading asterisks from
328 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
330 Fix minor problems found by GCC 4.6.0 static checking.
331 * buffer.c (Qclone_number): Remove for now, as it's unused.
332 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
333 (record_buffer): Remove unused local.
334 * frame.c (other_visible_frames, frame_buffer_list): Now static.
335 (set_frame_buffer_list): Remove; unused.
336 * frame.h (other_visible_frames): Remove decl.
337 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
338 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
339 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
341 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
342 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
343 Define only if HAVE_GPM.
344 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
345 (update_hints_inhibit): Remove; never set. All uses removed.
346 * widgetprv.h (emacsFrameClassRec): Remove decl.
347 * window.c (delete_deletable_window): Now returns void, since it
348 wasn't returning anything.
349 (compare_window_configurations): Remove unused locals.
350 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
351 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
352 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
353 the same widths as pointers. This follows up on the 2011-05-06 patch.
354 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
356 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
358 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
360 * makefile.w32-in: Update dependencies.
361 (LISP_H): Add lib/intprops.h.
363 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
365 * image.c (gif_load): Add animation frame delay to the metadata.
366 (syms_of_image): Use DEFSYM. New symbol `delay'.
368 2011-06-11 Martin Rudalics <rudalics@gmx.at>
370 * window.c (delete_deletable_window): Re-add.
371 (Fset_window_configuration): Rewrite to handle dead buffers and
372 consequently deletable windows.
373 (window_tree, Fwindow_tree): Remove. Supply functionality in
375 (compare_window_configurations): Simplify code.
377 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
379 * image.c (imagemagick_load_image): Fix type mismatch.
380 (Fimagemagick_types): Likewise.
382 * window.h (replace_buffer_in_windows): Declare.
384 2011-06-11 Martin Rudalics <rudalics@gmx.at>
386 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
387 Qclone_number. Remove external declaration of Qdelete_window.
388 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
390 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
391 Qbuffer_list_update_hook if allowed.
392 (Fother_buffer): Rewrite doc-string. Major rewrite for new
393 buffer list implementation.
394 (other_buffer_safely): New function.
395 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
396 calls to replace_buffer_in_windows and
397 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
399 (record_buffer): Inhibit quitting and rewrite using quittable
400 functions. Run Qbuffer_list_update_hook if allowed.
401 (Frecord_buffer, Funrecord_buffer): New functions.
402 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
403 switch-to-buffer to window.el.
404 (bury-buffer): Move to window.el.
405 (Vbuffer_list_update_hook): New variable.
407 * lisp.h (other_buffer_safely): Add prototype in buffer.c
410 * window.h (resize_frame_windows): Move up in code.
411 (Fwindow_frame): Remove EXFUN.
412 (replace_buffer_in_all_windows): Remove prototype.
413 (replace_buffer_in_windows_safely): Add prototype.
415 * window.c: Declare Qdelete_window static again. Move down
416 declaration of select_count.
417 (Fnext_window, Fprevious_window): Rewrite doc-strings.
418 (Fother_window): Move to window.el.
419 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
420 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
421 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
423 (replace_buffer_in_windows): Implement by calling
424 Qreplace_buffer_in_windows.
425 (replace_buffer_in_all_windows): Remove with some functionality
426 moved into replace_buffer_in_windows_safely.
427 (replace_buffer_in_windows_safely): New function.
428 (select_window_norecord, select_frame_norecord): Move in front
429 of run_window_configuration_change_hook. Remove now obsolete
431 (Fset_window_buffer): Rewrite doc-string. Call
432 Qrecord_window_buffer.
433 (keys_of_window): Move binding for other-window to window.el.
435 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
437 * dispextern.h (struct image): Replace data member, whose int_val
438 and ptr_val fields were not used by anything, with a single
441 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
442 (gif_clear_image, gif_load, imagemagick_load_image)
443 (gs_clear_image, gs_load): Callers changed.
445 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
447 * buffer.h: Include <time.h>, for time_t.
448 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
450 Fix minor problems found by static checking.
452 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
454 Make identifiers static if they are not used in other modules.
455 * data.c (Qcompiled_function, Qframe, Qvector):
456 * image.c (QimageMagick, Qsvg):
457 * minibuf.c (Qmetadata):
458 * window.c (resize_window_check, resize_root_window): Now static.
459 * window.h (resize_window_check, resize_root_window): Remove decls.
461 * window.c (window_deletion_count, delete_deletable_window):
463 (window_body_lines): Now static.
464 (Fdelete_other_windows_internal): Mark vars as initialized.
465 Make sure 'resize_failed' is initialized.
466 (run_window_configuration_change_hook): Rename local to avoid shadowing.
467 (resize_window_apply): Remove unused local.
468 * window.h (delete_deletable_window): Remove decl.
470 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
471 (imagemagick_load_image): Fix pointer signedness problem by changing
472 last arg from unsigned char * to char *. All uses changed.
473 Also, fix a local for similar reasons.
474 Remove unused locals. Remove locals to avoid shadowing.
475 (fn_rsvg_handle_free): Remove; unused.
476 (svg_load, svg_load_image): Fix pointer signedness problem.
477 (imagemagick_load_image): Don't use garbage pointer image_wand.
479 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
481 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
483 * image.c (gif_load): Fix omitted cast error introduced by
486 2011-06-10 Martin Rudalics <rudalics@gmx.at>
488 * window.h (resize_proportionally, orig_total_lines)
489 (orig_top_line): Remove from window structure.
490 (set_window_height, set_window_width, change_window_heights)
491 (Fdelete_window): Remove prototypes.
492 (resize_frame_windows): Remove duplicate declaration.
494 2011-06-10 Eli Zaretskii <eliz@gnu.org>
496 * window.h (resize_frame_windows, resize_window_check)
497 (delete_deletable_window, resize_root_window)
498 (resize_frame_windows): Declare prototypes.
500 * window.c (resize_window_apply): Make definition be "static" to
503 2011-06-10 Martin Rudalics <rudalics@gmx.at>
505 * window.c: Remove declarations of Qwindow_size_fixed,
506 window_min_size_1, window_min_size_2, window_min_size,
507 size_window, window_fixed_size_p, enlarge_window, delete_window.
508 Remove static from declaration of Qdelete_window, it's
509 temporarily needed by Fbury_buffer.
510 (replace_window): Don't assign orig_top_line and
512 (Fdelete_window, delete_window): Remove. Window deletion is
513 handled by window.el.
514 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
515 Fdelete_window calls with calls to Qdelete_window.
516 (Fdelete_other_windows): Remove. Deleting other windows is
517 handled by window.el.
518 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
519 handled in window.el.
520 (window_min_size_2, window_min_size_1, window_min_size): Remove.
521 Window minimum sizes are handled in window.el.
522 (shrink_windows, size_window, set_window_height)
523 (set_window_width, change_window_heights, window_height)
524 (window_width, CURBEG, CURSIZE, enlarge_window)
525 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
526 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
527 handled in window.el.
528 (make_dummy_parent): Rename to make_parent_window and give it a
529 second argument horflag.
530 (make_window): Don't set resize_proportionally any more.
531 (Fsplit_window): Remove. Windows are split in window.el.
532 (save_restore_action, save_restore_orig_size)
533 (shrink_window_lowest_first, save_restore_orig_size): Remove.
534 Resize mini windows in window.el.
535 (grow_mini_window, shrink_mini_window): Implement by calling
536 Qresize_root_window_vertically, resize_window_check and
538 (saved_window, Fset_window_configuration, save_window_save): Do
539 not handle orig_top_line, orig_total_lines, and
540 resize_proportionally.
541 (window_min_height, window_min_width): Move to window.el.
542 (keys_of_window): Move bindings for delete-other-windows,
543 split-window, delete-window and enlarge-window to window.el.
545 * buffer.c: Temporarily extern Qdelete_window.
546 (Fbury_buffer): Temporarily call Qdelete_window instead of
547 Fdelete_window (Fbury_buffer will move to window.el soon).
549 * frame.c (set_menu_bar_lines_1): Remove code handling
550 orig_top_line and orig_total_lines.
552 * dispnew.c (adjust_frame_glyphs_initially): Don't use
553 set_window_height but set heights directly.
554 (change_frame_size_1): Use resize_frame_windows.
556 * xdisp.c (init_xdisp): Don't use set_window_height but set
559 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
560 resize_frame_windows instead of change_window_heights and run
561 run_window_configuration_change_hook.
563 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
564 instead of change_window_heights and run
565 run_window_configuration_change_hook.
567 2011-06-09 Martin Rudalics <rudalics@gmx.at>
569 * window.c (replace_window): Rename second argument REPLACEMENT to
570 NEW. New third argument SETFLAG. Rewrite.
571 (delete_window, make_dummy_parent): Call replace_window with
573 (window_list_1): Move down in code.
574 (run_window_configuration_change_hook): Move set_buffer part
575 before select_frame_norecord part in order to unwind correctly.
576 Rename count1 to count.
577 (recombine_windows, delete_deletable_window, resize_root_window)
578 (Fdelete_other_windows_internal)
579 (Frun_window_configuration_change_hook, make_parent_window)
580 (resize_window_check, resize_window_apply, Fresize_window_apply)
581 (resize_frame_windows, Fsplit_window_internal)
582 (Fdelete_window_internal, Fresize_mini_window_internal): New
584 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
586 2011-06-08 Martin Rudalics <rudalics@gmx.at>
588 * window.h (window): Add some new members to window structure -
589 normal_lines, normal_cols, new_total, new_normal, clone_number,
590 splits, nest, prev_buffers, next_buffers.
591 (WINDOW_TOTAL_SIZE): Move here from window.c.
592 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
594 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
596 (make_dummy_parent): Set new members of windows structure.
597 (make_window): Move down in code. Handle new members of window
599 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
600 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
601 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
602 (Fset_window_prev_buffers, Fwindow_next_buffers)
603 (Fset_window_next_buffers, Fset_window_clone_number): New
605 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
606 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
608 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
609 Argument WINDOW can be now internal window too.
610 (Fwindow_use_time): Move up in code.
611 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
613 (Fset_window_configuration, saved_window)
614 (Fcurrent_window_configuration, save_window_save): Handle new
615 members of window structure.
616 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
617 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
618 (syms_of_window): New Lisp objects Qrecord_window_buffer,
619 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
620 Qget_mru_window, Qresize_root_window,
621 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
622 Qauto_buffer_name; staticpro them.
624 2011-06-07 Martin Rudalics <rudalics@gmx.at>
626 * window.c (Fwindow_total_size, Fwindow_left_column)
627 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
628 (Fwindow_list_1): New functions.
629 (window_box_text_cols): Replace with window_body_cols.
630 (Fwindow_width, Fscroll_left, Fscroll_right): Use
631 window_body_cols instead of window_box_text_cols.
632 (delete_window, Fset_window_configuration): Call
633 delete_all_subwindows with window as argument.
634 (delete_all_subwindows): Take a window as argument and not a
636 (window_loop): Remove handling of GET_LRU_WINDOW and
638 (Fget_lru_window, Fget_largest_window): Move to window.el.
640 * window.h: Extern window_body_cols instead of
641 window_box_text_cols. delete_all_subwindows now takes a
642 Lisp_Object as argument.
644 * indent.c (compute_motion, Fcompute_motion): Use
645 window_body_cols instead of window_box_text_cols.
647 * frame.c (delete_frame): Call delete_all_subwindows with root
650 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
652 * fns.c (Fputhash): Document return value.
654 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
656 * image.c (gif_load): Implement gif89a spec "no disposal" method.
658 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
660 Cons<->int and similar integer overflow fixes (Bug#8794).
662 Check for overflow when converting integer to cons and back.
663 * charset.c (Fdefine_charset_internal, Fdecode_char):
664 Use cons_to_unsigned to catch overflow.
665 (Fencode_char): Use INTEGER_TO_CONS.
666 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
667 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
668 * data.c (long_to_cons, cons_to_long): Remove.
669 (cons_to_unsigned, cons_to_signed): New functions.
670 These signal an error for invalid or out-of-range values.
671 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
672 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
673 * font.c (Ffont_variation_glyphs):
674 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
675 * lisp.h: Include <intprops.h>.
676 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
677 (cons_to_signed, cons_to_unsigned): New decls.
678 (long_to_cons, cons_to_long): Remove decls.
679 * undo.c (record_first_change): Use INTEGER_TO_CONS.
680 (Fprimitive_undo): Use CONS_TO_INTEGER.
681 * xfns.c (Fx_window_property): Likewise.
682 * xselect.c: Include <limits.h>.
683 (x_own_selection, selection_data_to_lisp_data):
685 (x_handle_selection_request, x_handle_selection_clear)
686 (x_get_foreign_selection, Fx_disown_selection_internal)
687 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
688 (lisp_data_to_selection_data): Use cons_to_unsigned.
689 (x_fill_property_data): Use cons_to_signed.
690 Report values out of range.
692 Check for buffer and string overflow more precisely.
693 * buffer.h (BUF_BYTES_MAX): New macro.
694 * lisp.h (STRING_BYTES_MAX): New macro.
695 * alloc.c (Fmake_string):
696 * character.c (string_escape_byte8):
697 * coding.c (coding_alloc_by_realloc):
699 * editfns.c (Fformat):
701 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
702 since they may not be the same number.
703 * editfns.c (Finsert_char):
704 * fileio.c (Finsert_file_contents):
705 Likewise for BUF_BYTES_MAX.
707 * image.c: Use ptrdiff_t, not int, for sizes.
708 (slurp_file): Switch from int to ptrdiff_t.
710 (slurp_file): Check that file size fits in both size_t (for
711 malloc) and ptrdiff_t (for sanity and safety).
713 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
714 if b->modtime has its maximal value.
716 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
718 Don't assume time_t can fit into int.
719 * buffer.h (struct buffer.modtime): Now time_t, not int.
720 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
721 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
723 Minor fixes for signed vs unsigned integers.
724 * character.h (MAYBE_UNIFY_CHAR):
725 * charset.c (maybe_unify_char):
726 * keyboard.c (read_char, reorder_modifiers):
727 XINT -> XFASTINT, since the integer must be nonnegative.
728 * ftfont.c (ftfont_spec_pattern):
729 * keymap.c (access_keymap, silly_event_symbol_error):
730 XUINT -> XFASTINT, since the integer must be nonnegative.
731 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
732 since it makes no difference and we prefer signed.
733 * keyboard.c (record_char): Use XUINT when all the neighbors do.
734 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
737 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
739 * window.h (Fwindow_frame): Declare.
741 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
743 * alloc.c: Simplify handling of large-request failures (Bug#8800).
744 (SPARE_MEMORY): Always define.
745 (LARGE_REQUEST): Remove.
746 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
748 2011-06-06 Martin Rudalics <rudalics@gmx.at>
750 * lisp.h: Move EXFUNS for Fframe_root_window,
751 Fframe_first_window and Fset_frame_selected_window to window.h.
753 * window.h: Move EXFUNS for Fframe_root_window,
754 Fframe_first_window and Fset_frame_selected_window here from
757 * frame.c (Fwindow_frame, Fframe_first_window)
758 (Fframe_root_window, Fframe_selected_window)
759 (Fset_frame_selected_window): Move to window.c.
760 (Factive_minibuffer_window): Move to minibuf.c.
761 (Fother_visible_frames_p): New function.
763 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
765 * window.c (decode_window, decode_any_window): Move up in code.
766 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
767 (inhibit_frame_unsplittable): Remove unused variable.
768 (Fwindow_buffer): Move up and rewrite doc-string.
769 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
770 (Fwindow_prev): New functions.
771 (Fwindow_frame): Move here from frame.c. Accept any window as
773 (Fframe_root_window, Fframe_first_window)
774 (Fframe_selected_window): Move here from frame.c. Accept frame
775 or arbitrary window as argument. Update doc-strings.
776 (Fminibuffer_window): Move up in code.
777 (Fwindow_minibuffer_p): Move up in code and simplify.
778 (Fset_frame_selected_window): Move here from frame.c.
780 (Fselected_window, select_window, Fselect_window): Move up in
781 code. Minor doc-string fixes.
783 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
785 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
786 Do not assume that spare memory exists; that assumption is valid
787 only if SYSTEM_MALLOC.
788 (LARGE_REQUEST): New macro, so that the issue of large requests
789 is separated from the issue of spare memory.
791 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
793 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
796 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
798 * xfns.c (x_set_scroll_bar_default_width): Move declarations
801 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
803 * gtkutil.c (xg_get_default_scrollbar_width): New function.
805 * gtkutil.h: Declare xg_get_default_scrollbar_width.
807 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
808 min width by calling x_set_scroll_bar_default_width (Bug#8505).
810 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
812 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
814 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
816 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
817 (x_clipboard_manager_save): Add return value.
818 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
820 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
821 Obey Vx_select_enable_clipboard_manager. Catch errors in
822 x_clipboard_manager_save (Bug#8779).
823 (Vx_select_enable_clipboard_manager): New variable.
824 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
826 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
828 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
830 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
832 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
833 in the current matrix if keep_current_p is non-zero.
835 2011-06-04 Eli Zaretskii <eliz@gnu.org>
837 * bidi.c (bidi_level_of_next_char): Fix last change.
839 2011-06-03 Eli Zaretskii <eliz@gnu.org>
841 Support bidi reordering of text covered by display properties.
843 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
844 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
845 (bidi_cache_search, bidi_cache_iterator_state)
846 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
847 (bidi_level_of_next_char, bidi_move_to_visually_next):
848 Support character positions inside a run of characters covered by a
850 (bidi_paragraph_init, bidi_resolve_explicit_1)
851 (bidi_level_of_next_char): Call bidi_fetch_char and
852 bidi_fetch_char_advance instead of FETCH_CHAR and
854 (bidi_init_it): Initialize new members.
855 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
857 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
858 instead of using explicit *_CHAR codes.
859 (bidi_resolve_explicit, bidi_resolve_weak):
860 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
861 bidirectional text is supported only in multibyte buffers.
862 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
863 it to initialize the frame_window_p member of struct bidi_it.
864 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
865 (bidi_resolve_explicit, bidi_resolve_weak)
866 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
867 bidi_it->nchars is non-positive.
868 (bidi_level_of_next_char): Don't try to lookup the cache for the
869 next/previous character if nothing is cached there yet, or if we
870 were just reseat()'ed to a new position.
872 * xdisp.c (set_cursor_from_row): Set start and stop points
873 according to the row's direction when priming the loop that looks
874 for the glyph on which to display cursor.
875 (single_display_spec_intangible_p): Function deleted.
876 (display_prop_intangible_p): Reimplement to call
877 handle_display_spec instead of single_display_spec_intangible_p.
878 Accept 3 additional arguments needed by handle_display_spec.
879 This fixes incorrect cursor motion across display property with complex
880 values: lists, `(when COND...)' forms, etc.
881 (single_display_spec_string_p): Support property values that are
882 lists with the argument STRING its top-level element.
883 (display_prop_string_p): Fix the condition for processing a
884 property that is a list to be consistent with handle_display_spec.
885 (handle_display_spec): New function, refactored from the
886 last portion of handle_display_prop.
887 (compute_display_string_pos): Accept additional argument
888 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
889 value of a `display' property is a "replacing spec".
890 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
891 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
892 the display property, but just return a value indicating whether
893 the display property will replace the characters it covers.
894 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
895 frame_window_p members of struct bidi_it.
896 (compute_display_string_pos, compute_display_string_end):
898 (push_it): Accept second argument POSITION, where pop_it should
899 jump to continue iteration.
900 (reseat_1): Initialize bidi_it.disp_pos.
902 * keyboard.c (adjust_point_for_property): Adjust the call to
903 display_prop_intangible_p to its new signature.
905 * dispextern.h (struct bidi_it): New member frame_window_p.
906 (bidi_init_it): Update prototypes.
907 (display_prop_intangible_p): Update prototype.
908 (compute_display_string_pos, compute_display_string_end):
910 (struct bidi_it): New members nchars and disp_pos. ch_len is now
913 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
915 Malloc failure behavior now depends on size of allocation.
916 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
917 * lisp.h: Change signatures accordingly.
918 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
919 All callers changed. (Bug#8762)
921 * gnutls.c: Use Emacs's memory allocators.
922 Without this change, the gnutls library would invoke malloc etc.
923 directly, which causes problems on non-SYNC_INPUT hosts, and which
924 runs afoul of improving memory_full behavior. (Bug#8761)
925 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
926 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
927 xfree instead of the default malloc, realloc, free.
928 (Fgnutls_boot): No need to check for memory allocation failure,
929 since xmalloc does that for us.
931 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
932 * category.c (hash_get_category_set):
933 * ccl.c (ccl_driver):
934 * charset.c (Fdefine_charset_internal):
935 * charset.h (struct charset.hash_index):
936 * composite.c (get_composition_id, gstring_lookup_cache)
937 (composition_gstring_put_cache):
938 * composite.h (struct composition.hash_index):
939 * dispextern.h (struct image.hash):
940 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
941 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
942 (hashfn_equal, hashfn_user_defined, make_hash_table)
943 (maybe_resize_hash_table, hash_lookup, hash_put)
944 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
945 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
946 (Fsxhash, Fgethash, Fputhash, Fmaphash):
947 * image.c (make_image, search_image_cache, lookup_image)
948 (xpm_put_color_table_h):
949 * lisp.h (struct Lisp_Hash_Table):
950 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
951 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
952 for hashes and hash indexes, instead of 'unsigned' and 'int'.
953 * alloc.c (allocate_vectorlike):
954 Check for overflow in vector size calculations.
955 * ccl.c (ccl_driver):
956 Check for overflow when converting EMACS_INT to int.
957 * fns.c, image.c: Remove unnecessary static decls that would otherwise
958 need to be updated by these changes.
959 * fns.c (make_hash_table, maybe_resize_hash_table):
960 Check for integer overflow with large hash tables.
961 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
962 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
963 (SXHASH_REDUCE): New macro.
964 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
965 Use it instead of discarding useful hash info with large hash values.
966 (sxhash_float): New function.
967 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
968 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
969 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
970 Rewrite to use FIXNUM_BITS, as this simplifies things.
971 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
972 Adjust signatures to match updated version of code.
973 (consing_since_gc): Now EMACS_INT, since a single hash table can
974 use more than INT_MAX bytes.
976 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
978 Make it possible to build with GCC-4.6+ -O2 -flto.
980 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
982 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
984 * minibuf.c (get_minibuffer, read_minibuf_unwind):
985 Call minibuffer-inactive-mode.
987 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
989 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
992 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
994 * data.c (init_data): Remove code for UTS, this system is not
997 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
999 Don't force ./temacs to start in terminal mode.
1001 * frame.c (make_initial_frame): Initialize faces in all cases, not
1002 only when CANNOT_DUMP is defined.
1003 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1005 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1007 * dispnew.c (add_window_display_history): Use const for the string
1008 pointer. Remove declaration, not needed.
1010 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1012 Use 'inline', not 'INLINE'.
1013 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1014 * alloc.c, fontset.c (INLINE): Remove.
1015 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1016 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1017 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1018 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1019 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1021 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1023 Make it possible to run ./temacs.
1025 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1026 syms_of_callproc does the same thing. Remove test for
1027 "initialized", do it in the caller.
1028 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1030 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1032 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1033 (read_minibuf): Use get_minibuffer.
1034 (syms_of_minibuf): Use DEFSYM.
1035 (Qmetadata): New var.
1036 * data.c (Qbuffer): Don't make it static.
1037 (syms_of_data): Use DEFSYM.
1039 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1041 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1042 (CCL_CODE_MIN): New macro.
1044 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1046 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1048 * eval.c (Qdebug): Now static.
1049 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1050 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1051 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1053 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1055 * image.c: Various fixes to ImageMagick code comments.
1056 (Fimagemagick_types): Doc fix.
1058 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1060 Minor fixes prompted by GCC 4.6.0 warnings.
1062 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1064 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1065 (x_clipboard_manager_save_all): Move extern decl to ...
1066 * xterm.h: ... here, so that it can be checked for consistency.
1068 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1070 * xselect.c (x_clipboard_manager_save_frame)
1071 (x_clipboard_manager_save_all): New functions.
1072 (Fx_clipboard_manager_save): Lisp function deleted.
1074 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1075 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1077 * xterm.h: Update prototype.
1079 2011-05-28 William Xu <william.xwl@gmail.com>
1081 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1084 2011-05-28 Jim Meyering <meyering@redhat.com>
1086 Avoid a sign-extension bug in crypto_hash_function.
1087 * fns.c (to_uchar): Define.
1088 (crypto_hash_function): Use it to convert some newly-signed
1089 variables to unsigned, to avoid sign-extension bugs. For example,
1090 without this change, (md5 "truc") would evaluate to
1091 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1092 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1093 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1095 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1097 Integer overflow fixes.
1099 * dbusbind.c: Serial number integer overflow fixes.
1100 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1101 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1102 to hold a serial number that is too large for a fixnum.
1103 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1104 Check for serial numbers out of range. Decode any serial number
1105 that was so large that it became a float. (Bug#8722)
1107 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1108 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1109 Use XFASTINT rather than XUINT when numbers are nonnegative.
1110 (xd_append_arg, Fdbus_method_return_internal):
1111 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1112 arguments, check that Lisp number is nonnegative, rather than
1113 silently wrapping negative numbers around. (Bug#8722)
1114 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1117 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1119 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1121 ccl: add integer overflow checks
1122 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1123 (IN_INT_RANGE): New macros.
1124 (ccl_driver): Use them to check for integer overflow when
1125 decoding a CCL program. Many of the new checks are whether XINT (x)
1126 fits in int; it doesn't always, on 64-bit hosts. The new version
1127 doesn't catch all possible integer overflows, but it's an
1128 improvement. (Bug#8719)
1130 * alloc.c (make_event_array): Use XINT, not XUINT.
1131 There's no need for unsigned here.
1133 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1134 This follows up to the 2011-05-06 change that substituted uintptr_t
1135 for EMACS_INT. This case wasn't caught back then.
1137 Rework Fformat to avoid integer overflow issues.
1138 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1139 now (part of C89). Include <verify.h>.
1140 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1141 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1142 (Fformat): Avoid the prepass trying to compute sizes; it was only
1143 approximate and thus did not catch overflow reliably. Instead, walk
1144 through the format just once, formatting and computing sizes as we go,
1145 checking for integer overflow at every step, and allocating a larger
1146 buffer as needed. Keep track separately whether the format is
1147 multibyte. Keep only the most-recently calculated precision, rather
1148 than them all. Record whether each argument has been converted to
1149 string. Use EMACS_INT, not int, for byte and char and arg counts.
1150 Support field widths and precisions larger than INT_MAX. Avoid
1151 sprintf's undefined behavior with conversion specifications such as %#d
1152 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1153 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1154 formatting out-of-range floating point numbers with int
1157 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1159 * data.c: Avoid integer truncation in expressions involving floats.
1160 * data.c: Include <intprops.h>.
1161 (arith_driver): When there's an integer overflow in an expression
1162 involving floating point, convert the integers to floating point
1163 so that the resulting value does not suffer from catastrophic
1164 integer truncation. For example, on a 64-bit host (* 4
1165 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1166 Do not rely on undefined behavior after integer overflow.
1168 merge count_size_as_multibyte, parse_str_to_multibyte
1169 * character.c, character.h (count_size_as_multibyte):
1170 Rename from parse_str_to_multibyte; all uses changed.
1171 Check for integer overflow.
1172 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1173 since it's now a duplicate of the other. This is more of
1174 a character than a buffer op, so better that it's in character.c.
1175 * fns.c, print.c: Adjust to above changes.
1177 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1179 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1181 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1183 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1184 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1185 (x_clipboard_manager_save): Now static.
1186 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1188 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1189 (crypto_hash_function): Now static.
1190 Fix pointer signedness problems. Avoid unnecessary initializations.
1192 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1194 * termhooks.h (Vselection_alist): Make it terminal-local.
1196 * terminal.c (create_terminal): Initialize it.
1198 * xselect.c: Support for clipboard managers.
1199 (Vselection_alist): Move to termhooks.h as terminal-local var.
1200 (LOCAL_SELECTION): New macro.
1201 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1202 (symbol_to_x_atom): Remove gratuitous arg.
1203 (x_handle_selection_request, lisp_data_to_selection_data)
1204 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1205 (x_own_selection, x_get_local_selection, x_convert_selection):
1206 New arg, specifying work frame. Use terminal-local Vselection_alist.
1207 (some_frame_on_display): Delete unused function.
1208 (Fx_own_selection_internal, Fx_get_selection_internal)
1209 (Fx_disown_selection_internal, Fx_selection_owner_p)
1210 (Fx_selection_exists_p): New optional frame arg.
1211 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1212 (x_handle_selection_clear): Don't treat other terminals with the
1213 same keyboard specially. Use the terminal-local Vselection_alist.
1214 (x_clear_frame_selections): Use Frun_hook_with_args.
1216 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1218 * xterm.h: Add support for those atoms.
1220 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1222 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1223 (converted_selections, conversion_fail_tag): New global variables.
1224 (x_selection_request_lisp_error): Free the above.
1225 (x_get_local_selection): Remove unnecessary code.
1226 (x_reply_selection_request): Args changed; handle arbitrary array
1227 of converted selections stored in converted_selections.
1228 Separate the XChangeProperty and SelectionNotify steps.
1229 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1230 (x_convert_selection): New function.
1231 (x_handle_selection_event): Simplify.
1232 (x_get_foreign_selection): Don't ignore incoming requests while
1233 waiting for an answer; this will fail when we implement
1234 SAVE_TARGETS, and seems unnecessary anyway.
1235 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1236 (Vx_sent_selection_functions): Doc fix.
1238 2011-05-26 Leo Liu <sdl.web@gmail.com>
1240 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1242 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1244 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1246 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1247 for fringe update if it has periodic bitmap.
1248 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1249 and fringe_bitmap_periodic_p.
1251 * fringe.c (get_fringe_bitmap_data): New function.
1252 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1253 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1254 row. Mark glyph row for fringe update if periodicity changed.
1256 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1257 for fringe update unless it has periodic bitmap.
1259 2011-05-25 Kenichi Handa <handa@m17n.org>
1261 * xdisp.c (get_next_display_element): Set correct it->face_id for
1262 a static composition.
1264 2011-05-24 Leo Liu <sdl.web@gmail.com>
1267 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1269 * fns.c (crypto_hash_function, Fsha1): New function.
1270 (Fmd5): Use crypto_hash_function.
1271 (syms_of_fns): Add Ssha1.
1273 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1275 * gnutls.c: Remove unused macros.
1276 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1277 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1278 Remove macros that are defined and never used.
1279 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1281 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1283 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1284 (Fx_get_selection_internal): Minor cleanup.
1285 (Fx_own_selection_internal): Rename arguments for consistency with
1288 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1290 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1292 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1294 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1296 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1298 * dispnew.c (scrolling_window): Don't exclude the case that the
1299 last enabled row in the desired matrix touches the bottom boundary.
1301 2011-05-21 Glenn Morris <rgm@gnu.org>
1303 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1304 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1305 and add some more files.
1307 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1309 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1310 report_file_error introduced by the change from 2011-05-07.
1312 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1314 * systime.h (Time): Define only if emacs is defined.
1315 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1316 where the include path doesn't have X11/X.h by default. See
1317 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1319 2011-05-20 Kenichi Handa <handa@m17n.org>
1321 * composite.c (find_automatic_composition): Fix previous change.
1323 2011-05-20 Glenn Morris <rgm@gnu.org>
1325 * lisp.mk: New file, split from Makefile.in.
1326 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1327 (shortlisp): Remove.
1328 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1330 2011-05-19 Glenn Morris <rgm@gnu.org>
1332 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1333 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1334 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1335 (lisp): Set the order to that of loadup.el.
1336 (shortlisp): Make it a copy of $lisp.
1337 (SOME_MACHINE_LISP): Remove.
1338 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1339 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1341 2011-05-18 Kenichi Handa <handa@m17n.org>
1343 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1344 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1345 (find_automatic_composition): Mostly rewrite for efficiency.
1347 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1349 * makefile.w32-in: Update dependencies.
1351 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1353 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1354 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1356 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1358 Fix some integer overflow issues, such as string length overflow.
1360 * insdel.c (count_size_as_multibyte): Check for string overflow.
1362 * character.c (lisp_string_width): Check for string overflow.
1363 Use EMACS_INT, not int, for string indexes and lengths; in
1364 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1365 the resulting string length overflows an EMACS_INT; instead,
1366 report a string overflow if no precision given. When checking for
1367 precision exhaustion, use a check that cannot possibly have
1368 integer overflow. (Bug#8675)
1369 * character.h (lisp_string_width): Adjust to new signature.
1371 * alloc.c (string_overflow): New function.
1372 (Fmake_string): Use it. This doesn't change behavior, but saves
1373 a few bytes and will simplify future changes.
1374 * character.c (string_escape_byte8): Likewise.
1375 * lisp.h (string_overflow): New decl.
1377 Fixups, following up to the user-interface timestamp change.
1378 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1379 for UI timestamps, instead of unsigned long.
1380 * msdos.c (mouse_get_pos): Likewise.
1381 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1382 * w32gui.h (Time): Define by including "systime.h" rather than by
1383 declaring it ourselves. (Bug#8664)
1385 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1386 * image.c (clear_image_cache): Likewise.
1388 * term.c (term_mouse_position): Don't assume time_t wraparound.
1390 Be more systematic about user-interface timestamps.
1391 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1392 and sometimes 'EMACS_UINT', to represent these timestamps.
1393 This change causes it to use 'Time' uniformly, as that's what X uses.
1394 This makes the code easier to follow, and makes it easier to catch
1395 integer overflow bugs such as Bug#8664.
1396 * frame.c (Fmouse_position, Fmouse_pixel_position):
1397 Use Time, not unsigned long, for user-interface timestamps.
1398 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1399 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1400 * keyboard.h (last_event_timestamp): Likewise.
1401 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1402 * menu.h (xmenu_show): Likewise.
1403 * term.c (term_mouse_position): Likewise.
1404 * termhooks.h (struct input_event.timestamp): Likewise.
1405 (struct terminal.mouse_position_hook): Likewise.
1406 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1407 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1408 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1409 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1411 * menu.h, termhooks.h: Include "systime.h", for Time.
1413 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1414 Don't assume that the difference between two unsigned long values
1415 can fit into an integer. At this point, we know button_down_time
1416 <= event->timestamp, so the difference must be nonnegative, so
1417 there's no need to cast the result if double-click-time is
1418 nonnegative, as it should be; check that it's nonnegative, just in
1419 case. This bug is triggered when events are more than 2**31 ms
1420 apart (about 25 days). (Bug#8664)
1422 * xselect.c (last_event_timestamp): Remove duplicate decl.
1423 (x_own_selection): Remove needless cast to unsigned long.
1425 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1426 that always fit in int. Use a sentinel instead of a counter, to
1427 avoid a temp and to allay GCC's concerns about possible int overflow.
1428 * frame.h (struct frame): Use int for menu_bar_items_used
1429 instead of EMACS_INT, since it always fits in int.
1431 * menu.c (grow_menu_items): Check for int overflow.
1433 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1435 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1436 Before, the code was not consistent. These values cannot exceed
1437 2**31 - 1 so there's no need to make them unsigned.
1438 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1439 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1440 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1442 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1444 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1445 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1446 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1447 presumably because the widths might not match.
1449 * window.c (size_window): Avoid needless test at loop start.
1451 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1453 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1455 2011-05-12 Drew Adams <drew.adams@oracle.com>
1457 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1459 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1461 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1462 `width' to `bar_area_x' and `bar_area_width', respectively.
1463 (x_scroll_run): Take account of fringe background extension.
1465 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1466 Rename local vars `left' and `width' to `bar_area_x' and
1467 `bar_area_width', respectively.
1468 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1469 background extension.
1471 2011-05-10 Jim Meyering <meyering@redhat.com>
1473 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1475 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1477 * image.c (Finit_image_library): Return t for built-in image types,
1478 like pbm and xbm. (Bug#8640)
1480 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1482 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1484 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1486 * w32console.c (Fset_screen_color): Doc fix.
1487 (Fget_screen_color): New function.
1488 (syms_of_ntterm): Defsubr it.
1490 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1491 unlink the temporary file if Fcall_process didn't create it in the
1493 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1494 child process will be redirected to a file specified with `:file'.
1495 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1496 cue to call_process_cleanup not to close that handle.
1498 2011-05-07 Ben Key <bkey76@gmail.com>
1500 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1501 one of two shell specific rules, either bootstrap-temacs-CMD or
1502 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1503 to the previous implementation of the bootstrap-temacs rule.
1504 The bootstrap-temacs-CMD rule is similar to the previous
1505 implementation of the bootstrap-temacs rule except that it
1506 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1509 These changes, along with some changes to nt/configure.bat,
1510 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1511 earlier fix to add support for --cflags and --ldflags options
1512 that include quotes so that it works whether make uses cmd or
1515 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1517 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1518 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1520 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1521 a string. Handle both cases.
1522 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1523 (Fdbus_register_method): Use Qinvalid_function.
1525 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1527 * makefile.w32-in: Update dependencies.
1528 (LISP_H): Add inttypes.h and stdin.h.
1529 (PROCESS_H): Add unistd.h.
1531 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1533 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1534 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1536 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1538 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1540 * term.c (vfatal): Remove stray call to va_end.
1541 It's not needed and the C Standard doesn't allow it here anyway.
1543 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1544 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1546 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1549 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1553 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1555 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1557 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1559 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1560 * charset.c (Fdefine_charset_internal): Don't initialize
1561 charset.code_space[15]. The value was garbage, on hosts with
1562 32-bit int (Bug#8600).
1564 * lread.c (read_integer): Be more consistent with string-to-number.
1565 Use string_to_number to do the actual conversion; this avoids
1566 rounding errors and fixes some other screwups. Without this fix,
1567 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1568 (digit_to_number): Move earlier, for benefit of read_integer.
1569 Return -1 if the digit is out of range for the base, -2 if it is
1570 not a digit in any supported base. (Bug#8602)
1572 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1574 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1575 to match comment at start of function. This also removes a
1576 GCC warning about overflow in a 32+64-bit port.
1578 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1580 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1581 Reported by Stefan Monnier in
1582 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1583 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1584 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1586 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1587 (EMACS_UINTPTR): Likewise, with uintptr_t.
1589 * lisp.h: Prefer 64-bit EMACS_INT if available.
1590 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1591 on 32-bit hosts that have 64-bit int, so that they can access
1593 However, temporarily disable this change unless the temporary
1594 symbol WIDE_EMACS_INT is defined.
1596 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1598 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1599 This removes an assumption that EMACS_INT and long are the same
1600 width as pointers. The assumption is true for Emacs porting targets
1601 now, but we want to make other targets possible.
1602 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1603 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1604 In the rest of the code, change types of integers that hold casted
1605 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1606 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1607 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1608 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1609 No need to cast type when ORing.
1610 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1611 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1612 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1613 assume EMACS_INT is the same width as char *.
1614 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1615 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1616 Remove no-longer-needed casts.
1617 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1618 (xg_tool_bar_help_callback, xg_make_tool_item):
1619 Use EMACS_INTPTR to hold an integer
1620 that will be cast to void *; this can avoid a GCC warning
1621 if EMACS_INT is not the same width as void *.
1622 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1623 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1624 (current_message_1, set_message_1):
1625 Use a local to convert to proper width without a cast.
1626 * xmenu.c (dialog_selection_callback): Likewise.
1628 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1629 Also, don't assume VALBITS / RAND_BITS is less than 5,
1630 and don't rely on undefined behavior when shifting a 1 left into
1632 * lisp.h (get_random): Change signature to match.
1634 * lread.c (hash_string): Use size_t, not int, for hash computation.
1635 Normally we prefer signed values; but hashing is special, because
1636 it's better to use unsigned division on hash table sizes so that
1637 the remainder is nonnegative. Also, size_t is the natural width
1638 for hashing into memory. The previous code used 'int', which doesn't
1639 retain enough info to hash well into very large tables.
1640 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1642 * dbusbind.c: Don't possibly lose pointer info when converting.
1643 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1644 Use XPNTR rather than XHASH, so that the high-order bits of
1645 the pointer aren't lost when converting through void *.
1647 * eval.c (Fautoload): Don't double-shift a pointer.
1649 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1651 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1653 * gnutls.c (DEF_GNUTLS_FN):
1654 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1656 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1658 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1661 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1663 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1664 New version that can reserve upto 2GB of heap space.
1666 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1668 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1670 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1672 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1673 `gnutls_certificate_set_x509_key_file'.
1675 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1677 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1678 Update dependencies.
1680 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1682 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1683 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1684 Remove unused parameter `fildes'.
1685 * process.c (read_process_output, send_process): Don't pass it.
1687 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1689 Fix previous change: the library cache is defined in w32.c.
1690 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1691 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1693 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1695 Implement dynamic loading of GnuTLS on Windows.
1697 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1698 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1699 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1702 * gnutls.c (Qgnutls_dll): Define.
1703 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1704 (gnutls_*): Declare function pointers.
1705 (init_gnutls_functions): New function to initialize function pointers.
1706 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1707 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1708 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1709 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1710 (emacs_gnutls_write, emacs_gnutls_read)
1711 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1712 (Fgnutls_available_p): New function.
1713 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1714 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1715 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1717 * image.c: Include w32.h.
1718 (Vimage_type_cache): Delete.
1719 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1720 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1721 (w32_delayed_load): Move to w32.c.
1723 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1725 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1726 (w32_delayed_load): Move from image.c. When loading a library, record
1727 its filename in the :loaded-from property of the library id.
1728 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1729 Initialize and staticpro them.
1730 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1732 * process.c: Include lisp.h before w32.h, not after.
1733 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1734 instead of gnutls_record_check_pending.
1736 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1738 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1740 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1741 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1744 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1746 * xterm.c (x_set_frame_alpha): Do not set property on anything
1747 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1749 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1751 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1753 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1755 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1756 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1757 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1758 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1759 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1760 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1761 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1762 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1763 (Qgnutls_bootprop_callbacks_verify): Make static.
1765 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1767 * callproc.c: Indentation fixup.
1769 * sysdep.c (wait_for_termination_1): Make static.
1770 (wait_for_termination, interruptible_wait_for_termination):
1771 Move after wait_for_termination_1.
1773 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1775 * sysdep.c (interruptible_wait_for_termination): New function
1776 which is like wait_for_termination, but allows keyboard
1779 * callproc.c (Fcall_process): Add (:file "file") as an option for
1781 (Fcall_process_region): Ditto.
1783 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1785 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1786 rather than `XVECTOR (FOO)->size'.
1788 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1789 inttypes.h, as a gnulib replacement is used if it not available in
1792 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1794 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1795 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1796 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1798 * coding.c (coding_alloc_by_realloc): Error out if destination
1799 will grow beyond MOST_POSITIVE_FIXNUM.
1800 (decode_coding_emacs_mule): Abort if there isn't enough place in
1801 charbuf for the composition carryover bytes. Reserve an extra
1802 space for up to 2 characters produced in a loop.
1803 (decode_coding_iso_2022): Abort if there isn't enough place in
1804 charbuf for the composition carryover bytes.
1806 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1808 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1809 aborting when %lld or %lll format is passed.
1810 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1811 %llo or %llx format is passed. (Bug#8545)
1813 * window.c (window_scroll_line_based): Use a marker instead of
1814 simple variables to record original value of point. (Bug#7952)
1816 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1817 produced by %s or %c overflows available buffer space. (Bug#8545)
1819 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1821 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1822 (SIZE_MAX): Move defn after all includes, as they might #define it.
1824 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1826 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1828 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1830 * keyboard.c (Qdelayed_warnings_hook): Define.
1831 (command_loop_1): Run `delayed-warnings-hook'
1832 if Vdelayed_warnings_list is non-nil.
1833 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1834 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1836 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1838 * doprnt.c (doprnt): Don't return value smaller than the buffer
1839 size if the message was truncated. (Bug#8545).
1841 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1843 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1844 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1846 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1848 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1850 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1852 * makefile.w32-in: Update dependencies.
1854 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1856 Improve `doprnt' and its usage. (Bug#8545)
1857 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1858 `format_end'. Remove support for %l as a conversion specifier.
1859 Don't use xrealloc. Improve diagnostics when the %l size modifier
1860 is used. Update the commentary.
1862 * eval.c (verror): Simplify calculation of size_t.
1864 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1867 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1869 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1872 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1874 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1875 This makes this file independent of the recent pseudovector change.
1877 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1879 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1881 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1882 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1883 Remove unused local.
1884 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1886 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1887 GCC 4.6.0 optimizes based on type-based alias analysis.
1888 For example, if b is of type struct buffer * and v of type struct
1889 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1890 != &v->size, and therefore "v->size = 1; b->size = 2; return
1891 v->size;" must therefore return 1. This assumption is incorrect
1892 for Emacs, since it type-puns struct Lisp_Vector * with many other
1893 types. To fix this problem, this patch adds a new type struct
1894 vectorlike_header that documents the constraints on layout of vectors
1895 and pseudovectors, and helps optimizing compilers not get fooled
1896 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1897 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1898 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1900 (XSETPVECTYPE): Rewrite in terms of new macro.
1901 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1902 This is a bit clearer, and further avoids the possibility of
1903 undesirable aliasing.
1904 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1905 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1906 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1907 since Lisp_Subr is a special case (no "next" field).
1908 (ASIZE): Now uses header.size rather than size.
1909 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1910 to avoid the hassle of writing XVECTOR (foo)->header.size.
1911 (struct vectorlike_header): New type.
1912 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1913 object, to help avoid aliasing.
1914 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1915 (SUBRP): Likewise, since Lisp_Subr is a special case.
1916 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1917 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1918 (struct Lisp_Hash_Table): Combine first two members into a single
1919 struct vectorlike_header member. All uses of "size" and "next" members
1920 changed to be "header.size" and "header.next".
1921 * buffer.h (struct buffer): Likewise.
1922 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1923 * frame.h (struct frame): Likewise.
1924 * process.h (struct Lisp_Process): Likewise.
1925 * termhooks.h (struct terminal): Likewise.
1926 * window.c (struct save_window_data, struct saved_window): Likewise.
1927 * window.h (struct window): Likewise.
1928 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1929 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1930 * buffer.c (init_buffer_once): Likewise.
1931 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1933 * process.c (Fformat_network_address): Use local var for size,
1936 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1938 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1939 * data.c (atof): Remove decl; no longer used or needed.
1940 (digit_to_number): Move to lread.c.
1941 (Fstring_to_number): Use new string_to_number function, to be
1942 consistent with how the Lisp reader treats infinities and NaNs.
1943 Do not assume that floating-point numbers represent EMACS_INT
1944 without losing information; this is not true on most 64-bit hosts.
1945 Avoid double-rounding errors, by insisting on integers when
1946 parsing non-base-10 numbers, as the documentation specifies.
1947 * lisp.h (string_to_number): New decl, replacing ...
1948 (isfloat_string): Remove.
1949 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1950 (read1): Do not accept +. and -. as integers; this
1951 appears to have been a coding error. Similarly, do not accept
1952 strings like +-1e0 as floating point numbers. Do not report
1953 overflow for integer overflows unless the base is not 10 which
1954 means we have no simple and reliable way to continue.
1955 Break out the floating-point parsing into a new
1956 function string_to_number, so that Fstring_to_number parses
1957 floating point numbers consistently with the Lisp reader.
1958 (digit_to_number): Move here from data.c. Make it static inline.
1959 (E_CHAR, EXP_INT): Remove, replacing with ...
1960 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1961 (string_to_number): New function, replacing isfloat_string.
1962 This function checks for valid syntax and produces the resulting
1963 Lisp float number too. Rework it so that string-to-number
1964 no longer mishandles examples like "1.0e+". Use strtoumax,
1965 so that overflow for non-base-10 numbers is reported only when
1966 there's no portable and simple way to convert to floating point.
1968 * textprop.c (set_text_properties_1): Rewrite for clarity,
1969 and to avoid GCC warning about integer overflow.
1971 * intervals.h (struct interval): Use EMACS_INT for members
1972 where EMACS_UINT might cause problems. See
1973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1974 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1975 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1977 (offset_intervals): Tell GCC not to worry about length overflow
1978 when negating a negative length.
1980 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1981 (overrun_check_free): Likewise.
1983 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1984 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1987 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1988 (gnutls_make_error): Rename local to avoid shadowing.
1989 (gnutls_emacs_global_deinit): ifdef out; not used.
1990 (Fgnutls_boot): Use const for pointer to readonly storage.
1991 Comment out unused local. Fix pointer signedness problems.
1993 * lread.c (openp): Don't stuff size_t into an 'int'.
1994 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1995 about possible signed overflow.
1997 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1998 (GDK_KEY_g): Don't define if already defined.
1999 (xg_prepare_tooltip): Avoid pointer signedness problem.
2000 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2002 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2003 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2005 * xfns.c (Fx_window_property): Simplify a bit,
2006 to make a bit faster and to avoid GCC 4.6.0 warning.
2007 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2009 * fns.c (internal_equal): Don't assume size_t fits in int.
2011 * alloc.c (compact_small_strings): Tighten assertion a little.
2013 Replace pEd with more-general pI, and fix some printf arg casts.
2014 * lisp.h (pI): New macro, generalizing old pEd macro to other
2015 conversion specifiers. For example, use "...%"pI"d..." rather
2016 than "...%"pEd"...".
2017 (pEd): Remove. All uses replaced with similar uses of pI.
2018 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2019 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2020 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2021 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2022 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2023 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2024 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2026 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2027 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2028 * print.c (safe_debug_print, print_object): Likewise.
2029 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2031 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2032 avoiding the 0 flag, which is not portable.
2033 * process.c (Fmake_network_process): Use pI to avoid cast.
2034 * region-cache.c (pp_cache): Likewise.
2035 * xdisp.c (decode_mode_spec): Likewise.
2036 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2037 behavior on 64-bit hosts with printf arg.
2038 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2039 (x_stop_queuing_selection_requests): Likewise.
2040 (x_get_window_property): Don't truncate byte count to an 'int'
2043 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2044 here, since it parses constructs like leading '-' and spaces,
2045 which are not wanted; and it overflows with large numbers.
2046 Instead, simply match F[0-9]+, which is what is wanted anyway.
2048 * alloc.c: Remove unportable assumptions about struct layout.
2049 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2050 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2051 (allocate_vectorlike, make_pure_vector): Use the new macros,
2052 plus offsetof, to remove unportable assumptions about struct layout.
2053 These assumptions hold on all porting targets that I know of, but
2054 they are not guaranteed, they're easy to remove, and removing them
2055 makes further changes easier.
2057 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2058 This doesn't fix a bug but makes the code clearer.
2059 (string_overrun_cookie): Now const. Use initializers that
2060 don't formally overflow signed char, to avoid warnings.
2061 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2062 can cause Emacs to crash when string overrun checking is enabled.
2063 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2064 multiple of sizeof (EMACS_INT); it need not be, if
2065 alignof(EMACS_INT) < sizeof (EMACS_INT).
2066 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2068 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2070 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2072 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2074 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2075 supposed to be handshaking. (Bug#8556)
2076 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2078 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2080 * lisp.h (Qdebug): List symbol.
2081 * eval.c (Qdebug): Restore global linkage.
2082 * keyboard.c (debug-on-event): New variable.
2083 (handle_user_signal): Break into debugger when debug-on-event
2084 matches the current signal symbol.
2086 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2088 * alloc.c (check_sblock, check_string_bytes)
2089 (check_string_free_list): Convert to standard C.
2091 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2093 * w32.c (emacs_gnutls_push): Fix typo.
2095 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2097 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2098 "cast to pointer from integer of different size".
2100 Improve doprnt and its use in verror. (Bug#8545)
2101 * doprnt.c (doprnt): Document the set of format control sequences
2102 supported by the function. Use SAFE_ALLOCA instead of always
2105 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2106 is one byte too soon. Don't use xrealloc; instead xfree and
2109 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2111 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2114 * gnutls.c: Renamed global_initialized to
2115 gnutls_global_initialized. Added internals for the
2116 :verify-hostname-error, :verify-error, and :verify-flags
2117 parameters of `gnutls-boot' and documented those parameters in the
2118 docstring. Start callback support.
2119 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2120 unless a fatal error occured. Call gnutls_alert_send_appropriate
2121 on error. Return error code.
2122 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2123 (emacs_gnutls_read): Likewise.
2124 (Fgnutls_boot): Return handshake error code.
2125 (emacs_gnutls_handle_error): New function.
2126 (wsaerror_to_errno): Likewise.
2128 * w32.h (emacs_gnutls_pull): Add prototype.
2129 (emacs_gnutls_push): Likewise.
2131 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2132 (emacs_gnutls_push): Likewise.
2134 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2136 * process.c (wait_reading_process_output): Check if GnuTLS
2137 buffered some data internally if no FDs are set for TLS
2140 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2141 (LIBS): Link to USER_LIBS.
2142 ($(BLD)/gnutls.$(0)): New target.
2144 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (handle_single_display_spec): Rename the
2147 display_replaced_before_p argument into display_replaced_p, to
2148 make it consistent with the commentary. Fix typos in the
2151 * textprop.c (syms_of_textprop): Remove dead code.
2152 (copy_text_properties): Delete obsolete commentary about an
2153 interface that was deleted long ago. Fix typos in the description
2156 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2157 to changes in oldXMenu/XMenu.h from 2011-04-16.
2158 <menu_help_message, prev_menu_help_message>: Constify.
2159 (IT_menu_make_room): menu->help_text is now `const char **';
2162 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2163 to changes in oldXMenu/XMenu.h from 2011-04-16.
2164 (struct XMenu): Declare `help_text' `const char **'.
2166 * xfaces.c <Qunspecified>: Make extern again.
2168 * syntax.c: Include sys/types.h before including regex.h, as
2171 * doc.c (get_doc_string): Improve the format passed to `error'.
2173 * doprnt.c (doprnt): Improve commentary.
2175 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2177 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2180 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2181 changes in globals.h immediately force recompilation.
2182 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2183 $(CURDIR)/s/ms-w32.h.
2184 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2186 * character.c (Fchar_direction): Function deleted.
2187 (syms_of_character): Don't defsubr it.
2188 <char-direction-table>: Deleted.
2190 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2192 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2193 * doprnt.c: Include limits.h.
2194 (SIZE_MAX): New macro.
2195 (doprnt): Return a size_t value. 2nd arg is now size_t.
2196 Many local variables are now size_t instead of int or unsigned.
2197 Improve overflow protection. Support `l' modifier for integer
2198 conversions. Support %l conversion. Don't assume an EMACS_INT
2199 argument for integer conversions and for %c.
2201 * lisp.h (doprnt): Restore prototype.
2203 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2206 * Makefile.in (base_obj): Add back doprnt.o.
2208 * deps.mk (doprnt.o): Add back prerequisites.
2209 (callint.o): Depend on character.h.
2211 * eval.c (internal_lisp_condition_case): Include the handler
2212 representation in the error message.
2213 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2214 when breaking from the loop.
2216 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2218 * callint.c (Fcall_interactively): When displaying error message
2219 about invalid control letter, pass the character's codepoint, not
2220 a pointer to its multibyte form. Improve display of the character
2221 in octal and display also its hex code.
2223 * character.c (char_string): Use %x to display the (unsigned)
2224 codepoint of an invalid character, to avoid displaying a bogus
2227 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2228 `error', not SYMBOL_NAME itself.
2230 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2231 character arguments to `error'.
2233 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2234 to `error' in error message about FINAL_CHAR argument. Make sure
2235 FINAL_CHAR is a character, and use %c when it is passed as
2236 argument to `error'.
2238 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2240 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2242 * w32.c: Include <time.h>.
2243 (sys_localtime): New function.
2245 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2247 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2249 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2251 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2253 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2256 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2258 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2259 gl_state.e_property when gl_state.object is Qt.
2261 * insdel.c (make_gap_larger): Remove limitation of buffer size
2264 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2266 * xdisp.c (lookup_glyphless_char_display)
2267 (produce_glyphless_glyph): Handle cons cell entry in
2268 glyphless-char-display.
2269 (Vglyphless_char_display): Document it.
2271 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2272 glyphless-char-display.
2274 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2276 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2278 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2280 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2281 definition for no-X builds.
2283 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2285 Static checks with GCC 4.6.0 and non-default toolkits.
2287 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2289 * process.c (keyboard_bit_set): Define only if SIGIO.
2290 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2291 (send_process): Repair possible setjmp clobbering.
2293 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2295 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2297 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2299 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2300 Define only if needed.
2302 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2303 by pacifying GCC about it. Maybe it's time to retire it?
2304 * xfaces.c (USG, __TIMEVAL__): Likewise.
2306 * dispextern.h (struct redisplay_interface): Rename param
2308 * termhooks.h (struct terminal): Likewise.
2309 * xterm.c (xembed_send_message): Likewise.
2311 * insdel.c (make_gap_smaller): Define only if
2312 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2314 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2317 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2318 so that we aren't warned about unused symbols.
2320 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2322 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2324 * xfns.c (x_real_positions): Mark locals as initialized.
2326 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2328 * xterm.c: Fix problems found by static analysis with other toolkits.
2329 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2330 (x_dispatch_event): Declare static if USE_GTK, and
2331 define if USE_GTK || USE_X_TOOLKIT.
2332 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2333 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2334 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2335 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2337 * xmenu.c (menu_help_callback): Pointer type fixes.
2338 Use const pointers when pointing at readonly data. Avoid pointer
2340 (FALSE): Remove unused macro.
2341 (update_frame_menubar): Remove unused decl.
2343 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2345 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2346 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2347 (single_menu_item): Rename local to avoid shadowing.
2349 * keyboard.c (make_lispy_event): Remove unused local var.
2351 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2352 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2354 * bitmaps: Change bitmaps from unsigned char back to the X11
2355 compatible char. Avoid the old compiler warnings about
2356 out-of-range initializers by using, for example, '\xab' rather
2359 * xgselect.c (xgselect_initialize): Check vs interface
2360 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2362 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2364 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2365 to read-only memory.
2367 * fns.c (vector): Remove; this old hack is no longer needed.
2369 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2371 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2373 * xrdb.c (x_load_resources): Omit unused local.
2375 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2376 (x_window): Rename locals to avoid shadowing.
2377 (USG): Use the kludged USG macro, to pacify gcc.
2379 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2380 (x_term_init): Remove local to avoid shadowing.
2382 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2384 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2385 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2387 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2389 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2391 Fix regex.c, syntax.c and friends for buffers > 2GB.
2392 * syntax.h (struct gl_state_s): Declare character position members
2395 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2397 * textprop.c (verify_interval_modification, interval_of):
2398 Declare arguments EMACS_INT.
2400 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2403 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2405 * indent.c (Fvertical_motion): Local variable it_start is now
2408 * regex.c (re_match, re_match_2, re_match_2_internal)
2409 (bcmp_translate, regcomp, regexec, print_double_string)
2410 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2411 (re_compile_pattern, re_exec): Declare arguments and local
2412 variables `size_t' and `ssize_t' and return values `regoff_t', as
2414 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2415 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2416 <compile_stack_type>: `size' and `avail' are now `size_t'.
2418 * regex.h <regoff_t>: Use ssize_t, not int.
2419 (re_search, re_search_2, re_match, re_match_2): Arguments that
2420 specify buffer/string position and length are now ssize_t and
2421 size_t. Return type is regoff_t.
2423 2011-04-16 Ben Key <bkey76@gmail.com>
2425 * nsfont.m: Fixed bugs in ns_get_family and
2426 ns_descriptor_to_entity that were caused by using free to
2427 deallocate memory blocks that were allocated by xmalloc (via
2428 xstrdup). This caused Emacs to crash when compiled with
2429 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2430 --enable-checking=xmallocoverrun). xfree is now used to
2431 deallocate these memory blocks.
2433 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2435 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2437 emacs_write: Accept and return EMACS_INT for sizes.
2438 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2440 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2441 Accept and return EMACS_INT.
2442 (emacs_gnutls_write): Return the number of bytes written on
2444 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2445 (emacs_read, emacs_write): Remove check for negative size, as the
2446 Emacs source code has been audited now.
2447 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2448 (emacs_read, emacs_write): Use it.
2449 * process.c (send_process): Adjust to the new signatures of
2450 emacs_write and emacs_gnutls_write. Do not attempt to store
2451 a byte offset into an 'int'; it might overflow.
2452 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2454 * sound.c: Don't assume sizes fit in 'int'.
2455 (struct sound_device.period_size, alsa_period_size):
2456 Return EMACS_INT, not int.
2457 (struct sound_device.write, vox_write, alsa_write):
2458 Accept EMACS_INT, not int.
2459 (wav_play, au_play): Use EMACS_INT to store sizes and to
2460 record read return values.
2462 2011-04-15 Ben Key <bkey76@gmail.com>
2464 * keyboard.c (Qundefined): Don't declare static since it is used
2466 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2467 static since they are used in nsfont.m.
2469 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2471 * process.c (Qprocessp): Don't declare static.
2472 * lisp.h (Qprocessp): Declare again.
2474 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2476 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2478 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2480 Improve C-level modularity by making more things 'static'.
2482 Don't publish debugger-only interfaces to other modules.
2483 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2484 (verify_bytepos, count_markers): Move decls to the only modules
2486 * region-cache.h (pp_cache): Likewise.
2487 * window.h (check_all_windows): Likewise.
2488 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2490 * sysdep.c (croak): Now static, if
2491 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2492 * syssignal.h (croak): Declare only if not static.
2494 * alloc.c (refill_memory_reserve): Now static if
2495 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2496 * lisp.h (refill_memory_reserve): Declare only if not static.
2498 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2499 Define only if USE_LUCID.
2501 * xrdb.c (x_customization_string, x_rm_string): Now static.
2503 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2504 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2506 * xdisp.c (draw_row_with_mouse_face): Now static.
2507 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2509 * window.h (check_all_windows): Mark externally visible.
2511 * window.c (window_deletion_count): Now static.
2513 * undo.c: Make symbols static if they're not exported.
2514 (last_undo_buffer, last_boundary_position, pending_boundary):
2517 * textprop.c (interval_insert_behind_hooks): Now static.
2518 (interval_insert_in_front_hooks): Likewise.
2520 * term.c: Make symbols static if they're not exported.
2521 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2522 (max_frame_lines, tty_set_terminal_modes):
2523 (tty_reset_terminal_modes, tty_turn_off_highlight):
2524 (get_tty_terminal): Now static.
2525 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2526 * termhooks.h (term_mouse_moveto): Do not declare if
2528 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2529 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2531 * sysdep.c: Make symbols static if they're not exported.
2532 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2534 (sigprocmask_set, full_mask): Remove; unused.
2535 (wait_debugging): Mark as visible.
2536 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2537 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2539 * syntax.c (syntax_temp): Define only if !__GNUC__.
2541 * sound.c (current_sound_device, current_sound): Now static.
2543 * search.c (searchbufs, searchbuf_head): Now static.
2545 * scroll.c (scroll_cost): Remove; unused.
2546 * dispextern.h (scroll_cost): Remove decl.
2548 * region-cache.h (pp_cache): Mark as externally visible.
2550 * process.c: Make symbols static if they're not exported.
2551 (process_tick, update_tick, create_process, chan_process):
2552 (Vprocess_alist, proc_buffered_char, datagram_access):
2553 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2554 (deactivate_process): Mark defn as static, as well as decl.
2555 * lisp.h (create_process): Remove decl.
2556 * process.h (chan_process, Vprocess_alist): Remove decls.
2558 * print.c: Make symbols static if they're not exported.
2559 (print_depth, new_backquote_output, being_printed, print_buffer):
2560 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2561 (print_interval, print_number_index, initial_stderr_stream):
2563 * lisp.h (Fprinc): Remove decl.
2564 (debug_output_compilation_hack): Mark as externally visible.
2566 * sysdep.c (croak): Move decl from here to syssignal.h.
2567 * syssignal.h (croak): Put it here, so the API can be checked when
2568 'croak' is called from dissociate_if_controlling_tty.
2570 * minibuf.c: Make symbols static if they're not exported.
2571 (minibuf_save_list, choose_minibuf_frame): Now static.
2572 * lisp.h (choose_minibuf_frame): Remove decl.
2574 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2576 * lread.c: Make symbols static if they're not exported.
2577 (read_objects, initial_obarray, oblookup_last_bucket_number):
2579 (make_symbol): Remove; unused.
2580 * lisp.h (initial_obarray, make_symbol): Remove decls.
2582 * keyboard.c: Make symbols static if they're not exported.
2583 (single_kboard, recent_keys_index, total_keys, recent_keys):
2584 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2585 (this_single_command_key_start, echoing, last_auto_save):
2586 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2587 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2588 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2589 (Vlispy_mouse_stem, double_click_count):
2591 (force_auto_save_soon): Define only if SIGDANGER.
2592 (ignore_mouse_drag_p): Now static if
2593 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2594 (print_help): Remove; unused.
2595 (stop_character, last_timer_event): Mark as externally visible.
2596 * keyboard.h (ignore_mouse_drag_p): Declare only if
2597 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2598 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2599 * lisp.h (echoing): Remove decl.
2600 (force_auto_save_soon): Declare only if SIGDANGER.
2601 * xdisp.c (redisplay_window): Simplify code, to make it more
2602 obvious that ignore_mouse_drag_p is not accessed if !defined
2603 USE_GTK && !defined HAVE_NS.
2605 * intervals.c: Make symbols static if they're not exported.
2606 (merge_properties_sticky, merge_interval_right, delete_interval):
2608 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2610 * insdel.c: Make symbols static if they're not exported.
2611 However, leave prepare_to_modify_buffer alone. It's never
2612 called from outside this function, but that appears to be a bug.
2613 (combine_after_change_list, combine_after_change_buffer):
2614 (adjust_after_replace, signal_before_change): Now static.
2615 (adjust_after_replace_noundo): Remove; unused.
2616 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2617 (signal_before_change): Remove decls.
2619 * indent.c (val_compute_motion, val_vmotion): Now static.
2621 * image.c: Make symbols static if they're not exported.
2622 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2624 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2625 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2627 * fringe.c (standard_bitmaps): Now static.
2628 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2630 * frame.c: Make symbols static if they're not exported.
2631 (x_report_frame_params, make_terminal_frame): Now static.
2632 (get_frame_param): Now static, unless HAVE_NS.
2633 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2634 (x_get_resource_string): Remove; not used.
2635 * frame.h (make_terminal_frame, x_report_frame_params):
2636 (x_get_resource_string); Remove decls.
2637 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2638 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2640 * font.c, fontset.c: Make symbols static if they're not exported.
2641 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2642 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2643 * font.c (font_close_object): Now static.
2644 * font.h (font_close_object): Remove.
2645 * fontset.c (FONTSET_OBJLIST): Remove.
2646 (free_realized_fontset) #if-0 the body, which does nothing.
2647 (face_suitable_for_char_p): #if-0, as it's never called.
2648 * fontset.h (face_suitable_for_char_p): Remove decl.
2649 * xfaces.c (face_at_string_position):
2650 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2651 since 0 is always ASCII.
2653 * fns.c (weak_hash_tables): Now static.
2655 * fileio.c: Make symbols static if they're not exported.
2656 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2657 (Vwrite_region_annotation_buffers): Now static.
2659 * eval.c: Make symbols static if they're not exported.
2660 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2661 * lisp.h (backtrace_list): Remove decl.
2663 * emacs.c: Make symbols static if they're not exported.
2664 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2665 (fatal_error_code, fatal_error_signal_hook, standard_args):
2667 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2668 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2669 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2670 * lisp.h (fatal_error_signal_hook): Remove decl.
2671 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2673 * editfns.c: Move a (normally-unused) function to its only use.
2674 * editfns.c, lisp.h (get_operating_system_release): Remove.
2675 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2676 worth the hassle of breaking this out.
2678 * xterm.c: Make symbols static if they're not exported.
2679 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2680 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2681 (x_destroy_window, x_delete_display):
2683 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2684 (x_mouse_leave): Remove; unused.
2685 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2686 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2687 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2689 (x_mouse_leave): Declare only if WINDOWSNT.
2690 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2691 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2694 * ftxfont.c: Make symbols static if they're not exported.
2695 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2697 * font.h (ftxfont_driver): Likewise.
2699 * xfns.c: Make symbols static if they're not exported.
2700 (x_last_font_name, x_display_info_for_name):
2701 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2702 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2703 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2704 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2705 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2706 (last_show_tip_args): Now static.
2707 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2708 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2709 (x_screen_planes): Remove; unused.
2710 * dispextern.h (x_screen_planes): Remove decl.
2712 * dispnew.c: Make symbols static if they're not exported.
2713 * dispextern.h (redraw_garbaged_frames, scrolling):
2714 (increment_row_positions): Remove.
2715 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2716 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2718 (redraw_garbaged_frames): Remove; unused.
2720 * xfaces.c: Make symbols static if they're not exported.
2721 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2723 * xterm.h (defined_color): Remove decls.
2724 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2725 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2726 (menu_face_changed_default, defined_color, free_realized_face):
2727 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2728 (ascii_face_of_lisp_face): Remove; unused.
2730 * xdisp.c: Make symbols static if they're not exported.
2731 * dispextern.h (scratch_glyph_row, window_box_edges):
2732 (glyph_to_pixel_coords, set_cursor_from_row):
2733 (get_next_display_element, set_iterator_to_next):
2734 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2735 (show_mouse_face): Remove decls
2736 * frame.h (message_buf_print): Likewise.
2737 * lisp.h (pop_message, set_message, check_point_in_composition):
2739 * xterm.h (set_vertical_scroll_bar): Likewise.
2740 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2741 (message_buf_print, scratch_glyph_row, displayed_buffer):
2742 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2743 (get_next_display_element, show_mouse_face, window_box_edges):
2744 (frame_to_window_pixel_xy, check_point_in_composition):
2745 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2746 (glyph_to_pixel_coords): Remove; unused.
2748 * dired.c (file_name_completion): Now static.
2750 * dbusbind.c (xd_in_read_queued_messages): Now static.
2752 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2753 * data.c (circular_list_error): Remove.
2755 * commands.h (last_point_position, last_point_position_buffer):
2756 (last_point_position_window): Remove decls.
2757 * keyboard.c: Make these variables static.
2759 * coding.h (coding, code_convert_region, encode_coding_gap):
2761 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2762 (iso_code_class, detect_coding, code_convert_region): Now static.
2763 (encode_coding_gap): Remove; unused.
2765 * chartab.c (chartab_chars, chartab_bits): Now static.
2767 * charset.h (charset_iso_8859_1): Remove decl.
2768 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2771 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2772 * ccl.c (Vccl_program_table): Now static.
2773 (check_ccl_update): Remove; unused.
2775 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2776 * category.h: ... from here.
2777 * category.c (check_category_table, set_category_set): Now static.
2779 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2780 * lisp.h: Remove these decls.
2782 * buffer.c (buffer_count): Remove unused var.
2784 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2785 so that it's not optimized away.
2786 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2787 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2788 exported only to the debugger.
2790 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2791 * atimer.h (run_all_atimers): Remove; not exported.
2793 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2794 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2795 was inaccessible from Lisp.
2796 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2797 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2799 alloc.c: Import and export fewer symbols, and remove unused items.
2800 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2802 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2803 it's not optimized away by whole-program optimization.
2804 (message_enable_multibyte, free_misc): Remove.
2805 (catchlist, handlerlist, mark_backtrace):
2806 Declare only if BYTE_MARK_STACK.
2807 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2808 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2809 (message_enable_multibyte): Remove decl.
2810 (free_misc, interval_free_list, float_block, float_block_index):
2811 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2812 (cons_free_list, last_marked_index):
2814 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2815 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2816 (mark_backtrace): Define only if BYTE_MARK_STACK.
2817 * xdisp.c (message_enable_multibyte): Now static.
2819 Declare Lisp_Object Q* variables to be 'static' if not exported.
2820 This makes it easier for human readers (and static analyzers)
2821 to see whether these variables are used from other modules.
2822 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2823 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2824 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2825 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2826 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2827 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2828 * xmenu.c, xselect.c:
2829 Declare Q* vars static if they are not used in other modules.
2830 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2831 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2832 Remove decls of unexported vars.
2833 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2835 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2837 Make Emacs functions such as Fatom 'static' by default.
2838 This makes it easier for human readers (and static analyzers)
2839 to see whether these functions can be called from other modules.
2840 DEFUN now defines a static function. To make the function external
2841 so that it can be used in other C modules, use the new macro DEFUE.
2842 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2843 (Finit_image_library):
2844 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2845 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2846 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2847 Remove decls, since these functions are now static.
2848 (Funintern, Fget_internal_run_time): New decls, since these functions
2849 were already external.
2851 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2852 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2853 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2854 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2855 * keyboard.c, keymap.c, lread.c:
2856 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2857 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2858 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2859 Mark functions with DEFUE instead of DEFUN,
2860 if they are used in other modules.
2861 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2862 decls for now-static functions.
2863 * buffer.h (Fdelete_overlay): Remove decl.
2864 * callproc.c (Fgetenv_internal): Mark as internal.
2865 * composite.c (Fremove_list_of_text_properties): Remove decl.
2866 (Fcomposition_get_gstring): New forward static decl.
2867 * composite.h (Fcomposite_get_gstring): Remove decl.
2868 * dired.c (Ffile_attributes): New forward static decl.
2869 * doc.c (Fdocumntation_property): New forward static decl.
2870 * eval.c (Ffetch_bytecode): New forward static decl.
2871 (Funintern): Remove extern decl; now in .h file where it belongs.
2872 * fileio.c (Fmake_symbolic_link): New forward static decl.
2873 * image.c (Finit_image_library): New forward static decl.
2874 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2875 * intervals.h (Fprevious_property_change):
2876 (Fremove_list_of_text_properties): Remove decls.
2877 * keyboard.c (Fthis_command_keys): Remove decl.
2878 (Fcommand_execute): New forward static decl.
2879 * keymap.c (Flookup_key): New forward static decl.
2880 (Fcopy_keymap): Now static.
2881 * keymap.h (Flookup_key): Remove decl.
2882 * process.c (Fget_process): New forward static decl.
2883 (Fprocess_datagram_address): Mark as internal.
2884 * syntax.c (Fsyntax_table_p): New forward static decl.
2885 (skip_chars): Remove duplicate decl.
2886 * textprop.c (Fprevious_property_change): New forward static decl.
2887 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2889 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2890 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2892 * editfns.c (Fformat): Remove unreachable code.
2894 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2896 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2899 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2901 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2902 when at ZV. (Bug#8487)
2904 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2906 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2908 * keyboard.c (parse_tool_bar_item): Likewise.
2909 * sound.c (sound_cleanup, alsa_close): Likewise.
2910 * termcap.c (tgetent): Likewise.
2911 * xfns.c (x_default_font_parameter): Likewise.
2912 * xsettings.c (read_and_apply_settings): Likewise.
2914 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2915 (overrun_check_free): Protoize.
2917 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2919 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2920 since callers should never pass a negative size.
2921 Change the signature to match that of plain 'read' and 'write'; see
2922 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2923 * lisp.h: Update prototypes of emacs_write and emacs_read.
2925 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2927 * xdisp.c (redisplay_window): Don't try to determine the character
2928 position of the scroll margin if the window start point w->startp
2929 is outside the buffer's accessible region. (Bug#8468)
2931 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2933 Fix write-region and its subroutines for buffers > 2GB.
2934 * fileio.c (a_write, e_write): Modify declaration of arguments and
2935 local variables to support buffers larger than 2GB.
2936 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2938 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2939 argument, local variables, and return value.
2941 * lisp.h: Update prototypes of emacs_write and emacs_read.
2943 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2945 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2947 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2949 Fix more problems found by GCC 4.6.0's static checks.
2951 * xdisp.c (vmessage): Use a better test for character truncation.
2953 * charset.c (load_charset_map): <, not <=, for optimization,
2954 and to avoid potential problems with integer overflow.
2955 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2956 * casetab.c (set_identity, shuffle): Likewise.
2957 * editfns.c (Fformat): Likewise.
2958 * syntax.c (skip_chars): Likewise.
2960 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2961 This also lets GCC 4.6.0 generate slightly better loop code.
2963 * callint.c (Fcall_interactively): <, not <=, for optimization.
2964 (Fcall_interactively): Count the number of arguments produced,
2965 not the number of arguments given. This is simpler and lets GCC
2966 4.6.0 generate slightly better code.
2968 * ftfont.c: Distingish more carefully between FcChar8 and char.
2969 The previous code passed unsigned char * to a functions like
2970 strlen and xstrcasecmp that expect char *, which does not
2971 conform to the C standard.
2972 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2973 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2974 char * when the C standard requires it.
2976 * keyboard.c (read_char): Remove unused var.
2978 * eval.c: Port to Windows vsnprintf (Bug#8435).
2980 (SIZE_MAX): Define if the headers do not.
2981 (verror): Do not give up if vsnprintf returns a negative count.
2982 Instead, grow the buffer. This ports to Windows vsnprintf, which
2983 does not conform to C99. Problem reported by Eli Zaretskii.
2984 Also, simplify the allocation scheme, by avoiding the need for
2985 calling realloc, and removing the ALLOCATED variable.
2987 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2989 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2990 But keep the doprint source code for now, as we might revamp it
2991 and use it again (Bug#8435).
2992 * lisp.h (doprnt): Remove.
2993 * Makefile.in (base_obj): Remove doprnt.o.
2994 * deps.mk (doprnt.o): Remove.
2996 error: Print 32- and 64-bit integers portably (Bug#8435).
2997 Without this change, on typical 64-bit hosts error ("...%d...", N)
2998 was used to print both 32- and 64-bit integers N, which relied on
3000 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3002 * lisp.h (error, verror): Mark as printf-like functions.
3003 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3004 Report overflow in size calculations when allocating printf buffer.
3005 Do not truncate output string at its first null byte.
3006 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3007 Truncate the output at a character boundary, since vsnprintf does not
3009 * charset.c (check_iso_charset_parameter): Convert internal
3010 character to string before calling 'error', since %c now has the
3012 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3013 overflow when computing char to be passed to 'error'. Do not
3014 pass Lisp_Object to 'error'; pass the integer instead.
3015 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3016 formatted with plain %d.
3018 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3020 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3022 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3024 * xterm.c (x_catch_errors): Remove duplicate declaration.
3026 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3028 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3030 2011-04-10 Jim Meyering <meyering@redhat.com>
3032 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3033 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3034 return ssize_t not "int", and use size_t as the buffer length.
3035 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3036 * gnutls.h: Update declarations.
3037 * process.c (read_process_output): Use ssize_t, to match.
3038 (send_process): Likewise.
3040 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3042 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3044 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3046 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3047 Use unsigned char, to match FcChar8 type definition.
3049 * xterm.c (handle_one_xevent):
3050 * xmenu.c (create_and_show_popup_menu):
3051 * xselect.c (x_decline_selection_request)
3052 (x_reply_selection_request): Avoid type-punned deref of X events.
3054 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3056 Fix some uses of `int' instead of EMACS_INT.
3057 * search.c (string_match_1, fast_string_match)
3058 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3059 (scan_buffer, find_next_newline_no_quit)
3060 (find_before_next_newline, search_command, Freplace_match)
3061 (Fmatch_data): Make some `int' variables be EMACS_INT.
3063 * xdisp.c (display_count_lines): 3rd argument and return value now
3064 EMACS_INT. All callers changed.
3065 (pint2hrstr): Last argument is now EMACS_INT.
3067 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3068 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3069 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3070 (decode_coding_utf_16, decode_coding_emacs_mule)
3071 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3072 (decode_coding_ccl, decode_coding_charset)
3073 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3074 (decode_coding_iso_2022, decode_coding_emacs_mule)
3075 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3076 <char_offset, last_offset>: Declare EMACS_INT.
3077 (encode_coding_utf_8, encode_coding_utf_16)
3078 (encode_coding_emacs_mule, encode_invocation_designation)
3079 (encode_designation_at_bol, encode_coding_iso_2022)
3080 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3081 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3083 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3084 (encode_invocation_designation): Last argument P_NCHARS is now
3086 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3087 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3089 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3092 * ccl.c (Fccl_execute_on_string): Declare some variables
3095 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3097 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3099 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3101 * process.c (Fformat_network_address): Doc fix.
3103 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3105 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3107 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3109 * keyboard.c (read_char): Call Lisp function help-form-show,
3110 instead of using internal_with_output_to_temp_buffer.
3111 (Qhelp_form_show): New var.
3112 (syms_of_keyboard): Use DEFSYM macro.
3114 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3116 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3118 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3120 * process.c (Flist_processes): Remove to Lisp.
3121 (list_processes_1): Delete.
3123 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3125 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3127 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3129 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3131 Fix more problems found by GCC 4.6.0's static checks.
3133 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3135 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3137 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3139 * xdisp.c (vmessage): Mark as a printf-like function.
3141 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3143 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3145 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3146 printf-like functions.
3147 (tiff_load): Add casts to remove these marks before passing them
3148 to system-supplied API.
3150 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3152 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3153 This avoids several warnings with gcc -Wstrict-overflow.
3154 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3155 directly, rather than having caller test rule sign. This avoids
3156 some unnecessary tests.
3157 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3158 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3159 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3161 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3162 (xfont_open): Avoid unnecessary tests.
3164 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3166 * composite.h, composite.c (composition_gstring_put_cache):
3167 Use EMACS_INT, not int, for length.
3169 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3170 breaking out part of COMPOSITION_DECODE_RULE.
3171 (COMPOSITION_DECODE_RULE): Use it.
3172 * composite.c (get_composition_id): Remove unused local vars,
3173 by using the new macro.
3175 * textprop.c (set_text_properties_1): Change while to do-while,
3176 since the condition is always true at first.
3178 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3179 (interval_deletion_adjustment): Return unsigned value.
3182 * process.c (list_processes_1, create_pty, read_process_output):
3183 (exec_sentinel): Remove vars that were set but not used.
3184 (create_pty): Remove unnecessary "volatile"s.
3185 (Fnetwork_interface_info): Avoid possibility of int overflow.
3186 (read_process_output): Do adaptive read buffering even if carryover.
3187 (read_process_output): Simplify nbytes computation if buffered.
3189 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3191 * syntax.c (scan_words): Remove var that was set but not used.
3192 (update_syntax_table): Use unsigned instead of int.
3194 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3195 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3196 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3198 * print.c (print_error_message): Avoid int overflow.
3200 * font.c (font_list_entities): Redo for clarity,
3201 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3203 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3204 (font_score): Avoid potential overflow in diff calculation.
3206 * fns.c (substring_both): Remove var that is set but not used.
3207 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3209 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3211 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3212 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3213 can always succeed if overflow has undefined behavior.
3215 * search.c (boyer_moore, wordify): Remove vars set but not used.
3216 (wordify): Omit three unnecessary tests.
3218 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3219 All callers changed. This avoids the need for an unused var.
3221 * casefiddle.c (casify_region): Remove var that is set but not used.
3223 * dired.c (file_name_completion): Remove var that is set but not used.
3225 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3227 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3228 (Finsert_file_contents): Remove unnecessary code checking fd.
3230 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3231 Check for integer overflow on size calculations.
3233 * buffer.c (Fprevious_overlay_change): Remove var that is set
3236 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3237 Remove vars that are set but not used.
3238 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3239 (timer_check_2): Mark vars as initialized.
3241 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3243 * image.c (lookup_image): Remove var that is set but not used.
3244 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3246 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3247 that are set but not used.
3249 * xfns.c (make_invisible_cursor): Don't return garbage
3250 if XCreateBitmapFromData fails (Bug#8410).
3252 * xselect.c (x_get_local_selection, x_handle_property_notify):
3253 Remove vars that are set but not used.
3255 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3256 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3258 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3259 Remove var that is set but not used.
3260 (scroll_bar_windows_size): Now size_t, not int.
3261 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3264 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3265 (map_tty_color) [!defined MSDOS]: Likewise.
3267 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3269 * coding.c: Remove vars that are set but not used.
3270 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3271 All callers changed.
3272 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3273 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3274 (decode_coding_charset): Remove vars that are set but not used.
3276 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3277 that is set but not used.
3279 * print.c (print_object): Remove var that is set but not used.
3281 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3282 The gnulib version avoids calling malloc in the usual case,
3283 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3284 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3285 * filelock.c (current_lock_owner): Likewise.
3286 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3287 * sysdep.c: Include allocator.h, careadlinkat.h.
3288 (emacs_no_realloc_allocator): New static constant.
3289 (emacs_readlink): New function.
3290 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3291 ../lib/careadlinkat.h.
3293 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3295 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3296 first non-nil return value).
3298 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3300 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3301 if not defined (Bug#8403).
3303 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3305 * xdisp.c (display_count_lines): Remove parameter `start',
3306 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3307 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3308 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3309 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3310 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3311 and thereabouts. All callers changed.
3312 (get_per_char_metric): Remove parameter `f', unused since
3313 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3315 2011-04-02 Jim Meyering <meyering@redhat.com>
3317 do not dereference NULL upon failed strdup
3318 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3319 (ns_get_family): Likewise.
3321 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3323 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3325 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3327 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3330 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3332 Add lexical binding.
3334 * window.c (Ftemp_output_buffer_show): New fun.
3335 (Fsave_window_excursion):
3336 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3338 * lread.c (lisp_file_lexically_bound_p): New function.
3339 (Fload): Bind Qlexical_binding.
3340 (readevalloop): Remove `evalfun' arg.
3341 Bind Qinternal_interpreter_environment.
3342 (Feval_buffer): Bind Qlexical_binding.
3343 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3345 (syms_of_lread): Declare `lexical-binding'.
3347 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3349 * keyboard.c (eval_dyn): New fun.
3350 (menu_item_eval_property): Use it.
3352 * image.c (parse_image_spec): Use Ffunctionp.
3354 * fns.c (concat, mapcar1): Accept byte-code-functions.
3356 * eval.c (Fsetq): Handle lexical vars.
3357 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3358 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3359 (FletX, Flet): Obey lexical binding.
3360 (Fcommandp): Handle closures.
3361 (Feval): New `lexical' arg.
3362 (eval_sub): New function extracted from Feval. Use it almost
3363 everywhere where Feval was used. Look up vars in lexical env.
3365 (Ffunctionp): Move from subr.el.
3366 (Ffuncall): Handle closures.
3367 (apply_lambda): Remove `eval_flags'.
3368 (funcall_lambda): Handle closures and new byte-code-functions.
3369 (Fspecial_variable_p): New function.
3370 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3371 but without exporting it to Lisp.
3373 * doc.c (Fdocumentation, store_function_docstring):
3374 * data.c (Finteractive_form): Handle closures.
3376 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3379 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3381 (exec_byte_code): New function extracted from Fbyte_code to handle new
3382 calling convention for byte-code-functions. Add new byte-codes.
3384 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3386 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3388 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3390 * xdisp.c (redisplay_internal): Fix prototype.
3392 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3394 * xdisp.c (SCROLL_LIMIT): New macro.
3395 (try_scrolling): Use it when setting scroll_limit.
3396 Limit scrolling to 100 screen lines.
3397 (redisplay_window): Even when falling back on "recentering",
3398 position point in the window according to scroll-conservatively,
3399 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3401 (try_scrolling): When point is above the window, allow searching
3402 as far as scroll_max, or one screenful, to compute vertical
3403 distance from PT to the scroll margin position. This prevents
3404 try_scrolling from unnecessarily failing when
3405 scroll-conservatively is set to a value slightly larger than the
3406 window height. Clean up the case of PT below the margin at bottom
3407 of window: scroll_max can no longer be INT_MAX. When aggressive
3408 scrolling is in use, don't let point enter the opposite scroll
3409 margin as result of the scroll.
3410 (syms_of_xdisp) <scroll-conservatively>: Document the
3411 threshold of 100 lines for never-recentering scrolling.
3413 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3415 * dispextern.h (move_it_by_lines):
3416 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3417 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3418 (message_log_check_duplicate): Remove parameters `prev_bol' and
3419 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3420 (redisplay_internal): Remove parameter `preserve_echo_area',
3421 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3423 * indent.c (Fvertical_motion):
3424 * window.c (window_scroll_pixel_based, Frecenter):
3425 Don't pass `need_y_p' to `move_it_by_lines'.
3427 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3429 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3430 steal a few bits to be more compact.
3431 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3432 Remove unneeded casts.
3434 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3436 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3438 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3439 binding" message (bug#7967).
3441 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3443 Fix more problems found by GCC 4.6.0's static checks.
3445 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3446 Remove unused local var.
3448 * editfns.c (Fmessage_box): Remove unused local var.
3450 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3451 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3452 Omit unused local vars.
3453 * window.c (shrink_windows): Omit unused local var.
3454 * menu.c (digest_single_submenu): Omit unused local var.
3455 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3456 Omit unused local var.
3458 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3459 Don't assume string length fits in int.
3460 (keyremap_step, read_key_sequence): Use size_t for sizes.
3461 (read_key_sequence): Don't check last_real_key_start redundantly.
3463 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3464 instead of alloca (Bug#8344).
3466 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3467 (Fbacktrace_frame): Don't assume nframes fits in int.
3469 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3471 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3474 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3476 * cm.c (calccost): Turn while-do into do-while, for clarity.
3478 * keyboard.c (syms_of_keyboard): Use the same style as later
3479 in this function when indexing through an array. This also
3480 works around GCC bug 48267.
3482 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3484 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3486 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3487 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3489 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3490 This avoids undefined behavior on integer overflow, and is a bit
3491 more convenient anyway since it is compared to a size_t variable.
3493 Variadic C functions now count arguments with size_t, not int.
3494 This avoids an unnecessary limitation on 64-bit machines, which
3495 caused (substring ...) to crash on large vectors (Bug#8344).
3496 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3497 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3498 All variadic functions and their callers changed accordingly.
3499 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3500 * data.c (arith_driver, float_arith_driver): Likewise.
3501 * editfns.c (general_insert_function): Likewise.
3502 * eval.c (struct backtrace.nargs, interactive_p)
3503 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3504 (funcall_lambda, mark_backtrace): Likewise.
3505 * fns.c (concat): Likewise.
3506 * frame.c (x_set_frame_parameters): Likewise.
3507 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3508 0 if not found, not -1. All callers changed.
3510 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3511 (stack_copy_size): Now size_t, not int.
3512 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3514 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3516 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3517 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3518 All callers changed.
3520 * lisp.h (multibyte_char_to_unibyte):
3521 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3522 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3523 * character.h (CHAR_TO_BYTE8):
3524 * cmds.c (internal_self_insert):
3525 * editfns.c (general_insert_function):
3526 * keymap.c (push_key_description):
3527 * search.c (Freplace_match):
3528 * xdisp.c (message_dolog, set_message_1): All callers changed.
3530 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3532 * keyboard.c (safe_run_hook_funcall): New function.
3533 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3534 don't set the hook to nil, but remove the offending function instead.
3535 (Qcommand_hook_internal): Remove, unused.
3536 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3537 Vcommand_hook_internal.
3539 * eval.c (enum run_hooks_condition): Remove.
3540 (funcall_nil, funcall_not): New functions.
3541 (run_hook_with_args): Call each function through a `funcall' argument.
3542 Remove `cond' argument, now redundant.
3543 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3544 (Frun_hook_with_args_until_failure): Adjust accordingly.
3545 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3547 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3549 * dispextern.h (string_buffer_position): Remove declaration.
3551 * print.c (strout): Remove parameter `multibyte', unused since
3552 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3554 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3555 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3556 All callers changed.
3558 * w32.c (_wsa_errlist): Use braces for struct initializers.
3560 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3561 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3562 All callers changed.
3563 (string_buffer_position): Likewise. Also, make static (it's never
3564 used outside xdisp.c).
3565 (cursor_row_p): Remove parameter `w', unused since
3566 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3567 (decode_mode_spec): Remove parameter `precision', introduced during
3568 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3569 All callers changed.
3571 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3573 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3575 2011-03-27 Anders Lindgren <andlind@gmail.com>
3577 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3578 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3579 (ns_update_auto_hide_menu_bar): New functions.
3580 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3581 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3582 ns_constrain_all_frames.
3583 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3584 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3586 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3588 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3590 2011-03-27 Glenn Morris <rgm@gnu.org>
3592 * syssignal.h: Replace RETSIGTYPE with void.
3593 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3594 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3595 Replace SIGTYPE with void everywhere.
3596 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3597 * s/template.h (SIGTYPE): Remove commented out definition.
3599 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3601 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3602 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3604 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3606 * w32.c (read_unc_volume): Use parameter `henum', instead of
3607 global variable `wget_enum_handle'.
3609 * keymap.c (describe_vector): Remove parameters `indices' and
3610 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3611 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3613 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3615 * keyboard.c (timer_check): Remove parameter `do_it_now',
3616 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3617 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3618 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3620 * keyboard.c (read_char):
3621 * w32menu.c (w32_menu_display_help):
3622 * xmenu.c (show_help_event, menu_help_callback):
3623 Adjust calls to `show_help_echo'.
3625 * gtkutil.c (xg_maybe_add_timer):
3626 * keyboard.c (readable_events):
3627 * process.c (wait_reading_process_output):
3628 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3630 * insdel.c (adjust_markers_gap_motion):
3631 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3632 (gap_left, gap_right): Don't call it.
3634 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3636 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3637 incurred during fontification.
3639 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3641 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3642 (DEFVAR_PER_BUFFER): Don't pass it.
3644 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3645 (scrolling_window): Don't pass it.
3647 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3649 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3651 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3653 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3654 of variables specific to SELinux and computation of `encoded_absname'.
3656 * image.c (XPutPixel): Remove unused variable `height'.
3658 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3660 * unexw32.c (get_section_info): Remove unused variable `section'.
3662 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3663 (system_process_attributes): Remove unused variable `sess'.
3664 (sys_read): Remove unused variable `err'.
3666 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3667 (w32_wnd_proc): Remove unused variable `isdead'.
3668 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3669 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3670 (x_create_tip_frame): Remove unused variable `tem'.
3672 * w32inevt.c (w32_console_read_socket):
3673 Remove unused variable `no_events'.
3675 * w32term.c (x_draw_composite_glyph_string_foreground):
3676 Remove unused variable `width'.
3678 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3680 * w32term.c (x_set_glyph_string_clipping):
3681 Don't pass uninitialized region to CombineRgn.
3683 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3685 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3686 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3687 (Fx_close_connection): Remove unused variable `i'.
3689 * w32font.c (w32font_draw): Return number of glyphs.
3690 (w32font_open_internal): Remove unused variable `i'.
3691 (w32font_driver): Add missing initializer.
3693 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3694 (fill_in_menu): Remove unused variable `items_added'.
3696 * w32term.c (last_mouse_press_frame): Remove static global variable.
3697 (w32_clip_to_row): Remove unused variable `f'.
3698 (x_delete_terminal): Remove unused variable `i'.
3700 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3701 (NOTHING): Remove unused static global variable.
3702 (uniscribe_check_otf): Remove unused variable `table'.
3703 (uniscribe_font_driver): Add missing initializers.
3705 2011-03-23 Julien Danjou <julien@danjou.info>
3707 * term.c (Fsuspend_tty, Fresume_tty):
3708 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3709 * window.c (temp_output_buffer_show):
3710 * insdel.c (signal_before_change):
3711 * frame.c (Fhandle_switch_frame):
3712 * fileio.c (Fdo_auto_save):
3713 * emacs.c (Fkill_emacs):
3714 * editfns.c (save_excursion_restore):
3715 * cmds.c (internal_self_insert):
3716 * callint.c (Fcall_interactively):
3717 * buffer.c (Fkill_all_local_variables):
3718 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3720 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3721 unconditionnaly since it does the check itself.
3723 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3725 Fix more problems found by GCC 4.5.2's static checks.
3727 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3728 the first time through the loop, since we know p0 < p1 then.
3729 This also avoids a gcc -Wstrict-overflow warning.
3731 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3732 leading to a memory leak, possible in functions like
3733 load_charset_map_from_file that can allocate an unbounded number
3734 of objects (Bug#8318).
3736 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3737 that could (at least in theory) be that large.
3739 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3740 This is less likely to overflow, and avoids undefined behavior if
3741 overflow does occur. All callers changed. Use strtoul to scan
3742 for the unsigned long integer.
3743 (pint2hrstr): Simplify and tune code slightly.
3744 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3746 * scroll.c (do_scrolling): Work around GCC bug 48228.
3747 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3749 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3750 This also avoids a warning with gcc -Wstrict-overflow.
3751 (validate_x_resource_name): Simplify count usage.
3752 This also avoids a warning with gcc -Wstrict-overflow.
3754 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3757 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3759 * process.c (Fmake_network_process): Use socklen_t, not int,
3760 where POSIX says socklen_t is required in portable programs.
3761 This fixes a porting bug on hosts like 64-bit HP-UX, where
3762 socklen_t is wider than int (Bug#8277).
3763 (Fmake_network_process, server_accept_connection):
3764 (wait_reading_process_output, read_process_output):
3767 * process.c: Rename or move locals to avoid shadowing.
3768 (list_processes_1, Fmake_network_process):
3769 (read_process_output_error_handler, exec_sentinel_error_handler):
3770 Rename or move locals.
3771 (Fmake_network_process): Define label "retry_connect" only if needed.
3772 (Fnetwork_interface_info): Fix pointer signedness.
3773 (process_send_signal): Add cast to avoid pointer signedness problem.
3774 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3775 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3777 Make tparam.h and terminfo.c consistent.
3778 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3779 Include tparam.h instead, since it declares them.
3780 * cm.h (PC): Remove extern decl; tparam.h now does this.
3781 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3782 * terminfo.c: Include tparam.h, to check interfaces.
3783 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3784 (tparam): Adjust signature to match interface in tparam.h;
3785 this removes some undefined behavior. Check that outstring and len
3786 are zero, which they always are with Emacs.
3787 * tparam.h (PC, BC, UP): New extern decls.
3789 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3790 (xftfont_open): Rename locals to avoid shadowing.
3792 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3793 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3794 (OTF_TAG_SYM): Omit macro if not needed.
3795 (ftfont_list): Remove unused local.
3796 (get_adstyle_property, ftfont_pattern_entity):
3797 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3798 Rename locals to avoid shadowing.
3800 * xfont.c (xfont_list_family): Mark var as initialized.
3802 * xml.c (make_dom): Now static.
3804 * composite.c (composition_compute_stop_pos): Rename local to
3806 (composition_reseat_it): Remove unused locals.
3807 (find_automatic_composition, composition_adjust_point): Likewise.
3808 (composition_update_it): Mark var as initialized.
3809 (find_automatic_composition): Mark vars as initialized,
3810 with a FIXME (Bug#8290).
3812 character.h: Rename locals to avoid shadowing.
3813 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3814 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3815 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3816 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3819 * textprop.c (property_change_between_p): Remove; unused.
3821 * intervals.c (interval_start_pos): Now static.
3823 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3825 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3826 Rename locals to avoid shadowing.
3828 * sound.c (wav_play, au_play, Fplay_sound_internal):
3829 Fix pointer signedness.
3830 (alsa_choose_format): Remove unused local var.
3831 (wav_play): Initialize a variable to 0, to prevent undefined
3832 behavior (Bug#8278).
3834 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3836 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3838 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3839 clobbering (Bug#8298).
3840 * sysdep.c (sys_subshell): Likewise.
3841 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3843 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3844 This should get cleaned up, so that child_setup has the
3845 same signature on all platforms.
3847 * callproc.c (call_process_cleanup): Now static.
3848 (relocate_fd): Rename locals to avoid shadowing.
3850 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3852 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3853 not to be necessary, and produces flickering.
3855 2011-03-20 Glenn Morris <rgm@gnu.org>
3857 * config.in: Remove file.
3859 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3861 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3862 are now in src/globals.h.
3863 (syms_of_minibuf): Remove spurious & from previous change.
3865 2011-03-20 Leo <sdl.web@gmail.com>
3867 * minibuf.c (completing-read-function): New variable.
3868 (completing-read-default): Rename from completing-read.
3869 (completing-read): Call completing-read-function.
3871 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3873 * xfaces.c (Fx_load_color_file):
3874 Read color file from absolute filename (bug#8250).
3876 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3878 * makefile.w32-in: Update dependencies.
3880 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3882 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3884 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3886 Fix more problems found by GCC 4.5.2's static checks.
3888 * process.c (make_serial_process_unwind, send_process_trap):
3889 (sigchld_handler): Now static.
3891 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3892 That way, the code declares only the vars that it needs.
3893 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3894 * s/cygwin.h (PTY_ITERATION): Likewise.
3895 * s/darwin.h (PTY_ITERATION): Likewise.
3896 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3898 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3899 * process.c (allocate_pty): Don't declare stb unless it's needed.
3901 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3902 (CONSTANTLIM): Remove; unused.
3903 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3904 Define only if needed.
3906 * unexelf.c (unexec): Name an expression,
3907 to avoid gcc -Wbad-function-cast warning.
3908 Use a different way to cause a compilation error if anyone uses
3909 n rather than nn, a way that does not involve shadowing.
3910 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3912 * deps.mk (unexalpha.o): Remove; unused.
3914 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3915 * unexec.h: New file.
3916 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3917 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3919 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3920 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3921 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3922 Change as necessary to match prototype in unexec.h.
3924 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3926 (back_comment, skip_chars): Mark vars as initialized.
3928 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3929 Rename locals to avoid shadowing.
3931 * lread.c (read1): Rewrite so as not to use empty "else".
3932 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3934 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3936 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3937 warning when compiling print.c.
3939 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3940 instead of using an uninitialized var.
3941 (font_sort_entities): Mark var as initialized.
3943 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3945 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3946 pointers to constants.
3947 (font_parse_fcname): Remove unused vars.
3948 (font_delete_unmatched): Now static.
3949 (font_get_spec): Remove; unused.
3950 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3951 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3952 Rename or move locals to avoid shadowing.
3954 * fns.c (require_nesting_list, require_unwind): Now static.
3955 (Ffillarray): Rename locals to avoid shadowing.
3957 * floatfns.c (domain_error2): Define only if needed.
3958 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3960 * alloc.c (mark_backtrace): Move decl from here ...
3961 * lisp.h: ... to here, so that it can be checked.
3963 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3964 (Fdefvar): Rewrite so as not to use empty "else".
3965 (lisp_indirect_variable): Name an expression,
3966 to avoid gcc -Wbad-function-cast warning.
3967 (Fdefvar): Rename locals to avoid shadowing.
3969 * callint.c (quotify_arg, quotify_args): Now static.
3970 (Fcall_interactively): Rename locals to avoid shadowing.
3971 Use const pointer when appropriate.
3973 * lisp.h (get_system_name, get_operating_system_release):
3974 Move decls here, to check interfaces.
3975 * process.c (get_operating_system_release): Move decl to lisp.h.
3976 * xrdb.c (get_system_name): Likewise.
3977 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3978 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3979 some of which prompt warnings from gcc -Wbad-function-cast.
3980 (Fformat_time_string, Fencode_time, Finsert_char):
3981 (Ftranslate_region_internal, Fformat):
3982 Rename or remove local vars to avoid shadowing.
3983 (Ftranslate_region_internal): Mark var as initialized.
3985 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3988 * lisp.h (eassert): Check that the argument compiles, even if
3989 ENABLE_CHECKING is not defined.
3991 * data.c (Findirect_variable): Name an expression, to avoid
3992 gcc -Wbad-function-cast warning.
3993 (default_value, arithcompare, arith_driver, arith_error): Now static.
3994 (store_symval_forwarding): Rename local to avoid shadowing.
3995 (Fmake_variable_buffer_local, Fmake_local_variable):
3996 Mark variables as initialized.
3997 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3999 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4000 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4001 Rename locals to avoid shadowing.
4002 (mark_stack): Move local variables into the #ifdef region where
4004 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4005 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4007 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4008 (GC_STRING_CHARS): Remove; not used.
4009 (Fmemory_limit): Cast sbrk's returned value to char *.
4011 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4012 avoids undefined behavior in theory.
4014 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4016 Use functions, not macros, for up- and down-casing (Bug#8254).
4017 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4018 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4019 to use the following functions instead of these macros.
4020 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4021 EMACS_INT, since callers assume the returned value fits in int.
4022 (upcase1): Likewise, for UPCASE_TABLE.
4023 (uppercasep, lowercasep, upcase): New static inline functions.
4024 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4025 the race-condition problem in the old DOWNCASE.
4027 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4028 Rename locals to avoid shadowing.
4029 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4030 (regex_compile, re_search_2, re_match_2_internal):
4031 Remove unused local vars.
4032 (FREE_VAR): Rewrite so as not to use empty "else",
4033 which gcc can warn about.
4034 (regex_compile, re_match_2_internal): Mark locals as initialized.
4035 (RETALLOC_IF): Define only if needed.
4036 (WORDCHAR_P): Likewise. This one is never needed, but is used
4037 only in a comment talking about a compiler bug, so put inside
4038 the #if 0 of that comment.
4039 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4040 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4043 * search.c (boyer_moore): Rename locals to avoid shadowing.
4044 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4045 (PREV_CHAR_BOUNDARY): Likewise.
4047 * search.c (simple_search): Remove unused var.
4049 * dired.c (compile_pattern): Move decl from here ...
4050 * lisp.h: ... to here, so that it can be checked.
4051 (struct re_registers): New forward decl.
4053 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4055 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4057 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4058 Rename locals to avoid shadowing.
4059 (Fvertical_motion): Mark locals as initialized.
4061 * casefiddle.c (casify_object, casify_region): Now static.
4062 (casify_region): Mark local as initialized.
4064 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4066 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4067 New macros, so that the caller can use some names other than
4068 gcpro1, gcpro2, etc.
4069 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4071 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4072 argument, for consistency with GCPRO2_VAR, etc: it is now the
4073 prefix of the variable, not the variable itself. All uses
4075 * dired.c (directory_files_internal, file_name_completion):
4076 Rename locals to avoid shadowing.
4078 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4079 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4080 dired.c's scmp function, had undefined behavior.
4081 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4082 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4083 * buffer.h: ... to here, because these macros use current_buffer,
4084 and the new implementation with inline functions needs to have
4085 current_buffer in scope now, rather than later when the macros
4087 (downcase, upcase1): New static inline functions.
4088 (DOWNCASE, UPCASE1): Reimplement using these functions.
4089 This avoids undefined behavior in expressions like
4090 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4091 from race conditions in accessing the global variables
4092 case_temp1 and case_temp2.
4093 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4094 * lisp.h (case_temp1, case_temp2): Remove their decls.
4095 * character.h (ASCII_CHAR_P): Move from here ...
4096 * lisp.h: ... to here, so that the inline functions mentioned
4099 * dired.c (directory_files_internal_unwind): Now static.
4101 * fileio.c (file_name_as_directory, directory_file_name):
4102 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4104 (file_name_as_directory): Use const pointers when appropriate.
4105 (Fexpand_file_name): Likewise. In particular, newdir might
4106 point at constant storage, so make it a const pointer.
4107 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4108 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4110 (Fset_file_times, Finsert_file_contents, auto_save_error):
4111 Rename locals to avoid shadowing.
4113 * minibuf.c (choose_minibuf_frame_1): Now static.
4114 (Ftry_completion, Fall_completions): Rename or remove locals
4117 * marker.c (bytepos_to_charpos): Remove; unused.
4119 * lisp.h (verify_bytepos, count_markers): New decls,
4120 so that gcc does not warn that these functions aren't declared.
4122 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4123 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4124 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4125 (copy_text): Remove unused local var.
4127 * filelock.c (within_one_second): Now static.
4128 (lock_file_1): Rename local to avoid shadowing.
4130 * buffer.c (fix_overlays_before): Mark locals as initialized.
4131 (fix_start_end_in_overlays): Likewise. This function should be
4132 simplified by using pointers-to-pointers, but that's a different
4134 (switch_to_buffer_1): Now static.
4135 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4136 (report_overlay_modification): Rename locals to avoid shadowing.
4138 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4139 Fix pointer signedness issue.
4140 (sys_subshell): Mark local as volatile if checking for lint,
4141 to suppress a gcc -Wclobbered warning that does not seem to be right.
4142 (MAXPATHLEN): Define only if needed.
4144 * process.c (serial_open, serial_configure): Move decls from here ...
4145 * systty.h: ... to here, so that they can be checked.
4147 * fns.c (get_random, seed_random): Move extern decls from here ...
4148 * lisp.h: ... to here, so that they can be checked.
4150 * sysdep.c (reset_io): Now static.
4151 (wait_for_termination_signal): Remove; unused.
4153 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4154 (copy_keymap_item, append_key, push_text_char_description):
4156 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4157 (DENSE_TABLE_SIZE): Remove; unused.
4158 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4159 (describe_map_tree):
4160 Rename locals to avoid shadowing.
4162 * keyboard.c: Declare functions static if they are not used elsewhere.
4163 (echo_char, echo_dash, cmd_error, top_level_2):
4164 (poll_for_input, handle_async_input): Now static.
4165 (read_char, kbd_buffer_get_event, make_lispy_position):
4166 (make_lispy_event, make_lispy_movement, apply_modifiers):
4167 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4168 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4169 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4170 (read_key_sequence, read_char): Mark locals as initialized.
4171 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4173 * keyboard.h (make_ctrl_char): New decl.
4174 (mark_kboards): Move decl here ...
4175 * alloc.c (mark_kboards): ... from here.
4177 * lisp.h (force_auto_save_soon): New decl.
4179 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4180 (DEFINE_DUMMY_FUNCTION): New macro.
4181 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4183 (main): Add casts to avoid warnings
4184 if GCC considers string literals to be constants.
4186 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4188 * dbusbind.c: Pointer signedness fixes.
4189 (xd_signature, xd_append_arg, xd_initialize):
4190 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4191 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4192 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4193 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4195 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4196 if GCC considers string literals to be constants.
4197 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4199 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4201 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4202 (print_preprocess, print_object): New macro to fix last change.
4204 * print.c (print_preprocess): Don't forget font objects.
4206 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4208 * emacs.c (USAGE3): Doc fixes.
4210 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4212 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4215 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4217 * lisp.h (VWindow_system, Qfile_name_history):
4218 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4219 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4220 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4222 * w32select.c: Don't #include "keyboard.h".
4223 (run_protected): Add extern declaration for waiting_for_input.
4225 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4226 * w32console.c (detect_input_pending, read_input_pending)
4227 (encode_terminal_code):
4228 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4229 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4230 (w32_system_caret_y, Qfile_name_history):
4231 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4232 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4233 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4234 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4235 * w32proc.c (Qlocal, report_file_error):
4236 * w32term.c (Vwindow_system, updating_frame):
4237 * w32uniscribe.c (initialized, uniscribe_font_driver):
4238 Remove unneeded extern declarations.
4240 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4242 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4244 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4246 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4247 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4248 These macros can no longer be used for assignment.
4250 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4251 Assign struct members directly, instead of using BUF_BEGV etc.
4252 (record_buffer_markers, fetch_buffer_markers): New functions for
4253 recording and fetching special buffer markers.
4254 (set_buffer_internal_1, set_buffer_temp): Use them.
4256 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4258 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4260 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4261 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4263 * xdisp.c (hscroll_window_tree):
4264 (reconsider_clip_changes): Use PT instead of BUF_PT.
4266 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4268 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4269 $(EMACS_ROOT)/lib/intprops.h.
4271 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4273 Fix more problems found by GCC 4.5.2's static checks.
4275 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4276 to unsigned char * to avoid compiler diagnostic.
4277 (xg_free_frame_widgets): Make it clear that a local variable is
4278 needed only if USE_GTK_TOOLTIP.
4279 (gdk_window_get_screen): Make it clear that this macro is needed
4280 only if USE_GTK_TOOLTIP.
4281 (int_gtk_range_get_value): New function, which avoids a diagnostic
4282 from gcc -Wbad-function-cast.
4283 (xg_set_toolkit_scroll_bar_thumb): Use it.
4284 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4285 diagnostic from gcc -Wbad-function-cast.
4286 (get_utf8_string, xg_get_file_with_chooser):
4287 Rename locals to avoid shadowing.
4288 (create_dialog): Move locals to avoid shadowing.
4290 * xgselect.c (xg_select): Remove unused var.
4292 * image.c (four_corners_best): Mark locals as initialized.
4293 (gif_load): Initialize transparent_p to zero (Bug#8238).
4294 Mark another local as initialized.
4295 (my_png_error, my_error_exit): Mark with NO_RETURN.
4297 * image.c (clear_image_cache): Now static.
4298 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4299 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4300 (x_edge_detection): Remove unnecessary cast that
4301 gcc -Wbad-function-cast diagnoses.
4302 (gif_load): Fix pointer signedness.
4303 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4304 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4306 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4308 Improve quality of tests for time stamp overflow.
4309 For example, without this patch (encode-time 0 0 0 1 1
4310 1152921504606846976) returns the obviously-bogus value (-948597
4311 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4312 reports time overflow. See
4313 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4314 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4315 * editfns.c: Include limits.h and intprops.h.
4316 (TIME_T_MIN, TIME_T_MAX): New macros.
4317 (time_overflow): Move earlier, to before first use.
4318 (hi_time, lo_time): New functions, for an accurate test for
4320 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4321 (Fget_internal_run_time): Don't assume time_t fits in int.
4322 (make_time): Use list2 instead of Fcons twice.
4323 (Fdecode_time): More accurate test for out-of-range times.
4324 (check_tm_member): New function.
4325 (Fencode_time): Use it, to test for out-of-range times.
4326 (lisp_time_argument): Don't rely on undefined left-shift and
4327 right-shift behavior when checking for time stamp overflow.
4329 * editfns.c (time_overflow): New function, refactoring common code.
4330 (Fformat_time_string, Fdecode_time, Fencode_time):
4331 (Fcurrent_time_string): Use it.
4333 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4334 * dired.c (make_time): Move to ...
4335 * editfns.c (make_time): ... here.
4336 * systime.h: Note the move.
4338 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4340 * fringe.c (update_window_fringes): Remove unused variables.
4342 * unexmacosx.c (copy_data_segment): Also copy __got section.
4345 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4347 * termcap.c [MSDOS]: Include "msdos.h".
4348 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4349 Constify `char *' arguments and their references according to
4350 prototypes in tparam.h.
4352 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4354 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4355 Adapt all references accordingly.
4357 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4359 2011-03-11 Tom Tromey <tromey@redhat.com>
4361 * buffer.c (syms_of_buffer): Remove obsolete comment.
4363 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4365 * termhooks.h (encode_terminal_code): Declare prototype.
4367 * msdos.c (encode_terminal_code): Don't declare prototype.
4369 * term.c (encode_terminal_code): Now external again, used by
4370 w32console.c and msdos.c.
4372 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4373 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4375 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4377 Fix some minor problems found by GCC 4.5.2's static checks.
4379 * fringe.c (update_window_fringes): Mark locals as initialized
4381 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4383 * alloc.c (mark_fringe_data): Move decl from here ...
4384 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4385 to check its interface.
4386 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4388 * fontset.c (free_realized_fontset): Now static.
4389 (Fset_fontset_font): Rename local to avoid shadowing.
4390 (fontset_font): Mark local as initialized.
4391 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4393 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4395 * xselect.c (x_disown_buffer_selections): Remove; not used.
4396 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4397 (x_own_selection, Fx_disown_selection_internal): Rename locals
4399 (x_handle_dnd_message): Remove local to avoid shadowing.
4401 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4402 so that the caller can use some name other than gcpro1.
4403 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4404 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4405 (Fx_backspace_delete_keys_p):
4406 Use them to avoid shadowing, and rename vars to avoid shadowing.
4407 (x_decode_color, x_set_name, x_window): Now static.
4408 (Fx_create_frame): Add braces to silence GCC warning.
4409 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4410 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4411 Remove unused locals.
4412 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4413 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4414 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4417 * xterm.h (x_mouse_leave): New decl.
4419 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4420 Remove unused functions.
4421 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4422 (x_calc_absolute_position): Now static.
4423 (XTread_socket): Don't define label "out" unless it's used.
4424 Don't declare local "event" unless it's used.
4425 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4426 unless they are used.
4427 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4428 (x_fatal_error_signal): Remove; not used.
4429 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4430 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4431 (x_error_catcher, x_connection_closed, x_error_handler):
4432 (x_error_quitter, xembed_send_message, x_iconify_frame):
4433 (my_log_handler): Rename locals to avoid shadowing.
4434 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4435 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4437 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4438 Rename or move locals to avoid shadowing.
4439 (tty_defined_color, merge_face_heights): Now static.
4440 (free_realized_faces_for_fontset): Remove; not used.
4441 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4442 does not deduce is never used uninitialized.
4443 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4444 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4446 * terminal.c (store_terminal_param): Now static.
4448 * xmenu.c (menu_highlight_callback): Now static.
4449 (set_frame_menubar): Remove unused local.
4450 (xmenu_show): Rename parameter to avoid shadowing.
4451 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4452 since they might point to immutable storage.
4453 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4454 since it's unused otherwise.
4456 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4457 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4458 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4459 avoids a gcc -Wuninitialized diagnostic.
4460 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4461 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4462 does not deduce are never used uninitialized.
4464 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4466 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4467 * window.c (window_loop, size_window):
4468 (run_window_configuration_change_hook, enlarge_window): Likewise.
4470 * window.c (display_buffer): Now static.
4471 (size_window): Mark variables that gcc -Wuninitialized
4472 does not deduce are never used uninitialized.
4473 * window.h (check_all_windows): New decl, to forestall
4474 gcc -Wmissing-prototypes diagnostic.
4475 * dispextern.h (bidi_dump_cached_states): Likewise.
4477 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4479 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4481 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4482 and to avoid gcc -Wuninitialized warning.
4483 (load_charset_map): Mark variables that gcc -Wuninitialized
4484 does not deduce are never used uninitialized.
4485 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4487 * coding.c (coding_set_source, coding_set_destination):
4488 Use "else { /* comment */ }" rather than "else /* comment */;"
4489 for clarity, and to avoid gcc -Wempty-body warning.
4490 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4491 a block, when the outer 'i' will do.
4492 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4493 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4494 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4495 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4496 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4497 Rename locals to avoid shadowing.
4498 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4499 * coding.c (emacs_mule_char, encode_invocation_designation):
4500 Now static, since they're not used elsewhere.
4501 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4502 (decode_coding_object, encode_coding_object, detect_coding_system):
4503 (decode_coding_emacs_mule): Mark variables that gcc
4504 -Wuninitialized does not deduce are never used uninitialized.
4505 (detect_coding_iso_2022): Initialize a local variable that might
4506 be used uninitialized. Leave a FIXME because it's not clear that
4507 this initialization is needed. (Bug#8211)
4508 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4509 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4510 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4511 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4512 Remove unused macros.
4514 * category.c (hash_get_category_set): Remove unused local var.
4515 (copy_category_table): Now static, since it's not used elsewhere.
4516 * character.c (string_count_byte8): Likewise.
4518 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4519 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4521 * chartab.c (copy_sub_char_table): Now static, since it's not used
4523 (sub_char_table_ref_and_range, char_table_ref_and_range):
4524 Rename locals to avoid shadowing.
4525 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4527 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4528 (BIDI_BOB): Remove unused macro.
4530 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4531 deduce are never used uninitialized.
4532 * term.c (encode_terminal_code): Likewise.
4534 * term.c (encode_terminal_code): Now static. Remove unused local.
4536 * tparam.h: New file.
4537 * term.c, tparam.h: Include it.
4538 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4539 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4540 Move these decls to tparam.h, and make them agree with what
4541 is actually in tparam.c. The previous trick of using incompatible
4542 decls in different modules does not conform to the C standard.
4543 All callers of tparam changed to use tparam's actual API.
4544 * tparam.c (tparam1, tparam, tgoto):
4545 Use const pointers where appropriate.
4547 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4548 * cm.h (struct cm): Likewise.
4549 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4550 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4551 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4552 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4553 (turn_on_face, init_tty): Likewise.
4554 * termchar.h (struct tty_display_info): Likewise.
4556 * term.c (term_mouse_position): Rename local to avoid shadowing.
4558 * alloc.c (mark_ttys): Move decl from here ...
4559 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4561 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4563 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4565 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4567 * search.c (compile_pattern_1): Remove argument regp, unused since
4568 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4569 (compile_pattern): Don't pass it.
4571 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4573 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4574 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4576 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4578 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4580 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4581 gdk_window_get_screen, gdk_window_get_geometry,
4582 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4583 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4584 (xg_get_pixbuf_from_pixmap): New function.
4585 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4586 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4587 Call xg_get_pixbuf_from_pixmap instead of
4588 gdk_pixbuf_get_from_drawable.
4589 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4590 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4591 (xg_check_special_colors): Use GtkStyleContext and its functions
4593 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4594 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4595 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4596 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4597 Call gtk_widget_get_preferred_size.
4598 (xg_frame_resized): gdk_window_get_geometry only takes 5
4600 (xg_win_to_widget, xg_event_is_for_menubar):
4601 Call gdk_x11_window_lookup_for_display.
4602 (xg_set_widget_bg): New function.
4603 (delete_cb): New function.
4604 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4605 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4606 (xg_set_background_color): Call xg_set_widget_bg.
4607 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4608 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4609 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4610 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4612 (update_frame_tool_bar): Call gtk_widget_hide.
4613 (xg_initialize): Use GDK_KEY_g.
4615 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4617 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4619 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4620 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4621 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4623 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4625 * w32xfns.c (select_palette): Check success of RealizePalette against
4626 GDI_ERROR, not zero.
4628 See ChangeLog.11 for earlier changes.
4634 Copyright (C) 2011 Free Software Foundation, Inc.
4636 This file is part of GNU Emacs.
4638 GNU Emacs is free software: you can redistribute it and/or modify
4639 it under the terms of the GNU General Public License as published by
4640 the Free Software Foundation, either version 3 of the License, or
4641 (at your option) any later version.
4643 GNU Emacs is distributed in the hope that it will be useful,
4644 but WITHOUT ANY WARRANTY; without even the implied warranty of
4645 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4646 GNU General Public License for more details.
4648 You should have received a copy of the GNU General Public License
4649 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.