1 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
4 Don't assume buffer size fits in 'int'. Remove unused local.
6 Use C99-style 'extern inline' if available.
7 * buffer.h (BUFFER_INLINE):
8 * category.h (CATEGORY_INLINE):
9 * character.h (CHARACTER_INLINE):
10 * charset.h (CHARSET_INLINE):
11 * composite.h (COMPOSITE_INLINE):
12 * dispextern.h (DISPEXTERN_INLINE):
13 * lisp.h (LISP_INLINE):
14 * systime.h (SYSTIME_INLINE):
15 New macro, replacing 'static inline' in this header.
16 * buffer.h, category.h, character.h, charset.h, composite.h:
17 * dispextern.h, lisp.h, systime.h:
18 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
19 * alloc.c (LISP_INLINE):
20 * buffer.c (BUFFER_INLINE):
21 * category.c (CATEGORY_INLINE):
22 * character.c (CHARACTER_INLINE):
23 * charset.c (CHARSET_INLINE):
24 * composite.c (COMPOSITE_INLINE):
25 * dispnew.c (DISPEXTERN_INLINE):
26 * sysdep.c (SYSTIME_INLINE):
27 Define to EXTERN_INLINE, so that the corresponding functions
28 are compiled into code.
29 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
30 (INLINE_HEADER_END): New macros.
31 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
32 since it's used in non-static inline functions now.
34 2012-08-02 Glenn Morris <rgm@gnu.org>
36 * s/: Remove empty directory.
38 * s/ms-w32.h: Move to ../nt/inc.
39 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
40 Update for new ms-w32.h location.
42 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
45 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
47 2012-08-02 Glenn Morris <rgm@gnu.org>
49 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
50 hard-coding the path separator.
52 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
54 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
55 This how ASET and AREF are supposed to work, and makes
56 it easier to think about future improvements. See
57 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
58 * charset.h (set_charset_attr): New function.
59 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
60 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
61 (aref_addr): New function. All uses of &AREF(...) changed.
62 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
63 (set_hash_index): New functions. All lvalue-style uses of
64 HASH_KEY etc. changed.
65 * keyboard.c (set_prop): New function. All lvalue-style uses
68 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
70 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
71 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
72 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
73 * nsfns.m (ns_set_name_as_filename): Likewise.
74 * nsmenu.m (ns_update_menubar): Likewise.
75 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
77 2012-08-01 Eli Zaretskii <eliz@gnu.org>
79 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
80 Adapt to latest changes in field names of the corresponding Lisp
83 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
85 2012-08-01 Glenn Morris <rgm@gnu.org>
87 * s/msdos.h: Remove file.
88 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
89 * Makefile.in (S_FILE): Remove.
90 (config_h): Remove S_FILE.
92 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
94 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
95 Remove; moved to nt/config.nt.
97 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
99 Use INTERNAL_FIELD for conses and overlays.
100 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
101 Remove obsolete comment.
103 (struct Lisp_Overlay): Use INTERNAL_FIELD.
104 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
106 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
108 Use INTERNAL_FIELD for symbols.
109 * lisp.h (SVAR): New macro. Adjust users.
110 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
111 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
113 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
115 Use INTERNAL_FIELD for processes.
116 * process.h (PVAR): New macro. Adjust style.
117 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
118 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
120 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
122 Use INTERNAL_FIELD for windows.
123 * window.h (WVAR): New macro.
124 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
125 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
126 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
127 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
128 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
129 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
131 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
133 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
135 2012-08-01 Glenn Morris <rgm@gnu.org>
137 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
138 Move to configure.ac.
140 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
142 * makefile.w32-in (CONFIG_H): Update dependencies.
143 (CONF_POST_H): New macro.
145 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
147 2012-07-31 Glenn Morris <rgm@gnu.org>
149 * Makefile.in (S_FILE): No longer set by configure.
151 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
153 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
155 * process.h (NULL_DEVICE):
157 * editfns.c (USER_FULL_NAME): Let configure set them.
159 * s/README, s/template.h: Remove files.
161 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
163 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
164 Move to configure.ac.
166 2012-07-31 Eli Zaretskii <eliz@gnu.org>
168 * .gdbinit (xframe): Adapt to introduction of FVAR and the
169 resulting renaming of 'struct frame' members.
171 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
173 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
174 after introduction of FVAR.
176 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
178 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
180 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
181 instead of compositeToPoint.
182 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
184 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
186 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
188 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
189 * lisp.h (INTERNAL_FIELD): New macro.
190 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
191 (BVAR): Change to use INTERNAL_FIELD.
192 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
193 (KVAR): Change to use INTERNAL_FIELD.
194 * frame.h (FVAR): New macro.
195 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
196 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
197 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
198 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
199 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
201 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
203 Miscellaneous fixes for non-default X toolkits.
204 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
205 * xterm.c (x_frame_of_widget): Remove redundant prototype.
206 Move under #ifdef USE_LUCID.
207 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
208 definition and usage to avoid warnings.
210 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
212 * nsterm.m (openFiles): Fix previous checkin.
214 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
216 * indent.c (compute_motion): Remove unused local.
218 2012-07-31 Glenn Morris <rgm@gnu.org>
220 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
222 * conf_post.h [USG5_4]:
223 Move remaining contents of s/usg5-4-common.h here.
224 * s/usg5-4-common.h: Remove file.
226 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
227 * s/irix6-5.h: Remove file.
229 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
230 * s/darwin.h: Remove file.
232 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
233 * s/hpux10-20.h: Remove file, which is now empty.
235 2012-07-30 Glenn Morris <rgm@gnu.org>
237 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
238 * Makefile.in (config_h): Add conf_post.h.
239 * makefile.w32-in (CONFIG_H): Add conf_post.h.
241 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
243 * nsterm.m (ns_do_open_file): New variable.
244 (ns_term_init): Set ns_do_open_file to YES after run returns.
245 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
246 files only if ns_do_open_file.
248 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
250 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
251 This no-op macro hasn't been needed for many years.
252 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
254 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
255 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
256 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
257 gdb_make_enums_visible.
258 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
259 (DIRECTORY_SEP): Now a constant, not a macro.
261 2012-07-30 Eli Zaretskii <eliz@gnu.org>
263 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
264 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
266 * w32term.c <w32_keyboard_codepage>: Renamed from
267 keyboard_codepage and now external. All users changed.
269 * w32term.h: Add declaration of w32_keyboard_codepage.
271 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
272 the codepage to translate keys to Unicode. If this argument is
273 -1, use the value returned by GetConsoleCP. All callers changed.
275 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
277 Update .PHONY listings in makefiles.
278 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
279 bootstrap-clean, distclean, maintainer-clean, versioclean,
282 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
283 This is a bit clearer. Fix some commentary typos.
285 2012-07-30 Glenn Morris <rgm@gnu.org>
287 * s/netbsd.h: Let configure include signal.h if needed.
288 Remove file, which is now empty.
290 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
291 Let configure set them.
292 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
293 No more need to undefine.
295 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
297 * keymap.c (Fkey_description): Don't remove 0x80 bit from
298 non-single-byte char when adding meta modifier. (Bug#12090)
300 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
302 Convert safe_call to use variable number of arguments.
303 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
304 (safe_call2): Fix comment.
305 * lisp.h (safe_call): Adjust prototype.
306 * coding.c (encode_coding_object): Change to use safe_call2.
307 * xfaces.c (merge_face_heights): Change to use safe_call1.
309 2012-07-30 Glenn Morris <rgm@gnu.org>
311 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
312 does that unconditionally. Remove file, which is now empty.
314 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
317 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
319 Export to GDB most of lisp.h's remaining object-like macros.
320 * lisp.h (min, max): Move earlier, because they're used earlier now.
321 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
322 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
323 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
324 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
325 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
326 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
327 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
328 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
329 Now constants, for GDB. They need not be macros.
330 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
331 Now constants, for GDB, as well as macros, for static initializers.
332 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
333 Move to after the definition of struct Lisp_Char_Table,
334 since the former now needs that type defined.
335 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
336 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
337 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
338 New enums, for gdb_make_enums_visible.
339 (GLYPH_MODE_LINE_FACE): Remove; unused.
340 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
341 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
342 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
343 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
344 enum maxargs, enum MAX_ALLOCA.
345 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
346 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
347 no longer needed, now that they are done in lisp.h.
349 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
351 Cleanup string bytes checking.
352 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
353 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
354 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
355 (check_sblock, compact_small_strings): Simplify.
357 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
359 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
360 These macros are confusing and no longer need to be defined, as
361 the enum values now suffice. All uses replaced with definiens.
362 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
364 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
366 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
367 ($(BLD)/w32console.$(O)): Update dependencies.
369 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
371 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
372 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
374 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
376 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
378 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
379 setting sitelisp (Bug#12010).
381 2012-07-29 Eli Zaretskii <eliz@gnu.org>
383 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
385 * w32heap.c (cache_system_info):
386 * w32.c (sys_rename):
387 * w32proc.c (find_child_console, sys_kill): All users changed.
389 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
391 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
393 2012-07-29 Eli Zaretskii <eliz@gnu.org>
395 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
397 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
399 Cleanup statistics calculation in Fgarbage_collect.
400 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
401 zombies percentage calculation. Simplify elapsed time calculation.
403 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
405 Generalize marker debugging code under MARKER_DEBUG and use eassert.
406 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
407 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
408 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
409 (replace_range, replace_range_2, del_range_2): Change to eassert.
410 * marker.c (byte_char_debug_check): Adjust style.
412 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
414 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
415 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
416 long-ago-commented-out code that talks about "WIN32".
417 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
420 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
422 Use Gnulib stdalign module (Bug#9772, Bug#9960).
423 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
424 Simplify by using alignof.
425 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
426 * lisp.h: Include <stdalign.h>.
427 (GCALIGNMENT): New macro and constant.
428 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
429 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
430 (stdalign): New macro, if not already defined.
432 2012-07-28 Eli Zaretskii <eliz@gnu.org>
434 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
435 * w32inevt.c: Include w32inevt.h.
436 (w32_read_console_input): New inline function, calls either
437 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
438 w32_console_unicode_input.
439 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
440 (w32_kbd_patch_key, key_event): Use the codepage returned by
441 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
442 (key_event): use uChar.UnicodeChar only if
443 w32_console_unicode_input is non-zero.
445 * w32console.c: Include w32heap.h.
446 <w32_console_unicode_input>: New global variable.
447 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
448 family of Windows, zero otherwise.
450 * w32inevt.h: Declare w32_console_unicode_input.
452 * xdisp.c (init_iterator): Don't reference tip_frame in a build
453 --without-x. (Bug#11742)
455 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
457 Adjust GDB to reflect pvec_type changes (Bug#12036).
458 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
459 2012-07-04 changes to pseudovector representation. Problem
460 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
462 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
464 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
466 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
468 2012-07-27 Eli Zaretskii <eliz@gnu.org>
470 * alloc.c (listn): Fix the order the arguments are consed onto the
473 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
474 enumeration constants, as PURE and HEAP are too general, and clash
475 with other headers and sources, such as gmalloc.c and the
476 MS-Windows system headers. All users changed.
478 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
480 Revert last save_excursion_save and save_excursion_restore changes.
481 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
482 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
484 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
486 Fix recently-introduced typos in Windows port.
487 Reported by Martin Rudalics <rudalics@gmx.at>.
488 * w32.c (init_environment): Replace comma with semicolon.
489 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
491 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
493 Improve GDB symbol export (Bug#12036).
494 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
495 arms of an 'if', not using conditional expressions; otherwise GDB
496 complains about the types in the unevaluated arm when the argument
497 is an integer literal.
498 (xgetint): Simplify expression.
499 * alloc.c (gdb_make_enums_visible): New constant. This ports to
500 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
501 Zaretskii in <http://bugs.gnu.org/12036#13>.
502 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
503 needed now that we have gdb_make_enums_visible.
504 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
505 (enum enum_USE_LSB_TAG):
506 New enum types, packaging up enums that need to be exported to GDB.
508 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
510 Utility function to make a list from specified amount of objects.
511 * lisp.h (enum constype): New datatype.
512 (listn): New prototype.
513 * alloc.c (listn): New function.
514 (Fmemory_use_count, syms_of_alloc): Use it.
515 * buffer.c (syms_of_buffer): Likewise.
516 * callint.c (syms_of_callint): Likewise.
517 * charset.c (define_charset_internal): Likewise.
518 * coding.c (syms_of_coding): Likewise.
519 * keymap.c (syms_of_keymap): Likewise.
520 * search.c (syms_of_search): Likewise.
521 * syntax.c (syms_of_syntax): Likewise.
522 * w32.c (init_environment): Likewise.
523 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
524 * xdisp.c (syms_of_xdisp): Likewise.
525 * xfns.c (syms_of_xfns): Likewise.
527 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
529 Fast save_excursion_save and save_excursion_restore.
530 * lisp.h (struct Lisp_Excursion): New data type.
531 (PVEC_EXCURSION): New pseudovector type.
532 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
533 to deal with it. Adjust comments.
534 (init_marker, attach_marker): New prototype.
535 (unchain_marker): Adjust prototype.
536 * marker.c (attach_marker): Change to global.
537 (init_marker): New function.
538 * alloc.c (Fmake_marker, build_marker): Use it.
539 (build_marker): More easserts.
540 (mark_object): Handle struct Lisp_Excursion.
541 * editfns.c (save_excursion_save, save_excursion_restore):
542 Reimplement to use struct Lisp_Excursion. Add comments.
544 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
546 Fix export of symbols to GDB (Bug#12036).
547 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
548 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
549 emacs.c, as this is a more-suitable home. Had this been done earlier
550 the fix for 12036 would have avoided some of the problems noted in
551 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
552 would have been more obvious.
553 * emacs.c: Do not include <verify.h>; no longer needed.
554 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
555 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
556 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
557 Remove; now done in lisp.h.
558 * lisp.h (PUBLISH_TO_GDB): New macro.
559 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
560 (DATA_SEG_BITS): Use it.
561 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
562 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
563 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
564 not be usable in #if. This simplifies things.
566 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
568 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
570 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
572 Simplify export of symbols to GDB (Bug#12036).
573 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
574 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
575 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
576 Adjust to changes in lisp.h and emacs.c, by using
577 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
578 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
579 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
580 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
581 instead of gdb_valbits.
582 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
583 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
584 instead of gdb_array_mark_flag.
585 (xboolvector): Get size from $->size, not $->header.size.
586 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
587 (xreload, hook-run, hookpost-run): Remove.
588 * emacs.c: Include <verify.h>.
589 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
590 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
592 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
593 (gdb_USE_LSB_TAG): New enum constants.
594 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
595 Also define these as enum constants, so they're visible to GDB.
596 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
597 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
598 as constants, so they're visible to GDB.
599 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
600 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
601 Now enum constants, not macros, so they're visible to GDB.
602 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
603 more convenient now. All uses changed.
604 (VALMASK) [USE_LSB_TAG]: Also define in this case.
605 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
607 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
609 Explicitly free restriction data that are not needed anymore.
610 * editfns.c (save_restriction_restore): Free restriction data.
612 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
614 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
615 add argument, tune behavior, and adjust all callers.
617 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
619 Use typedef for EMACS_INT, EMACS_UINT.
620 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
621 than macros. This simplifies debugging in the usual case, since
622 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
623 and it allows expressions involving EMACS_INT casts.
624 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
626 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
628 * nsterm.m (ns_read_socket): Return early if there is a modal
631 2012-07-25 Martin Rudalics <rudalics@gmx.at>
633 * frame.c (Fredirect_frame_focus): In doc-string don't mention
634 that FOCUS-FRAME can be omitted.
636 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
638 Adjust buffer text indirection counters at the end of Fkill_buffer.
639 * buffer.c (Fkill_buffer): Adjust indirection counters when the
640 buffer is definitely dead. This should really fix an issue reported
641 by Christoph Scholtes again. (Bug#12007).
642 (init_buffer_once): Initialize indirection counters of
643 buffer_defaults and buffer_local_symbols (for sanity and safety).
645 2012-07-24 Eli Zaretskii <eliz@gnu.org>
647 * xdisp.c (init_iterator): Don't compute dimensions of truncation
648 and continuation glyphs on tooltip frames, leave them at zero.
649 Avoids continued lines in tooltips. (Bug#11832)
651 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
653 Simplify copy_overlay.
654 * buffer.c (copy_overlay): Simplify. Use build_marker.
655 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
657 2012-07-23 Eli Zaretskii <eliz@gnu.org>
659 * print.c (print_object): Don't crash when a frame's name is nil
660 or invalid. (Bug#12025)
662 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
663 it signals an error when a tooltip frame is being created.
665 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
667 Cleanup miscellaneous objects allocation and initialization.
668 * alloc.c (allocate_misc): Change to static. Add argument to
669 specify the subtype. Adjust comment and users.
670 (build_overlay): New function.
671 * buffer.c (copy_overlays, Fmake_overlay): Use it.
672 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
673 (allocate_misc): Remove prototype.
674 (build_overlay): Add prototype.
676 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
678 Swap buffer text indirection counters in Fbuffer_swap_text.
679 * buffer.c (Fbuffer_swap_text): Swap indirections too.
680 This avoids crash reported by Christoph Scholtes at
681 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
683 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
685 * nsmenu.m (Popdown_data): New struct.
686 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
688 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
689 (initWithContentRect): Make imgView and contentView non-static
690 and autorelease them. Also autorelease img and matrix (Bug#12005).
691 (dealloc): Remove (Bug#12005).
693 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
695 Adjust consing_since_gc when objects are explicitly freed.
696 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
697 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
698 (free_cons, free_misc): Subtract object size from consing_since_gc.
700 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
702 Simplify and cleanup markers positioning code.
703 * marker.c (attach_marker): More useful eassert.
704 (live_buffer, set_marker_internal): New function.
705 (Fset_marker, set_marker_restricted): Use set_marker_internal.
706 (set_marker_both, set_marker_restricted_both): Use live_buffer.
708 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
710 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
711 as it's limited by the amount of memory, not by INT_MAX.
713 2012-07-21 Eli Zaretskii <eliz@gnu.org>
715 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
716 in special-event-map. See the discussion at
717 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
720 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
721 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
722 Fabrice Popineau <fabrice.popineau@supelec.fr>.
724 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
726 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
727 (conversationIdentifier): Return value is NSInteger.
728 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
730 2012-07-21 Chong Yidong <cyd@gnu.org>
732 * window.c (decode_any_window): Signal an error if the window is
733 on a dead frame (Bug#11984).
735 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
737 Add indirection counting to speed up Fkill_buffer.
738 * buffer.h (struct buffer): New member.
739 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
740 (Fmake_indirect_buffer): Set indirection counter to -1, increment
741 base buffer indirection counter.
742 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
743 (Fkill_buffer): Adjust indirection counters as needed, don't walk
744 through buffer list if indirection counter is 0.
746 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
748 Extend the value returned by Fgarbage_collect with heap statistics.
749 * alloc.c (Qheap): New symbol.
750 (syms_of_alloc): DEFSYM it.
751 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
752 (Fmemory_free): Remove.
753 (syms_of_alloc): Don't defsubr it.
754 * buffer.c (Fcompact_buffer): Remove.
755 (syms_of_buffer): Don't defsubr it.
757 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
759 Make maybe_gc inline.
760 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
761 * lisp.h (consing_since_gc, gc_relative_threshold)
762 (memory_full_cons_threshold): Revert declaration.
763 (maybe_gc): Remove prototype, define as inline.
764 * alloc.c: Remove old commented-out code.
765 (consing_since_gc, gc_relative_threshold)
766 (memory_full_cons_threshold): Revert to global.
769 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
771 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
772 * lisp.h (build_unibyte_string): New function.
773 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
774 * sysdep.c, w32fns.c, xfns.c: Use it.
775 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
776 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
777 Adjust users accordingly.
778 * font.h (font_open_by_name): Adjust prototype.
780 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
782 Cleanup calls to Fgarbage_collect.
783 * lisp.h (maybe_gc): New prototype.
784 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
786 * alloc.c (maybe_gc): New function.
787 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
789 * bytecode.c (MAYBE_GC): Use maybe_gc.
790 * eval.c (eval_sub, Ffuncall): Likewise.
791 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
792 to avoid dependency from auto-save feature.
794 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
796 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
797 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
798 'for_each_per_buffer_object_at'.
799 All uses changed. It's better to use upper-case for macros that
800 cannot be implemented as functions, to give the reader a clue
801 that they're special.
803 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
805 * alloc.c (Fgarbage_collect): Tweak docstring.
807 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
809 Tweak the value returned from Fgarbage_collect again.
810 * alloc.c (Fgarbage_collect): New return value, as confirmed in
811 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
812 Adjust documentation.
813 (total_vector_bytes): Rename to total_vector_slots, adjust
815 (total_free_vector_bytes): Rename to total_free_vector_slots,
817 (Qstring_bytes, Qvector_slots): New symbols.
818 (syms_of_alloc): DEFSYM them.
820 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
822 Buffer compaction primitive which may be used from Lisp.
823 * buffer.c (compact_buffer, Fcompact_buffer): New function.
824 (syms_of_buffer): Register Fcompact_buffer.
825 * alloc.c (Fgarbage_collect): Use compact_buffer.
826 * buffer.h (compact_buffer): New prototype.
827 (struct buffer_text): New member.
829 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
831 New macro to iterate over all buffers, miscellaneous cleanups.
832 * lisp.h (all_buffers): Remove declaration.
833 * buffer.h (all_buffers): Add declaration, with comment.
834 (for_each_buffer): New macro.
835 * alloc.c (Fgarbage_collect, mark_object): Use it.
836 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
837 (init_buffer): Likewise.
838 * data.c (Fset_default): Likewise.
839 * coding.c (code_conversion_restore): Remove redundant check
841 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
843 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
845 Fix bug that created negative-length intervals.
846 * intervals.c (merge_interval_right, merge_interval_left):
847 Do not zero out this interval if it is absorbed by its children,
848 as this interval's total length doesn't change in that case. See
849 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
851 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
853 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
854 when invoking (make-bool-vector N t) and N is a positive
855 multiple of 8 -- the last 8 bits were mistakenly cleared.
857 Remove some struct layout assumptions in bool vectors.
858 * alloc.c (bool_header_size): New constant.
859 (header_size, word_size): Move earlier, as they're now used earlier.
860 Use 'word_size' in a few more places, where it's appropriate.
861 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
862 padding before the data member of a bool vector.
863 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
864 than doing the check by hand with an abort ().
866 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
868 * eval.c (Fdefvar): Don't check constants since we only set the var if
869 it's not yet defined anyway (bug#11904).
871 * lisp.h (last_undo_boundary): Declare new var.
872 * keyboard.c (command_loop_1): Set it.
873 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
874 were auto-added by the command loop (bug#11774).
876 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
878 * w32font.c (Qsymbol): Remove local definition.
879 (syms_of_w32font): Don't DEFSYM it.
881 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
883 Fix sweep_vectors to handle large bool vectors correctly.
884 * alloc.c (sweep_vectors): Account total_vector_bytes for
885 bool vectors larger than VBLOCK_BYTES_MAX.
887 2012-07-18 Chong Yidong <cyd@gnu.org>
889 * frame.c (x_set_frame_parameters): Revert bogus change introduced
890 in 2012-05-25 commit by Paul Eggert (Bug#11738).
892 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
894 Return more descriptive data from Fgarbage_collect.
895 Suggested by Stefan Monnier in
896 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
897 * alloc.c (bounded_number): New function.
898 (total_buffers, total_vectors): New variable.
899 (total_string_size): Rename to total_string_bytes, adjust users.
900 (total_vector_size): Rename to total_vector_bytes, adjust users.
901 (sweep_vectors): Account total_vectors and total_vector_bytes.
902 (Fgarbage_collect): New return value. Adjust documentation.
903 (gc_sweep): Account total_buffers.
904 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
905 (VECTOR_SIZE): Remove.
906 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
907 (Qinterval, Qmisc): New symbols.
908 (syms_of_data): Initialize them.
909 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
910 (Qcons, Qbuffer): New declarations.
912 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
914 * alloc.c (Fmemory_free): Account for memory-free's own storage.
915 Round up, not down. Improve doc.
917 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
919 Restore old code in allocate_string_data to avoid Faset breakage.
920 Reported by Julien Danjou <julien@danjou.info> in
921 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
922 * alloc.c (allocate_string_data): Restore old code with minor
923 adjustments, fix comment to explain this subtle issue.
925 2012-07-17 Eli Zaretskii <eliz@gnu.org>
927 Remove FILE_SYSTEM_CASE.
928 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
930 * fileio.c (FILE_SYSTEM_CASE): Don't define.
931 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
932 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
933 call-process-region passes it through expand-file-name.
935 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
937 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
939 Fix crash when creating indirect buffer (Bug#11917)
940 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
941 Don't handle unbound variables specially if non-zero.
942 (Fbuffer_local_variables): Pass zero.
943 (clone_per_buffer_values): Pass non-zero.
945 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
947 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
948 to make the loop interruptible.
950 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
952 * gnutls.c (emacs_gnutls_handshake): Only retry if
953 GNUTLS_E_INTERRUPTED.
955 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
957 Cleanup and convert miscellaneous checks to eassert.
958 * alloc.c (mark_interval): Fix comment, partially rephrase
959 old comment from intervals.h (see below).
960 * intervals.c (find_interval, adjust_intervals_for_insertion)
961 (delete_interval, adjust_intervals_for_deletion)
962 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
964 (adjust_intervals_for_insertion, make_new_interval):
965 Remove obsolete and unused code.
966 * intervals.h (struct interval): Remove obsolete comment.
967 * textprotp.c (erase_properties): Remove unused code.
968 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
969 (Fremove_list_of_text_properties): Convert to eassert.
971 2012-07-17 Chong Yidong <cyd@gnu.org>
973 * editfns.c (Finsert_char): Doc fix.
975 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
977 Fix previous change to make Fmemory_free always accurate.
978 * alloc.c (make_interval): Update total_free_intervals.
979 (make_float): Likewise for total_free_floats.
980 (free_cons, Fcons): Likewise for total_free_conses.
981 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
982 Likewise for total_free_vector_bytes.
983 (Fmake_symbol): Likewise for total_free_symbols.
984 (bytes_free): Remove.
986 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
988 Simple free memory accounting feature.
989 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
990 (sweep_vectors): Accumulate size of free vectors.
991 (Fgarbage_collect): Setup bytes_free.
992 (Fmemory_free): New function.
993 (syms_of_alloc): Register it.
995 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
997 Cleanup overlays checking.
998 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
999 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1000 eassert and OVERLAYP.
1001 (sort_overlays): Change to use OVERLAYP.
1003 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1005 * editfns.c (Finsert_char): Make it interactive, and make the
1006 second arg optional. Copy interactive spec and docstring from
1009 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1011 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1012 Unlike the other wrapped functions, fabs has an unspecified
1015 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1017 * nsterm.m (keyDown): Interpret flags without left/right bits
1018 as the left key (Bug#11670).
1020 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1022 Remove empty and useless init functions.
1023 * lisp.h (init_character_once, init_fns, init_image)
1024 (init_filelock, init_sound): Remove prototype.
1025 * character.c (init_character_once): Remove.
1026 * filelock.c (init_filelock): Likewise.
1027 * fns.c (init_fns): Likewise.
1028 * image.c (init_image): Likewise.
1029 * sound.c (init_sound): Likewise.
1030 * emacs.c (main): Adjust accordingly.
1032 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1034 * gtkutil.h: Tiny cleanups.
1035 (use_old_gtk_file_dialog): Remove useless declaration.
1036 (xg_uses_old_file_dialog): Add suggested const attribute.
1038 2012-07-15 Eli Zaretskii <eliz@gnu.org>
1040 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1041 (bidi_paragraph_init): Use it to limit search forward for a strong
1042 directional character in abnormally large paragraphs full of
1043 neutral or weak characters. (Bug#11943)
1045 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1047 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1048 the toolbar (Bug#9451).
1049 (xg_make_tool_item): Give the widget event box a transparent
1052 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1054 Cleanup basic allocation variables and functions.
1055 * alloc.c (ignore_warnings, init_intervals, init_float)
1056 (init_cons, init_symbol, init_marker): Remove.
1057 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1058 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1059 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1060 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1061 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1062 (staticidx, init_alloc_once, init_strings, free_ablock):
1063 Remove redundant initialization.
1064 * fns.c (init_weak_hash_tables): Remove.
1065 * lisp.h (init_weak_hash_tables): Remove prototype.
1067 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1069 Use zero_vector where appropriate.
1070 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1072 * lisp.h (zero_vector): New declaration.
1073 * font.c (null_vector): Remove.
1074 (syms_of_font): Remove initialization and staticpro.
1075 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1076 * keymap.c (Faccessible_keymaps): Likewise.
1078 2012-07-15 Leo Liu <sdl.web@gmail.com>
1080 * fringe.c: Fix typo in comments.
1082 2012-07-14 Leo Liu <sdl.web@gmail.com>
1084 * fringe.c: Add a new bitmap exclamation-mark.
1086 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1088 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1090 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1091 (HAVE_MENUS): Don't define, defined by editing config.in with
1093 (GMALLOC_INHIBIT_VALLOC): Don't define.
1094 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1096 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1098 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1100 2012-07-14 Glenn Morris <rgm@gnu.org>
1102 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1103 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1104 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1106 2012-07-13 Glenn Morris <rgm@gnu.org>
1108 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1110 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1111 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1113 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1115 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1116 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1117 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1118 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1120 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1121 as boolean expression.
1122 (x_set_window_size): Remove unused variable toolbar.
1123 (ns_get_color_default, ns_mod_to_lisp): Remove.
1124 (ns_mouse_position): Remove unused variables xchar and ychar.
1125 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1126 (ns_set_vertical_scroll_bar): Remove unused variable count.
1127 (ns_delete_terminal): Remove unused variable i.
1128 (ns_term_init): Remove unused variables r, g and b.
1129 (mouseDown): Remove unused variable window.
1130 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1131 (initFrameFromEmacs): Remove unused variable vbextra.
1132 (mouseEntered): Remove unused variables p and dpyinfo.
1133 (mouseExited): Remove unused variables p and r.
1134 (ns_define_frame_cursor, ns_clear_frame_area)
1135 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1136 (menuDown): Assign [sender tag] to variable and cast the variable.
1138 * nsterm.h (menuDown): Add id as type to argument sender.
1139 (ns_display_info_for_name): Add Lisp_Object argument.
1140 (ns_term_init): Add Lisp_Object argument.
1141 (ns_map_event_to_object): Add void argument.
1142 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1143 prototype with arguments and only declare if __OBJC__.
1144 (nxatoms_of_nsselect): Add void argument.
1145 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1146 (ns_alloc_autorelease_pool): Add void argument.
1147 (ns_release_autorelease_pool): Add void* argument.
1148 (ns_get_defaults_value): Add const char* argument.
1150 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1151 (initFromContents): Use SSDATA where appropriate.
1152 (ns_update_menubar): Add braces to ambigous if-else.
1153 (initWithTitle): Put () around assignment in if statement.
1154 (ns_menu_show): Remove unused variables window and keymap.
1155 (update_frame_tool_bar): Remove unused variable selected_p.
1156 (initWithContentRect): Remove unused variable this_cmd_name.
1158 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1160 (setXBMColor): Remove unused variable len.
1161 (setPixmapData): Put () around assignment in loop statement.
1163 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1164 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1166 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1167 around assignment in loop statement.
1168 (nsfont_open): Remove unused variable i.
1169 (nsfont_open): Remove unused variable len.
1170 (nsfont_draw): Remove unused variable cs.
1172 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1173 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1174 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1175 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1176 (Fns_font_name, Fns_perform_service)
1177 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1178 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1179 (ns_set_name): Remove unused variable view.
1180 (x_set_menu_bar_lines): Remove unused variable olines.
1181 (x_set_tool_bar_lines): Remove unused variable root_window.
1182 (Fns_list_colors): Put () around assignment in while statement.
1183 (Fns_perform_service): Remove unused variable len.
1184 (Fns_display_usable_bounds): Remove unused variable top.
1185 (syms_of_nsfns): Remove unused variable i.
1187 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1190 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1192 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1193 and free it with DestroyExceptionInfo (Bug#11558).
1195 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1197 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1198 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1199 Set here, not in nt/config.nt.
1201 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1203 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1204 cursor overflow into the last glyph on display line when the right
1205 fringe is off. (Bug#11832)
1207 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1209 * xdisp.c (produce_special_glyphs): Now static.
1210 * dispextern.h (produce_special_glyphs): Remove decl.
1212 2012-07-13 Glenn Morris <rgm@gnu.org>
1214 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1215 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1217 * s/usg5-4-common.h (USG, USG5):
1218 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1219 * s/sol2-6.h (SOLARIS2):
1220 * s/irix6-5.h (IRIX6_5):
1221 * s/hpux10-20.h (USG, USG5, HPUX):
1222 * s/gnu-linux.h (USG, GNU_LINUX):
1223 * s/freebsd.h (BSD_SYSTEM):
1224 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1225 * s/cygwin.h (CYGWIN):
1226 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1227 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1229 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1231 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1233 2012-07-13 Glenn Morris <rgm@gnu.org>
1235 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1237 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1239 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1240 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1242 2012-07-12 Glenn Morris <rgm@gnu.org>
1244 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1246 * process.c (init_process_emacs): Rename from init_process.
1247 The old name is also the name of a Mach system call.
1248 * lisp.h, emacs.c: Update for this name change.
1249 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1252 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1254 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1255 memmove call that removes glyphs covered by the left truncation
1256 glyph. Improve commentary.
1257 (display_line): Fix display of continuation glyphs on GUI frames
1258 when the right fringe is turned off and variable-size fonts are
1259 used in the window. Move the code that appends a stretch glyph to
1260 produce_special_glyphs, so that it could be used for truncation
1261 and continuation glyphs alike.
1262 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1263 glyph of a suitably computed width, to align the special glyphs at
1264 the window margin. Code moved from display_line. (Bug#11832)
1266 2012-07-12 Glenn Morris <rgm@gnu.org>
1268 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1270 * s/gnu-linux.h, s/hpux10-20.h:
1271 Do not unconditionally define HAVE_XRMSETDATABASE.
1273 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1275 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1277 Fix typos that broke OS X build.
1278 Reported by Randal L. Schwartz in
1279 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1280 * nsterm.m (ns_timeout): Add missing local decl.
1281 (ns_get_color): snprintf -> sprintf, to fix typo.
1283 2012-07-12 Glenn Morris <rgm@gnu.org>
1285 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1286 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1287 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1288 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1290 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1291 Move PTY_OPEN to configure.
1293 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1294 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1295 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1297 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1299 Use empty_unibyte_string where applicable.
1300 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1301 * lread.c (read1): Likewise.
1302 * xsettings.c (syms_of_xsettings): Likewise.
1304 2012-07-12 Glenn Morris <rgm@gnu.org>
1306 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1307 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1308 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1309 * s/hpux10-20.h (RUN_TIME_REMAP):
1310 * s/bsd-common.h (TABDLY): Move to configure.
1312 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1314 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1316 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1317 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1319 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1321 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1322 * s/template.h: Move NARROWPROTO to configure.
1324 2012-07-11 Glenn Morris <rgm@gnu.org>
1326 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1327 unused since 2011-01-17 change to systty.h.
1329 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1330 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1331 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1333 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1335 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1337 2012-07-11 Glenn Morris <rgm@gnu.org>
1339 * s/darwin.h, s/gnu-linux.h, s/template.h:
1340 Move INTERRUPT_INPUT to configure.
1342 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1344 Minor adjustments to interning code.
1345 * lisp.h (intern, intern_c_string): Redefine as static inline
1346 wrappers for intern_1 and intern_c_string_1, respectively.
1347 (intern_1, intern_c_string_1): Rename prototypes.
1348 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1350 * font.c (font_intern_prop): Likewise. Adjust comment.
1351 * w32font.c (intern_font_name): Likewise.
1353 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1355 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1357 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1358 of Fcar/Fcdr if possible.
1359 * font.c (check_otf_features): Likewise.
1360 * fontset.c (Fnew_fontset): Likewise.
1361 * gnutls.c (Fgnutls_boot): Likewise.
1362 * minibuf.c (read_minibuf): Likewise.
1363 * msdos.c (IT_set_frame_parameters): Likewise.
1364 * xmenu.c (Fx_popup_dialog): Likewise.
1365 * w32menu.c (Fx_popup_dialog): Likewise.
1367 2012-07-11 Glenn Morris <rgm@gnu.org>
1369 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1370 since nothing has defined it on these platforms.
1372 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1373 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1375 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1376 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1377 Move CLASH_DETECTION to configure.
1379 * s/gnu.h: Remove file, which is now empty.
1381 * s/gnu.h, s/gnu-linux.h:
1382 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1384 2012-07-11 John Wiegley <johnw@newartisans.com>
1386 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1387 function attribute, so we only use it if it exists in the
1390 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1392 Avoid call to strlen in fast_c_string_match_ignore_case.
1393 * search.c (fast_c_string_match_ignore_case): Change to use
1394 length argument. Adjust users accordingly.
1395 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1397 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1399 Assume mkdir, rmdir.
1400 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1401 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1404 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1407 * s/hpux10-20.h (HAVE_PERROR): Remove.
1408 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1409 Remove dummy definition, as this problem was obsolete long ago.
1412 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1414 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1416 Avoid calls to strlen in font processing functions.
1417 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1418 (font_open_by_name): Change to use length argument. Adjust
1420 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1422 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1423 Change to return ptrdiff_t.
1424 (xfont_list_pattern, xfont_match): Use length returned by
1425 xfont_decode_coding_xlfd.
1426 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1428 2012-07-11 Glenn Morris <rgm@gnu.org>
1430 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1431 Move DONT_REOPEN_PTY to configure.
1433 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1434 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1436 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1438 Remove "#define unix" that is no longer needed (Bug#11905).
1439 * s/aix4-2.h (unix): Remove; no longer needed.
1441 EMACS_TIME simplification (Bug#11875).
1442 This replaces macros (which typically do not work in GDB)
1443 with functions, typedefs and enums, making the code easier to debug.
1444 The functional style also makes code easier to read and maintain.
1445 * systime.h: Include <sys/time.h> on all hosts, not just if
1446 WINDOWSNT, since 'struct timeval' is needed in general.
1447 (EMACS_TIME): Now a typedef, not a macro.
1448 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1450 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1451 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1452 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1453 (EMACS_TIME_LE): Now functions, not macros.
1454 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1455 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1456 which are not functions. All uses rewritten to use:
1457 (make_emacs_time): New function.
1458 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1459 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1460 not functions. All uses rewritten to use the following, respectively:
1461 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1462 (add_emacs_time, sub_emacs_time): New functions.
1463 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1464 * fileio.c (Fcopy_file):
1465 * xterm.c (XTflash): Get the current time closer to when it's used.
1466 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1468 * bytecode.c (targets): Suppress -Woverride-init warnings.
1470 Simplify by avoiding confusing use of strncpy etc.
1471 * doc.c (Fsnarf_documentation):
1472 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1473 * frame.c (Fmake_terminal_frame):
1474 * gtkutil.c (get_utf8_string):
1476 * nsmenu.m (ns_update_menubar):
1477 * regex.c (regerror):
1478 Prefer memcpy to strncpy and strncat when either will do.
1479 * fileio.c (Fsubstitute_in_file_name):
1480 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1481 (menu_separator_name_p):
1482 * nsmenu.m (ns_update_menubar):
1483 Prefer memcmp to strncmp when either will do.
1484 * nsterm.m: Include <ftoastr.h>.
1486 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1487 Prefer snprintf to strncpy.
1488 * nsterm.m (ns_term_init):
1489 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1490 * nsterm.m (ns_term_init):
1491 Avoid the need for strncpy, by using build_string or
1492 make_unibyte_string directly. Use dtoastr, not snprintf.
1493 * process.c (Fmake_network_process): Diagnose service names that
1494 are too long, rather than silently truncating them or creating
1495 non-null-terminated names.
1496 (Fnetwork_interface_info): Likewise, for interface names.
1497 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1498 Prefer sprintf to strncat.
1499 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1500 Prefer vsnprintf to vsprintf + strncpy.
1502 2012-07-10 Glenn Morris <rgm@gnu.org>
1504 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1505 Clarify fallback case.
1507 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1509 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1510 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1511 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1512 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1513 where argument type is known to be a Lisp_Cons.
1515 2012-07-10 Tom Tromey <tromey@redhat.com>
1517 * bytecode.c (BYTE_CODE_THREADED): New macro.
1518 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1519 (enum byte_code_op): New type.
1520 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1521 (exec_byte_code): Use them. Use token threading when applicable.
1523 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1525 Optimize pure C strings initialization.
1526 * lisp.h (make_pure_string): Fix prototype.
1527 (build_pure_c_string): New function, defined as static inline. This
1528 provides a better opportunity to optimize away calls to strlen when
1529 the function is called with compile-time constant argument.
1530 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1531 argument, adjust users accordingly. Use build_pure_c_string where
1533 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1534 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1535 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1537 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1539 Avoid calls to strlen in miscellaneous functions.
1540 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1541 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1542 * lread.c (openp): Likewise.
1544 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1546 Avoid calls to strlen in path processing functions.
1547 * fileio.c (file_name_as_directory): Add comment. Change to add
1548 srclen argument and return the length of result. Adjust users
1550 (directory_file_name): Fix comment. Change to add srclen argument,
1551 swap 1st and 2nd arguments to obey the common convention. Adjust
1553 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1555 2012-07-10 Glenn Morris <rgm@gnu.org>
1557 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1558 Move PENDING_OUTPUT_COUNT definition to configure.
1560 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1561 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1562 * s/gnu.h (DATA_START): Move definitions to configure.
1564 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1565 We include usg5-4-common.h, which defines them both.
1567 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1568 O_RDONLY already includes it).
1570 Stop ns builds setting the EMACSLOADPATH environment variable.
1571 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1572 Now it does not set EMACSLOADPATH, just returns the load-path string.
1573 * nsterm.h: Update accordingly.
1574 * lread.c [HAVE_NS]: Include nsterm.h.
1575 (init_lread) [HAVE_NS]: Use ns_load_path.
1576 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1578 2012-07-09 Glenn Morris <rgm@gnu.org>
1580 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1581 since the included bsd-common.h does so.
1583 Stop ns builds setting the EMACSPATH environment variable.
1584 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1585 (ns_init_paths): Do not set EMACSPATH.
1586 * nsterm.h (ns_exec_path): Add it.
1587 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1590 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1592 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1594 * process.c (wait_reading_process_output): 'waitchannels' was unset
1595 when read_kbd || !NILP (wait_for_cell); fix this.
1597 Add GCC-style 'const' attribute to functions that can use it.
1598 * character.h (char_resolve_modifier_mask):
1599 * keyboard.h (make_ctrl_char):
1600 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1601 (init_character_once, next_almost_prime, init_fns, init_image)
1602 (flush_pending_output, init_sound):
1603 * mem-limits.h (start_of_data):
1604 * menu.h (finish_menu_items):
1605 Add ATTRIBUTE_CONST.
1606 * emacs.c (DEFINE_DUMMY_FUNCTION):
1607 Declare the dummy function with ATTRIBUTE_CONST.
1608 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1609 Add decls with ATTRIBUTE_CONST.
1611 Minor improvements to make_formatted_string.
1612 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1613 where int is good enough, as vsprintf returns an int.
1614 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1616 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1618 Use make_formatted_string to avoid double length calculation.
1619 * lisp.h (make_formatted_string): New prototype.
1620 * alloc.c (make_formatted_string): New function.
1621 * buffer.c (Fgenerate_new_buffer_name): Use it.
1622 * dbus.c (syms_of_dbusbind): Likewise.
1623 * editfns.c (Fcurrent_time_zone): Likewise.
1624 * filelock.c (get_boot_time): Likewise.
1625 * frame.c (make_terminal_frame, set_term_frame_name)
1626 (x_report_frame_params): Likewise.
1627 * image.c (gs_load): Likewise.
1628 * minibuf.c (get_minibuffer): Likewise.
1629 * msdos.c (dos_set_window_size): Likewise.
1630 * process.c (make_process): Likewise.
1631 * xdisp.c (ensure_echo_area_buffers): Likewise.
1632 * xsettings.c (apply_xft_settings): Likewise.
1634 2012-07-09 Glenn Morris <rgm@gnu.org>
1636 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1637 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1638 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1639 * nsterm.h (ns_etc_directory): Add it.
1640 * callproc.c [HAVE_NS]: Include nsterm.h.
1641 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1643 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1645 Move marker debugging code under MARKER_DEBUG.
1646 * marker.c (MARKER_DEBUG): Move marker debugging code under
1647 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1648 for bootstrap with --enable-checking (~3x slowdown reported
1649 by Juanma Barranquero <lekktu@gmail.com>).
1650 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1652 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1654 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1655 See <http://bugs.gnu.org/11825#29>.
1657 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1659 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1660 has no font, use the frame's font. (Bug#11813)
1661 (display_line): Add commentary about displaying truncation glyphs
1663 (produce_special_glyphs): Move here from term.c.
1665 * term.c (produce_special_glyphs): Move to xdisp.c.
1667 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1670 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1672 * xdisp.c (display_line): Avoid warning about implicit declaration
1675 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1677 * lisp.h: Remove empty conditional.
1679 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1681 * lread.c (load_path_check): Now static.
1683 Fix some minor --with-ns problems found by static checking.
1684 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1685 (x_set_font) [!HAVE_X_WINDOWS]:
1686 * image.c (xpm_load_image) [HAVE_NS]:
1687 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1688 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1689 Remove unused local.
1690 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1691 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1692 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1693 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1694 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1695 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1696 Fix pointer signedness problem.
1697 * xfaces.c (FRAME_X_FONT_TABLE):
1698 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1700 2012-07-07 Glenn Morris <rgm@gnu.org>
1702 * lread.c (load_path_check): New function, split from init_lread.
1703 (init_lread): Reorganize. Motivation:
1704 If EMACSLOADPATH is set, check/warn about that rather than the
1705 defaults, which we are not going to use. Hence we can remove
1706 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1707 Don't warn if site-lisp directories are missing.
1708 If not installed, start from a blank load-path, since
1709 PATH_LOADSEARCH refers to the eventual installation directories.
1711 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1713 Support truncation and continuation glyphs on GUI frames, when
1714 fringes are disabled. (Bug#11832)
1715 * xdisp.c (init_iterator): Get dimensions of truncation and
1716 continuation glyphs even if on GUI frames. Adjust
1717 it->last_visible_x on GUI frames when the left or right fringes,
1718 or both, are absent.
1719 (start_display, move_it_in_display_line_to): Handle the case of a
1720 GUI frame without a fringe to display continuation or truncation
1722 (insert_left_trunc_glyphs): Support GUI frames: make sure
1723 truncation glyphs overwrite enough glyphs from the current line to
1724 have sufficient space in pixels.
1725 (display_line): Support truncation and continuation glyphs on GUI
1726 frames. If some spare pixels are left on the line after inserting
1727 the truncation glyphs, fill that space with a stretch glyph of a
1728 suitably computed width.
1730 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1731 produce_glyphs, to support GUI sessions.
1733 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1735 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1737 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1739 Do not require float-time's arg to fit in time_t (Bug#11825).
1740 This works better on hosts where time_t is unsigned, and where
1741 float-time is applied to the (negative) difference between two times.
1742 * editfns.c (decode_time_components): Last arg is now double *,
1743 not int *, and means to store all the result as a double, without
1744 worrying about whether the seconds part fits in time_t.
1745 All callers changed.
1746 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1747 All callers changed.
1748 (Ffloat_time): Do not fail merely because the specified time falls
1749 outside of time_t range.
1751 2012-07-07 Glenn Morris <rgm@gnu.org>
1753 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1754 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1755 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1757 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1759 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1760 Update dependencies.
1762 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1764 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1766 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1767 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1768 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1769 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1770 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1771 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1773 * xfont.c (compare_font_names): Redo to omit the need for casts.
1775 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1777 * xfns.c (Fx_change_window_property): Doc fix.
1778 * w32fns.c (Fx_change_window_property): Doc fix.
1780 * w32fns.c (Fx_window_property): Accept the same arguments as the
1781 X Windows version. Doc fix.
1782 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1784 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1785 Eli Zaretskii <eliz@gnu.org>
1787 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1788 Windows-specific code from nt/config.nt moved here.
1789 Obsolete settings removed.
1791 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1793 * process.c: Avoid unnecessary calls to gettime.
1794 (wait_reading_process_output): Don't get the time of day
1795 when gobbling data immediately and not waiting, as there's no need
1796 for it in that case. This removes a FIXME.
1798 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1800 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1801 is defined (Bug#11768).
1803 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1805 Fix marker debugging code.
1806 * marker.c (byte_char_debug_check): Do not perform the check
1807 if buffer is not multibyte.
1808 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1809 Call byte_char_debug_check with correct arguments.
1811 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1813 Compile marker debugging code only if ENABLE_CHECKING is defined.
1814 * marker.c (byte_char_debug_check, count_markers):
1815 Use only if ENABLE_CHECKING is defined.
1816 (byte_debug_flag): Remove.
1817 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1818 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1820 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1822 Avoid code repetition in marker-related functions.
1823 * marker.c (attach_marker): New function.
1824 (Fset_marker, set_marker_restricted, set_marker_both)
1825 (set_marker_restricted_both): Use it.
1826 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1827 Consistently rename charno to charpos.
1828 (marker_position): Add eassert.
1829 (marker_byte_position): Convert to eassert.
1831 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1833 Simplify list operations in unchain_overlay and unchain_marker.
1834 * buffer.c (unchain_overlay): Simplify. Add comment.
1835 * marker.c (unchain_marker): Simplify. Fix comments.
1837 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1839 Introduce fast path for the widely used marker operation.
1840 * alloc.c (build_marker): New function.
1841 * lisp.h (build_marker): New prototype.
1842 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1843 * composite.c (autocmp_chars): Likewise.
1844 * editfns.c (buildmark): Remove.
1845 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1846 (save_restriction_save): Use build_marker.
1847 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1848 * window.c (save_window_save): Likewise.
1850 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1852 Do not use Fdelete_overlay in delete_all_overlays
1853 to avoid redundant calls to unchain_overlay.
1854 * buffer.c (drop_overlay): New function.
1855 (delete_all_overlays, Fdelete_overlay): Use it.
1856 * minibuf.c (get_minibuffer): Fix comment.
1858 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1860 Port to OpenBSD 5.1 amd64.
1861 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1862 This is needed for OpenBSD, and should be harmless on all BSD systems.
1863 Also, include <sys/sysctl.h>, as it should be available on all
1864 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1865 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1866 use p_pid member, not kp_proc.pid.
1868 2012-07-06 Glenn Morris <rgm@gnu.org>
1870 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1872 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1874 More xmalloc and related cleanup.
1875 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1876 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1877 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1878 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1879 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1880 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1881 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1882 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1883 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1885 Omit needless casts involving void * pointers and allocation.
1886 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1887 as the former is more robust if P's type is changed.
1888 Prefer xzalloc to xmalloc + memset 0.
1889 Simplify malloc-or-realloc to realloc.
1890 Don't worry about xmalloc returning a null pointer.
1891 Prefer xstrdup to xmalloc + strcpy.
1892 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1894 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1895 alloca of a constant.
1897 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1899 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1900 hscroll is larger than the line width. Fixes long and futile
1901 looping inside extend_face_to_end_of_line (on a TTY) producing
1902 glyphs that are not needed and thrown away.
1904 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1906 * marker.c (set_marker_restricted_both): Simplify by using
1909 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1911 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1913 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1915 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1916 not defined (Bug#11768).
1917 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1918 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1919 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1920 followed by gtk_box_set_homogeneous (Bug#11768).
1921 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1922 (update_theme_scrollbar_width, xg_create_scroll_bar):
1923 Use gtk_scrollbar_new (Bug#11768).
1924 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1925 (is_box_type): New function (Bug#11768).
1926 (xg_tool_item_stale_p): Call is_box_type.
1927 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1928 with default display (Bug#11768).
1930 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1932 * xdisp.c (window_hscroll_limited): New function.
1933 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1934 coordinates when window's hscroll is set to insanely large
1937 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1939 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1940 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1942 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1945 * lisp.h (xzalloc): New prototype. Omit needless casts.
1946 * alloc.c (xzalloc): New function. Omit needless casts.
1947 * charset.c: Omit needless casts. Convert all calls to
1948 xmalloc with following memset to xzalloc.
1949 * dispnew.c: Likewise.
1950 * fringe.c: Likewise.
1951 * image.c: Likewise.
1952 * sound.c: Likewise.
1954 * w32fns.c: Likewise.
1955 * w32font.c: Likewise.
1956 * w32term.c: Likewise.
1957 * xfaces.c: Likewise.
1959 * xterm.c: Likewise.
1960 * atimer.c: Omit needless casts.
1961 * buffer.c: Likewise.
1962 * callproc.c: Likewise.
1964 * coding.c: Likewise.
1965 * composite.c: Likewise.
1967 * doprnt.c: Likewise.
1968 * editfns.c: Likewise.
1969 * emacs.c: Likewise.
1971 * filelock.c: Likewise.
1973 * gtkutil.c: Likewise.
1974 * keyboard.c: Likewise.
1976 * lread.c: Likewise.
1977 * minibuf.c: Likewise.
1978 * msdos.c: Likewise.
1979 * print.c: Likewise.
1980 * process.c: Likewise.
1981 * region-cache.c: Likewise.
1982 * search.c: Likewise.
1983 * sysdep.c: Likewise.
1984 * termcap.c: Likewise.
1985 * terminal.c: Likewise.
1986 * tparam.c: Likewise.
1987 * w16select.c: Likewise.
1989 * w32reg.c: Likewise.
1990 * w32select.c: Likewise.
1991 * w32uniscribe.c: Likewise.
1992 * widget.c: Likewise.
1993 * xdisp.c: Likewise.
1994 * xmenu.c: Likewise.
1996 * xselect.c: Likewise.
1998 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2000 * fileio.c (time_error_value): Check the right error number.
2001 Problem reported by Troels Nielsen in
2002 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2004 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2006 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2007 This should be fixed in a better way; see Eli Zaretskii in
2008 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2009 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2011 * fileio.c (time_error_value): Rename from special_mtime.
2012 The old name's problems were noted by Eli Zaretskii in
2013 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2015 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2016 This variable's comment says Emacs needs at least one GDB-visible
2017 symbol of type enum pvec_type, to work around GDB problems.
2018 The symbol's value doesn't matter.
2020 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2021 that causes compilation to fail on pre-C99 compilers.
2023 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
2025 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2026 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2028 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2030 * buffer.c (init_buffer_once): Fix initialization of
2031 headers for buffer_defaults and buffer_local_symbols.
2032 Reported by Juanma Barranquero <lekktu@gmail.com>.
2034 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2036 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2037 * lisp.h (enum pvec_type): Use fewer bits.
2038 (PSEUDOVECTOR_SIZE_BITS): New constant.
2039 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2040 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2041 change in pvec_type.
2042 (PSEUDOVECTOR_TYPEP): New macro.
2043 (TYPED_PSEUDOVECTORP): Use it.
2044 * fns.c (internal_equal): Adapt code to extract pvectype.
2045 * emacs.c (gdb_pvec_type): Update type.
2046 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2047 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2048 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2049 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2050 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2051 abusing vector->header.next.nbytes.
2052 (live_vector_p): Use PVEC_TYPE.
2053 (mark_object): Adapt code to extract pvectype. Use switch.
2055 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2057 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2058 Tighten new eassert a bit.
2060 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2062 Fix compilation with --enable-gcc-warnings and -O1
2064 * doprnt.c (doprnt): Change type of tem to int, initialize
2065 to avoid compiler warning. Add eassert.
2066 * search.c (simple_search): Initialize match_byte to avoid
2067 compiler warning. Add eassert.
2069 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2071 Avoid weird behavior with large horizontal scrolls.
2072 Without this change, for example, large hscroll values would
2073 mess up Emacs's display on Fedora 15 x86, presumably due to
2074 overflows in int calculations in the display code.
2075 Also, if buffers had long lines, Emacs would freeze.
2076 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2077 (set_window_hscroll): New function, containing the old guts of
2078 Fset_window_hscroll. Return the clipped value.
2079 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2080 This avoids the need to check against PTRDIFF_MAX.
2082 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2084 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2086 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2088 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2090 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2091 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2092 since GCC 4.4.6 issues a bogus warning for them.
2094 Fix bugs in file timestamp newness comparisons.
2095 * fileio.c (Ffile_newer_than_file_p):
2096 * lread.c (Fload): Use full timestamp resolution of files,
2097 not just the 1-second resolution, so that files that are only
2098 slightly newer still count as newer.
2099 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2100 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2102 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2104 * fileio.c: Improve handling of file time marker. (Bug#11852)
2105 (special_mtime): New function.
2106 (Finsert_file_contents, Fverify_visited_file_modtime):
2107 Use it to set special mtime values consistently.
2109 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2111 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2112 marker for non-existing file. (Bug#11852)
2114 2012-07-03 Glenn Morris <rgm@gnu.org>
2116 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2117 and did not make it into globals.h).
2119 2012-07-03 Tom Tromey <tromey@redhat.com>
2121 * window.c (Fset_window_margins, Fset_window_fringes)
2122 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2123 * textprop.c (Fprevious_property_change): No longer static.
2124 * syntax.c (Fsyntax_table_p): No longer static.
2125 * process.c (Fget_process, Fprocess_datagram_address): No longer
2127 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2128 * keyboard.c (Fcommand_execute): No longer static.
2130 * insdel.c (Fcombine_after_change_execute): No longer static.
2131 * image.c (Finit_image_library): No longer static.
2132 * fileio.c (Fmake_symbolic_link): No longer static.
2133 * eval.c (Ffetch_bytecode): No longer static.
2134 * editfns.c (Fuser_full_name): No longer static.
2135 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2137 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2139 * dired.c (Ffile_attributes): No longer static.
2140 * composite.c (Fcomposition_get_gstring): No longer static.
2141 * callproc.c (Fgetenv_internal): No longer static.
2143 * ccl.h: Remove EXFUNs.
2144 * buffer.h: Remove EXFUNs.
2145 * dispextern.h: Remove EXFUNs.
2146 * intervals.h: Remove EXFUNs.
2147 * fontset.h: Remove EXFUN.
2148 * font.h: Remove EXFUNs.
2149 * dosfns.c (system_process_attributes): Remove EXFUN.
2150 * keymap.h: Remove EXFUNs.
2151 * lisp.h: Remove EXFUNs.
2152 * w32term.h: Remove EXFUNs.
2153 * window.h: Remove EXFUNs.
2154 * xsettings.h: Remove EXFUN.
2155 * xterm.h: Remove EXFUN.
2157 2012-07-03 Glenn Morris <rgm@gnu.org>
2159 * lisp.h (Frandom): Make it visible to C.
2160 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2161 buffer for invisible buffers. (Bug#1229)
2163 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2165 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2166 values which aren't power of 2.
2167 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2168 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2171 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2173 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2175 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2177 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2179 * alloc.c (allocate_vector_block): Remove redundant
2180 calls to mallopt if DOUG_LEA_MALLOC is defined.
2181 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2182 avoid calls to mallopt if zero_vector is returned.
2184 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2186 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2187 is enabled, avoid dereferencing NULL current_sblock if
2190 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2192 Cleanup basic buffer management.
2193 * buffer.h (struct buffer): Change layout to use generic vector
2194 marking code. Fix some comments. Change type of 'clip_changed'
2195 to bitfield. Remove unused #ifndef old.
2196 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2197 (GET_OVERLAYS_AT): Fix indentation.
2198 (for_each_per_buffer_object_at): New macro.
2199 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2200 (Fbuffer_local_variables): Use it.
2201 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2202 * alloc.c (allocate_buffer): Adjust to match new layout of
2203 struct buffer. Fix comment.
2204 (mark_overlay): New function.
2205 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2206 Lisp area of struct buffer.
2207 (mark_object): Use it. Adjust marking of misc objects
2208 and related comments.
2210 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2212 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2213 wrapper that is not needed because the wrapped code is a no-op (zero
2214 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2215 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2217 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2219 * alloc.c (mark_buffer): Simplify. Remove prototype.
2220 (mark_object): Add comment. Reorganize marking of vector-like
2221 objects. Use CHECK_LIVE for all vector-like objects except buffers
2222 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2223 redundant calls to mark_vectorlike for bool vectors.
2225 2012-06-30 Glenn Morris <rgm@gnu.org>
2227 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2229 * epaths.in (PATH_SITELOADSEARCH): New.
2230 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2231 This is rather than relying on --enable-locallisppath elements
2232 having "site-lisp" in their names. (Bug#10208#25, 11658)
2234 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2236 * w32proc.c (sys_select): Accept and ignore one more argument.
2238 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2240 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2241 (pselect) [!MS_DOS]: Redirect to sys_select.
2243 * sysdep.c: Don't include dos.h and dosfns.h.
2245 * process.c (sys_select):
2246 * msdos.c (sys_select): Accept one more argument and ignore it.
2248 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2249 adapt data types and code to that.
2252 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2253 which clashes with the gnulib function of the same name.
2255 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2257 * font.c (font_style_to_value, font_style_symbolic)
2258 (font_prop_validate_style): Add type checks for values in
2261 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2263 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2266 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2268 * xdisp.c (try_window_id): Undo last change.
2270 * w32.c (getwd): Adjust commentary about startup_dir.
2271 (init_environment): Always call sys_access, even in non-MSVC
2272 builds. Don't chdir to the directory of the Emacs executable.
2273 This undoes code from 1997 which was justified by the need to
2274 "avoid conflicts when removing and renaming directories". But its
2275 downside was that every relative file name was being interpreted
2276 relative to the directory of the Emacs executable, which can never
2277 be TRT. In particular, it broke sys_access when called with
2278 relative file names.
2279 (sys_access): Map GetLastError to errno.
2281 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2283 * window.h (struct window): Change type of 'fringes_outside_margins'
2284 to bitfield. Fix comment. Adjust users accordingly.
2285 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2287 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2290 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2292 * gnutls.c (emacs_gnutls_handshake):
2293 Add QUIT to make the loop interruptible.
2295 2012-06-29 Glenn Morris <rgm@gnu.org>
2297 * charset.c (init_charset): Make lack of etc/charsets fatal.
2299 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2301 * editfns.c (region_limit): Fix type mismatch.
2303 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2305 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2306 undefined. Convert from xassert to eassert.
2307 * nsmenu.m: Convert from xassert to eassert.
2308 * nsterm.m: Likewise.
2310 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2312 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2314 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2316 Avoid integer overflow on scroll-left and scroll-right.
2317 * window.c (HSCROLL_MAX): New macro.
2318 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2319 overflow when requested scroll falls outside ptrdiff_t range.
2321 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2323 * window.h (struct window): Change type of 'hscroll',
2324 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2325 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2326 Adjust users accordingly.
2327 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2328 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2329 from EMACS_INT to ptrdiff_t.
2330 (make_window): Omit redundant initialization.
2332 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2334 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2336 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2338 * window.h (struct window): Change type of 'use_time' and
2339 'sequence_number' from Lisp_Object to int.
2340 * frame.c (make_frame): Adjust users accordingly.
2341 * print.c (print_object): Likewise.
2342 * window.c (select_window, Fwindow_use_time, make_parent_window)
2343 (make_window): Likewise.
2345 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2347 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2348 enabled with --enable-checking=[all,glyphs] configure option.
2349 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2350 adjust comments accordingly.
2351 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2352 undefined, adjust comments accordingly.
2353 * image.c: Likewise.
2354 * scroll.c: Likewise.
2355 * w32fns.c: Likewise.
2356 * w32term.c: Likewise.
2357 * xdisp.c: Likewise.
2358 * xfaces.c: Likewise.
2360 * xterm.c: Likewise.
2362 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2364 Generalize run-time debugging checks.
2365 * dispextern.h (XASSERTS): Remove.
2366 * fontset.c (xassert): Remove.
2367 Convert from xassert to eassert.
2368 * alloc.c: Convert from xassert to eassert.
2370 * dispnew.c: Likewise.
2372 * fringe.c: Likewise.
2373 * ftfont.c: Likewise.
2374 * gtkutil.c: Likewise.
2375 * image.c: Likewise.
2376 * keyboard.c: Likewise.
2378 * process.c: Likewise.
2379 * scroll.c: Likewise.
2380 * sound.c: Likewise.
2382 * w32console.c: Likewise.
2383 * w32fns.c: Likewise.
2384 * w32term.c: Likewise.
2385 * window.c: Likewise.
2386 * xdisp.c: Likewise.
2387 * xfaces.c: Likewise.
2389 * xselect.c: Likewise.
2390 * xterm.c: Likewise.
2392 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2394 * fns.c (maybe_resize_hash_table): Output message when growing the
2397 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2399 * alloc.c (allocate_string_data): Remove dead code.
2400 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2401 avoid GCC warning about unused macro.
2403 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2405 * alloc.c (allocate_string): Omit intervals initialization.
2406 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2407 as in make_pure_string and make_pure_c_string.
2409 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2411 * alloc.c (allocate_string): Fix last change.
2413 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2415 * alloc.c (allocate_string): Remove two redundant calls
2416 to memset, add explicit initialization where appropriate.
2418 2012-06-27 Glenn Morris <rgm@gnu.org>
2420 * lisp.mk (lisp): Remove paths.elc.
2422 2012-06-27 Chong Yidong <cyd@gnu.org>
2424 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2426 2012-06-26 John Wiegley <johnw@newartisans.com>
2428 * unexmacosx.c (copy_data_segment): Add two section names used
2429 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2431 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2432 when building with Clang.
2434 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2436 * eval.c (Fapply): Allow calling it with a single argument.
2438 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2440 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2441 _stricmp and _strnicmp.
2442 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2444 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2446 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2448 (allocate_process): Likewise for new process.
2449 (allocate_terminal): Change to use offsetof.
2450 (allocate_frame): Likewise.
2451 * frame.c (make_frame): Omit redundant initialization.
2452 * window.c (make_parent_window): Use memset.
2453 (make_window): Omit redundant initialization.
2454 * process.c (make_process): Omit redundant initialization.
2455 * terminal.c (create_terminal): Likewise.
2457 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2459 * term.c (delete_tty): Remove redundant call to memset.
2461 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2463 * alloc.c: Remove build_string.
2464 * lisp.h: Define build_string as static inline. This provides
2465 a better opportunity to optimize away calls to strlen when the
2466 function is called with compile-time constant argument.
2467 * image.c (imagemagick_error): Convert to build_string.
2468 * w32proc.c (sys_spawnve): Likewise.
2469 * xterm.c (x_term_init): Likewise.
2471 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2473 Use sprintf return value instead of invoking strlen on result.
2474 In the old days this wasn't portable, since some sprintf
2475 implementations returned char *. But they died out years ago and
2476 Emacs already assumes sprintf returns int.
2477 Similarly for float_to_string.
2478 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2479 * ccl.c (ccl_driver):
2480 * character.c (string_escape_byte8):
2481 * data.c (Fnumber_to_string):
2482 * doprnt.c (doprnt):
2483 * print.c (print_object):
2484 * xdisp.c (message_dolog):
2485 * xfns.c (syms_of_xfns):
2486 Use sprintf or float_to_string result to avoid need to call strlen.
2487 * data.c (Fnumber_to_string):
2488 Use make_unibyte_string, since the string must be ASCII.
2489 * lisp.h, print.c (float_to_string): Now returns int length.
2490 * term.c (produce_glyphless_glyph):
2491 Use sprintf result rather than recomputing it.
2493 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2494 * Makefile.in (ALL_CFLAGS):
2495 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2496 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2498 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2500 * dispextern.h (xstrcasecmp): Define to library function
2501 strcasecmp if available.
2502 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2504 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2506 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2507 Avoid comma operator.
2508 * menu.c (push_submenu_start, push_submenu_end)
2509 (push_left_right_boundary, push_menu_pane): Likewise.
2510 * msdos.c (dos_rawgetc): Likewise.
2512 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2514 * xfns.c (xic_create_fontsetname): Remove redundant calls
2517 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2519 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2520 sprintf already null-terminates its output.
2522 * xfns.c (x_window): Remove redundant cast.
2524 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2526 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2527 `const char *' to `char *' to avoid compiler warning.
2529 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2531 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2532 instead of truncating it to 63 (admittedly a generous limit).
2534 * process.c: Fix spelling and caps in comments.
2536 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2538 * emacs.c (setpgrp): Remove definition, unused.
2539 * sysdep.c (setpgrp): Remove definition, not used in this file.
2541 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2543 * makefile.w32-in: Update dependencies.
2545 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2547 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2548 (SYSTIME_H): Add nt/inc/sys/time.h.
2550 * systime.h [WINDOWSNT]: Include sys/time.h.
2552 * s/ms-w32.h (struct timespec): Definition moved from
2553 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2555 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2557 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2558 * buffer.h (buffer_slot_type_mismatch):
2559 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2560 * eval.c (unwind_to_catch):
2561 * image.c (my_png_error, my_error_exit):
2562 * keyboard.c (quit_throw_to_read_char, user_error)
2563 (Fexit_recursive_edit, Fabort_recursive_edit):
2564 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2565 (wrong_type_argument, buffer_overflow, __executable_start)
2566 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2567 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2568 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2570 (child_setup) [!DOS_NT]:
2571 * lread.c (end_of_file_error, invalid_syntax):
2572 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2573 * puresize.h (pure_write_error):
2574 * search.c (matcher_overflow):
2575 * sound.c (sound_perror, alsa_sound_perror):
2576 * sysdep.c, syssignal.h (croak):
2577 * term.c (maybe_fatal, vfatal):
2578 * textprop.c (text_read_only):
2579 * undo.c (user_error):
2580 * unexmacosx.c (unexec_error):
2581 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2582 Use _Noreturn rather than NO_RETURN.
2583 No need for separate decl merely because of _Noreturn.
2584 * sound.c (sound_warning, parse_sound):
2585 Remove unnecessary forward decls.
2587 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2589 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2590 * lisp.h (WAIT_READING_MAX): New macro.
2591 * dispnew.c (Fsleep_for, sit_for):
2592 * keyboard.c (kbd_buffer_get_event):
2593 * process.c (Faccept_process_output):
2594 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2595 This improves on the previous patch, which introduced a bug
2596 when time_t is unsigned and as wide as intmax_t.
2597 See <http://bugs.gnu.org/9000#51>.
2599 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2601 * dispnew.c (sit_for, Fsleep_for):
2602 * keyboard.c (kbd_buffer_get_event):
2603 * process.c (Faccept_process_output): Avoid compiler warnings when
2604 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2606 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2608 * makefile.w32-in: Update dependencies.
2610 * w32.c (ltime): Add return type and declare static.
2611 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2613 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2615 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2616 Privately reported by Herbert J. Skuhra.
2617 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2619 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2620 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2622 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2624 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2625 last argument of make_unibyte_string.
2627 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2628 language ID in the event parameters.
2630 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2631 event.code, not the obscure "character set ID".
2633 2012-06-23 Chong Yidong <cyd@gnu.org>
2635 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2637 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2639 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2640 * w32.c (fdutimens): New function.
2642 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2644 * s/ms-w32.h (pselect): Redirect to sys_select.
2646 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2648 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2649 in the logic of incrementing and decrementing the value of
2650 use_relocatable_buffers.
2652 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2654 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2655 Privately reported by Herbert J. Skuhra.
2656 [__FreeBSD__]: Remove "*/" typo after "#include".
2657 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2658 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2659 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2660 Don't assume EMACS_TIME and struct timeval are the same type.
2662 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2664 Support higher-resolution time stamps (Bug#9000).
2665 The time stamps are only nanosecond-resolution at the C level,
2666 since that's the best that any real-world system supports now.
2667 But they are picosecond-resolution at the Lisp level, as that's
2668 easy, and leaves room for future OS improvements.
2670 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2673 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2674 Don't get current time unless it's needed.
2676 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2677 now provides it if it's absent.
2678 (start_atimer): Port to higher-res time stamps.
2679 Check for time stamp overflow. Don't get current time more
2680 often than is needed.
2682 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2683 Include systime.h, not time.h.
2684 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2686 * dired.c: Include stat-time.h.
2687 (Ffile-attributes): File times now have higher resolution.
2689 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2690 (struct image): Timestamp now has higher resolution.
2692 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2693 has at least microseconds now. All uses removed.
2694 (update_frame, update_single_window, update_window, update_frame_1)
2695 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2697 * editfns.c (time_overflow): Now extern.
2698 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2699 (float-time, Fformat_time_string, Fcurrent_time_string)
2700 (Fcurrent_time_zone): Accept and generate higher-resolution
2702 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2703 (decode_time_components, lisp_seconds_argument): New functions.
2704 (make_time): Now static.
2705 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2706 Report an error if the time is invalid, rather than having the caller
2709 * fileio.c: Include <stat-time.h>
2710 (Fcopy_file): Copy higher-resolution time stamps.
2711 Prefer to set the time stamp via a file descriptor if that works.
2712 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2713 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2714 (Fvisited_file_modtime, Fset_visited_file_modtime):
2715 Support higher-resolution time stamps.
2717 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2719 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2721 * image.c (prepare_image_for_display, clear_image_cache)
2722 (lookup_image): Port to higer-resolution time stamps.
2724 * keyboard.c (start_polling, bind_polling_period):
2725 Check for time stamp overflow.
2726 (read_char, kbd_buffer_get_event, timer_start_idle)
2727 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2728 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2729 Port to higher-resolution time stamps. Do not assume time_t is signed.
2730 (decode_timer): New function. Timers are now vectors of length 9,
2731 not 8, to accommodate the picosecond component.
2732 (timer_check_2): Use it.
2734 * nsterm.m (select_timeout, timeval_subtract): Remove.
2735 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2736 as they're a bit more accurate and handle overflow better.
2737 (ns_select): Change prototype to be compatible with pselect.
2738 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2739 * nsterm.h (ns_select): Adjust prototype.
2741 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2742 us-resolution time stamps.
2743 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2745 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2747 * lisp.h (time_overflow): New decl.
2748 (wait_reading_process_output): First arg is now intmax_t, not int,
2749 to accommodate larger waits.
2751 * process.h (struct Lisp_Process.read_output_delay):
2752 Now counts nanoseconds, not microseconds.
2753 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2755 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2756 (wait_reading_process_output):
2757 Port to ns-resolution time stamps.
2758 (Faccept_process_output, wait_reading_process_output):
2759 Check for time stamp overflow. Do not assume time_t is signed.
2760 (select_wrapper): Remove; we now use pselect.
2761 (Fprocess_attributes): Now generates ns-resolution time stamps.
2763 * sysdep.c: Include utimens.h. Don't include utime.h
2764 or worry about struct utimbuf; gnulib does that for us now.
2765 (gettimeofday): Remove; gnulib provides a substitute.
2766 (make_timeval): New function.
2767 (set_file_times): Now sets ns-resolution time stamps.
2768 New arg FD; all uses changed.
2769 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2770 (system_process_attributes):
2771 Now returns ns-resolution time stamp. All uses changed.
2772 Check for time stamp overflow.
2774 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2775 provides a substitute now.
2777 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2778 since it guarantees struct timespec.
2779 (EMACS_TIME): Now struct timespec, so that we can support
2780 ns-resolution time stamps.
2781 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2782 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2783 (EMACS_USECS): Remove.
2784 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2785 so multiply the arg by 1000 before storing it.
2786 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2788 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2789 Port to ns-resolution time stamps.
2790 (EMACS_TIME_NEG_P): Remove; replaced by....
2791 (EMACS_TIME_SIGN): New macro.
2792 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2793 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2794 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2795 (make_timeval, make_lisp_time, decode_time_components): New decls.
2796 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2797 that it mishandled time_t overflow. You can't compare by subtracting!
2798 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2799 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2801 * term.c: Include <sys/time.h>.
2802 (timeval_to_Time): New function, for proper overflow wraparound.
2803 (term_mouse_position, term_mouse_click): Use it.
2805 * undo.c (record_first_change): Support higher-resolution time stamps
2807 (Fprimitive_undo): Use them when restoring time stamps.
2809 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2810 (w32_get_internal_run_time):
2811 Port to higher-resolution Emacs time stamps.
2812 (ltime): Now accepts single 64-bit integer, as that's more convenient
2815 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2817 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2818 for compatibility with pselect. Support ns-resolution time stamps.
2820 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2822 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2823 Check for time stamp overflow, and support ns-resolution time stamps.
2825 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2826 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2827 (timeval_subtract): Remove; no longer needed.
2828 (XTflash, XTring_bell, x_wait_for_event):
2829 Port to ns-resolution time stamps. Don't assume time_t is signed.
2831 2012-06-22 Chong Yidong <cyd@gnu.org>
2833 * xdisp.c (x_consider_frame_title): Revert last change.
2835 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2837 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2838 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2839 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2840 staticidx goes up to 1597 out of 1600 = 0x640.)
2842 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2844 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2845 Otherwise, the umask might be mistakenly 0 while handling input signals.
2847 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2849 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2851 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2853 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2854 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2855 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2856 access to `contents' member of Lisp_Vector objects with AREF and ASET
2859 2012-06-19 Chong Yidong <cyd@gnu.org>
2861 * frame.c (delete_frame): When selecting a frame on a different
2862 text terminal, do not alter the terminal's top-frame.
2864 * xdisp.c (format_mode_line_unwind_data): Record the target
2865 frame's selected window and its terminal's top-frame.
2866 (unwind_format_mode_line): Restore them.
2867 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2869 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2870 since tty frames can be explicitly named.
2871 (prepare_menu_bars): Likewise.
2873 * term.c (Ftty_top_frame): New function.
2875 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2877 Port byte-code-meter to modern targets.
2878 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2879 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2880 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2881 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2882 (METER_1, METER_2): Simplify.
2884 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2886 * data.c (Fdefalias): Return `symbol' (bug#11686).
2888 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2890 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2891 gets killed during executing of this function (Bug#11665).
2892 Try to always return Qt when the buffer has been actually killed.
2893 (Vkill_buffer_query_functions): In doc-string say that functions
2894 run by this hook should not change the current buffer.
2896 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2898 Fix recently-introduced process.c problems found by static checking.
2899 * process.c (write_queue_push, write_queue_pop, send_process):
2900 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2901 (write_queue_pop): Fix pointer signedness problem.
2902 (send_process): Remove unused local.
2904 2012-06-17 Chong Yidong <cyd@gnu.org>
2906 * xdisp.c (redisplay_internal): No need to redisplay terminal
2907 frames that are not on top.
2909 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2911 * process.c (make_process): Initialize write_queue.
2912 (write_queue_push, write_queue_pop): New functions.
2913 (send_process): Use them to maintain correct ordering of process
2916 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2918 * lisp.h (eassert): Assume C89 or later.
2919 This removes the need for CHECK.
2920 (CHECK): Remove. Its comments about always evaluating its
2921 argument were confusing, as 'eassert' typically does not evaluate
2924 * coding.c (produce_chars): Use ptrdiff_t, not int.
2926 * xterm.c (x_draw_underwave): Check for integer overflow.
2927 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2929 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2931 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2932 referenced (Bug#11583).
2934 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2936 Implement wave-style variant of underlining.
2937 * dispextern.h (face_underline_type): New enum.
2938 (face): Add field for underline type.
2939 * nsterm.m (ns_draw_underwave): New function.
2940 (ns_draw_text_decoration): Use it.
2941 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2943 (x_draw_glyph_string): Use them.
2944 * xfaces.c (Qline, Qwave): New Lisp objects.
2945 (check_lface_attrs, merge_face_ref)
2946 (Finternal_set_lisp_face_attribute, realize_x_face):
2947 Handle wave-style underline face attributes.
2948 * xterm.c (x_draw_underwave): New function.
2949 (x_draw_glyph_string): Use it.
2951 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2953 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2954 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2955 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2956 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2957 ($(BLD)/w32select.$(O)): Update dependencies.
2959 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2961 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2962 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2963 * character.c (_fetch_multibyte_char_p): Remove.
2964 * alloc.c: Include "character.h" before "buffer.h".
2966 * buffer.c: Likewise.
2967 * bytecode.c: Likewise.
2968 * callint.c: Likewise.
2969 * callproc.c: Likewise.
2970 * casefiddle.c: Likewise.
2971 * casetab.c: Likewise.
2972 * category.c: Likewise.
2974 * coding.c: Likewise.
2975 * composite.c: Likewise.
2976 * dired.c: Likewise.
2977 * dispnew.c: Likewise.
2979 * dosfns.c: Likewise.
2980 * editfns.c: Likewise.
2981 * emacs.c: Likewise.
2982 * fileio.c: Likewise.
2983 * filelock.c: Likewise.
2985 * fontset.c: Likewise.
2986 * fringe.c: Likewise.
2987 * indent.c: Likewise.
2988 * insdel.c: Likewise.
2989 * intervals.c: Likewise.
2990 * keyboard.c: Likewise.
2991 * keymap.c: Likewise.
2992 * lread.c: Likewise.
2993 * macros.c: Likewise.
2994 * marker.c: Likewise.
2995 * minibuf.c: Likewise.
2996 * nsfns.m: Likewise.
2997 * nsmenu.m: Likewise.
2998 * print.c: Likewise.
2999 * process.c: Likewise.
3000 * regex.c: Likewise.
3001 * region-cache.c: Likewise.
3002 * search.c: Likewise.
3003 * syntax.c: Likewise.
3005 * textprop.c: Likewise.
3007 * unexsol.c: Likewise.
3008 * w16select.c: Likewise.
3009 * w32fns.c: Likewise.
3010 * w32menu.c: Likewise.
3011 * window.c: Likewise.
3012 * xdisp.c: Likewise.
3014 * xmenu.c: Likewise.
3016 * xselect.c: Likewise.
3018 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3020 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3021 If all the glyphs of the glyph row came from strings, and we have no
3022 cursor positioning clues, put the cursor on the first glyph of the
3024 (handle_face_prop): Use chunk-relative overlay string index when
3025 indexing into it->string_overlays array. (Bug#11653)
3026 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3027 the rightmost. (Bug#11720)
3029 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3031 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3032 (CATEGORY_MEMBER): Enforce 1/0 value.
3033 * category.c (_temp_category_set): Remove.
3035 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3037 * window.c (Fdelete_other_windows_internal)
3038 (Fdelete_window_internal): Don't access frame's mouse highlight
3039 info of the initial frame. (Bug#11677)
3041 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3043 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3044 Assume USE_2_TAGS_FOR_INTS.
3045 (xreload): Adjust $tagmask width to match recent lisp.h change.
3047 Simplify lisp.h in minor ways that should not affect code.
3048 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3049 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3050 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3051 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3052 (INTTYPEBITS): New macro, for clarity.
3053 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3054 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3055 Simplify now that USE_LSB_TAG is always defined.
3056 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3057 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3059 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3061 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3063 2012-06-13 Glenn Morris <rgm@gnu.org>
3065 * s/bsd-common.h (BSD4_3):
3066 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3068 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3070 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3073 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3075 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3076 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3077 * alloc.c (widen_to_Lisp_Object): Remove.
3078 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3079 * frame.c (delete_frame): Remove outdated comment.
3080 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3081 USE_LISP_UNION_TYPE.
3082 (Fw32_unregister_hot_key): Likewise.
3083 (Fw32_toggle_lock_key): Likewise.
3084 * w32menu.c (add_menu_item): Likewise.
3085 (w32_menu_display_help): Use XIL instead of checking
3086 USE_LISP_UNION_TYPE.
3087 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3088 (init_heap): Likewise.
3089 * w32term.c (w32_read_socket): Update comment.
3091 2012-06-13 Glenn Morris <rgm@gnu.org>
3093 * s/usg5-4-common.h, src/s/unixware.h:
3094 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3096 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3098 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3100 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3101 * alloc.c (make_number) [!defined make_number]:
3102 Remove, as lisp.h always defines this now.
3103 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3104 (roundup_size): Verify that it is a power of 2.
3105 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3106 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3107 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3108 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3109 USE_LSB_TAG now is always defined to be either 0 or 1.
3111 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3112 code works fine either way, and efficiency is not a concern here,
3113 as the union type is for debugging, not for production.
3114 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3115 Use an inline function on all platforms when using the union type,
3116 since this is simpler and 'static inline' can be used portably
3118 (LISP_INITIALLY_ZERO): New macro.
3119 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3120 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3122 2012-06-12 Glenn Morris <rgm@gnu.org>
3124 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3126 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3128 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3129 Move BROKEN_SIGIO to configure.
3131 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3132 Move NO_TERMIO to configure.
3134 2012-06-12 Chong Yidong <cyd@gnu.org>
3136 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3137 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3138 MagickExportImagePixels is undefined.
3140 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3142 * image.c (imagemagick_load_image): Remove unused label.
3144 2012-06-11 Glenn Morris <rgm@gnu.org>
3146 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3147 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3148 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3149 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3151 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3153 * alloc.c (make_byte_code): New function.
3154 (Fmake_byte_code): Use it. Don't purify here.
3155 * lread.c (read1): Use it as well to avoid extra allocation.
3157 2012-06-11 Chong Yidong <cyd@gnu.org>
3159 * image.c (imagemagick_load_image): Implement transparency.
3161 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3163 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3164 account for preceding backslashes. (Bug#11663)
3166 2012-06-09 Chong Yidong <cyd@gnu.org>
3168 * term.c: Support italics in capable terminals (Bug#9652).
3169 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3170 (turn_on_face): Output using TS_enter_italic_mode if available.
3171 Don't handle unused blinking and alt-charset cases.
3172 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3173 and tty_alt_charset_p cases.
3174 (tty_capable_p, init_tty): Support italics.
3176 * termchar.h (struct tty_display_info): Add field for italics.
3177 Remove unused blink field.
3179 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3182 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3183 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3184 tty_alt_charset_p. Add tty_italic_p.
3186 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3188 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3189 dbus_type_is_basic if available.
3190 (xd_extract_signed, xd_extract_unsigned): Rename from
3191 extract_signed and extract_unsigned, respectively. Adapt callers.
3193 2012-06-09 Chong Yidong <cyd@gnu.org>
3195 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3197 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3200 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3202 * xdisp.c (vmessage): Treat frame message as multibyte.
3203 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3204 would generate the diagnostic "Making \302\247 buffer-local while
3207 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3209 * dispnew.c (showing_window_margins_p): Undo last change, which
3210 was done due to an inadvertent commit.
3211 (adjust_frame_glyphs_for_frame_redisplay): Do call
3212 showing_window_margins_p.
3214 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3216 * eval.c (Fmake_var_non_special): New primitive.
3217 (syms_of_eval): Defsubr it.
3218 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3220 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3222 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3223 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3225 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3227 * alloc.c (allocate_vectorlike): Fix last change.
3229 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3231 Block-based vector allocation of small vectors.
3232 * lisp.h (struct vectorlike_header): New field `nbytes',
3233 adjust comment accordingly.
3234 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3235 to denote vector blocks. Adjust users (live_vector_p,
3236 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3237 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3238 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3239 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3240 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3241 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3242 (roundup_size): New constant.
3243 (struct vector_block): New data type.
3244 (vector_blocks, vector_free_lists, zero_vector): New variables.
3245 (all_vectors): Rename to `large_vectors'.
3246 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3247 (sweep_vectors): New functions.
3248 (allocate_vectorlike): Return `zero_vector' as the only vector of
3249 0 items. Allocate new vector from block if vector size is less than
3250 or equal to VBLOCK_BYTES_MAX.
3251 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3252 (init_alloc_once): Add call to init_vectors.
3254 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3256 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3258 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3260 * doprnt.c (doprnt): Truncate multibyte char correctly.
3261 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3262 would mishandle a string argument "Xc" if X was a multibyte
3263 character of length 2: it would truncate after X's first byte
3264 rather than including all of X.
3266 2012-06-06 Chong Yidong <cyd@gnu.org>
3268 * buffer.c (word_wrap): Doc fix.
3270 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3272 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3274 2012-06-03 Glenn Morris <rgm@gnu.org>
3276 * xdisp.c (tool-bar-style): Doc fix.
3278 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3280 * Makefile.in (PAXCTL): Define.
3281 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3282 binary via PaX flags if the paxctl utility is available.
3283 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3284 Restore PaX flags to their default. (Bug#11398)
3286 2012-06-03 Chong Yidong <cyd@gnu.org>
3288 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3291 2012-06-03 Chong Yidong <cyd@gnu.org>
3293 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3294 (note_mode_line_or_margin_highlight): If there is no help echo,
3295 use mode-line-default-help-echo. Handle the case where the mouse
3296 position is past the end of the mode line string.
3298 * buffer.c (buffer_local_value_1): New function, split from
3299 Fbuffer_local_value; can return Qunbound.
3300 (Fbuffer_local_value): Use it.
3301 (Vmode_line_format): Docstring tweaks.
3303 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3305 * sysdep.c (system_process_attributes): Improve comment.
3307 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3309 * keyboard.c: Export real-this-command to Elisp.
3310 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3311 and DEFVAR it. Update all users.
3313 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3315 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3317 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3318 Convert pctcpu and pctmem to Lisp float properly.
3319 Let the compiler fold better, as 100.0/0x8000 is exact.
3321 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3323 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3326 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3328 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3330 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3332 For a 'struct window', replace some Lisp_Object fields to
3333 bitfields where appropriate, remove unused fields.
3334 * window.h (struct window): Remove unused 'last_mark_x' and
3335 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3336 change it's type from Lisp_Object to bitfield.
3337 Change type of 'force_start', 'optional_new_start',
3338 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3339 fields from Lisp_Object to bitfield. Adjust users accordingly.
3341 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3343 Pacify gcc -Wdouble-precision when using Xaw.
3344 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3345 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3346 Use 'float' consistently, rather than 'float' in most places
3347 and 'double' in a couple of places.
3349 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3351 * xdisp.c (handle_stop): Detect whether we have overlay strings
3352 loaded by testing it->current.overlay_string_index to be
3353 non-negative, instead of checking whether n_overlay_strings is
3354 positive. (Bug#11587)
3356 2012-05-31 Chong Yidong <cyd@gnu.org>
3358 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3360 * doc.c (Fsubstitute_command_keys): Doc fix.
3362 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3364 * search.c (search_buffer): Remove calls to
3365 r_alloc_inhibit_buffer_relocation, as it is now called by
3366 maybe_unify_char, which was the cause of relocation of buffer text
3369 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3371 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3372 for the duration of call to load_charset, to avoid problems with
3373 callers of maybe_unify_char that access buffer text through C
3376 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3377 decrement the inhibition flag, instead of just setting or
3380 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3382 Remove obsolete '#define static' cruft.
3383 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3384 This #undef was "temporary" in 2000; it is no longer needed
3385 now that '#define static' has gone away.
3386 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3387 (gray_bitmap_bits): Remove; no longer needed.
3388 All uses replaced with definiens.
3389 * xterm.c: Include "bitmaps/gray.xbm".
3391 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3393 Clean up __executable_start, monstartup when --enable-profiling.
3394 The following changes affect the code only when profiling.
3395 * dispnew.c (__executable_start): Rename from safe_bcopy.
3396 Define only on platforms that need it.
3397 * emacs.c: Include <sys/gmon.h> when profiling.
3398 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3399 (__executable_start): Remove decl, since lisp.h does it now.
3400 (safe_bcopy): Remove decl; no longer has that name.
3401 (main): Coalesce #if into single bit of code, for simplicity.
3402 Cast pointers to uintptr_t, since standard libraries want integers
3404 * lisp.h (__executable_start): New decl.
3406 2012-05-31 Glenn Morris <rgm@gnu.org>
3408 * image.c (Fimagemagick_types): Doc fix.
3410 2012-05-30 Jim Meyering <meyering@redhat.com>
3412 * callproc.c (Fcall_process_region): Include directory component
3413 in mkstemp error message (Bug#11586).
3415 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3417 * alloc.c, lisp.h (make_pure_vector): Now static.
3419 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3421 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3422 Move to byte-run.el.
3423 (Fautoload): Do the hash-doc more carefully.
3424 * data.c (Fdefalias): Purify definition, except for keymaps.
3425 (Qdefun): Move from eval.c.
3426 * lisp.h (Qdefun): Remove.
3427 * lread.c (read1): Tiny simplification.
3429 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3431 Do not create empty overlays with the evaporate property (Bug#9642).
3432 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3433 Bug#9642, but explicitly check that the buffer the overlay would
3434 be moved to is live and rearrange lines to make sure that errors
3435 will not put the overlay in an inconsistent state.
3436 (Fdelete_overlay): Cosmetics.
3438 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3440 * w32term.c (my_bring_window_to_top): New function.
3441 (x_raise_frame): Use handle returned by DeferWindowPos, which
3442 could be different from the original one.
3443 Call my_bring_window_to_top instead of my_set_foreground_window.
3446 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3447 by calling BringWindowToTop.
3449 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3450 (WM_EMACS_END): Increase by one.
3452 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3454 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3455 This avoids undefined behavior that might cause the eassert
3456 to not catch an out-of-range value.
3458 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3460 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3461 Update dependencies.
3463 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3465 * bidi.c (bidi_mirror_char): Fix last change.
3467 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3469 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3470 when referring to sectname field in printf format.
3472 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3474 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3475 Only r_alloc_inhibit_buffer_relocation needed to be added;
3476 the others were already declared.
3478 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3479 before checking whether it's out of range. Put the check inside
3481 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3483 2012-05-27 Ken Brown <kbrown@cornell.edu>
3485 * callproc.c (Fcall_process): Restore a line that was accidentally
3486 commented out in the 2011-02-13 change (bug#11547).
3488 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3490 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3491 defined on ralloc.c.
3493 * buffer.c [REL_ALLOC]: Remove prototypes of
3494 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3495 they are now on lisp.h.
3497 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3499 * search.c (search_buffer): Use it to inhibit relocation of buffer
3500 text while re_search_2 is doing its job, because re_search_2 is
3501 passed C pointers to buffer text. (Bug#11519)
3503 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3506 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3507 state after an additional call to move_it_in_display_line_to, keep
3508 the values of it->max_ascent and it->max_descent found for the
3510 (pos_visible_p): Revert the comparison against bottom_y to what it
3511 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3514 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3516 Fix coding-related core dumps with gcc -ftrapv.
3517 The code was computing A - B, where A and B are pointers, and B is
3518 random garbage. This can lead to core dumps on platforms that
3519 have special pointer registers, and it also leads to core dumps on
3520 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3521 A - B only when B is initialized properly.
3522 * coding.c (coding_set_source, coding_set_destination): Return void.
3523 (coding_change_source, coding_change_destinations): New functions,
3524 with the old behaviors of coding_set_source and coding_set_destination.
3525 All callers that need an offset changed to use these new functions.
3527 2012-05-26 Glenn Morris <rgm@gnu.org>
3529 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3531 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3533 Extend mouse support on W32 text-mode console.
3534 * xdisp.c (draw_row_with_mouse_face):
3535 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3537 * w32console.c: Include window.h.
3538 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3540 (initialize_w32_display): Initialize mouse-highlight data.
3542 * w32inevt.c: Include termchar.h and window.h.
3543 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3544 moves, call note_mouse_highlight. If help_echo changed, call
3545 gen_help_event to produce help-echo message in the echo area.
3546 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3549 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3551 * lread.c (read1): Simplify slightly to avoid an overflow warning
3552 with GCC 4.7.0 on x86-64.
3554 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3556 * bidi.c (bidi_mirror_char): Revert last change: an int is
3557 definitely wide enough here.
3559 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3561 Fix integer width and related bugs (Bug#9874).
3562 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3563 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3564 (string_bytes, check_sblock, allocate_string_data):
3565 (compact_small_strings, Fmake_bool_vector, make_string)
3566 (make_unibyte_string, make_multibyte_string)
3567 (make_string_from_bytes, make_specified_string)
3568 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3569 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3572 (allocate_pseudovector):
3573 Use int, not EMACS_INT, where int is wide enough.
3574 (inhibit_garbage_collection, Fgarbage_collect):
3575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3576 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3577 int might not be wide enough.
3578 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3579 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3580 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3581 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3582 (bidi_level_of_next_char, bidi_move_to_visually_next):
3583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3584 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3585 (Fkill_buffer, Fset_buffer_major_mode)
3586 (advance_to_char_boundary, Fbuffer_swap_text)
3587 (Fset_buffer_multibyte, overlays_at, overlays_in)
3588 (overlay_touches_p, struct sortvec, record_overlay_string)
3589 (overlay_strings, recenter_overlay_lists)
3590 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3591 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3592 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3593 (Foverlay_recenter, last_overlay_modification_hooks_used)
3594 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (validate_region): Omit unnecessary test for b <= e,
3597 since that's guaranteed by the previous test.
3598 (adjust_overlays_for_delete): Avoid pos + length overflow.
3599 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3600 (report_overlay_modification):
3601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3602 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3603 Omit pointer cast, which isn't needed anyway, and doesn't work
3604 after the EMACS_INT -> ptrdiff_t change.
3605 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3606 * buffer.h: Adjust decls to match defn changes elsewhere.
3607 (struct buffer_text, struct buffer):
3608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3609 Use EMACS_INT, not int, where int might not be wide enough.
3610 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3611 not int, to avoid needless 32-bit limit on 64-bit hosts.
3612 (exec_byte_code): Use tighter memory-full test, one that checks
3613 for alloca overflow. Don't compute the address of the object just
3614 before an array, as that's not portable. Use EMACS_INT, not
3615 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3616 * callint.c (Fcall_interactively):
3617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3618 * callproc.c (call_process_kill, Fcall_process):
3619 Don't assume pid_t fits into an Emacs fixnum.
3620 (call_process_cleanup, Fcall_process, child_setup):
3621 Don't assume pid_t fits into int.
3622 (call_process_cleanup, Fcall_process, delete_temp_file)
3623 (Fcall_process_region):
3624 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3625 (Fcall_process): Simplify handling of volatile integers.
3626 Use int, not EMACS_INT, where int will do.
3627 * casefiddle.c (casify_object, casify_region, operate_on_word)
3628 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3630 (casify_object): Avoid integer overflow when overallocating buffer.
3631 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3632 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3633 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3634 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3635 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3636 integers are now checked earlier. All uses replaced with XINT.
3638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3639 For CCL_MapSingle, check that content and value are in int range.
3640 (ccl_driver, Fregister_code_conversion_map):
3641 Check that Vcode_version_map_vector is a vector.
3642 (resolve_symbol_ccl_program): Check that vector header is in range.
3643 Always copy the vector, so that we can check its contents reliably
3644 now rather than having to recheck each instruction as it's being
3645 executed. Check that vector words fit in 'int'.
3646 (ccl_get_compiled_code, Fregister_ccl_program)
3647 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3648 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3649 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3650 contents are in range.
3651 (Fccl_execute_on_string): Check that status is in range.
3652 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3653 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3654 Accept and return EMACS_INT, not int, because callers can pass values
3656 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3657 (multibyte_chars_in_text, parse_str_as_multibyte)
3658 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3659 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3660 (string_escape_byte8, Fget_byte):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3663 avoid mishandling large integers.
3664 * character.h: Adjust decls to match defn changes elsewhere.
3665 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3666 (Ffind_charset_region):
3667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3668 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3669 (load_charset_map_from_vector, Fdefine_charset_internal):
3670 Don't assume fixnum fits in int.
3671 (load_charset_map_from_vector, Fmap_charset_chars):
3672 Remove now-unnecessary CHECK_NATNUMs.
3673 (Fdefine_charset_internal): Check ranges here, more carefully.
3674 Don't rely on undefined behavior with signed left shift overflow.
3675 Don't assume unsigned int fits into fixnum, or that fixnum fits
3676 into unsigned int. Don't require max_code to be a valid fixnum;
3677 that's not true for gb10830 4-byte on a 32-bit host. Allow
3678 invalid_code to be a cons, for the same reason. Require code_offset
3679 to be a character. Avoid int overflow if max_char is close
3681 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3682 this is intended anyway and avoids some undefined behavior.
3683 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3684 INDEX_TO_CODE_POINT, as that's what it expects.
3685 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3686 * charset.h (DECODE_CHAR): Return int, not unsigned;
3687 this is what was intended anyway, and it avoids undefined behavior.
3688 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3689 integer-overflow issues.
3690 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3691 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3692 where the argument is EMACS_INT, and this behavior is not intended.
3693 * chartab.c (Fmake_char_table, Fset_char_table_range)
3694 (uniprop_get_decoder, uniprop_get_encoder):
3695 Don't assume fixnum fits in int.
3696 * cmds.c (move_point): New function, that does the gist of
3697 Fforward_char and Fbackward_char, but does so while checking
3698 for integer overflow more accurately.
3699 (Fforward_char, Fbackward_char): Use it.
3700 (Fforward_line, Fend_of_line, internal_self_insert)
3701 (internal_self_insert):
3702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3703 Fix a FIXME, by checking for integer overflow when calculating
3704 target_clm and actual_clm.
3705 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3706 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3707 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3708 (coding_alloc_by_making_gap, alloc_destination)
3709 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3710 (encode_coding_utf_16, detect_coding_emacs_mule)
3711 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3712 (detect_coding_iso_2022, decode_coding_iso_2022)
3713 (encode_invocation_designation, encode_designation_at_bol)
3714 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3715 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3716 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3717 (encode_coding_ccl, encode_coding_raw_text)
3718 (detect_coding_charset, decode_coding_charset)
3719 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3720 (produce_composition, produce_charset, produce_annotation)
3721 (decode_coding, handle_composition_annotation)
3722 (handle_charset_annotation, consume_chars, decode_coding_gap)
3723 (decode_coding_object, encode_coding_object, detect_coding_system)
3724 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3725 (code_convert_region, code_convert_string)
3726 (Fdefine_coding_system_internal)
3727 (coding_set_source, coding_set_destination):
3728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3729 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3730 (Fdefine_coding_system_internal):
3731 Don't assume fixnums fit in int.
3732 (decode_coding_gap, decode_coding_object, encode_coding_object)
3733 (Fread_coding_system, Fdetect_coding_region)
3734 (Funencodable_char_position, Fcheck_coding_systems_region)
3735 (get_translation, handle_composition_annotation, consume_chars):
3736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3737 (consume_chars): Rewrite to not calculate an address outside buffer.
3738 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3739 Don't access memory outside of the args array.
3740 (Fdefine_coding_system_internal): Check for charset-id overflow.
3741 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3742 result of ENCODE_CHAR.
3743 * coding.h: Adjust decls to match defn changes elsewhere.
3744 (struct coding_system):
3745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3746 * composite.c (get_composition_id, find_composition)
3747 (run_composition_function, update_compositions)
3748 (compose_text, composition_gstring_put_cache)
3749 (composition_gstring_p, composition_gstring_width)
3750 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3751 (composition_compute_stop_pos, composition_reseat_it)
3752 (composition_update_it, struct position_record)
3753 (find_automatic_composition, composition_adjust_point)
3754 (Fcomposition_get_gstring, Ffind_composition_internal):
3755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3756 (update_compositions):
3757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3758 * composite.h: Adjust decls to match defn changes elsewhere.
3759 (struct composition):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3762 Do not attempt to compute the address of the object just before a
3763 buffer; this is not portable.
3765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3766 (Faset): Use int, not EMACS_INT, where int is wide enough.
3767 (Fstring_to_number): Don't assume fixnums fit in int.
3768 (Frem): Don't assume arg is nonnegative.
3769 * dbusbind.c (xd_append_arg): Check for integers out of range.
3770 (Fdbus_call_method): Don't overflow the timeout int.
3771 (extract_signed, extract_unsigned): New functions.
3772 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3773 (xd_get_connection_references): Return ptrdiff_t, not int.
3775 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3776 (xd_read_message_1):
3777 Use int, not unsigned, where the dbus API uses int.
3778 (Fdbus_message_internal): Don't overflow mtype.
3779 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3780 * dired.c (directory_files_internal, file_name_completion, scmp)
3781 (file_name_completion_stat):
3782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3783 (file_name_completion): Don't overflow matchcount.
3784 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3785 * dispextern.h: Adjust decls to match defn changes elsewhere.
3786 (struct text_pos, struct glyph, struct bidi_saved_info)
3787 (struct bidi_string_data, struct bidi_it, struct composition_it)
3789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3790 (struct display_pos, struct composition_it, struct it):
3791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3792 * dispnew.c (increment_matrix_positions)
3793 (increment_row_positions, mode_line_string)
3794 (marginal_area_string):
3795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3796 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3797 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3798 (duration_to_sec_usec): New function, to check for overflow better.
3799 (Fsleep_for, sit_for): Use it.
3800 * doc.c (get_doc_string, store_function_docstring):
3801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3802 (get_doc_string, Fsnarf_documentation):
3803 Use int, not EMACS_INT, where int is wide enough.
3805 Use SAFE_ALLOCA, not alloca.
3806 Check for overflow when converting EMACS_INT to off_t.
3807 * doprnt.c (doprnt):
3808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3809 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3810 Don't assume uid_t fits into fixnum.
3811 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3812 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3813 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3814 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3815 (general_insert_function)
3816 (Finsert_char, make_buffer_string, make_buffer_string_both)
3817 (update_buffer_properties, Fbuffer_substring)
3818 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3819 (Fsubst_char_in_region, check_translation)
3820 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3821 (transpose_markers, Ftranspose_regions):
3822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3823 (clip_to_bounds): Move to lisp.h as an inline function).
3824 (Fconstrain_to_field): Don't assume integers are nonnegative.
3825 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3826 (Fsubst_char_in_region, Fsave_restriction):
3827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3828 (Femacs_pid): Don't assume pid_t fits into fixnum.
3829 (lo_time): Use int, not EMACS_INT, when int suffices.
3830 (lisp_time_argument): Check for usec out of range.
3831 (Fencode_time): Don't assume fixnum fits in int.
3832 (Fuser_login_name, Fuser_full_name): Signal an error
3833 if a uid argument is out of range, rather than relying on
3835 (Fformat_time_string): Remove now-unnecessary check.
3836 lisp_time_argument checks for out-of-range usec now.
3837 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3838 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3839 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3840 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3841 (init_cmdargs, Fdump_emacs):
3842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3843 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3844 the bottom (typically) 32 bits of the fixnum.
3845 * eval.c (specpdl_size, call_debugger):
3846 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3847 (when_entered_debugger, Fbacktrace_debug):
3848 Don't assume fixnum can fit in int.
3849 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3850 the object just before a buffer; this is not portable.
3851 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3852 (grow_specpdl, unbind_to):
3853 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3854 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3855 (grow_specpdl): Simplify allocation by using xpalloc.
3856 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3857 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3858 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3862 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3863 (Fcopy_file, non_regular_nbytes, read_non_regular)
3864 (Finsert_file_contents):
3865 Use int, not EMACS_INT, where int is wide enough.
3866 (READ_BUF_SIZE): Verify that it fits in int.
3867 (Finsert_file_contents): Check that counts are in proper range,
3868 rather than assuming fixnums fit into ptrdiff_t etc.
3869 Don't assume fixnums fit into int.
3870 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3871 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3872 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3873 (string_char_to_byte, string_byte_to_char)
3874 (string_make_multibyte, string_to_multibyte)
3875 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3876 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3877 (substring_both, Fdelete, internal_equal, Ffillarray)
3878 (Fclear_string, mapcar1)
3879 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3880 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3881 (larger_vector, make_hash_table, maybe_resize_hash_table)
3882 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3883 (Fmaphash, secure_hash):
3884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3885 (concat): Check for string index and length overflow.
3886 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3888 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3889 (larger_vector): New API (vec, incr_min, size_max) replaces old
3890 one (vec, new_size, init). This catches size overflow.
3891 INIT was removed because it was always Qnil.
3892 All callers changed.
3893 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3894 the upper bound on a hash table index size.
3895 (make_hash_table, maybe_resize_hash_table): Use it.
3896 (secure_hash): Computer start_byte and end_byte only after
3897 they're known to be in ptrdiff_t range.
3898 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3899 (Ffont_get_glyphs, Ffont_at):
3900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3901 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3902 (Flist_fonts, Fopen_font):
3903 Don't assume fixnum can fit in int.
3904 (check_gstring): Don't assume index can fit in int.
3905 (font_match_p): Check that fixnum is a character, not a nonnegative
3906 fixnum, since the later code needs to stuff it into an int.
3907 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3908 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3909 conversion overflow issues.
3910 (Fopen_font): Check for integer out of range.
3911 (Ffont_get_glyphs): Don't assume index can fit in int.
3912 * font.h: Adjust decls to match defn changes elsewhere.
3913 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3915 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3916 printmax_t, where ptrdiff_t is wide enough.
3917 (Finternal_char_font):
3918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3919 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3920 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3921 (Fset_frame_position, x_set_frame_parameters)
3922 (x_set_line_spacing, x_set_border_width)
3923 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3924 Check that fixnums are in proper range for system types.
3925 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3927 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3928 Use SAFE_ALLOCA_LISP, not alloca.
3929 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3930 intptr_t is wide enough.
3931 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3932 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3933 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3934 Check for fixnum out of range.
3935 * ftfont.c (ftfont_list): Don't assume index fits in int.
3936 Check that fixnums are in proper range for system types.
3937 (ftfont_shape_by_flt):
3938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3939 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3941 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3942 Check that fixnums are in proper range for system types.
3943 * gnutls.h: Adjust decls to match defn changes elsewhere.
3944 * gtkutil.c (xg_dialog_run):
3945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3946 (update_frame_tool_bar):
3947 Check that fixnums are in proper range for system types.
3948 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3949 (lookup_image): Check that fixnums are in range for system types.
3950 * indent.c (last_known_column, last_known_column_point):
3951 (current_column_bol_cache):
3952 (skip_invisible, current_column, check_display_width):
3953 (check_display_width, scan_for_column, current_column_1)
3954 (Findent_to, Fcurrent_indentation, position_indentation)
3955 (indented_beyond_p, Fmove_to_column, compute_motion):
3956 (Fcompute_motion, Fvertical_motion):
3957 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3958 (last_known_column_modified): Use EMACS_INT, not int.
3959 (check_display_width):
3961 Check that fixnums and floats are in proper range for system types.
3962 (compute_motion): Don't assume index or fixnum fits in int.
3963 (compute_motion, Fcompute_motion):
3964 Use int, not EMACS_INT, when it is wide enough.
3965 (vmotion): Omit local var start_hpos that is always 0; that way
3966 we don't need to worry about overflow in expressions involving it.
3967 * indent.h: Adjust decls to match defn changes elsewhere.
3969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3970 Use int, not EMACS_INT, where int is wide enough.
3971 Remove unused members ovstring_chars_done and tab_offset;
3973 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3974 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3975 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3976 (make_gap, copy_text, insert, insert_and_inherit)
3977 (insert_before_markers, insert_before_markers_and_inherit)
3978 (insert_1, count_combining_before, count_combining_after)
3979 (insert_1_both, insert_from_string)
3980 (insert_from_string_before_markers, insert_from_string_1)
3981 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3982 (adjust_after_replace, adjust_after_insert, replace_range)
3983 (replace_range_2, del_range, del_range_1, del_range_byte)
3984 (del_range_both, del_range_2, modify_region)
3985 (prepare_to_modify_buffer, signal_before_change)
3986 (signal_after_change, Fcombine_after_change_execute):
3987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3988 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3989 (balance_an_interval, split_interval_right, split_interval_left)
3990 (find_interval, next_interval, update_interval)
3991 (adjust_intervals_for_insertion, delete_node, delete_interval)
3992 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3993 (static_offset_intervals, offset_intervals)
3994 (merge_interval_right, merge_interval_left, make_new_interval)
3995 (graft_intervals_into_buffer, temp_set_point_both)
3996 (temp_set_point, set_point, adjust_for_invis_intang)
3997 (set_point_both, move_if_not_intangible, get_property_and_range)
3998 (get_local_map, copy_intervals, copy_intervals_to_string)
3999 (compare_string_intervals, set_intervals_multibyte_1):
4000 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4001 * intervals.h: Adjust decls to match defn changes elsewhere.
4003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4004 * keyboard.c (this_command_key_count, this_single_command_key_start)
4005 (before_command_key_count, before_command_echo_length, echo_now)
4006 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4007 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4008 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4009 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4011 (last_non_minibuf_size, last_point_position, echo_truncate)
4012 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4013 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4014 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4015 (stuff_buffered_input):
4016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4017 (last_auto_save, command_loop_1, read_char):
4018 Use EMACS_INT, not int, to avoid integer overflow.
4019 (record_char): Avoid overflow in total_keys computation.
4020 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4021 * keyboard.h: Adjust decls to match defn changes elsewhere.
4022 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4023 (Fkey_description, Fdescribe_vector, Flookup_key):
4024 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4025 (click_position): New function, to check that positions are in range.
4026 (Fcurrent_active_maps):
4028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4029 (Faccessible_keymaps, Fkey_description):
4030 (preferred_sequence_p):
4031 Don't assume fixnum can fit into int.
4032 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4033 Check for integer overflow in size calculations.
4034 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4035 avoid mishandling large integers.
4036 * lisp.h: Adjust decls to match defn changes elsewhere.
4037 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4038 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4039 (struct Lisp_Marker):
4040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4041 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4042 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4043 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4044 All callers changed.
4045 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4046 Assume the arg has valid form, since it always does.
4047 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4048 unsigned integer system type.
4049 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4050 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4052 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4053 (duration_to_sec_usec): New decl.
4054 * lread.c (read_from_string_index, read_from_string_index_byte)
4055 (read_from_string_limit, readchar, unreadchar, openp)
4056 (read_internal_start, read1, oblookup):
4057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4058 (Fload, readevalloop, Feval_buffer, Feval_region):
4059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4060 (openp): Check for out-of-range argument to 'access'.
4061 (read1): Use int, not EMACS_INT, where int is wide enough.
4062 Don't assume fixnum fits into int.
4063 Fix off-by-one error that can read outside a buffer.
4064 (read_filtered_event): Use duration_to_sec_usec
4065 to do proper overflow checking on durations.
4066 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4067 in size calculation.
4068 (Fexecute_kbd_macro):
4069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4070 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4071 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4072 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4073 (set_marker_both, set_marker_restricted_both, marker_position)
4074 (marker_byte_position, Fbuffer_has_markers_at):
4075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4076 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4077 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4078 It now merely ensures that the menu is large enough, without
4079 necessarily growing it, as this avoids some integer overflow issues.
4080 All callers changed.
4081 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4082 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4083 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4084 Use SAFE_ALLOCA_LISP, not alloca.
4085 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4086 to EMACS_INT. Check that fixnums are in proper range for system types.
4087 * minibuf.c (minibuf_prompt_width, string_to_object)
4088 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4089 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4091 (get_minibuffer, read_minibuf_unwind):
4092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4093 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4094 this simplifies overflow checking. All callers changed.
4095 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4098 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4099 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4100 Check that fixnums are in proper range for system types.
4101 (Fx_create_frame, Fx_show_tip):
4102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4103 * nsfont.m (ns_findfonts, nsfont_list_family):
4104 Don't assume fixnum fits in long.
4105 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4107 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4109 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4111 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4112 (PRINTDECLARE, PRINTPREPARE):
4113 (strout, print_string):
4114 (print, print_preprocess, print_check_string_charset_prop)
4116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4118 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4120 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4121 (printchar, strout): Use xpalloc to catch size calculation overflow.
4122 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4123 (print_error_message): Use SAFE_ALLOCA, not alloca.
4124 (print_object): Use int, not EMACS_INT, where int is wide enough.
4125 (print_depth, new_backquote_output, print_number_index):
4126 Use ptrdiff_t, not int, where int might not be wide enough.
4127 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4128 (Fset_process_window_size, Fformat_network_address)
4129 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4131 Check that fixnums are in proper range for system types.
4132 (Fsignal_process): Simplify by avoiding a goto.
4133 Check for process-ids out of pid_t range rather than relying on
4135 (process_tick, update_tick): Use EMACS_INT, not int.
4136 (Fformat_network_address, read_process_output, send_process)
4137 (Fprocess_send_region, status_notify):
4138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4139 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4140 (wait_reading_process_output, read_process_output, exec_sentinel):
4141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4142 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4143 (Faccept_process_output): Use duration_to_sec_usec to do proper
4144 overflow checking on durations.
4145 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4146 Don't assume pid_t fits in int.
4147 * process.h (struct Lisp_Process): Members tick and update_tick
4148 are now of type EMACS_INT, not int.
4149 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4150 configured --with-wide-int.
4151 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4152 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4153 * search.c (looking_at_1, string_match_1):
4154 (fast_string_match, fast_c_string_match_ignore_case)
4155 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4156 (scan_newline, find_before_next_newline, search_command)
4157 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4158 (set_search_regs, wordify):
4161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4162 (string_match_1, search_buffer, set_search_regs):
4164 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4165 (wordify): Check for overflow in size calculation.
4166 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4167 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4168 Check that fixnums are in proper range for system types.
4169 * sound.c (struct sound_device)
4170 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4171 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4172 (Fplay_sound_internal):
4173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4174 * syntax.c (struct lisp_parse_state, find_start_modiff)
4175 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4176 (Fparse_partial_sexp):
4177 Don't assume fixnums can fit in int.
4178 (struct lisp_parse_state, find_start_pos, find_start_value)
4179 (find_start_value_byte, find_start_begv)
4180 (update_syntax_table, char_quoted, dec_bytepos)
4181 (find_defun_start, prev_char_comend_first, back_comment):
4182 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4183 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4185 (Finternal_describe_syntax_value): Check that match_lisp is a
4186 character, not an integer, since the code stuffs it into int.
4187 (scan_words, scan_sexps_forward):
4188 Check that fixnums are in proper range for system types.
4190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4191 (scan_sexps_forward):
4192 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4193 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4194 * syntax.h: Adjust decls to match defn changes elsewhere.
4195 (struct gl_state_s):
4196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4197 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4198 MOST_POSITIVE_FIXNUM.
4199 * sysdep.c (wait_for_termination_1, wait_for_termination)
4200 (interruptible_wait_for_termination, mkdir):
4201 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4202 (emacs_read, emacs_write):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4204 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4205 and double all fit in int.
4206 * term.c (set_tty_color_mode):
4207 Check that fixnums are in proper range for system types.
4208 * termhooks.h (struct input_event):
4209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4210 * textprop.c (validate_interval_range, interval_of)
4211 (Fadd_text_properties, set_text_properties_1)
4212 (Fremove_text_properties, Fremove_list_of_text_properties)
4213 (Ftext_property_any, Ftext_property_not_all)
4214 (copy_text_properties, text_property_list, extend_property_ranges)
4215 (verify_interval_modification):
4216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4217 (Fnext_single_char_property_change)
4218 (Fprevious_single_char_property_change):
4219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4220 (copy_text_properties):
4221 Check for integer overflow in index calculation.
4222 * undo.c (last_boundary_position, record_point, record_insert)
4223 (record_delete, record_marker_adjustment, record_change)
4224 (record_property_change):
4225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4226 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4228 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4229 (Fx_hide_tip, Fx_file_dialog):
4230 * w32menu.c (set_frame_menubar):
4231 Use ptrdiff_t, not int, for consistency with rest of code.
4232 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4233 (select_window, Fdelete_other_windows_internal)
4234 (window_scroll_pixel_based, window_scroll_line_based)
4235 (Frecenter, Fset_window_configuration):
4236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4237 (Fset_window_hscroll, run_window_configuration_change_hook)
4238 (set_window_buffer, temp_output_buffer_show, scroll_command)
4239 (Fscroll_other_window, Frecenter):
4240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4241 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4242 Don't assume fixnum fits in int.
4243 (Fset_window_scroll_bars):
4244 Check that fixnums are in proper range for system types.
4245 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4246 (string_pos, c_string_pos, number_of_chars, init_iterator)
4247 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4248 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4249 (compute_display_string_end, handle_face_prop)
4250 (face_before_or_after_it_pos, handle_invisible_prop)
4251 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4252 (display_prop_intangible_p, string_buffer_position_lim)
4253 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4254 (get_overlay_strings_1, get_overlay_strings)
4255 (iterate_out_of_display_property, forward_to_next_line_start)
4256 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4257 (get_next_display_element, set_iterator_to_next)
4258 (get_visually_first_element, compute_stop_pos_backwards)
4259 (handle_stop_backwards, next_element_from_buffer)
4260 (move_it_in_display_line_to, move_it_in_display_line)
4261 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4262 (add_to_log, message_dolog, message_log_check_duplicate)
4263 (message2, message2_nolog, message3, message3_nolog
4264 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4265 (current_message_1, truncate_echo_area, truncate_message_1)
4266 (set_message, set_message_1, store_mode_line_noprop)
4267 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4268 (text_outside_line_unchanged_p, check_point_in_composition)
4269 (reconsider_clip_changes)
4270 (redisplay_internal, set_cursor_from_row, try_scrolling)
4271 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4272 (redisplay_window, find_last_unchanged_at_beg_row)
4273 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4274 (trailing_whitespace_p, find_row_edges, display_line)
4275 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4276 (display_mode_element, store_mode_line_string)
4277 (pint2str, pint2hrstr, decode_mode_spec)
4278 (display_count_lines, display_string, draw_glyphs)
4279 (x_produce_glyphs, x_insert_glyphs)
4280 (rows_from_pos_range, mouse_face_from_buffer_pos)
4281 (fast_find_string_pos, mouse_face_from_string_pos)
4282 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4284 (safe_call, init_from_display_pos, handle_fontified_prop)
4285 (handle_single_display_spec, load_overlay_strings)
4286 (with_echo_area_buffer, setup_echo_area_for_printing)
4287 (display_echo_area, echo_area_display)
4288 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4289 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4290 (redisplay_window, dump_glyph_row, display_mode_line)
4291 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4292 (handle_display_spec, display_prop_string_p):
4293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4294 (handle_single_display_spec, build_desired_tool_bar_string)
4295 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4296 (get_specified_cursor_type):
4297 Check that fixnums are in proper range for system types.
4298 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4299 (Flookup_image_map):
4300 Don't assume fixnums fit in int.
4301 (compare_overlay_entries):
4302 Avoid mishandling comparisons due to subtraction overflow.
4303 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4304 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4305 (handle_tool_bar_click):
4306 Use int, not unsigned, since we prefer signed and the signedness
4307 doesn't matter here.
4308 (get_next_display_element, next_element_from_display_vector):
4309 Use int, not EMACS_INT, when int is wide enough.
4310 (start_hourglass): Use duration_to_sec_usec to do proper
4311 overflow checking on durations.
4312 * xfaces.c (Fbitmap_spec_p):
4313 Check that fixnums are in proper range for system types.
4314 (compare_fonts_by_sort_order):
4315 Avoid mishandling comparisons due to subtraction overflow.
4316 (Fx_family_fonts, realize_basic_faces):
4317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4319 Don't assume fixnum fits in int.
4320 Use SAFE_ALLOCA_LISP, not alloca.
4321 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4322 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4323 (face_at_buffer_position, face_for_overlay_string)
4324 (face_at_string_position):
4325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4326 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4327 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4329 Check that fixnums are in proper range for system types.
4330 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4331 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4333 (Fx_change_window_property): Don't assume fixnums fit in int.
4334 * xfont.c (xfont_chars_supported):
4335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4336 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4337 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4339 * xml.c (parse_region):
4340 * xrdb.c (magic_file_p):
4341 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4342 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4343 (x_get_local_selection, x_reply_selection_request)
4344 (x_handle_selection_request, wait_for_property_change):
4345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4346 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4347 short is wide enough.
4348 (x_send_client_event): Don't assume fixnum fits in int.
4349 * xterm.c (x_x_to_emacs_modifiers):
4350 Don't assume EMACS_INT overflows nicely into int.
4351 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4353 (handle_one_xevent): NATNUMP can eval its arg twice.
4354 (x_connection_closed):
4355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4356 * xterm.h: Adjust decls to match defn changes elsewhere.
4357 (struct scroll_bar): Use struct vectorlike_header
4358 rather than rolling our own approximation.
4359 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4361 2012-05-25 Glenn Morris <rgm@gnu.org>
4363 * lisp.mk (lisp): Update for more files being compiled now.
4365 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4367 * lread.c: Remove `read_pure' which makes no difference.
4368 (read_pure): Remove var.
4369 (unreadpure): Remove function.
4370 (readevalloop): Don't call read_list with -1 flag.
4371 (read1, read_vector): Don't test read_pure any more.
4372 (read_list): Simplify.
4374 * fileio.c, character.h: Minor style tweaks.
4376 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4378 * window.h (clip_changed): Remove useless declaration.
4380 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4382 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4383 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4385 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4388 This directory predates autoconf and is no longer needed nowadays.
4389 Move its few remaining bits of functionality to where they're needed.
4390 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4391 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4392 * m/template.h: Remove.
4393 * Makefile.in (M_FILE): Remove. All uses removed.
4394 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4395 * lisp.h (USE_LSB_TAG):
4396 * mem-limits.h (EXCEEDS_LISP_PTR):
4397 Use VAL_MAX, not VALBITS, in #if.
4398 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4399 (EMACS_UINT): Define unconditionally now.
4400 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4401 (BITS_PER_EMACS_INT): New constants, replacing
4402 what used to be in config.h, but not useful in #if.
4403 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4404 define them any more.
4405 (VAL_MAX): New macro.
4407 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4408 BITS_PER_EMACS_INT, in #if.
4409 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4410 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4411 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4412 * s/ms-w32.h (DATA_START):
4413 Move here from removed file m/intel386.h.
4414 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4415 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4417 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4419 Assume C89 or later.
4420 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4421 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4423 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4424 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4425 * textprop.c, tparam.c (NULL): Remove.
4426 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4427 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4428 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4429 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4430 * xterm.c (input_signal_count): Assume volatile works.
4432 2012-05-21 Ken Brown <kbrown@cornell.edu>
4434 * xgselect.c (xg_select): Fix first argument in call to 'select'
4437 2012-05-20 Ken Brown <kbrown@cornell.edu>
4439 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4440 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4442 2012-05-19 Ken Brown <kbrown@cornell.edu>
4444 * xfns.c (x_in_use): Remove `static' qualifier.
4445 * xterm.h (x_in_use): Declare.
4446 * xgselect.c: Include xterm.h.
4447 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4448 and `display_arg' (bug#9754).
4450 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4452 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4454 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4455 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4457 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4459 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4461 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4462 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4464 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4465 reference to image_cache->refcount.
4466 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4468 2012-05-17 Juri Linkov <juri@jurta.org>
4470 * search.c (Fword_search_regexp, Fword_search_backward)
4471 (Fword_search_forward, Fword_search_backward_lax)
4472 (Fword_search_forward_lax): Move functions to isearch.el
4473 (bug#10145, bug#11381).
4475 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4477 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4479 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4481 * lread.c (init_obarray): Declare Qt and Qnil as special.
4483 2012-05-14 Glenn Morris <rgm@gnu.org>
4485 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4486 Put "libexec" before "bin", for the sake of init_callproc_1.
4488 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4490 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4492 * unexaix.c: Port to more-recent AIX compilers.
4493 (report_error, report_error_1, make_hdr, copy_sym)
4494 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4495 Make arguments const char *, not char *, to avoid violations of C
4496 standard and to fix some AIX warnings reported by Gilles Pion.
4498 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4500 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4501 already have overlays loaded.
4502 (handle_single_display_spec): Before returning without displaying
4503 fringe bitmap, synchronize the bidi iterator with the main display
4504 iterator, by calling iterate_out_of_display_property.
4505 (iterate_out_of_display_property): Detect buffer iteration by
4506 testing that it->string is a Lisp string.
4507 (get_next_display_element): When the current object is exhausted,
4508 and there's something on it->stack, call set_iterator_to_next to
4509 proceed with what's on the stack, instead of returning zero.
4510 (set_iterator_to_next): If called at the end of a Lisp string,
4511 proceed to consider_string_end without incrementing string
4512 position. Don't increment display vector index past the end of
4513 the display vector. (Bug#11417)
4514 (pos_visible_p): Don't report a position visible when move_it_to
4515 stopped at the last line of window, which happens to be scanned
4516 backwards by the bidi iteration. (Bug#11464)
4518 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4520 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4521 and right-margin display specs even if the spec is invalid or we
4522 are on a TTY, and thus unable to display on the fringes.
4523 That's because the text with the property will not be displayed anyway,
4524 so we need to signal to the caller that this is a "replacing"
4525 display spec. This fixes display when the spec is invalid or we
4528 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4530 * unexaix.c (make_hdr): Fix typo in prototype.
4531 This bug broke the build on AIX. Problem reported by Gilles Pion.
4533 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4535 * keyboard.c (kbd_buffer_get_event): Read special events also in
4536 batch mode. (Bug#11415)
4538 2012-05-12 Glenn Morris <rgm@gnu.org>
4540 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4542 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4544 * lisp.mk (lisp): Add newcomment.elc.
4546 2012-05-12 Glenn Morris <rgm@gnu.org>
4548 * Makefile.in (MKDIR_P): New, set by configure.
4549 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4551 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4553 Remove unused function hourglass_started.
4554 * dispextern.h (hourglass_started):
4555 * w32fns.c (hourglass_started):
4556 * xdisp.c (hourglass_started): Remove.
4558 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4560 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4561 Update dependencies.
4563 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4565 * xgselect.c (xg_select): Put maxfds+1 into a var.
4566 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4568 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4570 2012-05-10 Dave Abrahams <dave@boostpro.com>
4572 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4573 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4575 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4577 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4578 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4579 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4580 Initialize xd_registered_buses.
4582 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4584 Untag more efficiently if USE_LSB_TAG.
4585 This is based on a proposal by YAMAMOTO Mitsuharu in
4586 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4587 For an admittedly artificial (nth 8000 longlist) benchmark on
4588 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4589 Emacs's overall text size by 1%.
4590 * lisp.h (XUNTAG): New macro.
4591 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4592 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4593 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4594 * eval.c (Fautoload):
4595 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4596 * frame.h (XFRAME): Use XUNTAG.
4598 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4599 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4600 Remove unportable assumptions about print widths of types like
4602 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4603 intptr_t when converting between pointer and integer, to avoid GCC
4604 warnings about wrong width.
4606 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4608 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4609 stack for each reader_thread, instead of defaulting to 8MB
4610 determined by the linker. This avoids failures in creating
4611 subprocesses on Windows 7, see the discussion in this thread:
4612 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4614 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4616 Fix up display of the *Minibuf-0* buffer in the mini window.
4617 * keyboard.c (read_char): Don't clear the echo area if there's no
4619 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4620 contents of *Minibuf-0*) if there's no message displayed in its stead.
4622 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4624 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4627 2012-05-06 Chong Yidong <cyd@gnu.org>
4629 * lisp.mk (lisp): Update.
4631 2012-05-05 Jim Meyering <meyering@redhat.com>
4633 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4635 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4637 * data.c (PUT_ERROR): New macro.
4638 (syms_of_data): Use it. Add new error type `user-error'.
4639 * undo.c (user_error): New function.
4640 (Fprimitive_undo): Use it.
4641 * print.c (print_error_message): Adjust print style for `user-error'.
4642 * keyboard.c (user_error): New function.
4643 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4645 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4647 Do not limit current-time-string to years 1000..9999.
4648 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4649 (Fcurrent_time_string): Support any year that is supported by the
4650 underlying localtime representation. Don't use asctime, as it
4651 has undefined behavior for years outside the range -999..9999.
4653 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4655 Fix race conditions involving setenv, gmtime, localtime, asctime.
4656 Without this fix, interrupts could mess up code that uses these
4657 nonreentrant functions, since setting TZ invalidates existing
4658 tm_zone or tzname values, and since most of these functions return
4659 pointers to static storage.
4660 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4661 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4662 Grow the critical sections to include not just invoking
4663 localtime/gmtime, but also accessing these functions' results
4664 including their tm_zone values if any, and any related TZ setting.
4665 (format_time_string): Last arg is now struct tm *, not struct tm **,
4666 so that the struct tm is saved in the critical section.
4667 All callers changed. Simplify allocation of initial buffer, partly
4668 motivated by the fact that memory allocation needs to be outside
4669 the critical section.
4671 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4673 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4674 with RESET_INTERVAL.
4676 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4677 Remove duplicated buffer name initialization.
4679 2012-05-02 Jim Meyering <jim@meyering.net>
4681 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4683 * xfns.c (x_window): Use xstrdup (Bug#11375).
4685 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4687 * xdisp.c (pos_visible_p): If already at a newline from the
4688 display string before the 'while' loop, don't walk back the glyphs
4689 from it3.glyph_row. Solves assertion violation when the display
4690 string begins with a newline (egg.el). (Bug#11367)
4692 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4694 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4697 2012-05-01 Glenn Morris <rgm@gnu.org>
4699 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4700 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4701 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4702 All were removed before 23.1.
4704 * dispnew.c: Remove HAVE_LIBNCURSES test;
4705 it is always true on relevant platforms.
4707 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4708 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4710 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4712 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4714 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4715 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4718 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4720 Do not avoid creating empty evaporating overlays (Bug#9642).
4721 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4722 That is, do not delete an evaporating overlay if it becomes
4723 empty after its bounds are adjusted to fit within its buffer.
4724 This fix caused other problems, and I'm reverting it until we get
4725 to the bottom of them.
4727 2012-04-27 Chong Yidong <cyd@gnu.org>
4729 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4731 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4733 * xdisp.c (pos_visible_p): If the window start position is beyond
4734 ZV, start the display from buffer beginning. Prevents assertion
4735 violation in init_iterator when the minibuffer window is scrolled
4738 * window.c (window_scroll_pixel_based): Likewise.
4740 2012-04-27 Chong Yidong <cyd@gnu.org>
4742 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4744 2012-04-27 Glenn Morris <rgm@gnu.org>
4746 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4747 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4749 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4751 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4752 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4754 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4756 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4757 display element, check also the underlying string or buffer
4758 character. (Bug#11341)
4760 * w32menu.c: Include w32heap.h.
4761 (add_menu_item): If the call to AppendMenuW (via
4762 unicode_append_menu) fails, disable Unicode menus only if we are
4763 running on Windows 9X/Me.
4765 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4767 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4768 (xgetint): Add missing shift for LSB tags.
4770 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4772 * keyboard.c (read_char): Don't wipe echo area for select window
4773 events: These might get delayed via `mouse-autoselect-window'
4776 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4778 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4779 manipulation of :loaded-from data.
4781 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4783 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4784 now a cons (bug#11311).
4786 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4788 Do not create empty overlays with the evaporate property (Bug#9642).
4789 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4790 if it becomes empty after its bounds are adjusted to fit within
4791 its buffer. Without this fix, in a nonempty buffer (let ((o
4792 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4793 yields an empty overlay that has the evaporate property, which is
4794 not supposed to happen.
4796 Fix minor GTK3 problems found by static checking.
4797 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4798 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4799 (struct _EmacsFixedClass, emacs_fixed_get_type):
4800 Move decls here from emacsgtkfixed.h, since they needn't be public.
4801 (emacs_fixed_get_type): Now static.
4802 (emacs_fixed_class_init): Omit unused local.
4803 (emacs_fixed_child_type): Remove; unused.
4804 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4805 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4806 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4807 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4808 (EMACS_FIXED_GET_CLASS): Remove; unused.
4809 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4811 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4812 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4814 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4816 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4817 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4818 (__malloc_size_t, __malloc_ptrdiff_t):
4819 Remove. All uses removed, replaced by the definiens if needed,
4820 since we can assume C89 or better now.
4821 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4822 (protect_malloc_state, align, get_contiguous_space)
4823 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4824 (malloc_atfork_handler_child, malloc_enable_thread)
4825 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4826 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4827 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4828 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4829 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4830 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4831 Define using prototypes, not old style.
4832 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4833 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4834 (align): Don't assume that signed integer overflow wraps around.
4835 Omit unused local var.
4836 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4837 (_free_internal_nolock, memalign, mallochook, reallochook):
4838 Omit no-longer-needed casts.
4839 (valloc): Use getpagesize, not __getpagesize.
4840 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4841 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4843 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4845 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4847 Move functions from C to Lisp. Make non-blocking method calls
4848 the default. Implement further D-Bus standard interfaces.
4850 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4851 (QCdbus_request_name_allow_replacement)
4852 (QCdbus_request_name_replace_existing)
4853 (QCdbus_request_name_do_not_queue)
4854 (QCdbus_request_name_reply_primary_owner)
4855 (QCdbus_request_name_reply_in_queue)
4856 (QCdbus_request_name_reply_exists)
4857 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4858 (QCdbus_registered_serial, QCdbus_registered_method)
4859 (QCdbus_registered_signal): New Lisp objects.
4860 (XD_DEBUG_MESSAGE): Use sizeof.
4861 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4862 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4863 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4864 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4865 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4866 (xd_signature, xd_append_arg): Allow float for integer types.
4867 (xd_get_connection_references): New function.
4868 (xd_get_connection_address): Rename from xd_initialize.
4869 Return cached address.
4870 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4871 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4873 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4874 Return number of refcounts.
4875 (Fdbus_get_unique_name): Make stronger parameter check.
4876 (Fdbus_message_internal): New defun.
4877 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4878 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4879 (Fdbus_send_signal, Fdbus_register_service)
4880 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4881 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4882 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4883 (Vdbus_compiled_version, Vdbus_runtime_version)
4884 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4885 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4886 (Vdbus_message_type_signal): New defvars.
4887 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4890 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4892 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4893 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4894 Do not assume ptrdiff_t is the same width as 'int'.
4896 * alloc.c: Handle unusual debugging option combinations.
4897 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4898 since the two debugging options are incompatible.
4899 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4901 (mem_init, mem_insert, mem_insert_fixup):
4902 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4903 (NEED_MEM_INSERT): Remove; no longer needed.
4905 2012-04-22 Leo Liu <sdl.web@gmail.com>
4907 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4909 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4911 * sysdep.c [__FreeBSD__]: Minor cleanups.
4912 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4913 Use Emacs indenting style more consistently. Avoid some casts.
4914 Use 'double' consistently rather than mixing 'float' and 'double'.
4916 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4918 * sysdep.c (list_system_processes, system_process_attributes):
4919 Add implementation for FreeBSD (Bug#5243).
4921 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4923 * lisp.mk (lisp): Update.
4925 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4927 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4928 It is never used otherwise.
4930 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4932 * print.c (print_preprocess): Only check print_depth if print-circle
4934 (print_object): Check for cycles even when print-circle is nil and
4935 print-gensym is t, but only check print_depth if print-circle is nil.
4937 2012-04-20 Chong Yidong <cyd@gnu.org>
4939 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4940 set the status to "failed" and ensure that sentinel is run.
4942 2012-04-20 Glenn Morris <rgm@gnu.org>
4944 * process.c (Fset_process_inherit_coding_system_flag)
4945 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4946 (Fmake_network_process, Fmake_serial_process): Doc fix.
4948 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4950 * xdisp.c (string_buffer_position_lim): Limit starting position to
4952 (set_cursor_from_row): If called for a mode-line or header-line
4953 row, return zero immediately.
4954 (try_cursor_movement): If inside continuation line, don't back up
4955 farther than the first row after the header line, if any.
4956 Don't consider the header-line row as "partially visible", even if
4957 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4959 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4961 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4964 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4965 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4967 configure: new option --enable-gcc-warnings (Bug#11207)
4968 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4969 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4970 (ALL_CFLAGS): Use new macros rather than old.
4971 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4972 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4973 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4974 -Wunused-result, -Wunused-variable. This should go away once
4975 the Emacs and Gnulib regex code is merged.
4976 (xmalloc, xrealloc): Now static.
4978 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4980 * dired.c (Fsystem_groups): Remove unused local.
4982 2012-04-17 Glenn Morris <rgm@gnu.org>
4984 * dired.c (Fsystem_users): Doc fix.
4986 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4988 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4989 (syms_of_dired): Add them.
4991 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4993 Fix minor alloc.c problems found by static checking.
4994 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4995 New extern decls, to avoid calling undeclared functions.
4996 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4997 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4998 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4999 (NEED_MEM_INSERT): New macro.
5000 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
5001 Remove one incorrect comment and fix another.
5003 Fix minor ralloc.c problems found by static checking.
5004 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5005 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5006 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5007 (r_alloc_sbrk): Now static.
5009 Improve ralloc.c interface checking.
5010 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5011 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5012 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5013 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5014 [REL_ALLOC]: ... to here, to check interface.
5015 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5016 Remove decls. This fixes an "It stinks!".
5018 * alloc.c (which_symbols): Fix alignment issue / type clash.
5020 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5022 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5023 (struct Lisp_Misc_Any): Likewise.
5024 (struct Lisp_Free): Likewise.
5025 * alloc.c (union aligned_Lisp_Symbol): Define.
5026 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5027 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5028 (union aligned_Lisp_Misc): Define.
5029 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5030 aligned_Lisp_Misc instead of union Lisp_Misc.
5031 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
5033 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5035 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5036 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5037 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5038 * s/netbsd.h, s/sol2-6.h:
5039 Remove definition of GC_MARK_STACK, since the default now works.
5040 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5041 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5042 no longer the default.
5043 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5045 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5047 * lread.c (lisp_file_lexically_bound_p):
5048 Fix hang at ";-*-\n" (bug#11238).
5050 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5052 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5053 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5055 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5057 * nsterm.m (constrainFrameRect): Always constrain when there is only
5058 one screen (Bug#10962).
5060 2012-04-13 Ken Brown <kbrown@cornell.edu>
5062 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5064 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5066 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5068 2012-04-11 Daniel Colascione <dancol@dancol.org>
5070 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5071 against is gone. It's better to use vfork now so that when Cygwin
5072 gains a new, working vfork, we use it automatically (bug#10398).
5074 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5076 * window.c (save_window_save): Obey window-point-insertion-type.
5078 2012-04-11 Glenn Morris <rgm@gnu.org>
5080 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5082 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5084 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5086 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5088 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5089 (force_quit_count): New var.
5090 (handle_interrupt): Use it.
5092 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5094 * w32.c (w32_delayed_load): Record the full path of the library
5095 being loaded (bug#10424).
5097 2012-04-09 Glenn Morris <rgm@gnu.org>
5099 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5100 not just in the obarray, before snarfing them. (Bug#11036)
5102 * Makefile.in ($(leimdir)/leim-list.el):
5103 Pass EMACS rather than BUILT_EMACS.
5105 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5107 * process.c (make_process):
5108 * process.h: Add integer `gnutls_handshakes_tried' member to
5111 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5112 Add convenience `GNUTLS_LOG2i' macro.
5114 * gnutls.c (gnutls_log_function2i): Convenience log function.
5115 (emacs_gnutls_read): Use new log functions,
5116 `gnutls_handshakes_tried' process member, and
5117 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5118 attempts per process (connection).
5120 2012-04-09 Chong Yidong <cyd@gnu.org>
5122 * eval.c (Fuser_variable_p, user_variable_p_eh)
5123 (lisp_indirect_variable): Functions deleted.
5124 (Fdefvar): Caller changed.
5126 * callint.c (Finteractive, Fcall_interactively):
5127 * minibuf.c (Fread_variable): Callers changed.
5129 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5131 * xdisp.c (set_cursor_from_row): If the display string appears in
5132 the buffer at position that is closer to point than the position
5133 after the display string, display the cursor on the first glyph of
5134 the display string. Fixes cursor display when a 'display' text
5135 property immediately follows invisible text. (Bug#11094)
5137 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5139 composite.c: use 'double' consistently
5140 * composite.c (get_composition_id): Use 'double' consistently
5141 instead of converting 'float' to 'double' and vice versa; this is
5142 easier to understand and avoids a GCC warning.
5144 2012-04-09 Glenn Morris <rgm@gnu.org>
5146 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5147 preparation for dumping it with emacs. (Bug#4789)
5148 (leimdir): New variable.
5149 ($(leimdir)/leim-list.el): New rule.
5150 (emacs$(EXEEXT)): Depend on leim-list.el.
5152 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5153 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5154 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5156 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5158 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5161 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5163 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5164 Remove unused local variable.
5166 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5168 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5169 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5170 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5171 objects, as mark_maybe_pointer will catch them otherwise.
5172 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5173 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5175 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5177 Fix typo that broke non-Windows builds.
5178 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5180 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5182 Support building on MS-Windows with libxml2.
5184 * makefile.w32-in (OBJ2): Add xml.$(O).
5185 (GLOBAL_SOURCES): Add xml.c.
5186 ($(BLD)/xml.$(O)): New dependency list.
5188 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5189 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5190 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5191 [!WINDOWSNT]: New macros.
5192 (init_libxml2_functions, libxml2_loaded_p): New functions.
5193 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5194 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5195 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5196 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5198 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5199 Call init_libxml2_functions before calling libxml2 functions.
5200 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5202 * emacs.c: Don't include libxml/parser.h.
5203 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5204 xmlCleanupParser directly.
5206 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5208 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5210 * indent.c (Fvertical_motion): If there is a display string at
5211 point, use it.vpos to compute how many lines to backtrack after
5212 move_it_to point. (Bug#11133)
5214 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5216 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5217 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5218 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5219 macros related to unification of CJK characters. For the details,
5220 see the discussion following the message here:
5221 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5223 2012-04-04 Chong Yidong <cyd@gnu.org>
5225 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5227 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5229 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5230 instead of alloca. (Bug#11138)
5232 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5234 * w32menu.c (is_simple_dialog): Properly check lisp types.
5237 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5239 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5240 position we get to after a call to move_it_to fails the
5241 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5242 only if we wind up in a string from display property. (Bug#11063)
5244 * window.c (Fdelete_other_windows_internal): Invalidate the row
5245 and column information about mouse highlight, so that redisplay
5246 restores it after reallocating the glyph matrices. (Bug#7464)
5248 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5249 string comes from a `display' text property, use the buffer
5250 position of that property as if we actually saw that position in
5252 (move_it_by_lines): Remove the assertion that
5253 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5254 violated when there's a before-string at the beginning of a line.
5257 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5259 * xdisp.c (append_space_for_newline): If the default face was
5260 remapped, use the remapped face for the appended newline.
5261 (extend_face_to_end_of_line): Use the remapped default face for
5262 extending the face to the end of the line.
5263 (display_line): Call extend_face_to_end_of_line when the default
5264 face was remapped. (Bug#11068)
5266 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5268 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5270 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5272 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5274 2012-03-27 Glenn Morris <rgm@gnu.org>
5276 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5279 2012-03-26 Kenichi Handa <handa@m17n.org>
5281 * dispextern.h (struct glyph): Fix previous change. Change the
5282 bit length of glyphless.ch to 25 (Bug#11082).
5284 2012-03-26 Chong Yidong <cyd@gnu.org>
5286 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5287 (command_loop_1): Use it; inhibit selection update for
5288 handle-select-window too (Bug#8996).
5290 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5292 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5294 2012-03-25 Kenichi Handa <handa@m17n.org>
5296 * dispextern.h (struct glyph): Change the bit length of
5297 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5299 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5301 * s/ms-w32.h (tzname): Include time.h before redirecting to
5302 _tzname. Fixes the MSVC build. (Bug#9960)
5304 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5306 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5309 * xterm.c (XTread_socket): Only modify handling_signal if
5310 !SYNC_INPUT. (Bug#11080)
5312 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5314 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5315 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5316 when fetching a multibyte character consumes more bytes than
5317 CHAR_BYTES returns, due to unification of CJK characters in
5318 string_char. (Bug#11073)
5320 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5322 * process.c (wait_reading_process_output): Handle pty disconnect
5323 by refraining from sending oneself a SIGCHLD (bug#10933).
5325 2012-03-22 Chong Yidong <cyd@gnu.org>
5327 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5329 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5330 Mark string as coming from a prefix property.
5331 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5332 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5334 2012-03-21 Chong Yidong <cyd@gnu.org>
5336 * xfaces.c (Vface_remapping_alist): Doc fix.
5338 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5340 * w32proc.c (Fw32_set_console_codepage)
5341 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5344 2012-03-20 Chong Yidong <cyd@gnu.org>
5346 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5347 to reflect default non-nil value of redisplay-dont-pause.
5349 2012-03-19 Kenichi Handa <handa@m17n.org>
5351 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5352 it fit in a valid range (Bug#11003).
5354 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5356 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5357 that is not from display property, accept the row as a "cursor
5358 row" if one of the string's character has a non-nil `cursor'
5359 property. Fixes cursor positioning when there are newlines in
5360 overlay strings, e.g. in icomplete.el. (Bug#11035)
5362 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5364 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5366 2012-03-12 Chong Yidong <cyd@gnu.org>
5368 * eval.c (inhibit_lisp_code): Rename from
5369 inhibit_window_configuration_change_hook; move from window.c.
5371 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5372 * window.c (run_window_configuration_change_hook)
5373 (syms_of_window): Callers changed.
5375 2012-03-11 Chong Yidong <cyd@gnu.org>
5377 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5379 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5381 2012-03-10 Chong Yidong <cyd@gnu.org>
5383 * frame.c (other_visible_frames): Don't assume the selected frame
5384 is visible (Bug#10955).
5386 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5388 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5390 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5392 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5393 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5396 2012-03-03 Glenn Morris <rgm@gnu.org>
5398 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5400 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5402 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5403 position past the first glyph_row that ends at ZV. (Bug#10902)
5404 (redisplay_window, next_element_from_string): Fix typos in
5406 (redisplay_window): Pass to move_it_vertically the margin in
5407 pixels, not in screen lines.
5409 2012-03-02 Glenn Morris <rgm@gnu.org>
5411 * buffer.c (buffer-list-update-hook): Doc fix.
5413 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5415 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5416 push_it before setting up the iterator for the first overlay
5417 string, even if we have an empty string loaded.
5418 (next_overlay_string): If there's an empty string on the iterator
5419 stack, pop the stack. (Bug#10903)
5421 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5423 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5424 Suggested by Stefan Monnier in
5425 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5426 * alloc.c (widen_to_Lisp_Object): New static function.
5427 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5428 and widening them to Lisp_Objects. This would work even if
5429 USE_LSB_TAG is defined and wide integers are used, which might
5430 happen in a future version of Emacs.
5432 2012-02-25 Chong Yidong <cyd@gnu.org>
5434 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5437 * xselect.c (Fx_selection_exists_p): Doc fix.
5438 (x_clipboard_manager_save_all): Print an informative message
5439 before saving to clipboard manager.
5441 2012-02-24 Chong Yidong <cyd@gnu.org>
5443 * keyboard.c (process_special_events): Handle all X selection
5444 requests in kbd_buffer, not just the next one (Bug#8869).
5446 2012-02-23 Chong Yidong <cyd@gnu.org>
5448 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5449 call when setting menu-bar-lines and tool-bar-lines parameters.
5450 (unwind_create_frame_1): New helper function.
5452 * window.c (inhibit_window_configuration_change_hook): New var.
5453 (run_window_configuration_change_hook): Obey it.
5454 (syms_of_window): Initialize it.
5456 2012-02-22 Chong Yidong <cyd@gnu.org>
5458 * xterm.c (x_draw_image_relief): Add missing type check for
5459 Vtool_bar_button_margin (Bug#10743).
5461 2012-02-21 Chong Yidong <cyd@gnu.org>
5463 * fileio.c (Vfile_name_handler_alist): Doc fix.
5465 * buffer.c (Fget_file_buffer): Protect against invalid file
5466 handler return value.
5468 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5470 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5471 when computing $valmask.
5473 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5474 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5475 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5476 It's useless in that case, and it can cause problems on hosts
5477 that allocate halves of EMACS_INT values separately.
5478 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5479 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5480 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5481 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5482 it avoids undefined behavior on hosts where shifting right by more
5483 than the word width has undefined behavior.
5485 2012-02-19 Chong Yidong <cyd@gnu.org>
5487 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5488 (Funhandled_file_name_directory, Ffile_name_as_directory)
5489 (Fdirectory_file_name, Fexpand_file_name)
5490 (Fsubstitute_in_file_name): Protect against invalid file handler
5491 return values (Bug#10845).
5493 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5495 * .gdbinit (pitx): Fix incorrect references to fields of the
5498 2012-02-17 Chong Yidong <cyd@gnu.org>
5500 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5502 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5504 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5505 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5507 2012-02-15 Chong Yidong <cyd@gnu.org>
5509 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5510 marked as special. Also, starting docstrings with * is obsolete.
5512 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5514 * gnutls.c (emacs_gnutls_write): Fix last change.
5516 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5518 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5521 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5523 * keymap.c (Fsingle_key_description): Handle char ranges.
5525 2012-02-12 Chong Yidong <cyd@gnu.org>
5527 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5528 as that creates a dangerous corner case.
5530 * window.c (Fdelete_window_internal): Invalidate the mouse
5531 highlight (Bug#9904).
5533 2012-02-12 Glenn Morris <rgm@gnu.org>
5535 * xselect.c (Fx_own_selection_internal)
5536 (Fx_get_selection_internal, Fx_disown_selection_internal)
5537 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5538 * nsselect.m (Fx_own_selection_internal)
5539 (Fx_disown_selection_internal, Fx_selection_exists_p)
5540 (Fx_selection_owner_p, Fx_get_selection_internal):
5541 Sync docs and argument specs with the xselect.c versions.
5543 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5545 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5547 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5549 * w32select.c (Fx_selection_exists_p): Sync doc string and
5550 argument list with xselect.c. (Bug#10783)
5552 * w16select.c (Fx_selection_exists_p): Sync doc string and
5553 argument list with xselect.c. (Bug#10783)
5555 2012-02-10 Glenn Morris <rgm@gnu.org>
5557 * fns.c (Fsecure_hash): Doc fix.
5559 2012-02-09 Kenichi Handa <handa@m17n.org>
5561 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5563 2012-02-07 Chong Yidong <cyd@gnu.org>
5565 * buffer.c (Fbuffer_local_variables)
5566 (buffer_lisp_local_variables): Handle unbound vars correctly;
5567 don't let Qunbound leak into Lisp.
5569 2012-02-07 Glenn Morris <rgm@gnu.org>
5571 * image.c (Fimagemagick_types): Doc fix.
5573 * image.c (imagemagick-render-type): Change it from a lisp object
5574 to an integer. Move the doc here from the lisp manual.
5575 Treat all values not equal to 0 the same.
5577 2012-02-06 Chong Yidong <cyd@gnu.org>
5579 * doc.c (store_function_docstring): Avoid applying docstring of
5580 alias to base function (Bug#2603).
5582 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5584 * .gdbinit (pp1, pv1): Remove redundant defines.
5587 2012-02-04 Chong Yidong <cyd@gnu.org>
5589 * nsterm.m: Declare a global (Bug#10694).
5591 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5593 * w32.c (get_emacs_configuration_options):
5594 Include --enable-checking, if specified, in the return value.
5596 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5598 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5599 after rounding frame sizes. (Bug#9723)
5601 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5603 * keyboard.c (adjust_point_for_property): Don't position point
5604 before BEGV. (Bug#10696)
5606 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5608 Handle overflow when computing char display width (Bug#9496).
5609 * character.c (char_width): Return EMACS_INT, not int.
5610 (char_width, c_string_width): Check for overflow when
5611 computing the width; this is possible now that individual
5612 characters can have unbounded width. Problem introduced
5613 by merge from Emacs 23 on 2012-01-19.
5615 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5617 * dbusbind.c (Fdbus_register_method): Mention the return value
5618 :ignore in the docstring.
5620 2012-02-02 Glenn Morris <rgm@gnu.org>
5622 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5624 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5625 Unconditionally set to t. (Bug#10673)
5626 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5627 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5628 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5630 2012-02-02 Kenichi Handa <handa@m17n.org>
5632 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5633 0, do not call append_composite_glyph.
5635 2012-02-02 Kenichi Handa <handa@m17n.org>
5637 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5639 (x_produce_glyphs): If the component of a composition is a null
5640 string, set it->pixel_width to 1 to avoid zero-width glyph.
5642 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5644 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5645 first 2 arguments are identical. This makes inserting large
5646 output from a subprocess an order of magnitude faster on
5647 MS-Windows, where all sbrk'ed memory is always contiguous.
5649 2012-01-31 Glenn Morris <rgm@gnu.org>
5651 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5652 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5653 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5655 2012-01-29 Glenn Morris <rgm@gnu.org>
5657 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5659 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5661 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5663 2012-01-28 Chong Yidong <cyd@gnu.org>
5665 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5667 2012-01-26 Chong Yidong <cyd@gnu.org>
5669 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5671 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5672 repeat counts (Bug#10507).
5674 2012-01-26 Glenn Morris <rgm@gnu.org>
5676 * lread.c (syms_of_lread): Doc fix.
5678 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5680 * coding.c (encode_designation_at_bol): Change return value to
5683 2012-01-25 Chong Yidong <cyd@gnu.org>
5685 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5687 2012-01-21 Chong Yidong <cyd@gnu.org>
5689 * floatfns.c (Fcopysign): Make the second argument non-optional,
5690 since nil is not allowed anyway.
5692 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5694 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5695 (send_process): Likewise.
5697 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5699 * window.c (save_window_save, Fcurrent_window_configuration)
5700 (Vwindow_persistent_parameters): Do not use Qstate.
5701 Rewrite doc-strings.
5703 2012-01-19 Kenichi Handa <handa@m17n.org>
5705 * character.c (char_width): New function.
5706 (Fchar_width, c_string_width, lisp_string_width):
5707 Use char_width (Bug#9496).
5709 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5711 * window.c (Vwindow_persistent_parameters): New variable.
5712 (Fset_window_configuration, save_window_save): Handle persistent
5715 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5717 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5718 thrashing the stack of the thread. (Bug#9087)
5720 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5722 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5724 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5726 * xdisp.c (rows_from_pos_range): Handle the case where the
5727 highlight ends on a newline. (Bug#10464)
5728 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5729 he end column for display of highlight that ends on a newline
5732 2012-01-11 Glenn Morris <rgm@gnu.org>
5734 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5735 from load-path also when installation-directory is nil. (Bug#10208)
5737 2012-01-10 Glenn Morris <rgm@gnu.org>
5739 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5741 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5742 Update template values to be closer to their typical values these days.
5744 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5746 * xdisp.c (rows_from_pos_range): Accept additional argument
5747 DISP_STRING, and accept any glyph in a row whose object is that
5748 string as eligible for mouse highlight. Fixes mouse highlight of
5749 display strings from overlays. (Bug#10464)
5751 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5753 emacs: fix an auto-save permissions race condition (Bug#10400)
5754 * fileio.c (auto_saving_dir_umask): New static var.
5755 (Fmake_directory_internal): Use it.
5756 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5757 creating the directory. The old code temporarily assigns
5758 too-generous permissions to the directory.
5759 (do_auto_save_eh): Clear it.
5760 (Fdo_auto_save): Catch all errors, not just file errors, so
5761 that the var is always cleared.
5763 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5765 * search.c (scan_buffer): Pass character positions to
5766 know_region_cache, not byte positions. (Bug#6540)
5768 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5770 * w32.c (sys_rename): Report EXDEV when rename of a directory
5771 fails because the target is on another logical disk. (Bug#10284)
5773 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5775 * xterm.c (x_embed_request_focus): New function.
5777 * xterm.h: Add prototype.
5779 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5781 2012-01-05 Glenn Morris <rgm@gnu.org>
5783 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5785 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5787 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5788 Load gnutls_transport_set_lowat only if GnuTLS version is below
5790 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5791 GnuTLS versions below 2.11.1.
5793 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5795 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5796 to the doc string advising against its use for altering the way
5797 windows are scrolled.
5799 2011-12-28 Kenichi Handa <handa@m17n.org>
5801 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5802 coding-system ASCII compatible only when it does not produce BOM
5803 on encoding (Bug#10383).
5805 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5807 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5809 (create_and_show_popup_menu): Always use menu_position_func for
5812 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5814 * callint.c (Fcall_interactively): Don't truncate prompt string.
5816 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5818 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5819 property that ends at ZV, so that the bidi iteration could be
5820 resumed from there (after widening). (Bug#10360)
5822 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5824 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5826 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5828 * nsterm.m (x_free_frame_resources):
5829 Release f->output_data.ns->miniimage.
5830 (ns_index_color): Fix indentation. Do not retain
5831 color_table->colors[i].
5833 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5836 * nsfns.m (x_set_background_color): Assign return value from
5837 ns_index_color to face-background instead of NSColor*.
5838 (ns_implicitly_set_icon_type): Fix indentation.
5839 Change assignment in for loop to comparison.
5841 * emacs.c (ns_pool): New variable.
5842 (main): Assign ns_pool.
5843 (Fkill_emacs): Call ns_release_autorelease_pool.
5845 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5846 autorelease fdesc, release fdAttrs and tdict.
5847 (ns_get_covering_families): Release charset.
5848 (ns_findfonts): Release NSFontDescriptor created with new.
5849 (ns_uni_to_glyphs): Fix indentation.
5850 (setString): Release attrStr before assigning new value.
5852 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5854 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5856 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5857 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5859 2011-12-18 David Reitter <reitter@cmu.edu>
5861 * nsterm.m (ns_term_init): Subscribe for notifications
5862 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5863 to method trackingNotification in EmacsMenu.
5865 * nsmenu.m (trackingMenu): New variable.
5866 (trackingNotification): New method (from Aquamacs).
5867 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5868 from Aquamacs (Bug#7030).
5870 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5872 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5873 (symbol_to_nsstring): Fix indentation.
5874 (ns_symbol_to_pb): New function.
5875 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5876 (Fns_rotate_cut_buffers_internal): Remove.
5877 (Fns_store_selection_internal): Rename from
5878 Fns_store_cut_buffer_internal.
5879 (ns_get_foreign_selection, Fx_own_selection_internal)
5880 (Fx_disown_selection_internal, Fx_selection_exists_p)
5881 (Fns_get_selection_internal, Fns_store_selection_internal):
5882 Use ns_symbol_to_pb and check if return value is nil.
5883 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5884 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5885 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5886 renamed to Sns_store_selection_internal.
5887 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5888 and remove this function.
5889 (ns_handle_selection_clear): Remove, never used.
5890 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5893 2011-12-17 Ken Brown <kbrown@cornell.edu>
5895 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5896 GID is unknown (Bug#10257).
5898 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5900 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5901 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5902 which caused a build failure on GNU/Linux IA-64. This problem was
5903 introduced by my 2011-10-07 patch.
5905 2011-12-15 Juri Linkov <juri@jurta.org>
5907 * image.c (imagemagick_error): New function. (Bug#10112)
5908 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5909 Use `imagemagick_error' where ImageMagick functions return
5911 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5914 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5916 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5917 fill background (Bug#8992).
5919 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5921 * window.c (Vwindow_combination_resize)
5922 (Vwindow_combination_limit): Use t instead of non-nil in
5924 (Vrecenter_redisplay): Add first sentence of doc-string on
5926 (Frecenter): Fix doc-string typo.
5928 2011-12-11 Kenichi Handa <handa@m17n.org>
5930 * coding.c (Funencodable_char_position): Pay attention to the
5931 buffer text relocation (Bug#9389).
5933 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5935 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5936 gtk_init (Bug#10100).
5938 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5940 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5941 IT->string is nil. (Bug#10263)
5943 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5945 * nsterm.h (x_free_frame_resources): Declare.
5947 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5948 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5950 * nsterm.h (ns_get_defaults_value): Declare.
5952 * nsterm.m (ns_default): Call ns_get_defaults_value.
5954 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5956 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5959 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5961 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5962 that where the value of an _OBJC_* symbol points to is in the .bss
5963 section (Bug#10240).
5965 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5967 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5968 after the loop to call ccl_driver at least once (Bug#8619).
5970 2011-12-08 Kenichi Handa <handa@m17n.org>
5972 * ftfont.c (get_adstyle_property): Fix previous change
5975 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5977 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5978 dirs from the default value of EMACSLOADPATH (bug#10208).
5980 2011-12-07 Glenn Morris <rgm@gnu.org>
5982 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5983 installation and source directories as well. (Bug#10208)
5985 2011-12-06 Chong Yidong <cyd@gnu.org>
5987 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5989 2011-12-06 Glenn Morris <rgm@gnu.org>
5991 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5992 as an error, not just -1. (Bug#10217)
5994 2011-12-05 Chong Yidong <cyd@gnu.org>
5996 * keyboard.c (process_special_events): New function.
5997 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5999 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6001 * coding.c (encode_designation_at_bol): Don't use uninitialized
6002 local variable (Bug#9318).
6004 2011-12-05 Kenichi Handa <handa@m17n.org>
6006 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6007 return Qnil (Bug#8046, Bug#10193).
6009 2011-12-05 Kenichi Handa <handa@m17n.org>
6011 * coding.c (encode_designation_at_bol): New args charbuf_end and
6012 dst. Return the number of produced bytes. Callers changed.
6013 (coding_set_source): Return how many bytes coding->source was
6015 (coding_set_destination): Return how many bytes
6016 coding->destination was relocated.
6017 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
6018 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
6020 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6022 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6023 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6026 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6028 The following changes are to fix Bug#9318.
6030 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
6031 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6032 (encode_coding_iso_2022, encode_coding_sjis)
6033 (encode_coding_big5, encode_coding_charset): Use the above macros.
6035 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
6037 * lisp.h (process_quit_flag): Fix external declaration.
6039 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6041 Don't macro-inline non-performance-critical code.
6042 * eval.c (process_quit_flag): New function.
6043 * lisp.h (QUIT): Use it.
6045 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6047 * nsfns.m (get_geometry_from_preferences): New function.
6048 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6050 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6052 * emacs.c (Qkill_emacs): Define.
6053 (syms_of_emacs): Initialize it.
6054 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6055 Qquit_flag to `kill-emacs' instead.
6056 (quit_throw_to_read_char): Add parameter `from_signal'.
6057 All callers changed. Call Fkill_emacs if requested and safe.
6058 * lisp.h (QUIT): Call Fkill_emacs if requested.
6060 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6062 * widget.c (update_wm_hints): Return if wmshell is null.
6063 (widget_update_wm_size_hints): New function.
6065 * widget.h (widget_update_wm_size_hints): Declare.
6067 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6068 widget_update_wm_size_hints (Bug#10104).
6070 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6072 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6073 before a newline, prepare the bidi iterator for consuming the
6074 newline, and keep the current paragraph direction. (Bug#10183)
6075 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6077 2011-12-02 Juri Linkov <juri@jurta.org>
6079 * search.c (Fword_search_regexp): New Lisp function created from
6080 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6081 (Fword_search_backward, Fword_search_forward)
6082 (Fword_search_backward_lax, Fword_search_forward_lax):
6083 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6084 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6086 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6088 * fileio.c (Finsert_file_contents): Move after-change-function call
6089 to before the "handled:" label, since all "goto handled" appear in
6090 cases where the *-change-functions have already been properly called
6093 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6095 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6096 waiting for input. (Bug#10169)
6098 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6100 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6101 verifies glyph row's hash code--we have just reallocated the
6102 glyphs, so their contents can be complete garbage. (Bug#10164)
6104 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6106 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6108 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6110 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6111 attributes are tested _before_ calling verify_row_hash, to protect
6112 against GCC re-ordering of the tests. (Bug#10164)
6114 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6116 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6118 * xterm.c (handle_one_xevent): Only set async_visible and friends
6119 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6120 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6121 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6123 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6125 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6126 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6127 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6128 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6129 All uses changed to use GCPRO1 etc.
6130 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6131 Revert to old implementation (i.e., before 2011-03-11).
6133 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6135 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6136 of scroll runs so as to avoid assigning disabled bogus rows and
6137 unnecessary graphics copy operations.
6139 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6141 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6142 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6143 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6144 (malloc, free, realloc, calloc): Redirect to e_* only when
6147 * lisp.h (GCTYPEBITS): Move before first use.
6148 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6149 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6150 this macro definition.
6152 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6155 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6157 * gtkutil.c (xg_create_frame_widgets):
6158 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6159 present with Gtk+ 2.0.
6161 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6163 * fileio.c (Finsert_file_contents): Undo previous change; see
6164 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6166 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6168 Rename locals to avoid shadowing.
6169 * fileio.c (Finsert_file_contents):
6170 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6171 * process.c (wait_reading_process_output):
6172 Rename inner 'proc' to 'p' to avoid shadowing.
6173 Indent for consistency with usual Emacs style.
6175 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6177 * xdisp.c (redisplay_window): If cursor row is not fully visible
6178 after recentering, and scroll-conservatively is set to a large
6179 number, scroll window by a few more lines to make the cursor fully
6180 visible and out of scroll-margin. (Bug#10105)
6181 (start_display): Don't move to the next line if the display should
6182 start at a newline that is part of a display vector or an overlay
6185 2011-11-24 Juri Linkov <juri@jurta.org>
6187 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6188 after the `MagickPingImage' call. (Bug#10112)
6190 2011-11-23 Chong Yidong <cyd@gnu.org>
6192 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6194 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6196 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6197 making another buffer current. (Bug#10114)
6199 2011-11-23 Glenn Morris <rgm@gnu.org>
6201 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6203 2011-11-23 Chong Yidong <cyd@gnu.org>
6205 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6206 using it (Bug#5984).
6208 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6210 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6211 and header-lines, as they don't have one computed for them.
6214 * .gdbinit (prow): Make displayed values more self-explaining.
6215 Add row's hash code.
6217 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6219 * process.c (wait_reading_process_output): Fix asynchrounous
6220 GnuTLS socket handling on some versions of the GnuTLS library.
6221 (wait_reading_process_output): Add comment and URL.
6223 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6225 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6227 2011-11-21 Chong Yidong <cyd@gnu.org>
6229 * window.c (Fnext_window, Fprevious_window): Doc fix.
6231 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6233 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6235 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6237 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6239 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6241 * window.c (Fset_window_combination_limit): Rename argument
6243 (Vwindow_combination_limit): Remove "status" from doc-string.
6245 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6247 * m/ibms390.h: Remove.
6248 * m/ibms390x.h: Don't include "ibms390.h".
6250 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6252 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6253 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6255 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6257 * casetab.c (Fset_case_table):
6258 * charset.c (Fcharset_after): Fix typos.
6260 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6262 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6263 Otherwise, valgrind does not work on some platforms.
6264 Problem reported by Andreas Schwab in
6265 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6266 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6267 is set, removing the need for VIRT_ADDRESS_VARIES.
6268 (PURE_P): Use a more-efficient implementation that needs just one
6269 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6270 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6271 to 4 (xorl, subq, cmpq, setbe).
6272 * alloc.c (pure): Always extern now, since that's the
6273 VIRT_ADDR_VARIES behavior.
6274 (PURE_POINTER_P): Use a single comparison, not two, for
6275 consistency with the new puresize.h.
6276 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6277 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6278 Remove VIRT_ADDR_VARIES no longer needed.
6280 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6282 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6283 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6284 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6285 behave as if the cursor position were at the window margin.
6287 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6288 and the cursor position is out of bounds, behave as if the cursor
6289 position were at the window margin. (Bug#10075)
6291 2011-11-18 Chong Yidong <cyd@gnu.org>
6293 * window.c (Fwindow_combination_limit): Make first argument
6294 non-optional, since it is meaningless for live windows like the
6297 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6299 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6301 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6303 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6304 (graft_intervals_into_buffer): Simplify.
6306 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6308 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6309 hash values of the two rows.
6310 (copy_row_except_pointers): Preserve the used[] arrays and the
6311 hash values of the two rows. (Bug#10035)
6312 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6314 * xdisp.c (row_hash): New function, body extracted from
6315 compute_line_metrics.
6316 (compute_line_metrics): Call row_hash, instead of computing the
6319 * dispnew.c (verify_row_hash): Call row_hash for computing the
6320 hash code of a row, instead of duplicating code from xdisp.c.
6322 * dispextern.h (row_hash): Add prototype.
6324 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6326 * frame.c (delete_frame): Don't delete the terminal when the last
6327 X frame is closed if emacs is built with GTK toolkit.
6329 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6331 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6333 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6335 * window.c (Vwindow_splits): Rename to
6336 Vwindow_combination_resize. Suggested by Juri Linkov.
6337 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6340 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6342 * nsfns.m (Fns_font_name):
6343 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6345 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6347 * window.h (window): Rename slot "nest" to "combination_limit".
6348 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6349 (Fset_window_nest): Rename to Fset_window_combination_limit.
6350 (Vwindow_nest): Rename to Vwindow_combination_limit.
6351 (recombine_windows, make_parent_window, make_window)
6352 (Fsplit_window_internal, saved_window)
6353 (Fset_window_configuration, save_window_save): Rename all
6354 occurrences of window_nest to window_combination_limit.
6356 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6358 * image.c (imagemagick_load_image): Fix typo.
6360 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6362 * xdisp.c (display_line): Move the call to
6363 highlight_trailing_whitespace before the call to
6364 compute_line_metrics, since the latter needs to see the final
6365 faces of all the glyphs to compute ROW's hash value.
6366 Fixes assertion violations in row_equal_p. (Bug#10035)
6368 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6370 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6371 just return (bug#10044).
6373 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6375 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6376 with user-defined heap size. Bump the default size of the temacs
6377 heap to 27MB, to avoid memory warning when running temacs.
6378 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6380 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6381 current_matrix and desired_matrix. (Bug#9990)
6382 (verify_row_hash) [XASSERTS]: New function.
6383 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6384 that the hash value of glyph rows is correct.
6386 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6388 * window.h (window): Remove splits slot.
6389 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6390 (Fdelete_other_windows_internal, make_parent_window)
6391 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6392 (Fset_window_configuration, save_window_save): Don't deal with
6393 split status of windows.
6394 (saved_window): Remove splits slot.
6395 (Vwindow_splits): Rewrite doc-string.
6397 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6399 * xfns.c (unwind_create_frame):
6400 * nsfns.m (unwind_create_frame):
6401 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6402 Vframe_list (Bug#9999).
6404 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6406 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6408 2011-11-11 Kenichi Handa <handa@m17n.org>
6410 * callproc.c (Fcall_process): Set the member dst_multibyte of
6413 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6415 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6416 avoid a crash (bug#9496).
6418 2011-11-09 Chong Yidong <cyd@gnu.org>
6420 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6421 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6423 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6425 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6427 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6429 Avoid some portability problems by eschewing 'extern inline' functions.
6430 The trivial performance wins aren't worth the portability hassles; see
6431 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6433 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6434 (window_box_width, window_box_left, window_box_left_offset)
6435 (window_box_right, window_box_right_offset): Undo previous change,
6436 by removing the "extern"s.
6437 * intervals.c (adjust_intervals_for_insertion)
6438 (adjust_intervals_for_deletion): Undo previous change,
6439 making these static again.
6440 (offset_intervals, temp_set_point_both, temp_set_point)
6441 (copy_intervals_to_string): No longer inline.
6442 * xdisp.c (window_text_bottom_y, window_box_width)
6443 (window_box_height, window_box_left_offset)
6444 (window_box_right_offset, window_box_left, window_box_right)
6445 (window_box): No longer inline.
6447 2011-11-08 Chong Yidong <cyd@gnu.org>
6449 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6450 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6451 Signal an error if not a live window.
6452 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6453 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6455 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6457 * lisp.h (syms_of_abbrev): Remove declaration.
6458 Reported by CHENG Gao <chenggao@royau.me>.
6460 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6462 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6463 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6464 of temacs in GUI mode.
6466 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6468 * window.h: Declare delete_all_child_windows instead of
6469 delete_all_subwindows.
6470 * window.c (Fwindow_nest, Fset_window_nest)
6471 (Fset_window_new_total, Fset_window_new_normal)
6472 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6473 (delete_all_subwindows): Rename to delete_all_child_windows.
6474 (Fdelete_other_windows_internal, Fset_window_configuration):
6475 Call delete_all_child_windows instead of delete_all_subwindows.
6476 * frame.c (delete_frame): Call delete_all_child_windows instead
6477 of delete_all_subwindows.
6479 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6481 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6482 This is also needed for porting to any host where GC_MARK_STACK is
6483 not GC_MAKE_GCPROS_NOOPS.
6484 (which_symbols): Use it.
6486 2011-11-07 Kenichi Handa <handa@m17n.org>
6488 * coding.c (coding_set_destination): Check coding->src_pos only
6489 when coding->src_object is a buffer (bug#9910).
6491 * process.c (send_process): Set the member src_multibyte of coding
6492 to 0 (bug#9911) when sending a unibyte text.
6494 * callproc.c (Fcall_process): Set the member src_multibyte of
6495 process_coding to 0 (bug#9912).
6497 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6499 * xmenu.c (cleanup_widget_value_tree): New function.
6500 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6501 calling free_menubar_widget_value_tree directly (Bug#9830).
6503 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6505 Fix some portability problems with 'inline'.
6506 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6507 (window_box_width, window_box_left, window_box_left_offset)
6508 (window_box_right, window_box_right_offset): Declare extern.
6509 Otherwise, these inline functions do not conform to C99 and
6510 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6511 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6512 * intervals.c (adjust_intervals_for_insertion)
6513 (adjust_intervals_for_deletion): Now extern, because otherwise the
6514 extern inline functions 'offset_intervals' couldn't refer to it.
6515 (static_offset_intervals): Remove.
6516 (offset_intervals): Rewrite using the old contents of
6517 static_offset_intervals. The old version didn't conform to C99
6518 because an extern inline function contained a reference to an
6519 identifier with static linkage.
6521 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6523 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6526 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6528 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6529 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6530 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6531 return Qleft_to_right.
6533 2011-11-06 Chong Yidong <cyd@gnu.org>
6535 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6536 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6537 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6538 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6539 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6540 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6541 (Fwindow_vscroll): Doc fix.
6542 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6543 argument, since it makes no sense to pass a live window and for
6544 consistency with window-child.
6546 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6548 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6551 2011-11-05 Jason Rumney <jasonr@gnu.org>
6553 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6554 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6556 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6557 bitwise arithmetic preventing use of unicode-sip and non-truetype
6560 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6562 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6565 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6566 initialization code to keep similarity to xfns.c after changes
6569 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6571 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6572 (unwind_create_frame): New function (Bug#9943).
6573 (Fx_create_frame): Restructure code to be more similar to the one in
6574 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6575 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6576 Move terminal->reference_count++ just before making the frame official
6579 * nsterm.m (x_free_frame_resources): New function.
6580 (x_destroy_window): Move code to x_free_frame_resources.
6582 * xfns.c (unwind_create_frame): Fix comment.
6583 (Fx_create_frame, x_create_tip_frame):
6584 Move terminal->reference_count++ just before making the frame
6585 official. Move initialization of image_cache_refcount and
6586 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6588 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6590 Support MSVC build with newer versions of Visual Studio.
6591 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6592 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6595 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6596 which are not supported by MSVC.
6597 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6598 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6600 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6602 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6604 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6606 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6608 Support MSVC build with newer versions of Visual Studio.
6609 * w32.c: Don't include w32api.h for MSVC.
6610 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6612 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6613 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6614 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6615 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6617 (alloca) [_MSC_VER]: Define to _alloca.
6619 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6621 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6623 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6625 * xdisp.c (note_mouse_highlight): If either of
6626 previous/next-single-property-change returns nil, treat that as
6627 the beginning or the end of the buffer. (Bug#9955)
6629 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6631 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6632 label is not null (Bug#9951).
6633 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6636 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6638 * window.c (Fwindow_body_size): Mention in the doc string that the
6639 return value is in frame's canonical units. (Bug#9949)
6641 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6643 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6645 * w32fns.c (unwind_create_frame): If needed, free the glyph
6646 matrices of the partially constructed frame. (Bug#9943)
6647 * xfns.c (unwind_create_frame): Likewise.
6649 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6651 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6652 Don't stop backward scan on the continuation glyph, even though
6653 its CHARPOS is positive.
6654 (mouse_face_from_buffer_pos, note_mouse_highlight):
6655 Rename cover_string to disp_string.
6657 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6659 * window.c (temp_output_buffer_show): Don't use
6660 Vtemp_buffer_show_specifiers.
6661 (Vtemp_buffer_show_specifiers): Remove unused variable.
6663 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6665 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6666 past the beginning of the current glyph matrix.
6668 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6670 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6671 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6672 HAVE_GTK3 (Bug#9869).
6674 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6675 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6677 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6679 * xterm.c: Declare x_handle_net_wm_state to return int.
6680 (handle_one_xevent): Check if we are iconified but don't have
6681 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6682 (get_current_wm_state): Return non-zero if not hidden,
6683 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6684 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6685 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6686 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6688 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6690 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6691 so that this new function doesn't get optimized away by a
6692 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6694 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6696 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6698 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6700 Fix the `xbytecode' command.
6701 * .gdbinit (xprintbytestr): New command.
6702 (xwhichsymbols): Rename from `which'; all callers changed.
6703 (xbytecode): Print the byte-code string as well.
6705 2011-10-29 Kim Storm <storm@cua.dk>
6707 * alloc.c (which_symbols): New function.
6709 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6711 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6714 2011-10-29 Glenn Morris <rgm@gnu.org>
6716 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6717 Not clear what it was for, and it causes various bugs. (Bug#9839)
6719 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6721 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6722 possible random value that matches one of those tested as
6723 condition to clear the mouse face.
6725 2011-10-28 Chong Yidong <cyd@gnu.org>
6727 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6729 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6731 * window.c (make_window): Initialize phys_cursor_on_p.
6733 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6735 * lisp.h (struct Lisp_Symbol): Update comments.
6737 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6739 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6741 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6743 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6744 <oslsachem@gmail.com> for helping to debug this.
6746 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6747 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6748 (g_b_init_get_glyph_outline_w): New static variables.
6749 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6750 (GetGlyphOutlineW_Proc): New typedefs.
6751 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6752 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6754 (w32font_open_internal, compute_metrics):
6755 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6756 instead of calling the "wide" APIs directly.
6758 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6760 * w32.h (syms_of_w32font): Add prototype.
6762 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6764 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6765 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6766 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6767 (Fmove_to_window_line): Doc fix.
6769 2011-10-27 Chong Yidong <cyd@gnu.org>
6771 * process.c (make_process): Set gnutls_state to NULL.
6773 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6774 non-NULL, regardless of GNUTLS_INITSTAGE.
6775 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6776 an error. Set process slots as soon as we allocate them.
6778 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6780 2011-10-27 Chong Yidong <cyd@gnu.org>
6782 * gnutls.c (emacs_gnutls_deinit): New function.
6783 Deallocate credentials structures as well as calling gnutls_deinit.
6784 (Fgnutls_deinit, Fgnutls_boot): Use it.
6786 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6787 (deactivate_process): Call emacs_gnutls_deinit.
6789 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6791 * image.c (x_create_x_image_and_pixmap):
6792 * w32.c (sys_rename, w32_delayed_load):
6793 * w32font.c (fill_in_logfont):
6794 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6796 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6798 * w32fns.c (w32_default_color_map): New function,
6799 extracted from Fw32_default_color_map.
6800 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6802 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6804 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6806 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6808 * keyboard.c (test_undefined): New function (bug#9751).
6809 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6811 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6813 * sysdep.c (init_sys_modes): Fix the check for the controlling
6814 terminal (Bug#6649).
6816 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6818 * dispextern.h (struct bidi_it): New member next_en_type.
6820 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6821 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6822 current character, check also for next_en_type being WEAK_EN.
6823 (bidi_resolve_weak): Don't enter the expensive loop if the current
6824 position is before next_en_pos. Record the bidi type of the first
6825 non-ET, non-BN character we find, in addition to its position.
6826 (bidi_level_of_next_char): Invalidate next_en_type when
6827 next_en_pos is over-stepped.
6829 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6831 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6832 * editfns.c: Rewrite current-time-zone so that it invokes
6833 the equivalent of (format-time-string "%Z") to get the time zone name.
6834 This fixes a bug when the time zone name contains characters that
6835 need converting from the system time locale to Emacs internal format.
6836 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6837 that patch fixed format-time-string to do the conversion, but
6838 I forgot to fix current-time-zone.
6839 (format_time_string): New function, containing most of
6840 what Fformat_time_string used to contain.
6841 (Fformat_time_string): Rewrite in terms of format_time_string.
6842 This doesn't change this function's behavior.
6843 (current-time-zone): Rewrite to use format_time_string.
6844 This fixes the bug reported by Michael Schierl in
6845 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6846 Jason Rumney's 2007-06-07 change worked around this bug, but
6848 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6850 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6852 * xdisp.c (start_display): If the character at POS is displayed
6853 via a display vector, reset IT->current.dpvec_index to zero.
6854 (try_window_reusing_current_matrix): If a line ends in a display
6855 vector or the next line starts in a display vector, continue
6856 redrawing the window even though the character position of
6857 start_row was reached.
6860 2011-10-18 Chong Yidong <cyd@gnu.org>
6862 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6863 with nobreak-char-display too.
6865 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6867 Fix part 3 of bug#9771.
6868 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6869 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6870 non-neutral characters if the current character is a paragraph
6871 separator (a.k.a. Newline). This avoids running the same
6872 expensive loop twice, once when we consume the preceding newline
6873 and the other time when the line actually needs to be displayed.
6874 Avoid the loop when we see neutrals on the base embedding level
6875 following a character whose directionality is the same as the
6876 paragraph's. This avoids running the expensive loop when a line
6877 ends in a long sequence of neutrals, like control characters.
6878 Add assertion against STRONG_AL type. Slightly rearrange code
6879 that determines the type of a neutral given the first non-neutral
6881 (bidi_level_of_next_char): Set next_en_pos to zero when
6882 invalidating its info.
6884 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6886 * xdisp.c (push_display_prop): Determine whether to record string
6887 or buffer position by IT->string, not by IT->method. Allow
6888 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6889 (move_it_vertically_backward): Don't look for character position
6890 immediately after the newline when in a continuation line.
6893 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6895 * window.c (coordinates_in_window): Rewrite and delabelize
6896 vertical border check. (Bug#5357) (Bug#9618)
6898 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6900 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6901 errors in XSetWindowBorder (bug#9310).
6903 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6905 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6906 avoid crash when xmalloc overrun checking is enabled.
6908 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6910 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6911 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6912 cursor motion with <left> and <right> arrow keys.
6914 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6915 some callers set that themselves.
6917 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6919 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6920 display string and the previous row comes from the same string and
6921 is empty. (Bug#9739) (Bug#9738)
6923 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6925 * doc.c (get_doc_string): Encode file name (bug#9735).
6927 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6929 * bidi.c (bidi_level_of_next_char):
6930 * xdisp.c (get_visually_first_element): Remove old incorrect
6931 comments regarding the Unicode Line Separator character.
6933 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6935 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6937 * alloc.c (Fgc_status): Do not access beyond zombies array
6938 boundary if nzombies > MAX_ZOMBIES.
6939 * alloc.c (dump_zombies): Add missing format specifier.
6941 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6943 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6944 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6946 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6947 Some packages use them to denote characters with modifiers.
6949 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6951 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6952 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6953 matching a pp-number. Rename parameter var to var1.
6955 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6957 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6959 2011-10-08 Glenn Morris <rgm@gnu.org>
6961 * callint.c (Fcall_interactively): Give a more explicit error for the
6962 'c' case with a non-character input. (Bug#8479)
6964 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6966 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6968 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6969 lines that are hscrolled on the left.
6971 * dispnew.c (buffer_posn_from_coords): Account for a possible
6972 presence of header-line. (Bug#4426)
6974 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6976 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6977 Don't advertise functionality which we discourage or doesn't work.
6979 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6981 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6982 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6983 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6984 this makes Emacs dump core during garbage collection on rare
6985 occasions. sizeof is obviously inferior to offsetof here, so
6986 stick with offsetof.
6987 (GC_POINTER_ALIGNMENT): New macro.
6988 (mark_memory): Omit 3rd (offset) arg; caller changed.
6989 Don't assume EMACS_INT alignment is the same as pointer alignment.
6991 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6993 * keyboard.c (read_key_sequence_remapped): New var.
6994 (read_key_sequence): Compute remapping in the right buffer.
6995 (command_loop_1): Use read_key_sequence's remapping directly.
6997 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6999 * dired.c (file_name_completion): Don't expand file name.
7000 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7001 before checking file name handler.
7003 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7004 they've been requested explicitly (bug#9591).
7006 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
7008 * keymap.c (Fsingle_key_description): Use make_specified_string
7009 instead of build_string to build string from push_key_description.
7012 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7014 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7015 This fixes a Y2038 bug on 64-bit hosts.
7016 * buffer.c (reset_buffer):
7017 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7018 (Fclear_buffer_auto_save_failure):
7019 Use 0, not -1, to represent an unset failure time, since time_t
7020 might not be signed.
7022 Remove dependency on glibc malloc internals.
7023 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7024 Move back here from lisp.h, but with their new implementations.
7025 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7026 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7027 * charset.c (charset_table_init): New static var.
7028 (syms_of_charset): Use it instead of xmalloc. This removes a
7029 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7030 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7031 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7032 Move back to alloc.c.
7033 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7034 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7036 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7038 * nsterm.m (windowDidResize): Call x_set_window_size only when
7039 ns_in_resize is true. Otherwise set pixelwidth/height and
7040 call change_frame_size (Bug#9628).
7042 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7044 Port --enable-checking=all to Fedora 14 x86-64.
7045 * charset.c (syms_of_charset): Also account for glibc malloc's
7046 internal overhead when calculating the initial malloc maximum.
7048 Port --enable-checking=all to Fedora 14 x86.
7049 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7051 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7052 (overrun_check_realloc, overrun_check_free):
7053 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7054 That way, xmalloc returns a properly-aligned pointer even if
7055 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7056 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7057 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7058 into account when calculating the initial malloc maximum.
7059 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7060 Move here from alloc.c, so that charset.c can use it too.
7061 Properly align; the old code wasn't right for common 32-bit hosts
7062 when configured with --enable-checking=all.
7063 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7064 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7066 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7068 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7071 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7073 * xdisp.c (compute_display_string_end): If there's no display
7074 string at CHARPOS, return -1.
7076 * bidi.c (bidi_fetch_char): When compute_display_string_end
7077 returns a negative value, treat the character as a normal
7078 character not covered by a display string. (Bug#9624)
7080 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7082 * lread.c (Fread_from_string): Fix typo in docstring.
7084 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7086 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7087 newline, reseat the iterator instead of bidi-iterating there one
7088 character at a time. (Bug#9610)
7089 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7090 TO_CHARPOS if the bidi iterator is at base embedding level.
7092 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7094 * lread.c (readevalloop): Use correct code for NBSP.
7095 (read1): Likewise. (Bug#9608)
7097 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7099 * dbusbind.c (Fdbus_register_signal): When service is not
7100 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7102 2011-09-25 Glenn Morris <rgm@gnu.org>
7104 * buffer.c (truncate-lines): Doc fix.
7106 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7108 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7109 (Fset_window_next_buffers): Doc fix.
7111 2011-09-24 Glenn Morris <rgm@gnu.org>
7113 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7115 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7117 Fix minor problems found by static checking.
7118 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7119 * indent.c (Fvertical_motion): Fix == vs = typo.
7121 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7123 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7124 Default value is now t. Doc fix.
7126 * indent.c (Fvertical_motion): Compute and apply the overshoot
7127 logic when moving up, not only when moving down. Fix the
7128 confusing name and values of the it_overshoot_expected variable;
7129 logic changes accordingly. (Bug#9254) (Bug#9549)
7131 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7132 CHARPOS is covered by a display string which includes newlines.
7133 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7134 is covered by a display string with embedded newlines.
7136 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7138 * dbusbind.c (Fdbus_register_signal): Add match rule to
7139 Vdbus_registered_objects_table. (Bug#9581)
7140 (Fdbus_register_method, Vdbus_registered_objects_table):
7143 2011-09-24 Jim Meyering <meyering@redhat.com>
7145 do not ignore write error for any output size
7146 The previous change was incomplete.
7147 While it makes emacs --batch detect the vast majority of stdout
7148 write failures, errors were still ignored whenever the output size is
7149 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7150 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7151 && echo FAIL: ignored write error
7152 FAIL: ignored write error
7153 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7154 && echo FAIL: ignored write error
7155 FAIL: ignored write error
7156 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7158 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7160 * emacs.c (Fkill_emacs): In noninteractive mode exit
7161 non-successfully if a write error occurred on stdout. (Bug#9574)
7163 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7165 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7168 * dispextern.h (struct it): Update the comment documenting what
7171 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7173 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7174 a display string, extend search for cursor position to end of row.
7175 (find_row_edges): If the row ends in a newline from a display
7176 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7177 Handle the case of a display string with multiple newlines.
7178 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7179 non-empty line. Fixes confusing cursor motion with arrow keys at
7180 the beginning of a line that starts with whitespace.
7182 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7184 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7187 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7189 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7192 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7194 * xdisp.c (display_line): Record maximum and minimum buffer
7195 positions even if no glyphs were produced (e.g., by a zero-width
7196 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7197 buffer positions that will be removed from the glyph row because
7199 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7200 column is beyond frame width: don't subtract 1 "pixel" when
7201 computing width of the stretch.
7202 (reseat_at_next_visible_line_start): Undo the change made on
7203 2011-09-17 that saved paragraph information and restored it after
7204 the call to `reseat'. (Bug#9545)
7206 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7208 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7209 and turn window cursor on if cleared (Bug#9415).
7211 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7213 * search.c (boyer_moore): Take unibyte characters from pattern
7214 literally. (Bug#9458)
7216 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7218 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7220 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7222 Fix minor problem found by static checking.
7223 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7224 initialized, to pacify gcc -Wuninitialized.
7226 * fileio.c: Report proper errno when syscall falls.
7227 (Finsert_file_contents): Save and restore errno,
7228 so that report_file_error outputs the correct diagnostic.
7229 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7231 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7233 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7235 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7237 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7238 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7240 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7242 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7243 about the current paragraph and restore it after the call to reseat.
7245 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7246 (bidi_find_paragraph_start): Search back for paragraph beginning
7247 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7248 (bidi_move_to_visually_next): Only trigger paragraph-related
7249 computations when the last character is a newline or at EOB, not
7250 just any NEUTRAL_B. (Bug#9470)
7252 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7253 truncated lines if point is covered by a display string. (Bug#9524)
7255 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7257 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7258 (cons_to_x_long): New function.
7259 (lisp_data_to_selection_data): Use it. Correct the test for
7260 short-versus-long data; it was negated. Break out of vector
7261 loop, for efficiency, when a long datum is discovered.
7263 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7265 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7267 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7269 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7270 GCC PR/17406) by declaring this function with external scope.
7272 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7274 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7275 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7277 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7279 * editfns.c (Fformat): Correctly handle text properties on "%%".
7281 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7283 * xterm.c (x_draw_composite_glyph_string_foreground):
7284 * w32term.c (x_draw_composite_glyph_string_foreground):
7285 * term.c (encode_terminal_code):
7286 * composite.c (composition_update_it, get_composition_id):
7287 * xdisp.c (get_next_display_element)
7288 (fill_composite_glyph_string): Add comments about special meaning
7289 of TAB characters in a composition.
7291 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7293 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7294 This occurs when processing a multibyte format.
7295 Problem reported by Wolfgang Jenker.
7297 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7299 * xdisp.c (try_cursor_movement): Only check for exact match if
7300 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7302 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7304 Remove unused external symbols.
7305 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7306 * xdisp.c (calc_pixel_width_or_height): Now static.
7307 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7308 * indent.c (check_display_width):
7309 * w32term.c: Fix comment to match code.
7310 * xterm.c, xterm.h (x_catching_errors): Remove.
7312 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7314 * xselect.c: Use signed conversions more consistently (Bug#9498).
7315 (selection_data_to_lisp_data): Assume incoming selection data are
7316 signed integers, not unsigned. This is to be consistent with
7317 outgoing selection data, which was modified to use signed integers
7318 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7319 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7320 expects long, not unsigned long.
7322 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7324 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7325 computation of loop end. Reported by Johan Bockgård
7328 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7330 * frame.c (Fother_visible_frames_p): Function deleted.
7332 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7334 * indent.c (compute_motion): Process display vector front to back
7335 rather than the other way around. (Bug#2496)
7337 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7339 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7341 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7343 * minibuf.c (Fread_from_minibuffer): Doc fix.
7345 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7347 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7348 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7350 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7352 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7353 value for non-existent files.
7355 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7357 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7358 set its "size" to -1. This will set the modtime_size field of
7359 the corresponding buffer to -1, which is what
7360 verify-visited-file-modtime expects for files that do not exist.
7363 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7365 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7367 * lisp.h: ... from here. push_key_description is no longer
7368 defined in keyboard.c, so its declaration should not be in
7369 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7370 logically belongs with push_key_description.
7372 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7374 * buffer.h: Include <sys/types.h> instead of <time.h>.
7375 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7376 Problem reported by Herbert J. Skuhra.
7378 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7380 * xml.c (parse_region): Make the parsing work for
7381 non-comment-starting XML files again (bug#9144).
7383 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7385 * image.c (gif_load): Fix calculation of bottom and right corner.
7388 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7390 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7391 redisplay in small windows.
7393 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7395 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7397 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7399 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7400 Operate on live windows only.
7402 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7404 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7406 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7408 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7409 only under bidi iteration.
7411 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7413 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7415 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7417 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7418 Without this fix, the command to link temacs failed due to an
7419 undefined symbol __builtin_isnan. This is because
7420 /usr/include/iso/math_c99.h #defines isnan(x) to
7421 __builtin_isnan(x), but the bundled gcc, which identifies itself
7422 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7424 * floatfns.c (isnan): #undef, and then #define to a clone of
7426 (Fisnan): Always define, since it's always available now.
7427 (syms_of_floatfns): Always define isnan at the Lisp level.
7429 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7431 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7433 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7435 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7436 The previous code assumed that file offsets (off_t values) fit in
7437 EMACS_INT variables, which is not true on typical 32-bit hosts.
7438 The code messed up by falsely reporting buffer overflow in cases
7439 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7440 when "big" contains more than 2**29 bytes, even though this
7441 inserts just one byte and does not overflow the buffer.
7442 (Finsert_file_contents): Store file offsets as off_t
7443 values, not as EMACS_INT values. Check for overflow when
7444 converting between EMACS_INT and off_t. When checking for
7445 buffer overflow or for overlap, take the offsets into account.
7446 Don't use EMACS_INT for small values where int suffices.
7447 When checking for overlap, fix a typo: ZV was used where
7448 ZV_BYTE was intended.
7449 (Fwrite_region): Don't assume off_t fits into 'long'.
7450 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7452 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7454 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7456 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7458 sprintf-related integer and memory overflow issues (Bug#9412).
7460 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7461 (esprintf, exprintf, evxprintf): New functions.
7462 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7463 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7464 (modify_event_symbol): Do not assume that the length of
7465 name_alist_or_stem is safe to alloca and fits in int.
7466 (Fexecute_extended_command): Likewise for function name and binding.
7467 (Frecursion_depth): Wrap around reliably on integer overflow.
7468 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7469 since some callers pass EMACS_INT values.
7470 (Fsingle_key_description): Don't crash if symbol name contains more
7471 than MAX_ALLOCA bytes.
7472 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7473 (get_minibuffer): Arg is now EMACS_INT, not int.
7474 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7475 (esprintf, exprintf, evxprintf): New decls.
7476 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7478 * dbusbind.c (signature_cat): New function.
7479 (xd_signature, Fdbus_register_signal):
7480 Do not overrun buffer; instead, report string overflow.
7482 * dispnew.c (add_window_display_history): Don't overrun buffer.
7483 Truncate instead; this is OK since it's just a log.
7485 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7486 even if the time zone offset is outlandishly large.
7487 Don't mishandle offset == INT_MIN.
7489 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7490 when creating daemon; the previous buffer-overflow check was incorrect.
7492 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7493 which has the guts of the old verror function.
7495 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7496 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7498 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7499 (font_unparse_xlfd): Don't blindly alloca long strings.
7500 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7501 fits in int, when using sprintf. Use single snprintf to count
7502 length of string rather than counting it via multiple sprintfs;
7503 that's simpler and more reliable.
7504 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7505 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7506 sprintf, in case result does not fit in int.
7508 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7509 (fontset_from_font): Print it.
7511 * frame.c (tty_frame_count): Now printmax_t, not int.
7512 (make_terminal_frame, set_term_frame_name): Print it.
7513 (x_report_frame_params): In X, window IDs are unsigned long,
7514 not signed long, so print them as unsigned.
7515 (validate_x_resource_name): Check for implausibly long names,
7516 and don't assume name length fits in 'int'.
7517 (x_get_resource_string): Don't blindly alloca invocation name;
7518 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7521 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7522 (xg_check_special_colors, xg_set_geometry):
7523 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7525 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7526 Use esprintf, not sprintf, in case result does not fit in int.
7528 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7529 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7530 it as a large positive number.
7531 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7532 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7534 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7535 in case result does not fit in int.
7537 * print.c (float_to_string): Detect width overflow more reliably.
7538 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7539 buffer overrun. Don't assume list length fits in 'int'. Treat
7540 print length of 0 as 0, not as infinity; to be consistent with other
7541 uses of print length in this function. Don't overflow print length
7542 index. Don't assume hash table size fits in 'long', or that
7543 vectorlike size fits in 'unsigned long'.
7545 * process.c (make_process): Use printmax_t, not int, to format
7546 process-name gensyms.
7548 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7550 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7551 to avoid potential buffer overrun.
7553 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7554 if X resource line is longer than 512 bytes.
7556 * xfns.c (x_window): Make sprintf buffer a bit bigger
7557 to avoid potential buffer overrun.
7559 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7561 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7563 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7565 Integer overflow fixes for scrolling, etc.
7566 Without these, Emacs silently mishandles large integers sometimes.
7567 For example, "C-u 4294967297 M-x recenter" was treated as if
7568 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7570 * xdisp.c (try_window_id): Check Emacs fixnum range before
7571 converting to 'int'.
7573 * window.c (window_scroll_line_based, Frecenter):
7574 Check that an Emacs fixnum is in range before assigning it to 'int'.
7575 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7576 values converted from Emacs fixnums.
7577 (Frecenter): Don't wrap around a line count if it is out of 'int'
7578 range; instead, treat it as an extreme value.
7579 (Fset_window_configuration, compare_window_configurations):
7580 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7582 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7583 that can exceed INT_MAX. Check that EMACS_INT value is in range
7584 before assigning it to the (possibly-narrower) index.
7585 (match_limit): Don't assume that a fixnum can fit in 'int'.
7587 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7590 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7591 (Fvertical_motion): Don't wrap around LINES values that don't fit
7592 in 'int'. Instead, treat them as extreme values. This is good
7593 enough for windows, which can't have more than INT_MAX lines anyway.
7595 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7597 * Require libxml/parser.h to avoid compilation warning.
7599 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7601 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7602 since this reportedly can destroy thread storage.
7604 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7606 * syntax.c (find_defun_start): Update all cache variables if
7607 exiting early (Bug#9401).
7609 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7611 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7613 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7614 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7615 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7617 * term.c (tty_append_glyph): New function.
7618 (produce_stretch_glyph): Static function and its prototype deleted.
7620 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7623 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7625 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7626 when checking :margin (Bug#9390).
7627 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7628 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7629 so that the name doesn't mislead. All uses changed.
7631 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7633 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7636 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7638 * xdisp.c (move_it_to): Don't bail out early when reaching
7639 position beyond to_charpos, if we are scanning backwards.
7640 (move_it_vertically_backward): When DY == 0, make sure we get to
7641 the first character in the line after the newline.
7643 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7645 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7646 (ccl_driver): Do not generate an out-of-range pointer.
7647 (Fccl_execute_on_string): Remove unnecessary check for
7648 integer overflow, noted by Stefan Monnier in
7649 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7650 Remove a FIXME that didn't need fixing.
7651 Simplify the newly-introduced buffer reallocation code.
7653 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7655 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7657 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7659 Integer and memory overflow issues (Bug#9196).
7661 * doc.c (get_doc_string): Rework so that
7662 get_doc_string_buffer_size is the actual buffer size, rather than
7663 being 1 less than the actual buffer size; this makes xpalloc more
7666 * image.c (x_allocate_bitmap_record, cache_image):
7667 * xselect.c (Fx_register_dnd_atom):
7668 Simplify previous changes by using xpalloc.
7670 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7671 since either will do and ptrdiff_t is convenient with xpalloc.
7673 * charset.c (charset_table_size)
7674 (struct charset_sort_data.priority): Now ptrdiff_t.
7675 (charset_compare): Don't overflow if priorities differ greatly.
7676 (Fsort_charsets): Don't assume list length fits in int.
7677 Check for size-calculation overflow when allocating sort data.
7678 (syms_of_charset): Allocate an initial charset table that is
7679 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7681 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7683 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7684 The actual value is always <= INT_MAX, and leaving it unsigned made
7685 overflow checking harder.
7687 * dispextern.h (struct glyph_matrix.rows_allocated)
7688 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7689 with xpalloc. The values are still always <= INT_MAX.
7691 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7693 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7694 (SAFE_NALLOCA): New macro.
7696 * region-cache.c (struct boundary.pos, find_cache_boundary)
7697 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7698 (set_cache_region, invalidate_region_cache)
7699 (revalidate_region_cache, know_region_cache, region_cache_forward)
7700 (region_cache_backward, pp_cache):
7701 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7702 so that ptrdiff_t * can be passed to xpalloc.
7703 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7704 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7705 (pp_cache): Don't assume cache_len fits in int.
7706 * region-cache.h: Adjust extern decls to match.
7708 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7709 EMACS_INT, since either will do, for xpalloc.
7711 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7712 (xnmalloc, xnrealloc, xpalloc): New functions.
7714 * bidi.c (bidi_shelve_header_size): New constant.
7715 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7716 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7718 * bidi.c (bidi_cache_shrink):
7719 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7721 Don't update size of array until after memory allocation succeeds,
7722 because xmalloc/xrealloc may not return.
7723 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7724 now that we have proper integer overflow checking.
7725 (record_overlay_string, overlay_strings): Catch overflows when
7726 calculating size of overlay_str_buf.
7728 * callproc.c (Fcall_process): Check for size overflow when
7729 calculating size of args2.
7730 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7731 Normally we prefer signed values, but sticking with ptrdiff_t would
7732 require adding more-complicated checks.
7734 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7735 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7736 Redo buffer-overflow calculations to avoid integer overflow.
7737 Add a FIXME comment where memory seems to be over-allocated.
7739 * character.c (Fstring): Check for size-calculation overflow.
7741 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7742 unnecessary integer overflow. Check for size overflow.
7743 (encode_coding_object): Don't update size until xmalloc succeeds.
7745 * composite.c (get_composition_id): Check for overflow in glyph
7746 length calculations.
7748 Integer and memory overflow fixes for display code.
7749 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7750 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7751 (scrolling_window): Check for overflow in size calculations.
7752 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7753 Don't assume glyph table len fits in int.
7754 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7755 (row_table_size): Now ptrdiff_t, not int.
7756 (scrolling_window): Avoid overflow in size calculations.
7757 Don't update size until allocation succeeds.
7758 * fns.c (concat): Check for overflow in size calculations.
7759 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7760 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7761 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7763 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7764 (get_doc_string): Check for size calculation overflow.
7765 Don't update size until allocation succeeds.
7766 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7767 EMACS_INT, where ptrdiff_t will do.
7768 (Fsubstitute_command_keys): Check for string overflow.
7770 * editfns.c (set_time_zone_rule): Don't assume environment length
7772 (message_length): Now ptrdiff_t, not int.
7773 (Fmessage_box): Don't update size until allocation succeeds.
7774 Don't assume message length fits in int.
7775 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7777 * emacs.c (main): Do not reallocate argv, since there is a null at
7778 the end that can be overwritten, and this way there's no need to
7779 worry about size-calculation overflow.
7780 (sort_args): Check for size-calculation overflow.
7782 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7784 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7786 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7787 (x_set_scroll_bar_width, x_figure_window_size):
7788 Check for integer overflow.
7789 (x_set_alpha): Do not assume XINT fits in int.
7791 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7792 This is for the members text_lines, text_cols, total_lines, total_cols,
7793 where the system imposes an 'int' limit.
7795 * fringe.c (Fdefine_fringe_bitmap):
7796 Don't update size until alloc works.
7798 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7799 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7801 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7802 Check for size-calculation overflow.
7803 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7804 do, as we prefer signed integers.
7805 (id_to_widget.max_size, id_to_widget.used)
7806 (xg_store_widget_in_map, xg_remove_widget_from_map)
7807 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7808 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7809 Use and return ptrdiff_t, not int.
7810 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7811 * gtkutil.h: Change prototypes to match the above.
7813 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7814 are duplicate now that they've been promoted to lisp.h.
7815 (x_allocate_bitmap_record, x_alloc_image_color)
7816 (make_image_cache, cache_image, xpm_load):
7817 Don't update size until alloc is done.
7818 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7820 Check for size calculation overflow.
7821 (ct_colors_allocated_max): New constant.
7822 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7825 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7826 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7827 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7828 Use ptrdiff_t, not int, to count maps.
7829 (read_char_minibuf_menu_prompt): Check for overflow in size
7830 calculations. Don't update size until allocation succeeds.
7831 Redo calculations to avoid overflow.
7832 * keyboard.h: Change prototypes to match the above.
7834 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7836 (current_minor_maps): Check for size calculation overflow.
7837 * keymap.h: Change prototypes to match the above.
7839 * lread.c (read1, init_obarray): Don't update size until alloc done.
7841 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7842 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7844 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7845 Now ptrdiff_t, not int.
7846 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7847 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7849 * process.c (Fnetwork_interface_list): Check for overflow
7850 in size calculation.
7852 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7854 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7855 overflow. Don't bother calling xmalloc when xrealloc will do.
7857 * search.c (Freplace_match): Check for size calculation overflow.
7858 (Fset_match_data): Don't assume list lengths fit in 'int'.
7860 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7861 for command line length. Do not attempt to address one before the
7862 beginning of an array, as that's not portable.
7864 * term.c (max_frame_lines): Remove; unused.
7865 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7867 (encode_terminal_code, calculate_costs): Check for size
7868 calculation overflow.
7869 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7870 table lengths and related sizes. Don't update size until alloc
7871 done. Redo calculations to avoid overflow.
7872 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7874 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7875 subtracting pointers.
7876 (gobble_line): Check for overflow more carefully. Don't update size
7879 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7880 Don't update size until alloc done.
7881 Redo size calculations to avoid overflow.
7882 Check for size calculation overflow.
7883 (main) [DEBUG]: Fix typo in invoking tparam1.
7885 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7886 Use ptrdiff_t, not int, for sizes.
7887 (store_mode_line_noprop_char): Don't update size until alloc done.
7889 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7890 Use ptrdiff_t, not int, for sizes.
7891 (Finternal_make_lisp_face, cache_face):
7892 Check for size calculation overflow.
7893 (cache_face): Treat size calculation overflows as if they were
7894 memory exhaustion (the usual treatment), rather than aborting.
7896 * xfns.c (x_encode_text, x_set_name_internal)
7897 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7898 sizes, since they can exceed INT_MAX in size. Check for size
7899 calculation overflow.
7901 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7902 (xg_select): Check for size calculation overflow.
7903 Don't update size until alloc done.
7905 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7906 as sprintf is limited to int lengths.
7908 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7909 (X_LONG_MIN): New macros.
7910 Use them to make the following changes clearer.
7911 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7912 This change doesn't affect the value now, but it may help remind
7913 future maintainers not to raise the value too much later.
7914 (SELECTION_QUANTUM): Remove, replacing with ...
7915 (selection_quantum): ... new function, which avoids overflow.
7917 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7918 assumption that selection length fits in 'int'.
7919 (x_reply_selection_request, x_handle_selection_request)
7920 (x_get_window_property, receive_incremental_selection)
7921 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7922 (lisp_data_to_selection_data, clean_local_selection_data):
7923 Use ptrdiff_t, not int, to record length of selection.
7924 (x_reply_selection_request, x_get_window_property)
7925 (receive_incremental_selection, x_property_data_to_lisp):
7926 Redo calculations to avoid overflow.
7927 (x_reply_selection_request): When sending hint, ceiling it at
7928 X_LONG_MAX rather than relying on wraparound overflow to send
7930 (x_get_window_property, receive_incremental_selection)
7931 (lisp_data_to_selection_data, x_property_data_to_lisp):
7932 Check for size-calculation overflow.
7933 (x_get_window_property, receive_incremental_selection)
7934 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7935 Don't store size until memory allocation succeeds.
7936 (x_get_window_property): Plug memory leak on memory exhaustion.
7937 Don't double-block input; malloc is safe here. Don't assume 2**34
7938 - 4 fits in unsigned long. Add an xassert to check
7939 XGetWindowProperty overflow. Be more careful about overflow
7940 calculations, and distinguish size from memory overflow better.
7941 (receive_incremental_selection): When tracing, don't assume
7942 unsigned int is less than INT_MAX.
7943 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7944 harmful) conversions of unsigned short to int.
7945 (lisp_data_to_selection_data): Don't assume that integers
7946 in the range -65535 through -1 fit in an X unsigned short.
7947 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7948 result parameters unless successful. Rely on cons_to_unsigned
7949 to report problems with elements; the old code wasn't right anyway.
7950 (x_check_property_data): Check for int overflow; we cannot use
7951 a wider type due to X limits.
7952 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7954 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7956 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7957 (x_term_init): Check for size calculation overflow.
7958 (x_color_cells): Don't store size until memory allocation succeeds.
7959 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7960 Don't assume alloca size is less than MAX_ALLOCA.
7961 (x_term_init): Don't assume length fits in int (sprintf is limited
7964 Use ptrdiff_t for composition IDs.
7965 * character.c (lisp_string_width):
7966 * composite.c (composition_table_size, n_compositions)
7967 (get_composition_id, composition_gstring_from_id):
7968 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7969 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7970 * window.c (Frecenter):
7971 Use ptrdiff_t, not int, for composition IDs.
7972 * composite.c (get_composition_id): Check for integer overflow.
7973 * composite.h: Adjust prototypes to match the above changes.
7975 Use ptrdiff_t for hash table indexes.
7976 * category.c (hash_get_category_set):
7977 * ccl.c (ccl_driver):
7978 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7979 * coding.c (coding_system_charset_list, detect_coding_system):
7980 * coding.h (struct coding_system.id):
7981 * composite.c (get_composition_id, gstring_lookup_cache):
7982 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7983 * image.c (xpm_get_color_table_h):
7984 * lisp.h (hash_lookup, hash_put):
7985 * minibuf.c (Ftest_completion):
7986 Use ptrdiff_t for hash table indexes, not int (which is too
7987 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7988 32-bit --with-wide-int hosts).
7990 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7991 Add a FIXME comment about memory leaks.
7992 (syms_of_charset): Don't assume xmalloc returns.
7994 Don't assume that stated character widths fit in int.
7995 * character.c (Fchar_width, c_string_width, lisp_string_width):
7996 * character.h (CHAR_WIDTH):
7997 * indent.c (MULTIBYTE_BYTES_WIDTH):
7998 Use sanitize_char_width to avoid undefined and/or bad behavior
7999 with outlandish widths.
8000 * character.h (sanitize_tab_width): Rename from sanitize_width,
8001 now that we have two such functions. All uses changed.
8002 (sanitize_char_width): New inline function.
8004 Don't assume that tab-width fits in int.
8005 * character.h (sanitize_width): New inline function.
8006 (SANE_TAB_WIDTH): New macro.
8007 (ASCII_CHAR_WIDTH): Use it.
8008 * indent.c (sane_tab_width): Remove. All uses replaced by
8009 SANE_TAB_WIDTH (current_buffer).
8010 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8012 * fileio.c: Integer overflow issues with file modes.
8013 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8015 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8016 Remove unreachable code.
8017 (read_hex, load_charset_map_from_file): Check for integer overflow.
8019 * xterm.c: Don't go over XClientMessageEvent limit.
8020 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8021 (x_send_scroll_bar_event): Likewise. Check that the size does not
8022 exceed limits imposed by XClientMessageEvent, as well as the usual
8023 ptrdiff_t and size_t limits.
8025 * keyboard.c: Overflow, signedness and related fixes.
8026 (make_lispy_movement): Use same integer type in forward decl
8027 that is used in the definition.
8028 (read_key_sequence, keyremap_step):
8029 Change bufsize argument back to int, undoing my 2011-03-30 change.
8030 We prefer signed types, and int is wide enough here.
8031 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8032 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8033 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8034 length, not size_t. Use ptrdiff_t for index, not int.
8035 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8036 possibility of integer overflow.
8038 Overflow, signedness and related fixes for images.
8040 * dispextern.h (struct it.stack[0].u.image.image_id)
8041 (struct_it.image_id, struct image.id, struct image_cache.size)
8042 (struct image_cache.used, struct image_cache.ref_count):
8043 * gtkutil.c (update_frame_tool_bar):
8044 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8045 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8046 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8047 * nsmenu.m (update_frame_tool_bar):
8048 * xdisp.c (calc_pixel_width_or_height):
8049 * xfns.c (image_cache_refcount):
8050 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8051 on typical 64-bit hosts.
8053 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8054 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8055 Omit unnecessary casts to int.
8056 (parse_image_spec): Check that integers fall into 'int' range
8057 when the callers expect that.
8058 (image_ascent): Redo ascent calculation to avoid int overflow.
8059 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8060 (lookup_image): Remove unnecessary tests.
8061 (xbm_image_p): Locals are now of int, not EMACS_INT,
8062 since parse_image_check makes sure they fit into int.
8063 (png_load, gif_load, svg_load_image):
8064 Prefer int to unsigned where either will do.
8065 (tiff_handler): New function, combining the cores of the
8066 old tiff_error_handler and tiff_warning_handler.
8067 This function is rewritten to use vsnprintf and thereby avoid
8068 stack buffer overflows. It uses only the features of vsnprintf
8069 that are common to both POSIX and native Microsoft.
8070 (tiff_error_handler, tiff_warning_handler): Use it.
8071 (tiff_load, gif_load, imagemagick_load_image):
8072 Don't assume :index value fits in 'int'.
8073 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8074 (imagemagick_load_image): Check that crop parameters fit into
8075 the integer types that MagickCropImage accepts. Don't assume
8076 Vimagemagick_render_type has a nonnegative value. Don't assume
8077 size_t fits in 'long'.
8078 (gs_load): Use printmax_t to print the widest integers possible.
8079 Check for integer overflow when computing image height and width.
8081 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8083 * xdisp.c (redisplay_window): Don't force window start if point
8084 will be invisible in the resulting window. (Bug#9324)
8086 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8088 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8089 the display spec is of the form `(space ...)'.
8090 (handle_display_spec): Return the value returned by
8091 handle_single_display_spec, not just 1 or zero.
8092 (handle_single_display_spec): If the display spec is of the form
8093 `(space ...)', and specifies display in the text area, return 2
8095 (try_cursor_movement): Check for the need to scroll more
8096 accurately, and prefer exact match for point under bidi.
8097 Don't advance `row' beyond the last row of the window.
8099 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8100 into disp_prop; all users changed.
8102 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8103 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8104 for the text covered by the display property.
8106 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8108 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8109 Change return value to nil.
8110 (Frecord_buffer): Delete unused function.
8112 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8114 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8115 buffers, return left-to-right.
8116 (set_cursor_from_row): Consider candidate row a win if its glyph
8117 represents a newline and point is on that newline. Fixes cursor
8118 positioning on the newline at EOL of R2L text within L2R
8119 paragraph, and vice versa.
8120 (try_cursor_movement): Check continued rows, in addition to
8121 continuation rows. Fixes unwarranted scroll when point enters a
8122 continued line of R2L text within an L2R paragraph, or vice versa.
8123 (cursor_row_p): Consider the case of point being equal to
8124 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8125 from the end of a short line to the beginning of a continued line
8126 of R2L text within L2R paragraph.
8127 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8128 composed characters.
8130 * bidi.c (bidi_check_type): Use xassert.
8131 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8134 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8136 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8139 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8141 * nsfont.m (ns_otf_to_script): Fix typo.
8143 2011-08-22 Kenichi Handa <handa@m17n.org>
8145 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8146 extra slot even if the purpose is char-code-property-table.
8148 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8150 * xdisp.c (redisplay_window): When computing centering_position,
8151 account for the height of the header line. (Bug#8874)
8153 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8154 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8155 candidate is selected by the mouse, and that candidate has a
8156 composed character under the mouse.
8158 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8159 coordinates reported by pos-visible-in-window-p for a composed
8160 character in column zero.
8162 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8164 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8166 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8168 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8169 consider it a hit if to_charpos is anywhere in the range of the
8170 composed buffer positions.
8172 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8174 * image.c (gif_load): Don't assume that each subimage has the same
8175 dimensions as the base image. Handle disposal method that is
8176 "undefined" by the gif spec (Bug#9335).
8178 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8180 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8181 (Fcondition_case): Document `debug' symbol in error handler.
8183 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8185 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8186 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8187 from an Org mode buffer to a Speedbar frame.
8189 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8190 a composition, take its buffer position from IT->cmp_it.charpos.
8191 Fixes cursor positioning at the beginning of a line that begins
8192 with a composed character.
8194 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8196 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8197 character bidirectional type, use STRONG_L instead. Fixes crashes
8198 in a buffer produced by `describe-categories'.
8200 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8201 members before the level stack, so they would be saved and
8202 restored when copying iterator state. Fixes incorrect reordering
8203 around TABs covered by display properties.
8205 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8207 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8209 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8211 * eval.c (internal_condition_case, internal_condition_case_1)
8212 (internal_condition_case_2, internal_condition_case_n):
8213 Remove unnecessary aborts (Bug#9081).
8215 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8217 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8218 has no `load' handler, try opening the file locally. (Bug#9311)
8220 2011-08-16 Ken Brown <kbrown@cornell.edu>
8222 * gmalloc.c: Expand comment.
8224 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8226 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8227 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8229 2011-08-16 Ken Brown <kbrown@cornell.edu>
8231 Fix memory allocation problems in Cygwin build (Bug#9273).
8233 * unexcw.c ( __malloc_initialized): Declare external variable.
8234 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8236 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8238 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8240 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8242 [CYGWIN] (special_realloc): New function.
8243 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8244 requests to realloc storage in the static heap.
8246 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8248 * bidi.c (bidi_initialize): Remove unused local.
8250 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8253 * biditype.h: Remove file.
8254 * makefile.w32-in ($(BLD)/bidi.$(O)):
8255 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8257 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8259 * chartab.c: Improve commentary for the uniprop_table API.
8261 * bidi.c (bidi_paragraph_init): Support zero value of
8262 bidi_ignore_explicit_marks_for_paragraph_level.
8263 (bidi_initialize): Use uniprop_table instead of including
8264 biditype.h and bidimirror.h.
8266 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8267 coordinates of the iterator when restoring from ppos_it.
8270 2011-08-14 Kenichi Handa <handa@m17n.org>
8272 * process.c (create_process): Call setup_process_coding_systems
8273 after the pid of the process is set to -1 (Bug#8162).
8275 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8277 * xdisp.c (move_it_in_display_line_to): Don't invoke
8278 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8279 ppos_it. Fixes vertical cursor motion when line beginning is
8280 covered by an image. (Bug#9296)
8282 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8284 * nsterm.h (ns_run_ascript): Declare.
8285 (NSAPP_DATA2_RUNASSCRIPT): Define.
8287 * nsfns.m (as_script, as_result, as_status): New static variables.
8288 (ns_run_ascript): New function.
8289 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8290 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8291 the event loop. Get status from as_status (Bug#7276).
8293 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8294 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8295 the event loop (Bug#7276).
8297 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8299 * gnutls.c (QCgnutls_bootprop_priority)
8300 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8301 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8302 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8303 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8304 (QCgnutls_bootprop_verify_hostname_error)
8305 (QCgnutls_bootprop_callbacks_verify): Rename from
8306 Qgnutls_bootprop_..., all uses changed.
8308 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8311 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8313 * xfaces.c (Qframe_set_background_mode): Now static.
8314 * dispextern.h (Qframe_set_background_mode): Remove decl.
8316 * process.c (Fnetwork_interface_info): Declare local only if needed.
8318 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8320 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8321 (Fnetwork_interface_list): Allocate in increments of bytes instead
8322 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8323 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8325 (struct ifflag_def): notrailers is smart on OSX.
8326 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8327 Get hardware address with getifaddrs if available.
8329 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8331 * xdisp.c (iterate_out_of_display_property): xassert that
8332 IT->position is set to within IT->object's boundaries. Break from
8333 the loop as soon as EOB is reached; avoids infloops in redisplay
8334 when IT->position is set up wrongly due to some bug.
8335 Set IT->current to match the bidi iterator unconditionally.
8336 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8337 entry. Force push_it to save on the stack the current
8338 buffer/string position, to be restored by pop_it. Fix flags in
8339 the iterator structure wrt the object coming from a display
8340 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8341 properties. (Bug#9284)
8343 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8345 * fontset.c (fontset_get_font_group): Add proper type checks.
8348 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8350 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8351 and LC_VERSION_MIN_MACOSX.
8352 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8353 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8355 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8357 * xdisp.c (forward_to_next_line_start): Allow to use the
8358 no-display-properties-and-no-overlays under bidi display.
8359 Set disp_pos in the bidi iterator to avoid searches for display
8360 properties and overlays.
8362 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8364 * editfns.c (Fset_time_zone_rule): Document relationship with the
8367 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8368 the font entity extracted from the cache (Bug#8109).
8370 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8372 * composite.c (autocmp_chars): Don't reset point. That is done by
8373 restore_point_unwind (Bug#5984).
8375 2011-08-07 Juri Linkov <juri@jurta.org>
8377 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8378 to show the arg `TIME' instead of `TIMEVAL'.
8380 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8382 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8383 display property strides EOL and includes a newline, as in
8384 longlines-mode. (Bug#9254)
8385 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8386 word-wrap under bidirectional display. (Bug#9224)
8388 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8389 is non-zero, even if the data buffer is NULL. Fixes a crash in
8390 vertical-motion with longlines-mode. (Bug#9254)
8392 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8394 * bidi.c <bidi_cache_total_alloc>: Now static.
8395 (bidi_initialize): Initialize bidi_cache_total_alloc.
8397 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8400 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8401 amount allocated this far in `bidi_cache_total_alloc'.
8402 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8403 non-zero, only free the data buffer without restoring the cache
8404 contents. All callers changed.
8406 * dispextern.h (bidi_unshelve_cache): Update prototype.
8408 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8409 (move_it_in_display_line, move_it_to)
8410 (move_it_vertically_backward, move_it_by_lines): Replace the call
8411 to xfree to an equivalent call to bidi_unshelve_cache.
8412 (move_it_in_display_line_to): Fix logic of returning
8413 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8415 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8417 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8418 came from a string character with a `cursor' property. (Bug#9229)
8420 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8422 * Makefile.in (LIB_PTHREAD): New variable.
8423 (LIBES): Add LIB_PTHREAD (Bug#9216).
8425 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8426 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8428 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8430 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8432 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8434 * xterm.c (x_find_topmost_parent): New function.
8435 (x_set_frame_alpha): Find topmost parent window with
8436 x_find_topmost_parent and set the property there also (bug#9181).
8437 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8439 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8441 * callproc.c (Fcall_process): Avoid vfork clobbering
8442 the local vars buffer, coding_systems, current_dir.
8444 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8446 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8448 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8450 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8451 so that it is not optimized away.
8453 * xdisp.c (compute_display_string_pos): Remove unused local.
8455 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8457 Fix slow cursor motion and scrolling in large buffers with
8458 selective display, like Org Mode buffers. (Bug#9218)
8460 * dispextern.h (struct bidi_it): New member disp_prop_p.
8462 * xdisp.c: Remove one-slot cache of display string positions.
8463 (compute_display_string_pos): Accept an additional argument
8464 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8465 for a display string or property. If found, set DISP_PROP_P
8468 * bidi.c (bidi_fetch_char): Accept an additional argument
8469 DISP_PROP_P, and pass it to compute_display_string_pos.
8470 Only handle text covered by a display string if DISP_PROP_P is returned
8471 non-zero. All callers of bidi_fetch_char changed.
8473 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8475 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8477 2010-12-03 Don March <don@ohspite.net>
8479 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8480 last character M-[char] is translated to ESC [char] (bug#7541).
8482 2011-08-02 Kenichi Handa <handa@m17n.org>
8484 * lisp.h (uniprop_table): Extern it.
8486 * chartab.c (uniprop_table): Make it non-static.
8488 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8490 * xdisp.c (forward_to_next_line_start): Accept additional argument
8491 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8493 (reseat_at_next_visible_line_start): Use the bidi iterator state
8494 returned by forward_to_next_line_start to restore the state of
8495 it->bidi_it after backing up to previous newline. (Bug#9212)
8497 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8499 * regex.c (re_comp): Protoize.
8500 (re_exec): Fix return type.
8501 (regexec): Fix type of `ret'. (Bug#9203)
8503 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8505 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8506 This is needed if max-image-size is a floating-point number.
8508 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8510 * print.c (print_object): Print empty symbol as ##.
8512 * lread.c (read1): Read ## as empty symbol.
8514 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8516 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8517 setting frame foreground color (Bug#9175).
8518 (x_set_background_color): Likewise.
8520 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8521 contents (Bug#9176).
8522 (EmacsTooltip -init): Remove bezels and add shadows to
8525 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8526 or scroll bar (Bug#8470).
8528 * nsfont.m (nsfont_open): Remove assignment to voffset and
8529 unnecessary vars hshink, expand, hd, full_height, min_height.
8530 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8532 * nsterm.h (nsfont_info): Remove voffset field.
8534 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8536 Implement strike-through and overline on NextStep (Bug#8863).
8538 * nsfont.m (nsfont_open): Use underline position provided by font,
8539 instead of hard-coded value of 2.
8540 (nsfont_draw): Call ns_draw_text_decoration instead.
8542 * nsterm.h: Add declaration for ns_draw_text_decoration.
8544 * nsterm.m (ns_draw_text_decoration): New function for drawing
8545 underline, overline, and strike-through.
8546 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8547 ns_draw_text_decoration. Change treatment of cursor drawing to
8548 accommodate underlining, etc.
8550 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8552 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8555 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8557 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8558 Without this fix, if a signal arrives just after memory fills up,
8559 'malloc' might be invoked reentrantly.
8561 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8562 In other words, assume that every image size is allowed, on non-X
8563 hosts. This assumption is probably wrong, but it lets Emacs compile.
8565 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8567 * regex.c (re_iswctype): Convert return values to boolean.
8569 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8571 * xdisp.c (compute_display_string_pos): Don't use cached display
8572 string position if the buffer had its restriction changed.
8575 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8577 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8579 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8581 Integer signedness and overflow and related fixes. (Bug#9079)
8583 * bidi.c: Integer size and overflow fixes.
8584 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8585 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8586 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8587 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8588 (bidi_find_other_level_edge):
8589 Use ptrdiff_t instead of EMACS_INT where either will do.
8590 This works better on 32-bit hosts configured --with-wide-int.
8591 (bidi_cache_ensure_space): Check for size-calculation overflow.
8592 Use % rather than repeated addition, for better worst-case speed.
8593 Don't set bidi_cache_size until after xrealloc returns, because it
8595 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8596 (bidi_cache_ensure_space): Also check that the bidi cache size
8597 does not exceed that of the largest Lisp string or buffer. See Eli
8598 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8600 * alloc.c (__malloc_size_t): Remove.
8601 All uses replaced by size_t. See Andreas Schwab's note
8602 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8604 * image.c: Improve checking for integer overflow.
8605 (check_image_size): Assume that f is nonnull, since
8606 it is always nonnull in practice. This is one less thing to
8607 worry about when checking for integer overflow later.
8608 (x_check_image_size): New function, which checks for integer
8609 overflow issues inside X.
8610 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8611 This removes the need for a memory_full check.
8612 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8613 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8614 (xbm_read_bitmap_data): Change locals back to 'int', since
8615 their values must fit in 'int'.
8616 (xpm_load_image, png_load, tiff_load):
8617 Invoke x_create_x_image_and_pixmap earlier,
8618 to avoid much needless work if the image is too large.
8619 (tiff_load): Treat overly large images as if
8620 x_create_x_image_and_pixmap failed, not as malloc failures.
8621 (gs_load): Use x_check_image_size.
8623 * gtkutil.c: Omit integer casts.
8624 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8625 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8627 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8629 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8630 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8631 would wrongly return t on a 64-bit host.
8633 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8634 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8635 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8636 and therefore cause GCC to emit a bogus diagnostic in some cases.
8638 * image.c: Integer signedness and overflow and related fixes.
8639 This is not an exhaustive set of fixes, but it's time to
8640 record what I've got.
8641 (lookup_pixel_color, check_image_size): Remove redundant decls.
8642 (check_image_size): Don't assume that arbitrary EMACS_INT values
8643 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8644 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8645 (tiff_load, imagemagick_load_image):
8646 Check for overflow in size calculations.
8647 (x_create_x_image_and_pixmap): Remove unnecessary test for
8648 xmalloc returning NULL; that can't happen.
8649 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8650 (xpm_color_bucket): Use better integer hashing function.
8651 (xpm_cache_color): Don't possibly over-allocate memory.
8652 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8653 (gif_memory_source):
8654 Use ptrdiff_t, not int or size_t, to record sizes.
8655 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8656 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8657 either works, as we prefer signed integers.
8658 (tiff_read_from_memory, tiff_write_from_memory):
8659 Return tsize_t, not size_t, since that's what the TIFF API wants.
8660 (tiff_read_from_memory): Don't fail simply because the read would
8661 go past EOF; instead, return a short read.
8662 (tiff_load): Omit no-longer-needed casts.
8663 (Fimagemagick_types): Don't assume size fits into 'int'.
8665 Improve hashing quality when configured --with-wide-int.
8666 * fns.c (hash_string): New function, taken from sxhash_string.
8667 Do not discard information about ASCII character case; this
8668 discarding is no longer needed.
8669 (sxhash-string): Use it. Change sig to match it. Caller changed.
8670 * lisp.h: Declare it.
8671 * lread.c (hash_string): Remove, since we now use fns.c's version.
8672 The fns.c version returns a wider integer if --with-wide-int is
8673 specified, so this should help the quality of the hashing a bit.
8675 * emacs.c: Integer overflow minor fix.
8676 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8677 Define only if GNU_LINUX.
8678 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8680 * dispnew.c: Integer signedness and overflow fixes.
8681 Remove unnecessary forward decls, that were a maintenance hassle.
8682 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8684 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8685 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8686 (prepare_desired_row, line_draw_cost):
8687 Use int, not unsigned, where either works.
8688 (save_current_matrix, restore_current_matrix):
8689 Use ptrdiff_t, not size_t, where either works.
8690 (init_display): Check for overflow more accurately, and without
8691 relying on undefined behavior.
8693 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8694 Remove, replacing with the new symbols in lisp.h. All uses changed.
8695 * fileio.c (make_temp_name):
8696 * filelock.c (lock_file_1, lock_file):
8697 * xdisp.c (message_dolog):
8698 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8699 Use pMd etc. instead.
8700 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8701 replacing the pWIDE etc. symbols removed from editfns.c.
8703 * keyboard.h (num_input_events): Now uintmax_t.
8704 This is (very slightly) less likely to mess up due to wraparound.
8707 * buffer.c: Integer signedness fixes.
8708 (alloc_buffer_text, enlarge_buffer_text):
8709 Use ptrdiff_t rather than size_t when either will do, as we prefer
8712 * alloc.c: Integer signedness and overflow fixes.
8713 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8714 (__malloc_size_t): Default to size_t, not to int.
8715 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8716 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8717 Prefer ptrdiff_t to size_t when either would do, as we prefer
8719 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8720 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8721 Now const. Initialize with values that are in range even if char
8723 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8724 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8725 These functions do the right thing with sizes > 2**32.
8726 (check_depth): Now ptrdiff_t, not int.
8727 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8728 Adjust to new way of storing sizes. Check for size overflow bugs
8730 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8731 slightly wrong anyway, as it missed one instance of
8732 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8733 (refill_memory_reserve): Omit needless cast to size_t.
8734 (mark_object_loop_halt): Mark as externally visible.
8736 * xselect.c: Integer signedness and overflow fixes.
8737 (Fx_register_dnd_atom, x_handle_dnd_message):
8738 Use ptrdiff_t, not size_t, since we prefer signed.
8739 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8740 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8741 x_dnd_atoms_size and x_dnd_atoms_length.
8743 * doprnt.c: Prefer signed to unsigned when either works.
8745 * doprnt.c (doprnt):
8747 * xdisp.c (vmessage):
8748 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8749 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8750 prefer signed arithmetic to avoid comparison confusion.
8751 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8752 but is a bit tricky.
8754 Assume freestanding C89 headers, string.h, stdlib.h.
8755 * data.c, doprnt.c, floatfns.c, print.c:
8756 Include float.h unconditionally.
8757 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8758 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8759 * regex.c: Likewise for stddef.h, string.h.
8760 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8761 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8762 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8763 (STDC_HEADERS): Remove obsolete defines.
8764 * sysdep.c: Include limits.h unconditionally.
8766 Assume support for memcmp, memcpy, memmove, memset.
8767 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8768 * regex.c (memcmp, memcpy):
8769 Remove; we assume C89 now.
8771 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8772 (__malloc_safe_bcopy): Remove; no longer needed.
8774 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8775 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8776 well either way, and we prefer signed to unsigned.
8778 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8780 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8781 closes the connection while we're reading (bug#9182).
8783 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8785 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8786 are specified (Bug#9168).
8788 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8790 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8791 Found by GCC static checking and --with-wide-int on a 32-bit host.
8793 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8795 * xdisp.c (compute_display_string_pos): Fix logic of caching
8796 previous display string position. Initialize cached_prev_pos to
8797 -1. Fixes slow-down at the beginning of a buffer.
8799 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8801 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8802 for attrs[LFACE_FONTSET_INDEX].
8804 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8806 * xml.c (parse_region): Remove unused local
8807 that was recently introduced.
8809 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8811 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8812 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8814 * xdisp.c (move_it_in_display_line_to): Record the best matching
8815 position for TO_CHARPOS while scanning the line, and restore it on
8816 exit if none of the characters scanned was an exact match.
8817 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8818 when exact match is impossible due to invisible text, and the
8819 lines are truncated.
8821 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8823 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8826 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8828 Fix a significant slow-down of cursor motion with C-n, C-p,
8829 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8830 auto-repeat under bidi redisplay in fontified buffers.
8831 * xdisp.c (compute_stop_pos_backwards): New function.
8832 (next_element_from_buffer): Call compute_stop_pos_backwards to
8833 find a suitable prev_stop when we find ourselves before
8835 (reseat): Don't look for prev_stop, as that could mean a very long
8837 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8838 <cached_disp_overlay_modiff>: Cache for last found display string
8840 (compute_display_string_pos): Return the cached position if asked
8841 about the same buffer in the same area of character positions, and
8842 the buffer wasn't changed since the time the display string
8843 position was cached.
8845 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8847 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8848 is an integer, which is important for empty lines. (Bug#9149)
8850 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8852 * frame.c (Fmodify_frame_parameters): In tty case, update the
8853 default face if necessary (Bug#4238).
8855 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8857 * editfns.c (Fstring_to_char): No need to explain what a character
8858 is in the docstring (Bug#6576).
8860 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8862 * xml.c (parse_region): Make sure we always return a tree.
8864 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8866 * xml.c (parse_region): If a document contains only comments,
8869 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8871 * xml.c (make_dom): Return comments, too.
8873 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8876 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8877 and the surrounding thread.
8878 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8879 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8880 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8882 * s/openbsd.h (BROKEN_SIGIO): Define.
8883 * unexelf.c (unexec) [__OpenBSD__]:
8884 Don't update the .mdebug section of the Alpha COFF symbol table.
8886 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8888 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8891 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8893 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8894 This fixes some race conditions on the permissions of any newly
8897 * alloc.c (valid_pointer_p): Use pipe, not open.
8898 This fixes some permissions issues when debugging.
8900 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8901 If fchown fails to set both uid and gid, try to set just gid,
8902 as that is sometimes allowed. Adjust the file's mode to eliminate
8903 setuid or setgid bits that are inappropriate if fchown fails.
8905 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8907 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8908 to compare Lisp_Objects.
8909 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8910 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8911 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8913 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8915 * lread.c (read_integer): Unread even EOF character.
8916 (read1): Likewise. Properly record start position of symbol.
8918 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8919 symbol character follows.
8921 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8923 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8924 This works around a problem with the previous change to Fcopy_file.
8925 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8926 and without this change, GCC might complain about discarding
8927 fchown's return value.
8929 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8931 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8933 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8935 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8937 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8939 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8940 it's used from the C level.
8942 * process.c: Use the same condition for POLL_FOR_INPUT in both
8943 keyboard.c and process.c (bug#1858).
8945 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8947 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8948 (Fgnutls_boot): Use it.
8950 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8952 * doc.c (Fsubstitute_command_keys): Revert last change.
8954 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8956 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8957 quotes the next character, and doesn't affect other longer
8958 sequences (bug#8935).
8960 * lread.c (syms_of_lread): Clarify that is isn't only
8961 `eval-buffer' and `eval-defun' that's affected by
8962 `lexical-binding' (bug#8460).
8964 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8966 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8967 bidi redisplay when a line includes both an image and is truncated.
8969 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8971 Fix minor problems found by static checking.
8972 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8973 (elsz): Now a signed constant, not a size_t var. We prefer signed
8974 types to unsigned, to avoid integer comparison confusion. Without
8975 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8976 "cannot optimize loop, the loop counter may overflow", a symptom
8978 * indent.c (Fvertical_motion): Mark locals as initialized.
8979 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8981 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8983 * search.c (Fre_search_backward): Mention `case-fold-search' in
8984 all the re_search_* functions (bug#8138).
8986 * keyboard.c (Fopen_dribble_file): Document when the file is
8989 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8991 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8994 Support bidi reordering of display and overlay strings.
8995 * xdisp.c (compute_display_string_pos)
8996 (compute_display_string_end): Accept additional argument STRING.
8997 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8998 (reseat_to_string): Initialize bidi_it->string.s and
8999 bidi_it->string.schars.
9000 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
9001 NULL (avoids a crash in bidi_paragraph_init).
9002 Initialize itb.string.lstring.
9003 (init_iterator): Call bidi_init_it only of a valid
9004 buffer position was specified. Initialize paragraph_embedding to
9006 (reseat_to_string): Initialize the bidi iterator.
9007 (display_string): If we need to ignore text properties of
9008 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9009 original value of -1 will not work with bidi.)
9010 (compute_display_string_pos): First arg is now struct
9011 `text_pos *'; all callers changed. Support display properties on
9013 (compute_display_string_end): Support display properties on Lisp
9015 (init_iterator, reseat_1, reseat_to_string): Initialize the
9016 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9017 when iterating on a string not from display properties).
9018 (compute_display_string_pos, compute_display_string_end):
9019 Fix calculation of the object to scan. Fixes an error when using
9021 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
9022 base_level_stop; instead, set base_level_stop to BEGV.
9023 Fixes crashes in vertical-motion.
9024 (next_element_from_buffer): Improve commentary for when
9025 the iterator is before prev_stop.
9026 (init_iterator): Initialize bidi_p from the default value of
9027 bidi-display-reordering, not from buffer-local value. Use the
9028 buffer-local value only if initializing for buffer iteration.
9029 (handle_invisible_prop): Support invisible properties on strings
9030 that are being bidi-reordered.
9031 (set_iterator_to_next): Support bidi reordering of C strings and
9033 (next_element_from_string): Support bidi reordering of Lisp
9035 (handle_stop_backwards): Support Lisp strings as well.
9036 (display_string): Support display of R2L glyph rows.
9037 Use IT_STRING_CHARPOS when displaying from a Lisp string.
9038 (init_iterator): Don't initialize it->bidi_p for strings
9040 (reseat_to_string): Initialize it->bidi_p for strings here.
9041 (next_element_from_string, next_element_from_c_string)
9042 (next_element_from_buffer): Add xassert's for correspondence
9043 between IT's object being iterated and it->bidi_it.string
9045 (face_before_or_after_it_pos): Support bidi iteration.
9046 (next_element_from_c_string): Handle the case of the first string
9047 character that is not the first one in the visual order.
9048 (get_visually_first_element): New function, refactored from common
9049 parts of next_element_from_buffer, next_element_from_string, and
9050 next_element_from_c_string.
9051 (tool_bar_lines_needed, redisplay_tool_bar)
9052 (display_menu_bar): Force left-to-right direction. Add a FIXME
9053 comment for making that be controlled by a user option.
9054 (push_it, pop_it): Save and restore the state of the
9055 bidi iterator. Save and restore the bidi_p flag.
9056 (pop_it): Iterate out of display property for string iteration as
9058 (iterate_out_of_display_property): Support iteration over strings.
9059 (handle_single_display_spec): Set up it->bidi_it for iteration
9060 over a display string, and call bidi_init_it.
9061 (handle_single_display_spec, next_overlay_string)
9062 (get_overlay_strings_1, push_display_prop): Set up the bidi
9063 iterator for displaying display or overlay strings.
9064 (forward_to_next_line_start): Don't use the shortcut if
9066 (back_to_previous_visible_line_start): If handle_display_prop
9067 pushed the iterator stack, restore the internal state of the bidi
9068 iterator by calling bidi_pop_it same number of times.
9069 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9070 and we are bidi-iterating, don't decrement the iterator position;
9071 instead, set the first_elt flag in the bidi iterator, to produce
9073 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9074 (push_display_prop): xassert that we are iterating a buffer.
9075 (push_it, pop_it): Save and restore paragraph_embedding member.
9076 (handle_single_display_spec, next_overlay_string)
9077 (get_overlay_strings_1, reseat_1, reseat_to_string)
9078 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9079 correctly. Don't assume unibyte strings are not bidi-reordered.
9080 (compute_display_string_pos)
9081 (compute_display_string_end): Fix handling the case of C string.
9082 (push_it, pop_it): Save and restore from_disp_prop_p.
9083 (handle_single_display_spec, push_display_prop): Set the
9084 from_disp_prop_p flag.
9085 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9086 (pop_it): Call iterate_out_of_display_property only if we are
9087 popping after iteration over a string that came from a display
9088 property. Fix a typo in popping stretch info. Add an assertion
9089 for verifying that the iterator position is in sync with the bidi
9091 (handle_single_display_spec, get_overlay_strings_1)
9092 (push_display_prop): Fix initialization of paragraph direction for
9093 string when that of the parent object is not yet determined.
9094 (reseat_1): Call bidi_init_it to resync the bidi
9095 iterator with IT's position. (Bug#7616)
9096 (find_row_edges): If ROW->start.pos gives position
9097 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9098 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9099 Reset the from_disp_prop_p flag.
9100 (SAVE_IT, RESTORE_IT): New macros.
9101 (pos_visible_p, face_before_or_after_it_pos)
9102 (back_to_previous_visible_line_start)
9103 (move_it_in_display_line_to, move_it_in_display_line)
9104 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9105 (try_scrolling, redisplay_window, display_line): Use them when
9106 saving a temporary copy of the iterator and restoring it back.
9107 (back_to_previous_visible_line_start, reseat_1)
9108 (init_iterator): Empty the bidi cache "stack".
9109 (move_it_in_display_line_to): If iterator ended up at
9110 EOL, but we never saw any buffer positions smaller than
9111 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9112 motion in bidi-reordered lines.
9113 (move_it_in_display_line_to): Record prev_method and prev_pos
9114 immediately before the call to set_iterator_to_next. Fixes cursor
9115 motion in bidi-reordered lines with stretch glyphs and strings
9116 displayed in margins. (Bug#8133) (Bug#8867)
9117 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9119 (pos_visible_p): Support positions in bidi-reordered lines.
9120 Save and restore bidi cache.
9122 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9123 (bidi_paragraph_info): Delete unused struct.
9124 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9125 (bidi_cache_start): New variable.
9126 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9128 (bidi_cache_fetch_state, bidi_cache_search)
9129 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9130 (bidi_cache_find, bidi_peek_at_next_level)
9131 (bidi_level_of_next_char, bidi_find_other_level_edge)
9132 (bidi_move_to_visually_next): Compare cache index with
9133 bidi_cache_start rather than with zero.
9134 (bidi_fetch_char): Accept new argument STRING; all callers
9135 changed. Support iteration over a string. Support strings with
9136 display properties. Support unibyte strings. Fix the type of
9137 `len' according to what STRING_CHAR_AND_LENGTH expects.
9138 (bidi_paragraph_init, bidi_resolve_explicit_1)
9139 (bidi_resolve_explicit, bidi_resolve_weak)
9140 (bidi_level_of_next_char, bidi_move_to_visually_next):
9141 Support iteration over a string.
9142 (bidi_set_sor_type, bidi_resolve_explicit_1)
9143 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9144 can now be zero (for strings); special values 0 and -1 were
9145 changed to -1 and -2, respectively.
9146 (bidi_char_at_pos): New function.
9147 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9148 Call it instead of FETCH_MULTIBYTE_CHAR.
9149 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9150 initialized to valid values.
9151 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9153 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9154 the test for valid cached positions. Fix the logic for looking up
9155 the sentinel state in the cache. GCPRO the Lisp string we are
9157 (bidi_push_it, bidi_pop_it): New functions.
9158 (bidi_initialize): Initialize the bidi cache start stack pointer.
9159 (bidi_cache_ensure_space): New function, refactored from part of
9160 bidi_cache_iterator_state. Don't assume the required size is just
9161 one BIDI_CACHE_CHUNK away.
9162 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9163 (bidi_count_bytes, bidi_char_at_pos): New functions.
9164 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9165 always valid if bidi_cache_idx is valid.
9166 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9167 is valid if it's going to be used.
9168 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9169 (bidi_cache_fetch_state, bidi_cache_search)
9170 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9171 (bidi_cache_iterator_state, bidi_cache_find)
9172 (bidi_find_other_level_edge, bidi_cache_start_stack):
9173 All variables related to cache indices are now EMACS_INT.
9175 * dispextern.h (struct bidi_string_data): New structure.
9176 (struct bidi_it): New member `string'. Make flag members be 1-bit
9177 fields, and put them last in the struct.
9178 (compute_display_string_pos, compute_display_string_end):
9180 (bidi_push_it, bidi_pop_it): Add prototypes.
9181 (struct iterator_stack_entry): New members bidi_p,
9182 paragraph_embedding, and from_disp_prop_p.
9183 (struct it): Member bidi_p is now a bit field 1 bit wide.
9184 (bidi_shelve_cache, bidi_unshelve_cache):
9187 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9188 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9189 and vector-like objects.
9191 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9192 cache around display iteration.
9194 * window.c (Fwindow_end, window_scroll_pixel_based)
9195 (displayed_window_lines, Frecenter): Save and restore the bidi
9196 cache around display iteration.
9198 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9200 * editfns.c (Fdelete_region): Clarify the use of the named
9201 parameters (bug#6788).
9203 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9205 * indent.c (Fvertical_motion): Set and restore w->pointm when
9206 saving and restoring the window's buffer (Bug#9006).
9208 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9210 * editfns.c (Fstring_to_char): Clarify just what is returned
9211 (bug#6576). Text by Eli Zaretskii.
9213 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9215 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9217 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9219 * buffer.c (mmap_find): Fix a typo.
9221 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9223 Fix execution of x selection hooks.
9224 * xselect.c (Qx_lost_selection_functions)
9225 (Qx_sent_selection_functions): New vars.
9226 (syms_of_xselect): DEFSYM them.
9227 (x_handle_selection_request): Pass Qx_sent_selection_functions
9228 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9229 (x_handle_selection_clear,x_clear_frame_selections):
9230 Pass Qx_lost_selection_functions rather than
9231 Vx_lost_selection_functions to Frun_hook_with_args.
9233 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9235 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9236 The old code sometimes used this field without initializing it.
9238 * alloc.c (gc_sweep): Don't read past end of array.
9239 In theory, the old code could also have corrupted Emacs internals,
9240 though it'd be very unlikely.
9242 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9244 * character.c (Fcharacterp): Don't advertise optional ignored
9245 argument. (Bug#4026)
9247 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9249 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9252 * window.c (Fset_window_start): Doc fix (bug#4199).
9253 (Fset_window_hscroll): Ditto.
9255 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9257 Fix minor new problems caught by GCC 4.6.1.
9258 * term.c (init_tty): Remove unused local.
9259 * xsettings.c (store_monospaced_changed): Define this function only
9260 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9263 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9265 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9267 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9269 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9270 are the mini-buffer and the echo area (bug#3320).
9272 * term.c (init_tty): Remove support for supdup, c10 and perq
9273 terminals, which are no longer supported (bug#1482).
9275 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9277 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9279 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9281 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9282 for non-popups (Bug#3642).
9284 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9286 * alloc.c (reset_malloc_hooks): Protoize.
9287 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9288 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9289 * cm.c (losecursor): Likewise.
9290 * data.c (fmod): Likewise.
9291 * dispnew.c (swap_glyphs_in_rows): Likewise.
9292 * emacs.c (memory_warning_signal): Likewise.
9293 * floatfns.c (float_error): Likewise.
9294 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9295 (otf_open, font_otf_capability, generate_otf_features)
9296 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9298 * image.c (pbm_read_file): Likewise.
9299 * indent.c (string_display_width): Likewise.
9300 * intervals.c (check_for_interval, search_for_interval)
9301 (inc_interval_count, count_intervals, root_interval)
9302 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9303 * lread.c (defalias): Likewise.
9304 * ralloc.c (r_alloc_check): Likewise.
9305 * regex.c (set_image_of_range_1, set_image_of_range)
9306 (regex_grow_registers): Likewise.
9307 * sysdep.c (strerror): Likewise.
9308 * termcap.c (valid_filename_p, tprint, main): Likewise.
9309 * tparam.c (main): Likewise.
9310 * unexhp9k800.c (run_time_remap, save_data_space)
9311 (update_file_ptrs, read_header, write_header, calculate_checksum)
9312 (copy_file, copy_rest, display_header): Likewise.
9313 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9315 * xdisp.c (check_it): Likewise.
9316 * xfaces.c (register_color, unregister_color, unregister_colors):
9318 * xfns.c (print_fontset_result): Likewise.
9319 * xrdb.c (member, fatal, main): Likewise.
9321 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9323 Fix minor problems found by static checking (Bug#9031).
9324 * chartab.c (char_table_set_range, map_sub_char_table):
9325 Remove unused locals.
9326 (uniprop_table): Now static.
9327 * composite.c (_work_char): Remove unused static var.
9329 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9331 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9333 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9335 * gtkutil.c (qttip_cb): Remove code without function.
9337 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9339 * w32.c (pthread_sigmask): New stub.
9341 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9343 Use pthread_sigmask, not sigprocmask (Bug#9010).
9344 sigprocmask is portable only for single-threaded applications, and
9345 Emacs can be multi-threaded when it uses GTK.
9346 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9348 * callproc.c (Fcall_process):
9349 * process.c (create_process):
9350 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9351 Use pthread_sigmask, not sigprocmask.
9353 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9355 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9356 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9359 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9361 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9362 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9363 (xg_hide_tooltip): Fix comment.
9365 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9366 in registerServicesMenuSendTypes.
9367 (validRequestorForSendType): Don't check ns_return_types.
9369 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9372 2011-07-08 Jason Rumney <jasonr@gnu.org>
9374 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9375 SH_SHOW for hidden windows (Bug#5482).
9377 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9378 frame struct members of non-existent frames (Bug#6284).
9380 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9382 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9383 variable firstTime not needed on OSX >= 10.6.
9384 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9385 >= 10.5. Use setKnobProportion, setDoubleValue.
9387 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9388 (MAC_OS_X_VERSION_10_5): Define if not defined.
9389 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9390 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9391 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9393 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9394 cString and lossyCString on OSX >= 10.4.
9396 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9397 sizeToFit on OSX >= 10.2.
9399 * nsimage.m (allocInitFromFile): Don't use deprecated method
9400 bestRepresentationForDevice on OSX >= 10.6.
9402 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9405 * emacs.c: Declare unexec_init_emacs_zone.
9407 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9409 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9411 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9412 on svcsMenu (Bug#8842).
9414 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9416 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9418 * nsterm.m (QUTF8_STRING): Declare.
9419 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9420 (validRequestorForSendType): Return type is (id).
9421 Change indexOfObjectIdenticalTo to indexOfObject.
9422 Check if we have local selection before returning self (Bug#8842).
9423 (writeSelectionToPasteboard): Put local selection into paste board
9424 if we have a local selection (Bug#8842).
9425 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9427 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9428 (ns_get_local_selection): Declare.
9430 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9432 * keymap.c (describe_map_tree): Don't insert a double newline at
9433 the end of the buffer (bug#1169) and return whether we inserted
9436 * callint.c (Fcall_interactively): Change "reading args" to
9437 "providing args" to try to clarify what it does (bug#1010).
9439 2011-07-07 Kenichi Handa <handa@m17n.org>
9441 * composite.c (composition_compute_stop_pos): Ignore a static
9442 composition starting before CHARPOS (Bug#8915).
9444 * xdisp.c (handle_composition_prop): Likewise.
9446 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9448 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9451 2011-07-07 Kenichi Handa <handa@m17n.org>
9453 * character.h (unicode_category_t): New enum type.
9455 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9456 (Qchar_code_property_table): New variable.
9457 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9458 (UNIPROP_COMPRESSED_FORM_P): New macros.
9459 (char_table_ascii): Uncompress the compressed values.
9460 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9461 Uncompress the compressed values.
9462 (sub_char_table_ref_and_range): Likewise.
9463 (char_table_ref_and_range): Uncompress the compressed values.
9464 (sub_char_table_set): New arg is_uniprop. Callers changed.
9465 Uncompress the compressed values.
9466 (sub_char_table_set_range): Args changed. Callers changed.
9467 (char_table_set_range): Adjuted for the above change.
9468 (map_sub_char_table): Delete args default_val and parent. Add arg
9469 top. Give decoded values to a Lisp function.
9470 (map_char_table): Adjust for the above change. Give decoded
9471 values to a Lisp function. Gcpro more variables.
9472 (uniprop_table_uncompress)
9473 (uniprop_decode_value_run_length): New functions.
9474 (uniprop_decoder, uniprop_decoder_count): New variables.
9475 (uniprop_get_decoder, uniprop_encode_value_character)
9476 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9478 (uniprop_encoder, uniprop_encoder_count): New variables.
9479 (uniprop_get_encoder, uniprop_table)
9480 (Funicode_property_table_internal, Fget_unicode_property_internal)
9481 (Fput_unicode_property_internal): New functions.
9482 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9483 Sunicode_property_table_internal, Sget_unicode_property_internal,
9484 and Sput_unicode_property_internal. Defvar_lisp
9485 char-code-property-alist.
9487 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9488 Vunicode_category_table.
9490 * font.c (font_range): Adjust for the change of
9491 Vunicode_category_table.
9493 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9495 * m/iris4d.h: Remove file, move contents ...
9496 * s/irix6-5.h: ... here.
9498 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9500 Remove unportable assumption about struct layout (Bug#8884).
9501 * alloc.c (mark_buffer):
9502 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9503 (clone_per_buffer_values): Don't assume that
9504 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9505 This isn't true in general, and it's particularly not true
9506 if Emacs is configured with --with-wide-int.
9507 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9508 New macros, used in the buffer.c change.
9510 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9512 * xsettings.c: Use both GConf and GSettings if both are available.
9513 (store_config_changed_event): Add comment.
9514 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9515 (store_tool_bar_style_changed): New functions.
9516 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9517 (struct xsettings): Move font inside HAVE_XFT.
9518 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9519 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9520 Move inside HAVE_XFT.
9521 (something_changed_gsettingsCB): Rename from something_changedCB.
9522 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9524 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9525 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9526 (something_changed_gconfCB): Rename from something_changedCB.
9527 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9528 (parse_settings): Move check for font inside HAVE_XFT.
9529 (read_settings, apply_xft_settings): Add comment.
9530 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9531 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9532 call store_font_name_changed.
9533 (xft_settings_event): Add comment.
9534 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9535 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9536 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9537 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9538 (xsettings_initialize): Call init_gsettings last.
9539 (xsettings_get_system_font, xsettings_get_system_normal_font):
9542 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9544 Random fixes. E.g., (random) never returned negative values.
9545 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9546 subseconds part to the entropy, as that's a bit more random.
9547 Prefer signed to unsigned, since the signedness doesn't matter and
9548 in general we prefer signed. When given a limit, use a
9549 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9550 latter isn't right if USE_2_TAGS_FOR_INTS.
9551 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9552 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9554 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9556 * textprop.c (text_property_stickiness):
9557 Obey Vtext_property_default_nonsticky.
9558 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9559 * w32fns.c (syms_of_w32fns):
9560 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9562 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9564 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9565 This is more efficient than Ffile_directory_p and avoids a minor race.
9567 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9569 * buffer.c (Foverlay_put): Say what the return value is
9572 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9573 is a directory before asking whether to use the file name
9575 (barf_or_query_if_file_exists): Make the "File is a directory"
9576 error be more correct.
9578 * fns.c (Frequire): Remove the mention of the .gz files, since
9579 that's installation-specific, but keep the mention of
9580 `get-load-suffixes'.
9582 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9584 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9585 Report string overflow if the output is too long.
9587 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9589 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9590 (syms_of_gnutls): Remove duplicate DEFSYM for
9591 Qgnutls_bootprop_verify_hostname_error, an error for
9592 Qgnutls_bootprop_verify_error (which is no longer used).
9594 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9595 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9596 Also (re)move comments that are misplaced or no longer relevant.
9598 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9600 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9602 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9604 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9605 and background color parameters if they have been changed.
9607 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9609 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9611 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9613 * xsettings.c (SYSTEM_FONT): Define only when used.
9614 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9616 * keymap.c (access_keymap_1): Now static.
9618 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9620 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9621 leave any prefix arg for the up event (Bug#1586).
9623 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9625 * lread.c (syms_of_lread): Mention single symbols defined by
9626 `defvar' or `defconst' (bug#7154).
9628 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9629 (Frequire): Mention get-load-suffixes.
9631 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9633 * window.h (window): Remove clone_number slot.
9634 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9636 (make_parent_window, make_window, saved_window)
9637 (Fset_window_configuration, save_window_save): Don't deal with
9639 * buffer.c (Qclone_number): Remove declaration.
9640 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9642 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9644 Add multiple inheritance to keymaps.
9645 * keymap.c (Fmake_composed_keymap): New function.
9646 (Fset_keymap_parent): Simplify.
9647 (fix_submap_inheritance): Remove.
9648 (access_keymap_1): New function extracted from access_keymap to handle
9649 embedded parents and handle lists of maps.
9650 (access_keymap): Use it.
9651 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9652 (Fcopy_keymap): Handle embedded parents.
9653 (Fcommand_remapping, define_as_prefix): Simplify.
9654 (Fkey_binding): Simplify.
9655 (syms_of_keymap): Move minibuffer-local-completion-map,
9656 minibuffer-local-filename-completion-map,
9657 minibuffer-local-must-match-map, and
9658 minibuffer-local-filename-must-match-map to Elisp.
9659 (syms_of_keymap): Defsubr make-composed-keymap.
9660 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9661 (parse_menu_item): Trivial simplification.
9663 2011-07-01 Glenn Morris <rgm@gnu.org>
9665 * Makefile.in (SETTINGS_LIBS): Fix typo.
9667 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9669 * coding.c (Fencode_coding_string): Record the last coding system
9670 used, as the function doc string says (bug#8738).
9672 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9674 * xsettings.c (store_monospaced_changed): Take new font as arg and
9675 check for change against current_mono_font.
9676 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9677 (emacs_settings_constructor, emacs_settings_get_property)
9678 (emacs_settings_set_property, emacs_settings_class_init)
9679 (emacs_settings_init, gsettings_obj): Remove.
9680 (something_changedCB): New function for HAVE_GSETTINGS.
9681 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9682 with value as argument.
9683 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9684 g_settings_new (Bug#8967). Do not create gsettings_obj.
9685 Remove calls to g_settings_bind. Connect something_changedCB to
9688 * xgselect.c: Add defined (HAVE_GSETTINGS).
9689 (xgselect_initialize): Ditto.
9691 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9692 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9695 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9697 * eval.c (struct backtrace): Simplify and port the data structure.
9698 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9699 signed bit field, as this assumption is not portable and it makes
9700 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9701 "char debug_on_exit : 1" as this is not portable either; instead,
9702 use the portable "unsigned int debug_on_exit : 1". Remove unused
9703 member evalargs. Remove obsolete comments about cc bombing out.
9705 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9707 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9708 Let HAVE_GSETTINGS override HAVE_GCONF.
9709 (store_monospaced_changed): New function.
9710 (EMACS_SETTINGS): A new type derived from GObject to handle
9711 GSettings notifications.
9712 (emacs_settings_constructor, emacs_settings_get_property)
9713 (emacs_settings_set_property, emacs_settings_class_init):
9715 (gsettings_client, gsettings_obj): New variables.
9716 (GSETTINGS_SCHEMA): New define.
9717 (something_changedCB): Call store_monospaced_changed.
9718 (init_gsettings): New function.
9719 (xsettings_initialize): Call init_gsettings.
9720 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9723 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9726 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9728 * window.c (resize_root_window, grow_mini_window)
9729 (shrink_mini_window): Rename Qresize_root_window to
9730 Qwindow_resize_root_window and Qresize_root_window_vertically to
9731 Qwindow_resize_root_window_vertically.
9733 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9735 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9737 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9739 * makefile.w32-in: Redesign dependencies so they reflect more
9740 clearly which files are directly included by each source file,
9741 and not through other includes.
9743 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9745 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9746 (sort_overlays, overlay_strings): When an overlay's clone number
9747 matches the window's clone number process the overlay even if
9748 the overlay's window property doesn't match the current window.
9750 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9751 (Fwindow_hchild): Rename to Fwindow_left_child.
9752 (Fwindow_next): Rename to Fwindow_next_sibling.
9753 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9754 (resize_window_check): Rename to window_resize_check.
9755 (resize_window_apply): Rename to window_resize_apply.
9756 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9757 (Fdelete_other_windows_internal, resize_frame_windows)
9758 (Fsplit_window_internal, Fdelete_window_internal)
9759 (grow_mini_window, shrink_mini_window)
9760 (Fresize_mini_window_internal): Fix callers accordingly.
9762 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9764 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9765 (emacs_fixed_set_min_size): Remove.
9766 (emacs_fixed_new): Take frame as argument.
9768 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9769 (_EmacsFixedPrivate): Remove minwidth/height.
9770 Add struct frame *f.
9771 (emacs_fixed_init): Initialize priv->f.
9772 (get_parent_class, emacs_fixed_set_min_size): Remove.
9773 (emacs_fixed_new): Set priv->f to argument.
9774 (emacs_fixed_get_preferred_width)
9775 (emacs_fixed_get_preferred_height): Use min_width/height from
9776 frames size_hint to set minimum and natural (Bug#8919).
9777 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9778 and use min_width/height from frames size_hint to set
9779 min_width/height (Bug#8919).
9781 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9782 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9785 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9787 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9788 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9791 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9793 * process.c (wait_reading_process_output): Bypass select if
9794 waiting for a cell while ignoring keyboard input, and input is
9795 pending. Suggested by Jan Djärv (Bug#8869).
9797 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9799 Use gnulib's dup2 module instead of rolling our own.
9800 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9802 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9804 * dispnew.c (scrolling_window): Before scrolling, turn off a
9805 mouse-highlight in the window being scrolled.
9807 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9809 Move DEFSYM to lisp.h and use everywhere.
9811 * character.h (DEFSYM): Move declaration...
9812 * lisp.h (DEFSYM): ...here.
9818 * w32select.c: Don't include character.h.
9820 * alloc.c (syms_of_alloc):
9821 * buffer.c (syms_of_buffer):
9822 * bytecode.c (syms_of_bytecode):
9823 * callint.c (syms_of_callint):
9824 * casefiddle.c (syms_of_casefiddle):
9825 * casetab.c (init_casetab_once):
9826 * category.c (init_category_once, syms_of_category):
9827 * ccl.c (syms_of_ccl):
9828 * cmds.c (syms_of_cmds):
9829 * composite.c (syms_of_composite):
9830 * dbusbind.c (syms_of_dbusbind):
9831 * dired.c (syms_of_dired):
9832 * dispnew.c (syms_of_display):
9833 * doc.c (syms_of_doc):
9834 * editfns.c (syms_of_editfns):
9835 * emacs.c (syms_of_emacs):
9836 * eval.c (syms_of_eval):
9837 * fileio.c (syms_of_fileio):
9838 * fns.c (syms_of_fns):
9839 * frame.c (syms_of_frame):
9840 * fringe.c (syms_of_fringe):
9841 * insdel.c (syms_of_insdel):
9842 * keymap.c (syms_of_keymap):
9843 * lread.c (init_obarray, syms_of_lread):
9844 * macros.c (syms_of_macros):
9845 * msdos.c (syms_of_msdos):
9846 * print.c (syms_of_print):
9847 * process.c (syms_of_process):
9848 * search.c (syms_of_search):
9849 * sound.c (syms_of_sound):
9850 * syntax.c (init_syntax_once, syms_of_syntax):
9851 * terminal.c (syms_of_terminal):
9852 * textprop.c (syms_of_textprop):
9853 * undo.c (syms_of_undo):
9854 * w32.c (globals_of_w32):
9855 * window.c (syms_of_window):
9856 * xdisp.c (syms_of_xdisp):
9857 * xfaces.c (syms_of_xfaces):
9858 * xfns.c (syms_of_xfns):
9859 * xmenu.c (syms_of_xmenu):
9860 * xsettings.c (syms_of_xsettings):
9861 * xterm.c (syms_of_xterm): Use DEFSYM.
9863 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9865 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9867 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9869 Integer and buffer overflow fixes (Bug#8873).
9871 * print.c (printchar, strout): Check for string overflow.
9872 (PRINTPREPARE, printchar, strout):
9873 Don't set size unless allocation succeeds.
9875 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9876 for sizes. Check for string overflow more accurately.
9877 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9879 * macros.c: Integer and buffer overflow fixes.
9880 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9881 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9882 Use ptrdiff_t, not int, for sizes.
9883 Don't increment bufsize until after realloc succeeds.
9884 Check for size-calculation overflow.
9885 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9887 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9889 * lread.c: Integer overflow fixes.
9890 (read_integer): Radix is now EMACS_INT, not int,
9891 to improve quality of diagnostics for out-of-range radices.
9892 Calculate buffer size correctly for out-of-range radices.
9893 (read1): Check for integer overflow in radices, and in
9894 read-circle numbers.
9895 (read_escape): Avoid int overflow.
9896 (Fload, openp, read_buffer_size, read1)
9897 (substitute_object_recurse, read_vector, read_list, map_obarray):
9898 Use ptrdiff_t, not int, for sizes.
9899 (read1): Use EMACS_INT, not int, for sizes.
9900 Check for size overflow.
9902 * image.c (cache_image): Check for size arithmetic overflow.
9904 * lread.c: Integer overflow issues.
9905 (saved_doc_string_size, saved_doc_string_length)
9906 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9907 Now ptrdiff_t, not int.
9908 (read1): Don't assume doc string length fits in int. Check for
9909 out-of-range doc string lengths.
9910 (read_list): Don't assume file position fits in int.
9911 (read_escape): Check for hex character overflow.
9913 2011-06-22 Leo Liu <sdl.web@gmail.com>
9915 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9916 Move to minibuffer.el.
9918 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9920 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9921 The following patches are for when GLYPH_DEBUG && !XASSERT.
9922 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9923 * dispnew.c (flush_stdout):
9924 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9925 Mark as externally visible.
9926 * dispnew.c (check_window_matrix_pointers): Now static.
9927 * dispnew.c (window_to_frame_vpos):
9928 * xfns.c (unwind_create_frame):
9929 * xterm.c (x_check_font): Remove unused local.
9930 * scroll.c (CHECK_BOUNDS):
9931 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9932 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9933 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9934 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9935 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9937 (debug_method_add): Use va_list and vsprintf rather than relying
9938 on undefined behavior with wrong number of arguments.
9939 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9940 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9941 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9942 since we're not interested in debugging glyphs with old libraries.
9943 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9944 GCC 4.6.0's static checking.
9946 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9948 Integer overflow and signedness fixes (Bug#8873).
9949 A few related buffer overrun fixes, too.
9951 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9953 * dispextern.h (struct face.stipple):
9954 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9955 (x_bitmap_mask, x_allocate_bitmap_record)
9956 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9957 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9958 (x_create_bitmap_from_xpm_data):
9959 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9960 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9962 * xfaces.c (load_pixmap):
9963 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9964 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9965 (.bitmaps_last, struct x_output.icon_bitmap):
9966 Use ptrdiff_t, not int, for bitmap indexes.
9967 (x_allocate_bitmap_record): Check for size overflow.
9968 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9970 Use ptrdiff_t, not int, for overlay counts.
9971 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9972 * editfns.c (overlays_around, get_pos_property):
9973 * textprop.c (get_char_property_and_overlay):
9974 * xdisp.c (next_overlay_change, note_mouse_highlight):
9975 * xfaces.c (face_at_buffer_position):
9976 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9977 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9978 (Fnext_overlay_change, Fprevious_overlay_change)
9979 (mouse_face_overlay_overlaps, Foverlays_in):
9980 Use ptrdiff_t, not int, for sizes.
9981 (overlays_at, overlays_in): Check for size-calculation overflow.
9983 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9985 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9986 (x_session_initialize): Do not assume string length fits in int.
9988 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9989 This is unlikely, but can occur if DPI is outlandish.
9991 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9992 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9994 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9995 * xrdb.c (magic_file_p, search_magic_path):
9996 Omit last arg SUFFIX; it was always 0. All callers changed.
9997 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9999 * xfont.c (xfont_match): Avoid need for strlen.
10001 * xfns.c: Don't assume strlen fits in int.
10002 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10004 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10005 not unsigned long, as we prefer signed integers. All callers changed.
10006 Detect integer overflow in repeat count.
10007 (message_dolog): Don't assume print length fits in 39 bytes.
10008 (display_mode_element): Don't assume strlen fits in int.
10010 * termcap.c: Don't assume sizes fit in int and never overflow.
10011 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10012 (gobble_line): Check for size-calculation overflow.
10014 * minibuf.c (Fread_buffer):
10015 * lread.c (intern, intern_c_string):
10016 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10017 Don't assume string length fits in int.
10019 * keyboard.c (parse_tool_bar_item):
10020 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10022 * font.c: Don't assume string length fits in int.
10023 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10024 Use ptrdiff_t, not int.
10025 (font_intern_prop): Don't assume string length fits in int.
10026 Don't assume integer property fits in fixnum.
10027 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
10029 * filelock.c: Fix some buffer overrun and integer overflow issues.
10030 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
10031 Reformulate so as not to need the command string.
10032 Invoke gzip -cd rather than gunzip, as it's more portable.
10033 (lock_info_type, lock_file_1, lock_file):
10034 Don't assume pid_t and time_t fit in unsigned long.
10035 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10036 (current_lock_owner): Prefer signed type for sizes.
10037 Use memcpy, not strncpy, where memcpy is what is really wanted.
10038 Don't assume (via atoi) that time_t and pid_t fit in int.
10039 Check for time_t and/or pid_t out of range, e.g., via a network share.
10040 Don't alloca where an auto var works fine.
10042 * fileio.c: Fix some integer overflow issues.
10043 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10044 Don't assume string length fits in int.
10045 (directory_file_name): Don't assume string length fits in long.
10046 (make_temp_name): Don't assume pid fits in int, or that its print
10047 length is less than 20.
10049 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10051 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10053 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10055 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10056 We prefer signed integers, even for size calculations.
10058 * emacs.c: Don't assume string length fits in 'int'.
10059 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10060 (main): Don't invoke strlen when not needed.
10062 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10063 (XD_DEBUG_MESSAGE): Don't waste a byte.
10065 * callproc.c (getenv_internal_1, getenv_internal)
10066 (Fgetenv_internal):
10067 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10069 * lread.c (invalid_syntax): Omit length argument.
10070 All uses changed. This doesn't fix a bug, but it simplifies the
10071 code away from its former Hollerith-constant appearance, and it's
10072 one less 'int' to worry about when looking at integer-overflow issues.
10073 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10075 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10076 This didn't break anything, but it didn't help either.
10077 It's confusing to put a bogus integer in a place where the actual
10078 value does not matter.
10079 (LIST_END_P): Remove unused macro and its bogus comment.
10080 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10082 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10083 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10085 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10086 We prefer signed types, and the value cannot exceed the EMACS_INT
10087 range anyway (because otherwise the length would not be representable).
10088 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10089 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10090 This avoids a GCC warning when WIDE_EMACS_INT.
10092 * indent.c (sane_tab_width): New function.
10093 (current_column, scan_for_column, Findent_to, position_indentation)
10094 (compute_motion): Use it. This is just for clarity.
10095 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10097 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10099 * lisp.h (lint_assume): New macro.
10100 * composite.c (composition_gstring_put_cache):
10101 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10103 * editfns.c, insdel.c:
10104 Omit unnecessary forward decls, to simplify future changes.
10106 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10108 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10110 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10111 Use much-faster test for byte-length change.
10112 Don't assume string byte-length fits in 'int'.
10113 Check that character arg fits in 'int'.
10114 (mapcar1): Declare byte as byte, for clarity.
10116 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10118 * fns.c (concat): Catch string overflow earlier.
10119 Do not rely on integer wraparound.
10121 * dispextern.h (struct it.overlay_strings_charpos)
10122 (struct it.selective): Now EMACS_INT, not int.
10123 * xdisp.c (forward_to_next_line_start)
10124 (back_to_previous_visible_line_start)
10125 (reseat_at_next_visible_line_start, next_element_from_buffer):
10126 Don't arbitrarily truncate the value of 'selective' to int.
10128 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10130 * composite.c: Don't truncate sizes to 'int'.
10131 (composition_gstring_p, composition_reseat_it)
10132 (composition_adjust_point): Use EMACS_INT, not int.
10133 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10134 not EMACS_UINT, for indexes.
10136 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10138 * buffer.c: Include <verify.h>.
10139 (struct sortvec.priority, struct sortstr.priority):
10140 Now EMACS_INT, not int.
10141 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10142 (struct sortstr.size, record_overlay_string)
10143 (struct sortstrlist.size, struct sortlist.used):
10144 Don't truncate size to int.
10145 (record_overlay_string): Check for size-calculation overflow.
10146 (init_buffer_once): Check at compile-time, not run-time.
10148 2011-06-22 Jim Meyering <meyering@redhat.com>
10150 Don't leak an XBM-image-sized buffer
10151 * image.c (xbm_load): Free the image buffer after using it.
10153 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10156 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10157 that Sun C diagnosed.
10158 * fns.c (secure_hash): Fix pointer signedness issue.
10159 * intervals.c (static_offset_intervals): New function.
10160 (offset_intervals): Use it.
10162 2011-06-21 Leo Liu <sdl.web@gmail.com>
10165 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10168 * fns.c (secure_hash): Rename from crypto_hash_function and change
10169 the first arg to accept symbols.
10170 (Fsecure_hash): New primitive.
10171 (syms_of_fns): New symbols.
10173 2011-06-20 Deniz Dogan <deniz@dogan.se>
10175 * process.c (Fset_process_buffer): Clarify return value in
10178 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10180 * dispnew.c (add_window_display_history): Use BVAR.
10182 * xdisp.c (debug_method_add): Use BVAR.
10183 (check_window_end, dump_glyph_matrix, dump_glyph)
10184 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10186 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10189 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10190 check till after the cache is created in init_frame_faces.
10192 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10194 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10196 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10198 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10199 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10200 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10202 Improve buffer-overflow checking (Bug#8873).
10203 * fileio.c (Finsert_file_contents):
10204 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10205 Remove the old (too-loose) buffer overflow checks.
10206 They weren't needed, since make_gap checks for buffer overflow.
10207 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10208 The old code merely checked for Emacs fixnum overflow, and relied
10209 on undefined (wraparound) behavior. The new code avoids undefined
10210 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10212 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10213 Tune. Don't use wider integers than needed. Don't use alloca.
10214 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10216 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10218 * insdel.c, lisp.h (buffer_overflow): New function.
10219 (insert_from_buffer_1, replace_range, replace_range_2):
10220 * insdel.c (make_gap_larger):
10221 * editfns.c (Finsert_char):
10222 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10224 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10226 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10228 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10230 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10231 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10233 * fileio.c: Don't assume EMACS_INT fits in off_t.
10234 (emacs_lseek): New static function.
10235 (Finsert_file_contents, Fwrite_region): Use it.
10236 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10238 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10240 * fns.c: Don't overflow int when computing a list length.
10241 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10242 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10243 truncation on 64-bit hosts. Check for QUIT every
10244 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10245 faster and is responsive enough.
10246 (Flength): Report an error instead of overflowing an integer.
10247 (Fsafe_length): Return a float if the value is not representable
10248 as a fixnum. This shouldn't happen except in contrived situations.
10249 (Fnthcdr, Fsort): Don't assume list length fits in int.
10250 (Fcopy_sequence): Don't assume vector length fits in int.
10252 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10253 (header_size, word_size): New constants.
10254 (allocate_vectorlike): Don't check size overflow here.
10255 (allocate_vector): Check it here instead, since this is the only
10256 caller of allocate_vectorlike that could cause overflow.
10257 Check that the new vector's length is representable as a fixnum.
10259 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10260 The previous code was bogus. For example, next_almost_prime (32)
10261 returned 39, which is undesirable as it is a multiple of 3; and
10262 next_almost_prime (24) returned 25, which is a multiple of 5 so
10263 why was the code bothering to check for multiples of 7?
10265 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10267 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10269 Variadic C functions now count arguments with ptrdiff_t.
10270 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10271 Back then I didn't know that the Emacs coding style prefers signed int.
10272 Also, in the meantime I found a few more instances where arguments
10273 were being counted with int, which may truncate counts on 64-bit
10274 machines, or EMACS_INT, which may be unnecessarily wide.
10275 * lisp.h (struct Lisp_Subr.function.aMANY)
10276 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10277 Arg counts are now ptrdiff_t, not size_t.
10278 All variadic functions and their callers changed accordingly.
10279 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10280 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10281 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10282 * callint.c (Fcall_interactively): Check arg count for overflow,
10283 to avoid potential buffer overrun. Use signed char, not 'int',
10284 for 'varies' array, so that we needn't bother to check its size
10285 calculation for overflow.
10286 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10287 * eval.c (apply_lambda):
10288 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10289 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10290 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10292 * callint.c (Fcall_interactively): Don't use index var as event count.
10294 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10295 * mem-limits.h (SIZE): Remove; no longer used.
10297 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10299 Remove unnecessary casts.
10300 * xterm.c (x_term_init):
10301 * xfns.c (x_set_border_pixel):
10302 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10303 These aren't needed now that we assume ANSI C.
10305 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10306 It's more likely to cause problems (due to unsigned overflow)
10309 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10311 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10313 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10315 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10317 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10319 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10321 GLYPH_CODE_FACE returns EMACS_INT, not int.
10322 * dispextern.h (merge_faces):
10323 * xfaces.c (merge_faces):
10324 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10325 Don't assume EMACS_INT fits in int.
10327 * character.h (CHAR_VALID_P): Remove unused parameter.
10328 * fontset.c, lisp.h, xdisp.c: All uses changed.
10330 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10332 * fns.c (concat): Minor tuning based on overflow analysis.
10333 This doesn't fix any bugs. Use int to hold character, instead
10334 of constantly refetching from Emacs object. Use XFASTINT, not
10335 XINT, for value known to be a character. Don't bother comparing
10336 a single byte to 0400, as it's always less.
10338 * floatfns.c (Fexpt):
10339 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10341 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10344 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10346 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10347 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10348 incorrectly succeed when S was a string, because 4294967386 was
10349 truncated before it was used.
10351 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10352 Otherwise, an out-of-range integer could cause undefined behavior
10355 * composite.c: Use int, not EMACS_INT, for characters.
10356 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10357 EMACS_INT, for values that are known to be in character range.
10358 This doesn't fix any bugs but is the usual style inside Emacs and
10359 may generate better code on 32-bit machines.
10361 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10362 This is for reasons similar to the recent CHAR_STRING fix.
10363 * charset.c (Fencode_char): Check that character arg is actually
10364 a character. Pass an int to ENCODE_CHAR.
10365 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10366 wider than 'int', as a compile-time check to prevent future regressions
10369 * character.c (char_string): Remove unnecessary casts.
10371 Make sure a 64-bit char is never passed to CHAR_STRING.
10372 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10373 by silently ignoring the top 32 bits, allowing some values
10374 that were far too large to be valid characters.
10375 * character.h: Include <verify.h>.
10376 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10377 arguments are no wider than unsigned, as a compile-time check
10378 to prevent future regressions in this area.
10380 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10381 (Fsubst_char_in_region):
10383 * xdisp.c (decode_mode_spec_coding):
10384 Adjust to CHAR_STRING's new requirement.
10385 * editfns.c (Finsert_char, Fsubst_char_in_region):
10386 * fns.c (concat): Check that character args are actually
10387 characters. Without this test, these functions did the wrong
10388 thing with wildly out-of-range values on 64-bit hosts.
10390 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10391 These casts should not be needed on 32-bit hosts, either.
10392 * keyboard.c (read_char):
10393 * lread.c (Fload): Remove casts to unsigned.
10395 * lisp.h (UNSIGNED_CMP): New macro.
10396 This fixes comparison bugs on 64-bit hosts.
10397 (ASCII_CHAR_P): Use it.
10398 * casefiddle.c (casify_object):
10399 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10400 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10401 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10402 * dispextern.h (FACE_FROM_ID):
10403 * keyboard.c (read_char): Use UNSIGNED_CMP.
10405 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10406 not to EMACS_INT, to avoid GCC warning.
10408 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10410 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10411 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10412 isn't needed on 32-bit machines.
10414 * buffer.c (Fgenerate_new_buffer_name):
10415 Use EMACS_INT for count, not int.
10416 (advance_to_char_boundary): Return EMACS_INT, not int.
10418 * data.c (Qcompiled_function): Now static.
10420 * window.c (window_body_lines): Now static.
10422 * image.c (gif_load): Rename local to avoid shadowing.
10424 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10425 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10426 * alloc.c (make_save_value): Integer argument is now of type
10427 ptrdiff_t, not int.
10428 (mark_object): Use ptrdiff_t, not int.
10429 * lisp.h (pD): New macro.
10430 * print.c (print_object): Use it.
10432 * alloc.c: Use EMACS_INT, not int, to count objects.
10433 (total_conses, total_markers, total_symbols, total_vector_size)
10434 (total_free_conses, total_free_markers, total_free_symbols)
10435 (total_free_floats, total_floats, total_free_intervals)
10436 (total_intervals, total_strings, total_free_strings):
10437 Now EMACS_INT, not int. All uses changed.
10438 (Fgarbage_collect): Compute overall total using a double, so that
10439 integer overflow is less likely to be a problem. Check for overflow
10440 when converting back to an integer.
10441 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10442 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10443 These were 'int' variables that could overflow on 64-bit hosts;
10444 they were never used, so remove them instead of repairing them.
10445 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10446 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10447 Previously, this ceilinged at INT_MAX, but that doesn't work on
10449 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10451 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10452 (allocate_vectorlike): Check for ptrdiff_t overflow.
10453 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10454 when a (possibly-narrower) signed value would do just as well.
10455 We prefer using signed arithmetic, to avoid comparison confusion.
10457 * alloc.c: Catch some string size overflows that we were missing.
10458 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10459 for convenience in STRING_BYTES_MAX.
10460 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10461 The definition here is exact; the one in lisp.h was approximate.
10462 (allocate_string_data): Check for string overflow. This catches
10463 some instances we weren't catching before. Also, it catches
10464 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10465 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10466 and ptrdiff_t and EMACS_INT are both 64 bits.
10468 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10469 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10470 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10472 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10474 * alloc.c (Fmake_string): Check for out-of-range init.
10476 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10478 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10480 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10482 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10483 xg_get_default_scrollbar_width.
10485 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10486 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10487 (style_changed_cb): Call update_theme_scrollbar_width and call
10488 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10489 all frames (Bug#8505).
10490 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10491 Call gtk_window_set_resizable if HAVE_GTK3.
10492 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10493 and height if HAVE_GTK3 (Bug#8505).
10494 (scroll_bar_width_for_theme): New variable.
10495 (update_theme_scrollbar_width): New function.
10496 (xg_get_default_scrollbar_width): Move code to
10497 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10498 (xg_initialize): Call update_theme_scrollbar_width.
10500 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10502 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10504 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10506 * frame.c (make_frame): Call other_buffer_safely instead of
10509 * window.c (temp_output_buffer_show): Call display_buffer with
10510 second argument Vtemp_buffer_show_specifiers and reset latter
10511 immediately after the call.
10512 (Vtemp_buffer_show_specifiers): New variable.
10513 (auto_window_vscroll_p, next_screen_context_lines)
10514 (Vscroll_preserve_screen_position): Remove leading asterisks from
10517 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10519 Fix minor problems found by GCC 4.6.0 static checking.
10520 * buffer.c (Qclone_number): Remove for now, as it's unused.
10521 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10522 (record_buffer): Remove unused local.
10523 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10524 (set_frame_buffer_list): Remove; unused.
10525 * frame.h (other_visible_frames): Remove decl.
10526 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10527 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10528 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10530 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10531 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10532 Define only if HAVE_GPM.
10533 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10534 (update_hints_inhibit): Remove; never set. All uses removed.
10535 * widgetprv.h (emacsFrameClassRec): Remove decl.
10536 * window.c (delete_deletable_window): Now returns void, since it
10537 wasn't returning anything.
10538 (compare_window_configurations): Remove unused locals.
10539 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10540 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10541 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10542 the same widths as pointers. This follows up on the 2011-05-06 patch.
10543 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10544 * xterm.h: Likewise.
10545 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10547 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10549 * makefile.w32-in: Update dependencies.
10550 (LISP_H): Add lib/intprops.h.
10552 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10554 * image.c (gif_load): Add animation frame delay to the metadata.
10555 (syms_of_image): Use DEFSYM. New symbol `delay'.
10557 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10559 * window.c (delete_deletable_window): Re-add.
10560 (Fset_window_configuration): Rewrite to handle dead buffers and
10561 consequently deletable windows.
10562 (window_tree, Fwindow_tree): Remove. Supply functionality in
10564 (compare_window_configurations): Simplify code.
10566 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10568 * image.c (imagemagick_load_image): Fix type mismatch.
10569 (Fimagemagick_types): Likewise.
10571 * window.h (replace_buffer_in_windows): Declare.
10573 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10575 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10576 Qclone_number. Remove external declaration of Qdelete_window.
10577 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10579 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10580 Run Qbuffer_list_update_hook if allowed.
10581 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10582 buffer list implementation.
10583 (other_buffer_safely): New function.
10584 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10585 calls to replace_buffer_in_windows and
10586 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10588 (record_buffer): Inhibit quitting and rewrite using quittable
10589 functions. Run Qbuffer_list_update_hook if allowed.
10590 (Frecord_buffer, Funrecord_buffer): New functions.
10591 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10592 Move switch-to-buffer to window.el.
10593 (bury-buffer): Move to window.el.
10594 (Vbuffer_list_update_hook): New variable.
10596 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10599 * window.h (resize_frame_windows): Move up in code.
10600 (Fwindow_frame): Remove EXFUN.
10601 (replace_buffer_in_all_windows): Remove prototype.
10602 (replace_buffer_in_windows_safely): Add prototype.
10604 * window.c: Declare Qdelete_window static again. Move down
10605 declaration of select_count.
10606 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10607 (Fother_window): Move to window.el.
10608 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10609 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10610 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10612 (replace_buffer_in_windows): Implement by calling
10613 Qreplace_buffer_in_windows.
10614 (replace_buffer_in_all_windows): Remove with some functionality
10615 moved into replace_buffer_in_windows_safely.
10616 (replace_buffer_in_windows_safely): New function.
10617 (select_window_norecord, select_frame_norecord): Move in front
10618 of run_window_configuration_change_hook. Remove now obsolete
10620 (Fset_window_buffer): Rewrite doc-string.
10621 Call Qrecord_window_buffer.
10622 (keys_of_window): Move binding for other-window to window.el.
10624 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10626 * dispextern.h (struct image): Replace data member, whose int_val
10627 and ptr_val fields were not used by anything, with a single
10630 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10631 (gif_clear_image, gif_load, imagemagick_load_image)
10632 (gs_clear_image, gs_load): Callers changed.
10634 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10636 * buffer.h: Include <time.h>, for time_t.
10637 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10639 Fix minor problems found by static checking.
10641 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10643 Make identifiers static if they are not used in other modules.
10644 * data.c (Qcompiled_function, Qframe, Qvector):
10645 * image.c (QimageMagick, Qsvg):
10646 * minibuf.c (Qmetadata):
10647 * window.c (resize_window_check, resize_root_window): Now static.
10648 * window.h (resize_window_check, resize_root_window): Remove decls.
10650 * window.c (window_deletion_count, delete_deletable_window):
10652 (window_body_lines): Now static.
10653 (Fdelete_other_windows_internal): Mark vars as initialized.
10654 Make sure 'resize_failed' is initialized.
10655 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10656 (resize_window_apply): Remove unused local.
10657 * window.h (delete_deletable_window): Remove decl.
10659 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10660 (imagemagick_load_image): Fix pointer signedness problem by changing
10661 last arg from unsigned char * to char *. All uses changed.
10662 Also, fix a local for similar reasons.
10663 Remove unused locals. Remove locals to avoid shadowing.
10664 (fn_rsvg_handle_free): Remove; unused.
10665 (svg_load, svg_load_image): Fix pointer signedness problem.
10666 (imagemagick_load_image): Don't use garbage pointer image_wand.
10668 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10670 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10672 * image.c (gif_load): Fix omitted cast error introduced by
10675 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10677 * window.h (resize_proportionally, orig_total_lines)
10678 (orig_top_line): Remove from window structure.
10679 (set_window_height, set_window_width, change_window_heights)
10680 (Fdelete_window): Remove prototypes.
10681 (resize_frame_windows): Remove duplicate declaration.
10683 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10685 * window.h (resize_frame_windows, resize_window_check)
10686 (delete_deletable_window, resize_root_window)
10687 (resize_frame_windows): Declare prototypes.
10689 * window.c (resize_window_apply): Make definition be "static" to
10690 match the prototype.
10692 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10694 * window.c: Remove declarations of Qwindow_size_fixed,
10695 window_min_size_1, window_min_size_2, window_min_size,
10696 size_window, window_fixed_size_p, enlarge_window, delete_window.
10697 Remove static from declaration of Qdelete_window, it's
10698 temporarily needed by Fbury_buffer.
10699 (replace_window): Don't assign orig_top_line and
10701 (Fdelete_window, delete_window): Remove. Window deletion is
10702 handled by window.el.
10703 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10704 Replace Fdelete_window calls with calls to Qdelete_window.
10705 (Fdelete_other_windows): Remove. Deleting other windows is
10706 handled by window.el.
10707 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10708 handled in window.el.
10709 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10710 Window minimum sizes are handled in window.el.
10711 (shrink_windows, size_window, set_window_height)
10712 (set_window_width, change_window_heights, window_height)
10713 (window_width, CURBEG, CURSIZE, enlarge_window)
10714 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10715 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10716 handled in window.el.
10717 (make_dummy_parent): Rename to make_parent_window and give it a
10718 second argument horflag.
10719 (make_window): Don't set resize_proportionally any more.
10720 (Fsplit_window): Remove. Windows are split in window.el.
10721 (save_restore_action, save_restore_orig_size)
10722 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10723 Resize mini windows in window.el.
10724 (grow_mini_window, shrink_mini_window): Implement by calling
10725 Qresize_root_window_vertically, resize_window_check and
10726 resize_window_apply.
10727 (saved_window, Fset_window_configuration, save_window_save):
10728 Do not handle orig_top_line, orig_total_lines, and
10729 resize_proportionally.
10730 (window_min_height, window_min_width): Move to window.el.
10731 (keys_of_window): Move bindings for delete-other-windows,
10732 split-window, delete-window and enlarge-window to window.el.
10734 * buffer.c: Temporarily extern Qdelete_window.
10735 (Fbury_buffer): Temporarily call Qdelete_window instead of
10736 Fdelete_window (Fbury_buffer will move to window.el soon).
10738 * frame.c (set_menu_bar_lines_1): Remove code handling
10739 orig_top_line and orig_total_lines.
10741 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10742 set_window_height but set heights directly.
10743 (change_frame_size_1): Use resize_frame_windows.
10745 * xdisp.c (init_xdisp): Don't use set_window_height but set
10748 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10749 Use resize_frame_windows instead of change_window_heights and run
10750 run_window_configuration_change_hook.
10752 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10753 instead of change_window_heights and run
10754 run_window_configuration_change_hook.
10756 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10758 * window.c (replace_window): Rename second argument REPLACEMENT to
10759 NEW. New third argument SETFLAG. Rewrite.
10760 (delete_window, make_dummy_parent): Call replace_window with
10762 (window_list_1): Move down in code.
10763 (run_window_configuration_change_hook): Move set_buffer part
10764 before select_frame_norecord part in order to unwind correctly.
10765 Rename count1 to count.
10766 (recombine_windows, delete_deletable_window, resize_root_window)
10767 (Fdelete_other_windows_internal)
10768 (Frun_window_configuration_change_hook, make_parent_window)
10769 (resize_window_check, resize_window_apply, Fresize_window_apply)
10770 (resize_frame_windows, Fsplit_window_internal)
10771 (Fdelete_window_internal, Fresize_mini_window_internal):
10773 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10775 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10777 * window.h (window): Add some new members to window structure -
10778 normal_lines, normal_cols, new_total, new_normal, clone_number,
10779 splits, nest, prev_buffers, next_buffers.
10780 (WINDOW_TOTAL_SIZE): Move here from window.c.
10781 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10783 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10785 (make_dummy_parent): Set new members of windows structure.
10786 (make_window): Move down in code. Handle new members of window
10788 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10789 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10790 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10791 (Fset_window_prev_buffers, Fwindow_next_buffers)
10792 (Fset_window_next_buffers, Fset_window_clone_number):
10794 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10795 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10797 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10798 Argument WINDOW can be now internal window too.
10799 (Fwindow_use_time): Move up in code.
10800 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10801 Rewrite doc-string.
10802 (Fset_window_configuration, saved_window)
10803 (Fcurrent_window_configuration, save_window_save): Handle new
10804 members of window structure.
10805 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10806 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10807 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10808 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10809 Qget_mru_window, Qresize_root_window,
10810 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10811 Qauto_buffer_name; staticpro them.
10813 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10815 * window.c (Fwindow_total_size, Fwindow_left_column)
10816 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10817 (Fwindow_list_1): New functions.
10818 (window_box_text_cols): Replace with window_body_cols.
10819 (Fwindow_width, Fscroll_left, Fscroll_right):
10820 Use window_body_cols instead of window_box_text_cols.
10821 (delete_window, Fset_window_configuration):
10822 Call delete_all_subwindows with window as argument.
10823 (delete_all_subwindows): Take a window as argument and not a
10824 structure. Rewrite.
10825 (window_loop): Remove handling of GET_LRU_WINDOW and
10826 GET_LARGEST_WINDOW.
10827 (Fget_lru_window, Fget_largest_window): Move to window.el.
10829 * window.h: Extern window_body_cols instead of
10830 window_box_text_cols. delete_all_subwindows now takes a
10831 Lisp_Object as argument.
10833 * indent.c (compute_motion, Fcompute_motion):
10834 Use window_body_cols instead of window_box_text_cols.
10836 * frame.c (delete_frame): Call delete_all_subwindows with root
10837 window as argument.
10839 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10841 * fns.c (Fputhash): Document return value.
10843 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10845 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10847 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10849 Cons<->int and similar integer overflow fixes (Bug#8794).
10851 Check for overflow when converting integer to cons and back.
10852 * charset.c (Fdefine_charset_internal, Fdecode_char):
10853 Use cons_to_unsigned to catch overflow.
10854 (Fencode_char): Use INTEGER_TO_CONS.
10855 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10856 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10857 * data.c (long_to_cons, cons_to_long): Remove.
10858 (cons_to_unsigned, cons_to_signed): New functions.
10859 These signal an error for invalid or out-of-range values.
10860 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10861 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10862 * font.c (Ffont_variation_glyphs):
10863 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10864 * lisp.h: Include <intprops.h>.
10865 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10866 (cons_to_signed, cons_to_unsigned): New decls.
10867 (long_to_cons, cons_to_long): Remove decls.
10868 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10869 (Fprimitive_undo): Use CONS_TO_INTEGER.
10870 * xfns.c (Fx_window_property): Likewise.
10871 * xselect.c: Include <limits.h>.
10872 (x_own_selection, selection_data_to_lisp_data):
10873 Use INTEGER_TO_CONS.
10874 (x_handle_selection_request, x_handle_selection_clear)
10875 (x_get_foreign_selection, Fx_disown_selection_internal)
10876 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10877 (lisp_data_to_selection_data): Use cons_to_unsigned.
10878 (x_fill_property_data): Use cons_to_signed.
10879 Report values out of range.
10881 Check for buffer and string overflow more precisely.
10882 * buffer.h (BUF_BYTES_MAX): New macro.
10883 * lisp.h (STRING_BYTES_MAX): New macro.
10884 * alloc.c (Fmake_string):
10885 * character.c (string_escape_byte8):
10886 * coding.c (coding_alloc_by_realloc):
10887 * doprnt.c (doprnt):
10888 * editfns.c (Fformat):
10890 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10891 since they may not be the same number.
10892 * editfns.c (Finsert_char):
10893 * fileio.c (Finsert_file_contents):
10894 Likewise for BUF_BYTES_MAX.
10896 * image.c: Use ptrdiff_t, not int, for sizes.
10897 (slurp_file): Switch from int to ptrdiff_t.
10899 (slurp_file): Check that file size fits in both size_t (for
10900 malloc) and ptrdiff_t (for sanity and safety).
10902 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10903 if b->modtime has its maximal value.
10905 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10907 Don't assume time_t can fit into int.
10908 * buffer.h (struct buffer.modtime): Now time_t, not int.
10909 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10910 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10912 Minor fixes for signed vs unsigned integers.
10913 * character.h (MAYBE_UNIFY_CHAR):
10914 * charset.c (maybe_unify_char):
10915 * keyboard.c (read_char, reorder_modifiers):
10916 XINT -> XFASTINT, since the integer must be nonnegative.
10917 * ftfont.c (ftfont_spec_pattern):
10918 * keymap.c (access_keymap, silly_event_symbol_error):
10919 XUINT -> XFASTINT, since the integer must be nonnegative.
10920 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10921 since it makes no difference and we prefer signed.
10922 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10923 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10926 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10928 * window.h (Fwindow_frame): Declare.
10930 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10932 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10933 (SPARE_MEMORY): Always define.
10934 (LARGE_REQUEST): Remove.
10935 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10937 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10939 * lisp.h: Move EXFUNS for Fframe_root_window,
10940 Fframe_first_window and Fset_frame_selected_window to window.h.
10942 * window.h: Move EXFUNS for Fframe_root_window,
10943 Fframe_first_window and Fset_frame_selected_window here from
10946 * frame.c (Fwindow_frame, Fframe_first_window)
10947 (Fframe_root_window, Fframe_selected_window)
10948 (Fset_frame_selected_window): Move to window.c.
10949 (Factive_minibuffer_window): Move to minibuf.c.
10950 (Fother_visible_frames_p): New function.
10952 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10954 * window.c (decode_window, decode_any_window): Move up in code.
10955 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10956 (inhibit_frame_unsplittable): Remove unused variable.
10957 (Fwindow_buffer): Move up and rewrite doc-string.
10958 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10959 (Fwindow_prev): New functions.
10960 (Fwindow_frame): Move here from frame.c. Accept any window as
10962 (Fframe_root_window, Fframe_first_window)
10963 (Fframe_selected_window): Move here from frame.c. Accept frame
10964 or arbitrary window as argument. Update doc-strings.
10965 (Fminibuffer_window): Move up in code.
10966 (Fwindow_minibuffer_p): Move up in code and simplify.
10967 (Fset_frame_selected_window): Move here from frame.c.
10969 (Fselected_window, select_window, Fselect_window): Move up in
10970 code. Minor doc-string fixes.
10972 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10974 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10975 Do not assume that spare memory exists; that assumption is valid
10976 only if SYSTEM_MALLOC.
10977 (LARGE_REQUEST): New macro, so that the issue of large requests
10978 is separated from the issue of spare memory.
10980 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10982 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10985 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10987 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10990 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10992 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10994 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10996 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10997 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10999 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
11001 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11003 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
11005 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11006 (x_clipboard_manager_save): Add return value.
11007 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11008 New error handlers.
11009 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11010 Obey Vx_select_enable_clipboard_manager. Catch errors in
11011 x_clipboard_manager_save (Bug#8779).
11012 (Vx_select_enable_clipboard_manager): New variable.
11013 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
11015 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
11017 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11019 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11021 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11022 in the current matrix if keep_current_p is non-zero.
11024 2011-06-04 Eli Zaretskii <eliz@gnu.org>
11026 * bidi.c (bidi_level_of_next_char): Fix last change.
11028 2011-06-03 Eli Zaretskii <eliz@gnu.org>
11030 Support bidi reordering of text covered by display properties.
11032 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11033 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11034 (bidi_cache_search, bidi_cache_iterator_state)
11035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11036 (bidi_level_of_next_char, bidi_move_to_visually_next):
11037 Support character positions inside a run of characters covered by a
11039 (bidi_paragraph_init, bidi_resolve_explicit_1)
11040 (bidi_level_of_next_char): Call bidi_fetch_char and
11041 bidi_fetch_char_advance instead of FETCH_CHAR and
11042 FETCH_CHAR_ADVANCE.
11043 (bidi_init_it): Initialize new members.
11044 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11046 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11047 instead of using explicit *_CHAR codes.
11048 (bidi_resolve_explicit, bidi_resolve_weak):
11049 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11050 bidirectional text is supported only in multibyte buffers.
11051 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11052 it to initialize the frame_window_p member of struct bidi_it.
11053 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11054 (bidi_resolve_explicit, bidi_resolve_weak)
11055 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11056 bidi_it->nchars is non-positive.
11057 (bidi_level_of_next_char): Don't try to lookup the cache for the
11058 next/previous character if nothing is cached there yet, or if we
11059 were just reseat()'ed to a new position.
11061 * xdisp.c (set_cursor_from_row): Set start and stop points
11062 according to the row's direction when priming the loop that looks
11063 for the glyph on which to display cursor.
11064 (single_display_spec_intangible_p): Function deleted.
11065 (display_prop_intangible_p): Reimplement to call
11066 handle_display_spec instead of single_display_spec_intangible_p.
11067 Accept 3 additional arguments needed by handle_display_spec.
11068 This fixes incorrect cursor motion across display property with complex
11069 values: lists, `(when COND...)' forms, etc.
11070 (single_display_spec_string_p): Support property values that are
11071 lists with the argument STRING its top-level element.
11072 (display_prop_string_p): Fix the condition for processing a
11073 property that is a list to be consistent with handle_display_spec.
11074 (handle_display_spec): New function, refactored from the
11075 last portion of handle_display_prop.
11076 (compute_display_string_pos): Accept additional argument
11077 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11078 value of a `display' property is a "replacing spec".
11079 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11080 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11081 the display property, but just return a value indicating whether
11082 the display property will replace the characters it covers.
11083 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11084 frame_window_p members of struct bidi_it.
11085 (compute_display_string_pos, compute_display_string_end):
11087 (push_it): Accept second argument POSITION, where pop_it should
11088 jump to continue iteration.
11089 (reseat_1): Initialize bidi_it.disp_pos.
11091 * keyboard.c (adjust_point_for_property): Adjust the call to
11092 display_prop_intangible_p to its new signature.
11094 * dispextern.h (struct bidi_it): New member frame_window_p.
11095 (bidi_init_it): Update prototypes.
11096 (display_prop_intangible_p): Update prototype.
11097 (compute_display_string_pos, compute_display_string_end):
11098 Declare prototypes.
11099 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11102 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11104 Malloc failure behavior now depends on size of allocation.
11105 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11106 * lisp.h: Change signatures accordingly.
11107 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11108 All callers changed. (Bug#8762)
11110 * gnutls.c: Use Emacs's memory allocators.
11111 Without this change, the gnutls library would invoke malloc etc.
11112 directly, which causes problems on non-SYNC_INPUT hosts, and which
11113 runs afoul of improving memory_full behavior. (Bug#8761)
11114 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11115 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11116 xfree instead of the default malloc, realloc, free.
11117 (Fgnutls_boot): No need to check for memory allocation failure,
11118 since xmalloc does that for us.
11120 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11121 * category.c (hash_get_category_set):
11122 * ccl.c (ccl_driver):
11123 * charset.c (Fdefine_charset_internal):
11124 * charset.h (struct charset.hash_index):
11125 * composite.c (get_composition_id, gstring_lookup_cache)
11126 (composition_gstring_put_cache):
11127 * composite.h (struct composition.hash_index):
11128 * dispextern.h (struct image.hash):
11129 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11130 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11131 (hashfn_equal, hashfn_user_defined, make_hash_table)
11132 (maybe_resize_hash_table, hash_lookup, hash_put)
11133 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11134 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11135 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11136 * image.c (make_image, search_image_cache, lookup_image)
11137 (xpm_put_color_table_h):
11138 * lisp.h (struct Lisp_Hash_Table):
11139 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11140 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11141 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11142 * alloc.c (allocate_vectorlike):
11143 Check for overflow in vector size calculations.
11144 * ccl.c (ccl_driver):
11145 Check for overflow when converting EMACS_INT to int.
11146 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11147 need to be updated by these changes.
11148 * fns.c (make_hash_table, maybe_resize_hash_table):
11149 Check for integer overflow with large hash tables.
11150 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11151 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11152 (SXHASH_REDUCE): New macro.
11153 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11154 Use it instead of discarding useful hash info with large hash values.
11155 (sxhash_float): New function.
11156 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11157 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11158 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11159 Rewrite to use FIXNUM_BITS, as this simplifies things.
11160 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11161 Adjust signatures to match updated version of code.
11162 (consing_since_gc): Now EMACS_INT, since a single hash table can
11163 use more than INT_MAX bytes.
11165 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11167 Make it possible to build with GCC-4.6+ -O2 -flto.
11169 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11171 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11173 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11174 Call minibuffer-inactive-mode.
11176 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11178 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11179 Update dependencies.
11181 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11183 * data.c (init_data): Remove code for UTS, this system is not
11186 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11188 Don't force ./temacs to start in terminal mode.
11190 * frame.c (make_initial_frame): Initialize faces in all cases, not
11191 only when CANNOT_DUMP is defined.
11192 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11194 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11196 * dispnew.c (add_window_display_history): Use const for the string
11197 pointer. Remove declaration, not needed.
11199 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11201 Use 'inline', not 'INLINE'.
11202 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11203 * alloc.c, fontset.c (INLINE): Remove.
11204 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11205 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11206 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11207 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11208 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11210 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11212 Make it possible to run ./temacs.
11214 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11215 syms_of_callproc does the same thing. Remove test for
11216 "initialized", do it in the caller.
11217 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11219 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11221 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11222 (read_minibuf): Use get_minibuffer.
11223 (syms_of_minibuf): Use DEFSYM.
11224 (Qmetadata): New var.
11225 * data.c (Qbuffer): Don't make it static.
11226 (syms_of_data): Use DEFSYM.
11228 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11230 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11231 (CCL_CODE_MIN): New macro.
11233 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11235 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11237 * eval.c (Qdebug): Now static.
11238 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11239 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11240 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11242 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11244 * image.c: Various fixes to ImageMagick code comments.
11245 (Fimagemagick_types): Doc fix.
11247 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11249 Minor fixes prompted by GCC 4.6.0 warnings.
11251 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11253 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11254 (x_clipboard_manager_save_all): Move extern decl to ...
11255 * xterm.h: ... here, so that it can be checked for consistency.
11257 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11259 * xselect.c (x_clipboard_manager_save_frame)
11260 (x_clipboard_manager_save_all): New functions.
11261 (Fx_clipboard_manager_save): Lisp function deleted.
11263 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11264 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11266 * xterm.h: Update prototype.
11268 2011-05-28 William Xu <william.xwl@gmail.com>
11270 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11271 exiting (Bug#8239).
11273 2011-05-28 Jim Meyering <meyering@redhat.com>
11275 Avoid a sign-extension bug in crypto_hash_function.
11276 * fns.c (to_uchar): Define.
11277 (crypto_hash_function): Use it to convert some newly-signed
11278 variables to unsigned, to avoid sign-extension bugs. For example,
11279 without this change, (md5 "truc") would evaluate to
11280 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11281 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11282 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11284 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11286 Integer overflow fixes.
11288 * dbusbind.c: Serial number integer overflow fixes.
11289 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11290 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11291 to hold a serial number that is too large for a fixnum.
11292 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11293 Check for serial numbers out of range. Decode any serial number
11294 that was so large that it became a float. (Bug#8722)
11296 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11297 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11298 Use XFASTINT rather than XUINT when numbers are nonnegative.
11299 (xd_append_arg, Fdbus_method_return_internal):
11300 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11301 arguments, check that Lisp number is nonnegative, rather than
11302 silently wrapping negative numbers around. (Bug#8722)
11303 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11306 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11308 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11310 ccl: Add integer overflow checks.
11311 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11312 (IN_INT_RANGE): New macros.
11313 (ccl_driver): Use them to check for integer overflow when
11314 decoding a CCL program. Many of the new checks are whether XINT (x)
11315 fits in int; it doesn't always, on 64-bit hosts. The new version
11316 doesn't catch all possible integer overflows, but it's an
11317 improvement. (Bug#8719)
11319 * alloc.c (make_event_array): Use XINT, not XUINT.
11320 There's no need for unsigned here.
11322 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11323 This follows up to the 2011-05-06 change that substituted uintptr_t
11324 for EMACS_INT. This case wasn't caught back then.
11326 Rework Fformat to avoid integer overflow issues.
11327 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11328 now (part of C89). Include <verify.h>.
11329 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11330 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11331 (Fformat): Avoid the prepass trying to compute sizes; it was only
11332 approximate and thus did not catch overflow reliably. Instead, walk
11333 through the format just once, formatting and computing sizes as we go,
11334 checking for integer overflow at every step, and allocating a larger
11335 buffer as needed. Keep track separately whether the format is
11336 multibyte. Keep only the most-recently calculated precision, rather
11337 than them all. Record whether each argument has been converted to
11338 string. Use EMACS_INT, not int, for byte and char and arg counts.
11339 Support field widths and precisions larger than INT_MAX. Avoid
11340 sprintf's undefined behavior with conversion specifications such as %#d
11341 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11342 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11343 formatting out-of-range floating point numbers with int
11344 formats. (Bug#8668)
11346 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11348 * data.c: Avoid integer truncation in expressions involving floats.
11349 * data.c: Include <intprops.h>.
11350 (arith_driver): When there's an integer overflow in an expression
11351 involving floating point, convert the integers to floating point
11352 so that the resulting value does not suffer from catastrophic
11353 integer truncation. For example, on a 64-bit host (* 4
11354 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11355 Do not rely on undefined behavior after integer overflow.
11357 merge count_size_as_multibyte, parse_str_to_multibyte
11358 * character.c, character.h (count_size_as_multibyte):
11359 Rename from parse_str_to_multibyte; all uses changed.
11360 Check for integer overflow.
11361 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11362 since it's now a duplicate of the other. This is more of
11363 a character than a buffer op, so better that it's in character.c.
11364 * fns.c, print.c: Adjust to above changes.
11366 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11368 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11370 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11372 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11373 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11374 (x_clipboard_manager_save): Now static.
11375 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11377 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11378 (crypto_hash_function): Now static.
11379 Fix pointer signedness problems. Avoid unnecessary initializations.
11381 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11383 * termhooks.h (Vselection_alist): Make it terminal-local.
11385 * terminal.c (create_terminal): Initialize it.
11387 * xselect.c: Support for clipboard managers.
11388 (Vselection_alist): Move to termhooks.h as terminal-local var.
11389 (LOCAL_SELECTION): New macro.
11390 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11391 (symbol_to_x_atom): Remove gratuitous arg.
11392 (x_handle_selection_request, lisp_data_to_selection_data)
11393 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11394 (x_own_selection, x_get_local_selection, x_convert_selection):
11395 New arg, specifying work frame. Use terminal-local Vselection_alist.
11396 (some_frame_on_display): Delete unused function.
11397 (Fx_own_selection_internal, Fx_get_selection_internal)
11398 (Fx_disown_selection_internal, Fx_selection_owner_p)
11399 (Fx_selection_exists_p): New optional frame arg.
11400 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11401 (x_handle_selection_clear): Don't treat other terminals with the
11402 same keyboard specially. Use the terminal-local Vselection_alist.
11403 (x_clear_frame_selections): Use Frun_hook_with_args.
11405 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11407 * xterm.h: Add support for those atoms.
11409 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11411 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11412 (converted_selections, conversion_fail_tag): New global variables.
11413 (x_selection_request_lisp_error): Free the above.
11414 (x_get_local_selection): Remove unnecessary code.
11415 (x_reply_selection_request): Args changed; handle arbitrary array
11416 of converted selections stored in converted_selections.
11417 Separate the XChangeProperty and SelectionNotify steps.
11418 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11419 (x_convert_selection): New function.
11420 (x_handle_selection_event): Simplify.
11421 (x_get_foreign_selection): Don't ignore incoming requests while
11422 waiting for an answer; this will fail when we implement
11423 SAVE_TARGETS, and seems unnecessary anyway.
11424 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11425 (Vx_sent_selection_functions): Doc fix.
11427 2011-05-26 Leo Liu <sdl.web@gmail.com>
11429 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11431 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11433 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11435 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11436 for fringe update if it has periodic bitmap.
11437 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11438 and fringe_bitmap_periodic_p.
11440 * fringe.c (get_fringe_bitmap_data): New function.
11441 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11442 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11443 row. Mark glyph row for fringe update if periodicity changed.
11445 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11446 for fringe update unless it has periodic bitmap.
11448 2011-05-25 Kenichi Handa <handa@m17n.org>
11450 * xdisp.c (get_next_display_element): Set correct it->face_id for
11451 a static composition.
11453 2011-05-24 Leo Liu <sdl.web@gmail.com>
11456 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11458 * fns.c (crypto_hash_function, Fsha1): New function.
11459 (Fmd5): Use crypto_hash_function.
11460 (syms_of_fns): Add Ssha1.
11462 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11464 * gnutls.c: Remove unused macros.
11465 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11466 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11467 Remove macros that are defined and never used.
11468 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11470 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11472 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11473 (Fx_get_selection_internal): Minor cleanup.
11474 (Fx_own_selection_internal): Rename arguments for consistency with
11477 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11479 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11481 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11483 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11485 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11487 * dispnew.c (scrolling_window): Don't exclude the case that the
11488 last enabled row in the desired matrix touches the bottom boundary.
11490 2011-05-21 Glenn Morris <rgm@gnu.org>
11492 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11493 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11494 and add some more files.
11496 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11498 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11499 report_file_error introduced by the change from 2011-05-07.
11501 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11503 * systime.h (Time): Define only if emacs is defined.
11504 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11505 where the include path doesn't have X11/X.h by default. See
11506 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11508 2011-05-20 Kenichi Handa <handa@m17n.org>
11510 * composite.c (find_automatic_composition): Fix previous change.
11512 2011-05-20 Glenn Morris <rgm@gnu.org>
11514 * lisp.mk: New file, split from Makefile.in.
11515 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11516 (shortlisp): Remove.
11517 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11519 2011-05-19 Glenn Morris <rgm@gnu.org>
11521 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11522 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11523 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11524 (lisp): Set the order to that of loadup.el.
11525 (shortlisp): Make it a copy of $lisp.
11526 (SOME_MACHINE_LISP): Remove.
11527 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11528 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11530 2011-05-18 Kenichi Handa <handa@m17n.org>
11532 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11533 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11534 (find_automatic_composition): Mostly rewrite for efficiency.
11536 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11538 * makefile.w32-in: Update dependencies.
11540 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11542 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11543 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11545 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11547 Fix some integer overflow issues, such as string length overflow.
11549 * insdel.c (count_size_as_multibyte): Check for string overflow.
11551 * character.c (lisp_string_width): Check for string overflow.
11552 Use EMACS_INT, not int, for string indexes and lengths; in
11553 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11554 the resulting string length overflows an EMACS_INT; instead,
11555 report a string overflow if no precision given. When checking for
11556 precision exhaustion, use a check that cannot possibly have
11557 integer overflow. (Bug#8675)
11558 * character.h (lisp_string_width): Adjust to new signature.
11560 * alloc.c (string_overflow): New function.
11561 (Fmake_string): Use it. This doesn't change behavior, but saves
11562 a few bytes and will simplify future changes.
11563 * character.c (string_escape_byte8): Likewise.
11564 * lisp.h (string_overflow): New decl.
11566 Fixups, following up to the user-interface timestamp change.
11567 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11568 for UI timestamps, instead of unsigned long.
11569 * msdos.c (mouse_get_pos): Likewise.
11570 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11571 * w32gui.h (Time): Define by including "systime.h" rather than by
11572 declaring it ourselves. (Bug#8664)
11574 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11575 * image.c (clear_image_cache): Likewise.
11577 * term.c (term_mouse_position): Don't assume time_t wraparound.
11579 Be more systematic about user-interface timestamps.
11580 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11581 and sometimes 'EMACS_UINT', to represent these timestamps.
11582 This change causes it to use 'Time' uniformly, as that's what X uses.
11583 This makes the code easier to follow, and makes it easier to catch
11584 integer overflow bugs such as Bug#8664.
11585 * frame.c (Fmouse_position, Fmouse_pixel_position):
11586 Use Time, not unsigned long, for user-interface timestamps.
11587 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11588 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11589 * keyboard.h (last_event_timestamp): Likewise.
11590 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11591 * menu.h (xmenu_show): Likewise.
11592 * term.c (term_mouse_position): Likewise.
11593 * termhooks.h (struct input_event.timestamp): Likewise.
11594 (struct terminal.mouse_position_hook): Likewise.
11595 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11596 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11597 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11598 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11599 what it was before.
11600 * menu.h, termhooks.h: Include "systime.h", for Time.
11602 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11603 Don't assume that the difference between two unsigned long values
11604 can fit into an integer. At this point, we know button_down_time
11605 <= event->timestamp, so the difference must be nonnegative, so
11606 there's no need to cast the result if double-click-time is
11607 nonnegative, as it should be; check that it's nonnegative, just in
11608 case. This bug is triggered when events are more than 2**31 ms
11609 apart (about 25 days). (Bug#8664)
11611 * xselect.c (last_event_timestamp): Remove duplicate decl.
11612 (x_own_selection): Remove needless cast to unsigned long.
11614 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11615 that always fit in int. Use a sentinel instead of a counter, to
11616 avoid a temp and to allay GCC's concerns about possible int overflow.
11617 * frame.h (struct frame): Use int for menu_bar_items_used
11618 instead of EMACS_INT, since it always fits in int.
11620 * menu.c (grow_menu_items): Check for int overflow.
11622 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11624 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11625 Before, the code was not consistent. These values cannot exceed
11626 2**31 - 1 so there's no need to make them unsigned.
11627 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11628 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11629 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11631 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11633 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11634 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11635 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11636 presumably because the widths might not match.
11638 * window.c (size_window): Avoid needless test at loop start.
11640 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11642 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11644 2011-05-12 Drew Adams <drew.adams@oracle.com>
11646 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11648 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11650 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11651 `width' to `bar_area_x' and `bar_area_width', respectively.
11652 (x_scroll_run): Take account of fringe background extension.
11654 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11655 Rename local vars `left' and `width' to `bar_area_x' and
11656 `bar_area_width', respectively.
11657 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11658 background extension.
11660 2011-05-10 Jim Meyering <meyering@redhat.com>
11662 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11664 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11666 * image.c (Finit_image_library): Return t for built-in image types,
11667 like pbm and xbm. (Bug#8640)
11669 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11671 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11673 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11675 * w32console.c (Fset_screen_color): Doc fix.
11676 (Fget_screen_color): New function.
11677 (syms_of_ntterm): Defsubr it.
11679 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11680 unlink the temporary file if Fcall_process didn't create it in the
11682 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11683 child process will be redirected to a file specified with `:file'.
11684 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11685 cue to call_process_cleanup not to close that handle.
11687 2011-05-07 Ben Key <bkey76@gmail.com>
11689 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11690 one of two shell specific rules, either bootstrap-temacs-CMD or
11691 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11692 to the previous implementation of the bootstrap-temacs rule.
11693 The bootstrap-temacs-CMD rule is similar to the previous
11694 implementation of the bootstrap-temacs rule except that it
11695 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11698 These changes, along with some changes to nt/configure.bat,
11699 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11700 earlier fix to add support for --cflags and --ldflags options
11701 that include quotes so that it works whether make uses cmd or
11704 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11706 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11707 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11709 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11710 a string. Handle both cases.
11711 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11712 (Fdbus_register_method): Use Qinvalid_function.
11714 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11716 * makefile.w32-in: Update dependencies.
11717 (LISP_H): Add inttypes.h and stdin.h.
11718 (PROCESS_H): Add unistd.h.
11720 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11722 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11723 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11725 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11727 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11729 * term.c (vfatal): Remove stray call to va_end.
11730 It's not needed and the C Standard doesn't allow it here anyway.
11732 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11733 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11735 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11738 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11740 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11742 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11744 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11746 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11748 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11749 * charset.c (Fdefine_charset_internal): Don't initialize
11750 charset.code_space[15]. The value was garbage, on hosts with
11751 32-bit int (Bug#8600).
11753 * lread.c (read_integer): Be more consistent with string-to-number.
11754 Use string_to_number to do the actual conversion; this avoids
11755 rounding errors and fixes some other screwups. Without this fix,
11756 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11757 (digit_to_number): Move earlier, for benefit of read_integer.
11758 Return -1 if the digit is out of range for the base, -2 if it is
11759 not a digit in any supported base. (Bug#8602)
11761 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11763 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11764 to match comment at start of function. This also removes a
11765 GCC warning about overflow in a 32+64-bit port.
11767 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11769 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11770 Reported by Stefan Monnier in
11771 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11772 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11773 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11775 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11776 (EMACS_UINTPTR): Likewise, with uintptr_t.
11778 * lisp.h: Prefer 64-bit EMACS_INT if available.
11779 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11780 on 32-bit hosts that have 64-bit int, so that they can access
11782 However, temporarily disable this change unless the temporary
11783 symbol WIDE_EMACS_INT is defined.
11785 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11787 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11788 This removes an assumption that EMACS_INT and long are the same
11789 width as pointers. The assumption is true for Emacs porting targets
11790 now, but we want to make other targets possible.
11791 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11792 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11793 In the rest of the code, change types of integers that hold casted
11794 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11795 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11796 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11797 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11798 No need to cast type when ORing.
11799 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11800 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11801 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11802 assume EMACS_INT is the same width as char *.
11803 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11804 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11805 Remove no-longer-needed casts.
11806 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11807 (xg_tool_bar_help_callback, xg_make_tool_item):
11808 Use EMACS_INTPTR to hold an integer
11809 that will be cast to void *; this can avoid a GCC warning
11810 if EMACS_INT is not the same width as void *.
11811 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11812 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11813 (current_message_1, set_message_1):
11814 Use a local to convert to proper width without a cast.
11815 * xmenu.c (dialog_selection_callback): Likewise.
11817 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11818 Also, don't assume VALBITS / RAND_BITS is less than 5,
11819 and don't rely on undefined behavior when shifting a 1 left into
11821 * lisp.h (get_random): Change signature to match.
11823 * lread.c (hash_string): Use size_t, not int, for hash computation.
11824 Normally we prefer signed values; but hashing is special, because
11825 it's better to use unsigned division on hash table sizes so that
11826 the remainder is nonnegative. Also, size_t is the natural width
11827 for hashing into memory. The previous code used 'int', which doesn't
11828 retain enough info to hash well into very large tables.
11829 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11831 * dbusbind.c: Don't possibly lose pointer info when converting.
11832 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11833 Use XPNTR rather than XHASH, so that the high-order bits of
11834 the pointer aren't lost when converting through void *.
11836 * eval.c (Fautoload): Don't double-shift a pointer.
11838 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11840 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11842 * gnutls.c (DEF_GNUTLS_FN):
11843 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11845 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11847 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11850 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11852 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11853 New version that can reserve upto 2GB of heap space.
11855 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11857 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11859 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11861 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11862 `gnutls_certificate_set_x509_key_file'.
11864 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11866 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11867 Update dependencies.
11869 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11871 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11872 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11873 Remove unused parameter `fildes'.
11874 * process.c (read_process_output, send_process): Don't pass it.
11876 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11878 Fix previous change: the library cache is defined in w32.c.
11879 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11880 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11882 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11884 Implement dynamic loading of GnuTLS on Windows.
11886 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11887 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11888 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11891 * gnutls.c (Qgnutls_dll): Define.
11892 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11893 (gnutls_*): Declare function pointers.
11894 (init_gnutls_functions): New function to initialize function pointers.
11895 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11896 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11897 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11898 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11899 (emacs_gnutls_write, emacs_gnutls_read)
11900 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11901 (Fgnutls_available_p): New function.
11902 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11903 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11904 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11906 * image.c: Include w32.h.
11907 (Vimage_type_cache): Delete.
11908 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11909 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11910 (w32_delayed_load): Move to w32.c.
11912 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11914 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11915 (w32_delayed_load): Move from image.c. When loading a library, record
11916 its filename in the :loaded-from property of the library id.
11917 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11918 Initialize and staticpro them.
11919 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11921 * process.c: Include lisp.h before w32.h, not after.
11922 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11923 instead of gnutls_record_check_pending.
11925 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11927 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11929 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11930 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11933 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11935 * xterm.c (x_set_frame_alpha): Do not set property on anything
11936 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11938 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11940 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11942 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11944 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11945 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11946 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11947 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11948 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11949 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11950 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11951 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11952 (Qgnutls_bootprop_callbacks_verify): Make static.
11954 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11956 * callproc.c: Indentation fixup.
11958 * sysdep.c (wait_for_termination_1): Make static.
11959 (wait_for_termination, interruptible_wait_for_termination):
11960 Move after wait_for_termination_1.
11962 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11964 * sysdep.c (interruptible_wait_for_termination): New function
11965 which is like wait_for_termination, but allows keyboard
11968 * callproc.c (Fcall_process): Add (:file "file") as an option for
11970 (Fcall_process_region): Ditto.
11972 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11974 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11975 rather than `XVECTOR (FOO)->size'.
11977 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11978 inttypes.h, as a gnulib replacement is used if it not available in
11981 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11983 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11984 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11985 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11987 * coding.c (coding_alloc_by_realloc): Error out if destination
11988 will grow beyond MOST_POSITIVE_FIXNUM.
11989 (decode_coding_emacs_mule): Abort if there isn't enough place in
11990 charbuf for the composition carryover bytes. Reserve an extra
11991 space for up to 2 characters produced in a loop.
11992 (decode_coding_iso_2022): Abort if there isn't enough place in
11993 charbuf for the composition carryover bytes.
11995 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11997 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11998 aborting when %lld or %lll format is passed.
11999 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12000 %llo or %llx format is passed. (Bug#8545)
12002 * window.c (window_scroll_line_based): Use a marker instead of
12003 simple variables to record original value of point. (Bug#7952)
12005 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12006 produced by %s or %c overflows available buffer space. (Bug#8545)
12008 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12010 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
12011 (SIZE_MAX): Move defn after all includes, as they might #define it.
12013 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12015 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12017 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12019 * keyboard.c (Qdelayed_warnings_hook): Define.
12020 (command_loop_1): Run `delayed-warnings-hook'
12021 if Vdelayed_warnings_list is non-nil.
12022 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12023 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12025 2011-04-28 Eli Zaretskii <eliz@gnu.org>
12027 * doprnt.c (doprnt): Don't return value smaller than the buffer
12028 size if the message was truncated. (Bug#8545).
12030 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12032 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12033 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12035 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12037 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12039 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12041 * makefile.w32-in: Update dependencies.
12043 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12045 Improve `doprnt' and its usage. (Bug#8545)
12046 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12047 `format_end'. Remove support for %l as a conversion specifier.
12048 Don't use xrealloc. Improve diagnostics when the %l size modifier
12049 is used. Update the commentary.
12051 * eval.c (verror): Simplify calculation of size_t.
12053 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12056 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12058 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12061 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12063 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12064 This makes this file independent of the recent pseudovector change.
12066 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12068 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12070 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12071 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12072 Remove unused local.
12073 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12075 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12076 GCC 4.6.0 optimizes based on type-based alias analysis.
12077 For example, if b is of type struct buffer * and v of type struct
12078 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12079 != &v->size, and therefore "v->size = 1; b->size = 2; return
12080 v->size;" must therefore return 1. This assumption is incorrect
12081 for Emacs, since it type-puns struct Lisp_Vector * with many other
12082 types. To fix this problem, this patch adds a new type struct
12083 vectorlike_header that documents the constraints on layout of vectors
12084 and pseudovectors, and helps optimizing compilers not get fooled
12085 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12086 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12087 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12089 (XSETPVECTYPE): Rewrite in terms of new macro.
12090 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12091 This is a bit clearer, and further avoids the possibility of
12092 undesirable aliasing.
12093 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12094 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12095 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12096 since Lisp_Subr is a special case (no "next" field).
12097 (ASIZE): Now uses header.size rather than size.
12098 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12099 to avoid the hassle of writing XVECTOR (foo)->header.size.
12100 (struct vectorlike_header): New type.
12101 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12102 object, to help avoid aliasing.
12103 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12104 (SUBRP): Likewise, since Lisp_Subr is a special case.
12105 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12106 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12107 (struct Lisp_Hash_Table): Combine first two members into a single
12108 struct vectorlike_header member. All uses of "size" and "next" members
12109 changed to be "header.size" and "header.next".
12110 * buffer.h (struct buffer): Likewise.
12111 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12112 * frame.h (struct frame): Likewise.
12113 * process.h (struct Lisp_Process): Likewise.
12114 * termhooks.h (struct terminal): Likewise.
12115 * window.c (struct save_window_data, struct saved_window): Likewise.
12116 * window.h (struct window): Likewise.
12117 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12118 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12119 * buffer.c (init_buffer_once): Likewise.
12120 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12122 * process.c (Fformat_network_address): Use local var for size,
12125 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12127 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12128 * data.c (atof): Remove decl; no longer used or needed.
12129 (digit_to_number): Move to lread.c.
12130 (Fstring_to_number): Use new string_to_number function, to be
12131 consistent with how the Lisp reader treats infinities and NaNs.
12132 Do not assume that floating-point numbers represent EMACS_INT
12133 without losing information; this is not true on most 64-bit hosts.
12134 Avoid double-rounding errors, by insisting on integers when
12135 parsing non-base-10 numbers, as the documentation specifies.
12136 * lisp.h (string_to_number): New decl, replacing ...
12137 (isfloat_string): Remove.
12138 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12139 (read1): Do not accept +. and -. as integers; this
12140 appears to have been a coding error. Similarly, do not accept
12141 strings like +-1e0 as floating point numbers. Do not report
12142 overflow for integer overflows unless the base is not 10 which
12143 means we have no simple and reliable way to continue.
12144 Break out the floating-point parsing into a new
12145 function string_to_number, so that Fstring_to_number parses
12146 floating point numbers consistently with the Lisp reader.
12147 (digit_to_number): Move here from data.c. Make it static inline.
12148 (E_CHAR, EXP_INT): Remove, replacing with ...
12149 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12150 (string_to_number): New function, replacing isfloat_string.
12151 This function checks for valid syntax and produces the resulting
12152 Lisp float number too. Rework it so that string-to-number
12153 no longer mishandles examples like "1.0e+". Use strtoumax,
12154 so that overflow for non-base-10 numbers is reported only when
12155 there's no portable and simple way to convert to floating point.
12157 * textprop.c (set_text_properties_1): Rewrite for clarity,
12158 and to avoid GCC warning about integer overflow.
12160 * intervals.h (struct interval): Use EMACS_INT for members
12161 where EMACS_UINT might cause problems. See
12162 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12163 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12164 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12166 (offset_intervals): Tell GCC not to worry about length overflow
12167 when negating a negative length.
12169 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12170 (overrun_check_free): Likewise.
12172 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12173 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12176 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12177 (gnutls_make_error): Rename local to avoid shadowing.
12178 (gnutls_emacs_global_deinit): ifdef out; not used.
12179 (Fgnutls_boot): Use const for pointer to readonly storage.
12180 Comment out unused local. Fix pointer signedness problems.
12182 * lread.c (openp): Don't stuff size_t into an 'int'.
12183 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12184 about possible signed overflow.
12186 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12187 (GDK_KEY_g): Don't define if already defined.
12188 (xg_prepare_tooltip): Avoid pointer signedness problem.
12189 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12191 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12192 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12194 * xfns.c (Fx_window_property): Simplify a bit,
12195 to make a bit faster and to avoid GCC 4.6.0 warning.
12196 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12198 * fns.c (internal_equal): Don't assume size_t fits in int.
12200 * alloc.c (compact_small_strings): Tighten assertion a little.
12202 Replace pEd with more-general pI, and fix some printf arg casts.
12203 * lisp.h (pI): New macro, generalizing old pEd macro to other
12204 conversion specifiers. For example, use "...%"pI"d..." rather
12205 than "...%"pEd"...".
12206 (pEd): Remove. All uses replaced with similar uses of pI.
12207 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12208 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12209 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12210 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12211 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12212 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12213 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12215 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12216 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12217 * print.c (safe_debug_print, print_object): Likewise.
12218 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12220 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12221 avoiding the 0 flag, which is not portable.
12222 * process.c (Fmake_network_process): Use pI to avoid cast.
12223 * region-cache.c (pp_cache): Likewise.
12224 * xdisp.c (decode_mode_spec): Likewise.
12225 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12226 behavior on 64-bit hosts with printf arg.
12227 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12228 (x_stop_queuing_selection_requests): Likewise.
12229 (x_get_window_property): Don't truncate byte count to an 'int'
12232 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12233 here, since it parses constructs like leading '-' and spaces,
12234 which are not wanted; and it overflows with large numbers.
12235 Instead, simply match F[0-9]+, which is what is wanted anyway.
12237 * alloc.c: Remove unportable assumptions about struct layout.
12238 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12239 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12240 (allocate_vectorlike, make_pure_vector): Use the new macros,
12241 plus offsetof, to remove unportable assumptions about struct layout.
12242 These assumptions hold on all porting targets that I know of, but
12243 they are not guaranteed, they're easy to remove, and removing them
12244 makes further changes easier.
12246 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12247 This doesn't fix a bug but makes the code clearer.
12248 (string_overrun_cookie): Now const. Use initializers that
12249 don't formally overflow signed char, to avoid warnings.
12250 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12251 can cause Emacs to crash when string overrun checking is enabled.
12252 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12253 multiple of sizeof (EMACS_INT); it need not be, if
12254 alignof(EMACS_INT) < sizeof (EMACS_INT).
12255 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12257 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12259 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12261 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12263 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12264 supposed to be handshaking. (Bug#8556)
12265 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12267 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12269 * lisp.h (Qdebug): List symbol.
12270 * eval.c (Qdebug): Restore global linkage.
12271 * keyboard.c (debug-on-event): New variable.
12272 (handle_user_signal): Break into debugger when debug-on-event
12273 matches the current signal symbol.
12275 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12277 * alloc.c (check_sblock, check_string_bytes)
12278 (check_string_free_list): Convert to standard C.
12280 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12282 * w32.c (emacs_gnutls_push): Fix typo.
12284 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12286 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12287 "cast to pointer from integer of different size".
12289 Improve doprnt and its use in verror. (Bug#8545)
12290 * doprnt.c (doprnt): Document the set of format control sequences
12291 supported by the function. Use SAFE_ALLOCA instead of always
12294 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12295 is one byte too soon. Don't use xrealloc; instead xfree and
12298 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12300 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12303 * gnutls.c: Renamed global_initialized to
12304 gnutls_global_initialized. Added internals for the
12305 :verify-hostname-error, :verify-error, and :verify-flags
12306 parameters of `gnutls-boot' and documented those parameters in the
12307 docstring. Start callback support.
12308 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12309 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12310 on error. Return error code.
12311 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12312 (emacs_gnutls_read): Likewise.
12313 (Fgnutls_boot): Return handshake error code.
12314 (emacs_gnutls_handle_error): New function.
12315 (wsaerror_to_errno): Likewise.
12317 * w32.h (emacs_gnutls_pull): Add prototype.
12318 (emacs_gnutls_push): Likewise.
12320 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12321 (emacs_gnutls_push): Likewise.
12323 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12325 * process.c (wait_reading_process_output): Check if GnuTLS
12326 buffered some data internally if no FDs are set for TLS
12329 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12330 (LIBS): Link to USER_LIBS.
12331 ($(BLD)/gnutls.$(0)): New target.
12333 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12335 * xdisp.c (handle_single_display_spec): Rename the
12336 display_replaced_before_p argument into display_replaced_p, to
12337 make it consistent with the commentary. Fix typos in the
12340 * textprop.c (syms_of_textprop): Remove dead code.
12341 (copy_text_properties): Delete obsolete commentary about an
12342 interface that was deleted long ago. Fix typos in the description
12345 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12346 to changes in oldXMenu/XMenu.h from 2011-04-16.
12347 <menu_help_message, prev_menu_help_message>: Constify.
12348 (IT_menu_make_room): menu->help_text is now `const char **';
12351 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12352 to changes in oldXMenu/XMenu.h from 2011-04-16.
12353 (struct XMenu): Declare `help_text' `const char **'.
12355 * xfaces.c <Qunspecified>: Make extern again.
12357 * syntax.c: Include sys/types.h before including regex.h, as
12360 * doc.c (get_doc_string): Improve the format passed to `error'.
12362 * doprnt.c (doprnt): Improve commentary.
12364 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12366 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12369 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12370 changes in globals.h immediately force recompilation.
12371 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12372 $(CURDIR)/s/ms-w32.h.
12373 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12375 * character.c (Fchar_direction): Function deleted.
12376 (syms_of_character): Don't defsubr it.
12377 <char-direction-table>: Deleted.
12379 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12381 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12382 * doprnt.c: Include limits.h.
12383 (SIZE_MAX): New macro.
12384 (doprnt): Return a size_t value. 2nd arg is now size_t.
12385 Many local variables are now size_t instead of int or unsigned.
12386 Improve overflow protection. Support `l' modifier for integer
12387 conversions. Support %l conversion. Don't assume an EMACS_INT
12388 argument for integer conversions and for %c.
12390 * lisp.h (doprnt): Restore prototype.
12392 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12393 $(SRC)/character.h.
12395 * Makefile.in (base_obj): Add back doprnt.o.
12397 * deps.mk (doprnt.o): Add back prerequisites.
12398 (callint.o): Depend on character.h.
12400 * eval.c (internal_lisp_condition_case): Include the handler
12401 representation in the error message.
12402 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12403 when breaking from the loop.
12405 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12407 * callint.c (Fcall_interactively): When displaying error message
12408 about invalid control letter, pass the character's codepoint, not
12409 a pointer to its multibyte form. Improve display of the character
12410 in octal and display also its hex code.
12412 * character.c (char_string): Use %x to display the (unsigned)
12413 codepoint of an invalid character, to avoid displaying a bogus
12416 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12417 `error', not SYMBOL_NAME itself.
12419 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12420 character arguments to `error'.
12422 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12423 to `error' in error message about FINAL_CHAR argument. Make sure
12424 FINAL_CHAR is a character, and use %c when it is passed as
12425 argument to `error'.
12427 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12429 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12431 * w32.c: Include <time.h>.
12432 (sys_localtime): New function.
12434 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12436 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12438 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12440 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12442 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12443 zombies (Bug#8467).
12445 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12447 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12448 gl_state.e_property when gl_state.object is Qt.
12450 * insdel.c (make_gap_larger): Remove limitation of buffer size
12453 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12455 * xdisp.c (lookup_glyphless_char_display)
12456 (produce_glyphless_glyph): Handle cons cell entry in
12457 glyphless-char-display.
12458 (Vglyphless_char_display): Document it.
12460 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12461 glyphless-char-display.
12463 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12465 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12467 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12469 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12470 definition for no-X builds.
12472 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12474 Static checks with GCC 4.6.0 and non-default toolkits.
12476 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12478 * process.c (keyboard_bit_set): Define only if SIGIO.
12479 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12480 (send_process): Repair possible setjmp clobbering.
12482 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12484 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12486 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12488 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12489 Define only if needed.
12491 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12492 by pacifying GCC about it. Maybe it's time to retire it?
12493 * xfaces.c (USG, __TIMEVAL__): Likewise.
12495 * dispextern.h (struct redisplay_interface): Rename param
12496 to avoid shadowing.
12497 * termhooks.h (struct terminal): Likewise.
12498 * xterm.c (xembed_send_message): Likewise.
12500 * insdel.c (make_gap_smaller): Define only if
12501 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12503 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12506 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12507 so that we aren't warned about unused symbols.
12509 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12511 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12513 * xfns.c (x_real_positions): Mark locals as initialized.
12515 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12517 * xterm.c: Fix problems found by static analysis with other toolkits.
12518 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12519 (x_dispatch_event): Declare static if USE_GTK, and
12520 define if USE_GTK || USE_X_TOOLKIT.
12521 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12522 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12523 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12524 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12526 * xmenu.c (menu_help_callback): Pointer type fixes.
12527 Use const pointers when pointing at readonly data. Avoid pointer
12528 signedness clashes.
12529 (FALSE): Remove unused macro.
12530 (update_frame_menubar): Remove unused decl.
12532 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12534 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12535 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12536 (single_menu_item): Rename local to avoid shadowing.
12538 * keyboard.c (make_lispy_event): Remove unused local var.
12540 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12541 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12543 * bitmaps: Change bitmaps from unsigned char back to the X11
12544 compatible char. Avoid the old compiler warnings about
12545 out-of-range initializers by using, for example, '\xab' rather
12548 * xgselect.c (xgselect_initialize): Check vs interface
12549 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12551 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12553 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12554 to read-only memory.
12556 * fns.c (vector): Remove; this old hack is no longer needed.
12558 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12560 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12562 * xrdb.c (x_load_resources): Omit unused local.
12564 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12565 (x_window): Rename locals to avoid shadowing.
12566 (USG): Use the kludged USG macro, to pacify gcc.
12568 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12569 (x_term_init): Remove local to avoid shadowing.
12571 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12573 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12574 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12576 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12578 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12580 Fix regex.c, syntax.c and friends for buffers > 2GB.
12581 * syntax.h (struct gl_state_s): Declare character position members
12584 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12586 * textprop.c (verify_interval_modification, interval_of):
12587 Declare arguments EMACS_INT.
12589 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12592 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12594 * indent.c (Fvertical_motion): Local variable it_start is now
12597 * regex.c (re_match, re_match_2, re_match_2_internal)
12598 (bcmp_translate, regcomp, regexec, print_double_string)
12599 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12600 (re_compile_pattern, re_exec): Declare arguments and local
12601 variables `size_t' and `ssize_t' and return values `regoff_t', as
12603 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12604 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12605 <compile_stack_type>: `size' and `avail' are now `size_t'.
12607 * regex.h <regoff_t>: Use ssize_t, not int.
12608 (re_search, re_search_2, re_match, re_match_2): Arguments that
12609 specify buffer/string position and length are now ssize_t and
12610 size_t. Return type is regoff_t.
12612 2011-04-16 Ben Key <bkey76@gmail.com>
12614 * nsfont.m: Fixed bugs in ns_get_family and
12615 ns_descriptor_to_entity that were caused by using free to
12616 deallocate memory blocks that were allocated by xmalloc (via
12617 xstrdup). This caused Emacs to crash when compiled with
12618 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12619 --enable-checking=xmallocoverrun). xfree is now used to
12620 deallocate these memory blocks.
12622 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12624 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12626 emacs_write: Accept and return EMACS_INT for sizes.
12627 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12629 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12630 Accept and return EMACS_INT.
12631 (emacs_gnutls_write): Return the number of bytes written on
12633 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12634 (emacs_read, emacs_write): Remove check for negative size, as the
12635 Emacs source code has been audited now.
12636 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12637 (emacs_read, emacs_write): Use it.
12638 * process.c (send_process): Adjust to the new signatures of
12639 emacs_write and emacs_gnutls_write. Do not attempt to store
12640 a byte offset into an 'int'; it might overflow.
12641 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12643 * sound.c: Don't assume sizes fit in 'int'.
12644 (struct sound_device.period_size, alsa_period_size):
12645 Return EMACS_INT, not int.
12646 (struct sound_device.write, vox_write, alsa_write):
12647 Accept EMACS_INT, not int.
12648 (wav_play, au_play): Use EMACS_INT to store sizes and to
12649 record read return values.
12651 2011-04-15 Ben Key <bkey76@gmail.com>
12653 * keyboard.c (Qundefined): Don't declare static since it is used
12655 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12656 static since they are used in nsfont.m.
12658 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12660 * process.c (Qprocessp): Don't declare static.
12661 * lisp.h (Qprocessp): Declare again.
12663 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12665 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12667 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12669 Improve C-level modularity by making more things 'static'.
12671 Don't publish debugger-only interfaces to other modules.
12672 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12673 (verify_bytepos, count_markers): Move decls to the only modules
12675 * region-cache.h (pp_cache): Likewise.
12676 * window.h (check_all_windows): Likewise.
12677 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12679 * sysdep.c (croak): Now static, if
12680 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12681 * syssignal.h (croak): Declare only if not static.
12683 * alloc.c (refill_memory_reserve): Now static if
12684 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12685 * lisp.h (refill_memory_reserve): Declare only if not static.
12687 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12688 Define only if USE_LUCID.
12690 * xrdb.c (x_customization_string, x_rm_string): Now static.
12692 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12693 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12695 * xdisp.c (draw_row_with_mouse_face): Now static.
12696 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12698 * window.h (check_all_windows): Mark externally visible.
12700 * window.c (window_deletion_count): Now static.
12702 * undo.c: Make symbols static if they're not exported.
12703 (last_undo_buffer, last_boundary_position, pending_boundary):
12706 * textprop.c (interval_insert_behind_hooks): Now static.
12707 (interval_insert_in_front_hooks): Likewise.
12709 * term.c: Make symbols static if they're not exported.
12710 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12711 (max_frame_lines, tty_set_terminal_modes):
12712 (tty_reset_terminal_modes, tty_turn_off_highlight):
12713 (get_tty_terminal): Now static.
12714 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12715 * termhooks.h (term_mouse_moveto): Do not declare if
12716 HAVE_WINDOW_SYSTEM.
12717 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12718 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12720 * sysdep.c: Make symbols static if they're not exported.
12721 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12723 (sigprocmask_set, full_mask): Remove; unused.
12724 (wait_debugging): Mark as visible.
12725 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12726 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12728 * syntax.c (syntax_temp): Define only if !__GNUC__.
12730 * sound.c (current_sound_device, current_sound): Now static.
12732 * search.c (searchbufs, searchbuf_head): Now static.
12734 * scroll.c (scroll_cost): Remove; unused.
12735 * dispextern.h (scroll_cost): Remove decl.
12737 * region-cache.h (pp_cache): Mark as externally visible.
12739 * process.c: Make symbols static if they're not exported.
12740 (process_tick, update_tick, create_process, chan_process):
12741 (Vprocess_alist, proc_buffered_char, datagram_access):
12742 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12743 (deactivate_process): Mark defn as static, as well as decl.
12744 * lisp.h (create_process): Remove decl.
12745 * process.h (chan_process, Vprocess_alist): Remove decls.
12747 * print.c: Make symbols static if they're not exported.
12748 (print_depth, new_backquote_output, being_printed, print_buffer):
12749 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12750 (print_interval, print_number_index, initial_stderr_stream):
12752 * lisp.h (Fprinc): Remove decl.
12753 (debug_output_compilation_hack): Mark as externally visible.
12755 * sysdep.c (croak): Move decl from here to syssignal.h.
12756 * syssignal.h (croak): Put it here, so the API can be checked when
12757 'croak' is called from dissociate_if_controlling_tty.
12759 * minibuf.c: Make symbols static if they're not exported.
12760 (minibuf_save_list, choose_minibuf_frame): Now static.
12761 * lisp.h (choose_minibuf_frame): Remove decl.
12763 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12765 * lread.c: Make symbols static if they're not exported.
12766 (read_objects, initial_obarray, oblookup_last_bucket_number):
12768 (make_symbol): Remove; unused.
12769 * lisp.h (initial_obarray, make_symbol): Remove decls.
12771 * keyboard.c: Make symbols static if they're not exported.
12772 (single_kboard, recent_keys_index, total_keys, recent_keys):
12773 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12774 (this_single_command_key_start, echoing, last_auto_save):
12775 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12776 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12777 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12778 (Vlispy_mouse_stem, double_click_count):
12780 (force_auto_save_soon): Define only if SIGDANGER.
12781 (ignore_mouse_drag_p): Now static if
12782 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12783 (print_help): Remove; unused.
12784 (stop_character, last_timer_event): Mark as externally visible.
12785 * keyboard.h (ignore_mouse_drag_p): Declare only if
12786 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12787 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12788 * lisp.h (echoing): Remove decl.
12789 (force_auto_save_soon): Declare only if SIGDANGER.
12790 * xdisp.c (redisplay_window): Simplify code, to make it more
12791 obvious that ignore_mouse_drag_p is not accessed if !defined
12792 USE_GTK && !defined HAVE_NS.
12794 * intervals.c: Make symbols static if they're not exported.
12795 (merge_properties_sticky, merge_interval_right, delete_interval):
12797 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12799 * insdel.c: Make symbols static if they're not exported.
12800 However, leave prepare_to_modify_buffer alone. It's never
12801 called from outside this function, but that appears to be a bug.
12802 (combine_after_change_list, combine_after_change_buffer):
12803 (adjust_after_replace, signal_before_change): Now static.
12804 (adjust_after_replace_noundo): Remove; unused.
12805 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12806 (signal_before_change): Remove decls.
12808 * indent.c (val_compute_motion, val_vmotion): Now static.
12810 * image.c: Make symbols static if they're not exported.
12811 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12813 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12814 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12816 * fringe.c (standard_bitmaps): Now static.
12817 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12819 * frame.c: Make symbols static if they're not exported.
12820 (x_report_frame_params, make_terminal_frame): Now static.
12821 (get_frame_param): Now static, unless HAVE_NS.
12822 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12823 (x_get_resource_string): Remove; not used.
12824 * frame.h (make_terminal_frame, x_report_frame_params):
12825 (x_get_resource_string); Remove decls.
12826 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12827 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12829 * font.c, fontset.c: Make symbols static if they're not exported.
12830 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12831 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12832 * font.c (font_close_object): Now static.
12833 * font.h (font_close_object): Remove.
12834 * fontset.c (FONTSET_OBJLIST): Remove.
12835 (free_realized_fontset) #if-0 the body, which does nothing.
12836 (face_suitable_for_char_p): #if-0, as it's never called.
12837 * fontset.h (face_suitable_for_char_p): Remove decl.
12838 * xfaces.c (face_at_string_position):
12839 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12840 since 0 is always ASCII.
12842 * fns.c (weak_hash_tables): Now static.
12844 * fileio.c: Make symbols static if they're not exported.
12845 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12846 (Vwrite_region_annotation_buffers): Now static.
12848 * eval.c: Make symbols static if they're not exported.
12849 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12850 * lisp.h (backtrace_list): Remove decl.
12852 * emacs.c: Make symbols static if they're not exported.
12853 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12854 (fatal_error_code, fatal_error_signal_hook, standard_args):
12856 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12857 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12858 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12859 * lisp.h (fatal_error_signal_hook): Remove decl.
12860 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12862 * editfns.c: Move a (normally-unused) function to its only use.
12863 * editfns.c, lisp.h (get_operating_system_release): Remove.
12864 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12865 worth the hassle of breaking this out.
12867 * xterm.c: Make symbols static if they're not exported.
12868 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12869 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12870 (x_destroy_window, x_delete_display):
12872 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12873 (x_mouse_leave): Remove; unused.
12874 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12875 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12876 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12878 (x_mouse_leave): Declare only if WINDOWSNT.
12879 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12880 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12883 * ftxfont.c: Make symbols static if they're not exported.
12884 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12886 * font.h (ftxfont_driver): Likewise.
12888 * xfns.c: Make symbols static if they're not exported.
12889 (x_last_font_name, x_display_info_for_name):
12890 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12891 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12892 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12893 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12894 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12895 (last_show_tip_args): Now static.
12896 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12897 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12898 (x_screen_planes): Remove; unused.
12899 * dispextern.h (x_screen_planes): Remove decl.
12901 * dispnew.c: Make symbols static if they're not exported.
12902 * dispextern.h (redraw_garbaged_frames, scrolling):
12903 (increment_row_positions): Remove.
12904 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12905 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12907 (redraw_garbaged_frames): Remove; unused.
12909 * xfaces.c: Make symbols static if they're not exported.
12910 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12912 * xterm.h (defined_color): Remove decls.
12913 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12914 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12915 (menu_face_changed_default, defined_color, free_realized_face):
12916 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12917 (ascii_face_of_lisp_face): Remove; unused.
12919 * xdisp.c: Make symbols static if they're not exported.
12920 * dispextern.h (scratch_glyph_row, window_box_edges):
12921 (glyph_to_pixel_coords, set_cursor_from_row):
12922 (get_next_display_element, set_iterator_to_next):
12923 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12924 (show_mouse_face): Remove decls
12925 * frame.h (message_buf_print): Likewise.
12926 * lisp.h (pop_message, set_message, check_point_in_composition):
12928 * xterm.h (set_vertical_scroll_bar): Likewise.
12929 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12930 (message_buf_print, scratch_glyph_row, displayed_buffer):
12931 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12932 (get_next_display_element, show_mouse_face, window_box_edges):
12933 (frame_to_window_pixel_xy, check_point_in_composition):
12934 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12935 (glyph_to_pixel_coords): Remove; unused.
12937 * dired.c (file_name_completion): Now static.
12939 * dbusbind.c (xd_in_read_queued_messages): Now static.
12941 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12942 * data.c (circular_list_error): Remove.
12944 * commands.h (last_point_position, last_point_position_buffer):
12945 (last_point_position_window): Remove decls.
12946 * keyboard.c: Make these variables static.
12948 * coding.h (coding, code_convert_region, encode_coding_gap):
12950 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12951 (iso_code_class, detect_coding, code_convert_region): Now static.
12952 (encode_coding_gap): Remove; unused.
12954 * chartab.c (chartab_chars, chartab_bits): Now static.
12956 * charset.h (charset_iso_8859_1): Remove decl.
12957 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12960 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12961 * ccl.c (Vccl_program_table): Now static.
12962 (check_ccl_update): Remove; unused.
12964 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12965 * category.h: ... from here.
12966 * category.c (check_category_table, set_category_set): Now static.
12968 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12969 * lisp.h: Remove these decls.
12971 * buffer.c (buffer_count): Remove unused var.
12973 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12974 so that it's not optimized away.
12975 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12976 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12977 exported only to the debugger.
12979 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12980 * atimer.h (run_all_atimers): Remove; not exported.
12982 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12983 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12984 was inaccessible from Lisp.
12985 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12986 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12988 alloc.c: Import and export fewer symbols, and remove unused items.
12989 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12991 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12992 it's not optimized away by whole-program optimization.
12993 (message_enable_multibyte, free_misc): Remove.
12994 (catchlist, handlerlist, mark_backtrace):
12995 Declare only if BYTE_MARK_STACK.
12996 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12997 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12998 (message_enable_multibyte): Remove decl.
12999 (free_misc, interval_free_list, float_block, float_block_index):
13000 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13001 (cons_free_list, last_marked_index):
13003 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13004 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13005 (mark_backtrace): Define only if BYTE_MARK_STACK.
13006 * xdisp.c (message_enable_multibyte): Now static.
13008 Declare Lisp_Object Q* variables to be 'static' if not exported.
13009 This makes it easier for human readers (and static analyzers)
13010 to see whether these variables are used from other modules.
13011 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13012 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13013 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13014 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13015 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13016 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13017 * xmenu.c, xselect.c:
13018 Declare Q* vars static if they are not used in other modules.
13019 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13020 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13021 Remove decls of unexported vars.
13022 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13024 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13026 Make Emacs functions such as Fatom 'static' by default.
13027 This makes it easier for human readers (and static analyzers)
13028 to see whether these functions can be called from other modules.
13029 DEFUN now defines a static function. To make the function external
13030 so that it can be used in other C modules, use the new macro DEFUE.
13031 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13032 (Finit_image_library):
13033 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13034 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13035 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13036 Remove decls, since these functions are now static.
13037 (Funintern, Fget_internal_run_time): New decls, since these functions
13038 were already external.
13040 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13041 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13042 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13043 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13044 * keyboard.c, keymap.c, lread.c:
13045 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13046 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13047 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13048 Mark functions with DEFUE instead of DEFUN,
13049 if they are used in other modules.
13050 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13051 decls for now-static functions.
13052 * buffer.h (Fdelete_overlay): Remove decl.
13053 * callproc.c (Fgetenv_internal): Mark as internal.
13054 * composite.c (Fremove_list_of_text_properties): Remove decl.
13055 (Fcomposition_get_gstring): New forward static decl.
13056 * composite.h (Fcomposite_get_gstring): Remove decl.
13057 * dired.c (Ffile_attributes): New forward static decl.
13058 * doc.c (Fdocumntation_property): New forward static decl.
13059 * eval.c (Ffetch_bytecode): New forward static decl.
13060 (Funintern): Remove extern decl; now in .h file where it belongs.
13061 * fileio.c (Fmake_symbolic_link): New forward static decl.
13062 * image.c (Finit_image_library): New forward static decl.
13063 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13064 * intervals.h (Fprevious_property_change):
13065 (Fremove_list_of_text_properties): Remove decls.
13066 * keyboard.c (Fthis_command_keys): Remove decl.
13067 (Fcommand_execute): New forward static decl.
13068 * keymap.c (Flookup_key): New forward static decl.
13069 (Fcopy_keymap): Now static.
13070 * keymap.h (Flookup_key): Remove decl.
13071 * process.c (Fget_process): New forward static decl.
13072 (Fprocess_datagram_address): Mark as internal.
13073 * syntax.c (Fsyntax_table_p): New forward static decl.
13074 (skip_chars): Remove duplicate decl.
13075 * textprop.c (Fprevious_property_change): New forward static decl.
13076 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13078 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13079 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13081 * editfns.c (Fformat): Remove unreachable code.
13083 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13085 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13088 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13090 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13091 when at ZV. (Bug#8487)
13093 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13095 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13097 * keyboard.c (parse_tool_bar_item): Likewise.
13098 * sound.c (sound_cleanup, alsa_close): Likewise.
13099 * termcap.c (tgetent): Likewise.
13100 * xfns.c (x_default_font_parameter): Likewise.
13101 * xsettings.c (read_and_apply_settings): Likewise.
13103 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13104 (overrun_check_free): Protoize.
13106 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13108 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13109 since callers should never pass a negative size.
13110 Change the signature to match that of plain 'read' and 'write'; see
13111 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13112 * lisp.h: Update prototypes of emacs_write and emacs_read.
13114 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13116 * xdisp.c (redisplay_window): Don't try to determine the character
13117 position of the scroll margin if the window start point w->startp
13118 is outside the buffer's accessible region. (Bug#8468)
13120 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13122 Fix write-region and its subroutines for buffers > 2GB.
13123 * fileio.c (a_write, e_write): Modify declaration of arguments and
13124 local variables to support buffers larger than 2GB.
13125 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13127 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13128 argument, local variables, and return value.
13130 * lisp.h: Update prototypes of emacs_write and emacs_read.
13132 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13134 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13136 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13138 Fix more problems found by GCC 4.6.0's static checks.
13140 * xdisp.c (vmessage): Use a better test for character truncation.
13142 * charset.c (load_charset_map): <, not <=, for optimization,
13143 and to avoid potential problems with integer overflow.
13144 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13145 * casetab.c (set_identity, shuffle): Likewise.
13146 * editfns.c (Fformat): Likewise.
13147 * syntax.c (skip_chars): Likewise.
13149 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13150 This also lets GCC 4.6.0 generate slightly better loop code.
13152 * callint.c (Fcall_interactively): <, not <=, for optimization.
13153 (Fcall_interactively): Count the number of arguments produced,
13154 not the number of arguments given. This is simpler and lets GCC
13155 4.6.0 generate slightly better code.
13157 * ftfont.c: Distingish more carefully between FcChar8 and char.
13158 The previous code passed unsigned char * to a functions like
13159 strlen and xstrcasecmp that expect char *, which does not
13160 conform to the C standard.
13161 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13162 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13163 char * when the C standard requires it.
13165 * keyboard.c (read_char): Remove unused var.
13167 * eval.c: Port to Windows vsnprintf (Bug#8435).
13168 Include <limits.h>.
13169 (SIZE_MAX): Define if the headers do not.
13170 (verror): Do not give up if vsnprintf returns a negative count.
13171 Instead, grow the buffer. This ports to Windows vsnprintf, which
13172 does not conform to C99. Problem reported by Eli Zaretskii.
13173 Also, simplify the allocation scheme, by avoiding the need for
13174 calling realloc, and removing the ALLOCATED variable.
13176 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13178 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13179 But keep the doprint source code for now, as we might revamp it
13180 and use it again (Bug#8435).
13181 * lisp.h (doprnt): Remove.
13182 * Makefile.in (base_obj): Remove doprnt.o.
13183 * deps.mk (doprnt.o): Remove.
13185 error: Print 32- and 64-bit integers portably (Bug#8435).
13186 Without this change, on typical 64-bit hosts error ("...%d...", N)
13187 was used to print both 32- and 64-bit integers N, which relied on
13188 undefined behavior.
13189 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13190 * lisp.h (error, verror): Mark as printf-like functions.
13191 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13192 Report overflow in size calculations when allocating printf buffer.
13193 Do not truncate output string at its first null byte.
13194 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13195 Truncate the output at a character boundary, since vsnprintf does not
13197 * charset.c (check_iso_charset_parameter): Convert internal
13198 character to string before calling 'error', since %c now has the
13200 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13201 overflow when computing char to be passed to 'error'. Do not
13202 pass Lisp_Object to 'error'; pass the integer instead.
13203 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13204 formatted with plain %d.
13206 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13208 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13210 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13212 * xterm.c (x_catch_errors): Remove duplicate declaration.
13214 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13216 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13218 2011-04-10 Jim Meyering <meyering@redhat.com>
13220 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13221 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13222 return ssize_t not "int", and use size_t as the buffer length.
13223 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13224 * gnutls.h: Update declarations.
13225 * process.c (read_process_output): Use ssize_t, to match.
13226 (send_process): Likewise.
13228 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13230 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13232 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13234 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13235 Use unsigned char, to match FcChar8 type definition.
13237 * xterm.c (handle_one_xevent):
13238 * xmenu.c (create_and_show_popup_menu):
13239 * xselect.c (x_decline_selection_request)
13240 (x_reply_selection_request): Avoid type-punned deref of X events.
13242 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13244 Fix some uses of `int' instead of EMACS_INT.
13245 * search.c (string_match_1, fast_string_match)
13246 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13247 (scan_buffer, find_next_newline_no_quit)
13248 (find_before_next_newline, search_command, Freplace_match)
13249 (Fmatch_data): Make some `int' variables be EMACS_INT.
13251 * xdisp.c (display_count_lines): 3rd argument and return value now
13252 EMACS_INT. All callers changed.
13253 (pint2hrstr): Last argument is now EMACS_INT.
13255 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13256 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13257 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13258 (decode_coding_utf_16, decode_coding_emacs_mule)
13259 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13260 (decode_coding_ccl, decode_coding_charset)
13261 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13262 (decode_coding_iso_2022, decode_coding_emacs_mule)
13263 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13264 <char_offset, last_offset>: Declare EMACS_INT.
13265 (encode_coding_utf_8, encode_coding_utf_16)
13266 (encode_coding_emacs_mule, encode_invocation_designation)
13267 (encode_designation_at_bol, encode_coding_iso_2022)
13268 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13269 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13271 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13272 (encode_invocation_designation): Last argument P_NCHARS is now
13274 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13275 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13277 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13280 * ccl.c (Fccl_execute_on_string): Declare some variables
13283 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13285 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13287 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13289 * process.c (Fformat_network_address): Doc fix.
13291 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13293 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13295 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13297 * keyboard.c (read_char): Call Lisp function help-form-show,
13298 instead of using internal_with_output_to_temp_buffer.
13299 (Qhelp_form_show): New var.
13300 (syms_of_keyboard): Use DEFSYM macro.
13302 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13304 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13306 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13308 * process.c (Flist_processes): Remove to Lisp.
13309 (list_processes_1): Delete.
13311 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13313 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13315 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13317 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13319 Fix more problems found by GCC 4.6.0's static checks.
13321 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13323 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13325 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13327 * xdisp.c (vmessage): Mark as a printf-like function.
13329 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13331 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13333 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13334 printf-like functions.
13335 (tiff_load): Add casts to remove these marks before passing them
13336 to system-supplied API.
13338 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13340 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13341 This avoids several warnings with gcc -Wstrict-overflow.
13342 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13343 directly, rather than having caller test rule sign. This avoids
13344 some unnecessary tests.
13345 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13346 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13347 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13349 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13350 (xfont_open): Avoid unnecessary tests.
13352 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13354 * composite.h, composite.c (composition_gstring_put_cache):
13355 Use EMACS_INT, not int, for length.
13357 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13358 breaking out part of COMPOSITION_DECODE_RULE.
13359 (COMPOSITION_DECODE_RULE): Use it.
13360 * composite.c (get_composition_id): Remove unused local vars,
13361 by using the new macro.
13363 * textprop.c (set_text_properties_1): Change while to do-while,
13364 since the condition is always true at first.
13366 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13367 (interval_deletion_adjustment): Return unsigned value.
13370 * process.c (list_processes_1, create_pty, read_process_output):
13371 (exec_sentinel): Remove vars that were set but not used.
13372 (create_pty): Remove unnecessary "volatile"s.
13373 (Fnetwork_interface_info): Avoid possibility of int overflow.
13374 (read_process_output): Do adaptive read buffering even if carryover.
13375 (read_process_output): Simplify nbytes computation if buffered.
13377 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13379 * syntax.c (scan_words): Remove var that was set but not used.
13380 (update_syntax_table): Use unsigned instead of int.
13382 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13383 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13384 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13386 * print.c (print_error_message): Avoid int overflow.
13388 * font.c (font_list_entities): Redo for clarity,
13389 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13391 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13392 (font_score): Avoid potential overflow in diff calculation.
13394 * fns.c (substring_both): Remove var that is set but not used.
13395 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13397 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13399 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13400 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13401 can always succeed if overflow has undefined behavior.
13403 * search.c (boyer_moore, wordify): Remove vars set but not used.
13404 (wordify): Omit three unnecessary tests.
13406 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13407 All callers changed. This avoids the need for an unused var.
13409 * casefiddle.c (casify_region): Remove var that is set but not used.
13411 * dired.c (file_name_completion): Remove var that is set but not used.
13413 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13415 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13416 (Finsert_file_contents): Remove unnecessary code checking fd.
13418 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13419 Check for integer overflow on size calculations.
13421 * buffer.c (Fprevious_overlay_change): Remove var that is set
13424 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13425 Remove vars that are set but not used.
13426 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13427 (timer_check_2): Mark vars as initialized.
13429 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13431 * image.c (lookup_image): Remove var that is set but not used.
13432 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13434 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13435 that are set but not used.
13437 * xfns.c (make_invisible_cursor): Don't return garbage
13438 if XCreateBitmapFromData fails (Bug#8410).
13440 * xselect.c (x_get_local_selection, x_handle_property_notify):
13441 Remove vars that are set but not used.
13443 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13444 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13446 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13447 Remove var that is set but not used.
13448 (scroll_bar_windows_size): Now size_t, not int.
13449 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13450 Check for overflow.
13452 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13453 (map_tty_color) [!defined MSDOS]: Likewise.
13455 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13457 * coding.c: Remove vars that are set but not used.
13458 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13459 All callers changed.
13460 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13461 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13462 (decode_coding_charset): Remove vars that are set but not used.
13464 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13465 that is set but not used.
13467 * print.c (print_object): Remove var that is set but not used.
13469 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13470 The gnulib version avoids calling malloc in the usual case,
13471 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13472 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13473 * filelock.c (current_lock_owner): Likewise.
13474 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13475 * sysdep.c: Include allocator.h, careadlinkat.h.
13476 (emacs_no_realloc_allocator): New static constant.
13477 (emacs_readlink): New function.
13478 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13479 ../lib/careadlinkat.h.
13481 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13483 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13484 first non-nil return value).
13486 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13488 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13489 if not defined (Bug#8403).
13491 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13493 * xdisp.c (display_count_lines): Remove parameter `start',
13494 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13495 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13496 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13497 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13498 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13499 and thereabouts. All callers changed.
13500 (get_per_char_metric): Remove parameter `f', unused since
13501 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13503 2011-04-02 Jim Meyering <meyering@redhat.com>
13505 do not dereference NULL upon failed strdup
13506 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13507 (ns_get_family): Likewise.
13509 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13511 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13513 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13515 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13518 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13520 Add lexical binding.
13522 * window.c (Ftemp_output_buffer_show): New fun.
13523 (Fsave_window_excursion):
13524 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13526 * lread.c (lisp_file_lexically_bound_p): New function.
13527 (Fload): Bind Qlexical_binding.
13528 (readevalloop): Remove `evalfun' arg.
13529 Bind Qinternal_interpreter_environment.
13530 (Feval_buffer): Bind Qlexical_binding.
13531 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13533 (syms_of_lread): Declare `lexical-binding'.
13535 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13537 * keyboard.c (eval_dyn): New fun.
13538 (menu_item_eval_property): Use it.
13540 * image.c (parse_image_spec): Use Ffunctionp.
13542 * fns.c (concat, mapcar1): Accept byte-code-functions.
13544 * eval.c (Fsetq): Handle lexical vars.
13545 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13546 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13547 (FletX, Flet): Obey lexical binding.
13548 (Fcommandp): Handle closures.
13549 (Feval): New `lexical' arg.
13550 (eval_sub): New function extracted from Feval. Use it almost
13551 everywhere where Feval was used. Look up vars in lexical env.
13553 (Ffunctionp): Move from subr.el.
13554 (Ffuncall): Handle closures.
13555 (apply_lambda): Remove `eval_flags'.
13556 (funcall_lambda): Handle closures and new byte-code-functions.
13557 (Fspecial_variable_p): New function.
13558 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13559 but without exporting it to Lisp.
13561 * doc.c (Fdocumentation, store_function_docstring):
13562 * data.c (Finteractive_form): Handle closures.
13564 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13567 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13569 (exec_byte_code): New function extracted from Fbyte_code to handle new
13570 calling convention for byte-code-functions. Add new byte-codes.
13572 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13574 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13576 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13578 * xdisp.c (redisplay_internal): Fix prototype.
13580 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13582 * xdisp.c (SCROLL_LIMIT): New macro.
13583 (try_scrolling): Use it when setting scroll_limit.
13584 Limit scrolling to 100 screen lines.
13585 (redisplay_window): Even when falling back on "recentering",
13586 position point in the window according to scroll-conservatively,
13587 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13589 (try_scrolling): When point is above the window, allow searching
13590 as far as scroll_max, or one screenful, to compute vertical
13591 distance from PT to the scroll margin position. This prevents
13592 try_scrolling from unnecessarily failing when
13593 scroll-conservatively is set to a value slightly larger than the
13594 window height. Clean up the case of PT below the margin at bottom
13595 of window: scroll_max can no longer be INT_MAX. When aggressive
13596 scrolling is in use, don't let point enter the opposite scroll
13597 margin as result of the scroll.
13598 (syms_of_xdisp) <scroll-conservatively>: Document the
13599 threshold of 100 lines for never-recentering scrolling.
13601 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13603 * dispextern.h (move_it_by_lines):
13604 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13605 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13606 (message_log_check_duplicate): Remove parameters `prev_bol' and
13607 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13608 (redisplay_internal): Remove parameter `preserve_echo_area',
13609 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13611 * indent.c (Fvertical_motion):
13612 * window.c (window_scroll_pixel_based, Frecenter):
13613 Don't pass `need_y_p' to `move_it_by_lines'.
13615 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13617 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13618 steal a few bits to be more compact.
13619 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13620 Remove unneeded casts.
13622 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13624 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13626 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13627 binding" message (bug#7967).
13629 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13631 Fix more problems found by GCC 4.6.0's static checks.
13633 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13634 Remove unused local var.
13636 * editfns.c (Fmessage_box): Remove unused local var.
13638 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13639 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13640 Omit unused local vars.
13641 * window.c (shrink_windows): Omit unused local var.
13642 * menu.c (digest_single_submenu): Omit unused local var.
13643 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13644 Omit unused local var.
13646 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13647 Don't assume string length fits in int.
13648 (keyremap_step, read_key_sequence): Use size_t for sizes.
13649 (read_key_sequence): Don't check last_real_key_start redundantly.
13651 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13652 instead of alloca (Bug#8344).
13654 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13655 (Fbacktrace_frame): Don't assume nframes fits in int.
13657 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13659 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13662 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13664 * cm.c (calccost): Turn while-do into do-while, for clarity.
13666 * keyboard.c (syms_of_keyboard): Use the same style as later
13667 in this function when indexing through an array. This also
13668 works around GCC bug 48267.
13670 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13672 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13674 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13675 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13677 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13678 This avoids undefined behavior on integer overflow, and is a bit
13679 more convenient anyway since it is compared to a size_t variable.
13681 Variadic C functions now count arguments with size_t, not int.
13682 This avoids an unnecessary limitation on 64-bit machines, which
13683 caused (substring ...) to crash on large vectors (Bug#8344).
13684 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13685 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13686 All variadic functions and their callers changed accordingly.
13687 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13688 * data.c (arith_driver, float_arith_driver): Likewise.
13689 * editfns.c (general_insert_function): Likewise.
13690 * eval.c (struct backtrace.nargs, interactive_p)
13691 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13692 (funcall_lambda, mark_backtrace): Likewise.
13693 * fns.c (concat): Likewise.
13694 * frame.c (x_set_frame_parameters): Likewise.
13695 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13696 0 if not found, not -1. All callers changed.
13698 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13699 (stack_copy_size): Now size_t, not int.
13700 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13702 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13704 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13705 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13706 All callers changed.
13708 * lisp.h (multibyte_char_to_unibyte):
13709 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13710 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13711 * character.h (CHAR_TO_BYTE8):
13712 * cmds.c (internal_self_insert):
13713 * editfns.c (general_insert_function):
13714 * keymap.c (push_key_description):
13715 * search.c (Freplace_match):
13716 * xdisp.c (message_dolog, set_message_1): All callers changed.
13718 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13720 * keyboard.c (safe_run_hook_funcall): New function.
13721 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13722 don't set the hook to nil, but remove the offending function instead.
13723 (Qcommand_hook_internal): Remove, unused.
13724 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13725 Vcommand_hook_internal.
13727 * eval.c (enum run_hooks_condition): Remove.
13728 (funcall_nil, funcall_not): New functions.
13729 (run_hook_with_args): Call each function through a `funcall' argument.
13730 Remove `cond' argument, now redundant.
13731 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13732 (Frun_hook_with_args_until_failure): Adjust accordingly.
13733 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13735 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13737 * dispextern.h (string_buffer_position): Remove declaration.
13739 * print.c (strout): Remove parameter `multibyte', unused since
13740 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13742 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13743 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13744 All callers changed.
13746 * w32.c (_wsa_errlist): Use braces for struct initializers.
13748 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13749 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13750 All callers changed.
13751 (string_buffer_position): Likewise. Also, make static (it's never
13752 used outside xdisp.c).
13753 (cursor_row_p): Remove parameter `w', unused since
13754 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13755 (decode_mode_spec): Remove parameter `precision', introduced during
13756 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13757 All callers changed.
13759 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13761 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13763 2011-03-27 Anders Lindgren <andlind@gmail.com>
13765 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13766 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13767 (ns_update_auto_hide_menu_bar): New functions.
13768 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13769 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13770 ns_constrain_all_frames.
13771 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13772 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13774 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13776 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13778 2011-03-27 Glenn Morris <rgm@gnu.org>
13780 * syssignal.h: Replace RETSIGTYPE with void.
13781 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13782 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13783 Replace SIGTYPE with void everywhere.
13784 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13785 * s/template.h (SIGTYPE): Remove commented out definition.
13787 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13789 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13790 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13792 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13794 * w32.c (read_unc_volume): Use parameter `henum', instead of
13795 global variable `wget_enum_handle'.
13797 * keymap.c (describe_vector): Remove parameters `indices' and
13798 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13799 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13801 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13803 * keyboard.c (timer_check): Remove parameter `do_it_now',
13804 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13805 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13806 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13808 * keyboard.c (read_char):
13809 * w32menu.c (w32_menu_display_help):
13810 * xmenu.c (show_help_event, menu_help_callback):
13811 Adjust calls to `show_help_echo'.
13813 * gtkutil.c (xg_maybe_add_timer):
13814 * keyboard.c (readable_events):
13815 * process.c (wait_reading_process_output):
13816 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13818 * insdel.c (adjust_markers_gap_motion):
13819 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13820 (gap_left, gap_right): Don't call it.
13822 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13824 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13825 incurred during fontification.
13827 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13829 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13830 (DEFVAR_PER_BUFFER): Don't pass it.
13832 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13833 (scrolling_window): Don't pass it.
13835 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13837 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13839 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13841 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13842 of variables specific to SELinux and computation of `encoded_absname'.
13844 * image.c (XPutPixel): Remove unused variable `height'.
13846 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13848 * unexw32.c (get_section_info): Remove unused variable `section'.
13850 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13851 (system_process_attributes): Remove unused variable `sess'.
13852 (sys_read): Remove unused variable `err'.
13854 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13855 (w32_wnd_proc): Remove unused variable `isdead'.
13856 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13857 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13858 (x_create_tip_frame): Remove unused variable `tem'.
13860 * w32inevt.c (w32_console_read_socket):
13861 Remove unused variable `no_events'.
13863 * w32term.c (x_draw_composite_glyph_string_foreground):
13864 Remove unused variable `width'.
13866 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13868 * w32term.c (x_set_glyph_string_clipping):
13869 Don't pass uninitialized region to CombineRgn.
13871 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13873 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13874 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13875 (Fx_close_connection): Remove unused variable `i'.
13877 * w32font.c (w32font_draw): Return number of glyphs.
13878 (w32font_open_internal): Remove unused variable `i'.
13879 (w32font_driver): Add missing initializer.
13881 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13882 (fill_in_menu): Remove unused variable `items_added'.
13884 * w32term.c (last_mouse_press_frame): Remove static global variable.
13885 (w32_clip_to_row): Remove unused variable `f'.
13886 (x_delete_terminal): Remove unused variable `i'.
13888 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13889 (NOTHING): Remove unused static global variable.
13890 (uniscribe_check_otf): Remove unused variable `table'.
13891 (uniscribe_font_driver): Add missing initializers.
13893 2011-03-23 Julien Danjou <julien@danjou.info>
13895 * term.c (Fsuspend_tty, Fresume_tty):
13896 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13897 * window.c (temp_output_buffer_show):
13898 * insdel.c (signal_before_change):
13899 * frame.c (Fhandle_switch_frame):
13900 * fileio.c (Fdo_auto_save):
13901 * emacs.c (Fkill_emacs):
13902 * editfns.c (save_excursion_restore):
13903 * cmds.c (internal_self_insert):
13904 * callint.c (Fcall_interactively):
13905 * buffer.c (Fkill_all_local_variables):
13906 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13908 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13909 unconditionally since it does the check itself.
13911 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13913 Fix more problems found by GCC 4.5.2's static checks.
13915 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13916 the first time through the loop, since we know p0 < p1 then.
13917 This also avoids a gcc -Wstrict-overflow warning.
13919 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13920 leading to a memory leak, possible in functions like
13921 load_charset_map_from_file that can allocate an unbounded number
13922 of objects (Bug#8318).
13924 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13925 that could (at least in theory) be that large.
13927 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13928 This is less likely to overflow, and avoids undefined behavior if
13929 overflow does occur. All callers changed. Use strtoul to scan
13930 for the unsigned long integer.
13931 (pint2hrstr): Simplify and tune code slightly.
13932 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13934 * scroll.c (do_scrolling): Work around GCC bug 48228.
13935 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13937 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13938 This also avoids a warning with gcc -Wstrict-overflow.
13939 (validate_x_resource_name): Simplify count usage.
13940 This also avoids a warning with gcc -Wstrict-overflow.
13942 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13945 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13947 * process.c (Fmake_network_process): Use socklen_t, not int,
13948 where POSIX says socklen_t is required in portable programs.
13949 This fixes a porting bug on hosts like 64-bit HP-UX, where
13950 socklen_t is wider than int (Bug#8277).
13951 (Fmake_network_process, server_accept_connection):
13952 (wait_reading_process_output, read_process_output):
13955 * process.c: Rename or move locals to avoid shadowing.
13956 (list_processes_1, Fmake_network_process):
13957 (read_process_output_error_handler, exec_sentinel_error_handler):
13958 Rename or move locals.
13959 (Fmake_network_process): Define label "retry_connect" only if needed.
13960 (Fnetwork_interface_info): Fix pointer signedness.
13961 (process_send_signal): Add cast to avoid pointer signedness problem.
13962 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13963 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13965 Make tparam.h and terminfo.c consistent.
13966 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13967 Include tparam.h instead, since it declares them.
13968 * cm.h (PC): Remove extern decl; tparam.h now does this.
13969 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13970 * terminfo.c: Include tparam.h, to check interfaces.
13971 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13972 (tparam): Adjust signature to match interface in tparam.h;
13973 this removes some undefined behavior. Check that outstring and len
13974 are zero, which they always are with Emacs.
13975 * tparam.h (PC, BC, UP): New extern decls.
13977 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13978 (xftfont_open): Rename locals to avoid shadowing.
13980 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13981 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13982 (OTF_TAG_SYM): Omit macro if not needed.
13983 (ftfont_list): Remove unused local.
13984 (get_adstyle_property, ftfont_pattern_entity):
13985 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13986 Rename locals to avoid shadowing.
13988 * xfont.c (xfont_list_family): Mark var as initialized.
13990 * xml.c (make_dom): Now static.
13992 * composite.c (composition_compute_stop_pos): Rename local to
13994 (composition_reseat_it): Remove unused locals.
13995 (find_automatic_composition, composition_adjust_point): Likewise.
13996 (composition_update_it): Mark var as initialized.
13997 (find_automatic_composition): Mark vars as initialized,
13998 with a FIXME (Bug#8290).
14000 character.h: Rename locals to avoid shadowing.
14001 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14002 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14003 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14004 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14005 to avoid shadowing.
14007 * textprop.c (property_change_between_p): Remove; unused.
14009 * intervals.c (interval_start_pos): Now static.
14011 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14013 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14014 Rename locals to avoid shadowing.
14016 * sound.c (wav_play, au_play, Fplay_sound_internal):
14017 Fix pointer signedness.
14018 (alsa_choose_format): Remove unused local var.
14019 (wav_play): Initialize a variable to 0, to prevent undefined
14020 behavior (Bug#8278).
14022 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14024 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14026 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14027 clobbering (Bug#8298).
14028 * sysdep.c (sys_subshell): Likewise.
14029 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
14031 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14032 This should get cleaned up, so that child_setup has the
14033 same signature on all platforms.
14035 * callproc.c (call_process_cleanup): Now static.
14036 (relocate_fd): Rename locals to avoid shadowing.
14038 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
14040 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14041 not to be necessary, and produces flickering.
14043 2011-03-20 Glenn Morris <rgm@gnu.org>
14045 * config.in: Remove file.
14047 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14049 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14050 are now in src/globals.h.
14051 (syms_of_minibuf): Remove spurious & from previous change.
14053 2011-03-20 Leo Liu <sdl.web@gmail.com>
14055 * minibuf.c (completing-read-function): New variable.
14056 (completing-read-default): Rename from completing-read.
14057 (completing-read): Call completing-read-function.
14059 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14061 * xfaces.c (Fx_load_color_file):
14062 Read color file from absolute filename (bug#8250).
14064 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14066 * makefile.w32-in: Update dependencies.
14068 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14070 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14072 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14074 Fix more problems found by GCC 4.5.2's static checks.
14076 * process.c (make_serial_process_unwind, send_process_trap):
14077 (sigchld_handler): Now static.
14079 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14080 That way, the code declares only the vars that it needs.
14081 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14082 * s/cygwin.h (PTY_ITERATION): Likewise.
14083 * s/darwin.h (PTY_ITERATION): Likewise.
14084 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14086 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14087 * process.c (allocate_pty): Don't declare stb unless it's needed.
14089 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14090 (CONSTANTLIM): Remove; unused.
14091 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14092 Define only if needed.
14094 * unexelf.c (unexec): Name an expression,
14095 to avoid gcc -Wbad-function-cast warning.
14096 Use a different way to cause a compilation error if anyone uses
14097 n rather than nn, a way that does not involve shadowing.
14098 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14100 * deps.mk (unexalpha.o): Remove; unused.
14102 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14103 * unexec.h: New file.
14104 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14105 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14106 Depend on unexec.h.
14107 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14108 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14109 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14110 Change as necessary to match prototype in unexec.h.
14112 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14114 (back_comment, skip_chars): Mark vars as initialized.
14116 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14117 Rename locals to avoid shadowing.
14119 * lread.c (read1): Rewrite so as not to use empty "else".
14120 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14122 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14124 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14125 warning when compiling print.c.
14127 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14128 instead of using an uninitialized var.
14129 (font_sort_entities): Mark var as initialized.
14131 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14133 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14134 pointers to constants.
14135 (font_parse_fcname): Remove unused vars.
14136 (font_delete_unmatched): Now static.
14137 (font_get_spec): Remove; unused.
14138 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14139 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14140 Rename or move locals to avoid shadowing.
14142 * fns.c (require_nesting_list, require_unwind): Now static.
14143 (Ffillarray): Rename locals to avoid shadowing.
14145 * floatfns.c (domain_error2): Define only if needed.
14146 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14148 * alloc.c (mark_backtrace): Move decl from here ...
14149 * lisp.h: ... to here, so that it can be checked.
14151 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14152 (Fdefvar): Rewrite so as not to use empty "else".
14153 (lisp_indirect_variable): Name an expression,
14154 to avoid gcc -Wbad-function-cast warning.
14155 (Fdefvar): Rename locals to avoid shadowing.
14157 * callint.c (quotify_arg, quotify_args): Now static.
14158 (Fcall_interactively): Rename locals to avoid shadowing.
14159 Use const pointer when appropriate.
14161 * lisp.h (get_system_name, get_operating_system_release):
14162 Move decls here, to check interfaces.
14163 * process.c (get_operating_system_release): Move decl to lisp.h.
14164 * xrdb.c (get_system_name): Likewise.
14165 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14166 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14167 some of which prompt warnings from gcc -Wbad-function-cast.
14168 (Fformat_time_string, Fencode_time, Finsert_char):
14169 (Ftranslate_region_internal, Fformat):
14170 Rename or remove local vars to avoid shadowing.
14171 (Ftranslate_region_internal): Mark var as initialized.
14173 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14176 * lisp.h (eassert): Check that the argument compiles, even if
14177 ENABLE_CHECKING is not defined.
14179 * data.c (Findirect_variable): Name an expression, to avoid
14180 gcc -Wbad-function-cast warning.
14181 (default_value, arithcompare, arith_driver, arith_error): Now static.
14182 (store_symval_forwarding): Rename local to avoid shadowing.
14183 (Fmake_variable_buffer_local, Fmake_local_variable):
14184 Mark variables as initialized.
14185 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14187 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14188 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14189 Rename locals to avoid shadowing.
14190 (mark_stack): Move local variables into the #ifdef region where
14192 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14193 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14195 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14196 (GC_STRING_CHARS): Remove; not used.
14197 (Fmemory_limit): Cast sbrk's returned value to char *.
14199 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14200 avoids undefined behavior in theory.
14202 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14204 Use functions, not macros, for up- and down-casing (Bug#8254).
14205 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14206 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14207 to use the following functions instead of these macros.
14208 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14209 EMACS_INT, since callers assume the returned value fits in int.
14210 (upcase1): Likewise, for UPCASE_TABLE.
14211 (uppercasep, lowercasep, upcase): New static inline functions.
14212 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14213 the race-condition problem in the old DOWNCASE.
14215 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14216 Rename locals to avoid shadowing.
14217 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14218 (regex_compile, re_search_2, re_match_2_internal):
14219 Remove unused local vars.
14220 (FREE_VAR): Rewrite so as not to use empty "else",
14221 which gcc can warn about.
14222 (regex_compile, re_match_2_internal): Mark locals as initialized.
14223 (RETALLOC_IF): Define only if needed.
14224 (WORDCHAR_P): Likewise. This one is never needed, but is used
14225 only in a comment talking about a compiler bug, so put inside
14226 the #if 0 of that comment.
14227 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14228 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14231 * search.c (boyer_moore): Rename locals to avoid shadowing.
14232 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14233 (PREV_CHAR_BOUNDARY): Likewise.
14235 * search.c (simple_search): Remove unused var.
14237 * dired.c (compile_pattern): Move decl from here ...
14238 * lisp.h: ... to here, so that it can be checked.
14239 (struct re_registers): New forward decl.
14241 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14243 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14245 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14246 Rename locals to avoid shadowing.
14247 (Fvertical_motion): Mark locals as initialized.
14249 * casefiddle.c (casify_object, casify_region): Now static.
14250 (casify_region): Mark local as initialized.
14252 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14254 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14255 New macros, so that the caller can use some names other than
14256 gcpro1, gcpro2, etc.
14257 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14259 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14260 argument, for consistency with GCPRO2_VAR, etc: it is now the
14261 prefix of the variable, not the variable itself. All uses
14263 * dired.c (directory_files_internal, file_name_completion):
14264 Rename locals to avoid shadowing.
14266 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14267 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14268 dired.c's scmp function, had undefined behavior.
14269 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14270 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14271 * buffer.h: ... to here, because these macros use current_buffer,
14272 and the new implementation with inline functions needs to have
14273 current_buffer in scope now, rather than later when the macros
14275 (downcase, upcase1): New static inline functions.
14276 (DOWNCASE, UPCASE1): Reimplement using these functions.
14277 This avoids undefined behavior in expressions like
14278 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14279 from race conditions in accessing the global variables
14280 case_temp1 and case_temp2.
14281 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14282 * lisp.h (case_temp1, case_temp2): Remove their decls.
14283 * character.h (ASCII_CHAR_P): Move from here ...
14284 * lisp.h: ... to here, so that the inline functions mentioned
14285 above can use them.
14287 * dired.c (directory_files_internal_unwind): Now static.
14289 * fileio.c (file_name_as_directory, directory_file_name):
14290 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14292 (file_name_as_directory): Use const pointers when appropriate.
14293 (Fexpand_file_name): Likewise. In particular, newdir might
14294 point at constant storage, so make it a const pointer.
14295 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14296 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14298 (Fset_file_times, Finsert_file_contents, auto_save_error):
14299 Rename locals to avoid shadowing.
14301 * minibuf.c (choose_minibuf_frame_1): Now static.
14302 (Ftry_completion, Fall_completions): Rename or remove locals
14303 to avoid shadowing.
14305 * marker.c (bytepos_to_charpos): Remove; unused.
14307 * lisp.h (verify_bytepos, count_markers): New decls,
14308 so that gcc does not warn that these functions aren't declared.
14310 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14311 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14312 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14313 (copy_text): Remove unused local var.
14315 * filelock.c (within_one_second): Now static.
14316 (lock_file_1): Rename local to avoid shadowing.
14318 * buffer.c (fix_overlays_before): Mark locals as initialized.
14319 (fix_start_end_in_overlays): Likewise. This function should be
14320 simplified by using pointers-to-pointers, but that's a different
14322 (switch_to_buffer_1): Now static.
14323 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14324 (report_overlay_modification): Rename locals to avoid shadowing.
14326 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14327 Fix pointer signedness issue.
14328 (sys_subshell): Mark local as volatile if checking for lint,
14329 to suppress a gcc -Wclobbered warning that does not seem to be right.
14330 (MAXPATHLEN): Define only if needed.
14332 * process.c (serial_open, serial_configure): Move decls from here ...
14333 * systty.h: ... to here, so that they can be checked.
14335 * fns.c (get_random, seed_random): Move extern decls from here ...
14336 * lisp.h: ... to here, so that they can be checked.
14338 * sysdep.c (reset_io): Now static.
14339 (wait_for_termination_signal): Remove; unused.
14341 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14342 (copy_keymap_item, append_key, push_text_char_description):
14344 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14345 (DENSE_TABLE_SIZE): Remove; unused.
14346 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14347 (describe_map_tree):
14348 Rename locals to avoid shadowing.
14350 * keyboard.c: Declare functions static if they are not used elsewhere.
14351 (echo_char, echo_dash, cmd_error, top_level_2):
14352 (poll_for_input, handle_async_input): Now static.
14353 (read_char, kbd_buffer_get_event, make_lispy_position):
14354 (make_lispy_event, make_lispy_movement, apply_modifiers):
14355 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14356 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14357 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14358 (read_key_sequence, read_char): Mark locals as initialized.
14359 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14361 * keyboard.h (make_ctrl_char): New decl.
14362 (mark_kboards): Move decl here ...
14363 * alloc.c (mark_kboards): ... from here.
14365 * lisp.h (force_auto_save_soon): New decl.
14367 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14368 (DEFINE_DUMMY_FUNCTION): New macro.
14369 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14371 (main): Add casts to avoid warnings
14372 if GCC considers string literals to be constants.
14374 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14376 * dbusbind.c: Pointer signedness fixes.
14377 (xd_signature, xd_append_arg, xd_initialize):
14378 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14379 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14380 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14381 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14383 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14384 if GCC considers string literals to be constants.
14385 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14387 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14389 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14390 (print_preprocess, print_object): New macro to fix last change.
14392 * print.c (print_preprocess): Don't forget font objects.
14394 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14396 * emacs.c (USAGE3): Doc fixes.
14398 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14400 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14403 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14405 * lisp.h (VWindow_system, Qfile_name_history):
14406 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14407 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14408 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14410 * w32select.c: Don't #include "keyboard.h".
14411 (run_protected): Add extern declaration for waiting_for_input.
14413 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14414 * w32console.c (detect_input_pending, read_input_pending)
14415 (encode_terminal_code):
14416 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14417 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14418 (w32_system_caret_y, Qfile_name_history):
14419 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14420 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14421 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14422 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14423 * w32proc.c (Qlocal, report_file_error):
14424 * w32term.c (Vwindow_system, updating_frame):
14425 * w32uniscribe.c (initialized, uniscribe_font_driver):
14426 Remove unneeded extern declarations.
14428 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14430 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14432 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14434 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14435 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14436 These macros can no longer be used for assignment.
14438 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14439 Assign struct members directly, instead of using BUF_BEGV etc.
14440 (record_buffer_markers, fetch_buffer_markers): New functions for
14441 recording and fetching special buffer markers.
14442 (set_buffer_internal_1, set_buffer_temp): Use them.
14444 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14446 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14448 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14449 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14451 * xdisp.c (hscroll_window_tree):
14452 (reconsider_clip_changes): Use PT instead of BUF_PT.
14454 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14456 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14457 $(EMACS_ROOT)/lib/intprops.h.
14459 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14461 Fix more problems found by GCC 4.5.2's static checks.
14463 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14464 to unsigned char * to avoid compiler diagnostic.
14465 (xg_free_frame_widgets): Make it clear that a local variable is
14466 needed only if USE_GTK_TOOLTIP.
14467 (gdk_window_get_screen): Make it clear that this macro is needed
14468 only if USE_GTK_TOOLTIP.
14469 (int_gtk_range_get_value): New function, which avoids a diagnostic
14470 from gcc -Wbad-function-cast.
14471 (xg_set_toolkit_scroll_bar_thumb): Use it.
14472 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14473 diagnostic from gcc -Wbad-function-cast.
14474 (get_utf8_string, xg_get_file_with_chooser):
14475 Rename locals to avoid shadowing.
14476 (create_dialog): Move locals to avoid shadowing.
14478 * xgselect.c (xg_select): Remove unused var.
14480 * image.c (four_corners_best): Mark locals as initialized.
14481 (gif_load): Initialize transparent_p to zero (Bug#8238).
14482 Mark another local as initialized.
14483 (my_png_error, my_error_exit): Mark with NO_RETURN.
14485 * image.c (clear_image_cache): Now static.
14486 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14487 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14488 (x_edge_detection): Remove unnecessary cast that
14489 gcc -Wbad-function-cast diagnoses.
14490 (gif_load): Fix pointer signedness.
14491 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14492 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14494 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14496 Improve quality of tests for time stamp overflow.
14497 For example, without this patch (encode-time 0 0 0 1 1
14498 1152921504606846976) returns the obviously-bogus value (-948597
14499 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14500 reports time overflow. See
14501 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14502 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14503 * editfns.c: Include limits.h and intprops.h.
14504 (TIME_T_MIN, TIME_T_MAX): New macros.
14505 (time_overflow): Move earlier, to before first use.
14506 (hi_time, lo_time): New functions, for an accurate test for
14507 out-of-range times.
14508 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14509 (Fget_internal_run_time): Don't assume time_t fits in int.
14510 (make_time): Use list2 instead of Fcons twice.
14511 (Fdecode_time): More accurate test for out-of-range times.
14512 (check_tm_member): New function.
14513 (Fencode_time): Use it, to test for out-of-range times.
14514 (lisp_time_argument): Don't rely on undefined left-shift and
14515 right-shift behavior when checking for time stamp overflow.
14517 * editfns.c (time_overflow): New function, refactoring common code.
14518 (Fformat_time_string, Fdecode_time, Fencode_time):
14519 (Fcurrent_time_string): Use it.
14521 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14522 * dired.c (make_time): Move to ...
14523 * editfns.c (make_time): ... here.
14524 * systime.h: Note the move.
14526 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14528 * fringe.c (update_window_fringes): Remove unused variables.
14530 * unexmacosx.c (copy_data_segment): Also copy __got section.
14533 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14535 * termcap.c [MSDOS]: Include "msdos.h".
14536 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14537 Constify `char *' arguments and their references according to
14538 prototypes in tparam.h.
14540 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14542 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14543 Adapt all references accordingly.
14545 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14547 2011-03-11 Tom Tromey <tromey@redhat.com>
14549 * buffer.c (syms_of_buffer): Remove obsolete comment.
14551 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14553 * termhooks.h (encode_terminal_code): Declare prototype.
14555 * msdos.c (encode_terminal_code): Don't declare prototype.
14557 * term.c (encode_terminal_code): Now external again, used by
14558 w32console.c and msdos.c.
14560 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14561 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14563 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14565 Fix some minor problems found by GCC 4.5.2's static checks.
14567 * fringe.c (update_window_fringes): Mark locals as initialized
14569 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14571 * alloc.c (mark_fringe_data): Move decl from here ...
14572 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14573 to check its interface.
14574 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14576 * fontset.c (free_realized_fontset): Now static.
14577 (Fset_fontset_font): Rename local to avoid shadowing.
14578 (fontset_font): Mark local as initialized.
14579 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14581 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14583 * xselect.c (x_disown_buffer_selections): Remove; not used.
14584 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14585 (x_own_selection, Fx_disown_selection_internal): Rename locals
14586 to avoid shadowing.
14587 (x_handle_dnd_message): Remove local to avoid shadowing.
14589 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14590 so that the caller can use some name other than gcpro1.
14591 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14592 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14593 (Fx_backspace_delete_keys_p):
14594 Use them to avoid shadowing, and rename vars to avoid shadowing.
14595 (x_decode_color, x_set_name, x_window): Now static.
14596 (Fx_create_frame): Add braces to silence GCC warning.
14597 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14598 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14599 Remove unused locals.
14600 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14601 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14602 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14605 * xterm.h (x_mouse_leave): New decl.
14607 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14608 Remove unused functions.
14609 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14610 (x_calc_absolute_position): Now static.
14611 (XTread_socket): Don't define label "out" unless it's used.
14612 Don't declare local "event" unless it's used.
14613 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14614 unless they are used.
14615 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14616 (x_fatal_error_signal): Remove; not used.
14617 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14618 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14619 (x_error_catcher, x_connection_closed, x_error_handler):
14620 (x_error_quitter, xembed_send_message, x_iconify_frame):
14621 (my_log_handler): Rename locals to avoid shadowing.
14622 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14623 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14625 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14626 Rename or move locals to avoid shadowing.
14627 (tty_defined_color, merge_face_heights): Now static.
14628 (free_realized_faces_for_fontset): Remove; not used.
14629 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14630 does not deduce is never used uninitialized.
14631 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14632 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14634 * terminal.c (store_terminal_param): Now static.
14636 * xmenu.c (menu_highlight_callback): Now static.
14637 (set_frame_menubar): Remove unused local.
14638 (xmenu_show): Rename parameter to avoid shadowing.
14639 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14640 since they might point to immutable storage.
14641 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14642 since it's unused otherwise.
14644 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14645 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14646 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14647 avoids a gcc -Wuninitialized diagnostic.
14648 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14649 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14650 does not deduce are never used uninitialized.
14652 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14654 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14655 * window.c (window_loop, size_window):
14656 (run_window_configuration_change_hook, enlarge_window): Likewise.
14658 * window.c (display_buffer): Now static.
14659 (size_window): Mark variables that gcc -Wuninitialized
14660 does not deduce are never used uninitialized.
14661 * window.h (check_all_windows): New decl, to forestall
14662 gcc -Wmissing-prototypes diagnostic.
14663 * dispextern.h (bidi_dump_cached_states): Likewise.
14665 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14667 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14668 Include <limits.h>.
14669 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14670 and to avoid gcc -Wuninitialized warning.
14671 (load_charset_map): Mark variables that gcc -Wuninitialized
14672 does not deduce are never used uninitialized.
14673 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14675 * coding.c (coding_set_source, coding_set_destination):
14676 Use "else { /* comment */ }" rather than "else /* comment */;"
14677 for clarity, and to avoid gcc -Wempty-body warning.
14678 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14679 a block, when the outer 'i' will do.
14680 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14681 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14682 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14683 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14684 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14685 Rename locals to avoid shadowing.
14686 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14687 * coding.c (emacs_mule_char, encode_invocation_designation):
14688 Now static, since they're not used elsewhere.
14689 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14690 (decode_coding_object, encode_coding_object, detect_coding_system):
14691 (decode_coding_emacs_mule): Mark variables that gcc
14692 -Wuninitialized does not deduce are never used uninitialized.
14693 (detect_coding_iso_2022): Initialize a local variable that might
14694 be used uninitialized. Leave a FIXME because it's not clear that
14695 this initialization is needed. (Bug#8211)
14696 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14697 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14698 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14699 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14700 Remove unused macros.
14702 * category.c (hash_get_category_set): Remove unused local var.
14703 (copy_category_table): Now static, since it's not used elsewhere.
14704 * character.c (string_count_byte8): Likewise.
14706 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14707 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14709 * chartab.c (copy_sub_char_table): Now static, since it's not used
14711 (sub_char_table_ref_and_range, char_table_ref_and_range):
14712 Rename locals to avoid shadowing.
14713 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14715 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14716 (BIDI_BOB): Remove unused macro.
14718 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14719 deduce are never used uninitialized.
14720 * term.c (encode_terminal_code): Likewise.
14722 * term.c (encode_terminal_code): Now static. Remove unused local.
14724 * tparam.h: New file.
14725 * term.c, tparam.h: Include it.
14726 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14727 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14728 Move these decls to tparam.h, and make them agree with what
14729 is actually in tparam.c. The previous trick of using incompatible
14730 decls in different modules does not conform to the C standard.
14731 All callers of tparam changed to use tparam's actual API.
14732 * tparam.c (tparam1, tparam, tgoto):
14733 Use const pointers where appropriate.
14735 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14736 * cm.h (struct cm): Likewise.
14737 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14738 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14739 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14740 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14741 (turn_on_face, init_tty): Likewise.
14742 * termchar.h (struct tty_display_info): Likewise.
14744 * term.c (term_mouse_position): Rename local to avoid shadowing.
14746 * alloc.c (mark_ttys): Move decl from here ...
14747 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14749 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14751 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14753 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14755 * search.c (compile_pattern_1): Remove argument regp, unused since
14756 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14757 (compile_pattern): Don't pass it.
14759 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14761 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14762 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14764 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14766 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14768 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14769 gdk_window_get_screen, gdk_window_get_geometry,
14770 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14771 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14772 (xg_get_pixbuf_from_pixmap): New function.
14773 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14774 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14775 Call xg_get_pixbuf_from_pixmap instead of
14776 gdk_pixbuf_get_from_drawable.
14777 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14778 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14779 (xg_check_special_colors): Use GtkStyleContext and its functions
14781 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14782 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14783 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14784 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14785 Call gtk_widget_get_preferred_size.
14786 (xg_frame_resized): gdk_window_get_geometry only takes 5
14788 (xg_win_to_widget, xg_event_is_for_menubar):
14789 Call gdk_x11_window_lookup_for_display.
14790 (xg_set_widget_bg): New function.
14791 (delete_cb): New function.
14792 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14793 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14794 (xg_set_background_color): Call xg_set_widget_bg.
14795 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14796 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14797 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14798 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14800 (update_frame_tool_bar): Call gtk_widget_hide.
14801 (xg_initialize): Use GDK_KEY_g.
14803 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14805 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14807 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14808 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14809 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14811 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14813 * w32xfns.c (select_palette): Check success of RealizePalette against
14814 GDI_ERROR, not zero.
14816 See ChangeLog.11 for earlier changes.
14818 ;; Local Variables:
14822 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14824 This file is part of GNU Emacs.
14826 GNU Emacs is free software: you can redistribute it and/or modify
14827 it under the terms of the GNU General Public License as published by
14828 the Free Software Foundation, either version 3 of the License, or
14829 (at your option) any later version.
14831 GNU Emacs is distributed in the hope that it will be useful,
14832 but WITHOUT ANY WARRANTY; without even the implied warranty of
14833 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14834 GNU General Public License for more details.
14836 You should have received a copy of the GNU General Public License
14837 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.