1 2012-03-25 Kenichi Handa <handa@m17n.org>
3 * dispextern.h (struct glyph): Change the bit length of
4 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6 2012-03-24 Eli Zaretskii <eliz@gnu.org>
8 * s/ms-w32.h (tzname): Include time.h before redirecting to
9 _tzname. Fixes the MSVC build. (Bug#9960)
11 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
13 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
16 * xterm.c (XTread_socket): Only modify handling_signal if
17 !SYNC_INPUT. (Bug#11080)
19 2012-03-23 Eli Zaretskii <eliz@gnu.org>
21 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
22 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
23 when fetching a multibyte character consumes more bytes than
24 CHAR_BYTES returns, due to unification of CJK characters in
25 string_char. (Bug#11073)
27 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
29 * process.c (wait_reading_process_output): Handle pty disconnect
30 by refraining from sending oneself a SIGCHLD (bug#10933).
32 2012-03-22 Chong Yidong <cyd@gnu.org>
34 * dispextern.h (struct it): New member string_from_prefix_prop_p.
36 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
37 Mark string as coming from a prefix property.
38 (handle_face_prop): Use default face for prefix strings (Bug#4281).
39 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
41 2012-03-21 Chong Yidong <cyd@gnu.org>
43 * xfaces.c (Vface_remapping_alist): Doc fix.
45 2012-03-20 Eli Zaretskii <eliz@gnu.org>
47 * w32proc.c (Fw32_set_console_codepage)
48 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
51 2012-03-20 Chong Yidong <cyd@gnu.org>
53 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
54 to reflect default non-nil value of redisplay-dont-pause.
56 2012-03-19 Kenichi Handa <handa@m17n.org>
58 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
59 it fit in a valid range (Bug#11003).
61 2012-03-18 Eli Zaretskii <eliz@gnu.org>
63 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
64 that is not from display property, accept the row as a "cursor
65 row" if one of the string's character has a non-nil `cursor'
66 property. Fixes cursor positioning when there are newlines in
67 overlay strings, e.g. in icomplete.el. (Bug#11035)
69 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
71 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
73 2012-03-12 Chong Yidong <cyd@gnu.org>
75 * eval.c (inhibit_lisp_code): Rename from
76 inhibit_window_configuration_change_hook; move from window.c.
78 * xfns.c (unwind_create_frame_1, Fx_create_frame):
79 * window.c (run_window_configuration_change_hook)
80 (syms_of_window): Callers changed.
82 2012-03-11 Chong Yidong <cyd@gnu.org>
84 * keymap.c (Fkey_description): Doc fix (Bug#9700).
86 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
88 2012-03-10 Chong Yidong <cyd@gnu.org>
90 * frame.c (other_visible_frames): Don't assume the selected frame
91 is visible (Bug#10955).
93 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
95 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
97 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
99 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
100 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
103 2012-03-03 Glenn Morris <rgm@gnu.org>
105 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
107 2012-03-02 Eli Zaretskii <eliz@gnu.org>
109 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
110 position past the first glyph_row that ends at ZV. (Bug#10902)
111 (redisplay_window, next_element_from_string): Fix typos in
113 (redisplay_window): Pass to move_it_vertically the margin in
114 pixels, not in screen lines.
116 2012-03-02 Glenn Morris <rgm@gnu.org>
118 * buffer.c (buffer-list-update-hook): Doc fix.
120 2012-02-29 Eli Zaretskii <eliz@gnu.org>
122 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
123 push_it before setting up the iterator for the first overlay
124 string, even if we have an empty string loaded.
125 (next_overlay_string): If there's an empty string on the iterator
126 stack, pop the stack. (Bug#10903)
128 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
130 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
131 Suggested by Stefan Monnier in
132 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
133 * alloc.c (widen_to_Lisp_Object): New static function.
134 (mark_memory): Also mark Lisp_Objects by fetching pointer words
135 and widening them to Lisp_Objects. This would work even if
136 USE_LSB_TAG is defined and wide integers are used, which might
137 happen in a future version of Emacs.
139 2012-02-25 Chong Yidong <cyd@gnu.org>
141 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
144 * xselect.c (Fx_selection_exists_p): Doc fix.
145 (x_clipboard_manager_save_all): Print an informative message
146 before saving to clipboard manager.
148 2012-02-24 Chong Yidong <cyd@gnu.org>
150 * keyboard.c (process_special_events): Handle all X selection
151 requests in kbd_buffer, not just the next one (Bug#8869).
153 2012-02-23 Chong Yidong <cyd@gnu.org>
155 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
156 call when setting menu-bar-lines and tool-bar-lines parameters.
157 (unwind_create_frame_1): New helper function.
159 * window.c (inhibit_window_configuration_change_hook): New var.
160 (run_window_configuration_change_hook): Obey it.
161 (syms_of_window): Initialize it.
163 2012-02-22 Chong Yidong <cyd@gnu.org>
165 * xterm.c (x_draw_image_relief): Add missing type check for
166 Vtool_bar_button_margin (Bug#10743).
168 2012-02-21 Chong Yidong <cyd@gnu.org>
170 * fileio.c (Vfile_name_handler_alist): Doc fix.
172 * buffer.c (Fget_file_buffer): Protect against invalid file
173 handler return value.
175 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
177 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
178 when computing $valmask.
180 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
181 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
182 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
183 It's useless in that case, and it can cause problems on hosts
184 that allocate halves of EMACS_INT values separately.
185 Reported by Dan Horák. Diagnosed by Andreas Schwab in
186 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
187 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
188 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
189 it avoids undefined behavior on hosts where shifting right by more
190 than the word width has undefined behavior.
192 2012-02-19 Chong Yidong <cyd@gnu.org>
194 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
195 (Funhandled_file_name_directory, Ffile_name_as_directory)
196 (Fdirectory_file_name, Fexpand_file_name)
197 (Fsubstitute_in_file_name): Protect against invalid file handler
198 return values (Bug#10845).
200 2012-02-18 Eli Zaretskii <eliz@gnu.org>
202 * .gdbinit (pitx): Fix incorrect references to fields of the
205 2012-02-17 Chong Yidong <cyd@gnu.org>
207 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
209 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
211 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
212 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
214 2012-02-15 Chong Yidong <cyd@gnu.org>
216 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
217 marked as special. Also, starting docstrings with * is obsolete.
219 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
221 * gnutls.c (emacs_gnutls_write): Fix last change.
223 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
225 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
228 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
230 * keymap.c (Fsingle_key_description): Handle char ranges.
232 2012-02-12 Chong Yidong <cyd@gnu.org>
234 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
235 as that creates a dangerous corner case.
237 * window.c (Fdelete_window_internal): Invalidate the mouse
238 highlight (Bug#9904).
240 2012-02-12 Glenn Morris <rgm@gnu.org>
242 * xselect.c (Fx_own_selection_internal)
243 (Fx_get_selection_internal, Fx_disown_selection_internal)
244 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
245 * nsselect.m (Fx_own_selection_internal)
246 (Fx_disown_selection_internal, Fx_selection_exists_p)
247 (Fx_selection_owner_p, Fx_get_selection_internal):
248 Sync docs and argument specs with the xselect.c versions.
250 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
252 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
254 2012-02-11 Eli Zaretskii <eliz@gnu.org>
256 * w32select.c (Fx_selection_exists_p): Sync doc string and
257 argument list with xselect.c. (Bug#10783)
259 * w16select.c (Fx_selection_exists_p): Sync doc string and
260 argument list with xselect.c. (Bug#10783)
262 2012-02-10 Glenn Morris <rgm@gnu.org>
264 * fns.c (Fsecure_hash): Doc fix.
266 2012-02-09 Kenichi Handa <handa@m17n.org>
268 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
270 2012-02-07 Chong Yidong <cyd@gnu.org>
272 * buffer.c (Fbuffer_local_variables)
273 (buffer_lisp_local_variables): Handle unbound vars correctly;
274 don't let Qunbound leak into Lisp.
276 2012-02-07 Glenn Morris <rgm@gnu.org>
278 * image.c (Fimagemagick_types): Doc fix.
280 * image.c (imagemagick-render-type): Change it from a lisp object
281 to an integer. Move the doc here from the lisp manual.
282 Treat all values not equal to 0 the same.
284 2012-02-06 Chong Yidong <cyd@gnu.org>
286 * doc.c (store_function_docstring): Avoid applying docstring of
287 alias to base function (Bug#2603).
289 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
291 * .gdbinit (pp1, pv1): Remove redundant defines.
294 2012-02-04 Chong Yidong <cyd@gnu.org>
296 * nsterm.m: Declare a global (Bug#10694).
298 2012-02-04 Eli Zaretskii <eliz@gnu.org>
300 * w32.c (get_emacs_configuration_options):
301 Include --enable-checking, if specified, in the return value.
303 2012-02-04 Martin Rudalics <rudalics@gmx.at>
305 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
306 after rounding frame sizes. (Bug#9723)
308 2012-02-04 Eli Zaretskii <eliz@gnu.org>
310 * keyboard.c (adjust_point_for_property): Don't position point
311 before BEGV. (Bug#10696)
313 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
315 Handle overflow when computing char display width (Bug#9496).
316 * character.c (char_width): Return EMACS_INT, not int.
317 (char_width, c_string_width): Check for overflow when
318 computing the width; this is possible now that individual
319 characters can have unbounded width. Problem introduced
320 by merge from Emacs 23 on 2012-01-19.
322 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
324 * dbusbind.c (Fdbus_register_method): Mention the return value
325 :ignore in the docstring.
327 2012-02-02 Glenn Morris <rgm@gnu.org>
329 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
331 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
332 Unconditionally set to t. (Bug#10673)
333 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
334 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
335 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
337 2012-02-02 Kenichi Handa <handa@m17n.org>
339 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
340 0, do not call append_composite_glyph.
342 2012-02-02 Kenichi Handa <handa@m17n.org>
344 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
346 (x_produce_glyphs): If the component of a composition is a null
347 string, set it->pixel_width to 1 to avoid zero-width glyph.
349 2012-02-01 Eli Zaretskii <eliz@gnu.org>
351 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
352 first 2 arguments are identical. This makes inserting large
353 output from a subprocess an order of magnitude faster on
354 MS-Windows, where all sbrk'ed memory is always contiguous.
356 2012-01-31 Glenn Morris <rgm@gnu.org>
358 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
359 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
360 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
362 2012-01-29 Glenn Morris <rgm@gnu.org>
364 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
366 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
368 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
370 2012-01-28 Chong Yidong <cyd@gnu.org>
372 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
374 2012-01-26 Chong Yidong <cyd@gnu.org>
376 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
378 * search.c (Fsearch_forward, Fsearch_backward): Document negative
379 repeat counts (Bug#10507).
381 2012-01-26 Glenn Morris <rgm@gnu.org>
383 * lread.c (syms_of_lread): Doc fix.
385 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
387 * coding.c (encode_designation_at_bol): Change return value to
390 2012-01-25 Chong Yidong <cyd@gnu.org>
392 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
394 2012-01-21 Chong Yidong <cyd@gnu.org>
396 * floatfns.c (Fcopysign): Make the second argument non-optional,
397 since nil is not allowed anyway.
399 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
401 * process.c (read_process_output): Use p instead of XPROCESS (proc).
402 (send_process): Likewise.
404 2012-01-19 Martin Rudalics <rudalics@gmx.at>
406 * window.c (save_window_save, Fcurrent_window_configuration)
407 (Vwindow_persistent_parameters): Do not use Qstate.
410 2012-01-19 Kenichi Handa <handa@m17n.org>
412 * character.c (char_width): New function.
413 (Fchar_width, c_string_width, lisp_string_width):
414 Use char_width (Bug#9496).
416 2012-01-16 Martin Rudalics <rudalics@gmx.at>
418 * window.c (Vwindow_persistent_parameters): New variable.
419 (Fset_window_configuration, save_window_save): Handle persistent
422 2012-01-14 Eli Zaretskii <eliz@gnu.org>
424 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
425 thrashing the stack of the thread. (Bug#9087)
427 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
429 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
431 2012-01-11 Eli Zaretskii <eliz@gnu.org>
433 * xdisp.c (rows_from_pos_range): Handle the case where the
434 highlight ends on a newline. (Bug#10464)
435 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
436 he end column for display of highlight that ends on a newline
439 2012-01-11 Glenn Morris <rgm@gnu.org>
441 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
442 from load-path also when installation-directory is nil. (Bug#10208)
444 2012-01-10 Glenn Morris <rgm@gnu.org>
446 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
448 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
449 Update template values to be closer to their typical values these days.
451 2012-01-09 Eli Zaretskii <eliz@gnu.org>
453 * xdisp.c (rows_from_pos_range): Accept additional argument
454 DISP_STRING, and accept any glyph in a row whose object is that
455 string as eligible for mouse highlight. Fixes mouse highlight of
456 display strings from overlays. (Bug#10464)
458 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
460 emacs: fix an auto-save permissions race condition (Bug#10400)
461 * fileio.c (auto_saving_dir_umask): New static var.
462 (Fmake_directory_internal): Use it.
463 (do_auto_save_make_dir): Set it, instead of invoking chmod after
464 creating the directory. The old code temporarily assigns
465 too-generous permissions to the directory.
466 (do_auto_save_eh): Clear it.
467 (Fdo_auto_save): Catch all errors, not just file errors, so
468 that the var is always cleared.
470 2012-01-07 Eli Zaretskii <eliz@gnu.org>
472 * search.c (scan_buffer): Pass character positions to
473 know_region_cache, not byte positions. (Bug#6540)
475 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
477 * w32.c (sys_rename): Report EXDEV when rename of a directory
478 fails because the target is on another logical disk. (Bug#10284)
480 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
482 * xterm.c (x_embed_request_focus): New function.
484 * xterm.h: Add prototype.
486 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
488 2012-01-05 Glenn Morris <rgm@gnu.org>
490 * emacs.c (emacs_copyright): Update short copyright year to 2012.
492 2012-01-01 Eli Zaretskii <eliz@gnu.org>
494 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
495 Load gnutls_transport_set_lowat only if GnuTLS version is below
497 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
498 GnuTLS versions below 2.11.1.
500 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
502 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
503 to the doc string advising against its use for altering the way
504 windows are scrolled.
506 2011-12-28 Kenichi Handa <handa@m17n.org>
508 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
509 coding-system ASCII compatible only when it does not produce BOM
510 on encoding (Bug#10383).
512 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
514 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
516 (create_and_show_popup_menu): Always use menu_position_func for
519 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
521 * callint.c (Fcall_interactively): Don't truncate prompt string.
523 2011-12-23 Eli Zaretskii <eliz@gnu.org>
525 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
526 property that ends at ZV, so that the bidi iteration could be
527 resumed from there (after widening). (Bug#10360)
529 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
531 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
533 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
535 * nsterm.m (x_free_frame_resources):
536 Release f->output_data.ns->miniimage.
537 (ns_index_color): Fix indentation. Do not retain
538 color_table->colors[i].
540 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
543 * nsfns.m (x_set_background_color): Assign return value from
544 ns_index_color to face-background instead of NSColor*.
545 (ns_implicitly_set_icon_type): Fix indentation.
546 Change assignment in for loop to comparison.
548 * emacs.c (ns_pool): New variable.
549 (main): Assign ns_pool.
550 (Fkill_emacs): Call ns_release_autorelease_pool.
552 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
553 autorelease fdesc, release fdAttrs and tdict.
554 (ns_get_covering_families): Release charset.
555 (ns_findfonts): Release NSFontDescriptor created with new.
556 (ns_uni_to_glyphs): Fix indentation.
557 (setString): Release attrStr before assigning new value.
559 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
561 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
563 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
564 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
566 2011-12-18 David Reitter <reitter@cmu.edu>
568 * nsterm.m (ns_term_init): Subscribe for notifications
569 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
570 to method trackingNotification in EmacsMenu.
572 * nsmenu.m (trackingMenu): New variable.
573 (trackingNotification): New method (from Aquamacs).
574 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
575 from Aquamacs (Bug#7030).
577 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
579 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
580 (symbol_to_nsstring): Fix indentation.
581 (ns_symbol_to_pb): New function.
582 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
583 (Fns_rotate_cut_buffers_internal): Remove.
584 (Fns_store_selection_internal): Rename from
585 Fns_store_cut_buffer_internal.
586 (ns_get_foreign_selection, Fx_own_selection_internal)
587 (Fx_disown_selection_internal, Fx_selection_exists_p)
588 (Fns_get_selection_internal, Fns_store_selection_internal):
589 Use ns_symbol_to_pb and check if return value is nil.
590 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
591 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
592 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
593 renamed to Sns_store_selection_internal.
594 (ns_handle_selection_request): Move code to Fx_own_selection_internal
595 and remove this function.
596 (ns_handle_selection_clear): Remove, never used.
597 (Fx_own_selection_internal): Move code from ns_handle_selection_request
600 2011-12-17 Ken Brown <kbrown@cornell.edu>
602 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
603 GID is unknown (Bug#10257).
605 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
607 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
608 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
609 which caused a build failure on GNU/Linux IA-64. This problem was
610 introduced by my 2011-10-07 patch.
612 2011-12-15 Juri Linkov <juri@jurta.org>
614 * image.c (imagemagick_error): New function. (Bug#10112)
615 (imagemagick_load_image): Comment out `MagickSetResolution' call.
616 Use `imagemagick_error' where ImageMagick functions return
618 (Fimagemagick_types): Add `Fnreverse' to return the list in the
621 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
623 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
624 fill background (Bug#8992).
626 2011-12-13 Martin Rudalics <rudalics@gmx.at>
628 * window.c (Vwindow_combination_resize)
629 (Vwindow_combination_limit): Use t instead of non-nil in
631 (Vrecenter_redisplay): Add first sentence of doc-string on
633 (Frecenter): Fix doc-string typo.
635 2011-12-11 Kenichi Handa <handa@m17n.org>
637 * coding.c (Funencodable_char_position): Pay attention to the
638 buffer text relocation (Bug#9389).
640 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
642 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
643 gtk_init (Bug#10100).
645 2011-12-10 Eli Zaretskii <eliz@gnu.org>
647 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
648 IT->string is nil. (Bug#10263)
650 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
652 * nsterm.h (x_free_frame_resources): Declare.
654 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
655 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
657 * nsterm.h (ns_get_defaults_value): Declare.
659 * nsterm.m (ns_default): Call ns_get_defaults_value.
661 2011-12-09 Eli Zaretskii <eliz@gnu.org>
663 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
666 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
668 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
669 that where the value of an _OBJC_* symbol points to is in the .bss
672 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
674 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
675 after the loop to call ccl_driver at least once (Bug#8619).
677 2011-12-08 Kenichi Handa <handa@m17n.org>
679 * ftfont.c (get_adstyle_property): Fix previous change
682 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
684 * w32.c (init_environment): If no_site_lisp, remove site-lisp
685 dirs from the default value of EMACSLOADPATH (bug#10208).
687 2011-12-07 Glenn Morris <rgm@gnu.org>
689 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
690 installation and source directories as well. (Bug#10208)
692 2011-12-06 Chong Yidong <cyd@gnu.org>
694 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
696 2011-12-06 Glenn Morris <rgm@gnu.org>
698 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
699 as an error, not just -1. (Bug#10217)
701 2011-12-05 Chong Yidong <cyd@gnu.org>
703 * keyboard.c (process_special_events): New function.
704 (swallow_events, Finput_pending_p): Use it (Bug#10195).
706 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
708 * coding.c (encode_designation_at_bol): Don't use uninitialized
709 local variable (Bug#9318).
711 2011-12-05 Kenichi Handa <handa@m17n.org>
713 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
714 return Qnil (Bug#8046, Bug#10193).
716 2011-12-05 Kenichi Handa <handa@m17n.org>
718 * coding.c (encode_designation_at_bol): New args charbuf_end and
719 dst. Return the number of produced bytes. Callers changed.
720 (coding_set_source): Return how many bytes coding->source was
722 (coding_set_destination): Return how many bytes
723 coding->destination was relocated.
724 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
725 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
727 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
729 * coding.c (CODING_CHAR_CHARSET_P): New macro.
730 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
733 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
735 The following changes are to fix Bug#9318.
737 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
738 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
739 (encode_coding_iso_2022, encode_coding_sjis)
740 (encode_coding_big5, encode_coding_charset): Use the above macros.
742 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
744 * lisp.h (process_quit_flag): Fix external declaration.
746 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
748 Don't macro-inline non-performance-critical code.
749 * eval.c (process_quit_flag): New function.
750 * lisp.h (QUIT): Use it.
752 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
754 * nsfns.m (get_geometry_from_preferences): New function.
755 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
757 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
759 * emacs.c (Qkill_emacs): Define.
760 (syms_of_emacs): Initialize it.
761 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
762 Qquit_flag to `kill-emacs' instead.
763 (quit_throw_to_read_char): Add parameter `from_signal'.
764 All callers changed. Call Fkill_emacs if requested and safe.
765 * lisp.h (QUIT): Call Fkill_emacs if requested.
767 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
769 * widget.c (update_wm_hints): Return if wmshell is null.
770 (widget_update_wm_size_hints): New function.
772 * widget.h (widget_update_wm_size_hints): Declare.
774 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
775 widget_update_wm_size_hints (Bug#10104).
777 2011-12-03 Eli Zaretskii <eliz@gnu.org>
779 * xdisp.c (handle_invisible_prop): If the invisible text ends just
780 before a newline, prepare the bidi iterator for consuming the
781 newline, and keep the current paragraph direction. (Bug#10183)
782 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
784 2011-12-02 Juri Linkov <juri@jurta.org>
786 * search.c (Fword_search_regexp): New Lisp function created from
787 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
788 (Fword_search_backward, Fword_search_forward)
789 (Fword_search_backward_lax, Fword_search_forward_lax):
790 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
791 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
793 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
795 * fileio.c (Finsert_file_contents): Move after-change-function call
796 to before the "handled:" label, since all "goto handled" appear in
797 cases where the *-change-functions have already been properly called
800 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
802 * keyboard.c (interrupt_signal): Don't call kill-emacs when
803 waiting for input. (Bug#10169)
805 2011-11-30 Eli Zaretskii <eliz@gnu.org>
807 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
808 verifies glyph row's hash code--we have just reallocated the
809 glyphs, so their contents can be complete garbage. (Bug#10164)
811 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
813 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
815 2011-11-30 Eli Zaretskii <eliz@gnu.org>
817 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
818 attributes are tested _before_ calling verify_row_hash, to protect
819 against GCC re-ordering of the tests. (Bug#10164)
821 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
823 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
825 * xterm.c (handle_one_xevent): Only set async_visible and friends
826 if net_wm_state_hidden_seen is non-zero (Bug#10002)
827 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
828 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
830 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
832 Remove GCPRO-related macros that exist only to avoid shadowing locals.
833 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
834 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
835 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
836 All uses changed to use GCPRO1 etc.
837 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
838 Revert to old implementation (i.e., before 2011-03-11).
840 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
842 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
843 of scroll runs so as to avoid assigning disabled bogus rows and
844 unnecessary graphics copy operations.
846 2011-11-27 Eli Zaretskii <eliz@gnu.org>
848 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
849 (snprintf) [_MSC_VER]: Redirect to _snprintf.
850 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
851 (malloc, free, realloc, calloc): Redirect to e_* only when
854 * lisp.h (GCTYPEBITS): Move before first use.
855 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
856 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
857 this macro definition.
859 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
862 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
864 * gtkutil.c (xg_create_frame_widgets):
865 Call gtk_window_set_has_resize_grip (FALSE) if that function is
866 present with Gtk+ 2.0.
868 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
870 * fileio.c (Finsert_file_contents): Undo previous change; see
871 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
873 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
875 Rename locals to avoid shadowing.
876 * fileio.c (Finsert_file_contents):
877 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
878 * process.c (wait_reading_process_output):
879 Rename inner 'proc' to 'p' to avoid shadowing.
880 Indent for consistency with usual Emacs style.
882 2011-11-25 Eli Zaretskii <eliz@gnu.org>
884 * xdisp.c (redisplay_window): If cursor row is not fully visible
885 after recentering, and scroll-conservatively is set to a large
886 number, scroll window by a few more lines to make the cursor fully
887 visible and out of scroll-margin. (Bug#10105)
888 (start_display): Don't move to the next line if the display should
889 start at a newline that is part of a display vector or an overlay
892 2011-11-24 Juri Linkov <juri@jurta.org>
894 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
895 after the `MagickPingImage' call. (Bug#10112)
897 2011-11-23 Chong Yidong <cyd@gnu.org>
899 * window.c (Fcoordinates_in_window_p): Accept only live windows.
901 2011-11-23 Martin Rudalics <rudalics@gmx.at>
903 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
904 making another buffer current. (Bug#10114)
906 2011-11-23 Glenn Morris <rgm@gnu.org>
908 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
910 2011-11-23 Chong Yidong <cyd@gnu.org>
912 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
915 2011-11-22 Eli Zaretskii <eliz@gnu.org>
917 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
918 and header-lines, as they don't have one computed for them.
921 * .gdbinit (prow): Make displayed values more self-explaining.
924 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
926 * process.c (wait_reading_process_output): Fix asynchrounous
927 GnuTLS socket handling on some versions of the GnuTLS library.
928 (wait_reading_process_output): Add comment and URL.
930 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
932 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
934 2011-11-21 Chong Yidong <cyd@gnu.org>
936 * window.c (Fnext_window, Fprevious_window): Doc fix.
938 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
940 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
942 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
944 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
946 2011-11-20 Martin Rudalics <rudalics@gmx.at>
948 * window.c (Fset_window_combination_limit): Rename argument
950 (Vwindow_combination_limit): Remove "status" from doc-string.
952 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
954 * m/ibms390.h: Remove.
955 * m/ibms390x.h: Don't include "ibms390.h".
957 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
959 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
960 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
962 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
964 * casetab.c (Fset_case_table):
965 * charset.c (Fcharset_after): Fix typos.
967 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
969 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
970 Otherwise, valgrind does not work on some platforms.
971 Problem reported by Andreas Schwab in
972 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
973 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
974 is set, removing the need for VIRT_ADDRESS_VARIES.
975 (PURE_P): Use a more-efficient implementation that needs just one
976 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
977 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
978 to 4 (xorl, subq, cmpq, setbe).
979 * alloc.c (pure): Always extern now, since that's the
980 VIRT_ADDR_VARIES behavior.
981 (PURE_POINTER_P): Use a single comparison, not two, for
982 consistency with the new puresize.h.
983 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
984 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
985 Remove VIRT_ADDR_VARIES no longer needed.
987 2011-11-19 Eli Zaretskii <eliz@gnu.org>
989 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
990 (erase_phys_cursor, update_window_cursor, show_mouse_face)
991 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
992 behave as if the cursor position were at the window margin.
994 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
995 and the cursor position is out of bounds, behave as if the cursor
996 position were at the window margin. (Bug#10075)
998 2011-11-18 Chong Yidong <cyd@gnu.org>
1000 * window.c (Fwindow_combination_limit): Make first argument
1001 non-optional, since it is meaningless for live windows like the
1004 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1006 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1008 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1010 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1011 (graft_intervals_into_buffer): Simplify.
1013 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1015 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1016 hash values of the two rows.
1017 (copy_row_except_pointers): Preserve the used[] arrays and the
1018 hash values of the two rows. (Bug#10035)
1019 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1021 * xdisp.c (row_hash): New function, body extracted from
1022 compute_line_metrics.
1023 (compute_line_metrics): Call row_hash, instead of computing the
1026 * dispnew.c (verify_row_hash): Call row_hash for computing the
1027 hash code of a row, instead of duplicating code from xdisp.c.
1029 * dispextern.h (row_hash): Add prototype.
1031 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1033 * frame.c (delete_frame): Don't delete the terminal when the last
1034 X frame is closed if emacs is built with GTK toolkit.
1036 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1038 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1040 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1042 * window.c (Vwindow_splits): Rename to
1043 Vwindow_combination_resize. Suggested by Juri Linkov.
1044 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1047 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1049 * nsfns.m (Fns_font_name):
1050 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1052 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1054 * window.h (window): Rename slot "nest" to "combination_limit".
1055 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1056 (Fset_window_nest): Rename to Fset_window_combination_limit.
1057 (Vwindow_nest): Rename to Vwindow_combination_limit.
1058 (recombine_windows, make_parent_window, make_window)
1059 (Fsplit_window_internal, saved_window)
1060 (Fset_window_configuration, save_window_save): Rename all
1061 occurrences of window_nest to window_combination_limit.
1063 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1065 * image.c (imagemagick_load_image): Fix typo.
1067 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1069 * xdisp.c (display_line): Move the call to
1070 highlight_trailing_whitespace before the call to
1071 compute_line_metrics, since the latter needs to see the final
1072 faces of all the glyphs to compute ROW's hash value.
1073 Fixes assertion violations in row_equal_p. (Bug#10035)
1075 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1077 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1078 just return (bug#10044).
1080 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1082 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1083 with user-defined heap size. Bump the default size of the temacs
1084 heap to 27MB, to avoid memory warning when running temacs.
1085 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1087 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1088 current_matrix and desired_matrix. (Bug#9990)
1089 (verify_row_hash) [XASSERTS]: New function.
1090 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1091 that the hash value of glyph rows is correct.
1093 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1095 * window.h (window): Remove splits slot.
1096 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1097 (Fdelete_other_windows_internal, make_parent_window)
1098 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1099 (Fset_window_configuration, save_window_save): Don't deal with
1100 split status of windows.
1101 (saved_window): Remove splits slot.
1102 (Vwindow_splits): Rewrite doc-string.
1104 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1106 * xfns.c (unwind_create_frame):
1107 * nsfns.m (unwind_create_frame):
1108 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1109 Vframe_list (Bug#9999).
1111 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1113 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1115 2011-11-11 Kenichi Handa <handa@m17n.org>
1117 * callproc.c (Fcall_process): Set the member dst_multibyte of
1120 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1122 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1123 avoid a crash (bug#9496).
1125 2011-11-09 Chong Yidong <cyd@gnu.org>
1127 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1128 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1130 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1132 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1134 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1136 Avoid some portability problems by eschewing 'extern inline' functions.
1137 The trivial performance wins aren't worth the portability hassles; see
1138 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1140 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1141 (window_box_width, window_box_left, window_box_left_offset)
1142 (window_box_right, window_box_right_offset): Undo previous change,
1143 by removing the "extern"s.
1144 * intervals.c (adjust_intervals_for_insertion)
1145 (adjust_intervals_for_deletion): Undo previous change,
1146 making these static again.
1147 (offset_intervals, temp_set_point_both, temp_set_point)
1148 (copy_intervals_to_string): No longer inline.
1149 * xdisp.c (window_text_bottom_y, window_box_width)
1150 (window_box_height, window_box_left_offset)
1151 (window_box_right_offset, window_box_left, window_box_right)
1152 (window_box): No longer inline.
1154 2011-11-08 Chong Yidong <cyd@gnu.org>
1156 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1157 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1158 Signal an error if not a live window.
1159 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1160 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1162 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1164 * lisp.h (syms_of_abbrev): Remove declaration.
1165 Reported by CHENG Gao <chenggao@royau.me>.
1167 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1169 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1170 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1171 of temacs in GUI mode.
1173 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1175 * window.h: Declare delete_all_child_windows instead of
1176 delete_all_subwindows.
1177 * window.c (Fwindow_nest, Fset_window_nest)
1178 (Fset_window_new_total, Fset_window_new_normal)
1179 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1180 (delete_all_subwindows): Rename to delete_all_child_windows.
1181 (Fdelete_other_windows_internal, Fset_window_configuration):
1182 Call delete_all_child_windows instead of delete_all_subwindows.
1183 * frame.c (delete_frame): Call delete_all_child_windows instead
1184 of delete_all_subwindows.
1186 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1188 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1189 This is also needed for porting to any host where GC_MARK_STACK is
1190 not GC_MAKE_GCPROS_NOOPS.
1191 (which_symbols): Use it.
1193 2011-11-07 Kenichi Handa <handa@m17n.org>
1195 * coding.c (coding_set_destination): Check coding->src_pos only
1196 when coding->src_object is a buffer (bug#9910).
1198 * process.c (send_process): Set the member src_multibyte of coding
1199 to 0 (bug#9911) when sending a unibyte text.
1201 * callproc.c (Fcall_process): Set the member src_multibyte of
1202 process_coding to 0 (bug#9912).
1204 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1206 * xmenu.c (cleanup_widget_value_tree): New function.
1207 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1208 calling free_menubar_widget_value_tree directly (Bug#9830).
1210 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1212 Fix some portability problems with 'inline'.
1213 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1214 (window_box_width, window_box_left, window_box_left_offset)
1215 (window_box_right, window_box_right_offset): Declare extern.
1216 Otherwise, these inline functions do not conform to C99 and
1217 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1218 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1219 * intervals.c (adjust_intervals_for_insertion)
1220 (adjust_intervals_for_deletion): Now extern, because otherwise the
1221 extern inline functions 'offset_intervals' couldn't refer to it.
1222 (static_offset_intervals): Remove.
1223 (offset_intervals): Rewrite using the old contents of
1224 static_offset_intervals. The old version didn't conform to C99
1225 because an extern inline function contained a reference to an
1226 identifier with static linkage.
1228 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1230 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1233 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1235 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1236 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1237 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1238 return Qleft_to_right.
1240 2011-11-06 Chong Yidong <cyd@gnu.org>
1242 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1243 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1244 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1245 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1246 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1247 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1248 (Fwindow_vscroll): Doc fix.
1249 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1250 argument, since it makes no sense to pass a live window and for
1251 consistency with window-child.
1253 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1255 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1258 2011-11-05 Jason Rumney <jasonr@gnu.org>
1260 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1261 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1263 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1264 bitwise arithmetic preventing use of unicode-sip and non-truetype
1267 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1269 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1272 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1273 initialization code to keep similarity to xfns.c after changes
1276 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1278 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1279 (unwind_create_frame): New function (Bug#9943).
1280 (Fx_create_frame): Restructure code to be more similar to the one in
1281 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1282 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1283 Move terminal->reference_count++ just before making the frame official
1286 * nsterm.m (x_free_frame_resources): New function.
1287 (x_destroy_window): Move code to x_free_frame_resources.
1289 * xfns.c (unwind_create_frame): Fix comment.
1290 (Fx_create_frame, x_create_tip_frame):
1291 Move terminal->reference_count++ just before making the frame
1292 official. Move initialization of image_cache_refcount and
1293 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1295 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1297 Support MSVC build with newer versions of Visual Studio.
1298 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1299 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1302 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1303 which are not supported by MSVC.
1304 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1305 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1307 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1309 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1311 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1313 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1315 Support MSVC build with newer versions of Visual Studio.
1316 * w32.c: Don't include w32api.h for MSVC.
1317 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1319 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1320 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1321 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1322 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1324 (alloca) [_MSC_VER]: Define to _alloca.
1326 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1328 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1330 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1332 * xdisp.c (note_mouse_highlight): If either of
1333 previous/next-single-property-change returns nil, treat that as
1334 the beginning or the end of the buffer. (Bug#9955)
1336 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1338 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1339 label is not null (Bug#9951).
1340 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1343 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1345 * window.c (Fwindow_body_size): Mention in the doc string that the
1346 return value is in frame's canonical units. (Bug#9949)
1348 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1350 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1352 * w32fns.c (unwind_create_frame): If needed, free the glyph
1353 matrices of the partially constructed frame. (Bug#9943)
1354 * xfns.c (unwind_create_frame): Likewise.
1356 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1358 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1359 Don't stop backward scan on the continuation glyph, even though
1360 its CHARPOS is positive.
1361 (mouse_face_from_buffer_pos, note_mouse_highlight):
1362 Rename cover_string to disp_string.
1364 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1366 * window.c (temp_output_buffer_show): Don't use
1367 Vtemp_buffer_show_specifiers.
1368 (Vtemp_buffer_show_specifiers): Remove unused variable.
1370 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1372 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1373 past the beginning of the current glyph matrix.
1375 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1377 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1378 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1379 HAVE_GTK3 (Bug#9869).
1381 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1382 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1384 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1386 * xterm.c: Declare x_handle_net_wm_state to return int.
1387 (handle_one_xevent): Check if we are iconified but don't have
1388 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1389 (get_current_wm_state): Return non-zero if not hidden,
1390 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1391 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1392 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1393 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1395 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1397 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1398 so that this new function doesn't get optimized away by a
1399 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1401 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1403 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1405 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1407 Fix the `xbytecode' command.
1408 * .gdbinit (xprintbytestr): New command.
1409 (xwhichsymbols): Rename from `which'; all callers changed.
1410 (xbytecode): Print the byte-code string as well.
1412 2011-10-29 Kim Storm <storm@cua.dk>
1414 * alloc.c (which_symbols): New function.
1416 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1418 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1421 2011-10-29 Glenn Morris <rgm@gnu.org>
1423 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1424 Not clear what it was for, and it causes various bugs. (Bug#9839)
1426 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1428 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1429 possible random value that matches one of those tested as
1430 condition to clear the mouse face.
1432 2011-10-28 Chong Yidong <cyd@gnu.org>
1434 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1436 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1438 * window.c (make_window): Initialize phys_cursor_on_p.
1440 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1442 * lisp.h (struct Lisp_Symbol): Update comments.
1444 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1446 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1448 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1450 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1451 <oslsachem@gmail.com> for helping to debug this.
1453 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1454 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1455 (g_b_init_get_glyph_outline_w): New static variables.
1456 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1457 (GetGlyphOutlineW_Proc): New typedefs.
1458 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1459 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1461 (w32font_open_internal, compute_metrics):
1462 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1463 instead of calling the "wide" APIs directly.
1465 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1467 * w32.h (syms_of_w32font): Add prototype.
1469 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1471 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1472 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1473 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1474 (Fmove_to_window_line): Doc fix.
1476 2011-10-27 Chong Yidong <cyd@gnu.org>
1478 * process.c (make_process): Set gnutls_state to NULL.
1480 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1481 non-NULL, regardless of GNUTLS_INITSTAGE.
1482 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1483 an error. Set process slots as soon as we allocate them.
1485 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1487 2011-10-27 Chong Yidong <cyd@gnu.org>
1489 * gnutls.c (emacs_gnutls_deinit): New function.
1490 Deallocate credentials structures as well as calling gnutls_deinit.
1491 (Fgnutls_deinit, Fgnutls_boot): Use it.
1493 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1494 (deactivate_process): Call emacs_gnutls_deinit.
1496 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1498 * image.c (x_create_x_image_and_pixmap):
1499 * w32.c (sys_rename, w32_delayed_load):
1500 * w32font.c (fill_in_logfont):
1501 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1503 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1505 * w32fns.c (w32_default_color_map): New function,
1506 extracted from Fw32_default_color_map.
1507 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1509 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1511 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1513 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1515 * keyboard.c (test_undefined): New function (bug#9751).
1516 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1518 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1520 * sysdep.c (init_sys_modes): Fix the check for the controlling
1521 terminal (Bug#6649).
1523 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1525 * dispextern.h (struct bidi_it): New member next_en_type.
1527 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1528 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1529 current character, check also for next_en_type being WEAK_EN.
1530 (bidi_resolve_weak): Don't enter the expensive loop if the current
1531 position is before next_en_pos. Record the bidi type of the first
1532 non-ET, non-BN character we find, in addition to its position.
1533 (bidi_level_of_next_char): Invalidate next_en_type when
1534 next_en_pos is over-stepped.
1536 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1538 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1539 * editfns.c: Rewrite current-time-zone so that it invokes
1540 the equivalent of (format-time-string "%Z") to get the time zone name.
1541 This fixes a bug when the time zone name contains characters that
1542 need converting from the system time locale to Emacs internal format.
1543 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1544 that patch fixed format-time-string to do the conversion, but
1545 I forgot to fix current-time-zone.
1546 (format_time_string): New function, containing most of
1547 what Fformat_time_string used to contain.
1548 (Fformat_time_string): Rewrite in terms of format_time_string.
1549 This doesn't change this function's behavior.
1550 (current-time-zone): Rewrite to use format_time_string.
1551 This fixes the bug reported by Michael Schierl in
1552 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1553 Jason Rumney's 2007-06-07 change worked around this bug, but
1555 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1557 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1559 * xdisp.c (start_display): If the character at POS is displayed
1560 via a display vector, reset IT->current.dpvec_index to zero.
1561 (try_window_reusing_current_matrix): If a line ends in a display
1562 vector or the next line starts in a display vector, continue
1563 redrawing the window even though the character position of
1564 start_row was reached.
1567 2011-10-18 Chong Yidong <cyd@gnu.org>
1569 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1570 with nobreak-char-display too.
1572 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1574 Fix part 3 of bug#9771.
1575 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1576 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1577 non-neutral characters if the current character is a paragraph
1578 separator (a.k.a. Newline). This avoids running the same
1579 expensive loop twice, once when we consume the preceding newline
1580 and the other time when the line actually needs to be displayed.
1581 Avoid the loop when we see neutrals on the base embedding level
1582 following a character whose directionality is the same as the
1583 paragraph's. This avoids running the expensive loop when a line
1584 ends in a long sequence of neutrals, like control characters.
1585 Add assertion against STRONG_AL type. Slightly rearrange code
1586 that determines the type of a neutral given the first non-neutral
1588 (bidi_level_of_next_char): Set next_en_pos to zero when
1589 invalidating its info.
1591 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1593 * xdisp.c (push_display_prop): Determine whether to record string
1594 or buffer position by IT->string, not by IT->method. Allow
1595 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1596 (move_it_vertically_backward): Don't look for character position
1597 immediately after the newline when in a continuation line.
1600 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1602 * window.c (coordinates_in_window): Rewrite and delabelize
1603 vertical border check. (Bug#5357) (Bug#9618)
1605 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1607 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1608 errors in XSetWindowBorder (bug#9310).
1610 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1612 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1613 avoid crash when xmalloc overrun checking is enabled.
1615 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1617 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1618 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1619 cursor motion with <left> and <right> arrow keys.
1621 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1622 some callers set that themselves.
1624 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1626 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1627 display string and the previous row comes from the same string and
1628 is empty. (Bug#9739) (Bug#9738)
1630 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1632 * doc.c (get_doc_string): Encode file name (bug#9735).
1634 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1636 * bidi.c (bidi_level_of_next_char):
1637 * xdisp.c (get_visually_first_element): Remove old incorrect
1638 comments regarding the Unicode Line Separator character.
1640 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1642 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1644 * alloc.c (Fgc_status): Do not access beyond zombies array
1645 boundary if nzombies > MAX_ZOMBIES.
1646 * alloc.c (dump_zombies): Add missing format specifier.
1648 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1650 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1651 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1653 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1654 Some packages use them to denote characters with modifiers.
1656 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1658 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1659 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1660 matching a pp-number. Rename parameter var to var1.
1662 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1664 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1666 2011-10-08 Glenn Morris <rgm@gnu.org>
1668 * callint.c (Fcall_interactively): Give a more explicit error for the
1669 'c' case with a non-character input. (Bug#8479)
1671 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1673 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1675 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1676 lines that are hscrolled on the left.
1678 * dispnew.c (buffer_posn_from_coords): Account for a possible
1679 presence of header-line. (Bug#4426)
1681 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1683 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1684 Don't advertise functionality which we discourage or doesn't work.
1686 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1688 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1689 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1690 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1691 this makes Emacs dump core during garbage collection on rare
1692 occasions. sizeof is obviously inferior to offsetof here, so
1693 stick with offsetof.
1694 (GC_POINTER_ALIGNMENT): New macro.
1695 (mark_memory): Omit 3rd (offset) arg; caller changed.
1696 Don't assume EMACS_INT alignment is the same as pointer alignment.
1698 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1700 * keyboard.c (read_key_sequence_remapped): New var.
1701 (read_key_sequence): Compute remapping in the right buffer.
1702 (command_loop_1): Use read_key_sequence's remapping directly.
1704 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1706 * dired.c (file_name_completion): Don't expand file name.
1707 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1708 before checking file name handler.
1710 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1711 they've been requested explicitly (bug#9591).
1713 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1715 * keymap.c (Fsingle_key_description): Use make_specified_string
1716 instead of build_string to build string from push_key_description.
1719 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1721 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1722 This fixes a Y2038 bug on 64-bit hosts.
1723 * buffer.c (reset_buffer):
1724 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1725 (Fclear_buffer_auto_save_failure):
1726 Use 0, not -1, to represent an unset failure time, since time_t
1727 might not be signed.
1729 Remove dependency on glibc malloc internals.
1730 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1731 Move back here from lisp.h, but with their new implementations.
1732 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1733 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1734 * charset.c (charset_table_init): New static var.
1735 (syms_of_charset): Use it instead of xmalloc. This removes a
1736 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1737 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1738 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1739 Move back to alloc.c.
1740 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1741 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1743 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1745 * nsterm.m (windowDidResize): Call x_set_window_size only when
1746 ns_in_resize is true. Otherwise set pixelwidth/height and
1747 call change_frame_size (Bug#9628).
1749 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1751 Port --enable-checking=all to Fedora 14 x86-64.
1752 * charset.c (syms_of_charset): Also account for glibc malloc's
1753 internal overhead when calculating the initial malloc maximum.
1755 Port --enable-checking=all to Fedora 14 x86.
1756 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1758 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1759 (overrun_check_realloc, overrun_check_free):
1760 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1761 That way, xmalloc returns a properly-aligned pointer even if
1762 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1763 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1764 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1765 into account when calculating the initial malloc maximum.
1766 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1767 Move here from alloc.c, so that charset.c can use it too.
1768 Properly align; the old code wasn't right for common 32-bit hosts
1769 when configured with --enable-checking=all.
1770 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1771 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1773 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1775 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1778 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1780 * xdisp.c (compute_display_string_end): If there's no display
1781 string at CHARPOS, return -1.
1783 * bidi.c (bidi_fetch_char): When compute_display_string_end
1784 returns a negative value, treat the character as a normal
1785 character not covered by a display string. (Bug#9624)
1787 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1789 * lread.c (Fread_from_string): Fix typo in docstring.
1791 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1793 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1794 newline, reseat the iterator instead of bidi-iterating there one
1795 character at a time. (Bug#9610)
1796 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1797 TO_CHARPOS if the bidi iterator is at base embedding level.
1799 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1801 * lread.c (readevalloop): Use correct code for NBSP.
1802 (read1): Likewise. (Bug#9608)
1804 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1806 * dbusbind.c (Fdbus_register_signal): When service is not
1807 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1809 2011-09-25 Glenn Morris <rgm@gnu.org>
1811 * buffer.c (truncate-lines): Doc fix.
1813 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1815 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1816 (Fset_window_next_buffers): Doc fix.
1818 2011-09-24 Glenn Morris <rgm@gnu.org>
1820 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1822 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1824 Fix minor problems found by static checking.
1825 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1826 * indent.c (Fvertical_motion): Fix == vs = typo.
1828 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1830 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1831 Default value is now t. Doc fix.
1833 * indent.c (Fvertical_motion): Compute and apply the overshoot
1834 logic when moving up, not only when moving down. Fix the
1835 confusing name and values of the it_overshoot_expected variable;
1836 logic changes accordingly. (Bug#9254) (Bug#9549)
1838 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1839 CHARPOS is covered by a display string which includes newlines.
1840 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1841 is covered by a display string with embedded newlines.
1843 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1845 * dbusbind.c (Fdbus_register_signal): Add match rule to
1846 Vdbus_registered_objects_table. (Bug#9581)
1847 (Fdbus_register_method, Vdbus_registered_objects_table):
1850 2011-09-24 Jim Meyering <meyering@redhat.com>
1852 do not ignore write error for any output size
1853 The previous change was incomplete.
1854 While it makes emacs --batch detect the vast majority of stdout
1855 write failures, errors were still ignored whenever the output size is
1856 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1857 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1858 && echo FAIL: ignored write error
1859 FAIL: ignored write error
1860 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1861 && echo FAIL: ignored write error
1862 FAIL: ignored write error
1863 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1865 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1867 * emacs.c (Fkill_emacs): In noninteractive mode exit
1868 non-successfully if a write error occurred on stdout. (Bug#9574)
1870 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1872 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1875 * dispextern.h (struct it): Update the comment documenting what
1878 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1880 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1881 a display string, extend search for cursor position to end of row.
1882 (find_row_edges): If the row ends in a newline from a display
1883 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1884 Handle the case of a display string with multiple newlines.
1885 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1886 non-empty line. Fixes confusing cursor motion with arrow keys at
1887 the beginning of a line that starts with whitespace.
1889 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1891 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1894 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1896 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1899 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1901 * xdisp.c (display_line): Record maximum and minimum buffer
1902 positions even if no glyphs were produced (e.g., by a zero-width
1903 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1904 buffer positions that will be removed from the glyph row because
1906 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1907 column is beyond frame width: don't subtract 1 "pixel" when
1908 computing width of the stretch.
1909 (reseat_at_next_visible_line_start): Undo the change made on
1910 2011-09-17 that saved paragraph information and restored it after
1911 the call to `reseat'. (Bug#9545)
1913 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1915 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1916 and turn window cursor on if cleared (Bug#9415).
1918 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1920 * search.c (boyer_moore): Take unibyte characters from pattern
1921 literally. (Bug#9458)
1923 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1925 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1927 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1929 Fix minor problem found by static checking.
1930 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1931 initialized, to pacify gcc -Wuninitialized.
1933 * fileio.c: Report proper errno when syscall falls.
1934 (Finsert_file_contents): Save and restore errno,
1935 so that report_file_error outputs the correct diagnostic.
1936 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1938 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1940 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1942 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1944 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1945 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1947 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1949 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1950 about the current paragraph and restore it after the call to reseat.
1952 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1953 (bidi_find_paragraph_start): Search back for paragraph beginning
1954 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1955 (bidi_move_to_visually_next): Only trigger paragraph-related
1956 computations when the last character is a newline or at EOB, not
1957 just any NEUTRAL_B. (Bug#9470)
1959 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1960 truncated lines if point is covered by a display string. (Bug#9524)
1962 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1964 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1965 (cons_to_x_long): New function.
1966 (lisp_data_to_selection_data): Use it. Correct the test for
1967 short-versus-long data; it was negated. Break out of vector
1968 loop, for efficiency, when a long datum is discovered.
1970 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1972 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1974 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1976 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1977 GCC PR/17406) by declaring this function with external scope.
1979 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1981 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1982 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1984 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1986 * editfns.c (Fformat): Correctly handle text properties on "%%".
1988 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1990 * xterm.c (x_draw_composite_glyph_string_foreground):
1991 * w32term.c (x_draw_composite_glyph_string_foreground):
1992 * term.c (encode_terminal_code):
1993 * composite.c (composition_update_it, get_composition_id):
1994 * xdisp.c (get_next_display_element)
1995 (fill_composite_glyph_string): Add comments about special meaning
1996 of TAB characters in a composition.
1998 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2000 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2001 This occurs when processing a multibyte format.
2002 Problem reported by Wolfgang Jenker.
2004 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2006 * xdisp.c (try_cursor_movement): Only check for exact match if
2007 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2009 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2011 Remove unused external symbols.
2012 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2013 * xdisp.c (calc_pixel_width_or_height): Now static.
2014 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2015 * indent.c (check_display_width):
2016 * w32term.c: Fix comment to match code.
2017 * xterm.c, xterm.h (x_catching_errors): Remove.
2019 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2021 * xselect.c: Use signed conversions more consistently (Bug#9498).
2022 (selection_data_to_lisp_data): Assume incoming selection data are
2023 signed integers, not unsigned. This is to be consistent with
2024 outgoing selection data, which was modified to use signed integers
2025 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2026 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2027 expects long, not unsigned long.
2029 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2031 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2032 computation of loop end. Reported by Johan Bockgård
2035 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2037 * frame.c (Fother_visible_frames_p): Function deleted.
2039 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2041 * indent.c (compute_motion): Process display vector front to back
2042 rather than the other way around. (Bug#2496)
2044 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2046 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2048 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2050 * minibuf.c (Fread_from_minibuffer): Doc fix.
2052 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2054 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2055 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2057 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2059 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2060 value for non-existent files.
2062 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2064 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2065 set its "size" to -1. This will set the modtime_size field of
2066 the corresponding buffer to -1, which is what
2067 verify-visited-file-modtime expects for files that do not exist.
2070 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2072 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2074 * lisp.h: ... from here. push_key_description is no longer
2075 defined in keyboard.c, so its declaration should not be in
2076 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2077 logically belongs with push_key_description.
2079 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2081 * buffer.h: Include <sys/types.h> instead of <time.h>.
2082 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2083 Problem reported by Herbert J. Skuhra.
2085 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2087 * xml.c (parse_region): Make the parsing work for
2088 non-comment-starting XML files again (bug#9144).
2090 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2092 * image.c (gif_load): Fix calculation of bottom and right corner.
2095 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2097 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2098 redisplay in small windows.
2100 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2102 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2104 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2106 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2107 Operate on live windows only.
2109 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2111 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2113 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2115 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2116 only under bidi iteration.
2118 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2120 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2122 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2124 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2125 Without this fix, the command to link temacs failed due to an
2126 undefined symbol __builtin_isnan. This is because
2127 /usr/include/iso/math_c99.h #defines isnan(x) to
2128 __builtin_isnan(x), but the bundled gcc, which identifies itself
2129 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2131 * floatfns.c (isnan): #undef, and then #define to a clone of
2133 (Fisnan): Always define, since it's always available now.
2134 (syms_of_floatfns): Always define isnan at the Lisp level.
2136 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2138 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2140 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2142 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2143 The previous code assumed that file offsets (off_t values) fit in
2144 EMACS_INT variables, which is not true on typical 32-bit hosts.
2145 The code messed up by falsely reporting buffer overflow in cases
2146 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2147 when "big" contains more than 2**29 bytes, even though this
2148 inserts just one byte and does not overflow the buffer.
2149 (Finsert_file_contents): Store file offsets as off_t
2150 values, not as EMACS_INT values. Check for overflow when
2151 converting between EMACS_INT and off_t. When checking for
2152 buffer overflow or for overlap, take the offsets into account.
2153 Don't use EMACS_INT for small values where int suffices.
2154 When checking for overlap, fix a typo: ZV was used where
2155 ZV_BYTE was intended.
2156 (Fwrite_region): Don't assume off_t fits into 'long'.
2157 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2159 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2161 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2163 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2165 sprintf-related integer and memory overflow issues (Bug#9412).
2167 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2168 (esprintf, exprintf, evxprintf): New functions.
2169 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2170 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2171 (modify_event_symbol): Do not assume that the length of
2172 name_alist_or_stem is safe to alloca and fits in int.
2173 (Fexecute_extended_command): Likewise for function name and binding.
2174 (Frecursion_depth): Wrap around reliably on integer overflow.
2175 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2176 since some callers pass EMACS_INT values.
2177 (Fsingle_key_description): Don't crash if symbol name contains more
2178 than MAX_ALLOCA bytes.
2179 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2180 (get_minibuffer): Arg is now EMACS_INT, not int.
2181 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2182 (esprintf, exprintf, evxprintf): New decls.
2183 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2185 * dbusbind.c (signature_cat): New function.
2186 (xd_signature, Fdbus_register_signal):
2187 Do not overrun buffer; instead, report string overflow.
2189 * dispnew.c (add_window_display_history): Don't overrun buffer.
2190 Truncate instead; this is OK since it's just a log.
2192 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2193 even if the time zone offset is outlandishly large.
2194 Don't mishandle offset == INT_MIN.
2196 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2197 when creating daemon; the previous buffer-overflow check was incorrect.
2199 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2200 which has the guts of the old verror function.
2202 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2203 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2205 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2206 (font_unparse_xlfd): Don't blindly alloca long strings.
2207 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2208 fits in int, when using sprintf. Use single snprintf to count
2209 length of string rather than counting it via multiple sprintfs;
2210 that's simpler and more reliable.
2211 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2212 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2213 sprintf, in case result does not fit in int.
2215 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2216 (fontset_from_font): Print it.
2218 * frame.c (tty_frame_count): Now printmax_t, not int.
2219 (make_terminal_frame, set_term_frame_name): Print it.
2220 (x_report_frame_params): In X, window IDs are unsigned long,
2221 not signed long, so print them as unsigned.
2222 (validate_x_resource_name): Check for implausibly long names,
2223 and don't assume name length fits in 'int'.
2224 (x_get_resource_string): Don't blindly alloca invocation name;
2225 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2228 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2229 (xg_check_special_colors, xg_set_geometry):
2230 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2232 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2233 Use esprintf, not sprintf, in case result does not fit in int.
2235 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2236 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2237 it as a large positive number.
2238 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2239 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2241 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2242 in case result does not fit in int.
2244 * print.c (float_to_string): Detect width overflow more reliably.
2245 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2246 buffer overrun. Don't assume list length fits in 'int'. Treat
2247 print length of 0 as 0, not as infinity; to be consistent with other
2248 uses of print length in this function. Don't overflow print length
2249 index. Don't assume hash table size fits in 'long', or that
2250 vectorlike size fits in 'unsigned long'.
2252 * process.c (make_process): Use printmax_t, not int, to format
2253 process-name gensyms.
2255 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2257 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2258 to avoid potential buffer overrun.
2260 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2261 if X resource line is longer than 512 bytes.
2263 * xfns.c (x_window): Make sprintf buffer a bit bigger
2264 to avoid potential buffer overrun.
2266 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2268 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2270 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2272 Integer overflow fixes for scrolling, etc.
2273 Without these, Emacs silently mishandles large integers sometimes.
2274 For example, "C-u 4294967297 M-x recenter" was treated as if
2275 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2277 * xdisp.c (try_window_id): Check Emacs fixnum range before
2278 converting to 'int'.
2280 * window.c (window_scroll_line_based, Frecenter):
2281 Check that an Emacs fixnum is in range before assigning it to 'int'.
2282 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2283 values converted from Emacs fixnums.
2284 (Frecenter): Don't wrap around a line count if it is out of 'int'
2285 range; instead, treat it as an extreme value.
2286 (Fset_window_configuration, compare_window_configurations):
2287 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2289 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2290 that can exceed INT_MAX. Check that EMACS_INT value is in range
2291 before assigning it to the (possibly-narrower) index.
2292 (match_limit): Don't assume that a fixnum can fit in 'int'.
2294 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2297 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2298 (Fvertical_motion): Don't wrap around LINES values that don't fit
2299 in 'int'. Instead, treat them as extreme values. This is good
2300 enough for windows, which can't have more than INT_MAX lines anyway.
2302 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2304 * Require libxml/parser.h to avoid compilation warning.
2306 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2308 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2309 since this reportedly can destroy thread storage.
2311 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2313 * syntax.c (find_defun_start): Update all cache variables if
2314 exiting early (Bug#9401).
2316 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2318 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2320 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2321 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2322 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2324 * term.c (tty_append_glyph): New function.
2325 (produce_stretch_glyph): Static function and its prototype deleted.
2327 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2330 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2332 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2333 when checking :margin (Bug#9390).
2334 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2335 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2336 so that the name doesn't mislead. All uses changed.
2338 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2340 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2343 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2345 * xdisp.c (move_it_to): Don't bail out early when reaching
2346 position beyond to_charpos, if we are scanning backwards.
2347 (move_it_vertically_backward): When DY == 0, make sure we get to
2348 the first character in the line after the newline.
2350 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2352 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2353 (ccl_driver): Do not generate an out-of-range pointer.
2354 (Fccl_execute_on_string): Remove unnecessary check for
2355 integer overflow, noted by Stefan Monnier in
2356 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2357 Remove a FIXME that didn't need fixing.
2358 Simplify the newly-introduced buffer reallocation code.
2360 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2362 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2364 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2366 Integer and memory overflow issues (Bug#9196).
2368 * doc.c (get_doc_string): Rework so that
2369 get_doc_string_buffer_size is the actual buffer size, rather than
2370 being 1 less than the actual buffer size; this makes xpalloc more
2373 * image.c (x_allocate_bitmap_record, cache_image):
2374 * xselect.c (Fx_register_dnd_atom):
2375 Simplify previous changes by using xpalloc.
2377 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2378 since either will do and ptrdiff_t is convenient with xpalloc.
2380 * charset.c (charset_table_size)
2381 (struct charset_sort_data.priority): Now ptrdiff_t.
2382 (charset_compare): Don't overflow if priorities differ greatly.
2383 (Fsort_charsets): Don't assume list length fits in int.
2384 Check for size-calculation overflow when allocating sort data.
2385 (syms_of_charset): Allocate an initial charset table that is
2386 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2388 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2390 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2391 The actual value is always <= INT_MAX, and leaving it unsigned made
2392 overflow checking harder.
2394 * dispextern.h (struct glyph_matrix.rows_allocated)
2395 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2396 with xpalloc. The values are still always <= INT_MAX.
2398 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2400 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2401 (SAFE_NALLOCA): New macro.
2403 * region-cache.c (struct boundary.pos, find_cache_boundary)
2404 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2405 (set_cache_region, invalidate_region_cache)
2406 (revalidate_region_cache, know_region_cache, region_cache_forward)
2407 (region_cache_backward, pp_cache):
2408 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2409 so that ptrdiff_t * can be passed to xpalloc.
2410 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2411 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2412 (pp_cache): Don't assume cache_len fits in int.
2413 * region-cache.h: Adjust extern decls to match.
2415 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2416 EMACS_INT, since either will do, for xpalloc.
2418 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2419 (xnmalloc, xnrealloc, xpalloc): New functions.
2421 * bidi.c (bidi_shelve_header_size): New constant.
2422 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2423 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2425 * bidi.c (bidi_cache_shrink):
2426 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2428 Don't update size of array until after memory allocation succeeds,
2429 because xmalloc/xrealloc may not return.
2430 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2431 now that we have proper integer overflow checking.
2432 (record_overlay_string, overlay_strings): Catch overflows when
2433 calculating size of overlay_str_buf.
2435 * callproc.c (Fcall_process): Check for size overflow when
2436 calculating size of args2.
2437 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2438 Normally we prefer signed values, but sticking with ptrdiff_t would
2439 require adding more-complicated checks.
2441 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2442 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2443 Redo buffer-overflow calculations to avoid integer overflow.
2444 Add a FIXME comment where memory seems to be over-allocated.
2446 * character.c (Fstring): Check for size-calculation overflow.
2448 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2449 unnecessary integer overflow. Check for size overflow.
2450 (encode_coding_object): Don't update size until xmalloc succeeds.
2452 * composite.c (get_composition_id): Check for overflow in glyph
2453 length calculations.
2455 Integer and memory overflow fixes for display code.
2456 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2457 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2458 (scrolling_window): Check for overflow in size calculations.
2459 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2460 Don't assume glyph table len fits in int.
2461 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2462 (row_table_size): Now ptrdiff_t, not int.
2463 (scrolling_window): Avoid overflow in size calculations.
2464 Don't update size until allocation succeeds.
2465 * fns.c (concat): Check for overflow in size calculations.
2466 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2467 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2468 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2470 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2471 (get_doc_string): Check for size calculation overflow.
2472 Don't update size until allocation succeeds.
2473 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2474 EMACS_INT, where ptrdiff_t will do.
2475 (Fsubstitute_command_keys): Check for string overflow.
2477 * editfns.c (set_time_zone_rule): Don't assume environment length
2479 (message_length): Now ptrdiff_t, not int.
2480 (Fmessage_box): Don't update size until allocation succeeds.
2481 Don't assume message length fits in int.
2482 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2484 * emacs.c (main): Do not reallocate argv, since there is a null at
2485 the end that can be overwritten, and this way there's no need to
2486 worry about size-calculation overflow.
2487 (sort_args): Check for size-calculation overflow.
2489 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2491 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2493 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2494 (x_set_scroll_bar_width, x_figure_window_size):
2495 Check for integer overflow.
2496 (x_set_alpha): Do not assume XINT fits in int.
2498 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2499 This is for the members text_lines, text_cols, total_lines, total_cols,
2500 where the system imposes an 'int' limit.
2502 * fringe.c (Fdefine_fringe_bitmap):
2503 Don't update size until alloc works.
2505 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2506 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2508 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2509 Check for size-calculation overflow.
2510 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2511 do, as we prefer signed integers.
2512 (id_to_widget.max_size, id_to_widget.used)
2513 (xg_store_widget_in_map, xg_remove_widget_from_map)
2514 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2515 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2516 Use and return ptrdiff_t, not int.
2517 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2518 * gtkutil.h: Change prototypes to match the above.
2520 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2521 are duplicate now that they've been promoted to lisp.h.
2522 (x_allocate_bitmap_record, x_alloc_image_color)
2523 (make_image_cache, cache_image, xpm_load):
2524 Don't update size until alloc is done.
2525 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2527 Check for size calculation overflow.
2528 (ct_colors_allocated_max): New constant.
2529 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2532 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2533 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2534 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2535 Use ptrdiff_t, not int, to count maps.
2536 (read_char_minibuf_menu_prompt): Check for overflow in size
2537 calculations. Don't update size until allocation succeeds.
2538 Redo calculations to avoid overflow.
2539 * keyboard.h: Change prototypes to match the above.
2541 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2543 (current_minor_maps): Check for size calculation overflow.
2544 * keymap.h: Change prototypes to match the above.
2546 * lread.c (read1, init_obarray): Don't update size until alloc done.
2548 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2549 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2551 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2552 Now ptrdiff_t, not int.
2553 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2554 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2556 * process.c (Fnetwork_interface_list): Check for overflow
2557 in size calculation.
2559 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2561 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2562 overflow. Don't bother calling xmalloc when xrealloc will do.
2564 * search.c (Freplace_match): Check for size calculation overflow.
2565 (Fset_match_data): Don't assume list lengths fit in 'int'.
2567 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2568 for command line length. Do not attempt to address one before the
2569 beginning of an array, as that's not portable.
2571 * term.c (max_frame_lines): Remove; unused.
2572 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2574 (encode_terminal_code, calculate_costs): Check for size
2575 calculation overflow.
2576 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2577 table lengths and related sizes. Don't update size until alloc
2578 done. Redo calculations to avoid overflow.
2579 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2581 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2582 subtracting pointers.
2583 (gobble_line): Check for overflow more carefully. Don't update size
2586 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2587 Don't update size until alloc done.
2588 Redo size calculations to avoid overflow.
2589 Check for size calculation overflow.
2590 (main) [DEBUG]: Fix typo in invoking tparam1.
2592 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2593 Use ptrdiff_t, not int, for sizes.
2594 (store_mode_line_noprop_char): Don't update size until alloc done.
2596 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2597 Use ptrdiff_t, not int, for sizes.
2598 (Finternal_make_lisp_face, cache_face):
2599 Check for size calculation overflow.
2600 (cache_face): Treat size calculation overflows as if they were
2601 memory exhaustion (the usual treatment), rather than aborting.
2603 * xfns.c (x_encode_text, x_set_name_internal)
2604 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2605 sizes, since they can exceed INT_MAX in size. Check for size
2606 calculation overflow.
2608 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2609 (xg_select): Check for size calculation overflow.
2610 Don't update size until alloc done.
2612 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2613 as sprintf is limited to int lengths.
2615 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2616 (X_LONG_MIN): New macros.
2617 Use them to make the following changes clearer.
2618 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2619 This change doesn't affect the value now, but it may help remind
2620 future maintainers not to raise the value too much later.
2621 (SELECTION_QUANTUM): Remove, replacing with ...
2622 (selection_quantum): ... new function, which avoids overflow.
2624 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2625 assumption that selection length fits in 'int'.
2626 (x_reply_selection_request, x_handle_selection_request)
2627 (x_get_window_property, receive_incremental_selection)
2628 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2629 (lisp_data_to_selection_data, clean_local_selection_data):
2630 Use ptrdiff_t, not int, to record length of selection.
2631 (x_reply_selection_request, x_get_window_property)
2632 (receive_incremental_selection, x_property_data_to_lisp):
2633 Redo calculations to avoid overflow.
2634 (x_reply_selection_request): When sending hint, ceiling it at
2635 X_LONG_MAX rather than relying on wraparound overflow to send
2637 (x_get_window_property, receive_incremental_selection)
2638 (lisp_data_to_selection_data, x_property_data_to_lisp):
2639 Check for size-calculation overflow.
2640 (x_get_window_property, receive_incremental_selection)
2641 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2642 Don't store size until memory allocation succeeds.
2643 (x_get_window_property): Plug memory leak on memory exhaustion.
2644 Don't double-block input; malloc is safe here. Don't assume 2**34
2645 - 4 fits in unsigned long. Add an xassert to check
2646 XGetWindowProperty overflow. Be more careful about overflow
2647 calculations, and distinguish size from memory overflow better.
2648 (receive_incremental_selection): When tracing, don't assume
2649 unsigned int is less than INT_MAX.
2650 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2651 harmful) conversions of unsigned short to int.
2652 (lisp_data_to_selection_data): Don't assume that integers
2653 in the range -65535 through -1 fit in an X unsigned short.
2654 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2655 result parameters unless successful. Rely on cons_to_unsigned
2656 to report problems with elements; the old code wasn't right anyway.
2657 (x_check_property_data): Check for int overflow; we cannot use
2658 a wider type due to X limits.
2659 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2661 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2663 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2664 (x_term_init): Check for size calculation overflow.
2665 (x_color_cells): Don't store size until memory allocation succeeds.
2666 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2667 Don't assume alloca size is less than MAX_ALLOCA.
2668 (x_term_init): Don't assume length fits in int (sprintf is limited
2671 Use ptrdiff_t for composition IDs.
2672 * character.c (lisp_string_width):
2673 * composite.c (composition_table_size, n_compositions)
2674 (get_composition_id, composition_gstring_from_id):
2675 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2676 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2677 * window.c (Frecenter):
2678 Use ptrdiff_t, not int, for composition IDs.
2679 * composite.c (get_composition_id): Check for integer overflow.
2680 * composite.h: Adjust prototypes to match the above changes.
2682 Use ptrdiff_t for hash table indexes.
2683 * category.c (hash_get_category_set):
2684 * ccl.c (ccl_driver):
2685 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2686 * coding.c (coding_system_charset_list, detect_coding_system):
2687 * coding.h (struct coding_system.id):
2688 * composite.c (get_composition_id, gstring_lookup_cache):
2689 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2690 * image.c (xpm_get_color_table_h):
2691 * lisp.h (hash_lookup, hash_put):
2692 * minibuf.c (Ftest_completion):
2693 Use ptrdiff_t for hash table indexes, not int (which is too
2694 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2695 32-bit --with-wide-int hosts).
2697 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2698 Add a FIXME comment about memory leaks.
2699 (syms_of_charset): Don't assume xmalloc returns.
2701 Don't assume that stated character widths fit in int.
2702 * character.c (Fchar_width, c_string_width, lisp_string_width):
2703 * character.h (CHAR_WIDTH):
2704 * indent.c (MULTIBYTE_BYTES_WIDTH):
2705 Use sanitize_char_width to avoid undefined and/or bad behavior
2706 with outlandish widths.
2707 * character.h (sanitize_tab_width): Rename from sanitize_width,
2708 now that we have two such functions. All uses changed.
2709 (sanitize_char_width): New inline function.
2711 Don't assume that tab-width fits in int.
2712 * character.h (sanitize_width): New inline function.
2713 (SANE_TAB_WIDTH): New macro.
2714 (ASCII_CHAR_WIDTH): Use it.
2715 * indent.c (sane_tab_width): Remove. All uses replaced by
2716 SANE_TAB_WIDTH (current_buffer).
2717 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2719 * fileio.c: Integer overflow issues with file modes.
2720 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2722 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2723 Remove unreachable code.
2724 (read_hex, load_charset_map_from_file): Check for integer overflow.
2726 * xterm.c: Don't go over XClientMessageEvent limit.
2727 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2728 (x_send_scroll_bar_event): Likewise. Check that the size does not
2729 exceed limits imposed by XClientMessageEvent, as well as the usual
2730 ptrdiff_t and size_t limits.
2732 * keyboard.c: Overflow, signedness and related fixes.
2733 (make_lispy_movement): Use same integer type in forward decl
2734 that is used in the definition.
2735 (read_key_sequence, keyremap_step):
2736 Change bufsize argument back to int, undoing my 2011-03-30 change.
2737 We prefer signed types, and int is wide enough here.
2738 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2739 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2740 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2741 length, not size_t. Use ptrdiff_t for index, not int.
2742 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2743 possibility of integer overflow.
2745 Overflow, signedness and related fixes for images.
2747 * dispextern.h (struct it.stack[0].u.image.image_id)
2748 (struct_it.image_id, struct image.id, struct image_cache.size)
2749 (struct image_cache.used, struct image_cache.ref_count):
2750 * gtkutil.c (update_frame_tool_bar):
2751 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2752 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2753 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2754 * nsmenu.m (update_frame_tool_bar):
2755 * xdisp.c (calc_pixel_width_or_height):
2756 * xfns.c (image_cache_refcount):
2757 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2758 on typical 64-bit hosts.
2760 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2761 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2762 Omit unnecessary casts to int.
2763 (parse_image_spec): Check that integers fall into 'int' range
2764 when the callers expect that.
2765 (image_ascent): Redo ascent calculation to avoid int overflow.
2766 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2767 (lookup_image): Remove unnecessary tests.
2768 (xbm_image_p): Locals are now of int, not EMACS_INT,
2769 since parse_image_check makes sure they fit into int.
2770 (png_load, gif_load, svg_load_image):
2771 Prefer int to unsigned where either will do.
2772 (tiff_handler): New function, combining the cores of the
2773 old tiff_error_handler and tiff_warning_handler.
2774 This function is rewritten to use vsnprintf and thereby avoid
2775 stack buffer overflows. It uses only the features of vsnprintf
2776 that are common to both POSIX and native Microsoft.
2777 (tiff_error_handler, tiff_warning_handler): Use it.
2778 (tiff_load, gif_load, imagemagick_load_image):
2779 Don't assume :index value fits in 'int'.
2780 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2781 (imagemagick_load_image): Check that crop parameters fit into
2782 the integer types that MagickCropImage accepts. Don't assume
2783 Vimagemagick_render_type has a nonnegative value. Don't assume
2784 size_t fits in 'long'.
2785 (gs_load): Use printmax_t to print the widest integers possible.
2786 Check for integer overflow when computing image height and width.
2788 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2790 * xdisp.c (redisplay_window): Don't force window start if point
2791 will be invisible in the resulting window. (Bug#9324)
2793 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2795 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2796 the display spec is of the form `(space ...)'.
2797 (handle_display_spec): Return the value returned by
2798 handle_single_display_spec, not just 1 or zero.
2799 (handle_single_display_spec): If the display spec is of the form
2800 `(space ...)', and specifies display in the text area, return 2
2802 (try_cursor_movement): Check for the need to scroll more
2803 accurately, and prefer exact match for point under bidi.
2804 Don't advance `row' beyond the last row of the window.
2806 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2807 into disp_prop; all users changed.
2809 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2810 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2811 for the text covered by the display property.
2813 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2815 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2816 Change return value to nil.
2817 (Frecord_buffer): Delete unused function.
2819 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2821 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2822 buffers, return left-to-right.
2823 (set_cursor_from_row): Consider candidate row a win if its glyph
2824 represents a newline and point is on that newline. Fixes cursor
2825 positioning on the newline at EOL of R2L text within L2R
2826 paragraph, and vice versa.
2827 (try_cursor_movement): Check continued rows, in addition to
2828 continuation rows. Fixes unwarranted scroll when point enters a
2829 continued line of R2L text within an L2R paragraph, or vice versa.
2830 (cursor_row_p): Consider the case of point being equal to
2831 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2832 from the end of a short line to the beginning of a continued line
2833 of R2L text within L2R paragraph.
2834 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2835 composed characters.
2837 * bidi.c (bidi_check_type): Use xassert.
2838 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2841 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2843 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2846 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2848 * nsfont.m (ns_otf_to_script): Fix typo.
2850 2011-08-22 Kenichi Handa <handa@m17n.org>
2852 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2853 extra slot even if the purpose is char-code-property-table.
2855 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2857 * xdisp.c (redisplay_window): When computing centering_position,
2858 account for the height of the header line. (Bug#8874)
2860 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2861 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2862 candidate is selected by the mouse, and that candidate has a
2863 composed character under the mouse.
2865 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2866 coordinates reported by pos-visible-in-window-p for a composed
2867 character in column zero.
2869 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2871 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2873 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2875 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2876 consider it a hit if to_charpos is anywhere in the range of the
2877 composed buffer positions.
2879 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2881 * image.c (gif_load): Don't assume that each subimage has the same
2882 dimensions as the base image. Handle disposal method that is
2883 "undefined" by the gif spec (Bug#9335).
2885 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2887 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2888 (Fcondition_case): Document `debug' symbol in error handler.
2890 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2892 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2893 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2894 from an Org mode buffer to a Speedbar frame.
2896 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2897 a composition, take its buffer position from IT->cmp_it.charpos.
2898 Fixes cursor positioning at the beginning of a line that begins
2899 with a composed character.
2901 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2903 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2904 character bidirectional type, use STRONG_L instead. Fixes crashes
2905 in a buffer produced by `describe-categories'.
2907 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2908 members before the level stack, so they would be saved and
2909 restored when copying iterator state. Fixes incorrect reordering
2910 around TABs covered by display properties.
2912 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2914 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2916 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2918 * eval.c (internal_condition_case, internal_condition_case_1)
2919 (internal_condition_case_2, internal_condition_case_n):
2920 Remove unnecessary aborts (Bug#9081).
2922 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2924 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2925 has no `load' handler, try opening the file locally. (Bug#9311)
2927 2011-08-16 Ken Brown <kbrown@cornell.edu>
2929 * gmalloc.c: Expand comment.
2931 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2933 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2934 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2936 2011-08-16 Ken Brown <kbrown@cornell.edu>
2938 Fix memory allocation problems in Cygwin build (Bug#9273).
2940 * unexcw.c ( __malloc_initialized): Declare external variable.
2941 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2943 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2945 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2947 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2949 [CYGWIN] (special_realloc): New function.
2950 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2951 requests to realloc storage in the static heap.
2953 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2955 * bidi.c (bidi_initialize): Remove unused local.
2957 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2960 * biditype.h: Remove file.
2961 * makefile.w32-in ($(BLD)/bidi.$(O)):
2962 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2964 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2966 * chartab.c: Improve commentary for the uniprop_table API.
2968 * bidi.c (bidi_paragraph_init): Support zero value of
2969 bidi_ignore_explicit_marks_for_paragraph_level.
2970 (bidi_initialize): Use uniprop_table instead of including
2971 biditype.h and bidimirror.h.
2973 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2974 coordinates of the iterator when restoring from ppos_it.
2977 2011-08-14 Kenichi Handa <handa@m17n.org>
2979 * process.c (create_process): Call setup_process_coding_systems
2980 after the pid of the process is set to -1 (Bug#8162).
2982 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2984 * xdisp.c (move_it_in_display_line_to): Don't invoke
2985 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2986 ppos_it. Fixes vertical cursor motion when line beginning is
2987 covered by an image. (Bug#9296)
2989 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2991 * nsterm.h (ns_run_ascript): Declare.
2992 (NSAPP_DATA2_RUNASSCRIPT): Define.
2994 * nsfns.m (as_script, as_result, as_status): New static variables.
2995 (ns_run_ascript): New function.
2996 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2997 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2998 the event loop. Get status from as_status (Bug#7276).
3000 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3001 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3002 the event loop (Bug#7276).
3004 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3006 * gnutls.c (QCgnutls_bootprop_priority)
3007 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3008 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3009 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3010 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3011 (QCgnutls_bootprop_verify_hostname_error)
3012 (QCgnutls_bootprop_callbacks_verify): Rename from
3013 Qgnutls_bootprop_..., all uses changed.
3015 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3018 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3020 * xfaces.c (Qframe_set_background_mode): Now static.
3021 * dispextern.h (Qframe_set_background_mode): Remove decl.
3023 * process.c (Fnetwork_interface_info): Declare local only if needed.
3025 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3027 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3028 (Fnetwork_interface_list): Allocate in increments of bytes instead
3029 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3030 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3032 (struct ifflag_def): notrailers is smart on OSX.
3033 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3034 Get hardware address with getifaddrs if available.
3036 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3038 * xdisp.c (iterate_out_of_display_property): xassert that
3039 IT->position is set to within IT->object's boundaries. Break from
3040 the loop as soon as EOB is reached; avoids infloops in redisplay
3041 when IT->position is set up wrongly due to some bug.
3042 Set IT->current to match the bidi iterator unconditionally.
3043 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3044 entry. Force push_it to save on the stack the current
3045 buffer/string position, to be restored by pop_it. Fix flags in
3046 the iterator structure wrt the object coming from a display
3047 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3048 properties. (Bug#9284)
3050 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3052 * fontset.c (fontset_get_font_group): Add proper type checks.
3055 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3057 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3058 and LC_VERSION_MIN_MACOSX.
3059 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3060 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3062 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3064 * xdisp.c (forward_to_next_line_start): Allow to use the
3065 no-display-properties-and-no-overlays under bidi display.
3066 Set disp_pos in the bidi iterator to avoid searches for display
3067 properties and overlays.
3069 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3071 * editfns.c (Fset_time_zone_rule): Document relationship with the
3074 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3075 the font entity extracted from the cache (Bug#8109).
3077 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3079 * composite.c (autocmp_chars): Don't reset point. That is done by
3080 restore_point_unwind (Bug#5984).
3082 2011-08-07 Juri Linkov <juri@jurta.org>
3084 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3085 to show the arg `TIME' instead of `TIMEVAL'.
3087 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3089 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3090 display property strides EOL and includes a newline, as in
3091 longlines-mode. (Bug#9254)
3092 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3093 word-wrap under bidirectional display. (Bug#9224)
3095 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3096 is non-zero, even if the data buffer is NULL. Fixes a crash in
3097 vertical-motion with longlines-mode. (Bug#9254)
3099 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3101 * bidi.c <bidi_cache_total_alloc>: Now static.
3102 (bidi_initialize): Initialize bidi_cache_total_alloc.
3104 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3107 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3108 amount allocated this far in `bidi_cache_total_alloc'.
3109 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3110 non-zero, only free the data buffer without restoring the cache
3111 contents. All callers changed.
3113 * dispextern.h (bidi_unshelve_cache): Update prototype.
3115 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3116 (move_it_in_display_line, move_it_to)
3117 (move_it_vertically_backward, move_it_by_lines): Replace the call
3118 to xfree to an equivalent call to bidi_unshelve_cache.
3119 (move_it_in_display_line_to): Fix logic of returning
3120 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3122 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3124 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3125 came from a string character with a `cursor' property. (Bug#9229)
3127 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3129 * Makefile.in (LIB_PTHREAD): New variable.
3130 (LIBES): Add LIB_PTHREAD (Bug#9216).
3132 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3133 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3135 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3137 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3139 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3141 * xterm.c (x_find_topmost_parent): New function.
3142 (x_set_frame_alpha): Find topmost parent window with
3143 x_find_topmost_parent and set the property there also (bug#9181).
3144 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3146 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3148 * callproc.c (Fcall_process): Avoid vfork clobbering
3149 the local vars buffer, coding_systems, current_dir.
3151 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3153 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3155 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3157 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3158 so that it is not optimized away.
3160 * xdisp.c (compute_display_string_pos): Remove unused local.
3162 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3164 Fix slow cursor motion and scrolling in large buffers with
3165 selective display, like Org Mode buffers. (Bug#9218)
3167 * dispextern.h (struct bidi_it): New member disp_prop_p.
3169 * xdisp.c: Remove one-slot cache of display string positions.
3170 (compute_display_string_pos): Accept an additional argument
3171 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3172 for a display string or property. If found, set DISP_PROP_P
3175 * bidi.c (bidi_fetch_char): Accept an additional argument
3176 DISP_PROP_P, and pass it to compute_display_string_pos.
3177 Only handle text covered by a display string if DISP_PROP_P is returned
3178 non-zero. All callers of bidi_fetch_char changed.
3180 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3182 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3184 2010-12-03 Don March <don@ohspite.net>
3186 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3187 last character M-[char] is translated to ESC [char] (bug#7541).
3189 2011-08-02 Kenichi Handa <handa@m17n.org>
3191 * lisp.h (uniprop_table): Extern it.
3193 * chartab.c (uniprop_table): Make it non-static.
3195 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3197 * xdisp.c (forward_to_next_line_start): Accept additional argument
3198 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3200 (reseat_at_next_visible_line_start): Use the bidi iterator state
3201 returned by forward_to_next_line_start to restore the state of
3202 it->bidi_it after backing up to previous newline. (Bug#9212)
3204 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3206 * regex.c (re_comp): Protoize.
3207 (re_exec): Fix return type.
3208 (regexec): Fix type of `ret'. (Bug#9203)
3210 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3212 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3213 This is needed if max-image-size is a floating-point number.
3215 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3217 * print.c (print_object): Print empty symbol as ##.
3219 * lread.c (read1): Read ## as empty symbol.
3221 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3223 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3224 setting frame foreground color (Bug#9175).
3225 (x_set_background_color): Likewise.
3227 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3228 contents (Bug#9176).
3229 (EmacsTooltip -init): Remove bezels and add shadows to
3232 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3233 or scroll bar (Bug#8470).
3235 * nsfont.m (nsfont_open): Remove assignment to voffset and
3236 unnecessary vars hshink, expand, hd, full_height, min_height.
3237 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3239 * nsterm.h (nsfont_info): Remove voffset field.
3241 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3243 Implement strike-through and overline on NextStep (Bug#8863).
3245 * nsfont.m (nsfont_open): Use underline position provided by font,
3246 instead of hard-coded value of 2.
3247 (nsfont_draw): Call ns_draw_text_decoration instead.
3249 * nsterm.h: Add declaration for ns_draw_text_decoration.
3251 * nsterm.m (ns_draw_text_decoration): New function for drawing
3252 underline, overline, and strike-through.
3253 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3254 ns_draw_text_decoration. Change treatment of cursor drawing to
3255 accommodate underlining, etc.
3257 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3259 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3262 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3264 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3265 Without this fix, if a signal arrives just after memory fills up,
3266 'malloc' might be invoked reentrantly.
3268 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3269 In other words, assume that every image size is allowed, on non-X
3270 hosts. This assumption is probably wrong, but it lets Emacs compile.
3272 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3274 * regex.c (re_iswctype): Convert return values to boolean.
3276 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3278 * xdisp.c (compute_display_string_pos): Don't use cached display
3279 string position if the buffer had its restriction changed.
3282 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3284 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3286 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3288 Integer signedness and overflow and related fixes. (Bug#9079)
3290 * bidi.c: Integer size and overflow fixes.
3291 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3292 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3293 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3294 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3295 (bidi_find_other_level_edge):
3296 Use ptrdiff_t instead of EMACS_INT where either will do.
3297 This works better on 32-bit hosts configured --with-wide-int.
3298 (bidi_cache_ensure_space): Check for size-calculation overflow.
3299 Use % rather than repeated addition, for better worst-case speed.
3300 Don't set bidi_cache_size until after xrealloc returns, because it
3302 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3303 (bidi_cache_ensure_space): Also check that the bidi cache size
3304 does not exceed that of the largest Lisp string or buffer. See Eli
3305 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3307 * alloc.c (__malloc_size_t): Remove.
3308 All uses replaced by size_t. See Andreas Schwab's note
3309 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3311 * image.c: Improve checking for integer overflow.
3312 (check_image_size): Assume that f is nonnull, since
3313 it is always nonnull in practice. This is one less thing to
3314 worry about when checking for integer overflow later.
3315 (x_check_image_size): New function, which checks for integer
3316 overflow issues inside X.
3317 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3318 This removes the need for a memory_full check.
3319 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3320 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3321 (xbm_read_bitmap_data): Change locals back to 'int', since
3322 their values must fit in 'int'.
3323 (xpm_load_image, png_load, tiff_load):
3324 Invoke x_create_x_image_and_pixmap earlier,
3325 to avoid much needless work if the image is too large.
3326 (tiff_load): Treat overly large images as if
3327 x_create_x_image_and_pixmap failed, not as malloc failures.
3328 (gs_load): Use x_check_image_size.
3330 * gtkutil.c: Omit integer casts.
3331 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3332 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3334 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3336 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3337 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3338 would wrongly return t on a 64-bit host.
3340 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3341 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3342 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3343 and therefore cause GCC to emit a bogus diagnostic in some cases.
3345 * image.c: Integer signedness and overflow and related fixes.
3346 This is not an exhaustive set of fixes, but it's time to
3347 record what I've got.
3348 (lookup_pixel_color, check_image_size): Remove redundant decls.
3349 (check_image_size): Don't assume that arbitrary EMACS_INT values
3350 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3351 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3352 (tiff_load, imagemagick_load_image):
3353 Check for overflow in size calculations.
3354 (x_create_x_image_and_pixmap): Remove unnecessary test for
3355 xmalloc returning NULL; that can't happen.
3356 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3357 (xpm_color_bucket): Use better integer hashing function.
3358 (xpm_cache_color): Don't possibly over-allocate memory.
3359 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3360 (gif_memory_source):
3361 Use ptrdiff_t, not int or size_t, to record sizes.
3362 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3363 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3364 either works, as we prefer signed integers.
3365 (tiff_read_from_memory, tiff_write_from_memory):
3366 Return tsize_t, not size_t, since that's what the TIFF API wants.
3367 (tiff_read_from_memory): Don't fail simply because the read would
3368 go past EOF; instead, return a short read.
3369 (tiff_load): Omit no-longer-needed casts.
3370 (Fimagemagick_types): Don't assume size fits into 'int'.
3372 Improve hashing quality when configured --with-wide-int.
3373 * fns.c (hash_string): New function, taken from sxhash_string.
3374 Do not discard information about ASCII character case; this
3375 discarding is no longer needed.
3376 (sxhash-string): Use it. Change sig to match it. Caller changed.
3377 * lisp.h: Declare it.
3378 * lread.c (hash_string): Remove, since we now use fns.c's version.
3379 The fns.c version returns a wider integer if --with-wide-int is
3380 specified, so this should help the quality of the hashing a bit.
3382 * emacs.c: Integer overflow minor fix.
3383 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3384 Define only if GNU_LINUX.
3385 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3387 * dispnew.c: Integer signedness and overflow fixes.
3388 Remove unnecessary forward decls, that were a maintenance hassle.
3389 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3391 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3392 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3393 (prepare_desired_row, line_draw_cost):
3394 Use int, not unsigned, where either works.
3395 (save_current_matrix, restore_current_matrix):
3396 Use ptrdiff_t, not size_t, where either works.
3397 (init_display): Check for overflow more accurately, and without
3398 relying on undefined behavior.
3400 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3401 Remove, replacing with the new symbols in lisp.h. All uses changed.
3402 * fileio.c (make_temp_name):
3403 * filelock.c (lock_file_1, lock_file):
3404 * xdisp.c (message_dolog):
3405 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3406 Use pMd etc. instead.
3407 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3408 replacing the pWIDE etc. symbols removed from editfns.c.
3410 * keyboard.h (num_input_events): Now uintmax_t.
3411 This is (very slightly) less likely to mess up due to wraparound.
3414 * buffer.c: Integer signedness fixes.
3415 (alloc_buffer_text, enlarge_buffer_text):
3416 Use ptrdiff_t rather than size_t when either will do, as we prefer
3419 * alloc.c: Integer signedness and overflow fixes.
3420 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3421 (__malloc_size_t): Default to size_t, not to int.
3422 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3423 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3424 Prefer ptrdiff_t to size_t when either would do, as we prefer
3426 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3427 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3428 Now const. Initialize with values that are in range even if char
3430 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3431 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3432 These functions do the right thing with sizes > 2**32.
3433 (check_depth): Now ptrdiff_t, not int.
3434 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3435 Adjust to new way of storing sizes. Check for size overflow bugs
3437 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3438 slightly wrong anyway, as it missed one instance of
3439 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3440 (refill_memory_reserve): Omit needless cast to size_t.
3441 (mark_object_loop_halt): Mark as externally visible.
3443 * xselect.c: Integer signedness and overflow fixes.
3444 (Fx_register_dnd_atom, x_handle_dnd_message):
3445 Use ptrdiff_t, not size_t, since we prefer signed.
3446 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3447 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3448 x_dnd_atoms_size and x_dnd_atoms_length.
3450 * doprnt.c: Prefer signed to unsigned when either works.
3452 * doprnt.c (doprnt):
3454 * xdisp.c (vmessage):
3455 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3456 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3457 prefer signed arithmetic to avoid comparison confusion.
3458 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3459 but is a bit tricky.
3461 Assume freestanding C89 headers, string.h, stdlib.h.
3462 * data.c, doprnt.c, floatfns.c, print.c:
3463 Include float.h unconditionally.
3464 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3465 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3466 * regex.c: Likewise for stddef.h, string.h.
3467 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3468 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3469 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3470 (STDC_HEADERS): Remove obsolete defines.
3471 * sysdep.c: Include limits.h unconditionally.
3473 Assume support for memcmp, memcpy, memmove, memset.
3474 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3475 * regex.c (memcmp, memcpy):
3476 Remove; we assume C89 now.
3478 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3479 (__malloc_safe_bcopy): Remove; no longer needed.
3481 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3482 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3483 well either way, and we prefer signed to unsigned.
3485 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3487 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3488 closes the connection while we're reading (bug#9182).
3490 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3492 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3493 are specified (Bug#9168).
3495 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3497 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3498 Found by GCC static checking and --with-wide-int on a 32-bit host.
3500 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3502 * xdisp.c (compute_display_string_pos): Fix logic of caching
3503 previous display string position. Initialize cached_prev_pos to
3504 -1. Fixes slow-down at the beginning of a buffer.
3506 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3508 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3509 for attrs[LFACE_FONTSET_INDEX].
3511 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3513 * xml.c (parse_region): Remove unused local
3514 that was recently introduced.
3516 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3518 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3519 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3521 * xdisp.c (move_it_in_display_line_to): Record the best matching
3522 position for TO_CHARPOS while scanning the line, and restore it on
3523 exit if none of the characters scanned was an exact match.
3524 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3525 when exact match is impossible due to invisible text, and the
3526 lines are truncated.
3528 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3530 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3533 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3535 Fix a significant slow-down of cursor motion with C-n, C-p,
3536 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3537 auto-repeat under bidi redisplay in fontified buffers.
3538 * xdisp.c (compute_stop_pos_backwards): New function.
3539 (next_element_from_buffer): Call compute_stop_pos_backwards to
3540 find a suitable prev_stop when we find ourselves before
3542 (reseat): Don't look for prev_stop, as that could mean a very long
3544 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3545 <cached_disp_overlay_modiff>: Cache for last found display string
3547 (compute_display_string_pos): Return the cached position if asked
3548 about the same buffer in the same area of character positions, and
3549 the buffer wasn't changed since the time the display string
3550 position was cached.
3552 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3554 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3555 is an integer, which is important for empty lines. (Bug#9149)
3557 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3559 * frame.c (Fmodify_frame_parameters): In tty case, update the
3560 default face if necessary (Bug#4238).
3562 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3564 * editfns.c (Fstring_to_char): No need to explain what a character
3565 is in the docstring (Bug#6576).
3567 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3569 * xml.c (parse_region): Make sure we always return a tree.
3571 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3573 * xml.c (parse_region): If a document contains only comments,
3576 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3578 * xml.c (make_dom): Return comments, too.
3580 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3583 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3584 and the surrounding thread.
3585 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3586 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3587 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3589 * s/openbsd.h (BROKEN_SIGIO): Define.
3590 * unexelf.c (unexec) [__OpenBSD__]:
3591 Don't update the .mdebug section of the Alpha COFF symbol table.
3593 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3595 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3598 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3600 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3601 This fixes some race conditions on the permissions of any newly
3604 * alloc.c (valid_pointer_p): Use pipe, not open.
3605 This fixes some permissions issues when debugging.
3607 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3608 If fchown fails to set both uid and gid, try to set just gid,
3609 as that is sometimes allowed. Adjust the file's mode to eliminate
3610 setuid or setgid bits that are inappropriate if fchown fails.
3612 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3614 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3615 to compare Lisp_Objects.
3616 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3617 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3618 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3620 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3622 * lread.c (read_integer): Unread even EOF character.
3623 (read1): Likewise. Properly record start position of symbol.
3625 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3626 symbol character follows.
3628 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3630 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3631 This works around a problem with the previous change to Fcopy_file.
3632 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3633 and without this change, GCC might complain about discarding
3634 fchown's return value.
3636 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3638 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3640 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3642 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3644 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3646 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3647 it's used from the C level.
3649 * process.c: Use the same condition for POLL_FOR_INPUT in both
3650 keyboard.c and process.c (bug#1858).
3652 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3654 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3655 (Fgnutls_boot): Use it.
3657 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3659 * doc.c (Fsubstitute_command_keys): Revert last change.
3661 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3663 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3664 quotes the next character, and doesn't affect other longer
3665 sequences (bug#8935).
3667 * lread.c (syms_of_lread): Clarify that is isn't only
3668 `eval-buffer' and `eval-defun' that's affected by
3669 `lexical-binding' (bug#8460).
3671 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3673 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3674 bidi redisplay when a line includes both an image and is truncated.
3676 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3678 Fix minor problems found by static checking.
3679 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3680 (elsz): Now a signed constant, not a size_t var. We prefer signed
3681 types to unsigned, to avoid integer comparison confusion. Without
3682 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3683 "cannot optimize loop, the loop counter may overflow", a symptom
3685 * indent.c (Fvertical_motion): Mark locals as initialized.
3686 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3688 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3690 * search.c (Fre_search_backward): Mention `case-fold-search' in
3691 all the re_search_* functions (bug#8138).
3693 * keyboard.c (Fopen_dribble_file): Document when the file is
3696 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3698 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3701 Support bidi reordering of display and overlay strings.
3702 * xdisp.c (compute_display_string_pos)
3703 (compute_display_string_end): Accept additional argument STRING.
3704 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3705 (reseat_to_string): Initialize bidi_it->string.s and
3706 bidi_it->string.schars.
3707 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3708 NULL (avoids a crash in bidi_paragraph_init).
3709 Initialize itb.string.lstring.
3710 (init_iterator): Call bidi_init_it only of a valid
3711 buffer position was specified. Initialize paragraph_embedding to
3713 (reseat_to_string): Initialize the bidi iterator.
3714 (display_string): If we need to ignore text properties of
3715 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3716 original value of -1 will not work with bidi.)
3717 (compute_display_string_pos): First arg is now struct
3718 `text_pos *'; all callers changed. Support display properties on
3720 (compute_display_string_end): Support display properties on Lisp
3722 (init_iterator, reseat_1, reseat_to_string): Initialize the
3723 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3724 when iterating on a string not from display properties).
3725 (compute_display_string_pos, compute_display_string_end):
3726 Fix calculation of the object to scan. Fixes an error when using
3728 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3729 base_level_stop; instead, set base_level_stop to BEGV.
3730 Fixes crashes in vertical-motion.
3731 (next_element_from_buffer): Improve commentary for when
3732 the iterator is before prev_stop.
3733 (init_iterator): Initialize bidi_p from the default value of
3734 bidi-display-reordering, not from buffer-local value. Use the
3735 buffer-local value only if initializing for buffer iteration.
3736 (handle_invisible_prop): Support invisible properties on strings
3737 that are being bidi-reordered.
3738 (set_iterator_to_next): Support bidi reordering of C strings and
3740 (next_element_from_string): Support bidi reordering of Lisp
3742 (handle_stop_backwards): Support Lisp strings as well.
3743 (display_string): Support display of R2L glyph rows.
3744 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3745 (init_iterator): Don't initialize it->bidi_p for strings
3747 (reseat_to_string): Initialize it->bidi_p for strings here.
3748 (next_element_from_string, next_element_from_c_string)
3749 (next_element_from_buffer): Add xassert's for correspondence
3750 between IT's object being iterated and it->bidi_it.string
3752 (face_before_or_after_it_pos): Support bidi iteration.
3753 (next_element_from_c_string): Handle the case of the first string
3754 character that is not the first one in the visual order.
3755 (get_visually_first_element): New function, refactored from common
3756 parts of next_element_from_buffer, next_element_from_string, and
3757 next_element_from_c_string.
3758 (tool_bar_lines_needed, redisplay_tool_bar)
3759 (display_menu_bar): Force left-to-right direction. Add a FIXME
3760 comment for making that be controlled by a user option.
3761 (push_it, pop_it): Save and restore the state of the
3762 bidi iterator. Save and restore the bidi_p flag.
3763 (pop_it): Iterate out of display property for string iteration as
3765 (iterate_out_of_display_property): Support iteration over strings.
3766 (handle_single_display_spec): Set up it->bidi_it for iteration
3767 over a display string, and call bidi_init_it.
3768 (handle_single_display_spec, next_overlay_string)
3769 (get_overlay_strings_1, push_display_prop): Set up the bidi
3770 iterator for displaying display or overlay strings.
3771 (forward_to_next_line_start): Don't use the shortcut if
3773 (back_to_previous_visible_line_start): If handle_display_prop
3774 pushed the iterator stack, restore the internal state of the bidi
3775 iterator by calling bidi_pop_it same number of times.
3776 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3777 and we are bidi-iterating, don't decrement the iterator position;
3778 instead, set the first_elt flag in the bidi iterator, to produce
3780 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3781 (push_display_prop): xassert that we are iterating a buffer.
3782 (push_it, pop_it): Save and restore paragraph_embedding member.
3783 (handle_single_display_spec, next_overlay_string)
3784 (get_overlay_strings_1, reseat_1, reseat_to_string)
3785 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3786 correctly. Don't assume unibyte strings are not bidi-reordered.
3787 (compute_display_string_pos)
3788 (compute_display_string_end): Fix handling the case of C string.
3789 (push_it, pop_it): Save and restore from_disp_prop_p.
3790 (handle_single_display_spec, push_display_prop): Set the
3791 from_disp_prop_p flag.
3792 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3793 (pop_it): Call iterate_out_of_display_property only if we are
3794 popping after iteration over a string that came from a display
3795 property. Fix a typo in popping stretch info. Add an assertion
3796 for verifying that the iterator position is in sync with the bidi
3798 (handle_single_display_spec, get_overlay_strings_1)
3799 (push_display_prop): Fix initialization of paragraph direction for
3800 string when that of the parent object is not yet determined.
3801 (reseat_1): Call bidi_init_it to resync the bidi
3802 iterator with IT's position. (Bug#7616)
3803 (find_row_edges): If ROW->start.pos gives position
3804 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3805 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3806 Reset the from_disp_prop_p flag.
3807 (SAVE_IT, RESTORE_IT): New macros.
3808 (pos_visible_p, face_before_or_after_it_pos)
3809 (back_to_previous_visible_line_start)
3810 (move_it_in_display_line_to, move_it_in_display_line)
3811 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3812 (try_scrolling, redisplay_window, display_line): Use them when
3813 saving a temporary copy of the iterator and restoring it back.
3814 (back_to_previous_visible_line_start, reseat_1)
3815 (init_iterator): Empty the bidi cache "stack".
3816 (move_it_in_display_line_to): If iterator ended up at
3817 EOL, but we never saw any buffer positions smaller than
3818 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3819 motion in bidi-reordered lines.
3820 (move_it_in_display_line_to): Record prev_method and prev_pos
3821 immediately before the call to set_iterator_to_next. Fixes cursor
3822 motion in bidi-reordered lines with stretch glyphs and strings
3823 displayed in margins. (Bug#8133) (Bug#8867)
3824 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3826 (pos_visible_p): Support positions in bidi-reordered lines.
3827 Save and restore bidi cache.
3829 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3830 (bidi_paragraph_info): Delete unused struct.
3831 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3832 (bidi_cache_start): New variable.
3833 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3835 (bidi_cache_fetch_state, bidi_cache_search)
3836 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3837 (bidi_cache_find, bidi_peek_at_next_level)
3838 (bidi_level_of_next_char, bidi_find_other_level_edge)
3839 (bidi_move_to_visually_next): Compare cache index with
3840 bidi_cache_start rather than with zero.
3841 (bidi_fetch_char): Accept new argument STRING; all callers
3842 changed. Support iteration over a string. Support strings with
3843 display properties. Support unibyte strings. Fix the type of
3844 `len' according to what STRING_CHAR_AND_LENGTH expects.
3845 (bidi_paragraph_init, bidi_resolve_explicit_1)
3846 (bidi_resolve_explicit, bidi_resolve_weak)
3847 (bidi_level_of_next_char, bidi_move_to_visually_next):
3848 Support iteration over a string.
3849 (bidi_set_sor_type, bidi_resolve_explicit_1)
3850 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3851 can now be zero (for strings); special values 0 and -1 were
3852 changed to -1 and -2, respectively.
3853 (bidi_char_at_pos): New function.
3854 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3855 Call it instead of FETCH_MULTIBYTE_CHAR.
3856 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3857 initialized to valid values.
3858 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3860 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3861 the test for valid cached positions. Fix the logic for looking up
3862 the sentinel state in the cache. GCPRO the Lisp string we are
3864 (bidi_push_it, bidi_pop_it): New functions.
3865 (bidi_initialize): Initialize the bidi cache start stack pointer.
3866 (bidi_cache_ensure_space): New function, refactored from part of
3867 bidi_cache_iterator_state. Don't assume the required size is just
3868 one BIDI_CACHE_CHUNK away.
3869 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3870 (bidi_count_bytes, bidi_char_at_pos): New functions.
3871 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3872 always valid if bidi_cache_idx is valid.
3873 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3874 is valid if it's going to be used.
3875 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3876 (bidi_cache_fetch_state, bidi_cache_search)
3877 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3878 (bidi_cache_iterator_state, bidi_cache_find)
3879 (bidi_find_other_level_edge, bidi_cache_start_stack):
3880 All variables related to cache indices are now EMACS_INT.
3882 * dispextern.h (struct bidi_string_data): New structure.
3883 (struct bidi_it): New member `string'. Make flag members be 1-bit
3884 fields, and put them last in the struct.
3885 (compute_display_string_pos, compute_display_string_end):
3887 (bidi_push_it, bidi_pop_it): Add prototypes.
3888 (struct iterator_stack_entry): New members bidi_p,
3889 paragraph_embedding, and from_disp_prop_p.
3890 (struct it): Member bidi_p is now a bit field 1 bit wide.
3891 (bidi_shelve_cache, bidi_unshelve_cache):
3894 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3895 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3896 and vector-like objects.
3898 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3899 cache around display iteration.
3901 * window.c (Fwindow_end, window_scroll_pixel_based)
3902 (displayed_window_lines, Frecenter): Save and restore the bidi
3903 cache around display iteration.
3905 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3907 * editfns.c (Fdelete_region): Clarify the use of the named
3908 parameters (bug#6788).
3910 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3912 * indent.c (Fvertical_motion): Set and restore w->pointm when
3913 saving and restoring the window's buffer (Bug#9006).
3915 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3917 * editfns.c (Fstring_to_char): Clarify just what is returned
3918 (bug#6576). Text by Eli Zaretskii.
3920 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3922 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3924 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3926 * buffer.c (mmap_find): Fix a typo.
3928 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3930 Fix execution of x selection hooks.
3931 * xselect.c (Qx_lost_selection_functions)
3932 (Qx_sent_selection_functions): New vars.
3933 (syms_of_xselect): DEFSYM them.
3934 (x_handle_selection_request): Pass Qx_sent_selection_functions
3935 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3936 (x_handle_selection_clear,x_clear_frame_selections):
3937 Pass Qx_lost_selection_functions rather than
3938 Vx_lost_selection_functions to Frun_hook_with_args.
3940 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3942 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3943 The old code sometimes used this field without initializing it.
3945 * alloc.c (gc_sweep): Don't read past end of array.
3946 In theory, the old code could also have corrupted Emacs internals,
3947 though it'd be very unlikely.
3949 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3951 * character.c (Fcharacterp): Don't advertise optional ignored
3952 argument. (Bug#4026)
3954 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3956 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3959 * window.c (Fset_window_start): Doc fix (bug#4199).
3960 (Fset_window_hscroll): Ditto.
3962 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3964 Fix minor new problems caught by GCC 4.6.1.
3965 * term.c (init_tty): Remove unused local.
3966 * xsettings.c (store_monospaced_changed): Define this function only
3967 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3970 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3972 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3974 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3976 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3977 are the mini-buffer and the echo area (bug#3320).
3979 * term.c (init_tty): Remove support for supdup, c10 and perq
3980 terminals, which are no longer supported (bug#1482).
3982 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3984 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3986 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3988 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3989 for non-popups (Bug#3642).
3991 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3993 * alloc.c (reset_malloc_hooks): Protoize.
3994 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3995 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3996 * cm.c (losecursor): Likewise.
3997 * data.c (fmod): Likewise.
3998 * dispnew.c (swap_glyphs_in_rows): Likewise.
3999 * emacs.c (memory_warning_signal): Likewise.
4000 * floatfns.c (float_error): Likewise.
4001 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4002 (otf_open, font_otf_capability, generate_otf_features)
4003 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4005 * image.c (pbm_read_file): Likewise.
4006 * indent.c (string_display_width): Likewise.
4007 * intervals.c (check_for_interval, search_for_interval)
4008 (inc_interval_count, count_intervals, root_interval)
4009 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4010 * lread.c (defalias): Likewise.
4011 * ralloc.c (r_alloc_check): Likewise.
4012 * regex.c (set_image_of_range_1, set_image_of_range)
4013 (regex_grow_registers): Likewise.
4014 * sysdep.c (strerror): Likewise.
4015 * termcap.c (valid_filename_p, tprint, main): Likewise.
4016 * tparam.c (main): Likewise.
4017 * unexhp9k800.c (run_time_remap, save_data_space)
4018 (update_file_ptrs, read_header, write_header, calculate_checksum)
4019 (copy_file, copy_rest, display_header): Likewise.
4020 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4022 * xdisp.c (check_it): Likewise.
4023 * xfaces.c (register_color, unregister_color, unregister_colors):
4025 * xfns.c (print_fontset_result): Likewise.
4026 * xrdb.c (member, fatal, main): Likewise.
4028 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4030 Fix minor problems found by static checking (Bug#9031).
4031 * chartab.c (char_table_set_range, map_sub_char_table):
4032 Remove unused locals.
4033 (uniprop_table): Now static.
4034 * composite.c (_work_char): Remove unused static var.
4036 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4038 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4040 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4042 * gtkutil.c (qttip_cb): Remove code without function.
4044 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4046 * w32.c (pthread_sigmask): New stub.
4048 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4050 Use pthread_sigmask, not sigprocmask (Bug#9010).
4051 sigprocmask is portable only for single-threaded applications, and
4052 Emacs can be multi-threaded when it uses GTK.
4053 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4055 * callproc.c (Fcall_process):
4056 * process.c (create_process):
4057 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4058 Use pthread_sigmask, not sigprocmask.
4060 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4062 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4063 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4066 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4068 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4069 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4070 (xg_hide_tooltip): Fix comment.
4072 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4073 in registerServicesMenuSendTypes.
4074 (validRequestorForSendType): Don't check ns_return_types.
4076 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4079 2011-07-08 Jason Rumney <jasonr@gnu.org>
4081 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4082 SH_SHOW for hidden windows (Bug#5482).
4084 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4085 frame struct members of non-existent frames (Bug#6284).
4087 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4089 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4090 variable firstTime not needed on OSX >= 10.6.
4091 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4092 >= 10.5. Use setKnobProportion, setDoubleValue.
4094 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4095 (MAC_OS_X_VERSION_10_5): Define if not defined.
4096 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4097 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4098 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4100 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4101 cString and lossyCString on OSX >= 10.4
4103 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4104 sizeToFit on OSX >= 10.2.
4106 * nsimage.m (allocInitFromFile): Don't use deprecated method
4107 bestRepresentationForDevice on OSX >= 10.6.
4109 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4112 * emacs.c: Declare unexec_init_emacs_zone.
4114 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4116 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4118 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4119 on svcsMenu (Bug#8842).
4121 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4123 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4125 * nsterm.m (QUTF8_STRING): Declare.
4126 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4127 (validRequestorForSendType): Return type is (id).
4128 Change indexOfObjectIdenticalTo to indexOfObject.
4129 Check if we have local selection before returning self (Bug#8842).
4130 (writeSelectionToPasteboard): Put local selection into paste board
4131 if we have a local selection (Bug#8842).
4132 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4134 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4135 (ns_get_local_selection): Declare.
4137 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4139 * keymap.c (describe_map_tree): Don't insert a double newline at
4140 the end of the buffer (bug#1169) and return whether we inserted
4143 * callint.c (Fcall_interactively): Change "reading args" to
4144 "providing args" to try to clarify what it does (bug#1010).
4146 2011-07-07 Kenichi Handa <handa@m17n.org>
4148 * composite.c (composition_compute_stop_pos): Ignore a static
4149 composition starting before CHARPOS (Bug#8915).
4151 * xdisp.c (handle_composition_prop): Likewise.
4153 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4155 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4158 2011-07-07 Kenichi Handa <handa@m17n.org>
4160 * character.h (unicode_category_t): New enum type.
4162 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4163 (Qchar_code_property_table): New variable.
4164 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4165 (UNIPROP_COMPRESSED_FORM_P): New macros.
4166 (char_table_ascii): Uncompress the compressed values.
4167 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4168 Uncompress the compressed values.
4169 (sub_char_table_ref_and_range): Likewise.
4170 (char_table_ref_and_range): Uncompress the compressed values.
4171 (sub_char_table_set): New arg is_uniprop. Callers changed.
4172 Uncompress the compressed values.
4173 (sub_char_table_set_range): Args changed. Callers changed.
4174 (char_table_set_range): Adjuted for the above change.
4175 (map_sub_char_table): Delete args default_val and parent. Add arg
4176 top. Give decoded values to a Lisp function.
4177 (map_char_table): Adjust for the above change. Give decoded
4178 values to a Lisp function. Gcpro more variables.
4179 (uniprop_table_uncompress)
4180 (uniprop_decode_value_run_length): New functions.
4181 (uniprop_decoder, uniprop_decoder_count): New variables.
4182 (uniprop_get_decoder, uniprop_encode_value_character)
4183 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4185 (uniprop_encoder, uniprop_encoder_count): New variables.
4186 (uniprop_get_encoder, uniprop_table)
4187 (Funicode_property_table_internal, Fget_unicode_property_internal)
4188 (Fput_unicode_property_internal): New functions.
4189 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4190 Sunicode_property_table_internal, Sget_unicode_property_internal,
4191 and Sput_unicode_property_internal. Defvar_lisp
4192 char-code-property-alist.
4194 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4195 Vunicode_category_table.
4197 * font.c (font_range): Adjust for the change of
4198 Vunicode_category_table.
4200 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4202 * m/iris4d.h: Remove file, move contents ...
4203 * s/irix6-5.h: ... here.
4205 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4207 Remove unportable assumption about struct layout (Bug#8884).
4208 * alloc.c (mark_buffer):
4209 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4210 (clone_per_buffer_values): Don't assume that
4211 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4212 This isn't true in general, and it's particularly not true
4213 if Emacs is configured with --with-wide-int.
4214 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4215 New macros, used in the buffer.c change.
4217 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4219 * xsettings.c: Use both GConf and GSettings if both are available.
4220 (store_config_changed_event): Add comment.
4221 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4222 (store_tool_bar_style_changed): New functions.
4223 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4224 (struct xsettings): Move font inside HAVE_XFT.
4225 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4226 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4227 Move inside HAVE_XFT.
4228 (something_changed_gsettingsCB): Rename from something_changedCB.
4229 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4231 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4232 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4233 (something_changed_gconfCB): Rename from something_changedCB.
4234 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4235 (parse_settings): Move check for font inside HAVE_XFT.
4236 (read_settings, apply_xft_settings): Add comment.
4237 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4238 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4239 call store_font_name_changed.
4240 (xft_settings_event): Add comment.
4241 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4242 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4243 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4244 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4245 (xsettings_initialize): Call init_gsettings last.
4246 (xsettings_get_system_font, xsettings_get_system_normal_font):
4249 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4251 Random fixes. E.g., (random) never returned negative values.
4252 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4253 subseconds part to the entropy, as that's a bit more random.
4254 Prefer signed to unsigned, since the signedness doesn't matter and
4255 in general we prefer signed. When given a limit, use a
4256 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4257 latter isn't right if USE_2_TAGS_FOR_INTS.
4258 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4259 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4261 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4263 * textprop.c (text_property_stickiness):
4264 Obey Vtext_property_default_nonsticky.
4265 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4266 * w32fns.c (syms_of_w32fns):
4267 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4269 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4271 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4272 This is more efficient than Ffile_directory_p and avoids a minor race.
4274 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4276 * buffer.c (Foverlay_put): Say what the return value is
4279 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4280 is a directory before asking whether to use the file name
4282 (barf_or_query_if_file_exists): Make the "File is a directory"
4283 error be more correct.
4285 * fns.c (Frequire): Remove the mention of the .gz files, since
4286 that's installation-specific, but keep the mention of
4287 `get-load-suffixes'.
4289 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4291 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4292 Report string overflow if the output is too long.
4294 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4296 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4297 (syms_of_gnutls): Remove duplicate DEFSYM for
4298 Qgnutls_bootprop_verify_hostname_error, an error for
4299 Qgnutls_bootprop_verify_error (which is no longer used).
4301 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4302 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4303 Also (re)move comments that are misplaced or no longer relevant.
4305 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4307 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4309 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4311 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4312 and background color parameters if they have been changed.
4314 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4316 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4318 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4320 * xsettings.c (SYSTEM_FONT): Define only when used.
4321 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4323 * keymap.c (access_keymap_1): Now static.
4325 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4327 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4328 leave any prefix arg for the up event (Bug#1586).
4330 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4332 * lread.c (syms_of_lread): Mention single symbols defined by
4333 `defvar' or `defconst' (bug#7154).
4335 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4336 (Frequire): Mention get-load-suffixes.
4338 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4340 * window.h (window): Remove clone_number slot.
4341 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4343 (make_parent_window, make_window, saved_window)
4344 (Fset_window_configuration, save_window_save): Don't deal with
4346 * buffer.c (Qclone_number): Remove declaration.
4347 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4349 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4351 Add multiple inheritance to keymaps.
4352 * keymap.c (Fmake_composed_keymap): New function.
4353 (Fset_keymap_parent): Simplify.
4354 (fix_submap_inheritance): Remove.
4355 (access_keymap_1): New function extracted from access_keymap to handle
4356 embedded parents and handle lists of maps.
4357 (access_keymap): Use it.
4358 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4359 (Fcopy_keymap): Handle embedded parents.
4360 (Fcommand_remapping, define_as_prefix): Simplify.
4361 (Fkey_binding): Simplify.
4362 (syms_of_keymap): Move minibuffer-local-completion-map,
4363 minibuffer-local-filename-completion-map,
4364 minibuffer-local-must-match-map, and
4365 minibuffer-local-filename-must-match-map to Elisp.
4366 (syms_of_keymap): Defsubr make-composed-keymap.
4367 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4368 (parse_menu_item): Trivial simplification.
4370 2011-07-01 Glenn Morris <rgm@gnu.org>
4372 * Makefile.in (SETTINGS_LIBS): Fix typo.
4374 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4376 * coding.c (Fencode_coding_string): Record the last coding system
4377 used, as the function doc string says (bug#8738).
4379 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4381 * xsettings.c (store_monospaced_changed): Take new font as arg and
4382 check for change against current_mono_font.
4383 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4384 (emacs_settings_constructor, emacs_settings_get_property)
4385 (emacs_settings_set_property, emacs_settings_class_init)
4386 (emacs_settings_init, gsettings_obj): Remove.
4387 (something_changedCB): New function for HAVE_GSETTINGS.
4388 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4389 with value as argument.
4390 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4391 g_settings_new (Bug#8967). Do not create gsettings_obj.
4392 Remove calls to g_settings_bind. Connect something_changedCB to
4395 * xgselect.c: Add defined (HAVE_GSETTINGS).
4396 (xgselect_initialize): Ditto.
4398 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4399 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4402 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4404 * eval.c (struct backtrace): Simplify and port the data structure.
4405 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4406 signed bit field, as this assumption is not portable and it makes
4407 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4408 "char debug_on_exit : 1" as this is not portable either; instead,
4409 use the portable "unsigned int debug_on_exit : 1". Remove unused
4410 member evalargs. Remove obsolete comments about cc bombing out.
4412 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4414 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4415 Let HAVE_GSETTINGS override HAVE_GCONF.
4416 (store_monospaced_changed): New function.
4417 (EMACS_SETTINGS): A new type derived from GObject to handle
4418 GSettings notifications.
4419 (emacs_settings_constructor, emacs_settings_get_property)
4420 (emacs_settings_set_property, emacs_settings_class_init):
4422 (gsettings_client, gsettings_obj): New variables.
4423 (GSETTINGS_SCHEMA): New define.
4424 (something_changedCB): Call store_monospaced_changed.
4425 (init_gsettings): New function.
4426 (xsettings_initialize): Call init_gsettings.
4427 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4430 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4433 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4435 * window.c (resize_root_window, grow_mini_window)
4436 (shrink_mini_window): Rename Qresize_root_window to
4437 Qwindow_resize_root_window and Qresize_root_window_vertically to
4438 Qwindow_resize_root_window_vertically.
4440 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4442 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4444 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4446 * makefile.w32-in: Redesign dependencies so they reflect more
4447 clearly which files are directly included by each source file,
4448 and not through other includes.
4450 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4452 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4453 (sort_overlays, overlay_strings): When an overlay's clone number
4454 matches the window's clone number process the overlay even if
4455 the overlay's window property doesn't match the current window.
4457 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4458 (Fwindow_hchild): Rename to Fwindow_left_child.
4459 (Fwindow_next): Rename to Fwindow_next_sibling.
4460 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4461 (resize_window_check): Rename to window_resize_check.
4462 (resize_window_apply): Rename to window_resize_apply.
4463 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4464 (Fdelete_other_windows_internal, resize_frame_windows)
4465 (Fsplit_window_internal, Fdelete_window_internal)
4466 (grow_mini_window, shrink_mini_window)
4467 (Fresize_mini_window_internal): Fix callers accordingly.
4469 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4471 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4472 (emacs_fixed_set_min_size): Remove.
4473 (emacs_fixed_new): Take frame as argument.
4475 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4476 (_EmacsFixedPrivate): Remove minwidth/height.
4477 Add struct frame *f.
4478 (emacs_fixed_init): Initialize priv->f.
4479 (get_parent_class, emacs_fixed_set_min_size): Remove.
4480 (emacs_fixed_new): Set priv->f to argument.
4481 (emacs_fixed_get_preferred_width)
4482 (emacs_fixed_get_preferred_height): Use min_width/height from
4483 frames size_hint to set minimum and natural (Bug#8919).
4484 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4485 and use min_width/height from frames size_hint to set
4486 min_width/height (Bug#8919).
4488 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4489 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4492 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4494 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4495 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4498 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4500 * process.c (wait_reading_process_output): Bypass select if
4501 waiting for a cell while ignoring keyboard input, and input is
4502 pending. Suggested by Jan Djärv (Bug#8869).
4504 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4506 Use gnulib's dup2 module instead of rolling our own.
4507 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4509 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4511 * dispnew.c (scrolling_window): Before scrolling, turn off a
4512 mouse-highlight in the window being scrolled.
4514 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4516 Move DEFSYM to lisp.h and use everywhere.
4518 * character.h (DEFSYM): Move declaration...
4519 * lisp.h (DEFSYM): ...here.
4525 * w32select.c: Don't include character.h.
4527 * alloc.c (syms_of_alloc):
4528 * buffer.c (syms_of_buffer):
4529 * bytecode.c (syms_of_bytecode):
4530 * callint.c (syms_of_callint):
4531 * casefiddle.c (syms_of_casefiddle):
4532 * casetab.c (init_casetab_once):
4533 * category.c (init_category_once, syms_of_category):
4534 * ccl.c (syms_of_ccl):
4535 * cmds.c (syms_of_cmds):
4536 * composite.c (syms_of_composite):
4537 * dbusbind.c (syms_of_dbusbind):
4538 * dired.c (syms_of_dired):
4539 * dispnew.c (syms_of_display):
4540 * doc.c (syms_of_doc):
4541 * editfns.c (syms_of_editfns):
4542 * emacs.c (syms_of_emacs):
4543 * eval.c (syms_of_eval):
4544 * fileio.c (syms_of_fileio):
4545 * fns.c (syms_of_fns):
4546 * frame.c (syms_of_frame):
4547 * fringe.c (syms_of_fringe):
4548 * insdel.c (syms_of_insdel):
4549 * keymap.c (syms_of_keymap):
4550 * lread.c (init_obarray, syms_of_lread):
4551 * macros.c (syms_of_macros):
4552 * msdos.c (syms_of_msdos):
4553 * print.c (syms_of_print):
4554 * process.c (syms_of_process):
4555 * search.c (syms_of_search):
4556 * sound.c (syms_of_sound):
4557 * syntax.c (init_syntax_once, syms_of_syntax):
4558 * terminal.c (syms_of_terminal):
4559 * textprop.c (syms_of_textprop):
4560 * undo.c (syms_of_undo):
4561 * w32.c (globals_of_w32):
4562 * window.c (syms_of_window):
4563 * xdisp.c (syms_of_xdisp):
4564 * xfaces.c (syms_of_xfaces):
4565 * xfns.c (syms_of_xfns):
4566 * xmenu.c (syms_of_xmenu):
4567 * xsettings.c (syms_of_xsettings):
4568 * xterm.c (syms_of_xterm): Use DEFSYM.
4570 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4572 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4574 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4576 Integer and buffer overflow fixes (Bug#8873).
4578 * print.c (printchar, strout): Check for string overflow.
4579 (PRINTPREPARE, printchar, strout):
4580 Don't set size unless allocation succeeds.
4582 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4583 for sizes. Check for string overflow more accurately.
4584 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4586 * macros.c: Integer and buffer overflow fixes.
4587 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4588 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4589 Use ptrdiff_t, not int, for sizes.
4590 Don't increment bufsize until after realloc succeeds.
4591 Check for size-calculation overflow.
4592 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4594 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4596 * lread.c: Integer overflow fixes.
4597 (read_integer): Radix is now EMACS_INT, not int,
4598 to improve quality of diagnostics for out-of-range radices.
4599 Calculate buffer size correctly for out-of-range radices.
4600 (read1): Check for integer overflow in radices, and in
4601 read-circle numbers.
4602 (read_escape): Avoid int overflow.
4603 (Fload, openp, read_buffer_size, read1)
4604 (substitute_object_recurse, read_vector, read_list, map_obarray):
4605 Use ptrdiff_t, not int, for sizes.
4606 (read1): Use EMACS_INT, not int, for sizes.
4607 Check for size overflow.
4609 * image.c (cache_image): Check for size arithmetic overflow.
4611 * lread.c: Integer overflow issues.
4612 (saved_doc_string_size, saved_doc_string_length)
4613 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4614 Now ptrdiff_t, not int.
4615 (read1): Don't assume doc string length fits in int. Check for
4616 out-of-range doc string lengths.
4617 (read_list): Don't assume file position fits in int.
4618 (read_escape): Check for hex character overflow.
4620 2011-06-22 Leo Liu <sdl.web@gmail.com>
4622 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4623 Move to minibuffer.el.
4625 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4627 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4628 The following patches are for when GLYPH_DEBUG && !XASSERT.
4629 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4630 * dispnew.c (flush_stdout):
4631 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4632 Mark as externally visible.
4633 * dispnew.c (check_window_matrix_pointers): Now static.
4634 * dispnew.c (window_to_frame_vpos):
4635 * xfns.c (unwind_create_frame):
4636 * xterm.c (x_check_font): Remove unused local.
4637 * scroll.c (CHECK_BOUNDS):
4638 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4639 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4640 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4641 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4642 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4644 (debug_method_add): Use va_list and vsprintf rather than relying
4645 on undefined behavior with wrong number of arguments.
4646 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4647 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4648 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4649 since we're not interested in debugging glyphs with old libraries.
4650 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4651 GCC 4.6.0's static checking.
4653 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4655 Integer overflow and signedness fixes (Bug#8873).
4656 A few related buffer overrun fixes, too.
4658 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4660 * dispextern.h (struct face.stipple):
4661 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4662 (x_bitmap_mask, x_allocate_bitmap_record)
4663 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4664 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4665 (x_create_bitmap_from_xpm_data):
4666 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4667 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4669 * xfaces.c (load_pixmap):
4670 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4671 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4672 (.bitmaps_last, struct x_output.icon_bitmap):
4673 Use ptrdiff_t, not int, for bitmap indexes.
4674 (x_allocate_bitmap_record): Check for size overflow.
4675 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4677 Use ptrdiff_t, not int, for overlay counts.
4678 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4679 * editfns.c (overlays_around, get_pos_property):
4680 * textprop.c (get_char_property_and_overlay):
4681 * xdisp.c (next_overlay_change, note_mouse_highlight):
4682 * xfaces.c (face_at_buffer_position):
4683 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4684 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4685 (Fnext_overlay_change, Fprevious_overlay_change)
4686 (mouse_face_overlay_overlaps, Foverlays_in):
4687 Use ptrdiff_t, not int, for sizes.
4688 (overlays_at, overlays_in): Check for size-calculation overflow.
4690 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4692 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4693 (x_session_initialize): Do not assume string length fits in int.
4695 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4696 This is unlikely, but can occur if DPI is outlandish.
4698 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4699 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4701 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4702 * xrdb.c (magic_file_p, search_magic_path):
4703 Omit last arg SUFFIX; it was always 0. All callers changed.
4704 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4706 * xfont.c (xfont_match): Avoid need for strlen.
4708 * xfns.c: Don't assume strlen fits in int.
4709 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4711 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4712 not unsigned long, as we prefer signed integers. All callers changed.
4713 Detect integer overflow in repeat count.
4714 (message_dolog): Don't assume print length fits in 39 bytes.
4715 (display_mode_element): Don't assume strlen fits in int.
4717 * termcap.c: Don't assume sizes fit in int and never overflow.
4718 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4719 (gobble_line): Check for size-calculation overflow.
4721 * minibuf.c (Fread_buffer):
4722 * lread.c (intern, intern_c_string):
4723 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4724 Don't assume string length fits in int.
4726 * keyboard.c (parse_tool_bar_item):
4727 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4729 * font.c: Don't assume string length fits in int.
4730 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4731 Use ptrdiff_t, not int.
4732 (font_intern_prop): Don't assume string length fits in int.
4733 Don't assume integer property fits in fixnum.
4734 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4736 * filelock.c: Fix some buffer overrun and integer overflow issues.
4737 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4738 Reformulate so as not to need the command string.
4739 Invoke gzip -cd rather than gunzip, as it's more portable.
4740 (lock_info_type, lock_file_1, lock_file):
4741 Don't assume pid_t and time_t fit in unsigned long.
4742 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4743 (current_lock_owner): Prefer signed type for sizes.
4744 Use memcpy, not strncpy, where memcpy is what is really wanted.
4745 Don't assume (via atoi) that time_t and pid_t fit in int.
4746 Check for time_t and/or pid_t out of range, e.g., via a network share.
4747 Don't alloca where an auto var works fine.
4749 * fileio.c: Fix some integer overflow issues.
4750 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4751 Don't assume string length fits in int.
4752 (directory_file_name): Don't assume string length fits in long.
4753 (make_temp_name): Don't assume pid fits in int, or that its print
4754 length is less than 20.
4756 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4758 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4760 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4762 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4763 We prefer signed integers, even for size calculations.
4765 * emacs.c: Don't assume string length fits in 'int'.
4766 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4767 (main): Don't invoke strlen when not needed.
4769 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4770 (XD_DEBUG_MESSAGE): Don't waste a byte.
4772 * callproc.c (getenv_internal_1, getenv_internal)
4774 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4776 * lread.c (invalid_syntax): Omit length argument.
4777 All uses changed. This doesn't fix a bug, but it simplifies the
4778 code away from its former Hollerith-constant appearance, and it's
4779 one less 'int' to worry about when looking at integer-overflow issues.
4780 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4782 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4783 This didn't break anything, but it didn't help either.
4784 It's confusing to put a bogus integer in a place where the actual
4785 value does not matter.
4786 (LIST_END_P): Remove unused macro and its bogus comment.
4787 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4789 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4790 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4792 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4793 We prefer signed types, and the value cannot exceed the EMACS_INT
4794 range anyway (because otherwise the length would not be representable).
4795 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4796 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4797 This avoids a GCC warning when WIDE_EMACS_INT.
4799 * indent.c (sane_tab_width): New function.
4800 (current_column, scan_for_column, Findent_to, position_indentation)
4801 (compute_motion): Use it. This is just for clarity.
4802 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4804 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4806 * lisp.h (lint_assume): New macro.
4807 * composite.c (composition_gstring_put_cache):
4808 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4810 * editfns.c, insdel.c:
4811 Omit unnecessary forward decls, to simplify future changes.
4813 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4815 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4817 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4818 Use much-faster test for byte-length change.
4819 Don't assume string byte-length fits in 'int'.
4820 Check that character arg fits in 'int'.
4821 (mapcar1): Declare byte as byte, for clarity.
4823 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4825 * fns.c (concat): Catch string overflow earlier.
4826 Do not rely on integer wraparound.
4828 * dispextern.h (struct it.overlay_strings_charpos)
4829 (struct it.selective): Now EMACS_INT, not int.
4830 * xdisp.c (forward_to_next_line_start)
4831 (back_to_previous_visible_line_start)
4832 (reseat_at_next_visible_line_start, next_element_from_buffer):
4833 Don't arbitrarily truncate the value of 'selective' to int.
4835 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4837 * composite.c: Don't truncate sizes to 'int'.
4838 (composition_gstring_p, composition_reseat_it)
4839 (composition_adjust_point): Use EMACS_INT, not int.
4840 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4841 not EMACS_UINT, for indexes.
4843 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4845 * buffer.c: Include <verify.h>.
4846 (struct sortvec.priority, struct sortstr.priority):
4847 Now EMACS_INT, not int.
4848 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4849 (struct sortstr.size, record_overlay_string)
4850 (struct sortstrlist.size, struct sortlist.used):
4851 Don't truncate size to int.
4852 (record_overlay_string): Check for size-calculation overflow.
4853 (init_buffer_once): Check at compile-time, not run-time.
4855 2011-06-22 Jim Meyering <meyering@redhat.com>
4857 Don't leak an XBM-image-sized buffer
4858 * image.c (xbm_load): Free the image buffer after using it.
4860 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4863 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4864 that Sun C diagnosed.
4865 * fns.c (secure_hash): Fix pointer signedness issue.
4866 * intervals.c (static_offset_intervals): New function.
4867 (offset_intervals): Use it.
4869 2011-06-21 Leo Liu <sdl.web@gmail.com>
4872 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4875 * fns.c (secure_hash): Rename from crypto_hash_function and change
4876 the first arg to accept symbols.
4877 (Fsecure_hash): New primitive.
4878 (syms_of_fns): New symbols.
4880 2011-06-20 Deniz Dogan <deniz@dogan.se>
4882 * process.c (Fset_process_buffer): Clarify return value in
4885 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4887 * dispnew.c (add_window_display_history): Use BVAR.
4889 * xdisp.c (debug_method_add): Use BVAR.
4890 (check_window_end, dump_glyph_matrix, dump_glyph)
4891 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4893 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4896 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4897 check till after the cache is created in init_frame_faces.
4899 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4901 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4903 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4905 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4906 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4907 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4909 Improve buffer-overflow checking (Bug#8873).
4910 * fileio.c (Finsert_file_contents):
4911 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4912 Remove the old (too-loose) buffer overflow checks.
4913 They weren't needed, since make_gap checks for buffer overflow.
4914 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4915 The old code merely checked for Emacs fixnum overflow, and relied
4916 on undefined (wraparound) behavior. The new code avoids undefined
4917 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4919 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4920 Tune. Don't use wider integers than needed. Don't use alloca.
4921 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4923 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4925 * insdel.c, lisp.h (buffer_overflow): New function.
4926 (insert_from_buffer_1, replace_range, replace_range_2):
4927 * insdel.c (make_gap_larger):
4928 * editfns.c (Finsert_char):
4929 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4931 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4933 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4935 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4937 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4938 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4940 * fileio.c: Don't assume EMACS_INT fits in off_t.
4941 (emacs_lseek): New static function.
4942 (Finsert_file_contents, Fwrite_region): Use it.
4943 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4945 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4947 * fns.c: Don't overflow int when computing a list length.
4948 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4949 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4950 truncation on 64-bit hosts. Check for QUIT every
4951 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4952 faster and is responsive enough.
4953 (Flength): Report an error instead of overflowing an integer.
4954 (Fsafe_length): Return a float if the value is not representable
4955 as a fixnum. This shouldn't happen except in contrived situations.
4956 (Fnthcdr, Fsort): Don't assume list length fits in int.
4957 (Fcopy_sequence): Don't assume vector length fits in int.
4959 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4960 (header_size, word_size): New constants.
4961 (allocate_vectorlike): Don't check size overflow here.
4962 (allocate_vector): Check it here instead, since this is the only
4963 caller of allocate_vectorlike that could cause overflow.
4964 Check that the new vector's length is representable as a fixnum.
4966 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4967 The previous code was bogus. For example, next_almost_prime (32)
4968 returned 39, which is undesirable as it is a multiple of 3; and
4969 next_almost_prime (24) returned 25, which is a multiple of 5 so
4970 why was the code bothering to check for multiples of 7?
4972 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4974 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4976 Variadic C functions now count arguments with ptrdiff_t.
4977 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4978 Back then I didn't know that the Emacs coding style prefers signed int.
4979 Also, in the meantime I found a few more instances where arguments
4980 were being counted with int, which may truncate counts on 64-bit
4981 machines, or EMACS_INT, which may be unnecessarily wide.
4982 * lisp.h (struct Lisp_Subr.function.aMANY)
4983 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4984 Arg counts are now ptrdiff_t, not size_t.
4985 All variadic functions and their callers changed accordingly.
4986 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4987 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4988 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4989 * callint.c (Fcall_interactively): Check arg count for overflow,
4990 to avoid potential buffer overrun. Use signed char, not 'int',
4991 for 'varies' array, so that we needn't bother to check its size
4992 calculation for overflow.
4993 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4994 * eval.c (apply_lambda):
4995 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4996 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4997 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4999 * callint.c (Fcall_interactively): Don't use index var as event count.
5001 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5002 * mem-limits.h (SIZE): Remove; no longer used.
5004 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5006 Remove unnecessary casts.
5007 * xterm.c (x_term_init):
5008 * xfns.c (x_set_border_pixel):
5009 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5010 These aren't needed now that we assume ANSI C.
5012 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5013 It's more likely to cause problems (due to unsigned overflow)
5016 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5018 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5020 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5022 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5024 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5026 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5028 GLYPH_CODE_FACE returns EMACS_INT, not int.
5029 * dispextern.h (merge_faces):
5030 * xfaces.c (merge_faces):
5031 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5032 Don't assume EMACS_INT fits in int.
5034 * character.h (CHAR_VALID_P): Remove unused parameter.
5035 * fontset.c, lisp.h, xdisp.c: All uses changed.
5037 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5039 * fns.c (concat): Minor tuning based on overflow analysis.
5040 This doesn't fix any bugs. Use int to hold character, instead
5041 of constantly refetching from Emacs object. Use XFASTINT, not
5042 XINT, for value known to be a character. Don't bother comparing
5043 a single byte to 0400, as it's always less.
5045 * floatfns.c (Fexpt):
5046 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5048 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5051 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5053 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5054 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5055 incorrectly succeed when S was a string, because 4294967386 was
5056 truncated before it was used.
5058 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5059 Otherwise, an out-of-range integer could cause undefined behavior
5062 * composite.c: Use int, not EMACS_INT, for characters.
5063 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5064 EMACS_INT, for values that are known to be in character range.
5065 This doesn't fix any bugs but is the usual style inside Emacs and
5066 may generate better code on 32-bit machines.
5068 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5069 This is for reasons similar to the recent CHAR_STRING fix.
5070 * charset.c (Fencode_char): Check that character arg is actually
5071 a character. Pass an int to ENCODE_CHAR.
5072 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5073 wider than 'int', as a compile-time check to prevent future regressions
5076 * character.c (char_string): Remove unnecessary casts.
5078 Make sure a 64-bit char is never passed to CHAR_STRING.
5079 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5080 by silently ignoring the top 32 bits, allowing some values
5081 that were far too large to be valid characters.
5082 * character.h: Include <verify.h>.
5083 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5084 arguments are no wider than unsigned, as a compile-time check
5085 to prevent future regressions in this area.
5087 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5088 (Fsubst_char_in_region):
5090 * xdisp.c (decode_mode_spec_coding):
5091 Adjust to CHAR_STRING's new requirement.
5092 * editfns.c (Finsert_char, Fsubst_char_in_region):
5093 * fns.c (concat): Check that character args are actually
5094 characters. Without this test, these functions did the wrong
5095 thing with wildly out-of-range values on 64-bit hosts.
5097 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5098 These casts should not be needed on 32-bit hosts, either.
5099 * keyboard.c (read_char):
5100 * lread.c (Fload): Remove casts to unsigned.
5102 * lisp.h (UNSIGNED_CMP): New macro.
5103 This fixes comparison bugs on 64-bit hosts.
5104 (ASCII_CHAR_P): Use it.
5105 * casefiddle.c (casify_object):
5106 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5107 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5108 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5109 * dispextern.h (FACE_FROM_ID):
5110 * keyboard.c (read_char): Use UNSIGNED_CMP.
5112 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5113 not to EMACS_INT, to avoid GCC warning.
5115 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5117 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5118 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5119 isn't needed on 32-bit machines.
5121 * buffer.c (Fgenerate_new_buffer_name):
5122 Use EMACS_INT for count, not int.
5123 (advance_to_char_boundary): Return EMACS_INT, not int.
5125 * data.c (Qcompiled_function): Now static.
5127 * window.c (window_body_lines): Now static.
5129 * image.c (gif_load): Rename local to avoid shadowing.
5131 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5132 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5133 * alloc.c (make_save_value): Integer argument is now of type
5135 (mark_object): Use ptrdiff_t, not int.
5136 * lisp.h (pD): New macro.
5137 * print.c (print_object): Use it.
5139 * alloc.c: Use EMACS_INT, not int, to count objects.
5140 (total_conses, total_markers, total_symbols, total_vector_size)
5141 (total_free_conses, total_free_markers, total_free_symbols)
5142 (total_free_floats, total_floats, total_free_intervals)
5143 (total_intervals, total_strings, total_free_strings):
5144 Now EMACS_INT, not int. All uses changed.
5145 (Fgarbage_collect): Compute overall total using a double, so that
5146 integer overflow is less likely to be a problem. Check for overflow
5147 when converting back to an integer.
5148 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5149 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5150 These were 'int' variables that could overflow on 64-bit hosts;
5151 they were never used, so remove them instead of repairing them.
5152 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5153 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5154 Previously, this ceilinged at INT_MAX, but that doesn't work on
5156 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5158 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5159 (allocate_vectorlike): Check for ptrdiff_t overflow.
5160 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5161 when a (possibly-narrower) signed value would do just as well.
5162 We prefer using signed arithmetic, to avoid comparison confusion.
5164 * alloc.c: Catch some string size overflows that we were missing.
5165 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5166 for convenience in STRING_BYTES_MAX.
5167 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5168 The definition here is exact; the one in lisp.h was approximate.
5169 (allocate_string_data): Check for string overflow. This catches
5170 some instances we weren't catching before. Also, it catches
5171 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5172 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5173 and ptrdiff_t and EMACS_INT are both 64 bits.
5175 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5176 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5177 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5179 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5181 * alloc.c (Fmake_string): Check for out-of-range init.
5183 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5185 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5187 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5189 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5190 xg_get_default_scrollbar_width.
5192 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5193 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5194 (style_changed_cb): Call update_theme_scrollbar_width and call
5195 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5196 all frames (Bug#8505).
5197 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5198 Call gtk_window_set_resizable if HAVE_GTK3.
5199 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5200 and height if HAVE_GTK3 (Bug#8505).
5201 (scroll_bar_width_for_theme): New variable.
5202 (update_theme_scrollbar_width): New function.
5203 (xg_get_default_scrollbar_width): Move code to
5204 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5205 (xg_initialize): Call update_theme_scrollbar_width.
5207 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5209 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5211 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5213 * frame.c (make_frame): Call other_buffer_safely instead of
5216 * window.c (temp_output_buffer_show): Call display_buffer with
5217 second argument Vtemp_buffer_show_specifiers and reset latter
5218 immediately after the call.
5219 (Vtemp_buffer_show_specifiers): New variable.
5220 (auto_window_vscroll_p, next_screen_context_lines)
5221 (Vscroll_preserve_screen_position): Remove leading asterisks from
5224 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5226 Fix minor problems found by GCC 4.6.0 static checking.
5227 * buffer.c (Qclone_number): Remove for now, as it's unused.
5228 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5229 (record_buffer): Remove unused local.
5230 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5231 (set_frame_buffer_list): Remove; unused.
5232 * frame.h (other_visible_frames): Remove decl.
5233 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5234 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5235 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5237 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5238 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5239 Define only if HAVE_GPM.
5240 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5241 (update_hints_inhibit): Remove; never set. All uses removed.
5242 * widgetprv.h (emacsFrameClassRec): Remove decl.
5243 * window.c (delete_deletable_window): Now returns void, since it
5244 wasn't returning anything.
5245 (compare_window_configurations): Remove unused locals.
5246 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5247 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5248 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5249 the same widths as pointers. This follows up on the 2011-05-06 patch.
5250 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5251 * xterm.h: Likewise.
5252 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5254 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5256 * makefile.w32-in: Update dependencies.
5257 (LISP_H): Add lib/intprops.h.
5259 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5261 * image.c (gif_load): Add animation frame delay to the metadata.
5262 (syms_of_image): Use DEFSYM. New symbol `delay'.
5264 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5266 * window.c (delete_deletable_window): Re-add.
5267 (Fset_window_configuration): Rewrite to handle dead buffers and
5268 consequently deletable windows.
5269 (window_tree, Fwindow_tree): Remove. Supply functionality in
5271 (compare_window_configurations): Simplify code.
5273 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5275 * image.c (imagemagick_load_image): Fix type mismatch.
5276 (Fimagemagick_types): Likewise.
5278 * window.h (replace_buffer_in_windows): Declare.
5280 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5282 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5283 Qclone_number. Remove external declaration of Qdelete_window.
5284 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5286 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5287 Run Qbuffer_list_update_hook if allowed.
5288 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5289 buffer list implementation.
5290 (other_buffer_safely): New function.
5291 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5292 calls to replace_buffer_in_windows and
5293 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5295 (record_buffer): Inhibit quitting and rewrite using quittable
5296 functions. Run Qbuffer_list_update_hook if allowed.
5297 (Frecord_buffer, Funrecord_buffer): New functions.
5298 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5299 Move switch-to-buffer to window.el.
5300 (bury-buffer): Move to window.el.
5301 (Vbuffer_list_update_hook): New variable.
5303 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5306 * window.h (resize_frame_windows): Move up in code.
5307 (Fwindow_frame): Remove EXFUN.
5308 (replace_buffer_in_all_windows): Remove prototype.
5309 (replace_buffer_in_windows_safely): Add prototype.
5311 * window.c: Declare Qdelete_window static again. Move down
5312 declaration of select_count.
5313 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5314 (Fother_window): Move to window.el.
5315 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5316 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5317 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5319 (replace_buffer_in_windows): Implement by calling
5320 Qreplace_buffer_in_windows.
5321 (replace_buffer_in_all_windows): Remove with some functionality
5322 moved into replace_buffer_in_windows_safely.
5323 (replace_buffer_in_windows_safely): New function.
5324 (select_window_norecord, select_frame_norecord): Move in front
5325 of run_window_configuration_change_hook. Remove now obsolete
5327 (Fset_window_buffer): Rewrite doc-string.
5328 Call Qrecord_window_buffer.
5329 (keys_of_window): Move binding for other-window to window.el.
5331 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5333 * dispextern.h (struct image): Replace data member, whose int_val
5334 and ptr_val fields were not used by anything, with a single
5337 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5338 (gif_clear_image, gif_load, imagemagick_load_image)
5339 (gs_clear_image, gs_load): Callers changed.
5341 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5343 * buffer.h: Include <time.h>, for time_t.
5344 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5346 Fix minor problems found by static checking.
5348 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5350 Make identifiers static if they are not used in other modules.
5351 * data.c (Qcompiled_function, Qframe, Qvector):
5352 * image.c (QimageMagick, Qsvg):
5353 * minibuf.c (Qmetadata):
5354 * window.c (resize_window_check, resize_root_window): Now static.
5355 * window.h (resize_window_check, resize_root_window): Remove decls.
5357 * window.c (window_deletion_count, delete_deletable_window):
5359 (window_body_lines): Now static.
5360 (Fdelete_other_windows_internal): Mark vars as initialized.
5361 Make sure 'resize_failed' is initialized.
5362 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5363 (resize_window_apply): Remove unused local.
5364 * window.h (delete_deletable_window): Remove decl.
5366 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5367 (imagemagick_load_image): Fix pointer signedness problem by changing
5368 last arg from unsigned char * to char *. All uses changed.
5369 Also, fix a local for similar reasons.
5370 Remove unused locals. Remove locals to avoid shadowing.
5371 (fn_rsvg_handle_free): Remove; unused.
5372 (svg_load, svg_load_image): Fix pointer signedness problem.
5373 (imagemagick_load_image): Don't use garbage pointer image_wand.
5375 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5377 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5379 * image.c (gif_load): Fix omitted cast error introduced by
5382 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5384 * window.h (resize_proportionally, orig_total_lines)
5385 (orig_top_line): Remove from window structure.
5386 (set_window_height, set_window_width, change_window_heights)
5387 (Fdelete_window): Remove prototypes.
5388 (resize_frame_windows): Remove duplicate declaration.
5390 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5392 * window.h (resize_frame_windows, resize_window_check)
5393 (delete_deletable_window, resize_root_window)
5394 (resize_frame_windows): Declare prototypes.
5396 * window.c (resize_window_apply): Make definition be "static" to
5397 match the prototype.
5399 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5401 * window.c: Remove declarations of Qwindow_size_fixed,
5402 window_min_size_1, window_min_size_2, window_min_size,
5403 size_window, window_fixed_size_p, enlarge_window, delete_window.
5404 Remove static from declaration of Qdelete_window, it's
5405 temporarily needed by Fbury_buffer.
5406 (replace_window): Don't assign orig_top_line and
5408 (Fdelete_window, delete_window): Remove. Window deletion is
5409 handled by window.el.
5410 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5411 Replace Fdelete_window calls with calls to Qdelete_window.
5412 (Fdelete_other_windows): Remove. Deleting other windows is
5413 handled by window.el.
5414 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5415 handled in window.el.
5416 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5417 Window minimum sizes are handled in window.el.
5418 (shrink_windows, size_window, set_window_height)
5419 (set_window_width, change_window_heights, window_height)
5420 (window_width, CURBEG, CURSIZE, enlarge_window)
5421 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5422 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5423 handled in window.el.
5424 (make_dummy_parent): Rename to make_parent_window and give it a
5425 second argument horflag.
5426 (make_window): Don't set resize_proportionally any more.
5427 (Fsplit_window): Remove. Windows are split in window.el.
5428 (save_restore_action, save_restore_orig_size)
5429 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5430 Resize mini windows in window.el.
5431 (grow_mini_window, shrink_mini_window): Implement by calling
5432 Qresize_root_window_vertically, resize_window_check and
5433 resize_window_apply.
5434 (saved_window, Fset_window_configuration, save_window_save):
5435 Do not handle orig_top_line, orig_total_lines, and
5436 resize_proportionally.
5437 (window_min_height, window_min_width): Move to window.el.
5438 (keys_of_window): Move bindings for delete-other-windows,
5439 split-window, delete-window and enlarge-window to window.el.
5441 * buffer.c: Temporarily extern Qdelete_window.
5442 (Fbury_buffer): Temporarily call Qdelete_window instead of
5443 Fdelete_window (Fbury_buffer will move to window.el soon).
5445 * frame.c (set_menu_bar_lines_1): Remove code handling
5446 orig_top_line and orig_total_lines.
5448 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5449 set_window_height but set heights directly.
5450 (change_frame_size_1): Use resize_frame_windows.
5452 * xdisp.c (init_xdisp): Don't use set_window_height but set
5455 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5456 Use resize_frame_windows instead of change_window_heights and run
5457 run_window_configuration_change_hook.
5459 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5460 instead of change_window_heights and run
5461 run_window_configuration_change_hook.
5463 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5465 * window.c (replace_window): Rename second argument REPLACEMENT to
5466 NEW. New third argument SETFLAG. Rewrite.
5467 (delete_window, make_dummy_parent): Call replace_window with
5469 (window_list_1): Move down in code.
5470 (run_window_configuration_change_hook): Move set_buffer part
5471 before select_frame_norecord part in order to unwind correctly.
5472 Rename count1 to count.
5473 (recombine_windows, delete_deletable_window, resize_root_window)
5474 (Fdelete_other_windows_internal)
5475 (Frun_window_configuration_change_hook, make_parent_window)
5476 (resize_window_check, resize_window_apply, Fresize_window_apply)
5477 (resize_frame_windows, Fsplit_window_internal)
5478 (Fdelete_window_internal, Fresize_mini_window_internal):
5480 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5482 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5484 * window.h (window): Add some new members to window structure -
5485 normal_lines, normal_cols, new_total, new_normal, clone_number,
5486 splits, nest, prev_buffers, next_buffers.
5487 (WINDOW_TOTAL_SIZE): Move here from window.c.
5488 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5490 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5492 (make_dummy_parent): Set new members of windows structure.
5493 (make_window): Move down in code. Handle new members of window
5495 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5496 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5497 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5498 (Fset_window_prev_buffers, Fwindow_next_buffers)
5499 (Fset_window_next_buffers, Fset_window_clone_number):
5501 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5502 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5504 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5505 Argument WINDOW can be now internal window too.
5506 (Fwindow_use_time): Move up in code.
5507 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5509 (Fset_window_configuration, saved_window)
5510 (Fcurrent_window_configuration, save_window_save): Handle new
5511 members of window structure.
5512 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5513 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5514 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5515 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5516 Qget_mru_window, Qresize_root_window,
5517 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5518 Qauto_buffer_name; staticpro them.
5520 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5522 * window.c (Fwindow_total_size, Fwindow_left_column)
5523 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5524 (Fwindow_list_1): New functions.
5525 (window_box_text_cols): Replace with window_body_cols.
5526 (Fwindow_width, Fscroll_left, Fscroll_right):
5527 Use window_body_cols instead of window_box_text_cols.
5528 (delete_window, Fset_window_configuration):
5529 Call delete_all_subwindows with window as argument.
5530 (delete_all_subwindows): Take a window as argument and not a
5532 (window_loop): Remove handling of GET_LRU_WINDOW and
5534 (Fget_lru_window, Fget_largest_window): Move to window.el.
5536 * window.h: Extern window_body_cols instead of
5537 window_box_text_cols. delete_all_subwindows now takes a
5538 Lisp_Object as argument.
5540 * indent.c (compute_motion, Fcompute_motion):
5541 Use window_body_cols instead of window_box_text_cols.
5543 * frame.c (delete_frame): Call delete_all_subwindows with root
5546 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5548 * fns.c (Fputhash): Document return value.
5550 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5552 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5554 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5556 Cons<->int and similar integer overflow fixes (Bug#8794).
5558 Check for overflow when converting integer to cons and back.
5559 * charset.c (Fdefine_charset_internal, Fdecode_char):
5560 Use cons_to_unsigned to catch overflow.
5561 (Fencode_char): Use INTEGER_TO_CONS.
5562 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5563 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5564 * data.c (long_to_cons, cons_to_long): Remove.
5565 (cons_to_unsigned, cons_to_signed): New functions.
5566 These signal an error for invalid or out-of-range values.
5567 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5568 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5569 * font.c (Ffont_variation_glyphs):
5570 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5571 * lisp.h: Include <intprops.h>.
5572 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5573 (cons_to_signed, cons_to_unsigned): New decls.
5574 (long_to_cons, cons_to_long): Remove decls.
5575 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5576 (Fprimitive_undo): Use CONS_TO_INTEGER.
5577 * xfns.c (Fx_window_property): Likewise.
5578 * xselect.c: Include <limits.h>.
5579 (x_own_selection, selection_data_to_lisp_data):
5580 Use INTEGER_TO_CONS.
5581 (x_handle_selection_request, x_handle_selection_clear)
5582 (x_get_foreign_selection, Fx_disown_selection_internal)
5583 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5584 (lisp_data_to_selection_data): Use cons_to_unsigned.
5585 (x_fill_property_data): Use cons_to_signed.
5586 Report values out of range.
5588 Check for buffer and string overflow more precisely.
5589 * buffer.h (BUF_BYTES_MAX): New macro.
5590 * lisp.h (STRING_BYTES_MAX): New macro.
5591 * alloc.c (Fmake_string):
5592 * character.c (string_escape_byte8):
5593 * coding.c (coding_alloc_by_realloc):
5594 * doprnt.c (doprnt):
5595 * editfns.c (Fformat):
5597 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5598 since they may not be the same number.
5599 * editfns.c (Finsert_char):
5600 * fileio.c (Finsert_file_contents):
5601 Likewise for BUF_BYTES_MAX.
5603 * image.c: Use ptrdiff_t, not int, for sizes.
5604 (slurp_file): Switch from int to ptrdiff_t.
5606 (slurp_file): Check that file size fits in both size_t (for
5607 malloc) and ptrdiff_t (for sanity and safety).
5609 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5610 if b->modtime has its maximal value.
5612 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5614 Don't assume time_t can fit into int.
5615 * buffer.h (struct buffer.modtime): Now time_t, not int.
5616 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5617 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5619 Minor fixes for signed vs unsigned integers.
5620 * character.h (MAYBE_UNIFY_CHAR):
5621 * charset.c (maybe_unify_char):
5622 * keyboard.c (read_char, reorder_modifiers):
5623 XINT -> XFASTINT, since the integer must be nonnegative.
5624 * ftfont.c (ftfont_spec_pattern):
5625 * keymap.c (access_keymap, silly_event_symbol_error):
5626 XUINT -> XFASTINT, since the integer must be nonnegative.
5627 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5628 since it makes no difference and we prefer signed.
5629 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5630 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5633 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5635 * window.h (Fwindow_frame): Declare.
5637 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5639 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5640 (SPARE_MEMORY): Always define.
5641 (LARGE_REQUEST): Remove.
5642 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5644 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5646 * lisp.h: Move EXFUNS for Fframe_root_window,
5647 Fframe_first_window and Fset_frame_selected_window to window.h.
5649 * window.h: Move EXFUNS for Fframe_root_window,
5650 Fframe_first_window and Fset_frame_selected_window here from
5653 * frame.c (Fwindow_frame, Fframe_first_window)
5654 (Fframe_root_window, Fframe_selected_window)
5655 (Fset_frame_selected_window): Move to window.c.
5656 (Factive_minibuffer_window): Move to minibuf.c.
5657 (Fother_visible_frames_p): New function.
5659 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5661 * window.c (decode_window, decode_any_window): Move up in code.
5662 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5663 (inhibit_frame_unsplittable): Remove unused variable.
5664 (Fwindow_buffer): Move up and rewrite doc-string.
5665 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5666 (Fwindow_prev): New functions.
5667 (Fwindow_frame): Move here from frame.c. Accept any window as
5669 (Fframe_root_window, Fframe_first_window)
5670 (Fframe_selected_window): Move here from frame.c. Accept frame
5671 or arbitrary window as argument. Update doc-strings.
5672 (Fminibuffer_window): Move up in code.
5673 (Fwindow_minibuffer_p): Move up in code and simplify.
5674 (Fset_frame_selected_window): Move here from frame.c.
5676 (Fselected_window, select_window, Fselect_window): Move up in
5677 code. Minor doc-string fixes.
5679 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5681 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5682 Do not assume that spare memory exists; that assumption is valid
5683 only if SYSTEM_MALLOC.
5684 (LARGE_REQUEST): New macro, so that the issue of large requests
5685 is separated from the issue of spare memory.
5687 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5689 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5692 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5694 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5697 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5699 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5701 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5703 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5704 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5706 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5708 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5710 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5712 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5713 (x_clipboard_manager_save): Add return value.
5714 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5716 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5717 Obey Vx_select_enable_clipboard_manager. Catch errors in
5718 x_clipboard_manager_save (Bug#8779).
5719 (Vx_select_enable_clipboard_manager): New variable.
5720 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5722 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5724 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5726 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5728 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5729 in the current matrix if keep_current_p is non-zero.
5731 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5733 * bidi.c (bidi_level_of_next_char): Fix last change.
5735 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5737 Support bidi reordering of text covered by display properties.
5739 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5740 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5741 (bidi_cache_search, bidi_cache_iterator_state)
5742 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5743 (bidi_level_of_next_char, bidi_move_to_visually_next):
5744 Support character positions inside a run of characters covered by a
5746 (bidi_paragraph_init, bidi_resolve_explicit_1)
5747 (bidi_level_of_next_char): Call bidi_fetch_char and
5748 bidi_fetch_char_advance instead of FETCH_CHAR and
5750 (bidi_init_it): Initialize new members.
5751 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5753 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5754 instead of using explicit *_CHAR codes.
5755 (bidi_resolve_explicit, bidi_resolve_weak):
5756 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5757 bidirectional text is supported only in multibyte buffers.
5758 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5759 it to initialize the frame_window_p member of struct bidi_it.
5760 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5761 (bidi_resolve_explicit, bidi_resolve_weak)
5762 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5763 bidi_it->nchars is non-positive.
5764 (bidi_level_of_next_char): Don't try to lookup the cache for the
5765 next/previous character if nothing is cached there yet, or if we
5766 were just reseat()'ed to a new position.
5768 * xdisp.c (set_cursor_from_row): Set start and stop points
5769 according to the row's direction when priming the loop that looks
5770 for the glyph on which to display cursor.
5771 (single_display_spec_intangible_p): Function deleted.
5772 (display_prop_intangible_p): Reimplement to call
5773 handle_display_spec instead of single_display_spec_intangible_p.
5774 Accept 3 additional arguments needed by handle_display_spec.
5775 This fixes incorrect cursor motion across display property with complex
5776 values: lists, `(when COND...)' forms, etc.
5777 (single_display_spec_string_p): Support property values that are
5778 lists with the argument STRING its top-level element.
5779 (display_prop_string_p): Fix the condition for processing a
5780 property that is a list to be consistent with handle_display_spec.
5781 (handle_display_spec): New function, refactored from the
5782 last portion of handle_display_prop.
5783 (compute_display_string_pos): Accept additional argument
5784 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5785 value of a `display' property is a "replacing spec".
5786 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5787 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5788 the display property, but just return a value indicating whether
5789 the display property will replace the characters it covers.
5790 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5791 frame_window_p members of struct bidi_it.
5792 (compute_display_string_pos, compute_display_string_end):
5794 (push_it): Accept second argument POSITION, where pop_it should
5795 jump to continue iteration.
5796 (reseat_1): Initialize bidi_it.disp_pos.
5798 * keyboard.c (adjust_point_for_property): Adjust the call to
5799 display_prop_intangible_p to its new signature.
5801 * dispextern.h (struct bidi_it): New member frame_window_p.
5802 (bidi_init_it): Update prototypes.
5803 (display_prop_intangible_p): Update prototype.
5804 (compute_display_string_pos, compute_display_string_end):
5806 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5809 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5811 Malloc failure behavior now depends on size of allocation.
5812 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5813 * lisp.h: Change signatures accordingly.
5814 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5815 All callers changed. (Bug#8762)
5817 * gnutls.c: Use Emacs's memory allocators.
5818 Without this change, the gnutls library would invoke malloc etc.
5819 directly, which causes problems on non-SYNC_INPUT hosts, and which
5820 runs afoul of improving memory_full behavior. (Bug#8761)
5821 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5822 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5823 xfree instead of the default malloc, realloc, free.
5824 (Fgnutls_boot): No need to check for memory allocation failure,
5825 since xmalloc does that for us.
5827 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5828 * category.c (hash_get_category_set):
5829 * ccl.c (ccl_driver):
5830 * charset.c (Fdefine_charset_internal):
5831 * charset.h (struct charset.hash_index):
5832 * composite.c (get_composition_id, gstring_lookup_cache)
5833 (composition_gstring_put_cache):
5834 * composite.h (struct composition.hash_index):
5835 * dispextern.h (struct image.hash):
5836 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5837 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5838 (hashfn_equal, hashfn_user_defined, make_hash_table)
5839 (maybe_resize_hash_table, hash_lookup, hash_put)
5840 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5841 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5842 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5843 * image.c (make_image, search_image_cache, lookup_image)
5844 (xpm_put_color_table_h):
5845 * lisp.h (struct Lisp_Hash_Table):
5846 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5847 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5848 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5849 * alloc.c (allocate_vectorlike):
5850 Check for overflow in vector size calculations.
5851 * ccl.c (ccl_driver):
5852 Check for overflow when converting EMACS_INT to int.
5853 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5854 need to be updated by these changes.
5855 * fns.c (make_hash_table, maybe_resize_hash_table):
5856 Check for integer overflow with large hash tables.
5857 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5858 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5859 (SXHASH_REDUCE): New macro.
5860 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5861 Use it instead of discarding useful hash info with large hash values.
5862 (sxhash_float): New function.
5863 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5864 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5865 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5866 Rewrite to use FIXNUM_BITS, as this simplifies things.
5867 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5868 Adjust signatures to match updated version of code.
5869 (consing_since_gc): Now EMACS_INT, since a single hash table can
5870 use more than INT_MAX bytes.
5872 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5874 Make it possible to build with GCC-4.6+ -O2 -flto.
5876 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5878 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5880 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5881 Call minibuffer-inactive-mode.
5883 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5885 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5886 Update dependencies.
5888 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5890 * data.c (init_data): Remove code for UTS, this system is not
5893 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5895 Don't force ./temacs to start in terminal mode.
5897 * frame.c (make_initial_frame): Initialize faces in all cases, not
5898 only when CANNOT_DUMP is defined.
5899 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5901 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5903 * dispnew.c (add_window_display_history): Use const for the string
5904 pointer. Remove declaration, not needed.
5906 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5908 Use 'inline', not 'INLINE'.
5909 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5910 * alloc.c, fontset.c (INLINE): Remove.
5911 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5912 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5913 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5914 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5915 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5917 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5919 Make it possible to run ./temacs.
5921 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5922 syms_of_callproc does the same thing. Remove test for
5923 "initialized", do it in the caller.
5924 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5926 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5928 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5929 (read_minibuf): Use get_minibuffer.
5930 (syms_of_minibuf): Use DEFSYM.
5931 (Qmetadata): New var.
5932 * data.c (Qbuffer): Don't make it static.
5933 (syms_of_data): Use DEFSYM.
5935 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5937 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5938 (CCL_CODE_MIN): New macro.
5940 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5942 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5944 * eval.c (Qdebug): Now static.
5945 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5946 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5947 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5949 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5951 * image.c: Various fixes to ImageMagick code comments.
5952 (Fimagemagick_types): Doc fix.
5954 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5956 Minor fixes prompted by GCC 4.6.0 warnings.
5958 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5960 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5961 (x_clipboard_manager_save_all): Move extern decl to ...
5962 * xterm.h: ... here, so that it can be checked for consistency.
5964 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5966 * xselect.c (x_clipboard_manager_save_frame)
5967 (x_clipboard_manager_save_all): New functions.
5968 (Fx_clipboard_manager_save): Lisp function deleted.
5970 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5971 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5973 * xterm.h: Update prototype.
5975 2011-05-28 William Xu <william.xwl@gmail.com>
5977 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5980 2011-05-28 Jim Meyering <meyering@redhat.com>
5982 Avoid a sign-extension bug in crypto_hash_function.
5983 * fns.c (to_uchar): Define.
5984 (crypto_hash_function): Use it to convert some newly-signed
5985 variables to unsigned, to avoid sign-extension bugs. For example,
5986 without this change, (md5 "truc") would evaluate to
5987 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5988 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5989 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5991 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5993 Integer overflow fixes.
5995 * dbusbind.c: Serial number integer overflow fixes.
5996 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5997 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5998 to hold a serial number that is too large for a fixnum.
5999 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6000 Check for serial numbers out of range. Decode any serial number
6001 that was so large that it became a float. (Bug#8722)
6003 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6004 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6005 Use XFASTINT rather than XUINT when numbers are nonnegative.
6006 (xd_append_arg, Fdbus_method_return_internal):
6007 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6008 arguments, check that Lisp number is nonnegative, rather than
6009 silently wrapping negative numbers around. (Bug#8722)
6010 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6013 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6015 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6017 ccl: Add integer overflow checks.
6018 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6019 (IN_INT_RANGE): New macros.
6020 (ccl_driver): Use them to check for integer overflow when
6021 decoding a CCL program. Many of the new checks are whether XINT (x)
6022 fits in int; it doesn't always, on 64-bit hosts. The new version
6023 doesn't catch all possible integer overflows, but it's an
6024 improvement. (Bug#8719)
6026 * alloc.c (make_event_array): Use XINT, not XUINT.
6027 There's no need for unsigned here.
6029 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6030 This follows up to the 2011-05-06 change that substituted uintptr_t
6031 for EMACS_INT. This case wasn't caught back then.
6033 Rework Fformat to avoid integer overflow issues.
6034 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6035 now (part of C89). Include <verify.h>.
6036 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6037 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6038 (Fformat): Avoid the prepass trying to compute sizes; it was only
6039 approximate and thus did not catch overflow reliably. Instead, walk
6040 through the format just once, formatting and computing sizes as we go,
6041 checking for integer overflow at every step, and allocating a larger
6042 buffer as needed. Keep track separately whether the format is
6043 multibyte. Keep only the most-recently calculated precision, rather
6044 than them all. Record whether each argument has been converted to
6045 string. Use EMACS_INT, not int, for byte and char and arg counts.
6046 Support field widths and precisions larger than INT_MAX. Avoid
6047 sprintf's undefined behavior with conversion specifications such as %#d
6048 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6049 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6050 formatting out-of-range floating point numbers with int
6053 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6055 * data.c: Avoid integer truncation in expressions involving floats.
6056 * data.c: Include <intprops.h>.
6057 (arith_driver): When there's an integer overflow in an expression
6058 involving floating point, convert the integers to floating point
6059 so that the resulting value does not suffer from catastrophic
6060 integer truncation. For example, on a 64-bit host (* 4
6061 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6062 Do not rely on undefined behavior after integer overflow.
6064 merge count_size_as_multibyte, parse_str_to_multibyte
6065 * character.c, character.h (count_size_as_multibyte):
6066 Rename from parse_str_to_multibyte; all uses changed.
6067 Check for integer overflow.
6068 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6069 since it's now a duplicate of the other. This is more of
6070 a character than a buffer op, so better that it's in character.c.
6071 * fns.c, print.c: Adjust to above changes.
6073 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6075 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6077 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6079 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6080 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6081 (x_clipboard_manager_save): Now static.
6082 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6084 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6085 (crypto_hash_function): Now static.
6086 Fix pointer signedness problems. Avoid unnecessary initializations.
6088 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6090 * termhooks.h (Vselection_alist): Make it terminal-local.
6092 * terminal.c (create_terminal): Initialize it.
6094 * xselect.c: Support for clipboard managers.
6095 (Vselection_alist): Move to termhooks.h as terminal-local var.
6096 (LOCAL_SELECTION): New macro.
6097 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6098 (symbol_to_x_atom): Remove gratuitous arg.
6099 (x_handle_selection_request, lisp_data_to_selection_data)
6100 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6101 (x_own_selection, x_get_local_selection, x_convert_selection):
6102 New arg, specifying work frame. Use terminal-local Vselection_alist.
6103 (some_frame_on_display): Delete unused function.
6104 (Fx_own_selection_internal, Fx_get_selection_internal)
6105 (Fx_disown_selection_internal, Fx_selection_owner_p)
6106 (Fx_selection_exists_p): New optional frame arg.
6107 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6108 (x_handle_selection_clear): Don't treat other terminals with the
6109 same keyboard specially. Use the terminal-local Vselection_alist.
6110 (x_clear_frame_selections): Use Frun_hook_with_args.
6112 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6114 * xterm.h: Add support for those atoms.
6116 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6118 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6119 (converted_selections, conversion_fail_tag): New global variables.
6120 (x_selection_request_lisp_error): Free the above.
6121 (x_get_local_selection): Remove unnecessary code.
6122 (x_reply_selection_request): Args changed; handle arbitrary array
6123 of converted selections stored in converted_selections.
6124 Separate the XChangeProperty and SelectionNotify steps.
6125 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6126 (x_convert_selection): New function.
6127 (x_handle_selection_event): Simplify.
6128 (x_get_foreign_selection): Don't ignore incoming requests while
6129 waiting for an answer; this will fail when we implement
6130 SAVE_TARGETS, and seems unnecessary anyway.
6131 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6132 (Vx_sent_selection_functions): Doc fix.
6134 2011-05-26 Leo Liu <sdl.web@gmail.com>
6136 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6138 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6140 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6142 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6143 for fringe update if it has periodic bitmap.
6144 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6145 and fringe_bitmap_periodic_p.
6147 * fringe.c (get_fringe_bitmap_data): New function.
6148 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6149 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6150 row. Mark glyph row for fringe update if periodicity changed.
6152 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6153 for fringe update unless it has periodic bitmap.
6155 2011-05-25 Kenichi Handa <handa@m17n.org>
6157 * xdisp.c (get_next_display_element): Set correct it->face_id for
6158 a static composition.
6160 2011-05-24 Leo Liu <sdl.web@gmail.com>
6163 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6165 * fns.c (crypto_hash_function, Fsha1): New function.
6166 (Fmd5): Use crypto_hash_function.
6167 (syms_of_fns): Add Ssha1.
6169 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6171 * gnutls.c: Remove unused macros.
6172 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6173 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6174 Remove macros that are defined and never used.
6175 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6177 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6179 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6180 (Fx_get_selection_internal): Minor cleanup.
6181 (Fx_own_selection_internal): Rename arguments for consistency with
6184 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6186 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6188 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6190 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6192 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6194 * dispnew.c (scrolling_window): Don't exclude the case that the
6195 last enabled row in the desired matrix touches the bottom boundary.
6197 2011-05-21 Glenn Morris <rgm@gnu.org>
6199 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6200 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6201 and add some more files.
6203 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6205 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6206 report_file_error introduced by the change from 2011-05-07.
6208 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6210 * systime.h (Time): Define only if emacs is defined.
6211 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6212 where the include path doesn't have X11/X.h by default. See
6213 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6215 2011-05-20 Kenichi Handa <handa@m17n.org>
6217 * composite.c (find_automatic_composition): Fix previous change.
6219 2011-05-20 Glenn Morris <rgm@gnu.org>
6221 * lisp.mk: New file, split from Makefile.in.
6222 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6223 (shortlisp): Remove.
6224 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6226 2011-05-19 Glenn Morris <rgm@gnu.org>
6228 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6229 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6230 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6231 (lisp): Set the order to that of loadup.el.
6232 (shortlisp): Make it a copy of $lisp.
6233 (SOME_MACHINE_LISP): Remove.
6234 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6235 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6237 2011-05-18 Kenichi Handa <handa@m17n.org>
6239 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6240 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6241 (find_automatic_composition): Mostly rewrite for efficiency.
6243 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6245 * makefile.w32-in: Update dependencies.
6247 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6249 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6250 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6252 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6254 Fix some integer overflow issues, such as string length overflow.
6256 * insdel.c (count_size_as_multibyte): Check for string overflow.
6258 * character.c (lisp_string_width): Check for string overflow.
6259 Use EMACS_INT, not int, for string indexes and lengths; in
6260 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6261 the resulting string length overflows an EMACS_INT; instead,
6262 report a string overflow if no precision given. When checking for
6263 precision exhaustion, use a check that cannot possibly have
6264 integer overflow. (Bug#8675)
6265 * character.h (lisp_string_width): Adjust to new signature.
6267 * alloc.c (string_overflow): New function.
6268 (Fmake_string): Use it. This doesn't change behavior, but saves
6269 a few bytes and will simplify future changes.
6270 * character.c (string_escape_byte8): Likewise.
6271 * lisp.h (string_overflow): New decl.
6273 Fixups, following up to the user-interface timestamp change.
6274 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6275 for UI timestamps, instead of unsigned long.
6276 * msdos.c (mouse_get_pos): Likewise.
6277 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6278 * w32gui.h (Time): Define by including "systime.h" rather than by
6279 declaring it ourselves. (Bug#8664)
6281 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6282 * image.c (clear_image_cache): Likewise.
6284 * term.c (term_mouse_position): Don't assume time_t wraparound.
6286 Be more systematic about user-interface timestamps.
6287 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6288 and sometimes 'EMACS_UINT', to represent these timestamps.
6289 This change causes it to use 'Time' uniformly, as that's what X uses.
6290 This makes the code easier to follow, and makes it easier to catch
6291 integer overflow bugs such as Bug#8664.
6292 * frame.c (Fmouse_position, Fmouse_pixel_position):
6293 Use Time, not unsigned long, for user-interface timestamps.
6294 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6295 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6296 * keyboard.h (last_event_timestamp): Likewise.
6297 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6298 * menu.h (xmenu_show): Likewise.
6299 * term.c (term_mouse_position): Likewise.
6300 * termhooks.h (struct input_event.timestamp): Likewise.
6301 (struct terminal.mouse_position_hook): Likewise.
6302 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6303 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6304 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6305 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6307 * menu.h, termhooks.h: Include "systime.h", for Time.
6309 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6310 Don't assume that the difference between two unsigned long values
6311 can fit into an integer. At this point, we know button_down_time
6312 <= event->timestamp, so the difference must be nonnegative, so
6313 there's no need to cast the result if double-click-time is
6314 nonnegative, as it should be; check that it's nonnegative, just in
6315 case. This bug is triggered when events are more than 2**31 ms
6316 apart (about 25 days). (Bug#8664)
6318 * xselect.c (last_event_timestamp): Remove duplicate decl.
6319 (x_own_selection): Remove needless cast to unsigned long.
6321 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6322 that always fit in int. Use a sentinel instead of a counter, to
6323 avoid a temp and to allay GCC's concerns about possible int overflow.
6324 * frame.h (struct frame): Use int for menu_bar_items_used
6325 instead of EMACS_INT, since it always fits in int.
6327 * menu.c (grow_menu_items): Check for int overflow.
6329 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6331 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6332 Before, the code was not consistent. These values cannot exceed
6333 2**31 - 1 so there's no need to make them unsigned.
6334 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6335 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6336 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6338 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6340 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6341 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6342 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6343 presumably because the widths might not match.
6345 * window.c (size_window): Avoid needless test at loop start.
6347 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6349 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6351 2011-05-12 Drew Adams <drew.adams@oracle.com>
6353 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6355 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6357 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6358 `width' to `bar_area_x' and `bar_area_width', respectively.
6359 (x_scroll_run): Take account of fringe background extension.
6361 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6362 Rename local vars `left' and `width' to `bar_area_x' and
6363 `bar_area_width', respectively.
6364 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6365 background extension.
6367 2011-05-10 Jim Meyering <meyering@redhat.com>
6369 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6371 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6373 * image.c (Finit_image_library): Return t for built-in image types,
6374 like pbm and xbm. (Bug#8640)
6376 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6378 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6380 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6382 * w32console.c (Fset_screen_color): Doc fix.
6383 (Fget_screen_color): New function.
6384 (syms_of_ntterm): Defsubr it.
6386 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6387 unlink the temporary file if Fcall_process didn't create it in the
6389 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6390 child process will be redirected to a file specified with `:file'.
6391 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6392 cue to call_process_cleanup not to close that handle.
6394 2011-05-07 Ben Key <bkey76@gmail.com>
6396 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6397 one of two shell specific rules, either bootstrap-temacs-CMD or
6398 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6399 to the previous implementation of the bootstrap-temacs rule.
6400 The bootstrap-temacs-CMD rule is similar to the previous
6401 implementation of the bootstrap-temacs rule except that it
6402 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6405 These changes, along with some changes to nt/configure.bat,
6406 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6407 earlier fix to add support for --cflags and --ldflags options
6408 that include quotes so that it works whether make uses cmd or
6411 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6413 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6414 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6416 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6417 a string. Handle both cases.
6418 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6419 (Fdbus_register_method): Use Qinvalid_function.
6421 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6423 * makefile.w32-in: Update dependencies.
6424 (LISP_H): Add inttypes.h and stdin.h.
6425 (PROCESS_H): Add unistd.h.
6427 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6429 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6430 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6432 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6434 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6436 * term.c (vfatal): Remove stray call to va_end.
6437 It's not needed and the C Standard doesn't allow it here anyway.
6439 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6440 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6442 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6445 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6447 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6449 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6451 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6453 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6455 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6456 * charset.c (Fdefine_charset_internal): Don't initialize
6457 charset.code_space[15]. The value was garbage, on hosts with
6458 32-bit int (Bug#8600).
6460 * lread.c (read_integer): Be more consistent with string-to-number.
6461 Use string_to_number to do the actual conversion; this avoids
6462 rounding errors and fixes some other screwups. Without this fix,
6463 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6464 (digit_to_number): Move earlier, for benefit of read_integer.
6465 Return -1 if the digit is out of range for the base, -2 if it is
6466 not a digit in any supported base. (Bug#8602)
6468 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6470 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6471 to match comment at start of function. This also removes a
6472 GCC warning about overflow in a 32+64-bit port.
6474 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6476 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6477 Reported by Stefan Monnier in
6478 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6479 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6480 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6482 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6483 (EMACS_UINTPTR): Likewise, with uintptr_t.
6485 * lisp.h: Prefer 64-bit EMACS_INT if available.
6486 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6487 on 32-bit hosts that have 64-bit int, so that they can access
6489 However, temporarily disable this change unless the temporary
6490 symbol WIDE_EMACS_INT is defined.
6492 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6494 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6495 This removes an assumption that EMACS_INT and long are the same
6496 width as pointers. The assumption is true for Emacs porting targets
6497 now, but we want to make other targets possible.
6498 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6499 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6500 In the rest of the code, change types of integers that hold casted
6501 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6502 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6503 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6504 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6505 No need to cast type when ORing.
6506 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6507 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6508 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6509 assume EMACS_INT is the same width as char *.
6510 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6511 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6512 Remove no-longer-needed casts.
6513 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6514 (xg_tool_bar_help_callback, xg_make_tool_item):
6515 Use EMACS_INTPTR to hold an integer
6516 that will be cast to void *; this can avoid a GCC warning
6517 if EMACS_INT is not the same width as void *.
6518 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6519 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6520 (current_message_1, set_message_1):
6521 Use a local to convert to proper width without a cast.
6522 * xmenu.c (dialog_selection_callback): Likewise.
6524 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6525 Also, don't assume VALBITS / RAND_BITS is less than 5,
6526 and don't rely on undefined behavior when shifting a 1 left into
6528 * lisp.h (get_random): Change signature to match.
6530 * lread.c (hash_string): Use size_t, not int, for hash computation.
6531 Normally we prefer signed values; but hashing is special, because
6532 it's better to use unsigned division on hash table sizes so that
6533 the remainder is nonnegative. Also, size_t is the natural width
6534 for hashing into memory. The previous code used 'int', which doesn't
6535 retain enough info to hash well into very large tables.
6536 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6538 * dbusbind.c: Don't possibly lose pointer info when converting.
6539 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6540 Use XPNTR rather than XHASH, so that the high-order bits of
6541 the pointer aren't lost when converting through void *.
6543 * eval.c (Fautoload): Don't double-shift a pointer.
6545 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6547 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6549 * gnutls.c (DEF_GNUTLS_FN):
6550 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6552 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6554 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6557 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6559 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6560 New version that can reserve upto 2GB of heap space.
6562 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6564 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6566 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6568 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6569 `gnutls_certificate_set_x509_key_file'.
6571 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6573 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6574 Update dependencies.
6576 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6578 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6579 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6580 Remove unused parameter `fildes'.
6581 * process.c (read_process_output, send_process): Don't pass it.
6583 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6585 Fix previous change: the library cache is defined in w32.c.
6586 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6587 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6589 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6591 Implement dynamic loading of GnuTLS on Windows.
6593 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6594 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6595 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6598 * gnutls.c (Qgnutls_dll): Define.
6599 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6600 (gnutls_*): Declare function pointers.
6601 (init_gnutls_functions): New function to initialize function pointers.
6602 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6603 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6604 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6605 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6606 (emacs_gnutls_write, emacs_gnutls_read)
6607 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6608 (Fgnutls_available_p): New function.
6609 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6610 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6611 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6613 * image.c: Include w32.h.
6614 (Vimage_type_cache): Delete.
6615 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6616 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6617 (w32_delayed_load): Move to w32.c.
6619 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6621 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6622 (w32_delayed_load): Move from image.c. When loading a library, record
6623 its filename in the :loaded-from property of the library id.
6624 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6625 Initialize and staticpro them.
6626 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6628 * process.c: Include lisp.h before w32.h, not after.
6629 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6630 instead of gnutls_record_check_pending.
6632 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6634 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6636 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6637 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6640 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6642 * xterm.c (x_set_frame_alpha): Do not set property on anything
6643 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6645 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6647 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6649 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6651 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6652 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6653 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6654 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6655 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6656 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6657 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6658 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6659 (Qgnutls_bootprop_callbacks_verify): Make static.
6661 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6663 * callproc.c: Indentation fixup.
6665 * sysdep.c (wait_for_termination_1): Make static.
6666 (wait_for_termination, interruptible_wait_for_termination):
6667 Move after wait_for_termination_1.
6669 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6671 * sysdep.c (interruptible_wait_for_termination): New function
6672 which is like wait_for_termination, but allows keyboard
6675 * callproc.c (Fcall_process): Add (:file "file") as an option for
6677 (Fcall_process_region): Ditto.
6679 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6681 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6682 rather than `XVECTOR (FOO)->size'.
6684 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6685 inttypes.h, as a gnulib replacement is used if it not available in
6688 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6690 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6691 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6692 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6694 * coding.c (coding_alloc_by_realloc): Error out if destination
6695 will grow beyond MOST_POSITIVE_FIXNUM.
6696 (decode_coding_emacs_mule): Abort if there isn't enough place in
6697 charbuf for the composition carryover bytes. Reserve an extra
6698 space for up to 2 characters produced in a loop.
6699 (decode_coding_iso_2022): Abort if there isn't enough place in
6700 charbuf for the composition carryover bytes.
6702 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6704 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6705 aborting when %lld or %lll format is passed.
6706 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6707 %llo or %llx format is passed. (Bug#8545)
6709 * window.c (window_scroll_line_based): Use a marker instead of
6710 simple variables to record original value of point. (Bug#7952)
6712 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6713 produced by %s or %c overflows available buffer space. (Bug#8545)
6715 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6717 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6718 (SIZE_MAX): Move defn after all includes, as they might #define it.
6720 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6722 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6724 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6726 * keyboard.c (Qdelayed_warnings_hook): Define.
6727 (command_loop_1): Run `delayed-warnings-hook'
6728 if Vdelayed_warnings_list is non-nil.
6729 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6730 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6732 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6734 * doprnt.c (doprnt): Don't return value smaller than the buffer
6735 size if the message was truncated. (Bug#8545).
6737 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6739 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6740 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6742 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6744 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6746 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6748 * makefile.w32-in: Update dependencies.
6750 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6752 Improve `doprnt' and its usage. (Bug#8545)
6753 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6754 `format_end'. Remove support for %l as a conversion specifier.
6755 Don't use xrealloc. Improve diagnostics when the %l size modifier
6756 is used. Update the commentary.
6758 * eval.c (verror): Simplify calculation of size_t.
6760 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6763 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6765 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6768 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6770 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6771 This makes this file independent of the recent pseudovector change.
6773 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6775 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6777 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6778 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6779 Remove unused local.
6780 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6782 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6783 GCC 4.6.0 optimizes based on type-based alias analysis.
6784 For example, if b is of type struct buffer * and v of type struct
6785 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6786 != &v->size, and therefore "v->size = 1; b->size = 2; return
6787 v->size;" must therefore return 1. This assumption is incorrect
6788 for Emacs, since it type-puns struct Lisp_Vector * with many other
6789 types. To fix this problem, this patch adds a new type struct
6790 vectorlike_header that documents the constraints on layout of vectors
6791 and pseudovectors, and helps optimizing compilers not get fooled
6792 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6793 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6794 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6796 (XSETPVECTYPE): Rewrite in terms of new macro.
6797 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6798 This is a bit clearer, and further avoids the possibility of
6799 undesirable aliasing.
6800 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6801 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6802 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6803 since Lisp_Subr is a special case (no "next" field).
6804 (ASIZE): Now uses header.size rather than size.
6805 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6806 to avoid the hassle of writing XVECTOR (foo)->header.size.
6807 (struct vectorlike_header): New type.
6808 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6809 object, to help avoid aliasing.
6810 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6811 (SUBRP): Likewise, since Lisp_Subr is a special case.
6812 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6813 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6814 (struct Lisp_Hash_Table): Combine first two members into a single
6815 struct vectorlike_header member. All uses of "size" and "next" members
6816 changed to be "header.size" and "header.next".
6817 * buffer.h (struct buffer): Likewise.
6818 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6819 * frame.h (struct frame): Likewise.
6820 * process.h (struct Lisp_Process): Likewise.
6821 * termhooks.h (struct terminal): Likewise.
6822 * window.c (struct save_window_data, struct saved_window): Likewise.
6823 * window.h (struct window): Likewise.
6824 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6825 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6826 * buffer.c (init_buffer_once): Likewise.
6827 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6829 * process.c (Fformat_network_address): Use local var for size,
6832 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6834 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6835 * data.c (atof): Remove decl; no longer used or needed.
6836 (digit_to_number): Move to lread.c.
6837 (Fstring_to_number): Use new string_to_number function, to be
6838 consistent with how the Lisp reader treats infinities and NaNs.
6839 Do not assume that floating-point numbers represent EMACS_INT
6840 without losing information; this is not true on most 64-bit hosts.
6841 Avoid double-rounding errors, by insisting on integers when
6842 parsing non-base-10 numbers, as the documentation specifies.
6843 * lisp.h (string_to_number): New decl, replacing ...
6844 (isfloat_string): Remove.
6845 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6846 (read1): Do not accept +. and -. as integers; this
6847 appears to have been a coding error. Similarly, do not accept
6848 strings like +-1e0 as floating point numbers. Do not report
6849 overflow for integer overflows unless the base is not 10 which
6850 means we have no simple and reliable way to continue.
6851 Break out the floating-point parsing into a new
6852 function string_to_number, so that Fstring_to_number parses
6853 floating point numbers consistently with the Lisp reader.
6854 (digit_to_number): Move here from data.c. Make it static inline.
6855 (E_CHAR, EXP_INT): Remove, replacing with ...
6856 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6857 (string_to_number): New function, replacing isfloat_string.
6858 This function checks for valid syntax and produces the resulting
6859 Lisp float number too. Rework it so that string-to-number
6860 no longer mishandles examples like "1.0e+". Use strtoumax,
6861 so that overflow for non-base-10 numbers is reported only when
6862 there's no portable and simple way to convert to floating point.
6864 * textprop.c (set_text_properties_1): Rewrite for clarity,
6865 and to avoid GCC warning about integer overflow.
6867 * intervals.h (struct interval): Use EMACS_INT for members
6868 where EMACS_UINT might cause problems. See
6869 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6870 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6871 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6873 (offset_intervals): Tell GCC not to worry about length overflow
6874 when negating a negative length.
6876 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6877 (overrun_check_free): Likewise.
6879 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6880 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6883 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6884 (gnutls_make_error): Rename local to avoid shadowing.
6885 (gnutls_emacs_global_deinit): ifdef out; not used.
6886 (Fgnutls_boot): Use const for pointer to readonly storage.
6887 Comment out unused local. Fix pointer signedness problems.
6889 * lread.c (openp): Don't stuff size_t into an 'int'.
6890 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6891 about possible signed overflow.
6893 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6894 (GDK_KEY_g): Don't define if already defined.
6895 (xg_prepare_tooltip): Avoid pointer signedness problem.
6896 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6898 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6899 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6901 * xfns.c (Fx_window_property): Simplify a bit,
6902 to make a bit faster and to avoid GCC 4.6.0 warning.
6903 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6905 * fns.c (internal_equal): Don't assume size_t fits in int.
6907 * alloc.c (compact_small_strings): Tighten assertion a little.
6909 Replace pEd with more-general pI, and fix some printf arg casts.
6910 * lisp.h (pI): New macro, generalizing old pEd macro to other
6911 conversion specifiers. For example, use "...%"pI"d..." rather
6912 than "...%"pEd"...".
6913 (pEd): Remove. All uses replaced with similar uses of pI.
6914 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6915 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6916 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6917 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6918 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6919 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6920 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6922 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6923 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6924 * print.c (safe_debug_print, print_object): Likewise.
6925 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6927 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6928 avoiding the 0 flag, which is not portable.
6929 * process.c (Fmake_network_process): Use pI to avoid cast.
6930 * region-cache.c (pp_cache): Likewise.
6931 * xdisp.c (decode_mode_spec): Likewise.
6932 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6933 behavior on 64-bit hosts with printf arg.
6934 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6935 (x_stop_queuing_selection_requests): Likewise.
6936 (x_get_window_property): Don't truncate byte count to an 'int'
6939 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6940 here, since it parses constructs like leading '-' and spaces,
6941 which are not wanted; and it overflows with large numbers.
6942 Instead, simply match F[0-9]+, which is what is wanted anyway.
6944 * alloc.c: Remove unportable assumptions about struct layout.
6945 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6946 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6947 (allocate_vectorlike, make_pure_vector): Use the new macros,
6948 plus offsetof, to remove unportable assumptions about struct layout.
6949 These assumptions hold on all porting targets that I know of, but
6950 they are not guaranteed, they're easy to remove, and removing them
6951 makes further changes easier.
6953 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6954 This doesn't fix a bug but makes the code clearer.
6955 (string_overrun_cookie): Now const. Use initializers that
6956 don't formally overflow signed char, to avoid warnings.
6957 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6958 can cause Emacs to crash when string overrun checking is enabled.
6959 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6960 multiple of sizeof (EMACS_INT); it need not be, if
6961 alignof(EMACS_INT) < sizeof (EMACS_INT).
6962 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6964 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6966 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6968 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6970 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6971 supposed to be handshaking. (Bug#8556)
6972 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6974 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6976 * lisp.h (Qdebug): List symbol.
6977 * eval.c (Qdebug): Restore global linkage.
6978 * keyboard.c (debug-on-event): New variable.
6979 (handle_user_signal): Break into debugger when debug-on-event
6980 matches the current signal symbol.
6982 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6984 * alloc.c (check_sblock, check_string_bytes)
6985 (check_string_free_list): Convert to standard C.
6987 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6989 * w32.c (emacs_gnutls_push): Fix typo.
6991 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6993 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6994 "cast to pointer from integer of different size".
6996 Improve doprnt and its use in verror. (Bug#8545)
6997 * doprnt.c (doprnt): Document the set of format control sequences
6998 supported by the function. Use SAFE_ALLOCA instead of always
7001 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7002 is one byte too soon. Don't use xrealloc; instead xfree and
7005 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7007 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7010 * gnutls.c: Renamed global_initialized to
7011 gnutls_global_initialized. Added internals for the
7012 :verify-hostname-error, :verify-error, and :verify-flags
7013 parameters of `gnutls-boot' and documented those parameters in the
7014 docstring. Start callback support.
7015 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7016 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7017 on error. Return error code.
7018 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7019 (emacs_gnutls_read): Likewise.
7020 (Fgnutls_boot): Return handshake error code.
7021 (emacs_gnutls_handle_error): New function.
7022 (wsaerror_to_errno): Likewise.
7024 * w32.h (emacs_gnutls_pull): Add prototype.
7025 (emacs_gnutls_push): Likewise.
7027 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7028 (emacs_gnutls_push): Likewise.
7030 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7032 * process.c (wait_reading_process_output): Check if GnuTLS
7033 buffered some data internally if no FDs are set for TLS
7036 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7037 (LIBS): Link to USER_LIBS.
7038 ($(BLD)/gnutls.$(0)): New target.
7040 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7042 * xdisp.c (handle_single_display_spec): Rename the
7043 display_replaced_before_p argument into display_replaced_p, to
7044 make it consistent with the commentary. Fix typos in the
7047 * textprop.c (syms_of_textprop): Remove dead code.
7048 (copy_text_properties): Delete obsolete commentary about an
7049 interface that was deleted long ago. Fix typos in the description
7052 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7053 to changes in oldXMenu/XMenu.h from 2011-04-16.
7054 <menu_help_message, prev_menu_help_message>: Constify.
7055 (IT_menu_make_room): menu->help_text is now `const char **';
7058 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7059 to changes in oldXMenu/XMenu.h from 2011-04-16.
7060 (struct XMenu): Declare `help_text' `const char **'.
7062 * xfaces.c <Qunspecified>: Make extern again.
7064 * syntax.c: Include sys/types.h before including regex.h, as
7067 * doc.c (get_doc_string): Improve the format passed to `error'.
7069 * doprnt.c (doprnt): Improve commentary.
7071 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7073 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7076 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7077 changes in globals.h immediately force recompilation.
7078 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7079 $(CURDIR)/s/ms-w32.h.
7080 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7082 * character.c (Fchar_direction): Function deleted.
7083 (syms_of_character): Don't defsubr it.
7084 <char-direction-table>: Deleted.
7086 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7088 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7089 * doprnt.c: Include limits.h.
7090 (SIZE_MAX): New macro.
7091 (doprnt): Return a size_t value. 2nd arg is now size_t.
7092 Many local variables are now size_t instead of int or unsigned.
7093 Improve overflow protection. Support `l' modifier for integer
7094 conversions. Support %l conversion. Don't assume an EMACS_INT
7095 argument for integer conversions and for %c.
7097 * lisp.h (doprnt): Restore prototype.
7099 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7102 * Makefile.in (base_obj): Add back doprnt.o.
7104 * deps.mk (doprnt.o): Add back prerequisites.
7105 (callint.o): Depend on character.h.
7107 * eval.c (internal_lisp_condition_case): Include the handler
7108 representation in the error message.
7109 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7110 when breaking from the loop.
7112 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7114 * callint.c (Fcall_interactively): When displaying error message
7115 about invalid control letter, pass the character's codepoint, not
7116 a pointer to its multibyte form. Improve display of the character
7117 in octal and display also its hex code.
7119 * character.c (char_string): Use %x to display the (unsigned)
7120 codepoint of an invalid character, to avoid displaying a bogus
7123 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7124 `error', not SYMBOL_NAME itself.
7126 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7127 character arguments to `error'.
7129 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7130 to `error' in error message about FINAL_CHAR argument. Make sure
7131 FINAL_CHAR is a character, and use %c when it is passed as
7132 argument to `error'.
7134 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7136 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7138 * w32.c: Include <time.h>.
7139 (sys_localtime): New function.
7141 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7143 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7145 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7147 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7149 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7152 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7154 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7155 gl_state.e_property when gl_state.object is Qt.
7157 * insdel.c (make_gap_larger): Remove limitation of buffer size
7160 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7162 * xdisp.c (lookup_glyphless_char_display)
7163 (produce_glyphless_glyph): Handle cons cell entry in
7164 glyphless-char-display.
7165 (Vglyphless_char_display): Document it.
7167 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7168 glyphless-char-display.
7170 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7172 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7174 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7176 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7177 definition for no-X builds.
7179 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7181 Static checks with GCC 4.6.0 and non-default toolkits.
7183 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7185 * process.c (keyboard_bit_set): Define only if SIGIO.
7186 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7187 (send_process): Repair possible setjmp clobbering.
7189 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7191 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7193 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7195 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7196 Define only if needed.
7198 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7199 by pacifying GCC about it. Maybe it's time to retire it?
7200 * xfaces.c (USG, __TIMEVAL__): Likewise.
7202 * dispextern.h (struct redisplay_interface): Rename param
7204 * termhooks.h (struct terminal): Likewise.
7205 * xterm.c (xembed_send_message): Likewise.
7207 * insdel.c (make_gap_smaller): Define only if
7208 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7210 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7213 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7214 so that we aren't warned about unused symbols.
7216 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7218 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7220 * xfns.c (x_real_positions): Mark locals as initialized.
7222 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7224 * xterm.c: Fix problems found by static analysis with other toolkits.
7225 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7226 (x_dispatch_event): Declare static if USE_GTK, and
7227 define if USE_GTK || USE_X_TOOLKIT.
7228 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7229 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7230 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7231 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7233 * xmenu.c (menu_help_callback): Pointer type fixes.
7234 Use const pointers when pointing at readonly data. Avoid pointer
7236 (FALSE): Remove unused macro.
7237 (update_frame_menubar): Remove unused decl.
7239 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7241 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7242 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7243 (single_menu_item): Rename local to avoid shadowing.
7245 * keyboard.c (make_lispy_event): Remove unused local var.
7247 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7248 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7250 * bitmaps: Change bitmaps from unsigned char back to the X11
7251 compatible char. Avoid the old compiler warnings about
7252 out-of-range initializers by using, for example, '\xab' rather
7255 * xgselect.c (xgselect_initialize): Check vs interface
7256 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7258 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7260 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7261 to read-only memory.
7263 * fns.c (vector): Remove; this old hack is no longer needed.
7265 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7267 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7269 * xrdb.c (x_load_resources): Omit unused local.
7271 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7272 (x_window): Rename locals to avoid shadowing.
7273 (USG): Use the kludged USG macro, to pacify gcc.
7275 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7276 (x_term_init): Remove local to avoid shadowing.
7278 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7280 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7281 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7283 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7285 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7287 Fix regex.c, syntax.c and friends for buffers > 2GB.
7288 * syntax.h (struct gl_state_s): Declare character position members
7291 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7293 * textprop.c (verify_interval_modification, interval_of):
7294 Declare arguments EMACS_INT.
7296 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7299 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7301 * indent.c (Fvertical_motion): Local variable it_start is now
7304 * regex.c (re_match, re_match_2, re_match_2_internal)
7305 (bcmp_translate, regcomp, regexec, print_double_string)
7306 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7307 (re_compile_pattern, re_exec): Declare arguments and local
7308 variables `size_t' and `ssize_t' and return values `regoff_t', as
7310 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7311 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7312 <compile_stack_type>: `size' and `avail' are now `size_t'.
7314 * regex.h <regoff_t>: Use ssize_t, not int.
7315 (re_search, re_search_2, re_match, re_match_2): Arguments that
7316 specify buffer/string position and length are now ssize_t and
7317 size_t. Return type is regoff_t.
7319 2011-04-16 Ben Key <bkey76@gmail.com>
7321 * nsfont.m: Fixed bugs in ns_get_family and
7322 ns_descriptor_to_entity that were caused by using free to
7323 deallocate memory blocks that were allocated by xmalloc (via
7324 xstrdup). This caused Emacs to crash when compiled with
7325 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7326 --enable-checking=xmallocoverrun). xfree is now used to
7327 deallocate these memory blocks.
7329 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7331 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7333 emacs_write: Accept and return EMACS_INT for sizes.
7334 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7336 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7337 Accept and return EMACS_INT.
7338 (emacs_gnutls_write): Return the number of bytes written on
7340 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7341 (emacs_read, emacs_write): Remove check for negative size, as the
7342 Emacs source code has been audited now.
7343 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7344 (emacs_read, emacs_write): Use it.
7345 * process.c (send_process): Adjust to the new signatures of
7346 emacs_write and emacs_gnutls_write. Do not attempt to store
7347 a byte offset into an 'int'; it might overflow.
7348 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7350 * sound.c: Don't assume sizes fit in 'int'.
7351 (struct sound_device.period_size, alsa_period_size):
7352 Return EMACS_INT, not int.
7353 (struct sound_device.write, vox_write, alsa_write):
7354 Accept EMACS_INT, not int.
7355 (wav_play, au_play): Use EMACS_INT to store sizes and to
7356 record read return values.
7358 2011-04-15 Ben Key <bkey76@gmail.com>
7360 * keyboard.c (Qundefined): Don't declare static since it is used
7362 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7363 static since they are used in nsfont.m.
7365 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7367 * process.c (Qprocessp): Don't declare static.
7368 * lisp.h (Qprocessp): Declare again.
7370 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7372 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7374 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7376 Improve C-level modularity by making more things 'static'.
7378 Don't publish debugger-only interfaces to other modules.
7379 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7380 (verify_bytepos, count_markers): Move decls to the only modules
7382 * region-cache.h (pp_cache): Likewise.
7383 * window.h (check_all_windows): Likewise.
7384 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7386 * sysdep.c (croak): Now static, if
7387 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7388 * syssignal.h (croak): Declare only if not static.
7390 * alloc.c (refill_memory_reserve): Now static if
7391 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7392 * lisp.h (refill_memory_reserve): Declare only if not static.
7394 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7395 Define only if USE_LUCID.
7397 * xrdb.c (x_customization_string, x_rm_string): Now static.
7399 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7400 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7402 * xdisp.c (draw_row_with_mouse_face): Now static.
7403 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7405 * window.h (check_all_windows): Mark externally visible.
7407 * window.c (window_deletion_count): Now static.
7409 * undo.c: Make symbols static if they're not exported.
7410 (last_undo_buffer, last_boundary_position, pending_boundary):
7413 * textprop.c (interval_insert_behind_hooks): Now static.
7414 (interval_insert_in_front_hooks): Likewise.
7416 * term.c: Make symbols static if they're not exported.
7417 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7418 (max_frame_lines, tty_set_terminal_modes):
7419 (tty_reset_terminal_modes, tty_turn_off_highlight):
7420 (get_tty_terminal): Now static.
7421 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7422 * termhooks.h (term_mouse_moveto): Do not declare if
7424 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7425 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7427 * sysdep.c: Make symbols static if they're not exported.
7428 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7430 (sigprocmask_set, full_mask): Remove; unused.
7431 (wait_debugging): Mark as visible.
7432 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7433 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7435 * syntax.c (syntax_temp): Define only if !__GNUC__.
7437 * sound.c (current_sound_device, current_sound): Now static.
7439 * search.c (searchbufs, searchbuf_head): Now static.
7441 * scroll.c (scroll_cost): Remove; unused.
7442 * dispextern.h (scroll_cost): Remove decl.
7444 * region-cache.h (pp_cache): Mark as externally visible.
7446 * process.c: Make symbols static if they're not exported.
7447 (process_tick, update_tick, create_process, chan_process):
7448 (Vprocess_alist, proc_buffered_char, datagram_access):
7449 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7450 (deactivate_process): Mark defn as static, as well as decl.
7451 * lisp.h (create_process): Remove decl.
7452 * process.h (chan_process, Vprocess_alist): Remove decls.
7454 * print.c: Make symbols static if they're not exported.
7455 (print_depth, new_backquote_output, being_printed, print_buffer):
7456 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7457 (print_interval, print_number_index, initial_stderr_stream):
7459 * lisp.h (Fprinc): Remove decl.
7460 (debug_output_compilation_hack): Mark as externally visible.
7462 * sysdep.c (croak): Move decl from here to syssignal.h.
7463 * syssignal.h (croak): Put it here, so the API can be checked when
7464 'croak' is called from dissociate_if_controlling_tty.
7466 * minibuf.c: Make symbols static if they're not exported.
7467 (minibuf_save_list, choose_minibuf_frame): Now static.
7468 * lisp.h (choose_minibuf_frame): Remove decl.
7470 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7472 * lread.c: Make symbols static if they're not exported.
7473 (read_objects, initial_obarray, oblookup_last_bucket_number):
7475 (make_symbol): Remove; unused.
7476 * lisp.h (initial_obarray, make_symbol): Remove decls.
7478 * keyboard.c: Make symbols static if they're not exported.
7479 (single_kboard, recent_keys_index, total_keys, recent_keys):
7480 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7481 (this_single_command_key_start, echoing, last_auto_save):
7482 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7483 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7484 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7485 (Vlispy_mouse_stem, double_click_count):
7487 (force_auto_save_soon): Define only if SIGDANGER.
7488 (ignore_mouse_drag_p): Now static if
7489 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7490 (print_help): Remove; unused.
7491 (stop_character, last_timer_event): Mark as externally visible.
7492 * keyboard.h (ignore_mouse_drag_p): Declare only if
7493 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7494 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7495 * lisp.h (echoing): Remove decl.
7496 (force_auto_save_soon): Declare only if SIGDANGER.
7497 * xdisp.c (redisplay_window): Simplify code, to make it more
7498 obvious that ignore_mouse_drag_p is not accessed if !defined
7499 USE_GTK && !defined HAVE_NS.
7501 * intervals.c: Make symbols static if they're not exported.
7502 (merge_properties_sticky, merge_interval_right, delete_interval):
7504 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7506 * insdel.c: Make symbols static if they're not exported.
7507 However, leave prepare_to_modify_buffer alone. It's never
7508 called from outside this function, but that appears to be a bug.
7509 (combine_after_change_list, combine_after_change_buffer):
7510 (adjust_after_replace, signal_before_change): Now static.
7511 (adjust_after_replace_noundo): Remove; unused.
7512 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7513 (signal_before_change): Remove decls.
7515 * indent.c (val_compute_motion, val_vmotion): Now static.
7517 * image.c: Make symbols static if they're not exported.
7518 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7520 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7521 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7523 * fringe.c (standard_bitmaps): Now static.
7524 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7526 * frame.c: Make symbols static if they're not exported.
7527 (x_report_frame_params, make_terminal_frame): Now static.
7528 (get_frame_param): Now static, unless HAVE_NS.
7529 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7530 (x_get_resource_string): Remove; not used.
7531 * frame.h (make_terminal_frame, x_report_frame_params):
7532 (x_get_resource_string); Remove decls.
7533 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7534 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7536 * font.c, fontset.c: Make symbols static if they're not exported.
7537 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7538 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7539 * font.c (font_close_object): Now static.
7540 * font.h (font_close_object): Remove.
7541 * fontset.c (FONTSET_OBJLIST): Remove.
7542 (free_realized_fontset) #if-0 the body, which does nothing.
7543 (face_suitable_for_char_p): #if-0, as it's never called.
7544 * fontset.h (face_suitable_for_char_p): Remove decl.
7545 * xfaces.c (face_at_string_position):
7546 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7547 since 0 is always ASCII.
7549 * fns.c (weak_hash_tables): Now static.
7551 * fileio.c: Make symbols static if they're not exported.
7552 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7553 (Vwrite_region_annotation_buffers): Now static.
7555 * eval.c: Make symbols static if they're not exported.
7556 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7557 * lisp.h (backtrace_list): Remove decl.
7559 * emacs.c: Make symbols static if they're not exported.
7560 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7561 (fatal_error_code, fatal_error_signal_hook, standard_args):
7563 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7564 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7565 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7566 * lisp.h (fatal_error_signal_hook): Remove decl.
7567 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7569 * editfns.c: Move a (normally-unused) function to its only use.
7570 * editfns.c, lisp.h (get_operating_system_release): Remove.
7571 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7572 worth the hassle of breaking this out.
7574 * xterm.c: Make symbols static if they're not exported.
7575 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7576 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7577 (x_destroy_window, x_delete_display):
7579 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7580 (x_mouse_leave): Remove; unused.
7581 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7582 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7583 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7585 (x_mouse_leave): Declare only if WINDOWSNT.
7586 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7587 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7590 * ftxfont.c: Make symbols static if they're not exported.
7591 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7593 * font.h (ftxfont_driver): Likewise.
7595 * xfns.c: Make symbols static if they're not exported.
7596 (x_last_font_name, x_display_info_for_name):
7597 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7598 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7599 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7600 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7601 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7602 (last_show_tip_args): Now static.
7603 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7604 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7605 (x_screen_planes): Remove; unused.
7606 * dispextern.h (x_screen_planes): Remove decl.
7608 * dispnew.c: Make symbols static if they're not exported.
7609 * dispextern.h (redraw_garbaged_frames, scrolling):
7610 (increment_row_positions): Remove.
7611 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7612 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7614 (redraw_garbaged_frames): Remove; unused.
7616 * xfaces.c: Make symbols static if they're not exported.
7617 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7619 * xterm.h (defined_color): Remove decls.
7620 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7621 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7622 (menu_face_changed_default, defined_color, free_realized_face):
7623 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7624 (ascii_face_of_lisp_face): Remove; unused.
7626 * xdisp.c: Make symbols static if they're not exported.
7627 * dispextern.h (scratch_glyph_row, window_box_edges):
7628 (glyph_to_pixel_coords, set_cursor_from_row):
7629 (get_next_display_element, set_iterator_to_next):
7630 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7631 (show_mouse_face): Remove decls
7632 * frame.h (message_buf_print): Likewise.
7633 * lisp.h (pop_message, set_message, check_point_in_composition):
7635 * xterm.h (set_vertical_scroll_bar): Likewise.
7636 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7637 (message_buf_print, scratch_glyph_row, displayed_buffer):
7638 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7639 (get_next_display_element, show_mouse_face, window_box_edges):
7640 (frame_to_window_pixel_xy, check_point_in_composition):
7641 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7642 (glyph_to_pixel_coords): Remove; unused.
7644 * dired.c (file_name_completion): Now static.
7646 * dbusbind.c (xd_in_read_queued_messages): Now static.
7648 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7649 * data.c (circular_list_error): Remove.
7651 * commands.h (last_point_position, last_point_position_buffer):
7652 (last_point_position_window): Remove decls.
7653 * keyboard.c: Make these variables static.
7655 * coding.h (coding, code_convert_region, encode_coding_gap):
7657 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7658 (iso_code_class, detect_coding, code_convert_region): Now static.
7659 (encode_coding_gap): Remove; unused.
7661 * chartab.c (chartab_chars, chartab_bits): Now static.
7663 * charset.h (charset_iso_8859_1): Remove decl.
7664 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7667 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7668 * ccl.c (Vccl_program_table): Now static.
7669 (check_ccl_update): Remove; unused.
7671 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7672 * category.h: ... from here.
7673 * category.c (check_category_table, set_category_set): Now static.
7675 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7676 * lisp.h: Remove these decls.
7678 * buffer.c (buffer_count): Remove unused var.
7680 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7681 so that it's not optimized away.
7682 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7683 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7684 exported only to the debugger.
7686 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7687 * atimer.h (run_all_atimers): Remove; not exported.
7689 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7690 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7691 was inaccessible from Lisp.
7692 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7693 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7695 alloc.c: Import and export fewer symbols, and remove unused items.
7696 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7698 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7699 it's not optimized away by whole-program optimization.
7700 (message_enable_multibyte, free_misc): Remove.
7701 (catchlist, handlerlist, mark_backtrace):
7702 Declare only if BYTE_MARK_STACK.
7703 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7704 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7705 (message_enable_multibyte): Remove decl.
7706 (free_misc, interval_free_list, float_block, float_block_index):
7707 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7708 (cons_free_list, last_marked_index):
7710 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7711 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7712 (mark_backtrace): Define only if BYTE_MARK_STACK.
7713 * xdisp.c (message_enable_multibyte): Now static.
7715 Declare Lisp_Object Q* variables to be 'static' if not exported.
7716 This makes it easier for human readers (and static analyzers)
7717 to see whether these variables are used from other modules.
7718 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7719 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7720 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7721 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7722 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7723 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7724 * xmenu.c, xselect.c:
7725 Declare Q* vars static if they are not used in other modules.
7726 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7727 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7728 Remove decls of unexported vars.
7729 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7731 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7733 Make Emacs functions such as Fatom 'static' by default.
7734 This makes it easier for human readers (and static analyzers)
7735 to see whether these functions can be called from other modules.
7736 DEFUN now defines a static function. To make the function external
7737 so that it can be used in other C modules, use the new macro DEFUE.
7738 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7739 (Finit_image_library):
7740 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7741 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7742 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7743 Remove decls, since these functions are now static.
7744 (Funintern, Fget_internal_run_time): New decls, since these functions
7745 were already external.
7747 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7748 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7749 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7750 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7751 * keyboard.c, keymap.c, lread.c:
7752 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7753 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7754 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7755 Mark functions with DEFUE instead of DEFUN,
7756 if they are used in other modules.
7757 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7758 decls for now-static functions.
7759 * buffer.h (Fdelete_overlay): Remove decl.
7760 * callproc.c (Fgetenv_internal): Mark as internal.
7761 * composite.c (Fremove_list_of_text_properties): Remove decl.
7762 (Fcomposition_get_gstring): New forward static decl.
7763 * composite.h (Fcomposite_get_gstring): Remove decl.
7764 * dired.c (Ffile_attributes): New forward static decl.
7765 * doc.c (Fdocumntation_property): New forward static decl.
7766 * eval.c (Ffetch_bytecode): New forward static decl.
7767 (Funintern): Remove extern decl; now in .h file where it belongs.
7768 * fileio.c (Fmake_symbolic_link): New forward static decl.
7769 * image.c (Finit_image_library): New forward static decl.
7770 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7771 * intervals.h (Fprevious_property_change):
7772 (Fremove_list_of_text_properties): Remove decls.
7773 * keyboard.c (Fthis_command_keys): Remove decl.
7774 (Fcommand_execute): New forward static decl.
7775 * keymap.c (Flookup_key): New forward static decl.
7776 (Fcopy_keymap): Now static.
7777 * keymap.h (Flookup_key): Remove decl.
7778 * process.c (Fget_process): New forward static decl.
7779 (Fprocess_datagram_address): Mark as internal.
7780 * syntax.c (Fsyntax_table_p): New forward static decl.
7781 (skip_chars): Remove duplicate decl.
7782 * textprop.c (Fprevious_property_change): New forward static decl.
7783 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7785 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7786 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7788 * editfns.c (Fformat): Remove unreachable code.
7790 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7792 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7795 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7797 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7798 when at ZV. (Bug#8487)
7800 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7802 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7804 * keyboard.c (parse_tool_bar_item): Likewise.
7805 * sound.c (sound_cleanup, alsa_close): Likewise.
7806 * termcap.c (tgetent): Likewise.
7807 * xfns.c (x_default_font_parameter): Likewise.
7808 * xsettings.c (read_and_apply_settings): Likewise.
7810 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7811 (overrun_check_free): Protoize.
7813 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7815 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7816 since callers should never pass a negative size.
7817 Change the signature to match that of plain 'read' and 'write'; see
7818 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7819 * lisp.h: Update prototypes of emacs_write and emacs_read.
7821 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7823 * xdisp.c (redisplay_window): Don't try to determine the character
7824 position of the scroll margin if the window start point w->startp
7825 is outside the buffer's accessible region. (Bug#8468)
7827 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7829 Fix write-region and its subroutines for buffers > 2GB.
7830 * fileio.c (a_write, e_write): Modify declaration of arguments and
7831 local variables to support buffers larger than 2GB.
7832 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7834 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7835 argument, local variables, and return value.
7837 * lisp.h: Update prototypes of emacs_write and emacs_read.
7839 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7841 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7843 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7845 Fix more problems found by GCC 4.6.0's static checks.
7847 * xdisp.c (vmessage): Use a better test for character truncation.
7849 * charset.c (load_charset_map): <, not <=, for optimization,
7850 and to avoid potential problems with integer overflow.
7851 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7852 * casetab.c (set_identity, shuffle): Likewise.
7853 * editfns.c (Fformat): Likewise.
7854 * syntax.c (skip_chars): Likewise.
7856 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7857 This also lets GCC 4.6.0 generate slightly better loop code.
7859 * callint.c (Fcall_interactively): <, not <=, for optimization.
7860 (Fcall_interactively): Count the number of arguments produced,
7861 not the number of arguments given. This is simpler and lets GCC
7862 4.6.0 generate slightly better code.
7864 * ftfont.c: Distingish more carefully between FcChar8 and char.
7865 The previous code passed unsigned char * to a functions like
7866 strlen and xstrcasecmp that expect char *, which does not
7867 conform to the C standard.
7868 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7869 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7870 char * when the C standard requires it.
7872 * keyboard.c (read_char): Remove unused var.
7874 * eval.c: Port to Windows vsnprintf (Bug#8435).
7876 (SIZE_MAX): Define if the headers do not.
7877 (verror): Do not give up if vsnprintf returns a negative count.
7878 Instead, grow the buffer. This ports to Windows vsnprintf, which
7879 does not conform to C99. Problem reported by Eli Zaretskii.
7880 Also, simplify the allocation scheme, by avoiding the need for
7881 calling realloc, and removing the ALLOCATED variable.
7883 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7885 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7886 But keep the doprint source code for now, as we might revamp it
7887 and use it again (Bug#8435).
7888 * lisp.h (doprnt): Remove.
7889 * Makefile.in (base_obj): Remove doprnt.o.
7890 * deps.mk (doprnt.o): Remove.
7892 error: Print 32- and 64-bit integers portably (Bug#8435).
7893 Without this change, on typical 64-bit hosts error ("...%d...", N)
7894 was used to print both 32- and 64-bit integers N, which relied on
7896 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7897 * lisp.h (error, verror): Mark as printf-like functions.
7898 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7899 Report overflow in size calculations when allocating printf buffer.
7900 Do not truncate output string at its first null byte.
7901 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7902 Truncate the output at a character boundary, since vsnprintf does not
7904 * charset.c (check_iso_charset_parameter): Convert internal
7905 character to string before calling 'error', since %c now has the
7907 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7908 overflow when computing char to be passed to 'error'. Do not
7909 pass Lisp_Object to 'error'; pass the integer instead.
7910 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7911 formatted with plain %d.
7913 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7915 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7917 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7919 * xterm.c (x_catch_errors): Remove duplicate declaration.
7921 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7923 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7925 2011-04-10 Jim Meyering <meyering@redhat.com>
7927 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7928 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7929 return ssize_t not "int", and use size_t as the buffer length.
7930 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7931 * gnutls.h: Update declarations.
7932 * process.c (read_process_output): Use ssize_t, to match.
7933 (send_process): Likewise.
7935 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7937 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7939 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7941 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7942 Use unsigned char, to match FcChar8 type definition.
7944 * xterm.c (handle_one_xevent):
7945 * xmenu.c (create_and_show_popup_menu):
7946 * xselect.c (x_decline_selection_request)
7947 (x_reply_selection_request): Avoid type-punned deref of X events.
7949 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7951 Fix some uses of `int' instead of EMACS_INT.
7952 * search.c (string_match_1, fast_string_match)
7953 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7954 (scan_buffer, find_next_newline_no_quit)
7955 (find_before_next_newline, search_command, Freplace_match)
7956 (Fmatch_data): Make some `int' variables be EMACS_INT.
7958 * xdisp.c (display_count_lines): 3rd argument and return value now
7959 EMACS_INT. All callers changed.
7960 (pint2hrstr): Last argument is now EMACS_INT.
7962 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7963 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7964 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7965 (decode_coding_utf_16, decode_coding_emacs_mule)
7966 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7967 (decode_coding_ccl, decode_coding_charset)
7968 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7969 (decode_coding_iso_2022, decode_coding_emacs_mule)
7970 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7971 <char_offset, last_offset>: Declare EMACS_INT.
7972 (encode_coding_utf_8, encode_coding_utf_16)
7973 (encode_coding_emacs_mule, encode_invocation_designation)
7974 (encode_designation_at_bol, encode_coding_iso_2022)
7975 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7976 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7978 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7979 (encode_invocation_designation): Last argument P_NCHARS is now
7981 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7982 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7984 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7987 * ccl.c (Fccl_execute_on_string): Declare some variables
7990 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7992 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7994 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7996 * process.c (Fformat_network_address): Doc fix.
7998 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8000 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8002 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8004 * keyboard.c (read_char): Call Lisp function help-form-show,
8005 instead of using internal_with_output_to_temp_buffer.
8006 (Qhelp_form_show): New var.
8007 (syms_of_keyboard): Use DEFSYM macro.
8009 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8011 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8013 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8015 * process.c (Flist_processes): Remove to Lisp.
8016 (list_processes_1): Delete.
8018 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8020 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8022 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8024 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8026 Fix more problems found by GCC 4.6.0's static checks.
8028 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8030 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8032 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8034 * xdisp.c (vmessage): Mark as a printf-like function.
8036 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8038 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8040 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8041 printf-like functions.
8042 (tiff_load): Add casts to remove these marks before passing them
8043 to system-supplied API.
8045 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8047 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8048 This avoids several warnings with gcc -Wstrict-overflow.
8049 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8050 directly, rather than having caller test rule sign. This avoids
8051 some unnecessary tests.
8052 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8053 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8054 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8056 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8057 (xfont_open): Avoid unnecessary tests.
8059 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8061 * composite.h, composite.c (composition_gstring_put_cache):
8062 Use EMACS_INT, not int, for length.
8064 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8065 breaking out part of COMPOSITION_DECODE_RULE.
8066 (COMPOSITION_DECODE_RULE): Use it.
8067 * composite.c (get_composition_id): Remove unused local vars,
8068 by using the new macro.
8070 * textprop.c (set_text_properties_1): Change while to do-while,
8071 since the condition is always true at first.
8073 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8074 (interval_deletion_adjustment): Return unsigned value.
8077 * process.c (list_processes_1, create_pty, read_process_output):
8078 (exec_sentinel): Remove vars that were set but not used.
8079 (create_pty): Remove unnecessary "volatile"s.
8080 (Fnetwork_interface_info): Avoid possibility of int overflow.
8081 (read_process_output): Do adaptive read buffering even if carryover.
8082 (read_process_output): Simplify nbytes computation if buffered.
8084 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8086 * syntax.c (scan_words): Remove var that was set but not used.
8087 (update_syntax_table): Use unsigned instead of int.
8089 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8090 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8091 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8093 * print.c (print_error_message): Avoid int overflow.
8095 * font.c (font_list_entities): Redo for clarity,
8096 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8098 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8099 (font_score): Avoid potential overflow in diff calculation.
8101 * fns.c (substring_both): Remove var that is set but not used.
8102 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8104 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8106 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8107 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8108 can always succeed if overflow has undefined behavior.
8110 * search.c (boyer_moore, wordify): Remove vars set but not used.
8111 (wordify): Omit three unnecessary tests.
8113 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8114 All callers changed. This avoids the need for an unused var.
8116 * casefiddle.c (casify_region): Remove var that is set but not used.
8118 * dired.c (file_name_completion): Remove var that is set but not used.
8120 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8122 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8123 (Finsert_file_contents): Remove unnecessary code checking fd.
8125 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8126 Check for integer overflow on size calculations.
8128 * buffer.c (Fprevious_overlay_change): Remove var that is set
8131 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8132 Remove vars that are set but not used.
8133 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8134 (timer_check_2): Mark vars as initialized.
8136 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8138 * image.c (lookup_image): Remove var that is set but not used.
8139 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8141 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8142 that are set but not used.
8144 * xfns.c (make_invisible_cursor): Don't return garbage
8145 if XCreateBitmapFromData fails (Bug#8410).
8147 * xselect.c (x_get_local_selection, x_handle_property_notify):
8148 Remove vars that are set but not used.
8150 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8151 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8153 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8154 Remove var that is set but not used.
8155 (scroll_bar_windows_size): Now size_t, not int.
8156 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8159 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8160 (map_tty_color) [!defined MSDOS]: Likewise.
8162 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8164 * coding.c: Remove vars that are set but not used.
8165 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8166 All callers changed.
8167 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8168 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8169 (decode_coding_charset): Remove vars that are set but not used.
8171 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8172 that is set but not used.
8174 * print.c (print_object): Remove var that is set but not used.
8176 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8177 The gnulib version avoids calling malloc in the usual case,
8178 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8179 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8180 * filelock.c (current_lock_owner): Likewise.
8181 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8182 * sysdep.c: Include allocator.h, careadlinkat.h.
8183 (emacs_no_realloc_allocator): New static constant.
8184 (emacs_readlink): New function.
8185 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8186 ../lib/careadlinkat.h.
8188 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8190 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8191 first non-nil return value).
8193 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8195 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8196 if not defined (Bug#8403).
8198 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8200 * xdisp.c (display_count_lines): Remove parameter `start',
8201 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8202 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8203 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8204 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8205 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8206 and thereabouts. All callers changed.
8207 (get_per_char_metric): Remove parameter `f', unused since
8208 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8210 2011-04-02 Jim Meyering <meyering@redhat.com>
8212 do not dereference NULL upon failed strdup
8213 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8214 (ns_get_family): Likewise.
8216 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8218 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8220 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8222 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8225 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8227 Add lexical binding.
8229 * window.c (Ftemp_output_buffer_show): New fun.
8230 (Fsave_window_excursion):
8231 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8233 * lread.c (lisp_file_lexically_bound_p): New function.
8234 (Fload): Bind Qlexical_binding.
8235 (readevalloop): Remove `evalfun' arg.
8236 Bind Qinternal_interpreter_environment.
8237 (Feval_buffer): Bind Qlexical_binding.
8238 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8240 (syms_of_lread): Declare `lexical-binding'.
8242 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8244 * keyboard.c (eval_dyn): New fun.
8245 (menu_item_eval_property): Use it.
8247 * image.c (parse_image_spec): Use Ffunctionp.
8249 * fns.c (concat, mapcar1): Accept byte-code-functions.
8251 * eval.c (Fsetq): Handle lexical vars.
8252 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8253 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8254 (FletX, Flet): Obey lexical binding.
8255 (Fcommandp): Handle closures.
8256 (Feval): New `lexical' arg.
8257 (eval_sub): New function extracted from Feval. Use it almost
8258 everywhere where Feval was used. Look up vars in lexical env.
8260 (Ffunctionp): Move from subr.el.
8261 (Ffuncall): Handle closures.
8262 (apply_lambda): Remove `eval_flags'.
8263 (funcall_lambda): Handle closures and new byte-code-functions.
8264 (Fspecial_variable_p): New function.
8265 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8266 but without exporting it to Lisp.
8268 * doc.c (Fdocumentation, store_function_docstring):
8269 * data.c (Finteractive_form): Handle closures.
8271 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8274 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8276 (exec_byte_code): New function extracted from Fbyte_code to handle new
8277 calling convention for byte-code-functions. Add new byte-codes.
8279 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8281 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8283 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8285 * xdisp.c (redisplay_internal): Fix prototype.
8287 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8289 * xdisp.c (SCROLL_LIMIT): New macro.
8290 (try_scrolling): Use it when setting scroll_limit.
8291 Limit scrolling to 100 screen lines.
8292 (redisplay_window): Even when falling back on "recentering",
8293 position point in the window according to scroll-conservatively,
8294 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8296 (try_scrolling): When point is above the window, allow searching
8297 as far as scroll_max, or one screenful, to compute vertical
8298 distance from PT to the scroll margin position. This prevents
8299 try_scrolling from unnecessarily failing when
8300 scroll-conservatively is set to a value slightly larger than the
8301 window height. Clean up the case of PT below the margin at bottom
8302 of window: scroll_max can no longer be INT_MAX. When aggressive
8303 scrolling is in use, don't let point enter the opposite scroll
8304 margin as result of the scroll.
8305 (syms_of_xdisp) <scroll-conservatively>: Document the
8306 threshold of 100 lines for never-recentering scrolling.
8308 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8310 * dispextern.h (move_it_by_lines):
8311 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8312 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8313 (message_log_check_duplicate): Remove parameters `prev_bol' and
8314 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8315 (redisplay_internal): Remove parameter `preserve_echo_area',
8316 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8318 * indent.c (Fvertical_motion):
8319 * window.c (window_scroll_pixel_based, Frecenter):
8320 Don't pass `need_y_p' to `move_it_by_lines'.
8322 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8324 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8325 steal a few bits to be more compact.
8326 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8327 Remove unneeded casts.
8329 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8331 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8333 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8334 binding" message (bug#7967).
8336 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8338 Fix more problems found by GCC 4.6.0's static checks.
8340 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8341 Remove unused local var.
8343 * editfns.c (Fmessage_box): Remove unused local var.
8345 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8346 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8347 Omit unused local vars.
8348 * window.c (shrink_windows): Omit unused local var.
8349 * menu.c (digest_single_submenu): Omit unused local var.
8350 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8351 Omit unused local var.
8353 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8354 Don't assume string length fits in int.
8355 (keyremap_step, read_key_sequence): Use size_t for sizes.
8356 (read_key_sequence): Don't check last_real_key_start redundantly.
8358 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8359 instead of alloca (Bug#8344).
8361 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8362 (Fbacktrace_frame): Don't assume nframes fits in int.
8364 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8366 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8369 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8371 * cm.c (calccost): Turn while-do into do-while, for clarity.
8373 * keyboard.c (syms_of_keyboard): Use the same style as later
8374 in this function when indexing through an array. This also
8375 works around GCC bug 48267.
8377 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8379 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8381 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8382 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8384 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8385 This avoids undefined behavior on integer overflow, and is a bit
8386 more convenient anyway since it is compared to a size_t variable.
8388 Variadic C functions now count arguments with size_t, not int.
8389 This avoids an unnecessary limitation on 64-bit machines, which
8390 caused (substring ...) to crash on large vectors (Bug#8344).
8391 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8392 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8393 All variadic functions and their callers changed accordingly.
8394 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8395 * data.c (arith_driver, float_arith_driver): Likewise.
8396 * editfns.c (general_insert_function): Likewise.
8397 * eval.c (struct backtrace.nargs, interactive_p)
8398 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8399 (funcall_lambda, mark_backtrace): Likewise.
8400 * fns.c (concat): Likewise.
8401 * frame.c (x_set_frame_parameters): Likewise.
8402 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8403 0 if not found, not -1. All callers changed.
8405 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8406 (stack_copy_size): Now size_t, not int.
8407 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8409 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8411 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8412 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8413 All callers changed.
8415 * lisp.h (multibyte_char_to_unibyte):
8416 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8417 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8418 * character.h (CHAR_TO_BYTE8):
8419 * cmds.c (internal_self_insert):
8420 * editfns.c (general_insert_function):
8421 * keymap.c (push_key_description):
8422 * search.c (Freplace_match):
8423 * xdisp.c (message_dolog, set_message_1): All callers changed.
8425 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8427 * keyboard.c (safe_run_hook_funcall): New function.
8428 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8429 don't set the hook to nil, but remove the offending function instead.
8430 (Qcommand_hook_internal): Remove, unused.
8431 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8432 Vcommand_hook_internal.
8434 * eval.c (enum run_hooks_condition): Remove.
8435 (funcall_nil, funcall_not): New functions.
8436 (run_hook_with_args): Call each function through a `funcall' argument.
8437 Remove `cond' argument, now redundant.
8438 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8439 (Frun_hook_with_args_until_failure): Adjust accordingly.
8440 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8442 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8444 * dispextern.h (string_buffer_position): Remove declaration.
8446 * print.c (strout): Remove parameter `multibyte', unused since
8447 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8449 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8450 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8451 All callers changed.
8453 * w32.c (_wsa_errlist): Use braces for struct initializers.
8455 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8456 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8457 All callers changed.
8458 (string_buffer_position): Likewise. Also, make static (it's never
8459 used outside xdisp.c).
8460 (cursor_row_p): Remove parameter `w', unused since
8461 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8462 (decode_mode_spec): Remove parameter `precision', introduced during
8463 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8464 All callers changed.
8466 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8468 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8470 2011-03-27 Anders Lindgren <andlind@gmail.com>
8472 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8473 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8474 (ns_update_auto_hide_menu_bar): New functions.
8475 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8476 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8477 ns_constrain_all_frames.
8478 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8479 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8481 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8483 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8485 2011-03-27 Glenn Morris <rgm@gnu.org>
8487 * syssignal.h: Replace RETSIGTYPE with void.
8488 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8489 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8490 Replace SIGTYPE with void everywhere.
8491 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8492 * s/template.h (SIGTYPE): Remove commented out definition.
8494 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8496 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8497 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8499 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8501 * w32.c (read_unc_volume): Use parameter `henum', instead of
8502 global variable `wget_enum_handle'.
8504 * keymap.c (describe_vector): Remove parameters `indices' and
8505 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8506 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8508 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8510 * keyboard.c (timer_check): Remove parameter `do_it_now',
8511 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8512 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8513 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8515 * keyboard.c (read_char):
8516 * w32menu.c (w32_menu_display_help):
8517 * xmenu.c (show_help_event, menu_help_callback):
8518 Adjust calls to `show_help_echo'.
8520 * gtkutil.c (xg_maybe_add_timer):
8521 * keyboard.c (readable_events):
8522 * process.c (wait_reading_process_output):
8523 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8525 * insdel.c (adjust_markers_gap_motion):
8526 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8527 (gap_left, gap_right): Don't call it.
8529 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8531 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8532 incurred during fontification.
8534 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8536 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8537 (DEFVAR_PER_BUFFER): Don't pass it.
8539 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8540 (scrolling_window): Don't pass it.
8542 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8544 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8546 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8548 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8549 of variables specific to SELinux and computation of `encoded_absname'.
8551 * image.c (XPutPixel): Remove unused variable `height'.
8553 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8555 * unexw32.c (get_section_info): Remove unused variable `section'.
8557 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8558 (system_process_attributes): Remove unused variable `sess'.
8559 (sys_read): Remove unused variable `err'.
8561 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8562 (w32_wnd_proc): Remove unused variable `isdead'.
8563 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8564 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8565 (x_create_tip_frame): Remove unused variable `tem'.
8567 * w32inevt.c (w32_console_read_socket):
8568 Remove unused variable `no_events'.
8570 * w32term.c (x_draw_composite_glyph_string_foreground):
8571 Remove unused variable `width'.
8573 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8575 * w32term.c (x_set_glyph_string_clipping):
8576 Don't pass uninitialized region to CombineRgn.
8578 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8580 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8581 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8582 (Fx_close_connection): Remove unused variable `i'.
8584 * w32font.c (w32font_draw): Return number of glyphs.
8585 (w32font_open_internal): Remove unused variable `i'.
8586 (w32font_driver): Add missing initializer.
8588 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8589 (fill_in_menu): Remove unused variable `items_added'.
8591 * w32term.c (last_mouse_press_frame): Remove static global variable.
8592 (w32_clip_to_row): Remove unused variable `f'.
8593 (x_delete_terminal): Remove unused variable `i'.
8595 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8596 (NOTHING): Remove unused static global variable.
8597 (uniscribe_check_otf): Remove unused variable `table'.
8598 (uniscribe_font_driver): Add missing initializers.
8600 2011-03-23 Julien Danjou <julien@danjou.info>
8602 * term.c (Fsuspend_tty, Fresume_tty):
8603 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8604 * window.c (temp_output_buffer_show):
8605 * insdel.c (signal_before_change):
8606 * frame.c (Fhandle_switch_frame):
8607 * fileio.c (Fdo_auto_save):
8608 * emacs.c (Fkill_emacs):
8609 * editfns.c (save_excursion_restore):
8610 * cmds.c (internal_self_insert):
8611 * callint.c (Fcall_interactively):
8612 * buffer.c (Fkill_all_local_variables):
8613 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8615 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8616 unconditionally since it does the check itself.
8618 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8620 Fix more problems found by GCC 4.5.2's static checks.
8622 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8623 the first time through the loop, since we know p0 < p1 then.
8624 This also avoids a gcc -Wstrict-overflow warning.
8626 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8627 leading to a memory leak, possible in functions like
8628 load_charset_map_from_file that can allocate an unbounded number
8629 of objects (Bug#8318).
8631 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8632 that could (at least in theory) be that large.
8634 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8635 This is less likely to overflow, and avoids undefined behavior if
8636 overflow does occur. All callers changed. Use strtoul to scan
8637 for the unsigned long integer.
8638 (pint2hrstr): Simplify and tune code slightly.
8639 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8641 * scroll.c (do_scrolling): Work around GCC bug 48228.
8642 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8644 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8645 This also avoids a warning with gcc -Wstrict-overflow.
8646 (validate_x_resource_name): Simplify count usage.
8647 This also avoids a warning with gcc -Wstrict-overflow.
8649 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8652 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8654 * process.c (Fmake_network_process): Use socklen_t, not int,
8655 where POSIX says socklen_t is required in portable programs.
8656 This fixes a porting bug on hosts like 64-bit HP-UX, where
8657 socklen_t is wider than int (Bug#8277).
8658 (Fmake_network_process, server_accept_connection):
8659 (wait_reading_process_output, read_process_output):
8662 * process.c: Rename or move locals to avoid shadowing.
8663 (list_processes_1, Fmake_network_process):
8664 (read_process_output_error_handler, exec_sentinel_error_handler):
8665 Rename or move locals.
8666 (Fmake_network_process): Define label "retry_connect" only if needed.
8667 (Fnetwork_interface_info): Fix pointer signedness.
8668 (process_send_signal): Add cast to avoid pointer signedness problem.
8669 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8670 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8672 Make tparam.h and terminfo.c consistent.
8673 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8674 Include tparam.h instead, since it declares them.
8675 * cm.h (PC): Remove extern decl; tparam.h now does this.
8676 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8677 * terminfo.c: Include tparam.h, to check interfaces.
8678 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8679 (tparam): Adjust signature to match interface in tparam.h;
8680 this removes some undefined behavior. Check that outstring and len
8681 are zero, which they always are with Emacs.
8682 * tparam.h (PC, BC, UP): New extern decls.
8684 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8685 (xftfont_open): Rename locals to avoid shadowing.
8687 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8688 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8689 (OTF_TAG_SYM): Omit macro if not needed.
8690 (ftfont_list): Remove unused local.
8691 (get_adstyle_property, ftfont_pattern_entity):
8692 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8693 Rename locals to avoid shadowing.
8695 * xfont.c (xfont_list_family): Mark var as initialized.
8697 * xml.c (make_dom): Now static.
8699 * composite.c (composition_compute_stop_pos): Rename local to
8701 (composition_reseat_it): Remove unused locals.
8702 (find_automatic_composition, composition_adjust_point): Likewise.
8703 (composition_update_it): Mark var as initialized.
8704 (find_automatic_composition): Mark vars as initialized,
8705 with a FIXME (Bug#8290).
8707 character.h: Rename locals to avoid shadowing.
8708 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8709 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8710 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8711 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8714 * textprop.c (property_change_between_p): Remove; unused.
8716 * intervals.c (interval_start_pos): Now static.
8718 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8720 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8721 Rename locals to avoid shadowing.
8723 * sound.c (wav_play, au_play, Fplay_sound_internal):
8724 Fix pointer signedness.
8725 (alsa_choose_format): Remove unused local var.
8726 (wav_play): Initialize a variable to 0, to prevent undefined
8727 behavior (Bug#8278).
8729 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8731 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8733 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8734 clobbering (Bug#8298).
8735 * sysdep.c (sys_subshell): Likewise.
8736 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8738 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8739 This should get cleaned up, so that child_setup has the
8740 same signature on all platforms.
8742 * callproc.c (call_process_cleanup): Now static.
8743 (relocate_fd): Rename locals to avoid shadowing.
8745 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8747 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8748 not to be necessary, and produces flickering.
8750 2011-03-20 Glenn Morris <rgm@gnu.org>
8752 * config.in: Remove file.
8754 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8756 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8757 are now in src/globals.h.
8758 (syms_of_minibuf): Remove spurious & from previous change.
8760 2011-03-20 Leo Liu <sdl.web@gmail.com>
8762 * minibuf.c (completing-read-function): New variable.
8763 (completing-read-default): Rename from completing-read.
8764 (completing-read): Call completing-read-function.
8766 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8768 * xfaces.c (Fx_load_color_file):
8769 Read color file from absolute filename (bug#8250).
8771 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8773 * makefile.w32-in: Update dependencies.
8775 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8777 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8779 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8781 Fix more problems found by GCC 4.5.2's static checks.
8783 * process.c (make_serial_process_unwind, send_process_trap):
8784 (sigchld_handler): Now static.
8786 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8787 That way, the code declares only the vars that it needs.
8788 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8789 * s/cygwin.h (PTY_ITERATION): Likewise.
8790 * s/darwin.h (PTY_ITERATION): Likewise.
8791 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8793 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8794 * process.c (allocate_pty): Don't declare stb unless it's needed.
8796 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8797 (CONSTANTLIM): Remove; unused.
8798 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8799 Define only if needed.
8801 * unexelf.c (unexec): Name an expression,
8802 to avoid gcc -Wbad-function-cast warning.
8803 Use a different way to cause a compilation error if anyone uses
8804 n rather than nn, a way that does not involve shadowing.
8805 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8807 * deps.mk (unexalpha.o): Remove; unused.
8809 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8810 * unexec.h: New file.
8811 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8812 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8814 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8815 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8816 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8817 Change as necessary to match prototype in unexec.h.
8819 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8821 (back_comment, skip_chars): Mark vars as initialized.
8823 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8824 Rename locals to avoid shadowing.
8826 * lread.c (read1): Rewrite so as not to use empty "else".
8827 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8829 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8831 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8832 warning when compiling print.c.
8834 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8835 instead of using an uninitialized var.
8836 (font_sort_entities): Mark var as initialized.
8838 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8840 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8841 pointers to constants.
8842 (font_parse_fcname): Remove unused vars.
8843 (font_delete_unmatched): Now static.
8844 (font_get_spec): Remove; unused.
8845 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8846 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8847 Rename or move locals to avoid shadowing.
8849 * fns.c (require_nesting_list, require_unwind): Now static.
8850 (Ffillarray): Rename locals to avoid shadowing.
8852 * floatfns.c (domain_error2): Define only if needed.
8853 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8855 * alloc.c (mark_backtrace): Move decl from here ...
8856 * lisp.h: ... to here, so that it can be checked.
8858 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8859 (Fdefvar): Rewrite so as not to use empty "else".
8860 (lisp_indirect_variable): Name an expression,
8861 to avoid gcc -Wbad-function-cast warning.
8862 (Fdefvar): Rename locals to avoid shadowing.
8864 * callint.c (quotify_arg, quotify_args): Now static.
8865 (Fcall_interactively): Rename locals to avoid shadowing.
8866 Use const pointer when appropriate.
8868 * lisp.h (get_system_name, get_operating_system_release):
8869 Move decls here, to check interfaces.
8870 * process.c (get_operating_system_release): Move decl to lisp.h.
8871 * xrdb.c (get_system_name): Likewise.
8872 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8873 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8874 some of which prompt warnings from gcc -Wbad-function-cast.
8875 (Fformat_time_string, Fencode_time, Finsert_char):
8876 (Ftranslate_region_internal, Fformat):
8877 Rename or remove local vars to avoid shadowing.
8878 (Ftranslate_region_internal): Mark var as initialized.
8880 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8883 * lisp.h (eassert): Check that the argument compiles, even if
8884 ENABLE_CHECKING is not defined.
8886 * data.c (Findirect_variable): Name an expression, to avoid
8887 gcc -Wbad-function-cast warning.
8888 (default_value, arithcompare, arith_driver, arith_error): Now static.
8889 (store_symval_forwarding): Rename local to avoid shadowing.
8890 (Fmake_variable_buffer_local, Fmake_local_variable):
8891 Mark variables as initialized.
8892 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8894 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8895 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8896 Rename locals to avoid shadowing.
8897 (mark_stack): Move local variables into the #ifdef region where
8899 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8900 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8902 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8903 (GC_STRING_CHARS): Remove; not used.
8904 (Fmemory_limit): Cast sbrk's returned value to char *.
8906 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8907 avoids undefined behavior in theory.
8909 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8911 Use functions, not macros, for up- and down-casing (Bug#8254).
8912 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8913 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8914 to use the following functions instead of these macros.
8915 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8916 EMACS_INT, since callers assume the returned value fits in int.
8917 (upcase1): Likewise, for UPCASE_TABLE.
8918 (uppercasep, lowercasep, upcase): New static inline functions.
8919 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8920 the race-condition problem in the old DOWNCASE.
8922 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8923 Rename locals to avoid shadowing.
8924 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8925 (regex_compile, re_search_2, re_match_2_internal):
8926 Remove unused local vars.
8927 (FREE_VAR): Rewrite so as not to use empty "else",
8928 which gcc can warn about.
8929 (regex_compile, re_match_2_internal): Mark locals as initialized.
8930 (RETALLOC_IF): Define only if needed.
8931 (WORDCHAR_P): Likewise. This one is never needed, but is used
8932 only in a comment talking about a compiler bug, so put inside
8933 the #if 0 of that comment.
8934 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8935 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8938 * search.c (boyer_moore): Rename locals to avoid shadowing.
8939 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8940 (PREV_CHAR_BOUNDARY): Likewise.
8942 * search.c (simple_search): Remove unused var.
8944 * dired.c (compile_pattern): Move decl from here ...
8945 * lisp.h: ... to here, so that it can be checked.
8946 (struct re_registers): New forward decl.
8948 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8950 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8952 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8953 Rename locals to avoid shadowing.
8954 (Fvertical_motion): Mark locals as initialized.
8956 * casefiddle.c (casify_object, casify_region): Now static.
8957 (casify_region): Mark local as initialized.
8959 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8961 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8962 New macros, so that the caller can use some names other than
8963 gcpro1, gcpro2, etc.
8964 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8966 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8967 argument, for consistency with GCPRO2_VAR, etc: it is now the
8968 prefix of the variable, not the variable itself. All uses
8970 * dired.c (directory_files_internal, file_name_completion):
8971 Rename locals to avoid shadowing.
8973 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8974 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8975 dired.c's scmp function, had undefined behavior.
8976 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8977 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8978 * buffer.h: ... to here, because these macros use current_buffer,
8979 and the new implementation with inline functions needs to have
8980 current_buffer in scope now, rather than later when the macros
8982 (downcase, upcase1): New static inline functions.
8983 (DOWNCASE, UPCASE1): Reimplement using these functions.
8984 This avoids undefined behavior in expressions like
8985 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8986 from race conditions in accessing the global variables
8987 case_temp1 and case_temp2.
8988 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8989 * lisp.h (case_temp1, case_temp2): Remove their decls.
8990 * character.h (ASCII_CHAR_P): Move from here ...
8991 * lisp.h: ... to here, so that the inline functions mentioned
8994 * dired.c (directory_files_internal_unwind): Now static.
8996 * fileio.c (file_name_as_directory, directory_file_name):
8997 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8999 (file_name_as_directory): Use const pointers when appropriate.
9000 (Fexpand_file_name): Likewise. In particular, newdir might
9001 point at constant storage, so make it a const pointer.
9002 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9003 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9005 (Fset_file_times, Finsert_file_contents, auto_save_error):
9006 Rename locals to avoid shadowing.
9008 * minibuf.c (choose_minibuf_frame_1): Now static.
9009 (Ftry_completion, Fall_completions): Rename or remove locals
9012 * marker.c (bytepos_to_charpos): Remove; unused.
9014 * lisp.h (verify_bytepos, count_markers): New decls,
9015 so that gcc does not warn that these functions aren't declared.
9017 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9018 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9019 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9020 (copy_text): Remove unused local var.
9022 * filelock.c (within_one_second): Now static.
9023 (lock_file_1): Rename local to avoid shadowing.
9025 * buffer.c (fix_overlays_before): Mark locals as initialized.
9026 (fix_start_end_in_overlays): Likewise. This function should be
9027 simplified by using pointers-to-pointers, but that's a different
9029 (switch_to_buffer_1): Now static.
9030 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9031 (report_overlay_modification): Rename locals to avoid shadowing.
9033 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9034 Fix pointer signedness issue.
9035 (sys_subshell): Mark local as volatile if checking for lint,
9036 to suppress a gcc -Wclobbered warning that does not seem to be right.
9037 (MAXPATHLEN): Define only if needed.
9039 * process.c (serial_open, serial_configure): Move decls from here ...
9040 * systty.h: ... to here, so that they can be checked.
9042 * fns.c (get_random, seed_random): Move extern decls from here ...
9043 * lisp.h: ... to here, so that they can be checked.
9045 * sysdep.c (reset_io): Now static.
9046 (wait_for_termination_signal): Remove; unused.
9048 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9049 (copy_keymap_item, append_key, push_text_char_description):
9051 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9052 (DENSE_TABLE_SIZE): Remove; unused.
9053 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9054 (describe_map_tree):
9055 Rename locals to avoid shadowing.
9057 * keyboard.c: Declare functions static if they are not used elsewhere.
9058 (echo_char, echo_dash, cmd_error, top_level_2):
9059 (poll_for_input, handle_async_input): Now static.
9060 (read_char, kbd_buffer_get_event, make_lispy_position):
9061 (make_lispy_event, make_lispy_movement, apply_modifiers):
9062 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9063 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9064 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9065 (read_key_sequence, read_char): Mark locals as initialized.
9066 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9068 * keyboard.h (make_ctrl_char): New decl.
9069 (mark_kboards): Move decl here ...
9070 * alloc.c (mark_kboards): ... from here.
9072 * lisp.h (force_auto_save_soon): New decl.
9074 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9075 (DEFINE_DUMMY_FUNCTION): New macro.
9076 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9078 (main): Add casts to avoid warnings
9079 if GCC considers string literals to be constants.
9081 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9083 * dbusbind.c: Pointer signedness fixes.
9084 (xd_signature, xd_append_arg, xd_initialize):
9085 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9086 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9087 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9088 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9090 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9091 if GCC considers string literals to be constants.
9092 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9094 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9096 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9097 (print_preprocess, print_object): New macro to fix last change.
9099 * print.c (print_preprocess): Don't forget font objects.
9101 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9103 * emacs.c (USAGE3): Doc fixes.
9105 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9107 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9110 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9112 * lisp.h (VWindow_system, Qfile_name_history):
9113 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9114 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9115 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9117 * w32select.c: Don't #include "keyboard.h".
9118 (run_protected): Add extern declaration for waiting_for_input.
9120 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9121 * w32console.c (detect_input_pending, read_input_pending)
9122 (encode_terminal_code):
9123 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9124 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9125 (w32_system_caret_y, Qfile_name_history):
9126 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9127 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9128 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9129 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9130 * w32proc.c (Qlocal, report_file_error):
9131 * w32term.c (Vwindow_system, updating_frame):
9132 * w32uniscribe.c (initialized, uniscribe_font_driver):
9133 Remove unneeded extern declarations.
9135 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9137 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9139 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9141 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9142 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9143 These macros can no longer be used for assignment.
9145 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9146 Assign struct members directly, instead of using BUF_BEGV etc.
9147 (record_buffer_markers, fetch_buffer_markers): New functions for
9148 recording and fetching special buffer markers.
9149 (set_buffer_internal_1, set_buffer_temp): Use them.
9151 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9153 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9155 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9156 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9158 * xdisp.c (hscroll_window_tree):
9159 (reconsider_clip_changes): Use PT instead of BUF_PT.
9161 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9163 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9164 $(EMACS_ROOT)/lib/intprops.h.
9166 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9168 Fix more problems found by GCC 4.5.2's static checks.
9170 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9171 to unsigned char * to avoid compiler diagnostic.
9172 (xg_free_frame_widgets): Make it clear that a local variable is
9173 needed only if USE_GTK_TOOLTIP.
9174 (gdk_window_get_screen): Make it clear that this macro is needed
9175 only if USE_GTK_TOOLTIP.
9176 (int_gtk_range_get_value): New function, which avoids a diagnostic
9177 from gcc -Wbad-function-cast.
9178 (xg_set_toolkit_scroll_bar_thumb): Use it.
9179 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9180 diagnostic from gcc -Wbad-function-cast.
9181 (get_utf8_string, xg_get_file_with_chooser):
9182 Rename locals to avoid shadowing.
9183 (create_dialog): Move locals to avoid shadowing.
9185 * xgselect.c (xg_select): Remove unused var.
9187 * image.c (four_corners_best): Mark locals as initialized.
9188 (gif_load): Initialize transparent_p to zero (Bug#8238).
9189 Mark another local as initialized.
9190 (my_png_error, my_error_exit): Mark with NO_RETURN.
9192 * image.c (clear_image_cache): Now static.
9193 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9194 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9195 (x_edge_detection): Remove unnecessary cast that
9196 gcc -Wbad-function-cast diagnoses.
9197 (gif_load): Fix pointer signedness.
9198 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9199 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9201 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9203 Improve quality of tests for time stamp overflow.
9204 For example, without this patch (encode-time 0 0 0 1 1
9205 1152921504606846976) returns the obviously-bogus value (-948597
9206 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9207 reports time overflow. See
9208 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9209 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9210 * editfns.c: Include limits.h and intprops.h.
9211 (TIME_T_MIN, TIME_T_MAX): New macros.
9212 (time_overflow): Move earlier, to before first use.
9213 (hi_time, lo_time): New functions, for an accurate test for
9215 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9216 (Fget_internal_run_time): Don't assume time_t fits in int.
9217 (make_time): Use list2 instead of Fcons twice.
9218 (Fdecode_time): More accurate test for out-of-range times.
9219 (check_tm_member): New function.
9220 (Fencode_time): Use it, to test for out-of-range times.
9221 (lisp_time_argument): Don't rely on undefined left-shift and
9222 right-shift behavior when checking for time stamp overflow.
9224 * editfns.c (time_overflow): New function, refactoring common code.
9225 (Fformat_time_string, Fdecode_time, Fencode_time):
9226 (Fcurrent_time_string): Use it.
9228 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9229 * dired.c (make_time): Move to ...
9230 * editfns.c (make_time): ... here.
9231 * systime.h: Note the move.
9233 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9235 * fringe.c (update_window_fringes): Remove unused variables.
9237 * unexmacosx.c (copy_data_segment): Also copy __got section.
9240 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9242 * termcap.c [MSDOS]: Include "msdos.h".
9243 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9244 Constify `char *' arguments and their references according to
9245 prototypes in tparam.h.
9247 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9249 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9250 Adapt all references accordingly.
9252 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9254 2011-03-11 Tom Tromey <tromey@redhat.com>
9256 * buffer.c (syms_of_buffer): Remove obsolete comment.
9258 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9260 * termhooks.h (encode_terminal_code): Declare prototype.
9262 * msdos.c (encode_terminal_code): Don't declare prototype.
9264 * term.c (encode_terminal_code): Now external again, used by
9265 w32console.c and msdos.c.
9267 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9268 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9270 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9272 Fix some minor problems found by GCC 4.5.2's static checks.
9274 * fringe.c (update_window_fringes): Mark locals as initialized
9276 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9278 * alloc.c (mark_fringe_data): Move decl from here ...
9279 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9280 to check its interface.
9281 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9283 * fontset.c (free_realized_fontset): Now static.
9284 (Fset_fontset_font): Rename local to avoid shadowing.
9285 (fontset_font): Mark local as initialized.
9286 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9288 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9290 * xselect.c (x_disown_buffer_selections): Remove; not used.
9291 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9292 (x_own_selection, Fx_disown_selection_internal): Rename locals
9294 (x_handle_dnd_message): Remove local to avoid shadowing.
9296 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9297 so that the caller can use some name other than gcpro1.
9298 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9299 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9300 (Fx_backspace_delete_keys_p):
9301 Use them to avoid shadowing, and rename vars to avoid shadowing.
9302 (x_decode_color, x_set_name, x_window): Now static.
9303 (Fx_create_frame): Add braces to silence GCC warning.
9304 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9305 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9306 Remove unused locals.
9307 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9308 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9309 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9312 * xterm.h (x_mouse_leave): New decl.
9314 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9315 Remove unused functions.
9316 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9317 (x_calc_absolute_position): Now static.
9318 (XTread_socket): Don't define label "out" unless it's used.
9319 Don't declare local "event" unless it's used.
9320 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9321 unless they are used.
9322 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9323 (x_fatal_error_signal): Remove; not used.
9324 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9325 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9326 (x_error_catcher, x_connection_closed, x_error_handler):
9327 (x_error_quitter, xembed_send_message, x_iconify_frame):
9328 (my_log_handler): Rename locals to avoid shadowing.
9329 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9330 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9332 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9333 Rename or move locals to avoid shadowing.
9334 (tty_defined_color, merge_face_heights): Now static.
9335 (free_realized_faces_for_fontset): Remove; not used.
9336 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9337 does not deduce is never used uninitialized.
9338 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9339 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9341 * terminal.c (store_terminal_param): Now static.
9343 * xmenu.c (menu_highlight_callback): Now static.
9344 (set_frame_menubar): Remove unused local.
9345 (xmenu_show): Rename parameter to avoid shadowing.
9346 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9347 since they might point to immutable storage.
9348 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9349 since it's unused otherwise.
9351 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9352 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9353 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9354 avoids a gcc -Wuninitialized diagnostic.
9355 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9356 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9357 does not deduce are never used uninitialized.
9359 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9361 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9362 * window.c (window_loop, size_window):
9363 (run_window_configuration_change_hook, enlarge_window): Likewise.
9365 * window.c (display_buffer): Now static.
9366 (size_window): Mark variables that gcc -Wuninitialized
9367 does not deduce are never used uninitialized.
9368 * window.h (check_all_windows): New decl, to forestall
9369 gcc -Wmissing-prototypes diagnostic.
9370 * dispextern.h (bidi_dump_cached_states): Likewise.
9372 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9374 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9376 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9377 and to avoid gcc -Wuninitialized warning.
9378 (load_charset_map): Mark variables that gcc -Wuninitialized
9379 does not deduce are never used uninitialized.
9380 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9382 * coding.c (coding_set_source, coding_set_destination):
9383 Use "else { /* comment */ }" rather than "else /* comment */;"
9384 for clarity, and to avoid gcc -Wempty-body warning.
9385 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9386 a block, when the outer 'i' will do.
9387 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9388 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9389 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9390 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9391 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9392 Rename locals to avoid shadowing.
9393 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9394 * coding.c (emacs_mule_char, encode_invocation_designation):
9395 Now static, since they're not used elsewhere.
9396 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9397 (decode_coding_object, encode_coding_object, detect_coding_system):
9398 (decode_coding_emacs_mule): Mark variables that gcc
9399 -Wuninitialized does not deduce are never used uninitialized.
9400 (detect_coding_iso_2022): Initialize a local variable that might
9401 be used uninitialized. Leave a FIXME because it's not clear that
9402 this initialization is needed. (Bug#8211)
9403 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9404 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9405 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9406 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9407 Remove unused macros.
9409 * category.c (hash_get_category_set): Remove unused local var.
9410 (copy_category_table): Now static, since it's not used elsewhere.
9411 * character.c (string_count_byte8): Likewise.
9413 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9414 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9416 * chartab.c (copy_sub_char_table): Now static, since it's not used
9418 (sub_char_table_ref_and_range, char_table_ref_and_range):
9419 Rename locals to avoid shadowing.
9420 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9422 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9423 (BIDI_BOB): Remove unused macro.
9425 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9426 deduce are never used uninitialized.
9427 * term.c (encode_terminal_code): Likewise.
9429 * term.c (encode_terminal_code): Now static. Remove unused local.
9431 * tparam.h: New file.
9432 * term.c, tparam.h: Include it.
9433 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9434 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9435 Move these decls to tparam.h, and make them agree with what
9436 is actually in tparam.c. The previous trick of using incompatible
9437 decls in different modules does not conform to the C standard.
9438 All callers of tparam changed to use tparam's actual API.
9439 * tparam.c (tparam1, tparam, tgoto):
9440 Use const pointers where appropriate.
9442 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9443 * cm.h (struct cm): Likewise.
9444 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9445 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9446 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9447 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9448 (turn_on_face, init_tty): Likewise.
9449 * termchar.h (struct tty_display_info): Likewise.
9451 * term.c (term_mouse_position): Rename local to avoid shadowing.
9453 * alloc.c (mark_ttys): Move decl from here ...
9454 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9456 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9458 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9460 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9462 * search.c (compile_pattern_1): Remove argument regp, unused since
9463 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9464 (compile_pattern): Don't pass it.
9466 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9468 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9469 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9471 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9473 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9475 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9476 gdk_window_get_screen, gdk_window_get_geometry,
9477 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9478 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9479 (xg_get_pixbuf_from_pixmap): New function.
9480 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9481 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9482 Call xg_get_pixbuf_from_pixmap instead of
9483 gdk_pixbuf_get_from_drawable.
9484 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9485 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9486 (xg_check_special_colors): Use GtkStyleContext and its functions
9488 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9489 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9490 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9491 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9492 Call gtk_widget_get_preferred_size.
9493 (xg_frame_resized): gdk_window_get_geometry only takes 5
9495 (xg_win_to_widget, xg_event_is_for_menubar):
9496 Call gdk_x11_window_lookup_for_display.
9497 (xg_set_widget_bg): New function.
9498 (delete_cb): New function.
9499 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9500 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9501 (xg_set_background_color): Call xg_set_widget_bg.
9502 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9503 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9504 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9505 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9507 (update_frame_tool_bar): Call gtk_widget_hide.
9508 (xg_initialize): Use GDK_KEY_g.
9510 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9512 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9514 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9515 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9516 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9518 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9520 * w32xfns.c (select_palette): Check success of RealizePalette against
9521 GDI_ERROR, not zero.
9523 See ChangeLog.11 for earlier changes.
9529 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9531 This file is part of GNU Emacs.
9533 GNU Emacs is free software: you can redistribute it and/or modify
9534 it under the terms of the GNU General Public License as published by
9535 the Free Software Foundation, either version 3 of the License, or
9536 (at your option) any later version.
9538 GNU Emacs is distributed in the hope that it will be useful,
9539 but WITHOUT ANY WARRANTY; without even the implied warranty of
9540 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9541 GNU General Public License for more details.
9543 You should have received a copy of the GNU General Public License
9544 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.