| blob | b154e722707de6dc55e70a3f4dbf9e95ae2e2692 |
1 ;;; checkdoc.el --- check documentation strings for style requirements
3 ;; Copyright (C) 1997-1998, 2001-2013 Free Software Foundation, Inc.
5 ;; Author: Eric M. Ludlam <zappo@gnu.org>
6 ;; Version: 0.6.2
7 ;; Keywords: docs, maint, lisp
9 ;; This file is part of GNU Emacs.
11 ;; GNU Emacs is free software: you can redistribute it and/or modify
12 ;; it under the terms of the GNU General Public License as published by
13 ;; the Free Software Foundation, either version 3 of the License, or
14 ;; (at your option) any later version.
16 ;; GNU Emacs is distributed in the hope that it will be useful,
17 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
18 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19 ;; GNU General Public License for more details.
21 ;; You should have received a copy of the GNU General Public License
22 ;; along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.
24 ;;; Commentary:
25 ;;
26 ;; The Emacs Lisp manual has a nice chapter on how to write
27 ;; documentation strings. Many stylistic suggestions are fairly
28 ;; deterministic and easy to check for syntactically, but also easy
29 ;; to forget. The main checkdoc engine will perform the stylistic
30 ;; checks needed to make sure these styles are remembered.
31 ;;
32 ;; There are two ways to use checkdoc:
33 ;; 1) Periodically use `checkdoc' or `checkdoc-current-buffer'.
34 ;; `checkdoc' is a more interactive version of
35 ;; `checkdoc-current-buffer'
36 ;; 2) Use `checkdoc-minor-mode' to automatically check your
37 ;; documentation whenever you evaluate Lisp code with C-M-x
38 ;; or [menu-bar emacs-lisp eval-buffer]. Additional key-bindings
39 ;; are also provided under C-c ? KEY
40 ;; (require 'checkdoc)
41 ;; (add-hook 'emacs-lisp-mode-hook 'checkdoc-minor-mode)
42 ;;
43 ;; Using `checkdoc':
44 ;;
45 ;; The commands `checkdoc' and `checkdoc-ispell' are the top-level
46 ;; entry points to all of the different checks that are available. It
47 ;; breaks examination of your Lisp file into four sections (comments,
48 ;; documentation, messages, and spacing) and indicates its current
49 ;; state in a status buffer.
50 ;;
51 ;; The Comments check examines your headers, footers, and
52 ;; various tags (such as "Code:") to make sure that your code is ready
53 ;; for easy integration into existing systems.
54 ;;
55 ;; The Documentation check deals with documentation strings
56 ;; and their elements that help make Emacs easier to use.
57 ;;
58 ;; The Messages check ensures that the strings displayed in the
59 ;; minibuffer by some commands (such as `error' and `y-or-n-p')
60 ;; are consistent with the Emacs environment.
61 ;;
62 ;; The Spacing check cleans up white-space at the end of lines.
63 ;;
64 ;; The interface while working with documentation and messages is
65 ;; slightly different when being run in the interactive mode. The
66 ;; interface offers several options, including the ability to skip to
67 ;; the next error, or back up to previous errors. Auto-fixing is
68 ;; turned off at this stage, but you can use the `f' or `F' key to fix
69 ;; a given error (if the fix is available.)
70 ;;
71 ;; Auto-fixing:
72 ;;
73 ;; There are four classifications of style errors in terms of how
74 ;; easy they are to fix. They are simple, complex, really complex,
75 ;; and impossible. (Impossible really means that checkdoc does not
76 ;; have a fixing routine yet.) Typically white-space errors are
77 ;; classified as simple, and are auto-fixed by default. Typographic
78 ;; changes are considered complex, and the user is asked if they want
79 ;; the problem fixed before checkdoc makes the change. These changes
80 ;; can be done without asking if `checkdoc-autofix-flag' is properly
81 ;; set. Potentially redundant changes are considered really complex,
82 ;; and the user is always asked before a change is inserted. The
83 ;; variable `checkdoc-autofix-flag' controls how these types of errors
84 ;; are fixed.
85 ;;
86 ;; Spell checking text:
87 ;;
88 ;; The variable `checkdoc-spellcheck-documentation-flag' can be set
89 ;; to customize how spell checking is to be done. Since spell
90 ;; checking can be quite slow, you can optimize how best you want your
91 ;; checking done. The default is `defun', which spell checks each time
92 ;; `checkdoc-defun' or `checkdoc-eval-defun' is used. Setting to nil
93 ;; prevents spell checking during normal usage.
94 ;; Setting this variable to nil does not mean you cannot take
95 ;; advantage of the spell checking. You can instead use the
96 ;; interactive functions `checkdoc-ispell-*' to check the spelling of
97 ;; your documentation.
98 ;; There is a list of Lisp-specific words which checkdoc will
99 ;; install into Ispell on the fly, but only if Ispell is not already
100 ;; running. Use `ispell-kill-ispell' to make checkdoc restart it with
101 ;; these words enabled.
102 ;;
103 ;; Checking parameters:
104 ;;
105 ;; You might not always want a function to have its parameters listed
106 ;; in order. When this is the case, put the following comment just in
107 ;; front of the documentation string: "; checkdoc-order: nil" This
108 ;; overrides the value of `checkdoc-arguments-in-order-flag'.
109 ;;
110 ;; If you specifically wish to avoid mentioning a parameter of a
111 ;; function in the doc string (such as a hidden parameter, or a
112 ;; parameter which is very obvious like events), you can have checkdoc
113 ;; skip looking for it by putting the following comment just in front
114 ;; of the documentation string: "; checkdoc-params: (args go here)"
115 ;;
116 ;; Checking message strings:
117 ;;
118 ;; The text that follows the `error' and `y-or-n-p' commands is
119 ;; also checked. The documentation for `error' clearly states some
120 ;; simple style rules to follow which checkdoc will auto-fix for you.
121 ;; `y-or-n-p' also states that it should end in a space. I added that
122 ;; it should end in "? " since that is almost always used.
123 ;;
124 ;; Adding your own checks:
125 ;;
126 ;; You can experiment with adding your own checks by setting the
127 ;; hooks `checkdoc-style-functions' and `checkdoc-comment-style-functions'.
128 ;; Return a string which is the error you wish to report. The cursor
129 ;; position should be preserved.
130 ;;
131 ;; Error errors:
132 ;;
133 ;; Checkdoc does not always flag errors correctly. There are a
134 ;; couple ways you can coax your file into passing all of checkdoc's
135 ;; tests through buffer local variables.
136 ;;
137 ;; The variable `checkdoc-verb-check-experimental-flag' can be used
138 ;; to turn off the check for verb-voice in case you use words that are
139 ;; not semantically verbs, but are still in the incomplete list.
140 ;;
141 ;; The variable `checkdoc-symbol-words' can be a list of words that
142 ;; happen to also be symbols. This is not a problem for one-word
143 ;; symbols, but if you use a hyphenated word that is also a symbol,
144 ;; then you may need this.
145 ;;
146 ;; The symbol `checkdoc-force-docstrings-flag' can be set to nil if
147 ;; you have many undocumented functions you don't wish to document.
148 ;;
149 ;; See the above section "Checking Parameters" for details about
150 ;; parameter checking.
151 ;;
152 ;; Dependencies:
153 ;;
154 ;; This file requires lisp-mnt (Lisp maintenance routines) for the
155 ;; comment checkers.
156 ;;
157 ;; Requires custom for Emacs v20.
159 ;;; TO DO:
160 ;; Hook into the byte compiler on a defun/defvar level to generate
161 ;; warnings in the byte-compiler's warning/error buffer.
162 ;; Better ways to override more typical `eval' functions. Advice
163 ;; might be good but hard to turn on/off as a minor mode.
164 ;;
165 ;;; Maybe Do:
166 ;; Code sweep checks for "forbidden functions", proper use of hooks,
167 ;; proper keybindings, and other items from the manual that are
168 ;; not specifically docstring related. Would this even be useful?
170 ;;; Code:
181 "Support for doc string checking in Emacs Lisp."
187 "String to display in mode line when Checkdoc mode is enabled; nil for none."
193 "Non-nil means attempt auto-fixing of doc strings.
194 If this value is the symbol `query', then the user is queried before
195 any change is made. If the value is `automatic', then all changes are
196 made without asking unless the change is very-complex. If the value
197 is `semiautomatic' or any other value, then simple fixes are made
198 without asking, and complex changes are made by asking the user first.
199 The value `never' is the same as nil, never ask or change anything."
208 Setting this to nil will silently make fixes that require no user
209 interaction. See `checkdoc-autofix-flag' for auto-fixing details."
214 "Non-nil means that all checkable definitions should have documentation.
215 Style guide dictates that interactive functions MUST have documentation,
216 and that it's good but not required practice to make non user visible items
217 have doc strings."
220 ;;;###autoload(put 'checkdoc-force-docstrings-flag 'safe-local-variable 'booleanp)
223 "Non-nil means that files should have a History section or ChangeLog file.
224 This helps document the evolution of, and recent changes to, the package."
227 ;;;###autoload(put 'checkdoc-force-history-flag 'safe-local-variable 'booleanp)
230 "Non-nil means the first line of a docstring may end with a comma.
231 Ordinarily, a full sentence is required. This may be misleading when
232 there is a substantial caveat to the one-line description -- the comma
233 should be used when the first part could stand alone as a sentence, but
234 it indicates that a modifying clause follows."
237 ;;;###autoload(put 'checkdoc-permit-comma-termination-flag 'safe-local-variable 'booleanp)
240 "Non-nil means run Ispell on text based on value.
241 This is automatically set to nil if Ispell does not exist on your
242 system. Possible values are:
244 nil - Don't spell-check during basic style checks.
245 defun - Spell-check when style checking a single defun
246 buffer - Spell-check when style checking the whole buffer
247 interactive - Spell-check during any interactive check.
248 t - Always spell-check"
262 Any more than this and a warning is generated suggesting that the construct
268 "Non-nil means warn if arguments appear out of order.
269 Setting this to nil will mean only checking that all the arguments
270 appear in the proper form in the documentation, not that they are in
271 the same order as they appear in the argument list. No mention is
272 made in the style guide relating to order."
275 ;;;###autoload(put 'checkdoc-arguments-in-order-flag 'safe-local-variable 'booleanp)
280 "Hook run after the standard style check is completed.
281 All functions must return nil or a string representing the error found.
282 Useful for adding new user implemented commands.
284 Each hook is called with two parameters, (DEFUNINFO ENDPOINT).
285 DEFUNINFO is the return value of `checkdoc-defun-info'. ENDPOINT is the
291 "Hook run after the standard comment style check is completed.
292 Must return nil if no errors are found, or a string describing the
301 "Regular expression used to identify a defun.
305 "Non-nil means to attempt to check the voice of the doc string.
306 This check keys off some words which are commonly misused. See the
307 variable `checkdoc-common-verbs-wrong-voice' if you wish to add your own."
312 "Non-nil means generate warnings in a buffer for browsing.
313 Do not set this by hand, use a function like `checkdoc-current-buffer'
317 "A list of symbol names (strings) which also happen to make good words.
318 These words are ignored when unquoted symbols are searched for.
319 This should be set in an Emacs Lisp file's local variables."
322 ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable 'checkdoc-list-of-strings-p)
324 ;;;###autoload
326 ;; this is a function so it might be shared by checkdoc-proper-noun-list
327 ;; and/or checkdoc-ispell-lisp-words in the future
336 ;; "[.!?]" is for noun at end of a sentence, since those chars
337 ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
338 ;; The \" allows it to be the last sentence in a docstring too.
427 )
428 "Alist of common words in the wrong voice and what should be used instead.
429 Set `checkdoc-verb-check-experimental-flag' to nil to avoid this costly
430 and experimental check. Do not modify this list without setting
431 the value of `checkdoc-common-verbs-regexp' to nil which cause it to
436 ;; When dealing with syntax in doc strings, make sure that - are
437 ;; encompassed in words so we can use cheap \\> to get the end of a symbol,
438 ;; not the end of a word in a conglomerate.
440 st)
443 ;;; Compatibility
444 ;;
460 ;;; User level commands
461 ;;
462 ;;;###autoload
464 "Interactively check the entire buffer for style errors.
465 The current status of the check will be displayed in a buffer which
466 the users will view as each check is completed."
472 ;; if the user set autofix to never, then that breaks the
473 ;; obviously requested asking implied by using this function.
474 ;; Set it to paranoia level.
477 'query
478 checkdoc-autofix-flag))
479 tmp)
481 ;; check the comments
489 ;; Check the documentation
496 ;; Check the message text
502 ;; Rogue spacing
511 "Display and update the status buffer for the current checkdoc mode.
512 CHECK is a list of four strings stating the current status of each
513 test; the nth string describes the status of the nth test."
526 ;;;###autoload
528 "Interactively check the current buffer for doc string errors.
529 Prefix argument START-HERE will start the checking from the current
530 point, otherwise the check starts at the beginning of the current
531 buffer. Allows navigation forward and backwards through document
532 errors. Does not check for comment or space warnings.
533 Optional argument SHOWSTATUS indicates that we should update the
534 checkdoc status window instead of the usual behavior."
540 ;; Due to a design flaw, this will never spell check
541 ;; docstrings.
544 ;; This is a workaround to perform spell checking.
547 ;;;###autoload
549 "Interactively check the current buffer for message string errors.
550 Prefix argument START-HERE will start the checking from the current
551 point, otherwise the check starts at the beginning of the current
552 buffer. Allows navigation forward and backwards through document
553 errors. Does not check for comment or space warnings.
554 Optional argument SHOWSTATUS indicates that we should update the
555 checkdoc status window instead of the usual behavior."
561 ;; Due to a design flaw, this will never spell check messages.
564 ;; This is a workaround to perform spell checking.
568 "Interactively loop over all errors that can be found by a given method.
570 If START-HERE is nil, searching starts at the beginning of the current
571 buffer, otherwise searching starts at START-HERE. SHOWSTATUS
572 expresses the verbosity of the search, and whether ending the search
573 will auto-exit this function.
575 FINDFUNC is a symbol representing a function that will position the
576 cursor, and return error message text to present to the user. It is
577 assumed that the cursor will stop just before a major sexp, which will
578 be highlighted to present the user with feedback as to the offending
579 style."
580 ;; Determine where to start the test
583 ;; Assign a flag to spellcheck flag
587 ;; Fetch the error list
591 c)
594 ;; Include whatever function point is in for good measure.
598 ;; The cursor should be just in front of the offending doc string
609 ;; Make sure the whole doc string is visible if possible.
633 ;; Exit condition
635 ;; Request an auto-fix
640 ;; `automatic-then-never' tells the autofix function
641 ;; to only allow one fix to be automatic. The autofix
642 ;; function will then set the flag to 'never, allowing
643 ;; the checker to return a different error.
665 ;; Move to the next error (if available)
671 err-list nil)
677 ;; Go backwards in the list of errors
686 ;; Edit the buffer recursively.
697 err-list nil)
701 ;; Quit checkdoc
704 err-list nil
706 ;; Goofy stuff
717 ""
719 "f, y - auto Fix this warning without asking (if\
722 )
734 returnme))
737 "Interactively spell check doc strings in the current buffer.
738 If START-HERE is nil, searching starts at the beginning of the current
739 buffer, otherwise searching starts at START-HERE."
742 ;; Move point to where we need to start.
744 ;; Include whatever function point is in for good measure.
747 ;; Loop over docstrings.
757 "Interactively spell check messages in the current buffer.
758 If START-HERE is nil, searching starts at the beginning of the current
759 buffer, otherwise searching starts at START-HERE."
762 ;; Move point to where we need to start.
764 ;; Include whatever function point is in for good measure.
767 ;; Loop over message strings.
778 "Find and return the next checkdoc error list, or nil.
779 Only documentation strings are checked.
780 An error list is of the form (WARNING . POSITION) where WARNING is the
781 warning text, and POSITION is the point in the buffer where the error
782 was found. We can use points and not markers because we promise not
783 to edit the buffer before point without re-executing this check.
784 Argument ENABLE-FIX will enable auto-fixing while looking for the next
785 error. This argument assumes that the cursor is already positioned to
786 perform the fix."
797 ;; Quit.. restore position, Other errors, leave alone
799 msg)))
802 "Find and return the next checkdoc message related error list, or nil.
803 Only text for error and `y-or-n-p' strings are checked. See
804 `checkdoc-next-error' for details on the return value.
805 Argument ENABLE-FIX turns on the auto-fix feature. This argument
806 assumes that the cursor is already positioned to perform the fix."
819 ;; Quit.. restore position, Other errors, leave alone
821 msg)))
824 "Enter recursive edit to permit a user to fix some error checkdoc has found.
825 MSG is the error that was found, which is displayed in a help buffer."
840 ;;;###autoload
842 "Evaluate and check documentation for the current buffer.
843 Evaluation is done first because good documentation for something that
844 doesn't work is just not useful. Comments, doc strings, and rogue
845 spacing are all verified."
850 ;;;###autoload
852 "Check current buffer for document, comment, error style, and rogue spaces.
853 With a prefix argument (in Lisp, the argument TAKE-NOTES),
854 store all errors found in a warnings buffer,
855 otherwise stop after the first error."
859 ;; Assign a flag to spellcheck flag
864 checkdoc-autofix-flag))
869 ;; every test is responsible for returning the cursor.
879 ;;;###autoload
881 "Start scanning the current buffer for documentation string style errors.
882 Only documentation strings are checked.
883 Use `checkdoc-continue' to continue checking if an error cannot be fixed.
884 Prefix argument TAKE-NOTES means to collect all the warning messages into
885 a separate buffer."
892 ;; Go back since we can't be here without success above.
894 nil))
896 ;;;###autoload
898 "Find the next doc string in the current buffer which has a style error.
899 Prefix argument TAKE-NOTES means to continue through the whole buffer and
900 save warnings in a separate buffer. Second optional argument START-POINT
901 is the starting location. If this is nil, `point-min' is used instead."
904 ;; Assign a flag to spellcheck flag
909 checkdoc-autofix-flag))
913 ;; If we are taking notes, encompass the whole buffer, otherwise
914 ;; the user is navigating down through the buffer.
916 ;; OK, let's look at the doc string.
929 "Move to the next doc string after point, and return t.
930 Return nil if there are no more doc strings."
932 nil
933 ;; search drops us after the identifier. The next sexp is either
934 ;; the argument list or the value of the variable. skip it.
937 t))
939 ;;;###autoload
941 "Find missing comment sections in the current Emacs Lisp file.
942 Prefix argument TAKE-NOTES non-nil means to save warnings in a
943 separate buffer. Otherwise print a message. This returns the error
944 if there is one."
958 e))
960 ;;;###autoload
962 "Find extra spaces at the end of lines in the current file.
963 Prefix argument TAKE-NOTES non-nil means to save warnings in a
964 separate buffer. Otherwise print a message. This returns the error
965 if there is one.
966 Optional argument INTERACT permits more interactive fixing."
974 e
980 ;;;###autoload
982 "Scan the buffer for occurrences of the error function, and verify text.
983 Optional argument TAKE-NOTES causes all errors to be logged."
992 e
1000 ;;;###autoload
1002 "Evaluate the current form with `eval-defun' and check its documentation.
1003 Evaluation is done first so the form will be read before the
1004 documentation is checked. If there is a documentation error, then the display
1005 of what was evaluated will be overwritten by the diagnostic message."
1010 ;;;###autoload
1012 "Examine the doc string of the function or variable under point.
1013 Call `error' if the doc string has problems. If NO-ERROR is
1014 non-nil, then do not call error, but call `message' instead.
1015 If the doc string passes the test, then check the function for rogue white
1016 space at the end of each line."
1021 ;; I found this more annoying than useful.
1022 ;;(if (not no-error)
1023 ;; (message "Cannot check this sexp's doc string."))
1024 nil
1025 ;; search drops us after the identifier. The next sexp is either
1026 ;; the argument list or the value of the variable. skip it.
1045 ;;; Ispell interface for forcing a spell check
1046 ;;
1048 ;;;###autoload
1050 "Check the style and spelling of everything interactively.
1051 Calls `checkdoc' with spell-checking turned on.
1052 Prefix argument TAKE-NOTES is the same as for `checkdoc'"
1057 ;;;###autoload
1059 "Check the style and spelling of the current buffer.
1060 Calls `checkdoc-current-buffer' with spell-checking turned on.
1061 Prefix argument TAKE-NOTES is the same as for `checkdoc-current-buffer'"
1066 ;;;###autoload
1068 "Check the style and spelling of the current buffer interactively.
1069 Calls `checkdoc-interactive' with spell-checking turned on.
1070 Prefix argument TAKE-NOTES is the same as for `checkdoc-interactive'"
1075 ;;;###autoload
1077 "Check the style and spelling of message text interactively.
1078 Calls `checkdoc-message-interactive' with spell-checking turned on.
1079 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-interactive'"
1084 ;;;###autoload
1086 "Check the style and spelling of message text interactively.
1087 Calls `checkdoc-message-text' with spell-checking turned on.
1088 Prefix argument TAKE-NOTES is the same as for `checkdoc-message-text'"
1093 ;;;###autoload
1095 "Check the style and spelling of the current buffer.
1096 Calls `checkdoc-start' with spell-checking turned on.
1097 Prefix argument TAKE-NOTES is the same as for `checkdoc-start'"
1102 ;;;###autoload
1104 "Check the style and spelling of the current buffer after point.
1105 Calls `checkdoc-continue' with spell-checking turned on.
1106 Prefix argument TAKE-NOTES is the same as for `checkdoc-continue'"
1111 ;;;###autoload
1113 "Check the style and spelling of the current buffer's comments.
1114 Calls `checkdoc-comments' with spell-checking turned on.
1115 Prefix argument TAKE-NOTES is the same as for `checkdoc-comments'"
1120 ;;;###autoload
1122 "Check the style and spelling of the current defun with Ispell.
1123 Calls `checkdoc-defun' with spell-checking turned on.
1124 Prefix argument TAKE-NOTES is the same as for `checkdoc-defun'"
1129 ;;; Error Management
1130 ;;
1131 ;; Errors returned from checkdoc functions can have various
1132 ;; features and behaviors, so we need some ways of specifying
1133 ;; them, and making them easier to use in the wacked-out interfaces
1134 ;; people are requesting
1136 "Used to create the return error text returned from all engines.
1137 TEXT is the descriptive text of the error. START and END define the region
1138 it is sensible to highlight when describing the problem.
1139 Optional argument UNFIXABLE means that the error has no auto-fix available.
1141 A list of the form (TEXT START END UNFIXABLE) is returned if we are not
1142 generating a buffered list of errors."
1145 nil)
1149 "Return the text specified in the checkdoc ERR."
1150 ;; string-p part is for backwards compatibility
1154 "Return the start point specified in the checkdoc ERR."
1155 ;; string-p part is for backwards compatibility
1159 "Return the end point specified in the checkdoc ERR."
1160 ;; string-p part is for backwards compatibility
1164 "Return the t if we cannot autofix the error specified in the checkdoc ERR."
1165 ;; string-p part is for backwards compatibility
1168 ;;; Minor Mode specification
1169 ;;
1174 ;; Override some bindings
1180 ;; Add some new bindings under C-c ?
1198 ;; bind our submap into map
1200 map)
1203 ;; Add in a menubar with easy-menu
1206 nil checkdoc-minor-mode-map "Checkdoc Minor Mode Menu"
1212 "---"
1221 checkdoc-ispell-message-interactive t]
1226 buffer-file-name]
1228 "---"
1233 ))
1234 ;; XEmacs requires some weird stuff to add this menu in a minor mode.
1235 ;; What is it?
1237 ;;;###autoload
1239 "Toggle automatic docstring checking (Checkdoc minor mode).
1240 With a prefix argument ARG, enable Checkdoc minor mode if ARG is
1241 positive, and disable it otherwise. If called from Lisp, enable
1242 the mode if ARG is omitted or nil.
1244 In Checkdoc minor mode, the usual bindings for `eval-defun' which is
1245 bound to \\<checkdoc-minor-mode-map>\\[checkdoc-eval-defun] and `checkdoc-eval-current-buffer' are overridden to include
1246 checking of documentation strings.
1249 nil checkdoc-minor-mode-string nil
1252 ;;; Subst utils
1253 ;;
1255 "Run hooks in HOOKVAR with ARGS."
1258 ;; This method was similar to above. We ignore the warning
1259 ;; since we will use the above for future Emacs versions
1263 "Rebuild the contents of `checkdoc-common-verbs-regexp'."
1271 ;; Profiler says this is not yet faster than just calling assoc
1272 ;;(defun checkdoc-word-in-alist-vector (word vector)
1273 ;; "Check to see if WORD is in the car of an element of VECTOR.
1274 ;;VECTOR must be sorted. The CDR should be a replacement. Since the
1275 ;;word list is getting bigger, it is time for a quick bisecting search."
1276 ;; (let ((max (length vector)) (min 0) i
1277 ;; (found nil) (fw nil))
1278 ;; (setq i (/ max 2))
1279 ;; (while (and (not found) (/= min max))
1280 ;; (setq fw (car (aref vector i)))
1281 ;; (cond ((string= word fw) (setq found (cdr (aref vector i))))
1282 ;; ((string< word fw) (setq max i))
1283 ;; (t (setq min i)))
1284 ;; (setq i (/ (+ max min) 2))
1285 ;; )
1286 ;; found))
1288 ;;; Checking engines
1289 ;;
1291 "Return a message string if the current doc string is invalid.
1292 Check for style only, such as the first line always being a complete
1293 sentence, whitespace restrictions, and making sure there are no
1294 hard-coded key-codes such as C-[char] or mouse-[number] in the comment.
1295 See the style guide in the Emacs Lisp manual for more details."
1297 ;; Jump over comments between the last object and the doc string
1306 err
1307 ;; * Every command, function, or variable intended for users to know
1308 ;; about should have a documentation string.
1309 ;;
1310 ;; * An internal variable or subroutine of a Lisp program might as well
1311 ;; have a documentation string. In earlier Emacs versions, you could
1312 ;; save space by using a comment instead of a documentation string,
1313 ;; but that is no longer the case.
1318 ;; Sometimes old code has comments where the documentation should
1319 ;; be. Let's see if we can find the comment, and offer to turn it
1320 ;; into documentation for them.
1336 ;; Our point is at the beginning of the comment!
1337 ;; Insert a quote, then remove the comment chars.
1356 ;; quote any double-quote characters in the comment.
1362 "You should convert this comment to documentation"
1366 "All interactive functions should have documentation"
1367 "All variables and subroutines might as well have a \
1373 err)))
1376 "Return an error list or string if the current doc string is invalid.
1377 Depends on `checkdoc-this-string-valid' to reset the syntax table so that
1378 regexp short cuts work. FP is the function defun information."
1380 ;; Use a marker so if an early check modifies the text,
1381 ;; we won't accidentally lose our place. This could cause
1382 ;; end-of doc string whitespace to also delete the " char.
1388 ;; * *Do not* indent subsequent lines of a documentation string so that
1389 ;; the text is lined up in the source code with the text of the first
1390 ;; line. This looks nice in the source code, but looks bizarre when
1391 ;; users view the documentation. Remember that the indentation
1392 ;; before the starting double-quote is not part of the string!
1400 "Remove this whitespace? "
1402 nil
1404 "Second line should not have indentation"
1407 ;; * Check for '(' in column 0.
1412 "Escape this '('? "
1414 nil
1416 "Open parenthesis in column 0 should be escaped"
1418 ;; * Do not start or end a documentation string with whitespace.
1431 nil
1433 "Documentation strings should not start or end with whitespace"
1434 start end))))
1435 ;; * The first line of the documentation string should consist of one
1436 ;; or two complete sentences that stand on their own as a summary.
1437 ;; `M-x apropos' displays just the first line, and if it doesn't
1438 ;; stand on its own, the result looks bad. In particular, start the
1439 ;; first line with a capital letter and end with a period.
1447 ;; A backslashed double quote at the end of a sentence
1449 ;; We might have to add a period in this case
1452 nil
1457 nil
1459 "First sentence should end with punctuation"
1462 ;; These are ok
1463 nil)
1465 nil)
1467 ;; If it is not a complete sentence, let's see if we can
1468 ;; predict a clever way to make it one.
1473 ;; Here we have found a complete sentence, but no break.
1476 "First line not a complete sentence. Add RET here? "
1487 ;; We can merge these lines! Replace this CR
1488 ;; with a space.
1491 ;; Let's see if there is enough room to draw the next
1492 ;; line's sentence up here. I often get hit w/
1493 ;; auto-fill moving my words around.
1503 "1st line not a complete sentence. Join these lines? "
1506 ;; They said yes. We have more fill work to do...
1515 ;; Continuation of above. Make sure our sentence is capitalized.
1522 t)
1523 nil
1525 "First line should be capitalized"
1527 nil))
1528 ;; * Don't write key sequences directly in documentation strings.
1529 ;; Instead, use the `\\[...]' construct to stand for them.
1534 ;; Find the first key sequence not in a sample
1544 ;; It is not practical to use `\\[...]' very many times, because
1545 ;; display of the documentation string will become slow. So use this
1546 ;; to describe the most important commands in your major mode, and
1547 ;; then use `\\{...}' to display the rest of the mode's keymap.
1555 ;; Ambiguous quoted symbol. When a symbol is both bound and fbound,
1556 ;; and is referred to in documentation, it should be prefixed with
1557 ;; something to disambiguate it. This check must be before the
1558 ;; 80 column check because it will probably break that.
1576 ;; We didn't actually replace anything. Here we find
1577 ;; out what special word form they wish to use as
1578 ;; a prefix.
1581 "Disambiguating Keyword (default variable): "
1593 nil)))
1594 ;; * Format the documentation string so that it fits in an
1595 ;; Emacs window on an 80-column screen. It is a good idea
1596 ;; for most lines to be no wider than 60 characters. The
1597 ;; first line can be wider if necessary to fit the
1598 ;; information that ought to be there.
1607 eol t))
1613 "Some lines are over 80 columns wide"
1615 ;; Here we deviate to tests based on a variable or function.
1616 ;; We must do this before checking for symbols in quotes because there
1617 ;; is a chance that just such a symbol might really be an argument.
1619 ;; This is if we are in a variable
1621 ;; * The documentation string for a variable that is a
1622 ;; yes-or-no flag should start with words such as Non-nil
1623 ;; means..., to make it clear that all non-`nil' values are
1624 ;; equivalent and indicate explicitly what `nil' and non-`nil'
1625 ;; mean.
1626 ;; * If a user option variable records a true-or-false
1627 ;; condition, give it a name that ends in `-flag'.
1629 ;; If the variable has -flag in the name, make sure
1633 "Flag variable doc strings should usually start: Non-nil means"
1635 ;; Don't rename variable to "foo-flag". This is unnecessary
1636 ;; and such names often end up inconvenient when the variable
1637 ;; is later expanded to non-boolean values. --Stef
1638 ;; If the doc string starts with "Non-nil means"
1639 ;; (if (and (looking-at "\"\\*?Non-nil\\s-+means\\s-+")
1640 ;; (not (string-match "-flag$" (car fp))))
1641 ;; (let ((newname
1642 ;; (if (string-match "-p$" (car fp))
1643 ;; (concat (substring (car fp) 0 -2) "-flag")
1644 ;; (concat (car fp) "-flag"))))
1645 ;; (if (checkdoc-y-or-n-p
1646 ;; (format
1647 ;; "Rename to %s and Query-Replace all occurrences? "
1648 ;; newname))
1649 ;; (progn
1650 ;; (beginning-of-defun)
1651 ;; (query-replace-regexp
1652 ;; (concat "\\<" (regexp-quote (car fp)) "\\>")
1653 ;; newname))
1654 ;; (checkdoc-create-error
1655 ;; "Flag variable names should normally end in `-flag'" s
1656 ;; (marker-position e)))))
1657 ;; Done with variables
1658 ))
1660 ;; This if we are in a function definition
1662 ;; * When a function's documentation string mentions the value
1663 ;; of an argument of the function, use the argument name in
1664 ;; capital letters as if it were a name for that value. Thus,
1665 ;; the documentation string of the function `/' refers to its
1666 ;; second argument as `DIVISOR', because the actual argument
1667 ;; name is `divisor'.
1669 ;; Addendum: Make sure they appear in the doc in the same
1670 ;; order that they are found in the arg list.
1680 inopts t)
1685 ;; Require whitespace OR
1686 ;; ITEMth<space> OR
1687 ;; ITEMs<space>
1689 e t)))
1692 ;; If the symbol was not found, let's see if we
1693 ;; can find it with a different capitalization
1694 ;; and see if the user wants to capitalize it.
1698 ;; Require whitespace OR
1699 ;; ITEMth<space> OR
1700 ;; ITEMs<space>
1702 e t))
1706 "If this is the argument `%s', it should appear as %s. Fix? "
1712 ;; It wasn't found at all! Offer to attach this new symbol
1713 ;; to the end of the documentation string.
1716 "Add %s documentation to end of doc string? "
1718 ;; Now do some magic and invent a doc string.
1729 nil)
1732 "Argument `%s' should appear (as %s) in the doc string"
1739 "Arguments occur in the doc string out of order"
1741 ;; * For consistency, phrase the verb in the first sentence of a
1742 ;; documentation string for functions as an imperative.
1743 ;; For instance, use `Return the cons of A and
1744 ;; B.' in preference to `Returns the cons of A and B.'
1745 ;; Usually it looks good to do likewise for the rest of the
1746 ;; first paragraph. Subsequent paragraphs usually look better
1747 ;; if they have proper subjects.
1748 ;;
1749 ;; This is the least important of the above tests. Make sure
1750 ;; it occurs last.
1753 ;; Maybe rebuild the monster-regexp
1757 ;; check string-continuation
1764 checkdoc-common-verbs-regexp
1765 lim t))
1769 checkdoc-common-verbs-wrong-voice))
1779 replace t)
1782 ;; there was a match, but no replace
1786 original replace)
1788 ;; Done with functions
1789 )))
1790 ;;* When a documentation string refers to a Lisp symbol, write it as
1791 ;; it would be printed (which usually means in lower case), with
1792 ;; single-quotes around it. For example: `lambda'. There are two
1793 ;; exceptions: write t and nil without single-quotes. (In this
1794 ;; manual, we normally do use single-quotes for those symbols.)
1799 ;; Ignore manual page references like
1800 ;; git-config(1).
1802 e t))
1804 ;; A . is a \s_ char, so we must remove periods from
1805 ;; sentences more carefully.
1815 ms))
1823 ms))))))
1828 nil)))
1829 ;; t and nil case
1837 nil
1839 "Symbols t and nil should not appear in `...' quotes"
1841 ;; Here is some basic sentence formatting
1843 ;; Here are common proper nouns that should always appear capitalized.
1845 ;; Make sure the doc string has correctly spelled English words
1846 ;; in it. This function is extracted due to its complexity,
1847 ;; and reliance on the Ispell program.
1849 ;; User supplied checks
1851 ;; Done!
1852 )))
1855 "Return a list of details about the current sexp.
1856 It is a list of the form:
1857 (NAME VARIABLE INTERACTIVE NODOCPARAMS PARAMETERS ...)
1858 where NAME is the name, VARIABLE is t if this is a `defvar',
1859 INTERACTIVE is nil if this is not an interactive function, otherwise
1860 it is the position of the `interactive' call, and PARAMETERS is a
1861 string which is the name of each variable in the function's argument
1862 list. The NODOCPARAMS is a sublist of parameters specified by a checkdoc
1863 comment for a given defun. If the first element is not a string, then
1864 the token checkdoc-order: <TOKEN> exists, and TOKEN is a symbol read
1865 from the comment."
1881 ;; The variable spot
1883 ;; Interactive
1888 t)
1889 ret)))
1893 ;; Overload th main obarray so read doesn't intern the
1894 ;; local symbols of the function we are checking.
1895 ;; Without this we end up cluttering the symbol space w/
1896 ;; useless symbols.
1898 ;; Ok, check for checkdoc parameter comment here
1906 t)
1912 t)
1926 sl1)
1927 ret)))
1928 ;; Read the list of parameters, but do not put the symbols in
1929 ;; the standard obarray.
1931 ;; This is because read will intern nil if it doesn't into the
1932 ;; new obarray.
1941 "Return non-nil if the current point is in a code fragment.
1942 A code fragment is identified by an open parenthesis followed by a
1943 symbol which is a valid function or a word in all CAPS, or a parenthesis
1944 that is quoted with the ' character. Only the region from START to LIMIT
1945 is allowed while searching for the bounding parenthesis."
1956 ;; if this string is function bound, we are in
1957 ;; sample code. If it has a - or : character in
1958 ;; the name, then it is probably supposed to be bound
1959 ;; but isn't yet.
1968 The text checked is between START and LIMIT."
1979 "Check all text between BEGIN and END for lower case proper nouns.
1980 These are Emacs centric proper nouns which should be capitalized for
1981 consistency. Return an error list if any are not fixed, but
1982 internally skip over no answers.
1983 If the offending word is in a piece of quoted text, then it is skipped."
1997 ;; surrounded by /, as in a URL or filename: /emacs/
2001 ;; info or url links left alone
2003 help-xref-info-regexp))
2005 help-xref-url-regexp)))
2008 text)
2010 nil
2012 ;; If there is already an error, then generate
2013 ;; the warning output if applicable
2017 "Name %s should appear capitalized as %s"
2019 b e))
2022 "Name %s should appear capitalized as %s"
2024 bb b be e)))))))
2028 "Make sure all sentences have double spaces between BEGIN and END."
2045 ;; piece of an abbreviation
2046 ;; FIXME etc
2051 b e
2052 "There should be two spaces after a period. Fix? "
2054 nil
2056 ;; If there is already an error, then generate
2057 ;; the warning output if applicable
2060 "There should be two spaces after a period"
2061 b e))
2063 "There should be two spaces after a period"
2064 bb b be e)))))))
2067 ;;; Ispell engine
2068 ;;
2072 "Initialize Ispell process (default version) with Lisp words.
2073 The words used are from `checkdoc-ispell-lisp-words'. If `ispell'
2074 cannot be loaded, then set `checkdoc-spellcheck-documentation-flag' to
2075 nil."
2081 ;; This code copied in part from ispell.el Emacs 19.34
2085 ;; Silence byte compiler
2092 "Run the Ispell tools on the doc string between point and END.
2093 Since Ispell isn't Lisp-smart, we must pre-process the doc string
2094 before using the Ispell engine on it."
2096 ;; If the user wants no questions or fixing, then we must
2097 ;; disable spell checking as not useful.
2100 nil
2107 ;; Skip lists describing meta-syntax, or bound variables
2115 ;; This is probably repetitive in most cases, but not always.
2116 nil
2117 ;; Find out how we spell-check this word.
2119 ;; All caps w/ option th, or s tacked on the end
2120 ;; for pluralization or number.
2123 )
2124 nil
2133 ;; Nothing here.
2134 )))))
2136 err))))
2138 ;;; Rogue space checking engine
2139 ;;
2141 "Return a message list if there is a line with white space at the end.
2142 If `checkdoc-autofix-flag' permits, delete that whitespace instead.
2143 If optional arguments START and END are non-nil, bound the check to
2144 this region.
2145 Optional argument INTERACT may permit the user to fix problems on the fly."
2149 ;; If end is nil, it means end of buffer to search anyway
2151 ;; Check for an error if `? ' or `?\ ' is used at the end of a line.
2152 ;; (It's dangerous)
2157 "Don't use `? ' at the end of a line. \
2158 News agents may remove it"
2160 ;; If interactive is passed down, give them a chance to fix things.
2167 ;; Check for, and potentially remove whitespace appearing at the
2168 ;; end of different lines.
2171 ;; There is no documentation in the Emacs Lisp manual about this check,
2172 ;; it is intended to help clean up messy code and reduce the file size.
2174 ;; This is not a complex activity
2178 nil
2181 ;; Return an error and leave the cursor at that spot, or restore
2182 ;; the cursor.
2186 nil)))
2188 ;;; Comment checking engine
2189 ;;
2191 ;; We must load this to:
2192 ;; a) get symbols for compile and
2193 ;; b) determine if we have lm-history symbol which doesn't always exist
2199 "Return a message list if this file does not match the Emacs standard.
2200 This checks for style only, such as the first line, Commentary:,
2201 Code:, and others referenced in the style guide."
2203 nil
2205 ;; Old XEmacs don't have `lm-commentary-mark'
2214 ;; This file has been set up where ERR is a variable. Each check is
2215 ;; asked, and the function will make sure that if the user does not
2216 ;; auto-fix some error, that we still move on to the next auto-fix,
2217 ;; AND we remember the past errors.
2219 err
2220 ;; Lisp Maintenance checks first
2221 ;; Was: (lm-verify) -> not flexible enough for some people
2222 ;; * Summary at the beginning of the file:
2224 ;; This certifies as very complex so always ask unless
2225 ;; it's set to never
2234 nil))
2236 err
2238 ;; * Commentary Section
2245 nil t)
2258 nil nil t)))
2259 nil)
2260 err))
2262 err
2264 ;; * History section. Say nothing if there is a file ChangeLog
2270 nil
2276 nil t)
2288 err))
2290 err
2292 ;; * Code section
2295 pos)
2297 ;; match ";;;###autoload" cookie to keep it with the form
2304 nil t))
2312 nil)
2316 nil)
2317 err))
2319 err
2321 ;; * A footer. Not compartmentalized from lm-verify: too bad.
2322 ;; The following is partially clipped from lm-verify
2330 nil t))
2337 fn fn fe)
2339 err))
2340 ;; The below checks will not return errors if the user says NO
2342 ;; Let's spellcheck the commentary section. This is the only
2343 ;; section that is easy to pick out, and it is also the most
2344 ;; visible section (with the finder).
2350 ;; Since the comments talk about Lisp, use the
2351 ;; specialized spell-checker we also used for doc
2352 ;; strings.
2357 err
2359 ;; Generic Full-file checks (should be comment related)
2361 err))
2362 ;; Done with full file comment checks
2363 err)))
2366 "Return t if point is outside the bounds of a valid sexp."
2373 ;;; `error' and `message' text verifier.
2374 ;;
2376 "Search between BEG and END for a style error with message text.
2377 Optional arguments BEG and END represent the boundary of the check.
2378 The default boundary is the entire buffer."
2385 e))
2388 "Move cursor to the next checkable message string after point.
2389 Return the message classification.
2390 Argument END is the maximum bounds to search in."
2409 nil
2411 return))
2414 "Return or fix errors found in strings passed to a message display function.
2415 According to the documentation for the function `error', the error list
2416 should not end with a period, and should start with a capital letter.
2417 The function `y-or-n-p' has similar constraints.
2418 Argument TYPE specifies the type of question, such as `error or `y-or-n-p."
2419 ;; If type is nil, then attempt to derive it.
2431 ;; From the documentation of the symbol `error':
2432 ;; In Emacs, the convention is that error messages start with a capital
2433 ;; letter but *do not* end with a period. Please follow this convention
2434 ;; for the sake of consistency.
2439 "Capitalize your message text? "
2441 t)))
2443 "Messages should start with a capital letter"
2445 nil)
2446 ;; In general, sentences should have two spaces after the period.
2450 ;; Look for proper nouns in this region too.
2454 ;; Here are message type specific questions.
2461 "Remove period from error? "
2462 ""
2463 t)))
2465 "Error messages should *not* end with a period"
2467 nil)
2468 ;; `y-or-n-p' documentation explicitly says:
2469 ;; It should end in a space; `y-or-n-p' adds `(y or n) ' to it.
2470 ;; I added the ? requirement. Without it, it is unclear that we
2471 ;; ask a question and it appears to be an undocumented style.
2476 nil
2480 ;; If we see a ?, then replace with "? ".
2485 nil
2496 nil
2508 nil
2512 ;; Now, let's just run the spell checker on this guy.
2515 )))
2517 ;;; Auto-fix helper functions
2518 ;;
2520 "Like `y-or-n-p', but pays attention to `checkdoc-autofix-flag'.
2521 Argument QUESTION is the prompt passed to `y-or-n-p'."
2525 nil
2532 "Highlight between START and END and queries the user with QUESTION.
2533 If the user says yes, or if `checkdoc-autofix-flag' permits, replace
2534 the region marked by START and END with REPLACEWITH. If optional flag
2535 COMPLEX is non-nil, then we may ask the user a question. See the
2536 documentation for `checkdoc-autofix-flag' for details.
2538 If a section is auto-replaced without asking the user, this function
2539 will pause near the fixed code so the user will briefly see what
2540 happened.
2542 This function returns non-nil if the text was replaced.
2544 This function will not modify `match-data'."
2561 ;; On the off chance this is automatic, display
2562 ;; the question anyway so the user knows what's
2563 ;; going on.
2575 ret)))
2577 ;;; Warning management
2578 ;;
2592 "Set up the major mode for the buffer containing the list of errors."
2594 checkdoc-output-error-regex-alist)
2596 checkdoc-output-font-lock-keywords))
2599 "The name to use for a checkdoc buffer in the error list."
2605 "Initialize the checkdoc diagnostic buffer for a pass.
2606 Create the header so that the string CHECK-TYPE is displayed as the
2607 function called to create the messages."
2619 "Store POINT and MSG as errors in the checkdoc diagnostic buffer."
2631 "Display the checkdoc diagnostic buffer in a temporary window."
2642 nil)))
2648 ;;; checkdoc.el ends here