1 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
3 * lisp.h: Remove empty conditional.
5 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
7 * lread.c (load_path_check): Now static.
9 Fix some minor --with-ns problems found by static checking.
10 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
11 (x_set_font) [!HAVE_X_WINDOWS]:
12 * image.c (xpm_load_image) [HAVE_NS]:
13 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
14 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
16 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
17 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
18 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
19 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
20 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
21 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
22 Fix pointer signedness problem.
23 * xfaces.c (FRAME_X_FONT_TABLE):
24 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
26 2012-07-07 Glenn Morris <rgm@gnu.org>
28 * lread.c (load_path_check): New function, split from init_lread.
29 (init_lread): Reorganize. Motivation:
30 If EMACSLOADPATH is set, check/warn about that rather than the
31 defaults, which we are not going to use. Hence we can remove
32 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
33 Don't warn if site-lisp directories are missing.
34 If not installed, start from a blank load-path, since
35 PATH_LOADSEARCH refers to the eventual installation directories.
37 2012-07-07 Eli Zaretskii <eliz@gnu.org>
39 Support truncation and continuation glyphs on GUI frames, when
40 fringes are disabled. (Bug#11832)
41 * xdisp.c (init_iterator): Get dimensions of truncation and
42 continuation glyphs even if on GUI frames. Adjust
43 it->last_visible_x on GUI frames when the left or right fringes,
45 (start_display, move_it_in_display_line_to): Handle the case of a
46 GUI frame without a fringe to display continuation or truncation
48 (insert_left_trunc_glyphs): Support GUI frames: make sure
49 truncation glyphs overwrite enough glyphs from the current line to
50 have sufficient space in pixels.
51 (display_line): Support truncation and continuation glyphs on GUI
52 frames. If some spare pixels are left on the line after inserting
53 the truncation glyphs, fill that space with a stretch glyph of a
54 suitably computed width.
56 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
57 produce_glyphs, to support GUI sessions.
59 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
61 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
63 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
65 Do not require float-time's arg to fit in time_t (Bug#11825).
66 This works better on hosts where time_t is unsigned, and where
67 float-time is applied to the (negative) difference between two times.
68 * editfns.c (decode_time_components): Last arg is now double *,
69 not int *, and means to store all the result as a double, without
70 worrying about whether the seconds part fits in time_t.
72 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
74 (Ffloat_time): Do not fail merely because the specified time falls
75 outside of time_t range.
77 2012-07-07 Glenn Morris <rgm@gnu.org>
79 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
80 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
81 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
83 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
85 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
88 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
90 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
92 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
93 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
94 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
95 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
96 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
97 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
99 * xfont.c (compare_font_names): Redo to omit the need for casts.
101 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
103 * xfns.c (Fx_change_window_property): Doc fix.
104 * w32fns.c (Fx_change_window_property): Doc fix.
106 * w32fns.c (Fx_window_property): Accept the same arguments as the
107 X Windows version. Doc fix.
108 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
110 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
111 Eli Zaretskii <eliz@gnu.org>
113 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
114 Windows-specific code from nt/config.nt moved here.
115 Obsolete settings removed.
117 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
119 * process.c: Avoid unnecessary calls to gettime.
120 (wait_reading_process_output): Don't get the time of day
121 when gobbling data immediately and not waiting, as there's no need
122 for it in that case. This removes a FIXME.
124 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
126 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
127 is defined (Bug#11768).
129 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
131 Fix marker debugging code.
132 * marker.c (byte_char_debug_check): Do not perform the check
133 if buffer is not multibyte.
134 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
135 byte_char_debug_check with correct arguments.
137 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
139 Compile marker debugging code only if ENABLE_CHECKING is defined.
140 * marker.c (byte_char_debug_check, count_markers): Use
141 only if ENABLE_CHECKING is defined.
142 (byte_debug_flag): Remove.
143 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
144 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
146 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
148 Avoid code repetition in marker-related functions.
149 * marker.c (attach_marker): New function.
150 (Fset_marker, set_marker_restricted, set_marker_both)
151 (set_marker_restricted_both): Use it.
152 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
153 Consistently rename charno to charpos.
154 (marker_position): Add eassert.
155 (marker_byte_position): Convert to eassert.
157 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
159 Simplify list operations in unchain_overlay and unchain_marker.
160 * buffer.c (unchain_overlay): Simplify. Add comment.
161 * marker.c (unchain_marker): Simplify. Fix comments.
163 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
165 Introduce fast path for the widely used marker operation.
166 * alloc.c (build_marker): New function.
167 * lisp.h (build_marker): New prototype.
168 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
169 * composite.c (autocmp_chars): Likewise.
170 * editfns.c (buildmark): Remove.
171 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
172 (save_restriction_save): Use build_marker.
173 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
174 * window.c (save_window_save): Likewise.
176 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
178 Do not use Fdelete_overlay in delete_all_overlays
179 to avoid redundant calls to unchain_overlay.
180 * buffer.c (drop_overlay): New function.
181 (delete_all_overlays, Fdelete_overlay): Use it.
182 * minibuf.c (get_minibuffer): Fix comment.
184 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
186 Port to OpenBSD 5.1 amd64.
187 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
188 This is needed for OpenBSD, and should be harmless on all BSD systems.
189 Also, include <sys/sysctl.h>, as it should be available on all
190 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
191 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
192 use p_pid member, not kp_proc.pid.
194 2012-07-06 Glenn Morris <rgm@gnu.org>
196 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
198 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
200 More xmalloc and related cleanup.
201 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
202 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
203 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
204 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
205 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
206 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
207 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
208 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
209 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
211 Omit needless casts involving void * pointers and allocation.
212 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
213 as the former is more robust if P's type is changed.
214 Prefer xzalloc to xmalloc + memset 0.
215 Simplify malloc-or-realloc to realloc.
216 Don't worry about xmalloc returning a null pointer.
217 Prefer xstrdup to xmalloc + strcpy.
218 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
220 * keyboard.c (apply_modifiers_uncached): Prefer local array to
221 alloca of a constant.
223 2012-07-05 Eli Zaretskii <eliz@gnu.org>
225 * xdisp.c (display_line): Fix horizontal pixel coordinates when
226 hscroll is larger than the line width. Fixes long and futile
227 looping inside extend_face_to_end_of_line (on a TTY) producing
228 glyphs that are not needed and thrown away.
230 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
232 * marker.c (set_marker_restricted_both): Simplify by using
235 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
237 * editfns.c (region_limit): Simplify by using clip_to_bounds.
239 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
241 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
242 not defined (Bug#11768).
243 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
244 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
245 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
246 followed by gtk_box_set_homogeneous (Bug#11768).
247 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
248 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
249 gtk_scrollbar_new (Bug#11768).
250 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
251 (is_box_type): New function (Bug#11768).
252 (xg_tool_item_stale_p): Call is_box_type.
253 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
254 with default display (Bug#11768).
256 2012-07-05 Eli Zaretskii <eliz@gnu.org>
258 * xdisp.c (window_hscroll_limited): New function.
259 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
260 coordinates when window's hscroll is set to insanely large
263 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
265 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
266 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
268 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
271 * lisp.h (xzalloc): New prototype. Omit needless casts.
272 * alloc.c (xzalloc): New function. Omit needless casts.
273 * charset.c: Omit needless casts. Convert all calls to
274 xmalloc with following memset to xzalloc.
275 * dispnew.c: Likewise.
276 * fringe.c: Likewise.
280 * w32fns.c: Likewise.
281 * w32font.c: Likewise.
282 * w32term.c: Likewise.
283 * xfaces.c: Likewise.
286 * atimer.c: Omit needless casts.
287 * buffer.c: Likewise.
288 * callproc.c: Likewise.
290 * coding.c: Likewise.
291 * composite.c: Likewise.
293 * doprnt.c: Likewise.
294 * editfns.c: Likewise.
297 * filelock.c: Likewise.
299 * gtkutil.c: Likewise.
300 * keyboard.c: Likewise.
303 * minibuf.c: Likewise.
306 * process.c: Likewise.
307 * region-cache.c: Likewise.
308 * search.c: Likewise.
309 * sysdep.c: Likewise.
310 * termcap.c: Likewise.
311 * terminal.c: Likewise.
312 * tparam.c: Likewise.
313 * w16select.c: Likewise.
315 * w32reg.c: Likewise.
316 * w32select.c: Likewise.
317 * w32uniscribe.c: Likewise.
318 * widget.c: Likewise.
322 * xselect.c: Likewise.
324 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
326 * fileio.c (time_error_value): Check the right error number.
327 Problem reported by Troels Nielsen in
328 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
330 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
332 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
333 This should be fixed in a better way; see Eli Zaretskii in
334 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
335 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
337 * fileio.c (time_error_value): Rename from special_mtime.
338 The old name's problems were noted by Eli Zaretskii in
339 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
341 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
342 This variable's comment says Emacs needs at least one GDB-visible
343 symbol of type enum pvec_type, to work around GDB problems.
344 The symbol's value doesn't matter.
346 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
347 that causes compilation to fail on pre-C99 compilers.
349 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
351 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
352 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
354 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
356 * buffer.c (init_buffer_once): Fix initialization of
357 headers for buffer_defaults and buffer_local_symbols.
358 Reported by Juanma Barranquero <lekktu@gmail.com>.
360 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
362 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
363 * lisp.h (enum pvec_type): Use fewer bits.
364 (PSEUDOVECTOR_SIZE_BITS): New constant.
365 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
366 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
368 (PSEUDOVECTOR_TYPEP): New macro.
369 (TYPED_PSEUDOVECTORP): Use it.
370 * fns.c (internal_equal): Adapt code to extract pvectype.
371 * emacs.c (gdb_pvec_type): Update type.
372 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
373 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
374 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
375 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
376 (sweep_vectors): Use it. Use local var `total_bytes' instead of
377 abusing vector->header.next.nbytes.
378 (live_vector_p): Use PVEC_TYPE.
379 (mark_object): Adapt code to extract pvectype. Use switch.
381 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
383 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
384 Tighten new eassert a bit.
386 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
388 Fix compilation with --enable-gcc-warnings and -O1
390 * doprnt.c (doprnt): Change type of tem to int, initialize
391 to avoid compiler warning. Add eassert.
392 * search.c (simple_search): Initialize match_byte to avoid
393 compiler warning. Add eassert.
395 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
397 Avoid weird behavior with large horizontal scrolls.
398 Without this change, for example, large hscroll values would
399 mess up Emacs's display on Fedora 15 x86, presumably due to
400 overflows in int calculations in the display code.
401 Also, if buffers had long lines, Emacs would freeze.
402 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
403 (set_window_hscroll): New function, containing the old guts of
404 Fset_window_hscroll. Return the clipped value.
405 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
406 This avoids the need to check against PTRDIFF_MAX.
408 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
410 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
412 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
414 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
416 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
417 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
418 since GCC 4.4.6 issues a bogus warning for them.
420 Fix bugs in file timestamp newness comparisons.
421 * fileio.c (Ffile_newer_than_file_p):
422 * lread.c (Fload): Use full timestamp resolution of files,
423 not just the 1-second resolution, so that files that are only
424 slightly newer still count as newer.
425 * fileio.c (Ffile_newer_than_file_p): Don't assume file
426 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
428 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
430 * fileio.c: Improve handling of file time marker. (Bug#11852)
431 (special_mtime): New function.
432 (Finsert_file_contents, Fverify_visited_file_modtime):
433 Use it to set special mtime values consistently.
435 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
437 * fileio.c (Finsert_file_contents): Properly handle st_mtime
438 marker for non-existing file. (Bug#11852)
440 2012-07-03 Glenn Morris <rgm@gnu.org>
442 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
443 and did not make it into globals.h).
445 2012-07-03 Tom Tromey <tromey@redhat.com>
447 * window.c (Fset_window_margins, Fset_window_fringes)
448 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
449 * textprop.c (Fprevious_property_change): No longer static.
450 * syntax.c (Fsyntax_table_p): No longer static.
451 * process.c (Fget_process, Fprocess_datagram_address): No longer
453 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
454 * keyboard.c (Fcommand_execute): No longer static.
456 * insdel.c (Fcombine_after_change_execute): No longer static.
457 * image.c (Finit_image_library): No longer static.
458 * fileio.c (Fmake_symbolic_link): No longer static.
459 * eval.c (Ffetch_bytecode): No longer static.
460 * editfns.c (Fuser_full_name): No longer static.
461 * doc.c (Fdocumentation_property, Fsnarf_documentation):
463 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
465 * dired.c (Ffile_attributes): No longer static.
466 * composite.c (Fcomposition_get_gstring): No longer static.
467 * callproc.c (Fgetenv_internal): No longer static.
469 * ccl.h: Remove EXFUNs.
470 * buffer.h: Remove EXFUNs.
471 * dispextern.h: Remove EXFUNs.
472 * intervals.h: Remove EXFUNs.
473 * fontset.h: Remove EXFUN.
474 * font.h: Remove EXFUNs.
475 * dosfns.c (system_process_attributes): Remove EXFUN.
476 * keymap.h: Remove EXFUNs.
477 * lisp.h: Remove EXFUNs.
478 * w32term.h: Remove EXFUNs.
479 * window.h: Remove EXFUNs.
480 * xsettings.h: Remove EXFUN.
481 * xterm.h: Remove EXFUN.
483 2012-07-03 Glenn Morris <rgm@gnu.org>
485 * lisp.h (Frandom): Make it visible to C.
486 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
487 buffer for invisible buffers. (Bug#1229)
489 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
491 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
492 values which aren't power of 2.
493 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
494 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
497 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
499 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
501 * alloc.c (mark_object): Revert part of last patch to use `switch'.
503 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
505 * alloc.c (allocate_vector_block): Remove redundant
506 calls to mallopt if DOUG_LEA_MALLOC is defined.
507 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
508 avoid calls to mallopt if zero_vector is returned.
510 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
512 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
513 is enabled, avoid dereferencing NULL current_sblock if
516 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
518 Cleanup basic buffer management.
519 * buffer.h (struct buffer): Change layout to use generic vector
520 marking code. Fix some comments. Change type of 'clip_changed'
521 to bitfield. Remove unused #ifndef old.
522 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
523 (GET_OVERLAYS_AT): Fix indentation.
524 (for_each_per_buffer_object_at): New macro.
525 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
526 (Fbuffer_local_variables): Use it.
527 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
528 * alloc.c (allocate_buffer): Adjust to match new layout of
529 struct buffer. Fix comment.
530 (mark_overlay): New function.
531 (mark_buffer): Use it. Use mark_vectorlike to mark normal
532 Lisp area of struct buffer.
533 (mark_object): Use it. Adjust marking of misc objects
534 and related comments.
536 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
538 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
539 wrapper that is not needed because the wrapped code is a no-op (zero
540 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
541 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
543 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
545 * alloc.c (mark_buffer): Simplify. Remove prototype.
546 (mark_object): Add comment. Reorganize marking of vector-like
547 objects. Use CHECK_LIVE for all vector-like objects except buffers
548 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
549 redundant calls to mark_vectorlike for bool vectors.
551 2012-06-30 Glenn Morris <rgm@gnu.org>
553 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
555 * epaths.in (PATH_SITELOADSEARCH): New.
556 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
557 This is rather than relying on --enable-locallisppath elements
558 having "site-lisp" in their names. (Bug#10208#25, 11658)
560 2012-06-30 Eli Zaretskii <eliz@gnu.org>
562 * w32proc.c (sys_select): Accept and ignore one more argument.
564 * w32.c (emacs_gnutls_pull): Call select with one more argument.
566 * sysselect.h [DOS_NT]: Don't include sys/select.h.
567 (pselect) [!MS_DOS]: Redirect to sys_select.
569 * sysdep.c: Don't include dos.h and dosfns.h.
571 * process.c (sys_select):
572 * msdos.c (sys_select): Accept one more argument and ignore it.
574 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
575 adapt data types and code to that.
578 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
579 which clashes with the gnulib function of the same name.
581 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
583 * font.c (font_style_to_value, font_style_symbolic)
584 (font_prop_validate_style): Add type checks for values in
587 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
589 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
592 2012-06-29 Eli Zaretskii <eliz@gnu.org>
594 * xdisp.c (try_window_id): Undo last change.
596 * w32.c (getwd): Adjust commentary about startup_dir.
597 (init_environment): Always call sys_access, even in non-MSVC
598 builds. Don't chdir to the directory of the Emacs executable.
599 This undoes code from 1997 which was justified by the need to
600 "avoid conflicts when removing and renaming directories". But its
601 downside was that every relative file name was being interpreted
602 relative to the directory of the Emacs executable, which can never
603 be TRT. In particular, it broke sys_access when called with
605 (sys_access): Map GetLastError to errno.
607 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
609 * window.h (struct window): Change type of 'fringes_outside_margins'
610 to bitfield. Fix comment. Adjust users accordingly.
611 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
613 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
616 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
618 * gnutls.c (emacs_gnutls_handshake):
619 Add QUIT to make the loop interruptible.
621 2012-06-29 Glenn Morris <rgm@gnu.org>
623 * charset.c (init_charset): Make lack of etc/charsets fatal.
625 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
627 * editfns.c (region_limit): Fix type mismatch.
629 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
631 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
632 undefined. Convert from xassert to eassert.
633 * nsmenu.m: Convert from xassert to eassert.
634 * nsterm.m: Likewise.
636 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
638 * editfns.c (region_limit): Clip to narrowing (bug#11770).
640 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
642 Avoid integer overflow on scroll-left and scroll-right.
643 * window.c (HSCROLL_MAX): New macro.
644 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
645 overflow when requested scroll falls outside ptrdiff_t range.
647 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
649 * window.h (struct window): Change type of 'hscroll',
650 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
651 'last_modified' and 'last_overlay_modified' to EMACS_INT.
652 Adjust users accordingly.
653 * xdisp.c (try_cursor_movement): Replace type check with eassert.
654 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
655 from EMACS_INT to ptrdiff_t.
656 (make_window): Omit redundant initialization.
658 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
660 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
662 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
664 * window.h (struct window): Change type of 'use_time' and
665 'sequence_number' from Lisp_Object to int.
666 * frame.c (make_frame): Adjust users accordingly.
667 * print.c (print_object): Likewise.
668 * window.c (select_window, Fwindow_use_time, make_parent_window)
669 (make_window): Likewise.
671 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
673 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
674 enabled with --enable-checking=[all,glyphs] configure option.
675 Fix GLYPH_DEBUG usage assuming that it may be undefined,
676 adjust comments accordingly.
677 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
678 undefined, adjust comments accordingly.
680 * scroll.c: Likewise.
681 * w32fns.c: Likewise.
682 * w32term.c: Likewise.
684 * xfaces.c: Likewise.
688 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
690 Generalize run-time debugging checks.
691 * dispextern.h (XASSERTS): Remove.
692 * fontset.c (xassert): Remove.
693 Convert from xassert to eassert.
694 * alloc.c: Convert from xassert to eassert.
696 * dispnew.c: Likewise.
698 * fringe.c: Likewise.
699 * ftfont.c: Likewise.
700 * gtkutil.c: Likewise.
702 * keyboard.c: Likewise.
704 * process.c: Likewise.
705 * scroll.c: Likewise.
708 * w32console.c: Likewise.
709 * w32fns.c: Likewise.
710 * w32term.c: Likewise.
711 * window.c: Likewise.
713 * xfaces.c: Likewise.
715 * xselect.c: Likewise.
718 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
720 * fns.c (maybe_resize_hash_table): Output message when growing the
723 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
725 * alloc.c (allocate_string_data): Remove dead code.
726 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
727 avoid GCC warning about unused macro.
729 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
731 * alloc.c (allocate_string): Omit intervals initialization.
732 * alloc.c (make_uninit_multibyte_string): Initialize intervals
733 as in make_pure_string and make_pure_c_string.
735 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
737 * alloc.c (allocate_string): Fix last change.
739 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
741 * alloc.c (allocate_string): Remove two redundant calls
742 to memset, add explicit initialization where appropriate.
744 2012-06-27 Glenn Morris <rgm@gnu.org>
746 * lisp.mk (lisp): Remove paths.elc.
748 2012-06-27 Chong Yidong <cyd@gnu.org>
750 * doc.c (Fsubstitute_command_keys): Fix punctuation.
752 2012-06-26 John Wiegley <johnw@newartisans.com>
754 * unexmacosx.c (copy_data_segment): Add two section names used
755 on Mac OS X Lion: __mod_init_func and __mod_term_func.
757 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
758 when building with Clang.
760 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
762 * eval.c (Fapply): Allow calling it with a single argument.
764 2012-06-26 Eli Zaretskii <eliz@gnu.org>
766 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
767 _stricmp and _strnicmp.
768 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
770 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
772 * alloc.c (allocate_window): Zero out non-Lisp part of newly
774 (allocate_process): Likewise for new process.
775 (allocate_terminal): Change to use offsetof.
776 (allocate_frame): Likewise.
777 * frame.c (make_frame): Omit redundant initialization.
778 * window.c (make_parent_window): Use memset.
779 (make_window): Omit redundant initialization.
780 * process.c (make_process): Omit redundant initialization.
781 * terminal.c (create_terminal): Likewise.
783 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
785 * term.c (delete_tty): Remove redundant call to memset.
787 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
789 * alloc.c: Remove build_string.
790 * lisp.h: Define build_string as static inline. This provides
791 a better opportunity to optimize away calls to strlen when the
792 function is called with compile-time constant argument.
793 * image.c (imagemagick_error): Convert to build_string.
794 * w32proc.c (sys_spawnve): Likewise.
795 * xterm.c (x_term_init): Likewise.
797 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
799 Use sprintf return value instead of invoking strlen on result.
800 In the old days this wasn't portable, since some sprintf
801 implementations returned char *. But they died out years ago and
802 Emacs already assumes sprintf returns int.
803 Similarly for float_to_string.
804 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
805 * ccl.c (ccl_driver):
806 * character.c (string_escape_byte8):
807 * data.c (Fnumber_to_string):
809 * print.c (print_object):
810 * xdisp.c (message_dolog):
811 * xfns.c (syms_of_xfns):
812 Use sprintf or float_to_string result to avoid need to call strlen.
813 * data.c (Fnumber_to_string):
814 Use make_unibyte_string, since the string must be ASCII.
815 * lisp.h, print.c (float_to_string): Now returns int length.
816 * term.c (produce_glyphless_glyph):
817 Use sprintf result rather than recomputing it.
819 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
820 * Makefile.in (ALL_CFLAGS):
821 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
822 * gmalloc.c, regex.c: Include <config.h> unconditionally.
824 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
826 * dispextern.h (xstrcasecmp): Define to library function
827 strcasecmp if available.
828 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
830 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
832 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
833 Avoid comma operator.
834 * menu.c (push_submenu_start, push_submenu_end)
835 (push_left_right_boundary, push_menu_pane): Likewise.
836 * msdos.c (dos_rawgetc): Likewise.
838 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
840 * xfns.c (xic_create_fontsetname): Remove redundant calls
843 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
845 * gtkutil.c (get_utf8_string): Remove redundant assignment.
846 sprintf already null-terminates its output.
848 * xfns.c (x_window): Remove redundant cast.
850 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
852 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
853 `const char *' to `char *' to avoid compiler warning.
855 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
857 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
858 instead of truncating it to 63 (admittedly a generous limit).
860 * process.c: Fix spelling and caps in comments.
862 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
864 * emacs.c (setpgrp): Remove definition, unused.
865 * sysdep.c (setpgrp): Remove definition, not used in this file.
867 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
869 * makefile.w32-in: Update dependencies.
871 2012-06-24 Eli Zaretskii <eliz@gnu.org>
873 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
874 (SYSTIME_H): Add nt/inc/sys/time.h.
876 * systime.h [WINDOWSNT]: Include sys/time.h.
878 * s/ms-w32.h (struct timespec): Definition moved from
879 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
881 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
883 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
884 * buffer.h (buffer_slot_type_mismatch):
885 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
886 * eval.c (unwind_to_catch):
887 * image.c (my_png_error, my_error_exit):
888 * keyboard.c (quit_throw_to_read_char, user_error)
889 (Fexit_recursive_edit, Fabort_recursive_edit):
890 * lisp.h (die, args_out_of_range, args_out_of_range_3)
891 (wrong_type_argument, buffer_overflow, __executable_start)
892 (memory_full, buffer_memory_full, string_overflow, Fthrow)
893 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
894 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
896 (child_setup) [!DOS_NT]:
897 * lread.c (end_of_file_error, invalid_syntax):
898 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
899 * puresize.h (pure_write_error):
900 * search.c (matcher_overflow):
901 * sound.c (sound_perror, alsa_sound_perror):
902 * sysdep.c, syssignal.h (croak):
903 * term.c (maybe_fatal, vfatal):
904 * textprop.c (text_read_only):
905 * undo.c (user_error):
906 * unexmacosx.c (unexec_error):
907 * xterm.c (x_ins_del_lines, x_delete_glyphs):
908 Use _Noreturn rather than NO_RETURN.
909 No need for separate decl merely because of _Noreturn.
910 * sound.c (sound_warning, parse_sound):
911 Remove unnecessary forward decls.
913 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
915 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
916 * lisp.h (WAIT_READING_MAX): New macro.
917 * dispnew.c (Fsleep_for, sit_for):
918 * keyboard.c (kbd_buffer_get_event):
919 * process.c (Faccept_process_output):
920 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
921 This improves on the previous patch, which introduced a bug
922 when time_t is unsigned and as wide as intmax_t.
923 See <http://bugs.gnu.org/9000#51>.
925 2012-06-23 Eli Zaretskii <eliz@gnu.org>
927 * dispnew.c (sit_for, Fsleep_for):
928 * keyboard.c (kbd_buffer_get_event):
929 * process.c (Faccept_process_output): Avoid compiler warnings when
930 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
932 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
934 * makefile.w32-in: Update dependencies.
936 * w32.c (ltime): Add return type and declare static.
937 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
939 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
941 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
942 Privately reported by Herbert J. Skuhra.
943 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
945 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
946 not make_lisp_timeval, when the argument is of type EMACS_TIME.
948 2012-06-23 Eli Zaretskii <eliz@gnu.org>
950 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
951 last argument of make_unibyte_string.
953 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
954 language ID in the event parameters.
956 * w32term.c (w32_read_socket): Put the new keyboard codepage into
957 event.code, not the obscure "character set ID".
959 2012-06-23 Chong Yidong <cyd@gnu.org>
961 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
963 2012-06-23 Eli Zaretskii <eliz@gnu.org>
965 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
966 * w32.c (fdutimens): New function.
968 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
970 * s/ms-w32.h (pselect): Redirect to sys_select.
972 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
974 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
975 in the logic of incrementing and decrementing the value of
976 use_relocatable_buffers.
978 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
980 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
981 Privately reported by Herbert J. Skuhra.
982 [__FreeBSD__]: Remove "*/" typo after "#include".
983 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
984 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
985 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
986 Don't assume EMACS_TIME and struct timeval are the same type.
988 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
990 Support higher-resolution time stamps (Bug#9000).
991 The time stamps are only nanosecond-resolution at the C level,
992 since that's the best that any real-world system supports now.
993 But they are picosecond-resolution at the Lisp level, as that's
994 easy, and leaves room for future OS improvements.
996 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
999 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1000 Don't get current time unless it's needed.
1002 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1003 now provides it if it's absent.
1004 (start_atimer): Port to higher-res time stamps.
1005 Check for time stamp overflow. Don't get current time more
1006 often than is needed.
1008 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1009 Include systime.h, not time.h.
1010 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1012 * dired.c: Include stat-time.h.
1013 (Ffile-attributes): File times now have higher resolution.
1015 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1016 (struct image): Timestamp now has higher resolution.
1018 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1019 has at least microseconds now. All uses removed.
1020 (update_frame, update_single_window, update_window, update_frame_1)
1021 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1023 * editfns.c (time_overflow): Now extern.
1024 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1025 (float-time, Fformat_time_string, Fcurrent_time_string)
1026 (Fcurrent_time_zone): Accept and generate higher-resolution
1028 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1029 (decode_time_components, lisp_seconds_argument): New functions.
1030 (make_time): Now static.
1031 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1032 Report an error if the time is invalid, rather than having the caller
1035 * fileio.c: Include <stat-time.h>
1036 (Fcopy_file): Copy higher-resolution time stamps.
1037 Prefer to set the time stamp via a file descriptor if that works.
1038 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1039 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1040 (Fvisited_file_modtime, Fset_visited_file_modtime):
1041 Support higher-resolution time stamps.
1043 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1045 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1047 * image.c (prepare_image_for_display, clear_image_cache)
1048 (lookup_image): Port to higer-resolution time stamps.
1050 * keyboard.c (start_polling, bind_polling_period):
1051 Check for time stamp overflow.
1052 (read_char, kbd_buffer_get_event, timer_start_idle)
1053 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1054 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1055 Port to higher-resolution time stamps. Do not assume time_t is signed.
1056 (decode_timer): New function. Timers are now vectors of length 9,
1057 not 8, to accommodate the picosecond component.
1058 (timer_check_2): Use it.
1060 * nsterm.m (select_timeout, timeval_subtract): Remove.
1061 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1062 as they're a bit more accurate and handle overflow better.
1063 (ns_select): Change prototype to be compatible with pselect.
1064 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1065 * nsterm.h (ns_select): Adjust prototype.
1067 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1068 us-resolution time stamps.
1069 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1071 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1073 * lisp.h (time_overflow): New decl.
1074 (wait_reading_process_output): First arg is now intmax_t, not int,
1075 to accommodate larger waits.
1077 * process.h (struct Lisp_Process.read_output_delay):
1078 Now counts nanoseconds, not microseconds.
1079 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1081 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1082 (wait_reading_process_output):
1083 Port to ns-resolution time stamps.
1084 (Faccept_process_output, wait_reading_process_output):
1085 Check for time stamp overflow. Do not assume time_t is signed.
1086 (select_wrapper): Remove; we now use pselect.
1087 (Fprocess_attributes): Now generates ns-resolution time stamps.
1089 * sysdep.c: Include utimens.h. Don't include utime.h
1090 or worry about struct utimbuf; gnulib does that for us now.
1091 (gettimeofday): Remove; gnulib provides a substitute.
1092 (make_timeval): New function.
1093 (set_file_times): Now sets ns-resolution time stamps.
1094 New arg FD; all uses changed.
1095 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1096 (system_process_attributes):
1097 Now returns ns-resolution time stamp. All uses changed.
1098 Check for time stamp overflow.
1100 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1101 provides a substitute now.
1103 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1104 since it guarantees struct timespec.
1105 (EMACS_TIME): Now struct timespec, so that we can support
1106 ns-resolution time stamps.
1107 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1108 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1109 (EMACS_USECS): Remove.
1110 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1111 so multiply the arg by 1000 before storing it.
1112 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1114 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1115 Port to ns-resolution time stamps.
1116 (EMACS_TIME_NEG_P): Remove; replaced by....
1117 (EMACS_TIME_SIGN): New macro.
1118 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1119 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1120 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1121 (make_timeval, make_lisp_time, decode_time_components): New decls.
1122 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1123 that it mishandled time_t overflow. You can't compare by subtracting!
1124 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1125 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1127 * term.c: Include <sys/time.h>.
1128 (timeval_to_Time): New function, for proper overflow wraparound.
1129 (term_mouse_position, term_mouse_click): Use it.
1131 * undo.c (record_first_change): Support higher-resolution time stamps
1133 (Fprimitive_undo): Use them when restoring time stamps.
1135 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1136 (w32_get_internal_run_time):
1137 Port to higher-resolution Emacs time stamps.
1138 (ltime): Now accepts single 64-bit integer, as that's more convenient
1141 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1143 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1144 for compatibility with pselect. Support ns-resolution time stamps.
1146 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1148 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1149 Check for time stamp overflow, and support ns-resolution time stamps.
1151 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1152 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1153 (timeval_subtract): Remove; no longer needed.
1154 (XTflash, XTring_bell, x_wait_for_event):
1155 Port to ns-resolution time stamps. Don't assume time_t is signed.
1157 2012-06-22 Chong Yidong <cyd@gnu.org>
1159 * xdisp.c (x_consider_frame_title): Revert last change.
1161 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1163 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1164 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1165 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1166 staticidx goes up to 1597 out of 1600 = 0x640.)
1168 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1170 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1171 Otherwise, the umask might be mistakenly 0 while handling input signals.
1173 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1175 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1177 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1179 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1180 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1181 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1182 access to `contents' member of Lisp_Vector objects with AREF and ASET
1185 2012-06-19 Chong Yidong <cyd@gnu.org>
1187 * frame.c (delete_frame): When selecting a frame on a different
1188 text terminal, do not alter the terminal's top-frame.
1190 * xdisp.c (format_mode_line_unwind_data): Record the target
1191 frame's selected window and its terminal's top-frame.
1192 (unwind_format_mode_line): Restore them.
1193 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1195 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1196 since tty frames can be explicitly named.
1197 (prepare_menu_bars): Likewise.
1199 * term.c (Ftty_top_frame): New function.
1201 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1203 Port byte-code-meter to modern targets.
1204 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1205 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1206 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1207 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1208 (METER_1, METER_2): Simplify.
1210 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1212 * data.c (Fdefalias): Return `symbol' (bug#11686).
1214 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1216 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1217 gets killed during executing of this function (Bug#11665).
1218 Try to always return Qt when the buffer has been actually killed.
1219 (Vkill_buffer_query_functions): In doc-string say that functions
1220 run by this hook should not change the current buffer.
1222 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1224 Fix recently-introduced process.c problems found by static checking.
1225 * process.c (write_queue_push, write_queue_pop, send_process):
1226 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1227 (write_queue_pop): Fix pointer signedness problem.
1228 (send_process): Remove unused local.
1230 2012-06-17 Chong Yidong <cyd@gnu.org>
1232 * xdisp.c (redisplay_internal): No need to redisplay terminal
1233 frames that are not on top.
1235 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1237 * process.c (make_process): Initialize write_queue.
1238 (write_queue_push, write_queue_pop): New functions.
1239 (send_process): Use them to maintain correct ordering of process
1242 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1244 * lisp.h (eassert): Assume C89 or later.
1245 This removes the need for CHECK.
1246 (CHECK): Remove. Its comments about always evaluating its
1247 argument were confusing, as 'eassert' typically does not evaluate
1250 * coding.c (produce_chars): Use ptrdiff_t, not int.
1252 * xterm.c (x_draw_underwave): Check for integer overflow.
1253 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1255 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1257 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1258 referenced (Bug#11583).
1260 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1262 Implement wave-style variant of underlining.
1263 * dispextern.h (face_underline_type): New enum.
1264 (face): Add field for underline type.
1265 * nsterm.m (ns_draw_underwave): New function.
1266 (ns_draw_text_decoration): Use it.
1267 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1269 (x_draw_glyph_string): Use them.
1270 * xfaces.c (Qline, Qwave): New Lisp objects.
1271 (check_lface_attrs, merge_face_ref)
1272 (Finternal_set_lisp_face_attribute, realize_x_face):
1273 Handle wave-style underline face attributes.
1274 * xterm.c (x_draw_underwave): New function.
1275 (x_draw_glyph_string): Use it.
1277 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1279 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1280 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1281 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1282 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1283 ($(BLD)/w32select.$(O)): Update dependencies.
1285 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1287 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1288 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1289 * character.c (_fetch_multibyte_char_p): Remove.
1290 * alloc.c: Include "character.h" before "buffer.h".
1292 * buffer.c: Likewise.
1293 * bytecode.c: Likewise.
1294 * callint.c: Likewise.
1295 * callproc.c: Likewise.
1296 * casefiddle.c: Likewise.
1297 * casetab.c: Likewise.
1298 * category.c: Likewise.
1300 * coding.c: Likewise.
1301 * composite.c: Likewise.
1302 * dired.c: Likewise.
1303 * dispnew.c: Likewise.
1305 * dosfns.c: Likewise.
1306 * editfns.c: Likewise.
1307 * emacs.c: Likewise.
1308 * fileio.c: Likewise.
1309 * filelock.c: Likewise.
1311 * fontset.c: Likewise.
1312 * fringe.c: Likewise.
1313 * indent.c: Likewise.
1314 * insdel.c: Likewise.
1315 * intervals.c: Likewise.
1316 * keyboard.c: Likewise.
1317 * keymap.c: Likewise.
1318 * lread.c: Likewise.
1319 * macros.c: Likewise.
1320 * marker.c: Likewise.
1321 * minibuf.c: Likewise.
1322 * nsfns.m: Likewise.
1323 * nsmenu.m: Likewise.
1324 * print.c: Likewise.
1325 * process.c: Likewise.
1326 * regex.c: Likewise.
1327 * region-cache.c: Likewise.
1328 * search.c: Likewise.
1329 * syntax.c: Likewise.
1331 * textprop.c: Likewise.
1333 * unexsol.c: Likewise.
1334 * w16select.c: Likewise.
1335 * w32fns.c: Likewise.
1336 * w32menu.c: Likewise.
1337 * window.c: Likewise.
1338 * xdisp.c: Likewise.
1340 * xmenu.c: Likewise.
1342 * xselect.c: Likewise.
1344 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1346 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1347 If all the glyphs of the glyph row came from strings, and we have no
1348 cursor positioning clues, put the cursor on the first glyph of the
1350 (handle_face_prop): Use chunk-relative overlay string index when
1351 indexing into it->string_overlays array. (Bug#11653)
1352 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1353 the rightmost. (Bug#11720)
1355 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1357 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1358 (CATEGORY_MEMBER): Enforce 1/0 value.
1359 * category.c (_temp_category_set): Remove.
1361 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1363 * window.c (Fdelete_other_windows_internal)
1364 (Fdelete_window_internal): Don't access frame's mouse highlight
1365 info of the initial frame. (Bug#11677)
1367 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1369 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1370 Assume USE_2_TAGS_FOR_INTS.
1371 (xreload): Adjust $tagmask width to match recent lisp.h change.
1373 Simplify lisp.h in minor ways that should not affect code.
1374 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1375 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1376 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1377 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1378 (INTTYPEBITS): New macro, for clarity.
1379 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1380 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1381 Simplify now that USE_LSB_TAG is always defined.
1382 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1383 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1385 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1387 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1389 2012-06-13 Glenn Morris <rgm@gnu.org>
1391 * s/bsd-common.h (BSD4_3):
1392 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1394 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1396 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1399 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1401 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1402 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1403 * alloc.c (widen_to_Lisp_Object): Remove.
1404 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1405 * frame.c (delete_frame): Remove outdated comment.
1406 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1407 USE_LISP_UNION_TYPE.
1408 (Fw32_unregister_hot_key): Likewise.
1409 (Fw32_toggle_lock_key): Likewise.
1410 * w32menu.c (add_menu_item): Likewise.
1411 (w32_menu_display_help): Use XIL instead of checking
1412 USE_LISP_UNION_TYPE.
1413 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1414 (init_heap): Likewise.
1415 * w32term.c (w32_read_socket): Update comment.
1417 2012-06-13 Glenn Morris <rgm@gnu.org>
1419 * s/usg5-4-common.h, src/s/unixware.h:
1420 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1422 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1424 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1426 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1427 * alloc.c (make_number) [!defined make_number]:
1428 Remove, as lisp.h always defines this now.
1429 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1430 (roundup_size): Verify that it is a power of 2.
1431 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1432 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1433 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1434 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1435 USE_LSB_TAG now is always defined to be either 0 or 1.
1437 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1438 code works fine either way, and efficiency is not a concern here,
1439 as the union type is for debugging, not for production.
1440 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1441 Use an inline function on all platforms when using the union type,
1442 since this is simpler and 'static inline' can be used portably
1444 (LISP_INITIALLY_ZERO): New macro.
1445 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1446 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1448 2012-06-12 Glenn Morris <rgm@gnu.org>
1450 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1452 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1454 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1455 Move BROKEN_SIGIO to configure.
1457 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1458 Move NO_TERMIO to configure.
1460 2012-06-12 Chong Yidong <cyd@gnu.org>
1462 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1463 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1464 MagickExportImagePixels is undefined.
1466 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1468 * image.c (imagemagick_load_image): Remove unused label.
1470 2012-06-11 Glenn Morris <rgm@gnu.org>
1472 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1473 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1474 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1475 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1477 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1479 * alloc.c (make_byte_code): New function.
1480 (Fmake_byte_code): Use it. Don't purify here.
1481 * lread.c (read1): Use it as well to avoid extra allocation.
1483 2012-06-11 Chong Yidong <cyd@gnu.org>
1485 * image.c (imagemagick_load_image): Implement transparency.
1487 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1489 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1490 account for preceding backslashes. (Bug#11663)
1492 2012-06-09 Chong Yidong <cyd@gnu.org>
1494 * term.c: Support italics in capable terminals (Bug#9652).
1495 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1496 (turn_on_face): Output using TS_enter_italic_mode if available.
1497 Don't handle unused blinking and alt-charset cases.
1498 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1499 and tty_alt_charset_p cases.
1500 (tty_capable_p, init_tty): Support italics.
1502 * termchar.h (struct tty_display_info): Add field for italics.
1503 Remove unused blink field.
1505 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1508 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1509 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1510 tty_alt_charset_p. Add tty_italic_p.
1512 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1514 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1515 dbus_type_is_basic if available.
1516 (xd_extract_signed, xd_extract_unsigned): Rename from
1517 extract_signed and extract_unsigned, respectively. Adapt callers.
1519 2012-06-09 Chong Yidong <cyd@gnu.org>
1521 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1523 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1526 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1528 * xdisp.c (vmessage): Treat frame message as multibyte.
1529 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1530 would generate the diagnostic "Making \302\247 buffer-local while
1533 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1535 * dispnew.c (showing_window_margins_p): Undo last change, which
1536 was done due to an inadvertent commit.
1537 (adjust_frame_glyphs_for_frame_redisplay): Do call
1538 showing_window_margins_p.
1540 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1542 * eval.c (Fmake_var_non_special): New primitive.
1543 (syms_of_eval): Defsubr it.
1544 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1546 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1548 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1549 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1551 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1553 * alloc.c (allocate_vectorlike): Fix last change.
1555 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1557 Block-based vector allocation of small vectors.
1558 * lisp.h (struct vectorlike_header): New field `nbytes',
1559 adjust comment accordingly.
1560 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1561 to denote vector blocks. Adjust users (live_vector_p,
1562 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1563 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1564 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1565 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1566 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1567 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1568 (roundup_size): New constant.
1569 (struct vector_block): New data type.
1570 (vector_blocks, vector_free_lists, zero_vector): New variables.
1571 (all_vectors): Rename to `large_vectors'.
1572 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1573 (sweep_vectors): New functions.
1574 (allocate_vectorlike): Return `zero_vector' as the only vector of
1575 0 items. Allocate new vector from block if vector size is less than
1576 or equal to VBLOCK_BYTES_MAX.
1577 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1578 (init_alloc_once): Add call to init_vectors.
1580 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1582 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1584 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1586 * doprnt.c (doprnt): Truncate multibyte char correctly.
1587 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1588 would mishandle a string argument "Xc" if X was a multibyte
1589 character of length 2: it would truncate after X's first byte
1590 rather than including all of X.
1592 2012-06-06 Chong Yidong <cyd@gnu.org>
1594 * buffer.c (word_wrap): Doc fix.
1596 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1598 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1600 2012-06-03 Glenn Morris <rgm@gnu.org>
1602 * xdisp.c (tool-bar-style): Doc fix.
1604 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1606 * Makefile.in (PAXCTL): Define.
1607 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1608 binary via PaX flags if the paxctl utility is available.
1609 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1610 Restore PaX flags to their default. (Bug#11398)
1612 2012-06-03 Chong Yidong <cyd@gnu.org>
1614 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1617 2012-06-03 Chong Yidong <cyd@gnu.org>
1619 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1620 (note_mode_line_or_margin_highlight): If there is no help echo,
1621 use mode-line-default-help-echo. Handle the case where the mouse
1622 position is past the end of the mode line string.
1624 * buffer.c (buffer_local_value_1): New function, split from
1625 Fbuffer_local_value; can return Qunbound.
1626 (Fbuffer_local_value): Use it.
1627 (Vmode_line_format): Docstring tweaks.
1629 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1631 * sysdep.c (system_process_attributes): Improve comment.
1633 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1635 * keyboard.c: Export real-this-command to Elisp.
1636 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1637 and DEFVAR it. Update all users.
1639 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1641 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1643 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1644 Convert pctcpu and pctmem to Lisp float properly.
1645 Let the compiler fold better, as 100.0/0x8000 is exact.
1647 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1649 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1652 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1654 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1656 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1658 For a 'struct window', replace some Lisp_Object fields to
1659 bitfields where appropriate, remove unused fields.
1660 * window.h (struct window): Remove unused 'last_mark_x' and
1661 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1662 change it's type from Lisp_Object to bitfield.
1663 Change type of 'force_start', 'optional_new_start',
1664 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1665 fields from Lisp_Object to bitfield. Adjust users accordingly.
1667 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1669 Pacify gcc -Wdouble-precision when using Xaw.
1670 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1671 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1672 Use 'float' consistently, rather than 'float' in most places
1673 and 'double' in a couple of places.
1675 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1677 * xdisp.c (handle_stop): Detect whether we have overlay strings
1678 loaded by testing it->current.overlay_string_index to be
1679 non-negative, instead of checking whether n_overlay_strings is
1680 positive. (Bug#11587)
1682 2012-05-31 Chong Yidong <cyd@gnu.org>
1684 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1686 * doc.c (Fsubstitute_command_keys): Doc fix.
1688 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1690 * search.c (search_buffer): Remove calls to
1691 r_alloc_inhibit_buffer_relocation, as it is now called by
1692 maybe_unify_char, which was the cause of relocation of buffer text
1695 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1697 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1698 for the duration of call to load_charset, to avoid problems with
1699 callers of maybe_unify_char that access buffer text through C
1702 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1703 decrement the inhibition flag, instead of just setting or
1706 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1708 Remove obsolete '#define static' cruft.
1709 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1710 This #undef was "temporary" in 2000; it is no longer needed
1711 now that '#define static' has gone away.
1712 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1713 (gray_bitmap_bits): Remove; no longer needed.
1714 All uses replaced with definiens.
1715 * xterm.c: Include "bitmaps/gray.xbm".
1717 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1719 Clean up __executable_start, monstartup when --enable-profiling.
1720 The following changes affect the code only when profiling.
1721 * dispnew.c (__executable_start): Rename from safe_bcopy.
1722 Define only on platforms that need it.
1723 * emacs.c: Include <sys/gmon.h> when profiling.
1724 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1725 (__executable_start): Remove decl, since lisp.h does it now.
1726 (safe_bcopy): Remove decl; no longer has that name.
1727 (main): Coalesce #if into single bit of code, for simplicity.
1728 Cast pointers to uintptr_t, since standard libraries want integers
1730 * lisp.h (__executable_start): New decl.
1732 2012-05-31 Glenn Morris <rgm@gnu.org>
1734 * image.c (Fimagemagick_types): Doc fix.
1736 2012-05-30 Jim Meyering <meyering@redhat.com>
1738 * callproc.c (Fcall_process_region): Include directory component
1739 in mkstemp error message (Bug#11586).
1741 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1743 * alloc.c, lisp.h (make_pure_vector): Now static.
1745 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1747 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1748 Move to byte-run.el.
1749 (Fautoload): Do the hash-doc more carefully.
1750 * data.c (Fdefalias): Purify definition, except for keymaps.
1751 (Qdefun): Move from eval.c.
1752 * lisp.h (Qdefun): Remove.
1753 * lread.c (read1): Tiny simplification.
1755 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1757 Do not create empty overlays with the evaporate property (Bug#9642).
1758 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1759 Bug#9642, but explicitly check that the buffer the overlay would
1760 be moved to is live and rearrange lines to make sure that errors
1761 will not put the overlay in an inconsistent state.
1762 (Fdelete_overlay): Cosmetics.
1764 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1766 * w32term.c (my_bring_window_to_top): New function.
1767 (x_raise_frame): Use handle returned by DeferWindowPos, which
1768 could be different from the original one.
1769 Call my_bring_window_to_top instead of my_set_foreground_window.
1772 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1773 by calling BringWindowToTop.
1775 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1776 (WM_EMACS_END): Increase by one.
1778 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1780 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1781 This avoids undefined behavior that might cause the eassert
1782 to not catch an out-of-range value.
1784 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1786 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1787 Update dependencies.
1789 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1791 * bidi.c (bidi_mirror_char): Fix last change.
1793 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1795 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1796 when referring to sectname field in printf format.
1798 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1800 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1801 Only r_alloc_inhibit_buffer_relocation needed to be added;
1802 the others were already declared.
1804 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1805 before checking whether it's out of range. Put the check inside
1807 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1809 2012-05-27 Ken Brown <kbrown@cornell.edu>
1811 * callproc.c (Fcall_process): Restore a line that was accidentally
1812 commented out in the 2011-02-13 change (bug#11547).
1814 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1816 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1817 defined on ralloc.c.
1819 * buffer.c [REL_ALLOC]: Remove prototypes of
1820 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1821 they are now on lisp.h.
1823 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1825 * search.c (search_buffer): Use it to inhibit relocation of buffer
1826 text while re_search_2 is doing its job, because re_search_2 is
1827 passed C pointers to buffer text. (Bug#11519)
1829 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1832 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1833 state after an additional call to move_it_in_display_line_to, keep
1834 the values of it->max_ascent and it->max_descent found for the
1836 (pos_visible_p): Revert the comparison against bottom_y to what it
1837 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1840 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1842 Fix coding-related core dumps with gcc -ftrapv.
1843 The code was computing A - B, where A and B are pointers, and B is
1844 random garbage. This can lead to core dumps on platforms that
1845 have special pointer registers, and it also leads to core dumps on
1846 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1847 A - B only when B is initialized properly.
1848 * coding.c (coding_set_source, coding_set_destination): Return void.
1849 (coding_change_source, coding_change_destinations): New functions,
1850 with the old behaviors of coding_set_source and coding_set_destination.
1851 All callers that need an offset changed to use these new functions.
1853 2012-05-26 Glenn Morris <rgm@gnu.org>
1855 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1857 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1859 Extend mouse support on W32 text-mode console.
1860 * xdisp.c (draw_row_with_mouse_face):
1861 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1863 * w32console.c: Include window.h.
1864 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1866 (initialize_w32_display): Initialize mouse-highlight data.
1868 * w32inevt.c: Include termchar.h and window.h.
1869 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1870 moves, call note_mouse_highlight. If help_echo changed, call
1871 gen_help_event to produce help-echo message in the echo area.
1872 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1875 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1877 * lread.c (read1): Simplify slightly to avoid an overflow warning
1878 with GCC 4.7.0 on x86-64.
1880 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1882 * bidi.c (bidi_mirror_char): Revert last change: an int is
1883 definitely wide enough here.
1885 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1887 Fix integer width and related bugs (Bug#9874).
1888 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1889 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1890 (string_bytes, check_sblock, allocate_string_data):
1891 (compact_small_strings, Fmake_bool_vector, make_string)
1892 (make_unibyte_string, make_multibyte_string)
1893 (make_string_from_bytes, make_specified_string)
1894 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1895 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1898 (allocate_pseudovector):
1899 Use int, not EMACS_INT, where int is wide enough.
1900 (inhibit_garbage_collection, Fgarbage_collect):
1901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1902 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1903 int might not be wide enough.
1904 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1905 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1906 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1907 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1908 (bidi_level_of_next_char, bidi_move_to_visually_next):
1909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1910 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1911 (Fkill_buffer, Fset_buffer_major_mode)
1912 (advance_to_char_boundary, Fbuffer_swap_text)
1913 (Fset_buffer_multibyte, overlays_at, overlays_in)
1914 (overlay_touches_p, struct sortvec, record_overlay_string)
1915 (overlay_strings, recenter_overlay_lists)
1916 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1917 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1918 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1919 (Foverlay_recenter, last_overlay_modification_hooks_used)
1920 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1922 (validate_region): Omit unnecessary test for b <= e,
1923 since that's guaranteed by the previous test.
1924 (adjust_overlays_for_delete): Avoid pos + length overflow.
1925 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1926 (report_overlay_modification):
1927 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1928 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1929 Omit pointer cast, which isn't needed anyway, and doesn't work
1930 after the EMACS_INT -> ptrdiff_t change.
1931 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1932 * buffer.h: Adjust decls to match defn changes elsewhere.
1933 (struct buffer_text, struct buffer):
1934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1935 Use EMACS_INT, not int, where int might not be wide enough.
1936 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1937 not int, to avoid needless 32-bit limit on 64-bit hosts.
1938 (exec_byte_code): Use tighter memory-full test, one that checks
1939 for alloca overflow. Don't compute the address of the object just
1940 before an array, as that's not portable. Use EMACS_INT, not
1941 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1942 * callint.c (Fcall_interactively):
1943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1944 * callproc.c (call_process_kill, Fcall_process):
1945 Don't assume pid_t fits into an Emacs fixnum.
1946 (call_process_cleanup, Fcall_process, child_setup):
1947 Don't assume pid_t fits into int.
1948 (call_process_cleanup, Fcall_process, delete_temp_file)
1949 (Fcall_process_region):
1950 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1951 (Fcall_process): Simplify handling of volatile integers.
1952 Use int, not EMACS_INT, where int will do.
1953 * casefiddle.c (casify_object, casify_region, operate_on_word)
1954 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1956 (casify_object): Avoid integer overflow when overallocating buffer.
1957 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1958 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1959 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1960 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1961 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1962 integers are now checked earlier. All uses replaced with XINT.
1964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1965 For CCL_MapSingle, check that content and value are in int range.
1966 (ccl_driver, Fregister_code_conversion_map):
1967 Check that Vcode_version_map_vector is a vector.
1968 (resolve_symbol_ccl_program): Check that vector header is in range.
1969 Always copy the vector, so that we can check its contents reliably
1970 now rather than having to recheck each instruction as it's being
1971 executed. Check that vector words fit in 'int'.
1972 (ccl_get_compiled_code, Fregister_ccl_program)
1973 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1974 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1975 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1976 contents are in range.
1977 (Fccl_execute_on_string): Check that status is in range.
1978 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1979 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1980 Accept and return EMACS_INT, not int, because callers can pass values
1982 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1983 (multibyte_chars_in_text, parse_str_as_multibyte)
1984 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1985 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1986 (string_escape_byte8, Fget_byte):
1987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1988 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1989 avoid mishandling large integers.
1990 * character.h: Adjust decls to match defn changes elsewhere.
1991 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1992 (Ffind_charset_region):
1993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1994 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1995 (load_charset_map_from_vector, Fdefine_charset_internal):
1996 Don't assume fixnum fits in int.
1997 (load_charset_map_from_vector, Fmap_charset_chars):
1998 Remove now-unnecessary CHECK_NATNUMs.
1999 (Fdefine_charset_internal): Check ranges here, more carefully.
2000 Don't rely on undefined behavior with signed left shift overflow.
2001 Don't assume unsigned int fits into fixnum, or that fixnum fits
2002 into unsigned int. Don't require max_code to be a valid fixnum;
2003 that's not true for gb10830 4-byte on a 32-bit host. Allow
2004 invalid_code to be a cons, for the same reason. Require code_offset
2005 to be a character. Avoid int overflow if max_char is close
2007 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2008 this is intended anyway and avoids some undefined behavior.
2009 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2010 INDEX_TO_CODE_POINT, as that's what it expects.
2011 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2012 * charset.h (DECODE_CHAR): Return int, not unsigned;
2013 this is what was intended anyway, and it avoids undefined behavior.
2014 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2015 integer-overflow issues.
2016 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2017 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2018 where the argument is EMACS_INT, and this behavior is not intended.
2019 * chartab.c (Fmake_char_table, Fset_char_table_range)
2020 (uniprop_get_decoder, uniprop_get_encoder):
2021 Don't assume fixnum fits in int.
2022 * cmds.c (move_point): New function, that does the gist of
2023 Fforward_char and Fbackward_char, but does so while checking
2024 for integer overflow more accurately.
2025 (Fforward_char, Fbackward_char): Use it.
2026 (Fforward_line, Fend_of_line, internal_self_insert)
2027 (internal_self_insert):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 Fix a FIXME, by checking for integer overflow when calculating
2030 target_clm and actual_clm.
2031 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2032 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2033 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2034 (coding_alloc_by_making_gap, alloc_destination)
2035 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2036 (encode_coding_utf_16, detect_coding_emacs_mule)
2037 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2038 (detect_coding_iso_2022, decode_coding_iso_2022)
2039 (encode_invocation_designation, encode_designation_at_bol)
2040 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2041 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2042 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2043 (encode_coding_ccl, encode_coding_raw_text)
2044 (detect_coding_charset, decode_coding_charset)
2045 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2046 (produce_composition, produce_charset, produce_annotation)
2047 (decode_coding, handle_composition_annotation)
2048 (handle_charset_annotation, consume_chars, decode_coding_gap)
2049 (decode_coding_object, encode_coding_object, detect_coding_system)
2050 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2051 (code_convert_region, code_convert_string)
2052 (Fdefine_coding_system_internal)
2053 (coding_set_source, coding_set_destination):
2054 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2055 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2056 (Fdefine_coding_system_internal):
2057 Don't assume fixnums fit in int.
2058 (decode_coding_gap, decode_coding_object, encode_coding_object)
2059 (Fread_coding_system, Fdetect_coding_region)
2060 (Funencodable_char_position, Fcheck_coding_systems_region)
2061 (get_translation, handle_composition_annotation, consume_chars):
2062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2063 (consume_chars): Rewrite to not calculate an address outside buffer.
2064 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2065 Don't access memory outside of the args array.
2066 (Fdefine_coding_system_internal): Check for charset-id overflow.
2067 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2068 result of ENCODE_CHAR.
2069 * coding.h: Adjust decls to match defn changes elsewhere.
2070 (struct coding_system):
2071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2072 * composite.c (get_composition_id, find_composition)
2073 (run_composition_function, update_compositions)
2074 (compose_text, composition_gstring_put_cache)
2075 (composition_gstring_p, composition_gstring_width)
2076 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2077 (composition_compute_stop_pos, composition_reseat_it)
2078 (composition_update_it, struct position_record)
2079 (find_automatic_composition, composition_adjust_point)
2080 (Fcomposition_get_gstring, Ffind_composition_internal):
2081 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2082 (update_compositions):
2083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2084 * composite.h: Adjust decls to match defn changes elsewhere.
2085 (struct composition):
2086 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2087 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2088 Do not attempt to compute the address of the object just before a
2089 buffer; this is not portable.
2091 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2092 (Faset): Use int, not EMACS_INT, where int is wide enough.
2093 (Fstring_to_number): Don't assume fixnums fit in int.
2094 (Frem): Don't assume arg is nonnegative.
2095 * dbusbind.c (xd_append_arg): Check for integers out of range.
2096 (Fdbus_call_method): Don't overflow the timeout int.
2097 (extract_signed, extract_unsigned): New functions.
2098 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2099 (xd_get_connection_references): Return ptrdiff_t, not int.
2101 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2102 (xd_read_message_1):
2103 Use int, not unsigned, where the dbus API uses int.
2104 (Fdbus_message_internal): Don't overflow mtype.
2105 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2106 * dired.c (directory_files_internal, file_name_completion, scmp)
2107 (file_name_completion_stat):
2108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2109 (file_name_completion): Don't overflow matchcount.
2110 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2111 * dispextern.h: Adjust decls to match defn changes elsewhere.
2112 (struct text_pos, struct glyph, struct bidi_saved_info)
2113 (struct bidi_string_data, struct bidi_it, struct composition_it)
2115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2116 (struct display_pos, struct composition_it, struct it):
2117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2118 * dispnew.c (increment_matrix_positions)
2119 (increment_row_positions, mode_line_string)
2120 (marginal_area_string):
2121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2122 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2123 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2124 (duration_to_sec_usec): New function, to check for overflow better.
2125 (Fsleep_for, sit_for): Use it.
2126 * doc.c (get_doc_string, store_function_docstring):
2127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2128 (get_doc_string, Fsnarf_documentation):
2129 Use int, not EMACS_INT, where int is wide enough.
2131 Use SAFE_ALLOCA, not alloca.
2132 Check for overflow when converting EMACS_INT to off_t.
2133 * doprnt.c (doprnt):
2134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2135 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2136 Don't assume uid_t fits into fixnum.
2137 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2138 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2139 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2140 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2141 (general_insert_function)
2142 (Finsert_char, make_buffer_string, make_buffer_string_both)
2143 (update_buffer_properties, Fbuffer_substring)
2144 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2145 (Fsubst_char_in_region, check_translation)
2146 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2147 (transpose_markers, Ftranspose_regions):
2148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2149 (clip_to_bounds): Move to lisp.h as an inline function).
2150 (Fconstrain_to_field): Don't assume integers are nonnegative.
2151 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2152 (Fsubst_char_in_region, Fsave_restriction):
2153 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2154 (Femacs_pid): Don't assume pid_t fits into fixnum.
2155 (lo_time): Use int, not EMACS_INT, when int suffices.
2156 (lisp_time_argument): Check for usec out of range.
2157 (Fencode_time): Don't assume fixnum fits in int.
2158 (Fuser_login_name, Fuser_full_name): Signal an error
2159 if a uid argument is out of range, rather than relying on
2161 (Fformat_time_string): Remove now-unnecessary check.
2162 lisp_time_argument checks for out-of-range usec now.
2163 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2164 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2165 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2166 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2167 (init_cmdargs, Fdump_emacs):
2168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2169 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2170 the bottom (typically) 32 bits of the fixnum.
2171 * eval.c (specpdl_size, call_debugger):
2172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2173 (when_entered_debugger, Fbacktrace_debug):
2174 Don't assume fixnum can fit in int.
2175 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2176 the object just before a buffer; this is not portable.
2177 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2178 (grow_specpdl, unbind_to):
2179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2180 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2181 (grow_specpdl): Simplify allocation by using xpalloc.
2182 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2183 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2184 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2186 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2189 (Fcopy_file, non_regular_nbytes, read_non_regular)
2190 (Finsert_file_contents):
2191 Use int, not EMACS_INT, where int is wide enough.
2192 (READ_BUF_SIZE): Verify that it fits in int.
2193 (Finsert_file_contents): Check that counts are in proper range,
2194 rather than assuming fixnums fit into ptrdiff_t etc.
2195 Don't assume fixnums fit into int.
2196 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2197 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2198 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2199 (string_char_to_byte, string_byte_to_char)
2200 (string_make_multibyte, string_to_multibyte)
2201 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2202 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2203 (substring_both, Fdelete, internal_equal, Ffillarray)
2204 (Fclear_string, mapcar1)
2205 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2206 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2207 (larger_vector, make_hash_table, maybe_resize_hash_table)
2208 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2209 (Fmaphash, secure_hash):
2210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2211 (concat): Check for string index and length overflow.
2212 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2215 (larger_vector): New API (vec, incr_min, size_max) replaces old
2216 one (vec, new_size, init). This catches size overflow.
2217 INIT was removed because it was always Qnil.
2218 All callers changed.
2219 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2220 the upper bound on a hash table index size.
2221 (make_hash_table, maybe_resize_hash_table): Use it.
2222 (secure_hash): Computer start_byte and end_byte only after
2223 they're known to be in ptrdiff_t range.
2224 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2225 (Ffont_get_glyphs, Ffont_at):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2228 (Flist_fonts, Fopen_font):
2229 Don't assume fixnum can fit in int.
2230 (check_gstring): Don't assume index can fit in int.
2231 (font_match_p): Check that fixnum is a character, not a nonnegative
2232 fixnum, since the later code needs to stuff it into an int.
2233 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2234 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2235 conversion overflow issues.
2236 (Fopen_font): Check for integer out of range.
2237 (Ffont_get_glyphs): Don't assume index can fit in int.
2238 * font.h: Adjust decls to match defn changes elsewhere.
2239 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2241 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2242 printmax_t, where ptrdiff_t is wide enough.
2243 (Finternal_char_font):
2244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2245 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2246 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2247 (Fset_frame_position, x_set_frame_parameters)
2248 (x_set_line_spacing, x_set_border_width)
2249 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2250 Check that fixnums are in proper range for system types.
2251 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2252 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2253 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2254 Use SAFE_ALLOCA_LISP, not alloca.
2255 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2256 intptr_t is wide enough.
2257 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2258 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2259 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2260 Check for fixnum out of range.
2261 * ftfont.c (ftfont_list): Don't assume index fits in int.
2262 Check that fixnums are in proper range for system types.
2263 (ftfont_shape_by_flt):
2264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2265 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2268 Check that fixnums are in proper range for system types.
2269 * gnutls.h: Adjust decls to match defn changes elsewhere.
2270 * gtkutil.c (xg_dialog_run):
2271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2272 (update_frame_tool_bar):
2273 Check that fixnums are in proper range for system types.
2274 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2275 (lookup_image): Check that fixnums are in range for system types.
2276 * indent.c (last_known_column, last_known_column_point):
2277 (current_column_bol_cache):
2278 (skip_invisible, current_column, check_display_width):
2279 (check_display_width, scan_for_column, current_column_1)
2280 (Findent_to, Fcurrent_indentation, position_indentation)
2281 (indented_beyond_p, Fmove_to_column, compute_motion):
2282 (Fcompute_motion, Fvertical_motion):
2283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2284 (last_known_column_modified): Use EMACS_INT, not int.
2285 (check_display_width):
2287 Check that fixnums and floats are in proper range for system types.
2288 (compute_motion): Don't assume index or fixnum fits in int.
2289 (compute_motion, Fcompute_motion):
2290 Use int, not EMACS_INT, when it is wide enough.
2291 (vmotion): Omit local var start_hpos that is always 0; that way
2292 we don't need to worry about overflow in expressions involving it.
2293 * indent.h: Adjust decls to match defn changes elsewhere.
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2296 Use int, not EMACS_INT, where int is wide enough.
2297 Remove unused members ovstring_chars_done and tab_offset;
2299 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2300 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2301 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2302 (make_gap, copy_text, insert, insert_and_inherit)
2303 (insert_before_markers, insert_before_markers_and_inherit)
2304 (insert_1, count_combining_before, count_combining_after)
2305 (insert_1_both, insert_from_string)
2306 (insert_from_string_before_markers, insert_from_string_1)
2307 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2308 (adjust_after_replace, adjust_after_insert, replace_range)
2309 (replace_range_2, del_range, del_range_1, del_range_byte)
2310 (del_range_both, del_range_2, modify_region)
2311 (prepare_to_modify_buffer, signal_before_change)
2312 (signal_after_change, Fcombine_after_change_execute):
2313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2314 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2315 (balance_an_interval, split_interval_right, split_interval_left)
2316 (find_interval, next_interval, update_interval)
2317 (adjust_intervals_for_insertion, delete_node, delete_interval)
2318 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2319 (static_offset_intervals, offset_intervals)
2320 (merge_interval_right, merge_interval_left, make_new_interval)
2321 (graft_intervals_into_buffer, temp_set_point_both)
2322 (temp_set_point, set_point, adjust_for_invis_intang)
2323 (set_point_both, move_if_not_intangible, get_property_and_range)
2324 (get_local_map, copy_intervals, copy_intervals_to_string)
2325 (compare_string_intervals, set_intervals_multibyte_1):
2326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2327 * intervals.h: Adjust decls to match defn changes elsewhere.
2329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2330 * keyboard.c (this_command_key_count, this_single_command_key_start)
2331 (before_command_key_count, before_command_echo_length, echo_now)
2332 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2333 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2334 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2335 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2337 (last_non_minibuf_size, last_point_position, echo_truncate)
2338 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2339 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2340 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2341 (stuff_buffered_input):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 (last_auto_save, command_loop_1, read_char):
2344 Use EMACS_INT, not int, to avoid integer overflow.
2345 (record_char): Avoid overflow in total_keys computation.
2346 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2347 * keyboard.h: Adjust decls to match defn changes elsewhere.
2348 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2349 (Fkey_description, Fdescribe_vector, Flookup_key):
2350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2351 (click_position): New function, to check that positions are in range.
2352 (Fcurrent_active_maps):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 (Faccessible_keymaps, Fkey_description):
2356 (preferred_sequence_p):
2357 Don't assume fixnum can fit into int.
2358 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2359 Check for integer overflow in size calculations.
2360 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2361 avoid mishandling large integers.
2362 * lisp.h: Adjust decls to match defn changes elsewhere.
2363 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2364 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2365 (struct Lisp_Marker):
2366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2367 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2368 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2369 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2370 All callers changed.
2371 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2372 Assume the arg has valid form, since it always does.
2373 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2374 unsigned integer system type.
2375 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2376 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2378 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2379 (duration_to_sec_usec): New decl.
2380 * lread.c (read_from_string_index, read_from_string_index_byte)
2381 (read_from_string_limit, readchar, unreadchar, openp)
2382 (read_internal_start, read1, oblookup):
2383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2384 (Fload, readevalloop, Feval_buffer, Feval_region):
2385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2386 (openp): Check for out-of-range argument to 'access'.
2387 (read1): Use int, not EMACS_INT, where int is wide enough.
2388 Don't assume fixnum fits into int.
2389 Fix off-by-one error that can read outside a buffer.
2390 (read_filtered_event): Use duration_to_sec_usec
2391 to do proper overflow checking on durations.
2392 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2393 in size calculation.
2394 (Fexecute_kbd_macro):
2395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2396 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2397 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2398 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2399 (set_marker_both, set_marker_restricted_both, marker_position)
2400 (marker_byte_position, Fbuffer_has_markers_at):
2401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2402 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2403 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2404 It now merely ensures that the menu is large enough, without
2405 necessarily growing it, as this avoids some integer overflow issues.
2406 All callers changed.
2407 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2408 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2409 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2410 Use SAFE_ALLOCA_LISP, not alloca.
2411 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2412 to EMACS_INT. Check that fixnums are in proper range for system types.
2413 * minibuf.c (minibuf_prompt_width, string_to_object)
2414 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2415 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2417 (get_minibuffer, read_minibuf_unwind):
2418 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2419 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2420 this simplifies overflow checking. All callers changed.
2421 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2423 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2424 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2425 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2426 Check that fixnums are in proper range for system types.
2427 (Fx_create_frame, Fx_show_tip):
2428 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2429 * nsfont.m (ns_findfonts, nsfont_list_family):
2430 Don't assume fixnum fits in long.
2431 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2432 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2433 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2435 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2436 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2437 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2438 (PRINTDECLARE, PRINTPREPARE):
2439 (strout, print_string):
2440 (print, print_preprocess, print_check_string_charset_prop)
2442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2444 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2446 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2447 (printchar, strout): Use xpalloc to catch size calculation overflow.
2448 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2449 (print_error_message): Use SAFE_ALLOCA, not alloca.
2450 (print_object): Use int, not EMACS_INT, where int is wide enough.
2451 (print_depth, new_backquote_output, print_number_index):
2452 Use ptrdiff_t, not int, where int might not be wide enough.
2453 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2454 (Fset_process_window_size, Fformat_network_address)
2455 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2457 Check that fixnums are in proper range for system types.
2458 (Fsignal_process): Simplify by avoiding a goto.
2459 Check for process-ids out of pid_t range rather than relying on
2461 (process_tick, update_tick): Use EMACS_INT, not int.
2462 (Fformat_network_address, read_process_output, send_process)
2463 (Fprocess_send_region, status_notify):
2464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2465 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2466 (wait_reading_process_output, read_process_output, exec_sentinel):
2467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2468 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2469 (Faccept_process_output): Use duration_to_sec_usec to do proper
2470 overflow checking on durations.
2471 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2472 Don't assume pid_t fits in int.
2473 * process.h (struct Lisp_Process): Members tick and update_tick
2474 are now of type EMACS_INT, not int.
2475 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2476 configured --with-wide-int.
2477 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2478 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2479 * search.c (looking_at_1, string_match_1):
2480 (fast_string_match, fast_c_string_match_ignore_case)
2481 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2482 (scan_newline, find_before_next_newline, search_command)
2483 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2484 (set_search_regs, wordify):
2487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2488 (string_match_1, search_buffer, set_search_regs):
2490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2491 (wordify): Check for overflow in size calculation.
2492 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2493 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2494 Check that fixnums are in proper range for system types.
2495 * sound.c (struct sound_device)
2496 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2498 (Fplay_sound_internal):
2499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2500 * syntax.c (struct lisp_parse_state, find_start_modiff)
2501 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2502 (Fparse_partial_sexp):
2503 Don't assume fixnums can fit in int.
2504 (struct lisp_parse_state, find_start_pos, find_start_value)
2505 (find_start_value_byte, find_start_begv)
2506 (update_syntax_table, char_quoted, dec_bytepos)
2507 (find_defun_start, prev_char_comend_first, back_comment):
2508 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2509 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2511 (Finternal_describe_syntax_value): Check that match_lisp is a
2512 character, not an integer, since the code stuffs it into int.
2513 (scan_words, scan_sexps_forward):
2514 Check that fixnums are in proper range for system types.
2516 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 (scan_sexps_forward):
2518 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2519 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2520 * syntax.h: Adjust decls to match defn changes elsewhere.
2521 (struct gl_state_s):
2522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2523 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2524 MOST_POSITIVE_FIXNUM.
2525 * sysdep.c (wait_for_termination_1, wait_for_termination)
2526 (interruptible_wait_for_termination, mkdir):
2527 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2528 (emacs_read, emacs_write):
2529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2530 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2531 and double all fit in int.
2532 * term.c (set_tty_color_mode):
2533 Check that fixnums are in proper range for system types.
2534 * termhooks.h (struct input_event):
2535 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2536 * textprop.c (validate_interval_range, interval_of)
2537 (Fadd_text_properties, set_text_properties_1)
2538 (Fremove_text_properties, Fremove_list_of_text_properties)
2539 (Ftext_property_any, Ftext_property_not_all)
2540 (copy_text_properties, text_property_list, extend_property_ranges)
2541 (verify_interval_modification):
2542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2543 (Fnext_single_char_property_change)
2544 (Fprevious_single_char_property_change):
2545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2546 (copy_text_properties):
2547 Check for integer overflow in index calculation.
2548 * undo.c (last_boundary_position, record_point, record_insert)
2549 (record_delete, record_marker_adjustment, record_change)
2550 (record_property_change):
2551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2552 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2554 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2555 (Fx_hide_tip, Fx_file_dialog):
2556 * w32menu.c (set_frame_menubar):
2557 Use ptrdiff_t, not int, for consistency with rest of code.
2558 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2559 (select_window, Fdelete_other_windows_internal)
2560 (window_scroll_pixel_based, window_scroll_line_based)
2561 (Frecenter, Fset_window_configuration):
2562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2563 (Fset_window_hscroll, run_window_configuration_change_hook)
2564 (set_window_buffer, temp_output_buffer_show, scroll_command)
2565 (Fscroll_other_window, Frecenter):
2566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2567 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2568 Don't assume fixnum fits in int.
2569 (Fset_window_scroll_bars):
2570 Check that fixnums are in proper range for system types.
2571 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2572 (string_pos, c_string_pos, number_of_chars, init_iterator)
2573 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2574 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2575 (compute_display_string_end, handle_face_prop)
2576 (face_before_or_after_it_pos, handle_invisible_prop)
2577 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2578 (display_prop_intangible_p, string_buffer_position_lim)
2579 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2580 (get_overlay_strings_1, get_overlay_strings)
2581 (iterate_out_of_display_property, forward_to_next_line_start)
2582 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2583 (get_next_display_element, set_iterator_to_next)
2584 (get_visually_first_element, compute_stop_pos_backwards)
2585 (handle_stop_backwards, next_element_from_buffer)
2586 (move_it_in_display_line_to, move_it_in_display_line)
2587 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2588 (add_to_log, message_dolog, message_log_check_duplicate)
2589 (message2, message2_nolog, message3, message3_nolog
2590 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2591 (current_message_1, truncate_echo_area, truncate_message_1)
2592 (set_message, set_message_1, store_mode_line_noprop)
2593 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2594 (text_outside_line_unchanged_p, check_point_in_composition)
2595 (reconsider_clip_changes)
2596 (redisplay_internal, set_cursor_from_row, try_scrolling)
2597 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2598 (redisplay_window, find_last_unchanged_at_beg_row)
2599 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2600 (trailing_whitespace_p, find_row_edges, display_line)
2601 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2602 (display_mode_element, store_mode_line_string)
2603 (pint2str, pint2hrstr, decode_mode_spec)
2604 (display_count_lines, display_string, draw_glyphs)
2605 (x_produce_glyphs, x_insert_glyphs)
2606 (rows_from_pos_range, mouse_face_from_buffer_pos)
2607 (fast_find_string_pos, mouse_face_from_string_pos)
2608 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2609 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2610 (safe_call, init_from_display_pos, handle_fontified_prop)
2611 (handle_single_display_spec, load_overlay_strings)
2612 (with_echo_area_buffer, setup_echo_area_for_printing)
2613 (display_echo_area, echo_area_display)
2614 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2615 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2616 (redisplay_window, dump_glyph_row, display_mode_line)
2617 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2618 (handle_display_spec, display_prop_string_p):
2619 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2620 (handle_single_display_spec, build_desired_tool_bar_string)
2621 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2622 (get_specified_cursor_type):
2623 Check that fixnums are in proper range for system types.
2624 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2625 (Flookup_image_map):
2626 Don't assume fixnums fit in int.
2627 (compare_overlay_entries):
2628 Avoid mishandling comparisons due to subtraction overflow.
2629 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2630 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2631 (handle_tool_bar_click):
2632 Use int, not unsigned, since we prefer signed and the signedness
2633 doesn't matter here.
2634 (get_next_display_element, next_element_from_display_vector):
2635 Use int, not EMACS_INT, when int is wide enough.
2636 (start_hourglass): Use duration_to_sec_usec to do proper
2637 overflow checking on durations.
2638 * xfaces.c (Fbitmap_spec_p):
2639 Check that fixnums are in proper range for system types.
2640 (compare_fonts_by_sort_order):
2641 Avoid mishandling comparisons due to subtraction overflow.
2642 (Fx_family_fonts, realize_basic_faces):
2643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2645 Don't assume fixnum fits in int.
2646 Use SAFE_ALLOCA_LISP, not alloca.
2647 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2648 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2649 (face_at_buffer_position, face_for_overlay_string)
2650 (face_at_string_position):
2651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2652 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2653 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2655 Check that fixnums are in proper range for system types.
2656 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2657 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2659 (Fx_change_window_property): Don't assume fixnums fit in int.
2660 * xfont.c (xfont_chars_supported):
2661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2662 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2663 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2665 * xml.c (parse_region):
2666 * xrdb.c (magic_file_p):
2667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2668 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2669 (x_get_local_selection, x_reply_selection_request)
2670 (x_handle_selection_request, wait_for_property_change):
2671 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2672 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2673 short is wide enough.
2674 (x_send_client_event): Don't assume fixnum fits in int.
2675 * xterm.c (x_x_to_emacs_modifiers):
2676 Don't assume EMACS_INT overflows nicely into int.
2677 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2679 (handle_one_xevent): NATNUMP can eval its arg twice.
2680 (x_connection_closed):
2681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2682 * xterm.h: Adjust decls to match defn changes elsewhere.
2683 (struct scroll_bar): Use struct vectorlike_header
2684 rather than rolling our own approximation.
2685 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2687 2012-05-25 Glenn Morris <rgm@gnu.org>
2689 * lisp.mk (lisp): Update for more files being compiled now.
2691 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2693 * lread.c: Remove `read_pure' which makes no difference.
2694 (read_pure): Remove var.
2695 (unreadpure): Remove function.
2696 (readevalloop): Don't call read_list with -1 flag.
2697 (read1, read_vector): Don't test read_pure any more.
2698 (read_list): Simplify.
2700 * fileio.c, character.h: Minor style tweaks.
2702 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2704 * window.h (clip_changed): Remove useless declaration.
2706 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2708 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2709 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2711 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2714 This directory predates autoconf and is no longer needed nowadays.
2715 Move its few remaining bits of functionality to where they're needed.
2716 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2717 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2718 * m/template.h: Remove.
2719 * Makefile.in (M_FILE): Remove. All uses removed.
2720 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2721 * lisp.h (USE_LSB_TAG):
2722 * mem-limits.h (EXCEEDS_LISP_PTR):
2723 Use VAL_MAX, not VALBITS, in #if.
2724 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2725 (EMACS_UINT): Define unconditionally now.
2726 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2727 (BITS_PER_EMACS_INT): New constants, replacing
2728 what used to be in config.h, but not useful in #if.
2729 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2730 define them any more.
2731 (VAL_MAX): New macro.
2733 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2734 BITS_PER_EMACS_INT, in #if.
2735 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2736 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2737 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2738 * s/ms-w32.h (DATA_START):
2739 Move here from removed file m/intel386.h.
2740 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2741 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2743 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2745 Assume C89 or later.
2746 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2747 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2749 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2750 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2751 * textprop.c, tparam.c (NULL): Remove.
2752 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2753 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2754 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2755 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2756 * xterm.c (input_signal_count): Assume volatile works.
2758 2012-05-21 Ken Brown <kbrown@cornell.edu>
2760 * xgselect.c (xg_select): Fix first argument in call to 'select'
2763 2012-05-20 Ken Brown <kbrown@cornell.edu>
2765 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2766 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2768 2012-05-19 Ken Brown <kbrown@cornell.edu>
2770 * xfns.c (x_in_use): Remove `static' qualifier.
2771 * xterm.h (x_in_use): Declare.
2772 * xgselect.c: Include xterm.h.
2773 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2774 and `display_arg' (bug#9754).
2776 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2778 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2780 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2781 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2783 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2785 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2787 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2788 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2790 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2791 reference to image_cache->refcount.
2792 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2794 2012-05-17 Juri Linkov <juri@jurta.org>
2796 * search.c (Fword_search_regexp, Fword_search_backward)
2797 (Fword_search_forward, Fword_search_backward_lax)
2798 (Fword_search_forward_lax): Move functions to isearch.el
2799 (bug#10145, bug#11381).
2801 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2803 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2805 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2807 * lread.c (init_obarray): Declare Qt and Qnil as special.
2809 2012-05-14 Glenn Morris <rgm@gnu.org>
2811 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2812 Put "libexec" before "bin", for the sake of init_callproc_1.
2814 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2816 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2818 * unexaix.c: Port to more-recent AIX compilers.
2819 (report_error, report_error_1, make_hdr, copy_sym)
2820 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2821 Make arguments const char *, not char *, to avoid violations of C
2822 standard and to fix some AIX warnings reported by Gilles Pion.
2824 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2826 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2827 already have overlays loaded.
2828 (handle_single_display_spec): Before returning without displaying
2829 fringe bitmap, synchronize the bidi iterator with the main display
2830 iterator, by calling iterate_out_of_display_property.
2831 (iterate_out_of_display_property): Detect buffer iteration by
2832 testing that it->string is a Lisp string.
2833 (get_next_display_element): When the current object is exhausted,
2834 and there's something on it->stack, call set_iterator_to_next to
2835 proceed with what's on the stack, instead of returning zero.
2836 (set_iterator_to_next): If called at the end of a Lisp string,
2837 proceed to consider_string_end without incrementing string
2838 position. Don't increment display vector index past the end of
2839 the display vector. (Bug#11417)
2840 (pos_visible_p): Don't report a position visible when move_it_to
2841 stopped at the last line of window, which happens to be scanned
2842 backwards by the bidi iteration. (Bug#11464)
2844 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2846 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2847 and right-margin display specs even if the spec is invalid or we
2848 are on a TTY, and thus unable to display on the fringes.
2849 That's because the text with the property will not be displayed anyway,
2850 so we need to signal to the caller that this is a "replacing"
2851 display spec. This fixes display when the spec is invalid or we
2854 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2856 * unexaix.c (make_hdr): Fix typo in prototype.
2857 This bug broke the build on AIX. Problem reported by Gilles Pion.
2859 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2861 * keyboard.c (kbd_buffer_get_event): Read special events also in
2862 batch mode. (Bug#11415)
2864 2012-05-12 Glenn Morris <rgm@gnu.org>
2866 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2868 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2870 * lisp.mk (lisp): Add newcomment.elc.
2872 2012-05-12 Glenn Morris <rgm@gnu.org>
2874 * Makefile.in (MKDIR_P): New, set by configure.
2875 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2877 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2879 Remove unused function hourglass_started.
2880 * dispextern.h (hourglass_started):
2881 * w32fns.c (hourglass_started):
2882 * xdisp.c (hourglass_started): Remove.
2884 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2886 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2887 Update dependencies.
2889 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2891 * xgselect.c (xg_select): Put maxfds+1 into a var.
2892 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2894 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2896 2012-05-10 Dave Abrahams <dave@boostpro.com>
2898 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2899 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2901 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2903 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2904 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2905 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2906 Initialize xd_registered_buses.
2908 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2910 Untag more efficiently if USE_LSB_TAG.
2911 This is based on a proposal by YAMAMOTO Mitsuharu in
2912 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2913 For an admittedly artificial (nth 8000 longlist) benchmark on
2914 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2915 Emacs's overall text size by 1%.
2916 * lisp.h (XUNTAG): New macro.
2917 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2918 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2919 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2920 * eval.c (Fautoload):
2921 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2922 * frame.h (XFRAME): Use XUNTAG.
2924 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2925 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2926 Remove unportable assumptions about print widths of types like
2928 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2929 intptr_t when converting between pointer and integer, to avoid GCC
2930 warnings about wrong width.
2932 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2934 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2935 stack for each reader_thread, instead of defaulting to 8MB
2936 determined by the linker. This avoids failures in creating
2937 subprocesses on Windows 7, see the discussion in this thread:
2938 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2940 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2942 Fix up display of the *Minibuf-0* buffer in the mini window.
2943 * keyboard.c (read_char): Don't clear the echo area if there's no
2945 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2946 contents of *Minibuf-0*) if there's no message displayed in its stead.
2948 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2950 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2953 2012-05-06 Chong Yidong <cyd@gnu.org>
2955 * lisp.mk (lisp): Update.
2957 2012-05-05 Jim Meyering <meyering@redhat.com>
2959 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2961 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2963 * data.c (PUT_ERROR): New macro.
2964 (syms_of_data): Use it. Add new error type `user-error'.
2965 * undo.c (user_error): New function.
2966 (Fprimitive_undo): Use it.
2967 * print.c (print_error_message): Adjust print style for `user-error'.
2968 * keyboard.c (user_error): New function.
2969 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2971 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2973 Do not limit current-time-string to years 1000..9999.
2974 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2975 (Fcurrent_time_string): Support any year that is supported by the
2976 underlying localtime representation. Don't use asctime, as it
2977 has undefined behavior for years outside the range -999..9999.
2979 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2981 Fix race conditions involving setenv, gmtime, localtime, asctime.
2982 Without this fix, interrupts could mess up code that uses these
2983 nonreentrant functions, since setting TZ invalidates existing
2984 tm_zone or tzname values, and since most of these functions return
2985 pointers to static storage.
2986 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2987 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2988 Grow the critical sections to include not just invoking
2989 localtime/gmtime, but also accessing these functions' results
2990 including their tm_zone values if any, and any related TZ setting.
2991 (format_time_string): Last arg is now struct tm *, not struct tm **,
2992 so that the struct tm is saved in the critical section.
2993 All callers changed. Simplify allocation of initial buffer, partly
2994 motivated by the fact that memory allocation needs to be outside
2995 the critical section.
2997 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2999 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3000 with RESET_INTERVAL.
3002 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3003 Remove duplicated buffer name initialization.
3005 2012-05-02 Jim Meyering <jim@meyering.net>
3007 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3009 * xfns.c (x_window): Use xstrdup (Bug#11375).
3011 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3013 * xdisp.c (pos_visible_p): If already at a newline from the
3014 display string before the 'while' loop, don't walk back the glyphs
3015 from it3.glyph_row. Solves assertion violation when the display
3016 string begins with a newline (egg.el). (Bug#11367)
3018 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3020 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3023 2012-05-01 Glenn Morris <rgm@gnu.org>
3025 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3026 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3027 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3028 All were removed before 23.1.
3030 * dispnew.c: Remove HAVE_LIBNCURSES test;
3031 it is always true on relevant platforms.
3033 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3034 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3036 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3038 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3040 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3041 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3044 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3046 Do not avoid creating empty evaporating overlays (Bug#9642).
3047 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3048 That is, do not delete an evaporating overlay if it becomes
3049 empty after its bounds are adjusted to fit within its buffer.
3050 This fix caused other problems, and I'm reverting it until we get
3051 to the bottom of them.
3053 2012-04-27 Chong Yidong <cyd@gnu.org>
3055 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3057 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3059 * xdisp.c (pos_visible_p): If the window start position is beyond
3060 ZV, start the display from buffer beginning. Prevents assertion
3061 violation in init_iterator when the minibuffer window is scrolled
3064 * window.c (window_scroll_pixel_based): Likewise.
3066 2012-04-27 Chong Yidong <cyd@gnu.org>
3068 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3070 2012-04-27 Glenn Morris <rgm@gnu.org>
3072 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3073 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3075 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3077 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3078 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3080 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3082 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3083 display element, check also the underlying string or buffer
3084 character. (Bug#11341)
3086 * w32menu.c: Include w32heap.h.
3087 (add_menu_item): If the call to AppendMenuW (via
3088 unicode_append_menu) fails, disable Unicode menus only if we are
3089 running on Windows 9X/Me.
3091 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3093 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3094 (xgetint): Add missing shift for LSB tags.
3096 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3098 * keyboard.c (read_char): Don't wipe echo area for select window
3099 events: These might get delayed via `mouse-autoselect-window'
3102 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3104 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3105 manipulation of :loaded-from data.
3107 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3109 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3110 now a cons (bug#11311).
3112 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3114 Do not create empty overlays with the evaporate property (Bug#9642).
3115 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3116 if it becomes empty after its bounds are adjusted to fit within
3117 its buffer. Without this fix, in a nonempty buffer (let ((o
3118 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3119 yields an empty overlay that has the evaporate property, which is
3120 not supposed to happen.
3122 Fix minor GTK3 problems found by static checking.
3123 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3124 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3125 (struct _EmacsFixedClass, emacs_fixed_get_type):
3126 Move decls here from emacsgtkfixed.h, since they needn't be public.
3127 (emacs_fixed_get_type): Now static.
3128 (emacs_fixed_class_init): Omit unused local.
3129 (emacs_fixed_child_type): Remove; unused.
3130 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3131 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3132 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3133 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3134 (EMACS_FIXED_GET_CLASS): Remove; unused.
3135 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3137 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3138 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3140 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3142 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3143 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3144 (__malloc_size_t, __malloc_ptrdiff_t):
3145 Remove. All uses removed, replaced by the definiens if needed,
3146 since we can assume C89 or better now.
3147 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3148 (protect_malloc_state, align, get_contiguous_space)
3149 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3150 (malloc_atfork_handler_child, malloc_enable_thread)
3151 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3152 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3153 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3154 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3155 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3156 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3157 Define using prototypes, not old style.
3158 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3159 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3160 (align): Don't assume that signed integer overflow wraps around.
3161 Omit unused local var.
3162 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3163 (_free_internal_nolock, memalign, mallochook, reallochook):
3164 Omit no-longer-needed casts.
3165 (valloc): Use getpagesize, not __getpagesize.
3166 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3167 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3169 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3171 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3173 Move functions from C to Lisp. Make non-blocking method calls
3174 the default. Implement further D-Bus standard interfaces.
3176 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3177 (QCdbus_request_name_allow_replacement)
3178 (QCdbus_request_name_replace_existing)
3179 (QCdbus_request_name_do_not_queue)
3180 (QCdbus_request_name_reply_primary_owner)
3181 (QCdbus_request_name_reply_in_queue)
3182 (QCdbus_request_name_reply_exists)
3183 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3184 (QCdbus_registered_serial, QCdbus_registered_method)
3185 (QCdbus_registered_signal): New Lisp objects.
3186 (XD_DEBUG_MESSAGE): Use sizeof.
3187 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3188 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3189 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3190 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3191 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3192 (xd_signature, xd_append_arg): Allow float for integer types.
3193 (xd_get_connection_references): New function.
3194 (xd_get_connection_address): Rename from xd_initialize.
3195 Return cached address.
3196 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3197 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3199 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3200 Return number of refcounts.
3201 (Fdbus_get_unique_name): Make stronger parameter check.
3202 (Fdbus_message_internal): New defun.
3203 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3204 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3205 (Fdbus_send_signal, Fdbus_register_service)
3206 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3207 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3208 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3209 (Vdbus_compiled_version, Vdbus_runtime_version)
3210 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3211 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3212 (Vdbus_message_type_signal): New defvars.
3213 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3216 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3218 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3219 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3220 Do not assume ptrdiff_t is the same width as 'int'.
3222 * alloc.c: Handle unusual debugging option combinations.
3223 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3224 since the two debugging options are incompatible.
3225 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3227 (mem_init, mem_insert, mem_insert_fixup):
3228 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3229 (NEED_MEM_INSERT): Remove; no longer needed.
3231 2012-04-22 Leo Liu <sdl.web@gmail.com>
3233 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3235 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3237 * sysdep.c [__FreeBSD__]: Minor cleanups.
3238 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3239 Use Emacs indenting style more consistently. Avoid some casts.
3240 Use 'double' consistently rather than mixing 'float' and 'double'.
3242 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3244 * sysdep.c (list_system_processes, system_process_attributes):
3245 Add implementation for FreeBSD (Bug#5243).
3247 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3249 * lisp.mk (lisp): Update.
3251 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3253 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3254 It is never used otherwise.
3256 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3258 * print.c (print_preprocess): Only check print_depth if print-circle
3260 (print_object): Check for cycles even when print-circle is nil and
3261 print-gensym is t, but only check print_depth if print-circle is nil.
3263 2012-04-20 Chong Yidong <cyd@gnu.org>
3265 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3266 set the status to "failed" and ensure that sentinel is run.
3268 2012-04-20 Glenn Morris <rgm@gnu.org>
3270 * process.c (Fset_process_inherit_coding_system_flag)
3271 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3272 (Fmake_network_process, Fmake_serial_process): Doc fix.
3274 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3276 * xdisp.c (string_buffer_position_lim): Limit starting position to
3278 (set_cursor_from_row): If called for a mode-line or header-line
3279 row, return zero immediately.
3280 (try_cursor_movement): If inside continuation line, don't back up
3281 farther than the first row after the header line, if any.
3282 Don't consider the header-line row as "partially visible", even if
3283 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3285 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3287 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3290 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3291 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3293 configure: new option --enable-gcc-warnings (Bug#11207)
3294 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3295 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3296 (ALL_CFLAGS): Use new macros rather than old.
3297 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3298 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3299 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3300 -Wunused-result, -Wunused-variable. This should go away once
3301 the Emacs and Gnulib regex code is merged.
3302 (xmalloc, xrealloc): Now static.
3304 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3306 * dired.c (Fsystem_groups): Remove unused local.
3308 2012-04-17 Glenn Morris <rgm@gnu.org>
3310 * dired.c (Fsystem_users): Doc fix.
3312 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3314 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3315 (syms_of_dired): Add them.
3317 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3319 Fix minor alloc.c problems found by static checking.
3320 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3321 New extern decls, to avoid calling undeclared functions.
3322 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3323 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3324 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3325 (NEED_MEM_INSERT): New macro.
3326 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3327 Remove one incorrect comment and fix another.
3329 Fix minor ralloc.c problems found by static checking.
3330 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3331 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3332 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3333 (r_alloc_sbrk): Now static.
3335 Improve ralloc.c interface checking.
3336 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3337 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3338 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3339 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3340 [REL_ALLOC]: ... to here, to check interface.
3341 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3342 Remove decls. This fixes an "It stinks!".
3344 * alloc.c (which_symbols): Fix alignment issue / type clash.
3346 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3348 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3349 (struct Lisp_Misc_Any): Likewise.
3350 (struct Lisp_Free): Likewise.
3351 * alloc.c (union aligned_Lisp_Symbol): Define.
3352 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3353 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3354 (union aligned_Lisp_Misc): Define.
3355 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3356 aligned_Lisp_Misc instead of union Lisp_Misc.
3357 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3359 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3361 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3362 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3363 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3364 * s/netbsd.h, s/sol2-6.h:
3365 Remove definition of GC_MARK_STACK, since the default now works.
3366 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3367 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3368 no longer the default.
3369 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3371 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3373 * lread.c (lisp_file_lexically_bound_p):
3374 Fix hang at ";-*-\n" (bug#11238).
3376 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3378 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3379 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3381 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3383 * nsterm.m (constrainFrameRect): Always constrain when there is only
3384 one screen (Bug#10962).
3386 2012-04-13 Ken Brown <kbrown@cornell.edu>
3388 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3390 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3392 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3394 2012-04-11 Daniel Colascione <dancol@dancol.org>
3396 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3397 against is gone. It's better to use vfork now so that when Cygwin
3398 gains a new, working vfork, we use it automatically (bug#10398).
3400 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3402 * window.c (save_window_save): Obey window-point-insertion-type.
3404 2012-04-11 Glenn Morris <rgm@gnu.org>
3406 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3408 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3410 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3412 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3414 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3415 (force_quit_count): New var.
3416 (handle_interrupt): Use it.
3418 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3420 * w32.c (w32_delayed_load): Record the full path of the library
3421 being loaded (bug#10424).
3423 2012-04-09 Glenn Morris <rgm@gnu.org>
3425 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3426 not just in the obarray, before snarfing them. (Bug#11036)
3428 * Makefile.in ($(leimdir)/leim-list.el):
3429 Pass EMACS rather than BUILT_EMACS.
3431 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3433 * process.c (make_process):
3434 * process.h: Add integer `gnutls_handshakes_tried' member to
3437 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3438 Add convenience `GNUTLS_LOG2i' macro.
3440 * gnutls.c (gnutls_log_function2i): Convenience log function.
3441 (emacs_gnutls_read): Use new log functions,
3442 `gnutls_handshakes_tried' process member, and
3443 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3444 attempts per process (connection).
3446 2012-04-09 Chong Yidong <cyd@gnu.org>
3448 * eval.c (Fuser_variable_p, user_variable_p_eh)
3449 (lisp_indirect_variable): Functions deleted.
3450 (Fdefvar): Caller changed.
3452 * callint.c (Finteractive, Fcall_interactively):
3453 * minibuf.c (Fread_variable): Callers changed.
3455 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3457 * xdisp.c (set_cursor_from_row): If the display string appears in
3458 the buffer at position that is closer to point than the position
3459 after the display string, display the cursor on the first glyph of
3460 the display string. Fixes cursor display when a 'display' text
3461 property immediately follows invisible text. (Bug#11094)
3463 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3465 composite.c: use 'double' consistently
3466 * composite.c (get_composition_id): Use 'double' consistently
3467 instead of converting 'float' to 'double' and vice versa; this is
3468 easier to understand and avoids a GCC warning.
3470 2012-04-09 Glenn Morris <rgm@gnu.org>
3472 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3473 preparation for dumping it with emacs. (Bug#4789)
3474 (leimdir): New variable.
3475 ($(leimdir)/leim-list.el): New rule.
3476 (emacs$(EXEEXT)): Depend on leim-list.el.
3478 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3479 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3480 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3482 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3484 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3487 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3489 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3490 Remove unused local variable.
3492 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3494 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3495 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3496 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3497 objects, as mark_maybe_pointer will catch them otherwise.
3498 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3499 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3501 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3503 Fix typo that broke non-Windows builds.
3504 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3506 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3508 Support building on MS-Windows with libxml2.
3510 * makefile.w32-in (OBJ2): Add xml.$(O).
3511 (GLOBAL_SOURCES): Add xml.c.
3512 ($(BLD)/xml.$(O)): New dependency list.
3514 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3515 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3516 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3517 [!WINDOWSNT]: New macros.
3518 (init_libxml2_functions, libxml2_loaded_p): New functions.
3519 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3520 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3521 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3522 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3524 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3525 Call init_libxml2_functions before calling libxml2 functions.
3526 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3528 * emacs.c: Don't include libxml/parser.h.
3529 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3530 xmlCleanupParser directly.
3532 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3534 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3536 * indent.c (Fvertical_motion): If there is a display string at
3537 point, use it.vpos to compute how many lines to backtrack after
3538 move_it_to point. (Bug#11133)
3540 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3542 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3543 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3544 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3545 macros related to unification of CJK characters. For the details,
3546 see the discussion following the message here:
3547 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3549 2012-04-04 Chong Yidong <cyd@gnu.org>
3551 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3553 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3555 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3556 instead of alloca. (Bug#11138)
3558 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3560 * w32menu.c (is_simple_dialog): Properly check lisp types.
3563 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3565 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3566 position we get to after a call to move_it_to fails the
3567 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3568 only if we wind up in a string from display property. (Bug#11063)
3570 * window.c (Fdelete_other_windows_internal): Invalidate the row
3571 and column information about mouse highlight, so that redisplay
3572 restores it after reallocating the glyph matrices. (Bug#7464)
3574 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3575 string comes from a `display' text property, use the buffer
3576 position of that property as if we actually saw that position in
3578 (move_it_by_lines): Remove the assertion that
3579 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3580 violated when there's a before-string at the beginning of a line.
3583 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3585 * xdisp.c (append_space_for_newline): If the default face was
3586 remapped, use the remapped face for the appended newline.
3587 (extend_face_to_end_of_line): Use the remapped default face for
3588 extending the face to the end of the line.
3589 (display_line): Call extend_face_to_end_of_line when the default
3590 face was remapped. (Bug#11068)
3592 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3594 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3596 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3598 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3600 2012-03-27 Glenn Morris <rgm@gnu.org>
3602 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3605 2012-03-26 Kenichi Handa <handa@m17n.org>
3607 * dispextern.h (struct glyph): Fix previous change. Change the
3608 bit length of glyphless.ch to 25 (Bug#11082).
3610 2012-03-26 Chong Yidong <cyd@gnu.org>
3612 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3613 (command_loop_1): Use it; inhibit selection update for
3614 handle-select-window too (Bug#8996).
3616 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3618 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3620 2012-03-25 Kenichi Handa <handa@m17n.org>
3622 * dispextern.h (struct glyph): Change the bit length of
3623 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3625 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3627 * s/ms-w32.h (tzname): Include time.h before redirecting to
3628 _tzname. Fixes the MSVC build. (Bug#9960)
3630 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3632 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3635 * xterm.c (XTread_socket): Only modify handling_signal if
3636 !SYNC_INPUT. (Bug#11080)
3638 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3640 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3641 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3642 when fetching a multibyte character consumes more bytes than
3643 CHAR_BYTES returns, due to unification of CJK characters in
3644 string_char. (Bug#11073)
3646 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3648 * process.c (wait_reading_process_output): Handle pty disconnect
3649 by refraining from sending oneself a SIGCHLD (bug#10933).
3651 2012-03-22 Chong Yidong <cyd@gnu.org>
3653 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3655 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3656 Mark string as coming from a prefix property.
3657 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3658 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3660 2012-03-21 Chong Yidong <cyd@gnu.org>
3662 * xfaces.c (Vface_remapping_alist): Doc fix.
3664 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3666 * w32proc.c (Fw32_set_console_codepage)
3667 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3670 2012-03-20 Chong Yidong <cyd@gnu.org>
3672 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3673 to reflect default non-nil value of redisplay-dont-pause.
3675 2012-03-19 Kenichi Handa <handa@m17n.org>
3677 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3678 it fit in a valid range (Bug#11003).
3680 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3682 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3683 that is not from display property, accept the row as a "cursor
3684 row" if one of the string's character has a non-nil `cursor'
3685 property. Fixes cursor positioning when there are newlines in
3686 overlay strings, e.g. in icomplete.el. (Bug#11035)
3688 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3690 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3692 2012-03-12 Chong Yidong <cyd@gnu.org>
3694 * eval.c (inhibit_lisp_code): Rename from
3695 inhibit_window_configuration_change_hook; move from window.c.
3697 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3698 * window.c (run_window_configuration_change_hook)
3699 (syms_of_window): Callers changed.
3701 2012-03-11 Chong Yidong <cyd@gnu.org>
3703 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3705 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3707 2012-03-10 Chong Yidong <cyd@gnu.org>
3709 * frame.c (other_visible_frames): Don't assume the selected frame
3710 is visible (Bug#10955).
3712 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3714 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3716 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3718 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3719 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3722 2012-03-03 Glenn Morris <rgm@gnu.org>
3724 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3726 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3728 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3729 position past the first glyph_row that ends at ZV. (Bug#10902)
3730 (redisplay_window, next_element_from_string): Fix typos in
3732 (redisplay_window): Pass to move_it_vertically the margin in
3733 pixels, not in screen lines.
3735 2012-03-02 Glenn Morris <rgm@gnu.org>
3737 * buffer.c (buffer-list-update-hook): Doc fix.
3739 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3741 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3742 push_it before setting up the iterator for the first overlay
3743 string, even if we have an empty string loaded.
3744 (next_overlay_string): If there's an empty string on the iterator
3745 stack, pop the stack. (Bug#10903)
3747 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3749 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3750 Suggested by Stefan Monnier in
3751 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3752 * alloc.c (widen_to_Lisp_Object): New static function.
3753 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3754 and widening them to Lisp_Objects. This would work even if
3755 USE_LSB_TAG is defined and wide integers are used, which might
3756 happen in a future version of Emacs.
3758 2012-02-25 Chong Yidong <cyd@gnu.org>
3760 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3763 * xselect.c (Fx_selection_exists_p): Doc fix.
3764 (x_clipboard_manager_save_all): Print an informative message
3765 before saving to clipboard manager.
3767 2012-02-24 Chong Yidong <cyd@gnu.org>
3769 * keyboard.c (process_special_events): Handle all X selection
3770 requests in kbd_buffer, not just the next one (Bug#8869).
3772 2012-02-23 Chong Yidong <cyd@gnu.org>
3774 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3775 call when setting menu-bar-lines and tool-bar-lines parameters.
3776 (unwind_create_frame_1): New helper function.
3778 * window.c (inhibit_window_configuration_change_hook): New var.
3779 (run_window_configuration_change_hook): Obey it.
3780 (syms_of_window): Initialize it.
3782 2012-02-22 Chong Yidong <cyd@gnu.org>
3784 * xterm.c (x_draw_image_relief): Add missing type check for
3785 Vtool_bar_button_margin (Bug#10743).
3787 2012-02-21 Chong Yidong <cyd@gnu.org>
3789 * fileio.c (Vfile_name_handler_alist): Doc fix.
3791 * buffer.c (Fget_file_buffer): Protect against invalid file
3792 handler return value.
3794 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3796 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3797 when computing $valmask.
3799 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3800 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3801 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3802 It's useless in that case, and it can cause problems on hosts
3803 that allocate halves of EMACS_INT values separately.
3804 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3805 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3806 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3807 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3808 it avoids undefined behavior on hosts where shifting right by more
3809 than the word width has undefined behavior.
3811 2012-02-19 Chong Yidong <cyd@gnu.org>
3813 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3814 (Funhandled_file_name_directory, Ffile_name_as_directory)
3815 (Fdirectory_file_name, Fexpand_file_name)
3816 (Fsubstitute_in_file_name): Protect against invalid file handler
3817 return values (Bug#10845).
3819 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3821 * .gdbinit (pitx): Fix incorrect references to fields of the
3824 2012-02-17 Chong Yidong <cyd@gnu.org>
3826 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3828 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3830 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3831 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3833 2012-02-15 Chong Yidong <cyd@gnu.org>
3835 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3836 marked as special. Also, starting docstrings with * is obsolete.
3838 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3840 * gnutls.c (emacs_gnutls_write): Fix last change.
3842 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3844 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3847 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3849 * keymap.c (Fsingle_key_description): Handle char ranges.
3851 2012-02-12 Chong Yidong <cyd@gnu.org>
3853 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3854 as that creates a dangerous corner case.
3856 * window.c (Fdelete_window_internal): Invalidate the mouse
3857 highlight (Bug#9904).
3859 2012-02-12 Glenn Morris <rgm@gnu.org>
3861 * xselect.c (Fx_own_selection_internal)
3862 (Fx_get_selection_internal, Fx_disown_selection_internal)
3863 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3864 * nsselect.m (Fx_own_selection_internal)
3865 (Fx_disown_selection_internal, Fx_selection_exists_p)
3866 (Fx_selection_owner_p, Fx_get_selection_internal):
3867 Sync docs and argument specs with the xselect.c versions.
3869 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3871 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3873 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3875 * w32select.c (Fx_selection_exists_p): Sync doc string and
3876 argument list with xselect.c. (Bug#10783)
3878 * w16select.c (Fx_selection_exists_p): Sync doc string and
3879 argument list with xselect.c. (Bug#10783)
3881 2012-02-10 Glenn Morris <rgm@gnu.org>
3883 * fns.c (Fsecure_hash): Doc fix.
3885 2012-02-09 Kenichi Handa <handa@m17n.org>
3887 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3889 2012-02-07 Chong Yidong <cyd@gnu.org>
3891 * buffer.c (Fbuffer_local_variables)
3892 (buffer_lisp_local_variables): Handle unbound vars correctly;
3893 don't let Qunbound leak into Lisp.
3895 2012-02-07 Glenn Morris <rgm@gnu.org>
3897 * image.c (Fimagemagick_types): Doc fix.
3899 * image.c (imagemagick-render-type): Change it from a lisp object
3900 to an integer. Move the doc here from the lisp manual.
3901 Treat all values not equal to 0 the same.
3903 2012-02-06 Chong Yidong <cyd@gnu.org>
3905 * doc.c (store_function_docstring): Avoid applying docstring of
3906 alias to base function (Bug#2603).
3908 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3910 * .gdbinit (pp1, pv1): Remove redundant defines.
3913 2012-02-04 Chong Yidong <cyd@gnu.org>
3915 * nsterm.m: Declare a global (Bug#10694).
3917 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3919 * w32.c (get_emacs_configuration_options):
3920 Include --enable-checking, if specified, in the return value.
3922 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3924 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3925 after rounding frame sizes. (Bug#9723)
3927 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3929 * keyboard.c (adjust_point_for_property): Don't position point
3930 before BEGV. (Bug#10696)
3932 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3934 Handle overflow when computing char display width (Bug#9496).
3935 * character.c (char_width): Return EMACS_INT, not int.
3936 (char_width, c_string_width): Check for overflow when
3937 computing the width; this is possible now that individual
3938 characters can have unbounded width. Problem introduced
3939 by merge from Emacs 23 on 2012-01-19.
3941 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3943 * dbusbind.c (Fdbus_register_method): Mention the return value
3944 :ignore in the docstring.
3946 2012-02-02 Glenn Morris <rgm@gnu.org>
3948 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3950 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3951 Unconditionally set to t. (Bug#10673)
3952 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3953 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3954 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3956 2012-02-02 Kenichi Handa <handa@m17n.org>
3958 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3959 0, do not call append_composite_glyph.
3961 2012-02-02 Kenichi Handa <handa@m17n.org>
3963 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3965 (x_produce_glyphs): If the component of a composition is a null
3966 string, set it->pixel_width to 1 to avoid zero-width glyph.
3968 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3970 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3971 first 2 arguments are identical. This makes inserting large
3972 output from a subprocess an order of magnitude faster on
3973 MS-Windows, where all sbrk'ed memory is always contiguous.
3975 2012-01-31 Glenn Morris <rgm@gnu.org>
3977 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3978 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3979 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3981 2012-01-29 Glenn Morris <rgm@gnu.org>
3983 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3985 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3987 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3989 2012-01-28 Chong Yidong <cyd@gnu.org>
3991 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3993 2012-01-26 Chong Yidong <cyd@gnu.org>
3995 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3997 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3998 repeat counts (Bug#10507).
4000 2012-01-26 Glenn Morris <rgm@gnu.org>
4002 * lread.c (syms_of_lread): Doc fix.
4004 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4006 * coding.c (encode_designation_at_bol): Change return value to
4009 2012-01-25 Chong Yidong <cyd@gnu.org>
4011 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4013 2012-01-21 Chong Yidong <cyd@gnu.org>
4015 * floatfns.c (Fcopysign): Make the second argument non-optional,
4016 since nil is not allowed anyway.
4018 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4020 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4021 (send_process): Likewise.
4023 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4025 * window.c (save_window_save, Fcurrent_window_configuration)
4026 (Vwindow_persistent_parameters): Do not use Qstate.
4027 Rewrite doc-strings.
4029 2012-01-19 Kenichi Handa <handa@m17n.org>
4031 * character.c (char_width): New function.
4032 (Fchar_width, c_string_width, lisp_string_width):
4033 Use char_width (Bug#9496).
4035 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4037 * window.c (Vwindow_persistent_parameters): New variable.
4038 (Fset_window_configuration, save_window_save): Handle persistent
4041 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4043 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4044 thrashing the stack of the thread. (Bug#9087)
4046 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4048 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4050 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4052 * xdisp.c (rows_from_pos_range): Handle the case where the
4053 highlight ends on a newline. (Bug#10464)
4054 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4055 he end column for display of highlight that ends on a newline
4058 2012-01-11 Glenn Morris <rgm@gnu.org>
4060 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4061 from load-path also when installation-directory is nil. (Bug#10208)
4063 2012-01-10 Glenn Morris <rgm@gnu.org>
4065 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4067 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4068 Update template values to be closer to their typical values these days.
4070 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4072 * xdisp.c (rows_from_pos_range): Accept additional argument
4073 DISP_STRING, and accept any glyph in a row whose object is that
4074 string as eligible for mouse highlight. Fixes mouse highlight of
4075 display strings from overlays. (Bug#10464)
4077 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4079 emacs: fix an auto-save permissions race condition (Bug#10400)
4080 * fileio.c (auto_saving_dir_umask): New static var.
4081 (Fmake_directory_internal): Use it.
4082 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4083 creating the directory. The old code temporarily assigns
4084 too-generous permissions to the directory.
4085 (do_auto_save_eh): Clear it.
4086 (Fdo_auto_save): Catch all errors, not just file errors, so
4087 that the var is always cleared.
4089 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4091 * search.c (scan_buffer): Pass character positions to
4092 know_region_cache, not byte positions. (Bug#6540)
4094 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4096 * w32.c (sys_rename): Report EXDEV when rename of a directory
4097 fails because the target is on another logical disk. (Bug#10284)
4099 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4101 * xterm.c (x_embed_request_focus): New function.
4103 * xterm.h: Add prototype.
4105 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4107 2012-01-05 Glenn Morris <rgm@gnu.org>
4109 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4111 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4113 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4114 Load gnutls_transport_set_lowat only if GnuTLS version is below
4116 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4117 GnuTLS versions below 2.11.1.
4119 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4121 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4122 to the doc string advising against its use for altering the way
4123 windows are scrolled.
4125 2011-12-28 Kenichi Handa <handa@m17n.org>
4127 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4128 coding-system ASCII compatible only when it does not produce BOM
4129 on encoding (Bug#10383).
4131 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4133 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4135 (create_and_show_popup_menu): Always use menu_position_func for
4138 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4140 * callint.c (Fcall_interactively): Don't truncate prompt string.
4142 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4144 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4145 property that ends at ZV, so that the bidi iteration could be
4146 resumed from there (after widening). (Bug#10360)
4148 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4150 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4152 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4154 * nsterm.m (x_free_frame_resources):
4155 Release f->output_data.ns->miniimage.
4156 (ns_index_color): Fix indentation. Do not retain
4157 color_table->colors[i].
4159 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4162 * nsfns.m (x_set_background_color): Assign return value from
4163 ns_index_color to face-background instead of NSColor*.
4164 (ns_implicitly_set_icon_type): Fix indentation.
4165 Change assignment in for loop to comparison.
4167 * emacs.c (ns_pool): New variable.
4168 (main): Assign ns_pool.
4169 (Fkill_emacs): Call ns_release_autorelease_pool.
4171 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4172 autorelease fdesc, release fdAttrs and tdict.
4173 (ns_get_covering_families): Release charset.
4174 (ns_findfonts): Release NSFontDescriptor created with new.
4175 (ns_uni_to_glyphs): Fix indentation.
4176 (setString): Release attrStr before assigning new value.
4178 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4180 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4182 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4183 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4185 2011-12-18 David Reitter <reitter@cmu.edu>
4187 * nsterm.m (ns_term_init): Subscribe for notifications
4188 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4189 to method trackingNotification in EmacsMenu.
4191 * nsmenu.m (trackingMenu): New variable.
4192 (trackingNotification): New method (from Aquamacs).
4193 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4194 from Aquamacs (Bug#7030).
4196 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4198 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4199 (symbol_to_nsstring): Fix indentation.
4200 (ns_symbol_to_pb): New function.
4201 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4202 (Fns_rotate_cut_buffers_internal): Remove.
4203 (Fns_store_selection_internal): Rename from
4204 Fns_store_cut_buffer_internal.
4205 (ns_get_foreign_selection, Fx_own_selection_internal)
4206 (Fx_disown_selection_internal, Fx_selection_exists_p)
4207 (Fns_get_selection_internal, Fns_store_selection_internal):
4208 Use ns_symbol_to_pb and check if return value is nil.
4209 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4210 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4211 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4212 renamed to Sns_store_selection_internal.
4213 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4214 and remove this function.
4215 (ns_handle_selection_clear): Remove, never used.
4216 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4219 2011-12-17 Ken Brown <kbrown@cornell.edu>
4221 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4222 GID is unknown (Bug#10257).
4224 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4226 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4227 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4228 which caused a build failure on GNU/Linux IA-64. This problem was
4229 introduced by my 2011-10-07 patch.
4231 2011-12-15 Juri Linkov <juri@jurta.org>
4233 * image.c (imagemagick_error): New function. (Bug#10112)
4234 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4235 Use `imagemagick_error' where ImageMagick functions return
4237 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4240 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4242 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4243 fill background (Bug#8992).
4245 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4247 * window.c (Vwindow_combination_resize)
4248 (Vwindow_combination_limit): Use t instead of non-nil in
4250 (Vrecenter_redisplay): Add first sentence of doc-string on
4252 (Frecenter): Fix doc-string typo.
4254 2011-12-11 Kenichi Handa <handa@m17n.org>
4256 * coding.c (Funencodable_char_position): Pay attention to the
4257 buffer text relocation (Bug#9389).
4259 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4261 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4262 gtk_init (Bug#10100).
4264 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4266 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4267 IT->string is nil. (Bug#10263)
4269 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4271 * nsterm.h (x_free_frame_resources): Declare.
4273 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4274 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4276 * nsterm.h (ns_get_defaults_value): Declare.
4278 * nsterm.m (ns_default): Call ns_get_defaults_value.
4280 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4282 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4285 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4287 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4288 that where the value of an _OBJC_* symbol points to is in the .bss
4289 section (Bug#10240).
4291 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4293 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4294 after the loop to call ccl_driver at least once (Bug#8619).
4296 2011-12-08 Kenichi Handa <handa@m17n.org>
4298 * ftfont.c (get_adstyle_property): Fix previous change
4301 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4303 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4304 dirs from the default value of EMACSLOADPATH (bug#10208).
4306 2011-12-07 Glenn Morris <rgm@gnu.org>
4308 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4309 installation and source directories as well. (Bug#10208)
4311 2011-12-06 Chong Yidong <cyd@gnu.org>
4313 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4315 2011-12-06 Glenn Morris <rgm@gnu.org>
4317 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4318 as an error, not just -1. (Bug#10217)
4320 2011-12-05 Chong Yidong <cyd@gnu.org>
4322 * keyboard.c (process_special_events): New function.
4323 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4325 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4327 * coding.c (encode_designation_at_bol): Don't use uninitialized
4328 local variable (Bug#9318).
4330 2011-12-05 Kenichi Handa <handa@m17n.org>
4332 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4333 return Qnil (Bug#8046, Bug#10193).
4335 2011-12-05 Kenichi Handa <handa@m17n.org>
4337 * coding.c (encode_designation_at_bol): New args charbuf_end and
4338 dst. Return the number of produced bytes. Callers changed.
4339 (coding_set_source): Return how many bytes coding->source was
4341 (coding_set_destination): Return how many bytes
4342 coding->destination was relocated.
4343 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4344 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4346 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4348 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4349 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4352 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4354 The following changes are to fix Bug#9318.
4356 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4357 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4358 (encode_coding_iso_2022, encode_coding_sjis)
4359 (encode_coding_big5, encode_coding_charset): Use the above macros.
4361 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4363 * lisp.h (process_quit_flag): Fix external declaration.
4365 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4367 Don't macro-inline non-performance-critical code.
4368 * eval.c (process_quit_flag): New function.
4369 * lisp.h (QUIT): Use it.
4371 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4373 * nsfns.m (get_geometry_from_preferences): New function.
4374 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4376 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4378 * emacs.c (Qkill_emacs): Define.
4379 (syms_of_emacs): Initialize it.
4380 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4381 Qquit_flag to `kill-emacs' instead.
4382 (quit_throw_to_read_char): Add parameter `from_signal'.
4383 All callers changed. Call Fkill_emacs if requested and safe.
4384 * lisp.h (QUIT): Call Fkill_emacs if requested.
4386 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4388 * widget.c (update_wm_hints): Return if wmshell is null.
4389 (widget_update_wm_size_hints): New function.
4391 * widget.h (widget_update_wm_size_hints): Declare.
4393 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4394 widget_update_wm_size_hints (Bug#10104).
4396 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4398 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4399 before a newline, prepare the bidi iterator for consuming the
4400 newline, and keep the current paragraph direction. (Bug#10183)
4401 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4403 2011-12-02 Juri Linkov <juri@jurta.org>
4405 * search.c (Fword_search_regexp): New Lisp function created from
4406 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4407 (Fword_search_backward, Fword_search_forward)
4408 (Fword_search_backward_lax, Fword_search_forward_lax):
4409 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4410 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4412 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4414 * fileio.c (Finsert_file_contents): Move after-change-function call
4415 to before the "handled:" label, since all "goto handled" appear in
4416 cases where the *-change-functions have already been properly called
4419 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4421 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4422 waiting for input. (Bug#10169)
4424 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4426 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4427 verifies glyph row's hash code--we have just reallocated the
4428 glyphs, so their contents can be complete garbage. (Bug#10164)
4430 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4432 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4434 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4436 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4437 attributes are tested _before_ calling verify_row_hash, to protect
4438 against GCC re-ordering of the tests. (Bug#10164)
4440 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4442 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4444 * xterm.c (handle_one_xevent): Only set async_visible and friends
4445 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4446 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4447 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4449 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4451 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4452 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4453 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4454 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4455 All uses changed to use GCPRO1 etc.
4456 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4457 Revert to old implementation (i.e., before 2011-03-11).
4459 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4461 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4462 of scroll runs so as to avoid assigning disabled bogus rows and
4463 unnecessary graphics copy operations.
4465 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4467 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4468 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4469 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4470 (malloc, free, realloc, calloc): Redirect to e_* only when
4473 * lisp.h (GCTYPEBITS): Move before first use.
4474 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4475 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4476 this macro definition.
4478 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4481 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4483 * gtkutil.c (xg_create_frame_widgets):
4484 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4485 present with Gtk+ 2.0.
4487 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4489 * fileio.c (Finsert_file_contents): Undo previous change; see
4490 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4492 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4494 Rename locals to avoid shadowing.
4495 * fileio.c (Finsert_file_contents):
4496 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4497 * process.c (wait_reading_process_output):
4498 Rename inner 'proc' to 'p' to avoid shadowing.
4499 Indent for consistency with usual Emacs style.
4501 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4503 * xdisp.c (redisplay_window): If cursor row is not fully visible
4504 after recentering, and scroll-conservatively is set to a large
4505 number, scroll window by a few more lines to make the cursor fully
4506 visible and out of scroll-margin. (Bug#10105)
4507 (start_display): Don't move to the next line if the display should
4508 start at a newline that is part of a display vector or an overlay
4511 2011-11-24 Juri Linkov <juri@jurta.org>
4513 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4514 after the `MagickPingImage' call. (Bug#10112)
4516 2011-11-23 Chong Yidong <cyd@gnu.org>
4518 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4520 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4522 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4523 making another buffer current. (Bug#10114)
4525 2011-11-23 Glenn Morris <rgm@gnu.org>
4527 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4529 2011-11-23 Chong Yidong <cyd@gnu.org>
4531 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4532 using it (Bug#5984).
4534 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4536 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4537 and header-lines, as they don't have one computed for them.
4540 * .gdbinit (prow): Make displayed values more self-explaining.
4541 Add row's hash code.
4543 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4545 * process.c (wait_reading_process_output): Fix asynchrounous
4546 GnuTLS socket handling on some versions of the GnuTLS library.
4547 (wait_reading_process_output): Add comment and URL.
4549 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4551 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4553 2011-11-21 Chong Yidong <cyd@gnu.org>
4555 * window.c (Fnext_window, Fprevious_window): Doc fix.
4557 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4559 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4561 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4563 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4565 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4567 * window.c (Fset_window_combination_limit): Rename argument
4569 (Vwindow_combination_limit): Remove "status" from doc-string.
4571 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4573 * m/ibms390.h: Remove.
4574 * m/ibms390x.h: Don't include "ibms390.h".
4576 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4578 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4579 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4581 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4583 * casetab.c (Fset_case_table):
4584 * charset.c (Fcharset_after): Fix typos.
4586 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4588 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4589 Otherwise, valgrind does not work on some platforms.
4590 Problem reported by Andreas Schwab in
4591 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4592 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4593 is set, removing the need for VIRT_ADDRESS_VARIES.
4594 (PURE_P): Use a more-efficient implementation that needs just one
4595 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4596 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4597 to 4 (xorl, subq, cmpq, setbe).
4598 * alloc.c (pure): Always extern now, since that's the
4599 VIRT_ADDR_VARIES behavior.
4600 (PURE_POINTER_P): Use a single comparison, not two, for
4601 consistency with the new puresize.h.
4602 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4603 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4604 Remove VIRT_ADDR_VARIES no longer needed.
4606 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4608 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4609 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4610 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4611 behave as if the cursor position were at the window margin.
4613 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4614 and the cursor position is out of bounds, behave as if the cursor
4615 position were at the window margin. (Bug#10075)
4617 2011-11-18 Chong Yidong <cyd@gnu.org>
4619 * window.c (Fwindow_combination_limit): Make first argument
4620 non-optional, since it is meaningless for live windows like the
4623 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4625 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4627 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4629 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4630 (graft_intervals_into_buffer): Simplify.
4632 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4634 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4635 hash values of the two rows.
4636 (copy_row_except_pointers): Preserve the used[] arrays and the
4637 hash values of the two rows. (Bug#10035)
4638 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4640 * xdisp.c (row_hash): New function, body extracted from
4641 compute_line_metrics.
4642 (compute_line_metrics): Call row_hash, instead of computing the
4645 * dispnew.c (verify_row_hash): Call row_hash for computing the
4646 hash code of a row, instead of duplicating code from xdisp.c.
4648 * dispextern.h (row_hash): Add prototype.
4650 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4652 * frame.c (delete_frame): Don't delete the terminal when the last
4653 X frame is closed if emacs is built with GTK toolkit.
4655 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4657 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4659 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4661 * window.c (Vwindow_splits): Rename to
4662 Vwindow_combination_resize. Suggested by Juri Linkov.
4663 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4666 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4668 * nsfns.m (Fns_font_name):
4669 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4671 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4673 * window.h (window): Rename slot "nest" to "combination_limit".
4674 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4675 (Fset_window_nest): Rename to Fset_window_combination_limit.
4676 (Vwindow_nest): Rename to Vwindow_combination_limit.
4677 (recombine_windows, make_parent_window, make_window)
4678 (Fsplit_window_internal, saved_window)
4679 (Fset_window_configuration, save_window_save): Rename all
4680 occurrences of window_nest to window_combination_limit.
4682 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4684 * image.c (imagemagick_load_image): Fix typo.
4686 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4688 * xdisp.c (display_line): Move the call to
4689 highlight_trailing_whitespace before the call to
4690 compute_line_metrics, since the latter needs to see the final
4691 faces of all the glyphs to compute ROW's hash value.
4692 Fixes assertion violations in row_equal_p. (Bug#10035)
4694 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4696 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4697 just return (bug#10044).
4699 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4701 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4702 with user-defined heap size. Bump the default size of the temacs
4703 heap to 27MB, to avoid memory warning when running temacs.
4704 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4706 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4707 current_matrix and desired_matrix. (Bug#9990)
4708 (verify_row_hash) [XASSERTS]: New function.
4709 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4710 that the hash value of glyph rows is correct.
4712 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4714 * window.h (window): Remove splits slot.
4715 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4716 (Fdelete_other_windows_internal, make_parent_window)
4717 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4718 (Fset_window_configuration, save_window_save): Don't deal with
4719 split status of windows.
4720 (saved_window): Remove splits slot.
4721 (Vwindow_splits): Rewrite doc-string.
4723 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4725 * xfns.c (unwind_create_frame):
4726 * nsfns.m (unwind_create_frame):
4727 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4728 Vframe_list (Bug#9999).
4730 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4732 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4734 2011-11-11 Kenichi Handa <handa@m17n.org>
4736 * callproc.c (Fcall_process): Set the member dst_multibyte of
4739 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4741 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4742 avoid a crash (bug#9496).
4744 2011-11-09 Chong Yidong <cyd@gnu.org>
4746 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4747 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4749 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4751 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4753 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4755 Avoid some portability problems by eschewing 'extern inline' functions.
4756 The trivial performance wins aren't worth the portability hassles; see
4757 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4759 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4760 (window_box_width, window_box_left, window_box_left_offset)
4761 (window_box_right, window_box_right_offset): Undo previous change,
4762 by removing the "extern"s.
4763 * intervals.c (adjust_intervals_for_insertion)
4764 (adjust_intervals_for_deletion): Undo previous change,
4765 making these static again.
4766 (offset_intervals, temp_set_point_both, temp_set_point)
4767 (copy_intervals_to_string): No longer inline.
4768 * xdisp.c (window_text_bottom_y, window_box_width)
4769 (window_box_height, window_box_left_offset)
4770 (window_box_right_offset, window_box_left, window_box_right)
4771 (window_box): No longer inline.
4773 2011-11-08 Chong Yidong <cyd@gnu.org>
4775 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4776 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4777 Signal an error if not a live window.
4778 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4779 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4781 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4783 * lisp.h (syms_of_abbrev): Remove declaration.
4784 Reported by CHENG Gao <chenggao@royau.me>.
4786 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4788 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4789 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4790 of temacs in GUI mode.
4792 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4794 * window.h: Declare delete_all_child_windows instead of
4795 delete_all_subwindows.
4796 * window.c (Fwindow_nest, Fset_window_nest)
4797 (Fset_window_new_total, Fset_window_new_normal)
4798 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4799 (delete_all_subwindows): Rename to delete_all_child_windows.
4800 (Fdelete_other_windows_internal, Fset_window_configuration):
4801 Call delete_all_child_windows instead of delete_all_subwindows.
4802 * frame.c (delete_frame): Call delete_all_child_windows instead
4803 of delete_all_subwindows.
4805 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4807 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4808 This is also needed for porting to any host where GC_MARK_STACK is
4809 not GC_MAKE_GCPROS_NOOPS.
4810 (which_symbols): Use it.
4812 2011-11-07 Kenichi Handa <handa@m17n.org>
4814 * coding.c (coding_set_destination): Check coding->src_pos only
4815 when coding->src_object is a buffer (bug#9910).
4817 * process.c (send_process): Set the member src_multibyte of coding
4818 to 0 (bug#9911) when sending a unibyte text.
4820 * callproc.c (Fcall_process): Set the member src_multibyte of
4821 process_coding to 0 (bug#9912).
4823 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4825 * xmenu.c (cleanup_widget_value_tree): New function.
4826 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4827 calling free_menubar_widget_value_tree directly (Bug#9830).
4829 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4831 Fix some portability problems with 'inline'.
4832 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4833 (window_box_width, window_box_left, window_box_left_offset)
4834 (window_box_right, window_box_right_offset): Declare extern.
4835 Otherwise, these inline functions do not conform to C99 and
4836 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4837 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4838 * intervals.c (adjust_intervals_for_insertion)
4839 (adjust_intervals_for_deletion): Now extern, because otherwise the
4840 extern inline functions 'offset_intervals' couldn't refer to it.
4841 (static_offset_intervals): Remove.
4842 (offset_intervals): Rewrite using the old contents of
4843 static_offset_intervals. The old version didn't conform to C99
4844 because an extern inline function contained a reference to an
4845 identifier with static linkage.
4847 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4849 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4852 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4854 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4855 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4856 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4857 return Qleft_to_right.
4859 2011-11-06 Chong Yidong <cyd@gnu.org>
4861 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4862 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4863 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4864 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4865 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4866 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4867 (Fwindow_vscroll): Doc fix.
4868 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4869 argument, since it makes no sense to pass a live window and for
4870 consistency with window-child.
4872 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4874 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4877 2011-11-05 Jason Rumney <jasonr@gnu.org>
4879 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4880 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4882 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4883 bitwise arithmetic preventing use of unicode-sip and non-truetype
4886 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4888 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4891 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4892 initialization code to keep similarity to xfns.c after changes
4895 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4897 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4898 (unwind_create_frame): New function (Bug#9943).
4899 (Fx_create_frame): Restructure code to be more similar to the one in
4900 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4901 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4902 Move terminal->reference_count++ just before making the frame official
4905 * nsterm.m (x_free_frame_resources): New function.
4906 (x_destroy_window): Move code to x_free_frame_resources.
4908 * xfns.c (unwind_create_frame): Fix comment.
4909 (Fx_create_frame, x_create_tip_frame):
4910 Move terminal->reference_count++ just before making the frame
4911 official. Move initialization of image_cache_refcount and
4912 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4914 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4916 Support MSVC build with newer versions of Visual Studio.
4917 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4918 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4921 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4922 which are not supported by MSVC.
4923 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4924 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4926 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4928 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4930 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4932 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4934 Support MSVC build with newer versions of Visual Studio.
4935 * w32.c: Don't include w32api.h for MSVC.
4936 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4938 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4939 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4940 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4941 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4943 (alloca) [_MSC_VER]: Define to _alloca.
4945 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4947 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4949 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4951 * xdisp.c (note_mouse_highlight): If either of
4952 previous/next-single-property-change returns nil, treat that as
4953 the beginning or the end of the buffer. (Bug#9955)
4955 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4957 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4958 label is not null (Bug#9951).
4959 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4962 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4964 * window.c (Fwindow_body_size): Mention in the doc string that the
4965 return value is in frame's canonical units. (Bug#9949)
4967 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4969 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4971 * w32fns.c (unwind_create_frame): If needed, free the glyph
4972 matrices of the partially constructed frame. (Bug#9943)
4973 * xfns.c (unwind_create_frame): Likewise.
4975 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4977 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4978 Don't stop backward scan on the continuation glyph, even though
4979 its CHARPOS is positive.
4980 (mouse_face_from_buffer_pos, note_mouse_highlight):
4981 Rename cover_string to disp_string.
4983 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4985 * window.c (temp_output_buffer_show): Don't use
4986 Vtemp_buffer_show_specifiers.
4987 (Vtemp_buffer_show_specifiers): Remove unused variable.
4989 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4991 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4992 past the beginning of the current glyph matrix.
4994 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4996 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4997 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4998 HAVE_GTK3 (Bug#9869).
5000 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5001 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5003 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5005 * xterm.c: Declare x_handle_net_wm_state to return int.
5006 (handle_one_xevent): Check if we are iconified but don't have
5007 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5008 (get_current_wm_state): Return non-zero if not hidden,
5009 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5010 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5011 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5012 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5014 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5016 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5017 so that this new function doesn't get optimized away by a
5018 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5020 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5022 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5024 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5026 Fix the `xbytecode' command.
5027 * .gdbinit (xprintbytestr): New command.
5028 (xwhichsymbols): Rename from `which'; all callers changed.
5029 (xbytecode): Print the byte-code string as well.
5031 2011-10-29 Kim Storm <storm@cua.dk>
5033 * alloc.c (which_symbols): New function.
5035 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5037 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5040 2011-10-29 Glenn Morris <rgm@gnu.org>
5042 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5043 Not clear what it was for, and it causes various bugs. (Bug#9839)
5045 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5047 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5048 possible random value that matches one of those tested as
5049 condition to clear the mouse face.
5051 2011-10-28 Chong Yidong <cyd@gnu.org>
5053 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5055 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5057 * window.c (make_window): Initialize phys_cursor_on_p.
5059 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5061 * lisp.h (struct Lisp_Symbol): Update comments.
5063 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5065 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5067 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5069 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5070 <oslsachem@gmail.com> for helping to debug this.
5072 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5073 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5074 (g_b_init_get_glyph_outline_w): New static variables.
5075 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5076 (GetGlyphOutlineW_Proc): New typedefs.
5077 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5078 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5080 (w32font_open_internal, compute_metrics):
5081 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5082 instead of calling the "wide" APIs directly.
5084 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5086 * w32.h (syms_of_w32font): Add prototype.
5088 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5090 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5091 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5092 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5093 (Fmove_to_window_line): Doc fix.
5095 2011-10-27 Chong Yidong <cyd@gnu.org>
5097 * process.c (make_process): Set gnutls_state to NULL.
5099 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5100 non-NULL, regardless of GNUTLS_INITSTAGE.
5101 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5102 an error. Set process slots as soon as we allocate them.
5104 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5106 2011-10-27 Chong Yidong <cyd@gnu.org>
5108 * gnutls.c (emacs_gnutls_deinit): New function.
5109 Deallocate credentials structures as well as calling gnutls_deinit.
5110 (Fgnutls_deinit, Fgnutls_boot): Use it.
5112 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5113 (deactivate_process): Call emacs_gnutls_deinit.
5115 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5117 * image.c (x_create_x_image_and_pixmap):
5118 * w32.c (sys_rename, w32_delayed_load):
5119 * w32font.c (fill_in_logfont):
5120 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5122 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5124 * w32fns.c (w32_default_color_map): New function,
5125 extracted from Fw32_default_color_map.
5126 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5128 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5130 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5132 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5134 * keyboard.c (test_undefined): New function (bug#9751).
5135 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5137 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5139 * sysdep.c (init_sys_modes): Fix the check for the controlling
5140 terminal (Bug#6649).
5142 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5144 * dispextern.h (struct bidi_it): New member next_en_type.
5146 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5147 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5148 current character, check also for next_en_type being WEAK_EN.
5149 (bidi_resolve_weak): Don't enter the expensive loop if the current
5150 position is before next_en_pos. Record the bidi type of the first
5151 non-ET, non-BN character we find, in addition to its position.
5152 (bidi_level_of_next_char): Invalidate next_en_type when
5153 next_en_pos is over-stepped.
5155 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5157 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5158 * editfns.c: Rewrite current-time-zone so that it invokes
5159 the equivalent of (format-time-string "%Z") to get the time zone name.
5160 This fixes a bug when the time zone name contains characters that
5161 need converting from the system time locale to Emacs internal format.
5162 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5163 that patch fixed format-time-string to do the conversion, but
5164 I forgot to fix current-time-zone.
5165 (format_time_string): New function, containing most of
5166 what Fformat_time_string used to contain.
5167 (Fformat_time_string): Rewrite in terms of format_time_string.
5168 This doesn't change this function's behavior.
5169 (current-time-zone): Rewrite to use format_time_string.
5170 This fixes the bug reported by Michael Schierl in
5171 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5172 Jason Rumney's 2007-06-07 change worked around this bug, but
5174 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5176 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5178 * xdisp.c (start_display): If the character at POS is displayed
5179 via a display vector, reset IT->current.dpvec_index to zero.
5180 (try_window_reusing_current_matrix): If a line ends in a display
5181 vector or the next line starts in a display vector, continue
5182 redrawing the window even though the character position of
5183 start_row was reached.
5186 2011-10-18 Chong Yidong <cyd@gnu.org>
5188 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5189 with nobreak-char-display too.
5191 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5193 Fix part 3 of bug#9771.
5194 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5195 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5196 non-neutral characters if the current character is a paragraph
5197 separator (a.k.a. Newline). This avoids running the same
5198 expensive loop twice, once when we consume the preceding newline
5199 and the other time when the line actually needs to be displayed.
5200 Avoid the loop when we see neutrals on the base embedding level
5201 following a character whose directionality is the same as the
5202 paragraph's. This avoids running the expensive loop when a line
5203 ends in a long sequence of neutrals, like control characters.
5204 Add assertion against STRONG_AL type. Slightly rearrange code
5205 that determines the type of a neutral given the first non-neutral
5207 (bidi_level_of_next_char): Set next_en_pos to zero when
5208 invalidating its info.
5210 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5212 * xdisp.c (push_display_prop): Determine whether to record string
5213 or buffer position by IT->string, not by IT->method. Allow
5214 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5215 (move_it_vertically_backward): Don't look for character position
5216 immediately after the newline when in a continuation line.
5219 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5221 * window.c (coordinates_in_window): Rewrite and delabelize
5222 vertical border check. (Bug#5357) (Bug#9618)
5224 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5226 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5227 errors in XSetWindowBorder (bug#9310).
5229 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5231 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5232 avoid crash when xmalloc overrun checking is enabled.
5234 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5236 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5237 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5238 cursor motion with <left> and <right> arrow keys.
5240 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5241 some callers set that themselves.
5243 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5245 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5246 display string and the previous row comes from the same string and
5247 is empty. (Bug#9739) (Bug#9738)
5249 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5251 * doc.c (get_doc_string): Encode file name (bug#9735).
5253 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5255 * bidi.c (bidi_level_of_next_char):
5256 * xdisp.c (get_visually_first_element): Remove old incorrect
5257 comments regarding the Unicode Line Separator character.
5259 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5261 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5263 * alloc.c (Fgc_status): Do not access beyond zombies array
5264 boundary if nzombies > MAX_ZOMBIES.
5265 * alloc.c (dump_zombies): Add missing format specifier.
5267 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5269 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5270 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5272 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5273 Some packages use them to denote characters with modifiers.
5275 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5277 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5278 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5279 matching a pp-number. Rename parameter var to var1.
5281 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5283 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5285 2011-10-08 Glenn Morris <rgm@gnu.org>
5287 * callint.c (Fcall_interactively): Give a more explicit error for the
5288 'c' case with a non-character input. (Bug#8479)
5290 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5292 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5294 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5295 lines that are hscrolled on the left.
5297 * dispnew.c (buffer_posn_from_coords): Account for a possible
5298 presence of header-line. (Bug#4426)
5300 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5302 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5303 Don't advertise functionality which we discourage or doesn't work.
5305 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5307 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5308 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5309 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5310 this makes Emacs dump core during garbage collection on rare
5311 occasions. sizeof is obviously inferior to offsetof here, so
5312 stick with offsetof.
5313 (GC_POINTER_ALIGNMENT): New macro.
5314 (mark_memory): Omit 3rd (offset) arg; caller changed.
5315 Don't assume EMACS_INT alignment is the same as pointer alignment.
5317 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5319 * keyboard.c (read_key_sequence_remapped): New var.
5320 (read_key_sequence): Compute remapping in the right buffer.
5321 (command_loop_1): Use read_key_sequence's remapping directly.
5323 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5325 * dired.c (file_name_completion): Don't expand file name.
5326 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5327 before checking file name handler.
5329 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5330 they've been requested explicitly (bug#9591).
5332 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5334 * keymap.c (Fsingle_key_description): Use make_specified_string
5335 instead of build_string to build string from push_key_description.
5338 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5340 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5341 This fixes a Y2038 bug on 64-bit hosts.
5342 * buffer.c (reset_buffer):
5343 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5344 (Fclear_buffer_auto_save_failure):
5345 Use 0, not -1, to represent an unset failure time, since time_t
5346 might not be signed.
5348 Remove dependency on glibc malloc internals.
5349 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5350 Move back here from lisp.h, but with their new implementations.
5351 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5352 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5353 * charset.c (charset_table_init): New static var.
5354 (syms_of_charset): Use it instead of xmalloc. This removes a
5355 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5356 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5357 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5358 Move back to alloc.c.
5359 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5360 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5362 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5364 * nsterm.m (windowDidResize): Call x_set_window_size only when
5365 ns_in_resize is true. Otherwise set pixelwidth/height and
5366 call change_frame_size (Bug#9628).
5368 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5370 Port --enable-checking=all to Fedora 14 x86-64.
5371 * charset.c (syms_of_charset): Also account for glibc malloc's
5372 internal overhead when calculating the initial malloc maximum.
5374 Port --enable-checking=all to Fedora 14 x86.
5375 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5377 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5378 (overrun_check_realloc, overrun_check_free):
5379 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5380 That way, xmalloc returns a properly-aligned pointer even if
5381 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5382 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5383 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5384 into account when calculating the initial malloc maximum.
5385 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5386 Move here from alloc.c, so that charset.c can use it too.
5387 Properly align; the old code wasn't right for common 32-bit hosts
5388 when configured with --enable-checking=all.
5389 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5390 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5392 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5394 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5397 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5399 * xdisp.c (compute_display_string_end): If there's no display
5400 string at CHARPOS, return -1.
5402 * bidi.c (bidi_fetch_char): When compute_display_string_end
5403 returns a negative value, treat the character as a normal
5404 character not covered by a display string. (Bug#9624)
5406 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5408 * lread.c (Fread_from_string): Fix typo in docstring.
5410 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5412 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5413 newline, reseat the iterator instead of bidi-iterating there one
5414 character at a time. (Bug#9610)
5415 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5416 TO_CHARPOS if the bidi iterator is at base embedding level.
5418 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5420 * lread.c (readevalloop): Use correct code for NBSP.
5421 (read1): Likewise. (Bug#9608)
5423 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5425 * dbusbind.c (Fdbus_register_signal): When service is not
5426 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5428 2011-09-25 Glenn Morris <rgm@gnu.org>
5430 * buffer.c (truncate-lines): Doc fix.
5432 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5434 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5435 (Fset_window_next_buffers): Doc fix.
5437 2011-09-24 Glenn Morris <rgm@gnu.org>
5439 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5441 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5443 Fix minor problems found by static checking.
5444 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5445 * indent.c (Fvertical_motion): Fix == vs = typo.
5447 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5449 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5450 Default value is now t. Doc fix.
5452 * indent.c (Fvertical_motion): Compute and apply the overshoot
5453 logic when moving up, not only when moving down. Fix the
5454 confusing name and values of the it_overshoot_expected variable;
5455 logic changes accordingly. (Bug#9254) (Bug#9549)
5457 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5458 CHARPOS is covered by a display string which includes newlines.
5459 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5460 is covered by a display string with embedded newlines.
5462 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5464 * dbusbind.c (Fdbus_register_signal): Add match rule to
5465 Vdbus_registered_objects_table. (Bug#9581)
5466 (Fdbus_register_method, Vdbus_registered_objects_table):
5469 2011-09-24 Jim Meyering <meyering@redhat.com>
5471 do not ignore write error for any output size
5472 The previous change was incomplete.
5473 While it makes emacs --batch detect the vast majority of stdout
5474 write failures, errors were still ignored whenever the output size is
5475 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5476 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5477 && echo FAIL: ignored write error
5478 FAIL: ignored write error
5479 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5480 && echo FAIL: ignored write error
5481 FAIL: ignored write error
5482 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5484 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5486 * emacs.c (Fkill_emacs): In noninteractive mode exit
5487 non-successfully if a write error occurred on stdout. (Bug#9574)
5489 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5491 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5494 * dispextern.h (struct it): Update the comment documenting what
5497 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5499 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5500 a display string, extend search for cursor position to end of row.
5501 (find_row_edges): If the row ends in a newline from a display
5502 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5503 Handle the case of a display string with multiple newlines.
5504 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5505 non-empty line. Fixes confusing cursor motion with arrow keys at
5506 the beginning of a line that starts with whitespace.
5508 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5510 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5513 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5515 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5518 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5520 * xdisp.c (display_line): Record maximum and minimum buffer
5521 positions even if no glyphs were produced (e.g., by a zero-width
5522 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5523 buffer positions that will be removed from the glyph row because
5525 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5526 column is beyond frame width: don't subtract 1 "pixel" when
5527 computing width of the stretch.
5528 (reseat_at_next_visible_line_start): Undo the change made on
5529 2011-09-17 that saved paragraph information and restored it after
5530 the call to `reseat'. (Bug#9545)
5532 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5534 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5535 and turn window cursor on if cleared (Bug#9415).
5537 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5539 * search.c (boyer_moore): Take unibyte characters from pattern
5540 literally. (Bug#9458)
5542 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5544 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5546 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5548 Fix minor problem found by static checking.
5549 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5550 initialized, to pacify gcc -Wuninitialized.
5552 * fileio.c: Report proper errno when syscall falls.
5553 (Finsert_file_contents): Save and restore errno,
5554 so that report_file_error outputs the correct diagnostic.
5555 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5557 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5559 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5561 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5563 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5564 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5566 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5568 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5569 about the current paragraph and restore it after the call to reseat.
5571 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5572 (bidi_find_paragraph_start): Search back for paragraph beginning
5573 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5574 (bidi_move_to_visually_next): Only trigger paragraph-related
5575 computations when the last character is a newline or at EOB, not
5576 just any NEUTRAL_B. (Bug#9470)
5578 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5579 truncated lines if point is covered by a display string. (Bug#9524)
5581 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5583 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5584 (cons_to_x_long): New function.
5585 (lisp_data_to_selection_data): Use it. Correct the test for
5586 short-versus-long data; it was negated. Break out of vector
5587 loop, for efficiency, when a long datum is discovered.
5589 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5591 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5593 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5595 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5596 GCC PR/17406) by declaring this function with external scope.
5598 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5600 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5601 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5603 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5605 * editfns.c (Fformat): Correctly handle text properties on "%%".
5607 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5609 * xterm.c (x_draw_composite_glyph_string_foreground):
5610 * w32term.c (x_draw_composite_glyph_string_foreground):
5611 * term.c (encode_terminal_code):
5612 * composite.c (composition_update_it, get_composition_id):
5613 * xdisp.c (get_next_display_element)
5614 (fill_composite_glyph_string): Add comments about special meaning
5615 of TAB characters in a composition.
5617 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5619 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5620 This occurs when processing a multibyte format.
5621 Problem reported by Wolfgang Jenker.
5623 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5625 * xdisp.c (try_cursor_movement): Only check for exact match if
5626 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5628 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5630 Remove unused external symbols.
5631 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5632 * xdisp.c (calc_pixel_width_or_height): Now static.
5633 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5634 * indent.c (check_display_width):
5635 * w32term.c: Fix comment to match code.
5636 * xterm.c, xterm.h (x_catching_errors): Remove.
5638 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5640 * xselect.c: Use signed conversions more consistently (Bug#9498).
5641 (selection_data_to_lisp_data): Assume incoming selection data are
5642 signed integers, not unsigned. This is to be consistent with
5643 outgoing selection data, which was modified to use signed integers
5644 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5645 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5646 expects long, not unsigned long.
5648 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5650 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5651 computation of loop end. Reported by Johan Bockgård
5654 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5656 * frame.c (Fother_visible_frames_p): Function deleted.
5658 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5660 * indent.c (compute_motion): Process display vector front to back
5661 rather than the other way around. (Bug#2496)
5663 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5665 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5667 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5669 * minibuf.c (Fread_from_minibuffer): Doc fix.
5671 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5673 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5674 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5676 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5678 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5679 value for non-existent files.
5681 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5683 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5684 set its "size" to -1. This will set the modtime_size field of
5685 the corresponding buffer to -1, which is what
5686 verify-visited-file-modtime expects for files that do not exist.
5689 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5691 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5693 * lisp.h: ... from here. push_key_description is no longer
5694 defined in keyboard.c, so its declaration should not be in
5695 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5696 logically belongs with push_key_description.
5698 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5700 * buffer.h: Include <sys/types.h> instead of <time.h>.
5701 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5702 Problem reported by Herbert J. Skuhra.
5704 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5706 * xml.c (parse_region): Make the parsing work for
5707 non-comment-starting XML files again (bug#9144).
5709 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5711 * image.c (gif_load): Fix calculation of bottom and right corner.
5714 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5716 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5717 redisplay in small windows.
5719 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5721 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5723 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5725 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5726 Operate on live windows only.
5728 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5730 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5732 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5734 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5735 only under bidi iteration.
5737 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5739 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5741 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5743 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5744 Without this fix, the command to link temacs failed due to an
5745 undefined symbol __builtin_isnan. This is because
5746 /usr/include/iso/math_c99.h #defines isnan(x) to
5747 __builtin_isnan(x), but the bundled gcc, which identifies itself
5748 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5750 * floatfns.c (isnan): #undef, and then #define to a clone of
5752 (Fisnan): Always define, since it's always available now.
5753 (syms_of_floatfns): Always define isnan at the Lisp level.
5755 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5757 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5759 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5761 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5762 The previous code assumed that file offsets (off_t values) fit in
5763 EMACS_INT variables, which is not true on typical 32-bit hosts.
5764 The code messed up by falsely reporting buffer overflow in cases
5765 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5766 when "big" contains more than 2**29 bytes, even though this
5767 inserts just one byte and does not overflow the buffer.
5768 (Finsert_file_contents): Store file offsets as off_t
5769 values, not as EMACS_INT values. Check for overflow when
5770 converting between EMACS_INT and off_t. When checking for
5771 buffer overflow or for overlap, take the offsets into account.
5772 Don't use EMACS_INT for small values where int suffices.
5773 When checking for overlap, fix a typo: ZV was used where
5774 ZV_BYTE was intended.
5775 (Fwrite_region): Don't assume off_t fits into 'long'.
5776 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5778 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5780 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5782 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5784 sprintf-related integer and memory overflow issues (Bug#9412).
5786 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5787 (esprintf, exprintf, evxprintf): New functions.
5788 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5789 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5790 (modify_event_symbol): Do not assume that the length of
5791 name_alist_or_stem is safe to alloca and fits in int.
5792 (Fexecute_extended_command): Likewise for function name and binding.
5793 (Frecursion_depth): Wrap around reliably on integer overflow.
5794 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5795 since some callers pass EMACS_INT values.
5796 (Fsingle_key_description): Don't crash if symbol name contains more
5797 than MAX_ALLOCA bytes.
5798 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5799 (get_minibuffer): Arg is now EMACS_INT, not int.
5800 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5801 (esprintf, exprintf, evxprintf): New decls.
5802 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5804 * dbusbind.c (signature_cat): New function.
5805 (xd_signature, Fdbus_register_signal):
5806 Do not overrun buffer; instead, report string overflow.
5808 * dispnew.c (add_window_display_history): Don't overrun buffer.
5809 Truncate instead; this is OK since it's just a log.
5811 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5812 even if the time zone offset is outlandishly large.
5813 Don't mishandle offset == INT_MIN.
5815 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5816 when creating daemon; the previous buffer-overflow check was incorrect.
5818 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5819 which has the guts of the old verror function.
5821 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5822 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5824 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5825 (font_unparse_xlfd): Don't blindly alloca long strings.
5826 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5827 fits in int, when using sprintf. Use single snprintf to count
5828 length of string rather than counting it via multiple sprintfs;
5829 that's simpler and more reliable.
5830 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5831 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5832 sprintf, in case result does not fit in int.
5834 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5835 (fontset_from_font): Print it.
5837 * frame.c (tty_frame_count): Now printmax_t, not int.
5838 (make_terminal_frame, set_term_frame_name): Print it.
5839 (x_report_frame_params): In X, window IDs are unsigned long,
5840 not signed long, so print them as unsigned.
5841 (validate_x_resource_name): Check for implausibly long names,
5842 and don't assume name length fits in 'int'.
5843 (x_get_resource_string): Don't blindly alloca invocation name;
5844 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5847 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5848 (xg_check_special_colors, xg_set_geometry):
5849 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5851 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5852 Use esprintf, not sprintf, in case result does not fit in int.
5854 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5855 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5856 it as a large positive number.
5857 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5858 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5860 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5861 in case result does not fit in int.
5863 * print.c (float_to_string): Detect width overflow more reliably.
5864 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5865 buffer overrun. Don't assume list length fits in 'int'. Treat
5866 print length of 0 as 0, not as infinity; to be consistent with other
5867 uses of print length in this function. Don't overflow print length
5868 index. Don't assume hash table size fits in 'long', or that
5869 vectorlike size fits in 'unsigned long'.
5871 * process.c (make_process): Use printmax_t, not int, to format
5872 process-name gensyms.
5874 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5876 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5877 to avoid potential buffer overrun.
5879 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5880 if X resource line is longer than 512 bytes.
5882 * xfns.c (x_window): Make sprintf buffer a bit bigger
5883 to avoid potential buffer overrun.
5885 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5887 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5889 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5891 Integer overflow fixes for scrolling, etc.
5892 Without these, Emacs silently mishandles large integers sometimes.
5893 For example, "C-u 4294967297 M-x recenter" was treated as if
5894 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5896 * xdisp.c (try_window_id): Check Emacs fixnum range before
5897 converting to 'int'.
5899 * window.c (window_scroll_line_based, Frecenter):
5900 Check that an Emacs fixnum is in range before assigning it to 'int'.
5901 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5902 values converted from Emacs fixnums.
5903 (Frecenter): Don't wrap around a line count if it is out of 'int'
5904 range; instead, treat it as an extreme value.
5905 (Fset_window_configuration, compare_window_configurations):
5906 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5908 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5909 that can exceed INT_MAX. Check that EMACS_INT value is in range
5910 before assigning it to the (possibly-narrower) index.
5911 (match_limit): Don't assume that a fixnum can fit in 'int'.
5913 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5916 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5917 (Fvertical_motion): Don't wrap around LINES values that don't fit
5918 in 'int'. Instead, treat them as extreme values. This is good
5919 enough for windows, which can't have more than INT_MAX lines anyway.
5921 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5923 * Require libxml/parser.h to avoid compilation warning.
5925 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5927 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5928 since this reportedly can destroy thread storage.
5930 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5932 * syntax.c (find_defun_start): Update all cache variables if
5933 exiting early (Bug#9401).
5935 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5937 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5939 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5940 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5941 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5943 * term.c (tty_append_glyph): New function.
5944 (produce_stretch_glyph): Static function and its prototype deleted.
5946 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5949 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5951 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5952 when checking :margin (Bug#9390).
5953 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5954 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5955 so that the name doesn't mislead. All uses changed.
5957 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5959 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5962 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5964 * xdisp.c (move_it_to): Don't bail out early when reaching
5965 position beyond to_charpos, if we are scanning backwards.
5966 (move_it_vertically_backward): When DY == 0, make sure we get to
5967 the first character in the line after the newline.
5969 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5971 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5972 (ccl_driver): Do not generate an out-of-range pointer.
5973 (Fccl_execute_on_string): Remove unnecessary check for
5974 integer overflow, noted by Stefan Monnier in
5975 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5976 Remove a FIXME that didn't need fixing.
5977 Simplify the newly-introduced buffer reallocation code.
5979 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5981 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5983 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5985 Integer and memory overflow issues (Bug#9196).
5987 * doc.c (get_doc_string): Rework so that
5988 get_doc_string_buffer_size is the actual buffer size, rather than
5989 being 1 less than the actual buffer size; this makes xpalloc more
5992 * image.c (x_allocate_bitmap_record, cache_image):
5993 * xselect.c (Fx_register_dnd_atom):
5994 Simplify previous changes by using xpalloc.
5996 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5997 since either will do and ptrdiff_t is convenient with xpalloc.
5999 * charset.c (charset_table_size)
6000 (struct charset_sort_data.priority): Now ptrdiff_t.
6001 (charset_compare): Don't overflow if priorities differ greatly.
6002 (Fsort_charsets): Don't assume list length fits in int.
6003 Check for size-calculation overflow when allocating sort data.
6004 (syms_of_charset): Allocate an initial charset table that is
6005 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6007 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6009 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6010 The actual value is always <= INT_MAX, and leaving it unsigned made
6011 overflow checking harder.
6013 * dispextern.h (struct glyph_matrix.rows_allocated)
6014 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6015 with xpalloc. The values are still always <= INT_MAX.
6017 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6019 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6020 (SAFE_NALLOCA): New macro.
6022 * region-cache.c (struct boundary.pos, find_cache_boundary)
6023 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6024 (set_cache_region, invalidate_region_cache)
6025 (revalidate_region_cache, know_region_cache, region_cache_forward)
6026 (region_cache_backward, pp_cache):
6027 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6028 so that ptrdiff_t * can be passed to xpalloc.
6029 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6030 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6031 (pp_cache): Don't assume cache_len fits in int.
6032 * region-cache.h: Adjust extern decls to match.
6034 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6035 EMACS_INT, since either will do, for xpalloc.
6037 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6038 (xnmalloc, xnrealloc, xpalloc): New functions.
6040 * bidi.c (bidi_shelve_header_size): New constant.
6041 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6042 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6044 * bidi.c (bidi_cache_shrink):
6045 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6047 Don't update size of array until after memory allocation succeeds,
6048 because xmalloc/xrealloc may not return.
6049 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6050 now that we have proper integer overflow checking.
6051 (record_overlay_string, overlay_strings): Catch overflows when
6052 calculating size of overlay_str_buf.
6054 * callproc.c (Fcall_process): Check for size overflow when
6055 calculating size of args2.
6056 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6057 Normally we prefer signed values, but sticking with ptrdiff_t would
6058 require adding more-complicated checks.
6060 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6061 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6062 Redo buffer-overflow calculations to avoid integer overflow.
6063 Add a FIXME comment where memory seems to be over-allocated.
6065 * character.c (Fstring): Check for size-calculation overflow.
6067 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6068 unnecessary integer overflow. Check for size overflow.
6069 (encode_coding_object): Don't update size until xmalloc succeeds.
6071 * composite.c (get_composition_id): Check for overflow in glyph
6072 length calculations.
6074 Integer and memory overflow fixes for display code.
6075 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6076 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6077 (scrolling_window): Check for overflow in size calculations.
6078 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6079 Don't assume glyph table len fits in int.
6080 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6081 (row_table_size): Now ptrdiff_t, not int.
6082 (scrolling_window): Avoid overflow in size calculations.
6083 Don't update size until allocation succeeds.
6084 * fns.c (concat): Check for overflow in size calculations.
6085 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6086 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6087 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6089 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6090 (get_doc_string): Check for size calculation overflow.
6091 Don't update size until allocation succeeds.
6092 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6093 EMACS_INT, where ptrdiff_t will do.
6094 (Fsubstitute_command_keys): Check for string overflow.
6096 * editfns.c (set_time_zone_rule): Don't assume environment length
6098 (message_length): Now ptrdiff_t, not int.
6099 (Fmessage_box): Don't update size until allocation succeeds.
6100 Don't assume message length fits in int.
6101 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6103 * emacs.c (main): Do not reallocate argv, since there is a null at
6104 the end that can be overwritten, and this way there's no need to
6105 worry about size-calculation overflow.
6106 (sort_args): Check for size-calculation overflow.
6108 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6110 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6112 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6113 (x_set_scroll_bar_width, x_figure_window_size):
6114 Check for integer overflow.
6115 (x_set_alpha): Do not assume XINT fits in int.
6117 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6118 This is for the members text_lines, text_cols, total_lines, total_cols,
6119 where the system imposes an 'int' limit.
6121 * fringe.c (Fdefine_fringe_bitmap):
6122 Don't update size until alloc works.
6124 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6125 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6127 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6128 Check for size-calculation overflow.
6129 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6130 do, as we prefer signed integers.
6131 (id_to_widget.max_size, id_to_widget.used)
6132 (xg_store_widget_in_map, xg_remove_widget_from_map)
6133 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6134 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6135 Use and return ptrdiff_t, not int.
6136 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6137 * gtkutil.h: Change prototypes to match the above.
6139 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6140 are duplicate now that they've been promoted to lisp.h.
6141 (x_allocate_bitmap_record, x_alloc_image_color)
6142 (make_image_cache, cache_image, xpm_load):
6143 Don't update size until alloc is done.
6144 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6146 Check for size calculation overflow.
6147 (ct_colors_allocated_max): New constant.
6148 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6151 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6152 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6153 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6154 Use ptrdiff_t, not int, to count maps.
6155 (read_char_minibuf_menu_prompt): Check for overflow in size
6156 calculations. Don't update size until allocation succeeds.
6157 Redo calculations to avoid overflow.
6158 * keyboard.h: Change prototypes to match the above.
6160 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6162 (current_minor_maps): Check for size calculation overflow.
6163 * keymap.h: Change prototypes to match the above.
6165 * lread.c (read1, init_obarray): Don't update size until alloc done.
6167 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6168 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6170 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6171 Now ptrdiff_t, not int.
6172 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6173 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6175 * process.c (Fnetwork_interface_list): Check for overflow
6176 in size calculation.
6178 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6180 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6181 overflow. Don't bother calling xmalloc when xrealloc will do.
6183 * search.c (Freplace_match): Check for size calculation overflow.
6184 (Fset_match_data): Don't assume list lengths fit in 'int'.
6186 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6187 for command line length. Do not attempt to address one before the
6188 beginning of an array, as that's not portable.
6190 * term.c (max_frame_lines): Remove; unused.
6191 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6193 (encode_terminal_code, calculate_costs): Check for size
6194 calculation overflow.
6195 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6196 table lengths and related sizes. Don't update size until alloc
6197 done. Redo calculations to avoid overflow.
6198 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6200 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6201 subtracting pointers.
6202 (gobble_line): Check for overflow more carefully. Don't update size
6205 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6206 Don't update size until alloc done.
6207 Redo size calculations to avoid overflow.
6208 Check for size calculation overflow.
6209 (main) [DEBUG]: Fix typo in invoking tparam1.
6211 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6212 Use ptrdiff_t, not int, for sizes.
6213 (store_mode_line_noprop_char): Don't update size until alloc done.
6215 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6216 Use ptrdiff_t, not int, for sizes.
6217 (Finternal_make_lisp_face, cache_face):
6218 Check for size calculation overflow.
6219 (cache_face): Treat size calculation overflows as if they were
6220 memory exhaustion (the usual treatment), rather than aborting.
6222 * xfns.c (x_encode_text, x_set_name_internal)
6223 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6224 sizes, since they can exceed INT_MAX in size. Check for size
6225 calculation overflow.
6227 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6228 (xg_select): Check for size calculation overflow.
6229 Don't update size until alloc done.
6231 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6232 as sprintf is limited to int lengths.
6234 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6235 (X_LONG_MIN): New macros.
6236 Use them to make the following changes clearer.
6237 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6238 This change doesn't affect the value now, but it may help remind
6239 future maintainers not to raise the value too much later.
6240 (SELECTION_QUANTUM): Remove, replacing with ...
6241 (selection_quantum): ... new function, which avoids overflow.
6243 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6244 assumption that selection length fits in 'int'.
6245 (x_reply_selection_request, x_handle_selection_request)
6246 (x_get_window_property, receive_incremental_selection)
6247 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6248 (lisp_data_to_selection_data, clean_local_selection_data):
6249 Use ptrdiff_t, not int, to record length of selection.
6250 (x_reply_selection_request, x_get_window_property)
6251 (receive_incremental_selection, x_property_data_to_lisp):
6252 Redo calculations to avoid overflow.
6253 (x_reply_selection_request): When sending hint, ceiling it at
6254 X_LONG_MAX rather than relying on wraparound overflow to send
6256 (x_get_window_property, receive_incremental_selection)
6257 (lisp_data_to_selection_data, x_property_data_to_lisp):
6258 Check for size-calculation overflow.
6259 (x_get_window_property, receive_incremental_selection)
6260 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6261 Don't store size until memory allocation succeeds.
6262 (x_get_window_property): Plug memory leak on memory exhaustion.
6263 Don't double-block input; malloc is safe here. Don't assume 2**34
6264 - 4 fits in unsigned long. Add an xassert to check
6265 XGetWindowProperty overflow. Be more careful about overflow
6266 calculations, and distinguish size from memory overflow better.
6267 (receive_incremental_selection): When tracing, don't assume
6268 unsigned int is less than INT_MAX.
6269 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6270 harmful) conversions of unsigned short to int.
6271 (lisp_data_to_selection_data): Don't assume that integers
6272 in the range -65535 through -1 fit in an X unsigned short.
6273 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6274 result parameters unless successful. Rely on cons_to_unsigned
6275 to report problems with elements; the old code wasn't right anyway.
6276 (x_check_property_data): Check for int overflow; we cannot use
6277 a wider type due to X limits.
6278 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6280 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6282 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6283 (x_term_init): Check for size calculation overflow.
6284 (x_color_cells): Don't store size until memory allocation succeeds.
6285 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6286 Don't assume alloca size is less than MAX_ALLOCA.
6287 (x_term_init): Don't assume length fits in int (sprintf is limited
6290 Use ptrdiff_t for composition IDs.
6291 * character.c (lisp_string_width):
6292 * composite.c (composition_table_size, n_compositions)
6293 (get_composition_id, composition_gstring_from_id):
6294 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6295 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6296 * window.c (Frecenter):
6297 Use ptrdiff_t, not int, for composition IDs.
6298 * composite.c (get_composition_id): Check for integer overflow.
6299 * composite.h: Adjust prototypes to match the above changes.
6301 Use ptrdiff_t for hash table indexes.
6302 * category.c (hash_get_category_set):
6303 * ccl.c (ccl_driver):
6304 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6305 * coding.c (coding_system_charset_list, detect_coding_system):
6306 * coding.h (struct coding_system.id):
6307 * composite.c (get_composition_id, gstring_lookup_cache):
6308 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6309 * image.c (xpm_get_color_table_h):
6310 * lisp.h (hash_lookup, hash_put):
6311 * minibuf.c (Ftest_completion):
6312 Use ptrdiff_t for hash table indexes, not int (which is too
6313 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6314 32-bit --with-wide-int hosts).
6316 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6317 Add a FIXME comment about memory leaks.
6318 (syms_of_charset): Don't assume xmalloc returns.
6320 Don't assume that stated character widths fit in int.
6321 * character.c (Fchar_width, c_string_width, lisp_string_width):
6322 * character.h (CHAR_WIDTH):
6323 * indent.c (MULTIBYTE_BYTES_WIDTH):
6324 Use sanitize_char_width to avoid undefined and/or bad behavior
6325 with outlandish widths.
6326 * character.h (sanitize_tab_width): Rename from sanitize_width,
6327 now that we have two such functions. All uses changed.
6328 (sanitize_char_width): New inline function.
6330 Don't assume that tab-width fits in int.
6331 * character.h (sanitize_width): New inline function.
6332 (SANE_TAB_WIDTH): New macro.
6333 (ASCII_CHAR_WIDTH): Use it.
6334 * indent.c (sane_tab_width): Remove. All uses replaced by
6335 SANE_TAB_WIDTH (current_buffer).
6336 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6338 * fileio.c: Integer overflow issues with file modes.
6339 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6341 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6342 Remove unreachable code.
6343 (read_hex, load_charset_map_from_file): Check for integer overflow.
6345 * xterm.c: Don't go over XClientMessageEvent limit.
6346 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6347 (x_send_scroll_bar_event): Likewise. Check that the size does not
6348 exceed limits imposed by XClientMessageEvent, as well as the usual
6349 ptrdiff_t and size_t limits.
6351 * keyboard.c: Overflow, signedness and related fixes.
6352 (make_lispy_movement): Use same integer type in forward decl
6353 that is used in the definition.
6354 (read_key_sequence, keyremap_step):
6355 Change bufsize argument back to int, undoing my 2011-03-30 change.
6356 We prefer signed types, and int is wide enough here.
6357 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6358 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6359 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6360 length, not size_t. Use ptrdiff_t for index, not int.
6361 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6362 possibility of integer overflow.
6364 Overflow, signedness and related fixes for images.
6366 * dispextern.h (struct it.stack[0].u.image.image_id)
6367 (struct_it.image_id, struct image.id, struct image_cache.size)
6368 (struct image_cache.used, struct image_cache.ref_count):
6369 * gtkutil.c (update_frame_tool_bar):
6370 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6371 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6372 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6373 * nsmenu.m (update_frame_tool_bar):
6374 * xdisp.c (calc_pixel_width_or_height):
6375 * xfns.c (image_cache_refcount):
6376 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6377 on typical 64-bit hosts.
6379 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6380 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6381 Omit unnecessary casts to int.
6382 (parse_image_spec): Check that integers fall into 'int' range
6383 when the callers expect that.
6384 (image_ascent): Redo ascent calculation to avoid int overflow.
6385 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6386 (lookup_image): Remove unnecessary tests.
6387 (xbm_image_p): Locals are now of int, not EMACS_INT,
6388 since parse_image_check makes sure they fit into int.
6389 (png_load, gif_load, svg_load_image):
6390 Prefer int to unsigned where either will do.
6391 (tiff_handler): New function, combining the cores of the
6392 old tiff_error_handler and tiff_warning_handler.
6393 This function is rewritten to use vsnprintf and thereby avoid
6394 stack buffer overflows. It uses only the features of vsnprintf
6395 that are common to both POSIX and native Microsoft.
6396 (tiff_error_handler, tiff_warning_handler): Use it.
6397 (tiff_load, gif_load, imagemagick_load_image):
6398 Don't assume :index value fits in 'int'.
6399 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6400 (imagemagick_load_image): Check that crop parameters fit into
6401 the integer types that MagickCropImage accepts. Don't assume
6402 Vimagemagick_render_type has a nonnegative value. Don't assume
6403 size_t fits in 'long'.
6404 (gs_load): Use printmax_t to print the widest integers possible.
6405 Check for integer overflow when computing image height and width.
6407 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6409 * xdisp.c (redisplay_window): Don't force window start if point
6410 will be invisible in the resulting window. (Bug#9324)
6412 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6414 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6415 the display spec is of the form `(space ...)'.
6416 (handle_display_spec): Return the value returned by
6417 handle_single_display_spec, not just 1 or zero.
6418 (handle_single_display_spec): If the display spec is of the form
6419 `(space ...)', and specifies display in the text area, return 2
6421 (try_cursor_movement): Check for the need to scroll more
6422 accurately, and prefer exact match for point under bidi.
6423 Don't advance `row' beyond the last row of the window.
6425 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6426 into disp_prop; all users changed.
6428 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6429 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6430 for the text covered by the display property.
6432 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6434 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6435 Change return value to nil.
6436 (Frecord_buffer): Delete unused function.
6438 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6440 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6441 buffers, return left-to-right.
6442 (set_cursor_from_row): Consider candidate row a win if its glyph
6443 represents a newline and point is on that newline. Fixes cursor
6444 positioning on the newline at EOL of R2L text within L2R
6445 paragraph, and vice versa.
6446 (try_cursor_movement): Check continued rows, in addition to
6447 continuation rows. Fixes unwarranted scroll when point enters a
6448 continued line of R2L text within an L2R paragraph, or vice versa.
6449 (cursor_row_p): Consider the case of point being equal to
6450 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6451 from the end of a short line to the beginning of a continued line
6452 of R2L text within L2R paragraph.
6453 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6454 composed characters.
6456 * bidi.c (bidi_check_type): Use xassert.
6457 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6460 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6462 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6465 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6467 * nsfont.m (ns_otf_to_script): Fix typo.
6469 2011-08-22 Kenichi Handa <handa@m17n.org>
6471 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6472 extra slot even if the purpose is char-code-property-table.
6474 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6476 * xdisp.c (redisplay_window): When computing centering_position,
6477 account for the height of the header line. (Bug#8874)
6479 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6480 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6481 candidate is selected by the mouse, and that candidate has a
6482 composed character under the mouse.
6484 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6485 coordinates reported by pos-visible-in-window-p for a composed
6486 character in column zero.
6488 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6490 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6492 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6494 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6495 consider it a hit if to_charpos is anywhere in the range of the
6496 composed buffer positions.
6498 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6500 * image.c (gif_load): Don't assume that each subimage has the same
6501 dimensions as the base image. Handle disposal method that is
6502 "undefined" by the gif spec (Bug#9335).
6504 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6506 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6507 (Fcondition_case): Document `debug' symbol in error handler.
6509 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6511 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6512 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6513 from an Org mode buffer to a Speedbar frame.
6515 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6516 a composition, take its buffer position from IT->cmp_it.charpos.
6517 Fixes cursor positioning at the beginning of a line that begins
6518 with a composed character.
6520 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6522 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6523 character bidirectional type, use STRONG_L instead. Fixes crashes
6524 in a buffer produced by `describe-categories'.
6526 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6527 members before the level stack, so they would be saved and
6528 restored when copying iterator state. Fixes incorrect reordering
6529 around TABs covered by display properties.
6531 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6533 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6535 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6537 * eval.c (internal_condition_case, internal_condition_case_1)
6538 (internal_condition_case_2, internal_condition_case_n):
6539 Remove unnecessary aborts (Bug#9081).
6541 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6543 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6544 has no `load' handler, try opening the file locally. (Bug#9311)
6546 2011-08-16 Ken Brown <kbrown@cornell.edu>
6548 * gmalloc.c: Expand comment.
6550 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6552 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6553 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6555 2011-08-16 Ken Brown <kbrown@cornell.edu>
6557 Fix memory allocation problems in Cygwin build (Bug#9273).
6559 * unexcw.c ( __malloc_initialized): Declare external variable.
6560 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6562 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6564 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6566 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6568 [CYGWIN] (special_realloc): New function.
6569 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6570 requests to realloc storage in the static heap.
6572 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6574 * bidi.c (bidi_initialize): Remove unused local.
6576 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6579 * biditype.h: Remove file.
6580 * makefile.w32-in ($(BLD)/bidi.$(O)):
6581 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6583 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6585 * chartab.c: Improve commentary for the uniprop_table API.
6587 * bidi.c (bidi_paragraph_init): Support zero value of
6588 bidi_ignore_explicit_marks_for_paragraph_level.
6589 (bidi_initialize): Use uniprop_table instead of including
6590 biditype.h and bidimirror.h.
6592 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6593 coordinates of the iterator when restoring from ppos_it.
6596 2011-08-14 Kenichi Handa <handa@m17n.org>
6598 * process.c (create_process): Call setup_process_coding_systems
6599 after the pid of the process is set to -1 (Bug#8162).
6601 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6603 * xdisp.c (move_it_in_display_line_to): Don't invoke
6604 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6605 ppos_it. Fixes vertical cursor motion when line beginning is
6606 covered by an image. (Bug#9296)
6608 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6610 * nsterm.h (ns_run_ascript): Declare.
6611 (NSAPP_DATA2_RUNASSCRIPT): Define.
6613 * nsfns.m (as_script, as_result, as_status): New static variables.
6614 (ns_run_ascript): New function.
6615 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6616 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6617 the event loop. Get status from as_status (Bug#7276).
6619 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6620 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6621 the event loop (Bug#7276).
6623 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6625 * gnutls.c (QCgnutls_bootprop_priority)
6626 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6627 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6628 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6629 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6630 (QCgnutls_bootprop_verify_hostname_error)
6631 (QCgnutls_bootprop_callbacks_verify): Rename from
6632 Qgnutls_bootprop_..., all uses changed.
6634 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6637 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6639 * xfaces.c (Qframe_set_background_mode): Now static.
6640 * dispextern.h (Qframe_set_background_mode): Remove decl.
6642 * process.c (Fnetwork_interface_info): Declare local only if needed.
6644 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6646 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6647 (Fnetwork_interface_list): Allocate in increments of bytes instead
6648 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6649 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6651 (struct ifflag_def): notrailers is smart on OSX.
6652 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6653 Get hardware address with getifaddrs if available.
6655 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6657 * xdisp.c (iterate_out_of_display_property): xassert that
6658 IT->position is set to within IT->object's boundaries. Break from
6659 the loop as soon as EOB is reached; avoids infloops in redisplay
6660 when IT->position is set up wrongly due to some bug.
6661 Set IT->current to match the bidi iterator unconditionally.
6662 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6663 entry. Force push_it to save on the stack the current
6664 buffer/string position, to be restored by pop_it. Fix flags in
6665 the iterator structure wrt the object coming from a display
6666 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6667 properties. (Bug#9284)
6669 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6671 * fontset.c (fontset_get_font_group): Add proper type checks.
6674 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6676 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6677 and LC_VERSION_MIN_MACOSX.
6678 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6679 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6681 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6683 * xdisp.c (forward_to_next_line_start): Allow to use the
6684 no-display-properties-and-no-overlays under bidi display.
6685 Set disp_pos in the bidi iterator to avoid searches for display
6686 properties and overlays.
6688 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6690 * editfns.c (Fset_time_zone_rule): Document relationship with the
6693 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6694 the font entity extracted from the cache (Bug#8109).
6696 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6698 * composite.c (autocmp_chars): Don't reset point. That is done by
6699 restore_point_unwind (Bug#5984).
6701 2011-08-07 Juri Linkov <juri@jurta.org>
6703 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6704 to show the arg `TIME' instead of `TIMEVAL'.
6706 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6708 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6709 display property strides EOL and includes a newline, as in
6710 longlines-mode. (Bug#9254)
6711 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6712 word-wrap under bidirectional display. (Bug#9224)
6714 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6715 is non-zero, even if the data buffer is NULL. Fixes a crash in
6716 vertical-motion with longlines-mode. (Bug#9254)
6718 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6720 * bidi.c <bidi_cache_total_alloc>: Now static.
6721 (bidi_initialize): Initialize bidi_cache_total_alloc.
6723 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6726 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6727 amount allocated this far in `bidi_cache_total_alloc'.
6728 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6729 non-zero, only free the data buffer without restoring the cache
6730 contents. All callers changed.
6732 * dispextern.h (bidi_unshelve_cache): Update prototype.
6734 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6735 (move_it_in_display_line, move_it_to)
6736 (move_it_vertically_backward, move_it_by_lines): Replace the call
6737 to xfree to an equivalent call to bidi_unshelve_cache.
6738 (move_it_in_display_line_to): Fix logic of returning
6739 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6741 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6743 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6744 came from a string character with a `cursor' property. (Bug#9229)
6746 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6748 * Makefile.in (LIB_PTHREAD): New variable.
6749 (LIBES): Add LIB_PTHREAD (Bug#9216).
6751 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6752 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6754 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6756 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6758 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6760 * xterm.c (x_find_topmost_parent): New function.
6761 (x_set_frame_alpha): Find topmost parent window with
6762 x_find_topmost_parent and set the property there also (bug#9181).
6763 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6765 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6767 * callproc.c (Fcall_process): Avoid vfork clobbering
6768 the local vars buffer, coding_systems, current_dir.
6770 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6772 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6774 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6776 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6777 so that it is not optimized away.
6779 * xdisp.c (compute_display_string_pos): Remove unused local.
6781 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6783 Fix slow cursor motion and scrolling in large buffers with
6784 selective display, like Org Mode buffers. (Bug#9218)
6786 * dispextern.h (struct bidi_it): New member disp_prop_p.
6788 * xdisp.c: Remove one-slot cache of display string positions.
6789 (compute_display_string_pos): Accept an additional argument
6790 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6791 for a display string or property. If found, set DISP_PROP_P
6794 * bidi.c (bidi_fetch_char): Accept an additional argument
6795 DISP_PROP_P, and pass it to compute_display_string_pos.
6796 Only handle text covered by a display string if DISP_PROP_P is returned
6797 non-zero. All callers of bidi_fetch_char changed.
6799 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6801 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6803 2010-12-03 Don March <don@ohspite.net>
6805 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6806 last character M-[char] is translated to ESC [char] (bug#7541).
6808 2011-08-02 Kenichi Handa <handa@m17n.org>
6810 * lisp.h (uniprop_table): Extern it.
6812 * chartab.c (uniprop_table): Make it non-static.
6814 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6816 * xdisp.c (forward_to_next_line_start): Accept additional argument
6817 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6819 (reseat_at_next_visible_line_start): Use the bidi iterator state
6820 returned by forward_to_next_line_start to restore the state of
6821 it->bidi_it after backing up to previous newline. (Bug#9212)
6823 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6825 * regex.c (re_comp): Protoize.
6826 (re_exec): Fix return type.
6827 (regexec): Fix type of `ret'. (Bug#9203)
6829 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6831 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6832 This is needed if max-image-size is a floating-point number.
6834 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6836 * print.c (print_object): Print empty symbol as ##.
6838 * lread.c (read1): Read ## as empty symbol.
6840 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6842 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6843 setting frame foreground color (Bug#9175).
6844 (x_set_background_color): Likewise.
6846 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6847 contents (Bug#9176).
6848 (EmacsTooltip -init): Remove bezels and add shadows to
6851 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6852 or scroll bar (Bug#8470).
6854 * nsfont.m (nsfont_open): Remove assignment to voffset and
6855 unnecessary vars hshink, expand, hd, full_height, min_height.
6856 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6858 * nsterm.h (nsfont_info): Remove voffset field.
6860 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6862 Implement strike-through and overline on NextStep (Bug#8863).
6864 * nsfont.m (nsfont_open): Use underline position provided by font,
6865 instead of hard-coded value of 2.
6866 (nsfont_draw): Call ns_draw_text_decoration instead.
6868 * nsterm.h: Add declaration for ns_draw_text_decoration.
6870 * nsterm.m (ns_draw_text_decoration): New function for drawing
6871 underline, overline, and strike-through.
6872 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6873 ns_draw_text_decoration. Change treatment of cursor drawing to
6874 accommodate underlining, etc.
6876 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6878 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6881 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6883 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6884 Without this fix, if a signal arrives just after memory fills up,
6885 'malloc' might be invoked reentrantly.
6887 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6888 In other words, assume that every image size is allowed, on non-X
6889 hosts. This assumption is probably wrong, but it lets Emacs compile.
6891 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6893 * regex.c (re_iswctype): Convert return values to boolean.
6895 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6897 * xdisp.c (compute_display_string_pos): Don't use cached display
6898 string position if the buffer had its restriction changed.
6901 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6903 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6905 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6907 Integer signedness and overflow and related fixes. (Bug#9079)
6909 * bidi.c: Integer size and overflow fixes.
6910 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6911 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6912 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6913 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6914 (bidi_find_other_level_edge):
6915 Use ptrdiff_t instead of EMACS_INT where either will do.
6916 This works better on 32-bit hosts configured --with-wide-int.
6917 (bidi_cache_ensure_space): Check for size-calculation overflow.
6918 Use % rather than repeated addition, for better worst-case speed.
6919 Don't set bidi_cache_size until after xrealloc returns, because it
6921 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6922 (bidi_cache_ensure_space): Also check that the bidi cache size
6923 does not exceed that of the largest Lisp string or buffer. See Eli
6924 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6926 * alloc.c (__malloc_size_t): Remove.
6927 All uses replaced by size_t. See Andreas Schwab's note
6928 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6930 * image.c: Improve checking for integer overflow.
6931 (check_image_size): Assume that f is nonnull, since
6932 it is always nonnull in practice. This is one less thing to
6933 worry about when checking for integer overflow later.
6934 (x_check_image_size): New function, which checks for integer
6935 overflow issues inside X.
6936 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6937 This removes the need for a memory_full check.
6938 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6939 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6940 (xbm_read_bitmap_data): Change locals back to 'int', since
6941 their values must fit in 'int'.
6942 (xpm_load_image, png_load, tiff_load):
6943 Invoke x_create_x_image_and_pixmap earlier,
6944 to avoid much needless work if the image is too large.
6945 (tiff_load): Treat overly large images as if
6946 x_create_x_image_and_pixmap failed, not as malloc failures.
6947 (gs_load): Use x_check_image_size.
6949 * gtkutil.c: Omit integer casts.
6950 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6951 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6953 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6955 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6956 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6957 would wrongly return t on a 64-bit host.
6959 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6960 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6961 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6962 and therefore cause GCC to emit a bogus diagnostic in some cases.
6964 * image.c: Integer signedness and overflow and related fixes.
6965 This is not an exhaustive set of fixes, but it's time to
6966 record what I've got.
6967 (lookup_pixel_color, check_image_size): Remove redundant decls.
6968 (check_image_size): Don't assume that arbitrary EMACS_INT values
6969 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6970 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6971 (tiff_load, imagemagick_load_image):
6972 Check for overflow in size calculations.
6973 (x_create_x_image_and_pixmap): Remove unnecessary test for
6974 xmalloc returning NULL; that can't happen.
6975 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6976 (xpm_color_bucket): Use better integer hashing function.
6977 (xpm_cache_color): Don't possibly over-allocate memory.
6978 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6979 (gif_memory_source):
6980 Use ptrdiff_t, not int or size_t, to record sizes.
6981 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6982 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6983 either works, as we prefer signed integers.
6984 (tiff_read_from_memory, tiff_write_from_memory):
6985 Return tsize_t, not size_t, since that's what the TIFF API wants.
6986 (tiff_read_from_memory): Don't fail simply because the read would
6987 go past EOF; instead, return a short read.
6988 (tiff_load): Omit no-longer-needed casts.
6989 (Fimagemagick_types): Don't assume size fits into 'int'.
6991 Improve hashing quality when configured --with-wide-int.
6992 * fns.c (hash_string): New function, taken from sxhash_string.
6993 Do not discard information about ASCII character case; this
6994 discarding is no longer needed.
6995 (sxhash-string): Use it. Change sig to match it. Caller changed.
6996 * lisp.h: Declare it.
6997 * lread.c (hash_string): Remove, since we now use fns.c's version.
6998 The fns.c version returns a wider integer if --with-wide-int is
6999 specified, so this should help the quality of the hashing a bit.
7001 * emacs.c: Integer overflow minor fix.
7002 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7003 Define only if GNU_LINUX.
7004 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7006 * dispnew.c: Integer signedness and overflow fixes.
7007 Remove unnecessary forward decls, that were a maintenance hassle.
7008 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7010 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7011 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7012 (prepare_desired_row, line_draw_cost):
7013 Use int, not unsigned, where either works.
7014 (save_current_matrix, restore_current_matrix):
7015 Use ptrdiff_t, not size_t, where either works.
7016 (init_display): Check for overflow more accurately, and without
7017 relying on undefined behavior.
7019 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7020 Remove, replacing with the new symbols in lisp.h. All uses changed.
7021 * fileio.c (make_temp_name):
7022 * filelock.c (lock_file_1, lock_file):
7023 * xdisp.c (message_dolog):
7024 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7025 Use pMd etc. instead.
7026 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7027 replacing the pWIDE etc. symbols removed from editfns.c.
7029 * keyboard.h (num_input_events): Now uintmax_t.
7030 This is (very slightly) less likely to mess up due to wraparound.
7033 * buffer.c: Integer signedness fixes.
7034 (alloc_buffer_text, enlarge_buffer_text):
7035 Use ptrdiff_t rather than size_t when either will do, as we prefer
7038 * alloc.c: Integer signedness and overflow fixes.
7039 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7040 (__malloc_size_t): Default to size_t, not to int.
7041 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7042 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7043 Prefer ptrdiff_t to size_t when either would do, as we prefer
7045 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7046 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7047 Now const. Initialize with values that are in range even if char
7049 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7050 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7051 These functions do the right thing with sizes > 2**32.
7052 (check_depth): Now ptrdiff_t, not int.
7053 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7054 Adjust to new way of storing sizes. Check for size overflow bugs
7056 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7057 slightly wrong anyway, as it missed one instance of
7058 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7059 (refill_memory_reserve): Omit needless cast to size_t.
7060 (mark_object_loop_halt): Mark as externally visible.
7062 * xselect.c: Integer signedness and overflow fixes.
7063 (Fx_register_dnd_atom, x_handle_dnd_message):
7064 Use ptrdiff_t, not size_t, since we prefer signed.
7065 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7066 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7067 x_dnd_atoms_size and x_dnd_atoms_length.
7069 * doprnt.c: Prefer signed to unsigned when either works.
7071 * doprnt.c (doprnt):
7073 * xdisp.c (vmessage):
7074 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7075 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7076 prefer signed arithmetic to avoid comparison confusion.
7077 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7078 but is a bit tricky.
7080 Assume freestanding C89 headers, string.h, stdlib.h.
7081 * data.c, doprnt.c, floatfns.c, print.c:
7082 Include float.h unconditionally.
7083 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7084 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7085 * regex.c: Likewise for stddef.h, string.h.
7086 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7087 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7088 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7089 (STDC_HEADERS): Remove obsolete defines.
7090 * sysdep.c: Include limits.h unconditionally.
7092 Assume support for memcmp, memcpy, memmove, memset.
7093 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7094 * regex.c (memcmp, memcpy):
7095 Remove; we assume C89 now.
7097 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7098 (__malloc_safe_bcopy): Remove; no longer needed.
7100 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7101 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7102 well either way, and we prefer signed to unsigned.
7104 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7106 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7107 closes the connection while we're reading (bug#9182).
7109 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7111 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7112 are specified (Bug#9168).
7114 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7116 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7117 Found by GCC static checking and --with-wide-int on a 32-bit host.
7119 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7121 * xdisp.c (compute_display_string_pos): Fix logic of caching
7122 previous display string position. Initialize cached_prev_pos to
7123 -1. Fixes slow-down at the beginning of a buffer.
7125 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7127 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7128 for attrs[LFACE_FONTSET_INDEX].
7130 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7132 * xml.c (parse_region): Remove unused local
7133 that was recently introduced.
7135 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7137 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7138 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7140 * xdisp.c (move_it_in_display_line_to): Record the best matching
7141 position for TO_CHARPOS while scanning the line, and restore it on
7142 exit if none of the characters scanned was an exact match.
7143 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7144 when exact match is impossible due to invisible text, and the
7145 lines are truncated.
7147 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7149 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7152 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7154 Fix a significant slow-down of cursor motion with C-n, C-p,
7155 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7156 auto-repeat under bidi redisplay in fontified buffers.
7157 * xdisp.c (compute_stop_pos_backwards): New function.
7158 (next_element_from_buffer): Call compute_stop_pos_backwards to
7159 find a suitable prev_stop when we find ourselves before
7161 (reseat): Don't look for prev_stop, as that could mean a very long
7163 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7164 <cached_disp_overlay_modiff>: Cache for last found display string
7166 (compute_display_string_pos): Return the cached position if asked
7167 about the same buffer in the same area of character positions, and
7168 the buffer wasn't changed since the time the display string
7169 position was cached.
7171 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7173 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7174 is an integer, which is important for empty lines. (Bug#9149)
7176 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7178 * frame.c (Fmodify_frame_parameters): In tty case, update the
7179 default face if necessary (Bug#4238).
7181 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7183 * editfns.c (Fstring_to_char): No need to explain what a character
7184 is in the docstring (Bug#6576).
7186 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7188 * xml.c (parse_region): Make sure we always return a tree.
7190 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7192 * xml.c (parse_region): If a document contains only comments,
7195 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7197 * xml.c (make_dom): Return comments, too.
7199 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7202 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7203 and the surrounding thread.
7204 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7205 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7206 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7208 * s/openbsd.h (BROKEN_SIGIO): Define.
7209 * unexelf.c (unexec) [__OpenBSD__]:
7210 Don't update the .mdebug section of the Alpha COFF symbol table.
7212 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7214 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7217 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7219 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7220 This fixes some race conditions on the permissions of any newly
7223 * alloc.c (valid_pointer_p): Use pipe, not open.
7224 This fixes some permissions issues when debugging.
7226 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7227 If fchown fails to set both uid and gid, try to set just gid,
7228 as that is sometimes allowed. Adjust the file's mode to eliminate
7229 setuid or setgid bits that are inappropriate if fchown fails.
7231 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7233 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7234 to compare Lisp_Objects.
7235 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7236 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7237 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7239 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7241 * lread.c (read_integer): Unread even EOF character.
7242 (read1): Likewise. Properly record start position of symbol.
7244 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7245 symbol character follows.
7247 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7249 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7250 This works around a problem with the previous change to Fcopy_file.
7251 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7252 and without this change, GCC might complain about discarding
7253 fchown's return value.
7255 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7257 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7259 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7261 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7263 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7265 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7266 it's used from the C level.
7268 * process.c: Use the same condition for POLL_FOR_INPUT in both
7269 keyboard.c and process.c (bug#1858).
7271 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7273 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7274 (Fgnutls_boot): Use it.
7276 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7278 * doc.c (Fsubstitute_command_keys): Revert last change.
7280 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7282 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7283 quotes the next character, and doesn't affect other longer
7284 sequences (bug#8935).
7286 * lread.c (syms_of_lread): Clarify that is isn't only
7287 `eval-buffer' and `eval-defun' that's affected by
7288 `lexical-binding' (bug#8460).
7290 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7292 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7293 bidi redisplay when a line includes both an image and is truncated.
7295 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7297 Fix minor problems found by static checking.
7298 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7299 (elsz): Now a signed constant, not a size_t var. We prefer signed
7300 types to unsigned, to avoid integer comparison confusion. Without
7301 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7302 "cannot optimize loop, the loop counter may overflow", a symptom
7304 * indent.c (Fvertical_motion): Mark locals as initialized.
7305 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7307 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7309 * search.c (Fre_search_backward): Mention `case-fold-search' in
7310 all the re_search_* functions (bug#8138).
7312 * keyboard.c (Fopen_dribble_file): Document when the file is
7315 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7317 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7320 Support bidi reordering of display and overlay strings.
7321 * xdisp.c (compute_display_string_pos)
7322 (compute_display_string_end): Accept additional argument STRING.
7323 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7324 (reseat_to_string): Initialize bidi_it->string.s and
7325 bidi_it->string.schars.
7326 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7327 NULL (avoids a crash in bidi_paragraph_init).
7328 Initialize itb.string.lstring.
7329 (init_iterator): Call bidi_init_it only of a valid
7330 buffer position was specified. Initialize paragraph_embedding to
7332 (reseat_to_string): Initialize the bidi iterator.
7333 (display_string): If we need to ignore text properties of
7334 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7335 original value of -1 will not work with bidi.)
7336 (compute_display_string_pos): First arg is now struct
7337 `text_pos *'; all callers changed. Support display properties on
7339 (compute_display_string_end): Support display properties on Lisp
7341 (init_iterator, reseat_1, reseat_to_string): Initialize the
7342 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7343 when iterating on a string not from display properties).
7344 (compute_display_string_pos, compute_display_string_end):
7345 Fix calculation of the object to scan. Fixes an error when using
7347 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7348 base_level_stop; instead, set base_level_stop to BEGV.
7349 Fixes crashes in vertical-motion.
7350 (next_element_from_buffer): Improve commentary for when
7351 the iterator is before prev_stop.
7352 (init_iterator): Initialize bidi_p from the default value of
7353 bidi-display-reordering, not from buffer-local value. Use the
7354 buffer-local value only if initializing for buffer iteration.
7355 (handle_invisible_prop): Support invisible properties on strings
7356 that are being bidi-reordered.
7357 (set_iterator_to_next): Support bidi reordering of C strings and
7359 (next_element_from_string): Support bidi reordering of Lisp
7361 (handle_stop_backwards): Support Lisp strings as well.
7362 (display_string): Support display of R2L glyph rows.
7363 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7364 (init_iterator): Don't initialize it->bidi_p for strings
7366 (reseat_to_string): Initialize it->bidi_p for strings here.
7367 (next_element_from_string, next_element_from_c_string)
7368 (next_element_from_buffer): Add xassert's for correspondence
7369 between IT's object being iterated and it->bidi_it.string
7371 (face_before_or_after_it_pos): Support bidi iteration.
7372 (next_element_from_c_string): Handle the case of the first string
7373 character that is not the first one in the visual order.
7374 (get_visually_first_element): New function, refactored from common
7375 parts of next_element_from_buffer, next_element_from_string, and
7376 next_element_from_c_string.
7377 (tool_bar_lines_needed, redisplay_tool_bar)
7378 (display_menu_bar): Force left-to-right direction. Add a FIXME
7379 comment for making that be controlled by a user option.
7380 (push_it, pop_it): Save and restore the state of the
7381 bidi iterator. Save and restore the bidi_p flag.
7382 (pop_it): Iterate out of display property for string iteration as
7384 (iterate_out_of_display_property): Support iteration over strings.
7385 (handle_single_display_spec): Set up it->bidi_it for iteration
7386 over a display string, and call bidi_init_it.
7387 (handle_single_display_spec, next_overlay_string)
7388 (get_overlay_strings_1, push_display_prop): Set up the bidi
7389 iterator for displaying display or overlay strings.
7390 (forward_to_next_line_start): Don't use the shortcut if
7392 (back_to_previous_visible_line_start): If handle_display_prop
7393 pushed the iterator stack, restore the internal state of the bidi
7394 iterator by calling bidi_pop_it same number of times.
7395 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7396 and we are bidi-iterating, don't decrement the iterator position;
7397 instead, set the first_elt flag in the bidi iterator, to produce
7399 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7400 (push_display_prop): xassert that we are iterating a buffer.
7401 (push_it, pop_it): Save and restore paragraph_embedding member.
7402 (handle_single_display_spec, next_overlay_string)
7403 (get_overlay_strings_1, reseat_1, reseat_to_string)
7404 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7405 correctly. Don't assume unibyte strings are not bidi-reordered.
7406 (compute_display_string_pos)
7407 (compute_display_string_end): Fix handling the case of C string.
7408 (push_it, pop_it): Save and restore from_disp_prop_p.
7409 (handle_single_display_spec, push_display_prop): Set the
7410 from_disp_prop_p flag.
7411 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7412 (pop_it): Call iterate_out_of_display_property only if we are
7413 popping after iteration over a string that came from a display
7414 property. Fix a typo in popping stretch info. Add an assertion
7415 for verifying that the iterator position is in sync with the bidi
7417 (handle_single_display_spec, get_overlay_strings_1)
7418 (push_display_prop): Fix initialization of paragraph direction for
7419 string when that of the parent object is not yet determined.
7420 (reseat_1): Call bidi_init_it to resync the bidi
7421 iterator with IT's position. (Bug#7616)
7422 (find_row_edges): If ROW->start.pos gives position
7423 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7424 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7425 Reset the from_disp_prop_p flag.
7426 (SAVE_IT, RESTORE_IT): New macros.
7427 (pos_visible_p, face_before_or_after_it_pos)
7428 (back_to_previous_visible_line_start)
7429 (move_it_in_display_line_to, move_it_in_display_line)
7430 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7431 (try_scrolling, redisplay_window, display_line): Use them when
7432 saving a temporary copy of the iterator and restoring it back.
7433 (back_to_previous_visible_line_start, reseat_1)
7434 (init_iterator): Empty the bidi cache "stack".
7435 (move_it_in_display_line_to): If iterator ended up at
7436 EOL, but we never saw any buffer positions smaller than
7437 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7438 motion in bidi-reordered lines.
7439 (move_it_in_display_line_to): Record prev_method and prev_pos
7440 immediately before the call to set_iterator_to_next. Fixes cursor
7441 motion in bidi-reordered lines with stretch glyphs and strings
7442 displayed in margins. (Bug#8133) (Bug#8867)
7443 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7445 (pos_visible_p): Support positions in bidi-reordered lines.
7446 Save and restore bidi cache.
7448 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7449 (bidi_paragraph_info): Delete unused struct.
7450 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7451 (bidi_cache_start): New variable.
7452 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7454 (bidi_cache_fetch_state, bidi_cache_search)
7455 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7456 (bidi_cache_find, bidi_peek_at_next_level)
7457 (bidi_level_of_next_char, bidi_find_other_level_edge)
7458 (bidi_move_to_visually_next): Compare cache index with
7459 bidi_cache_start rather than with zero.
7460 (bidi_fetch_char): Accept new argument STRING; all callers
7461 changed. Support iteration over a string. Support strings with
7462 display properties. Support unibyte strings. Fix the type of
7463 `len' according to what STRING_CHAR_AND_LENGTH expects.
7464 (bidi_paragraph_init, bidi_resolve_explicit_1)
7465 (bidi_resolve_explicit, bidi_resolve_weak)
7466 (bidi_level_of_next_char, bidi_move_to_visually_next):
7467 Support iteration over a string.
7468 (bidi_set_sor_type, bidi_resolve_explicit_1)
7469 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7470 can now be zero (for strings); special values 0 and -1 were
7471 changed to -1 and -2, respectively.
7472 (bidi_char_at_pos): New function.
7473 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7474 Call it instead of FETCH_MULTIBYTE_CHAR.
7475 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7476 initialized to valid values.
7477 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7479 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7480 the test for valid cached positions. Fix the logic for looking up
7481 the sentinel state in the cache. GCPRO the Lisp string we are
7483 (bidi_push_it, bidi_pop_it): New functions.
7484 (bidi_initialize): Initialize the bidi cache start stack pointer.
7485 (bidi_cache_ensure_space): New function, refactored from part of
7486 bidi_cache_iterator_state. Don't assume the required size is just
7487 one BIDI_CACHE_CHUNK away.
7488 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7489 (bidi_count_bytes, bidi_char_at_pos): New functions.
7490 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7491 always valid if bidi_cache_idx is valid.
7492 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7493 is valid if it's going to be used.
7494 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7495 (bidi_cache_fetch_state, bidi_cache_search)
7496 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7497 (bidi_cache_iterator_state, bidi_cache_find)
7498 (bidi_find_other_level_edge, bidi_cache_start_stack):
7499 All variables related to cache indices are now EMACS_INT.
7501 * dispextern.h (struct bidi_string_data): New structure.
7502 (struct bidi_it): New member `string'. Make flag members be 1-bit
7503 fields, and put them last in the struct.
7504 (compute_display_string_pos, compute_display_string_end):
7506 (bidi_push_it, bidi_pop_it): Add prototypes.
7507 (struct iterator_stack_entry): New members bidi_p,
7508 paragraph_embedding, and from_disp_prop_p.
7509 (struct it): Member bidi_p is now a bit field 1 bit wide.
7510 (bidi_shelve_cache, bidi_unshelve_cache):
7513 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7514 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7515 and vector-like objects.
7517 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7518 cache around display iteration.
7520 * window.c (Fwindow_end, window_scroll_pixel_based)
7521 (displayed_window_lines, Frecenter): Save and restore the bidi
7522 cache around display iteration.
7524 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7526 * editfns.c (Fdelete_region): Clarify the use of the named
7527 parameters (bug#6788).
7529 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7531 * indent.c (Fvertical_motion): Set and restore w->pointm when
7532 saving and restoring the window's buffer (Bug#9006).
7534 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7536 * editfns.c (Fstring_to_char): Clarify just what is returned
7537 (bug#6576). Text by Eli Zaretskii.
7539 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7541 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7543 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7545 * buffer.c (mmap_find): Fix a typo.
7547 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7549 Fix execution of x selection hooks.
7550 * xselect.c (Qx_lost_selection_functions)
7551 (Qx_sent_selection_functions): New vars.
7552 (syms_of_xselect): DEFSYM them.
7553 (x_handle_selection_request): Pass Qx_sent_selection_functions
7554 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7555 (x_handle_selection_clear,x_clear_frame_selections):
7556 Pass Qx_lost_selection_functions rather than
7557 Vx_lost_selection_functions to Frun_hook_with_args.
7559 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7561 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7562 The old code sometimes used this field without initializing it.
7564 * alloc.c (gc_sweep): Don't read past end of array.
7565 In theory, the old code could also have corrupted Emacs internals,
7566 though it'd be very unlikely.
7568 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7570 * character.c (Fcharacterp): Don't advertise optional ignored
7571 argument. (Bug#4026)
7573 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7575 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7578 * window.c (Fset_window_start): Doc fix (bug#4199).
7579 (Fset_window_hscroll): Ditto.
7581 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7583 Fix minor new problems caught by GCC 4.6.1.
7584 * term.c (init_tty): Remove unused local.
7585 * xsettings.c (store_monospaced_changed): Define this function only
7586 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7589 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7591 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7593 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7595 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7596 are the mini-buffer and the echo area (bug#3320).
7598 * term.c (init_tty): Remove support for supdup, c10 and perq
7599 terminals, which are no longer supported (bug#1482).
7601 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7603 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7605 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7607 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7608 for non-popups (Bug#3642).
7610 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7612 * alloc.c (reset_malloc_hooks): Protoize.
7613 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7614 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7615 * cm.c (losecursor): Likewise.
7616 * data.c (fmod): Likewise.
7617 * dispnew.c (swap_glyphs_in_rows): Likewise.
7618 * emacs.c (memory_warning_signal): Likewise.
7619 * floatfns.c (float_error): Likewise.
7620 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7621 (otf_open, font_otf_capability, generate_otf_features)
7622 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7624 * image.c (pbm_read_file): Likewise.
7625 * indent.c (string_display_width): Likewise.
7626 * intervals.c (check_for_interval, search_for_interval)
7627 (inc_interval_count, count_intervals, root_interval)
7628 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7629 * lread.c (defalias): Likewise.
7630 * ralloc.c (r_alloc_check): Likewise.
7631 * regex.c (set_image_of_range_1, set_image_of_range)
7632 (regex_grow_registers): Likewise.
7633 * sysdep.c (strerror): Likewise.
7634 * termcap.c (valid_filename_p, tprint, main): Likewise.
7635 * tparam.c (main): Likewise.
7636 * unexhp9k800.c (run_time_remap, save_data_space)
7637 (update_file_ptrs, read_header, write_header, calculate_checksum)
7638 (copy_file, copy_rest, display_header): Likewise.
7639 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7641 * xdisp.c (check_it): Likewise.
7642 * xfaces.c (register_color, unregister_color, unregister_colors):
7644 * xfns.c (print_fontset_result): Likewise.
7645 * xrdb.c (member, fatal, main): Likewise.
7647 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7649 Fix minor problems found by static checking (Bug#9031).
7650 * chartab.c (char_table_set_range, map_sub_char_table):
7651 Remove unused locals.
7652 (uniprop_table): Now static.
7653 * composite.c (_work_char): Remove unused static var.
7655 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7657 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7659 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7661 * gtkutil.c (qttip_cb): Remove code without function.
7663 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7665 * w32.c (pthread_sigmask): New stub.
7667 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7669 Use pthread_sigmask, not sigprocmask (Bug#9010).
7670 sigprocmask is portable only for single-threaded applications, and
7671 Emacs can be multi-threaded when it uses GTK.
7672 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7674 * callproc.c (Fcall_process):
7675 * process.c (create_process):
7676 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7677 Use pthread_sigmask, not sigprocmask.
7679 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7681 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7682 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7685 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7687 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7688 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7689 (xg_hide_tooltip): Fix comment.
7691 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7692 in registerServicesMenuSendTypes.
7693 (validRequestorForSendType): Don't check ns_return_types.
7695 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7698 2011-07-08 Jason Rumney <jasonr@gnu.org>
7700 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7701 SH_SHOW for hidden windows (Bug#5482).
7703 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7704 frame struct members of non-existent frames (Bug#6284).
7706 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7708 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7709 variable firstTime not needed on OSX >= 10.6.
7710 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7711 >= 10.5. Use setKnobProportion, setDoubleValue.
7713 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7714 (MAC_OS_X_VERSION_10_5): Define if not defined.
7715 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7716 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7717 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7719 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7720 cString and lossyCString on OSX >= 10.4
7722 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7723 sizeToFit on OSX >= 10.2.
7725 * nsimage.m (allocInitFromFile): Don't use deprecated method
7726 bestRepresentationForDevice on OSX >= 10.6.
7728 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7731 * emacs.c: Declare unexec_init_emacs_zone.
7733 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7735 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7737 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7738 on svcsMenu (Bug#8842).
7740 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7742 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7744 * nsterm.m (QUTF8_STRING): Declare.
7745 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7746 (validRequestorForSendType): Return type is (id).
7747 Change indexOfObjectIdenticalTo to indexOfObject.
7748 Check if we have local selection before returning self (Bug#8842).
7749 (writeSelectionToPasteboard): Put local selection into paste board
7750 if we have a local selection (Bug#8842).
7751 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7753 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7754 (ns_get_local_selection): Declare.
7756 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7758 * keymap.c (describe_map_tree): Don't insert a double newline at
7759 the end of the buffer (bug#1169) and return whether we inserted
7762 * callint.c (Fcall_interactively): Change "reading args" to
7763 "providing args" to try to clarify what it does (bug#1010).
7765 2011-07-07 Kenichi Handa <handa@m17n.org>
7767 * composite.c (composition_compute_stop_pos): Ignore a static
7768 composition starting before CHARPOS (Bug#8915).
7770 * xdisp.c (handle_composition_prop): Likewise.
7772 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7774 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7777 2011-07-07 Kenichi Handa <handa@m17n.org>
7779 * character.h (unicode_category_t): New enum type.
7781 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7782 (Qchar_code_property_table): New variable.
7783 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7784 (UNIPROP_COMPRESSED_FORM_P): New macros.
7785 (char_table_ascii): Uncompress the compressed values.
7786 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7787 Uncompress the compressed values.
7788 (sub_char_table_ref_and_range): Likewise.
7789 (char_table_ref_and_range): Uncompress the compressed values.
7790 (sub_char_table_set): New arg is_uniprop. Callers changed.
7791 Uncompress the compressed values.
7792 (sub_char_table_set_range): Args changed. Callers changed.
7793 (char_table_set_range): Adjuted for the above change.
7794 (map_sub_char_table): Delete args default_val and parent. Add arg
7795 top. Give decoded values to a Lisp function.
7796 (map_char_table): Adjust for the above change. Give decoded
7797 values to a Lisp function. Gcpro more variables.
7798 (uniprop_table_uncompress)
7799 (uniprop_decode_value_run_length): New functions.
7800 (uniprop_decoder, uniprop_decoder_count): New variables.
7801 (uniprop_get_decoder, uniprop_encode_value_character)
7802 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7804 (uniprop_encoder, uniprop_encoder_count): New variables.
7805 (uniprop_get_encoder, uniprop_table)
7806 (Funicode_property_table_internal, Fget_unicode_property_internal)
7807 (Fput_unicode_property_internal): New functions.
7808 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7809 Sunicode_property_table_internal, Sget_unicode_property_internal,
7810 and Sput_unicode_property_internal. Defvar_lisp
7811 char-code-property-alist.
7813 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7814 Vunicode_category_table.
7816 * font.c (font_range): Adjust for the change of
7817 Vunicode_category_table.
7819 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7821 * m/iris4d.h: Remove file, move contents ...
7822 * s/irix6-5.h: ... here.
7824 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7826 Remove unportable assumption about struct layout (Bug#8884).
7827 * alloc.c (mark_buffer):
7828 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7829 (clone_per_buffer_values): Don't assume that
7830 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7831 This isn't true in general, and it's particularly not true
7832 if Emacs is configured with --with-wide-int.
7833 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7834 New macros, used in the buffer.c change.
7836 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7838 * xsettings.c: Use both GConf and GSettings if both are available.
7839 (store_config_changed_event): Add comment.
7840 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7841 (store_tool_bar_style_changed): New functions.
7842 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7843 (struct xsettings): Move font inside HAVE_XFT.
7844 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7845 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7846 Move inside HAVE_XFT.
7847 (something_changed_gsettingsCB): Rename from something_changedCB.
7848 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7850 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7851 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7852 (something_changed_gconfCB): Rename from something_changedCB.
7853 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7854 (parse_settings): Move check for font inside HAVE_XFT.
7855 (read_settings, apply_xft_settings): Add comment.
7856 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7857 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7858 call store_font_name_changed.
7859 (xft_settings_event): Add comment.
7860 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7861 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7862 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7863 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7864 (xsettings_initialize): Call init_gsettings last.
7865 (xsettings_get_system_font, xsettings_get_system_normal_font):
7868 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7870 Random fixes. E.g., (random) never returned negative values.
7871 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7872 subseconds part to the entropy, as that's a bit more random.
7873 Prefer signed to unsigned, since the signedness doesn't matter and
7874 in general we prefer signed. When given a limit, use a
7875 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7876 latter isn't right if USE_2_TAGS_FOR_INTS.
7877 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7878 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7880 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7882 * textprop.c (text_property_stickiness):
7883 Obey Vtext_property_default_nonsticky.
7884 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7885 * w32fns.c (syms_of_w32fns):
7886 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7888 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7890 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7891 This is more efficient than Ffile_directory_p and avoids a minor race.
7893 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7895 * buffer.c (Foverlay_put): Say what the return value is
7898 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7899 is a directory before asking whether to use the file name
7901 (barf_or_query_if_file_exists): Make the "File is a directory"
7902 error be more correct.
7904 * fns.c (Frequire): Remove the mention of the .gz files, since
7905 that's installation-specific, but keep the mention of
7906 `get-load-suffixes'.
7908 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7910 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7911 Report string overflow if the output is too long.
7913 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7915 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7916 (syms_of_gnutls): Remove duplicate DEFSYM for
7917 Qgnutls_bootprop_verify_hostname_error, an error for
7918 Qgnutls_bootprop_verify_error (which is no longer used).
7920 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7921 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7922 Also (re)move comments that are misplaced or no longer relevant.
7924 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7926 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7928 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7930 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7931 and background color parameters if they have been changed.
7933 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7935 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7937 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7939 * xsettings.c (SYSTEM_FONT): Define only when used.
7940 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7942 * keymap.c (access_keymap_1): Now static.
7944 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7946 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7947 leave any prefix arg for the up event (Bug#1586).
7949 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7951 * lread.c (syms_of_lread): Mention single symbols defined by
7952 `defvar' or `defconst' (bug#7154).
7954 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7955 (Frequire): Mention get-load-suffixes.
7957 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7959 * window.h (window): Remove clone_number slot.
7960 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7962 (make_parent_window, make_window, saved_window)
7963 (Fset_window_configuration, save_window_save): Don't deal with
7965 * buffer.c (Qclone_number): Remove declaration.
7966 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7968 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7970 Add multiple inheritance to keymaps.
7971 * keymap.c (Fmake_composed_keymap): New function.
7972 (Fset_keymap_parent): Simplify.
7973 (fix_submap_inheritance): Remove.
7974 (access_keymap_1): New function extracted from access_keymap to handle
7975 embedded parents and handle lists of maps.
7976 (access_keymap): Use it.
7977 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7978 (Fcopy_keymap): Handle embedded parents.
7979 (Fcommand_remapping, define_as_prefix): Simplify.
7980 (Fkey_binding): Simplify.
7981 (syms_of_keymap): Move minibuffer-local-completion-map,
7982 minibuffer-local-filename-completion-map,
7983 minibuffer-local-must-match-map, and
7984 minibuffer-local-filename-must-match-map to Elisp.
7985 (syms_of_keymap): Defsubr make-composed-keymap.
7986 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7987 (parse_menu_item): Trivial simplification.
7989 2011-07-01 Glenn Morris <rgm@gnu.org>
7991 * Makefile.in (SETTINGS_LIBS): Fix typo.
7993 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7995 * coding.c (Fencode_coding_string): Record the last coding system
7996 used, as the function doc string says (bug#8738).
7998 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8000 * xsettings.c (store_monospaced_changed): Take new font as arg and
8001 check for change against current_mono_font.
8002 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8003 (emacs_settings_constructor, emacs_settings_get_property)
8004 (emacs_settings_set_property, emacs_settings_class_init)
8005 (emacs_settings_init, gsettings_obj): Remove.
8006 (something_changedCB): New function for HAVE_GSETTINGS.
8007 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8008 with value as argument.
8009 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8010 g_settings_new (Bug#8967). Do not create gsettings_obj.
8011 Remove calls to g_settings_bind. Connect something_changedCB to
8014 * xgselect.c: Add defined (HAVE_GSETTINGS).
8015 (xgselect_initialize): Ditto.
8017 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8018 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8021 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8023 * eval.c (struct backtrace): Simplify and port the data structure.
8024 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8025 signed bit field, as this assumption is not portable and it makes
8026 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8027 "char debug_on_exit : 1" as this is not portable either; instead,
8028 use the portable "unsigned int debug_on_exit : 1". Remove unused
8029 member evalargs. Remove obsolete comments about cc bombing out.
8031 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8033 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8034 Let HAVE_GSETTINGS override HAVE_GCONF.
8035 (store_monospaced_changed): New function.
8036 (EMACS_SETTINGS): A new type derived from GObject to handle
8037 GSettings notifications.
8038 (emacs_settings_constructor, emacs_settings_get_property)
8039 (emacs_settings_set_property, emacs_settings_class_init):
8041 (gsettings_client, gsettings_obj): New variables.
8042 (GSETTINGS_SCHEMA): New define.
8043 (something_changedCB): Call store_monospaced_changed.
8044 (init_gsettings): New function.
8045 (xsettings_initialize): Call init_gsettings.
8046 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8049 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8052 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8054 * window.c (resize_root_window, grow_mini_window)
8055 (shrink_mini_window): Rename Qresize_root_window to
8056 Qwindow_resize_root_window and Qresize_root_window_vertically to
8057 Qwindow_resize_root_window_vertically.
8059 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8061 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8063 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8065 * makefile.w32-in: Redesign dependencies so they reflect more
8066 clearly which files are directly included by each source file,
8067 and not through other includes.
8069 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8071 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8072 (sort_overlays, overlay_strings): When an overlay's clone number
8073 matches the window's clone number process the overlay even if
8074 the overlay's window property doesn't match the current window.
8076 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8077 (Fwindow_hchild): Rename to Fwindow_left_child.
8078 (Fwindow_next): Rename to Fwindow_next_sibling.
8079 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8080 (resize_window_check): Rename to window_resize_check.
8081 (resize_window_apply): Rename to window_resize_apply.
8082 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8083 (Fdelete_other_windows_internal, resize_frame_windows)
8084 (Fsplit_window_internal, Fdelete_window_internal)
8085 (grow_mini_window, shrink_mini_window)
8086 (Fresize_mini_window_internal): Fix callers accordingly.
8088 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8090 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8091 (emacs_fixed_set_min_size): Remove.
8092 (emacs_fixed_new): Take frame as argument.
8094 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8095 (_EmacsFixedPrivate): Remove minwidth/height.
8096 Add struct frame *f.
8097 (emacs_fixed_init): Initialize priv->f.
8098 (get_parent_class, emacs_fixed_set_min_size): Remove.
8099 (emacs_fixed_new): Set priv->f to argument.
8100 (emacs_fixed_get_preferred_width)
8101 (emacs_fixed_get_preferred_height): Use min_width/height from
8102 frames size_hint to set minimum and natural (Bug#8919).
8103 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8104 and use min_width/height from frames size_hint to set
8105 min_width/height (Bug#8919).
8107 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8108 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8111 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8113 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8114 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8117 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8119 * process.c (wait_reading_process_output): Bypass select if
8120 waiting for a cell while ignoring keyboard input, and input is
8121 pending. Suggested by Jan Djärv (Bug#8869).
8123 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8125 Use gnulib's dup2 module instead of rolling our own.
8126 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8128 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8130 * dispnew.c (scrolling_window): Before scrolling, turn off a
8131 mouse-highlight in the window being scrolled.
8133 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8135 Move DEFSYM to lisp.h and use everywhere.
8137 * character.h (DEFSYM): Move declaration...
8138 * lisp.h (DEFSYM): ...here.
8144 * w32select.c: Don't include character.h.
8146 * alloc.c (syms_of_alloc):
8147 * buffer.c (syms_of_buffer):
8148 * bytecode.c (syms_of_bytecode):
8149 * callint.c (syms_of_callint):
8150 * casefiddle.c (syms_of_casefiddle):
8151 * casetab.c (init_casetab_once):
8152 * category.c (init_category_once, syms_of_category):
8153 * ccl.c (syms_of_ccl):
8154 * cmds.c (syms_of_cmds):
8155 * composite.c (syms_of_composite):
8156 * dbusbind.c (syms_of_dbusbind):
8157 * dired.c (syms_of_dired):
8158 * dispnew.c (syms_of_display):
8159 * doc.c (syms_of_doc):
8160 * editfns.c (syms_of_editfns):
8161 * emacs.c (syms_of_emacs):
8162 * eval.c (syms_of_eval):
8163 * fileio.c (syms_of_fileio):
8164 * fns.c (syms_of_fns):
8165 * frame.c (syms_of_frame):
8166 * fringe.c (syms_of_fringe):
8167 * insdel.c (syms_of_insdel):
8168 * keymap.c (syms_of_keymap):
8169 * lread.c (init_obarray, syms_of_lread):
8170 * macros.c (syms_of_macros):
8171 * msdos.c (syms_of_msdos):
8172 * print.c (syms_of_print):
8173 * process.c (syms_of_process):
8174 * search.c (syms_of_search):
8175 * sound.c (syms_of_sound):
8176 * syntax.c (init_syntax_once, syms_of_syntax):
8177 * terminal.c (syms_of_terminal):
8178 * textprop.c (syms_of_textprop):
8179 * undo.c (syms_of_undo):
8180 * w32.c (globals_of_w32):
8181 * window.c (syms_of_window):
8182 * xdisp.c (syms_of_xdisp):
8183 * xfaces.c (syms_of_xfaces):
8184 * xfns.c (syms_of_xfns):
8185 * xmenu.c (syms_of_xmenu):
8186 * xsettings.c (syms_of_xsettings):
8187 * xterm.c (syms_of_xterm): Use DEFSYM.
8189 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8191 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8193 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8195 Integer and buffer overflow fixes (Bug#8873).
8197 * print.c (printchar, strout): Check for string overflow.
8198 (PRINTPREPARE, printchar, strout):
8199 Don't set size unless allocation succeeds.
8201 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8202 for sizes. Check for string overflow more accurately.
8203 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8205 * macros.c: Integer and buffer overflow fixes.
8206 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8207 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8208 Use ptrdiff_t, not int, for sizes.
8209 Don't increment bufsize until after realloc succeeds.
8210 Check for size-calculation overflow.
8211 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8213 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8215 * lread.c: Integer overflow fixes.
8216 (read_integer): Radix is now EMACS_INT, not int,
8217 to improve quality of diagnostics for out-of-range radices.
8218 Calculate buffer size correctly for out-of-range radices.
8219 (read1): Check for integer overflow in radices, and in
8220 read-circle numbers.
8221 (read_escape): Avoid int overflow.
8222 (Fload, openp, read_buffer_size, read1)
8223 (substitute_object_recurse, read_vector, read_list, map_obarray):
8224 Use ptrdiff_t, not int, for sizes.
8225 (read1): Use EMACS_INT, not int, for sizes.
8226 Check for size overflow.
8228 * image.c (cache_image): Check for size arithmetic overflow.
8230 * lread.c: Integer overflow issues.
8231 (saved_doc_string_size, saved_doc_string_length)
8232 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8233 Now ptrdiff_t, not int.
8234 (read1): Don't assume doc string length fits in int. Check for
8235 out-of-range doc string lengths.
8236 (read_list): Don't assume file position fits in int.
8237 (read_escape): Check for hex character overflow.
8239 2011-06-22 Leo Liu <sdl.web@gmail.com>
8241 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8242 Move to minibuffer.el.
8244 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8246 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8247 The following patches are for when GLYPH_DEBUG && !XASSERT.
8248 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8249 * dispnew.c (flush_stdout):
8250 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8251 Mark as externally visible.
8252 * dispnew.c (check_window_matrix_pointers): Now static.
8253 * dispnew.c (window_to_frame_vpos):
8254 * xfns.c (unwind_create_frame):
8255 * xterm.c (x_check_font): Remove unused local.
8256 * scroll.c (CHECK_BOUNDS):
8257 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8258 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8259 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8260 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8261 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8263 (debug_method_add): Use va_list and vsprintf rather than relying
8264 on undefined behavior with wrong number of arguments.
8265 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8266 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8267 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8268 since we're not interested in debugging glyphs with old libraries.
8269 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8270 GCC 4.6.0's static checking.
8272 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8274 Integer overflow and signedness fixes (Bug#8873).
8275 A few related buffer overrun fixes, too.
8277 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8279 * dispextern.h (struct face.stipple):
8280 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8281 (x_bitmap_mask, x_allocate_bitmap_record)
8282 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8283 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8284 (x_create_bitmap_from_xpm_data):
8285 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8286 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8288 * xfaces.c (load_pixmap):
8289 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8290 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8291 (.bitmaps_last, struct x_output.icon_bitmap):
8292 Use ptrdiff_t, not int, for bitmap indexes.
8293 (x_allocate_bitmap_record): Check for size overflow.
8294 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8296 Use ptrdiff_t, not int, for overlay counts.
8297 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8298 * editfns.c (overlays_around, get_pos_property):
8299 * textprop.c (get_char_property_and_overlay):
8300 * xdisp.c (next_overlay_change, note_mouse_highlight):
8301 * xfaces.c (face_at_buffer_position):
8302 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8303 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8304 (Fnext_overlay_change, Fprevious_overlay_change)
8305 (mouse_face_overlay_overlaps, Foverlays_in):
8306 Use ptrdiff_t, not int, for sizes.
8307 (overlays_at, overlays_in): Check for size-calculation overflow.
8309 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8311 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8312 (x_session_initialize): Do not assume string length fits in int.
8314 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8315 This is unlikely, but can occur if DPI is outlandish.
8317 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8318 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8320 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8321 * xrdb.c (magic_file_p, search_magic_path):
8322 Omit last arg SUFFIX; it was always 0. All callers changed.
8323 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8325 * xfont.c (xfont_match): Avoid need for strlen.
8327 * xfns.c: Don't assume strlen fits in int.
8328 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8330 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8331 not unsigned long, as we prefer signed integers. All callers changed.
8332 Detect integer overflow in repeat count.
8333 (message_dolog): Don't assume print length fits in 39 bytes.
8334 (display_mode_element): Don't assume strlen fits in int.
8336 * termcap.c: Don't assume sizes fit in int and never overflow.
8337 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8338 (gobble_line): Check for size-calculation overflow.
8340 * minibuf.c (Fread_buffer):
8341 * lread.c (intern, intern_c_string):
8342 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8343 Don't assume string length fits in int.
8345 * keyboard.c (parse_tool_bar_item):
8346 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8348 * font.c: Don't assume string length fits in int.
8349 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8350 Use ptrdiff_t, not int.
8351 (font_intern_prop): Don't assume string length fits in int.
8352 Don't assume integer property fits in fixnum.
8353 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8355 * filelock.c: Fix some buffer overrun and integer overflow issues.
8356 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8357 Reformulate so as not to need the command string.
8358 Invoke gzip -cd rather than gunzip, as it's more portable.
8359 (lock_info_type, lock_file_1, lock_file):
8360 Don't assume pid_t and time_t fit in unsigned long.
8361 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8362 (current_lock_owner): Prefer signed type for sizes.
8363 Use memcpy, not strncpy, where memcpy is what is really wanted.
8364 Don't assume (via atoi) that time_t and pid_t fit in int.
8365 Check for time_t and/or pid_t out of range, e.g., via a network share.
8366 Don't alloca where an auto var works fine.
8368 * fileio.c: Fix some integer overflow issues.
8369 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8370 Don't assume string length fits in int.
8371 (directory_file_name): Don't assume string length fits in long.
8372 (make_temp_name): Don't assume pid fits in int, or that its print
8373 length is less than 20.
8375 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8377 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8379 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8381 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8382 We prefer signed integers, even for size calculations.
8384 * emacs.c: Don't assume string length fits in 'int'.
8385 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8386 (main): Don't invoke strlen when not needed.
8388 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8389 (XD_DEBUG_MESSAGE): Don't waste a byte.
8391 * callproc.c (getenv_internal_1, getenv_internal)
8393 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8395 * lread.c (invalid_syntax): Omit length argument.
8396 All uses changed. This doesn't fix a bug, but it simplifies the
8397 code away from its former Hollerith-constant appearance, and it's
8398 one less 'int' to worry about when looking at integer-overflow issues.
8399 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8401 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8402 This didn't break anything, but it didn't help either.
8403 It's confusing to put a bogus integer in a place where the actual
8404 value does not matter.
8405 (LIST_END_P): Remove unused macro and its bogus comment.
8406 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8408 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8409 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8411 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8412 We prefer signed types, and the value cannot exceed the EMACS_INT
8413 range anyway (because otherwise the length would not be representable).
8414 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8415 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8416 This avoids a GCC warning when WIDE_EMACS_INT.
8418 * indent.c (sane_tab_width): New function.
8419 (current_column, scan_for_column, Findent_to, position_indentation)
8420 (compute_motion): Use it. This is just for clarity.
8421 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8423 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8425 * lisp.h (lint_assume): New macro.
8426 * composite.c (composition_gstring_put_cache):
8427 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8429 * editfns.c, insdel.c:
8430 Omit unnecessary forward decls, to simplify future changes.
8432 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8434 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8436 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8437 Use much-faster test for byte-length change.
8438 Don't assume string byte-length fits in 'int'.
8439 Check that character arg fits in 'int'.
8440 (mapcar1): Declare byte as byte, for clarity.
8442 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8444 * fns.c (concat): Catch string overflow earlier.
8445 Do not rely on integer wraparound.
8447 * dispextern.h (struct it.overlay_strings_charpos)
8448 (struct it.selective): Now EMACS_INT, not int.
8449 * xdisp.c (forward_to_next_line_start)
8450 (back_to_previous_visible_line_start)
8451 (reseat_at_next_visible_line_start, next_element_from_buffer):
8452 Don't arbitrarily truncate the value of 'selective' to int.
8454 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8456 * composite.c: Don't truncate sizes to 'int'.
8457 (composition_gstring_p, composition_reseat_it)
8458 (composition_adjust_point): Use EMACS_INT, not int.
8459 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8460 not EMACS_UINT, for indexes.
8462 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8464 * buffer.c: Include <verify.h>.
8465 (struct sortvec.priority, struct sortstr.priority):
8466 Now EMACS_INT, not int.
8467 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8468 (struct sortstr.size, record_overlay_string)
8469 (struct sortstrlist.size, struct sortlist.used):
8470 Don't truncate size to int.
8471 (record_overlay_string): Check for size-calculation overflow.
8472 (init_buffer_once): Check at compile-time, not run-time.
8474 2011-06-22 Jim Meyering <meyering@redhat.com>
8476 Don't leak an XBM-image-sized buffer
8477 * image.c (xbm_load): Free the image buffer after using it.
8479 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8482 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8483 that Sun C diagnosed.
8484 * fns.c (secure_hash): Fix pointer signedness issue.
8485 * intervals.c (static_offset_intervals): New function.
8486 (offset_intervals): Use it.
8488 2011-06-21 Leo Liu <sdl.web@gmail.com>
8491 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8494 * fns.c (secure_hash): Rename from crypto_hash_function and change
8495 the first arg to accept symbols.
8496 (Fsecure_hash): New primitive.
8497 (syms_of_fns): New symbols.
8499 2011-06-20 Deniz Dogan <deniz@dogan.se>
8501 * process.c (Fset_process_buffer): Clarify return value in
8504 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8506 * dispnew.c (add_window_display_history): Use BVAR.
8508 * xdisp.c (debug_method_add): Use BVAR.
8509 (check_window_end, dump_glyph_matrix, dump_glyph)
8510 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8512 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8515 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8516 check till after the cache is created in init_frame_faces.
8518 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8520 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8522 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8524 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8525 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8526 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8528 Improve buffer-overflow checking (Bug#8873).
8529 * fileio.c (Finsert_file_contents):
8530 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8531 Remove the old (too-loose) buffer overflow checks.
8532 They weren't needed, since make_gap checks for buffer overflow.
8533 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8534 The old code merely checked for Emacs fixnum overflow, and relied
8535 on undefined (wraparound) behavior. The new code avoids undefined
8536 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8538 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8539 Tune. Don't use wider integers than needed. Don't use alloca.
8540 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8542 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8544 * insdel.c, lisp.h (buffer_overflow): New function.
8545 (insert_from_buffer_1, replace_range, replace_range_2):
8546 * insdel.c (make_gap_larger):
8547 * editfns.c (Finsert_char):
8548 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8550 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8552 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8554 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8556 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8557 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8559 * fileio.c: Don't assume EMACS_INT fits in off_t.
8560 (emacs_lseek): New static function.
8561 (Finsert_file_contents, Fwrite_region): Use it.
8562 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8564 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8566 * fns.c: Don't overflow int when computing a list length.
8567 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8568 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8569 truncation on 64-bit hosts. Check for QUIT every
8570 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8571 faster and is responsive enough.
8572 (Flength): Report an error instead of overflowing an integer.
8573 (Fsafe_length): Return a float if the value is not representable
8574 as a fixnum. This shouldn't happen except in contrived situations.
8575 (Fnthcdr, Fsort): Don't assume list length fits in int.
8576 (Fcopy_sequence): Don't assume vector length fits in int.
8578 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8579 (header_size, word_size): New constants.
8580 (allocate_vectorlike): Don't check size overflow here.
8581 (allocate_vector): Check it here instead, since this is the only
8582 caller of allocate_vectorlike that could cause overflow.
8583 Check that the new vector's length is representable as a fixnum.
8585 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8586 The previous code was bogus. For example, next_almost_prime (32)
8587 returned 39, which is undesirable as it is a multiple of 3; and
8588 next_almost_prime (24) returned 25, which is a multiple of 5 so
8589 why was the code bothering to check for multiples of 7?
8591 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8593 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8595 Variadic C functions now count arguments with ptrdiff_t.
8596 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8597 Back then I didn't know that the Emacs coding style prefers signed int.
8598 Also, in the meantime I found a few more instances where arguments
8599 were being counted with int, which may truncate counts on 64-bit
8600 machines, or EMACS_INT, which may be unnecessarily wide.
8601 * lisp.h (struct Lisp_Subr.function.aMANY)
8602 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8603 Arg counts are now ptrdiff_t, not size_t.
8604 All variadic functions and their callers changed accordingly.
8605 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8606 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8607 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8608 * callint.c (Fcall_interactively): Check arg count for overflow,
8609 to avoid potential buffer overrun. Use signed char, not 'int',
8610 for 'varies' array, so that we needn't bother to check its size
8611 calculation for overflow.
8612 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8613 * eval.c (apply_lambda):
8614 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8615 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8616 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8618 * callint.c (Fcall_interactively): Don't use index var as event count.
8620 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8621 * mem-limits.h (SIZE): Remove; no longer used.
8623 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8625 Remove unnecessary casts.
8626 * xterm.c (x_term_init):
8627 * xfns.c (x_set_border_pixel):
8628 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8629 These aren't needed now that we assume ANSI C.
8631 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8632 It's more likely to cause problems (due to unsigned overflow)
8635 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8637 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8639 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8641 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8643 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8645 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8647 GLYPH_CODE_FACE returns EMACS_INT, not int.
8648 * dispextern.h (merge_faces):
8649 * xfaces.c (merge_faces):
8650 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8651 Don't assume EMACS_INT fits in int.
8653 * character.h (CHAR_VALID_P): Remove unused parameter.
8654 * fontset.c, lisp.h, xdisp.c: All uses changed.
8656 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8658 * fns.c (concat): Minor tuning based on overflow analysis.
8659 This doesn't fix any bugs. Use int to hold character, instead
8660 of constantly refetching from Emacs object. Use XFASTINT, not
8661 XINT, for value known to be a character. Don't bother comparing
8662 a single byte to 0400, as it's always less.
8664 * floatfns.c (Fexpt):
8665 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8667 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8670 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8672 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8673 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8674 incorrectly succeed when S was a string, because 4294967386 was
8675 truncated before it was used.
8677 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8678 Otherwise, an out-of-range integer could cause undefined behavior
8681 * composite.c: Use int, not EMACS_INT, for characters.
8682 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8683 EMACS_INT, for values that are known to be in character range.
8684 This doesn't fix any bugs but is the usual style inside Emacs and
8685 may generate better code on 32-bit machines.
8687 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8688 This is for reasons similar to the recent CHAR_STRING fix.
8689 * charset.c (Fencode_char): Check that character arg is actually
8690 a character. Pass an int to ENCODE_CHAR.
8691 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8692 wider than 'int', as a compile-time check to prevent future regressions
8695 * character.c (char_string): Remove unnecessary casts.
8697 Make sure a 64-bit char is never passed to CHAR_STRING.
8698 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8699 by silently ignoring the top 32 bits, allowing some values
8700 that were far too large to be valid characters.
8701 * character.h: Include <verify.h>.
8702 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8703 arguments are no wider than unsigned, as a compile-time check
8704 to prevent future regressions in this area.
8706 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8707 (Fsubst_char_in_region):
8709 * xdisp.c (decode_mode_spec_coding):
8710 Adjust to CHAR_STRING's new requirement.
8711 * editfns.c (Finsert_char, Fsubst_char_in_region):
8712 * fns.c (concat): Check that character args are actually
8713 characters. Without this test, these functions did the wrong
8714 thing with wildly out-of-range values on 64-bit hosts.
8716 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8717 These casts should not be needed on 32-bit hosts, either.
8718 * keyboard.c (read_char):
8719 * lread.c (Fload): Remove casts to unsigned.
8721 * lisp.h (UNSIGNED_CMP): New macro.
8722 This fixes comparison bugs on 64-bit hosts.
8723 (ASCII_CHAR_P): Use it.
8724 * casefiddle.c (casify_object):
8725 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8726 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8727 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8728 * dispextern.h (FACE_FROM_ID):
8729 * keyboard.c (read_char): Use UNSIGNED_CMP.
8731 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8732 not to EMACS_INT, to avoid GCC warning.
8734 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8736 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8737 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8738 isn't needed on 32-bit machines.
8740 * buffer.c (Fgenerate_new_buffer_name):
8741 Use EMACS_INT for count, not int.
8742 (advance_to_char_boundary): Return EMACS_INT, not int.
8744 * data.c (Qcompiled_function): Now static.
8746 * window.c (window_body_lines): Now static.
8748 * image.c (gif_load): Rename local to avoid shadowing.
8750 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8751 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8752 * alloc.c (make_save_value): Integer argument is now of type
8754 (mark_object): Use ptrdiff_t, not int.
8755 * lisp.h (pD): New macro.
8756 * print.c (print_object): Use it.
8758 * alloc.c: Use EMACS_INT, not int, to count objects.
8759 (total_conses, total_markers, total_symbols, total_vector_size)
8760 (total_free_conses, total_free_markers, total_free_symbols)
8761 (total_free_floats, total_floats, total_free_intervals)
8762 (total_intervals, total_strings, total_free_strings):
8763 Now EMACS_INT, not int. All uses changed.
8764 (Fgarbage_collect): Compute overall total using a double, so that
8765 integer overflow is less likely to be a problem. Check for overflow
8766 when converting back to an integer.
8767 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8768 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8769 These were 'int' variables that could overflow on 64-bit hosts;
8770 they were never used, so remove them instead of repairing them.
8771 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8772 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8773 Previously, this ceilinged at INT_MAX, but that doesn't work on
8775 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8777 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8778 (allocate_vectorlike): Check for ptrdiff_t overflow.
8779 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8780 when a (possibly-narrower) signed value would do just as well.
8781 We prefer using signed arithmetic, to avoid comparison confusion.
8783 * alloc.c: Catch some string size overflows that we were missing.
8784 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8785 for convenience in STRING_BYTES_MAX.
8786 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8787 The definition here is exact; the one in lisp.h was approximate.
8788 (allocate_string_data): Check for string overflow. This catches
8789 some instances we weren't catching before. Also, it catches
8790 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8791 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8792 and ptrdiff_t and EMACS_INT are both 64 bits.
8794 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8795 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8796 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8798 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8800 * alloc.c (Fmake_string): Check for out-of-range init.
8802 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8804 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8806 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8808 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8809 xg_get_default_scrollbar_width.
8811 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8812 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8813 (style_changed_cb): Call update_theme_scrollbar_width and call
8814 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8815 all frames (Bug#8505).
8816 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8817 Call gtk_window_set_resizable if HAVE_GTK3.
8818 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8819 and height if HAVE_GTK3 (Bug#8505).
8820 (scroll_bar_width_for_theme): New variable.
8821 (update_theme_scrollbar_width): New function.
8822 (xg_get_default_scrollbar_width): Move code to
8823 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8824 (xg_initialize): Call update_theme_scrollbar_width.
8826 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8828 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8830 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8832 * frame.c (make_frame): Call other_buffer_safely instead of
8835 * window.c (temp_output_buffer_show): Call display_buffer with
8836 second argument Vtemp_buffer_show_specifiers and reset latter
8837 immediately after the call.
8838 (Vtemp_buffer_show_specifiers): New variable.
8839 (auto_window_vscroll_p, next_screen_context_lines)
8840 (Vscroll_preserve_screen_position): Remove leading asterisks from
8843 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8845 Fix minor problems found by GCC 4.6.0 static checking.
8846 * buffer.c (Qclone_number): Remove for now, as it's unused.
8847 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8848 (record_buffer): Remove unused local.
8849 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8850 (set_frame_buffer_list): Remove; unused.
8851 * frame.h (other_visible_frames): Remove decl.
8852 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8853 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8854 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8856 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8857 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8858 Define only if HAVE_GPM.
8859 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8860 (update_hints_inhibit): Remove; never set. All uses removed.
8861 * widgetprv.h (emacsFrameClassRec): Remove decl.
8862 * window.c (delete_deletable_window): Now returns void, since it
8863 wasn't returning anything.
8864 (compare_window_configurations): Remove unused locals.
8865 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8866 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8867 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8868 the same widths as pointers. This follows up on the 2011-05-06 patch.
8869 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8870 * xterm.h: Likewise.
8871 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8873 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8875 * makefile.w32-in: Update dependencies.
8876 (LISP_H): Add lib/intprops.h.
8878 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8880 * image.c (gif_load): Add animation frame delay to the metadata.
8881 (syms_of_image): Use DEFSYM. New symbol `delay'.
8883 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8885 * window.c (delete_deletable_window): Re-add.
8886 (Fset_window_configuration): Rewrite to handle dead buffers and
8887 consequently deletable windows.
8888 (window_tree, Fwindow_tree): Remove. Supply functionality in
8890 (compare_window_configurations): Simplify code.
8892 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8894 * image.c (imagemagick_load_image): Fix type mismatch.
8895 (Fimagemagick_types): Likewise.
8897 * window.h (replace_buffer_in_windows): Declare.
8899 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8901 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8902 Qclone_number. Remove external declaration of Qdelete_window.
8903 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8905 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8906 Run Qbuffer_list_update_hook if allowed.
8907 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8908 buffer list implementation.
8909 (other_buffer_safely): New function.
8910 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8911 calls to replace_buffer_in_windows and
8912 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8914 (record_buffer): Inhibit quitting and rewrite using quittable
8915 functions. Run Qbuffer_list_update_hook if allowed.
8916 (Frecord_buffer, Funrecord_buffer): New functions.
8917 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8918 Move switch-to-buffer to window.el.
8919 (bury-buffer): Move to window.el.
8920 (Vbuffer_list_update_hook): New variable.
8922 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8925 * window.h (resize_frame_windows): Move up in code.
8926 (Fwindow_frame): Remove EXFUN.
8927 (replace_buffer_in_all_windows): Remove prototype.
8928 (replace_buffer_in_windows_safely): Add prototype.
8930 * window.c: Declare Qdelete_window static again. Move down
8931 declaration of select_count.
8932 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8933 (Fother_window): Move to window.el.
8934 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8935 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8936 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8938 (replace_buffer_in_windows): Implement by calling
8939 Qreplace_buffer_in_windows.
8940 (replace_buffer_in_all_windows): Remove with some functionality
8941 moved into replace_buffer_in_windows_safely.
8942 (replace_buffer_in_windows_safely): New function.
8943 (select_window_norecord, select_frame_norecord): Move in front
8944 of run_window_configuration_change_hook. Remove now obsolete
8946 (Fset_window_buffer): Rewrite doc-string.
8947 Call Qrecord_window_buffer.
8948 (keys_of_window): Move binding for other-window to window.el.
8950 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8952 * dispextern.h (struct image): Replace data member, whose int_val
8953 and ptr_val fields were not used by anything, with a single
8956 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8957 (gif_clear_image, gif_load, imagemagick_load_image)
8958 (gs_clear_image, gs_load): Callers changed.
8960 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8962 * buffer.h: Include <time.h>, for time_t.
8963 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8965 Fix minor problems found by static checking.
8967 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8969 Make identifiers static if they are not used in other modules.
8970 * data.c (Qcompiled_function, Qframe, Qvector):
8971 * image.c (QimageMagick, Qsvg):
8972 * minibuf.c (Qmetadata):
8973 * window.c (resize_window_check, resize_root_window): Now static.
8974 * window.h (resize_window_check, resize_root_window): Remove decls.
8976 * window.c (window_deletion_count, delete_deletable_window):
8978 (window_body_lines): Now static.
8979 (Fdelete_other_windows_internal): Mark vars as initialized.
8980 Make sure 'resize_failed' is initialized.
8981 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8982 (resize_window_apply): Remove unused local.
8983 * window.h (delete_deletable_window): Remove decl.
8985 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8986 (imagemagick_load_image): Fix pointer signedness problem by changing
8987 last arg from unsigned char * to char *. All uses changed.
8988 Also, fix a local for similar reasons.
8989 Remove unused locals. Remove locals to avoid shadowing.
8990 (fn_rsvg_handle_free): Remove; unused.
8991 (svg_load, svg_load_image): Fix pointer signedness problem.
8992 (imagemagick_load_image): Don't use garbage pointer image_wand.
8994 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8996 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8998 * image.c (gif_load): Fix omitted cast error introduced by
9001 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9003 * window.h (resize_proportionally, orig_total_lines)
9004 (orig_top_line): Remove from window structure.
9005 (set_window_height, set_window_width, change_window_heights)
9006 (Fdelete_window): Remove prototypes.
9007 (resize_frame_windows): Remove duplicate declaration.
9009 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9011 * window.h (resize_frame_windows, resize_window_check)
9012 (delete_deletable_window, resize_root_window)
9013 (resize_frame_windows): Declare prototypes.
9015 * window.c (resize_window_apply): Make definition be "static" to
9016 match the prototype.
9018 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9020 * window.c: Remove declarations of Qwindow_size_fixed,
9021 window_min_size_1, window_min_size_2, window_min_size,
9022 size_window, window_fixed_size_p, enlarge_window, delete_window.
9023 Remove static from declaration of Qdelete_window, it's
9024 temporarily needed by Fbury_buffer.
9025 (replace_window): Don't assign orig_top_line and
9027 (Fdelete_window, delete_window): Remove. Window deletion is
9028 handled by window.el.
9029 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9030 Replace Fdelete_window calls with calls to Qdelete_window.
9031 (Fdelete_other_windows): Remove. Deleting other windows is
9032 handled by window.el.
9033 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9034 handled in window.el.
9035 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9036 Window minimum sizes are handled in window.el.
9037 (shrink_windows, size_window, set_window_height)
9038 (set_window_width, change_window_heights, window_height)
9039 (window_width, CURBEG, CURSIZE, enlarge_window)
9040 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9041 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9042 handled in window.el.
9043 (make_dummy_parent): Rename to make_parent_window and give it a
9044 second argument horflag.
9045 (make_window): Don't set resize_proportionally any more.
9046 (Fsplit_window): Remove. Windows are split in window.el.
9047 (save_restore_action, save_restore_orig_size)
9048 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9049 Resize mini windows in window.el.
9050 (grow_mini_window, shrink_mini_window): Implement by calling
9051 Qresize_root_window_vertically, resize_window_check and
9052 resize_window_apply.
9053 (saved_window, Fset_window_configuration, save_window_save):
9054 Do not handle orig_top_line, orig_total_lines, and
9055 resize_proportionally.
9056 (window_min_height, window_min_width): Move to window.el.
9057 (keys_of_window): Move bindings for delete-other-windows,
9058 split-window, delete-window and enlarge-window to window.el.
9060 * buffer.c: Temporarily extern Qdelete_window.
9061 (Fbury_buffer): Temporarily call Qdelete_window instead of
9062 Fdelete_window (Fbury_buffer will move to window.el soon).
9064 * frame.c (set_menu_bar_lines_1): Remove code handling
9065 orig_top_line and orig_total_lines.
9067 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9068 set_window_height but set heights directly.
9069 (change_frame_size_1): Use resize_frame_windows.
9071 * xdisp.c (init_xdisp): Don't use set_window_height but set
9074 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9075 Use resize_frame_windows instead of change_window_heights and run
9076 run_window_configuration_change_hook.
9078 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9079 instead of change_window_heights and run
9080 run_window_configuration_change_hook.
9082 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9084 * window.c (replace_window): Rename second argument REPLACEMENT to
9085 NEW. New third argument SETFLAG. Rewrite.
9086 (delete_window, make_dummy_parent): Call replace_window with
9088 (window_list_1): Move down in code.
9089 (run_window_configuration_change_hook): Move set_buffer part
9090 before select_frame_norecord part in order to unwind correctly.
9091 Rename count1 to count.
9092 (recombine_windows, delete_deletable_window, resize_root_window)
9093 (Fdelete_other_windows_internal)
9094 (Frun_window_configuration_change_hook, make_parent_window)
9095 (resize_window_check, resize_window_apply, Fresize_window_apply)
9096 (resize_frame_windows, Fsplit_window_internal)
9097 (Fdelete_window_internal, Fresize_mini_window_internal):
9099 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9101 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9103 * window.h (window): Add some new members to window structure -
9104 normal_lines, normal_cols, new_total, new_normal, clone_number,
9105 splits, nest, prev_buffers, next_buffers.
9106 (WINDOW_TOTAL_SIZE): Move here from window.c.
9107 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9109 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9111 (make_dummy_parent): Set new members of windows structure.
9112 (make_window): Move down in code. Handle new members of window
9114 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9115 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9116 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9117 (Fset_window_prev_buffers, Fwindow_next_buffers)
9118 (Fset_window_next_buffers, Fset_window_clone_number):
9120 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9121 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9123 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9124 Argument WINDOW can be now internal window too.
9125 (Fwindow_use_time): Move up in code.
9126 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9128 (Fset_window_configuration, saved_window)
9129 (Fcurrent_window_configuration, save_window_save): Handle new
9130 members of window structure.
9131 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9132 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9133 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9134 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9135 Qget_mru_window, Qresize_root_window,
9136 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9137 Qauto_buffer_name; staticpro them.
9139 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9141 * window.c (Fwindow_total_size, Fwindow_left_column)
9142 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9143 (Fwindow_list_1): New functions.
9144 (window_box_text_cols): Replace with window_body_cols.
9145 (Fwindow_width, Fscroll_left, Fscroll_right):
9146 Use window_body_cols instead of window_box_text_cols.
9147 (delete_window, Fset_window_configuration):
9148 Call delete_all_subwindows with window as argument.
9149 (delete_all_subwindows): Take a window as argument and not a
9151 (window_loop): Remove handling of GET_LRU_WINDOW and
9153 (Fget_lru_window, Fget_largest_window): Move to window.el.
9155 * window.h: Extern window_body_cols instead of
9156 window_box_text_cols. delete_all_subwindows now takes a
9157 Lisp_Object as argument.
9159 * indent.c (compute_motion, Fcompute_motion):
9160 Use window_body_cols instead of window_box_text_cols.
9162 * frame.c (delete_frame): Call delete_all_subwindows with root
9165 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9167 * fns.c (Fputhash): Document return value.
9169 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9171 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9173 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9175 Cons<->int and similar integer overflow fixes (Bug#8794).
9177 Check for overflow when converting integer to cons and back.
9178 * charset.c (Fdefine_charset_internal, Fdecode_char):
9179 Use cons_to_unsigned to catch overflow.
9180 (Fencode_char): Use INTEGER_TO_CONS.
9181 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9182 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9183 * data.c (long_to_cons, cons_to_long): Remove.
9184 (cons_to_unsigned, cons_to_signed): New functions.
9185 These signal an error for invalid or out-of-range values.
9186 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9187 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9188 * font.c (Ffont_variation_glyphs):
9189 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9190 * lisp.h: Include <intprops.h>.
9191 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9192 (cons_to_signed, cons_to_unsigned): New decls.
9193 (long_to_cons, cons_to_long): Remove decls.
9194 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9195 (Fprimitive_undo): Use CONS_TO_INTEGER.
9196 * xfns.c (Fx_window_property): Likewise.
9197 * xselect.c: Include <limits.h>.
9198 (x_own_selection, selection_data_to_lisp_data):
9199 Use INTEGER_TO_CONS.
9200 (x_handle_selection_request, x_handle_selection_clear)
9201 (x_get_foreign_selection, Fx_disown_selection_internal)
9202 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9203 (lisp_data_to_selection_data): Use cons_to_unsigned.
9204 (x_fill_property_data): Use cons_to_signed.
9205 Report values out of range.
9207 Check for buffer and string overflow more precisely.
9208 * buffer.h (BUF_BYTES_MAX): New macro.
9209 * lisp.h (STRING_BYTES_MAX): New macro.
9210 * alloc.c (Fmake_string):
9211 * character.c (string_escape_byte8):
9212 * coding.c (coding_alloc_by_realloc):
9213 * doprnt.c (doprnt):
9214 * editfns.c (Fformat):
9216 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9217 since they may not be the same number.
9218 * editfns.c (Finsert_char):
9219 * fileio.c (Finsert_file_contents):
9220 Likewise for BUF_BYTES_MAX.
9222 * image.c: Use ptrdiff_t, not int, for sizes.
9223 (slurp_file): Switch from int to ptrdiff_t.
9225 (slurp_file): Check that file size fits in both size_t (for
9226 malloc) and ptrdiff_t (for sanity and safety).
9228 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9229 if b->modtime has its maximal value.
9231 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9233 Don't assume time_t can fit into int.
9234 * buffer.h (struct buffer.modtime): Now time_t, not int.
9235 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9236 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9238 Minor fixes for signed vs unsigned integers.
9239 * character.h (MAYBE_UNIFY_CHAR):
9240 * charset.c (maybe_unify_char):
9241 * keyboard.c (read_char, reorder_modifiers):
9242 XINT -> XFASTINT, since the integer must be nonnegative.
9243 * ftfont.c (ftfont_spec_pattern):
9244 * keymap.c (access_keymap, silly_event_symbol_error):
9245 XUINT -> XFASTINT, since the integer must be nonnegative.
9246 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9247 since it makes no difference and we prefer signed.
9248 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9249 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9252 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9254 * window.h (Fwindow_frame): Declare.
9256 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9258 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9259 (SPARE_MEMORY): Always define.
9260 (LARGE_REQUEST): Remove.
9261 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9263 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9265 * lisp.h: Move EXFUNS for Fframe_root_window,
9266 Fframe_first_window and Fset_frame_selected_window to window.h.
9268 * window.h: Move EXFUNS for Fframe_root_window,
9269 Fframe_first_window and Fset_frame_selected_window here from
9272 * frame.c (Fwindow_frame, Fframe_first_window)
9273 (Fframe_root_window, Fframe_selected_window)
9274 (Fset_frame_selected_window): Move to window.c.
9275 (Factive_minibuffer_window): Move to minibuf.c.
9276 (Fother_visible_frames_p): New function.
9278 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9280 * window.c (decode_window, decode_any_window): Move up in code.
9281 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9282 (inhibit_frame_unsplittable): Remove unused variable.
9283 (Fwindow_buffer): Move up and rewrite doc-string.
9284 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9285 (Fwindow_prev): New functions.
9286 (Fwindow_frame): Move here from frame.c. Accept any window as
9288 (Fframe_root_window, Fframe_first_window)
9289 (Fframe_selected_window): Move here from frame.c. Accept frame
9290 or arbitrary window as argument. Update doc-strings.
9291 (Fminibuffer_window): Move up in code.
9292 (Fwindow_minibuffer_p): Move up in code and simplify.
9293 (Fset_frame_selected_window): Move here from frame.c.
9295 (Fselected_window, select_window, Fselect_window): Move up in
9296 code. Minor doc-string fixes.
9298 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9300 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9301 Do not assume that spare memory exists; that assumption is valid
9302 only if SYSTEM_MALLOC.
9303 (LARGE_REQUEST): New macro, so that the issue of large requests
9304 is separated from the issue of spare memory.
9306 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9308 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9311 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9313 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9316 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9318 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9320 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9322 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9323 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9325 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9327 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9329 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9331 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9332 (x_clipboard_manager_save): Add return value.
9333 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9335 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9336 Obey Vx_select_enable_clipboard_manager. Catch errors in
9337 x_clipboard_manager_save (Bug#8779).
9338 (Vx_select_enable_clipboard_manager): New variable.
9339 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9341 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9343 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9345 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9347 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9348 in the current matrix if keep_current_p is non-zero.
9350 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9352 * bidi.c (bidi_level_of_next_char): Fix last change.
9354 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9356 Support bidi reordering of text covered by display properties.
9358 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9359 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9360 (bidi_cache_search, bidi_cache_iterator_state)
9361 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9362 (bidi_level_of_next_char, bidi_move_to_visually_next):
9363 Support character positions inside a run of characters covered by a
9365 (bidi_paragraph_init, bidi_resolve_explicit_1)
9366 (bidi_level_of_next_char): Call bidi_fetch_char and
9367 bidi_fetch_char_advance instead of FETCH_CHAR and
9369 (bidi_init_it): Initialize new members.
9370 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9372 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9373 instead of using explicit *_CHAR codes.
9374 (bidi_resolve_explicit, bidi_resolve_weak):
9375 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9376 bidirectional text is supported only in multibyte buffers.
9377 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9378 it to initialize the frame_window_p member of struct bidi_it.
9379 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9380 (bidi_resolve_explicit, bidi_resolve_weak)
9381 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9382 bidi_it->nchars is non-positive.
9383 (bidi_level_of_next_char): Don't try to lookup the cache for the
9384 next/previous character if nothing is cached there yet, or if we
9385 were just reseat()'ed to a new position.
9387 * xdisp.c (set_cursor_from_row): Set start and stop points
9388 according to the row's direction when priming the loop that looks
9389 for the glyph on which to display cursor.
9390 (single_display_spec_intangible_p): Function deleted.
9391 (display_prop_intangible_p): Reimplement to call
9392 handle_display_spec instead of single_display_spec_intangible_p.
9393 Accept 3 additional arguments needed by handle_display_spec.
9394 This fixes incorrect cursor motion across display property with complex
9395 values: lists, `(when COND...)' forms, etc.
9396 (single_display_spec_string_p): Support property values that are
9397 lists with the argument STRING its top-level element.
9398 (display_prop_string_p): Fix the condition for processing a
9399 property that is a list to be consistent with handle_display_spec.
9400 (handle_display_spec): New function, refactored from the
9401 last portion of handle_display_prop.
9402 (compute_display_string_pos): Accept additional argument
9403 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9404 value of a `display' property is a "replacing spec".
9405 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9406 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9407 the display property, but just return a value indicating whether
9408 the display property will replace the characters it covers.
9409 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9410 frame_window_p members of struct bidi_it.
9411 (compute_display_string_pos, compute_display_string_end):
9413 (push_it): Accept second argument POSITION, where pop_it should
9414 jump to continue iteration.
9415 (reseat_1): Initialize bidi_it.disp_pos.
9417 * keyboard.c (adjust_point_for_property): Adjust the call to
9418 display_prop_intangible_p to its new signature.
9420 * dispextern.h (struct bidi_it): New member frame_window_p.
9421 (bidi_init_it): Update prototypes.
9422 (display_prop_intangible_p): Update prototype.
9423 (compute_display_string_pos, compute_display_string_end):
9425 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9428 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9430 Malloc failure behavior now depends on size of allocation.
9431 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9432 * lisp.h: Change signatures accordingly.
9433 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9434 All callers changed. (Bug#8762)
9436 * gnutls.c: Use Emacs's memory allocators.
9437 Without this change, the gnutls library would invoke malloc etc.
9438 directly, which causes problems on non-SYNC_INPUT hosts, and which
9439 runs afoul of improving memory_full behavior. (Bug#8761)
9440 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9441 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9442 xfree instead of the default malloc, realloc, free.
9443 (Fgnutls_boot): No need to check for memory allocation failure,
9444 since xmalloc does that for us.
9446 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9447 * category.c (hash_get_category_set):
9448 * ccl.c (ccl_driver):
9449 * charset.c (Fdefine_charset_internal):
9450 * charset.h (struct charset.hash_index):
9451 * composite.c (get_composition_id, gstring_lookup_cache)
9452 (composition_gstring_put_cache):
9453 * composite.h (struct composition.hash_index):
9454 * dispextern.h (struct image.hash):
9455 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9456 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9457 (hashfn_equal, hashfn_user_defined, make_hash_table)
9458 (maybe_resize_hash_table, hash_lookup, hash_put)
9459 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9460 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9461 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9462 * image.c (make_image, search_image_cache, lookup_image)
9463 (xpm_put_color_table_h):
9464 * lisp.h (struct Lisp_Hash_Table):
9465 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9466 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9467 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9468 * alloc.c (allocate_vectorlike):
9469 Check for overflow in vector size calculations.
9470 * ccl.c (ccl_driver):
9471 Check for overflow when converting EMACS_INT to int.
9472 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9473 need to be updated by these changes.
9474 * fns.c (make_hash_table, maybe_resize_hash_table):
9475 Check for integer overflow with large hash tables.
9476 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9477 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9478 (SXHASH_REDUCE): New macro.
9479 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9480 Use it instead of discarding useful hash info with large hash values.
9481 (sxhash_float): New function.
9482 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9483 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9484 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9485 Rewrite to use FIXNUM_BITS, as this simplifies things.
9486 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9487 Adjust signatures to match updated version of code.
9488 (consing_since_gc): Now EMACS_INT, since a single hash table can
9489 use more than INT_MAX bytes.
9491 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9493 Make it possible to build with GCC-4.6+ -O2 -flto.
9495 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9497 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9499 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9500 Call minibuffer-inactive-mode.
9502 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9504 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9505 Update dependencies.
9507 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9509 * data.c (init_data): Remove code for UTS, this system is not
9512 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9514 Don't force ./temacs to start in terminal mode.
9516 * frame.c (make_initial_frame): Initialize faces in all cases, not
9517 only when CANNOT_DUMP is defined.
9518 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9520 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9522 * dispnew.c (add_window_display_history): Use const for the string
9523 pointer. Remove declaration, not needed.
9525 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9527 Use 'inline', not 'INLINE'.
9528 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9529 * alloc.c, fontset.c (INLINE): Remove.
9530 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9531 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9532 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9533 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9534 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9536 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9538 Make it possible to run ./temacs.
9540 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9541 syms_of_callproc does the same thing. Remove test for
9542 "initialized", do it in the caller.
9543 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9545 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9547 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9548 (read_minibuf): Use get_minibuffer.
9549 (syms_of_minibuf): Use DEFSYM.
9550 (Qmetadata): New var.
9551 * data.c (Qbuffer): Don't make it static.
9552 (syms_of_data): Use DEFSYM.
9554 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9556 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9557 (CCL_CODE_MIN): New macro.
9559 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9561 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9563 * eval.c (Qdebug): Now static.
9564 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9565 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9566 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9568 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9570 * image.c: Various fixes to ImageMagick code comments.
9571 (Fimagemagick_types): Doc fix.
9573 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9575 Minor fixes prompted by GCC 4.6.0 warnings.
9577 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9579 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9580 (x_clipboard_manager_save_all): Move extern decl to ...
9581 * xterm.h: ... here, so that it can be checked for consistency.
9583 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9585 * xselect.c (x_clipboard_manager_save_frame)
9586 (x_clipboard_manager_save_all): New functions.
9587 (Fx_clipboard_manager_save): Lisp function deleted.
9589 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9590 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9592 * xterm.h: Update prototype.
9594 2011-05-28 William Xu <william.xwl@gmail.com>
9596 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9599 2011-05-28 Jim Meyering <meyering@redhat.com>
9601 Avoid a sign-extension bug in crypto_hash_function.
9602 * fns.c (to_uchar): Define.
9603 (crypto_hash_function): Use it to convert some newly-signed
9604 variables to unsigned, to avoid sign-extension bugs. For example,
9605 without this change, (md5 "truc") would evaluate to
9606 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9607 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9608 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9610 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9612 Integer overflow fixes.
9614 * dbusbind.c: Serial number integer overflow fixes.
9615 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9616 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9617 to hold a serial number that is too large for a fixnum.
9618 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9619 Check for serial numbers out of range. Decode any serial number
9620 that was so large that it became a float. (Bug#8722)
9622 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9623 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9624 Use XFASTINT rather than XUINT when numbers are nonnegative.
9625 (xd_append_arg, Fdbus_method_return_internal):
9626 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9627 arguments, check that Lisp number is nonnegative, rather than
9628 silently wrapping negative numbers around. (Bug#8722)
9629 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9632 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9634 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9636 ccl: Add integer overflow checks.
9637 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9638 (IN_INT_RANGE): New macros.
9639 (ccl_driver): Use them to check for integer overflow when
9640 decoding a CCL program. Many of the new checks are whether XINT (x)
9641 fits in int; it doesn't always, on 64-bit hosts. The new version
9642 doesn't catch all possible integer overflows, but it's an
9643 improvement. (Bug#8719)
9645 * alloc.c (make_event_array): Use XINT, not XUINT.
9646 There's no need for unsigned here.
9648 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9649 This follows up to the 2011-05-06 change that substituted uintptr_t
9650 for EMACS_INT. This case wasn't caught back then.
9652 Rework Fformat to avoid integer overflow issues.
9653 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9654 now (part of C89). Include <verify.h>.
9655 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9656 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9657 (Fformat): Avoid the prepass trying to compute sizes; it was only
9658 approximate and thus did not catch overflow reliably. Instead, walk
9659 through the format just once, formatting and computing sizes as we go,
9660 checking for integer overflow at every step, and allocating a larger
9661 buffer as needed. Keep track separately whether the format is
9662 multibyte. Keep only the most-recently calculated precision, rather
9663 than them all. Record whether each argument has been converted to
9664 string. Use EMACS_INT, not int, for byte and char and arg counts.
9665 Support field widths and precisions larger than INT_MAX. Avoid
9666 sprintf's undefined behavior with conversion specifications such as %#d
9667 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9668 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9669 formatting out-of-range floating point numbers with int
9672 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9674 * data.c: Avoid integer truncation in expressions involving floats.
9675 * data.c: Include <intprops.h>.
9676 (arith_driver): When there's an integer overflow in an expression
9677 involving floating point, convert the integers to floating point
9678 so that the resulting value does not suffer from catastrophic
9679 integer truncation. For example, on a 64-bit host (* 4
9680 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9681 Do not rely on undefined behavior after integer overflow.
9683 merge count_size_as_multibyte, parse_str_to_multibyte
9684 * character.c, character.h (count_size_as_multibyte):
9685 Rename from parse_str_to_multibyte; all uses changed.
9686 Check for integer overflow.
9687 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9688 since it's now a duplicate of the other. This is more of
9689 a character than a buffer op, so better that it's in character.c.
9690 * fns.c, print.c: Adjust to above changes.
9692 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9694 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9696 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9698 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9699 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9700 (x_clipboard_manager_save): Now static.
9701 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9703 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9704 (crypto_hash_function): Now static.
9705 Fix pointer signedness problems. Avoid unnecessary initializations.
9707 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9709 * termhooks.h (Vselection_alist): Make it terminal-local.
9711 * terminal.c (create_terminal): Initialize it.
9713 * xselect.c: Support for clipboard managers.
9714 (Vselection_alist): Move to termhooks.h as terminal-local var.
9715 (LOCAL_SELECTION): New macro.
9716 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9717 (symbol_to_x_atom): Remove gratuitous arg.
9718 (x_handle_selection_request, lisp_data_to_selection_data)
9719 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9720 (x_own_selection, x_get_local_selection, x_convert_selection):
9721 New arg, specifying work frame. Use terminal-local Vselection_alist.
9722 (some_frame_on_display): Delete unused function.
9723 (Fx_own_selection_internal, Fx_get_selection_internal)
9724 (Fx_disown_selection_internal, Fx_selection_owner_p)
9725 (Fx_selection_exists_p): New optional frame arg.
9726 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9727 (x_handle_selection_clear): Don't treat other terminals with the
9728 same keyboard specially. Use the terminal-local Vselection_alist.
9729 (x_clear_frame_selections): Use Frun_hook_with_args.
9731 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9733 * xterm.h: Add support for those atoms.
9735 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9737 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9738 (converted_selections, conversion_fail_tag): New global variables.
9739 (x_selection_request_lisp_error): Free the above.
9740 (x_get_local_selection): Remove unnecessary code.
9741 (x_reply_selection_request): Args changed; handle arbitrary array
9742 of converted selections stored in converted_selections.
9743 Separate the XChangeProperty and SelectionNotify steps.
9744 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9745 (x_convert_selection): New function.
9746 (x_handle_selection_event): Simplify.
9747 (x_get_foreign_selection): Don't ignore incoming requests while
9748 waiting for an answer; this will fail when we implement
9749 SAVE_TARGETS, and seems unnecessary anyway.
9750 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9751 (Vx_sent_selection_functions): Doc fix.
9753 2011-05-26 Leo Liu <sdl.web@gmail.com>
9755 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9757 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9759 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9761 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9762 for fringe update if it has periodic bitmap.
9763 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9764 and fringe_bitmap_periodic_p.
9766 * fringe.c (get_fringe_bitmap_data): New function.
9767 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9768 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9769 row. Mark glyph row for fringe update if periodicity changed.
9771 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9772 for fringe update unless it has periodic bitmap.
9774 2011-05-25 Kenichi Handa <handa@m17n.org>
9776 * xdisp.c (get_next_display_element): Set correct it->face_id for
9777 a static composition.
9779 2011-05-24 Leo Liu <sdl.web@gmail.com>
9782 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9784 * fns.c (crypto_hash_function, Fsha1): New function.
9785 (Fmd5): Use crypto_hash_function.
9786 (syms_of_fns): Add Ssha1.
9788 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9790 * gnutls.c: Remove unused macros.
9791 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9792 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9793 Remove macros that are defined and never used.
9794 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9796 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9798 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9799 (Fx_get_selection_internal): Minor cleanup.
9800 (Fx_own_selection_internal): Rename arguments for consistency with
9803 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9805 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9807 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9809 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9811 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9813 * dispnew.c (scrolling_window): Don't exclude the case that the
9814 last enabled row in the desired matrix touches the bottom boundary.
9816 2011-05-21 Glenn Morris <rgm@gnu.org>
9818 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9819 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9820 and add some more files.
9822 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9824 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9825 report_file_error introduced by the change from 2011-05-07.
9827 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9829 * systime.h (Time): Define only if emacs is defined.
9830 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9831 where the include path doesn't have X11/X.h by default. See
9832 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9834 2011-05-20 Kenichi Handa <handa@m17n.org>
9836 * composite.c (find_automatic_composition): Fix previous change.
9838 2011-05-20 Glenn Morris <rgm@gnu.org>
9840 * lisp.mk: New file, split from Makefile.in.
9841 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9842 (shortlisp): Remove.
9843 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9845 2011-05-19 Glenn Morris <rgm@gnu.org>
9847 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9848 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9849 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9850 (lisp): Set the order to that of loadup.el.
9851 (shortlisp): Make it a copy of $lisp.
9852 (SOME_MACHINE_LISP): Remove.
9853 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9854 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9856 2011-05-18 Kenichi Handa <handa@m17n.org>
9858 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9859 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9860 (find_automatic_composition): Mostly rewrite for efficiency.
9862 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9864 * makefile.w32-in: Update dependencies.
9866 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9868 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9869 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9871 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9873 Fix some integer overflow issues, such as string length overflow.
9875 * insdel.c (count_size_as_multibyte): Check for string overflow.
9877 * character.c (lisp_string_width): Check for string overflow.
9878 Use EMACS_INT, not int, for string indexes and lengths; in
9879 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9880 the resulting string length overflows an EMACS_INT; instead,
9881 report a string overflow if no precision given. When checking for
9882 precision exhaustion, use a check that cannot possibly have
9883 integer overflow. (Bug#8675)
9884 * character.h (lisp_string_width): Adjust to new signature.
9886 * alloc.c (string_overflow): New function.
9887 (Fmake_string): Use it. This doesn't change behavior, but saves
9888 a few bytes and will simplify future changes.
9889 * character.c (string_escape_byte8): Likewise.
9890 * lisp.h (string_overflow): New decl.
9892 Fixups, following up to the user-interface timestamp change.
9893 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9894 for UI timestamps, instead of unsigned long.
9895 * msdos.c (mouse_get_pos): Likewise.
9896 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9897 * w32gui.h (Time): Define by including "systime.h" rather than by
9898 declaring it ourselves. (Bug#8664)
9900 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9901 * image.c (clear_image_cache): Likewise.
9903 * term.c (term_mouse_position): Don't assume time_t wraparound.
9905 Be more systematic about user-interface timestamps.
9906 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9907 and sometimes 'EMACS_UINT', to represent these timestamps.
9908 This change causes it to use 'Time' uniformly, as that's what X uses.
9909 This makes the code easier to follow, and makes it easier to catch
9910 integer overflow bugs such as Bug#8664.
9911 * frame.c (Fmouse_position, Fmouse_pixel_position):
9912 Use Time, not unsigned long, for user-interface timestamps.
9913 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9914 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9915 * keyboard.h (last_event_timestamp): Likewise.
9916 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9917 * menu.h (xmenu_show): Likewise.
9918 * term.c (term_mouse_position): Likewise.
9919 * termhooks.h (struct input_event.timestamp): Likewise.
9920 (struct terminal.mouse_position_hook): Likewise.
9921 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9922 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9923 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9924 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9926 * menu.h, termhooks.h: Include "systime.h", for Time.
9928 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9929 Don't assume that the difference between two unsigned long values
9930 can fit into an integer. At this point, we know button_down_time
9931 <= event->timestamp, so the difference must be nonnegative, so
9932 there's no need to cast the result if double-click-time is
9933 nonnegative, as it should be; check that it's nonnegative, just in
9934 case. This bug is triggered when events are more than 2**31 ms
9935 apart (about 25 days). (Bug#8664)
9937 * xselect.c (last_event_timestamp): Remove duplicate decl.
9938 (x_own_selection): Remove needless cast to unsigned long.
9940 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9941 that always fit in int. Use a sentinel instead of a counter, to
9942 avoid a temp and to allay GCC's concerns about possible int overflow.
9943 * frame.h (struct frame): Use int for menu_bar_items_used
9944 instead of EMACS_INT, since it always fits in int.
9946 * menu.c (grow_menu_items): Check for int overflow.
9948 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9950 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9951 Before, the code was not consistent. These values cannot exceed
9952 2**31 - 1 so there's no need to make them unsigned.
9953 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9954 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9955 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9957 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9959 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9960 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9961 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9962 presumably because the widths might not match.
9964 * window.c (size_window): Avoid needless test at loop start.
9966 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9968 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9970 2011-05-12 Drew Adams <drew.adams@oracle.com>
9972 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9974 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9976 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9977 `width' to `bar_area_x' and `bar_area_width', respectively.
9978 (x_scroll_run): Take account of fringe background extension.
9980 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9981 Rename local vars `left' and `width' to `bar_area_x' and
9982 `bar_area_width', respectively.
9983 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9984 background extension.
9986 2011-05-10 Jim Meyering <meyering@redhat.com>
9988 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9990 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9992 * image.c (Finit_image_library): Return t for built-in image types,
9993 like pbm and xbm. (Bug#8640)
9995 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9997 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9999 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10001 * w32console.c (Fset_screen_color): Doc fix.
10002 (Fget_screen_color): New function.
10003 (syms_of_ntterm): Defsubr it.
10005 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10006 unlink the temporary file if Fcall_process didn't create it in the
10008 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10009 child process will be redirected to a file specified with `:file'.
10010 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10011 cue to call_process_cleanup not to close that handle.
10013 2011-05-07 Ben Key <bkey76@gmail.com>
10015 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10016 one of two shell specific rules, either bootstrap-temacs-CMD or
10017 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10018 to the previous implementation of the bootstrap-temacs rule.
10019 The bootstrap-temacs-CMD rule is similar to the previous
10020 implementation of the bootstrap-temacs rule except that it
10021 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10024 These changes, along with some changes to nt/configure.bat,
10025 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10026 earlier fix to add support for --cflags and --ldflags options
10027 that include quotes so that it works whether make uses cmd or
10030 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10032 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10033 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10035 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10036 a string. Handle both cases.
10037 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10038 (Fdbus_register_method): Use Qinvalid_function.
10040 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10042 * makefile.w32-in: Update dependencies.
10043 (LISP_H): Add inttypes.h and stdin.h.
10044 (PROCESS_H): Add unistd.h.
10046 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10048 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10049 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10051 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10053 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10055 * term.c (vfatal): Remove stray call to va_end.
10056 It's not needed and the C Standard doesn't allow it here anyway.
10058 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10059 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10061 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10064 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10066 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10068 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10070 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10072 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10074 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10075 * charset.c (Fdefine_charset_internal): Don't initialize
10076 charset.code_space[15]. The value was garbage, on hosts with
10077 32-bit int (Bug#8600).
10079 * lread.c (read_integer): Be more consistent with string-to-number.
10080 Use string_to_number to do the actual conversion; this avoids
10081 rounding errors and fixes some other screwups. Without this fix,
10082 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10083 (digit_to_number): Move earlier, for benefit of read_integer.
10084 Return -1 if the digit is out of range for the base, -2 if it is
10085 not a digit in any supported base. (Bug#8602)
10087 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10089 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10090 to match comment at start of function. This also removes a
10091 GCC warning about overflow in a 32+64-bit port.
10093 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10095 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10096 Reported by Stefan Monnier in
10097 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10098 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10099 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10101 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10102 (EMACS_UINTPTR): Likewise, with uintptr_t.
10104 * lisp.h: Prefer 64-bit EMACS_INT if available.
10105 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10106 on 32-bit hosts that have 64-bit int, so that they can access
10108 However, temporarily disable this change unless the temporary
10109 symbol WIDE_EMACS_INT is defined.
10111 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10113 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10114 This removes an assumption that EMACS_INT and long are the same
10115 width as pointers. The assumption is true for Emacs porting targets
10116 now, but we want to make other targets possible.
10117 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10118 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10119 In the rest of the code, change types of integers that hold casted
10120 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10121 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10122 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10123 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10124 No need to cast type when ORing.
10125 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10126 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10127 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10128 assume EMACS_INT is the same width as char *.
10129 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10130 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10131 Remove no-longer-needed casts.
10132 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10133 (xg_tool_bar_help_callback, xg_make_tool_item):
10134 Use EMACS_INTPTR to hold an integer
10135 that will be cast to void *; this can avoid a GCC warning
10136 if EMACS_INT is not the same width as void *.
10137 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10138 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10139 (current_message_1, set_message_1):
10140 Use a local to convert to proper width without a cast.
10141 * xmenu.c (dialog_selection_callback): Likewise.
10143 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10144 Also, don't assume VALBITS / RAND_BITS is less than 5,
10145 and don't rely on undefined behavior when shifting a 1 left into
10147 * lisp.h (get_random): Change signature to match.
10149 * lread.c (hash_string): Use size_t, not int, for hash computation.
10150 Normally we prefer signed values; but hashing is special, because
10151 it's better to use unsigned division on hash table sizes so that
10152 the remainder is nonnegative. Also, size_t is the natural width
10153 for hashing into memory. The previous code used 'int', which doesn't
10154 retain enough info to hash well into very large tables.
10155 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10157 * dbusbind.c: Don't possibly lose pointer info when converting.
10158 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10159 Use XPNTR rather than XHASH, so that the high-order bits of
10160 the pointer aren't lost when converting through void *.
10162 * eval.c (Fautoload): Don't double-shift a pointer.
10164 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10166 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10168 * gnutls.c (DEF_GNUTLS_FN):
10169 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10171 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10173 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10176 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10178 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10179 New version that can reserve upto 2GB of heap space.
10181 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10183 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10185 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10187 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10188 `gnutls_certificate_set_x509_key_file'.
10190 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10192 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10193 Update dependencies.
10195 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10197 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10198 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10199 Remove unused parameter `fildes'.
10200 * process.c (read_process_output, send_process): Don't pass it.
10202 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10204 Fix previous change: the library cache is defined in w32.c.
10205 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10206 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10208 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10210 Implement dynamic loading of GnuTLS on Windows.
10212 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10213 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10214 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10217 * gnutls.c (Qgnutls_dll): Define.
10218 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10219 (gnutls_*): Declare function pointers.
10220 (init_gnutls_functions): New function to initialize function pointers.
10221 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10222 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10223 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10224 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10225 (emacs_gnutls_write, emacs_gnutls_read)
10226 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10227 (Fgnutls_available_p): New function.
10228 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10229 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10230 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10232 * image.c: Include w32.h.
10233 (Vimage_type_cache): Delete.
10234 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10235 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10236 (w32_delayed_load): Move to w32.c.
10238 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10240 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10241 (w32_delayed_load): Move from image.c. When loading a library, record
10242 its filename in the :loaded-from property of the library id.
10243 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10244 Initialize and staticpro them.
10245 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10247 * process.c: Include lisp.h before w32.h, not after.
10248 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10249 instead of gnutls_record_check_pending.
10251 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10253 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10255 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10256 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10259 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10261 * xterm.c (x_set_frame_alpha): Do not set property on anything
10262 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10264 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10266 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10268 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10270 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10271 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10272 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10273 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10274 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10275 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10276 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10277 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10278 (Qgnutls_bootprop_callbacks_verify): Make static.
10280 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10282 * callproc.c: Indentation fixup.
10284 * sysdep.c (wait_for_termination_1): Make static.
10285 (wait_for_termination, interruptible_wait_for_termination):
10286 Move after wait_for_termination_1.
10288 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10290 * sysdep.c (interruptible_wait_for_termination): New function
10291 which is like wait_for_termination, but allows keyboard
10294 * callproc.c (Fcall_process): Add (:file "file") as an option for
10296 (Fcall_process_region): Ditto.
10298 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10300 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10301 rather than `XVECTOR (FOO)->size'.
10303 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10304 inttypes.h, as a gnulib replacement is used if it not available in
10307 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10309 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10310 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10311 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10313 * coding.c (coding_alloc_by_realloc): Error out if destination
10314 will grow beyond MOST_POSITIVE_FIXNUM.
10315 (decode_coding_emacs_mule): Abort if there isn't enough place in
10316 charbuf for the composition carryover bytes. Reserve an extra
10317 space for up to 2 characters produced in a loop.
10318 (decode_coding_iso_2022): Abort if there isn't enough place in
10319 charbuf for the composition carryover bytes.
10321 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10323 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10324 aborting when %lld or %lll format is passed.
10325 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10326 %llo or %llx format is passed. (Bug#8545)
10328 * window.c (window_scroll_line_based): Use a marker instead of
10329 simple variables to record original value of point. (Bug#7952)
10331 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10332 produced by %s or %c overflows available buffer space. (Bug#8545)
10334 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10336 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10337 (SIZE_MAX): Move defn after all includes, as they might #define it.
10339 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10341 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10343 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10345 * keyboard.c (Qdelayed_warnings_hook): Define.
10346 (command_loop_1): Run `delayed-warnings-hook'
10347 if Vdelayed_warnings_list is non-nil.
10348 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10349 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10351 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10353 * doprnt.c (doprnt): Don't return value smaller than the buffer
10354 size if the message was truncated. (Bug#8545).
10356 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10358 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10359 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10361 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10363 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10365 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10367 * makefile.w32-in: Update dependencies.
10369 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10371 Improve `doprnt' and its usage. (Bug#8545)
10372 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10373 `format_end'. Remove support for %l as a conversion specifier.
10374 Don't use xrealloc. Improve diagnostics when the %l size modifier
10375 is used. Update the commentary.
10377 * eval.c (verror): Simplify calculation of size_t.
10379 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10382 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10384 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10387 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10389 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10390 This makes this file independent of the recent pseudovector change.
10392 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10394 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10396 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10397 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10398 Remove unused local.
10399 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10401 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10402 GCC 4.6.0 optimizes based on type-based alias analysis.
10403 For example, if b is of type struct buffer * and v of type struct
10404 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10405 != &v->size, and therefore "v->size = 1; b->size = 2; return
10406 v->size;" must therefore return 1. This assumption is incorrect
10407 for Emacs, since it type-puns struct Lisp_Vector * with many other
10408 types. To fix this problem, this patch adds a new type struct
10409 vectorlike_header that documents the constraints on layout of vectors
10410 and pseudovectors, and helps optimizing compilers not get fooled
10411 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10412 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10413 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10415 (XSETPVECTYPE): Rewrite in terms of new macro.
10416 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10417 This is a bit clearer, and further avoids the possibility of
10418 undesirable aliasing.
10419 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10420 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10421 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10422 since Lisp_Subr is a special case (no "next" field).
10423 (ASIZE): Now uses header.size rather than size.
10424 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10425 to avoid the hassle of writing XVECTOR (foo)->header.size.
10426 (struct vectorlike_header): New type.
10427 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10428 object, to help avoid aliasing.
10429 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10430 (SUBRP): Likewise, since Lisp_Subr is a special case.
10431 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10432 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10433 (struct Lisp_Hash_Table): Combine first two members into a single
10434 struct vectorlike_header member. All uses of "size" and "next" members
10435 changed to be "header.size" and "header.next".
10436 * buffer.h (struct buffer): Likewise.
10437 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10438 * frame.h (struct frame): Likewise.
10439 * process.h (struct Lisp_Process): Likewise.
10440 * termhooks.h (struct terminal): Likewise.
10441 * window.c (struct save_window_data, struct saved_window): Likewise.
10442 * window.h (struct window): Likewise.
10443 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10444 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10445 * buffer.c (init_buffer_once): Likewise.
10446 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10448 * process.c (Fformat_network_address): Use local var for size,
10451 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10453 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10454 * data.c (atof): Remove decl; no longer used or needed.
10455 (digit_to_number): Move to lread.c.
10456 (Fstring_to_number): Use new string_to_number function, to be
10457 consistent with how the Lisp reader treats infinities and NaNs.
10458 Do not assume that floating-point numbers represent EMACS_INT
10459 without losing information; this is not true on most 64-bit hosts.
10460 Avoid double-rounding errors, by insisting on integers when
10461 parsing non-base-10 numbers, as the documentation specifies.
10462 * lisp.h (string_to_number): New decl, replacing ...
10463 (isfloat_string): Remove.
10464 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10465 (read1): Do not accept +. and -. as integers; this
10466 appears to have been a coding error. Similarly, do not accept
10467 strings like +-1e0 as floating point numbers. Do not report
10468 overflow for integer overflows unless the base is not 10 which
10469 means we have no simple and reliable way to continue.
10470 Break out the floating-point parsing into a new
10471 function string_to_number, so that Fstring_to_number parses
10472 floating point numbers consistently with the Lisp reader.
10473 (digit_to_number): Move here from data.c. Make it static inline.
10474 (E_CHAR, EXP_INT): Remove, replacing with ...
10475 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10476 (string_to_number): New function, replacing isfloat_string.
10477 This function checks for valid syntax and produces the resulting
10478 Lisp float number too. Rework it so that string-to-number
10479 no longer mishandles examples like "1.0e+". Use strtoumax,
10480 so that overflow for non-base-10 numbers is reported only when
10481 there's no portable and simple way to convert to floating point.
10483 * textprop.c (set_text_properties_1): Rewrite for clarity,
10484 and to avoid GCC warning about integer overflow.
10486 * intervals.h (struct interval): Use EMACS_INT for members
10487 where EMACS_UINT might cause problems. See
10488 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10489 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10490 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10492 (offset_intervals): Tell GCC not to worry about length overflow
10493 when negating a negative length.
10495 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10496 (overrun_check_free): Likewise.
10498 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10499 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10502 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10503 (gnutls_make_error): Rename local to avoid shadowing.
10504 (gnutls_emacs_global_deinit): ifdef out; not used.
10505 (Fgnutls_boot): Use const for pointer to readonly storage.
10506 Comment out unused local. Fix pointer signedness problems.
10508 * lread.c (openp): Don't stuff size_t into an 'int'.
10509 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10510 about possible signed overflow.
10512 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10513 (GDK_KEY_g): Don't define if already defined.
10514 (xg_prepare_tooltip): Avoid pointer signedness problem.
10515 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10517 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10518 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10520 * xfns.c (Fx_window_property): Simplify a bit,
10521 to make a bit faster and to avoid GCC 4.6.0 warning.
10522 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10524 * fns.c (internal_equal): Don't assume size_t fits in int.
10526 * alloc.c (compact_small_strings): Tighten assertion a little.
10528 Replace pEd with more-general pI, and fix some printf arg casts.
10529 * lisp.h (pI): New macro, generalizing old pEd macro to other
10530 conversion specifiers. For example, use "...%"pI"d..." rather
10531 than "...%"pEd"...".
10532 (pEd): Remove. All uses replaced with similar uses of pI.
10533 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10534 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10535 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10536 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10537 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10538 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10539 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10541 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10542 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10543 * print.c (safe_debug_print, print_object): Likewise.
10544 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10546 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10547 avoiding the 0 flag, which is not portable.
10548 * process.c (Fmake_network_process): Use pI to avoid cast.
10549 * region-cache.c (pp_cache): Likewise.
10550 * xdisp.c (decode_mode_spec): Likewise.
10551 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10552 behavior on 64-bit hosts with printf arg.
10553 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10554 (x_stop_queuing_selection_requests): Likewise.
10555 (x_get_window_property): Don't truncate byte count to an 'int'
10558 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10559 here, since it parses constructs like leading '-' and spaces,
10560 which are not wanted; and it overflows with large numbers.
10561 Instead, simply match F[0-9]+, which is what is wanted anyway.
10563 * alloc.c: Remove unportable assumptions about struct layout.
10564 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10565 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10566 (allocate_vectorlike, make_pure_vector): Use the new macros,
10567 plus offsetof, to remove unportable assumptions about struct layout.
10568 These assumptions hold on all porting targets that I know of, but
10569 they are not guaranteed, they're easy to remove, and removing them
10570 makes further changes easier.
10572 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10573 This doesn't fix a bug but makes the code clearer.
10574 (string_overrun_cookie): Now const. Use initializers that
10575 don't formally overflow signed char, to avoid warnings.
10576 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10577 can cause Emacs to crash when string overrun checking is enabled.
10578 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10579 multiple of sizeof (EMACS_INT); it need not be, if
10580 alignof(EMACS_INT) < sizeof (EMACS_INT).
10581 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10583 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10585 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10587 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10589 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10590 supposed to be handshaking. (Bug#8556)
10591 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10593 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10595 * lisp.h (Qdebug): List symbol.
10596 * eval.c (Qdebug): Restore global linkage.
10597 * keyboard.c (debug-on-event): New variable.
10598 (handle_user_signal): Break into debugger when debug-on-event
10599 matches the current signal symbol.
10601 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10603 * alloc.c (check_sblock, check_string_bytes)
10604 (check_string_free_list): Convert to standard C.
10606 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10608 * w32.c (emacs_gnutls_push): Fix typo.
10610 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10612 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10613 "cast to pointer from integer of different size".
10615 Improve doprnt and its use in verror. (Bug#8545)
10616 * doprnt.c (doprnt): Document the set of format control sequences
10617 supported by the function. Use SAFE_ALLOCA instead of always
10620 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10621 is one byte too soon. Don't use xrealloc; instead xfree and
10624 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10626 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10629 * gnutls.c: Renamed global_initialized to
10630 gnutls_global_initialized. Added internals for the
10631 :verify-hostname-error, :verify-error, and :verify-flags
10632 parameters of `gnutls-boot' and documented those parameters in the
10633 docstring. Start callback support.
10634 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10635 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10636 on error. Return error code.
10637 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10638 (emacs_gnutls_read): Likewise.
10639 (Fgnutls_boot): Return handshake error code.
10640 (emacs_gnutls_handle_error): New function.
10641 (wsaerror_to_errno): Likewise.
10643 * w32.h (emacs_gnutls_pull): Add prototype.
10644 (emacs_gnutls_push): Likewise.
10646 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10647 (emacs_gnutls_push): Likewise.
10649 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10651 * process.c (wait_reading_process_output): Check if GnuTLS
10652 buffered some data internally if no FDs are set for TLS
10655 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10656 (LIBS): Link to USER_LIBS.
10657 ($(BLD)/gnutls.$(0)): New target.
10659 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10661 * xdisp.c (handle_single_display_spec): Rename the
10662 display_replaced_before_p argument into display_replaced_p, to
10663 make it consistent with the commentary. Fix typos in the
10666 * textprop.c (syms_of_textprop): Remove dead code.
10667 (copy_text_properties): Delete obsolete commentary about an
10668 interface that was deleted long ago. Fix typos in the description
10671 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10672 to changes in oldXMenu/XMenu.h from 2011-04-16.
10673 <menu_help_message, prev_menu_help_message>: Constify.
10674 (IT_menu_make_room): menu->help_text is now `const char **';
10677 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10678 to changes in oldXMenu/XMenu.h from 2011-04-16.
10679 (struct XMenu): Declare `help_text' `const char **'.
10681 * xfaces.c <Qunspecified>: Make extern again.
10683 * syntax.c: Include sys/types.h before including regex.h, as
10686 * doc.c (get_doc_string): Improve the format passed to `error'.
10688 * doprnt.c (doprnt): Improve commentary.
10690 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10692 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10695 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10696 changes in globals.h immediately force recompilation.
10697 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10698 $(CURDIR)/s/ms-w32.h.
10699 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10701 * character.c (Fchar_direction): Function deleted.
10702 (syms_of_character): Don't defsubr it.
10703 <char-direction-table>: Deleted.
10705 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10707 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10708 * doprnt.c: Include limits.h.
10709 (SIZE_MAX): New macro.
10710 (doprnt): Return a size_t value. 2nd arg is now size_t.
10711 Many local variables are now size_t instead of int or unsigned.
10712 Improve overflow protection. Support `l' modifier for integer
10713 conversions. Support %l conversion. Don't assume an EMACS_INT
10714 argument for integer conversions and for %c.
10716 * lisp.h (doprnt): Restore prototype.
10718 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10719 $(SRC)/character.h.
10721 * Makefile.in (base_obj): Add back doprnt.o.
10723 * deps.mk (doprnt.o): Add back prerequisites.
10724 (callint.o): Depend on character.h.
10726 * eval.c (internal_lisp_condition_case): Include the handler
10727 representation in the error message.
10728 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10729 when breaking from the loop.
10731 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10733 * callint.c (Fcall_interactively): When displaying error message
10734 about invalid control letter, pass the character's codepoint, not
10735 a pointer to its multibyte form. Improve display of the character
10736 in octal and display also its hex code.
10738 * character.c (char_string): Use %x to display the (unsigned)
10739 codepoint of an invalid character, to avoid displaying a bogus
10742 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10743 `error', not SYMBOL_NAME itself.
10745 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10746 character arguments to `error'.
10748 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10749 to `error' in error message about FINAL_CHAR argument. Make sure
10750 FINAL_CHAR is a character, and use %c when it is passed as
10751 argument to `error'.
10753 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10755 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10757 * w32.c: Include <time.h>.
10758 (sys_localtime): New function.
10760 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10762 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10764 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10766 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10768 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10769 zombies (Bug#8467).
10771 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10773 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10774 gl_state.e_property when gl_state.object is Qt.
10776 * insdel.c (make_gap_larger): Remove limitation of buffer size
10779 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10781 * xdisp.c (lookup_glyphless_char_display)
10782 (produce_glyphless_glyph): Handle cons cell entry in
10783 glyphless-char-display.
10784 (Vglyphless_char_display): Document it.
10786 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10787 glyphless-char-display.
10789 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10791 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10793 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10795 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10796 definition for no-X builds.
10798 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10800 Static checks with GCC 4.6.0 and non-default toolkits.
10802 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10804 * process.c (keyboard_bit_set): Define only if SIGIO.
10805 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10806 (send_process): Repair possible setjmp clobbering.
10808 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10810 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10812 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10814 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10815 Define only if needed.
10817 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10818 by pacifying GCC about it. Maybe it's time to retire it?
10819 * xfaces.c (USG, __TIMEVAL__): Likewise.
10821 * dispextern.h (struct redisplay_interface): Rename param
10822 to avoid shadowing.
10823 * termhooks.h (struct terminal): Likewise.
10824 * xterm.c (xembed_send_message): Likewise.
10826 * insdel.c (make_gap_smaller): Define only if
10827 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10829 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10832 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10833 so that we aren't warned about unused symbols.
10835 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10837 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10839 * xfns.c (x_real_positions): Mark locals as initialized.
10841 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10843 * xterm.c: Fix problems found by static analysis with other toolkits.
10844 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10845 (x_dispatch_event): Declare static if USE_GTK, and
10846 define if USE_GTK || USE_X_TOOLKIT.
10847 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10848 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10849 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10850 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10852 * xmenu.c (menu_help_callback): Pointer type fixes.
10853 Use const pointers when pointing at readonly data. Avoid pointer
10854 signedness clashes.
10855 (FALSE): Remove unused macro.
10856 (update_frame_menubar): Remove unused decl.
10858 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10860 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10861 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10862 (single_menu_item): Rename local to avoid shadowing.
10864 * keyboard.c (make_lispy_event): Remove unused local var.
10866 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10867 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10869 * bitmaps: Change bitmaps from unsigned char back to the X11
10870 compatible char. Avoid the old compiler warnings about
10871 out-of-range initializers by using, for example, '\xab' rather
10874 * xgselect.c (xgselect_initialize): Check vs interface
10875 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10877 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10879 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10880 to read-only memory.
10882 * fns.c (vector): Remove; this old hack is no longer needed.
10884 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10886 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10888 * xrdb.c (x_load_resources): Omit unused local.
10890 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10891 (x_window): Rename locals to avoid shadowing.
10892 (USG): Use the kludged USG macro, to pacify gcc.
10894 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10895 (x_term_init): Remove local to avoid shadowing.
10897 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10899 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10900 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10902 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10904 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10906 Fix regex.c, syntax.c and friends for buffers > 2GB.
10907 * syntax.h (struct gl_state_s): Declare character position members
10910 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10912 * textprop.c (verify_interval_modification, interval_of):
10913 Declare arguments EMACS_INT.
10915 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10918 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10920 * indent.c (Fvertical_motion): Local variable it_start is now
10923 * regex.c (re_match, re_match_2, re_match_2_internal)
10924 (bcmp_translate, regcomp, regexec, print_double_string)
10925 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10926 (re_compile_pattern, re_exec): Declare arguments and local
10927 variables `size_t' and `ssize_t' and return values `regoff_t', as
10929 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10930 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10931 <compile_stack_type>: `size' and `avail' are now `size_t'.
10933 * regex.h <regoff_t>: Use ssize_t, not int.
10934 (re_search, re_search_2, re_match, re_match_2): Arguments that
10935 specify buffer/string position and length are now ssize_t and
10936 size_t. Return type is regoff_t.
10938 2011-04-16 Ben Key <bkey76@gmail.com>
10940 * nsfont.m: Fixed bugs in ns_get_family and
10941 ns_descriptor_to_entity that were caused by using free to
10942 deallocate memory blocks that were allocated by xmalloc (via
10943 xstrdup). This caused Emacs to crash when compiled with
10944 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10945 --enable-checking=xmallocoverrun). xfree is now used to
10946 deallocate these memory blocks.
10948 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10950 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10952 emacs_write: Accept and return EMACS_INT for sizes.
10953 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10955 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10956 Accept and return EMACS_INT.
10957 (emacs_gnutls_write): Return the number of bytes written on
10959 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10960 (emacs_read, emacs_write): Remove check for negative size, as the
10961 Emacs source code has been audited now.
10962 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10963 (emacs_read, emacs_write): Use it.
10964 * process.c (send_process): Adjust to the new signatures of
10965 emacs_write and emacs_gnutls_write. Do not attempt to store
10966 a byte offset into an 'int'; it might overflow.
10967 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10969 * sound.c: Don't assume sizes fit in 'int'.
10970 (struct sound_device.period_size, alsa_period_size):
10971 Return EMACS_INT, not int.
10972 (struct sound_device.write, vox_write, alsa_write):
10973 Accept EMACS_INT, not int.
10974 (wav_play, au_play): Use EMACS_INT to store sizes and to
10975 record read return values.
10977 2011-04-15 Ben Key <bkey76@gmail.com>
10979 * keyboard.c (Qundefined): Don't declare static since it is used
10981 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10982 static since they are used in nsfont.m.
10984 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10986 * process.c (Qprocessp): Don't declare static.
10987 * lisp.h (Qprocessp): Declare again.
10989 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10991 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10993 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10995 Improve C-level modularity by making more things 'static'.
10997 Don't publish debugger-only interfaces to other modules.
10998 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10999 (verify_bytepos, count_markers): Move decls to the only modules
11001 * region-cache.h (pp_cache): Likewise.
11002 * window.h (check_all_windows): Likewise.
11003 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11005 * sysdep.c (croak): Now static, if
11006 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11007 * syssignal.h (croak): Declare only if not static.
11009 * alloc.c (refill_memory_reserve): Now static if
11010 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11011 * lisp.h (refill_memory_reserve): Declare only if not static.
11013 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11014 Define only if USE_LUCID.
11016 * xrdb.c (x_customization_string, x_rm_string): Now static.
11018 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11019 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11021 * xdisp.c (draw_row_with_mouse_face): Now static.
11022 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11024 * window.h (check_all_windows): Mark externally visible.
11026 * window.c (window_deletion_count): Now static.
11028 * undo.c: Make symbols static if they're not exported.
11029 (last_undo_buffer, last_boundary_position, pending_boundary):
11032 * textprop.c (interval_insert_behind_hooks): Now static.
11033 (interval_insert_in_front_hooks): Likewise.
11035 * term.c: Make symbols static if they're not exported.
11036 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11037 (max_frame_lines, tty_set_terminal_modes):
11038 (tty_reset_terminal_modes, tty_turn_off_highlight):
11039 (get_tty_terminal): Now static.
11040 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11041 * termhooks.h (term_mouse_moveto): Do not declare if
11042 HAVE_WINDOW_SYSTEM.
11043 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11044 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11046 * sysdep.c: Make symbols static if they're not exported.
11047 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11049 (sigprocmask_set, full_mask): Remove; unused.
11050 (wait_debugging): Mark as visible.
11051 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11052 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11054 * syntax.c (syntax_temp): Define only if !__GNUC__.
11056 * sound.c (current_sound_device, current_sound): Now static.
11058 * search.c (searchbufs, searchbuf_head): Now static.
11060 * scroll.c (scroll_cost): Remove; unused.
11061 * dispextern.h (scroll_cost): Remove decl.
11063 * region-cache.h (pp_cache): Mark as externally visible.
11065 * process.c: Make symbols static if they're not exported.
11066 (process_tick, update_tick, create_process, chan_process):
11067 (Vprocess_alist, proc_buffered_char, datagram_access):
11068 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11069 (deactivate_process): Mark defn as static, as well as decl.
11070 * lisp.h (create_process): Remove decl.
11071 * process.h (chan_process, Vprocess_alist): Remove decls.
11073 * print.c: Make symbols static if they're not exported.
11074 (print_depth, new_backquote_output, being_printed, print_buffer):
11075 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11076 (print_interval, print_number_index, initial_stderr_stream):
11078 * lisp.h (Fprinc): Remove decl.
11079 (debug_output_compilation_hack): Mark as externally visible.
11081 * sysdep.c (croak): Move decl from here to syssignal.h.
11082 * syssignal.h (croak): Put it here, so the API can be checked when
11083 'croak' is called from dissociate_if_controlling_tty.
11085 * minibuf.c: Make symbols static if they're not exported.
11086 (minibuf_save_list, choose_minibuf_frame): Now static.
11087 * lisp.h (choose_minibuf_frame): Remove decl.
11089 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11091 * lread.c: Make symbols static if they're not exported.
11092 (read_objects, initial_obarray, oblookup_last_bucket_number):
11094 (make_symbol): Remove; unused.
11095 * lisp.h (initial_obarray, make_symbol): Remove decls.
11097 * keyboard.c: Make symbols static if they're not exported.
11098 (single_kboard, recent_keys_index, total_keys, recent_keys):
11099 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11100 (this_single_command_key_start, echoing, last_auto_save):
11101 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11102 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11103 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11104 (Vlispy_mouse_stem, double_click_count):
11106 (force_auto_save_soon): Define only if SIGDANGER.
11107 (ignore_mouse_drag_p): Now static if
11108 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11109 (print_help): Remove; unused.
11110 (stop_character, last_timer_event): Mark as externally visible.
11111 * keyboard.h (ignore_mouse_drag_p): Declare only if
11112 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11113 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11114 * lisp.h (echoing): Remove decl.
11115 (force_auto_save_soon): Declare only if SIGDANGER.
11116 * xdisp.c (redisplay_window): Simplify code, to make it more
11117 obvious that ignore_mouse_drag_p is not accessed if !defined
11118 USE_GTK && !defined HAVE_NS.
11120 * intervals.c: Make symbols static if they're not exported.
11121 (merge_properties_sticky, merge_interval_right, delete_interval):
11123 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11125 * insdel.c: Make symbols static if they're not exported.
11126 However, leave prepare_to_modify_buffer alone. It's never
11127 called from outside this function, but that appears to be a bug.
11128 (combine_after_change_list, combine_after_change_buffer):
11129 (adjust_after_replace, signal_before_change): Now static.
11130 (adjust_after_replace_noundo): Remove; unused.
11131 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11132 (signal_before_change): Remove decls.
11134 * indent.c (val_compute_motion, val_vmotion): Now static.
11136 * image.c: Make symbols static if they're not exported.
11137 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11139 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11140 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11142 * fringe.c (standard_bitmaps): Now static.
11143 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11145 * frame.c: Make symbols static if they're not exported.
11146 (x_report_frame_params, make_terminal_frame): Now static.
11147 (get_frame_param): Now static, unless HAVE_NS.
11148 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11149 (x_get_resource_string): Remove; not used.
11150 * frame.h (make_terminal_frame, x_report_frame_params):
11151 (x_get_resource_string); Remove decls.
11152 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11153 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11155 * font.c, fontset.c: Make symbols static if they're not exported.
11156 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11157 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11158 * font.c (font_close_object): Now static.
11159 * font.h (font_close_object): Remove.
11160 * fontset.c (FONTSET_OBJLIST): Remove.
11161 (free_realized_fontset) #if-0 the body, which does nothing.
11162 (face_suitable_for_char_p): #if-0, as it's never called.
11163 * fontset.h (face_suitable_for_char_p): Remove decl.
11164 * xfaces.c (face_at_string_position):
11165 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11166 since 0 is always ASCII.
11168 * fns.c (weak_hash_tables): Now static.
11170 * fileio.c: Make symbols static if they're not exported.
11171 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11172 (Vwrite_region_annotation_buffers): Now static.
11174 * eval.c: Make symbols static if they're not exported.
11175 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11176 * lisp.h (backtrace_list): Remove decl.
11178 * emacs.c: Make symbols static if they're not exported.
11179 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11180 (fatal_error_code, fatal_error_signal_hook, standard_args):
11182 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11183 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11184 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11185 * lisp.h (fatal_error_signal_hook): Remove decl.
11186 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11188 * editfns.c: Move a (normally-unused) function to its only use.
11189 * editfns.c, lisp.h (get_operating_system_release): Remove.
11190 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11191 worth the hassle of breaking this out.
11193 * xterm.c: Make symbols static if they're not exported.
11194 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11195 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11196 (x_destroy_window, x_delete_display):
11198 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11199 (x_mouse_leave): Remove; unused.
11200 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11201 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11202 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11204 (x_mouse_leave): Declare only if WINDOWSNT.
11205 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11206 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11209 * ftxfont.c: Make symbols static if they're not exported.
11210 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11212 * font.h (ftxfont_driver): Likewise.
11214 * xfns.c: Make symbols static if they're not exported.
11215 (x_last_font_name, x_display_info_for_name):
11216 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11217 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11218 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11219 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11220 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11221 (last_show_tip_args): Now static.
11222 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11223 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11224 (x_screen_planes): Remove; unused.
11225 * dispextern.h (x_screen_planes): Remove decl.
11227 * dispnew.c: Make symbols static if they're not exported.
11228 * dispextern.h (redraw_garbaged_frames, scrolling):
11229 (increment_row_positions): Remove.
11230 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11231 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11233 (redraw_garbaged_frames): Remove; unused.
11235 * xfaces.c: Make symbols static if they're not exported.
11236 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11238 * xterm.h (defined_color): Remove decls.
11239 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11240 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11241 (menu_face_changed_default, defined_color, free_realized_face):
11242 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11243 (ascii_face_of_lisp_face): Remove; unused.
11245 * xdisp.c: Make symbols static if they're not exported.
11246 * dispextern.h (scratch_glyph_row, window_box_edges):
11247 (glyph_to_pixel_coords, set_cursor_from_row):
11248 (get_next_display_element, set_iterator_to_next):
11249 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11250 (show_mouse_face): Remove decls
11251 * frame.h (message_buf_print): Likewise.
11252 * lisp.h (pop_message, set_message, check_point_in_composition):
11254 * xterm.h (set_vertical_scroll_bar): Likewise.
11255 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11256 (message_buf_print, scratch_glyph_row, displayed_buffer):
11257 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11258 (get_next_display_element, show_mouse_face, window_box_edges):
11259 (frame_to_window_pixel_xy, check_point_in_composition):
11260 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11261 (glyph_to_pixel_coords): Remove; unused.
11263 * dired.c (file_name_completion): Now static.
11265 * dbusbind.c (xd_in_read_queued_messages): Now static.
11267 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11268 * data.c (circular_list_error): Remove.
11270 * commands.h (last_point_position, last_point_position_buffer):
11271 (last_point_position_window): Remove decls.
11272 * keyboard.c: Make these variables static.
11274 * coding.h (coding, code_convert_region, encode_coding_gap):
11276 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11277 (iso_code_class, detect_coding, code_convert_region): Now static.
11278 (encode_coding_gap): Remove; unused.
11280 * chartab.c (chartab_chars, chartab_bits): Now static.
11282 * charset.h (charset_iso_8859_1): Remove decl.
11283 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11286 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11287 * ccl.c (Vccl_program_table): Now static.
11288 (check_ccl_update): Remove; unused.
11290 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11291 * category.h: ... from here.
11292 * category.c (check_category_table, set_category_set): Now static.
11294 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11295 * lisp.h: Remove these decls.
11297 * buffer.c (buffer_count): Remove unused var.
11299 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11300 so that it's not optimized away.
11301 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11302 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11303 exported only to the debugger.
11305 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11306 * atimer.h (run_all_atimers): Remove; not exported.
11308 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11309 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11310 was inaccessible from Lisp.
11311 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11312 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11314 alloc.c: Import and export fewer symbols, and remove unused items.
11315 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11317 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11318 it's not optimized away by whole-program optimization.
11319 (message_enable_multibyte, free_misc): Remove.
11320 (catchlist, handlerlist, mark_backtrace):
11321 Declare only if BYTE_MARK_STACK.
11322 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11323 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11324 (message_enable_multibyte): Remove decl.
11325 (free_misc, interval_free_list, float_block, float_block_index):
11326 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11327 (cons_free_list, last_marked_index):
11329 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11330 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11331 (mark_backtrace): Define only if BYTE_MARK_STACK.
11332 * xdisp.c (message_enable_multibyte): Now static.
11334 Declare Lisp_Object Q* variables to be 'static' if not exported.
11335 This makes it easier for human readers (and static analyzers)
11336 to see whether these variables are used from other modules.
11337 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11338 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11339 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11340 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11341 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11342 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11343 * xmenu.c, xselect.c:
11344 Declare Q* vars static if they are not used in other modules.
11345 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11346 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11347 Remove decls of unexported vars.
11348 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11350 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11352 Make Emacs functions such as Fatom 'static' by default.
11353 This makes it easier for human readers (and static analyzers)
11354 to see whether these functions can be called from other modules.
11355 DEFUN now defines a static function. To make the function external
11356 so that it can be used in other C modules, use the new macro DEFUE.
11357 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11358 (Finit_image_library):
11359 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11360 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11361 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11362 Remove decls, since these functions are now static.
11363 (Funintern, Fget_internal_run_time): New decls, since these functions
11364 were already external.
11366 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11367 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11368 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11369 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11370 * keyboard.c, keymap.c, lread.c:
11371 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11372 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11373 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11374 Mark functions with DEFUE instead of DEFUN,
11375 if they are used in other modules.
11376 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11377 decls for now-static functions.
11378 * buffer.h (Fdelete_overlay): Remove decl.
11379 * callproc.c (Fgetenv_internal): Mark as internal.
11380 * composite.c (Fremove_list_of_text_properties): Remove decl.
11381 (Fcomposition_get_gstring): New forward static decl.
11382 * composite.h (Fcomposite_get_gstring): Remove decl.
11383 * dired.c (Ffile_attributes): New forward static decl.
11384 * doc.c (Fdocumntation_property): New forward static decl.
11385 * eval.c (Ffetch_bytecode): New forward static decl.
11386 (Funintern): Remove extern decl; now in .h file where it belongs.
11387 * fileio.c (Fmake_symbolic_link): New forward static decl.
11388 * image.c (Finit_image_library): New forward static decl.
11389 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11390 * intervals.h (Fprevious_property_change):
11391 (Fremove_list_of_text_properties): Remove decls.
11392 * keyboard.c (Fthis_command_keys): Remove decl.
11393 (Fcommand_execute): New forward static decl.
11394 * keymap.c (Flookup_key): New forward static decl.
11395 (Fcopy_keymap): Now static.
11396 * keymap.h (Flookup_key): Remove decl.
11397 * process.c (Fget_process): New forward static decl.
11398 (Fprocess_datagram_address): Mark as internal.
11399 * syntax.c (Fsyntax_table_p): New forward static decl.
11400 (skip_chars): Remove duplicate decl.
11401 * textprop.c (Fprevious_property_change): New forward static decl.
11402 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11404 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11405 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11407 * editfns.c (Fformat): Remove unreachable code.
11409 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11411 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11414 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11416 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11417 when at ZV. (Bug#8487)
11419 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11421 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11423 * keyboard.c (parse_tool_bar_item): Likewise.
11424 * sound.c (sound_cleanup, alsa_close): Likewise.
11425 * termcap.c (tgetent): Likewise.
11426 * xfns.c (x_default_font_parameter): Likewise.
11427 * xsettings.c (read_and_apply_settings): Likewise.
11429 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11430 (overrun_check_free): Protoize.
11432 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11434 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11435 since callers should never pass a negative size.
11436 Change the signature to match that of plain 'read' and 'write'; see
11437 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11438 * lisp.h: Update prototypes of emacs_write and emacs_read.
11440 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11442 * xdisp.c (redisplay_window): Don't try to determine the character
11443 position of the scroll margin if the window start point w->startp
11444 is outside the buffer's accessible region. (Bug#8468)
11446 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11448 Fix write-region and its subroutines for buffers > 2GB.
11449 * fileio.c (a_write, e_write): Modify declaration of arguments and
11450 local variables to support buffers larger than 2GB.
11451 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11453 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11454 argument, local variables, and return value.
11456 * lisp.h: Update prototypes of emacs_write and emacs_read.
11458 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11460 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11462 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11464 Fix more problems found by GCC 4.6.0's static checks.
11466 * xdisp.c (vmessage): Use a better test for character truncation.
11468 * charset.c (load_charset_map): <, not <=, for optimization,
11469 and to avoid potential problems with integer overflow.
11470 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11471 * casetab.c (set_identity, shuffle): Likewise.
11472 * editfns.c (Fformat): Likewise.
11473 * syntax.c (skip_chars): Likewise.
11475 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11476 This also lets GCC 4.6.0 generate slightly better loop code.
11478 * callint.c (Fcall_interactively): <, not <=, for optimization.
11479 (Fcall_interactively): Count the number of arguments produced,
11480 not the number of arguments given. This is simpler and lets GCC
11481 4.6.0 generate slightly better code.
11483 * ftfont.c: Distingish more carefully between FcChar8 and char.
11484 The previous code passed unsigned char * to a functions like
11485 strlen and xstrcasecmp that expect char *, which does not
11486 conform to the C standard.
11487 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11488 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11489 char * when the C standard requires it.
11491 * keyboard.c (read_char): Remove unused var.
11493 * eval.c: Port to Windows vsnprintf (Bug#8435).
11494 Include <limits.h>.
11495 (SIZE_MAX): Define if the headers do not.
11496 (verror): Do not give up if vsnprintf returns a negative count.
11497 Instead, grow the buffer. This ports to Windows vsnprintf, which
11498 does not conform to C99. Problem reported by Eli Zaretskii.
11499 Also, simplify the allocation scheme, by avoiding the need for
11500 calling realloc, and removing the ALLOCATED variable.
11502 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11504 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11505 But keep the doprint source code for now, as we might revamp it
11506 and use it again (Bug#8435).
11507 * lisp.h (doprnt): Remove.
11508 * Makefile.in (base_obj): Remove doprnt.o.
11509 * deps.mk (doprnt.o): Remove.
11511 error: Print 32- and 64-bit integers portably (Bug#8435).
11512 Without this change, on typical 64-bit hosts error ("...%d...", N)
11513 was used to print both 32- and 64-bit integers N, which relied on
11514 undefined behavior.
11515 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11516 * lisp.h (error, verror): Mark as printf-like functions.
11517 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11518 Report overflow in size calculations when allocating printf buffer.
11519 Do not truncate output string at its first null byte.
11520 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11521 Truncate the output at a character boundary, since vsnprintf does not
11523 * charset.c (check_iso_charset_parameter): Convert internal
11524 character to string before calling 'error', since %c now has the
11526 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11527 overflow when computing char to be passed to 'error'. Do not
11528 pass Lisp_Object to 'error'; pass the integer instead.
11529 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11530 formatted with plain %d.
11532 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11534 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11536 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11538 * xterm.c (x_catch_errors): Remove duplicate declaration.
11540 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11542 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11544 2011-04-10 Jim Meyering <meyering@redhat.com>
11546 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11547 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11548 return ssize_t not "int", and use size_t as the buffer length.
11549 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11550 * gnutls.h: Update declarations.
11551 * process.c (read_process_output): Use ssize_t, to match.
11552 (send_process): Likewise.
11554 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11556 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11558 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11560 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11561 Use unsigned char, to match FcChar8 type definition.
11563 * xterm.c (handle_one_xevent):
11564 * xmenu.c (create_and_show_popup_menu):
11565 * xselect.c (x_decline_selection_request)
11566 (x_reply_selection_request): Avoid type-punned deref of X events.
11568 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11570 Fix some uses of `int' instead of EMACS_INT.
11571 * search.c (string_match_1, fast_string_match)
11572 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11573 (scan_buffer, find_next_newline_no_quit)
11574 (find_before_next_newline, search_command, Freplace_match)
11575 (Fmatch_data): Make some `int' variables be EMACS_INT.
11577 * xdisp.c (display_count_lines): 3rd argument and return value now
11578 EMACS_INT. All callers changed.
11579 (pint2hrstr): Last argument is now EMACS_INT.
11581 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11582 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11583 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11584 (decode_coding_utf_16, decode_coding_emacs_mule)
11585 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11586 (decode_coding_ccl, decode_coding_charset)
11587 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11588 (decode_coding_iso_2022, decode_coding_emacs_mule)
11589 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11590 <char_offset, last_offset>: Declare EMACS_INT.
11591 (encode_coding_utf_8, encode_coding_utf_16)
11592 (encode_coding_emacs_mule, encode_invocation_designation)
11593 (encode_designation_at_bol, encode_coding_iso_2022)
11594 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11595 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11597 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11598 (encode_invocation_designation): Last argument P_NCHARS is now
11600 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11601 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11603 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11606 * ccl.c (Fccl_execute_on_string): Declare some variables
11609 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11611 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11613 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11615 * process.c (Fformat_network_address): Doc fix.
11617 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11619 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11621 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11623 * keyboard.c (read_char): Call Lisp function help-form-show,
11624 instead of using internal_with_output_to_temp_buffer.
11625 (Qhelp_form_show): New var.
11626 (syms_of_keyboard): Use DEFSYM macro.
11628 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11630 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11632 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11634 * process.c (Flist_processes): Remove to Lisp.
11635 (list_processes_1): Delete.
11637 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11639 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11641 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11643 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11645 Fix more problems found by GCC 4.6.0's static checks.
11647 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11649 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11651 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11653 * xdisp.c (vmessage): Mark as a printf-like function.
11655 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11657 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11659 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11660 printf-like functions.
11661 (tiff_load): Add casts to remove these marks before passing them
11662 to system-supplied API.
11664 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11666 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11667 This avoids several warnings with gcc -Wstrict-overflow.
11668 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11669 directly, rather than having caller test rule sign. This avoids
11670 some unnecessary tests.
11671 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11672 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11673 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11675 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11676 (xfont_open): Avoid unnecessary tests.
11678 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11680 * composite.h, composite.c (composition_gstring_put_cache):
11681 Use EMACS_INT, not int, for length.
11683 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11684 breaking out part of COMPOSITION_DECODE_RULE.
11685 (COMPOSITION_DECODE_RULE): Use it.
11686 * composite.c (get_composition_id): Remove unused local vars,
11687 by using the new macro.
11689 * textprop.c (set_text_properties_1): Change while to do-while,
11690 since the condition is always true at first.
11692 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11693 (interval_deletion_adjustment): Return unsigned value.
11696 * process.c (list_processes_1, create_pty, read_process_output):
11697 (exec_sentinel): Remove vars that were set but not used.
11698 (create_pty): Remove unnecessary "volatile"s.
11699 (Fnetwork_interface_info): Avoid possibility of int overflow.
11700 (read_process_output): Do adaptive read buffering even if carryover.
11701 (read_process_output): Simplify nbytes computation if buffered.
11703 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11705 * syntax.c (scan_words): Remove var that was set but not used.
11706 (update_syntax_table): Use unsigned instead of int.
11708 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11709 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11710 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11712 * print.c (print_error_message): Avoid int overflow.
11714 * font.c (font_list_entities): Redo for clarity,
11715 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11717 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11718 (font_score): Avoid potential overflow in diff calculation.
11720 * fns.c (substring_both): Remove var that is set but not used.
11721 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11723 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11725 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11726 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11727 can always succeed if overflow has undefined behavior.
11729 * search.c (boyer_moore, wordify): Remove vars set but not used.
11730 (wordify): Omit three unnecessary tests.
11732 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11733 All callers changed. This avoids the need for an unused var.
11735 * casefiddle.c (casify_region): Remove var that is set but not used.
11737 * dired.c (file_name_completion): Remove var that is set but not used.
11739 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11741 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11742 (Finsert_file_contents): Remove unnecessary code checking fd.
11744 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11745 Check for integer overflow on size calculations.
11747 * buffer.c (Fprevious_overlay_change): Remove var that is set
11750 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11751 Remove vars that are set but not used.
11752 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11753 (timer_check_2): Mark vars as initialized.
11755 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11757 * image.c (lookup_image): Remove var that is set but not used.
11758 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11760 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11761 that are set but not used.
11763 * xfns.c (make_invisible_cursor): Don't return garbage
11764 if XCreateBitmapFromData fails (Bug#8410).
11766 * xselect.c (x_get_local_selection, x_handle_property_notify):
11767 Remove vars that are set but not used.
11769 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11770 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11772 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11773 Remove var that is set but not used.
11774 (scroll_bar_windows_size): Now size_t, not int.
11775 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11776 Check for overflow.
11778 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11779 (map_tty_color) [!defined MSDOS]: Likewise.
11781 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11783 * coding.c: Remove vars that are set but not used.
11784 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11785 All callers changed.
11786 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11787 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11788 (decode_coding_charset): Remove vars that are set but not used.
11790 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11791 that is set but not used.
11793 * print.c (print_object): Remove var that is set but not used.
11795 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11796 The gnulib version avoids calling malloc in the usual case,
11797 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11798 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11799 * filelock.c (current_lock_owner): Likewise.
11800 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11801 * sysdep.c: Include allocator.h, careadlinkat.h.
11802 (emacs_no_realloc_allocator): New static constant.
11803 (emacs_readlink): New function.
11804 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11805 ../lib/careadlinkat.h.
11807 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11809 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11810 first non-nil return value).
11812 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11814 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11815 if not defined (Bug#8403).
11817 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11819 * xdisp.c (display_count_lines): Remove parameter `start',
11820 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11821 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11822 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11823 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11824 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11825 and thereabouts. All callers changed.
11826 (get_per_char_metric): Remove parameter `f', unused since
11827 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11829 2011-04-02 Jim Meyering <meyering@redhat.com>
11831 do not dereference NULL upon failed strdup
11832 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11833 (ns_get_family): Likewise.
11835 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11837 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11839 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11841 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11844 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11846 Add lexical binding.
11848 * window.c (Ftemp_output_buffer_show): New fun.
11849 (Fsave_window_excursion):
11850 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11852 * lread.c (lisp_file_lexically_bound_p): New function.
11853 (Fload): Bind Qlexical_binding.
11854 (readevalloop): Remove `evalfun' arg.
11855 Bind Qinternal_interpreter_environment.
11856 (Feval_buffer): Bind Qlexical_binding.
11857 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11859 (syms_of_lread): Declare `lexical-binding'.
11861 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11863 * keyboard.c (eval_dyn): New fun.
11864 (menu_item_eval_property): Use it.
11866 * image.c (parse_image_spec): Use Ffunctionp.
11868 * fns.c (concat, mapcar1): Accept byte-code-functions.
11870 * eval.c (Fsetq): Handle lexical vars.
11871 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11872 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11873 (FletX, Flet): Obey lexical binding.
11874 (Fcommandp): Handle closures.
11875 (Feval): New `lexical' arg.
11876 (eval_sub): New function extracted from Feval. Use it almost
11877 everywhere where Feval was used. Look up vars in lexical env.
11879 (Ffunctionp): Move from subr.el.
11880 (Ffuncall): Handle closures.
11881 (apply_lambda): Remove `eval_flags'.
11882 (funcall_lambda): Handle closures and new byte-code-functions.
11883 (Fspecial_variable_p): New function.
11884 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11885 but without exporting it to Lisp.
11887 * doc.c (Fdocumentation, store_function_docstring):
11888 * data.c (Finteractive_form): Handle closures.
11890 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11893 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11895 (exec_byte_code): New function extracted from Fbyte_code to handle new
11896 calling convention for byte-code-functions. Add new byte-codes.
11898 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11900 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11902 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11904 * xdisp.c (redisplay_internal): Fix prototype.
11906 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11908 * xdisp.c (SCROLL_LIMIT): New macro.
11909 (try_scrolling): Use it when setting scroll_limit.
11910 Limit scrolling to 100 screen lines.
11911 (redisplay_window): Even when falling back on "recentering",
11912 position point in the window according to scroll-conservatively,
11913 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11915 (try_scrolling): When point is above the window, allow searching
11916 as far as scroll_max, or one screenful, to compute vertical
11917 distance from PT to the scroll margin position. This prevents
11918 try_scrolling from unnecessarily failing when
11919 scroll-conservatively is set to a value slightly larger than the
11920 window height. Clean up the case of PT below the margin at bottom
11921 of window: scroll_max can no longer be INT_MAX. When aggressive
11922 scrolling is in use, don't let point enter the opposite scroll
11923 margin as result of the scroll.
11924 (syms_of_xdisp) <scroll-conservatively>: Document the
11925 threshold of 100 lines for never-recentering scrolling.
11927 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11929 * dispextern.h (move_it_by_lines):
11930 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11931 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11932 (message_log_check_duplicate): Remove parameters `prev_bol' and
11933 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11934 (redisplay_internal): Remove parameter `preserve_echo_area',
11935 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11937 * indent.c (Fvertical_motion):
11938 * window.c (window_scroll_pixel_based, Frecenter):
11939 Don't pass `need_y_p' to `move_it_by_lines'.
11941 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11943 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11944 steal a few bits to be more compact.
11945 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11946 Remove unneeded casts.
11948 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11950 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11952 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11953 binding" message (bug#7967).
11955 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11957 Fix more problems found by GCC 4.6.0's static checks.
11959 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11960 Remove unused local var.
11962 * editfns.c (Fmessage_box): Remove unused local var.
11964 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11965 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11966 Omit unused local vars.
11967 * window.c (shrink_windows): Omit unused local var.
11968 * menu.c (digest_single_submenu): Omit unused local var.
11969 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11970 Omit unused local var.
11972 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11973 Don't assume string length fits in int.
11974 (keyremap_step, read_key_sequence): Use size_t for sizes.
11975 (read_key_sequence): Don't check last_real_key_start redundantly.
11977 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11978 instead of alloca (Bug#8344).
11980 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11981 (Fbacktrace_frame): Don't assume nframes fits in int.
11983 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11985 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11988 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11990 * cm.c (calccost): Turn while-do into do-while, for clarity.
11992 * keyboard.c (syms_of_keyboard): Use the same style as later
11993 in this function when indexing through an array. This also
11994 works around GCC bug 48267.
11996 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11998 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12000 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12001 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12003 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12004 This avoids undefined behavior on integer overflow, and is a bit
12005 more convenient anyway since it is compared to a size_t variable.
12007 Variadic C functions now count arguments with size_t, not int.
12008 This avoids an unnecessary limitation on 64-bit machines, which
12009 caused (substring ...) to crash on large vectors (Bug#8344).
12010 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12011 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12012 All variadic functions and their callers changed accordingly.
12013 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12014 * data.c (arith_driver, float_arith_driver): Likewise.
12015 * editfns.c (general_insert_function): Likewise.
12016 * eval.c (struct backtrace.nargs, interactive_p)
12017 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12018 (funcall_lambda, mark_backtrace): Likewise.
12019 * fns.c (concat): Likewise.
12020 * frame.c (x_set_frame_parameters): Likewise.
12021 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12022 0 if not found, not -1. All callers changed.
12024 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12025 (stack_copy_size): Now size_t, not int.
12026 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12028 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12030 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12031 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12032 All callers changed.
12034 * lisp.h (multibyte_char_to_unibyte):
12035 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12036 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12037 * character.h (CHAR_TO_BYTE8):
12038 * cmds.c (internal_self_insert):
12039 * editfns.c (general_insert_function):
12040 * keymap.c (push_key_description):
12041 * search.c (Freplace_match):
12042 * xdisp.c (message_dolog, set_message_1): All callers changed.
12044 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12046 * keyboard.c (safe_run_hook_funcall): New function.
12047 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12048 don't set the hook to nil, but remove the offending function instead.
12049 (Qcommand_hook_internal): Remove, unused.
12050 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12051 Vcommand_hook_internal.
12053 * eval.c (enum run_hooks_condition): Remove.
12054 (funcall_nil, funcall_not): New functions.
12055 (run_hook_with_args): Call each function through a `funcall' argument.
12056 Remove `cond' argument, now redundant.
12057 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12058 (Frun_hook_with_args_until_failure): Adjust accordingly.
12059 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12061 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12063 * dispextern.h (string_buffer_position): Remove declaration.
12065 * print.c (strout): Remove parameter `multibyte', unused since
12066 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12068 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12069 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12070 All callers changed.
12072 * w32.c (_wsa_errlist): Use braces for struct initializers.
12074 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12075 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12076 All callers changed.
12077 (string_buffer_position): Likewise. Also, make static (it's never
12078 used outside xdisp.c).
12079 (cursor_row_p): Remove parameter `w', unused since
12080 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12081 (decode_mode_spec): Remove parameter `precision', introduced during
12082 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12083 All callers changed.
12085 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12087 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12089 2011-03-27 Anders Lindgren <andlind@gmail.com>
12091 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12092 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12093 (ns_update_auto_hide_menu_bar): New functions.
12094 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12095 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12096 ns_constrain_all_frames.
12097 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12098 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12100 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12102 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12104 2011-03-27 Glenn Morris <rgm@gnu.org>
12106 * syssignal.h: Replace RETSIGTYPE with void.
12107 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12108 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12109 Replace SIGTYPE with void everywhere.
12110 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12111 * s/template.h (SIGTYPE): Remove commented out definition.
12113 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12115 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12116 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12118 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12120 * w32.c (read_unc_volume): Use parameter `henum', instead of
12121 global variable `wget_enum_handle'.
12123 * keymap.c (describe_vector): Remove parameters `indices' and
12124 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12125 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12127 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12129 * keyboard.c (timer_check): Remove parameter `do_it_now',
12130 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12131 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12132 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12134 * keyboard.c (read_char):
12135 * w32menu.c (w32_menu_display_help):
12136 * xmenu.c (show_help_event, menu_help_callback):
12137 Adjust calls to `show_help_echo'.
12139 * gtkutil.c (xg_maybe_add_timer):
12140 * keyboard.c (readable_events):
12141 * process.c (wait_reading_process_output):
12142 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12144 * insdel.c (adjust_markers_gap_motion):
12145 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12146 (gap_left, gap_right): Don't call it.
12148 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12150 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12151 incurred during fontification.
12153 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12155 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12156 (DEFVAR_PER_BUFFER): Don't pass it.
12158 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12159 (scrolling_window): Don't pass it.
12161 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12163 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12165 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12167 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12168 of variables specific to SELinux and computation of `encoded_absname'.
12170 * image.c (XPutPixel): Remove unused variable `height'.
12172 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12174 * unexw32.c (get_section_info): Remove unused variable `section'.
12176 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12177 (system_process_attributes): Remove unused variable `sess'.
12178 (sys_read): Remove unused variable `err'.
12180 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12181 (w32_wnd_proc): Remove unused variable `isdead'.
12182 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12183 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12184 (x_create_tip_frame): Remove unused variable `tem'.
12186 * w32inevt.c (w32_console_read_socket):
12187 Remove unused variable `no_events'.
12189 * w32term.c (x_draw_composite_glyph_string_foreground):
12190 Remove unused variable `width'.
12192 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12194 * w32term.c (x_set_glyph_string_clipping):
12195 Don't pass uninitialized region to CombineRgn.
12197 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12199 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12200 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12201 (Fx_close_connection): Remove unused variable `i'.
12203 * w32font.c (w32font_draw): Return number of glyphs.
12204 (w32font_open_internal): Remove unused variable `i'.
12205 (w32font_driver): Add missing initializer.
12207 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12208 (fill_in_menu): Remove unused variable `items_added'.
12210 * w32term.c (last_mouse_press_frame): Remove static global variable.
12211 (w32_clip_to_row): Remove unused variable `f'.
12212 (x_delete_terminal): Remove unused variable `i'.
12214 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12215 (NOTHING): Remove unused static global variable.
12216 (uniscribe_check_otf): Remove unused variable `table'.
12217 (uniscribe_font_driver): Add missing initializers.
12219 2011-03-23 Julien Danjou <julien@danjou.info>
12221 * term.c (Fsuspend_tty, Fresume_tty):
12222 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12223 * window.c (temp_output_buffer_show):
12224 * insdel.c (signal_before_change):
12225 * frame.c (Fhandle_switch_frame):
12226 * fileio.c (Fdo_auto_save):
12227 * emacs.c (Fkill_emacs):
12228 * editfns.c (save_excursion_restore):
12229 * cmds.c (internal_self_insert):
12230 * callint.c (Fcall_interactively):
12231 * buffer.c (Fkill_all_local_variables):
12232 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12234 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12235 unconditionally since it does the check itself.
12237 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12239 Fix more problems found by GCC 4.5.2's static checks.
12241 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12242 the first time through the loop, since we know p0 < p1 then.
12243 This also avoids a gcc -Wstrict-overflow warning.
12245 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12246 leading to a memory leak, possible in functions like
12247 load_charset_map_from_file that can allocate an unbounded number
12248 of objects (Bug#8318).
12250 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12251 that could (at least in theory) be that large.
12253 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12254 This is less likely to overflow, and avoids undefined behavior if
12255 overflow does occur. All callers changed. Use strtoul to scan
12256 for the unsigned long integer.
12257 (pint2hrstr): Simplify and tune code slightly.
12258 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12260 * scroll.c (do_scrolling): Work around GCC bug 48228.
12261 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12263 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12264 This also avoids a warning with gcc -Wstrict-overflow.
12265 (validate_x_resource_name): Simplify count usage.
12266 This also avoids a warning with gcc -Wstrict-overflow.
12268 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12271 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12273 * process.c (Fmake_network_process): Use socklen_t, not int,
12274 where POSIX says socklen_t is required in portable programs.
12275 This fixes a porting bug on hosts like 64-bit HP-UX, where
12276 socklen_t is wider than int (Bug#8277).
12277 (Fmake_network_process, server_accept_connection):
12278 (wait_reading_process_output, read_process_output):
12281 * process.c: Rename or move locals to avoid shadowing.
12282 (list_processes_1, Fmake_network_process):
12283 (read_process_output_error_handler, exec_sentinel_error_handler):
12284 Rename or move locals.
12285 (Fmake_network_process): Define label "retry_connect" only if needed.
12286 (Fnetwork_interface_info): Fix pointer signedness.
12287 (process_send_signal): Add cast to avoid pointer signedness problem.
12288 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12289 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12291 Make tparam.h and terminfo.c consistent.
12292 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12293 Include tparam.h instead, since it declares them.
12294 * cm.h (PC): Remove extern decl; tparam.h now does this.
12295 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12296 * terminfo.c: Include tparam.h, to check interfaces.
12297 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12298 (tparam): Adjust signature to match interface in tparam.h;
12299 this removes some undefined behavior. Check that outstring and len
12300 are zero, which they always are with Emacs.
12301 * tparam.h (PC, BC, UP): New extern decls.
12303 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12304 (xftfont_open): Rename locals to avoid shadowing.
12306 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12307 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12308 (OTF_TAG_SYM): Omit macro if not needed.
12309 (ftfont_list): Remove unused local.
12310 (get_adstyle_property, ftfont_pattern_entity):
12311 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12312 Rename locals to avoid shadowing.
12314 * xfont.c (xfont_list_family): Mark var as initialized.
12316 * xml.c (make_dom): Now static.
12318 * composite.c (composition_compute_stop_pos): Rename local to
12320 (composition_reseat_it): Remove unused locals.
12321 (find_automatic_composition, composition_adjust_point): Likewise.
12322 (composition_update_it): Mark var as initialized.
12323 (find_automatic_composition): Mark vars as initialized,
12324 with a FIXME (Bug#8290).
12326 character.h: Rename locals to avoid shadowing.
12327 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12328 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12329 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12330 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12331 to avoid shadowing.
12333 * textprop.c (property_change_between_p): Remove; unused.
12335 * intervals.c (interval_start_pos): Now static.
12337 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12339 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12340 Rename locals to avoid shadowing.
12342 * sound.c (wav_play, au_play, Fplay_sound_internal):
12343 Fix pointer signedness.
12344 (alsa_choose_format): Remove unused local var.
12345 (wav_play): Initialize a variable to 0, to prevent undefined
12346 behavior (Bug#8278).
12348 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12350 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12352 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12353 clobbering (Bug#8298).
12354 * sysdep.c (sys_subshell): Likewise.
12355 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12357 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12358 This should get cleaned up, so that child_setup has the
12359 same signature on all platforms.
12361 * callproc.c (call_process_cleanup): Now static.
12362 (relocate_fd): Rename locals to avoid shadowing.
12364 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12366 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12367 not to be necessary, and produces flickering.
12369 2011-03-20 Glenn Morris <rgm@gnu.org>
12371 * config.in: Remove file.
12373 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12375 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12376 are now in src/globals.h.
12377 (syms_of_minibuf): Remove spurious & from previous change.
12379 2011-03-20 Leo Liu <sdl.web@gmail.com>
12381 * minibuf.c (completing-read-function): New variable.
12382 (completing-read-default): Rename from completing-read.
12383 (completing-read): Call completing-read-function.
12385 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12387 * xfaces.c (Fx_load_color_file):
12388 Read color file from absolute filename (bug#8250).
12390 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12392 * makefile.w32-in: Update dependencies.
12394 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12396 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12398 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12400 Fix more problems found by GCC 4.5.2's static checks.
12402 * process.c (make_serial_process_unwind, send_process_trap):
12403 (sigchld_handler): Now static.
12405 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12406 That way, the code declares only the vars that it needs.
12407 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12408 * s/cygwin.h (PTY_ITERATION): Likewise.
12409 * s/darwin.h (PTY_ITERATION): Likewise.
12410 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12412 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12413 * process.c (allocate_pty): Don't declare stb unless it's needed.
12415 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12416 (CONSTANTLIM): Remove; unused.
12417 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12418 Define only if needed.
12420 * unexelf.c (unexec): Name an expression,
12421 to avoid gcc -Wbad-function-cast warning.
12422 Use a different way to cause a compilation error if anyone uses
12423 n rather than nn, a way that does not involve shadowing.
12424 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12426 * deps.mk (unexalpha.o): Remove; unused.
12428 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12429 * unexec.h: New file.
12430 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12431 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12432 Depend on unexec.h.
12433 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12434 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12435 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12436 Change as necessary to match prototype in unexec.h.
12438 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12440 (back_comment, skip_chars): Mark vars as initialized.
12442 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12443 Rename locals to avoid shadowing.
12445 * lread.c (read1): Rewrite so as not to use empty "else".
12446 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12448 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12450 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12451 warning when compiling print.c.
12453 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12454 instead of using an uninitialized var.
12455 (font_sort_entities): Mark var as initialized.
12457 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12459 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12460 pointers to constants.
12461 (font_parse_fcname): Remove unused vars.
12462 (font_delete_unmatched): Now static.
12463 (font_get_spec): Remove; unused.
12464 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12465 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12466 Rename or move locals to avoid shadowing.
12468 * fns.c (require_nesting_list, require_unwind): Now static.
12469 (Ffillarray): Rename locals to avoid shadowing.
12471 * floatfns.c (domain_error2): Define only if needed.
12472 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12474 * alloc.c (mark_backtrace): Move decl from here ...
12475 * lisp.h: ... to here, so that it can be checked.
12477 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12478 (Fdefvar): Rewrite so as not to use empty "else".
12479 (lisp_indirect_variable): Name an expression,
12480 to avoid gcc -Wbad-function-cast warning.
12481 (Fdefvar): Rename locals to avoid shadowing.
12483 * callint.c (quotify_arg, quotify_args): Now static.
12484 (Fcall_interactively): Rename locals to avoid shadowing.
12485 Use const pointer when appropriate.
12487 * lisp.h (get_system_name, get_operating_system_release):
12488 Move decls here, to check interfaces.
12489 * process.c (get_operating_system_release): Move decl to lisp.h.
12490 * xrdb.c (get_system_name): Likewise.
12491 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12492 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12493 some of which prompt warnings from gcc -Wbad-function-cast.
12494 (Fformat_time_string, Fencode_time, Finsert_char):
12495 (Ftranslate_region_internal, Fformat):
12496 Rename or remove local vars to avoid shadowing.
12497 (Ftranslate_region_internal): Mark var as initialized.
12499 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12502 * lisp.h (eassert): Check that the argument compiles, even if
12503 ENABLE_CHECKING is not defined.
12505 * data.c (Findirect_variable): Name an expression, to avoid
12506 gcc -Wbad-function-cast warning.
12507 (default_value, arithcompare, arith_driver, arith_error): Now static.
12508 (store_symval_forwarding): Rename local to avoid shadowing.
12509 (Fmake_variable_buffer_local, Fmake_local_variable):
12510 Mark variables as initialized.
12511 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12513 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12514 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12515 Rename locals to avoid shadowing.
12516 (mark_stack): Move local variables into the #ifdef region where
12518 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12519 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12521 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12522 (GC_STRING_CHARS): Remove; not used.
12523 (Fmemory_limit): Cast sbrk's returned value to char *.
12525 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12526 avoids undefined behavior in theory.
12528 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12530 Use functions, not macros, for up- and down-casing (Bug#8254).
12531 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12532 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12533 to use the following functions instead of these macros.
12534 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12535 EMACS_INT, since callers assume the returned value fits in int.
12536 (upcase1): Likewise, for UPCASE_TABLE.
12537 (uppercasep, lowercasep, upcase): New static inline functions.
12538 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12539 the race-condition problem in the old DOWNCASE.
12541 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12542 Rename locals to avoid shadowing.
12543 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12544 (regex_compile, re_search_2, re_match_2_internal):
12545 Remove unused local vars.
12546 (FREE_VAR): Rewrite so as not to use empty "else",
12547 which gcc can warn about.
12548 (regex_compile, re_match_2_internal): Mark locals as initialized.
12549 (RETALLOC_IF): Define only if needed.
12550 (WORDCHAR_P): Likewise. This one is never needed, but is used
12551 only in a comment talking about a compiler bug, so put inside
12552 the #if 0 of that comment.
12553 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12554 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12557 * search.c (boyer_moore): Rename locals to avoid shadowing.
12558 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12559 (PREV_CHAR_BOUNDARY): Likewise.
12561 * search.c (simple_search): Remove unused var.
12563 * dired.c (compile_pattern): Move decl from here ...
12564 * lisp.h: ... to here, so that it can be checked.
12565 (struct re_registers): New forward decl.
12567 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12569 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12571 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12572 Rename locals to avoid shadowing.
12573 (Fvertical_motion): Mark locals as initialized.
12575 * casefiddle.c (casify_object, casify_region): Now static.
12576 (casify_region): Mark local as initialized.
12578 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12580 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12581 New macros, so that the caller can use some names other than
12582 gcpro1, gcpro2, etc.
12583 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12585 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12586 argument, for consistency with GCPRO2_VAR, etc: it is now the
12587 prefix of the variable, not the variable itself. All uses
12589 * dired.c (directory_files_internal, file_name_completion):
12590 Rename locals to avoid shadowing.
12592 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12593 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12594 dired.c's scmp function, had undefined behavior.
12595 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12596 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12597 * buffer.h: ... to here, because these macros use current_buffer,
12598 and the new implementation with inline functions needs to have
12599 current_buffer in scope now, rather than later when the macros
12601 (downcase, upcase1): New static inline functions.
12602 (DOWNCASE, UPCASE1): Reimplement using these functions.
12603 This avoids undefined behavior in expressions like
12604 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12605 from race conditions in accessing the global variables
12606 case_temp1 and case_temp2.
12607 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12608 * lisp.h (case_temp1, case_temp2): Remove their decls.
12609 * character.h (ASCII_CHAR_P): Move from here ...
12610 * lisp.h: ... to here, so that the inline functions mentioned
12611 above can use them.
12613 * dired.c (directory_files_internal_unwind): Now static.
12615 * fileio.c (file_name_as_directory, directory_file_name):
12616 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12618 (file_name_as_directory): Use const pointers when appropriate.
12619 (Fexpand_file_name): Likewise. In particular, newdir might
12620 point at constant storage, so make it a const pointer.
12621 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12622 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12624 (Fset_file_times, Finsert_file_contents, auto_save_error):
12625 Rename locals to avoid shadowing.
12627 * minibuf.c (choose_minibuf_frame_1): Now static.
12628 (Ftry_completion, Fall_completions): Rename or remove locals
12629 to avoid shadowing.
12631 * marker.c (bytepos_to_charpos): Remove; unused.
12633 * lisp.h (verify_bytepos, count_markers): New decls,
12634 so that gcc does not warn that these functions aren't declared.
12636 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12637 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12638 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12639 (copy_text): Remove unused local var.
12641 * filelock.c (within_one_second): Now static.
12642 (lock_file_1): Rename local to avoid shadowing.
12644 * buffer.c (fix_overlays_before): Mark locals as initialized.
12645 (fix_start_end_in_overlays): Likewise. This function should be
12646 simplified by using pointers-to-pointers, but that's a different
12648 (switch_to_buffer_1): Now static.
12649 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12650 (report_overlay_modification): Rename locals to avoid shadowing.
12652 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12653 Fix pointer signedness issue.
12654 (sys_subshell): Mark local as volatile if checking for lint,
12655 to suppress a gcc -Wclobbered warning that does not seem to be right.
12656 (MAXPATHLEN): Define only if needed.
12658 * process.c (serial_open, serial_configure): Move decls from here ...
12659 * systty.h: ... to here, so that they can be checked.
12661 * fns.c (get_random, seed_random): Move extern decls from here ...
12662 * lisp.h: ... to here, so that they can be checked.
12664 * sysdep.c (reset_io): Now static.
12665 (wait_for_termination_signal): Remove; unused.
12667 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12668 (copy_keymap_item, append_key, push_text_char_description):
12670 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12671 (DENSE_TABLE_SIZE): Remove; unused.
12672 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12673 (describe_map_tree):
12674 Rename locals to avoid shadowing.
12676 * keyboard.c: Declare functions static if they are not used elsewhere.
12677 (echo_char, echo_dash, cmd_error, top_level_2):
12678 (poll_for_input, handle_async_input): Now static.
12679 (read_char, kbd_buffer_get_event, make_lispy_position):
12680 (make_lispy_event, make_lispy_movement, apply_modifiers):
12681 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12682 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12683 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12684 (read_key_sequence, read_char): Mark locals as initialized.
12685 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12687 * keyboard.h (make_ctrl_char): New decl.
12688 (mark_kboards): Move decl here ...
12689 * alloc.c (mark_kboards): ... from here.
12691 * lisp.h (force_auto_save_soon): New decl.
12693 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12694 (DEFINE_DUMMY_FUNCTION): New macro.
12695 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12697 (main): Add casts to avoid warnings
12698 if GCC considers string literals to be constants.
12700 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12702 * dbusbind.c: Pointer signedness fixes.
12703 (xd_signature, xd_append_arg, xd_initialize):
12704 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12705 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12706 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12707 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12709 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12710 if GCC considers string literals to be constants.
12711 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12713 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12715 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12716 (print_preprocess, print_object): New macro to fix last change.
12718 * print.c (print_preprocess): Don't forget font objects.
12720 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12722 * emacs.c (USAGE3): Doc fixes.
12724 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12726 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12729 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12731 * lisp.h (VWindow_system, Qfile_name_history):
12732 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12733 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12734 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12736 * w32select.c: Don't #include "keyboard.h".
12737 (run_protected): Add extern declaration for waiting_for_input.
12739 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12740 * w32console.c (detect_input_pending, read_input_pending)
12741 (encode_terminal_code):
12742 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12743 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12744 (w32_system_caret_y, Qfile_name_history):
12745 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12746 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12747 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12748 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12749 * w32proc.c (Qlocal, report_file_error):
12750 * w32term.c (Vwindow_system, updating_frame):
12751 * w32uniscribe.c (initialized, uniscribe_font_driver):
12752 Remove unneeded extern declarations.
12754 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12756 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12758 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12760 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12761 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12762 These macros can no longer be used for assignment.
12764 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12765 Assign struct members directly, instead of using BUF_BEGV etc.
12766 (record_buffer_markers, fetch_buffer_markers): New functions for
12767 recording and fetching special buffer markers.
12768 (set_buffer_internal_1, set_buffer_temp): Use them.
12770 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12772 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12774 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12775 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12777 * xdisp.c (hscroll_window_tree):
12778 (reconsider_clip_changes): Use PT instead of BUF_PT.
12780 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12782 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12783 $(EMACS_ROOT)/lib/intprops.h.
12785 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12787 Fix more problems found by GCC 4.5.2's static checks.
12789 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12790 to unsigned char * to avoid compiler diagnostic.
12791 (xg_free_frame_widgets): Make it clear that a local variable is
12792 needed only if USE_GTK_TOOLTIP.
12793 (gdk_window_get_screen): Make it clear that this macro is needed
12794 only if USE_GTK_TOOLTIP.
12795 (int_gtk_range_get_value): New function, which avoids a diagnostic
12796 from gcc -Wbad-function-cast.
12797 (xg_set_toolkit_scroll_bar_thumb): Use it.
12798 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12799 diagnostic from gcc -Wbad-function-cast.
12800 (get_utf8_string, xg_get_file_with_chooser):
12801 Rename locals to avoid shadowing.
12802 (create_dialog): Move locals to avoid shadowing.
12804 * xgselect.c (xg_select): Remove unused var.
12806 * image.c (four_corners_best): Mark locals as initialized.
12807 (gif_load): Initialize transparent_p to zero (Bug#8238).
12808 Mark another local as initialized.
12809 (my_png_error, my_error_exit): Mark with NO_RETURN.
12811 * image.c (clear_image_cache): Now static.
12812 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12813 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12814 (x_edge_detection): Remove unnecessary cast that
12815 gcc -Wbad-function-cast diagnoses.
12816 (gif_load): Fix pointer signedness.
12817 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12818 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12820 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12822 Improve quality of tests for time stamp overflow.
12823 For example, without this patch (encode-time 0 0 0 1 1
12824 1152921504606846976) returns the obviously-bogus value (-948597
12825 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12826 reports time overflow. See
12827 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12828 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12829 * editfns.c: Include limits.h and intprops.h.
12830 (TIME_T_MIN, TIME_T_MAX): New macros.
12831 (time_overflow): Move earlier, to before first use.
12832 (hi_time, lo_time): New functions, for an accurate test for
12833 out-of-range times.
12834 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12835 (Fget_internal_run_time): Don't assume time_t fits in int.
12836 (make_time): Use list2 instead of Fcons twice.
12837 (Fdecode_time): More accurate test for out-of-range times.
12838 (check_tm_member): New function.
12839 (Fencode_time): Use it, to test for out-of-range times.
12840 (lisp_time_argument): Don't rely on undefined left-shift and
12841 right-shift behavior when checking for time stamp overflow.
12843 * editfns.c (time_overflow): New function, refactoring common code.
12844 (Fformat_time_string, Fdecode_time, Fencode_time):
12845 (Fcurrent_time_string): Use it.
12847 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12848 * dired.c (make_time): Move to ...
12849 * editfns.c (make_time): ... here.
12850 * systime.h: Note the move.
12852 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12854 * fringe.c (update_window_fringes): Remove unused variables.
12856 * unexmacosx.c (copy_data_segment): Also copy __got section.
12859 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12861 * termcap.c [MSDOS]: Include "msdos.h".
12862 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12863 Constify `char *' arguments and their references according to
12864 prototypes in tparam.h.
12866 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12868 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12869 Adapt all references accordingly.
12871 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12873 2011-03-11 Tom Tromey <tromey@redhat.com>
12875 * buffer.c (syms_of_buffer): Remove obsolete comment.
12877 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12879 * termhooks.h (encode_terminal_code): Declare prototype.
12881 * msdos.c (encode_terminal_code): Don't declare prototype.
12883 * term.c (encode_terminal_code): Now external again, used by
12884 w32console.c and msdos.c.
12886 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12887 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12889 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12891 Fix some minor problems found by GCC 4.5.2's static checks.
12893 * fringe.c (update_window_fringes): Mark locals as initialized
12895 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12897 * alloc.c (mark_fringe_data): Move decl from here ...
12898 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12899 to check its interface.
12900 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12902 * fontset.c (free_realized_fontset): Now static.
12903 (Fset_fontset_font): Rename local to avoid shadowing.
12904 (fontset_font): Mark local as initialized.
12905 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12907 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12909 * xselect.c (x_disown_buffer_selections): Remove; not used.
12910 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12911 (x_own_selection, Fx_disown_selection_internal): Rename locals
12912 to avoid shadowing.
12913 (x_handle_dnd_message): Remove local to avoid shadowing.
12915 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12916 so that the caller can use some name other than gcpro1.
12917 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12918 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12919 (Fx_backspace_delete_keys_p):
12920 Use them to avoid shadowing, and rename vars to avoid shadowing.
12921 (x_decode_color, x_set_name, x_window): Now static.
12922 (Fx_create_frame): Add braces to silence GCC warning.
12923 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12924 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12925 Remove unused locals.
12926 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12927 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12928 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12931 * xterm.h (x_mouse_leave): New decl.
12933 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12934 Remove unused functions.
12935 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12936 (x_calc_absolute_position): Now static.
12937 (XTread_socket): Don't define label "out" unless it's used.
12938 Don't declare local "event" unless it's used.
12939 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12940 unless they are used.
12941 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12942 (x_fatal_error_signal): Remove; not used.
12943 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12944 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12945 (x_error_catcher, x_connection_closed, x_error_handler):
12946 (x_error_quitter, xembed_send_message, x_iconify_frame):
12947 (my_log_handler): Rename locals to avoid shadowing.
12948 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12949 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12951 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12952 Rename or move locals to avoid shadowing.
12953 (tty_defined_color, merge_face_heights): Now static.
12954 (free_realized_faces_for_fontset): Remove; not used.
12955 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12956 does not deduce is never used uninitialized.
12957 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12958 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12960 * terminal.c (store_terminal_param): Now static.
12962 * xmenu.c (menu_highlight_callback): Now static.
12963 (set_frame_menubar): Remove unused local.
12964 (xmenu_show): Rename parameter to avoid shadowing.
12965 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12966 since they might point to immutable storage.
12967 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12968 since it's unused otherwise.
12970 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12971 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12972 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12973 avoids a gcc -Wuninitialized diagnostic.
12974 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12975 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12976 does not deduce are never used uninitialized.
12978 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12980 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12981 * window.c (window_loop, size_window):
12982 (run_window_configuration_change_hook, enlarge_window): Likewise.
12984 * window.c (display_buffer): Now static.
12985 (size_window): Mark variables that gcc -Wuninitialized
12986 does not deduce are never used uninitialized.
12987 * window.h (check_all_windows): New decl, to forestall
12988 gcc -Wmissing-prototypes diagnostic.
12989 * dispextern.h (bidi_dump_cached_states): Likewise.
12991 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12993 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12994 Include <limits.h>.
12995 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12996 and to avoid gcc -Wuninitialized warning.
12997 (load_charset_map): Mark variables that gcc -Wuninitialized
12998 does not deduce are never used uninitialized.
12999 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13001 * coding.c (coding_set_source, coding_set_destination):
13002 Use "else { /* comment */ }" rather than "else /* comment */;"
13003 for clarity, and to avoid gcc -Wempty-body warning.
13004 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13005 a block, when the outer 'i' will do.
13006 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13007 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13008 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13009 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13010 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13011 Rename locals to avoid shadowing.
13012 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13013 * coding.c (emacs_mule_char, encode_invocation_designation):
13014 Now static, since they're not used elsewhere.
13015 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13016 (decode_coding_object, encode_coding_object, detect_coding_system):
13017 (decode_coding_emacs_mule): Mark variables that gcc
13018 -Wuninitialized does not deduce are never used uninitialized.
13019 (detect_coding_iso_2022): Initialize a local variable that might
13020 be used uninitialized. Leave a FIXME because it's not clear that
13021 this initialization is needed. (Bug#8211)
13022 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13023 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13024 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13025 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13026 Remove unused macros.
13028 * category.c (hash_get_category_set): Remove unused local var.
13029 (copy_category_table): Now static, since it's not used elsewhere.
13030 * character.c (string_count_byte8): Likewise.
13032 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13033 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13035 * chartab.c (copy_sub_char_table): Now static, since it's not used
13037 (sub_char_table_ref_and_range, char_table_ref_and_range):
13038 Rename locals to avoid shadowing.
13039 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13041 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13042 (BIDI_BOB): Remove unused macro.
13044 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13045 deduce are never used uninitialized.
13046 * term.c (encode_terminal_code): Likewise.
13048 * term.c (encode_terminal_code): Now static. Remove unused local.
13050 * tparam.h: New file.
13051 * term.c, tparam.h: Include it.
13052 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13053 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13054 Move these decls to tparam.h, and make them agree with what
13055 is actually in tparam.c. The previous trick of using incompatible
13056 decls in different modules does not conform to the C standard.
13057 All callers of tparam changed to use tparam's actual API.
13058 * tparam.c (tparam1, tparam, tgoto):
13059 Use const pointers where appropriate.
13061 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13062 * cm.h (struct cm): Likewise.
13063 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13064 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13065 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13066 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13067 (turn_on_face, init_tty): Likewise.
13068 * termchar.h (struct tty_display_info): Likewise.
13070 * term.c (term_mouse_position): Rename local to avoid shadowing.
13072 * alloc.c (mark_ttys): Move decl from here ...
13073 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13075 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13077 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13079 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13081 * search.c (compile_pattern_1): Remove argument regp, unused since
13082 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13083 (compile_pattern): Don't pass it.
13085 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13087 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13088 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13090 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13092 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13094 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13095 gdk_window_get_screen, gdk_window_get_geometry,
13096 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13097 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13098 (xg_get_pixbuf_from_pixmap): New function.
13099 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13100 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13101 Call xg_get_pixbuf_from_pixmap instead of
13102 gdk_pixbuf_get_from_drawable.
13103 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13104 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13105 (xg_check_special_colors): Use GtkStyleContext and its functions
13107 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13108 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13109 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13110 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13111 Call gtk_widget_get_preferred_size.
13112 (xg_frame_resized): gdk_window_get_geometry only takes 5
13114 (xg_win_to_widget, xg_event_is_for_menubar):
13115 Call gdk_x11_window_lookup_for_display.
13116 (xg_set_widget_bg): New function.
13117 (delete_cb): New function.
13118 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13119 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13120 (xg_set_background_color): Call xg_set_widget_bg.
13121 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13122 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13123 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13124 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13126 (update_frame_tool_bar): Call gtk_widget_hide.
13127 (xg_initialize): Use GDK_KEY_g.
13129 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13131 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13133 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13134 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13135 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13137 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13139 * w32xfns.c (select_palette): Check success of RealizePalette against
13140 GDI_ERROR, not zero.
13142 See ChangeLog.11 for earlier changes.
13144 ;; Local Variables:
13148 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13150 This file is part of GNU Emacs.
13152 GNU Emacs is free software: you can redistribute it and/or modify
13153 it under the terms of the GNU General Public License as published by
13154 the Free Software Foundation, either version 3 of the License, or
13155 (at your option) any later version.
13157 GNU Emacs is distributed in the hope that it will be useful,
13158 but WITHOUT ANY WARRANTY; without even the implied warranty of
13159 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13160 GNU General Public License for more details.
13162 You should have received a copy of the GNU General Public License
13163 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.