1 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4 (graft_intervals_into_buffer): Simplify.
6 2011-11-18 Eli Zaretskii <eliz@gnu.org>
8 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9 hash values of the two rows.
10 (copy_row_except_pointers): Preserve the used[] arrays and the
11 hash values of the two rows. (Bug#10035)
12 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
14 * xdisp.c (row_hash): New function, body extracted from
16 (compute_line_metrics): Call row_hash, instead of computing the
19 * dispnew.c (verify_row_hash): Call row_hash for computing the
20 hash code of a row, instead of duplicating code from xdisp.c.
22 * dispextern.h (row_hash): Add prototype.
24 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
26 * frame.c (delete_frame): Don't delete the terminal when the last
27 X frame is closed if emacs is built with GTK toolkit.
29 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
31 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
33 2011-11-17 Martin Rudalics <rudalics@gmx.at>
35 * window.c (Vwindow_splits): Rename to
36 Vwindow_combination_resize. Suggested by Juri Linkov.
37 (Fsplit_window_internal): Use Vwindow_combination_resize instead
40 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
42 * nsfns.m (Fns_font_name):
43 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
45 2011-11-16 Martin Rudalics <rudalics@gmx.at>
47 * window.h (window): Rename slot "nest" to "combination_limit".
48 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
49 (Fset_window_nest): Rename to Fset_window_combination_limit.
50 (Vwindow_nest): Rename to Vwindow_combination_limit.
51 (recombine_windows, make_parent_window, make_window)
52 (Fsplit_window_internal, saved_window)
53 (Fset_window_configuration, save_window_save): Rename all
54 occurrences of window_nest to window_combination_limit.
56 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
58 * image.c (imagemagick_load_image): Fix typo.
60 2011-11-14 Eli Zaretskii <eliz@gnu.org>
62 * xdisp.c (display_line): Move the call to
63 highlight_trailing_whitespace before the call to
64 compute_line_metrics, since the latter needs to see the final
65 faces of all the glyphs to compute ROW's hash value. Fixes
66 assertion violations in row_equal_p. (Bug#10035)
68 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
70 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
71 just return (bug#10044).
73 2011-11-12 Eli Zaretskii <eliz@gnu.org>
75 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
76 with user-defined heap size. Bump the default size of the temacs
77 heap to 27MB, to avoid memory warning when running temacs.
78 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
80 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
81 current_matrix and desired_matrix. (Bug#9990)
82 (verify_row_hash) [XASSERTS]: New function.
83 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
84 that the hash value of glyph rows is correct.
86 2011-11-12 Martin Rudalics <rudalics@gmx.at>
88 * window.h (window): Remove splits slot.
89 * window.c (Fwindow_splits, Fset_window_splits): Remove.
90 (Fdelete_other_windows_internal, make_parent_window)
91 (make_window, Fsplit_window_internal, Fdelete_window_internal)
92 (Fset_window_configuration, save_window_save): Don't deal with
93 split status of windows.
94 (saved_window): Remove splits slot.
95 (Vwindow_splits): Rewrite doc-string.
97 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
99 * xfns.c (unwind_create_frame):
100 * nsfns.m (unwind_create_frame):
101 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
102 Vframe_list (Bug#9999).
104 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
106 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
108 2011-11-11 Kenichi Handa <handa@m17n.org>
110 * callproc.c (Fcall_process): Set the member dst_multibyte of
113 2011-11-11 Johan Bockgård <bojohan@gnu.org>
115 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
116 avoid a crash (bug#9496).
118 2011-11-09 Chong Yidong <cyd@gnu.org>
120 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
121 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
123 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
125 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
127 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
129 Avoid some portability problems by eschewing 'extern inline' functions.
130 The trivial performance wins aren't worth the portability hassles; see
131 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
133 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
134 (window_box_width, window_box_left, window_box_left_offset)
135 (window_box_right, window_box_right_offset): Undo previous change,
136 by removing the "extern"s.
137 * intervals.c (adjust_intervals_for_insertion)
138 (adjust_intervals_for_deletion): Undo previous change,
139 making these static again.
140 (offset_intervals, temp_set_point_both, temp_set_point)
141 (copy_intervals_to_string): No longer inline.
142 * xdisp.c (window_text_bottom_y, window_box_width)
143 (window_box_height, window_box_left_offset)
144 (window_box_right_offset, window_box_left, window_box_right)
145 (window_box): No longer inline.
147 2011-11-08 Chong Yidong <cyd@gnu.org>
149 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
150 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
151 an error if not a live window.
152 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
153 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
155 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
157 * lisp.h (syms_of_abbrev): Remove declaration.
158 Reported by CHENG Gao <chenggao@royau.me>.
160 2011-11-07 Eli Zaretskii <eliz@gnu.org>
162 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
163 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
164 of temacs in GUI mode.
166 2011-11-07 Martin Rudalics <rudalics@gmx.at>
168 * window.h: Declare delete_all_child_windows instead of
169 delete_all_subwindows.
170 * window.c (Fwindow_nest, Fset_window_nest)
171 (Fset_window_new_total, Fset_window_new_normal)
172 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
173 (delete_all_subwindows): Rename to delete_all_child_windows.
174 (Fdelete_other_windows_internal, Fset_window_configuration):
175 Call delete_all_child_windows instead of delete_all_subwindows.
176 * frame.c (delete_frame): Call delete_all_child_windows instead
177 of delete_all_subwindows.
179 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
181 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
182 This is also needed for porting to any host where GC_MARK_STACK is
183 not GC_MAKE_GCPROS_NOOPS.
184 (which_symbols): Use it.
186 2011-11-07 Kenichi Handa <handa@m17n.org>
188 * coding.c (coding_set_destination): Check coding->src_pos only
189 when coding->src_object is a buffer (bug#9910).
191 * process.c (send_process): Set the member src_multibyte of coding
192 to 0 (bug#9911) when sending a unibyte text.
194 * callproc.c (Fcall_process): Set the member src_multibyte of
195 process_coding to 0 (bug#9912).
197 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
199 * xmenu.c (cleanup_widget_value_tree): New function.
200 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
201 calling free_menubar_widget_value_tree directly (Bug#9830).
203 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
205 Fix some portability problems with 'inline'.
206 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
207 (window_box_width, window_box_left, window_box_left_offset)
208 (window_box_right, window_box_right_offset): Declare extern.
209 Otherwise, these inline functions do not conform to C99 and
210 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
211 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
212 * intervals.c (adjust_intervals_for_insertion)
213 (adjust_intervals_for_deletion): Now extern, because otherwise the
214 extern inline functions 'offset_intervals' couldn't refer to it.
215 (static_offset_intervals): Remove.
216 (offset_intervals): Rewrite using the old contents of
217 static_offset_intervals. The old version didn't conform to C99
218 because an extern inline function contained a reference to an
219 identifier with static linkage.
221 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
223 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
226 2011-11-06 Eli Zaretskii <eliz@gnu.org>
228 * xdisp.c (init_iterator, reseat_to_string): Don't set the
229 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
230 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
231 return Qleft_to_right.
233 2011-11-06 Chong Yidong <cyd@gnu.org>
235 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
236 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
237 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
238 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
239 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
240 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
241 (Fwindow_vscroll): Doc fix.
242 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
243 argument, since it makes no sense to pass a live window and for
244 consistency with window-child.
246 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
248 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
251 2011-11-05 Jason Rumney <jasonr@gnu.org>
253 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
254 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
256 (add_font_entity_to_list): Fix logic errors in mixed boolean and
257 bitwise arithmetic preventing use of unicode-sip and non-truetype
260 2011-11-05 Eli Zaretskii <eliz@gnu.org>
262 * s/ms-w32.h (fstat, stat, utime): Move redirections to
265 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
266 initialization code to keep similarity to xfns.c after changes
269 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
271 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
272 (unwind_create_frame): New function (Bug#9943).
273 (Fx_create_frame): Restructure code to be more similar to the one in
274 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
275 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
276 Move terminal->reference_count++ just before making the frame official
279 * nsterm.m (x_free_frame_resources): New function.
280 (x_destroy_window): Move code to x_free_frame_resources.
282 * xfns.c (unwind_create_frame): Fix comment.
283 (Fx_create_frame, x_create_tip_frame): Move
284 terminal->reference_count++ just before making the frame
285 official. Move initialization of image_cache_refcount and
286 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
288 2011-11-05 Eli Zaretskii <eliz@gnu.org>
290 Support MSVC build with newer versions of Visual Studio.
291 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
292 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
295 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
296 which are not supported by MSVC.
297 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
298 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
300 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
302 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
304 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
306 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
308 Support MSVC build with newer versions of Visual Studio.
309 * w32.c: Don't include w32api.h for MSVC.
310 (init_environment) [_MSC_VER]: Call sys_access, not _access.
312 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
313 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
314 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
315 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
317 (alloca) [_MSC_VER]: Define to _alloca.
319 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
321 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
323 2011-11-04 Eli Zaretskii <eliz@gnu.org>
325 * xdisp.c (note_mouse_highlight): If either of
326 previous/next-single-property-change returns nil, treat that as
327 the beginning or the end of the buffer. (Bug#9955)
329 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
331 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
332 label is not null (Bug#9951).
333 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
336 2011-11-04 Eli Zaretskii <eliz@gnu.org>
338 * window.c (Fwindow_body_size): Mention in the doc string that the
339 return value is in frame's canonical units. (Bug#9949)
341 2011-11-03 Eli Zaretskii <eliz@gnu.org>
343 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
345 * w32fns.c (unwind_create_frame): If needed, free the glyph
346 matrices of the partially constructed frame. (Bug#9943)
347 * xfns.c (unwind_create_frame): Likewise.
349 2011-11-01 Eli Zaretskii <eliz@gnu.org>
351 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
352 Don't stop backward scan on the continuation glyph, even though
353 its CHARPOS is positive.
354 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
355 cover_string to disp_string.
357 2011-11-01 Martin Rudalics <rudalics@gmx.at>
359 * window.c (temp_output_buffer_show): Don't use
360 Vtemp_buffer_show_specifiers.
361 (Vtemp_buffer_show_specifiers): Remove unused variable.
363 2011-10-30 Eli Zaretskii <eliz@gnu.org>
365 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
366 past the beginning of the current glyph matrix.
368 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
370 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
371 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
372 HAVE_GTK3 (Bug#9869).
374 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
375 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
377 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
379 * xterm.c: Declare x_handle_net_wm_state to return int.
380 (handle_one_xevent): Check if we are iconified but don't have
381 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
382 (get_current_wm_state): Return non-zero if not hidden,
383 check for _NET_WM_STATE_HIDDEN (Bug#9893).
384 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
385 (x_handle_net_wm_state): Return what get_current_wm_state returns.
386 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
388 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
390 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
391 so that this new function doesn't get optimized away by a
392 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
394 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
396 * frame.h (MOUSE_HL_INFO): Remove excess parens.
398 2011-10-29 Eli Zaretskii <eliz@gnu.org>
400 Fix the `xbytecode' command.
401 * .gdbinit (xprintbytestr): New command.
402 (xwhichsymbols): Rename from `which'; all callers changed.
403 (xbytecode): Print the byte-code string as well.
405 2011-10-29 Kim Storm <storm@cua.dk>
407 * alloc.c (which_symbols): New function.
409 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
411 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
414 2011-10-29 Glenn Morris <rgm@gnu.org>
416 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
417 Not clear what it was for, and it causes various bugs. (Bug#9839)
419 2011-10-28 Eli Zaretskii <eliz@gnu.org>
421 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
422 possible random value that matches one of those tested as
423 condition to clear the mouse face.
425 2011-10-28 Chong Yidong <cyd@gnu.org>
427 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
429 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
431 * window.c (make_window): Initialize phys_cursor_on_p.
433 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
435 * lisp.h (struct Lisp_Symbol): Update comments.
437 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
439 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
441 2011-10-28 Eli Zaretskii <eliz@gnu.org>
443 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
444 <oslsachem@gmail.com> for helping to debug this.
446 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
447 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
448 (g_b_init_get_glyph_outline_w): New static variables.
449 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
450 (GetGlyphOutlineW_Proc): New typedefs.
451 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
452 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
454 (w32font_open_internal, compute_metrics):
455 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
456 instead of calling the "wide" APIs directly.
458 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
460 * w32.h (syms_of_w32font): Add prototype.
462 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
464 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
465 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
466 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
467 (Fmove_to_window_line): Doc fix.
469 2011-10-27 Chong Yidong <cyd@gnu.org>
471 * process.c (make_process): Set gnutls_state to NULL.
473 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
474 non-NULL, regardless of GNUTLS_INITSTAGE.
475 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
476 an error. Set process slots as soon as we allocate them.
478 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
480 2011-10-27 Chong Yidong <cyd@gnu.org>
482 * gnutls.c (emacs_gnutls_deinit): New function.
483 Deallocate credentials structures as well as calling gnutls_deinit.
484 (Fgnutls_deinit, Fgnutls_boot): Use it.
486 * process.c (make_process): Initialize GnuTLS credentials to NULL.
487 (deactivate_process): Call emacs_gnutls_deinit.
489 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
491 * image.c (x_create_x_image_and_pixmap):
492 * w32.c (sys_rename, w32_delayed_load):
493 * w32font.c (fill_in_logfont):
494 * w32reg.c (x_get_string_resource): Silence compiler warnings.
496 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
498 * w32fns.c (w32_default_color_map): New function,
499 extracted from Fw32_default_color_map.
500 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
502 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
504 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
506 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
508 * keyboard.c (test_undefined): New function (bug#9751).
509 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
511 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
513 * sysdep.c (init_sys_modes): Fix the check for the controlling
516 2011-10-20 Eli Zaretskii <eliz@gnu.org>
518 * dispextern.h (struct bidi_it): New member next_en_type.
520 * bidi.c (bidi_line_init): Initialize the next_en_type member.
521 (bidi_resolve_explicit_1): When next_en_pos is valid for the
522 current character, check also for next_en_type being WEAK_EN.
523 (bidi_resolve_weak): Don't enter the expensive loop if the current
524 position is before next_en_pos. Record the bidi type of the first
525 non-ET, non-BN character we find, in addition to its position.
526 (bidi_level_of_next_char): Invalidate next_en_type when
527 next_en_pos is over-stepped.
529 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
531 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
532 * editfns.c: Rewrite current-time-zone so that it invokes
533 the equivalent of (format-time-string "%Z") to get the time zone name.
534 This fixes a bug when the time zone name contains characters that
535 need converting from the system time locale to Emacs internal format.
536 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
537 that patch fixed format-time-string to do the conversion, but
538 I forgot to fix current-time-zone.
539 (format_time_string): New function, containing most of
540 what Fformat_time_string used to contain.
541 (Fformat_time_string): Rewrite in terms of format_time_string.
542 This doesn't change this function's behavior.
543 (current-time-zone): Rewrite to use format_time_string.
544 This fixes the bug reported by Michael Schierl in
545 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
546 Jason Rumney's 2007-06-07 change worked around this bug, but
548 * systime.h (tzname, timezone): Remove no-longer-used declarations.
550 2011-10-19 Eli Zaretskii <eliz@gnu.org>
552 * xdisp.c (start_display): If the character at POS is displayed
553 via a display vector, reset IT->current.dpvec_index to zero.
554 (try_window_reusing_current_matrix): If a line ends in a display
555 vector or the next line starts in a display vector, continue
556 redrawing the window even though the character position of
557 start_row was reached.
560 2011-10-18 Chong Yidong <cyd@gnu.org>
562 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
563 with nobreak-char-display too.
565 2011-10-18 Eli Zaretskii <eliz@gnu.org>
567 Fix part 3 of bug#9771.
568 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
569 (bidi_resolve_neutral): Don't enter the expensive loop looking for
570 non-neutral characters if the current character is a paragraph
571 separator (a.k.a. Newline). This avoids running the same
572 expensive loop twice, once when we consume the preceding newline
573 and the other time when the line actually needs to be displayed.
574 Avoid the loop when we see neutrals on the base embedding level
575 following a character whose directionality is the same as the
576 paragraph's. This avoids running the expensive loop when a line
577 ends in a long sequence of neutrals, like control characters.
578 Add assertion against STRONG_AL type. Slightly rearrange code
579 that determines the type of a neutral given the first non-neutral
581 (bidi_level_of_next_char): Set next_en_pos to zero when
582 invalidating its info.
584 2011-10-17 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (push_display_prop): Determine whether to record string
587 or buffer position by IT->string, not by IT->method. Allow
588 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
589 (move_it_vertically_backward): Don't look for character position
590 immediately after the newline when in a continuation line.
593 2011-10-15 Martin Rudalics <rudalics@gmx.at>
595 * window.c (coordinates_in_window): Rewrite and delabelize
596 vertical border check. (Bug#5357) (Bug#9618)
598 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
600 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
601 errors in XSetWindowBorder (bug#9310).
603 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
605 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
606 avoid crash when xmalloc overrun checking is enabled.
608 2011-10-13 Eli Zaretskii <eliz@gnu.org>
610 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
611 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
612 cursor motion with <left> and <right> arrow keys.
614 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
615 some callers set that themselves.
617 2011-10-12 Eli Zaretskii <eliz@gnu.org>
619 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
620 display string and the previous row comes from the same string and
621 is empty. (Bug#9739) (Bug#9738)
623 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
625 * doc.c (get_doc_string): Encode file name (bug#9735).
627 2011-10-12 Eli Zaretskii <eliz@gnu.org>
629 * bidi.c (bidi_level_of_next_char):
630 * xdisp.c (get_visually_first_element): Remove old incorrect
631 comments regarding the Unicode Line Separator character.
633 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
635 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
637 * alloc.c (Fgc_status): Do not access beyond zombies array
638 boundary if nzombies > MAX_ZOMBIES.
639 * alloc.c (dump_zombies): Add missing format specifier.
641 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
643 * xdisp.c (set_cursor_from_row): Simplify conditionals,
644 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
646 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
647 Some packages use them to denote characters with modifiers.
649 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
651 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
652 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
653 matching a pp-number. Rename parameter var to var1.
655 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
657 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
659 2011-10-08 Glenn Morris <rgm@gnu.org>
661 * callint.c (Fcall_interactively): Give a more explicit error for the
662 'c' case with a non-character input. (Bug#8479)
664 2011-10-08 Eli Zaretskii <eliz@gnu.org>
666 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
668 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
669 lines that are hscrolled on the left.
671 * dispnew.c (buffer_posn_from_coords): Account for a possible
672 presence of header-line. (Bug#4426)
674 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
676 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
677 Don't advertise functionality which we discourage or doesn't work.
679 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
681 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
682 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
683 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
684 this makes Emacs dump core during garbage collection on rare
685 occasions. sizeof is obviously inferior to offsetof here, so
687 (GC_POINTER_ALIGNMENT): New macro.
688 (mark_memory): Omit 3rd (offset) arg; caller changed.
689 Don't assume EMACS_INT alignment is the same as pointer alignment.
691 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
693 * keyboard.c (read_key_sequence_remapped): New var.
694 (read_key_sequence): Compute remapping in the right buffer.
695 (command_loop_1): Use read_key_sequence's remapping directly.
697 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
699 * dired.c (file_name_completion): Don't expand file name.
700 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
701 before checking file name handler.
703 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
704 they've been requested explicitly (bug#9591).
706 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
708 * keymap.c (Fsingle_key_description): Use make_specified_string
709 instead of build_string to build string from push_key_description.
712 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
714 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
715 This fixes a Y2038 bug on 64-bit hosts.
716 * buffer.c (reset_buffer):
717 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
718 (Fclear_buffer_auto_save_failure):
719 Use 0, not -1, to represent an unset failure time, since time_t
722 Remove dependency on glibc malloc internals.
723 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
724 Move back here from lisp.h, but with their new implementations.
725 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
726 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
727 * charset.c (charset_table_init): New static var.
728 (syms_of_charset): Use it instead of xmalloc. This removes a
729 dependency on glibc malloc internals. See Eli Zaretskii's comment in
730 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
731 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
732 Move back to alloc.c.
733 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
734 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
736 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
738 * nsterm.m (windowDidResize): Call x_set_window_size only when
739 ns_in_resize is true. Otherwise set pixelwidth/height and
740 call change_frame_size (Bug#9628).
742 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
744 Port --enable-checking=all to Fedora 14 x86-64.
745 * charset.c (syms_of_charset): Also account for glibc malloc's
746 internal overhead when calculating the initial malloc maximum.
748 Port --enable-checking=all to Fedora 14 x86.
749 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
751 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
752 (overrun_check_realloc, overrun_check_free):
753 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
754 That way, xmalloc returns a properly-aligned pointer even if
755 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
756 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
757 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
758 into account when calculating the initial malloc maximum.
759 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
760 Move here from alloc.c, so that charset.c can use it too.
761 Properly align; the old code wasn't right for common 32-bit hosts
762 when configured with --enable-checking=all.
763 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
764 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
766 2011-09-29 Eli Zaretskii <eliz@gnu.org>
768 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
771 2011-09-28 Eli Zaretskii <eliz@gnu.org>
773 * xdisp.c (compute_display_string_end): If there's no display
774 string at CHARPOS, return -1.
776 * bidi.c (bidi_fetch_char): When compute_display_string_end
777 returns a negative value, treat the character as a normal
778 character not covered by a display string. (Bug#9624)
780 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
782 * lread.c (Fread_from_string): Fix typo in docstring.
784 2011-09-27 Eli Zaretskii <eliz@gnu.org>
786 * xdisp.c (handle_invisible_prop): If invisible text ends on a
787 newline, reseat the iterator instead of bidi-iterating there one
788 character at a time. (Bug#9610)
789 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
790 TO_CHARPOS if the bidi iterator is at base embedding level.
792 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
794 * lread.c (readevalloop): Use correct code for NBSP.
795 (read1): Likewise. (Bug#9608)
797 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
799 * dbusbind.c (Fdbus_register_signal): When service is not
800 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
802 2011-09-25 Glenn Morris <rgm@gnu.org>
804 * buffer.c (truncate-lines): Doc fix.
806 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
808 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
809 (Fset_window_next_buffers): Doc fix.
811 2011-09-24 Glenn Morris <rgm@gnu.org>
813 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
815 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
817 Fix minor problems found by static checking.
818 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
819 * indent.c (Fvertical_motion): Fix == vs = typo.
821 2011-09-24 Eli Zaretskii <eliz@gnu.org>
823 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
824 Default value is now t. Doc fix.
826 * indent.c (Fvertical_motion): Compute and apply the overshoot
827 logic when moving up, not only when moving down. Fix the
828 confusing name and values of the it_overshoot_expected variable;
829 logic changes accordingly. (Bug#9254) (Bug#9549)
831 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
832 CHARPOS is covered by a display string which includes newlines.
833 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
834 is covered by a display string with embedded newlines.
836 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
838 * dbusbind.c (Fdbus_register_signal): Add match rule to
839 Vdbus_registered_objects_table. (Bug#9581)
840 (Fdbus_register_method, Vdbus_registered_objects_table):
843 2011-09-24 Jim Meyering <meyering@redhat.com>
845 do not ignore write error for any output size
846 The previous change was incomplete.
847 While it makes emacs --batch detect the vast majority of stdout
848 write failures, errors were still ignored whenever the output size is
849 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
850 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
851 && echo FAIL: ignored write error
852 FAIL: ignored write error
853 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
854 && echo FAIL: ignored write error
855 FAIL: ignored write error
856 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
858 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
860 * emacs.c (Fkill_emacs): In noninteractive mode exit
861 non-successfully if a write error occurred on stdout. (Bug#9574)
863 2011-09-21 Eli Zaretskii <eliz@gnu.org>
865 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
868 * dispextern.h (struct it): Update the comment documenting what
871 2011-09-20 Eli Zaretskii <eliz@gnu.org>
873 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
874 a display string, extend search for cursor position to end of row.
875 (find_row_edges): If the row ends in a newline from a display
876 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
877 Handle the case of a display string with multiple newlines.
878 (Fcurrent_bidi_paragraph_direction): Fix search for previous
879 non-empty line. Fixes confusing cursor motion with arrow keys at
880 the beginning of a line that starts with whitespace.
882 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
884 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
887 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
889 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
892 2011-09-18 Eli Zaretskii <eliz@gnu.org>
894 * xdisp.c (display_line): Record maximum and minimum buffer
895 positions even if no glyphs were produced (e.g., by a zero-width
896 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
897 buffer positions that will be removed from the glyph row because
899 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
900 column is beyond frame width: don't subtract 1 "pixel" when
901 computing width of the stretch.
902 (reseat_at_next_visible_line_start): Undo the change made on
903 2011-09-17 that saved paragraph information and restored it after
904 the call to `reseat'. (Bug#9545)
906 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
908 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
909 and turn window cursor on if cleared (Bug#9415).
911 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
913 * search.c (boyer_moore): Take unibyte characters from pattern
914 literally. (Bug#9458)
916 2011-09-18 Eli Zaretskii <eliz@gnu.org>
918 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
920 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
922 Fix minor problem found by static checking.
923 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
924 initialized, to pacify gcc -Wuninitialized.
926 * fileio.c: Report proper errno when syscall falls.
927 (Finsert_file_contents): Save and restore errno,
928 so that report_file_error outputs the correct diagnostic.
929 (Fwrite_region) [CLASH_DETECTION]: Likewise.
931 2011-09-18 Eli Zaretskii <eliz@gnu.org>
933 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
935 2011-09-17 Eli Zaretskii <eliz@gnu.org>
937 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
938 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
940 2011-09-17 Eli Zaretskii <eliz@gnu.org>
942 * xdisp.c (reseat_at_next_visible_line_start): Keep information
943 about the current paragraph and restore it after the call to reseat.
945 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
946 (bidi_find_paragraph_start): Search back for paragraph beginning
947 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
948 (bidi_move_to_visually_next): Only trigger paragraph-related
949 computations when the last character is a newline or at EOB, not
950 just any NEUTRAL_B. (Bug#9470)
952 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
953 truncated lines if point is covered by a display string. (Bug#9524)
955 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
957 * xselect.c: Relax test for outgoing X longs (Bug#9498).
958 (cons_to_x_long): New function.
959 (lisp_data_to_selection_data): Use it. Correct the test for
960 short-versus-long data; it was negated. Break out of vector
961 loop, for efficiency, when a long datum is discovered.
963 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
965 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
967 2011-09-16 Eli Zaretskii <eliz@gnu.org>
969 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
970 GCC PR/17406) by declaring this function with external scope.
972 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
974 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
975 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
977 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
979 * editfns.c (Fformat): Correctly handle text properties on "%%".
981 2011-09-15 Eli Zaretskii <eliz@gnu.org>
983 * xterm.c (x_draw_composite_glyph_string_foreground):
984 * w32term.c (x_draw_composite_glyph_string_foreground):
985 * term.c (encode_terminal_code):
986 * composite.c (composition_update_it, get_composition_id):
987 * xdisp.c (get_next_display_element)
988 (fill_composite_glyph_string): Add comments about special meaning
989 of TAB characters in a composition.
991 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
993 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
994 This occurs when processing a multibyte format.
995 Problem reported by Wolfgang Jenker.
997 2011-09-15 Johan Bockgård <bojohan@gnu.org>
999 * xdisp.c (try_cursor_movement): Only check for exact match if
1000 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1002 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1004 Remove unused external symbols.
1005 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1006 * xdisp.c (calc_pixel_width_or_height): Now static.
1007 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1008 * indent.c (check_display_width):
1009 * w32term.c: Fix comment to match code.
1010 * xterm.c, xterm.h (x_catching_errors): Remove.
1012 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1014 * xselect.c: Use signed conversions more consistently (Bug#9498).
1015 (selection_data_to_lisp_data): Assume incoming selection data are
1016 signed integers, not unsigned. This is to be consistent with
1017 outgoing selection data, which was modified to use signed integers
1018 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1019 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1020 expects long, not unsigned long.
1022 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1024 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1025 computation of loop end. Reported by Johan Bockgård
1028 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1030 * frame.c (Fother_visible_frames_p): Function deleted.
1032 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1034 * indent.c (compute_motion): Process display vector front to back
1035 rather than the other way around. (Bug#2496)
1037 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1039 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1041 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1043 * minibuf.c (Fread_from_minibuffer): Doc fix.
1045 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1047 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1048 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1050 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1052 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1053 value for non-existent files.
1055 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1057 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1058 set its "size" to -1. This will set the modtime_size field of
1059 the corresponding buffer to -1, which is what
1060 verify-visited-file-modtime expects for files that do not exist.
1063 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1065 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1067 * lisp.h: ... from here. push_key_description is no longer
1068 defined in keyboard.c, so its declaration should not be in
1069 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1070 logically belongs with push_key_description.
1072 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1074 * buffer.h: Include <sys/types.h> instead of <time.h>.
1075 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1076 Problem reported by Herbert J. Skuhra.
1078 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1080 * xml.c (parse_region): Make the parsing work for
1081 non-comment-starting XML files again (bug#9144).
1083 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1085 * image.c (gif_load): Fix calculation of bottom and right corner.
1088 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1090 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1091 redisplay in small windows.
1093 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1095 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1097 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1099 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1100 Operate on live windows only.
1102 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1104 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1106 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1108 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1109 only under bidi iteration.
1111 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1113 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1115 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1117 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1118 Without this fix, the command to link temacs failed due to an
1119 undefined symbol __builtin_isnan. This is because
1120 /usr/include/iso/math_c99.h #defines isnan(x) to
1121 __builtin_isnan(x), but the bundled gcc, which identifies itself
1122 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1124 * floatfns.c (isnan): #undef, and then #define to a clone of
1126 (Fisnan): Always define, since it's always available now.
1127 (syms_of_floatfns): Always define isnan at the Lisp level.
1129 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1131 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1133 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1135 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1136 The previous code assumed that file offsets (off_t values) fit in
1137 EMACS_INT variables, which is not true on typical 32-bit hosts.
1138 The code messed up by falsely reporting buffer overflow in cases
1139 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1140 when "big" contains more than 2**29 bytes, even though this
1141 inserts just one byte and does not overflow the buffer.
1142 (Finsert_file_contents): Store file offsets as off_t
1143 values, not as EMACS_INT values. Check for overflow when
1144 converting between EMACS_INT and off_t. When checking for
1145 buffer overflow or for overlap, take the offsets into account.
1146 Don't use EMACS_INT for small values where int suffices.
1147 When checking for overlap, fix a typo: ZV was used where
1148 ZV_BYTE was intended.
1149 (Fwrite_region): Don't assume off_t fits into 'long'.
1150 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1152 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1154 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1156 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1158 sprintf-related integer and memory overflow issues (Bug#9412).
1160 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1161 (esprintf, exprintf, evxprintf): New functions.
1162 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1163 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1164 (modify_event_symbol): Do not assume that the length of
1165 name_alist_or_stem is safe to alloca and fits in int.
1166 (Fexecute_extended_command): Likewise for function name and binding.
1167 (Frecursion_depth): Wrap around reliably on integer overflow.
1168 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1169 since some callers pass EMACS_INT values.
1170 (Fsingle_key_description): Don't crash if symbol name contains more
1171 than MAX_ALLOCA bytes.
1172 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1173 (get_minibuffer): Arg is now EMACS_INT, not int.
1174 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1175 (esprintf, exprintf, evxprintf): New decls.
1176 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1178 * dbusbind.c (signature_cat): New function.
1179 (xd_signature, Fdbus_register_signal):
1180 Do not overrun buffer; instead, report string overflow.
1182 * dispnew.c (add_window_display_history): Don't overrun buffer.
1183 Truncate instead; this is OK since it's just a log.
1185 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1186 even if the time zone offset is outlandishly large.
1187 Don't mishandle offset == INT_MIN.
1189 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1190 when creating daemon; the previous buffer-overflow check was incorrect.
1192 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1193 which has the guts of the old verror function.
1195 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1196 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1198 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1199 (font_unparse_xlfd): Don't blindly alloca long strings.
1200 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1201 fits in int, when using sprintf. Use single snprintf to count
1202 length of string rather than counting it via multiple sprintfs;
1203 that's simpler and more reliable.
1204 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1205 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1206 sprintf, in case result does not fit in int.
1208 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1209 (fontset_from_font): Print it.
1211 * frame.c (tty_frame_count): Now printmax_t, not int.
1212 (make_terminal_frame, set_term_frame_name): Print it.
1213 (x_report_frame_params): In X, window IDs are unsigned long,
1214 not signed long, so print them as unsigned.
1215 (validate_x_resource_name): Check for implausibly long names,
1216 and don't assume name length fits in 'int'.
1217 (x_get_resource_string): Don't blindly alloca invocation name;
1218 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1221 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1222 (xg_check_special_colors, xg_set_geometry):
1223 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1225 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1226 Use esprintf, not sprintf, in case result does not fit in int.
1228 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1229 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1230 it as a large positive number.
1231 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1232 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1234 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1235 in case result does not fit in int.
1237 * print.c (float_to_string): Detect width overflow more reliably.
1238 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1239 buffer overrun. Don't assume list length fits in 'int'. Treat
1240 print length of 0 as 0, not as infinity; to be consistent with other
1241 uses of print length in this function. Don't overflow print length
1242 index. Don't assume hash table size fits in 'long', or that
1243 vectorlike size fits in 'unsigned long'.
1245 * process.c (make_process): Use printmax_t, not int, to format
1246 process-name gensyms.
1248 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1250 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1251 to avoid potential buffer overrun.
1253 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1254 if X resource line is longer than 512 bytes.
1256 * xfns.c (x_window): Make sprintf buffer a bit bigger
1257 to avoid potential buffer overrun.
1259 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1261 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1263 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1265 Integer overflow fixes for scrolling, etc.
1266 Without these, Emacs silently mishandles large integers sometimes.
1267 For example, "C-u 4294967297 M-x recenter" was treated as if
1268 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1270 * xdisp.c (try_window_id): Check Emacs fixnum range before
1271 converting to 'int'.
1273 * window.c (window_scroll_line_based, Frecenter):
1274 Check that an Emacs fixnum is in range before assigning it to 'int'.
1275 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1276 values converted from Emacs fixnums.
1277 (Frecenter): Don't wrap around a line count if it is out of 'int'
1278 range; instead, treat it as an extreme value.
1279 (Fset_window_configuration, compare_window_configurations):
1280 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1282 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1283 that can exceed INT_MAX. Check that EMACS_INT value is in range
1284 before assigning it to the (possibly-narrower) index.
1285 (match_limit): Don't assume that a fixnum can fit in 'int'.
1287 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1290 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1291 (Fvertical_motion): Don't wrap around LINES values that don't fit
1292 in 'int'. Instead, treat them as extreme values. This is good
1293 enough for windows, which can't have more than INT_MAX lines anyway.
1295 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1297 * Require libxml/parser.h to avoid compilation warning.
1299 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1301 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1302 since this reportedly can destroy thread storage.
1304 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1306 * syntax.c (find_defun_start): Update all cache variables if
1307 exiting early (Bug#9401).
1309 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1311 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1313 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1314 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1315 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1317 * term.c (tty_append_glyph): New function.
1318 (produce_stretch_glyph): Static function and its prototype deleted.
1320 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1323 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1325 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1326 when checking :margin (Bug#9390).
1327 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1328 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1329 so that the name doesn't mislead. All uses changed.
1331 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1333 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1336 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1338 * xdisp.c (move_it_to): Don't bail out early when reaching
1339 position beyond to_charpos, if we are scanning backwards.
1340 (move_it_vertically_backward): When DY == 0, make sure we get to
1341 the first character in the line after the newline.
1343 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1345 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1346 (ccl_driver): Do not generate an out-of-range pointer.
1347 (Fccl_execute_on_string): Remove unnecessary check for
1348 integer overflow, noted by Stefan Monnier in
1349 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1350 Remove a FIXME that didn't need fixing.
1351 Simplify the newly-introduced buffer reallocation code.
1353 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1355 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1357 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1359 Integer and memory overflow issues (Bug#9196).
1361 * doc.c (get_doc_string): Rework so that
1362 get_doc_string_buffer_size is the actual buffer size, rather than
1363 being 1 less than the actual buffer size; this makes xpalloc more
1366 * image.c (x_allocate_bitmap_record, cache_image):
1367 * xselect.c (Fx_register_dnd_atom):
1368 Simplify previous changes by using xpalloc.
1370 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1371 since either will do and ptrdiff_t is convenient with xpalloc.
1373 * charset.c (charset_table_size)
1374 (struct charset_sort_data.priority): Now ptrdiff_t.
1375 (charset_compare): Don't overflow if priorities differ greatly.
1376 (Fsort_charsets): Don't assume list length fits in int.
1377 Check for size-calculation overflow when allocating sort data.
1378 (syms_of_charset): Allocate an initial charset table that is
1379 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1381 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1383 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1384 The actual value is always <= INT_MAX, and leaving it unsigned made
1385 overflow checking harder.
1387 * dispextern.h (struct glyph_matrix.rows_allocated)
1388 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1389 with xpalloc. The values are still always <= INT_MAX.
1391 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1393 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1394 (SAFE_NALLOCA): New macro.
1396 * region-cache.c (struct boundary.pos, find_cache_boundary)
1397 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1398 (set_cache_region, invalidate_region_cache)
1399 (revalidate_region_cache, know_region_cache, region_cache_forward)
1400 (region_cache_backward, pp_cache):
1401 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1402 so that ptrdiff_t * can be passed to xpalloc.
1403 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1404 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1405 (pp_cache): Don't assume cache_len fits in int.
1406 * region-cache.h: Adjust extern decls to match.
1408 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1409 EMACS_INT, since either will do, for xpalloc.
1411 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1412 (xnmalloc, xnrealloc, xpalloc): New functions.
1414 * bidi.c (bidi_shelve_header_size): New constant.
1415 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1416 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1418 * bidi.c (bidi_cache_shrink):
1419 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1421 Don't update size of array until after memory allocation succeeds,
1422 because xmalloc/xrealloc may not return.
1423 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1424 now that we have proper integer overflow checking.
1425 (record_overlay_string, overlay_strings): Catch overflows when
1426 calculating size of overlay_str_buf.
1428 * callproc.c (Fcall_process): Check for size overflow when
1429 calculating size of args2.
1430 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1431 Normally we prefer signed values, but sticking with ptrdiff_t would
1432 require adding more-complicated checks.
1434 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1435 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1436 Redo buffer-overflow calculations to avoid integer overflow.
1437 Add a FIXME comment where memory seems to be over-allocated.
1439 * character.c (Fstring): Check for size-calculation overflow.
1441 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1442 unnecessary integer overflow. Check for size overflow.
1443 (encode_coding_object): Don't update size until xmalloc succeeds.
1445 * composite.c (get_composition_id): Check for overflow in glyph
1446 length calculations.
1448 Integer and memory overflow fixes for display code.
1449 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1450 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1451 (scrolling_window): Check for overflow in size calculations.
1452 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1453 Don't assume glyph table len fits in int.
1454 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1455 (row_table_size): Now ptrdiff_t, not int.
1456 (scrolling_window): Avoid overflow in size calculations.
1457 Don't update size until allocation succeeds.
1458 * fns.c (concat): Check for overflow in size calculations.
1459 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1460 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1461 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1463 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1464 (get_doc_string): Check for size calculation overflow.
1465 Don't update size until allocation succeeds.
1466 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1467 EMACS_INT, where ptrdiff_t will do.
1468 (Fsubstitute_command_keys): Check for string overflow.
1470 * editfns.c (set_time_zone_rule): Don't assume environment length
1472 (message_length): Now ptrdiff_t, not int.
1473 (Fmessage_box): Don't update size until allocation succeeds.
1474 Don't assume message length fits in int.
1475 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1477 * emacs.c (main): Do not reallocate argv, since there is a null at
1478 the end that can be overwritten, and this way there's no need to
1479 worry about size-calculation overflow.
1480 (sort_args): Check for size-calculation overflow.
1482 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1484 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1486 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1487 (x_set_scroll_bar_width, x_figure_window_size):
1488 Check for integer overflow.
1489 (x_set_alpha): Do not assume XINT fits in int.
1491 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1492 This is for the members text_lines, text_cols, total_lines, total_cols,
1493 where the system imposes an 'int' limit.
1495 * fringe.c (Fdefine_fringe_bitmap):
1496 Don't update size until alloc works.
1498 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1499 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1501 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1502 Check for size-calculation overflow.
1503 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1504 do, as we prefer signed integers.
1505 (id_to_widget.max_size, id_to_widget.used)
1506 (xg_store_widget_in_map, xg_remove_widget_from_map)
1507 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1508 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1509 Use and return ptrdiff_t, not int.
1510 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1511 * gtkutil.h: Change prototypes to match the above.
1513 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1514 are duplicate now that they've been promoted to lisp.h.
1515 (x_allocate_bitmap_record, x_alloc_image_color)
1516 (make_image_cache, cache_image, xpm_load):
1517 Don't update size until alloc is done.
1518 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1520 Check for size calculation overflow.
1521 (ct_colors_allocated_max): New constant.
1522 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1525 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1526 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1527 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1528 Use ptrdiff_t, not int, to count maps.
1529 (read_char_minibuf_menu_prompt): Check for overflow in size
1530 calculations. Don't update size until allocation succeeds.
1531 Redo calculations to avoid overflow.
1532 * keyboard.h: Change prototypes to match the above.
1534 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1536 (current_minor_maps): Check for size calculation overflow.
1537 * keymap.h: Change prototypes to match the above.
1539 * lread.c (read1, init_obarray): Don't update size until alloc done.
1541 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1542 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1544 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1545 Now ptrdiff_t, not int.
1546 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1547 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1549 * process.c (Fnetwork_interface_list): Check for overflow
1550 in size calculation.
1552 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1554 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1555 overflow. Don't bother calling xmalloc when xrealloc will do.
1557 * search.c (Freplace_match): Check for size calculation overflow.
1558 (Fset_match_data): Don't assume list lengths fit in 'int'.
1560 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1561 for command line length. Do not attempt to address one before the
1562 beginning of an array, as that's not portable.
1564 * term.c (max_frame_lines): Remove; unused.
1565 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1567 (encode_terminal_code, calculate_costs): Check for size
1568 calculation overflow.
1569 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1570 table lengths and related sizes. Don't update size until alloc
1571 done. Redo calculations to avoid overflow.
1572 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1574 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1575 subtracting pointers.
1576 (gobble_line): Check for overflow more carefully. Don't update size
1579 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1580 Don't update size until alloc done.
1581 Redo size calculations to avoid overflow.
1582 Check for size calculation overflow.
1583 (main) [DEBUG]: Fix typo in invoking tparam1.
1585 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1586 Use ptrdiff_t, not int, for sizes.
1587 (store_mode_line_noprop_char): Don't update size until alloc done.
1589 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1590 Use ptrdiff_t, not int, for sizes.
1591 (Finternal_make_lisp_face, cache_face):
1592 Check for size calculation overflow.
1593 (cache_face): Treat size calculation overflows as if they were
1594 memory exhaustion (the usual treatment), rather than aborting.
1596 * xfns.c (x_encode_text, x_set_name_internal)
1597 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1598 sizes, since they can exceed INT_MAX in size. Check for size
1599 calculation overflow.
1601 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1602 (xg_select): Check for size calculation overflow.
1603 Don't update size until alloc done.
1605 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1606 as sprintf is limited to int lengths.
1608 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1609 (X_LONG_MIN): New macros.
1610 Use them to make the following changes clearer.
1611 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1612 This change doesn't affect the value now, but it may help remind
1613 future maintainers not to raise the value too much later.
1614 (SELECTION_QUANTUM): Remove, replacing with ...
1615 (selection_quantum): ... new function, which avoids overflow.
1617 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1618 assumption that selection length fits in 'int'.
1619 (x_reply_selection_request, x_handle_selection_request)
1620 (x_get_window_property, receive_incremental_selection)
1621 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1622 (lisp_data_to_selection_data, clean_local_selection_data):
1623 Use ptrdiff_t, not int, to record length of selection.
1624 (x_reply_selection_request, x_get_window_property)
1625 (receive_incremental_selection, x_property_data_to_lisp):
1626 Redo calculations to avoid overflow.
1627 (x_reply_selection_request): When sending hint, ceiling it at
1628 X_LONG_MAX rather than relying on wraparound overflow to send
1630 (x_get_window_property, receive_incremental_selection)
1631 (lisp_data_to_selection_data, x_property_data_to_lisp):
1632 Check for size-calculation overflow.
1633 (x_get_window_property, receive_incremental_selection)
1634 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1635 Don't store size until memory allocation succeeds.
1636 (x_get_window_property): Plug memory leak on memory exhaustion.
1637 Don't double-block input; malloc is safe here. Don't assume 2**34
1638 - 4 fits in unsigned long. Add an xassert to check
1639 XGetWindowProperty overflow. Be more careful about overflow
1640 calculations, and distinguish size from memory overflow better.
1641 (receive_incremental_selection): When tracing, don't assume
1642 unsigned int is less than INT_MAX.
1643 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1644 harmful) conversions of unsigned short to int.
1645 (lisp_data_to_selection_data): Don't assume that integers
1646 in the range -65535 through -1 fit in an X unsigned short.
1647 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1648 result parameters unless successful. Rely on cons_to_unsigned
1649 to report problems with elements; the old code wasn't right anyway.
1650 (x_check_property_data): Check for int overflow; we cannot use
1651 a wider type due to X limits.
1652 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1654 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1656 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1657 (x_term_init): Check for size calculation overflow.
1658 (x_color_cells): Don't store size until memory allocation succeeds.
1659 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1660 Don't assume alloca size is less than MAX_ALLOCA.
1661 (x_term_init): Don't assume length fits in int (sprintf is limited
1664 Use ptrdiff_t for composition IDs.
1665 * character.c (lisp_string_width):
1666 * composite.c (composition_table_size, n_compositions)
1667 (get_composition_id, composition_gstring_from_id):
1668 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1669 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1670 * window.c (Frecenter):
1671 Use ptrdiff_t, not int, for composition IDs.
1672 * composite.c (get_composition_id): Check for integer overflow.
1673 * composite.h: Adjust prototypes to match the above changes.
1675 Use ptrdiff_t for hash table indexes.
1676 * category.c (hash_get_category_set):
1677 * ccl.c (ccl_driver):
1678 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1679 * coding.c (coding_system_charset_list, detect_coding_system):
1680 * coding.h (struct coding_system.id):
1681 * composite.c (get_composition_id, gstring_lookup_cache):
1682 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1683 * image.c (xpm_get_color_table_h):
1684 * lisp.h (hash_lookup, hash_put):
1685 * minibuf.c (Ftest_completion):
1686 Use ptrdiff_t for hash table indexes, not int (which is too
1687 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1688 32-bit --with-wide-int hosts).
1690 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1691 Add a FIXME comment about memory leaks.
1692 (syms_of_charset): Don't assume xmalloc returns.
1694 Don't assume that stated character widths fit in int.
1695 * character.c (Fchar_width, c_string_width, lisp_string_width):
1696 * character.h (CHAR_WIDTH):
1697 * indent.c (MULTIBYTE_BYTES_WIDTH):
1698 Use sanitize_char_width to avoid undefined and/or bad behavior
1699 with outlandish widths.
1700 * character.h (sanitize_tab_width): Rename from sanitize_width,
1701 now that we have two such functions. All uses changed.
1702 (sanitize_char_width): New inline function.
1704 Don't assume that tab-width fits in int.
1705 * character.h (sanitize_width): New inline function.
1706 (SANE_TAB_WIDTH): New macro.
1707 (ASCII_CHAR_WIDTH): Use it.
1708 * indent.c (sane_tab_width): Remove. All uses replaced by
1709 SANE_TAB_WIDTH (current_buffer).
1710 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1712 * fileio.c: Integer overflow issues with file modes.
1713 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1715 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1716 Remove unreachable code.
1717 (read_hex, load_charset_map_from_file): Check for integer overflow.
1719 * xterm.c: don't go over XClientMessageEvent limit
1720 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1721 (x_send_scroll_bar_event): Likewise. Check that the size does not
1722 exceed limits imposed by XClientMessageEvent, as well as the usual
1723 ptrdiff_t and size_t limits.
1725 * keyboard.c: Overflow, signedness and related fixes.
1726 (make_lispy_movement): Use same integer type in forward decl
1727 that is used in the definition.
1728 (read_key_sequence, keyremap_step):
1729 Change bufsize argument back to int, undoing my 2011-03-30 change.
1730 We prefer signed types, and int is wide enough here.
1731 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1732 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1733 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1734 length, not size_t. Use ptrdiff_t for index, not int.
1735 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1736 possibility of integer overflow.
1738 Overflow, signedness and related fixes for images.
1740 * dispextern.h (struct it.stack[0].u.image.image_id)
1741 (struct_it.image_id, struct image.id, struct image_cache.size)
1742 (struct image_cache.used, struct image_cache.ref_count):
1743 * gtkutil.c (update_frame_tool_bar):
1744 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1745 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1746 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1747 * nsmenu.m (update_frame_tool_bar):
1748 * xdisp.c (calc_pixel_width_or_height):
1749 * xfns.c (image_cache_refcount):
1750 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1751 on typical 64-bit hosts.
1753 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1754 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1755 Omit unnecessary casts to int.
1756 (parse_image_spec): Check that integers fall into 'int' range
1757 when the callers expect that.
1758 (image_ascent): Redo ascent calculation to avoid int overflow.
1759 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1760 (lookup_image): Remove unnecessary tests.
1761 (xbm_image_p): Locals are now of int, not EMACS_INT,
1762 since parse_image_check makes sure they fit into int.
1763 (png_load, gif_load, svg_load_image):
1764 Prefer int to unsigned where either will do.
1765 (tiff_handler): New function, combining the cores of the
1766 old tiff_error_handler and tiff_warning_handler.
1767 This function is rewritten to use vsnprintf and thereby avoid
1768 stack buffer overflows. It uses only the features of vsnprintf
1769 that are common to both POSIX and native Microsoft.
1770 (tiff_error_handler, tiff_warning_handler): Use it.
1771 (tiff_load, gif_load, imagemagick_load_image):
1772 Don't assume :index value fits in 'int'.
1773 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1774 (imagemagick_load_image): Check that crop parameters fit into
1775 the integer types that MagickCropImage accepts. Don't assume
1776 Vimagemagick_render_type has a nonnegative value. Don't assume
1777 size_t fits in 'long'.
1778 (gs_load): Use printmax_t to print the widest integers possible.
1779 Check for integer overflow when computing image height and width.
1781 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1783 * xdisp.c (redisplay_window): Don't force window start if point
1784 will be invisible in the resulting window. (Bug#9324)
1786 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1788 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1789 the display spec is of the form `(space ...)'.
1790 (handle_display_spec): Return the value returned by
1791 handle_single_display_spec, not just 1 or zero.
1792 (handle_single_display_spec): If the display spec is of the form
1793 `(space ...)', and specifies display in the text area, return 2
1795 (try_cursor_movement): Check for the need to scroll more
1796 accurately, and prefer exact match for point under bidi.
1797 Don't advance `row' beyond the last row of the window.
1799 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1800 into disp_prop; all users changed.
1802 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1803 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1804 for the text covered by the display property.
1806 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1808 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1809 Change return value to nil.
1810 (Frecord_buffer): Delete unused function.
1812 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1815 buffers, return left-to-right.
1816 (set_cursor_from_row): Consider candidate row a win if its glyph
1817 represents a newline and point is on that newline. Fixes cursor
1818 positioning on the newline at EOL of R2L text within L2R
1819 paragraph, and vice versa.
1820 (try_cursor_movement): Check continued rows, in addition to
1821 continuation rows. Fixes unwarranted scroll when point enters a
1822 continued line of R2L text within an L2R paragraph, or vice versa.
1823 (cursor_row_p): Consider the case of point being equal to
1824 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1825 from the end of a short line to the beginning of a continued line
1826 of R2L text within L2R paragraph.
1827 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1828 composed characters.
1830 * bidi.c (bidi_check_type): Use xassert.
1831 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1834 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1836 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1839 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1841 * nsfont.m (ns_otf_to_script): Fix typo.
1843 2011-08-22 Kenichi Handa <handa@m17n.org>
1845 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1846 extra slot even if the purpose is char-code-property-table.
1848 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1850 * xdisp.c (redisplay_window): When computing centering_position,
1851 account for the height of the header line. (Bug#8874)
1853 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1854 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1855 candidate is selected by the mouse, and that candidate has a
1856 composed character under the mouse.
1858 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1859 coordinates reported by pos-visible-in-window-p for a composed
1860 character in column zero.
1862 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1864 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1866 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1868 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1869 consider it a hit if to_charpos is anywhere in the range of the
1870 composed buffer positions.
1872 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1874 * image.c (gif_load): Don't assume that each subimage has the same
1875 dimensions as the base image. Handle disposal method that is
1876 "undefined" by the gif spec (Bug#9335).
1878 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1880 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1881 (Fcondition_case): Document `debug' symbol in error handler.
1883 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1885 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1886 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1887 from an Org mode buffer to a Speedbar frame.
1889 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1890 a composition, take its buffer position from IT->cmp_it.charpos.
1891 Fixes cursor positioning at the beginning of a line that begins
1892 with a composed character.
1894 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1896 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1897 character bidirectional type, use STRONG_L instead. Fixes crashes
1898 in a buffer produced by `describe-categories'.
1900 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1901 members before the level stack, so they would be saved and
1902 restored when copying iterator state. Fixes incorrect reordering
1903 around TABs covered by display properties.
1905 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1907 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1909 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1911 * eval.c (internal_condition_case, internal_condition_case_1)
1912 (internal_condition_case_2, internal_condition_case_n):
1913 Remove unnecessary aborts (Bug#9081).
1915 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1917 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1918 has no `load' handler, try opening the file locally. (Bug#9311)
1920 2011-08-16 Ken Brown <kbrown@cornell.edu>
1922 * gmalloc.c: Expand comment.
1924 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1926 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1927 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1929 2011-08-16 Ken Brown <kbrown@cornell.edu>
1931 Fix memory allocation problems in Cygwin build (Bug#9273).
1933 * unexcw.c ( __malloc_initialized): Declare external variable.
1934 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1936 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1938 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1940 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1942 [CYGWIN] (special_realloc): New function.
1943 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1944 requests to realloc storage in the static heap.
1946 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1948 * bidi.c (bidi_initialize): Remove unused local.
1950 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1953 * biditype.h: Remove file.
1954 * makefile.w32-in ($(BLD)/bidi.$(O)):
1955 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1957 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1959 * chartab.c: Improve commentary for the uniprop_table API.
1961 * bidi.c (bidi_paragraph_init): Support zero value of
1962 bidi_ignore_explicit_marks_for_paragraph_level.
1963 (bidi_initialize): Use uniprop_table instead of including
1964 biditype.h and bidimirror.h.
1966 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1967 coordinates of the iterator when restoring from ppos_it.
1970 2011-08-14 Kenichi Handa <handa@m17n.org>
1972 * process.c (create_process): Call setup_process_coding_systems
1973 after the pid of the process is set to -1 (Bug#8162).
1975 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1977 * xdisp.c (move_it_in_display_line_to): Don't invoke
1978 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1979 ppos_it. Fixes vertical cursor motion when line beginning is
1980 covered by an image. (Bug#9296)
1982 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1984 * nsterm.h (ns_run_ascript): Declare.
1985 (NSAPP_DATA2_RUNASSCRIPT): Define.
1987 * nsfns.m (as_script, as_result, as_status): New static variables.
1988 (ns_run_ascript): New function.
1989 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1990 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1991 the event loop. Get status from as_status (Bug#7276).
1993 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1994 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1995 the event loop (Bug#7276).
1997 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1999 * gnutls.c (QCgnutls_bootprop_priority)
2000 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2001 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2002 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2003 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2004 (QCgnutls_bootprop_verify_hostname_error)
2005 (QCgnutls_bootprop_callbacks_verify): Rename from
2006 Qgnutls_bootprop_..., all uses changed.
2008 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2011 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2013 * xfaces.c (Qframe_set_background_mode): Now static.
2014 * dispextern.h (Qframe_set_background_mode): Remove decl.
2016 * process.c (Fnetwork_interface_info): Declare local only if needed.
2018 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2020 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2021 (Fnetwork_interface_list): Allocate in increments of bytes instead
2022 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2023 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2025 (struct ifflag_def): notrailers is smart on OSX.
2026 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2027 Get hardware address with getifaddrs if available.
2029 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2031 * xdisp.c (iterate_out_of_display_property): xassert that
2032 IT->position is set to within IT->object's boundaries. Break from
2033 the loop as soon as EOB is reached; avoids infloops in redisplay
2034 when IT->position is set up wrongly due to some bug.
2035 Set IT->current to match the bidi iterator unconditionally.
2036 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2037 entry. Force push_it to save on the stack the current
2038 buffer/string position, to be restored by pop_it. Fix flags in
2039 the iterator structure wrt the object coming from a display
2040 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2041 properties. (Bug#9284)
2043 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2045 * fontset.c (fontset_get_font_group): Add proper type checks.
2048 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2050 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2051 and LC_VERSION_MIN_MACOSX.
2052 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2053 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2055 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2057 * xdisp.c (forward_to_next_line_start): Allow to use the
2058 no-display-properties-and-no-overlays under bidi display.
2059 Set disp_pos in the bidi iterator to avoid searches for display
2060 properties and overlays.
2062 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2064 * editfns.c (Fset_time_zone_rule): Document relationship with the
2067 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2068 the font entity extracted from the cache (Bug#8109).
2070 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2072 * composite.c (autocmp_chars): Don't reset point. That is done by
2073 restore_point_unwind (Bug#5984).
2075 2011-08-07 Juri Linkov <juri@jurta.org>
2077 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2078 to show the arg `TIME' instead of `TIMEVAL'.
2080 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2082 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2083 display property strides EOL and includes a newline, as in
2084 longlines-mode. (Bug#9254)
2085 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2086 word-wrap under bidirectional display. (Bug#9224)
2088 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2089 is non-zero, even if the data buffer is NULL. Fixes a crash in
2090 vertical-motion with longlines-mode. (Bug#9254)
2092 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2094 * bidi.c <bidi_cache_total_alloc>: Now static.
2095 (bidi_initialize): Initialize bidi_cache_total_alloc.
2097 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2100 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2101 amount allocated this far in `bidi_cache_total_alloc'.
2102 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2103 non-zero, only free the data buffer without restoring the cache
2104 contents. All callers changed.
2106 * dispextern.h (bidi_unshelve_cache): Update prototype.
2108 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2109 (move_it_in_display_line, move_it_to)
2110 (move_it_vertically_backward, move_it_by_lines): Replace the call
2111 to xfree to an equivalent call to bidi_unshelve_cache.
2112 (move_it_in_display_line_to): Fix logic of returning
2113 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2115 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2118 came from a string character with a `cursor' property. (Bug#9229)
2120 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2122 * Makefile.in (LIB_PTHREAD): New variable.
2123 (LIBES): Add LIB_PTHREAD (Bug#9216).
2125 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2126 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2128 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2130 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2132 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2134 * xterm.c (x_find_topmost_parent): New function.
2135 (x_set_frame_alpha): Find topmost parent window with
2136 x_find_topmost_parent and set the property there also (bug#9181).
2137 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2139 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2141 * callproc.c (Fcall_process): Avoid vfork clobbering
2142 the local vars buffer, coding_systems, current_dir.
2144 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2146 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2148 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2150 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2151 so that it is not optimized away.
2153 * xdisp.c (compute_display_string_pos): Remove unused local.
2155 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2157 Fix slow cursor motion and scrolling in large buffers with
2158 selective display, like Org Mode buffers. (Bug#9218)
2160 * dispextern.h (struct bidi_it): New member disp_prop_p.
2162 * xdisp.c: Remove one-slot cache of display string positions.
2163 (compute_display_string_pos): Accept an additional argument
2164 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2165 for a display string or property. If found, set DISP_PROP_P
2168 * bidi.c (bidi_fetch_char): Accept an additional argument
2169 DISP_PROP_P, and pass it to compute_display_string_pos.
2170 Only handle text covered by a display string if DISP_PROP_P is returned
2171 non-zero. All callers of bidi_fetch_char changed.
2173 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2175 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2177 2010-12-03 Don March <don@ohspite.net>
2179 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2180 last character M-[char] is translated to ESC [char] (bug#7541).
2182 2011-08-02 Kenichi Handa <handa@m17n.org>
2184 * lisp.h (uniprop_table): Extern it.
2186 * chartab.c (uniprop_table): Make it non-static.
2188 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2190 * xdisp.c (forward_to_next_line_start): Accept additional argument
2191 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2193 (reseat_at_next_visible_line_start): Use the bidi iterator state
2194 returned by forward_to_next_line_start to restore the state of
2195 it->bidi_it after backing up to previous newline. (Bug#9212)
2197 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2199 * regex.c (re_comp): Protoize.
2200 (re_exec): Fix return type.
2201 (regexec): Fix type of `ret'. (Bug#9203)
2203 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2205 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2206 This is needed if max-image-size is a floating-point number.
2208 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2210 * print.c (print_object): Print empty symbol as ##.
2212 * lread.c (read1): Read ## as empty symbol.
2214 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2216 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2217 setting frame foreground color (Bug#9175).
2218 (x_set_background_color): Likewise.
2220 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2221 contents (Bug#9176).
2222 (EmacsTooltip -init): Remove bezels and add shadows to
2225 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2226 or scroll bar (Bug#8470).
2228 * nsfont.m (nsfont_open): Remove assignment to voffset and
2229 unnecessary vars hshink, expand, hd, full_height, min_height.
2230 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2232 * nsterm.h (nsfont_info): Remove voffset field.
2234 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2236 Implement strike-through and overline on NextStep (Bug#8863).
2238 * nsfont.m (nsfont_open): Use underline position provided by font,
2239 instead of hard-coded value of 2.
2240 (nsfont_draw): Call ns_draw_text_decoration instead.
2242 * nsterm.h: Add declaration for ns_draw_text_decoration.
2244 * nsterm.m (ns_draw_text_decoration): New function for drawing
2245 underline, overline, and strike-through.
2246 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2247 ns_draw_text_decoration. Change treatment of cursor drawing to
2248 accommodate underlining, etc.
2250 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2252 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2255 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2257 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2258 Without this fix, if a signal arrives just after memory fills up,
2259 'malloc' might be invoked reentrantly.
2261 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2262 In other words, assume that every image size is allowed, on non-X
2263 hosts. This assumption is probably wrong, but it lets Emacs compile.
2265 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2267 * regex.c (re_iswctype): Convert return values to boolean.
2269 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2271 * xdisp.c (compute_display_string_pos): Don't use cached display
2272 string position if the buffer had its restriction changed.
2275 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2277 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2279 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2281 Integer signedness and overflow and related fixes. (Bug#9079)
2283 * bidi.c: Integer size and overflow fixes.
2284 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2285 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2286 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2287 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2288 (bidi_find_other_level_edge):
2289 Use ptrdiff_t instead of EMACS_INT where either will do.
2290 This works better on 32-bit hosts configured --with-wide-int.
2291 (bidi_cache_ensure_space): Check for size-calculation overflow.
2292 Use % rather than repeated addition, for better worst-case speed.
2293 Don't set bidi_cache_size until after xrealloc returns, because it
2295 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2296 (bidi_cache_ensure_space): Also check that the bidi cache size
2297 does not exceed that of the largest Lisp string or buffer. See Eli
2298 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2300 * alloc.c (__malloc_size_t): Remove.
2301 All uses replaced by size_t. See Andreas Schwab's note
2302 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2304 * image.c: Improve checking for integer overflow.
2305 (check_image_size): Assume that f is nonnull, since
2306 it is always nonnull in practice. This is one less thing to
2307 worry about when checking for integer overflow later.
2308 (x_check_image_size): New function, which checks for integer
2309 overflow issues inside X.
2310 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2311 This removes the need for a memory_full check.
2312 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2313 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2314 (xbm_read_bitmap_data): Change locals back to 'int', since
2315 their values must fit in 'int'.
2316 (xpm_load_image, png_load, tiff_load):
2317 Invoke x_create_x_image_and_pixmap earlier,
2318 to avoid much needless work if the image is too large.
2319 (tiff_load): Treat overly large images as if
2320 x_create_x_image_and_pixmap failed, not as malloc failures.
2321 (gs_load): Use x_check_image_size.
2323 * gtkutil.c: Omit integer casts.
2324 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2325 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2327 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2329 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2330 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2331 would wrongly return t on a 64-bit host.
2333 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2334 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2335 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2336 and therefore cause GCC to emit a bogus diagnostic in some cases.
2338 * image.c: Integer signedness and overflow and related fixes.
2339 This is not an exhaustive set of fixes, but it's time to
2340 record what I've got.
2341 (lookup_pixel_color, check_image_size): Remove redundant decls.
2342 (check_image_size): Don't assume that arbitrary EMACS_INT values
2343 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2344 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2345 (tiff_load, imagemagick_load_image):
2346 Check for overflow in size calculations.
2347 (x_create_x_image_and_pixmap): Remove unnecessary test for
2348 xmalloc returning NULL; that can't happen.
2349 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2350 (xpm_color_bucket): Use better integer hashing function.
2351 (xpm_cache_color): Don't possibly over-allocate memory.
2352 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2353 (gif_memory_source):
2354 Use ptrdiff_t, not int or size_t, to record sizes.
2355 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2356 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2357 either works, as we prefer signed integers.
2358 (tiff_read_from_memory, tiff_write_from_memory):
2359 Return tsize_t, not size_t, since that's what the TIFF API wants.
2360 (tiff_read_from_memory): Don't fail simply because the read would
2361 go past EOF; instead, return a short read.
2362 (tiff_load): Omit no-longer-needed casts.
2363 (Fimagemagick_types): Don't assume size fits into 'int'.
2365 Improve hashing quality when configured --with-wide-int.
2366 * fns.c (hash_string): New function, taken from sxhash_string.
2367 Do not discard information about ASCII character case; this
2368 discarding is no longer needed.
2369 (sxhash-string): Use it. Change sig to match it. Caller changed.
2370 * lisp.h: Declare it.
2371 * lread.c (hash_string): Remove, since we now use fns.c's version.
2372 The fns.c version returns a wider integer if --with-wide-int is
2373 specified, so this should help the quality of the hashing a bit.
2375 * emacs.c: Integer overflow minor fix.
2376 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2377 Define only if GNU_LINUX.
2378 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2380 * dispnew.c: Integer signedness and overflow fixes.
2381 Remove unnecessary forward decls, that were a maintenance hassle.
2382 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2384 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2385 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2386 (prepare_desired_row, line_draw_cost):
2387 Use int, not unsigned, where either works.
2388 (save_current_matrix, restore_current_matrix):
2389 Use ptrdiff_t, not size_t, where either works.
2390 (init_display): Check for overflow more accurately, and without
2391 relying on undefined behavior.
2393 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2394 Remove, replacing with the new symbols in lisp.h. All uses changed.
2395 * fileio.c (make_temp_name):
2396 * filelock.c (lock_file_1, lock_file):
2397 * xdisp.c (message_dolog):
2398 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2399 Use pMd etc. instead.
2400 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2401 replacing the pWIDE etc. symbols removed from editfns.c.
2403 * keyboard.h (num_input_events): Now uintmax_t.
2404 This is (very slightly) less likely to mess up due to wraparound.
2407 * buffer.c: Integer signedness fixes.
2408 (alloc_buffer_text, enlarge_buffer_text):
2409 Use ptrdiff_t rather than size_t when either will do, as we prefer
2412 * alloc.c: Integer signedness and overflow fixes.
2413 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2414 (__malloc_size_t): Default to size_t, not to int.
2415 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2416 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2417 Prefer ptrdiff_t to size_t when either would do, as we prefer
2419 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2420 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2421 Now const. Initialize with values that are in range even if char
2423 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2424 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2425 These functions do the right thing with sizes > 2**32.
2426 (check_depth): Now ptrdiff_t, not int.
2427 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2428 Adjust to new way of storing sizes. Check for size overflow bugs
2430 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2431 slightly wrong anyway, as it missed one instance of
2432 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2433 (refill_memory_reserve): Omit needless cast to size_t.
2434 (mark_object_loop_halt): Mark as externally visible.
2436 * xselect.c: Integer signedness and overflow fixes.
2437 (Fx_register_dnd_atom, x_handle_dnd_message):
2438 Use ptrdiff_t, not size_t, since we prefer signed.
2439 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2440 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2441 x_dnd_atoms_size and x_dnd_atoms_length.
2443 * doprnt.c: Prefer signed to unsigned when either works.
2445 * doprnt.c (doprnt):
2447 * xdisp.c (vmessage):
2448 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2449 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2450 prefer signed arithmetic to avoid comparison confusion.
2451 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2452 but is a bit tricky.
2454 Assume freestanding C89 headers, string.h, stdlib.h.
2455 * data.c, doprnt.c, floatfns.c, print.c:
2456 Include float.h unconditionally.
2457 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2458 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2459 * regex.c: Likewise for stddef.h, string.h.
2460 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2461 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2462 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2463 (STDC_HEADERS): Remove obsolete defines.
2464 * sysdep.c: Include limits.h unconditionally.
2466 Assume support for memcmp, memcpy, memmove, memset.
2467 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2468 * regex.c (memcmp, memcpy):
2469 Remove; we assume C89 now.
2471 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2472 (__malloc_safe_bcopy): Remove; no longer needed.
2474 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2475 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2476 well either way, and we prefer signed to unsigned.
2478 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2481 closes the connection while we're reading (bug#9182).
2483 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2485 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2486 are specified (Bug#9168).
2488 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2490 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2491 Found by GCC static checking and --with-wide-int on a 32-bit host.
2493 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2495 * xdisp.c (compute_display_string_pos): Fix logic of caching
2496 previous display string position. Initialize cached_prev_pos to
2497 -1. Fixes slow-down at the beginning of a buffer.
2499 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2501 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2502 for attrs[LFACE_FONTSET_INDEX].
2504 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2506 * xml.c (parse_region): Remove unused local
2507 that was recently introduced.
2509 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2511 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2512 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2514 * xdisp.c (move_it_in_display_line_to): Record the best matching
2515 position for TO_CHARPOS while scanning the line, and restore it on
2516 exit if none of the characters scanned was an exact match.
2517 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2518 when exact match is impossible due to invisible text, and the
2519 lines are truncated.
2521 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2523 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2526 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2528 Fix a significant slow-down of cursor motion with C-n, C-p,
2529 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2530 auto-repeat under bidi redisplay in fontified buffers.
2531 * xdisp.c (compute_stop_pos_backwards): New function.
2532 (next_element_from_buffer): Call compute_stop_pos_backwards to
2533 find a suitable prev_stop when we find ourselves before
2535 (reseat): Don't look for prev_stop, as that could mean a very long
2537 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2538 <cached_disp_overlay_modiff>: Cache for last found display string
2540 (compute_display_string_pos): Return the cached position if asked
2541 about the same buffer in the same area of character positions, and
2542 the buffer wasn't changed since the time the display string
2543 position was cached.
2545 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2547 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2548 is an integer, which is important for empty lines. (Bug#9149)
2550 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2552 * frame.c (Fmodify_frame_parameters): In tty case, update the
2553 default face if necessary (Bug#4238).
2555 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2557 * editfns.c (Fstring_to_char): No need to explain what a character
2558 is in the docstring (Bug#6576).
2560 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2562 * xml.c (parse_region): Make sure we always return a tree.
2564 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2566 * xml.c (parse_region): If a document contains only comments,
2569 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2571 * xml.c (make_dom): Return comments, too.
2573 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2576 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2577 and the surrounding thread.
2578 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2579 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2580 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2582 * s/openbsd.h (BROKEN_SIGIO): Define.
2583 * unexelf.c (unexec) [__OpenBSD__]:
2584 Don't update the .mdebug section of the Alpha COFF symbol table.
2586 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2588 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2591 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2593 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2594 This fixes some race conditions on the permissions of any newly
2597 * alloc.c (valid_pointer_p): Use pipe, not open.
2598 This fixes some permissions issues when debugging.
2600 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2601 If fchown fails to set both uid and gid, try to set just gid,
2602 as that is sometimes allowed. Adjust the file's mode to eliminate
2603 setuid or setgid bits that are inappropriate if fchown fails.
2605 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2607 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2608 to compare Lisp_Objects.
2609 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2610 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2611 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2613 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2615 * lread.c (read_integer): Unread even EOF character.
2616 (read1): Likewise. Properly record start position of symbol.
2618 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2619 symbol character follows.
2621 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2623 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2624 This works around a problem with the previous change to Fcopy_file.
2625 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2626 and without this change, GCC might complain about discarding
2627 fchown's return value.
2629 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2631 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2633 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2635 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2637 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2639 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2640 it's used from the C level.
2642 * process.c: Use the same condition for POLL_FOR_INPUT in both
2643 keyboard.c and process.c (bug#1858).
2645 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2647 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2648 (Fgnutls_boot): Use it.
2650 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2652 * doc.c (Fsubstitute_command_keys): Revert last change.
2654 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2656 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2657 quotes the next character, and doesn't affect other longer
2658 sequences (bug#8935).
2660 * lread.c (syms_of_lread): Clarify that is isn't only
2661 `eval-buffer' and `eval-defun' that's affected by
2662 `lexical-binding' (bug#8460).
2664 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2666 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2667 bidi redisplay when a line includes both an image and is truncated.
2669 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2671 Fix minor problems found by static checking.
2672 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2673 (elsz): Now a signed constant, not a size_t var. We prefer signed
2674 types to unsigned, to avoid integer comparison confusion. Without
2675 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2676 "cannot optimize loop, the loop counter may overflow", a symptom
2678 * indent.c (Fvertical_motion): Mark locals as initialized.
2679 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2681 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2683 * search.c (Fre_search_backward): Mention `case-fold-search' in
2684 all the re_search_* functions (bug#8138).
2686 * keyboard.c (Fopen_dribble_file): Document when the file is
2689 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2691 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2694 Support bidi reordering of display and overlay strings.
2695 * xdisp.c (compute_display_string_pos)
2696 (compute_display_string_end): Accept additional argument STRING.
2697 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2698 (reseat_to_string): Initialize bidi_it->string.s and
2699 bidi_it->string.schars.
2700 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2701 NULL (avoids a crash in bidi_paragraph_init).
2702 Initialize itb.string.lstring.
2703 (init_iterator): Call bidi_init_it only of a valid
2704 buffer position was specified. Initialize paragraph_embedding to
2706 (reseat_to_string): Initialize the bidi iterator.
2707 (display_string): If we need to ignore text properties of
2708 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2709 original value of -1 will not work with bidi.)
2710 (compute_display_string_pos): First arg is now struct
2711 `text_pos *'; all callers changed. Support display properties on
2713 (compute_display_string_end): Support display properties on Lisp
2715 (init_iterator, reseat_1, reseat_to_string): Initialize the
2716 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2717 when iterating on a string not from display properties).
2718 (compute_display_string_pos, compute_display_string_end):
2719 Fix calculation of the object to scan. Fixes an error when using
2721 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2722 base_level_stop; instead, set base_level_stop to BEGV.
2723 Fixes crashes in vertical-motion.
2724 (next_element_from_buffer): Improve commentary for when
2725 the iterator is before prev_stop.
2726 (init_iterator): Initialize bidi_p from the default value of
2727 bidi-display-reordering, not from buffer-local value. Use the
2728 buffer-local value only if initializing for buffer iteration.
2729 (handle_invisible_prop): Support invisible properties on strings
2730 that are being bidi-reordered.
2731 (set_iterator_to_next): Support bidi reordering of C strings and
2733 (next_element_from_string): Support bidi reordering of Lisp
2735 (handle_stop_backwards): Support Lisp strings as well.
2736 (display_string): Support display of R2L glyph rows.
2737 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2738 (init_iterator): Don't initialize it->bidi_p for strings
2740 (reseat_to_string): Initialize it->bidi_p for strings here.
2741 (next_element_from_string, next_element_from_c_string)
2742 (next_element_from_buffer): Add xassert's for correspondence
2743 between IT's object being iterated and it->bidi_it.string
2745 (face_before_or_after_it_pos): Support bidi iteration.
2746 (next_element_from_c_string): Handle the case of the first string
2747 character that is not the first one in the visual order.
2748 (get_visually_first_element): New function, refactored from common
2749 parts of next_element_from_buffer, next_element_from_string, and
2750 next_element_from_c_string.
2751 (tool_bar_lines_needed, redisplay_tool_bar)
2752 (display_menu_bar): Force left-to-right direction. Add a FIXME
2753 comment for making that be controlled by a user option.
2754 (push_it, pop_it): Save and restore the state of the
2755 bidi iterator. Save and restore the bidi_p flag.
2756 (pop_it): Iterate out of display property for string iteration as
2758 (iterate_out_of_display_property): Support iteration over strings.
2759 (handle_single_display_spec): Set up it->bidi_it for iteration
2760 over a display string, and call bidi_init_it.
2761 (handle_single_display_spec, next_overlay_string)
2762 (get_overlay_strings_1, push_display_prop): Set up the bidi
2763 iterator for displaying display or overlay strings.
2764 (forward_to_next_line_start): Don't use the shortcut if
2766 (back_to_previous_visible_line_start): If handle_display_prop
2767 pushed the iterator stack, restore the internal state of the bidi
2768 iterator by calling bidi_pop_it same number of times.
2769 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2770 and we are bidi-iterating, don't decrement the iterator position;
2771 instead, set the first_elt flag in the bidi iterator, to produce
2773 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2774 (push_display_prop): xassert that we are iterating a buffer.
2775 (push_it, pop_it): Save and restore paragraph_embedding member.
2776 (handle_single_display_spec, next_overlay_string)
2777 (get_overlay_strings_1, reseat_1, reseat_to_string)
2778 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2779 correctly. Don't assume unibyte strings are not bidi-reordered.
2780 (compute_display_string_pos)
2781 (compute_display_string_end): Fix handling the case of C string.
2782 (push_it, pop_it): Save and restore from_disp_prop_p.
2783 (handle_single_display_spec, push_display_prop): Set the
2784 from_disp_prop_p flag.
2785 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2786 (pop_it): Call iterate_out_of_display_property only if we are
2787 popping after iteration over a string that came from a display
2788 property. Fix a typo in popping stretch info. Add an assertion
2789 for verifying that the iterator position is in sync with the bidi
2791 (handle_single_display_spec, get_overlay_strings_1)
2792 (push_display_prop): Fix initialization of paragraph direction for
2793 string when that of the parent object is not yet determined.
2794 (reseat_1): Call bidi_init_it to resync the bidi
2795 iterator with IT's position. (Bug#7616)
2796 (find_row_edges): If ROW->start.pos gives position
2797 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2798 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2799 Reset the from_disp_prop_p flag.
2800 (SAVE_IT, RESTORE_IT): New macros.
2801 (pos_visible_p, face_before_or_after_it_pos)
2802 (back_to_previous_visible_line_start)
2803 (move_it_in_display_line_to, move_it_in_display_line)
2804 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2805 (try_scrolling, redisplay_window, display_line): Use them when
2806 saving a temporary copy of the iterator and restoring it back.
2807 (back_to_previous_visible_line_start, reseat_1)
2808 (init_iterator): Empty the bidi cache "stack".
2809 (move_it_in_display_line_to): If iterator ended up at
2810 EOL, but we never saw any buffer positions smaller than
2811 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2812 motion in bidi-reordered lines.
2813 (move_it_in_display_line_to): Record prev_method and prev_pos
2814 immediately before the call to set_iterator_to_next. Fixes cursor
2815 motion in bidi-reordered lines with stretch glyphs and strings
2816 displayed in margins. (Bug#8133) (Bug#8867)
2817 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2819 (pos_visible_p): Support positions in bidi-reordered lines.
2820 Save and restore bidi cache.
2822 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2823 (bidi_paragraph_info): Delete unused struct.
2824 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2825 (bidi_cache_start): New variable.
2826 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2828 (bidi_cache_fetch_state, bidi_cache_search)
2829 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2830 (bidi_cache_find, bidi_peek_at_next_level)
2831 (bidi_level_of_next_char, bidi_find_other_level_edge)
2832 (bidi_move_to_visually_next): Compare cache index with
2833 bidi_cache_start rather than with zero.
2834 (bidi_fetch_char): Accept new argument STRING; all callers
2835 changed. Support iteration over a string. Support strings with
2836 display properties. Support unibyte strings. Fix the type of
2837 `len' according to what STRING_CHAR_AND_LENGTH expects.
2838 (bidi_paragraph_init, bidi_resolve_explicit_1)
2839 (bidi_resolve_explicit, bidi_resolve_weak)
2840 (bidi_level_of_next_char, bidi_move_to_visually_next):
2841 Support iteration over a string.
2842 (bidi_set_sor_type, bidi_resolve_explicit_1)
2843 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2844 can now be zero (for strings); special values 0 and -1 were
2845 changed to -1 and -2, respectively.
2846 (bidi_char_at_pos): New function.
2847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2848 Call it instead of FETCH_MULTIBYTE_CHAR.
2849 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2850 initialized to valid values.
2851 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2853 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2854 the test for valid cached positions. Fix the logic for looking up
2855 the sentinel state in the cache. GCPRO the Lisp string we are
2857 (bidi_push_it, bidi_pop_it): New functions.
2858 (bidi_initialize): Initialize the bidi cache start stack pointer.
2859 (bidi_cache_ensure_space): New function, refactored from part of
2860 bidi_cache_iterator_state. Don't assume the required size is just
2861 one BIDI_CACHE_CHUNK away.
2862 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2863 (bidi_count_bytes, bidi_char_at_pos): New functions.
2864 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2865 always valid if bidi_cache_idx is valid.
2866 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2867 is valid if it's going to be used.
2868 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2869 (bidi_cache_fetch_state, bidi_cache_search)
2870 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2871 (bidi_cache_iterator_state, bidi_cache_find)
2872 (bidi_find_other_level_edge, bidi_cache_start_stack):
2873 All variables related to cache indices are now EMACS_INT.
2875 * dispextern.h (struct bidi_string_data): New structure.
2876 (struct bidi_it): New member `string'. Make flag members be 1-bit
2877 fields, and put them last in the struct.
2878 (compute_display_string_pos, compute_display_string_end):
2880 (bidi_push_it, bidi_pop_it): Add prototypes.
2881 (struct iterator_stack_entry): New members bidi_p,
2882 paragraph_embedding, and from_disp_prop_p.
2883 (struct it): Member bidi_p is now a bit field 1 bit wide.
2884 (bidi_shelve_cache, bidi_unshelve_cache):
2887 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2888 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2889 and vector-like objects.
2891 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2892 cache around display iteration.
2894 * window.c (Fwindow_end, window_scroll_pixel_based)
2895 (displayed_window_lines, Frecenter): Save and restore the bidi
2896 cache around display iteration.
2898 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2900 * editfns.c (Fdelete_region): Clarify the use of the named
2901 parameters (bug#6788).
2903 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2905 * indent.c (Fvertical_motion): Set and restore w->pointm when
2906 saving and restoring the window's buffer (Bug#9006).
2908 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2910 * editfns.c (Fstring_to_char): Clarify just what is returned
2911 (bug#6576). Text by Eli Zaretskii.
2913 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2915 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2917 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2919 * buffer.c (mmap_find): Fix a typo.
2921 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2923 Fix execution of x selection hooks.
2924 * xselect.c (Qx_lost_selection_functions)
2925 (Qx_sent_selection_functions): New vars.
2926 (syms_of_xselect): DEFSYM them.
2927 (x_handle_selection_request): Pass Qx_sent_selection_functions
2928 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2929 (x_handle_selection_clear,x_clear_frame_selections):
2930 Pass Qx_lost_selection_functions rather than
2931 Vx_lost_selection_functions to Frun_hook_with_args.
2933 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2935 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2936 The old code sometimes used this field without initializing it.
2938 * alloc.c (gc_sweep): Don't read past end of array.
2939 In theory, the old code could also have corrupted Emacs internals,
2940 though it'd be very unlikely.
2942 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2944 * character.c (Fcharacterp): Don't advertise optional ignored
2945 argument. (Bug#4026)
2947 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2949 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2952 * window.c (Fset_window_start): Doc fix (bug#4199).
2953 (Fset_window_hscroll): Ditto.
2955 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2957 Fix minor new problems caught by GCC 4.6.1.
2958 * term.c (init_tty): Remove unused local.
2959 * xsettings.c (store_monospaced_changed): Define this function only
2960 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2963 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2965 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2967 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2969 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2970 are the mini-buffer and the echo area (bug#3320).
2972 * term.c (init_tty): Remove support for supdup, c10 and perq
2973 terminals, which are no longer supported (bug#1482).
2975 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2977 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2979 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2981 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2982 for non-popups (Bug#3642).
2984 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2986 * alloc.c (reset_malloc_hooks): Protoize.
2987 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2988 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2989 * cm.c (losecursor): Likewise.
2990 * data.c (fmod): Likewise.
2991 * dispnew.c (swap_glyphs_in_rows): Likewise.
2992 * emacs.c (memory_warning_signal): Likewise.
2993 * floatfns.c (float_error): Likewise.
2994 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2995 (otf_open, font_otf_capability, generate_otf_features)
2996 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2998 * image.c (pbm_read_file): Likewise.
2999 * indent.c (string_display_width): Likewise.
3000 * intervals.c (check_for_interval, search_for_interval)
3001 (inc_interval_count, count_intervals, root_interval)
3002 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3003 * lread.c (defalias): Likewise.
3004 * ralloc.c (r_alloc_check): Likewise.
3005 * regex.c (set_image_of_range_1, set_image_of_range)
3006 (regex_grow_registers): Likewise.
3007 * sysdep.c (strerror): Likewise.
3008 * termcap.c (valid_filename_p, tprint, main): Likewise.
3009 * tparam.c (main): Likewise.
3010 * unexhp9k800.c (run_time_remap, save_data_space)
3011 (update_file_ptrs, read_header, write_header, calculate_checksum)
3012 (copy_file, copy_rest, display_header): Likewise.
3013 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3015 * xdisp.c (check_it): Likewise.
3016 * xfaces.c (register_color, unregister_color, unregister_colors):
3018 * xfns.c (print_fontset_result): Likewise.
3019 * xrdb.c (member, fatal, main): Likewise.
3021 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3023 Fix minor problems found by static checking (Bug#9031).
3024 * chartab.c (char_table_set_range, map_sub_char_table):
3025 Remove unused locals.
3026 (uniprop_table): Now static.
3027 * composite.c (_work_char): Remove unused static var.
3029 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3031 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3033 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3035 * gtkutil.c (qttip_cb): Remove code without function.
3037 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3039 * w32.c (pthread_sigmask): New stub.
3041 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3043 Use pthread_sigmask, not sigprocmask (Bug#9010).
3044 sigprocmask is portable only for single-threaded applications, and
3045 Emacs can be multi-threaded when it uses GTK.
3046 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3048 * callproc.c (Fcall_process):
3049 * process.c (create_process):
3050 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3051 Use pthread_sigmask, not sigprocmask.
3053 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3055 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3056 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3059 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3061 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3062 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3063 (xg_hide_tooltip): Fix comment.
3065 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3066 in registerServicesMenuSendTypes.
3067 (validRequestorForSendType): Don't check ns_return_types.
3069 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3072 2011-07-08 Jason Rumney <jasonr@gnu.org>
3074 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3075 SH_SHOW for hidden windows (Bug#5482).
3077 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3078 frame struct members of non-existent frames (Bug#6284).
3080 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3082 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3083 variable firstTime not needed on OSX >= 10.6.
3084 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3085 >= 10.5. Use setKnobProportion, setDoubleValue.
3087 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3088 (MAC_OS_X_VERSION_10_5): Define if not defined.
3089 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3090 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3091 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3093 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3094 cString and lossyCString on OSX >= 10.4
3096 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3097 sizeToFit on OSX >= 10.2.
3099 * nsimage.m (allocInitFromFile): Don't use deprecated method
3100 bestRepresentationForDevice on OSX >= 10.6.
3102 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3105 * emacs.c: Declare unexec_init_emacs_zone.
3107 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3109 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3111 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3112 on svcsMenu (Bug#8842).
3114 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3116 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3118 * nsterm.m (QUTF8_STRING): Declare.
3119 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3120 (validRequestorForSendType): Return type is (id).
3121 Change indexOfObjectIdenticalTo to indexOfObject.
3122 Check if we have local selection before returning self (Bug#8842).
3123 (writeSelectionToPasteboard): Put local selection into paste board
3124 if we have a local selection (Bug#8842).
3125 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3127 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3128 (ns_get_local_selection): Declare.
3130 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3132 * keymap.c (describe_map_tree): Don't insert a double newline at
3133 the end of the buffer (bug#1169) and return whether we inserted
3136 * callint.c (Fcall_interactively): Change "reading args" to
3137 "providing args" to try to clarify what it does (bug#1010).
3139 2011-07-07 Kenichi Handa <handa@m17n.org>
3141 * composite.c (composition_compute_stop_pos): Ignore a static
3142 composition starting before CHARPOS (Bug#8915).
3144 * xdisp.c (handle_composition_prop): Likewise.
3146 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3148 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3151 2011-07-07 Kenichi Handa <handa@m17n.org>
3153 * character.h (unicode_category_t): New enum type.
3155 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3156 (Qchar_code_property_table): New variable.
3157 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3158 (UNIPROP_COMPRESSED_FORM_P): New macros.
3159 (char_table_ascii): Uncompress the compressed values.
3160 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3161 Uncompress the compressed values.
3162 (sub_char_table_ref_and_range): Likewise.
3163 (char_table_ref_and_range): Uncompress the compressed values.
3164 (sub_char_table_set): New arg is_uniprop. Callers changed.
3165 Uncompress the compressed values.
3166 (sub_char_table_set_range): Args changed. Callers changed.
3167 (char_table_set_range): Adjuted for the above change.
3168 (map_sub_char_table): Delete args default_val and parent. Add arg
3169 top. Give decoded values to a Lisp function.
3170 (map_char_table): Adjust for the above change. Give decoded
3171 values to a Lisp function. Gcpro more variables.
3172 (uniprop_table_uncompress)
3173 (uniprop_decode_value_run_length): New functions.
3174 (uniprop_decoder, uniprop_decoder_count): New variables.
3175 (uniprop_get_decoder, uniprop_encode_value_character)
3176 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3178 (uniprop_encoder, uniprop_encoder_count): New variables.
3179 (uniprop_get_encoder, uniprop_table)
3180 (Funicode_property_table_internal, Fget_unicode_property_internal)
3181 (Fput_unicode_property_internal): New functions.
3182 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3183 Sunicode_property_table_internal, Sget_unicode_property_internal,
3184 and Sput_unicode_property_internal. Defvar_lisp
3185 char-code-property-alist.
3187 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3188 Vunicode_category_table.
3190 * font.c (font_range): Adjust for the change of
3191 Vunicode_category_table.
3193 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3195 * m/iris4d.h: Remove file, move contents ...
3196 * s/irix6-5.h: ... here.
3198 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3200 Remove unportable assumption about struct layout (Bug#8884).
3201 * alloc.c (mark_buffer):
3202 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3203 (clone_per_buffer_values): Don't assume that
3204 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3205 This isn't true in general, and it's particularly not true
3206 if Emacs is configured with --with-wide-int.
3207 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3208 New macros, used in the buffer.c change.
3210 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3212 * xsettings.c: Use both GConf and GSettings if both are available.
3213 (store_config_changed_event): Add comment.
3214 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3215 (store_tool_bar_style_changed): New functions.
3216 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3217 (struct xsettings): Move font inside HAVE_XFT.
3218 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3219 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3220 Move inside HAVE_XFT.
3221 (something_changed_gsettingsCB): Rename from something_changedCB.
3222 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3224 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3225 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3226 (something_changed_gconfCB): Rename from something_changedCB.
3227 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3228 (parse_settings): Move check for font inside HAVE_XFT.
3229 (read_settings, apply_xft_settings): Add comment.
3230 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3231 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3232 call store_font_name_changed.
3233 (xft_settings_event): Add comment.
3234 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3235 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3236 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3237 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3238 (xsettings_initialize): Call init_gsettings last.
3239 (xsettings_get_system_font, xsettings_get_system_normal_font):
3242 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3244 Random fixes. E.g., (random) never returned negative values.
3245 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3246 subseconds part to the entropy, as that's a bit more random.
3247 Prefer signed to unsigned, since the signedness doesn't matter and
3248 in general we prefer signed. When given a limit, use a
3249 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3250 latter isn't right if USE_2_TAGS_FOR_INTS.
3251 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3252 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3254 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3256 * textprop.c (text_property_stickiness):
3257 Obey Vtext_property_default_nonsticky.
3258 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3259 * w32fns.c (syms_of_w32fns):
3260 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3262 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3264 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3265 This is more efficient than Ffile_directory_p and avoids a minor race.
3267 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3269 * buffer.c (Foverlay_put): Say what the return value is
3272 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3273 is a directory before asking whether to use the file name
3275 (barf_or_query_if_file_exists): Make the "File is a directory"
3276 error be more correct.
3278 * fns.c (Frequire): Remove the mention of the .gz files, since
3279 that's installation-specific, but keep the mention of
3280 `get-load-suffixes'.
3282 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3284 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3285 Report string overflow if the output is too long.
3287 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3289 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3290 (syms_of_gnutls): Remove duplicate DEFSYM for
3291 Qgnutls_bootprop_verify_hostname_error, an error for
3292 Qgnutls_bootprop_verify_error (which is no longer used).
3294 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3295 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3296 Also (re)move comments that are misplaced or no longer relevant.
3298 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3300 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3302 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3304 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3305 and background color parameters if they have been changed.
3307 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3309 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3311 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3313 * xsettings.c (SYSTEM_FONT): Define only when used.
3314 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3316 * keymap.c (access_keymap_1): Now static.
3318 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3320 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3321 leave any prefix arg for the up event (Bug#1586).
3323 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3325 * lread.c (syms_of_lread): Mention single symbols defined by
3326 `defvar' or `defconst' (bug#7154).
3328 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3329 (Frequire): Mention get-load-suffixes.
3331 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3333 * window.h (window): Remove clone_number slot.
3334 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3336 (make_parent_window, make_window, saved_window)
3337 (Fset_window_configuration, save_window_save): Don't deal with
3339 * buffer.c (Qclone_number): Remove declaration.
3340 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3342 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3344 Add multiple inheritance to keymaps.
3345 * keymap.c (Fmake_composed_keymap): New function.
3346 (Fset_keymap_parent): Simplify.
3347 (fix_submap_inheritance): Remove.
3348 (access_keymap_1): New function extracted from access_keymap to handle
3349 embedded parents and handle lists of maps.
3350 (access_keymap): Use it.
3351 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3352 (Fcopy_keymap): Handle embedded parents.
3353 (Fcommand_remapping, define_as_prefix): Simplify.
3354 (Fkey_binding): Simplify.
3355 (syms_of_keymap): Move minibuffer-local-completion-map,
3356 minibuffer-local-filename-completion-map,
3357 minibuffer-local-must-match-map, and
3358 minibuffer-local-filename-must-match-map to Elisp.
3359 (syms_of_keymap): Defsubr make-composed-keymap.
3360 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3361 (parse_menu_item): Trivial simplification.
3363 2011-07-01 Glenn Morris <rgm@gnu.org>
3365 * Makefile.in (SETTINGS_LIBS): Fix typo.
3367 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3369 * coding.c (Fencode_coding_string): Record the last coding system
3370 used, as the function doc string says (bug#8738).
3372 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3374 * xsettings.c (store_monospaced_changed): Take new font as arg and
3375 check for change against current_mono_font.
3376 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3377 (emacs_settings_constructor, emacs_settings_get_property)
3378 (emacs_settings_set_property, emacs_settings_class_init)
3379 (emacs_settings_init, gsettings_obj): Remove.
3380 (something_changedCB): New function for HAVE_GSETTINGS.
3381 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3382 with value as argument.
3383 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3384 g_settings_new (Bug#8967). Do not create gsettings_obj.
3385 Remove calls to g_settings_bind. Connect something_changedCB to
3388 * xgselect.c: Add defined (HAVE_GSETTINGS).
3389 (xgselect_initialize): Ditto.
3391 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3392 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3395 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3397 * eval.c (struct backtrace): Simplify and port the data structure.
3398 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3399 signed bit field, as this assumption is not portable and it makes
3400 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3401 "char debug_on_exit : 1" as this is not portable either; instead,
3402 use the portable "unsigned int debug_on_exit : 1". Remove unused
3403 member evalargs. Remove obsolete comments about cc bombing out.
3405 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3407 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3408 Let HAVE_GSETTINGS override HAVE_GCONF.
3409 (store_monospaced_changed): New function.
3410 (EMACS_SETTINGS): A new type derived from GObject to handle
3411 GSettings notifications.
3412 (emacs_settings_constructor, emacs_settings_get_property)
3413 (emacs_settings_set_property, emacs_settings_class_init):
3415 (gsettings_client, gsettings_obj): New variables.
3416 (GSETTINGS_SCHEMA): New define.
3417 (something_changedCB): Call store_monospaced_changed.
3418 (init_gsettings): New function.
3419 (xsettings_initialize): Call init_gsettings.
3420 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3423 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3426 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3428 * window.c (resize_root_window, grow_mini_window)
3429 (shrink_mini_window): Rename Qresize_root_window to
3430 Qwindow_resize_root_window and Qresize_root_window_vertically to
3431 Qwindow_resize_root_window_vertically.
3433 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3435 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3437 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3439 * makefile.w32-in: Redesign dependencies so they reflect more
3440 clearly which files are directly included by each source file,
3441 and not through other includes.
3443 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3445 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3446 (sort_overlays, overlay_strings): When an overlay's clone number
3447 matches the window's clone number process the overlay even if
3448 the overlay's window property doesn't match the current window.
3450 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3451 (Fwindow_hchild): Rename to Fwindow_left_child.
3452 (Fwindow_next): Rename to Fwindow_next_sibling.
3453 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3454 (resize_window_check): Rename to window_resize_check.
3455 (resize_window_apply): Rename to window_resize_apply.
3456 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3457 (Fdelete_other_windows_internal, resize_frame_windows)
3458 (Fsplit_window_internal, Fdelete_window_internal)
3459 (grow_mini_window, shrink_mini_window)
3460 (Fresize_mini_window_internal): Fix callers accordingly.
3462 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3464 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3465 (emacs_fixed_set_min_size): Remove.
3466 (emacs_fixed_new): Take frame as argument.
3468 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3469 (_EmacsFixedPrivate): Remove minwidth/height.
3470 Add struct frame *f.
3471 (emacs_fixed_init): Initialize priv->f.
3472 (get_parent_class, emacs_fixed_set_min_size): Remove.
3473 (emacs_fixed_new): Set priv->f to argument.
3474 (emacs_fixed_get_preferred_width)
3475 (emacs_fixed_get_preferred_height): Use min_width/height from
3476 frames size_hint to set minimum and natural (Bug#8919).
3477 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3478 and use min_width/height from frames size_hint to set
3479 min_width/height (Bug#8919).
3481 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3482 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3485 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3487 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3488 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3491 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3493 * process.c (wait_reading_process_output): Bypass select if
3494 waiting for a cell while ignoring keyboard input, and input is
3495 pending. Suggested by Jan Djärv (Bug#8869).
3497 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3499 Use gnulib's dup2 module instead of rolling our own.
3500 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3502 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3504 * dispnew.c (scrolling_window): Before scrolling, turn off a
3505 mouse-highlight in the window being scrolled.
3507 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3509 Move DEFSYM to lisp.h and use everywhere.
3511 * character.h (DEFSYM): Move declaration...
3512 * lisp.h (DEFSYM): ...here.
3518 * w32select.c: Don't include character.h.
3520 * alloc.c (syms_of_alloc):
3521 * buffer.c (syms_of_buffer):
3522 * bytecode.c (syms_of_bytecode):
3523 * callint.c (syms_of_callint):
3524 * casefiddle.c (syms_of_casefiddle):
3525 * casetab.c (init_casetab_once):
3526 * category.c (init_category_once, syms_of_category):
3527 * ccl.c (syms_of_ccl):
3528 * cmds.c (syms_of_cmds):
3529 * composite.c (syms_of_composite):
3530 * dbusbind.c (syms_of_dbusbind):
3531 * dired.c (syms_of_dired):
3532 * dispnew.c (syms_of_display):
3533 * doc.c (syms_of_doc):
3534 * editfns.c (syms_of_editfns):
3535 * emacs.c (syms_of_emacs):
3536 * eval.c (syms_of_eval):
3537 * fileio.c (syms_of_fileio):
3538 * fns.c (syms_of_fns):
3539 * frame.c (syms_of_frame):
3540 * fringe.c (syms_of_fringe):
3541 * insdel.c (syms_of_insdel):
3542 * keymap.c (syms_of_keymap):
3543 * lread.c (init_obarray, syms_of_lread):
3544 * macros.c (syms_of_macros):
3545 * msdos.c (syms_of_msdos):
3546 * print.c (syms_of_print):
3547 * process.c (syms_of_process):
3548 * search.c (syms_of_search):
3549 * sound.c (syms_of_sound):
3550 * syntax.c (init_syntax_once, syms_of_syntax):
3551 * terminal.c (syms_of_terminal):
3552 * textprop.c (syms_of_textprop):
3553 * undo.c (syms_of_undo):
3554 * w32.c (globals_of_w32):
3555 * window.c (syms_of_window):
3556 * xdisp.c (syms_of_xdisp):
3557 * xfaces.c (syms_of_xfaces):
3558 * xfns.c (syms_of_xfns):
3559 * xmenu.c (syms_of_xmenu):
3560 * xsettings.c (syms_of_xsettings):
3561 * xterm.c (syms_of_xterm): Use DEFSYM.
3563 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3565 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3567 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3569 Integer and buffer overflow fixes (Bug#8873).
3571 * print.c (printchar, strout): Check for string overflow.
3572 (PRINTPREPARE, printchar, strout):
3573 Don't set size unless allocation succeeds.
3575 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3576 for sizes. Check for string overflow more accurately.
3577 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3579 * macros.c: Integer and buffer overflow fixes.
3580 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3581 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3582 Use ptrdiff_t, not int, for sizes.
3583 Don't increment bufsize until after realloc succeeds.
3584 Check for size-calculation overflow.
3585 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3587 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3589 * lread.c: Integer overflow fixes.
3590 (read_integer): Radix is now EMACS_INT, not int,
3591 to improve quality of diagnostics for out-of-range radices.
3592 Calculate buffer size correctly for out-of-range radices.
3593 (read1): Check for integer overflow in radices, and in
3594 read-circle numbers.
3595 (read_escape): Avoid int overflow.
3596 (Fload, openp, read_buffer_size, read1)
3597 (substitute_object_recurse, read_vector, read_list, map_obarray):
3598 Use ptrdiff_t, not int, for sizes.
3599 (read1): Use EMACS_INT, not int, for sizes.
3600 Check for size overflow.
3602 * image.c (cache_image): Check for size arithmetic overflow.
3604 * lread.c: Integer overflow issues.
3605 (saved_doc_string_size, saved_doc_string_length)
3606 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3607 Now ptrdiff_t, not int.
3608 (read1): Don't assume doc string length fits in int. Check for
3609 out-of-range doc string lengths.
3610 (read_list): Don't assume file position fits in int.
3611 (read_escape): Check for hex character overflow.
3613 2011-06-22 Leo Liu <sdl.web@gmail.com>
3615 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3616 Move to minibuffer.el.
3618 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3620 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3621 The following patches are for when GLYPH_DEBUG && !XASSERT.
3622 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3623 * dispnew.c (flush_stdout):
3624 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3625 Mark as externally visible.
3626 * dispnew.c (check_window_matrix_pointers): Now static.
3627 * dispnew.c (window_to_frame_vpos):
3628 * xfns.c (unwind_create_frame):
3629 * xterm.c (x_check_font): Remove unused local.
3630 * scroll.c (CHECK_BOUNDS):
3631 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3632 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3633 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3634 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3635 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3637 (debug_method_add): Use va_list and vsprintf rather than relying
3638 on undefined behavior with wrong number of arguments.
3639 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3640 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3641 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3642 since we're not interested in debugging glyphs with old libraries.
3643 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3644 GCC 4.6.0's static checking.
3646 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3648 Integer overflow and signedness fixes (Bug#8873).
3649 A few related buffer overrun fixes, too.
3651 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3653 * dispextern.h (struct face.stipple):
3654 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3655 (x_bitmap_mask, x_allocate_bitmap_record)
3656 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3657 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3658 (x_create_bitmap_from_xpm_data):
3659 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3660 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3662 * xfaces.c (load_pixmap):
3663 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3664 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3665 (.bitmaps_last, struct x_output.icon_bitmap):
3666 Use ptrdiff_t, not int, for bitmap indexes.
3667 (x_allocate_bitmap_record): Check for size overflow.
3668 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3670 Use ptrdiff_t, not int, for overlay counts.
3671 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3672 * editfns.c (overlays_around, get_pos_property):
3673 * textprop.c (get_char_property_and_overlay):
3674 * xdisp.c (next_overlay_change, note_mouse_highlight):
3675 * xfaces.c (face_at_buffer_position):
3676 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3677 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3678 (Fnext_overlay_change, Fprevious_overlay_change)
3679 (mouse_face_overlay_overlaps, Foverlays_in):
3680 Use ptrdiff_t, not int, for sizes.
3681 (overlays_at, overlays_in): Check for size-calculation overflow.
3683 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3685 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3686 (x_session_initialize): Do not assume string length fits in int.
3688 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3689 This is unlikely, but can occur if DPI is outlandish.
3691 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3692 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3694 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3695 * xrdb.c (magic_file_p, search_magic_path):
3696 Omit last arg SUFFIX; it was always 0. All callers changed.
3697 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3699 * xfont.c (xfont_match): Avoid need for strlen.
3701 * xfns.c: Don't assume strlen fits in int.
3702 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3704 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3705 not unsigned long, as we prefer signed integers. All callers changed.
3706 Detect integer overflow in repeat count.
3707 (message_dolog): Don't assume print length fits in 39 bytes.
3708 (display_mode_element): Don't assume strlen fits in int.
3710 * termcap.c: Don't assume sizes fit in int and never overflow.
3711 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3712 (gobble_line): Check for size-calculation overflow.
3714 * minibuf.c (Fread_buffer):
3715 * lread.c (intern, intern_c_string):
3716 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3717 Don't assume string length fits in int.
3719 * keyboard.c (parse_tool_bar_item):
3720 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3722 * font.c: Don't assume string length fits in int.
3723 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3724 Use ptrdiff_t, not int.
3725 (font_intern_prop): Don't assume string length fits in int.
3726 Don't assume integer property fits in fixnum.
3727 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3729 * filelock.c: Fix some buffer overrun and integer overflow issues.
3730 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3731 Reformulate so as not to need the command string.
3732 Invoke gzip -cd rather than gunzip, as it's more portable.
3733 (lock_info_type, lock_file_1, lock_file):
3734 Don't assume pid_t and time_t fit in unsigned long.
3735 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3736 (current_lock_owner): Prefer signed type for sizes.
3737 Use memcpy, not strncpy, where memcpy is what is really wanted.
3738 Don't assume (via atoi) that time_t and pid_t fit in int.
3739 Check for time_t and/or pid_t out of range, e.g., via a network share.
3740 Don't alloca where an auto var works fine.
3742 * fileio.c: Fix some integer overflow issues.
3743 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3744 Don't assume string length fits in int.
3745 (directory_file_name): Don't assume string length fits in long.
3746 (make_temp_name): Don't assume pid fits in int, or that its print
3747 length is less than 20.
3749 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3751 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3753 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3755 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3756 We prefer signed integers, even for size calculations.
3758 * emacs.c: Don't assume string length fits in 'int'.
3759 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3760 (main): Don't invoke strlen when not needed.
3762 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3763 (XD_DEBUG_MESSAGE): Don't waste a byte.
3765 * callproc.c (getenv_internal_1, getenv_internal)
3767 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3769 * lread.c (invalid_syntax): Omit length argument.
3770 All uses changed. This doesn't fix a bug, but it simplifies the
3771 code away from its former Hollerith-constant appearance, and it's
3772 one less 'int' to worry about when looking at integer-overflow issues.
3773 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3775 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3776 This didn't break anything, but it didn't help either.
3777 It's confusing to put a bogus integer in a place where the actual
3778 value does not matter.
3779 (LIST_END_P): Remove unused macro and its bogus comment.
3780 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3782 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3783 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3785 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3786 We prefer signed types, and the value cannot exceed the EMACS_INT
3787 range anyway (because otherwise the length would not be representable).
3788 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3789 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3790 This avoids a GCC warning when WIDE_EMACS_INT.
3792 * indent.c (sane_tab_width): New function.
3793 (current_column, scan_for_column, Findent_to, position_indentation)
3794 (compute_motion): Use it. This is just for clarity.
3795 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3797 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3799 * lisp.h (lint_assume): New macro.
3800 * composite.c (composition_gstring_put_cache):
3801 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3803 * editfns.c, insdel.c:
3804 Omit unnecessary forward decls, to simplify future changes.
3806 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3808 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3810 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3811 Use much-faster test for byte-length change.
3812 Don't assume string byte-length fits in 'int'.
3813 Check that character arg fits in 'int'.
3814 (mapcar1): Declare byte as byte, for clarity.
3816 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3818 * fns.c (concat): Catch string overflow earlier.
3819 Do not rely on integer wraparound.
3821 * dispextern.h (struct it.overlay_strings_charpos)
3822 (struct it.selective): Now EMACS_INT, not int.
3823 * xdisp.c (forward_to_next_line_start)
3824 (back_to_previous_visible_line_start)
3825 (reseat_at_next_visible_line_start, next_element_from_buffer):
3826 Don't arbitrarily truncate the value of 'selective' to int.
3828 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3830 * composite.c: Don't truncate sizes to 'int'.
3831 (composition_gstring_p, composition_reseat_it)
3832 (composition_adjust_point): Use EMACS_INT, not int.
3833 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3834 not EMACS_UINT, for indexes.
3836 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3838 * buffer.c: Include <verify.h>.
3839 (struct sortvec.priority, struct sortstr.priority):
3840 Now EMACS_INT, not int.
3841 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3842 (struct sortstr.size, record_overlay_string)
3843 (struct sortstrlist.size, struct sortlist.used):
3844 Don't truncate size to int.
3845 (record_overlay_string): Check for size-calculation overflow.
3846 (init_buffer_once): Check at compile-time, not run-time.
3848 2011-06-22 Jim Meyering <meyering@redhat.com>
3850 Don't leak an XBM-image-sized buffer
3851 * image.c (xbm_load): Free the image buffer after using it.
3853 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3856 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3857 that Sun C diagnosed.
3858 * fns.c (secure_hash): Fix pointer signedness issue.
3859 * intervals.c (static_offset_intervals): New function.
3860 (offset_intervals): Use it.
3862 2011-06-21 Leo Liu <sdl.web@gmail.com>
3865 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3868 * fns.c (secure_hash): Rename from crypto_hash_function and change
3869 the first arg to accept symbols.
3870 (Fsecure_hash): New primitive.
3871 (syms_of_fns): New symbols.
3873 2011-06-20 Deniz Dogan <deniz@dogan.se>
3875 * process.c (Fset_process_buffer): Clarify return value in
3878 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3880 * dispnew.c (add_window_display_history): Use BVAR.
3882 * xdisp.c (debug_method_add): Use BVAR.
3883 (check_window_end, dump_glyph_matrix, dump_glyph)
3884 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3886 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3889 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3890 check till after the cache is created in init_frame_faces.
3892 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3894 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3896 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3898 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3899 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3900 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3902 Improve buffer-overflow checking (Bug#8873).
3903 * fileio.c (Finsert_file_contents):
3904 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3905 Remove the old (too-loose) buffer overflow checks.
3906 They weren't needed, since make_gap checks for buffer overflow.
3907 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3908 The old code merely checked for Emacs fixnum overflow, and relied
3909 on undefined (wraparound) behavior. The new code avoids undefined
3910 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3912 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3913 Tune. Don't use wider integers than needed. Don't use alloca.
3914 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3916 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3918 * insdel.c, lisp.h (buffer_overflow): New function.
3919 (insert_from_buffer_1, replace_range, replace_range_2):
3920 * insdel.c (make_gap_larger):
3921 * editfns.c (Finsert_char):
3922 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3924 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3926 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3928 Integer overflow and signedness fixes (Bug#8873).
3930 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3931 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3933 * fileio.c: Don't assume EMACS_INT fits in off_t.
3934 (emacs_lseek): New static function.
3935 (Finsert_file_contents, Fwrite_region): Use it.
3936 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3938 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3940 * fns.c: Don't overflow int when computing a list length.
3941 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3942 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3943 truncation on 64-bit hosts. Check for QUIT every
3944 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3945 faster and is responsive enough.
3946 (Flength): Report an error instead of overflowing an integer.
3947 (Fsafe_length): Return a float if the value is not representable
3948 as a fixnum. This shouldn't happen except in contrived situations.
3949 (Fnthcdr, Fsort): Don't assume list length fits in int.
3950 (Fcopy_sequence): Don't assume vector length fits in int.
3952 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3953 (header_size, word_size): New constants.
3954 (allocate_vectorlike): Don't check size overflow here.
3955 (allocate_vector): Check it here instead, since this is the only
3956 caller of allocate_vectorlike that could cause overflow.
3957 Check that the new vector's length is representable as a fixnum.
3959 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3960 The previous code was bogus. For example, next_almost_prime (32)
3961 returned 39, which is undesirable as it is a multiple of 3; and
3962 next_almost_prime (24) returned 25, which is a multiple of 5 so
3963 why was the code bothering to check for multiples of 7?
3965 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3967 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3969 Variadic C functions now count arguments with ptrdiff_t.
3970 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3971 Back then I didn't know that the Emacs coding style prefers signed int.
3972 Also, in the meantime I found a few more instances where arguments
3973 were being counted with int, which may truncate counts on 64-bit
3974 machines, or EMACS_INT, which may be unnecessarily wide.
3975 * lisp.h (struct Lisp_Subr.function.aMANY)
3976 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3977 Arg counts are now ptrdiff_t, not size_t.
3978 All variadic functions and their callers changed accordingly.
3979 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3980 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3981 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3982 * callint.c (Fcall_interactively): Check arg count for overflow,
3983 to avoid potential buffer overrun. Use signed char, not 'int',
3984 for 'varies' array, so that we needn't bother to check its size
3985 calculation for overflow.
3986 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3987 * eval.c (apply_lambda):
3988 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3989 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3990 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3992 * callint.c (Fcall_interactively): Don't use index var as event count.
3994 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3995 * mem-limits.h (SIZE): Remove; no longer used.
3997 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3999 Remove unnecessary casts.
4000 * xterm.c (x_term_init):
4001 * xfns.c (x_set_border_pixel):
4002 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4003 These aren't needed now that we assume ANSI C.
4005 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4006 It's more likely to cause problems (due to unsigned overflow)
4009 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4011 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4013 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4015 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4017 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4019 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4021 GLYPH_CODE_FACE returns EMACS_INT, not int.
4022 * dispextern.h (merge_faces):
4023 * xfaces.c (merge_faces):
4024 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4025 Don't assume EMACS_INT fits in int.
4027 * character.h (CHAR_VALID_P): Remove unused parameter.
4028 * fontset.c, lisp.h, xdisp.c: All uses changed.
4030 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4032 * fns.c (concat): Minor tuning based on overflow analysis.
4033 This doesn't fix any bugs. Use int to hold character, instead
4034 of constantly refetching from Emacs object. Use XFASTINT, not
4035 XINT, for value known to be a character. Don't bother comparing
4036 a single byte to 0400, as it's always less.
4038 * floatfns.c (Fexpt):
4039 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4041 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4044 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4046 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4047 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4048 incorrectly succeed when S was a string, because 4294967386 was
4049 truncated before it was used.
4051 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4052 Otherwise, an out-of-range integer could cause undefined behavior
4055 * composite.c: Use int, not EMACS_INT, for characters.
4056 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4057 EMACS_INT, for values that are known to be in character range.
4058 This doesn't fix any bugs but is the usual style inside Emacs and
4059 may generate better code on 32-bit machines.
4061 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4062 This is for reasons similar to the recent CHAR_STRING fix.
4063 * charset.c (Fencode_char): Check that character arg is actually
4064 a character. Pass an int to ENCODE_CHAR.
4065 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4066 wider than 'int', as a compile-time check to prevent future regressions
4069 * character.c (char_string): Remove unnecessary casts.
4071 Make sure a 64-bit char is never passed to CHAR_STRING.
4072 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4073 by silently ignoring the top 32 bits, allowing some values
4074 that were far too large to be valid characters.
4075 * character.h: Include <verify.h>.
4076 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4077 arguments are no wider than unsigned, as a compile-time check
4078 to prevent future regressions in this area.
4080 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4081 (Fsubst_char_in_region):
4083 * xdisp.c (decode_mode_spec_coding):
4084 Adjust to CHAR_STRING's new requirement.
4085 * editfns.c (Finsert_char, Fsubst_char_in_region):
4086 * fns.c (concat): Check that character args are actually
4087 characters. Without this test, these functions did the wrong
4088 thing with wildly out-of-range values on 64-bit hosts.
4090 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4091 These casts should not be needed on 32-bit hosts, either.
4092 * keyboard.c (read_char):
4093 * lread.c (Fload): Remove casts to unsigned.
4095 * lisp.h (UNSIGNED_CMP): New macro.
4096 This fixes comparison bugs on 64-bit hosts.
4097 (ASCII_CHAR_P): Use it.
4098 * casefiddle.c (casify_object):
4099 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4100 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4101 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4102 * dispextern.h (FACE_FROM_ID):
4103 * keyboard.c (read_char): Use UNSIGNED_CMP.
4105 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4106 not to EMACS_INT, to avoid GCC warning.
4108 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4110 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4111 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4112 isn't needed on 32-bit machines.
4114 * buffer.c (Fgenerate_new_buffer_name):
4115 Use EMACS_INT for count, not int.
4116 (advance_to_char_boundary): Return EMACS_INT, not int.
4118 * data.c (Qcompiled_function): Now static.
4120 * window.c (window_body_lines): Now static.
4122 * image.c (gif_load): Rename local to avoid shadowing.
4124 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4125 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4126 * alloc.c (make_save_value): Integer argument is now of type
4128 (mark_object): Use ptrdiff_t, not int.
4129 * lisp.h (pD): New macro.
4130 * print.c (print_object): Use it.
4132 * alloc.c: Use EMACS_INT, not int, to count objects.
4133 (total_conses, total_markers, total_symbols, total_vector_size)
4134 (total_free_conses, total_free_markers, total_free_symbols)
4135 (total_free_floats, total_floats, total_free_intervals)
4136 (total_intervals, total_strings, total_free_strings):
4137 Now EMACS_INT, not int. All uses changed.
4138 (Fgarbage_collect): Compute overall total using a double, so that
4139 integer overflow is less likely to be a problem. Check for overflow
4140 when converting back to an integer.
4141 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4142 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4143 These were 'int' variables that could overflow on 64-bit hosts;
4144 they were never used, so remove them instead of repairing them.
4145 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4146 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4147 Previously, this ceilinged at INT_MAX, but that doesn't work on
4149 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4151 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4152 (allocate_vectorlike): Check for ptrdiff_t overflow.
4153 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4154 when a (possibly-narrower) signed value would do just as well.
4155 We prefer using signed arithmetic, to avoid comparison confusion.
4157 * alloc.c: Catch some string size overflows that we were missing.
4158 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4159 for convenience in STRING_BYTES_MAX.
4160 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4161 The definition here is exact; the one in lisp.h was approximate.
4162 (allocate_string_data): Check for string overflow. This catches
4163 some instances we weren't catching before. Also, it catches
4164 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4165 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4166 and ptrdiff_t and EMACS_INT are both 64 bits.
4168 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4169 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4170 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4172 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4174 * alloc.c (Fmake_string): Check for out-of-range init.
4176 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4178 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4180 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4182 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4183 xg_get_default_scrollbar_width.
4185 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4186 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4187 (style_changed_cb): Call update_theme_scrollbar_width and call
4188 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4189 all frames (Bug#8505).
4190 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4191 Call gtk_window_set_resizable if HAVE_GTK3.
4192 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4193 and height if HAVE_GTK3 (Bug#8505).
4194 (scroll_bar_width_for_theme): New variable.
4195 (update_theme_scrollbar_width): New function.
4196 (xg_get_default_scrollbar_width): Move code to
4197 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4198 (xg_initialize): Call update_theme_scrollbar_width.
4200 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4202 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4204 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4206 * frame.c (make_frame): Call other_buffer_safely instead of
4209 * window.c (temp_output_buffer_show): Call display_buffer with
4210 second argument Vtemp_buffer_show_specifiers and reset latter
4211 immediately after the call.
4212 (Vtemp_buffer_show_specifiers): New variable.
4213 (auto_window_vscroll_p, next_screen_context_lines)
4214 (Vscroll_preserve_screen_position): Remove leading asterisks from
4217 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4219 Fix minor problems found by GCC 4.6.0 static checking.
4220 * buffer.c (Qclone_number): Remove for now, as it's unused.
4221 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4222 (record_buffer): Remove unused local.
4223 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4224 (set_frame_buffer_list): Remove; unused.
4225 * frame.h (other_visible_frames): Remove decl.
4226 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4227 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4228 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4230 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4231 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4232 Define only if HAVE_GPM.
4233 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4234 (update_hints_inhibit): Remove; never set. All uses removed.
4235 * widgetprv.h (emacsFrameClassRec): Remove decl.
4236 * window.c (delete_deletable_window): Now returns void, since it
4237 wasn't returning anything.
4238 (compare_window_configurations): Remove unused locals.
4239 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4240 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4241 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4242 the same widths as pointers. This follows up on the 2011-05-06 patch.
4243 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4244 * xterm.h: Likewise.
4245 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4247 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4249 * makefile.w32-in: Update dependencies.
4250 (LISP_H): Add lib/intprops.h.
4252 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4254 * image.c (gif_load): Add animation frame delay to the metadata.
4255 (syms_of_image): Use DEFSYM. New symbol `delay'.
4257 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4259 * window.c (delete_deletable_window): Re-add.
4260 (Fset_window_configuration): Rewrite to handle dead buffers and
4261 consequently deletable windows.
4262 (window_tree, Fwindow_tree): Remove. Supply functionality in
4264 (compare_window_configurations): Simplify code.
4266 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4268 * image.c (imagemagick_load_image): Fix type mismatch.
4269 (Fimagemagick_types): Likewise.
4271 * window.h (replace_buffer_in_windows): Declare.
4273 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4275 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4276 Qclone_number. Remove external declaration of Qdelete_window.
4277 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4279 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4280 Run Qbuffer_list_update_hook if allowed.
4281 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4282 buffer list implementation.
4283 (other_buffer_safely): New function.
4284 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4285 calls to replace_buffer_in_windows and
4286 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4288 (record_buffer): Inhibit quitting and rewrite using quittable
4289 functions. Run Qbuffer_list_update_hook if allowed.
4290 (Frecord_buffer, Funrecord_buffer): New functions.
4291 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4292 Move switch-to-buffer to window.el.
4293 (bury-buffer): Move to window.el.
4294 (Vbuffer_list_update_hook): New variable.
4296 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4299 * window.h (resize_frame_windows): Move up in code.
4300 (Fwindow_frame): Remove EXFUN.
4301 (replace_buffer_in_all_windows): Remove prototype.
4302 (replace_buffer_in_windows_safely): Add prototype.
4304 * window.c: Declare Qdelete_window static again. Move down
4305 declaration of select_count.
4306 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4307 (Fother_window): Move to window.el.
4308 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4309 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4310 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4312 (replace_buffer_in_windows): Implement by calling
4313 Qreplace_buffer_in_windows.
4314 (replace_buffer_in_all_windows): Remove with some functionality
4315 moved into replace_buffer_in_windows_safely.
4316 (replace_buffer_in_windows_safely): New function.
4317 (select_window_norecord, select_frame_norecord): Move in front
4318 of run_window_configuration_change_hook. Remove now obsolete
4320 (Fset_window_buffer): Rewrite doc-string.
4321 Call Qrecord_window_buffer.
4322 (keys_of_window): Move binding for other-window to window.el.
4324 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4326 * dispextern.h (struct image): Replace data member, whose int_val
4327 and ptr_val fields were not used by anything, with a single
4330 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4331 (gif_clear_image, gif_load, imagemagick_load_image)
4332 (gs_clear_image, gs_load): Callers changed.
4334 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4336 * buffer.h: Include <time.h>, for time_t.
4337 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4339 Fix minor problems found by static checking.
4341 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4343 Make identifiers static if they are not used in other modules.
4344 * data.c (Qcompiled_function, Qframe, Qvector):
4345 * image.c (QimageMagick, Qsvg):
4346 * minibuf.c (Qmetadata):
4347 * window.c (resize_window_check, resize_root_window): Now static.
4348 * window.h (resize_window_check, resize_root_window): Remove decls.
4350 * window.c (window_deletion_count, delete_deletable_window):
4352 (window_body_lines): Now static.
4353 (Fdelete_other_windows_internal): Mark vars as initialized.
4354 Make sure 'resize_failed' is initialized.
4355 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4356 (resize_window_apply): Remove unused local.
4357 * window.h (delete_deletable_window): Remove decl.
4359 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4360 (imagemagick_load_image): Fix pointer signedness problem by changing
4361 last arg from unsigned char * to char *. All uses changed.
4362 Also, fix a local for similar reasons.
4363 Remove unused locals. Remove locals to avoid shadowing.
4364 (fn_rsvg_handle_free): Remove; unused.
4365 (svg_load, svg_load_image): Fix pointer signedness problem.
4366 (imagemagick_load_image): Don't use garbage pointer image_wand.
4368 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4370 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4372 * image.c (gif_load): Fix omitted cast error introduced by
4375 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4377 * window.h (resize_proportionally, orig_total_lines)
4378 (orig_top_line): Remove from window structure.
4379 (set_window_height, set_window_width, change_window_heights)
4380 (Fdelete_window): Remove prototypes.
4381 (resize_frame_windows): Remove duplicate declaration.
4383 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4385 * window.h (resize_frame_windows, resize_window_check)
4386 (delete_deletable_window, resize_root_window)
4387 (resize_frame_windows): Declare prototypes.
4389 * window.c (resize_window_apply): Make definition be "static" to
4390 match the prototype.
4392 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4394 * window.c: Remove declarations of Qwindow_size_fixed,
4395 window_min_size_1, window_min_size_2, window_min_size,
4396 size_window, window_fixed_size_p, enlarge_window, delete_window.
4397 Remove static from declaration of Qdelete_window, it's
4398 temporarily needed by Fbury_buffer.
4399 (replace_window): Don't assign orig_top_line and
4401 (Fdelete_window, delete_window): Remove. Window deletion is
4402 handled by window.el.
4403 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4404 Replace Fdelete_window calls with calls to Qdelete_window.
4405 (Fdelete_other_windows): Remove. Deleting other windows is
4406 handled by window.el.
4407 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4408 handled in window.el.
4409 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4410 Window minimum sizes are handled in window.el.
4411 (shrink_windows, size_window, set_window_height)
4412 (set_window_width, change_window_heights, window_height)
4413 (window_width, CURBEG, CURSIZE, enlarge_window)
4414 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4415 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4416 handled in window.el.
4417 (make_dummy_parent): Rename to make_parent_window and give it a
4418 second argument horflag.
4419 (make_window): Don't set resize_proportionally any more.
4420 (Fsplit_window): Remove. Windows are split in window.el.
4421 (save_restore_action, save_restore_orig_size)
4422 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4423 Resize mini windows in window.el.
4424 (grow_mini_window, shrink_mini_window): Implement by calling
4425 Qresize_root_window_vertically, resize_window_check and
4426 resize_window_apply.
4427 (saved_window, Fset_window_configuration, save_window_save):
4428 Do not handle orig_top_line, orig_total_lines, and
4429 resize_proportionally.
4430 (window_min_height, window_min_width): Move to window.el.
4431 (keys_of_window): Move bindings for delete-other-windows,
4432 split-window, delete-window and enlarge-window to window.el.
4434 * buffer.c: Temporarily extern Qdelete_window.
4435 (Fbury_buffer): Temporarily call Qdelete_window instead of
4436 Fdelete_window (Fbury_buffer will move to window.el soon).
4438 * frame.c (set_menu_bar_lines_1): Remove code handling
4439 orig_top_line and orig_total_lines.
4441 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4442 set_window_height but set heights directly.
4443 (change_frame_size_1): Use resize_frame_windows.
4445 * xdisp.c (init_xdisp): Don't use set_window_height but set
4448 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4449 Use resize_frame_windows instead of change_window_heights and run
4450 run_window_configuration_change_hook.
4452 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4453 instead of change_window_heights and run
4454 run_window_configuration_change_hook.
4456 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4458 * window.c (replace_window): Rename second argument REPLACEMENT to
4459 NEW. New third argument SETFLAG. Rewrite.
4460 (delete_window, make_dummy_parent): Call replace_window with
4462 (window_list_1): Move down in code.
4463 (run_window_configuration_change_hook): Move set_buffer part
4464 before select_frame_norecord part in order to unwind correctly.
4465 Rename count1 to count.
4466 (recombine_windows, delete_deletable_window, resize_root_window)
4467 (Fdelete_other_windows_internal)
4468 (Frun_window_configuration_change_hook, make_parent_window)
4469 (resize_window_check, resize_window_apply, Fresize_window_apply)
4470 (resize_frame_windows, Fsplit_window_internal)
4471 (Fdelete_window_internal, Fresize_mini_window_internal):
4473 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4475 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4477 * window.h (window): Add some new members to window structure -
4478 normal_lines, normal_cols, new_total, new_normal, clone_number,
4479 splits, nest, prev_buffers, next_buffers.
4480 (WINDOW_TOTAL_SIZE): Move here from window.c.
4481 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4483 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4485 (make_dummy_parent): Set new members of windows structure.
4486 (make_window): Move down in code. Handle new members of window
4488 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4489 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4490 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4491 (Fset_window_prev_buffers, Fwindow_next_buffers)
4492 (Fset_window_next_buffers, Fset_window_clone_number):
4494 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4495 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4497 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4498 Argument WINDOW can be now internal window too.
4499 (Fwindow_use_time): Move up in code.
4500 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4502 (Fset_window_configuration, saved_window)
4503 (Fcurrent_window_configuration, save_window_save): Handle new
4504 members of window structure.
4505 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4506 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4507 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4508 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4509 Qget_mru_window, Qresize_root_window,
4510 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4511 Qauto_buffer_name; staticpro them.
4513 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4515 * window.c (Fwindow_total_size, Fwindow_left_column)
4516 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4517 (Fwindow_list_1): New functions.
4518 (window_box_text_cols): Replace with window_body_cols.
4519 (Fwindow_width, Fscroll_left, Fscroll_right):
4520 Use window_body_cols instead of window_box_text_cols.
4521 (delete_window, Fset_window_configuration):
4522 Call delete_all_subwindows with window as argument.
4523 (delete_all_subwindows): Take a window as argument and not a
4525 (window_loop): Remove handling of GET_LRU_WINDOW and
4527 (Fget_lru_window, Fget_largest_window): Move to window.el.
4529 * window.h: Extern window_body_cols instead of
4530 window_box_text_cols. delete_all_subwindows now takes a
4531 Lisp_Object as argument.
4533 * indent.c (compute_motion, Fcompute_motion):
4534 Use window_body_cols instead of window_box_text_cols.
4536 * frame.c (delete_frame): Call delete_all_subwindows with root
4539 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4541 * fns.c (Fputhash): Document return value.
4543 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4545 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4547 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4549 Cons<->int and similar integer overflow fixes (Bug#8794).
4551 Check for overflow when converting integer to cons and back.
4552 * charset.c (Fdefine_charset_internal, Fdecode_char):
4553 Use cons_to_unsigned to catch overflow.
4554 (Fencode_char): Use INTEGER_TO_CONS.
4555 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4556 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4557 * data.c (long_to_cons, cons_to_long): Remove.
4558 (cons_to_unsigned, cons_to_signed): New functions.
4559 These signal an error for invalid or out-of-range values.
4560 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4561 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4562 * font.c (Ffont_variation_glyphs):
4563 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4564 * lisp.h: Include <intprops.h>.
4565 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4566 (cons_to_signed, cons_to_unsigned): New decls.
4567 (long_to_cons, cons_to_long): Remove decls.
4568 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4569 (Fprimitive_undo): Use CONS_TO_INTEGER.
4570 * xfns.c (Fx_window_property): Likewise.
4571 * xselect.c: Include <limits.h>.
4572 (x_own_selection, selection_data_to_lisp_data):
4573 Use INTEGER_TO_CONS.
4574 (x_handle_selection_request, x_handle_selection_clear)
4575 (x_get_foreign_selection, Fx_disown_selection_internal)
4576 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4577 (lisp_data_to_selection_data): Use cons_to_unsigned.
4578 (x_fill_property_data): Use cons_to_signed.
4579 Report values out of range.
4581 Check for buffer and string overflow more precisely.
4582 * buffer.h (BUF_BYTES_MAX): New macro.
4583 * lisp.h (STRING_BYTES_MAX): New macro.
4584 * alloc.c (Fmake_string):
4585 * character.c (string_escape_byte8):
4586 * coding.c (coding_alloc_by_realloc):
4587 * doprnt.c (doprnt):
4588 * editfns.c (Fformat):
4590 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4591 since they may not be the same number.
4592 * editfns.c (Finsert_char):
4593 * fileio.c (Finsert_file_contents):
4594 Likewise for BUF_BYTES_MAX.
4596 * image.c: Use ptrdiff_t, not int, for sizes.
4597 (slurp_file): Switch from int to ptrdiff_t.
4599 (slurp_file): Check that file size fits in both size_t (for
4600 malloc) and ptrdiff_t (for sanity and safety).
4602 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4603 if b->modtime has its maximal value.
4605 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4607 Don't assume time_t can fit into int.
4608 * buffer.h (struct buffer.modtime): Now time_t, not int.
4609 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4610 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4612 Minor fixes for signed vs unsigned integers.
4613 * character.h (MAYBE_UNIFY_CHAR):
4614 * charset.c (maybe_unify_char):
4615 * keyboard.c (read_char, reorder_modifiers):
4616 XINT -> XFASTINT, since the integer must be nonnegative.
4617 * ftfont.c (ftfont_spec_pattern):
4618 * keymap.c (access_keymap, silly_event_symbol_error):
4619 XUINT -> XFASTINT, since the integer must be nonnegative.
4620 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4621 since it makes no difference and we prefer signed.
4622 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4623 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4626 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4628 * window.h (Fwindow_frame): Declare.
4630 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4632 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4633 (SPARE_MEMORY): Always define.
4634 (LARGE_REQUEST): Remove.
4635 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4637 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4639 * lisp.h: Move EXFUNS for Fframe_root_window,
4640 Fframe_first_window and Fset_frame_selected_window to window.h.
4642 * window.h: Move EXFUNS for Fframe_root_window,
4643 Fframe_first_window and Fset_frame_selected_window here from
4646 * frame.c (Fwindow_frame, Fframe_first_window)
4647 (Fframe_root_window, Fframe_selected_window)
4648 (Fset_frame_selected_window): Move to window.c.
4649 (Factive_minibuffer_window): Move to minibuf.c.
4650 (Fother_visible_frames_p): New function.
4652 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4654 * window.c (decode_window, decode_any_window): Move up in code.
4655 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4656 (inhibit_frame_unsplittable): Remove unused variable.
4657 (Fwindow_buffer): Move up and rewrite doc-string.
4658 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4659 (Fwindow_prev): New functions.
4660 (Fwindow_frame): Move here from frame.c. Accept any window as
4662 (Fframe_root_window, Fframe_first_window)
4663 (Fframe_selected_window): Move here from frame.c. Accept frame
4664 or arbitrary window as argument. Update doc-strings.
4665 (Fminibuffer_window): Move up in code.
4666 (Fwindow_minibuffer_p): Move up in code and simplify.
4667 (Fset_frame_selected_window): Move here from frame.c.
4669 (Fselected_window, select_window, Fselect_window): Move up in
4670 code. Minor doc-string fixes.
4672 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4674 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4675 Do not assume that spare memory exists; that assumption is valid
4676 only if SYSTEM_MALLOC.
4677 (LARGE_REQUEST): New macro, so that the issue of large requests
4678 is separated from the issue of spare memory.
4680 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4682 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4685 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4687 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4690 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4692 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4694 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4696 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4697 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4699 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4701 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4703 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4705 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4706 (x_clipboard_manager_save): Add return value.
4707 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4709 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4710 Obey Vx_select_enable_clipboard_manager. Catch errors in
4711 x_clipboard_manager_save (Bug#8779).
4712 (Vx_select_enable_clipboard_manager): New variable.
4713 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4715 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4717 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4719 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4721 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4722 in the current matrix if keep_current_p is non-zero.
4724 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4726 * bidi.c (bidi_level_of_next_char): Fix last change.
4728 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4730 Support bidi reordering of text covered by display properties.
4732 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4733 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4734 (bidi_cache_search, bidi_cache_iterator_state)
4735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4736 (bidi_level_of_next_char, bidi_move_to_visually_next):
4737 Support character positions inside a run of characters covered by a
4739 (bidi_paragraph_init, bidi_resolve_explicit_1)
4740 (bidi_level_of_next_char): Call bidi_fetch_char and
4741 bidi_fetch_char_advance instead of FETCH_CHAR and
4743 (bidi_init_it): Initialize new members.
4744 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4746 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4747 instead of using explicit *_CHAR codes.
4748 (bidi_resolve_explicit, bidi_resolve_weak):
4749 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4750 bidirectional text is supported only in multibyte buffers.
4751 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4752 it to initialize the frame_window_p member of struct bidi_it.
4753 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4754 (bidi_resolve_explicit, bidi_resolve_weak)
4755 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4756 bidi_it->nchars is non-positive.
4757 (bidi_level_of_next_char): Don't try to lookup the cache for the
4758 next/previous character if nothing is cached there yet, or if we
4759 were just reseat()'ed to a new position.
4761 * xdisp.c (set_cursor_from_row): Set start and stop points
4762 according to the row's direction when priming the loop that looks
4763 for the glyph on which to display cursor.
4764 (single_display_spec_intangible_p): Function deleted.
4765 (display_prop_intangible_p): Reimplement to call
4766 handle_display_spec instead of single_display_spec_intangible_p.
4767 Accept 3 additional arguments needed by handle_display_spec.
4768 This fixes incorrect cursor motion across display property with complex
4769 values: lists, `(when COND...)' forms, etc.
4770 (single_display_spec_string_p): Support property values that are
4771 lists with the argument STRING its top-level element.
4772 (display_prop_string_p): Fix the condition for processing a
4773 property that is a list to be consistent with handle_display_spec.
4774 (handle_display_spec): New function, refactored from the
4775 last portion of handle_display_prop.
4776 (compute_display_string_pos): Accept additional argument
4777 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4778 value of a `display' property is a "replacing spec".
4779 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4780 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4781 the display property, but just return a value indicating whether
4782 the display property will replace the characters it covers.
4783 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4784 frame_window_p members of struct bidi_it.
4785 (compute_display_string_pos, compute_display_string_end):
4787 (push_it): Accept second argument POSITION, where pop_it should
4788 jump to continue iteration.
4789 (reseat_1): Initialize bidi_it.disp_pos.
4791 * keyboard.c (adjust_point_for_property): Adjust the call to
4792 display_prop_intangible_p to its new signature.
4794 * dispextern.h (struct bidi_it): New member frame_window_p.
4795 (bidi_init_it): Update prototypes.
4796 (display_prop_intangible_p): Update prototype.
4797 (compute_display_string_pos, compute_display_string_end):
4799 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4802 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4804 Malloc failure behavior now depends on size of allocation.
4805 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4806 * lisp.h: Change signatures accordingly.
4807 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4808 All callers changed. (Bug#8762)
4810 * gnutls.c: Use Emacs's memory allocators.
4811 Without this change, the gnutls library would invoke malloc etc.
4812 directly, which causes problems on non-SYNC_INPUT hosts, and which
4813 runs afoul of improving memory_full behavior. (Bug#8761)
4814 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4815 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4816 xfree instead of the default malloc, realloc, free.
4817 (Fgnutls_boot): No need to check for memory allocation failure,
4818 since xmalloc does that for us.
4820 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4821 * category.c (hash_get_category_set):
4822 * ccl.c (ccl_driver):
4823 * charset.c (Fdefine_charset_internal):
4824 * charset.h (struct charset.hash_index):
4825 * composite.c (get_composition_id, gstring_lookup_cache)
4826 (composition_gstring_put_cache):
4827 * composite.h (struct composition.hash_index):
4828 * dispextern.h (struct image.hash):
4829 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4830 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4831 (hashfn_equal, hashfn_user_defined, make_hash_table)
4832 (maybe_resize_hash_table, hash_lookup, hash_put)
4833 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4834 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4835 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4836 * image.c (make_image, search_image_cache, lookup_image)
4837 (xpm_put_color_table_h):
4838 * lisp.h (struct Lisp_Hash_Table):
4839 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4840 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4841 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4842 * alloc.c (allocate_vectorlike):
4843 Check for overflow in vector size calculations.
4844 * ccl.c (ccl_driver):
4845 Check for overflow when converting EMACS_INT to int.
4846 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4847 need to be updated by these changes.
4848 * fns.c (make_hash_table, maybe_resize_hash_table):
4849 Check for integer overflow with large hash tables.
4850 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4851 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4852 (SXHASH_REDUCE): New macro.
4853 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4854 Use it instead of discarding useful hash info with large hash values.
4855 (sxhash_float): New function.
4856 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4857 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4858 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4859 Rewrite to use FIXNUM_BITS, as this simplifies things.
4860 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4861 Adjust signatures to match updated version of code.
4862 (consing_since_gc): Now EMACS_INT, since a single hash table can
4863 use more than INT_MAX bytes.
4865 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4867 Make it possible to build with GCC-4.6+ -O2 -flto.
4869 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4871 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4873 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4874 Call minibuffer-inactive-mode.
4876 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4878 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4879 Update dependencies.
4881 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4883 * data.c (init_data): Remove code for UTS, this system is not
4886 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4888 Don't force ./temacs to start in terminal mode.
4890 * frame.c (make_initial_frame): Initialize faces in all cases, not
4891 only when CANNOT_DUMP is defined.
4892 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4894 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4896 * dispnew.c (add_window_display_history): Use const for the string
4897 pointer. Remove declaration, not needed.
4899 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4901 Use 'inline', not 'INLINE'.
4902 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4903 * alloc.c, fontset.c (INLINE): Remove.
4904 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4905 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4906 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4907 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4908 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4910 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4912 Make it possible to run ./temacs.
4914 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4915 syms_of_callproc does the same thing. Remove test for
4916 "initialized", do it in the caller.
4917 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4919 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4921 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4922 (read_minibuf): Use get_minibuffer.
4923 (syms_of_minibuf): Use DEFSYM.
4924 (Qmetadata): New var.
4925 * data.c (Qbuffer): Don't make it static.
4926 (syms_of_data): Use DEFSYM.
4928 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4930 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4931 (CCL_CODE_MIN): New macro.
4933 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4935 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4937 * eval.c (Qdebug): Now static.
4938 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4939 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4940 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4942 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4944 * image.c: Various fixes to ImageMagick code comments.
4945 (Fimagemagick_types): Doc fix.
4947 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4949 Minor fixes prompted by GCC 4.6.0 warnings.
4951 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4953 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4954 (x_clipboard_manager_save_all): Move extern decl to ...
4955 * xterm.h: ... here, so that it can be checked for consistency.
4957 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4959 * xselect.c (x_clipboard_manager_save_frame)
4960 (x_clipboard_manager_save_all): New functions.
4961 (Fx_clipboard_manager_save): Lisp function deleted.
4963 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4964 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4966 * xterm.h: Update prototype.
4968 2011-05-28 William Xu <william.xwl@gmail.com>
4970 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4973 2011-05-28 Jim Meyering <meyering@redhat.com>
4975 Avoid a sign-extension bug in crypto_hash_function.
4976 * fns.c (to_uchar): Define.
4977 (crypto_hash_function): Use it to convert some newly-signed
4978 variables to unsigned, to avoid sign-extension bugs. For example,
4979 without this change, (md5 "truc") would evaluate to
4980 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4981 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4982 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4984 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4986 Integer overflow fixes.
4988 * dbusbind.c: Serial number integer overflow fixes.
4989 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4990 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4991 to hold a serial number that is too large for a fixnum.
4992 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4993 Check for serial numbers out of range. Decode any serial number
4994 that was so large that it became a float. (Bug#8722)
4996 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4997 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4998 Use XFASTINT rather than XUINT when numbers are nonnegative.
4999 (xd_append_arg, Fdbus_method_return_internal):
5000 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5001 arguments, check that Lisp number is nonnegative, rather than
5002 silently wrapping negative numbers around. (Bug#8722)
5003 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5006 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5008 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5010 ccl: add integer overflow checks
5011 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5012 (IN_INT_RANGE): New macros.
5013 (ccl_driver): Use them to check for integer overflow when
5014 decoding a CCL program. Many of the new checks are whether XINT (x)
5015 fits in int; it doesn't always, on 64-bit hosts. The new version
5016 doesn't catch all possible integer overflows, but it's an
5017 improvement. (Bug#8719)
5019 * alloc.c (make_event_array): Use XINT, not XUINT.
5020 There's no need for unsigned here.
5022 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5023 This follows up to the 2011-05-06 change that substituted uintptr_t
5024 for EMACS_INT. This case wasn't caught back then.
5026 Rework Fformat to avoid integer overflow issues.
5027 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5028 now (part of C89). Include <verify.h>.
5029 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5030 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5031 (Fformat): Avoid the prepass trying to compute sizes; it was only
5032 approximate and thus did not catch overflow reliably. Instead, walk
5033 through the format just once, formatting and computing sizes as we go,
5034 checking for integer overflow at every step, and allocating a larger
5035 buffer as needed. Keep track separately whether the format is
5036 multibyte. Keep only the most-recently calculated precision, rather
5037 than them all. Record whether each argument has been converted to
5038 string. Use EMACS_INT, not int, for byte and char and arg counts.
5039 Support field widths and precisions larger than INT_MAX. Avoid
5040 sprintf's undefined behavior with conversion specifications such as %#d
5041 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5042 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5043 formatting out-of-range floating point numbers with int
5046 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5048 * data.c: Avoid integer truncation in expressions involving floats.
5049 * data.c: Include <intprops.h>.
5050 (arith_driver): When there's an integer overflow in an expression
5051 involving floating point, convert the integers to floating point
5052 so that the resulting value does not suffer from catastrophic
5053 integer truncation. For example, on a 64-bit host (* 4
5054 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5055 Do not rely on undefined behavior after integer overflow.
5057 merge count_size_as_multibyte, parse_str_to_multibyte
5058 * character.c, character.h (count_size_as_multibyte):
5059 Rename from parse_str_to_multibyte; all uses changed.
5060 Check for integer overflow.
5061 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5062 since it's now a duplicate of the other. This is more of
5063 a character than a buffer op, so better that it's in character.c.
5064 * fns.c, print.c: Adjust to above changes.
5066 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5068 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5070 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5072 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5073 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5074 (x_clipboard_manager_save): Now static.
5075 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5077 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5078 (crypto_hash_function): Now static.
5079 Fix pointer signedness problems. Avoid unnecessary initializations.
5081 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5083 * termhooks.h (Vselection_alist): Make it terminal-local.
5085 * terminal.c (create_terminal): Initialize it.
5087 * xselect.c: Support for clipboard managers.
5088 (Vselection_alist): Move to termhooks.h as terminal-local var.
5089 (LOCAL_SELECTION): New macro.
5090 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5091 (symbol_to_x_atom): Remove gratuitous arg.
5092 (x_handle_selection_request, lisp_data_to_selection_data)
5093 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5094 (x_own_selection, x_get_local_selection, x_convert_selection):
5095 New arg, specifying work frame. Use terminal-local Vselection_alist.
5096 (some_frame_on_display): Delete unused function.
5097 (Fx_own_selection_internal, Fx_get_selection_internal)
5098 (Fx_disown_selection_internal, Fx_selection_owner_p)
5099 (Fx_selection_exists_p): New optional frame arg.
5100 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5101 (x_handle_selection_clear): Don't treat other terminals with the
5102 same keyboard specially. Use the terminal-local Vselection_alist.
5103 (x_clear_frame_selections): Use Frun_hook_with_args.
5105 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5107 * xterm.h: Add support for those atoms.
5109 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5111 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5112 (converted_selections, conversion_fail_tag): New global variables.
5113 (x_selection_request_lisp_error): Free the above.
5114 (x_get_local_selection): Remove unnecessary code.
5115 (x_reply_selection_request): Args changed; handle arbitrary array
5116 of converted selections stored in converted_selections.
5117 Separate the XChangeProperty and SelectionNotify steps.
5118 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5119 (x_convert_selection): New function.
5120 (x_handle_selection_event): Simplify.
5121 (x_get_foreign_selection): Don't ignore incoming requests while
5122 waiting for an answer; this will fail when we implement
5123 SAVE_TARGETS, and seems unnecessary anyway.
5124 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5125 (Vx_sent_selection_functions): Doc fix.
5127 2011-05-26 Leo Liu <sdl.web@gmail.com>
5129 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5131 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5133 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5135 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5136 for fringe update if it has periodic bitmap.
5137 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5138 and fringe_bitmap_periodic_p.
5140 * fringe.c (get_fringe_bitmap_data): New function.
5141 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5142 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5143 row. Mark glyph row for fringe update if periodicity changed.
5145 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5146 for fringe update unless it has periodic bitmap.
5148 2011-05-25 Kenichi Handa <handa@m17n.org>
5150 * xdisp.c (get_next_display_element): Set correct it->face_id for
5151 a static composition.
5153 2011-05-24 Leo Liu <sdl.web@gmail.com>
5156 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5158 * fns.c (crypto_hash_function, Fsha1): New function.
5159 (Fmd5): Use crypto_hash_function.
5160 (syms_of_fns): Add Ssha1.
5162 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5164 * gnutls.c: Remove unused macros.
5165 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5166 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5167 Remove macros that are defined and never used.
5168 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5170 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5172 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5173 (Fx_get_selection_internal): Minor cleanup.
5174 (Fx_own_selection_internal): Rename arguments for consistency with
5177 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5179 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5181 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5183 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5185 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5187 * dispnew.c (scrolling_window): Don't exclude the case that the
5188 last enabled row in the desired matrix touches the bottom boundary.
5190 2011-05-21 Glenn Morris <rgm@gnu.org>
5192 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5193 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5194 and add some more files.
5196 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5198 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5199 report_file_error introduced by the change from 2011-05-07.
5201 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5203 * systime.h (Time): Define only if emacs is defined.
5204 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5205 where the include path doesn't have X11/X.h by default. See
5206 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5208 2011-05-20 Kenichi Handa <handa@m17n.org>
5210 * composite.c (find_automatic_composition): Fix previous change.
5212 2011-05-20 Glenn Morris <rgm@gnu.org>
5214 * lisp.mk: New file, split from Makefile.in.
5215 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5216 (shortlisp): Remove.
5217 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5219 2011-05-19 Glenn Morris <rgm@gnu.org>
5221 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5222 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5223 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5224 (lisp): Set the order to that of loadup.el.
5225 (shortlisp): Make it a copy of $lisp.
5226 (SOME_MACHINE_LISP): Remove.
5227 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5228 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5230 2011-05-18 Kenichi Handa <handa@m17n.org>
5232 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5233 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5234 (find_automatic_composition): Mostly rewrite for efficiency.
5236 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5238 * makefile.w32-in: Update dependencies.
5240 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5242 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5243 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5245 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5247 Fix some integer overflow issues, such as string length overflow.
5249 * insdel.c (count_size_as_multibyte): Check for string overflow.
5251 * character.c (lisp_string_width): Check for string overflow.
5252 Use EMACS_INT, not int, for string indexes and lengths; in
5253 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5254 the resulting string length overflows an EMACS_INT; instead,
5255 report a string overflow if no precision given. When checking for
5256 precision exhaustion, use a check that cannot possibly have
5257 integer overflow. (Bug#8675)
5258 * character.h (lisp_string_width): Adjust to new signature.
5260 * alloc.c (string_overflow): New function.
5261 (Fmake_string): Use it. This doesn't change behavior, but saves
5262 a few bytes and will simplify future changes.
5263 * character.c (string_escape_byte8): Likewise.
5264 * lisp.h (string_overflow): New decl.
5266 Fixups, following up to the user-interface timestamp change.
5267 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5268 for UI timestamps, instead of unsigned long.
5269 * msdos.c (mouse_get_pos): Likewise.
5270 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5271 * w32gui.h (Time): Define by including "systime.h" rather than by
5272 declaring it ourselves. (Bug#8664)
5274 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5275 * image.c (clear_image_cache): Likewise.
5277 * term.c (term_mouse_position): Don't assume time_t wraparound.
5279 Be more systematic about user-interface timestamps.
5280 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5281 and sometimes 'EMACS_UINT', to represent these timestamps.
5282 This change causes it to use 'Time' uniformly, as that's what X uses.
5283 This makes the code easier to follow, and makes it easier to catch
5284 integer overflow bugs such as Bug#8664.
5285 * frame.c (Fmouse_position, Fmouse_pixel_position):
5286 Use Time, not unsigned long, for user-interface timestamps.
5287 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5288 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5289 * keyboard.h (last_event_timestamp): Likewise.
5290 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5291 * menu.h (xmenu_show): Likewise.
5292 * term.c (term_mouse_position): Likewise.
5293 * termhooks.h (struct input_event.timestamp): Likewise.
5294 (struct terminal.mouse_position_hook): Likewise.
5295 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5296 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5297 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5298 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5300 * menu.h, termhooks.h: Include "systime.h", for Time.
5302 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5303 Don't assume that the difference between two unsigned long values
5304 can fit into an integer. At this point, we know button_down_time
5305 <= event->timestamp, so the difference must be nonnegative, so
5306 there's no need to cast the result if double-click-time is
5307 nonnegative, as it should be; check that it's nonnegative, just in
5308 case. This bug is triggered when events are more than 2**31 ms
5309 apart (about 25 days). (Bug#8664)
5311 * xselect.c (last_event_timestamp): Remove duplicate decl.
5312 (x_own_selection): Remove needless cast to unsigned long.
5314 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5315 that always fit in int. Use a sentinel instead of a counter, to
5316 avoid a temp and to allay GCC's concerns about possible int overflow.
5317 * frame.h (struct frame): Use int for menu_bar_items_used
5318 instead of EMACS_INT, since it always fits in int.
5320 * menu.c (grow_menu_items): Check for int overflow.
5322 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5324 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5325 Before, the code was not consistent. These values cannot exceed
5326 2**31 - 1 so there's no need to make them unsigned.
5327 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5328 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5329 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5331 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5333 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5334 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5335 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5336 presumably because the widths might not match.
5338 * window.c (size_window): Avoid needless test at loop start.
5340 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5342 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5344 2011-05-12 Drew Adams <drew.adams@oracle.com>
5346 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5348 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5350 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5351 `width' to `bar_area_x' and `bar_area_width', respectively.
5352 (x_scroll_run): Take account of fringe background extension.
5354 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5355 Rename local vars `left' and `width' to `bar_area_x' and
5356 `bar_area_width', respectively.
5357 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5358 background extension.
5360 2011-05-10 Jim Meyering <meyering@redhat.com>
5362 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5364 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5366 * image.c (Finit_image_library): Return t for built-in image types,
5367 like pbm and xbm. (Bug#8640)
5369 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5371 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5373 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5375 * w32console.c (Fset_screen_color): Doc fix.
5376 (Fget_screen_color): New function.
5377 (syms_of_ntterm): Defsubr it.
5379 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5380 unlink the temporary file if Fcall_process didn't create it in the
5382 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5383 child process will be redirected to a file specified with `:file'.
5384 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5385 cue to call_process_cleanup not to close that handle.
5387 2011-05-07 Ben Key <bkey76@gmail.com>
5389 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5390 one of two shell specific rules, either bootstrap-temacs-CMD or
5391 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5392 to the previous implementation of the bootstrap-temacs rule.
5393 The bootstrap-temacs-CMD rule is similar to the previous
5394 implementation of the bootstrap-temacs rule except that it
5395 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5398 These changes, along with some changes to nt/configure.bat,
5399 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5400 earlier fix to add support for --cflags and --ldflags options
5401 that include quotes so that it works whether make uses cmd or
5404 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5406 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5407 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5409 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5410 a string. Handle both cases.
5411 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5412 (Fdbus_register_method): Use Qinvalid_function.
5414 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5416 * makefile.w32-in: Update dependencies.
5417 (LISP_H): Add inttypes.h and stdin.h.
5418 (PROCESS_H): Add unistd.h.
5420 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5422 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5423 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5425 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5427 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5429 * term.c (vfatal): Remove stray call to va_end.
5430 It's not needed and the C Standard doesn't allow it here anyway.
5432 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5433 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5435 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5438 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5440 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5442 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5444 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5446 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5448 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5449 * charset.c (Fdefine_charset_internal): Don't initialize
5450 charset.code_space[15]. The value was garbage, on hosts with
5451 32-bit int (Bug#8600).
5453 * lread.c (read_integer): Be more consistent with string-to-number.
5454 Use string_to_number to do the actual conversion; this avoids
5455 rounding errors and fixes some other screwups. Without this fix,
5456 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5457 (digit_to_number): Move earlier, for benefit of read_integer.
5458 Return -1 if the digit is out of range for the base, -2 if it is
5459 not a digit in any supported base. (Bug#8602)
5461 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5463 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5464 to match comment at start of function. This also removes a
5465 GCC warning about overflow in a 32+64-bit port.
5467 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5469 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5470 Reported by Stefan Monnier in
5471 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5472 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5473 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5475 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5476 (EMACS_UINTPTR): Likewise, with uintptr_t.
5478 * lisp.h: Prefer 64-bit EMACS_INT if available.
5479 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5480 on 32-bit hosts that have 64-bit int, so that they can access
5482 However, temporarily disable this change unless the temporary
5483 symbol WIDE_EMACS_INT is defined.
5485 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5487 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5488 This removes an assumption that EMACS_INT and long are the same
5489 width as pointers. The assumption is true for Emacs porting targets
5490 now, but we want to make other targets possible.
5491 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5492 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5493 In the rest of the code, change types of integers that hold casted
5494 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5495 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5496 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5497 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5498 No need to cast type when ORing.
5499 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5500 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5501 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5502 assume EMACS_INT is the same width as char *.
5503 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5504 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5505 Remove no-longer-needed casts.
5506 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5507 (xg_tool_bar_help_callback, xg_make_tool_item):
5508 Use EMACS_INTPTR to hold an integer
5509 that will be cast to void *; this can avoid a GCC warning
5510 if EMACS_INT is not the same width as void *.
5511 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5512 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5513 (current_message_1, set_message_1):
5514 Use a local to convert to proper width without a cast.
5515 * xmenu.c (dialog_selection_callback): Likewise.
5517 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5518 Also, don't assume VALBITS / RAND_BITS is less than 5,
5519 and don't rely on undefined behavior when shifting a 1 left into
5521 * lisp.h (get_random): Change signature to match.
5523 * lread.c (hash_string): Use size_t, not int, for hash computation.
5524 Normally we prefer signed values; but hashing is special, because
5525 it's better to use unsigned division on hash table sizes so that
5526 the remainder is nonnegative. Also, size_t is the natural width
5527 for hashing into memory. The previous code used 'int', which doesn't
5528 retain enough info to hash well into very large tables.
5529 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5531 * dbusbind.c: Don't possibly lose pointer info when converting.
5532 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5533 Use XPNTR rather than XHASH, so that the high-order bits of
5534 the pointer aren't lost when converting through void *.
5536 * eval.c (Fautoload): Don't double-shift a pointer.
5538 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5540 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5542 * gnutls.c (DEF_GNUTLS_FN):
5543 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5545 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5547 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5550 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5552 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5553 New version that can reserve upto 2GB of heap space.
5555 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5557 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5559 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5561 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5562 `gnutls_certificate_set_x509_key_file'.
5564 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5566 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5567 Update dependencies.
5569 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5571 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5572 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5573 Remove unused parameter `fildes'.
5574 * process.c (read_process_output, send_process): Don't pass it.
5576 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5578 Fix previous change: the library cache is defined in w32.c.
5579 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5580 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5582 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5584 Implement dynamic loading of GnuTLS on Windows.
5586 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5587 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5588 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5591 * gnutls.c (Qgnutls_dll): Define.
5592 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5593 (gnutls_*): Declare function pointers.
5594 (init_gnutls_functions): New function to initialize function pointers.
5595 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5596 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5597 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5598 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5599 (emacs_gnutls_write, emacs_gnutls_read)
5600 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5601 (Fgnutls_available_p): New function.
5602 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5603 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5604 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5606 * image.c: Include w32.h.
5607 (Vimage_type_cache): Delete.
5608 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5609 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5610 (w32_delayed_load): Move to w32.c.
5612 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5614 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5615 (w32_delayed_load): Move from image.c. When loading a library, record
5616 its filename in the :loaded-from property of the library id.
5617 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5618 Initialize and staticpro them.
5619 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5621 * process.c: Include lisp.h before w32.h, not after.
5622 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5623 instead of gnutls_record_check_pending.
5625 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5627 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5629 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5630 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5633 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5635 * xterm.c (x_set_frame_alpha): Do not set property on anything
5636 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5638 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5640 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5642 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5644 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5645 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5646 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5647 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5648 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5649 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5650 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5651 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5652 (Qgnutls_bootprop_callbacks_verify): Make static.
5654 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5656 * callproc.c: Indentation fixup.
5658 * sysdep.c (wait_for_termination_1): Make static.
5659 (wait_for_termination, interruptible_wait_for_termination):
5660 Move after wait_for_termination_1.
5662 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5664 * sysdep.c (interruptible_wait_for_termination): New function
5665 which is like wait_for_termination, but allows keyboard
5668 * callproc.c (Fcall_process): Add (:file "file") as an option for
5670 (Fcall_process_region): Ditto.
5672 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5674 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5675 rather than `XVECTOR (FOO)->size'.
5677 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5678 inttypes.h, as a gnulib replacement is used if it not available in
5681 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5683 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5684 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5685 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5687 * coding.c (coding_alloc_by_realloc): Error out if destination
5688 will grow beyond MOST_POSITIVE_FIXNUM.
5689 (decode_coding_emacs_mule): Abort if there isn't enough place in
5690 charbuf for the composition carryover bytes. Reserve an extra
5691 space for up to 2 characters produced in a loop.
5692 (decode_coding_iso_2022): Abort if there isn't enough place in
5693 charbuf for the composition carryover bytes.
5695 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5697 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5698 aborting when %lld or %lll format is passed.
5699 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5700 %llo or %llx format is passed. (Bug#8545)
5702 * window.c (window_scroll_line_based): Use a marker instead of
5703 simple variables to record original value of point. (Bug#7952)
5705 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5706 produced by %s or %c overflows available buffer space. (Bug#8545)
5708 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5710 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5711 (SIZE_MAX): Move defn after all includes, as they might #define it.
5713 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5715 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5717 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5719 * keyboard.c (Qdelayed_warnings_hook): Define.
5720 (command_loop_1): Run `delayed-warnings-hook'
5721 if Vdelayed_warnings_list is non-nil.
5722 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5723 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5725 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5727 * doprnt.c (doprnt): Don't return value smaller than the buffer
5728 size if the message was truncated. (Bug#8545).
5730 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5732 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5733 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5735 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5737 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5739 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5741 * makefile.w32-in: Update dependencies.
5743 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5745 Improve `doprnt' and its usage. (Bug#8545)
5746 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5747 `format_end'. Remove support for %l as a conversion specifier.
5748 Don't use xrealloc. Improve diagnostics when the %l size modifier
5749 is used. Update the commentary.
5751 * eval.c (verror): Simplify calculation of size_t.
5753 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5756 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5758 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5761 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5763 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5764 This makes this file independent of the recent pseudovector change.
5766 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5768 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5770 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5771 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5772 Remove unused local.
5773 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5775 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5776 GCC 4.6.0 optimizes based on type-based alias analysis.
5777 For example, if b is of type struct buffer * and v of type struct
5778 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5779 != &v->size, and therefore "v->size = 1; b->size = 2; return
5780 v->size;" must therefore return 1. This assumption is incorrect
5781 for Emacs, since it type-puns struct Lisp_Vector * with many other
5782 types. To fix this problem, this patch adds a new type struct
5783 vectorlike_header that documents the constraints on layout of vectors
5784 and pseudovectors, and helps optimizing compilers not get fooled
5785 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5786 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5787 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5789 (XSETPVECTYPE): Rewrite in terms of new macro.
5790 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5791 This is a bit clearer, and further avoids the possibility of
5792 undesirable aliasing.
5793 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5794 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5795 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5796 since Lisp_Subr is a special case (no "next" field).
5797 (ASIZE): Now uses header.size rather than size.
5798 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5799 to avoid the hassle of writing XVECTOR (foo)->header.size.
5800 (struct vectorlike_header): New type.
5801 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5802 object, to help avoid aliasing.
5803 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5804 (SUBRP): Likewise, since Lisp_Subr is a special case.
5805 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5806 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5807 (struct Lisp_Hash_Table): Combine first two members into a single
5808 struct vectorlike_header member. All uses of "size" and "next" members
5809 changed to be "header.size" and "header.next".
5810 * buffer.h (struct buffer): Likewise.
5811 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5812 * frame.h (struct frame): Likewise.
5813 * process.h (struct Lisp_Process): Likewise.
5814 * termhooks.h (struct terminal): Likewise.
5815 * window.c (struct save_window_data, struct saved_window): Likewise.
5816 * window.h (struct window): Likewise.
5817 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5818 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5819 * buffer.c (init_buffer_once): Likewise.
5820 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5822 * process.c (Fformat_network_address): Use local var for size,
5825 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5827 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5828 * data.c (atof): Remove decl; no longer used or needed.
5829 (digit_to_number): Move to lread.c.
5830 (Fstring_to_number): Use new string_to_number function, to be
5831 consistent with how the Lisp reader treats infinities and NaNs.
5832 Do not assume that floating-point numbers represent EMACS_INT
5833 without losing information; this is not true on most 64-bit hosts.
5834 Avoid double-rounding errors, by insisting on integers when
5835 parsing non-base-10 numbers, as the documentation specifies.
5836 * lisp.h (string_to_number): New decl, replacing ...
5837 (isfloat_string): Remove.
5838 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5839 (read1): Do not accept +. and -. as integers; this
5840 appears to have been a coding error. Similarly, do not accept
5841 strings like +-1e0 as floating point numbers. Do not report
5842 overflow for integer overflows unless the base is not 10 which
5843 means we have no simple and reliable way to continue.
5844 Break out the floating-point parsing into a new
5845 function string_to_number, so that Fstring_to_number parses
5846 floating point numbers consistently with the Lisp reader.
5847 (digit_to_number): Move here from data.c. Make it static inline.
5848 (E_CHAR, EXP_INT): Remove, replacing with ...
5849 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5850 (string_to_number): New function, replacing isfloat_string.
5851 This function checks for valid syntax and produces the resulting
5852 Lisp float number too. Rework it so that string-to-number
5853 no longer mishandles examples like "1.0e+". Use strtoumax,
5854 so that overflow for non-base-10 numbers is reported only when
5855 there's no portable and simple way to convert to floating point.
5857 * textprop.c (set_text_properties_1): Rewrite for clarity,
5858 and to avoid GCC warning about integer overflow.
5860 * intervals.h (struct interval): Use EMACS_INT for members
5861 where EMACS_UINT might cause problems. See
5862 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5863 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5864 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5866 (offset_intervals): Tell GCC not to worry about length overflow
5867 when negating a negative length.
5869 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5870 (overrun_check_free): Likewise.
5872 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5873 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5876 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5877 (gnutls_make_error): Rename local to avoid shadowing.
5878 (gnutls_emacs_global_deinit): ifdef out; not used.
5879 (Fgnutls_boot): Use const for pointer to readonly storage.
5880 Comment out unused local. Fix pointer signedness problems.
5882 * lread.c (openp): Don't stuff size_t into an 'int'.
5883 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5884 about possible signed overflow.
5886 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5887 (GDK_KEY_g): Don't define if already defined.
5888 (xg_prepare_tooltip): Avoid pointer signedness problem.
5889 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5891 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5892 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5894 * xfns.c (Fx_window_property): Simplify a bit,
5895 to make a bit faster and to avoid GCC 4.6.0 warning.
5896 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5898 * fns.c (internal_equal): Don't assume size_t fits in int.
5900 * alloc.c (compact_small_strings): Tighten assertion a little.
5902 Replace pEd with more-general pI, and fix some printf arg casts.
5903 * lisp.h (pI): New macro, generalizing old pEd macro to other
5904 conversion specifiers. For example, use "...%"pI"d..." rather
5905 than "...%"pEd"...".
5906 (pEd): Remove. All uses replaced with similar uses of pI.
5907 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5908 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5909 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5910 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5911 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5912 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5913 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5915 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5916 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5917 * print.c (safe_debug_print, print_object): Likewise.
5918 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5920 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5921 avoiding the 0 flag, which is not portable.
5922 * process.c (Fmake_network_process): Use pI to avoid cast.
5923 * region-cache.c (pp_cache): Likewise.
5924 * xdisp.c (decode_mode_spec): Likewise.
5925 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5926 behavior on 64-bit hosts with printf arg.
5927 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5928 (x_stop_queuing_selection_requests): Likewise.
5929 (x_get_window_property): Don't truncate byte count to an 'int'
5932 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5933 here, since it parses constructs like leading '-' and spaces,
5934 which are not wanted; and it overflows with large numbers.
5935 Instead, simply match F[0-9]+, which is what is wanted anyway.
5937 * alloc.c: Remove unportable assumptions about struct layout.
5938 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5939 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5940 (allocate_vectorlike, make_pure_vector): Use the new macros,
5941 plus offsetof, to remove unportable assumptions about struct layout.
5942 These assumptions hold on all porting targets that I know of, but
5943 they are not guaranteed, they're easy to remove, and removing them
5944 makes further changes easier.
5946 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5947 This doesn't fix a bug but makes the code clearer.
5948 (string_overrun_cookie): Now const. Use initializers that
5949 don't formally overflow signed char, to avoid warnings.
5950 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5951 can cause Emacs to crash when string overrun checking is enabled.
5952 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5953 multiple of sizeof (EMACS_INT); it need not be, if
5954 alignof(EMACS_INT) < sizeof (EMACS_INT).
5955 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5957 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5959 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5961 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5963 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5964 supposed to be handshaking. (Bug#8556)
5965 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5967 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5969 * lisp.h (Qdebug): List symbol.
5970 * eval.c (Qdebug): Restore global linkage.
5971 * keyboard.c (debug-on-event): New variable.
5972 (handle_user_signal): Break into debugger when debug-on-event
5973 matches the current signal symbol.
5975 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5977 * alloc.c (check_sblock, check_string_bytes)
5978 (check_string_free_list): Convert to standard C.
5980 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5982 * w32.c (emacs_gnutls_push): Fix typo.
5984 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5986 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5987 "cast to pointer from integer of different size".
5989 Improve doprnt and its use in verror. (Bug#8545)
5990 * doprnt.c (doprnt): Document the set of format control sequences
5991 supported by the function. Use SAFE_ALLOCA instead of always
5994 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5995 is one byte too soon. Don't use xrealloc; instead xfree and
5998 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6000 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6003 * gnutls.c: Renamed global_initialized to
6004 gnutls_global_initialized. Added internals for the
6005 :verify-hostname-error, :verify-error, and :verify-flags
6006 parameters of `gnutls-boot' and documented those parameters in the
6007 docstring. Start callback support.
6008 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6009 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6010 on error. Return error code.
6011 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6012 (emacs_gnutls_read): Likewise.
6013 (Fgnutls_boot): Return handshake error code.
6014 (emacs_gnutls_handle_error): New function.
6015 (wsaerror_to_errno): Likewise.
6017 * w32.h (emacs_gnutls_pull): Add prototype.
6018 (emacs_gnutls_push): Likewise.
6020 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6021 (emacs_gnutls_push): Likewise.
6023 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6025 * process.c (wait_reading_process_output): Check if GnuTLS
6026 buffered some data internally if no FDs are set for TLS
6029 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6030 (LIBS): Link to USER_LIBS.
6031 ($(BLD)/gnutls.$(0)): New target.
6033 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6035 * xdisp.c (handle_single_display_spec): Rename the
6036 display_replaced_before_p argument into display_replaced_p, to
6037 make it consistent with the commentary. Fix typos in the
6040 * textprop.c (syms_of_textprop): Remove dead code.
6041 (copy_text_properties): Delete obsolete commentary about an
6042 interface that was deleted long ago. Fix typos in the description
6045 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6046 to changes in oldXMenu/XMenu.h from 2011-04-16.
6047 <menu_help_message, prev_menu_help_message>: Constify.
6048 (IT_menu_make_room): menu->help_text is now `const char **';
6051 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6052 to changes in oldXMenu/XMenu.h from 2011-04-16.
6053 (struct XMenu): Declare `help_text' `const char **'.
6055 * xfaces.c <Qunspecified>: Make extern again.
6057 * syntax.c: Include sys/types.h before including regex.h, as
6060 * doc.c (get_doc_string): Improve the format passed to `error'.
6062 * doprnt.c (doprnt): Improve commentary.
6064 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6066 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6069 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6070 changes in globals.h immediately force recompilation.
6071 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6072 $(CURDIR)/s/ms-w32.h.
6073 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6075 * character.c (Fchar_direction): Function deleted.
6076 (syms_of_character): Don't defsubr it.
6077 <char-direction-table>: Deleted.
6079 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6081 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6082 * doprnt.c: Include limits.h.
6083 (SIZE_MAX): New macro.
6084 (doprnt): Return a size_t value. 2nd arg is now size_t.
6085 Many local variables are now size_t instead of int or unsigned.
6086 Improve overflow protection. Support `l' modifier for integer
6087 conversions. Support %l conversion. Don't assume an EMACS_INT
6088 argument for integer conversions and for %c.
6090 * lisp.h (doprnt): Restore prototype.
6092 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6095 * Makefile.in (base_obj): Add back doprnt.o.
6097 * deps.mk (doprnt.o): Add back prerequisites.
6098 (callint.o): Depend on character.h.
6100 * eval.c (internal_lisp_condition_case): Include the handler
6101 representation in the error message.
6102 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6103 when breaking from the loop.
6105 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6107 * callint.c (Fcall_interactively): When displaying error message
6108 about invalid control letter, pass the character's codepoint, not
6109 a pointer to its multibyte form. Improve display of the character
6110 in octal and display also its hex code.
6112 * character.c (char_string): Use %x to display the (unsigned)
6113 codepoint of an invalid character, to avoid displaying a bogus
6116 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6117 `error', not SYMBOL_NAME itself.
6119 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6120 character arguments to `error'.
6122 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6123 to `error' in error message about FINAL_CHAR argument. Make sure
6124 FINAL_CHAR is a character, and use %c when it is passed as
6125 argument to `error'.
6127 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6129 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6131 * w32.c: Include <time.h>.
6132 (sys_localtime): New function.
6134 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6136 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6138 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6140 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6142 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6145 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6147 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6148 gl_state.e_property when gl_state.object is Qt.
6150 * insdel.c (make_gap_larger): Remove limitation of buffer size
6153 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6155 * xdisp.c (lookup_glyphless_char_display)
6156 (produce_glyphless_glyph): Handle cons cell entry in
6157 glyphless-char-display.
6158 (Vglyphless_char_display): Document it.
6160 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6161 glyphless-char-display.
6163 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6165 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6167 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6169 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6170 definition for no-X builds.
6172 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6174 Static checks with GCC 4.6.0 and non-default toolkits.
6176 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6178 * process.c (keyboard_bit_set): Define only if SIGIO.
6179 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6180 (send_process): Repair possible setjmp clobbering.
6182 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6184 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6186 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6188 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6189 Define only if needed.
6191 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6192 by pacifying GCC about it. Maybe it's time to retire it?
6193 * xfaces.c (USG, __TIMEVAL__): Likewise.
6195 * dispextern.h (struct redisplay_interface): Rename param
6197 * termhooks.h (struct terminal): Likewise.
6198 * xterm.c (xembed_send_message): Likewise.
6200 * insdel.c (make_gap_smaller): Define only if
6201 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6203 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6206 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6207 so that we aren't warned about unused symbols.
6209 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6211 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6213 * xfns.c (x_real_positions): Mark locals as initialized.
6215 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6217 * xterm.c: Fix problems found by static analysis with other toolkits.
6218 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6219 (x_dispatch_event): Declare static if USE_GTK, and
6220 define if USE_GTK || USE_X_TOOLKIT.
6221 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6222 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6223 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6224 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6226 * xmenu.c (menu_help_callback): Pointer type fixes.
6227 Use const pointers when pointing at readonly data. Avoid pointer
6229 (FALSE): Remove unused macro.
6230 (update_frame_menubar): Remove unused decl.
6232 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6234 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6235 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6236 (single_menu_item): Rename local to avoid shadowing.
6238 * keyboard.c (make_lispy_event): Remove unused local var.
6240 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6241 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6243 * bitmaps: Change bitmaps from unsigned char back to the X11
6244 compatible char. Avoid the old compiler warnings about
6245 out-of-range initializers by using, for example, '\xab' rather
6248 * xgselect.c (xgselect_initialize): Check vs interface
6249 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6251 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6253 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6254 to read-only memory.
6256 * fns.c (vector): Remove; this old hack is no longer needed.
6258 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6260 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6262 * xrdb.c (x_load_resources): Omit unused local.
6264 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6265 (x_window): Rename locals to avoid shadowing.
6266 (USG): Use the kludged USG macro, to pacify gcc.
6268 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6269 (x_term_init): Remove local to avoid shadowing.
6271 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6273 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6274 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6276 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6278 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6280 Fix regex.c, syntax.c and friends for buffers > 2GB.
6281 * syntax.h (struct gl_state_s): Declare character position members
6284 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6286 * textprop.c (verify_interval_modification, interval_of):
6287 Declare arguments EMACS_INT.
6289 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6292 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6294 * indent.c (Fvertical_motion): Local variable it_start is now
6297 * regex.c (re_match, re_match_2, re_match_2_internal)
6298 (bcmp_translate, regcomp, regexec, print_double_string)
6299 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6300 (re_compile_pattern, re_exec): Declare arguments and local
6301 variables `size_t' and `ssize_t' and return values `regoff_t', as
6303 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6304 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6305 <compile_stack_type>: `size' and `avail' are now `size_t'.
6307 * regex.h <regoff_t>: Use ssize_t, not int.
6308 (re_search, re_search_2, re_match, re_match_2): Arguments that
6309 specify buffer/string position and length are now ssize_t and
6310 size_t. Return type is regoff_t.
6312 2011-04-16 Ben Key <bkey76@gmail.com>
6314 * nsfont.m: Fixed bugs in ns_get_family and
6315 ns_descriptor_to_entity that were caused by using free to
6316 deallocate memory blocks that were allocated by xmalloc (via
6317 xstrdup). This caused Emacs to crash when compiled with
6318 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6319 --enable-checking=xmallocoverrun). xfree is now used to
6320 deallocate these memory blocks.
6322 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6324 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6326 emacs_write: Accept and return EMACS_INT for sizes.
6327 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6329 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6330 Accept and return EMACS_INT.
6331 (emacs_gnutls_write): Return the number of bytes written on
6333 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6334 (emacs_read, emacs_write): Remove check for negative size, as the
6335 Emacs source code has been audited now.
6336 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6337 (emacs_read, emacs_write): Use it.
6338 * process.c (send_process): Adjust to the new signatures of
6339 emacs_write and emacs_gnutls_write. Do not attempt to store
6340 a byte offset into an 'int'; it might overflow.
6341 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6343 * sound.c: Don't assume sizes fit in 'int'.
6344 (struct sound_device.period_size, alsa_period_size):
6345 Return EMACS_INT, not int.
6346 (struct sound_device.write, vox_write, alsa_write):
6347 Accept EMACS_INT, not int.
6348 (wav_play, au_play): Use EMACS_INT to store sizes and to
6349 record read return values.
6351 2011-04-15 Ben Key <bkey76@gmail.com>
6353 * keyboard.c (Qundefined): Don't declare static since it is used
6355 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6356 static since they are used in nsfont.m.
6358 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6360 * process.c (Qprocessp): Don't declare static.
6361 * lisp.h (Qprocessp): Declare again.
6363 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6365 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6367 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6369 Improve C-level modularity by making more things 'static'.
6371 Don't publish debugger-only interfaces to other modules.
6372 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6373 (verify_bytepos, count_markers): Move decls to the only modules
6375 * region-cache.h (pp_cache): Likewise.
6376 * window.h (check_all_windows): Likewise.
6377 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6379 * sysdep.c (croak): Now static, if
6380 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6381 * syssignal.h (croak): Declare only if not static.
6383 * alloc.c (refill_memory_reserve): Now static if
6384 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6385 * lisp.h (refill_memory_reserve): Declare only if not static.
6387 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6388 Define only if USE_LUCID.
6390 * xrdb.c (x_customization_string, x_rm_string): Now static.
6392 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6393 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6395 * xdisp.c (draw_row_with_mouse_face): Now static.
6396 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6398 * window.h (check_all_windows): Mark externally visible.
6400 * window.c (window_deletion_count): Now static.
6402 * undo.c: Make symbols static if they're not exported.
6403 (last_undo_buffer, last_boundary_position, pending_boundary):
6406 * textprop.c (interval_insert_behind_hooks): Now static.
6407 (interval_insert_in_front_hooks): Likewise.
6409 * term.c: Make symbols static if they're not exported.
6410 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6411 (max_frame_lines, tty_set_terminal_modes):
6412 (tty_reset_terminal_modes, tty_turn_off_highlight):
6413 (get_tty_terminal): Now static.
6414 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6415 * termhooks.h (term_mouse_moveto): Do not declare if
6417 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6418 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6420 * sysdep.c: Make symbols static if they're not exported.
6421 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6423 (sigprocmask_set, full_mask): Remove; unused.
6424 (wait_debugging): Mark as visible.
6425 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6426 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6428 * syntax.c (syntax_temp): Define only if !__GNUC__.
6430 * sound.c (current_sound_device, current_sound): Now static.
6432 * search.c (searchbufs, searchbuf_head): Now static.
6434 * scroll.c (scroll_cost): Remove; unused.
6435 * dispextern.h (scroll_cost): Remove decl.
6437 * region-cache.h (pp_cache): Mark as externally visible.
6439 * process.c: Make symbols static if they're not exported.
6440 (process_tick, update_tick, create_process, chan_process):
6441 (Vprocess_alist, proc_buffered_char, datagram_access):
6442 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6443 (deactivate_process): Mark defn as static, as well as decl.
6444 * lisp.h (create_process): Remove decl.
6445 * process.h (chan_process, Vprocess_alist): Remove decls.
6447 * print.c: Make symbols static if they're not exported.
6448 (print_depth, new_backquote_output, being_printed, print_buffer):
6449 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6450 (print_interval, print_number_index, initial_stderr_stream):
6452 * lisp.h (Fprinc): Remove decl.
6453 (debug_output_compilation_hack): Mark as externally visible.
6455 * sysdep.c (croak): Move decl from here to syssignal.h.
6456 * syssignal.h (croak): Put it here, so the API can be checked when
6457 'croak' is called from dissociate_if_controlling_tty.
6459 * minibuf.c: Make symbols static if they're not exported.
6460 (minibuf_save_list, choose_minibuf_frame): Now static.
6461 * lisp.h (choose_minibuf_frame): Remove decl.
6463 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6465 * lread.c: Make symbols static if they're not exported.
6466 (read_objects, initial_obarray, oblookup_last_bucket_number):
6468 (make_symbol): Remove; unused.
6469 * lisp.h (initial_obarray, make_symbol): Remove decls.
6471 * keyboard.c: Make symbols static if they're not exported.
6472 (single_kboard, recent_keys_index, total_keys, recent_keys):
6473 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6474 (this_single_command_key_start, echoing, last_auto_save):
6475 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6476 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6477 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6478 (Vlispy_mouse_stem, double_click_count):
6480 (force_auto_save_soon): Define only if SIGDANGER.
6481 (ignore_mouse_drag_p): Now static if
6482 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6483 (print_help): Remove; unused.
6484 (stop_character, last_timer_event): Mark as externally visible.
6485 * keyboard.h (ignore_mouse_drag_p): Declare only if
6486 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6487 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6488 * lisp.h (echoing): Remove decl.
6489 (force_auto_save_soon): Declare only if SIGDANGER.
6490 * xdisp.c (redisplay_window): Simplify code, to make it more
6491 obvious that ignore_mouse_drag_p is not accessed if !defined
6492 USE_GTK && !defined HAVE_NS.
6494 * intervals.c: Make symbols static if they're not exported.
6495 (merge_properties_sticky, merge_interval_right, delete_interval):
6497 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6499 * insdel.c: Make symbols static if they're not exported.
6500 However, leave prepare_to_modify_buffer alone. It's never
6501 called from outside this function, but that appears to be a bug.
6502 (combine_after_change_list, combine_after_change_buffer):
6503 (adjust_after_replace, signal_before_change): Now static.
6504 (adjust_after_replace_noundo): Remove; unused.
6505 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6506 (signal_before_change): Remove decls.
6508 * indent.c (val_compute_motion, val_vmotion): Now static.
6510 * image.c: Make symbols static if they're not exported.
6511 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6513 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6514 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6516 * fringe.c (standard_bitmaps): Now static.
6517 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6519 * frame.c: Make symbols static if they're not exported.
6520 (x_report_frame_params, make_terminal_frame): Now static.
6521 (get_frame_param): Now static, unless HAVE_NS.
6522 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6523 (x_get_resource_string): Remove; not used.
6524 * frame.h (make_terminal_frame, x_report_frame_params):
6525 (x_get_resource_string); Remove decls.
6526 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6527 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6529 * font.c, fontset.c: Make symbols static if they're not exported.
6530 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6531 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6532 * font.c (font_close_object): Now static.
6533 * font.h (font_close_object): Remove.
6534 * fontset.c (FONTSET_OBJLIST): Remove.
6535 (free_realized_fontset) #if-0 the body, which does nothing.
6536 (face_suitable_for_char_p): #if-0, as it's never called.
6537 * fontset.h (face_suitable_for_char_p): Remove decl.
6538 * xfaces.c (face_at_string_position):
6539 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6540 since 0 is always ASCII.
6542 * fns.c (weak_hash_tables): Now static.
6544 * fileio.c: Make symbols static if they're not exported.
6545 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6546 (Vwrite_region_annotation_buffers): Now static.
6548 * eval.c: Make symbols static if they're not exported.
6549 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6550 * lisp.h (backtrace_list): Remove decl.
6552 * emacs.c: Make symbols static if they're not exported.
6553 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6554 (fatal_error_code, fatal_error_signal_hook, standard_args):
6556 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6557 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6558 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6559 * lisp.h (fatal_error_signal_hook): Remove decl.
6560 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6562 * editfns.c: Move a (normally-unused) function to its only use.
6563 * editfns.c, lisp.h (get_operating_system_release): Remove.
6564 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6565 worth the hassle of breaking this out.
6567 * xterm.c: Make symbols static if they're not exported.
6568 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6569 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6570 (x_destroy_window, x_delete_display):
6572 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6573 (x_mouse_leave): Remove; unused.
6574 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6575 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6576 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6578 (x_mouse_leave): Declare only if WINDOWSNT.
6579 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6580 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6583 * ftxfont.c: Make symbols static if they're not exported.
6584 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6586 * font.h (ftxfont_driver): Likewise.
6588 * xfns.c: Make symbols static if they're not exported.
6589 (x_last_font_name, x_display_info_for_name):
6590 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6591 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6592 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6593 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6594 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6595 (last_show_tip_args): Now static.
6596 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6597 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6598 (x_screen_planes): Remove; unused.
6599 * dispextern.h (x_screen_planes): Remove decl.
6601 * dispnew.c: Make symbols static if they're not exported.
6602 * dispextern.h (redraw_garbaged_frames, scrolling):
6603 (increment_row_positions): Remove.
6604 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6605 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6607 (redraw_garbaged_frames): Remove; unused.
6609 * xfaces.c: Make symbols static if they're not exported.
6610 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6612 * xterm.h (defined_color): Remove decls.
6613 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6614 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6615 (menu_face_changed_default, defined_color, free_realized_face):
6616 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6617 (ascii_face_of_lisp_face): Remove; unused.
6619 * xdisp.c: Make symbols static if they're not exported.
6620 * dispextern.h (scratch_glyph_row, window_box_edges):
6621 (glyph_to_pixel_coords, set_cursor_from_row):
6622 (get_next_display_element, set_iterator_to_next):
6623 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6624 (show_mouse_face): Remove decls
6625 * frame.h (message_buf_print): Likewise.
6626 * lisp.h (pop_message, set_message, check_point_in_composition):
6628 * xterm.h (set_vertical_scroll_bar): Likewise.
6629 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6630 (message_buf_print, scratch_glyph_row, displayed_buffer):
6631 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6632 (get_next_display_element, show_mouse_face, window_box_edges):
6633 (frame_to_window_pixel_xy, check_point_in_composition):
6634 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6635 (glyph_to_pixel_coords): Remove; unused.
6637 * dired.c (file_name_completion): Now static.
6639 * dbusbind.c (xd_in_read_queued_messages): Now static.
6641 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6642 * data.c (circular_list_error): Remove.
6644 * commands.h (last_point_position, last_point_position_buffer):
6645 (last_point_position_window): Remove decls.
6646 * keyboard.c: Make these variables static.
6648 * coding.h (coding, code_convert_region, encode_coding_gap):
6650 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6651 (iso_code_class, detect_coding, code_convert_region): Now static.
6652 (encode_coding_gap): Remove; unused.
6654 * chartab.c (chartab_chars, chartab_bits): Now static.
6656 * charset.h (charset_iso_8859_1): Remove decl.
6657 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6660 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6661 * ccl.c (Vccl_program_table): Now static.
6662 (check_ccl_update): Remove; unused.
6664 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6665 * category.h: ... from here.
6666 * category.c (check_category_table, set_category_set): Now static.
6668 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6669 * lisp.h: Remove these decls.
6671 * buffer.c (buffer_count): Remove unused var.
6673 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6674 so that it's not optimized away.
6675 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6676 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6677 exported only to the debugger.
6679 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6680 * atimer.h (run_all_atimers): Remove; not exported.
6682 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6683 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6684 was inaccessible from Lisp.
6685 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6686 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6688 alloc.c: Import and export fewer symbols, and remove unused items.
6689 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6691 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6692 it's not optimized away by whole-program optimization.
6693 (message_enable_multibyte, free_misc): Remove.
6694 (catchlist, handlerlist, mark_backtrace):
6695 Declare only if BYTE_MARK_STACK.
6696 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6697 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6698 (message_enable_multibyte): Remove decl.
6699 (free_misc, interval_free_list, float_block, float_block_index):
6700 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6701 (cons_free_list, last_marked_index):
6703 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6704 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6705 (mark_backtrace): Define only if BYTE_MARK_STACK.
6706 * xdisp.c (message_enable_multibyte): Now static.
6708 Declare Lisp_Object Q* variables to be 'static' if not exported.
6709 This makes it easier for human readers (and static analyzers)
6710 to see whether these variables are used from other modules.
6711 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6712 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6713 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6714 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6715 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6716 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6717 * xmenu.c, xselect.c:
6718 Declare Q* vars static if they are not used in other modules.
6719 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6720 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6721 Remove decls of unexported vars.
6722 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6724 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6726 Make Emacs functions such as Fatom 'static' by default.
6727 This makes it easier for human readers (and static analyzers)
6728 to see whether these functions can be called from other modules.
6729 DEFUN now defines a static function. To make the function external
6730 so that it can be used in other C modules, use the new macro DEFUE.
6731 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6732 (Finit_image_library):
6733 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6734 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6735 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6736 Remove decls, since these functions are now static.
6737 (Funintern, Fget_internal_run_time): New decls, since these functions
6738 were already external.
6740 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6741 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6742 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6743 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6744 * keyboard.c, keymap.c, lread.c:
6745 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6746 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6747 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6748 Mark functions with DEFUE instead of DEFUN,
6749 if they are used in other modules.
6750 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6751 decls for now-static functions.
6752 * buffer.h (Fdelete_overlay): Remove decl.
6753 * callproc.c (Fgetenv_internal): Mark as internal.
6754 * composite.c (Fremove_list_of_text_properties): Remove decl.
6755 (Fcomposition_get_gstring): New forward static decl.
6756 * composite.h (Fcomposite_get_gstring): Remove decl.
6757 * dired.c (Ffile_attributes): New forward static decl.
6758 * doc.c (Fdocumntation_property): New forward static decl.
6759 * eval.c (Ffetch_bytecode): New forward static decl.
6760 (Funintern): Remove extern decl; now in .h file where it belongs.
6761 * fileio.c (Fmake_symbolic_link): New forward static decl.
6762 * image.c (Finit_image_library): New forward static decl.
6763 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6764 * intervals.h (Fprevious_property_change):
6765 (Fremove_list_of_text_properties): Remove decls.
6766 * keyboard.c (Fthis_command_keys): Remove decl.
6767 (Fcommand_execute): New forward static decl.
6768 * keymap.c (Flookup_key): New forward static decl.
6769 (Fcopy_keymap): Now static.
6770 * keymap.h (Flookup_key): Remove decl.
6771 * process.c (Fget_process): New forward static decl.
6772 (Fprocess_datagram_address): Mark as internal.
6773 * syntax.c (Fsyntax_table_p): New forward static decl.
6774 (skip_chars): Remove duplicate decl.
6775 * textprop.c (Fprevious_property_change): New forward static decl.
6776 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6778 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6779 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6781 * editfns.c (Fformat): Remove unreachable code.
6783 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6785 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6788 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6790 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6791 when at ZV. (Bug#8487)
6793 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6795 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6797 * keyboard.c (parse_tool_bar_item): Likewise.
6798 * sound.c (sound_cleanup, alsa_close): Likewise.
6799 * termcap.c (tgetent): Likewise.
6800 * xfns.c (x_default_font_parameter): Likewise.
6801 * xsettings.c (read_and_apply_settings): Likewise.
6803 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6804 (overrun_check_free): Protoize.
6806 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6808 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6809 since callers should never pass a negative size.
6810 Change the signature to match that of plain 'read' and 'write'; see
6811 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6812 * lisp.h: Update prototypes of emacs_write and emacs_read.
6814 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6816 * xdisp.c (redisplay_window): Don't try to determine the character
6817 position of the scroll margin if the window start point w->startp
6818 is outside the buffer's accessible region. (Bug#8468)
6820 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6822 Fix write-region and its subroutines for buffers > 2GB.
6823 * fileio.c (a_write, e_write): Modify declaration of arguments and
6824 local variables to support buffers larger than 2GB.
6825 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6827 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6828 argument, local variables, and return value.
6830 * lisp.h: Update prototypes of emacs_write and emacs_read.
6832 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6834 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6836 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6838 Fix more problems found by GCC 4.6.0's static checks.
6840 * xdisp.c (vmessage): Use a better test for character truncation.
6842 * charset.c (load_charset_map): <, not <=, for optimization,
6843 and to avoid potential problems with integer overflow.
6844 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6845 * casetab.c (set_identity, shuffle): Likewise.
6846 * editfns.c (Fformat): Likewise.
6847 * syntax.c (skip_chars): Likewise.
6849 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6850 This also lets GCC 4.6.0 generate slightly better loop code.
6852 * callint.c (Fcall_interactively): <, not <=, for optimization.
6853 (Fcall_interactively): Count the number of arguments produced,
6854 not the number of arguments given. This is simpler and lets GCC
6855 4.6.0 generate slightly better code.
6857 * ftfont.c: Distingish more carefully between FcChar8 and char.
6858 The previous code passed unsigned char * to a functions like
6859 strlen and xstrcasecmp that expect char *, which does not
6860 conform to the C standard.
6861 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6862 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6863 char * when the C standard requires it.
6865 * keyboard.c (read_char): Remove unused var.
6867 * eval.c: Port to Windows vsnprintf (Bug#8435).
6869 (SIZE_MAX): Define if the headers do not.
6870 (verror): Do not give up if vsnprintf returns a negative count.
6871 Instead, grow the buffer. This ports to Windows vsnprintf, which
6872 does not conform to C99. Problem reported by Eli Zaretskii.
6873 Also, simplify the allocation scheme, by avoiding the need for
6874 calling realloc, and removing the ALLOCATED variable.
6876 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6878 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6879 But keep the doprint source code for now, as we might revamp it
6880 and use it again (Bug#8435).
6881 * lisp.h (doprnt): Remove.
6882 * Makefile.in (base_obj): Remove doprnt.o.
6883 * deps.mk (doprnt.o): Remove.
6885 error: Print 32- and 64-bit integers portably (Bug#8435).
6886 Without this change, on typical 64-bit hosts error ("...%d...", N)
6887 was used to print both 32- and 64-bit integers N, which relied on
6889 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6891 * lisp.h (error, verror): Mark as printf-like functions.
6892 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6893 Report overflow in size calculations when allocating printf buffer.
6894 Do not truncate output string at its first null byte.
6895 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6896 Truncate the output at a character boundary, since vsnprintf does not
6898 * charset.c (check_iso_charset_parameter): Convert internal
6899 character to string before calling 'error', since %c now has the
6901 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6902 overflow when computing char to be passed to 'error'. Do not
6903 pass Lisp_Object to 'error'; pass the integer instead.
6904 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6905 formatted with plain %d.
6907 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6909 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6911 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6913 * xterm.c (x_catch_errors): Remove duplicate declaration.
6915 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6917 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6919 2011-04-10 Jim Meyering <meyering@redhat.com>
6921 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6922 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6923 return ssize_t not "int", and use size_t as the buffer length.
6924 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6925 * gnutls.h: Update declarations.
6926 * process.c (read_process_output): Use ssize_t, to match.
6927 (send_process): Likewise.
6929 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6931 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6933 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6935 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6936 Use unsigned char, to match FcChar8 type definition.
6938 * xterm.c (handle_one_xevent):
6939 * xmenu.c (create_and_show_popup_menu):
6940 * xselect.c (x_decline_selection_request)
6941 (x_reply_selection_request): Avoid type-punned deref of X events.
6943 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6945 Fix some uses of `int' instead of EMACS_INT.
6946 * search.c (string_match_1, fast_string_match)
6947 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6948 (scan_buffer, find_next_newline_no_quit)
6949 (find_before_next_newline, search_command, Freplace_match)
6950 (Fmatch_data): Make some `int' variables be EMACS_INT.
6952 * xdisp.c (display_count_lines): 3rd argument and return value now
6953 EMACS_INT. All callers changed.
6954 (pint2hrstr): Last argument is now EMACS_INT.
6956 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6957 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6958 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6959 (decode_coding_utf_16, decode_coding_emacs_mule)
6960 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6961 (decode_coding_ccl, decode_coding_charset)
6962 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6963 (decode_coding_iso_2022, decode_coding_emacs_mule)
6964 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6965 <char_offset, last_offset>: Declare EMACS_INT.
6966 (encode_coding_utf_8, encode_coding_utf_16)
6967 (encode_coding_emacs_mule, encode_invocation_designation)
6968 (encode_designation_at_bol, encode_coding_iso_2022)
6969 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6970 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6972 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6973 (encode_invocation_designation): Last argument P_NCHARS is now
6975 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6976 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6978 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6981 * ccl.c (Fccl_execute_on_string): Declare some variables
6984 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6986 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6988 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6990 * process.c (Fformat_network_address): Doc fix.
6992 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6994 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6996 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6998 * keyboard.c (read_char): Call Lisp function help-form-show,
6999 instead of using internal_with_output_to_temp_buffer.
7000 (Qhelp_form_show): New var.
7001 (syms_of_keyboard): Use DEFSYM macro.
7003 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7005 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7007 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7009 * process.c (Flist_processes): Remove to Lisp.
7010 (list_processes_1): Delete.
7012 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7014 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7016 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7018 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7020 Fix more problems found by GCC 4.6.0's static checks.
7022 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7024 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7026 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7028 * xdisp.c (vmessage): Mark as a printf-like function.
7030 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7032 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7034 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7035 printf-like functions.
7036 (tiff_load): Add casts to remove these marks before passing them
7037 to system-supplied API.
7039 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7041 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7042 This avoids several warnings with gcc -Wstrict-overflow.
7043 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7044 directly, rather than having caller test rule sign. This avoids
7045 some unnecessary tests.
7046 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7047 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7048 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7050 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7051 (xfont_open): Avoid unnecessary tests.
7053 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7055 * composite.h, composite.c (composition_gstring_put_cache):
7056 Use EMACS_INT, not int, for length.
7058 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7059 breaking out part of COMPOSITION_DECODE_RULE.
7060 (COMPOSITION_DECODE_RULE): Use it.
7061 * composite.c (get_composition_id): Remove unused local vars,
7062 by using the new macro.
7064 * textprop.c (set_text_properties_1): Change while to do-while,
7065 since the condition is always true at first.
7067 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7068 (interval_deletion_adjustment): Return unsigned value.
7071 * process.c (list_processes_1, create_pty, read_process_output):
7072 (exec_sentinel): Remove vars that were set but not used.
7073 (create_pty): Remove unnecessary "volatile"s.
7074 (Fnetwork_interface_info): Avoid possibility of int overflow.
7075 (read_process_output): Do adaptive read buffering even if carryover.
7076 (read_process_output): Simplify nbytes computation if buffered.
7078 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7080 * syntax.c (scan_words): Remove var that was set but not used.
7081 (update_syntax_table): Use unsigned instead of int.
7083 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7084 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7085 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7087 * print.c (print_error_message): Avoid int overflow.
7089 * font.c (font_list_entities): Redo for clarity,
7090 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7092 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7093 (font_score): Avoid potential overflow in diff calculation.
7095 * fns.c (substring_both): Remove var that is set but not used.
7096 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7098 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7100 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7101 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7102 can always succeed if overflow has undefined behavior.
7104 * search.c (boyer_moore, wordify): Remove vars set but not used.
7105 (wordify): Omit three unnecessary tests.
7107 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7108 All callers changed. This avoids the need for an unused var.
7110 * casefiddle.c (casify_region): Remove var that is set but not used.
7112 * dired.c (file_name_completion): Remove var that is set but not used.
7114 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7116 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7117 (Finsert_file_contents): Remove unnecessary code checking fd.
7119 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7120 Check for integer overflow on size calculations.
7122 * buffer.c (Fprevious_overlay_change): Remove var that is set
7125 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7126 Remove vars that are set but not used.
7127 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7128 (timer_check_2): Mark vars as initialized.
7130 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7132 * image.c (lookup_image): Remove var that is set but not used.
7133 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7135 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7136 that are set but not used.
7138 * xfns.c (make_invisible_cursor): Don't return garbage
7139 if XCreateBitmapFromData fails (Bug#8410).
7141 * xselect.c (x_get_local_selection, x_handle_property_notify):
7142 Remove vars that are set but not used.
7144 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7145 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7147 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7148 Remove var that is set but not used.
7149 (scroll_bar_windows_size): Now size_t, not int.
7150 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7153 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7154 (map_tty_color) [!defined MSDOS]: Likewise.
7156 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7158 * coding.c: Remove vars that are set but not used.
7159 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7160 All callers changed.
7161 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7162 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7163 (decode_coding_charset): Remove vars that are set but not used.
7165 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7166 that is set but not used.
7168 * print.c (print_object): Remove var that is set but not used.
7170 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7171 The gnulib version avoids calling malloc in the usual case,
7172 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7173 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7174 * filelock.c (current_lock_owner): Likewise.
7175 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7176 * sysdep.c: Include allocator.h, careadlinkat.h.
7177 (emacs_no_realloc_allocator): New static constant.
7178 (emacs_readlink): New function.
7179 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7180 ../lib/careadlinkat.h.
7182 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7184 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7185 first non-nil return value).
7187 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7189 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7190 if not defined (Bug#8403).
7192 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7194 * xdisp.c (display_count_lines): Remove parameter `start',
7195 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7196 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7197 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7198 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7199 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7200 and thereabouts. All callers changed.
7201 (get_per_char_metric): Remove parameter `f', unused since
7202 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7204 2011-04-02 Jim Meyering <meyering@redhat.com>
7206 do not dereference NULL upon failed strdup
7207 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7208 (ns_get_family): Likewise.
7210 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7212 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7214 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7216 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7219 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7221 Add lexical binding.
7223 * window.c (Ftemp_output_buffer_show): New fun.
7224 (Fsave_window_excursion):
7225 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7227 * lread.c (lisp_file_lexically_bound_p): New function.
7228 (Fload): Bind Qlexical_binding.
7229 (readevalloop): Remove `evalfun' arg.
7230 Bind Qinternal_interpreter_environment.
7231 (Feval_buffer): Bind Qlexical_binding.
7232 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7234 (syms_of_lread): Declare `lexical-binding'.
7236 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7238 * keyboard.c (eval_dyn): New fun.
7239 (menu_item_eval_property): Use it.
7241 * image.c (parse_image_spec): Use Ffunctionp.
7243 * fns.c (concat, mapcar1): Accept byte-code-functions.
7245 * eval.c (Fsetq): Handle lexical vars.
7246 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7247 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7248 (FletX, Flet): Obey lexical binding.
7249 (Fcommandp): Handle closures.
7250 (Feval): New `lexical' arg.
7251 (eval_sub): New function extracted from Feval. Use it almost
7252 everywhere where Feval was used. Look up vars in lexical env.
7254 (Ffunctionp): Move from subr.el.
7255 (Ffuncall): Handle closures.
7256 (apply_lambda): Remove `eval_flags'.
7257 (funcall_lambda): Handle closures and new byte-code-functions.
7258 (Fspecial_variable_p): New function.
7259 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7260 but without exporting it to Lisp.
7262 * doc.c (Fdocumentation, store_function_docstring):
7263 * data.c (Finteractive_form): Handle closures.
7265 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7268 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7270 (exec_byte_code): New function extracted from Fbyte_code to handle new
7271 calling convention for byte-code-functions. Add new byte-codes.
7273 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7275 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7277 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7279 * xdisp.c (redisplay_internal): Fix prototype.
7281 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7283 * xdisp.c (SCROLL_LIMIT): New macro.
7284 (try_scrolling): Use it when setting scroll_limit.
7285 Limit scrolling to 100 screen lines.
7286 (redisplay_window): Even when falling back on "recentering",
7287 position point in the window according to scroll-conservatively,
7288 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7290 (try_scrolling): When point is above the window, allow searching
7291 as far as scroll_max, or one screenful, to compute vertical
7292 distance from PT to the scroll margin position. This prevents
7293 try_scrolling from unnecessarily failing when
7294 scroll-conservatively is set to a value slightly larger than the
7295 window height. Clean up the case of PT below the margin at bottom
7296 of window: scroll_max can no longer be INT_MAX. When aggressive
7297 scrolling is in use, don't let point enter the opposite scroll
7298 margin as result of the scroll.
7299 (syms_of_xdisp) <scroll-conservatively>: Document the
7300 threshold of 100 lines for never-recentering scrolling.
7302 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7304 * dispextern.h (move_it_by_lines):
7305 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7306 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7307 (message_log_check_duplicate): Remove parameters `prev_bol' and
7308 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7309 (redisplay_internal): Remove parameter `preserve_echo_area',
7310 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7312 * indent.c (Fvertical_motion):
7313 * window.c (window_scroll_pixel_based, Frecenter):
7314 Don't pass `need_y_p' to `move_it_by_lines'.
7316 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7318 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7319 steal a few bits to be more compact.
7320 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7321 Remove unneeded casts.
7323 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7325 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7327 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7328 binding" message (bug#7967).
7330 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7332 Fix more problems found by GCC 4.6.0's static checks.
7334 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7335 Remove unused local var.
7337 * editfns.c (Fmessage_box): Remove unused local var.
7339 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7340 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7341 Omit unused local vars.
7342 * window.c (shrink_windows): Omit unused local var.
7343 * menu.c (digest_single_submenu): Omit unused local var.
7344 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7345 Omit unused local var.
7347 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7348 Don't assume string length fits in int.
7349 (keyremap_step, read_key_sequence): Use size_t for sizes.
7350 (read_key_sequence): Don't check last_real_key_start redundantly.
7352 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7353 instead of alloca (Bug#8344).
7355 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7356 (Fbacktrace_frame): Don't assume nframes fits in int.
7358 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7360 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7363 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7365 * cm.c (calccost): Turn while-do into do-while, for clarity.
7367 * keyboard.c (syms_of_keyboard): Use the same style as later
7368 in this function when indexing through an array. This also
7369 works around GCC bug 48267.
7371 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7373 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7375 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7376 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7378 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7379 This avoids undefined behavior on integer overflow, and is a bit
7380 more convenient anyway since it is compared to a size_t variable.
7382 Variadic C functions now count arguments with size_t, not int.
7383 This avoids an unnecessary limitation on 64-bit machines, which
7384 caused (substring ...) to crash on large vectors (Bug#8344).
7385 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7386 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7387 All variadic functions and their callers changed accordingly.
7388 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7389 * data.c (arith_driver, float_arith_driver): Likewise.
7390 * editfns.c (general_insert_function): Likewise.
7391 * eval.c (struct backtrace.nargs, interactive_p)
7392 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7393 (funcall_lambda, mark_backtrace): Likewise.
7394 * fns.c (concat): Likewise.
7395 * frame.c (x_set_frame_parameters): Likewise.
7396 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7397 0 if not found, not -1. All callers changed.
7399 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7400 (stack_copy_size): Now size_t, not int.
7401 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7403 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7405 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7406 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7407 All callers changed.
7409 * lisp.h (multibyte_char_to_unibyte):
7410 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7411 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7412 * character.h (CHAR_TO_BYTE8):
7413 * cmds.c (internal_self_insert):
7414 * editfns.c (general_insert_function):
7415 * keymap.c (push_key_description):
7416 * search.c (Freplace_match):
7417 * xdisp.c (message_dolog, set_message_1): All callers changed.
7419 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7421 * keyboard.c (safe_run_hook_funcall): New function.
7422 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7423 don't set the hook to nil, but remove the offending function instead.
7424 (Qcommand_hook_internal): Remove, unused.
7425 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7426 Vcommand_hook_internal.
7428 * eval.c (enum run_hooks_condition): Remove.
7429 (funcall_nil, funcall_not): New functions.
7430 (run_hook_with_args): Call each function through a `funcall' argument.
7431 Remove `cond' argument, now redundant.
7432 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7433 (Frun_hook_with_args_until_failure): Adjust accordingly.
7434 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7436 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7438 * dispextern.h (string_buffer_position): Remove declaration.
7440 * print.c (strout): Remove parameter `multibyte', unused since
7441 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7443 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7444 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7445 All callers changed.
7447 * w32.c (_wsa_errlist): Use braces for struct initializers.
7449 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7450 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7451 All callers changed.
7452 (string_buffer_position): Likewise. Also, make static (it's never
7453 used outside xdisp.c).
7454 (cursor_row_p): Remove parameter `w', unused since
7455 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7456 (decode_mode_spec): Remove parameter `precision', introduced during
7457 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7458 All callers changed.
7460 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7462 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7464 2011-03-27 Anders Lindgren <andlind@gmail.com>
7466 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7467 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7468 (ns_update_auto_hide_menu_bar): New functions.
7469 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7470 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7471 ns_constrain_all_frames.
7472 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7473 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7475 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7477 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7479 2011-03-27 Glenn Morris <rgm@gnu.org>
7481 * syssignal.h: Replace RETSIGTYPE with void.
7482 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7483 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7484 Replace SIGTYPE with void everywhere.
7485 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7486 * s/template.h (SIGTYPE): Remove commented out definition.
7488 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7490 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7491 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7493 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7495 * w32.c (read_unc_volume): Use parameter `henum', instead of
7496 global variable `wget_enum_handle'.
7498 * keymap.c (describe_vector): Remove parameters `indices' and
7499 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7500 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7502 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7504 * keyboard.c (timer_check): Remove parameter `do_it_now',
7505 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7506 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7507 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7509 * keyboard.c (read_char):
7510 * w32menu.c (w32_menu_display_help):
7511 * xmenu.c (show_help_event, menu_help_callback):
7512 Adjust calls to `show_help_echo'.
7514 * gtkutil.c (xg_maybe_add_timer):
7515 * keyboard.c (readable_events):
7516 * process.c (wait_reading_process_output):
7517 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7519 * insdel.c (adjust_markers_gap_motion):
7520 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7521 (gap_left, gap_right): Don't call it.
7523 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7525 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7526 incurred during fontification.
7528 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7530 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7531 (DEFVAR_PER_BUFFER): Don't pass it.
7533 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7534 (scrolling_window): Don't pass it.
7536 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7538 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7540 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7542 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7543 of variables specific to SELinux and computation of `encoded_absname'.
7545 * image.c (XPutPixel): Remove unused variable `height'.
7547 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7549 * unexw32.c (get_section_info): Remove unused variable `section'.
7551 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7552 (system_process_attributes): Remove unused variable `sess'.
7553 (sys_read): Remove unused variable `err'.
7555 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7556 (w32_wnd_proc): Remove unused variable `isdead'.
7557 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7558 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7559 (x_create_tip_frame): Remove unused variable `tem'.
7561 * w32inevt.c (w32_console_read_socket):
7562 Remove unused variable `no_events'.
7564 * w32term.c (x_draw_composite_glyph_string_foreground):
7565 Remove unused variable `width'.
7567 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7569 * w32term.c (x_set_glyph_string_clipping):
7570 Don't pass uninitialized region to CombineRgn.
7572 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7574 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7575 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7576 (Fx_close_connection): Remove unused variable `i'.
7578 * w32font.c (w32font_draw): Return number of glyphs.
7579 (w32font_open_internal): Remove unused variable `i'.
7580 (w32font_driver): Add missing initializer.
7582 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7583 (fill_in_menu): Remove unused variable `items_added'.
7585 * w32term.c (last_mouse_press_frame): Remove static global variable.
7586 (w32_clip_to_row): Remove unused variable `f'.
7587 (x_delete_terminal): Remove unused variable `i'.
7589 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7590 (NOTHING): Remove unused static global variable.
7591 (uniscribe_check_otf): Remove unused variable `table'.
7592 (uniscribe_font_driver): Add missing initializers.
7594 2011-03-23 Julien Danjou <julien@danjou.info>
7596 * term.c (Fsuspend_tty, Fresume_tty):
7597 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7598 * window.c (temp_output_buffer_show):
7599 * insdel.c (signal_before_change):
7600 * frame.c (Fhandle_switch_frame):
7601 * fileio.c (Fdo_auto_save):
7602 * emacs.c (Fkill_emacs):
7603 * editfns.c (save_excursion_restore):
7604 * cmds.c (internal_self_insert):
7605 * callint.c (Fcall_interactively):
7606 * buffer.c (Fkill_all_local_variables):
7607 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7609 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7610 unconditionnaly since it does the check itself.
7612 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7614 Fix more problems found by GCC 4.5.2's static checks.
7616 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7617 the first time through the loop, since we know p0 < p1 then.
7618 This also avoids a gcc -Wstrict-overflow warning.
7620 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7621 leading to a memory leak, possible in functions like
7622 load_charset_map_from_file that can allocate an unbounded number
7623 of objects (Bug#8318).
7625 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7626 that could (at least in theory) be that large.
7628 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7629 This is less likely to overflow, and avoids undefined behavior if
7630 overflow does occur. All callers changed. Use strtoul to scan
7631 for the unsigned long integer.
7632 (pint2hrstr): Simplify and tune code slightly.
7633 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7635 * scroll.c (do_scrolling): Work around GCC bug 48228.
7636 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7638 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7639 This also avoids a warning with gcc -Wstrict-overflow.
7640 (validate_x_resource_name): Simplify count usage.
7641 This also avoids a warning with gcc -Wstrict-overflow.
7643 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7646 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7648 * process.c (Fmake_network_process): Use socklen_t, not int,
7649 where POSIX says socklen_t is required in portable programs.
7650 This fixes a porting bug on hosts like 64-bit HP-UX, where
7651 socklen_t is wider than int (Bug#8277).
7652 (Fmake_network_process, server_accept_connection):
7653 (wait_reading_process_output, read_process_output):
7656 * process.c: Rename or move locals to avoid shadowing.
7657 (list_processes_1, Fmake_network_process):
7658 (read_process_output_error_handler, exec_sentinel_error_handler):
7659 Rename or move locals.
7660 (Fmake_network_process): Define label "retry_connect" only if needed.
7661 (Fnetwork_interface_info): Fix pointer signedness.
7662 (process_send_signal): Add cast to avoid pointer signedness problem.
7663 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7664 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7666 Make tparam.h and terminfo.c consistent.
7667 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7668 Include tparam.h instead, since it declares them.
7669 * cm.h (PC): Remove extern decl; tparam.h now does this.
7670 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7671 * terminfo.c: Include tparam.h, to check interfaces.
7672 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7673 (tparam): Adjust signature to match interface in tparam.h;
7674 this removes some undefined behavior. Check that outstring and len
7675 are zero, which they always are with Emacs.
7676 * tparam.h (PC, BC, UP): New extern decls.
7678 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7679 (xftfont_open): Rename locals to avoid shadowing.
7681 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7682 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7683 (OTF_TAG_SYM): Omit macro if not needed.
7684 (ftfont_list): Remove unused local.
7685 (get_adstyle_property, ftfont_pattern_entity):
7686 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7687 Rename locals to avoid shadowing.
7689 * xfont.c (xfont_list_family): Mark var as initialized.
7691 * xml.c (make_dom): Now static.
7693 * composite.c (composition_compute_stop_pos): Rename local to
7695 (composition_reseat_it): Remove unused locals.
7696 (find_automatic_composition, composition_adjust_point): Likewise.
7697 (composition_update_it): Mark var as initialized.
7698 (find_automatic_composition): Mark vars as initialized,
7699 with a FIXME (Bug#8290).
7701 character.h: Rename locals to avoid shadowing.
7702 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7703 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7704 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7705 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7708 * textprop.c (property_change_between_p): Remove; unused.
7710 * intervals.c (interval_start_pos): Now static.
7712 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7714 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7715 Rename locals to avoid shadowing.
7717 * sound.c (wav_play, au_play, Fplay_sound_internal):
7718 Fix pointer signedness.
7719 (alsa_choose_format): Remove unused local var.
7720 (wav_play): Initialize a variable to 0, to prevent undefined
7721 behavior (Bug#8278).
7723 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7725 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7727 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7728 clobbering (Bug#8298).
7729 * sysdep.c (sys_subshell): Likewise.
7730 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7732 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7733 This should get cleaned up, so that child_setup has the
7734 same signature on all platforms.
7736 * callproc.c (call_process_cleanup): Now static.
7737 (relocate_fd): Rename locals to avoid shadowing.
7739 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7741 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7742 not to be necessary, and produces flickering.
7744 2011-03-20 Glenn Morris <rgm@gnu.org>
7746 * config.in: Remove file.
7748 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7750 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7751 are now in src/globals.h.
7752 (syms_of_minibuf): Remove spurious & from previous change.
7754 2011-03-20 Leo <sdl.web@gmail.com>
7756 * minibuf.c (completing-read-function): New variable.
7757 (completing-read-default): Rename from completing-read.
7758 (completing-read): Call completing-read-function.
7760 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7762 * xfaces.c (Fx_load_color_file):
7763 Read color file from absolute filename (bug#8250).
7765 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7767 * makefile.w32-in: Update dependencies.
7769 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7771 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7773 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7775 Fix more problems found by GCC 4.5.2's static checks.
7777 * process.c (make_serial_process_unwind, send_process_trap):
7778 (sigchld_handler): Now static.
7780 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7781 That way, the code declares only the vars that it needs.
7782 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7783 * s/cygwin.h (PTY_ITERATION): Likewise.
7784 * s/darwin.h (PTY_ITERATION): Likewise.
7785 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7787 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7788 * process.c (allocate_pty): Don't declare stb unless it's needed.
7790 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7791 (CONSTANTLIM): Remove; unused.
7792 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7793 Define only if needed.
7795 * unexelf.c (unexec): Name an expression,
7796 to avoid gcc -Wbad-function-cast warning.
7797 Use a different way to cause a compilation error if anyone uses
7798 n rather than nn, a way that does not involve shadowing.
7799 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7801 * deps.mk (unexalpha.o): Remove; unused.
7803 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7804 * unexec.h: New file.
7805 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7806 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7808 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7809 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7810 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7811 Change as necessary to match prototype in unexec.h.
7813 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7815 (back_comment, skip_chars): Mark vars as initialized.
7817 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7818 Rename locals to avoid shadowing.
7820 * lread.c (read1): Rewrite so as not to use empty "else".
7821 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7823 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7825 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7826 warning when compiling print.c.
7828 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7829 instead of using an uninitialized var.
7830 (font_sort_entities): Mark var as initialized.
7832 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7834 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7835 pointers to constants.
7836 (font_parse_fcname): Remove unused vars.
7837 (font_delete_unmatched): Now static.
7838 (font_get_spec): Remove; unused.
7839 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7840 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7841 Rename or move locals to avoid shadowing.
7843 * fns.c (require_nesting_list, require_unwind): Now static.
7844 (Ffillarray): Rename locals to avoid shadowing.
7846 * floatfns.c (domain_error2): Define only if needed.
7847 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7849 * alloc.c (mark_backtrace): Move decl from here ...
7850 * lisp.h: ... to here, so that it can be checked.
7852 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7853 (Fdefvar): Rewrite so as not to use empty "else".
7854 (lisp_indirect_variable): Name an expression,
7855 to avoid gcc -Wbad-function-cast warning.
7856 (Fdefvar): Rename locals to avoid shadowing.
7858 * callint.c (quotify_arg, quotify_args): Now static.
7859 (Fcall_interactively): Rename locals to avoid shadowing.
7860 Use const pointer when appropriate.
7862 * lisp.h (get_system_name, get_operating_system_release):
7863 Move decls here, to check interfaces.
7864 * process.c (get_operating_system_release): Move decl to lisp.h.
7865 * xrdb.c (get_system_name): Likewise.
7866 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7867 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7868 some of which prompt warnings from gcc -Wbad-function-cast.
7869 (Fformat_time_string, Fencode_time, Finsert_char):
7870 (Ftranslate_region_internal, Fformat):
7871 Rename or remove local vars to avoid shadowing.
7872 (Ftranslate_region_internal): Mark var as initialized.
7874 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7877 * lisp.h (eassert): Check that the argument compiles, even if
7878 ENABLE_CHECKING is not defined.
7880 * data.c (Findirect_variable): Name an expression, to avoid
7881 gcc -Wbad-function-cast warning.
7882 (default_value, arithcompare, arith_driver, arith_error): Now static.
7883 (store_symval_forwarding): Rename local to avoid shadowing.
7884 (Fmake_variable_buffer_local, Fmake_local_variable):
7885 Mark variables as initialized.
7886 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7888 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7889 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7890 Rename locals to avoid shadowing.
7891 (mark_stack): Move local variables into the #ifdef region where
7893 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7894 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7896 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7897 (GC_STRING_CHARS): Remove; not used.
7898 (Fmemory_limit): Cast sbrk's returned value to char *.
7900 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7901 avoids undefined behavior in theory.
7903 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7905 Use functions, not macros, for up- and down-casing (Bug#8254).
7906 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7907 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7908 to use the following functions instead of these macros.
7909 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7910 EMACS_INT, since callers assume the returned value fits in int.
7911 (upcase1): Likewise, for UPCASE_TABLE.
7912 (uppercasep, lowercasep, upcase): New static inline functions.
7913 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7914 the race-condition problem in the old DOWNCASE.
7916 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7917 Rename locals to avoid shadowing.
7918 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7919 (regex_compile, re_search_2, re_match_2_internal):
7920 Remove unused local vars.
7921 (FREE_VAR): Rewrite so as not to use empty "else",
7922 which gcc can warn about.
7923 (regex_compile, re_match_2_internal): Mark locals as initialized.
7924 (RETALLOC_IF): Define only if needed.
7925 (WORDCHAR_P): Likewise. This one is never needed, but is used
7926 only in a comment talking about a compiler bug, so put inside
7927 the #if 0 of that comment.
7928 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7929 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7932 * search.c (boyer_moore): Rename locals to avoid shadowing.
7933 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7934 (PREV_CHAR_BOUNDARY): Likewise.
7936 * search.c (simple_search): Remove unused var.
7938 * dired.c (compile_pattern): Move decl from here ...
7939 * lisp.h: ... to here, so that it can be checked.
7940 (struct re_registers): New forward decl.
7942 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7944 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7946 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7947 Rename locals to avoid shadowing.
7948 (Fvertical_motion): Mark locals as initialized.
7950 * casefiddle.c (casify_object, casify_region): Now static.
7951 (casify_region): Mark local as initialized.
7953 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7955 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7956 New macros, so that the caller can use some names other than
7957 gcpro1, gcpro2, etc.
7958 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7960 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7961 argument, for consistency with GCPRO2_VAR, etc: it is now the
7962 prefix of the variable, not the variable itself. All uses
7964 * dired.c (directory_files_internal, file_name_completion):
7965 Rename locals to avoid shadowing.
7967 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7968 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7969 dired.c's scmp function, had undefined behavior.
7970 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7971 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7972 * buffer.h: ... to here, because these macros use current_buffer,
7973 and the new implementation with inline functions needs to have
7974 current_buffer in scope now, rather than later when the macros
7976 (downcase, upcase1): New static inline functions.
7977 (DOWNCASE, UPCASE1): Reimplement using these functions.
7978 This avoids undefined behavior in expressions like
7979 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7980 from race conditions in accessing the global variables
7981 case_temp1 and case_temp2.
7982 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7983 * lisp.h (case_temp1, case_temp2): Remove their decls.
7984 * character.h (ASCII_CHAR_P): Move from here ...
7985 * lisp.h: ... to here, so that the inline functions mentioned
7988 * dired.c (directory_files_internal_unwind): Now static.
7990 * fileio.c (file_name_as_directory, directory_file_name):
7991 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7993 (file_name_as_directory): Use const pointers when appropriate.
7994 (Fexpand_file_name): Likewise. In particular, newdir might
7995 point at constant storage, so make it a const pointer.
7996 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7997 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7999 (Fset_file_times, Finsert_file_contents, auto_save_error):
8000 Rename locals to avoid shadowing.
8002 * minibuf.c (choose_minibuf_frame_1): Now static.
8003 (Ftry_completion, Fall_completions): Rename or remove locals
8006 * marker.c (bytepos_to_charpos): Remove; unused.
8008 * lisp.h (verify_bytepos, count_markers): New decls,
8009 so that gcc does not warn that these functions aren't declared.
8011 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8012 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8013 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8014 (copy_text): Remove unused local var.
8016 * filelock.c (within_one_second): Now static.
8017 (lock_file_1): Rename local to avoid shadowing.
8019 * buffer.c (fix_overlays_before): Mark locals as initialized.
8020 (fix_start_end_in_overlays): Likewise. This function should be
8021 simplified by using pointers-to-pointers, but that's a different
8023 (switch_to_buffer_1): Now static.
8024 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8025 (report_overlay_modification): Rename locals to avoid shadowing.
8027 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8028 Fix pointer signedness issue.
8029 (sys_subshell): Mark local as volatile if checking for lint,
8030 to suppress a gcc -Wclobbered warning that does not seem to be right.
8031 (MAXPATHLEN): Define only if needed.
8033 * process.c (serial_open, serial_configure): Move decls from here ...
8034 * systty.h: ... to here, so that they can be checked.
8036 * fns.c (get_random, seed_random): Move extern decls from here ...
8037 * lisp.h: ... to here, so that they can be checked.
8039 * sysdep.c (reset_io): Now static.
8040 (wait_for_termination_signal): Remove; unused.
8042 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8043 (copy_keymap_item, append_key, push_text_char_description):
8045 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8046 (DENSE_TABLE_SIZE): Remove; unused.
8047 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8048 (describe_map_tree):
8049 Rename locals to avoid shadowing.
8051 * keyboard.c: Declare functions static if they are not used elsewhere.
8052 (echo_char, echo_dash, cmd_error, top_level_2):
8053 (poll_for_input, handle_async_input): Now static.
8054 (read_char, kbd_buffer_get_event, make_lispy_position):
8055 (make_lispy_event, make_lispy_movement, apply_modifiers):
8056 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8057 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8058 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8059 (read_key_sequence, read_char): Mark locals as initialized.
8060 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8062 * keyboard.h (make_ctrl_char): New decl.
8063 (mark_kboards): Move decl here ...
8064 * alloc.c (mark_kboards): ... from here.
8066 * lisp.h (force_auto_save_soon): New decl.
8068 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8069 (DEFINE_DUMMY_FUNCTION): New macro.
8070 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8072 (main): Add casts to avoid warnings
8073 if GCC considers string literals to be constants.
8075 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8077 * dbusbind.c: Pointer signedness fixes.
8078 (xd_signature, xd_append_arg, xd_initialize):
8079 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8080 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8081 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8082 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8084 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8085 if GCC considers string literals to be constants.
8086 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8088 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8090 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8091 (print_preprocess, print_object): New macro to fix last change.
8093 * print.c (print_preprocess): Don't forget font objects.
8095 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8097 * emacs.c (USAGE3): Doc fixes.
8099 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8101 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8104 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8106 * lisp.h (VWindow_system, Qfile_name_history):
8107 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8108 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8109 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8111 * w32select.c: Don't #include "keyboard.h".
8112 (run_protected): Add extern declaration for waiting_for_input.
8114 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8115 * w32console.c (detect_input_pending, read_input_pending)
8116 (encode_terminal_code):
8117 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8118 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8119 (w32_system_caret_y, Qfile_name_history):
8120 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8121 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8122 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8123 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8124 * w32proc.c (Qlocal, report_file_error):
8125 * w32term.c (Vwindow_system, updating_frame):
8126 * w32uniscribe.c (initialized, uniscribe_font_driver):
8127 Remove unneeded extern declarations.
8129 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8131 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8133 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8135 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8136 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8137 These macros can no longer be used for assignment.
8139 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8140 Assign struct members directly, instead of using BUF_BEGV etc.
8141 (record_buffer_markers, fetch_buffer_markers): New functions for
8142 recording and fetching special buffer markers.
8143 (set_buffer_internal_1, set_buffer_temp): Use them.
8145 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8147 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8149 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8150 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8152 * xdisp.c (hscroll_window_tree):
8153 (reconsider_clip_changes): Use PT instead of BUF_PT.
8155 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8157 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8158 $(EMACS_ROOT)/lib/intprops.h.
8160 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8162 Fix more problems found by GCC 4.5.2's static checks.
8164 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8165 to unsigned char * to avoid compiler diagnostic.
8166 (xg_free_frame_widgets): Make it clear that a local variable is
8167 needed only if USE_GTK_TOOLTIP.
8168 (gdk_window_get_screen): Make it clear that this macro is needed
8169 only if USE_GTK_TOOLTIP.
8170 (int_gtk_range_get_value): New function, which avoids a diagnostic
8171 from gcc -Wbad-function-cast.
8172 (xg_set_toolkit_scroll_bar_thumb): Use it.
8173 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8174 diagnostic from gcc -Wbad-function-cast.
8175 (get_utf8_string, xg_get_file_with_chooser):
8176 Rename locals to avoid shadowing.
8177 (create_dialog): Move locals to avoid shadowing.
8179 * xgselect.c (xg_select): Remove unused var.
8181 * image.c (four_corners_best): Mark locals as initialized.
8182 (gif_load): Initialize transparent_p to zero (Bug#8238).
8183 Mark another local as initialized.
8184 (my_png_error, my_error_exit): Mark with NO_RETURN.
8186 * image.c (clear_image_cache): Now static.
8187 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8188 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8189 (x_edge_detection): Remove unnecessary cast that
8190 gcc -Wbad-function-cast diagnoses.
8191 (gif_load): Fix pointer signedness.
8192 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8193 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8195 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8197 Improve quality of tests for time stamp overflow.
8198 For example, without this patch (encode-time 0 0 0 1 1
8199 1152921504606846976) returns the obviously-bogus value (-948597
8200 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8201 reports time overflow. See
8202 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8203 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8204 * editfns.c: Include limits.h and intprops.h.
8205 (TIME_T_MIN, TIME_T_MAX): New macros.
8206 (time_overflow): Move earlier, to before first use.
8207 (hi_time, lo_time): New functions, for an accurate test for
8209 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8210 (Fget_internal_run_time): Don't assume time_t fits in int.
8211 (make_time): Use list2 instead of Fcons twice.
8212 (Fdecode_time): More accurate test for out-of-range times.
8213 (check_tm_member): New function.
8214 (Fencode_time): Use it, to test for out-of-range times.
8215 (lisp_time_argument): Don't rely on undefined left-shift and
8216 right-shift behavior when checking for time stamp overflow.
8218 * editfns.c (time_overflow): New function, refactoring common code.
8219 (Fformat_time_string, Fdecode_time, Fencode_time):
8220 (Fcurrent_time_string): Use it.
8222 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8223 * dired.c (make_time): Move to ...
8224 * editfns.c (make_time): ... here.
8225 * systime.h: Note the move.
8227 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8229 * fringe.c (update_window_fringes): Remove unused variables.
8231 * unexmacosx.c (copy_data_segment): Also copy __got section.
8234 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8236 * termcap.c [MSDOS]: Include "msdos.h".
8237 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8238 Constify `char *' arguments and their references according to
8239 prototypes in tparam.h.
8241 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8243 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8244 Adapt all references accordingly.
8246 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8248 2011-03-11 Tom Tromey <tromey@redhat.com>
8250 * buffer.c (syms_of_buffer): Remove obsolete comment.
8252 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8254 * termhooks.h (encode_terminal_code): Declare prototype.
8256 * msdos.c (encode_terminal_code): Don't declare prototype.
8258 * term.c (encode_terminal_code): Now external again, used by
8259 w32console.c and msdos.c.
8261 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8262 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8264 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8266 Fix some minor problems found by GCC 4.5.2's static checks.
8268 * fringe.c (update_window_fringes): Mark locals as initialized
8270 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8272 * alloc.c (mark_fringe_data): Move decl from here ...
8273 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8274 to check its interface.
8275 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8277 * fontset.c (free_realized_fontset): Now static.
8278 (Fset_fontset_font): Rename local to avoid shadowing.
8279 (fontset_font): Mark local as initialized.
8280 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8282 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8284 * xselect.c (x_disown_buffer_selections): Remove; not used.
8285 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8286 (x_own_selection, Fx_disown_selection_internal): Rename locals
8288 (x_handle_dnd_message): Remove local to avoid shadowing.
8290 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8291 so that the caller can use some name other than gcpro1.
8292 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8293 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8294 (Fx_backspace_delete_keys_p):
8295 Use them to avoid shadowing, and rename vars to avoid shadowing.
8296 (x_decode_color, x_set_name, x_window): Now static.
8297 (Fx_create_frame): Add braces to silence GCC warning.
8298 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8299 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8300 Remove unused locals.
8301 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8302 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8303 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8306 * xterm.h (x_mouse_leave): New decl.
8308 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8309 Remove unused functions.
8310 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8311 (x_calc_absolute_position): Now static.
8312 (XTread_socket): Don't define label "out" unless it's used.
8313 Don't declare local "event" unless it's used.
8314 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8315 unless they are used.
8316 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8317 (x_fatal_error_signal): Remove; not used.
8318 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8319 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8320 (x_error_catcher, x_connection_closed, x_error_handler):
8321 (x_error_quitter, xembed_send_message, x_iconify_frame):
8322 (my_log_handler): Rename locals to avoid shadowing.
8323 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8324 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8326 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8327 Rename or move locals to avoid shadowing.
8328 (tty_defined_color, merge_face_heights): Now static.
8329 (free_realized_faces_for_fontset): Remove; not used.
8330 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8331 does not deduce is never used uninitialized.
8332 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8333 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8335 * terminal.c (store_terminal_param): Now static.
8337 * xmenu.c (menu_highlight_callback): Now static.
8338 (set_frame_menubar): Remove unused local.
8339 (xmenu_show): Rename parameter to avoid shadowing.
8340 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8341 since they might point to immutable storage.
8342 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8343 since it's unused otherwise.
8345 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8346 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8347 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8348 avoids a gcc -Wuninitialized diagnostic.
8349 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8350 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8351 does not deduce are never used uninitialized.
8353 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8355 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8356 * window.c (window_loop, size_window):
8357 (run_window_configuration_change_hook, enlarge_window): Likewise.
8359 * window.c (display_buffer): Now static.
8360 (size_window): Mark variables that gcc -Wuninitialized
8361 does not deduce are never used uninitialized.
8362 * window.h (check_all_windows): New decl, to forestall
8363 gcc -Wmissing-prototypes diagnostic.
8364 * dispextern.h (bidi_dump_cached_states): Likewise.
8366 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8368 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8370 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8371 and to avoid gcc -Wuninitialized warning.
8372 (load_charset_map): Mark variables that gcc -Wuninitialized
8373 does not deduce are never used uninitialized.
8374 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8376 * coding.c (coding_set_source, coding_set_destination):
8377 Use "else { /* comment */ }" rather than "else /* comment */;"
8378 for clarity, and to avoid gcc -Wempty-body warning.
8379 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8380 a block, when the outer 'i' will do.
8381 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8382 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8383 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8384 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8385 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8386 Rename locals to avoid shadowing.
8387 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8388 * coding.c (emacs_mule_char, encode_invocation_designation):
8389 Now static, since they're not used elsewhere.
8390 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8391 (decode_coding_object, encode_coding_object, detect_coding_system):
8392 (decode_coding_emacs_mule): Mark variables that gcc
8393 -Wuninitialized does not deduce are never used uninitialized.
8394 (detect_coding_iso_2022): Initialize a local variable that might
8395 be used uninitialized. Leave a FIXME because it's not clear that
8396 this initialization is needed. (Bug#8211)
8397 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8398 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8399 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8400 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8401 Remove unused macros.
8403 * category.c (hash_get_category_set): Remove unused local var.
8404 (copy_category_table): Now static, since it's not used elsewhere.
8405 * character.c (string_count_byte8): Likewise.
8407 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8408 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8410 * chartab.c (copy_sub_char_table): Now static, since it's not used
8412 (sub_char_table_ref_and_range, char_table_ref_and_range):
8413 Rename locals to avoid shadowing.
8414 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8416 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8417 (BIDI_BOB): Remove unused macro.
8419 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8420 deduce are never used uninitialized.
8421 * term.c (encode_terminal_code): Likewise.
8423 * term.c (encode_terminal_code): Now static. Remove unused local.
8425 * tparam.h: New file.
8426 * term.c, tparam.h: Include it.
8427 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8428 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8429 Move these decls to tparam.h, and make them agree with what
8430 is actually in tparam.c. The previous trick of using incompatible
8431 decls in different modules does not conform to the C standard.
8432 All callers of tparam changed to use tparam's actual API.
8433 * tparam.c (tparam1, tparam, tgoto):
8434 Use const pointers where appropriate.
8436 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8437 * cm.h (struct cm): Likewise.
8438 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8439 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8440 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8441 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8442 (turn_on_face, init_tty): Likewise.
8443 * termchar.h (struct tty_display_info): Likewise.
8445 * term.c (term_mouse_position): Rename local to avoid shadowing.
8447 * alloc.c (mark_ttys): Move decl from here ...
8448 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8450 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8452 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8454 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8456 * search.c (compile_pattern_1): Remove argument regp, unused since
8457 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8458 (compile_pattern): Don't pass it.
8460 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8462 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8463 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8465 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8467 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8469 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8470 gdk_window_get_screen, gdk_window_get_geometry,
8471 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8472 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8473 (xg_get_pixbuf_from_pixmap): New function.
8474 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8475 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8476 Call xg_get_pixbuf_from_pixmap instead of
8477 gdk_pixbuf_get_from_drawable.
8478 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8479 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8480 (xg_check_special_colors): Use GtkStyleContext and its functions
8482 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8483 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8484 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8485 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8486 Call gtk_widget_get_preferred_size.
8487 (xg_frame_resized): gdk_window_get_geometry only takes 5
8489 (xg_win_to_widget, xg_event_is_for_menubar):
8490 Call gdk_x11_window_lookup_for_display.
8491 (xg_set_widget_bg): New function.
8492 (delete_cb): New function.
8493 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8494 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8495 (xg_set_background_color): Call xg_set_widget_bg.
8496 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8497 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8498 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8499 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8501 (update_frame_tool_bar): Call gtk_widget_hide.
8502 (xg_initialize): Use GDK_KEY_g.
8504 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8506 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8508 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8509 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8510 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8512 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8514 * w32xfns.c (select_palette): Check success of RealizePalette against
8515 GDI_ERROR, not zero.
8517 See ChangeLog.11 for earlier changes.
8523 Copyright (C) 2011 Free Software Foundation, Inc.
8525 This file is part of GNU Emacs.
8527 GNU Emacs is free software: you can redistribute it and/or modify
8528 it under the terms of the GNU General Public License as published by
8529 the Free Software Foundation, either version 3 of the License, or
8530 (at your option) any later version.
8532 GNU Emacs is distributed in the hope that it will be useful,
8533 but WITHOUT ANY WARRANTY; without even the implied warranty of
8534 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8535 GNU General Public License for more details.
8537 You should have received a copy of the GNU General Public License
8538 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.