1 2012-04-09 Glenn Morris <rgm@gnu.org>
3 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4 not just in the obarray, before snarfing them. (Bug#11036)
6 * Makefile.in ($(leimdir)/leim-list.el):
7 Pass EMACS rather than BUILT_EMACS.
9 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
11 * process.c (make_process):
12 * process.h: Add integer `gnutls_handshakes_tried' member to
15 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit. Add
16 convenience `GNUTLS_LOG2i' macro.
18 * gnutls.c (gnutls_log_function2i): Convenience log function.
19 (emacs_gnutls_read): Use new log functions,
20 `gnutls_handshakes_tried' process member, and
21 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
22 attempts per process (connection).
24 2012-04-09 Chong Yidong <cyd@gnu.org>
26 * eval.c (Fuser_variable_p, user_variable_p_eh)
27 (lisp_indirect_variable): Functions deleted.
28 (Fdefvar): Caller changed.
30 * callint.c (Finteractive, Fcall_interactively):
31 * minibuf.c (Fread_variable): Callers changed.
33 2012-04-09 Eli Zaretskii <eliz@gnu.org>
35 * xdisp.c (set_cursor_from_row): If the display string appears in
36 the buffer at position that is closer to point than the position
37 after the display string, display the cursor on the first glyph of
38 the display string. Fixes cursor display when a 'display' text
39 property immediately follows invisible text. (Bug#11094)
41 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
43 composite.c: use 'double' consistently
44 * composite.c (get_composition_id): Use 'double' consistently
45 instead of converting 'float' to 'double' and vice versa; this is
46 easier to understand and avoids a GCC warning.
48 2012-04-09 Glenn Morris <rgm@gnu.org>
50 * Makefile.in: Generate leim-list with bootstrap-emacs, in
51 preparation for dumping it with emacs. (Bug#4789)
52 (leimdir): New variable.
53 ($(leimdir)/leim-list.el): New rule.
54 (emacs$(EXEEXT)): Depend on leim-list.el.
56 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
57 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
58 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
60 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
62 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
65 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
67 * xml.c (init_libxml2_functions) [WINDOWSNT]:
68 Remove unused local variable.
70 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
72 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
73 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
74 (mark_memory): Mark Lisp_Objects only if pointers might hide in
75 objects, as mark_maybe_pointer will catch them otherwise.
76 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
77 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
79 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
81 Fix typo that broke non-Windows builds.
82 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
84 2012-04-07 Eli Zaretskii <eliz@gnu.org>
86 Support building on MS-Windows with libxml2.
88 * makefile.w32-in (OBJ2): Add xml.$(O).
89 (GLOBAL_SOURCES): Add xml.c.
90 ($(BLD)/xml.$(O)): New dependency list.
92 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
93 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
94 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
95 [!WINDOWSNT]: New macros.
96 (init_libxml2_functions, libxml2_loaded_p): New functions.
97 (parse_region): Call fn_xmlCheckVersion instead of using the macro
98 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
99 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
100 Calls xmlCleanupParser only if libxml2 was loaded (or statically
102 (Flibxml_parse_html_region, Flibxml_parse_xml_region): Call
103 init_libxml2_functions before calling libxml2 functions.
104 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
106 * emacs.c: Don't include libxml/parser.h.
107 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
108 xmlCleanupParser directly.
110 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
112 2012-04-07 Eli Zaretskii <eliz@gnu.org>
114 * indent.c (Fvertical_motion): If there is a display string at
115 point, use it.vpos to compute how many lines to backtrack after
116 move_it_to point. (Bug#11133)
118 2012-04-06 Eli Zaretskii <eliz@gnu.org>
120 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
121 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
122 about subtle differences between FETCH_CHAR* and STRING_CHAR*
123 macros related to unification of CJK characters. For the details,
124 see the discussion following the message here:
125 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
127 2012-04-04 Chong Yidong <cyd@gnu.org>
129 * keyboard.c (Vdelayed_warnings_list): Doc fix.
131 2012-04-01 Eli Zaretskii <eliz@gnu.org>
133 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
134 instead of alloca. (Bug#11138)
136 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
138 * w32menu.c (is_simple_dialog): Properly check lisp types.
141 2012-03-31 Eli Zaretskii <eliz@gnu.org>
143 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
144 position we get to after a call to move_it_to fails the
145 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
146 only if we wind up in a string from display property. (Bug#11063)
148 * window.c (Fdelete_other_windows_internal): Invalidate the row
149 and column information about mouse highlight, so that redisplay
150 restores it after reallocating the glyph matrices. (Bug#7464)
152 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
153 string comes from a `display' text property, use the buffer
154 position of that property as if we actually saw that position in
156 (move_it_by_lines): Remove the assertion that
157 "it->current_x == 0 && it->hpos == 0" which can be legitimately
158 violated when there's a before-string at the beginning of a line.
161 2012-03-30 Eli Zaretskii <eliz@gnu.org>
163 * xdisp.c (append_space_for_newline): If the default face was
164 remapped, use the remapped face for the appended newline.
165 (extend_face_to_end_of_line): Use the remapped default face for
166 extending the face to the end of the line.
167 (display_line): Call extend_face_to_end_of_line when the default
168 face was remapped. (Bug#11068)
170 2012-03-29 Eli Zaretskii <eliz@gnu.org>
172 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
174 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
176 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
178 2012-03-27 Glenn Morris <rgm@gnu.org>
180 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
183 2012-03-26 Kenichi Handa <handa@m17n.org>
185 * dispextern.h (struct glyph): Fix previous change. Change the
186 bit length of glyphless.ch to 25 (Bug#11082).
188 2012-03-26 Chong Yidong <cyd@gnu.org>
190 * keyboard.c (Vselection_inhibit_update_commands): New variable.
191 (command_loop_1): Use it; inhibit selection update for
192 handle-select-window too (Bug#8996).
194 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
196 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
198 2012-03-25 Kenichi Handa <handa@m17n.org>
200 * dispextern.h (struct glyph): Change the bit length of
201 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
203 2012-03-24 Eli Zaretskii <eliz@gnu.org>
205 * s/ms-w32.h (tzname): Include time.h before redirecting to
206 _tzname. Fixes the MSVC build. (Bug#9960)
208 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
210 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
213 * xterm.c (XTread_socket): Only modify handling_signal if
214 !SYNC_INPUT. (Bug#11080)
216 2012-03-23 Eli Zaretskii <eliz@gnu.org>
218 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
219 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
220 when fetching a multibyte character consumes more bytes than
221 CHAR_BYTES returns, due to unification of CJK characters in
222 string_char. (Bug#11073)
224 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
226 * process.c (wait_reading_process_output): Handle pty disconnect
227 by refraining from sending oneself a SIGCHLD (bug#10933).
229 2012-03-22 Chong Yidong <cyd@gnu.org>
231 * dispextern.h (struct it): New member string_from_prefix_prop_p.
233 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
234 Mark string as coming from a prefix property.
235 (handle_face_prop): Use default face for prefix strings (Bug#4281).
236 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
238 2012-03-21 Chong Yidong <cyd@gnu.org>
240 * xfaces.c (Vface_remapping_alist): Doc fix.
242 2012-03-20 Eli Zaretskii <eliz@gnu.org>
244 * w32proc.c (Fw32_set_console_codepage)
245 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
248 2012-03-20 Chong Yidong <cyd@gnu.org>
250 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
251 to reflect default non-nil value of redisplay-dont-pause.
253 2012-03-19 Kenichi Handa <handa@m17n.org>
255 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
256 it fit in a valid range (Bug#11003).
258 2012-03-18 Eli Zaretskii <eliz@gnu.org>
260 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
261 that is not from display property, accept the row as a "cursor
262 row" if one of the string's character has a non-nil `cursor'
263 property. Fixes cursor positioning when there are newlines in
264 overlay strings, e.g. in icomplete.el. (Bug#11035)
266 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
268 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
270 2012-03-12 Chong Yidong <cyd@gnu.org>
272 * eval.c (inhibit_lisp_code): Rename from
273 inhibit_window_configuration_change_hook; move from window.c.
275 * xfns.c (unwind_create_frame_1, Fx_create_frame):
276 * window.c (run_window_configuration_change_hook)
277 (syms_of_window): Callers changed.
279 2012-03-11 Chong Yidong <cyd@gnu.org>
281 * keymap.c (Fkey_description): Doc fix (Bug#9700).
283 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
285 2012-03-10 Chong Yidong <cyd@gnu.org>
287 * frame.c (other_visible_frames): Don't assume the selected frame
288 is visible (Bug#10955).
290 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
292 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
294 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
296 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
297 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
300 2012-03-03 Glenn Morris <rgm@gnu.org>
302 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
304 2012-03-02 Eli Zaretskii <eliz@gnu.org>
306 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
307 position past the first glyph_row that ends at ZV. (Bug#10902)
308 (redisplay_window, next_element_from_string): Fix typos in
310 (redisplay_window): Pass to move_it_vertically the margin in
311 pixels, not in screen lines.
313 2012-03-02 Glenn Morris <rgm@gnu.org>
315 * buffer.c (buffer-list-update-hook): Doc fix.
317 2012-02-29 Eli Zaretskii <eliz@gnu.org>
319 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
320 push_it before setting up the iterator for the first overlay
321 string, even if we have an empty string loaded.
322 (next_overlay_string): If there's an empty string on the iterator
323 stack, pop the stack. (Bug#10903)
325 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
327 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
328 Suggested by Stefan Monnier in
329 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
330 * alloc.c (widen_to_Lisp_Object): New static function.
331 (mark_memory): Also mark Lisp_Objects by fetching pointer words
332 and widening them to Lisp_Objects. This would work even if
333 USE_LSB_TAG is defined and wide integers are used, which might
334 happen in a future version of Emacs.
336 2012-02-25 Chong Yidong <cyd@gnu.org>
338 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
341 * xselect.c (Fx_selection_exists_p): Doc fix.
342 (x_clipboard_manager_save_all): Print an informative message
343 before saving to clipboard manager.
345 2012-02-24 Chong Yidong <cyd@gnu.org>
347 * keyboard.c (process_special_events): Handle all X selection
348 requests in kbd_buffer, not just the next one (Bug#8869).
350 2012-02-23 Chong Yidong <cyd@gnu.org>
352 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
353 call when setting menu-bar-lines and tool-bar-lines parameters.
354 (unwind_create_frame_1): New helper function.
356 * window.c (inhibit_window_configuration_change_hook): New var.
357 (run_window_configuration_change_hook): Obey it.
358 (syms_of_window): Initialize it.
360 2012-02-22 Chong Yidong <cyd@gnu.org>
362 * xterm.c (x_draw_image_relief): Add missing type check for
363 Vtool_bar_button_margin (Bug#10743).
365 2012-02-21 Chong Yidong <cyd@gnu.org>
367 * fileio.c (Vfile_name_handler_alist): Doc fix.
369 * buffer.c (Fget_file_buffer): Protect against invalid file
370 handler return value.
372 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
374 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
375 when computing $valmask.
377 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
378 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
379 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
380 It's useless in that case, and it can cause problems on hosts
381 that allocate halves of EMACS_INT values separately.
382 Reported by Dan Horák. Diagnosed by Andreas Schwab in
383 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
384 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
385 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
386 it avoids undefined behavior on hosts where shifting right by more
387 than the word width has undefined behavior.
389 2012-02-19 Chong Yidong <cyd@gnu.org>
391 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
392 (Funhandled_file_name_directory, Ffile_name_as_directory)
393 (Fdirectory_file_name, Fexpand_file_name)
394 (Fsubstitute_in_file_name): Protect against invalid file handler
395 return values (Bug#10845).
397 2012-02-18 Eli Zaretskii <eliz@gnu.org>
399 * .gdbinit (pitx): Fix incorrect references to fields of the
402 2012-02-17 Chong Yidong <cyd@gnu.org>
404 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
406 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
408 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
409 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
411 2012-02-15 Chong Yidong <cyd@gnu.org>
413 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
414 marked as special. Also, starting docstrings with * is obsolete.
416 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
418 * gnutls.c (emacs_gnutls_write): Fix last change.
420 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
422 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
425 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
427 * keymap.c (Fsingle_key_description): Handle char ranges.
429 2012-02-12 Chong Yidong <cyd@gnu.org>
431 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
432 as that creates a dangerous corner case.
434 * window.c (Fdelete_window_internal): Invalidate the mouse
435 highlight (Bug#9904).
437 2012-02-12 Glenn Morris <rgm@gnu.org>
439 * xselect.c (Fx_own_selection_internal)
440 (Fx_get_selection_internal, Fx_disown_selection_internal)
441 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
442 * nsselect.m (Fx_own_selection_internal)
443 (Fx_disown_selection_internal, Fx_selection_exists_p)
444 (Fx_selection_owner_p, Fx_get_selection_internal):
445 Sync docs and argument specs with the xselect.c versions.
447 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
449 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
451 2012-02-11 Eli Zaretskii <eliz@gnu.org>
453 * w32select.c (Fx_selection_exists_p): Sync doc string and
454 argument list with xselect.c. (Bug#10783)
456 * w16select.c (Fx_selection_exists_p): Sync doc string and
457 argument list with xselect.c. (Bug#10783)
459 2012-02-10 Glenn Morris <rgm@gnu.org>
461 * fns.c (Fsecure_hash): Doc fix.
463 2012-02-09 Kenichi Handa <handa@m17n.org>
465 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
467 2012-02-07 Chong Yidong <cyd@gnu.org>
469 * buffer.c (Fbuffer_local_variables)
470 (buffer_lisp_local_variables): Handle unbound vars correctly;
471 don't let Qunbound leak into Lisp.
473 2012-02-07 Glenn Morris <rgm@gnu.org>
475 * image.c (Fimagemagick_types): Doc fix.
477 * image.c (imagemagick-render-type): Change it from a lisp object
478 to an integer. Move the doc here from the lisp manual.
479 Treat all values not equal to 0 the same.
481 2012-02-06 Chong Yidong <cyd@gnu.org>
483 * doc.c (store_function_docstring): Avoid applying docstring of
484 alias to base function (Bug#2603).
486 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
488 * .gdbinit (pp1, pv1): Remove redundant defines.
491 2012-02-04 Chong Yidong <cyd@gnu.org>
493 * nsterm.m: Declare a global (Bug#10694).
495 2012-02-04 Eli Zaretskii <eliz@gnu.org>
497 * w32.c (get_emacs_configuration_options):
498 Include --enable-checking, if specified, in the return value.
500 2012-02-04 Martin Rudalics <rudalics@gmx.at>
502 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
503 after rounding frame sizes. (Bug#9723)
505 2012-02-04 Eli Zaretskii <eliz@gnu.org>
507 * keyboard.c (adjust_point_for_property): Don't position point
508 before BEGV. (Bug#10696)
510 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
512 Handle overflow when computing char display width (Bug#9496).
513 * character.c (char_width): Return EMACS_INT, not int.
514 (char_width, c_string_width): Check for overflow when
515 computing the width; this is possible now that individual
516 characters can have unbounded width. Problem introduced
517 by merge from Emacs 23 on 2012-01-19.
519 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
521 * dbusbind.c (Fdbus_register_method): Mention the return value
522 :ignore in the docstring.
524 2012-02-02 Glenn Morris <rgm@gnu.org>
526 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
528 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
529 Unconditionally set to t. (Bug#10673)
530 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
531 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
532 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
534 2012-02-02 Kenichi Handa <handa@m17n.org>
536 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
537 0, do not call append_composite_glyph.
539 2012-02-02 Kenichi Handa <handa@m17n.org>
541 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
543 (x_produce_glyphs): If the component of a composition is a null
544 string, set it->pixel_width to 1 to avoid zero-width glyph.
546 2012-02-01 Eli Zaretskii <eliz@gnu.org>
548 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
549 first 2 arguments are identical. This makes inserting large
550 output from a subprocess an order of magnitude faster on
551 MS-Windows, where all sbrk'ed memory is always contiguous.
553 2012-01-31 Glenn Morris <rgm@gnu.org>
555 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
556 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
557 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
559 2012-01-29 Glenn Morris <rgm@gnu.org>
561 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
563 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
565 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
567 2012-01-28 Chong Yidong <cyd@gnu.org>
569 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
571 2012-01-26 Chong Yidong <cyd@gnu.org>
573 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
575 * search.c (Fsearch_forward, Fsearch_backward): Document negative
576 repeat counts (Bug#10507).
578 2012-01-26 Glenn Morris <rgm@gnu.org>
580 * lread.c (syms_of_lread): Doc fix.
582 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
584 * coding.c (encode_designation_at_bol): Change return value to
587 2012-01-25 Chong Yidong <cyd@gnu.org>
589 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
591 2012-01-21 Chong Yidong <cyd@gnu.org>
593 * floatfns.c (Fcopysign): Make the second argument non-optional,
594 since nil is not allowed anyway.
596 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
598 * process.c (read_process_output): Use p instead of XPROCESS (proc).
599 (send_process): Likewise.
601 2012-01-19 Martin Rudalics <rudalics@gmx.at>
603 * window.c (save_window_save, Fcurrent_window_configuration)
604 (Vwindow_persistent_parameters): Do not use Qstate.
607 2012-01-19 Kenichi Handa <handa@m17n.org>
609 * character.c (char_width): New function.
610 (Fchar_width, c_string_width, lisp_string_width):
611 Use char_width (Bug#9496).
613 2012-01-16 Martin Rudalics <rudalics@gmx.at>
615 * window.c (Vwindow_persistent_parameters): New variable.
616 (Fset_window_configuration, save_window_save): Handle persistent
619 2012-01-14 Eli Zaretskii <eliz@gnu.org>
621 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
622 thrashing the stack of the thread. (Bug#9087)
624 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
626 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
628 2012-01-11 Eli Zaretskii <eliz@gnu.org>
630 * xdisp.c (rows_from_pos_range): Handle the case where the
631 highlight ends on a newline. (Bug#10464)
632 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
633 he end column for display of highlight that ends on a newline
636 2012-01-11 Glenn Morris <rgm@gnu.org>
638 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
639 from load-path also when installation-directory is nil. (Bug#10208)
641 2012-01-10 Glenn Morris <rgm@gnu.org>
643 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
645 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
646 Update template values to be closer to their typical values these days.
648 2012-01-09 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (rows_from_pos_range): Accept additional argument
651 DISP_STRING, and accept any glyph in a row whose object is that
652 string as eligible for mouse highlight. Fixes mouse highlight of
653 display strings from overlays. (Bug#10464)
655 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
657 emacs: fix an auto-save permissions race condition (Bug#10400)
658 * fileio.c (auto_saving_dir_umask): New static var.
659 (Fmake_directory_internal): Use it.
660 (do_auto_save_make_dir): Set it, instead of invoking chmod after
661 creating the directory. The old code temporarily assigns
662 too-generous permissions to the directory.
663 (do_auto_save_eh): Clear it.
664 (Fdo_auto_save): Catch all errors, not just file errors, so
665 that the var is always cleared.
667 2012-01-07 Eli Zaretskii <eliz@gnu.org>
669 * search.c (scan_buffer): Pass character positions to
670 know_region_cache, not byte positions. (Bug#6540)
672 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
674 * w32.c (sys_rename): Report EXDEV when rename of a directory
675 fails because the target is on another logical disk. (Bug#10284)
677 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
679 * xterm.c (x_embed_request_focus): New function.
681 * xterm.h: Add prototype.
683 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
685 2012-01-05 Glenn Morris <rgm@gnu.org>
687 * emacs.c (emacs_copyright): Update short copyright year to 2012.
689 2012-01-01 Eli Zaretskii <eliz@gnu.org>
691 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
692 Load gnutls_transport_set_lowat only if GnuTLS version is below
694 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
695 GnuTLS versions below 2.11.1.
697 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
699 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
700 to the doc string advising against its use for altering the way
701 windows are scrolled.
703 2011-12-28 Kenichi Handa <handa@m17n.org>
705 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
706 coding-system ASCII compatible only when it does not produce BOM
707 on encoding (Bug#10383).
709 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
711 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
713 (create_and_show_popup_menu): Always use menu_position_func for
716 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
718 * callint.c (Fcall_interactively): Don't truncate prompt string.
720 2011-12-23 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
723 property that ends at ZV, so that the bidi iteration could be
724 resumed from there (after widening). (Bug#10360)
726 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
728 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
730 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
732 * nsterm.m (x_free_frame_resources):
733 Release f->output_data.ns->miniimage.
734 (ns_index_color): Fix indentation. Do not retain
735 color_table->colors[i].
737 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
740 * nsfns.m (x_set_background_color): Assign return value from
741 ns_index_color to face-background instead of NSColor*.
742 (ns_implicitly_set_icon_type): Fix indentation.
743 Change assignment in for loop to comparison.
745 * emacs.c (ns_pool): New variable.
746 (main): Assign ns_pool.
747 (Fkill_emacs): Call ns_release_autorelease_pool.
749 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
750 autorelease fdesc, release fdAttrs and tdict.
751 (ns_get_covering_families): Release charset.
752 (ns_findfonts): Release NSFontDescriptor created with new.
753 (ns_uni_to_glyphs): Fix indentation.
754 (setString): Release attrStr before assigning new value.
756 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
758 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
760 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
761 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
763 2011-12-18 David Reitter <reitter@cmu.edu>
765 * nsterm.m (ns_term_init): Subscribe for notifications
766 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
767 to method trackingNotification in EmacsMenu.
769 * nsmenu.m (trackingMenu): New variable.
770 (trackingNotification): New method (from Aquamacs).
771 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
772 from Aquamacs (Bug#7030).
774 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
776 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
777 (symbol_to_nsstring): Fix indentation.
778 (ns_symbol_to_pb): New function.
779 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
780 (Fns_rotate_cut_buffers_internal): Remove.
781 (Fns_store_selection_internal): Rename from
782 Fns_store_cut_buffer_internal.
783 (ns_get_foreign_selection, Fx_own_selection_internal)
784 (Fx_disown_selection_internal, Fx_selection_exists_p)
785 (Fns_get_selection_internal, Fns_store_selection_internal):
786 Use ns_symbol_to_pb and check if return value is nil.
787 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
788 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
789 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
790 renamed to Sns_store_selection_internal.
791 (ns_handle_selection_request): Move code to Fx_own_selection_internal
792 and remove this function.
793 (ns_handle_selection_clear): Remove, never used.
794 (Fx_own_selection_internal): Move code from ns_handle_selection_request
797 2011-12-17 Ken Brown <kbrown@cornell.edu>
799 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
800 GID is unknown (Bug#10257).
802 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
804 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
805 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
806 which caused a build failure on GNU/Linux IA-64. This problem was
807 introduced by my 2011-10-07 patch.
809 2011-12-15 Juri Linkov <juri@jurta.org>
811 * image.c (imagemagick_error): New function. (Bug#10112)
812 (imagemagick_load_image): Comment out `MagickSetResolution' call.
813 Use `imagemagick_error' where ImageMagick functions return
815 (Fimagemagick_types): Add `Fnreverse' to return the list in the
818 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
820 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
821 fill background (Bug#8992).
823 2011-12-13 Martin Rudalics <rudalics@gmx.at>
825 * window.c (Vwindow_combination_resize)
826 (Vwindow_combination_limit): Use t instead of non-nil in
828 (Vrecenter_redisplay): Add first sentence of doc-string on
830 (Frecenter): Fix doc-string typo.
832 2011-12-11 Kenichi Handa <handa@m17n.org>
834 * coding.c (Funencodable_char_position): Pay attention to the
835 buffer text relocation (Bug#9389).
837 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
839 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
840 gtk_init (Bug#10100).
842 2011-12-10 Eli Zaretskii <eliz@gnu.org>
844 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
845 IT->string is nil. (Bug#10263)
847 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
849 * nsterm.h (x_free_frame_resources): Declare.
851 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
852 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
854 * nsterm.h (ns_get_defaults_value): Declare.
856 * nsterm.m (ns_default): Call ns_get_defaults_value.
858 2011-12-09 Eli Zaretskii <eliz@gnu.org>
860 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
863 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
865 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
866 that where the value of an _OBJC_* symbol points to is in the .bss
869 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
871 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
872 after the loop to call ccl_driver at least once (Bug#8619).
874 2011-12-08 Kenichi Handa <handa@m17n.org>
876 * ftfont.c (get_adstyle_property): Fix previous change
879 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
881 * w32.c (init_environment): If no_site_lisp, remove site-lisp
882 dirs from the default value of EMACSLOADPATH (bug#10208).
884 2011-12-07 Glenn Morris <rgm@gnu.org>
886 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
887 installation and source directories as well. (Bug#10208)
889 2011-12-06 Chong Yidong <cyd@gnu.org>
891 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
893 2011-12-06 Glenn Morris <rgm@gnu.org>
895 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
896 as an error, not just -1. (Bug#10217)
898 2011-12-05 Chong Yidong <cyd@gnu.org>
900 * keyboard.c (process_special_events): New function.
901 (swallow_events, Finput_pending_p): Use it (Bug#10195).
903 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
905 * coding.c (encode_designation_at_bol): Don't use uninitialized
906 local variable (Bug#9318).
908 2011-12-05 Kenichi Handa <handa@m17n.org>
910 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
911 return Qnil (Bug#8046, Bug#10193).
913 2011-12-05 Kenichi Handa <handa@m17n.org>
915 * coding.c (encode_designation_at_bol): New args charbuf_end and
916 dst. Return the number of produced bytes. Callers changed.
917 (coding_set_source): Return how many bytes coding->source was
919 (coding_set_destination): Return how many bytes
920 coding->destination was relocated.
921 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
922 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
924 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
926 * coding.c (CODING_CHAR_CHARSET_P): New macro.
927 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
930 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
932 The following changes are to fix Bug#9318.
934 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
935 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
936 (encode_coding_iso_2022, encode_coding_sjis)
937 (encode_coding_big5, encode_coding_charset): Use the above macros.
939 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
941 * lisp.h (process_quit_flag): Fix external declaration.
943 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
945 Don't macro-inline non-performance-critical code.
946 * eval.c (process_quit_flag): New function.
947 * lisp.h (QUIT): Use it.
949 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
951 * nsfns.m (get_geometry_from_preferences): New function.
952 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
954 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
956 * emacs.c (Qkill_emacs): Define.
957 (syms_of_emacs): Initialize it.
958 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
959 Qquit_flag to `kill-emacs' instead.
960 (quit_throw_to_read_char): Add parameter `from_signal'.
961 All callers changed. Call Fkill_emacs if requested and safe.
962 * lisp.h (QUIT): Call Fkill_emacs if requested.
964 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
966 * widget.c (update_wm_hints): Return if wmshell is null.
967 (widget_update_wm_size_hints): New function.
969 * widget.h (widget_update_wm_size_hints): Declare.
971 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
972 widget_update_wm_size_hints (Bug#10104).
974 2011-12-03 Eli Zaretskii <eliz@gnu.org>
976 * xdisp.c (handle_invisible_prop): If the invisible text ends just
977 before a newline, prepare the bidi iterator for consuming the
978 newline, and keep the current paragraph direction. (Bug#10183)
979 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
981 2011-12-02 Juri Linkov <juri@jurta.org>
983 * search.c (Fword_search_regexp): New Lisp function created from
984 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
985 (Fword_search_backward, Fword_search_forward)
986 (Fword_search_backward_lax, Fword_search_forward_lax):
987 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
988 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
990 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
992 * fileio.c (Finsert_file_contents): Move after-change-function call
993 to before the "handled:" label, since all "goto handled" appear in
994 cases where the *-change-functions have already been properly called
997 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
999 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1000 waiting for input. (Bug#10169)
1002 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1004 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1005 verifies glyph row's hash code--we have just reallocated the
1006 glyphs, so their contents can be complete garbage. (Bug#10164)
1008 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1010 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1012 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1014 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1015 attributes are tested _before_ calling verify_row_hash, to protect
1016 against GCC re-ordering of the tests. (Bug#10164)
1018 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1020 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1022 * xterm.c (handle_one_xevent): Only set async_visible and friends
1023 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1024 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1025 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1027 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1029 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1030 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1031 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1032 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1033 All uses changed to use GCPRO1 etc.
1034 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1035 Revert to old implementation (i.e., before 2011-03-11).
1037 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1039 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1040 of scroll runs so as to avoid assigning disabled bogus rows and
1041 unnecessary graphics copy operations.
1043 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1045 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1046 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1047 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1048 (malloc, free, realloc, calloc): Redirect to e_* only when
1051 * lisp.h (GCTYPEBITS): Move before first use.
1052 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1053 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1054 this macro definition.
1056 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1059 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1061 * gtkutil.c (xg_create_frame_widgets):
1062 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1063 present with Gtk+ 2.0.
1065 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1067 * fileio.c (Finsert_file_contents): Undo previous change; see
1068 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1070 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1072 Rename locals to avoid shadowing.
1073 * fileio.c (Finsert_file_contents):
1074 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1075 * process.c (wait_reading_process_output):
1076 Rename inner 'proc' to 'p' to avoid shadowing.
1077 Indent for consistency with usual Emacs style.
1079 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1081 * xdisp.c (redisplay_window): If cursor row is not fully visible
1082 after recentering, and scroll-conservatively is set to a large
1083 number, scroll window by a few more lines to make the cursor fully
1084 visible and out of scroll-margin. (Bug#10105)
1085 (start_display): Don't move to the next line if the display should
1086 start at a newline that is part of a display vector or an overlay
1089 2011-11-24 Juri Linkov <juri@jurta.org>
1091 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1092 after the `MagickPingImage' call. (Bug#10112)
1094 2011-11-23 Chong Yidong <cyd@gnu.org>
1096 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1098 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1100 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1101 making another buffer current. (Bug#10114)
1103 2011-11-23 Glenn Morris <rgm@gnu.org>
1105 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1107 2011-11-23 Chong Yidong <cyd@gnu.org>
1109 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1110 using it (Bug#5984).
1112 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1114 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1115 and header-lines, as they don't have one computed for them.
1118 * .gdbinit (prow): Make displayed values more self-explaining.
1119 Add row's hash code.
1121 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1123 * process.c (wait_reading_process_output): Fix asynchrounous
1124 GnuTLS socket handling on some versions of the GnuTLS library.
1125 (wait_reading_process_output): Add comment and URL.
1127 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1129 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1131 2011-11-21 Chong Yidong <cyd@gnu.org>
1133 * window.c (Fnext_window, Fprevious_window): Doc fix.
1135 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1137 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1139 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1141 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1143 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1145 * window.c (Fset_window_combination_limit): Rename argument
1147 (Vwindow_combination_limit): Remove "status" from doc-string.
1149 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1151 * m/ibms390.h: Remove.
1152 * m/ibms390x.h: Don't include "ibms390.h".
1154 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1156 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1157 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1159 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1161 * casetab.c (Fset_case_table):
1162 * charset.c (Fcharset_after): Fix typos.
1164 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1166 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1167 Otherwise, valgrind does not work on some platforms.
1168 Problem reported by Andreas Schwab in
1169 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1170 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1171 is set, removing the need for VIRT_ADDRESS_VARIES.
1172 (PURE_P): Use a more-efficient implementation that needs just one
1173 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1174 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1175 to 4 (xorl, subq, cmpq, setbe).
1176 * alloc.c (pure): Always extern now, since that's the
1177 VIRT_ADDR_VARIES behavior.
1178 (PURE_POINTER_P): Use a single comparison, not two, for
1179 consistency with the new puresize.h.
1180 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1181 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1182 Remove VIRT_ADDR_VARIES no longer needed.
1184 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1186 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1187 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1188 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1189 behave as if the cursor position were at the window margin.
1191 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1192 and the cursor position is out of bounds, behave as if the cursor
1193 position were at the window margin. (Bug#10075)
1195 2011-11-18 Chong Yidong <cyd@gnu.org>
1197 * window.c (Fwindow_combination_limit): Make first argument
1198 non-optional, since it is meaningless for live windows like the
1201 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1203 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1205 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1207 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1208 (graft_intervals_into_buffer): Simplify.
1210 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1212 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1213 hash values of the two rows.
1214 (copy_row_except_pointers): Preserve the used[] arrays and the
1215 hash values of the two rows. (Bug#10035)
1216 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1218 * xdisp.c (row_hash): New function, body extracted from
1219 compute_line_metrics.
1220 (compute_line_metrics): Call row_hash, instead of computing the
1223 * dispnew.c (verify_row_hash): Call row_hash for computing the
1224 hash code of a row, instead of duplicating code from xdisp.c.
1226 * dispextern.h (row_hash): Add prototype.
1228 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1230 * frame.c (delete_frame): Don't delete the terminal when the last
1231 X frame is closed if emacs is built with GTK toolkit.
1233 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1235 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1237 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1239 * window.c (Vwindow_splits): Rename to
1240 Vwindow_combination_resize. Suggested by Juri Linkov.
1241 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1244 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1246 * nsfns.m (Fns_font_name):
1247 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1249 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1251 * window.h (window): Rename slot "nest" to "combination_limit".
1252 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1253 (Fset_window_nest): Rename to Fset_window_combination_limit.
1254 (Vwindow_nest): Rename to Vwindow_combination_limit.
1255 (recombine_windows, make_parent_window, make_window)
1256 (Fsplit_window_internal, saved_window)
1257 (Fset_window_configuration, save_window_save): Rename all
1258 occurrences of window_nest to window_combination_limit.
1260 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1262 * image.c (imagemagick_load_image): Fix typo.
1264 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1266 * xdisp.c (display_line): Move the call to
1267 highlight_trailing_whitespace before the call to
1268 compute_line_metrics, since the latter needs to see the final
1269 faces of all the glyphs to compute ROW's hash value.
1270 Fixes assertion violations in row_equal_p. (Bug#10035)
1272 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1274 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1275 just return (bug#10044).
1277 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1279 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1280 with user-defined heap size. Bump the default size of the temacs
1281 heap to 27MB, to avoid memory warning when running temacs.
1282 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1284 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1285 current_matrix and desired_matrix. (Bug#9990)
1286 (verify_row_hash) [XASSERTS]: New function.
1287 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1288 that the hash value of glyph rows is correct.
1290 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1292 * window.h (window): Remove splits slot.
1293 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1294 (Fdelete_other_windows_internal, make_parent_window)
1295 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1296 (Fset_window_configuration, save_window_save): Don't deal with
1297 split status of windows.
1298 (saved_window): Remove splits slot.
1299 (Vwindow_splits): Rewrite doc-string.
1301 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1303 * xfns.c (unwind_create_frame):
1304 * nsfns.m (unwind_create_frame):
1305 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1306 Vframe_list (Bug#9999).
1308 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1310 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1312 2011-11-11 Kenichi Handa <handa@m17n.org>
1314 * callproc.c (Fcall_process): Set the member dst_multibyte of
1317 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1319 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1320 avoid a crash (bug#9496).
1322 2011-11-09 Chong Yidong <cyd@gnu.org>
1324 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1325 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1327 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1329 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1331 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1333 Avoid some portability problems by eschewing 'extern inline' functions.
1334 The trivial performance wins aren't worth the portability hassles; see
1335 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1337 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1338 (window_box_width, window_box_left, window_box_left_offset)
1339 (window_box_right, window_box_right_offset): Undo previous change,
1340 by removing the "extern"s.
1341 * intervals.c (adjust_intervals_for_insertion)
1342 (adjust_intervals_for_deletion): Undo previous change,
1343 making these static again.
1344 (offset_intervals, temp_set_point_both, temp_set_point)
1345 (copy_intervals_to_string): No longer inline.
1346 * xdisp.c (window_text_bottom_y, window_box_width)
1347 (window_box_height, window_box_left_offset)
1348 (window_box_right_offset, window_box_left, window_box_right)
1349 (window_box): No longer inline.
1351 2011-11-08 Chong Yidong <cyd@gnu.org>
1353 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1354 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1355 Signal an error if not a live window.
1356 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1357 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1359 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1361 * lisp.h (syms_of_abbrev): Remove declaration.
1362 Reported by CHENG Gao <chenggao@royau.me>.
1364 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1366 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1367 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1368 of temacs in GUI mode.
1370 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1372 * window.h: Declare delete_all_child_windows instead of
1373 delete_all_subwindows.
1374 * window.c (Fwindow_nest, Fset_window_nest)
1375 (Fset_window_new_total, Fset_window_new_normal)
1376 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1377 (delete_all_subwindows): Rename to delete_all_child_windows.
1378 (Fdelete_other_windows_internal, Fset_window_configuration):
1379 Call delete_all_child_windows instead of delete_all_subwindows.
1380 * frame.c (delete_frame): Call delete_all_child_windows instead
1381 of delete_all_subwindows.
1383 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1385 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1386 This is also needed for porting to any host where GC_MARK_STACK is
1387 not GC_MAKE_GCPROS_NOOPS.
1388 (which_symbols): Use it.
1390 2011-11-07 Kenichi Handa <handa@m17n.org>
1392 * coding.c (coding_set_destination): Check coding->src_pos only
1393 when coding->src_object is a buffer (bug#9910).
1395 * process.c (send_process): Set the member src_multibyte of coding
1396 to 0 (bug#9911) when sending a unibyte text.
1398 * callproc.c (Fcall_process): Set the member src_multibyte of
1399 process_coding to 0 (bug#9912).
1401 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1403 * xmenu.c (cleanup_widget_value_tree): New function.
1404 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1405 calling free_menubar_widget_value_tree directly (Bug#9830).
1407 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1409 Fix some portability problems with 'inline'.
1410 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1411 (window_box_width, window_box_left, window_box_left_offset)
1412 (window_box_right, window_box_right_offset): Declare extern.
1413 Otherwise, these inline functions do not conform to C99 and
1414 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1415 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1416 * intervals.c (adjust_intervals_for_insertion)
1417 (adjust_intervals_for_deletion): Now extern, because otherwise the
1418 extern inline functions 'offset_intervals' couldn't refer to it.
1419 (static_offset_intervals): Remove.
1420 (offset_intervals): Rewrite using the old contents of
1421 static_offset_intervals. The old version didn't conform to C99
1422 because an extern inline function contained a reference to an
1423 identifier with static linkage.
1425 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1427 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1430 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1432 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1433 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1434 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1435 return Qleft_to_right.
1437 2011-11-06 Chong Yidong <cyd@gnu.org>
1439 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1440 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1441 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1442 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1443 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1444 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1445 (Fwindow_vscroll): Doc fix.
1446 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1447 argument, since it makes no sense to pass a live window and for
1448 consistency with window-child.
1450 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1452 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1455 2011-11-05 Jason Rumney <jasonr@gnu.org>
1457 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1458 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1460 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1461 bitwise arithmetic preventing use of unicode-sip and non-truetype
1464 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1466 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1469 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1470 initialization code to keep similarity to xfns.c after changes
1473 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1475 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1476 (unwind_create_frame): New function (Bug#9943).
1477 (Fx_create_frame): Restructure code to be more similar to the one in
1478 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1479 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1480 Move terminal->reference_count++ just before making the frame official
1483 * nsterm.m (x_free_frame_resources): New function.
1484 (x_destroy_window): Move code to x_free_frame_resources.
1486 * xfns.c (unwind_create_frame): Fix comment.
1487 (Fx_create_frame, x_create_tip_frame):
1488 Move terminal->reference_count++ just before making the frame
1489 official. Move initialization of image_cache_refcount and
1490 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1492 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1494 Support MSVC build with newer versions of Visual Studio.
1495 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1496 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1499 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1500 which are not supported by MSVC.
1501 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1502 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1504 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1506 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1508 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1510 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1512 Support MSVC build with newer versions of Visual Studio.
1513 * w32.c: Don't include w32api.h for MSVC.
1514 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1516 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1517 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1518 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1519 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1521 (alloca) [_MSC_VER]: Define to _alloca.
1523 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1525 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1527 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1529 * xdisp.c (note_mouse_highlight): If either of
1530 previous/next-single-property-change returns nil, treat that as
1531 the beginning or the end of the buffer. (Bug#9955)
1533 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1535 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1536 label is not null (Bug#9951).
1537 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1540 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1542 * window.c (Fwindow_body_size): Mention in the doc string that the
1543 return value is in frame's canonical units. (Bug#9949)
1545 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1547 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1549 * w32fns.c (unwind_create_frame): If needed, free the glyph
1550 matrices of the partially constructed frame. (Bug#9943)
1551 * xfns.c (unwind_create_frame): Likewise.
1553 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1555 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1556 Don't stop backward scan on the continuation glyph, even though
1557 its CHARPOS is positive.
1558 (mouse_face_from_buffer_pos, note_mouse_highlight):
1559 Rename cover_string to disp_string.
1561 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1563 * window.c (temp_output_buffer_show): Don't use
1564 Vtemp_buffer_show_specifiers.
1565 (Vtemp_buffer_show_specifiers): Remove unused variable.
1567 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1569 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1570 past the beginning of the current glyph matrix.
1572 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1574 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1575 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1576 HAVE_GTK3 (Bug#9869).
1578 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1579 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1581 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1583 * xterm.c: Declare x_handle_net_wm_state to return int.
1584 (handle_one_xevent): Check if we are iconified but don't have
1585 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1586 (get_current_wm_state): Return non-zero if not hidden,
1587 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1588 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1589 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1590 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1592 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1594 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1595 so that this new function doesn't get optimized away by a
1596 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1598 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1600 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1602 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1604 Fix the `xbytecode' command.
1605 * .gdbinit (xprintbytestr): New command.
1606 (xwhichsymbols): Rename from `which'; all callers changed.
1607 (xbytecode): Print the byte-code string as well.
1609 2011-10-29 Kim Storm <storm@cua.dk>
1611 * alloc.c (which_symbols): New function.
1613 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1615 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1618 2011-10-29 Glenn Morris <rgm@gnu.org>
1620 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1621 Not clear what it was for, and it causes various bugs. (Bug#9839)
1623 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1625 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1626 possible random value that matches one of those tested as
1627 condition to clear the mouse face.
1629 2011-10-28 Chong Yidong <cyd@gnu.org>
1631 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1633 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1635 * window.c (make_window): Initialize phys_cursor_on_p.
1637 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1639 * lisp.h (struct Lisp_Symbol): Update comments.
1641 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1643 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1645 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1647 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1648 <oslsachem@gmail.com> for helping to debug this.
1650 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1651 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1652 (g_b_init_get_glyph_outline_w): New static variables.
1653 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1654 (GetGlyphOutlineW_Proc): New typedefs.
1655 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1656 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1658 (w32font_open_internal, compute_metrics):
1659 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1660 instead of calling the "wide" APIs directly.
1662 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1664 * w32.h (syms_of_w32font): Add prototype.
1666 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1668 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1669 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1670 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1671 (Fmove_to_window_line): Doc fix.
1673 2011-10-27 Chong Yidong <cyd@gnu.org>
1675 * process.c (make_process): Set gnutls_state to NULL.
1677 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1678 non-NULL, regardless of GNUTLS_INITSTAGE.
1679 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1680 an error. Set process slots as soon as we allocate them.
1682 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1684 2011-10-27 Chong Yidong <cyd@gnu.org>
1686 * gnutls.c (emacs_gnutls_deinit): New function.
1687 Deallocate credentials structures as well as calling gnutls_deinit.
1688 (Fgnutls_deinit, Fgnutls_boot): Use it.
1690 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1691 (deactivate_process): Call emacs_gnutls_deinit.
1693 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1695 * image.c (x_create_x_image_and_pixmap):
1696 * w32.c (sys_rename, w32_delayed_load):
1697 * w32font.c (fill_in_logfont):
1698 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1700 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1702 * w32fns.c (w32_default_color_map): New function,
1703 extracted from Fw32_default_color_map.
1704 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1706 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1708 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1710 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1712 * keyboard.c (test_undefined): New function (bug#9751).
1713 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1715 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1717 * sysdep.c (init_sys_modes): Fix the check for the controlling
1718 terminal (Bug#6649).
1720 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1722 * dispextern.h (struct bidi_it): New member next_en_type.
1724 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1725 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1726 current character, check also for next_en_type being WEAK_EN.
1727 (bidi_resolve_weak): Don't enter the expensive loop if the current
1728 position is before next_en_pos. Record the bidi type of the first
1729 non-ET, non-BN character we find, in addition to its position.
1730 (bidi_level_of_next_char): Invalidate next_en_type when
1731 next_en_pos is over-stepped.
1733 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1735 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1736 * editfns.c: Rewrite current-time-zone so that it invokes
1737 the equivalent of (format-time-string "%Z") to get the time zone name.
1738 This fixes a bug when the time zone name contains characters that
1739 need converting from the system time locale to Emacs internal format.
1740 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1741 that patch fixed format-time-string to do the conversion, but
1742 I forgot to fix current-time-zone.
1743 (format_time_string): New function, containing most of
1744 what Fformat_time_string used to contain.
1745 (Fformat_time_string): Rewrite in terms of format_time_string.
1746 This doesn't change this function's behavior.
1747 (current-time-zone): Rewrite to use format_time_string.
1748 This fixes the bug reported by Michael Schierl in
1749 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1750 Jason Rumney's 2007-06-07 change worked around this bug, but
1752 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1754 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1756 * xdisp.c (start_display): If the character at POS is displayed
1757 via a display vector, reset IT->current.dpvec_index to zero.
1758 (try_window_reusing_current_matrix): If a line ends in a display
1759 vector or the next line starts in a display vector, continue
1760 redrawing the window even though the character position of
1761 start_row was reached.
1764 2011-10-18 Chong Yidong <cyd@gnu.org>
1766 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1767 with nobreak-char-display too.
1769 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1771 Fix part 3 of bug#9771.
1772 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1773 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1774 non-neutral characters if the current character is a paragraph
1775 separator (a.k.a. Newline). This avoids running the same
1776 expensive loop twice, once when we consume the preceding newline
1777 and the other time when the line actually needs to be displayed.
1778 Avoid the loop when we see neutrals on the base embedding level
1779 following a character whose directionality is the same as the
1780 paragraph's. This avoids running the expensive loop when a line
1781 ends in a long sequence of neutrals, like control characters.
1782 Add assertion against STRONG_AL type. Slightly rearrange code
1783 that determines the type of a neutral given the first non-neutral
1785 (bidi_level_of_next_char): Set next_en_pos to zero when
1786 invalidating its info.
1788 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1790 * xdisp.c (push_display_prop): Determine whether to record string
1791 or buffer position by IT->string, not by IT->method. Allow
1792 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1793 (move_it_vertically_backward): Don't look for character position
1794 immediately after the newline when in a continuation line.
1797 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1799 * window.c (coordinates_in_window): Rewrite and delabelize
1800 vertical border check. (Bug#5357) (Bug#9618)
1802 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1804 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1805 errors in XSetWindowBorder (bug#9310).
1807 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1809 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1810 avoid crash when xmalloc overrun checking is enabled.
1812 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1815 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1816 cursor motion with <left> and <right> arrow keys.
1818 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1819 some callers set that themselves.
1821 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1823 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1824 display string and the previous row comes from the same string and
1825 is empty. (Bug#9739) (Bug#9738)
1827 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1829 * doc.c (get_doc_string): Encode file name (bug#9735).
1831 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1833 * bidi.c (bidi_level_of_next_char):
1834 * xdisp.c (get_visually_first_element): Remove old incorrect
1835 comments regarding the Unicode Line Separator character.
1837 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1839 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1841 * alloc.c (Fgc_status): Do not access beyond zombies array
1842 boundary if nzombies > MAX_ZOMBIES.
1843 * alloc.c (dump_zombies): Add missing format specifier.
1845 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1847 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1848 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1850 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1851 Some packages use them to denote characters with modifiers.
1853 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1855 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1856 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1857 matching a pp-number. Rename parameter var to var1.
1859 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1861 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1863 2011-10-08 Glenn Morris <rgm@gnu.org>
1865 * callint.c (Fcall_interactively): Give a more explicit error for the
1866 'c' case with a non-character input. (Bug#8479)
1868 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1870 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1872 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1873 lines that are hscrolled on the left.
1875 * dispnew.c (buffer_posn_from_coords): Account for a possible
1876 presence of header-line. (Bug#4426)
1878 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1880 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1881 Don't advertise functionality which we discourage or doesn't work.
1883 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1885 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1886 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1887 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1888 this makes Emacs dump core during garbage collection on rare
1889 occasions. sizeof is obviously inferior to offsetof here, so
1890 stick with offsetof.
1891 (GC_POINTER_ALIGNMENT): New macro.
1892 (mark_memory): Omit 3rd (offset) arg; caller changed.
1893 Don't assume EMACS_INT alignment is the same as pointer alignment.
1895 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1897 * keyboard.c (read_key_sequence_remapped): New var.
1898 (read_key_sequence): Compute remapping in the right buffer.
1899 (command_loop_1): Use read_key_sequence's remapping directly.
1901 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1903 * dired.c (file_name_completion): Don't expand file name.
1904 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1905 before checking file name handler.
1907 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1908 they've been requested explicitly (bug#9591).
1910 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1912 * keymap.c (Fsingle_key_description): Use make_specified_string
1913 instead of build_string to build string from push_key_description.
1916 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1918 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1919 This fixes a Y2038 bug on 64-bit hosts.
1920 * buffer.c (reset_buffer):
1921 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1922 (Fclear_buffer_auto_save_failure):
1923 Use 0, not -1, to represent an unset failure time, since time_t
1924 might not be signed.
1926 Remove dependency on glibc malloc internals.
1927 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1928 Move back here from lisp.h, but with their new implementations.
1929 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1930 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1931 * charset.c (charset_table_init): New static var.
1932 (syms_of_charset): Use it instead of xmalloc. This removes a
1933 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1934 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1935 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1936 Move back to alloc.c.
1937 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1938 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1940 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1942 * nsterm.m (windowDidResize): Call x_set_window_size only when
1943 ns_in_resize is true. Otherwise set pixelwidth/height and
1944 call change_frame_size (Bug#9628).
1946 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1948 Port --enable-checking=all to Fedora 14 x86-64.
1949 * charset.c (syms_of_charset): Also account for glibc malloc's
1950 internal overhead when calculating the initial malloc maximum.
1952 Port --enable-checking=all to Fedora 14 x86.
1953 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1955 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1956 (overrun_check_realloc, overrun_check_free):
1957 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1958 That way, xmalloc returns a properly-aligned pointer even if
1959 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1960 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1961 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1962 into account when calculating the initial malloc maximum.
1963 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1964 Move here from alloc.c, so that charset.c can use it too.
1965 Properly align; the old code wasn't right for common 32-bit hosts
1966 when configured with --enable-checking=all.
1967 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1968 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1970 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1972 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1975 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1977 * xdisp.c (compute_display_string_end): If there's no display
1978 string at CHARPOS, return -1.
1980 * bidi.c (bidi_fetch_char): When compute_display_string_end
1981 returns a negative value, treat the character as a normal
1982 character not covered by a display string. (Bug#9624)
1984 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1986 * lread.c (Fread_from_string): Fix typo in docstring.
1988 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1990 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1991 newline, reseat the iterator instead of bidi-iterating there one
1992 character at a time. (Bug#9610)
1993 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1994 TO_CHARPOS if the bidi iterator is at base embedding level.
1996 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1998 * lread.c (readevalloop): Use correct code for NBSP.
1999 (read1): Likewise. (Bug#9608)
2001 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2003 * dbusbind.c (Fdbus_register_signal): When service is not
2004 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2006 2011-09-25 Glenn Morris <rgm@gnu.org>
2008 * buffer.c (truncate-lines): Doc fix.
2010 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2012 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2013 (Fset_window_next_buffers): Doc fix.
2015 2011-09-24 Glenn Morris <rgm@gnu.org>
2017 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2019 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2021 Fix minor problems found by static checking.
2022 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2023 * indent.c (Fvertical_motion): Fix == vs = typo.
2025 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2027 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2028 Default value is now t. Doc fix.
2030 * indent.c (Fvertical_motion): Compute and apply the overshoot
2031 logic when moving up, not only when moving down. Fix the
2032 confusing name and values of the it_overshoot_expected variable;
2033 logic changes accordingly. (Bug#9254) (Bug#9549)
2035 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2036 CHARPOS is covered by a display string which includes newlines.
2037 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2038 is covered by a display string with embedded newlines.
2040 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2042 * dbusbind.c (Fdbus_register_signal): Add match rule to
2043 Vdbus_registered_objects_table. (Bug#9581)
2044 (Fdbus_register_method, Vdbus_registered_objects_table):
2047 2011-09-24 Jim Meyering <meyering@redhat.com>
2049 do not ignore write error for any output size
2050 The previous change was incomplete.
2051 While it makes emacs --batch detect the vast majority of stdout
2052 write failures, errors were still ignored whenever the output size is
2053 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2054 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2055 && echo FAIL: ignored write error
2056 FAIL: ignored write error
2057 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2058 && echo FAIL: ignored write error
2059 FAIL: ignored write error
2060 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2062 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2064 * emacs.c (Fkill_emacs): In noninteractive mode exit
2065 non-successfully if a write error occurred on stdout. (Bug#9574)
2067 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2069 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2072 * dispextern.h (struct it): Update the comment documenting what
2075 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2077 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2078 a display string, extend search for cursor position to end of row.
2079 (find_row_edges): If the row ends in a newline from a display
2080 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2081 Handle the case of a display string with multiple newlines.
2082 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2083 non-empty line. Fixes confusing cursor motion with arrow keys at
2084 the beginning of a line that starts with whitespace.
2086 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2088 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2091 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2093 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2096 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2098 * xdisp.c (display_line): Record maximum and minimum buffer
2099 positions even if no glyphs were produced (e.g., by a zero-width
2100 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2101 buffer positions that will be removed from the glyph row because
2103 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2104 column is beyond frame width: don't subtract 1 "pixel" when
2105 computing width of the stretch.
2106 (reseat_at_next_visible_line_start): Undo the change made on
2107 2011-09-17 that saved paragraph information and restored it after
2108 the call to `reseat'. (Bug#9545)
2110 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2112 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2113 and turn window cursor on if cleared (Bug#9415).
2115 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2117 * search.c (boyer_moore): Take unibyte characters from pattern
2118 literally. (Bug#9458)
2120 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2122 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2124 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2126 Fix minor problem found by static checking.
2127 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2128 initialized, to pacify gcc -Wuninitialized.
2130 * fileio.c: Report proper errno when syscall falls.
2131 (Finsert_file_contents): Save and restore errno,
2132 so that report_file_error outputs the correct diagnostic.
2133 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2135 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2137 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2139 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2142 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2144 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2146 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2147 about the current paragraph and restore it after the call to reseat.
2149 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2150 (bidi_find_paragraph_start): Search back for paragraph beginning
2151 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2152 (bidi_move_to_visually_next): Only trigger paragraph-related
2153 computations when the last character is a newline or at EOB, not
2154 just any NEUTRAL_B. (Bug#9470)
2156 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2157 truncated lines if point is covered by a display string. (Bug#9524)
2159 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2161 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2162 (cons_to_x_long): New function.
2163 (lisp_data_to_selection_data): Use it. Correct the test for
2164 short-versus-long data; it was negated. Break out of vector
2165 loop, for efficiency, when a long datum is discovered.
2167 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2169 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2171 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2173 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2174 GCC PR/17406) by declaring this function with external scope.
2176 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2178 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2179 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2181 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2183 * editfns.c (Fformat): Correctly handle text properties on "%%".
2185 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2187 * xterm.c (x_draw_composite_glyph_string_foreground):
2188 * w32term.c (x_draw_composite_glyph_string_foreground):
2189 * term.c (encode_terminal_code):
2190 * composite.c (composition_update_it, get_composition_id):
2191 * xdisp.c (get_next_display_element)
2192 (fill_composite_glyph_string): Add comments about special meaning
2193 of TAB characters in a composition.
2195 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2197 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2198 This occurs when processing a multibyte format.
2199 Problem reported by Wolfgang Jenker.
2201 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2203 * xdisp.c (try_cursor_movement): Only check for exact match if
2204 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2206 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2208 Remove unused external symbols.
2209 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2210 * xdisp.c (calc_pixel_width_or_height): Now static.
2211 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2212 * indent.c (check_display_width):
2213 * w32term.c: Fix comment to match code.
2214 * xterm.c, xterm.h (x_catching_errors): Remove.
2216 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2218 * xselect.c: Use signed conversions more consistently (Bug#9498).
2219 (selection_data_to_lisp_data): Assume incoming selection data are
2220 signed integers, not unsigned. This is to be consistent with
2221 outgoing selection data, which was modified to use signed integers
2222 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2223 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2224 expects long, not unsigned long.
2226 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2228 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2229 computation of loop end. Reported by Johan Bockgård
2232 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2234 * frame.c (Fother_visible_frames_p): Function deleted.
2236 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2238 * indent.c (compute_motion): Process display vector front to back
2239 rather than the other way around. (Bug#2496)
2241 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2243 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2245 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2247 * minibuf.c (Fread_from_minibuffer): Doc fix.
2249 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2251 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2252 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2254 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2256 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2257 value for non-existent files.
2259 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2261 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2262 set its "size" to -1. This will set the modtime_size field of
2263 the corresponding buffer to -1, which is what
2264 verify-visited-file-modtime expects for files that do not exist.
2267 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2269 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2271 * lisp.h: ... from here. push_key_description is no longer
2272 defined in keyboard.c, so its declaration should not be in
2273 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2274 logically belongs with push_key_description.
2276 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2278 * buffer.h: Include <sys/types.h> instead of <time.h>.
2279 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2280 Problem reported by Herbert J. Skuhra.
2282 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2284 * xml.c (parse_region): Make the parsing work for
2285 non-comment-starting XML files again (bug#9144).
2287 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2289 * image.c (gif_load): Fix calculation of bottom and right corner.
2292 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2294 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2295 redisplay in small windows.
2297 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2299 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2301 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2303 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2304 Operate on live windows only.
2306 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2308 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2310 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2312 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2313 only under bidi iteration.
2315 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2317 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2319 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2321 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2322 Without this fix, the command to link temacs failed due to an
2323 undefined symbol __builtin_isnan. This is because
2324 /usr/include/iso/math_c99.h #defines isnan(x) to
2325 __builtin_isnan(x), but the bundled gcc, which identifies itself
2326 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2328 * floatfns.c (isnan): #undef, and then #define to a clone of
2330 (Fisnan): Always define, since it's always available now.
2331 (syms_of_floatfns): Always define isnan at the Lisp level.
2333 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2335 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2337 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2339 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2340 The previous code assumed that file offsets (off_t values) fit in
2341 EMACS_INT variables, which is not true on typical 32-bit hosts.
2342 The code messed up by falsely reporting buffer overflow in cases
2343 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2344 when "big" contains more than 2**29 bytes, even though this
2345 inserts just one byte and does not overflow the buffer.
2346 (Finsert_file_contents): Store file offsets as off_t
2347 values, not as EMACS_INT values. Check for overflow when
2348 converting between EMACS_INT and off_t. When checking for
2349 buffer overflow or for overlap, take the offsets into account.
2350 Don't use EMACS_INT for small values where int suffices.
2351 When checking for overlap, fix a typo: ZV was used where
2352 ZV_BYTE was intended.
2353 (Fwrite_region): Don't assume off_t fits into 'long'.
2354 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2356 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2358 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2360 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2362 sprintf-related integer and memory overflow issues (Bug#9412).
2364 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2365 (esprintf, exprintf, evxprintf): New functions.
2366 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2367 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2368 (modify_event_symbol): Do not assume that the length of
2369 name_alist_or_stem is safe to alloca and fits in int.
2370 (Fexecute_extended_command): Likewise for function name and binding.
2371 (Frecursion_depth): Wrap around reliably on integer overflow.
2372 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2373 since some callers pass EMACS_INT values.
2374 (Fsingle_key_description): Don't crash if symbol name contains more
2375 than MAX_ALLOCA bytes.
2376 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2377 (get_minibuffer): Arg is now EMACS_INT, not int.
2378 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2379 (esprintf, exprintf, evxprintf): New decls.
2380 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2382 * dbusbind.c (signature_cat): New function.
2383 (xd_signature, Fdbus_register_signal):
2384 Do not overrun buffer; instead, report string overflow.
2386 * dispnew.c (add_window_display_history): Don't overrun buffer.
2387 Truncate instead; this is OK since it's just a log.
2389 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2390 even if the time zone offset is outlandishly large.
2391 Don't mishandle offset == INT_MIN.
2393 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2394 when creating daemon; the previous buffer-overflow check was incorrect.
2396 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2397 which has the guts of the old verror function.
2399 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2400 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2402 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2403 (font_unparse_xlfd): Don't blindly alloca long strings.
2404 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2405 fits in int, when using sprintf. Use single snprintf to count
2406 length of string rather than counting it via multiple sprintfs;
2407 that's simpler and more reliable.
2408 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2409 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2410 sprintf, in case result does not fit in int.
2412 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2413 (fontset_from_font): Print it.
2415 * frame.c (tty_frame_count): Now printmax_t, not int.
2416 (make_terminal_frame, set_term_frame_name): Print it.
2417 (x_report_frame_params): In X, window IDs are unsigned long,
2418 not signed long, so print them as unsigned.
2419 (validate_x_resource_name): Check for implausibly long names,
2420 and don't assume name length fits in 'int'.
2421 (x_get_resource_string): Don't blindly alloca invocation name;
2422 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2425 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2426 (xg_check_special_colors, xg_set_geometry):
2427 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2429 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2430 Use esprintf, not sprintf, in case result does not fit in int.
2432 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2433 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2434 it as a large positive number.
2435 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2436 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2438 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2439 in case result does not fit in int.
2441 * print.c (float_to_string): Detect width overflow more reliably.
2442 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2443 buffer overrun. Don't assume list length fits in 'int'. Treat
2444 print length of 0 as 0, not as infinity; to be consistent with other
2445 uses of print length in this function. Don't overflow print length
2446 index. Don't assume hash table size fits in 'long', or that
2447 vectorlike size fits in 'unsigned long'.
2449 * process.c (make_process): Use printmax_t, not int, to format
2450 process-name gensyms.
2452 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2454 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2455 to avoid potential buffer overrun.
2457 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2458 if X resource line is longer than 512 bytes.
2460 * xfns.c (x_window): Make sprintf buffer a bit bigger
2461 to avoid potential buffer overrun.
2463 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2465 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2467 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2469 Integer overflow fixes for scrolling, etc.
2470 Without these, Emacs silently mishandles large integers sometimes.
2471 For example, "C-u 4294967297 M-x recenter" was treated as if
2472 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2474 * xdisp.c (try_window_id): Check Emacs fixnum range before
2475 converting to 'int'.
2477 * window.c (window_scroll_line_based, Frecenter):
2478 Check that an Emacs fixnum is in range before assigning it to 'int'.
2479 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2480 values converted from Emacs fixnums.
2481 (Frecenter): Don't wrap around a line count if it is out of 'int'
2482 range; instead, treat it as an extreme value.
2483 (Fset_window_configuration, compare_window_configurations):
2484 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2486 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2487 that can exceed INT_MAX. Check that EMACS_INT value is in range
2488 before assigning it to the (possibly-narrower) index.
2489 (match_limit): Don't assume that a fixnum can fit in 'int'.
2491 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2494 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2495 (Fvertical_motion): Don't wrap around LINES values that don't fit
2496 in 'int'. Instead, treat them as extreme values. This is good
2497 enough for windows, which can't have more than INT_MAX lines anyway.
2499 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2501 * Require libxml/parser.h to avoid compilation warning.
2503 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2505 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2506 since this reportedly can destroy thread storage.
2508 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2510 * syntax.c (find_defun_start): Update all cache variables if
2511 exiting early (Bug#9401).
2513 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2515 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2517 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2518 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2519 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2521 * term.c (tty_append_glyph): New function.
2522 (produce_stretch_glyph): Static function and its prototype deleted.
2524 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2527 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2529 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2530 when checking :margin (Bug#9390).
2531 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2532 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2533 so that the name doesn't mislead. All uses changed.
2535 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2537 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2540 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2542 * xdisp.c (move_it_to): Don't bail out early when reaching
2543 position beyond to_charpos, if we are scanning backwards.
2544 (move_it_vertically_backward): When DY == 0, make sure we get to
2545 the first character in the line after the newline.
2547 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2549 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2550 (ccl_driver): Do not generate an out-of-range pointer.
2551 (Fccl_execute_on_string): Remove unnecessary check for
2552 integer overflow, noted by Stefan Monnier in
2553 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2554 Remove a FIXME that didn't need fixing.
2555 Simplify the newly-introduced buffer reallocation code.
2557 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2559 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2561 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2563 Integer and memory overflow issues (Bug#9196).
2565 * doc.c (get_doc_string): Rework so that
2566 get_doc_string_buffer_size is the actual buffer size, rather than
2567 being 1 less than the actual buffer size; this makes xpalloc more
2570 * image.c (x_allocate_bitmap_record, cache_image):
2571 * xselect.c (Fx_register_dnd_atom):
2572 Simplify previous changes by using xpalloc.
2574 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2575 since either will do and ptrdiff_t is convenient with xpalloc.
2577 * charset.c (charset_table_size)
2578 (struct charset_sort_data.priority): Now ptrdiff_t.
2579 (charset_compare): Don't overflow if priorities differ greatly.
2580 (Fsort_charsets): Don't assume list length fits in int.
2581 Check for size-calculation overflow when allocating sort data.
2582 (syms_of_charset): Allocate an initial charset table that is
2583 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2585 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2587 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2588 The actual value is always <= INT_MAX, and leaving it unsigned made
2589 overflow checking harder.
2591 * dispextern.h (struct glyph_matrix.rows_allocated)
2592 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2593 with xpalloc. The values are still always <= INT_MAX.
2595 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2597 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2598 (SAFE_NALLOCA): New macro.
2600 * region-cache.c (struct boundary.pos, find_cache_boundary)
2601 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2602 (set_cache_region, invalidate_region_cache)
2603 (revalidate_region_cache, know_region_cache, region_cache_forward)
2604 (region_cache_backward, pp_cache):
2605 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2606 so that ptrdiff_t * can be passed to xpalloc.
2607 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2608 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2609 (pp_cache): Don't assume cache_len fits in int.
2610 * region-cache.h: Adjust extern decls to match.
2612 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2613 EMACS_INT, since either will do, for xpalloc.
2615 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2616 (xnmalloc, xnrealloc, xpalloc): New functions.
2618 * bidi.c (bidi_shelve_header_size): New constant.
2619 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2620 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2622 * bidi.c (bidi_cache_shrink):
2623 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2625 Don't update size of array until after memory allocation succeeds,
2626 because xmalloc/xrealloc may not return.
2627 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2628 now that we have proper integer overflow checking.
2629 (record_overlay_string, overlay_strings): Catch overflows when
2630 calculating size of overlay_str_buf.
2632 * callproc.c (Fcall_process): Check for size overflow when
2633 calculating size of args2.
2634 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2635 Normally we prefer signed values, but sticking with ptrdiff_t would
2636 require adding more-complicated checks.
2638 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2639 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2640 Redo buffer-overflow calculations to avoid integer overflow.
2641 Add a FIXME comment where memory seems to be over-allocated.
2643 * character.c (Fstring): Check for size-calculation overflow.
2645 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2646 unnecessary integer overflow. Check for size overflow.
2647 (encode_coding_object): Don't update size until xmalloc succeeds.
2649 * composite.c (get_composition_id): Check for overflow in glyph
2650 length calculations.
2652 Integer and memory overflow fixes for display code.
2653 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2654 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2655 (scrolling_window): Check for overflow in size calculations.
2656 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2657 Don't assume glyph table len fits in int.
2658 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2659 (row_table_size): Now ptrdiff_t, not int.
2660 (scrolling_window): Avoid overflow in size calculations.
2661 Don't update size until allocation succeeds.
2662 * fns.c (concat): Check for overflow in size calculations.
2663 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2664 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2665 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2667 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2668 (get_doc_string): Check for size calculation overflow.
2669 Don't update size until allocation succeeds.
2670 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2671 EMACS_INT, where ptrdiff_t will do.
2672 (Fsubstitute_command_keys): Check for string overflow.
2674 * editfns.c (set_time_zone_rule): Don't assume environment length
2676 (message_length): Now ptrdiff_t, not int.
2677 (Fmessage_box): Don't update size until allocation succeeds.
2678 Don't assume message length fits in int.
2679 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2681 * emacs.c (main): Do not reallocate argv, since there is a null at
2682 the end that can be overwritten, and this way there's no need to
2683 worry about size-calculation overflow.
2684 (sort_args): Check for size-calculation overflow.
2686 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2688 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2690 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2691 (x_set_scroll_bar_width, x_figure_window_size):
2692 Check for integer overflow.
2693 (x_set_alpha): Do not assume XINT fits in int.
2695 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2696 This is for the members text_lines, text_cols, total_lines, total_cols,
2697 where the system imposes an 'int' limit.
2699 * fringe.c (Fdefine_fringe_bitmap):
2700 Don't update size until alloc works.
2702 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2703 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2705 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2706 Check for size-calculation overflow.
2707 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2708 do, as we prefer signed integers.
2709 (id_to_widget.max_size, id_to_widget.used)
2710 (xg_store_widget_in_map, xg_remove_widget_from_map)
2711 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2712 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2713 Use and return ptrdiff_t, not int.
2714 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2715 * gtkutil.h: Change prototypes to match the above.
2717 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2718 are duplicate now that they've been promoted to lisp.h.
2719 (x_allocate_bitmap_record, x_alloc_image_color)
2720 (make_image_cache, cache_image, xpm_load):
2721 Don't update size until alloc is done.
2722 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2724 Check for size calculation overflow.
2725 (ct_colors_allocated_max): New constant.
2726 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2729 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2730 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2731 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2732 Use ptrdiff_t, not int, to count maps.
2733 (read_char_minibuf_menu_prompt): Check for overflow in size
2734 calculations. Don't update size until allocation succeeds.
2735 Redo calculations to avoid overflow.
2736 * keyboard.h: Change prototypes to match the above.
2738 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2740 (current_minor_maps): Check for size calculation overflow.
2741 * keymap.h: Change prototypes to match the above.
2743 * lread.c (read1, init_obarray): Don't update size until alloc done.
2745 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2746 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2748 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2749 Now ptrdiff_t, not int.
2750 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2751 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2753 * process.c (Fnetwork_interface_list): Check for overflow
2754 in size calculation.
2756 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2758 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2759 overflow. Don't bother calling xmalloc when xrealloc will do.
2761 * search.c (Freplace_match): Check for size calculation overflow.
2762 (Fset_match_data): Don't assume list lengths fit in 'int'.
2764 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2765 for command line length. Do not attempt to address one before the
2766 beginning of an array, as that's not portable.
2768 * term.c (max_frame_lines): Remove; unused.
2769 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2771 (encode_terminal_code, calculate_costs): Check for size
2772 calculation overflow.
2773 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2774 table lengths and related sizes. Don't update size until alloc
2775 done. Redo calculations to avoid overflow.
2776 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2778 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2779 subtracting pointers.
2780 (gobble_line): Check for overflow more carefully. Don't update size
2783 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2784 Don't update size until alloc done.
2785 Redo size calculations to avoid overflow.
2786 Check for size calculation overflow.
2787 (main) [DEBUG]: Fix typo in invoking tparam1.
2789 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2790 Use ptrdiff_t, not int, for sizes.
2791 (store_mode_line_noprop_char): Don't update size until alloc done.
2793 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2794 Use ptrdiff_t, not int, for sizes.
2795 (Finternal_make_lisp_face, cache_face):
2796 Check for size calculation overflow.
2797 (cache_face): Treat size calculation overflows as if they were
2798 memory exhaustion (the usual treatment), rather than aborting.
2800 * xfns.c (x_encode_text, x_set_name_internal)
2801 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2802 sizes, since they can exceed INT_MAX in size. Check for size
2803 calculation overflow.
2805 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2806 (xg_select): Check for size calculation overflow.
2807 Don't update size until alloc done.
2809 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2810 as sprintf is limited to int lengths.
2812 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2813 (X_LONG_MIN): New macros.
2814 Use them to make the following changes clearer.
2815 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2816 This change doesn't affect the value now, but it may help remind
2817 future maintainers not to raise the value too much later.
2818 (SELECTION_QUANTUM): Remove, replacing with ...
2819 (selection_quantum): ... new function, which avoids overflow.
2821 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2822 assumption that selection length fits in 'int'.
2823 (x_reply_selection_request, x_handle_selection_request)
2824 (x_get_window_property, receive_incremental_selection)
2825 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2826 (lisp_data_to_selection_data, clean_local_selection_data):
2827 Use ptrdiff_t, not int, to record length of selection.
2828 (x_reply_selection_request, x_get_window_property)
2829 (receive_incremental_selection, x_property_data_to_lisp):
2830 Redo calculations to avoid overflow.
2831 (x_reply_selection_request): When sending hint, ceiling it at
2832 X_LONG_MAX rather than relying on wraparound overflow to send
2834 (x_get_window_property, receive_incremental_selection)
2835 (lisp_data_to_selection_data, x_property_data_to_lisp):
2836 Check for size-calculation overflow.
2837 (x_get_window_property, receive_incremental_selection)
2838 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2839 Don't store size until memory allocation succeeds.
2840 (x_get_window_property): Plug memory leak on memory exhaustion.
2841 Don't double-block input; malloc is safe here. Don't assume 2**34
2842 - 4 fits in unsigned long. Add an xassert to check
2843 XGetWindowProperty overflow. Be more careful about overflow
2844 calculations, and distinguish size from memory overflow better.
2845 (receive_incremental_selection): When tracing, don't assume
2846 unsigned int is less than INT_MAX.
2847 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2848 harmful) conversions of unsigned short to int.
2849 (lisp_data_to_selection_data): Don't assume that integers
2850 in the range -65535 through -1 fit in an X unsigned short.
2851 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2852 result parameters unless successful. Rely on cons_to_unsigned
2853 to report problems with elements; the old code wasn't right anyway.
2854 (x_check_property_data): Check for int overflow; we cannot use
2855 a wider type due to X limits.
2856 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2858 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2860 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2861 (x_term_init): Check for size calculation overflow.
2862 (x_color_cells): Don't store size until memory allocation succeeds.
2863 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2864 Don't assume alloca size is less than MAX_ALLOCA.
2865 (x_term_init): Don't assume length fits in int (sprintf is limited
2868 Use ptrdiff_t for composition IDs.
2869 * character.c (lisp_string_width):
2870 * composite.c (composition_table_size, n_compositions)
2871 (get_composition_id, composition_gstring_from_id):
2872 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2873 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2874 * window.c (Frecenter):
2875 Use ptrdiff_t, not int, for composition IDs.
2876 * composite.c (get_composition_id): Check for integer overflow.
2877 * composite.h: Adjust prototypes to match the above changes.
2879 Use ptrdiff_t for hash table indexes.
2880 * category.c (hash_get_category_set):
2881 * ccl.c (ccl_driver):
2882 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2883 * coding.c (coding_system_charset_list, detect_coding_system):
2884 * coding.h (struct coding_system.id):
2885 * composite.c (get_composition_id, gstring_lookup_cache):
2886 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2887 * image.c (xpm_get_color_table_h):
2888 * lisp.h (hash_lookup, hash_put):
2889 * minibuf.c (Ftest_completion):
2890 Use ptrdiff_t for hash table indexes, not int (which is too
2891 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2892 32-bit --with-wide-int hosts).
2894 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2895 Add a FIXME comment about memory leaks.
2896 (syms_of_charset): Don't assume xmalloc returns.
2898 Don't assume that stated character widths fit in int.
2899 * character.c (Fchar_width, c_string_width, lisp_string_width):
2900 * character.h (CHAR_WIDTH):
2901 * indent.c (MULTIBYTE_BYTES_WIDTH):
2902 Use sanitize_char_width to avoid undefined and/or bad behavior
2903 with outlandish widths.
2904 * character.h (sanitize_tab_width): Rename from sanitize_width,
2905 now that we have two such functions. All uses changed.
2906 (sanitize_char_width): New inline function.
2908 Don't assume that tab-width fits in int.
2909 * character.h (sanitize_width): New inline function.
2910 (SANE_TAB_WIDTH): New macro.
2911 (ASCII_CHAR_WIDTH): Use it.
2912 * indent.c (sane_tab_width): Remove. All uses replaced by
2913 SANE_TAB_WIDTH (current_buffer).
2914 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2916 * fileio.c: Integer overflow issues with file modes.
2917 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2919 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2920 Remove unreachable code.
2921 (read_hex, load_charset_map_from_file): Check for integer overflow.
2923 * xterm.c: Don't go over XClientMessageEvent limit.
2924 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2925 (x_send_scroll_bar_event): Likewise. Check that the size does not
2926 exceed limits imposed by XClientMessageEvent, as well as the usual
2927 ptrdiff_t and size_t limits.
2929 * keyboard.c: Overflow, signedness and related fixes.
2930 (make_lispy_movement): Use same integer type in forward decl
2931 that is used in the definition.
2932 (read_key_sequence, keyremap_step):
2933 Change bufsize argument back to int, undoing my 2011-03-30 change.
2934 We prefer signed types, and int is wide enough here.
2935 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2936 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2937 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2938 length, not size_t. Use ptrdiff_t for index, not int.
2939 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2940 possibility of integer overflow.
2942 Overflow, signedness and related fixes for images.
2944 * dispextern.h (struct it.stack[0].u.image.image_id)
2945 (struct_it.image_id, struct image.id, struct image_cache.size)
2946 (struct image_cache.used, struct image_cache.ref_count):
2947 * gtkutil.c (update_frame_tool_bar):
2948 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2949 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2950 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2951 * nsmenu.m (update_frame_tool_bar):
2952 * xdisp.c (calc_pixel_width_or_height):
2953 * xfns.c (image_cache_refcount):
2954 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2955 on typical 64-bit hosts.
2957 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2958 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2959 Omit unnecessary casts to int.
2960 (parse_image_spec): Check that integers fall into 'int' range
2961 when the callers expect that.
2962 (image_ascent): Redo ascent calculation to avoid int overflow.
2963 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2964 (lookup_image): Remove unnecessary tests.
2965 (xbm_image_p): Locals are now of int, not EMACS_INT,
2966 since parse_image_check makes sure they fit into int.
2967 (png_load, gif_load, svg_load_image):
2968 Prefer int to unsigned where either will do.
2969 (tiff_handler): New function, combining the cores of the
2970 old tiff_error_handler and tiff_warning_handler.
2971 This function is rewritten to use vsnprintf and thereby avoid
2972 stack buffer overflows. It uses only the features of vsnprintf
2973 that are common to both POSIX and native Microsoft.
2974 (tiff_error_handler, tiff_warning_handler): Use it.
2975 (tiff_load, gif_load, imagemagick_load_image):
2976 Don't assume :index value fits in 'int'.
2977 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2978 (imagemagick_load_image): Check that crop parameters fit into
2979 the integer types that MagickCropImage accepts. Don't assume
2980 Vimagemagick_render_type has a nonnegative value. Don't assume
2981 size_t fits in 'long'.
2982 (gs_load): Use printmax_t to print the widest integers possible.
2983 Check for integer overflow when computing image height and width.
2985 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2987 * xdisp.c (redisplay_window): Don't force window start if point
2988 will be invisible in the resulting window. (Bug#9324)
2990 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2992 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2993 the display spec is of the form `(space ...)'.
2994 (handle_display_spec): Return the value returned by
2995 handle_single_display_spec, not just 1 or zero.
2996 (handle_single_display_spec): If the display spec is of the form
2997 `(space ...)', and specifies display in the text area, return 2
2999 (try_cursor_movement): Check for the need to scroll more
3000 accurately, and prefer exact match for point under bidi.
3001 Don't advance `row' beyond the last row of the window.
3003 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3004 into disp_prop; all users changed.
3006 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3007 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3008 for the text covered by the display property.
3010 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3012 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3013 Change return value to nil.
3014 (Frecord_buffer): Delete unused function.
3016 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3018 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3019 buffers, return left-to-right.
3020 (set_cursor_from_row): Consider candidate row a win if its glyph
3021 represents a newline and point is on that newline. Fixes cursor
3022 positioning on the newline at EOL of R2L text within L2R
3023 paragraph, and vice versa.
3024 (try_cursor_movement): Check continued rows, in addition to
3025 continuation rows. Fixes unwarranted scroll when point enters a
3026 continued line of R2L text within an L2R paragraph, or vice versa.
3027 (cursor_row_p): Consider the case of point being equal to
3028 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3029 from the end of a short line to the beginning of a continued line
3030 of R2L text within L2R paragraph.
3031 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3032 composed characters.
3034 * bidi.c (bidi_check_type): Use xassert.
3035 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3038 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3040 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3043 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3045 * nsfont.m (ns_otf_to_script): Fix typo.
3047 2011-08-22 Kenichi Handa <handa@m17n.org>
3049 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3050 extra slot even if the purpose is char-code-property-table.
3052 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3054 * xdisp.c (redisplay_window): When computing centering_position,
3055 account for the height of the header line. (Bug#8874)
3057 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3058 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3059 candidate is selected by the mouse, and that candidate has a
3060 composed character under the mouse.
3062 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3063 coordinates reported by pos-visible-in-window-p for a composed
3064 character in column zero.
3066 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3068 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3070 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3072 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3073 consider it a hit if to_charpos is anywhere in the range of the
3074 composed buffer positions.
3076 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3078 * image.c (gif_load): Don't assume that each subimage has the same
3079 dimensions as the base image. Handle disposal method that is
3080 "undefined" by the gif spec (Bug#9335).
3082 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3084 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3085 (Fcondition_case): Document `debug' symbol in error handler.
3087 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3089 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3090 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3091 from an Org mode buffer to a Speedbar frame.
3093 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3094 a composition, take its buffer position from IT->cmp_it.charpos.
3095 Fixes cursor positioning at the beginning of a line that begins
3096 with a composed character.
3098 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3100 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3101 character bidirectional type, use STRONG_L instead. Fixes crashes
3102 in a buffer produced by `describe-categories'.
3104 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3105 members before the level stack, so they would be saved and
3106 restored when copying iterator state. Fixes incorrect reordering
3107 around TABs covered by display properties.
3109 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3111 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3113 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3115 * eval.c (internal_condition_case, internal_condition_case_1)
3116 (internal_condition_case_2, internal_condition_case_n):
3117 Remove unnecessary aborts (Bug#9081).
3119 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3121 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3122 has no `load' handler, try opening the file locally. (Bug#9311)
3124 2011-08-16 Ken Brown <kbrown@cornell.edu>
3126 * gmalloc.c: Expand comment.
3128 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3130 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3131 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3133 2011-08-16 Ken Brown <kbrown@cornell.edu>
3135 Fix memory allocation problems in Cygwin build (Bug#9273).
3137 * unexcw.c ( __malloc_initialized): Declare external variable.
3138 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3140 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3142 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3144 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3146 [CYGWIN] (special_realloc): New function.
3147 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3148 requests to realloc storage in the static heap.
3150 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3152 * bidi.c (bidi_initialize): Remove unused local.
3154 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3157 * biditype.h: Remove file.
3158 * makefile.w32-in ($(BLD)/bidi.$(O)):
3159 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3161 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3163 * chartab.c: Improve commentary for the uniprop_table API.
3165 * bidi.c (bidi_paragraph_init): Support zero value of
3166 bidi_ignore_explicit_marks_for_paragraph_level.
3167 (bidi_initialize): Use uniprop_table instead of including
3168 biditype.h and bidimirror.h.
3170 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3171 coordinates of the iterator when restoring from ppos_it.
3174 2011-08-14 Kenichi Handa <handa@m17n.org>
3176 * process.c (create_process): Call setup_process_coding_systems
3177 after the pid of the process is set to -1 (Bug#8162).
3179 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3181 * xdisp.c (move_it_in_display_line_to): Don't invoke
3182 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3183 ppos_it. Fixes vertical cursor motion when line beginning is
3184 covered by an image. (Bug#9296)
3186 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3188 * nsterm.h (ns_run_ascript): Declare.
3189 (NSAPP_DATA2_RUNASSCRIPT): Define.
3191 * nsfns.m (as_script, as_result, as_status): New static variables.
3192 (ns_run_ascript): New function.
3193 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3194 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3195 the event loop. Get status from as_status (Bug#7276).
3197 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3198 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3199 the event loop (Bug#7276).
3201 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3203 * gnutls.c (QCgnutls_bootprop_priority)
3204 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3205 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3206 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3207 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3208 (QCgnutls_bootprop_verify_hostname_error)
3209 (QCgnutls_bootprop_callbacks_verify): Rename from
3210 Qgnutls_bootprop_..., all uses changed.
3212 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3215 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3217 * xfaces.c (Qframe_set_background_mode): Now static.
3218 * dispextern.h (Qframe_set_background_mode): Remove decl.
3220 * process.c (Fnetwork_interface_info): Declare local only if needed.
3222 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3224 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3225 (Fnetwork_interface_list): Allocate in increments of bytes instead
3226 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3227 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3229 (struct ifflag_def): notrailers is smart on OSX.
3230 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3231 Get hardware address with getifaddrs if available.
3233 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3235 * xdisp.c (iterate_out_of_display_property): xassert that
3236 IT->position is set to within IT->object's boundaries. Break from
3237 the loop as soon as EOB is reached; avoids infloops in redisplay
3238 when IT->position is set up wrongly due to some bug.
3239 Set IT->current to match the bidi iterator unconditionally.
3240 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3241 entry. Force push_it to save on the stack the current
3242 buffer/string position, to be restored by pop_it. Fix flags in
3243 the iterator structure wrt the object coming from a display
3244 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3245 properties. (Bug#9284)
3247 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3249 * fontset.c (fontset_get_font_group): Add proper type checks.
3252 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3254 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3255 and LC_VERSION_MIN_MACOSX.
3256 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3257 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3259 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3261 * xdisp.c (forward_to_next_line_start): Allow to use the
3262 no-display-properties-and-no-overlays under bidi display.
3263 Set disp_pos in the bidi iterator to avoid searches for display
3264 properties and overlays.
3266 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3268 * editfns.c (Fset_time_zone_rule): Document relationship with the
3271 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3272 the font entity extracted from the cache (Bug#8109).
3274 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3276 * composite.c (autocmp_chars): Don't reset point. That is done by
3277 restore_point_unwind (Bug#5984).
3279 2011-08-07 Juri Linkov <juri@jurta.org>
3281 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3282 to show the arg `TIME' instead of `TIMEVAL'.
3284 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3286 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3287 display property strides EOL and includes a newline, as in
3288 longlines-mode. (Bug#9254)
3289 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3290 word-wrap under bidirectional display. (Bug#9224)
3292 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3293 is non-zero, even if the data buffer is NULL. Fixes a crash in
3294 vertical-motion with longlines-mode. (Bug#9254)
3296 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3298 * bidi.c <bidi_cache_total_alloc>: Now static.
3299 (bidi_initialize): Initialize bidi_cache_total_alloc.
3301 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3304 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3305 amount allocated this far in `bidi_cache_total_alloc'.
3306 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3307 non-zero, only free the data buffer without restoring the cache
3308 contents. All callers changed.
3310 * dispextern.h (bidi_unshelve_cache): Update prototype.
3312 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3313 (move_it_in_display_line, move_it_to)
3314 (move_it_vertically_backward, move_it_by_lines): Replace the call
3315 to xfree to an equivalent call to bidi_unshelve_cache.
3316 (move_it_in_display_line_to): Fix logic of returning
3317 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3319 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3321 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3322 came from a string character with a `cursor' property. (Bug#9229)
3324 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3326 * Makefile.in (LIB_PTHREAD): New variable.
3327 (LIBES): Add LIB_PTHREAD (Bug#9216).
3329 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3330 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3332 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3334 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3336 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3338 * xterm.c (x_find_topmost_parent): New function.
3339 (x_set_frame_alpha): Find topmost parent window with
3340 x_find_topmost_parent and set the property there also (bug#9181).
3341 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3343 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3345 * callproc.c (Fcall_process): Avoid vfork clobbering
3346 the local vars buffer, coding_systems, current_dir.
3348 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3350 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3352 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3354 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3355 so that it is not optimized away.
3357 * xdisp.c (compute_display_string_pos): Remove unused local.
3359 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3361 Fix slow cursor motion and scrolling in large buffers with
3362 selective display, like Org Mode buffers. (Bug#9218)
3364 * dispextern.h (struct bidi_it): New member disp_prop_p.
3366 * xdisp.c: Remove one-slot cache of display string positions.
3367 (compute_display_string_pos): Accept an additional argument
3368 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3369 for a display string or property. If found, set DISP_PROP_P
3372 * bidi.c (bidi_fetch_char): Accept an additional argument
3373 DISP_PROP_P, and pass it to compute_display_string_pos.
3374 Only handle text covered by a display string if DISP_PROP_P is returned
3375 non-zero. All callers of bidi_fetch_char changed.
3377 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3379 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3381 2010-12-03 Don March <don@ohspite.net>
3383 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3384 last character M-[char] is translated to ESC [char] (bug#7541).
3386 2011-08-02 Kenichi Handa <handa@m17n.org>
3388 * lisp.h (uniprop_table): Extern it.
3390 * chartab.c (uniprop_table): Make it non-static.
3392 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3394 * xdisp.c (forward_to_next_line_start): Accept additional argument
3395 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3397 (reseat_at_next_visible_line_start): Use the bidi iterator state
3398 returned by forward_to_next_line_start to restore the state of
3399 it->bidi_it after backing up to previous newline. (Bug#9212)
3401 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3403 * regex.c (re_comp): Protoize.
3404 (re_exec): Fix return type.
3405 (regexec): Fix type of `ret'. (Bug#9203)
3407 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3409 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3410 This is needed if max-image-size is a floating-point number.
3412 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3414 * print.c (print_object): Print empty symbol as ##.
3416 * lread.c (read1): Read ## as empty symbol.
3418 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3420 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3421 setting frame foreground color (Bug#9175).
3422 (x_set_background_color): Likewise.
3424 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3425 contents (Bug#9176).
3426 (EmacsTooltip -init): Remove bezels and add shadows to
3429 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3430 or scroll bar (Bug#8470).
3432 * nsfont.m (nsfont_open): Remove assignment to voffset and
3433 unnecessary vars hshink, expand, hd, full_height, min_height.
3434 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3436 * nsterm.h (nsfont_info): Remove voffset field.
3438 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3440 Implement strike-through and overline on NextStep (Bug#8863).
3442 * nsfont.m (nsfont_open): Use underline position provided by font,
3443 instead of hard-coded value of 2.
3444 (nsfont_draw): Call ns_draw_text_decoration instead.
3446 * nsterm.h: Add declaration for ns_draw_text_decoration.
3448 * nsterm.m (ns_draw_text_decoration): New function for drawing
3449 underline, overline, and strike-through.
3450 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3451 ns_draw_text_decoration. Change treatment of cursor drawing to
3452 accommodate underlining, etc.
3454 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3456 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3459 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3461 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3462 Without this fix, if a signal arrives just after memory fills up,
3463 'malloc' might be invoked reentrantly.
3465 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3466 In other words, assume that every image size is allowed, on non-X
3467 hosts. This assumption is probably wrong, but it lets Emacs compile.
3469 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3471 * regex.c (re_iswctype): Convert return values to boolean.
3473 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3475 * xdisp.c (compute_display_string_pos): Don't use cached display
3476 string position if the buffer had its restriction changed.
3479 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3481 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3483 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3485 Integer signedness and overflow and related fixes. (Bug#9079)
3487 * bidi.c: Integer size and overflow fixes.
3488 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3489 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3490 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3491 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3492 (bidi_find_other_level_edge):
3493 Use ptrdiff_t instead of EMACS_INT where either will do.
3494 This works better on 32-bit hosts configured --with-wide-int.
3495 (bidi_cache_ensure_space): Check for size-calculation overflow.
3496 Use % rather than repeated addition, for better worst-case speed.
3497 Don't set bidi_cache_size until after xrealloc returns, because it
3499 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3500 (bidi_cache_ensure_space): Also check that the bidi cache size
3501 does not exceed that of the largest Lisp string or buffer. See Eli
3502 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3504 * alloc.c (__malloc_size_t): Remove.
3505 All uses replaced by size_t. See Andreas Schwab's note
3506 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3508 * image.c: Improve checking for integer overflow.
3509 (check_image_size): Assume that f is nonnull, since
3510 it is always nonnull in practice. This is one less thing to
3511 worry about when checking for integer overflow later.
3512 (x_check_image_size): New function, which checks for integer
3513 overflow issues inside X.
3514 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3515 This removes the need for a memory_full check.
3516 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3517 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3518 (xbm_read_bitmap_data): Change locals back to 'int', since
3519 their values must fit in 'int'.
3520 (xpm_load_image, png_load, tiff_load):
3521 Invoke x_create_x_image_and_pixmap earlier,
3522 to avoid much needless work if the image is too large.
3523 (tiff_load): Treat overly large images as if
3524 x_create_x_image_and_pixmap failed, not as malloc failures.
3525 (gs_load): Use x_check_image_size.
3527 * gtkutil.c: Omit integer casts.
3528 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3529 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3531 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3533 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3534 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3535 would wrongly return t on a 64-bit host.
3537 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3538 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3539 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3540 and therefore cause GCC to emit a bogus diagnostic in some cases.
3542 * image.c: Integer signedness and overflow and related fixes.
3543 This is not an exhaustive set of fixes, but it's time to
3544 record what I've got.
3545 (lookup_pixel_color, check_image_size): Remove redundant decls.
3546 (check_image_size): Don't assume that arbitrary EMACS_INT values
3547 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3548 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3549 (tiff_load, imagemagick_load_image):
3550 Check for overflow in size calculations.
3551 (x_create_x_image_and_pixmap): Remove unnecessary test for
3552 xmalloc returning NULL; that can't happen.
3553 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3554 (xpm_color_bucket): Use better integer hashing function.
3555 (xpm_cache_color): Don't possibly over-allocate memory.
3556 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3557 (gif_memory_source):
3558 Use ptrdiff_t, not int or size_t, to record sizes.
3559 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3560 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3561 either works, as we prefer signed integers.
3562 (tiff_read_from_memory, tiff_write_from_memory):
3563 Return tsize_t, not size_t, since that's what the TIFF API wants.
3564 (tiff_read_from_memory): Don't fail simply because the read would
3565 go past EOF; instead, return a short read.
3566 (tiff_load): Omit no-longer-needed casts.
3567 (Fimagemagick_types): Don't assume size fits into 'int'.
3569 Improve hashing quality when configured --with-wide-int.
3570 * fns.c (hash_string): New function, taken from sxhash_string.
3571 Do not discard information about ASCII character case; this
3572 discarding is no longer needed.
3573 (sxhash-string): Use it. Change sig to match it. Caller changed.
3574 * lisp.h: Declare it.
3575 * lread.c (hash_string): Remove, since we now use fns.c's version.
3576 The fns.c version returns a wider integer if --with-wide-int is
3577 specified, so this should help the quality of the hashing a bit.
3579 * emacs.c: Integer overflow minor fix.
3580 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3581 Define only if GNU_LINUX.
3582 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3584 * dispnew.c: Integer signedness and overflow fixes.
3585 Remove unnecessary forward decls, that were a maintenance hassle.
3586 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3588 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3589 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3590 (prepare_desired_row, line_draw_cost):
3591 Use int, not unsigned, where either works.
3592 (save_current_matrix, restore_current_matrix):
3593 Use ptrdiff_t, not size_t, where either works.
3594 (init_display): Check for overflow more accurately, and without
3595 relying on undefined behavior.
3597 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3598 Remove, replacing with the new symbols in lisp.h. All uses changed.
3599 * fileio.c (make_temp_name):
3600 * filelock.c (lock_file_1, lock_file):
3601 * xdisp.c (message_dolog):
3602 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3603 Use pMd etc. instead.
3604 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3605 replacing the pWIDE etc. symbols removed from editfns.c.
3607 * keyboard.h (num_input_events): Now uintmax_t.
3608 This is (very slightly) less likely to mess up due to wraparound.
3611 * buffer.c: Integer signedness fixes.
3612 (alloc_buffer_text, enlarge_buffer_text):
3613 Use ptrdiff_t rather than size_t when either will do, as we prefer
3616 * alloc.c: Integer signedness and overflow fixes.
3617 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3618 (__malloc_size_t): Default to size_t, not to int.
3619 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3620 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3621 Prefer ptrdiff_t to size_t when either would do, as we prefer
3623 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3624 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3625 Now const. Initialize with values that are in range even if char
3627 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3628 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3629 These functions do the right thing with sizes > 2**32.
3630 (check_depth): Now ptrdiff_t, not int.
3631 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3632 Adjust to new way of storing sizes. Check for size overflow bugs
3634 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3635 slightly wrong anyway, as it missed one instance of
3636 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3637 (refill_memory_reserve): Omit needless cast to size_t.
3638 (mark_object_loop_halt): Mark as externally visible.
3640 * xselect.c: Integer signedness and overflow fixes.
3641 (Fx_register_dnd_atom, x_handle_dnd_message):
3642 Use ptrdiff_t, not size_t, since we prefer signed.
3643 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3644 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3645 x_dnd_atoms_size and x_dnd_atoms_length.
3647 * doprnt.c: Prefer signed to unsigned when either works.
3649 * doprnt.c (doprnt):
3651 * xdisp.c (vmessage):
3652 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3653 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3654 prefer signed arithmetic to avoid comparison confusion.
3655 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3656 but is a bit tricky.
3658 Assume freestanding C89 headers, string.h, stdlib.h.
3659 * data.c, doprnt.c, floatfns.c, print.c:
3660 Include float.h unconditionally.
3661 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3662 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3663 * regex.c: Likewise for stddef.h, string.h.
3664 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3665 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3666 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3667 (STDC_HEADERS): Remove obsolete defines.
3668 * sysdep.c: Include limits.h unconditionally.
3670 Assume support for memcmp, memcpy, memmove, memset.
3671 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3672 * regex.c (memcmp, memcpy):
3673 Remove; we assume C89 now.
3675 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3676 (__malloc_safe_bcopy): Remove; no longer needed.
3678 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3679 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3680 well either way, and we prefer signed to unsigned.
3682 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3684 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3685 closes the connection while we're reading (bug#9182).
3687 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3689 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3690 are specified (Bug#9168).
3692 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3694 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3695 Found by GCC static checking and --with-wide-int on a 32-bit host.
3697 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3699 * xdisp.c (compute_display_string_pos): Fix logic of caching
3700 previous display string position. Initialize cached_prev_pos to
3701 -1. Fixes slow-down at the beginning of a buffer.
3703 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3705 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3706 for attrs[LFACE_FONTSET_INDEX].
3708 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3710 * xml.c (parse_region): Remove unused local
3711 that was recently introduced.
3713 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3715 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3716 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3718 * xdisp.c (move_it_in_display_line_to): Record the best matching
3719 position for TO_CHARPOS while scanning the line, and restore it on
3720 exit if none of the characters scanned was an exact match.
3721 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3722 when exact match is impossible due to invisible text, and the
3723 lines are truncated.
3725 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3727 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3730 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3732 Fix a significant slow-down of cursor motion with C-n, C-p,
3733 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3734 auto-repeat under bidi redisplay in fontified buffers.
3735 * xdisp.c (compute_stop_pos_backwards): New function.
3736 (next_element_from_buffer): Call compute_stop_pos_backwards to
3737 find a suitable prev_stop when we find ourselves before
3739 (reseat): Don't look for prev_stop, as that could mean a very long
3741 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3742 <cached_disp_overlay_modiff>: Cache for last found display string
3744 (compute_display_string_pos): Return the cached position if asked
3745 about the same buffer in the same area of character positions, and
3746 the buffer wasn't changed since the time the display string
3747 position was cached.
3749 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3751 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3752 is an integer, which is important for empty lines. (Bug#9149)
3754 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3756 * frame.c (Fmodify_frame_parameters): In tty case, update the
3757 default face if necessary (Bug#4238).
3759 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3761 * editfns.c (Fstring_to_char): No need to explain what a character
3762 is in the docstring (Bug#6576).
3764 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3766 * xml.c (parse_region): Make sure we always return a tree.
3768 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3770 * xml.c (parse_region): If a document contains only comments,
3773 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3775 * xml.c (make_dom): Return comments, too.
3777 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3780 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3781 and the surrounding thread.
3782 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3783 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3784 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3786 * s/openbsd.h (BROKEN_SIGIO): Define.
3787 * unexelf.c (unexec) [__OpenBSD__]:
3788 Don't update the .mdebug section of the Alpha COFF symbol table.
3790 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3792 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3795 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3797 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3798 This fixes some race conditions on the permissions of any newly
3801 * alloc.c (valid_pointer_p): Use pipe, not open.
3802 This fixes some permissions issues when debugging.
3804 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3805 If fchown fails to set both uid and gid, try to set just gid,
3806 as that is sometimes allowed. Adjust the file's mode to eliminate
3807 setuid or setgid bits that are inappropriate if fchown fails.
3809 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3811 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3812 to compare Lisp_Objects.
3813 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3814 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3815 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3817 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3819 * lread.c (read_integer): Unread even EOF character.
3820 (read1): Likewise. Properly record start position of symbol.
3822 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3823 symbol character follows.
3825 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3827 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3828 This works around a problem with the previous change to Fcopy_file.
3829 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3830 and without this change, GCC might complain about discarding
3831 fchown's return value.
3833 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3835 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3837 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3839 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3841 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3843 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3844 it's used from the C level.
3846 * process.c: Use the same condition for POLL_FOR_INPUT in both
3847 keyboard.c and process.c (bug#1858).
3849 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3851 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3852 (Fgnutls_boot): Use it.
3854 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3856 * doc.c (Fsubstitute_command_keys): Revert last change.
3858 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3860 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3861 quotes the next character, and doesn't affect other longer
3862 sequences (bug#8935).
3864 * lread.c (syms_of_lread): Clarify that is isn't only
3865 `eval-buffer' and `eval-defun' that's affected by
3866 `lexical-binding' (bug#8460).
3868 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3870 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3871 bidi redisplay when a line includes both an image and is truncated.
3873 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3875 Fix minor problems found by static checking.
3876 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3877 (elsz): Now a signed constant, not a size_t var. We prefer signed
3878 types to unsigned, to avoid integer comparison confusion. Without
3879 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3880 "cannot optimize loop, the loop counter may overflow", a symptom
3882 * indent.c (Fvertical_motion): Mark locals as initialized.
3883 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3885 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3887 * search.c (Fre_search_backward): Mention `case-fold-search' in
3888 all the re_search_* functions (bug#8138).
3890 * keyboard.c (Fopen_dribble_file): Document when the file is
3893 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3895 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3898 Support bidi reordering of display and overlay strings.
3899 * xdisp.c (compute_display_string_pos)
3900 (compute_display_string_end): Accept additional argument STRING.
3901 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3902 (reseat_to_string): Initialize bidi_it->string.s and
3903 bidi_it->string.schars.
3904 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3905 NULL (avoids a crash in bidi_paragraph_init).
3906 Initialize itb.string.lstring.
3907 (init_iterator): Call bidi_init_it only of a valid
3908 buffer position was specified. Initialize paragraph_embedding to
3910 (reseat_to_string): Initialize the bidi iterator.
3911 (display_string): If we need to ignore text properties of
3912 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3913 original value of -1 will not work with bidi.)
3914 (compute_display_string_pos): First arg is now struct
3915 `text_pos *'; all callers changed. Support display properties on
3917 (compute_display_string_end): Support display properties on Lisp
3919 (init_iterator, reseat_1, reseat_to_string): Initialize the
3920 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3921 when iterating on a string not from display properties).
3922 (compute_display_string_pos, compute_display_string_end):
3923 Fix calculation of the object to scan. Fixes an error when using
3925 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3926 base_level_stop; instead, set base_level_stop to BEGV.
3927 Fixes crashes in vertical-motion.
3928 (next_element_from_buffer): Improve commentary for when
3929 the iterator is before prev_stop.
3930 (init_iterator): Initialize bidi_p from the default value of
3931 bidi-display-reordering, not from buffer-local value. Use the
3932 buffer-local value only if initializing for buffer iteration.
3933 (handle_invisible_prop): Support invisible properties on strings
3934 that are being bidi-reordered.
3935 (set_iterator_to_next): Support bidi reordering of C strings and
3937 (next_element_from_string): Support bidi reordering of Lisp
3939 (handle_stop_backwards): Support Lisp strings as well.
3940 (display_string): Support display of R2L glyph rows.
3941 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3942 (init_iterator): Don't initialize it->bidi_p for strings
3944 (reseat_to_string): Initialize it->bidi_p for strings here.
3945 (next_element_from_string, next_element_from_c_string)
3946 (next_element_from_buffer): Add xassert's for correspondence
3947 between IT's object being iterated and it->bidi_it.string
3949 (face_before_or_after_it_pos): Support bidi iteration.
3950 (next_element_from_c_string): Handle the case of the first string
3951 character that is not the first one in the visual order.
3952 (get_visually_first_element): New function, refactored from common
3953 parts of next_element_from_buffer, next_element_from_string, and
3954 next_element_from_c_string.
3955 (tool_bar_lines_needed, redisplay_tool_bar)
3956 (display_menu_bar): Force left-to-right direction. Add a FIXME
3957 comment for making that be controlled by a user option.
3958 (push_it, pop_it): Save and restore the state of the
3959 bidi iterator. Save and restore the bidi_p flag.
3960 (pop_it): Iterate out of display property for string iteration as
3962 (iterate_out_of_display_property): Support iteration over strings.
3963 (handle_single_display_spec): Set up it->bidi_it for iteration
3964 over a display string, and call bidi_init_it.
3965 (handle_single_display_spec, next_overlay_string)
3966 (get_overlay_strings_1, push_display_prop): Set up the bidi
3967 iterator for displaying display or overlay strings.
3968 (forward_to_next_line_start): Don't use the shortcut if
3970 (back_to_previous_visible_line_start): If handle_display_prop
3971 pushed the iterator stack, restore the internal state of the bidi
3972 iterator by calling bidi_pop_it same number of times.
3973 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3974 and we are bidi-iterating, don't decrement the iterator position;
3975 instead, set the first_elt flag in the bidi iterator, to produce
3977 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3978 (push_display_prop): xassert that we are iterating a buffer.
3979 (push_it, pop_it): Save and restore paragraph_embedding member.
3980 (handle_single_display_spec, next_overlay_string)
3981 (get_overlay_strings_1, reseat_1, reseat_to_string)
3982 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3983 correctly. Don't assume unibyte strings are not bidi-reordered.
3984 (compute_display_string_pos)
3985 (compute_display_string_end): Fix handling the case of C string.
3986 (push_it, pop_it): Save and restore from_disp_prop_p.
3987 (handle_single_display_spec, push_display_prop): Set the
3988 from_disp_prop_p flag.
3989 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3990 (pop_it): Call iterate_out_of_display_property only if we are
3991 popping after iteration over a string that came from a display
3992 property. Fix a typo in popping stretch info. Add an assertion
3993 for verifying that the iterator position is in sync with the bidi
3995 (handle_single_display_spec, get_overlay_strings_1)
3996 (push_display_prop): Fix initialization of paragraph direction for
3997 string when that of the parent object is not yet determined.
3998 (reseat_1): Call bidi_init_it to resync the bidi
3999 iterator with IT's position. (Bug#7616)
4000 (find_row_edges): If ROW->start.pos gives position
4001 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4002 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4003 Reset the from_disp_prop_p flag.
4004 (SAVE_IT, RESTORE_IT): New macros.
4005 (pos_visible_p, face_before_or_after_it_pos)
4006 (back_to_previous_visible_line_start)
4007 (move_it_in_display_line_to, move_it_in_display_line)
4008 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4009 (try_scrolling, redisplay_window, display_line): Use them when
4010 saving a temporary copy of the iterator and restoring it back.
4011 (back_to_previous_visible_line_start, reseat_1)
4012 (init_iterator): Empty the bidi cache "stack".
4013 (move_it_in_display_line_to): If iterator ended up at
4014 EOL, but we never saw any buffer positions smaller than
4015 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4016 motion in bidi-reordered lines.
4017 (move_it_in_display_line_to): Record prev_method and prev_pos
4018 immediately before the call to set_iterator_to_next. Fixes cursor
4019 motion in bidi-reordered lines with stretch glyphs and strings
4020 displayed in margins. (Bug#8133) (Bug#8867)
4021 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4023 (pos_visible_p): Support positions in bidi-reordered lines.
4024 Save and restore bidi cache.
4026 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4027 (bidi_paragraph_info): Delete unused struct.
4028 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4029 (bidi_cache_start): New variable.
4030 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4032 (bidi_cache_fetch_state, bidi_cache_search)
4033 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4034 (bidi_cache_find, bidi_peek_at_next_level)
4035 (bidi_level_of_next_char, bidi_find_other_level_edge)
4036 (bidi_move_to_visually_next): Compare cache index with
4037 bidi_cache_start rather than with zero.
4038 (bidi_fetch_char): Accept new argument STRING; all callers
4039 changed. Support iteration over a string. Support strings with
4040 display properties. Support unibyte strings. Fix the type of
4041 `len' according to what STRING_CHAR_AND_LENGTH expects.
4042 (bidi_paragraph_init, bidi_resolve_explicit_1)
4043 (bidi_resolve_explicit, bidi_resolve_weak)
4044 (bidi_level_of_next_char, bidi_move_to_visually_next):
4045 Support iteration over a string.
4046 (bidi_set_sor_type, bidi_resolve_explicit_1)
4047 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4048 can now be zero (for strings); special values 0 and -1 were
4049 changed to -1 and -2, respectively.
4050 (bidi_char_at_pos): New function.
4051 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4052 Call it instead of FETCH_MULTIBYTE_CHAR.
4053 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4054 initialized to valid values.
4055 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4057 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4058 the test for valid cached positions. Fix the logic for looking up
4059 the sentinel state in the cache. GCPRO the Lisp string we are
4061 (bidi_push_it, bidi_pop_it): New functions.
4062 (bidi_initialize): Initialize the bidi cache start stack pointer.
4063 (bidi_cache_ensure_space): New function, refactored from part of
4064 bidi_cache_iterator_state. Don't assume the required size is just
4065 one BIDI_CACHE_CHUNK away.
4066 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4067 (bidi_count_bytes, bidi_char_at_pos): New functions.
4068 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4069 always valid if bidi_cache_idx is valid.
4070 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4071 is valid if it's going to be used.
4072 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4073 (bidi_cache_fetch_state, bidi_cache_search)
4074 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4075 (bidi_cache_iterator_state, bidi_cache_find)
4076 (bidi_find_other_level_edge, bidi_cache_start_stack):
4077 All variables related to cache indices are now EMACS_INT.
4079 * dispextern.h (struct bidi_string_data): New structure.
4080 (struct bidi_it): New member `string'. Make flag members be 1-bit
4081 fields, and put them last in the struct.
4082 (compute_display_string_pos, compute_display_string_end):
4084 (bidi_push_it, bidi_pop_it): Add prototypes.
4085 (struct iterator_stack_entry): New members bidi_p,
4086 paragraph_embedding, and from_disp_prop_p.
4087 (struct it): Member bidi_p is now a bit field 1 bit wide.
4088 (bidi_shelve_cache, bidi_unshelve_cache):
4091 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4092 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4093 and vector-like objects.
4095 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4096 cache around display iteration.
4098 * window.c (Fwindow_end, window_scroll_pixel_based)
4099 (displayed_window_lines, Frecenter): Save and restore the bidi
4100 cache around display iteration.
4102 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4104 * editfns.c (Fdelete_region): Clarify the use of the named
4105 parameters (bug#6788).
4107 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4109 * indent.c (Fvertical_motion): Set and restore w->pointm when
4110 saving and restoring the window's buffer (Bug#9006).
4112 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4114 * editfns.c (Fstring_to_char): Clarify just what is returned
4115 (bug#6576). Text by Eli Zaretskii.
4117 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4119 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4121 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4123 * buffer.c (mmap_find): Fix a typo.
4125 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4127 Fix execution of x selection hooks.
4128 * xselect.c (Qx_lost_selection_functions)
4129 (Qx_sent_selection_functions): New vars.
4130 (syms_of_xselect): DEFSYM them.
4131 (x_handle_selection_request): Pass Qx_sent_selection_functions
4132 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4133 (x_handle_selection_clear,x_clear_frame_selections):
4134 Pass Qx_lost_selection_functions rather than
4135 Vx_lost_selection_functions to Frun_hook_with_args.
4137 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4139 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4140 The old code sometimes used this field without initializing it.
4142 * alloc.c (gc_sweep): Don't read past end of array.
4143 In theory, the old code could also have corrupted Emacs internals,
4144 though it'd be very unlikely.
4146 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4148 * character.c (Fcharacterp): Don't advertise optional ignored
4149 argument. (Bug#4026)
4151 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4153 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4156 * window.c (Fset_window_start): Doc fix (bug#4199).
4157 (Fset_window_hscroll): Ditto.
4159 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4161 Fix minor new problems caught by GCC 4.6.1.
4162 * term.c (init_tty): Remove unused local.
4163 * xsettings.c (store_monospaced_changed): Define this function only
4164 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4167 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4169 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4171 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4173 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4174 are the mini-buffer and the echo area (bug#3320).
4176 * term.c (init_tty): Remove support for supdup, c10 and perq
4177 terminals, which are no longer supported (bug#1482).
4179 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4181 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4183 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4185 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4186 for non-popups (Bug#3642).
4188 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4190 * alloc.c (reset_malloc_hooks): Protoize.
4191 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4192 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4193 * cm.c (losecursor): Likewise.
4194 * data.c (fmod): Likewise.
4195 * dispnew.c (swap_glyphs_in_rows): Likewise.
4196 * emacs.c (memory_warning_signal): Likewise.
4197 * floatfns.c (float_error): Likewise.
4198 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4199 (otf_open, font_otf_capability, generate_otf_features)
4200 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4202 * image.c (pbm_read_file): Likewise.
4203 * indent.c (string_display_width): Likewise.
4204 * intervals.c (check_for_interval, search_for_interval)
4205 (inc_interval_count, count_intervals, root_interval)
4206 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4207 * lread.c (defalias): Likewise.
4208 * ralloc.c (r_alloc_check): Likewise.
4209 * regex.c (set_image_of_range_1, set_image_of_range)
4210 (regex_grow_registers): Likewise.
4211 * sysdep.c (strerror): Likewise.
4212 * termcap.c (valid_filename_p, tprint, main): Likewise.
4213 * tparam.c (main): Likewise.
4214 * unexhp9k800.c (run_time_remap, save_data_space)
4215 (update_file_ptrs, read_header, write_header, calculate_checksum)
4216 (copy_file, copy_rest, display_header): Likewise.
4217 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4219 * xdisp.c (check_it): Likewise.
4220 * xfaces.c (register_color, unregister_color, unregister_colors):
4222 * xfns.c (print_fontset_result): Likewise.
4223 * xrdb.c (member, fatal, main): Likewise.
4225 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4227 Fix minor problems found by static checking (Bug#9031).
4228 * chartab.c (char_table_set_range, map_sub_char_table):
4229 Remove unused locals.
4230 (uniprop_table): Now static.
4231 * composite.c (_work_char): Remove unused static var.
4233 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4235 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4237 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4239 * gtkutil.c (qttip_cb): Remove code without function.
4241 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4243 * w32.c (pthread_sigmask): New stub.
4245 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4247 Use pthread_sigmask, not sigprocmask (Bug#9010).
4248 sigprocmask is portable only for single-threaded applications, and
4249 Emacs can be multi-threaded when it uses GTK.
4250 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4252 * callproc.c (Fcall_process):
4253 * process.c (create_process):
4254 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4255 Use pthread_sigmask, not sigprocmask.
4257 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4259 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4260 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4263 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4265 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4266 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4267 (xg_hide_tooltip): Fix comment.
4269 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4270 in registerServicesMenuSendTypes.
4271 (validRequestorForSendType): Don't check ns_return_types.
4273 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4276 2011-07-08 Jason Rumney <jasonr@gnu.org>
4278 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4279 SH_SHOW for hidden windows (Bug#5482).
4281 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4282 frame struct members of non-existent frames (Bug#6284).
4284 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4286 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4287 variable firstTime not needed on OSX >= 10.6.
4288 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4289 >= 10.5. Use setKnobProportion, setDoubleValue.
4291 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4292 (MAC_OS_X_VERSION_10_5): Define if not defined.
4293 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4294 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4295 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4297 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4298 cString and lossyCString on OSX >= 10.4
4300 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4301 sizeToFit on OSX >= 10.2.
4303 * nsimage.m (allocInitFromFile): Don't use deprecated method
4304 bestRepresentationForDevice on OSX >= 10.6.
4306 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4309 * emacs.c: Declare unexec_init_emacs_zone.
4311 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4313 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4315 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4316 on svcsMenu (Bug#8842).
4318 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4320 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4322 * nsterm.m (QUTF8_STRING): Declare.
4323 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4324 (validRequestorForSendType): Return type is (id).
4325 Change indexOfObjectIdenticalTo to indexOfObject.
4326 Check if we have local selection before returning self (Bug#8842).
4327 (writeSelectionToPasteboard): Put local selection into paste board
4328 if we have a local selection (Bug#8842).
4329 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4331 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4332 (ns_get_local_selection): Declare.
4334 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4336 * keymap.c (describe_map_tree): Don't insert a double newline at
4337 the end of the buffer (bug#1169) and return whether we inserted
4340 * callint.c (Fcall_interactively): Change "reading args" to
4341 "providing args" to try to clarify what it does (bug#1010).
4343 2011-07-07 Kenichi Handa <handa@m17n.org>
4345 * composite.c (composition_compute_stop_pos): Ignore a static
4346 composition starting before CHARPOS (Bug#8915).
4348 * xdisp.c (handle_composition_prop): Likewise.
4350 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4352 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4355 2011-07-07 Kenichi Handa <handa@m17n.org>
4357 * character.h (unicode_category_t): New enum type.
4359 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4360 (Qchar_code_property_table): New variable.
4361 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4362 (UNIPROP_COMPRESSED_FORM_P): New macros.
4363 (char_table_ascii): Uncompress the compressed values.
4364 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4365 Uncompress the compressed values.
4366 (sub_char_table_ref_and_range): Likewise.
4367 (char_table_ref_and_range): Uncompress the compressed values.
4368 (sub_char_table_set): New arg is_uniprop. Callers changed.
4369 Uncompress the compressed values.
4370 (sub_char_table_set_range): Args changed. Callers changed.
4371 (char_table_set_range): Adjuted for the above change.
4372 (map_sub_char_table): Delete args default_val and parent. Add arg
4373 top. Give decoded values to a Lisp function.
4374 (map_char_table): Adjust for the above change. Give decoded
4375 values to a Lisp function. Gcpro more variables.
4376 (uniprop_table_uncompress)
4377 (uniprop_decode_value_run_length): New functions.
4378 (uniprop_decoder, uniprop_decoder_count): New variables.
4379 (uniprop_get_decoder, uniprop_encode_value_character)
4380 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4382 (uniprop_encoder, uniprop_encoder_count): New variables.
4383 (uniprop_get_encoder, uniprop_table)
4384 (Funicode_property_table_internal, Fget_unicode_property_internal)
4385 (Fput_unicode_property_internal): New functions.
4386 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4387 Sunicode_property_table_internal, Sget_unicode_property_internal,
4388 and Sput_unicode_property_internal. Defvar_lisp
4389 char-code-property-alist.
4391 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4392 Vunicode_category_table.
4394 * font.c (font_range): Adjust for the change of
4395 Vunicode_category_table.
4397 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4399 * m/iris4d.h: Remove file, move contents ...
4400 * s/irix6-5.h: ... here.
4402 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4404 Remove unportable assumption about struct layout (Bug#8884).
4405 * alloc.c (mark_buffer):
4406 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4407 (clone_per_buffer_values): Don't assume that
4408 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4409 This isn't true in general, and it's particularly not true
4410 if Emacs is configured with --with-wide-int.
4411 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4412 New macros, used in the buffer.c change.
4414 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4416 * xsettings.c: Use both GConf and GSettings if both are available.
4417 (store_config_changed_event): Add comment.
4418 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4419 (store_tool_bar_style_changed): New functions.
4420 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4421 (struct xsettings): Move font inside HAVE_XFT.
4422 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4423 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4424 Move inside HAVE_XFT.
4425 (something_changed_gsettingsCB): Rename from something_changedCB.
4426 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4428 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4429 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4430 (something_changed_gconfCB): Rename from something_changedCB.
4431 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4432 (parse_settings): Move check for font inside HAVE_XFT.
4433 (read_settings, apply_xft_settings): Add comment.
4434 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4435 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4436 call store_font_name_changed.
4437 (xft_settings_event): Add comment.
4438 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4439 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4440 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4441 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4442 (xsettings_initialize): Call init_gsettings last.
4443 (xsettings_get_system_font, xsettings_get_system_normal_font):
4446 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4448 Random fixes. E.g., (random) never returned negative values.
4449 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4450 subseconds part to the entropy, as that's a bit more random.
4451 Prefer signed to unsigned, since the signedness doesn't matter and
4452 in general we prefer signed. When given a limit, use a
4453 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4454 latter isn't right if USE_2_TAGS_FOR_INTS.
4455 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4456 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4458 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4460 * textprop.c (text_property_stickiness):
4461 Obey Vtext_property_default_nonsticky.
4462 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4463 * w32fns.c (syms_of_w32fns):
4464 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4466 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4468 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4469 This is more efficient than Ffile_directory_p and avoids a minor race.
4471 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4473 * buffer.c (Foverlay_put): Say what the return value is
4476 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4477 is a directory before asking whether to use the file name
4479 (barf_or_query_if_file_exists): Make the "File is a directory"
4480 error be more correct.
4482 * fns.c (Frequire): Remove the mention of the .gz files, since
4483 that's installation-specific, but keep the mention of
4484 `get-load-suffixes'.
4486 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4488 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4489 Report string overflow if the output is too long.
4491 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4493 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4494 (syms_of_gnutls): Remove duplicate DEFSYM for
4495 Qgnutls_bootprop_verify_hostname_error, an error for
4496 Qgnutls_bootprop_verify_error (which is no longer used).
4498 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4499 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4500 Also (re)move comments that are misplaced or no longer relevant.
4502 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4504 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4506 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4508 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4509 and background color parameters if they have been changed.
4511 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4513 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4515 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4517 * xsettings.c (SYSTEM_FONT): Define only when used.
4518 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4520 * keymap.c (access_keymap_1): Now static.
4522 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4524 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4525 leave any prefix arg for the up event (Bug#1586).
4527 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4529 * lread.c (syms_of_lread): Mention single symbols defined by
4530 `defvar' or `defconst' (bug#7154).
4532 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4533 (Frequire): Mention get-load-suffixes.
4535 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4537 * window.h (window): Remove clone_number slot.
4538 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4540 (make_parent_window, make_window, saved_window)
4541 (Fset_window_configuration, save_window_save): Don't deal with
4543 * buffer.c (Qclone_number): Remove declaration.
4544 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4546 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4548 Add multiple inheritance to keymaps.
4549 * keymap.c (Fmake_composed_keymap): New function.
4550 (Fset_keymap_parent): Simplify.
4551 (fix_submap_inheritance): Remove.
4552 (access_keymap_1): New function extracted from access_keymap to handle
4553 embedded parents and handle lists of maps.
4554 (access_keymap): Use it.
4555 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4556 (Fcopy_keymap): Handle embedded parents.
4557 (Fcommand_remapping, define_as_prefix): Simplify.
4558 (Fkey_binding): Simplify.
4559 (syms_of_keymap): Move minibuffer-local-completion-map,
4560 minibuffer-local-filename-completion-map,
4561 minibuffer-local-must-match-map, and
4562 minibuffer-local-filename-must-match-map to Elisp.
4563 (syms_of_keymap): Defsubr make-composed-keymap.
4564 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4565 (parse_menu_item): Trivial simplification.
4567 2011-07-01 Glenn Morris <rgm@gnu.org>
4569 * Makefile.in (SETTINGS_LIBS): Fix typo.
4571 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4573 * coding.c (Fencode_coding_string): Record the last coding system
4574 used, as the function doc string says (bug#8738).
4576 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4578 * xsettings.c (store_monospaced_changed): Take new font as arg and
4579 check for change against current_mono_font.
4580 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4581 (emacs_settings_constructor, emacs_settings_get_property)
4582 (emacs_settings_set_property, emacs_settings_class_init)
4583 (emacs_settings_init, gsettings_obj): Remove.
4584 (something_changedCB): New function for HAVE_GSETTINGS.
4585 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4586 with value as argument.
4587 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4588 g_settings_new (Bug#8967). Do not create gsettings_obj.
4589 Remove calls to g_settings_bind. Connect something_changedCB to
4592 * xgselect.c: Add defined (HAVE_GSETTINGS).
4593 (xgselect_initialize): Ditto.
4595 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4596 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4599 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4601 * eval.c (struct backtrace): Simplify and port the data structure.
4602 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4603 signed bit field, as this assumption is not portable and it makes
4604 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4605 "char debug_on_exit : 1" as this is not portable either; instead,
4606 use the portable "unsigned int debug_on_exit : 1". Remove unused
4607 member evalargs. Remove obsolete comments about cc bombing out.
4609 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4611 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4612 Let HAVE_GSETTINGS override HAVE_GCONF.
4613 (store_monospaced_changed): New function.
4614 (EMACS_SETTINGS): A new type derived from GObject to handle
4615 GSettings notifications.
4616 (emacs_settings_constructor, emacs_settings_get_property)
4617 (emacs_settings_set_property, emacs_settings_class_init):
4619 (gsettings_client, gsettings_obj): New variables.
4620 (GSETTINGS_SCHEMA): New define.
4621 (something_changedCB): Call store_monospaced_changed.
4622 (init_gsettings): New function.
4623 (xsettings_initialize): Call init_gsettings.
4624 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4627 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4630 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4632 * window.c (resize_root_window, grow_mini_window)
4633 (shrink_mini_window): Rename Qresize_root_window to
4634 Qwindow_resize_root_window and Qresize_root_window_vertically to
4635 Qwindow_resize_root_window_vertically.
4637 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4639 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4641 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4643 * makefile.w32-in: Redesign dependencies so they reflect more
4644 clearly which files are directly included by each source file,
4645 and not through other includes.
4647 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4649 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4650 (sort_overlays, overlay_strings): When an overlay's clone number
4651 matches the window's clone number process the overlay even if
4652 the overlay's window property doesn't match the current window.
4654 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4655 (Fwindow_hchild): Rename to Fwindow_left_child.
4656 (Fwindow_next): Rename to Fwindow_next_sibling.
4657 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4658 (resize_window_check): Rename to window_resize_check.
4659 (resize_window_apply): Rename to window_resize_apply.
4660 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4661 (Fdelete_other_windows_internal, resize_frame_windows)
4662 (Fsplit_window_internal, Fdelete_window_internal)
4663 (grow_mini_window, shrink_mini_window)
4664 (Fresize_mini_window_internal): Fix callers accordingly.
4666 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4668 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4669 (emacs_fixed_set_min_size): Remove.
4670 (emacs_fixed_new): Take frame as argument.
4672 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4673 (_EmacsFixedPrivate): Remove minwidth/height.
4674 Add struct frame *f.
4675 (emacs_fixed_init): Initialize priv->f.
4676 (get_parent_class, emacs_fixed_set_min_size): Remove.
4677 (emacs_fixed_new): Set priv->f to argument.
4678 (emacs_fixed_get_preferred_width)
4679 (emacs_fixed_get_preferred_height): Use min_width/height from
4680 frames size_hint to set minimum and natural (Bug#8919).
4681 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4682 and use min_width/height from frames size_hint to set
4683 min_width/height (Bug#8919).
4685 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4686 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4689 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4691 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4692 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4695 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4697 * process.c (wait_reading_process_output): Bypass select if
4698 waiting for a cell while ignoring keyboard input, and input is
4699 pending. Suggested by Jan Djärv (Bug#8869).
4701 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4703 Use gnulib's dup2 module instead of rolling our own.
4704 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4706 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4708 * dispnew.c (scrolling_window): Before scrolling, turn off a
4709 mouse-highlight in the window being scrolled.
4711 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4713 Move DEFSYM to lisp.h and use everywhere.
4715 * character.h (DEFSYM): Move declaration...
4716 * lisp.h (DEFSYM): ...here.
4722 * w32select.c: Don't include character.h.
4724 * alloc.c (syms_of_alloc):
4725 * buffer.c (syms_of_buffer):
4726 * bytecode.c (syms_of_bytecode):
4727 * callint.c (syms_of_callint):
4728 * casefiddle.c (syms_of_casefiddle):
4729 * casetab.c (init_casetab_once):
4730 * category.c (init_category_once, syms_of_category):
4731 * ccl.c (syms_of_ccl):
4732 * cmds.c (syms_of_cmds):
4733 * composite.c (syms_of_composite):
4734 * dbusbind.c (syms_of_dbusbind):
4735 * dired.c (syms_of_dired):
4736 * dispnew.c (syms_of_display):
4737 * doc.c (syms_of_doc):
4738 * editfns.c (syms_of_editfns):
4739 * emacs.c (syms_of_emacs):
4740 * eval.c (syms_of_eval):
4741 * fileio.c (syms_of_fileio):
4742 * fns.c (syms_of_fns):
4743 * frame.c (syms_of_frame):
4744 * fringe.c (syms_of_fringe):
4745 * insdel.c (syms_of_insdel):
4746 * keymap.c (syms_of_keymap):
4747 * lread.c (init_obarray, syms_of_lread):
4748 * macros.c (syms_of_macros):
4749 * msdos.c (syms_of_msdos):
4750 * print.c (syms_of_print):
4751 * process.c (syms_of_process):
4752 * search.c (syms_of_search):
4753 * sound.c (syms_of_sound):
4754 * syntax.c (init_syntax_once, syms_of_syntax):
4755 * terminal.c (syms_of_terminal):
4756 * textprop.c (syms_of_textprop):
4757 * undo.c (syms_of_undo):
4758 * w32.c (globals_of_w32):
4759 * window.c (syms_of_window):
4760 * xdisp.c (syms_of_xdisp):
4761 * xfaces.c (syms_of_xfaces):
4762 * xfns.c (syms_of_xfns):
4763 * xmenu.c (syms_of_xmenu):
4764 * xsettings.c (syms_of_xsettings):
4765 * xterm.c (syms_of_xterm): Use DEFSYM.
4767 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4769 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4771 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4773 Integer and buffer overflow fixes (Bug#8873).
4775 * print.c (printchar, strout): Check for string overflow.
4776 (PRINTPREPARE, printchar, strout):
4777 Don't set size unless allocation succeeds.
4779 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4780 for sizes. Check for string overflow more accurately.
4781 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4783 * macros.c: Integer and buffer overflow fixes.
4784 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4785 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4786 Use ptrdiff_t, not int, for sizes.
4787 Don't increment bufsize until after realloc succeeds.
4788 Check for size-calculation overflow.
4789 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4791 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4793 * lread.c: Integer overflow fixes.
4794 (read_integer): Radix is now EMACS_INT, not int,
4795 to improve quality of diagnostics for out-of-range radices.
4796 Calculate buffer size correctly for out-of-range radices.
4797 (read1): Check for integer overflow in radices, and in
4798 read-circle numbers.
4799 (read_escape): Avoid int overflow.
4800 (Fload, openp, read_buffer_size, read1)
4801 (substitute_object_recurse, read_vector, read_list, map_obarray):
4802 Use ptrdiff_t, not int, for sizes.
4803 (read1): Use EMACS_INT, not int, for sizes.
4804 Check for size overflow.
4806 * image.c (cache_image): Check for size arithmetic overflow.
4808 * lread.c: Integer overflow issues.
4809 (saved_doc_string_size, saved_doc_string_length)
4810 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4811 Now ptrdiff_t, not int.
4812 (read1): Don't assume doc string length fits in int. Check for
4813 out-of-range doc string lengths.
4814 (read_list): Don't assume file position fits in int.
4815 (read_escape): Check for hex character overflow.
4817 2011-06-22 Leo Liu <sdl.web@gmail.com>
4819 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4820 Move to minibuffer.el.
4822 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4824 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4825 The following patches are for when GLYPH_DEBUG && !XASSERT.
4826 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4827 * dispnew.c (flush_stdout):
4828 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4829 Mark as externally visible.
4830 * dispnew.c (check_window_matrix_pointers): Now static.
4831 * dispnew.c (window_to_frame_vpos):
4832 * xfns.c (unwind_create_frame):
4833 * xterm.c (x_check_font): Remove unused local.
4834 * scroll.c (CHECK_BOUNDS):
4835 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4836 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4837 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4838 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4839 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4841 (debug_method_add): Use va_list and vsprintf rather than relying
4842 on undefined behavior with wrong number of arguments.
4843 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4844 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4845 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4846 since we're not interested in debugging glyphs with old libraries.
4847 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4848 GCC 4.6.0's static checking.
4850 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4852 Integer overflow and signedness fixes (Bug#8873).
4853 A few related buffer overrun fixes, too.
4855 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4857 * dispextern.h (struct face.stipple):
4858 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4859 (x_bitmap_mask, x_allocate_bitmap_record)
4860 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4861 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4862 (x_create_bitmap_from_xpm_data):
4863 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4864 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4866 * xfaces.c (load_pixmap):
4867 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4868 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4869 (.bitmaps_last, struct x_output.icon_bitmap):
4870 Use ptrdiff_t, not int, for bitmap indexes.
4871 (x_allocate_bitmap_record): Check for size overflow.
4872 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4874 Use ptrdiff_t, not int, for overlay counts.
4875 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4876 * editfns.c (overlays_around, get_pos_property):
4877 * textprop.c (get_char_property_and_overlay):
4878 * xdisp.c (next_overlay_change, note_mouse_highlight):
4879 * xfaces.c (face_at_buffer_position):
4880 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4881 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4882 (Fnext_overlay_change, Fprevious_overlay_change)
4883 (mouse_face_overlay_overlaps, Foverlays_in):
4884 Use ptrdiff_t, not int, for sizes.
4885 (overlays_at, overlays_in): Check for size-calculation overflow.
4887 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4889 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4890 (x_session_initialize): Do not assume string length fits in int.
4892 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4893 This is unlikely, but can occur if DPI is outlandish.
4895 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4896 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4898 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4899 * xrdb.c (magic_file_p, search_magic_path):
4900 Omit last arg SUFFIX; it was always 0. All callers changed.
4901 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4903 * xfont.c (xfont_match): Avoid need for strlen.
4905 * xfns.c: Don't assume strlen fits in int.
4906 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4908 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4909 not unsigned long, as we prefer signed integers. All callers changed.
4910 Detect integer overflow in repeat count.
4911 (message_dolog): Don't assume print length fits in 39 bytes.
4912 (display_mode_element): Don't assume strlen fits in int.
4914 * termcap.c: Don't assume sizes fit in int and never overflow.
4915 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4916 (gobble_line): Check for size-calculation overflow.
4918 * minibuf.c (Fread_buffer):
4919 * lread.c (intern, intern_c_string):
4920 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4921 Don't assume string length fits in int.
4923 * keyboard.c (parse_tool_bar_item):
4924 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4926 * font.c: Don't assume string length fits in int.
4927 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4928 Use ptrdiff_t, not int.
4929 (font_intern_prop): Don't assume string length fits in int.
4930 Don't assume integer property fits in fixnum.
4931 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4933 * filelock.c: Fix some buffer overrun and integer overflow issues.
4934 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4935 Reformulate so as not to need the command string.
4936 Invoke gzip -cd rather than gunzip, as it's more portable.
4937 (lock_info_type, lock_file_1, lock_file):
4938 Don't assume pid_t and time_t fit in unsigned long.
4939 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4940 (current_lock_owner): Prefer signed type for sizes.
4941 Use memcpy, not strncpy, where memcpy is what is really wanted.
4942 Don't assume (via atoi) that time_t and pid_t fit in int.
4943 Check for time_t and/or pid_t out of range, e.g., via a network share.
4944 Don't alloca where an auto var works fine.
4946 * fileio.c: Fix some integer overflow issues.
4947 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4948 Don't assume string length fits in int.
4949 (directory_file_name): Don't assume string length fits in long.
4950 (make_temp_name): Don't assume pid fits in int, or that its print
4951 length is less than 20.
4953 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4955 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4957 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4959 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4960 We prefer signed integers, even for size calculations.
4962 * emacs.c: Don't assume string length fits in 'int'.
4963 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4964 (main): Don't invoke strlen when not needed.
4966 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4967 (XD_DEBUG_MESSAGE): Don't waste a byte.
4969 * callproc.c (getenv_internal_1, getenv_internal)
4971 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4973 * lread.c (invalid_syntax): Omit length argument.
4974 All uses changed. This doesn't fix a bug, but it simplifies the
4975 code away from its former Hollerith-constant appearance, and it's
4976 one less 'int' to worry about when looking at integer-overflow issues.
4977 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4979 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4980 This didn't break anything, but it didn't help either.
4981 It's confusing to put a bogus integer in a place where the actual
4982 value does not matter.
4983 (LIST_END_P): Remove unused macro and its bogus comment.
4984 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4986 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4987 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4989 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4990 We prefer signed types, and the value cannot exceed the EMACS_INT
4991 range anyway (because otherwise the length would not be representable).
4992 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4993 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4994 This avoids a GCC warning when WIDE_EMACS_INT.
4996 * indent.c (sane_tab_width): New function.
4997 (current_column, scan_for_column, Findent_to, position_indentation)
4998 (compute_motion): Use it. This is just for clarity.
4999 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5001 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5003 * lisp.h (lint_assume): New macro.
5004 * composite.c (composition_gstring_put_cache):
5005 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5007 * editfns.c, insdel.c:
5008 Omit unnecessary forward decls, to simplify future changes.
5010 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5012 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5014 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5015 Use much-faster test for byte-length change.
5016 Don't assume string byte-length fits in 'int'.
5017 Check that character arg fits in 'int'.
5018 (mapcar1): Declare byte as byte, for clarity.
5020 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5022 * fns.c (concat): Catch string overflow earlier.
5023 Do not rely on integer wraparound.
5025 * dispextern.h (struct it.overlay_strings_charpos)
5026 (struct it.selective): Now EMACS_INT, not int.
5027 * xdisp.c (forward_to_next_line_start)
5028 (back_to_previous_visible_line_start)
5029 (reseat_at_next_visible_line_start, next_element_from_buffer):
5030 Don't arbitrarily truncate the value of 'selective' to int.
5032 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5034 * composite.c: Don't truncate sizes to 'int'.
5035 (composition_gstring_p, composition_reseat_it)
5036 (composition_adjust_point): Use EMACS_INT, not int.
5037 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5038 not EMACS_UINT, for indexes.
5040 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5042 * buffer.c: Include <verify.h>.
5043 (struct sortvec.priority, struct sortstr.priority):
5044 Now EMACS_INT, not int.
5045 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5046 (struct sortstr.size, record_overlay_string)
5047 (struct sortstrlist.size, struct sortlist.used):
5048 Don't truncate size to int.
5049 (record_overlay_string): Check for size-calculation overflow.
5050 (init_buffer_once): Check at compile-time, not run-time.
5052 2011-06-22 Jim Meyering <meyering@redhat.com>
5054 Don't leak an XBM-image-sized buffer
5055 * image.c (xbm_load): Free the image buffer after using it.
5057 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5060 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5061 that Sun C diagnosed.
5062 * fns.c (secure_hash): Fix pointer signedness issue.
5063 * intervals.c (static_offset_intervals): New function.
5064 (offset_intervals): Use it.
5066 2011-06-21 Leo Liu <sdl.web@gmail.com>
5069 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5072 * fns.c (secure_hash): Rename from crypto_hash_function and change
5073 the first arg to accept symbols.
5074 (Fsecure_hash): New primitive.
5075 (syms_of_fns): New symbols.
5077 2011-06-20 Deniz Dogan <deniz@dogan.se>
5079 * process.c (Fset_process_buffer): Clarify return value in
5082 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5084 * dispnew.c (add_window_display_history): Use BVAR.
5086 * xdisp.c (debug_method_add): Use BVAR.
5087 (check_window_end, dump_glyph_matrix, dump_glyph)
5088 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5090 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5093 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5094 check till after the cache is created in init_frame_faces.
5096 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5098 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5100 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5102 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5103 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5104 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5106 Improve buffer-overflow checking (Bug#8873).
5107 * fileio.c (Finsert_file_contents):
5108 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5109 Remove the old (too-loose) buffer overflow checks.
5110 They weren't needed, since make_gap checks for buffer overflow.
5111 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5112 The old code merely checked for Emacs fixnum overflow, and relied
5113 on undefined (wraparound) behavior. The new code avoids undefined
5114 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5116 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5117 Tune. Don't use wider integers than needed. Don't use alloca.
5118 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5120 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5122 * insdel.c, lisp.h (buffer_overflow): New function.
5123 (insert_from_buffer_1, replace_range, replace_range_2):
5124 * insdel.c (make_gap_larger):
5125 * editfns.c (Finsert_char):
5126 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5128 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5130 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5132 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5134 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5135 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5137 * fileio.c: Don't assume EMACS_INT fits in off_t.
5138 (emacs_lseek): New static function.
5139 (Finsert_file_contents, Fwrite_region): Use it.
5140 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5142 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5144 * fns.c: Don't overflow int when computing a list length.
5145 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5146 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5147 truncation on 64-bit hosts. Check for QUIT every
5148 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5149 faster and is responsive enough.
5150 (Flength): Report an error instead of overflowing an integer.
5151 (Fsafe_length): Return a float if the value is not representable
5152 as a fixnum. This shouldn't happen except in contrived situations.
5153 (Fnthcdr, Fsort): Don't assume list length fits in int.
5154 (Fcopy_sequence): Don't assume vector length fits in int.
5156 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5157 (header_size, word_size): New constants.
5158 (allocate_vectorlike): Don't check size overflow here.
5159 (allocate_vector): Check it here instead, since this is the only
5160 caller of allocate_vectorlike that could cause overflow.
5161 Check that the new vector's length is representable as a fixnum.
5163 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5164 The previous code was bogus. For example, next_almost_prime (32)
5165 returned 39, which is undesirable as it is a multiple of 3; and
5166 next_almost_prime (24) returned 25, which is a multiple of 5 so
5167 why was the code bothering to check for multiples of 7?
5169 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5171 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5173 Variadic C functions now count arguments with ptrdiff_t.
5174 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5175 Back then I didn't know that the Emacs coding style prefers signed int.
5176 Also, in the meantime I found a few more instances where arguments
5177 were being counted with int, which may truncate counts on 64-bit
5178 machines, or EMACS_INT, which may be unnecessarily wide.
5179 * lisp.h (struct Lisp_Subr.function.aMANY)
5180 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5181 Arg counts are now ptrdiff_t, not size_t.
5182 All variadic functions and their callers changed accordingly.
5183 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5184 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5185 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5186 * callint.c (Fcall_interactively): Check arg count for overflow,
5187 to avoid potential buffer overrun. Use signed char, not 'int',
5188 for 'varies' array, so that we needn't bother to check its size
5189 calculation for overflow.
5190 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5191 * eval.c (apply_lambda):
5192 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5193 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5194 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5196 * callint.c (Fcall_interactively): Don't use index var as event count.
5198 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5199 * mem-limits.h (SIZE): Remove; no longer used.
5201 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5203 Remove unnecessary casts.
5204 * xterm.c (x_term_init):
5205 * xfns.c (x_set_border_pixel):
5206 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5207 These aren't needed now that we assume ANSI C.
5209 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5210 It's more likely to cause problems (due to unsigned overflow)
5213 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5215 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5217 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5219 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5221 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5223 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5225 GLYPH_CODE_FACE returns EMACS_INT, not int.
5226 * dispextern.h (merge_faces):
5227 * xfaces.c (merge_faces):
5228 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5229 Don't assume EMACS_INT fits in int.
5231 * character.h (CHAR_VALID_P): Remove unused parameter.
5232 * fontset.c, lisp.h, xdisp.c: All uses changed.
5234 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5236 * fns.c (concat): Minor tuning based on overflow analysis.
5237 This doesn't fix any bugs. Use int to hold character, instead
5238 of constantly refetching from Emacs object. Use XFASTINT, not
5239 XINT, for value known to be a character. Don't bother comparing
5240 a single byte to 0400, as it's always less.
5242 * floatfns.c (Fexpt):
5243 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5245 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5248 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5250 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5251 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5252 incorrectly succeed when S was a string, because 4294967386 was
5253 truncated before it was used.
5255 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5256 Otherwise, an out-of-range integer could cause undefined behavior
5259 * composite.c: Use int, not EMACS_INT, for characters.
5260 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5261 EMACS_INT, for values that are known to be in character range.
5262 This doesn't fix any bugs but is the usual style inside Emacs and
5263 may generate better code on 32-bit machines.
5265 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5266 This is for reasons similar to the recent CHAR_STRING fix.
5267 * charset.c (Fencode_char): Check that character arg is actually
5268 a character. Pass an int to ENCODE_CHAR.
5269 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5270 wider than 'int', as a compile-time check to prevent future regressions
5273 * character.c (char_string): Remove unnecessary casts.
5275 Make sure a 64-bit char is never passed to CHAR_STRING.
5276 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5277 by silently ignoring the top 32 bits, allowing some values
5278 that were far too large to be valid characters.
5279 * character.h: Include <verify.h>.
5280 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5281 arguments are no wider than unsigned, as a compile-time check
5282 to prevent future regressions in this area.
5284 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5285 (Fsubst_char_in_region):
5287 * xdisp.c (decode_mode_spec_coding):
5288 Adjust to CHAR_STRING's new requirement.
5289 * editfns.c (Finsert_char, Fsubst_char_in_region):
5290 * fns.c (concat): Check that character args are actually
5291 characters. Without this test, these functions did the wrong
5292 thing with wildly out-of-range values on 64-bit hosts.
5294 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5295 These casts should not be needed on 32-bit hosts, either.
5296 * keyboard.c (read_char):
5297 * lread.c (Fload): Remove casts to unsigned.
5299 * lisp.h (UNSIGNED_CMP): New macro.
5300 This fixes comparison bugs on 64-bit hosts.
5301 (ASCII_CHAR_P): Use it.
5302 * casefiddle.c (casify_object):
5303 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5304 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5305 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5306 * dispextern.h (FACE_FROM_ID):
5307 * keyboard.c (read_char): Use UNSIGNED_CMP.
5309 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5310 not to EMACS_INT, to avoid GCC warning.
5312 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5314 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5315 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5316 isn't needed on 32-bit machines.
5318 * buffer.c (Fgenerate_new_buffer_name):
5319 Use EMACS_INT for count, not int.
5320 (advance_to_char_boundary): Return EMACS_INT, not int.
5322 * data.c (Qcompiled_function): Now static.
5324 * window.c (window_body_lines): Now static.
5326 * image.c (gif_load): Rename local to avoid shadowing.
5328 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5329 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5330 * alloc.c (make_save_value): Integer argument is now of type
5332 (mark_object): Use ptrdiff_t, not int.
5333 * lisp.h (pD): New macro.
5334 * print.c (print_object): Use it.
5336 * alloc.c: Use EMACS_INT, not int, to count objects.
5337 (total_conses, total_markers, total_symbols, total_vector_size)
5338 (total_free_conses, total_free_markers, total_free_symbols)
5339 (total_free_floats, total_floats, total_free_intervals)
5340 (total_intervals, total_strings, total_free_strings):
5341 Now EMACS_INT, not int. All uses changed.
5342 (Fgarbage_collect): Compute overall total using a double, so that
5343 integer overflow is less likely to be a problem. Check for overflow
5344 when converting back to an integer.
5345 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5346 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5347 These were 'int' variables that could overflow on 64-bit hosts;
5348 they were never used, so remove them instead of repairing them.
5349 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5350 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5351 Previously, this ceilinged at INT_MAX, but that doesn't work on
5353 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5355 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5356 (allocate_vectorlike): Check for ptrdiff_t overflow.
5357 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5358 when a (possibly-narrower) signed value would do just as well.
5359 We prefer using signed arithmetic, to avoid comparison confusion.
5361 * alloc.c: Catch some string size overflows that we were missing.
5362 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5363 for convenience in STRING_BYTES_MAX.
5364 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5365 The definition here is exact; the one in lisp.h was approximate.
5366 (allocate_string_data): Check for string overflow. This catches
5367 some instances we weren't catching before. Also, it catches
5368 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5369 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5370 and ptrdiff_t and EMACS_INT are both 64 bits.
5372 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5373 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5374 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5376 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5378 * alloc.c (Fmake_string): Check for out-of-range init.
5380 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5382 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5384 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5386 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5387 xg_get_default_scrollbar_width.
5389 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5390 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5391 (style_changed_cb): Call update_theme_scrollbar_width and call
5392 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5393 all frames (Bug#8505).
5394 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5395 Call gtk_window_set_resizable if HAVE_GTK3.
5396 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5397 and height if HAVE_GTK3 (Bug#8505).
5398 (scroll_bar_width_for_theme): New variable.
5399 (update_theme_scrollbar_width): New function.
5400 (xg_get_default_scrollbar_width): Move code to
5401 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5402 (xg_initialize): Call update_theme_scrollbar_width.
5404 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5406 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5408 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5410 * frame.c (make_frame): Call other_buffer_safely instead of
5413 * window.c (temp_output_buffer_show): Call display_buffer with
5414 second argument Vtemp_buffer_show_specifiers and reset latter
5415 immediately after the call.
5416 (Vtemp_buffer_show_specifiers): New variable.
5417 (auto_window_vscroll_p, next_screen_context_lines)
5418 (Vscroll_preserve_screen_position): Remove leading asterisks from
5421 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5423 Fix minor problems found by GCC 4.6.0 static checking.
5424 * buffer.c (Qclone_number): Remove for now, as it's unused.
5425 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5426 (record_buffer): Remove unused local.
5427 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5428 (set_frame_buffer_list): Remove; unused.
5429 * frame.h (other_visible_frames): Remove decl.
5430 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5431 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5432 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5434 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5435 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5436 Define only if HAVE_GPM.
5437 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5438 (update_hints_inhibit): Remove; never set. All uses removed.
5439 * widgetprv.h (emacsFrameClassRec): Remove decl.
5440 * window.c (delete_deletable_window): Now returns void, since it
5441 wasn't returning anything.
5442 (compare_window_configurations): Remove unused locals.
5443 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5444 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5445 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5446 the same widths as pointers. This follows up on the 2011-05-06 patch.
5447 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5448 * xterm.h: Likewise.
5449 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5451 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5453 * makefile.w32-in: Update dependencies.
5454 (LISP_H): Add lib/intprops.h.
5456 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5458 * image.c (gif_load): Add animation frame delay to the metadata.
5459 (syms_of_image): Use DEFSYM. New symbol `delay'.
5461 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5463 * window.c (delete_deletable_window): Re-add.
5464 (Fset_window_configuration): Rewrite to handle dead buffers and
5465 consequently deletable windows.
5466 (window_tree, Fwindow_tree): Remove. Supply functionality in
5468 (compare_window_configurations): Simplify code.
5470 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5472 * image.c (imagemagick_load_image): Fix type mismatch.
5473 (Fimagemagick_types): Likewise.
5475 * window.h (replace_buffer_in_windows): Declare.
5477 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5479 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5480 Qclone_number. Remove external declaration of Qdelete_window.
5481 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5483 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5484 Run Qbuffer_list_update_hook if allowed.
5485 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5486 buffer list implementation.
5487 (other_buffer_safely): New function.
5488 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5489 calls to replace_buffer_in_windows and
5490 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5492 (record_buffer): Inhibit quitting and rewrite using quittable
5493 functions. Run Qbuffer_list_update_hook if allowed.
5494 (Frecord_buffer, Funrecord_buffer): New functions.
5495 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5496 Move switch-to-buffer to window.el.
5497 (bury-buffer): Move to window.el.
5498 (Vbuffer_list_update_hook): New variable.
5500 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5503 * window.h (resize_frame_windows): Move up in code.
5504 (Fwindow_frame): Remove EXFUN.
5505 (replace_buffer_in_all_windows): Remove prototype.
5506 (replace_buffer_in_windows_safely): Add prototype.
5508 * window.c: Declare Qdelete_window static again. Move down
5509 declaration of select_count.
5510 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5511 (Fother_window): Move to window.el.
5512 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5513 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5514 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5516 (replace_buffer_in_windows): Implement by calling
5517 Qreplace_buffer_in_windows.
5518 (replace_buffer_in_all_windows): Remove with some functionality
5519 moved into replace_buffer_in_windows_safely.
5520 (replace_buffer_in_windows_safely): New function.
5521 (select_window_norecord, select_frame_norecord): Move in front
5522 of run_window_configuration_change_hook. Remove now obsolete
5524 (Fset_window_buffer): Rewrite doc-string.
5525 Call Qrecord_window_buffer.
5526 (keys_of_window): Move binding for other-window to window.el.
5528 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5530 * dispextern.h (struct image): Replace data member, whose int_val
5531 and ptr_val fields were not used by anything, with a single
5534 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5535 (gif_clear_image, gif_load, imagemagick_load_image)
5536 (gs_clear_image, gs_load): Callers changed.
5538 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5540 * buffer.h: Include <time.h>, for time_t.
5541 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5543 Fix minor problems found by static checking.
5545 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5547 Make identifiers static if they are not used in other modules.
5548 * data.c (Qcompiled_function, Qframe, Qvector):
5549 * image.c (QimageMagick, Qsvg):
5550 * minibuf.c (Qmetadata):
5551 * window.c (resize_window_check, resize_root_window): Now static.
5552 * window.h (resize_window_check, resize_root_window): Remove decls.
5554 * window.c (window_deletion_count, delete_deletable_window):
5556 (window_body_lines): Now static.
5557 (Fdelete_other_windows_internal): Mark vars as initialized.
5558 Make sure 'resize_failed' is initialized.
5559 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5560 (resize_window_apply): Remove unused local.
5561 * window.h (delete_deletable_window): Remove decl.
5563 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5564 (imagemagick_load_image): Fix pointer signedness problem by changing
5565 last arg from unsigned char * to char *. All uses changed.
5566 Also, fix a local for similar reasons.
5567 Remove unused locals. Remove locals to avoid shadowing.
5568 (fn_rsvg_handle_free): Remove; unused.
5569 (svg_load, svg_load_image): Fix pointer signedness problem.
5570 (imagemagick_load_image): Don't use garbage pointer image_wand.
5572 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5574 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5576 * image.c (gif_load): Fix omitted cast error introduced by
5579 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5581 * window.h (resize_proportionally, orig_total_lines)
5582 (orig_top_line): Remove from window structure.
5583 (set_window_height, set_window_width, change_window_heights)
5584 (Fdelete_window): Remove prototypes.
5585 (resize_frame_windows): Remove duplicate declaration.
5587 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5589 * window.h (resize_frame_windows, resize_window_check)
5590 (delete_deletable_window, resize_root_window)
5591 (resize_frame_windows): Declare prototypes.
5593 * window.c (resize_window_apply): Make definition be "static" to
5594 match the prototype.
5596 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5598 * window.c: Remove declarations of Qwindow_size_fixed,
5599 window_min_size_1, window_min_size_2, window_min_size,
5600 size_window, window_fixed_size_p, enlarge_window, delete_window.
5601 Remove static from declaration of Qdelete_window, it's
5602 temporarily needed by Fbury_buffer.
5603 (replace_window): Don't assign orig_top_line and
5605 (Fdelete_window, delete_window): Remove. Window deletion is
5606 handled by window.el.
5607 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5608 Replace Fdelete_window calls with calls to Qdelete_window.
5609 (Fdelete_other_windows): Remove. Deleting other windows is
5610 handled by window.el.
5611 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5612 handled in window.el.
5613 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5614 Window minimum sizes are handled in window.el.
5615 (shrink_windows, size_window, set_window_height)
5616 (set_window_width, change_window_heights, window_height)
5617 (window_width, CURBEG, CURSIZE, enlarge_window)
5618 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5619 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5620 handled in window.el.
5621 (make_dummy_parent): Rename to make_parent_window and give it a
5622 second argument horflag.
5623 (make_window): Don't set resize_proportionally any more.
5624 (Fsplit_window): Remove. Windows are split in window.el.
5625 (save_restore_action, save_restore_orig_size)
5626 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5627 Resize mini windows in window.el.
5628 (grow_mini_window, shrink_mini_window): Implement by calling
5629 Qresize_root_window_vertically, resize_window_check and
5630 resize_window_apply.
5631 (saved_window, Fset_window_configuration, save_window_save):
5632 Do not handle orig_top_line, orig_total_lines, and
5633 resize_proportionally.
5634 (window_min_height, window_min_width): Move to window.el.
5635 (keys_of_window): Move bindings for delete-other-windows,
5636 split-window, delete-window and enlarge-window to window.el.
5638 * buffer.c: Temporarily extern Qdelete_window.
5639 (Fbury_buffer): Temporarily call Qdelete_window instead of
5640 Fdelete_window (Fbury_buffer will move to window.el soon).
5642 * frame.c (set_menu_bar_lines_1): Remove code handling
5643 orig_top_line and orig_total_lines.
5645 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5646 set_window_height but set heights directly.
5647 (change_frame_size_1): Use resize_frame_windows.
5649 * xdisp.c (init_xdisp): Don't use set_window_height but set
5652 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5653 Use resize_frame_windows instead of change_window_heights and run
5654 run_window_configuration_change_hook.
5656 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5657 instead of change_window_heights and run
5658 run_window_configuration_change_hook.
5660 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5662 * window.c (replace_window): Rename second argument REPLACEMENT to
5663 NEW. New third argument SETFLAG. Rewrite.
5664 (delete_window, make_dummy_parent): Call replace_window with
5666 (window_list_1): Move down in code.
5667 (run_window_configuration_change_hook): Move set_buffer part
5668 before select_frame_norecord part in order to unwind correctly.
5669 Rename count1 to count.
5670 (recombine_windows, delete_deletable_window, resize_root_window)
5671 (Fdelete_other_windows_internal)
5672 (Frun_window_configuration_change_hook, make_parent_window)
5673 (resize_window_check, resize_window_apply, Fresize_window_apply)
5674 (resize_frame_windows, Fsplit_window_internal)
5675 (Fdelete_window_internal, Fresize_mini_window_internal):
5677 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5679 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5681 * window.h (window): Add some new members to window structure -
5682 normal_lines, normal_cols, new_total, new_normal, clone_number,
5683 splits, nest, prev_buffers, next_buffers.
5684 (WINDOW_TOTAL_SIZE): Move here from window.c.
5685 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5687 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5689 (make_dummy_parent): Set new members of windows structure.
5690 (make_window): Move down in code. Handle new members of window
5692 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5693 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5694 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5695 (Fset_window_prev_buffers, Fwindow_next_buffers)
5696 (Fset_window_next_buffers, Fset_window_clone_number):
5698 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5699 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5701 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5702 Argument WINDOW can be now internal window too.
5703 (Fwindow_use_time): Move up in code.
5704 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5706 (Fset_window_configuration, saved_window)
5707 (Fcurrent_window_configuration, save_window_save): Handle new
5708 members of window structure.
5709 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5710 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5711 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5712 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5713 Qget_mru_window, Qresize_root_window,
5714 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5715 Qauto_buffer_name; staticpro them.
5717 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5719 * window.c (Fwindow_total_size, Fwindow_left_column)
5720 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5721 (Fwindow_list_1): New functions.
5722 (window_box_text_cols): Replace with window_body_cols.
5723 (Fwindow_width, Fscroll_left, Fscroll_right):
5724 Use window_body_cols instead of window_box_text_cols.
5725 (delete_window, Fset_window_configuration):
5726 Call delete_all_subwindows with window as argument.
5727 (delete_all_subwindows): Take a window as argument and not a
5729 (window_loop): Remove handling of GET_LRU_WINDOW and
5731 (Fget_lru_window, Fget_largest_window): Move to window.el.
5733 * window.h: Extern window_body_cols instead of
5734 window_box_text_cols. delete_all_subwindows now takes a
5735 Lisp_Object as argument.
5737 * indent.c (compute_motion, Fcompute_motion):
5738 Use window_body_cols instead of window_box_text_cols.
5740 * frame.c (delete_frame): Call delete_all_subwindows with root
5743 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5745 * fns.c (Fputhash): Document return value.
5747 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5749 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5751 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5753 Cons<->int and similar integer overflow fixes (Bug#8794).
5755 Check for overflow when converting integer to cons and back.
5756 * charset.c (Fdefine_charset_internal, Fdecode_char):
5757 Use cons_to_unsigned to catch overflow.
5758 (Fencode_char): Use INTEGER_TO_CONS.
5759 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5760 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5761 * data.c (long_to_cons, cons_to_long): Remove.
5762 (cons_to_unsigned, cons_to_signed): New functions.
5763 These signal an error for invalid or out-of-range values.
5764 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5765 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5766 * font.c (Ffont_variation_glyphs):
5767 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5768 * lisp.h: Include <intprops.h>.
5769 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5770 (cons_to_signed, cons_to_unsigned): New decls.
5771 (long_to_cons, cons_to_long): Remove decls.
5772 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5773 (Fprimitive_undo): Use CONS_TO_INTEGER.
5774 * xfns.c (Fx_window_property): Likewise.
5775 * xselect.c: Include <limits.h>.
5776 (x_own_selection, selection_data_to_lisp_data):
5777 Use INTEGER_TO_CONS.
5778 (x_handle_selection_request, x_handle_selection_clear)
5779 (x_get_foreign_selection, Fx_disown_selection_internal)
5780 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5781 (lisp_data_to_selection_data): Use cons_to_unsigned.
5782 (x_fill_property_data): Use cons_to_signed.
5783 Report values out of range.
5785 Check for buffer and string overflow more precisely.
5786 * buffer.h (BUF_BYTES_MAX): New macro.
5787 * lisp.h (STRING_BYTES_MAX): New macro.
5788 * alloc.c (Fmake_string):
5789 * character.c (string_escape_byte8):
5790 * coding.c (coding_alloc_by_realloc):
5791 * doprnt.c (doprnt):
5792 * editfns.c (Fformat):
5794 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5795 since they may not be the same number.
5796 * editfns.c (Finsert_char):
5797 * fileio.c (Finsert_file_contents):
5798 Likewise for BUF_BYTES_MAX.
5800 * image.c: Use ptrdiff_t, not int, for sizes.
5801 (slurp_file): Switch from int to ptrdiff_t.
5803 (slurp_file): Check that file size fits in both size_t (for
5804 malloc) and ptrdiff_t (for sanity and safety).
5806 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5807 if b->modtime has its maximal value.
5809 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5811 Don't assume time_t can fit into int.
5812 * buffer.h (struct buffer.modtime): Now time_t, not int.
5813 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5814 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5816 Minor fixes for signed vs unsigned integers.
5817 * character.h (MAYBE_UNIFY_CHAR):
5818 * charset.c (maybe_unify_char):
5819 * keyboard.c (read_char, reorder_modifiers):
5820 XINT -> XFASTINT, since the integer must be nonnegative.
5821 * ftfont.c (ftfont_spec_pattern):
5822 * keymap.c (access_keymap, silly_event_symbol_error):
5823 XUINT -> XFASTINT, since the integer must be nonnegative.
5824 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5825 since it makes no difference and we prefer signed.
5826 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5827 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5830 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5832 * window.h (Fwindow_frame): Declare.
5834 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5836 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5837 (SPARE_MEMORY): Always define.
5838 (LARGE_REQUEST): Remove.
5839 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5841 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5843 * lisp.h: Move EXFUNS for Fframe_root_window,
5844 Fframe_first_window and Fset_frame_selected_window to window.h.
5846 * window.h: Move EXFUNS for Fframe_root_window,
5847 Fframe_first_window and Fset_frame_selected_window here from
5850 * frame.c (Fwindow_frame, Fframe_first_window)
5851 (Fframe_root_window, Fframe_selected_window)
5852 (Fset_frame_selected_window): Move to window.c.
5853 (Factive_minibuffer_window): Move to minibuf.c.
5854 (Fother_visible_frames_p): New function.
5856 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5858 * window.c (decode_window, decode_any_window): Move up in code.
5859 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5860 (inhibit_frame_unsplittable): Remove unused variable.
5861 (Fwindow_buffer): Move up and rewrite doc-string.
5862 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5863 (Fwindow_prev): New functions.
5864 (Fwindow_frame): Move here from frame.c. Accept any window as
5866 (Fframe_root_window, Fframe_first_window)
5867 (Fframe_selected_window): Move here from frame.c. Accept frame
5868 or arbitrary window as argument. Update doc-strings.
5869 (Fminibuffer_window): Move up in code.
5870 (Fwindow_minibuffer_p): Move up in code and simplify.
5871 (Fset_frame_selected_window): Move here from frame.c.
5873 (Fselected_window, select_window, Fselect_window): Move up in
5874 code. Minor doc-string fixes.
5876 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5878 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5879 Do not assume that spare memory exists; that assumption is valid
5880 only if SYSTEM_MALLOC.
5881 (LARGE_REQUEST): New macro, so that the issue of large requests
5882 is separated from the issue of spare memory.
5884 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5886 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5889 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5891 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5894 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5896 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5898 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5900 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5901 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5903 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5905 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5907 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5909 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5910 (x_clipboard_manager_save): Add return value.
5911 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5913 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5914 Obey Vx_select_enable_clipboard_manager. Catch errors in
5915 x_clipboard_manager_save (Bug#8779).
5916 (Vx_select_enable_clipboard_manager): New variable.
5917 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5919 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5921 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5923 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5925 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5926 in the current matrix if keep_current_p is non-zero.
5928 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5930 * bidi.c (bidi_level_of_next_char): Fix last change.
5932 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5934 Support bidi reordering of text covered by display properties.
5936 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5937 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5938 (bidi_cache_search, bidi_cache_iterator_state)
5939 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5940 (bidi_level_of_next_char, bidi_move_to_visually_next):
5941 Support character positions inside a run of characters covered by a
5943 (bidi_paragraph_init, bidi_resolve_explicit_1)
5944 (bidi_level_of_next_char): Call bidi_fetch_char and
5945 bidi_fetch_char_advance instead of FETCH_CHAR and
5947 (bidi_init_it): Initialize new members.
5948 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5950 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5951 instead of using explicit *_CHAR codes.
5952 (bidi_resolve_explicit, bidi_resolve_weak):
5953 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5954 bidirectional text is supported only in multibyte buffers.
5955 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5956 it to initialize the frame_window_p member of struct bidi_it.
5957 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5958 (bidi_resolve_explicit, bidi_resolve_weak)
5959 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5960 bidi_it->nchars is non-positive.
5961 (bidi_level_of_next_char): Don't try to lookup the cache for the
5962 next/previous character if nothing is cached there yet, or if we
5963 were just reseat()'ed to a new position.
5965 * xdisp.c (set_cursor_from_row): Set start and stop points
5966 according to the row's direction when priming the loop that looks
5967 for the glyph on which to display cursor.
5968 (single_display_spec_intangible_p): Function deleted.
5969 (display_prop_intangible_p): Reimplement to call
5970 handle_display_spec instead of single_display_spec_intangible_p.
5971 Accept 3 additional arguments needed by handle_display_spec.
5972 This fixes incorrect cursor motion across display property with complex
5973 values: lists, `(when COND...)' forms, etc.
5974 (single_display_spec_string_p): Support property values that are
5975 lists with the argument STRING its top-level element.
5976 (display_prop_string_p): Fix the condition for processing a
5977 property that is a list to be consistent with handle_display_spec.
5978 (handle_display_spec): New function, refactored from the
5979 last portion of handle_display_prop.
5980 (compute_display_string_pos): Accept additional argument
5981 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5982 value of a `display' property is a "replacing spec".
5983 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5984 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5985 the display property, but just return a value indicating whether
5986 the display property will replace the characters it covers.
5987 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5988 frame_window_p members of struct bidi_it.
5989 (compute_display_string_pos, compute_display_string_end):
5991 (push_it): Accept second argument POSITION, where pop_it should
5992 jump to continue iteration.
5993 (reseat_1): Initialize bidi_it.disp_pos.
5995 * keyboard.c (adjust_point_for_property): Adjust the call to
5996 display_prop_intangible_p to its new signature.
5998 * dispextern.h (struct bidi_it): New member frame_window_p.
5999 (bidi_init_it): Update prototypes.
6000 (display_prop_intangible_p): Update prototype.
6001 (compute_display_string_pos, compute_display_string_end):
6003 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6006 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6008 Malloc failure behavior now depends on size of allocation.
6009 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6010 * lisp.h: Change signatures accordingly.
6011 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6012 All callers changed. (Bug#8762)
6014 * gnutls.c: Use Emacs's memory allocators.
6015 Without this change, the gnutls library would invoke malloc etc.
6016 directly, which causes problems on non-SYNC_INPUT hosts, and which
6017 runs afoul of improving memory_full behavior. (Bug#8761)
6018 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6019 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6020 xfree instead of the default malloc, realloc, free.
6021 (Fgnutls_boot): No need to check for memory allocation failure,
6022 since xmalloc does that for us.
6024 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6025 * category.c (hash_get_category_set):
6026 * ccl.c (ccl_driver):
6027 * charset.c (Fdefine_charset_internal):
6028 * charset.h (struct charset.hash_index):
6029 * composite.c (get_composition_id, gstring_lookup_cache)
6030 (composition_gstring_put_cache):
6031 * composite.h (struct composition.hash_index):
6032 * dispextern.h (struct image.hash):
6033 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6034 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6035 (hashfn_equal, hashfn_user_defined, make_hash_table)
6036 (maybe_resize_hash_table, hash_lookup, hash_put)
6037 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6038 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6039 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6040 * image.c (make_image, search_image_cache, lookup_image)
6041 (xpm_put_color_table_h):
6042 * lisp.h (struct Lisp_Hash_Table):
6043 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6044 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6045 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6046 * alloc.c (allocate_vectorlike):
6047 Check for overflow in vector size calculations.
6048 * ccl.c (ccl_driver):
6049 Check for overflow when converting EMACS_INT to int.
6050 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6051 need to be updated by these changes.
6052 * fns.c (make_hash_table, maybe_resize_hash_table):
6053 Check for integer overflow with large hash tables.
6054 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6055 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6056 (SXHASH_REDUCE): New macro.
6057 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6058 Use it instead of discarding useful hash info with large hash values.
6059 (sxhash_float): New function.
6060 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6061 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6062 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6063 Rewrite to use FIXNUM_BITS, as this simplifies things.
6064 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6065 Adjust signatures to match updated version of code.
6066 (consing_since_gc): Now EMACS_INT, since a single hash table can
6067 use more than INT_MAX bytes.
6069 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6071 Make it possible to build with GCC-4.6+ -O2 -flto.
6073 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6075 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6077 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6078 Call minibuffer-inactive-mode.
6080 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6082 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6083 Update dependencies.
6085 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6087 * data.c (init_data): Remove code for UTS, this system is not
6090 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6092 Don't force ./temacs to start in terminal mode.
6094 * frame.c (make_initial_frame): Initialize faces in all cases, not
6095 only when CANNOT_DUMP is defined.
6096 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6098 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6100 * dispnew.c (add_window_display_history): Use const for the string
6101 pointer. Remove declaration, not needed.
6103 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6105 Use 'inline', not 'INLINE'.
6106 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6107 * alloc.c, fontset.c (INLINE): Remove.
6108 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6109 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6110 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6111 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6112 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6114 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6116 Make it possible to run ./temacs.
6118 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6119 syms_of_callproc does the same thing. Remove test for
6120 "initialized", do it in the caller.
6121 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6123 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6125 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6126 (read_minibuf): Use get_minibuffer.
6127 (syms_of_minibuf): Use DEFSYM.
6128 (Qmetadata): New var.
6129 * data.c (Qbuffer): Don't make it static.
6130 (syms_of_data): Use DEFSYM.
6132 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6134 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6135 (CCL_CODE_MIN): New macro.
6137 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6139 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6141 * eval.c (Qdebug): Now static.
6142 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6143 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6144 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6146 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6148 * image.c: Various fixes to ImageMagick code comments.
6149 (Fimagemagick_types): Doc fix.
6151 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6153 Minor fixes prompted by GCC 4.6.0 warnings.
6155 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6157 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6158 (x_clipboard_manager_save_all): Move extern decl to ...
6159 * xterm.h: ... here, so that it can be checked for consistency.
6161 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6163 * xselect.c (x_clipboard_manager_save_frame)
6164 (x_clipboard_manager_save_all): New functions.
6165 (Fx_clipboard_manager_save): Lisp function deleted.
6167 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6168 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6170 * xterm.h: Update prototype.
6172 2011-05-28 William Xu <william.xwl@gmail.com>
6174 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6177 2011-05-28 Jim Meyering <meyering@redhat.com>
6179 Avoid a sign-extension bug in crypto_hash_function.
6180 * fns.c (to_uchar): Define.
6181 (crypto_hash_function): Use it to convert some newly-signed
6182 variables to unsigned, to avoid sign-extension bugs. For example,
6183 without this change, (md5 "truc") would evaluate to
6184 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6185 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6186 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6188 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6190 Integer overflow fixes.
6192 * dbusbind.c: Serial number integer overflow fixes.
6193 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6194 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6195 to hold a serial number that is too large for a fixnum.
6196 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6197 Check for serial numbers out of range. Decode any serial number
6198 that was so large that it became a float. (Bug#8722)
6200 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6201 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6202 Use XFASTINT rather than XUINT when numbers are nonnegative.
6203 (xd_append_arg, Fdbus_method_return_internal):
6204 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6205 arguments, check that Lisp number is nonnegative, rather than
6206 silently wrapping negative numbers around. (Bug#8722)
6207 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6210 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6212 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6214 ccl: Add integer overflow checks.
6215 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6216 (IN_INT_RANGE): New macros.
6217 (ccl_driver): Use them to check for integer overflow when
6218 decoding a CCL program. Many of the new checks are whether XINT (x)
6219 fits in int; it doesn't always, on 64-bit hosts. The new version
6220 doesn't catch all possible integer overflows, but it's an
6221 improvement. (Bug#8719)
6223 * alloc.c (make_event_array): Use XINT, not XUINT.
6224 There's no need for unsigned here.
6226 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6227 This follows up to the 2011-05-06 change that substituted uintptr_t
6228 for EMACS_INT. This case wasn't caught back then.
6230 Rework Fformat to avoid integer overflow issues.
6231 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6232 now (part of C89). Include <verify.h>.
6233 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6234 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6235 (Fformat): Avoid the prepass trying to compute sizes; it was only
6236 approximate and thus did not catch overflow reliably. Instead, walk
6237 through the format just once, formatting and computing sizes as we go,
6238 checking for integer overflow at every step, and allocating a larger
6239 buffer as needed. Keep track separately whether the format is
6240 multibyte. Keep only the most-recently calculated precision, rather
6241 than them all. Record whether each argument has been converted to
6242 string. Use EMACS_INT, not int, for byte and char and arg counts.
6243 Support field widths and precisions larger than INT_MAX. Avoid
6244 sprintf's undefined behavior with conversion specifications such as %#d
6245 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6246 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6247 formatting out-of-range floating point numbers with int
6250 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6252 * data.c: Avoid integer truncation in expressions involving floats.
6253 * data.c: Include <intprops.h>.
6254 (arith_driver): When there's an integer overflow in an expression
6255 involving floating point, convert the integers to floating point
6256 so that the resulting value does not suffer from catastrophic
6257 integer truncation. For example, on a 64-bit host (* 4
6258 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6259 Do not rely on undefined behavior after integer overflow.
6261 merge count_size_as_multibyte, parse_str_to_multibyte
6262 * character.c, character.h (count_size_as_multibyte):
6263 Rename from parse_str_to_multibyte; all uses changed.
6264 Check for integer overflow.
6265 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6266 since it's now a duplicate of the other. This is more of
6267 a character than a buffer op, so better that it's in character.c.
6268 * fns.c, print.c: Adjust to above changes.
6270 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6272 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6274 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6276 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6277 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6278 (x_clipboard_manager_save): Now static.
6279 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6281 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6282 (crypto_hash_function): Now static.
6283 Fix pointer signedness problems. Avoid unnecessary initializations.
6285 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6287 * termhooks.h (Vselection_alist): Make it terminal-local.
6289 * terminal.c (create_terminal): Initialize it.
6291 * xselect.c: Support for clipboard managers.
6292 (Vselection_alist): Move to termhooks.h as terminal-local var.
6293 (LOCAL_SELECTION): New macro.
6294 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6295 (symbol_to_x_atom): Remove gratuitous arg.
6296 (x_handle_selection_request, lisp_data_to_selection_data)
6297 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6298 (x_own_selection, x_get_local_selection, x_convert_selection):
6299 New arg, specifying work frame. Use terminal-local Vselection_alist.
6300 (some_frame_on_display): Delete unused function.
6301 (Fx_own_selection_internal, Fx_get_selection_internal)
6302 (Fx_disown_selection_internal, Fx_selection_owner_p)
6303 (Fx_selection_exists_p): New optional frame arg.
6304 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6305 (x_handle_selection_clear): Don't treat other terminals with the
6306 same keyboard specially. Use the terminal-local Vselection_alist.
6307 (x_clear_frame_selections): Use Frun_hook_with_args.
6309 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6311 * xterm.h: Add support for those atoms.
6313 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6315 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6316 (converted_selections, conversion_fail_tag): New global variables.
6317 (x_selection_request_lisp_error): Free the above.
6318 (x_get_local_selection): Remove unnecessary code.
6319 (x_reply_selection_request): Args changed; handle arbitrary array
6320 of converted selections stored in converted_selections.
6321 Separate the XChangeProperty and SelectionNotify steps.
6322 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6323 (x_convert_selection): New function.
6324 (x_handle_selection_event): Simplify.
6325 (x_get_foreign_selection): Don't ignore incoming requests while
6326 waiting for an answer; this will fail when we implement
6327 SAVE_TARGETS, and seems unnecessary anyway.
6328 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6329 (Vx_sent_selection_functions): Doc fix.
6331 2011-05-26 Leo Liu <sdl.web@gmail.com>
6333 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6335 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6337 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6339 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6340 for fringe update if it has periodic bitmap.
6341 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6342 and fringe_bitmap_periodic_p.
6344 * fringe.c (get_fringe_bitmap_data): New function.
6345 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6346 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6347 row. Mark glyph row for fringe update if periodicity changed.
6349 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6350 for fringe update unless it has periodic bitmap.
6352 2011-05-25 Kenichi Handa <handa@m17n.org>
6354 * xdisp.c (get_next_display_element): Set correct it->face_id for
6355 a static composition.
6357 2011-05-24 Leo Liu <sdl.web@gmail.com>
6360 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6362 * fns.c (crypto_hash_function, Fsha1): New function.
6363 (Fmd5): Use crypto_hash_function.
6364 (syms_of_fns): Add Ssha1.
6366 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6368 * gnutls.c: Remove unused macros.
6369 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6370 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6371 Remove macros that are defined and never used.
6372 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6374 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6376 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6377 (Fx_get_selection_internal): Minor cleanup.
6378 (Fx_own_selection_internal): Rename arguments for consistency with
6381 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6383 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6385 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6387 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6389 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6391 * dispnew.c (scrolling_window): Don't exclude the case that the
6392 last enabled row in the desired matrix touches the bottom boundary.
6394 2011-05-21 Glenn Morris <rgm@gnu.org>
6396 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6397 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6398 and add some more files.
6400 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6402 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6403 report_file_error introduced by the change from 2011-05-07.
6405 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6407 * systime.h (Time): Define only if emacs is defined.
6408 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6409 where the include path doesn't have X11/X.h by default. See
6410 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6412 2011-05-20 Kenichi Handa <handa@m17n.org>
6414 * composite.c (find_automatic_composition): Fix previous change.
6416 2011-05-20 Glenn Morris <rgm@gnu.org>
6418 * lisp.mk: New file, split from Makefile.in.
6419 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6420 (shortlisp): Remove.
6421 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6423 2011-05-19 Glenn Morris <rgm@gnu.org>
6425 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6426 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6427 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6428 (lisp): Set the order to that of loadup.el.
6429 (shortlisp): Make it a copy of $lisp.
6430 (SOME_MACHINE_LISP): Remove.
6431 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6432 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6434 2011-05-18 Kenichi Handa <handa@m17n.org>
6436 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6437 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6438 (find_automatic_composition): Mostly rewrite for efficiency.
6440 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6442 * makefile.w32-in: Update dependencies.
6444 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6446 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6447 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6449 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6451 Fix some integer overflow issues, such as string length overflow.
6453 * insdel.c (count_size_as_multibyte): Check for string overflow.
6455 * character.c (lisp_string_width): Check for string overflow.
6456 Use EMACS_INT, not int, for string indexes and lengths; in
6457 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6458 the resulting string length overflows an EMACS_INT; instead,
6459 report a string overflow if no precision given. When checking for
6460 precision exhaustion, use a check that cannot possibly have
6461 integer overflow. (Bug#8675)
6462 * character.h (lisp_string_width): Adjust to new signature.
6464 * alloc.c (string_overflow): New function.
6465 (Fmake_string): Use it. This doesn't change behavior, but saves
6466 a few bytes and will simplify future changes.
6467 * character.c (string_escape_byte8): Likewise.
6468 * lisp.h (string_overflow): New decl.
6470 Fixups, following up to the user-interface timestamp change.
6471 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6472 for UI timestamps, instead of unsigned long.
6473 * msdos.c (mouse_get_pos): Likewise.
6474 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6475 * w32gui.h (Time): Define by including "systime.h" rather than by
6476 declaring it ourselves. (Bug#8664)
6478 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6479 * image.c (clear_image_cache): Likewise.
6481 * term.c (term_mouse_position): Don't assume time_t wraparound.
6483 Be more systematic about user-interface timestamps.
6484 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6485 and sometimes 'EMACS_UINT', to represent these timestamps.
6486 This change causes it to use 'Time' uniformly, as that's what X uses.
6487 This makes the code easier to follow, and makes it easier to catch
6488 integer overflow bugs such as Bug#8664.
6489 * frame.c (Fmouse_position, Fmouse_pixel_position):
6490 Use Time, not unsigned long, for user-interface timestamps.
6491 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6492 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6493 * keyboard.h (last_event_timestamp): Likewise.
6494 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6495 * menu.h (xmenu_show): Likewise.
6496 * term.c (term_mouse_position): Likewise.
6497 * termhooks.h (struct input_event.timestamp): Likewise.
6498 (struct terminal.mouse_position_hook): Likewise.
6499 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6500 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6501 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6502 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6504 * menu.h, termhooks.h: Include "systime.h", for Time.
6506 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6507 Don't assume that the difference between two unsigned long values
6508 can fit into an integer. At this point, we know button_down_time
6509 <= event->timestamp, so the difference must be nonnegative, so
6510 there's no need to cast the result if double-click-time is
6511 nonnegative, as it should be; check that it's nonnegative, just in
6512 case. This bug is triggered when events are more than 2**31 ms
6513 apart (about 25 days). (Bug#8664)
6515 * xselect.c (last_event_timestamp): Remove duplicate decl.
6516 (x_own_selection): Remove needless cast to unsigned long.
6518 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6519 that always fit in int. Use a sentinel instead of a counter, to
6520 avoid a temp and to allay GCC's concerns about possible int overflow.
6521 * frame.h (struct frame): Use int for menu_bar_items_used
6522 instead of EMACS_INT, since it always fits in int.
6524 * menu.c (grow_menu_items): Check for int overflow.
6526 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6528 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6529 Before, the code was not consistent. These values cannot exceed
6530 2**31 - 1 so there's no need to make them unsigned.
6531 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6532 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6533 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6535 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6537 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6538 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6539 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6540 presumably because the widths might not match.
6542 * window.c (size_window): Avoid needless test at loop start.
6544 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6546 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6548 2011-05-12 Drew Adams <drew.adams@oracle.com>
6550 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6552 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6554 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6555 `width' to `bar_area_x' and `bar_area_width', respectively.
6556 (x_scroll_run): Take account of fringe background extension.
6558 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6559 Rename local vars `left' and `width' to `bar_area_x' and
6560 `bar_area_width', respectively.
6561 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6562 background extension.
6564 2011-05-10 Jim Meyering <meyering@redhat.com>
6566 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6568 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6570 * image.c (Finit_image_library): Return t for built-in image types,
6571 like pbm and xbm. (Bug#8640)
6573 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6575 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6577 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6579 * w32console.c (Fset_screen_color): Doc fix.
6580 (Fget_screen_color): New function.
6581 (syms_of_ntterm): Defsubr it.
6583 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6584 unlink the temporary file if Fcall_process didn't create it in the
6586 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6587 child process will be redirected to a file specified with `:file'.
6588 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6589 cue to call_process_cleanup not to close that handle.
6591 2011-05-07 Ben Key <bkey76@gmail.com>
6593 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6594 one of two shell specific rules, either bootstrap-temacs-CMD or
6595 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6596 to the previous implementation of the bootstrap-temacs rule.
6597 The bootstrap-temacs-CMD rule is similar to the previous
6598 implementation of the bootstrap-temacs rule except that it
6599 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6602 These changes, along with some changes to nt/configure.bat,
6603 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6604 earlier fix to add support for --cflags and --ldflags options
6605 that include quotes so that it works whether make uses cmd or
6608 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6610 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6611 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6613 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6614 a string. Handle both cases.
6615 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6616 (Fdbus_register_method): Use Qinvalid_function.
6618 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6620 * makefile.w32-in: Update dependencies.
6621 (LISP_H): Add inttypes.h and stdin.h.
6622 (PROCESS_H): Add unistd.h.
6624 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6626 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6627 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6629 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6631 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6633 * term.c (vfatal): Remove stray call to va_end.
6634 It's not needed and the C Standard doesn't allow it here anyway.
6636 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6637 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6639 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6642 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6644 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6646 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6648 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6650 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6652 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6653 * charset.c (Fdefine_charset_internal): Don't initialize
6654 charset.code_space[15]. The value was garbage, on hosts with
6655 32-bit int (Bug#8600).
6657 * lread.c (read_integer): Be more consistent with string-to-number.
6658 Use string_to_number to do the actual conversion; this avoids
6659 rounding errors and fixes some other screwups. Without this fix,
6660 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6661 (digit_to_number): Move earlier, for benefit of read_integer.
6662 Return -1 if the digit is out of range for the base, -2 if it is
6663 not a digit in any supported base. (Bug#8602)
6665 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6667 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6668 to match comment at start of function. This also removes a
6669 GCC warning about overflow in a 32+64-bit port.
6671 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6673 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6674 Reported by Stefan Monnier in
6675 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6676 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6677 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6679 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6680 (EMACS_UINTPTR): Likewise, with uintptr_t.
6682 * lisp.h: Prefer 64-bit EMACS_INT if available.
6683 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6684 on 32-bit hosts that have 64-bit int, so that they can access
6686 However, temporarily disable this change unless the temporary
6687 symbol WIDE_EMACS_INT is defined.
6689 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6691 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6692 This removes an assumption that EMACS_INT and long are the same
6693 width as pointers. The assumption is true for Emacs porting targets
6694 now, but we want to make other targets possible.
6695 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6696 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6697 In the rest of the code, change types of integers that hold casted
6698 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6699 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6700 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6701 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6702 No need to cast type when ORing.
6703 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6704 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6705 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6706 assume EMACS_INT is the same width as char *.
6707 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6708 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6709 Remove no-longer-needed casts.
6710 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6711 (xg_tool_bar_help_callback, xg_make_tool_item):
6712 Use EMACS_INTPTR to hold an integer
6713 that will be cast to void *; this can avoid a GCC warning
6714 if EMACS_INT is not the same width as void *.
6715 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6716 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6717 (current_message_1, set_message_1):
6718 Use a local to convert to proper width without a cast.
6719 * xmenu.c (dialog_selection_callback): Likewise.
6721 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6722 Also, don't assume VALBITS / RAND_BITS is less than 5,
6723 and don't rely on undefined behavior when shifting a 1 left into
6725 * lisp.h (get_random): Change signature to match.
6727 * lread.c (hash_string): Use size_t, not int, for hash computation.
6728 Normally we prefer signed values; but hashing is special, because
6729 it's better to use unsigned division on hash table sizes so that
6730 the remainder is nonnegative. Also, size_t is the natural width
6731 for hashing into memory. The previous code used 'int', which doesn't
6732 retain enough info to hash well into very large tables.
6733 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6735 * dbusbind.c: Don't possibly lose pointer info when converting.
6736 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6737 Use XPNTR rather than XHASH, so that the high-order bits of
6738 the pointer aren't lost when converting through void *.
6740 * eval.c (Fautoload): Don't double-shift a pointer.
6742 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6744 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6746 * gnutls.c (DEF_GNUTLS_FN):
6747 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6749 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6751 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6754 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6756 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6757 New version that can reserve upto 2GB of heap space.
6759 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6761 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6763 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6765 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6766 `gnutls_certificate_set_x509_key_file'.
6768 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6770 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6771 Update dependencies.
6773 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6775 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6776 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6777 Remove unused parameter `fildes'.
6778 * process.c (read_process_output, send_process): Don't pass it.
6780 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6782 Fix previous change: the library cache is defined in w32.c.
6783 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6784 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6786 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6788 Implement dynamic loading of GnuTLS on Windows.
6790 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6791 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6792 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6795 * gnutls.c (Qgnutls_dll): Define.
6796 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6797 (gnutls_*): Declare function pointers.
6798 (init_gnutls_functions): New function to initialize function pointers.
6799 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6800 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6801 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6802 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6803 (emacs_gnutls_write, emacs_gnutls_read)
6804 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6805 (Fgnutls_available_p): New function.
6806 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6807 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6808 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6810 * image.c: Include w32.h.
6811 (Vimage_type_cache): Delete.
6812 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6813 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6814 (w32_delayed_load): Move to w32.c.
6816 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6818 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6819 (w32_delayed_load): Move from image.c. When loading a library, record
6820 its filename in the :loaded-from property of the library id.
6821 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6822 Initialize and staticpro them.
6823 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6825 * process.c: Include lisp.h before w32.h, not after.
6826 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6827 instead of gnutls_record_check_pending.
6829 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6831 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6833 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6834 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6837 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6839 * xterm.c (x_set_frame_alpha): Do not set property on anything
6840 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6842 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6844 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6846 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6848 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6849 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6850 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6851 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6852 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6853 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6854 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6855 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6856 (Qgnutls_bootprop_callbacks_verify): Make static.
6858 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6860 * callproc.c: Indentation fixup.
6862 * sysdep.c (wait_for_termination_1): Make static.
6863 (wait_for_termination, interruptible_wait_for_termination):
6864 Move after wait_for_termination_1.
6866 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6868 * sysdep.c (interruptible_wait_for_termination): New function
6869 which is like wait_for_termination, but allows keyboard
6872 * callproc.c (Fcall_process): Add (:file "file") as an option for
6874 (Fcall_process_region): Ditto.
6876 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6878 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6879 rather than `XVECTOR (FOO)->size'.
6881 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6882 inttypes.h, as a gnulib replacement is used if it not available in
6885 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6887 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6888 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6889 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6891 * coding.c (coding_alloc_by_realloc): Error out if destination
6892 will grow beyond MOST_POSITIVE_FIXNUM.
6893 (decode_coding_emacs_mule): Abort if there isn't enough place in
6894 charbuf for the composition carryover bytes. Reserve an extra
6895 space for up to 2 characters produced in a loop.
6896 (decode_coding_iso_2022): Abort if there isn't enough place in
6897 charbuf for the composition carryover bytes.
6899 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6901 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6902 aborting when %lld or %lll format is passed.
6903 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6904 %llo or %llx format is passed. (Bug#8545)
6906 * window.c (window_scroll_line_based): Use a marker instead of
6907 simple variables to record original value of point. (Bug#7952)
6909 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6910 produced by %s or %c overflows available buffer space. (Bug#8545)
6912 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6914 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6915 (SIZE_MAX): Move defn after all includes, as they might #define it.
6917 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6919 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6921 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6923 * keyboard.c (Qdelayed_warnings_hook): Define.
6924 (command_loop_1): Run `delayed-warnings-hook'
6925 if Vdelayed_warnings_list is non-nil.
6926 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6927 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6929 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6931 * doprnt.c (doprnt): Don't return value smaller than the buffer
6932 size if the message was truncated. (Bug#8545).
6934 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6936 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6937 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6939 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6941 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6943 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6945 * makefile.w32-in: Update dependencies.
6947 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6949 Improve `doprnt' and its usage. (Bug#8545)
6950 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6951 `format_end'. Remove support for %l as a conversion specifier.
6952 Don't use xrealloc. Improve diagnostics when the %l size modifier
6953 is used. Update the commentary.
6955 * eval.c (verror): Simplify calculation of size_t.
6957 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6960 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6962 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6965 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6967 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6968 This makes this file independent of the recent pseudovector change.
6970 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6972 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6974 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6975 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6976 Remove unused local.
6977 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6979 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6980 GCC 4.6.0 optimizes based on type-based alias analysis.
6981 For example, if b is of type struct buffer * and v of type struct
6982 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6983 != &v->size, and therefore "v->size = 1; b->size = 2; return
6984 v->size;" must therefore return 1. This assumption is incorrect
6985 for Emacs, since it type-puns struct Lisp_Vector * with many other
6986 types. To fix this problem, this patch adds a new type struct
6987 vectorlike_header that documents the constraints on layout of vectors
6988 and pseudovectors, and helps optimizing compilers not get fooled
6989 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6990 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6991 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6993 (XSETPVECTYPE): Rewrite in terms of new macro.
6994 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6995 This is a bit clearer, and further avoids the possibility of
6996 undesirable aliasing.
6997 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6998 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6999 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7000 since Lisp_Subr is a special case (no "next" field).
7001 (ASIZE): Now uses header.size rather than size.
7002 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7003 to avoid the hassle of writing XVECTOR (foo)->header.size.
7004 (struct vectorlike_header): New type.
7005 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7006 object, to help avoid aliasing.
7007 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7008 (SUBRP): Likewise, since Lisp_Subr is a special case.
7009 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7010 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7011 (struct Lisp_Hash_Table): Combine first two members into a single
7012 struct vectorlike_header member. All uses of "size" and "next" members
7013 changed to be "header.size" and "header.next".
7014 * buffer.h (struct buffer): Likewise.
7015 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7016 * frame.h (struct frame): Likewise.
7017 * process.h (struct Lisp_Process): Likewise.
7018 * termhooks.h (struct terminal): Likewise.
7019 * window.c (struct save_window_data, struct saved_window): Likewise.
7020 * window.h (struct window): Likewise.
7021 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7022 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7023 * buffer.c (init_buffer_once): Likewise.
7024 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7026 * process.c (Fformat_network_address): Use local var for size,
7029 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7031 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7032 * data.c (atof): Remove decl; no longer used or needed.
7033 (digit_to_number): Move to lread.c.
7034 (Fstring_to_number): Use new string_to_number function, to be
7035 consistent with how the Lisp reader treats infinities and NaNs.
7036 Do not assume that floating-point numbers represent EMACS_INT
7037 without losing information; this is not true on most 64-bit hosts.
7038 Avoid double-rounding errors, by insisting on integers when
7039 parsing non-base-10 numbers, as the documentation specifies.
7040 * lisp.h (string_to_number): New decl, replacing ...
7041 (isfloat_string): Remove.
7042 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7043 (read1): Do not accept +. and -. as integers; this
7044 appears to have been a coding error. Similarly, do not accept
7045 strings like +-1e0 as floating point numbers. Do not report
7046 overflow for integer overflows unless the base is not 10 which
7047 means we have no simple and reliable way to continue.
7048 Break out the floating-point parsing into a new
7049 function string_to_number, so that Fstring_to_number parses
7050 floating point numbers consistently with the Lisp reader.
7051 (digit_to_number): Move here from data.c. Make it static inline.
7052 (E_CHAR, EXP_INT): Remove, replacing with ...
7053 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7054 (string_to_number): New function, replacing isfloat_string.
7055 This function checks for valid syntax and produces the resulting
7056 Lisp float number too. Rework it so that string-to-number
7057 no longer mishandles examples like "1.0e+". Use strtoumax,
7058 so that overflow for non-base-10 numbers is reported only when
7059 there's no portable and simple way to convert to floating point.
7061 * textprop.c (set_text_properties_1): Rewrite for clarity,
7062 and to avoid GCC warning about integer overflow.
7064 * intervals.h (struct interval): Use EMACS_INT for members
7065 where EMACS_UINT might cause problems. See
7066 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7067 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7068 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7070 (offset_intervals): Tell GCC not to worry about length overflow
7071 when negating a negative length.
7073 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7074 (overrun_check_free): Likewise.
7076 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7077 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7080 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7081 (gnutls_make_error): Rename local to avoid shadowing.
7082 (gnutls_emacs_global_deinit): ifdef out; not used.
7083 (Fgnutls_boot): Use const for pointer to readonly storage.
7084 Comment out unused local. Fix pointer signedness problems.
7086 * lread.c (openp): Don't stuff size_t into an 'int'.
7087 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7088 about possible signed overflow.
7090 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7091 (GDK_KEY_g): Don't define if already defined.
7092 (xg_prepare_tooltip): Avoid pointer signedness problem.
7093 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7095 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7096 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7098 * xfns.c (Fx_window_property): Simplify a bit,
7099 to make a bit faster and to avoid GCC 4.6.0 warning.
7100 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7102 * fns.c (internal_equal): Don't assume size_t fits in int.
7104 * alloc.c (compact_small_strings): Tighten assertion a little.
7106 Replace pEd with more-general pI, and fix some printf arg casts.
7107 * lisp.h (pI): New macro, generalizing old pEd macro to other
7108 conversion specifiers. For example, use "...%"pI"d..." rather
7109 than "...%"pEd"...".
7110 (pEd): Remove. All uses replaced with similar uses of pI.
7111 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7112 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7113 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7114 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7115 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7116 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7117 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7119 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7120 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7121 * print.c (safe_debug_print, print_object): Likewise.
7122 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7124 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7125 avoiding the 0 flag, which is not portable.
7126 * process.c (Fmake_network_process): Use pI to avoid cast.
7127 * region-cache.c (pp_cache): Likewise.
7128 * xdisp.c (decode_mode_spec): Likewise.
7129 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7130 behavior on 64-bit hosts with printf arg.
7131 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7132 (x_stop_queuing_selection_requests): Likewise.
7133 (x_get_window_property): Don't truncate byte count to an 'int'
7136 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7137 here, since it parses constructs like leading '-' and spaces,
7138 which are not wanted; and it overflows with large numbers.
7139 Instead, simply match F[0-9]+, which is what is wanted anyway.
7141 * alloc.c: Remove unportable assumptions about struct layout.
7142 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7143 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7144 (allocate_vectorlike, make_pure_vector): Use the new macros,
7145 plus offsetof, to remove unportable assumptions about struct layout.
7146 These assumptions hold on all porting targets that I know of, but
7147 they are not guaranteed, they're easy to remove, and removing them
7148 makes further changes easier.
7150 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7151 This doesn't fix a bug but makes the code clearer.
7152 (string_overrun_cookie): Now const. Use initializers that
7153 don't formally overflow signed char, to avoid warnings.
7154 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7155 can cause Emacs to crash when string overrun checking is enabled.
7156 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7157 multiple of sizeof (EMACS_INT); it need not be, if
7158 alignof(EMACS_INT) < sizeof (EMACS_INT).
7159 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7161 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7163 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7165 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7167 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7168 supposed to be handshaking. (Bug#8556)
7169 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7171 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7173 * lisp.h (Qdebug): List symbol.
7174 * eval.c (Qdebug): Restore global linkage.
7175 * keyboard.c (debug-on-event): New variable.
7176 (handle_user_signal): Break into debugger when debug-on-event
7177 matches the current signal symbol.
7179 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7181 * alloc.c (check_sblock, check_string_bytes)
7182 (check_string_free_list): Convert to standard C.
7184 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7186 * w32.c (emacs_gnutls_push): Fix typo.
7188 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7190 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7191 "cast to pointer from integer of different size".
7193 Improve doprnt and its use in verror. (Bug#8545)
7194 * doprnt.c (doprnt): Document the set of format control sequences
7195 supported by the function. Use SAFE_ALLOCA instead of always
7198 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7199 is one byte too soon. Don't use xrealloc; instead xfree and
7202 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7204 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7207 * gnutls.c: Renamed global_initialized to
7208 gnutls_global_initialized. Added internals for the
7209 :verify-hostname-error, :verify-error, and :verify-flags
7210 parameters of `gnutls-boot' and documented those parameters in the
7211 docstring. Start callback support.
7212 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7213 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7214 on error. Return error code.
7215 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7216 (emacs_gnutls_read): Likewise.
7217 (Fgnutls_boot): Return handshake error code.
7218 (emacs_gnutls_handle_error): New function.
7219 (wsaerror_to_errno): Likewise.
7221 * w32.h (emacs_gnutls_pull): Add prototype.
7222 (emacs_gnutls_push): Likewise.
7224 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7225 (emacs_gnutls_push): Likewise.
7227 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7229 * process.c (wait_reading_process_output): Check if GnuTLS
7230 buffered some data internally if no FDs are set for TLS
7233 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7234 (LIBS): Link to USER_LIBS.
7235 ($(BLD)/gnutls.$(0)): New target.
7237 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7239 * xdisp.c (handle_single_display_spec): Rename the
7240 display_replaced_before_p argument into display_replaced_p, to
7241 make it consistent with the commentary. Fix typos in the
7244 * textprop.c (syms_of_textprop): Remove dead code.
7245 (copy_text_properties): Delete obsolete commentary about an
7246 interface that was deleted long ago. Fix typos in the description
7249 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7250 to changes in oldXMenu/XMenu.h from 2011-04-16.
7251 <menu_help_message, prev_menu_help_message>: Constify.
7252 (IT_menu_make_room): menu->help_text is now `const char **';
7255 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7256 to changes in oldXMenu/XMenu.h from 2011-04-16.
7257 (struct XMenu): Declare `help_text' `const char **'.
7259 * xfaces.c <Qunspecified>: Make extern again.
7261 * syntax.c: Include sys/types.h before including regex.h, as
7264 * doc.c (get_doc_string): Improve the format passed to `error'.
7266 * doprnt.c (doprnt): Improve commentary.
7268 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7270 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7273 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7274 changes in globals.h immediately force recompilation.
7275 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7276 $(CURDIR)/s/ms-w32.h.
7277 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7279 * character.c (Fchar_direction): Function deleted.
7280 (syms_of_character): Don't defsubr it.
7281 <char-direction-table>: Deleted.
7283 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7285 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7286 * doprnt.c: Include limits.h.
7287 (SIZE_MAX): New macro.
7288 (doprnt): Return a size_t value. 2nd arg is now size_t.
7289 Many local variables are now size_t instead of int or unsigned.
7290 Improve overflow protection. Support `l' modifier for integer
7291 conversions. Support %l conversion. Don't assume an EMACS_INT
7292 argument for integer conversions and for %c.
7294 * lisp.h (doprnt): Restore prototype.
7296 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7299 * Makefile.in (base_obj): Add back doprnt.o.
7301 * deps.mk (doprnt.o): Add back prerequisites.
7302 (callint.o): Depend on character.h.
7304 * eval.c (internal_lisp_condition_case): Include the handler
7305 representation in the error message.
7306 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7307 when breaking from the loop.
7309 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7311 * callint.c (Fcall_interactively): When displaying error message
7312 about invalid control letter, pass the character's codepoint, not
7313 a pointer to its multibyte form. Improve display of the character
7314 in octal and display also its hex code.
7316 * character.c (char_string): Use %x to display the (unsigned)
7317 codepoint of an invalid character, to avoid displaying a bogus
7320 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7321 `error', not SYMBOL_NAME itself.
7323 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7324 character arguments to `error'.
7326 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7327 to `error' in error message about FINAL_CHAR argument. Make sure
7328 FINAL_CHAR is a character, and use %c when it is passed as
7329 argument to `error'.
7331 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7333 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7335 * w32.c: Include <time.h>.
7336 (sys_localtime): New function.
7338 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7340 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7342 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7344 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7346 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7349 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7351 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7352 gl_state.e_property when gl_state.object is Qt.
7354 * insdel.c (make_gap_larger): Remove limitation of buffer size
7357 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7359 * xdisp.c (lookup_glyphless_char_display)
7360 (produce_glyphless_glyph): Handle cons cell entry in
7361 glyphless-char-display.
7362 (Vglyphless_char_display): Document it.
7364 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7365 glyphless-char-display.
7367 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7369 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7371 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7373 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7374 definition for no-X builds.
7376 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7378 Static checks with GCC 4.6.0 and non-default toolkits.
7380 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7382 * process.c (keyboard_bit_set): Define only if SIGIO.
7383 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7384 (send_process): Repair possible setjmp clobbering.
7386 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7388 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7390 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7392 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7393 Define only if needed.
7395 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7396 by pacifying GCC about it. Maybe it's time to retire it?
7397 * xfaces.c (USG, __TIMEVAL__): Likewise.
7399 * dispextern.h (struct redisplay_interface): Rename param
7401 * termhooks.h (struct terminal): Likewise.
7402 * xterm.c (xembed_send_message): Likewise.
7404 * insdel.c (make_gap_smaller): Define only if
7405 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7407 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7410 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7411 so that we aren't warned about unused symbols.
7413 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7415 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7417 * xfns.c (x_real_positions): Mark locals as initialized.
7419 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7421 * xterm.c: Fix problems found by static analysis with other toolkits.
7422 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7423 (x_dispatch_event): Declare static if USE_GTK, and
7424 define if USE_GTK || USE_X_TOOLKIT.
7425 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7426 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7427 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7428 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7430 * xmenu.c (menu_help_callback): Pointer type fixes.
7431 Use const pointers when pointing at readonly data. Avoid pointer
7433 (FALSE): Remove unused macro.
7434 (update_frame_menubar): Remove unused decl.
7436 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7438 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7439 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7440 (single_menu_item): Rename local to avoid shadowing.
7442 * keyboard.c (make_lispy_event): Remove unused local var.
7444 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7445 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7447 * bitmaps: Change bitmaps from unsigned char back to the X11
7448 compatible char. Avoid the old compiler warnings about
7449 out-of-range initializers by using, for example, '\xab' rather
7452 * xgselect.c (xgselect_initialize): Check vs interface
7453 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7455 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7457 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7458 to read-only memory.
7460 * fns.c (vector): Remove; this old hack is no longer needed.
7462 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7464 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7466 * xrdb.c (x_load_resources): Omit unused local.
7468 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7469 (x_window): Rename locals to avoid shadowing.
7470 (USG): Use the kludged USG macro, to pacify gcc.
7472 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7473 (x_term_init): Remove local to avoid shadowing.
7475 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7477 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7478 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7480 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7482 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7484 Fix regex.c, syntax.c and friends for buffers > 2GB.
7485 * syntax.h (struct gl_state_s): Declare character position members
7488 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7490 * textprop.c (verify_interval_modification, interval_of):
7491 Declare arguments EMACS_INT.
7493 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7496 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7498 * indent.c (Fvertical_motion): Local variable it_start is now
7501 * regex.c (re_match, re_match_2, re_match_2_internal)
7502 (bcmp_translate, regcomp, regexec, print_double_string)
7503 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7504 (re_compile_pattern, re_exec): Declare arguments and local
7505 variables `size_t' and `ssize_t' and return values `regoff_t', as
7507 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7508 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7509 <compile_stack_type>: `size' and `avail' are now `size_t'.
7511 * regex.h <regoff_t>: Use ssize_t, not int.
7512 (re_search, re_search_2, re_match, re_match_2): Arguments that
7513 specify buffer/string position and length are now ssize_t and
7514 size_t. Return type is regoff_t.
7516 2011-04-16 Ben Key <bkey76@gmail.com>
7518 * nsfont.m: Fixed bugs in ns_get_family and
7519 ns_descriptor_to_entity that were caused by using free to
7520 deallocate memory blocks that were allocated by xmalloc (via
7521 xstrdup). This caused Emacs to crash when compiled with
7522 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7523 --enable-checking=xmallocoverrun). xfree is now used to
7524 deallocate these memory blocks.
7526 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7528 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7530 emacs_write: Accept and return EMACS_INT for sizes.
7531 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7533 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7534 Accept and return EMACS_INT.
7535 (emacs_gnutls_write): Return the number of bytes written on
7537 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7538 (emacs_read, emacs_write): Remove check for negative size, as the
7539 Emacs source code has been audited now.
7540 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7541 (emacs_read, emacs_write): Use it.
7542 * process.c (send_process): Adjust to the new signatures of
7543 emacs_write and emacs_gnutls_write. Do not attempt to store
7544 a byte offset into an 'int'; it might overflow.
7545 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7547 * sound.c: Don't assume sizes fit in 'int'.
7548 (struct sound_device.period_size, alsa_period_size):
7549 Return EMACS_INT, not int.
7550 (struct sound_device.write, vox_write, alsa_write):
7551 Accept EMACS_INT, not int.
7552 (wav_play, au_play): Use EMACS_INT to store sizes and to
7553 record read return values.
7555 2011-04-15 Ben Key <bkey76@gmail.com>
7557 * keyboard.c (Qundefined): Don't declare static since it is used
7559 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7560 static since they are used in nsfont.m.
7562 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7564 * process.c (Qprocessp): Don't declare static.
7565 * lisp.h (Qprocessp): Declare again.
7567 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7569 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7571 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7573 Improve C-level modularity by making more things 'static'.
7575 Don't publish debugger-only interfaces to other modules.
7576 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7577 (verify_bytepos, count_markers): Move decls to the only modules
7579 * region-cache.h (pp_cache): Likewise.
7580 * window.h (check_all_windows): Likewise.
7581 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7583 * sysdep.c (croak): Now static, if
7584 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7585 * syssignal.h (croak): Declare only if not static.
7587 * alloc.c (refill_memory_reserve): Now static if
7588 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7589 * lisp.h (refill_memory_reserve): Declare only if not static.
7591 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7592 Define only if USE_LUCID.
7594 * xrdb.c (x_customization_string, x_rm_string): Now static.
7596 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7597 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7599 * xdisp.c (draw_row_with_mouse_face): Now static.
7600 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7602 * window.h (check_all_windows): Mark externally visible.
7604 * window.c (window_deletion_count): Now static.
7606 * undo.c: Make symbols static if they're not exported.
7607 (last_undo_buffer, last_boundary_position, pending_boundary):
7610 * textprop.c (interval_insert_behind_hooks): Now static.
7611 (interval_insert_in_front_hooks): Likewise.
7613 * term.c: Make symbols static if they're not exported.
7614 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7615 (max_frame_lines, tty_set_terminal_modes):
7616 (tty_reset_terminal_modes, tty_turn_off_highlight):
7617 (get_tty_terminal): Now static.
7618 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7619 * termhooks.h (term_mouse_moveto): Do not declare if
7621 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7622 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7624 * sysdep.c: Make symbols static if they're not exported.
7625 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7627 (sigprocmask_set, full_mask): Remove; unused.
7628 (wait_debugging): Mark as visible.
7629 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7630 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7632 * syntax.c (syntax_temp): Define only if !__GNUC__.
7634 * sound.c (current_sound_device, current_sound): Now static.
7636 * search.c (searchbufs, searchbuf_head): Now static.
7638 * scroll.c (scroll_cost): Remove; unused.
7639 * dispextern.h (scroll_cost): Remove decl.
7641 * region-cache.h (pp_cache): Mark as externally visible.
7643 * process.c: Make symbols static if they're not exported.
7644 (process_tick, update_tick, create_process, chan_process):
7645 (Vprocess_alist, proc_buffered_char, datagram_access):
7646 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7647 (deactivate_process): Mark defn as static, as well as decl.
7648 * lisp.h (create_process): Remove decl.
7649 * process.h (chan_process, Vprocess_alist): Remove decls.
7651 * print.c: Make symbols static if they're not exported.
7652 (print_depth, new_backquote_output, being_printed, print_buffer):
7653 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7654 (print_interval, print_number_index, initial_stderr_stream):
7656 * lisp.h (Fprinc): Remove decl.
7657 (debug_output_compilation_hack): Mark as externally visible.
7659 * sysdep.c (croak): Move decl from here to syssignal.h.
7660 * syssignal.h (croak): Put it here, so the API can be checked when
7661 'croak' is called from dissociate_if_controlling_tty.
7663 * minibuf.c: Make symbols static if they're not exported.
7664 (minibuf_save_list, choose_minibuf_frame): Now static.
7665 * lisp.h (choose_minibuf_frame): Remove decl.
7667 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7669 * lread.c: Make symbols static if they're not exported.
7670 (read_objects, initial_obarray, oblookup_last_bucket_number):
7672 (make_symbol): Remove; unused.
7673 * lisp.h (initial_obarray, make_symbol): Remove decls.
7675 * keyboard.c: Make symbols static if they're not exported.
7676 (single_kboard, recent_keys_index, total_keys, recent_keys):
7677 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7678 (this_single_command_key_start, echoing, last_auto_save):
7679 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7680 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7681 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7682 (Vlispy_mouse_stem, double_click_count):
7684 (force_auto_save_soon): Define only if SIGDANGER.
7685 (ignore_mouse_drag_p): Now static if
7686 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7687 (print_help): Remove; unused.
7688 (stop_character, last_timer_event): Mark as externally visible.
7689 * keyboard.h (ignore_mouse_drag_p): Declare only if
7690 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7691 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7692 * lisp.h (echoing): Remove decl.
7693 (force_auto_save_soon): Declare only if SIGDANGER.
7694 * xdisp.c (redisplay_window): Simplify code, to make it more
7695 obvious that ignore_mouse_drag_p is not accessed if !defined
7696 USE_GTK && !defined HAVE_NS.
7698 * intervals.c: Make symbols static if they're not exported.
7699 (merge_properties_sticky, merge_interval_right, delete_interval):
7701 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7703 * insdel.c: Make symbols static if they're not exported.
7704 However, leave prepare_to_modify_buffer alone. It's never
7705 called from outside this function, but that appears to be a bug.
7706 (combine_after_change_list, combine_after_change_buffer):
7707 (adjust_after_replace, signal_before_change): Now static.
7708 (adjust_after_replace_noundo): Remove; unused.
7709 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7710 (signal_before_change): Remove decls.
7712 * indent.c (val_compute_motion, val_vmotion): Now static.
7714 * image.c: Make symbols static if they're not exported.
7715 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7717 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7718 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7720 * fringe.c (standard_bitmaps): Now static.
7721 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7723 * frame.c: Make symbols static if they're not exported.
7724 (x_report_frame_params, make_terminal_frame): Now static.
7725 (get_frame_param): Now static, unless HAVE_NS.
7726 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7727 (x_get_resource_string): Remove; not used.
7728 * frame.h (make_terminal_frame, x_report_frame_params):
7729 (x_get_resource_string); Remove decls.
7730 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7731 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7733 * font.c, fontset.c: Make symbols static if they're not exported.
7734 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7735 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7736 * font.c (font_close_object): Now static.
7737 * font.h (font_close_object): Remove.
7738 * fontset.c (FONTSET_OBJLIST): Remove.
7739 (free_realized_fontset) #if-0 the body, which does nothing.
7740 (face_suitable_for_char_p): #if-0, as it's never called.
7741 * fontset.h (face_suitable_for_char_p): Remove decl.
7742 * xfaces.c (face_at_string_position):
7743 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7744 since 0 is always ASCII.
7746 * fns.c (weak_hash_tables): Now static.
7748 * fileio.c: Make symbols static if they're not exported.
7749 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7750 (Vwrite_region_annotation_buffers): Now static.
7752 * eval.c: Make symbols static if they're not exported.
7753 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7754 * lisp.h (backtrace_list): Remove decl.
7756 * emacs.c: Make symbols static if they're not exported.
7757 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7758 (fatal_error_code, fatal_error_signal_hook, standard_args):
7760 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7761 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7762 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7763 * lisp.h (fatal_error_signal_hook): Remove decl.
7764 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7766 * editfns.c: Move a (normally-unused) function to its only use.
7767 * editfns.c, lisp.h (get_operating_system_release): Remove.
7768 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7769 worth the hassle of breaking this out.
7771 * xterm.c: Make symbols static if they're not exported.
7772 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7773 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7774 (x_destroy_window, x_delete_display):
7776 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7777 (x_mouse_leave): Remove; unused.
7778 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7779 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7780 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7782 (x_mouse_leave): Declare only if WINDOWSNT.
7783 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7784 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7787 * ftxfont.c: Make symbols static if they're not exported.
7788 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7790 * font.h (ftxfont_driver): Likewise.
7792 * xfns.c: Make symbols static if they're not exported.
7793 (x_last_font_name, x_display_info_for_name):
7794 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7795 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7796 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7797 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7798 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7799 (last_show_tip_args): Now static.
7800 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7801 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7802 (x_screen_planes): Remove; unused.
7803 * dispextern.h (x_screen_planes): Remove decl.
7805 * dispnew.c: Make symbols static if they're not exported.
7806 * dispextern.h (redraw_garbaged_frames, scrolling):
7807 (increment_row_positions): Remove.
7808 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7809 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7811 (redraw_garbaged_frames): Remove; unused.
7813 * xfaces.c: Make symbols static if they're not exported.
7814 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7816 * xterm.h (defined_color): Remove decls.
7817 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7818 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7819 (menu_face_changed_default, defined_color, free_realized_face):
7820 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7821 (ascii_face_of_lisp_face): Remove; unused.
7823 * xdisp.c: Make symbols static if they're not exported.
7824 * dispextern.h (scratch_glyph_row, window_box_edges):
7825 (glyph_to_pixel_coords, set_cursor_from_row):
7826 (get_next_display_element, set_iterator_to_next):
7827 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7828 (show_mouse_face): Remove decls
7829 * frame.h (message_buf_print): Likewise.
7830 * lisp.h (pop_message, set_message, check_point_in_composition):
7832 * xterm.h (set_vertical_scroll_bar): Likewise.
7833 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7834 (message_buf_print, scratch_glyph_row, displayed_buffer):
7835 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7836 (get_next_display_element, show_mouse_face, window_box_edges):
7837 (frame_to_window_pixel_xy, check_point_in_composition):
7838 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7839 (glyph_to_pixel_coords): Remove; unused.
7841 * dired.c (file_name_completion): Now static.
7843 * dbusbind.c (xd_in_read_queued_messages): Now static.
7845 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7846 * data.c (circular_list_error): Remove.
7848 * commands.h (last_point_position, last_point_position_buffer):
7849 (last_point_position_window): Remove decls.
7850 * keyboard.c: Make these variables static.
7852 * coding.h (coding, code_convert_region, encode_coding_gap):
7854 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7855 (iso_code_class, detect_coding, code_convert_region): Now static.
7856 (encode_coding_gap): Remove; unused.
7858 * chartab.c (chartab_chars, chartab_bits): Now static.
7860 * charset.h (charset_iso_8859_1): Remove decl.
7861 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7864 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7865 * ccl.c (Vccl_program_table): Now static.
7866 (check_ccl_update): Remove; unused.
7868 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7869 * category.h: ... from here.
7870 * category.c (check_category_table, set_category_set): Now static.
7872 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7873 * lisp.h: Remove these decls.
7875 * buffer.c (buffer_count): Remove unused var.
7877 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7878 so that it's not optimized away.
7879 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7880 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7881 exported only to the debugger.
7883 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7884 * atimer.h (run_all_atimers): Remove; not exported.
7886 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7887 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7888 was inaccessible from Lisp.
7889 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7890 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7892 alloc.c: Import and export fewer symbols, and remove unused items.
7893 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7895 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7896 it's not optimized away by whole-program optimization.
7897 (message_enable_multibyte, free_misc): Remove.
7898 (catchlist, handlerlist, mark_backtrace):
7899 Declare only if BYTE_MARK_STACK.
7900 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7901 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7902 (message_enable_multibyte): Remove decl.
7903 (free_misc, interval_free_list, float_block, float_block_index):
7904 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7905 (cons_free_list, last_marked_index):
7907 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7908 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7909 (mark_backtrace): Define only if BYTE_MARK_STACK.
7910 * xdisp.c (message_enable_multibyte): Now static.
7912 Declare Lisp_Object Q* variables to be 'static' if not exported.
7913 This makes it easier for human readers (and static analyzers)
7914 to see whether these variables are used from other modules.
7915 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7916 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7917 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7918 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7919 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7920 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7921 * xmenu.c, xselect.c:
7922 Declare Q* vars static if they are not used in other modules.
7923 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7924 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7925 Remove decls of unexported vars.
7926 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7928 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7930 Make Emacs functions such as Fatom 'static' by default.
7931 This makes it easier for human readers (and static analyzers)
7932 to see whether these functions can be called from other modules.
7933 DEFUN now defines a static function. To make the function external
7934 so that it can be used in other C modules, use the new macro DEFUE.
7935 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7936 (Finit_image_library):
7937 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7938 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7939 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7940 Remove decls, since these functions are now static.
7941 (Funintern, Fget_internal_run_time): New decls, since these functions
7942 were already external.
7944 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7945 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7946 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7947 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7948 * keyboard.c, keymap.c, lread.c:
7949 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7950 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7951 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7952 Mark functions with DEFUE instead of DEFUN,
7953 if they are used in other modules.
7954 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7955 decls for now-static functions.
7956 * buffer.h (Fdelete_overlay): Remove decl.
7957 * callproc.c (Fgetenv_internal): Mark as internal.
7958 * composite.c (Fremove_list_of_text_properties): Remove decl.
7959 (Fcomposition_get_gstring): New forward static decl.
7960 * composite.h (Fcomposite_get_gstring): Remove decl.
7961 * dired.c (Ffile_attributes): New forward static decl.
7962 * doc.c (Fdocumntation_property): New forward static decl.
7963 * eval.c (Ffetch_bytecode): New forward static decl.
7964 (Funintern): Remove extern decl; now in .h file where it belongs.
7965 * fileio.c (Fmake_symbolic_link): New forward static decl.
7966 * image.c (Finit_image_library): New forward static decl.
7967 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7968 * intervals.h (Fprevious_property_change):
7969 (Fremove_list_of_text_properties): Remove decls.
7970 * keyboard.c (Fthis_command_keys): Remove decl.
7971 (Fcommand_execute): New forward static decl.
7972 * keymap.c (Flookup_key): New forward static decl.
7973 (Fcopy_keymap): Now static.
7974 * keymap.h (Flookup_key): Remove decl.
7975 * process.c (Fget_process): New forward static decl.
7976 (Fprocess_datagram_address): Mark as internal.
7977 * syntax.c (Fsyntax_table_p): New forward static decl.
7978 (skip_chars): Remove duplicate decl.
7979 * textprop.c (Fprevious_property_change): New forward static decl.
7980 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7982 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7983 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7985 * editfns.c (Fformat): Remove unreachable code.
7987 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7989 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7992 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7994 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7995 when at ZV. (Bug#8487)
7997 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7999 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8001 * keyboard.c (parse_tool_bar_item): Likewise.
8002 * sound.c (sound_cleanup, alsa_close): Likewise.
8003 * termcap.c (tgetent): Likewise.
8004 * xfns.c (x_default_font_parameter): Likewise.
8005 * xsettings.c (read_and_apply_settings): Likewise.
8007 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8008 (overrun_check_free): Protoize.
8010 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8012 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8013 since callers should never pass a negative size.
8014 Change the signature to match that of plain 'read' and 'write'; see
8015 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8016 * lisp.h: Update prototypes of emacs_write and emacs_read.
8018 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8020 * xdisp.c (redisplay_window): Don't try to determine the character
8021 position of the scroll margin if the window start point w->startp
8022 is outside the buffer's accessible region. (Bug#8468)
8024 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8026 Fix write-region and its subroutines for buffers > 2GB.
8027 * fileio.c (a_write, e_write): Modify declaration of arguments and
8028 local variables to support buffers larger than 2GB.
8029 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8031 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8032 argument, local variables, and return value.
8034 * lisp.h: Update prototypes of emacs_write and emacs_read.
8036 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8038 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8040 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8042 Fix more problems found by GCC 4.6.0's static checks.
8044 * xdisp.c (vmessage): Use a better test for character truncation.
8046 * charset.c (load_charset_map): <, not <=, for optimization,
8047 and to avoid potential problems with integer overflow.
8048 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8049 * casetab.c (set_identity, shuffle): Likewise.
8050 * editfns.c (Fformat): Likewise.
8051 * syntax.c (skip_chars): Likewise.
8053 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8054 This also lets GCC 4.6.0 generate slightly better loop code.
8056 * callint.c (Fcall_interactively): <, not <=, for optimization.
8057 (Fcall_interactively): Count the number of arguments produced,
8058 not the number of arguments given. This is simpler and lets GCC
8059 4.6.0 generate slightly better code.
8061 * ftfont.c: Distingish more carefully between FcChar8 and char.
8062 The previous code passed unsigned char * to a functions like
8063 strlen and xstrcasecmp that expect char *, which does not
8064 conform to the C standard.
8065 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8066 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8067 char * when the C standard requires it.
8069 * keyboard.c (read_char): Remove unused var.
8071 * eval.c: Port to Windows vsnprintf (Bug#8435).
8073 (SIZE_MAX): Define if the headers do not.
8074 (verror): Do not give up if vsnprintf returns a negative count.
8075 Instead, grow the buffer. This ports to Windows vsnprintf, which
8076 does not conform to C99. Problem reported by Eli Zaretskii.
8077 Also, simplify the allocation scheme, by avoiding the need for
8078 calling realloc, and removing the ALLOCATED variable.
8080 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8082 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8083 But keep the doprint source code for now, as we might revamp it
8084 and use it again (Bug#8435).
8085 * lisp.h (doprnt): Remove.
8086 * Makefile.in (base_obj): Remove doprnt.o.
8087 * deps.mk (doprnt.o): Remove.
8089 error: Print 32- and 64-bit integers portably (Bug#8435).
8090 Without this change, on typical 64-bit hosts error ("...%d...", N)
8091 was used to print both 32- and 64-bit integers N, which relied on
8093 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8094 * lisp.h (error, verror): Mark as printf-like functions.
8095 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8096 Report overflow in size calculations when allocating printf buffer.
8097 Do not truncate output string at its first null byte.
8098 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8099 Truncate the output at a character boundary, since vsnprintf does not
8101 * charset.c (check_iso_charset_parameter): Convert internal
8102 character to string before calling 'error', since %c now has the
8104 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8105 overflow when computing char to be passed to 'error'. Do not
8106 pass Lisp_Object to 'error'; pass the integer instead.
8107 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8108 formatted with plain %d.
8110 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8112 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8114 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8116 * xterm.c (x_catch_errors): Remove duplicate declaration.
8118 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8120 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8122 2011-04-10 Jim Meyering <meyering@redhat.com>
8124 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8125 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8126 return ssize_t not "int", and use size_t as the buffer length.
8127 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8128 * gnutls.h: Update declarations.
8129 * process.c (read_process_output): Use ssize_t, to match.
8130 (send_process): Likewise.
8132 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8134 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8136 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8138 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8139 Use unsigned char, to match FcChar8 type definition.
8141 * xterm.c (handle_one_xevent):
8142 * xmenu.c (create_and_show_popup_menu):
8143 * xselect.c (x_decline_selection_request)
8144 (x_reply_selection_request): Avoid type-punned deref of X events.
8146 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8148 Fix some uses of `int' instead of EMACS_INT.
8149 * search.c (string_match_1, fast_string_match)
8150 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8151 (scan_buffer, find_next_newline_no_quit)
8152 (find_before_next_newline, search_command, Freplace_match)
8153 (Fmatch_data): Make some `int' variables be EMACS_INT.
8155 * xdisp.c (display_count_lines): 3rd argument and return value now
8156 EMACS_INT. All callers changed.
8157 (pint2hrstr): Last argument is now EMACS_INT.
8159 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8160 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8161 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8162 (decode_coding_utf_16, decode_coding_emacs_mule)
8163 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8164 (decode_coding_ccl, decode_coding_charset)
8165 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8166 (decode_coding_iso_2022, decode_coding_emacs_mule)
8167 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8168 <char_offset, last_offset>: Declare EMACS_INT.
8169 (encode_coding_utf_8, encode_coding_utf_16)
8170 (encode_coding_emacs_mule, encode_invocation_designation)
8171 (encode_designation_at_bol, encode_coding_iso_2022)
8172 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8173 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8175 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8176 (encode_invocation_designation): Last argument P_NCHARS is now
8178 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8179 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8181 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8184 * ccl.c (Fccl_execute_on_string): Declare some variables
8187 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8189 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8191 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8193 * process.c (Fformat_network_address): Doc fix.
8195 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8197 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8199 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8201 * keyboard.c (read_char): Call Lisp function help-form-show,
8202 instead of using internal_with_output_to_temp_buffer.
8203 (Qhelp_form_show): New var.
8204 (syms_of_keyboard): Use DEFSYM macro.
8206 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8208 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8210 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8212 * process.c (Flist_processes): Remove to Lisp.
8213 (list_processes_1): Delete.
8215 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8217 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8219 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8221 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8223 Fix more problems found by GCC 4.6.0's static checks.
8225 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8227 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8229 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8231 * xdisp.c (vmessage): Mark as a printf-like function.
8233 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8235 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8237 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8238 printf-like functions.
8239 (tiff_load): Add casts to remove these marks before passing them
8240 to system-supplied API.
8242 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8244 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8245 This avoids several warnings with gcc -Wstrict-overflow.
8246 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8247 directly, rather than having caller test rule sign. This avoids
8248 some unnecessary tests.
8249 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8250 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8251 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8253 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8254 (xfont_open): Avoid unnecessary tests.
8256 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8258 * composite.h, composite.c (composition_gstring_put_cache):
8259 Use EMACS_INT, not int, for length.
8261 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8262 breaking out part of COMPOSITION_DECODE_RULE.
8263 (COMPOSITION_DECODE_RULE): Use it.
8264 * composite.c (get_composition_id): Remove unused local vars,
8265 by using the new macro.
8267 * textprop.c (set_text_properties_1): Change while to do-while,
8268 since the condition is always true at first.
8270 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8271 (interval_deletion_adjustment): Return unsigned value.
8274 * process.c (list_processes_1, create_pty, read_process_output):
8275 (exec_sentinel): Remove vars that were set but not used.
8276 (create_pty): Remove unnecessary "volatile"s.
8277 (Fnetwork_interface_info): Avoid possibility of int overflow.
8278 (read_process_output): Do adaptive read buffering even if carryover.
8279 (read_process_output): Simplify nbytes computation if buffered.
8281 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8283 * syntax.c (scan_words): Remove var that was set but not used.
8284 (update_syntax_table): Use unsigned instead of int.
8286 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8287 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8288 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8290 * print.c (print_error_message): Avoid int overflow.
8292 * font.c (font_list_entities): Redo for clarity,
8293 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8295 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8296 (font_score): Avoid potential overflow in diff calculation.
8298 * fns.c (substring_both): Remove var that is set but not used.
8299 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8301 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8303 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8304 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8305 can always succeed if overflow has undefined behavior.
8307 * search.c (boyer_moore, wordify): Remove vars set but not used.
8308 (wordify): Omit three unnecessary tests.
8310 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8311 All callers changed. This avoids the need for an unused var.
8313 * casefiddle.c (casify_region): Remove var that is set but not used.
8315 * dired.c (file_name_completion): Remove var that is set but not used.
8317 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8319 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8320 (Finsert_file_contents): Remove unnecessary code checking fd.
8322 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8323 Check for integer overflow on size calculations.
8325 * buffer.c (Fprevious_overlay_change): Remove var that is set
8328 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8329 Remove vars that are set but not used.
8330 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8331 (timer_check_2): Mark vars as initialized.
8333 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8335 * image.c (lookup_image): Remove var that is set but not used.
8336 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8338 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8339 that are set but not used.
8341 * xfns.c (make_invisible_cursor): Don't return garbage
8342 if XCreateBitmapFromData fails (Bug#8410).
8344 * xselect.c (x_get_local_selection, x_handle_property_notify):
8345 Remove vars that are set but not used.
8347 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8348 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8350 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8351 Remove var that is set but not used.
8352 (scroll_bar_windows_size): Now size_t, not int.
8353 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8356 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8357 (map_tty_color) [!defined MSDOS]: Likewise.
8359 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8361 * coding.c: Remove vars that are set but not used.
8362 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8363 All callers changed.
8364 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8365 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8366 (decode_coding_charset): Remove vars that are set but not used.
8368 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8369 that is set but not used.
8371 * print.c (print_object): Remove var that is set but not used.
8373 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8374 The gnulib version avoids calling malloc in the usual case,
8375 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8376 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8377 * filelock.c (current_lock_owner): Likewise.
8378 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8379 * sysdep.c: Include allocator.h, careadlinkat.h.
8380 (emacs_no_realloc_allocator): New static constant.
8381 (emacs_readlink): New function.
8382 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8383 ../lib/careadlinkat.h.
8385 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8387 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8388 first non-nil return value).
8390 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8392 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8393 if not defined (Bug#8403).
8395 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8397 * xdisp.c (display_count_lines): Remove parameter `start',
8398 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8399 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8400 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8401 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8402 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8403 and thereabouts. All callers changed.
8404 (get_per_char_metric): Remove parameter `f', unused since
8405 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8407 2011-04-02 Jim Meyering <meyering@redhat.com>
8409 do not dereference NULL upon failed strdup
8410 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8411 (ns_get_family): Likewise.
8413 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8415 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8417 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8419 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8422 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8424 Add lexical binding.
8426 * window.c (Ftemp_output_buffer_show): New fun.
8427 (Fsave_window_excursion):
8428 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8430 * lread.c (lisp_file_lexically_bound_p): New function.
8431 (Fload): Bind Qlexical_binding.
8432 (readevalloop): Remove `evalfun' arg.
8433 Bind Qinternal_interpreter_environment.
8434 (Feval_buffer): Bind Qlexical_binding.
8435 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8437 (syms_of_lread): Declare `lexical-binding'.
8439 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8441 * keyboard.c (eval_dyn): New fun.
8442 (menu_item_eval_property): Use it.
8444 * image.c (parse_image_spec): Use Ffunctionp.
8446 * fns.c (concat, mapcar1): Accept byte-code-functions.
8448 * eval.c (Fsetq): Handle lexical vars.
8449 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8450 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8451 (FletX, Flet): Obey lexical binding.
8452 (Fcommandp): Handle closures.
8453 (Feval): New `lexical' arg.
8454 (eval_sub): New function extracted from Feval. Use it almost
8455 everywhere where Feval was used. Look up vars in lexical env.
8457 (Ffunctionp): Move from subr.el.
8458 (Ffuncall): Handle closures.
8459 (apply_lambda): Remove `eval_flags'.
8460 (funcall_lambda): Handle closures and new byte-code-functions.
8461 (Fspecial_variable_p): New function.
8462 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8463 but without exporting it to Lisp.
8465 * doc.c (Fdocumentation, store_function_docstring):
8466 * data.c (Finteractive_form): Handle closures.
8468 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8471 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8473 (exec_byte_code): New function extracted from Fbyte_code to handle new
8474 calling convention for byte-code-functions. Add new byte-codes.
8476 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8478 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8480 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8482 * xdisp.c (redisplay_internal): Fix prototype.
8484 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8486 * xdisp.c (SCROLL_LIMIT): New macro.
8487 (try_scrolling): Use it when setting scroll_limit.
8488 Limit scrolling to 100 screen lines.
8489 (redisplay_window): Even when falling back on "recentering",
8490 position point in the window according to scroll-conservatively,
8491 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8493 (try_scrolling): When point is above the window, allow searching
8494 as far as scroll_max, or one screenful, to compute vertical
8495 distance from PT to the scroll margin position. This prevents
8496 try_scrolling from unnecessarily failing when
8497 scroll-conservatively is set to a value slightly larger than the
8498 window height. Clean up the case of PT below the margin at bottom
8499 of window: scroll_max can no longer be INT_MAX. When aggressive
8500 scrolling is in use, don't let point enter the opposite scroll
8501 margin as result of the scroll.
8502 (syms_of_xdisp) <scroll-conservatively>: Document the
8503 threshold of 100 lines for never-recentering scrolling.
8505 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8507 * dispextern.h (move_it_by_lines):
8508 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8509 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8510 (message_log_check_duplicate): Remove parameters `prev_bol' and
8511 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8512 (redisplay_internal): Remove parameter `preserve_echo_area',
8513 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8515 * indent.c (Fvertical_motion):
8516 * window.c (window_scroll_pixel_based, Frecenter):
8517 Don't pass `need_y_p' to `move_it_by_lines'.
8519 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8521 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8522 steal a few bits to be more compact.
8523 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8524 Remove unneeded casts.
8526 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8528 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8530 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8531 binding" message (bug#7967).
8533 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8535 Fix more problems found by GCC 4.6.0's static checks.
8537 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8538 Remove unused local var.
8540 * editfns.c (Fmessage_box): Remove unused local var.
8542 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8543 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8544 Omit unused local vars.
8545 * window.c (shrink_windows): Omit unused local var.
8546 * menu.c (digest_single_submenu): Omit unused local var.
8547 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8548 Omit unused local var.
8550 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8551 Don't assume string length fits in int.
8552 (keyremap_step, read_key_sequence): Use size_t for sizes.
8553 (read_key_sequence): Don't check last_real_key_start redundantly.
8555 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8556 instead of alloca (Bug#8344).
8558 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8559 (Fbacktrace_frame): Don't assume nframes fits in int.
8561 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8563 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8566 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8568 * cm.c (calccost): Turn while-do into do-while, for clarity.
8570 * keyboard.c (syms_of_keyboard): Use the same style as later
8571 in this function when indexing through an array. This also
8572 works around GCC bug 48267.
8574 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8576 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8578 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8579 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8581 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8582 This avoids undefined behavior on integer overflow, and is a bit
8583 more convenient anyway since it is compared to a size_t variable.
8585 Variadic C functions now count arguments with size_t, not int.
8586 This avoids an unnecessary limitation on 64-bit machines, which
8587 caused (substring ...) to crash on large vectors (Bug#8344).
8588 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8589 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8590 All variadic functions and their callers changed accordingly.
8591 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8592 * data.c (arith_driver, float_arith_driver): Likewise.
8593 * editfns.c (general_insert_function): Likewise.
8594 * eval.c (struct backtrace.nargs, interactive_p)
8595 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8596 (funcall_lambda, mark_backtrace): Likewise.
8597 * fns.c (concat): Likewise.
8598 * frame.c (x_set_frame_parameters): Likewise.
8599 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8600 0 if not found, not -1. All callers changed.
8602 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8603 (stack_copy_size): Now size_t, not int.
8604 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8606 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8608 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8609 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8610 All callers changed.
8612 * lisp.h (multibyte_char_to_unibyte):
8613 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8614 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8615 * character.h (CHAR_TO_BYTE8):
8616 * cmds.c (internal_self_insert):
8617 * editfns.c (general_insert_function):
8618 * keymap.c (push_key_description):
8619 * search.c (Freplace_match):
8620 * xdisp.c (message_dolog, set_message_1): All callers changed.
8622 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8624 * keyboard.c (safe_run_hook_funcall): New function.
8625 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8626 don't set the hook to nil, but remove the offending function instead.
8627 (Qcommand_hook_internal): Remove, unused.
8628 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8629 Vcommand_hook_internal.
8631 * eval.c (enum run_hooks_condition): Remove.
8632 (funcall_nil, funcall_not): New functions.
8633 (run_hook_with_args): Call each function through a `funcall' argument.
8634 Remove `cond' argument, now redundant.
8635 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8636 (Frun_hook_with_args_until_failure): Adjust accordingly.
8637 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8639 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8641 * dispextern.h (string_buffer_position): Remove declaration.
8643 * print.c (strout): Remove parameter `multibyte', unused since
8644 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8646 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8647 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8648 All callers changed.
8650 * w32.c (_wsa_errlist): Use braces for struct initializers.
8652 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8653 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8654 All callers changed.
8655 (string_buffer_position): Likewise. Also, make static (it's never
8656 used outside xdisp.c).
8657 (cursor_row_p): Remove parameter `w', unused since
8658 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8659 (decode_mode_spec): Remove parameter `precision', introduced during
8660 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8661 All callers changed.
8663 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8665 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8667 2011-03-27 Anders Lindgren <andlind@gmail.com>
8669 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8670 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8671 (ns_update_auto_hide_menu_bar): New functions.
8672 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8673 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8674 ns_constrain_all_frames.
8675 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8676 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8678 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8680 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8682 2011-03-27 Glenn Morris <rgm@gnu.org>
8684 * syssignal.h: Replace RETSIGTYPE with void.
8685 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8686 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8687 Replace SIGTYPE with void everywhere.
8688 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8689 * s/template.h (SIGTYPE): Remove commented out definition.
8691 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8693 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8694 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8696 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8698 * w32.c (read_unc_volume): Use parameter `henum', instead of
8699 global variable `wget_enum_handle'.
8701 * keymap.c (describe_vector): Remove parameters `indices' and
8702 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8703 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8705 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8707 * keyboard.c (timer_check): Remove parameter `do_it_now',
8708 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8709 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8710 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8712 * keyboard.c (read_char):
8713 * w32menu.c (w32_menu_display_help):
8714 * xmenu.c (show_help_event, menu_help_callback):
8715 Adjust calls to `show_help_echo'.
8717 * gtkutil.c (xg_maybe_add_timer):
8718 * keyboard.c (readable_events):
8719 * process.c (wait_reading_process_output):
8720 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8722 * insdel.c (adjust_markers_gap_motion):
8723 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8724 (gap_left, gap_right): Don't call it.
8726 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8728 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8729 incurred during fontification.
8731 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8733 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8734 (DEFVAR_PER_BUFFER): Don't pass it.
8736 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8737 (scrolling_window): Don't pass it.
8739 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8741 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8743 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8745 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8746 of variables specific to SELinux and computation of `encoded_absname'.
8748 * image.c (XPutPixel): Remove unused variable `height'.
8750 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8752 * unexw32.c (get_section_info): Remove unused variable `section'.
8754 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8755 (system_process_attributes): Remove unused variable `sess'.
8756 (sys_read): Remove unused variable `err'.
8758 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8759 (w32_wnd_proc): Remove unused variable `isdead'.
8760 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8761 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8762 (x_create_tip_frame): Remove unused variable `tem'.
8764 * w32inevt.c (w32_console_read_socket):
8765 Remove unused variable `no_events'.
8767 * w32term.c (x_draw_composite_glyph_string_foreground):
8768 Remove unused variable `width'.
8770 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8772 * w32term.c (x_set_glyph_string_clipping):
8773 Don't pass uninitialized region to CombineRgn.
8775 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8777 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8778 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8779 (Fx_close_connection): Remove unused variable `i'.
8781 * w32font.c (w32font_draw): Return number of glyphs.
8782 (w32font_open_internal): Remove unused variable `i'.
8783 (w32font_driver): Add missing initializer.
8785 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8786 (fill_in_menu): Remove unused variable `items_added'.
8788 * w32term.c (last_mouse_press_frame): Remove static global variable.
8789 (w32_clip_to_row): Remove unused variable `f'.
8790 (x_delete_terminal): Remove unused variable `i'.
8792 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8793 (NOTHING): Remove unused static global variable.
8794 (uniscribe_check_otf): Remove unused variable `table'.
8795 (uniscribe_font_driver): Add missing initializers.
8797 2011-03-23 Julien Danjou <julien@danjou.info>
8799 * term.c (Fsuspend_tty, Fresume_tty):
8800 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8801 * window.c (temp_output_buffer_show):
8802 * insdel.c (signal_before_change):
8803 * frame.c (Fhandle_switch_frame):
8804 * fileio.c (Fdo_auto_save):
8805 * emacs.c (Fkill_emacs):
8806 * editfns.c (save_excursion_restore):
8807 * cmds.c (internal_self_insert):
8808 * callint.c (Fcall_interactively):
8809 * buffer.c (Fkill_all_local_variables):
8810 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8812 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8813 unconditionally since it does the check itself.
8815 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8817 Fix more problems found by GCC 4.5.2's static checks.
8819 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8820 the first time through the loop, since we know p0 < p1 then.
8821 This also avoids a gcc -Wstrict-overflow warning.
8823 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8824 leading to a memory leak, possible in functions like
8825 load_charset_map_from_file that can allocate an unbounded number
8826 of objects (Bug#8318).
8828 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8829 that could (at least in theory) be that large.
8831 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8832 This is less likely to overflow, and avoids undefined behavior if
8833 overflow does occur. All callers changed. Use strtoul to scan
8834 for the unsigned long integer.
8835 (pint2hrstr): Simplify and tune code slightly.
8836 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8838 * scroll.c (do_scrolling): Work around GCC bug 48228.
8839 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8841 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8842 This also avoids a warning with gcc -Wstrict-overflow.
8843 (validate_x_resource_name): Simplify count usage.
8844 This also avoids a warning with gcc -Wstrict-overflow.
8846 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8849 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8851 * process.c (Fmake_network_process): Use socklen_t, not int,
8852 where POSIX says socklen_t is required in portable programs.
8853 This fixes a porting bug on hosts like 64-bit HP-UX, where
8854 socklen_t is wider than int (Bug#8277).
8855 (Fmake_network_process, server_accept_connection):
8856 (wait_reading_process_output, read_process_output):
8859 * process.c: Rename or move locals to avoid shadowing.
8860 (list_processes_1, Fmake_network_process):
8861 (read_process_output_error_handler, exec_sentinel_error_handler):
8862 Rename or move locals.
8863 (Fmake_network_process): Define label "retry_connect" only if needed.
8864 (Fnetwork_interface_info): Fix pointer signedness.
8865 (process_send_signal): Add cast to avoid pointer signedness problem.
8866 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8867 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8869 Make tparam.h and terminfo.c consistent.
8870 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8871 Include tparam.h instead, since it declares them.
8872 * cm.h (PC): Remove extern decl; tparam.h now does this.
8873 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8874 * terminfo.c: Include tparam.h, to check interfaces.
8875 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8876 (tparam): Adjust signature to match interface in tparam.h;
8877 this removes some undefined behavior. Check that outstring and len
8878 are zero, which they always are with Emacs.
8879 * tparam.h (PC, BC, UP): New extern decls.
8881 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8882 (xftfont_open): Rename locals to avoid shadowing.
8884 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8885 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8886 (OTF_TAG_SYM): Omit macro if not needed.
8887 (ftfont_list): Remove unused local.
8888 (get_adstyle_property, ftfont_pattern_entity):
8889 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8890 Rename locals to avoid shadowing.
8892 * xfont.c (xfont_list_family): Mark var as initialized.
8894 * xml.c (make_dom): Now static.
8896 * composite.c (composition_compute_stop_pos): Rename local to
8898 (composition_reseat_it): Remove unused locals.
8899 (find_automatic_composition, composition_adjust_point): Likewise.
8900 (composition_update_it): Mark var as initialized.
8901 (find_automatic_composition): Mark vars as initialized,
8902 with a FIXME (Bug#8290).
8904 character.h: Rename locals to avoid shadowing.
8905 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8906 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8907 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8908 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8911 * textprop.c (property_change_between_p): Remove; unused.
8913 * intervals.c (interval_start_pos): Now static.
8915 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8917 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8918 Rename locals to avoid shadowing.
8920 * sound.c (wav_play, au_play, Fplay_sound_internal):
8921 Fix pointer signedness.
8922 (alsa_choose_format): Remove unused local var.
8923 (wav_play): Initialize a variable to 0, to prevent undefined
8924 behavior (Bug#8278).
8926 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8928 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8930 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8931 clobbering (Bug#8298).
8932 * sysdep.c (sys_subshell): Likewise.
8933 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8935 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8936 This should get cleaned up, so that child_setup has the
8937 same signature on all platforms.
8939 * callproc.c (call_process_cleanup): Now static.
8940 (relocate_fd): Rename locals to avoid shadowing.
8942 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8944 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8945 not to be necessary, and produces flickering.
8947 2011-03-20 Glenn Morris <rgm@gnu.org>
8949 * config.in: Remove file.
8951 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8953 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8954 are now in src/globals.h.
8955 (syms_of_minibuf): Remove spurious & from previous change.
8957 2011-03-20 Leo Liu <sdl.web@gmail.com>
8959 * minibuf.c (completing-read-function): New variable.
8960 (completing-read-default): Rename from completing-read.
8961 (completing-read): Call completing-read-function.
8963 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8965 * xfaces.c (Fx_load_color_file):
8966 Read color file from absolute filename (bug#8250).
8968 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8970 * makefile.w32-in: Update dependencies.
8972 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8974 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8976 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8978 Fix more problems found by GCC 4.5.2's static checks.
8980 * process.c (make_serial_process_unwind, send_process_trap):
8981 (sigchld_handler): Now static.
8983 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8984 That way, the code declares only the vars that it needs.
8985 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8986 * s/cygwin.h (PTY_ITERATION): Likewise.
8987 * s/darwin.h (PTY_ITERATION): Likewise.
8988 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8990 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8991 * process.c (allocate_pty): Don't declare stb unless it's needed.
8993 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8994 (CONSTANTLIM): Remove; unused.
8995 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8996 Define only if needed.
8998 * unexelf.c (unexec): Name an expression,
8999 to avoid gcc -Wbad-function-cast warning.
9000 Use a different way to cause a compilation error if anyone uses
9001 n rather than nn, a way that does not involve shadowing.
9002 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9004 * deps.mk (unexalpha.o): Remove; unused.
9006 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9007 * unexec.h: New file.
9008 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9009 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9011 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9012 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9013 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9014 Change as necessary to match prototype in unexec.h.
9016 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9018 (back_comment, skip_chars): Mark vars as initialized.
9020 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9021 Rename locals to avoid shadowing.
9023 * lread.c (read1): Rewrite so as not to use empty "else".
9024 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9026 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9028 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9029 warning when compiling print.c.
9031 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9032 instead of using an uninitialized var.
9033 (font_sort_entities): Mark var as initialized.
9035 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9037 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9038 pointers to constants.
9039 (font_parse_fcname): Remove unused vars.
9040 (font_delete_unmatched): Now static.
9041 (font_get_spec): Remove; unused.
9042 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9043 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9044 Rename or move locals to avoid shadowing.
9046 * fns.c (require_nesting_list, require_unwind): Now static.
9047 (Ffillarray): Rename locals to avoid shadowing.
9049 * floatfns.c (domain_error2): Define only if needed.
9050 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9052 * alloc.c (mark_backtrace): Move decl from here ...
9053 * lisp.h: ... to here, so that it can be checked.
9055 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9056 (Fdefvar): Rewrite so as not to use empty "else".
9057 (lisp_indirect_variable): Name an expression,
9058 to avoid gcc -Wbad-function-cast warning.
9059 (Fdefvar): Rename locals to avoid shadowing.
9061 * callint.c (quotify_arg, quotify_args): Now static.
9062 (Fcall_interactively): Rename locals to avoid shadowing.
9063 Use const pointer when appropriate.
9065 * lisp.h (get_system_name, get_operating_system_release):
9066 Move decls here, to check interfaces.
9067 * process.c (get_operating_system_release): Move decl to lisp.h.
9068 * xrdb.c (get_system_name): Likewise.
9069 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9070 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9071 some of which prompt warnings from gcc -Wbad-function-cast.
9072 (Fformat_time_string, Fencode_time, Finsert_char):
9073 (Ftranslate_region_internal, Fformat):
9074 Rename or remove local vars to avoid shadowing.
9075 (Ftranslate_region_internal): Mark var as initialized.
9077 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9080 * lisp.h (eassert): Check that the argument compiles, even if
9081 ENABLE_CHECKING is not defined.
9083 * data.c (Findirect_variable): Name an expression, to avoid
9084 gcc -Wbad-function-cast warning.
9085 (default_value, arithcompare, arith_driver, arith_error): Now static.
9086 (store_symval_forwarding): Rename local to avoid shadowing.
9087 (Fmake_variable_buffer_local, Fmake_local_variable):
9088 Mark variables as initialized.
9089 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9091 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9092 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9093 Rename locals to avoid shadowing.
9094 (mark_stack): Move local variables into the #ifdef region where
9096 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9097 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9099 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9100 (GC_STRING_CHARS): Remove; not used.
9101 (Fmemory_limit): Cast sbrk's returned value to char *.
9103 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9104 avoids undefined behavior in theory.
9106 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9108 Use functions, not macros, for up- and down-casing (Bug#8254).
9109 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9110 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9111 to use the following functions instead of these macros.
9112 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9113 EMACS_INT, since callers assume the returned value fits in int.
9114 (upcase1): Likewise, for UPCASE_TABLE.
9115 (uppercasep, lowercasep, upcase): New static inline functions.
9116 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9117 the race-condition problem in the old DOWNCASE.
9119 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9120 Rename locals to avoid shadowing.
9121 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9122 (regex_compile, re_search_2, re_match_2_internal):
9123 Remove unused local vars.
9124 (FREE_VAR): Rewrite so as not to use empty "else",
9125 which gcc can warn about.
9126 (regex_compile, re_match_2_internal): Mark locals as initialized.
9127 (RETALLOC_IF): Define only if needed.
9128 (WORDCHAR_P): Likewise. This one is never needed, but is used
9129 only in a comment talking about a compiler bug, so put inside
9130 the #if 0 of that comment.
9131 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9132 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9135 * search.c (boyer_moore): Rename locals to avoid shadowing.
9136 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9137 (PREV_CHAR_BOUNDARY): Likewise.
9139 * search.c (simple_search): Remove unused var.
9141 * dired.c (compile_pattern): Move decl from here ...
9142 * lisp.h: ... to here, so that it can be checked.
9143 (struct re_registers): New forward decl.
9145 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9147 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9149 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9150 Rename locals to avoid shadowing.
9151 (Fvertical_motion): Mark locals as initialized.
9153 * casefiddle.c (casify_object, casify_region): Now static.
9154 (casify_region): Mark local as initialized.
9156 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9158 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9159 New macros, so that the caller can use some names other than
9160 gcpro1, gcpro2, etc.
9161 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9163 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9164 argument, for consistency with GCPRO2_VAR, etc: it is now the
9165 prefix of the variable, not the variable itself. All uses
9167 * dired.c (directory_files_internal, file_name_completion):
9168 Rename locals to avoid shadowing.
9170 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9171 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9172 dired.c's scmp function, had undefined behavior.
9173 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9174 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9175 * buffer.h: ... to here, because these macros use current_buffer,
9176 and the new implementation with inline functions needs to have
9177 current_buffer in scope now, rather than later when the macros
9179 (downcase, upcase1): New static inline functions.
9180 (DOWNCASE, UPCASE1): Reimplement using these functions.
9181 This avoids undefined behavior in expressions like
9182 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9183 from race conditions in accessing the global variables
9184 case_temp1 and case_temp2.
9185 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9186 * lisp.h (case_temp1, case_temp2): Remove their decls.
9187 * character.h (ASCII_CHAR_P): Move from here ...
9188 * lisp.h: ... to here, so that the inline functions mentioned
9191 * dired.c (directory_files_internal_unwind): Now static.
9193 * fileio.c (file_name_as_directory, directory_file_name):
9194 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9196 (file_name_as_directory): Use const pointers when appropriate.
9197 (Fexpand_file_name): Likewise. In particular, newdir might
9198 point at constant storage, so make it a const pointer.
9199 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9200 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9202 (Fset_file_times, Finsert_file_contents, auto_save_error):
9203 Rename locals to avoid shadowing.
9205 * minibuf.c (choose_minibuf_frame_1): Now static.
9206 (Ftry_completion, Fall_completions): Rename or remove locals
9209 * marker.c (bytepos_to_charpos): Remove; unused.
9211 * lisp.h (verify_bytepos, count_markers): New decls,
9212 so that gcc does not warn that these functions aren't declared.
9214 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9215 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9216 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9217 (copy_text): Remove unused local var.
9219 * filelock.c (within_one_second): Now static.
9220 (lock_file_1): Rename local to avoid shadowing.
9222 * buffer.c (fix_overlays_before): Mark locals as initialized.
9223 (fix_start_end_in_overlays): Likewise. This function should be
9224 simplified by using pointers-to-pointers, but that's a different
9226 (switch_to_buffer_1): Now static.
9227 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9228 (report_overlay_modification): Rename locals to avoid shadowing.
9230 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9231 Fix pointer signedness issue.
9232 (sys_subshell): Mark local as volatile if checking for lint,
9233 to suppress a gcc -Wclobbered warning that does not seem to be right.
9234 (MAXPATHLEN): Define only if needed.
9236 * process.c (serial_open, serial_configure): Move decls from here ...
9237 * systty.h: ... to here, so that they can be checked.
9239 * fns.c (get_random, seed_random): Move extern decls from here ...
9240 * lisp.h: ... to here, so that they can be checked.
9242 * sysdep.c (reset_io): Now static.
9243 (wait_for_termination_signal): Remove; unused.
9245 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9246 (copy_keymap_item, append_key, push_text_char_description):
9248 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9249 (DENSE_TABLE_SIZE): Remove; unused.
9250 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9251 (describe_map_tree):
9252 Rename locals to avoid shadowing.
9254 * keyboard.c: Declare functions static if they are not used elsewhere.
9255 (echo_char, echo_dash, cmd_error, top_level_2):
9256 (poll_for_input, handle_async_input): Now static.
9257 (read_char, kbd_buffer_get_event, make_lispy_position):
9258 (make_lispy_event, make_lispy_movement, apply_modifiers):
9259 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9260 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9261 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9262 (read_key_sequence, read_char): Mark locals as initialized.
9263 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9265 * keyboard.h (make_ctrl_char): New decl.
9266 (mark_kboards): Move decl here ...
9267 * alloc.c (mark_kboards): ... from here.
9269 * lisp.h (force_auto_save_soon): New decl.
9271 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9272 (DEFINE_DUMMY_FUNCTION): New macro.
9273 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9275 (main): Add casts to avoid warnings
9276 if GCC considers string literals to be constants.
9278 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9280 * dbusbind.c: Pointer signedness fixes.
9281 (xd_signature, xd_append_arg, xd_initialize):
9282 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9283 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9284 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9285 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9287 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9288 if GCC considers string literals to be constants.
9289 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9291 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9293 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9294 (print_preprocess, print_object): New macro to fix last change.
9296 * print.c (print_preprocess): Don't forget font objects.
9298 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9300 * emacs.c (USAGE3): Doc fixes.
9302 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9304 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9307 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9309 * lisp.h (VWindow_system, Qfile_name_history):
9310 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9311 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9312 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9314 * w32select.c: Don't #include "keyboard.h".
9315 (run_protected): Add extern declaration for waiting_for_input.
9317 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9318 * w32console.c (detect_input_pending, read_input_pending)
9319 (encode_terminal_code):
9320 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9321 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9322 (w32_system_caret_y, Qfile_name_history):
9323 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9324 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9325 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9326 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9327 * w32proc.c (Qlocal, report_file_error):
9328 * w32term.c (Vwindow_system, updating_frame):
9329 * w32uniscribe.c (initialized, uniscribe_font_driver):
9330 Remove unneeded extern declarations.
9332 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9334 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9336 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9338 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9339 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9340 These macros can no longer be used for assignment.
9342 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9343 Assign struct members directly, instead of using BUF_BEGV etc.
9344 (record_buffer_markers, fetch_buffer_markers): New functions for
9345 recording and fetching special buffer markers.
9346 (set_buffer_internal_1, set_buffer_temp): Use them.
9348 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9350 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9352 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9353 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9355 * xdisp.c (hscroll_window_tree):
9356 (reconsider_clip_changes): Use PT instead of BUF_PT.
9358 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9360 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9361 $(EMACS_ROOT)/lib/intprops.h.
9363 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9365 Fix more problems found by GCC 4.5.2's static checks.
9367 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9368 to unsigned char * to avoid compiler diagnostic.
9369 (xg_free_frame_widgets): Make it clear that a local variable is
9370 needed only if USE_GTK_TOOLTIP.
9371 (gdk_window_get_screen): Make it clear that this macro is needed
9372 only if USE_GTK_TOOLTIP.
9373 (int_gtk_range_get_value): New function, which avoids a diagnostic
9374 from gcc -Wbad-function-cast.
9375 (xg_set_toolkit_scroll_bar_thumb): Use it.
9376 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9377 diagnostic from gcc -Wbad-function-cast.
9378 (get_utf8_string, xg_get_file_with_chooser):
9379 Rename locals to avoid shadowing.
9380 (create_dialog): Move locals to avoid shadowing.
9382 * xgselect.c (xg_select): Remove unused var.
9384 * image.c (four_corners_best): Mark locals as initialized.
9385 (gif_load): Initialize transparent_p to zero (Bug#8238).
9386 Mark another local as initialized.
9387 (my_png_error, my_error_exit): Mark with NO_RETURN.
9389 * image.c (clear_image_cache): Now static.
9390 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9391 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9392 (x_edge_detection): Remove unnecessary cast that
9393 gcc -Wbad-function-cast diagnoses.
9394 (gif_load): Fix pointer signedness.
9395 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9396 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9398 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9400 Improve quality of tests for time stamp overflow.
9401 For example, without this patch (encode-time 0 0 0 1 1
9402 1152921504606846976) returns the obviously-bogus value (-948597
9403 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9404 reports time overflow. See
9405 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9406 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9407 * editfns.c: Include limits.h and intprops.h.
9408 (TIME_T_MIN, TIME_T_MAX): New macros.
9409 (time_overflow): Move earlier, to before first use.
9410 (hi_time, lo_time): New functions, for an accurate test for
9412 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9413 (Fget_internal_run_time): Don't assume time_t fits in int.
9414 (make_time): Use list2 instead of Fcons twice.
9415 (Fdecode_time): More accurate test for out-of-range times.
9416 (check_tm_member): New function.
9417 (Fencode_time): Use it, to test for out-of-range times.
9418 (lisp_time_argument): Don't rely on undefined left-shift and
9419 right-shift behavior when checking for time stamp overflow.
9421 * editfns.c (time_overflow): New function, refactoring common code.
9422 (Fformat_time_string, Fdecode_time, Fencode_time):
9423 (Fcurrent_time_string): Use it.
9425 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9426 * dired.c (make_time): Move to ...
9427 * editfns.c (make_time): ... here.
9428 * systime.h: Note the move.
9430 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9432 * fringe.c (update_window_fringes): Remove unused variables.
9434 * unexmacosx.c (copy_data_segment): Also copy __got section.
9437 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9439 * termcap.c [MSDOS]: Include "msdos.h".
9440 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9441 Constify `char *' arguments and their references according to
9442 prototypes in tparam.h.
9444 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9446 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9447 Adapt all references accordingly.
9449 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9451 2011-03-11 Tom Tromey <tromey@redhat.com>
9453 * buffer.c (syms_of_buffer): Remove obsolete comment.
9455 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9457 * termhooks.h (encode_terminal_code): Declare prototype.
9459 * msdos.c (encode_terminal_code): Don't declare prototype.
9461 * term.c (encode_terminal_code): Now external again, used by
9462 w32console.c and msdos.c.
9464 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9465 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9467 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9469 Fix some minor problems found by GCC 4.5.2's static checks.
9471 * fringe.c (update_window_fringes): Mark locals as initialized
9473 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9475 * alloc.c (mark_fringe_data): Move decl from here ...
9476 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9477 to check its interface.
9478 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9480 * fontset.c (free_realized_fontset): Now static.
9481 (Fset_fontset_font): Rename local to avoid shadowing.
9482 (fontset_font): Mark local as initialized.
9483 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9485 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9487 * xselect.c (x_disown_buffer_selections): Remove; not used.
9488 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9489 (x_own_selection, Fx_disown_selection_internal): Rename locals
9491 (x_handle_dnd_message): Remove local to avoid shadowing.
9493 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9494 so that the caller can use some name other than gcpro1.
9495 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9496 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9497 (Fx_backspace_delete_keys_p):
9498 Use them to avoid shadowing, and rename vars to avoid shadowing.
9499 (x_decode_color, x_set_name, x_window): Now static.
9500 (Fx_create_frame): Add braces to silence GCC warning.
9501 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9502 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9503 Remove unused locals.
9504 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9505 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9506 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9509 * xterm.h (x_mouse_leave): New decl.
9511 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9512 Remove unused functions.
9513 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9514 (x_calc_absolute_position): Now static.
9515 (XTread_socket): Don't define label "out" unless it's used.
9516 Don't declare local "event" unless it's used.
9517 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9518 unless they are used.
9519 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9520 (x_fatal_error_signal): Remove; not used.
9521 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9522 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9523 (x_error_catcher, x_connection_closed, x_error_handler):
9524 (x_error_quitter, xembed_send_message, x_iconify_frame):
9525 (my_log_handler): Rename locals to avoid shadowing.
9526 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9527 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9529 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9530 Rename or move locals to avoid shadowing.
9531 (tty_defined_color, merge_face_heights): Now static.
9532 (free_realized_faces_for_fontset): Remove; not used.
9533 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9534 does not deduce is never used uninitialized.
9535 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9536 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9538 * terminal.c (store_terminal_param): Now static.
9540 * xmenu.c (menu_highlight_callback): Now static.
9541 (set_frame_menubar): Remove unused local.
9542 (xmenu_show): Rename parameter to avoid shadowing.
9543 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9544 since they might point to immutable storage.
9545 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9546 since it's unused otherwise.
9548 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9549 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9550 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9551 avoids a gcc -Wuninitialized diagnostic.
9552 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9553 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9554 does not deduce are never used uninitialized.
9556 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9558 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9559 * window.c (window_loop, size_window):
9560 (run_window_configuration_change_hook, enlarge_window): Likewise.
9562 * window.c (display_buffer): Now static.
9563 (size_window): Mark variables that gcc -Wuninitialized
9564 does not deduce are never used uninitialized.
9565 * window.h (check_all_windows): New decl, to forestall
9566 gcc -Wmissing-prototypes diagnostic.
9567 * dispextern.h (bidi_dump_cached_states): Likewise.
9569 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9571 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9573 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9574 and to avoid gcc -Wuninitialized warning.
9575 (load_charset_map): Mark variables that gcc -Wuninitialized
9576 does not deduce are never used uninitialized.
9577 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9579 * coding.c (coding_set_source, coding_set_destination):
9580 Use "else { /* comment */ }" rather than "else /* comment */;"
9581 for clarity, and to avoid gcc -Wempty-body warning.
9582 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9583 a block, when the outer 'i' will do.
9584 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9585 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9586 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9587 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9588 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9589 Rename locals to avoid shadowing.
9590 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9591 * coding.c (emacs_mule_char, encode_invocation_designation):
9592 Now static, since they're not used elsewhere.
9593 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9594 (decode_coding_object, encode_coding_object, detect_coding_system):
9595 (decode_coding_emacs_mule): Mark variables that gcc
9596 -Wuninitialized does not deduce are never used uninitialized.
9597 (detect_coding_iso_2022): Initialize a local variable that might
9598 be used uninitialized. Leave a FIXME because it's not clear that
9599 this initialization is needed. (Bug#8211)
9600 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9601 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9602 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9603 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9604 Remove unused macros.
9606 * category.c (hash_get_category_set): Remove unused local var.
9607 (copy_category_table): Now static, since it's not used elsewhere.
9608 * character.c (string_count_byte8): Likewise.
9610 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9611 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9613 * chartab.c (copy_sub_char_table): Now static, since it's not used
9615 (sub_char_table_ref_and_range, char_table_ref_and_range):
9616 Rename locals to avoid shadowing.
9617 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9619 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9620 (BIDI_BOB): Remove unused macro.
9622 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9623 deduce are never used uninitialized.
9624 * term.c (encode_terminal_code): Likewise.
9626 * term.c (encode_terminal_code): Now static. Remove unused local.
9628 * tparam.h: New file.
9629 * term.c, tparam.h: Include it.
9630 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9631 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9632 Move these decls to tparam.h, and make them agree with what
9633 is actually in tparam.c. The previous trick of using incompatible
9634 decls in different modules does not conform to the C standard.
9635 All callers of tparam changed to use tparam's actual API.
9636 * tparam.c (tparam1, tparam, tgoto):
9637 Use const pointers where appropriate.
9639 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9640 * cm.h (struct cm): Likewise.
9641 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9642 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9643 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9644 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9645 (turn_on_face, init_tty): Likewise.
9646 * termchar.h (struct tty_display_info): Likewise.
9648 * term.c (term_mouse_position): Rename local to avoid shadowing.
9650 * alloc.c (mark_ttys): Move decl from here ...
9651 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9653 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9655 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9657 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9659 * search.c (compile_pattern_1): Remove argument regp, unused since
9660 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9661 (compile_pattern): Don't pass it.
9663 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9665 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9666 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9668 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9670 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9672 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9673 gdk_window_get_screen, gdk_window_get_geometry,
9674 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9675 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9676 (xg_get_pixbuf_from_pixmap): New function.
9677 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9678 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9679 Call xg_get_pixbuf_from_pixmap instead of
9680 gdk_pixbuf_get_from_drawable.
9681 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9682 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9683 (xg_check_special_colors): Use GtkStyleContext and its functions
9685 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9686 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9687 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9688 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9689 Call gtk_widget_get_preferred_size.
9690 (xg_frame_resized): gdk_window_get_geometry only takes 5
9692 (xg_win_to_widget, xg_event_is_for_menubar):
9693 Call gdk_x11_window_lookup_for_display.
9694 (xg_set_widget_bg): New function.
9695 (delete_cb): New function.
9696 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9697 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9698 (xg_set_background_color): Call xg_set_widget_bg.
9699 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9700 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9701 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9702 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9704 (update_frame_tool_bar): Call gtk_widget_hide.
9705 (xg_initialize): Use GDK_KEY_g.
9707 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9709 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9711 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9712 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9713 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9715 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9717 * w32xfns.c (select_palette): Check success of RealizePalette against
9718 GDI_ERROR, not zero.
9720 See ChangeLog.11 for earlier changes.
9726 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9728 This file is part of GNU Emacs.
9730 GNU Emacs is free software: you can redistribute it and/or modify
9731 it under the terms of the GNU General Public License as published by
9732 the Free Software Foundation, either version 3 of the License, or
9733 (at your option) any later version.
9735 GNU Emacs is distributed in the hope that it will be useful,
9736 but WITHOUT ANY WARRANTY; without even the implied warranty of
9737 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9738 GNU General Public License for more details.
9740 You should have received a copy of the GNU General Public License
9741 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.