1 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3 * keyboard.c (read_char): Don't wipe echo area for select window
4 events: These might get delayed via `mouse-autoselect-window'
7 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
9 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
10 manipulation of :loaded-from data.
12 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
14 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
15 now a cons (bug#11311).
17 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
19 Do not create empty overlays with the evaporate property (Bug#9642).
20 * buffer.c (Fmove_overlay): Delete an evaporating overlay
21 if it becomes empty after its bounds are adjusted to fit within
22 its buffer. Without this fix, in a nonempty buffer (let ((o
23 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
24 yields an empty overlay that has the evaporate property, which is
25 not supposed to happen.
27 Fix minor GTK3 problems found by static checking.
28 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
29 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
30 (struct _EmacsFixedClass, emacs_fixed_get_type):
31 Move decls here from emacsgtkfixed.h, since they needn't be public.
32 (emacs_fixed_get_type): Now static.
33 (emacs_fixed_class_init): Omit unused local.
34 (emacs_fixed_child_type): Remove; unused.
35 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
36 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
37 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
38 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
39 (EMACS_FIXED_GET_CLASS): Remove; unused.
40 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
42 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
43 Problem reported by Juanma Barranquero for Windows -Wunused-function.
45 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
47 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
48 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
49 (__malloc_size_t, __malloc_ptrdiff_t):
50 Remove. All uses removed, replaced by the definiens if needed,
51 since we can assume C89 or better now.
52 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
53 (protect_malloc_state, align, get_contiguous_space)
54 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
55 (malloc_atfork_handler_child, malloc_enable_thread)
56 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
57 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
58 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
59 (special_realloc, _realloc_internal_nolock, _realloc_internal)
60 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
61 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
62 Define using prototypes, not old style.
63 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
64 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
65 (align): Don't assume that signed integer overflow wraps around.
66 Omit unused local var.
67 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
68 (_free_internal_nolock, memalign, mallochook, reallochook):
69 Omit no-longer-needed casts.
70 (valloc): Use getpagesize, not __getpagesize.
71 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
72 (struct hdr): The 'magic' member is now size_t, not unsigned long.
74 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
76 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
78 Move functions from C to Lisp. Make non-blocking method calls
79 the default. Implement further D-Bus standard interfaces.
81 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
82 (QCdbus_request_name_allow_replacement)
83 (QCdbus_request_name_replace_existing)
84 (QCdbus_request_name_do_not_queue)
85 (QCdbus_request_name_reply_primary_owner)
86 (QCdbus_request_name_reply_in_queue)
87 (QCdbus_request_name_reply_exists)
88 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
89 (QCdbus_registered_serial, QCdbus_registered_method)
90 (QCdbus_registered_signal): New Lisp objects.
91 (XD_DEBUG_MESSAGE): Use sizeof.
92 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
93 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
94 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
95 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
96 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
97 (xd_signature, xd_append_arg): Allow float for integer types.
98 (xd_get_connection_references): New function.
99 (xd_get_connection_address): Rename from xd_initialize. Return
101 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
102 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
104 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
105 Return number of recounts.
106 (Fdbus_get_unique_name): Make stronger parameter check.
107 (Fdbus_message_internal): New defun.
108 (Fdbus_call_method, Fdbus_call_method_asynchronously)
109 (Fdbus_method_return_internal, Fdbus_method_error_internal)
110 (Fdbus_send_signal, Fdbus_register_service)
111 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
112 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
113 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
114 (Vdbus_compiled_version, Vdbus_runtime_version)
115 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
116 (Vdbus_message_type_method_return, Vdbus_message_type_error)
117 (Vdbus_message_type_signal): New defvars.
118 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
121 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
123 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
124 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
125 Do not assume ptrdiff_t is the same width as 'int'.
127 * alloc.c: Handle unusual debugging option combinations.
128 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
129 since the two debugging options are incompatible.
130 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
132 (mem_init, mem_insert, mem_insert_fixup):
133 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
134 (NEED_MEM_INSERT): Remove; no longer needed.
136 2012-04-22 Leo Liu <sdl.web@gmail.com>
138 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
140 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
142 * sysdep.c [__FreeBSD__]: Minor cleanups.
143 (list_system_processes, system_process_attributes) [__FreeBSD__]:
144 Use Emacs indenting style more consistently. Avoid some casts.
145 Use 'double' consistently rather than mixing 'float' and 'double'.
147 2012-04-21 Eduard Wiebe <usenet@pusto.de>
149 * sysdep.c (list_system_processes, system_process_attributes): Add
150 implementation for FreeBSD (Bug#5243).
152 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
154 * lisp.mk (lisp): Update.
156 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
158 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
159 It is never used otherwise.
161 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
163 * print.c (print_preprocess): Only check print_depth if print-circle
165 (print_object): Check for cycles even when print-circle is nil and
166 print-gensym is t, but only check print_depth if print-circle is nil.
168 2012-04-20 Chong Yidong <cyd@gnu.org>
170 * process.c (wait_reading_process_output): If EIO occurs on a pty,
171 set the status to "failed" and ensure that sentinel is run.
173 2012-04-20 Glenn Morris <rgm@gnu.org>
175 * process.c (Fset_process_inherit_coding_system_flag)
176 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
177 (Fmake_network_process, Fmake_serial_process): Doc fix.
179 2012-04-20 Eli Zaretskii <eliz@gnu.org>
181 * xdisp.c (string_buffer_position_lim): Limit starting position to
183 (set_cursor_from_row): If called for a mode-line or header-line
184 row, return zero immediately.
185 (try_cursor_movement): If inside continuation line, don't back up
186 farther than the first row after the header line, if any.
187 Don't consider the header-line row as "partially visible", even if
188 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
190 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
192 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
195 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
196 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
198 configure: new option --enable-gcc-warnings (Bug#11207)
199 * Makefile.in (C_WARNINGS_SWITCH): Remove.
200 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
201 (ALL_CFLAGS): Use new macros rather than old.
202 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
203 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
204 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
205 -Wunused-result, -Wunused-variable. This should go away once
206 the Emacs and Gnulib regex code is merged.
207 (xmalloc, xrealloc): Now static.
209 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
211 * dired.c (Fsystem_groups): Remove unused local.
213 2012-04-17 Glenn Morris <rgm@gnu.org>
215 * dired.c (Fsystem_users): Doc fix.
217 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
219 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
220 (syms_of_dired): Add them.
222 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
224 Fix minor alloc.c problems found by static checking.
225 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
226 New extern decls, to avoid calling undeclared functions.
227 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
228 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
229 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
230 (NEED_MEM_INSERT): New macro.
231 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
232 Remove one incorrect comment and fix another.
234 Fix minor ralloc.c problems found by static checking.
235 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
236 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
237 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
238 (r_alloc_sbrk): Now static.
240 Improve ralloc.c interface checking.
241 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
242 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
243 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
244 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
245 [REL_ALLOC]: ... to here, to check interface.
246 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
247 Remove decls. This fixes an "It stinks!".
249 * alloc.c (which_symbols): Fix alignment issue / type clash.
251 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
253 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
254 (struct Lisp_Misc_Any): Likewise.
255 (struct Lisp_Free): Likewise.
256 * alloc.c (union aligned_Lisp_Symbol): Define.
257 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
258 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
259 (union aligned_Lisp_Misc): Define.
260 (MARKER_BLOCK_SIZE, struct marker_block): Use union
261 aligned_Lisp_Misc instead of union Lisp_Misc.
262 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
264 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
266 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
267 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
268 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
269 * s/netbsd.h, s/sol2-6.h:
270 Remove definition of GC_MARK_STACK, since the default now works.
271 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
272 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
273 no longer the default.
274 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
276 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
278 * lread.c (lisp_file_lexically_bound_p):
279 Fix hang at ";-*-\n" (bug#11238).
281 2012-04-14 Eli Zaretskii <eliz@gnu.org>
283 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
284 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
286 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
288 * nsterm.m (constrainFrameRect): Always constrain when there is only
289 one screen (Bug#10962).
291 2012-04-13 Ken Brown <kbrown@cornell.edu>
293 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
295 2012-04-13 Reuben Thomas <rrt@sc3d.org>
297 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
299 2012-04-11 Daniel Colascione <dancol@dancol.org>
301 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
302 against is gone. It's better to use vfork now so that when Cygwin
303 gains a new, working vfork, we use it automatically (bug#10398).
305 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
307 * window.c (save_window_save): Obey window-point-insertion-type.
309 2012-04-11 Glenn Morris <rgm@gnu.org>
311 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
313 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
315 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
317 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
319 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
320 (force_quit_count): New var.
321 (handle_interrupt): Use it.
323 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
325 * w32.c (w32_delayed_load): Record the full path of the library
326 being loaded (bug#10424).
328 2012-04-09 Glenn Morris <rgm@gnu.org>
330 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
331 not just in the obarray, before snarfing them. (Bug#11036)
333 * Makefile.in ($(leimdir)/leim-list.el):
334 Pass EMACS rather than BUILT_EMACS.
336 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
338 * process.c (make_process):
339 * process.h: Add integer `gnutls_handshakes_tried' member to
342 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
343 Add convenience `GNUTLS_LOG2i' macro.
345 * gnutls.c (gnutls_log_function2i): Convenience log function.
346 (emacs_gnutls_read): Use new log functions,
347 `gnutls_handshakes_tried' process member, and
348 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
349 attempts per process (connection).
351 2012-04-09 Chong Yidong <cyd@gnu.org>
353 * eval.c (Fuser_variable_p, user_variable_p_eh)
354 (lisp_indirect_variable): Functions deleted.
355 (Fdefvar): Caller changed.
357 * callint.c (Finteractive, Fcall_interactively):
358 * minibuf.c (Fread_variable): Callers changed.
360 2012-04-09 Eli Zaretskii <eliz@gnu.org>
362 * xdisp.c (set_cursor_from_row): If the display string appears in
363 the buffer at position that is closer to point than the position
364 after the display string, display the cursor on the first glyph of
365 the display string. Fixes cursor display when a 'display' text
366 property immediately follows invisible text. (Bug#11094)
368 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
370 composite.c: use 'double' consistently
371 * composite.c (get_composition_id): Use 'double' consistently
372 instead of converting 'float' to 'double' and vice versa; this is
373 easier to understand and avoids a GCC warning.
375 2012-04-09 Glenn Morris <rgm@gnu.org>
377 * Makefile.in: Generate leim-list with bootstrap-emacs, in
378 preparation for dumping it with emacs. (Bug#4789)
379 (leimdir): New variable.
380 ($(leimdir)/leim-list.el): New rule.
381 (emacs$(EXEEXT)): Depend on leim-list.el.
383 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
384 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
385 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
387 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
389 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
392 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
394 * xml.c (init_libxml2_functions) [WINDOWSNT]:
395 Remove unused local variable.
397 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
399 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
400 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
401 (mark_memory): Mark Lisp_Objects only if pointers might hide in
402 objects, as mark_maybe_pointer will catch them otherwise.
403 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
404 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
406 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
408 Fix typo that broke non-Windows builds.
409 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
411 2012-04-07 Eli Zaretskii <eliz@gnu.org>
413 Support building on MS-Windows with libxml2.
415 * makefile.w32-in (OBJ2): Add xml.$(O).
416 (GLOBAL_SOURCES): Add xml.c.
417 ($(BLD)/xml.$(O)): New dependency list.
419 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
420 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
421 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
422 [!WINDOWSNT]: New macros.
423 (init_libxml2_functions, libxml2_loaded_p): New functions.
424 (parse_region): Call fn_xmlCheckVersion instead of using the macro
425 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
426 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
427 Calls xmlCleanupParser only if libxml2 was loaded (or statically
429 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
430 Call init_libxml2_functions before calling libxml2 functions.
431 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
433 * emacs.c: Don't include libxml/parser.h.
434 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
435 xmlCleanupParser directly.
437 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
439 2012-04-07 Eli Zaretskii <eliz@gnu.org>
441 * indent.c (Fvertical_motion): If there is a display string at
442 point, use it.vpos to compute how many lines to backtrack after
443 move_it_to point. (Bug#11133)
445 2012-04-06 Eli Zaretskii <eliz@gnu.org>
447 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
448 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
449 about subtle differences between FETCH_CHAR* and STRING_CHAR*
450 macros related to unification of CJK characters. For the details,
451 see the discussion following the message here:
452 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
454 2012-04-04 Chong Yidong <cyd@gnu.org>
456 * keyboard.c (Vdelayed_warnings_list): Doc fix.
458 2012-04-01 Eli Zaretskii <eliz@gnu.org>
460 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
461 instead of alloca. (Bug#11138)
463 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
465 * w32menu.c (is_simple_dialog): Properly check lisp types.
468 2012-03-31 Eli Zaretskii <eliz@gnu.org>
470 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
471 position we get to after a call to move_it_to fails the
472 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
473 only if we wind up in a string from display property. (Bug#11063)
475 * window.c (Fdelete_other_windows_internal): Invalidate the row
476 and column information about mouse highlight, so that redisplay
477 restores it after reallocating the glyph matrices. (Bug#7464)
479 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
480 string comes from a `display' text property, use the buffer
481 position of that property as if we actually saw that position in
483 (move_it_by_lines): Remove the assertion that
484 "it->current_x == 0 && it->hpos == 0" which can be legitimately
485 violated when there's a before-string at the beginning of a line.
488 2012-03-30 Eli Zaretskii <eliz@gnu.org>
490 * xdisp.c (append_space_for_newline): If the default face was
491 remapped, use the remapped face for the appended newline.
492 (extend_face_to_end_of_line): Use the remapped default face for
493 extending the face to the end of the line.
494 (display_line): Call extend_face_to_end_of_line when the default
495 face was remapped. (Bug#11068)
497 2012-03-29 Eli Zaretskii <eliz@gnu.org>
499 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
501 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
503 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
505 2012-03-27 Glenn Morris <rgm@gnu.org>
507 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
510 2012-03-26 Kenichi Handa <handa@m17n.org>
512 * dispextern.h (struct glyph): Fix previous change. Change the
513 bit length of glyphless.ch to 25 (Bug#11082).
515 2012-03-26 Chong Yidong <cyd@gnu.org>
517 * keyboard.c (Vselection_inhibit_update_commands): New variable.
518 (command_loop_1): Use it; inhibit selection update for
519 handle-select-window too (Bug#8996).
521 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
523 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
525 2012-03-25 Kenichi Handa <handa@m17n.org>
527 * dispextern.h (struct glyph): Change the bit length of
528 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
530 2012-03-24 Eli Zaretskii <eliz@gnu.org>
532 * s/ms-w32.h (tzname): Include time.h before redirecting to
533 _tzname. Fixes the MSVC build. (Bug#9960)
535 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
537 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
540 * xterm.c (XTread_socket): Only modify handling_signal if
541 !SYNC_INPUT. (Bug#11080)
543 2012-03-23 Eli Zaretskii <eliz@gnu.org>
545 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
546 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
547 when fetching a multibyte character consumes more bytes than
548 CHAR_BYTES returns, due to unification of CJK characters in
549 string_char. (Bug#11073)
551 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
553 * process.c (wait_reading_process_output): Handle pty disconnect
554 by refraining from sending oneself a SIGCHLD (bug#10933).
556 2012-03-22 Chong Yidong <cyd@gnu.org>
558 * dispextern.h (struct it): New member string_from_prefix_prop_p.
560 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
561 Mark string as coming from a prefix property.
562 (handle_face_prop): Use default face for prefix strings (Bug#4281).
563 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
565 2012-03-21 Chong Yidong <cyd@gnu.org>
567 * xfaces.c (Vface_remapping_alist): Doc fix.
569 2012-03-20 Eli Zaretskii <eliz@gnu.org>
571 * w32proc.c (Fw32_set_console_codepage)
572 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
575 2012-03-20 Chong Yidong <cyd@gnu.org>
577 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
578 to reflect default non-nil value of redisplay-dont-pause.
580 2012-03-19 Kenichi Handa <handa@m17n.org>
582 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
583 it fit in a valid range (Bug#11003).
585 2012-03-18 Eli Zaretskii <eliz@gnu.org>
587 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
588 that is not from display property, accept the row as a "cursor
589 row" if one of the string's character has a non-nil `cursor'
590 property. Fixes cursor positioning when there are newlines in
591 overlay strings, e.g. in icomplete.el. (Bug#11035)
593 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
595 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
597 2012-03-12 Chong Yidong <cyd@gnu.org>
599 * eval.c (inhibit_lisp_code): Rename from
600 inhibit_window_configuration_change_hook; move from window.c.
602 * xfns.c (unwind_create_frame_1, Fx_create_frame):
603 * window.c (run_window_configuration_change_hook)
604 (syms_of_window): Callers changed.
606 2012-03-11 Chong Yidong <cyd@gnu.org>
608 * keymap.c (Fkey_description): Doc fix (Bug#9700).
610 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
612 2012-03-10 Chong Yidong <cyd@gnu.org>
614 * frame.c (other_visible_frames): Don't assume the selected frame
615 is visible (Bug#10955).
617 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
619 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
621 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
623 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
624 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
627 2012-03-03 Glenn Morris <rgm@gnu.org>
629 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
631 2012-03-02 Eli Zaretskii <eliz@gnu.org>
633 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
634 position past the first glyph_row that ends at ZV. (Bug#10902)
635 (redisplay_window, next_element_from_string): Fix typos in
637 (redisplay_window): Pass to move_it_vertically the margin in
638 pixels, not in screen lines.
640 2012-03-02 Glenn Morris <rgm@gnu.org>
642 * buffer.c (buffer-list-update-hook): Doc fix.
644 2012-02-29 Eli Zaretskii <eliz@gnu.org>
646 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
647 push_it before setting up the iterator for the first overlay
648 string, even if we have an empty string loaded.
649 (next_overlay_string): If there's an empty string on the iterator
650 stack, pop the stack. (Bug#10903)
652 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
654 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
655 Suggested by Stefan Monnier in
656 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
657 * alloc.c (widen_to_Lisp_Object): New static function.
658 (mark_memory): Also mark Lisp_Objects by fetching pointer words
659 and widening them to Lisp_Objects. This would work even if
660 USE_LSB_TAG is defined and wide integers are used, which might
661 happen in a future version of Emacs.
663 2012-02-25 Chong Yidong <cyd@gnu.org>
665 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
668 * xselect.c (Fx_selection_exists_p): Doc fix.
669 (x_clipboard_manager_save_all): Print an informative message
670 before saving to clipboard manager.
672 2012-02-24 Chong Yidong <cyd@gnu.org>
674 * keyboard.c (process_special_events): Handle all X selection
675 requests in kbd_buffer, not just the next one (Bug#8869).
677 2012-02-23 Chong Yidong <cyd@gnu.org>
679 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
680 call when setting menu-bar-lines and tool-bar-lines parameters.
681 (unwind_create_frame_1): New helper function.
683 * window.c (inhibit_window_configuration_change_hook): New var.
684 (run_window_configuration_change_hook): Obey it.
685 (syms_of_window): Initialize it.
687 2012-02-22 Chong Yidong <cyd@gnu.org>
689 * xterm.c (x_draw_image_relief): Add missing type check for
690 Vtool_bar_button_margin (Bug#10743).
692 2012-02-21 Chong Yidong <cyd@gnu.org>
694 * fileio.c (Vfile_name_handler_alist): Doc fix.
696 * buffer.c (Fget_file_buffer): Protect against invalid file
697 handler return value.
699 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
701 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
702 when computing $valmask.
704 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
705 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
706 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
707 It's useless in that case, and it can cause problems on hosts
708 that allocate halves of EMACS_INT values separately.
709 Reported by Dan Horák. Diagnosed by Andreas Schwab in
710 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
711 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
712 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
713 it avoids undefined behavior on hosts where shifting right by more
714 than the word width has undefined behavior.
716 2012-02-19 Chong Yidong <cyd@gnu.org>
718 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
719 (Funhandled_file_name_directory, Ffile_name_as_directory)
720 (Fdirectory_file_name, Fexpand_file_name)
721 (Fsubstitute_in_file_name): Protect against invalid file handler
722 return values (Bug#10845).
724 2012-02-18 Eli Zaretskii <eliz@gnu.org>
726 * .gdbinit (pitx): Fix incorrect references to fields of the
729 2012-02-17 Chong Yidong <cyd@gnu.org>
731 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
733 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
735 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
736 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
738 2012-02-15 Chong Yidong <cyd@gnu.org>
740 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
741 marked as special. Also, starting docstrings with * is obsolete.
743 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
745 * gnutls.c (emacs_gnutls_write): Fix last change.
747 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
749 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
752 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
754 * keymap.c (Fsingle_key_description): Handle char ranges.
756 2012-02-12 Chong Yidong <cyd@gnu.org>
758 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
759 as that creates a dangerous corner case.
761 * window.c (Fdelete_window_internal): Invalidate the mouse
762 highlight (Bug#9904).
764 2012-02-12 Glenn Morris <rgm@gnu.org>
766 * xselect.c (Fx_own_selection_internal)
767 (Fx_get_selection_internal, Fx_disown_selection_internal)
768 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
769 * nsselect.m (Fx_own_selection_internal)
770 (Fx_disown_selection_internal, Fx_selection_exists_p)
771 (Fx_selection_owner_p, Fx_get_selection_internal):
772 Sync docs and argument specs with the xselect.c versions.
774 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
776 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
778 2012-02-11 Eli Zaretskii <eliz@gnu.org>
780 * w32select.c (Fx_selection_exists_p): Sync doc string and
781 argument list with xselect.c. (Bug#10783)
783 * w16select.c (Fx_selection_exists_p): Sync doc string and
784 argument list with xselect.c. (Bug#10783)
786 2012-02-10 Glenn Morris <rgm@gnu.org>
788 * fns.c (Fsecure_hash): Doc fix.
790 2012-02-09 Kenichi Handa <handa@m17n.org>
792 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
794 2012-02-07 Chong Yidong <cyd@gnu.org>
796 * buffer.c (Fbuffer_local_variables)
797 (buffer_lisp_local_variables): Handle unbound vars correctly;
798 don't let Qunbound leak into Lisp.
800 2012-02-07 Glenn Morris <rgm@gnu.org>
802 * image.c (Fimagemagick_types): Doc fix.
804 * image.c (imagemagick-render-type): Change it from a lisp object
805 to an integer. Move the doc here from the lisp manual.
806 Treat all values not equal to 0 the same.
808 2012-02-06 Chong Yidong <cyd@gnu.org>
810 * doc.c (store_function_docstring): Avoid applying docstring of
811 alias to base function (Bug#2603).
813 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
815 * .gdbinit (pp1, pv1): Remove redundant defines.
818 2012-02-04 Chong Yidong <cyd@gnu.org>
820 * nsterm.m: Declare a global (Bug#10694).
822 2012-02-04 Eli Zaretskii <eliz@gnu.org>
824 * w32.c (get_emacs_configuration_options):
825 Include --enable-checking, if specified, in the return value.
827 2012-02-04 Martin Rudalics <rudalics@gmx.at>
829 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
830 after rounding frame sizes. (Bug#9723)
832 2012-02-04 Eli Zaretskii <eliz@gnu.org>
834 * keyboard.c (adjust_point_for_property): Don't position point
835 before BEGV. (Bug#10696)
837 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
839 Handle overflow when computing char display width (Bug#9496).
840 * character.c (char_width): Return EMACS_INT, not int.
841 (char_width, c_string_width): Check for overflow when
842 computing the width; this is possible now that individual
843 characters can have unbounded width. Problem introduced
844 by merge from Emacs 23 on 2012-01-19.
846 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
848 * dbusbind.c (Fdbus_register_method): Mention the return value
849 :ignore in the docstring.
851 2012-02-02 Glenn Morris <rgm@gnu.org>
853 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
855 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
856 Unconditionally set to t. (Bug#10673)
857 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
858 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
859 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
861 2012-02-02 Kenichi Handa <handa@m17n.org>
863 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
864 0, do not call append_composite_glyph.
866 2012-02-02 Kenichi Handa <handa@m17n.org>
868 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
870 (x_produce_glyphs): If the component of a composition is a null
871 string, set it->pixel_width to 1 to avoid zero-width glyph.
873 2012-02-01 Eli Zaretskii <eliz@gnu.org>
875 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
876 first 2 arguments are identical. This makes inserting large
877 output from a subprocess an order of magnitude faster on
878 MS-Windows, where all sbrk'ed memory is always contiguous.
880 2012-01-31 Glenn Morris <rgm@gnu.org>
882 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
883 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
884 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
886 2012-01-29 Glenn Morris <rgm@gnu.org>
888 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
890 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
892 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
894 2012-01-28 Chong Yidong <cyd@gnu.org>
896 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
898 2012-01-26 Chong Yidong <cyd@gnu.org>
900 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
902 * search.c (Fsearch_forward, Fsearch_backward): Document negative
903 repeat counts (Bug#10507).
905 2012-01-26 Glenn Morris <rgm@gnu.org>
907 * lread.c (syms_of_lread): Doc fix.
909 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
911 * coding.c (encode_designation_at_bol): Change return value to
914 2012-01-25 Chong Yidong <cyd@gnu.org>
916 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
918 2012-01-21 Chong Yidong <cyd@gnu.org>
920 * floatfns.c (Fcopysign): Make the second argument non-optional,
921 since nil is not allowed anyway.
923 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
925 * process.c (read_process_output): Use p instead of XPROCESS (proc).
926 (send_process): Likewise.
928 2012-01-19 Martin Rudalics <rudalics@gmx.at>
930 * window.c (save_window_save, Fcurrent_window_configuration)
931 (Vwindow_persistent_parameters): Do not use Qstate.
934 2012-01-19 Kenichi Handa <handa@m17n.org>
936 * character.c (char_width): New function.
937 (Fchar_width, c_string_width, lisp_string_width):
938 Use char_width (Bug#9496).
940 2012-01-16 Martin Rudalics <rudalics@gmx.at>
942 * window.c (Vwindow_persistent_parameters): New variable.
943 (Fset_window_configuration, save_window_save): Handle persistent
946 2012-01-14 Eli Zaretskii <eliz@gnu.org>
948 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
949 thrashing the stack of the thread. (Bug#9087)
951 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
953 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
955 2012-01-11 Eli Zaretskii <eliz@gnu.org>
957 * xdisp.c (rows_from_pos_range): Handle the case where the
958 highlight ends on a newline. (Bug#10464)
959 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
960 he end column for display of highlight that ends on a newline
963 2012-01-11 Glenn Morris <rgm@gnu.org>
965 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
966 from load-path also when installation-directory is nil. (Bug#10208)
968 2012-01-10 Glenn Morris <rgm@gnu.org>
970 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
972 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
973 Update template values to be closer to their typical values these days.
975 2012-01-09 Eli Zaretskii <eliz@gnu.org>
977 * xdisp.c (rows_from_pos_range): Accept additional argument
978 DISP_STRING, and accept any glyph in a row whose object is that
979 string as eligible for mouse highlight. Fixes mouse highlight of
980 display strings from overlays. (Bug#10464)
982 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
984 emacs: fix an auto-save permissions race condition (Bug#10400)
985 * fileio.c (auto_saving_dir_umask): New static var.
986 (Fmake_directory_internal): Use it.
987 (do_auto_save_make_dir): Set it, instead of invoking chmod after
988 creating the directory. The old code temporarily assigns
989 too-generous permissions to the directory.
990 (do_auto_save_eh): Clear it.
991 (Fdo_auto_save): Catch all errors, not just file errors, so
992 that the var is always cleared.
994 2012-01-07 Eli Zaretskii <eliz@gnu.org>
996 * search.c (scan_buffer): Pass character positions to
997 know_region_cache, not byte positions. (Bug#6540)
999 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1001 * w32.c (sys_rename): Report EXDEV when rename of a directory
1002 fails because the target is on another logical disk. (Bug#10284)
1004 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1006 * xterm.c (x_embed_request_focus): New function.
1008 * xterm.h: Add prototype.
1010 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1012 2012-01-05 Glenn Morris <rgm@gnu.org>
1014 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1016 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1018 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1019 Load gnutls_transport_set_lowat only if GnuTLS version is below
1021 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1022 GnuTLS versions below 2.11.1.
1024 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1026 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1027 to the doc string advising against its use for altering the way
1028 windows are scrolled.
1030 2011-12-28 Kenichi Handa <handa@m17n.org>
1032 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1033 coding-system ASCII compatible only when it does not produce BOM
1034 on encoding (Bug#10383).
1036 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1038 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1040 (create_and_show_popup_menu): Always use menu_position_func for
1043 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1045 * callint.c (Fcall_interactively): Don't truncate prompt string.
1047 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1049 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1050 property that ends at ZV, so that the bidi iteration could be
1051 resumed from there (after widening). (Bug#10360)
1053 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1055 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1057 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1059 * nsterm.m (x_free_frame_resources):
1060 Release f->output_data.ns->miniimage.
1061 (ns_index_color): Fix indentation. Do not retain
1062 color_table->colors[i].
1064 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1067 * nsfns.m (x_set_background_color): Assign return value from
1068 ns_index_color to face-background instead of NSColor*.
1069 (ns_implicitly_set_icon_type): Fix indentation.
1070 Change assignment in for loop to comparison.
1072 * emacs.c (ns_pool): New variable.
1073 (main): Assign ns_pool.
1074 (Fkill_emacs): Call ns_release_autorelease_pool.
1076 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1077 autorelease fdesc, release fdAttrs and tdict.
1078 (ns_get_covering_families): Release charset.
1079 (ns_findfonts): Release NSFontDescriptor created with new.
1080 (ns_uni_to_glyphs): Fix indentation.
1081 (setString): Release attrStr before assigning new value.
1083 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1085 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1087 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1088 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1090 2011-12-18 David Reitter <reitter@cmu.edu>
1092 * nsterm.m (ns_term_init): Subscribe for notifications
1093 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1094 to method trackingNotification in EmacsMenu.
1096 * nsmenu.m (trackingMenu): New variable.
1097 (trackingNotification): New method (from Aquamacs).
1098 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1099 from Aquamacs (Bug#7030).
1101 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1103 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1104 (symbol_to_nsstring): Fix indentation.
1105 (ns_symbol_to_pb): New function.
1106 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1107 (Fns_rotate_cut_buffers_internal): Remove.
1108 (Fns_store_selection_internal): Rename from
1109 Fns_store_cut_buffer_internal.
1110 (ns_get_foreign_selection, Fx_own_selection_internal)
1111 (Fx_disown_selection_internal, Fx_selection_exists_p)
1112 (Fns_get_selection_internal, Fns_store_selection_internal):
1113 Use ns_symbol_to_pb and check if return value is nil.
1114 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1115 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1116 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1117 renamed to Sns_store_selection_internal.
1118 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1119 and remove this function.
1120 (ns_handle_selection_clear): Remove, never used.
1121 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1124 2011-12-17 Ken Brown <kbrown@cornell.edu>
1126 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1127 GID is unknown (Bug#10257).
1129 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1131 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1132 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1133 which caused a build failure on GNU/Linux IA-64. This problem was
1134 introduced by my 2011-10-07 patch.
1136 2011-12-15 Juri Linkov <juri@jurta.org>
1138 * image.c (imagemagick_error): New function. (Bug#10112)
1139 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1140 Use `imagemagick_error' where ImageMagick functions return
1142 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1145 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1147 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1148 fill background (Bug#8992).
1150 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1152 * window.c (Vwindow_combination_resize)
1153 (Vwindow_combination_limit): Use t instead of non-nil in
1155 (Vrecenter_redisplay): Add first sentence of doc-string on
1157 (Frecenter): Fix doc-string typo.
1159 2011-12-11 Kenichi Handa <handa@m17n.org>
1161 * coding.c (Funencodable_char_position): Pay attention to the
1162 buffer text relocation (Bug#9389).
1164 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1166 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1167 gtk_init (Bug#10100).
1169 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1171 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1172 IT->string is nil. (Bug#10263)
1174 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1176 * nsterm.h (x_free_frame_resources): Declare.
1178 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1179 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1181 * nsterm.h (ns_get_defaults_value): Declare.
1183 * nsterm.m (ns_default): Call ns_get_defaults_value.
1185 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1187 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1190 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1192 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1193 that where the value of an _OBJC_* symbol points to is in the .bss
1194 section (Bug#10240).
1196 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1198 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1199 after the loop to call ccl_driver at least once (Bug#8619).
1201 2011-12-08 Kenichi Handa <handa@m17n.org>
1203 * ftfont.c (get_adstyle_property): Fix previous change
1206 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1208 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1209 dirs from the default value of EMACSLOADPATH (bug#10208).
1211 2011-12-07 Glenn Morris <rgm@gnu.org>
1213 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1214 installation and source directories as well. (Bug#10208)
1216 2011-12-06 Chong Yidong <cyd@gnu.org>
1218 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1220 2011-12-06 Glenn Morris <rgm@gnu.org>
1222 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1223 as an error, not just -1. (Bug#10217)
1225 2011-12-05 Chong Yidong <cyd@gnu.org>
1227 * keyboard.c (process_special_events): New function.
1228 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1230 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1232 * coding.c (encode_designation_at_bol): Don't use uninitialized
1233 local variable (Bug#9318).
1235 2011-12-05 Kenichi Handa <handa@m17n.org>
1237 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1238 return Qnil (Bug#8046, Bug#10193).
1240 2011-12-05 Kenichi Handa <handa@m17n.org>
1242 * coding.c (encode_designation_at_bol): New args charbuf_end and
1243 dst. Return the number of produced bytes. Callers changed.
1244 (coding_set_source): Return how many bytes coding->source was
1246 (coding_set_destination): Return how many bytes
1247 coding->destination was relocated.
1248 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1249 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1251 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1253 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1254 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1257 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1259 The following changes are to fix Bug#9318.
1261 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1262 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1263 (encode_coding_iso_2022, encode_coding_sjis)
1264 (encode_coding_big5, encode_coding_charset): Use the above macros.
1266 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1268 * lisp.h (process_quit_flag): Fix external declaration.
1270 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1272 Don't macro-inline non-performance-critical code.
1273 * eval.c (process_quit_flag): New function.
1274 * lisp.h (QUIT): Use it.
1276 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1278 * nsfns.m (get_geometry_from_preferences): New function.
1279 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1281 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1283 * emacs.c (Qkill_emacs): Define.
1284 (syms_of_emacs): Initialize it.
1285 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1286 Qquit_flag to `kill-emacs' instead.
1287 (quit_throw_to_read_char): Add parameter `from_signal'.
1288 All callers changed. Call Fkill_emacs if requested and safe.
1289 * lisp.h (QUIT): Call Fkill_emacs if requested.
1291 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1293 * widget.c (update_wm_hints): Return if wmshell is null.
1294 (widget_update_wm_size_hints): New function.
1296 * widget.h (widget_update_wm_size_hints): Declare.
1298 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1299 widget_update_wm_size_hints (Bug#10104).
1301 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1303 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1304 before a newline, prepare the bidi iterator for consuming the
1305 newline, and keep the current paragraph direction. (Bug#10183)
1306 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1308 2011-12-02 Juri Linkov <juri@jurta.org>
1310 * search.c (Fword_search_regexp): New Lisp function created from
1311 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1312 (Fword_search_backward, Fword_search_forward)
1313 (Fword_search_backward_lax, Fword_search_forward_lax):
1314 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1315 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1317 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1319 * fileio.c (Finsert_file_contents): Move after-change-function call
1320 to before the "handled:" label, since all "goto handled" appear in
1321 cases where the *-change-functions have already been properly called
1324 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1326 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1327 waiting for input. (Bug#10169)
1329 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1331 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1332 verifies glyph row's hash code--we have just reallocated the
1333 glyphs, so their contents can be complete garbage. (Bug#10164)
1335 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1337 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1339 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1341 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1342 attributes are tested _before_ calling verify_row_hash, to protect
1343 against GCC re-ordering of the tests. (Bug#10164)
1345 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1347 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1349 * xterm.c (handle_one_xevent): Only set async_visible and friends
1350 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1351 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1352 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1354 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1356 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1357 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1358 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1359 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1360 All uses changed to use GCPRO1 etc.
1361 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1362 Revert to old implementation (i.e., before 2011-03-11).
1364 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1366 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1367 of scroll runs so as to avoid assigning disabled bogus rows and
1368 unnecessary graphics copy operations.
1370 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1372 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1373 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1374 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1375 (malloc, free, realloc, calloc): Redirect to e_* only when
1378 * lisp.h (GCTYPEBITS): Move before first use.
1379 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1380 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1381 this macro definition.
1383 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1386 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1388 * gtkutil.c (xg_create_frame_widgets):
1389 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1390 present with Gtk+ 2.0.
1392 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1394 * fileio.c (Finsert_file_contents): Undo previous change; see
1395 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1397 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1399 Rename locals to avoid shadowing.
1400 * fileio.c (Finsert_file_contents):
1401 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1402 * process.c (wait_reading_process_output):
1403 Rename inner 'proc' to 'p' to avoid shadowing.
1404 Indent for consistency with usual Emacs style.
1406 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1408 * xdisp.c (redisplay_window): If cursor row is not fully visible
1409 after recentering, and scroll-conservatively is set to a large
1410 number, scroll window by a few more lines to make the cursor fully
1411 visible and out of scroll-margin. (Bug#10105)
1412 (start_display): Don't move to the next line if the display should
1413 start at a newline that is part of a display vector or an overlay
1416 2011-11-24 Juri Linkov <juri@jurta.org>
1418 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1419 after the `MagickPingImage' call. (Bug#10112)
1421 2011-11-23 Chong Yidong <cyd@gnu.org>
1423 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1425 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1427 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1428 making another buffer current. (Bug#10114)
1430 2011-11-23 Glenn Morris <rgm@gnu.org>
1432 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1434 2011-11-23 Chong Yidong <cyd@gnu.org>
1436 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1437 using it (Bug#5984).
1439 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1441 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1442 and header-lines, as they don't have one computed for them.
1445 * .gdbinit (prow): Make displayed values more self-explaining.
1446 Add row's hash code.
1448 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1450 * process.c (wait_reading_process_output): Fix asynchrounous
1451 GnuTLS socket handling on some versions of the GnuTLS library.
1452 (wait_reading_process_output): Add comment and URL.
1454 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1456 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1458 2011-11-21 Chong Yidong <cyd@gnu.org>
1460 * window.c (Fnext_window, Fprevious_window): Doc fix.
1462 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1464 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1466 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1468 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1470 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1472 * window.c (Fset_window_combination_limit): Rename argument
1474 (Vwindow_combination_limit): Remove "status" from doc-string.
1476 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1478 * m/ibms390.h: Remove.
1479 * m/ibms390x.h: Don't include "ibms390.h".
1481 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1483 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1484 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1486 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1488 * casetab.c (Fset_case_table):
1489 * charset.c (Fcharset_after): Fix typos.
1491 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1493 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1494 Otherwise, valgrind does not work on some platforms.
1495 Problem reported by Andreas Schwab in
1496 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1497 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1498 is set, removing the need for VIRT_ADDRESS_VARIES.
1499 (PURE_P): Use a more-efficient implementation that needs just one
1500 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1501 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1502 to 4 (xorl, subq, cmpq, setbe).
1503 * alloc.c (pure): Always extern now, since that's the
1504 VIRT_ADDR_VARIES behavior.
1505 (PURE_POINTER_P): Use a single comparison, not two, for
1506 consistency with the new puresize.h.
1507 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1508 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1509 Remove VIRT_ADDR_VARIES no longer needed.
1511 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1513 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1514 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1515 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1516 behave as if the cursor position were at the window margin.
1518 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1519 and the cursor position is out of bounds, behave as if the cursor
1520 position were at the window margin. (Bug#10075)
1522 2011-11-18 Chong Yidong <cyd@gnu.org>
1524 * window.c (Fwindow_combination_limit): Make first argument
1525 non-optional, since it is meaningless for live windows like the
1528 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1530 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1532 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1534 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1535 (graft_intervals_into_buffer): Simplify.
1537 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1539 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1540 hash values of the two rows.
1541 (copy_row_except_pointers): Preserve the used[] arrays and the
1542 hash values of the two rows. (Bug#10035)
1543 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1545 * xdisp.c (row_hash): New function, body extracted from
1546 compute_line_metrics.
1547 (compute_line_metrics): Call row_hash, instead of computing the
1550 * dispnew.c (verify_row_hash): Call row_hash for computing the
1551 hash code of a row, instead of duplicating code from xdisp.c.
1553 * dispextern.h (row_hash): Add prototype.
1555 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1557 * frame.c (delete_frame): Don't delete the terminal when the last
1558 X frame is closed if emacs is built with GTK toolkit.
1560 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1562 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1564 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1566 * window.c (Vwindow_splits): Rename to
1567 Vwindow_combination_resize. Suggested by Juri Linkov.
1568 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1571 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1573 * nsfns.m (Fns_font_name):
1574 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1576 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1578 * window.h (window): Rename slot "nest" to "combination_limit".
1579 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1580 (Fset_window_nest): Rename to Fset_window_combination_limit.
1581 (Vwindow_nest): Rename to Vwindow_combination_limit.
1582 (recombine_windows, make_parent_window, make_window)
1583 (Fsplit_window_internal, saved_window)
1584 (Fset_window_configuration, save_window_save): Rename all
1585 occurrences of window_nest to window_combination_limit.
1587 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1589 * image.c (imagemagick_load_image): Fix typo.
1591 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1593 * xdisp.c (display_line): Move the call to
1594 highlight_trailing_whitespace before the call to
1595 compute_line_metrics, since the latter needs to see the final
1596 faces of all the glyphs to compute ROW's hash value.
1597 Fixes assertion violations in row_equal_p. (Bug#10035)
1599 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1601 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1602 just return (bug#10044).
1604 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1606 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1607 with user-defined heap size. Bump the default size of the temacs
1608 heap to 27MB, to avoid memory warning when running temacs.
1609 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1611 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1612 current_matrix and desired_matrix. (Bug#9990)
1613 (verify_row_hash) [XASSERTS]: New function.
1614 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1615 that the hash value of glyph rows is correct.
1617 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1619 * window.h (window): Remove splits slot.
1620 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1621 (Fdelete_other_windows_internal, make_parent_window)
1622 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1623 (Fset_window_configuration, save_window_save): Don't deal with
1624 split status of windows.
1625 (saved_window): Remove splits slot.
1626 (Vwindow_splits): Rewrite doc-string.
1628 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1630 * xfns.c (unwind_create_frame):
1631 * nsfns.m (unwind_create_frame):
1632 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1633 Vframe_list (Bug#9999).
1635 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1637 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1639 2011-11-11 Kenichi Handa <handa@m17n.org>
1641 * callproc.c (Fcall_process): Set the member dst_multibyte of
1644 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1646 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1647 avoid a crash (bug#9496).
1649 2011-11-09 Chong Yidong <cyd@gnu.org>
1651 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1652 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1654 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1656 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1658 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1660 Avoid some portability problems by eschewing 'extern inline' functions.
1661 The trivial performance wins aren't worth the portability hassles; see
1662 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1664 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1665 (window_box_width, window_box_left, window_box_left_offset)
1666 (window_box_right, window_box_right_offset): Undo previous change,
1667 by removing the "extern"s.
1668 * intervals.c (adjust_intervals_for_insertion)
1669 (adjust_intervals_for_deletion): Undo previous change,
1670 making these static again.
1671 (offset_intervals, temp_set_point_both, temp_set_point)
1672 (copy_intervals_to_string): No longer inline.
1673 * xdisp.c (window_text_bottom_y, window_box_width)
1674 (window_box_height, window_box_left_offset)
1675 (window_box_right_offset, window_box_left, window_box_right)
1676 (window_box): No longer inline.
1678 2011-11-08 Chong Yidong <cyd@gnu.org>
1680 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1681 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1682 Signal an error if not a live window.
1683 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1684 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1686 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1688 * lisp.h (syms_of_abbrev): Remove declaration.
1689 Reported by CHENG Gao <chenggao@royau.me>.
1691 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1693 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1694 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1695 of temacs in GUI mode.
1697 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1699 * window.h: Declare delete_all_child_windows instead of
1700 delete_all_subwindows.
1701 * window.c (Fwindow_nest, Fset_window_nest)
1702 (Fset_window_new_total, Fset_window_new_normal)
1703 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1704 (delete_all_subwindows): Rename to delete_all_child_windows.
1705 (Fdelete_other_windows_internal, Fset_window_configuration):
1706 Call delete_all_child_windows instead of delete_all_subwindows.
1707 * frame.c (delete_frame): Call delete_all_child_windows instead
1708 of delete_all_subwindows.
1710 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1712 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1713 This is also needed for porting to any host where GC_MARK_STACK is
1714 not GC_MAKE_GCPROS_NOOPS.
1715 (which_symbols): Use it.
1717 2011-11-07 Kenichi Handa <handa@m17n.org>
1719 * coding.c (coding_set_destination): Check coding->src_pos only
1720 when coding->src_object is a buffer (bug#9910).
1722 * process.c (send_process): Set the member src_multibyte of coding
1723 to 0 (bug#9911) when sending a unibyte text.
1725 * callproc.c (Fcall_process): Set the member src_multibyte of
1726 process_coding to 0 (bug#9912).
1728 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1730 * xmenu.c (cleanup_widget_value_tree): New function.
1731 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1732 calling free_menubar_widget_value_tree directly (Bug#9830).
1734 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1736 Fix some portability problems with 'inline'.
1737 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1738 (window_box_width, window_box_left, window_box_left_offset)
1739 (window_box_right, window_box_right_offset): Declare extern.
1740 Otherwise, these inline functions do not conform to C99 and
1741 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1742 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1743 * intervals.c (adjust_intervals_for_insertion)
1744 (adjust_intervals_for_deletion): Now extern, because otherwise the
1745 extern inline functions 'offset_intervals' couldn't refer to it.
1746 (static_offset_intervals): Remove.
1747 (offset_intervals): Rewrite using the old contents of
1748 static_offset_intervals. The old version didn't conform to C99
1749 because an extern inline function contained a reference to an
1750 identifier with static linkage.
1752 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1754 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1757 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1759 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1760 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1761 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1762 return Qleft_to_right.
1764 2011-11-06 Chong Yidong <cyd@gnu.org>
1766 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1767 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1768 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1769 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1770 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1771 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1772 (Fwindow_vscroll): Doc fix.
1773 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1774 argument, since it makes no sense to pass a live window and for
1775 consistency with window-child.
1777 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1779 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1782 2011-11-05 Jason Rumney <jasonr@gnu.org>
1784 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1785 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1787 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1788 bitwise arithmetic preventing use of unicode-sip and non-truetype
1791 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1793 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1796 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1797 initialization code to keep similarity to xfns.c after changes
1800 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1802 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1803 (unwind_create_frame): New function (Bug#9943).
1804 (Fx_create_frame): Restructure code to be more similar to the one in
1805 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1806 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1807 Move terminal->reference_count++ just before making the frame official
1810 * nsterm.m (x_free_frame_resources): New function.
1811 (x_destroy_window): Move code to x_free_frame_resources.
1813 * xfns.c (unwind_create_frame): Fix comment.
1814 (Fx_create_frame, x_create_tip_frame):
1815 Move terminal->reference_count++ just before making the frame
1816 official. Move initialization of image_cache_refcount and
1817 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1819 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1821 Support MSVC build with newer versions of Visual Studio.
1822 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1823 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1826 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1827 which are not supported by MSVC.
1828 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1829 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1831 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1833 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1835 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1837 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1839 Support MSVC build with newer versions of Visual Studio.
1840 * w32.c: Don't include w32api.h for MSVC.
1841 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1843 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1844 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1845 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1846 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1848 (alloca) [_MSC_VER]: Define to _alloca.
1850 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1852 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1854 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1856 * xdisp.c (note_mouse_highlight): If either of
1857 previous/next-single-property-change returns nil, treat that as
1858 the beginning or the end of the buffer. (Bug#9955)
1860 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1862 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1863 label is not null (Bug#9951).
1864 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1867 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1869 * window.c (Fwindow_body_size): Mention in the doc string that the
1870 return value is in frame's canonical units. (Bug#9949)
1872 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1874 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1876 * w32fns.c (unwind_create_frame): If needed, free the glyph
1877 matrices of the partially constructed frame. (Bug#9943)
1878 * xfns.c (unwind_create_frame): Likewise.
1880 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1882 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1883 Don't stop backward scan on the continuation glyph, even though
1884 its CHARPOS is positive.
1885 (mouse_face_from_buffer_pos, note_mouse_highlight):
1886 Rename cover_string to disp_string.
1888 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1890 * window.c (temp_output_buffer_show): Don't use
1891 Vtemp_buffer_show_specifiers.
1892 (Vtemp_buffer_show_specifiers): Remove unused variable.
1894 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1896 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1897 past the beginning of the current glyph matrix.
1899 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1901 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1902 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1903 HAVE_GTK3 (Bug#9869).
1905 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1906 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1908 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1910 * xterm.c: Declare x_handle_net_wm_state to return int.
1911 (handle_one_xevent): Check if we are iconified but don't have
1912 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1913 (get_current_wm_state): Return non-zero if not hidden,
1914 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1915 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1916 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1917 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1919 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1921 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1922 so that this new function doesn't get optimized away by a
1923 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1925 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1927 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1929 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1931 Fix the `xbytecode' command.
1932 * .gdbinit (xprintbytestr): New command.
1933 (xwhichsymbols): Rename from `which'; all callers changed.
1934 (xbytecode): Print the byte-code string as well.
1936 2011-10-29 Kim Storm <storm@cua.dk>
1938 * alloc.c (which_symbols): New function.
1940 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1942 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1945 2011-10-29 Glenn Morris <rgm@gnu.org>
1947 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1948 Not clear what it was for, and it causes various bugs. (Bug#9839)
1950 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1952 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1953 possible random value that matches one of those tested as
1954 condition to clear the mouse face.
1956 2011-10-28 Chong Yidong <cyd@gnu.org>
1958 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1960 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1962 * window.c (make_window): Initialize phys_cursor_on_p.
1964 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1966 * lisp.h (struct Lisp_Symbol): Update comments.
1968 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1970 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1972 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1974 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1975 <oslsachem@gmail.com> for helping to debug this.
1977 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1978 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1979 (g_b_init_get_glyph_outline_w): New static variables.
1980 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1981 (GetGlyphOutlineW_Proc): New typedefs.
1982 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1983 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1985 (w32font_open_internal, compute_metrics):
1986 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1987 instead of calling the "wide" APIs directly.
1989 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1991 * w32.h (syms_of_w32font): Add prototype.
1993 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1995 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1996 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1997 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1998 (Fmove_to_window_line): Doc fix.
2000 2011-10-27 Chong Yidong <cyd@gnu.org>
2002 * process.c (make_process): Set gnutls_state to NULL.
2004 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2005 non-NULL, regardless of GNUTLS_INITSTAGE.
2006 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2007 an error. Set process slots as soon as we allocate them.
2009 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2011 2011-10-27 Chong Yidong <cyd@gnu.org>
2013 * gnutls.c (emacs_gnutls_deinit): New function.
2014 Deallocate credentials structures as well as calling gnutls_deinit.
2015 (Fgnutls_deinit, Fgnutls_boot): Use it.
2017 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2018 (deactivate_process): Call emacs_gnutls_deinit.
2020 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2022 * image.c (x_create_x_image_and_pixmap):
2023 * w32.c (sys_rename, w32_delayed_load):
2024 * w32font.c (fill_in_logfont):
2025 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2027 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2029 * w32fns.c (w32_default_color_map): New function,
2030 extracted from Fw32_default_color_map.
2031 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2033 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2035 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2037 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2039 * keyboard.c (test_undefined): New function (bug#9751).
2040 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2042 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2044 * sysdep.c (init_sys_modes): Fix the check for the controlling
2045 terminal (Bug#6649).
2047 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2049 * dispextern.h (struct bidi_it): New member next_en_type.
2051 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2052 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2053 current character, check also for next_en_type being WEAK_EN.
2054 (bidi_resolve_weak): Don't enter the expensive loop if the current
2055 position is before next_en_pos. Record the bidi type of the first
2056 non-ET, non-BN character we find, in addition to its position.
2057 (bidi_level_of_next_char): Invalidate next_en_type when
2058 next_en_pos is over-stepped.
2060 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2062 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2063 * editfns.c: Rewrite current-time-zone so that it invokes
2064 the equivalent of (format-time-string "%Z") to get the time zone name.
2065 This fixes a bug when the time zone name contains characters that
2066 need converting from the system time locale to Emacs internal format.
2067 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2068 that patch fixed format-time-string to do the conversion, but
2069 I forgot to fix current-time-zone.
2070 (format_time_string): New function, containing most of
2071 what Fformat_time_string used to contain.
2072 (Fformat_time_string): Rewrite in terms of format_time_string.
2073 This doesn't change this function's behavior.
2074 (current-time-zone): Rewrite to use format_time_string.
2075 This fixes the bug reported by Michael Schierl in
2076 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2077 Jason Rumney's 2007-06-07 change worked around this bug, but
2079 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2081 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2083 * xdisp.c (start_display): If the character at POS is displayed
2084 via a display vector, reset IT->current.dpvec_index to zero.
2085 (try_window_reusing_current_matrix): If a line ends in a display
2086 vector or the next line starts in a display vector, continue
2087 redrawing the window even though the character position of
2088 start_row was reached.
2091 2011-10-18 Chong Yidong <cyd@gnu.org>
2093 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2094 with nobreak-char-display too.
2096 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2098 Fix part 3 of bug#9771.
2099 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2100 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2101 non-neutral characters if the current character is a paragraph
2102 separator (a.k.a. Newline). This avoids running the same
2103 expensive loop twice, once when we consume the preceding newline
2104 and the other time when the line actually needs to be displayed.
2105 Avoid the loop when we see neutrals on the base embedding level
2106 following a character whose directionality is the same as the
2107 paragraph's. This avoids running the expensive loop when a line
2108 ends in a long sequence of neutrals, like control characters.
2109 Add assertion against STRONG_AL type. Slightly rearrange code
2110 that determines the type of a neutral given the first non-neutral
2112 (bidi_level_of_next_char): Set next_en_pos to zero when
2113 invalidating its info.
2115 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2117 * xdisp.c (push_display_prop): Determine whether to record string
2118 or buffer position by IT->string, not by IT->method. Allow
2119 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2120 (move_it_vertically_backward): Don't look for character position
2121 immediately after the newline when in a continuation line.
2124 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2126 * window.c (coordinates_in_window): Rewrite and delabelize
2127 vertical border check. (Bug#5357) (Bug#9618)
2129 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2131 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2132 errors in XSetWindowBorder (bug#9310).
2134 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2136 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2137 avoid crash when xmalloc overrun checking is enabled.
2139 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2141 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2142 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2143 cursor motion with <left> and <right> arrow keys.
2145 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2146 some callers set that themselves.
2148 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2150 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2151 display string and the previous row comes from the same string and
2152 is empty. (Bug#9739) (Bug#9738)
2154 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2156 * doc.c (get_doc_string): Encode file name (bug#9735).
2158 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2160 * bidi.c (bidi_level_of_next_char):
2161 * xdisp.c (get_visually_first_element): Remove old incorrect
2162 comments regarding the Unicode Line Separator character.
2164 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2166 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2168 * alloc.c (Fgc_status): Do not access beyond zombies array
2169 boundary if nzombies > MAX_ZOMBIES.
2170 * alloc.c (dump_zombies): Add missing format specifier.
2172 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2174 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2175 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2177 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2178 Some packages use them to denote characters with modifiers.
2180 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2182 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2183 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2184 matching a pp-number. Rename parameter var to var1.
2186 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2188 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2190 2011-10-08 Glenn Morris <rgm@gnu.org>
2192 * callint.c (Fcall_interactively): Give a more explicit error for the
2193 'c' case with a non-character input. (Bug#8479)
2195 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2197 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2199 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2200 lines that are hscrolled on the left.
2202 * dispnew.c (buffer_posn_from_coords): Account for a possible
2203 presence of header-line. (Bug#4426)
2205 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2207 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2208 Don't advertise functionality which we discourage or doesn't work.
2210 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2212 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2213 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2214 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2215 this makes Emacs dump core during garbage collection on rare
2216 occasions. sizeof is obviously inferior to offsetof here, so
2217 stick with offsetof.
2218 (GC_POINTER_ALIGNMENT): New macro.
2219 (mark_memory): Omit 3rd (offset) arg; caller changed.
2220 Don't assume EMACS_INT alignment is the same as pointer alignment.
2222 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2224 * keyboard.c (read_key_sequence_remapped): New var.
2225 (read_key_sequence): Compute remapping in the right buffer.
2226 (command_loop_1): Use read_key_sequence's remapping directly.
2228 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2230 * dired.c (file_name_completion): Don't expand file name.
2231 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2232 before checking file name handler.
2234 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2235 they've been requested explicitly (bug#9591).
2237 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2239 * keymap.c (Fsingle_key_description): Use make_specified_string
2240 instead of build_string to build string from push_key_description.
2243 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2245 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2246 This fixes a Y2038 bug on 64-bit hosts.
2247 * buffer.c (reset_buffer):
2248 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2249 (Fclear_buffer_auto_save_failure):
2250 Use 0, not -1, to represent an unset failure time, since time_t
2251 might not be signed.
2253 Remove dependency on glibc malloc internals.
2254 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2255 Move back here from lisp.h, but with their new implementations.
2256 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2257 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2258 * charset.c (charset_table_init): New static var.
2259 (syms_of_charset): Use it instead of xmalloc. This removes a
2260 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2261 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2262 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2263 Move back to alloc.c.
2264 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2265 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2267 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2269 * nsterm.m (windowDidResize): Call x_set_window_size only when
2270 ns_in_resize is true. Otherwise set pixelwidth/height and
2271 call change_frame_size (Bug#9628).
2273 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2275 Port --enable-checking=all to Fedora 14 x86-64.
2276 * charset.c (syms_of_charset): Also account for glibc malloc's
2277 internal overhead when calculating the initial malloc maximum.
2279 Port --enable-checking=all to Fedora 14 x86.
2280 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2282 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2283 (overrun_check_realloc, overrun_check_free):
2284 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2285 That way, xmalloc returns a properly-aligned pointer even if
2286 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2287 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2288 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2289 into account when calculating the initial malloc maximum.
2290 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2291 Move here from alloc.c, so that charset.c can use it too.
2292 Properly align; the old code wasn't right for common 32-bit hosts
2293 when configured with --enable-checking=all.
2294 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2295 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2297 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2299 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2302 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2304 * xdisp.c (compute_display_string_end): If there's no display
2305 string at CHARPOS, return -1.
2307 * bidi.c (bidi_fetch_char): When compute_display_string_end
2308 returns a negative value, treat the character as a normal
2309 character not covered by a display string. (Bug#9624)
2311 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2313 * lread.c (Fread_from_string): Fix typo in docstring.
2315 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2317 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2318 newline, reseat the iterator instead of bidi-iterating there one
2319 character at a time. (Bug#9610)
2320 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2321 TO_CHARPOS if the bidi iterator is at base embedding level.
2323 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2325 * lread.c (readevalloop): Use correct code for NBSP.
2326 (read1): Likewise. (Bug#9608)
2328 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2330 * dbusbind.c (Fdbus_register_signal): When service is not
2331 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2333 2011-09-25 Glenn Morris <rgm@gnu.org>
2335 * buffer.c (truncate-lines): Doc fix.
2337 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2339 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2340 (Fset_window_next_buffers): Doc fix.
2342 2011-09-24 Glenn Morris <rgm@gnu.org>
2344 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2346 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2348 Fix minor problems found by static checking.
2349 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2350 * indent.c (Fvertical_motion): Fix == vs = typo.
2352 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2354 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2355 Default value is now t. Doc fix.
2357 * indent.c (Fvertical_motion): Compute and apply the overshoot
2358 logic when moving up, not only when moving down. Fix the
2359 confusing name and values of the it_overshoot_expected variable;
2360 logic changes accordingly. (Bug#9254) (Bug#9549)
2362 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2363 CHARPOS is covered by a display string which includes newlines.
2364 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2365 is covered by a display string with embedded newlines.
2367 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2369 * dbusbind.c (Fdbus_register_signal): Add match rule to
2370 Vdbus_registered_objects_table. (Bug#9581)
2371 (Fdbus_register_method, Vdbus_registered_objects_table):
2374 2011-09-24 Jim Meyering <meyering@redhat.com>
2376 do not ignore write error for any output size
2377 The previous change was incomplete.
2378 While it makes emacs --batch detect the vast majority of stdout
2379 write failures, errors were still ignored whenever the output size is
2380 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2381 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2382 && echo FAIL: ignored write error
2383 FAIL: ignored write error
2384 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2385 && echo FAIL: ignored write error
2386 FAIL: ignored write error
2387 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2389 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2391 * emacs.c (Fkill_emacs): In noninteractive mode exit
2392 non-successfully if a write error occurred on stdout. (Bug#9574)
2394 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2396 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2399 * dispextern.h (struct it): Update the comment documenting what
2402 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2404 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2405 a display string, extend search for cursor position to end of row.
2406 (find_row_edges): If the row ends in a newline from a display
2407 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2408 Handle the case of a display string with multiple newlines.
2409 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2410 non-empty line. Fixes confusing cursor motion with arrow keys at
2411 the beginning of a line that starts with whitespace.
2413 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2415 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2418 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2420 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2423 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2425 * xdisp.c (display_line): Record maximum and minimum buffer
2426 positions even if no glyphs were produced (e.g., by a zero-width
2427 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2428 buffer positions that will be removed from the glyph row because
2430 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2431 column is beyond frame width: don't subtract 1 "pixel" when
2432 computing width of the stretch.
2433 (reseat_at_next_visible_line_start): Undo the change made on
2434 2011-09-17 that saved paragraph information and restored it after
2435 the call to `reseat'. (Bug#9545)
2437 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2439 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2440 and turn window cursor on if cleared (Bug#9415).
2442 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2444 * search.c (boyer_moore): Take unibyte characters from pattern
2445 literally. (Bug#9458)
2447 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2449 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2451 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2453 Fix minor problem found by static checking.
2454 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2455 initialized, to pacify gcc -Wuninitialized.
2457 * fileio.c: Report proper errno when syscall falls.
2458 (Finsert_file_contents): Save and restore errno,
2459 so that report_file_error outputs the correct diagnostic.
2460 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2462 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2464 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2466 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2468 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2469 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2471 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2473 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2474 about the current paragraph and restore it after the call to reseat.
2476 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2477 (bidi_find_paragraph_start): Search back for paragraph beginning
2478 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2479 (bidi_move_to_visually_next): Only trigger paragraph-related
2480 computations when the last character is a newline or at EOB, not
2481 just any NEUTRAL_B. (Bug#9470)
2483 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2484 truncated lines if point is covered by a display string. (Bug#9524)
2486 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2488 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2489 (cons_to_x_long): New function.
2490 (lisp_data_to_selection_data): Use it. Correct the test for
2491 short-versus-long data; it was negated. Break out of vector
2492 loop, for efficiency, when a long datum is discovered.
2494 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2496 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2498 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2500 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2501 GCC PR/17406) by declaring this function with external scope.
2503 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2505 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2506 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2508 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2510 * editfns.c (Fformat): Correctly handle text properties on "%%".
2512 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2514 * xterm.c (x_draw_composite_glyph_string_foreground):
2515 * w32term.c (x_draw_composite_glyph_string_foreground):
2516 * term.c (encode_terminal_code):
2517 * composite.c (composition_update_it, get_composition_id):
2518 * xdisp.c (get_next_display_element)
2519 (fill_composite_glyph_string): Add comments about special meaning
2520 of TAB characters in a composition.
2522 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2524 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2525 This occurs when processing a multibyte format.
2526 Problem reported by Wolfgang Jenker.
2528 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2530 * xdisp.c (try_cursor_movement): Only check for exact match if
2531 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2533 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2535 Remove unused external symbols.
2536 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2537 * xdisp.c (calc_pixel_width_or_height): Now static.
2538 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2539 * indent.c (check_display_width):
2540 * w32term.c: Fix comment to match code.
2541 * xterm.c, xterm.h (x_catching_errors): Remove.
2543 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2545 * xselect.c: Use signed conversions more consistently (Bug#9498).
2546 (selection_data_to_lisp_data): Assume incoming selection data are
2547 signed integers, not unsigned. This is to be consistent with
2548 outgoing selection data, which was modified to use signed integers
2549 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2550 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2551 expects long, not unsigned long.
2553 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2555 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2556 computation of loop end. Reported by Johan Bockgård
2559 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2561 * frame.c (Fother_visible_frames_p): Function deleted.
2563 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2565 * indent.c (compute_motion): Process display vector front to back
2566 rather than the other way around. (Bug#2496)
2568 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2570 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2572 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2574 * minibuf.c (Fread_from_minibuffer): Doc fix.
2576 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2578 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2579 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2581 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2583 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2584 value for non-existent files.
2586 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2588 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2589 set its "size" to -1. This will set the modtime_size field of
2590 the corresponding buffer to -1, which is what
2591 verify-visited-file-modtime expects for files that do not exist.
2594 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2596 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2598 * lisp.h: ... from here. push_key_description is no longer
2599 defined in keyboard.c, so its declaration should not be in
2600 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2601 logically belongs with push_key_description.
2603 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2605 * buffer.h: Include <sys/types.h> instead of <time.h>.
2606 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2607 Problem reported by Herbert J. Skuhra.
2609 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2611 * xml.c (parse_region): Make the parsing work for
2612 non-comment-starting XML files again (bug#9144).
2614 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2616 * image.c (gif_load): Fix calculation of bottom and right corner.
2619 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2621 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2622 redisplay in small windows.
2624 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2626 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2628 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2630 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2631 Operate on live windows only.
2633 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2635 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2637 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2639 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2640 only under bidi iteration.
2642 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2644 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2646 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2648 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2649 Without this fix, the command to link temacs failed due to an
2650 undefined symbol __builtin_isnan. This is because
2651 /usr/include/iso/math_c99.h #defines isnan(x) to
2652 __builtin_isnan(x), but the bundled gcc, which identifies itself
2653 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2655 * floatfns.c (isnan): #undef, and then #define to a clone of
2657 (Fisnan): Always define, since it's always available now.
2658 (syms_of_floatfns): Always define isnan at the Lisp level.
2660 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2662 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2664 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2666 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2667 The previous code assumed that file offsets (off_t values) fit in
2668 EMACS_INT variables, which is not true on typical 32-bit hosts.
2669 The code messed up by falsely reporting buffer overflow in cases
2670 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2671 when "big" contains more than 2**29 bytes, even though this
2672 inserts just one byte and does not overflow the buffer.
2673 (Finsert_file_contents): Store file offsets as off_t
2674 values, not as EMACS_INT values. Check for overflow when
2675 converting between EMACS_INT and off_t. When checking for
2676 buffer overflow or for overlap, take the offsets into account.
2677 Don't use EMACS_INT for small values where int suffices.
2678 When checking for overlap, fix a typo: ZV was used where
2679 ZV_BYTE was intended.
2680 (Fwrite_region): Don't assume off_t fits into 'long'.
2681 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2683 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2685 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2687 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2689 sprintf-related integer and memory overflow issues (Bug#9412).
2691 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2692 (esprintf, exprintf, evxprintf): New functions.
2693 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2694 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2695 (modify_event_symbol): Do not assume that the length of
2696 name_alist_or_stem is safe to alloca and fits in int.
2697 (Fexecute_extended_command): Likewise for function name and binding.
2698 (Frecursion_depth): Wrap around reliably on integer overflow.
2699 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2700 since some callers pass EMACS_INT values.
2701 (Fsingle_key_description): Don't crash if symbol name contains more
2702 than MAX_ALLOCA bytes.
2703 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2704 (get_minibuffer): Arg is now EMACS_INT, not int.
2705 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2706 (esprintf, exprintf, evxprintf): New decls.
2707 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2709 * dbusbind.c (signature_cat): New function.
2710 (xd_signature, Fdbus_register_signal):
2711 Do not overrun buffer; instead, report string overflow.
2713 * dispnew.c (add_window_display_history): Don't overrun buffer.
2714 Truncate instead; this is OK since it's just a log.
2716 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2717 even if the time zone offset is outlandishly large.
2718 Don't mishandle offset == INT_MIN.
2720 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2721 when creating daemon; the previous buffer-overflow check was incorrect.
2723 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2724 which has the guts of the old verror function.
2726 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2727 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2729 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2730 (font_unparse_xlfd): Don't blindly alloca long strings.
2731 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2732 fits in int, when using sprintf. Use single snprintf to count
2733 length of string rather than counting it via multiple sprintfs;
2734 that's simpler and more reliable.
2735 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2736 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2737 sprintf, in case result does not fit in int.
2739 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2740 (fontset_from_font): Print it.
2742 * frame.c (tty_frame_count): Now printmax_t, not int.
2743 (make_terminal_frame, set_term_frame_name): Print it.
2744 (x_report_frame_params): In X, window IDs are unsigned long,
2745 not signed long, so print them as unsigned.
2746 (validate_x_resource_name): Check for implausibly long names,
2747 and don't assume name length fits in 'int'.
2748 (x_get_resource_string): Don't blindly alloca invocation name;
2749 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2752 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2753 (xg_check_special_colors, xg_set_geometry):
2754 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2756 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2757 Use esprintf, not sprintf, in case result does not fit in int.
2759 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2760 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2761 it as a large positive number.
2762 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2763 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2765 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2766 in case result does not fit in int.
2768 * print.c (float_to_string): Detect width overflow more reliably.
2769 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2770 buffer overrun. Don't assume list length fits in 'int'. Treat
2771 print length of 0 as 0, not as infinity; to be consistent with other
2772 uses of print length in this function. Don't overflow print length
2773 index. Don't assume hash table size fits in 'long', or that
2774 vectorlike size fits in 'unsigned long'.
2776 * process.c (make_process): Use printmax_t, not int, to format
2777 process-name gensyms.
2779 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2781 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2782 to avoid potential buffer overrun.
2784 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2785 if X resource line is longer than 512 bytes.
2787 * xfns.c (x_window): Make sprintf buffer a bit bigger
2788 to avoid potential buffer overrun.
2790 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2792 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2794 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2796 Integer overflow fixes for scrolling, etc.
2797 Without these, Emacs silently mishandles large integers sometimes.
2798 For example, "C-u 4294967297 M-x recenter" was treated as if
2799 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2801 * xdisp.c (try_window_id): Check Emacs fixnum range before
2802 converting to 'int'.
2804 * window.c (window_scroll_line_based, Frecenter):
2805 Check that an Emacs fixnum is in range before assigning it to 'int'.
2806 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2807 values converted from Emacs fixnums.
2808 (Frecenter): Don't wrap around a line count if it is out of 'int'
2809 range; instead, treat it as an extreme value.
2810 (Fset_window_configuration, compare_window_configurations):
2811 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2813 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2814 that can exceed INT_MAX. Check that EMACS_INT value is in range
2815 before assigning it to the (possibly-narrower) index.
2816 (match_limit): Don't assume that a fixnum can fit in 'int'.
2818 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2821 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2822 (Fvertical_motion): Don't wrap around LINES values that don't fit
2823 in 'int'. Instead, treat them as extreme values. This is good
2824 enough for windows, which can't have more than INT_MAX lines anyway.
2826 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2828 * Require libxml/parser.h to avoid compilation warning.
2830 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2832 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2833 since this reportedly can destroy thread storage.
2835 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2837 * syntax.c (find_defun_start): Update all cache variables if
2838 exiting early (Bug#9401).
2840 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2842 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2844 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2845 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2846 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2848 * term.c (tty_append_glyph): New function.
2849 (produce_stretch_glyph): Static function and its prototype deleted.
2851 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2854 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2856 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2857 when checking :margin (Bug#9390).
2858 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2859 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2860 so that the name doesn't mislead. All uses changed.
2862 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2864 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2867 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2869 * xdisp.c (move_it_to): Don't bail out early when reaching
2870 position beyond to_charpos, if we are scanning backwards.
2871 (move_it_vertically_backward): When DY == 0, make sure we get to
2872 the first character in the line after the newline.
2874 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2876 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2877 (ccl_driver): Do not generate an out-of-range pointer.
2878 (Fccl_execute_on_string): Remove unnecessary check for
2879 integer overflow, noted by Stefan Monnier in
2880 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2881 Remove a FIXME that didn't need fixing.
2882 Simplify the newly-introduced buffer reallocation code.
2884 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2886 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2888 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2890 Integer and memory overflow issues (Bug#9196).
2892 * doc.c (get_doc_string): Rework so that
2893 get_doc_string_buffer_size is the actual buffer size, rather than
2894 being 1 less than the actual buffer size; this makes xpalloc more
2897 * image.c (x_allocate_bitmap_record, cache_image):
2898 * xselect.c (Fx_register_dnd_atom):
2899 Simplify previous changes by using xpalloc.
2901 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2902 since either will do and ptrdiff_t is convenient with xpalloc.
2904 * charset.c (charset_table_size)
2905 (struct charset_sort_data.priority): Now ptrdiff_t.
2906 (charset_compare): Don't overflow if priorities differ greatly.
2907 (Fsort_charsets): Don't assume list length fits in int.
2908 Check for size-calculation overflow when allocating sort data.
2909 (syms_of_charset): Allocate an initial charset table that is
2910 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2912 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2914 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2915 The actual value is always <= INT_MAX, and leaving it unsigned made
2916 overflow checking harder.
2918 * dispextern.h (struct glyph_matrix.rows_allocated)
2919 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2920 with xpalloc. The values are still always <= INT_MAX.
2922 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2924 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2925 (SAFE_NALLOCA): New macro.
2927 * region-cache.c (struct boundary.pos, find_cache_boundary)
2928 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2929 (set_cache_region, invalidate_region_cache)
2930 (revalidate_region_cache, know_region_cache, region_cache_forward)
2931 (region_cache_backward, pp_cache):
2932 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2933 so that ptrdiff_t * can be passed to xpalloc.
2934 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2935 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2936 (pp_cache): Don't assume cache_len fits in int.
2937 * region-cache.h: Adjust extern decls to match.
2939 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2940 EMACS_INT, since either will do, for xpalloc.
2942 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2943 (xnmalloc, xnrealloc, xpalloc): New functions.
2945 * bidi.c (bidi_shelve_header_size): New constant.
2946 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2947 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2949 * bidi.c (bidi_cache_shrink):
2950 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2952 Don't update size of array until after memory allocation succeeds,
2953 because xmalloc/xrealloc may not return.
2954 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2955 now that we have proper integer overflow checking.
2956 (record_overlay_string, overlay_strings): Catch overflows when
2957 calculating size of overlay_str_buf.
2959 * callproc.c (Fcall_process): Check for size overflow when
2960 calculating size of args2.
2961 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2962 Normally we prefer signed values, but sticking with ptrdiff_t would
2963 require adding more-complicated checks.
2965 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2966 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2967 Redo buffer-overflow calculations to avoid integer overflow.
2968 Add a FIXME comment where memory seems to be over-allocated.
2970 * character.c (Fstring): Check for size-calculation overflow.
2972 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2973 unnecessary integer overflow. Check for size overflow.
2974 (encode_coding_object): Don't update size until xmalloc succeeds.
2976 * composite.c (get_composition_id): Check for overflow in glyph
2977 length calculations.
2979 Integer and memory overflow fixes for display code.
2980 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2981 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2982 (scrolling_window): Check for overflow in size calculations.
2983 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2984 Don't assume glyph table len fits in int.
2985 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2986 (row_table_size): Now ptrdiff_t, not int.
2987 (scrolling_window): Avoid overflow in size calculations.
2988 Don't update size until allocation succeeds.
2989 * fns.c (concat): Check for overflow in size calculations.
2990 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2991 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2992 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2994 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2995 (get_doc_string): Check for size calculation overflow.
2996 Don't update size until allocation succeeds.
2997 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2998 EMACS_INT, where ptrdiff_t will do.
2999 (Fsubstitute_command_keys): Check for string overflow.
3001 * editfns.c (set_time_zone_rule): Don't assume environment length
3003 (message_length): Now ptrdiff_t, not int.
3004 (Fmessage_box): Don't update size until allocation succeeds.
3005 Don't assume message length fits in int.
3006 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3008 * emacs.c (main): Do not reallocate argv, since there is a null at
3009 the end that can be overwritten, and this way there's no need to
3010 worry about size-calculation overflow.
3011 (sort_args): Check for size-calculation overflow.
3013 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3015 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3017 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3018 (x_set_scroll_bar_width, x_figure_window_size):
3019 Check for integer overflow.
3020 (x_set_alpha): Do not assume XINT fits in int.
3022 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3023 This is for the members text_lines, text_cols, total_lines, total_cols,
3024 where the system imposes an 'int' limit.
3026 * fringe.c (Fdefine_fringe_bitmap):
3027 Don't update size until alloc works.
3029 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3030 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3032 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3033 Check for size-calculation overflow.
3034 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3035 do, as we prefer signed integers.
3036 (id_to_widget.max_size, id_to_widget.used)
3037 (xg_store_widget_in_map, xg_remove_widget_from_map)
3038 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3039 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3040 Use and return ptrdiff_t, not int.
3041 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3042 * gtkutil.h: Change prototypes to match the above.
3044 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3045 are duplicate now that they've been promoted to lisp.h.
3046 (x_allocate_bitmap_record, x_alloc_image_color)
3047 (make_image_cache, cache_image, xpm_load):
3048 Don't update size until alloc is done.
3049 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3051 Check for size calculation overflow.
3052 (ct_colors_allocated_max): New constant.
3053 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3056 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3057 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3058 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3059 Use ptrdiff_t, not int, to count maps.
3060 (read_char_minibuf_menu_prompt): Check for overflow in size
3061 calculations. Don't update size until allocation succeeds.
3062 Redo calculations to avoid overflow.
3063 * keyboard.h: Change prototypes to match the above.
3065 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3067 (current_minor_maps): Check for size calculation overflow.
3068 * keymap.h: Change prototypes to match the above.
3070 * lread.c (read1, init_obarray): Don't update size until alloc done.
3072 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3073 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3075 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3076 Now ptrdiff_t, not int.
3077 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3078 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3080 * process.c (Fnetwork_interface_list): Check for overflow
3081 in size calculation.
3083 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3085 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3086 overflow. Don't bother calling xmalloc when xrealloc will do.
3088 * search.c (Freplace_match): Check for size calculation overflow.
3089 (Fset_match_data): Don't assume list lengths fit in 'int'.
3091 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3092 for command line length. Do not attempt to address one before the
3093 beginning of an array, as that's not portable.
3095 * term.c (max_frame_lines): Remove; unused.
3096 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3098 (encode_terminal_code, calculate_costs): Check for size
3099 calculation overflow.
3100 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3101 table lengths and related sizes. Don't update size until alloc
3102 done. Redo calculations to avoid overflow.
3103 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3105 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3106 subtracting pointers.
3107 (gobble_line): Check for overflow more carefully. Don't update size
3110 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3111 Don't update size until alloc done.
3112 Redo size calculations to avoid overflow.
3113 Check for size calculation overflow.
3114 (main) [DEBUG]: Fix typo in invoking tparam1.
3116 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3117 Use ptrdiff_t, not int, for sizes.
3118 (store_mode_line_noprop_char): Don't update size until alloc done.
3120 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3121 Use ptrdiff_t, not int, for sizes.
3122 (Finternal_make_lisp_face, cache_face):
3123 Check for size calculation overflow.
3124 (cache_face): Treat size calculation overflows as if they were
3125 memory exhaustion (the usual treatment), rather than aborting.
3127 * xfns.c (x_encode_text, x_set_name_internal)
3128 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3129 sizes, since they can exceed INT_MAX in size. Check for size
3130 calculation overflow.
3132 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3133 (xg_select): Check for size calculation overflow.
3134 Don't update size until alloc done.
3136 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3137 as sprintf is limited to int lengths.
3139 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3140 (X_LONG_MIN): New macros.
3141 Use them to make the following changes clearer.
3142 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3143 This change doesn't affect the value now, but it may help remind
3144 future maintainers not to raise the value too much later.
3145 (SELECTION_QUANTUM): Remove, replacing with ...
3146 (selection_quantum): ... new function, which avoids overflow.
3148 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3149 assumption that selection length fits in 'int'.
3150 (x_reply_selection_request, x_handle_selection_request)
3151 (x_get_window_property, receive_incremental_selection)
3152 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3153 (lisp_data_to_selection_data, clean_local_selection_data):
3154 Use ptrdiff_t, not int, to record length of selection.
3155 (x_reply_selection_request, x_get_window_property)
3156 (receive_incremental_selection, x_property_data_to_lisp):
3157 Redo calculations to avoid overflow.
3158 (x_reply_selection_request): When sending hint, ceiling it at
3159 X_LONG_MAX rather than relying on wraparound overflow to send
3161 (x_get_window_property, receive_incremental_selection)
3162 (lisp_data_to_selection_data, x_property_data_to_lisp):
3163 Check for size-calculation overflow.
3164 (x_get_window_property, receive_incremental_selection)
3165 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3166 Don't store size until memory allocation succeeds.
3167 (x_get_window_property): Plug memory leak on memory exhaustion.
3168 Don't double-block input; malloc is safe here. Don't assume 2**34
3169 - 4 fits in unsigned long. Add an xassert to check
3170 XGetWindowProperty overflow. Be more careful about overflow
3171 calculations, and distinguish size from memory overflow better.
3172 (receive_incremental_selection): When tracing, don't assume
3173 unsigned int is less than INT_MAX.
3174 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3175 harmful) conversions of unsigned short to int.
3176 (lisp_data_to_selection_data): Don't assume that integers
3177 in the range -65535 through -1 fit in an X unsigned short.
3178 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3179 result parameters unless successful. Rely on cons_to_unsigned
3180 to report problems with elements; the old code wasn't right anyway.
3181 (x_check_property_data): Check for int overflow; we cannot use
3182 a wider type due to X limits.
3183 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3185 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3187 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3188 (x_term_init): Check for size calculation overflow.
3189 (x_color_cells): Don't store size until memory allocation succeeds.
3190 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3191 Don't assume alloca size is less than MAX_ALLOCA.
3192 (x_term_init): Don't assume length fits in int (sprintf is limited
3195 Use ptrdiff_t for composition IDs.
3196 * character.c (lisp_string_width):
3197 * composite.c (composition_table_size, n_compositions)
3198 (get_composition_id, composition_gstring_from_id):
3199 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3200 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3201 * window.c (Frecenter):
3202 Use ptrdiff_t, not int, for composition IDs.
3203 * composite.c (get_composition_id): Check for integer overflow.
3204 * composite.h: Adjust prototypes to match the above changes.
3206 Use ptrdiff_t for hash table indexes.
3207 * category.c (hash_get_category_set):
3208 * ccl.c (ccl_driver):
3209 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3210 * coding.c (coding_system_charset_list, detect_coding_system):
3211 * coding.h (struct coding_system.id):
3212 * composite.c (get_composition_id, gstring_lookup_cache):
3213 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3214 * image.c (xpm_get_color_table_h):
3215 * lisp.h (hash_lookup, hash_put):
3216 * minibuf.c (Ftest_completion):
3217 Use ptrdiff_t for hash table indexes, not int (which is too
3218 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3219 32-bit --with-wide-int hosts).
3221 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3222 Add a FIXME comment about memory leaks.
3223 (syms_of_charset): Don't assume xmalloc returns.
3225 Don't assume that stated character widths fit in int.
3226 * character.c (Fchar_width, c_string_width, lisp_string_width):
3227 * character.h (CHAR_WIDTH):
3228 * indent.c (MULTIBYTE_BYTES_WIDTH):
3229 Use sanitize_char_width to avoid undefined and/or bad behavior
3230 with outlandish widths.
3231 * character.h (sanitize_tab_width): Rename from sanitize_width,
3232 now that we have two such functions. All uses changed.
3233 (sanitize_char_width): New inline function.
3235 Don't assume that tab-width fits in int.
3236 * character.h (sanitize_width): New inline function.
3237 (SANE_TAB_WIDTH): New macro.
3238 (ASCII_CHAR_WIDTH): Use it.
3239 * indent.c (sane_tab_width): Remove. All uses replaced by
3240 SANE_TAB_WIDTH (current_buffer).
3241 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3243 * fileio.c: Integer overflow issues with file modes.
3244 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3246 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3247 Remove unreachable code.
3248 (read_hex, load_charset_map_from_file): Check for integer overflow.
3250 * xterm.c: Don't go over XClientMessageEvent limit.
3251 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3252 (x_send_scroll_bar_event): Likewise. Check that the size does not
3253 exceed limits imposed by XClientMessageEvent, as well as the usual
3254 ptrdiff_t and size_t limits.
3256 * keyboard.c: Overflow, signedness and related fixes.
3257 (make_lispy_movement): Use same integer type in forward decl
3258 that is used in the definition.
3259 (read_key_sequence, keyremap_step):
3260 Change bufsize argument back to int, undoing my 2011-03-30 change.
3261 We prefer signed types, and int is wide enough here.
3262 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3263 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3264 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3265 length, not size_t. Use ptrdiff_t for index, not int.
3266 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3267 possibility of integer overflow.
3269 Overflow, signedness and related fixes for images.
3271 * dispextern.h (struct it.stack[0].u.image.image_id)
3272 (struct_it.image_id, struct image.id, struct image_cache.size)
3273 (struct image_cache.used, struct image_cache.ref_count):
3274 * gtkutil.c (update_frame_tool_bar):
3275 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3276 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3277 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3278 * nsmenu.m (update_frame_tool_bar):
3279 * xdisp.c (calc_pixel_width_or_height):
3280 * xfns.c (image_cache_refcount):
3281 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3282 on typical 64-bit hosts.
3284 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3285 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3286 Omit unnecessary casts to int.
3287 (parse_image_spec): Check that integers fall into 'int' range
3288 when the callers expect that.
3289 (image_ascent): Redo ascent calculation to avoid int overflow.
3290 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3291 (lookup_image): Remove unnecessary tests.
3292 (xbm_image_p): Locals are now of int, not EMACS_INT,
3293 since parse_image_check makes sure they fit into int.
3294 (png_load, gif_load, svg_load_image):
3295 Prefer int to unsigned where either will do.
3296 (tiff_handler): New function, combining the cores of the
3297 old tiff_error_handler and tiff_warning_handler.
3298 This function is rewritten to use vsnprintf and thereby avoid
3299 stack buffer overflows. It uses only the features of vsnprintf
3300 that are common to both POSIX and native Microsoft.
3301 (tiff_error_handler, tiff_warning_handler): Use it.
3302 (tiff_load, gif_load, imagemagick_load_image):
3303 Don't assume :index value fits in 'int'.
3304 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3305 (imagemagick_load_image): Check that crop parameters fit into
3306 the integer types that MagickCropImage accepts. Don't assume
3307 Vimagemagick_render_type has a nonnegative value. Don't assume
3308 size_t fits in 'long'.
3309 (gs_load): Use printmax_t to print the widest integers possible.
3310 Check for integer overflow when computing image height and width.
3312 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3314 * xdisp.c (redisplay_window): Don't force window start if point
3315 will be invisible in the resulting window. (Bug#9324)
3317 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3319 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3320 the display spec is of the form `(space ...)'.
3321 (handle_display_spec): Return the value returned by
3322 handle_single_display_spec, not just 1 or zero.
3323 (handle_single_display_spec): If the display spec is of the form
3324 `(space ...)', and specifies display in the text area, return 2
3326 (try_cursor_movement): Check for the need to scroll more
3327 accurately, and prefer exact match for point under bidi.
3328 Don't advance `row' beyond the last row of the window.
3330 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3331 into disp_prop; all users changed.
3333 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3334 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3335 for the text covered by the display property.
3337 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3339 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3340 Change return value to nil.
3341 (Frecord_buffer): Delete unused function.
3343 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3345 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3346 buffers, return left-to-right.
3347 (set_cursor_from_row): Consider candidate row a win if its glyph
3348 represents a newline and point is on that newline. Fixes cursor
3349 positioning on the newline at EOL of R2L text within L2R
3350 paragraph, and vice versa.
3351 (try_cursor_movement): Check continued rows, in addition to
3352 continuation rows. Fixes unwarranted scroll when point enters a
3353 continued line of R2L text within an L2R paragraph, or vice versa.
3354 (cursor_row_p): Consider the case of point being equal to
3355 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3356 from the end of a short line to the beginning of a continued line
3357 of R2L text within L2R paragraph.
3358 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3359 composed characters.
3361 * bidi.c (bidi_check_type): Use xassert.
3362 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3365 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3367 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3370 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3372 * nsfont.m (ns_otf_to_script): Fix typo.
3374 2011-08-22 Kenichi Handa <handa@m17n.org>
3376 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3377 extra slot even if the purpose is char-code-property-table.
3379 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3381 * xdisp.c (redisplay_window): When computing centering_position,
3382 account for the height of the header line. (Bug#8874)
3384 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3385 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3386 candidate is selected by the mouse, and that candidate has a
3387 composed character under the mouse.
3389 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3390 coordinates reported by pos-visible-in-window-p for a composed
3391 character in column zero.
3393 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3395 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3397 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3399 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3400 consider it a hit if to_charpos is anywhere in the range of the
3401 composed buffer positions.
3403 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3405 * image.c (gif_load): Don't assume that each subimage has the same
3406 dimensions as the base image. Handle disposal method that is
3407 "undefined" by the gif spec (Bug#9335).
3409 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3411 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3412 (Fcondition_case): Document `debug' symbol in error handler.
3414 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3416 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3417 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3418 from an Org mode buffer to a Speedbar frame.
3420 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3421 a composition, take its buffer position from IT->cmp_it.charpos.
3422 Fixes cursor positioning at the beginning of a line that begins
3423 with a composed character.
3425 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3427 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3428 character bidirectional type, use STRONG_L instead. Fixes crashes
3429 in a buffer produced by `describe-categories'.
3431 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3432 members before the level stack, so they would be saved and
3433 restored when copying iterator state. Fixes incorrect reordering
3434 around TABs covered by display properties.
3436 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3438 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3440 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3442 * eval.c (internal_condition_case, internal_condition_case_1)
3443 (internal_condition_case_2, internal_condition_case_n):
3444 Remove unnecessary aborts (Bug#9081).
3446 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3448 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3449 has no `load' handler, try opening the file locally. (Bug#9311)
3451 2011-08-16 Ken Brown <kbrown@cornell.edu>
3453 * gmalloc.c: Expand comment.
3455 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3457 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3458 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3460 2011-08-16 Ken Brown <kbrown@cornell.edu>
3462 Fix memory allocation problems in Cygwin build (Bug#9273).
3464 * unexcw.c ( __malloc_initialized): Declare external variable.
3465 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3467 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3469 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3471 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3473 [CYGWIN] (special_realloc): New function.
3474 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3475 requests to realloc storage in the static heap.
3477 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3479 * bidi.c (bidi_initialize): Remove unused local.
3481 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3484 * biditype.h: Remove file.
3485 * makefile.w32-in ($(BLD)/bidi.$(O)):
3486 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3488 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3490 * chartab.c: Improve commentary for the uniprop_table API.
3492 * bidi.c (bidi_paragraph_init): Support zero value of
3493 bidi_ignore_explicit_marks_for_paragraph_level.
3494 (bidi_initialize): Use uniprop_table instead of including
3495 biditype.h and bidimirror.h.
3497 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3498 coordinates of the iterator when restoring from ppos_it.
3501 2011-08-14 Kenichi Handa <handa@m17n.org>
3503 * process.c (create_process): Call setup_process_coding_systems
3504 after the pid of the process is set to -1 (Bug#8162).
3506 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3508 * xdisp.c (move_it_in_display_line_to): Don't invoke
3509 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3510 ppos_it. Fixes vertical cursor motion when line beginning is
3511 covered by an image. (Bug#9296)
3513 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3515 * nsterm.h (ns_run_ascript): Declare.
3516 (NSAPP_DATA2_RUNASSCRIPT): Define.
3518 * nsfns.m (as_script, as_result, as_status): New static variables.
3519 (ns_run_ascript): New function.
3520 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3521 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3522 the event loop. Get status from as_status (Bug#7276).
3524 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3525 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3526 the event loop (Bug#7276).
3528 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3530 * gnutls.c (QCgnutls_bootprop_priority)
3531 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3532 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3533 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3534 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3535 (QCgnutls_bootprop_verify_hostname_error)
3536 (QCgnutls_bootprop_callbacks_verify): Rename from
3537 Qgnutls_bootprop_..., all uses changed.
3539 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3542 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3544 * xfaces.c (Qframe_set_background_mode): Now static.
3545 * dispextern.h (Qframe_set_background_mode): Remove decl.
3547 * process.c (Fnetwork_interface_info): Declare local only if needed.
3549 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3551 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3552 (Fnetwork_interface_list): Allocate in increments of bytes instead
3553 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3554 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3556 (struct ifflag_def): notrailers is smart on OSX.
3557 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3558 Get hardware address with getifaddrs if available.
3560 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3562 * xdisp.c (iterate_out_of_display_property): xassert that
3563 IT->position is set to within IT->object's boundaries. Break from
3564 the loop as soon as EOB is reached; avoids infloops in redisplay
3565 when IT->position is set up wrongly due to some bug.
3566 Set IT->current to match the bidi iterator unconditionally.
3567 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3568 entry. Force push_it to save on the stack the current
3569 buffer/string position, to be restored by pop_it. Fix flags in
3570 the iterator structure wrt the object coming from a display
3571 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3572 properties. (Bug#9284)
3574 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3576 * fontset.c (fontset_get_font_group): Add proper type checks.
3579 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3581 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3582 and LC_VERSION_MIN_MACOSX.
3583 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3584 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3586 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3588 * xdisp.c (forward_to_next_line_start): Allow to use the
3589 no-display-properties-and-no-overlays under bidi display.
3590 Set disp_pos in the bidi iterator to avoid searches for display
3591 properties and overlays.
3593 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3595 * editfns.c (Fset_time_zone_rule): Document relationship with the
3598 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3599 the font entity extracted from the cache (Bug#8109).
3601 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3603 * composite.c (autocmp_chars): Don't reset point. That is done by
3604 restore_point_unwind (Bug#5984).
3606 2011-08-07 Juri Linkov <juri@jurta.org>
3608 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3609 to show the arg `TIME' instead of `TIMEVAL'.
3611 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3613 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3614 display property strides EOL and includes a newline, as in
3615 longlines-mode. (Bug#9254)
3616 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3617 word-wrap under bidirectional display. (Bug#9224)
3619 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3620 is non-zero, even if the data buffer is NULL. Fixes a crash in
3621 vertical-motion with longlines-mode. (Bug#9254)
3623 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3625 * bidi.c <bidi_cache_total_alloc>: Now static.
3626 (bidi_initialize): Initialize bidi_cache_total_alloc.
3628 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3631 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3632 amount allocated this far in `bidi_cache_total_alloc'.
3633 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3634 non-zero, only free the data buffer without restoring the cache
3635 contents. All callers changed.
3637 * dispextern.h (bidi_unshelve_cache): Update prototype.
3639 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3640 (move_it_in_display_line, move_it_to)
3641 (move_it_vertically_backward, move_it_by_lines): Replace the call
3642 to xfree to an equivalent call to bidi_unshelve_cache.
3643 (move_it_in_display_line_to): Fix logic of returning
3644 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3646 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3648 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3649 came from a string character with a `cursor' property. (Bug#9229)
3651 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3653 * Makefile.in (LIB_PTHREAD): New variable.
3654 (LIBES): Add LIB_PTHREAD (Bug#9216).
3656 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3657 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3659 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3661 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3663 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3665 * xterm.c (x_find_topmost_parent): New function.
3666 (x_set_frame_alpha): Find topmost parent window with
3667 x_find_topmost_parent and set the property there also (bug#9181).
3668 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3670 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3672 * callproc.c (Fcall_process): Avoid vfork clobbering
3673 the local vars buffer, coding_systems, current_dir.
3675 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3677 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3679 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3681 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3682 so that it is not optimized away.
3684 * xdisp.c (compute_display_string_pos): Remove unused local.
3686 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3688 Fix slow cursor motion and scrolling in large buffers with
3689 selective display, like Org Mode buffers. (Bug#9218)
3691 * dispextern.h (struct bidi_it): New member disp_prop_p.
3693 * xdisp.c: Remove one-slot cache of display string positions.
3694 (compute_display_string_pos): Accept an additional argument
3695 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3696 for a display string or property. If found, set DISP_PROP_P
3699 * bidi.c (bidi_fetch_char): Accept an additional argument
3700 DISP_PROP_P, and pass it to compute_display_string_pos.
3701 Only handle text covered by a display string if DISP_PROP_P is returned
3702 non-zero. All callers of bidi_fetch_char changed.
3704 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3706 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3708 2010-12-03 Don March <don@ohspite.net>
3710 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3711 last character M-[char] is translated to ESC [char] (bug#7541).
3713 2011-08-02 Kenichi Handa <handa@m17n.org>
3715 * lisp.h (uniprop_table): Extern it.
3717 * chartab.c (uniprop_table): Make it non-static.
3719 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3721 * xdisp.c (forward_to_next_line_start): Accept additional argument
3722 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3724 (reseat_at_next_visible_line_start): Use the bidi iterator state
3725 returned by forward_to_next_line_start to restore the state of
3726 it->bidi_it after backing up to previous newline. (Bug#9212)
3728 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3730 * regex.c (re_comp): Protoize.
3731 (re_exec): Fix return type.
3732 (regexec): Fix type of `ret'. (Bug#9203)
3734 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3736 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3737 This is needed if max-image-size is a floating-point number.
3739 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3741 * print.c (print_object): Print empty symbol as ##.
3743 * lread.c (read1): Read ## as empty symbol.
3745 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3747 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3748 setting frame foreground color (Bug#9175).
3749 (x_set_background_color): Likewise.
3751 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3752 contents (Bug#9176).
3753 (EmacsTooltip -init): Remove bezels and add shadows to
3756 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3757 or scroll bar (Bug#8470).
3759 * nsfont.m (nsfont_open): Remove assignment to voffset and
3760 unnecessary vars hshink, expand, hd, full_height, min_height.
3761 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3763 * nsterm.h (nsfont_info): Remove voffset field.
3765 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3767 Implement strike-through and overline on NextStep (Bug#8863).
3769 * nsfont.m (nsfont_open): Use underline position provided by font,
3770 instead of hard-coded value of 2.
3771 (nsfont_draw): Call ns_draw_text_decoration instead.
3773 * nsterm.h: Add declaration for ns_draw_text_decoration.
3775 * nsterm.m (ns_draw_text_decoration): New function for drawing
3776 underline, overline, and strike-through.
3777 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3778 ns_draw_text_decoration. Change treatment of cursor drawing to
3779 accommodate underlining, etc.
3781 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3783 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3786 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3788 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3789 Without this fix, if a signal arrives just after memory fills up,
3790 'malloc' might be invoked reentrantly.
3792 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3793 In other words, assume that every image size is allowed, on non-X
3794 hosts. This assumption is probably wrong, but it lets Emacs compile.
3796 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3798 * regex.c (re_iswctype): Convert return values to boolean.
3800 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3802 * xdisp.c (compute_display_string_pos): Don't use cached display
3803 string position if the buffer had its restriction changed.
3806 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3808 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3810 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3812 Integer signedness and overflow and related fixes. (Bug#9079)
3814 * bidi.c: Integer size and overflow fixes.
3815 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3816 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3817 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3818 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3819 (bidi_find_other_level_edge):
3820 Use ptrdiff_t instead of EMACS_INT where either will do.
3821 This works better on 32-bit hosts configured --with-wide-int.
3822 (bidi_cache_ensure_space): Check for size-calculation overflow.
3823 Use % rather than repeated addition, for better worst-case speed.
3824 Don't set bidi_cache_size until after xrealloc returns, because it
3826 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3827 (bidi_cache_ensure_space): Also check that the bidi cache size
3828 does not exceed that of the largest Lisp string or buffer. See Eli
3829 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3831 * alloc.c (__malloc_size_t): Remove.
3832 All uses replaced by size_t. See Andreas Schwab's note
3833 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3835 * image.c: Improve checking for integer overflow.
3836 (check_image_size): Assume that f is nonnull, since
3837 it is always nonnull in practice. This is one less thing to
3838 worry about when checking for integer overflow later.
3839 (x_check_image_size): New function, which checks for integer
3840 overflow issues inside X.
3841 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3842 This removes the need for a memory_full check.
3843 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3844 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3845 (xbm_read_bitmap_data): Change locals back to 'int', since
3846 their values must fit in 'int'.
3847 (xpm_load_image, png_load, tiff_load):
3848 Invoke x_create_x_image_and_pixmap earlier,
3849 to avoid much needless work if the image is too large.
3850 (tiff_load): Treat overly large images as if
3851 x_create_x_image_and_pixmap failed, not as malloc failures.
3852 (gs_load): Use x_check_image_size.
3854 * gtkutil.c: Omit integer casts.
3855 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3856 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3858 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3860 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3861 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3862 would wrongly return t on a 64-bit host.
3864 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3865 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3866 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3867 and therefore cause GCC to emit a bogus diagnostic in some cases.
3869 * image.c: Integer signedness and overflow and related fixes.
3870 This is not an exhaustive set of fixes, but it's time to
3871 record what I've got.
3872 (lookup_pixel_color, check_image_size): Remove redundant decls.
3873 (check_image_size): Don't assume that arbitrary EMACS_INT values
3874 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3875 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3876 (tiff_load, imagemagick_load_image):
3877 Check for overflow in size calculations.
3878 (x_create_x_image_and_pixmap): Remove unnecessary test for
3879 xmalloc returning NULL; that can't happen.
3880 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3881 (xpm_color_bucket): Use better integer hashing function.
3882 (xpm_cache_color): Don't possibly over-allocate memory.
3883 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3884 (gif_memory_source):
3885 Use ptrdiff_t, not int or size_t, to record sizes.
3886 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3887 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3888 either works, as we prefer signed integers.
3889 (tiff_read_from_memory, tiff_write_from_memory):
3890 Return tsize_t, not size_t, since that's what the TIFF API wants.
3891 (tiff_read_from_memory): Don't fail simply because the read would
3892 go past EOF; instead, return a short read.
3893 (tiff_load): Omit no-longer-needed casts.
3894 (Fimagemagick_types): Don't assume size fits into 'int'.
3896 Improve hashing quality when configured --with-wide-int.
3897 * fns.c (hash_string): New function, taken from sxhash_string.
3898 Do not discard information about ASCII character case; this
3899 discarding is no longer needed.
3900 (sxhash-string): Use it. Change sig to match it. Caller changed.
3901 * lisp.h: Declare it.
3902 * lread.c (hash_string): Remove, since we now use fns.c's version.
3903 The fns.c version returns a wider integer if --with-wide-int is
3904 specified, so this should help the quality of the hashing a bit.
3906 * emacs.c: Integer overflow minor fix.
3907 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3908 Define only if GNU_LINUX.
3909 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3911 * dispnew.c: Integer signedness and overflow fixes.
3912 Remove unnecessary forward decls, that were a maintenance hassle.
3913 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3915 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3916 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3917 (prepare_desired_row, line_draw_cost):
3918 Use int, not unsigned, where either works.
3919 (save_current_matrix, restore_current_matrix):
3920 Use ptrdiff_t, not size_t, where either works.
3921 (init_display): Check for overflow more accurately, and without
3922 relying on undefined behavior.
3924 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3925 Remove, replacing with the new symbols in lisp.h. All uses changed.
3926 * fileio.c (make_temp_name):
3927 * filelock.c (lock_file_1, lock_file):
3928 * xdisp.c (message_dolog):
3929 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3930 Use pMd etc. instead.
3931 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3932 replacing the pWIDE etc. symbols removed from editfns.c.
3934 * keyboard.h (num_input_events): Now uintmax_t.
3935 This is (very slightly) less likely to mess up due to wraparound.
3938 * buffer.c: Integer signedness fixes.
3939 (alloc_buffer_text, enlarge_buffer_text):
3940 Use ptrdiff_t rather than size_t when either will do, as we prefer
3943 * alloc.c: Integer signedness and overflow fixes.
3944 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3945 (__malloc_size_t): Default to size_t, not to int.
3946 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3947 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3948 Prefer ptrdiff_t to size_t when either would do, as we prefer
3950 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3951 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3952 Now const. Initialize with values that are in range even if char
3954 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3955 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3956 These functions do the right thing with sizes > 2**32.
3957 (check_depth): Now ptrdiff_t, not int.
3958 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3959 Adjust to new way of storing sizes. Check for size overflow bugs
3961 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3962 slightly wrong anyway, as it missed one instance of
3963 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3964 (refill_memory_reserve): Omit needless cast to size_t.
3965 (mark_object_loop_halt): Mark as externally visible.
3967 * xselect.c: Integer signedness and overflow fixes.
3968 (Fx_register_dnd_atom, x_handle_dnd_message):
3969 Use ptrdiff_t, not size_t, since we prefer signed.
3970 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3971 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3972 x_dnd_atoms_size and x_dnd_atoms_length.
3974 * doprnt.c: Prefer signed to unsigned when either works.
3976 * doprnt.c (doprnt):
3978 * xdisp.c (vmessage):
3979 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3980 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3981 prefer signed arithmetic to avoid comparison confusion.
3982 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3983 but is a bit tricky.
3985 Assume freestanding C89 headers, string.h, stdlib.h.
3986 * data.c, doprnt.c, floatfns.c, print.c:
3987 Include float.h unconditionally.
3988 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3989 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3990 * regex.c: Likewise for stddef.h, string.h.
3991 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3992 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3993 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3994 (STDC_HEADERS): Remove obsolete defines.
3995 * sysdep.c: Include limits.h unconditionally.
3997 Assume support for memcmp, memcpy, memmove, memset.
3998 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3999 * regex.c (memcmp, memcpy):
4000 Remove; we assume C89 now.
4002 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4003 (__malloc_safe_bcopy): Remove; no longer needed.
4005 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4006 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4007 well either way, and we prefer signed to unsigned.
4009 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4011 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4012 closes the connection while we're reading (bug#9182).
4014 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4016 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4017 are specified (Bug#9168).
4019 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4021 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4022 Found by GCC static checking and --with-wide-int on a 32-bit host.
4024 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4026 * xdisp.c (compute_display_string_pos): Fix logic of caching
4027 previous display string position. Initialize cached_prev_pos to
4028 -1. Fixes slow-down at the beginning of a buffer.
4030 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4032 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4033 for attrs[LFACE_FONTSET_INDEX].
4035 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4037 * xml.c (parse_region): Remove unused local
4038 that was recently introduced.
4040 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4042 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4043 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4045 * xdisp.c (move_it_in_display_line_to): Record the best matching
4046 position for TO_CHARPOS while scanning the line, and restore it on
4047 exit if none of the characters scanned was an exact match.
4048 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4049 when exact match is impossible due to invisible text, and the
4050 lines are truncated.
4052 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4054 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4057 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4059 Fix a significant slow-down of cursor motion with C-n, C-p,
4060 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4061 auto-repeat under bidi redisplay in fontified buffers.
4062 * xdisp.c (compute_stop_pos_backwards): New function.
4063 (next_element_from_buffer): Call compute_stop_pos_backwards to
4064 find a suitable prev_stop when we find ourselves before
4066 (reseat): Don't look for prev_stop, as that could mean a very long
4068 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4069 <cached_disp_overlay_modiff>: Cache for last found display string
4071 (compute_display_string_pos): Return the cached position if asked
4072 about the same buffer in the same area of character positions, and
4073 the buffer wasn't changed since the time the display string
4074 position was cached.
4076 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4078 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4079 is an integer, which is important for empty lines. (Bug#9149)
4081 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4083 * frame.c (Fmodify_frame_parameters): In tty case, update the
4084 default face if necessary (Bug#4238).
4086 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4088 * editfns.c (Fstring_to_char): No need to explain what a character
4089 is in the docstring (Bug#6576).
4091 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4093 * xml.c (parse_region): Make sure we always return a tree.
4095 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4097 * xml.c (parse_region): If a document contains only comments,
4100 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4102 * xml.c (make_dom): Return comments, too.
4104 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4107 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4108 and the surrounding thread.
4109 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4110 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4111 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4113 * s/openbsd.h (BROKEN_SIGIO): Define.
4114 * unexelf.c (unexec) [__OpenBSD__]:
4115 Don't update the .mdebug section of the Alpha COFF symbol table.
4117 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4119 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4122 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4124 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4125 This fixes some race conditions on the permissions of any newly
4128 * alloc.c (valid_pointer_p): Use pipe, not open.
4129 This fixes some permissions issues when debugging.
4131 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4132 If fchown fails to set both uid and gid, try to set just gid,
4133 as that is sometimes allowed. Adjust the file's mode to eliminate
4134 setuid or setgid bits that are inappropriate if fchown fails.
4136 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4138 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4139 to compare Lisp_Objects.
4140 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4141 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4142 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4144 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4146 * lread.c (read_integer): Unread even EOF character.
4147 (read1): Likewise. Properly record start position of symbol.
4149 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4150 symbol character follows.
4152 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4154 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4155 This works around a problem with the previous change to Fcopy_file.
4156 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4157 and without this change, GCC might complain about discarding
4158 fchown's return value.
4160 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4162 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4164 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4166 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4168 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4170 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4171 it's used from the C level.
4173 * process.c: Use the same condition for POLL_FOR_INPUT in both
4174 keyboard.c and process.c (bug#1858).
4176 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4178 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4179 (Fgnutls_boot): Use it.
4181 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4183 * doc.c (Fsubstitute_command_keys): Revert last change.
4185 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4187 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4188 quotes the next character, and doesn't affect other longer
4189 sequences (bug#8935).
4191 * lread.c (syms_of_lread): Clarify that is isn't only
4192 `eval-buffer' and `eval-defun' that's affected by
4193 `lexical-binding' (bug#8460).
4195 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4197 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4198 bidi redisplay when a line includes both an image and is truncated.
4200 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4202 Fix minor problems found by static checking.
4203 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4204 (elsz): Now a signed constant, not a size_t var. We prefer signed
4205 types to unsigned, to avoid integer comparison confusion. Without
4206 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4207 "cannot optimize loop, the loop counter may overflow", a symptom
4209 * indent.c (Fvertical_motion): Mark locals as initialized.
4210 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4212 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4214 * search.c (Fre_search_backward): Mention `case-fold-search' in
4215 all the re_search_* functions (bug#8138).
4217 * keyboard.c (Fopen_dribble_file): Document when the file is
4220 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4222 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4225 Support bidi reordering of display and overlay strings.
4226 * xdisp.c (compute_display_string_pos)
4227 (compute_display_string_end): Accept additional argument STRING.
4228 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4229 (reseat_to_string): Initialize bidi_it->string.s and
4230 bidi_it->string.schars.
4231 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4232 NULL (avoids a crash in bidi_paragraph_init).
4233 Initialize itb.string.lstring.
4234 (init_iterator): Call bidi_init_it only of a valid
4235 buffer position was specified. Initialize paragraph_embedding to
4237 (reseat_to_string): Initialize the bidi iterator.
4238 (display_string): If we need to ignore text properties of
4239 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4240 original value of -1 will not work with bidi.)
4241 (compute_display_string_pos): First arg is now struct
4242 `text_pos *'; all callers changed. Support display properties on
4244 (compute_display_string_end): Support display properties on Lisp
4246 (init_iterator, reseat_1, reseat_to_string): Initialize the
4247 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4248 when iterating on a string not from display properties).
4249 (compute_display_string_pos, compute_display_string_end):
4250 Fix calculation of the object to scan. Fixes an error when using
4252 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4253 base_level_stop; instead, set base_level_stop to BEGV.
4254 Fixes crashes in vertical-motion.
4255 (next_element_from_buffer): Improve commentary for when
4256 the iterator is before prev_stop.
4257 (init_iterator): Initialize bidi_p from the default value of
4258 bidi-display-reordering, not from buffer-local value. Use the
4259 buffer-local value only if initializing for buffer iteration.
4260 (handle_invisible_prop): Support invisible properties on strings
4261 that are being bidi-reordered.
4262 (set_iterator_to_next): Support bidi reordering of C strings and
4264 (next_element_from_string): Support bidi reordering of Lisp
4266 (handle_stop_backwards): Support Lisp strings as well.
4267 (display_string): Support display of R2L glyph rows.
4268 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4269 (init_iterator): Don't initialize it->bidi_p for strings
4271 (reseat_to_string): Initialize it->bidi_p for strings here.
4272 (next_element_from_string, next_element_from_c_string)
4273 (next_element_from_buffer): Add xassert's for correspondence
4274 between IT's object being iterated and it->bidi_it.string
4276 (face_before_or_after_it_pos): Support bidi iteration.
4277 (next_element_from_c_string): Handle the case of the first string
4278 character that is not the first one in the visual order.
4279 (get_visually_first_element): New function, refactored from common
4280 parts of next_element_from_buffer, next_element_from_string, and
4281 next_element_from_c_string.
4282 (tool_bar_lines_needed, redisplay_tool_bar)
4283 (display_menu_bar): Force left-to-right direction. Add a FIXME
4284 comment for making that be controlled by a user option.
4285 (push_it, pop_it): Save and restore the state of the
4286 bidi iterator. Save and restore the bidi_p flag.
4287 (pop_it): Iterate out of display property for string iteration as
4289 (iterate_out_of_display_property): Support iteration over strings.
4290 (handle_single_display_spec): Set up it->bidi_it for iteration
4291 over a display string, and call bidi_init_it.
4292 (handle_single_display_spec, next_overlay_string)
4293 (get_overlay_strings_1, push_display_prop): Set up the bidi
4294 iterator for displaying display or overlay strings.
4295 (forward_to_next_line_start): Don't use the shortcut if
4297 (back_to_previous_visible_line_start): If handle_display_prop
4298 pushed the iterator stack, restore the internal state of the bidi
4299 iterator by calling bidi_pop_it same number of times.
4300 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4301 and we are bidi-iterating, don't decrement the iterator position;
4302 instead, set the first_elt flag in the bidi iterator, to produce
4304 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4305 (push_display_prop): xassert that we are iterating a buffer.
4306 (push_it, pop_it): Save and restore paragraph_embedding member.
4307 (handle_single_display_spec, next_overlay_string)
4308 (get_overlay_strings_1, reseat_1, reseat_to_string)
4309 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4310 correctly. Don't assume unibyte strings are not bidi-reordered.
4311 (compute_display_string_pos)
4312 (compute_display_string_end): Fix handling the case of C string.
4313 (push_it, pop_it): Save and restore from_disp_prop_p.
4314 (handle_single_display_spec, push_display_prop): Set the
4315 from_disp_prop_p flag.
4316 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4317 (pop_it): Call iterate_out_of_display_property only if we are
4318 popping after iteration over a string that came from a display
4319 property. Fix a typo in popping stretch info. Add an assertion
4320 for verifying that the iterator position is in sync with the bidi
4322 (handle_single_display_spec, get_overlay_strings_1)
4323 (push_display_prop): Fix initialization of paragraph direction for
4324 string when that of the parent object is not yet determined.
4325 (reseat_1): Call bidi_init_it to resync the bidi
4326 iterator with IT's position. (Bug#7616)
4327 (find_row_edges): If ROW->start.pos gives position
4328 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4329 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4330 Reset the from_disp_prop_p flag.
4331 (SAVE_IT, RESTORE_IT): New macros.
4332 (pos_visible_p, face_before_or_after_it_pos)
4333 (back_to_previous_visible_line_start)
4334 (move_it_in_display_line_to, move_it_in_display_line)
4335 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4336 (try_scrolling, redisplay_window, display_line): Use them when
4337 saving a temporary copy of the iterator and restoring it back.
4338 (back_to_previous_visible_line_start, reseat_1)
4339 (init_iterator): Empty the bidi cache "stack".
4340 (move_it_in_display_line_to): If iterator ended up at
4341 EOL, but we never saw any buffer positions smaller than
4342 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4343 motion in bidi-reordered lines.
4344 (move_it_in_display_line_to): Record prev_method and prev_pos
4345 immediately before the call to set_iterator_to_next. Fixes cursor
4346 motion in bidi-reordered lines with stretch glyphs and strings
4347 displayed in margins. (Bug#8133) (Bug#8867)
4348 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4350 (pos_visible_p): Support positions in bidi-reordered lines.
4351 Save and restore bidi cache.
4353 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4354 (bidi_paragraph_info): Delete unused struct.
4355 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4356 (bidi_cache_start): New variable.
4357 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4359 (bidi_cache_fetch_state, bidi_cache_search)
4360 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4361 (bidi_cache_find, bidi_peek_at_next_level)
4362 (bidi_level_of_next_char, bidi_find_other_level_edge)
4363 (bidi_move_to_visually_next): Compare cache index with
4364 bidi_cache_start rather than with zero.
4365 (bidi_fetch_char): Accept new argument STRING; all callers
4366 changed. Support iteration over a string. Support strings with
4367 display properties. Support unibyte strings. Fix the type of
4368 `len' according to what STRING_CHAR_AND_LENGTH expects.
4369 (bidi_paragraph_init, bidi_resolve_explicit_1)
4370 (bidi_resolve_explicit, bidi_resolve_weak)
4371 (bidi_level_of_next_char, bidi_move_to_visually_next):
4372 Support iteration over a string.
4373 (bidi_set_sor_type, bidi_resolve_explicit_1)
4374 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4375 can now be zero (for strings); special values 0 and -1 were
4376 changed to -1 and -2, respectively.
4377 (bidi_char_at_pos): New function.
4378 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4379 Call it instead of FETCH_MULTIBYTE_CHAR.
4380 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4381 initialized to valid values.
4382 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4384 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4385 the test for valid cached positions. Fix the logic for looking up
4386 the sentinel state in the cache. GCPRO the Lisp string we are
4388 (bidi_push_it, bidi_pop_it): New functions.
4389 (bidi_initialize): Initialize the bidi cache start stack pointer.
4390 (bidi_cache_ensure_space): New function, refactored from part of
4391 bidi_cache_iterator_state. Don't assume the required size is just
4392 one BIDI_CACHE_CHUNK away.
4393 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4394 (bidi_count_bytes, bidi_char_at_pos): New functions.
4395 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4396 always valid if bidi_cache_idx is valid.
4397 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4398 is valid if it's going to be used.
4399 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4400 (bidi_cache_fetch_state, bidi_cache_search)
4401 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4402 (bidi_cache_iterator_state, bidi_cache_find)
4403 (bidi_find_other_level_edge, bidi_cache_start_stack):
4404 All variables related to cache indices are now EMACS_INT.
4406 * dispextern.h (struct bidi_string_data): New structure.
4407 (struct bidi_it): New member `string'. Make flag members be 1-bit
4408 fields, and put them last in the struct.
4409 (compute_display_string_pos, compute_display_string_end):
4411 (bidi_push_it, bidi_pop_it): Add prototypes.
4412 (struct iterator_stack_entry): New members bidi_p,
4413 paragraph_embedding, and from_disp_prop_p.
4414 (struct it): Member bidi_p is now a bit field 1 bit wide.
4415 (bidi_shelve_cache, bidi_unshelve_cache):
4418 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4419 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4420 and vector-like objects.
4422 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4423 cache around display iteration.
4425 * window.c (Fwindow_end, window_scroll_pixel_based)
4426 (displayed_window_lines, Frecenter): Save and restore the bidi
4427 cache around display iteration.
4429 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4431 * editfns.c (Fdelete_region): Clarify the use of the named
4432 parameters (bug#6788).
4434 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4436 * indent.c (Fvertical_motion): Set and restore w->pointm when
4437 saving and restoring the window's buffer (Bug#9006).
4439 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4441 * editfns.c (Fstring_to_char): Clarify just what is returned
4442 (bug#6576). Text by Eli Zaretskii.
4444 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4446 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4448 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4450 * buffer.c (mmap_find): Fix a typo.
4452 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4454 Fix execution of x selection hooks.
4455 * xselect.c (Qx_lost_selection_functions)
4456 (Qx_sent_selection_functions): New vars.
4457 (syms_of_xselect): DEFSYM them.
4458 (x_handle_selection_request): Pass Qx_sent_selection_functions
4459 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4460 (x_handle_selection_clear,x_clear_frame_selections):
4461 Pass Qx_lost_selection_functions rather than
4462 Vx_lost_selection_functions to Frun_hook_with_args.
4464 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4466 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4467 The old code sometimes used this field without initializing it.
4469 * alloc.c (gc_sweep): Don't read past end of array.
4470 In theory, the old code could also have corrupted Emacs internals,
4471 though it'd be very unlikely.
4473 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4475 * character.c (Fcharacterp): Don't advertise optional ignored
4476 argument. (Bug#4026)
4478 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4480 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4483 * window.c (Fset_window_start): Doc fix (bug#4199).
4484 (Fset_window_hscroll): Ditto.
4486 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4488 Fix minor new problems caught by GCC 4.6.1.
4489 * term.c (init_tty): Remove unused local.
4490 * xsettings.c (store_monospaced_changed): Define this function only
4491 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4494 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4496 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4498 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4500 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4501 are the mini-buffer and the echo area (bug#3320).
4503 * term.c (init_tty): Remove support for supdup, c10 and perq
4504 terminals, which are no longer supported (bug#1482).
4506 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4508 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4510 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4512 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4513 for non-popups (Bug#3642).
4515 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4517 * alloc.c (reset_malloc_hooks): Protoize.
4518 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4519 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4520 * cm.c (losecursor): Likewise.
4521 * data.c (fmod): Likewise.
4522 * dispnew.c (swap_glyphs_in_rows): Likewise.
4523 * emacs.c (memory_warning_signal): Likewise.
4524 * floatfns.c (float_error): Likewise.
4525 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4526 (otf_open, font_otf_capability, generate_otf_features)
4527 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4529 * image.c (pbm_read_file): Likewise.
4530 * indent.c (string_display_width): Likewise.
4531 * intervals.c (check_for_interval, search_for_interval)
4532 (inc_interval_count, count_intervals, root_interval)
4533 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4534 * lread.c (defalias): Likewise.
4535 * ralloc.c (r_alloc_check): Likewise.
4536 * regex.c (set_image_of_range_1, set_image_of_range)
4537 (regex_grow_registers): Likewise.
4538 * sysdep.c (strerror): Likewise.
4539 * termcap.c (valid_filename_p, tprint, main): Likewise.
4540 * tparam.c (main): Likewise.
4541 * unexhp9k800.c (run_time_remap, save_data_space)
4542 (update_file_ptrs, read_header, write_header, calculate_checksum)
4543 (copy_file, copy_rest, display_header): Likewise.
4544 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4546 * xdisp.c (check_it): Likewise.
4547 * xfaces.c (register_color, unregister_color, unregister_colors):
4549 * xfns.c (print_fontset_result): Likewise.
4550 * xrdb.c (member, fatal, main): Likewise.
4552 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4554 Fix minor problems found by static checking (Bug#9031).
4555 * chartab.c (char_table_set_range, map_sub_char_table):
4556 Remove unused locals.
4557 (uniprop_table): Now static.
4558 * composite.c (_work_char): Remove unused static var.
4560 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4562 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4564 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4566 * gtkutil.c (qttip_cb): Remove code without function.
4568 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4570 * w32.c (pthread_sigmask): New stub.
4572 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4574 Use pthread_sigmask, not sigprocmask (Bug#9010).
4575 sigprocmask is portable only for single-threaded applications, and
4576 Emacs can be multi-threaded when it uses GTK.
4577 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4579 * callproc.c (Fcall_process):
4580 * process.c (create_process):
4581 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4582 Use pthread_sigmask, not sigprocmask.
4584 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4586 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4587 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4590 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4592 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4593 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4594 (xg_hide_tooltip): Fix comment.
4596 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4597 in registerServicesMenuSendTypes.
4598 (validRequestorForSendType): Don't check ns_return_types.
4600 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4603 2011-07-08 Jason Rumney <jasonr@gnu.org>
4605 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4606 SH_SHOW for hidden windows (Bug#5482).
4608 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4609 frame struct members of non-existent frames (Bug#6284).
4611 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4613 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4614 variable firstTime not needed on OSX >= 10.6.
4615 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4616 >= 10.5. Use setKnobProportion, setDoubleValue.
4618 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4619 (MAC_OS_X_VERSION_10_5): Define if not defined.
4620 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4621 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4622 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4624 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4625 cString and lossyCString on OSX >= 10.4
4627 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4628 sizeToFit on OSX >= 10.2.
4630 * nsimage.m (allocInitFromFile): Don't use deprecated method
4631 bestRepresentationForDevice on OSX >= 10.6.
4633 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4636 * emacs.c: Declare unexec_init_emacs_zone.
4638 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4640 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4642 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4643 on svcsMenu (Bug#8842).
4645 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4647 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4649 * nsterm.m (QUTF8_STRING): Declare.
4650 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4651 (validRequestorForSendType): Return type is (id).
4652 Change indexOfObjectIdenticalTo to indexOfObject.
4653 Check if we have local selection before returning self (Bug#8842).
4654 (writeSelectionToPasteboard): Put local selection into paste board
4655 if we have a local selection (Bug#8842).
4656 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4658 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4659 (ns_get_local_selection): Declare.
4661 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4663 * keymap.c (describe_map_tree): Don't insert a double newline at
4664 the end of the buffer (bug#1169) and return whether we inserted
4667 * callint.c (Fcall_interactively): Change "reading args" to
4668 "providing args" to try to clarify what it does (bug#1010).
4670 2011-07-07 Kenichi Handa <handa@m17n.org>
4672 * composite.c (composition_compute_stop_pos): Ignore a static
4673 composition starting before CHARPOS (Bug#8915).
4675 * xdisp.c (handle_composition_prop): Likewise.
4677 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4679 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4682 2011-07-07 Kenichi Handa <handa@m17n.org>
4684 * character.h (unicode_category_t): New enum type.
4686 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4687 (Qchar_code_property_table): New variable.
4688 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4689 (UNIPROP_COMPRESSED_FORM_P): New macros.
4690 (char_table_ascii): Uncompress the compressed values.
4691 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4692 Uncompress the compressed values.
4693 (sub_char_table_ref_and_range): Likewise.
4694 (char_table_ref_and_range): Uncompress the compressed values.
4695 (sub_char_table_set): New arg is_uniprop. Callers changed.
4696 Uncompress the compressed values.
4697 (sub_char_table_set_range): Args changed. Callers changed.
4698 (char_table_set_range): Adjuted for the above change.
4699 (map_sub_char_table): Delete args default_val and parent. Add arg
4700 top. Give decoded values to a Lisp function.
4701 (map_char_table): Adjust for the above change. Give decoded
4702 values to a Lisp function. Gcpro more variables.
4703 (uniprop_table_uncompress)
4704 (uniprop_decode_value_run_length): New functions.
4705 (uniprop_decoder, uniprop_decoder_count): New variables.
4706 (uniprop_get_decoder, uniprop_encode_value_character)
4707 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4709 (uniprop_encoder, uniprop_encoder_count): New variables.
4710 (uniprop_get_encoder, uniprop_table)
4711 (Funicode_property_table_internal, Fget_unicode_property_internal)
4712 (Fput_unicode_property_internal): New functions.
4713 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4714 Sunicode_property_table_internal, Sget_unicode_property_internal,
4715 and Sput_unicode_property_internal. Defvar_lisp
4716 char-code-property-alist.
4718 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4719 Vunicode_category_table.
4721 * font.c (font_range): Adjust for the change of
4722 Vunicode_category_table.
4724 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4726 * m/iris4d.h: Remove file, move contents ...
4727 * s/irix6-5.h: ... here.
4729 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4731 Remove unportable assumption about struct layout (Bug#8884).
4732 * alloc.c (mark_buffer):
4733 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4734 (clone_per_buffer_values): Don't assume that
4735 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4736 This isn't true in general, and it's particularly not true
4737 if Emacs is configured with --with-wide-int.
4738 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4739 New macros, used in the buffer.c change.
4741 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4743 * xsettings.c: Use both GConf and GSettings if both are available.
4744 (store_config_changed_event): Add comment.
4745 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4746 (store_tool_bar_style_changed): New functions.
4747 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4748 (struct xsettings): Move font inside HAVE_XFT.
4749 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4750 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4751 Move inside HAVE_XFT.
4752 (something_changed_gsettingsCB): Rename from something_changedCB.
4753 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4755 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4756 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4757 (something_changed_gconfCB): Rename from something_changedCB.
4758 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4759 (parse_settings): Move check for font inside HAVE_XFT.
4760 (read_settings, apply_xft_settings): Add comment.
4761 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4762 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4763 call store_font_name_changed.
4764 (xft_settings_event): Add comment.
4765 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4766 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4767 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4768 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4769 (xsettings_initialize): Call init_gsettings last.
4770 (xsettings_get_system_font, xsettings_get_system_normal_font):
4773 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4775 Random fixes. E.g., (random) never returned negative values.
4776 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4777 subseconds part to the entropy, as that's a bit more random.
4778 Prefer signed to unsigned, since the signedness doesn't matter and
4779 in general we prefer signed. When given a limit, use a
4780 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4781 latter isn't right if USE_2_TAGS_FOR_INTS.
4782 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4783 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4785 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4787 * textprop.c (text_property_stickiness):
4788 Obey Vtext_property_default_nonsticky.
4789 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4790 * w32fns.c (syms_of_w32fns):
4791 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4793 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4795 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4796 This is more efficient than Ffile_directory_p and avoids a minor race.
4798 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4800 * buffer.c (Foverlay_put): Say what the return value is
4803 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4804 is a directory before asking whether to use the file name
4806 (barf_or_query_if_file_exists): Make the "File is a directory"
4807 error be more correct.
4809 * fns.c (Frequire): Remove the mention of the .gz files, since
4810 that's installation-specific, but keep the mention of
4811 `get-load-suffixes'.
4813 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4815 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4816 Report string overflow if the output is too long.
4818 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4820 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4821 (syms_of_gnutls): Remove duplicate DEFSYM for
4822 Qgnutls_bootprop_verify_hostname_error, an error for
4823 Qgnutls_bootprop_verify_error (which is no longer used).
4825 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4826 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4827 Also (re)move comments that are misplaced or no longer relevant.
4829 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4831 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4833 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4835 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4836 and background color parameters if they have been changed.
4838 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4840 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4842 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4844 * xsettings.c (SYSTEM_FONT): Define only when used.
4845 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4847 * keymap.c (access_keymap_1): Now static.
4849 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4851 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4852 leave any prefix arg for the up event (Bug#1586).
4854 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4856 * lread.c (syms_of_lread): Mention single symbols defined by
4857 `defvar' or `defconst' (bug#7154).
4859 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4860 (Frequire): Mention get-load-suffixes.
4862 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4864 * window.h (window): Remove clone_number slot.
4865 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4867 (make_parent_window, make_window, saved_window)
4868 (Fset_window_configuration, save_window_save): Don't deal with
4870 * buffer.c (Qclone_number): Remove declaration.
4871 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4873 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4875 Add multiple inheritance to keymaps.
4876 * keymap.c (Fmake_composed_keymap): New function.
4877 (Fset_keymap_parent): Simplify.
4878 (fix_submap_inheritance): Remove.
4879 (access_keymap_1): New function extracted from access_keymap to handle
4880 embedded parents and handle lists of maps.
4881 (access_keymap): Use it.
4882 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4883 (Fcopy_keymap): Handle embedded parents.
4884 (Fcommand_remapping, define_as_prefix): Simplify.
4885 (Fkey_binding): Simplify.
4886 (syms_of_keymap): Move minibuffer-local-completion-map,
4887 minibuffer-local-filename-completion-map,
4888 minibuffer-local-must-match-map, and
4889 minibuffer-local-filename-must-match-map to Elisp.
4890 (syms_of_keymap): Defsubr make-composed-keymap.
4891 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4892 (parse_menu_item): Trivial simplification.
4894 2011-07-01 Glenn Morris <rgm@gnu.org>
4896 * Makefile.in (SETTINGS_LIBS): Fix typo.
4898 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4900 * coding.c (Fencode_coding_string): Record the last coding system
4901 used, as the function doc string says (bug#8738).
4903 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4905 * xsettings.c (store_monospaced_changed): Take new font as arg and
4906 check for change against current_mono_font.
4907 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4908 (emacs_settings_constructor, emacs_settings_get_property)
4909 (emacs_settings_set_property, emacs_settings_class_init)
4910 (emacs_settings_init, gsettings_obj): Remove.
4911 (something_changedCB): New function for HAVE_GSETTINGS.
4912 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4913 with value as argument.
4914 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4915 g_settings_new (Bug#8967). Do not create gsettings_obj.
4916 Remove calls to g_settings_bind. Connect something_changedCB to
4919 * xgselect.c: Add defined (HAVE_GSETTINGS).
4920 (xgselect_initialize): Ditto.
4922 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4923 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4926 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4928 * eval.c (struct backtrace): Simplify and port the data structure.
4929 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4930 signed bit field, as this assumption is not portable and it makes
4931 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4932 "char debug_on_exit : 1" as this is not portable either; instead,
4933 use the portable "unsigned int debug_on_exit : 1". Remove unused
4934 member evalargs. Remove obsolete comments about cc bombing out.
4936 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4938 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4939 Let HAVE_GSETTINGS override HAVE_GCONF.
4940 (store_monospaced_changed): New function.
4941 (EMACS_SETTINGS): A new type derived from GObject to handle
4942 GSettings notifications.
4943 (emacs_settings_constructor, emacs_settings_get_property)
4944 (emacs_settings_set_property, emacs_settings_class_init):
4946 (gsettings_client, gsettings_obj): New variables.
4947 (GSETTINGS_SCHEMA): New define.
4948 (something_changedCB): Call store_monospaced_changed.
4949 (init_gsettings): New function.
4950 (xsettings_initialize): Call init_gsettings.
4951 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4954 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4957 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4959 * window.c (resize_root_window, grow_mini_window)
4960 (shrink_mini_window): Rename Qresize_root_window to
4961 Qwindow_resize_root_window and Qresize_root_window_vertically to
4962 Qwindow_resize_root_window_vertically.
4964 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4966 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4968 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4970 * makefile.w32-in: Redesign dependencies so they reflect more
4971 clearly which files are directly included by each source file,
4972 and not through other includes.
4974 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4976 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4977 (sort_overlays, overlay_strings): When an overlay's clone number
4978 matches the window's clone number process the overlay even if
4979 the overlay's window property doesn't match the current window.
4981 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4982 (Fwindow_hchild): Rename to Fwindow_left_child.
4983 (Fwindow_next): Rename to Fwindow_next_sibling.
4984 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4985 (resize_window_check): Rename to window_resize_check.
4986 (resize_window_apply): Rename to window_resize_apply.
4987 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4988 (Fdelete_other_windows_internal, resize_frame_windows)
4989 (Fsplit_window_internal, Fdelete_window_internal)
4990 (grow_mini_window, shrink_mini_window)
4991 (Fresize_mini_window_internal): Fix callers accordingly.
4993 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4995 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4996 (emacs_fixed_set_min_size): Remove.
4997 (emacs_fixed_new): Take frame as argument.
4999 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5000 (_EmacsFixedPrivate): Remove minwidth/height.
5001 Add struct frame *f.
5002 (emacs_fixed_init): Initialize priv->f.
5003 (get_parent_class, emacs_fixed_set_min_size): Remove.
5004 (emacs_fixed_new): Set priv->f to argument.
5005 (emacs_fixed_get_preferred_width)
5006 (emacs_fixed_get_preferred_height): Use min_width/height from
5007 frames size_hint to set minimum and natural (Bug#8919).
5008 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5009 and use min_width/height from frames size_hint to set
5010 min_width/height (Bug#8919).
5012 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5013 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5016 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5018 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5019 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5022 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5024 * process.c (wait_reading_process_output): Bypass select if
5025 waiting for a cell while ignoring keyboard input, and input is
5026 pending. Suggested by Jan Djärv (Bug#8869).
5028 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5030 Use gnulib's dup2 module instead of rolling our own.
5031 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5033 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5035 * dispnew.c (scrolling_window): Before scrolling, turn off a
5036 mouse-highlight in the window being scrolled.
5038 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5040 Move DEFSYM to lisp.h and use everywhere.
5042 * character.h (DEFSYM): Move declaration...
5043 * lisp.h (DEFSYM): ...here.
5049 * w32select.c: Don't include character.h.
5051 * alloc.c (syms_of_alloc):
5052 * buffer.c (syms_of_buffer):
5053 * bytecode.c (syms_of_bytecode):
5054 * callint.c (syms_of_callint):
5055 * casefiddle.c (syms_of_casefiddle):
5056 * casetab.c (init_casetab_once):
5057 * category.c (init_category_once, syms_of_category):
5058 * ccl.c (syms_of_ccl):
5059 * cmds.c (syms_of_cmds):
5060 * composite.c (syms_of_composite):
5061 * dbusbind.c (syms_of_dbusbind):
5062 * dired.c (syms_of_dired):
5063 * dispnew.c (syms_of_display):
5064 * doc.c (syms_of_doc):
5065 * editfns.c (syms_of_editfns):
5066 * emacs.c (syms_of_emacs):
5067 * eval.c (syms_of_eval):
5068 * fileio.c (syms_of_fileio):
5069 * fns.c (syms_of_fns):
5070 * frame.c (syms_of_frame):
5071 * fringe.c (syms_of_fringe):
5072 * insdel.c (syms_of_insdel):
5073 * keymap.c (syms_of_keymap):
5074 * lread.c (init_obarray, syms_of_lread):
5075 * macros.c (syms_of_macros):
5076 * msdos.c (syms_of_msdos):
5077 * print.c (syms_of_print):
5078 * process.c (syms_of_process):
5079 * search.c (syms_of_search):
5080 * sound.c (syms_of_sound):
5081 * syntax.c (init_syntax_once, syms_of_syntax):
5082 * terminal.c (syms_of_terminal):
5083 * textprop.c (syms_of_textprop):
5084 * undo.c (syms_of_undo):
5085 * w32.c (globals_of_w32):
5086 * window.c (syms_of_window):
5087 * xdisp.c (syms_of_xdisp):
5088 * xfaces.c (syms_of_xfaces):
5089 * xfns.c (syms_of_xfns):
5090 * xmenu.c (syms_of_xmenu):
5091 * xsettings.c (syms_of_xsettings):
5092 * xterm.c (syms_of_xterm): Use DEFSYM.
5094 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5096 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5098 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5100 Integer and buffer overflow fixes (Bug#8873).
5102 * print.c (printchar, strout): Check for string overflow.
5103 (PRINTPREPARE, printchar, strout):
5104 Don't set size unless allocation succeeds.
5106 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5107 for sizes. Check for string overflow more accurately.
5108 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5110 * macros.c: Integer and buffer overflow fixes.
5111 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5112 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5113 Use ptrdiff_t, not int, for sizes.
5114 Don't increment bufsize until after realloc succeeds.
5115 Check for size-calculation overflow.
5116 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5118 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5120 * lread.c: Integer overflow fixes.
5121 (read_integer): Radix is now EMACS_INT, not int,
5122 to improve quality of diagnostics for out-of-range radices.
5123 Calculate buffer size correctly for out-of-range radices.
5124 (read1): Check for integer overflow in radices, and in
5125 read-circle numbers.
5126 (read_escape): Avoid int overflow.
5127 (Fload, openp, read_buffer_size, read1)
5128 (substitute_object_recurse, read_vector, read_list, map_obarray):
5129 Use ptrdiff_t, not int, for sizes.
5130 (read1): Use EMACS_INT, not int, for sizes.
5131 Check for size overflow.
5133 * image.c (cache_image): Check for size arithmetic overflow.
5135 * lread.c: Integer overflow issues.
5136 (saved_doc_string_size, saved_doc_string_length)
5137 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5138 Now ptrdiff_t, not int.
5139 (read1): Don't assume doc string length fits in int. Check for
5140 out-of-range doc string lengths.
5141 (read_list): Don't assume file position fits in int.
5142 (read_escape): Check for hex character overflow.
5144 2011-06-22 Leo Liu <sdl.web@gmail.com>
5146 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5147 Move to minibuffer.el.
5149 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5151 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5152 The following patches are for when GLYPH_DEBUG && !XASSERT.
5153 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5154 * dispnew.c (flush_stdout):
5155 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5156 Mark as externally visible.
5157 * dispnew.c (check_window_matrix_pointers): Now static.
5158 * dispnew.c (window_to_frame_vpos):
5159 * xfns.c (unwind_create_frame):
5160 * xterm.c (x_check_font): Remove unused local.
5161 * scroll.c (CHECK_BOUNDS):
5162 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5163 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5164 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5165 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5166 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5168 (debug_method_add): Use va_list and vsprintf rather than relying
5169 on undefined behavior with wrong number of arguments.
5170 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5171 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5172 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5173 since we're not interested in debugging glyphs with old libraries.
5174 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5175 GCC 4.6.0's static checking.
5177 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5179 Integer overflow and signedness fixes (Bug#8873).
5180 A few related buffer overrun fixes, too.
5182 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5184 * dispextern.h (struct face.stipple):
5185 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5186 (x_bitmap_mask, x_allocate_bitmap_record)
5187 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5188 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5189 (x_create_bitmap_from_xpm_data):
5190 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5191 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5193 * xfaces.c (load_pixmap):
5194 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5195 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5196 (.bitmaps_last, struct x_output.icon_bitmap):
5197 Use ptrdiff_t, not int, for bitmap indexes.
5198 (x_allocate_bitmap_record): Check for size overflow.
5199 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5201 Use ptrdiff_t, not int, for overlay counts.
5202 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5203 * editfns.c (overlays_around, get_pos_property):
5204 * textprop.c (get_char_property_and_overlay):
5205 * xdisp.c (next_overlay_change, note_mouse_highlight):
5206 * xfaces.c (face_at_buffer_position):
5207 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5208 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5209 (Fnext_overlay_change, Fprevious_overlay_change)
5210 (mouse_face_overlay_overlaps, Foverlays_in):
5211 Use ptrdiff_t, not int, for sizes.
5212 (overlays_at, overlays_in): Check for size-calculation overflow.
5214 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5216 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5217 (x_session_initialize): Do not assume string length fits in int.
5219 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5220 This is unlikely, but can occur if DPI is outlandish.
5222 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5223 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5225 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5226 * xrdb.c (magic_file_p, search_magic_path):
5227 Omit last arg SUFFIX; it was always 0. All callers changed.
5228 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5230 * xfont.c (xfont_match): Avoid need for strlen.
5232 * xfns.c: Don't assume strlen fits in int.
5233 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5235 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5236 not unsigned long, as we prefer signed integers. All callers changed.
5237 Detect integer overflow in repeat count.
5238 (message_dolog): Don't assume print length fits in 39 bytes.
5239 (display_mode_element): Don't assume strlen fits in int.
5241 * termcap.c: Don't assume sizes fit in int and never overflow.
5242 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5243 (gobble_line): Check for size-calculation overflow.
5245 * minibuf.c (Fread_buffer):
5246 * lread.c (intern, intern_c_string):
5247 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5248 Don't assume string length fits in int.
5250 * keyboard.c (parse_tool_bar_item):
5251 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5253 * font.c: Don't assume string length fits in int.
5254 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5255 Use ptrdiff_t, not int.
5256 (font_intern_prop): Don't assume string length fits in int.
5257 Don't assume integer property fits in fixnum.
5258 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5260 * filelock.c: Fix some buffer overrun and integer overflow issues.
5261 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5262 Reformulate so as not to need the command string.
5263 Invoke gzip -cd rather than gunzip, as it's more portable.
5264 (lock_info_type, lock_file_1, lock_file):
5265 Don't assume pid_t and time_t fit in unsigned long.
5266 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5267 (current_lock_owner): Prefer signed type for sizes.
5268 Use memcpy, not strncpy, where memcpy is what is really wanted.
5269 Don't assume (via atoi) that time_t and pid_t fit in int.
5270 Check for time_t and/or pid_t out of range, e.g., via a network share.
5271 Don't alloca where an auto var works fine.
5273 * fileio.c: Fix some integer overflow issues.
5274 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5275 Don't assume string length fits in int.
5276 (directory_file_name): Don't assume string length fits in long.
5277 (make_temp_name): Don't assume pid fits in int, or that its print
5278 length is less than 20.
5280 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5282 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5284 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5286 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5287 We prefer signed integers, even for size calculations.
5289 * emacs.c: Don't assume string length fits in 'int'.
5290 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5291 (main): Don't invoke strlen when not needed.
5293 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5294 (XD_DEBUG_MESSAGE): Don't waste a byte.
5296 * callproc.c (getenv_internal_1, getenv_internal)
5298 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5300 * lread.c (invalid_syntax): Omit length argument.
5301 All uses changed. This doesn't fix a bug, but it simplifies the
5302 code away from its former Hollerith-constant appearance, and it's
5303 one less 'int' to worry about when looking at integer-overflow issues.
5304 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5306 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5307 This didn't break anything, but it didn't help either.
5308 It's confusing to put a bogus integer in a place where the actual
5309 value does not matter.
5310 (LIST_END_P): Remove unused macro and its bogus comment.
5311 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5313 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5314 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5316 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5317 We prefer signed types, and the value cannot exceed the EMACS_INT
5318 range anyway (because otherwise the length would not be representable).
5319 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5320 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5321 This avoids a GCC warning when WIDE_EMACS_INT.
5323 * indent.c (sane_tab_width): New function.
5324 (current_column, scan_for_column, Findent_to, position_indentation)
5325 (compute_motion): Use it. This is just for clarity.
5326 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5328 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5330 * lisp.h (lint_assume): New macro.
5331 * composite.c (composition_gstring_put_cache):
5332 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5334 * editfns.c, insdel.c:
5335 Omit unnecessary forward decls, to simplify future changes.
5337 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5339 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5341 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5342 Use much-faster test for byte-length change.
5343 Don't assume string byte-length fits in 'int'.
5344 Check that character arg fits in 'int'.
5345 (mapcar1): Declare byte as byte, for clarity.
5347 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5349 * fns.c (concat): Catch string overflow earlier.
5350 Do not rely on integer wraparound.
5352 * dispextern.h (struct it.overlay_strings_charpos)
5353 (struct it.selective): Now EMACS_INT, not int.
5354 * xdisp.c (forward_to_next_line_start)
5355 (back_to_previous_visible_line_start)
5356 (reseat_at_next_visible_line_start, next_element_from_buffer):
5357 Don't arbitrarily truncate the value of 'selective' to int.
5359 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5361 * composite.c: Don't truncate sizes to 'int'.
5362 (composition_gstring_p, composition_reseat_it)
5363 (composition_adjust_point): Use EMACS_INT, not int.
5364 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5365 not EMACS_UINT, for indexes.
5367 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5369 * buffer.c: Include <verify.h>.
5370 (struct sortvec.priority, struct sortstr.priority):
5371 Now EMACS_INT, not int.
5372 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5373 (struct sortstr.size, record_overlay_string)
5374 (struct sortstrlist.size, struct sortlist.used):
5375 Don't truncate size to int.
5376 (record_overlay_string): Check for size-calculation overflow.
5377 (init_buffer_once): Check at compile-time, not run-time.
5379 2011-06-22 Jim Meyering <meyering@redhat.com>
5381 Don't leak an XBM-image-sized buffer
5382 * image.c (xbm_load): Free the image buffer after using it.
5384 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5387 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5388 that Sun C diagnosed.
5389 * fns.c (secure_hash): Fix pointer signedness issue.
5390 * intervals.c (static_offset_intervals): New function.
5391 (offset_intervals): Use it.
5393 2011-06-21 Leo Liu <sdl.web@gmail.com>
5396 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5399 * fns.c (secure_hash): Rename from crypto_hash_function and change
5400 the first arg to accept symbols.
5401 (Fsecure_hash): New primitive.
5402 (syms_of_fns): New symbols.
5404 2011-06-20 Deniz Dogan <deniz@dogan.se>
5406 * process.c (Fset_process_buffer): Clarify return value in
5409 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5411 * dispnew.c (add_window_display_history): Use BVAR.
5413 * xdisp.c (debug_method_add): Use BVAR.
5414 (check_window_end, dump_glyph_matrix, dump_glyph)
5415 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5417 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5420 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5421 check till after the cache is created in init_frame_faces.
5423 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5425 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5427 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5429 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5430 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5431 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5433 Improve buffer-overflow checking (Bug#8873).
5434 * fileio.c (Finsert_file_contents):
5435 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5436 Remove the old (too-loose) buffer overflow checks.
5437 They weren't needed, since make_gap checks for buffer overflow.
5438 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5439 The old code merely checked for Emacs fixnum overflow, and relied
5440 on undefined (wraparound) behavior. The new code avoids undefined
5441 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5443 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5444 Tune. Don't use wider integers than needed. Don't use alloca.
5445 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5447 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5449 * insdel.c, lisp.h (buffer_overflow): New function.
5450 (insert_from_buffer_1, replace_range, replace_range_2):
5451 * insdel.c (make_gap_larger):
5452 * editfns.c (Finsert_char):
5453 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5455 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5457 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5459 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5461 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5462 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5464 * fileio.c: Don't assume EMACS_INT fits in off_t.
5465 (emacs_lseek): New static function.
5466 (Finsert_file_contents, Fwrite_region): Use it.
5467 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5469 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5471 * fns.c: Don't overflow int when computing a list length.
5472 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5473 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5474 truncation on 64-bit hosts. Check for QUIT every
5475 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5476 faster and is responsive enough.
5477 (Flength): Report an error instead of overflowing an integer.
5478 (Fsafe_length): Return a float if the value is not representable
5479 as a fixnum. This shouldn't happen except in contrived situations.
5480 (Fnthcdr, Fsort): Don't assume list length fits in int.
5481 (Fcopy_sequence): Don't assume vector length fits in int.
5483 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5484 (header_size, word_size): New constants.
5485 (allocate_vectorlike): Don't check size overflow here.
5486 (allocate_vector): Check it here instead, since this is the only
5487 caller of allocate_vectorlike that could cause overflow.
5488 Check that the new vector's length is representable as a fixnum.
5490 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5491 The previous code was bogus. For example, next_almost_prime (32)
5492 returned 39, which is undesirable as it is a multiple of 3; and
5493 next_almost_prime (24) returned 25, which is a multiple of 5 so
5494 why was the code bothering to check for multiples of 7?
5496 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5498 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5500 Variadic C functions now count arguments with ptrdiff_t.
5501 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5502 Back then I didn't know that the Emacs coding style prefers signed int.
5503 Also, in the meantime I found a few more instances where arguments
5504 were being counted with int, which may truncate counts on 64-bit
5505 machines, or EMACS_INT, which may be unnecessarily wide.
5506 * lisp.h (struct Lisp_Subr.function.aMANY)
5507 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5508 Arg counts are now ptrdiff_t, not size_t.
5509 All variadic functions and their callers changed accordingly.
5510 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5511 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5512 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5513 * callint.c (Fcall_interactively): Check arg count for overflow,
5514 to avoid potential buffer overrun. Use signed char, not 'int',
5515 for 'varies' array, so that we needn't bother to check its size
5516 calculation for overflow.
5517 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5518 * eval.c (apply_lambda):
5519 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5520 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5521 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5523 * callint.c (Fcall_interactively): Don't use index var as event count.
5525 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5526 * mem-limits.h (SIZE): Remove; no longer used.
5528 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5530 Remove unnecessary casts.
5531 * xterm.c (x_term_init):
5532 * xfns.c (x_set_border_pixel):
5533 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5534 These aren't needed now that we assume ANSI C.
5536 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5537 It's more likely to cause problems (due to unsigned overflow)
5540 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5542 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5544 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5546 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5548 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5550 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5552 GLYPH_CODE_FACE returns EMACS_INT, not int.
5553 * dispextern.h (merge_faces):
5554 * xfaces.c (merge_faces):
5555 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5556 Don't assume EMACS_INT fits in int.
5558 * character.h (CHAR_VALID_P): Remove unused parameter.
5559 * fontset.c, lisp.h, xdisp.c: All uses changed.
5561 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5563 * fns.c (concat): Minor tuning based on overflow analysis.
5564 This doesn't fix any bugs. Use int to hold character, instead
5565 of constantly refetching from Emacs object. Use XFASTINT, not
5566 XINT, for value known to be a character. Don't bother comparing
5567 a single byte to 0400, as it's always less.
5569 * floatfns.c (Fexpt):
5570 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5572 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5575 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5577 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5578 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5579 incorrectly succeed when S was a string, because 4294967386 was
5580 truncated before it was used.
5582 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5583 Otherwise, an out-of-range integer could cause undefined behavior
5586 * composite.c: Use int, not EMACS_INT, for characters.
5587 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5588 EMACS_INT, for values that are known to be in character range.
5589 This doesn't fix any bugs but is the usual style inside Emacs and
5590 may generate better code on 32-bit machines.
5592 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5593 This is for reasons similar to the recent CHAR_STRING fix.
5594 * charset.c (Fencode_char): Check that character arg is actually
5595 a character. Pass an int to ENCODE_CHAR.
5596 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5597 wider than 'int', as a compile-time check to prevent future regressions
5600 * character.c (char_string): Remove unnecessary casts.
5602 Make sure a 64-bit char is never passed to CHAR_STRING.
5603 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5604 by silently ignoring the top 32 bits, allowing some values
5605 that were far too large to be valid characters.
5606 * character.h: Include <verify.h>.
5607 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5608 arguments are no wider than unsigned, as a compile-time check
5609 to prevent future regressions in this area.
5611 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5612 (Fsubst_char_in_region):
5614 * xdisp.c (decode_mode_spec_coding):
5615 Adjust to CHAR_STRING's new requirement.
5616 * editfns.c (Finsert_char, Fsubst_char_in_region):
5617 * fns.c (concat): Check that character args are actually
5618 characters. Without this test, these functions did the wrong
5619 thing with wildly out-of-range values on 64-bit hosts.
5621 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5622 These casts should not be needed on 32-bit hosts, either.
5623 * keyboard.c (read_char):
5624 * lread.c (Fload): Remove casts to unsigned.
5626 * lisp.h (UNSIGNED_CMP): New macro.
5627 This fixes comparison bugs on 64-bit hosts.
5628 (ASCII_CHAR_P): Use it.
5629 * casefiddle.c (casify_object):
5630 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5631 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5632 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5633 * dispextern.h (FACE_FROM_ID):
5634 * keyboard.c (read_char): Use UNSIGNED_CMP.
5636 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5637 not to EMACS_INT, to avoid GCC warning.
5639 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5641 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5642 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5643 isn't needed on 32-bit machines.
5645 * buffer.c (Fgenerate_new_buffer_name):
5646 Use EMACS_INT for count, not int.
5647 (advance_to_char_boundary): Return EMACS_INT, not int.
5649 * data.c (Qcompiled_function): Now static.
5651 * window.c (window_body_lines): Now static.
5653 * image.c (gif_load): Rename local to avoid shadowing.
5655 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5656 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5657 * alloc.c (make_save_value): Integer argument is now of type
5659 (mark_object): Use ptrdiff_t, not int.
5660 * lisp.h (pD): New macro.
5661 * print.c (print_object): Use it.
5663 * alloc.c: Use EMACS_INT, not int, to count objects.
5664 (total_conses, total_markers, total_symbols, total_vector_size)
5665 (total_free_conses, total_free_markers, total_free_symbols)
5666 (total_free_floats, total_floats, total_free_intervals)
5667 (total_intervals, total_strings, total_free_strings):
5668 Now EMACS_INT, not int. All uses changed.
5669 (Fgarbage_collect): Compute overall total using a double, so that
5670 integer overflow is less likely to be a problem. Check for overflow
5671 when converting back to an integer.
5672 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5673 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5674 These were 'int' variables that could overflow on 64-bit hosts;
5675 they were never used, so remove them instead of repairing them.
5676 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5677 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5678 Previously, this ceilinged at INT_MAX, but that doesn't work on
5680 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5682 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5683 (allocate_vectorlike): Check for ptrdiff_t overflow.
5684 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5685 when a (possibly-narrower) signed value would do just as well.
5686 We prefer using signed arithmetic, to avoid comparison confusion.
5688 * alloc.c: Catch some string size overflows that we were missing.
5689 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5690 for convenience in STRING_BYTES_MAX.
5691 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5692 The definition here is exact; the one in lisp.h was approximate.
5693 (allocate_string_data): Check for string overflow. This catches
5694 some instances we weren't catching before. Also, it catches
5695 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5696 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5697 and ptrdiff_t and EMACS_INT are both 64 bits.
5699 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5700 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5701 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5703 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5705 * alloc.c (Fmake_string): Check for out-of-range init.
5707 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5709 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5711 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5713 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5714 xg_get_default_scrollbar_width.
5716 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5717 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5718 (style_changed_cb): Call update_theme_scrollbar_width and call
5719 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5720 all frames (Bug#8505).
5721 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5722 Call gtk_window_set_resizable if HAVE_GTK3.
5723 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5724 and height if HAVE_GTK3 (Bug#8505).
5725 (scroll_bar_width_for_theme): New variable.
5726 (update_theme_scrollbar_width): New function.
5727 (xg_get_default_scrollbar_width): Move code to
5728 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5729 (xg_initialize): Call update_theme_scrollbar_width.
5731 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5733 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5735 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5737 * frame.c (make_frame): Call other_buffer_safely instead of
5740 * window.c (temp_output_buffer_show): Call display_buffer with
5741 second argument Vtemp_buffer_show_specifiers and reset latter
5742 immediately after the call.
5743 (Vtemp_buffer_show_specifiers): New variable.
5744 (auto_window_vscroll_p, next_screen_context_lines)
5745 (Vscroll_preserve_screen_position): Remove leading asterisks from
5748 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5750 Fix minor problems found by GCC 4.6.0 static checking.
5751 * buffer.c (Qclone_number): Remove for now, as it's unused.
5752 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5753 (record_buffer): Remove unused local.
5754 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5755 (set_frame_buffer_list): Remove; unused.
5756 * frame.h (other_visible_frames): Remove decl.
5757 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5758 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5759 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5761 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5762 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5763 Define only if HAVE_GPM.
5764 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5765 (update_hints_inhibit): Remove; never set. All uses removed.
5766 * widgetprv.h (emacsFrameClassRec): Remove decl.
5767 * window.c (delete_deletable_window): Now returns void, since it
5768 wasn't returning anything.
5769 (compare_window_configurations): Remove unused locals.
5770 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5771 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5772 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5773 the same widths as pointers. This follows up on the 2011-05-06 patch.
5774 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5775 * xterm.h: Likewise.
5776 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5778 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5780 * makefile.w32-in: Update dependencies.
5781 (LISP_H): Add lib/intprops.h.
5783 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5785 * image.c (gif_load): Add animation frame delay to the metadata.
5786 (syms_of_image): Use DEFSYM. New symbol `delay'.
5788 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5790 * window.c (delete_deletable_window): Re-add.
5791 (Fset_window_configuration): Rewrite to handle dead buffers and
5792 consequently deletable windows.
5793 (window_tree, Fwindow_tree): Remove. Supply functionality in
5795 (compare_window_configurations): Simplify code.
5797 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5799 * image.c (imagemagick_load_image): Fix type mismatch.
5800 (Fimagemagick_types): Likewise.
5802 * window.h (replace_buffer_in_windows): Declare.
5804 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5806 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5807 Qclone_number. Remove external declaration of Qdelete_window.
5808 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5810 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5811 Run Qbuffer_list_update_hook if allowed.
5812 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5813 buffer list implementation.
5814 (other_buffer_safely): New function.
5815 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5816 calls to replace_buffer_in_windows and
5817 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5819 (record_buffer): Inhibit quitting and rewrite using quittable
5820 functions. Run Qbuffer_list_update_hook if allowed.
5821 (Frecord_buffer, Funrecord_buffer): New functions.
5822 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5823 Move switch-to-buffer to window.el.
5824 (bury-buffer): Move to window.el.
5825 (Vbuffer_list_update_hook): New variable.
5827 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5830 * window.h (resize_frame_windows): Move up in code.
5831 (Fwindow_frame): Remove EXFUN.
5832 (replace_buffer_in_all_windows): Remove prototype.
5833 (replace_buffer_in_windows_safely): Add prototype.
5835 * window.c: Declare Qdelete_window static again. Move down
5836 declaration of select_count.
5837 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5838 (Fother_window): Move to window.el.
5839 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5840 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5841 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5843 (replace_buffer_in_windows): Implement by calling
5844 Qreplace_buffer_in_windows.
5845 (replace_buffer_in_all_windows): Remove with some functionality
5846 moved into replace_buffer_in_windows_safely.
5847 (replace_buffer_in_windows_safely): New function.
5848 (select_window_norecord, select_frame_norecord): Move in front
5849 of run_window_configuration_change_hook. Remove now obsolete
5851 (Fset_window_buffer): Rewrite doc-string.
5852 Call Qrecord_window_buffer.
5853 (keys_of_window): Move binding for other-window to window.el.
5855 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5857 * dispextern.h (struct image): Replace data member, whose int_val
5858 and ptr_val fields were not used by anything, with a single
5861 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5862 (gif_clear_image, gif_load, imagemagick_load_image)
5863 (gs_clear_image, gs_load): Callers changed.
5865 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5867 * buffer.h: Include <time.h>, for time_t.
5868 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5870 Fix minor problems found by static checking.
5872 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5874 Make identifiers static if they are not used in other modules.
5875 * data.c (Qcompiled_function, Qframe, Qvector):
5876 * image.c (QimageMagick, Qsvg):
5877 * minibuf.c (Qmetadata):
5878 * window.c (resize_window_check, resize_root_window): Now static.
5879 * window.h (resize_window_check, resize_root_window): Remove decls.
5881 * window.c (window_deletion_count, delete_deletable_window):
5883 (window_body_lines): Now static.
5884 (Fdelete_other_windows_internal): Mark vars as initialized.
5885 Make sure 'resize_failed' is initialized.
5886 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5887 (resize_window_apply): Remove unused local.
5888 * window.h (delete_deletable_window): Remove decl.
5890 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5891 (imagemagick_load_image): Fix pointer signedness problem by changing
5892 last arg from unsigned char * to char *. All uses changed.
5893 Also, fix a local for similar reasons.
5894 Remove unused locals. Remove locals to avoid shadowing.
5895 (fn_rsvg_handle_free): Remove; unused.
5896 (svg_load, svg_load_image): Fix pointer signedness problem.
5897 (imagemagick_load_image): Don't use garbage pointer image_wand.
5899 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5901 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5903 * image.c (gif_load): Fix omitted cast error introduced by
5906 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5908 * window.h (resize_proportionally, orig_total_lines)
5909 (orig_top_line): Remove from window structure.
5910 (set_window_height, set_window_width, change_window_heights)
5911 (Fdelete_window): Remove prototypes.
5912 (resize_frame_windows): Remove duplicate declaration.
5914 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5916 * window.h (resize_frame_windows, resize_window_check)
5917 (delete_deletable_window, resize_root_window)
5918 (resize_frame_windows): Declare prototypes.
5920 * window.c (resize_window_apply): Make definition be "static" to
5921 match the prototype.
5923 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5925 * window.c: Remove declarations of Qwindow_size_fixed,
5926 window_min_size_1, window_min_size_2, window_min_size,
5927 size_window, window_fixed_size_p, enlarge_window, delete_window.
5928 Remove static from declaration of Qdelete_window, it's
5929 temporarily needed by Fbury_buffer.
5930 (replace_window): Don't assign orig_top_line and
5932 (Fdelete_window, delete_window): Remove. Window deletion is
5933 handled by window.el.
5934 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5935 Replace Fdelete_window calls with calls to Qdelete_window.
5936 (Fdelete_other_windows): Remove. Deleting other windows is
5937 handled by window.el.
5938 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5939 handled in window.el.
5940 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5941 Window minimum sizes are handled in window.el.
5942 (shrink_windows, size_window, set_window_height)
5943 (set_window_width, change_window_heights, window_height)
5944 (window_width, CURBEG, CURSIZE, enlarge_window)
5945 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5946 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5947 handled in window.el.
5948 (make_dummy_parent): Rename to make_parent_window and give it a
5949 second argument horflag.
5950 (make_window): Don't set resize_proportionally any more.
5951 (Fsplit_window): Remove. Windows are split in window.el.
5952 (save_restore_action, save_restore_orig_size)
5953 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5954 Resize mini windows in window.el.
5955 (grow_mini_window, shrink_mini_window): Implement by calling
5956 Qresize_root_window_vertically, resize_window_check and
5957 resize_window_apply.
5958 (saved_window, Fset_window_configuration, save_window_save):
5959 Do not handle orig_top_line, orig_total_lines, and
5960 resize_proportionally.
5961 (window_min_height, window_min_width): Move to window.el.
5962 (keys_of_window): Move bindings for delete-other-windows,
5963 split-window, delete-window and enlarge-window to window.el.
5965 * buffer.c: Temporarily extern Qdelete_window.
5966 (Fbury_buffer): Temporarily call Qdelete_window instead of
5967 Fdelete_window (Fbury_buffer will move to window.el soon).
5969 * frame.c (set_menu_bar_lines_1): Remove code handling
5970 orig_top_line and orig_total_lines.
5972 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5973 set_window_height but set heights directly.
5974 (change_frame_size_1): Use resize_frame_windows.
5976 * xdisp.c (init_xdisp): Don't use set_window_height but set
5979 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5980 Use resize_frame_windows instead of change_window_heights and run
5981 run_window_configuration_change_hook.
5983 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5984 instead of change_window_heights and run
5985 run_window_configuration_change_hook.
5987 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5989 * window.c (replace_window): Rename second argument REPLACEMENT to
5990 NEW. New third argument SETFLAG. Rewrite.
5991 (delete_window, make_dummy_parent): Call replace_window with
5993 (window_list_1): Move down in code.
5994 (run_window_configuration_change_hook): Move set_buffer part
5995 before select_frame_norecord part in order to unwind correctly.
5996 Rename count1 to count.
5997 (recombine_windows, delete_deletable_window, resize_root_window)
5998 (Fdelete_other_windows_internal)
5999 (Frun_window_configuration_change_hook, make_parent_window)
6000 (resize_window_check, resize_window_apply, Fresize_window_apply)
6001 (resize_frame_windows, Fsplit_window_internal)
6002 (Fdelete_window_internal, Fresize_mini_window_internal):
6004 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6006 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6008 * window.h (window): Add some new members to window structure -
6009 normal_lines, normal_cols, new_total, new_normal, clone_number,
6010 splits, nest, prev_buffers, next_buffers.
6011 (WINDOW_TOTAL_SIZE): Move here from window.c.
6012 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6014 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6016 (make_dummy_parent): Set new members of windows structure.
6017 (make_window): Move down in code. Handle new members of window
6019 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6020 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6021 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6022 (Fset_window_prev_buffers, Fwindow_next_buffers)
6023 (Fset_window_next_buffers, Fset_window_clone_number):
6025 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6026 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6028 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6029 Argument WINDOW can be now internal window too.
6030 (Fwindow_use_time): Move up in code.
6031 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6033 (Fset_window_configuration, saved_window)
6034 (Fcurrent_window_configuration, save_window_save): Handle new
6035 members of window structure.
6036 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6037 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6038 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6039 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6040 Qget_mru_window, Qresize_root_window,
6041 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6042 Qauto_buffer_name; staticpro them.
6044 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6046 * window.c (Fwindow_total_size, Fwindow_left_column)
6047 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6048 (Fwindow_list_1): New functions.
6049 (window_box_text_cols): Replace with window_body_cols.
6050 (Fwindow_width, Fscroll_left, Fscroll_right):
6051 Use window_body_cols instead of window_box_text_cols.
6052 (delete_window, Fset_window_configuration):
6053 Call delete_all_subwindows with window as argument.
6054 (delete_all_subwindows): Take a window as argument and not a
6056 (window_loop): Remove handling of GET_LRU_WINDOW and
6058 (Fget_lru_window, Fget_largest_window): Move to window.el.
6060 * window.h: Extern window_body_cols instead of
6061 window_box_text_cols. delete_all_subwindows now takes a
6062 Lisp_Object as argument.
6064 * indent.c (compute_motion, Fcompute_motion):
6065 Use window_body_cols instead of window_box_text_cols.
6067 * frame.c (delete_frame): Call delete_all_subwindows with root
6070 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6072 * fns.c (Fputhash): Document return value.
6074 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6076 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6078 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6080 Cons<->int and similar integer overflow fixes (Bug#8794).
6082 Check for overflow when converting integer to cons and back.
6083 * charset.c (Fdefine_charset_internal, Fdecode_char):
6084 Use cons_to_unsigned to catch overflow.
6085 (Fencode_char): Use INTEGER_TO_CONS.
6086 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6087 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6088 * data.c (long_to_cons, cons_to_long): Remove.
6089 (cons_to_unsigned, cons_to_signed): New functions.
6090 These signal an error for invalid or out-of-range values.
6091 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6092 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6093 * font.c (Ffont_variation_glyphs):
6094 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6095 * lisp.h: Include <intprops.h>.
6096 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6097 (cons_to_signed, cons_to_unsigned): New decls.
6098 (long_to_cons, cons_to_long): Remove decls.
6099 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6100 (Fprimitive_undo): Use CONS_TO_INTEGER.
6101 * xfns.c (Fx_window_property): Likewise.
6102 * xselect.c: Include <limits.h>.
6103 (x_own_selection, selection_data_to_lisp_data):
6104 Use INTEGER_TO_CONS.
6105 (x_handle_selection_request, x_handle_selection_clear)
6106 (x_get_foreign_selection, Fx_disown_selection_internal)
6107 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6108 (lisp_data_to_selection_data): Use cons_to_unsigned.
6109 (x_fill_property_data): Use cons_to_signed.
6110 Report values out of range.
6112 Check for buffer and string overflow more precisely.
6113 * buffer.h (BUF_BYTES_MAX): New macro.
6114 * lisp.h (STRING_BYTES_MAX): New macro.
6115 * alloc.c (Fmake_string):
6116 * character.c (string_escape_byte8):
6117 * coding.c (coding_alloc_by_realloc):
6118 * doprnt.c (doprnt):
6119 * editfns.c (Fformat):
6121 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6122 since they may not be the same number.
6123 * editfns.c (Finsert_char):
6124 * fileio.c (Finsert_file_contents):
6125 Likewise for BUF_BYTES_MAX.
6127 * image.c: Use ptrdiff_t, not int, for sizes.
6128 (slurp_file): Switch from int to ptrdiff_t.
6130 (slurp_file): Check that file size fits in both size_t (for
6131 malloc) and ptrdiff_t (for sanity and safety).
6133 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6134 if b->modtime has its maximal value.
6136 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6138 Don't assume time_t can fit into int.
6139 * buffer.h (struct buffer.modtime): Now time_t, not int.
6140 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6141 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6143 Minor fixes for signed vs unsigned integers.
6144 * character.h (MAYBE_UNIFY_CHAR):
6145 * charset.c (maybe_unify_char):
6146 * keyboard.c (read_char, reorder_modifiers):
6147 XINT -> XFASTINT, since the integer must be nonnegative.
6148 * ftfont.c (ftfont_spec_pattern):
6149 * keymap.c (access_keymap, silly_event_symbol_error):
6150 XUINT -> XFASTINT, since the integer must be nonnegative.
6151 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6152 since it makes no difference and we prefer signed.
6153 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6154 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6157 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6159 * window.h (Fwindow_frame): Declare.
6161 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6163 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6164 (SPARE_MEMORY): Always define.
6165 (LARGE_REQUEST): Remove.
6166 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6168 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6170 * lisp.h: Move EXFUNS for Fframe_root_window,
6171 Fframe_first_window and Fset_frame_selected_window to window.h.
6173 * window.h: Move EXFUNS for Fframe_root_window,
6174 Fframe_first_window and Fset_frame_selected_window here from
6177 * frame.c (Fwindow_frame, Fframe_first_window)
6178 (Fframe_root_window, Fframe_selected_window)
6179 (Fset_frame_selected_window): Move to window.c.
6180 (Factive_minibuffer_window): Move to minibuf.c.
6181 (Fother_visible_frames_p): New function.
6183 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6185 * window.c (decode_window, decode_any_window): Move up in code.
6186 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6187 (inhibit_frame_unsplittable): Remove unused variable.
6188 (Fwindow_buffer): Move up and rewrite doc-string.
6189 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6190 (Fwindow_prev): New functions.
6191 (Fwindow_frame): Move here from frame.c. Accept any window as
6193 (Fframe_root_window, Fframe_first_window)
6194 (Fframe_selected_window): Move here from frame.c. Accept frame
6195 or arbitrary window as argument. Update doc-strings.
6196 (Fminibuffer_window): Move up in code.
6197 (Fwindow_minibuffer_p): Move up in code and simplify.
6198 (Fset_frame_selected_window): Move here from frame.c.
6200 (Fselected_window, select_window, Fselect_window): Move up in
6201 code. Minor doc-string fixes.
6203 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6205 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6206 Do not assume that spare memory exists; that assumption is valid
6207 only if SYSTEM_MALLOC.
6208 (LARGE_REQUEST): New macro, so that the issue of large requests
6209 is separated from the issue of spare memory.
6211 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6213 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6216 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6218 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6221 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6223 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6225 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6227 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6228 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6230 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6232 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6234 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6236 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6237 (x_clipboard_manager_save): Add return value.
6238 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6240 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6241 Obey Vx_select_enable_clipboard_manager. Catch errors in
6242 x_clipboard_manager_save (Bug#8779).
6243 (Vx_select_enable_clipboard_manager): New variable.
6244 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6246 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6248 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6250 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6252 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6253 in the current matrix if keep_current_p is non-zero.
6255 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6257 * bidi.c (bidi_level_of_next_char): Fix last change.
6259 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6261 Support bidi reordering of text covered by display properties.
6263 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6264 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6265 (bidi_cache_search, bidi_cache_iterator_state)
6266 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6267 (bidi_level_of_next_char, bidi_move_to_visually_next):
6268 Support character positions inside a run of characters covered by a
6270 (bidi_paragraph_init, bidi_resolve_explicit_1)
6271 (bidi_level_of_next_char): Call bidi_fetch_char and
6272 bidi_fetch_char_advance instead of FETCH_CHAR and
6274 (bidi_init_it): Initialize new members.
6275 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6277 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6278 instead of using explicit *_CHAR codes.
6279 (bidi_resolve_explicit, bidi_resolve_weak):
6280 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6281 bidirectional text is supported only in multibyte buffers.
6282 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6283 it to initialize the frame_window_p member of struct bidi_it.
6284 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6285 (bidi_resolve_explicit, bidi_resolve_weak)
6286 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6287 bidi_it->nchars is non-positive.
6288 (bidi_level_of_next_char): Don't try to lookup the cache for the
6289 next/previous character if nothing is cached there yet, or if we
6290 were just reseat()'ed to a new position.
6292 * xdisp.c (set_cursor_from_row): Set start and stop points
6293 according to the row's direction when priming the loop that looks
6294 for the glyph on which to display cursor.
6295 (single_display_spec_intangible_p): Function deleted.
6296 (display_prop_intangible_p): Reimplement to call
6297 handle_display_spec instead of single_display_spec_intangible_p.
6298 Accept 3 additional arguments needed by handle_display_spec.
6299 This fixes incorrect cursor motion across display property with complex
6300 values: lists, `(when COND...)' forms, etc.
6301 (single_display_spec_string_p): Support property values that are
6302 lists with the argument STRING its top-level element.
6303 (display_prop_string_p): Fix the condition for processing a
6304 property that is a list to be consistent with handle_display_spec.
6305 (handle_display_spec): New function, refactored from the
6306 last portion of handle_display_prop.
6307 (compute_display_string_pos): Accept additional argument
6308 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6309 value of a `display' property is a "replacing spec".
6310 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6311 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6312 the display property, but just return a value indicating whether
6313 the display property will replace the characters it covers.
6314 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6315 frame_window_p members of struct bidi_it.
6316 (compute_display_string_pos, compute_display_string_end):
6318 (push_it): Accept second argument POSITION, where pop_it should
6319 jump to continue iteration.
6320 (reseat_1): Initialize bidi_it.disp_pos.
6322 * keyboard.c (adjust_point_for_property): Adjust the call to
6323 display_prop_intangible_p to its new signature.
6325 * dispextern.h (struct bidi_it): New member frame_window_p.
6326 (bidi_init_it): Update prototypes.
6327 (display_prop_intangible_p): Update prototype.
6328 (compute_display_string_pos, compute_display_string_end):
6330 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6333 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6335 Malloc failure behavior now depends on size of allocation.
6336 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6337 * lisp.h: Change signatures accordingly.
6338 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6339 All callers changed. (Bug#8762)
6341 * gnutls.c: Use Emacs's memory allocators.
6342 Without this change, the gnutls library would invoke malloc etc.
6343 directly, which causes problems on non-SYNC_INPUT hosts, and which
6344 runs afoul of improving memory_full behavior. (Bug#8761)
6345 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6346 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6347 xfree instead of the default malloc, realloc, free.
6348 (Fgnutls_boot): No need to check for memory allocation failure,
6349 since xmalloc does that for us.
6351 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6352 * category.c (hash_get_category_set):
6353 * ccl.c (ccl_driver):
6354 * charset.c (Fdefine_charset_internal):
6355 * charset.h (struct charset.hash_index):
6356 * composite.c (get_composition_id, gstring_lookup_cache)
6357 (composition_gstring_put_cache):
6358 * composite.h (struct composition.hash_index):
6359 * dispextern.h (struct image.hash):
6360 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6361 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6362 (hashfn_equal, hashfn_user_defined, make_hash_table)
6363 (maybe_resize_hash_table, hash_lookup, hash_put)
6364 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6365 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6366 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6367 * image.c (make_image, search_image_cache, lookup_image)
6368 (xpm_put_color_table_h):
6369 * lisp.h (struct Lisp_Hash_Table):
6370 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6371 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6372 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6373 * alloc.c (allocate_vectorlike):
6374 Check for overflow in vector size calculations.
6375 * ccl.c (ccl_driver):
6376 Check for overflow when converting EMACS_INT to int.
6377 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6378 need to be updated by these changes.
6379 * fns.c (make_hash_table, maybe_resize_hash_table):
6380 Check for integer overflow with large hash tables.
6381 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6382 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6383 (SXHASH_REDUCE): New macro.
6384 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6385 Use it instead of discarding useful hash info with large hash values.
6386 (sxhash_float): New function.
6387 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6388 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6389 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6390 Rewrite to use FIXNUM_BITS, as this simplifies things.
6391 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6392 Adjust signatures to match updated version of code.
6393 (consing_since_gc): Now EMACS_INT, since a single hash table can
6394 use more than INT_MAX bytes.
6396 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6398 Make it possible to build with GCC-4.6+ -O2 -flto.
6400 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6402 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6404 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6405 Call minibuffer-inactive-mode.
6407 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6409 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6410 Update dependencies.
6412 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6414 * data.c (init_data): Remove code for UTS, this system is not
6417 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6419 Don't force ./temacs to start in terminal mode.
6421 * frame.c (make_initial_frame): Initialize faces in all cases, not
6422 only when CANNOT_DUMP is defined.
6423 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6425 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6427 * dispnew.c (add_window_display_history): Use const for the string
6428 pointer. Remove declaration, not needed.
6430 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6432 Use 'inline', not 'INLINE'.
6433 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6434 * alloc.c, fontset.c (INLINE): Remove.
6435 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6436 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6437 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6438 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6439 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6441 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6443 Make it possible to run ./temacs.
6445 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6446 syms_of_callproc does the same thing. Remove test for
6447 "initialized", do it in the caller.
6448 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6450 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6452 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6453 (read_minibuf): Use get_minibuffer.
6454 (syms_of_minibuf): Use DEFSYM.
6455 (Qmetadata): New var.
6456 * data.c (Qbuffer): Don't make it static.
6457 (syms_of_data): Use DEFSYM.
6459 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6461 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6462 (CCL_CODE_MIN): New macro.
6464 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6466 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6468 * eval.c (Qdebug): Now static.
6469 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6470 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6471 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6473 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6475 * image.c: Various fixes to ImageMagick code comments.
6476 (Fimagemagick_types): Doc fix.
6478 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6480 Minor fixes prompted by GCC 4.6.0 warnings.
6482 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6484 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6485 (x_clipboard_manager_save_all): Move extern decl to ...
6486 * xterm.h: ... here, so that it can be checked for consistency.
6488 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6490 * xselect.c (x_clipboard_manager_save_frame)
6491 (x_clipboard_manager_save_all): New functions.
6492 (Fx_clipboard_manager_save): Lisp function deleted.
6494 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6495 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6497 * xterm.h: Update prototype.
6499 2011-05-28 William Xu <william.xwl@gmail.com>
6501 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6504 2011-05-28 Jim Meyering <meyering@redhat.com>
6506 Avoid a sign-extension bug in crypto_hash_function.
6507 * fns.c (to_uchar): Define.
6508 (crypto_hash_function): Use it to convert some newly-signed
6509 variables to unsigned, to avoid sign-extension bugs. For example,
6510 without this change, (md5 "truc") would evaluate to
6511 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6512 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6513 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6515 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6517 Integer overflow fixes.
6519 * dbusbind.c: Serial number integer overflow fixes.
6520 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6521 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6522 to hold a serial number that is too large for a fixnum.
6523 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6524 Check for serial numbers out of range. Decode any serial number
6525 that was so large that it became a float. (Bug#8722)
6527 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6528 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6529 Use XFASTINT rather than XUINT when numbers are nonnegative.
6530 (xd_append_arg, Fdbus_method_return_internal):
6531 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6532 arguments, check that Lisp number is nonnegative, rather than
6533 silently wrapping negative numbers around. (Bug#8722)
6534 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6537 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6539 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6541 ccl: Add integer overflow checks.
6542 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6543 (IN_INT_RANGE): New macros.
6544 (ccl_driver): Use them to check for integer overflow when
6545 decoding a CCL program. Many of the new checks are whether XINT (x)
6546 fits in int; it doesn't always, on 64-bit hosts. The new version
6547 doesn't catch all possible integer overflows, but it's an
6548 improvement. (Bug#8719)
6550 * alloc.c (make_event_array): Use XINT, not XUINT.
6551 There's no need for unsigned here.
6553 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6554 This follows up to the 2011-05-06 change that substituted uintptr_t
6555 for EMACS_INT. This case wasn't caught back then.
6557 Rework Fformat to avoid integer overflow issues.
6558 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6559 now (part of C89). Include <verify.h>.
6560 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6561 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6562 (Fformat): Avoid the prepass trying to compute sizes; it was only
6563 approximate and thus did not catch overflow reliably. Instead, walk
6564 through the format just once, formatting and computing sizes as we go,
6565 checking for integer overflow at every step, and allocating a larger
6566 buffer as needed. Keep track separately whether the format is
6567 multibyte. Keep only the most-recently calculated precision, rather
6568 than them all. Record whether each argument has been converted to
6569 string. Use EMACS_INT, not int, for byte and char and arg counts.
6570 Support field widths and precisions larger than INT_MAX. Avoid
6571 sprintf's undefined behavior with conversion specifications such as %#d
6572 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6573 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6574 formatting out-of-range floating point numbers with int
6577 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6579 * data.c: Avoid integer truncation in expressions involving floats.
6580 * data.c: Include <intprops.h>.
6581 (arith_driver): When there's an integer overflow in an expression
6582 involving floating point, convert the integers to floating point
6583 so that the resulting value does not suffer from catastrophic
6584 integer truncation. For example, on a 64-bit host (* 4
6585 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6586 Do not rely on undefined behavior after integer overflow.
6588 merge count_size_as_multibyte, parse_str_to_multibyte
6589 * character.c, character.h (count_size_as_multibyte):
6590 Rename from parse_str_to_multibyte; all uses changed.
6591 Check for integer overflow.
6592 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6593 since it's now a duplicate of the other. This is more of
6594 a character than a buffer op, so better that it's in character.c.
6595 * fns.c, print.c: Adjust to above changes.
6597 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6599 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6601 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6603 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6604 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6605 (x_clipboard_manager_save): Now static.
6606 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6608 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6609 (crypto_hash_function): Now static.
6610 Fix pointer signedness problems. Avoid unnecessary initializations.
6612 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6614 * termhooks.h (Vselection_alist): Make it terminal-local.
6616 * terminal.c (create_terminal): Initialize it.
6618 * xselect.c: Support for clipboard managers.
6619 (Vselection_alist): Move to termhooks.h as terminal-local var.
6620 (LOCAL_SELECTION): New macro.
6621 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6622 (symbol_to_x_atom): Remove gratuitous arg.
6623 (x_handle_selection_request, lisp_data_to_selection_data)
6624 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6625 (x_own_selection, x_get_local_selection, x_convert_selection):
6626 New arg, specifying work frame. Use terminal-local Vselection_alist.
6627 (some_frame_on_display): Delete unused function.
6628 (Fx_own_selection_internal, Fx_get_selection_internal)
6629 (Fx_disown_selection_internal, Fx_selection_owner_p)
6630 (Fx_selection_exists_p): New optional frame arg.
6631 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6632 (x_handle_selection_clear): Don't treat other terminals with the
6633 same keyboard specially. Use the terminal-local Vselection_alist.
6634 (x_clear_frame_selections): Use Frun_hook_with_args.
6636 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6638 * xterm.h: Add support for those atoms.
6640 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6642 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6643 (converted_selections, conversion_fail_tag): New global variables.
6644 (x_selection_request_lisp_error): Free the above.
6645 (x_get_local_selection): Remove unnecessary code.
6646 (x_reply_selection_request): Args changed; handle arbitrary array
6647 of converted selections stored in converted_selections.
6648 Separate the XChangeProperty and SelectionNotify steps.
6649 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6650 (x_convert_selection): New function.
6651 (x_handle_selection_event): Simplify.
6652 (x_get_foreign_selection): Don't ignore incoming requests while
6653 waiting for an answer; this will fail when we implement
6654 SAVE_TARGETS, and seems unnecessary anyway.
6655 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6656 (Vx_sent_selection_functions): Doc fix.
6658 2011-05-26 Leo Liu <sdl.web@gmail.com>
6660 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6662 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6664 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6666 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6667 for fringe update if it has periodic bitmap.
6668 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6669 and fringe_bitmap_periodic_p.
6671 * fringe.c (get_fringe_bitmap_data): New function.
6672 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6673 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6674 row. Mark glyph row for fringe update if periodicity changed.
6676 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6677 for fringe update unless it has periodic bitmap.
6679 2011-05-25 Kenichi Handa <handa@m17n.org>
6681 * xdisp.c (get_next_display_element): Set correct it->face_id for
6682 a static composition.
6684 2011-05-24 Leo Liu <sdl.web@gmail.com>
6687 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6689 * fns.c (crypto_hash_function, Fsha1): New function.
6690 (Fmd5): Use crypto_hash_function.
6691 (syms_of_fns): Add Ssha1.
6693 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6695 * gnutls.c: Remove unused macros.
6696 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6697 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6698 Remove macros that are defined and never used.
6699 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6701 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6703 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6704 (Fx_get_selection_internal): Minor cleanup.
6705 (Fx_own_selection_internal): Rename arguments for consistency with
6708 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6710 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6712 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6714 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6716 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6718 * dispnew.c (scrolling_window): Don't exclude the case that the
6719 last enabled row in the desired matrix touches the bottom boundary.
6721 2011-05-21 Glenn Morris <rgm@gnu.org>
6723 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6724 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6725 and add some more files.
6727 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6729 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6730 report_file_error introduced by the change from 2011-05-07.
6732 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6734 * systime.h (Time): Define only if emacs is defined.
6735 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6736 where the include path doesn't have X11/X.h by default. See
6737 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6739 2011-05-20 Kenichi Handa <handa@m17n.org>
6741 * composite.c (find_automatic_composition): Fix previous change.
6743 2011-05-20 Glenn Morris <rgm@gnu.org>
6745 * lisp.mk: New file, split from Makefile.in.
6746 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6747 (shortlisp): Remove.
6748 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6750 2011-05-19 Glenn Morris <rgm@gnu.org>
6752 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6753 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6754 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6755 (lisp): Set the order to that of loadup.el.
6756 (shortlisp): Make it a copy of $lisp.
6757 (SOME_MACHINE_LISP): Remove.
6758 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6759 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6761 2011-05-18 Kenichi Handa <handa@m17n.org>
6763 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6764 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6765 (find_automatic_composition): Mostly rewrite for efficiency.
6767 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6769 * makefile.w32-in: Update dependencies.
6771 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6773 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6774 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6776 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6778 Fix some integer overflow issues, such as string length overflow.
6780 * insdel.c (count_size_as_multibyte): Check for string overflow.
6782 * character.c (lisp_string_width): Check for string overflow.
6783 Use EMACS_INT, not int, for string indexes and lengths; in
6784 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6785 the resulting string length overflows an EMACS_INT; instead,
6786 report a string overflow if no precision given. When checking for
6787 precision exhaustion, use a check that cannot possibly have
6788 integer overflow. (Bug#8675)
6789 * character.h (lisp_string_width): Adjust to new signature.
6791 * alloc.c (string_overflow): New function.
6792 (Fmake_string): Use it. This doesn't change behavior, but saves
6793 a few bytes and will simplify future changes.
6794 * character.c (string_escape_byte8): Likewise.
6795 * lisp.h (string_overflow): New decl.
6797 Fixups, following up to the user-interface timestamp change.
6798 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6799 for UI timestamps, instead of unsigned long.
6800 * msdos.c (mouse_get_pos): Likewise.
6801 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6802 * w32gui.h (Time): Define by including "systime.h" rather than by
6803 declaring it ourselves. (Bug#8664)
6805 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6806 * image.c (clear_image_cache): Likewise.
6808 * term.c (term_mouse_position): Don't assume time_t wraparound.
6810 Be more systematic about user-interface timestamps.
6811 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6812 and sometimes 'EMACS_UINT', to represent these timestamps.
6813 This change causes it to use 'Time' uniformly, as that's what X uses.
6814 This makes the code easier to follow, and makes it easier to catch
6815 integer overflow bugs such as Bug#8664.
6816 * frame.c (Fmouse_position, Fmouse_pixel_position):
6817 Use Time, not unsigned long, for user-interface timestamps.
6818 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6819 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6820 * keyboard.h (last_event_timestamp): Likewise.
6821 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6822 * menu.h (xmenu_show): Likewise.
6823 * term.c (term_mouse_position): Likewise.
6824 * termhooks.h (struct input_event.timestamp): Likewise.
6825 (struct terminal.mouse_position_hook): Likewise.
6826 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6827 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6828 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6829 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6831 * menu.h, termhooks.h: Include "systime.h", for Time.
6833 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6834 Don't assume that the difference between two unsigned long values
6835 can fit into an integer. At this point, we know button_down_time
6836 <= event->timestamp, so the difference must be nonnegative, so
6837 there's no need to cast the result if double-click-time is
6838 nonnegative, as it should be; check that it's nonnegative, just in
6839 case. This bug is triggered when events are more than 2**31 ms
6840 apart (about 25 days). (Bug#8664)
6842 * xselect.c (last_event_timestamp): Remove duplicate decl.
6843 (x_own_selection): Remove needless cast to unsigned long.
6845 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6846 that always fit in int. Use a sentinel instead of a counter, to
6847 avoid a temp and to allay GCC's concerns about possible int overflow.
6848 * frame.h (struct frame): Use int for menu_bar_items_used
6849 instead of EMACS_INT, since it always fits in int.
6851 * menu.c (grow_menu_items): Check for int overflow.
6853 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6855 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6856 Before, the code was not consistent. These values cannot exceed
6857 2**31 - 1 so there's no need to make them unsigned.
6858 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6859 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6860 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6862 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6864 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6865 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6866 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6867 presumably because the widths might not match.
6869 * window.c (size_window): Avoid needless test at loop start.
6871 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6873 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6875 2011-05-12 Drew Adams <drew.adams@oracle.com>
6877 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6879 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6881 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6882 `width' to `bar_area_x' and `bar_area_width', respectively.
6883 (x_scroll_run): Take account of fringe background extension.
6885 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6886 Rename local vars `left' and `width' to `bar_area_x' and
6887 `bar_area_width', respectively.
6888 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6889 background extension.
6891 2011-05-10 Jim Meyering <meyering@redhat.com>
6893 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6895 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6897 * image.c (Finit_image_library): Return t for built-in image types,
6898 like pbm and xbm. (Bug#8640)
6900 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6902 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6904 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6906 * w32console.c (Fset_screen_color): Doc fix.
6907 (Fget_screen_color): New function.
6908 (syms_of_ntterm): Defsubr it.
6910 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6911 unlink the temporary file if Fcall_process didn't create it in the
6913 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6914 child process will be redirected to a file specified with `:file'.
6915 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6916 cue to call_process_cleanup not to close that handle.
6918 2011-05-07 Ben Key <bkey76@gmail.com>
6920 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6921 one of two shell specific rules, either bootstrap-temacs-CMD or
6922 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6923 to the previous implementation of the bootstrap-temacs rule.
6924 The bootstrap-temacs-CMD rule is similar to the previous
6925 implementation of the bootstrap-temacs rule except that it
6926 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6929 These changes, along with some changes to nt/configure.bat,
6930 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6931 earlier fix to add support for --cflags and --ldflags options
6932 that include quotes so that it works whether make uses cmd or
6935 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6937 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6938 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6940 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6941 a string. Handle both cases.
6942 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6943 (Fdbus_register_method): Use Qinvalid_function.
6945 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6947 * makefile.w32-in: Update dependencies.
6948 (LISP_H): Add inttypes.h and stdin.h.
6949 (PROCESS_H): Add unistd.h.
6951 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6953 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6954 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6956 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6958 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6960 * term.c (vfatal): Remove stray call to va_end.
6961 It's not needed and the C Standard doesn't allow it here anyway.
6963 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6964 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6966 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6969 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6971 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6973 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6975 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6977 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6979 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6980 * charset.c (Fdefine_charset_internal): Don't initialize
6981 charset.code_space[15]. The value was garbage, on hosts with
6982 32-bit int (Bug#8600).
6984 * lread.c (read_integer): Be more consistent with string-to-number.
6985 Use string_to_number to do the actual conversion; this avoids
6986 rounding errors and fixes some other screwups. Without this fix,
6987 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6988 (digit_to_number): Move earlier, for benefit of read_integer.
6989 Return -1 if the digit is out of range for the base, -2 if it is
6990 not a digit in any supported base. (Bug#8602)
6992 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6994 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6995 to match comment at start of function. This also removes a
6996 GCC warning about overflow in a 32+64-bit port.
6998 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7000 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7001 Reported by Stefan Monnier in
7002 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7003 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7004 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7006 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7007 (EMACS_UINTPTR): Likewise, with uintptr_t.
7009 * lisp.h: Prefer 64-bit EMACS_INT if available.
7010 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7011 on 32-bit hosts that have 64-bit int, so that they can access
7013 However, temporarily disable this change unless the temporary
7014 symbol WIDE_EMACS_INT is defined.
7016 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7018 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7019 This removes an assumption that EMACS_INT and long are the same
7020 width as pointers. The assumption is true for Emacs porting targets
7021 now, but we want to make other targets possible.
7022 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7023 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7024 In the rest of the code, change types of integers that hold casted
7025 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7026 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7027 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7028 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7029 No need to cast type when ORing.
7030 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7031 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7032 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7033 assume EMACS_INT is the same width as char *.
7034 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7035 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7036 Remove no-longer-needed casts.
7037 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7038 (xg_tool_bar_help_callback, xg_make_tool_item):
7039 Use EMACS_INTPTR to hold an integer
7040 that will be cast to void *; this can avoid a GCC warning
7041 if EMACS_INT is not the same width as void *.
7042 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7043 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7044 (current_message_1, set_message_1):
7045 Use a local to convert to proper width without a cast.
7046 * xmenu.c (dialog_selection_callback): Likewise.
7048 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7049 Also, don't assume VALBITS / RAND_BITS is less than 5,
7050 and don't rely on undefined behavior when shifting a 1 left into
7052 * lisp.h (get_random): Change signature to match.
7054 * lread.c (hash_string): Use size_t, not int, for hash computation.
7055 Normally we prefer signed values; but hashing is special, because
7056 it's better to use unsigned division on hash table sizes so that
7057 the remainder is nonnegative. Also, size_t is the natural width
7058 for hashing into memory. The previous code used 'int', which doesn't
7059 retain enough info to hash well into very large tables.
7060 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7062 * dbusbind.c: Don't possibly lose pointer info when converting.
7063 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7064 Use XPNTR rather than XHASH, so that the high-order bits of
7065 the pointer aren't lost when converting through void *.
7067 * eval.c (Fautoload): Don't double-shift a pointer.
7069 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7071 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7073 * gnutls.c (DEF_GNUTLS_FN):
7074 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7076 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7078 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7081 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7083 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7084 New version that can reserve upto 2GB of heap space.
7086 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7088 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7090 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7092 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7093 `gnutls_certificate_set_x509_key_file'.
7095 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7097 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7098 Update dependencies.
7100 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7102 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7103 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7104 Remove unused parameter `fildes'.
7105 * process.c (read_process_output, send_process): Don't pass it.
7107 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7109 Fix previous change: the library cache is defined in w32.c.
7110 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7111 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7113 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7115 Implement dynamic loading of GnuTLS on Windows.
7117 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7118 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7119 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7122 * gnutls.c (Qgnutls_dll): Define.
7123 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7124 (gnutls_*): Declare function pointers.
7125 (init_gnutls_functions): New function to initialize function pointers.
7126 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7127 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7128 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7129 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7130 (emacs_gnutls_write, emacs_gnutls_read)
7131 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7132 (Fgnutls_available_p): New function.
7133 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7134 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7135 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7137 * image.c: Include w32.h.
7138 (Vimage_type_cache): Delete.
7139 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7140 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7141 (w32_delayed_load): Move to w32.c.
7143 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7145 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7146 (w32_delayed_load): Move from image.c. When loading a library, record
7147 its filename in the :loaded-from property of the library id.
7148 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7149 Initialize and staticpro them.
7150 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7152 * process.c: Include lisp.h before w32.h, not after.
7153 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7154 instead of gnutls_record_check_pending.
7156 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7158 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7160 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7161 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7164 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7166 * xterm.c (x_set_frame_alpha): Do not set property on anything
7167 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7169 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7171 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7173 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7175 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7176 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7177 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7178 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7179 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7180 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7181 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7182 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7183 (Qgnutls_bootprop_callbacks_verify): Make static.
7185 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7187 * callproc.c: Indentation fixup.
7189 * sysdep.c (wait_for_termination_1): Make static.
7190 (wait_for_termination, interruptible_wait_for_termination):
7191 Move after wait_for_termination_1.
7193 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7195 * sysdep.c (interruptible_wait_for_termination): New function
7196 which is like wait_for_termination, but allows keyboard
7199 * callproc.c (Fcall_process): Add (:file "file") as an option for
7201 (Fcall_process_region): Ditto.
7203 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7205 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7206 rather than `XVECTOR (FOO)->size'.
7208 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7209 inttypes.h, as a gnulib replacement is used if it not available in
7212 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7214 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7215 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7216 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7218 * coding.c (coding_alloc_by_realloc): Error out if destination
7219 will grow beyond MOST_POSITIVE_FIXNUM.
7220 (decode_coding_emacs_mule): Abort if there isn't enough place in
7221 charbuf for the composition carryover bytes. Reserve an extra
7222 space for up to 2 characters produced in a loop.
7223 (decode_coding_iso_2022): Abort if there isn't enough place in
7224 charbuf for the composition carryover bytes.
7226 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7228 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7229 aborting when %lld or %lll format is passed.
7230 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7231 %llo or %llx format is passed. (Bug#8545)
7233 * window.c (window_scroll_line_based): Use a marker instead of
7234 simple variables to record original value of point. (Bug#7952)
7236 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7237 produced by %s or %c overflows available buffer space. (Bug#8545)
7239 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7241 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7242 (SIZE_MAX): Move defn after all includes, as they might #define it.
7244 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7246 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7248 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7250 * keyboard.c (Qdelayed_warnings_hook): Define.
7251 (command_loop_1): Run `delayed-warnings-hook'
7252 if Vdelayed_warnings_list is non-nil.
7253 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7254 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7256 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7258 * doprnt.c (doprnt): Don't return value smaller than the buffer
7259 size if the message was truncated. (Bug#8545).
7261 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7263 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7264 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7266 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7268 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7270 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7272 * makefile.w32-in: Update dependencies.
7274 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7276 Improve `doprnt' and its usage. (Bug#8545)
7277 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7278 `format_end'. Remove support for %l as a conversion specifier.
7279 Don't use xrealloc. Improve diagnostics when the %l size modifier
7280 is used. Update the commentary.
7282 * eval.c (verror): Simplify calculation of size_t.
7284 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7287 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7289 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7292 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7294 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7295 This makes this file independent of the recent pseudovector change.
7297 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7299 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7301 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7302 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7303 Remove unused local.
7304 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7306 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7307 GCC 4.6.0 optimizes based on type-based alias analysis.
7308 For example, if b is of type struct buffer * and v of type struct
7309 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7310 != &v->size, and therefore "v->size = 1; b->size = 2; return
7311 v->size;" must therefore return 1. This assumption is incorrect
7312 for Emacs, since it type-puns struct Lisp_Vector * with many other
7313 types. To fix this problem, this patch adds a new type struct
7314 vectorlike_header that documents the constraints on layout of vectors
7315 and pseudovectors, and helps optimizing compilers not get fooled
7316 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7317 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7318 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7320 (XSETPVECTYPE): Rewrite in terms of new macro.
7321 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7322 This is a bit clearer, and further avoids the possibility of
7323 undesirable aliasing.
7324 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7325 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7326 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7327 since Lisp_Subr is a special case (no "next" field).
7328 (ASIZE): Now uses header.size rather than size.
7329 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7330 to avoid the hassle of writing XVECTOR (foo)->header.size.
7331 (struct vectorlike_header): New type.
7332 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7333 object, to help avoid aliasing.
7334 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7335 (SUBRP): Likewise, since Lisp_Subr is a special case.
7336 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7337 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7338 (struct Lisp_Hash_Table): Combine first two members into a single
7339 struct vectorlike_header member. All uses of "size" and "next" members
7340 changed to be "header.size" and "header.next".
7341 * buffer.h (struct buffer): Likewise.
7342 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7343 * frame.h (struct frame): Likewise.
7344 * process.h (struct Lisp_Process): Likewise.
7345 * termhooks.h (struct terminal): Likewise.
7346 * window.c (struct save_window_data, struct saved_window): Likewise.
7347 * window.h (struct window): Likewise.
7348 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7349 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7350 * buffer.c (init_buffer_once): Likewise.
7351 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7353 * process.c (Fformat_network_address): Use local var for size,
7356 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7358 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7359 * data.c (atof): Remove decl; no longer used or needed.
7360 (digit_to_number): Move to lread.c.
7361 (Fstring_to_number): Use new string_to_number function, to be
7362 consistent with how the Lisp reader treats infinities and NaNs.
7363 Do not assume that floating-point numbers represent EMACS_INT
7364 without losing information; this is not true on most 64-bit hosts.
7365 Avoid double-rounding errors, by insisting on integers when
7366 parsing non-base-10 numbers, as the documentation specifies.
7367 * lisp.h (string_to_number): New decl, replacing ...
7368 (isfloat_string): Remove.
7369 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7370 (read1): Do not accept +. and -. as integers; this
7371 appears to have been a coding error. Similarly, do not accept
7372 strings like +-1e0 as floating point numbers. Do not report
7373 overflow for integer overflows unless the base is not 10 which
7374 means we have no simple and reliable way to continue.
7375 Break out the floating-point parsing into a new
7376 function string_to_number, so that Fstring_to_number parses
7377 floating point numbers consistently with the Lisp reader.
7378 (digit_to_number): Move here from data.c. Make it static inline.
7379 (E_CHAR, EXP_INT): Remove, replacing with ...
7380 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7381 (string_to_number): New function, replacing isfloat_string.
7382 This function checks for valid syntax and produces the resulting
7383 Lisp float number too. Rework it so that string-to-number
7384 no longer mishandles examples like "1.0e+". Use strtoumax,
7385 so that overflow for non-base-10 numbers is reported only when
7386 there's no portable and simple way to convert to floating point.
7388 * textprop.c (set_text_properties_1): Rewrite for clarity,
7389 and to avoid GCC warning about integer overflow.
7391 * intervals.h (struct interval): Use EMACS_INT for members
7392 where EMACS_UINT might cause problems. See
7393 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7394 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7395 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7397 (offset_intervals): Tell GCC not to worry about length overflow
7398 when negating a negative length.
7400 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7401 (overrun_check_free): Likewise.
7403 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7404 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7407 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7408 (gnutls_make_error): Rename local to avoid shadowing.
7409 (gnutls_emacs_global_deinit): ifdef out; not used.
7410 (Fgnutls_boot): Use const for pointer to readonly storage.
7411 Comment out unused local. Fix pointer signedness problems.
7413 * lread.c (openp): Don't stuff size_t into an 'int'.
7414 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7415 about possible signed overflow.
7417 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7418 (GDK_KEY_g): Don't define if already defined.
7419 (xg_prepare_tooltip): Avoid pointer signedness problem.
7420 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7422 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7423 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7425 * xfns.c (Fx_window_property): Simplify a bit,
7426 to make a bit faster and to avoid GCC 4.6.0 warning.
7427 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7429 * fns.c (internal_equal): Don't assume size_t fits in int.
7431 * alloc.c (compact_small_strings): Tighten assertion a little.
7433 Replace pEd with more-general pI, and fix some printf arg casts.
7434 * lisp.h (pI): New macro, generalizing old pEd macro to other
7435 conversion specifiers. For example, use "...%"pI"d..." rather
7436 than "...%"pEd"...".
7437 (pEd): Remove. All uses replaced with similar uses of pI.
7438 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7439 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7440 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7441 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7442 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7443 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7444 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7446 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7447 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7448 * print.c (safe_debug_print, print_object): Likewise.
7449 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7451 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7452 avoiding the 0 flag, which is not portable.
7453 * process.c (Fmake_network_process): Use pI to avoid cast.
7454 * region-cache.c (pp_cache): Likewise.
7455 * xdisp.c (decode_mode_spec): Likewise.
7456 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7457 behavior on 64-bit hosts with printf arg.
7458 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7459 (x_stop_queuing_selection_requests): Likewise.
7460 (x_get_window_property): Don't truncate byte count to an 'int'
7463 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7464 here, since it parses constructs like leading '-' and spaces,
7465 which are not wanted; and it overflows with large numbers.
7466 Instead, simply match F[0-9]+, which is what is wanted anyway.
7468 * alloc.c: Remove unportable assumptions about struct layout.
7469 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7470 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7471 (allocate_vectorlike, make_pure_vector): Use the new macros,
7472 plus offsetof, to remove unportable assumptions about struct layout.
7473 These assumptions hold on all porting targets that I know of, but
7474 they are not guaranteed, they're easy to remove, and removing them
7475 makes further changes easier.
7477 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7478 This doesn't fix a bug but makes the code clearer.
7479 (string_overrun_cookie): Now const. Use initializers that
7480 don't formally overflow signed char, to avoid warnings.
7481 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7482 can cause Emacs to crash when string overrun checking is enabled.
7483 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7484 multiple of sizeof (EMACS_INT); it need not be, if
7485 alignof(EMACS_INT) < sizeof (EMACS_INT).
7486 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7488 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7490 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7492 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7494 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7495 supposed to be handshaking. (Bug#8556)
7496 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7498 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7500 * lisp.h (Qdebug): List symbol.
7501 * eval.c (Qdebug): Restore global linkage.
7502 * keyboard.c (debug-on-event): New variable.
7503 (handle_user_signal): Break into debugger when debug-on-event
7504 matches the current signal symbol.
7506 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7508 * alloc.c (check_sblock, check_string_bytes)
7509 (check_string_free_list): Convert to standard C.
7511 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7513 * w32.c (emacs_gnutls_push): Fix typo.
7515 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7517 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7518 "cast to pointer from integer of different size".
7520 Improve doprnt and its use in verror. (Bug#8545)
7521 * doprnt.c (doprnt): Document the set of format control sequences
7522 supported by the function. Use SAFE_ALLOCA instead of always
7525 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7526 is one byte too soon. Don't use xrealloc; instead xfree and
7529 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7531 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7534 * gnutls.c: Renamed global_initialized to
7535 gnutls_global_initialized. Added internals for the
7536 :verify-hostname-error, :verify-error, and :verify-flags
7537 parameters of `gnutls-boot' and documented those parameters in the
7538 docstring. Start callback support.
7539 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7540 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7541 on error. Return error code.
7542 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7543 (emacs_gnutls_read): Likewise.
7544 (Fgnutls_boot): Return handshake error code.
7545 (emacs_gnutls_handle_error): New function.
7546 (wsaerror_to_errno): Likewise.
7548 * w32.h (emacs_gnutls_pull): Add prototype.
7549 (emacs_gnutls_push): Likewise.
7551 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7552 (emacs_gnutls_push): Likewise.
7554 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7556 * process.c (wait_reading_process_output): Check if GnuTLS
7557 buffered some data internally if no FDs are set for TLS
7560 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7561 (LIBS): Link to USER_LIBS.
7562 ($(BLD)/gnutls.$(0)): New target.
7564 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7566 * xdisp.c (handle_single_display_spec): Rename the
7567 display_replaced_before_p argument into display_replaced_p, to
7568 make it consistent with the commentary. Fix typos in the
7571 * textprop.c (syms_of_textprop): Remove dead code.
7572 (copy_text_properties): Delete obsolete commentary about an
7573 interface that was deleted long ago. Fix typos in the description
7576 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7577 to changes in oldXMenu/XMenu.h from 2011-04-16.
7578 <menu_help_message, prev_menu_help_message>: Constify.
7579 (IT_menu_make_room): menu->help_text is now `const char **';
7582 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7583 to changes in oldXMenu/XMenu.h from 2011-04-16.
7584 (struct XMenu): Declare `help_text' `const char **'.
7586 * xfaces.c <Qunspecified>: Make extern again.
7588 * syntax.c: Include sys/types.h before including regex.h, as
7591 * doc.c (get_doc_string): Improve the format passed to `error'.
7593 * doprnt.c (doprnt): Improve commentary.
7595 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7597 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7600 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7601 changes in globals.h immediately force recompilation.
7602 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7603 $(CURDIR)/s/ms-w32.h.
7604 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7606 * character.c (Fchar_direction): Function deleted.
7607 (syms_of_character): Don't defsubr it.
7608 <char-direction-table>: Deleted.
7610 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7612 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7613 * doprnt.c: Include limits.h.
7614 (SIZE_MAX): New macro.
7615 (doprnt): Return a size_t value. 2nd arg is now size_t.
7616 Many local variables are now size_t instead of int or unsigned.
7617 Improve overflow protection. Support `l' modifier for integer
7618 conversions. Support %l conversion. Don't assume an EMACS_INT
7619 argument for integer conversions and for %c.
7621 * lisp.h (doprnt): Restore prototype.
7623 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7626 * Makefile.in (base_obj): Add back doprnt.o.
7628 * deps.mk (doprnt.o): Add back prerequisites.
7629 (callint.o): Depend on character.h.
7631 * eval.c (internal_lisp_condition_case): Include the handler
7632 representation in the error message.
7633 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7634 when breaking from the loop.
7636 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7638 * callint.c (Fcall_interactively): When displaying error message
7639 about invalid control letter, pass the character's codepoint, not
7640 a pointer to its multibyte form. Improve display of the character
7641 in octal and display also its hex code.
7643 * character.c (char_string): Use %x to display the (unsigned)
7644 codepoint of an invalid character, to avoid displaying a bogus
7647 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7648 `error', not SYMBOL_NAME itself.
7650 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7651 character arguments to `error'.
7653 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7654 to `error' in error message about FINAL_CHAR argument. Make sure
7655 FINAL_CHAR is a character, and use %c when it is passed as
7656 argument to `error'.
7658 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7660 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7662 * w32.c: Include <time.h>.
7663 (sys_localtime): New function.
7665 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7667 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7669 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7671 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7673 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7676 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7678 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7679 gl_state.e_property when gl_state.object is Qt.
7681 * insdel.c (make_gap_larger): Remove limitation of buffer size
7684 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7686 * xdisp.c (lookup_glyphless_char_display)
7687 (produce_glyphless_glyph): Handle cons cell entry in
7688 glyphless-char-display.
7689 (Vglyphless_char_display): Document it.
7691 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7692 glyphless-char-display.
7694 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7696 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7698 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7700 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7701 definition for no-X builds.
7703 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7705 Static checks with GCC 4.6.0 and non-default toolkits.
7707 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7709 * process.c (keyboard_bit_set): Define only if SIGIO.
7710 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7711 (send_process): Repair possible setjmp clobbering.
7713 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7715 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7717 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7719 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7720 Define only if needed.
7722 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7723 by pacifying GCC about it. Maybe it's time to retire it?
7724 * xfaces.c (USG, __TIMEVAL__): Likewise.
7726 * dispextern.h (struct redisplay_interface): Rename param
7728 * termhooks.h (struct terminal): Likewise.
7729 * xterm.c (xembed_send_message): Likewise.
7731 * insdel.c (make_gap_smaller): Define only if
7732 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7734 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7737 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7738 so that we aren't warned about unused symbols.
7740 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7742 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7744 * xfns.c (x_real_positions): Mark locals as initialized.
7746 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7748 * xterm.c: Fix problems found by static analysis with other toolkits.
7749 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7750 (x_dispatch_event): Declare static if USE_GTK, and
7751 define if USE_GTK || USE_X_TOOLKIT.
7752 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7753 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7754 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7755 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7757 * xmenu.c (menu_help_callback): Pointer type fixes.
7758 Use const pointers when pointing at readonly data. Avoid pointer
7760 (FALSE): Remove unused macro.
7761 (update_frame_menubar): Remove unused decl.
7763 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7765 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7766 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7767 (single_menu_item): Rename local to avoid shadowing.
7769 * keyboard.c (make_lispy_event): Remove unused local var.
7771 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7772 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7774 * bitmaps: Change bitmaps from unsigned char back to the X11
7775 compatible char. Avoid the old compiler warnings about
7776 out-of-range initializers by using, for example, '\xab' rather
7779 * xgselect.c (xgselect_initialize): Check vs interface
7780 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7782 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7784 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7785 to read-only memory.
7787 * fns.c (vector): Remove; this old hack is no longer needed.
7789 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7791 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7793 * xrdb.c (x_load_resources): Omit unused local.
7795 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7796 (x_window): Rename locals to avoid shadowing.
7797 (USG): Use the kludged USG macro, to pacify gcc.
7799 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7800 (x_term_init): Remove local to avoid shadowing.
7802 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7804 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7805 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7807 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7809 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7811 Fix regex.c, syntax.c and friends for buffers > 2GB.
7812 * syntax.h (struct gl_state_s): Declare character position members
7815 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7817 * textprop.c (verify_interval_modification, interval_of):
7818 Declare arguments EMACS_INT.
7820 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7823 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7825 * indent.c (Fvertical_motion): Local variable it_start is now
7828 * regex.c (re_match, re_match_2, re_match_2_internal)
7829 (bcmp_translate, regcomp, regexec, print_double_string)
7830 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7831 (re_compile_pattern, re_exec): Declare arguments and local
7832 variables `size_t' and `ssize_t' and return values `regoff_t', as
7834 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7835 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7836 <compile_stack_type>: `size' and `avail' are now `size_t'.
7838 * regex.h <regoff_t>: Use ssize_t, not int.
7839 (re_search, re_search_2, re_match, re_match_2): Arguments that
7840 specify buffer/string position and length are now ssize_t and
7841 size_t. Return type is regoff_t.
7843 2011-04-16 Ben Key <bkey76@gmail.com>
7845 * nsfont.m: Fixed bugs in ns_get_family and
7846 ns_descriptor_to_entity that were caused by using free to
7847 deallocate memory blocks that were allocated by xmalloc (via
7848 xstrdup). This caused Emacs to crash when compiled with
7849 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7850 --enable-checking=xmallocoverrun). xfree is now used to
7851 deallocate these memory blocks.
7853 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7855 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7857 emacs_write: Accept and return EMACS_INT for sizes.
7858 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7860 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7861 Accept and return EMACS_INT.
7862 (emacs_gnutls_write): Return the number of bytes written on
7864 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7865 (emacs_read, emacs_write): Remove check for negative size, as the
7866 Emacs source code has been audited now.
7867 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7868 (emacs_read, emacs_write): Use it.
7869 * process.c (send_process): Adjust to the new signatures of
7870 emacs_write and emacs_gnutls_write. Do not attempt to store
7871 a byte offset into an 'int'; it might overflow.
7872 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7874 * sound.c: Don't assume sizes fit in 'int'.
7875 (struct sound_device.period_size, alsa_period_size):
7876 Return EMACS_INT, not int.
7877 (struct sound_device.write, vox_write, alsa_write):
7878 Accept EMACS_INT, not int.
7879 (wav_play, au_play): Use EMACS_INT to store sizes and to
7880 record read return values.
7882 2011-04-15 Ben Key <bkey76@gmail.com>
7884 * keyboard.c (Qundefined): Don't declare static since it is used
7886 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7887 static since they are used in nsfont.m.
7889 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7891 * process.c (Qprocessp): Don't declare static.
7892 * lisp.h (Qprocessp): Declare again.
7894 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7896 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7898 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7900 Improve C-level modularity by making more things 'static'.
7902 Don't publish debugger-only interfaces to other modules.
7903 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7904 (verify_bytepos, count_markers): Move decls to the only modules
7906 * region-cache.h (pp_cache): Likewise.
7907 * window.h (check_all_windows): Likewise.
7908 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7910 * sysdep.c (croak): Now static, if
7911 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7912 * syssignal.h (croak): Declare only if not static.
7914 * alloc.c (refill_memory_reserve): Now static if
7915 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7916 * lisp.h (refill_memory_reserve): Declare only if not static.
7918 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7919 Define only if USE_LUCID.
7921 * xrdb.c (x_customization_string, x_rm_string): Now static.
7923 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7924 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7926 * xdisp.c (draw_row_with_mouse_face): Now static.
7927 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7929 * window.h (check_all_windows): Mark externally visible.
7931 * window.c (window_deletion_count): Now static.
7933 * undo.c: Make symbols static if they're not exported.
7934 (last_undo_buffer, last_boundary_position, pending_boundary):
7937 * textprop.c (interval_insert_behind_hooks): Now static.
7938 (interval_insert_in_front_hooks): Likewise.
7940 * term.c: Make symbols static if they're not exported.
7941 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7942 (max_frame_lines, tty_set_terminal_modes):
7943 (tty_reset_terminal_modes, tty_turn_off_highlight):
7944 (get_tty_terminal): Now static.
7945 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7946 * termhooks.h (term_mouse_moveto): Do not declare if
7948 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7949 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7951 * sysdep.c: Make symbols static if they're not exported.
7952 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7954 (sigprocmask_set, full_mask): Remove; unused.
7955 (wait_debugging): Mark as visible.
7956 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7957 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7959 * syntax.c (syntax_temp): Define only if !__GNUC__.
7961 * sound.c (current_sound_device, current_sound): Now static.
7963 * search.c (searchbufs, searchbuf_head): Now static.
7965 * scroll.c (scroll_cost): Remove; unused.
7966 * dispextern.h (scroll_cost): Remove decl.
7968 * region-cache.h (pp_cache): Mark as externally visible.
7970 * process.c: Make symbols static if they're not exported.
7971 (process_tick, update_tick, create_process, chan_process):
7972 (Vprocess_alist, proc_buffered_char, datagram_access):
7973 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7974 (deactivate_process): Mark defn as static, as well as decl.
7975 * lisp.h (create_process): Remove decl.
7976 * process.h (chan_process, Vprocess_alist): Remove decls.
7978 * print.c: Make symbols static if they're not exported.
7979 (print_depth, new_backquote_output, being_printed, print_buffer):
7980 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7981 (print_interval, print_number_index, initial_stderr_stream):
7983 * lisp.h (Fprinc): Remove decl.
7984 (debug_output_compilation_hack): Mark as externally visible.
7986 * sysdep.c (croak): Move decl from here to syssignal.h.
7987 * syssignal.h (croak): Put it here, so the API can be checked when
7988 'croak' is called from dissociate_if_controlling_tty.
7990 * minibuf.c: Make symbols static if they're not exported.
7991 (minibuf_save_list, choose_minibuf_frame): Now static.
7992 * lisp.h (choose_minibuf_frame): Remove decl.
7994 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7996 * lread.c: Make symbols static if they're not exported.
7997 (read_objects, initial_obarray, oblookup_last_bucket_number):
7999 (make_symbol): Remove; unused.
8000 * lisp.h (initial_obarray, make_symbol): Remove decls.
8002 * keyboard.c: Make symbols static if they're not exported.
8003 (single_kboard, recent_keys_index, total_keys, recent_keys):
8004 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8005 (this_single_command_key_start, echoing, last_auto_save):
8006 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8007 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8008 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8009 (Vlispy_mouse_stem, double_click_count):
8011 (force_auto_save_soon): Define only if SIGDANGER.
8012 (ignore_mouse_drag_p): Now static if
8013 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8014 (print_help): Remove; unused.
8015 (stop_character, last_timer_event): Mark as externally visible.
8016 * keyboard.h (ignore_mouse_drag_p): Declare only if
8017 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8018 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8019 * lisp.h (echoing): Remove decl.
8020 (force_auto_save_soon): Declare only if SIGDANGER.
8021 * xdisp.c (redisplay_window): Simplify code, to make it more
8022 obvious that ignore_mouse_drag_p is not accessed if !defined
8023 USE_GTK && !defined HAVE_NS.
8025 * intervals.c: Make symbols static if they're not exported.
8026 (merge_properties_sticky, merge_interval_right, delete_interval):
8028 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8030 * insdel.c: Make symbols static if they're not exported.
8031 However, leave prepare_to_modify_buffer alone. It's never
8032 called from outside this function, but that appears to be a bug.
8033 (combine_after_change_list, combine_after_change_buffer):
8034 (adjust_after_replace, signal_before_change): Now static.
8035 (adjust_after_replace_noundo): Remove; unused.
8036 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8037 (signal_before_change): Remove decls.
8039 * indent.c (val_compute_motion, val_vmotion): Now static.
8041 * image.c: Make symbols static if they're not exported.
8042 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8044 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8045 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8047 * fringe.c (standard_bitmaps): Now static.
8048 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8050 * frame.c: Make symbols static if they're not exported.
8051 (x_report_frame_params, make_terminal_frame): Now static.
8052 (get_frame_param): Now static, unless HAVE_NS.
8053 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8054 (x_get_resource_string): Remove; not used.
8055 * frame.h (make_terminal_frame, x_report_frame_params):
8056 (x_get_resource_string); Remove decls.
8057 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8058 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8060 * font.c, fontset.c: Make symbols static if they're not exported.
8061 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8062 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8063 * font.c (font_close_object): Now static.
8064 * font.h (font_close_object): Remove.
8065 * fontset.c (FONTSET_OBJLIST): Remove.
8066 (free_realized_fontset) #if-0 the body, which does nothing.
8067 (face_suitable_for_char_p): #if-0, as it's never called.
8068 * fontset.h (face_suitable_for_char_p): Remove decl.
8069 * xfaces.c (face_at_string_position):
8070 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8071 since 0 is always ASCII.
8073 * fns.c (weak_hash_tables): Now static.
8075 * fileio.c: Make symbols static if they're not exported.
8076 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8077 (Vwrite_region_annotation_buffers): Now static.
8079 * eval.c: Make symbols static if they're not exported.
8080 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8081 * lisp.h (backtrace_list): Remove decl.
8083 * emacs.c: Make symbols static if they're not exported.
8084 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8085 (fatal_error_code, fatal_error_signal_hook, standard_args):
8087 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8088 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8089 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8090 * lisp.h (fatal_error_signal_hook): Remove decl.
8091 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8093 * editfns.c: Move a (normally-unused) function to its only use.
8094 * editfns.c, lisp.h (get_operating_system_release): Remove.
8095 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8096 worth the hassle of breaking this out.
8098 * xterm.c: Make symbols static if they're not exported.
8099 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8100 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8101 (x_destroy_window, x_delete_display):
8103 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8104 (x_mouse_leave): Remove; unused.
8105 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8106 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8107 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8109 (x_mouse_leave): Declare only if WINDOWSNT.
8110 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8111 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8114 * ftxfont.c: Make symbols static if they're not exported.
8115 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8117 * font.h (ftxfont_driver): Likewise.
8119 * xfns.c: Make symbols static if they're not exported.
8120 (x_last_font_name, x_display_info_for_name):
8121 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8122 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8123 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8124 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8125 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8126 (last_show_tip_args): Now static.
8127 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8128 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8129 (x_screen_planes): Remove; unused.
8130 * dispextern.h (x_screen_planes): Remove decl.
8132 * dispnew.c: Make symbols static if they're not exported.
8133 * dispextern.h (redraw_garbaged_frames, scrolling):
8134 (increment_row_positions): Remove.
8135 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8136 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8138 (redraw_garbaged_frames): Remove; unused.
8140 * xfaces.c: Make symbols static if they're not exported.
8141 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8143 * xterm.h (defined_color): Remove decls.
8144 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8145 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8146 (menu_face_changed_default, defined_color, free_realized_face):
8147 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8148 (ascii_face_of_lisp_face): Remove; unused.
8150 * xdisp.c: Make symbols static if they're not exported.
8151 * dispextern.h (scratch_glyph_row, window_box_edges):
8152 (glyph_to_pixel_coords, set_cursor_from_row):
8153 (get_next_display_element, set_iterator_to_next):
8154 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8155 (show_mouse_face): Remove decls
8156 * frame.h (message_buf_print): Likewise.
8157 * lisp.h (pop_message, set_message, check_point_in_composition):
8159 * xterm.h (set_vertical_scroll_bar): Likewise.
8160 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8161 (message_buf_print, scratch_glyph_row, displayed_buffer):
8162 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8163 (get_next_display_element, show_mouse_face, window_box_edges):
8164 (frame_to_window_pixel_xy, check_point_in_composition):
8165 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8166 (glyph_to_pixel_coords): Remove; unused.
8168 * dired.c (file_name_completion): Now static.
8170 * dbusbind.c (xd_in_read_queued_messages): Now static.
8172 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8173 * data.c (circular_list_error): Remove.
8175 * commands.h (last_point_position, last_point_position_buffer):
8176 (last_point_position_window): Remove decls.
8177 * keyboard.c: Make these variables static.
8179 * coding.h (coding, code_convert_region, encode_coding_gap):
8181 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8182 (iso_code_class, detect_coding, code_convert_region): Now static.
8183 (encode_coding_gap): Remove; unused.
8185 * chartab.c (chartab_chars, chartab_bits): Now static.
8187 * charset.h (charset_iso_8859_1): Remove decl.
8188 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8191 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8192 * ccl.c (Vccl_program_table): Now static.
8193 (check_ccl_update): Remove; unused.
8195 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8196 * category.h: ... from here.
8197 * category.c (check_category_table, set_category_set): Now static.
8199 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8200 * lisp.h: Remove these decls.
8202 * buffer.c (buffer_count): Remove unused var.
8204 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8205 so that it's not optimized away.
8206 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8207 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8208 exported only to the debugger.
8210 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8211 * atimer.h (run_all_atimers): Remove; not exported.
8213 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8214 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8215 was inaccessible from Lisp.
8216 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8217 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8219 alloc.c: Import and export fewer symbols, and remove unused items.
8220 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8222 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8223 it's not optimized away by whole-program optimization.
8224 (message_enable_multibyte, free_misc): Remove.
8225 (catchlist, handlerlist, mark_backtrace):
8226 Declare only if BYTE_MARK_STACK.
8227 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8228 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8229 (message_enable_multibyte): Remove decl.
8230 (free_misc, interval_free_list, float_block, float_block_index):
8231 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8232 (cons_free_list, last_marked_index):
8234 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8235 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8236 (mark_backtrace): Define only if BYTE_MARK_STACK.
8237 * xdisp.c (message_enable_multibyte): Now static.
8239 Declare Lisp_Object Q* variables to be 'static' if not exported.
8240 This makes it easier for human readers (and static analyzers)
8241 to see whether these variables are used from other modules.
8242 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8243 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8244 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8245 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8246 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8247 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8248 * xmenu.c, xselect.c:
8249 Declare Q* vars static if they are not used in other modules.
8250 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8251 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8252 Remove decls of unexported vars.
8253 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8255 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8257 Make Emacs functions such as Fatom 'static' by default.
8258 This makes it easier for human readers (and static analyzers)
8259 to see whether these functions can be called from other modules.
8260 DEFUN now defines a static function. To make the function external
8261 so that it can be used in other C modules, use the new macro DEFUE.
8262 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8263 (Finit_image_library):
8264 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8265 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8266 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8267 Remove decls, since these functions are now static.
8268 (Funintern, Fget_internal_run_time): New decls, since these functions
8269 were already external.
8271 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8272 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8273 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8274 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8275 * keyboard.c, keymap.c, lread.c:
8276 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8277 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8278 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8279 Mark functions with DEFUE instead of DEFUN,
8280 if they are used in other modules.
8281 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8282 decls for now-static functions.
8283 * buffer.h (Fdelete_overlay): Remove decl.
8284 * callproc.c (Fgetenv_internal): Mark as internal.
8285 * composite.c (Fremove_list_of_text_properties): Remove decl.
8286 (Fcomposition_get_gstring): New forward static decl.
8287 * composite.h (Fcomposite_get_gstring): Remove decl.
8288 * dired.c (Ffile_attributes): New forward static decl.
8289 * doc.c (Fdocumntation_property): New forward static decl.
8290 * eval.c (Ffetch_bytecode): New forward static decl.
8291 (Funintern): Remove extern decl; now in .h file where it belongs.
8292 * fileio.c (Fmake_symbolic_link): New forward static decl.
8293 * image.c (Finit_image_library): New forward static decl.
8294 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8295 * intervals.h (Fprevious_property_change):
8296 (Fremove_list_of_text_properties): Remove decls.
8297 * keyboard.c (Fthis_command_keys): Remove decl.
8298 (Fcommand_execute): New forward static decl.
8299 * keymap.c (Flookup_key): New forward static decl.
8300 (Fcopy_keymap): Now static.
8301 * keymap.h (Flookup_key): Remove decl.
8302 * process.c (Fget_process): New forward static decl.
8303 (Fprocess_datagram_address): Mark as internal.
8304 * syntax.c (Fsyntax_table_p): New forward static decl.
8305 (skip_chars): Remove duplicate decl.
8306 * textprop.c (Fprevious_property_change): New forward static decl.
8307 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8309 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8310 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8312 * editfns.c (Fformat): Remove unreachable code.
8314 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8316 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8319 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8321 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8322 when at ZV. (Bug#8487)
8324 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8326 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8328 * keyboard.c (parse_tool_bar_item): Likewise.
8329 * sound.c (sound_cleanup, alsa_close): Likewise.
8330 * termcap.c (tgetent): Likewise.
8331 * xfns.c (x_default_font_parameter): Likewise.
8332 * xsettings.c (read_and_apply_settings): Likewise.
8334 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8335 (overrun_check_free): Protoize.
8337 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8339 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8340 since callers should never pass a negative size.
8341 Change the signature to match that of plain 'read' and 'write'; see
8342 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8343 * lisp.h: Update prototypes of emacs_write and emacs_read.
8345 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8347 * xdisp.c (redisplay_window): Don't try to determine the character
8348 position of the scroll margin if the window start point w->startp
8349 is outside the buffer's accessible region. (Bug#8468)
8351 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8353 Fix write-region and its subroutines for buffers > 2GB.
8354 * fileio.c (a_write, e_write): Modify declaration of arguments and
8355 local variables to support buffers larger than 2GB.
8356 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8358 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8359 argument, local variables, and return value.
8361 * lisp.h: Update prototypes of emacs_write and emacs_read.
8363 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8365 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8367 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8369 Fix more problems found by GCC 4.6.0's static checks.
8371 * xdisp.c (vmessage): Use a better test for character truncation.
8373 * charset.c (load_charset_map): <, not <=, for optimization,
8374 and to avoid potential problems with integer overflow.
8375 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8376 * casetab.c (set_identity, shuffle): Likewise.
8377 * editfns.c (Fformat): Likewise.
8378 * syntax.c (skip_chars): Likewise.
8380 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8381 This also lets GCC 4.6.0 generate slightly better loop code.
8383 * callint.c (Fcall_interactively): <, not <=, for optimization.
8384 (Fcall_interactively): Count the number of arguments produced,
8385 not the number of arguments given. This is simpler and lets GCC
8386 4.6.0 generate slightly better code.
8388 * ftfont.c: Distingish more carefully between FcChar8 and char.
8389 The previous code passed unsigned char * to a functions like
8390 strlen and xstrcasecmp that expect char *, which does not
8391 conform to the C standard.
8392 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8393 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8394 char * when the C standard requires it.
8396 * keyboard.c (read_char): Remove unused var.
8398 * eval.c: Port to Windows vsnprintf (Bug#8435).
8400 (SIZE_MAX): Define if the headers do not.
8401 (verror): Do not give up if vsnprintf returns a negative count.
8402 Instead, grow the buffer. This ports to Windows vsnprintf, which
8403 does not conform to C99. Problem reported by Eli Zaretskii.
8404 Also, simplify the allocation scheme, by avoiding the need for
8405 calling realloc, and removing the ALLOCATED variable.
8407 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8409 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8410 But keep the doprint source code for now, as we might revamp it
8411 and use it again (Bug#8435).
8412 * lisp.h (doprnt): Remove.
8413 * Makefile.in (base_obj): Remove doprnt.o.
8414 * deps.mk (doprnt.o): Remove.
8416 error: Print 32- and 64-bit integers portably (Bug#8435).
8417 Without this change, on typical 64-bit hosts error ("...%d...", N)
8418 was used to print both 32- and 64-bit integers N, which relied on
8420 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8421 * lisp.h (error, verror): Mark as printf-like functions.
8422 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8423 Report overflow in size calculations when allocating printf buffer.
8424 Do not truncate output string at its first null byte.
8425 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8426 Truncate the output at a character boundary, since vsnprintf does not
8428 * charset.c (check_iso_charset_parameter): Convert internal
8429 character to string before calling 'error', since %c now has the
8431 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8432 overflow when computing char to be passed to 'error'. Do not
8433 pass Lisp_Object to 'error'; pass the integer instead.
8434 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8435 formatted with plain %d.
8437 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8439 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8441 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8443 * xterm.c (x_catch_errors): Remove duplicate declaration.
8445 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8447 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8449 2011-04-10 Jim Meyering <meyering@redhat.com>
8451 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8452 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8453 return ssize_t not "int", and use size_t as the buffer length.
8454 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8455 * gnutls.h: Update declarations.
8456 * process.c (read_process_output): Use ssize_t, to match.
8457 (send_process): Likewise.
8459 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8461 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8463 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8465 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8466 Use unsigned char, to match FcChar8 type definition.
8468 * xterm.c (handle_one_xevent):
8469 * xmenu.c (create_and_show_popup_menu):
8470 * xselect.c (x_decline_selection_request)
8471 (x_reply_selection_request): Avoid type-punned deref of X events.
8473 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8475 Fix some uses of `int' instead of EMACS_INT.
8476 * search.c (string_match_1, fast_string_match)
8477 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8478 (scan_buffer, find_next_newline_no_quit)
8479 (find_before_next_newline, search_command, Freplace_match)
8480 (Fmatch_data): Make some `int' variables be EMACS_INT.
8482 * xdisp.c (display_count_lines): 3rd argument and return value now
8483 EMACS_INT. All callers changed.
8484 (pint2hrstr): Last argument is now EMACS_INT.
8486 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8487 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8488 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8489 (decode_coding_utf_16, decode_coding_emacs_mule)
8490 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8491 (decode_coding_ccl, decode_coding_charset)
8492 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8493 (decode_coding_iso_2022, decode_coding_emacs_mule)
8494 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8495 <char_offset, last_offset>: Declare EMACS_INT.
8496 (encode_coding_utf_8, encode_coding_utf_16)
8497 (encode_coding_emacs_mule, encode_invocation_designation)
8498 (encode_designation_at_bol, encode_coding_iso_2022)
8499 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8500 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8502 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8503 (encode_invocation_designation): Last argument P_NCHARS is now
8505 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8506 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8508 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8511 * ccl.c (Fccl_execute_on_string): Declare some variables
8514 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8516 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8518 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8520 * process.c (Fformat_network_address): Doc fix.
8522 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8524 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8526 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8528 * keyboard.c (read_char): Call Lisp function help-form-show,
8529 instead of using internal_with_output_to_temp_buffer.
8530 (Qhelp_form_show): New var.
8531 (syms_of_keyboard): Use DEFSYM macro.
8533 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8535 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8537 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8539 * process.c (Flist_processes): Remove to Lisp.
8540 (list_processes_1): Delete.
8542 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8544 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8546 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8548 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8550 Fix more problems found by GCC 4.6.0's static checks.
8552 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8554 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8556 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8558 * xdisp.c (vmessage): Mark as a printf-like function.
8560 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8562 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8564 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8565 printf-like functions.
8566 (tiff_load): Add casts to remove these marks before passing them
8567 to system-supplied API.
8569 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8571 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8572 This avoids several warnings with gcc -Wstrict-overflow.
8573 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8574 directly, rather than having caller test rule sign. This avoids
8575 some unnecessary tests.
8576 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8577 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8578 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8580 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8581 (xfont_open): Avoid unnecessary tests.
8583 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8585 * composite.h, composite.c (composition_gstring_put_cache):
8586 Use EMACS_INT, not int, for length.
8588 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8589 breaking out part of COMPOSITION_DECODE_RULE.
8590 (COMPOSITION_DECODE_RULE): Use it.
8591 * composite.c (get_composition_id): Remove unused local vars,
8592 by using the new macro.
8594 * textprop.c (set_text_properties_1): Change while to do-while,
8595 since the condition is always true at first.
8597 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8598 (interval_deletion_adjustment): Return unsigned value.
8601 * process.c (list_processes_1, create_pty, read_process_output):
8602 (exec_sentinel): Remove vars that were set but not used.
8603 (create_pty): Remove unnecessary "volatile"s.
8604 (Fnetwork_interface_info): Avoid possibility of int overflow.
8605 (read_process_output): Do adaptive read buffering even if carryover.
8606 (read_process_output): Simplify nbytes computation if buffered.
8608 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8610 * syntax.c (scan_words): Remove var that was set but not used.
8611 (update_syntax_table): Use unsigned instead of int.
8613 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8614 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8615 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8617 * print.c (print_error_message): Avoid int overflow.
8619 * font.c (font_list_entities): Redo for clarity,
8620 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8622 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8623 (font_score): Avoid potential overflow in diff calculation.
8625 * fns.c (substring_both): Remove var that is set but not used.
8626 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8628 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8630 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8631 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8632 can always succeed if overflow has undefined behavior.
8634 * search.c (boyer_moore, wordify): Remove vars set but not used.
8635 (wordify): Omit three unnecessary tests.
8637 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8638 All callers changed. This avoids the need for an unused var.
8640 * casefiddle.c (casify_region): Remove var that is set but not used.
8642 * dired.c (file_name_completion): Remove var that is set but not used.
8644 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8646 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8647 (Finsert_file_contents): Remove unnecessary code checking fd.
8649 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8650 Check for integer overflow on size calculations.
8652 * buffer.c (Fprevious_overlay_change): Remove var that is set
8655 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8656 Remove vars that are set but not used.
8657 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8658 (timer_check_2): Mark vars as initialized.
8660 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8662 * image.c (lookup_image): Remove var that is set but not used.
8663 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8665 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8666 that are set but not used.
8668 * xfns.c (make_invisible_cursor): Don't return garbage
8669 if XCreateBitmapFromData fails (Bug#8410).
8671 * xselect.c (x_get_local_selection, x_handle_property_notify):
8672 Remove vars that are set but not used.
8674 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8675 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8677 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8678 Remove var that is set but not used.
8679 (scroll_bar_windows_size): Now size_t, not int.
8680 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8683 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8684 (map_tty_color) [!defined MSDOS]: Likewise.
8686 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8688 * coding.c: Remove vars that are set but not used.
8689 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8690 All callers changed.
8691 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8692 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8693 (decode_coding_charset): Remove vars that are set but not used.
8695 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8696 that is set but not used.
8698 * print.c (print_object): Remove var that is set but not used.
8700 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8701 The gnulib version avoids calling malloc in the usual case,
8702 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8703 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8704 * filelock.c (current_lock_owner): Likewise.
8705 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8706 * sysdep.c: Include allocator.h, careadlinkat.h.
8707 (emacs_no_realloc_allocator): New static constant.
8708 (emacs_readlink): New function.
8709 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8710 ../lib/careadlinkat.h.
8712 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8714 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8715 first non-nil return value).
8717 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8719 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8720 if not defined (Bug#8403).
8722 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8724 * xdisp.c (display_count_lines): Remove parameter `start',
8725 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8726 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8727 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8728 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8729 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8730 and thereabouts. All callers changed.
8731 (get_per_char_metric): Remove parameter `f', unused since
8732 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8734 2011-04-02 Jim Meyering <meyering@redhat.com>
8736 do not dereference NULL upon failed strdup
8737 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8738 (ns_get_family): Likewise.
8740 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8742 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8744 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8746 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8749 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8751 Add lexical binding.
8753 * window.c (Ftemp_output_buffer_show): New fun.
8754 (Fsave_window_excursion):
8755 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8757 * lread.c (lisp_file_lexically_bound_p): New function.
8758 (Fload): Bind Qlexical_binding.
8759 (readevalloop): Remove `evalfun' arg.
8760 Bind Qinternal_interpreter_environment.
8761 (Feval_buffer): Bind Qlexical_binding.
8762 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8764 (syms_of_lread): Declare `lexical-binding'.
8766 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8768 * keyboard.c (eval_dyn): New fun.
8769 (menu_item_eval_property): Use it.
8771 * image.c (parse_image_spec): Use Ffunctionp.
8773 * fns.c (concat, mapcar1): Accept byte-code-functions.
8775 * eval.c (Fsetq): Handle lexical vars.
8776 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8777 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8778 (FletX, Flet): Obey lexical binding.
8779 (Fcommandp): Handle closures.
8780 (Feval): New `lexical' arg.
8781 (eval_sub): New function extracted from Feval. Use it almost
8782 everywhere where Feval was used. Look up vars in lexical env.
8784 (Ffunctionp): Move from subr.el.
8785 (Ffuncall): Handle closures.
8786 (apply_lambda): Remove `eval_flags'.
8787 (funcall_lambda): Handle closures and new byte-code-functions.
8788 (Fspecial_variable_p): New function.
8789 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8790 but without exporting it to Lisp.
8792 * doc.c (Fdocumentation, store_function_docstring):
8793 * data.c (Finteractive_form): Handle closures.
8795 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8798 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8800 (exec_byte_code): New function extracted from Fbyte_code to handle new
8801 calling convention for byte-code-functions. Add new byte-codes.
8803 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8805 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8807 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8809 * xdisp.c (redisplay_internal): Fix prototype.
8811 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8813 * xdisp.c (SCROLL_LIMIT): New macro.
8814 (try_scrolling): Use it when setting scroll_limit.
8815 Limit scrolling to 100 screen lines.
8816 (redisplay_window): Even when falling back on "recentering",
8817 position point in the window according to scroll-conservatively,
8818 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8820 (try_scrolling): When point is above the window, allow searching
8821 as far as scroll_max, or one screenful, to compute vertical
8822 distance from PT to the scroll margin position. This prevents
8823 try_scrolling from unnecessarily failing when
8824 scroll-conservatively is set to a value slightly larger than the
8825 window height. Clean up the case of PT below the margin at bottom
8826 of window: scroll_max can no longer be INT_MAX. When aggressive
8827 scrolling is in use, don't let point enter the opposite scroll
8828 margin as result of the scroll.
8829 (syms_of_xdisp) <scroll-conservatively>: Document the
8830 threshold of 100 lines for never-recentering scrolling.
8832 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8834 * dispextern.h (move_it_by_lines):
8835 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8836 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8837 (message_log_check_duplicate): Remove parameters `prev_bol' and
8838 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8839 (redisplay_internal): Remove parameter `preserve_echo_area',
8840 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8842 * indent.c (Fvertical_motion):
8843 * window.c (window_scroll_pixel_based, Frecenter):
8844 Don't pass `need_y_p' to `move_it_by_lines'.
8846 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8848 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8849 steal a few bits to be more compact.
8850 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8851 Remove unneeded casts.
8853 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8855 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8857 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8858 binding" message (bug#7967).
8860 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8862 Fix more problems found by GCC 4.6.0's static checks.
8864 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8865 Remove unused local var.
8867 * editfns.c (Fmessage_box): Remove unused local var.
8869 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8870 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8871 Omit unused local vars.
8872 * window.c (shrink_windows): Omit unused local var.
8873 * menu.c (digest_single_submenu): Omit unused local var.
8874 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8875 Omit unused local var.
8877 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8878 Don't assume string length fits in int.
8879 (keyremap_step, read_key_sequence): Use size_t for sizes.
8880 (read_key_sequence): Don't check last_real_key_start redundantly.
8882 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8883 instead of alloca (Bug#8344).
8885 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8886 (Fbacktrace_frame): Don't assume nframes fits in int.
8888 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8890 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8893 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8895 * cm.c (calccost): Turn while-do into do-while, for clarity.
8897 * keyboard.c (syms_of_keyboard): Use the same style as later
8898 in this function when indexing through an array. This also
8899 works around GCC bug 48267.
8901 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8903 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8905 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8906 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8908 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8909 This avoids undefined behavior on integer overflow, and is a bit
8910 more convenient anyway since it is compared to a size_t variable.
8912 Variadic C functions now count arguments with size_t, not int.
8913 This avoids an unnecessary limitation on 64-bit machines, which
8914 caused (substring ...) to crash on large vectors (Bug#8344).
8915 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8916 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8917 All variadic functions and their callers changed accordingly.
8918 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8919 * data.c (arith_driver, float_arith_driver): Likewise.
8920 * editfns.c (general_insert_function): Likewise.
8921 * eval.c (struct backtrace.nargs, interactive_p)
8922 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8923 (funcall_lambda, mark_backtrace): Likewise.
8924 * fns.c (concat): Likewise.
8925 * frame.c (x_set_frame_parameters): Likewise.
8926 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8927 0 if not found, not -1. All callers changed.
8929 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8930 (stack_copy_size): Now size_t, not int.
8931 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8933 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8935 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8936 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8937 All callers changed.
8939 * lisp.h (multibyte_char_to_unibyte):
8940 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8941 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8942 * character.h (CHAR_TO_BYTE8):
8943 * cmds.c (internal_self_insert):
8944 * editfns.c (general_insert_function):
8945 * keymap.c (push_key_description):
8946 * search.c (Freplace_match):
8947 * xdisp.c (message_dolog, set_message_1): All callers changed.
8949 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8951 * keyboard.c (safe_run_hook_funcall): New function.
8952 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8953 don't set the hook to nil, but remove the offending function instead.
8954 (Qcommand_hook_internal): Remove, unused.
8955 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8956 Vcommand_hook_internal.
8958 * eval.c (enum run_hooks_condition): Remove.
8959 (funcall_nil, funcall_not): New functions.
8960 (run_hook_with_args): Call each function through a `funcall' argument.
8961 Remove `cond' argument, now redundant.
8962 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8963 (Frun_hook_with_args_until_failure): Adjust accordingly.
8964 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8966 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8968 * dispextern.h (string_buffer_position): Remove declaration.
8970 * print.c (strout): Remove parameter `multibyte', unused since
8971 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8973 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8974 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8975 All callers changed.
8977 * w32.c (_wsa_errlist): Use braces for struct initializers.
8979 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8980 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8981 All callers changed.
8982 (string_buffer_position): Likewise. Also, make static (it's never
8983 used outside xdisp.c).
8984 (cursor_row_p): Remove parameter `w', unused since
8985 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8986 (decode_mode_spec): Remove parameter `precision', introduced during
8987 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8988 All callers changed.
8990 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8992 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8994 2011-03-27 Anders Lindgren <andlind@gmail.com>
8996 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8997 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8998 (ns_update_auto_hide_menu_bar): New functions.
8999 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9000 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9001 ns_constrain_all_frames.
9002 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9003 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9005 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9007 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9009 2011-03-27 Glenn Morris <rgm@gnu.org>
9011 * syssignal.h: Replace RETSIGTYPE with void.
9012 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9013 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9014 Replace SIGTYPE with void everywhere.
9015 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9016 * s/template.h (SIGTYPE): Remove commented out definition.
9018 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9020 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9021 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9023 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9025 * w32.c (read_unc_volume): Use parameter `henum', instead of
9026 global variable `wget_enum_handle'.
9028 * keymap.c (describe_vector): Remove parameters `indices' and
9029 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9030 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9032 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9034 * keyboard.c (timer_check): Remove parameter `do_it_now',
9035 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9036 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9037 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9039 * keyboard.c (read_char):
9040 * w32menu.c (w32_menu_display_help):
9041 * xmenu.c (show_help_event, menu_help_callback):
9042 Adjust calls to `show_help_echo'.
9044 * gtkutil.c (xg_maybe_add_timer):
9045 * keyboard.c (readable_events):
9046 * process.c (wait_reading_process_output):
9047 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9049 * insdel.c (adjust_markers_gap_motion):
9050 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9051 (gap_left, gap_right): Don't call it.
9053 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9055 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9056 incurred during fontification.
9058 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9060 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9061 (DEFVAR_PER_BUFFER): Don't pass it.
9063 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9064 (scrolling_window): Don't pass it.
9066 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9068 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9070 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9072 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9073 of variables specific to SELinux and computation of `encoded_absname'.
9075 * image.c (XPutPixel): Remove unused variable `height'.
9077 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9079 * unexw32.c (get_section_info): Remove unused variable `section'.
9081 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9082 (system_process_attributes): Remove unused variable `sess'.
9083 (sys_read): Remove unused variable `err'.
9085 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9086 (w32_wnd_proc): Remove unused variable `isdead'.
9087 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9088 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9089 (x_create_tip_frame): Remove unused variable `tem'.
9091 * w32inevt.c (w32_console_read_socket):
9092 Remove unused variable `no_events'.
9094 * w32term.c (x_draw_composite_glyph_string_foreground):
9095 Remove unused variable `width'.
9097 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9099 * w32term.c (x_set_glyph_string_clipping):
9100 Don't pass uninitialized region to CombineRgn.
9102 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9104 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9105 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9106 (Fx_close_connection): Remove unused variable `i'.
9108 * w32font.c (w32font_draw): Return number of glyphs.
9109 (w32font_open_internal): Remove unused variable `i'.
9110 (w32font_driver): Add missing initializer.
9112 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9113 (fill_in_menu): Remove unused variable `items_added'.
9115 * w32term.c (last_mouse_press_frame): Remove static global variable.
9116 (w32_clip_to_row): Remove unused variable `f'.
9117 (x_delete_terminal): Remove unused variable `i'.
9119 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9120 (NOTHING): Remove unused static global variable.
9121 (uniscribe_check_otf): Remove unused variable `table'.
9122 (uniscribe_font_driver): Add missing initializers.
9124 2011-03-23 Julien Danjou <julien@danjou.info>
9126 * term.c (Fsuspend_tty, Fresume_tty):
9127 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9128 * window.c (temp_output_buffer_show):
9129 * insdel.c (signal_before_change):
9130 * frame.c (Fhandle_switch_frame):
9131 * fileio.c (Fdo_auto_save):
9132 * emacs.c (Fkill_emacs):
9133 * editfns.c (save_excursion_restore):
9134 * cmds.c (internal_self_insert):
9135 * callint.c (Fcall_interactively):
9136 * buffer.c (Fkill_all_local_variables):
9137 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9139 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9140 unconditionally since it does the check itself.
9142 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9144 Fix more problems found by GCC 4.5.2's static checks.
9146 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9147 the first time through the loop, since we know p0 < p1 then.
9148 This also avoids a gcc -Wstrict-overflow warning.
9150 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9151 leading to a memory leak, possible in functions like
9152 load_charset_map_from_file that can allocate an unbounded number
9153 of objects (Bug#8318).
9155 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9156 that could (at least in theory) be that large.
9158 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9159 This is less likely to overflow, and avoids undefined behavior if
9160 overflow does occur. All callers changed. Use strtoul to scan
9161 for the unsigned long integer.
9162 (pint2hrstr): Simplify and tune code slightly.
9163 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9165 * scroll.c (do_scrolling): Work around GCC bug 48228.
9166 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9168 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9169 This also avoids a warning with gcc -Wstrict-overflow.
9170 (validate_x_resource_name): Simplify count usage.
9171 This also avoids a warning with gcc -Wstrict-overflow.
9173 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9176 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9178 * process.c (Fmake_network_process): Use socklen_t, not int,
9179 where POSIX says socklen_t is required in portable programs.
9180 This fixes a porting bug on hosts like 64-bit HP-UX, where
9181 socklen_t is wider than int (Bug#8277).
9182 (Fmake_network_process, server_accept_connection):
9183 (wait_reading_process_output, read_process_output):
9186 * process.c: Rename or move locals to avoid shadowing.
9187 (list_processes_1, Fmake_network_process):
9188 (read_process_output_error_handler, exec_sentinel_error_handler):
9189 Rename or move locals.
9190 (Fmake_network_process): Define label "retry_connect" only if needed.
9191 (Fnetwork_interface_info): Fix pointer signedness.
9192 (process_send_signal): Add cast to avoid pointer signedness problem.
9193 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9194 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9196 Make tparam.h and terminfo.c consistent.
9197 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9198 Include tparam.h instead, since it declares them.
9199 * cm.h (PC): Remove extern decl; tparam.h now does this.
9200 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9201 * terminfo.c: Include tparam.h, to check interfaces.
9202 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9203 (tparam): Adjust signature to match interface in tparam.h;
9204 this removes some undefined behavior. Check that outstring and len
9205 are zero, which they always are with Emacs.
9206 * tparam.h (PC, BC, UP): New extern decls.
9208 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9209 (xftfont_open): Rename locals to avoid shadowing.
9211 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9212 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9213 (OTF_TAG_SYM): Omit macro if not needed.
9214 (ftfont_list): Remove unused local.
9215 (get_adstyle_property, ftfont_pattern_entity):
9216 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9217 Rename locals to avoid shadowing.
9219 * xfont.c (xfont_list_family): Mark var as initialized.
9221 * xml.c (make_dom): Now static.
9223 * composite.c (composition_compute_stop_pos): Rename local to
9225 (composition_reseat_it): Remove unused locals.
9226 (find_automatic_composition, composition_adjust_point): Likewise.
9227 (composition_update_it): Mark var as initialized.
9228 (find_automatic_composition): Mark vars as initialized,
9229 with a FIXME (Bug#8290).
9231 character.h: Rename locals to avoid shadowing.
9232 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9233 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9234 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9235 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9238 * textprop.c (property_change_between_p): Remove; unused.
9240 * intervals.c (interval_start_pos): Now static.
9242 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9244 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9245 Rename locals to avoid shadowing.
9247 * sound.c (wav_play, au_play, Fplay_sound_internal):
9248 Fix pointer signedness.
9249 (alsa_choose_format): Remove unused local var.
9250 (wav_play): Initialize a variable to 0, to prevent undefined
9251 behavior (Bug#8278).
9253 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9255 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9257 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9258 clobbering (Bug#8298).
9259 * sysdep.c (sys_subshell): Likewise.
9260 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9262 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9263 This should get cleaned up, so that child_setup has the
9264 same signature on all platforms.
9266 * callproc.c (call_process_cleanup): Now static.
9267 (relocate_fd): Rename locals to avoid shadowing.
9269 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9271 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9272 not to be necessary, and produces flickering.
9274 2011-03-20 Glenn Morris <rgm@gnu.org>
9276 * config.in: Remove file.
9278 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9280 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9281 are now in src/globals.h.
9282 (syms_of_minibuf): Remove spurious & from previous change.
9284 2011-03-20 Leo Liu <sdl.web@gmail.com>
9286 * minibuf.c (completing-read-function): New variable.
9287 (completing-read-default): Rename from completing-read.
9288 (completing-read): Call completing-read-function.
9290 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9292 * xfaces.c (Fx_load_color_file):
9293 Read color file from absolute filename (bug#8250).
9295 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9297 * makefile.w32-in: Update dependencies.
9299 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9301 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9303 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9305 Fix more problems found by GCC 4.5.2's static checks.
9307 * process.c (make_serial_process_unwind, send_process_trap):
9308 (sigchld_handler): Now static.
9310 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9311 That way, the code declares only the vars that it needs.
9312 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9313 * s/cygwin.h (PTY_ITERATION): Likewise.
9314 * s/darwin.h (PTY_ITERATION): Likewise.
9315 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9317 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9318 * process.c (allocate_pty): Don't declare stb unless it's needed.
9320 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9321 (CONSTANTLIM): Remove; unused.
9322 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9323 Define only if needed.
9325 * unexelf.c (unexec): Name an expression,
9326 to avoid gcc -Wbad-function-cast warning.
9327 Use a different way to cause a compilation error if anyone uses
9328 n rather than nn, a way that does not involve shadowing.
9329 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9331 * deps.mk (unexalpha.o): Remove; unused.
9333 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9334 * unexec.h: New file.
9335 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9336 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9338 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9339 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9340 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9341 Change as necessary to match prototype in unexec.h.
9343 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9345 (back_comment, skip_chars): Mark vars as initialized.
9347 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9348 Rename locals to avoid shadowing.
9350 * lread.c (read1): Rewrite so as not to use empty "else".
9351 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9353 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9355 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9356 warning when compiling print.c.
9358 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9359 instead of using an uninitialized var.
9360 (font_sort_entities): Mark var as initialized.
9362 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9364 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9365 pointers to constants.
9366 (font_parse_fcname): Remove unused vars.
9367 (font_delete_unmatched): Now static.
9368 (font_get_spec): Remove; unused.
9369 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9370 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9371 Rename or move locals to avoid shadowing.
9373 * fns.c (require_nesting_list, require_unwind): Now static.
9374 (Ffillarray): Rename locals to avoid shadowing.
9376 * floatfns.c (domain_error2): Define only if needed.
9377 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9379 * alloc.c (mark_backtrace): Move decl from here ...
9380 * lisp.h: ... to here, so that it can be checked.
9382 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9383 (Fdefvar): Rewrite so as not to use empty "else".
9384 (lisp_indirect_variable): Name an expression,
9385 to avoid gcc -Wbad-function-cast warning.
9386 (Fdefvar): Rename locals to avoid shadowing.
9388 * callint.c (quotify_arg, quotify_args): Now static.
9389 (Fcall_interactively): Rename locals to avoid shadowing.
9390 Use const pointer when appropriate.
9392 * lisp.h (get_system_name, get_operating_system_release):
9393 Move decls here, to check interfaces.
9394 * process.c (get_operating_system_release): Move decl to lisp.h.
9395 * xrdb.c (get_system_name): Likewise.
9396 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9397 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9398 some of which prompt warnings from gcc -Wbad-function-cast.
9399 (Fformat_time_string, Fencode_time, Finsert_char):
9400 (Ftranslate_region_internal, Fformat):
9401 Rename or remove local vars to avoid shadowing.
9402 (Ftranslate_region_internal): Mark var as initialized.
9404 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9407 * lisp.h (eassert): Check that the argument compiles, even if
9408 ENABLE_CHECKING is not defined.
9410 * data.c (Findirect_variable): Name an expression, to avoid
9411 gcc -Wbad-function-cast warning.
9412 (default_value, arithcompare, arith_driver, arith_error): Now static.
9413 (store_symval_forwarding): Rename local to avoid shadowing.
9414 (Fmake_variable_buffer_local, Fmake_local_variable):
9415 Mark variables as initialized.
9416 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9418 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9419 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9420 Rename locals to avoid shadowing.
9421 (mark_stack): Move local variables into the #ifdef region where
9423 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9424 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9426 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9427 (GC_STRING_CHARS): Remove; not used.
9428 (Fmemory_limit): Cast sbrk's returned value to char *.
9430 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9431 avoids undefined behavior in theory.
9433 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9435 Use functions, not macros, for up- and down-casing (Bug#8254).
9436 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9437 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9438 to use the following functions instead of these macros.
9439 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9440 EMACS_INT, since callers assume the returned value fits in int.
9441 (upcase1): Likewise, for UPCASE_TABLE.
9442 (uppercasep, lowercasep, upcase): New static inline functions.
9443 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9444 the race-condition problem in the old DOWNCASE.
9446 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9447 Rename locals to avoid shadowing.
9448 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9449 (regex_compile, re_search_2, re_match_2_internal):
9450 Remove unused local vars.
9451 (FREE_VAR): Rewrite so as not to use empty "else",
9452 which gcc can warn about.
9453 (regex_compile, re_match_2_internal): Mark locals as initialized.
9454 (RETALLOC_IF): Define only if needed.
9455 (WORDCHAR_P): Likewise. This one is never needed, but is used
9456 only in a comment talking about a compiler bug, so put inside
9457 the #if 0 of that comment.
9458 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9459 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9462 * search.c (boyer_moore): Rename locals to avoid shadowing.
9463 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9464 (PREV_CHAR_BOUNDARY): Likewise.
9466 * search.c (simple_search): Remove unused var.
9468 * dired.c (compile_pattern): Move decl from here ...
9469 * lisp.h: ... to here, so that it can be checked.
9470 (struct re_registers): New forward decl.
9472 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9474 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9476 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9477 Rename locals to avoid shadowing.
9478 (Fvertical_motion): Mark locals as initialized.
9480 * casefiddle.c (casify_object, casify_region): Now static.
9481 (casify_region): Mark local as initialized.
9483 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9485 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9486 New macros, so that the caller can use some names other than
9487 gcpro1, gcpro2, etc.
9488 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9490 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9491 argument, for consistency with GCPRO2_VAR, etc: it is now the
9492 prefix of the variable, not the variable itself. All uses
9494 * dired.c (directory_files_internal, file_name_completion):
9495 Rename locals to avoid shadowing.
9497 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9498 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9499 dired.c's scmp function, had undefined behavior.
9500 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9501 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9502 * buffer.h: ... to here, because these macros use current_buffer,
9503 and the new implementation with inline functions needs to have
9504 current_buffer in scope now, rather than later when the macros
9506 (downcase, upcase1): New static inline functions.
9507 (DOWNCASE, UPCASE1): Reimplement using these functions.
9508 This avoids undefined behavior in expressions like
9509 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9510 from race conditions in accessing the global variables
9511 case_temp1 and case_temp2.
9512 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9513 * lisp.h (case_temp1, case_temp2): Remove their decls.
9514 * character.h (ASCII_CHAR_P): Move from here ...
9515 * lisp.h: ... to here, so that the inline functions mentioned
9518 * dired.c (directory_files_internal_unwind): Now static.
9520 * fileio.c (file_name_as_directory, directory_file_name):
9521 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9523 (file_name_as_directory): Use const pointers when appropriate.
9524 (Fexpand_file_name): Likewise. In particular, newdir might
9525 point at constant storage, so make it a const pointer.
9526 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9527 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9529 (Fset_file_times, Finsert_file_contents, auto_save_error):
9530 Rename locals to avoid shadowing.
9532 * minibuf.c (choose_minibuf_frame_1): Now static.
9533 (Ftry_completion, Fall_completions): Rename or remove locals
9536 * marker.c (bytepos_to_charpos): Remove; unused.
9538 * lisp.h (verify_bytepos, count_markers): New decls,
9539 so that gcc does not warn that these functions aren't declared.
9541 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9542 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9543 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9544 (copy_text): Remove unused local var.
9546 * filelock.c (within_one_second): Now static.
9547 (lock_file_1): Rename local to avoid shadowing.
9549 * buffer.c (fix_overlays_before): Mark locals as initialized.
9550 (fix_start_end_in_overlays): Likewise. This function should be
9551 simplified by using pointers-to-pointers, but that's a different
9553 (switch_to_buffer_1): Now static.
9554 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9555 (report_overlay_modification): Rename locals to avoid shadowing.
9557 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9558 Fix pointer signedness issue.
9559 (sys_subshell): Mark local as volatile if checking for lint,
9560 to suppress a gcc -Wclobbered warning that does not seem to be right.
9561 (MAXPATHLEN): Define only if needed.
9563 * process.c (serial_open, serial_configure): Move decls from here ...
9564 * systty.h: ... to here, so that they can be checked.
9566 * fns.c (get_random, seed_random): Move extern decls from here ...
9567 * lisp.h: ... to here, so that they can be checked.
9569 * sysdep.c (reset_io): Now static.
9570 (wait_for_termination_signal): Remove; unused.
9572 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9573 (copy_keymap_item, append_key, push_text_char_description):
9575 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9576 (DENSE_TABLE_SIZE): Remove; unused.
9577 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9578 (describe_map_tree):
9579 Rename locals to avoid shadowing.
9581 * keyboard.c: Declare functions static if they are not used elsewhere.
9582 (echo_char, echo_dash, cmd_error, top_level_2):
9583 (poll_for_input, handle_async_input): Now static.
9584 (read_char, kbd_buffer_get_event, make_lispy_position):
9585 (make_lispy_event, make_lispy_movement, apply_modifiers):
9586 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9587 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9588 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9589 (read_key_sequence, read_char): Mark locals as initialized.
9590 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9592 * keyboard.h (make_ctrl_char): New decl.
9593 (mark_kboards): Move decl here ...
9594 * alloc.c (mark_kboards): ... from here.
9596 * lisp.h (force_auto_save_soon): New decl.
9598 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9599 (DEFINE_DUMMY_FUNCTION): New macro.
9600 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9602 (main): Add casts to avoid warnings
9603 if GCC considers string literals to be constants.
9605 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9607 * dbusbind.c: Pointer signedness fixes.
9608 (xd_signature, xd_append_arg, xd_initialize):
9609 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9610 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9611 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9612 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9614 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9615 if GCC considers string literals to be constants.
9616 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9618 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9620 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9621 (print_preprocess, print_object): New macro to fix last change.
9623 * print.c (print_preprocess): Don't forget font objects.
9625 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9627 * emacs.c (USAGE3): Doc fixes.
9629 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9631 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9634 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9636 * lisp.h (VWindow_system, Qfile_name_history):
9637 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9638 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9639 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9641 * w32select.c: Don't #include "keyboard.h".
9642 (run_protected): Add extern declaration for waiting_for_input.
9644 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9645 * w32console.c (detect_input_pending, read_input_pending)
9646 (encode_terminal_code):
9647 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9648 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9649 (w32_system_caret_y, Qfile_name_history):
9650 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9651 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9652 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9653 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9654 * w32proc.c (Qlocal, report_file_error):
9655 * w32term.c (Vwindow_system, updating_frame):
9656 * w32uniscribe.c (initialized, uniscribe_font_driver):
9657 Remove unneeded extern declarations.
9659 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9661 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9663 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9665 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9666 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9667 These macros can no longer be used for assignment.
9669 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9670 Assign struct members directly, instead of using BUF_BEGV etc.
9671 (record_buffer_markers, fetch_buffer_markers): New functions for
9672 recording and fetching special buffer markers.
9673 (set_buffer_internal_1, set_buffer_temp): Use them.
9675 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9677 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9679 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9680 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9682 * xdisp.c (hscroll_window_tree):
9683 (reconsider_clip_changes): Use PT instead of BUF_PT.
9685 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9687 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9688 $(EMACS_ROOT)/lib/intprops.h.
9690 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9692 Fix more problems found by GCC 4.5.2's static checks.
9694 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9695 to unsigned char * to avoid compiler diagnostic.
9696 (xg_free_frame_widgets): Make it clear that a local variable is
9697 needed only if USE_GTK_TOOLTIP.
9698 (gdk_window_get_screen): Make it clear that this macro is needed
9699 only if USE_GTK_TOOLTIP.
9700 (int_gtk_range_get_value): New function, which avoids a diagnostic
9701 from gcc -Wbad-function-cast.
9702 (xg_set_toolkit_scroll_bar_thumb): Use it.
9703 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9704 diagnostic from gcc -Wbad-function-cast.
9705 (get_utf8_string, xg_get_file_with_chooser):
9706 Rename locals to avoid shadowing.
9707 (create_dialog): Move locals to avoid shadowing.
9709 * xgselect.c (xg_select): Remove unused var.
9711 * image.c (four_corners_best): Mark locals as initialized.
9712 (gif_load): Initialize transparent_p to zero (Bug#8238).
9713 Mark another local as initialized.
9714 (my_png_error, my_error_exit): Mark with NO_RETURN.
9716 * image.c (clear_image_cache): Now static.
9717 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9718 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9719 (x_edge_detection): Remove unnecessary cast that
9720 gcc -Wbad-function-cast diagnoses.
9721 (gif_load): Fix pointer signedness.
9722 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9723 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9725 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9727 Improve quality of tests for time stamp overflow.
9728 For example, without this patch (encode-time 0 0 0 1 1
9729 1152921504606846976) returns the obviously-bogus value (-948597
9730 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9731 reports time overflow. See
9732 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9733 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9734 * editfns.c: Include limits.h and intprops.h.
9735 (TIME_T_MIN, TIME_T_MAX): New macros.
9736 (time_overflow): Move earlier, to before first use.
9737 (hi_time, lo_time): New functions, for an accurate test for
9739 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9740 (Fget_internal_run_time): Don't assume time_t fits in int.
9741 (make_time): Use list2 instead of Fcons twice.
9742 (Fdecode_time): More accurate test for out-of-range times.
9743 (check_tm_member): New function.
9744 (Fencode_time): Use it, to test for out-of-range times.
9745 (lisp_time_argument): Don't rely on undefined left-shift and
9746 right-shift behavior when checking for time stamp overflow.
9748 * editfns.c (time_overflow): New function, refactoring common code.
9749 (Fformat_time_string, Fdecode_time, Fencode_time):
9750 (Fcurrent_time_string): Use it.
9752 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9753 * dired.c (make_time): Move to ...
9754 * editfns.c (make_time): ... here.
9755 * systime.h: Note the move.
9757 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9759 * fringe.c (update_window_fringes): Remove unused variables.
9761 * unexmacosx.c (copy_data_segment): Also copy __got section.
9764 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9766 * termcap.c [MSDOS]: Include "msdos.h".
9767 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9768 Constify `char *' arguments and their references according to
9769 prototypes in tparam.h.
9771 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9773 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9774 Adapt all references accordingly.
9776 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9778 2011-03-11 Tom Tromey <tromey@redhat.com>
9780 * buffer.c (syms_of_buffer): Remove obsolete comment.
9782 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9784 * termhooks.h (encode_terminal_code): Declare prototype.
9786 * msdos.c (encode_terminal_code): Don't declare prototype.
9788 * term.c (encode_terminal_code): Now external again, used by
9789 w32console.c and msdos.c.
9791 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9792 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9794 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9796 Fix some minor problems found by GCC 4.5.2's static checks.
9798 * fringe.c (update_window_fringes): Mark locals as initialized
9800 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9802 * alloc.c (mark_fringe_data): Move decl from here ...
9803 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9804 to check its interface.
9805 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9807 * fontset.c (free_realized_fontset): Now static.
9808 (Fset_fontset_font): Rename local to avoid shadowing.
9809 (fontset_font): Mark local as initialized.
9810 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9812 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9814 * xselect.c (x_disown_buffer_selections): Remove; not used.
9815 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9816 (x_own_selection, Fx_disown_selection_internal): Rename locals
9818 (x_handle_dnd_message): Remove local to avoid shadowing.
9820 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9821 so that the caller can use some name other than gcpro1.
9822 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9823 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9824 (Fx_backspace_delete_keys_p):
9825 Use them to avoid shadowing, and rename vars to avoid shadowing.
9826 (x_decode_color, x_set_name, x_window): Now static.
9827 (Fx_create_frame): Add braces to silence GCC warning.
9828 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9829 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9830 Remove unused locals.
9831 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9832 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9833 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9836 * xterm.h (x_mouse_leave): New decl.
9838 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9839 Remove unused functions.
9840 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9841 (x_calc_absolute_position): Now static.
9842 (XTread_socket): Don't define label "out" unless it's used.
9843 Don't declare local "event" unless it's used.
9844 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9845 unless they are used.
9846 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9847 (x_fatal_error_signal): Remove; not used.
9848 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9849 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9850 (x_error_catcher, x_connection_closed, x_error_handler):
9851 (x_error_quitter, xembed_send_message, x_iconify_frame):
9852 (my_log_handler): Rename locals to avoid shadowing.
9853 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9854 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9856 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9857 Rename or move locals to avoid shadowing.
9858 (tty_defined_color, merge_face_heights): Now static.
9859 (free_realized_faces_for_fontset): Remove; not used.
9860 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9861 does not deduce is never used uninitialized.
9862 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9863 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9865 * terminal.c (store_terminal_param): Now static.
9867 * xmenu.c (menu_highlight_callback): Now static.
9868 (set_frame_menubar): Remove unused local.
9869 (xmenu_show): Rename parameter to avoid shadowing.
9870 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9871 since they might point to immutable storage.
9872 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9873 since it's unused otherwise.
9875 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9876 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9877 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9878 avoids a gcc -Wuninitialized diagnostic.
9879 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9880 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9881 does not deduce are never used uninitialized.
9883 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9885 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9886 * window.c (window_loop, size_window):
9887 (run_window_configuration_change_hook, enlarge_window): Likewise.
9889 * window.c (display_buffer): Now static.
9890 (size_window): Mark variables that gcc -Wuninitialized
9891 does not deduce are never used uninitialized.
9892 * window.h (check_all_windows): New decl, to forestall
9893 gcc -Wmissing-prototypes diagnostic.
9894 * dispextern.h (bidi_dump_cached_states): Likewise.
9896 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9898 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9900 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9901 and to avoid gcc -Wuninitialized warning.
9902 (load_charset_map): Mark variables that gcc -Wuninitialized
9903 does not deduce are never used uninitialized.
9904 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9906 * coding.c (coding_set_source, coding_set_destination):
9907 Use "else { /* comment */ }" rather than "else /* comment */;"
9908 for clarity, and to avoid gcc -Wempty-body warning.
9909 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9910 a block, when the outer 'i' will do.
9911 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9912 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9913 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9914 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9915 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9916 Rename locals to avoid shadowing.
9917 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9918 * coding.c (emacs_mule_char, encode_invocation_designation):
9919 Now static, since they're not used elsewhere.
9920 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9921 (decode_coding_object, encode_coding_object, detect_coding_system):
9922 (decode_coding_emacs_mule): Mark variables that gcc
9923 -Wuninitialized does not deduce are never used uninitialized.
9924 (detect_coding_iso_2022): Initialize a local variable that might
9925 be used uninitialized. Leave a FIXME because it's not clear that
9926 this initialization is needed. (Bug#8211)
9927 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9928 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9929 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9930 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9931 Remove unused macros.
9933 * category.c (hash_get_category_set): Remove unused local var.
9934 (copy_category_table): Now static, since it's not used elsewhere.
9935 * character.c (string_count_byte8): Likewise.
9937 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9938 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9940 * chartab.c (copy_sub_char_table): Now static, since it's not used
9942 (sub_char_table_ref_and_range, char_table_ref_and_range):
9943 Rename locals to avoid shadowing.
9944 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9946 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9947 (BIDI_BOB): Remove unused macro.
9949 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9950 deduce are never used uninitialized.
9951 * term.c (encode_terminal_code): Likewise.
9953 * term.c (encode_terminal_code): Now static. Remove unused local.
9955 * tparam.h: New file.
9956 * term.c, tparam.h: Include it.
9957 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9958 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9959 Move these decls to tparam.h, and make them agree with what
9960 is actually in tparam.c. The previous trick of using incompatible
9961 decls in different modules does not conform to the C standard.
9962 All callers of tparam changed to use tparam's actual API.
9963 * tparam.c (tparam1, tparam, tgoto):
9964 Use const pointers where appropriate.
9966 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9967 * cm.h (struct cm): Likewise.
9968 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9969 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9970 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9971 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9972 (turn_on_face, init_tty): Likewise.
9973 * termchar.h (struct tty_display_info): Likewise.
9975 * term.c (term_mouse_position): Rename local to avoid shadowing.
9977 * alloc.c (mark_ttys): Move decl from here ...
9978 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9980 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9982 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9984 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9986 * search.c (compile_pattern_1): Remove argument regp, unused since
9987 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9988 (compile_pattern): Don't pass it.
9990 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9992 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9993 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9995 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9997 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9999 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10000 gdk_window_get_screen, gdk_window_get_geometry,
10001 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10002 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10003 (xg_get_pixbuf_from_pixmap): New function.
10004 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10005 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10006 Call xg_get_pixbuf_from_pixmap instead of
10007 gdk_pixbuf_get_from_drawable.
10008 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10009 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10010 (xg_check_special_colors): Use GtkStyleContext and its functions
10012 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10013 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10014 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10015 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10016 Call gtk_widget_get_preferred_size.
10017 (xg_frame_resized): gdk_window_get_geometry only takes 5
10019 (xg_win_to_widget, xg_event_is_for_menubar):
10020 Call gdk_x11_window_lookup_for_display.
10021 (xg_set_widget_bg): New function.
10022 (delete_cb): New function.
10023 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10024 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10025 (xg_set_background_color): Call xg_set_widget_bg.
10026 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10027 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10028 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10029 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10031 (update_frame_tool_bar): Call gtk_widget_hide.
10032 (xg_initialize): Use GDK_KEY_g.
10034 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10036 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10038 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10039 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10040 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10042 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10044 * w32xfns.c (select_palette): Check success of RealizePalette against
10045 GDI_ERROR, not zero.
10047 See ChangeLog.11 for earlier changes.
10049 ;; Local Variables:
10053 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10055 This file is part of GNU Emacs.
10057 GNU Emacs is free software: you can redistribute it and/or modify
10058 it under the terms of the GNU General Public License as published by
10059 the Free Software Foundation, either version 3 of the License, or
10060 (at your option) any later version.
10062 GNU Emacs is distributed in the hope that it will be useful,
10063 but WITHOUT ANY WARRANTY; without even the implied warranty of
10064 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10065 GNU General Public License for more details.
10067 You should have received a copy of the GNU General Public License
10068 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.