1 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
3 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8 Use much-faster test for byte-length change.
9 Don't assume string byte-length fits in 'int'.
10 Check that character arg fits in 'int'.
11 (mapcar1): Declare byte as byte, for clarity.
13 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
15 * fns.c (concat): Catch string overflow earlier.
16 Do not rely on integer wraparound.
18 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
20 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
22 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
23 * xdisp.c (forward_to_next_line_start)
24 (back_to_previous_visible_line_start)
25 (reseat_at_next_visible_line_start, next_element_from_buffer):
26 Don't arbitrarily truncate the value of 'selective' to int.
28 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
30 * composite.c: Don't truncate sizes to 'int'.
31 (composition_gstring_p, composition_reseat_it)
32 (composition_adjust_point): Use EMACS_INT, not int.
33 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
34 not EMACS_UINT, for indexes.
36 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
38 * buffer.c: Include <verify.h>.
39 (struct sortvec.priority, struct sortstr.priority):
40 Now EMACS_INT, not int.
41 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
42 (struct sortstr.size, record_overlay_string)
43 (struct sortstrlist.size, struct sortlist.used):
44 Don't truncate size to int.
45 (record_overlay_string): Check for size-calculation overflow.
46 (init_buffer_once): Check at compile-time, not run-time.
48 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
50 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
51 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
52 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
54 Improve buffer-overflow checking (Bug#8873).
55 * fileio.c (Finsert_file_contents):
56 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
57 Remove the old (too-loose) buffer overflow checks.
58 They weren't needed, since make_gap checks for buffer overflow.
59 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
60 The old code merely checked for Emacs fixnum overflow, and relied
61 on undefined (wraparound) behavior. The new code avoids undefined
62 behavior, and also checks for ptrdiff_t and/or size_t overflow.
64 * editfns.c (Finsert_char): Don't dump core with very negative counts.
65 Tune. Don't use wider integers than needed. Don't use alloca.
66 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
68 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
70 * insdel.c, lisp.h (buffer_overflow): New function.
71 (insert_from_buffer_1, replace_range, replace_range_2):
72 * insdel.c (make_gap_larger):
73 * editfns.c (Finsert_char):
74 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
76 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
78 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
80 Integer overflow and signedness fixes (Bug#8873).
82 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
83 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
85 * fileio.c: Don't assume EMACS_INT fits in off_t.
86 (emacs_lseek): New static function.
87 (Finsert_file_contents, Fwrite_region): Use it.
88 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
90 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
92 * fns.c: Don't overflow int when computing a list length.
93 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
94 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
95 truncation on 64-bit hosts. Check for QUIT every
96 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
97 faster and is responsive enough.
98 (Flength): Report an error instead of overflowing an integer.
99 (Fsafe_length): Return a float if the value is not representable
100 as a fixnum. This shouldn't happen except in contrived situations.
101 (Fnthcdr, Fsort): Don't assume list length fits in int.
102 (Fcopy_sequence): Don't assume vector length fits in int.
104 * alloc.c: Check that resized vectors' lengths fit in fixnums.
105 (header_size, word_size): New constants.
106 (allocate_vectorlike): Don't check size overflow here.
107 (allocate_vector): Check it here instead, since this is the only
108 caller of allocate_vectorlike that could cause overflow.
109 Check that the new vector's length is representable as a fixnum.
111 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
112 The previous code was bogus. For example, next_almost_prime (32)
113 returned 39, which is undesirable as it is a multiple of 3; and
114 next_almost_prime (24) returned 25, which is a multiple of 5 so
115 why was the code bothering to check for multiples of 7?
117 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
119 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
121 Variadic C functions now count arguments with ptrdiff_t.
122 This partly undoes my 2011-03-30 change, which replaced int with size_t.
123 Back then I didn't know that the Emacs coding style prefers signed int.
124 Also, in the meantime I found a few more instances where arguments
125 were being counted with int, which may truncate counts on 64-bit
126 machines, or EMACS_INT, which may be unnecessarily wide.
127 * lisp.h (struct Lisp_Subr.function.aMANY)
128 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
129 Arg counts are now ptrdiff_t, not size_t.
130 All variadic functions and their callers changed accordingly.
131 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
132 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
133 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
134 * callint.c (Fcall_interactively): Check arg count for overflow,
135 to avoid potential buffer overrun. Use signed char, not 'int',
136 for 'varies' array, so that we needn't bother to check its size
137 calculation for overflow.
138 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
139 * eval.c (apply_lambda):
140 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
141 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
142 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
144 * callint.c (Fcall_interactively): Don't use index var as event count.
146 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
147 * mem-limits.h (SIZE): Remove; no longer used.
149 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
151 Remove unnecessary casts.
152 * xterm.c (x_term_init):
153 * xfns.c (x_set_border_pixel):
154 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
155 These aren't needed now that we assume ANSI C.
157 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
158 It's more likely to cause problems (due to unsigned overflow)
161 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
163 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
165 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
167 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
169 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
171 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
173 GLYPH_CODE_FACE returns EMACS_INT, not int.
174 * dispextern.h (merge_faces):
175 * xfaces.c (merge_faces):
176 * xdisp.c (get_next_display_element, next_element_from_display_vector):
177 Don't assume EMACS_INT fits in int.
179 * character.h (CHAR_VALID_P): Remove unused parameter.
180 * fontset.c, lisp.h, xdisp.c: All uses changed.
182 * editfns.c (Ftranslate_region_internal): Omit redundant test.
184 * fns.c (concat): Minor tuning based on overflow analysis.
185 This doesn't fix any bugs. Use int to hold character, instead
186 of constantly refetching from Emacs object. Use XFASTINT, not
187 XINT, for value known to be a character. Don't bother comparing
188 a single byte to 0400, as it's always less.
190 * floatfns.c (Fexpt):
191 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
193 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
196 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
198 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
199 Without this fix, on a 64-bit host (aset S 0 4294967386) would
200 incorrectly succeed when S was a string, because 4294967386 was
201 truncated before it was used.
203 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
204 Otherwise, an out-of-range integer could cause undefined behavior
207 * composite.c: Use int, not EMACS_INT, for characters.
208 (fill_gstring_body, composition_compute_stop_pos): Use int, not
209 EMACS_INT, for values that are known to be in character range.
210 This doesn't fix any bugs but is the usual style inside Emacs and
211 may generate better code on 32-bit machines.
213 Make sure a 64-bit char is never passed to ENCODE_CHAR.
214 This is for reasons similar to the recent CHAR_STRING fix.
215 * charset.c (Fencode_char): Check that character arg is actually
216 a character. Pass an int to ENCODE_CHAR.
217 * charset.h (ENCODE_CHAR): Verify that the character argument is no
218 wider than 'int', as a compile-time check to prevent future regressions
221 * character.c (char_string): Remove unnecessary casts.
223 Make sure a 64-bit char is never passed to CHAR_STRING.
224 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
225 by silently ignoring the top 32 bits, allowing some values
226 that were far too large to be valid characters.
227 * character.h: Include <verify.h>.
228 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
229 arguments are no wider than unsigned, as a compile-time check
230 to prevent future regressions in this area.
232 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
233 (Fsubst_char_in_region):
235 * xdisp.c (decode_mode_spec_coding):
236 Adjust to CHAR_STRING's new requirement.
237 * editfns.c (Finsert_char, Fsubst_char_in_region):
238 * fns.c (concat): Check that character args are actually
239 characters. Without this test, these functions did the wrong
240 thing with wildly out-of-range values on 64-bit hosts.
242 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
243 These casts should not be needed on 32-bit hosts, either.
244 * keyboard.c (read_char):
245 * lread.c (Fload): Remove casts to unsigned.
247 * lisp.h (UNSIGNED_CMP): New macro.
248 This fixes comparison bugs on 64-bit hosts.
249 (ASCII_CHAR_P): Use it.
250 * casefiddle.c (casify_object):
251 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
252 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
253 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
254 * dispextern.h (FACE_FROM_ID):
255 * keyboard.c (read_char): Use UNSIGNED_CMP.
257 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
258 not to EMACS_INT, to avoid GCC warning.
260 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
262 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
263 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
264 isn't needed on 32-bit machines.
266 * buffer.c (Fgenerate_new_buffer_name):
267 Use EMACS_INT for count, not int.
268 (advance_to_char_boundary): Return EMACS_INT, not int.
270 * data.c (Qcompiled_function): Now static.
272 * window.c (window_body_lines): Now static.
274 * image.c (gif_load): Rename local to avoid shadowing.
276 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
277 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
278 * alloc.c (make_save_value): Integer argument is now of type
280 (mark_object): Use ptrdiff_t, not int.
281 * lisp.h (pD): New macro.
282 * print.c (print_object): Use it.
284 * alloc.c: Use EMACS_INT, not int, to count objects.
285 (total_conses, total_markers, total_symbols, total_vector_size)
286 (total_free_conses, total_free_markers, total_free_symbols)
287 (total_free_floats, total_floats, total_free_intervals)
288 (total_intervals, total_strings, total_free_strings):
289 Now EMACS_INT, not int. All uses changed.
290 (Fgarbage_collect): Compute overall total using a double, so that
291 integer overflow is less likely to be a problem. Check for overflow
292 when converting back to an integer.
293 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
294 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
295 These were 'int' variables that could overflow on 64-bit hosts;
296 they were never used, so remove them instead of repairing them.
297 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
298 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
299 Previously, this ceilinged at INT_MAX, but that doesn't work on
301 (allocate_pseudovector): Don't use EMACS_INT when int would do.
303 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
304 (allocate_vectorlike): Check for ptrdiff_t overflow.
305 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
306 when a (possibly-narrower) signed value would do just as well.
307 We prefer using signed arithmetic, to avoid comparison confusion.
309 * alloc.c: Catch some string size overflows that we were missing.
310 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
311 for convenience in STRING_BYTES_MAX.
312 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
313 The definition here is exact; the one in lisp.h was approximate.
314 (allocate_string_data): Check for string overflow. This catches
315 some instances we weren't catching before. Also, it catches
316 size_t overflow on (unusual) hosts where SIZE_MAX <= min
317 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
318 and ptrdiff_t and EMACS_INT are both 64 bits.
320 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
321 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
322 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
324 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
326 * alloc.c (Fmake_string): Check for out-of-range init.
328 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
330 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
332 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
334 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
335 xg_get_default_scrollbar_width.
337 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
338 (int_gtk_range_get_value): Move to the scroll bar part of the file.
339 (style_changed_cb): Call update_theme_scrollbar_width and call
340 x_set_scroll_bar_default_width and xg_frame_set_char_size for
341 all frames (Bug#8505).
342 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
343 Call gtk_window_set_resizable if HAVE_GTK3.
344 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
345 and height if HAVE_GTK3 (Bug#8505).
346 (scroll_bar_width_for_theme): New variable.
347 (update_theme_scrollbar_width): New function.
348 (xg_get_default_scrollbar_width): Move code to
349 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
350 (xg_initialize): Call update_theme_scrollbar_width.
352 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
354 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
356 2011-06-12 Martin Rudalics <rudalics@gmx.at>
358 * frame.c (make_frame): Call other_buffer_safely instead of
361 * window.c (temp_output_buffer_show): Call display_buffer with
362 second argument Vtemp_buffer_show_specifiers and reset latter
363 immediately after the call.
364 (Vtemp_buffer_show_specifiers): New variable.
365 (auto_window_vscroll_p, next_screen_context_lines)
366 (Vscroll_preserve_screen_position): Remove leading asterisks from
369 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
371 Fix minor problems found by GCC 4.6.0 static checking.
372 * buffer.c (Qclone_number): Remove for now, as it's unused.
373 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
374 (record_buffer): Remove unused local.
375 * frame.c (other_visible_frames, frame_buffer_list): Now static.
376 (set_frame_buffer_list): Remove; unused.
377 * frame.h (other_visible_frames): Remove decl.
378 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
379 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
380 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
382 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
383 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
384 Define only if HAVE_GPM.
385 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
386 (update_hints_inhibit): Remove; never set. All uses removed.
387 * widgetprv.h (emacsFrameClassRec): Remove decl.
388 * window.c (delete_deletable_window): Now returns void, since it
389 wasn't returning anything.
390 (compare_window_configurations): Remove unused locals.
391 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
392 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
393 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
394 the same widths as pointers. This follows up on the 2011-05-06 patch.
395 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
397 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
399 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
401 * makefile.w32-in: Update dependencies.
402 (LISP_H): Add lib/intprops.h.
404 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
406 * image.c (gif_load): Add animation frame delay to the metadata.
407 (syms_of_image): Use DEFSYM. New symbol `delay'.
409 2011-06-11 Martin Rudalics <rudalics@gmx.at>
411 * window.c (delete_deletable_window): Re-add.
412 (Fset_window_configuration): Rewrite to handle dead buffers and
413 consequently deletable windows.
414 (window_tree, Fwindow_tree): Remove. Supply functionality in
416 (compare_window_configurations): Simplify code.
418 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
420 * image.c (imagemagick_load_image): Fix type mismatch.
421 (Fimagemagick_types): Likewise.
423 * window.h (replace_buffer_in_windows): Declare.
425 2011-06-11 Martin Rudalics <rudalics@gmx.at>
427 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
428 Qclone_number. Remove external declaration of Qdelete_window.
429 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
431 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
432 Qbuffer_list_update_hook if allowed.
433 (Fother_buffer): Rewrite doc-string. Major rewrite for new
434 buffer list implementation.
435 (other_buffer_safely): New function.
436 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
437 calls to replace_buffer_in_windows and
438 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
440 (record_buffer): Inhibit quitting and rewrite using quittable
441 functions. Run Qbuffer_list_update_hook if allowed.
442 (Frecord_buffer, Funrecord_buffer): New functions.
443 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
444 switch-to-buffer to window.el.
445 (bury-buffer): Move to window.el.
446 (Vbuffer_list_update_hook): New variable.
448 * lisp.h (other_buffer_safely): Add prototype in buffer.c
451 * window.h (resize_frame_windows): Move up in code.
452 (Fwindow_frame): Remove EXFUN.
453 (replace_buffer_in_all_windows): Remove prototype.
454 (replace_buffer_in_windows_safely): Add prototype.
456 * window.c: Declare Qdelete_window static again. Move down
457 declaration of select_count.
458 (Fnext_window, Fprevious_window): Rewrite doc-strings.
459 (Fother_window): Move to window.el.
460 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
461 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
462 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
464 (replace_buffer_in_windows): Implement by calling
465 Qreplace_buffer_in_windows.
466 (replace_buffer_in_all_windows): Remove with some functionality
467 moved into replace_buffer_in_windows_safely.
468 (replace_buffer_in_windows_safely): New function.
469 (select_window_norecord, select_frame_norecord): Move in front
470 of run_window_configuration_change_hook. Remove now obsolete
472 (Fset_window_buffer): Rewrite doc-string. Call
473 Qrecord_window_buffer.
474 (keys_of_window): Move binding for other-window to window.el.
476 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
478 * dispextern.h (struct image): Replace data member, whose int_val
479 and ptr_val fields were not used by anything, with a single
482 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
483 (gif_clear_image, gif_load, imagemagick_load_image)
484 (gs_clear_image, gs_load): Callers changed.
486 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
488 * buffer.h: Include <time.h>, for time_t.
489 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
491 Fix minor problems found by static checking.
493 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
495 Make identifiers static if they are not used in other modules.
496 * data.c (Qcompiled_function, Qframe, Qvector):
497 * image.c (QimageMagick, Qsvg):
498 * minibuf.c (Qmetadata):
499 * window.c (resize_window_check, resize_root_window): Now static.
500 * window.h (resize_window_check, resize_root_window): Remove decls.
502 * window.c (window_deletion_count, delete_deletable_window):
504 (window_body_lines): Now static.
505 (Fdelete_other_windows_internal): Mark vars as initialized.
506 Make sure 'resize_failed' is initialized.
507 (run_window_configuration_change_hook): Rename local to avoid shadowing.
508 (resize_window_apply): Remove unused local.
509 * window.h (delete_deletable_window): Remove decl.
511 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
512 (imagemagick_load_image): Fix pointer signedness problem by changing
513 last arg from unsigned char * to char *. All uses changed.
514 Also, fix a local for similar reasons.
515 Remove unused locals. Remove locals to avoid shadowing.
516 (fn_rsvg_handle_free): Remove; unused.
517 (svg_load, svg_load_image): Fix pointer signedness problem.
518 (imagemagick_load_image): Don't use garbage pointer image_wand.
520 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
522 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
524 * image.c (gif_load): Fix omitted cast error introduced by
527 2011-06-10 Martin Rudalics <rudalics@gmx.at>
529 * window.h (resize_proportionally, orig_total_lines)
530 (orig_top_line): Remove from window structure.
531 (set_window_height, set_window_width, change_window_heights)
532 (Fdelete_window): Remove prototypes.
533 (resize_frame_windows): Remove duplicate declaration.
535 2011-06-10 Eli Zaretskii <eliz@gnu.org>
537 * window.h (resize_frame_windows, resize_window_check)
538 (delete_deletable_window, resize_root_window)
539 (resize_frame_windows): Declare prototypes.
541 * window.c (resize_window_apply): Make definition be "static" to
544 2011-06-10 Martin Rudalics <rudalics@gmx.at>
546 * window.c: Remove declarations of Qwindow_size_fixed,
547 window_min_size_1, window_min_size_2, window_min_size,
548 size_window, window_fixed_size_p, enlarge_window, delete_window.
549 Remove static from declaration of Qdelete_window, it's
550 temporarily needed by Fbury_buffer.
551 (replace_window): Don't assign orig_top_line and
553 (Fdelete_window, delete_window): Remove. Window deletion is
554 handled by window.el.
555 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
556 Fdelete_window calls with calls to Qdelete_window.
557 (Fdelete_other_windows): Remove. Deleting other windows is
558 handled by window.el.
559 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
560 handled in window.el.
561 (window_min_size_2, window_min_size_1, window_min_size): Remove.
562 Window minimum sizes are handled in window.el.
563 (shrink_windows, size_window, set_window_height)
564 (set_window_width, change_window_heights, window_height)
565 (window_width, CURBEG, CURSIZE, enlarge_window)
566 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
567 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
568 handled in window.el.
569 (make_dummy_parent): Rename to make_parent_window and give it a
570 second argument horflag.
571 (make_window): Don't set resize_proportionally any more.
572 (Fsplit_window): Remove. Windows are split in window.el.
573 (save_restore_action, save_restore_orig_size)
574 (shrink_window_lowest_first, save_restore_orig_size): Remove.
575 Resize mini windows in window.el.
576 (grow_mini_window, shrink_mini_window): Implement by calling
577 Qresize_root_window_vertically, resize_window_check and
579 (saved_window, Fset_window_configuration, save_window_save): Do
580 not handle orig_top_line, orig_total_lines, and
581 resize_proportionally.
582 (window_min_height, window_min_width): Move to window.el.
583 (keys_of_window): Move bindings for delete-other-windows,
584 split-window, delete-window and enlarge-window to window.el.
586 * buffer.c: Temporarily extern Qdelete_window.
587 (Fbury_buffer): Temporarily call Qdelete_window instead of
588 Fdelete_window (Fbury_buffer will move to window.el soon).
590 * frame.c (set_menu_bar_lines_1): Remove code handling
591 orig_top_line and orig_total_lines.
593 * dispnew.c (adjust_frame_glyphs_initially): Don't use
594 set_window_height but set heights directly.
595 (change_frame_size_1): Use resize_frame_windows.
597 * xdisp.c (init_xdisp): Don't use set_window_height but set
600 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
601 resize_frame_windows instead of change_window_heights and run
602 run_window_configuration_change_hook.
604 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
605 instead of change_window_heights and run
606 run_window_configuration_change_hook.
608 2011-06-09 Martin Rudalics <rudalics@gmx.at>
610 * window.c (replace_window): Rename second argument REPLACEMENT to
611 NEW. New third argument SETFLAG. Rewrite.
612 (delete_window, make_dummy_parent): Call replace_window with
614 (window_list_1): Move down in code.
615 (run_window_configuration_change_hook): Move set_buffer part
616 before select_frame_norecord part in order to unwind correctly.
617 Rename count1 to count.
618 (recombine_windows, delete_deletable_window, resize_root_window)
619 (Fdelete_other_windows_internal)
620 (Frun_window_configuration_change_hook, make_parent_window)
621 (resize_window_check, resize_window_apply, Fresize_window_apply)
622 (resize_frame_windows, Fsplit_window_internal)
623 (Fdelete_window_internal, Fresize_mini_window_internal): New
625 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
627 2011-06-08 Martin Rudalics <rudalics@gmx.at>
629 * window.h (window): Add some new members to window structure -
630 normal_lines, normal_cols, new_total, new_normal, clone_number,
631 splits, nest, prev_buffers, next_buffers.
632 (WINDOW_TOTAL_SIZE): Move here from window.c.
633 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
635 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
637 (make_dummy_parent): Set new members of windows structure.
638 (make_window): Move down in code. Handle new members of window
640 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
641 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
642 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
643 (Fset_window_prev_buffers, Fwindow_next_buffers)
644 (Fset_window_next_buffers, Fset_window_clone_number): New
646 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
647 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
649 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
650 Argument WINDOW can be now internal window too.
651 (Fwindow_use_time): Move up in code.
652 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
654 (Fset_window_configuration, saved_window)
655 (Fcurrent_window_configuration, save_window_save): Handle new
656 members of window structure.
657 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
658 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
659 (syms_of_window): New Lisp objects Qrecord_window_buffer,
660 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
661 Qget_mru_window, Qresize_root_window,
662 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
663 Qauto_buffer_name; staticpro them.
665 2011-06-07 Martin Rudalics <rudalics@gmx.at>
667 * window.c (Fwindow_total_size, Fwindow_left_column)
668 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
669 (Fwindow_list_1): New functions.
670 (window_box_text_cols): Replace with window_body_cols.
671 (Fwindow_width, Fscroll_left, Fscroll_right): Use
672 window_body_cols instead of window_box_text_cols.
673 (delete_window, Fset_window_configuration): Call
674 delete_all_subwindows with window as argument.
675 (delete_all_subwindows): Take a window as argument and not a
677 (window_loop): Remove handling of GET_LRU_WINDOW and
679 (Fget_lru_window, Fget_largest_window): Move to window.el.
681 * window.h: Extern window_body_cols instead of
682 window_box_text_cols. delete_all_subwindows now takes a
683 Lisp_Object as argument.
685 * indent.c (compute_motion, Fcompute_motion): Use
686 window_body_cols instead of window_box_text_cols.
688 * frame.c (delete_frame): Call delete_all_subwindows with root
691 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
693 * fns.c (Fputhash): Document return value.
695 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
697 * image.c (gif_load): Implement gif89a spec "no disposal" method.
699 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
701 Cons<->int and similar integer overflow fixes (Bug#8794).
703 Check for overflow when converting integer to cons and back.
704 * charset.c (Fdefine_charset_internal, Fdecode_char):
705 Use cons_to_unsigned to catch overflow.
706 (Fencode_char): Use INTEGER_TO_CONS.
707 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
708 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
709 * data.c (long_to_cons, cons_to_long): Remove.
710 (cons_to_unsigned, cons_to_signed): New functions.
711 These signal an error for invalid or out-of-range values.
712 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
713 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
714 * font.c (Ffont_variation_glyphs):
715 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
716 * lisp.h: Include <intprops.h>.
717 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
718 (cons_to_signed, cons_to_unsigned): New decls.
719 (long_to_cons, cons_to_long): Remove decls.
720 * undo.c (record_first_change): Use INTEGER_TO_CONS.
721 (Fprimitive_undo): Use CONS_TO_INTEGER.
722 * xfns.c (Fx_window_property): Likewise.
723 * xselect.c: Include <limits.h>.
724 (x_own_selection, selection_data_to_lisp_data):
726 (x_handle_selection_request, x_handle_selection_clear)
727 (x_get_foreign_selection, Fx_disown_selection_internal)
728 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
729 (lisp_data_to_selection_data): Use cons_to_unsigned.
730 (x_fill_property_data): Use cons_to_signed.
731 Report values out of range.
733 Check for buffer and string overflow more precisely.
734 * buffer.h (BUF_BYTES_MAX): New macro.
735 * lisp.h (STRING_BYTES_MAX): New macro.
736 * alloc.c (Fmake_string):
737 * character.c (string_escape_byte8):
738 * coding.c (coding_alloc_by_realloc):
740 * editfns.c (Fformat):
742 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
743 since they may not be the same number.
744 * editfns.c (Finsert_char):
745 * fileio.c (Finsert_file_contents):
746 Likewise for BUF_BYTES_MAX.
748 * image.c: Use ptrdiff_t, not int, for sizes.
749 (slurp_file): Switch from int to ptrdiff_t.
751 (slurp_file): Check that file size fits in both size_t (for
752 malloc) and ptrdiff_t (for sanity and safety).
754 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
755 if b->modtime has its maximal value.
757 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
759 Don't assume time_t can fit into int.
760 * buffer.h (struct buffer.modtime): Now time_t, not int.
761 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
762 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
764 Minor fixes for signed vs unsigned integers.
765 * character.h (MAYBE_UNIFY_CHAR):
766 * charset.c (maybe_unify_char):
767 * keyboard.c (read_char, reorder_modifiers):
768 XINT -> XFASTINT, since the integer must be nonnegative.
769 * ftfont.c (ftfont_spec_pattern):
770 * keymap.c (access_keymap, silly_event_symbol_error):
771 XUINT -> XFASTINT, since the integer must be nonnegative.
772 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
773 since it makes no difference and we prefer signed.
774 * keyboard.c (record_char): Use XUINT when all the neighbors do.
775 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
778 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
780 * window.h (Fwindow_frame): Declare.
782 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
784 * alloc.c: Simplify handling of large-request failures (Bug#8800).
785 (SPARE_MEMORY): Always define.
786 (LARGE_REQUEST): Remove.
787 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
789 2011-06-06 Martin Rudalics <rudalics@gmx.at>
791 * lisp.h: Move EXFUNS for Fframe_root_window,
792 Fframe_first_window and Fset_frame_selected_window to window.h.
794 * window.h: Move EXFUNS for Fframe_root_window,
795 Fframe_first_window and Fset_frame_selected_window here from
798 * frame.c (Fwindow_frame, Fframe_first_window)
799 (Fframe_root_window, Fframe_selected_window)
800 (Fset_frame_selected_window): Move to window.c.
801 (Factive_minibuffer_window): Move to minibuf.c.
802 (Fother_visible_frames_p): New function.
804 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
806 * window.c (decode_window, decode_any_window): Move up in code.
807 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
808 (inhibit_frame_unsplittable): Remove unused variable.
809 (Fwindow_buffer): Move up and rewrite doc-string.
810 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
811 (Fwindow_prev): New functions.
812 (Fwindow_frame): Move here from frame.c. Accept any window as
814 (Fframe_root_window, Fframe_first_window)
815 (Fframe_selected_window): Move here from frame.c. Accept frame
816 or arbitrary window as argument. Update doc-strings.
817 (Fminibuffer_window): Move up in code.
818 (Fwindow_minibuffer_p): Move up in code and simplify.
819 (Fset_frame_selected_window): Move here from frame.c.
821 (Fselected_window, select_window, Fselect_window): Move up in
822 code. Minor doc-string fixes.
824 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
826 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
827 Do not assume that spare memory exists; that assumption is valid
828 only if SYSTEM_MALLOC.
829 (LARGE_REQUEST): New macro, so that the issue of large requests
830 is separated from the issue of spare memory.
832 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
834 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
837 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
839 * xfns.c (x_set_scroll_bar_default_width): Move declarations
842 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
844 * gtkutil.c (xg_get_default_scrollbar_width): New function.
846 * gtkutil.h: Declare xg_get_default_scrollbar_width.
848 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
849 min width by calling x_set_scroll_bar_default_width (Bug#8505).
851 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
853 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
855 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
857 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
858 (x_clipboard_manager_save): Add return value.
859 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
861 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
862 Obey Vx_select_enable_clipboard_manager. Catch errors in
863 x_clipboard_manager_save (Bug#8779).
864 (Vx_select_enable_clipboard_manager): New variable.
865 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
867 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
869 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
871 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
873 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
874 in the current matrix if keep_current_p is non-zero.
876 2011-06-04 Eli Zaretskii <eliz@gnu.org>
878 * bidi.c (bidi_level_of_next_char): Fix last change.
880 2011-06-03 Eli Zaretskii <eliz@gnu.org>
882 Support bidi reordering of text covered by display properties.
884 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
885 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
886 (bidi_cache_search, bidi_cache_iterator_state)
887 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
888 (bidi_level_of_next_char, bidi_move_to_visually_next):
889 Support character positions inside a run of characters covered by a
891 (bidi_paragraph_init, bidi_resolve_explicit_1)
892 (bidi_level_of_next_char): Call bidi_fetch_char and
893 bidi_fetch_char_advance instead of FETCH_CHAR and
895 (bidi_init_it): Initialize new members.
896 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
898 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
899 instead of using explicit *_CHAR codes.
900 (bidi_resolve_explicit, bidi_resolve_weak):
901 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
902 bidirectional text is supported only in multibyte buffers.
903 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
904 it to initialize the frame_window_p member of struct bidi_it.
905 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
906 (bidi_resolve_explicit, bidi_resolve_weak)
907 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
908 bidi_it->nchars is non-positive.
909 (bidi_level_of_next_char): Don't try to lookup the cache for the
910 next/previous character if nothing is cached there yet, or if we
911 were just reseat()'ed to a new position.
913 * xdisp.c (set_cursor_from_row): Set start and stop points
914 according to the row's direction when priming the loop that looks
915 for the glyph on which to display cursor.
916 (single_display_spec_intangible_p): Function deleted.
917 (display_prop_intangible_p): Reimplement to call
918 handle_display_spec instead of single_display_spec_intangible_p.
919 Accept 3 additional arguments needed by handle_display_spec.
920 This fixes incorrect cursor motion across display property with complex
921 values: lists, `(when COND...)' forms, etc.
922 (single_display_spec_string_p): Support property values that are
923 lists with the argument STRING its top-level element.
924 (display_prop_string_p): Fix the condition for processing a
925 property that is a list to be consistent with handle_display_spec.
926 (handle_display_spec): New function, refactored from the
927 last portion of handle_display_prop.
928 (compute_display_string_pos): Accept additional argument
929 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
930 value of a `display' property is a "replacing spec".
931 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
932 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
933 the display property, but just return a value indicating whether
934 the display property will replace the characters it covers.
935 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
936 frame_window_p members of struct bidi_it.
937 (compute_display_string_pos, compute_display_string_end):
939 (push_it): Accept second argument POSITION, where pop_it should
940 jump to continue iteration.
941 (reseat_1): Initialize bidi_it.disp_pos.
943 * keyboard.c (adjust_point_for_property): Adjust the call to
944 display_prop_intangible_p to its new signature.
946 * dispextern.h (struct bidi_it): New member frame_window_p.
947 (bidi_init_it): Update prototypes.
948 (display_prop_intangible_p): Update prototype.
949 (compute_display_string_pos, compute_display_string_end):
951 (struct bidi_it): New members nchars and disp_pos. ch_len is now
954 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
956 Malloc failure behavior now depends on size of allocation.
957 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
958 * lisp.h: Change signatures accordingly.
959 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
960 All callers changed. (Bug#8762)
962 * gnutls.c: Use Emacs's memory allocators.
963 Without this change, the gnutls library would invoke malloc etc.
964 directly, which causes problems on non-SYNC_INPUT hosts, and which
965 runs afoul of improving memory_full behavior. (Bug#8761)
966 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
967 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
968 xfree instead of the default malloc, realloc, free.
969 (Fgnutls_boot): No need to check for memory allocation failure,
970 since xmalloc does that for us.
972 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
973 * category.c (hash_get_category_set):
974 * ccl.c (ccl_driver):
975 * charset.c (Fdefine_charset_internal):
976 * charset.h (struct charset.hash_index):
977 * composite.c (get_composition_id, gstring_lookup_cache)
978 (composition_gstring_put_cache):
979 * composite.h (struct composition.hash_index):
980 * dispextern.h (struct image.hash):
981 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
982 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
983 (hashfn_equal, hashfn_user_defined, make_hash_table)
984 (maybe_resize_hash_table, hash_lookup, hash_put)
985 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
986 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
987 (Fsxhash, Fgethash, Fputhash, Fmaphash):
988 * image.c (make_image, search_image_cache, lookup_image)
989 (xpm_put_color_table_h):
990 * lisp.h (struct Lisp_Hash_Table):
991 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
992 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
993 for hashes and hash indexes, instead of 'unsigned' and 'int'.
994 * alloc.c (allocate_vectorlike):
995 Check for overflow in vector size calculations.
996 * ccl.c (ccl_driver):
997 Check for overflow when converting EMACS_INT to int.
998 * fns.c, image.c: Remove unnecessary static decls that would otherwise
999 need to be updated by these changes.
1000 * fns.c (make_hash_table, maybe_resize_hash_table):
1001 Check for integer overflow with large hash tables.
1002 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1003 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1004 (SXHASH_REDUCE): New macro.
1005 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1006 Use it instead of discarding useful hash info with large hash values.
1007 (sxhash_float): New function.
1008 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1009 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1010 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1011 Rewrite to use FIXNUM_BITS, as this simplifies things.
1012 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1013 Adjust signatures to match updated version of code.
1014 (consing_since_gc): Now EMACS_INT, since a single hash table can
1015 use more than INT_MAX bytes.
1017 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1019 Make it possible to build with GCC-4.6+ -O2 -flto.
1021 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1023 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1025 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1026 Call minibuffer-inactive-mode.
1028 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1030 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1031 Update dependencies.
1033 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1035 * data.c (init_data): Remove code for UTS, this system is not
1038 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1040 Don't force ./temacs to start in terminal mode.
1042 * frame.c (make_initial_frame): Initialize faces in all cases, not
1043 only when CANNOT_DUMP is defined.
1044 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1046 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1048 * dispnew.c (add_window_display_history): Use const for the string
1049 pointer. Remove declaration, not needed.
1051 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1053 Use 'inline', not 'INLINE'.
1054 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1055 * alloc.c, fontset.c (INLINE): Remove.
1056 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1057 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1058 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1059 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1060 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1062 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1064 Make it possible to run ./temacs.
1066 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1067 syms_of_callproc does the same thing. Remove test for
1068 "initialized", do it in the caller.
1069 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1071 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1073 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1074 (read_minibuf): Use get_minibuffer.
1075 (syms_of_minibuf): Use DEFSYM.
1076 (Qmetadata): New var.
1077 * data.c (Qbuffer): Don't make it static.
1078 (syms_of_data): Use DEFSYM.
1080 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1082 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1083 (CCL_CODE_MIN): New macro.
1085 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1087 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1089 * eval.c (Qdebug): Now static.
1090 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1091 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1092 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1094 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1096 * image.c: Various fixes to ImageMagick code comments.
1097 (Fimagemagick_types): Doc fix.
1099 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1101 Minor fixes prompted by GCC 4.6.0 warnings.
1103 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1105 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1106 (x_clipboard_manager_save_all): Move extern decl to ...
1107 * xterm.h: ... here, so that it can be checked for consistency.
1109 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1111 * xselect.c (x_clipboard_manager_save_frame)
1112 (x_clipboard_manager_save_all): New functions.
1113 (Fx_clipboard_manager_save): Lisp function deleted.
1115 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1116 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1118 * xterm.h: Update prototype.
1120 2011-05-28 William Xu <william.xwl@gmail.com>
1122 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1125 2011-05-28 Jim Meyering <meyering@redhat.com>
1127 Avoid a sign-extension bug in crypto_hash_function.
1128 * fns.c (to_uchar): Define.
1129 (crypto_hash_function): Use it to convert some newly-signed
1130 variables to unsigned, to avoid sign-extension bugs. For example,
1131 without this change, (md5 "truc") would evaluate to
1132 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1133 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1134 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1136 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1138 Integer overflow fixes.
1140 * dbusbind.c: Serial number integer overflow fixes.
1141 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1142 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1143 to hold a serial number that is too large for a fixnum.
1144 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1145 Check for serial numbers out of range. Decode any serial number
1146 that was so large that it became a float. (Bug#8722)
1148 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1149 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1150 Use XFASTINT rather than XUINT when numbers are nonnegative.
1151 (xd_append_arg, Fdbus_method_return_internal):
1152 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1153 arguments, check that Lisp number is nonnegative, rather than
1154 silently wrapping negative numbers around. (Bug#8722)
1155 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1158 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1160 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1162 ccl: add integer overflow checks
1163 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1164 (IN_INT_RANGE): New macros.
1165 (ccl_driver): Use them to check for integer overflow when
1166 decoding a CCL program. Many of the new checks are whether XINT (x)
1167 fits in int; it doesn't always, on 64-bit hosts. The new version
1168 doesn't catch all possible integer overflows, but it's an
1169 improvement. (Bug#8719)
1171 * alloc.c (make_event_array): Use XINT, not XUINT.
1172 There's no need for unsigned here.
1174 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1175 This follows up to the 2011-05-06 change that substituted uintptr_t
1176 for EMACS_INT. This case wasn't caught back then.
1178 Rework Fformat to avoid integer overflow issues.
1179 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1180 now (part of C89). Include <verify.h>.
1181 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1182 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1183 (Fformat): Avoid the prepass trying to compute sizes; it was only
1184 approximate and thus did not catch overflow reliably. Instead, walk
1185 through the format just once, formatting and computing sizes as we go,
1186 checking for integer overflow at every step, and allocating a larger
1187 buffer as needed. Keep track separately whether the format is
1188 multibyte. Keep only the most-recently calculated precision, rather
1189 than them all. Record whether each argument has been converted to
1190 string. Use EMACS_INT, not int, for byte and char and arg counts.
1191 Support field widths and precisions larger than INT_MAX. Avoid
1192 sprintf's undefined behavior with conversion specifications such as %#d
1193 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1194 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1195 formatting out-of-range floating point numbers with int
1198 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1200 * data.c: Avoid integer truncation in expressions involving floats.
1201 * data.c: Include <intprops.h>.
1202 (arith_driver): When there's an integer overflow in an expression
1203 involving floating point, convert the integers to floating point
1204 so that the resulting value does not suffer from catastrophic
1205 integer truncation. For example, on a 64-bit host (* 4
1206 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1207 Do not rely on undefined behavior after integer overflow.
1209 merge count_size_as_multibyte, parse_str_to_multibyte
1210 * character.c, character.h (count_size_as_multibyte):
1211 Rename from parse_str_to_multibyte; all uses changed.
1212 Check for integer overflow.
1213 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1214 since it's now a duplicate of the other. This is more of
1215 a character than a buffer op, so better that it's in character.c.
1216 * fns.c, print.c: Adjust to above changes.
1218 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1220 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1222 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1224 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1225 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1226 (x_clipboard_manager_save): Now static.
1227 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1229 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1230 (crypto_hash_function): Now static.
1231 Fix pointer signedness problems. Avoid unnecessary initializations.
1233 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1235 * termhooks.h (Vselection_alist): Make it terminal-local.
1237 * terminal.c (create_terminal): Initialize it.
1239 * xselect.c: Support for clipboard managers.
1240 (Vselection_alist): Move to termhooks.h as terminal-local var.
1241 (LOCAL_SELECTION): New macro.
1242 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1243 (symbol_to_x_atom): Remove gratuitous arg.
1244 (x_handle_selection_request, lisp_data_to_selection_data)
1245 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1246 (x_own_selection, x_get_local_selection, x_convert_selection):
1247 New arg, specifying work frame. Use terminal-local Vselection_alist.
1248 (some_frame_on_display): Delete unused function.
1249 (Fx_own_selection_internal, Fx_get_selection_internal)
1250 (Fx_disown_selection_internal, Fx_selection_owner_p)
1251 (Fx_selection_exists_p): New optional frame arg.
1252 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1253 (x_handle_selection_clear): Don't treat other terminals with the
1254 same keyboard specially. Use the terminal-local Vselection_alist.
1255 (x_clear_frame_selections): Use Frun_hook_with_args.
1257 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1259 * xterm.h: Add support for those atoms.
1261 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1263 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1264 (converted_selections, conversion_fail_tag): New global variables.
1265 (x_selection_request_lisp_error): Free the above.
1266 (x_get_local_selection): Remove unnecessary code.
1267 (x_reply_selection_request): Args changed; handle arbitrary array
1268 of converted selections stored in converted_selections.
1269 Separate the XChangeProperty and SelectionNotify steps.
1270 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1271 (x_convert_selection): New function.
1272 (x_handle_selection_event): Simplify.
1273 (x_get_foreign_selection): Don't ignore incoming requests while
1274 waiting for an answer; this will fail when we implement
1275 SAVE_TARGETS, and seems unnecessary anyway.
1276 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1277 (Vx_sent_selection_functions): Doc fix.
1279 2011-05-26 Leo Liu <sdl.web@gmail.com>
1281 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1283 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1285 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1287 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1288 for fringe update if it has periodic bitmap.
1289 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1290 and fringe_bitmap_periodic_p.
1292 * fringe.c (get_fringe_bitmap_data): New function.
1293 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1294 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1295 row. Mark glyph row for fringe update if periodicity changed.
1297 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1298 for fringe update unless it has periodic bitmap.
1300 2011-05-25 Kenichi Handa <handa@m17n.org>
1302 * xdisp.c (get_next_display_element): Set correct it->face_id for
1303 a static composition.
1305 2011-05-24 Leo Liu <sdl.web@gmail.com>
1308 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1310 * fns.c (crypto_hash_function, Fsha1): New function.
1311 (Fmd5): Use crypto_hash_function.
1312 (syms_of_fns): Add Ssha1.
1314 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1316 * gnutls.c: Remove unused macros.
1317 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1318 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1319 Remove macros that are defined and never used.
1320 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1322 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1324 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1325 (Fx_get_selection_internal): Minor cleanup.
1326 (Fx_own_selection_internal): Rename arguments for consistency with
1329 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1331 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1333 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1335 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1337 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1339 * dispnew.c (scrolling_window): Don't exclude the case that the
1340 last enabled row in the desired matrix touches the bottom boundary.
1342 2011-05-21 Glenn Morris <rgm@gnu.org>
1344 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1345 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1346 and add some more files.
1348 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1350 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1351 report_file_error introduced by the change from 2011-05-07.
1353 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1355 * systime.h (Time): Define only if emacs is defined.
1356 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1357 where the include path doesn't have X11/X.h by default. See
1358 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1360 2011-05-20 Kenichi Handa <handa@m17n.org>
1362 * composite.c (find_automatic_composition): Fix previous change.
1364 2011-05-20 Glenn Morris <rgm@gnu.org>
1366 * lisp.mk: New file, split from Makefile.in.
1367 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1368 (shortlisp): Remove.
1369 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1371 2011-05-19 Glenn Morris <rgm@gnu.org>
1373 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1374 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1375 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1376 (lisp): Set the order to that of loadup.el.
1377 (shortlisp): Make it a copy of $lisp.
1378 (SOME_MACHINE_LISP): Remove.
1379 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1380 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1382 2011-05-18 Kenichi Handa <handa@m17n.org>
1384 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1385 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1386 (find_automatic_composition): Mostly rewrite for efficiency.
1388 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1390 * makefile.w32-in: Update dependencies.
1392 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1394 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1395 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1397 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1399 Fix some integer overflow issues, such as string length overflow.
1401 * insdel.c (count_size_as_multibyte): Check for string overflow.
1403 * character.c (lisp_string_width): Check for string overflow.
1404 Use EMACS_INT, not int, for string indexes and lengths; in
1405 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1406 the resulting string length overflows an EMACS_INT; instead,
1407 report a string overflow if no precision given. When checking for
1408 precision exhaustion, use a check that cannot possibly have
1409 integer overflow. (Bug#8675)
1410 * character.h (lisp_string_width): Adjust to new signature.
1412 * alloc.c (string_overflow): New function.
1413 (Fmake_string): Use it. This doesn't change behavior, but saves
1414 a few bytes and will simplify future changes.
1415 * character.c (string_escape_byte8): Likewise.
1416 * lisp.h (string_overflow): New decl.
1418 Fixups, following up to the user-interface timestamp change.
1419 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1420 for UI timestamps, instead of unsigned long.
1421 * msdos.c (mouse_get_pos): Likewise.
1422 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1423 * w32gui.h (Time): Define by including "systime.h" rather than by
1424 declaring it ourselves. (Bug#8664)
1426 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1427 * image.c (clear_image_cache): Likewise.
1429 * term.c (term_mouse_position): Don't assume time_t wraparound.
1431 Be more systematic about user-interface timestamps.
1432 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1433 and sometimes 'EMACS_UINT', to represent these timestamps.
1434 This change causes it to use 'Time' uniformly, as that's what X uses.
1435 This makes the code easier to follow, and makes it easier to catch
1436 integer overflow bugs such as Bug#8664.
1437 * frame.c (Fmouse_position, Fmouse_pixel_position):
1438 Use Time, not unsigned long, for user-interface timestamps.
1439 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1440 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1441 * keyboard.h (last_event_timestamp): Likewise.
1442 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1443 * menu.h (xmenu_show): Likewise.
1444 * term.c (term_mouse_position): Likewise.
1445 * termhooks.h (struct input_event.timestamp): Likewise.
1446 (struct terminal.mouse_position_hook): Likewise.
1447 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1448 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1449 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1450 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1452 * menu.h, termhooks.h: Include "systime.h", for Time.
1454 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1455 Don't assume that the difference between two unsigned long values
1456 can fit into an integer. At this point, we know button_down_time
1457 <= event->timestamp, so the difference must be nonnegative, so
1458 there's no need to cast the result if double-click-time is
1459 nonnegative, as it should be; check that it's nonnegative, just in
1460 case. This bug is triggered when events are more than 2**31 ms
1461 apart (about 25 days). (Bug#8664)
1463 * xselect.c (last_event_timestamp): Remove duplicate decl.
1464 (x_own_selection): Remove needless cast to unsigned long.
1466 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1467 that always fit in int. Use a sentinel instead of a counter, to
1468 avoid a temp and to allay GCC's concerns about possible int overflow.
1469 * frame.h (struct frame): Use int for menu_bar_items_used
1470 instead of EMACS_INT, since it always fits in int.
1472 * menu.c (grow_menu_items): Check for int overflow.
1474 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1476 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1477 Before, the code was not consistent. These values cannot exceed
1478 2**31 - 1 so there's no need to make them unsigned.
1479 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1480 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1481 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1483 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1485 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1486 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1487 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1488 presumably because the widths might not match.
1490 * window.c (size_window): Avoid needless test at loop start.
1492 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1494 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1496 2011-05-12 Drew Adams <drew.adams@oracle.com>
1498 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1500 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1502 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1503 `width' to `bar_area_x' and `bar_area_width', respectively.
1504 (x_scroll_run): Take account of fringe background extension.
1506 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1507 Rename local vars `left' and `width' to `bar_area_x' and
1508 `bar_area_width', respectively.
1509 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1510 background extension.
1512 2011-05-10 Jim Meyering <meyering@redhat.com>
1514 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1516 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1518 * image.c (Finit_image_library): Return t for built-in image types,
1519 like pbm and xbm. (Bug#8640)
1521 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1523 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1525 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1527 * w32console.c (Fset_screen_color): Doc fix.
1528 (Fget_screen_color): New function.
1529 (syms_of_ntterm): Defsubr it.
1531 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1532 unlink the temporary file if Fcall_process didn't create it in the
1534 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1535 child process will be redirected to a file specified with `:file'.
1536 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1537 cue to call_process_cleanup not to close that handle.
1539 2011-05-07 Ben Key <bkey76@gmail.com>
1541 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1542 one of two shell specific rules, either bootstrap-temacs-CMD or
1543 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1544 to the previous implementation of the bootstrap-temacs rule.
1545 The bootstrap-temacs-CMD rule is similar to the previous
1546 implementation of the bootstrap-temacs rule except that it
1547 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1550 These changes, along with some changes to nt/configure.bat,
1551 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1552 earlier fix to add support for --cflags and --ldflags options
1553 that include quotes so that it works whether make uses cmd or
1556 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1558 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1559 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1561 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1562 a string. Handle both cases.
1563 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1564 (Fdbus_register_method): Use Qinvalid_function.
1566 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1568 * makefile.w32-in: Update dependencies.
1569 (LISP_H): Add inttypes.h and stdin.h.
1570 (PROCESS_H): Add unistd.h.
1572 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1574 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1575 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1577 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1579 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1581 * term.c (vfatal): Remove stray call to va_end.
1582 It's not needed and the C Standard doesn't allow it here anyway.
1584 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1585 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1587 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1590 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1592 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1594 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1596 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1598 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1600 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1601 * charset.c (Fdefine_charset_internal): Don't initialize
1602 charset.code_space[15]. The value was garbage, on hosts with
1603 32-bit int (Bug#8600).
1605 * lread.c (read_integer): Be more consistent with string-to-number.
1606 Use string_to_number to do the actual conversion; this avoids
1607 rounding errors and fixes some other screwups. Without this fix,
1608 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1609 (digit_to_number): Move earlier, for benefit of read_integer.
1610 Return -1 if the digit is out of range for the base, -2 if it is
1611 not a digit in any supported base. (Bug#8602)
1613 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1615 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1616 to match comment at start of function. This also removes a
1617 GCC warning about overflow in a 32+64-bit port.
1619 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1621 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1622 Reported by Stefan Monnier in
1623 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1624 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1625 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1627 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1628 (EMACS_UINTPTR): Likewise, with uintptr_t.
1630 * lisp.h: Prefer 64-bit EMACS_INT if available.
1631 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1632 on 32-bit hosts that have 64-bit int, so that they can access
1634 However, temporarily disable this change unless the temporary
1635 symbol WIDE_EMACS_INT is defined.
1637 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1639 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1640 This removes an assumption that EMACS_INT and long are the same
1641 width as pointers. The assumption is true for Emacs porting targets
1642 now, but we want to make other targets possible.
1643 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1644 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1645 In the rest of the code, change types of integers that hold casted
1646 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1647 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1648 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1649 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1650 No need to cast type when ORing.
1651 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1652 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1653 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1654 assume EMACS_INT is the same width as char *.
1655 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1656 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1657 Remove no-longer-needed casts.
1658 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1659 (xg_tool_bar_help_callback, xg_make_tool_item):
1660 Use EMACS_INTPTR to hold an integer
1661 that will be cast to void *; this can avoid a GCC warning
1662 if EMACS_INT is not the same width as void *.
1663 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1664 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1665 (current_message_1, set_message_1):
1666 Use a local to convert to proper width without a cast.
1667 * xmenu.c (dialog_selection_callback): Likewise.
1669 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1670 Also, don't assume VALBITS / RAND_BITS is less than 5,
1671 and don't rely on undefined behavior when shifting a 1 left into
1673 * lisp.h (get_random): Change signature to match.
1675 * lread.c (hash_string): Use size_t, not int, for hash computation.
1676 Normally we prefer signed values; but hashing is special, because
1677 it's better to use unsigned division on hash table sizes so that
1678 the remainder is nonnegative. Also, size_t is the natural width
1679 for hashing into memory. The previous code used 'int', which doesn't
1680 retain enough info to hash well into very large tables.
1681 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1683 * dbusbind.c: Don't possibly lose pointer info when converting.
1684 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1685 Use XPNTR rather than XHASH, so that the high-order bits of
1686 the pointer aren't lost when converting through void *.
1688 * eval.c (Fautoload): Don't double-shift a pointer.
1690 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1692 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1694 * gnutls.c (DEF_GNUTLS_FN):
1695 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1697 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1699 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1702 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1704 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1705 New version that can reserve upto 2GB of heap space.
1707 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1709 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1711 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1713 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1714 `gnutls_certificate_set_x509_key_file'.
1716 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1718 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1719 Update dependencies.
1721 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1723 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1724 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1725 Remove unused parameter `fildes'.
1726 * process.c (read_process_output, send_process): Don't pass it.
1728 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1730 Fix previous change: the library cache is defined in w32.c.
1731 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1732 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1734 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1736 Implement dynamic loading of GnuTLS on Windows.
1738 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1739 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1740 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1743 * gnutls.c (Qgnutls_dll): Define.
1744 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1745 (gnutls_*): Declare function pointers.
1746 (init_gnutls_functions): New function to initialize function pointers.
1747 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1748 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1749 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1750 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1751 (emacs_gnutls_write, emacs_gnutls_read)
1752 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1753 (Fgnutls_available_p): New function.
1754 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1755 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1756 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1758 * image.c: Include w32.h.
1759 (Vimage_type_cache): Delete.
1760 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1761 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1762 (w32_delayed_load): Move to w32.c.
1764 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1766 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1767 (w32_delayed_load): Move from image.c. When loading a library, record
1768 its filename in the :loaded-from property of the library id.
1769 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1770 Initialize and staticpro them.
1771 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1773 * process.c: Include lisp.h before w32.h, not after.
1774 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1775 instead of gnutls_record_check_pending.
1777 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1779 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1781 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1782 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1785 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1787 * xterm.c (x_set_frame_alpha): Do not set property on anything
1788 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1790 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1792 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1794 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1796 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1797 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1798 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1799 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1800 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1801 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1802 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1803 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1804 (Qgnutls_bootprop_callbacks_verify): Make static.
1806 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1808 * callproc.c: Indentation fixup.
1810 * sysdep.c (wait_for_termination_1): Make static.
1811 (wait_for_termination, interruptible_wait_for_termination):
1812 Move after wait_for_termination_1.
1814 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1816 * sysdep.c (interruptible_wait_for_termination): New function
1817 which is like wait_for_termination, but allows keyboard
1820 * callproc.c (Fcall_process): Add (:file "file") as an option for
1822 (Fcall_process_region): Ditto.
1824 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1826 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1827 rather than `XVECTOR (FOO)->size'.
1829 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1830 inttypes.h, as a gnulib replacement is used if it not available in
1833 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1835 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1836 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1837 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1839 * coding.c (coding_alloc_by_realloc): Error out if destination
1840 will grow beyond MOST_POSITIVE_FIXNUM.
1841 (decode_coding_emacs_mule): Abort if there isn't enough place in
1842 charbuf for the composition carryover bytes. Reserve an extra
1843 space for up to 2 characters produced in a loop.
1844 (decode_coding_iso_2022): Abort if there isn't enough place in
1845 charbuf for the composition carryover bytes.
1847 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1849 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1850 aborting when %lld or %lll format is passed.
1851 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1852 %llo or %llx format is passed. (Bug#8545)
1854 * window.c (window_scroll_line_based): Use a marker instead of
1855 simple variables to record original value of point. (Bug#7952)
1857 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1858 produced by %s or %c overflows available buffer space. (Bug#8545)
1860 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1862 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1863 (SIZE_MAX): Move defn after all includes, as they might #define it.
1865 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1867 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1869 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1871 * keyboard.c (Qdelayed_warnings_hook): Define.
1872 (command_loop_1): Run `delayed-warnings-hook'
1873 if Vdelayed_warnings_list is non-nil.
1874 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1875 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1877 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1879 * doprnt.c (doprnt): Don't return value smaller than the buffer
1880 size if the message was truncated. (Bug#8545).
1882 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1884 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1885 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1887 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1889 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1891 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1893 * makefile.w32-in: Update dependencies.
1895 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1897 Improve `doprnt' and its usage. (Bug#8545)
1898 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1899 `format_end'. Remove support for %l as a conversion specifier.
1900 Don't use xrealloc. Improve diagnostics when the %l size modifier
1901 is used. Update the commentary.
1903 * eval.c (verror): Simplify calculation of size_t.
1905 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1908 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1910 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1913 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1915 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1916 This makes this file independent of the recent pseudovector change.
1918 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1920 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1922 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1923 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1924 Remove unused local.
1925 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1927 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1928 GCC 4.6.0 optimizes based on type-based alias analysis.
1929 For example, if b is of type struct buffer * and v of type struct
1930 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1931 != &v->size, and therefore "v->size = 1; b->size = 2; return
1932 v->size;" must therefore return 1. This assumption is incorrect
1933 for Emacs, since it type-puns struct Lisp_Vector * with many other
1934 types. To fix this problem, this patch adds a new type struct
1935 vectorlike_header that documents the constraints on layout of vectors
1936 and pseudovectors, and helps optimizing compilers not get fooled
1937 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1938 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1939 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1941 (XSETPVECTYPE): Rewrite in terms of new macro.
1942 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1943 This is a bit clearer, and further avoids the possibility of
1944 undesirable aliasing.
1945 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1946 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1947 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1948 since Lisp_Subr is a special case (no "next" field).
1949 (ASIZE): Now uses header.size rather than size.
1950 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1951 to avoid the hassle of writing XVECTOR (foo)->header.size.
1952 (struct vectorlike_header): New type.
1953 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1954 object, to help avoid aliasing.
1955 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1956 (SUBRP): Likewise, since Lisp_Subr is a special case.
1957 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1958 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1959 (struct Lisp_Hash_Table): Combine first two members into a single
1960 struct vectorlike_header member. All uses of "size" and "next" members
1961 changed to be "header.size" and "header.next".
1962 * buffer.h (struct buffer): Likewise.
1963 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1964 * frame.h (struct frame): Likewise.
1965 * process.h (struct Lisp_Process): Likewise.
1966 * termhooks.h (struct terminal): Likewise.
1967 * window.c (struct save_window_data, struct saved_window): Likewise.
1968 * window.h (struct window): Likewise.
1969 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1970 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1971 * buffer.c (init_buffer_once): Likewise.
1972 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1974 * process.c (Fformat_network_address): Use local var for size,
1977 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1979 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1980 * data.c (atof): Remove decl; no longer used or needed.
1981 (digit_to_number): Move to lread.c.
1982 (Fstring_to_number): Use new string_to_number function, to be
1983 consistent with how the Lisp reader treats infinities and NaNs.
1984 Do not assume that floating-point numbers represent EMACS_INT
1985 without losing information; this is not true on most 64-bit hosts.
1986 Avoid double-rounding errors, by insisting on integers when
1987 parsing non-base-10 numbers, as the documentation specifies.
1988 * lisp.h (string_to_number): New decl, replacing ...
1989 (isfloat_string): Remove.
1990 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1991 (read1): Do not accept +. and -. as integers; this
1992 appears to have been a coding error. Similarly, do not accept
1993 strings like +-1e0 as floating point numbers. Do not report
1994 overflow for integer overflows unless the base is not 10 which
1995 means we have no simple and reliable way to continue.
1996 Break out the floating-point parsing into a new
1997 function string_to_number, so that Fstring_to_number parses
1998 floating point numbers consistently with the Lisp reader.
1999 (digit_to_number): Move here from data.c. Make it static inline.
2000 (E_CHAR, EXP_INT): Remove, replacing with ...
2001 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2002 (string_to_number): New function, replacing isfloat_string.
2003 This function checks for valid syntax and produces the resulting
2004 Lisp float number too. Rework it so that string-to-number
2005 no longer mishandles examples like "1.0e+". Use strtoumax,
2006 so that overflow for non-base-10 numbers is reported only when
2007 there's no portable and simple way to convert to floating point.
2009 * textprop.c (set_text_properties_1): Rewrite for clarity,
2010 and to avoid GCC warning about integer overflow.
2012 * intervals.h (struct interval): Use EMACS_INT for members
2013 where EMACS_UINT might cause problems. See
2014 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2015 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2016 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2018 (offset_intervals): Tell GCC not to worry about length overflow
2019 when negating a negative length.
2021 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2022 (overrun_check_free): Likewise.
2024 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2025 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2028 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2029 (gnutls_make_error): Rename local to avoid shadowing.
2030 (gnutls_emacs_global_deinit): ifdef out; not used.
2031 (Fgnutls_boot): Use const for pointer to readonly storage.
2032 Comment out unused local. Fix pointer signedness problems.
2034 * lread.c (openp): Don't stuff size_t into an 'int'.
2035 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2036 about possible signed overflow.
2038 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2039 (GDK_KEY_g): Don't define if already defined.
2040 (xg_prepare_tooltip): Avoid pointer signedness problem.
2041 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2043 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2044 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2046 * xfns.c (Fx_window_property): Simplify a bit,
2047 to make a bit faster and to avoid GCC 4.6.0 warning.
2048 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2050 * fns.c (internal_equal): Don't assume size_t fits in int.
2052 * alloc.c (compact_small_strings): Tighten assertion a little.
2054 Replace pEd with more-general pI, and fix some printf arg casts.
2055 * lisp.h (pI): New macro, generalizing old pEd macro to other
2056 conversion specifiers. For example, use "...%"pI"d..." rather
2057 than "...%"pEd"...".
2058 (pEd): Remove. All uses replaced with similar uses of pI.
2059 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2060 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2061 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2062 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2063 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2064 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2065 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2067 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2068 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2069 * print.c (safe_debug_print, print_object): Likewise.
2070 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2072 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2073 avoiding the 0 flag, which is not portable.
2074 * process.c (Fmake_network_process): Use pI to avoid cast.
2075 * region-cache.c (pp_cache): Likewise.
2076 * xdisp.c (decode_mode_spec): Likewise.
2077 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2078 behavior on 64-bit hosts with printf arg.
2079 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2080 (x_stop_queuing_selection_requests): Likewise.
2081 (x_get_window_property): Don't truncate byte count to an 'int'
2084 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2085 here, since it parses constructs like leading '-' and spaces,
2086 which are not wanted; and it overflows with large numbers.
2087 Instead, simply match F[0-9]+, which is what is wanted anyway.
2089 * alloc.c: Remove unportable assumptions about struct layout.
2090 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2091 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2092 (allocate_vectorlike, make_pure_vector): Use the new macros,
2093 plus offsetof, to remove unportable assumptions about struct layout.
2094 These assumptions hold on all porting targets that I know of, but
2095 they are not guaranteed, they're easy to remove, and removing them
2096 makes further changes easier.
2098 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2099 This doesn't fix a bug but makes the code clearer.
2100 (string_overrun_cookie): Now const. Use initializers that
2101 don't formally overflow signed char, to avoid warnings.
2102 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2103 can cause Emacs to crash when string overrun checking is enabled.
2104 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2105 multiple of sizeof (EMACS_INT); it need not be, if
2106 alignof(EMACS_INT) < sizeof (EMACS_INT).
2107 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2109 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2111 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2113 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2115 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2116 supposed to be handshaking. (Bug#8556)
2117 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2119 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2121 * lisp.h (Qdebug): List symbol.
2122 * eval.c (Qdebug): Restore global linkage.
2123 * keyboard.c (debug-on-event): New variable.
2124 (handle_user_signal): Break into debugger when debug-on-event
2125 matches the current signal symbol.
2127 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2129 * alloc.c (check_sblock, check_string_bytes)
2130 (check_string_free_list): Convert to standard C.
2132 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2134 * w32.c (emacs_gnutls_push): Fix typo.
2136 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2138 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2139 "cast to pointer from integer of different size".
2141 Improve doprnt and its use in verror. (Bug#8545)
2142 * doprnt.c (doprnt): Document the set of format control sequences
2143 supported by the function. Use SAFE_ALLOCA instead of always
2146 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2147 is one byte too soon. Don't use xrealloc; instead xfree and
2150 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2152 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2155 * gnutls.c: Renamed global_initialized to
2156 gnutls_global_initialized. Added internals for the
2157 :verify-hostname-error, :verify-error, and :verify-flags
2158 parameters of `gnutls-boot' and documented those parameters in the
2159 docstring. Start callback support.
2160 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2161 unless a fatal error occured. Call gnutls_alert_send_appropriate
2162 on error. Return error code.
2163 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2164 (emacs_gnutls_read): Likewise.
2165 (Fgnutls_boot): Return handshake error code.
2166 (emacs_gnutls_handle_error): New function.
2167 (wsaerror_to_errno): Likewise.
2169 * w32.h (emacs_gnutls_pull): Add prototype.
2170 (emacs_gnutls_push): Likewise.
2172 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2173 (emacs_gnutls_push): Likewise.
2175 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2177 * process.c (wait_reading_process_output): Check if GnuTLS
2178 buffered some data internally if no FDs are set for TLS
2181 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2182 (LIBS): Link to USER_LIBS.
2183 ($(BLD)/gnutls.$(0)): New target.
2185 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2187 * xdisp.c (handle_single_display_spec): Rename the
2188 display_replaced_before_p argument into display_replaced_p, to
2189 make it consistent with the commentary. Fix typos in the
2192 * textprop.c (syms_of_textprop): Remove dead code.
2193 (copy_text_properties): Delete obsolete commentary about an
2194 interface that was deleted long ago. Fix typos in the description
2197 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2198 to changes in oldXMenu/XMenu.h from 2011-04-16.
2199 <menu_help_message, prev_menu_help_message>: Constify.
2200 (IT_menu_make_room): menu->help_text is now `const char **';
2203 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2204 to changes in oldXMenu/XMenu.h from 2011-04-16.
2205 (struct XMenu): Declare `help_text' `const char **'.
2207 * xfaces.c <Qunspecified>: Make extern again.
2209 * syntax.c: Include sys/types.h before including regex.h, as
2212 * doc.c (get_doc_string): Improve the format passed to `error'.
2214 * doprnt.c (doprnt): Improve commentary.
2216 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2218 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2221 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2222 changes in globals.h immediately force recompilation.
2223 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2224 $(CURDIR)/s/ms-w32.h.
2225 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2227 * character.c (Fchar_direction): Function deleted.
2228 (syms_of_character): Don't defsubr it.
2229 <char-direction-table>: Deleted.
2231 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2233 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2234 * doprnt.c: Include limits.h.
2235 (SIZE_MAX): New macro.
2236 (doprnt): Return a size_t value. 2nd arg is now size_t.
2237 Many local variables are now size_t instead of int or unsigned.
2238 Improve overflow protection. Support `l' modifier for integer
2239 conversions. Support %l conversion. Don't assume an EMACS_INT
2240 argument for integer conversions and for %c.
2242 * lisp.h (doprnt): Restore prototype.
2244 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2247 * Makefile.in (base_obj): Add back doprnt.o.
2249 * deps.mk (doprnt.o): Add back prerequisites.
2250 (callint.o): Depend on character.h.
2252 * eval.c (internal_lisp_condition_case): Include the handler
2253 representation in the error message.
2254 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2255 when breaking from the loop.
2257 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2259 * callint.c (Fcall_interactively): When displaying error message
2260 about invalid control letter, pass the character's codepoint, not
2261 a pointer to its multibyte form. Improve display of the character
2262 in octal and display also its hex code.
2264 * character.c (char_string): Use %x to display the (unsigned)
2265 codepoint of an invalid character, to avoid displaying a bogus
2268 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2269 `error', not SYMBOL_NAME itself.
2271 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2272 character arguments to `error'.
2274 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2275 to `error' in error message about FINAL_CHAR argument. Make sure
2276 FINAL_CHAR is a character, and use %c when it is passed as
2277 argument to `error'.
2279 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2281 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2283 * w32.c: Include <time.h>.
2284 (sys_localtime): New function.
2286 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2288 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2290 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2292 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2294 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2297 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2299 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2300 gl_state.e_property when gl_state.object is Qt.
2302 * insdel.c (make_gap_larger): Remove limitation of buffer size
2305 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2307 * xdisp.c (lookup_glyphless_char_display)
2308 (produce_glyphless_glyph): Handle cons cell entry in
2309 glyphless-char-display.
2310 (Vglyphless_char_display): Document it.
2312 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2313 glyphless-char-display.
2315 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2317 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2319 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2321 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2322 definition for no-X builds.
2324 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2326 Static checks with GCC 4.6.0 and non-default toolkits.
2328 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2330 * process.c (keyboard_bit_set): Define only if SIGIO.
2331 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2332 (send_process): Repair possible setjmp clobbering.
2334 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2336 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2338 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2340 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2341 Define only if needed.
2343 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2344 by pacifying GCC about it. Maybe it's time to retire it?
2345 * xfaces.c (USG, __TIMEVAL__): Likewise.
2347 * dispextern.h (struct redisplay_interface): Rename param
2349 * termhooks.h (struct terminal): Likewise.
2350 * xterm.c (xembed_send_message): Likewise.
2352 * insdel.c (make_gap_smaller): Define only if
2353 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2355 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2358 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2359 so that we aren't warned about unused symbols.
2361 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2363 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2365 * xfns.c (x_real_positions): Mark locals as initialized.
2367 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2369 * xterm.c: Fix problems found by static analysis with other toolkits.
2370 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2371 (x_dispatch_event): Declare static if USE_GTK, and
2372 define if USE_GTK || USE_X_TOOLKIT.
2373 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2374 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2375 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2376 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2378 * xmenu.c (menu_help_callback): Pointer type fixes.
2379 Use const pointers when pointing at readonly data. Avoid pointer
2381 (FALSE): Remove unused macro.
2382 (update_frame_menubar): Remove unused decl.
2384 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2386 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2387 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2388 (single_menu_item): Rename local to avoid shadowing.
2390 * keyboard.c (make_lispy_event): Remove unused local var.
2392 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2393 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2395 * bitmaps: Change bitmaps from unsigned char back to the X11
2396 compatible char. Avoid the old compiler warnings about
2397 out-of-range initializers by using, for example, '\xab' rather
2400 * xgselect.c (xgselect_initialize): Check vs interface
2401 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2403 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2405 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2406 to read-only memory.
2408 * fns.c (vector): Remove; this old hack is no longer needed.
2410 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2412 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2414 * xrdb.c (x_load_resources): Omit unused local.
2416 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2417 (x_window): Rename locals to avoid shadowing.
2418 (USG): Use the kludged USG macro, to pacify gcc.
2420 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2421 (x_term_init): Remove local to avoid shadowing.
2423 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2425 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2426 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2428 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2430 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2432 Fix regex.c, syntax.c and friends for buffers > 2GB.
2433 * syntax.h (struct gl_state_s): Declare character position members
2436 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2438 * textprop.c (verify_interval_modification, interval_of):
2439 Declare arguments EMACS_INT.
2441 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2444 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2446 * indent.c (Fvertical_motion): Local variable it_start is now
2449 * regex.c (re_match, re_match_2, re_match_2_internal)
2450 (bcmp_translate, regcomp, regexec, print_double_string)
2451 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2452 (re_compile_pattern, re_exec): Declare arguments and local
2453 variables `size_t' and `ssize_t' and return values `regoff_t', as
2455 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2456 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2457 <compile_stack_type>: `size' and `avail' are now `size_t'.
2459 * regex.h <regoff_t>: Use ssize_t, not int.
2460 (re_search, re_search_2, re_match, re_match_2): Arguments that
2461 specify buffer/string position and length are now ssize_t and
2462 size_t. Return type is regoff_t.
2464 2011-04-16 Ben Key <bkey76@gmail.com>
2466 * nsfont.m: Fixed bugs in ns_get_family and
2467 ns_descriptor_to_entity that were caused by using free to
2468 deallocate memory blocks that were allocated by xmalloc (via
2469 xstrdup). This caused Emacs to crash when compiled with
2470 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2471 --enable-checking=xmallocoverrun). xfree is now used to
2472 deallocate these memory blocks.
2474 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2476 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2478 emacs_write: Accept and return EMACS_INT for sizes.
2479 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2481 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2482 Accept and return EMACS_INT.
2483 (emacs_gnutls_write): Return the number of bytes written on
2485 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2486 (emacs_read, emacs_write): Remove check for negative size, as the
2487 Emacs source code has been audited now.
2488 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2489 (emacs_read, emacs_write): Use it.
2490 * process.c (send_process): Adjust to the new signatures of
2491 emacs_write and emacs_gnutls_write. Do not attempt to store
2492 a byte offset into an 'int'; it might overflow.
2493 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2495 * sound.c: Don't assume sizes fit in 'int'.
2496 (struct sound_device.period_size, alsa_period_size):
2497 Return EMACS_INT, not int.
2498 (struct sound_device.write, vox_write, alsa_write):
2499 Accept EMACS_INT, not int.
2500 (wav_play, au_play): Use EMACS_INT to store sizes and to
2501 record read return values.
2503 2011-04-15 Ben Key <bkey76@gmail.com>
2505 * keyboard.c (Qundefined): Don't declare static since it is used
2507 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2508 static since they are used in nsfont.m.
2510 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2512 * process.c (Qprocessp): Don't declare static.
2513 * lisp.h (Qprocessp): Declare again.
2515 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2517 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2519 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2521 Improve C-level modularity by making more things 'static'.
2523 Don't publish debugger-only interfaces to other modules.
2524 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2525 (verify_bytepos, count_markers): Move decls to the only modules
2527 * region-cache.h (pp_cache): Likewise.
2528 * window.h (check_all_windows): Likewise.
2529 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2531 * sysdep.c (croak): Now static, if
2532 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2533 * syssignal.h (croak): Declare only if not static.
2535 * alloc.c (refill_memory_reserve): Now static if
2536 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2537 * lisp.h (refill_memory_reserve): Declare only if not static.
2539 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2540 Define only if USE_LUCID.
2542 * xrdb.c (x_customization_string, x_rm_string): Now static.
2544 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2545 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2547 * xdisp.c (draw_row_with_mouse_face): Now static.
2548 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2550 * window.h (check_all_windows): Mark externally visible.
2552 * window.c (window_deletion_count): Now static.
2554 * undo.c: Make symbols static if they're not exported.
2555 (last_undo_buffer, last_boundary_position, pending_boundary):
2558 * textprop.c (interval_insert_behind_hooks): Now static.
2559 (interval_insert_in_front_hooks): Likewise.
2561 * term.c: Make symbols static if they're not exported.
2562 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2563 (max_frame_lines, tty_set_terminal_modes):
2564 (tty_reset_terminal_modes, tty_turn_off_highlight):
2565 (get_tty_terminal): Now static.
2566 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2567 * termhooks.h (term_mouse_moveto): Do not declare if
2569 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2570 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2572 * sysdep.c: Make symbols static if they're not exported.
2573 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2575 (sigprocmask_set, full_mask): Remove; unused.
2576 (wait_debugging): Mark as visible.
2577 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2578 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2580 * syntax.c (syntax_temp): Define only if !__GNUC__.
2582 * sound.c (current_sound_device, current_sound): Now static.
2584 * search.c (searchbufs, searchbuf_head): Now static.
2586 * scroll.c (scroll_cost): Remove; unused.
2587 * dispextern.h (scroll_cost): Remove decl.
2589 * region-cache.h (pp_cache): Mark as externally visible.
2591 * process.c: Make symbols static if they're not exported.
2592 (process_tick, update_tick, create_process, chan_process):
2593 (Vprocess_alist, proc_buffered_char, datagram_access):
2594 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2595 (deactivate_process): Mark defn as static, as well as decl.
2596 * lisp.h (create_process): Remove decl.
2597 * process.h (chan_process, Vprocess_alist): Remove decls.
2599 * print.c: Make symbols static if they're not exported.
2600 (print_depth, new_backquote_output, being_printed, print_buffer):
2601 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2602 (print_interval, print_number_index, initial_stderr_stream):
2604 * lisp.h (Fprinc): Remove decl.
2605 (debug_output_compilation_hack): Mark as externally visible.
2607 * sysdep.c (croak): Move decl from here to syssignal.h.
2608 * syssignal.h (croak): Put it here, so the API can be checked when
2609 'croak' is called from dissociate_if_controlling_tty.
2611 * minibuf.c: Make symbols static if they're not exported.
2612 (minibuf_save_list, choose_minibuf_frame): Now static.
2613 * lisp.h (choose_minibuf_frame): Remove decl.
2615 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2617 * lread.c: Make symbols static if they're not exported.
2618 (read_objects, initial_obarray, oblookup_last_bucket_number):
2620 (make_symbol): Remove; unused.
2621 * lisp.h (initial_obarray, make_symbol): Remove decls.
2623 * keyboard.c: Make symbols static if they're not exported.
2624 (single_kboard, recent_keys_index, total_keys, recent_keys):
2625 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2626 (this_single_command_key_start, echoing, last_auto_save):
2627 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2628 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2629 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2630 (Vlispy_mouse_stem, double_click_count):
2632 (force_auto_save_soon): Define only if SIGDANGER.
2633 (ignore_mouse_drag_p): Now static if
2634 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2635 (print_help): Remove; unused.
2636 (stop_character, last_timer_event): Mark as externally visible.
2637 * keyboard.h (ignore_mouse_drag_p): Declare only if
2638 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2639 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2640 * lisp.h (echoing): Remove decl.
2641 (force_auto_save_soon): Declare only if SIGDANGER.
2642 * xdisp.c (redisplay_window): Simplify code, to make it more
2643 obvious that ignore_mouse_drag_p is not accessed if !defined
2644 USE_GTK && !defined HAVE_NS.
2646 * intervals.c: Make symbols static if they're not exported.
2647 (merge_properties_sticky, merge_interval_right, delete_interval):
2649 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2651 * insdel.c: Make symbols static if they're not exported.
2652 However, leave prepare_to_modify_buffer alone. It's never
2653 called from outside this function, but that appears to be a bug.
2654 (combine_after_change_list, combine_after_change_buffer):
2655 (adjust_after_replace, signal_before_change): Now static.
2656 (adjust_after_replace_noundo): Remove; unused.
2657 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2658 (signal_before_change): Remove decls.
2660 * indent.c (val_compute_motion, val_vmotion): Now static.
2662 * image.c: Make symbols static if they're not exported.
2663 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2665 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2666 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2668 * fringe.c (standard_bitmaps): Now static.
2669 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2671 * frame.c: Make symbols static if they're not exported.
2672 (x_report_frame_params, make_terminal_frame): Now static.
2673 (get_frame_param): Now static, unless HAVE_NS.
2674 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2675 (x_get_resource_string): Remove; not used.
2676 * frame.h (make_terminal_frame, x_report_frame_params):
2677 (x_get_resource_string); Remove decls.
2678 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2679 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2681 * font.c, fontset.c: Make symbols static if they're not exported.
2682 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2683 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2684 * font.c (font_close_object): Now static.
2685 * font.h (font_close_object): Remove.
2686 * fontset.c (FONTSET_OBJLIST): Remove.
2687 (free_realized_fontset) #if-0 the body, which does nothing.
2688 (face_suitable_for_char_p): #if-0, as it's never called.
2689 * fontset.h (face_suitable_for_char_p): Remove decl.
2690 * xfaces.c (face_at_string_position):
2691 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2692 since 0 is always ASCII.
2694 * fns.c (weak_hash_tables): Now static.
2696 * fileio.c: Make symbols static if they're not exported.
2697 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2698 (Vwrite_region_annotation_buffers): Now static.
2700 * eval.c: Make symbols static if they're not exported.
2701 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2702 * lisp.h (backtrace_list): Remove decl.
2704 * emacs.c: Make symbols static if they're not exported.
2705 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2706 (fatal_error_code, fatal_error_signal_hook, standard_args):
2708 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2709 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2710 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2711 * lisp.h (fatal_error_signal_hook): Remove decl.
2712 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2714 * editfns.c: Move a (normally-unused) function to its only use.
2715 * editfns.c, lisp.h (get_operating_system_release): Remove.
2716 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2717 worth the hassle of breaking this out.
2719 * xterm.c: Make symbols static if they're not exported.
2720 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2721 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2722 (x_destroy_window, x_delete_display):
2724 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2725 (x_mouse_leave): Remove; unused.
2726 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2727 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2728 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2730 (x_mouse_leave): Declare only if WINDOWSNT.
2731 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2732 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2735 * ftxfont.c: Make symbols static if they're not exported.
2736 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2738 * font.h (ftxfont_driver): Likewise.
2740 * xfns.c: Make symbols static if they're not exported.
2741 (x_last_font_name, x_display_info_for_name):
2742 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2743 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2744 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2745 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2746 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2747 (last_show_tip_args): Now static.
2748 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2749 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2750 (x_screen_planes): Remove; unused.
2751 * dispextern.h (x_screen_planes): Remove decl.
2753 * dispnew.c: Make symbols static if they're not exported.
2754 * dispextern.h (redraw_garbaged_frames, scrolling):
2755 (increment_row_positions): Remove.
2756 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2757 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2759 (redraw_garbaged_frames): Remove; unused.
2761 * xfaces.c: Make symbols static if they're not exported.
2762 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2764 * xterm.h (defined_color): Remove decls.
2765 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2766 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2767 (menu_face_changed_default, defined_color, free_realized_face):
2768 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2769 (ascii_face_of_lisp_face): Remove; unused.
2771 * xdisp.c: Make symbols static if they're not exported.
2772 * dispextern.h (scratch_glyph_row, window_box_edges):
2773 (glyph_to_pixel_coords, set_cursor_from_row):
2774 (get_next_display_element, set_iterator_to_next):
2775 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2776 (show_mouse_face): Remove decls
2777 * frame.h (message_buf_print): Likewise.
2778 * lisp.h (pop_message, set_message, check_point_in_composition):
2780 * xterm.h (set_vertical_scroll_bar): Likewise.
2781 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2782 (message_buf_print, scratch_glyph_row, displayed_buffer):
2783 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2784 (get_next_display_element, show_mouse_face, window_box_edges):
2785 (frame_to_window_pixel_xy, check_point_in_composition):
2786 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2787 (glyph_to_pixel_coords): Remove; unused.
2789 * dired.c (file_name_completion): Now static.
2791 * dbusbind.c (xd_in_read_queued_messages): Now static.
2793 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2794 * data.c (circular_list_error): Remove.
2796 * commands.h (last_point_position, last_point_position_buffer):
2797 (last_point_position_window): Remove decls.
2798 * keyboard.c: Make these variables static.
2800 * coding.h (coding, code_convert_region, encode_coding_gap):
2802 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2803 (iso_code_class, detect_coding, code_convert_region): Now static.
2804 (encode_coding_gap): Remove; unused.
2806 * chartab.c (chartab_chars, chartab_bits): Now static.
2808 * charset.h (charset_iso_8859_1): Remove decl.
2809 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2812 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2813 * ccl.c (Vccl_program_table): Now static.
2814 (check_ccl_update): Remove; unused.
2816 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2817 * category.h: ... from here.
2818 * category.c (check_category_table, set_category_set): Now static.
2820 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2821 * lisp.h: Remove these decls.
2823 * buffer.c (buffer_count): Remove unused var.
2825 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2826 so that it's not optimized away.
2827 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2828 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2829 exported only to the debugger.
2831 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2832 * atimer.h (run_all_atimers): Remove; not exported.
2834 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2835 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2836 was inaccessible from Lisp.
2837 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2838 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2840 alloc.c: Import and export fewer symbols, and remove unused items.
2841 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2843 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2844 it's not optimized away by whole-program optimization.
2845 (message_enable_multibyte, free_misc): Remove.
2846 (catchlist, handlerlist, mark_backtrace):
2847 Declare only if BYTE_MARK_STACK.
2848 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2849 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2850 (message_enable_multibyte): Remove decl.
2851 (free_misc, interval_free_list, float_block, float_block_index):
2852 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2853 (cons_free_list, last_marked_index):
2855 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2856 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2857 (mark_backtrace): Define only if BYTE_MARK_STACK.
2858 * xdisp.c (message_enable_multibyte): Now static.
2860 Declare Lisp_Object Q* variables to be 'static' if not exported.
2861 This makes it easier for human readers (and static analyzers)
2862 to see whether these variables are used from other modules.
2863 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2864 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2865 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2866 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2867 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2868 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2869 * xmenu.c, xselect.c:
2870 Declare Q* vars static if they are not used in other modules.
2871 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2872 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2873 Remove decls of unexported vars.
2874 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2876 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2878 Make Emacs functions such as Fatom 'static' by default.
2879 This makes it easier for human readers (and static analyzers)
2880 to see whether these functions can be called from other modules.
2881 DEFUN now defines a static function. To make the function external
2882 so that it can be used in other C modules, use the new macro DEFUE.
2883 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2884 (Finit_image_library):
2885 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2886 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2887 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2888 Remove decls, since these functions are now static.
2889 (Funintern, Fget_internal_run_time): New decls, since these functions
2890 were already external.
2892 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2893 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2894 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2895 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2896 * keyboard.c, keymap.c, lread.c:
2897 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2898 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2899 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2900 Mark functions with DEFUE instead of DEFUN,
2901 if they are used in other modules.
2902 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2903 decls for now-static functions.
2904 * buffer.h (Fdelete_overlay): Remove decl.
2905 * callproc.c (Fgetenv_internal): Mark as internal.
2906 * composite.c (Fremove_list_of_text_properties): Remove decl.
2907 (Fcomposition_get_gstring): New forward static decl.
2908 * composite.h (Fcomposite_get_gstring): Remove decl.
2909 * dired.c (Ffile_attributes): New forward static decl.
2910 * doc.c (Fdocumntation_property): New forward static decl.
2911 * eval.c (Ffetch_bytecode): New forward static decl.
2912 (Funintern): Remove extern decl; now in .h file where it belongs.
2913 * fileio.c (Fmake_symbolic_link): New forward static decl.
2914 * image.c (Finit_image_library): New forward static decl.
2915 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2916 * intervals.h (Fprevious_property_change):
2917 (Fremove_list_of_text_properties): Remove decls.
2918 * keyboard.c (Fthis_command_keys): Remove decl.
2919 (Fcommand_execute): New forward static decl.
2920 * keymap.c (Flookup_key): New forward static decl.
2921 (Fcopy_keymap): Now static.
2922 * keymap.h (Flookup_key): Remove decl.
2923 * process.c (Fget_process): New forward static decl.
2924 (Fprocess_datagram_address): Mark as internal.
2925 * syntax.c (Fsyntax_table_p): New forward static decl.
2926 (skip_chars): Remove duplicate decl.
2927 * textprop.c (Fprevious_property_change): New forward static decl.
2928 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2930 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2931 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2933 * editfns.c (Fformat): Remove unreachable code.
2935 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2937 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2940 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2942 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2943 when at ZV. (Bug#8487)
2945 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2947 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2949 * keyboard.c (parse_tool_bar_item): Likewise.
2950 * sound.c (sound_cleanup, alsa_close): Likewise.
2951 * termcap.c (tgetent): Likewise.
2952 * xfns.c (x_default_font_parameter): Likewise.
2953 * xsettings.c (read_and_apply_settings): Likewise.
2955 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2956 (overrun_check_free): Protoize.
2958 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2960 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2961 since callers should never pass a negative size.
2962 Change the signature to match that of plain 'read' and 'write'; see
2963 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2964 * lisp.h: Update prototypes of emacs_write and emacs_read.
2966 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2968 * xdisp.c (redisplay_window): Don't try to determine the character
2969 position of the scroll margin if the window start point w->startp
2970 is outside the buffer's accessible region. (Bug#8468)
2972 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2974 Fix write-region and its subroutines for buffers > 2GB.
2975 * fileio.c (a_write, e_write): Modify declaration of arguments and
2976 local variables to support buffers larger than 2GB.
2977 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2979 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2980 argument, local variables, and return value.
2982 * lisp.h: Update prototypes of emacs_write and emacs_read.
2984 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2986 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2988 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2990 Fix more problems found by GCC 4.6.0's static checks.
2992 * xdisp.c (vmessage): Use a better test for character truncation.
2994 * charset.c (load_charset_map): <, not <=, for optimization,
2995 and to avoid potential problems with integer overflow.
2996 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2997 * casetab.c (set_identity, shuffle): Likewise.
2998 * editfns.c (Fformat): Likewise.
2999 * syntax.c (skip_chars): Likewise.
3001 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3002 This also lets GCC 4.6.0 generate slightly better loop code.
3004 * callint.c (Fcall_interactively): <, not <=, for optimization.
3005 (Fcall_interactively): Count the number of arguments produced,
3006 not the number of arguments given. This is simpler and lets GCC
3007 4.6.0 generate slightly better code.
3009 * ftfont.c: Distingish more carefully between FcChar8 and char.
3010 The previous code passed unsigned char * to a functions like
3011 strlen and xstrcasecmp that expect char *, which does not
3012 conform to the C standard.
3013 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3014 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3015 char * when the C standard requires it.
3017 * keyboard.c (read_char): Remove unused var.
3019 * eval.c: Port to Windows vsnprintf (Bug#8435).
3021 (SIZE_MAX): Define if the headers do not.
3022 (verror): Do not give up if vsnprintf returns a negative count.
3023 Instead, grow the buffer. This ports to Windows vsnprintf, which
3024 does not conform to C99. Problem reported by Eli Zaretskii.
3025 Also, simplify the allocation scheme, by avoiding the need for
3026 calling realloc, and removing the ALLOCATED variable.
3028 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3030 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3031 But keep the doprint source code for now, as we might revamp it
3032 and use it again (Bug#8435).
3033 * lisp.h (doprnt): Remove.
3034 * Makefile.in (base_obj): Remove doprnt.o.
3035 * deps.mk (doprnt.o): Remove.
3037 error: Print 32- and 64-bit integers portably (Bug#8435).
3038 Without this change, on typical 64-bit hosts error ("...%d...", N)
3039 was used to print both 32- and 64-bit integers N, which relied on
3041 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3043 * lisp.h (error, verror): Mark as printf-like functions.
3044 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3045 Report overflow in size calculations when allocating printf buffer.
3046 Do not truncate output string at its first null byte.
3047 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3048 Truncate the output at a character boundary, since vsnprintf does not
3050 * charset.c (check_iso_charset_parameter): Convert internal
3051 character to string before calling 'error', since %c now has the
3053 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3054 overflow when computing char to be passed to 'error'. Do not
3055 pass Lisp_Object to 'error'; pass the integer instead.
3056 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3057 formatted with plain %d.
3059 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3061 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3063 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3065 * xterm.c (x_catch_errors): Remove duplicate declaration.
3067 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3069 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3071 2011-04-10 Jim Meyering <meyering@redhat.com>
3073 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3074 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3075 return ssize_t not "int", and use size_t as the buffer length.
3076 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3077 * gnutls.h: Update declarations.
3078 * process.c (read_process_output): Use ssize_t, to match.
3079 (send_process): Likewise.
3081 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3083 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3085 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3087 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3088 Use unsigned char, to match FcChar8 type definition.
3090 * xterm.c (handle_one_xevent):
3091 * xmenu.c (create_and_show_popup_menu):
3092 * xselect.c (x_decline_selection_request)
3093 (x_reply_selection_request): Avoid type-punned deref of X events.
3095 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3097 Fix some uses of `int' instead of EMACS_INT.
3098 * search.c (string_match_1, fast_string_match)
3099 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3100 (scan_buffer, find_next_newline_no_quit)
3101 (find_before_next_newline, search_command, Freplace_match)
3102 (Fmatch_data): Make some `int' variables be EMACS_INT.
3104 * xdisp.c (display_count_lines): 3rd argument and return value now
3105 EMACS_INT. All callers changed.
3106 (pint2hrstr): Last argument is now EMACS_INT.
3108 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3109 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3110 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3111 (decode_coding_utf_16, decode_coding_emacs_mule)
3112 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3113 (decode_coding_ccl, decode_coding_charset)
3114 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3115 (decode_coding_iso_2022, decode_coding_emacs_mule)
3116 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3117 <char_offset, last_offset>: Declare EMACS_INT.
3118 (encode_coding_utf_8, encode_coding_utf_16)
3119 (encode_coding_emacs_mule, encode_invocation_designation)
3120 (encode_designation_at_bol, encode_coding_iso_2022)
3121 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3122 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3124 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3125 (encode_invocation_designation): Last argument P_NCHARS is now
3127 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3128 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3130 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3133 * ccl.c (Fccl_execute_on_string): Declare some variables
3136 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3138 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3140 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3142 * process.c (Fformat_network_address): Doc fix.
3144 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3146 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3148 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3150 * keyboard.c (read_char): Call Lisp function help-form-show,
3151 instead of using internal_with_output_to_temp_buffer.
3152 (Qhelp_form_show): New var.
3153 (syms_of_keyboard): Use DEFSYM macro.
3155 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3157 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3159 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3161 * process.c (Flist_processes): Remove to Lisp.
3162 (list_processes_1): Delete.
3164 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3166 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3168 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3170 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3172 Fix more problems found by GCC 4.6.0's static checks.
3174 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3176 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3178 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3180 * xdisp.c (vmessage): Mark as a printf-like function.
3182 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3184 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3186 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3187 printf-like functions.
3188 (tiff_load): Add casts to remove these marks before passing them
3189 to system-supplied API.
3191 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3193 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3194 This avoids several warnings with gcc -Wstrict-overflow.
3195 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3196 directly, rather than having caller test rule sign. This avoids
3197 some unnecessary tests.
3198 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3199 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3200 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3202 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3203 (xfont_open): Avoid unnecessary tests.
3205 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3207 * composite.h, composite.c (composition_gstring_put_cache):
3208 Use EMACS_INT, not int, for length.
3210 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3211 breaking out part of COMPOSITION_DECODE_RULE.
3212 (COMPOSITION_DECODE_RULE): Use it.
3213 * composite.c (get_composition_id): Remove unused local vars,
3214 by using the new macro.
3216 * textprop.c (set_text_properties_1): Change while to do-while,
3217 since the condition is always true at first.
3219 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3220 (interval_deletion_adjustment): Return unsigned value.
3223 * process.c (list_processes_1, create_pty, read_process_output):
3224 (exec_sentinel): Remove vars that were set but not used.
3225 (create_pty): Remove unnecessary "volatile"s.
3226 (Fnetwork_interface_info): Avoid possibility of int overflow.
3227 (read_process_output): Do adaptive read buffering even if carryover.
3228 (read_process_output): Simplify nbytes computation if buffered.
3230 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3232 * syntax.c (scan_words): Remove var that was set but not used.
3233 (update_syntax_table): Use unsigned instead of int.
3235 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3236 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3237 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3239 * print.c (print_error_message): Avoid int overflow.
3241 * font.c (font_list_entities): Redo for clarity,
3242 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3244 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3245 (font_score): Avoid potential overflow in diff calculation.
3247 * fns.c (substring_both): Remove var that is set but not used.
3248 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3250 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3252 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3253 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3254 can always succeed if overflow has undefined behavior.
3256 * search.c (boyer_moore, wordify): Remove vars set but not used.
3257 (wordify): Omit three unnecessary tests.
3259 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3260 All callers changed. This avoids the need for an unused var.
3262 * casefiddle.c (casify_region): Remove var that is set but not used.
3264 * dired.c (file_name_completion): Remove var that is set but not used.
3266 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3268 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3269 (Finsert_file_contents): Remove unnecessary code checking fd.
3271 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3272 Check for integer overflow on size calculations.
3274 * buffer.c (Fprevious_overlay_change): Remove var that is set
3277 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3278 Remove vars that are set but not used.
3279 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3280 (timer_check_2): Mark vars as initialized.
3282 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3284 * image.c (lookup_image): Remove var that is set but not used.
3285 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3287 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3288 that are set but not used.
3290 * xfns.c (make_invisible_cursor): Don't return garbage
3291 if XCreateBitmapFromData fails (Bug#8410).
3293 * xselect.c (x_get_local_selection, x_handle_property_notify):
3294 Remove vars that are set but not used.
3296 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3297 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3299 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3300 Remove var that is set but not used.
3301 (scroll_bar_windows_size): Now size_t, not int.
3302 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3305 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3306 (map_tty_color) [!defined MSDOS]: Likewise.
3308 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3310 * coding.c: Remove vars that are set but not used.
3311 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3312 All callers changed.
3313 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3314 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3315 (decode_coding_charset): Remove vars that are set but not used.
3317 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3318 that is set but not used.
3320 * print.c (print_object): Remove var that is set but not used.
3322 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3323 The gnulib version avoids calling malloc in the usual case,
3324 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3325 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3326 * filelock.c (current_lock_owner): Likewise.
3327 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3328 * sysdep.c: Include allocator.h, careadlinkat.h.
3329 (emacs_no_realloc_allocator): New static constant.
3330 (emacs_readlink): New function.
3331 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3332 ../lib/careadlinkat.h.
3334 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3336 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3337 first non-nil return value).
3339 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3341 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3342 if not defined (Bug#8403).
3344 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3346 * xdisp.c (display_count_lines): Remove parameter `start',
3347 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3348 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3349 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3350 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3351 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3352 and thereabouts. All callers changed.
3353 (get_per_char_metric): Remove parameter `f', unused since
3354 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3356 2011-04-02 Jim Meyering <meyering@redhat.com>
3358 do not dereference NULL upon failed strdup
3359 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3360 (ns_get_family): Likewise.
3362 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3364 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3366 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3368 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3371 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3373 Add lexical binding.
3375 * window.c (Ftemp_output_buffer_show): New fun.
3376 (Fsave_window_excursion):
3377 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3379 * lread.c (lisp_file_lexically_bound_p): New function.
3380 (Fload): Bind Qlexical_binding.
3381 (readevalloop): Remove `evalfun' arg.
3382 Bind Qinternal_interpreter_environment.
3383 (Feval_buffer): Bind Qlexical_binding.
3384 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3386 (syms_of_lread): Declare `lexical-binding'.
3388 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3390 * keyboard.c (eval_dyn): New fun.
3391 (menu_item_eval_property): Use it.
3393 * image.c (parse_image_spec): Use Ffunctionp.
3395 * fns.c (concat, mapcar1): Accept byte-code-functions.
3397 * eval.c (Fsetq): Handle lexical vars.
3398 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3399 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3400 (FletX, Flet): Obey lexical binding.
3401 (Fcommandp): Handle closures.
3402 (Feval): New `lexical' arg.
3403 (eval_sub): New function extracted from Feval. Use it almost
3404 everywhere where Feval was used. Look up vars in lexical env.
3406 (Ffunctionp): Move from subr.el.
3407 (Ffuncall): Handle closures.
3408 (apply_lambda): Remove `eval_flags'.
3409 (funcall_lambda): Handle closures and new byte-code-functions.
3410 (Fspecial_variable_p): New function.
3411 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3412 but without exporting it to Lisp.
3414 * doc.c (Fdocumentation, store_function_docstring):
3415 * data.c (Finteractive_form): Handle closures.
3417 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3420 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3422 (exec_byte_code): New function extracted from Fbyte_code to handle new
3423 calling convention for byte-code-functions. Add new byte-codes.
3425 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3427 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3429 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3431 * xdisp.c (redisplay_internal): Fix prototype.
3433 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (SCROLL_LIMIT): New macro.
3436 (try_scrolling): Use it when setting scroll_limit.
3437 Limit scrolling to 100 screen lines.
3438 (redisplay_window): Even when falling back on "recentering",
3439 position point in the window according to scroll-conservatively,
3440 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3442 (try_scrolling): When point is above the window, allow searching
3443 as far as scroll_max, or one screenful, to compute vertical
3444 distance from PT to the scroll margin position. This prevents
3445 try_scrolling from unnecessarily failing when
3446 scroll-conservatively is set to a value slightly larger than the
3447 window height. Clean up the case of PT below the margin at bottom
3448 of window: scroll_max can no longer be INT_MAX. When aggressive
3449 scrolling is in use, don't let point enter the opposite scroll
3450 margin as result of the scroll.
3451 (syms_of_xdisp) <scroll-conservatively>: Document the
3452 threshold of 100 lines for never-recentering scrolling.
3454 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3456 * dispextern.h (move_it_by_lines):
3457 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3458 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3459 (message_log_check_duplicate): Remove parameters `prev_bol' and
3460 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3461 (redisplay_internal): Remove parameter `preserve_echo_area',
3462 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3464 * indent.c (Fvertical_motion):
3465 * window.c (window_scroll_pixel_based, Frecenter):
3466 Don't pass `need_y_p' to `move_it_by_lines'.
3468 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3470 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3471 steal a few bits to be more compact.
3472 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3473 Remove unneeded casts.
3475 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3477 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3479 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3480 binding" message (bug#7967).
3482 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3484 Fix more problems found by GCC 4.6.0's static checks.
3486 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3487 Remove unused local var.
3489 * editfns.c (Fmessage_box): Remove unused local var.
3491 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3492 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3493 Omit unused local vars.
3494 * window.c (shrink_windows): Omit unused local var.
3495 * menu.c (digest_single_submenu): Omit unused local var.
3496 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3497 Omit unused local var.
3499 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3500 Don't assume string length fits in int.
3501 (keyremap_step, read_key_sequence): Use size_t for sizes.
3502 (read_key_sequence): Don't check last_real_key_start redundantly.
3504 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3505 instead of alloca (Bug#8344).
3507 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3508 (Fbacktrace_frame): Don't assume nframes fits in int.
3510 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3512 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3515 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3517 * cm.c (calccost): Turn while-do into do-while, for clarity.
3519 * keyboard.c (syms_of_keyboard): Use the same style as later
3520 in this function when indexing through an array. This also
3521 works around GCC bug 48267.
3523 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3525 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3527 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3528 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3530 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3531 This avoids undefined behavior on integer overflow, and is a bit
3532 more convenient anyway since it is compared to a size_t variable.
3534 Variadic C functions now count arguments with size_t, not int.
3535 This avoids an unnecessary limitation on 64-bit machines, which
3536 caused (substring ...) to crash on large vectors (Bug#8344).
3537 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3538 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3539 All variadic functions and their callers changed accordingly.
3540 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3541 * data.c (arith_driver, float_arith_driver): Likewise.
3542 * editfns.c (general_insert_function): Likewise.
3543 * eval.c (struct backtrace.nargs, interactive_p)
3544 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3545 (funcall_lambda, mark_backtrace): Likewise.
3546 * fns.c (concat): Likewise.
3547 * frame.c (x_set_frame_parameters): Likewise.
3548 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3549 0 if not found, not -1. All callers changed.
3551 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3552 (stack_copy_size): Now size_t, not int.
3553 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3555 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3557 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3558 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3559 All callers changed.
3561 * lisp.h (multibyte_char_to_unibyte):
3562 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3563 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3564 * character.h (CHAR_TO_BYTE8):
3565 * cmds.c (internal_self_insert):
3566 * editfns.c (general_insert_function):
3567 * keymap.c (push_key_description):
3568 * search.c (Freplace_match):
3569 * xdisp.c (message_dolog, set_message_1): All callers changed.
3571 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3573 * keyboard.c (safe_run_hook_funcall): New function.
3574 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3575 don't set the hook to nil, but remove the offending function instead.
3576 (Qcommand_hook_internal): Remove, unused.
3577 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3578 Vcommand_hook_internal.
3580 * eval.c (enum run_hooks_condition): Remove.
3581 (funcall_nil, funcall_not): New functions.
3582 (run_hook_with_args): Call each function through a `funcall' argument.
3583 Remove `cond' argument, now redundant.
3584 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3585 (Frun_hook_with_args_until_failure): Adjust accordingly.
3586 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3588 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3590 * dispextern.h (string_buffer_position): Remove declaration.
3592 * print.c (strout): Remove parameter `multibyte', unused since
3593 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3595 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3596 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3597 All callers changed.
3599 * w32.c (_wsa_errlist): Use braces for struct initializers.
3601 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3602 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3603 All callers changed.
3604 (string_buffer_position): Likewise. Also, make static (it's never
3605 used outside xdisp.c).
3606 (cursor_row_p): Remove parameter `w', unused since
3607 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3608 (decode_mode_spec): Remove parameter `precision', introduced during
3609 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3610 All callers changed.
3612 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3614 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3616 2011-03-27 Anders Lindgren <andlind@gmail.com>
3618 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3619 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3620 (ns_update_auto_hide_menu_bar): New functions.
3621 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3622 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3623 ns_constrain_all_frames.
3624 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3625 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3627 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3629 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3631 2011-03-27 Glenn Morris <rgm@gnu.org>
3633 * syssignal.h: Replace RETSIGTYPE with void.
3634 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3635 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3636 Replace SIGTYPE with void everywhere.
3637 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3638 * s/template.h (SIGTYPE): Remove commented out definition.
3640 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3642 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3643 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3645 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3647 * w32.c (read_unc_volume): Use parameter `henum', instead of
3648 global variable `wget_enum_handle'.
3650 * keymap.c (describe_vector): Remove parameters `indices' and
3651 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3652 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3654 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3656 * keyboard.c (timer_check): Remove parameter `do_it_now',
3657 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3658 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3659 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3661 * keyboard.c (read_char):
3662 * w32menu.c (w32_menu_display_help):
3663 * xmenu.c (show_help_event, menu_help_callback):
3664 Adjust calls to `show_help_echo'.
3666 * gtkutil.c (xg_maybe_add_timer):
3667 * keyboard.c (readable_events):
3668 * process.c (wait_reading_process_output):
3669 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3671 * insdel.c (adjust_markers_gap_motion):
3672 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3673 (gap_left, gap_right): Don't call it.
3675 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3677 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3678 incurred during fontification.
3680 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3682 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3683 (DEFVAR_PER_BUFFER): Don't pass it.
3685 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3686 (scrolling_window): Don't pass it.
3688 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3690 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3692 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3694 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3695 of variables specific to SELinux and computation of `encoded_absname'.
3697 * image.c (XPutPixel): Remove unused variable `height'.
3699 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3701 * unexw32.c (get_section_info): Remove unused variable `section'.
3703 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3704 (system_process_attributes): Remove unused variable `sess'.
3705 (sys_read): Remove unused variable `err'.
3707 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3708 (w32_wnd_proc): Remove unused variable `isdead'.
3709 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3710 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3711 (x_create_tip_frame): Remove unused variable `tem'.
3713 * w32inevt.c (w32_console_read_socket):
3714 Remove unused variable `no_events'.
3716 * w32term.c (x_draw_composite_glyph_string_foreground):
3717 Remove unused variable `width'.
3719 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3721 * w32term.c (x_set_glyph_string_clipping):
3722 Don't pass uninitialized region to CombineRgn.
3724 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3726 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3727 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3728 (Fx_close_connection): Remove unused variable `i'.
3730 * w32font.c (w32font_draw): Return number of glyphs.
3731 (w32font_open_internal): Remove unused variable `i'.
3732 (w32font_driver): Add missing initializer.
3734 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3735 (fill_in_menu): Remove unused variable `items_added'.
3737 * w32term.c (last_mouse_press_frame): Remove static global variable.
3738 (w32_clip_to_row): Remove unused variable `f'.
3739 (x_delete_terminal): Remove unused variable `i'.
3741 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3742 (NOTHING): Remove unused static global variable.
3743 (uniscribe_check_otf): Remove unused variable `table'.
3744 (uniscribe_font_driver): Add missing initializers.
3746 2011-03-23 Julien Danjou <julien@danjou.info>
3748 * term.c (Fsuspend_tty, Fresume_tty):
3749 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3750 * window.c (temp_output_buffer_show):
3751 * insdel.c (signal_before_change):
3752 * frame.c (Fhandle_switch_frame):
3753 * fileio.c (Fdo_auto_save):
3754 * emacs.c (Fkill_emacs):
3755 * editfns.c (save_excursion_restore):
3756 * cmds.c (internal_self_insert):
3757 * callint.c (Fcall_interactively):
3758 * buffer.c (Fkill_all_local_variables):
3759 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3761 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3762 unconditionnaly since it does the check itself.
3764 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3766 Fix more problems found by GCC 4.5.2's static checks.
3768 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3769 the first time through the loop, since we know p0 < p1 then.
3770 This also avoids a gcc -Wstrict-overflow warning.
3772 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3773 leading to a memory leak, possible in functions like
3774 load_charset_map_from_file that can allocate an unbounded number
3775 of objects (Bug#8318).
3777 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3778 that could (at least in theory) be that large.
3780 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3781 This is less likely to overflow, and avoids undefined behavior if
3782 overflow does occur. All callers changed. Use strtoul to scan
3783 for the unsigned long integer.
3784 (pint2hrstr): Simplify and tune code slightly.
3785 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3787 * scroll.c (do_scrolling): Work around GCC bug 48228.
3788 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3790 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3791 This also avoids a warning with gcc -Wstrict-overflow.
3792 (validate_x_resource_name): Simplify count usage.
3793 This also avoids a warning with gcc -Wstrict-overflow.
3795 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3798 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3800 * process.c (Fmake_network_process): Use socklen_t, not int,
3801 where POSIX says socklen_t is required in portable programs.
3802 This fixes a porting bug on hosts like 64-bit HP-UX, where
3803 socklen_t is wider than int (Bug#8277).
3804 (Fmake_network_process, server_accept_connection):
3805 (wait_reading_process_output, read_process_output):
3808 * process.c: Rename or move locals to avoid shadowing.
3809 (list_processes_1, Fmake_network_process):
3810 (read_process_output_error_handler, exec_sentinel_error_handler):
3811 Rename or move locals.
3812 (Fmake_network_process): Define label "retry_connect" only if needed.
3813 (Fnetwork_interface_info): Fix pointer signedness.
3814 (process_send_signal): Add cast to avoid pointer signedness problem.
3815 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3816 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3818 Make tparam.h and terminfo.c consistent.
3819 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3820 Include tparam.h instead, since it declares them.
3821 * cm.h (PC): Remove extern decl; tparam.h now does this.
3822 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3823 * terminfo.c: Include tparam.h, to check interfaces.
3824 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3825 (tparam): Adjust signature to match interface in tparam.h;
3826 this removes some undefined behavior. Check that outstring and len
3827 are zero, which they always are with Emacs.
3828 * tparam.h (PC, BC, UP): New extern decls.
3830 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3831 (xftfont_open): Rename locals to avoid shadowing.
3833 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3834 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3835 (OTF_TAG_SYM): Omit macro if not needed.
3836 (ftfont_list): Remove unused local.
3837 (get_adstyle_property, ftfont_pattern_entity):
3838 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3839 Rename locals to avoid shadowing.
3841 * xfont.c (xfont_list_family): Mark var as initialized.
3843 * xml.c (make_dom): Now static.
3845 * composite.c (composition_compute_stop_pos): Rename local to
3847 (composition_reseat_it): Remove unused locals.
3848 (find_automatic_composition, composition_adjust_point): Likewise.
3849 (composition_update_it): Mark var as initialized.
3850 (find_automatic_composition): Mark vars as initialized,
3851 with a FIXME (Bug#8290).
3853 character.h: Rename locals to avoid shadowing.
3854 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3855 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3856 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3857 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3860 * textprop.c (property_change_between_p): Remove; unused.
3862 * intervals.c (interval_start_pos): Now static.
3864 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3866 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3867 Rename locals to avoid shadowing.
3869 * sound.c (wav_play, au_play, Fplay_sound_internal):
3870 Fix pointer signedness.
3871 (alsa_choose_format): Remove unused local var.
3872 (wav_play): Initialize a variable to 0, to prevent undefined
3873 behavior (Bug#8278).
3875 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3877 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3879 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3880 clobbering (Bug#8298).
3881 * sysdep.c (sys_subshell): Likewise.
3882 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3884 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3885 This should get cleaned up, so that child_setup has the
3886 same signature on all platforms.
3888 * callproc.c (call_process_cleanup): Now static.
3889 (relocate_fd): Rename locals to avoid shadowing.
3891 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3893 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3894 not to be necessary, and produces flickering.
3896 2011-03-20 Glenn Morris <rgm@gnu.org>
3898 * config.in: Remove file.
3900 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3902 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3903 are now in src/globals.h.
3904 (syms_of_minibuf): Remove spurious & from previous change.
3906 2011-03-20 Leo <sdl.web@gmail.com>
3908 * minibuf.c (completing-read-function): New variable.
3909 (completing-read-default): Rename from completing-read.
3910 (completing-read): Call completing-read-function.
3912 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3914 * xfaces.c (Fx_load_color_file):
3915 Read color file from absolute filename (bug#8250).
3917 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3919 * makefile.w32-in: Update dependencies.
3921 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3923 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3925 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3927 Fix more problems found by GCC 4.5.2's static checks.
3929 * process.c (make_serial_process_unwind, send_process_trap):
3930 (sigchld_handler): Now static.
3932 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3933 That way, the code declares only the vars that it needs.
3934 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3935 * s/cygwin.h (PTY_ITERATION): Likewise.
3936 * s/darwin.h (PTY_ITERATION): Likewise.
3937 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3939 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3940 * process.c (allocate_pty): Don't declare stb unless it's needed.
3942 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3943 (CONSTANTLIM): Remove; unused.
3944 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3945 Define only if needed.
3947 * unexelf.c (unexec): Name an expression,
3948 to avoid gcc -Wbad-function-cast warning.
3949 Use a different way to cause a compilation error if anyone uses
3950 n rather than nn, a way that does not involve shadowing.
3951 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3953 * deps.mk (unexalpha.o): Remove; unused.
3955 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3956 * unexec.h: New file.
3957 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3958 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3960 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3961 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3962 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3963 Change as necessary to match prototype in unexec.h.
3965 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3967 (back_comment, skip_chars): Mark vars as initialized.
3969 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3970 Rename locals to avoid shadowing.
3972 * lread.c (read1): Rewrite so as not to use empty "else".
3973 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3975 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3977 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3978 warning when compiling print.c.
3980 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3981 instead of using an uninitialized var.
3982 (font_sort_entities): Mark var as initialized.
3984 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3986 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3987 pointers to constants.
3988 (font_parse_fcname): Remove unused vars.
3989 (font_delete_unmatched): Now static.
3990 (font_get_spec): Remove; unused.
3991 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3992 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3993 Rename or move locals to avoid shadowing.
3995 * fns.c (require_nesting_list, require_unwind): Now static.
3996 (Ffillarray): Rename locals to avoid shadowing.
3998 * floatfns.c (domain_error2): Define only if needed.
3999 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4001 * alloc.c (mark_backtrace): Move decl from here ...
4002 * lisp.h: ... to here, so that it can be checked.
4004 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4005 (Fdefvar): Rewrite so as not to use empty "else".
4006 (lisp_indirect_variable): Name an expression,
4007 to avoid gcc -Wbad-function-cast warning.
4008 (Fdefvar): Rename locals to avoid shadowing.
4010 * callint.c (quotify_arg, quotify_args): Now static.
4011 (Fcall_interactively): Rename locals to avoid shadowing.
4012 Use const pointer when appropriate.
4014 * lisp.h (get_system_name, get_operating_system_release):
4015 Move decls here, to check interfaces.
4016 * process.c (get_operating_system_release): Move decl to lisp.h.
4017 * xrdb.c (get_system_name): Likewise.
4018 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4019 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4020 some of which prompt warnings from gcc -Wbad-function-cast.
4021 (Fformat_time_string, Fencode_time, Finsert_char):
4022 (Ftranslate_region_internal, Fformat):
4023 Rename or remove local vars to avoid shadowing.
4024 (Ftranslate_region_internal): Mark var as initialized.
4026 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4029 * lisp.h (eassert): Check that the argument compiles, even if
4030 ENABLE_CHECKING is not defined.
4032 * data.c (Findirect_variable): Name an expression, to avoid
4033 gcc -Wbad-function-cast warning.
4034 (default_value, arithcompare, arith_driver, arith_error): Now static.
4035 (store_symval_forwarding): Rename local to avoid shadowing.
4036 (Fmake_variable_buffer_local, Fmake_local_variable):
4037 Mark variables as initialized.
4038 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4040 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4041 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4042 Rename locals to avoid shadowing.
4043 (mark_stack): Move local variables into the #ifdef region where
4045 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4046 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4048 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4049 (GC_STRING_CHARS): Remove; not used.
4050 (Fmemory_limit): Cast sbrk's returned value to char *.
4052 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4053 avoids undefined behavior in theory.
4055 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4057 Use functions, not macros, for up- and down-casing (Bug#8254).
4058 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4059 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4060 to use the following functions instead of these macros.
4061 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4062 EMACS_INT, since callers assume the returned value fits in int.
4063 (upcase1): Likewise, for UPCASE_TABLE.
4064 (uppercasep, lowercasep, upcase): New static inline functions.
4065 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4066 the race-condition problem in the old DOWNCASE.
4068 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4069 Rename locals to avoid shadowing.
4070 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4071 (regex_compile, re_search_2, re_match_2_internal):
4072 Remove unused local vars.
4073 (FREE_VAR): Rewrite so as not to use empty "else",
4074 which gcc can warn about.
4075 (regex_compile, re_match_2_internal): Mark locals as initialized.
4076 (RETALLOC_IF): Define only if needed.
4077 (WORDCHAR_P): Likewise. This one is never needed, but is used
4078 only in a comment talking about a compiler bug, so put inside
4079 the #if 0 of that comment.
4080 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4081 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4084 * search.c (boyer_moore): Rename locals to avoid shadowing.
4085 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4086 (PREV_CHAR_BOUNDARY): Likewise.
4088 * search.c (simple_search): Remove unused var.
4090 * dired.c (compile_pattern): Move decl from here ...
4091 * lisp.h: ... to here, so that it can be checked.
4092 (struct re_registers): New forward decl.
4094 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4096 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4098 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4099 Rename locals to avoid shadowing.
4100 (Fvertical_motion): Mark locals as initialized.
4102 * casefiddle.c (casify_object, casify_region): Now static.
4103 (casify_region): Mark local as initialized.
4105 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4107 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4108 New macros, so that the caller can use some names other than
4109 gcpro1, gcpro2, etc.
4110 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4112 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4113 argument, for consistency with GCPRO2_VAR, etc: it is now the
4114 prefix of the variable, not the variable itself. All uses
4116 * dired.c (directory_files_internal, file_name_completion):
4117 Rename locals to avoid shadowing.
4119 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4120 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4121 dired.c's scmp function, had undefined behavior.
4122 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4123 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4124 * buffer.h: ... to here, because these macros use current_buffer,
4125 and the new implementation with inline functions needs to have
4126 current_buffer in scope now, rather than later when the macros
4128 (downcase, upcase1): New static inline functions.
4129 (DOWNCASE, UPCASE1): Reimplement using these functions.
4130 This avoids undefined behavior in expressions like
4131 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4132 from race conditions in accessing the global variables
4133 case_temp1 and case_temp2.
4134 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4135 * lisp.h (case_temp1, case_temp2): Remove their decls.
4136 * character.h (ASCII_CHAR_P): Move from here ...
4137 * lisp.h: ... to here, so that the inline functions mentioned
4140 * dired.c (directory_files_internal_unwind): Now static.
4142 * fileio.c (file_name_as_directory, directory_file_name):
4143 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4145 (file_name_as_directory): Use const pointers when appropriate.
4146 (Fexpand_file_name): Likewise. In particular, newdir might
4147 point at constant storage, so make it a const pointer.
4148 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4149 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4151 (Fset_file_times, Finsert_file_contents, auto_save_error):
4152 Rename locals to avoid shadowing.
4154 * minibuf.c (choose_minibuf_frame_1): Now static.
4155 (Ftry_completion, Fall_completions): Rename or remove locals
4158 * marker.c (bytepos_to_charpos): Remove; unused.
4160 * lisp.h (verify_bytepos, count_markers): New decls,
4161 so that gcc does not warn that these functions aren't declared.
4163 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4164 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4165 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4166 (copy_text): Remove unused local var.
4168 * filelock.c (within_one_second): Now static.
4169 (lock_file_1): Rename local to avoid shadowing.
4171 * buffer.c (fix_overlays_before): Mark locals as initialized.
4172 (fix_start_end_in_overlays): Likewise. This function should be
4173 simplified by using pointers-to-pointers, but that's a different
4175 (switch_to_buffer_1): Now static.
4176 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4177 (report_overlay_modification): Rename locals to avoid shadowing.
4179 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4180 Fix pointer signedness issue.
4181 (sys_subshell): Mark local as volatile if checking for lint,
4182 to suppress a gcc -Wclobbered warning that does not seem to be right.
4183 (MAXPATHLEN): Define only if needed.
4185 * process.c (serial_open, serial_configure): Move decls from here ...
4186 * systty.h: ... to here, so that they can be checked.
4188 * fns.c (get_random, seed_random): Move extern decls from here ...
4189 * lisp.h: ... to here, so that they can be checked.
4191 * sysdep.c (reset_io): Now static.
4192 (wait_for_termination_signal): Remove; unused.
4194 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4195 (copy_keymap_item, append_key, push_text_char_description):
4197 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4198 (DENSE_TABLE_SIZE): Remove; unused.
4199 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4200 (describe_map_tree):
4201 Rename locals to avoid shadowing.
4203 * keyboard.c: Declare functions static if they are not used elsewhere.
4204 (echo_char, echo_dash, cmd_error, top_level_2):
4205 (poll_for_input, handle_async_input): Now static.
4206 (read_char, kbd_buffer_get_event, make_lispy_position):
4207 (make_lispy_event, make_lispy_movement, apply_modifiers):
4208 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4209 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4210 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4211 (read_key_sequence, read_char): Mark locals as initialized.
4212 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4214 * keyboard.h (make_ctrl_char): New decl.
4215 (mark_kboards): Move decl here ...
4216 * alloc.c (mark_kboards): ... from here.
4218 * lisp.h (force_auto_save_soon): New decl.
4220 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4221 (DEFINE_DUMMY_FUNCTION): New macro.
4222 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4224 (main): Add casts to avoid warnings
4225 if GCC considers string literals to be constants.
4227 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4229 * dbusbind.c: Pointer signedness fixes.
4230 (xd_signature, xd_append_arg, xd_initialize):
4231 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4232 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4233 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4234 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4236 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4237 if GCC considers string literals to be constants.
4238 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4240 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4242 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4243 (print_preprocess, print_object): New macro to fix last change.
4245 * print.c (print_preprocess): Don't forget font objects.
4247 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4249 * emacs.c (USAGE3): Doc fixes.
4251 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4253 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4256 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4258 * lisp.h (VWindow_system, Qfile_name_history):
4259 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4260 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4261 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4263 * w32select.c: Don't #include "keyboard.h".
4264 (run_protected): Add extern declaration for waiting_for_input.
4266 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4267 * w32console.c (detect_input_pending, read_input_pending)
4268 (encode_terminal_code):
4269 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4270 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4271 (w32_system_caret_y, Qfile_name_history):
4272 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4273 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4274 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4275 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4276 * w32proc.c (Qlocal, report_file_error):
4277 * w32term.c (Vwindow_system, updating_frame):
4278 * w32uniscribe.c (initialized, uniscribe_font_driver):
4279 Remove unneeded extern declarations.
4281 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4283 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4285 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4287 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4288 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4289 These macros can no longer be used for assignment.
4291 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4292 Assign struct members directly, instead of using BUF_BEGV etc.
4293 (record_buffer_markers, fetch_buffer_markers): New functions for
4294 recording and fetching special buffer markers.
4295 (set_buffer_internal_1, set_buffer_temp): Use them.
4297 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4299 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4301 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4302 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4304 * xdisp.c (hscroll_window_tree):
4305 (reconsider_clip_changes): Use PT instead of BUF_PT.
4307 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4309 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4310 $(EMACS_ROOT)/lib/intprops.h.
4312 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4314 Fix more problems found by GCC 4.5.2's static checks.
4316 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4317 to unsigned char * to avoid compiler diagnostic.
4318 (xg_free_frame_widgets): Make it clear that a local variable is
4319 needed only if USE_GTK_TOOLTIP.
4320 (gdk_window_get_screen): Make it clear that this macro is needed
4321 only if USE_GTK_TOOLTIP.
4322 (int_gtk_range_get_value): New function, which avoids a diagnostic
4323 from gcc -Wbad-function-cast.
4324 (xg_set_toolkit_scroll_bar_thumb): Use it.
4325 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4326 diagnostic from gcc -Wbad-function-cast.
4327 (get_utf8_string, xg_get_file_with_chooser):
4328 Rename locals to avoid shadowing.
4329 (create_dialog): Move locals to avoid shadowing.
4331 * xgselect.c (xg_select): Remove unused var.
4333 * image.c (four_corners_best): Mark locals as initialized.
4334 (gif_load): Initialize transparent_p to zero (Bug#8238).
4335 Mark another local as initialized.
4336 (my_png_error, my_error_exit): Mark with NO_RETURN.
4338 * image.c (clear_image_cache): Now static.
4339 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4340 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4341 (x_edge_detection): Remove unnecessary cast that
4342 gcc -Wbad-function-cast diagnoses.
4343 (gif_load): Fix pointer signedness.
4344 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4345 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4347 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4349 Improve quality of tests for time stamp overflow.
4350 For example, without this patch (encode-time 0 0 0 1 1
4351 1152921504606846976) returns the obviously-bogus value (-948597
4352 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4353 reports time overflow. See
4354 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4355 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4356 * editfns.c: Include limits.h and intprops.h.
4357 (TIME_T_MIN, TIME_T_MAX): New macros.
4358 (time_overflow): Move earlier, to before first use.
4359 (hi_time, lo_time): New functions, for an accurate test for
4361 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4362 (Fget_internal_run_time): Don't assume time_t fits in int.
4363 (make_time): Use list2 instead of Fcons twice.
4364 (Fdecode_time): More accurate test for out-of-range times.
4365 (check_tm_member): New function.
4366 (Fencode_time): Use it, to test for out-of-range times.
4367 (lisp_time_argument): Don't rely on undefined left-shift and
4368 right-shift behavior when checking for time stamp overflow.
4370 * editfns.c (time_overflow): New function, refactoring common code.
4371 (Fformat_time_string, Fdecode_time, Fencode_time):
4372 (Fcurrent_time_string): Use it.
4374 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4375 * dired.c (make_time): Move to ...
4376 * editfns.c (make_time): ... here.
4377 * systime.h: Note the move.
4379 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4381 * fringe.c (update_window_fringes): Remove unused variables.
4383 * unexmacosx.c (copy_data_segment): Also copy __got section.
4386 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4388 * termcap.c [MSDOS]: Include "msdos.h".
4389 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4390 Constify `char *' arguments and their references according to
4391 prototypes in tparam.h.
4393 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4395 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4396 Adapt all references accordingly.
4398 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4400 2011-03-11 Tom Tromey <tromey@redhat.com>
4402 * buffer.c (syms_of_buffer): Remove obsolete comment.
4404 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4406 * termhooks.h (encode_terminal_code): Declare prototype.
4408 * msdos.c (encode_terminal_code): Don't declare prototype.
4410 * term.c (encode_terminal_code): Now external again, used by
4411 w32console.c and msdos.c.
4413 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4414 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4416 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4418 Fix some minor problems found by GCC 4.5.2's static checks.
4420 * fringe.c (update_window_fringes): Mark locals as initialized
4422 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4424 * alloc.c (mark_fringe_data): Move decl from here ...
4425 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4426 to check its interface.
4427 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4429 * fontset.c (free_realized_fontset): Now static.
4430 (Fset_fontset_font): Rename local to avoid shadowing.
4431 (fontset_font): Mark local as initialized.
4432 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4434 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4436 * xselect.c (x_disown_buffer_selections): Remove; not used.
4437 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4438 (x_own_selection, Fx_disown_selection_internal): Rename locals
4440 (x_handle_dnd_message): Remove local to avoid shadowing.
4442 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4443 so that the caller can use some name other than gcpro1.
4444 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4445 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4446 (Fx_backspace_delete_keys_p):
4447 Use them to avoid shadowing, and rename vars to avoid shadowing.
4448 (x_decode_color, x_set_name, x_window): Now static.
4449 (Fx_create_frame): Add braces to silence GCC warning.
4450 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4451 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4452 Remove unused locals.
4453 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4454 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4455 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4458 * xterm.h (x_mouse_leave): New decl.
4460 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4461 Remove unused functions.
4462 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4463 (x_calc_absolute_position): Now static.
4464 (XTread_socket): Don't define label "out" unless it's used.
4465 Don't declare local "event" unless it's used.
4466 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4467 unless they are used.
4468 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4469 (x_fatal_error_signal): Remove; not used.
4470 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4471 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4472 (x_error_catcher, x_connection_closed, x_error_handler):
4473 (x_error_quitter, xembed_send_message, x_iconify_frame):
4474 (my_log_handler): Rename locals to avoid shadowing.
4475 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4476 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4478 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4479 Rename or move locals to avoid shadowing.
4480 (tty_defined_color, merge_face_heights): Now static.
4481 (free_realized_faces_for_fontset): Remove; not used.
4482 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4483 does not deduce is never used uninitialized.
4484 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4485 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4487 * terminal.c (store_terminal_param): Now static.
4489 * xmenu.c (menu_highlight_callback): Now static.
4490 (set_frame_menubar): Remove unused local.
4491 (xmenu_show): Rename parameter to avoid shadowing.
4492 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4493 since they might point to immutable storage.
4494 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4495 since it's unused otherwise.
4497 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4498 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4499 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4500 avoids a gcc -Wuninitialized diagnostic.
4501 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4502 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4503 does not deduce are never used uninitialized.
4505 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4507 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4508 * window.c (window_loop, size_window):
4509 (run_window_configuration_change_hook, enlarge_window): Likewise.
4511 * window.c (display_buffer): Now static.
4512 (size_window): Mark variables that gcc -Wuninitialized
4513 does not deduce are never used uninitialized.
4514 * window.h (check_all_windows): New decl, to forestall
4515 gcc -Wmissing-prototypes diagnostic.
4516 * dispextern.h (bidi_dump_cached_states): Likewise.
4518 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4520 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4522 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4523 and to avoid gcc -Wuninitialized warning.
4524 (load_charset_map): Mark variables that gcc -Wuninitialized
4525 does not deduce are never used uninitialized.
4526 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4528 * coding.c (coding_set_source, coding_set_destination):
4529 Use "else { /* comment */ }" rather than "else /* comment */;"
4530 for clarity, and to avoid gcc -Wempty-body warning.
4531 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4532 a block, when the outer 'i' will do.
4533 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4534 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4535 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4536 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4537 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4538 Rename locals to avoid shadowing.
4539 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4540 * coding.c (emacs_mule_char, encode_invocation_designation):
4541 Now static, since they're not used elsewhere.
4542 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4543 (decode_coding_object, encode_coding_object, detect_coding_system):
4544 (decode_coding_emacs_mule): Mark variables that gcc
4545 -Wuninitialized does not deduce are never used uninitialized.
4546 (detect_coding_iso_2022): Initialize a local variable that might
4547 be used uninitialized. Leave a FIXME because it's not clear that
4548 this initialization is needed. (Bug#8211)
4549 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4550 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4551 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4552 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4553 Remove unused macros.
4555 * category.c (hash_get_category_set): Remove unused local var.
4556 (copy_category_table): Now static, since it's not used elsewhere.
4557 * character.c (string_count_byte8): Likewise.
4559 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4560 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4562 * chartab.c (copy_sub_char_table): Now static, since it's not used
4564 (sub_char_table_ref_and_range, char_table_ref_and_range):
4565 Rename locals to avoid shadowing.
4566 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4568 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4569 (BIDI_BOB): Remove unused macro.
4571 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4572 deduce are never used uninitialized.
4573 * term.c (encode_terminal_code): Likewise.
4575 * term.c (encode_terminal_code): Now static. Remove unused local.
4577 * tparam.h: New file.
4578 * term.c, tparam.h: Include it.
4579 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4580 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4581 Move these decls to tparam.h, and make them agree with what
4582 is actually in tparam.c. The previous trick of using incompatible
4583 decls in different modules does not conform to the C standard.
4584 All callers of tparam changed to use tparam's actual API.
4585 * tparam.c (tparam1, tparam, tgoto):
4586 Use const pointers where appropriate.
4588 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4589 * cm.h (struct cm): Likewise.
4590 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4591 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4592 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4593 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4594 (turn_on_face, init_tty): Likewise.
4595 * termchar.h (struct tty_display_info): Likewise.
4597 * term.c (term_mouse_position): Rename local to avoid shadowing.
4599 * alloc.c (mark_ttys): Move decl from here ...
4600 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4602 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4604 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4606 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4608 * search.c (compile_pattern_1): Remove argument regp, unused since
4609 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4610 (compile_pattern): Don't pass it.
4612 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4614 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4615 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4617 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4619 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4621 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4622 gdk_window_get_screen, gdk_window_get_geometry,
4623 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4624 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4625 (xg_get_pixbuf_from_pixmap): New function.
4626 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4627 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4628 Call xg_get_pixbuf_from_pixmap instead of
4629 gdk_pixbuf_get_from_drawable.
4630 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4631 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4632 (xg_check_special_colors): Use GtkStyleContext and its functions
4634 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4635 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4636 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4637 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4638 Call gtk_widget_get_preferred_size.
4639 (xg_frame_resized): gdk_window_get_geometry only takes 5
4641 (xg_win_to_widget, xg_event_is_for_menubar):
4642 Call gdk_x11_window_lookup_for_display.
4643 (xg_set_widget_bg): New function.
4644 (delete_cb): New function.
4645 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4646 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4647 (xg_set_background_color): Call xg_set_widget_bg.
4648 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4649 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4650 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4651 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4653 (update_frame_tool_bar): Call gtk_widget_hide.
4654 (xg_initialize): Use GDK_KEY_g.
4656 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4658 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4660 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4661 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4662 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4664 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4666 * w32xfns.c (select_palette): Check success of RealizePalette against
4667 GDI_ERROR, not zero.
4669 See ChangeLog.11 for earlier changes.
4675 Copyright (C) 2011 Free Software Foundation, Inc.
4677 This file is part of GNU Emacs.
4679 GNU Emacs is free software: you can redistribute it and/or modify
4680 it under the terms of the GNU General Public License as published by
4681 the Free Software Foundation, either version 3 of the License, or
4682 (at your option) any later version.
4684 GNU Emacs is distributed in the hope that it will be useful,
4685 but WITHOUT ANY WARRANTY; without even the implied warranty of
4686 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4687 GNU General Public License for more details.
4689 You should have received a copy of the GNU General Public License
4690 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.