1 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
3 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
8 2012-06-29 Eli Zaretskii <eliz@gnu.org>
10 * xdisp.c (try_window_id): Undo last change.
12 * w32.c (getwd): Adjust commentary about startup_dir.
13 (init_environment): Always call sys_access, even in non-MSVC
14 builds. Don't chdir to the directory of the Emacs executable.
15 This undoes code from 1997 which was justified by the need to
16 "avoid conflicts when removing and renaming directories". But its
17 downside was that every relative file name was being interpreted
18 relative to the directory of the Emacs executable, which can never
19 be TRT. In particular, it broke sys_access when called with
21 (sys_access): Map GetLastError to errno.
23 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
25 * window.h (struct window): Change type of 'fringes_outside_margins'
26 to bitfield. Fix comment. Adjust users accordingly.
27 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
29 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
32 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
34 * gnutls.c (emacs_gnutls_handshake):
35 Add QUIT to make the loop interruptible.
37 2012-06-29 Glenn Morris <rgm@gnu.org>
39 * charset.c (init_charset): Make lack of etc/charsets fatal.
41 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
43 * editfns.c (region_limit): Fix type mismatch.
45 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
47 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
48 undefined. Convert from xassert to eassert.
49 * nsmenu.m: Convert from xassert to eassert.
52 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
54 * editfns.c (region_limit): Clip to narrowing (bug#11770).
56 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
58 Avoid integer overflow on scroll-left and scroll-right.
59 * window.c (HSCROLL_MAX): New macro.
60 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
61 overflow when requested scroll falls outside ptrdiff_t range.
63 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
65 * window.h (struct window): Change type of 'hscroll',
66 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
67 'last_modified' and 'last_overlay_modified' to EMACS_INT.
68 Adjust users accordingly.
69 * xdisp.c (try_cursor_movement): Replace type check with eassert.
70 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
71 from EMACS_INT to ptrdiff_t.
72 (make_window): Omit redundant initialization.
74 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
76 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
78 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
80 * window.h (struct window): Change type of 'use_time' and
81 'sequence_number' from Lisp_Object to int.
82 * frame.c (make_frame): Adjust users accordingly.
83 * print.c (print_object): Likewise.
84 * window.c (select_window, Fwindow_use_time, make_parent_window)
85 (make_window): Likewise.
87 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
89 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
90 enabled with --enable-checking=[all,glyphs] configure option.
91 Fix GLYPH_DEBUG usage assuming that it may be undefined,
92 adjust comments accordingly.
93 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
94 undefined, adjust comments accordingly.
98 * w32term.c: Likewise.
100 * xfaces.c: Likewise.
104 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
106 Generalize run-time debugging checks.
107 * dispextern.h (XASSERTS): Remove.
108 * fontset.c (xassert): Remove.
109 Convert from xassert to eassert.
110 * alloc.c: Convert from xassert to eassert.
112 * dispnew.c: Likewise.
114 * fringe.c: Likewise.
115 * ftfont.c: Likewise.
116 * gtkutil.c: Likewise.
118 * keyboard.c: Likewise.
120 * process.c: Likewise.
121 * scroll.c: Likewise.
124 * w32console.c: Likewise.
125 * w32fns.c: Likewise.
126 * w32term.c: Likewise.
127 * window.c: Likewise.
129 * xfaces.c: Likewise.
131 * xselect.c: Likewise.
134 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
136 * fns.c (maybe_resize_hash_table): Output message when growing the
139 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
141 * alloc.c (allocate_string_data): Remove dead code.
142 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
143 avoid GCC warning about unused macro.
145 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
147 * alloc.c (allocate_string): Omit intervals initialization.
148 * alloc.c (make_uninit_multibyte_string): Initialize intervals
149 as in make_pure_string and make_pure_c_string.
151 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
153 * alloc.c (allocate_string): Fix last change.
155 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
157 * alloc.c (allocate_string): Remove two redundant calls
158 to memset, add explicit initialization where appropriate.
160 2012-06-27 Glenn Morris <rgm@gnu.org>
162 * lisp.mk (lisp): Remove paths.elc.
164 2012-06-27 Chong Yidong <cyd@gnu.org>
166 * doc.c (Fsubstitute_command_keys): Fix punctuation.
168 2012-06-26 John Wiegley <johnw@newartisans.com>
170 * unexmacosx.c (copy_data_segment): Add two section names used
171 on Mac OS X Lion: __mod_init_func and __mod_term_func.
173 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
174 when building with Clang.
176 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
178 * eval.c (Fapply): Allow calling it with a single argument.
180 2012-06-26 Eli Zaretskii <eliz@gnu.org>
182 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
183 _stricmp and _strnicmp.
184 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
186 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
188 * alloc.c (allocate_window): Zero out non-Lisp part of newly
190 (allocate_process): Likewise for new process.
191 (allocate_terminal): Change to use offsetof.
192 (allocate_frame): Likewise.
193 * frame.c (make_frame): Omit redundant initialization.
194 * window.c (make_parent_window): Use memset.
195 (make_window): Omit redundant initialization.
196 * process.c (make_process): Omit redundant initialization.
197 * terminal.c (create_terminal): Likewise.
199 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
201 * term.c (delete_tty): Remove redundant call to memset.
203 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
205 * alloc.c: Remove build_string.
206 * lisp.h: Define build_string as static inline. This provides
207 a better opportunity to optimize away calls to strlen when the
208 function is called with compile-time constant argument.
209 * image.c (imagemagick_error): Convert to build_string.
210 * w32proc.c (sys_spawnve): Likewise.
211 * xterm.c (x_term_init): Likewise.
213 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
215 Use sprintf return value instead of invoking strlen on result.
216 In the old days this wasn't portable, since some sprintf
217 implementations returned char *. But they died out years ago and
218 Emacs already assumes sprintf returns int.
219 Similarly for float_to_string.
220 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
221 * ccl.c (ccl_driver):
222 * character.c (string_escape_byte8):
223 * data.c (Fnumber_to_string):
225 * print.c (print_object):
226 * xdisp.c (message_dolog):
227 * xfns.c (syms_of_xfns):
228 Use sprintf or float_to_string result to avoid need to call strlen.
229 * data.c (Fnumber_to_string):
230 Use make_unibyte_string, since the string must be ASCII.
231 * lisp.h, print.c (float_to_string): Now returns int length.
232 * term.c (produce_glyphless_glyph):
233 Use sprintf result rather than recomputing it.
235 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
236 * Makefile.in (ALL_CFLAGS):
237 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
238 * gmalloc.c, regex.c: Include <config.h> unconditionally.
240 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
242 * dispextern.h (xstrcasecmp): Define to library function
243 strcasecmp if available.
244 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
246 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
248 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
249 Avoid comma operator.
250 * menu.c (push_submenu_start, push_submenu_end)
251 (push_left_right_boundary, push_menu_pane): Likewise.
252 * msdos.c (dos_rawgetc): Likewise.
254 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
256 * xfns.c (xic_create_fontsetname): Remove redundant calls
259 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
261 * gtkutil.c (get_utf8_string): Remove redundant assignment.
262 sprintf already null-terminates its output.
264 * xfns.c (x_window): Remove redundant cast.
266 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
268 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
269 `const char *' to `char *' to avoid compiler warning.
271 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
273 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
274 instead of truncating it to 63 (admittedly a generous limit).
276 * process.c: Fix spelling and caps in comments.
278 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
280 * emacs.c (setpgrp): Remove definition, unused.
281 * sysdep.c (setpgrp): Remove definition, not used in this file.
283 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
285 * makefile.w32-in: Update dependencies.
287 2012-06-24 Eli Zaretskii <eliz@gnu.org>
289 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
290 (SYSTIME_H): Add nt/inc/sys/time.h.
292 * systime.h [WINDOWSNT]: Include sys/time.h.
294 * s/ms-w32.h (struct timespec): Definition moved from
295 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
297 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
299 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
300 * buffer.h (buffer_slot_type_mismatch):
301 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
302 * eval.c (unwind_to_catch):
303 * image.c (my_png_error, my_error_exit):
304 * keyboard.c (quit_throw_to_read_char, user_error)
305 (Fexit_recursive_edit, Fabort_recursive_edit):
306 * lisp.h (die, args_out_of_range, args_out_of_range_3)
307 (wrong_type_argument, buffer_overflow, __executable_start)
308 (memory_full, buffer_memory_full, string_overflow, Fthrow)
309 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
310 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
312 (child_setup) [!DOS_NT]:
313 * lread.c (end_of_file_error, invalid_syntax):
314 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
315 * puresize.h (pure_write_error):
316 * search.c (matcher_overflow):
317 * sound.c (sound_perror, alsa_sound_perror):
318 * sysdep.c, syssignal.h (croak):
319 * term.c (maybe_fatal, vfatal):
320 * textprop.c (text_read_only):
321 * undo.c (user_error):
322 * unexmacosx.c (unexec_error):
323 * xterm.c (x_ins_del_lines, x_delete_glyphs):
324 Use _Noreturn rather than NO_RETURN.
325 No need for separate decl merely because of _Noreturn.
326 * sound.c (sound_warning, parse_sound):
327 Remove unnecessary forward decls.
329 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
331 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
332 * lisp.h (WAIT_READING_MAX): New macro.
333 * dispnew.c (Fsleep_for, sit_for):
334 * keyboard.c (kbd_buffer_get_event):
335 * process.c (Faccept_process_output):
336 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
337 This improves on the previous patch, which introduced a bug
338 when time_t is unsigned and as wide as intmax_t.
339 See <http://bugs.gnu.org/9000#51>.
341 2012-06-23 Eli Zaretskii <eliz@gnu.org>
343 * dispnew.c (sit_for, Fsleep_for):
344 * keyboard.c (kbd_buffer_get_event):
345 * process.c (Faccept_process_output): Avoid compiler warnings when
346 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
348 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
350 * makefile.w32-in: Update dependencies.
352 * w32.c (ltime): Add return type and declare static.
353 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
355 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
357 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
358 Privately reported by Herbert J. Skuhra.
359 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
361 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
362 not make_lisp_timeval, when the argument is of type EMACS_TIME.
364 2012-06-23 Eli Zaretskii <eliz@gnu.org>
366 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
367 last argument of make_unibyte_string.
369 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
370 language ID in the event parameters.
372 * w32term.c (w32_read_socket): Put the new keyboard codepage into
373 event.code, not the obscure "character set ID".
375 2012-06-23 Chong Yidong <cyd@gnu.org>
377 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
379 2012-06-23 Eli Zaretskii <eliz@gnu.org>
381 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
382 * w32.c (fdutimens): New function.
384 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
386 * s/ms-w32.h (pselect): Redirect to sys_select.
388 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
390 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
391 in the logic of incrementing and decrementing the value of
392 use_relocatable_buffers.
394 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
396 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
397 Privately reported by Herbert J. Skuhra.
398 [__FreeBSD__]: Remove "*/" typo after "#include".
399 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
400 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
401 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
402 Don't assume EMACS_TIME and struct timeval are the same type.
404 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
406 Support higher-resolution time stamps (Bug#9000).
407 The time stamps are only nanosecond-resolution at the C level,
408 since that's the best that any real-world system supports now.
409 But they are picosecond-resolution at the Lisp level, as that's
410 easy, and leaves room for future OS improvements.
412 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
415 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
416 Don't get current time unless it's needed.
418 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
419 now provides it if it's absent.
420 (start_atimer): Port to higher-res time stamps.
421 Check for time stamp overflow. Don't get current time more
422 often than is needed.
424 * buffer.h (struct buffer): Buffer modtime now has high resolution.
425 Include systime.h, not time.h.
426 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
428 * dired.c: Include stat-time.h.
429 (Ffile-attributes): File times now have higher resolution.
431 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
432 (struct image): Timestamp now has higher resolution.
434 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
435 has at least microseconds now. All uses removed.
436 (update_frame, update_single_window, update_window, update_frame_1)
437 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
439 * editfns.c (time_overflow): Now extern.
440 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
441 (float-time, Fformat_time_string, Fcurrent_time_string)
442 (Fcurrent_time_zone): Accept and generate higher-resolution
444 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
445 (decode_time_components, lisp_seconds_argument): New functions.
446 (make_time): Now static.
447 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
448 Report an error if the time is invalid, rather than having the caller
451 * fileio.c: Include <stat-time.h>
452 (Fcopy_file): Copy higher-resolution time stamps.
453 Prefer to set the time stamp via a file descriptor if that works.
454 (Fset_file_times, Finsert_file_contents, Fwrite_region)
455 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
456 (Fvisited_file_modtime, Fset_visited_file_modtime):
457 Support higher-resolution time stamps.
459 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
461 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
463 * image.c (prepare_image_for_display, clear_image_cache)
464 (lookup_image): Port to higer-resolution time stamps.
466 * keyboard.c (start_polling, bind_polling_period):
467 Check for time stamp overflow.
468 (read_char, kbd_buffer_get_event, timer_start_idle)
469 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
470 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
471 Port to higher-resolution time stamps. Do not assume time_t is signed.
472 (decode_timer): New function. Timers are now vectors of length 9,
473 not 8, to accommodate the picosecond component.
474 (timer_check_2): Use it.
476 * nsterm.m (select_timeout, timeval_subtract): Remove.
477 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
478 as they're a bit more accurate and handle overflow better.
479 (ns_select): Change prototype to be compatible with pselect.
480 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
481 * nsterm.h (ns_select): Adjust prototype.
483 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
484 us-resolution time stamps.
485 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
487 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
489 * lisp.h (time_overflow): New decl.
490 (wait_reading_process_output): First arg is now intmax_t, not int,
491 to accommodate larger waits.
493 * process.h (struct Lisp_Process.read_output_delay):
494 Now counts nanoseconds, not microseconds.
495 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
497 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
498 (wait_reading_process_output):
499 Port to ns-resolution time stamps.
500 (Faccept_process_output, wait_reading_process_output):
501 Check for time stamp overflow. Do not assume time_t is signed.
502 (select_wrapper): Remove; we now use pselect.
503 (Fprocess_attributes): Now generates ns-resolution time stamps.
505 * sysdep.c: Include utimens.h. Don't include utime.h
506 or worry about struct utimbuf; gnulib does that for us now.
507 (gettimeofday): Remove; gnulib provides a substitute.
508 (make_timeval): New function.
509 (set_file_times): Now sets ns-resolution time stamps.
510 New arg FD; all uses changed.
511 (time_from_jiffies, ltime_from_jiffies, get_up_time)
512 (system_process_attributes):
513 Now returns ns-resolution time stamp. All uses changed.
514 Check for time stamp overflow.
516 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
517 provides a substitute now.
519 * systime.h: Include timespec.h rather than sys/time.h and time.h,
520 since it guarantees struct timespec.
521 (EMACS_TIME): Now struct timespec, so that we can support
522 ns-resolution time stamps.
523 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
524 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
525 (EMACS_USECS): Remove.
526 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
527 so multiply the arg by 1000 before storing it.
528 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
530 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
531 Port to ns-resolution time stamps.
532 (EMACS_TIME_NEG_P): Remove; replaced by....
533 (EMACS_TIME_SIGN): New macro.
534 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
535 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
536 (set_file_times, make_time, lisp_time_argument): Adjust signature.
537 (make_timeval, make_lisp_time, decode_time_components): New decls.
538 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
539 that it mishandled time_t overflow. You can't compare by subtracting!
540 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
541 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
543 * term.c: Include <sys/time.h>.
544 (timeval_to_Time): New function, for proper overflow wraparound.
545 (term_mouse_position, term_mouse_click): Use it.
547 * undo.c (record_first_change): Support higher-resolution time stamps
549 (Fprimitive_undo): Use them when restoring time stamps.
551 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
552 (w32_get_internal_run_time):
553 Port to higher-resolution Emacs time stamps.
554 (ltime): Now accepts single 64-bit integer, as that's more convenient
557 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
559 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
560 for compatibility with pselect. Support ns-resolution time stamps.
562 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
564 * xselect.c (wait_for_property_change, x_get_foreign_selection):
565 Check for time stamp overflow, and support ns-resolution time stamps.
567 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
568 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
569 (timeval_subtract): Remove; no longer needed.
570 (XTflash, XTring_bell, x_wait_for_event):
571 Port to ns-resolution time stamps. Don't assume time_t is signed.
573 2012-06-22 Chong Yidong <cyd@gnu.org>
575 * xdisp.c (x_consider_frame_title): Revert last change.
577 2012-06-22 Eli Zaretskii <eliz@gnu.org>
579 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
580 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
581 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
582 staticidx goes up to 1597 out of 1600 = 0x640.)
584 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
586 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
587 Otherwise, the umask might be mistakenly 0 while handling input signals.
589 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
591 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
593 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
595 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
596 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
597 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
598 access to `contents' member of Lisp_Vector objects with AREF and ASET
601 2012-06-19 Chong Yidong <cyd@gnu.org>
603 * frame.c (delete_frame): When selecting a frame on a different
604 text terminal, do not alter the terminal's top-frame.
606 * xdisp.c (format_mode_line_unwind_data): Record the target
607 frame's selected window and its terminal's top-frame.
608 (unwind_format_mode_line): Restore them.
609 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
611 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
612 since tty frames can be explicitly named.
613 (prepare_menu_bars): Likewise.
615 * term.c (Ftty_top_frame): New function.
617 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
619 Port byte-code-meter to modern targets.
620 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
621 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
622 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
623 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
624 (METER_1, METER_2): Simplify.
626 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
628 * data.c (Fdefalias): Return `symbol' (bug#11686).
630 2012-06-18 Martin Rudalics <rudalics@gmx.at>
632 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
633 gets killed during executing of this function (Bug#11665).
634 Try to always return Qt when the buffer has been actually killed.
635 (Vkill_buffer_query_functions): In doc-string say that functions
636 run by this hook should not change the current buffer.
638 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
640 Fix recently-introduced process.c problems found by static checking.
641 * process.c (write_queue_push, write_queue_pop, send_process):
642 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
643 (write_queue_pop): Fix pointer signedness problem.
644 (send_process): Remove unused local.
646 2012-06-17 Chong Yidong <cyd@gnu.org>
648 * xdisp.c (redisplay_internal): No need to redisplay terminal
649 frames that are not on top.
651 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
653 * process.c (make_process): Initialize write_queue.
654 (write_queue_push, write_queue_pop): New functions.
655 (send_process): Use them to maintain correct ordering of process
658 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
660 * lisp.h (eassert): Assume C89 or later.
661 This removes the need for CHECK.
662 (CHECK): Remove. Its comments about always evaluating its
663 argument were confusing, as 'eassert' typically does not evaluate
666 * coding.c (produce_chars): Use ptrdiff_t, not int.
668 * xterm.c (x_draw_underwave): Check for integer overflow.
669 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
671 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
673 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
674 referenced (Bug#11583).
676 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
678 Implement wave-style variant of underlining.
679 * dispextern.h (face_underline_type): New enum.
680 (face): Add field for underline type.
681 * nsterm.m (ns_draw_underwave): New function.
682 (ns_draw_text_decoration): Use it.
683 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
685 (x_draw_glyph_string): Use them.
686 * xfaces.c (Qline, Qwave): New Lisp objects.
687 (check_lface_attrs, merge_face_ref)
688 (Finternal_set_lisp_face_attribute, realize_x_face):
689 Handle wave-style underline face attributes.
690 * xterm.c (x_draw_underwave): New function.
691 (x_draw_glyph_string): Use it.
693 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
695 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
696 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
697 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
698 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
699 ($(BLD)/w32select.$(O)): Update dependencies.
701 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
703 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
704 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
705 * character.c (_fetch_multibyte_char_p): Remove.
706 * alloc.c: Include "character.h" before "buffer.h".
708 * buffer.c: Likewise.
709 * bytecode.c: Likewise.
710 * callint.c: Likewise.
711 * callproc.c: Likewise.
712 * casefiddle.c: Likewise.
713 * casetab.c: Likewise.
714 * category.c: Likewise.
716 * coding.c: Likewise.
717 * composite.c: Likewise.
719 * dispnew.c: Likewise.
721 * dosfns.c: Likewise.
722 * editfns.c: Likewise.
724 * fileio.c: Likewise.
725 * filelock.c: Likewise.
727 * fontset.c: Likewise.
728 * fringe.c: Likewise.
729 * indent.c: Likewise.
730 * insdel.c: Likewise.
731 * intervals.c: Likewise.
732 * keyboard.c: Likewise.
733 * keymap.c: Likewise.
735 * macros.c: Likewise.
736 * marker.c: Likewise.
737 * minibuf.c: Likewise.
739 * nsmenu.m: Likewise.
741 * process.c: Likewise.
743 * region-cache.c: Likewise.
744 * search.c: Likewise.
745 * syntax.c: Likewise.
747 * textprop.c: Likewise.
749 * unexsol.c: Likewise.
750 * w16select.c: Likewise.
751 * w32fns.c: Likewise.
752 * w32menu.c: Likewise.
753 * window.c: Likewise.
758 * xselect.c: Likewise.
760 2012-06-16 Eli Zaretskii <eliz@gnu.org>
762 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
763 If all the glyphs of the glyph row came from strings, and we have no
764 cursor positioning clues, put the cursor on the first glyph of the
766 (handle_face_prop): Use chunk-relative overlay string index when
767 indexing into it->string_overlays array. (Bug#11653)
768 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
769 the rightmost. (Bug#11720)
771 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
773 * category.h (CHAR_HAS_CATEGORY): Define as inline.
774 (CATEGORY_MEMBER): Enforce 1/0 value.
775 * category.c (_temp_category_set): Remove.
777 2012-06-16 Eli Zaretskii <eliz@gnu.org>
779 * window.c (Fdelete_other_windows_internal)
780 (Fdelete_window_internal): Don't access frame's mouse highlight
781 info of the initial frame. (Bug#11677)
783 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
785 * .gdbinit (xgetint): Fix recently-introduced paren typo.
786 Assume USE_2_TAGS_FOR_INTS.
787 (xreload): Adjust $tagmask width to match recent lisp.h change.
789 Simplify lisp.h in minor ways that should not affect code.
790 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
791 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
792 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
793 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
794 (INTTYPEBITS): New macro, for clarity.
795 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
796 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
797 Simplify now that USE_LSB_TAG is always defined.
798 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
799 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
801 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
803 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
805 2012-06-13 Glenn Morris <rgm@gnu.org>
807 * s/bsd-common.h (BSD4_3):
808 * s/usg5-4-common.h (USG5_4): No longer define; unused.
810 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
812 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
815 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
817 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
818 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
819 * alloc.c (widen_to_Lisp_Object): Remove.
820 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
821 * frame.c (delete_frame): Remove outdated comment.
822 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
824 (Fw32_unregister_hot_key): Likewise.
825 (Fw32_toggle_lock_key): Likewise.
826 * w32menu.c (add_menu_item): Likewise.
827 (w32_menu_display_help): Use XIL instead of checking
829 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
830 (init_heap): Likewise.
831 * w32term.c (w32_read_socket): Update comment.
833 2012-06-13 Glenn Morris <rgm@gnu.org>
835 * s/usg5-4-common.h, src/s/unixware.h:
836 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
838 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
840 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
842 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
843 * alloc.c (make_number) [!defined make_number]:
844 Remove, as lisp.h always defines this now.
845 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
846 (roundup_size): Verify that it is a power of 2.
847 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
848 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
849 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
850 -DUSE_LSB_TAG=0, to override the automatically-selected default.
851 USE_LSB_TAG now is always defined to be either 0 or 1.
853 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
854 code works fine either way, and efficiency is not a concern here,
855 as the union type is for debugging, not for production.
856 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
857 Use an inline function on all platforms when using the union type,
858 since this is simpler and 'static inline' can be used portably
860 (LISP_INITIALLY_ZERO): New macro.
861 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
862 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
864 2012-06-12 Glenn Morris <rgm@gnu.org>
866 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
868 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
870 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
871 Move BROKEN_SIGIO to configure.
873 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
874 Move NO_TERMIO to configure.
876 2012-06-12 Chong Yidong <cyd@gnu.org>
878 * image.c (imagemagick_load_image): Use MagickFlattenImage if
879 MagickMergeImageLayers is undefined. Use pixel pusher loop if
880 MagickExportImagePixels is undefined.
882 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
884 * image.c (imagemagick_load_image): Remove unused label.
886 2012-06-11 Glenn Morris <rgm@gnu.org>
888 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
889 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
890 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
891 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
893 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
895 * alloc.c (make_byte_code): New function.
896 (Fmake_byte_code): Use it. Don't purify here.
897 * lread.c (read1): Use it as well to avoid extra allocation.
899 2012-06-11 Chong Yidong <cyd@gnu.org>
901 * image.c (imagemagick_load_image): Implement transparency.
903 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
905 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
906 account for preceding backslashes. (Bug#11663)
908 2012-06-09 Chong Yidong <cyd@gnu.org>
910 * term.c: Support italics in capable terminals (Bug#9652).
911 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
912 (turn_on_face): Output using TS_enter_italic_mode if available.
913 Don't handle unused blinking and alt-charset cases.
914 (turn_off_face): Handle italic case; discard unused tty_blinking_p
915 and tty_alt_charset_p cases.
916 (tty_capable_p, init_tty): Support italics.
918 * termchar.h (struct tty_display_info): Add field for italics.
919 Remove unused blink field.
921 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
924 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
925 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
926 tty_alt_charset_p. Add tty_italic_p.
928 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
930 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
931 dbus_type_is_basic if available.
932 (xd_extract_signed, xd_extract_unsigned): Rename from
933 extract_signed and extract_unsigned, respectively. Adapt callers.
935 2012-06-09 Chong Yidong <cyd@gnu.org>
937 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
939 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
942 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
944 * xdisp.c (vmessage): Treat frame message as multibyte.
945 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
946 would generate the diagnostic "Making \302\247 buffer-local while
949 2012-06-08 Eli Zaretskii <eliz@gnu.org>
951 * dispnew.c (showing_window_margins_p): Undo last change, which
952 was done due to an inadvertent commit.
953 (adjust_frame_glyphs_for_frame_redisplay): Do call
954 showing_window_margins_p.
956 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
958 * eval.c (Fmake_var_non_special): New primitive.
959 (syms_of_eval): Defsubr it.
960 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
962 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
964 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
965 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
967 2012-06-08 Eli Zaretskii <eliz@gnu.org>
969 * alloc.c (allocate_vectorlike): Fix last change.
971 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
973 Block-based vector allocation of small vectors.
974 * lisp.h (struct vectorlike_header): New field `nbytes',
975 adjust comment accordingly.
976 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
977 to denote vector blocks. Adjust users (live_vector_p,
978 mark_maybe_pointer, valid_lisp_object_p) accordingly.
979 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
980 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
981 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
982 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
983 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
984 (roundup_size): New constant.
985 (struct vector_block): New data type.
986 (vector_blocks, vector_free_lists, zero_vector): New variables.
987 (all_vectors): Rename to `large_vectors'.
988 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
989 (sweep_vectors): New functions.
990 (allocate_vectorlike): Return `zero_vector' as the only vector of
991 0 items. Allocate new vector from block if vector size is less than
992 or equal to VBLOCK_BYTES_MAX.
993 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
994 (init_alloc_once): Add call to init_vectors.
996 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
998 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1000 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1002 * doprnt.c (doprnt): Truncate multibyte char correctly.
1003 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1004 would mishandle a string argument "Xc" if X was a multibyte
1005 character of length 2: it would truncate after X's first byte
1006 rather than including all of X.
1008 2012-06-06 Chong Yidong <cyd@gnu.org>
1010 * buffer.c (word_wrap): Doc fix.
1012 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1014 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1016 2012-06-03 Glenn Morris <rgm@gnu.org>
1018 * xdisp.c (tool-bar-style): Doc fix.
1020 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1022 * Makefile.in (PAXCTL): Define.
1023 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1024 binary via PaX flags if the paxctl utility is available.
1025 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1026 Restore PaX flags to their default. (Bug#11398)
1028 2012-06-03 Chong Yidong <cyd@gnu.org>
1030 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1033 2012-06-03 Chong Yidong <cyd@gnu.org>
1035 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1036 (note_mode_line_or_margin_highlight): If there is no help echo,
1037 use mode-line-default-help-echo. Handle the case where the mouse
1038 position is past the end of the mode line string.
1040 * buffer.c (buffer_local_value_1): New function, split from
1041 Fbuffer_local_value; can return Qunbound.
1042 (Fbuffer_local_value): Use it.
1043 (Vmode_line_format): Docstring tweaks.
1045 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1047 * sysdep.c (system_process_attributes): Improve comment.
1049 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1051 * keyboard.c: Export real-this-command to Elisp.
1052 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1053 and DEFVAR it. Update all users.
1055 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1057 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1059 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1060 Convert pctcpu and pctmem to Lisp float properly.
1061 Let the compiler fold better, as 100.0/0x8000 is exact.
1063 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1065 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1068 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1070 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1072 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1074 For a 'struct window', replace some Lisp_Object fields to
1075 bitfields where appropriate, remove unused fields.
1076 * window.h (struct window): Remove unused 'last_mark_x' and
1077 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1078 change it's type from Lisp_Object to bitfield.
1079 Change type of 'force_start', 'optional_new_start',
1080 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1081 fields from Lisp_Object to bitfield. Adjust users accordingly.
1083 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1085 Pacify gcc -Wdouble-precision when using Xaw.
1086 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1087 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1088 Use 'float' consistently, rather than 'float' in most places
1089 and 'double' in a couple of places.
1091 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1093 * xdisp.c (handle_stop): Detect whether we have overlay strings
1094 loaded by testing it->current.overlay_string_index to be
1095 non-negative, instead of checking whether n_overlay_strings is
1096 positive. (Bug#11587)
1098 2012-05-31 Chong Yidong <cyd@gnu.org>
1100 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1102 * doc.c (Fsubstitute_command_keys): Doc fix.
1104 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1106 * search.c (search_buffer): Remove calls to
1107 r_alloc_inhibit_buffer_relocation, as it is now called by
1108 maybe_unify_char, which was the cause of relocation of buffer text
1111 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1113 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1114 for the duration of call to load_charset, to avoid problems with
1115 callers of maybe_unify_char that access buffer text through C
1118 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1119 decrement the inhibition flag, instead of just setting or
1122 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1124 Remove obsolete '#define static' cruft.
1125 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1126 This #undef was "temporary" in 2000; it is no longer needed
1127 now that '#define static' has gone away.
1128 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1129 (gray_bitmap_bits): Remove; no longer needed.
1130 All uses replaced with definiens.
1131 * xterm.c: Include "bitmaps/gray.xbm".
1133 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1135 Clean up __executable_start, monstartup when --enable-profiling.
1136 The following changes affect the code only when profiling.
1137 * dispnew.c (__executable_start): Rename from safe_bcopy.
1138 Define only on platforms that need it.
1139 * emacs.c: Include <sys/gmon.h> when profiling.
1140 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1141 (__executable_start): Remove decl, since lisp.h does it now.
1142 (safe_bcopy): Remove decl; no longer has that name.
1143 (main): Coalesce #if into single bit of code, for simplicity.
1144 Cast pointers to uintptr_t, since standard libraries want integers
1146 * lisp.h (__executable_start): New decl.
1148 2012-05-31 Glenn Morris <rgm@gnu.org>
1150 * image.c (Fimagemagick_types): Doc fix.
1152 2012-05-30 Jim Meyering <meyering@redhat.com>
1154 * callproc.c (Fcall_process_region): Include directory component
1155 in mkstemp error message (Bug#11586).
1157 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1159 * alloc.c, lisp.h (make_pure_vector): Now static.
1161 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1163 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1164 Move to byte-run.el.
1165 (Fautoload): Do the hash-doc more carefully.
1166 * data.c (Fdefalias): Purify definition, except for keymaps.
1167 (Qdefun): Move from eval.c.
1168 * lisp.h (Qdefun): Remove.
1169 * lread.c (read1): Tiny simplification.
1171 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1173 Do not create empty overlays with the evaporate property (Bug#9642).
1174 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1175 Bug#9642, but explicitly check that the buffer the overlay would
1176 be moved to is live and rearrange lines to make sure that errors
1177 will not put the overlay in an inconsistent state.
1178 (Fdelete_overlay): Cosmetics.
1180 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1182 * w32term.c (my_bring_window_to_top): New function.
1183 (x_raise_frame): Use handle returned by DeferWindowPos, which
1184 could be different from the original one.
1185 Call my_bring_window_to_top instead of my_set_foreground_window.
1188 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1189 by calling BringWindowToTop.
1191 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1192 (WM_EMACS_END): Increase by one.
1194 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1196 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1197 This avoids undefined behavior that might cause the eassert
1198 to not catch an out-of-range value.
1200 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1202 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1203 Update dependencies.
1205 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1207 * bidi.c (bidi_mirror_char): Fix last change.
1209 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1211 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1212 when referring to sectname field in printf format.
1214 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1216 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1217 Only r_alloc_inhibit_buffer_relocation needed to be added;
1218 the others were already declared.
1220 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1221 before checking whether it's out of range. Put the check inside
1223 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1225 2012-05-27 Ken Brown <kbrown@cornell.edu>
1227 * callproc.c (Fcall_process): Restore a line that was accidentally
1228 commented out in the 2011-02-13 change (bug#11547).
1230 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1232 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1233 defined on ralloc.c.
1235 * buffer.c [REL_ALLOC]: Remove prototypes of
1236 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1237 they are now on lisp.h.
1239 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1241 * search.c (search_buffer): Use it to inhibit relocation of buffer
1242 text while re_search_2 is doing its job, because re_search_2 is
1243 passed C pointers to buffer text. (Bug#11519)
1245 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1248 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1249 state after an additional call to move_it_in_display_line_to, keep
1250 the values of it->max_ascent and it->max_descent found for the
1252 (pos_visible_p): Revert the comparison against bottom_y to what it
1253 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1256 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1258 Fix coding-related core dumps with gcc -ftrapv.
1259 The code was computing A - B, where A and B are pointers, and B is
1260 random garbage. This can lead to core dumps on platforms that
1261 have special pointer registers, and it also leads to core dumps on
1262 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1263 A - B only when B is initialized properly.
1264 * coding.c (coding_set_source, coding_set_destination): Return void.
1265 (coding_change_source, coding_change_destinations): New functions,
1266 with the old behaviors of coding_set_source and coding_set_destination.
1267 All callers that need an offset changed to use these new functions.
1269 2012-05-26 Glenn Morris <rgm@gnu.org>
1271 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1273 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1275 Extend mouse support on W32 text-mode console.
1276 * xdisp.c (draw_row_with_mouse_face):
1277 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1279 * w32console.c: Include window.h.
1280 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1282 (initialize_w32_display): Initialize mouse-highlight data.
1284 * w32inevt.c: Include termchar.h and window.h.
1285 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1286 moves, call note_mouse_highlight. If help_echo changed, call
1287 gen_help_event to produce help-echo message in the echo area.
1288 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1291 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1293 * lread.c (read1): Simplify slightly to avoid an overflow warning
1294 with GCC 4.7.0 on x86-64.
1296 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1298 * bidi.c (bidi_mirror_char): Revert last change: an int is
1299 definitely wide enough here.
1301 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1303 Fix integer width and related bugs (Bug#9874).
1304 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1305 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1306 (string_bytes, check_sblock, allocate_string_data):
1307 (compact_small_strings, Fmake_bool_vector, make_string)
1308 (make_unibyte_string, make_multibyte_string)
1309 (make_string_from_bytes, make_specified_string)
1310 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1311 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1314 (allocate_pseudovector):
1315 Use int, not EMACS_INT, where int is wide enough.
1316 (inhibit_garbage_collection, Fgarbage_collect):
1317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1318 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1319 int might not be wide enough.
1320 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1321 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1322 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1323 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1324 (bidi_level_of_next_char, bidi_move_to_visually_next):
1325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1326 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1327 (Fkill_buffer, Fset_buffer_major_mode)
1328 (advance_to_char_boundary, Fbuffer_swap_text)
1329 (Fset_buffer_multibyte, overlays_at, overlays_in)
1330 (overlay_touches_p, struct sortvec, record_overlay_string)
1331 (overlay_strings, recenter_overlay_lists)
1332 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1333 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1334 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1335 (Foverlay_recenter, last_overlay_modification_hooks_used)
1336 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1337 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1338 (validate_region): Omit unnecessary test for b <= e,
1339 since that's guaranteed by the previous test.
1340 (adjust_overlays_for_delete): Avoid pos + length overflow.
1341 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1342 (report_overlay_modification):
1343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1344 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1345 Omit pointer cast, which isn't needed anyway, and doesn't work
1346 after the EMACS_INT -> ptrdiff_t change.
1347 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1348 * buffer.h: Adjust decls to match defn changes elsewhere.
1349 (struct buffer_text, struct buffer):
1350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1351 Use EMACS_INT, not int, where int might not be wide enough.
1352 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1353 not int, to avoid needless 32-bit limit on 64-bit hosts.
1354 (exec_byte_code): Use tighter memory-full test, one that checks
1355 for alloca overflow. Don't compute the address of the object just
1356 before an array, as that's not portable. Use EMACS_INT, not
1357 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1358 * callint.c (Fcall_interactively):
1359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1360 * callproc.c (call_process_kill, Fcall_process):
1361 Don't assume pid_t fits into an Emacs fixnum.
1362 (call_process_cleanup, Fcall_process, child_setup):
1363 Don't assume pid_t fits into int.
1364 (call_process_cleanup, Fcall_process, delete_temp_file)
1365 (Fcall_process_region):
1366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1367 (Fcall_process): Simplify handling of volatile integers.
1368 Use int, not EMACS_INT, where int will do.
1369 * casefiddle.c (casify_object, casify_region, operate_on_word)
1370 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1372 (casify_object): Avoid integer overflow when overallocating buffer.
1373 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1374 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1375 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1376 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1377 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1378 integers are now checked earlier. All uses replaced with XINT.
1380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1381 For CCL_MapSingle, check that content and value are in int range.
1382 (ccl_driver, Fregister_code_conversion_map):
1383 Check that Vcode_version_map_vector is a vector.
1384 (resolve_symbol_ccl_program): Check that vector header is in range.
1385 Always copy the vector, so that we can check its contents reliably
1386 now rather than having to recheck each instruction as it's being
1387 executed. Check that vector words fit in 'int'.
1388 (ccl_get_compiled_code, Fregister_ccl_program)
1389 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1390 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1391 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1392 contents are in range.
1393 (Fccl_execute_on_string): Check that status is in range.
1394 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1395 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1396 Accept and return EMACS_INT, not int, because callers can pass values
1398 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1399 (multibyte_chars_in_text, parse_str_as_multibyte)
1400 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1401 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1402 (string_escape_byte8, Fget_byte):
1403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1404 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1405 avoid mishandling large integers.
1406 * character.h: Adjust decls to match defn changes elsewhere.
1407 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1408 (Ffind_charset_region):
1409 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1410 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1411 (load_charset_map_from_vector, Fdefine_charset_internal):
1412 Don't assume fixnum fits in int.
1413 (load_charset_map_from_vector, Fmap_charset_chars):
1414 Remove now-unnecessary CHECK_NATNUMs.
1415 (Fdefine_charset_internal): Check ranges here, more carefully.
1416 Don't rely on undefined behavior with signed left shift overflow.
1417 Don't assume unsigned int fits into fixnum, or that fixnum fits
1418 into unsigned int. Don't require max_code to be a valid fixnum;
1419 that's not true for gb10830 4-byte on a 32-bit host. Allow
1420 invalid_code to be a cons, for the same reason. Require code_offset
1421 to be a character. Avoid int overflow if max_char is close
1423 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1424 this is intended anyway and avoids some undefined behavior.
1425 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1426 INDEX_TO_CODE_POINT, as that's what it expects.
1427 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1428 * charset.h (DECODE_CHAR): Return int, not unsigned;
1429 this is what was intended anyway, and it avoids undefined behavior.
1430 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1431 integer-overflow issues.
1432 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1433 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1434 where the argument is EMACS_INT, and this behavior is not intended.
1435 * chartab.c (Fmake_char_table, Fset_char_table_range)
1436 (uniprop_get_decoder, uniprop_get_encoder):
1437 Don't assume fixnum fits in int.
1438 * cmds.c (move_point): New function, that does the gist of
1439 Fforward_char and Fbackward_char, but does so while checking
1440 for integer overflow more accurately.
1441 (Fforward_char, Fbackward_char): Use it.
1442 (Fforward_line, Fend_of_line, internal_self_insert)
1443 (internal_self_insert):
1444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1445 Fix a FIXME, by checking for integer overflow when calculating
1446 target_clm and actual_clm.
1447 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1448 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1449 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1450 (coding_alloc_by_making_gap, alloc_destination)
1451 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1452 (encode_coding_utf_16, detect_coding_emacs_mule)
1453 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1454 (detect_coding_iso_2022, decode_coding_iso_2022)
1455 (encode_invocation_designation, encode_designation_at_bol)
1456 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1457 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1458 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1459 (encode_coding_ccl, encode_coding_raw_text)
1460 (detect_coding_charset, decode_coding_charset)
1461 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1462 (produce_composition, produce_charset, produce_annotation)
1463 (decode_coding, handle_composition_annotation)
1464 (handle_charset_annotation, consume_chars, decode_coding_gap)
1465 (decode_coding_object, encode_coding_object, detect_coding_system)
1466 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1467 (code_convert_region, code_convert_string)
1468 (Fdefine_coding_system_internal)
1469 (coding_set_source, coding_set_destination):
1470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1471 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1472 (Fdefine_coding_system_internal):
1473 Don't assume fixnums fit in int.
1474 (decode_coding_gap, decode_coding_object, encode_coding_object)
1475 (Fread_coding_system, Fdetect_coding_region)
1476 (Funencodable_char_position, Fcheck_coding_systems_region)
1477 (get_translation, handle_composition_annotation, consume_chars):
1478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1479 (consume_chars): Rewrite to not calculate an address outside buffer.
1480 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1481 Don't access memory outside of the args array.
1482 (Fdefine_coding_system_internal): Check for charset-id overflow.
1483 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1484 result of ENCODE_CHAR.
1485 * coding.h: Adjust decls to match defn changes elsewhere.
1486 (struct coding_system):
1487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1488 * composite.c (get_composition_id, find_composition)
1489 (run_composition_function, update_compositions)
1490 (compose_text, composition_gstring_put_cache)
1491 (composition_gstring_p, composition_gstring_width)
1492 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1493 (composition_compute_stop_pos, composition_reseat_it)
1494 (composition_update_it, struct position_record)
1495 (find_automatic_composition, composition_adjust_point)
1496 (Fcomposition_get_gstring, Ffind_composition_internal):
1497 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1498 (update_compositions):
1499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1500 * composite.h: Adjust decls to match defn changes elsewhere.
1501 (struct composition):
1502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1503 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1504 Do not attempt to compute the address of the object just before a
1505 buffer; this is not portable.
1507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1508 (Faset): Use int, not EMACS_INT, where int is wide enough.
1509 (Fstring_to_number): Don't assume fixnums fit in int.
1510 (Frem): Don't assume arg is nonnegative.
1511 * dbusbind.c (xd_append_arg): Check for integers out of range.
1512 (Fdbus_call_method): Don't overflow the timeout int.
1513 (extract_signed, extract_unsigned): New functions.
1514 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1515 (xd_get_connection_references): Return ptrdiff_t, not int.
1517 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1518 (xd_read_message_1):
1519 Use int, not unsigned, where the dbus API uses int.
1520 (Fdbus_message_internal): Don't overflow mtype.
1521 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1522 * dired.c (directory_files_internal, file_name_completion, scmp)
1523 (file_name_completion_stat):
1524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1525 (file_name_completion): Don't overflow matchcount.
1526 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1527 * dispextern.h: Adjust decls to match defn changes elsewhere.
1528 (struct text_pos, struct glyph, struct bidi_saved_info)
1529 (struct bidi_string_data, struct bidi_it, struct composition_it)
1531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1532 (struct display_pos, struct composition_it, struct it):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 * dispnew.c (increment_matrix_positions)
1535 (increment_row_positions, mode_line_string)
1536 (marginal_area_string):
1537 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1538 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1540 (duration_to_sec_usec): New function, to check for overflow better.
1541 (Fsleep_for, sit_for): Use it.
1542 * doc.c (get_doc_string, store_function_docstring):
1543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1544 (get_doc_string, Fsnarf_documentation):
1545 Use int, not EMACS_INT, where int is wide enough.
1547 Use SAFE_ALLOCA, not alloca.
1548 Check for overflow when converting EMACS_INT to off_t.
1549 * doprnt.c (doprnt):
1550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1551 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1552 Don't assume uid_t fits into fixnum.
1553 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1554 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1555 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1556 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1557 (general_insert_function)
1558 (Finsert_char, make_buffer_string, make_buffer_string_both)
1559 (update_buffer_properties, Fbuffer_substring)
1560 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1561 (Fsubst_char_in_region, check_translation)
1562 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1563 (transpose_markers, Ftranspose_regions):
1564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1565 (clip_to_bounds): Move to lisp.h as an inline function).
1566 (Fconstrain_to_field): Don't assume integers are nonnegative.
1567 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1568 (Fsubst_char_in_region, Fsave_restriction):
1569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1570 (Femacs_pid): Don't assume pid_t fits into fixnum.
1571 (lo_time): Use int, not EMACS_INT, when int suffices.
1572 (lisp_time_argument): Check for usec out of range.
1573 (Fencode_time): Don't assume fixnum fits in int.
1574 (Fuser_login_name, Fuser_full_name): Signal an error
1575 if a uid argument is out of range, rather than relying on
1577 (Fformat_time_string): Remove now-unnecessary check.
1578 lisp_time_argument checks for out-of-range usec now.
1579 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1580 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1581 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1582 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1583 (init_cmdargs, Fdump_emacs):
1584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1585 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1586 the bottom (typically) 32 bits of the fixnum.
1587 * eval.c (specpdl_size, call_debugger):
1588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1589 (when_entered_debugger, Fbacktrace_debug):
1590 Don't assume fixnum can fit in int.
1591 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1592 the object just before a buffer; this is not portable.
1593 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1594 (grow_specpdl, unbind_to):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1596 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1597 (grow_specpdl): Simplify allocation by using xpalloc.
1598 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1599 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1600 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1601 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1602 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1605 (Fcopy_file, non_regular_nbytes, read_non_regular)
1606 (Finsert_file_contents):
1607 Use int, not EMACS_INT, where int is wide enough.
1608 (READ_BUF_SIZE): Verify that it fits in int.
1609 (Finsert_file_contents): Check that counts are in proper range,
1610 rather than assuming fixnums fit into ptrdiff_t etc.
1611 Don't assume fixnums fit into int.
1612 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1613 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1614 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1615 (string_char_to_byte, string_byte_to_char)
1616 (string_make_multibyte, string_to_multibyte)
1617 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1618 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1619 (substring_both, Fdelete, internal_equal, Ffillarray)
1620 (Fclear_string, mapcar1)
1621 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1622 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1623 (larger_vector, make_hash_table, maybe_resize_hash_table)
1624 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1625 (Fmaphash, secure_hash):
1626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1627 (concat): Check for string index and length overflow.
1628 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1631 (larger_vector): New API (vec, incr_min, size_max) replaces old
1632 one (vec, new_size, init). This catches size overflow.
1633 INIT was removed because it was always Qnil.
1634 All callers changed.
1635 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1636 the upper bound on a hash table index size.
1637 (make_hash_table, maybe_resize_hash_table): Use it.
1638 (secure_hash): Computer start_byte and end_byte only after
1639 they're known to be in ptrdiff_t range.
1640 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1641 (Ffont_get_glyphs, Ffont_at):
1642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1643 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1644 (Flist_fonts, Fopen_font):
1645 Don't assume fixnum can fit in int.
1646 (check_gstring): Don't assume index can fit in int.
1647 (font_match_p): Check that fixnum is a character, not a nonnegative
1648 fixnum, since the later code needs to stuff it into an int.
1649 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1650 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1651 conversion overflow issues.
1652 (Fopen_font): Check for integer out of range.
1653 (Ffont_get_glyphs): Don't assume index can fit in int.
1654 * font.h: Adjust decls to match defn changes elsewhere.
1655 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1657 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1658 printmax_t, where ptrdiff_t is wide enough.
1659 (Finternal_char_font):
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1661 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1662 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1663 (Fset_frame_position, x_set_frame_parameters)
1664 (x_set_line_spacing, x_set_border_width)
1665 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1666 Check that fixnums are in proper range for system types.
1667 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1670 Use SAFE_ALLOCA_LISP, not alloca.
1671 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1672 intptr_t is wide enough.
1673 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1674 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1675 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1676 Check for fixnum out of range.
1677 * ftfont.c (ftfont_list): Don't assume index fits in int.
1678 Check that fixnums are in proper range for system types.
1679 (ftfont_shape_by_flt):
1680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1681 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1682 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1683 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1684 Check that fixnums are in proper range for system types.
1685 * gnutls.h: Adjust decls to match defn changes elsewhere.
1686 * gtkutil.c (xg_dialog_run):
1687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1688 (update_frame_tool_bar):
1689 Check that fixnums are in proper range for system types.
1690 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1691 (lookup_image): Check that fixnums are in range for system types.
1692 * indent.c (last_known_column, last_known_column_point):
1693 (current_column_bol_cache):
1694 (skip_invisible, current_column, check_display_width):
1695 (check_display_width, scan_for_column, current_column_1)
1696 (Findent_to, Fcurrent_indentation, position_indentation)
1697 (indented_beyond_p, Fmove_to_column, compute_motion):
1698 (Fcompute_motion, Fvertical_motion):
1699 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1700 (last_known_column_modified): Use EMACS_INT, not int.
1701 (check_display_width):
1703 Check that fixnums and floats are in proper range for system types.
1704 (compute_motion): Don't assume index or fixnum fits in int.
1705 (compute_motion, Fcompute_motion):
1706 Use int, not EMACS_INT, when it is wide enough.
1707 (vmotion): Omit local var start_hpos that is always 0; that way
1708 we don't need to worry about overflow in expressions involving it.
1709 * indent.h: Adjust decls to match defn changes elsewhere.
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 Use int, not EMACS_INT, where int is wide enough.
1713 Remove unused members ovstring_chars_done and tab_offset;
1715 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1716 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1717 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1718 (make_gap, copy_text, insert, insert_and_inherit)
1719 (insert_before_markers, insert_before_markers_and_inherit)
1720 (insert_1, count_combining_before, count_combining_after)
1721 (insert_1_both, insert_from_string)
1722 (insert_from_string_before_markers, insert_from_string_1)
1723 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1724 (adjust_after_replace, adjust_after_insert, replace_range)
1725 (replace_range_2, del_range, del_range_1, del_range_byte)
1726 (del_range_both, del_range_2, modify_region)
1727 (prepare_to_modify_buffer, signal_before_change)
1728 (signal_after_change, Fcombine_after_change_execute):
1729 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1730 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1731 (balance_an_interval, split_interval_right, split_interval_left)
1732 (find_interval, next_interval, update_interval)
1733 (adjust_intervals_for_insertion, delete_node, delete_interval)
1734 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1735 (static_offset_intervals, offset_intervals)
1736 (merge_interval_right, merge_interval_left, make_new_interval)
1737 (graft_intervals_into_buffer, temp_set_point_both)
1738 (temp_set_point, set_point, adjust_for_invis_intang)
1739 (set_point_both, move_if_not_intangible, get_property_and_range)
1740 (get_local_map, copy_intervals, copy_intervals_to_string)
1741 (compare_string_intervals, set_intervals_multibyte_1):
1742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1743 * intervals.h: Adjust decls to match defn changes elsewhere.
1745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1746 * keyboard.c (this_command_key_count, this_single_command_key_start)
1747 (before_command_key_count, before_command_echo_length, echo_now)
1748 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1749 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1750 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1751 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1753 (last_non_minibuf_size, last_point_position, echo_truncate)
1754 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1755 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1756 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1757 (stuff_buffered_input):
1758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1759 (last_auto_save, command_loop_1, read_char):
1760 Use EMACS_INT, not int, to avoid integer overflow.
1761 (record_char): Avoid overflow in total_keys computation.
1762 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1763 * keyboard.h: Adjust decls to match defn changes elsewhere.
1764 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1765 (Fkey_description, Fdescribe_vector, Flookup_key):
1766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1767 (click_position): New function, to check that positions are in range.
1768 (Fcurrent_active_maps):
1770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1771 (Faccessible_keymaps, Fkey_description):
1772 (preferred_sequence_p):
1773 Don't assume fixnum can fit into int.
1774 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1775 Check for integer overflow in size calculations.
1776 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1777 avoid mishandling large integers.
1778 * lisp.h: Adjust decls to match defn changes elsewhere.
1779 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1780 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1781 (struct Lisp_Marker):
1782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1783 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1784 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1785 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1786 All callers changed.
1787 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1788 Assume the arg has valid form, since it always does.
1789 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1790 unsigned integer system type.
1791 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1792 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1794 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1795 (duration_to_sec_usec): New decl.
1796 * lread.c (read_from_string_index, read_from_string_index_byte)
1797 (read_from_string_limit, readchar, unreadchar, openp)
1798 (read_internal_start, read1, oblookup):
1799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1800 (Fload, readevalloop, Feval_buffer, Feval_region):
1801 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1802 (openp): Check for out-of-range argument to 'access'.
1803 (read1): Use int, not EMACS_INT, where int is wide enough.
1804 Don't assume fixnum fits into int.
1805 Fix off-by-one error that can read outside a buffer.
1806 (read_filtered_event): Use duration_to_sec_usec
1807 to do proper overflow checking on durations.
1808 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1809 in size calculation.
1810 (Fexecute_kbd_macro):
1811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1812 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1813 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1814 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1815 (set_marker_both, set_marker_restricted_both, marker_position)
1816 (marker_byte_position, Fbuffer_has_markers_at):
1817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1818 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1819 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1820 It now merely ensures that the menu is large enough, without
1821 necessarily growing it, as this avoids some integer overflow issues.
1822 All callers changed.
1823 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1825 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1826 Use SAFE_ALLOCA_LISP, not alloca.
1827 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1828 to EMACS_INT. Check that fixnums are in proper range for system types.
1829 * minibuf.c (minibuf_prompt_width, string_to_object)
1830 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1831 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1833 (get_minibuffer, read_minibuf_unwind):
1834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1835 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1836 this simplifies overflow checking. All callers changed.
1837 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1839 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1840 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1841 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1842 Check that fixnums are in proper range for system types.
1843 (Fx_create_frame, Fx_show_tip):
1844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1845 * nsfont.m (ns_findfonts, nsfont_list_family):
1846 Don't assume fixnum fits in long.
1847 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1851 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1853 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1854 (PRINTDECLARE, PRINTPREPARE):
1855 (strout, print_string):
1856 (print, print_preprocess, print_check_string_charset_prop)
1858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1862 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1863 (printchar, strout): Use xpalloc to catch size calculation overflow.
1864 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1865 (print_error_message): Use SAFE_ALLOCA, not alloca.
1866 (print_object): Use int, not EMACS_INT, where int is wide enough.
1867 (print_depth, new_backquote_output, print_number_index):
1868 Use ptrdiff_t, not int, where int might not be wide enough.
1869 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1870 (Fset_process_window_size, Fformat_network_address)
1871 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1873 Check that fixnums are in proper range for system types.
1874 (Fsignal_process): Simplify by avoiding a goto.
1875 Check for process-ids out of pid_t range rather than relying on
1877 (process_tick, update_tick): Use EMACS_INT, not int.
1878 (Fformat_network_address, read_process_output, send_process)
1879 (Fprocess_send_region, status_notify):
1880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1881 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1882 (wait_reading_process_output, read_process_output, exec_sentinel):
1883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1884 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1885 (Faccept_process_output): Use duration_to_sec_usec to do proper
1886 overflow checking on durations.
1887 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1888 Don't assume pid_t fits in int.
1889 * process.h (struct Lisp_Process): Members tick and update_tick
1890 are now of type EMACS_INT, not int.
1891 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1892 configured --with-wide-int.
1893 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1894 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1895 * search.c (looking_at_1, string_match_1):
1896 (fast_string_match, fast_c_string_match_ignore_case)
1897 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1898 (scan_newline, find_before_next_newline, search_command)
1899 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1900 (set_search_regs, wordify):
1903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1904 (string_match_1, search_buffer, set_search_regs):
1906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1907 (wordify): Check for overflow in size calculation.
1908 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1909 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1910 Check that fixnums are in proper range for system types.
1911 * sound.c (struct sound_device)
1912 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1914 (Fplay_sound_internal):
1915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1916 * syntax.c (struct lisp_parse_state, find_start_modiff)
1917 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1918 (Fparse_partial_sexp):
1919 Don't assume fixnums can fit in int.
1920 (struct lisp_parse_state, find_start_pos, find_start_value)
1921 (find_start_value_byte, find_start_begv)
1922 (update_syntax_table, char_quoted, dec_bytepos)
1923 (find_defun_start, prev_char_comend_first, back_comment):
1924 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1925 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1927 (Finternal_describe_syntax_value): Check that match_lisp is a
1928 character, not an integer, since the code stuffs it into int.
1929 (scan_words, scan_sexps_forward):
1930 Check that fixnums are in proper range for system types.
1932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1933 (scan_sexps_forward):
1934 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1935 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1936 * syntax.h: Adjust decls to match defn changes elsewhere.
1937 (struct gl_state_s):
1938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1939 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1940 MOST_POSITIVE_FIXNUM.
1941 * sysdep.c (wait_for_termination_1, wait_for_termination)
1942 (interruptible_wait_for_termination, mkdir):
1943 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1944 (emacs_read, emacs_write):
1945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1946 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1947 and double all fit in int.
1948 * term.c (set_tty_color_mode):
1949 Check that fixnums are in proper range for system types.
1950 * termhooks.h (struct input_event):
1951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1952 * textprop.c (validate_interval_range, interval_of)
1953 (Fadd_text_properties, set_text_properties_1)
1954 (Fremove_text_properties, Fremove_list_of_text_properties)
1955 (Ftext_property_any, Ftext_property_not_all)
1956 (copy_text_properties, text_property_list, extend_property_ranges)
1957 (verify_interval_modification):
1958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1959 (Fnext_single_char_property_change)
1960 (Fprevious_single_char_property_change):
1961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1962 (copy_text_properties):
1963 Check for integer overflow in index calculation.
1964 * undo.c (last_boundary_position, record_point, record_insert)
1965 (record_delete, record_marker_adjustment, record_change)
1966 (record_property_change):
1967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1968 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1970 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1971 (Fx_hide_tip, Fx_file_dialog):
1972 * w32menu.c (set_frame_menubar):
1973 Use ptrdiff_t, not int, for consistency with rest of code.
1974 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1975 (select_window, Fdelete_other_windows_internal)
1976 (window_scroll_pixel_based, window_scroll_line_based)
1977 (Frecenter, Fset_window_configuration):
1978 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1979 (Fset_window_hscroll, run_window_configuration_change_hook)
1980 (set_window_buffer, temp_output_buffer_show, scroll_command)
1981 (Fscroll_other_window, Frecenter):
1982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1983 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1984 Don't assume fixnum fits in int.
1985 (Fset_window_scroll_bars):
1986 Check that fixnums are in proper range for system types.
1987 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1988 (string_pos, c_string_pos, number_of_chars, init_iterator)
1989 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1990 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1991 (compute_display_string_end, handle_face_prop)
1992 (face_before_or_after_it_pos, handle_invisible_prop)
1993 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1994 (display_prop_intangible_p, string_buffer_position_lim)
1995 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1996 (get_overlay_strings_1, get_overlay_strings)
1997 (iterate_out_of_display_property, forward_to_next_line_start)
1998 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1999 (get_next_display_element, set_iterator_to_next)
2000 (get_visually_first_element, compute_stop_pos_backwards)
2001 (handle_stop_backwards, next_element_from_buffer)
2002 (move_it_in_display_line_to, move_it_in_display_line)
2003 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2004 (add_to_log, message_dolog, message_log_check_duplicate)
2005 (message2, message2_nolog, message3, message3_nolog
2006 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2007 (current_message_1, truncate_echo_area, truncate_message_1)
2008 (set_message, set_message_1, store_mode_line_noprop)
2009 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2010 (text_outside_line_unchanged_p, check_point_in_composition)
2011 (reconsider_clip_changes)
2012 (redisplay_internal, set_cursor_from_row, try_scrolling)
2013 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2014 (redisplay_window, find_last_unchanged_at_beg_row)
2015 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2016 (trailing_whitespace_p, find_row_edges, display_line)
2017 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2018 (display_mode_element, store_mode_line_string)
2019 (pint2str, pint2hrstr, decode_mode_spec)
2020 (display_count_lines, display_string, draw_glyphs)
2021 (x_produce_glyphs, x_insert_glyphs)
2022 (rows_from_pos_range, mouse_face_from_buffer_pos)
2023 (fast_find_string_pos, mouse_face_from_string_pos)
2024 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2026 (safe_call, init_from_display_pos, handle_fontified_prop)
2027 (handle_single_display_spec, load_overlay_strings)
2028 (with_echo_area_buffer, setup_echo_area_for_printing)
2029 (display_echo_area, echo_area_display)
2030 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2031 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2032 (redisplay_window, dump_glyph_row, display_mode_line)
2033 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2034 (handle_display_spec, display_prop_string_p):
2035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2036 (handle_single_display_spec, build_desired_tool_bar_string)
2037 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2038 (get_specified_cursor_type):
2039 Check that fixnums are in proper range for system types.
2040 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2041 (Flookup_image_map):
2042 Don't assume fixnums fit in int.
2043 (compare_overlay_entries):
2044 Avoid mishandling comparisons due to subtraction overflow.
2045 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2046 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2047 (handle_tool_bar_click):
2048 Use int, not unsigned, since we prefer signed and the signedness
2049 doesn't matter here.
2050 (get_next_display_element, next_element_from_display_vector):
2051 Use int, not EMACS_INT, when int is wide enough.
2052 (start_hourglass): Use duration_to_sec_usec to do proper
2053 overflow checking on durations.
2054 * xfaces.c (Fbitmap_spec_p):
2055 Check that fixnums are in proper range for system types.
2056 (compare_fonts_by_sort_order):
2057 Avoid mishandling comparisons due to subtraction overflow.
2058 (Fx_family_fonts, realize_basic_faces):
2059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2061 Don't assume fixnum fits in int.
2062 Use SAFE_ALLOCA_LISP, not alloca.
2063 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2064 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2065 (face_at_buffer_position, face_for_overlay_string)
2066 (face_at_string_position):
2067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2068 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2069 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2071 Check that fixnums are in proper range for system types.
2072 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2073 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2075 (Fx_change_window_property): Don't assume fixnums fit in int.
2076 * xfont.c (xfont_chars_supported):
2077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2078 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2079 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2081 * xml.c (parse_region):
2082 * xrdb.c (magic_file_p):
2083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2084 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2085 (x_get_local_selection, x_reply_selection_request)
2086 (x_handle_selection_request, wait_for_property_change):
2087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2088 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2089 short is wide enough.
2090 (x_send_client_event): Don't assume fixnum fits in int.
2091 * xterm.c (x_x_to_emacs_modifiers):
2092 Don't assume EMACS_INT overflows nicely into int.
2093 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2095 (handle_one_xevent): NATNUMP can eval its arg twice.
2096 (x_connection_closed):
2097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2098 * xterm.h: Adjust decls to match defn changes elsewhere.
2099 (struct scroll_bar): Use struct vectorlike_header
2100 rather than rolling our own approximation.
2101 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2103 2012-05-25 Glenn Morris <rgm@gnu.org>
2105 * lisp.mk (lisp): Update for more files being compiled now.
2107 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2109 * lread.c: Remove `read_pure' which makes no difference.
2110 (read_pure): Remove var.
2111 (unreadpure): Remove function.
2112 (readevalloop): Don't call read_list with -1 flag.
2113 (read1, read_vector): Don't test read_pure any more.
2114 (read_list): Simplify.
2116 * fileio.c, character.h: Minor style tweaks.
2118 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2120 * window.h (clip_changed): Remove useless declaration.
2122 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2124 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2125 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2127 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2130 This directory predates autoconf and is no longer needed nowadays.
2131 Move its few remaining bits of functionality to where they're needed.
2132 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2133 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2134 * m/template.h: Remove.
2135 * Makefile.in (M_FILE): Remove. All uses removed.
2136 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2137 * lisp.h (USE_LSB_TAG):
2138 * mem-limits.h (EXCEEDS_LISP_PTR):
2139 Use VAL_MAX, not VALBITS, in #if.
2140 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2141 (EMACS_UINT): Define unconditionally now.
2142 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2143 (BITS_PER_EMACS_INT): New constants, replacing
2144 what used to be in config.h, but not useful in #if.
2145 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2146 define them any more.
2147 (VAL_MAX): New macro.
2149 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2150 BITS_PER_EMACS_INT, in #if.
2151 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2152 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2153 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2154 * s/ms-w32.h (DATA_START):
2155 Move here from removed file m/intel386.h.
2156 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2157 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2159 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2161 Assume C89 or later.
2162 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2163 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2165 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2166 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2167 * textprop.c, tparam.c (NULL): Remove.
2168 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2169 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2170 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2171 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2172 * xterm.c (input_signal_count): Assume volatile works.
2174 2012-05-21 Ken Brown <kbrown@cornell.edu>
2176 * xgselect.c (xg_select): Fix first argument in call to 'select'
2179 2012-05-20 Ken Brown <kbrown@cornell.edu>
2181 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2182 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2184 2012-05-19 Ken Brown <kbrown@cornell.edu>
2186 * xfns.c (x_in_use): Remove `static' qualifier.
2187 * xterm.h (x_in_use): Declare.
2188 * xgselect.c: Include xterm.h.
2189 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2190 and `display_arg' (bug#9754).
2192 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2194 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2196 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2197 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2199 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2201 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2203 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2204 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2206 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2207 reference to image_cache->refcount.
2208 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2210 2012-05-17 Juri Linkov <juri@jurta.org>
2212 * search.c (Fword_search_regexp, Fword_search_backward)
2213 (Fword_search_forward, Fword_search_backward_lax)
2214 (Fword_search_forward_lax): Move functions to isearch.el
2215 (bug#10145, bug#11381).
2217 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2219 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2221 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2223 * lread.c (init_obarray): Declare Qt and Qnil as special.
2225 2012-05-14 Glenn Morris <rgm@gnu.org>
2227 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2228 Put "libexec" before "bin", for the sake of init_callproc_1.
2230 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2232 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2234 * unexaix.c: Port to more-recent AIX compilers.
2235 (report_error, report_error_1, make_hdr, copy_sym)
2236 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2237 Make arguments const char *, not char *, to avoid violations of C
2238 standard and to fix some AIX warnings reported by Gilles Pion.
2240 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2242 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2243 already have overlays loaded.
2244 (handle_single_display_spec): Before returning without displaying
2245 fringe bitmap, synchronize the bidi iterator with the main display
2246 iterator, by calling iterate_out_of_display_property.
2247 (iterate_out_of_display_property): Detect buffer iteration by
2248 testing that it->string is a Lisp string.
2249 (get_next_display_element): When the current object is exhausted,
2250 and there's something on it->stack, call set_iterator_to_next to
2251 proceed with what's on the stack, instead of returning zero.
2252 (set_iterator_to_next): If called at the end of a Lisp string,
2253 proceed to consider_string_end without incrementing string
2254 position. Don't increment display vector index past the end of
2255 the display vector. (Bug#11417)
2256 (pos_visible_p): Don't report a position visible when move_it_to
2257 stopped at the last line of window, which happens to be scanned
2258 backwards by the bidi iteration. (Bug#11464)
2260 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2262 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2263 and right-margin display specs even if the spec is invalid or we
2264 are on a TTY, and thus unable to display on the fringes.
2265 That's because the text with the property will not be displayed anyway,
2266 so we need to signal to the caller that this is a "replacing"
2267 display spec. This fixes display when the spec is invalid or we
2270 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2272 * unexaix.c (make_hdr): Fix typo in prototype.
2273 This bug broke the build on AIX. Problem reported by Gilles Pion.
2275 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2277 * keyboard.c (kbd_buffer_get_event): Read special events also in
2278 batch mode. (Bug#11415)
2280 2012-05-12 Glenn Morris <rgm@gnu.org>
2282 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2284 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2286 * lisp.mk (lisp): Add newcomment.elc.
2288 2012-05-12 Glenn Morris <rgm@gnu.org>
2290 * Makefile.in (MKDIR_P): New, set by configure.
2291 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2293 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2295 Remove unused function hourglass_started.
2296 * dispextern.h (hourglass_started):
2297 * w32fns.c (hourglass_started):
2298 * xdisp.c (hourglass_started): Remove.
2300 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2302 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2303 Update dependencies.
2305 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2307 * xgselect.c (xg_select): Put maxfds+1 into a var.
2308 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2310 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2312 2012-05-10 Dave Abrahams <dave@boostpro.com>
2314 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2315 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2317 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2319 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2320 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2321 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2322 Initialize xd_registered_buses.
2324 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2326 Untag more efficiently if USE_LSB_TAG.
2327 This is based on a proposal by YAMAMOTO Mitsuharu in
2328 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2329 For an admittedly artificial (nth 8000 longlist) benchmark on
2330 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2331 Emacs's overall text size by 1%.
2332 * lisp.h (XUNTAG): New macro.
2333 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2334 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2335 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2336 * eval.c (Fautoload):
2337 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2338 * frame.h (XFRAME): Use XUNTAG.
2340 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2341 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2342 Remove unportable assumptions about print widths of types like
2344 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2345 intptr_t when converting between pointer and integer, to avoid GCC
2346 warnings about wrong width.
2348 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2350 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2351 stack for each reader_thread, instead of defaulting to 8MB
2352 determined by the linker. This avoids failures in creating
2353 subprocesses on Windows 7, see the discussion in this thread:
2354 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2356 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2358 Fix up display of the *Minibuf-0* buffer in the mini window.
2359 * keyboard.c (read_char): Don't clear the echo area if there's no
2361 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2362 contents of *Minibuf-0*) if there's no message displayed in its stead.
2364 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2366 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2369 2012-05-06 Chong Yidong <cyd@gnu.org>
2371 * lisp.mk (lisp): Update.
2373 2012-05-05 Jim Meyering <meyering@redhat.com>
2375 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2377 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2379 * data.c (PUT_ERROR): New macro.
2380 (syms_of_data): Use it. Add new error type `user-error'.
2381 * undo.c (user_error): New function.
2382 (Fprimitive_undo): Use it.
2383 * print.c (print_error_message): Adjust print style for `user-error'.
2384 * keyboard.c (user_error): New function.
2385 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2387 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2389 Do not limit current-time-string to years 1000..9999.
2390 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2391 (Fcurrent_time_string): Support any year that is supported by the
2392 underlying localtime representation. Don't use asctime, as it
2393 has undefined behavior for years outside the range -999..9999.
2395 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2397 Fix race conditions involving setenv, gmtime, localtime, asctime.
2398 Without this fix, interrupts could mess up code that uses these
2399 nonreentrant functions, since setting TZ invalidates existing
2400 tm_zone or tzname values, and since most of these functions return
2401 pointers to static storage.
2402 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2403 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2404 Grow the critical sections to include not just invoking
2405 localtime/gmtime, but also accessing these functions' results
2406 including their tm_zone values if any, and any related TZ setting.
2407 (format_time_string): Last arg is now struct tm *, not struct tm **,
2408 so that the struct tm is saved in the critical section.
2409 All callers changed. Simplify allocation of initial buffer, partly
2410 motivated by the fact that memory allocation needs to be outside
2411 the critical section.
2413 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2415 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2416 with RESET_INTERVAL.
2418 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2419 Remove duplicated buffer name initialization.
2421 2012-05-02 Jim Meyering <jim@meyering.net>
2423 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2425 * xfns.c (x_window): Use xstrdup (Bug#11375).
2427 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2429 * xdisp.c (pos_visible_p): If already at a newline from the
2430 display string before the 'while' loop, don't walk back the glyphs
2431 from it3.glyph_row. Solves assertion violation when the display
2432 string begins with a newline (egg.el). (Bug#11367)
2434 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2436 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2439 2012-05-01 Glenn Morris <rgm@gnu.org>
2441 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2442 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2443 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2444 All were removed before 23.1.
2446 * dispnew.c: Remove HAVE_LIBNCURSES test;
2447 it is always true on relevant platforms.
2449 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2450 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2452 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2454 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2456 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2457 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2460 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2462 Do not avoid creating empty evaporating overlays (Bug#9642).
2463 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2464 That is, do not delete an evaporating overlay if it becomes
2465 empty after its bounds are adjusted to fit within its buffer.
2466 This fix caused other problems, and I'm reverting it until we get
2467 to the bottom of them.
2469 2012-04-27 Chong Yidong <cyd@gnu.org>
2471 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2473 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2475 * xdisp.c (pos_visible_p): If the window start position is beyond
2476 ZV, start the display from buffer beginning. Prevents assertion
2477 violation in init_iterator when the minibuffer window is scrolled
2480 * window.c (window_scroll_pixel_based): Likewise.
2482 2012-04-27 Chong Yidong <cyd@gnu.org>
2484 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2486 2012-04-27 Glenn Morris <rgm@gnu.org>
2488 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2489 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2491 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2493 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2494 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2496 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2498 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2499 display element, check also the underlying string or buffer
2500 character. (Bug#11341)
2502 * w32menu.c: Include w32heap.h.
2503 (add_menu_item): If the call to AppendMenuW (via
2504 unicode_append_menu) fails, disable Unicode menus only if we are
2505 running on Windows 9X/Me.
2507 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2509 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2510 (xgetint): Add missing shift for LSB tags.
2512 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2514 * keyboard.c (read_char): Don't wipe echo area for select window
2515 events: These might get delayed via `mouse-autoselect-window'
2518 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2520 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2521 manipulation of :loaded-from data.
2523 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2525 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2526 now a cons (bug#11311).
2528 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2530 Do not create empty overlays with the evaporate property (Bug#9642).
2531 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2532 if it becomes empty after its bounds are adjusted to fit within
2533 its buffer. Without this fix, in a nonempty buffer (let ((o
2534 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2535 yields an empty overlay that has the evaporate property, which is
2536 not supposed to happen.
2538 Fix minor GTK3 problems found by static checking.
2539 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2540 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2541 (struct _EmacsFixedClass, emacs_fixed_get_type):
2542 Move decls here from emacsgtkfixed.h, since they needn't be public.
2543 (emacs_fixed_get_type): Now static.
2544 (emacs_fixed_class_init): Omit unused local.
2545 (emacs_fixed_child_type): Remove; unused.
2546 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2547 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2548 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2549 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2550 (EMACS_FIXED_GET_CLASS): Remove; unused.
2551 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2553 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2554 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2556 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2558 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2559 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2560 (__malloc_size_t, __malloc_ptrdiff_t):
2561 Remove. All uses removed, replaced by the definiens if needed,
2562 since we can assume C89 or better now.
2563 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2564 (protect_malloc_state, align, get_contiguous_space)
2565 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2566 (malloc_atfork_handler_child, malloc_enable_thread)
2567 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2568 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2569 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2570 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2571 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2572 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2573 Define using prototypes, not old style.
2574 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2575 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2576 (align): Don't assume that signed integer overflow wraps around.
2577 Omit unused local var.
2578 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2579 (_free_internal_nolock, memalign, mallochook, reallochook):
2580 Omit no-longer-needed casts.
2581 (valloc): Use getpagesize, not __getpagesize.
2582 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2583 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2585 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2587 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2589 Move functions from C to Lisp. Make non-blocking method calls
2590 the default. Implement further D-Bus standard interfaces.
2592 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2593 (QCdbus_request_name_allow_replacement)
2594 (QCdbus_request_name_replace_existing)
2595 (QCdbus_request_name_do_not_queue)
2596 (QCdbus_request_name_reply_primary_owner)
2597 (QCdbus_request_name_reply_in_queue)
2598 (QCdbus_request_name_reply_exists)
2599 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2600 (QCdbus_registered_serial, QCdbus_registered_method)
2601 (QCdbus_registered_signal): New Lisp objects.
2602 (XD_DEBUG_MESSAGE): Use sizeof.
2603 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2604 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2605 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2606 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2607 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2608 (xd_signature, xd_append_arg): Allow float for integer types.
2609 (xd_get_connection_references): New function.
2610 (xd_get_connection_address): Rename from xd_initialize.
2611 Return cached address.
2612 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2613 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2615 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2616 Return number of refcounts.
2617 (Fdbus_get_unique_name): Make stronger parameter check.
2618 (Fdbus_message_internal): New defun.
2619 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2620 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2621 (Fdbus_send_signal, Fdbus_register_service)
2622 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2623 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2624 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2625 (Vdbus_compiled_version, Vdbus_runtime_version)
2626 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2627 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2628 (Vdbus_message_type_signal): New defvars.
2629 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2632 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2634 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2635 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2636 Do not assume ptrdiff_t is the same width as 'int'.
2638 * alloc.c: Handle unusual debugging option combinations.
2639 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2640 since the two debugging options are incompatible.
2641 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2643 (mem_init, mem_insert, mem_insert_fixup):
2644 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2645 (NEED_MEM_INSERT): Remove; no longer needed.
2647 2012-04-22 Leo Liu <sdl.web@gmail.com>
2649 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2651 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2653 * sysdep.c [__FreeBSD__]: Minor cleanups.
2654 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2655 Use Emacs indenting style more consistently. Avoid some casts.
2656 Use 'double' consistently rather than mixing 'float' and 'double'.
2658 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2660 * sysdep.c (list_system_processes, system_process_attributes):
2661 Add implementation for FreeBSD (Bug#5243).
2663 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2665 * lisp.mk (lisp): Update.
2667 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2669 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2670 It is never used otherwise.
2672 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2674 * print.c (print_preprocess): Only check print_depth if print-circle
2676 (print_object): Check for cycles even when print-circle is nil and
2677 print-gensym is t, but only check print_depth if print-circle is nil.
2679 2012-04-20 Chong Yidong <cyd@gnu.org>
2681 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2682 set the status to "failed" and ensure that sentinel is run.
2684 2012-04-20 Glenn Morris <rgm@gnu.org>
2686 * process.c (Fset_process_inherit_coding_system_flag)
2687 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2688 (Fmake_network_process, Fmake_serial_process): Doc fix.
2690 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2692 * xdisp.c (string_buffer_position_lim): Limit starting position to
2694 (set_cursor_from_row): If called for a mode-line or header-line
2695 row, return zero immediately.
2696 (try_cursor_movement): If inside continuation line, don't back up
2697 farther than the first row after the header line, if any.
2698 Don't consider the header-line row as "partially visible", even if
2699 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2701 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2703 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2706 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2707 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2709 configure: new option --enable-gcc-warnings (Bug#11207)
2710 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2711 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2712 (ALL_CFLAGS): Use new macros rather than old.
2713 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2714 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2715 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2716 -Wunused-result, -Wunused-variable. This should go away once
2717 the Emacs and Gnulib regex code is merged.
2718 (xmalloc, xrealloc): Now static.
2720 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2722 * dired.c (Fsystem_groups): Remove unused local.
2724 2012-04-17 Glenn Morris <rgm@gnu.org>
2726 * dired.c (Fsystem_users): Doc fix.
2728 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2730 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2731 (syms_of_dired): Add them.
2733 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2735 Fix minor alloc.c problems found by static checking.
2736 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2737 New extern decls, to avoid calling undeclared functions.
2738 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2739 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2740 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2741 (NEED_MEM_INSERT): New macro.
2742 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2743 Remove one incorrect comment and fix another.
2745 Fix minor ralloc.c problems found by static checking.
2746 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2747 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2748 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2749 (r_alloc_sbrk): Now static.
2751 Improve ralloc.c interface checking.
2752 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2753 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2754 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2755 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2756 [REL_ALLOC]: ... to here, to check interface.
2757 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2758 Remove decls. This fixes an "It stinks!".
2760 * alloc.c (which_symbols): Fix alignment issue / type clash.
2762 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2764 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2765 (struct Lisp_Misc_Any): Likewise.
2766 (struct Lisp_Free): Likewise.
2767 * alloc.c (union aligned_Lisp_Symbol): Define.
2768 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2769 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2770 (union aligned_Lisp_Misc): Define.
2771 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2772 aligned_Lisp_Misc instead of union Lisp_Misc.
2773 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2775 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2777 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2778 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2779 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2780 * s/netbsd.h, s/sol2-6.h:
2781 Remove definition of GC_MARK_STACK, since the default now works.
2782 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2783 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2784 no longer the default.
2785 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2787 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2789 * lread.c (lisp_file_lexically_bound_p):
2790 Fix hang at ";-*-\n" (bug#11238).
2792 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2794 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2795 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2797 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2799 * nsterm.m (constrainFrameRect): Always constrain when there is only
2800 one screen (Bug#10962).
2802 2012-04-13 Ken Brown <kbrown@cornell.edu>
2804 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2806 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2808 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2810 2012-04-11 Daniel Colascione <dancol@dancol.org>
2812 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2813 against is gone. It's better to use vfork now so that when Cygwin
2814 gains a new, working vfork, we use it automatically (bug#10398).
2816 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2818 * window.c (save_window_save): Obey window-point-insertion-type.
2820 2012-04-11 Glenn Morris <rgm@gnu.org>
2822 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2824 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2826 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2828 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2830 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2831 (force_quit_count): New var.
2832 (handle_interrupt): Use it.
2834 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2836 * w32.c (w32_delayed_load): Record the full path of the library
2837 being loaded (bug#10424).
2839 2012-04-09 Glenn Morris <rgm@gnu.org>
2841 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2842 not just in the obarray, before snarfing them. (Bug#11036)
2844 * Makefile.in ($(leimdir)/leim-list.el):
2845 Pass EMACS rather than BUILT_EMACS.
2847 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2849 * process.c (make_process):
2850 * process.h: Add integer `gnutls_handshakes_tried' member to
2853 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2854 Add convenience `GNUTLS_LOG2i' macro.
2856 * gnutls.c (gnutls_log_function2i): Convenience log function.
2857 (emacs_gnutls_read): Use new log functions,
2858 `gnutls_handshakes_tried' process member, and
2859 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2860 attempts per process (connection).
2862 2012-04-09 Chong Yidong <cyd@gnu.org>
2864 * eval.c (Fuser_variable_p, user_variable_p_eh)
2865 (lisp_indirect_variable): Functions deleted.
2866 (Fdefvar): Caller changed.
2868 * callint.c (Finteractive, Fcall_interactively):
2869 * minibuf.c (Fread_variable): Callers changed.
2871 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2873 * xdisp.c (set_cursor_from_row): If the display string appears in
2874 the buffer at position that is closer to point than the position
2875 after the display string, display the cursor on the first glyph of
2876 the display string. Fixes cursor display when a 'display' text
2877 property immediately follows invisible text. (Bug#11094)
2879 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2881 composite.c: use 'double' consistently
2882 * composite.c (get_composition_id): Use 'double' consistently
2883 instead of converting 'float' to 'double' and vice versa; this is
2884 easier to understand and avoids a GCC warning.
2886 2012-04-09 Glenn Morris <rgm@gnu.org>
2888 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2889 preparation for dumping it with emacs. (Bug#4789)
2890 (leimdir): New variable.
2891 ($(leimdir)/leim-list.el): New rule.
2892 (emacs$(EXEEXT)): Depend on leim-list.el.
2894 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2895 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2896 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2898 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2900 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2903 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2905 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2906 Remove unused local variable.
2908 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2910 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2911 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2912 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2913 objects, as mark_maybe_pointer will catch them otherwise.
2914 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2915 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2917 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2919 Fix typo that broke non-Windows builds.
2920 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2922 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2924 Support building on MS-Windows with libxml2.
2926 * makefile.w32-in (OBJ2): Add xml.$(O).
2927 (GLOBAL_SOURCES): Add xml.c.
2928 ($(BLD)/xml.$(O)): New dependency list.
2930 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2931 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2932 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2933 [!WINDOWSNT]: New macros.
2934 (init_libxml2_functions, libxml2_loaded_p): New functions.
2935 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2936 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2937 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2938 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2940 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2941 Call init_libxml2_functions before calling libxml2 functions.
2942 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2944 * emacs.c: Don't include libxml/parser.h.
2945 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2946 xmlCleanupParser directly.
2948 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2950 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2952 * indent.c (Fvertical_motion): If there is a display string at
2953 point, use it.vpos to compute how many lines to backtrack after
2954 move_it_to point. (Bug#11133)
2956 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2958 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2959 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2960 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2961 macros related to unification of CJK characters. For the details,
2962 see the discussion following the message here:
2963 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2965 2012-04-04 Chong Yidong <cyd@gnu.org>
2967 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2969 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2971 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2972 instead of alloca. (Bug#11138)
2974 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2976 * w32menu.c (is_simple_dialog): Properly check lisp types.
2979 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2981 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2982 position we get to after a call to move_it_to fails the
2983 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2984 only if we wind up in a string from display property. (Bug#11063)
2986 * window.c (Fdelete_other_windows_internal): Invalidate the row
2987 and column information about mouse highlight, so that redisplay
2988 restores it after reallocating the glyph matrices. (Bug#7464)
2990 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2991 string comes from a `display' text property, use the buffer
2992 position of that property as if we actually saw that position in
2994 (move_it_by_lines): Remove the assertion that
2995 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2996 violated when there's a before-string at the beginning of a line.
2999 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3001 * xdisp.c (append_space_for_newline): If the default face was
3002 remapped, use the remapped face for the appended newline.
3003 (extend_face_to_end_of_line): Use the remapped default face for
3004 extending the face to the end of the line.
3005 (display_line): Call extend_face_to_end_of_line when the default
3006 face was remapped. (Bug#11068)
3008 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3010 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3012 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3014 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3016 2012-03-27 Glenn Morris <rgm@gnu.org>
3018 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3021 2012-03-26 Kenichi Handa <handa@m17n.org>
3023 * dispextern.h (struct glyph): Fix previous change. Change the
3024 bit length of glyphless.ch to 25 (Bug#11082).
3026 2012-03-26 Chong Yidong <cyd@gnu.org>
3028 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3029 (command_loop_1): Use it; inhibit selection update for
3030 handle-select-window too (Bug#8996).
3032 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3034 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3036 2012-03-25 Kenichi Handa <handa@m17n.org>
3038 * dispextern.h (struct glyph): Change the bit length of
3039 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3041 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3043 * s/ms-w32.h (tzname): Include time.h before redirecting to
3044 _tzname. Fixes the MSVC build. (Bug#9960)
3046 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3048 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3051 * xterm.c (XTread_socket): Only modify handling_signal if
3052 !SYNC_INPUT. (Bug#11080)
3054 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3056 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3057 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3058 when fetching a multibyte character consumes more bytes than
3059 CHAR_BYTES returns, due to unification of CJK characters in
3060 string_char. (Bug#11073)
3062 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3064 * process.c (wait_reading_process_output): Handle pty disconnect
3065 by refraining from sending oneself a SIGCHLD (bug#10933).
3067 2012-03-22 Chong Yidong <cyd@gnu.org>
3069 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3071 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3072 Mark string as coming from a prefix property.
3073 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3074 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3076 2012-03-21 Chong Yidong <cyd@gnu.org>
3078 * xfaces.c (Vface_remapping_alist): Doc fix.
3080 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3082 * w32proc.c (Fw32_set_console_codepage)
3083 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3086 2012-03-20 Chong Yidong <cyd@gnu.org>
3088 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3089 to reflect default non-nil value of redisplay-dont-pause.
3091 2012-03-19 Kenichi Handa <handa@m17n.org>
3093 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3094 it fit in a valid range (Bug#11003).
3096 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3098 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3099 that is not from display property, accept the row as a "cursor
3100 row" if one of the string's character has a non-nil `cursor'
3101 property. Fixes cursor positioning when there are newlines in
3102 overlay strings, e.g. in icomplete.el. (Bug#11035)
3104 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3106 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3108 2012-03-12 Chong Yidong <cyd@gnu.org>
3110 * eval.c (inhibit_lisp_code): Rename from
3111 inhibit_window_configuration_change_hook; move from window.c.
3113 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3114 * window.c (run_window_configuration_change_hook)
3115 (syms_of_window): Callers changed.
3117 2012-03-11 Chong Yidong <cyd@gnu.org>
3119 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3121 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3123 2012-03-10 Chong Yidong <cyd@gnu.org>
3125 * frame.c (other_visible_frames): Don't assume the selected frame
3126 is visible (Bug#10955).
3128 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3130 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3132 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3134 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3135 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3138 2012-03-03 Glenn Morris <rgm@gnu.org>
3140 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3142 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3144 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3145 position past the first glyph_row that ends at ZV. (Bug#10902)
3146 (redisplay_window, next_element_from_string): Fix typos in
3148 (redisplay_window): Pass to move_it_vertically the margin in
3149 pixels, not in screen lines.
3151 2012-03-02 Glenn Morris <rgm@gnu.org>
3153 * buffer.c (buffer-list-update-hook): Doc fix.
3155 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3157 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3158 push_it before setting up the iterator for the first overlay
3159 string, even if we have an empty string loaded.
3160 (next_overlay_string): If there's an empty string on the iterator
3161 stack, pop the stack. (Bug#10903)
3163 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3165 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3166 Suggested by Stefan Monnier in
3167 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3168 * alloc.c (widen_to_Lisp_Object): New static function.
3169 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3170 and widening them to Lisp_Objects. This would work even if
3171 USE_LSB_TAG is defined and wide integers are used, which might
3172 happen in a future version of Emacs.
3174 2012-02-25 Chong Yidong <cyd@gnu.org>
3176 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3179 * xselect.c (Fx_selection_exists_p): Doc fix.
3180 (x_clipboard_manager_save_all): Print an informative message
3181 before saving to clipboard manager.
3183 2012-02-24 Chong Yidong <cyd@gnu.org>
3185 * keyboard.c (process_special_events): Handle all X selection
3186 requests in kbd_buffer, not just the next one (Bug#8869).
3188 2012-02-23 Chong Yidong <cyd@gnu.org>
3190 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3191 call when setting menu-bar-lines and tool-bar-lines parameters.
3192 (unwind_create_frame_1): New helper function.
3194 * window.c (inhibit_window_configuration_change_hook): New var.
3195 (run_window_configuration_change_hook): Obey it.
3196 (syms_of_window): Initialize it.
3198 2012-02-22 Chong Yidong <cyd@gnu.org>
3200 * xterm.c (x_draw_image_relief): Add missing type check for
3201 Vtool_bar_button_margin (Bug#10743).
3203 2012-02-21 Chong Yidong <cyd@gnu.org>
3205 * fileio.c (Vfile_name_handler_alist): Doc fix.
3207 * buffer.c (Fget_file_buffer): Protect against invalid file
3208 handler return value.
3210 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3212 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3213 when computing $valmask.
3215 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3216 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3217 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3218 It's useless in that case, and it can cause problems on hosts
3219 that allocate halves of EMACS_INT values separately.
3220 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3221 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3222 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3223 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3224 it avoids undefined behavior on hosts where shifting right by more
3225 than the word width has undefined behavior.
3227 2012-02-19 Chong Yidong <cyd@gnu.org>
3229 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3230 (Funhandled_file_name_directory, Ffile_name_as_directory)
3231 (Fdirectory_file_name, Fexpand_file_name)
3232 (Fsubstitute_in_file_name): Protect against invalid file handler
3233 return values (Bug#10845).
3235 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3237 * .gdbinit (pitx): Fix incorrect references to fields of the
3240 2012-02-17 Chong Yidong <cyd@gnu.org>
3242 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3244 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3246 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3247 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3249 2012-02-15 Chong Yidong <cyd@gnu.org>
3251 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3252 marked as special. Also, starting docstrings with * is obsolete.
3254 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3256 * gnutls.c (emacs_gnutls_write): Fix last change.
3258 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3260 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3263 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3265 * keymap.c (Fsingle_key_description): Handle char ranges.
3267 2012-02-12 Chong Yidong <cyd@gnu.org>
3269 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3270 as that creates a dangerous corner case.
3272 * window.c (Fdelete_window_internal): Invalidate the mouse
3273 highlight (Bug#9904).
3275 2012-02-12 Glenn Morris <rgm@gnu.org>
3277 * xselect.c (Fx_own_selection_internal)
3278 (Fx_get_selection_internal, Fx_disown_selection_internal)
3279 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3280 * nsselect.m (Fx_own_selection_internal)
3281 (Fx_disown_selection_internal, Fx_selection_exists_p)
3282 (Fx_selection_owner_p, Fx_get_selection_internal):
3283 Sync docs and argument specs with the xselect.c versions.
3285 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3287 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3289 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3291 * w32select.c (Fx_selection_exists_p): Sync doc string and
3292 argument list with xselect.c. (Bug#10783)
3294 * w16select.c (Fx_selection_exists_p): Sync doc string and
3295 argument list with xselect.c. (Bug#10783)
3297 2012-02-10 Glenn Morris <rgm@gnu.org>
3299 * fns.c (Fsecure_hash): Doc fix.
3301 2012-02-09 Kenichi Handa <handa@m17n.org>
3303 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3305 2012-02-07 Chong Yidong <cyd@gnu.org>
3307 * buffer.c (Fbuffer_local_variables)
3308 (buffer_lisp_local_variables): Handle unbound vars correctly;
3309 don't let Qunbound leak into Lisp.
3311 2012-02-07 Glenn Morris <rgm@gnu.org>
3313 * image.c (Fimagemagick_types): Doc fix.
3315 * image.c (imagemagick-render-type): Change it from a lisp object
3316 to an integer. Move the doc here from the lisp manual.
3317 Treat all values not equal to 0 the same.
3319 2012-02-06 Chong Yidong <cyd@gnu.org>
3321 * doc.c (store_function_docstring): Avoid applying docstring of
3322 alias to base function (Bug#2603).
3324 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3326 * .gdbinit (pp1, pv1): Remove redundant defines.
3329 2012-02-04 Chong Yidong <cyd@gnu.org>
3331 * nsterm.m: Declare a global (Bug#10694).
3333 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3335 * w32.c (get_emacs_configuration_options):
3336 Include --enable-checking, if specified, in the return value.
3338 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3340 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3341 after rounding frame sizes. (Bug#9723)
3343 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3345 * keyboard.c (adjust_point_for_property): Don't position point
3346 before BEGV. (Bug#10696)
3348 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3350 Handle overflow when computing char display width (Bug#9496).
3351 * character.c (char_width): Return EMACS_INT, not int.
3352 (char_width, c_string_width): Check for overflow when
3353 computing the width; this is possible now that individual
3354 characters can have unbounded width. Problem introduced
3355 by merge from Emacs 23 on 2012-01-19.
3357 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3359 * dbusbind.c (Fdbus_register_method): Mention the return value
3360 :ignore in the docstring.
3362 2012-02-02 Glenn Morris <rgm@gnu.org>
3364 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3366 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3367 Unconditionally set to t. (Bug#10673)
3368 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3369 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3370 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3372 2012-02-02 Kenichi Handa <handa@m17n.org>
3374 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3375 0, do not call append_composite_glyph.
3377 2012-02-02 Kenichi Handa <handa@m17n.org>
3379 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3381 (x_produce_glyphs): If the component of a composition is a null
3382 string, set it->pixel_width to 1 to avoid zero-width glyph.
3384 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3386 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3387 first 2 arguments are identical. This makes inserting large
3388 output from a subprocess an order of magnitude faster on
3389 MS-Windows, where all sbrk'ed memory is always contiguous.
3391 2012-01-31 Glenn Morris <rgm@gnu.org>
3393 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3394 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3395 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3397 2012-01-29 Glenn Morris <rgm@gnu.org>
3399 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3401 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3403 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3405 2012-01-28 Chong Yidong <cyd@gnu.org>
3407 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3409 2012-01-26 Chong Yidong <cyd@gnu.org>
3411 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3413 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3414 repeat counts (Bug#10507).
3416 2012-01-26 Glenn Morris <rgm@gnu.org>
3418 * lread.c (syms_of_lread): Doc fix.
3420 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3422 * coding.c (encode_designation_at_bol): Change return value to
3425 2012-01-25 Chong Yidong <cyd@gnu.org>
3427 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3429 2012-01-21 Chong Yidong <cyd@gnu.org>
3431 * floatfns.c (Fcopysign): Make the second argument non-optional,
3432 since nil is not allowed anyway.
3434 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3436 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3437 (send_process): Likewise.
3439 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3441 * window.c (save_window_save, Fcurrent_window_configuration)
3442 (Vwindow_persistent_parameters): Do not use Qstate.
3443 Rewrite doc-strings.
3445 2012-01-19 Kenichi Handa <handa@m17n.org>
3447 * character.c (char_width): New function.
3448 (Fchar_width, c_string_width, lisp_string_width):
3449 Use char_width (Bug#9496).
3451 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3453 * window.c (Vwindow_persistent_parameters): New variable.
3454 (Fset_window_configuration, save_window_save): Handle persistent
3457 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3459 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3460 thrashing the stack of the thread. (Bug#9087)
3462 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3464 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3466 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3468 * xdisp.c (rows_from_pos_range): Handle the case where the
3469 highlight ends on a newline. (Bug#10464)
3470 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3471 he end column for display of highlight that ends on a newline
3474 2012-01-11 Glenn Morris <rgm@gnu.org>
3476 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3477 from load-path also when installation-directory is nil. (Bug#10208)
3479 2012-01-10 Glenn Morris <rgm@gnu.org>
3481 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3483 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3484 Update template values to be closer to their typical values these days.
3486 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3488 * xdisp.c (rows_from_pos_range): Accept additional argument
3489 DISP_STRING, and accept any glyph in a row whose object is that
3490 string as eligible for mouse highlight. Fixes mouse highlight of
3491 display strings from overlays. (Bug#10464)
3493 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3495 emacs: fix an auto-save permissions race condition (Bug#10400)
3496 * fileio.c (auto_saving_dir_umask): New static var.
3497 (Fmake_directory_internal): Use it.
3498 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3499 creating the directory. The old code temporarily assigns
3500 too-generous permissions to the directory.
3501 (do_auto_save_eh): Clear it.
3502 (Fdo_auto_save): Catch all errors, not just file errors, so
3503 that the var is always cleared.
3505 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3507 * search.c (scan_buffer): Pass character positions to
3508 know_region_cache, not byte positions. (Bug#6540)
3510 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3512 * w32.c (sys_rename): Report EXDEV when rename of a directory
3513 fails because the target is on another logical disk. (Bug#10284)
3515 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3517 * xterm.c (x_embed_request_focus): New function.
3519 * xterm.h: Add prototype.
3521 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3523 2012-01-05 Glenn Morris <rgm@gnu.org>
3525 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3527 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3529 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3530 Load gnutls_transport_set_lowat only if GnuTLS version is below
3532 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3533 GnuTLS versions below 2.11.1.
3535 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3537 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3538 to the doc string advising against its use for altering the way
3539 windows are scrolled.
3541 2011-12-28 Kenichi Handa <handa@m17n.org>
3543 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3544 coding-system ASCII compatible only when it does not produce BOM
3545 on encoding (Bug#10383).
3547 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3549 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3551 (create_and_show_popup_menu): Always use menu_position_func for
3554 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3556 * callint.c (Fcall_interactively): Don't truncate prompt string.
3558 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3560 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3561 property that ends at ZV, so that the bidi iteration could be
3562 resumed from there (after widening). (Bug#10360)
3564 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3566 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3568 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3570 * nsterm.m (x_free_frame_resources):
3571 Release f->output_data.ns->miniimage.
3572 (ns_index_color): Fix indentation. Do not retain
3573 color_table->colors[i].
3575 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3578 * nsfns.m (x_set_background_color): Assign return value from
3579 ns_index_color to face-background instead of NSColor*.
3580 (ns_implicitly_set_icon_type): Fix indentation.
3581 Change assignment in for loop to comparison.
3583 * emacs.c (ns_pool): New variable.
3584 (main): Assign ns_pool.
3585 (Fkill_emacs): Call ns_release_autorelease_pool.
3587 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3588 autorelease fdesc, release fdAttrs and tdict.
3589 (ns_get_covering_families): Release charset.
3590 (ns_findfonts): Release NSFontDescriptor created with new.
3591 (ns_uni_to_glyphs): Fix indentation.
3592 (setString): Release attrStr before assigning new value.
3594 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3596 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3598 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3599 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3601 2011-12-18 David Reitter <reitter@cmu.edu>
3603 * nsterm.m (ns_term_init): Subscribe for notifications
3604 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3605 to method trackingNotification in EmacsMenu.
3607 * nsmenu.m (trackingMenu): New variable.
3608 (trackingNotification): New method (from Aquamacs).
3609 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3610 from Aquamacs (Bug#7030).
3612 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3614 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3615 (symbol_to_nsstring): Fix indentation.
3616 (ns_symbol_to_pb): New function.
3617 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3618 (Fns_rotate_cut_buffers_internal): Remove.
3619 (Fns_store_selection_internal): Rename from
3620 Fns_store_cut_buffer_internal.
3621 (ns_get_foreign_selection, Fx_own_selection_internal)
3622 (Fx_disown_selection_internal, Fx_selection_exists_p)
3623 (Fns_get_selection_internal, Fns_store_selection_internal):
3624 Use ns_symbol_to_pb and check if return value is nil.
3625 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3626 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3627 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3628 renamed to Sns_store_selection_internal.
3629 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3630 and remove this function.
3631 (ns_handle_selection_clear): Remove, never used.
3632 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3635 2011-12-17 Ken Brown <kbrown@cornell.edu>
3637 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3638 GID is unknown (Bug#10257).
3640 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3642 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3643 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3644 which caused a build failure on GNU/Linux IA-64. This problem was
3645 introduced by my 2011-10-07 patch.
3647 2011-12-15 Juri Linkov <juri@jurta.org>
3649 * image.c (imagemagick_error): New function. (Bug#10112)
3650 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3651 Use `imagemagick_error' where ImageMagick functions return
3653 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3656 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3658 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3659 fill background (Bug#8992).
3661 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3663 * window.c (Vwindow_combination_resize)
3664 (Vwindow_combination_limit): Use t instead of non-nil in
3666 (Vrecenter_redisplay): Add first sentence of doc-string on
3668 (Frecenter): Fix doc-string typo.
3670 2011-12-11 Kenichi Handa <handa@m17n.org>
3672 * coding.c (Funencodable_char_position): Pay attention to the
3673 buffer text relocation (Bug#9389).
3675 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3677 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3678 gtk_init (Bug#10100).
3680 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3682 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3683 IT->string is nil. (Bug#10263)
3685 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3687 * nsterm.h (x_free_frame_resources): Declare.
3689 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3690 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3692 * nsterm.h (ns_get_defaults_value): Declare.
3694 * nsterm.m (ns_default): Call ns_get_defaults_value.
3696 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3698 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3701 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3703 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3704 that where the value of an _OBJC_* symbol points to is in the .bss
3705 section (Bug#10240).
3707 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3709 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3710 after the loop to call ccl_driver at least once (Bug#8619).
3712 2011-12-08 Kenichi Handa <handa@m17n.org>
3714 * ftfont.c (get_adstyle_property): Fix previous change
3717 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3719 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3720 dirs from the default value of EMACSLOADPATH (bug#10208).
3722 2011-12-07 Glenn Morris <rgm@gnu.org>
3724 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3725 installation and source directories as well. (Bug#10208)
3727 2011-12-06 Chong Yidong <cyd@gnu.org>
3729 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3731 2011-12-06 Glenn Morris <rgm@gnu.org>
3733 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3734 as an error, not just -1. (Bug#10217)
3736 2011-12-05 Chong Yidong <cyd@gnu.org>
3738 * keyboard.c (process_special_events): New function.
3739 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3741 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3743 * coding.c (encode_designation_at_bol): Don't use uninitialized
3744 local variable (Bug#9318).
3746 2011-12-05 Kenichi Handa <handa@m17n.org>
3748 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3749 return Qnil (Bug#8046, Bug#10193).
3751 2011-12-05 Kenichi Handa <handa@m17n.org>
3753 * coding.c (encode_designation_at_bol): New args charbuf_end and
3754 dst. Return the number of produced bytes. Callers changed.
3755 (coding_set_source): Return how many bytes coding->source was
3757 (coding_set_destination): Return how many bytes
3758 coding->destination was relocated.
3759 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3760 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3762 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3764 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3765 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3768 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3770 The following changes are to fix Bug#9318.
3772 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3773 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3774 (encode_coding_iso_2022, encode_coding_sjis)
3775 (encode_coding_big5, encode_coding_charset): Use the above macros.
3777 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3779 * lisp.h (process_quit_flag): Fix external declaration.
3781 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3783 Don't macro-inline non-performance-critical code.
3784 * eval.c (process_quit_flag): New function.
3785 * lisp.h (QUIT): Use it.
3787 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3789 * nsfns.m (get_geometry_from_preferences): New function.
3790 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3792 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3794 * emacs.c (Qkill_emacs): Define.
3795 (syms_of_emacs): Initialize it.
3796 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3797 Qquit_flag to `kill-emacs' instead.
3798 (quit_throw_to_read_char): Add parameter `from_signal'.
3799 All callers changed. Call Fkill_emacs if requested and safe.
3800 * lisp.h (QUIT): Call Fkill_emacs if requested.
3802 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3804 * widget.c (update_wm_hints): Return if wmshell is null.
3805 (widget_update_wm_size_hints): New function.
3807 * widget.h (widget_update_wm_size_hints): Declare.
3809 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3810 widget_update_wm_size_hints (Bug#10104).
3812 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3814 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3815 before a newline, prepare the bidi iterator for consuming the
3816 newline, and keep the current paragraph direction. (Bug#10183)
3817 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3819 2011-12-02 Juri Linkov <juri@jurta.org>
3821 * search.c (Fword_search_regexp): New Lisp function created from
3822 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3823 (Fword_search_backward, Fword_search_forward)
3824 (Fword_search_backward_lax, Fword_search_forward_lax):
3825 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3826 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3828 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3830 * fileio.c (Finsert_file_contents): Move after-change-function call
3831 to before the "handled:" label, since all "goto handled" appear in
3832 cases where the *-change-functions have already been properly called
3835 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3837 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3838 waiting for input. (Bug#10169)
3840 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3842 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3843 verifies glyph row's hash code--we have just reallocated the
3844 glyphs, so their contents can be complete garbage. (Bug#10164)
3846 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3848 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3850 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3852 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3853 attributes are tested _before_ calling verify_row_hash, to protect
3854 against GCC re-ordering of the tests. (Bug#10164)
3856 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3858 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3860 * xterm.c (handle_one_xevent): Only set async_visible and friends
3861 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3862 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3863 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3865 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3867 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3868 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3869 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3870 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3871 All uses changed to use GCPRO1 etc.
3872 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3873 Revert to old implementation (i.e., before 2011-03-11).
3875 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3877 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3878 of scroll runs so as to avoid assigning disabled bogus rows and
3879 unnecessary graphics copy operations.
3881 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3883 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3884 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3885 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3886 (malloc, free, realloc, calloc): Redirect to e_* only when
3889 * lisp.h (GCTYPEBITS): Move before first use.
3890 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3891 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3892 this macro definition.
3894 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3897 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3899 * gtkutil.c (xg_create_frame_widgets):
3900 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3901 present with Gtk+ 2.0.
3903 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3905 * fileio.c (Finsert_file_contents): Undo previous change; see
3906 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3908 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3910 Rename locals to avoid shadowing.
3911 * fileio.c (Finsert_file_contents):
3912 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3913 * process.c (wait_reading_process_output):
3914 Rename inner 'proc' to 'p' to avoid shadowing.
3915 Indent for consistency with usual Emacs style.
3917 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3919 * xdisp.c (redisplay_window): If cursor row is not fully visible
3920 after recentering, and scroll-conservatively is set to a large
3921 number, scroll window by a few more lines to make the cursor fully
3922 visible and out of scroll-margin. (Bug#10105)
3923 (start_display): Don't move to the next line if the display should
3924 start at a newline that is part of a display vector or an overlay
3927 2011-11-24 Juri Linkov <juri@jurta.org>
3929 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3930 after the `MagickPingImage' call. (Bug#10112)
3932 2011-11-23 Chong Yidong <cyd@gnu.org>
3934 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3936 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3938 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3939 making another buffer current. (Bug#10114)
3941 2011-11-23 Glenn Morris <rgm@gnu.org>
3943 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3945 2011-11-23 Chong Yidong <cyd@gnu.org>
3947 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3948 using it (Bug#5984).
3950 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3952 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3953 and header-lines, as they don't have one computed for them.
3956 * .gdbinit (prow): Make displayed values more self-explaining.
3957 Add row's hash code.
3959 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3961 * process.c (wait_reading_process_output): Fix asynchrounous
3962 GnuTLS socket handling on some versions of the GnuTLS library.
3963 (wait_reading_process_output): Add comment and URL.
3965 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3967 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3969 2011-11-21 Chong Yidong <cyd@gnu.org>
3971 * window.c (Fnext_window, Fprevious_window): Doc fix.
3973 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3975 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3977 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3979 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3981 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3983 * window.c (Fset_window_combination_limit): Rename argument
3985 (Vwindow_combination_limit): Remove "status" from doc-string.
3987 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3989 * m/ibms390.h: Remove.
3990 * m/ibms390x.h: Don't include "ibms390.h".
3992 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3994 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3995 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3997 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3999 * casetab.c (Fset_case_table):
4000 * charset.c (Fcharset_after): Fix typos.
4002 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4004 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4005 Otherwise, valgrind does not work on some platforms.
4006 Problem reported by Andreas Schwab in
4007 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4008 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4009 is set, removing the need for VIRT_ADDRESS_VARIES.
4010 (PURE_P): Use a more-efficient implementation that needs just one
4011 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4012 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4013 to 4 (xorl, subq, cmpq, setbe).
4014 * alloc.c (pure): Always extern now, since that's the
4015 VIRT_ADDR_VARIES behavior.
4016 (PURE_POINTER_P): Use a single comparison, not two, for
4017 consistency with the new puresize.h.
4018 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4019 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4020 Remove VIRT_ADDR_VARIES no longer needed.
4022 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4024 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4025 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4026 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4027 behave as if the cursor position were at the window margin.
4029 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4030 and the cursor position is out of bounds, behave as if the cursor
4031 position were at the window margin. (Bug#10075)
4033 2011-11-18 Chong Yidong <cyd@gnu.org>
4035 * window.c (Fwindow_combination_limit): Make first argument
4036 non-optional, since it is meaningless for live windows like the
4039 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4041 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4043 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4045 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4046 (graft_intervals_into_buffer): Simplify.
4048 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4050 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4051 hash values of the two rows.
4052 (copy_row_except_pointers): Preserve the used[] arrays and the
4053 hash values of the two rows. (Bug#10035)
4054 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4056 * xdisp.c (row_hash): New function, body extracted from
4057 compute_line_metrics.
4058 (compute_line_metrics): Call row_hash, instead of computing the
4061 * dispnew.c (verify_row_hash): Call row_hash for computing the
4062 hash code of a row, instead of duplicating code from xdisp.c.
4064 * dispextern.h (row_hash): Add prototype.
4066 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4068 * frame.c (delete_frame): Don't delete the terminal when the last
4069 X frame is closed if emacs is built with GTK toolkit.
4071 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4073 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4075 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4077 * window.c (Vwindow_splits): Rename to
4078 Vwindow_combination_resize. Suggested by Juri Linkov.
4079 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4082 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4084 * nsfns.m (Fns_font_name):
4085 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4087 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4089 * window.h (window): Rename slot "nest" to "combination_limit".
4090 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4091 (Fset_window_nest): Rename to Fset_window_combination_limit.
4092 (Vwindow_nest): Rename to Vwindow_combination_limit.
4093 (recombine_windows, make_parent_window, make_window)
4094 (Fsplit_window_internal, saved_window)
4095 (Fset_window_configuration, save_window_save): Rename all
4096 occurrences of window_nest to window_combination_limit.
4098 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4100 * image.c (imagemagick_load_image): Fix typo.
4102 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4104 * xdisp.c (display_line): Move the call to
4105 highlight_trailing_whitespace before the call to
4106 compute_line_metrics, since the latter needs to see the final
4107 faces of all the glyphs to compute ROW's hash value.
4108 Fixes assertion violations in row_equal_p. (Bug#10035)
4110 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4112 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4113 just return (bug#10044).
4115 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4117 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4118 with user-defined heap size. Bump the default size of the temacs
4119 heap to 27MB, to avoid memory warning when running temacs.
4120 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4122 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4123 current_matrix and desired_matrix. (Bug#9990)
4124 (verify_row_hash) [XASSERTS]: New function.
4125 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4126 that the hash value of glyph rows is correct.
4128 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4130 * window.h (window): Remove splits slot.
4131 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4132 (Fdelete_other_windows_internal, make_parent_window)
4133 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4134 (Fset_window_configuration, save_window_save): Don't deal with
4135 split status of windows.
4136 (saved_window): Remove splits slot.
4137 (Vwindow_splits): Rewrite doc-string.
4139 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4141 * xfns.c (unwind_create_frame):
4142 * nsfns.m (unwind_create_frame):
4143 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4144 Vframe_list (Bug#9999).
4146 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4148 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4150 2011-11-11 Kenichi Handa <handa@m17n.org>
4152 * callproc.c (Fcall_process): Set the member dst_multibyte of
4155 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4157 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4158 avoid a crash (bug#9496).
4160 2011-11-09 Chong Yidong <cyd@gnu.org>
4162 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4163 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4165 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4167 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4169 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4171 Avoid some portability problems by eschewing 'extern inline' functions.
4172 The trivial performance wins aren't worth the portability hassles; see
4173 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4175 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4176 (window_box_width, window_box_left, window_box_left_offset)
4177 (window_box_right, window_box_right_offset): Undo previous change,
4178 by removing the "extern"s.
4179 * intervals.c (adjust_intervals_for_insertion)
4180 (adjust_intervals_for_deletion): Undo previous change,
4181 making these static again.
4182 (offset_intervals, temp_set_point_both, temp_set_point)
4183 (copy_intervals_to_string): No longer inline.
4184 * xdisp.c (window_text_bottom_y, window_box_width)
4185 (window_box_height, window_box_left_offset)
4186 (window_box_right_offset, window_box_left, window_box_right)
4187 (window_box): No longer inline.
4189 2011-11-08 Chong Yidong <cyd@gnu.org>
4191 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4192 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4193 Signal an error if not a live window.
4194 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4195 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4197 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4199 * lisp.h (syms_of_abbrev): Remove declaration.
4200 Reported by CHENG Gao <chenggao@royau.me>.
4202 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4204 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4205 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4206 of temacs in GUI mode.
4208 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4210 * window.h: Declare delete_all_child_windows instead of
4211 delete_all_subwindows.
4212 * window.c (Fwindow_nest, Fset_window_nest)
4213 (Fset_window_new_total, Fset_window_new_normal)
4214 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4215 (delete_all_subwindows): Rename to delete_all_child_windows.
4216 (Fdelete_other_windows_internal, Fset_window_configuration):
4217 Call delete_all_child_windows instead of delete_all_subwindows.
4218 * frame.c (delete_frame): Call delete_all_child_windows instead
4219 of delete_all_subwindows.
4221 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4223 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4224 This is also needed for porting to any host where GC_MARK_STACK is
4225 not GC_MAKE_GCPROS_NOOPS.
4226 (which_symbols): Use it.
4228 2011-11-07 Kenichi Handa <handa@m17n.org>
4230 * coding.c (coding_set_destination): Check coding->src_pos only
4231 when coding->src_object is a buffer (bug#9910).
4233 * process.c (send_process): Set the member src_multibyte of coding
4234 to 0 (bug#9911) when sending a unibyte text.
4236 * callproc.c (Fcall_process): Set the member src_multibyte of
4237 process_coding to 0 (bug#9912).
4239 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4241 * xmenu.c (cleanup_widget_value_tree): New function.
4242 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4243 calling free_menubar_widget_value_tree directly (Bug#9830).
4245 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4247 Fix some portability problems with 'inline'.
4248 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4249 (window_box_width, window_box_left, window_box_left_offset)
4250 (window_box_right, window_box_right_offset): Declare extern.
4251 Otherwise, these inline functions do not conform to C99 and
4252 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4253 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4254 * intervals.c (adjust_intervals_for_insertion)
4255 (adjust_intervals_for_deletion): Now extern, because otherwise the
4256 extern inline functions 'offset_intervals' couldn't refer to it.
4257 (static_offset_intervals): Remove.
4258 (offset_intervals): Rewrite using the old contents of
4259 static_offset_intervals. The old version didn't conform to C99
4260 because an extern inline function contained a reference to an
4261 identifier with static linkage.
4263 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4265 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4268 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4270 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4271 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4272 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4273 return Qleft_to_right.
4275 2011-11-06 Chong Yidong <cyd@gnu.org>
4277 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4278 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4279 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4280 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4281 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4282 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4283 (Fwindow_vscroll): Doc fix.
4284 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4285 argument, since it makes no sense to pass a live window and for
4286 consistency with window-child.
4288 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4290 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4293 2011-11-05 Jason Rumney <jasonr@gnu.org>
4295 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4296 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4298 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4299 bitwise arithmetic preventing use of unicode-sip and non-truetype
4302 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4304 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4307 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4308 initialization code to keep similarity to xfns.c after changes
4311 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4313 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4314 (unwind_create_frame): New function (Bug#9943).
4315 (Fx_create_frame): Restructure code to be more similar to the one in
4316 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4317 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4318 Move terminal->reference_count++ just before making the frame official
4321 * nsterm.m (x_free_frame_resources): New function.
4322 (x_destroy_window): Move code to x_free_frame_resources.
4324 * xfns.c (unwind_create_frame): Fix comment.
4325 (Fx_create_frame, x_create_tip_frame):
4326 Move terminal->reference_count++ just before making the frame
4327 official. Move initialization of image_cache_refcount and
4328 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4330 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4332 Support MSVC build with newer versions of Visual Studio.
4333 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4334 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4337 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4338 which are not supported by MSVC.
4339 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4340 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4342 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4344 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4346 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4348 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4350 Support MSVC build with newer versions of Visual Studio.
4351 * w32.c: Don't include w32api.h for MSVC.
4352 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4354 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4355 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4356 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4357 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4359 (alloca) [_MSC_VER]: Define to _alloca.
4361 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4363 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4365 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4367 * xdisp.c (note_mouse_highlight): If either of
4368 previous/next-single-property-change returns nil, treat that as
4369 the beginning or the end of the buffer. (Bug#9955)
4371 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4373 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4374 label is not null (Bug#9951).
4375 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4378 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4380 * window.c (Fwindow_body_size): Mention in the doc string that the
4381 return value is in frame's canonical units. (Bug#9949)
4383 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4385 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4387 * w32fns.c (unwind_create_frame): If needed, free the glyph
4388 matrices of the partially constructed frame. (Bug#9943)
4389 * xfns.c (unwind_create_frame): Likewise.
4391 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4393 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4394 Don't stop backward scan on the continuation glyph, even though
4395 its CHARPOS is positive.
4396 (mouse_face_from_buffer_pos, note_mouse_highlight):
4397 Rename cover_string to disp_string.
4399 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4401 * window.c (temp_output_buffer_show): Don't use
4402 Vtemp_buffer_show_specifiers.
4403 (Vtemp_buffer_show_specifiers): Remove unused variable.
4405 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4407 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4408 past the beginning of the current glyph matrix.
4410 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4412 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4413 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4414 HAVE_GTK3 (Bug#9869).
4416 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4417 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4419 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4421 * xterm.c: Declare x_handle_net_wm_state to return int.
4422 (handle_one_xevent): Check if we are iconified but don't have
4423 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4424 (get_current_wm_state): Return non-zero if not hidden,
4425 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4426 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4427 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4428 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4430 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4432 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4433 so that this new function doesn't get optimized away by a
4434 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4436 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4438 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4440 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4442 Fix the `xbytecode' command.
4443 * .gdbinit (xprintbytestr): New command.
4444 (xwhichsymbols): Rename from `which'; all callers changed.
4445 (xbytecode): Print the byte-code string as well.
4447 2011-10-29 Kim Storm <storm@cua.dk>
4449 * alloc.c (which_symbols): New function.
4451 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4453 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4456 2011-10-29 Glenn Morris <rgm@gnu.org>
4458 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4459 Not clear what it was for, and it causes various bugs. (Bug#9839)
4461 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4463 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4464 possible random value that matches one of those tested as
4465 condition to clear the mouse face.
4467 2011-10-28 Chong Yidong <cyd@gnu.org>
4469 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4471 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4473 * window.c (make_window): Initialize phys_cursor_on_p.
4475 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4477 * lisp.h (struct Lisp_Symbol): Update comments.
4479 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4481 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4483 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4485 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4486 <oslsachem@gmail.com> for helping to debug this.
4488 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4489 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4490 (g_b_init_get_glyph_outline_w): New static variables.
4491 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4492 (GetGlyphOutlineW_Proc): New typedefs.
4493 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4494 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4496 (w32font_open_internal, compute_metrics):
4497 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4498 instead of calling the "wide" APIs directly.
4500 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4502 * w32.h (syms_of_w32font): Add prototype.
4504 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4506 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4507 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4508 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4509 (Fmove_to_window_line): Doc fix.
4511 2011-10-27 Chong Yidong <cyd@gnu.org>
4513 * process.c (make_process): Set gnutls_state to NULL.
4515 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4516 non-NULL, regardless of GNUTLS_INITSTAGE.
4517 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4518 an error. Set process slots as soon as we allocate them.
4520 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4522 2011-10-27 Chong Yidong <cyd@gnu.org>
4524 * gnutls.c (emacs_gnutls_deinit): New function.
4525 Deallocate credentials structures as well as calling gnutls_deinit.
4526 (Fgnutls_deinit, Fgnutls_boot): Use it.
4528 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4529 (deactivate_process): Call emacs_gnutls_deinit.
4531 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4533 * image.c (x_create_x_image_and_pixmap):
4534 * w32.c (sys_rename, w32_delayed_load):
4535 * w32font.c (fill_in_logfont):
4536 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4538 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4540 * w32fns.c (w32_default_color_map): New function,
4541 extracted from Fw32_default_color_map.
4542 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4544 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4546 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4548 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4550 * keyboard.c (test_undefined): New function (bug#9751).
4551 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4553 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4555 * sysdep.c (init_sys_modes): Fix the check for the controlling
4556 terminal (Bug#6649).
4558 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4560 * dispextern.h (struct bidi_it): New member next_en_type.
4562 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4563 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4564 current character, check also for next_en_type being WEAK_EN.
4565 (bidi_resolve_weak): Don't enter the expensive loop if the current
4566 position is before next_en_pos. Record the bidi type of the first
4567 non-ET, non-BN character we find, in addition to its position.
4568 (bidi_level_of_next_char): Invalidate next_en_type when
4569 next_en_pos is over-stepped.
4571 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4573 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4574 * editfns.c: Rewrite current-time-zone so that it invokes
4575 the equivalent of (format-time-string "%Z") to get the time zone name.
4576 This fixes a bug when the time zone name contains characters that
4577 need converting from the system time locale to Emacs internal format.
4578 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4579 that patch fixed format-time-string to do the conversion, but
4580 I forgot to fix current-time-zone.
4581 (format_time_string): New function, containing most of
4582 what Fformat_time_string used to contain.
4583 (Fformat_time_string): Rewrite in terms of format_time_string.
4584 This doesn't change this function's behavior.
4585 (current-time-zone): Rewrite to use format_time_string.
4586 This fixes the bug reported by Michael Schierl in
4587 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4588 Jason Rumney's 2007-06-07 change worked around this bug, but
4590 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4592 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4594 * xdisp.c (start_display): If the character at POS is displayed
4595 via a display vector, reset IT->current.dpvec_index to zero.
4596 (try_window_reusing_current_matrix): If a line ends in a display
4597 vector or the next line starts in a display vector, continue
4598 redrawing the window even though the character position of
4599 start_row was reached.
4602 2011-10-18 Chong Yidong <cyd@gnu.org>
4604 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4605 with nobreak-char-display too.
4607 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4609 Fix part 3 of bug#9771.
4610 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4611 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4612 non-neutral characters if the current character is a paragraph
4613 separator (a.k.a. Newline). This avoids running the same
4614 expensive loop twice, once when we consume the preceding newline
4615 and the other time when the line actually needs to be displayed.
4616 Avoid the loop when we see neutrals on the base embedding level
4617 following a character whose directionality is the same as the
4618 paragraph's. This avoids running the expensive loop when a line
4619 ends in a long sequence of neutrals, like control characters.
4620 Add assertion against STRONG_AL type. Slightly rearrange code
4621 that determines the type of a neutral given the first non-neutral
4623 (bidi_level_of_next_char): Set next_en_pos to zero when
4624 invalidating its info.
4626 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4628 * xdisp.c (push_display_prop): Determine whether to record string
4629 or buffer position by IT->string, not by IT->method. Allow
4630 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4631 (move_it_vertically_backward): Don't look for character position
4632 immediately after the newline when in a continuation line.
4635 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4637 * window.c (coordinates_in_window): Rewrite and delabelize
4638 vertical border check. (Bug#5357) (Bug#9618)
4640 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4642 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4643 errors in XSetWindowBorder (bug#9310).
4645 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4647 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4648 avoid crash when xmalloc overrun checking is enabled.
4650 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4652 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4653 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4654 cursor motion with <left> and <right> arrow keys.
4656 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4657 some callers set that themselves.
4659 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4661 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4662 display string and the previous row comes from the same string and
4663 is empty. (Bug#9739) (Bug#9738)
4665 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4667 * doc.c (get_doc_string): Encode file name (bug#9735).
4669 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4671 * bidi.c (bidi_level_of_next_char):
4672 * xdisp.c (get_visually_first_element): Remove old incorrect
4673 comments regarding the Unicode Line Separator character.
4675 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4677 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4679 * alloc.c (Fgc_status): Do not access beyond zombies array
4680 boundary if nzombies > MAX_ZOMBIES.
4681 * alloc.c (dump_zombies): Add missing format specifier.
4683 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4685 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4686 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4688 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4689 Some packages use them to denote characters with modifiers.
4691 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4693 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4694 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4695 matching a pp-number. Rename parameter var to var1.
4697 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4699 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4701 2011-10-08 Glenn Morris <rgm@gnu.org>
4703 * callint.c (Fcall_interactively): Give a more explicit error for the
4704 'c' case with a non-character input. (Bug#8479)
4706 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4708 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4710 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4711 lines that are hscrolled on the left.
4713 * dispnew.c (buffer_posn_from_coords): Account for a possible
4714 presence of header-line. (Bug#4426)
4716 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4718 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4719 Don't advertise functionality which we discourage or doesn't work.
4721 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4723 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4724 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4725 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4726 this makes Emacs dump core during garbage collection on rare
4727 occasions. sizeof is obviously inferior to offsetof here, so
4728 stick with offsetof.
4729 (GC_POINTER_ALIGNMENT): New macro.
4730 (mark_memory): Omit 3rd (offset) arg; caller changed.
4731 Don't assume EMACS_INT alignment is the same as pointer alignment.
4733 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4735 * keyboard.c (read_key_sequence_remapped): New var.
4736 (read_key_sequence): Compute remapping in the right buffer.
4737 (command_loop_1): Use read_key_sequence's remapping directly.
4739 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4741 * dired.c (file_name_completion): Don't expand file name.
4742 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4743 before checking file name handler.
4745 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4746 they've been requested explicitly (bug#9591).
4748 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4750 * keymap.c (Fsingle_key_description): Use make_specified_string
4751 instead of build_string to build string from push_key_description.
4754 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4756 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4757 This fixes a Y2038 bug on 64-bit hosts.
4758 * buffer.c (reset_buffer):
4759 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4760 (Fclear_buffer_auto_save_failure):
4761 Use 0, not -1, to represent an unset failure time, since time_t
4762 might not be signed.
4764 Remove dependency on glibc malloc internals.
4765 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4766 Move back here from lisp.h, but with their new implementations.
4767 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4768 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4769 * charset.c (charset_table_init): New static var.
4770 (syms_of_charset): Use it instead of xmalloc. This removes a
4771 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4772 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4773 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4774 Move back to alloc.c.
4775 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4776 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4778 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4780 * nsterm.m (windowDidResize): Call x_set_window_size only when
4781 ns_in_resize is true. Otherwise set pixelwidth/height and
4782 call change_frame_size (Bug#9628).
4784 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4786 Port --enable-checking=all to Fedora 14 x86-64.
4787 * charset.c (syms_of_charset): Also account for glibc malloc's
4788 internal overhead when calculating the initial malloc maximum.
4790 Port --enable-checking=all to Fedora 14 x86.
4791 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4793 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4794 (overrun_check_realloc, overrun_check_free):
4795 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4796 That way, xmalloc returns a properly-aligned pointer even if
4797 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4798 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4799 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4800 into account when calculating the initial malloc maximum.
4801 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4802 Move here from alloc.c, so that charset.c can use it too.
4803 Properly align; the old code wasn't right for common 32-bit hosts
4804 when configured with --enable-checking=all.
4805 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4806 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4808 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4810 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4813 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4815 * xdisp.c (compute_display_string_end): If there's no display
4816 string at CHARPOS, return -1.
4818 * bidi.c (bidi_fetch_char): When compute_display_string_end
4819 returns a negative value, treat the character as a normal
4820 character not covered by a display string. (Bug#9624)
4822 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4824 * lread.c (Fread_from_string): Fix typo in docstring.
4826 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4828 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4829 newline, reseat the iterator instead of bidi-iterating there one
4830 character at a time. (Bug#9610)
4831 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4832 TO_CHARPOS if the bidi iterator is at base embedding level.
4834 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4836 * lread.c (readevalloop): Use correct code for NBSP.
4837 (read1): Likewise. (Bug#9608)
4839 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4841 * dbusbind.c (Fdbus_register_signal): When service is not
4842 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4844 2011-09-25 Glenn Morris <rgm@gnu.org>
4846 * buffer.c (truncate-lines): Doc fix.
4848 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4850 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4851 (Fset_window_next_buffers): Doc fix.
4853 2011-09-24 Glenn Morris <rgm@gnu.org>
4855 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4857 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4859 Fix minor problems found by static checking.
4860 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4861 * indent.c (Fvertical_motion): Fix == vs = typo.
4863 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4865 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4866 Default value is now t. Doc fix.
4868 * indent.c (Fvertical_motion): Compute and apply the overshoot
4869 logic when moving up, not only when moving down. Fix the
4870 confusing name and values of the it_overshoot_expected variable;
4871 logic changes accordingly. (Bug#9254) (Bug#9549)
4873 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4874 CHARPOS is covered by a display string which includes newlines.
4875 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4876 is covered by a display string with embedded newlines.
4878 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4880 * dbusbind.c (Fdbus_register_signal): Add match rule to
4881 Vdbus_registered_objects_table. (Bug#9581)
4882 (Fdbus_register_method, Vdbus_registered_objects_table):
4885 2011-09-24 Jim Meyering <meyering@redhat.com>
4887 do not ignore write error for any output size
4888 The previous change was incomplete.
4889 While it makes emacs --batch detect the vast majority of stdout
4890 write failures, errors were still ignored whenever the output size is
4891 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4892 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4893 && echo FAIL: ignored write error
4894 FAIL: ignored write error
4895 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4896 && echo FAIL: ignored write error
4897 FAIL: ignored write error
4898 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4900 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4902 * emacs.c (Fkill_emacs): In noninteractive mode exit
4903 non-successfully if a write error occurred on stdout. (Bug#9574)
4905 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4907 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4910 * dispextern.h (struct it): Update the comment documenting what
4913 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4915 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4916 a display string, extend search for cursor position to end of row.
4917 (find_row_edges): If the row ends in a newline from a display
4918 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4919 Handle the case of a display string with multiple newlines.
4920 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4921 non-empty line. Fixes confusing cursor motion with arrow keys at
4922 the beginning of a line that starts with whitespace.
4924 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4926 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4929 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4931 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4934 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4936 * xdisp.c (display_line): Record maximum and minimum buffer
4937 positions even if no glyphs were produced (e.g., by a zero-width
4938 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4939 buffer positions that will be removed from the glyph row because
4941 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4942 column is beyond frame width: don't subtract 1 "pixel" when
4943 computing width of the stretch.
4944 (reseat_at_next_visible_line_start): Undo the change made on
4945 2011-09-17 that saved paragraph information and restored it after
4946 the call to `reseat'. (Bug#9545)
4948 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4950 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4951 and turn window cursor on if cleared (Bug#9415).
4953 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4955 * search.c (boyer_moore): Take unibyte characters from pattern
4956 literally. (Bug#9458)
4958 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4960 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4962 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4964 Fix minor problem found by static checking.
4965 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4966 initialized, to pacify gcc -Wuninitialized.
4968 * fileio.c: Report proper errno when syscall falls.
4969 (Finsert_file_contents): Save and restore errno,
4970 so that report_file_error outputs the correct diagnostic.
4971 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4973 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4975 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4977 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4979 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4980 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4982 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4984 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4985 about the current paragraph and restore it after the call to reseat.
4987 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4988 (bidi_find_paragraph_start): Search back for paragraph beginning
4989 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4990 (bidi_move_to_visually_next): Only trigger paragraph-related
4991 computations when the last character is a newline or at EOB, not
4992 just any NEUTRAL_B. (Bug#9470)
4994 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4995 truncated lines if point is covered by a display string. (Bug#9524)
4997 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4999 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5000 (cons_to_x_long): New function.
5001 (lisp_data_to_selection_data): Use it. Correct the test for
5002 short-versus-long data; it was negated. Break out of vector
5003 loop, for efficiency, when a long datum is discovered.
5005 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5007 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5009 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5011 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5012 GCC PR/17406) by declaring this function with external scope.
5014 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5016 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5017 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5019 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5021 * editfns.c (Fformat): Correctly handle text properties on "%%".
5023 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5025 * xterm.c (x_draw_composite_glyph_string_foreground):
5026 * w32term.c (x_draw_composite_glyph_string_foreground):
5027 * term.c (encode_terminal_code):
5028 * composite.c (composition_update_it, get_composition_id):
5029 * xdisp.c (get_next_display_element)
5030 (fill_composite_glyph_string): Add comments about special meaning
5031 of TAB characters in a composition.
5033 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5035 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5036 This occurs when processing a multibyte format.
5037 Problem reported by Wolfgang Jenker.
5039 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5041 * xdisp.c (try_cursor_movement): Only check for exact match if
5042 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5044 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5046 Remove unused external symbols.
5047 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5048 * xdisp.c (calc_pixel_width_or_height): Now static.
5049 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5050 * indent.c (check_display_width):
5051 * w32term.c: Fix comment to match code.
5052 * xterm.c, xterm.h (x_catching_errors): Remove.
5054 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5056 * xselect.c: Use signed conversions more consistently (Bug#9498).
5057 (selection_data_to_lisp_data): Assume incoming selection data are
5058 signed integers, not unsigned. This is to be consistent with
5059 outgoing selection data, which was modified to use signed integers
5060 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5061 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5062 expects long, not unsigned long.
5064 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5066 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5067 computation of loop end. Reported by Johan Bockgård
5070 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5072 * frame.c (Fother_visible_frames_p): Function deleted.
5074 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5076 * indent.c (compute_motion): Process display vector front to back
5077 rather than the other way around. (Bug#2496)
5079 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5081 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5083 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5085 * minibuf.c (Fread_from_minibuffer): Doc fix.
5087 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5089 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5090 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5092 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5094 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5095 value for non-existent files.
5097 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5099 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5100 set its "size" to -1. This will set the modtime_size field of
5101 the corresponding buffer to -1, which is what
5102 verify-visited-file-modtime expects for files that do not exist.
5105 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5107 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5109 * lisp.h: ... from here. push_key_description is no longer
5110 defined in keyboard.c, so its declaration should not be in
5111 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5112 logically belongs with push_key_description.
5114 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5116 * buffer.h: Include <sys/types.h> instead of <time.h>.
5117 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5118 Problem reported by Herbert J. Skuhra.
5120 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5122 * xml.c (parse_region): Make the parsing work for
5123 non-comment-starting XML files again (bug#9144).
5125 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5127 * image.c (gif_load): Fix calculation of bottom and right corner.
5130 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5132 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5133 redisplay in small windows.
5135 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5137 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5139 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5141 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5142 Operate on live windows only.
5144 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5146 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5148 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5150 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5151 only under bidi iteration.
5153 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5155 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5157 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5159 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5160 Without this fix, the command to link temacs failed due to an
5161 undefined symbol __builtin_isnan. This is because
5162 /usr/include/iso/math_c99.h #defines isnan(x) to
5163 __builtin_isnan(x), but the bundled gcc, which identifies itself
5164 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5166 * floatfns.c (isnan): #undef, and then #define to a clone of
5168 (Fisnan): Always define, since it's always available now.
5169 (syms_of_floatfns): Always define isnan at the Lisp level.
5171 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5173 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5175 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5177 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5178 The previous code assumed that file offsets (off_t values) fit in
5179 EMACS_INT variables, which is not true on typical 32-bit hosts.
5180 The code messed up by falsely reporting buffer overflow in cases
5181 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5182 when "big" contains more than 2**29 bytes, even though this
5183 inserts just one byte and does not overflow the buffer.
5184 (Finsert_file_contents): Store file offsets as off_t
5185 values, not as EMACS_INT values. Check for overflow when
5186 converting between EMACS_INT and off_t. When checking for
5187 buffer overflow or for overlap, take the offsets into account.
5188 Don't use EMACS_INT for small values where int suffices.
5189 When checking for overlap, fix a typo: ZV was used where
5190 ZV_BYTE was intended.
5191 (Fwrite_region): Don't assume off_t fits into 'long'.
5192 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5194 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5196 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5198 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5200 sprintf-related integer and memory overflow issues (Bug#9412).
5202 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5203 (esprintf, exprintf, evxprintf): New functions.
5204 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5205 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5206 (modify_event_symbol): Do not assume that the length of
5207 name_alist_or_stem is safe to alloca and fits in int.
5208 (Fexecute_extended_command): Likewise for function name and binding.
5209 (Frecursion_depth): Wrap around reliably on integer overflow.
5210 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5211 since some callers pass EMACS_INT values.
5212 (Fsingle_key_description): Don't crash if symbol name contains more
5213 than MAX_ALLOCA bytes.
5214 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5215 (get_minibuffer): Arg is now EMACS_INT, not int.
5216 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5217 (esprintf, exprintf, evxprintf): New decls.
5218 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5220 * dbusbind.c (signature_cat): New function.
5221 (xd_signature, Fdbus_register_signal):
5222 Do not overrun buffer; instead, report string overflow.
5224 * dispnew.c (add_window_display_history): Don't overrun buffer.
5225 Truncate instead; this is OK since it's just a log.
5227 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5228 even if the time zone offset is outlandishly large.
5229 Don't mishandle offset == INT_MIN.
5231 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5232 when creating daemon; the previous buffer-overflow check was incorrect.
5234 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5235 which has the guts of the old verror function.
5237 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5238 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5240 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5241 (font_unparse_xlfd): Don't blindly alloca long strings.
5242 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5243 fits in int, when using sprintf. Use single snprintf to count
5244 length of string rather than counting it via multiple sprintfs;
5245 that's simpler and more reliable.
5246 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5247 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5248 sprintf, in case result does not fit in int.
5250 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5251 (fontset_from_font): Print it.
5253 * frame.c (tty_frame_count): Now printmax_t, not int.
5254 (make_terminal_frame, set_term_frame_name): Print it.
5255 (x_report_frame_params): In X, window IDs are unsigned long,
5256 not signed long, so print them as unsigned.
5257 (validate_x_resource_name): Check for implausibly long names,
5258 and don't assume name length fits in 'int'.
5259 (x_get_resource_string): Don't blindly alloca invocation name;
5260 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5263 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5264 (xg_check_special_colors, xg_set_geometry):
5265 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5267 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5268 Use esprintf, not sprintf, in case result does not fit in int.
5270 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5271 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5272 it as a large positive number.
5273 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5274 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5276 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5277 in case result does not fit in int.
5279 * print.c (float_to_string): Detect width overflow more reliably.
5280 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5281 buffer overrun. Don't assume list length fits in 'int'. Treat
5282 print length of 0 as 0, not as infinity; to be consistent with other
5283 uses of print length in this function. Don't overflow print length
5284 index. Don't assume hash table size fits in 'long', or that
5285 vectorlike size fits in 'unsigned long'.
5287 * process.c (make_process): Use printmax_t, not int, to format
5288 process-name gensyms.
5290 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5292 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5293 to avoid potential buffer overrun.
5295 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5296 if X resource line is longer than 512 bytes.
5298 * xfns.c (x_window): Make sprintf buffer a bit bigger
5299 to avoid potential buffer overrun.
5301 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5303 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5305 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5307 Integer overflow fixes for scrolling, etc.
5308 Without these, Emacs silently mishandles large integers sometimes.
5309 For example, "C-u 4294967297 M-x recenter" was treated as if
5310 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5312 * xdisp.c (try_window_id): Check Emacs fixnum range before
5313 converting to 'int'.
5315 * window.c (window_scroll_line_based, Frecenter):
5316 Check that an Emacs fixnum is in range before assigning it to 'int'.
5317 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5318 values converted from Emacs fixnums.
5319 (Frecenter): Don't wrap around a line count if it is out of 'int'
5320 range; instead, treat it as an extreme value.
5321 (Fset_window_configuration, compare_window_configurations):
5322 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5324 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5325 that can exceed INT_MAX. Check that EMACS_INT value is in range
5326 before assigning it to the (possibly-narrower) index.
5327 (match_limit): Don't assume that a fixnum can fit in 'int'.
5329 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5332 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5333 (Fvertical_motion): Don't wrap around LINES values that don't fit
5334 in 'int'. Instead, treat them as extreme values. This is good
5335 enough for windows, which can't have more than INT_MAX lines anyway.
5337 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5339 * Require libxml/parser.h to avoid compilation warning.
5341 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5343 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5344 since this reportedly can destroy thread storage.
5346 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5348 * syntax.c (find_defun_start): Update all cache variables if
5349 exiting early (Bug#9401).
5351 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5353 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5355 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5356 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5357 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5359 * term.c (tty_append_glyph): New function.
5360 (produce_stretch_glyph): Static function and its prototype deleted.
5362 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5365 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5367 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5368 when checking :margin (Bug#9390).
5369 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5370 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5371 so that the name doesn't mislead. All uses changed.
5373 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5375 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5378 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5380 * xdisp.c (move_it_to): Don't bail out early when reaching
5381 position beyond to_charpos, if we are scanning backwards.
5382 (move_it_vertically_backward): When DY == 0, make sure we get to
5383 the first character in the line after the newline.
5385 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5387 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5388 (ccl_driver): Do not generate an out-of-range pointer.
5389 (Fccl_execute_on_string): Remove unnecessary check for
5390 integer overflow, noted by Stefan Monnier in
5391 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5392 Remove a FIXME that didn't need fixing.
5393 Simplify the newly-introduced buffer reallocation code.
5395 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5397 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5399 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5401 Integer and memory overflow issues (Bug#9196).
5403 * doc.c (get_doc_string): Rework so that
5404 get_doc_string_buffer_size is the actual buffer size, rather than
5405 being 1 less than the actual buffer size; this makes xpalloc more
5408 * image.c (x_allocate_bitmap_record, cache_image):
5409 * xselect.c (Fx_register_dnd_atom):
5410 Simplify previous changes by using xpalloc.
5412 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5413 since either will do and ptrdiff_t is convenient with xpalloc.
5415 * charset.c (charset_table_size)
5416 (struct charset_sort_data.priority): Now ptrdiff_t.
5417 (charset_compare): Don't overflow if priorities differ greatly.
5418 (Fsort_charsets): Don't assume list length fits in int.
5419 Check for size-calculation overflow when allocating sort data.
5420 (syms_of_charset): Allocate an initial charset table that is
5421 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5423 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5425 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5426 The actual value is always <= INT_MAX, and leaving it unsigned made
5427 overflow checking harder.
5429 * dispextern.h (struct glyph_matrix.rows_allocated)
5430 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5431 with xpalloc. The values are still always <= INT_MAX.
5433 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5435 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5436 (SAFE_NALLOCA): New macro.
5438 * region-cache.c (struct boundary.pos, find_cache_boundary)
5439 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5440 (set_cache_region, invalidate_region_cache)
5441 (revalidate_region_cache, know_region_cache, region_cache_forward)
5442 (region_cache_backward, pp_cache):
5443 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5444 so that ptrdiff_t * can be passed to xpalloc.
5445 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5446 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5447 (pp_cache): Don't assume cache_len fits in int.
5448 * region-cache.h: Adjust extern decls to match.
5450 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5451 EMACS_INT, since either will do, for xpalloc.
5453 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5454 (xnmalloc, xnrealloc, xpalloc): New functions.
5456 * bidi.c (bidi_shelve_header_size): New constant.
5457 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5458 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5460 * bidi.c (bidi_cache_shrink):
5461 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5463 Don't update size of array until after memory allocation succeeds,
5464 because xmalloc/xrealloc may not return.
5465 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5466 now that we have proper integer overflow checking.
5467 (record_overlay_string, overlay_strings): Catch overflows when
5468 calculating size of overlay_str_buf.
5470 * callproc.c (Fcall_process): Check for size overflow when
5471 calculating size of args2.
5472 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5473 Normally we prefer signed values, but sticking with ptrdiff_t would
5474 require adding more-complicated checks.
5476 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5477 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5478 Redo buffer-overflow calculations to avoid integer overflow.
5479 Add a FIXME comment where memory seems to be over-allocated.
5481 * character.c (Fstring): Check for size-calculation overflow.
5483 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5484 unnecessary integer overflow. Check for size overflow.
5485 (encode_coding_object): Don't update size until xmalloc succeeds.
5487 * composite.c (get_composition_id): Check for overflow in glyph
5488 length calculations.
5490 Integer and memory overflow fixes for display code.
5491 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5492 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5493 (scrolling_window): Check for overflow in size calculations.
5494 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5495 Don't assume glyph table len fits in int.
5496 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5497 (row_table_size): Now ptrdiff_t, not int.
5498 (scrolling_window): Avoid overflow in size calculations.
5499 Don't update size until allocation succeeds.
5500 * fns.c (concat): Check for overflow in size calculations.
5501 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5502 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5503 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5505 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5506 (get_doc_string): Check for size calculation overflow.
5507 Don't update size until allocation succeeds.
5508 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5509 EMACS_INT, where ptrdiff_t will do.
5510 (Fsubstitute_command_keys): Check for string overflow.
5512 * editfns.c (set_time_zone_rule): Don't assume environment length
5514 (message_length): Now ptrdiff_t, not int.
5515 (Fmessage_box): Don't update size until allocation succeeds.
5516 Don't assume message length fits in int.
5517 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5519 * emacs.c (main): Do not reallocate argv, since there is a null at
5520 the end that can be overwritten, and this way there's no need to
5521 worry about size-calculation overflow.
5522 (sort_args): Check for size-calculation overflow.
5524 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5526 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5528 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5529 (x_set_scroll_bar_width, x_figure_window_size):
5530 Check for integer overflow.
5531 (x_set_alpha): Do not assume XINT fits in int.
5533 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5534 This is for the members text_lines, text_cols, total_lines, total_cols,
5535 where the system imposes an 'int' limit.
5537 * fringe.c (Fdefine_fringe_bitmap):
5538 Don't update size until alloc works.
5540 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5541 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5543 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5544 Check for size-calculation overflow.
5545 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5546 do, as we prefer signed integers.
5547 (id_to_widget.max_size, id_to_widget.used)
5548 (xg_store_widget_in_map, xg_remove_widget_from_map)
5549 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5550 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5551 Use and return ptrdiff_t, not int.
5552 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5553 * gtkutil.h: Change prototypes to match the above.
5555 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5556 are duplicate now that they've been promoted to lisp.h.
5557 (x_allocate_bitmap_record, x_alloc_image_color)
5558 (make_image_cache, cache_image, xpm_load):
5559 Don't update size until alloc is done.
5560 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5562 Check for size calculation overflow.
5563 (ct_colors_allocated_max): New constant.
5564 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5567 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5568 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5569 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5570 Use ptrdiff_t, not int, to count maps.
5571 (read_char_minibuf_menu_prompt): Check for overflow in size
5572 calculations. Don't update size until allocation succeeds.
5573 Redo calculations to avoid overflow.
5574 * keyboard.h: Change prototypes to match the above.
5576 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5578 (current_minor_maps): Check for size calculation overflow.
5579 * keymap.h: Change prototypes to match the above.
5581 * lread.c (read1, init_obarray): Don't update size until alloc done.
5583 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5584 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5586 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5587 Now ptrdiff_t, not int.
5588 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5589 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5591 * process.c (Fnetwork_interface_list): Check for overflow
5592 in size calculation.
5594 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5596 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5597 overflow. Don't bother calling xmalloc when xrealloc will do.
5599 * search.c (Freplace_match): Check for size calculation overflow.
5600 (Fset_match_data): Don't assume list lengths fit in 'int'.
5602 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5603 for command line length. Do not attempt to address one before the
5604 beginning of an array, as that's not portable.
5606 * term.c (max_frame_lines): Remove; unused.
5607 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5609 (encode_terminal_code, calculate_costs): Check for size
5610 calculation overflow.
5611 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5612 table lengths and related sizes. Don't update size until alloc
5613 done. Redo calculations to avoid overflow.
5614 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5616 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5617 subtracting pointers.
5618 (gobble_line): Check for overflow more carefully. Don't update size
5621 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5622 Don't update size until alloc done.
5623 Redo size calculations to avoid overflow.
5624 Check for size calculation overflow.
5625 (main) [DEBUG]: Fix typo in invoking tparam1.
5627 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5628 Use ptrdiff_t, not int, for sizes.
5629 (store_mode_line_noprop_char): Don't update size until alloc done.
5631 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5632 Use ptrdiff_t, not int, for sizes.
5633 (Finternal_make_lisp_face, cache_face):
5634 Check for size calculation overflow.
5635 (cache_face): Treat size calculation overflows as if they were
5636 memory exhaustion (the usual treatment), rather than aborting.
5638 * xfns.c (x_encode_text, x_set_name_internal)
5639 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5640 sizes, since they can exceed INT_MAX in size. Check for size
5641 calculation overflow.
5643 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5644 (xg_select): Check for size calculation overflow.
5645 Don't update size until alloc done.
5647 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5648 as sprintf is limited to int lengths.
5650 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5651 (X_LONG_MIN): New macros.
5652 Use them to make the following changes clearer.
5653 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5654 This change doesn't affect the value now, but it may help remind
5655 future maintainers not to raise the value too much later.
5656 (SELECTION_QUANTUM): Remove, replacing with ...
5657 (selection_quantum): ... new function, which avoids overflow.
5659 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5660 assumption that selection length fits in 'int'.
5661 (x_reply_selection_request, x_handle_selection_request)
5662 (x_get_window_property, receive_incremental_selection)
5663 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5664 (lisp_data_to_selection_data, clean_local_selection_data):
5665 Use ptrdiff_t, not int, to record length of selection.
5666 (x_reply_selection_request, x_get_window_property)
5667 (receive_incremental_selection, x_property_data_to_lisp):
5668 Redo calculations to avoid overflow.
5669 (x_reply_selection_request): When sending hint, ceiling it at
5670 X_LONG_MAX rather than relying on wraparound overflow to send
5672 (x_get_window_property, receive_incremental_selection)
5673 (lisp_data_to_selection_data, x_property_data_to_lisp):
5674 Check for size-calculation overflow.
5675 (x_get_window_property, receive_incremental_selection)
5676 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5677 Don't store size until memory allocation succeeds.
5678 (x_get_window_property): Plug memory leak on memory exhaustion.
5679 Don't double-block input; malloc is safe here. Don't assume 2**34
5680 - 4 fits in unsigned long. Add an xassert to check
5681 XGetWindowProperty overflow. Be more careful about overflow
5682 calculations, and distinguish size from memory overflow better.
5683 (receive_incremental_selection): When tracing, don't assume
5684 unsigned int is less than INT_MAX.
5685 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5686 harmful) conversions of unsigned short to int.
5687 (lisp_data_to_selection_data): Don't assume that integers
5688 in the range -65535 through -1 fit in an X unsigned short.
5689 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5690 result parameters unless successful. Rely on cons_to_unsigned
5691 to report problems with elements; the old code wasn't right anyway.
5692 (x_check_property_data): Check for int overflow; we cannot use
5693 a wider type due to X limits.
5694 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5696 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5698 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5699 (x_term_init): Check for size calculation overflow.
5700 (x_color_cells): Don't store size until memory allocation succeeds.
5701 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5702 Don't assume alloca size is less than MAX_ALLOCA.
5703 (x_term_init): Don't assume length fits in int (sprintf is limited
5706 Use ptrdiff_t for composition IDs.
5707 * character.c (lisp_string_width):
5708 * composite.c (composition_table_size, n_compositions)
5709 (get_composition_id, composition_gstring_from_id):
5710 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5711 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5712 * window.c (Frecenter):
5713 Use ptrdiff_t, not int, for composition IDs.
5714 * composite.c (get_composition_id): Check for integer overflow.
5715 * composite.h: Adjust prototypes to match the above changes.
5717 Use ptrdiff_t for hash table indexes.
5718 * category.c (hash_get_category_set):
5719 * ccl.c (ccl_driver):
5720 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5721 * coding.c (coding_system_charset_list, detect_coding_system):
5722 * coding.h (struct coding_system.id):
5723 * composite.c (get_composition_id, gstring_lookup_cache):
5724 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5725 * image.c (xpm_get_color_table_h):
5726 * lisp.h (hash_lookup, hash_put):
5727 * minibuf.c (Ftest_completion):
5728 Use ptrdiff_t for hash table indexes, not int (which is too
5729 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5730 32-bit --with-wide-int hosts).
5732 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5733 Add a FIXME comment about memory leaks.
5734 (syms_of_charset): Don't assume xmalloc returns.
5736 Don't assume that stated character widths fit in int.
5737 * character.c (Fchar_width, c_string_width, lisp_string_width):
5738 * character.h (CHAR_WIDTH):
5739 * indent.c (MULTIBYTE_BYTES_WIDTH):
5740 Use sanitize_char_width to avoid undefined and/or bad behavior
5741 with outlandish widths.
5742 * character.h (sanitize_tab_width): Rename from sanitize_width,
5743 now that we have two such functions. All uses changed.
5744 (sanitize_char_width): New inline function.
5746 Don't assume that tab-width fits in int.
5747 * character.h (sanitize_width): New inline function.
5748 (SANE_TAB_WIDTH): New macro.
5749 (ASCII_CHAR_WIDTH): Use it.
5750 * indent.c (sane_tab_width): Remove. All uses replaced by
5751 SANE_TAB_WIDTH (current_buffer).
5752 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5754 * fileio.c: Integer overflow issues with file modes.
5755 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5757 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5758 Remove unreachable code.
5759 (read_hex, load_charset_map_from_file): Check for integer overflow.
5761 * xterm.c: Don't go over XClientMessageEvent limit.
5762 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5763 (x_send_scroll_bar_event): Likewise. Check that the size does not
5764 exceed limits imposed by XClientMessageEvent, as well as the usual
5765 ptrdiff_t and size_t limits.
5767 * keyboard.c: Overflow, signedness and related fixes.
5768 (make_lispy_movement): Use same integer type in forward decl
5769 that is used in the definition.
5770 (read_key_sequence, keyremap_step):
5771 Change bufsize argument back to int, undoing my 2011-03-30 change.
5772 We prefer signed types, and int is wide enough here.
5773 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5774 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5775 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5776 length, not size_t. Use ptrdiff_t for index, not int.
5777 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5778 possibility of integer overflow.
5780 Overflow, signedness and related fixes for images.
5782 * dispextern.h (struct it.stack[0].u.image.image_id)
5783 (struct_it.image_id, struct image.id, struct image_cache.size)
5784 (struct image_cache.used, struct image_cache.ref_count):
5785 * gtkutil.c (update_frame_tool_bar):
5786 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5787 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5788 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5789 * nsmenu.m (update_frame_tool_bar):
5790 * xdisp.c (calc_pixel_width_or_height):
5791 * xfns.c (image_cache_refcount):
5792 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5793 on typical 64-bit hosts.
5795 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5796 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5797 Omit unnecessary casts to int.
5798 (parse_image_spec): Check that integers fall into 'int' range
5799 when the callers expect that.
5800 (image_ascent): Redo ascent calculation to avoid int overflow.
5801 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5802 (lookup_image): Remove unnecessary tests.
5803 (xbm_image_p): Locals are now of int, not EMACS_INT,
5804 since parse_image_check makes sure they fit into int.
5805 (png_load, gif_load, svg_load_image):
5806 Prefer int to unsigned where either will do.
5807 (tiff_handler): New function, combining the cores of the
5808 old tiff_error_handler and tiff_warning_handler.
5809 This function is rewritten to use vsnprintf and thereby avoid
5810 stack buffer overflows. It uses only the features of vsnprintf
5811 that are common to both POSIX and native Microsoft.
5812 (tiff_error_handler, tiff_warning_handler): Use it.
5813 (tiff_load, gif_load, imagemagick_load_image):
5814 Don't assume :index value fits in 'int'.
5815 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5816 (imagemagick_load_image): Check that crop parameters fit into
5817 the integer types that MagickCropImage accepts. Don't assume
5818 Vimagemagick_render_type has a nonnegative value. Don't assume
5819 size_t fits in 'long'.
5820 (gs_load): Use printmax_t to print the widest integers possible.
5821 Check for integer overflow when computing image height and width.
5823 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5825 * xdisp.c (redisplay_window): Don't force window start if point
5826 will be invisible in the resulting window. (Bug#9324)
5828 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5830 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5831 the display spec is of the form `(space ...)'.
5832 (handle_display_spec): Return the value returned by
5833 handle_single_display_spec, not just 1 or zero.
5834 (handle_single_display_spec): If the display spec is of the form
5835 `(space ...)', and specifies display in the text area, return 2
5837 (try_cursor_movement): Check for the need to scroll more
5838 accurately, and prefer exact match for point under bidi.
5839 Don't advance `row' beyond the last row of the window.
5841 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5842 into disp_prop; all users changed.
5844 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5845 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5846 for the text covered by the display property.
5848 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5850 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5851 Change return value to nil.
5852 (Frecord_buffer): Delete unused function.
5854 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5856 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5857 buffers, return left-to-right.
5858 (set_cursor_from_row): Consider candidate row a win if its glyph
5859 represents a newline and point is on that newline. Fixes cursor
5860 positioning on the newline at EOL of R2L text within L2R
5861 paragraph, and vice versa.
5862 (try_cursor_movement): Check continued rows, in addition to
5863 continuation rows. Fixes unwarranted scroll when point enters a
5864 continued line of R2L text within an L2R paragraph, or vice versa.
5865 (cursor_row_p): Consider the case of point being equal to
5866 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5867 from the end of a short line to the beginning of a continued line
5868 of R2L text within L2R paragraph.
5869 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5870 composed characters.
5872 * bidi.c (bidi_check_type): Use xassert.
5873 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5876 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5878 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5881 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5883 * nsfont.m (ns_otf_to_script): Fix typo.
5885 2011-08-22 Kenichi Handa <handa@m17n.org>
5887 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5888 extra slot even if the purpose is char-code-property-table.
5890 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5892 * xdisp.c (redisplay_window): When computing centering_position,
5893 account for the height of the header line. (Bug#8874)
5895 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5896 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5897 candidate is selected by the mouse, and that candidate has a
5898 composed character under the mouse.
5900 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5901 coordinates reported by pos-visible-in-window-p for a composed
5902 character in column zero.
5904 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5906 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5908 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5910 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5911 consider it a hit if to_charpos is anywhere in the range of the
5912 composed buffer positions.
5914 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5916 * image.c (gif_load): Don't assume that each subimage has the same
5917 dimensions as the base image. Handle disposal method that is
5918 "undefined" by the gif spec (Bug#9335).
5920 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5922 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5923 (Fcondition_case): Document `debug' symbol in error handler.
5925 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5927 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5928 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5929 from an Org mode buffer to a Speedbar frame.
5931 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5932 a composition, take its buffer position from IT->cmp_it.charpos.
5933 Fixes cursor positioning at the beginning of a line that begins
5934 with a composed character.
5936 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5938 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5939 character bidirectional type, use STRONG_L instead. Fixes crashes
5940 in a buffer produced by `describe-categories'.
5942 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5943 members before the level stack, so they would be saved and
5944 restored when copying iterator state. Fixes incorrect reordering
5945 around TABs covered by display properties.
5947 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5949 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5951 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5953 * eval.c (internal_condition_case, internal_condition_case_1)
5954 (internal_condition_case_2, internal_condition_case_n):
5955 Remove unnecessary aborts (Bug#9081).
5957 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5959 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5960 has no `load' handler, try opening the file locally. (Bug#9311)
5962 2011-08-16 Ken Brown <kbrown@cornell.edu>
5964 * gmalloc.c: Expand comment.
5966 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5968 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5969 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5971 2011-08-16 Ken Brown <kbrown@cornell.edu>
5973 Fix memory allocation problems in Cygwin build (Bug#9273).
5975 * unexcw.c ( __malloc_initialized): Declare external variable.
5976 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5978 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5980 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5982 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5984 [CYGWIN] (special_realloc): New function.
5985 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5986 requests to realloc storage in the static heap.
5988 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5990 * bidi.c (bidi_initialize): Remove unused local.
5992 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5995 * biditype.h: Remove file.
5996 * makefile.w32-in ($(BLD)/bidi.$(O)):
5997 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5999 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6001 * chartab.c: Improve commentary for the uniprop_table API.
6003 * bidi.c (bidi_paragraph_init): Support zero value of
6004 bidi_ignore_explicit_marks_for_paragraph_level.
6005 (bidi_initialize): Use uniprop_table instead of including
6006 biditype.h and bidimirror.h.
6008 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6009 coordinates of the iterator when restoring from ppos_it.
6012 2011-08-14 Kenichi Handa <handa@m17n.org>
6014 * process.c (create_process): Call setup_process_coding_systems
6015 after the pid of the process is set to -1 (Bug#8162).
6017 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6019 * xdisp.c (move_it_in_display_line_to): Don't invoke
6020 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6021 ppos_it. Fixes vertical cursor motion when line beginning is
6022 covered by an image. (Bug#9296)
6024 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6026 * nsterm.h (ns_run_ascript): Declare.
6027 (NSAPP_DATA2_RUNASSCRIPT): Define.
6029 * nsfns.m (as_script, as_result, as_status): New static variables.
6030 (ns_run_ascript): New function.
6031 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6032 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6033 the event loop. Get status from as_status (Bug#7276).
6035 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6036 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6037 the event loop (Bug#7276).
6039 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6041 * gnutls.c (QCgnutls_bootprop_priority)
6042 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6043 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6044 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6045 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6046 (QCgnutls_bootprop_verify_hostname_error)
6047 (QCgnutls_bootprop_callbacks_verify): Rename from
6048 Qgnutls_bootprop_..., all uses changed.
6050 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6053 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6055 * xfaces.c (Qframe_set_background_mode): Now static.
6056 * dispextern.h (Qframe_set_background_mode): Remove decl.
6058 * process.c (Fnetwork_interface_info): Declare local only if needed.
6060 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6062 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6063 (Fnetwork_interface_list): Allocate in increments of bytes instead
6064 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6065 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6067 (struct ifflag_def): notrailers is smart on OSX.
6068 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6069 Get hardware address with getifaddrs if available.
6071 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6073 * xdisp.c (iterate_out_of_display_property): xassert that
6074 IT->position is set to within IT->object's boundaries. Break from
6075 the loop as soon as EOB is reached; avoids infloops in redisplay
6076 when IT->position is set up wrongly due to some bug.
6077 Set IT->current to match the bidi iterator unconditionally.
6078 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6079 entry. Force push_it to save on the stack the current
6080 buffer/string position, to be restored by pop_it. Fix flags in
6081 the iterator structure wrt the object coming from a display
6082 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6083 properties. (Bug#9284)
6085 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6087 * fontset.c (fontset_get_font_group): Add proper type checks.
6090 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6092 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6093 and LC_VERSION_MIN_MACOSX.
6094 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6095 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6097 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6099 * xdisp.c (forward_to_next_line_start): Allow to use the
6100 no-display-properties-and-no-overlays under bidi display.
6101 Set disp_pos in the bidi iterator to avoid searches for display
6102 properties and overlays.
6104 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6106 * editfns.c (Fset_time_zone_rule): Document relationship with the
6109 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6110 the font entity extracted from the cache (Bug#8109).
6112 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6114 * composite.c (autocmp_chars): Don't reset point. That is done by
6115 restore_point_unwind (Bug#5984).
6117 2011-08-07 Juri Linkov <juri@jurta.org>
6119 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6120 to show the arg `TIME' instead of `TIMEVAL'.
6122 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6124 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6125 display property strides EOL and includes a newline, as in
6126 longlines-mode. (Bug#9254)
6127 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6128 word-wrap under bidirectional display. (Bug#9224)
6130 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6131 is non-zero, even if the data buffer is NULL. Fixes a crash in
6132 vertical-motion with longlines-mode. (Bug#9254)
6134 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6136 * bidi.c <bidi_cache_total_alloc>: Now static.
6137 (bidi_initialize): Initialize bidi_cache_total_alloc.
6139 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6142 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6143 amount allocated this far in `bidi_cache_total_alloc'.
6144 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6145 non-zero, only free the data buffer without restoring the cache
6146 contents. All callers changed.
6148 * dispextern.h (bidi_unshelve_cache): Update prototype.
6150 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6151 (move_it_in_display_line, move_it_to)
6152 (move_it_vertically_backward, move_it_by_lines): Replace the call
6153 to xfree to an equivalent call to bidi_unshelve_cache.
6154 (move_it_in_display_line_to): Fix logic of returning
6155 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6157 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6159 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6160 came from a string character with a `cursor' property. (Bug#9229)
6162 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6164 * Makefile.in (LIB_PTHREAD): New variable.
6165 (LIBES): Add LIB_PTHREAD (Bug#9216).
6167 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6168 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6170 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6172 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6174 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6176 * xterm.c (x_find_topmost_parent): New function.
6177 (x_set_frame_alpha): Find topmost parent window with
6178 x_find_topmost_parent and set the property there also (bug#9181).
6179 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6181 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6183 * callproc.c (Fcall_process): Avoid vfork clobbering
6184 the local vars buffer, coding_systems, current_dir.
6186 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6188 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6190 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6192 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6193 so that it is not optimized away.
6195 * xdisp.c (compute_display_string_pos): Remove unused local.
6197 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6199 Fix slow cursor motion and scrolling in large buffers with
6200 selective display, like Org Mode buffers. (Bug#9218)
6202 * dispextern.h (struct bidi_it): New member disp_prop_p.
6204 * xdisp.c: Remove one-slot cache of display string positions.
6205 (compute_display_string_pos): Accept an additional argument
6206 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6207 for a display string or property. If found, set DISP_PROP_P
6210 * bidi.c (bidi_fetch_char): Accept an additional argument
6211 DISP_PROP_P, and pass it to compute_display_string_pos.
6212 Only handle text covered by a display string if DISP_PROP_P is returned
6213 non-zero. All callers of bidi_fetch_char changed.
6215 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6217 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6219 2010-12-03 Don March <don@ohspite.net>
6221 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6222 last character M-[char] is translated to ESC [char] (bug#7541).
6224 2011-08-02 Kenichi Handa <handa@m17n.org>
6226 * lisp.h (uniprop_table): Extern it.
6228 * chartab.c (uniprop_table): Make it non-static.
6230 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6232 * xdisp.c (forward_to_next_line_start): Accept additional argument
6233 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6235 (reseat_at_next_visible_line_start): Use the bidi iterator state
6236 returned by forward_to_next_line_start to restore the state of
6237 it->bidi_it after backing up to previous newline. (Bug#9212)
6239 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6241 * regex.c (re_comp): Protoize.
6242 (re_exec): Fix return type.
6243 (regexec): Fix type of `ret'. (Bug#9203)
6245 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6247 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6248 This is needed if max-image-size is a floating-point number.
6250 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6252 * print.c (print_object): Print empty symbol as ##.
6254 * lread.c (read1): Read ## as empty symbol.
6256 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6258 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6259 setting frame foreground color (Bug#9175).
6260 (x_set_background_color): Likewise.
6262 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6263 contents (Bug#9176).
6264 (EmacsTooltip -init): Remove bezels and add shadows to
6267 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6268 or scroll bar (Bug#8470).
6270 * nsfont.m (nsfont_open): Remove assignment to voffset and
6271 unnecessary vars hshink, expand, hd, full_height, min_height.
6272 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6274 * nsterm.h (nsfont_info): Remove voffset field.
6276 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6278 Implement strike-through and overline on NextStep (Bug#8863).
6280 * nsfont.m (nsfont_open): Use underline position provided by font,
6281 instead of hard-coded value of 2.
6282 (nsfont_draw): Call ns_draw_text_decoration instead.
6284 * nsterm.h: Add declaration for ns_draw_text_decoration.
6286 * nsterm.m (ns_draw_text_decoration): New function for drawing
6287 underline, overline, and strike-through.
6288 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6289 ns_draw_text_decoration. Change treatment of cursor drawing to
6290 accommodate underlining, etc.
6292 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6294 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6297 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6299 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6300 Without this fix, if a signal arrives just after memory fills up,
6301 'malloc' might be invoked reentrantly.
6303 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6304 In other words, assume that every image size is allowed, on non-X
6305 hosts. This assumption is probably wrong, but it lets Emacs compile.
6307 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6309 * regex.c (re_iswctype): Convert return values to boolean.
6311 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6313 * xdisp.c (compute_display_string_pos): Don't use cached display
6314 string position if the buffer had its restriction changed.
6317 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6319 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6321 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6323 Integer signedness and overflow and related fixes. (Bug#9079)
6325 * bidi.c: Integer size and overflow fixes.
6326 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6327 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6328 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6329 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6330 (bidi_find_other_level_edge):
6331 Use ptrdiff_t instead of EMACS_INT where either will do.
6332 This works better on 32-bit hosts configured --with-wide-int.
6333 (bidi_cache_ensure_space): Check for size-calculation overflow.
6334 Use % rather than repeated addition, for better worst-case speed.
6335 Don't set bidi_cache_size until after xrealloc returns, because it
6337 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6338 (bidi_cache_ensure_space): Also check that the bidi cache size
6339 does not exceed that of the largest Lisp string or buffer. See Eli
6340 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6342 * alloc.c (__malloc_size_t): Remove.
6343 All uses replaced by size_t. See Andreas Schwab's note
6344 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6346 * image.c: Improve checking for integer overflow.
6347 (check_image_size): Assume that f is nonnull, since
6348 it is always nonnull in practice. This is one less thing to
6349 worry about when checking for integer overflow later.
6350 (x_check_image_size): New function, which checks for integer
6351 overflow issues inside X.
6352 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6353 This removes the need for a memory_full check.
6354 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6355 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6356 (xbm_read_bitmap_data): Change locals back to 'int', since
6357 their values must fit in 'int'.
6358 (xpm_load_image, png_load, tiff_load):
6359 Invoke x_create_x_image_and_pixmap earlier,
6360 to avoid much needless work if the image is too large.
6361 (tiff_load): Treat overly large images as if
6362 x_create_x_image_and_pixmap failed, not as malloc failures.
6363 (gs_load): Use x_check_image_size.
6365 * gtkutil.c: Omit integer casts.
6366 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6367 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6369 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6371 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6372 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6373 would wrongly return t on a 64-bit host.
6375 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6376 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6377 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6378 and therefore cause GCC to emit a bogus diagnostic in some cases.
6380 * image.c: Integer signedness and overflow and related fixes.
6381 This is not an exhaustive set of fixes, but it's time to
6382 record what I've got.
6383 (lookup_pixel_color, check_image_size): Remove redundant decls.
6384 (check_image_size): Don't assume that arbitrary EMACS_INT values
6385 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6386 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6387 (tiff_load, imagemagick_load_image):
6388 Check for overflow in size calculations.
6389 (x_create_x_image_and_pixmap): Remove unnecessary test for
6390 xmalloc returning NULL; that can't happen.
6391 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6392 (xpm_color_bucket): Use better integer hashing function.
6393 (xpm_cache_color): Don't possibly over-allocate memory.
6394 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6395 (gif_memory_source):
6396 Use ptrdiff_t, not int or size_t, to record sizes.
6397 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6398 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6399 either works, as we prefer signed integers.
6400 (tiff_read_from_memory, tiff_write_from_memory):
6401 Return tsize_t, not size_t, since that's what the TIFF API wants.
6402 (tiff_read_from_memory): Don't fail simply because the read would
6403 go past EOF; instead, return a short read.
6404 (tiff_load): Omit no-longer-needed casts.
6405 (Fimagemagick_types): Don't assume size fits into 'int'.
6407 Improve hashing quality when configured --with-wide-int.
6408 * fns.c (hash_string): New function, taken from sxhash_string.
6409 Do not discard information about ASCII character case; this
6410 discarding is no longer needed.
6411 (sxhash-string): Use it. Change sig to match it. Caller changed.
6412 * lisp.h: Declare it.
6413 * lread.c (hash_string): Remove, since we now use fns.c's version.
6414 The fns.c version returns a wider integer if --with-wide-int is
6415 specified, so this should help the quality of the hashing a bit.
6417 * emacs.c: Integer overflow minor fix.
6418 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6419 Define only if GNU_LINUX.
6420 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6422 * dispnew.c: Integer signedness and overflow fixes.
6423 Remove unnecessary forward decls, that were a maintenance hassle.
6424 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6426 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6427 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6428 (prepare_desired_row, line_draw_cost):
6429 Use int, not unsigned, where either works.
6430 (save_current_matrix, restore_current_matrix):
6431 Use ptrdiff_t, not size_t, where either works.
6432 (init_display): Check for overflow more accurately, and without
6433 relying on undefined behavior.
6435 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6436 Remove, replacing with the new symbols in lisp.h. All uses changed.
6437 * fileio.c (make_temp_name):
6438 * filelock.c (lock_file_1, lock_file):
6439 * xdisp.c (message_dolog):
6440 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6441 Use pMd etc. instead.
6442 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6443 replacing the pWIDE etc. symbols removed from editfns.c.
6445 * keyboard.h (num_input_events): Now uintmax_t.
6446 This is (very slightly) less likely to mess up due to wraparound.
6449 * buffer.c: Integer signedness fixes.
6450 (alloc_buffer_text, enlarge_buffer_text):
6451 Use ptrdiff_t rather than size_t when either will do, as we prefer
6454 * alloc.c: Integer signedness and overflow fixes.
6455 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6456 (__malloc_size_t): Default to size_t, not to int.
6457 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6458 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6459 Prefer ptrdiff_t to size_t when either would do, as we prefer
6461 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6462 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6463 Now const. Initialize with values that are in range even if char
6465 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6466 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6467 These functions do the right thing with sizes > 2**32.
6468 (check_depth): Now ptrdiff_t, not int.
6469 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6470 Adjust to new way of storing sizes. Check for size overflow bugs
6472 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6473 slightly wrong anyway, as it missed one instance of
6474 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6475 (refill_memory_reserve): Omit needless cast to size_t.
6476 (mark_object_loop_halt): Mark as externally visible.
6478 * xselect.c: Integer signedness and overflow fixes.
6479 (Fx_register_dnd_atom, x_handle_dnd_message):
6480 Use ptrdiff_t, not size_t, since we prefer signed.
6481 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6482 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6483 x_dnd_atoms_size and x_dnd_atoms_length.
6485 * doprnt.c: Prefer signed to unsigned when either works.
6487 * doprnt.c (doprnt):
6489 * xdisp.c (vmessage):
6490 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6491 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6492 prefer signed arithmetic to avoid comparison confusion.
6493 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6494 but is a bit tricky.
6496 Assume freestanding C89 headers, string.h, stdlib.h.
6497 * data.c, doprnt.c, floatfns.c, print.c:
6498 Include float.h unconditionally.
6499 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6500 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6501 * regex.c: Likewise for stddef.h, string.h.
6502 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6503 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6504 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6505 (STDC_HEADERS): Remove obsolete defines.
6506 * sysdep.c: Include limits.h unconditionally.
6508 Assume support for memcmp, memcpy, memmove, memset.
6509 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6510 * regex.c (memcmp, memcpy):
6511 Remove; we assume C89 now.
6513 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6514 (__malloc_safe_bcopy): Remove; no longer needed.
6516 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6517 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6518 well either way, and we prefer signed to unsigned.
6520 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6522 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6523 closes the connection while we're reading (bug#9182).
6525 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6527 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6528 are specified (Bug#9168).
6530 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6532 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6533 Found by GCC static checking and --with-wide-int on a 32-bit host.
6535 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6537 * xdisp.c (compute_display_string_pos): Fix logic of caching
6538 previous display string position. Initialize cached_prev_pos to
6539 -1. Fixes slow-down at the beginning of a buffer.
6541 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6543 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6544 for attrs[LFACE_FONTSET_INDEX].
6546 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6548 * xml.c (parse_region): Remove unused local
6549 that was recently introduced.
6551 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6553 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6554 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6556 * xdisp.c (move_it_in_display_line_to): Record the best matching
6557 position for TO_CHARPOS while scanning the line, and restore it on
6558 exit if none of the characters scanned was an exact match.
6559 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6560 when exact match is impossible due to invisible text, and the
6561 lines are truncated.
6563 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6565 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6568 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6570 Fix a significant slow-down of cursor motion with C-n, C-p,
6571 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6572 auto-repeat under bidi redisplay in fontified buffers.
6573 * xdisp.c (compute_stop_pos_backwards): New function.
6574 (next_element_from_buffer): Call compute_stop_pos_backwards to
6575 find a suitable prev_stop when we find ourselves before
6577 (reseat): Don't look for prev_stop, as that could mean a very long
6579 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6580 <cached_disp_overlay_modiff>: Cache for last found display string
6582 (compute_display_string_pos): Return the cached position if asked
6583 about the same buffer in the same area of character positions, and
6584 the buffer wasn't changed since the time the display string
6585 position was cached.
6587 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6589 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6590 is an integer, which is important for empty lines. (Bug#9149)
6592 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6594 * frame.c (Fmodify_frame_parameters): In tty case, update the
6595 default face if necessary (Bug#4238).
6597 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6599 * editfns.c (Fstring_to_char): No need to explain what a character
6600 is in the docstring (Bug#6576).
6602 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6604 * xml.c (parse_region): Make sure we always return a tree.
6606 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6608 * xml.c (parse_region): If a document contains only comments,
6611 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6613 * xml.c (make_dom): Return comments, too.
6615 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6618 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6619 and the surrounding thread.
6620 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6621 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6622 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6624 * s/openbsd.h (BROKEN_SIGIO): Define.
6625 * unexelf.c (unexec) [__OpenBSD__]:
6626 Don't update the .mdebug section of the Alpha COFF symbol table.
6628 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6630 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6633 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6635 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6636 This fixes some race conditions on the permissions of any newly
6639 * alloc.c (valid_pointer_p): Use pipe, not open.
6640 This fixes some permissions issues when debugging.
6642 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6643 If fchown fails to set both uid and gid, try to set just gid,
6644 as that is sometimes allowed. Adjust the file's mode to eliminate
6645 setuid or setgid bits that are inappropriate if fchown fails.
6647 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6649 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6650 to compare Lisp_Objects.
6651 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6652 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6653 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6655 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6657 * lread.c (read_integer): Unread even EOF character.
6658 (read1): Likewise. Properly record start position of symbol.
6660 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6661 symbol character follows.
6663 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6665 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6666 This works around a problem with the previous change to Fcopy_file.
6667 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6668 and without this change, GCC might complain about discarding
6669 fchown's return value.
6671 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6673 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6675 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6677 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6679 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6681 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6682 it's used from the C level.
6684 * process.c: Use the same condition for POLL_FOR_INPUT in both
6685 keyboard.c and process.c (bug#1858).
6687 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6689 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6690 (Fgnutls_boot): Use it.
6692 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6694 * doc.c (Fsubstitute_command_keys): Revert last change.
6696 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6698 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6699 quotes the next character, and doesn't affect other longer
6700 sequences (bug#8935).
6702 * lread.c (syms_of_lread): Clarify that is isn't only
6703 `eval-buffer' and `eval-defun' that's affected by
6704 `lexical-binding' (bug#8460).
6706 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6708 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6709 bidi redisplay when a line includes both an image and is truncated.
6711 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6713 Fix minor problems found by static checking.
6714 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6715 (elsz): Now a signed constant, not a size_t var. We prefer signed
6716 types to unsigned, to avoid integer comparison confusion. Without
6717 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6718 "cannot optimize loop, the loop counter may overflow", a symptom
6720 * indent.c (Fvertical_motion): Mark locals as initialized.
6721 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6723 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6725 * search.c (Fre_search_backward): Mention `case-fold-search' in
6726 all the re_search_* functions (bug#8138).
6728 * keyboard.c (Fopen_dribble_file): Document when the file is
6731 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6733 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6736 Support bidi reordering of display and overlay strings.
6737 * xdisp.c (compute_display_string_pos)
6738 (compute_display_string_end): Accept additional argument STRING.
6739 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6740 (reseat_to_string): Initialize bidi_it->string.s and
6741 bidi_it->string.schars.
6742 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6743 NULL (avoids a crash in bidi_paragraph_init).
6744 Initialize itb.string.lstring.
6745 (init_iterator): Call bidi_init_it only of a valid
6746 buffer position was specified. Initialize paragraph_embedding to
6748 (reseat_to_string): Initialize the bidi iterator.
6749 (display_string): If we need to ignore text properties of
6750 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6751 original value of -1 will not work with bidi.)
6752 (compute_display_string_pos): First arg is now struct
6753 `text_pos *'; all callers changed. Support display properties on
6755 (compute_display_string_end): Support display properties on Lisp
6757 (init_iterator, reseat_1, reseat_to_string): Initialize the
6758 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6759 when iterating on a string not from display properties).
6760 (compute_display_string_pos, compute_display_string_end):
6761 Fix calculation of the object to scan. Fixes an error when using
6763 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6764 base_level_stop; instead, set base_level_stop to BEGV.
6765 Fixes crashes in vertical-motion.
6766 (next_element_from_buffer): Improve commentary for when
6767 the iterator is before prev_stop.
6768 (init_iterator): Initialize bidi_p from the default value of
6769 bidi-display-reordering, not from buffer-local value. Use the
6770 buffer-local value only if initializing for buffer iteration.
6771 (handle_invisible_prop): Support invisible properties on strings
6772 that are being bidi-reordered.
6773 (set_iterator_to_next): Support bidi reordering of C strings and
6775 (next_element_from_string): Support bidi reordering of Lisp
6777 (handle_stop_backwards): Support Lisp strings as well.
6778 (display_string): Support display of R2L glyph rows.
6779 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6780 (init_iterator): Don't initialize it->bidi_p for strings
6782 (reseat_to_string): Initialize it->bidi_p for strings here.
6783 (next_element_from_string, next_element_from_c_string)
6784 (next_element_from_buffer): Add xassert's for correspondence
6785 between IT's object being iterated and it->bidi_it.string
6787 (face_before_or_after_it_pos): Support bidi iteration.
6788 (next_element_from_c_string): Handle the case of the first string
6789 character that is not the first one in the visual order.
6790 (get_visually_first_element): New function, refactored from common
6791 parts of next_element_from_buffer, next_element_from_string, and
6792 next_element_from_c_string.
6793 (tool_bar_lines_needed, redisplay_tool_bar)
6794 (display_menu_bar): Force left-to-right direction. Add a FIXME
6795 comment for making that be controlled by a user option.
6796 (push_it, pop_it): Save and restore the state of the
6797 bidi iterator. Save and restore the bidi_p flag.
6798 (pop_it): Iterate out of display property for string iteration as
6800 (iterate_out_of_display_property): Support iteration over strings.
6801 (handle_single_display_spec): Set up it->bidi_it for iteration
6802 over a display string, and call bidi_init_it.
6803 (handle_single_display_spec, next_overlay_string)
6804 (get_overlay_strings_1, push_display_prop): Set up the bidi
6805 iterator for displaying display or overlay strings.
6806 (forward_to_next_line_start): Don't use the shortcut if
6808 (back_to_previous_visible_line_start): If handle_display_prop
6809 pushed the iterator stack, restore the internal state of the bidi
6810 iterator by calling bidi_pop_it same number of times.
6811 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6812 and we are bidi-iterating, don't decrement the iterator position;
6813 instead, set the first_elt flag in the bidi iterator, to produce
6815 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6816 (push_display_prop): xassert that we are iterating a buffer.
6817 (push_it, pop_it): Save and restore paragraph_embedding member.
6818 (handle_single_display_spec, next_overlay_string)
6819 (get_overlay_strings_1, reseat_1, reseat_to_string)
6820 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6821 correctly. Don't assume unibyte strings are not bidi-reordered.
6822 (compute_display_string_pos)
6823 (compute_display_string_end): Fix handling the case of C string.
6824 (push_it, pop_it): Save and restore from_disp_prop_p.
6825 (handle_single_display_spec, push_display_prop): Set the
6826 from_disp_prop_p flag.
6827 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6828 (pop_it): Call iterate_out_of_display_property only if we are
6829 popping after iteration over a string that came from a display
6830 property. Fix a typo in popping stretch info. Add an assertion
6831 for verifying that the iterator position is in sync with the bidi
6833 (handle_single_display_spec, get_overlay_strings_1)
6834 (push_display_prop): Fix initialization of paragraph direction for
6835 string when that of the parent object is not yet determined.
6836 (reseat_1): Call bidi_init_it to resync the bidi
6837 iterator with IT's position. (Bug#7616)
6838 (find_row_edges): If ROW->start.pos gives position
6839 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6840 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6841 Reset the from_disp_prop_p flag.
6842 (SAVE_IT, RESTORE_IT): New macros.
6843 (pos_visible_p, face_before_or_after_it_pos)
6844 (back_to_previous_visible_line_start)
6845 (move_it_in_display_line_to, move_it_in_display_line)
6846 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6847 (try_scrolling, redisplay_window, display_line): Use them when
6848 saving a temporary copy of the iterator and restoring it back.
6849 (back_to_previous_visible_line_start, reseat_1)
6850 (init_iterator): Empty the bidi cache "stack".
6851 (move_it_in_display_line_to): If iterator ended up at
6852 EOL, but we never saw any buffer positions smaller than
6853 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6854 motion in bidi-reordered lines.
6855 (move_it_in_display_line_to): Record prev_method and prev_pos
6856 immediately before the call to set_iterator_to_next. Fixes cursor
6857 motion in bidi-reordered lines with stretch glyphs and strings
6858 displayed in margins. (Bug#8133) (Bug#8867)
6859 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6861 (pos_visible_p): Support positions in bidi-reordered lines.
6862 Save and restore bidi cache.
6864 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6865 (bidi_paragraph_info): Delete unused struct.
6866 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6867 (bidi_cache_start): New variable.
6868 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6870 (bidi_cache_fetch_state, bidi_cache_search)
6871 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6872 (bidi_cache_find, bidi_peek_at_next_level)
6873 (bidi_level_of_next_char, bidi_find_other_level_edge)
6874 (bidi_move_to_visually_next): Compare cache index with
6875 bidi_cache_start rather than with zero.
6876 (bidi_fetch_char): Accept new argument STRING; all callers
6877 changed. Support iteration over a string. Support strings with
6878 display properties. Support unibyte strings. Fix the type of
6879 `len' according to what STRING_CHAR_AND_LENGTH expects.
6880 (bidi_paragraph_init, bidi_resolve_explicit_1)
6881 (bidi_resolve_explicit, bidi_resolve_weak)
6882 (bidi_level_of_next_char, bidi_move_to_visually_next):
6883 Support iteration over a string.
6884 (bidi_set_sor_type, bidi_resolve_explicit_1)
6885 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6886 can now be zero (for strings); special values 0 and -1 were
6887 changed to -1 and -2, respectively.
6888 (bidi_char_at_pos): New function.
6889 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6890 Call it instead of FETCH_MULTIBYTE_CHAR.
6891 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6892 initialized to valid values.
6893 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6895 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6896 the test for valid cached positions. Fix the logic for looking up
6897 the sentinel state in the cache. GCPRO the Lisp string we are
6899 (bidi_push_it, bidi_pop_it): New functions.
6900 (bidi_initialize): Initialize the bidi cache start stack pointer.
6901 (bidi_cache_ensure_space): New function, refactored from part of
6902 bidi_cache_iterator_state. Don't assume the required size is just
6903 one BIDI_CACHE_CHUNK away.
6904 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6905 (bidi_count_bytes, bidi_char_at_pos): New functions.
6906 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6907 always valid if bidi_cache_idx is valid.
6908 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6909 is valid if it's going to be used.
6910 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6911 (bidi_cache_fetch_state, bidi_cache_search)
6912 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6913 (bidi_cache_iterator_state, bidi_cache_find)
6914 (bidi_find_other_level_edge, bidi_cache_start_stack):
6915 All variables related to cache indices are now EMACS_INT.
6917 * dispextern.h (struct bidi_string_data): New structure.
6918 (struct bidi_it): New member `string'. Make flag members be 1-bit
6919 fields, and put them last in the struct.
6920 (compute_display_string_pos, compute_display_string_end):
6922 (bidi_push_it, bidi_pop_it): Add prototypes.
6923 (struct iterator_stack_entry): New members bidi_p,
6924 paragraph_embedding, and from_disp_prop_p.
6925 (struct it): Member bidi_p is now a bit field 1 bit wide.
6926 (bidi_shelve_cache, bidi_unshelve_cache):
6929 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6930 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6931 and vector-like objects.
6933 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6934 cache around display iteration.
6936 * window.c (Fwindow_end, window_scroll_pixel_based)
6937 (displayed_window_lines, Frecenter): Save and restore the bidi
6938 cache around display iteration.
6940 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6942 * editfns.c (Fdelete_region): Clarify the use of the named
6943 parameters (bug#6788).
6945 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6947 * indent.c (Fvertical_motion): Set and restore w->pointm when
6948 saving and restoring the window's buffer (Bug#9006).
6950 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6952 * editfns.c (Fstring_to_char): Clarify just what is returned
6953 (bug#6576). Text by Eli Zaretskii.
6955 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6957 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6959 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6961 * buffer.c (mmap_find): Fix a typo.
6963 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6965 Fix execution of x selection hooks.
6966 * xselect.c (Qx_lost_selection_functions)
6967 (Qx_sent_selection_functions): New vars.
6968 (syms_of_xselect): DEFSYM them.
6969 (x_handle_selection_request): Pass Qx_sent_selection_functions
6970 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6971 (x_handle_selection_clear,x_clear_frame_selections):
6972 Pass Qx_lost_selection_functions rather than
6973 Vx_lost_selection_functions to Frun_hook_with_args.
6975 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6977 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6978 The old code sometimes used this field without initializing it.
6980 * alloc.c (gc_sweep): Don't read past end of array.
6981 In theory, the old code could also have corrupted Emacs internals,
6982 though it'd be very unlikely.
6984 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6986 * character.c (Fcharacterp): Don't advertise optional ignored
6987 argument. (Bug#4026)
6989 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6991 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6994 * window.c (Fset_window_start): Doc fix (bug#4199).
6995 (Fset_window_hscroll): Ditto.
6997 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6999 Fix minor new problems caught by GCC 4.6.1.
7000 * term.c (init_tty): Remove unused local.
7001 * xsettings.c (store_monospaced_changed): Define this function only
7002 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7005 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7007 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7009 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7011 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7012 are the mini-buffer and the echo area (bug#3320).
7014 * term.c (init_tty): Remove support for supdup, c10 and perq
7015 terminals, which are no longer supported (bug#1482).
7017 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7019 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7021 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7023 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7024 for non-popups (Bug#3642).
7026 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7028 * alloc.c (reset_malloc_hooks): Protoize.
7029 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7030 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7031 * cm.c (losecursor): Likewise.
7032 * data.c (fmod): Likewise.
7033 * dispnew.c (swap_glyphs_in_rows): Likewise.
7034 * emacs.c (memory_warning_signal): Likewise.
7035 * floatfns.c (float_error): Likewise.
7036 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7037 (otf_open, font_otf_capability, generate_otf_features)
7038 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7040 * image.c (pbm_read_file): Likewise.
7041 * indent.c (string_display_width): Likewise.
7042 * intervals.c (check_for_interval, search_for_interval)
7043 (inc_interval_count, count_intervals, root_interval)
7044 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7045 * lread.c (defalias): Likewise.
7046 * ralloc.c (r_alloc_check): Likewise.
7047 * regex.c (set_image_of_range_1, set_image_of_range)
7048 (regex_grow_registers): Likewise.
7049 * sysdep.c (strerror): Likewise.
7050 * termcap.c (valid_filename_p, tprint, main): Likewise.
7051 * tparam.c (main): Likewise.
7052 * unexhp9k800.c (run_time_remap, save_data_space)
7053 (update_file_ptrs, read_header, write_header, calculate_checksum)
7054 (copy_file, copy_rest, display_header): Likewise.
7055 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7057 * xdisp.c (check_it): Likewise.
7058 * xfaces.c (register_color, unregister_color, unregister_colors):
7060 * xfns.c (print_fontset_result): Likewise.
7061 * xrdb.c (member, fatal, main): Likewise.
7063 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7065 Fix minor problems found by static checking (Bug#9031).
7066 * chartab.c (char_table_set_range, map_sub_char_table):
7067 Remove unused locals.
7068 (uniprop_table): Now static.
7069 * composite.c (_work_char): Remove unused static var.
7071 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7073 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7075 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7077 * gtkutil.c (qttip_cb): Remove code without function.
7079 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7081 * w32.c (pthread_sigmask): New stub.
7083 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7085 Use pthread_sigmask, not sigprocmask (Bug#9010).
7086 sigprocmask is portable only for single-threaded applications, and
7087 Emacs can be multi-threaded when it uses GTK.
7088 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7090 * callproc.c (Fcall_process):
7091 * process.c (create_process):
7092 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7093 Use pthread_sigmask, not sigprocmask.
7095 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7097 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7098 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7101 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7103 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7104 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7105 (xg_hide_tooltip): Fix comment.
7107 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7108 in registerServicesMenuSendTypes.
7109 (validRequestorForSendType): Don't check ns_return_types.
7111 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7114 2011-07-08 Jason Rumney <jasonr@gnu.org>
7116 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7117 SH_SHOW for hidden windows (Bug#5482).
7119 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7120 frame struct members of non-existent frames (Bug#6284).
7122 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7124 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7125 variable firstTime not needed on OSX >= 10.6.
7126 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7127 >= 10.5. Use setKnobProportion, setDoubleValue.
7129 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7130 (MAC_OS_X_VERSION_10_5): Define if not defined.
7131 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7132 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7133 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7135 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7136 cString and lossyCString on OSX >= 10.4
7138 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7139 sizeToFit on OSX >= 10.2.
7141 * nsimage.m (allocInitFromFile): Don't use deprecated method
7142 bestRepresentationForDevice on OSX >= 10.6.
7144 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7147 * emacs.c: Declare unexec_init_emacs_zone.
7149 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7151 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7153 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7154 on svcsMenu (Bug#8842).
7156 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7158 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7160 * nsterm.m (QUTF8_STRING): Declare.
7161 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7162 (validRequestorForSendType): Return type is (id).
7163 Change indexOfObjectIdenticalTo to indexOfObject.
7164 Check if we have local selection before returning self (Bug#8842).
7165 (writeSelectionToPasteboard): Put local selection into paste board
7166 if we have a local selection (Bug#8842).
7167 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7169 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7170 (ns_get_local_selection): Declare.
7172 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7174 * keymap.c (describe_map_tree): Don't insert a double newline at
7175 the end of the buffer (bug#1169) and return whether we inserted
7178 * callint.c (Fcall_interactively): Change "reading args" to
7179 "providing args" to try to clarify what it does (bug#1010).
7181 2011-07-07 Kenichi Handa <handa@m17n.org>
7183 * composite.c (composition_compute_stop_pos): Ignore a static
7184 composition starting before CHARPOS (Bug#8915).
7186 * xdisp.c (handle_composition_prop): Likewise.
7188 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7190 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7193 2011-07-07 Kenichi Handa <handa@m17n.org>
7195 * character.h (unicode_category_t): New enum type.
7197 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7198 (Qchar_code_property_table): New variable.
7199 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7200 (UNIPROP_COMPRESSED_FORM_P): New macros.
7201 (char_table_ascii): Uncompress the compressed values.
7202 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7203 Uncompress the compressed values.
7204 (sub_char_table_ref_and_range): Likewise.
7205 (char_table_ref_and_range): Uncompress the compressed values.
7206 (sub_char_table_set): New arg is_uniprop. Callers changed.
7207 Uncompress the compressed values.
7208 (sub_char_table_set_range): Args changed. Callers changed.
7209 (char_table_set_range): Adjuted for the above change.
7210 (map_sub_char_table): Delete args default_val and parent. Add arg
7211 top. Give decoded values to a Lisp function.
7212 (map_char_table): Adjust for the above change. Give decoded
7213 values to a Lisp function. Gcpro more variables.
7214 (uniprop_table_uncompress)
7215 (uniprop_decode_value_run_length): New functions.
7216 (uniprop_decoder, uniprop_decoder_count): New variables.
7217 (uniprop_get_decoder, uniprop_encode_value_character)
7218 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7220 (uniprop_encoder, uniprop_encoder_count): New variables.
7221 (uniprop_get_encoder, uniprop_table)
7222 (Funicode_property_table_internal, Fget_unicode_property_internal)
7223 (Fput_unicode_property_internal): New functions.
7224 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7225 Sunicode_property_table_internal, Sget_unicode_property_internal,
7226 and Sput_unicode_property_internal. Defvar_lisp
7227 char-code-property-alist.
7229 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7230 Vunicode_category_table.
7232 * font.c (font_range): Adjust for the change of
7233 Vunicode_category_table.
7235 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7237 * m/iris4d.h: Remove file, move contents ...
7238 * s/irix6-5.h: ... here.
7240 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7242 Remove unportable assumption about struct layout (Bug#8884).
7243 * alloc.c (mark_buffer):
7244 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7245 (clone_per_buffer_values): Don't assume that
7246 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7247 This isn't true in general, and it's particularly not true
7248 if Emacs is configured with --with-wide-int.
7249 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7250 New macros, used in the buffer.c change.
7252 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7254 * xsettings.c: Use both GConf and GSettings if both are available.
7255 (store_config_changed_event): Add comment.
7256 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7257 (store_tool_bar_style_changed): New functions.
7258 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7259 (struct xsettings): Move font inside HAVE_XFT.
7260 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7261 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7262 Move inside HAVE_XFT.
7263 (something_changed_gsettingsCB): Rename from something_changedCB.
7264 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7266 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7267 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7268 (something_changed_gconfCB): Rename from something_changedCB.
7269 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7270 (parse_settings): Move check for font inside HAVE_XFT.
7271 (read_settings, apply_xft_settings): Add comment.
7272 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7273 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7274 call store_font_name_changed.
7275 (xft_settings_event): Add comment.
7276 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7277 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7278 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7279 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7280 (xsettings_initialize): Call init_gsettings last.
7281 (xsettings_get_system_font, xsettings_get_system_normal_font):
7284 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7286 Random fixes. E.g., (random) never returned negative values.
7287 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7288 subseconds part to the entropy, as that's a bit more random.
7289 Prefer signed to unsigned, since the signedness doesn't matter and
7290 in general we prefer signed. When given a limit, use a
7291 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7292 latter isn't right if USE_2_TAGS_FOR_INTS.
7293 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7294 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7296 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7298 * textprop.c (text_property_stickiness):
7299 Obey Vtext_property_default_nonsticky.
7300 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7301 * w32fns.c (syms_of_w32fns):
7302 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7304 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7306 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7307 This is more efficient than Ffile_directory_p and avoids a minor race.
7309 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7311 * buffer.c (Foverlay_put): Say what the return value is
7314 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7315 is a directory before asking whether to use the file name
7317 (barf_or_query_if_file_exists): Make the "File is a directory"
7318 error be more correct.
7320 * fns.c (Frequire): Remove the mention of the .gz files, since
7321 that's installation-specific, but keep the mention of
7322 `get-load-suffixes'.
7324 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7326 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7327 Report string overflow if the output is too long.
7329 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7331 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7332 (syms_of_gnutls): Remove duplicate DEFSYM for
7333 Qgnutls_bootprop_verify_hostname_error, an error for
7334 Qgnutls_bootprop_verify_error (which is no longer used).
7336 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7337 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7338 Also (re)move comments that are misplaced or no longer relevant.
7340 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7342 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7344 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7346 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7347 and background color parameters if they have been changed.
7349 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7351 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7353 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7355 * xsettings.c (SYSTEM_FONT): Define only when used.
7356 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7358 * keymap.c (access_keymap_1): Now static.
7360 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7362 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7363 leave any prefix arg for the up event (Bug#1586).
7365 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7367 * lread.c (syms_of_lread): Mention single symbols defined by
7368 `defvar' or `defconst' (bug#7154).
7370 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7371 (Frequire): Mention get-load-suffixes.
7373 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7375 * window.h (window): Remove clone_number slot.
7376 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7378 (make_parent_window, make_window, saved_window)
7379 (Fset_window_configuration, save_window_save): Don't deal with
7381 * buffer.c (Qclone_number): Remove declaration.
7382 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7384 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7386 Add multiple inheritance to keymaps.
7387 * keymap.c (Fmake_composed_keymap): New function.
7388 (Fset_keymap_parent): Simplify.
7389 (fix_submap_inheritance): Remove.
7390 (access_keymap_1): New function extracted from access_keymap to handle
7391 embedded parents and handle lists of maps.
7392 (access_keymap): Use it.
7393 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7394 (Fcopy_keymap): Handle embedded parents.
7395 (Fcommand_remapping, define_as_prefix): Simplify.
7396 (Fkey_binding): Simplify.
7397 (syms_of_keymap): Move minibuffer-local-completion-map,
7398 minibuffer-local-filename-completion-map,
7399 minibuffer-local-must-match-map, and
7400 minibuffer-local-filename-must-match-map to Elisp.
7401 (syms_of_keymap): Defsubr make-composed-keymap.
7402 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7403 (parse_menu_item): Trivial simplification.
7405 2011-07-01 Glenn Morris <rgm@gnu.org>
7407 * Makefile.in (SETTINGS_LIBS): Fix typo.
7409 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7411 * coding.c (Fencode_coding_string): Record the last coding system
7412 used, as the function doc string says (bug#8738).
7414 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7416 * xsettings.c (store_monospaced_changed): Take new font as arg and
7417 check for change against current_mono_font.
7418 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7419 (emacs_settings_constructor, emacs_settings_get_property)
7420 (emacs_settings_set_property, emacs_settings_class_init)
7421 (emacs_settings_init, gsettings_obj): Remove.
7422 (something_changedCB): New function for HAVE_GSETTINGS.
7423 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7424 with value as argument.
7425 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7426 g_settings_new (Bug#8967). Do not create gsettings_obj.
7427 Remove calls to g_settings_bind. Connect something_changedCB to
7430 * xgselect.c: Add defined (HAVE_GSETTINGS).
7431 (xgselect_initialize): Ditto.
7433 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7434 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7437 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7439 * eval.c (struct backtrace): Simplify and port the data structure.
7440 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7441 signed bit field, as this assumption is not portable and it makes
7442 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7443 "char debug_on_exit : 1" as this is not portable either; instead,
7444 use the portable "unsigned int debug_on_exit : 1". Remove unused
7445 member evalargs. Remove obsolete comments about cc bombing out.
7447 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7449 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7450 Let HAVE_GSETTINGS override HAVE_GCONF.
7451 (store_monospaced_changed): New function.
7452 (EMACS_SETTINGS): A new type derived from GObject to handle
7453 GSettings notifications.
7454 (emacs_settings_constructor, emacs_settings_get_property)
7455 (emacs_settings_set_property, emacs_settings_class_init):
7457 (gsettings_client, gsettings_obj): New variables.
7458 (GSETTINGS_SCHEMA): New define.
7459 (something_changedCB): Call store_monospaced_changed.
7460 (init_gsettings): New function.
7461 (xsettings_initialize): Call init_gsettings.
7462 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7465 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7468 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7470 * window.c (resize_root_window, grow_mini_window)
7471 (shrink_mini_window): Rename Qresize_root_window to
7472 Qwindow_resize_root_window and Qresize_root_window_vertically to
7473 Qwindow_resize_root_window_vertically.
7475 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7477 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7479 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7481 * makefile.w32-in: Redesign dependencies so they reflect more
7482 clearly which files are directly included by each source file,
7483 and not through other includes.
7485 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7487 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7488 (sort_overlays, overlay_strings): When an overlay's clone number
7489 matches the window's clone number process the overlay even if
7490 the overlay's window property doesn't match the current window.
7492 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7493 (Fwindow_hchild): Rename to Fwindow_left_child.
7494 (Fwindow_next): Rename to Fwindow_next_sibling.
7495 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7496 (resize_window_check): Rename to window_resize_check.
7497 (resize_window_apply): Rename to window_resize_apply.
7498 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7499 (Fdelete_other_windows_internal, resize_frame_windows)
7500 (Fsplit_window_internal, Fdelete_window_internal)
7501 (grow_mini_window, shrink_mini_window)
7502 (Fresize_mini_window_internal): Fix callers accordingly.
7504 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7506 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7507 (emacs_fixed_set_min_size): Remove.
7508 (emacs_fixed_new): Take frame as argument.
7510 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7511 (_EmacsFixedPrivate): Remove minwidth/height.
7512 Add struct frame *f.
7513 (emacs_fixed_init): Initialize priv->f.
7514 (get_parent_class, emacs_fixed_set_min_size): Remove.
7515 (emacs_fixed_new): Set priv->f to argument.
7516 (emacs_fixed_get_preferred_width)
7517 (emacs_fixed_get_preferred_height): Use min_width/height from
7518 frames size_hint to set minimum and natural (Bug#8919).
7519 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7520 and use min_width/height from frames size_hint to set
7521 min_width/height (Bug#8919).
7523 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7524 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7527 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7529 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7530 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7533 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7535 * process.c (wait_reading_process_output): Bypass select if
7536 waiting for a cell while ignoring keyboard input, and input is
7537 pending. Suggested by Jan Djärv (Bug#8869).
7539 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7541 Use gnulib's dup2 module instead of rolling our own.
7542 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7544 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7546 * dispnew.c (scrolling_window): Before scrolling, turn off a
7547 mouse-highlight in the window being scrolled.
7549 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7551 Move DEFSYM to lisp.h and use everywhere.
7553 * character.h (DEFSYM): Move declaration...
7554 * lisp.h (DEFSYM): ...here.
7560 * w32select.c: Don't include character.h.
7562 * alloc.c (syms_of_alloc):
7563 * buffer.c (syms_of_buffer):
7564 * bytecode.c (syms_of_bytecode):
7565 * callint.c (syms_of_callint):
7566 * casefiddle.c (syms_of_casefiddle):
7567 * casetab.c (init_casetab_once):
7568 * category.c (init_category_once, syms_of_category):
7569 * ccl.c (syms_of_ccl):
7570 * cmds.c (syms_of_cmds):
7571 * composite.c (syms_of_composite):
7572 * dbusbind.c (syms_of_dbusbind):
7573 * dired.c (syms_of_dired):
7574 * dispnew.c (syms_of_display):
7575 * doc.c (syms_of_doc):
7576 * editfns.c (syms_of_editfns):
7577 * emacs.c (syms_of_emacs):
7578 * eval.c (syms_of_eval):
7579 * fileio.c (syms_of_fileio):
7580 * fns.c (syms_of_fns):
7581 * frame.c (syms_of_frame):
7582 * fringe.c (syms_of_fringe):
7583 * insdel.c (syms_of_insdel):
7584 * keymap.c (syms_of_keymap):
7585 * lread.c (init_obarray, syms_of_lread):
7586 * macros.c (syms_of_macros):
7587 * msdos.c (syms_of_msdos):
7588 * print.c (syms_of_print):
7589 * process.c (syms_of_process):
7590 * search.c (syms_of_search):
7591 * sound.c (syms_of_sound):
7592 * syntax.c (init_syntax_once, syms_of_syntax):
7593 * terminal.c (syms_of_terminal):
7594 * textprop.c (syms_of_textprop):
7595 * undo.c (syms_of_undo):
7596 * w32.c (globals_of_w32):
7597 * window.c (syms_of_window):
7598 * xdisp.c (syms_of_xdisp):
7599 * xfaces.c (syms_of_xfaces):
7600 * xfns.c (syms_of_xfns):
7601 * xmenu.c (syms_of_xmenu):
7602 * xsettings.c (syms_of_xsettings):
7603 * xterm.c (syms_of_xterm): Use DEFSYM.
7605 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7607 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7609 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7611 Integer and buffer overflow fixes (Bug#8873).
7613 * print.c (printchar, strout): Check for string overflow.
7614 (PRINTPREPARE, printchar, strout):
7615 Don't set size unless allocation succeeds.
7617 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7618 for sizes. Check for string overflow more accurately.
7619 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7621 * macros.c: Integer and buffer overflow fixes.
7622 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7623 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7624 Use ptrdiff_t, not int, for sizes.
7625 Don't increment bufsize until after realloc succeeds.
7626 Check for size-calculation overflow.
7627 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7629 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7631 * lread.c: Integer overflow fixes.
7632 (read_integer): Radix is now EMACS_INT, not int,
7633 to improve quality of diagnostics for out-of-range radices.
7634 Calculate buffer size correctly for out-of-range radices.
7635 (read1): Check for integer overflow in radices, and in
7636 read-circle numbers.
7637 (read_escape): Avoid int overflow.
7638 (Fload, openp, read_buffer_size, read1)
7639 (substitute_object_recurse, read_vector, read_list, map_obarray):
7640 Use ptrdiff_t, not int, for sizes.
7641 (read1): Use EMACS_INT, not int, for sizes.
7642 Check for size overflow.
7644 * image.c (cache_image): Check for size arithmetic overflow.
7646 * lread.c: Integer overflow issues.
7647 (saved_doc_string_size, saved_doc_string_length)
7648 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7649 Now ptrdiff_t, not int.
7650 (read1): Don't assume doc string length fits in int. Check for
7651 out-of-range doc string lengths.
7652 (read_list): Don't assume file position fits in int.
7653 (read_escape): Check for hex character overflow.
7655 2011-06-22 Leo Liu <sdl.web@gmail.com>
7657 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7658 Move to minibuffer.el.
7660 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7662 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7663 The following patches are for when GLYPH_DEBUG && !XASSERT.
7664 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7665 * dispnew.c (flush_stdout):
7666 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7667 Mark as externally visible.
7668 * dispnew.c (check_window_matrix_pointers): Now static.
7669 * dispnew.c (window_to_frame_vpos):
7670 * xfns.c (unwind_create_frame):
7671 * xterm.c (x_check_font): Remove unused local.
7672 * scroll.c (CHECK_BOUNDS):
7673 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7674 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7675 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7676 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7677 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7679 (debug_method_add): Use va_list and vsprintf rather than relying
7680 on undefined behavior with wrong number of arguments.
7681 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7682 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7683 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7684 since we're not interested in debugging glyphs with old libraries.
7685 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7686 GCC 4.6.0's static checking.
7688 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7690 Integer overflow and signedness fixes (Bug#8873).
7691 A few related buffer overrun fixes, too.
7693 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7695 * dispextern.h (struct face.stipple):
7696 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7697 (x_bitmap_mask, x_allocate_bitmap_record)
7698 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7699 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7700 (x_create_bitmap_from_xpm_data):
7701 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7702 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7704 * xfaces.c (load_pixmap):
7705 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7706 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7707 (.bitmaps_last, struct x_output.icon_bitmap):
7708 Use ptrdiff_t, not int, for bitmap indexes.
7709 (x_allocate_bitmap_record): Check for size overflow.
7710 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7712 Use ptrdiff_t, not int, for overlay counts.
7713 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7714 * editfns.c (overlays_around, get_pos_property):
7715 * textprop.c (get_char_property_and_overlay):
7716 * xdisp.c (next_overlay_change, note_mouse_highlight):
7717 * xfaces.c (face_at_buffer_position):
7718 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7719 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7720 (Fnext_overlay_change, Fprevious_overlay_change)
7721 (mouse_face_overlay_overlaps, Foverlays_in):
7722 Use ptrdiff_t, not int, for sizes.
7723 (overlays_at, overlays_in): Check for size-calculation overflow.
7725 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7727 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7728 (x_session_initialize): Do not assume string length fits in int.
7730 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7731 This is unlikely, but can occur if DPI is outlandish.
7733 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7734 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7736 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7737 * xrdb.c (magic_file_p, search_magic_path):
7738 Omit last arg SUFFIX; it was always 0. All callers changed.
7739 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7741 * xfont.c (xfont_match): Avoid need for strlen.
7743 * xfns.c: Don't assume strlen fits in int.
7744 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7746 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7747 not unsigned long, as we prefer signed integers. All callers changed.
7748 Detect integer overflow in repeat count.
7749 (message_dolog): Don't assume print length fits in 39 bytes.
7750 (display_mode_element): Don't assume strlen fits in int.
7752 * termcap.c: Don't assume sizes fit in int and never overflow.
7753 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7754 (gobble_line): Check for size-calculation overflow.
7756 * minibuf.c (Fread_buffer):
7757 * lread.c (intern, intern_c_string):
7758 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7759 Don't assume string length fits in int.
7761 * keyboard.c (parse_tool_bar_item):
7762 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7764 * font.c: Don't assume string length fits in int.
7765 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7766 Use ptrdiff_t, not int.
7767 (font_intern_prop): Don't assume string length fits in int.
7768 Don't assume integer property fits in fixnum.
7769 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7771 * filelock.c: Fix some buffer overrun and integer overflow issues.
7772 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7773 Reformulate so as not to need the command string.
7774 Invoke gzip -cd rather than gunzip, as it's more portable.
7775 (lock_info_type, lock_file_1, lock_file):
7776 Don't assume pid_t and time_t fit in unsigned long.
7777 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7778 (current_lock_owner): Prefer signed type for sizes.
7779 Use memcpy, not strncpy, where memcpy is what is really wanted.
7780 Don't assume (via atoi) that time_t and pid_t fit in int.
7781 Check for time_t and/or pid_t out of range, e.g., via a network share.
7782 Don't alloca where an auto var works fine.
7784 * fileio.c: Fix some integer overflow issues.
7785 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7786 Don't assume string length fits in int.
7787 (directory_file_name): Don't assume string length fits in long.
7788 (make_temp_name): Don't assume pid fits in int, or that its print
7789 length is less than 20.
7791 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7793 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7795 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7797 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7798 We prefer signed integers, even for size calculations.
7800 * emacs.c: Don't assume string length fits in 'int'.
7801 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7802 (main): Don't invoke strlen when not needed.
7804 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7805 (XD_DEBUG_MESSAGE): Don't waste a byte.
7807 * callproc.c (getenv_internal_1, getenv_internal)
7809 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7811 * lread.c (invalid_syntax): Omit length argument.
7812 All uses changed. This doesn't fix a bug, but it simplifies the
7813 code away from its former Hollerith-constant appearance, and it's
7814 one less 'int' to worry about when looking at integer-overflow issues.
7815 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7817 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7818 This didn't break anything, but it didn't help either.
7819 It's confusing to put a bogus integer in a place where the actual
7820 value does not matter.
7821 (LIST_END_P): Remove unused macro and its bogus comment.
7822 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7824 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7825 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7827 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7828 We prefer signed types, and the value cannot exceed the EMACS_INT
7829 range anyway (because otherwise the length would not be representable).
7830 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7831 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7832 This avoids a GCC warning when WIDE_EMACS_INT.
7834 * indent.c (sane_tab_width): New function.
7835 (current_column, scan_for_column, Findent_to, position_indentation)
7836 (compute_motion): Use it. This is just for clarity.
7837 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7839 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7841 * lisp.h (lint_assume): New macro.
7842 * composite.c (composition_gstring_put_cache):
7843 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7845 * editfns.c, insdel.c:
7846 Omit unnecessary forward decls, to simplify future changes.
7848 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7850 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7852 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7853 Use much-faster test for byte-length change.
7854 Don't assume string byte-length fits in 'int'.
7855 Check that character arg fits in 'int'.
7856 (mapcar1): Declare byte as byte, for clarity.
7858 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7860 * fns.c (concat): Catch string overflow earlier.
7861 Do not rely on integer wraparound.
7863 * dispextern.h (struct it.overlay_strings_charpos)
7864 (struct it.selective): Now EMACS_INT, not int.
7865 * xdisp.c (forward_to_next_line_start)
7866 (back_to_previous_visible_line_start)
7867 (reseat_at_next_visible_line_start, next_element_from_buffer):
7868 Don't arbitrarily truncate the value of 'selective' to int.
7870 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7872 * composite.c: Don't truncate sizes to 'int'.
7873 (composition_gstring_p, composition_reseat_it)
7874 (composition_adjust_point): Use EMACS_INT, not int.
7875 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7876 not EMACS_UINT, for indexes.
7878 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7880 * buffer.c: Include <verify.h>.
7881 (struct sortvec.priority, struct sortstr.priority):
7882 Now EMACS_INT, not int.
7883 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7884 (struct sortstr.size, record_overlay_string)
7885 (struct sortstrlist.size, struct sortlist.used):
7886 Don't truncate size to int.
7887 (record_overlay_string): Check for size-calculation overflow.
7888 (init_buffer_once): Check at compile-time, not run-time.
7890 2011-06-22 Jim Meyering <meyering@redhat.com>
7892 Don't leak an XBM-image-sized buffer
7893 * image.c (xbm_load): Free the image buffer after using it.
7895 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7898 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7899 that Sun C diagnosed.
7900 * fns.c (secure_hash): Fix pointer signedness issue.
7901 * intervals.c (static_offset_intervals): New function.
7902 (offset_intervals): Use it.
7904 2011-06-21 Leo Liu <sdl.web@gmail.com>
7907 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7910 * fns.c (secure_hash): Rename from crypto_hash_function and change
7911 the first arg to accept symbols.
7912 (Fsecure_hash): New primitive.
7913 (syms_of_fns): New symbols.
7915 2011-06-20 Deniz Dogan <deniz@dogan.se>
7917 * process.c (Fset_process_buffer): Clarify return value in
7920 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7922 * dispnew.c (add_window_display_history): Use BVAR.
7924 * xdisp.c (debug_method_add): Use BVAR.
7925 (check_window_end, dump_glyph_matrix, dump_glyph)
7926 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7928 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7931 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7932 check till after the cache is created in init_frame_faces.
7934 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7936 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7938 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7940 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7941 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7942 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7944 Improve buffer-overflow checking (Bug#8873).
7945 * fileio.c (Finsert_file_contents):
7946 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7947 Remove the old (too-loose) buffer overflow checks.
7948 They weren't needed, since make_gap checks for buffer overflow.
7949 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7950 The old code merely checked for Emacs fixnum overflow, and relied
7951 on undefined (wraparound) behavior. The new code avoids undefined
7952 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7954 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7955 Tune. Don't use wider integers than needed. Don't use alloca.
7956 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7958 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7960 * insdel.c, lisp.h (buffer_overflow): New function.
7961 (insert_from_buffer_1, replace_range, replace_range_2):
7962 * insdel.c (make_gap_larger):
7963 * editfns.c (Finsert_char):
7964 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7966 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7968 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7970 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7972 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7973 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7975 * fileio.c: Don't assume EMACS_INT fits in off_t.
7976 (emacs_lseek): New static function.
7977 (Finsert_file_contents, Fwrite_region): Use it.
7978 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7980 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7982 * fns.c: Don't overflow int when computing a list length.
7983 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7984 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7985 truncation on 64-bit hosts. Check for QUIT every
7986 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7987 faster and is responsive enough.
7988 (Flength): Report an error instead of overflowing an integer.
7989 (Fsafe_length): Return a float if the value is not representable
7990 as a fixnum. This shouldn't happen except in contrived situations.
7991 (Fnthcdr, Fsort): Don't assume list length fits in int.
7992 (Fcopy_sequence): Don't assume vector length fits in int.
7994 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7995 (header_size, word_size): New constants.
7996 (allocate_vectorlike): Don't check size overflow here.
7997 (allocate_vector): Check it here instead, since this is the only
7998 caller of allocate_vectorlike that could cause overflow.
7999 Check that the new vector's length is representable as a fixnum.
8001 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8002 The previous code was bogus. For example, next_almost_prime (32)
8003 returned 39, which is undesirable as it is a multiple of 3; and
8004 next_almost_prime (24) returned 25, which is a multiple of 5 so
8005 why was the code bothering to check for multiples of 7?
8007 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8009 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8011 Variadic C functions now count arguments with ptrdiff_t.
8012 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8013 Back then I didn't know that the Emacs coding style prefers signed int.
8014 Also, in the meantime I found a few more instances where arguments
8015 were being counted with int, which may truncate counts on 64-bit
8016 machines, or EMACS_INT, which may be unnecessarily wide.
8017 * lisp.h (struct Lisp_Subr.function.aMANY)
8018 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8019 Arg counts are now ptrdiff_t, not size_t.
8020 All variadic functions and their callers changed accordingly.
8021 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8022 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8023 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8024 * callint.c (Fcall_interactively): Check arg count for overflow,
8025 to avoid potential buffer overrun. Use signed char, not 'int',
8026 for 'varies' array, so that we needn't bother to check its size
8027 calculation for overflow.
8028 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8029 * eval.c (apply_lambda):
8030 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8031 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8032 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8034 * callint.c (Fcall_interactively): Don't use index var as event count.
8036 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8037 * mem-limits.h (SIZE): Remove; no longer used.
8039 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8041 Remove unnecessary casts.
8042 * xterm.c (x_term_init):
8043 * xfns.c (x_set_border_pixel):
8044 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8045 These aren't needed now that we assume ANSI C.
8047 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8048 It's more likely to cause problems (due to unsigned overflow)
8051 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8053 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8055 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8057 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8059 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8061 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8063 GLYPH_CODE_FACE returns EMACS_INT, not int.
8064 * dispextern.h (merge_faces):
8065 * xfaces.c (merge_faces):
8066 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8067 Don't assume EMACS_INT fits in int.
8069 * character.h (CHAR_VALID_P): Remove unused parameter.
8070 * fontset.c, lisp.h, xdisp.c: All uses changed.
8072 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8074 * fns.c (concat): Minor tuning based on overflow analysis.
8075 This doesn't fix any bugs. Use int to hold character, instead
8076 of constantly refetching from Emacs object. Use XFASTINT, not
8077 XINT, for value known to be a character. Don't bother comparing
8078 a single byte to 0400, as it's always less.
8080 * floatfns.c (Fexpt):
8081 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8083 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8086 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8088 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8089 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8090 incorrectly succeed when S was a string, because 4294967386 was
8091 truncated before it was used.
8093 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8094 Otherwise, an out-of-range integer could cause undefined behavior
8097 * composite.c: Use int, not EMACS_INT, for characters.
8098 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8099 EMACS_INT, for values that are known to be in character range.
8100 This doesn't fix any bugs but is the usual style inside Emacs and
8101 may generate better code on 32-bit machines.
8103 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8104 This is for reasons similar to the recent CHAR_STRING fix.
8105 * charset.c (Fencode_char): Check that character arg is actually
8106 a character. Pass an int to ENCODE_CHAR.
8107 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8108 wider than 'int', as a compile-time check to prevent future regressions
8111 * character.c (char_string): Remove unnecessary casts.
8113 Make sure a 64-bit char is never passed to CHAR_STRING.
8114 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8115 by silently ignoring the top 32 bits, allowing some values
8116 that were far too large to be valid characters.
8117 * character.h: Include <verify.h>.
8118 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8119 arguments are no wider than unsigned, as a compile-time check
8120 to prevent future regressions in this area.
8122 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8123 (Fsubst_char_in_region):
8125 * xdisp.c (decode_mode_spec_coding):
8126 Adjust to CHAR_STRING's new requirement.
8127 * editfns.c (Finsert_char, Fsubst_char_in_region):
8128 * fns.c (concat): Check that character args are actually
8129 characters. Without this test, these functions did the wrong
8130 thing with wildly out-of-range values on 64-bit hosts.
8132 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8133 These casts should not be needed on 32-bit hosts, either.
8134 * keyboard.c (read_char):
8135 * lread.c (Fload): Remove casts to unsigned.
8137 * lisp.h (UNSIGNED_CMP): New macro.
8138 This fixes comparison bugs on 64-bit hosts.
8139 (ASCII_CHAR_P): Use it.
8140 * casefiddle.c (casify_object):
8141 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8142 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8143 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8144 * dispextern.h (FACE_FROM_ID):
8145 * keyboard.c (read_char): Use UNSIGNED_CMP.
8147 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8148 not to EMACS_INT, to avoid GCC warning.
8150 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8152 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8153 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8154 isn't needed on 32-bit machines.
8156 * buffer.c (Fgenerate_new_buffer_name):
8157 Use EMACS_INT for count, not int.
8158 (advance_to_char_boundary): Return EMACS_INT, not int.
8160 * data.c (Qcompiled_function): Now static.
8162 * window.c (window_body_lines): Now static.
8164 * image.c (gif_load): Rename local to avoid shadowing.
8166 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8167 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8168 * alloc.c (make_save_value): Integer argument is now of type
8170 (mark_object): Use ptrdiff_t, not int.
8171 * lisp.h (pD): New macro.
8172 * print.c (print_object): Use it.
8174 * alloc.c: Use EMACS_INT, not int, to count objects.
8175 (total_conses, total_markers, total_symbols, total_vector_size)
8176 (total_free_conses, total_free_markers, total_free_symbols)
8177 (total_free_floats, total_floats, total_free_intervals)
8178 (total_intervals, total_strings, total_free_strings):
8179 Now EMACS_INT, not int. All uses changed.
8180 (Fgarbage_collect): Compute overall total using a double, so that
8181 integer overflow is less likely to be a problem. Check for overflow
8182 when converting back to an integer.
8183 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8184 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8185 These were 'int' variables that could overflow on 64-bit hosts;
8186 they were never used, so remove them instead of repairing them.
8187 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8188 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8189 Previously, this ceilinged at INT_MAX, but that doesn't work on
8191 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8193 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8194 (allocate_vectorlike): Check for ptrdiff_t overflow.
8195 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8196 when a (possibly-narrower) signed value would do just as well.
8197 We prefer using signed arithmetic, to avoid comparison confusion.
8199 * alloc.c: Catch some string size overflows that we were missing.
8200 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8201 for convenience in STRING_BYTES_MAX.
8202 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8203 The definition here is exact; the one in lisp.h was approximate.
8204 (allocate_string_data): Check for string overflow. This catches
8205 some instances we weren't catching before. Also, it catches
8206 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8207 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8208 and ptrdiff_t and EMACS_INT are both 64 bits.
8210 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8211 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8212 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8214 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8216 * alloc.c (Fmake_string): Check for out-of-range init.
8218 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8220 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8222 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8224 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8225 xg_get_default_scrollbar_width.
8227 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8228 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8229 (style_changed_cb): Call update_theme_scrollbar_width and call
8230 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8231 all frames (Bug#8505).
8232 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8233 Call gtk_window_set_resizable if HAVE_GTK3.
8234 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8235 and height if HAVE_GTK3 (Bug#8505).
8236 (scroll_bar_width_for_theme): New variable.
8237 (update_theme_scrollbar_width): New function.
8238 (xg_get_default_scrollbar_width): Move code to
8239 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8240 (xg_initialize): Call update_theme_scrollbar_width.
8242 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8244 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8246 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8248 * frame.c (make_frame): Call other_buffer_safely instead of
8251 * window.c (temp_output_buffer_show): Call display_buffer with
8252 second argument Vtemp_buffer_show_specifiers and reset latter
8253 immediately after the call.
8254 (Vtemp_buffer_show_specifiers): New variable.
8255 (auto_window_vscroll_p, next_screen_context_lines)
8256 (Vscroll_preserve_screen_position): Remove leading asterisks from
8259 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8261 Fix minor problems found by GCC 4.6.0 static checking.
8262 * buffer.c (Qclone_number): Remove for now, as it's unused.
8263 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8264 (record_buffer): Remove unused local.
8265 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8266 (set_frame_buffer_list): Remove; unused.
8267 * frame.h (other_visible_frames): Remove decl.
8268 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8269 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8270 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8272 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8273 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8274 Define only if HAVE_GPM.
8275 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8276 (update_hints_inhibit): Remove; never set. All uses removed.
8277 * widgetprv.h (emacsFrameClassRec): Remove decl.
8278 * window.c (delete_deletable_window): Now returns void, since it
8279 wasn't returning anything.
8280 (compare_window_configurations): Remove unused locals.
8281 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8282 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8283 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8284 the same widths as pointers. This follows up on the 2011-05-06 patch.
8285 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8286 * xterm.h: Likewise.
8287 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8289 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8291 * makefile.w32-in: Update dependencies.
8292 (LISP_H): Add lib/intprops.h.
8294 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8296 * image.c (gif_load): Add animation frame delay to the metadata.
8297 (syms_of_image): Use DEFSYM. New symbol `delay'.
8299 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8301 * window.c (delete_deletable_window): Re-add.
8302 (Fset_window_configuration): Rewrite to handle dead buffers and
8303 consequently deletable windows.
8304 (window_tree, Fwindow_tree): Remove. Supply functionality in
8306 (compare_window_configurations): Simplify code.
8308 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8310 * image.c (imagemagick_load_image): Fix type mismatch.
8311 (Fimagemagick_types): Likewise.
8313 * window.h (replace_buffer_in_windows): Declare.
8315 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8317 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8318 Qclone_number. Remove external declaration of Qdelete_window.
8319 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8321 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8322 Run Qbuffer_list_update_hook if allowed.
8323 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8324 buffer list implementation.
8325 (other_buffer_safely): New function.
8326 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8327 calls to replace_buffer_in_windows and
8328 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8330 (record_buffer): Inhibit quitting and rewrite using quittable
8331 functions. Run Qbuffer_list_update_hook if allowed.
8332 (Frecord_buffer, Funrecord_buffer): New functions.
8333 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8334 Move switch-to-buffer to window.el.
8335 (bury-buffer): Move to window.el.
8336 (Vbuffer_list_update_hook): New variable.
8338 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8341 * window.h (resize_frame_windows): Move up in code.
8342 (Fwindow_frame): Remove EXFUN.
8343 (replace_buffer_in_all_windows): Remove prototype.
8344 (replace_buffer_in_windows_safely): Add prototype.
8346 * window.c: Declare Qdelete_window static again. Move down
8347 declaration of select_count.
8348 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8349 (Fother_window): Move to window.el.
8350 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8351 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8352 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8354 (replace_buffer_in_windows): Implement by calling
8355 Qreplace_buffer_in_windows.
8356 (replace_buffer_in_all_windows): Remove with some functionality
8357 moved into replace_buffer_in_windows_safely.
8358 (replace_buffer_in_windows_safely): New function.
8359 (select_window_norecord, select_frame_norecord): Move in front
8360 of run_window_configuration_change_hook. Remove now obsolete
8362 (Fset_window_buffer): Rewrite doc-string.
8363 Call Qrecord_window_buffer.
8364 (keys_of_window): Move binding for other-window to window.el.
8366 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8368 * dispextern.h (struct image): Replace data member, whose int_val
8369 and ptr_val fields were not used by anything, with a single
8372 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8373 (gif_clear_image, gif_load, imagemagick_load_image)
8374 (gs_clear_image, gs_load): Callers changed.
8376 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8378 * buffer.h: Include <time.h>, for time_t.
8379 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8381 Fix minor problems found by static checking.
8383 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8385 Make identifiers static if they are not used in other modules.
8386 * data.c (Qcompiled_function, Qframe, Qvector):
8387 * image.c (QimageMagick, Qsvg):
8388 * minibuf.c (Qmetadata):
8389 * window.c (resize_window_check, resize_root_window): Now static.
8390 * window.h (resize_window_check, resize_root_window): Remove decls.
8392 * window.c (window_deletion_count, delete_deletable_window):
8394 (window_body_lines): Now static.
8395 (Fdelete_other_windows_internal): Mark vars as initialized.
8396 Make sure 'resize_failed' is initialized.
8397 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8398 (resize_window_apply): Remove unused local.
8399 * window.h (delete_deletable_window): Remove decl.
8401 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8402 (imagemagick_load_image): Fix pointer signedness problem by changing
8403 last arg from unsigned char * to char *. All uses changed.
8404 Also, fix a local for similar reasons.
8405 Remove unused locals. Remove locals to avoid shadowing.
8406 (fn_rsvg_handle_free): Remove; unused.
8407 (svg_load, svg_load_image): Fix pointer signedness problem.
8408 (imagemagick_load_image): Don't use garbage pointer image_wand.
8410 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8412 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8414 * image.c (gif_load): Fix omitted cast error introduced by
8417 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8419 * window.h (resize_proportionally, orig_total_lines)
8420 (orig_top_line): Remove from window structure.
8421 (set_window_height, set_window_width, change_window_heights)
8422 (Fdelete_window): Remove prototypes.
8423 (resize_frame_windows): Remove duplicate declaration.
8425 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8427 * window.h (resize_frame_windows, resize_window_check)
8428 (delete_deletable_window, resize_root_window)
8429 (resize_frame_windows): Declare prototypes.
8431 * window.c (resize_window_apply): Make definition be "static" to
8432 match the prototype.
8434 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8436 * window.c: Remove declarations of Qwindow_size_fixed,
8437 window_min_size_1, window_min_size_2, window_min_size,
8438 size_window, window_fixed_size_p, enlarge_window, delete_window.
8439 Remove static from declaration of Qdelete_window, it's
8440 temporarily needed by Fbury_buffer.
8441 (replace_window): Don't assign orig_top_line and
8443 (Fdelete_window, delete_window): Remove. Window deletion is
8444 handled by window.el.
8445 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8446 Replace Fdelete_window calls with calls to Qdelete_window.
8447 (Fdelete_other_windows): Remove. Deleting other windows is
8448 handled by window.el.
8449 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8450 handled in window.el.
8451 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8452 Window minimum sizes are handled in window.el.
8453 (shrink_windows, size_window, set_window_height)
8454 (set_window_width, change_window_heights, window_height)
8455 (window_width, CURBEG, CURSIZE, enlarge_window)
8456 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8457 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8458 handled in window.el.
8459 (make_dummy_parent): Rename to make_parent_window and give it a
8460 second argument horflag.
8461 (make_window): Don't set resize_proportionally any more.
8462 (Fsplit_window): Remove. Windows are split in window.el.
8463 (save_restore_action, save_restore_orig_size)
8464 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8465 Resize mini windows in window.el.
8466 (grow_mini_window, shrink_mini_window): Implement by calling
8467 Qresize_root_window_vertically, resize_window_check and
8468 resize_window_apply.
8469 (saved_window, Fset_window_configuration, save_window_save):
8470 Do not handle orig_top_line, orig_total_lines, and
8471 resize_proportionally.
8472 (window_min_height, window_min_width): Move to window.el.
8473 (keys_of_window): Move bindings for delete-other-windows,
8474 split-window, delete-window and enlarge-window to window.el.
8476 * buffer.c: Temporarily extern Qdelete_window.
8477 (Fbury_buffer): Temporarily call Qdelete_window instead of
8478 Fdelete_window (Fbury_buffer will move to window.el soon).
8480 * frame.c (set_menu_bar_lines_1): Remove code handling
8481 orig_top_line and orig_total_lines.
8483 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8484 set_window_height but set heights directly.
8485 (change_frame_size_1): Use resize_frame_windows.
8487 * xdisp.c (init_xdisp): Don't use set_window_height but set
8490 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8491 Use resize_frame_windows instead of change_window_heights and run
8492 run_window_configuration_change_hook.
8494 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8495 instead of change_window_heights and run
8496 run_window_configuration_change_hook.
8498 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8500 * window.c (replace_window): Rename second argument REPLACEMENT to
8501 NEW. New third argument SETFLAG. Rewrite.
8502 (delete_window, make_dummy_parent): Call replace_window with
8504 (window_list_1): Move down in code.
8505 (run_window_configuration_change_hook): Move set_buffer part
8506 before select_frame_norecord part in order to unwind correctly.
8507 Rename count1 to count.
8508 (recombine_windows, delete_deletable_window, resize_root_window)
8509 (Fdelete_other_windows_internal)
8510 (Frun_window_configuration_change_hook, make_parent_window)
8511 (resize_window_check, resize_window_apply, Fresize_window_apply)
8512 (resize_frame_windows, Fsplit_window_internal)
8513 (Fdelete_window_internal, Fresize_mini_window_internal):
8515 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8517 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8519 * window.h (window): Add some new members to window structure -
8520 normal_lines, normal_cols, new_total, new_normal, clone_number,
8521 splits, nest, prev_buffers, next_buffers.
8522 (WINDOW_TOTAL_SIZE): Move here from window.c.
8523 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8525 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8527 (make_dummy_parent): Set new members of windows structure.
8528 (make_window): Move down in code. Handle new members of window
8530 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8531 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8532 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8533 (Fset_window_prev_buffers, Fwindow_next_buffers)
8534 (Fset_window_next_buffers, Fset_window_clone_number):
8536 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8537 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8539 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8540 Argument WINDOW can be now internal window too.
8541 (Fwindow_use_time): Move up in code.
8542 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8544 (Fset_window_configuration, saved_window)
8545 (Fcurrent_window_configuration, save_window_save): Handle new
8546 members of window structure.
8547 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8548 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8549 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8550 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8551 Qget_mru_window, Qresize_root_window,
8552 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8553 Qauto_buffer_name; staticpro them.
8555 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8557 * window.c (Fwindow_total_size, Fwindow_left_column)
8558 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8559 (Fwindow_list_1): New functions.
8560 (window_box_text_cols): Replace with window_body_cols.
8561 (Fwindow_width, Fscroll_left, Fscroll_right):
8562 Use window_body_cols instead of window_box_text_cols.
8563 (delete_window, Fset_window_configuration):
8564 Call delete_all_subwindows with window as argument.
8565 (delete_all_subwindows): Take a window as argument and not a
8567 (window_loop): Remove handling of GET_LRU_WINDOW and
8569 (Fget_lru_window, Fget_largest_window): Move to window.el.
8571 * window.h: Extern window_body_cols instead of
8572 window_box_text_cols. delete_all_subwindows now takes a
8573 Lisp_Object as argument.
8575 * indent.c (compute_motion, Fcompute_motion):
8576 Use window_body_cols instead of window_box_text_cols.
8578 * frame.c (delete_frame): Call delete_all_subwindows with root
8581 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8583 * fns.c (Fputhash): Document return value.
8585 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8587 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8589 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8591 Cons<->int and similar integer overflow fixes (Bug#8794).
8593 Check for overflow when converting integer to cons and back.
8594 * charset.c (Fdefine_charset_internal, Fdecode_char):
8595 Use cons_to_unsigned to catch overflow.
8596 (Fencode_char): Use INTEGER_TO_CONS.
8597 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8598 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8599 * data.c (long_to_cons, cons_to_long): Remove.
8600 (cons_to_unsigned, cons_to_signed): New functions.
8601 These signal an error for invalid or out-of-range values.
8602 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8603 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8604 * font.c (Ffont_variation_glyphs):
8605 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8606 * lisp.h: Include <intprops.h>.
8607 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8608 (cons_to_signed, cons_to_unsigned): New decls.
8609 (long_to_cons, cons_to_long): Remove decls.
8610 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8611 (Fprimitive_undo): Use CONS_TO_INTEGER.
8612 * xfns.c (Fx_window_property): Likewise.
8613 * xselect.c: Include <limits.h>.
8614 (x_own_selection, selection_data_to_lisp_data):
8615 Use INTEGER_TO_CONS.
8616 (x_handle_selection_request, x_handle_selection_clear)
8617 (x_get_foreign_selection, Fx_disown_selection_internal)
8618 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8619 (lisp_data_to_selection_data): Use cons_to_unsigned.
8620 (x_fill_property_data): Use cons_to_signed.
8621 Report values out of range.
8623 Check for buffer and string overflow more precisely.
8624 * buffer.h (BUF_BYTES_MAX): New macro.
8625 * lisp.h (STRING_BYTES_MAX): New macro.
8626 * alloc.c (Fmake_string):
8627 * character.c (string_escape_byte8):
8628 * coding.c (coding_alloc_by_realloc):
8629 * doprnt.c (doprnt):
8630 * editfns.c (Fformat):
8632 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8633 since they may not be the same number.
8634 * editfns.c (Finsert_char):
8635 * fileio.c (Finsert_file_contents):
8636 Likewise for BUF_BYTES_MAX.
8638 * image.c: Use ptrdiff_t, not int, for sizes.
8639 (slurp_file): Switch from int to ptrdiff_t.
8641 (slurp_file): Check that file size fits in both size_t (for
8642 malloc) and ptrdiff_t (for sanity and safety).
8644 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8645 if b->modtime has its maximal value.
8647 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8649 Don't assume time_t can fit into int.
8650 * buffer.h (struct buffer.modtime): Now time_t, not int.
8651 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8652 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8654 Minor fixes for signed vs unsigned integers.
8655 * character.h (MAYBE_UNIFY_CHAR):
8656 * charset.c (maybe_unify_char):
8657 * keyboard.c (read_char, reorder_modifiers):
8658 XINT -> XFASTINT, since the integer must be nonnegative.
8659 * ftfont.c (ftfont_spec_pattern):
8660 * keymap.c (access_keymap, silly_event_symbol_error):
8661 XUINT -> XFASTINT, since the integer must be nonnegative.
8662 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8663 since it makes no difference and we prefer signed.
8664 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8665 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8668 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8670 * window.h (Fwindow_frame): Declare.
8672 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8674 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8675 (SPARE_MEMORY): Always define.
8676 (LARGE_REQUEST): Remove.
8677 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8679 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8681 * lisp.h: Move EXFUNS for Fframe_root_window,
8682 Fframe_first_window and Fset_frame_selected_window to window.h.
8684 * window.h: Move EXFUNS for Fframe_root_window,
8685 Fframe_first_window and Fset_frame_selected_window here from
8688 * frame.c (Fwindow_frame, Fframe_first_window)
8689 (Fframe_root_window, Fframe_selected_window)
8690 (Fset_frame_selected_window): Move to window.c.
8691 (Factive_minibuffer_window): Move to minibuf.c.
8692 (Fother_visible_frames_p): New function.
8694 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8696 * window.c (decode_window, decode_any_window): Move up in code.
8697 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8698 (inhibit_frame_unsplittable): Remove unused variable.
8699 (Fwindow_buffer): Move up and rewrite doc-string.
8700 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8701 (Fwindow_prev): New functions.
8702 (Fwindow_frame): Move here from frame.c. Accept any window as
8704 (Fframe_root_window, Fframe_first_window)
8705 (Fframe_selected_window): Move here from frame.c. Accept frame
8706 or arbitrary window as argument. Update doc-strings.
8707 (Fminibuffer_window): Move up in code.
8708 (Fwindow_minibuffer_p): Move up in code and simplify.
8709 (Fset_frame_selected_window): Move here from frame.c.
8711 (Fselected_window, select_window, Fselect_window): Move up in
8712 code. Minor doc-string fixes.
8714 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8716 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8717 Do not assume that spare memory exists; that assumption is valid
8718 only if SYSTEM_MALLOC.
8719 (LARGE_REQUEST): New macro, so that the issue of large requests
8720 is separated from the issue of spare memory.
8722 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8724 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8727 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8729 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8732 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8734 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8736 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8738 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8739 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8741 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8743 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8745 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8747 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8748 (x_clipboard_manager_save): Add return value.
8749 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8751 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8752 Obey Vx_select_enable_clipboard_manager. Catch errors in
8753 x_clipboard_manager_save (Bug#8779).
8754 (Vx_select_enable_clipboard_manager): New variable.
8755 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8757 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8759 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8761 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8763 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8764 in the current matrix if keep_current_p is non-zero.
8766 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8768 * bidi.c (bidi_level_of_next_char): Fix last change.
8770 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8772 Support bidi reordering of text covered by display properties.
8774 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8775 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8776 (bidi_cache_search, bidi_cache_iterator_state)
8777 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8778 (bidi_level_of_next_char, bidi_move_to_visually_next):
8779 Support character positions inside a run of characters covered by a
8781 (bidi_paragraph_init, bidi_resolve_explicit_1)
8782 (bidi_level_of_next_char): Call bidi_fetch_char and
8783 bidi_fetch_char_advance instead of FETCH_CHAR and
8785 (bidi_init_it): Initialize new members.
8786 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8788 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8789 instead of using explicit *_CHAR codes.
8790 (bidi_resolve_explicit, bidi_resolve_weak):
8791 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8792 bidirectional text is supported only in multibyte buffers.
8793 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8794 it to initialize the frame_window_p member of struct bidi_it.
8795 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8796 (bidi_resolve_explicit, bidi_resolve_weak)
8797 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8798 bidi_it->nchars is non-positive.
8799 (bidi_level_of_next_char): Don't try to lookup the cache for the
8800 next/previous character if nothing is cached there yet, or if we
8801 were just reseat()'ed to a new position.
8803 * xdisp.c (set_cursor_from_row): Set start and stop points
8804 according to the row's direction when priming the loop that looks
8805 for the glyph on which to display cursor.
8806 (single_display_spec_intangible_p): Function deleted.
8807 (display_prop_intangible_p): Reimplement to call
8808 handle_display_spec instead of single_display_spec_intangible_p.
8809 Accept 3 additional arguments needed by handle_display_spec.
8810 This fixes incorrect cursor motion across display property with complex
8811 values: lists, `(when COND...)' forms, etc.
8812 (single_display_spec_string_p): Support property values that are
8813 lists with the argument STRING its top-level element.
8814 (display_prop_string_p): Fix the condition for processing a
8815 property that is a list to be consistent with handle_display_spec.
8816 (handle_display_spec): New function, refactored from the
8817 last portion of handle_display_prop.
8818 (compute_display_string_pos): Accept additional argument
8819 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8820 value of a `display' property is a "replacing spec".
8821 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8822 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8823 the display property, but just return a value indicating whether
8824 the display property will replace the characters it covers.
8825 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8826 frame_window_p members of struct bidi_it.
8827 (compute_display_string_pos, compute_display_string_end):
8829 (push_it): Accept second argument POSITION, where pop_it should
8830 jump to continue iteration.
8831 (reseat_1): Initialize bidi_it.disp_pos.
8833 * keyboard.c (adjust_point_for_property): Adjust the call to
8834 display_prop_intangible_p to its new signature.
8836 * dispextern.h (struct bidi_it): New member frame_window_p.
8837 (bidi_init_it): Update prototypes.
8838 (display_prop_intangible_p): Update prototype.
8839 (compute_display_string_pos, compute_display_string_end):
8841 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8844 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8846 Malloc failure behavior now depends on size of allocation.
8847 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8848 * lisp.h: Change signatures accordingly.
8849 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8850 All callers changed. (Bug#8762)
8852 * gnutls.c: Use Emacs's memory allocators.
8853 Without this change, the gnutls library would invoke malloc etc.
8854 directly, which causes problems on non-SYNC_INPUT hosts, and which
8855 runs afoul of improving memory_full behavior. (Bug#8761)
8856 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8857 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8858 xfree instead of the default malloc, realloc, free.
8859 (Fgnutls_boot): No need to check for memory allocation failure,
8860 since xmalloc does that for us.
8862 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8863 * category.c (hash_get_category_set):
8864 * ccl.c (ccl_driver):
8865 * charset.c (Fdefine_charset_internal):
8866 * charset.h (struct charset.hash_index):
8867 * composite.c (get_composition_id, gstring_lookup_cache)
8868 (composition_gstring_put_cache):
8869 * composite.h (struct composition.hash_index):
8870 * dispextern.h (struct image.hash):
8871 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8872 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8873 (hashfn_equal, hashfn_user_defined, make_hash_table)
8874 (maybe_resize_hash_table, hash_lookup, hash_put)
8875 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8876 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8877 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8878 * image.c (make_image, search_image_cache, lookup_image)
8879 (xpm_put_color_table_h):
8880 * lisp.h (struct Lisp_Hash_Table):
8881 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8882 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8883 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8884 * alloc.c (allocate_vectorlike):
8885 Check for overflow in vector size calculations.
8886 * ccl.c (ccl_driver):
8887 Check for overflow when converting EMACS_INT to int.
8888 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8889 need to be updated by these changes.
8890 * fns.c (make_hash_table, maybe_resize_hash_table):
8891 Check for integer overflow with large hash tables.
8892 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8893 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8894 (SXHASH_REDUCE): New macro.
8895 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8896 Use it instead of discarding useful hash info with large hash values.
8897 (sxhash_float): New function.
8898 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8899 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8900 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8901 Rewrite to use FIXNUM_BITS, as this simplifies things.
8902 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8903 Adjust signatures to match updated version of code.
8904 (consing_since_gc): Now EMACS_INT, since a single hash table can
8905 use more than INT_MAX bytes.
8907 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8909 Make it possible to build with GCC-4.6+ -O2 -flto.
8911 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8913 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8915 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8916 Call minibuffer-inactive-mode.
8918 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8920 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8921 Update dependencies.
8923 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8925 * data.c (init_data): Remove code for UTS, this system is not
8928 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8930 Don't force ./temacs to start in terminal mode.
8932 * frame.c (make_initial_frame): Initialize faces in all cases, not
8933 only when CANNOT_DUMP is defined.
8934 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8936 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8938 * dispnew.c (add_window_display_history): Use const for the string
8939 pointer. Remove declaration, not needed.
8941 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8943 Use 'inline', not 'INLINE'.
8944 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8945 * alloc.c, fontset.c (INLINE): Remove.
8946 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8947 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8948 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8949 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8950 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8952 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8954 Make it possible to run ./temacs.
8956 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8957 syms_of_callproc does the same thing. Remove test for
8958 "initialized", do it in the caller.
8959 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8961 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8963 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8964 (read_minibuf): Use get_minibuffer.
8965 (syms_of_minibuf): Use DEFSYM.
8966 (Qmetadata): New var.
8967 * data.c (Qbuffer): Don't make it static.
8968 (syms_of_data): Use DEFSYM.
8970 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8972 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8973 (CCL_CODE_MIN): New macro.
8975 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8977 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8979 * eval.c (Qdebug): Now static.
8980 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8981 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8982 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8984 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8986 * image.c: Various fixes to ImageMagick code comments.
8987 (Fimagemagick_types): Doc fix.
8989 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8991 Minor fixes prompted by GCC 4.6.0 warnings.
8993 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8995 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8996 (x_clipboard_manager_save_all): Move extern decl to ...
8997 * xterm.h: ... here, so that it can be checked for consistency.
8999 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9001 * xselect.c (x_clipboard_manager_save_frame)
9002 (x_clipboard_manager_save_all): New functions.
9003 (Fx_clipboard_manager_save): Lisp function deleted.
9005 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9006 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9008 * xterm.h: Update prototype.
9010 2011-05-28 William Xu <william.xwl@gmail.com>
9012 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9015 2011-05-28 Jim Meyering <meyering@redhat.com>
9017 Avoid a sign-extension bug in crypto_hash_function.
9018 * fns.c (to_uchar): Define.
9019 (crypto_hash_function): Use it to convert some newly-signed
9020 variables to unsigned, to avoid sign-extension bugs. For example,
9021 without this change, (md5 "truc") would evaluate to
9022 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9023 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9024 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9026 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9028 Integer overflow fixes.
9030 * dbusbind.c: Serial number integer overflow fixes.
9031 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9032 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9033 to hold a serial number that is too large for a fixnum.
9034 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9035 Check for serial numbers out of range. Decode any serial number
9036 that was so large that it became a float. (Bug#8722)
9038 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9039 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9040 Use XFASTINT rather than XUINT when numbers are nonnegative.
9041 (xd_append_arg, Fdbus_method_return_internal):
9042 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9043 arguments, check that Lisp number is nonnegative, rather than
9044 silently wrapping negative numbers around. (Bug#8722)
9045 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9048 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9050 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9052 ccl: Add integer overflow checks.
9053 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9054 (IN_INT_RANGE): New macros.
9055 (ccl_driver): Use them to check for integer overflow when
9056 decoding a CCL program. Many of the new checks are whether XINT (x)
9057 fits in int; it doesn't always, on 64-bit hosts. The new version
9058 doesn't catch all possible integer overflows, but it's an
9059 improvement. (Bug#8719)
9061 * alloc.c (make_event_array): Use XINT, not XUINT.
9062 There's no need for unsigned here.
9064 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9065 This follows up to the 2011-05-06 change that substituted uintptr_t
9066 for EMACS_INT. This case wasn't caught back then.
9068 Rework Fformat to avoid integer overflow issues.
9069 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9070 now (part of C89). Include <verify.h>.
9071 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9072 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9073 (Fformat): Avoid the prepass trying to compute sizes; it was only
9074 approximate and thus did not catch overflow reliably. Instead, walk
9075 through the format just once, formatting and computing sizes as we go,
9076 checking for integer overflow at every step, and allocating a larger
9077 buffer as needed. Keep track separately whether the format is
9078 multibyte. Keep only the most-recently calculated precision, rather
9079 than them all. Record whether each argument has been converted to
9080 string. Use EMACS_INT, not int, for byte and char and arg counts.
9081 Support field widths and precisions larger than INT_MAX. Avoid
9082 sprintf's undefined behavior with conversion specifications such as %#d
9083 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9084 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9085 formatting out-of-range floating point numbers with int
9088 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9090 * data.c: Avoid integer truncation in expressions involving floats.
9091 * data.c: Include <intprops.h>.
9092 (arith_driver): When there's an integer overflow in an expression
9093 involving floating point, convert the integers to floating point
9094 so that the resulting value does not suffer from catastrophic
9095 integer truncation. For example, on a 64-bit host (* 4
9096 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9097 Do not rely on undefined behavior after integer overflow.
9099 merge count_size_as_multibyte, parse_str_to_multibyte
9100 * character.c, character.h (count_size_as_multibyte):
9101 Rename from parse_str_to_multibyte; all uses changed.
9102 Check for integer overflow.
9103 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9104 since it's now a duplicate of the other. This is more of
9105 a character than a buffer op, so better that it's in character.c.
9106 * fns.c, print.c: Adjust to above changes.
9108 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9110 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9112 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9114 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9115 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9116 (x_clipboard_manager_save): Now static.
9117 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9119 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9120 (crypto_hash_function): Now static.
9121 Fix pointer signedness problems. Avoid unnecessary initializations.
9123 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9125 * termhooks.h (Vselection_alist): Make it terminal-local.
9127 * terminal.c (create_terminal): Initialize it.
9129 * xselect.c: Support for clipboard managers.
9130 (Vselection_alist): Move to termhooks.h as terminal-local var.
9131 (LOCAL_SELECTION): New macro.
9132 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9133 (symbol_to_x_atom): Remove gratuitous arg.
9134 (x_handle_selection_request, lisp_data_to_selection_data)
9135 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9136 (x_own_selection, x_get_local_selection, x_convert_selection):
9137 New arg, specifying work frame. Use terminal-local Vselection_alist.
9138 (some_frame_on_display): Delete unused function.
9139 (Fx_own_selection_internal, Fx_get_selection_internal)
9140 (Fx_disown_selection_internal, Fx_selection_owner_p)
9141 (Fx_selection_exists_p): New optional frame arg.
9142 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9143 (x_handle_selection_clear): Don't treat other terminals with the
9144 same keyboard specially. Use the terminal-local Vselection_alist.
9145 (x_clear_frame_selections): Use Frun_hook_with_args.
9147 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9149 * xterm.h: Add support for those atoms.
9151 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9153 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9154 (converted_selections, conversion_fail_tag): New global variables.
9155 (x_selection_request_lisp_error): Free the above.
9156 (x_get_local_selection): Remove unnecessary code.
9157 (x_reply_selection_request): Args changed; handle arbitrary array
9158 of converted selections stored in converted_selections.
9159 Separate the XChangeProperty and SelectionNotify steps.
9160 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9161 (x_convert_selection): New function.
9162 (x_handle_selection_event): Simplify.
9163 (x_get_foreign_selection): Don't ignore incoming requests while
9164 waiting for an answer; this will fail when we implement
9165 SAVE_TARGETS, and seems unnecessary anyway.
9166 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9167 (Vx_sent_selection_functions): Doc fix.
9169 2011-05-26 Leo Liu <sdl.web@gmail.com>
9171 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9173 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9175 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9177 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9178 for fringe update if it has periodic bitmap.
9179 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9180 and fringe_bitmap_periodic_p.
9182 * fringe.c (get_fringe_bitmap_data): New function.
9183 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9184 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9185 row. Mark glyph row for fringe update if periodicity changed.
9187 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9188 for fringe update unless it has periodic bitmap.
9190 2011-05-25 Kenichi Handa <handa@m17n.org>
9192 * xdisp.c (get_next_display_element): Set correct it->face_id for
9193 a static composition.
9195 2011-05-24 Leo Liu <sdl.web@gmail.com>
9198 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9200 * fns.c (crypto_hash_function, Fsha1): New function.
9201 (Fmd5): Use crypto_hash_function.
9202 (syms_of_fns): Add Ssha1.
9204 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9206 * gnutls.c: Remove unused macros.
9207 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9208 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9209 Remove macros that are defined and never used.
9210 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9212 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9214 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9215 (Fx_get_selection_internal): Minor cleanup.
9216 (Fx_own_selection_internal): Rename arguments for consistency with
9219 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9221 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9223 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9225 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9227 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9229 * dispnew.c (scrolling_window): Don't exclude the case that the
9230 last enabled row in the desired matrix touches the bottom boundary.
9232 2011-05-21 Glenn Morris <rgm@gnu.org>
9234 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9235 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9236 and add some more files.
9238 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9240 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9241 report_file_error introduced by the change from 2011-05-07.
9243 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9245 * systime.h (Time): Define only if emacs is defined.
9246 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9247 where the include path doesn't have X11/X.h by default. See
9248 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9250 2011-05-20 Kenichi Handa <handa@m17n.org>
9252 * composite.c (find_automatic_composition): Fix previous change.
9254 2011-05-20 Glenn Morris <rgm@gnu.org>
9256 * lisp.mk: New file, split from Makefile.in.
9257 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9258 (shortlisp): Remove.
9259 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9261 2011-05-19 Glenn Morris <rgm@gnu.org>
9263 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9264 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9265 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9266 (lisp): Set the order to that of loadup.el.
9267 (shortlisp): Make it a copy of $lisp.
9268 (SOME_MACHINE_LISP): Remove.
9269 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9270 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9272 2011-05-18 Kenichi Handa <handa@m17n.org>
9274 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9275 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9276 (find_automatic_composition): Mostly rewrite for efficiency.
9278 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9280 * makefile.w32-in: Update dependencies.
9282 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9284 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9285 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9287 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9289 Fix some integer overflow issues, such as string length overflow.
9291 * insdel.c (count_size_as_multibyte): Check for string overflow.
9293 * character.c (lisp_string_width): Check for string overflow.
9294 Use EMACS_INT, not int, for string indexes and lengths; in
9295 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9296 the resulting string length overflows an EMACS_INT; instead,
9297 report a string overflow if no precision given. When checking for
9298 precision exhaustion, use a check that cannot possibly have
9299 integer overflow. (Bug#8675)
9300 * character.h (lisp_string_width): Adjust to new signature.
9302 * alloc.c (string_overflow): New function.
9303 (Fmake_string): Use it. This doesn't change behavior, but saves
9304 a few bytes and will simplify future changes.
9305 * character.c (string_escape_byte8): Likewise.
9306 * lisp.h (string_overflow): New decl.
9308 Fixups, following up to the user-interface timestamp change.
9309 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9310 for UI timestamps, instead of unsigned long.
9311 * msdos.c (mouse_get_pos): Likewise.
9312 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9313 * w32gui.h (Time): Define by including "systime.h" rather than by
9314 declaring it ourselves. (Bug#8664)
9316 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9317 * image.c (clear_image_cache): Likewise.
9319 * term.c (term_mouse_position): Don't assume time_t wraparound.
9321 Be more systematic about user-interface timestamps.
9322 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9323 and sometimes 'EMACS_UINT', to represent these timestamps.
9324 This change causes it to use 'Time' uniformly, as that's what X uses.
9325 This makes the code easier to follow, and makes it easier to catch
9326 integer overflow bugs such as Bug#8664.
9327 * frame.c (Fmouse_position, Fmouse_pixel_position):
9328 Use Time, not unsigned long, for user-interface timestamps.
9329 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9330 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9331 * keyboard.h (last_event_timestamp): Likewise.
9332 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9333 * menu.h (xmenu_show): Likewise.
9334 * term.c (term_mouse_position): Likewise.
9335 * termhooks.h (struct input_event.timestamp): Likewise.
9336 (struct terminal.mouse_position_hook): Likewise.
9337 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9338 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9339 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9340 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9342 * menu.h, termhooks.h: Include "systime.h", for Time.
9344 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9345 Don't assume that the difference between two unsigned long values
9346 can fit into an integer. At this point, we know button_down_time
9347 <= event->timestamp, so the difference must be nonnegative, so
9348 there's no need to cast the result if double-click-time is
9349 nonnegative, as it should be; check that it's nonnegative, just in
9350 case. This bug is triggered when events are more than 2**31 ms
9351 apart (about 25 days). (Bug#8664)
9353 * xselect.c (last_event_timestamp): Remove duplicate decl.
9354 (x_own_selection): Remove needless cast to unsigned long.
9356 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9357 that always fit in int. Use a sentinel instead of a counter, to
9358 avoid a temp and to allay GCC's concerns about possible int overflow.
9359 * frame.h (struct frame): Use int for menu_bar_items_used
9360 instead of EMACS_INT, since it always fits in int.
9362 * menu.c (grow_menu_items): Check for int overflow.
9364 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9366 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9367 Before, the code was not consistent. These values cannot exceed
9368 2**31 - 1 so there's no need to make them unsigned.
9369 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9370 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9371 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9373 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9375 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9376 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9377 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9378 presumably because the widths might not match.
9380 * window.c (size_window): Avoid needless test at loop start.
9382 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9384 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9386 2011-05-12 Drew Adams <drew.adams@oracle.com>
9388 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9390 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9392 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9393 `width' to `bar_area_x' and `bar_area_width', respectively.
9394 (x_scroll_run): Take account of fringe background extension.
9396 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9397 Rename local vars `left' and `width' to `bar_area_x' and
9398 `bar_area_width', respectively.
9399 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9400 background extension.
9402 2011-05-10 Jim Meyering <meyering@redhat.com>
9404 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9406 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9408 * image.c (Finit_image_library): Return t for built-in image types,
9409 like pbm and xbm. (Bug#8640)
9411 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9413 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9415 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9417 * w32console.c (Fset_screen_color): Doc fix.
9418 (Fget_screen_color): New function.
9419 (syms_of_ntterm): Defsubr it.
9421 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9422 unlink the temporary file if Fcall_process didn't create it in the
9424 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9425 child process will be redirected to a file specified with `:file'.
9426 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9427 cue to call_process_cleanup not to close that handle.
9429 2011-05-07 Ben Key <bkey76@gmail.com>
9431 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9432 one of two shell specific rules, either bootstrap-temacs-CMD or
9433 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9434 to the previous implementation of the bootstrap-temacs rule.
9435 The bootstrap-temacs-CMD rule is similar to the previous
9436 implementation of the bootstrap-temacs rule except that it
9437 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9440 These changes, along with some changes to nt/configure.bat,
9441 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9442 earlier fix to add support for --cflags and --ldflags options
9443 that include quotes so that it works whether make uses cmd or
9446 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9448 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9449 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9451 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9452 a string. Handle both cases.
9453 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9454 (Fdbus_register_method): Use Qinvalid_function.
9456 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9458 * makefile.w32-in: Update dependencies.
9459 (LISP_H): Add inttypes.h and stdin.h.
9460 (PROCESS_H): Add unistd.h.
9462 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9464 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9465 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9467 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9469 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9471 * term.c (vfatal): Remove stray call to va_end.
9472 It's not needed and the C Standard doesn't allow it here anyway.
9474 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9475 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9477 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9480 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9482 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9484 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9486 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9488 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9490 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9491 * charset.c (Fdefine_charset_internal): Don't initialize
9492 charset.code_space[15]. The value was garbage, on hosts with
9493 32-bit int (Bug#8600).
9495 * lread.c (read_integer): Be more consistent with string-to-number.
9496 Use string_to_number to do the actual conversion; this avoids
9497 rounding errors and fixes some other screwups. Without this fix,
9498 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9499 (digit_to_number): Move earlier, for benefit of read_integer.
9500 Return -1 if the digit is out of range for the base, -2 if it is
9501 not a digit in any supported base. (Bug#8602)
9503 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9505 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9506 to match comment at start of function. This also removes a
9507 GCC warning about overflow in a 32+64-bit port.
9509 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9511 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9512 Reported by Stefan Monnier in
9513 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9514 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9515 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9517 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9518 (EMACS_UINTPTR): Likewise, with uintptr_t.
9520 * lisp.h: Prefer 64-bit EMACS_INT if available.
9521 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9522 on 32-bit hosts that have 64-bit int, so that they can access
9524 However, temporarily disable this change unless the temporary
9525 symbol WIDE_EMACS_INT is defined.
9527 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9529 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9530 This removes an assumption that EMACS_INT and long are the same
9531 width as pointers. The assumption is true for Emacs porting targets
9532 now, but we want to make other targets possible.
9533 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9534 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9535 In the rest of the code, change types of integers that hold casted
9536 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9537 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9538 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9539 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9540 No need to cast type when ORing.
9541 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9542 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9543 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9544 assume EMACS_INT is the same width as char *.
9545 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9546 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9547 Remove no-longer-needed casts.
9548 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9549 (xg_tool_bar_help_callback, xg_make_tool_item):
9550 Use EMACS_INTPTR to hold an integer
9551 that will be cast to void *; this can avoid a GCC warning
9552 if EMACS_INT is not the same width as void *.
9553 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9554 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9555 (current_message_1, set_message_1):
9556 Use a local to convert to proper width without a cast.
9557 * xmenu.c (dialog_selection_callback): Likewise.
9559 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9560 Also, don't assume VALBITS / RAND_BITS is less than 5,
9561 and don't rely on undefined behavior when shifting a 1 left into
9563 * lisp.h (get_random): Change signature to match.
9565 * lread.c (hash_string): Use size_t, not int, for hash computation.
9566 Normally we prefer signed values; but hashing is special, because
9567 it's better to use unsigned division on hash table sizes so that
9568 the remainder is nonnegative. Also, size_t is the natural width
9569 for hashing into memory. The previous code used 'int', which doesn't
9570 retain enough info to hash well into very large tables.
9571 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9573 * dbusbind.c: Don't possibly lose pointer info when converting.
9574 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9575 Use XPNTR rather than XHASH, so that the high-order bits of
9576 the pointer aren't lost when converting through void *.
9578 * eval.c (Fautoload): Don't double-shift a pointer.
9580 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9582 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9584 * gnutls.c (DEF_GNUTLS_FN):
9585 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9587 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9589 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9592 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9594 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9595 New version that can reserve upto 2GB of heap space.
9597 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9599 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9601 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9603 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9604 `gnutls_certificate_set_x509_key_file'.
9606 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9608 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9609 Update dependencies.
9611 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9613 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9614 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9615 Remove unused parameter `fildes'.
9616 * process.c (read_process_output, send_process): Don't pass it.
9618 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9620 Fix previous change: the library cache is defined in w32.c.
9621 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9622 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9624 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9626 Implement dynamic loading of GnuTLS on Windows.
9628 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9629 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9630 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9633 * gnutls.c (Qgnutls_dll): Define.
9634 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9635 (gnutls_*): Declare function pointers.
9636 (init_gnutls_functions): New function to initialize function pointers.
9637 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9638 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9639 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9640 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9641 (emacs_gnutls_write, emacs_gnutls_read)
9642 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9643 (Fgnutls_available_p): New function.
9644 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9645 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9646 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9648 * image.c: Include w32.h.
9649 (Vimage_type_cache): Delete.
9650 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9651 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9652 (w32_delayed_load): Move to w32.c.
9654 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9656 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9657 (w32_delayed_load): Move from image.c. When loading a library, record
9658 its filename in the :loaded-from property of the library id.
9659 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9660 Initialize and staticpro them.
9661 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9663 * process.c: Include lisp.h before w32.h, not after.
9664 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9665 instead of gnutls_record_check_pending.
9667 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9669 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9671 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9672 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9675 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9677 * xterm.c (x_set_frame_alpha): Do not set property on anything
9678 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9680 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9682 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9684 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9686 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9687 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9688 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9689 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9690 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9691 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9692 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9693 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9694 (Qgnutls_bootprop_callbacks_verify): Make static.
9696 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9698 * callproc.c: Indentation fixup.
9700 * sysdep.c (wait_for_termination_1): Make static.
9701 (wait_for_termination, interruptible_wait_for_termination):
9702 Move after wait_for_termination_1.
9704 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9706 * sysdep.c (interruptible_wait_for_termination): New function
9707 which is like wait_for_termination, but allows keyboard
9710 * callproc.c (Fcall_process): Add (:file "file") as an option for
9712 (Fcall_process_region): Ditto.
9714 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9716 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9717 rather than `XVECTOR (FOO)->size'.
9719 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9720 inttypes.h, as a gnulib replacement is used if it not available in
9723 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9725 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9726 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9727 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9729 * coding.c (coding_alloc_by_realloc): Error out if destination
9730 will grow beyond MOST_POSITIVE_FIXNUM.
9731 (decode_coding_emacs_mule): Abort if there isn't enough place in
9732 charbuf for the composition carryover bytes. Reserve an extra
9733 space for up to 2 characters produced in a loop.
9734 (decode_coding_iso_2022): Abort if there isn't enough place in
9735 charbuf for the composition carryover bytes.
9737 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9739 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9740 aborting when %lld or %lll format is passed.
9741 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9742 %llo or %llx format is passed. (Bug#8545)
9744 * window.c (window_scroll_line_based): Use a marker instead of
9745 simple variables to record original value of point. (Bug#7952)
9747 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9748 produced by %s or %c overflows available buffer space. (Bug#8545)
9750 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9752 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9753 (SIZE_MAX): Move defn after all includes, as they might #define it.
9755 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9757 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9759 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9761 * keyboard.c (Qdelayed_warnings_hook): Define.
9762 (command_loop_1): Run `delayed-warnings-hook'
9763 if Vdelayed_warnings_list is non-nil.
9764 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9765 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9767 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9769 * doprnt.c (doprnt): Don't return value smaller than the buffer
9770 size if the message was truncated. (Bug#8545).
9772 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9774 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9775 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9777 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9779 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9781 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9783 * makefile.w32-in: Update dependencies.
9785 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9787 Improve `doprnt' and its usage. (Bug#8545)
9788 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9789 `format_end'. Remove support for %l as a conversion specifier.
9790 Don't use xrealloc. Improve diagnostics when the %l size modifier
9791 is used. Update the commentary.
9793 * eval.c (verror): Simplify calculation of size_t.
9795 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9798 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9800 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9803 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9805 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9806 This makes this file independent of the recent pseudovector change.
9808 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9810 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9812 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9813 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9814 Remove unused local.
9815 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9817 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9818 GCC 4.6.0 optimizes based on type-based alias analysis.
9819 For example, if b is of type struct buffer * and v of type struct
9820 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9821 != &v->size, and therefore "v->size = 1; b->size = 2; return
9822 v->size;" must therefore return 1. This assumption is incorrect
9823 for Emacs, since it type-puns struct Lisp_Vector * with many other
9824 types. To fix this problem, this patch adds a new type struct
9825 vectorlike_header that documents the constraints on layout of vectors
9826 and pseudovectors, and helps optimizing compilers not get fooled
9827 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9828 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9829 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9831 (XSETPVECTYPE): Rewrite in terms of new macro.
9832 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9833 This is a bit clearer, and further avoids the possibility of
9834 undesirable aliasing.
9835 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9836 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9837 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9838 since Lisp_Subr is a special case (no "next" field).
9839 (ASIZE): Now uses header.size rather than size.
9840 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9841 to avoid the hassle of writing XVECTOR (foo)->header.size.
9842 (struct vectorlike_header): New type.
9843 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9844 object, to help avoid aliasing.
9845 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9846 (SUBRP): Likewise, since Lisp_Subr is a special case.
9847 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9848 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9849 (struct Lisp_Hash_Table): Combine first two members into a single
9850 struct vectorlike_header member. All uses of "size" and "next" members
9851 changed to be "header.size" and "header.next".
9852 * buffer.h (struct buffer): Likewise.
9853 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9854 * frame.h (struct frame): Likewise.
9855 * process.h (struct Lisp_Process): Likewise.
9856 * termhooks.h (struct terminal): Likewise.
9857 * window.c (struct save_window_data, struct saved_window): Likewise.
9858 * window.h (struct window): Likewise.
9859 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9860 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9861 * buffer.c (init_buffer_once): Likewise.
9862 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9864 * process.c (Fformat_network_address): Use local var for size,
9867 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9869 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9870 * data.c (atof): Remove decl; no longer used or needed.
9871 (digit_to_number): Move to lread.c.
9872 (Fstring_to_number): Use new string_to_number function, to be
9873 consistent with how the Lisp reader treats infinities and NaNs.
9874 Do not assume that floating-point numbers represent EMACS_INT
9875 without losing information; this is not true on most 64-bit hosts.
9876 Avoid double-rounding errors, by insisting on integers when
9877 parsing non-base-10 numbers, as the documentation specifies.
9878 * lisp.h (string_to_number): New decl, replacing ...
9879 (isfloat_string): Remove.
9880 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9881 (read1): Do not accept +. and -. as integers; this
9882 appears to have been a coding error. Similarly, do not accept
9883 strings like +-1e0 as floating point numbers. Do not report
9884 overflow for integer overflows unless the base is not 10 which
9885 means we have no simple and reliable way to continue.
9886 Break out the floating-point parsing into a new
9887 function string_to_number, so that Fstring_to_number parses
9888 floating point numbers consistently with the Lisp reader.
9889 (digit_to_number): Move here from data.c. Make it static inline.
9890 (E_CHAR, EXP_INT): Remove, replacing with ...
9891 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9892 (string_to_number): New function, replacing isfloat_string.
9893 This function checks for valid syntax and produces the resulting
9894 Lisp float number too. Rework it so that string-to-number
9895 no longer mishandles examples like "1.0e+". Use strtoumax,
9896 so that overflow for non-base-10 numbers is reported only when
9897 there's no portable and simple way to convert to floating point.
9899 * textprop.c (set_text_properties_1): Rewrite for clarity,
9900 and to avoid GCC warning about integer overflow.
9902 * intervals.h (struct interval): Use EMACS_INT for members
9903 where EMACS_UINT might cause problems. See
9904 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9905 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9906 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9908 (offset_intervals): Tell GCC not to worry about length overflow
9909 when negating a negative length.
9911 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9912 (overrun_check_free): Likewise.
9914 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9915 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9918 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9919 (gnutls_make_error): Rename local to avoid shadowing.
9920 (gnutls_emacs_global_deinit): ifdef out; not used.
9921 (Fgnutls_boot): Use const for pointer to readonly storage.
9922 Comment out unused local. Fix pointer signedness problems.
9924 * lread.c (openp): Don't stuff size_t into an 'int'.
9925 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9926 about possible signed overflow.
9928 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9929 (GDK_KEY_g): Don't define if already defined.
9930 (xg_prepare_tooltip): Avoid pointer signedness problem.
9931 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9933 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9934 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9936 * xfns.c (Fx_window_property): Simplify a bit,
9937 to make a bit faster and to avoid GCC 4.6.0 warning.
9938 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9940 * fns.c (internal_equal): Don't assume size_t fits in int.
9942 * alloc.c (compact_small_strings): Tighten assertion a little.
9944 Replace pEd with more-general pI, and fix some printf arg casts.
9945 * lisp.h (pI): New macro, generalizing old pEd macro to other
9946 conversion specifiers. For example, use "...%"pI"d..." rather
9947 than "...%"pEd"...".
9948 (pEd): Remove. All uses replaced with similar uses of pI.
9949 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9950 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9951 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9952 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9953 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9954 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9955 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9957 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9958 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9959 * print.c (safe_debug_print, print_object): Likewise.
9960 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9962 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9963 avoiding the 0 flag, which is not portable.
9964 * process.c (Fmake_network_process): Use pI to avoid cast.
9965 * region-cache.c (pp_cache): Likewise.
9966 * xdisp.c (decode_mode_spec): Likewise.
9967 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9968 behavior on 64-bit hosts with printf arg.
9969 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9970 (x_stop_queuing_selection_requests): Likewise.
9971 (x_get_window_property): Don't truncate byte count to an 'int'
9974 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9975 here, since it parses constructs like leading '-' and spaces,
9976 which are not wanted; and it overflows with large numbers.
9977 Instead, simply match F[0-9]+, which is what is wanted anyway.
9979 * alloc.c: Remove unportable assumptions about struct layout.
9980 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9981 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9982 (allocate_vectorlike, make_pure_vector): Use the new macros,
9983 plus offsetof, to remove unportable assumptions about struct layout.
9984 These assumptions hold on all porting targets that I know of, but
9985 they are not guaranteed, they're easy to remove, and removing them
9986 makes further changes easier.
9988 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9989 This doesn't fix a bug but makes the code clearer.
9990 (string_overrun_cookie): Now const. Use initializers that
9991 don't formally overflow signed char, to avoid warnings.
9992 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9993 can cause Emacs to crash when string overrun checking is enabled.
9994 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9995 multiple of sizeof (EMACS_INT); it need not be, if
9996 alignof(EMACS_INT) < sizeof (EMACS_INT).
9997 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9999 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10001 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10003 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10005 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10006 supposed to be handshaking. (Bug#8556)
10007 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10009 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10011 * lisp.h (Qdebug): List symbol.
10012 * eval.c (Qdebug): Restore global linkage.
10013 * keyboard.c (debug-on-event): New variable.
10014 (handle_user_signal): Break into debugger when debug-on-event
10015 matches the current signal symbol.
10017 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10019 * alloc.c (check_sblock, check_string_bytes)
10020 (check_string_free_list): Convert to standard C.
10022 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10024 * w32.c (emacs_gnutls_push): Fix typo.
10026 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10028 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10029 "cast to pointer from integer of different size".
10031 Improve doprnt and its use in verror. (Bug#8545)
10032 * doprnt.c (doprnt): Document the set of format control sequences
10033 supported by the function. Use SAFE_ALLOCA instead of always
10036 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10037 is one byte too soon. Don't use xrealloc; instead xfree and
10040 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10042 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10045 * gnutls.c: Renamed global_initialized to
10046 gnutls_global_initialized. Added internals for the
10047 :verify-hostname-error, :verify-error, and :verify-flags
10048 parameters of `gnutls-boot' and documented those parameters in the
10049 docstring. Start callback support.
10050 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10051 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10052 on error. Return error code.
10053 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10054 (emacs_gnutls_read): Likewise.
10055 (Fgnutls_boot): Return handshake error code.
10056 (emacs_gnutls_handle_error): New function.
10057 (wsaerror_to_errno): Likewise.
10059 * w32.h (emacs_gnutls_pull): Add prototype.
10060 (emacs_gnutls_push): Likewise.
10062 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10063 (emacs_gnutls_push): Likewise.
10065 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10067 * process.c (wait_reading_process_output): Check if GnuTLS
10068 buffered some data internally if no FDs are set for TLS
10071 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10072 (LIBS): Link to USER_LIBS.
10073 ($(BLD)/gnutls.$(0)): New target.
10075 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10077 * xdisp.c (handle_single_display_spec): Rename the
10078 display_replaced_before_p argument into display_replaced_p, to
10079 make it consistent with the commentary. Fix typos in the
10082 * textprop.c (syms_of_textprop): Remove dead code.
10083 (copy_text_properties): Delete obsolete commentary about an
10084 interface that was deleted long ago. Fix typos in the description
10087 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10088 to changes in oldXMenu/XMenu.h from 2011-04-16.
10089 <menu_help_message, prev_menu_help_message>: Constify.
10090 (IT_menu_make_room): menu->help_text is now `const char **';
10093 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10094 to changes in oldXMenu/XMenu.h from 2011-04-16.
10095 (struct XMenu): Declare `help_text' `const char **'.
10097 * xfaces.c <Qunspecified>: Make extern again.
10099 * syntax.c: Include sys/types.h before including regex.h, as
10102 * doc.c (get_doc_string): Improve the format passed to `error'.
10104 * doprnt.c (doprnt): Improve commentary.
10106 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10108 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10111 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10112 changes in globals.h immediately force recompilation.
10113 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10114 $(CURDIR)/s/ms-w32.h.
10115 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10117 * character.c (Fchar_direction): Function deleted.
10118 (syms_of_character): Don't defsubr it.
10119 <char-direction-table>: Deleted.
10121 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10123 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10124 * doprnt.c: Include limits.h.
10125 (SIZE_MAX): New macro.
10126 (doprnt): Return a size_t value. 2nd arg is now size_t.
10127 Many local variables are now size_t instead of int or unsigned.
10128 Improve overflow protection. Support `l' modifier for integer
10129 conversions. Support %l conversion. Don't assume an EMACS_INT
10130 argument for integer conversions and for %c.
10132 * lisp.h (doprnt): Restore prototype.
10134 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10135 $(SRC)/character.h.
10137 * Makefile.in (base_obj): Add back doprnt.o.
10139 * deps.mk (doprnt.o): Add back prerequisites.
10140 (callint.o): Depend on character.h.
10142 * eval.c (internal_lisp_condition_case): Include the handler
10143 representation in the error message.
10144 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10145 when breaking from the loop.
10147 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10149 * callint.c (Fcall_interactively): When displaying error message
10150 about invalid control letter, pass the character's codepoint, not
10151 a pointer to its multibyte form. Improve display of the character
10152 in octal and display also its hex code.
10154 * character.c (char_string): Use %x to display the (unsigned)
10155 codepoint of an invalid character, to avoid displaying a bogus
10158 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10159 `error', not SYMBOL_NAME itself.
10161 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10162 character arguments to `error'.
10164 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10165 to `error' in error message about FINAL_CHAR argument. Make sure
10166 FINAL_CHAR is a character, and use %c when it is passed as
10167 argument to `error'.
10169 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10171 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10173 * w32.c: Include <time.h>.
10174 (sys_localtime): New function.
10176 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10178 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10180 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10182 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10184 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10185 zombies (Bug#8467).
10187 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10189 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10190 gl_state.e_property when gl_state.object is Qt.
10192 * insdel.c (make_gap_larger): Remove limitation of buffer size
10195 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10197 * xdisp.c (lookup_glyphless_char_display)
10198 (produce_glyphless_glyph): Handle cons cell entry in
10199 glyphless-char-display.
10200 (Vglyphless_char_display): Document it.
10202 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10203 glyphless-char-display.
10205 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10207 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10209 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10211 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10212 definition for no-X builds.
10214 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10216 Static checks with GCC 4.6.0 and non-default toolkits.
10218 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10220 * process.c (keyboard_bit_set): Define only if SIGIO.
10221 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10222 (send_process): Repair possible setjmp clobbering.
10224 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10226 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10228 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10230 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10231 Define only if needed.
10233 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10234 by pacifying GCC about it. Maybe it's time to retire it?
10235 * xfaces.c (USG, __TIMEVAL__): Likewise.
10237 * dispextern.h (struct redisplay_interface): Rename param
10238 to avoid shadowing.
10239 * termhooks.h (struct terminal): Likewise.
10240 * xterm.c (xembed_send_message): Likewise.
10242 * insdel.c (make_gap_smaller): Define only if
10243 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10245 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10248 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10249 so that we aren't warned about unused symbols.
10251 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10253 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10255 * xfns.c (x_real_positions): Mark locals as initialized.
10257 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10259 * xterm.c: Fix problems found by static analysis with other toolkits.
10260 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10261 (x_dispatch_event): Declare static if USE_GTK, and
10262 define if USE_GTK || USE_X_TOOLKIT.
10263 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10264 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10265 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10266 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10268 * xmenu.c (menu_help_callback): Pointer type fixes.
10269 Use const pointers when pointing at readonly data. Avoid pointer
10270 signedness clashes.
10271 (FALSE): Remove unused macro.
10272 (update_frame_menubar): Remove unused decl.
10274 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10276 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10277 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10278 (single_menu_item): Rename local to avoid shadowing.
10280 * keyboard.c (make_lispy_event): Remove unused local var.
10282 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10283 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10285 * bitmaps: Change bitmaps from unsigned char back to the X11
10286 compatible char. Avoid the old compiler warnings about
10287 out-of-range initializers by using, for example, '\xab' rather
10290 * xgselect.c (xgselect_initialize): Check vs interface
10291 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10293 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10295 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10296 to read-only memory.
10298 * fns.c (vector): Remove; this old hack is no longer needed.
10300 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10302 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10304 * xrdb.c (x_load_resources): Omit unused local.
10306 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10307 (x_window): Rename locals to avoid shadowing.
10308 (USG): Use the kludged USG macro, to pacify gcc.
10310 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10311 (x_term_init): Remove local to avoid shadowing.
10313 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10315 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10316 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10318 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10320 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10322 Fix regex.c, syntax.c and friends for buffers > 2GB.
10323 * syntax.h (struct gl_state_s): Declare character position members
10326 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10328 * textprop.c (verify_interval_modification, interval_of):
10329 Declare arguments EMACS_INT.
10331 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10334 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10336 * indent.c (Fvertical_motion): Local variable it_start is now
10339 * regex.c (re_match, re_match_2, re_match_2_internal)
10340 (bcmp_translate, regcomp, regexec, print_double_string)
10341 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10342 (re_compile_pattern, re_exec): Declare arguments and local
10343 variables `size_t' and `ssize_t' and return values `regoff_t', as
10345 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10346 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10347 <compile_stack_type>: `size' and `avail' are now `size_t'.
10349 * regex.h <regoff_t>: Use ssize_t, not int.
10350 (re_search, re_search_2, re_match, re_match_2): Arguments that
10351 specify buffer/string position and length are now ssize_t and
10352 size_t. Return type is regoff_t.
10354 2011-04-16 Ben Key <bkey76@gmail.com>
10356 * nsfont.m: Fixed bugs in ns_get_family and
10357 ns_descriptor_to_entity that were caused by using free to
10358 deallocate memory blocks that were allocated by xmalloc (via
10359 xstrdup). This caused Emacs to crash when compiled with
10360 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10361 --enable-checking=xmallocoverrun). xfree is now used to
10362 deallocate these memory blocks.
10364 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10366 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10368 emacs_write: Accept and return EMACS_INT for sizes.
10369 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10371 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10372 Accept and return EMACS_INT.
10373 (emacs_gnutls_write): Return the number of bytes written on
10375 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10376 (emacs_read, emacs_write): Remove check for negative size, as the
10377 Emacs source code has been audited now.
10378 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10379 (emacs_read, emacs_write): Use it.
10380 * process.c (send_process): Adjust to the new signatures of
10381 emacs_write and emacs_gnutls_write. Do not attempt to store
10382 a byte offset into an 'int'; it might overflow.
10383 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10385 * sound.c: Don't assume sizes fit in 'int'.
10386 (struct sound_device.period_size, alsa_period_size):
10387 Return EMACS_INT, not int.
10388 (struct sound_device.write, vox_write, alsa_write):
10389 Accept EMACS_INT, not int.
10390 (wav_play, au_play): Use EMACS_INT to store sizes and to
10391 record read return values.
10393 2011-04-15 Ben Key <bkey76@gmail.com>
10395 * keyboard.c (Qundefined): Don't declare static since it is used
10397 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10398 static since they are used in nsfont.m.
10400 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10402 * process.c (Qprocessp): Don't declare static.
10403 * lisp.h (Qprocessp): Declare again.
10405 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10407 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10409 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10411 Improve C-level modularity by making more things 'static'.
10413 Don't publish debugger-only interfaces to other modules.
10414 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10415 (verify_bytepos, count_markers): Move decls to the only modules
10417 * region-cache.h (pp_cache): Likewise.
10418 * window.h (check_all_windows): Likewise.
10419 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10421 * sysdep.c (croak): Now static, if
10422 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10423 * syssignal.h (croak): Declare only if not static.
10425 * alloc.c (refill_memory_reserve): Now static if
10426 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10427 * lisp.h (refill_memory_reserve): Declare only if not static.
10429 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10430 Define only if USE_LUCID.
10432 * xrdb.c (x_customization_string, x_rm_string): Now static.
10434 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10435 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10437 * xdisp.c (draw_row_with_mouse_face): Now static.
10438 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10440 * window.h (check_all_windows): Mark externally visible.
10442 * window.c (window_deletion_count): Now static.
10444 * undo.c: Make symbols static if they're not exported.
10445 (last_undo_buffer, last_boundary_position, pending_boundary):
10448 * textprop.c (interval_insert_behind_hooks): Now static.
10449 (interval_insert_in_front_hooks): Likewise.
10451 * term.c: Make symbols static if they're not exported.
10452 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10453 (max_frame_lines, tty_set_terminal_modes):
10454 (tty_reset_terminal_modes, tty_turn_off_highlight):
10455 (get_tty_terminal): Now static.
10456 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10457 * termhooks.h (term_mouse_moveto): Do not declare if
10458 HAVE_WINDOW_SYSTEM.
10459 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10460 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10462 * sysdep.c: Make symbols static if they're not exported.
10463 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10465 (sigprocmask_set, full_mask): Remove; unused.
10466 (wait_debugging): Mark as visible.
10467 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10468 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10470 * syntax.c (syntax_temp): Define only if !__GNUC__.
10472 * sound.c (current_sound_device, current_sound): Now static.
10474 * search.c (searchbufs, searchbuf_head): Now static.
10476 * scroll.c (scroll_cost): Remove; unused.
10477 * dispextern.h (scroll_cost): Remove decl.
10479 * region-cache.h (pp_cache): Mark as externally visible.
10481 * process.c: Make symbols static if they're not exported.
10482 (process_tick, update_tick, create_process, chan_process):
10483 (Vprocess_alist, proc_buffered_char, datagram_access):
10484 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10485 (deactivate_process): Mark defn as static, as well as decl.
10486 * lisp.h (create_process): Remove decl.
10487 * process.h (chan_process, Vprocess_alist): Remove decls.
10489 * print.c: Make symbols static if they're not exported.
10490 (print_depth, new_backquote_output, being_printed, print_buffer):
10491 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10492 (print_interval, print_number_index, initial_stderr_stream):
10494 * lisp.h (Fprinc): Remove decl.
10495 (debug_output_compilation_hack): Mark as externally visible.
10497 * sysdep.c (croak): Move decl from here to syssignal.h.
10498 * syssignal.h (croak): Put it here, so the API can be checked when
10499 'croak' is called from dissociate_if_controlling_tty.
10501 * minibuf.c: Make symbols static if they're not exported.
10502 (minibuf_save_list, choose_minibuf_frame): Now static.
10503 * lisp.h (choose_minibuf_frame): Remove decl.
10505 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10507 * lread.c: Make symbols static if they're not exported.
10508 (read_objects, initial_obarray, oblookup_last_bucket_number):
10510 (make_symbol): Remove; unused.
10511 * lisp.h (initial_obarray, make_symbol): Remove decls.
10513 * keyboard.c: Make symbols static if they're not exported.
10514 (single_kboard, recent_keys_index, total_keys, recent_keys):
10515 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10516 (this_single_command_key_start, echoing, last_auto_save):
10517 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10518 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10519 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10520 (Vlispy_mouse_stem, double_click_count):
10522 (force_auto_save_soon): Define only if SIGDANGER.
10523 (ignore_mouse_drag_p): Now static if
10524 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10525 (print_help): Remove; unused.
10526 (stop_character, last_timer_event): Mark as externally visible.
10527 * keyboard.h (ignore_mouse_drag_p): Declare only if
10528 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10529 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10530 * lisp.h (echoing): Remove decl.
10531 (force_auto_save_soon): Declare only if SIGDANGER.
10532 * xdisp.c (redisplay_window): Simplify code, to make it more
10533 obvious that ignore_mouse_drag_p is not accessed if !defined
10534 USE_GTK && !defined HAVE_NS.
10536 * intervals.c: Make symbols static if they're not exported.
10537 (merge_properties_sticky, merge_interval_right, delete_interval):
10539 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10541 * insdel.c: Make symbols static if they're not exported.
10542 However, leave prepare_to_modify_buffer alone. It's never
10543 called from outside this function, but that appears to be a bug.
10544 (combine_after_change_list, combine_after_change_buffer):
10545 (adjust_after_replace, signal_before_change): Now static.
10546 (adjust_after_replace_noundo): Remove; unused.
10547 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10548 (signal_before_change): Remove decls.
10550 * indent.c (val_compute_motion, val_vmotion): Now static.
10552 * image.c: Make symbols static if they're not exported.
10553 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10555 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10556 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10558 * fringe.c (standard_bitmaps): Now static.
10559 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10561 * frame.c: Make symbols static if they're not exported.
10562 (x_report_frame_params, make_terminal_frame): Now static.
10563 (get_frame_param): Now static, unless HAVE_NS.
10564 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10565 (x_get_resource_string): Remove; not used.
10566 * frame.h (make_terminal_frame, x_report_frame_params):
10567 (x_get_resource_string); Remove decls.
10568 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10569 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10571 * font.c, fontset.c: Make symbols static if they're not exported.
10572 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10573 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10574 * font.c (font_close_object): Now static.
10575 * font.h (font_close_object): Remove.
10576 * fontset.c (FONTSET_OBJLIST): Remove.
10577 (free_realized_fontset) #if-0 the body, which does nothing.
10578 (face_suitable_for_char_p): #if-0, as it's never called.
10579 * fontset.h (face_suitable_for_char_p): Remove decl.
10580 * xfaces.c (face_at_string_position):
10581 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10582 since 0 is always ASCII.
10584 * fns.c (weak_hash_tables): Now static.
10586 * fileio.c: Make symbols static if they're not exported.
10587 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10588 (Vwrite_region_annotation_buffers): Now static.
10590 * eval.c: Make symbols static if they're not exported.
10591 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10592 * lisp.h (backtrace_list): Remove decl.
10594 * emacs.c: Make symbols static if they're not exported.
10595 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10596 (fatal_error_code, fatal_error_signal_hook, standard_args):
10598 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10599 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10600 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10601 * lisp.h (fatal_error_signal_hook): Remove decl.
10602 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10604 * editfns.c: Move a (normally-unused) function to its only use.
10605 * editfns.c, lisp.h (get_operating_system_release): Remove.
10606 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10607 worth the hassle of breaking this out.
10609 * xterm.c: Make symbols static if they're not exported.
10610 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10611 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10612 (x_destroy_window, x_delete_display):
10614 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10615 (x_mouse_leave): Remove; unused.
10616 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10617 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10618 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10620 (x_mouse_leave): Declare only if WINDOWSNT.
10621 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10622 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10625 * ftxfont.c: Make symbols static if they're not exported.
10626 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10628 * font.h (ftxfont_driver): Likewise.
10630 * xfns.c: Make symbols static if they're not exported.
10631 (x_last_font_name, x_display_info_for_name):
10632 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10633 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10634 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10635 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10636 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10637 (last_show_tip_args): Now static.
10638 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10639 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10640 (x_screen_planes): Remove; unused.
10641 * dispextern.h (x_screen_planes): Remove decl.
10643 * dispnew.c: Make symbols static if they're not exported.
10644 * dispextern.h (redraw_garbaged_frames, scrolling):
10645 (increment_row_positions): Remove.
10646 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10647 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10649 (redraw_garbaged_frames): Remove; unused.
10651 * xfaces.c: Make symbols static if they're not exported.
10652 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10654 * xterm.h (defined_color): Remove decls.
10655 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10656 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10657 (menu_face_changed_default, defined_color, free_realized_face):
10658 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10659 (ascii_face_of_lisp_face): Remove; unused.
10661 * xdisp.c: Make symbols static if they're not exported.
10662 * dispextern.h (scratch_glyph_row, window_box_edges):
10663 (glyph_to_pixel_coords, set_cursor_from_row):
10664 (get_next_display_element, set_iterator_to_next):
10665 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10666 (show_mouse_face): Remove decls
10667 * frame.h (message_buf_print): Likewise.
10668 * lisp.h (pop_message, set_message, check_point_in_composition):
10670 * xterm.h (set_vertical_scroll_bar): Likewise.
10671 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10672 (message_buf_print, scratch_glyph_row, displayed_buffer):
10673 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10674 (get_next_display_element, show_mouse_face, window_box_edges):
10675 (frame_to_window_pixel_xy, check_point_in_composition):
10676 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10677 (glyph_to_pixel_coords): Remove; unused.
10679 * dired.c (file_name_completion): Now static.
10681 * dbusbind.c (xd_in_read_queued_messages): Now static.
10683 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10684 * data.c (circular_list_error): Remove.
10686 * commands.h (last_point_position, last_point_position_buffer):
10687 (last_point_position_window): Remove decls.
10688 * keyboard.c: Make these variables static.
10690 * coding.h (coding, code_convert_region, encode_coding_gap):
10692 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10693 (iso_code_class, detect_coding, code_convert_region): Now static.
10694 (encode_coding_gap): Remove; unused.
10696 * chartab.c (chartab_chars, chartab_bits): Now static.
10698 * charset.h (charset_iso_8859_1): Remove decl.
10699 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10702 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10703 * ccl.c (Vccl_program_table): Now static.
10704 (check_ccl_update): Remove; unused.
10706 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10707 * category.h: ... from here.
10708 * category.c (check_category_table, set_category_set): Now static.
10710 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10711 * lisp.h: Remove these decls.
10713 * buffer.c (buffer_count): Remove unused var.
10715 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10716 so that it's not optimized away.
10717 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10718 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10719 exported only to the debugger.
10721 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10722 * atimer.h (run_all_atimers): Remove; not exported.
10724 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10725 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10726 was inaccessible from Lisp.
10727 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10728 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10730 alloc.c: Import and export fewer symbols, and remove unused items.
10731 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10733 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10734 it's not optimized away by whole-program optimization.
10735 (message_enable_multibyte, free_misc): Remove.
10736 (catchlist, handlerlist, mark_backtrace):
10737 Declare only if BYTE_MARK_STACK.
10738 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10739 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10740 (message_enable_multibyte): Remove decl.
10741 (free_misc, interval_free_list, float_block, float_block_index):
10742 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10743 (cons_free_list, last_marked_index):
10745 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10746 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10747 (mark_backtrace): Define only if BYTE_MARK_STACK.
10748 * xdisp.c (message_enable_multibyte): Now static.
10750 Declare Lisp_Object Q* variables to be 'static' if not exported.
10751 This makes it easier for human readers (and static analyzers)
10752 to see whether these variables are used from other modules.
10753 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10754 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10755 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10756 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10757 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10758 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10759 * xmenu.c, xselect.c:
10760 Declare Q* vars static if they are not used in other modules.
10761 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10762 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10763 Remove decls of unexported vars.
10764 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10766 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10768 Make Emacs functions such as Fatom 'static' by default.
10769 This makes it easier for human readers (and static analyzers)
10770 to see whether these functions can be called from other modules.
10771 DEFUN now defines a static function. To make the function external
10772 so that it can be used in other C modules, use the new macro DEFUE.
10773 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10774 (Finit_image_library):
10775 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10776 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10777 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10778 Remove decls, since these functions are now static.
10779 (Funintern, Fget_internal_run_time): New decls, since these functions
10780 were already external.
10782 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10783 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10784 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10785 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10786 * keyboard.c, keymap.c, lread.c:
10787 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10788 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10789 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10790 Mark functions with DEFUE instead of DEFUN,
10791 if they are used in other modules.
10792 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10793 decls for now-static functions.
10794 * buffer.h (Fdelete_overlay): Remove decl.
10795 * callproc.c (Fgetenv_internal): Mark as internal.
10796 * composite.c (Fremove_list_of_text_properties): Remove decl.
10797 (Fcomposition_get_gstring): New forward static decl.
10798 * composite.h (Fcomposite_get_gstring): Remove decl.
10799 * dired.c (Ffile_attributes): New forward static decl.
10800 * doc.c (Fdocumntation_property): New forward static decl.
10801 * eval.c (Ffetch_bytecode): New forward static decl.
10802 (Funintern): Remove extern decl; now in .h file where it belongs.
10803 * fileio.c (Fmake_symbolic_link): New forward static decl.
10804 * image.c (Finit_image_library): New forward static decl.
10805 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10806 * intervals.h (Fprevious_property_change):
10807 (Fremove_list_of_text_properties): Remove decls.
10808 * keyboard.c (Fthis_command_keys): Remove decl.
10809 (Fcommand_execute): New forward static decl.
10810 * keymap.c (Flookup_key): New forward static decl.
10811 (Fcopy_keymap): Now static.
10812 * keymap.h (Flookup_key): Remove decl.
10813 * process.c (Fget_process): New forward static decl.
10814 (Fprocess_datagram_address): Mark as internal.
10815 * syntax.c (Fsyntax_table_p): New forward static decl.
10816 (skip_chars): Remove duplicate decl.
10817 * textprop.c (Fprevious_property_change): New forward static decl.
10818 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10820 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10821 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10823 * editfns.c (Fformat): Remove unreachable code.
10825 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10827 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10830 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10832 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10833 when at ZV. (Bug#8487)
10835 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10837 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10839 * keyboard.c (parse_tool_bar_item): Likewise.
10840 * sound.c (sound_cleanup, alsa_close): Likewise.
10841 * termcap.c (tgetent): Likewise.
10842 * xfns.c (x_default_font_parameter): Likewise.
10843 * xsettings.c (read_and_apply_settings): Likewise.
10845 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10846 (overrun_check_free): Protoize.
10848 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10850 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10851 since callers should never pass a negative size.
10852 Change the signature to match that of plain 'read' and 'write'; see
10853 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10854 * lisp.h: Update prototypes of emacs_write and emacs_read.
10856 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10858 * xdisp.c (redisplay_window): Don't try to determine the character
10859 position of the scroll margin if the window start point w->startp
10860 is outside the buffer's accessible region. (Bug#8468)
10862 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10864 Fix write-region and its subroutines for buffers > 2GB.
10865 * fileio.c (a_write, e_write): Modify declaration of arguments and
10866 local variables to support buffers larger than 2GB.
10867 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10869 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10870 argument, local variables, and return value.
10872 * lisp.h: Update prototypes of emacs_write and emacs_read.
10874 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10876 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10878 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10880 Fix more problems found by GCC 4.6.0's static checks.
10882 * xdisp.c (vmessage): Use a better test for character truncation.
10884 * charset.c (load_charset_map): <, not <=, for optimization,
10885 and to avoid potential problems with integer overflow.
10886 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10887 * casetab.c (set_identity, shuffle): Likewise.
10888 * editfns.c (Fformat): Likewise.
10889 * syntax.c (skip_chars): Likewise.
10891 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10892 This also lets GCC 4.6.0 generate slightly better loop code.
10894 * callint.c (Fcall_interactively): <, not <=, for optimization.
10895 (Fcall_interactively): Count the number of arguments produced,
10896 not the number of arguments given. This is simpler and lets GCC
10897 4.6.0 generate slightly better code.
10899 * ftfont.c: Distingish more carefully between FcChar8 and char.
10900 The previous code passed unsigned char * to a functions like
10901 strlen and xstrcasecmp that expect char *, which does not
10902 conform to the C standard.
10903 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10904 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10905 char * when the C standard requires it.
10907 * keyboard.c (read_char): Remove unused var.
10909 * eval.c: Port to Windows vsnprintf (Bug#8435).
10910 Include <limits.h>.
10911 (SIZE_MAX): Define if the headers do not.
10912 (verror): Do not give up if vsnprintf returns a negative count.
10913 Instead, grow the buffer. This ports to Windows vsnprintf, which
10914 does not conform to C99. Problem reported by Eli Zaretskii.
10915 Also, simplify the allocation scheme, by avoiding the need for
10916 calling realloc, and removing the ALLOCATED variable.
10918 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10920 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10921 But keep the doprint source code for now, as we might revamp it
10922 and use it again (Bug#8435).
10923 * lisp.h (doprnt): Remove.
10924 * Makefile.in (base_obj): Remove doprnt.o.
10925 * deps.mk (doprnt.o): Remove.
10927 error: Print 32- and 64-bit integers portably (Bug#8435).
10928 Without this change, on typical 64-bit hosts error ("...%d...", N)
10929 was used to print both 32- and 64-bit integers N, which relied on
10930 undefined behavior.
10931 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10932 * lisp.h (error, verror): Mark as printf-like functions.
10933 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10934 Report overflow in size calculations when allocating printf buffer.
10935 Do not truncate output string at its first null byte.
10936 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10937 Truncate the output at a character boundary, since vsnprintf does not
10939 * charset.c (check_iso_charset_parameter): Convert internal
10940 character to string before calling 'error', since %c now has the
10942 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10943 overflow when computing char to be passed to 'error'. Do not
10944 pass Lisp_Object to 'error'; pass the integer instead.
10945 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10946 formatted with plain %d.
10948 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10950 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10952 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10954 * xterm.c (x_catch_errors): Remove duplicate declaration.
10956 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10958 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10960 2011-04-10 Jim Meyering <meyering@redhat.com>
10962 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10963 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10964 return ssize_t not "int", and use size_t as the buffer length.
10965 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10966 * gnutls.h: Update declarations.
10967 * process.c (read_process_output): Use ssize_t, to match.
10968 (send_process): Likewise.
10970 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10972 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10974 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10976 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10977 Use unsigned char, to match FcChar8 type definition.
10979 * xterm.c (handle_one_xevent):
10980 * xmenu.c (create_and_show_popup_menu):
10981 * xselect.c (x_decline_selection_request)
10982 (x_reply_selection_request): Avoid type-punned deref of X events.
10984 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10986 Fix some uses of `int' instead of EMACS_INT.
10987 * search.c (string_match_1, fast_string_match)
10988 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10989 (scan_buffer, find_next_newline_no_quit)
10990 (find_before_next_newline, search_command, Freplace_match)
10991 (Fmatch_data): Make some `int' variables be EMACS_INT.
10993 * xdisp.c (display_count_lines): 3rd argument and return value now
10994 EMACS_INT. All callers changed.
10995 (pint2hrstr): Last argument is now EMACS_INT.
10997 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10998 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10999 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11000 (decode_coding_utf_16, decode_coding_emacs_mule)
11001 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11002 (decode_coding_ccl, decode_coding_charset)
11003 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11004 (decode_coding_iso_2022, decode_coding_emacs_mule)
11005 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11006 <char_offset, last_offset>: Declare EMACS_INT.
11007 (encode_coding_utf_8, encode_coding_utf_16)
11008 (encode_coding_emacs_mule, encode_invocation_designation)
11009 (encode_designation_at_bol, encode_coding_iso_2022)
11010 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11011 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11013 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11014 (encode_invocation_designation): Last argument P_NCHARS is now
11016 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11017 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11019 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11022 * ccl.c (Fccl_execute_on_string): Declare some variables
11025 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11027 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11029 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11031 * process.c (Fformat_network_address): Doc fix.
11033 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11035 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11037 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11039 * keyboard.c (read_char): Call Lisp function help-form-show,
11040 instead of using internal_with_output_to_temp_buffer.
11041 (Qhelp_form_show): New var.
11042 (syms_of_keyboard): Use DEFSYM macro.
11044 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11046 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11048 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11050 * process.c (Flist_processes): Remove to Lisp.
11051 (list_processes_1): Delete.
11053 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11055 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11057 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11059 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11061 Fix more problems found by GCC 4.6.0's static checks.
11063 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11065 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11067 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11069 * xdisp.c (vmessage): Mark as a printf-like function.
11071 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11073 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11075 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11076 printf-like functions.
11077 (tiff_load): Add casts to remove these marks before passing them
11078 to system-supplied API.
11080 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11082 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11083 This avoids several warnings with gcc -Wstrict-overflow.
11084 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11085 directly, rather than having caller test rule sign. This avoids
11086 some unnecessary tests.
11087 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11088 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11089 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11091 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11092 (xfont_open): Avoid unnecessary tests.
11094 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11096 * composite.h, composite.c (composition_gstring_put_cache):
11097 Use EMACS_INT, not int, for length.
11099 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11100 breaking out part of COMPOSITION_DECODE_RULE.
11101 (COMPOSITION_DECODE_RULE): Use it.
11102 * composite.c (get_composition_id): Remove unused local vars,
11103 by using the new macro.
11105 * textprop.c (set_text_properties_1): Change while to do-while,
11106 since the condition is always true at first.
11108 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11109 (interval_deletion_adjustment): Return unsigned value.
11112 * process.c (list_processes_1, create_pty, read_process_output):
11113 (exec_sentinel): Remove vars that were set but not used.
11114 (create_pty): Remove unnecessary "volatile"s.
11115 (Fnetwork_interface_info): Avoid possibility of int overflow.
11116 (read_process_output): Do adaptive read buffering even if carryover.
11117 (read_process_output): Simplify nbytes computation if buffered.
11119 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11121 * syntax.c (scan_words): Remove var that was set but not used.
11122 (update_syntax_table): Use unsigned instead of int.
11124 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11125 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11126 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11128 * print.c (print_error_message): Avoid int overflow.
11130 * font.c (font_list_entities): Redo for clarity,
11131 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11133 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11134 (font_score): Avoid potential overflow in diff calculation.
11136 * fns.c (substring_both): Remove var that is set but not used.
11137 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11139 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11141 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11142 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11143 can always succeed if overflow has undefined behavior.
11145 * search.c (boyer_moore, wordify): Remove vars set but not used.
11146 (wordify): Omit three unnecessary tests.
11148 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11149 All callers changed. This avoids the need for an unused var.
11151 * casefiddle.c (casify_region): Remove var that is set but not used.
11153 * dired.c (file_name_completion): Remove var that is set but not used.
11155 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11157 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11158 (Finsert_file_contents): Remove unnecessary code checking fd.
11160 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11161 Check for integer overflow on size calculations.
11163 * buffer.c (Fprevious_overlay_change): Remove var that is set
11166 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11167 Remove vars that are set but not used.
11168 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11169 (timer_check_2): Mark vars as initialized.
11171 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11173 * image.c (lookup_image): Remove var that is set but not used.
11174 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11176 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11177 that are set but not used.
11179 * xfns.c (make_invisible_cursor): Don't return garbage
11180 if XCreateBitmapFromData fails (Bug#8410).
11182 * xselect.c (x_get_local_selection, x_handle_property_notify):
11183 Remove vars that are set but not used.
11185 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11186 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11188 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11189 Remove var that is set but not used.
11190 (scroll_bar_windows_size): Now size_t, not int.
11191 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11192 Check for overflow.
11194 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11195 (map_tty_color) [!defined MSDOS]: Likewise.
11197 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11199 * coding.c: Remove vars that are set but not used.
11200 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11201 All callers changed.
11202 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11203 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11204 (decode_coding_charset): Remove vars that are set but not used.
11206 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11207 that is set but not used.
11209 * print.c (print_object): Remove var that is set but not used.
11211 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11212 The gnulib version avoids calling malloc in the usual case,
11213 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11214 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11215 * filelock.c (current_lock_owner): Likewise.
11216 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11217 * sysdep.c: Include allocator.h, careadlinkat.h.
11218 (emacs_no_realloc_allocator): New static constant.
11219 (emacs_readlink): New function.
11220 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11221 ../lib/careadlinkat.h.
11223 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11225 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11226 first non-nil return value).
11228 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11230 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11231 if not defined (Bug#8403).
11233 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11235 * xdisp.c (display_count_lines): Remove parameter `start',
11236 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11237 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11238 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11239 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11240 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11241 and thereabouts. All callers changed.
11242 (get_per_char_metric): Remove parameter `f', unused since
11243 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11245 2011-04-02 Jim Meyering <meyering@redhat.com>
11247 do not dereference NULL upon failed strdup
11248 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11249 (ns_get_family): Likewise.
11251 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11253 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11255 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11257 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11260 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11262 Add lexical binding.
11264 * window.c (Ftemp_output_buffer_show): New fun.
11265 (Fsave_window_excursion):
11266 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11268 * lread.c (lisp_file_lexically_bound_p): New function.
11269 (Fload): Bind Qlexical_binding.
11270 (readevalloop): Remove `evalfun' arg.
11271 Bind Qinternal_interpreter_environment.
11272 (Feval_buffer): Bind Qlexical_binding.
11273 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11275 (syms_of_lread): Declare `lexical-binding'.
11277 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11279 * keyboard.c (eval_dyn): New fun.
11280 (menu_item_eval_property): Use it.
11282 * image.c (parse_image_spec): Use Ffunctionp.
11284 * fns.c (concat, mapcar1): Accept byte-code-functions.
11286 * eval.c (Fsetq): Handle lexical vars.
11287 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11288 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11289 (FletX, Flet): Obey lexical binding.
11290 (Fcommandp): Handle closures.
11291 (Feval): New `lexical' arg.
11292 (eval_sub): New function extracted from Feval. Use it almost
11293 everywhere where Feval was used. Look up vars in lexical env.
11295 (Ffunctionp): Move from subr.el.
11296 (Ffuncall): Handle closures.
11297 (apply_lambda): Remove `eval_flags'.
11298 (funcall_lambda): Handle closures and new byte-code-functions.
11299 (Fspecial_variable_p): New function.
11300 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11301 but without exporting it to Lisp.
11303 * doc.c (Fdocumentation, store_function_docstring):
11304 * data.c (Finteractive_form): Handle closures.
11306 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11309 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11311 (exec_byte_code): New function extracted from Fbyte_code to handle new
11312 calling convention for byte-code-functions. Add new byte-codes.
11314 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11316 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11318 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11320 * xdisp.c (redisplay_internal): Fix prototype.
11322 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11324 * xdisp.c (SCROLL_LIMIT): New macro.
11325 (try_scrolling): Use it when setting scroll_limit.
11326 Limit scrolling to 100 screen lines.
11327 (redisplay_window): Even when falling back on "recentering",
11328 position point in the window according to scroll-conservatively,
11329 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11331 (try_scrolling): When point is above the window, allow searching
11332 as far as scroll_max, or one screenful, to compute vertical
11333 distance from PT to the scroll margin position. This prevents
11334 try_scrolling from unnecessarily failing when
11335 scroll-conservatively is set to a value slightly larger than the
11336 window height. Clean up the case of PT below the margin at bottom
11337 of window: scroll_max can no longer be INT_MAX. When aggressive
11338 scrolling is in use, don't let point enter the opposite scroll
11339 margin as result of the scroll.
11340 (syms_of_xdisp) <scroll-conservatively>: Document the
11341 threshold of 100 lines for never-recentering scrolling.
11343 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11345 * dispextern.h (move_it_by_lines):
11346 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11347 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11348 (message_log_check_duplicate): Remove parameters `prev_bol' and
11349 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11350 (redisplay_internal): Remove parameter `preserve_echo_area',
11351 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11353 * indent.c (Fvertical_motion):
11354 * window.c (window_scroll_pixel_based, Frecenter):
11355 Don't pass `need_y_p' to `move_it_by_lines'.
11357 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11359 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11360 steal a few bits to be more compact.
11361 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11362 Remove unneeded casts.
11364 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11366 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11368 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11369 binding" message (bug#7967).
11371 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11373 Fix more problems found by GCC 4.6.0's static checks.
11375 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11376 Remove unused local var.
11378 * editfns.c (Fmessage_box): Remove unused local var.
11380 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11381 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11382 Omit unused local vars.
11383 * window.c (shrink_windows): Omit unused local var.
11384 * menu.c (digest_single_submenu): Omit unused local var.
11385 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11386 Omit unused local var.
11388 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11389 Don't assume string length fits in int.
11390 (keyremap_step, read_key_sequence): Use size_t for sizes.
11391 (read_key_sequence): Don't check last_real_key_start redundantly.
11393 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11394 instead of alloca (Bug#8344).
11396 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11397 (Fbacktrace_frame): Don't assume nframes fits in int.
11399 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11401 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11404 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11406 * cm.c (calccost): Turn while-do into do-while, for clarity.
11408 * keyboard.c (syms_of_keyboard): Use the same style as later
11409 in this function when indexing through an array. This also
11410 works around GCC bug 48267.
11412 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11414 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11416 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11417 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11419 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11420 This avoids undefined behavior on integer overflow, and is a bit
11421 more convenient anyway since it is compared to a size_t variable.
11423 Variadic C functions now count arguments with size_t, not int.
11424 This avoids an unnecessary limitation on 64-bit machines, which
11425 caused (substring ...) to crash on large vectors (Bug#8344).
11426 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11427 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11428 All variadic functions and their callers changed accordingly.
11429 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11430 * data.c (arith_driver, float_arith_driver): Likewise.
11431 * editfns.c (general_insert_function): Likewise.
11432 * eval.c (struct backtrace.nargs, interactive_p)
11433 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11434 (funcall_lambda, mark_backtrace): Likewise.
11435 * fns.c (concat): Likewise.
11436 * frame.c (x_set_frame_parameters): Likewise.
11437 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11438 0 if not found, not -1. All callers changed.
11440 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11441 (stack_copy_size): Now size_t, not int.
11442 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11444 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11446 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11447 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11448 All callers changed.
11450 * lisp.h (multibyte_char_to_unibyte):
11451 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11452 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11453 * character.h (CHAR_TO_BYTE8):
11454 * cmds.c (internal_self_insert):
11455 * editfns.c (general_insert_function):
11456 * keymap.c (push_key_description):
11457 * search.c (Freplace_match):
11458 * xdisp.c (message_dolog, set_message_1): All callers changed.
11460 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11462 * keyboard.c (safe_run_hook_funcall): New function.
11463 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11464 don't set the hook to nil, but remove the offending function instead.
11465 (Qcommand_hook_internal): Remove, unused.
11466 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11467 Vcommand_hook_internal.
11469 * eval.c (enum run_hooks_condition): Remove.
11470 (funcall_nil, funcall_not): New functions.
11471 (run_hook_with_args): Call each function through a `funcall' argument.
11472 Remove `cond' argument, now redundant.
11473 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11474 (Frun_hook_with_args_until_failure): Adjust accordingly.
11475 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11477 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11479 * dispextern.h (string_buffer_position): Remove declaration.
11481 * print.c (strout): Remove parameter `multibyte', unused since
11482 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11484 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11485 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11486 All callers changed.
11488 * w32.c (_wsa_errlist): Use braces for struct initializers.
11490 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11491 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11492 All callers changed.
11493 (string_buffer_position): Likewise. Also, make static (it's never
11494 used outside xdisp.c).
11495 (cursor_row_p): Remove parameter `w', unused since
11496 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11497 (decode_mode_spec): Remove parameter `precision', introduced during
11498 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11499 All callers changed.
11501 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11503 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11505 2011-03-27 Anders Lindgren <andlind@gmail.com>
11507 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11508 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11509 (ns_update_auto_hide_menu_bar): New functions.
11510 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11511 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11512 ns_constrain_all_frames.
11513 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11514 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11516 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11518 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11520 2011-03-27 Glenn Morris <rgm@gnu.org>
11522 * syssignal.h: Replace RETSIGTYPE with void.
11523 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11524 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11525 Replace SIGTYPE with void everywhere.
11526 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11527 * s/template.h (SIGTYPE): Remove commented out definition.
11529 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11531 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11532 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11534 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11536 * w32.c (read_unc_volume): Use parameter `henum', instead of
11537 global variable `wget_enum_handle'.
11539 * keymap.c (describe_vector): Remove parameters `indices' and
11540 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11541 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11543 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11545 * keyboard.c (timer_check): Remove parameter `do_it_now',
11546 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11547 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11548 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11550 * keyboard.c (read_char):
11551 * w32menu.c (w32_menu_display_help):
11552 * xmenu.c (show_help_event, menu_help_callback):
11553 Adjust calls to `show_help_echo'.
11555 * gtkutil.c (xg_maybe_add_timer):
11556 * keyboard.c (readable_events):
11557 * process.c (wait_reading_process_output):
11558 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11560 * insdel.c (adjust_markers_gap_motion):
11561 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11562 (gap_left, gap_right): Don't call it.
11564 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11566 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11567 incurred during fontification.
11569 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11571 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11572 (DEFVAR_PER_BUFFER): Don't pass it.
11574 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11575 (scrolling_window): Don't pass it.
11577 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11579 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11581 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11583 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11584 of variables specific to SELinux and computation of `encoded_absname'.
11586 * image.c (XPutPixel): Remove unused variable `height'.
11588 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11590 * unexw32.c (get_section_info): Remove unused variable `section'.
11592 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11593 (system_process_attributes): Remove unused variable `sess'.
11594 (sys_read): Remove unused variable `err'.
11596 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11597 (w32_wnd_proc): Remove unused variable `isdead'.
11598 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11599 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11600 (x_create_tip_frame): Remove unused variable `tem'.
11602 * w32inevt.c (w32_console_read_socket):
11603 Remove unused variable `no_events'.
11605 * w32term.c (x_draw_composite_glyph_string_foreground):
11606 Remove unused variable `width'.
11608 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11610 * w32term.c (x_set_glyph_string_clipping):
11611 Don't pass uninitialized region to CombineRgn.
11613 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11615 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11616 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11617 (Fx_close_connection): Remove unused variable `i'.
11619 * w32font.c (w32font_draw): Return number of glyphs.
11620 (w32font_open_internal): Remove unused variable `i'.
11621 (w32font_driver): Add missing initializer.
11623 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11624 (fill_in_menu): Remove unused variable `items_added'.
11626 * w32term.c (last_mouse_press_frame): Remove static global variable.
11627 (w32_clip_to_row): Remove unused variable `f'.
11628 (x_delete_terminal): Remove unused variable `i'.
11630 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11631 (NOTHING): Remove unused static global variable.
11632 (uniscribe_check_otf): Remove unused variable `table'.
11633 (uniscribe_font_driver): Add missing initializers.
11635 2011-03-23 Julien Danjou <julien@danjou.info>
11637 * term.c (Fsuspend_tty, Fresume_tty):
11638 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11639 * window.c (temp_output_buffer_show):
11640 * insdel.c (signal_before_change):
11641 * frame.c (Fhandle_switch_frame):
11642 * fileio.c (Fdo_auto_save):
11643 * emacs.c (Fkill_emacs):
11644 * editfns.c (save_excursion_restore):
11645 * cmds.c (internal_self_insert):
11646 * callint.c (Fcall_interactively):
11647 * buffer.c (Fkill_all_local_variables):
11648 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11650 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11651 unconditionally since it does the check itself.
11653 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11655 Fix more problems found by GCC 4.5.2's static checks.
11657 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11658 the first time through the loop, since we know p0 < p1 then.
11659 This also avoids a gcc -Wstrict-overflow warning.
11661 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11662 leading to a memory leak, possible in functions like
11663 load_charset_map_from_file that can allocate an unbounded number
11664 of objects (Bug#8318).
11666 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11667 that could (at least in theory) be that large.
11669 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11670 This is less likely to overflow, and avoids undefined behavior if
11671 overflow does occur. All callers changed. Use strtoul to scan
11672 for the unsigned long integer.
11673 (pint2hrstr): Simplify and tune code slightly.
11674 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11676 * scroll.c (do_scrolling): Work around GCC bug 48228.
11677 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11679 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11680 This also avoids a warning with gcc -Wstrict-overflow.
11681 (validate_x_resource_name): Simplify count usage.
11682 This also avoids a warning with gcc -Wstrict-overflow.
11684 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11687 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11689 * process.c (Fmake_network_process): Use socklen_t, not int,
11690 where POSIX says socklen_t is required in portable programs.
11691 This fixes a porting bug on hosts like 64-bit HP-UX, where
11692 socklen_t is wider than int (Bug#8277).
11693 (Fmake_network_process, server_accept_connection):
11694 (wait_reading_process_output, read_process_output):
11697 * process.c: Rename or move locals to avoid shadowing.
11698 (list_processes_1, Fmake_network_process):
11699 (read_process_output_error_handler, exec_sentinel_error_handler):
11700 Rename or move locals.
11701 (Fmake_network_process): Define label "retry_connect" only if needed.
11702 (Fnetwork_interface_info): Fix pointer signedness.
11703 (process_send_signal): Add cast to avoid pointer signedness problem.
11704 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11705 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11707 Make tparam.h and terminfo.c consistent.
11708 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11709 Include tparam.h instead, since it declares them.
11710 * cm.h (PC): Remove extern decl; tparam.h now does this.
11711 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11712 * terminfo.c: Include tparam.h, to check interfaces.
11713 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11714 (tparam): Adjust signature to match interface in tparam.h;
11715 this removes some undefined behavior. Check that outstring and len
11716 are zero, which they always are with Emacs.
11717 * tparam.h (PC, BC, UP): New extern decls.
11719 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11720 (xftfont_open): Rename locals to avoid shadowing.
11722 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11723 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11724 (OTF_TAG_SYM): Omit macro if not needed.
11725 (ftfont_list): Remove unused local.
11726 (get_adstyle_property, ftfont_pattern_entity):
11727 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11728 Rename locals to avoid shadowing.
11730 * xfont.c (xfont_list_family): Mark var as initialized.
11732 * xml.c (make_dom): Now static.
11734 * composite.c (composition_compute_stop_pos): Rename local to
11736 (composition_reseat_it): Remove unused locals.
11737 (find_automatic_composition, composition_adjust_point): Likewise.
11738 (composition_update_it): Mark var as initialized.
11739 (find_automatic_composition): Mark vars as initialized,
11740 with a FIXME (Bug#8290).
11742 character.h: Rename locals to avoid shadowing.
11743 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11744 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11745 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11746 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11747 to avoid shadowing.
11749 * textprop.c (property_change_between_p): Remove; unused.
11751 * intervals.c (interval_start_pos): Now static.
11753 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11755 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11756 Rename locals to avoid shadowing.
11758 * sound.c (wav_play, au_play, Fplay_sound_internal):
11759 Fix pointer signedness.
11760 (alsa_choose_format): Remove unused local var.
11761 (wav_play): Initialize a variable to 0, to prevent undefined
11762 behavior (Bug#8278).
11764 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11766 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11768 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11769 clobbering (Bug#8298).
11770 * sysdep.c (sys_subshell): Likewise.
11771 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11773 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11774 This should get cleaned up, so that child_setup has the
11775 same signature on all platforms.
11777 * callproc.c (call_process_cleanup): Now static.
11778 (relocate_fd): Rename locals to avoid shadowing.
11780 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11782 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11783 not to be necessary, and produces flickering.
11785 2011-03-20 Glenn Morris <rgm@gnu.org>
11787 * config.in: Remove file.
11789 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11791 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11792 are now in src/globals.h.
11793 (syms_of_minibuf): Remove spurious & from previous change.
11795 2011-03-20 Leo Liu <sdl.web@gmail.com>
11797 * minibuf.c (completing-read-function): New variable.
11798 (completing-read-default): Rename from completing-read.
11799 (completing-read): Call completing-read-function.
11801 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11803 * xfaces.c (Fx_load_color_file):
11804 Read color file from absolute filename (bug#8250).
11806 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11808 * makefile.w32-in: Update dependencies.
11810 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11812 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11814 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11816 Fix more problems found by GCC 4.5.2's static checks.
11818 * process.c (make_serial_process_unwind, send_process_trap):
11819 (sigchld_handler): Now static.
11821 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11822 That way, the code declares only the vars that it needs.
11823 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11824 * s/cygwin.h (PTY_ITERATION): Likewise.
11825 * s/darwin.h (PTY_ITERATION): Likewise.
11826 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11828 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11829 * process.c (allocate_pty): Don't declare stb unless it's needed.
11831 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11832 (CONSTANTLIM): Remove; unused.
11833 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11834 Define only if needed.
11836 * unexelf.c (unexec): Name an expression,
11837 to avoid gcc -Wbad-function-cast warning.
11838 Use a different way to cause a compilation error if anyone uses
11839 n rather than nn, a way that does not involve shadowing.
11840 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11842 * deps.mk (unexalpha.o): Remove; unused.
11844 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11845 * unexec.h: New file.
11846 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11847 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11848 Depend on unexec.h.
11849 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11850 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11851 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11852 Change as necessary to match prototype in unexec.h.
11854 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11856 (back_comment, skip_chars): Mark vars as initialized.
11858 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11859 Rename locals to avoid shadowing.
11861 * lread.c (read1): Rewrite so as not to use empty "else".
11862 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11864 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11866 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11867 warning when compiling print.c.
11869 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11870 instead of using an uninitialized var.
11871 (font_sort_entities): Mark var as initialized.
11873 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11875 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11876 pointers to constants.
11877 (font_parse_fcname): Remove unused vars.
11878 (font_delete_unmatched): Now static.
11879 (font_get_spec): Remove; unused.
11880 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11881 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11882 Rename or move locals to avoid shadowing.
11884 * fns.c (require_nesting_list, require_unwind): Now static.
11885 (Ffillarray): Rename locals to avoid shadowing.
11887 * floatfns.c (domain_error2): Define only if needed.
11888 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11890 * alloc.c (mark_backtrace): Move decl from here ...
11891 * lisp.h: ... to here, so that it can be checked.
11893 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11894 (Fdefvar): Rewrite so as not to use empty "else".
11895 (lisp_indirect_variable): Name an expression,
11896 to avoid gcc -Wbad-function-cast warning.
11897 (Fdefvar): Rename locals to avoid shadowing.
11899 * callint.c (quotify_arg, quotify_args): Now static.
11900 (Fcall_interactively): Rename locals to avoid shadowing.
11901 Use const pointer when appropriate.
11903 * lisp.h (get_system_name, get_operating_system_release):
11904 Move decls here, to check interfaces.
11905 * process.c (get_operating_system_release): Move decl to lisp.h.
11906 * xrdb.c (get_system_name): Likewise.
11907 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11908 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11909 some of which prompt warnings from gcc -Wbad-function-cast.
11910 (Fformat_time_string, Fencode_time, Finsert_char):
11911 (Ftranslate_region_internal, Fformat):
11912 Rename or remove local vars to avoid shadowing.
11913 (Ftranslate_region_internal): Mark var as initialized.
11915 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11918 * lisp.h (eassert): Check that the argument compiles, even if
11919 ENABLE_CHECKING is not defined.
11921 * data.c (Findirect_variable): Name an expression, to avoid
11922 gcc -Wbad-function-cast warning.
11923 (default_value, arithcompare, arith_driver, arith_error): Now static.
11924 (store_symval_forwarding): Rename local to avoid shadowing.
11925 (Fmake_variable_buffer_local, Fmake_local_variable):
11926 Mark variables as initialized.
11927 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11929 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11930 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11931 Rename locals to avoid shadowing.
11932 (mark_stack): Move local variables into the #ifdef region where
11934 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11935 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11937 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11938 (GC_STRING_CHARS): Remove; not used.
11939 (Fmemory_limit): Cast sbrk's returned value to char *.
11941 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11942 avoids undefined behavior in theory.
11944 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11946 Use functions, not macros, for up- and down-casing (Bug#8254).
11947 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11948 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11949 to use the following functions instead of these macros.
11950 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11951 EMACS_INT, since callers assume the returned value fits in int.
11952 (upcase1): Likewise, for UPCASE_TABLE.
11953 (uppercasep, lowercasep, upcase): New static inline functions.
11954 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11955 the race-condition problem in the old DOWNCASE.
11957 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11958 Rename locals to avoid shadowing.
11959 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11960 (regex_compile, re_search_2, re_match_2_internal):
11961 Remove unused local vars.
11962 (FREE_VAR): Rewrite so as not to use empty "else",
11963 which gcc can warn about.
11964 (regex_compile, re_match_2_internal): Mark locals as initialized.
11965 (RETALLOC_IF): Define only if needed.
11966 (WORDCHAR_P): Likewise. This one is never needed, but is used
11967 only in a comment talking about a compiler bug, so put inside
11968 the #if 0 of that comment.
11969 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11970 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11973 * search.c (boyer_moore): Rename locals to avoid shadowing.
11974 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11975 (PREV_CHAR_BOUNDARY): Likewise.
11977 * search.c (simple_search): Remove unused var.
11979 * dired.c (compile_pattern): Move decl from here ...
11980 * lisp.h: ... to here, so that it can be checked.
11981 (struct re_registers): New forward decl.
11983 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11985 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11987 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11988 Rename locals to avoid shadowing.
11989 (Fvertical_motion): Mark locals as initialized.
11991 * casefiddle.c (casify_object, casify_region): Now static.
11992 (casify_region): Mark local as initialized.
11994 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11996 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11997 New macros, so that the caller can use some names other than
11998 gcpro1, gcpro2, etc.
11999 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12001 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12002 argument, for consistency with GCPRO2_VAR, etc: it is now the
12003 prefix of the variable, not the variable itself. All uses
12005 * dired.c (directory_files_internal, file_name_completion):
12006 Rename locals to avoid shadowing.
12008 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12009 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12010 dired.c's scmp function, had undefined behavior.
12011 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12012 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12013 * buffer.h: ... to here, because these macros use current_buffer,
12014 and the new implementation with inline functions needs to have
12015 current_buffer in scope now, rather than later when the macros
12017 (downcase, upcase1): New static inline functions.
12018 (DOWNCASE, UPCASE1): Reimplement using these functions.
12019 This avoids undefined behavior in expressions like
12020 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12021 from race conditions in accessing the global variables
12022 case_temp1 and case_temp2.
12023 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12024 * lisp.h (case_temp1, case_temp2): Remove their decls.
12025 * character.h (ASCII_CHAR_P): Move from here ...
12026 * lisp.h: ... to here, so that the inline functions mentioned
12027 above can use them.
12029 * dired.c (directory_files_internal_unwind): Now static.
12031 * fileio.c (file_name_as_directory, directory_file_name):
12032 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12034 (file_name_as_directory): Use const pointers when appropriate.
12035 (Fexpand_file_name): Likewise. In particular, newdir might
12036 point at constant storage, so make it a const pointer.
12037 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12038 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12040 (Fset_file_times, Finsert_file_contents, auto_save_error):
12041 Rename locals to avoid shadowing.
12043 * minibuf.c (choose_minibuf_frame_1): Now static.
12044 (Ftry_completion, Fall_completions): Rename or remove locals
12045 to avoid shadowing.
12047 * marker.c (bytepos_to_charpos): Remove; unused.
12049 * lisp.h (verify_bytepos, count_markers): New decls,
12050 so that gcc does not warn that these functions aren't declared.
12052 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12053 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12054 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12055 (copy_text): Remove unused local var.
12057 * filelock.c (within_one_second): Now static.
12058 (lock_file_1): Rename local to avoid shadowing.
12060 * buffer.c (fix_overlays_before): Mark locals as initialized.
12061 (fix_start_end_in_overlays): Likewise. This function should be
12062 simplified by using pointers-to-pointers, but that's a different
12064 (switch_to_buffer_1): Now static.
12065 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12066 (report_overlay_modification): Rename locals to avoid shadowing.
12068 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12069 Fix pointer signedness issue.
12070 (sys_subshell): Mark local as volatile if checking for lint,
12071 to suppress a gcc -Wclobbered warning that does not seem to be right.
12072 (MAXPATHLEN): Define only if needed.
12074 * process.c (serial_open, serial_configure): Move decls from here ...
12075 * systty.h: ... to here, so that they can be checked.
12077 * fns.c (get_random, seed_random): Move extern decls from here ...
12078 * lisp.h: ... to here, so that they can be checked.
12080 * sysdep.c (reset_io): Now static.
12081 (wait_for_termination_signal): Remove; unused.
12083 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12084 (copy_keymap_item, append_key, push_text_char_description):
12086 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12087 (DENSE_TABLE_SIZE): Remove; unused.
12088 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12089 (describe_map_tree):
12090 Rename locals to avoid shadowing.
12092 * keyboard.c: Declare functions static if they are not used elsewhere.
12093 (echo_char, echo_dash, cmd_error, top_level_2):
12094 (poll_for_input, handle_async_input): Now static.
12095 (read_char, kbd_buffer_get_event, make_lispy_position):
12096 (make_lispy_event, make_lispy_movement, apply_modifiers):
12097 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12098 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12099 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12100 (read_key_sequence, read_char): Mark locals as initialized.
12101 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12103 * keyboard.h (make_ctrl_char): New decl.
12104 (mark_kboards): Move decl here ...
12105 * alloc.c (mark_kboards): ... from here.
12107 * lisp.h (force_auto_save_soon): New decl.
12109 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12110 (DEFINE_DUMMY_FUNCTION): New macro.
12111 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12113 (main): Add casts to avoid warnings
12114 if GCC considers string literals to be constants.
12116 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12118 * dbusbind.c: Pointer signedness fixes.
12119 (xd_signature, xd_append_arg, xd_initialize):
12120 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12121 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12122 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12123 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12125 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12126 if GCC considers string literals to be constants.
12127 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12129 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12131 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12132 (print_preprocess, print_object): New macro to fix last change.
12134 * print.c (print_preprocess): Don't forget font objects.
12136 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12138 * emacs.c (USAGE3): Doc fixes.
12140 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12142 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12145 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12147 * lisp.h (VWindow_system, Qfile_name_history):
12148 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12149 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12150 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12152 * w32select.c: Don't #include "keyboard.h".
12153 (run_protected): Add extern declaration for waiting_for_input.
12155 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12156 * w32console.c (detect_input_pending, read_input_pending)
12157 (encode_terminal_code):
12158 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12159 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12160 (w32_system_caret_y, Qfile_name_history):
12161 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12162 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12163 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12164 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12165 * w32proc.c (Qlocal, report_file_error):
12166 * w32term.c (Vwindow_system, updating_frame):
12167 * w32uniscribe.c (initialized, uniscribe_font_driver):
12168 Remove unneeded extern declarations.
12170 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12172 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12174 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12176 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12177 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12178 These macros can no longer be used for assignment.
12180 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12181 Assign struct members directly, instead of using BUF_BEGV etc.
12182 (record_buffer_markers, fetch_buffer_markers): New functions for
12183 recording and fetching special buffer markers.
12184 (set_buffer_internal_1, set_buffer_temp): Use them.
12186 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12188 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12190 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12191 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12193 * xdisp.c (hscroll_window_tree):
12194 (reconsider_clip_changes): Use PT instead of BUF_PT.
12196 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12198 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12199 $(EMACS_ROOT)/lib/intprops.h.
12201 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12203 Fix more problems found by GCC 4.5.2's static checks.
12205 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12206 to unsigned char * to avoid compiler diagnostic.
12207 (xg_free_frame_widgets): Make it clear that a local variable is
12208 needed only if USE_GTK_TOOLTIP.
12209 (gdk_window_get_screen): Make it clear that this macro is needed
12210 only if USE_GTK_TOOLTIP.
12211 (int_gtk_range_get_value): New function, which avoids a diagnostic
12212 from gcc -Wbad-function-cast.
12213 (xg_set_toolkit_scroll_bar_thumb): Use it.
12214 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12215 diagnostic from gcc -Wbad-function-cast.
12216 (get_utf8_string, xg_get_file_with_chooser):
12217 Rename locals to avoid shadowing.
12218 (create_dialog): Move locals to avoid shadowing.
12220 * xgselect.c (xg_select): Remove unused var.
12222 * image.c (four_corners_best): Mark locals as initialized.
12223 (gif_load): Initialize transparent_p to zero (Bug#8238).
12224 Mark another local as initialized.
12225 (my_png_error, my_error_exit): Mark with NO_RETURN.
12227 * image.c (clear_image_cache): Now static.
12228 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12229 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12230 (x_edge_detection): Remove unnecessary cast that
12231 gcc -Wbad-function-cast diagnoses.
12232 (gif_load): Fix pointer signedness.
12233 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12234 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12236 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12238 Improve quality of tests for time stamp overflow.
12239 For example, without this patch (encode-time 0 0 0 1 1
12240 1152921504606846976) returns the obviously-bogus value (-948597
12241 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12242 reports time overflow. See
12243 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12244 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12245 * editfns.c: Include limits.h and intprops.h.
12246 (TIME_T_MIN, TIME_T_MAX): New macros.
12247 (time_overflow): Move earlier, to before first use.
12248 (hi_time, lo_time): New functions, for an accurate test for
12249 out-of-range times.
12250 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12251 (Fget_internal_run_time): Don't assume time_t fits in int.
12252 (make_time): Use list2 instead of Fcons twice.
12253 (Fdecode_time): More accurate test for out-of-range times.
12254 (check_tm_member): New function.
12255 (Fencode_time): Use it, to test for out-of-range times.
12256 (lisp_time_argument): Don't rely on undefined left-shift and
12257 right-shift behavior when checking for time stamp overflow.
12259 * editfns.c (time_overflow): New function, refactoring common code.
12260 (Fformat_time_string, Fdecode_time, Fencode_time):
12261 (Fcurrent_time_string): Use it.
12263 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12264 * dired.c (make_time): Move to ...
12265 * editfns.c (make_time): ... here.
12266 * systime.h: Note the move.
12268 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12270 * fringe.c (update_window_fringes): Remove unused variables.
12272 * unexmacosx.c (copy_data_segment): Also copy __got section.
12275 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12277 * termcap.c [MSDOS]: Include "msdos.h".
12278 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12279 Constify `char *' arguments and their references according to
12280 prototypes in tparam.h.
12282 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12284 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12285 Adapt all references accordingly.
12287 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12289 2011-03-11 Tom Tromey <tromey@redhat.com>
12291 * buffer.c (syms_of_buffer): Remove obsolete comment.
12293 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12295 * termhooks.h (encode_terminal_code): Declare prototype.
12297 * msdos.c (encode_terminal_code): Don't declare prototype.
12299 * term.c (encode_terminal_code): Now external again, used by
12300 w32console.c and msdos.c.
12302 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12303 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12305 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12307 Fix some minor problems found by GCC 4.5.2's static checks.
12309 * fringe.c (update_window_fringes): Mark locals as initialized
12311 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12313 * alloc.c (mark_fringe_data): Move decl from here ...
12314 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12315 to check its interface.
12316 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12318 * fontset.c (free_realized_fontset): Now static.
12319 (Fset_fontset_font): Rename local to avoid shadowing.
12320 (fontset_font): Mark local as initialized.
12321 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12323 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12325 * xselect.c (x_disown_buffer_selections): Remove; not used.
12326 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12327 (x_own_selection, Fx_disown_selection_internal): Rename locals
12328 to avoid shadowing.
12329 (x_handle_dnd_message): Remove local to avoid shadowing.
12331 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12332 so that the caller can use some name other than gcpro1.
12333 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12334 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12335 (Fx_backspace_delete_keys_p):
12336 Use them to avoid shadowing, and rename vars to avoid shadowing.
12337 (x_decode_color, x_set_name, x_window): Now static.
12338 (Fx_create_frame): Add braces to silence GCC warning.
12339 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12340 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12341 Remove unused locals.
12342 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12343 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12344 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12347 * xterm.h (x_mouse_leave): New decl.
12349 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12350 Remove unused functions.
12351 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12352 (x_calc_absolute_position): Now static.
12353 (XTread_socket): Don't define label "out" unless it's used.
12354 Don't declare local "event" unless it's used.
12355 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12356 unless they are used.
12357 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12358 (x_fatal_error_signal): Remove; not used.
12359 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12360 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12361 (x_error_catcher, x_connection_closed, x_error_handler):
12362 (x_error_quitter, xembed_send_message, x_iconify_frame):
12363 (my_log_handler): Rename locals to avoid shadowing.
12364 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12365 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12367 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12368 Rename or move locals to avoid shadowing.
12369 (tty_defined_color, merge_face_heights): Now static.
12370 (free_realized_faces_for_fontset): Remove; not used.
12371 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12372 does not deduce is never used uninitialized.
12373 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12374 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12376 * terminal.c (store_terminal_param): Now static.
12378 * xmenu.c (menu_highlight_callback): Now static.
12379 (set_frame_menubar): Remove unused local.
12380 (xmenu_show): Rename parameter to avoid shadowing.
12381 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12382 since they might point to immutable storage.
12383 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12384 since it's unused otherwise.
12386 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12387 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12388 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12389 avoids a gcc -Wuninitialized diagnostic.
12390 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12391 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12392 does not deduce are never used uninitialized.
12394 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12396 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12397 * window.c (window_loop, size_window):
12398 (run_window_configuration_change_hook, enlarge_window): Likewise.
12400 * window.c (display_buffer): Now static.
12401 (size_window): Mark variables that gcc -Wuninitialized
12402 does not deduce are never used uninitialized.
12403 * window.h (check_all_windows): New decl, to forestall
12404 gcc -Wmissing-prototypes diagnostic.
12405 * dispextern.h (bidi_dump_cached_states): Likewise.
12407 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12409 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12410 Include <limits.h>.
12411 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12412 and to avoid gcc -Wuninitialized warning.
12413 (load_charset_map): Mark variables that gcc -Wuninitialized
12414 does not deduce are never used uninitialized.
12415 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12417 * coding.c (coding_set_source, coding_set_destination):
12418 Use "else { /* comment */ }" rather than "else /* comment */;"
12419 for clarity, and to avoid gcc -Wempty-body warning.
12420 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12421 a block, when the outer 'i' will do.
12422 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12423 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12424 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12425 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12426 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12427 Rename locals to avoid shadowing.
12428 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12429 * coding.c (emacs_mule_char, encode_invocation_designation):
12430 Now static, since they're not used elsewhere.
12431 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12432 (decode_coding_object, encode_coding_object, detect_coding_system):
12433 (decode_coding_emacs_mule): Mark variables that gcc
12434 -Wuninitialized does not deduce are never used uninitialized.
12435 (detect_coding_iso_2022): Initialize a local variable that might
12436 be used uninitialized. Leave a FIXME because it's not clear that
12437 this initialization is needed. (Bug#8211)
12438 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12439 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12440 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12441 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12442 Remove unused macros.
12444 * category.c (hash_get_category_set): Remove unused local var.
12445 (copy_category_table): Now static, since it's not used elsewhere.
12446 * character.c (string_count_byte8): Likewise.
12448 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12449 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12451 * chartab.c (copy_sub_char_table): Now static, since it's not used
12453 (sub_char_table_ref_and_range, char_table_ref_and_range):
12454 Rename locals to avoid shadowing.
12455 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12457 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12458 (BIDI_BOB): Remove unused macro.
12460 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12461 deduce are never used uninitialized.
12462 * term.c (encode_terminal_code): Likewise.
12464 * term.c (encode_terminal_code): Now static. Remove unused local.
12466 * tparam.h: New file.
12467 * term.c, tparam.h: Include it.
12468 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12469 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12470 Move these decls to tparam.h, and make them agree with what
12471 is actually in tparam.c. The previous trick of using incompatible
12472 decls in different modules does not conform to the C standard.
12473 All callers of tparam changed to use tparam's actual API.
12474 * tparam.c (tparam1, tparam, tgoto):
12475 Use const pointers where appropriate.
12477 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12478 * cm.h (struct cm): Likewise.
12479 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12480 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12481 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12482 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12483 (turn_on_face, init_tty): Likewise.
12484 * termchar.h (struct tty_display_info): Likewise.
12486 * term.c (term_mouse_position): Rename local to avoid shadowing.
12488 * alloc.c (mark_ttys): Move decl from here ...
12489 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12491 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12493 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12495 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12497 * search.c (compile_pattern_1): Remove argument regp, unused since
12498 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12499 (compile_pattern): Don't pass it.
12501 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12503 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12504 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12506 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12508 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12510 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12511 gdk_window_get_screen, gdk_window_get_geometry,
12512 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12513 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12514 (xg_get_pixbuf_from_pixmap): New function.
12515 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12516 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12517 Call xg_get_pixbuf_from_pixmap instead of
12518 gdk_pixbuf_get_from_drawable.
12519 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12520 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12521 (xg_check_special_colors): Use GtkStyleContext and its functions
12523 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12524 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12525 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12526 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12527 Call gtk_widget_get_preferred_size.
12528 (xg_frame_resized): gdk_window_get_geometry only takes 5
12530 (xg_win_to_widget, xg_event_is_for_menubar):
12531 Call gdk_x11_window_lookup_for_display.
12532 (xg_set_widget_bg): New function.
12533 (delete_cb): New function.
12534 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12535 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12536 (xg_set_background_color): Call xg_set_widget_bg.
12537 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12538 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12539 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12540 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12542 (update_frame_tool_bar): Call gtk_widget_hide.
12543 (xg_initialize): Use GDK_KEY_g.
12545 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12547 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12549 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12550 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12551 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12553 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12555 * w32xfns.c (select_palette): Check success of RealizePalette against
12556 GDI_ERROR, not zero.
12558 See ChangeLog.11 for earlier changes.
12560 ;; Local Variables:
12564 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12566 This file is part of GNU Emacs.
12568 GNU Emacs is free software: you can redistribute it and/or modify
12569 it under the terms of the GNU General Public License as published by
12570 the Free Software Foundation, either version 3 of the License, or
12571 (at your option) any later version.
12573 GNU Emacs is distributed in the hope that it will be useful,
12574 but WITHOUT ANY WARRANTY; without even the implied warranty of
12575 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12576 GNU General Public License for more details.
12578 You should have received a copy of the GNU General Public License
12579 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.