1 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3 sprintf-related integer and memory overflow issues.
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
71 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
72 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
73 it as a large positive number.
74 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
75 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
77 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
78 in case result does not fit in int.
80 * print.c (float_to_string): Detect width overflow more reliably.
81 (print_object): Make sprintf buffer a bit bigger, to avoid potential
82 buffer overrun. Don't assume list length fits in 'int'. Treat
83 print length of 0 as 0, not as infinity; to be consistent with other
84 uses of print length in this function. Don't overflow print length
85 index. Don't assume hash table size fits in 'long', or that
86 vectorlike size fits in 'unsigned long'.
88 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
90 Integer and memory overflow issues (Bug#9196).
92 * doc.c (get_doc_string): Rework so that
93 get_doc_string_buffer_size is the actual buffer size, rather than
94 being 1 less than the actual buffer size; this makes xpalloc more
97 * image.c (x_allocate_bitmap_record, cache_image):
98 * xselect.c (Fx_register_dnd_atom):
99 Simplify previous changes by using xpalloc.
101 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
102 since either will do and ptrdiff_t is convenient with xpalloc.
104 * charset.c (charset_table_size)
105 (struct charset_sort_data.priority): Now ptrdiff_t.
106 (charset_compare): Don't overflow if priorities differ greatly.
107 (Fsort_charsets): Don't assume list length fits in int.
108 Check for size-calculation overflow when allocating sort data.
109 (syms_of_charset): Allocate an initial charset table that is
110 just under 64 KiB, to avoid problems with glibc malloc and mmap.
112 * cmds.c (internal_self_insert): Check for size-calculation overflow.
114 * composite.h (struct composition.glyph_len): Now int, not unsigned.
115 The actual value is always <= INT_MAX, and leaving it unsigned made
116 overflow checking harder.
118 * dispextern.h (struct glyph_matrix.rows_allocated)
119 (struct face_cache.size): Now ptrdiff_t, for convenience in use
120 with xpalloc. The values are still always <= INT_MAX.
122 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
124 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
125 (SAFE_NALLOCA): New macro.
127 * region-cache.c (struct boundary.pos, find_cache_boundary)
128 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
129 (set_cache_region, invalidate_region_cache)
130 (revalidate_region_cache, know_region_cache, region_cache_forward)
131 (region_cache_backward, pp_cache):
132 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
133 so that ptrdiff_t * can be passed to xpalloc.
134 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
135 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
136 (pp_cache): Don't assume cache_len fits in int.
137 * region-cache.h: Adjust extern decls to match.
139 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
140 EMACS_INT, since either will do, for xpalloc.
142 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
143 (xnmalloc, xnrealloc, xpalloc): New functions.
145 * bidi.c (bidi_shelve_header_size): New constant.
146 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
147 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
149 * bidi.c (bidi_cache_shrink):
150 * buffer.c (overlays_at, overlays_in, record_overlay_string)
152 Don't update size of array until after memory allocation succeeds,
153 because xmalloc/xrealloc may not return.
154 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
155 now that we have proper integer overflow checking.
156 (record_overlay_string, overlay_strings): Catch overflows when
157 calculating size of overlay_str_buf.
159 * callproc.c (Fcall_process): Check for size overflow when
160 calculating size of args2.
161 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
162 Normally we prefer signed values, but sticking with ptrdiff_t would
163 require adding more-complicated checks.
165 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
166 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
167 Redo buffer-overflow calculations to avoid integer overflow.
168 Add a FIXME comment where memory seems to be over-allocated.
170 * character.c (Fstring): Check for size-calculation overflow.
172 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
173 unnecessary integer overflow. Check for size overflow.
174 (encode_coding_object): Don't update size until xmalloc succeeds.
176 * composite.c (get_composition_id): Check for overflow in glyph
179 Integer and memory overflow fixes for display code.
180 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
181 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
182 (scrolling_window): Check for overflow in size calculations.
183 (line_draw_cost, realloc_glyph_pool, add_row_entry):
184 Don't assume glyph table len fits in int.
185 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
186 (row_table_size): Now ptrdiff_t, not int.
187 (scrolling_window): Avoid overflow in size calculations.
188 Don't update size until allocation succeeds.
189 * fns.c (concat): Check for overflow in size calculations.
190 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
191 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
192 (NEXT_ALMOST_PRIME_LIMIT): New constant.
194 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
195 (get_doc_string): Check for size calculation overflow.
196 Don't update size until allocation succeeds.
197 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
198 EMACS_INT, where ptrdiff_t will do.
199 (Fsubstitute_command_keys): Check for string overflow.
201 * editfns.c (set_time_zone_rule): Don't assume environment length
203 (message_length): Now ptrdiff_t, not int.
204 (Fmessage_box): Don't update size until allocation succeeds.
205 Don't assume message length fits in int.
206 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
208 * emacs.c (main): Do not reallocate argv, since there is a null at
209 the end that can be overwritten, and this way there's no need to
210 worry about size-calculation overflow.
211 (sort_args): Check for size-calculation overflow.
213 * eval.c (init_eval_once, grow_specpdl): Don't update size until
215 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
217 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
218 (x_set_scroll_bar_width, x_figure_window_size):
219 Check for integer overflow.
220 (x_set_alpha): Do not assume XINT fits in int.
222 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
223 This is for the members text_lines, text_cols, total_lines, total_cols,
224 where the system imposes an 'int' limit.
226 * fringe.c (Fdefine_fringe_bitmap):
227 Don't update size until alloc works.
229 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
230 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
232 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
233 Check for size-calculation overflow.
234 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
235 do, as we prefer signed integers.
236 (id_to_widget.max_size, id_to_widget.used)
237 (xg_store_widget_in_map, xg_remove_widget_from_map)
238 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
239 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
240 Use and return ptrdiff_t, not int.
241 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
242 * gtkutil.h: Change prototypes to match the above.
244 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
245 are duplicate now that they've been promoted to lisp.h.
246 (x_allocate_bitmap_record, x_alloc_image_color)
247 (make_image_cache, cache_image, xpm_load):
248 Don't update size until alloc is done.
249 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
251 Check for size calculation overflow.
252 (ct_colors_allocated_max): New constant.
253 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
256 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
257 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
258 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
259 Use ptrdiff_t, not int, to count maps.
260 (read_char_minibuf_menu_prompt): Check for overflow in size
261 calculations. Don't update size until allocation succeeds. Redo
262 calculations to avoid overflow.
263 * keyboard.h: Change prototypes to match the above.
265 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
267 (current_minor_maps): Check for size calculation overflow.
268 * keymap.h: Change prototypes to match the above.
270 * lread.c (read1, init_obarray): Don't update size until alloc done.
272 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
273 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
275 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
276 Now ptrdiff_t, not int.
277 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
278 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
280 * process.c (Fnetwork_interface_list): Check for overflow
283 * region-cache.c (move_cache_gap): Check for size calculation overflow.
285 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
286 overflow. Don't bother calling xmalloc when xrealloc will do.
288 * search.c (Freplace_match): Check for size calculation overflow.
289 (Fset_match_data): Don't assume list lengths fit in 'int'.
291 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
292 for command line length. Do not attempt to address one before the
293 beginning of an array, as that's not portable.
295 * term.c (max_frame_lines): Remove; unused.
296 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
298 (encode_terminal_code, calculate_costs): Check for size
299 calculation overflow.
300 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
301 table lengths and related sizes. Don't update size until alloc
302 done. Redo calculations to avoid overflow.
303 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
305 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
306 subtracting pointers.
307 (gobble_line): Check for overflow more carefully. Don't update size
310 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
311 Don't update size until alloc done.
312 Redo size calculations to avoid overflow.
313 Check for size calculation overflow.
314 (main) [DEBUG]: Fix typo in invoking tparam1.
316 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
317 Use ptrdiff_t, not int, for sizes.
318 (store_mode_line_noprop_char): Don't update size until alloc done.
320 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
321 Use ptrdiff_t, not int, for sizes.
322 (Finternal_make_lisp_face, cache_face):
323 Check for size calculation overflow.
324 (cache_face): Treat size calculation overflows as if they were
325 memory exhaustion (the usual treatment), rather than aborting.
327 * xfns.c (x_encode_text, x_set_name_internal)
328 (Fx_change_window_property): Use ptrdiff_t, not int, to count
329 sizes, since they can exceed INT_MAX in size. Check for size
330 calculation overflow.
332 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
333 (xg_select): Check for size calculation overflow.
334 Don't update size until alloc done.
336 * xrdb.c (get_environ_db): Don't assume path length fits in int,
337 as sprintf is limited to int lengths.
339 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
340 (X_LONG_MIN): New macros.
341 Use them to make the following changes clearer.
342 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
343 This change doesn't affect the value now, but it may help remind
344 future maintainers not to raise the value too much later.
345 (SELECTION_QUANTUM): Remove, replacing with ...
346 (selection_quantum): ... new function, which avoids overflow.
348 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
349 assumption that selection length fits in 'int'.
350 (x_reply_selection_request, x_handle_selection_request)
351 (x_get_window_property, receive_incremental_selection)
352 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
353 (lisp_data_to_selection_data, clean_local_selection_data):
354 Use ptrdiff_t, not int, to record length of selection.
355 (x_reply_selection_request, x_get_window_property)
356 (receive_incremental_selection, x_property_data_to_lisp):
357 Redo calculations to avoid overflow.
358 (x_reply_selection_request): When sending hint, ceiling it at
359 X_LONG_MAX rather than relying on wraparound overflow to send
361 (x_get_window_property, receive_incremental_selection)
362 (lisp_data_to_selection_data, x_property_data_to_lisp):
363 Check for size-calculation overflow.
364 (x_get_window_property, receive_incremental_selection)
365 (lisp_data_to_selection_data, Fx_register_dnd_atom):
366 Don't store size until memory allocation succeeds.
367 (x_get_window_property): Plug memory leak on memory exhaustion.
368 Don't double-block input; malloc is safe here. Don't assume 2**34
369 - 4 fits in unsigned long. Add an xassert to check
370 XGetWindowProperty overflow. Be more careful about overflow
371 calculations, and distinguish size from memory overflow better.
372 (receive_incremental_selection): When tracing, don't assume
373 unsigned int is less than INT_MAX.
374 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
375 harmful) conversions of unsigned short to int.
376 (lisp_data_to_selection_data): Don't assume that integers
377 in the range -65535 through -1 fit in an X unsigned short.
378 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
379 result parameters unless successful. Rely on cons_to_unsigned
380 to report problems with elements; the old code wasn't right anyway.
381 (x_check_property_data): Check for int overflow; we cannot use
382 a wider type due to X limits.
383 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
385 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
387 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
388 (x_term_init): Check for size calculation overflow.
389 (x_color_cells): Don't store size until memory allocation succeeds.
390 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
391 Don't assume alloca size is less than MAX_ALLOCA.
392 (x_term_init): Don't assume length fits in int (sprintf is limited
395 Use ptrdiff_t for composition IDs.
396 * character.c (lisp_string_width):
397 * composite.c (composition_table_size, n_compositions)
398 (get_composition_id, composition_gstring_from_id):
399 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
400 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
401 * window.c (Frecenter):
402 Use ptrdiff_t, not int, for composition IDs.
403 * composite.c (get_composition_id): Check for integer overflow.
404 * composite.h: Adjust prototypes to match the above changes.
406 Use ptrdiff_t for hash table indexes.
407 * category.c (hash_get_category_set):
408 * ccl.c (ccl_driver):
409 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
410 * coding.c (coding_system_charset_list, detect_coding_system):
411 * coding.h (struct coding_system.id):
412 * composite.c (get_composition_id, gstring_lookup_cache):
413 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
414 * image.c (xpm_get_color_table_h):
415 * lisp.h (hash_lookup, hash_put):
416 * minibuf.c (Ftest_completion):
417 Use ptrdiff_t for hash table indexes, not int (which is too
418 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
419 32-bit --with-wide-int hosts).
421 * charset.c (Fdefine_charset_internal): Check for integer overflow.
422 Add a FIXME comment about memory leaks.
423 (syms_of_charset): Don't assume xmalloc returns.
425 Don't assume that stated character widths fit in int.
426 * character.c (Fchar_width, c_string_width, lisp_string_width):
427 * character.h (CHAR_WIDTH):
428 * indent.c (MULTIBYTE_BYTES_WIDTH):
429 Use sanitize_char_width to avoid undefined and/or bad behavior
430 with outlandish widths.
431 * character.h (sanitize_tab_width): Renamed from sanitize_width,
432 now that we have two such functions. All uses changed.
433 (sanitize_char_width): New inline function.
435 Don't assume that tab-width fits in int.
436 * character.h (sanitize_width): New inline function.
437 (SANE_TAB_WIDTH): New macro.
438 (ASCII_CHAR_WIDTH): Use it.
439 * indent.c (sane_tab_width): Remove. All uses replaced by
440 SANE_TAB_WIDTH (current_buffer).
441 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
443 * fileio.c: Integer overflow issues with file modes.
444 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
446 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
447 Remove unreachable code.
448 (read_hex, load_charset_map_from_file): Check for integer overflow.
450 * xterm.c: don't go over XClientMessageEvent limit
451 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
452 (x_send_scroll_bar_event): Likewise. Check that the size does not
453 exceed limits imposed by XClientMessageEvent, as well as the usual
454 ptrdiff_t and size_t limits.
456 * keyboard.c: Overflow, signedness and related fixes.
457 (make_lispy_movement): Use same integer type in forward decl
458 that is used in the definition.
459 (read_key_sequence, keyremap_step):
460 Change bufsize argument back to int, undoing my 2011-03-30 change.
461 We prefer signed types, and int is wide enough here.
462 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
463 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
464 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
465 length, not size_t. Use ptrdiff_t for index, not int.
466 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
467 possibility of integer overflow.
469 Overflow, signedness and related fixes for images.
471 * dispextern.h (struct it.stack[0].u.image.image_id)
472 (struct_it.image_id, struct image.id, struct image_cache.size)
473 (struct image_cache.used, struct image_cache.ref_count):
474 * gtkutil.c (update_frame_tool_bar):
475 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
476 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
477 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
478 * nsmenu.m (update_frame_tool_bar):
479 * xdisp.c (calc_pixel_width_or_height):
480 * xfns.c (image_cache_refcount):
481 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
482 on typical 64-bit hosts.
484 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
485 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
486 Omit unnecessary casts to int.
487 (parse_image_spec): Check that integers fall into 'int' range
488 when the callers expect that.
489 (image_ascent): Redo ascent calculation to avoid int overflow.
490 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
491 (lookup_image): Remove unnecessary tests.
492 (xbm_image_p): Locals are now of int, not EMACS_INT,
493 since parse_image_check makes sure they fit into int.
494 (png_load, gif_load, svg_load_image):
495 Prefer int to unsigned where either will do.
496 (tiff_handler): New function, combining the cores of the
497 old tiff_error_handler and tiff_warning_handler. This
498 function is rewritten to use vsnprintf and thereby avoid
499 stack buffer overflows. It uses only the features of vsnprintf
500 that are common to both POSIX and native Microsoft.
501 (tiff_error_handler, tiff_warning_handler): Use it.
502 (tiff_load, gif_load, imagemagick_load_image):
503 Don't assume :index value fits in 'int'.
504 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
505 (imagemagick_load_image): Check that crop parameters fit into
506 the integer types that MagickCropImage accepts. Don't assume
507 Vimagemagick_render_type has a nonnegative value. Don't assume
508 size_t fits in 'long'.
509 (gs_load): Use printmax_t to print the widest integers possible.
510 Check for integer overflow when computing image height and width.
512 2011-08-26 Eli Zaretskii <eliz@gnu.org>
514 * xdisp.c (redisplay_window): Don't force window start if point
515 will be invisible in the resulting window. (Bug#9324)
517 2011-08-25 Eli Zaretskii <eliz@gnu.org>
519 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
520 the display spec is of the form `(space ...)'.
521 (handle_display_spec): Return the value returned by
522 handle_single_display_spec, not just 1 or zero.
523 (handle_single_display_spec): If the display spec is of the form
524 `(space ...)', and specifies display in the text area, return 2
526 (try_cursor_movement): Check for the need to scroll more
527 accurately, and prefer exact match for point under bidi. Don't
528 advance `row' beyond the last row of the window.
530 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
531 into disp_prop; all users changed.
533 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
534 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
535 for the text covered by the display property.
537 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
539 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
540 Change return value to nil.
541 (Frecord_buffer): Delete unused function.
543 2011-08-24 Eli Zaretskii <eliz@gnu.org>
545 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
546 buffers, return left-to-right.
547 (set_cursor_from_row): Consider candidate row a win if its glyph
548 represents a newline and point is on that newline. Fixes cursor
549 positioning on the newline at EOL of R2L text within L2R
550 paragraph, and vice versa.
551 (try_cursor_movement): Check continued rows, in addition to
552 continuation rows. Fixes unwarranted scroll when point enters a
553 continued line of R2L text within an L2R paragraph, or vice versa.
554 (cursor_row_p): Consider the case of point being equal to
555 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
556 from the end of a short line to the beginning of a continued line
557 of R2L text within L2R paragraph.
558 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
561 * bidi.c (bidi_check_type): Use xassert.
562 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
565 2011-08-23 Eli Zaretskii <eliz@gnu.org>
567 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
570 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
572 * nsfont.m (ns_otf_to_script): Fix typo.
574 2011-08-22 Kenichi Handa <handa@m17n.org>
576 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
577 extra slot even if the purpose is char-code-property-table.
579 2011-08-23 Eli Zaretskii <eliz@gnu.org>
581 * xdisp.c (redisplay_window): When computing centering_position,
582 account for the height of the header line. (Bug#8874)
584 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
585 instead of CHAR_TO_BYTE. Fixes a crash when a completion
586 candidate is selected by the mouse, and that candidate has a
587 composed character under the mouse.
589 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
590 coordinates reported by pos-visible-in-window-p for a composed
591 character in column zero.
593 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
595 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
597 2011-08-22 Eli Zaretskii <eliz@gnu.org>
599 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
600 consider it a hit if to_charpos is anywhere in the range of the
601 composed buffer positions.
603 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
605 * image.c (gif_load): Don't assume that each subimage has the same
606 dimensions as the base image. Handle disposal method that is
607 "undefined" by the gif spec (Bug#9335).
609 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
611 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
612 (Fcondition_case): Document `debug' symbol in error handler.
614 2011-08-19 Eli Zaretskii <eliz@gnu.org>
616 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
617 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
618 from an Org mode buffer to a Speedbar frame.
620 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
621 a composition, take its buffer position from IT->cmp_it.charpos.
622 Fixes cursor positioning at the beginning of a line that begins
623 with a composed character.
625 2011-08-18 Eli Zaretskii <eliz@gnu.org>
627 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
628 character bidirectional type, use STRONG_L instead. Fixes crashes
629 in a buffer produced by `describe-categories'.
631 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
632 members before the level stack, so they would be saved and
633 restored when copying iterator state. Fixes incorrect reordering
634 around TABs covered by display properties.
636 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
638 * process.c (Fnetwork_interface_list): Correctly determine buffer
641 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
643 * eval.c (internal_condition_case, internal_condition_case_1)
644 (internal_condition_case_2, internal_condition_case_n):
645 Remove unnecessary aborts (Bug#9081).
647 2011-08-17 Eli Zaretskii <eliz@gnu.org>
649 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
650 has no `load' handler, try opening the file locally. (Bug#9311)
652 2011-08-16 Ken Brown <kbrown@cornell.edu>
654 * gmalloc.c: Expand comment.
656 2011-08-16 Eli Zaretskii <eliz@gnu.org>
658 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
659 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
661 2011-08-16 Ken Brown <kbrown@cornell.edu>
663 Fix memory allocation problems in Cygwin build (Bug#9273).
665 * unexcw.c ( __malloc_initialized): Declare external variable.
666 (fixup_executable): Force the dumped emacs to reinitialize malloc.
668 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
670 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
672 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
674 [CYGWIN] (special_realloc): New function.
675 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
676 requests to realloc storage in the static heap.
678 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
680 * bidi.c (bidi_initialize): Remove unused local.
682 2011-08-15 Eli Zaretskii <eliz@gnu.org>
684 * biditype.h: File removed.
686 * bidimirror.h: File removed.
688 * deps.mk (bidi.o): Remove biditype.h and
691 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
694 * dispextern.h: Fix a typo in the comment to bidi_type_t.
696 * chartab.c: Improve commentary for the uniprop_table API.
698 * bidi.c (bidi_paragraph_init): Support zero value of
699 bidi_ignore_explicit_marks_for_paragraph_level.
700 (bidi_initialize): Use uniprop_table instead of including
701 biditype.h and bidimirror.h.
703 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
704 coordinates of the iterator when restoring from ppos_it.
707 2011-08-14 Kenichi Handa <handa@m17n.org>
709 * process.c (create_process): Call setup_process_coding_systems
710 after the pid of the process is set to -1 (Bug#8162).
712 2011-08-14 Eli Zaretskii <eliz@gnu.org>
714 * xdisp.c (move_it_in_display_line_to): Don't invoke
715 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
716 ppos_it. Fixes vertical cursor motion when line beginning is
717 covered by an image. (Bug#9296)
719 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
721 * nsterm.h (ns_run_ascript): Declare.
722 (NSAPP_DATA2_RUNASSCRIPT): Define.
724 * nsfns.m (as_script, as_result, as_status): New static variables.
725 (ns_run_ascript): New function.
726 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
727 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
728 the event loop. Get status from as_status (Bug#7276).
730 * nsterm.m (sendEvent): If event is NSApplicationDefined and
731 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
732 the event loop (Bug#7276).
734 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
736 * gnutls.c (QCgnutls_bootprop_priority)
737 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
738 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
739 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
740 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
741 (QCgnutls_bootprop_verify_hostname_error)
742 (QCgnutls_bootprop_callbacks_verify): Rename from
743 Qgnutls_bootprop_..., all uses changed.
745 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
748 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
750 * xfaces.c (Qframe_set_background_mode): Now static.
751 * dispextern.h (Qframe_set_background_mode): Remove decl.
753 * process.c (Fnetwork_interface_info): Declare local only if needed.
755 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
757 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
758 (Fnetwork_interface_list): Allocate in increments of bytes instead
759 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
760 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
762 (struct ifflag_def): notrailers is smart on OSX.
763 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
764 Get hardware address with getifaddrs if available.
766 2011-08-12 Eli Zaretskii <eliz@gnu.org>
768 * xdisp.c (iterate_out_of_display_property): xassert that
769 IT->position is set to within IT->object's boundaries. Break from
770 the loop as soon as EOB is reached; avoids infloops in redisplay
771 when IT->position is set up wrongly due to some bug.
772 Set IT->current to match the bidi iterator unconditionally.
773 (push_display_prop): Allow GET_FROM_STRING as IT->method on
774 entry. Force push_it to save on the stack the current
775 buffer/string position, to be restored by pop_it. Fix flags in
776 the iterator structure wrt the object coming from a display
777 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
778 properties. (Bug#9284)
780 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
782 * fontset.c (fontset_get_font_group): Add proper type checks.
785 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
787 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
788 and LC_VERSION_MIN_MACOSX.
789 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
790 (dump_it) [LC_FUNCTION_STARTS]: Use it.
792 2011-08-08 Eli Zaretskii <eliz@gnu.org>
794 * xdisp.c (forward_to_next_line_start): Allow to use the
795 no-display-properties-and-no-overlays under bidi display.
796 Set disp_pos in the bidi iterator to avoid searches for display
797 properties and overlays.
799 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
801 * editfns.c (Fset_time_zone_rule): Document relationship with the
804 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
805 the font entity extracted from the cache (Bug#8109).
807 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
809 * composite.c (autocmp_chars): Don't reset point. That is done by
810 restore_point_unwind (Bug#5984).
812 2011-08-07 Juri Linkov <juri@jurta.org>
814 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
815 to show the arg `TIME' instead of `TIMEVAL'.
817 2011-08-06 Eli Zaretskii <eliz@gnu.org>
819 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
820 display property strides EOL and includes a newline, as in
821 longlines-mode. (Bug#9254)
822 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
823 word-wrap under bidirectional display. (Bug#9224)
825 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
826 is non-zero, even if the data buffer is NULL. Fixes a crash in
827 vertical-motion with longlines-mode. (Bug#9254)
829 2011-08-05 Eli Zaretskii <eliz@gnu.org>
831 * bidi.c <bidi_cache_total_alloc>: Now static.
832 (bidi_initialize): Initialize bidi_cache_total_alloc.
834 * xdisp.c (display_line): Release buffer allocated for shelved bidi
837 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
838 amount allocated this far in `bidi_cache_total_alloc'.
839 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
840 non-zero, only free the data buffer without restoring the cache
841 contents. All callers changed.
843 * dispextern.h (bidi_unshelve_cache): Update prototype.
845 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
846 (move_it_in_display_line, move_it_to)
847 (move_it_vertically_backward, move_it_by_lines): Replace the call
848 to xfree to an equivalent call to bidi_unshelve_cache.
849 (move_it_in_display_line_to): Fix logic of returning
850 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
852 2011-08-05 Eli Zaretskii <eliz@gnu.org>
854 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
855 came from a string character with a `cursor' property. (Bug#9229)
857 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
859 * Makefile.in (LIB_PTHREAD): New variable.
860 (LIBES): Add LIB_PTHREAD (Bug#9216).
862 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
863 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
865 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
867 * regex.c (re_iswctype): Remove some redundant boolean
870 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
872 * xterm.c (x_find_topmost_parent): New function.
873 (x_set_frame_alpha): Find topmost parent window with
874 x_find_topmost_parent and set the property there also (bug#9181).
875 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
877 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
879 * callproc.c (Fcall_process): Avoid vfork clobbering
880 the local vars buffer, coding_systems, current_dir.
882 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
884 * keymap.c (Fmake_composed_keymap): Move to subr.el.
886 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
888 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
889 so that it is not optimized away.
891 * xdisp.c (compute_display_string_pos): Remove unused local.
893 2011-08-02 Eli Zaretskii <eliz@gnu.org>
895 Fix slow cursor motion and scrolling in large buffers with
896 selective display, like Org Mode buffers. (Bug#9218)
898 * dispextern.h (struct bidi_it): New member disp_prop_p.
900 * xdisp.c: Remove one-slot cache of display string positions.
901 (compute_display_string_pos): Accept an additional argument
902 DISP_PROP_P; callers changed. Scan at most 5K characters forward
903 for a display string or property. If found, set DISP_PROP_P
906 * bidi.c (bidi_fetch_char): Accept an additional argument
907 DISP_PROP_P, and pass it to compute_display_string_pos.
908 Only handle text covered by a display string if DISP_PROP_P is returned
909 non-zero. All callers of bidi_fetch_char changed.
911 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
913 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
915 2010-12-03 Don March <don@ohspite.net>
917 * keymap.c (Fdefine_key): Fix non-prefix key error message when
918 last character M-[char] is translated to ESC [char] (bug#7541).
920 2011-08-02 Kenichi Handa <handa@m17n.org>
922 * lisp.h (uniprop_table): Extern it.
924 * chartab.c (uniprop_table): Make it non-static.
926 2011-08-01 Eli Zaretskii <eliz@gnu.org>
928 * xdisp.c (forward_to_next_line_start): Accept additional argument
929 BIDI_IT_PREV, and store into it the state of the bidi iterator had
931 (reseat_at_next_visible_line_start): Use the bidi iterator state
932 returned by forward_to_next_line_start to restore the state of
933 it->bidi_it after backing up to previous newline. (Bug#9212)
935 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
937 * regex.c (re_comp): Protoize.
938 (re_exec): Fix return type.
939 (regexec): Fix type of `ret'. (Bug#9203)
941 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
943 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
944 This is needed if max-image-size is a floating-point number.
946 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
948 * print.c (print_object): Print empty symbol as ##.
950 * lread.c (read1): Read ## as empty symbol.
952 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
954 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
955 setting frame foreground color (Bug#9175).
956 (x_set_background_color): Likewise.
958 * nsmenu.m (-setText): Size tooltip dimensions precisely to
960 (EmacsTooltip -init): Remove bezels and add shadows to
963 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
964 or scroll bar (Bug#8470).
966 * nsfont.m (nsfont_open): Remove assignment to voffset and
967 unnecessary vars hshink, expand, hd, full_height, min_height.
968 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
970 * nsterm.h (nsfont_info): Remove voffset field.
972 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
974 Implement strike-through and overline on NextStep (Bug#8863).
976 * nsfont.m (nsfont_open): Use underline position provided by font,
977 instead of hard-coded value of 2.
978 (nsfont_draw): Call ns_draw_text_decoration instead.
980 * nsterm.h: Add declaration for ns_draw_text_decoration.
982 * nsterm.m (ns_draw_text_decoration): New function for drawing
983 underline, overline, and strike-through.
984 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
985 ns_draw_text_decoration. Change treatment of cursor drawing to
986 accomodate underlining, etc.
988 2011-07-28 Eli Zaretskii <eliz@gnu.org>
990 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
993 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
995 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
996 Without this fix, if a signal arrives just after memory fills up,
997 'malloc' might be invoked reentrantly.
999 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1000 In other words, assume that every image size is allowed, on non-X
1001 hosts. This assumption is probably wrong, but it lets Emacs compile.
1003 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1005 * regex.c (re_iswctype): Convert return values to boolean.
1007 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1009 * xdisp.c (compute_display_string_pos): Don't use cached display
1010 string position if the buffer had its restriction changed.
1013 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1017 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1019 Integer signedness and overflow and related fixes. (Bug#9079)
1021 * bidi.c: Integer size and overflow fixes.
1022 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1023 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1024 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1025 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1026 (bidi_find_other_level_edge):
1027 Use ptrdiff_t instead of EMACS_INT where either will do.
1028 This works better on 32-bit hosts configured --with-wide-int.
1029 (bidi_cache_ensure_space): Check for size-calculation overflow.
1030 Use % rather than repeated addition, for better worst-case speed.
1031 Don't set bidi_cache_size until after xrealloc returns, because it
1033 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1034 (bidi_cache_ensure_space): Also check that the bidi cache size
1035 does not exceed that of the largest Lisp string or buffer. See Eli
1036 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1038 * alloc.c (__malloc_size_t): Remove.
1039 All uses replaced by size_t. See Andreas Schwab's note
1040 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1042 * image.c: Improve checking for integer overflow.
1043 (check_image_size): Assume that f is nonnull, since
1044 it is always nonnull in practice. This is one less thing to
1045 worry about when checking for integer overflow later.
1046 (x_check_image_size): New function, which checks for integer
1047 overflow issues inside X.
1048 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1049 This removes the need for a memory_full check.
1050 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1051 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1052 (xbm_read_bitmap_data): Change locals back to 'int', since
1053 their values must fit in 'int'.
1054 (xpm_load_image, png_load, tiff_load):
1055 Invoke x_create_x_image_and_pixmap earlier,
1056 to avoid much needless work if the image is too large.
1057 (tiff_load): Treat overly large images as if
1058 x_create_x_image_and_pixmap failed, not as malloc failures.
1059 (gs_load): Use x_check_image_size.
1061 * gtkutil.c: Omit integer casts.
1062 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1063 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1065 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1067 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1068 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1069 would wrongly return t on a 64-bit host.
1071 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1072 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1073 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1074 and therefore cause GCC to emit a bogus diagnostic in some cases.
1076 * image.c: Integer signedness and overflow and related fixes.
1077 This is not an exhaustive set of fixes, but it's time to
1078 record what I've got.
1079 (lookup_pixel_color, check_image_size): Remove redundant decls.
1080 (check_image_size): Don't assume that arbitrary EMACS_INT values
1081 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1082 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1083 (tiff_load, imagemagick_load_image):
1084 Check for overflow in size calculations.
1085 (x_create_x_image_and_pixmap): Remove unnecessary test for
1086 xmalloc returning NULL; that can't happen.
1087 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1088 (xpm_color_bucket): Use better integer hashing function.
1089 (xpm_cache_color): Don't possibly over-allocate memory.
1090 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1091 (gif_memory_source):
1092 Use ptrdiff_t, not int or size_t, to record sizes.
1093 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1094 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1095 either works, as we prefer signed integers.
1096 (tiff_read_from_memory, tiff_write_from_memory):
1097 Return tsize_t, not size_t, since that's what the TIFF API wants.
1098 (tiff_read_from_memory): Don't fail simply because the read would
1099 go past EOF; instead, return a short read.
1100 (tiff_load): Omit no-longer-needed casts.
1101 (Fimagemagick_types): Don't assume size fits into 'int'.
1103 Improve hashing quality when configured --with-wide-int.
1104 * fns.c (hash_string): New function, taken from sxhash_string.
1105 Do not discard information about ASCII character case; this
1106 discarding is no longer needed.
1107 (sxhash-string): Use it. Change sig to match it. Caller changed.
1108 * lisp.h: Declare it.
1109 * lread.c (hash_string): Remove, since we now use fns.c's version.
1110 The fns.c version returns a wider integer if --with-wide-int is
1111 specified, so this should help the quality of the hashing a bit.
1113 * emacs.c: Integer overflow minor fix.
1114 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1115 Define only if GNU_LINUX.
1116 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1118 * dispnew.c: Integer signedness and overflow fixes.
1119 Remove unnecessary forward decls, that were a maintenance hassle.
1120 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1122 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1123 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1124 (prepare_desired_row, line_draw_cost):
1125 Use int, not unsigned, where either works.
1126 (save_current_matrix, restore_current_matrix):
1127 Use ptrdiff_t, not size_t, where either works.
1128 (init_display): Check for overflow more accurately, and without
1129 relying on undefined behavior.
1131 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1132 Remove, replacing with the new symbols in lisp.h. All uses changed.
1133 * fileio.c (make_temp_name):
1134 * filelock.c (lock_file_1, lock_file):
1135 * xdisp.c (message_dolog):
1136 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1137 Use pMd etc. instead.
1138 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1139 replacing the pWIDE etc. symbols removed from editfns.c.
1141 * keyboard.h (num_input_events): Now uintmax_t.
1142 This is (very slightly) less likely to mess up due to wraparound.
1145 * buffer.c: Integer signedness fixes.
1146 (alloc_buffer_text, enlarge_buffer_text):
1147 Use ptrdiff_t rather than size_t when either will do, as we prefer
1150 * alloc.c: Integer signedness and overflow fixes.
1151 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1152 (__malloc_size_t): Default to size_t, not to int.
1153 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1154 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1155 Prefer ptrdiff_t to size_t when either would do, as we prefer
1157 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1158 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1159 Now const. Initialize with values that are in range even if char
1161 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1162 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1163 These functions do the right thing with sizes > 2**32.
1164 (check_depth): Now ptrdiff_t, not int.
1165 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1166 Adjust to new way of storing sizes. Check for size overflow bugs
1168 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1169 slightly wrong anyway, as it missed one instance of
1170 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1171 (refill_memory_reserve): Omit needless cast to size_t.
1172 (mark_object_loop_halt): Mark as externally visible.
1174 * xselect.c: Integer signedness and overflow fixes.
1175 (Fx_register_dnd_atom, x_handle_dnd_message):
1176 Use ptrdiff_t, not size_t, since we prefer signed.
1177 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1178 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1179 x_dnd_atoms_size and x_dnd_atoms_length.
1181 * doprnt.c: Prefer signed to unsigned when either works.
1183 * doprnt.c (doprnt):
1185 * xdisp.c (vmessage):
1186 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1187 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1188 prefer signed arithmetic to avoid comparison confusion.
1189 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1190 but is a bit tricky.
1192 Assume freestanding C89 headers, string.h, stdlib.h.
1193 * data.c, doprnt.c, floatfns.c, print.c:
1194 Include float.h unconditionally.
1195 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1196 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1197 * regex.c: Likewise for stddef.h, string.h.
1198 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1199 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1200 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1201 (STDC_HEADERS): Remove obsolete defines.
1202 * sysdep.c: Include limits.h unconditionally.
1204 Assume support for memcmp, memcpy, memmove, memset.
1205 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1206 * regex.c (memcmp, memcpy):
1207 Remove; we assume C89 now.
1209 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1210 (__malloc_safe_bcopy): Remove; no longer needed.
1212 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1213 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1214 well either way, and we prefer signed to unsigned.
1216 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1218 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1219 closes the connection while we're reading (bug#9182).
1221 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1223 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1224 are specified (Bug#9168).
1226 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1228 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1229 Found by GCC static checking and --with-wide-int on a 32-bit host.
1231 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1233 * xdisp.c (compute_display_string_pos): Fix logic of caching
1234 previous display string position. Initialize cached_prev_pos to
1235 -1. Fixes slow-down at the beginning of a buffer.
1237 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1239 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1240 for attrs[LFACE_FONTSET_INDEX].
1242 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1244 * xml.c (parse_region): Remove unused local
1245 that was recently introduced.
1247 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1249 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1250 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1252 * xdisp.c (move_it_in_display_line_to): Record the best matching
1253 position for TO_CHARPOS while scanning the line, and restore it on
1254 exit if none of the characters scanned was an exact match.
1255 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1256 when exact match is impossible due to invisible text, and the
1257 lines are truncated.
1259 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1261 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1264 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1266 Fix a significant slow-down of cursor motion with C-n, C-p,
1267 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1268 auto-repeat under bidi redisplay in fontified buffers.
1269 * xdisp.c (compute_stop_pos_backwards): New function.
1270 (next_element_from_buffer): Call compute_stop_pos_backwards to
1271 find a suitable prev_stop when we find ourselves before
1273 (reseat): Don't look for prev_stop, as that could mean a very long
1275 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1276 <cached_disp_overlay_modiff>: Cache for last found display string
1278 (compute_display_string_pos): Return the cached position if asked
1279 about the same buffer in the same area of character positions, and
1280 the buffer wasn't changed since the time the display string
1281 position was cached.
1283 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1285 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1286 is an integer, which is important for empty lines. (Bug#9149)
1288 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1290 * frame.c (Fmodify_frame_parameters): In tty case, update the
1291 default face if necessary (Bug#4238).
1293 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1295 * editfns.c (Fstring_to_char): No need to explain what a character
1296 is in the docstring (Bug#6576).
1298 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1300 * xml.c (parse_region): Make sure we always return a tree.
1302 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1304 * xml.c (parse_region): If a document contains only comments,
1307 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1309 * xml.c (make_dom): Return comments, too.
1311 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1314 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1315 and the surrounding thread.
1316 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1317 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1318 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1320 * s/openbsd.h (BROKEN_SIGIO): Define.
1321 * unexelf.c (unexec) [__OpenBSD__]:
1322 Don't update the .mdebug section of the Alpha COFF symbol table.
1324 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1326 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1329 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1331 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1332 This fixes some race conditions on the permissions of any newly
1335 * alloc.c (valid_pointer_p): Use pipe, not open.
1336 This fixes some permissions issues when debugging.
1338 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1339 If fchown fails to set both uid and gid, try to set just gid,
1340 as that is sometimes allowed. Adjust the file's mode to eliminate
1341 setuid or setgid bits that are inappropriate if fchown fails.
1343 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1345 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1346 to compare Lisp_Objects.
1347 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1348 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1349 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1351 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1353 * lread.c (read_integer): Unread even EOF character.
1354 (read1): Likewise. Properly record start position of symbol.
1356 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1357 symbol character follows.
1359 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1361 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1362 This works around a problem with the previous change to Fcopy_file.
1363 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1364 and without this change, GCC might complain about discarding
1365 fchown's return value.
1367 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1369 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1371 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1373 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1375 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1377 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1378 it's used from the C level.
1380 * process.c: Use the same condition for POLL_FOR_INPUT in both
1381 keyboard.c and process.c (bug#1858).
1383 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1385 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1386 (Fgnutls_boot): Use it.
1388 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1390 * doc.c (Fsubstitute_command_keys): Revert last change.
1392 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1394 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1395 quotes the next character, and doesn't affect other longer
1396 sequences (bug#8935).
1398 * lread.c (syms_of_lread): Clarify that is isn't only
1399 `eval-buffer' and `eval-defun' that's affected by
1400 `lexical-binding' (bug#8460).
1402 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1404 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1405 bidi redisplay when a line includes both an image and is
1408 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1410 Fix minor problems found by static checking.
1411 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1412 (elsz): Now a signed constant, not a size_t var. We prefer signed
1413 types to unsigned, to avoid integer comparison confusion. Without
1414 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1415 "cannot optimize loop, the loop counter may overflow", a symptom
1417 * indent.c (Fvertical_motion): Mark locals as initialized.
1418 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1420 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1422 * search.c (Fre_search_backward): Mention `case-fold-search' in
1423 all the re_search_* functions (bug#8138).
1425 * keyboard.c (Fopen_dribble_file): Document when the file is
1428 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1430 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1433 Support bidi reordering of display and overlay strings.
1434 * xdisp.c (compute_display_string_pos)
1435 (compute_display_string_end): Accept additional argument STRING.
1436 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1437 (reseat_to_string): Initialize bidi_it->string.s and
1438 bidi_it->string.schars.
1439 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1440 NULL (avoids a crash in bidi_paragraph_init).
1441 Initialize itb.string.lstring.
1442 (init_iterator): Call bidi_init_it only of a valid
1443 buffer position was specified. Initialize paragraph_embedding to
1445 (reseat_to_string): Initialize the bidi iterator.
1446 (display_string): If we need to ignore text properties of
1447 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1448 original value of -1 will not work with bidi.)
1449 (compute_display_string_pos): First arg is now struct
1450 `text_pos *'; all callers changed. Support display properties on
1452 (compute_display_string_end): Support display properties on Lisp
1454 (init_iterator, reseat_1, reseat_to_string): Initialize the
1455 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1456 when iterating on a string not from display properties).
1457 (compute_display_string_pos, compute_display_string_end):
1458 Fix calculation of the object to scan. Fixes an error when using
1460 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1461 base_level_stop; instead, set base_level_stop to BEGV.
1462 Fixes crashes in vertical-motion.
1463 (next_element_from_buffer): Improve commentary for when
1464 the iterator is before prev_stop.
1465 (init_iterator): Initialize bidi_p from the default value of
1466 bidi-display-reordering, not from buffer-local value. Use the
1467 buffer-local value only if initializing for buffer iteration.
1468 (handle_invisible_prop): Support invisible properties on strings
1469 that are being bidi-reordered.
1470 (set_iterator_to_next): Support bidi reordering of C strings and
1472 (next_element_from_string): Support bidi reordering of Lisp
1474 (handle_stop_backwards): Support Lisp strings as well.
1475 (display_string): Support display of R2L glyph rows.
1476 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1477 (init_iterator): Don't initialize it->bidi_p for strings
1479 (reseat_to_string): Initialize it->bidi_p for strings here.
1480 (next_element_from_string, next_element_from_c_string)
1481 (next_element_from_buffer): Add xassert's for correspondence
1482 between IT's object being iterated and it->bidi_it.string
1484 (face_before_or_after_it_pos): Support bidi iteration.
1485 (next_element_from_c_string): Handle the case of the first string
1486 character that is not the first one in the visual order.
1487 (get_visually_first_element): New function, refactored from common
1488 parts of next_element_from_buffer, next_element_from_string, and
1489 next_element_from_c_string.
1490 (tool_bar_lines_needed, redisplay_tool_bar)
1491 (display_menu_bar): Force left-to-right direction. Add a FIXME
1492 comment for making that be controlled by a user option.
1493 (push_it, pop_it): Save and restore the state of the
1494 bidi iterator. Save and restore the bidi_p flag.
1495 (pop_it): Iterate out of display property for string iteration as
1497 (iterate_out_of_display_property): Support iteration over strings.
1498 (handle_single_display_spec): Set up it->bidi_it for iteration
1499 over a display string, and call bidi_init_it.
1500 (handle_single_display_spec, next_overlay_string)
1501 (get_overlay_strings_1, push_display_prop): Set up the bidi
1502 iterator for displaying display or overlay strings.
1503 (forward_to_next_line_start): Don't use the shortcut if
1505 (back_to_previous_visible_line_start): If handle_display_prop
1506 pushed the iterator stack, restore the internal state of the bidi
1507 iterator by calling bidi_pop_it same number of times.
1508 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1509 and we are bidi-iterating, don't decrement the iterator position;
1510 instead, set the first_elt flag in the bidi iterator, to produce
1512 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1513 (push_display_prop): xassert that we are iterating a buffer.
1514 (push_it, pop_it): Save and restore paragraph_embedding member.
1515 (handle_single_display_spec, next_overlay_string)
1516 (get_overlay_strings_1, reseat_1, reseat_to_string)
1517 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1518 correctly. Don't assume unibyte strings are not bidi-reordered.
1519 (compute_display_string_pos)
1520 (compute_display_string_end): Fix handling the case of C string.
1521 (push_it, pop_it): Save and restore from_disp_prop_p.
1522 (handle_single_display_spec, push_display_prop): Set the
1523 from_disp_prop_p flag.
1524 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1525 (pop_it): Call iterate_out_of_display_property only if we are
1526 popping after iteration over a string that came from a display
1527 property. Fix a typo in popping stretch info. Add an assertion
1528 for verifying that the iterator position is in sync with the bidi
1530 (handle_single_display_spec, get_overlay_strings_1)
1531 (push_display_prop): Fix initialization of paragraph direction for
1532 string when that of the parent object is not yet determined.
1533 (reseat_1): Call bidi_init_it to resync the bidi
1534 iterator with IT's position. (Bug#7616)
1535 (find_row_edges): If ROW->start.pos gives position
1536 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1537 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1538 Reset the from_disp_prop_p flag.
1539 (SAVE_IT, RESTORE_IT): New macros.
1540 (pos_visible_p, face_before_or_after_it_pos)
1541 (back_to_previous_visible_line_start)
1542 (move_it_in_display_line_to, move_it_in_display_line)
1543 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1544 (try_scrolling, redisplay_window, display_line): Use them when
1545 saving a temporary copy of the iterator and restoring it back.
1546 (back_to_previous_visible_line_start, reseat_1)
1547 (init_iterator): Empty the bidi cache "stack".
1548 (move_it_in_display_line_to): If iterator ended up at
1549 EOL, but we never saw any buffer positions smaller than
1550 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1551 motion in bidi-reordered lines.
1552 (move_it_in_display_line_to): Record prev_method and prev_pos
1553 immediately before the call to set_iterator_to_next. Fixes cursor
1554 motion in bidi-reordered lines with stretch glyphs and strings
1555 displayed in margins. (Bug#8133) (Bug#8867)
1556 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1558 (pos_visible_p): Support positions in bidi-reordered lines.
1559 Save and restore bidi cache.
1561 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1562 (bidi_paragraph_info): Delete unused struct.
1563 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1564 (bidi_cache_start): New variable.
1565 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1567 (bidi_cache_fetch_state, bidi_cache_search)
1568 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1569 (bidi_cache_find, bidi_peek_at_next_level)
1570 (bidi_level_of_next_char, bidi_find_other_level_edge)
1571 (bidi_move_to_visually_next): Compare cache index with
1572 bidi_cache_start rather than with zero.
1573 (bidi_fetch_char): Accept new argument STRING; all callers
1574 changed. Support iteration over a string. Support strings with
1575 display properties. Support unibyte strings. Fix the type of
1576 `len' according to what STRING_CHAR_AND_LENGTH expects.
1577 (bidi_paragraph_init, bidi_resolve_explicit_1)
1578 (bidi_resolve_explicit, bidi_resolve_weak)
1579 (bidi_level_of_next_char, bidi_move_to_visually_next):
1580 Support iteration over a string.
1581 (bidi_set_sor_type, bidi_resolve_explicit_1)
1582 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1583 can now be zero (for strings); special values 0 and -1 were
1584 changed to -1 and -2, respectively.
1585 (bidi_char_at_pos): New function.
1586 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1587 Call it instead of FETCH_MULTIBYTE_CHAR.
1588 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1589 initialized to valid values.
1590 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1592 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1593 the test for valid cached positions. Fix the logic for looking up
1594 the sentinel state in the cache. GCPRO the Lisp string we are
1596 (bidi_push_it, bidi_pop_it): New functions.
1597 (bidi_initialize): Initialize the bidi cache start stack pointer.
1598 (bidi_cache_ensure_space): New function, refactored from part of
1599 bidi_cache_iterator_state. Don't assume the required size is just
1600 one BIDI_CACHE_CHUNK away.
1601 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1602 (bidi_count_bytes, bidi_char_at_pos): New functions.
1603 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1604 always valid if bidi_cache_idx is valid.
1605 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1606 is valid if it's going to be used.
1607 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1608 (bidi_cache_fetch_state, bidi_cache_search)
1609 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1610 (bidi_cache_iterator_state, bidi_cache_find)
1611 (bidi_find_other_level_edge, bidi_cache_start_stack):
1612 All variables related to cache indices are now EMACS_INT.
1614 * dispextern.h (struct bidi_string_data): New structure.
1615 (struct bidi_it): New member `string'. Make flag members be 1-bit
1616 fields, and put them last in the struct.
1617 (compute_display_string_pos, compute_display_string_end):
1619 (bidi_push_it, bidi_pop_it): Add prototypes.
1620 (struct iterator_stack_entry): New members bidi_p,
1621 paragraph_embedding, and from_disp_prop_p.
1622 (struct it): Member bidi_p is now a bit field 1 bit wide.
1623 (bidi_shelve_cache, bidi_unshelve_cache):
1626 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1627 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1628 and vector-like objects.
1630 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1631 cache around display iteration.
1633 * window.c (Fwindow_end, window_scroll_pixel_based)
1634 (displayed_window_lines, Frecenter): Save and restore the bidi
1635 cache around display iteration.
1637 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1639 * editfns.c (Fdelete_region): Clarify the use of the named
1640 parameters (bug#6788).
1642 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1644 * indent.c (Fvertical_motion): Set and restore w->pointm when
1645 saving and restoring the window's buffer (Bug#9006).
1647 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1649 * editfns.c (Fstring_to_char): Clarify just what is returned
1650 (bug#6576). Text by Eli Zaretskii.
1652 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1654 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1656 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1658 * buffer.c (mmap_find): Fix a typo.
1660 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1662 Fix execution of x selection hooks.
1663 * xselect.c (Qx_lost_selection_functions)
1664 (Qx_sent_selection_functions): New vars.
1665 (syms_of_xselect): DEFSYM them.
1666 (x_handle_selection_request): Pass Qx_sent_selection_functions
1667 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1668 (x_handle_selection_clear,x_clear_frame_selections):
1669 Pass Qx_lost_selection_functions rather than
1670 Vx_lost_selection_functions to Frun_hook_with_args.
1672 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1674 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1675 The old code sometimes used this field without initializing it.
1677 * alloc.c (gc_sweep): Don't read past end of array.
1678 In theory, the old code could also have corrupted Emacs internals,
1679 though it'd be very unlikely.
1681 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1683 * character.c (Fcharacterp): Don't advertise optional ignored
1684 argument. (Bug#4026)
1686 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1688 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1691 * window.c (Fset_window_start): Doc fix (bug#4199).
1692 (Fset_window_hscroll): Ditto.
1694 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1696 Fix minor new problems caught by GCC 4.6.1.
1697 * term.c (init_tty): Remove unused local.
1698 * xsettings.c (store_monospaced_changed): Define this function only
1699 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1702 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1704 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1706 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1708 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1709 are the mini-buffer and the echo area (bug#3320).
1711 * term.c (init_tty): Remove support for supdup, c10 and perq
1712 terminals, which are no longer supported (bug#1482).
1714 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1716 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1718 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1720 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1721 for non-popups (Bug#3642).
1723 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1725 * alloc.c (reset_malloc_hooks): Protoize.
1726 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1727 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1728 * cm.c (losecursor): Likewise.
1729 * data.c (fmod): Likewise.
1730 * dispnew.c (swap_glyphs_in_rows): Likewise.
1731 * emacs.c (memory_warning_signal): Likewise.
1732 * floatfns.c (float_error): Likewise.
1733 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1734 (otf_open, font_otf_capability, generate_otf_features)
1735 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1737 * image.c (pbm_read_file): Likewise.
1738 * indent.c (string_display_width): Likewise.
1739 * intervals.c (check_for_interval, search_for_interval)
1740 (inc_interval_count, count_intervals, root_interval)
1741 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1742 * lread.c (defalias): Likewise.
1743 * ralloc.c (r_alloc_check): Likewise.
1744 * regex.c (set_image_of_range_1, set_image_of_range)
1745 (regex_grow_registers): Likewise.
1746 * sysdep.c (strerror): Likewise.
1747 * termcap.c (valid_filename_p, tprint, main): Likewise.
1748 * tparam.c (main): Likewise.
1749 * unexhp9k800.c (run_time_remap, save_data_space)
1750 (update_file_ptrs, read_header, write_header, calculate_checksum)
1751 (copy_file, copy_rest, display_header): Likewise.
1752 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1754 * xdisp.c (check_it): Likewise.
1755 * xfaces.c (register_color, unregister_color, unregister_colors):
1757 * xfns.c (print_fontset_result): Likewise.
1758 * xrdb.c (member, fatal, main): Likewise.
1760 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1762 Fix minor problems found by static checking (Bug#9031).
1763 * chartab.c (char_table_set_range, map_sub_char_table):
1764 Remove unused locals.
1765 (uniprop_table): Now static.
1766 * composite.c (_work_char): Remove unused static var.
1768 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1770 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1772 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1774 * gtkutil.c (qttip_cb): Remove code without function.
1776 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1778 * w32.c (pthread_sigmask): New stub.
1780 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1782 Use pthread_sigmask, not sigprocmask (Bug#9010).
1783 sigprocmask is portable only for single-threaded applications, and
1784 Emacs can be multi-threaded when it uses GTK.
1785 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1787 * callproc.c (Fcall_process):
1788 * process.c (create_process):
1789 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1790 Use pthread_sigmask, not sigprocmask.
1792 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1794 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1795 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1798 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1800 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1801 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1802 (xg_hide_tooltip): Fix comment.
1804 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1805 in registerServicesMenuSendTypes.
1806 (validRequestorForSendType): Don't check ns_return_types.
1808 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1811 2011-07-08 Jason Rumney <jasonr@gnu.org>
1813 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1814 frame struct members of non-existent frames (Bug#6284).
1816 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1818 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1819 variable firstTime not needed on OSX >= 10.6.
1820 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1821 >= 10.5. Use setKnobProportion, setDoubleValue.
1823 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1824 (MAC_OS_X_VERSION_10_5): Define if not defined.
1825 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1826 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1827 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1829 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1830 cString and lossyCString on OSX >= 10.4
1832 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1833 sizeToFit on OSX >= 10.2.
1835 * nsimage.m (allocInitFromFile): Don't use deprecated method
1836 bestRepresentationForDevice on OSX >= 10.6.
1838 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1841 * emacs.c: Declare unexec_init_emacs_zone.
1843 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1845 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1847 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1848 on svcsMenu (Bug#8842).
1850 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1852 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1854 * nsterm.m (QUTF8_STRING): Declare.
1855 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1856 (validRequestorForSendType): Return type is (id).
1857 Change indexOfObjectIdenticalTo to indexOfObject.
1858 Check if we have local selection before returning self (Bug#8842).
1859 (writeSelectionToPasteboard): Put local selection into paste board
1860 if we have a local selection (Bug#8842).
1861 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1863 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1864 (ns_get_local_selection): Declare.
1866 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1868 * keymap.c (describe_map_tree): Don't insert a double newline at
1869 the end of the buffer (bug#1169) and return whether we inserted
1872 * callint.c (Fcall_interactively): Change "reading args" to
1873 "providing args" to try to clarify what it does (bug#1010).
1875 2011-07-07 Kenichi Handa <handa@m17n.org>
1877 * composite.c (composition_compute_stop_pos): Ignore a static
1878 composition starting before CHARPOS (Bug#8915).
1880 * xdisp.c (handle_composition_prop): Likewise.
1882 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1884 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1887 2011-07-07 Kenichi Handa <handa@m17n.org>
1889 * character.h (unicode_category_t): New enum type.
1891 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1892 (Qchar_code_property_table): New variable.
1893 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1894 (UNIPROP_COMPRESSED_FORM_P): New macros.
1895 (char_table_ascii): Uncompress the compressed values.
1896 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1897 Uncompress the compressed values.
1898 (sub_char_table_ref_and_range): Likewise.
1899 (char_table_ref_and_range): Uncompress the compressed values.
1900 (sub_char_table_set): New arg is_uniprop. Callers changed.
1901 Uncompress the compressed values.
1902 (sub_char_table_set_range): Args changed. Callers changed.
1903 (char_table_set_range): Adjuted for the above change.
1904 (map_sub_char_table): Delete args default_val and parent. Add arg
1905 top. Give decoded values to a Lisp function.
1906 (map_char_table): Adjust for the above change. Give decoded
1907 values to a Lisp function. Gcpro more variables.
1908 (uniprop_table_uncompress)
1909 (uniprop_decode_value_run_length): New functions.
1910 (uniprop_decoder, uniprop_decoder_count): New variables.
1911 (uniprop_get_decoder, uniprop_encode_value_character)
1912 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1914 (uniprop_encoder, uniprop_encoder_count): New variables.
1915 (uniprop_get_encoder, uniprop_table)
1916 (Funicode_property_table_internal, Fget_unicode_property_internal)
1917 (Fput_unicode_property_internal): New functions.
1918 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1919 Sunicode_property_table_internal, Sget_unicode_property_internal,
1920 and Sput_unicode_property_internal. Defvar_lisp
1921 char-code-property-alist.
1923 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1924 Vunicode_category_table.
1926 * font.c (font_range): Adjust for the change of
1927 Vunicode_category_table.
1929 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1931 * m/iris4d.h: Remove file, move contents ...
1932 * s/irix6-5.h: ... here.
1934 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1936 Remove unportable assumption about struct layout (Bug#8884).
1937 * alloc.c (mark_buffer):
1938 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1939 (clone_per_buffer_values): Don't assume that
1940 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1941 This isn't true in general, and it's particularly not true
1942 if Emacs is configured with --with-wide-int.
1943 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1944 New macros, used in the buffer.c change.
1946 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1948 * xsettings.c: Use both GConf and GSettings if both are available.
1949 (store_config_changed_event): Add comment.
1950 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1951 (store_tool_bar_style_changed): New functions.
1952 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1953 (struct xsettings): Move font inside HAVE_XFT.
1954 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1955 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1956 Move inside HAVE_XFT.
1957 (something_changed_gsettingsCB): Rename from something_changedCB.
1958 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1960 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1961 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1962 (something_changed_gconfCB): Rename from something_changedCB.
1963 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1964 (parse_settings): Move check for font inside HAVE_XFT.
1965 (read_settings, apply_xft_settings): Add comment.
1966 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1967 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1968 call store_font_name_changed.
1969 (xft_settings_event): Add comment.
1970 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1971 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1972 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1973 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1974 (xsettings_initialize): Call init_gsettings last.
1975 (xsettings_get_system_font, xsettings_get_system_normal_font):
1978 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1980 Random fixes. E.g., (random) never returned negative values.
1981 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1982 subseconds part to the entropy, as that's a bit more random.
1983 Prefer signed to unsigned, since the signedness doesn't matter and
1984 in general we prefer signed. When given a limit, use a
1985 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1986 latter isn't right if USE_2_TAGS_FOR_INTS.
1987 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1988 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1990 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1992 * textprop.c (text_property_stickiness):
1993 Obey Vtext_property_default_nonsticky.
1994 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1995 * w32fns.c (syms_of_w32fns):
1996 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1998 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2000 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2001 This is more efficient than Ffile_directory_p and avoids a minor race.
2003 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2005 * buffer.c (Foverlay_put): Say what the return value is
2008 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2009 is a directory before asking whether to use the file name
2011 (barf_or_query_if_file_exists): Make the "File is a directory"
2012 error be more correct.
2014 * fns.c (Frequire): Remove the mention of the .gz files, since
2015 that's installation-specific, but keep the mention of
2016 `get-load-suffixes'.
2018 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2020 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2021 Report string overflow if the output is too long.
2023 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2025 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2026 (syms_of_gnutls): Remove duplicate DEFSYM for
2027 Qgnutls_bootprop_verify_hostname_error, an error for
2028 Qgnutls_bootprop_verify_error (which is no longer used).
2030 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2031 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2032 Also (re)move comments that are misplaced or no longer relevant.
2034 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2036 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2038 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2040 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2041 and background color parameters if they have been changed.
2043 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2045 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2047 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2049 * xsettings.c (SYSTEM_FONT): Define only when used.
2050 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2052 * keymap.c (access_keymap_1): Now static.
2054 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2056 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2057 leave any prefix arg for the up event (Bug#1586).
2059 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2061 * lread.c (syms_of_lread): Mention single symbols defined by
2062 `defvar' or `defconst' (bug#7154).
2064 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2065 (Frequire): Mention get-load-suffixes.
2067 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2069 * window.h (window): Remove clone_number slot.
2070 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2072 (make_parent_window, make_window, saved_window)
2073 (Fset_window_configuration, save_window_save): Don't deal with
2075 * buffer.c (Qclone_number): Remove declaration.
2076 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2078 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2080 Add multiple inheritance to keymaps.
2081 * keymap.c (Fmake_composed_keymap): New function.
2082 (Fset_keymap_parent): Simplify.
2083 (fix_submap_inheritance): Remove.
2084 (access_keymap_1): New function extracted from access_keymap to handle
2085 embedded parents and handle lists of maps.
2086 (access_keymap): Use it.
2087 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2088 (Fcopy_keymap): Handle embedded parents.
2089 (Fcommand_remapping, define_as_prefix): Simplify.
2090 (Fkey_binding): Simplify.
2091 (syms_of_keymap): Move minibuffer-local-completion-map,
2092 minibuffer-local-filename-completion-map,
2093 minibuffer-local-must-match-map, and
2094 minibuffer-local-filename-must-match-map to Elisp.
2095 (syms_of_keymap): Defsubr make-composed-keymap.
2096 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2097 (parse_menu_item): Trivial simplification.
2099 2011-07-01 Glenn Morris <rgm@gnu.org>
2101 * Makefile.in (SETTINGS_LIBS): Fix typo.
2103 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2105 * coding.c (Fencode_coding_string): Record the last coding system
2106 used, as the function doc string says (bug#8738).
2108 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2110 * xsettings.c (store_monospaced_changed): Take new font as arg and
2111 check for change against current_mono_font.
2112 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2113 (emacs_settings_constructor, emacs_settings_get_property)
2114 (emacs_settings_set_property, emacs_settings_class_init)
2115 (emacs_settings_init, gsettings_obj): Remove.
2116 (something_changedCB): New function for HAVE_GSETTINGS.
2117 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2118 with value as argument.
2119 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2120 g_settings_new (Bug#8967). Do not create gsettings_obj.
2121 Remove calls to g_settings_bind. Connect something_changedCB to
2124 * xgselect.c: Add defined (HAVE_GSETTINGS).
2125 (xgselect_initialize): Ditto.
2127 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2128 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2131 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2133 * eval.c (struct backtrace): Simplify and port the data structure.
2134 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2135 signed bit field, as this assumption is not portable and it makes
2136 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2137 "char debug_on_exit : 1" as this is not portable either; instead,
2138 use the portable "unsigned int debug_on_exit : 1". Remove unused
2139 member evalargs. Remove obsolete comments about cc bombing out.
2141 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2143 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2144 Let HAVE_GSETTINGS override HAVE_GCONF.
2145 (store_monospaced_changed): New function.
2146 (EMACS_SETTINGS): A new type derived from GObject to handle
2147 GSettings notifications.
2148 (emacs_settings_constructor, emacs_settings_get_property)
2149 (emacs_settings_set_property, emacs_settings_class_init):
2151 (gsettings_client, gsettings_obj): New variables.
2152 (GSETTINGS_SCHEMA): New define.
2153 (something_changedCB): Call store_monospaced_changed.
2154 (init_gsettings): New function.
2155 (xsettings_initialize): Call init_gsettings.
2156 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2159 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2162 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2164 * window.c (resize_root_window, grow_mini_window)
2165 (shrink_mini_window): Rename Qresize_root_window to
2166 Qwindow_resize_root_window and Qresize_root_window_vertically to
2167 Qwindow_resize_root_window_vertically.
2169 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2171 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2173 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2175 * makefile.w32-in: Redesign dependencies so they reflect more
2176 clearly which files are directly included by each source file,
2177 and not through other includes.
2179 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2181 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2182 (sort_overlays, overlay_strings): When an overlay's clone number
2183 matches the window's clone number process the overlay even if
2184 the overlay's window property doesn't match the current window.
2186 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2187 (Fwindow_hchild): Rename to Fwindow_left_child.
2188 (Fwindow_next): Rename to Fwindow_next_sibling.
2189 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2190 (resize_window_check): Rename to window_resize_check.
2191 (resize_window_apply): Rename to window_resize_apply.
2192 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2193 (Fdelete_other_windows_internal, resize_frame_windows)
2194 (Fsplit_window_internal, Fdelete_window_internal)
2195 (grow_mini_window, shrink_mini_window)
2196 (Fresize_mini_window_internal): Fix callers accordingly.
2198 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2200 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2201 (emacs_fixed_set_min_size): Remove.
2202 (emacs_fixed_new): Take frame as argument.
2204 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2205 (_EmacsFixedPrivate): Remove minwidth/height.
2206 Add struct frame *f.
2207 (emacs_fixed_init): Initialize priv->f.
2208 (get_parent_class, emacs_fixed_set_min_size): Remove.
2209 (emacs_fixed_new): Set priv->f to argument.
2210 (emacs_fixed_get_preferred_width)
2211 (emacs_fixed_get_preferred_height): Use min_width/height from
2212 frames size_hint to set minimum and natural (Bug#8919).
2213 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2214 and use min_width/height from frames size_hint to set
2215 min_width/height (Bug#8919).
2217 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2218 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2221 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2223 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2224 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2227 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2229 * process.c (wait_reading_process_output): Bypass select if
2230 waiting for a cell while ignoring keyboard input, and input is
2231 pending. Suggested by Jan Djärv (Bug#8869).
2233 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2235 Use gnulib's dup2 module instead of rolling our own.
2236 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2238 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2240 * dispnew.c (scrolling_window): Before scrolling, turn off a
2241 mouse-highlight in the window being scrolled.
2243 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2245 Move DEFSYM to lisp.h and use everywhere.
2247 * character.h (DEFSYM): Move declaration...
2248 * lisp.h (DEFSYM): ...here.
2254 * w32select.c: Don't include character.h.
2256 * alloc.c (syms_of_alloc):
2257 * buffer.c (syms_of_buffer):
2258 * bytecode.c (syms_of_bytecode):
2259 * callint.c (syms_of_callint):
2260 * casefiddle.c (syms_of_casefiddle):
2261 * casetab.c (init_casetab_once):
2262 * category.c (init_category_once, syms_of_category):
2263 * ccl.c (syms_of_ccl):
2264 * cmds.c (syms_of_cmds):
2265 * composite.c (syms_of_composite):
2266 * dbusbind.c (syms_of_dbusbind):
2267 * dired.c (syms_of_dired):
2268 * dispnew.c (syms_of_display):
2269 * doc.c (syms_of_doc):
2270 * editfns.c (syms_of_editfns):
2271 * emacs.c (syms_of_emacs):
2272 * eval.c (syms_of_eval):
2273 * fileio.c (syms_of_fileio):
2274 * fns.c (syms_of_fns):
2275 * frame.c (syms_of_frame):
2276 * fringe.c (syms_of_fringe):
2277 * insdel.c (syms_of_insdel):
2278 * keymap.c (syms_of_keymap):
2279 * lread.c (init_obarray, syms_of_lread):
2280 * macros.c (syms_of_macros):
2281 * msdos.c (syms_of_msdos):
2282 * print.c (syms_of_print):
2283 * process.c (syms_of_process):
2284 * search.c (syms_of_search):
2285 * sound.c (syms_of_sound):
2286 * syntax.c (init_syntax_once, syms_of_syntax):
2287 * terminal.c (syms_of_terminal):
2288 * textprop.c (syms_of_textprop):
2289 * undo.c (syms_of_undo):
2290 * w32.c (globals_of_w32):
2291 * window.c (syms_of_window):
2292 * xdisp.c (syms_of_xdisp):
2293 * xfaces.c (syms_of_xfaces):
2294 * xfns.c (syms_of_xfns):
2295 * xmenu.c (syms_of_xmenu):
2296 * xsettings.c (syms_of_xsettings):
2297 * xterm.c (syms_of_xterm): Use DEFSYM.
2299 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2301 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2303 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2305 Integer and buffer overflow fixes (Bug#8873).
2307 * print.c (printchar, strout): Check for string overflow.
2308 (PRINTPREPARE, printchar, strout):
2309 Don't set size unless allocation succeeds.
2311 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2312 for sizes. Check for string overflow more accurately.
2313 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2315 * macros.c: Integer and buffer overflow fixes.
2316 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2317 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2318 Use ptrdiff_t, not int, for sizes.
2319 Don't increment bufsize until after realloc succeeds.
2320 Check for size-calculation overflow.
2321 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2323 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2325 * lread.c: Integer overflow fixes.
2326 (read_integer): Radix is now EMACS_INT, not int,
2327 to improve quality of diagnostics for out-of-range radices.
2328 Calculate buffer size correctly for out-of-range radices.
2329 (read1): Check for integer overflow in radices, and in
2330 read-circle numbers.
2331 (read_escape): Avoid int overflow.
2332 (Fload, openp, read_buffer_size, read1)
2333 (substitute_object_recurse, read_vector, read_list, map_obarray):
2334 Use ptrdiff_t, not int, for sizes.
2335 (read1): Use EMACS_INT, not int, for sizes.
2336 Check for size overflow.
2338 * image.c (cache_image): Check for size arithmetic overflow.
2340 * lread.c: Integer overflow issues.
2341 (saved_doc_string_size, saved_doc_string_length)
2342 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2343 Now ptrdiff_t, not int.
2344 (read1): Don't assume doc string length fits in int. Check for
2345 out-of-range doc string lengths.
2346 (read_list): Don't assume file position fits in int.
2347 (read_escape): Check for hex character overflow.
2349 2011-06-22 Leo Liu <sdl.web@gmail.com>
2351 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2352 Move to minibuffer.el.
2354 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2356 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2357 The following patches are for when GLYPH_DEBUG && !XASSERT.
2358 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2359 * dispnew.c (flush_stdout):
2360 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2361 Mark as externally visible.
2362 * dispnew.c (check_window_matrix_pointers): Now static.
2363 * dispnew.c (window_to_frame_vpos):
2364 * xfns.c (unwind_create_frame):
2365 * xterm.c (x_check_font): Remove unused local.
2366 * scroll.c (CHECK_BOUNDS):
2367 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2368 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2369 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2370 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2371 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2373 (debug_method_add): Use va_list and vsprintf rather than relying
2374 on undefined behavior with wrong number of arguments.
2375 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2376 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2377 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2378 since we're not interested in debugging glyphs with old libraries.
2379 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2380 GCC 4.6.0's static checking.
2382 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2384 Integer overflow and signedness fixes (Bug#8873).
2385 A few related buffer overrun fixes, too.
2387 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2389 * dispextern.h (struct face.stipple):
2390 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2391 (x_bitmap_mask, x_allocate_bitmap_record)
2392 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2393 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2394 (x_create_bitmap_from_xpm_data):
2395 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2396 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2398 * xfaces.c (load_pixmap):
2399 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2400 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2401 (.bitmaps_last, struct x_output.icon_bitmap):
2402 Use ptrdiff_t, not int, for bitmap indexes.
2403 (x_allocate_bitmap_record): Check for size overflow.
2404 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2406 Use ptrdiff_t, not int, for overlay counts.
2407 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2408 * editfns.c (overlays_around, get_pos_property):
2409 * textprop.c (get_char_property_and_overlay):
2410 * xdisp.c (next_overlay_change, note_mouse_highlight):
2411 * xfaces.c (face_at_buffer_position):
2412 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2413 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2414 (Fnext_overlay_change, Fprevious_overlay_change)
2415 (mouse_face_overlay_overlaps, Foverlays_in):
2416 Use ptrdiff_t, not int, for sizes.
2417 (overlays_at, overlays_in): Check for size-calculation overflow.
2419 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2421 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2422 (x_session_initialize): Do not assume string length fits in int.
2424 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2425 This is unlikely, but can occur if DPI is outlandish.
2427 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2428 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2430 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2431 * xrdb.c (magic_file_p, search_magic_path):
2432 Omit last arg SUFFIX; it was always 0. All callers changed.
2433 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2435 * xfont.c (xfont_match): Avoid need for strlen.
2437 * xfns.c: Don't assume strlen fits in int.
2438 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2440 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2441 not unsigned long, as we prefer signed integers. All callers changed.
2442 Detect integer overflow in repeat count.
2443 (message_dolog): Don't assume print length fits in 39 bytes.
2444 (display_mode_element): Don't assume strlen fits in int.
2446 * termcap.c: Don't assume sizes fit in int and never overflow.
2447 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2448 (gobble_line): Check for size-calculation overflow.
2450 * minibuf.c (Fread_buffer):
2451 * lread.c (intern, intern_c_string):
2452 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2453 Don't assume string length fits in int.
2455 * keyboard.c (parse_tool_bar_item):
2456 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2458 * font.c: Don't assume string length fits in int.
2459 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2460 Use ptrdiff_t, not int.
2461 (font_intern_prop): Don't assume string length fits in int.
2462 Don't assume integer property fits in fixnum.
2463 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2465 * filelock.c: Fix some buffer overrun and integer overflow issues.
2466 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2467 Reformulate so as not to need the command string.
2468 Invoke gzip -cd rather than gunzip, as it's more portable.
2469 (lock_info_type, lock_file_1, lock_file):
2470 Don't assume pid_t and time_t fit in unsigned long.
2471 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2472 (current_lock_owner): Prefer signed type for sizes.
2473 Use memcpy, not strncpy, where memcpy is what is really wanted.
2474 Don't assume (via atoi) that time_t and pid_t fit in int.
2475 Check for time_t and/or pid_t out of range, e.g., via a network share.
2476 Don't alloca where an auto var works fine.
2478 * fileio.c: Fix some integer overflow issues.
2479 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2480 Don't assume string length fits in int.
2481 (directory_file_name): Don't assume string length fits in long.
2482 (make_temp_name): Don't assume pid fits in int, or that its print
2483 length is less than 20.
2485 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2487 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2489 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2491 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2492 We prefer signed integers, even for size calculations.
2494 * emacs.c: Don't assume string length fits in 'int'.
2495 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2496 (main): Don't invoke strlen when not needed.
2498 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2499 (XD_DEBUG_MESSAGE): Don't waste a byte.
2501 * callproc.c (getenv_internal_1, getenv_internal)
2503 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2505 * lread.c (invalid_syntax): Omit length argument.
2506 All uses changed. This doesn't fix a bug, but it simplifies the
2507 code away from its former Hollerith-constant appearance, and it's
2508 one less 'int' to worry about when looking at integer-overflow issues.
2509 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2511 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2512 This didn't break anything, but it didn't help either.
2513 It's confusing to put a bogus integer in a place where the actual
2514 value does not matter.
2515 (LIST_END_P): Remove unused macro and its bogus comment.
2516 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2518 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2519 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2521 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2522 We prefer signed types, and the value cannot exceed the EMACS_INT
2523 range anyway (because otherwise the length would not be representable).
2524 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2525 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2526 This avoids a GCC warning when WIDE_EMACS_INT.
2528 * indent.c (sane_tab_width): New function.
2529 (current_column, scan_for_column, Findent_to, position_indentation)
2530 (compute_motion): Use it. This is just for clarity.
2531 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2533 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2535 * lisp.h (lint_assume): New macro.
2536 * composite.c (composition_gstring_put_cache):
2537 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2539 * editfns.c, insdel.c:
2540 Omit unnecessary forward decls, to simplify future changes.
2542 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2544 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2546 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2547 Use much-faster test for byte-length change.
2548 Don't assume string byte-length fits in 'int'.
2549 Check that character arg fits in 'int'.
2550 (mapcar1): Declare byte as byte, for clarity.
2552 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2554 * fns.c (concat): Catch string overflow earlier.
2555 Do not rely on integer wraparound.
2557 * dispextern.h (struct it.overlay_strings_charpos)
2558 (struct it.selective): Now EMACS_INT, not int.
2559 * xdisp.c (forward_to_next_line_start)
2560 (back_to_previous_visible_line_start)
2561 (reseat_at_next_visible_line_start, next_element_from_buffer):
2562 Don't arbitrarily truncate the value of 'selective' to int.
2564 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2566 * composite.c: Don't truncate sizes to 'int'.
2567 (composition_gstring_p, composition_reseat_it)
2568 (composition_adjust_point): Use EMACS_INT, not int.
2569 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2570 not EMACS_UINT, for indexes.
2572 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2574 * buffer.c: Include <verify.h>.
2575 (struct sortvec.priority, struct sortstr.priority):
2576 Now EMACS_INT, not int.
2577 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2578 (struct sortstr.size, record_overlay_string)
2579 (struct sortstrlist.size, struct sortlist.used):
2580 Don't truncate size to int.
2581 (record_overlay_string): Check for size-calculation overflow.
2582 (init_buffer_once): Check at compile-time, not run-time.
2584 2011-06-22 Jim Meyering <meyering@redhat.com>
2586 Don't leak an XBM-image-sized buffer
2587 * image.c (xbm_load): Free the image buffer after using it.
2589 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2592 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2593 that Sun C diagnosed.
2594 * fns.c (secure_hash): Fix pointer signedness issue.
2595 * intervals.c (static_offset_intervals): New function.
2596 (offset_intervals): Use it.
2598 2011-06-21 Leo Liu <sdl.web@gmail.com>
2601 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2604 * fns.c (secure_hash): Rename from crypto_hash_function and change
2605 the first arg to accept symbols.
2606 (Fsecure_hash): New primitive.
2607 (syms_of_fns): New symbols.
2609 2011-06-20 Deniz Dogan <deniz@dogan.se>
2611 * process.c (Fset_process_buffer): Clarify return value in
2614 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2616 * dispnew.c (add_window_display_history): Use BVAR.
2618 * xdisp.c (debug_method_add): Use BVAR.
2619 (check_window_end, dump_glyph_matrix, dump_glyph)
2620 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2622 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2625 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2626 check till after the cache is created in init_frame_faces.
2628 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2630 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2632 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2634 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2635 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2636 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2638 Improve buffer-overflow checking (Bug#8873).
2639 * fileio.c (Finsert_file_contents):
2640 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2641 Remove the old (too-loose) buffer overflow checks.
2642 They weren't needed, since make_gap checks for buffer overflow.
2643 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2644 The old code merely checked for Emacs fixnum overflow, and relied
2645 on undefined (wraparound) behavior. The new code avoids undefined
2646 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2648 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2649 Tune. Don't use wider integers than needed. Don't use alloca.
2650 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2652 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2654 * insdel.c, lisp.h (buffer_overflow): New function.
2655 (insert_from_buffer_1, replace_range, replace_range_2):
2656 * insdel.c (make_gap_larger):
2657 * editfns.c (Finsert_char):
2658 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2660 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2662 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2664 Integer overflow and signedness fixes (Bug#8873).
2666 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2667 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2669 * fileio.c: Don't assume EMACS_INT fits in off_t.
2670 (emacs_lseek): New static function.
2671 (Finsert_file_contents, Fwrite_region): Use it.
2672 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2674 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2676 * fns.c: Don't overflow int when computing a list length.
2677 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2678 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2679 truncation on 64-bit hosts. Check for QUIT every
2680 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2681 faster and is responsive enough.
2682 (Flength): Report an error instead of overflowing an integer.
2683 (Fsafe_length): Return a float if the value is not representable
2684 as a fixnum. This shouldn't happen except in contrived situations.
2685 (Fnthcdr, Fsort): Don't assume list length fits in int.
2686 (Fcopy_sequence): Don't assume vector length fits in int.
2688 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2689 (header_size, word_size): New constants.
2690 (allocate_vectorlike): Don't check size overflow here.
2691 (allocate_vector): Check it here instead, since this is the only
2692 caller of allocate_vectorlike that could cause overflow.
2693 Check that the new vector's length is representable as a fixnum.
2695 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2696 The previous code was bogus. For example, next_almost_prime (32)
2697 returned 39, which is undesirable as it is a multiple of 3; and
2698 next_almost_prime (24) returned 25, which is a multiple of 5 so
2699 why was the code bothering to check for multiples of 7?
2701 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2703 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2705 Variadic C functions now count arguments with ptrdiff_t.
2706 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2707 Back then I didn't know that the Emacs coding style prefers signed int.
2708 Also, in the meantime I found a few more instances where arguments
2709 were being counted with int, which may truncate counts on 64-bit
2710 machines, or EMACS_INT, which may be unnecessarily wide.
2711 * lisp.h (struct Lisp_Subr.function.aMANY)
2712 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2713 Arg counts are now ptrdiff_t, not size_t.
2714 All variadic functions and their callers changed accordingly.
2715 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2716 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2717 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2718 * callint.c (Fcall_interactively): Check arg count for overflow,
2719 to avoid potential buffer overrun. Use signed char, not 'int',
2720 for 'varies' array, so that we needn't bother to check its size
2721 calculation for overflow.
2722 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2723 * eval.c (apply_lambda):
2724 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2725 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2726 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2728 * callint.c (Fcall_interactively): Don't use index var as event count.
2730 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2731 * mem-limits.h (SIZE): Remove; no longer used.
2733 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2735 Remove unnecessary casts.
2736 * xterm.c (x_term_init):
2737 * xfns.c (x_set_border_pixel):
2738 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2739 These aren't needed now that we assume ANSI C.
2741 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2742 It's more likely to cause problems (due to unsigned overflow)
2745 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2747 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2749 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2751 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2753 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2755 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2757 GLYPH_CODE_FACE returns EMACS_INT, not int.
2758 * dispextern.h (merge_faces):
2759 * xfaces.c (merge_faces):
2760 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2761 Don't assume EMACS_INT fits in int.
2763 * character.h (CHAR_VALID_P): Remove unused parameter.
2764 * fontset.c, lisp.h, xdisp.c: All uses changed.
2766 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2768 * fns.c (concat): Minor tuning based on overflow analysis.
2769 This doesn't fix any bugs. Use int to hold character, instead
2770 of constantly refetching from Emacs object. Use XFASTINT, not
2771 XINT, for value known to be a character. Don't bother comparing
2772 a single byte to 0400, as it's always less.
2774 * floatfns.c (Fexpt):
2775 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2777 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2780 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2782 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2783 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2784 incorrectly succeed when S was a string, because 4294967386 was
2785 truncated before it was used.
2787 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2788 Otherwise, an out-of-range integer could cause undefined behavior
2791 * composite.c: Use int, not EMACS_INT, for characters.
2792 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2793 EMACS_INT, for values that are known to be in character range.
2794 This doesn't fix any bugs but is the usual style inside Emacs and
2795 may generate better code on 32-bit machines.
2797 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2798 This is for reasons similar to the recent CHAR_STRING fix.
2799 * charset.c (Fencode_char): Check that character arg is actually
2800 a character. Pass an int to ENCODE_CHAR.
2801 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2802 wider than 'int', as a compile-time check to prevent future regressions
2805 * character.c (char_string): Remove unnecessary casts.
2807 Make sure a 64-bit char is never passed to CHAR_STRING.
2808 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2809 by silently ignoring the top 32 bits, allowing some values
2810 that were far too large to be valid characters.
2811 * character.h: Include <verify.h>.
2812 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2813 arguments are no wider than unsigned, as a compile-time check
2814 to prevent future regressions in this area.
2816 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2817 (Fsubst_char_in_region):
2819 * xdisp.c (decode_mode_spec_coding):
2820 Adjust to CHAR_STRING's new requirement.
2821 * editfns.c (Finsert_char, Fsubst_char_in_region):
2822 * fns.c (concat): Check that character args are actually
2823 characters. Without this test, these functions did the wrong
2824 thing with wildly out-of-range values on 64-bit hosts.
2826 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2827 These casts should not be needed on 32-bit hosts, either.
2828 * keyboard.c (read_char):
2829 * lread.c (Fload): Remove casts to unsigned.
2831 * lisp.h (UNSIGNED_CMP): New macro.
2832 This fixes comparison bugs on 64-bit hosts.
2833 (ASCII_CHAR_P): Use it.
2834 * casefiddle.c (casify_object):
2835 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2836 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2837 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2838 * dispextern.h (FACE_FROM_ID):
2839 * keyboard.c (read_char): Use UNSIGNED_CMP.
2841 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2842 not to EMACS_INT, to avoid GCC warning.
2844 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2846 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2847 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2848 isn't needed on 32-bit machines.
2850 * buffer.c (Fgenerate_new_buffer_name):
2851 Use EMACS_INT for count, not int.
2852 (advance_to_char_boundary): Return EMACS_INT, not int.
2854 * data.c (Qcompiled_function): Now static.
2856 * window.c (window_body_lines): Now static.
2858 * image.c (gif_load): Rename local to avoid shadowing.
2860 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2861 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2862 * alloc.c (make_save_value): Integer argument is now of type
2864 (mark_object): Use ptrdiff_t, not int.
2865 * lisp.h (pD): New macro.
2866 * print.c (print_object): Use it.
2868 * alloc.c: Use EMACS_INT, not int, to count objects.
2869 (total_conses, total_markers, total_symbols, total_vector_size)
2870 (total_free_conses, total_free_markers, total_free_symbols)
2871 (total_free_floats, total_floats, total_free_intervals)
2872 (total_intervals, total_strings, total_free_strings):
2873 Now EMACS_INT, not int. All uses changed.
2874 (Fgarbage_collect): Compute overall total using a double, so that
2875 integer overflow is less likely to be a problem. Check for overflow
2876 when converting back to an integer.
2877 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2878 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2879 These were 'int' variables that could overflow on 64-bit hosts;
2880 they were never used, so remove them instead of repairing them.
2881 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2882 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2883 Previously, this ceilinged at INT_MAX, but that doesn't work on
2885 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2887 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2888 (allocate_vectorlike): Check for ptrdiff_t overflow.
2889 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2890 when a (possibly-narrower) signed value would do just as well.
2891 We prefer using signed arithmetic, to avoid comparison confusion.
2893 * alloc.c: Catch some string size overflows that we were missing.
2894 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2895 for convenience in STRING_BYTES_MAX.
2896 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2897 The definition here is exact; the one in lisp.h was approximate.
2898 (allocate_string_data): Check for string overflow. This catches
2899 some instances we weren't catching before. Also, it catches
2900 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2901 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2902 and ptrdiff_t and EMACS_INT are both 64 bits.
2904 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2905 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2906 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2908 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2910 * alloc.c (Fmake_string): Check for out-of-range init.
2912 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2914 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2916 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2918 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2919 xg_get_default_scrollbar_width.
2921 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2922 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2923 (style_changed_cb): Call update_theme_scrollbar_width and call
2924 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2925 all frames (Bug#8505).
2926 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2927 Call gtk_window_set_resizable if HAVE_GTK3.
2928 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2929 and height if HAVE_GTK3 (Bug#8505).
2930 (scroll_bar_width_for_theme): New variable.
2931 (update_theme_scrollbar_width): New function.
2932 (xg_get_default_scrollbar_width): Move code to
2933 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2934 (xg_initialize): Call update_theme_scrollbar_width.
2936 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2938 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2940 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2942 * frame.c (make_frame): Call other_buffer_safely instead of
2945 * window.c (temp_output_buffer_show): Call display_buffer with
2946 second argument Vtemp_buffer_show_specifiers and reset latter
2947 immediately after the call.
2948 (Vtemp_buffer_show_specifiers): New variable.
2949 (auto_window_vscroll_p, next_screen_context_lines)
2950 (Vscroll_preserve_screen_position): Remove leading asterisks from
2953 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2955 Fix minor problems found by GCC 4.6.0 static checking.
2956 * buffer.c (Qclone_number): Remove for now, as it's unused.
2957 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2958 (record_buffer): Remove unused local.
2959 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2960 (set_frame_buffer_list): Remove; unused.
2961 * frame.h (other_visible_frames): Remove decl.
2962 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2963 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2964 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2966 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2967 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2968 Define only if HAVE_GPM.
2969 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2970 (update_hints_inhibit): Remove; never set. All uses removed.
2971 * widgetprv.h (emacsFrameClassRec): Remove decl.
2972 * window.c (delete_deletable_window): Now returns void, since it
2973 wasn't returning anything.
2974 (compare_window_configurations): Remove unused locals.
2975 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2976 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2977 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2978 the same widths as pointers. This follows up on the 2011-05-06 patch.
2979 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2980 * xterm.h: Likewise.
2981 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2983 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2985 * makefile.w32-in: Update dependencies.
2986 (LISP_H): Add lib/intprops.h.
2988 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2990 * image.c (gif_load): Add animation frame delay to the metadata.
2991 (syms_of_image): Use DEFSYM. New symbol `delay'.
2993 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2995 * window.c (delete_deletable_window): Re-add.
2996 (Fset_window_configuration): Rewrite to handle dead buffers and
2997 consequently deletable windows.
2998 (window_tree, Fwindow_tree): Remove. Supply functionality in
3000 (compare_window_configurations): Simplify code.
3002 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3004 * image.c (imagemagick_load_image): Fix type mismatch.
3005 (Fimagemagick_types): Likewise.
3007 * window.h (replace_buffer_in_windows): Declare.
3009 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3011 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3012 Qclone_number. Remove external declaration of Qdelete_window.
3013 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3015 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3016 Run Qbuffer_list_update_hook if allowed.
3017 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3018 buffer list implementation.
3019 (other_buffer_safely): New function.
3020 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3021 calls to replace_buffer_in_windows and
3022 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3024 (record_buffer): Inhibit quitting and rewrite using quittable
3025 functions. Run Qbuffer_list_update_hook if allowed.
3026 (Frecord_buffer, Funrecord_buffer): New functions.
3027 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3028 Move switch-to-buffer to window.el.
3029 (bury-buffer): Move to window.el.
3030 (Vbuffer_list_update_hook): New variable.
3032 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3035 * window.h (resize_frame_windows): Move up in code.
3036 (Fwindow_frame): Remove EXFUN.
3037 (replace_buffer_in_all_windows): Remove prototype.
3038 (replace_buffer_in_windows_safely): Add prototype.
3040 * window.c: Declare Qdelete_window static again. Move down
3041 declaration of select_count.
3042 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3043 (Fother_window): Move to window.el.
3044 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3045 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3046 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3048 (replace_buffer_in_windows): Implement by calling
3049 Qreplace_buffer_in_windows.
3050 (replace_buffer_in_all_windows): Remove with some functionality
3051 moved into replace_buffer_in_windows_safely.
3052 (replace_buffer_in_windows_safely): New function.
3053 (select_window_norecord, select_frame_norecord): Move in front
3054 of run_window_configuration_change_hook. Remove now obsolete
3056 (Fset_window_buffer): Rewrite doc-string.
3057 Call Qrecord_window_buffer.
3058 (keys_of_window): Move binding for other-window to window.el.
3060 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3062 * dispextern.h (struct image): Replace data member, whose int_val
3063 and ptr_val fields were not used by anything, with a single
3066 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3067 (gif_clear_image, gif_load, imagemagick_load_image)
3068 (gs_clear_image, gs_load): Callers changed.
3070 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3072 * buffer.h: Include <time.h>, for time_t.
3073 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3075 Fix minor problems found by static checking.
3077 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3079 Make identifiers static if they are not used in other modules.
3080 * data.c (Qcompiled_function, Qframe, Qvector):
3081 * image.c (QimageMagick, Qsvg):
3082 * minibuf.c (Qmetadata):
3083 * window.c (resize_window_check, resize_root_window): Now static.
3084 * window.h (resize_window_check, resize_root_window): Remove decls.
3086 * window.c (window_deletion_count, delete_deletable_window):
3088 (window_body_lines): Now static.
3089 (Fdelete_other_windows_internal): Mark vars as initialized.
3090 Make sure 'resize_failed' is initialized.
3091 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3092 (resize_window_apply): Remove unused local.
3093 * window.h (delete_deletable_window): Remove decl.
3095 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3096 (imagemagick_load_image): Fix pointer signedness problem by changing
3097 last arg from unsigned char * to char *. All uses changed.
3098 Also, fix a local for similar reasons.
3099 Remove unused locals. Remove locals to avoid shadowing.
3100 (fn_rsvg_handle_free): Remove; unused.
3101 (svg_load, svg_load_image): Fix pointer signedness problem.
3102 (imagemagick_load_image): Don't use garbage pointer image_wand.
3104 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3106 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3108 * image.c (gif_load): Fix omitted cast error introduced by
3111 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3113 * window.h (resize_proportionally, orig_total_lines)
3114 (orig_top_line): Remove from window structure.
3115 (set_window_height, set_window_width, change_window_heights)
3116 (Fdelete_window): Remove prototypes.
3117 (resize_frame_windows): Remove duplicate declaration.
3119 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3121 * window.h (resize_frame_windows, resize_window_check)
3122 (delete_deletable_window, resize_root_window)
3123 (resize_frame_windows): Declare prototypes.
3125 * window.c (resize_window_apply): Make definition be "static" to
3126 match the prototype.
3128 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3130 * window.c: Remove declarations of Qwindow_size_fixed,
3131 window_min_size_1, window_min_size_2, window_min_size,
3132 size_window, window_fixed_size_p, enlarge_window, delete_window.
3133 Remove static from declaration of Qdelete_window, it's
3134 temporarily needed by Fbury_buffer.
3135 (replace_window): Don't assign orig_top_line and
3137 (Fdelete_window, delete_window): Remove. Window deletion is
3138 handled by window.el.
3139 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3140 Replace Fdelete_window calls with calls to Qdelete_window.
3141 (Fdelete_other_windows): Remove. Deleting other windows is
3142 handled by window.el.
3143 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3144 handled in window.el.
3145 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3146 Window minimum sizes are handled in window.el.
3147 (shrink_windows, size_window, set_window_height)
3148 (set_window_width, change_window_heights, window_height)
3149 (window_width, CURBEG, CURSIZE, enlarge_window)
3150 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3151 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3152 handled in window.el.
3153 (make_dummy_parent): Rename to make_parent_window and give it a
3154 second argument horflag.
3155 (make_window): Don't set resize_proportionally any more.
3156 (Fsplit_window): Remove. Windows are split in window.el.
3157 (save_restore_action, save_restore_orig_size)
3158 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3159 Resize mini windows in window.el.
3160 (grow_mini_window, shrink_mini_window): Implement by calling
3161 Qresize_root_window_vertically, resize_window_check and
3162 resize_window_apply.
3163 (saved_window, Fset_window_configuration, save_window_save):
3164 Do not handle orig_top_line, orig_total_lines, and
3165 resize_proportionally.
3166 (window_min_height, window_min_width): Move to window.el.
3167 (keys_of_window): Move bindings for delete-other-windows,
3168 split-window, delete-window and enlarge-window to window.el.
3170 * buffer.c: Temporarily extern Qdelete_window.
3171 (Fbury_buffer): Temporarily call Qdelete_window instead of
3172 Fdelete_window (Fbury_buffer will move to window.el soon).
3174 * frame.c (set_menu_bar_lines_1): Remove code handling
3175 orig_top_line and orig_total_lines.
3177 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3178 set_window_height but set heights directly.
3179 (change_frame_size_1): Use resize_frame_windows.
3181 * xdisp.c (init_xdisp): Don't use set_window_height but set
3184 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3185 Use resize_frame_windows instead of change_window_heights and run
3186 run_window_configuration_change_hook.
3188 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3189 instead of change_window_heights and run
3190 run_window_configuration_change_hook.
3192 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3194 * window.c (replace_window): Rename second argument REPLACEMENT to
3195 NEW. New third argument SETFLAG. Rewrite.
3196 (delete_window, make_dummy_parent): Call replace_window with
3198 (window_list_1): Move down in code.
3199 (run_window_configuration_change_hook): Move set_buffer part
3200 before select_frame_norecord part in order to unwind correctly.
3201 Rename count1 to count.
3202 (recombine_windows, delete_deletable_window, resize_root_window)
3203 (Fdelete_other_windows_internal)
3204 (Frun_window_configuration_change_hook, make_parent_window)
3205 (resize_window_check, resize_window_apply, Fresize_window_apply)
3206 (resize_frame_windows, Fsplit_window_internal)
3207 (Fdelete_window_internal, Fresize_mini_window_internal):
3209 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3211 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3213 * window.h (window): Add some new members to window structure -
3214 normal_lines, normal_cols, new_total, new_normal, clone_number,
3215 splits, nest, prev_buffers, next_buffers.
3216 (WINDOW_TOTAL_SIZE): Move here from window.c.
3217 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3219 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3221 (make_dummy_parent): Set new members of windows structure.
3222 (make_window): Move down in code. Handle new members of window
3224 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3225 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3226 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3227 (Fset_window_prev_buffers, Fwindow_next_buffers)
3228 (Fset_window_next_buffers, Fset_window_clone_number):
3230 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3231 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3233 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3234 Argument WINDOW can be now internal window too.
3235 (Fwindow_use_time): Move up in code.
3236 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3238 (Fset_window_configuration, saved_window)
3239 (Fcurrent_window_configuration, save_window_save): Handle new
3240 members of window structure.
3241 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3242 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3243 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3244 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3245 Qget_mru_window, Qresize_root_window,
3246 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3247 Qauto_buffer_name; staticpro them.
3249 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3251 * window.c (Fwindow_total_size, Fwindow_left_column)
3252 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3253 (Fwindow_list_1): New functions.
3254 (window_box_text_cols): Replace with window_body_cols.
3255 (Fwindow_width, Fscroll_left, Fscroll_right):
3256 Use window_body_cols instead of window_box_text_cols.
3257 (delete_window, Fset_window_configuration):
3258 Call delete_all_subwindows with window as argument.
3259 (delete_all_subwindows): Take a window as argument and not a
3261 (window_loop): Remove handling of GET_LRU_WINDOW and
3263 (Fget_lru_window, Fget_largest_window): Move to window.el.
3265 * window.h: Extern window_body_cols instead of
3266 window_box_text_cols. delete_all_subwindows now takes a
3267 Lisp_Object as argument.
3269 * indent.c (compute_motion, Fcompute_motion):
3270 Use window_body_cols instead of window_box_text_cols.
3272 * frame.c (delete_frame): Call delete_all_subwindows with root
3275 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3277 * fns.c (Fputhash): Document return value.
3279 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3281 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3283 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3285 Cons<->int and similar integer overflow fixes (Bug#8794).
3287 Check for overflow when converting integer to cons and back.
3288 * charset.c (Fdefine_charset_internal, Fdecode_char):
3289 Use cons_to_unsigned to catch overflow.
3290 (Fencode_char): Use INTEGER_TO_CONS.
3291 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3292 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3293 * data.c (long_to_cons, cons_to_long): Remove.
3294 (cons_to_unsigned, cons_to_signed): New functions.
3295 These signal an error for invalid or out-of-range values.
3296 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3297 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3298 * font.c (Ffont_variation_glyphs):
3299 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3300 * lisp.h: Include <intprops.h>.
3301 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3302 (cons_to_signed, cons_to_unsigned): New decls.
3303 (long_to_cons, cons_to_long): Remove decls.
3304 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3305 (Fprimitive_undo): Use CONS_TO_INTEGER.
3306 * xfns.c (Fx_window_property): Likewise.
3307 * xselect.c: Include <limits.h>.
3308 (x_own_selection, selection_data_to_lisp_data):
3309 Use INTEGER_TO_CONS.
3310 (x_handle_selection_request, x_handle_selection_clear)
3311 (x_get_foreign_selection, Fx_disown_selection_internal)
3312 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3313 (lisp_data_to_selection_data): Use cons_to_unsigned.
3314 (x_fill_property_data): Use cons_to_signed.
3315 Report values out of range.
3317 Check for buffer and string overflow more precisely.
3318 * buffer.h (BUF_BYTES_MAX): New macro.
3319 * lisp.h (STRING_BYTES_MAX): New macro.
3320 * alloc.c (Fmake_string):
3321 * character.c (string_escape_byte8):
3322 * coding.c (coding_alloc_by_realloc):
3323 * doprnt.c (doprnt):
3324 * editfns.c (Fformat):
3326 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3327 since they may not be the same number.
3328 * editfns.c (Finsert_char):
3329 * fileio.c (Finsert_file_contents):
3330 Likewise for BUF_BYTES_MAX.
3332 * image.c: Use ptrdiff_t, not int, for sizes.
3333 (slurp_file): Switch from int to ptrdiff_t.
3335 (slurp_file): Check that file size fits in both size_t (for
3336 malloc) and ptrdiff_t (for sanity and safety).
3338 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3339 if b->modtime has its maximal value.
3341 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3343 Don't assume time_t can fit into int.
3344 * buffer.h (struct buffer.modtime): Now time_t, not int.
3345 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3346 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3348 Minor fixes for signed vs unsigned integers.
3349 * character.h (MAYBE_UNIFY_CHAR):
3350 * charset.c (maybe_unify_char):
3351 * keyboard.c (read_char, reorder_modifiers):
3352 XINT -> XFASTINT, since the integer must be nonnegative.
3353 * ftfont.c (ftfont_spec_pattern):
3354 * keymap.c (access_keymap, silly_event_symbol_error):
3355 XUINT -> XFASTINT, since the integer must be nonnegative.
3356 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3357 since it makes no difference and we prefer signed.
3358 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3359 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3362 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3364 * window.h (Fwindow_frame): Declare.
3366 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3368 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3369 (SPARE_MEMORY): Always define.
3370 (LARGE_REQUEST): Remove.
3371 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3373 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3375 * lisp.h: Move EXFUNS for Fframe_root_window,
3376 Fframe_first_window and Fset_frame_selected_window to window.h.
3378 * window.h: Move EXFUNS for Fframe_root_window,
3379 Fframe_first_window and Fset_frame_selected_window here from
3382 * frame.c (Fwindow_frame, Fframe_first_window)
3383 (Fframe_root_window, Fframe_selected_window)
3384 (Fset_frame_selected_window): Move to window.c.
3385 (Factive_minibuffer_window): Move to minibuf.c.
3386 (Fother_visible_frames_p): New function.
3388 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3390 * window.c (decode_window, decode_any_window): Move up in code.
3391 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3392 (inhibit_frame_unsplittable): Remove unused variable.
3393 (Fwindow_buffer): Move up and rewrite doc-string.
3394 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3395 (Fwindow_prev): New functions.
3396 (Fwindow_frame): Move here from frame.c. Accept any window as
3398 (Fframe_root_window, Fframe_first_window)
3399 (Fframe_selected_window): Move here from frame.c. Accept frame
3400 or arbitrary window as argument. Update doc-strings.
3401 (Fminibuffer_window): Move up in code.
3402 (Fwindow_minibuffer_p): Move up in code and simplify.
3403 (Fset_frame_selected_window): Move here from frame.c.
3405 (Fselected_window, select_window, Fselect_window): Move up in
3406 code. Minor doc-string fixes.
3408 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3410 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3411 Do not assume that spare memory exists; that assumption is valid
3412 only if SYSTEM_MALLOC.
3413 (LARGE_REQUEST): New macro, so that the issue of large requests
3414 is separated from the issue of spare memory.
3416 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3418 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3421 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3423 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3426 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3428 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3430 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3432 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3433 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3435 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3437 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3439 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3441 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3442 (x_clipboard_manager_save): Add return value.
3443 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3445 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3446 Obey Vx_select_enable_clipboard_manager. Catch errors in
3447 x_clipboard_manager_save (Bug#8779).
3448 (Vx_select_enable_clipboard_manager): New variable.
3449 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3451 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3453 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3455 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3457 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3458 in the current matrix if keep_current_p is non-zero.
3460 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3462 * bidi.c (bidi_level_of_next_char): Fix last change.
3464 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3466 Support bidi reordering of text covered by display properties.
3468 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3469 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3470 (bidi_cache_search, bidi_cache_iterator_state)
3471 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3472 (bidi_level_of_next_char, bidi_move_to_visually_next):
3473 Support character positions inside a run of characters covered by a
3475 (bidi_paragraph_init, bidi_resolve_explicit_1)
3476 (bidi_level_of_next_char): Call bidi_fetch_char and
3477 bidi_fetch_char_advance instead of FETCH_CHAR and
3479 (bidi_init_it): Initialize new members.
3480 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3482 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3483 instead of using explicit *_CHAR codes.
3484 (bidi_resolve_explicit, bidi_resolve_weak):
3485 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3486 bidirectional text is supported only in multibyte buffers.
3487 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3488 it to initialize the frame_window_p member of struct bidi_it.
3489 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3490 (bidi_resolve_explicit, bidi_resolve_weak)
3491 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3492 bidi_it->nchars is non-positive.
3493 (bidi_level_of_next_char): Don't try to lookup the cache for the
3494 next/previous character if nothing is cached there yet, or if we
3495 were just reseat()'ed to a new position.
3497 * xdisp.c (set_cursor_from_row): Set start and stop points
3498 according to the row's direction when priming the loop that looks
3499 for the glyph on which to display cursor.
3500 (single_display_spec_intangible_p): Function deleted.
3501 (display_prop_intangible_p): Reimplement to call
3502 handle_display_spec instead of single_display_spec_intangible_p.
3503 Accept 3 additional arguments needed by handle_display_spec.
3504 This fixes incorrect cursor motion across display property with complex
3505 values: lists, `(when COND...)' forms, etc.
3506 (single_display_spec_string_p): Support property values that are
3507 lists with the argument STRING its top-level element.
3508 (display_prop_string_p): Fix the condition for processing a
3509 property that is a list to be consistent with handle_display_spec.
3510 (handle_display_spec): New function, refactored from the
3511 last portion of handle_display_prop.
3512 (compute_display_string_pos): Accept additional argument
3513 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3514 value of a `display' property is a "replacing spec".
3515 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3516 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3517 the display property, but just return a value indicating whether
3518 the display property will replace the characters it covers.
3519 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3520 frame_window_p members of struct bidi_it.
3521 (compute_display_string_pos, compute_display_string_end):
3523 (push_it): Accept second argument POSITION, where pop_it should
3524 jump to continue iteration.
3525 (reseat_1): Initialize bidi_it.disp_pos.
3527 * keyboard.c (adjust_point_for_property): Adjust the call to
3528 display_prop_intangible_p to its new signature.
3530 * dispextern.h (struct bidi_it): New member frame_window_p.
3531 (bidi_init_it): Update prototypes.
3532 (display_prop_intangible_p): Update prototype.
3533 (compute_display_string_pos, compute_display_string_end):
3535 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3538 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3540 Malloc failure behavior now depends on size of allocation.
3541 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3542 * lisp.h: Change signatures accordingly.
3543 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3544 All callers changed. (Bug#8762)
3546 * gnutls.c: Use Emacs's memory allocators.
3547 Without this change, the gnutls library would invoke malloc etc.
3548 directly, which causes problems on non-SYNC_INPUT hosts, and which
3549 runs afoul of improving memory_full behavior. (Bug#8761)
3550 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3551 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3552 xfree instead of the default malloc, realloc, free.
3553 (Fgnutls_boot): No need to check for memory allocation failure,
3554 since xmalloc does that for us.
3556 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3557 * category.c (hash_get_category_set):
3558 * ccl.c (ccl_driver):
3559 * charset.c (Fdefine_charset_internal):
3560 * charset.h (struct charset.hash_index):
3561 * composite.c (get_composition_id, gstring_lookup_cache)
3562 (composition_gstring_put_cache):
3563 * composite.h (struct composition.hash_index):
3564 * dispextern.h (struct image.hash):
3565 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3566 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3567 (hashfn_equal, hashfn_user_defined, make_hash_table)
3568 (maybe_resize_hash_table, hash_lookup, hash_put)
3569 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3570 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3571 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3572 * image.c (make_image, search_image_cache, lookup_image)
3573 (xpm_put_color_table_h):
3574 * lisp.h (struct Lisp_Hash_Table):
3575 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3576 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3577 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3578 * alloc.c (allocate_vectorlike):
3579 Check for overflow in vector size calculations.
3580 * ccl.c (ccl_driver):
3581 Check for overflow when converting EMACS_INT to int.
3582 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3583 need to be updated by these changes.
3584 * fns.c (make_hash_table, maybe_resize_hash_table):
3585 Check for integer overflow with large hash tables.
3586 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3587 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3588 (SXHASH_REDUCE): New macro.
3589 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3590 Use it instead of discarding useful hash info with large hash values.
3591 (sxhash_float): New function.
3592 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3593 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3594 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3595 Rewrite to use FIXNUM_BITS, as this simplifies things.
3596 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3597 Adjust signatures to match updated version of code.
3598 (consing_since_gc): Now EMACS_INT, since a single hash table can
3599 use more than INT_MAX bytes.
3601 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3603 Make it possible to build with GCC-4.6+ -O2 -flto.
3605 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3607 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3609 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3610 Call minibuffer-inactive-mode.
3612 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3614 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3615 Update dependencies.
3617 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3619 * data.c (init_data): Remove code for UTS, this system is not
3622 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3624 Don't force ./temacs to start in terminal mode.
3626 * frame.c (make_initial_frame): Initialize faces in all cases, not
3627 only when CANNOT_DUMP is defined.
3628 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3630 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3632 * dispnew.c (add_window_display_history): Use const for the string
3633 pointer. Remove declaration, not needed.
3635 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3637 Use 'inline', not 'INLINE'.
3638 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3639 * alloc.c, fontset.c (INLINE): Remove.
3640 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3641 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3642 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3643 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3644 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3646 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3648 Make it possible to run ./temacs.
3650 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3651 syms_of_callproc does the same thing. Remove test for
3652 "initialized", do it in the caller.
3653 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3655 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3657 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3658 (read_minibuf): Use get_minibuffer.
3659 (syms_of_minibuf): Use DEFSYM.
3660 (Qmetadata): New var.
3661 * data.c (Qbuffer): Don't make it static.
3662 (syms_of_data): Use DEFSYM.
3664 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3666 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3667 (CCL_CODE_MIN): New macro.
3669 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3671 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3673 * eval.c (Qdebug): Now static.
3674 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3675 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3676 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3678 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3680 * image.c: Various fixes to ImageMagick code comments.
3681 (Fimagemagick_types): Doc fix.
3683 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3685 Minor fixes prompted by GCC 4.6.0 warnings.
3687 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3689 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3690 (x_clipboard_manager_save_all): Move extern decl to ...
3691 * xterm.h: ... here, so that it can be checked for consistency.
3693 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3695 * xselect.c (x_clipboard_manager_save_frame)
3696 (x_clipboard_manager_save_all): New functions.
3697 (Fx_clipboard_manager_save): Lisp function deleted.
3699 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3700 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3702 * xterm.h: Update prototype.
3704 2011-05-28 William Xu <william.xwl@gmail.com>
3706 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3709 2011-05-28 Jim Meyering <meyering@redhat.com>
3711 Avoid a sign-extension bug in crypto_hash_function.
3712 * fns.c (to_uchar): Define.
3713 (crypto_hash_function): Use it to convert some newly-signed
3714 variables to unsigned, to avoid sign-extension bugs. For example,
3715 without this change, (md5 "truc") would evaluate to
3716 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3717 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3718 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3720 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3722 Integer overflow fixes.
3724 * dbusbind.c: Serial number integer overflow fixes.
3725 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3726 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3727 to hold a serial number that is too large for a fixnum.
3728 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3729 Check for serial numbers out of range. Decode any serial number
3730 that was so large that it became a float. (Bug#8722)
3732 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3733 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3734 Use XFASTINT rather than XUINT when numbers are nonnegative.
3735 (xd_append_arg, Fdbus_method_return_internal):
3736 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3737 arguments, check that Lisp number is nonnegative, rather than
3738 silently wrapping negative numbers around. (Bug#8722)
3739 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3742 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3744 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3746 ccl: add integer overflow checks
3747 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3748 (IN_INT_RANGE): New macros.
3749 (ccl_driver): Use them to check for integer overflow when
3750 decoding a CCL program. Many of the new checks are whether XINT (x)
3751 fits in int; it doesn't always, on 64-bit hosts. The new version
3752 doesn't catch all possible integer overflows, but it's an
3753 improvement. (Bug#8719)
3755 * alloc.c (make_event_array): Use XINT, not XUINT.
3756 There's no need for unsigned here.
3758 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3759 This follows up to the 2011-05-06 change that substituted uintptr_t
3760 for EMACS_INT. This case wasn't caught back then.
3762 Rework Fformat to avoid integer overflow issues.
3763 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3764 now (part of C89). Include <verify.h>.
3765 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3766 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3767 (Fformat): Avoid the prepass trying to compute sizes; it was only
3768 approximate and thus did not catch overflow reliably. Instead, walk
3769 through the format just once, formatting and computing sizes as we go,
3770 checking for integer overflow at every step, and allocating a larger
3771 buffer as needed. Keep track separately whether the format is
3772 multibyte. Keep only the most-recently calculated precision, rather
3773 than them all. Record whether each argument has been converted to
3774 string. Use EMACS_INT, not int, for byte and char and arg counts.
3775 Support field widths and precisions larger than INT_MAX. Avoid
3776 sprintf's undefined behavior with conversion specifications such as %#d
3777 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3778 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3779 formatting out-of-range floating point numbers with int
3782 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3784 * data.c: Avoid integer truncation in expressions involving floats.
3785 * data.c: Include <intprops.h>.
3786 (arith_driver): When there's an integer overflow in an expression
3787 involving floating point, convert the integers to floating point
3788 so that the resulting value does not suffer from catastrophic
3789 integer truncation. For example, on a 64-bit host (* 4
3790 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3791 Do not rely on undefined behavior after integer overflow.
3793 merge count_size_as_multibyte, parse_str_to_multibyte
3794 * character.c, character.h (count_size_as_multibyte):
3795 Rename from parse_str_to_multibyte; all uses changed.
3796 Check for integer overflow.
3797 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3798 since it's now a duplicate of the other. This is more of
3799 a character than a buffer op, so better that it's in character.c.
3800 * fns.c, print.c: Adjust to above changes.
3802 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3804 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3806 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3808 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3809 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3810 (x_clipboard_manager_save): Now static.
3811 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3813 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3814 (crypto_hash_function): Now static.
3815 Fix pointer signedness problems. Avoid unnecessary initializations.
3817 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3819 * termhooks.h (Vselection_alist): Make it terminal-local.
3821 * terminal.c (create_terminal): Initialize it.
3823 * xselect.c: Support for clipboard managers.
3824 (Vselection_alist): Move to termhooks.h as terminal-local var.
3825 (LOCAL_SELECTION): New macro.
3826 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3827 (symbol_to_x_atom): Remove gratuitous arg.
3828 (x_handle_selection_request, lisp_data_to_selection_data)
3829 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3830 (x_own_selection, x_get_local_selection, x_convert_selection):
3831 New arg, specifying work frame. Use terminal-local Vselection_alist.
3832 (some_frame_on_display): Delete unused function.
3833 (Fx_own_selection_internal, Fx_get_selection_internal)
3834 (Fx_disown_selection_internal, Fx_selection_owner_p)
3835 (Fx_selection_exists_p): New optional frame arg.
3836 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3837 (x_handle_selection_clear): Don't treat other terminals with the
3838 same keyboard specially. Use the terminal-local Vselection_alist.
3839 (x_clear_frame_selections): Use Frun_hook_with_args.
3841 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3843 * xterm.h: Add support for those atoms.
3845 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3847 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3848 (converted_selections, conversion_fail_tag): New global variables.
3849 (x_selection_request_lisp_error): Free the above.
3850 (x_get_local_selection): Remove unnecessary code.
3851 (x_reply_selection_request): Args changed; handle arbitrary array
3852 of converted selections stored in converted_selections.
3853 Separate the XChangeProperty and SelectionNotify steps.
3854 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3855 (x_convert_selection): New function.
3856 (x_handle_selection_event): Simplify.
3857 (x_get_foreign_selection): Don't ignore incoming requests while
3858 waiting for an answer; this will fail when we implement
3859 SAVE_TARGETS, and seems unnecessary anyway.
3860 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3861 (Vx_sent_selection_functions): Doc fix.
3863 2011-05-26 Leo Liu <sdl.web@gmail.com>
3865 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3867 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3869 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3871 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3872 for fringe update if it has periodic bitmap.
3873 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3874 and fringe_bitmap_periodic_p.
3876 * fringe.c (get_fringe_bitmap_data): New function.
3877 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3878 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3879 row. Mark glyph row for fringe update if periodicity changed.
3881 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3882 for fringe update unless it has periodic bitmap.
3884 2011-05-25 Kenichi Handa <handa@m17n.org>
3886 * xdisp.c (get_next_display_element): Set correct it->face_id for
3887 a static composition.
3889 2011-05-24 Leo Liu <sdl.web@gmail.com>
3892 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3894 * fns.c (crypto_hash_function, Fsha1): New function.
3895 (Fmd5): Use crypto_hash_function.
3896 (syms_of_fns): Add Ssha1.
3898 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3900 * gnutls.c: Remove unused macros.
3901 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3902 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3903 Remove macros that are defined and never used.
3904 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3906 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3908 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3909 (Fx_get_selection_internal): Minor cleanup.
3910 (Fx_own_selection_internal): Rename arguments for consistency with
3913 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3915 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3917 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3919 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3921 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3923 * dispnew.c (scrolling_window): Don't exclude the case that the
3924 last enabled row in the desired matrix touches the bottom boundary.
3926 2011-05-21 Glenn Morris <rgm@gnu.org>
3928 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3929 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3930 and add some more files.
3932 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3934 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3935 report_file_error introduced by the change from 2011-05-07.
3937 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3939 * systime.h (Time): Define only if emacs is defined.
3940 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3941 where the include path doesn't have X11/X.h by default. See
3942 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3944 2011-05-20 Kenichi Handa <handa@m17n.org>
3946 * composite.c (find_automatic_composition): Fix previous change.
3948 2011-05-20 Glenn Morris <rgm@gnu.org>
3950 * lisp.mk: New file, split from Makefile.in.
3951 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3952 (shortlisp): Remove.
3953 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3955 2011-05-19 Glenn Morris <rgm@gnu.org>
3957 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3958 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3959 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3960 (lisp): Set the order to that of loadup.el.
3961 (shortlisp): Make it a copy of $lisp.
3962 (SOME_MACHINE_LISP): Remove.
3963 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3964 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3966 2011-05-18 Kenichi Handa <handa@m17n.org>
3968 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3969 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3970 (find_automatic_composition): Mostly rewrite for efficiency.
3972 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3974 * makefile.w32-in: Update dependencies.
3976 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3978 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3979 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3981 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3983 Fix some integer overflow issues, such as string length overflow.
3985 * insdel.c (count_size_as_multibyte): Check for string overflow.
3987 * character.c (lisp_string_width): Check for string overflow.
3988 Use EMACS_INT, not int, for string indexes and lengths; in
3989 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3990 the resulting string length overflows an EMACS_INT; instead,
3991 report a string overflow if no precision given. When checking for
3992 precision exhaustion, use a check that cannot possibly have
3993 integer overflow. (Bug#8675)
3994 * character.h (lisp_string_width): Adjust to new signature.
3996 * alloc.c (string_overflow): New function.
3997 (Fmake_string): Use it. This doesn't change behavior, but saves
3998 a few bytes and will simplify future changes.
3999 * character.c (string_escape_byte8): Likewise.
4000 * lisp.h (string_overflow): New decl.
4002 Fixups, following up to the user-interface timestamp change.
4003 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4004 for UI timestamps, instead of unsigned long.
4005 * msdos.c (mouse_get_pos): Likewise.
4006 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4007 * w32gui.h (Time): Define by including "systime.h" rather than by
4008 declaring it ourselves. (Bug#8664)
4010 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4011 * image.c (clear_image_cache): Likewise.
4013 * term.c (term_mouse_position): Don't assume time_t wraparound.
4015 Be more systematic about user-interface timestamps.
4016 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4017 and sometimes 'EMACS_UINT', to represent these timestamps.
4018 This change causes it to use 'Time' uniformly, as that's what X uses.
4019 This makes the code easier to follow, and makes it easier to catch
4020 integer overflow bugs such as Bug#8664.
4021 * frame.c (Fmouse_position, Fmouse_pixel_position):
4022 Use Time, not unsigned long, for user-interface timestamps.
4023 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4024 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4025 * keyboard.h (last_event_timestamp): Likewise.
4026 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4027 * menu.h (xmenu_show): Likewise.
4028 * term.c (term_mouse_position): Likewise.
4029 * termhooks.h (struct input_event.timestamp): Likewise.
4030 (struct terminal.mouse_position_hook): Likewise.
4031 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4032 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4033 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4034 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4036 * menu.h, termhooks.h: Include "systime.h", for Time.
4038 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4039 Don't assume that the difference between two unsigned long values
4040 can fit into an integer. At this point, we know button_down_time
4041 <= event->timestamp, so the difference must be nonnegative, so
4042 there's no need to cast the result if double-click-time is
4043 nonnegative, as it should be; check that it's nonnegative, just in
4044 case. This bug is triggered when events are more than 2**31 ms
4045 apart (about 25 days). (Bug#8664)
4047 * xselect.c (last_event_timestamp): Remove duplicate decl.
4048 (x_own_selection): Remove needless cast to unsigned long.
4050 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4051 that always fit in int. Use a sentinel instead of a counter, to
4052 avoid a temp and to allay GCC's concerns about possible int overflow.
4053 * frame.h (struct frame): Use int for menu_bar_items_used
4054 instead of EMACS_INT, since it always fits in int.
4056 * menu.c (grow_menu_items): Check for int overflow.
4058 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4060 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4061 Before, the code was not consistent. These values cannot exceed
4062 2**31 - 1 so there's no need to make them unsigned.
4063 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4064 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4065 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4067 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4069 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4070 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4071 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4072 presumably because the widths might not match.
4074 * window.c (size_window): Avoid needless test at loop start.
4076 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4078 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4080 2011-05-12 Drew Adams <drew.adams@oracle.com>
4082 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4084 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4086 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4087 `width' to `bar_area_x' and `bar_area_width', respectively.
4088 (x_scroll_run): Take account of fringe background extension.
4090 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4091 Rename local vars `left' and `width' to `bar_area_x' and
4092 `bar_area_width', respectively.
4093 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4094 background extension.
4096 2011-05-10 Jim Meyering <meyering@redhat.com>
4098 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4100 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4102 * image.c (Finit_image_library): Return t for built-in image types,
4103 like pbm and xbm. (Bug#8640)
4105 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4107 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4109 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4111 * w32console.c (Fset_screen_color): Doc fix.
4112 (Fget_screen_color): New function.
4113 (syms_of_ntterm): Defsubr it.
4115 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4116 unlink the temporary file if Fcall_process didn't create it in the
4118 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4119 child process will be redirected to a file specified with `:file'.
4120 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4121 cue to call_process_cleanup not to close that handle.
4123 2011-05-07 Ben Key <bkey76@gmail.com>
4125 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4126 one of two shell specific rules, either bootstrap-temacs-CMD or
4127 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4128 to the previous implementation of the bootstrap-temacs rule.
4129 The bootstrap-temacs-CMD rule is similar to the previous
4130 implementation of the bootstrap-temacs rule except that it
4131 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4134 These changes, along with some changes to nt/configure.bat,
4135 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4136 earlier fix to add support for --cflags and --ldflags options
4137 that include quotes so that it works whether make uses cmd or
4140 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4142 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4143 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4145 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4146 a string. Handle both cases.
4147 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4148 (Fdbus_register_method): Use Qinvalid_function.
4150 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4152 * makefile.w32-in: Update dependencies.
4153 (LISP_H): Add inttypes.h and stdin.h.
4154 (PROCESS_H): Add unistd.h.
4156 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4158 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4159 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4161 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4163 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4165 * term.c (vfatal): Remove stray call to va_end.
4166 It's not needed and the C Standard doesn't allow it here anyway.
4168 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4169 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4171 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4174 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4178 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4180 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4182 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4184 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4185 * charset.c (Fdefine_charset_internal): Don't initialize
4186 charset.code_space[15]. The value was garbage, on hosts with
4187 32-bit int (Bug#8600).
4189 * lread.c (read_integer): Be more consistent with string-to-number.
4190 Use string_to_number to do the actual conversion; this avoids
4191 rounding errors and fixes some other screwups. Without this fix,
4192 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4193 (digit_to_number): Move earlier, for benefit of read_integer.
4194 Return -1 if the digit is out of range for the base, -2 if it is
4195 not a digit in any supported base. (Bug#8602)
4197 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4199 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4200 to match comment at start of function. This also removes a
4201 GCC warning about overflow in a 32+64-bit port.
4203 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4205 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4206 Reported by Stefan Monnier in
4207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4208 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4209 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4211 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4212 (EMACS_UINTPTR): Likewise, with uintptr_t.
4214 * lisp.h: Prefer 64-bit EMACS_INT if available.
4215 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4216 on 32-bit hosts that have 64-bit int, so that they can access
4218 However, temporarily disable this change unless the temporary
4219 symbol WIDE_EMACS_INT is defined.
4221 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4223 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4224 This removes an assumption that EMACS_INT and long are the same
4225 width as pointers. The assumption is true for Emacs porting targets
4226 now, but we want to make other targets possible.
4227 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4228 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4229 In the rest of the code, change types of integers that hold casted
4230 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4231 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4232 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4233 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4234 No need to cast type when ORing.
4235 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4236 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4237 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4238 assume EMACS_INT is the same width as char *.
4239 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4240 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4241 Remove no-longer-needed casts.
4242 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4243 (xg_tool_bar_help_callback, xg_make_tool_item):
4244 Use EMACS_INTPTR to hold an integer
4245 that will be cast to void *; this can avoid a GCC warning
4246 if EMACS_INT is not the same width as void *.
4247 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4248 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4249 (current_message_1, set_message_1):
4250 Use a local to convert to proper width without a cast.
4251 * xmenu.c (dialog_selection_callback): Likewise.
4253 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4254 Also, don't assume VALBITS / RAND_BITS is less than 5,
4255 and don't rely on undefined behavior when shifting a 1 left into
4257 * lisp.h (get_random): Change signature to match.
4259 * lread.c (hash_string): Use size_t, not int, for hash computation.
4260 Normally we prefer signed values; but hashing is special, because
4261 it's better to use unsigned division on hash table sizes so that
4262 the remainder is nonnegative. Also, size_t is the natural width
4263 for hashing into memory. The previous code used 'int', which doesn't
4264 retain enough info to hash well into very large tables.
4265 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4267 * dbusbind.c: Don't possibly lose pointer info when converting.
4268 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4269 Use XPNTR rather than XHASH, so that the high-order bits of
4270 the pointer aren't lost when converting through void *.
4272 * eval.c (Fautoload): Don't double-shift a pointer.
4274 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4276 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4278 * gnutls.c (DEF_GNUTLS_FN):
4279 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4281 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4283 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4286 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4288 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4289 New version that can reserve upto 2GB of heap space.
4291 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4293 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4295 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4297 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4298 `gnutls_certificate_set_x509_key_file'.
4300 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4302 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4303 Update dependencies.
4305 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4307 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4308 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4309 Remove unused parameter `fildes'.
4310 * process.c (read_process_output, send_process): Don't pass it.
4312 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4314 Fix previous change: the library cache is defined in w32.c.
4315 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4316 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4318 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4320 Implement dynamic loading of GnuTLS on Windows.
4322 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4323 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4324 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4327 * gnutls.c (Qgnutls_dll): Define.
4328 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4329 (gnutls_*): Declare function pointers.
4330 (init_gnutls_functions): New function to initialize function pointers.
4331 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4332 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4333 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4334 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4335 (emacs_gnutls_write, emacs_gnutls_read)
4336 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4337 (Fgnutls_available_p): New function.
4338 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4339 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4340 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4342 * image.c: Include w32.h.
4343 (Vimage_type_cache): Delete.
4344 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4345 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4346 (w32_delayed_load): Move to w32.c.
4348 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4350 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4351 (w32_delayed_load): Move from image.c. When loading a library, record
4352 its filename in the :loaded-from property of the library id.
4353 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4354 Initialize and staticpro them.
4355 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4357 * process.c: Include lisp.h before w32.h, not after.
4358 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4359 instead of gnutls_record_check_pending.
4361 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4363 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4365 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4366 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4369 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4371 * xterm.c (x_set_frame_alpha): Do not set property on anything
4372 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4374 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4376 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4378 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4380 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4381 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4382 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4383 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4384 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4385 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4386 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4387 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4388 (Qgnutls_bootprop_callbacks_verify): Make static.
4390 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4392 * callproc.c: Indentation fixup.
4394 * sysdep.c (wait_for_termination_1): Make static.
4395 (wait_for_termination, interruptible_wait_for_termination):
4396 Move after wait_for_termination_1.
4398 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4400 * sysdep.c (interruptible_wait_for_termination): New function
4401 which is like wait_for_termination, but allows keyboard
4404 * callproc.c (Fcall_process): Add (:file "file") as an option for
4406 (Fcall_process_region): Ditto.
4408 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4410 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4411 rather than `XVECTOR (FOO)->size'.
4413 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4414 inttypes.h, as a gnulib replacement is used if it not available in
4417 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4419 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4420 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4421 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4423 * coding.c (coding_alloc_by_realloc): Error out if destination
4424 will grow beyond MOST_POSITIVE_FIXNUM.
4425 (decode_coding_emacs_mule): Abort if there isn't enough place in
4426 charbuf for the composition carryover bytes. Reserve an extra
4427 space for up to 2 characters produced in a loop.
4428 (decode_coding_iso_2022): Abort if there isn't enough place in
4429 charbuf for the composition carryover bytes.
4431 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4433 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4434 aborting when %lld or %lll format is passed.
4435 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4436 %llo or %llx format is passed. (Bug#8545)
4438 * window.c (window_scroll_line_based): Use a marker instead of
4439 simple variables to record original value of point. (Bug#7952)
4441 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4442 produced by %s or %c overflows available buffer space. (Bug#8545)
4444 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4446 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4447 (SIZE_MAX): Move defn after all includes, as they might #define it.
4449 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4451 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4453 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4455 * keyboard.c (Qdelayed_warnings_hook): Define.
4456 (command_loop_1): Run `delayed-warnings-hook'
4457 if Vdelayed_warnings_list is non-nil.
4458 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4459 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4461 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4463 * doprnt.c (doprnt): Don't return value smaller than the buffer
4464 size if the message was truncated. (Bug#8545).
4466 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4468 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4469 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4471 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4473 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4475 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4477 * makefile.w32-in: Update dependencies.
4479 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4481 Improve `doprnt' and its usage. (Bug#8545)
4482 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4483 `format_end'. Remove support for %l as a conversion specifier.
4484 Don't use xrealloc. Improve diagnostics when the %l size modifier
4485 is used. Update the commentary.
4487 * eval.c (verror): Simplify calculation of size_t.
4489 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4492 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4494 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4497 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4499 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4500 This makes this file independent of the recent pseudovector change.
4502 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4504 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4506 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4507 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4508 Remove unused local.
4509 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4511 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4512 GCC 4.6.0 optimizes based on type-based alias analysis.
4513 For example, if b is of type struct buffer * and v of type struct
4514 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4515 != &v->size, and therefore "v->size = 1; b->size = 2; return
4516 v->size;" must therefore return 1. This assumption is incorrect
4517 for Emacs, since it type-puns struct Lisp_Vector * with many other
4518 types. To fix this problem, this patch adds a new type struct
4519 vectorlike_header that documents the constraints on layout of vectors
4520 and pseudovectors, and helps optimizing compilers not get fooled
4521 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4522 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4523 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4525 (XSETPVECTYPE): Rewrite in terms of new macro.
4526 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4527 This is a bit clearer, and further avoids the possibility of
4528 undesirable aliasing.
4529 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4530 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4531 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4532 since Lisp_Subr is a special case (no "next" field).
4533 (ASIZE): Now uses header.size rather than size.
4534 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4535 to avoid the hassle of writing XVECTOR (foo)->header.size.
4536 (struct vectorlike_header): New type.
4537 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4538 object, to help avoid aliasing.
4539 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4540 (SUBRP): Likewise, since Lisp_Subr is a special case.
4541 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4542 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4543 (struct Lisp_Hash_Table): Combine first two members into a single
4544 struct vectorlike_header member. All uses of "size" and "next" members
4545 changed to be "header.size" and "header.next".
4546 * buffer.h (struct buffer): Likewise.
4547 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4548 * frame.h (struct frame): Likewise.
4549 * process.h (struct Lisp_Process): Likewise.
4550 * termhooks.h (struct terminal): Likewise.
4551 * window.c (struct save_window_data, struct saved_window): Likewise.
4552 * window.h (struct window): Likewise.
4553 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4554 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4555 * buffer.c (init_buffer_once): Likewise.
4556 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4558 * process.c (Fformat_network_address): Use local var for size,
4561 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4563 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4564 * data.c (atof): Remove decl; no longer used or needed.
4565 (digit_to_number): Move to lread.c.
4566 (Fstring_to_number): Use new string_to_number function, to be
4567 consistent with how the Lisp reader treats infinities and NaNs.
4568 Do not assume that floating-point numbers represent EMACS_INT
4569 without losing information; this is not true on most 64-bit hosts.
4570 Avoid double-rounding errors, by insisting on integers when
4571 parsing non-base-10 numbers, as the documentation specifies.
4572 * lisp.h (string_to_number): New decl, replacing ...
4573 (isfloat_string): Remove.
4574 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4575 (read1): Do not accept +. and -. as integers; this
4576 appears to have been a coding error. Similarly, do not accept
4577 strings like +-1e0 as floating point numbers. Do not report
4578 overflow for integer overflows unless the base is not 10 which
4579 means we have no simple and reliable way to continue.
4580 Break out the floating-point parsing into a new
4581 function string_to_number, so that Fstring_to_number parses
4582 floating point numbers consistently with the Lisp reader.
4583 (digit_to_number): Move here from data.c. Make it static inline.
4584 (E_CHAR, EXP_INT): Remove, replacing with ...
4585 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4586 (string_to_number): New function, replacing isfloat_string.
4587 This function checks for valid syntax and produces the resulting
4588 Lisp float number too. Rework it so that string-to-number
4589 no longer mishandles examples like "1.0e+". Use strtoumax,
4590 so that overflow for non-base-10 numbers is reported only when
4591 there's no portable and simple way to convert to floating point.
4593 * textprop.c (set_text_properties_1): Rewrite for clarity,
4594 and to avoid GCC warning about integer overflow.
4596 * intervals.h (struct interval): Use EMACS_INT for members
4597 where EMACS_UINT might cause problems. See
4598 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4599 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4600 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4602 (offset_intervals): Tell GCC not to worry about length overflow
4603 when negating a negative length.
4605 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4606 (overrun_check_free): Likewise.
4608 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4609 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4612 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4613 (gnutls_make_error): Rename local to avoid shadowing.
4614 (gnutls_emacs_global_deinit): ifdef out; not used.
4615 (Fgnutls_boot): Use const for pointer to readonly storage.
4616 Comment out unused local. Fix pointer signedness problems.
4618 * lread.c (openp): Don't stuff size_t into an 'int'.
4619 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4620 about possible signed overflow.
4622 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4623 (GDK_KEY_g): Don't define if already defined.
4624 (xg_prepare_tooltip): Avoid pointer signedness problem.
4625 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4627 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4628 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4630 * xfns.c (Fx_window_property): Simplify a bit,
4631 to make a bit faster and to avoid GCC 4.6.0 warning.
4632 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4634 * fns.c (internal_equal): Don't assume size_t fits in int.
4636 * alloc.c (compact_small_strings): Tighten assertion a little.
4638 Replace pEd with more-general pI, and fix some printf arg casts.
4639 * lisp.h (pI): New macro, generalizing old pEd macro to other
4640 conversion specifiers. For example, use "...%"pI"d..." rather
4641 than "...%"pEd"...".
4642 (pEd): Remove. All uses replaced with similar uses of pI.
4643 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4644 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4645 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4646 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4647 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4648 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4649 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4651 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4652 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4653 * print.c (safe_debug_print, print_object): Likewise.
4654 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4656 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4657 avoiding the 0 flag, which is not portable.
4658 * process.c (Fmake_network_process): Use pI to avoid cast.
4659 * region-cache.c (pp_cache): Likewise.
4660 * xdisp.c (decode_mode_spec): Likewise.
4661 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4662 behavior on 64-bit hosts with printf arg.
4663 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4664 (x_stop_queuing_selection_requests): Likewise.
4665 (x_get_window_property): Don't truncate byte count to an 'int'
4668 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4669 here, since it parses constructs like leading '-' and spaces,
4670 which are not wanted; and it overflows with large numbers.
4671 Instead, simply match F[0-9]+, which is what is wanted anyway.
4673 * alloc.c: Remove unportable assumptions about struct layout.
4674 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4675 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4676 (allocate_vectorlike, make_pure_vector): Use the new macros,
4677 plus offsetof, to remove unportable assumptions about struct layout.
4678 These assumptions hold on all porting targets that I know of, but
4679 they are not guaranteed, they're easy to remove, and removing them
4680 makes further changes easier.
4682 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4683 This doesn't fix a bug but makes the code clearer.
4684 (string_overrun_cookie): Now const. Use initializers that
4685 don't formally overflow signed char, to avoid warnings.
4686 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4687 can cause Emacs to crash when string overrun checking is enabled.
4688 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4689 multiple of sizeof (EMACS_INT); it need not be, if
4690 alignof(EMACS_INT) < sizeof (EMACS_INT).
4691 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4693 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4695 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4697 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4699 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4700 supposed to be handshaking. (Bug#8556)
4701 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4703 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4705 * lisp.h (Qdebug): List symbol.
4706 * eval.c (Qdebug): Restore global linkage.
4707 * keyboard.c (debug-on-event): New variable.
4708 (handle_user_signal): Break into debugger when debug-on-event
4709 matches the current signal symbol.
4711 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4713 * alloc.c (check_sblock, check_string_bytes)
4714 (check_string_free_list): Convert to standard C.
4716 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4718 * w32.c (emacs_gnutls_push): Fix typo.
4720 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4722 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4723 "cast to pointer from integer of different size".
4725 Improve doprnt and its use in verror. (Bug#8545)
4726 * doprnt.c (doprnt): Document the set of format control sequences
4727 supported by the function. Use SAFE_ALLOCA instead of always
4730 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4731 is one byte too soon. Don't use xrealloc; instead xfree and
4734 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4736 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4739 * gnutls.c: Renamed global_initialized to
4740 gnutls_global_initialized. Added internals for the
4741 :verify-hostname-error, :verify-error, and :verify-flags
4742 parameters of `gnutls-boot' and documented those parameters in the
4743 docstring. Start callback support.
4744 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4745 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4746 on error. Return error code.
4747 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4748 (emacs_gnutls_read): Likewise.
4749 (Fgnutls_boot): Return handshake error code.
4750 (emacs_gnutls_handle_error): New function.
4751 (wsaerror_to_errno): Likewise.
4753 * w32.h (emacs_gnutls_pull): Add prototype.
4754 (emacs_gnutls_push): Likewise.
4756 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4757 (emacs_gnutls_push): Likewise.
4759 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4761 * process.c (wait_reading_process_output): Check if GnuTLS
4762 buffered some data internally if no FDs are set for TLS
4765 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4766 (LIBS): Link to USER_LIBS.
4767 ($(BLD)/gnutls.$(0)): New target.
4769 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4771 * xdisp.c (handle_single_display_spec): Rename the
4772 display_replaced_before_p argument into display_replaced_p, to
4773 make it consistent with the commentary. Fix typos in the
4776 * textprop.c (syms_of_textprop): Remove dead code.
4777 (copy_text_properties): Delete obsolete commentary about an
4778 interface that was deleted long ago. Fix typos in the description
4781 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4782 to changes in oldXMenu/XMenu.h from 2011-04-16.
4783 <menu_help_message, prev_menu_help_message>: Constify.
4784 (IT_menu_make_room): menu->help_text is now `const char **';
4787 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4788 to changes in oldXMenu/XMenu.h from 2011-04-16.
4789 (struct XMenu): Declare `help_text' `const char **'.
4791 * xfaces.c <Qunspecified>: Make extern again.
4793 * syntax.c: Include sys/types.h before including regex.h, as
4796 * doc.c (get_doc_string): Improve the format passed to `error'.
4798 * doprnt.c (doprnt): Improve commentary.
4800 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4802 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4805 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4806 changes in globals.h immediately force recompilation.
4807 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4808 $(CURDIR)/s/ms-w32.h.
4809 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4811 * character.c (Fchar_direction): Function deleted.
4812 (syms_of_character): Don't defsubr it.
4813 <char-direction-table>: Deleted.
4815 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4817 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4818 * doprnt.c: Include limits.h.
4819 (SIZE_MAX): New macro.
4820 (doprnt): Return a size_t value. 2nd arg is now size_t.
4821 Many local variables are now size_t instead of int or unsigned.
4822 Improve overflow protection. Support `l' modifier for integer
4823 conversions. Support %l conversion. Don't assume an EMACS_INT
4824 argument for integer conversions and for %c.
4826 * lisp.h (doprnt): Restore prototype.
4828 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4831 * Makefile.in (base_obj): Add back doprnt.o.
4833 * deps.mk (doprnt.o): Add back prerequisites.
4834 (callint.o): Depend on character.h.
4836 * eval.c (internal_lisp_condition_case): Include the handler
4837 representation in the error message.
4838 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4839 when breaking from the loop.
4841 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4843 * callint.c (Fcall_interactively): When displaying error message
4844 about invalid control letter, pass the character's codepoint, not
4845 a pointer to its multibyte form. Improve display of the character
4846 in octal and display also its hex code.
4848 * character.c (char_string): Use %x to display the (unsigned)
4849 codepoint of an invalid character, to avoid displaying a bogus
4852 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4853 `error', not SYMBOL_NAME itself.
4855 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4856 character arguments to `error'.
4858 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4859 to `error' in error message about FINAL_CHAR argument. Make sure
4860 FINAL_CHAR is a character, and use %c when it is passed as
4861 argument to `error'.
4863 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4865 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4867 * w32.c: Include <time.h>.
4868 (sys_localtime): New function.
4870 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4872 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4874 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4876 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4878 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4881 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4883 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4884 gl_state.e_property when gl_state.object is Qt.
4886 * insdel.c (make_gap_larger): Remove limitation of buffer size
4889 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4891 * xdisp.c (lookup_glyphless_char_display)
4892 (produce_glyphless_glyph): Handle cons cell entry in
4893 glyphless-char-display.
4894 (Vglyphless_char_display): Document it.
4896 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4897 glyphless-char-display.
4899 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4901 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4903 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4905 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4906 definition for no-X builds.
4908 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4910 Static checks with GCC 4.6.0 and non-default toolkits.
4912 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4914 * process.c (keyboard_bit_set): Define only if SIGIO.
4915 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4916 (send_process): Repair possible setjmp clobbering.
4918 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4920 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4922 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4924 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4925 Define only if needed.
4927 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4928 by pacifying GCC about it. Maybe it's time to retire it?
4929 * xfaces.c (USG, __TIMEVAL__): Likewise.
4931 * dispextern.h (struct redisplay_interface): Rename param
4933 * termhooks.h (struct terminal): Likewise.
4934 * xterm.c (xembed_send_message): Likewise.
4936 * insdel.c (make_gap_smaller): Define only if
4937 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4939 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4942 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4943 so that we aren't warned about unused symbols.
4945 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4947 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4949 * xfns.c (x_real_positions): Mark locals as initialized.
4951 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4953 * xterm.c: Fix problems found by static analysis with other toolkits.
4954 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4955 (x_dispatch_event): Declare static if USE_GTK, and
4956 define if USE_GTK || USE_X_TOOLKIT.
4957 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4958 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4959 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4960 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4962 * xmenu.c (menu_help_callback): Pointer type fixes.
4963 Use const pointers when pointing at readonly data. Avoid pointer
4965 (FALSE): Remove unused macro.
4966 (update_frame_menubar): Remove unused decl.
4968 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4970 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4971 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4972 (single_menu_item): Rename local to avoid shadowing.
4974 * keyboard.c (make_lispy_event): Remove unused local var.
4976 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4977 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4979 * bitmaps: Change bitmaps from unsigned char back to the X11
4980 compatible char. Avoid the old compiler warnings about
4981 out-of-range initializers by using, for example, '\xab' rather
4984 * xgselect.c (xgselect_initialize): Check vs interface
4985 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4987 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4989 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4990 to read-only memory.
4992 * fns.c (vector): Remove; this old hack is no longer needed.
4994 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4996 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4998 * xrdb.c (x_load_resources): Omit unused local.
5000 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5001 (x_window): Rename locals to avoid shadowing.
5002 (USG): Use the kludged USG macro, to pacify gcc.
5004 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5005 (x_term_init): Remove local to avoid shadowing.
5007 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5009 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5010 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5012 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5014 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5016 Fix regex.c, syntax.c and friends for buffers > 2GB.
5017 * syntax.h (struct gl_state_s): Declare character position members
5020 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5022 * textprop.c (verify_interval_modification, interval_of):
5023 Declare arguments EMACS_INT.
5025 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5028 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5030 * indent.c (Fvertical_motion): Local variable it_start is now
5033 * regex.c (re_match, re_match_2, re_match_2_internal)
5034 (bcmp_translate, regcomp, regexec, print_double_string)
5035 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5036 (re_compile_pattern, re_exec): Declare arguments and local
5037 variables `size_t' and `ssize_t' and return values `regoff_t', as
5039 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5040 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5041 <compile_stack_type>: `size' and `avail' are now `size_t'.
5043 * regex.h <regoff_t>: Use ssize_t, not int.
5044 (re_search, re_search_2, re_match, re_match_2): Arguments that
5045 specify buffer/string position and length are now ssize_t and
5046 size_t. Return type is regoff_t.
5048 2011-04-16 Ben Key <bkey76@gmail.com>
5050 * nsfont.m: Fixed bugs in ns_get_family and
5051 ns_descriptor_to_entity that were caused by using free to
5052 deallocate memory blocks that were allocated by xmalloc (via
5053 xstrdup). This caused Emacs to crash when compiled with
5054 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5055 --enable-checking=xmallocoverrun). xfree is now used to
5056 deallocate these memory blocks.
5058 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5060 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5062 emacs_write: Accept and return EMACS_INT for sizes.
5063 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5065 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5066 Accept and return EMACS_INT.
5067 (emacs_gnutls_write): Return the number of bytes written on
5069 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5070 (emacs_read, emacs_write): Remove check for negative size, as the
5071 Emacs source code has been audited now.
5072 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5073 (emacs_read, emacs_write): Use it.
5074 * process.c (send_process): Adjust to the new signatures of
5075 emacs_write and emacs_gnutls_write. Do not attempt to store
5076 a byte offset into an 'int'; it might overflow.
5077 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5079 * sound.c: Don't assume sizes fit in 'int'.
5080 (struct sound_device.period_size, alsa_period_size):
5081 Return EMACS_INT, not int.
5082 (struct sound_device.write, vox_write, alsa_write):
5083 Accept EMACS_INT, not int.
5084 (wav_play, au_play): Use EMACS_INT to store sizes and to
5085 record read return values.
5087 2011-04-15 Ben Key <bkey76@gmail.com>
5089 * keyboard.c (Qundefined): Don't declare static since it is used
5091 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5092 static since they are used in nsfont.m.
5094 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5096 * process.c (Qprocessp): Don't declare static.
5097 * lisp.h (Qprocessp): Declare again.
5099 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5101 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5103 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5105 Improve C-level modularity by making more things 'static'.
5107 Don't publish debugger-only interfaces to other modules.
5108 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5109 (verify_bytepos, count_markers): Move decls to the only modules
5111 * region-cache.h (pp_cache): Likewise.
5112 * window.h (check_all_windows): Likewise.
5113 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5115 * sysdep.c (croak): Now static, if
5116 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5117 * syssignal.h (croak): Declare only if not static.
5119 * alloc.c (refill_memory_reserve): Now static if
5120 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5121 * lisp.h (refill_memory_reserve): Declare only if not static.
5123 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5124 Define only if USE_LUCID.
5126 * xrdb.c (x_customization_string, x_rm_string): Now static.
5128 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5129 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5131 * xdisp.c (draw_row_with_mouse_face): Now static.
5132 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5134 * window.h (check_all_windows): Mark externally visible.
5136 * window.c (window_deletion_count): Now static.
5138 * undo.c: Make symbols static if they're not exported.
5139 (last_undo_buffer, last_boundary_position, pending_boundary):
5142 * textprop.c (interval_insert_behind_hooks): Now static.
5143 (interval_insert_in_front_hooks): Likewise.
5145 * term.c: Make symbols static if they're not exported.
5146 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5147 (max_frame_lines, tty_set_terminal_modes):
5148 (tty_reset_terminal_modes, tty_turn_off_highlight):
5149 (get_tty_terminal): Now static.
5150 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5151 * termhooks.h (term_mouse_moveto): Do not declare if
5153 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5154 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5156 * sysdep.c: Make symbols static if they're not exported.
5157 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5159 (sigprocmask_set, full_mask): Remove; unused.
5160 (wait_debugging): Mark as visible.
5161 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5162 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5164 * syntax.c (syntax_temp): Define only if !__GNUC__.
5166 * sound.c (current_sound_device, current_sound): Now static.
5168 * search.c (searchbufs, searchbuf_head): Now static.
5170 * scroll.c (scroll_cost): Remove; unused.
5171 * dispextern.h (scroll_cost): Remove decl.
5173 * region-cache.h (pp_cache): Mark as externally visible.
5175 * process.c: Make symbols static if they're not exported.
5176 (process_tick, update_tick, create_process, chan_process):
5177 (Vprocess_alist, proc_buffered_char, datagram_access):
5178 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5179 (deactivate_process): Mark defn as static, as well as decl.
5180 * lisp.h (create_process): Remove decl.
5181 * process.h (chan_process, Vprocess_alist): Remove decls.
5183 * print.c: Make symbols static if they're not exported.
5184 (print_depth, new_backquote_output, being_printed, print_buffer):
5185 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5186 (print_interval, print_number_index, initial_stderr_stream):
5188 * lisp.h (Fprinc): Remove decl.
5189 (debug_output_compilation_hack): Mark as externally visible.
5191 * sysdep.c (croak): Move decl from here to syssignal.h.
5192 * syssignal.h (croak): Put it here, so the API can be checked when
5193 'croak' is called from dissociate_if_controlling_tty.
5195 * minibuf.c: Make symbols static if they're not exported.
5196 (minibuf_save_list, choose_minibuf_frame): Now static.
5197 * lisp.h (choose_minibuf_frame): Remove decl.
5199 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5201 * lread.c: Make symbols static if they're not exported.
5202 (read_objects, initial_obarray, oblookup_last_bucket_number):
5204 (make_symbol): Remove; unused.
5205 * lisp.h (initial_obarray, make_symbol): Remove decls.
5207 * keyboard.c: Make symbols static if they're not exported.
5208 (single_kboard, recent_keys_index, total_keys, recent_keys):
5209 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5210 (this_single_command_key_start, echoing, last_auto_save):
5211 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5212 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5213 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5214 (Vlispy_mouse_stem, double_click_count):
5216 (force_auto_save_soon): Define only if SIGDANGER.
5217 (ignore_mouse_drag_p): Now static if
5218 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5219 (print_help): Remove; unused.
5220 (stop_character, last_timer_event): Mark as externally visible.
5221 * keyboard.h (ignore_mouse_drag_p): Declare only if
5222 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5223 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5224 * lisp.h (echoing): Remove decl.
5225 (force_auto_save_soon): Declare only if SIGDANGER.
5226 * xdisp.c (redisplay_window): Simplify code, to make it more
5227 obvious that ignore_mouse_drag_p is not accessed if !defined
5228 USE_GTK && !defined HAVE_NS.
5230 * intervals.c: Make symbols static if they're not exported.
5231 (merge_properties_sticky, merge_interval_right, delete_interval):
5233 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5235 * insdel.c: Make symbols static if they're not exported.
5236 However, leave prepare_to_modify_buffer alone. It's never
5237 called from outside this function, but that appears to be a bug.
5238 (combine_after_change_list, combine_after_change_buffer):
5239 (adjust_after_replace, signal_before_change): Now static.
5240 (adjust_after_replace_noundo): Remove; unused.
5241 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5242 (signal_before_change): Remove decls.
5244 * indent.c (val_compute_motion, val_vmotion): Now static.
5246 * image.c: Make symbols static if they're not exported.
5247 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5249 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5250 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5252 * fringe.c (standard_bitmaps): Now static.
5253 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5255 * frame.c: Make symbols static if they're not exported.
5256 (x_report_frame_params, make_terminal_frame): Now static.
5257 (get_frame_param): Now static, unless HAVE_NS.
5258 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5259 (x_get_resource_string): Remove; not used.
5260 * frame.h (make_terminal_frame, x_report_frame_params):
5261 (x_get_resource_string); Remove decls.
5262 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5263 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5265 * font.c, fontset.c: Make symbols static if they're not exported.
5266 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5267 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5268 * font.c (font_close_object): Now static.
5269 * font.h (font_close_object): Remove.
5270 * fontset.c (FONTSET_OBJLIST): Remove.
5271 (free_realized_fontset) #if-0 the body, which does nothing.
5272 (face_suitable_for_char_p): #if-0, as it's never called.
5273 * fontset.h (face_suitable_for_char_p): Remove decl.
5274 * xfaces.c (face_at_string_position):
5275 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5276 since 0 is always ASCII.
5278 * fns.c (weak_hash_tables): Now static.
5280 * fileio.c: Make symbols static if they're not exported.
5281 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5282 (Vwrite_region_annotation_buffers): Now static.
5284 * eval.c: Make symbols static if they're not exported.
5285 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5286 * lisp.h (backtrace_list): Remove decl.
5288 * emacs.c: Make symbols static if they're not exported.
5289 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5290 (fatal_error_code, fatal_error_signal_hook, standard_args):
5292 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5293 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5294 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5295 * lisp.h (fatal_error_signal_hook): Remove decl.
5296 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5298 * editfns.c: Move a (normally-unused) function to its only use.
5299 * editfns.c, lisp.h (get_operating_system_release): Remove.
5300 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5301 worth the hassle of breaking this out.
5303 * xterm.c: Make symbols static if they're not exported.
5304 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5305 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5306 (x_destroy_window, x_delete_display):
5308 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5309 (x_mouse_leave): Remove; unused.
5310 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5311 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5312 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5314 (x_mouse_leave): Declare only if WINDOWSNT.
5315 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5316 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5319 * ftxfont.c: Make symbols static if they're not exported.
5320 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5322 * font.h (ftxfont_driver): Likewise.
5324 * xfns.c: Make symbols static if they're not exported.
5325 (x_last_font_name, x_display_info_for_name):
5326 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5327 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5328 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5329 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5330 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5331 (last_show_tip_args): Now static.
5332 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5333 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5334 (x_screen_planes): Remove; unused.
5335 * dispextern.h (x_screen_planes): Remove decl.
5337 * dispnew.c: Make symbols static if they're not exported.
5338 * dispextern.h (redraw_garbaged_frames, scrolling):
5339 (increment_row_positions): Remove.
5340 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5341 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5343 (redraw_garbaged_frames): Remove; unused.
5345 * xfaces.c: Make symbols static if they're not exported.
5346 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5348 * xterm.h (defined_color): Remove decls.
5349 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5350 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5351 (menu_face_changed_default, defined_color, free_realized_face):
5352 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5353 (ascii_face_of_lisp_face): Remove; unused.
5355 * xdisp.c: Make symbols static if they're not exported.
5356 * dispextern.h (scratch_glyph_row, window_box_edges):
5357 (glyph_to_pixel_coords, set_cursor_from_row):
5358 (get_next_display_element, set_iterator_to_next):
5359 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5360 (show_mouse_face): Remove decls
5361 * frame.h (message_buf_print): Likewise.
5362 * lisp.h (pop_message, set_message, check_point_in_composition):
5364 * xterm.h (set_vertical_scroll_bar): Likewise.
5365 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5366 (message_buf_print, scratch_glyph_row, displayed_buffer):
5367 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5368 (get_next_display_element, show_mouse_face, window_box_edges):
5369 (frame_to_window_pixel_xy, check_point_in_composition):
5370 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5371 (glyph_to_pixel_coords): Remove; unused.
5373 * dired.c (file_name_completion): Now static.
5375 * dbusbind.c (xd_in_read_queued_messages): Now static.
5377 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5378 * data.c (circular_list_error): Remove.
5380 * commands.h (last_point_position, last_point_position_buffer):
5381 (last_point_position_window): Remove decls.
5382 * keyboard.c: Make these variables static.
5384 * coding.h (coding, code_convert_region, encode_coding_gap):
5386 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5387 (iso_code_class, detect_coding, code_convert_region): Now static.
5388 (encode_coding_gap): Remove; unused.
5390 * chartab.c (chartab_chars, chartab_bits): Now static.
5392 * charset.h (charset_iso_8859_1): Remove decl.
5393 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5396 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5397 * ccl.c (Vccl_program_table): Now static.
5398 (check_ccl_update): Remove; unused.
5400 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5401 * category.h: ... from here.
5402 * category.c (check_category_table, set_category_set): Now static.
5404 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5405 * lisp.h: Remove these decls.
5407 * buffer.c (buffer_count): Remove unused var.
5409 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5410 so that it's not optimized away.
5411 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5412 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5413 exported only to the debugger.
5415 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5416 * atimer.h (run_all_atimers): Remove; not exported.
5418 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5419 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5420 was inaccessible from Lisp.
5421 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5422 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5424 alloc.c: Import and export fewer symbols, and remove unused items.
5425 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5427 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5428 it's not optimized away by whole-program optimization.
5429 (message_enable_multibyte, free_misc): Remove.
5430 (catchlist, handlerlist, mark_backtrace):
5431 Declare only if BYTE_MARK_STACK.
5432 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5433 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5434 (message_enable_multibyte): Remove decl.
5435 (free_misc, interval_free_list, float_block, float_block_index):
5436 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5437 (cons_free_list, last_marked_index):
5439 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5440 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5441 (mark_backtrace): Define only if BYTE_MARK_STACK.
5442 * xdisp.c (message_enable_multibyte): Now static.
5444 Declare Lisp_Object Q* variables to be 'static' if not exported.
5445 This makes it easier for human readers (and static analyzers)
5446 to see whether these variables are used from other modules.
5447 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5448 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5449 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5450 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5451 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5452 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5453 * xmenu.c, xselect.c:
5454 Declare Q* vars static if they are not used in other modules.
5455 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5456 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5457 Remove decls of unexported vars.
5458 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5460 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5462 Make Emacs functions such as Fatom 'static' by default.
5463 This makes it easier for human readers (and static analyzers)
5464 to see whether these functions can be called from other modules.
5465 DEFUN now defines a static function. To make the function external
5466 so that it can be used in other C modules, use the new macro DEFUE.
5467 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5468 (Finit_image_library):
5469 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5470 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5471 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5472 Remove decls, since these functions are now static.
5473 (Funintern, Fget_internal_run_time): New decls, since these functions
5474 were already external.
5476 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5477 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5478 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5479 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5480 * keyboard.c, keymap.c, lread.c:
5481 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5482 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5483 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5484 Mark functions with DEFUE instead of DEFUN,
5485 if they are used in other modules.
5486 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5487 decls for now-static functions.
5488 * buffer.h (Fdelete_overlay): Remove decl.
5489 * callproc.c (Fgetenv_internal): Mark as internal.
5490 * composite.c (Fremove_list_of_text_properties): Remove decl.
5491 (Fcomposition_get_gstring): New forward static decl.
5492 * composite.h (Fcomposite_get_gstring): Remove decl.
5493 * dired.c (Ffile_attributes): New forward static decl.
5494 * doc.c (Fdocumntation_property): New forward static decl.
5495 * eval.c (Ffetch_bytecode): New forward static decl.
5496 (Funintern): Remove extern decl; now in .h file where it belongs.
5497 * fileio.c (Fmake_symbolic_link): New forward static decl.
5498 * image.c (Finit_image_library): New forward static decl.
5499 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5500 * intervals.h (Fprevious_property_change):
5501 (Fremove_list_of_text_properties): Remove decls.
5502 * keyboard.c (Fthis_command_keys): Remove decl.
5503 (Fcommand_execute): New forward static decl.
5504 * keymap.c (Flookup_key): New forward static decl.
5505 (Fcopy_keymap): Now static.
5506 * keymap.h (Flookup_key): Remove decl.
5507 * process.c (Fget_process): New forward static decl.
5508 (Fprocess_datagram_address): Mark as internal.
5509 * syntax.c (Fsyntax_table_p): New forward static decl.
5510 (skip_chars): Remove duplicate decl.
5511 * textprop.c (Fprevious_property_change): New forward static decl.
5512 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5514 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5515 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5517 * editfns.c (Fformat): Remove unreachable code.
5519 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5521 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5524 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5526 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5527 when at ZV. (Bug#8487)
5529 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5531 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5533 * keyboard.c (parse_tool_bar_item): Likewise.
5534 * sound.c (sound_cleanup, alsa_close): Likewise.
5535 * termcap.c (tgetent): Likewise.
5536 * xfns.c (x_default_font_parameter): Likewise.
5537 * xsettings.c (read_and_apply_settings): Likewise.
5539 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5540 (overrun_check_free): Protoize.
5542 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5544 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5545 since callers should never pass a negative size.
5546 Change the signature to match that of plain 'read' and 'write'; see
5547 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5548 * lisp.h: Update prototypes of emacs_write and emacs_read.
5550 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5552 * xdisp.c (redisplay_window): Don't try to determine the character
5553 position of the scroll margin if the window start point w->startp
5554 is outside the buffer's accessible region. (Bug#8468)
5556 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5558 Fix write-region and its subroutines for buffers > 2GB.
5559 * fileio.c (a_write, e_write): Modify declaration of arguments and
5560 local variables to support buffers larger than 2GB.
5561 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5563 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5564 argument, local variables, and return value.
5566 * lisp.h: Update prototypes of emacs_write and emacs_read.
5568 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5570 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5572 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5574 Fix more problems found by GCC 4.6.0's static checks.
5576 * xdisp.c (vmessage): Use a better test for character truncation.
5578 * charset.c (load_charset_map): <, not <=, for optimization,
5579 and to avoid potential problems with integer overflow.
5580 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5581 * casetab.c (set_identity, shuffle): Likewise.
5582 * editfns.c (Fformat): Likewise.
5583 * syntax.c (skip_chars): Likewise.
5585 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5586 This also lets GCC 4.6.0 generate slightly better loop code.
5588 * callint.c (Fcall_interactively): <, not <=, for optimization.
5589 (Fcall_interactively): Count the number of arguments produced,
5590 not the number of arguments given. This is simpler and lets GCC
5591 4.6.0 generate slightly better code.
5593 * ftfont.c: Distingish more carefully between FcChar8 and char.
5594 The previous code passed unsigned char * to a functions like
5595 strlen and xstrcasecmp that expect char *, which does not
5596 conform to the C standard.
5597 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5598 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5599 char * when the C standard requires it.
5601 * keyboard.c (read_char): Remove unused var.
5603 * eval.c: Port to Windows vsnprintf (Bug#8435).
5605 (SIZE_MAX): Define if the headers do not.
5606 (verror): Do not give up if vsnprintf returns a negative count.
5607 Instead, grow the buffer. This ports to Windows vsnprintf, which
5608 does not conform to C99. Problem reported by Eli Zaretskii.
5609 Also, simplify the allocation scheme, by avoiding the need for
5610 calling realloc, and removing the ALLOCATED variable.
5612 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5614 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5615 But keep the doprint source code for now, as we might revamp it
5616 and use it again (Bug#8435).
5617 * lisp.h (doprnt): Remove.
5618 * Makefile.in (base_obj): Remove doprnt.o.
5619 * deps.mk (doprnt.o): Remove.
5621 error: Print 32- and 64-bit integers portably (Bug#8435).
5622 Without this change, on typical 64-bit hosts error ("...%d...", N)
5623 was used to print both 32- and 64-bit integers N, which relied on
5625 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5627 * lisp.h (error, verror): Mark as printf-like functions.
5628 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5629 Report overflow in size calculations when allocating printf buffer.
5630 Do not truncate output string at its first null byte.
5631 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5632 Truncate the output at a character boundary, since vsnprintf does not
5634 * charset.c (check_iso_charset_parameter): Convert internal
5635 character to string before calling 'error', since %c now has the
5637 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5638 overflow when computing char to be passed to 'error'. Do not
5639 pass Lisp_Object to 'error'; pass the integer instead.
5640 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5641 formatted with plain %d.
5643 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5645 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5647 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5649 * xterm.c (x_catch_errors): Remove duplicate declaration.
5651 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5653 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5655 2011-04-10 Jim Meyering <meyering@redhat.com>
5657 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5658 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5659 return ssize_t not "int", and use size_t as the buffer length.
5660 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5661 * gnutls.h: Update declarations.
5662 * process.c (read_process_output): Use ssize_t, to match.
5663 (send_process): Likewise.
5665 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5667 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5669 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5671 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5672 Use unsigned char, to match FcChar8 type definition.
5674 * xterm.c (handle_one_xevent):
5675 * xmenu.c (create_and_show_popup_menu):
5676 * xselect.c (x_decline_selection_request)
5677 (x_reply_selection_request): Avoid type-punned deref of X events.
5679 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5681 Fix some uses of `int' instead of EMACS_INT.
5682 * search.c (string_match_1, fast_string_match)
5683 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5684 (scan_buffer, find_next_newline_no_quit)
5685 (find_before_next_newline, search_command, Freplace_match)
5686 (Fmatch_data): Make some `int' variables be EMACS_INT.
5688 * xdisp.c (display_count_lines): 3rd argument and return value now
5689 EMACS_INT. All callers changed.
5690 (pint2hrstr): Last argument is now EMACS_INT.
5692 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5693 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5694 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5695 (decode_coding_utf_16, decode_coding_emacs_mule)
5696 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5697 (decode_coding_ccl, decode_coding_charset)
5698 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5699 (decode_coding_iso_2022, decode_coding_emacs_mule)
5700 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5701 <char_offset, last_offset>: Declare EMACS_INT.
5702 (encode_coding_utf_8, encode_coding_utf_16)
5703 (encode_coding_emacs_mule, encode_invocation_designation)
5704 (encode_designation_at_bol, encode_coding_iso_2022)
5705 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5706 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5708 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5709 (encode_invocation_designation): Last argument P_NCHARS is now
5711 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5712 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5714 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5717 * ccl.c (Fccl_execute_on_string): Declare some variables
5720 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5722 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5724 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5726 * process.c (Fformat_network_address): Doc fix.
5728 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5730 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5732 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5734 * keyboard.c (read_char): Call Lisp function help-form-show,
5735 instead of using internal_with_output_to_temp_buffer.
5736 (Qhelp_form_show): New var.
5737 (syms_of_keyboard): Use DEFSYM macro.
5739 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5741 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5743 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5745 * process.c (Flist_processes): Remove to Lisp.
5746 (list_processes_1): Delete.
5748 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5750 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5752 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5754 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5756 Fix more problems found by GCC 4.6.0's static checks.
5758 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5760 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5762 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5764 * xdisp.c (vmessage): Mark as a printf-like function.
5766 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5768 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5770 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5771 printf-like functions.
5772 (tiff_load): Add casts to remove these marks before passing them
5773 to system-supplied API.
5775 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5777 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5778 This avoids several warnings with gcc -Wstrict-overflow.
5779 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5780 directly, rather than having caller test rule sign. This avoids
5781 some unnecessary tests.
5782 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5783 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5784 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5786 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5787 (xfont_open): Avoid unnecessary tests.
5789 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5791 * composite.h, composite.c (composition_gstring_put_cache):
5792 Use EMACS_INT, not int, for length.
5794 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5795 breaking out part of COMPOSITION_DECODE_RULE.
5796 (COMPOSITION_DECODE_RULE): Use it.
5797 * composite.c (get_composition_id): Remove unused local vars,
5798 by using the new macro.
5800 * textprop.c (set_text_properties_1): Change while to do-while,
5801 since the condition is always true at first.
5803 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5804 (interval_deletion_adjustment): Return unsigned value.
5807 * process.c (list_processes_1, create_pty, read_process_output):
5808 (exec_sentinel): Remove vars that were set but not used.
5809 (create_pty): Remove unnecessary "volatile"s.
5810 (Fnetwork_interface_info): Avoid possibility of int overflow.
5811 (read_process_output): Do adaptive read buffering even if carryover.
5812 (read_process_output): Simplify nbytes computation if buffered.
5814 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5816 * syntax.c (scan_words): Remove var that was set but not used.
5817 (update_syntax_table): Use unsigned instead of int.
5819 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5820 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5821 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5823 * print.c (print_error_message): Avoid int overflow.
5825 * font.c (font_list_entities): Redo for clarity,
5826 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5828 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5829 (font_score): Avoid potential overflow in diff calculation.
5831 * fns.c (substring_both): Remove var that is set but not used.
5832 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5834 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5836 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5837 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5838 can always succeed if overflow has undefined behavior.
5840 * search.c (boyer_moore, wordify): Remove vars set but not used.
5841 (wordify): Omit three unnecessary tests.
5843 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5844 All callers changed. This avoids the need for an unused var.
5846 * casefiddle.c (casify_region): Remove var that is set but not used.
5848 * dired.c (file_name_completion): Remove var that is set but not used.
5850 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5852 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5853 (Finsert_file_contents): Remove unnecessary code checking fd.
5855 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5856 Check for integer overflow on size calculations.
5858 * buffer.c (Fprevious_overlay_change): Remove var that is set
5861 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5862 Remove vars that are set but not used.
5863 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5864 (timer_check_2): Mark vars as initialized.
5866 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5868 * image.c (lookup_image): Remove var that is set but not used.
5869 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5871 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5872 that are set but not used.
5874 * xfns.c (make_invisible_cursor): Don't return garbage
5875 if XCreateBitmapFromData fails (Bug#8410).
5877 * xselect.c (x_get_local_selection, x_handle_property_notify):
5878 Remove vars that are set but not used.
5880 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5881 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5883 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5884 Remove var that is set but not used.
5885 (scroll_bar_windows_size): Now size_t, not int.
5886 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5889 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5890 (map_tty_color) [!defined MSDOS]: Likewise.
5892 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5894 * coding.c: Remove vars that are set but not used.
5895 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5896 All callers changed.
5897 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5898 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5899 (decode_coding_charset): Remove vars that are set but not used.
5901 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5902 that is set but not used.
5904 * print.c (print_object): Remove var that is set but not used.
5906 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5907 The gnulib version avoids calling malloc in the usual case,
5908 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5909 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5910 * filelock.c (current_lock_owner): Likewise.
5911 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5912 * sysdep.c: Include allocator.h, careadlinkat.h.
5913 (emacs_no_realloc_allocator): New static constant.
5914 (emacs_readlink): New function.
5915 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5916 ../lib/careadlinkat.h.
5918 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5920 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5921 first non-nil return value).
5923 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5925 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5926 if not defined (Bug#8403).
5928 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5930 * xdisp.c (display_count_lines): Remove parameter `start',
5931 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5932 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5933 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5934 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5935 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5936 and thereabouts. All callers changed.
5937 (get_per_char_metric): Remove parameter `f', unused since
5938 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5940 2011-04-02 Jim Meyering <meyering@redhat.com>
5942 do not dereference NULL upon failed strdup
5943 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5944 (ns_get_family): Likewise.
5946 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5948 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5950 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5952 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5955 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5957 Add lexical binding.
5959 * window.c (Ftemp_output_buffer_show): New fun.
5960 (Fsave_window_excursion):
5961 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5963 * lread.c (lisp_file_lexically_bound_p): New function.
5964 (Fload): Bind Qlexical_binding.
5965 (readevalloop): Remove `evalfun' arg.
5966 Bind Qinternal_interpreter_environment.
5967 (Feval_buffer): Bind Qlexical_binding.
5968 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5970 (syms_of_lread): Declare `lexical-binding'.
5972 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5974 * keyboard.c (eval_dyn): New fun.
5975 (menu_item_eval_property): Use it.
5977 * image.c (parse_image_spec): Use Ffunctionp.
5979 * fns.c (concat, mapcar1): Accept byte-code-functions.
5981 * eval.c (Fsetq): Handle lexical vars.
5982 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5983 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5984 (FletX, Flet): Obey lexical binding.
5985 (Fcommandp): Handle closures.
5986 (Feval): New `lexical' arg.
5987 (eval_sub): New function extracted from Feval. Use it almost
5988 everywhere where Feval was used. Look up vars in lexical env.
5990 (Ffunctionp): Move from subr.el.
5991 (Ffuncall): Handle closures.
5992 (apply_lambda): Remove `eval_flags'.
5993 (funcall_lambda): Handle closures and new byte-code-functions.
5994 (Fspecial_variable_p): New function.
5995 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5996 but without exporting it to Lisp.
5998 * doc.c (Fdocumentation, store_function_docstring):
5999 * data.c (Finteractive_form): Handle closures.
6001 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6004 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6006 (exec_byte_code): New function extracted from Fbyte_code to handle new
6007 calling convention for byte-code-functions. Add new byte-codes.
6009 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6011 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6013 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6015 * xdisp.c (redisplay_internal): Fix prototype.
6017 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6019 * xdisp.c (SCROLL_LIMIT): New macro.
6020 (try_scrolling): Use it when setting scroll_limit.
6021 Limit scrolling to 100 screen lines.
6022 (redisplay_window): Even when falling back on "recentering",
6023 position point in the window according to scroll-conservatively,
6024 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6026 (try_scrolling): When point is above the window, allow searching
6027 as far as scroll_max, or one screenful, to compute vertical
6028 distance from PT to the scroll margin position. This prevents
6029 try_scrolling from unnecessarily failing when
6030 scroll-conservatively is set to a value slightly larger than the
6031 window height. Clean up the case of PT below the margin at bottom
6032 of window: scroll_max can no longer be INT_MAX. When aggressive
6033 scrolling is in use, don't let point enter the opposite scroll
6034 margin as result of the scroll.
6035 (syms_of_xdisp) <scroll-conservatively>: Document the
6036 threshold of 100 lines for never-recentering scrolling.
6038 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6040 * dispextern.h (move_it_by_lines):
6041 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6042 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6043 (message_log_check_duplicate): Remove parameters `prev_bol' and
6044 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6045 (redisplay_internal): Remove parameter `preserve_echo_area',
6046 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6048 * indent.c (Fvertical_motion):
6049 * window.c (window_scroll_pixel_based, Frecenter):
6050 Don't pass `need_y_p' to `move_it_by_lines'.
6052 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6054 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6055 steal a few bits to be more compact.
6056 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6057 Remove unneeded casts.
6059 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6061 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6063 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6064 binding" message (bug#7967).
6066 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6068 Fix more problems found by GCC 4.6.0's static checks.
6070 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6071 Remove unused local var.
6073 * editfns.c (Fmessage_box): Remove unused local var.
6075 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6076 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6077 Omit unused local vars.
6078 * window.c (shrink_windows): Omit unused local var.
6079 * menu.c (digest_single_submenu): Omit unused local var.
6080 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6081 Omit unused local var.
6083 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6084 Don't assume string length fits in int.
6085 (keyremap_step, read_key_sequence): Use size_t for sizes.
6086 (read_key_sequence): Don't check last_real_key_start redundantly.
6088 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6089 instead of alloca (Bug#8344).
6091 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6092 (Fbacktrace_frame): Don't assume nframes fits in int.
6094 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6096 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6099 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6101 * cm.c (calccost): Turn while-do into do-while, for clarity.
6103 * keyboard.c (syms_of_keyboard): Use the same style as later
6104 in this function when indexing through an array. This also
6105 works around GCC bug 48267.
6107 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6109 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6111 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6112 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6114 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6115 This avoids undefined behavior on integer overflow, and is a bit
6116 more convenient anyway since it is compared to a size_t variable.
6118 Variadic C functions now count arguments with size_t, not int.
6119 This avoids an unnecessary limitation on 64-bit machines, which
6120 caused (substring ...) to crash on large vectors (Bug#8344).
6121 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6122 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6123 All variadic functions and their callers changed accordingly.
6124 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6125 * data.c (arith_driver, float_arith_driver): Likewise.
6126 * editfns.c (general_insert_function): Likewise.
6127 * eval.c (struct backtrace.nargs, interactive_p)
6128 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6129 (funcall_lambda, mark_backtrace): Likewise.
6130 * fns.c (concat): Likewise.
6131 * frame.c (x_set_frame_parameters): Likewise.
6132 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6133 0 if not found, not -1. All callers changed.
6135 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6136 (stack_copy_size): Now size_t, not int.
6137 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6139 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6141 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6142 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6143 All callers changed.
6145 * lisp.h (multibyte_char_to_unibyte):
6146 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6147 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6148 * character.h (CHAR_TO_BYTE8):
6149 * cmds.c (internal_self_insert):
6150 * editfns.c (general_insert_function):
6151 * keymap.c (push_key_description):
6152 * search.c (Freplace_match):
6153 * xdisp.c (message_dolog, set_message_1): All callers changed.
6155 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6157 * keyboard.c (safe_run_hook_funcall): New function.
6158 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6159 don't set the hook to nil, but remove the offending function instead.
6160 (Qcommand_hook_internal): Remove, unused.
6161 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6162 Vcommand_hook_internal.
6164 * eval.c (enum run_hooks_condition): Remove.
6165 (funcall_nil, funcall_not): New functions.
6166 (run_hook_with_args): Call each function through a `funcall' argument.
6167 Remove `cond' argument, now redundant.
6168 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6169 (Frun_hook_with_args_until_failure): Adjust accordingly.
6170 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6172 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6174 * dispextern.h (string_buffer_position): Remove declaration.
6176 * print.c (strout): Remove parameter `multibyte', unused since
6177 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6179 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6180 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6181 All callers changed.
6183 * w32.c (_wsa_errlist): Use braces for struct initializers.
6185 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6186 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6187 All callers changed.
6188 (string_buffer_position): Likewise. Also, make static (it's never
6189 used outside xdisp.c).
6190 (cursor_row_p): Remove parameter `w', unused since
6191 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6192 (decode_mode_spec): Remove parameter `precision', introduced during
6193 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6194 All callers changed.
6196 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6198 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6200 2011-03-27 Anders Lindgren <andlind@gmail.com>
6202 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6203 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6204 (ns_update_auto_hide_menu_bar): New functions.
6205 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6206 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6207 ns_constrain_all_frames.
6208 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6209 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6211 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6213 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6215 2011-03-27 Glenn Morris <rgm@gnu.org>
6217 * syssignal.h: Replace RETSIGTYPE with void.
6218 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6219 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6220 Replace SIGTYPE with void everywhere.
6221 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6222 * s/template.h (SIGTYPE): Remove commented out definition.
6224 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6226 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6227 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6229 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6231 * w32.c (read_unc_volume): Use parameter `henum', instead of
6232 global variable `wget_enum_handle'.
6234 * keymap.c (describe_vector): Remove parameters `indices' and
6235 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6236 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6238 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6240 * keyboard.c (timer_check): Remove parameter `do_it_now',
6241 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6242 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6243 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6245 * keyboard.c (read_char):
6246 * w32menu.c (w32_menu_display_help):
6247 * xmenu.c (show_help_event, menu_help_callback):
6248 Adjust calls to `show_help_echo'.
6250 * gtkutil.c (xg_maybe_add_timer):
6251 * keyboard.c (readable_events):
6252 * process.c (wait_reading_process_output):
6253 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6255 * insdel.c (adjust_markers_gap_motion):
6256 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6257 (gap_left, gap_right): Don't call it.
6259 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6261 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6262 incurred during fontification.
6264 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6266 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6267 (DEFVAR_PER_BUFFER): Don't pass it.
6269 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6270 (scrolling_window): Don't pass it.
6272 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6274 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6276 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6278 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6279 of variables specific to SELinux and computation of `encoded_absname'.
6281 * image.c (XPutPixel): Remove unused variable `height'.
6283 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6285 * unexw32.c (get_section_info): Remove unused variable `section'.
6287 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6288 (system_process_attributes): Remove unused variable `sess'.
6289 (sys_read): Remove unused variable `err'.
6291 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6292 (w32_wnd_proc): Remove unused variable `isdead'.
6293 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6294 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6295 (x_create_tip_frame): Remove unused variable `tem'.
6297 * w32inevt.c (w32_console_read_socket):
6298 Remove unused variable `no_events'.
6300 * w32term.c (x_draw_composite_glyph_string_foreground):
6301 Remove unused variable `width'.
6303 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6305 * w32term.c (x_set_glyph_string_clipping):
6306 Don't pass uninitialized region to CombineRgn.
6308 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6310 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6311 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6312 (Fx_close_connection): Remove unused variable `i'.
6314 * w32font.c (w32font_draw): Return number of glyphs.
6315 (w32font_open_internal): Remove unused variable `i'.
6316 (w32font_driver): Add missing initializer.
6318 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6319 (fill_in_menu): Remove unused variable `items_added'.
6321 * w32term.c (last_mouse_press_frame): Remove static global variable.
6322 (w32_clip_to_row): Remove unused variable `f'.
6323 (x_delete_terminal): Remove unused variable `i'.
6325 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6326 (NOTHING): Remove unused static global variable.
6327 (uniscribe_check_otf): Remove unused variable `table'.
6328 (uniscribe_font_driver): Add missing initializers.
6330 2011-03-23 Julien Danjou <julien@danjou.info>
6332 * term.c (Fsuspend_tty, Fresume_tty):
6333 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6334 * window.c (temp_output_buffer_show):
6335 * insdel.c (signal_before_change):
6336 * frame.c (Fhandle_switch_frame):
6337 * fileio.c (Fdo_auto_save):
6338 * emacs.c (Fkill_emacs):
6339 * editfns.c (save_excursion_restore):
6340 * cmds.c (internal_self_insert):
6341 * callint.c (Fcall_interactively):
6342 * buffer.c (Fkill_all_local_variables):
6343 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6345 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6346 unconditionnaly since it does the check itself.
6348 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6350 Fix more problems found by GCC 4.5.2's static checks.
6352 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6353 the first time through the loop, since we know p0 < p1 then.
6354 This also avoids a gcc -Wstrict-overflow warning.
6356 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6357 leading to a memory leak, possible in functions like
6358 load_charset_map_from_file that can allocate an unbounded number
6359 of objects (Bug#8318).
6361 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6362 that could (at least in theory) be that large.
6364 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6365 This is less likely to overflow, and avoids undefined behavior if
6366 overflow does occur. All callers changed. Use strtoul to scan
6367 for the unsigned long integer.
6368 (pint2hrstr): Simplify and tune code slightly.
6369 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6371 * scroll.c (do_scrolling): Work around GCC bug 48228.
6372 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6374 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6375 This also avoids a warning with gcc -Wstrict-overflow.
6376 (validate_x_resource_name): Simplify count usage.
6377 This also avoids a warning with gcc -Wstrict-overflow.
6379 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6382 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6384 * process.c (Fmake_network_process): Use socklen_t, not int,
6385 where POSIX says socklen_t is required in portable programs.
6386 This fixes a porting bug on hosts like 64-bit HP-UX, where
6387 socklen_t is wider than int (Bug#8277).
6388 (Fmake_network_process, server_accept_connection):
6389 (wait_reading_process_output, read_process_output):
6392 * process.c: Rename or move locals to avoid shadowing.
6393 (list_processes_1, Fmake_network_process):
6394 (read_process_output_error_handler, exec_sentinel_error_handler):
6395 Rename or move locals.
6396 (Fmake_network_process): Define label "retry_connect" only if needed.
6397 (Fnetwork_interface_info): Fix pointer signedness.
6398 (process_send_signal): Add cast to avoid pointer signedness problem.
6399 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6400 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6402 Make tparam.h and terminfo.c consistent.
6403 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6404 Include tparam.h instead, since it declares them.
6405 * cm.h (PC): Remove extern decl; tparam.h now does this.
6406 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6407 * terminfo.c: Include tparam.h, to check interfaces.
6408 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6409 (tparam): Adjust signature to match interface in tparam.h;
6410 this removes some undefined behavior. Check that outstring and len
6411 are zero, which they always are with Emacs.
6412 * tparam.h (PC, BC, UP): New extern decls.
6414 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6415 (xftfont_open): Rename locals to avoid shadowing.
6417 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6418 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6419 (OTF_TAG_SYM): Omit macro if not needed.
6420 (ftfont_list): Remove unused local.
6421 (get_adstyle_property, ftfont_pattern_entity):
6422 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6423 Rename locals to avoid shadowing.
6425 * xfont.c (xfont_list_family): Mark var as initialized.
6427 * xml.c (make_dom): Now static.
6429 * composite.c (composition_compute_stop_pos): Rename local to
6431 (composition_reseat_it): Remove unused locals.
6432 (find_automatic_composition, composition_adjust_point): Likewise.
6433 (composition_update_it): Mark var as initialized.
6434 (find_automatic_composition): Mark vars as initialized,
6435 with a FIXME (Bug#8290).
6437 character.h: Rename locals to avoid shadowing.
6438 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6439 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6440 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6441 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6444 * textprop.c (property_change_between_p): Remove; unused.
6446 * intervals.c (interval_start_pos): Now static.
6448 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6450 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6451 Rename locals to avoid shadowing.
6453 * sound.c (wav_play, au_play, Fplay_sound_internal):
6454 Fix pointer signedness.
6455 (alsa_choose_format): Remove unused local var.
6456 (wav_play): Initialize a variable to 0, to prevent undefined
6457 behavior (Bug#8278).
6459 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6461 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6463 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6464 clobbering (Bug#8298).
6465 * sysdep.c (sys_subshell): Likewise.
6466 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6468 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6469 This should get cleaned up, so that child_setup has the
6470 same signature on all platforms.
6472 * callproc.c (call_process_cleanup): Now static.
6473 (relocate_fd): Rename locals to avoid shadowing.
6475 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6477 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6478 not to be necessary, and produces flickering.
6480 2011-03-20 Glenn Morris <rgm@gnu.org>
6482 * config.in: Remove file.
6484 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6486 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6487 are now in src/globals.h.
6488 (syms_of_minibuf): Remove spurious & from previous change.
6490 2011-03-20 Leo <sdl.web@gmail.com>
6492 * minibuf.c (completing-read-function): New variable.
6493 (completing-read-default): Rename from completing-read.
6494 (completing-read): Call completing-read-function.
6496 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6498 * xfaces.c (Fx_load_color_file):
6499 Read color file from absolute filename (bug#8250).
6501 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6503 * makefile.w32-in: Update dependencies.
6505 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6507 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6509 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6511 Fix more problems found by GCC 4.5.2's static checks.
6513 * process.c (make_serial_process_unwind, send_process_trap):
6514 (sigchld_handler): Now static.
6516 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6517 That way, the code declares only the vars that it needs.
6518 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6519 * s/cygwin.h (PTY_ITERATION): Likewise.
6520 * s/darwin.h (PTY_ITERATION): Likewise.
6521 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6523 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6524 * process.c (allocate_pty): Don't declare stb unless it's needed.
6526 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6527 (CONSTANTLIM): Remove; unused.
6528 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6529 Define only if needed.
6531 * unexelf.c (unexec): Name an expression,
6532 to avoid gcc -Wbad-function-cast warning.
6533 Use a different way to cause a compilation error if anyone uses
6534 n rather than nn, a way that does not involve shadowing.
6535 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6537 * deps.mk (unexalpha.o): Remove; unused.
6539 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6540 * unexec.h: New file.
6541 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6542 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6544 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6545 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6546 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6547 Change as necessary to match prototype in unexec.h.
6549 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6551 (back_comment, skip_chars): Mark vars as initialized.
6553 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6554 Rename locals to avoid shadowing.
6556 * lread.c (read1): Rewrite so as not to use empty "else".
6557 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6559 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6561 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6562 warning when compiling print.c.
6564 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6565 instead of using an uninitialized var.
6566 (font_sort_entities): Mark var as initialized.
6568 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6570 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6571 pointers to constants.
6572 (font_parse_fcname): Remove unused vars.
6573 (font_delete_unmatched): Now static.
6574 (font_get_spec): Remove; unused.
6575 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6576 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6577 Rename or move locals to avoid shadowing.
6579 * fns.c (require_nesting_list, require_unwind): Now static.
6580 (Ffillarray): Rename locals to avoid shadowing.
6582 * floatfns.c (domain_error2): Define only if needed.
6583 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6585 * alloc.c (mark_backtrace): Move decl from here ...
6586 * lisp.h: ... to here, so that it can be checked.
6588 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6589 (Fdefvar): Rewrite so as not to use empty "else".
6590 (lisp_indirect_variable): Name an expression,
6591 to avoid gcc -Wbad-function-cast warning.
6592 (Fdefvar): Rename locals to avoid shadowing.
6594 * callint.c (quotify_arg, quotify_args): Now static.
6595 (Fcall_interactively): Rename locals to avoid shadowing.
6596 Use const pointer when appropriate.
6598 * lisp.h (get_system_name, get_operating_system_release):
6599 Move decls here, to check interfaces.
6600 * process.c (get_operating_system_release): Move decl to lisp.h.
6601 * xrdb.c (get_system_name): Likewise.
6602 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6603 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6604 some of which prompt warnings from gcc -Wbad-function-cast.
6605 (Fformat_time_string, Fencode_time, Finsert_char):
6606 (Ftranslate_region_internal, Fformat):
6607 Rename or remove local vars to avoid shadowing.
6608 (Ftranslate_region_internal): Mark var as initialized.
6610 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6613 * lisp.h (eassert): Check that the argument compiles, even if
6614 ENABLE_CHECKING is not defined.
6616 * data.c (Findirect_variable): Name an expression, to avoid
6617 gcc -Wbad-function-cast warning.
6618 (default_value, arithcompare, arith_driver, arith_error): Now static.
6619 (store_symval_forwarding): Rename local to avoid shadowing.
6620 (Fmake_variable_buffer_local, Fmake_local_variable):
6621 Mark variables as initialized.
6622 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6624 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6625 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6626 Rename locals to avoid shadowing.
6627 (mark_stack): Move local variables into the #ifdef region where
6629 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6630 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6632 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6633 (GC_STRING_CHARS): Remove; not used.
6634 (Fmemory_limit): Cast sbrk's returned value to char *.
6636 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6637 avoids undefined behavior in theory.
6639 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6641 Use functions, not macros, for up- and down-casing (Bug#8254).
6642 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6643 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6644 to use the following functions instead of these macros.
6645 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6646 EMACS_INT, since callers assume the returned value fits in int.
6647 (upcase1): Likewise, for UPCASE_TABLE.
6648 (uppercasep, lowercasep, upcase): New static inline functions.
6649 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6650 the race-condition problem in the old DOWNCASE.
6652 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6653 Rename locals to avoid shadowing.
6654 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6655 (regex_compile, re_search_2, re_match_2_internal):
6656 Remove unused local vars.
6657 (FREE_VAR): Rewrite so as not to use empty "else",
6658 which gcc can warn about.
6659 (regex_compile, re_match_2_internal): Mark locals as initialized.
6660 (RETALLOC_IF): Define only if needed.
6661 (WORDCHAR_P): Likewise. This one is never needed, but is used
6662 only in a comment talking about a compiler bug, so put inside
6663 the #if 0 of that comment.
6664 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6665 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6668 * search.c (boyer_moore): Rename locals to avoid shadowing.
6669 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6670 (PREV_CHAR_BOUNDARY): Likewise.
6672 * search.c (simple_search): Remove unused var.
6674 * dired.c (compile_pattern): Move decl from here ...
6675 * lisp.h: ... to here, so that it can be checked.
6676 (struct re_registers): New forward decl.
6678 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6680 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6682 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6683 Rename locals to avoid shadowing.
6684 (Fvertical_motion): Mark locals as initialized.
6686 * casefiddle.c (casify_object, casify_region): Now static.
6687 (casify_region): Mark local as initialized.
6689 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6691 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6692 New macros, so that the caller can use some names other than
6693 gcpro1, gcpro2, etc.
6694 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6696 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6697 argument, for consistency with GCPRO2_VAR, etc: it is now the
6698 prefix of the variable, not the variable itself. All uses
6700 * dired.c (directory_files_internal, file_name_completion):
6701 Rename locals to avoid shadowing.
6703 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6704 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6705 dired.c's scmp function, had undefined behavior.
6706 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6707 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6708 * buffer.h: ... to here, because these macros use current_buffer,
6709 and the new implementation with inline functions needs to have
6710 current_buffer in scope now, rather than later when the macros
6712 (downcase, upcase1): New static inline functions.
6713 (DOWNCASE, UPCASE1): Reimplement using these functions.
6714 This avoids undefined behavior in expressions like
6715 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6716 from race conditions in accessing the global variables
6717 case_temp1 and case_temp2.
6718 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6719 * lisp.h (case_temp1, case_temp2): Remove their decls.
6720 * character.h (ASCII_CHAR_P): Move from here ...
6721 * lisp.h: ... to here, so that the inline functions mentioned
6724 * dired.c (directory_files_internal_unwind): Now static.
6726 * fileio.c (file_name_as_directory, directory_file_name):
6727 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6729 (file_name_as_directory): Use const pointers when appropriate.
6730 (Fexpand_file_name): Likewise. In particular, newdir might
6731 point at constant storage, so make it a const pointer.
6732 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6733 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6735 (Fset_file_times, Finsert_file_contents, auto_save_error):
6736 Rename locals to avoid shadowing.
6738 * minibuf.c (choose_minibuf_frame_1): Now static.
6739 (Ftry_completion, Fall_completions): Rename or remove locals
6742 * marker.c (bytepos_to_charpos): Remove; unused.
6744 * lisp.h (verify_bytepos, count_markers): New decls,
6745 so that gcc does not warn that these functions aren't declared.
6747 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6748 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6749 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6750 (copy_text): Remove unused local var.
6752 * filelock.c (within_one_second): Now static.
6753 (lock_file_1): Rename local to avoid shadowing.
6755 * buffer.c (fix_overlays_before): Mark locals as initialized.
6756 (fix_start_end_in_overlays): Likewise. This function should be
6757 simplified by using pointers-to-pointers, but that's a different
6759 (switch_to_buffer_1): Now static.
6760 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6761 (report_overlay_modification): Rename locals to avoid shadowing.
6763 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6764 Fix pointer signedness issue.
6765 (sys_subshell): Mark local as volatile if checking for lint,
6766 to suppress a gcc -Wclobbered warning that does not seem to be right.
6767 (MAXPATHLEN): Define only if needed.
6769 * process.c (serial_open, serial_configure): Move decls from here ...
6770 * systty.h: ... to here, so that they can be checked.
6772 * fns.c (get_random, seed_random): Move extern decls from here ...
6773 * lisp.h: ... to here, so that they can be checked.
6775 * sysdep.c (reset_io): Now static.
6776 (wait_for_termination_signal): Remove; unused.
6778 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6779 (copy_keymap_item, append_key, push_text_char_description):
6781 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6782 (DENSE_TABLE_SIZE): Remove; unused.
6783 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6784 (describe_map_tree):
6785 Rename locals to avoid shadowing.
6787 * keyboard.c: Declare functions static if they are not used elsewhere.
6788 (echo_char, echo_dash, cmd_error, top_level_2):
6789 (poll_for_input, handle_async_input): Now static.
6790 (read_char, kbd_buffer_get_event, make_lispy_position):
6791 (make_lispy_event, make_lispy_movement, apply_modifiers):
6792 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6793 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6794 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6795 (read_key_sequence, read_char): Mark locals as initialized.
6796 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6798 * keyboard.h (make_ctrl_char): New decl.
6799 (mark_kboards): Move decl here ...
6800 * alloc.c (mark_kboards): ... from here.
6802 * lisp.h (force_auto_save_soon): New decl.
6804 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6805 (DEFINE_DUMMY_FUNCTION): New macro.
6806 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6808 (main): Add casts to avoid warnings
6809 if GCC considers string literals to be constants.
6811 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6813 * dbusbind.c: Pointer signedness fixes.
6814 (xd_signature, xd_append_arg, xd_initialize):
6815 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6816 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6817 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6818 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6820 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6821 if GCC considers string literals to be constants.
6822 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6824 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6826 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6827 (print_preprocess, print_object): New macro to fix last change.
6829 * print.c (print_preprocess): Don't forget font objects.
6831 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6833 * emacs.c (USAGE3): Doc fixes.
6835 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6837 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6840 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6842 * lisp.h (VWindow_system, Qfile_name_history):
6843 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6844 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6845 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6847 * w32select.c: Don't #include "keyboard.h".
6848 (run_protected): Add extern declaration for waiting_for_input.
6850 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6851 * w32console.c (detect_input_pending, read_input_pending)
6852 (encode_terminal_code):
6853 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6854 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6855 (w32_system_caret_y, Qfile_name_history):
6856 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6857 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6858 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6859 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6860 * w32proc.c (Qlocal, report_file_error):
6861 * w32term.c (Vwindow_system, updating_frame):
6862 * w32uniscribe.c (initialized, uniscribe_font_driver):
6863 Remove unneeded extern declarations.
6865 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6867 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6869 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6871 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6872 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6873 These macros can no longer be used for assignment.
6875 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6876 Assign struct members directly, instead of using BUF_BEGV etc.
6877 (record_buffer_markers, fetch_buffer_markers): New functions for
6878 recording and fetching special buffer markers.
6879 (set_buffer_internal_1, set_buffer_temp): Use them.
6881 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6883 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6885 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6886 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6888 * xdisp.c (hscroll_window_tree):
6889 (reconsider_clip_changes): Use PT instead of BUF_PT.
6891 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6893 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6894 $(EMACS_ROOT)/lib/intprops.h.
6896 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6898 Fix more problems found by GCC 4.5.2's static checks.
6900 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6901 to unsigned char * to avoid compiler diagnostic.
6902 (xg_free_frame_widgets): Make it clear that a local variable is
6903 needed only if USE_GTK_TOOLTIP.
6904 (gdk_window_get_screen): Make it clear that this macro is needed
6905 only if USE_GTK_TOOLTIP.
6906 (int_gtk_range_get_value): New function, which avoids a diagnostic
6907 from gcc -Wbad-function-cast.
6908 (xg_set_toolkit_scroll_bar_thumb): Use it.
6909 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6910 diagnostic from gcc -Wbad-function-cast.
6911 (get_utf8_string, xg_get_file_with_chooser):
6912 Rename locals to avoid shadowing.
6913 (create_dialog): Move locals to avoid shadowing.
6915 * xgselect.c (xg_select): Remove unused var.
6917 * image.c (four_corners_best): Mark locals as initialized.
6918 (gif_load): Initialize transparent_p to zero (Bug#8238).
6919 Mark another local as initialized.
6920 (my_png_error, my_error_exit): Mark with NO_RETURN.
6922 * image.c (clear_image_cache): Now static.
6923 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6924 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6925 (x_edge_detection): Remove unnecessary cast that
6926 gcc -Wbad-function-cast diagnoses.
6927 (gif_load): Fix pointer signedness.
6928 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6929 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6931 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6933 Improve quality of tests for time stamp overflow.
6934 For example, without this patch (encode-time 0 0 0 1 1
6935 1152921504606846976) returns the obviously-bogus value (-948597
6936 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6937 reports time overflow. See
6938 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6939 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6940 * editfns.c: Include limits.h and intprops.h.
6941 (TIME_T_MIN, TIME_T_MAX): New macros.
6942 (time_overflow): Move earlier, to before first use.
6943 (hi_time, lo_time): New functions, for an accurate test for
6945 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6946 (Fget_internal_run_time): Don't assume time_t fits in int.
6947 (make_time): Use list2 instead of Fcons twice.
6948 (Fdecode_time): More accurate test for out-of-range times.
6949 (check_tm_member): New function.
6950 (Fencode_time): Use it, to test for out-of-range times.
6951 (lisp_time_argument): Don't rely on undefined left-shift and
6952 right-shift behavior when checking for time stamp overflow.
6954 * editfns.c (time_overflow): New function, refactoring common code.
6955 (Fformat_time_string, Fdecode_time, Fencode_time):
6956 (Fcurrent_time_string): Use it.
6958 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6959 * dired.c (make_time): Move to ...
6960 * editfns.c (make_time): ... here.
6961 * systime.h: Note the move.
6963 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6965 * fringe.c (update_window_fringes): Remove unused variables.
6967 * unexmacosx.c (copy_data_segment): Also copy __got section.
6970 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6972 * termcap.c [MSDOS]: Include "msdos.h".
6973 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6974 Constify `char *' arguments and their references according to
6975 prototypes in tparam.h.
6977 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6979 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6980 Adapt all references accordingly.
6982 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6984 2011-03-11 Tom Tromey <tromey@redhat.com>
6986 * buffer.c (syms_of_buffer): Remove obsolete comment.
6988 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6990 * termhooks.h (encode_terminal_code): Declare prototype.
6992 * msdos.c (encode_terminal_code): Don't declare prototype.
6994 * term.c (encode_terminal_code): Now external again, used by
6995 w32console.c and msdos.c.
6997 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6998 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7000 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7002 Fix some minor problems found by GCC 4.5.2's static checks.
7004 * fringe.c (update_window_fringes): Mark locals as initialized
7006 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7008 * alloc.c (mark_fringe_data): Move decl from here ...
7009 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7010 to check its interface.
7011 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7013 * fontset.c (free_realized_fontset): Now static.
7014 (Fset_fontset_font): Rename local to avoid shadowing.
7015 (fontset_font): Mark local as initialized.
7016 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7018 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7020 * xselect.c (x_disown_buffer_selections): Remove; not used.
7021 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7022 (x_own_selection, Fx_disown_selection_internal): Rename locals
7024 (x_handle_dnd_message): Remove local to avoid shadowing.
7026 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7027 so that the caller can use some name other than gcpro1.
7028 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7029 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7030 (Fx_backspace_delete_keys_p):
7031 Use them to avoid shadowing, and rename vars to avoid shadowing.
7032 (x_decode_color, x_set_name, x_window): Now static.
7033 (Fx_create_frame): Add braces to silence GCC warning.
7034 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7035 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7036 Remove unused locals.
7037 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7038 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7039 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7042 * xterm.h (x_mouse_leave): New decl.
7044 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7045 Remove unused functions.
7046 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7047 (x_calc_absolute_position): Now static.
7048 (XTread_socket): Don't define label "out" unless it's used.
7049 Don't declare local "event" unless it's used.
7050 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7051 unless they are used.
7052 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7053 (x_fatal_error_signal): Remove; not used.
7054 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7055 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7056 (x_error_catcher, x_connection_closed, x_error_handler):
7057 (x_error_quitter, xembed_send_message, x_iconify_frame):
7058 (my_log_handler): Rename locals to avoid shadowing.
7059 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7060 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7062 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7063 Rename or move locals to avoid shadowing.
7064 (tty_defined_color, merge_face_heights): Now static.
7065 (free_realized_faces_for_fontset): Remove; not used.
7066 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7067 does not deduce is never used uninitialized.
7068 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7069 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7071 * terminal.c (store_terminal_param): Now static.
7073 * xmenu.c (menu_highlight_callback): Now static.
7074 (set_frame_menubar): Remove unused local.
7075 (xmenu_show): Rename parameter to avoid shadowing.
7076 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7077 since they might point to immutable storage.
7078 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7079 since it's unused otherwise.
7081 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7082 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7083 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7084 avoids a gcc -Wuninitialized diagnostic.
7085 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7086 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7087 does not deduce are never used uninitialized.
7089 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7091 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7092 * window.c (window_loop, size_window):
7093 (run_window_configuration_change_hook, enlarge_window): Likewise.
7095 * window.c (display_buffer): Now static.
7096 (size_window): Mark variables that gcc -Wuninitialized
7097 does not deduce are never used uninitialized.
7098 * window.h (check_all_windows): New decl, to forestall
7099 gcc -Wmissing-prototypes diagnostic.
7100 * dispextern.h (bidi_dump_cached_states): Likewise.
7102 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7104 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7106 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7107 and to avoid gcc -Wuninitialized warning.
7108 (load_charset_map): Mark variables that gcc -Wuninitialized
7109 does not deduce are never used uninitialized.
7110 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7112 * coding.c (coding_set_source, coding_set_destination):
7113 Use "else { /* comment */ }" rather than "else /* comment */;"
7114 for clarity, and to avoid gcc -Wempty-body warning.
7115 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7116 a block, when the outer 'i' will do.
7117 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7118 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7119 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7120 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7121 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7122 Rename locals to avoid shadowing.
7123 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7124 * coding.c (emacs_mule_char, encode_invocation_designation):
7125 Now static, since they're not used elsewhere.
7126 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7127 (decode_coding_object, encode_coding_object, detect_coding_system):
7128 (decode_coding_emacs_mule): Mark variables that gcc
7129 -Wuninitialized does not deduce are never used uninitialized.
7130 (detect_coding_iso_2022): Initialize a local variable that might
7131 be used uninitialized. Leave a FIXME because it's not clear that
7132 this initialization is needed. (Bug#8211)
7133 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7134 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7135 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7136 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7137 Remove unused macros.
7139 * category.c (hash_get_category_set): Remove unused local var.
7140 (copy_category_table): Now static, since it's not used elsewhere.
7141 * character.c (string_count_byte8): Likewise.
7143 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7144 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7146 * chartab.c (copy_sub_char_table): Now static, since it's not used
7148 (sub_char_table_ref_and_range, char_table_ref_and_range):
7149 Rename locals to avoid shadowing.
7150 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7152 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7153 (BIDI_BOB): Remove unused macro.
7155 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7156 deduce are never used uninitialized.
7157 * term.c (encode_terminal_code): Likewise.
7159 * term.c (encode_terminal_code): Now static. Remove unused local.
7161 * tparam.h: New file.
7162 * term.c, tparam.h: Include it.
7163 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7164 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7165 Move these decls to tparam.h, and make them agree with what
7166 is actually in tparam.c. The previous trick of using incompatible
7167 decls in different modules does not conform to the C standard.
7168 All callers of tparam changed to use tparam's actual API.
7169 * tparam.c (tparam1, tparam, tgoto):
7170 Use const pointers where appropriate.
7172 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7173 * cm.h (struct cm): Likewise.
7174 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7175 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7176 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7177 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7178 (turn_on_face, init_tty): Likewise.
7179 * termchar.h (struct tty_display_info): Likewise.
7181 * term.c (term_mouse_position): Rename local to avoid shadowing.
7183 * alloc.c (mark_ttys): Move decl from here ...
7184 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7186 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7188 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7190 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7192 * search.c (compile_pattern_1): Remove argument regp, unused since
7193 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7194 (compile_pattern): Don't pass it.
7196 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7198 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7199 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7201 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7203 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7205 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7206 gdk_window_get_screen, gdk_window_get_geometry,
7207 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7208 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7209 (xg_get_pixbuf_from_pixmap): New function.
7210 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7211 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7212 Call xg_get_pixbuf_from_pixmap instead of
7213 gdk_pixbuf_get_from_drawable.
7214 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7215 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7216 (xg_check_special_colors): Use GtkStyleContext and its functions
7218 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7219 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7220 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7221 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7222 Call gtk_widget_get_preferred_size.
7223 (xg_frame_resized): gdk_window_get_geometry only takes 5
7225 (xg_win_to_widget, xg_event_is_for_menubar):
7226 Call gdk_x11_window_lookup_for_display.
7227 (xg_set_widget_bg): New function.
7228 (delete_cb): New function.
7229 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7230 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7231 (xg_set_background_color): Call xg_set_widget_bg.
7232 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7233 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7234 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7235 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7237 (update_frame_tool_bar): Call gtk_widget_hide.
7238 (xg_initialize): Use GDK_KEY_g.
7240 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7242 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7244 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7245 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7246 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7248 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7250 * w32xfns.c (select_palette): Check success of RealizePalette against
7251 GDI_ERROR, not zero.
7253 See ChangeLog.11 for earlier changes.
7259 Copyright (C) 2011 Free Software Foundation, Inc.
7261 This file is part of GNU Emacs.
7263 GNU Emacs is free software: you can redistribute it and/or modify
7264 it under the terms of the GNU General Public License as published by
7265 the Free Software Foundation, either version 3 of the License, or
7266 (at your option) any later version.
7268 GNU Emacs is distributed in the hope that it will be useful,
7269 but WITHOUT ANY WARRANTY; without even the implied warranty of
7270 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7271 GNU General Public License for more details.
7273 You should have received a copy of the GNU General Public License
7274 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.