1 2011-07-07 Paul Eggert <eggert@cs.ucla.edu>
3 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4 Remove, replacing with the new symbols in lisp.h. All uses changed.
5 * fileio.c (make_temp_name):
6 * filelock.c (lock_file_1, lock_file):
7 * xdisp.c (message_dolog):
8 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
10 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11 replacing the pWIDE etc. symbols removed from editfns.c.
13 * keyboard.h (num_input_events): Now uintmax_t.
14 This is (very slightly) less likely to mess up due to wraparound.
17 * buffer.c: Integer signedness fixes.
18 (alloc_buffer_text, enlarge_buffer_text):
19 Use ptrdiff_t rather than size_t when either will do, as we prefer
22 * bidi.c: Integer signedness and overflow fixes.
23 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
24 (bidi_cache_search, bidi_cache_find_level_change)
25 (bidi_cache_iterator_state, bidi_cache_find, bidi_find_other_level_edge)
26 (bidi_dump_cached_states):
27 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
28 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
30 (elsz): Make it a (signed) constant.
31 (bidi_cache_iterator_state): Check for size-calculation overflow.
33 * alloc.c: Integer signedness and overflow fixes.
34 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
35 (__malloc_size_t): Default to size_t, not to int.
36 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
37 (Fgarbage_collect, mark_object_loop_halt, mark_object):
38 Prefer ptrdiff_t to size_t when either would do, as we prefer
40 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
41 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
42 Now const. Initialize with values that are in range even if char
44 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
45 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
46 These functions do the right thing with sizes > 2**32.
47 (check_depth): Now ptrdiff_t, not int.
48 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
49 Adjust to new way of storing sizes. Check for size overflow bugs
51 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
52 slightly wrong anyway, as it missed one instance of
53 XMALLOC_OVERRUN_CHECK_OVERHEAD.
54 (refill_memory_reserve): Omit needless cast to size_t.
55 (mark_object_loop_halt): Mark as externally visible.
57 * xselect.c: Integer signedness and overflow fixes.
58 (Fx_register_dnd_atom, x_handle_dnd_message):
59 Use ptrdiff_t, not size_t, since we prefer signed.
60 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
61 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
62 x_dnd_atoms_size and x_dnd_atoms_length.
64 * doprnt.c: Prefer signed to unsigned when either works.
69 Use ptrdiff_t, not size_t, when using or implementing doprnt,
70 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
71 prefer signed arithmetic to avoid comparison confusion.
72 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
75 Assume freestanding C89 headers, string.h, stdlib.h.
76 * data.c, doprnt.c, floatfns.c, print.c:
77 Include float.h unconditionally.
78 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
79 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
80 * regex.c: Likewise for stddef.h, string.h.
81 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
82 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
83 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
84 (STDC_HEADERS): Remove obsolete defines.
85 * sysdep.c: Include limits.h unconditionally.
87 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
89 Assume support for memcmp, memcpy, memmove, memset.
90 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
91 * regex.c (memcmp, memcpy):
92 Remove; we assume C89 now.
94 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
95 (__malloc_safe_bcopy): Remove; no longer needed.
97 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
98 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
99 well either way, and we prefer signed to unsigned.
101 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
103 Remove unportable assumption about struct layout (Bug#8884).
104 * alloc.c (mark_buffer):
105 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
106 (clone_per_buffer_values): Don't assume that
107 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
108 This isn't true in general, and it's particularly not true
109 if Emacs is configured with --with-wide-int.
110 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
111 New macros, used in the buffer.c change.
113 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
115 * xsettings.c: Use both GConf and GSettings if both are available.
116 (store_config_changed_event): Add comment.
117 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
118 (store_tool_bar_style_changed): New functions.
119 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
120 (struct xsettings): Move font inside HAVE_XFT.
121 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
122 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
123 Move inside HAVE_XFT.
124 (something_changed_gsettingsCB): Renamed from something_changedCB.
125 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
127 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
128 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
129 (something_changed_gconfCB): Renamed from something_changedCB.
130 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
131 (parse_settings): Move check for font inside HAVE_XFT.
132 (read_settings, apply_xft_settings): Add comment.
133 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
134 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
135 call store_font_name_changed.
136 (xft_settings_event): Add comment.
137 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
138 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
139 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
140 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
141 (xsettings_initialize): Call init_gsettings last.
142 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
145 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
147 Random fixes. E.g., (random) never returned negative values.
148 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
149 subseconds part to the entropy, as that's a bit more random.
150 Prefer signed to unsigned, since the signedness doesn't matter and
151 in general we prefer signed. When given a limit, use a
152 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
153 latter isn't right if USE_2_TAGS_FOR_INTS.
154 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
155 not 0..VALMASK. Don't discard "excess" bits that random () returns.
157 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
159 * textprop.c (text_property_stickiness):
160 Obey Vtext_property_default_nonsticky.
161 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
162 * w32fns.c (syms_of_w32fns):
163 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
165 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
167 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
168 This is more efficient than Ffile_directory_p and avoids a minor race.
170 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
172 * buffer.c (Foverlay_put): Say what the return value is
175 * fileio.c (barf_or_query_if_file_exists): Check first if the file
176 is a directory before asking whether to use the file name
178 (barf_or_query_if_file_exists): Make the "File is a directory"
179 error be more correct.
181 * fns.c (Frequire): Remove the mention of the .gz files, since
182 that's installation-specific, but keep the mention of
185 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
187 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
188 Report string overflow if the output is too long.
190 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
192 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
193 (syms_of_gnutls): Remove duplicate DEFSYM for
194 Qgnutls_bootprop_verify_hostname_error, an error for
195 Qgnutls_bootprop_verify_error (which is no longer used).
197 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
198 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
199 Also (re)move comments that are misplaced or no longer relevant.
201 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
203 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
205 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
207 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
208 and background color parameters if they have been changed.
210 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
212 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
214 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
216 * xsettings.c (SYSTEM_FONT): Define only when used.
217 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
219 * keymap.c (access_keymap_1): Now static.
221 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
223 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
224 leave any prefix arg for the up event (Bug#1586).
226 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
228 * lread.c (syms_of_lread): Mention single symbols defined by
229 `defvar' or `defconst' (bug#7154).
231 * fns.c (Frequire): Mention .el.gz files (bug#7314).
232 (Frequire): Mention get-load-suffixes.
234 2011-07-02 Martin Rudalics <rudalics@gmx.at>
236 * window.h (window): Remove clone_number slot.
237 * window.c (Fwindow_clone_number, Fset_window_clone_number):
239 (make_parent_window, make_window, saved_window)
240 (Fset_window_configuration, save_window_save): Don't deal with
242 * buffer.c (Qclone_number): Remove declaration.
243 (sort_overlays, overlay_strings): Don't deal with clone numbers.
245 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
247 Add multiple inheritance to keymaps.
248 * keymap.c (Fmake_composed_keymap): New function.
249 (Fset_keymap_parent): Simplify.
250 (fix_submap_inheritance): Remove.
251 (access_keymap_1): New function extracted from access_keymap to handle
252 embedded parents and handle lists of maps.
253 (access_keymap): Use it.
254 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
255 (Fcopy_keymap): Handle embedded parents.
256 (Fcommand_remapping, define_as_prefix): Simplify.
257 (Fkey_binding): Simplify.
258 (syms_of_keymap): Move minibuffer-local-completion-map,
259 minibuffer-local-filename-completion-map,
260 minibuffer-local-must-match-map, and
261 minibuffer-local-filename-must-match-map to Elisp.
262 (syms_of_keymap): Defsubr make-composed-keymap.
263 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
264 (parse_menu_item): Trivial simplification.
266 2011-07-01 Glenn Morris <rgm@gnu.org>
268 * Makefile.in (SETTINGS_LIBS): Fix typo.
270 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
272 * coding.c (Fencode_coding_string): Record the last coding system
273 used, as the function doc string says (bug#8738).
275 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
277 * xsettings.c (store_monospaced_changed): Take new font as arg and
278 check for change against current_mono_font.
279 (EMACS_TYPE_SETTINGS): Remove this and related defines.
280 (emacs_settings_constructor, emacs_settings_get_property)
281 (emacs_settings_set_property, emacs_settings_class_init)
282 (emacs_settings_init, gsettings_obj): Remove.
283 (something_changedCB): New function for HAVE_GSETTINGS.
284 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
285 with value as argument.
286 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
287 g_settings_new (Bug#8967). Do not create gsettings_obj.
288 Remove calls to g_settings_bind. Connect something_changedCB to
291 * xgselect.c: Add defined (HAVE_GSETTINGS).
292 (xgselect_initialize): Ditto.
294 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
295 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
298 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
300 * eval.c (struct backtrace): Simplify and port the data structure.
301 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
302 signed bit field, as this assumption is not portable and it makes
303 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
304 "char debug_on_exit : 1" as this is not portable either; instead,
305 use the portable "unsigned int debug_on_exit : 1". Remove unused
306 member evalargs. Remove obsolete comments about cc bombing out.
308 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
310 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
311 Let HAVE_GSETTINGS override HAVE_GCONF.
312 (store_monospaced_changed): New function.
313 (EMACS_SETTINGS): A new type derived from GObject to handle
314 GSettings notifications.
315 (emacs_settings_constructor, emacs_settings_get_property)
316 (emacs_settings_set_property, emacs_settings_class_init):
318 (gsettings_client, gsettings_obj): New variables.
319 (GSETTINGS_SCHEMA): New define.
320 (something_changedCB): Call store_monospaced_changed.
321 (init_gsettings): New function.
322 (xsettings_initialize): Call init_gsettings.
323 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
326 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
329 2011-06-29 Martin Rudalics <rudalics@gmx.at>
331 * window.c (resize_root_window, grow_mini_window)
332 (shrink_mini_window): Rename Qresize_root_window to
333 Qwindow_resize_root_window and Qresize_root_window_vertically to
334 Qwindow_resize_root_window_vertically.
336 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
338 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
340 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
342 * makefile.w32-in: Redesign dependencies so they reflect more
343 clearly which files are directly included by each source file,
344 and not through other includes.
346 2011-06-27 Martin Rudalics <rudalics@gmx.at>
348 * buffer.c (Qclone_number): Declare static and DEFSYM it.
349 (sort_overlays, overlay_strings): When an overlay's clone number
350 matches the window's clone number process the overlay even if
351 the overlay's window property doesn't match the current window.
353 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
354 (Fwindow_hchild): Rename to Fwindow_left_child.
355 (Fwindow_next): Rename to Fwindow_next_sibling.
356 (Fwindow_prev): Rename to Fwindow_prev_sibling.
357 (resize_window_check): Rename to window_resize_check.
358 (resize_window_apply): Rename to window_resize_apply.
359 (Fresize_window_apply): Rename to Fwindow_resize_apply.
360 (Fdelete_other_windows_internal, resize_frame_windows)
361 (Fsplit_window_internal, Fdelete_window_internal)
362 (grow_mini_window, shrink_mini_window)
363 (Fresize_mini_window_internal): Fix callers accordingly.
365 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
367 * emacsgtkfixed.h: State that this is only used with Gtk+3.
368 (emacs_fixed_set_min_size): Remove.
369 (emacs_fixed_new): Take frame as argument.
371 * emacsgtkfixed.c: State that this is only used with Gtk+3.
372 (_EmacsFixedPrivate): Remove minwidth/height.
374 (emacs_fixed_init): Initialize priv->f.
375 (get_parent_class, emacs_fixed_set_min_size): Remove.
376 (emacs_fixed_new): Set priv->f to argument.
377 (emacs_fixed_get_preferred_width)
378 (emacs_fixed_get_preferred_height): Use min_width/height from
379 frames size_hint to set minimum and natural (Bug#8919).
380 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
381 and use min_width/height from frames size_hint to set
382 min_width/height (Bug#8919).
384 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
385 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
388 2011-06-26 Eli Zaretskii <eliz@gnu.org>
390 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
391 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
394 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
396 * process.c (wait_reading_process_output): Bypass select if
397 waiting for a cell while ignoring keyboard input, and input is
398 pending. Suggested by Jan Djärv (Bug#8869).
400 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
402 Use gnulib's dup2 module instead of rolling our own.
403 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
405 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
407 * dispnew.c (scrolling_window): Before scrolling, turn off a
408 mouse-highlight in the window being scrolled.
410 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
412 Move DEFSYM to lisp.h and use everywhere.
414 * character.h (DEFSYM): Move declaration...
415 * lisp.h (DEFSYM): ...here.
421 * w32select.c: Don't include character.h.
423 * alloc.c (syms_of_alloc):
424 * buffer.c (syms_of_buffer):
425 * bytecode.c (syms_of_bytecode):
426 * callint.c (syms_of_callint):
427 * casefiddle.c (syms_of_casefiddle):
428 * casetab.c (init_casetab_once):
429 * category.c (init_category_once, syms_of_category):
430 * ccl.c (syms_of_ccl):
431 * cmds.c (syms_of_cmds):
432 * composite.c (syms_of_composite):
433 * dbusbind.c (syms_of_dbusbind):
434 * dired.c (syms_of_dired):
435 * dispnew.c (syms_of_display):
436 * doc.c (syms_of_doc):
437 * editfns.c (syms_of_editfns):
438 * emacs.c (syms_of_emacs):
439 * eval.c (syms_of_eval):
440 * fileio.c (syms_of_fileio):
441 * fns.c (syms_of_fns):
442 * frame.c (syms_of_frame):
443 * fringe.c (syms_of_fringe):
444 * insdel.c (syms_of_insdel):
445 * keymap.c (syms_of_keymap):
446 * lread.c (init_obarray, syms_of_lread):
447 * macros.c (syms_of_macros):
448 * msdos.c (syms_of_msdos):
449 * print.c (syms_of_print):
450 * process.c (syms_of_process):
451 * search.c (syms_of_search):
452 * sound.c (syms_of_sound):
453 * syntax.c (init_syntax_once, syms_of_syntax):
454 * terminal.c (syms_of_terminal):
455 * textprop.c (syms_of_textprop):
456 * undo.c (syms_of_undo):
457 * w32.c (globals_of_w32):
458 * window.c (syms_of_window):
459 * xdisp.c (syms_of_xdisp):
460 * xfaces.c (syms_of_xfaces):
461 * xfns.c (syms_of_xfns):
462 * xmenu.c (syms_of_xmenu):
463 * xsettings.c (syms_of_xsettings):
464 * xterm.c (syms_of_xterm): Use DEFSYM.
466 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
468 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
470 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
472 Integer and buffer overflow fixes (Bug#8873).
474 * print.c (printchar, strout): Check for string overflow.
475 (PRINTPREPARE, printchar, strout):
476 Don't set size unless allocation succeeds.
478 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
479 for sizes. Check for string overflow more accurately.
480 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
482 * macros.c: Integer and buffer overflow fixes.
483 * keyboard.h (struct keyboard.kbd_macro_bufsize):
484 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
485 Use ptrdiff_t, not int, for sizes.
486 Don't increment bufsize until after realloc succeeds.
487 Check for size-calculation overflow.
488 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
490 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
492 * lread.c: Integer overflow fixes.
493 (read_integer): Radix is now EMACS_INT, not int,
494 to improve quality of diagnostics for out-of-range radices.
495 Calculate buffer size correctly for out-of-range radices.
496 (read1): Check for integer overflow in radices, and in
498 (read_escape): Avoid int overflow.
499 (Fload, openp, read_buffer_size, read1)
500 (substitute_object_recurse, read_vector, read_list, map_obarray):
501 Use ptrdiff_t, not int, for sizes.
502 (read1): Use EMACS_INT, not int, for sizes.
503 Check for size overflow.
505 * image.c (cache_image): Check for size arithmetic overflow.
507 * lread.c: Integer overflow issues.
508 (saved_doc_string_size, saved_doc_string_length)
509 (prev_saved_doc_string_size, prev_saved_doc_string_length):
510 Now ptrdiff_t, not int.
511 (read1): Don't assume doc string length fits in int. Check for
512 out-of-range doc string lengths.
513 (read_list): Don't assume file position fits in int.
514 (read_escape): Check for hex character overflow.
516 2011-06-22 Leo Liu <sdl.web@gmail.com>
518 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
519 Move to minibuffer.el.
521 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
523 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
524 The following patches are for when GLYPH_DEBUG && !XASSERT.
525 * dispextern.h (trace_redisplay_p, dump_glyph_string):
526 * dispnew.c (flush_stdout):
527 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
528 Mark as externally visible.
529 * dispnew.c (check_window_matrix_pointers): Now static.
530 * dispnew.c (window_to_frame_vpos):
531 * xfns.c (unwind_create_frame):
532 * xterm.c (x_check_font): Remove unused local.
533 * scroll.c (CHECK_BOUNDS):
534 * xfaces.c (cache_fache): Rename local to avoid shadowing.
535 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
536 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
537 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
538 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
540 (debug_method_add): Use va_list and vsprintf rather than relying
541 on undefined behavior with wrong number of arguments.
542 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
543 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
544 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
545 since we're not interested in debugging glyphs with old libraries.
546 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
547 GCC 4.6.0's static checking.
549 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
551 Integer overflow and signedness fixes (Bug#8873).
552 A few related buffer overrun fixes, too.
554 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
556 * dispextern.h (struct face.stipple):
557 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
558 (x_bitmap_mask, x_allocate_bitmap_record)
559 (x_create_bitmap_from_data, x_create_bitmap_from_file)
560 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
561 (x_create_bitmap_from_xpm_data):
562 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
563 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
565 * xfaces.c (load_pixmap):
566 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
567 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
568 (.bitmaps_last, struct x_output.icon_bitmap):
569 Use ptrdiff_t, not int, for bitmap indexes.
570 (x_allocate_bitmap_record): Check for size overflow.
571 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
573 Use ptrdiff_t, not int, for overlay counts.
574 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
575 * editfns.c (overlays_around, get_pos_property):
576 * textprop.c (get_char_property_and_overlay):
577 * xdisp.c (next_overlay_change, note_mouse_highlight):
578 * xfaces.c (face_at_buffer_position):
579 * buffer.c (OVERLAY_COUNT_MAX): New macro.
580 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
581 (Fnext_overlay_change, Fprevious_overlay_change)
582 (mouse_face_overlay_overlaps, Foverlays_in):
583 Use ptrdiff_t, not int, for sizes.
584 (overlays_at, overlays_in): Check for size-calculation overflow.
586 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
588 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
589 (x_session_initialize): Do not assume string length fits in int.
591 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
592 This is unlikely, but can occur if DPI is outlandish.
594 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
595 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
597 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
598 * xrdb.c (magic_file_p, search_magic_path):
599 Omit last arg SUFFIX; it was always 0. All callers changed.
600 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
602 * xfont.c (xfont_match): Avoid need for strlen.
604 * xfns.c: Don't assume strlen fits in int.
605 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
607 * xdisp.c (message_log_check_duplicate): Return intmax_t,
608 not unsigned long, as we prefer signed integers. All callers changed.
609 Detect integer overflow in repeat count.
610 (message_dolog): Don't assume print length fits in 39 bytes.
611 (display_mode_element): Don't assume strlen fits in int.
613 * termcap.c: Don't assume sizes fit in int and never overflow.
614 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
615 (gobble_line): Check for size-calculation overflow.
617 * minibuf.c (Fread_buffer):
618 * lread.c (intern, intern_c_string):
619 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
620 Don't assume string length fits in int.
622 * keyboard.c (parse_tool_bar_item):
623 * gtkutil.c (style_changed_cb): Avoid need for strlen.
625 * font.c: Don't assume string length fits in int.
626 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
627 Use ptrdiff_t, not int.
628 (font_intern_prop): Don't assume string length fits in int.
629 Don't assume integer property fits in fixnum.
630 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
632 * filelock.c: Fix some buffer overrun and integer overflow issues.
633 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
634 Reformulate so as not to need the command string.
635 Invoke gzip -cd rather than gunzip, as it's more portable.
636 (lock_info_type, lock_file_1, lock_file):
637 Don't assume pid_t and time_t fit in unsigned long.
638 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
639 (current_lock_owner): Prefer signed type for sizes.
640 Use memcpy, not strncpy, where memcpy is what is really wanted.
641 Don't assume (via atoi) that time_t and pid_t fit in int.
642 Check for time_t and/or pid_t out of range, e.g., via a network share.
643 Don't alloca where an auto var works fine.
645 * fileio.c: Fix some integer overflow issues.
646 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
647 Don't assume string length fits in int.
648 (directory_file_name): Don't assume string length fits in long.
649 (make_temp_name): Don't assume pid fits in int, or that its print
650 length is less than 20.
652 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
654 * coding.c (make_subsidiaries): Don't assume string length fits in int.
656 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
658 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
659 We prefer signed integers, even for size calculations.
661 * emacs.c: Don't assume string length fits in 'int'.
662 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
663 (main): Don't invoke strlen when not needed.
665 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
666 (XD_DEBUG_MESSAGE): Don't waste a byte.
668 * callproc.c (getenv_internal_1, getenv_internal)
670 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
672 * lread.c (invalid_syntax): Omit length argument.
673 All uses changed. This doesn't fix a bug, but it simplifies the
674 code away from its former Hollerith-constant appearance, and it's
675 one less 'int' to worry about when looking at integer-overflow issues.
676 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
678 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
679 This didn't break anything, but it didn't help either.
680 It's confusing to put a bogus integer in a place where the actual
681 value does not matter.
682 (LIST_END_P): Remove unused macro and its bogus comment.
683 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
685 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
686 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
688 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
689 We prefer signed types, and the value cannot exceed the EMACS_INT
690 range anyway (because otherwise the length would not be representable).
691 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
692 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
693 This avoids a GCC warning when WIDE_EMACS_INT.
695 * indent.c (sane_tab_width): New function.
696 (current_column, scan_for_column, Findent_to, position_indentation)
697 (compute_motion): Use it. This is just for clarity.
698 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
700 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
702 * lisp.h (lint_assume): New macro.
703 * composite.c (composition_gstring_put_cache):
704 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
706 * editfns.c, insdel.c:
707 Omit unnecessary forward decls, to simplify future changes.
709 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
711 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
713 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
714 Use much-faster test for byte-length change.
715 Don't assume string byte-length fits in 'int'.
716 Check that character arg fits in 'int'.
717 (mapcar1): Declare byte as byte, for clarity.
719 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
721 * fns.c (concat): Catch string overflow earlier.
722 Do not rely on integer wraparound.
724 * dispextern.h (struct it.overlay_strings_charpos)
725 (struct it.selective): Now EMACS_INT, not int.
726 * xdisp.c (forward_to_next_line_start)
727 (back_to_previous_visible_line_start)
728 (reseat_at_next_visible_line_start, next_element_from_buffer):
729 Don't arbitrarily truncate the value of 'selective' to int.
731 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
733 * composite.c: Don't truncate sizes to 'int'.
734 (composition_gstring_p, composition_reseat_it)
735 (composition_adjust_point): Use EMACS_INT, not int.
736 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
737 not EMACS_UINT, for indexes.
739 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
741 * buffer.c: Include <verify.h>.
742 (struct sortvec.priority, struct sortstr.priority):
743 Now EMACS_INT, not int.
744 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
745 (struct sortstr.size, record_overlay_string)
746 (struct sortstrlist.size, struct sortlist.used):
747 Don't truncate size to int.
748 (record_overlay_string): Check for size-calculation overflow.
749 (init_buffer_once): Check at compile-time, not run-time.
751 2011-06-22 Jim Meyering <meyering@redhat.com>
753 Don't leak an XBM-image-sized buffer
754 * image.c (xbm_load): Free the image buffer after using it.
756 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
759 * composite.c (find_automatic_composition): Omit needless 'return 0;'
760 that Sun C diagnosed.
761 * fns.c (secure_hash): Fix pointer signedness issue.
762 * intervals.c (static_offset_intervals): New function.
763 (offset_intervals): Use it.
765 2011-06-21 Leo Liu <sdl.web@gmail.com>
768 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
771 * fns.c (secure_hash): Rename from crypto_hash_function and change
772 the first arg to accept symbols.
773 (Fsecure_hash): New primitive.
774 (syms_of_fns): New symbols.
776 2011-06-20 Deniz Dogan <deniz@dogan.se>
778 * process.c (Fset_process_buffer): Clarify return value in
781 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
783 * dispnew.c (add_window_display_history): Use BVAR.
785 * xdisp.c (debug_method_add): Use BVAR.
786 (check_window_end, dump_glyph_matrix, dump_glyph)
787 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
789 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
792 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
793 check till after the cache is created in init_frame_faces.
795 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
797 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
799 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
801 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
802 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
803 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
805 Improve buffer-overflow checking (Bug#8873).
806 * fileio.c (Finsert_file_contents):
807 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
808 Remove the old (too-loose) buffer overflow checks.
809 They weren't needed, since make_gap checks for buffer overflow.
810 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
811 The old code merely checked for Emacs fixnum overflow, and relied
812 on undefined (wraparound) behavior. The new code avoids undefined
813 behavior, and also checks for ptrdiff_t and/or size_t overflow.
815 * editfns.c (Finsert_char): Don't dump core with very negative counts.
816 Tune. Don't use wider integers than needed. Don't use alloca.
817 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
819 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
821 * insdel.c, lisp.h (buffer_overflow): New function.
822 (insert_from_buffer_1, replace_range, replace_range_2):
823 * insdel.c (make_gap_larger):
824 * editfns.c (Finsert_char):
825 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
827 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
829 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
831 Integer overflow and signedness fixes (Bug#8873).
833 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
834 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
836 * fileio.c: Don't assume EMACS_INT fits in off_t.
837 (emacs_lseek): New static function.
838 (Finsert_file_contents, Fwrite_region): Use it.
839 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
841 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
843 * fns.c: Don't overflow int when computing a list length.
844 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
845 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
846 truncation on 64-bit hosts. Check for QUIT every
847 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
848 faster and is responsive enough.
849 (Flength): Report an error instead of overflowing an integer.
850 (Fsafe_length): Return a float if the value is not representable
851 as a fixnum. This shouldn't happen except in contrived situations.
852 (Fnthcdr, Fsort): Don't assume list length fits in int.
853 (Fcopy_sequence): Don't assume vector length fits in int.
855 * alloc.c: Check that resized vectors' lengths fit in fixnums.
856 (header_size, word_size): New constants.
857 (allocate_vectorlike): Don't check size overflow here.
858 (allocate_vector): Check it here instead, since this is the only
859 caller of allocate_vectorlike that could cause overflow.
860 Check that the new vector's length is representable as a fixnum.
862 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
863 The previous code was bogus. For example, next_almost_prime (32)
864 returned 39, which is undesirable as it is a multiple of 3; and
865 next_almost_prime (24) returned 25, which is a multiple of 5 so
866 why was the code bothering to check for multiples of 7?
868 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
870 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
872 Variadic C functions now count arguments with ptrdiff_t.
873 This partly undoes my 2011-03-30 change, which replaced int with size_t.
874 Back then I didn't know that the Emacs coding style prefers signed int.
875 Also, in the meantime I found a few more instances where arguments
876 were being counted with int, which may truncate counts on 64-bit
877 machines, or EMACS_INT, which may be unnecessarily wide.
878 * lisp.h (struct Lisp_Subr.function.aMANY)
879 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
880 Arg counts are now ptrdiff_t, not size_t.
881 All variadic functions and their callers changed accordingly.
882 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
883 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
884 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
885 * callint.c (Fcall_interactively): Check arg count for overflow,
886 to avoid potential buffer overrun. Use signed char, not 'int',
887 for 'varies' array, so that we needn't bother to check its size
888 calculation for overflow.
889 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
890 * eval.c (apply_lambda):
891 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
892 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
893 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
895 * callint.c (Fcall_interactively): Don't use index var as event count.
897 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
898 * mem-limits.h (SIZE): Remove; no longer used.
900 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
902 Remove unnecessary casts.
903 * xterm.c (x_term_init):
904 * xfns.c (x_set_border_pixel):
905 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
906 These aren't needed now that we assume ANSI C.
908 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
909 It's more likely to cause problems (due to unsigned overflow)
912 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
914 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
916 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
918 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
920 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
922 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
924 GLYPH_CODE_FACE returns EMACS_INT, not int.
925 * dispextern.h (merge_faces):
926 * xfaces.c (merge_faces):
927 * xdisp.c (get_next_display_element, next_element_from_display_vector):
928 Don't assume EMACS_INT fits in int.
930 * character.h (CHAR_VALID_P): Remove unused parameter.
931 * fontset.c, lisp.h, xdisp.c: All uses changed.
933 * editfns.c (Ftranslate_region_internal): Omit redundant test.
935 * fns.c (concat): Minor tuning based on overflow analysis.
936 This doesn't fix any bugs. Use int to hold character, instead
937 of constantly refetching from Emacs object. Use XFASTINT, not
938 XINT, for value known to be a character. Don't bother comparing
939 a single byte to 0400, as it's always less.
941 * floatfns.c (Fexpt):
942 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
944 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
947 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
949 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
950 Without this fix, on a 64-bit host (aset S 0 4294967386) would
951 incorrectly succeed when S was a string, because 4294967386 was
952 truncated before it was used.
954 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
955 Otherwise, an out-of-range integer could cause undefined behavior
958 * composite.c: Use int, not EMACS_INT, for characters.
959 (fill_gstring_body, composition_compute_stop_pos): Use int, not
960 EMACS_INT, for values that are known to be in character range.
961 This doesn't fix any bugs but is the usual style inside Emacs and
962 may generate better code on 32-bit machines.
964 Make sure a 64-bit char is never passed to ENCODE_CHAR.
965 This is for reasons similar to the recent CHAR_STRING fix.
966 * charset.c (Fencode_char): Check that character arg is actually
967 a character. Pass an int to ENCODE_CHAR.
968 * charset.h (ENCODE_CHAR): Verify that the character argument is no
969 wider than 'int', as a compile-time check to prevent future regressions
972 * character.c (char_string): Remove unnecessary casts.
974 Make sure a 64-bit char is never passed to CHAR_STRING.
975 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
976 by silently ignoring the top 32 bits, allowing some values
977 that were far too large to be valid characters.
978 * character.h: Include <verify.h>.
979 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
980 arguments are no wider than unsigned, as a compile-time check
981 to prevent future regressions in this area.
983 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
984 (Fsubst_char_in_region):
986 * xdisp.c (decode_mode_spec_coding):
987 Adjust to CHAR_STRING's new requirement.
988 * editfns.c (Finsert_char, Fsubst_char_in_region):
989 * fns.c (concat): Check that character args are actually
990 characters. Without this test, these functions did the wrong
991 thing with wildly out-of-range values on 64-bit hosts.
993 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
994 These casts should not be needed on 32-bit hosts, either.
995 * keyboard.c (read_char):
996 * lread.c (Fload): Remove casts to unsigned.
998 * lisp.h (UNSIGNED_CMP): New macro.
999 This fixes comparison bugs on 64-bit hosts.
1000 (ASCII_CHAR_P): Use it.
1001 * casefiddle.c (casify_object):
1002 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1003 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1004 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1005 * dispextern.h (FACE_FROM_ID):
1006 * keyboard.c (read_char): Use UNSIGNED_CMP.
1008 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1009 not to EMACS_INT, to avoid GCC warning.
1011 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1013 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1014 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1015 isn't needed on 32-bit machines.
1017 * buffer.c (Fgenerate_new_buffer_name):
1018 Use EMACS_INT for count, not int.
1019 (advance_to_char_boundary): Return EMACS_INT, not int.
1021 * data.c (Qcompiled_function): Now static.
1023 * window.c (window_body_lines): Now static.
1025 * image.c (gif_load): Rename local to avoid shadowing.
1027 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1028 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1029 * alloc.c (make_save_value): Integer argument is now of type
1031 (mark_object): Use ptrdiff_t, not int.
1032 * lisp.h (pD): New macro.
1033 * print.c (print_object): Use it.
1035 * alloc.c: Use EMACS_INT, not int, to count objects.
1036 (total_conses, total_markers, total_symbols, total_vector_size)
1037 (total_free_conses, total_free_markers, total_free_symbols)
1038 (total_free_floats, total_floats, total_free_intervals)
1039 (total_intervals, total_strings, total_free_strings):
1040 Now EMACS_INT, not int. All uses changed.
1041 (Fgarbage_collect): Compute overall total using a double, so that
1042 integer overflow is less likely to be a problem. Check for overflow
1043 when converting back to an integer.
1044 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1045 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1046 These were 'int' variables that could overflow on 64-bit hosts;
1047 they were never used, so remove them instead of repairing them.
1048 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1049 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1050 Previously, this ceilinged at INT_MAX, but that doesn't work on
1052 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1054 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1055 (allocate_vectorlike): Check for ptrdiff_t overflow.
1056 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1057 when a (possibly-narrower) signed value would do just as well.
1058 We prefer using signed arithmetic, to avoid comparison confusion.
1060 * alloc.c: Catch some string size overflows that we were missing.
1061 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1062 for convenience in STRING_BYTES_MAX.
1063 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1064 The definition here is exact; the one in lisp.h was approximate.
1065 (allocate_string_data): Check for string overflow. This catches
1066 some instances we weren't catching before. Also, it catches
1067 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1068 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1069 and ptrdiff_t and EMACS_INT are both 64 bits.
1071 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1072 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1073 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1075 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1077 * alloc.c (Fmake_string): Check for out-of-range init.
1079 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1081 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1083 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1085 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1086 xg_get_default_scrollbar_width.
1088 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1089 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1090 (style_changed_cb): Call update_theme_scrollbar_width and call
1091 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1092 all frames (Bug#8505).
1093 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1094 Call gtk_window_set_resizable if HAVE_GTK3.
1095 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1096 and height if HAVE_GTK3 (Bug#8505).
1097 (scroll_bar_width_for_theme): New variable.
1098 (update_theme_scrollbar_width): New function.
1099 (xg_get_default_scrollbar_width): Move code to
1100 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1101 (xg_initialize): Call update_theme_scrollbar_width.
1103 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1105 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1107 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1109 * frame.c (make_frame): Call other_buffer_safely instead of
1112 * window.c (temp_output_buffer_show): Call display_buffer with
1113 second argument Vtemp_buffer_show_specifiers and reset latter
1114 immediately after the call.
1115 (Vtemp_buffer_show_specifiers): New variable.
1116 (auto_window_vscroll_p, next_screen_context_lines)
1117 (Vscroll_preserve_screen_position): Remove leading asterisks from
1120 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1122 Fix minor problems found by GCC 4.6.0 static checking.
1123 * buffer.c (Qclone_number): Remove for now, as it's unused.
1124 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1125 (record_buffer): Remove unused local.
1126 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1127 (set_frame_buffer_list): Remove; unused.
1128 * frame.h (other_visible_frames): Remove decl.
1129 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1130 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1131 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1133 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1134 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1135 Define only if HAVE_GPM.
1136 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1137 (update_hints_inhibit): Remove; never set. All uses removed.
1138 * widgetprv.h (emacsFrameClassRec): Remove decl.
1139 * window.c (delete_deletable_window): Now returns void, since it
1140 wasn't returning anything.
1141 (compare_window_configurations): Remove unused locals.
1142 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1143 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1144 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1145 the same widths as pointers. This follows up on the 2011-05-06 patch.
1146 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1147 * xterm.h: Likewise.
1148 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1150 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1152 * makefile.w32-in: Update dependencies.
1153 (LISP_H): Add lib/intprops.h.
1155 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1157 * image.c (gif_load): Add animation frame delay to the metadata.
1158 (syms_of_image): Use DEFSYM. New symbol `delay'.
1160 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1162 * window.c (delete_deletable_window): Re-add.
1163 (Fset_window_configuration): Rewrite to handle dead buffers and
1164 consequently deletable windows.
1165 (window_tree, Fwindow_tree): Remove. Supply functionality in
1167 (compare_window_configurations): Simplify code.
1169 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1171 * image.c (imagemagick_load_image): Fix type mismatch.
1172 (Fimagemagick_types): Likewise.
1174 * window.h (replace_buffer_in_windows): Declare.
1176 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1178 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1179 Qclone_number. Remove external declaration of Qdelete_window.
1180 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1182 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1183 Qbuffer_list_update_hook if allowed.
1184 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1185 buffer list implementation.
1186 (other_buffer_safely): New function.
1187 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1188 calls to replace_buffer_in_windows and
1189 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1191 (record_buffer): Inhibit quitting and rewrite using quittable
1192 functions. Run Qbuffer_list_update_hook if allowed.
1193 (Frecord_buffer, Funrecord_buffer): New functions.
1194 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1195 switch-to-buffer to window.el.
1196 (bury-buffer): Move to window.el.
1197 (Vbuffer_list_update_hook): New variable.
1199 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1202 * window.h (resize_frame_windows): Move up in code.
1203 (Fwindow_frame): Remove EXFUN.
1204 (replace_buffer_in_all_windows): Remove prototype.
1205 (replace_buffer_in_windows_safely): Add prototype.
1207 * window.c: Declare Qdelete_window static again. Move down
1208 declaration of select_count.
1209 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1210 (Fother_window): Move to window.el.
1211 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1212 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1213 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1215 (replace_buffer_in_windows): Implement by calling
1216 Qreplace_buffer_in_windows.
1217 (replace_buffer_in_all_windows): Remove with some functionality
1218 moved into replace_buffer_in_windows_safely.
1219 (replace_buffer_in_windows_safely): New function.
1220 (select_window_norecord, select_frame_norecord): Move in front
1221 of run_window_configuration_change_hook. Remove now obsolete
1223 (Fset_window_buffer): Rewrite doc-string. Call
1224 Qrecord_window_buffer.
1225 (keys_of_window): Move binding for other-window to window.el.
1227 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1229 * dispextern.h (struct image): Replace data member, whose int_val
1230 and ptr_val fields were not used by anything, with a single
1233 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1234 (gif_clear_image, gif_load, imagemagick_load_image)
1235 (gs_clear_image, gs_load): Callers changed.
1237 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1239 * buffer.h: Include <time.h>, for time_t.
1240 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1242 Fix minor problems found by static checking.
1244 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1246 Make identifiers static if they are not used in other modules.
1247 * data.c (Qcompiled_function, Qframe, Qvector):
1248 * image.c (QimageMagick, Qsvg):
1249 * minibuf.c (Qmetadata):
1250 * window.c (resize_window_check, resize_root_window): Now static.
1251 * window.h (resize_window_check, resize_root_window): Remove decls.
1253 * window.c (window_deletion_count, delete_deletable_window):
1255 (window_body_lines): Now static.
1256 (Fdelete_other_windows_internal): Mark vars as initialized.
1257 Make sure 'resize_failed' is initialized.
1258 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1259 (resize_window_apply): Remove unused local.
1260 * window.h (delete_deletable_window): Remove decl.
1262 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1263 (imagemagick_load_image): Fix pointer signedness problem by changing
1264 last arg from unsigned char * to char *. All uses changed.
1265 Also, fix a local for similar reasons.
1266 Remove unused locals. Remove locals to avoid shadowing.
1267 (fn_rsvg_handle_free): Remove; unused.
1268 (svg_load, svg_load_image): Fix pointer signedness problem.
1269 (imagemagick_load_image): Don't use garbage pointer image_wand.
1271 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1273 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1275 * image.c (gif_load): Fix omitted cast error introduced by
1278 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1280 * window.h (resize_proportionally, orig_total_lines)
1281 (orig_top_line): Remove from window structure.
1282 (set_window_height, set_window_width, change_window_heights)
1283 (Fdelete_window): Remove prototypes.
1284 (resize_frame_windows): Remove duplicate declaration.
1286 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1288 * window.h (resize_frame_windows, resize_window_check)
1289 (delete_deletable_window, resize_root_window)
1290 (resize_frame_windows): Declare prototypes.
1292 * window.c (resize_window_apply): Make definition be "static" to
1293 match the prototype.
1295 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1297 * window.c: Remove declarations of Qwindow_size_fixed,
1298 window_min_size_1, window_min_size_2, window_min_size,
1299 size_window, window_fixed_size_p, enlarge_window, delete_window.
1300 Remove static from declaration of Qdelete_window, it's
1301 temporarily needed by Fbury_buffer.
1302 (replace_window): Don't assign orig_top_line and
1304 (Fdelete_window, delete_window): Remove. Window deletion is
1305 handled by window.el.
1306 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1307 Fdelete_window calls with calls to Qdelete_window.
1308 (Fdelete_other_windows): Remove. Deleting other windows is
1309 handled by window.el.
1310 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1311 handled in window.el.
1312 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1313 Window minimum sizes are handled in window.el.
1314 (shrink_windows, size_window, set_window_height)
1315 (set_window_width, change_window_heights, window_height)
1316 (window_width, CURBEG, CURSIZE, enlarge_window)
1317 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1318 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1319 handled in window.el.
1320 (make_dummy_parent): Rename to make_parent_window and give it a
1321 second argument horflag.
1322 (make_window): Don't set resize_proportionally any more.
1323 (Fsplit_window): Remove. Windows are split in window.el.
1324 (save_restore_action, save_restore_orig_size)
1325 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1326 Resize mini windows in window.el.
1327 (grow_mini_window, shrink_mini_window): Implement by calling
1328 Qresize_root_window_vertically, resize_window_check and
1329 resize_window_apply.
1330 (saved_window, Fset_window_configuration, save_window_save): Do
1331 not handle orig_top_line, orig_total_lines, and
1332 resize_proportionally.
1333 (window_min_height, window_min_width): Move to window.el.
1334 (keys_of_window): Move bindings for delete-other-windows,
1335 split-window, delete-window and enlarge-window to window.el.
1337 * buffer.c: Temporarily extern Qdelete_window.
1338 (Fbury_buffer): Temporarily call Qdelete_window instead of
1339 Fdelete_window (Fbury_buffer will move to window.el soon).
1341 * frame.c (set_menu_bar_lines_1): Remove code handling
1342 orig_top_line and orig_total_lines.
1344 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1345 set_window_height but set heights directly.
1346 (change_frame_size_1): Use resize_frame_windows.
1348 * xdisp.c (init_xdisp): Don't use set_window_height but set
1351 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1352 resize_frame_windows instead of change_window_heights and run
1353 run_window_configuration_change_hook.
1355 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1356 instead of change_window_heights and run
1357 run_window_configuration_change_hook.
1359 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1361 * window.c (replace_window): Rename second argument REPLACEMENT to
1362 NEW. New third argument SETFLAG. Rewrite.
1363 (delete_window, make_dummy_parent): Call replace_window with
1365 (window_list_1): Move down in code.
1366 (run_window_configuration_change_hook): Move set_buffer part
1367 before select_frame_norecord part in order to unwind correctly.
1368 Rename count1 to count.
1369 (recombine_windows, delete_deletable_window, resize_root_window)
1370 (Fdelete_other_windows_internal)
1371 (Frun_window_configuration_change_hook, make_parent_window)
1372 (resize_window_check, resize_window_apply, Fresize_window_apply)
1373 (resize_frame_windows, Fsplit_window_internal)
1374 (Fdelete_window_internal, Fresize_mini_window_internal): New
1376 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1378 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1380 * window.h (window): Add some new members to window structure -
1381 normal_lines, normal_cols, new_total, new_normal, clone_number,
1382 splits, nest, prev_buffers, next_buffers.
1383 (WINDOW_TOTAL_SIZE): Move here from window.c.
1384 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1386 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1388 (make_dummy_parent): Set new members of windows structure.
1389 (make_window): Move down in code. Handle new members of window
1391 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1392 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1393 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1394 (Fset_window_prev_buffers, Fwindow_next_buffers)
1395 (Fset_window_next_buffers, Fset_window_clone_number): New
1397 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1398 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1400 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1401 Argument WINDOW can be now internal window too.
1402 (Fwindow_use_time): Move up in code.
1403 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1405 (Fset_window_configuration, saved_window)
1406 (Fcurrent_window_configuration, save_window_save): Handle new
1407 members of window structure.
1408 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1409 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1410 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1411 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1412 Qget_mru_window, Qresize_root_window,
1413 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1414 Qauto_buffer_name; staticpro them.
1416 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1418 * window.c (Fwindow_total_size, Fwindow_left_column)
1419 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1420 (Fwindow_list_1): New functions.
1421 (window_box_text_cols): Replace with window_body_cols.
1422 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1423 window_body_cols instead of window_box_text_cols.
1424 (delete_window, Fset_window_configuration): Call
1425 delete_all_subwindows with window as argument.
1426 (delete_all_subwindows): Take a window as argument and not a
1428 (window_loop): Remove handling of GET_LRU_WINDOW and
1430 (Fget_lru_window, Fget_largest_window): Move to window.el.
1432 * window.h: Extern window_body_cols instead of
1433 window_box_text_cols. delete_all_subwindows now takes a
1434 Lisp_Object as argument.
1436 * indent.c (compute_motion, Fcompute_motion): Use
1437 window_body_cols instead of window_box_text_cols.
1439 * frame.c (delete_frame): Call delete_all_subwindows with root
1442 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1444 * fns.c (Fputhash): Document return value.
1446 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1448 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1450 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1452 Cons<->int and similar integer overflow fixes (Bug#8794).
1454 Check for overflow when converting integer to cons and back.
1455 * charset.c (Fdefine_charset_internal, Fdecode_char):
1456 Use cons_to_unsigned to catch overflow.
1457 (Fencode_char): Use INTEGER_TO_CONS.
1458 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1459 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1460 * data.c (long_to_cons, cons_to_long): Remove.
1461 (cons_to_unsigned, cons_to_signed): New functions.
1462 These signal an error for invalid or out-of-range values.
1463 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1464 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1465 * font.c (Ffont_variation_glyphs):
1466 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1467 * lisp.h: Include <intprops.h>.
1468 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1469 (cons_to_signed, cons_to_unsigned): New decls.
1470 (long_to_cons, cons_to_long): Remove decls.
1471 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1472 (Fprimitive_undo): Use CONS_TO_INTEGER.
1473 * xfns.c (Fx_window_property): Likewise.
1474 * xselect.c: Include <limits.h>.
1475 (x_own_selection, selection_data_to_lisp_data):
1476 Use INTEGER_TO_CONS.
1477 (x_handle_selection_request, x_handle_selection_clear)
1478 (x_get_foreign_selection, Fx_disown_selection_internal)
1479 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1480 (lisp_data_to_selection_data): Use cons_to_unsigned.
1481 (x_fill_property_data): Use cons_to_signed.
1482 Report values out of range.
1484 Check for buffer and string overflow more precisely.
1485 * buffer.h (BUF_BYTES_MAX): New macro.
1486 * lisp.h (STRING_BYTES_MAX): New macro.
1487 * alloc.c (Fmake_string):
1488 * character.c (string_escape_byte8):
1489 * coding.c (coding_alloc_by_realloc):
1490 * doprnt.c (doprnt):
1491 * editfns.c (Fformat):
1493 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1494 since they may not be the same number.
1495 * editfns.c (Finsert_char):
1496 * fileio.c (Finsert_file_contents):
1497 Likewise for BUF_BYTES_MAX.
1499 * image.c: Use ptrdiff_t, not int, for sizes.
1500 (slurp_file): Switch from int to ptrdiff_t.
1502 (slurp_file): Check that file size fits in both size_t (for
1503 malloc) and ptrdiff_t (for sanity and safety).
1505 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1506 if b->modtime has its maximal value.
1508 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1510 Don't assume time_t can fit into int.
1511 * buffer.h (struct buffer.modtime): Now time_t, not int.
1512 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1513 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1515 Minor fixes for signed vs unsigned integers.
1516 * character.h (MAYBE_UNIFY_CHAR):
1517 * charset.c (maybe_unify_char):
1518 * keyboard.c (read_char, reorder_modifiers):
1519 XINT -> XFASTINT, since the integer must be nonnegative.
1520 * ftfont.c (ftfont_spec_pattern):
1521 * keymap.c (access_keymap, silly_event_symbol_error):
1522 XUINT -> XFASTINT, since the integer must be nonnegative.
1523 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1524 since it makes no difference and we prefer signed.
1525 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1526 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1529 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1531 * window.h (Fwindow_frame): Declare.
1533 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1535 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1536 (SPARE_MEMORY): Always define.
1537 (LARGE_REQUEST): Remove.
1538 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1540 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1542 * lisp.h: Move EXFUNS for Fframe_root_window,
1543 Fframe_first_window and Fset_frame_selected_window to window.h.
1545 * window.h: Move EXFUNS for Fframe_root_window,
1546 Fframe_first_window and Fset_frame_selected_window here from
1549 * frame.c (Fwindow_frame, Fframe_first_window)
1550 (Fframe_root_window, Fframe_selected_window)
1551 (Fset_frame_selected_window): Move to window.c.
1552 (Factive_minibuffer_window): Move to minibuf.c.
1553 (Fother_visible_frames_p): New function.
1555 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1557 * window.c (decode_window, decode_any_window): Move up in code.
1558 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1559 (inhibit_frame_unsplittable): Remove unused variable.
1560 (Fwindow_buffer): Move up and rewrite doc-string.
1561 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1562 (Fwindow_prev): New functions.
1563 (Fwindow_frame): Move here from frame.c. Accept any window as
1565 (Fframe_root_window, Fframe_first_window)
1566 (Fframe_selected_window): Move here from frame.c. Accept frame
1567 or arbitrary window as argument. Update doc-strings.
1568 (Fminibuffer_window): Move up in code.
1569 (Fwindow_minibuffer_p): Move up in code and simplify.
1570 (Fset_frame_selected_window): Move here from frame.c.
1572 (Fselected_window, select_window, Fselect_window): Move up in
1573 code. Minor doc-string fixes.
1575 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1577 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1578 Do not assume that spare memory exists; that assumption is valid
1579 only if SYSTEM_MALLOC.
1580 (LARGE_REQUEST): New macro, so that the issue of large requests
1581 is separated from the issue of spare memory.
1583 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1585 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1588 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1590 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1593 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1595 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1597 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1599 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1600 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1602 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1604 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1606 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1608 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1609 (x_clipboard_manager_save): Add return value.
1610 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1612 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1613 Obey Vx_select_enable_clipboard_manager. Catch errors in
1614 x_clipboard_manager_save (Bug#8779).
1615 (Vx_select_enable_clipboard_manager): New variable.
1616 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1618 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1620 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1622 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1624 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1625 in the current matrix if keep_current_p is non-zero.
1627 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1629 * bidi.c (bidi_level_of_next_char): Fix last change.
1631 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1633 Support bidi reordering of text covered by display properties.
1635 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1636 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1637 (bidi_cache_search, bidi_cache_iterator_state)
1638 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1639 (bidi_level_of_next_char, bidi_move_to_visually_next):
1640 Support character positions inside a run of characters covered by a
1642 (bidi_paragraph_init, bidi_resolve_explicit_1)
1643 (bidi_level_of_next_char): Call bidi_fetch_char and
1644 bidi_fetch_char_advance instead of FETCH_CHAR and
1646 (bidi_init_it): Initialize new members.
1647 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1649 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1650 instead of using explicit *_CHAR codes.
1651 (bidi_resolve_explicit, bidi_resolve_weak):
1652 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1653 bidirectional text is supported only in multibyte buffers.
1654 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1655 it to initialize the frame_window_p member of struct bidi_it.
1656 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1657 (bidi_resolve_explicit, bidi_resolve_weak)
1658 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1659 bidi_it->nchars is non-positive.
1660 (bidi_level_of_next_char): Don't try to lookup the cache for the
1661 next/previous character if nothing is cached there yet, or if we
1662 were just reseat()'ed to a new position.
1664 * xdisp.c (set_cursor_from_row): Set start and stop points
1665 according to the row's direction when priming the loop that looks
1666 for the glyph on which to display cursor.
1667 (single_display_spec_intangible_p): Function deleted.
1668 (display_prop_intangible_p): Reimplement to call
1669 handle_display_spec instead of single_display_spec_intangible_p.
1670 Accept 3 additional arguments needed by handle_display_spec.
1671 This fixes incorrect cursor motion across display property with complex
1672 values: lists, `(when COND...)' forms, etc.
1673 (single_display_spec_string_p): Support property values that are
1674 lists with the argument STRING its top-level element.
1675 (display_prop_string_p): Fix the condition for processing a
1676 property that is a list to be consistent with handle_display_spec.
1677 (handle_display_spec): New function, refactored from the
1678 last portion of handle_display_prop.
1679 (compute_display_string_pos): Accept additional argument
1680 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1681 value of a `display' property is a "replacing spec".
1682 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1683 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1684 the display property, but just return a value indicating whether
1685 the display property will replace the characters it covers.
1686 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1687 frame_window_p members of struct bidi_it.
1688 (compute_display_string_pos, compute_display_string_end):
1690 (push_it): Accept second argument POSITION, where pop_it should
1691 jump to continue iteration.
1692 (reseat_1): Initialize bidi_it.disp_pos.
1694 * keyboard.c (adjust_point_for_property): Adjust the call to
1695 display_prop_intangible_p to its new signature.
1697 * dispextern.h (struct bidi_it): New member frame_window_p.
1698 (bidi_init_it): Update prototypes.
1699 (display_prop_intangible_p): Update prototype.
1700 (compute_display_string_pos, compute_display_string_end):
1702 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1705 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1707 Malloc failure behavior now depends on size of allocation.
1708 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1709 * lisp.h: Change signatures accordingly.
1710 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1711 All callers changed. (Bug#8762)
1713 * gnutls.c: Use Emacs's memory allocators.
1714 Without this change, the gnutls library would invoke malloc etc.
1715 directly, which causes problems on non-SYNC_INPUT hosts, and which
1716 runs afoul of improving memory_full behavior. (Bug#8761)
1717 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1718 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1719 xfree instead of the default malloc, realloc, free.
1720 (Fgnutls_boot): No need to check for memory allocation failure,
1721 since xmalloc does that for us.
1723 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1724 * category.c (hash_get_category_set):
1725 * ccl.c (ccl_driver):
1726 * charset.c (Fdefine_charset_internal):
1727 * charset.h (struct charset.hash_index):
1728 * composite.c (get_composition_id, gstring_lookup_cache)
1729 (composition_gstring_put_cache):
1730 * composite.h (struct composition.hash_index):
1731 * dispextern.h (struct image.hash):
1732 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1733 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1734 (hashfn_equal, hashfn_user_defined, make_hash_table)
1735 (maybe_resize_hash_table, hash_lookup, hash_put)
1736 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1737 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1738 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1739 * image.c (make_image, search_image_cache, lookup_image)
1740 (xpm_put_color_table_h):
1741 * lisp.h (struct Lisp_Hash_Table):
1742 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1743 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1744 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1745 * alloc.c (allocate_vectorlike):
1746 Check for overflow in vector size calculations.
1747 * ccl.c (ccl_driver):
1748 Check for overflow when converting EMACS_INT to int.
1749 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1750 need to be updated by these changes.
1751 * fns.c (make_hash_table, maybe_resize_hash_table):
1752 Check for integer overflow with large hash tables.
1753 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1754 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1755 (SXHASH_REDUCE): New macro.
1756 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1757 Use it instead of discarding useful hash info with large hash values.
1758 (sxhash_float): New function.
1759 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1760 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1761 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1762 Rewrite to use FIXNUM_BITS, as this simplifies things.
1763 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1764 Adjust signatures to match updated version of code.
1765 (consing_since_gc): Now EMACS_INT, since a single hash table can
1766 use more than INT_MAX bytes.
1768 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1770 Make it possible to build with GCC-4.6+ -O2 -flto.
1772 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1774 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1776 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1777 Call minibuffer-inactive-mode.
1779 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1781 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1782 Update dependencies.
1784 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1786 * data.c (init_data): Remove code for UTS, this system is not
1789 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1791 Don't force ./temacs to start in terminal mode.
1793 * frame.c (make_initial_frame): Initialize faces in all cases, not
1794 only when CANNOT_DUMP is defined.
1795 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1797 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1799 * dispnew.c (add_window_display_history): Use const for the string
1800 pointer. Remove declaration, not needed.
1802 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1804 Use 'inline', not 'INLINE'.
1805 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1806 * alloc.c, fontset.c (INLINE): Remove.
1807 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1808 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1809 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1810 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1811 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1813 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1815 Make it possible to run ./temacs.
1817 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1818 syms_of_callproc does the same thing. Remove test for
1819 "initialized", do it in the caller.
1820 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1822 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1824 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1825 (read_minibuf): Use get_minibuffer.
1826 (syms_of_minibuf): Use DEFSYM.
1827 (Qmetadata): New var.
1828 * data.c (Qbuffer): Don't make it static.
1829 (syms_of_data): Use DEFSYM.
1831 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1833 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1834 (CCL_CODE_MIN): New macro.
1836 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1838 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1840 * eval.c (Qdebug): Now static.
1841 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1842 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1843 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1845 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1847 * image.c: Various fixes to ImageMagick code comments.
1848 (Fimagemagick_types): Doc fix.
1850 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1852 Minor fixes prompted by GCC 4.6.0 warnings.
1854 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1856 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1857 (x_clipboard_manager_save_all): Move extern decl to ...
1858 * xterm.h: ... here, so that it can be checked for consistency.
1860 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1862 * xselect.c (x_clipboard_manager_save_frame)
1863 (x_clipboard_manager_save_all): New functions.
1864 (Fx_clipboard_manager_save): Lisp function deleted.
1866 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1867 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1869 * xterm.h: Update prototype.
1871 2011-05-28 William Xu <william.xwl@gmail.com>
1873 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1876 2011-05-28 Jim Meyering <meyering@redhat.com>
1878 Avoid a sign-extension bug in crypto_hash_function.
1879 * fns.c (to_uchar): Define.
1880 (crypto_hash_function): Use it to convert some newly-signed
1881 variables to unsigned, to avoid sign-extension bugs. For example,
1882 without this change, (md5 "truc") would evaluate to
1883 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1884 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1885 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1887 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1889 Integer overflow fixes.
1891 * dbusbind.c: Serial number integer overflow fixes.
1892 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1893 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1894 to hold a serial number that is too large for a fixnum.
1895 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1896 Check for serial numbers out of range. Decode any serial number
1897 that was so large that it became a float. (Bug#8722)
1899 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1900 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1901 Use XFASTINT rather than XUINT when numbers are nonnegative.
1902 (xd_append_arg, Fdbus_method_return_internal):
1903 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1904 arguments, check that Lisp number is nonnegative, rather than
1905 silently wrapping negative numbers around. (Bug#8722)
1906 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1909 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1911 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1913 ccl: add integer overflow checks
1914 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1915 (IN_INT_RANGE): New macros.
1916 (ccl_driver): Use them to check for integer overflow when
1917 decoding a CCL program. Many of the new checks are whether XINT (x)
1918 fits in int; it doesn't always, on 64-bit hosts. The new version
1919 doesn't catch all possible integer overflows, but it's an
1920 improvement. (Bug#8719)
1922 * alloc.c (make_event_array): Use XINT, not XUINT.
1923 There's no need for unsigned here.
1925 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1926 This follows up to the 2011-05-06 change that substituted uintptr_t
1927 for EMACS_INT. This case wasn't caught back then.
1929 Rework Fformat to avoid integer overflow issues.
1930 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1931 now (part of C89). Include <verify.h>.
1932 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1933 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1934 (Fformat): Avoid the prepass trying to compute sizes; it was only
1935 approximate and thus did not catch overflow reliably. Instead, walk
1936 through the format just once, formatting and computing sizes as we go,
1937 checking for integer overflow at every step, and allocating a larger
1938 buffer as needed. Keep track separately whether the format is
1939 multibyte. Keep only the most-recently calculated precision, rather
1940 than them all. Record whether each argument has been converted to
1941 string. Use EMACS_INT, not int, for byte and char and arg counts.
1942 Support field widths and precisions larger than INT_MAX. Avoid
1943 sprintf's undefined behavior with conversion specifications such as %#d
1944 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1945 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1946 formatting out-of-range floating point numbers with int
1949 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1951 * data.c: Avoid integer truncation in expressions involving floats.
1952 * data.c: Include <intprops.h>.
1953 (arith_driver): When there's an integer overflow in an expression
1954 involving floating point, convert the integers to floating point
1955 so that the resulting value does not suffer from catastrophic
1956 integer truncation. For example, on a 64-bit host (* 4
1957 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1958 Do not rely on undefined behavior after integer overflow.
1960 merge count_size_as_multibyte, parse_str_to_multibyte
1961 * character.c, character.h (count_size_as_multibyte):
1962 Rename from parse_str_to_multibyte; all uses changed.
1963 Check for integer overflow.
1964 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1965 since it's now a duplicate of the other. This is more of
1966 a character than a buffer op, so better that it's in character.c.
1967 * fns.c, print.c: Adjust to above changes.
1969 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1971 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1973 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1975 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1976 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1977 (x_clipboard_manager_save): Now static.
1978 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1980 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1981 (crypto_hash_function): Now static.
1982 Fix pointer signedness problems. Avoid unnecessary initializations.
1984 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1986 * termhooks.h (Vselection_alist): Make it terminal-local.
1988 * terminal.c (create_terminal): Initialize it.
1990 * xselect.c: Support for clipboard managers.
1991 (Vselection_alist): Move to termhooks.h as terminal-local var.
1992 (LOCAL_SELECTION): New macro.
1993 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1994 (symbol_to_x_atom): Remove gratuitous arg.
1995 (x_handle_selection_request, lisp_data_to_selection_data)
1996 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1997 (x_own_selection, x_get_local_selection, x_convert_selection):
1998 New arg, specifying work frame. Use terminal-local Vselection_alist.
1999 (some_frame_on_display): Delete unused function.
2000 (Fx_own_selection_internal, Fx_get_selection_internal)
2001 (Fx_disown_selection_internal, Fx_selection_owner_p)
2002 (Fx_selection_exists_p): New optional frame arg.
2003 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2004 (x_handle_selection_clear): Don't treat other terminals with the
2005 same keyboard specially. Use the terminal-local Vselection_alist.
2006 (x_clear_frame_selections): Use Frun_hook_with_args.
2008 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2010 * xterm.h: Add support for those atoms.
2012 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2014 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2015 (converted_selections, conversion_fail_tag): New global variables.
2016 (x_selection_request_lisp_error): Free the above.
2017 (x_get_local_selection): Remove unnecessary code.
2018 (x_reply_selection_request): Args changed; handle arbitrary array
2019 of converted selections stored in converted_selections.
2020 Separate the XChangeProperty and SelectionNotify steps.
2021 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2022 (x_convert_selection): New function.
2023 (x_handle_selection_event): Simplify.
2024 (x_get_foreign_selection): Don't ignore incoming requests while
2025 waiting for an answer; this will fail when we implement
2026 SAVE_TARGETS, and seems unnecessary anyway.
2027 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2028 (Vx_sent_selection_functions): Doc fix.
2030 2011-05-26 Leo Liu <sdl.web@gmail.com>
2032 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2034 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2036 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2038 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2039 for fringe update if it has periodic bitmap.
2040 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2041 and fringe_bitmap_periodic_p.
2043 * fringe.c (get_fringe_bitmap_data): New function.
2044 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2045 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2046 row. Mark glyph row for fringe update if periodicity changed.
2048 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2049 for fringe update unless it has periodic bitmap.
2051 2011-05-25 Kenichi Handa <handa@m17n.org>
2053 * xdisp.c (get_next_display_element): Set correct it->face_id for
2054 a static composition.
2056 2011-05-24 Leo Liu <sdl.web@gmail.com>
2059 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2061 * fns.c (crypto_hash_function, Fsha1): New function.
2062 (Fmd5): Use crypto_hash_function.
2063 (syms_of_fns): Add Ssha1.
2065 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2067 * gnutls.c: Remove unused macros.
2068 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2069 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2070 Remove macros that are defined and never used.
2071 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2073 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2075 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2076 (Fx_get_selection_internal): Minor cleanup.
2077 (Fx_own_selection_internal): Rename arguments for consistency with
2080 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2082 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2084 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2086 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2088 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2090 * dispnew.c (scrolling_window): Don't exclude the case that the
2091 last enabled row in the desired matrix touches the bottom boundary.
2093 2011-05-21 Glenn Morris <rgm@gnu.org>
2095 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2096 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2097 and add some more files.
2099 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2101 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2102 report_file_error introduced by the change from 2011-05-07.
2104 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2106 * systime.h (Time): Define only if emacs is defined.
2107 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2108 where the include path doesn't have X11/X.h by default. See
2109 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2111 2011-05-20 Kenichi Handa <handa@m17n.org>
2113 * composite.c (find_automatic_composition): Fix previous change.
2115 2011-05-20 Glenn Morris <rgm@gnu.org>
2117 * lisp.mk: New file, split from Makefile.in.
2118 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2119 (shortlisp): Remove.
2120 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2122 2011-05-19 Glenn Morris <rgm@gnu.org>
2124 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2125 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2126 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2127 (lisp): Set the order to that of loadup.el.
2128 (shortlisp): Make it a copy of $lisp.
2129 (SOME_MACHINE_LISP): Remove.
2130 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2131 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2133 2011-05-18 Kenichi Handa <handa@m17n.org>
2135 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2136 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2137 (find_automatic_composition): Mostly rewrite for efficiency.
2139 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2141 * makefile.w32-in: Update dependencies.
2143 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2145 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2146 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2148 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2150 Fix some integer overflow issues, such as string length overflow.
2152 * insdel.c (count_size_as_multibyte): Check for string overflow.
2154 * character.c (lisp_string_width): Check for string overflow.
2155 Use EMACS_INT, not int, for string indexes and lengths; in
2156 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2157 the resulting string length overflows an EMACS_INT; instead,
2158 report a string overflow if no precision given. When checking for
2159 precision exhaustion, use a check that cannot possibly have
2160 integer overflow. (Bug#8675)
2161 * character.h (lisp_string_width): Adjust to new signature.
2163 * alloc.c (string_overflow): New function.
2164 (Fmake_string): Use it. This doesn't change behavior, but saves
2165 a few bytes and will simplify future changes.
2166 * character.c (string_escape_byte8): Likewise.
2167 * lisp.h (string_overflow): New decl.
2169 Fixups, following up to the user-interface timestamp change.
2170 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2171 for UI timestamps, instead of unsigned long.
2172 * msdos.c (mouse_get_pos): Likewise.
2173 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2174 * w32gui.h (Time): Define by including "systime.h" rather than by
2175 declaring it ourselves. (Bug#8664)
2177 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2178 * image.c (clear_image_cache): Likewise.
2180 * term.c (term_mouse_position): Don't assume time_t wraparound.
2182 Be more systematic about user-interface timestamps.
2183 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2184 and sometimes 'EMACS_UINT', to represent these timestamps.
2185 This change causes it to use 'Time' uniformly, as that's what X uses.
2186 This makes the code easier to follow, and makes it easier to catch
2187 integer overflow bugs such as Bug#8664.
2188 * frame.c (Fmouse_position, Fmouse_pixel_position):
2189 Use Time, not unsigned long, for user-interface timestamps.
2190 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2191 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2192 * keyboard.h (last_event_timestamp): Likewise.
2193 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2194 * menu.h (xmenu_show): Likewise.
2195 * term.c (term_mouse_position): Likewise.
2196 * termhooks.h (struct input_event.timestamp): Likewise.
2197 (struct terminal.mouse_position_hook): Likewise.
2198 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2199 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2200 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2201 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2203 * menu.h, termhooks.h: Include "systime.h", for Time.
2205 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2206 Don't assume that the difference between two unsigned long values
2207 can fit into an integer. At this point, we know button_down_time
2208 <= event->timestamp, so the difference must be nonnegative, so
2209 there's no need to cast the result if double-click-time is
2210 nonnegative, as it should be; check that it's nonnegative, just in
2211 case. This bug is triggered when events are more than 2**31 ms
2212 apart (about 25 days). (Bug#8664)
2214 * xselect.c (last_event_timestamp): Remove duplicate decl.
2215 (x_own_selection): Remove needless cast to unsigned long.
2217 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2218 that always fit in int. Use a sentinel instead of a counter, to
2219 avoid a temp and to allay GCC's concerns about possible int overflow.
2220 * frame.h (struct frame): Use int for menu_bar_items_used
2221 instead of EMACS_INT, since it always fits in int.
2223 * menu.c (grow_menu_items): Check for int overflow.
2225 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2227 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2228 Before, the code was not consistent. These values cannot exceed
2229 2**31 - 1 so there's no need to make them unsigned.
2230 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2231 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2232 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2234 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2236 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2237 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2238 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2239 presumably because the widths might not match.
2241 * window.c (size_window): Avoid needless test at loop start.
2243 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2245 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2247 2011-05-12 Drew Adams <drew.adams@oracle.com>
2249 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2251 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2253 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2254 `width' to `bar_area_x' and `bar_area_width', respectively.
2255 (x_scroll_run): Take account of fringe background extension.
2257 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2258 Rename local vars `left' and `width' to `bar_area_x' and
2259 `bar_area_width', respectively.
2260 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2261 background extension.
2263 2011-05-10 Jim Meyering <meyering@redhat.com>
2265 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2267 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2269 * image.c (Finit_image_library): Return t for built-in image types,
2270 like pbm and xbm. (Bug#8640)
2272 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2274 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2276 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2278 * w32console.c (Fset_screen_color): Doc fix.
2279 (Fget_screen_color): New function.
2280 (syms_of_ntterm): Defsubr it.
2282 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2283 unlink the temporary file if Fcall_process didn't create it in the
2285 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2286 child process will be redirected to a file specified with `:file'.
2287 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2288 cue to call_process_cleanup not to close that handle.
2290 2011-05-07 Ben Key <bkey76@gmail.com>
2292 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2293 one of two shell specific rules, either bootstrap-temacs-CMD or
2294 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2295 to the previous implementation of the bootstrap-temacs rule.
2296 The bootstrap-temacs-CMD rule is similar to the previous
2297 implementation of the bootstrap-temacs rule except that it
2298 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2301 These changes, along with some changes to nt/configure.bat,
2302 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2303 earlier fix to add support for --cflags and --ldflags options
2304 that include quotes so that it works whether make uses cmd or
2307 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2309 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2310 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2312 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2313 a string. Handle both cases.
2314 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2315 (Fdbus_register_method): Use Qinvalid_function.
2317 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2319 * makefile.w32-in: Update dependencies.
2320 (LISP_H): Add inttypes.h and stdin.h.
2321 (PROCESS_H): Add unistd.h.
2323 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2325 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2326 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2328 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2330 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2332 * term.c (vfatal): Remove stray call to va_end.
2333 It's not needed and the C Standard doesn't allow it here anyway.
2335 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2336 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2338 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2341 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2343 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2345 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2347 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2349 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2351 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2352 * charset.c (Fdefine_charset_internal): Don't initialize
2353 charset.code_space[15]. The value was garbage, on hosts with
2354 32-bit int (Bug#8600).
2356 * lread.c (read_integer): Be more consistent with string-to-number.
2357 Use string_to_number to do the actual conversion; this avoids
2358 rounding errors and fixes some other screwups. Without this fix,
2359 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2360 (digit_to_number): Move earlier, for benefit of read_integer.
2361 Return -1 if the digit is out of range for the base, -2 if it is
2362 not a digit in any supported base. (Bug#8602)
2364 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2366 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2367 to match comment at start of function. This also removes a
2368 GCC warning about overflow in a 32+64-bit port.
2370 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2372 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2373 Reported by Stefan Monnier in
2374 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2375 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2376 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2378 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2379 (EMACS_UINTPTR): Likewise, with uintptr_t.
2381 * lisp.h: Prefer 64-bit EMACS_INT if available.
2382 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2383 on 32-bit hosts that have 64-bit int, so that they can access
2385 However, temporarily disable this change unless the temporary
2386 symbol WIDE_EMACS_INT is defined.
2388 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2390 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2391 This removes an assumption that EMACS_INT and long are the same
2392 width as pointers. The assumption is true for Emacs porting targets
2393 now, but we want to make other targets possible.
2394 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2395 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2396 In the rest of the code, change types of integers that hold casted
2397 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2398 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2399 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2400 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2401 No need to cast type when ORing.
2402 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2403 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2404 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2405 assume EMACS_INT is the same width as char *.
2406 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2407 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2408 Remove no-longer-needed casts.
2409 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2410 (xg_tool_bar_help_callback, xg_make_tool_item):
2411 Use EMACS_INTPTR to hold an integer
2412 that will be cast to void *; this can avoid a GCC warning
2413 if EMACS_INT is not the same width as void *.
2414 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2415 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2416 (current_message_1, set_message_1):
2417 Use a local to convert to proper width without a cast.
2418 * xmenu.c (dialog_selection_callback): Likewise.
2420 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2421 Also, don't assume VALBITS / RAND_BITS is less than 5,
2422 and don't rely on undefined behavior when shifting a 1 left into
2424 * lisp.h (get_random): Change signature to match.
2426 * lread.c (hash_string): Use size_t, not int, for hash computation.
2427 Normally we prefer signed values; but hashing is special, because
2428 it's better to use unsigned division on hash table sizes so that
2429 the remainder is nonnegative. Also, size_t is the natural width
2430 for hashing into memory. The previous code used 'int', which doesn't
2431 retain enough info to hash well into very large tables.
2432 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2434 * dbusbind.c: Don't possibly lose pointer info when converting.
2435 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2436 Use XPNTR rather than XHASH, so that the high-order bits of
2437 the pointer aren't lost when converting through void *.
2439 * eval.c (Fautoload): Don't double-shift a pointer.
2441 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2443 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2445 * gnutls.c (DEF_GNUTLS_FN):
2446 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2448 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2450 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2453 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2455 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2456 New version that can reserve upto 2GB of heap space.
2458 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2460 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2462 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2464 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2465 `gnutls_certificate_set_x509_key_file'.
2467 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2469 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2470 Update dependencies.
2472 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2474 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2475 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2476 Remove unused parameter `fildes'.
2477 * process.c (read_process_output, send_process): Don't pass it.
2479 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2481 Fix previous change: the library cache is defined in w32.c.
2482 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2483 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2485 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2487 Implement dynamic loading of GnuTLS on Windows.
2489 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2490 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2491 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2494 * gnutls.c (Qgnutls_dll): Define.
2495 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2496 (gnutls_*): Declare function pointers.
2497 (init_gnutls_functions): New function to initialize function pointers.
2498 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2499 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2500 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2501 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2502 (emacs_gnutls_write, emacs_gnutls_read)
2503 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2504 (Fgnutls_available_p): New function.
2505 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2506 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2507 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2509 * image.c: Include w32.h.
2510 (Vimage_type_cache): Delete.
2511 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2512 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2513 (w32_delayed_load): Move to w32.c.
2515 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2517 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2518 (w32_delayed_load): Move from image.c. When loading a library, record
2519 its filename in the :loaded-from property of the library id.
2520 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2521 Initialize and staticpro them.
2522 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2524 * process.c: Include lisp.h before w32.h, not after.
2525 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2526 instead of gnutls_record_check_pending.
2528 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2530 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2532 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2533 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2536 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2538 * xterm.c (x_set_frame_alpha): Do not set property on anything
2539 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2541 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2543 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2545 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2547 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2548 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2549 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2550 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2551 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2552 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2553 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2554 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2555 (Qgnutls_bootprop_callbacks_verify): Make static.
2557 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2559 * callproc.c: Indentation fixup.
2561 * sysdep.c (wait_for_termination_1): Make static.
2562 (wait_for_termination, interruptible_wait_for_termination):
2563 Move after wait_for_termination_1.
2565 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2567 * sysdep.c (interruptible_wait_for_termination): New function
2568 which is like wait_for_termination, but allows keyboard
2571 * callproc.c (Fcall_process): Add (:file "file") as an option for
2573 (Fcall_process_region): Ditto.
2575 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2577 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2578 rather than `XVECTOR (FOO)->size'.
2580 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2581 inttypes.h, as a gnulib replacement is used if it not available in
2584 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2586 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2587 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2588 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2590 * coding.c (coding_alloc_by_realloc): Error out if destination
2591 will grow beyond MOST_POSITIVE_FIXNUM.
2592 (decode_coding_emacs_mule): Abort if there isn't enough place in
2593 charbuf for the composition carryover bytes. Reserve an extra
2594 space for up to 2 characters produced in a loop.
2595 (decode_coding_iso_2022): Abort if there isn't enough place in
2596 charbuf for the composition carryover bytes.
2598 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2600 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2601 aborting when %lld or %lll format is passed.
2602 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2603 %llo or %llx format is passed. (Bug#8545)
2605 * window.c (window_scroll_line_based): Use a marker instead of
2606 simple variables to record original value of point. (Bug#7952)
2608 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2609 produced by %s or %c overflows available buffer space. (Bug#8545)
2611 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2613 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2614 (SIZE_MAX): Move defn after all includes, as they might #define it.
2616 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2618 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2620 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2622 * keyboard.c (Qdelayed_warnings_hook): Define.
2623 (command_loop_1): Run `delayed-warnings-hook'
2624 if Vdelayed_warnings_list is non-nil.
2625 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2626 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2628 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2630 * doprnt.c (doprnt): Don't return value smaller than the buffer
2631 size if the message was truncated. (Bug#8545).
2633 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2635 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2636 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2638 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2640 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2642 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2644 * makefile.w32-in: Update dependencies.
2646 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2648 Improve `doprnt' and its usage. (Bug#8545)
2649 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2650 `format_end'. Remove support for %l as a conversion specifier.
2651 Don't use xrealloc. Improve diagnostics when the %l size modifier
2652 is used. Update the commentary.
2654 * eval.c (verror): Simplify calculation of size_t.
2656 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2659 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2661 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2664 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2666 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2667 This makes this file independent of the recent pseudovector change.
2669 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2671 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2673 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2674 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2675 Remove unused local.
2676 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2678 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2679 GCC 4.6.0 optimizes based on type-based alias analysis.
2680 For example, if b is of type struct buffer * and v of type struct
2681 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2682 != &v->size, and therefore "v->size = 1; b->size = 2; return
2683 v->size;" must therefore return 1. This assumption is incorrect
2684 for Emacs, since it type-puns struct Lisp_Vector * with many other
2685 types. To fix this problem, this patch adds a new type struct
2686 vectorlike_header that documents the constraints on layout of vectors
2687 and pseudovectors, and helps optimizing compilers not get fooled
2688 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2689 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2690 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2692 (XSETPVECTYPE): Rewrite in terms of new macro.
2693 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2694 This is a bit clearer, and further avoids the possibility of
2695 undesirable aliasing.
2696 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2697 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2698 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2699 since Lisp_Subr is a special case (no "next" field).
2700 (ASIZE): Now uses header.size rather than size.
2701 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2702 to avoid the hassle of writing XVECTOR (foo)->header.size.
2703 (struct vectorlike_header): New type.
2704 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2705 object, to help avoid aliasing.
2706 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2707 (SUBRP): Likewise, since Lisp_Subr is a special case.
2708 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2709 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2710 (struct Lisp_Hash_Table): Combine first two members into a single
2711 struct vectorlike_header member. All uses of "size" and "next" members
2712 changed to be "header.size" and "header.next".
2713 * buffer.h (struct buffer): Likewise.
2714 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2715 * frame.h (struct frame): Likewise.
2716 * process.h (struct Lisp_Process): Likewise.
2717 * termhooks.h (struct terminal): Likewise.
2718 * window.c (struct save_window_data, struct saved_window): Likewise.
2719 * window.h (struct window): Likewise.
2720 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2721 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2722 * buffer.c (init_buffer_once): Likewise.
2723 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2725 * process.c (Fformat_network_address): Use local var for size,
2728 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2730 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2731 * data.c (atof): Remove decl; no longer used or needed.
2732 (digit_to_number): Move to lread.c.
2733 (Fstring_to_number): Use new string_to_number function, to be
2734 consistent with how the Lisp reader treats infinities and NaNs.
2735 Do not assume that floating-point numbers represent EMACS_INT
2736 without losing information; this is not true on most 64-bit hosts.
2737 Avoid double-rounding errors, by insisting on integers when
2738 parsing non-base-10 numbers, as the documentation specifies.
2739 * lisp.h (string_to_number): New decl, replacing ...
2740 (isfloat_string): Remove.
2741 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2742 (read1): Do not accept +. and -. as integers; this
2743 appears to have been a coding error. Similarly, do not accept
2744 strings like +-1e0 as floating point numbers. Do not report
2745 overflow for integer overflows unless the base is not 10 which
2746 means we have no simple and reliable way to continue.
2747 Break out the floating-point parsing into a new
2748 function string_to_number, so that Fstring_to_number parses
2749 floating point numbers consistently with the Lisp reader.
2750 (digit_to_number): Move here from data.c. Make it static inline.
2751 (E_CHAR, EXP_INT): Remove, replacing with ...
2752 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2753 (string_to_number): New function, replacing isfloat_string.
2754 This function checks for valid syntax and produces the resulting
2755 Lisp float number too. Rework it so that string-to-number
2756 no longer mishandles examples like "1.0e+". Use strtoumax,
2757 so that overflow for non-base-10 numbers is reported only when
2758 there's no portable and simple way to convert to floating point.
2760 * textprop.c (set_text_properties_1): Rewrite for clarity,
2761 and to avoid GCC warning about integer overflow.
2763 * intervals.h (struct interval): Use EMACS_INT for members
2764 where EMACS_UINT might cause problems. See
2765 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2766 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2767 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2769 (offset_intervals): Tell GCC not to worry about length overflow
2770 when negating a negative length.
2772 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2773 (overrun_check_free): Likewise.
2775 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2776 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2779 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2780 (gnutls_make_error): Rename local to avoid shadowing.
2781 (gnutls_emacs_global_deinit): ifdef out; not used.
2782 (Fgnutls_boot): Use const for pointer to readonly storage.
2783 Comment out unused local. Fix pointer signedness problems.
2785 * lread.c (openp): Don't stuff size_t into an 'int'.
2786 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2787 about possible signed overflow.
2789 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2790 (GDK_KEY_g): Don't define if already defined.
2791 (xg_prepare_tooltip): Avoid pointer signedness problem.
2792 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2794 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2795 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2797 * xfns.c (Fx_window_property): Simplify a bit,
2798 to make a bit faster and to avoid GCC 4.6.0 warning.
2799 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2801 * fns.c (internal_equal): Don't assume size_t fits in int.
2803 * alloc.c (compact_small_strings): Tighten assertion a little.
2805 Replace pEd with more-general pI, and fix some printf arg casts.
2806 * lisp.h (pI): New macro, generalizing old pEd macro to other
2807 conversion specifiers. For example, use "...%"pI"d..." rather
2808 than "...%"pEd"...".
2809 (pEd): Remove. All uses replaced with similar uses of pI.
2810 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2811 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2812 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2813 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2814 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2815 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2816 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2818 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2819 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2820 * print.c (safe_debug_print, print_object): Likewise.
2821 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2823 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2824 avoiding the 0 flag, which is not portable.
2825 * process.c (Fmake_network_process): Use pI to avoid cast.
2826 * region-cache.c (pp_cache): Likewise.
2827 * xdisp.c (decode_mode_spec): Likewise.
2828 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2829 behavior on 64-bit hosts with printf arg.
2830 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2831 (x_stop_queuing_selection_requests): Likewise.
2832 (x_get_window_property): Don't truncate byte count to an 'int'
2835 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2836 here, since it parses constructs like leading '-' and spaces,
2837 which are not wanted; and it overflows with large numbers.
2838 Instead, simply match F[0-9]+, which is what is wanted anyway.
2840 * alloc.c: Remove unportable assumptions about struct layout.
2841 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2842 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2843 (allocate_vectorlike, make_pure_vector): Use the new macros,
2844 plus offsetof, to remove unportable assumptions about struct layout.
2845 These assumptions hold on all porting targets that I know of, but
2846 they are not guaranteed, they're easy to remove, and removing them
2847 makes further changes easier.
2849 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2850 This doesn't fix a bug but makes the code clearer.
2851 (string_overrun_cookie): Now const. Use initializers that
2852 don't formally overflow signed char, to avoid warnings.
2853 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2854 can cause Emacs to crash when string overrun checking is enabled.
2855 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2856 multiple of sizeof (EMACS_INT); it need not be, if
2857 alignof(EMACS_INT) < sizeof (EMACS_INT).
2858 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2860 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2862 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2864 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2866 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2867 supposed to be handshaking. (Bug#8556)
2868 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2870 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2872 * lisp.h (Qdebug): List symbol.
2873 * eval.c (Qdebug): Restore global linkage.
2874 * keyboard.c (debug-on-event): New variable.
2875 (handle_user_signal): Break into debugger when debug-on-event
2876 matches the current signal symbol.
2878 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2880 * alloc.c (check_sblock, check_string_bytes)
2881 (check_string_free_list): Convert to standard C.
2883 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2885 * w32.c (emacs_gnutls_push): Fix typo.
2887 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2889 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2890 "cast to pointer from integer of different size".
2892 Improve doprnt and its use in verror. (Bug#8545)
2893 * doprnt.c (doprnt): Document the set of format control sequences
2894 supported by the function. Use SAFE_ALLOCA instead of always
2897 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2898 is one byte too soon. Don't use xrealloc; instead xfree and
2901 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2903 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2906 * gnutls.c: Renamed global_initialized to
2907 gnutls_global_initialized. Added internals for the
2908 :verify-hostname-error, :verify-error, and :verify-flags
2909 parameters of `gnutls-boot' and documented those parameters in the
2910 docstring. Start callback support.
2911 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2912 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2913 on error. Return error code.
2914 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2915 (emacs_gnutls_read): Likewise.
2916 (Fgnutls_boot): Return handshake error code.
2917 (emacs_gnutls_handle_error): New function.
2918 (wsaerror_to_errno): Likewise.
2920 * w32.h (emacs_gnutls_pull): Add prototype.
2921 (emacs_gnutls_push): Likewise.
2923 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2924 (emacs_gnutls_push): Likewise.
2926 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2928 * process.c (wait_reading_process_output): Check if GnuTLS
2929 buffered some data internally if no FDs are set for TLS
2932 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2933 (LIBS): Link to USER_LIBS.
2934 ($(BLD)/gnutls.$(0)): New target.
2936 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2938 * xdisp.c (handle_single_display_spec): Rename the
2939 display_replaced_before_p argument into display_replaced_p, to
2940 make it consistent with the commentary. Fix typos in the
2943 * textprop.c (syms_of_textprop): Remove dead code.
2944 (copy_text_properties): Delete obsolete commentary about an
2945 interface that was deleted long ago. Fix typos in the description
2948 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2949 to changes in oldXMenu/XMenu.h from 2011-04-16.
2950 <menu_help_message, prev_menu_help_message>: Constify.
2951 (IT_menu_make_room): menu->help_text is now `const char **';
2954 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2955 to changes in oldXMenu/XMenu.h from 2011-04-16.
2956 (struct XMenu): Declare `help_text' `const char **'.
2958 * xfaces.c <Qunspecified>: Make extern again.
2960 * syntax.c: Include sys/types.h before including regex.h, as
2963 * doc.c (get_doc_string): Improve the format passed to `error'.
2965 * doprnt.c (doprnt): Improve commentary.
2967 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2969 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2972 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2973 changes in globals.h immediately force recompilation.
2974 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2975 $(CURDIR)/s/ms-w32.h.
2976 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2978 * character.c (Fchar_direction): Function deleted.
2979 (syms_of_character): Don't defsubr it.
2980 <char-direction-table>: Deleted.
2982 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2984 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2985 * doprnt.c: Include limits.h.
2986 (SIZE_MAX): New macro.
2987 (doprnt): Return a size_t value. 2nd arg is now size_t.
2988 Many local variables are now size_t instead of int or unsigned.
2989 Improve overflow protection. Support `l' modifier for integer
2990 conversions. Support %l conversion. Don't assume an EMACS_INT
2991 argument for integer conversions and for %c.
2993 * lisp.h (doprnt): Restore prototype.
2995 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2998 * Makefile.in (base_obj): Add back doprnt.o.
3000 * deps.mk (doprnt.o): Add back prerequisites.
3001 (callint.o): Depend on character.h.
3003 * eval.c (internal_lisp_condition_case): Include the handler
3004 representation in the error message.
3005 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3006 when breaking from the loop.
3008 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3010 * callint.c (Fcall_interactively): When displaying error message
3011 about invalid control letter, pass the character's codepoint, not
3012 a pointer to its multibyte form. Improve display of the character
3013 in octal and display also its hex code.
3015 * character.c (char_string): Use %x to display the (unsigned)
3016 codepoint of an invalid character, to avoid displaying a bogus
3019 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3020 `error', not SYMBOL_NAME itself.
3022 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3023 character arguments to `error'.
3025 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3026 to `error' in error message about FINAL_CHAR argument. Make sure
3027 FINAL_CHAR is a character, and use %c when it is passed as
3028 argument to `error'.
3030 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3032 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3034 * w32.c: Include <time.h>.
3035 (sys_localtime): New function.
3037 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3039 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3041 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3043 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3045 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3048 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3050 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3051 gl_state.e_property when gl_state.object is Qt.
3053 * insdel.c (make_gap_larger): Remove limitation of buffer size
3056 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3058 * xdisp.c (lookup_glyphless_char_display)
3059 (produce_glyphless_glyph): Handle cons cell entry in
3060 glyphless-char-display.
3061 (Vglyphless_char_display): Document it.
3063 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3064 glyphless-char-display.
3066 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3068 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3070 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3072 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3073 definition for no-X builds.
3075 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3077 Static checks with GCC 4.6.0 and non-default toolkits.
3079 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3081 * process.c (keyboard_bit_set): Define only if SIGIO.
3082 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3083 (send_process): Repair possible setjmp clobbering.
3085 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3087 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3089 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3091 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3092 Define only if needed.
3094 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3095 by pacifying GCC about it. Maybe it's time to retire it?
3096 * xfaces.c (USG, __TIMEVAL__): Likewise.
3098 * dispextern.h (struct redisplay_interface): Rename param
3100 * termhooks.h (struct terminal): Likewise.
3101 * xterm.c (xembed_send_message): Likewise.
3103 * insdel.c (make_gap_smaller): Define only if
3104 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3106 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3109 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3110 so that we aren't warned about unused symbols.
3112 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3114 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3116 * xfns.c (x_real_positions): Mark locals as initialized.
3118 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3120 * xterm.c: Fix problems found by static analysis with other toolkits.
3121 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3122 (x_dispatch_event): Declare static if USE_GTK, and
3123 define if USE_GTK || USE_X_TOOLKIT.
3124 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3125 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3126 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3127 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3129 * xmenu.c (menu_help_callback): Pointer type fixes.
3130 Use const pointers when pointing at readonly data. Avoid pointer
3132 (FALSE): Remove unused macro.
3133 (update_frame_menubar): Remove unused decl.
3135 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3137 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3138 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3139 (single_menu_item): Rename local to avoid shadowing.
3141 * keyboard.c (make_lispy_event): Remove unused local var.
3143 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3144 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3146 * bitmaps: Change bitmaps from unsigned char back to the X11
3147 compatible char. Avoid the old compiler warnings about
3148 out-of-range initializers by using, for example, '\xab' rather
3151 * xgselect.c (xgselect_initialize): Check vs interface
3152 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3154 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3156 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3157 to read-only memory.
3159 * fns.c (vector): Remove; this old hack is no longer needed.
3161 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3163 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3165 * xrdb.c (x_load_resources): Omit unused local.
3167 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3168 (x_window): Rename locals to avoid shadowing.
3169 (USG): Use the kludged USG macro, to pacify gcc.
3171 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3172 (x_term_init): Remove local to avoid shadowing.
3174 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3176 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3177 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3179 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3181 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3183 Fix regex.c, syntax.c and friends for buffers > 2GB.
3184 * syntax.h (struct gl_state_s): Declare character position members
3187 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3189 * textprop.c (verify_interval_modification, interval_of):
3190 Declare arguments EMACS_INT.
3192 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3195 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3197 * indent.c (Fvertical_motion): Local variable it_start is now
3200 * regex.c (re_match, re_match_2, re_match_2_internal)
3201 (bcmp_translate, regcomp, regexec, print_double_string)
3202 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3203 (re_compile_pattern, re_exec): Declare arguments and local
3204 variables `size_t' and `ssize_t' and return values `regoff_t', as
3206 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3207 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3208 <compile_stack_type>: `size' and `avail' are now `size_t'.
3210 * regex.h <regoff_t>: Use ssize_t, not int.
3211 (re_search, re_search_2, re_match, re_match_2): Arguments that
3212 specify buffer/string position and length are now ssize_t and
3213 size_t. Return type is regoff_t.
3215 2011-04-16 Ben Key <bkey76@gmail.com>
3217 * nsfont.m: Fixed bugs in ns_get_family and
3218 ns_descriptor_to_entity that were caused by using free to
3219 deallocate memory blocks that were allocated by xmalloc (via
3220 xstrdup). This caused Emacs to crash when compiled with
3221 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3222 --enable-checking=xmallocoverrun). xfree is now used to
3223 deallocate these memory blocks.
3225 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3227 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3229 emacs_write: Accept and return EMACS_INT for sizes.
3230 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3232 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3233 Accept and return EMACS_INT.
3234 (emacs_gnutls_write): Return the number of bytes written on
3236 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3237 (emacs_read, emacs_write): Remove check for negative size, as the
3238 Emacs source code has been audited now.
3239 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3240 (emacs_read, emacs_write): Use it.
3241 * process.c (send_process): Adjust to the new signatures of
3242 emacs_write and emacs_gnutls_write. Do not attempt to store
3243 a byte offset into an 'int'; it might overflow.
3244 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3246 * sound.c: Don't assume sizes fit in 'int'.
3247 (struct sound_device.period_size, alsa_period_size):
3248 Return EMACS_INT, not int.
3249 (struct sound_device.write, vox_write, alsa_write):
3250 Accept EMACS_INT, not int.
3251 (wav_play, au_play): Use EMACS_INT to store sizes and to
3252 record read return values.
3254 2011-04-15 Ben Key <bkey76@gmail.com>
3256 * keyboard.c (Qundefined): Don't declare static since it is used
3258 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3259 static since they are used in nsfont.m.
3261 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3263 * process.c (Qprocessp): Don't declare static.
3264 * lisp.h (Qprocessp): Declare again.
3266 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3268 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3270 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3272 Improve C-level modularity by making more things 'static'.
3274 Don't publish debugger-only interfaces to other modules.
3275 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3276 (verify_bytepos, count_markers): Move decls to the only modules
3278 * region-cache.h (pp_cache): Likewise.
3279 * window.h (check_all_windows): Likewise.
3280 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3282 * sysdep.c (croak): Now static, if
3283 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3284 * syssignal.h (croak): Declare only if not static.
3286 * alloc.c (refill_memory_reserve): Now static if
3287 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3288 * lisp.h (refill_memory_reserve): Declare only if not static.
3290 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3291 Define only if USE_LUCID.
3293 * xrdb.c (x_customization_string, x_rm_string): Now static.
3295 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3296 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3298 * xdisp.c (draw_row_with_mouse_face): Now static.
3299 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3301 * window.h (check_all_windows): Mark externally visible.
3303 * window.c (window_deletion_count): Now static.
3305 * undo.c: Make symbols static if they're not exported.
3306 (last_undo_buffer, last_boundary_position, pending_boundary):
3309 * textprop.c (interval_insert_behind_hooks): Now static.
3310 (interval_insert_in_front_hooks): Likewise.
3312 * term.c: Make symbols static if they're not exported.
3313 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3314 (max_frame_lines, tty_set_terminal_modes):
3315 (tty_reset_terminal_modes, tty_turn_off_highlight):
3316 (get_tty_terminal): Now static.
3317 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3318 * termhooks.h (term_mouse_moveto): Do not declare if
3320 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3321 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3323 * sysdep.c: Make symbols static if they're not exported.
3324 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3326 (sigprocmask_set, full_mask): Remove; unused.
3327 (wait_debugging): Mark as visible.
3328 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3329 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3331 * syntax.c (syntax_temp): Define only if !__GNUC__.
3333 * sound.c (current_sound_device, current_sound): Now static.
3335 * search.c (searchbufs, searchbuf_head): Now static.
3337 * scroll.c (scroll_cost): Remove; unused.
3338 * dispextern.h (scroll_cost): Remove decl.
3340 * region-cache.h (pp_cache): Mark as externally visible.
3342 * process.c: Make symbols static if they're not exported.
3343 (process_tick, update_tick, create_process, chan_process):
3344 (Vprocess_alist, proc_buffered_char, datagram_access):
3345 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3346 (deactivate_process): Mark defn as static, as well as decl.
3347 * lisp.h (create_process): Remove decl.
3348 * process.h (chan_process, Vprocess_alist): Remove decls.
3350 * print.c: Make symbols static if they're not exported.
3351 (print_depth, new_backquote_output, being_printed, print_buffer):
3352 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3353 (print_interval, print_number_index, initial_stderr_stream):
3355 * lisp.h (Fprinc): Remove decl.
3356 (debug_output_compilation_hack): Mark as externally visible.
3358 * sysdep.c (croak): Move decl from here to syssignal.h.
3359 * syssignal.h (croak): Put it here, so the API can be checked when
3360 'croak' is called from dissociate_if_controlling_tty.
3362 * minibuf.c: Make symbols static if they're not exported.
3363 (minibuf_save_list, choose_minibuf_frame): Now static.
3364 * lisp.h (choose_minibuf_frame): Remove decl.
3366 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3368 * lread.c: Make symbols static if they're not exported.
3369 (read_objects, initial_obarray, oblookup_last_bucket_number):
3371 (make_symbol): Remove; unused.
3372 * lisp.h (initial_obarray, make_symbol): Remove decls.
3374 * keyboard.c: Make symbols static if they're not exported.
3375 (single_kboard, recent_keys_index, total_keys, recent_keys):
3376 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3377 (this_single_command_key_start, echoing, last_auto_save):
3378 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3379 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3380 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3381 (Vlispy_mouse_stem, double_click_count):
3383 (force_auto_save_soon): Define only if SIGDANGER.
3384 (ignore_mouse_drag_p): Now static if
3385 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3386 (print_help): Remove; unused.
3387 (stop_character, last_timer_event): Mark as externally visible.
3388 * keyboard.h (ignore_mouse_drag_p): Declare only if
3389 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3390 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3391 * lisp.h (echoing): Remove decl.
3392 (force_auto_save_soon): Declare only if SIGDANGER.
3393 * xdisp.c (redisplay_window): Simplify code, to make it more
3394 obvious that ignore_mouse_drag_p is not accessed if !defined
3395 USE_GTK && !defined HAVE_NS.
3397 * intervals.c: Make symbols static if they're not exported.
3398 (merge_properties_sticky, merge_interval_right, delete_interval):
3400 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3402 * insdel.c: Make symbols static if they're not exported.
3403 However, leave prepare_to_modify_buffer alone. It's never
3404 called from outside this function, but that appears to be a bug.
3405 (combine_after_change_list, combine_after_change_buffer):
3406 (adjust_after_replace, signal_before_change): Now static.
3407 (adjust_after_replace_noundo): Remove; unused.
3408 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3409 (signal_before_change): Remove decls.
3411 * indent.c (val_compute_motion, val_vmotion): Now static.
3413 * image.c: Make symbols static if they're not exported.
3414 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3416 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3417 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3419 * fringe.c (standard_bitmaps): Now static.
3420 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3422 * frame.c: Make symbols static if they're not exported.
3423 (x_report_frame_params, make_terminal_frame): Now static.
3424 (get_frame_param): Now static, unless HAVE_NS.
3425 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3426 (x_get_resource_string): Remove; not used.
3427 * frame.h (make_terminal_frame, x_report_frame_params):
3428 (x_get_resource_string); Remove decls.
3429 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3430 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3432 * font.c, fontset.c: Make symbols static if they're not exported.
3433 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3434 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3435 * font.c (font_close_object): Now static.
3436 * font.h (font_close_object): Remove.
3437 * fontset.c (FONTSET_OBJLIST): Remove.
3438 (free_realized_fontset) #if-0 the body, which does nothing.
3439 (face_suitable_for_char_p): #if-0, as it's never called.
3440 * fontset.h (face_suitable_for_char_p): Remove decl.
3441 * xfaces.c (face_at_string_position):
3442 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3443 since 0 is always ASCII.
3445 * fns.c (weak_hash_tables): Now static.
3447 * fileio.c: Make symbols static if they're not exported.
3448 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3449 (Vwrite_region_annotation_buffers): Now static.
3451 * eval.c: Make symbols static if they're not exported.
3452 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3453 * lisp.h (backtrace_list): Remove decl.
3455 * emacs.c: Make symbols static if they're not exported.
3456 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3457 (fatal_error_code, fatal_error_signal_hook, standard_args):
3459 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3460 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3461 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3462 * lisp.h (fatal_error_signal_hook): Remove decl.
3463 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3465 * editfns.c: Move a (normally-unused) function to its only use.
3466 * editfns.c, lisp.h (get_operating_system_release): Remove.
3467 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3468 worth the hassle of breaking this out.
3470 * xterm.c: Make symbols static if they're not exported.
3471 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3472 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3473 (x_destroy_window, x_delete_display):
3475 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3476 (x_mouse_leave): Remove; unused.
3477 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3478 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3479 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3481 (x_mouse_leave): Declare only if WINDOWSNT.
3482 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3483 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3486 * ftxfont.c: Make symbols static if they're not exported.
3487 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3489 * font.h (ftxfont_driver): Likewise.
3491 * xfns.c: Make symbols static if they're not exported.
3492 (x_last_font_name, x_display_info_for_name):
3493 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3494 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3495 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3496 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3497 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3498 (last_show_tip_args): Now static.
3499 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3500 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3501 (x_screen_planes): Remove; unused.
3502 * dispextern.h (x_screen_planes): Remove decl.
3504 * dispnew.c: Make symbols static if they're not exported.
3505 * dispextern.h (redraw_garbaged_frames, scrolling):
3506 (increment_row_positions): Remove.
3507 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3508 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3510 (redraw_garbaged_frames): Remove; unused.
3512 * xfaces.c: Make symbols static if they're not exported.
3513 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3515 * xterm.h (defined_color): Remove decls.
3516 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3517 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3518 (menu_face_changed_default, defined_color, free_realized_face):
3519 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3520 (ascii_face_of_lisp_face): Remove; unused.
3522 * xdisp.c: Make symbols static if they're not exported.
3523 * dispextern.h (scratch_glyph_row, window_box_edges):
3524 (glyph_to_pixel_coords, set_cursor_from_row):
3525 (get_next_display_element, set_iterator_to_next):
3526 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3527 (show_mouse_face): Remove decls
3528 * frame.h (message_buf_print): Likewise.
3529 * lisp.h (pop_message, set_message, check_point_in_composition):
3531 * xterm.h (set_vertical_scroll_bar): Likewise.
3532 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3533 (message_buf_print, scratch_glyph_row, displayed_buffer):
3534 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3535 (get_next_display_element, show_mouse_face, window_box_edges):
3536 (frame_to_window_pixel_xy, check_point_in_composition):
3537 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3538 (glyph_to_pixel_coords): Remove; unused.
3540 * dired.c (file_name_completion): Now static.
3542 * dbusbind.c (xd_in_read_queued_messages): Now static.
3544 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3545 * data.c (circular_list_error): Remove.
3547 * commands.h (last_point_position, last_point_position_buffer):
3548 (last_point_position_window): Remove decls.
3549 * keyboard.c: Make these variables static.
3551 * coding.h (coding, code_convert_region, encode_coding_gap):
3553 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3554 (iso_code_class, detect_coding, code_convert_region): Now static.
3555 (encode_coding_gap): Remove; unused.
3557 * chartab.c (chartab_chars, chartab_bits): Now static.
3559 * charset.h (charset_iso_8859_1): Remove decl.
3560 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3563 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3564 * ccl.c (Vccl_program_table): Now static.
3565 (check_ccl_update): Remove; unused.
3567 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3568 * category.h: ... from here.
3569 * category.c (check_category_table, set_category_set): Now static.
3571 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3572 * lisp.h: Remove these decls.
3574 * buffer.c (buffer_count): Remove unused var.
3576 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3577 so that it's not optimized away.
3578 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3579 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3580 exported only to the debugger.
3582 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3583 * atimer.h (run_all_atimers): Remove; not exported.
3585 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3586 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3587 was inaccessible from Lisp.
3588 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3589 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3591 alloc.c: Import and export fewer symbols, and remove unused items.
3592 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3594 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3595 it's not optimized away by whole-program optimization.
3596 (message_enable_multibyte, free_misc): Remove.
3597 (catchlist, handlerlist, mark_backtrace):
3598 Declare only if BYTE_MARK_STACK.
3599 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3600 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3601 (message_enable_multibyte): Remove decl.
3602 (free_misc, interval_free_list, float_block, float_block_index):
3603 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3604 (cons_free_list, last_marked_index):
3606 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3607 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3608 (mark_backtrace): Define only if BYTE_MARK_STACK.
3609 * xdisp.c (message_enable_multibyte): Now static.
3611 Declare Lisp_Object Q* variables to be 'static' if not exported.
3612 This makes it easier for human readers (and static analyzers)
3613 to see whether these variables are used from other modules.
3614 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3615 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3616 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3617 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3618 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3619 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3620 * xmenu.c, xselect.c:
3621 Declare Q* vars static if they are not used in other modules.
3622 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3623 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3624 Remove decls of unexported vars.
3625 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3627 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3629 Make Emacs functions such as Fatom 'static' by default.
3630 This makes it easier for human readers (and static analyzers)
3631 to see whether these functions can be called from other modules.
3632 DEFUN now defines a static function. To make the function external
3633 so that it can be used in other C modules, use the new macro DEFUE.
3634 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3635 (Finit_image_library):
3636 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3637 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3638 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3639 Remove decls, since these functions are now static.
3640 (Funintern, Fget_internal_run_time): New decls, since these functions
3641 were already external.
3643 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3644 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3645 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3646 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3647 * keyboard.c, keymap.c, lread.c:
3648 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3649 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3650 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3651 Mark functions with DEFUE instead of DEFUN,
3652 if they are used in other modules.
3653 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3654 decls for now-static functions.
3655 * buffer.h (Fdelete_overlay): Remove decl.
3656 * callproc.c (Fgetenv_internal): Mark as internal.
3657 * composite.c (Fremove_list_of_text_properties): Remove decl.
3658 (Fcomposition_get_gstring): New forward static decl.
3659 * composite.h (Fcomposite_get_gstring): Remove decl.
3660 * dired.c (Ffile_attributes): New forward static decl.
3661 * doc.c (Fdocumntation_property): New forward static decl.
3662 * eval.c (Ffetch_bytecode): New forward static decl.
3663 (Funintern): Remove extern decl; now in .h file where it belongs.
3664 * fileio.c (Fmake_symbolic_link): New forward static decl.
3665 * image.c (Finit_image_library): New forward static decl.
3666 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3667 * intervals.h (Fprevious_property_change):
3668 (Fremove_list_of_text_properties): Remove decls.
3669 * keyboard.c (Fthis_command_keys): Remove decl.
3670 (Fcommand_execute): New forward static decl.
3671 * keymap.c (Flookup_key): New forward static decl.
3672 (Fcopy_keymap): Now static.
3673 * keymap.h (Flookup_key): Remove decl.
3674 * process.c (Fget_process): New forward static decl.
3675 (Fprocess_datagram_address): Mark as internal.
3676 * syntax.c (Fsyntax_table_p): New forward static decl.
3677 (skip_chars): Remove duplicate decl.
3678 * textprop.c (Fprevious_property_change): New forward static decl.
3679 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3681 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3682 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3684 * editfns.c (Fformat): Remove unreachable code.
3686 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3688 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3691 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3693 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3694 when at ZV. (Bug#8487)
3696 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3698 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3700 * keyboard.c (parse_tool_bar_item): Likewise.
3701 * sound.c (sound_cleanup, alsa_close): Likewise.
3702 * termcap.c (tgetent): Likewise.
3703 * xfns.c (x_default_font_parameter): Likewise.
3704 * xsettings.c (read_and_apply_settings): Likewise.
3706 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3707 (overrun_check_free): Protoize.
3709 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3711 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3712 since callers should never pass a negative size.
3713 Change the signature to match that of plain 'read' and 'write'; see
3714 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3715 * lisp.h: Update prototypes of emacs_write and emacs_read.
3717 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3719 * xdisp.c (redisplay_window): Don't try to determine the character
3720 position of the scroll margin if the window start point w->startp
3721 is outside the buffer's accessible region. (Bug#8468)
3723 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3725 Fix write-region and its subroutines for buffers > 2GB.
3726 * fileio.c (a_write, e_write): Modify declaration of arguments and
3727 local variables to support buffers larger than 2GB.
3728 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3730 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3731 argument, local variables, and return value.
3733 * lisp.h: Update prototypes of emacs_write and emacs_read.
3735 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3737 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3739 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3741 Fix more problems found by GCC 4.6.0's static checks.
3743 * xdisp.c (vmessage): Use a better test for character truncation.
3745 * charset.c (load_charset_map): <, not <=, for optimization,
3746 and to avoid potential problems with integer overflow.
3747 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3748 * casetab.c (set_identity, shuffle): Likewise.
3749 * editfns.c (Fformat): Likewise.
3750 * syntax.c (skip_chars): Likewise.
3752 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3753 This also lets GCC 4.6.0 generate slightly better loop code.
3755 * callint.c (Fcall_interactively): <, not <=, for optimization.
3756 (Fcall_interactively): Count the number of arguments produced,
3757 not the number of arguments given. This is simpler and lets GCC
3758 4.6.0 generate slightly better code.
3760 * ftfont.c: Distingish more carefully between FcChar8 and char.
3761 The previous code passed unsigned char * to a functions like
3762 strlen and xstrcasecmp that expect char *, which does not
3763 conform to the C standard.
3764 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3765 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3766 char * when the C standard requires it.
3768 * keyboard.c (read_char): Remove unused var.
3770 * eval.c: Port to Windows vsnprintf (Bug#8435).
3772 (SIZE_MAX): Define if the headers do not.
3773 (verror): Do not give up if vsnprintf returns a negative count.
3774 Instead, grow the buffer. This ports to Windows vsnprintf, which
3775 does not conform to C99. Problem reported by Eli Zaretskii.
3776 Also, simplify the allocation scheme, by avoiding the need for
3777 calling realloc, and removing the ALLOCATED variable.
3779 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3781 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3782 But keep the doprint source code for now, as we might revamp it
3783 and use it again (Bug#8435).
3784 * lisp.h (doprnt): Remove.
3785 * Makefile.in (base_obj): Remove doprnt.o.
3786 * deps.mk (doprnt.o): Remove.
3788 error: Print 32- and 64-bit integers portably (Bug#8435).
3789 Without this change, on typical 64-bit hosts error ("...%d...", N)
3790 was used to print both 32- and 64-bit integers N, which relied on
3792 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3794 * lisp.h (error, verror): Mark as printf-like functions.
3795 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3796 Report overflow in size calculations when allocating printf buffer.
3797 Do not truncate output string at its first null byte.
3798 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3799 Truncate the output at a character boundary, since vsnprintf does not
3801 * charset.c (check_iso_charset_parameter): Convert internal
3802 character to string before calling 'error', since %c now has the
3804 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3805 overflow when computing char to be passed to 'error'. Do not
3806 pass Lisp_Object to 'error'; pass the integer instead.
3807 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3808 formatted with plain %d.
3810 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3812 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3814 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3816 * xterm.c (x_catch_errors): Remove duplicate declaration.
3818 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3820 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3822 2011-04-10 Jim Meyering <meyering@redhat.com>
3824 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3825 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3826 return ssize_t not "int", and use size_t as the buffer length.
3827 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3828 * gnutls.h: Update declarations.
3829 * process.c (read_process_output): Use ssize_t, to match.
3830 (send_process): Likewise.
3832 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3834 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3836 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3838 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3839 Use unsigned char, to match FcChar8 type definition.
3841 * xterm.c (handle_one_xevent):
3842 * xmenu.c (create_and_show_popup_menu):
3843 * xselect.c (x_decline_selection_request)
3844 (x_reply_selection_request): Avoid type-punned deref of X events.
3846 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3848 Fix some uses of `int' instead of EMACS_INT.
3849 * search.c (string_match_1, fast_string_match)
3850 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3851 (scan_buffer, find_next_newline_no_quit)
3852 (find_before_next_newline, search_command, Freplace_match)
3853 (Fmatch_data): Make some `int' variables be EMACS_INT.
3855 * xdisp.c (display_count_lines): 3rd argument and return value now
3856 EMACS_INT. All callers changed.
3857 (pint2hrstr): Last argument is now EMACS_INT.
3859 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3860 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3861 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3862 (decode_coding_utf_16, decode_coding_emacs_mule)
3863 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3864 (decode_coding_ccl, decode_coding_charset)
3865 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3866 (decode_coding_iso_2022, decode_coding_emacs_mule)
3867 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3868 <char_offset, last_offset>: Declare EMACS_INT.
3869 (encode_coding_utf_8, encode_coding_utf_16)
3870 (encode_coding_emacs_mule, encode_invocation_designation)
3871 (encode_designation_at_bol, encode_coding_iso_2022)
3872 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3873 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3875 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3876 (encode_invocation_designation): Last argument P_NCHARS is now
3878 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3879 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3881 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3884 * ccl.c (Fccl_execute_on_string): Declare some variables
3887 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3889 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3891 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3893 * process.c (Fformat_network_address): Doc fix.
3895 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3897 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3899 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3901 * keyboard.c (read_char): Call Lisp function help-form-show,
3902 instead of using internal_with_output_to_temp_buffer.
3903 (Qhelp_form_show): New var.
3904 (syms_of_keyboard): Use DEFSYM macro.
3906 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3908 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3910 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3912 * process.c (Flist_processes): Remove to Lisp.
3913 (list_processes_1): Delete.
3915 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3917 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3919 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3921 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3923 Fix more problems found by GCC 4.6.0's static checks.
3925 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3927 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3929 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3931 * xdisp.c (vmessage): Mark as a printf-like function.
3933 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3935 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3937 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3938 printf-like functions.
3939 (tiff_load): Add casts to remove these marks before passing them
3940 to system-supplied API.
3942 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3944 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3945 This avoids several warnings with gcc -Wstrict-overflow.
3946 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3947 directly, rather than having caller test rule sign. This avoids
3948 some unnecessary tests.
3949 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3950 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3951 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3953 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3954 (xfont_open): Avoid unnecessary tests.
3956 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3958 * composite.h, composite.c (composition_gstring_put_cache):
3959 Use EMACS_INT, not int, for length.
3961 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3962 breaking out part of COMPOSITION_DECODE_RULE.
3963 (COMPOSITION_DECODE_RULE): Use it.
3964 * composite.c (get_composition_id): Remove unused local vars,
3965 by using the new macro.
3967 * textprop.c (set_text_properties_1): Change while to do-while,
3968 since the condition is always true at first.
3970 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3971 (interval_deletion_adjustment): Return unsigned value.
3974 * process.c (list_processes_1, create_pty, read_process_output):
3975 (exec_sentinel): Remove vars that were set but not used.
3976 (create_pty): Remove unnecessary "volatile"s.
3977 (Fnetwork_interface_info): Avoid possibility of int overflow.
3978 (read_process_output): Do adaptive read buffering even if carryover.
3979 (read_process_output): Simplify nbytes computation if buffered.
3981 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3983 * syntax.c (scan_words): Remove var that was set but not used.
3984 (update_syntax_table): Use unsigned instead of int.
3986 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3987 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3988 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3990 * print.c (print_error_message): Avoid int overflow.
3992 * font.c (font_list_entities): Redo for clarity,
3993 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3995 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3996 (font_score): Avoid potential overflow in diff calculation.
3998 * fns.c (substring_both): Remove var that is set but not used.
3999 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4001 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4003 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4004 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4005 can always succeed if overflow has undefined behavior.
4007 * search.c (boyer_moore, wordify): Remove vars set but not used.
4008 (wordify): Omit three unnecessary tests.
4010 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4011 All callers changed. This avoids the need for an unused var.
4013 * casefiddle.c (casify_region): Remove var that is set but not used.
4015 * dired.c (file_name_completion): Remove var that is set but not used.
4017 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4019 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4020 (Finsert_file_contents): Remove unnecessary code checking fd.
4022 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4023 Check for integer overflow on size calculations.
4025 * buffer.c (Fprevious_overlay_change): Remove var that is set
4028 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4029 Remove vars that are set but not used.
4030 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4031 (timer_check_2): Mark vars as initialized.
4033 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4035 * image.c (lookup_image): Remove var that is set but not used.
4036 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4038 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4039 that are set but not used.
4041 * xfns.c (make_invisible_cursor): Don't return garbage
4042 if XCreateBitmapFromData fails (Bug#8410).
4044 * xselect.c (x_get_local_selection, x_handle_property_notify):
4045 Remove vars that are set but not used.
4047 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4048 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4050 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4051 Remove var that is set but not used.
4052 (scroll_bar_windows_size): Now size_t, not int.
4053 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4056 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4057 (map_tty_color) [!defined MSDOS]: Likewise.
4059 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4061 * coding.c: Remove vars that are set but not used.
4062 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4063 All callers changed.
4064 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4065 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4066 (decode_coding_charset): Remove vars that are set but not used.
4068 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4069 that is set but not used.
4071 * print.c (print_object): Remove var that is set but not used.
4073 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4074 The gnulib version avoids calling malloc in the usual case,
4075 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4076 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4077 * filelock.c (current_lock_owner): Likewise.
4078 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4079 * sysdep.c: Include allocator.h, careadlinkat.h.
4080 (emacs_no_realloc_allocator): New static constant.
4081 (emacs_readlink): New function.
4082 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4083 ../lib/careadlinkat.h.
4085 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4087 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4088 first non-nil return value).
4090 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4092 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4093 if not defined (Bug#8403).
4095 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4097 * xdisp.c (display_count_lines): Remove parameter `start',
4098 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4099 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4100 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4101 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4102 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4103 and thereabouts. All callers changed.
4104 (get_per_char_metric): Remove parameter `f', unused since
4105 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4107 2011-04-02 Jim Meyering <meyering@redhat.com>
4109 do not dereference NULL upon failed strdup
4110 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4111 (ns_get_family): Likewise.
4113 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4115 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4117 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4119 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4122 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4124 Add lexical binding.
4126 * window.c (Ftemp_output_buffer_show): New fun.
4127 (Fsave_window_excursion):
4128 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4130 * lread.c (lisp_file_lexically_bound_p): New function.
4131 (Fload): Bind Qlexical_binding.
4132 (readevalloop): Remove `evalfun' arg.
4133 Bind Qinternal_interpreter_environment.
4134 (Feval_buffer): Bind Qlexical_binding.
4135 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4137 (syms_of_lread): Declare `lexical-binding'.
4139 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4141 * keyboard.c (eval_dyn): New fun.
4142 (menu_item_eval_property): Use it.
4144 * image.c (parse_image_spec): Use Ffunctionp.
4146 * fns.c (concat, mapcar1): Accept byte-code-functions.
4148 * eval.c (Fsetq): Handle lexical vars.
4149 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4150 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4151 (FletX, Flet): Obey lexical binding.
4152 (Fcommandp): Handle closures.
4153 (Feval): New `lexical' arg.
4154 (eval_sub): New function extracted from Feval. Use it almost
4155 everywhere where Feval was used. Look up vars in lexical env.
4157 (Ffunctionp): Move from subr.el.
4158 (Ffuncall): Handle closures.
4159 (apply_lambda): Remove `eval_flags'.
4160 (funcall_lambda): Handle closures and new byte-code-functions.
4161 (Fspecial_variable_p): New function.
4162 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4163 but without exporting it to Lisp.
4165 * doc.c (Fdocumentation, store_function_docstring):
4166 * data.c (Finteractive_form): Handle closures.
4168 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4171 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4173 (exec_byte_code): New function extracted from Fbyte_code to handle new
4174 calling convention for byte-code-functions. Add new byte-codes.
4176 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4178 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4180 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4182 * xdisp.c (redisplay_internal): Fix prototype.
4184 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4186 * xdisp.c (SCROLL_LIMIT): New macro.
4187 (try_scrolling): Use it when setting scroll_limit.
4188 Limit scrolling to 100 screen lines.
4189 (redisplay_window): Even when falling back on "recentering",
4190 position point in the window according to scroll-conservatively,
4191 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4193 (try_scrolling): When point is above the window, allow searching
4194 as far as scroll_max, or one screenful, to compute vertical
4195 distance from PT to the scroll margin position. This prevents
4196 try_scrolling from unnecessarily failing when
4197 scroll-conservatively is set to a value slightly larger than the
4198 window height. Clean up the case of PT below the margin at bottom
4199 of window: scroll_max can no longer be INT_MAX. When aggressive
4200 scrolling is in use, don't let point enter the opposite scroll
4201 margin as result of the scroll.
4202 (syms_of_xdisp) <scroll-conservatively>: Document the
4203 threshold of 100 lines for never-recentering scrolling.
4205 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4207 * dispextern.h (move_it_by_lines):
4208 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4209 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4210 (message_log_check_duplicate): Remove parameters `prev_bol' and
4211 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4212 (redisplay_internal): Remove parameter `preserve_echo_area',
4213 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4215 * indent.c (Fvertical_motion):
4216 * window.c (window_scroll_pixel_based, Frecenter):
4217 Don't pass `need_y_p' to `move_it_by_lines'.
4219 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4221 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4222 steal a few bits to be more compact.
4223 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4224 Remove unneeded casts.
4226 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4228 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4230 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4231 binding" message (bug#7967).
4233 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4235 Fix more problems found by GCC 4.6.0's static checks.
4237 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4238 Remove unused local var.
4240 * editfns.c (Fmessage_box): Remove unused local var.
4242 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4243 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4244 Omit unused local vars.
4245 * window.c (shrink_windows): Omit unused local var.
4246 * menu.c (digest_single_submenu): Omit unused local var.
4247 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4248 Omit unused local var.
4250 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4251 Don't assume string length fits in int.
4252 (keyremap_step, read_key_sequence): Use size_t for sizes.
4253 (read_key_sequence): Don't check last_real_key_start redundantly.
4255 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4256 instead of alloca (Bug#8344).
4258 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4259 (Fbacktrace_frame): Don't assume nframes fits in int.
4261 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4263 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4266 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4268 * cm.c (calccost): Turn while-do into do-while, for clarity.
4270 * keyboard.c (syms_of_keyboard): Use the same style as later
4271 in this function when indexing through an array. This also
4272 works around GCC bug 48267.
4274 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4276 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4278 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4279 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4281 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4282 This avoids undefined behavior on integer overflow, and is a bit
4283 more convenient anyway since it is compared to a size_t variable.
4285 Variadic C functions now count arguments with size_t, not int.
4286 This avoids an unnecessary limitation on 64-bit machines, which
4287 caused (substring ...) to crash on large vectors (Bug#8344).
4288 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4289 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4290 All variadic functions and their callers changed accordingly.
4291 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4292 * data.c (arith_driver, float_arith_driver): Likewise.
4293 * editfns.c (general_insert_function): Likewise.
4294 * eval.c (struct backtrace.nargs, interactive_p)
4295 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4296 (funcall_lambda, mark_backtrace): Likewise.
4297 * fns.c (concat): Likewise.
4298 * frame.c (x_set_frame_parameters): Likewise.
4299 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4300 0 if not found, not -1. All callers changed.
4302 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4303 (stack_copy_size): Now size_t, not int.
4304 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4306 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4308 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4309 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4310 All callers changed.
4312 * lisp.h (multibyte_char_to_unibyte):
4313 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4314 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4315 * character.h (CHAR_TO_BYTE8):
4316 * cmds.c (internal_self_insert):
4317 * editfns.c (general_insert_function):
4318 * keymap.c (push_key_description):
4319 * search.c (Freplace_match):
4320 * xdisp.c (message_dolog, set_message_1): All callers changed.
4322 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4324 * keyboard.c (safe_run_hook_funcall): New function.
4325 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4326 don't set the hook to nil, but remove the offending function instead.
4327 (Qcommand_hook_internal): Remove, unused.
4328 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4329 Vcommand_hook_internal.
4331 * eval.c (enum run_hooks_condition): Remove.
4332 (funcall_nil, funcall_not): New functions.
4333 (run_hook_with_args): Call each function through a `funcall' argument.
4334 Remove `cond' argument, now redundant.
4335 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4336 (Frun_hook_with_args_until_failure): Adjust accordingly.
4337 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4339 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4341 * dispextern.h (string_buffer_position): Remove declaration.
4343 * print.c (strout): Remove parameter `multibyte', unused since
4344 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4346 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4347 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4348 All callers changed.
4350 * w32.c (_wsa_errlist): Use braces for struct initializers.
4352 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4353 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4354 All callers changed.
4355 (string_buffer_position): Likewise. Also, make static (it's never
4356 used outside xdisp.c).
4357 (cursor_row_p): Remove parameter `w', unused since
4358 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4359 (decode_mode_spec): Remove parameter `precision', introduced during
4360 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4361 All callers changed.
4363 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4365 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4367 2011-03-27 Anders Lindgren <andlind@gmail.com>
4369 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4370 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4371 (ns_update_auto_hide_menu_bar): New functions.
4372 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4373 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4374 ns_constrain_all_frames.
4375 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4376 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4378 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4380 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4382 2011-03-27 Glenn Morris <rgm@gnu.org>
4384 * syssignal.h: Replace RETSIGTYPE with void.
4385 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4386 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4387 Replace SIGTYPE with void everywhere.
4388 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4389 * s/template.h (SIGTYPE): Remove commented out definition.
4391 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4393 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4394 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4396 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4398 * w32.c (read_unc_volume): Use parameter `henum', instead of
4399 global variable `wget_enum_handle'.
4401 * keymap.c (describe_vector): Remove parameters `indices' and
4402 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4403 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4405 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4407 * keyboard.c (timer_check): Remove parameter `do_it_now',
4408 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4409 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4410 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4412 * keyboard.c (read_char):
4413 * w32menu.c (w32_menu_display_help):
4414 * xmenu.c (show_help_event, menu_help_callback):
4415 Adjust calls to `show_help_echo'.
4417 * gtkutil.c (xg_maybe_add_timer):
4418 * keyboard.c (readable_events):
4419 * process.c (wait_reading_process_output):
4420 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4422 * insdel.c (adjust_markers_gap_motion):
4423 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4424 (gap_left, gap_right): Don't call it.
4426 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4428 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4429 incurred during fontification.
4431 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4433 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4434 (DEFVAR_PER_BUFFER): Don't pass it.
4436 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4437 (scrolling_window): Don't pass it.
4439 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4441 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4443 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4445 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4446 of variables specific to SELinux and computation of `encoded_absname'.
4448 * image.c (XPutPixel): Remove unused variable `height'.
4450 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4452 * unexw32.c (get_section_info): Remove unused variable `section'.
4454 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4455 (system_process_attributes): Remove unused variable `sess'.
4456 (sys_read): Remove unused variable `err'.
4458 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4459 (w32_wnd_proc): Remove unused variable `isdead'.
4460 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4461 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4462 (x_create_tip_frame): Remove unused variable `tem'.
4464 * w32inevt.c (w32_console_read_socket):
4465 Remove unused variable `no_events'.
4467 * w32term.c (x_draw_composite_glyph_string_foreground):
4468 Remove unused variable `width'.
4470 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4472 * w32term.c (x_set_glyph_string_clipping):
4473 Don't pass uninitialized region to CombineRgn.
4475 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4477 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4478 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4479 (Fx_close_connection): Remove unused variable `i'.
4481 * w32font.c (w32font_draw): Return number of glyphs.
4482 (w32font_open_internal): Remove unused variable `i'.
4483 (w32font_driver): Add missing initializer.
4485 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4486 (fill_in_menu): Remove unused variable `items_added'.
4488 * w32term.c (last_mouse_press_frame): Remove static global variable.
4489 (w32_clip_to_row): Remove unused variable `f'.
4490 (x_delete_terminal): Remove unused variable `i'.
4492 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4493 (NOTHING): Remove unused static global variable.
4494 (uniscribe_check_otf): Remove unused variable `table'.
4495 (uniscribe_font_driver): Add missing initializers.
4497 2011-03-23 Julien Danjou <julien@danjou.info>
4499 * term.c (Fsuspend_tty, Fresume_tty):
4500 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4501 * window.c (temp_output_buffer_show):
4502 * insdel.c (signal_before_change):
4503 * frame.c (Fhandle_switch_frame):
4504 * fileio.c (Fdo_auto_save):
4505 * emacs.c (Fkill_emacs):
4506 * editfns.c (save_excursion_restore):
4507 * cmds.c (internal_self_insert):
4508 * callint.c (Fcall_interactively):
4509 * buffer.c (Fkill_all_local_variables):
4510 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4512 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4513 unconditionnaly since it does the check itself.
4515 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4517 Fix more problems found by GCC 4.5.2's static checks.
4519 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4520 the first time through the loop, since we know p0 < p1 then.
4521 This also avoids a gcc -Wstrict-overflow warning.
4523 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4524 leading to a memory leak, possible in functions like
4525 load_charset_map_from_file that can allocate an unbounded number
4526 of objects (Bug#8318).
4528 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4529 that could (at least in theory) be that large.
4531 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4532 This is less likely to overflow, and avoids undefined behavior if
4533 overflow does occur. All callers changed. Use strtoul to scan
4534 for the unsigned long integer.
4535 (pint2hrstr): Simplify and tune code slightly.
4536 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4538 * scroll.c (do_scrolling): Work around GCC bug 48228.
4539 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4541 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4542 This also avoids a warning with gcc -Wstrict-overflow.
4543 (validate_x_resource_name): Simplify count usage.
4544 This also avoids a warning with gcc -Wstrict-overflow.
4546 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4549 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4551 * process.c (Fmake_network_process): Use socklen_t, not int,
4552 where POSIX says socklen_t is required in portable programs.
4553 This fixes a porting bug on hosts like 64-bit HP-UX, where
4554 socklen_t is wider than int (Bug#8277).
4555 (Fmake_network_process, server_accept_connection):
4556 (wait_reading_process_output, read_process_output):
4559 * process.c: Rename or move locals to avoid shadowing.
4560 (list_processes_1, Fmake_network_process):
4561 (read_process_output_error_handler, exec_sentinel_error_handler):
4562 Rename or move locals.
4563 (Fmake_network_process): Define label "retry_connect" only if needed.
4564 (Fnetwork_interface_info): Fix pointer signedness.
4565 (process_send_signal): Add cast to avoid pointer signedness problem.
4566 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4567 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4569 Make tparam.h and terminfo.c consistent.
4570 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4571 Include tparam.h instead, since it declares them.
4572 * cm.h (PC): Remove extern decl; tparam.h now does this.
4573 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4574 * terminfo.c: Include tparam.h, to check interfaces.
4575 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4576 (tparam): Adjust signature to match interface in tparam.h;
4577 this removes some undefined behavior. Check that outstring and len
4578 are zero, which they always are with Emacs.
4579 * tparam.h (PC, BC, UP): New extern decls.
4581 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4582 (xftfont_open): Rename locals to avoid shadowing.
4584 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4585 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4586 (OTF_TAG_SYM): Omit macro if not needed.
4587 (ftfont_list): Remove unused local.
4588 (get_adstyle_property, ftfont_pattern_entity):
4589 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4590 Rename locals to avoid shadowing.
4592 * xfont.c (xfont_list_family): Mark var as initialized.
4594 * xml.c (make_dom): Now static.
4596 * composite.c (composition_compute_stop_pos): Rename local to
4598 (composition_reseat_it): Remove unused locals.
4599 (find_automatic_composition, composition_adjust_point): Likewise.
4600 (composition_update_it): Mark var as initialized.
4601 (find_automatic_composition): Mark vars as initialized,
4602 with a FIXME (Bug#8290).
4604 character.h: Rename locals to avoid shadowing.
4605 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4606 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4607 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4608 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4611 * textprop.c (property_change_between_p): Remove; unused.
4613 * intervals.c (interval_start_pos): Now static.
4615 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4617 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4618 Rename locals to avoid shadowing.
4620 * sound.c (wav_play, au_play, Fplay_sound_internal):
4621 Fix pointer signedness.
4622 (alsa_choose_format): Remove unused local var.
4623 (wav_play): Initialize a variable to 0, to prevent undefined
4624 behavior (Bug#8278).
4626 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4628 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4630 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4631 clobbering (Bug#8298).
4632 * sysdep.c (sys_subshell): Likewise.
4633 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4635 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4636 This should get cleaned up, so that child_setup has the
4637 same signature on all platforms.
4639 * callproc.c (call_process_cleanup): Now static.
4640 (relocate_fd): Rename locals to avoid shadowing.
4642 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4644 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4645 not to be necessary, and produces flickering.
4647 2011-03-20 Glenn Morris <rgm@gnu.org>
4649 * config.in: Remove file.
4651 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4653 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4654 are now in src/globals.h.
4655 (syms_of_minibuf): Remove spurious & from previous change.
4657 2011-03-20 Leo <sdl.web@gmail.com>
4659 * minibuf.c (completing-read-function): New variable.
4660 (completing-read-default): Rename from completing-read.
4661 (completing-read): Call completing-read-function.
4663 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4665 * xfaces.c (Fx_load_color_file):
4666 Read color file from absolute filename (bug#8250).
4668 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4670 * makefile.w32-in: Update dependencies.
4672 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4674 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4676 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4678 Fix more problems found by GCC 4.5.2's static checks.
4680 * process.c (make_serial_process_unwind, send_process_trap):
4681 (sigchld_handler): Now static.
4683 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4684 That way, the code declares only the vars that it needs.
4685 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4686 * s/cygwin.h (PTY_ITERATION): Likewise.
4687 * s/darwin.h (PTY_ITERATION): Likewise.
4688 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4690 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4691 * process.c (allocate_pty): Don't declare stb unless it's needed.
4693 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4694 (CONSTANTLIM): Remove; unused.
4695 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4696 Define only if needed.
4698 * unexelf.c (unexec): Name an expression,
4699 to avoid gcc -Wbad-function-cast warning.
4700 Use a different way to cause a compilation error if anyone uses
4701 n rather than nn, a way that does not involve shadowing.
4702 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4704 * deps.mk (unexalpha.o): Remove; unused.
4706 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4707 * unexec.h: New file.
4708 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4709 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4711 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4712 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4713 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4714 Change as necessary to match prototype in unexec.h.
4716 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4718 (back_comment, skip_chars): Mark vars as initialized.
4720 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4721 Rename locals to avoid shadowing.
4723 * lread.c (read1): Rewrite so as not to use empty "else".
4724 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4726 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4728 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4729 warning when compiling print.c.
4731 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4732 instead of using an uninitialized var.
4733 (font_sort_entities): Mark var as initialized.
4735 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4737 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4738 pointers to constants.
4739 (font_parse_fcname): Remove unused vars.
4740 (font_delete_unmatched): Now static.
4741 (font_get_spec): Remove; unused.
4742 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4743 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4744 Rename or move locals to avoid shadowing.
4746 * fns.c (require_nesting_list, require_unwind): Now static.
4747 (Ffillarray): Rename locals to avoid shadowing.
4749 * floatfns.c (domain_error2): Define only if needed.
4750 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4752 * alloc.c (mark_backtrace): Move decl from here ...
4753 * lisp.h: ... to here, so that it can be checked.
4755 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4756 (Fdefvar): Rewrite so as not to use empty "else".
4757 (lisp_indirect_variable): Name an expression,
4758 to avoid gcc -Wbad-function-cast warning.
4759 (Fdefvar): Rename locals to avoid shadowing.
4761 * callint.c (quotify_arg, quotify_args): Now static.
4762 (Fcall_interactively): Rename locals to avoid shadowing.
4763 Use const pointer when appropriate.
4765 * lisp.h (get_system_name, get_operating_system_release):
4766 Move decls here, to check interfaces.
4767 * process.c (get_operating_system_release): Move decl to lisp.h.
4768 * xrdb.c (get_system_name): Likewise.
4769 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4770 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4771 some of which prompt warnings from gcc -Wbad-function-cast.
4772 (Fformat_time_string, Fencode_time, Finsert_char):
4773 (Ftranslate_region_internal, Fformat):
4774 Rename or remove local vars to avoid shadowing.
4775 (Ftranslate_region_internal): Mark var as initialized.
4777 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4780 * lisp.h (eassert): Check that the argument compiles, even if
4781 ENABLE_CHECKING is not defined.
4783 * data.c (Findirect_variable): Name an expression, to avoid
4784 gcc -Wbad-function-cast warning.
4785 (default_value, arithcompare, arith_driver, arith_error): Now static.
4786 (store_symval_forwarding): Rename local to avoid shadowing.
4787 (Fmake_variable_buffer_local, Fmake_local_variable):
4788 Mark variables as initialized.
4789 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4791 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4792 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4793 Rename locals to avoid shadowing.
4794 (mark_stack): Move local variables into the #ifdef region where
4796 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4797 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4799 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4800 (GC_STRING_CHARS): Remove; not used.
4801 (Fmemory_limit): Cast sbrk's returned value to char *.
4803 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4804 avoids undefined behavior in theory.
4806 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4808 Use functions, not macros, for up- and down-casing (Bug#8254).
4809 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4810 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4811 to use the following functions instead of these macros.
4812 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4813 EMACS_INT, since callers assume the returned value fits in int.
4814 (upcase1): Likewise, for UPCASE_TABLE.
4815 (uppercasep, lowercasep, upcase): New static inline functions.
4816 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4817 the race-condition problem in the old DOWNCASE.
4819 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4820 Rename locals to avoid shadowing.
4821 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4822 (regex_compile, re_search_2, re_match_2_internal):
4823 Remove unused local vars.
4824 (FREE_VAR): Rewrite so as not to use empty "else",
4825 which gcc can warn about.
4826 (regex_compile, re_match_2_internal): Mark locals as initialized.
4827 (RETALLOC_IF): Define only if needed.
4828 (WORDCHAR_P): Likewise. This one is never needed, but is used
4829 only in a comment talking about a compiler bug, so put inside
4830 the #if 0 of that comment.
4831 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4832 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4835 * search.c (boyer_moore): Rename locals to avoid shadowing.
4836 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4837 (PREV_CHAR_BOUNDARY): Likewise.
4839 * search.c (simple_search): Remove unused var.
4841 * dired.c (compile_pattern): Move decl from here ...
4842 * lisp.h: ... to here, so that it can be checked.
4843 (struct re_registers): New forward decl.
4845 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4847 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4849 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4850 Rename locals to avoid shadowing.
4851 (Fvertical_motion): Mark locals as initialized.
4853 * casefiddle.c (casify_object, casify_region): Now static.
4854 (casify_region): Mark local as initialized.
4856 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4858 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4859 New macros, so that the caller can use some names other than
4860 gcpro1, gcpro2, etc.
4861 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4863 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4864 argument, for consistency with GCPRO2_VAR, etc: it is now the
4865 prefix of the variable, not the variable itself. All uses
4867 * dired.c (directory_files_internal, file_name_completion):
4868 Rename locals to avoid shadowing.
4870 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4871 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4872 dired.c's scmp function, had undefined behavior.
4873 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4874 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4875 * buffer.h: ... to here, because these macros use current_buffer,
4876 and the new implementation with inline functions needs to have
4877 current_buffer in scope now, rather than later when the macros
4879 (downcase, upcase1): New static inline functions.
4880 (DOWNCASE, UPCASE1): Reimplement using these functions.
4881 This avoids undefined behavior in expressions like
4882 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4883 from race conditions in accessing the global variables
4884 case_temp1 and case_temp2.
4885 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4886 * lisp.h (case_temp1, case_temp2): Remove their decls.
4887 * character.h (ASCII_CHAR_P): Move from here ...
4888 * lisp.h: ... to here, so that the inline functions mentioned
4891 * dired.c (directory_files_internal_unwind): Now static.
4893 * fileio.c (file_name_as_directory, directory_file_name):
4894 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4896 (file_name_as_directory): Use const pointers when appropriate.
4897 (Fexpand_file_name): Likewise. In particular, newdir might
4898 point at constant storage, so make it a const pointer.
4899 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4900 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4902 (Fset_file_times, Finsert_file_contents, auto_save_error):
4903 Rename locals to avoid shadowing.
4905 * minibuf.c (choose_minibuf_frame_1): Now static.
4906 (Ftry_completion, Fall_completions): Rename or remove locals
4909 * marker.c (bytepos_to_charpos): Remove; unused.
4911 * lisp.h (verify_bytepos, count_markers): New decls,
4912 so that gcc does not warn that these functions aren't declared.
4914 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4915 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4916 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4917 (copy_text): Remove unused local var.
4919 * filelock.c (within_one_second): Now static.
4920 (lock_file_1): Rename local to avoid shadowing.
4922 * buffer.c (fix_overlays_before): Mark locals as initialized.
4923 (fix_start_end_in_overlays): Likewise. This function should be
4924 simplified by using pointers-to-pointers, but that's a different
4926 (switch_to_buffer_1): Now static.
4927 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4928 (report_overlay_modification): Rename locals to avoid shadowing.
4930 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4931 Fix pointer signedness issue.
4932 (sys_subshell): Mark local as volatile if checking for lint,
4933 to suppress a gcc -Wclobbered warning that does not seem to be right.
4934 (MAXPATHLEN): Define only if needed.
4936 * process.c (serial_open, serial_configure): Move decls from here ...
4937 * systty.h: ... to here, so that they can be checked.
4939 * fns.c (get_random, seed_random): Move extern decls from here ...
4940 * lisp.h: ... to here, so that they can be checked.
4942 * sysdep.c (reset_io): Now static.
4943 (wait_for_termination_signal): Remove; unused.
4945 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4946 (copy_keymap_item, append_key, push_text_char_description):
4948 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4949 (DENSE_TABLE_SIZE): Remove; unused.
4950 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4951 (describe_map_tree):
4952 Rename locals to avoid shadowing.
4954 * keyboard.c: Declare functions static if they are not used elsewhere.
4955 (echo_char, echo_dash, cmd_error, top_level_2):
4956 (poll_for_input, handle_async_input): Now static.
4957 (read_char, kbd_buffer_get_event, make_lispy_position):
4958 (make_lispy_event, make_lispy_movement, apply_modifiers):
4959 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4960 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4961 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4962 (read_key_sequence, read_char): Mark locals as initialized.
4963 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4965 * keyboard.h (make_ctrl_char): New decl.
4966 (mark_kboards): Move decl here ...
4967 * alloc.c (mark_kboards): ... from here.
4969 * lisp.h (force_auto_save_soon): New decl.
4971 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4972 (DEFINE_DUMMY_FUNCTION): New macro.
4973 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4975 (main): Add casts to avoid warnings
4976 if GCC considers string literals to be constants.
4978 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4980 * dbusbind.c: Pointer signedness fixes.
4981 (xd_signature, xd_append_arg, xd_initialize):
4982 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4983 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4984 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4985 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4987 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4988 if GCC considers string literals to be constants.
4989 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4991 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4993 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4994 (print_preprocess, print_object): New macro to fix last change.
4996 * print.c (print_preprocess): Don't forget font objects.
4998 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5000 * emacs.c (USAGE3): Doc fixes.
5002 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5004 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5007 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5009 * lisp.h (VWindow_system, Qfile_name_history):
5010 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5011 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5012 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5014 * w32select.c: Don't #include "keyboard.h".
5015 (run_protected): Add extern declaration for waiting_for_input.
5017 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5018 * w32console.c (detect_input_pending, read_input_pending)
5019 (encode_terminal_code):
5020 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5021 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5022 (w32_system_caret_y, Qfile_name_history):
5023 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5024 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5025 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5026 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5027 * w32proc.c (Qlocal, report_file_error):
5028 * w32term.c (Vwindow_system, updating_frame):
5029 * w32uniscribe.c (initialized, uniscribe_font_driver):
5030 Remove unneeded extern declarations.
5032 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5034 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5036 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5038 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5039 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5040 These macros can no longer be used for assignment.
5042 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5043 Assign struct members directly, instead of using BUF_BEGV etc.
5044 (record_buffer_markers, fetch_buffer_markers): New functions for
5045 recording and fetching special buffer markers.
5046 (set_buffer_internal_1, set_buffer_temp): Use them.
5048 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5050 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5052 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5053 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5055 * xdisp.c (hscroll_window_tree):
5056 (reconsider_clip_changes): Use PT instead of BUF_PT.
5058 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5060 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5061 $(EMACS_ROOT)/lib/intprops.h.
5063 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5065 Fix more problems found by GCC 4.5.2's static checks.
5067 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5068 to unsigned char * to avoid compiler diagnostic.
5069 (xg_free_frame_widgets): Make it clear that a local variable is
5070 needed only if USE_GTK_TOOLTIP.
5071 (gdk_window_get_screen): Make it clear that this macro is needed
5072 only if USE_GTK_TOOLTIP.
5073 (int_gtk_range_get_value): New function, which avoids a diagnostic
5074 from gcc -Wbad-function-cast.
5075 (xg_set_toolkit_scroll_bar_thumb): Use it.
5076 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5077 diagnostic from gcc -Wbad-function-cast.
5078 (get_utf8_string, xg_get_file_with_chooser):
5079 Rename locals to avoid shadowing.
5080 (create_dialog): Move locals to avoid shadowing.
5082 * xgselect.c (xg_select): Remove unused var.
5084 * image.c (four_corners_best): Mark locals as initialized.
5085 (gif_load): Initialize transparent_p to zero (Bug#8238).
5086 Mark another local as initialized.
5087 (my_png_error, my_error_exit): Mark with NO_RETURN.
5089 * image.c (clear_image_cache): Now static.
5090 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5091 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5092 (x_edge_detection): Remove unnecessary cast that
5093 gcc -Wbad-function-cast diagnoses.
5094 (gif_load): Fix pointer signedness.
5095 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5096 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5098 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5100 Improve quality of tests for time stamp overflow.
5101 For example, without this patch (encode-time 0 0 0 1 1
5102 1152921504606846976) returns the obviously-bogus value (-948597
5103 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5104 reports time overflow. See
5105 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5106 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5107 * editfns.c: Include limits.h and intprops.h.
5108 (TIME_T_MIN, TIME_T_MAX): New macros.
5109 (time_overflow): Move earlier, to before first use.
5110 (hi_time, lo_time): New functions, for an accurate test for
5112 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5113 (Fget_internal_run_time): Don't assume time_t fits in int.
5114 (make_time): Use list2 instead of Fcons twice.
5115 (Fdecode_time): More accurate test for out-of-range times.
5116 (check_tm_member): New function.
5117 (Fencode_time): Use it, to test for out-of-range times.
5118 (lisp_time_argument): Don't rely on undefined left-shift and
5119 right-shift behavior when checking for time stamp overflow.
5121 * editfns.c (time_overflow): New function, refactoring common code.
5122 (Fformat_time_string, Fdecode_time, Fencode_time):
5123 (Fcurrent_time_string): Use it.
5125 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5126 * dired.c (make_time): Move to ...
5127 * editfns.c (make_time): ... here.
5128 * systime.h: Note the move.
5130 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5132 * fringe.c (update_window_fringes): Remove unused variables.
5134 * unexmacosx.c (copy_data_segment): Also copy __got section.
5137 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5139 * termcap.c [MSDOS]: Include "msdos.h".
5140 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5141 Constify `char *' arguments and their references according to
5142 prototypes in tparam.h.
5144 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5146 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5147 Adapt all references accordingly.
5149 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5151 2011-03-11 Tom Tromey <tromey@redhat.com>
5153 * buffer.c (syms_of_buffer): Remove obsolete comment.
5155 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5157 * termhooks.h (encode_terminal_code): Declare prototype.
5159 * msdos.c (encode_terminal_code): Don't declare prototype.
5161 * term.c (encode_terminal_code): Now external again, used by
5162 w32console.c and msdos.c.
5164 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5165 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5167 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5169 Fix some minor problems found by GCC 4.5.2's static checks.
5171 * fringe.c (update_window_fringes): Mark locals as initialized
5173 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5175 * alloc.c (mark_fringe_data): Move decl from here ...
5176 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5177 to check its interface.
5178 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5180 * fontset.c (free_realized_fontset): Now static.
5181 (Fset_fontset_font): Rename local to avoid shadowing.
5182 (fontset_font): Mark local as initialized.
5183 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5185 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5187 * xselect.c (x_disown_buffer_selections): Remove; not used.
5188 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5189 (x_own_selection, Fx_disown_selection_internal): Rename locals
5191 (x_handle_dnd_message): Remove local to avoid shadowing.
5193 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5194 so that the caller can use some name other than gcpro1.
5195 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5196 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5197 (Fx_backspace_delete_keys_p):
5198 Use them to avoid shadowing, and rename vars to avoid shadowing.
5199 (x_decode_color, x_set_name, x_window): Now static.
5200 (Fx_create_frame): Add braces to silence GCC warning.
5201 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5202 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5203 Remove unused locals.
5204 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5205 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5206 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5209 * xterm.h (x_mouse_leave): New decl.
5211 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5212 Remove unused functions.
5213 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5214 (x_calc_absolute_position): Now static.
5215 (XTread_socket): Don't define label "out" unless it's used.
5216 Don't declare local "event" unless it's used.
5217 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5218 unless they are used.
5219 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5220 (x_fatal_error_signal): Remove; not used.
5221 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5222 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5223 (x_error_catcher, x_connection_closed, x_error_handler):
5224 (x_error_quitter, xembed_send_message, x_iconify_frame):
5225 (my_log_handler): Rename locals to avoid shadowing.
5226 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5227 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5229 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5230 Rename or move locals to avoid shadowing.
5231 (tty_defined_color, merge_face_heights): Now static.
5232 (free_realized_faces_for_fontset): Remove; not used.
5233 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5234 does not deduce is never used uninitialized.
5235 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5236 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5238 * terminal.c (store_terminal_param): Now static.
5240 * xmenu.c (menu_highlight_callback): Now static.
5241 (set_frame_menubar): Remove unused local.
5242 (xmenu_show): Rename parameter to avoid shadowing.
5243 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5244 since they might point to immutable storage.
5245 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5246 since it's unused otherwise.
5248 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5249 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5250 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5251 avoids a gcc -Wuninitialized diagnostic.
5252 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5253 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5254 does not deduce are never used uninitialized.
5256 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5258 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5259 * window.c (window_loop, size_window):
5260 (run_window_configuration_change_hook, enlarge_window): Likewise.
5262 * window.c (display_buffer): Now static.
5263 (size_window): Mark variables that gcc -Wuninitialized
5264 does not deduce are never used uninitialized.
5265 * window.h (check_all_windows): New decl, to forestall
5266 gcc -Wmissing-prototypes diagnostic.
5267 * dispextern.h (bidi_dump_cached_states): Likewise.
5269 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5271 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5273 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5274 and to avoid gcc -Wuninitialized warning.
5275 (load_charset_map): Mark variables that gcc -Wuninitialized
5276 does not deduce are never used uninitialized.
5277 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5279 * coding.c (coding_set_source, coding_set_destination):
5280 Use "else { /* comment */ }" rather than "else /* comment */;"
5281 for clarity, and to avoid gcc -Wempty-body warning.
5282 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5283 a block, when the outer 'i' will do.
5284 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5285 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5286 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5287 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5288 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5289 Rename locals to avoid shadowing.
5290 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5291 * coding.c (emacs_mule_char, encode_invocation_designation):
5292 Now static, since they're not used elsewhere.
5293 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5294 (decode_coding_object, encode_coding_object, detect_coding_system):
5295 (decode_coding_emacs_mule): Mark variables that gcc
5296 -Wuninitialized does not deduce are never used uninitialized.
5297 (detect_coding_iso_2022): Initialize a local variable that might
5298 be used uninitialized. Leave a FIXME because it's not clear that
5299 this initialization is needed. (Bug#8211)
5300 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5301 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5302 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5303 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5304 Remove unused macros.
5306 * category.c (hash_get_category_set): Remove unused local var.
5307 (copy_category_table): Now static, since it's not used elsewhere.
5308 * character.c (string_count_byte8): Likewise.
5310 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5311 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5313 * chartab.c (copy_sub_char_table): Now static, since it's not used
5315 (sub_char_table_ref_and_range, char_table_ref_and_range):
5316 Rename locals to avoid shadowing.
5317 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5319 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5320 (BIDI_BOB): Remove unused macro.
5322 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5323 deduce are never used uninitialized.
5324 * term.c (encode_terminal_code): Likewise.
5326 * term.c (encode_terminal_code): Now static. Remove unused local.
5328 * tparam.h: New file.
5329 * term.c, tparam.h: Include it.
5330 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5331 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5332 Move these decls to tparam.h, and make them agree with what
5333 is actually in tparam.c. The previous trick of using incompatible
5334 decls in different modules does not conform to the C standard.
5335 All callers of tparam changed to use tparam's actual API.
5336 * tparam.c (tparam1, tparam, tgoto):
5337 Use const pointers where appropriate.
5339 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5340 * cm.h (struct cm): Likewise.
5341 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5342 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5343 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5344 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5345 (turn_on_face, init_tty): Likewise.
5346 * termchar.h (struct tty_display_info): Likewise.
5348 * term.c (term_mouse_position): Rename local to avoid shadowing.
5350 * alloc.c (mark_ttys): Move decl from here ...
5351 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5353 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5355 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5357 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5359 * search.c (compile_pattern_1): Remove argument regp, unused since
5360 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5361 (compile_pattern): Don't pass it.
5363 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5365 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5366 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5368 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5370 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5372 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5373 gdk_window_get_screen, gdk_window_get_geometry,
5374 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5375 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5376 (xg_get_pixbuf_from_pixmap): New function.
5377 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5378 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5379 Call xg_get_pixbuf_from_pixmap instead of
5380 gdk_pixbuf_get_from_drawable.
5381 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5382 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5383 (xg_check_special_colors): Use GtkStyleContext and its functions
5385 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5386 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5387 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5388 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5389 Call gtk_widget_get_preferred_size.
5390 (xg_frame_resized): gdk_window_get_geometry only takes 5
5392 (xg_win_to_widget, xg_event_is_for_menubar):
5393 Call gdk_x11_window_lookup_for_display.
5394 (xg_set_widget_bg): New function.
5395 (delete_cb): New function.
5396 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5397 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5398 (xg_set_background_color): Call xg_set_widget_bg.
5399 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5400 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5401 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5402 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5404 (update_frame_tool_bar): Call gtk_widget_hide.
5405 (xg_initialize): Use GDK_KEY_g.
5407 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5409 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5411 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5412 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5413 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5415 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5417 * w32xfns.c (select_palette): Check success of RealizePalette against
5418 GDI_ERROR, not zero.
5420 See ChangeLog.11 for earlier changes.
5426 Copyright (C) 2011 Free Software Foundation, Inc.
5428 This file is part of GNU Emacs.
5430 GNU Emacs is free software: you can redistribute it and/or modify
5431 it under the terms of the GNU General Public License as published by
5432 the Free Software Foundation, either version 3 of the License, or
5433 (at your option) any later version.
5435 GNU Emacs is distributed in the hope that it will be useful,
5436 but WITHOUT ANY WARRANTY; without even the implied warranty of
5437 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5438 GNU General Public License for more details.
5440 You should have received a copy of the GNU General Public License
5441 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.