1 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3 Support MSVC build with newer versions of Visual Studio.
4 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
8 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9 which are not supported by MSVC.
10 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
11 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
13 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
15 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
17 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
19 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
21 Support MSVC build with newer versions of Visual Studio.
22 * w32.c: Don't include w32api.h for MSVC.
23 (init_environment) [_MSC_VER]: Call sys_access, not _access.
25 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
26 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
27 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
28 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
30 (alloca) [_MSC_VER]: Define to _alloca.
32 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
34 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
36 2011-11-04 Eli Zaretskii <eliz@gnu.org>
38 * xdisp.c (note_mouse_highlight): If either of
39 previous/next-single-property-change returns nil, treat that as
40 the beginning or the end of the buffer. (Bug#9955)
42 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
44 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
45 label is not null (Bug#9951).
46 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
49 2011-11-04 Eli Zaretskii <eliz@gnu.org>
51 * window.c (Fwindow_body_size): Mention in the doc string that the
52 return value is in frame's canonical units. (Bug#9949)
54 2011-11-03 Eli Zaretskii <eliz@gnu.org>
56 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
58 * w32fns.c (unwind_create_frame): If needed, free the glyph
59 matrices of the partially constructed frame. (Bug#9943)
60 * xfns.c (unwind_create_frame): Likewise.
62 2011-11-01 Eli Zaretskii <eliz@gnu.org>
64 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
65 Don't stop backward scan on the continuation glyph, even though
66 its CHARPOS is positive.
67 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
68 cover_string to disp_string.
70 2011-11-01 Martin Rudalics <rudalics@gmx.at>
72 * window.c (temp_output_buffer_show): Don't use
73 Vtemp_buffer_show_specifiers.
74 (Vtemp_buffer_show_specifiers): Remove unused variable.
76 2011-10-30 Eli Zaretskii <eliz@gnu.org>
78 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
79 past the beginning of the current glyph matrix.
81 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
83 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
84 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
87 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
88 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
90 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
92 * xterm.c: Declare x_handle_net_wm_state to return int.
93 (handle_one_xevent): Check if we are iconified but don't have
94 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
95 (get_current_wm_state): Return non-zero if not hidden,
96 check for _NET_WM_STATE_HIDDEN (Bug#9893).
97 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
98 (x_handle_net_wm_state): Return what get_current_wm_state returns.
99 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
101 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
103 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
104 so that this new function doesn't get optimized away by a
105 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
107 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
109 * frame.h (MOUSE_HL_INFO): Remove excess parens.
111 2011-10-29 Eli Zaretskii <eliz@gnu.org>
113 Fix the `xbytecode' command.
114 * .gdbinit (xprintbytestr): New command.
115 (xwhichsymbols): Renamed from `which'; all callers changed.
116 (xbytecode): Print the byte-code string as well.
118 2011-10-29 Kim Storm <storm@cua.dk>
120 * alloc.c (which_symbols): New function.
122 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
124 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
127 2011-10-29 Glenn Morris <rgm@gnu.org>
129 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
130 Not clear what it was for, and it causes various bugs. (Bug#9839)
132 2011-10-28 Eli Zaretskii <eliz@gnu.org>
134 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
135 possible random value that matches one of those tested as
136 condition to clear the mouse face.
138 2011-10-28 Chong Yidong <cyd@gnu.org>
140 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
142 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
144 * window.c (make_window): Initialize phys_cursor_on_p.
146 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
148 * lisp.h (struct Lisp_Symbol): Update comments.
150 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
152 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
154 2011-10-28 Eli Zaretskii <eliz@gnu.org>
156 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
157 <oslsachem@gmail.com> for helping to debug this.
159 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
160 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
161 (g_b_init_get_glyph_outline_w): New static variables.
162 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
163 (GetGlyphOutlineW_Proc): New typedefs.
164 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
165 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
167 (w32font_open_internal, compute_metrics):
168 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
169 instead of calling the "wide" APIs directly.
171 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
173 * w32.h (syms_of_w32font): Add prototype.
175 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
177 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
178 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
179 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
180 (Fmove_to_window_line): Doc fix.
182 2011-10-27 Chong Yidong <cyd@gnu.org>
184 * process.c (make_process): Set gnutls_state to NULL.
186 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
187 non-NULL, regardless of GNUTLS_INITSTAGE.
188 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
189 an error. Set process slots as soon as we allocate them.
191 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
193 2011-10-27 Chong Yidong <cyd@gnu.org>
195 * gnutls.c (emacs_gnutls_deinit): New function.
196 Deallocate credentials structures as well as calling gnutls_deinit.
197 (Fgnutls_deinit, Fgnutls_boot): Use it.
199 * process.c (make_process): Initialize GnuTLS credentials to NULL.
200 (deactivate_process): Call emacs_gnutls_deinit.
202 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
204 * image.c (x_create_x_image_and_pixmap):
205 * w32.c (sys_rename, w32_delayed_load):
206 * w32font.c (fill_in_logfont):
207 * w32reg.c (x_get_string_resource): Silence compiler warnings.
209 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
211 * w32fns.c (w32_default_color_map): New function,
212 extracted from Fw32_default_color_map.
213 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
215 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
217 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
219 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
221 * keyboard.c (test_undefined): New function (bug#9751).
222 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
224 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
226 * sysdep.c (init_sys_modes): Fix the check for the controlling
229 2011-10-20 Eli Zaretskii <eliz@gnu.org>
231 * dispextern.h (struct bidi_it): New member next_en_type.
233 * bidi.c (bidi_line_init): Initialize the next_en_type member.
234 (bidi_resolve_explicit_1): When next_en_pos is valid for the
235 current character, check also for next_en_type being WEAK_EN.
236 (bidi_resolve_weak): Don't enter the expensive loop if the current
237 position is before next_en_pos. Record the bidi type of the first
238 non-ET, non-BN character we find, in addition to its position.
239 (bidi_level_of_next_char): Invalidate next_en_type when
240 next_en_pos is over-stepped.
242 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
244 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
245 * editfns.c: Rewrite current-time-zone so that it invokes
246 the equivalent of (format-time-string "%Z") to get the time zone name.
247 This fixes a bug when the time zone name contains characters that
248 need converting from the system time locale to Emacs internal format.
249 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
250 that patch fixed format-time-string to do the conversion, but
251 I forgot to fix current-time-zone.
252 (format_time_string): New function, containing most of
253 what Fformat_time_string used to contain.
254 (Fformat_time_string): Rewrite in terms of format_time_string.
255 This doesn't change this function's behavior.
256 (current-time-zone): Rewrite to use format_time_string.
257 This fixes the bug reported by Michael Schierl in
258 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
259 Jason Rumney's 2007-06-07 change worked around this bug, but
261 * systime.h (tzname, timezone): Remove no-longer-used declarations.
263 2011-10-19 Eli Zaretskii <eliz@gnu.org>
265 * xdisp.c (start_display): If the character at POS is displayed
266 via a display vector, reset IT->current.dpvec_index to zero.
267 (try_window_reusing_current_matrix): If a line ends in a display
268 vector or the next line starts in a display vector, continue
269 redrawing the window even though the character position of
270 start_row was reached.
273 2011-10-18 Chong Yidong <cyd@gnu.org>
275 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
276 with nobreak-char-display too.
278 2011-10-18 Eli Zaretskii <eliz@gnu.org>
280 Fix part 3 of bug#9771.
281 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
282 (bidi_resolve_neutral): Don't enter the expensive loop looking for
283 non-neutral characters if the current character is a paragraph
284 separator (a.k.a. Newline). This avoids running the same
285 expensive loop twice, once when we consume the preceding newline
286 and the other time when the line actually needs to be displayed.
287 Avoid the loop when we see neutrals on the base embedding level
288 following a character whose directionality is the same as the
289 paragraph's. This avoids running the expensive loop when a line
290 ends in a long sequence of neutrals, like control characters.
291 Add assertion against STRONG_AL type. Slightly rearrange code
292 that determines the type of a neutral given the first non-neutral
294 (bidi_level_of_next_char): Set next_en_pos to zero when
295 invalidating its info.
297 2011-10-17 Eli Zaretskii <eliz@gnu.org>
299 * xdisp.c (push_display_prop): Determine whether to record string
300 or buffer position by IT->string, not by IT->method. Allow
301 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
302 (move_it_vertically_backward): Don't look for character position
303 immediately after the newline when in a continuation line.
306 2011-10-15 Martin Rudalics <rudalics@gmx.at>
308 * window.c (coordinates_in_window): Rewrite and delabelize
309 vertical border check. (Bug#5357) (Bug#9618)
311 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
313 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
314 errors in XSetWindowBorder (bug#9310).
316 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
318 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
319 avoid crash when xmalloc overrun checking is enabled.
321 2011-10-13 Eli Zaretskii <eliz@gnu.org>
323 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
324 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
325 cursor motion with <left> and <right> arrow keys.
327 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
328 some callers set that themselves.
330 2011-10-12 Eli Zaretskii <eliz@gnu.org>
332 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
333 display string and the previous row comes from the same string and
334 is empty. (Bug#9739) (Bug#9738)
336 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
338 * doc.c (get_doc_string): Encode file name (bug#9735).
340 2011-10-12 Eli Zaretskii <eliz@gnu.org>
342 * bidi.c (bidi_level_of_next_char):
343 * xdisp.c (get_visually_first_element): Remove old incorrect
344 comments regarding the Unicode Line Separator character.
346 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
348 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
350 * alloc.c (Fgc_status): Do not access beyond zombies array
351 boundary if nzombies > MAX_ZOMBIES.
352 * alloc.c (dump_zombies): Add missing format specifier.
354 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
356 * xdisp.c (set_cursor_from_row): Simplify conditionals,
357 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
359 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
360 Some packages use them to denote characters with modifiers.
362 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
364 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
365 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
366 matching a pp-number. Rename parameter var to var1.
368 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
370 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
372 2011-10-08 Glenn Morris <rgm@gnu.org>
374 * callint.c (Fcall_interactively): Give a more explicit error for the
375 'c' case with a non-character input. (Bug#8479)
377 2011-10-08 Eli Zaretskii <eliz@gnu.org>
379 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
381 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
382 lines that are hscrolled on the left.
384 * dispnew.c (buffer_posn_from_coords): Account for a possible
385 presence of header-line. (Bug#4426)
387 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
389 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
390 Don't advertise functionality which we discourage or doesn't work.
392 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
394 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
395 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
396 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
397 this makes Emacs dump core during garbage collection on rare
398 occasions. sizeof is obviously inferior to offsetof here, so
400 (GC_POINTER_ALIGNMENT): New macro.
401 (mark_memory): Omit 3rd (offset) arg; caller changed.
402 Don't assume EMACS_INT alignment is the same as pointer alignment.
404 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
406 * keyboard.c (read_key_sequence_remapped): New var.
407 (read_key_sequence): Compute remapping in the right buffer.
408 (command_loop_1): Use read_key_sequence's remapping directly.
410 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
412 * dired.c (file_name_completion): Don't expand file name.
413 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
414 before checking file name handler.
416 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
417 they've been requested explicitly (bug#9591).
419 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
421 * keymap.c (Fsingle_key_description): Use make_specified_string
422 instead of build_string to build string from push_key_description.
425 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
427 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
428 This fixes a Y2038 bug on 64-bit hosts.
429 * buffer.c (reset_buffer):
430 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
431 (Fclear_buffer_auto_save_failure):
432 Use 0, not -1, to represent an unset failure time, since time_t
435 Remove dependency on glibc malloc internals.
436 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
437 Move back here from lisp.h, but with their new implementations.
438 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
439 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
440 * charset.c (charset_table_init): New static var.
441 (syms_of_charset): Use it instead of xmalloc. This removes a
442 dependency on glibc malloc internals. See Eli Zaretskii's comment in
443 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
444 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
445 Move back to alloc.c.
446 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
447 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
449 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
451 * nsterm.m (windowDidResize): Call x_set_window_size only when
452 ns_in_resize is true. Otherwise set pixelwidth/height and
453 call change_frame_size (Bug#9628).
455 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
457 Port --enable-checking=all to Fedora 14 x86-64.
458 * charset.c (syms_of_charset): Also account for glibc malloc's
459 internal overhead when calculating the initial malloc maximum.
461 Port --enable-checking=all to Fedora 14 x86.
462 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
464 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
465 (overrun_check_realloc, overrun_check_free):
466 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
467 That way, xmalloc returns a properly-aligned pointer even if
468 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
469 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
470 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
471 into account when calculating the initial malloc maximum.
472 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
473 Move here from alloc.c, so that charset.c can use it too.
474 Properly align; the old code wasn't right for common 32-bit hosts
475 when configured with --enable-checking=all.
476 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
477 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
479 2011-09-29 Eli Zaretskii <eliz@gnu.org>
481 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
484 2011-09-28 Eli Zaretskii <eliz@gnu.org>
486 * xdisp.c (compute_display_string_end): If there's no display
487 string at CHARPOS, return -1.
489 * bidi.c (bidi_fetch_char): When compute_display_string_end
490 returns a negative value, treat the character as a normal
491 character not covered by a display string. (Bug#9624)
493 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
495 * lread.c (Fread_from_string): Fix typo in docstring.
497 2011-09-27 Eli Zaretskii <eliz@gnu.org>
499 * xdisp.c (handle_invisible_prop): If invisible text ends on a
500 newline, reseat the iterator instead of bidi-iterating there one
501 character at a time. (Bug#9610)
502 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
503 TO_CHARPOS if the bidi iterator is at base embedding level.
505 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
507 * lread.c (readevalloop): Use correct code for NBSP.
508 (read1): Likewise. (Bug#9608)
510 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
512 * dbusbind.c (Fdbus_register_signal): When service is not
513 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
515 2011-09-25 Glenn Morris <rgm@gnu.org>
517 * buffer.c (truncate-lines): Doc fix.
519 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
521 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
522 (Fset_window_next_buffers): Doc fix.
524 2011-09-24 Glenn Morris <rgm@gnu.org>
526 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
528 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
530 Fix minor problems found by static checking.
531 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
532 * indent.c (Fvertical_motion): Fix == vs = typo.
534 2011-09-24 Eli Zaretskii <eliz@gnu.org>
536 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
537 Default value is now t. Doc fix.
539 * indent.c (Fvertical_motion): Compute and apply the overshoot
540 logic when moving up, not only when moving down. Fix the
541 confusing name and values of the it_overshoot_expected variable;
542 logic changes accordingly. (Bug#9254) (Bug#9549)
544 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
545 CHARPOS is covered by a display string which includes newlines.
546 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
547 is covered by a display string with embedded newlines.
549 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
551 * dbusbind.c (Fdbus_register_signal): Add match rule to
552 Vdbus_registered_objects_table. (Bug#9581)
553 (Fdbus_register_method, Vdbus_registered_objects_table):
556 2011-09-24 Jim Meyering <meyering@redhat.com>
558 do not ignore write error for any output size
559 The previous change was incomplete.
560 While it makes emacs --batch detect the vast majority of stdout
561 write failures, errors were still ignored whenever the output size is
562 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
563 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
564 && echo FAIL: ignored write error
565 FAIL: ignored write error
566 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
567 && echo FAIL: ignored write error
568 FAIL: ignored write error
569 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
571 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
573 * emacs.c (Fkill_emacs): In noninteractive mode exit
574 non-successfully if a write error occurred on stdout. (Bug#9574)
576 2011-09-21 Eli Zaretskii <eliz@gnu.org>
578 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
581 * dispextern.h (struct it): Update the comment documenting what
584 2011-09-20 Eli Zaretskii <eliz@gnu.org>
586 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
587 a display string, extend search for cursor position to end of row.
588 (find_row_edges): If the row ends in a newline from a display
589 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
590 Handle the case of a display string with multiple newlines.
591 (Fcurrent_bidi_paragraph_direction): Fix search for previous
592 non-empty line. Fixes confusing cursor motion with arrow keys at
593 the beginning of a line that starts with whitespace.
595 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
597 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
600 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
602 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
605 2011-09-18 Eli Zaretskii <eliz@gnu.org>
607 * xdisp.c (display_line): Record maximum and minimum buffer
608 positions even if no glyphs were produced (e.g., by a zero-width
609 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
610 buffer positions that will be removed from the glyph row because
612 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
613 column is beyond frame width: don't subtract 1 "pixel" when
614 computing width of the stretch.
615 (reseat_at_next_visible_line_start): Undo the change made on
616 2011-09-17 that saved paragraph information and restored it after
617 the call to `reseat'. (Bug#9545)
619 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
621 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
622 and turn window cursor on if cleared (Bug#9415).
624 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
626 * search.c (boyer_moore): Take unibyte characters from pattern
627 literally. (Bug#9458)
629 2011-09-18 Eli Zaretskii <eliz@gnu.org>
631 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
633 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
635 Fix minor problem found by static checking.
636 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
637 initialized, to pacify gcc -Wuninitialized.
639 * fileio.c: Report proper errno when syscall falls.
640 (Finsert_file_contents): Save and restore errno,
641 so that report_file_error outputs the correct diagnostic.
642 (Fwrite_region) [CLASH_DETECTION]: Likewise.
644 2011-09-18 Eli Zaretskii <eliz@gnu.org>
646 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
648 2011-09-17 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
651 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
653 2011-09-17 Eli Zaretskii <eliz@gnu.org>
655 * xdisp.c (reseat_at_next_visible_line_start): Keep information
656 about the current paragraph and restore it after the call to reseat.
658 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
659 (bidi_find_paragraph_start): Search back for paragraph beginning
660 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
661 (bidi_move_to_visually_next): Only trigger paragraph-related
662 computations when the last character is a newline or at EOB, not
663 just any NEUTRAL_B. (Bug#9470)
665 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
666 truncated lines if point is covered by a display string. (Bug#9524)
668 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
670 * xselect.c: Relax test for outgoing X longs (Bug#9498).
671 (cons_to_x_long): New function.
672 (lisp_data_to_selection_data): Use it. Correct the test for
673 short-versus-long data; it was negated. Break out of vector
674 loop, for efficiency, when a long datum is discovered.
676 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
678 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
680 2011-09-16 Eli Zaretskii <eliz@gnu.org>
682 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
683 GCC PR/17406) by declaring this function with external scope.
685 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
687 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
688 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
690 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
692 * editfns.c (Fformat): Correctly handle text properties on "%%".
694 2011-09-15 Eli Zaretskii <eliz@gnu.org>
696 * xterm.c (x_draw_composite_glyph_string_foreground):
697 * w32term.c (x_draw_composite_glyph_string_foreground):
698 * term.c (encode_terminal_code):
699 * composite.c (composition_update_it, get_composition_id):
700 * xdisp.c (get_next_display_element)
701 (fill_composite_glyph_string): Add comments about special meaning
702 of TAB characters in a composition.
704 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
706 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
707 This occurs when processing a multibyte format.
708 Problem reported by Wolfgang Jenker.
710 2011-09-15 Johan Bockgård <bojohan@gnu.org>
712 * xdisp.c (try_cursor_movement): Only check for exact match if
713 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
715 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
717 Remove unused external symbols.
718 * dispextern.h (calc_pixel_width_or_height): Remove decl.
719 * xdisp.c (calc_pixel_width_or_height): Now static.
720 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
721 * indent.c (check_display_width):
722 * w32term.c: Fix comment to match code.
723 * xterm.c, xterm.h (x_catching_errors): Remove.
725 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
727 * xselect.c: Use signed conversions more consistently (Bug#9498).
728 (selection_data_to_lisp_data): Assume incoming selection data are
729 signed integers, not unsigned. This is to be consistent with
730 outgoing selection data, which was modified to use signed integers
731 in as part of the fix to Bug#9196 in response to Jan D.'s comment
732 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
733 expects long, not unsigned long.
735 2011-09-14 Eli Zaretskii <eliz@gnu.org>
737 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
738 computation of loop end. Reported by Johan Bockgård
741 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
743 * frame.c (Fother_visible_frames_p): Function deleted.
745 2011-09-12 Eli Zaretskii <eliz@gnu.org>
747 * indent.c (compute_motion): Process display vector front to back
748 rather than the other way around. (Bug#2496)
750 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
752 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
754 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
756 * minibuf.c (Fread_from_minibuffer): Doc fix.
758 2011-09-11 Eli Zaretskii <eliz@gnu.org>
760 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
761 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
763 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
765 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
766 value for non-existent files.
768 2011-09-11 Eli Zaretskii <eliz@gnu.org>
770 * fileio.c (Finsert_file_contents): If the file cannot be opened,
771 set its "size" to -1. This will set the modtime_size field of
772 the corresponding buffer to -1, which is what
773 verify-visited-file-modtime expects for files that do not exist.
776 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
778 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
780 * lisp.h: ... from here. push_key_description is no longer
781 defined in keyboard.c, so its declaration should not be in
782 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
783 logically belongs with push_key_description.
785 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
787 * buffer.h: Include <sys/types.h> instead of <time.h>.
788 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
789 Problem reported by Herbert J. Skuhra.
791 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
793 * xml.c (parse_region): Make the parsing work for
794 non-comment-starting XML files again (bug#9144).
796 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
798 * image.c (gif_load): Fix calculation of bottom and right corner.
801 2011-09-10 Eli Zaretskii <eliz@gnu.org>
803 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
804 redisplay in small windows.
806 2011-09-09 Eli Zaretskii <eliz@gnu.org>
808 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
810 2011-09-08 Martin Rudalics <rudalics@gmx.at>
812 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
813 Operate on live windows only.
815 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
817 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
819 2011-09-07 Eli Zaretskii <eliz@gnu.org>
821 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
822 only under bidi iteration.
824 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
826 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
828 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
830 isnan: Fix porting problem to Solaris 10 with bundled gcc.
831 Without this fix, the command to link temacs failed due to an
832 undefined symbol __builtin_isnan. This is because
833 /usr/include/iso/math_c99.h #defines isnan(x) to
834 __builtin_isnan(x), but the bundled gcc, which identifies itself
835 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
837 * floatfns.c (isnan): #undef, and then #define to a clone of
839 (Fisnan): Always define, since it's always available now.
840 (syms_of_floatfns): Always define isnan at the Lisp level.
842 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
844 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
846 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
848 * fileio.c: Fix bugs with large file offsets (Bug#9428).
849 The previous code assumed that file offsets (off_t values) fit in
850 EMACS_INT variables, which is not true on typical 32-bit hosts.
851 The code messed up by falsely reporting buffer overflow in cases
852 such as (insert-file-contents "big" nil 1 2) into an empty buffer
853 when "big" contains more than 2**29 bytes, even though this
854 inserts just one byte and does not overflow the buffer.
855 (Finsert_file_contents): Store file offsets as off_t
856 values, not as EMACS_INT values. Check for overflow when
857 converting between EMACS_INT and off_t. When checking for
858 buffer overflow or for overlap, take the offsets into account.
859 Don't use EMACS_INT for small values where int suffices.
860 When checking for overlap, fix a typo: ZV was used where
861 ZV_BYTE was intended.
862 (Fwrite_region): Don't assume off_t fits into 'long'.
863 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
865 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
867 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
869 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
871 sprintf-related integer and memory overflow issues (Bug#9412).
873 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
874 (esprintf, exprintf, evxprintf): New functions.
875 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
876 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
877 (modify_event_symbol): Do not assume that the length of
878 name_alist_or_stem is safe to alloca and fits in int.
879 (Fexecute_extended_command): Likewise for function name and binding.
880 (Frecursion_depth): Wrap around reliably on integer overflow.
881 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
882 since some callers pass EMACS_INT values.
883 (Fsingle_key_description): Don't crash if symbol name contains more
884 than MAX_ALLOCA bytes.
885 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
886 (get_minibuffer): Arg is now EMACS_INT, not int.
887 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
888 (esprintf, exprintf, evxprintf): New decls.
889 * window.h (command_loop_level, minibuf_level): Reflect API changes.
891 * dbusbind.c (signature_cat): New function.
892 (xd_signature, Fdbus_register_signal):
893 Do not overrun buffer; instead, report string overflow.
895 * dispnew.c (add_window_display_history): Don't overrun buffer.
896 Truncate instead; this is OK since it's just a log.
898 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
899 even if the time zone offset is outlandishly large.
900 Don't mishandle offset == INT_MIN.
902 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
903 when creating daemon; the previous buffer-overflow check was incorrect.
905 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
906 which has the guts of the old verror function.
908 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
909 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
911 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
912 (font_unparse_xlfd): Don't blindly alloca long strings.
913 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
914 fits in int, when using sprintf. Use single snprintf to count
915 length of string rather than counting it via multiple sprintfs;
916 that's simpler and more reliable.
917 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
918 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
919 sprintf, in case result does not fit in int.
921 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
922 (fontset_from_font): Print it.
924 * frame.c (tty_frame_count): Now printmax_t, not int.
925 (make_terminal_frame, set_term_frame_name): Print it.
926 (x_report_frame_params): In X, window IDs are unsigned long,
927 not signed long, so print them as unsigned.
928 (validate_x_resource_name): Check for implausibly long names,
929 and don't assume name length fits in 'int'.
930 (x_get_resource_string): Don't blindly alloca invocation name;
931 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
934 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
935 (xg_check_special_colors, xg_set_geometry):
936 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
938 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
939 Use esprintf, not sprintf, in case result does not fit in int.
941 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
942 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
943 it as a large positive number.
944 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
945 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
947 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
948 in case result does not fit in int.
950 * print.c (float_to_string): Detect width overflow more reliably.
951 (print_object): Make sprintf buffer a bit bigger, to avoid potential
952 buffer overrun. Don't assume list length fits in 'int'. Treat
953 print length of 0 as 0, not as infinity; to be consistent with other
954 uses of print length in this function. Don't overflow print length
955 index. Don't assume hash table size fits in 'long', or that
956 vectorlike size fits in 'unsigned long'.
958 * process.c (make_process): Use printmax_t, not int, to format
959 process-name gensyms.
961 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
963 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
964 to avoid potential buffer overrun.
966 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
967 if X resource line is longer than 512 bytes.
969 * xfns.c (x_window): Make sprintf buffer a bit bigger
970 to avoid potential buffer overrun.
972 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
974 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
976 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
978 Integer overflow fixes for scrolling, etc.
979 Without these, Emacs silently mishandles large integers sometimes.
980 For example, "C-u 4294967297 M-x recenter" was treated as if
981 it were "C-u 1 M-x recenter" on a typical 64-bit host.
983 * xdisp.c (try_window_id): Check Emacs fixnum range before
986 * window.c (window_scroll_line_based, Frecenter):
987 Check that an Emacs fixnum is in range before assigning it to 'int'.
988 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
989 values converted from Emacs fixnums.
990 (Frecenter): Don't wrap around a line count if it is out of 'int'
991 range; instead, treat it as an extreme value.
992 (Fset_window_configuration, compare_window_configurations):
993 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
995 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
996 that can exceed INT_MAX. Check that EMACS_INT value is in range
997 before assigning it to the (possibly-narrower) index.
998 (match_limit): Don't assume that a fixnum can fit in 'int'.
1000 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1003 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1004 (Fvertical_motion): Don't wrap around LINES values that don't fit
1005 in 'int'. Instead, treat them as extreme values. This is good
1006 enough for windows, which can't have more than INT_MAX lines anyway.
1008 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1010 * Require libxml/parser.h to avoid compilation warning.
1012 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1014 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1015 since this reportedly can destroy thread storage.
1017 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1019 * syntax.c (find_defun_start): Update all cache variables if
1020 exiting early (Bug#9401).
1022 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1024 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1026 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1027 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1028 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1030 * term.c (tty_append_glyph): New function.
1031 (produce_stretch_glyph): Static function and its prototype deleted.
1033 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1036 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1038 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1039 when checking :margin (Bug#9390).
1040 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1041 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1042 so that the name doesn't mislead. All uses changed.
1044 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1046 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1049 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1051 * xdisp.c (move_it_to): Don't bail out early when reaching
1052 position beyond to_charpos, if we are scanning backwards.
1053 (move_it_vertically_backward): When DY == 0, make sure we get to
1054 the first character in the line after the newline.
1056 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1058 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1059 (ccl_driver): Do not generate an out-of-range pointer.
1060 (Fccl_execute_on_string): Remove unnecessary check for
1061 integer overflow, noted by Stefan Monnier in
1062 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1063 Remove a FIXME that didn't need fixing.
1064 Simplify the newly-introduced buffer reallocation code.
1066 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1068 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1070 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1072 Integer and memory overflow issues (Bug#9196).
1074 * doc.c (get_doc_string): Rework so that
1075 get_doc_string_buffer_size is the actual buffer size, rather than
1076 being 1 less than the actual buffer size; this makes xpalloc more
1079 * image.c (x_allocate_bitmap_record, cache_image):
1080 * xselect.c (Fx_register_dnd_atom):
1081 Simplify previous changes by using xpalloc.
1083 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1084 since either will do and ptrdiff_t is convenient with xpalloc.
1086 * charset.c (charset_table_size)
1087 (struct charset_sort_data.priority): Now ptrdiff_t.
1088 (charset_compare): Don't overflow if priorities differ greatly.
1089 (Fsort_charsets): Don't assume list length fits in int.
1090 Check for size-calculation overflow when allocating sort data.
1091 (syms_of_charset): Allocate an initial charset table that is
1092 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1094 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1096 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1097 The actual value is always <= INT_MAX, and leaving it unsigned made
1098 overflow checking harder.
1100 * dispextern.h (struct glyph_matrix.rows_allocated)
1101 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1102 with xpalloc. The values are still always <= INT_MAX.
1104 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1106 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1107 (SAFE_NALLOCA): New macro.
1109 * region-cache.c (struct boundary.pos, find_cache_boundary)
1110 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1111 (set_cache_region, invalidate_region_cache)
1112 (revalidate_region_cache, know_region_cache, region_cache_forward)
1113 (region_cache_backward, pp_cache):
1114 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1115 so that ptrdiff_t * can be passed to xpalloc.
1116 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1117 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1118 (pp_cache): Don't assume cache_len fits in int.
1119 * region-cache.h: Adjust extern decls to match.
1121 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1122 EMACS_INT, since either will do, for xpalloc.
1124 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1125 (xnmalloc, xnrealloc, xpalloc): New functions.
1127 * bidi.c (bidi_shelve_header_size): New constant.
1128 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1129 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1131 * bidi.c (bidi_cache_shrink):
1132 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1134 Don't update size of array until after memory allocation succeeds,
1135 because xmalloc/xrealloc may not return.
1136 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1137 now that we have proper integer overflow checking.
1138 (record_overlay_string, overlay_strings): Catch overflows when
1139 calculating size of overlay_str_buf.
1141 * callproc.c (Fcall_process): Check for size overflow when
1142 calculating size of args2.
1143 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1144 Normally we prefer signed values, but sticking with ptrdiff_t would
1145 require adding more-complicated checks.
1147 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1148 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1149 Redo buffer-overflow calculations to avoid integer overflow.
1150 Add a FIXME comment where memory seems to be over-allocated.
1152 * character.c (Fstring): Check for size-calculation overflow.
1154 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1155 unnecessary integer overflow. Check for size overflow.
1156 (encode_coding_object): Don't update size until xmalloc succeeds.
1158 * composite.c (get_composition_id): Check for overflow in glyph
1159 length calculations.
1161 Integer and memory overflow fixes for display code.
1162 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1163 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1164 (scrolling_window): Check for overflow in size calculations.
1165 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1166 Don't assume glyph table len fits in int.
1167 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1168 (row_table_size): Now ptrdiff_t, not int.
1169 (scrolling_window): Avoid overflow in size calculations.
1170 Don't update size until allocation succeeds.
1171 * fns.c (concat): Check for overflow in size calculations.
1172 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1173 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1174 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1176 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1177 (get_doc_string): Check for size calculation overflow.
1178 Don't update size until allocation succeeds.
1179 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1180 EMACS_INT, where ptrdiff_t will do.
1181 (Fsubstitute_command_keys): Check for string overflow.
1183 * editfns.c (set_time_zone_rule): Don't assume environment length
1185 (message_length): Now ptrdiff_t, not int.
1186 (Fmessage_box): Don't update size until allocation succeeds.
1187 Don't assume message length fits in int.
1188 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1190 * emacs.c (main): Do not reallocate argv, since there is a null at
1191 the end that can be overwritten, and this way there's no need to
1192 worry about size-calculation overflow.
1193 (sort_args): Check for size-calculation overflow.
1195 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1197 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1199 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1200 (x_set_scroll_bar_width, x_figure_window_size):
1201 Check for integer overflow.
1202 (x_set_alpha): Do not assume XINT fits in int.
1204 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1205 This is for the members text_lines, text_cols, total_lines, total_cols,
1206 where the system imposes an 'int' limit.
1208 * fringe.c (Fdefine_fringe_bitmap):
1209 Don't update size until alloc works.
1211 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1212 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1214 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1215 Check for size-calculation overflow.
1216 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1217 do, as we prefer signed integers.
1218 (id_to_widget.max_size, id_to_widget.used)
1219 (xg_store_widget_in_map, xg_remove_widget_from_map)
1220 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1221 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1222 Use and return ptrdiff_t, not int.
1223 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1224 * gtkutil.h: Change prototypes to match the above.
1226 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1227 are duplicate now that they've been promoted to lisp.h.
1228 (x_allocate_bitmap_record, x_alloc_image_color)
1229 (make_image_cache, cache_image, xpm_load):
1230 Don't update size until alloc is done.
1231 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1233 Check for size calculation overflow.
1234 (ct_colors_allocated_max): New constant.
1235 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1238 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1239 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1240 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1241 Use ptrdiff_t, not int, to count maps.
1242 (read_char_minibuf_menu_prompt): Check for overflow in size
1243 calculations. Don't update size until allocation succeeds.
1244 Redo calculations to avoid overflow.
1245 * keyboard.h: Change prototypes to match the above.
1247 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1249 (current_minor_maps): Check for size calculation overflow.
1250 * keymap.h: Change prototypes to match the above.
1252 * lread.c (read1, init_obarray): Don't update size until alloc done.
1254 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1255 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1257 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1258 Now ptrdiff_t, not int.
1259 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1260 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1262 * process.c (Fnetwork_interface_list): Check for overflow
1263 in size calculation.
1265 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1267 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1268 overflow. Don't bother calling xmalloc when xrealloc will do.
1270 * search.c (Freplace_match): Check for size calculation overflow.
1271 (Fset_match_data): Don't assume list lengths fit in 'int'.
1273 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1274 for command line length. Do not attempt to address one before the
1275 beginning of an array, as that's not portable.
1277 * term.c (max_frame_lines): Remove; unused.
1278 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1280 (encode_terminal_code, calculate_costs): Check for size
1281 calculation overflow.
1282 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1283 table lengths and related sizes. Don't update size until alloc
1284 done. Redo calculations to avoid overflow.
1285 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1287 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1288 subtracting pointers.
1289 (gobble_line): Check for overflow more carefully. Don't update size
1292 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1293 Don't update size until alloc done.
1294 Redo size calculations to avoid overflow.
1295 Check for size calculation overflow.
1296 (main) [DEBUG]: Fix typo in invoking tparam1.
1298 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1299 Use ptrdiff_t, not int, for sizes.
1300 (store_mode_line_noprop_char): Don't update size until alloc done.
1302 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1303 Use ptrdiff_t, not int, for sizes.
1304 (Finternal_make_lisp_face, cache_face):
1305 Check for size calculation overflow.
1306 (cache_face): Treat size calculation overflows as if they were
1307 memory exhaustion (the usual treatment), rather than aborting.
1309 * xfns.c (x_encode_text, x_set_name_internal)
1310 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1311 sizes, since they can exceed INT_MAX in size. Check for size
1312 calculation overflow.
1314 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1315 (xg_select): Check for size calculation overflow.
1316 Don't update size until alloc done.
1318 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1319 as sprintf is limited to int lengths.
1321 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1322 (X_LONG_MIN): New macros.
1323 Use them to make the following changes clearer.
1324 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1325 This change doesn't affect the value now, but it may help remind
1326 future maintainers not to raise the value too much later.
1327 (SELECTION_QUANTUM): Remove, replacing with ...
1328 (selection_quantum): ... new function, which avoids overflow.
1330 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1331 assumption that selection length fits in 'int'.
1332 (x_reply_selection_request, x_handle_selection_request)
1333 (x_get_window_property, receive_incremental_selection)
1334 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1335 (lisp_data_to_selection_data, clean_local_selection_data):
1336 Use ptrdiff_t, not int, to record length of selection.
1337 (x_reply_selection_request, x_get_window_property)
1338 (receive_incremental_selection, x_property_data_to_lisp):
1339 Redo calculations to avoid overflow.
1340 (x_reply_selection_request): When sending hint, ceiling it at
1341 X_LONG_MAX rather than relying on wraparound overflow to send
1343 (x_get_window_property, receive_incremental_selection)
1344 (lisp_data_to_selection_data, x_property_data_to_lisp):
1345 Check for size-calculation overflow.
1346 (x_get_window_property, receive_incremental_selection)
1347 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1348 Don't store size until memory allocation succeeds.
1349 (x_get_window_property): Plug memory leak on memory exhaustion.
1350 Don't double-block input; malloc is safe here. Don't assume 2**34
1351 - 4 fits in unsigned long. Add an xassert to check
1352 XGetWindowProperty overflow. Be more careful about overflow
1353 calculations, and distinguish size from memory overflow better.
1354 (receive_incremental_selection): When tracing, don't assume
1355 unsigned int is less than INT_MAX.
1356 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1357 harmful) conversions of unsigned short to int.
1358 (lisp_data_to_selection_data): Don't assume that integers
1359 in the range -65535 through -1 fit in an X unsigned short.
1360 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1361 result parameters unless successful. Rely on cons_to_unsigned
1362 to report problems with elements; the old code wasn't right anyway.
1363 (x_check_property_data): Check for int overflow; we cannot use
1364 a wider type due to X limits.
1365 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1367 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1369 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1370 (x_term_init): Check for size calculation overflow.
1371 (x_color_cells): Don't store size until memory allocation succeeds.
1372 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1373 Don't assume alloca size is less than MAX_ALLOCA.
1374 (x_term_init): Don't assume length fits in int (sprintf is limited
1377 Use ptrdiff_t for composition IDs.
1378 * character.c (lisp_string_width):
1379 * composite.c (composition_table_size, n_compositions)
1380 (get_composition_id, composition_gstring_from_id):
1381 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1382 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1383 * window.c (Frecenter):
1384 Use ptrdiff_t, not int, for composition IDs.
1385 * composite.c (get_composition_id): Check for integer overflow.
1386 * composite.h: Adjust prototypes to match the above changes.
1388 Use ptrdiff_t for hash table indexes.
1389 * category.c (hash_get_category_set):
1390 * ccl.c (ccl_driver):
1391 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1392 * coding.c (coding_system_charset_list, detect_coding_system):
1393 * coding.h (struct coding_system.id):
1394 * composite.c (get_composition_id, gstring_lookup_cache):
1395 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1396 * image.c (xpm_get_color_table_h):
1397 * lisp.h (hash_lookup, hash_put):
1398 * minibuf.c (Ftest_completion):
1399 Use ptrdiff_t for hash table indexes, not int (which is too
1400 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1401 32-bit --with-wide-int hosts).
1403 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1404 Add a FIXME comment about memory leaks.
1405 (syms_of_charset): Don't assume xmalloc returns.
1407 Don't assume that stated character widths fit in int.
1408 * character.c (Fchar_width, c_string_width, lisp_string_width):
1409 * character.h (CHAR_WIDTH):
1410 * indent.c (MULTIBYTE_BYTES_WIDTH):
1411 Use sanitize_char_width to avoid undefined and/or bad behavior
1412 with outlandish widths.
1413 * character.h (sanitize_tab_width): Rename from sanitize_width,
1414 now that we have two such functions. All uses changed.
1415 (sanitize_char_width): New inline function.
1417 Don't assume that tab-width fits in int.
1418 * character.h (sanitize_width): New inline function.
1419 (SANE_TAB_WIDTH): New macro.
1420 (ASCII_CHAR_WIDTH): Use it.
1421 * indent.c (sane_tab_width): Remove. All uses replaced by
1422 SANE_TAB_WIDTH (current_buffer).
1423 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1425 * fileio.c: Integer overflow issues with file modes.
1426 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1428 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1429 Remove unreachable code.
1430 (read_hex, load_charset_map_from_file): Check for integer overflow.
1432 * xterm.c: don't go over XClientMessageEvent limit
1433 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1434 (x_send_scroll_bar_event): Likewise. Check that the size does not
1435 exceed limits imposed by XClientMessageEvent, as well as the usual
1436 ptrdiff_t and size_t limits.
1438 * keyboard.c: Overflow, signedness and related fixes.
1439 (make_lispy_movement): Use same integer type in forward decl
1440 that is used in the definition.
1441 (read_key_sequence, keyremap_step):
1442 Change bufsize argument back to int, undoing my 2011-03-30 change.
1443 We prefer signed types, and int is wide enough here.
1444 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1445 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1446 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1447 length, not size_t. Use ptrdiff_t for index, not int.
1448 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1449 possibility of integer overflow.
1451 Overflow, signedness and related fixes for images.
1453 * dispextern.h (struct it.stack[0].u.image.image_id)
1454 (struct_it.image_id, struct image.id, struct image_cache.size)
1455 (struct image_cache.used, struct image_cache.ref_count):
1456 * gtkutil.c (update_frame_tool_bar):
1457 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1458 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1459 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1460 * nsmenu.m (update_frame_tool_bar):
1461 * xdisp.c (calc_pixel_width_or_height):
1462 * xfns.c (image_cache_refcount):
1463 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1464 on typical 64-bit hosts.
1466 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1467 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1468 Omit unnecessary casts to int.
1469 (parse_image_spec): Check that integers fall into 'int' range
1470 when the callers expect that.
1471 (image_ascent): Redo ascent calculation to avoid int overflow.
1472 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1473 (lookup_image): Remove unnecessary tests.
1474 (xbm_image_p): Locals are now of int, not EMACS_INT,
1475 since parse_image_check makes sure they fit into int.
1476 (png_load, gif_load, svg_load_image):
1477 Prefer int to unsigned where either will do.
1478 (tiff_handler): New function, combining the cores of the
1479 old tiff_error_handler and tiff_warning_handler.
1480 This function is rewritten to use vsnprintf and thereby avoid
1481 stack buffer overflows. It uses only the features of vsnprintf
1482 that are common to both POSIX and native Microsoft.
1483 (tiff_error_handler, tiff_warning_handler): Use it.
1484 (tiff_load, gif_load, imagemagick_load_image):
1485 Don't assume :index value fits in 'int'.
1486 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1487 (imagemagick_load_image): Check that crop parameters fit into
1488 the integer types that MagickCropImage accepts. Don't assume
1489 Vimagemagick_render_type has a nonnegative value. Don't assume
1490 size_t fits in 'long'.
1491 (gs_load): Use printmax_t to print the widest integers possible.
1492 Check for integer overflow when computing image height and width.
1494 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1496 * xdisp.c (redisplay_window): Don't force window start if point
1497 will be invisible in the resulting window. (Bug#9324)
1499 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1501 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1502 the display spec is of the form `(space ...)'.
1503 (handle_display_spec): Return the value returned by
1504 handle_single_display_spec, not just 1 or zero.
1505 (handle_single_display_spec): If the display spec is of the form
1506 `(space ...)', and specifies display in the text area, return 2
1508 (try_cursor_movement): Check for the need to scroll more
1509 accurately, and prefer exact match for point under bidi.
1510 Don't advance `row' beyond the last row of the window.
1512 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1513 into disp_prop; all users changed.
1515 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1516 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1517 for the text covered by the display property.
1519 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1521 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1522 Change return value to nil.
1523 (Frecord_buffer): Delete unused function.
1525 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1527 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1528 buffers, return left-to-right.
1529 (set_cursor_from_row): Consider candidate row a win if its glyph
1530 represents a newline and point is on that newline. Fixes cursor
1531 positioning on the newline at EOL of R2L text within L2R
1532 paragraph, and vice versa.
1533 (try_cursor_movement): Check continued rows, in addition to
1534 continuation rows. Fixes unwarranted scroll when point enters a
1535 continued line of R2L text within an L2R paragraph, or vice versa.
1536 (cursor_row_p): Consider the case of point being equal to
1537 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1538 from the end of a short line to the beginning of a continued line
1539 of R2L text within L2R paragraph.
1540 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1541 composed characters.
1543 * bidi.c (bidi_check_type): Use xassert.
1544 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1547 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1549 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1552 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1554 * nsfont.m (ns_otf_to_script): Fix typo.
1556 2011-08-22 Kenichi Handa <handa@m17n.org>
1558 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1559 extra slot even if the purpose is char-code-property-table.
1561 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1563 * xdisp.c (redisplay_window): When computing centering_position,
1564 account for the height of the header line. (Bug#8874)
1566 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1567 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1568 candidate is selected by the mouse, and that candidate has a
1569 composed character under the mouse.
1571 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1572 coordinates reported by pos-visible-in-window-p for a composed
1573 character in column zero.
1575 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1577 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1579 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1581 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1582 consider it a hit if to_charpos is anywhere in the range of the
1583 composed buffer positions.
1585 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1587 * image.c (gif_load): Don't assume that each subimage has the same
1588 dimensions as the base image. Handle disposal method that is
1589 "undefined" by the gif spec (Bug#9335).
1591 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1593 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1594 (Fcondition_case): Document `debug' symbol in error handler.
1596 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1598 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1599 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1600 from an Org mode buffer to a Speedbar frame.
1602 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1603 a composition, take its buffer position from IT->cmp_it.charpos.
1604 Fixes cursor positioning at the beginning of a line that begins
1605 with a composed character.
1607 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1609 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1610 character bidirectional type, use STRONG_L instead. Fixes crashes
1611 in a buffer produced by `describe-categories'.
1613 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1614 members before the level stack, so they would be saved and
1615 restored when copying iterator state. Fixes incorrect reordering
1616 around TABs covered by display properties.
1618 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1620 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1622 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1624 * eval.c (internal_condition_case, internal_condition_case_1)
1625 (internal_condition_case_2, internal_condition_case_n):
1626 Remove unnecessary aborts (Bug#9081).
1628 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1630 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1631 has no `load' handler, try opening the file locally. (Bug#9311)
1633 2011-08-16 Ken Brown <kbrown@cornell.edu>
1635 * gmalloc.c: Expand comment.
1637 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1639 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1640 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1642 2011-08-16 Ken Brown <kbrown@cornell.edu>
1644 Fix memory allocation problems in Cygwin build (Bug#9273).
1646 * unexcw.c ( __malloc_initialized): Declare external variable.
1647 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1649 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1651 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1653 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1655 [CYGWIN] (special_realloc): New function.
1656 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1657 requests to realloc storage in the static heap.
1659 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1661 * bidi.c (bidi_initialize): Remove unused local.
1663 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1666 * biditype.h: Remove file.
1667 * makefile.w32-in ($(BLD)/bidi.$(O)):
1668 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1670 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1672 * chartab.c: Improve commentary for the uniprop_table API.
1674 * bidi.c (bidi_paragraph_init): Support zero value of
1675 bidi_ignore_explicit_marks_for_paragraph_level.
1676 (bidi_initialize): Use uniprop_table instead of including
1677 biditype.h and bidimirror.h.
1679 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1680 coordinates of the iterator when restoring from ppos_it.
1683 2011-08-14 Kenichi Handa <handa@m17n.org>
1685 * process.c (create_process): Call setup_process_coding_systems
1686 after the pid of the process is set to -1 (Bug#8162).
1688 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1690 * xdisp.c (move_it_in_display_line_to): Don't invoke
1691 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1692 ppos_it. Fixes vertical cursor motion when line beginning is
1693 covered by an image. (Bug#9296)
1695 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1697 * nsterm.h (ns_run_ascript): Declare.
1698 (NSAPP_DATA2_RUNASSCRIPT): Define.
1700 * nsfns.m (as_script, as_result, as_status): New static variables.
1701 (ns_run_ascript): New function.
1702 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1703 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1704 the event loop. Get status from as_status (Bug#7276).
1706 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1707 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1708 the event loop (Bug#7276).
1710 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1712 * gnutls.c (QCgnutls_bootprop_priority)
1713 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1714 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1715 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1716 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1717 (QCgnutls_bootprop_verify_hostname_error)
1718 (QCgnutls_bootprop_callbacks_verify): Rename from
1719 Qgnutls_bootprop_..., all uses changed.
1721 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1724 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1726 * xfaces.c (Qframe_set_background_mode): Now static.
1727 * dispextern.h (Qframe_set_background_mode): Remove decl.
1729 * process.c (Fnetwork_interface_info): Declare local only if needed.
1731 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1733 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1734 (Fnetwork_interface_list): Allocate in increments of bytes instead
1735 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1736 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1738 (struct ifflag_def): notrailers is smart on OSX.
1739 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1740 Get hardware address with getifaddrs if available.
1742 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1744 * xdisp.c (iterate_out_of_display_property): xassert that
1745 IT->position is set to within IT->object's boundaries. Break from
1746 the loop as soon as EOB is reached; avoids infloops in redisplay
1747 when IT->position is set up wrongly due to some bug.
1748 Set IT->current to match the bidi iterator unconditionally.
1749 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1750 entry. Force push_it to save on the stack the current
1751 buffer/string position, to be restored by pop_it. Fix flags in
1752 the iterator structure wrt the object coming from a display
1753 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1754 properties. (Bug#9284)
1756 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1758 * fontset.c (fontset_get_font_group): Add proper type checks.
1761 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1763 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1764 and LC_VERSION_MIN_MACOSX.
1765 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1766 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1768 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1770 * xdisp.c (forward_to_next_line_start): Allow to use the
1771 no-display-properties-and-no-overlays under bidi display.
1772 Set disp_pos in the bidi iterator to avoid searches for display
1773 properties and overlays.
1775 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1777 * editfns.c (Fset_time_zone_rule): Document relationship with the
1780 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1781 the font entity extracted from the cache (Bug#8109).
1783 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1785 * composite.c (autocmp_chars): Don't reset point. That is done by
1786 restore_point_unwind (Bug#5984).
1788 2011-08-07 Juri Linkov <juri@jurta.org>
1790 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1791 to show the arg `TIME' instead of `TIMEVAL'.
1793 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1795 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1796 display property strides EOL and includes a newline, as in
1797 longlines-mode. (Bug#9254)
1798 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1799 word-wrap under bidirectional display. (Bug#9224)
1801 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1802 is non-zero, even if the data buffer is NULL. Fixes a crash in
1803 vertical-motion with longlines-mode. (Bug#9254)
1805 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1807 * bidi.c <bidi_cache_total_alloc>: Now static.
1808 (bidi_initialize): Initialize bidi_cache_total_alloc.
1810 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1813 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1814 amount allocated this far in `bidi_cache_total_alloc'.
1815 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1816 non-zero, only free the data buffer without restoring the cache
1817 contents. All callers changed.
1819 * dispextern.h (bidi_unshelve_cache): Update prototype.
1821 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1822 (move_it_in_display_line, move_it_to)
1823 (move_it_vertically_backward, move_it_by_lines): Replace the call
1824 to xfree to an equivalent call to bidi_unshelve_cache.
1825 (move_it_in_display_line_to): Fix logic of returning
1826 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1828 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1831 came from a string character with a `cursor' property. (Bug#9229)
1833 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1835 * Makefile.in (LIB_PTHREAD): New variable.
1836 (LIBES): Add LIB_PTHREAD (Bug#9216).
1838 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1839 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1841 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1843 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1845 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1847 * xterm.c (x_find_topmost_parent): New function.
1848 (x_set_frame_alpha): Find topmost parent window with
1849 x_find_topmost_parent and set the property there also (bug#9181).
1850 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1852 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1854 * callproc.c (Fcall_process): Avoid vfork clobbering
1855 the local vars buffer, coding_systems, current_dir.
1857 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1859 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1861 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1863 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1864 so that it is not optimized away.
1866 * xdisp.c (compute_display_string_pos): Remove unused local.
1868 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1870 Fix slow cursor motion and scrolling in large buffers with
1871 selective display, like Org Mode buffers. (Bug#9218)
1873 * dispextern.h (struct bidi_it): New member disp_prop_p.
1875 * xdisp.c: Remove one-slot cache of display string positions.
1876 (compute_display_string_pos): Accept an additional argument
1877 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1878 for a display string or property. If found, set DISP_PROP_P
1881 * bidi.c (bidi_fetch_char): Accept an additional argument
1882 DISP_PROP_P, and pass it to compute_display_string_pos.
1883 Only handle text covered by a display string if DISP_PROP_P is returned
1884 non-zero. All callers of bidi_fetch_char changed.
1886 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1888 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1890 2010-12-03 Don March <don@ohspite.net>
1892 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1893 last character M-[char] is translated to ESC [char] (bug#7541).
1895 2011-08-02 Kenichi Handa <handa@m17n.org>
1897 * lisp.h (uniprop_table): Extern it.
1899 * chartab.c (uniprop_table): Make it non-static.
1901 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1903 * xdisp.c (forward_to_next_line_start): Accept additional argument
1904 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1906 (reseat_at_next_visible_line_start): Use the bidi iterator state
1907 returned by forward_to_next_line_start to restore the state of
1908 it->bidi_it after backing up to previous newline. (Bug#9212)
1910 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1912 * regex.c (re_comp): Protoize.
1913 (re_exec): Fix return type.
1914 (regexec): Fix type of `ret'. (Bug#9203)
1916 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1918 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1919 This is needed if max-image-size is a floating-point number.
1921 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1923 * print.c (print_object): Print empty symbol as ##.
1925 * lread.c (read1): Read ## as empty symbol.
1927 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1929 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1930 setting frame foreground color (Bug#9175).
1931 (x_set_background_color): Likewise.
1933 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1934 contents (Bug#9176).
1935 (EmacsTooltip -init): Remove bezels and add shadows to
1938 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1939 or scroll bar (Bug#8470).
1941 * nsfont.m (nsfont_open): Remove assignment to voffset and
1942 unnecessary vars hshink, expand, hd, full_height, min_height.
1943 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1945 * nsterm.h (nsfont_info): Remove voffset field.
1947 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1949 Implement strike-through and overline on NextStep (Bug#8863).
1951 * nsfont.m (nsfont_open): Use underline position provided by font,
1952 instead of hard-coded value of 2.
1953 (nsfont_draw): Call ns_draw_text_decoration instead.
1955 * nsterm.h: Add declaration for ns_draw_text_decoration.
1957 * nsterm.m (ns_draw_text_decoration): New function for drawing
1958 underline, overline, and strike-through.
1959 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1960 ns_draw_text_decoration. Change treatment of cursor drawing to
1961 accommodate underlining, etc.
1963 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1965 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1968 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1970 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1971 Without this fix, if a signal arrives just after memory fills up,
1972 'malloc' might be invoked reentrantly.
1974 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1975 In other words, assume that every image size is allowed, on non-X
1976 hosts. This assumption is probably wrong, but it lets Emacs compile.
1978 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1980 * regex.c (re_iswctype): Convert return values to boolean.
1982 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1984 * xdisp.c (compute_display_string_pos): Don't use cached display
1985 string position if the buffer had its restriction changed.
1988 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1990 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1992 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1994 Integer signedness and overflow and related fixes. (Bug#9079)
1996 * bidi.c: Integer size and overflow fixes.
1997 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1998 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1999 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2000 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2001 (bidi_find_other_level_edge):
2002 Use ptrdiff_t instead of EMACS_INT where either will do.
2003 This works better on 32-bit hosts configured --with-wide-int.
2004 (bidi_cache_ensure_space): Check for size-calculation overflow.
2005 Use % rather than repeated addition, for better worst-case speed.
2006 Don't set bidi_cache_size until after xrealloc returns, because it
2008 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2009 (bidi_cache_ensure_space): Also check that the bidi cache size
2010 does not exceed that of the largest Lisp string or buffer. See Eli
2011 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2013 * alloc.c (__malloc_size_t): Remove.
2014 All uses replaced by size_t. See Andreas Schwab's note
2015 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2017 * image.c: Improve checking for integer overflow.
2018 (check_image_size): Assume that f is nonnull, since
2019 it is always nonnull in practice. This is one less thing to
2020 worry about when checking for integer overflow later.
2021 (x_check_image_size): New function, which checks for integer
2022 overflow issues inside X.
2023 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2024 This removes the need for a memory_full check.
2025 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2026 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2027 (xbm_read_bitmap_data): Change locals back to 'int', since
2028 their values must fit in 'int'.
2029 (xpm_load_image, png_load, tiff_load):
2030 Invoke x_create_x_image_and_pixmap earlier,
2031 to avoid much needless work if the image is too large.
2032 (tiff_load): Treat overly large images as if
2033 x_create_x_image_and_pixmap failed, not as malloc failures.
2034 (gs_load): Use x_check_image_size.
2036 * gtkutil.c: Omit integer casts.
2037 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2038 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2040 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2042 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2043 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2044 would wrongly return t on a 64-bit host.
2046 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2047 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2048 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2049 and therefore cause GCC to emit a bogus diagnostic in some cases.
2051 * image.c: Integer signedness and overflow and related fixes.
2052 This is not an exhaustive set of fixes, but it's time to
2053 record what I've got.
2054 (lookup_pixel_color, check_image_size): Remove redundant decls.
2055 (check_image_size): Don't assume that arbitrary EMACS_INT values
2056 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2057 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2058 (tiff_load, imagemagick_load_image):
2059 Check for overflow in size calculations.
2060 (x_create_x_image_and_pixmap): Remove unnecessary test for
2061 xmalloc returning NULL; that can't happen.
2062 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2063 (xpm_color_bucket): Use better integer hashing function.
2064 (xpm_cache_color): Don't possibly over-allocate memory.
2065 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2066 (gif_memory_source):
2067 Use ptrdiff_t, not int or size_t, to record sizes.
2068 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2069 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2070 either works, as we prefer signed integers.
2071 (tiff_read_from_memory, tiff_write_from_memory):
2072 Return tsize_t, not size_t, since that's what the TIFF API wants.
2073 (tiff_read_from_memory): Don't fail simply because the read would
2074 go past EOF; instead, return a short read.
2075 (tiff_load): Omit no-longer-needed casts.
2076 (Fimagemagick_types): Don't assume size fits into 'int'.
2078 Improve hashing quality when configured --with-wide-int.
2079 * fns.c (hash_string): New function, taken from sxhash_string.
2080 Do not discard information about ASCII character case; this
2081 discarding is no longer needed.
2082 (sxhash-string): Use it. Change sig to match it. Caller changed.
2083 * lisp.h: Declare it.
2084 * lread.c (hash_string): Remove, since we now use fns.c's version.
2085 The fns.c version returns a wider integer if --with-wide-int is
2086 specified, so this should help the quality of the hashing a bit.
2088 * emacs.c: Integer overflow minor fix.
2089 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2090 Define only if GNU_LINUX.
2091 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2093 * dispnew.c: Integer signedness and overflow fixes.
2094 Remove unnecessary forward decls, that were a maintenance hassle.
2095 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2097 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2098 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2099 (prepare_desired_row, line_draw_cost):
2100 Use int, not unsigned, where either works.
2101 (save_current_matrix, restore_current_matrix):
2102 Use ptrdiff_t, not size_t, where either works.
2103 (init_display): Check for overflow more accurately, and without
2104 relying on undefined behavior.
2106 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2107 Remove, replacing with the new symbols in lisp.h. All uses changed.
2108 * fileio.c (make_temp_name):
2109 * filelock.c (lock_file_1, lock_file):
2110 * xdisp.c (message_dolog):
2111 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2112 Use pMd etc. instead.
2113 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2114 replacing the pWIDE etc. symbols removed from editfns.c.
2116 * keyboard.h (num_input_events): Now uintmax_t.
2117 This is (very slightly) less likely to mess up due to wraparound.
2120 * buffer.c: Integer signedness fixes.
2121 (alloc_buffer_text, enlarge_buffer_text):
2122 Use ptrdiff_t rather than size_t when either will do, as we prefer
2125 * alloc.c: Integer signedness and overflow fixes.
2126 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2127 (__malloc_size_t): Default to size_t, not to int.
2128 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2129 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2130 Prefer ptrdiff_t to size_t when either would do, as we prefer
2132 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2133 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2134 Now const. Initialize with values that are in range even if char
2136 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2137 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2138 These functions do the right thing with sizes > 2**32.
2139 (check_depth): Now ptrdiff_t, not int.
2140 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2141 Adjust to new way of storing sizes. Check for size overflow bugs
2143 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2144 slightly wrong anyway, as it missed one instance of
2145 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2146 (refill_memory_reserve): Omit needless cast to size_t.
2147 (mark_object_loop_halt): Mark as externally visible.
2149 * xselect.c: Integer signedness and overflow fixes.
2150 (Fx_register_dnd_atom, x_handle_dnd_message):
2151 Use ptrdiff_t, not size_t, since we prefer signed.
2152 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2153 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2154 x_dnd_atoms_size and x_dnd_atoms_length.
2156 * doprnt.c: Prefer signed to unsigned when either works.
2158 * doprnt.c (doprnt):
2160 * xdisp.c (vmessage):
2161 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2162 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2163 prefer signed arithmetic to avoid comparison confusion.
2164 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2165 but is a bit tricky.
2167 Assume freestanding C89 headers, string.h, stdlib.h.
2168 * data.c, doprnt.c, floatfns.c, print.c:
2169 Include float.h unconditionally.
2170 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2171 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2172 * regex.c: Likewise for stddef.h, string.h.
2173 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2174 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2175 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2176 (STDC_HEADERS): Remove obsolete defines.
2177 * sysdep.c: Include limits.h unconditionally.
2179 Assume support for memcmp, memcpy, memmove, memset.
2180 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2181 * regex.c (memcmp, memcpy):
2182 Remove; we assume C89 now.
2184 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2185 (__malloc_safe_bcopy): Remove; no longer needed.
2187 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2188 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2189 well either way, and we prefer signed to unsigned.
2191 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2193 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2194 closes the connection while we're reading (bug#9182).
2196 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2198 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2199 are specified (Bug#9168).
2201 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2203 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2204 Found by GCC static checking and --with-wide-int on a 32-bit host.
2206 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2208 * xdisp.c (compute_display_string_pos): Fix logic of caching
2209 previous display string position. Initialize cached_prev_pos to
2210 -1. Fixes slow-down at the beginning of a buffer.
2212 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2214 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2215 for attrs[LFACE_FONTSET_INDEX].
2217 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2219 * xml.c (parse_region): Remove unused local
2220 that was recently introduced.
2222 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2224 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2225 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2227 * xdisp.c (move_it_in_display_line_to): Record the best matching
2228 position for TO_CHARPOS while scanning the line, and restore it on
2229 exit if none of the characters scanned was an exact match.
2230 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2231 when exact match is impossible due to invisible text, and the
2232 lines are truncated.
2234 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2236 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2239 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2241 Fix a significant slow-down of cursor motion with C-n, C-p,
2242 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2243 auto-repeat under bidi redisplay in fontified buffers.
2244 * xdisp.c (compute_stop_pos_backwards): New function.
2245 (next_element_from_buffer): Call compute_stop_pos_backwards to
2246 find a suitable prev_stop when we find ourselves before
2248 (reseat): Don't look for prev_stop, as that could mean a very long
2250 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2251 <cached_disp_overlay_modiff>: Cache for last found display string
2253 (compute_display_string_pos): Return the cached position if asked
2254 about the same buffer in the same area of character positions, and
2255 the buffer wasn't changed since the time the display string
2256 position was cached.
2258 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2261 is an integer, which is important for empty lines. (Bug#9149)
2263 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2265 * frame.c (Fmodify_frame_parameters): In tty case, update the
2266 default face if necessary (Bug#4238).
2268 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2270 * editfns.c (Fstring_to_char): No need to explain what a character
2271 is in the docstring (Bug#6576).
2273 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2275 * xml.c (parse_region): Make sure we always return a tree.
2277 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2279 * xml.c (parse_region): If a document contains only comments,
2282 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2284 * xml.c (make_dom): Return comments, too.
2286 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2289 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2290 and the surrounding thread.
2291 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2292 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2293 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2295 * s/openbsd.h (BROKEN_SIGIO): Define.
2296 * unexelf.c (unexec) [__OpenBSD__]:
2297 Don't update the .mdebug section of the Alpha COFF symbol table.
2299 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2301 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2304 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2306 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2307 This fixes some race conditions on the permissions of any newly
2310 * alloc.c (valid_pointer_p): Use pipe, not open.
2311 This fixes some permissions issues when debugging.
2313 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2314 If fchown fails to set both uid and gid, try to set just gid,
2315 as that is sometimes allowed. Adjust the file's mode to eliminate
2316 setuid or setgid bits that are inappropriate if fchown fails.
2318 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2320 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2321 to compare Lisp_Objects.
2322 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2323 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2324 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2326 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2328 * lread.c (read_integer): Unread even EOF character.
2329 (read1): Likewise. Properly record start position of symbol.
2331 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2332 symbol character follows.
2334 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2336 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2337 This works around a problem with the previous change to Fcopy_file.
2338 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2339 and without this change, GCC might complain about discarding
2340 fchown's return value.
2342 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2344 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2346 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2348 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2350 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2352 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2353 it's used from the C level.
2355 * process.c: Use the same condition for POLL_FOR_INPUT in both
2356 keyboard.c and process.c (bug#1858).
2358 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2360 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2361 (Fgnutls_boot): Use it.
2363 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2365 * doc.c (Fsubstitute_command_keys): Revert last change.
2367 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2369 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2370 quotes the next character, and doesn't affect other longer
2371 sequences (bug#8935).
2373 * lread.c (syms_of_lread): Clarify that is isn't only
2374 `eval-buffer' and `eval-defun' that's affected by
2375 `lexical-binding' (bug#8460).
2377 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2379 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2380 bidi redisplay when a line includes both an image and is truncated.
2382 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2384 Fix minor problems found by static checking.
2385 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2386 (elsz): Now a signed constant, not a size_t var. We prefer signed
2387 types to unsigned, to avoid integer comparison confusion. Without
2388 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2389 "cannot optimize loop, the loop counter may overflow", a symptom
2391 * indent.c (Fvertical_motion): Mark locals as initialized.
2392 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2394 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2396 * search.c (Fre_search_backward): Mention `case-fold-search' in
2397 all the re_search_* functions (bug#8138).
2399 * keyboard.c (Fopen_dribble_file): Document when the file is
2402 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2404 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2407 Support bidi reordering of display and overlay strings.
2408 * xdisp.c (compute_display_string_pos)
2409 (compute_display_string_end): Accept additional argument STRING.
2410 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2411 (reseat_to_string): Initialize bidi_it->string.s and
2412 bidi_it->string.schars.
2413 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2414 NULL (avoids a crash in bidi_paragraph_init).
2415 Initialize itb.string.lstring.
2416 (init_iterator): Call bidi_init_it only of a valid
2417 buffer position was specified. Initialize paragraph_embedding to
2419 (reseat_to_string): Initialize the bidi iterator.
2420 (display_string): If we need to ignore text properties of
2421 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2422 original value of -1 will not work with bidi.)
2423 (compute_display_string_pos): First arg is now struct
2424 `text_pos *'; all callers changed. Support display properties on
2426 (compute_display_string_end): Support display properties on Lisp
2428 (init_iterator, reseat_1, reseat_to_string): Initialize the
2429 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2430 when iterating on a string not from display properties).
2431 (compute_display_string_pos, compute_display_string_end):
2432 Fix calculation of the object to scan. Fixes an error when using
2434 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2435 base_level_stop; instead, set base_level_stop to BEGV.
2436 Fixes crashes in vertical-motion.
2437 (next_element_from_buffer): Improve commentary for when
2438 the iterator is before prev_stop.
2439 (init_iterator): Initialize bidi_p from the default value of
2440 bidi-display-reordering, not from buffer-local value. Use the
2441 buffer-local value only if initializing for buffer iteration.
2442 (handle_invisible_prop): Support invisible properties on strings
2443 that are being bidi-reordered.
2444 (set_iterator_to_next): Support bidi reordering of C strings and
2446 (next_element_from_string): Support bidi reordering of Lisp
2448 (handle_stop_backwards): Support Lisp strings as well.
2449 (display_string): Support display of R2L glyph rows.
2450 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2451 (init_iterator): Don't initialize it->bidi_p for strings
2453 (reseat_to_string): Initialize it->bidi_p for strings here.
2454 (next_element_from_string, next_element_from_c_string)
2455 (next_element_from_buffer): Add xassert's for correspondence
2456 between IT's object being iterated and it->bidi_it.string
2458 (face_before_or_after_it_pos): Support bidi iteration.
2459 (next_element_from_c_string): Handle the case of the first string
2460 character that is not the first one in the visual order.
2461 (get_visually_first_element): New function, refactored from common
2462 parts of next_element_from_buffer, next_element_from_string, and
2463 next_element_from_c_string.
2464 (tool_bar_lines_needed, redisplay_tool_bar)
2465 (display_menu_bar): Force left-to-right direction. Add a FIXME
2466 comment for making that be controlled by a user option.
2467 (push_it, pop_it): Save and restore the state of the
2468 bidi iterator. Save and restore the bidi_p flag.
2469 (pop_it): Iterate out of display property for string iteration as
2471 (iterate_out_of_display_property): Support iteration over strings.
2472 (handle_single_display_spec): Set up it->bidi_it for iteration
2473 over a display string, and call bidi_init_it.
2474 (handle_single_display_spec, next_overlay_string)
2475 (get_overlay_strings_1, push_display_prop): Set up the bidi
2476 iterator for displaying display or overlay strings.
2477 (forward_to_next_line_start): Don't use the shortcut if
2479 (back_to_previous_visible_line_start): If handle_display_prop
2480 pushed the iterator stack, restore the internal state of the bidi
2481 iterator by calling bidi_pop_it same number of times.
2482 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2483 and we are bidi-iterating, don't decrement the iterator position;
2484 instead, set the first_elt flag in the bidi iterator, to produce
2486 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2487 (push_display_prop): xassert that we are iterating a buffer.
2488 (push_it, pop_it): Save and restore paragraph_embedding member.
2489 (handle_single_display_spec, next_overlay_string)
2490 (get_overlay_strings_1, reseat_1, reseat_to_string)
2491 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2492 correctly. Don't assume unibyte strings are not bidi-reordered.
2493 (compute_display_string_pos)
2494 (compute_display_string_end): Fix handling the case of C string.
2495 (push_it, pop_it): Save and restore from_disp_prop_p.
2496 (handle_single_display_spec, push_display_prop): Set the
2497 from_disp_prop_p flag.
2498 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2499 (pop_it): Call iterate_out_of_display_property only if we are
2500 popping after iteration over a string that came from a display
2501 property. Fix a typo in popping stretch info. Add an assertion
2502 for verifying that the iterator position is in sync with the bidi
2504 (handle_single_display_spec, get_overlay_strings_1)
2505 (push_display_prop): Fix initialization of paragraph direction for
2506 string when that of the parent object is not yet determined.
2507 (reseat_1): Call bidi_init_it to resync the bidi
2508 iterator with IT's position. (Bug#7616)
2509 (find_row_edges): If ROW->start.pos gives position
2510 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2511 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2512 Reset the from_disp_prop_p flag.
2513 (SAVE_IT, RESTORE_IT): New macros.
2514 (pos_visible_p, face_before_or_after_it_pos)
2515 (back_to_previous_visible_line_start)
2516 (move_it_in_display_line_to, move_it_in_display_line)
2517 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2518 (try_scrolling, redisplay_window, display_line): Use them when
2519 saving a temporary copy of the iterator and restoring it back.
2520 (back_to_previous_visible_line_start, reseat_1)
2521 (init_iterator): Empty the bidi cache "stack".
2522 (move_it_in_display_line_to): If iterator ended up at
2523 EOL, but we never saw any buffer positions smaller than
2524 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2525 motion in bidi-reordered lines.
2526 (move_it_in_display_line_to): Record prev_method and prev_pos
2527 immediately before the call to set_iterator_to_next. Fixes cursor
2528 motion in bidi-reordered lines with stretch glyphs and strings
2529 displayed in margins. (Bug#8133) (Bug#8867)
2530 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2532 (pos_visible_p): Support positions in bidi-reordered lines.
2533 Save and restore bidi cache.
2535 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2536 (bidi_paragraph_info): Delete unused struct.
2537 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2538 (bidi_cache_start): New variable.
2539 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2541 (bidi_cache_fetch_state, bidi_cache_search)
2542 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2543 (bidi_cache_find, bidi_peek_at_next_level)
2544 (bidi_level_of_next_char, bidi_find_other_level_edge)
2545 (bidi_move_to_visually_next): Compare cache index with
2546 bidi_cache_start rather than with zero.
2547 (bidi_fetch_char): Accept new argument STRING; all callers
2548 changed. Support iteration over a string. Support strings with
2549 display properties. Support unibyte strings. Fix the type of
2550 `len' according to what STRING_CHAR_AND_LENGTH expects.
2551 (bidi_paragraph_init, bidi_resolve_explicit_1)
2552 (bidi_resolve_explicit, bidi_resolve_weak)
2553 (bidi_level_of_next_char, bidi_move_to_visually_next):
2554 Support iteration over a string.
2555 (bidi_set_sor_type, bidi_resolve_explicit_1)
2556 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2557 can now be zero (for strings); special values 0 and -1 were
2558 changed to -1 and -2, respectively.
2559 (bidi_char_at_pos): New function.
2560 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2561 Call it instead of FETCH_MULTIBYTE_CHAR.
2562 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2563 initialized to valid values.
2564 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2566 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2567 the test for valid cached positions. Fix the logic for looking up
2568 the sentinel state in the cache. GCPRO the Lisp string we are
2570 (bidi_push_it, bidi_pop_it): New functions.
2571 (bidi_initialize): Initialize the bidi cache start stack pointer.
2572 (bidi_cache_ensure_space): New function, refactored from part of
2573 bidi_cache_iterator_state. Don't assume the required size is just
2574 one BIDI_CACHE_CHUNK away.
2575 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2576 (bidi_count_bytes, bidi_char_at_pos): New functions.
2577 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2578 always valid if bidi_cache_idx is valid.
2579 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2580 is valid if it's going to be used.
2581 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2582 (bidi_cache_fetch_state, bidi_cache_search)
2583 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2584 (bidi_cache_iterator_state, bidi_cache_find)
2585 (bidi_find_other_level_edge, bidi_cache_start_stack):
2586 All variables related to cache indices are now EMACS_INT.
2588 * dispextern.h (struct bidi_string_data): New structure.
2589 (struct bidi_it): New member `string'. Make flag members be 1-bit
2590 fields, and put them last in the struct.
2591 (compute_display_string_pos, compute_display_string_end):
2593 (bidi_push_it, bidi_pop_it): Add prototypes.
2594 (struct iterator_stack_entry): New members bidi_p,
2595 paragraph_embedding, and from_disp_prop_p.
2596 (struct it): Member bidi_p is now a bit field 1 bit wide.
2597 (bidi_shelve_cache, bidi_unshelve_cache):
2600 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2601 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2602 and vector-like objects.
2604 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2605 cache around display iteration.
2607 * window.c (Fwindow_end, window_scroll_pixel_based)
2608 (displayed_window_lines, Frecenter): Save and restore the bidi
2609 cache around display iteration.
2611 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2613 * editfns.c (Fdelete_region): Clarify the use of the named
2614 parameters (bug#6788).
2616 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2618 * indent.c (Fvertical_motion): Set and restore w->pointm when
2619 saving and restoring the window's buffer (Bug#9006).
2621 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2623 * editfns.c (Fstring_to_char): Clarify just what is returned
2624 (bug#6576). Text by Eli Zaretskii.
2626 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2628 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2630 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2632 * buffer.c (mmap_find): Fix a typo.
2634 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2636 Fix execution of x selection hooks.
2637 * xselect.c (Qx_lost_selection_functions)
2638 (Qx_sent_selection_functions): New vars.
2639 (syms_of_xselect): DEFSYM them.
2640 (x_handle_selection_request): Pass Qx_sent_selection_functions
2641 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2642 (x_handle_selection_clear,x_clear_frame_selections):
2643 Pass Qx_lost_selection_functions rather than
2644 Vx_lost_selection_functions to Frun_hook_with_args.
2646 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2648 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2649 The old code sometimes used this field without initializing it.
2651 * alloc.c (gc_sweep): Don't read past end of array.
2652 In theory, the old code could also have corrupted Emacs internals,
2653 though it'd be very unlikely.
2655 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2657 * character.c (Fcharacterp): Don't advertise optional ignored
2658 argument. (Bug#4026)
2660 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2662 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2665 * window.c (Fset_window_start): Doc fix (bug#4199).
2666 (Fset_window_hscroll): Ditto.
2668 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2670 Fix minor new problems caught by GCC 4.6.1.
2671 * term.c (init_tty): Remove unused local.
2672 * xsettings.c (store_monospaced_changed): Define this function only
2673 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2676 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2678 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2680 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2682 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2683 are the mini-buffer and the echo area (bug#3320).
2685 * term.c (init_tty): Remove support for supdup, c10 and perq
2686 terminals, which are no longer supported (bug#1482).
2688 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2690 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2692 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2694 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2695 for non-popups (Bug#3642).
2697 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2699 * alloc.c (reset_malloc_hooks): Protoize.
2700 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2701 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2702 * cm.c (losecursor): Likewise.
2703 * data.c (fmod): Likewise.
2704 * dispnew.c (swap_glyphs_in_rows): Likewise.
2705 * emacs.c (memory_warning_signal): Likewise.
2706 * floatfns.c (float_error): Likewise.
2707 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2708 (otf_open, font_otf_capability, generate_otf_features)
2709 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2711 * image.c (pbm_read_file): Likewise.
2712 * indent.c (string_display_width): Likewise.
2713 * intervals.c (check_for_interval, search_for_interval)
2714 (inc_interval_count, count_intervals, root_interval)
2715 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2716 * lread.c (defalias): Likewise.
2717 * ralloc.c (r_alloc_check): Likewise.
2718 * regex.c (set_image_of_range_1, set_image_of_range)
2719 (regex_grow_registers): Likewise.
2720 * sysdep.c (strerror): Likewise.
2721 * termcap.c (valid_filename_p, tprint, main): Likewise.
2722 * tparam.c (main): Likewise.
2723 * unexhp9k800.c (run_time_remap, save_data_space)
2724 (update_file_ptrs, read_header, write_header, calculate_checksum)
2725 (copy_file, copy_rest, display_header): Likewise.
2726 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2728 * xdisp.c (check_it): Likewise.
2729 * xfaces.c (register_color, unregister_color, unregister_colors):
2731 * xfns.c (print_fontset_result): Likewise.
2732 * xrdb.c (member, fatal, main): Likewise.
2734 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2736 Fix minor problems found by static checking (Bug#9031).
2737 * chartab.c (char_table_set_range, map_sub_char_table):
2738 Remove unused locals.
2739 (uniprop_table): Now static.
2740 * composite.c (_work_char): Remove unused static var.
2742 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2744 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2746 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2748 * gtkutil.c (qttip_cb): Remove code without function.
2750 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2752 * w32.c (pthread_sigmask): New stub.
2754 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2756 Use pthread_sigmask, not sigprocmask (Bug#9010).
2757 sigprocmask is portable only for single-threaded applications, and
2758 Emacs can be multi-threaded when it uses GTK.
2759 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2761 * callproc.c (Fcall_process):
2762 * process.c (create_process):
2763 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2764 Use pthread_sigmask, not sigprocmask.
2766 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2768 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2769 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2772 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2774 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2775 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2776 (xg_hide_tooltip): Fix comment.
2778 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2779 in registerServicesMenuSendTypes.
2780 (validRequestorForSendType): Don't check ns_return_types.
2782 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2785 2011-07-08 Jason Rumney <jasonr@gnu.org>
2787 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2788 frame struct members of non-existent frames (Bug#6284).
2790 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2792 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2793 variable firstTime not needed on OSX >= 10.6.
2794 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2795 >= 10.5. Use setKnobProportion, setDoubleValue.
2797 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2798 (MAC_OS_X_VERSION_10_5): Define if not defined.
2799 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2800 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2801 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2803 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2804 cString and lossyCString on OSX >= 10.4
2806 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2807 sizeToFit on OSX >= 10.2.
2809 * nsimage.m (allocInitFromFile): Don't use deprecated method
2810 bestRepresentationForDevice on OSX >= 10.6.
2812 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2815 * emacs.c: Declare unexec_init_emacs_zone.
2817 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2819 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2821 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2822 on svcsMenu (Bug#8842).
2824 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2826 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2828 * nsterm.m (QUTF8_STRING): Declare.
2829 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2830 (validRequestorForSendType): Return type is (id).
2831 Change indexOfObjectIdenticalTo to indexOfObject.
2832 Check if we have local selection before returning self (Bug#8842).
2833 (writeSelectionToPasteboard): Put local selection into paste board
2834 if we have a local selection (Bug#8842).
2835 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2837 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2838 (ns_get_local_selection): Declare.
2840 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2842 * keymap.c (describe_map_tree): Don't insert a double newline at
2843 the end of the buffer (bug#1169) and return whether we inserted
2846 * callint.c (Fcall_interactively): Change "reading args" to
2847 "providing args" to try to clarify what it does (bug#1010).
2849 2011-07-07 Kenichi Handa <handa@m17n.org>
2851 * composite.c (composition_compute_stop_pos): Ignore a static
2852 composition starting before CHARPOS (Bug#8915).
2854 * xdisp.c (handle_composition_prop): Likewise.
2856 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2858 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2861 2011-07-07 Kenichi Handa <handa@m17n.org>
2863 * character.h (unicode_category_t): New enum type.
2865 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2866 (Qchar_code_property_table): New variable.
2867 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2868 (UNIPROP_COMPRESSED_FORM_P): New macros.
2869 (char_table_ascii): Uncompress the compressed values.
2870 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2871 Uncompress the compressed values.
2872 (sub_char_table_ref_and_range): Likewise.
2873 (char_table_ref_and_range): Uncompress the compressed values.
2874 (sub_char_table_set): New arg is_uniprop. Callers changed.
2875 Uncompress the compressed values.
2876 (sub_char_table_set_range): Args changed. Callers changed.
2877 (char_table_set_range): Adjuted for the above change.
2878 (map_sub_char_table): Delete args default_val and parent. Add arg
2879 top. Give decoded values to a Lisp function.
2880 (map_char_table): Adjust for the above change. Give decoded
2881 values to a Lisp function. Gcpro more variables.
2882 (uniprop_table_uncompress)
2883 (uniprop_decode_value_run_length): New functions.
2884 (uniprop_decoder, uniprop_decoder_count): New variables.
2885 (uniprop_get_decoder, uniprop_encode_value_character)
2886 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2888 (uniprop_encoder, uniprop_encoder_count): New variables.
2889 (uniprop_get_encoder, uniprop_table)
2890 (Funicode_property_table_internal, Fget_unicode_property_internal)
2891 (Fput_unicode_property_internal): New functions.
2892 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2893 Sunicode_property_table_internal, Sget_unicode_property_internal,
2894 and Sput_unicode_property_internal. Defvar_lisp
2895 char-code-property-alist.
2897 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2898 Vunicode_category_table.
2900 * font.c (font_range): Adjust for the change of
2901 Vunicode_category_table.
2903 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2905 * m/iris4d.h: Remove file, move contents ...
2906 * s/irix6-5.h: ... here.
2908 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2910 Remove unportable assumption about struct layout (Bug#8884).
2911 * alloc.c (mark_buffer):
2912 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2913 (clone_per_buffer_values): Don't assume that
2914 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2915 This isn't true in general, and it's particularly not true
2916 if Emacs is configured with --with-wide-int.
2917 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2918 New macros, used in the buffer.c change.
2920 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2922 * xsettings.c: Use both GConf and GSettings if both are available.
2923 (store_config_changed_event): Add comment.
2924 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2925 (store_tool_bar_style_changed): New functions.
2926 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2927 (struct xsettings): Move font inside HAVE_XFT.
2928 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2929 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2930 Move inside HAVE_XFT.
2931 (something_changed_gsettingsCB): Rename from something_changedCB.
2932 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2934 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2935 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2936 (something_changed_gconfCB): Rename from something_changedCB.
2937 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2938 (parse_settings): Move check for font inside HAVE_XFT.
2939 (read_settings, apply_xft_settings): Add comment.
2940 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2941 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2942 call store_font_name_changed.
2943 (xft_settings_event): Add comment.
2944 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2945 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2946 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2947 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2948 (xsettings_initialize): Call init_gsettings last.
2949 (xsettings_get_system_font, xsettings_get_system_normal_font):
2952 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2954 Random fixes. E.g., (random) never returned negative values.
2955 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2956 subseconds part to the entropy, as that's a bit more random.
2957 Prefer signed to unsigned, since the signedness doesn't matter and
2958 in general we prefer signed. When given a limit, use a
2959 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2960 latter isn't right if USE_2_TAGS_FOR_INTS.
2961 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2962 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2964 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2966 * textprop.c (text_property_stickiness):
2967 Obey Vtext_property_default_nonsticky.
2968 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2969 * w32fns.c (syms_of_w32fns):
2970 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2972 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2974 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2975 This is more efficient than Ffile_directory_p and avoids a minor race.
2977 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2979 * buffer.c (Foverlay_put): Say what the return value is
2982 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2983 is a directory before asking whether to use the file name
2985 (barf_or_query_if_file_exists): Make the "File is a directory"
2986 error be more correct.
2988 * fns.c (Frequire): Remove the mention of the .gz files, since
2989 that's installation-specific, but keep the mention of
2990 `get-load-suffixes'.
2992 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2994 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2995 Report string overflow if the output is too long.
2997 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2999 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3000 (syms_of_gnutls): Remove duplicate DEFSYM for
3001 Qgnutls_bootprop_verify_hostname_error, an error for
3002 Qgnutls_bootprop_verify_error (which is no longer used).
3004 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3005 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3006 Also (re)move comments that are misplaced or no longer relevant.
3008 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3010 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3012 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3014 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3015 and background color parameters if they have been changed.
3017 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3019 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3021 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3023 * xsettings.c (SYSTEM_FONT): Define only when used.
3024 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3026 * keymap.c (access_keymap_1): Now static.
3028 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3030 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3031 leave any prefix arg for the up event (Bug#1586).
3033 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3035 * lread.c (syms_of_lread): Mention single symbols defined by
3036 `defvar' or `defconst' (bug#7154).
3038 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3039 (Frequire): Mention get-load-suffixes.
3041 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3043 * window.h (window): Remove clone_number slot.
3044 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3046 (make_parent_window, make_window, saved_window)
3047 (Fset_window_configuration, save_window_save): Don't deal with
3049 * buffer.c (Qclone_number): Remove declaration.
3050 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3052 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3054 Add multiple inheritance to keymaps.
3055 * keymap.c (Fmake_composed_keymap): New function.
3056 (Fset_keymap_parent): Simplify.
3057 (fix_submap_inheritance): Remove.
3058 (access_keymap_1): New function extracted from access_keymap to handle
3059 embedded parents and handle lists of maps.
3060 (access_keymap): Use it.
3061 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3062 (Fcopy_keymap): Handle embedded parents.
3063 (Fcommand_remapping, define_as_prefix): Simplify.
3064 (Fkey_binding): Simplify.
3065 (syms_of_keymap): Move minibuffer-local-completion-map,
3066 minibuffer-local-filename-completion-map,
3067 minibuffer-local-must-match-map, and
3068 minibuffer-local-filename-must-match-map to Elisp.
3069 (syms_of_keymap): Defsubr make-composed-keymap.
3070 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3071 (parse_menu_item): Trivial simplification.
3073 2011-07-01 Glenn Morris <rgm@gnu.org>
3075 * Makefile.in (SETTINGS_LIBS): Fix typo.
3077 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3079 * coding.c (Fencode_coding_string): Record the last coding system
3080 used, as the function doc string says (bug#8738).
3082 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3084 * xsettings.c (store_monospaced_changed): Take new font as arg and
3085 check for change against current_mono_font.
3086 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3087 (emacs_settings_constructor, emacs_settings_get_property)
3088 (emacs_settings_set_property, emacs_settings_class_init)
3089 (emacs_settings_init, gsettings_obj): Remove.
3090 (something_changedCB): New function for HAVE_GSETTINGS.
3091 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3092 with value as argument.
3093 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3094 g_settings_new (Bug#8967). Do not create gsettings_obj.
3095 Remove calls to g_settings_bind. Connect something_changedCB to
3098 * xgselect.c: Add defined (HAVE_GSETTINGS).
3099 (xgselect_initialize): Ditto.
3101 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3102 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3105 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3107 * eval.c (struct backtrace): Simplify and port the data structure.
3108 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3109 signed bit field, as this assumption is not portable and it makes
3110 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3111 "char debug_on_exit : 1" as this is not portable either; instead,
3112 use the portable "unsigned int debug_on_exit : 1". Remove unused
3113 member evalargs. Remove obsolete comments about cc bombing out.
3115 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3117 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3118 Let HAVE_GSETTINGS override HAVE_GCONF.
3119 (store_monospaced_changed): New function.
3120 (EMACS_SETTINGS): A new type derived from GObject to handle
3121 GSettings notifications.
3122 (emacs_settings_constructor, emacs_settings_get_property)
3123 (emacs_settings_set_property, emacs_settings_class_init):
3125 (gsettings_client, gsettings_obj): New variables.
3126 (GSETTINGS_SCHEMA): New define.
3127 (something_changedCB): Call store_monospaced_changed.
3128 (init_gsettings): New function.
3129 (xsettings_initialize): Call init_gsettings.
3130 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3133 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3136 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3138 * window.c (resize_root_window, grow_mini_window)
3139 (shrink_mini_window): Rename Qresize_root_window to
3140 Qwindow_resize_root_window and Qresize_root_window_vertically to
3141 Qwindow_resize_root_window_vertically.
3143 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3145 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3147 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3149 * makefile.w32-in: Redesign dependencies so they reflect more
3150 clearly which files are directly included by each source file,
3151 and not through other includes.
3153 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3155 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3156 (sort_overlays, overlay_strings): When an overlay's clone number
3157 matches the window's clone number process the overlay even if
3158 the overlay's window property doesn't match the current window.
3160 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3161 (Fwindow_hchild): Rename to Fwindow_left_child.
3162 (Fwindow_next): Rename to Fwindow_next_sibling.
3163 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3164 (resize_window_check): Rename to window_resize_check.
3165 (resize_window_apply): Rename to window_resize_apply.
3166 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3167 (Fdelete_other_windows_internal, resize_frame_windows)
3168 (Fsplit_window_internal, Fdelete_window_internal)
3169 (grow_mini_window, shrink_mini_window)
3170 (Fresize_mini_window_internal): Fix callers accordingly.
3172 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3174 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3175 (emacs_fixed_set_min_size): Remove.
3176 (emacs_fixed_new): Take frame as argument.
3178 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3179 (_EmacsFixedPrivate): Remove minwidth/height.
3180 Add struct frame *f.
3181 (emacs_fixed_init): Initialize priv->f.
3182 (get_parent_class, emacs_fixed_set_min_size): Remove.
3183 (emacs_fixed_new): Set priv->f to argument.
3184 (emacs_fixed_get_preferred_width)
3185 (emacs_fixed_get_preferred_height): Use min_width/height from
3186 frames size_hint to set minimum and natural (Bug#8919).
3187 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3188 and use min_width/height from frames size_hint to set
3189 min_width/height (Bug#8919).
3191 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3192 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3195 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3197 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3198 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3201 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3203 * process.c (wait_reading_process_output): Bypass select if
3204 waiting for a cell while ignoring keyboard input, and input is
3205 pending. Suggested by Jan Djärv (Bug#8869).
3207 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3209 Use gnulib's dup2 module instead of rolling our own.
3210 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3212 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3214 * dispnew.c (scrolling_window): Before scrolling, turn off a
3215 mouse-highlight in the window being scrolled.
3217 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3219 Move DEFSYM to lisp.h and use everywhere.
3221 * character.h (DEFSYM): Move declaration...
3222 * lisp.h (DEFSYM): ...here.
3228 * w32select.c: Don't include character.h.
3230 * alloc.c (syms_of_alloc):
3231 * buffer.c (syms_of_buffer):
3232 * bytecode.c (syms_of_bytecode):
3233 * callint.c (syms_of_callint):
3234 * casefiddle.c (syms_of_casefiddle):
3235 * casetab.c (init_casetab_once):
3236 * category.c (init_category_once, syms_of_category):
3237 * ccl.c (syms_of_ccl):
3238 * cmds.c (syms_of_cmds):
3239 * composite.c (syms_of_composite):
3240 * dbusbind.c (syms_of_dbusbind):
3241 * dired.c (syms_of_dired):
3242 * dispnew.c (syms_of_display):
3243 * doc.c (syms_of_doc):
3244 * editfns.c (syms_of_editfns):
3245 * emacs.c (syms_of_emacs):
3246 * eval.c (syms_of_eval):
3247 * fileio.c (syms_of_fileio):
3248 * fns.c (syms_of_fns):
3249 * frame.c (syms_of_frame):
3250 * fringe.c (syms_of_fringe):
3251 * insdel.c (syms_of_insdel):
3252 * keymap.c (syms_of_keymap):
3253 * lread.c (init_obarray, syms_of_lread):
3254 * macros.c (syms_of_macros):
3255 * msdos.c (syms_of_msdos):
3256 * print.c (syms_of_print):
3257 * process.c (syms_of_process):
3258 * search.c (syms_of_search):
3259 * sound.c (syms_of_sound):
3260 * syntax.c (init_syntax_once, syms_of_syntax):
3261 * terminal.c (syms_of_terminal):
3262 * textprop.c (syms_of_textprop):
3263 * undo.c (syms_of_undo):
3264 * w32.c (globals_of_w32):
3265 * window.c (syms_of_window):
3266 * xdisp.c (syms_of_xdisp):
3267 * xfaces.c (syms_of_xfaces):
3268 * xfns.c (syms_of_xfns):
3269 * xmenu.c (syms_of_xmenu):
3270 * xsettings.c (syms_of_xsettings):
3271 * xterm.c (syms_of_xterm): Use DEFSYM.
3273 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3275 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3277 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3279 Integer and buffer overflow fixes (Bug#8873).
3281 * print.c (printchar, strout): Check for string overflow.
3282 (PRINTPREPARE, printchar, strout):
3283 Don't set size unless allocation succeeds.
3285 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3286 for sizes. Check for string overflow more accurately.
3287 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3289 * macros.c: Integer and buffer overflow fixes.
3290 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3291 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3292 Use ptrdiff_t, not int, for sizes.
3293 Don't increment bufsize until after realloc succeeds.
3294 Check for size-calculation overflow.
3295 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3297 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3299 * lread.c: Integer overflow fixes.
3300 (read_integer): Radix is now EMACS_INT, not int,
3301 to improve quality of diagnostics for out-of-range radices.
3302 Calculate buffer size correctly for out-of-range radices.
3303 (read1): Check for integer overflow in radices, and in
3304 read-circle numbers.
3305 (read_escape): Avoid int overflow.
3306 (Fload, openp, read_buffer_size, read1)
3307 (substitute_object_recurse, read_vector, read_list, map_obarray):
3308 Use ptrdiff_t, not int, for sizes.
3309 (read1): Use EMACS_INT, not int, for sizes.
3310 Check for size overflow.
3312 * image.c (cache_image): Check for size arithmetic overflow.
3314 * lread.c: Integer overflow issues.
3315 (saved_doc_string_size, saved_doc_string_length)
3316 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3317 Now ptrdiff_t, not int.
3318 (read1): Don't assume doc string length fits in int. Check for
3319 out-of-range doc string lengths.
3320 (read_list): Don't assume file position fits in int.
3321 (read_escape): Check for hex character overflow.
3323 2011-06-22 Leo Liu <sdl.web@gmail.com>
3325 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3326 Move to minibuffer.el.
3328 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3330 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3331 The following patches are for when GLYPH_DEBUG && !XASSERT.
3332 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3333 * dispnew.c (flush_stdout):
3334 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3335 Mark as externally visible.
3336 * dispnew.c (check_window_matrix_pointers): Now static.
3337 * dispnew.c (window_to_frame_vpos):
3338 * xfns.c (unwind_create_frame):
3339 * xterm.c (x_check_font): Remove unused local.
3340 * scroll.c (CHECK_BOUNDS):
3341 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3342 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3343 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3344 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3345 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3347 (debug_method_add): Use va_list and vsprintf rather than relying
3348 on undefined behavior with wrong number of arguments.
3349 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3350 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3351 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3352 since we're not interested in debugging glyphs with old libraries.
3353 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3354 GCC 4.6.0's static checking.
3356 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3358 Integer overflow and signedness fixes (Bug#8873).
3359 A few related buffer overrun fixes, too.
3361 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3363 * dispextern.h (struct face.stipple):
3364 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3365 (x_bitmap_mask, x_allocate_bitmap_record)
3366 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3367 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3368 (x_create_bitmap_from_xpm_data):
3369 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3370 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3372 * xfaces.c (load_pixmap):
3373 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3374 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3375 (.bitmaps_last, struct x_output.icon_bitmap):
3376 Use ptrdiff_t, not int, for bitmap indexes.
3377 (x_allocate_bitmap_record): Check for size overflow.
3378 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3380 Use ptrdiff_t, not int, for overlay counts.
3381 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3382 * editfns.c (overlays_around, get_pos_property):
3383 * textprop.c (get_char_property_and_overlay):
3384 * xdisp.c (next_overlay_change, note_mouse_highlight):
3385 * xfaces.c (face_at_buffer_position):
3386 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3387 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3388 (Fnext_overlay_change, Fprevious_overlay_change)
3389 (mouse_face_overlay_overlaps, Foverlays_in):
3390 Use ptrdiff_t, not int, for sizes.
3391 (overlays_at, overlays_in): Check for size-calculation overflow.
3393 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3395 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3396 (x_session_initialize): Do not assume string length fits in int.
3398 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3399 This is unlikely, but can occur if DPI is outlandish.
3401 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3402 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3404 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3405 * xrdb.c (magic_file_p, search_magic_path):
3406 Omit last arg SUFFIX; it was always 0. All callers changed.
3407 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3409 * xfont.c (xfont_match): Avoid need for strlen.
3411 * xfns.c: Don't assume strlen fits in int.
3412 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3414 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3415 not unsigned long, as we prefer signed integers. All callers changed.
3416 Detect integer overflow in repeat count.
3417 (message_dolog): Don't assume print length fits in 39 bytes.
3418 (display_mode_element): Don't assume strlen fits in int.
3420 * termcap.c: Don't assume sizes fit in int and never overflow.
3421 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3422 (gobble_line): Check for size-calculation overflow.
3424 * minibuf.c (Fread_buffer):
3425 * lread.c (intern, intern_c_string):
3426 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3427 Don't assume string length fits in int.
3429 * keyboard.c (parse_tool_bar_item):
3430 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3432 * font.c: Don't assume string length fits in int.
3433 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3434 Use ptrdiff_t, not int.
3435 (font_intern_prop): Don't assume string length fits in int.
3436 Don't assume integer property fits in fixnum.
3437 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3439 * filelock.c: Fix some buffer overrun and integer overflow issues.
3440 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3441 Reformulate so as not to need the command string.
3442 Invoke gzip -cd rather than gunzip, as it's more portable.
3443 (lock_info_type, lock_file_1, lock_file):
3444 Don't assume pid_t and time_t fit in unsigned long.
3445 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3446 (current_lock_owner): Prefer signed type for sizes.
3447 Use memcpy, not strncpy, where memcpy is what is really wanted.
3448 Don't assume (via atoi) that time_t and pid_t fit in int.
3449 Check for time_t and/or pid_t out of range, e.g., via a network share.
3450 Don't alloca where an auto var works fine.
3452 * fileio.c: Fix some integer overflow issues.
3453 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3454 Don't assume string length fits in int.
3455 (directory_file_name): Don't assume string length fits in long.
3456 (make_temp_name): Don't assume pid fits in int, or that its print
3457 length is less than 20.
3459 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3461 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3463 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3465 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3466 We prefer signed integers, even for size calculations.
3468 * emacs.c: Don't assume string length fits in 'int'.
3469 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3470 (main): Don't invoke strlen when not needed.
3472 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3473 (XD_DEBUG_MESSAGE): Don't waste a byte.
3475 * callproc.c (getenv_internal_1, getenv_internal)
3477 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3479 * lread.c (invalid_syntax): Omit length argument.
3480 All uses changed. This doesn't fix a bug, but it simplifies the
3481 code away from its former Hollerith-constant appearance, and it's
3482 one less 'int' to worry about when looking at integer-overflow issues.
3483 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3485 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3486 This didn't break anything, but it didn't help either.
3487 It's confusing to put a bogus integer in a place where the actual
3488 value does not matter.
3489 (LIST_END_P): Remove unused macro and its bogus comment.
3490 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3492 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3493 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3495 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3496 We prefer signed types, and the value cannot exceed the EMACS_INT
3497 range anyway (because otherwise the length would not be representable).
3498 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3499 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3500 This avoids a GCC warning when WIDE_EMACS_INT.
3502 * indent.c (sane_tab_width): New function.
3503 (current_column, scan_for_column, Findent_to, position_indentation)
3504 (compute_motion): Use it. This is just for clarity.
3505 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3507 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3509 * lisp.h (lint_assume): New macro.
3510 * composite.c (composition_gstring_put_cache):
3511 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3513 * editfns.c, insdel.c:
3514 Omit unnecessary forward decls, to simplify future changes.
3516 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3518 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3520 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3521 Use much-faster test for byte-length change.
3522 Don't assume string byte-length fits in 'int'.
3523 Check that character arg fits in 'int'.
3524 (mapcar1): Declare byte as byte, for clarity.
3526 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3528 * fns.c (concat): Catch string overflow earlier.
3529 Do not rely on integer wraparound.
3531 * dispextern.h (struct it.overlay_strings_charpos)
3532 (struct it.selective): Now EMACS_INT, not int.
3533 * xdisp.c (forward_to_next_line_start)
3534 (back_to_previous_visible_line_start)
3535 (reseat_at_next_visible_line_start, next_element_from_buffer):
3536 Don't arbitrarily truncate the value of 'selective' to int.
3538 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3540 * composite.c: Don't truncate sizes to 'int'.
3541 (composition_gstring_p, composition_reseat_it)
3542 (composition_adjust_point): Use EMACS_INT, not int.
3543 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3544 not EMACS_UINT, for indexes.
3546 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3548 * buffer.c: Include <verify.h>.
3549 (struct sortvec.priority, struct sortstr.priority):
3550 Now EMACS_INT, not int.
3551 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3552 (struct sortstr.size, record_overlay_string)
3553 (struct sortstrlist.size, struct sortlist.used):
3554 Don't truncate size to int.
3555 (record_overlay_string): Check for size-calculation overflow.
3556 (init_buffer_once): Check at compile-time, not run-time.
3558 2011-06-22 Jim Meyering <meyering@redhat.com>
3560 Don't leak an XBM-image-sized buffer
3561 * image.c (xbm_load): Free the image buffer after using it.
3563 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3566 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3567 that Sun C diagnosed.
3568 * fns.c (secure_hash): Fix pointer signedness issue.
3569 * intervals.c (static_offset_intervals): New function.
3570 (offset_intervals): Use it.
3572 2011-06-21 Leo Liu <sdl.web@gmail.com>
3575 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3578 * fns.c (secure_hash): Rename from crypto_hash_function and change
3579 the first arg to accept symbols.
3580 (Fsecure_hash): New primitive.
3581 (syms_of_fns): New symbols.
3583 2011-06-20 Deniz Dogan <deniz@dogan.se>
3585 * process.c (Fset_process_buffer): Clarify return value in
3588 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3590 * dispnew.c (add_window_display_history): Use BVAR.
3592 * xdisp.c (debug_method_add): Use BVAR.
3593 (check_window_end, dump_glyph_matrix, dump_glyph)
3594 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3596 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3599 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3600 check till after the cache is created in init_frame_faces.
3602 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3604 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3606 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3608 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3609 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3610 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3612 Improve buffer-overflow checking (Bug#8873).
3613 * fileio.c (Finsert_file_contents):
3614 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3615 Remove the old (too-loose) buffer overflow checks.
3616 They weren't needed, since make_gap checks for buffer overflow.
3617 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3618 The old code merely checked for Emacs fixnum overflow, and relied
3619 on undefined (wraparound) behavior. The new code avoids undefined
3620 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3622 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3623 Tune. Don't use wider integers than needed. Don't use alloca.
3624 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3626 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3628 * insdel.c, lisp.h (buffer_overflow): New function.
3629 (insert_from_buffer_1, replace_range, replace_range_2):
3630 * insdel.c (make_gap_larger):
3631 * editfns.c (Finsert_char):
3632 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3634 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3636 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3638 Integer overflow and signedness fixes (Bug#8873).
3640 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3641 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3643 * fileio.c: Don't assume EMACS_INT fits in off_t.
3644 (emacs_lseek): New static function.
3645 (Finsert_file_contents, Fwrite_region): Use it.
3646 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3648 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3650 * fns.c: Don't overflow int when computing a list length.
3651 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3652 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3653 truncation on 64-bit hosts. Check for QUIT every
3654 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3655 faster and is responsive enough.
3656 (Flength): Report an error instead of overflowing an integer.
3657 (Fsafe_length): Return a float if the value is not representable
3658 as a fixnum. This shouldn't happen except in contrived situations.
3659 (Fnthcdr, Fsort): Don't assume list length fits in int.
3660 (Fcopy_sequence): Don't assume vector length fits in int.
3662 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3663 (header_size, word_size): New constants.
3664 (allocate_vectorlike): Don't check size overflow here.
3665 (allocate_vector): Check it here instead, since this is the only
3666 caller of allocate_vectorlike that could cause overflow.
3667 Check that the new vector's length is representable as a fixnum.
3669 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3670 The previous code was bogus. For example, next_almost_prime (32)
3671 returned 39, which is undesirable as it is a multiple of 3; and
3672 next_almost_prime (24) returned 25, which is a multiple of 5 so
3673 why was the code bothering to check for multiples of 7?
3675 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3677 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3679 Variadic C functions now count arguments with ptrdiff_t.
3680 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3681 Back then I didn't know that the Emacs coding style prefers signed int.
3682 Also, in the meantime I found a few more instances where arguments
3683 were being counted with int, which may truncate counts on 64-bit
3684 machines, or EMACS_INT, which may be unnecessarily wide.
3685 * lisp.h (struct Lisp_Subr.function.aMANY)
3686 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3687 Arg counts are now ptrdiff_t, not size_t.
3688 All variadic functions and their callers changed accordingly.
3689 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3690 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3691 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3692 * callint.c (Fcall_interactively): Check arg count for overflow,
3693 to avoid potential buffer overrun. Use signed char, not 'int',
3694 for 'varies' array, so that we needn't bother to check its size
3695 calculation for overflow.
3696 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3697 * eval.c (apply_lambda):
3698 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3699 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3700 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3702 * callint.c (Fcall_interactively): Don't use index var as event count.
3704 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3705 * mem-limits.h (SIZE): Remove; no longer used.
3707 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3709 Remove unnecessary casts.
3710 * xterm.c (x_term_init):
3711 * xfns.c (x_set_border_pixel):
3712 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3713 These aren't needed now that we assume ANSI C.
3715 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3716 It's more likely to cause problems (due to unsigned overflow)
3719 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3721 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3723 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3725 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3727 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3729 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3731 GLYPH_CODE_FACE returns EMACS_INT, not int.
3732 * dispextern.h (merge_faces):
3733 * xfaces.c (merge_faces):
3734 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3735 Don't assume EMACS_INT fits in int.
3737 * character.h (CHAR_VALID_P): Remove unused parameter.
3738 * fontset.c, lisp.h, xdisp.c: All uses changed.
3740 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3742 * fns.c (concat): Minor tuning based on overflow analysis.
3743 This doesn't fix any bugs. Use int to hold character, instead
3744 of constantly refetching from Emacs object. Use XFASTINT, not
3745 XINT, for value known to be a character. Don't bother comparing
3746 a single byte to 0400, as it's always less.
3748 * floatfns.c (Fexpt):
3749 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3751 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3754 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3756 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3757 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3758 incorrectly succeed when S was a string, because 4294967386 was
3759 truncated before it was used.
3761 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3762 Otherwise, an out-of-range integer could cause undefined behavior
3765 * composite.c: Use int, not EMACS_INT, for characters.
3766 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3767 EMACS_INT, for values that are known to be in character range.
3768 This doesn't fix any bugs but is the usual style inside Emacs and
3769 may generate better code on 32-bit machines.
3771 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3772 This is for reasons similar to the recent CHAR_STRING fix.
3773 * charset.c (Fencode_char): Check that character arg is actually
3774 a character. Pass an int to ENCODE_CHAR.
3775 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3776 wider than 'int', as a compile-time check to prevent future regressions
3779 * character.c (char_string): Remove unnecessary casts.
3781 Make sure a 64-bit char is never passed to CHAR_STRING.
3782 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3783 by silently ignoring the top 32 bits, allowing some values
3784 that were far too large to be valid characters.
3785 * character.h: Include <verify.h>.
3786 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3787 arguments are no wider than unsigned, as a compile-time check
3788 to prevent future regressions in this area.
3790 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3791 (Fsubst_char_in_region):
3793 * xdisp.c (decode_mode_spec_coding):
3794 Adjust to CHAR_STRING's new requirement.
3795 * editfns.c (Finsert_char, Fsubst_char_in_region):
3796 * fns.c (concat): Check that character args are actually
3797 characters. Without this test, these functions did the wrong
3798 thing with wildly out-of-range values on 64-bit hosts.
3800 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3801 These casts should not be needed on 32-bit hosts, either.
3802 * keyboard.c (read_char):
3803 * lread.c (Fload): Remove casts to unsigned.
3805 * lisp.h (UNSIGNED_CMP): New macro.
3806 This fixes comparison bugs on 64-bit hosts.
3807 (ASCII_CHAR_P): Use it.
3808 * casefiddle.c (casify_object):
3809 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3810 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3811 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3812 * dispextern.h (FACE_FROM_ID):
3813 * keyboard.c (read_char): Use UNSIGNED_CMP.
3815 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3816 not to EMACS_INT, to avoid GCC warning.
3818 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3820 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3821 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3822 isn't needed on 32-bit machines.
3824 * buffer.c (Fgenerate_new_buffer_name):
3825 Use EMACS_INT for count, not int.
3826 (advance_to_char_boundary): Return EMACS_INT, not int.
3828 * data.c (Qcompiled_function): Now static.
3830 * window.c (window_body_lines): Now static.
3832 * image.c (gif_load): Rename local to avoid shadowing.
3834 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3835 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3836 * alloc.c (make_save_value): Integer argument is now of type
3838 (mark_object): Use ptrdiff_t, not int.
3839 * lisp.h (pD): New macro.
3840 * print.c (print_object): Use it.
3842 * alloc.c: Use EMACS_INT, not int, to count objects.
3843 (total_conses, total_markers, total_symbols, total_vector_size)
3844 (total_free_conses, total_free_markers, total_free_symbols)
3845 (total_free_floats, total_floats, total_free_intervals)
3846 (total_intervals, total_strings, total_free_strings):
3847 Now EMACS_INT, not int. All uses changed.
3848 (Fgarbage_collect): Compute overall total using a double, so that
3849 integer overflow is less likely to be a problem. Check for overflow
3850 when converting back to an integer.
3851 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3852 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3853 These were 'int' variables that could overflow on 64-bit hosts;
3854 they were never used, so remove them instead of repairing them.
3855 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3856 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3857 Previously, this ceilinged at INT_MAX, but that doesn't work on
3859 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3861 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3862 (allocate_vectorlike): Check for ptrdiff_t overflow.
3863 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3864 when a (possibly-narrower) signed value would do just as well.
3865 We prefer using signed arithmetic, to avoid comparison confusion.
3867 * alloc.c: Catch some string size overflows that we were missing.
3868 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3869 for convenience in STRING_BYTES_MAX.
3870 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3871 The definition here is exact; the one in lisp.h was approximate.
3872 (allocate_string_data): Check for string overflow. This catches
3873 some instances we weren't catching before. Also, it catches
3874 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3875 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3876 and ptrdiff_t and EMACS_INT are both 64 bits.
3878 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3879 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3880 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3882 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3884 * alloc.c (Fmake_string): Check for out-of-range init.
3886 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3888 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3890 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3892 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3893 xg_get_default_scrollbar_width.
3895 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3896 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3897 (style_changed_cb): Call update_theme_scrollbar_width and call
3898 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3899 all frames (Bug#8505).
3900 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3901 Call gtk_window_set_resizable if HAVE_GTK3.
3902 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3903 and height if HAVE_GTK3 (Bug#8505).
3904 (scroll_bar_width_for_theme): New variable.
3905 (update_theme_scrollbar_width): New function.
3906 (xg_get_default_scrollbar_width): Move code to
3907 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3908 (xg_initialize): Call update_theme_scrollbar_width.
3910 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3912 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3914 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3916 * frame.c (make_frame): Call other_buffer_safely instead of
3919 * window.c (temp_output_buffer_show): Call display_buffer with
3920 second argument Vtemp_buffer_show_specifiers and reset latter
3921 immediately after the call.
3922 (Vtemp_buffer_show_specifiers): New variable.
3923 (auto_window_vscroll_p, next_screen_context_lines)
3924 (Vscroll_preserve_screen_position): Remove leading asterisks from
3927 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3929 Fix minor problems found by GCC 4.6.0 static checking.
3930 * buffer.c (Qclone_number): Remove for now, as it's unused.
3931 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3932 (record_buffer): Remove unused local.
3933 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3934 (set_frame_buffer_list): Remove; unused.
3935 * frame.h (other_visible_frames): Remove decl.
3936 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3937 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3938 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3940 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3941 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3942 Define only if HAVE_GPM.
3943 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3944 (update_hints_inhibit): Remove; never set. All uses removed.
3945 * widgetprv.h (emacsFrameClassRec): Remove decl.
3946 * window.c (delete_deletable_window): Now returns void, since it
3947 wasn't returning anything.
3948 (compare_window_configurations): Remove unused locals.
3949 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3950 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3951 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3952 the same widths as pointers. This follows up on the 2011-05-06 patch.
3953 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3954 * xterm.h: Likewise.
3955 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3957 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3959 * makefile.w32-in: Update dependencies.
3960 (LISP_H): Add lib/intprops.h.
3962 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3964 * image.c (gif_load): Add animation frame delay to the metadata.
3965 (syms_of_image): Use DEFSYM. New symbol `delay'.
3967 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3969 * window.c (delete_deletable_window): Re-add.
3970 (Fset_window_configuration): Rewrite to handle dead buffers and
3971 consequently deletable windows.
3972 (window_tree, Fwindow_tree): Remove. Supply functionality in
3974 (compare_window_configurations): Simplify code.
3976 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3978 * image.c (imagemagick_load_image): Fix type mismatch.
3979 (Fimagemagick_types): Likewise.
3981 * window.h (replace_buffer_in_windows): Declare.
3983 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3985 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3986 Qclone_number. Remove external declaration of Qdelete_window.
3987 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3989 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3990 Run Qbuffer_list_update_hook if allowed.
3991 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3992 buffer list implementation.
3993 (other_buffer_safely): New function.
3994 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3995 calls to replace_buffer_in_windows and
3996 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3998 (record_buffer): Inhibit quitting and rewrite using quittable
3999 functions. Run Qbuffer_list_update_hook if allowed.
4000 (Frecord_buffer, Funrecord_buffer): New functions.
4001 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4002 Move switch-to-buffer to window.el.
4003 (bury-buffer): Move to window.el.
4004 (Vbuffer_list_update_hook): New variable.
4006 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4009 * window.h (resize_frame_windows): Move up in code.
4010 (Fwindow_frame): Remove EXFUN.
4011 (replace_buffer_in_all_windows): Remove prototype.
4012 (replace_buffer_in_windows_safely): Add prototype.
4014 * window.c: Declare Qdelete_window static again. Move down
4015 declaration of select_count.
4016 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4017 (Fother_window): Move to window.el.
4018 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4019 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4020 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4022 (replace_buffer_in_windows): Implement by calling
4023 Qreplace_buffer_in_windows.
4024 (replace_buffer_in_all_windows): Remove with some functionality
4025 moved into replace_buffer_in_windows_safely.
4026 (replace_buffer_in_windows_safely): New function.
4027 (select_window_norecord, select_frame_norecord): Move in front
4028 of run_window_configuration_change_hook. Remove now obsolete
4030 (Fset_window_buffer): Rewrite doc-string.
4031 Call Qrecord_window_buffer.
4032 (keys_of_window): Move binding for other-window to window.el.
4034 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4036 * dispextern.h (struct image): Replace data member, whose int_val
4037 and ptr_val fields were not used by anything, with a single
4040 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4041 (gif_clear_image, gif_load, imagemagick_load_image)
4042 (gs_clear_image, gs_load): Callers changed.
4044 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4046 * buffer.h: Include <time.h>, for time_t.
4047 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4049 Fix minor problems found by static checking.
4051 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4053 Make identifiers static if they are not used in other modules.
4054 * data.c (Qcompiled_function, Qframe, Qvector):
4055 * image.c (QimageMagick, Qsvg):
4056 * minibuf.c (Qmetadata):
4057 * window.c (resize_window_check, resize_root_window): Now static.
4058 * window.h (resize_window_check, resize_root_window): Remove decls.
4060 * window.c (window_deletion_count, delete_deletable_window):
4062 (window_body_lines): Now static.
4063 (Fdelete_other_windows_internal): Mark vars as initialized.
4064 Make sure 'resize_failed' is initialized.
4065 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4066 (resize_window_apply): Remove unused local.
4067 * window.h (delete_deletable_window): Remove decl.
4069 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4070 (imagemagick_load_image): Fix pointer signedness problem by changing
4071 last arg from unsigned char * to char *. All uses changed.
4072 Also, fix a local for similar reasons.
4073 Remove unused locals. Remove locals to avoid shadowing.
4074 (fn_rsvg_handle_free): Remove; unused.
4075 (svg_load, svg_load_image): Fix pointer signedness problem.
4076 (imagemagick_load_image): Don't use garbage pointer image_wand.
4078 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4080 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4082 * image.c (gif_load): Fix omitted cast error introduced by
4085 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4087 * window.h (resize_proportionally, orig_total_lines)
4088 (orig_top_line): Remove from window structure.
4089 (set_window_height, set_window_width, change_window_heights)
4090 (Fdelete_window): Remove prototypes.
4091 (resize_frame_windows): Remove duplicate declaration.
4093 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4095 * window.h (resize_frame_windows, resize_window_check)
4096 (delete_deletable_window, resize_root_window)
4097 (resize_frame_windows): Declare prototypes.
4099 * window.c (resize_window_apply): Make definition be "static" to
4100 match the prototype.
4102 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4104 * window.c: Remove declarations of Qwindow_size_fixed,
4105 window_min_size_1, window_min_size_2, window_min_size,
4106 size_window, window_fixed_size_p, enlarge_window, delete_window.
4107 Remove static from declaration of Qdelete_window, it's
4108 temporarily needed by Fbury_buffer.
4109 (replace_window): Don't assign orig_top_line and
4111 (Fdelete_window, delete_window): Remove. Window deletion is
4112 handled by window.el.
4113 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4114 Replace Fdelete_window calls with calls to Qdelete_window.
4115 (Fdelete_other_windows): Remove. Deleting other windows is
4116 handled by window.el.
4117 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4118 handled in window.el.
4119 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4120 Window minimum sizes are handled in window.el.
4121 (shrink_windows, size_window, set_window_height)
4122 (set_window_width, change_window_heights, window_height)
4123 (window_width, CURBEG, CURSIZE, enlarge_window)
4124 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4125 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4126 handled in window.el.
4127 (make_dummy_parent): Rename to make_parent_window and give it a
4128 second argument horflag.
4129 (make_window): Don't set resize_proportionally any more.
4130 (Fsplit_window): Remove. Windows are split in window.el.
4131 (save_restore_action, save_restore_orig_size)
4132 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4133 Resize mini windows in window.el.
4134 (grow_mini_window, shrink_mini_window): Implement by calling
4135 Qresize_root_window_vertically, resize_window_check and
4136 resize_window_apply.
4137 (saved_window, Fset_window_configuration, save_window_save):
4138 Do not handle orig_top_line, orig_total_lines, and
4139 resize_proportionally.
4140 (window_min_height, window_min_width): Move to window.el.
4141 (keys_of_window): Move bindings for delete-other-windows,
4142 split-window, delete-window and enlarge-window to window.el.
4144 * buffer.c: Temporarily extern Qdelete_window.
4145 (Fbury_buffer): Temporarily call Qdelete_window instead of
4146 Fdelete_window (Fbury_buffer will move to window.el soon).
4148 * frame.c (set_menu_bar_lines_1): Remove code handling
4149 orig_top_line and orig_total_lines.
4151 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4152 set_window_height but set heights directly.
4153 (change_frame_size_1): Use resize_frame_windows.
4155 * xdisp.c (init_xdisp): Don't use set_window_height but set
4158 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4159 Use resize_frame_windows instead of change_window_heights and run
4160 run_window_configuration_change_hook.
4162 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4163 instead of change_window_heights and run
4164 run_window_configuration_change_hook.
4166 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4168 * window.c (replace_window): Rename second argument REPLACEMENT to
4169 NEW. New third argument SETFLAG. Rewrite.
4170 (delete_window, make_dummy_parent): Call replace_window with
4172 (window_list_1): Move down in code.
4173 (run_window_configuration_change_hook): Move set_buffer part
4174 before select_frame_norecord part in order to unwind correctly.
4175 Rename count1 to count.
4176 (recombine_windows, delete_deletable_window, resize_root_window)
4177 (Fdelete_other_windows_internal)
4178 (Frun_window_configuration_change_hook, make_parent_window)
4179 (resize_window_check, resize_window_apply, Fresize_window_apply)
4180 (resize_frame_windows, Fsplit_window_internal)
4181 (Fdelete_window_internal, Fresize_mini_window_internal):
4183 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4185 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4187 * window.h (window): Add some new members to window structure -
4188 normal_lines, normal_cols, new_total, new_normal, clone_number,
4189 splits, nest, prev_buffers, next_buffers.
4190 (WINDOW_TOTAL_SIZE): Move here from window.c.
4191 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4193 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4195 (make_dummy_parent): Set new members of windows structure.
4196 (make_window): Move down in code. Handle new members of window
4198 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4199 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4200 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4201 (Fset_window_prev_buffers, Fwindow_next_buffers)
4202 (Fset_window_next_buffers, Fset_window_clone_number):
4204 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4205 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4207 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4208 Argument WINDOW can be now internal window too.
4209 (Fwindow_use_time): Move up in code.
4210 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4212 (Fset_window_configuration, saved_window)
4213 (Fcurrent_window_configuration, save_window_save): Handle new
4214 members of window structure.
4215 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4216 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4217 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4218 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4219 Qget_mru_window, Qresize_root_window,
4220 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4221 Qauto_buffer_name; staticpro them.
4223 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4225 * window.c (Fwindow_total_size, Fwindow_left_column)
4226 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4227 (Fwindow_list_1): New functions.
4228 (window_box_text_cols): Replace with window_body_cols.
4229 (Fwindow_width, Fscroll_left, Fscroll_right):
4230 Use window_body_cols instead of window_box_text_cols.
4231 (delete_window, Fset_window_configuration):
4232 Call delete_all_subwindows with window as argument.
4233 (delete_all_subwindows): Take a window as argument and not a
4235 (window_loop): Remove handling of GET_LRU_WINDOW and
4237 (Fget_lru_window, Fget_largest_window): Move to window.el.
4239 * window.h: Extern window_body_cols instead of
4240 window_box_text_cols. delete_all_subwindows now takes a
4241 Lisp_Object as argument.
4243 * indent.c (compute_motion, Fcompute_motion):
4244 Use window_body_cols instead of window_box_text_cols.
4246 * frame.c (delete_frame): Call delete_all_subwindows with root
4249 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4251 * fns.c (Fputhash): Document return value.
4253 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4255 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4257 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4259 Cons<->int and similar integer overflow fixes (Bug#8794).
4261 Check for overflow when converting integer to cons and back.
4262 * charset.c (Fdefine_charset_internal, Fdecode_char):
4263 Use cons_to_unsigned to catch overflow.
4264 (Fencode_char): Use INTEGER_TO_CONS.
4265 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4266 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4267 * data.c (long_to_cons, cons_to_long): Remove.
4268 (cons_to_unsigned, cons_to_signed): New functions.
4269 These signal an error for invalid or out-of-range values.
4270 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4271 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4272 * font.c (Ffont_variation_glyphs):
4273 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4274 * lisp.h: Include <intprops.h>.
4275 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4276 (cons_to_signed, cons_to_unsigned): New decls.
4277 (long_to_cons, cons_to_long): Remove decls.
4278 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4279 (Fprimitive_undo): Use CONS_TO_INTEGER.
4280 * xfns.c (Fx_window_property): Likewise.
4281 * xselect.c: Include <limits.h>.
4282 (x_own_selection, selection_data_to_lisp_data):
4283 Use INTEGER_TO_CONS.
4284 (x_handle_selection_request, x_handle_selection_clear)
4285 (x_get_foreign_selection, Fx_disown_selection_internal)
4286 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4287 (lisp_data_to_selection_data): Use cons_to_unsigned.
4288 (x_fill_property_data): Use cons_to_signed.
4289 Report values out of range.
4291 Check for buffer and string overflow more precisely.
4292 * buffer.h (BUF_BYTES_MAX): New macro.
4293 * lisp.h (STRING_BYTES_MAX): New macro.
4294 * alloc.c (Fmake_string):
4295 * character.c (string_escape_byte8):
4296 * coding.c (coding_alloc_by_realloc):
4297 * doprnt.c (doprnt):
4298 * editfns.c (Fformat):
4300 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4301 since they may not be the same number.
4302 * editfns.c (Finsert_char):
4303 * fileio.c (Finsert_file_contents):
4304 Likewise for BUF_BYTES_MAX.
4306 * image.c: Use ptrdiff_t, not int, for sizes.
4307 (slurp_file): Switch from int to ptrdiff_t.
4309 (slurp_file): Check that file size fits in both size_t (for
4310 malloc) and ptrdiff_t (for sanity and safety).
4312 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4313 if b->modtime has its maximal value.
4315 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4317 Don't assume time_t can fit into int.
4318 * buffer.h (struct buffer.modtime): Now time_t, not int.
4319 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4320 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4322 Minor fixes for signed vs unsigned integers.
4323 * character.h (MAYBE_UNIFY_CHAR):
4324 * charset.c (maybe_unify_char):
4325 * keyboard.c (read_char, reorder_modifiers):
4326 XINT -> XFASTINT, since the integer must be nonnegative.
4327 * ftfont.c (ftfont_spec_pattern):
4328 * keymap.c (access_keymap, silly_event_symbol_error):
4329 XUINT -> XFASTINT, since the integer must be nonnegative.
4330 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4331 since it makes no difference and we prefer signed.
4332 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4333 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4336 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4338 * window.h (Fwindow_frame): Declare.
4340 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4342 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4343 (SPARE_MEMORY): Always define.
4344 (LARGE_REQUEST): Remove.
4345 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4347 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4349 * lisp.h: Move EXFUNS for Fframe_root_window,
4350 Fframe_first_window and Fset_frame_selected_window to window.h.
4352 * window.h: Move EXFUNS for Fframe_root_window,
4353 Fframe_first_window and Fset_frame_selected_window here from
4356 * frame.c (Fwindow_frame, Fframe_first_window)
4357 (Fframe_root_window, Fframe_selected_window)
4358 (Fset_frame_selected_window): Move to window.c.
4359 (Factive_minibuffer_window): Move to minibuf.c.
4360 (Fother_visible_frames_p): New function.
4362 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4364 * window.c (decode_window, decode_any_window): Move up in code.
4365 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4366 (inhibit_frame_unsplittable): Remove unused variable.
4367 (Fwindow_buffer): Move up and rewrite doc-string.
4368 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4369 (Fwindow_prev): New functions.
4370 (Fwindow_frame): Move here from frame.c. Accept any window as
4372 (Fframe_root_window, Fframe_first_window)
4373 (Fframe_selected_window): Move here from frame.c. Accept frame
4374 or arbitrary window as argument. Update doc-strings.
4375 (Fminibuffer_window): Move up in code.
4376 (Fwindow_minibuffer_p): Move up in code and simplify.
4377 (Fset_frame_selected_window): Move here from frame.c.
4379 (Fselected_window, select_window, Fselect_window): Move up in
4380 code. Minor doc-string fixes.
4382 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4384 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4385 Do not assume that spare memory exists; that assumption is valid
4386 only if SYSTEM_MALLOC.
4387 (LARGE_REQUEST): New macro, so that the issue of large requests
4388 is separated from the issue of spare memory.
4390 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4392 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4395 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4397 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4400 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4402 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4404 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4406 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4407 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4409 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4411 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4413 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4415 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4416 (x_clipboard_manager_save): Add return value.
4417 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4419 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4420 Obey Vx_select_enable_clipboard_manager. Catch errors in
4421 x_clipboard_manager_save (Bug#8779).
4422 (Vx_select_enable_clipboard_manager): New variable.
4423 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4425 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4427 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4429 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4431 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4432 in the current matrix if keep_current_p is non-zero.
4434 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4436 * bidi.c (bidi_level_of_next_char): Fix last change.
4438 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4440 Support bidi reordering of text covered by display properties.
4442 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4443 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4444 (bidi_cache_search, bidi_cache_iterator_state)
4445 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4446 (bidi_level_of_next_char, bidi_move_to_visually_next):
4447 Support character positions inside a run of characters covered by a
4449 (bidi_paragraph_init, bidi_resolve_explicit_1)
4450 (bidi_level_of_next_char): Call bidi_fetch_char and
4451 bidi_fetch_char_advance instead of FETCH_CHAR and
4453 (bidi_init_it): Initialize new members.
4454 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4456 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4457 instead of using explicit *_CHAR codes.
4458 (bidi_resolve_explicit, bidi_resolve_weak):
4459 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4460 bidirectional text is supported only in multibyte buffers.
4461 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4462 it to initialize the frame_window_p member of struct bidi_it.
4463 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4464 (bidi_resolve_explicit, bidi_resolve_weak)
4465 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4466 bidi_it->nchars is non-positive.
4467 (bidi_level_of_next_char): Don't try to lookup the cache for the
4468 next/previous character if nothing is cached there yet, or if we
4469 were just reseat()'ed to a new position.
4471 * xdisp.c (set_cursor_from_row): Set start and stop points
4472 according to the row's direction when priming the loop that looks
4473 for the glyph on which to display cursor.
4474 (single_display_spec_intangible_p): Function deleted.
4475 (display_prop_intangible_p): Reimplement to call
4476 handle_display_spec instead of single_display_spec_intangible_p.
4477 Accept 3 additional arguments needed by handle_display_spec.
4478 This fixes incorrect cursor motion across display property with complex
4479 values: lists, `(when COND...)' forms, etc.
4480 (single_display_spec_string_p): Support property values that are
4481 lists with the argument STRING its top-level element.
4482 (display_prop_string_p): Fix the condition for processing a
4483 property that is a list to be consistent with handle_display_spec.
4484 (handle_display_spec): New function, refactored from the
4485 last portion of handle_display_prop.
4486 (compute_display_string_pos): Accept additional argument
4487 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4488 value of a `display' property is a "replacing spec".
4489 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4490 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4491 the display property, but just return a value indicating whether
4492 the display property will replace the characters it covers.
4493 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4494 frame_window_p members of struct bidi_it.
4495 (compute_display_string_pos, compute_display_string_end):
4497 (push_it): Accept second argument POSITION, where pop_it should
4498 jump to continue iteration.
4499 (reseat_1): Initialize bidi_it.disp_pos.
4501 * keyboard.c (adjust_point_for_property): Adjust the call to
4502 display_prop_intangible_p to its new signature.
4504 * dispextern.h (struct bidi_it): New member frame_window_p.
4505 (bidi_init_it): Update prototypes.
4506 (display_prop_intangible_p): Update prototype.
4507 (compute_display_string_pos, compute_display_string_end):
4509 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4512 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4514 Malloc failure behavior now depends on size of allocation.
4515 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4516 * lisp.h: Change signatures accordingly.
4517 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4518 All callers changed. (Bug#8762)
4520 * gnutls.c: Use Emacs's memory allocators.
4521 Without this change, the gnutls library would invoke malloc etc.
4522 directly, which causes problems on non-SYNC_INPUT hosts, and which
4523 runs afoul of improving memory_full behavior. (Bug#8761)
4524 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4525 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4526 xfree instead of the default malloc, realloc, free.
4527 (Fgnutls_boot): No need to check for memory allocation failure,
4528 since xmalloc does that for us.
4530 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4531 * category.c (hash_get_category_set):
4532 * ccl.c (ccl_driver):
4533 * charset.c (Fdefine_charset_internal):
4534 * charset.h (struct charset.hash_index):
4535 * composite.c (get_composition_id, gstring_lookup_cache)
4536 (composition_gstring_put_cache):
4537 * composite.h (struct composition.hash_index):
4538 * dispextern.h (struct image.hash):
4539 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4540 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4541 (hashfn_equal, hashfn_user_defined, make_hash_table)
4542 (maybe_resize_hash_table, hash_lookup, hash_put)
4543 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4544 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4545 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4546 * image.c (make_image, search_image_cache, lookup_image)
4547 (xpm_put_color_table_h):
4548 * lisp.h (struct Lisp_Hash_Table):
4549 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4550 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4551 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4552 * alloc.c (allocate_vectorlike):
4553 Check for overflow in vector size calculations.
4554 * ccl.c (ccl_driver):
4555 Check for overflow when converting EMACS_INT to int.
4556 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4557 need to be updated by these changes.
4558 * fns.c (make_hash_table, maybe_resize_hash_table):
4559 Check for integer overflow with large hash tables.
4560 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4561 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4562 (SXHASH_REDUCE): New macro.
4563 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4564 Use it instead of discarding useful hash info with large hash values.
4565 (sxhash_float): New function.
4566 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4567 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4568 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4569 Rewrite to use FIXNUM_BITS, as this simplifies things.
4570 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4571 Adjust signatures to match updated version of code.
4572 (consing_since_gc): Now EMACS_INT, since a single hash table can
4573 use more than INT_MAX bytes.
4575 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4577 Make it possible to build with GCC-4.6+ -O2 -flto.
4579 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4581 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4583 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4584 Call minibuffer-inactive-mode.
4586 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4588 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4589 Update dependencies.
4591 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4593 * data.c (init_data): Remove code for UTS, this system is not
4596 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4598 Don't force ./temacs to start in terminal mode.
4600 * frame.c (make_initial_frame): Initialize faces in all cases, not
4601 only when CANNOT_DUMP is defined.
4602 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4604 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4606 * dispnew.c (add_window_display_history): Use const for the string
4607 pointer. Remove declaration, not needed.
4609 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4611 Use 'inline', not 'INLINE'.
4612 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4613 * alloc.c, fontset.c (INLINE): Remove.
4614 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4615 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4616 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4617 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4618 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4620 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4622 Make it possible to run ./temacs.
4624 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4625 syms_of_callproc does the same thing. Remove test for
4626 "initialized", do it in the caller.
4627 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4629 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4631 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4632 (read_minibuf): Use get_minibuffer.
4633 (syms_of_minibuf): Use DEFSYM.
4634 (Qmetadata): New var.
4635 * data.c (Qbuffer): Don't make it static.
4636 (syms_of_data): Use DEFSYM.
4638 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4640 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4641 (CCL_CODE_MIN): New macro.
4643 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4645 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4647 * eval.c (Qdebug): Now static.
4648 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4649 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4650 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4652 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4654 * image.c: Various fixes to ImageMagick code comments.
4655 (Fimagemagick_types): Doc fix.
4657 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4659 Minor fixes prompted by GCC 4.6.0 warnings.
4661 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4663 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4664 (x_clipboard_manager_save_all): Move extern decl to ...
4665 * xterm.h: ... here, so that it can be checked for consistency.
4667 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4669 * xselect.c (x_clipboard_manager_save_frame)
4670 (x_clipboard_manager_save_all): New functions.
4671 (Fx_clipboard_manager_save): Lisp function deleted.
4673 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4674 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4676 * xterm.h: Update prototype.
4678 2011-05-28 William Xu <william.xwl@gmail.com>
4680 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4683 2011-05-28 Jim Meyering <meyering@redhat.com>
4685 Avoid a sign-extension bug in crypto_hash_function.
4686 * fns.c (to_uchar): Define.
4687 (crypto_hash_function): Use it to convert some newly-signed
4688 variables to unsigned, to avoid sign-extension bugs. For example,
4689 without this change, (md5 "truc") would evaluate to
4690 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4691 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4692 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4694 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4696 Integer overflow fixes.
4698 * dbusbind.c: Serial number integer overflow fixes.
4699 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4700 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4701 to hold a serial number that is too large for a fixnum.
4702 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4703 Check for serial numbers out of range. Decode any serial number
4704 that was so large that it became a float. (Bug#8722)
4706 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4707 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4708 Use XFASTINT rather than XUINT when numbers are nonnegative.
4709 (xd_append_arg, Fdbus_method_return_internal):
4710 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4711 arguments, check that Lisp number is nonnegative, rather than
4712 silently wrapping negative numbers around. (Bug#8722)
4713 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4716 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4718 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4720 ccl: add integer overflow checks
4721 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4722 (IN_INT_RANGE): New macros.
4723 (ccl_driver): Use them to check for integer overflow when
4724 decoding a CCL program. Many of the new checks are whether XINT (x)
4725 fits in int; it doesn't always, on 64-bit hosts. The new version
4726 doesn't catch all possible integer overflows, but it's an
4727 improvement. (Bug#8719)
4729 * alloc.c (make_event_array): Use XINT, not XUINT.
4730 There's no need for unsigned here.
4732 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4733 This follows up to the 2011-05-06 change that substituted uintptr_t
4734 for EMACS_INT. This case wasn't caught back then.
4736 Rework Fformat to avoid integer overflow issues.
4737 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4738 now (part of C89). Include <verify.h>.
4739 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4740 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4741 (Fformat): Avoid the prepass trying to compute sizes; it was only
4742 approximate and thus did not catch overflow reliably. Instead, walk
4743 through the format just once, formatting and computing sizes as we go,
4744 checking for integer overflow at every step, and allocating a larger
4745 buffer as needed. Keep track separately whether the format is
4746 multibyte. Keep only the most-recently calculated precision, rather
4747 than them all. Record whether each argument has been converted to
4748 string. Use EMACS_INT, not int, for byte and char and arg counts.
4749 Support field widths and precisions larger than INT_MAX. Avoid
4750 sprintf's undefined behavior with conversion specifications such as %#d
4751 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4752 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4753 formatting out-of-range floating point numbers with int
4756 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4758 * data.c: Avoid integer truncation in expressions involving floats.
4759 * data.c: Include <intprops.h>.
4760 (arith_driver): When there's an integer overflow in an expression
4761 involving floating point, convert the integers to floating point
4762 so that the resulting value does not suffer from catastrophic
4763 integer truncation. For example, on a 64-bit host (* 4
4764 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4765 Do not rely on undefined behavior after integer overflow.
4767 merge count_size_as_multibyte, parse_str_to_multibyte
4768 * character.c, character.h (count_size_as_multibyte):
4769 Rename from parse_str_to_multibyte; all uses changed.
4770 Check for integer overflow.
4771 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4772 since it's now a duplicate of the other. This is more of
4773 a character than a buffer op, so better that it's in character.c.
4774 * fns.c, print.c: Adjust to above changes.
4776 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4778 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4780 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4782 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4783 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4784 (x_clipboard_manager_save): Now static.
4785 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4787 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4788 (crypto_hash_function): Now static.
4789 Fix pointer signedness problems. Avoid unnecessary initializations.
4791 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4793 * termhooks.h (Vselection_alist): Make it terminal-local.
4795 * terminal.c (create_terminal): Initialize it.
4797 * xselect.c: Support for clipboard managers.
4798 (Vselection_alist): Move to termhooks.h as terminal-local var.
4799 (LOCAL_SELECTION): New macro.
4800 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4801 (symbol_to_x_atom): Remove gratuitous arg.
4802 (x_handle_selection_request, lisp_data_to_selection_data)
4803 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4804 (x_own_selection, x_get_local_selection, x_convert_selection):
4805 New arg, specifying work frame. Use terminal-local Vselection_alist.
4806 (some_frame_on_display): Delete unused function.
4807 (Fx_own_selection_internal, Fx_get_selection_internal)
4808 (Fx_disown_selection_internal, Fx_selection_owner_p)
4809 (Fx_selection_exists_p): New optional frame arg.
4810 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4811 (x_handle_selection_clear): Don't treat other terminals with the
4812 same keyboard specially. Use the terminal-local Vselection_alist.
4813 (x_clear_frame_selections): Use Frun_hook_with_args.
4815 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4817 * xterm.h: Add support for those atoms.
4819 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4821 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4822 (converted_selections, conversion_fail_tag): New global variables.
4823 (x_selection_request_lisp_error): Free the above.
4824 (x_get_local_selection): Remove unnecessary code.
4825 (x_reply_selection_request): Args changed; handle arbitrary array
4826 of converted selections stored in converted_selections.
4827 Separate the XChangeProperty and SelectionNotify steps.
4828 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4829 (x_convert_selection): New function.
4830 (x_handle_selection_event): Simplify.
4831 (x_get_foreign_selection): Don't ignore incoming requests while
4832 waiting for an answer; this will fail when we implement
4833 SAVE_TARGETS, and seems unnecessary anyway.
4834 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4835 (Vx_sent_selection_functions): Doc fix.
4837 2011-05-26 Leo Liu <sdl.web@gmail.com>
4839 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4841 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4843 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4845 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4846 for fringe update if it has periodic bitmap.
4847 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4848 and fringe_bitmap_periodic_p.
4850 * fringe.c (get_fringe_bitmap_data): New function.
4851 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4852 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4853 row. Mark glyph row for fringe update if periodicity changed.
4855 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4856 for fringe update unless it has periodic bitmap.
4858 2011-05-25 Kenichi Handa <handa@m17n.org>
4860 * xdisp.c (get_next_display_element): Set correct it->face_id for
4861 a static composition.
4863 2011-05-24 Leo Liu <sdl.web@gmail.com>
4866 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4868 * fns.c (crypto_hash_function, Fsha1): New function.
4869 (Fmd5): Use crypto_hash_function.
4870 (syms_of_fns): Add Ssha1.
4872 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4874 * gnutls.c: Remove unused macros.
4875 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4876 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4877 Remove macros that are defined and never used.
4878 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4880 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4882 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4883 (Fx_get_selection_internal): Minor cleanup.
4884 (Fx_own_selection_internal): Rename arguments for consistency with
4887 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4889 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4891 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4893 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4895 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4897 * dispnew.c (scrolling_window): Don't exclude the case that the
4898 last enabled row in the desired matrix touches the bottom boundary.
4900 2011-05-21 Glenn Morris <rgm@gnu.org>
4902 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4903 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4904 and add some more files.
4906 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4908 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4909 report_file_error introduced by the change from 2011-05-07.
4911 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4913 * systime.h (Time): Define only if emacs is defined.
4914 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4915 where the include path doesn't have X11/X.h by default. See
4916 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4918 2011-05-20 Kenichi Handa <handa@m17n.org>
4920 * composite.c (find_automatic_composition): Fix previous change.
4922 2011-05-20 Glenn Morris <rgm@gnu.org>
4924 * lisp.mk: New file, split from Makefile.in.
4925 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4926 (shortlisp): Remove.
4927 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4929 2011-05-19 Glenn Morris <rgm@gnu.org>
4931 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4932 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4933 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4934 (lisp): Set the order to that of loadup.el.
4935 (shortlisp): Make it a copy of $lisp.
4936 (SOME_MACHINE_LISP): Remove.
4937 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4938 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4940 2011-05-18 Kenichi Handa <handa@m17n.org>
4942 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4943 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4944 (find_automatic_composition): Mostly rewrite for efficiency.
4946 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4948 * makefile.w32-in: Update dependencies.
4950 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4952 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4953 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4955 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4957 Fix some integer overflow issues, such as string length overflow.
4959 * insdel.c (count_size_as_multibyte): Check for string overflow.
4961 * character.c (lisp_string_width): Check for string overflow.
4962 Use EMACS_INT, not int, for string indexes and lengths; in
4963 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4964 the resulting string length overflows an EMACS_INT; instead,
4965 report a string overflow if no precision given. When checking for
4966 precision exhaustion, use a check that cannot possibly have
4967 integer overflow. (Bug#8675)
4968 * character.h (lisp_string_width): Adjust to new signature.
4970 * alloc.c (string_overflow): New function.
4971 (Fmake_string): Use it. This doesn't change behavior, but saves
4972 a few bytes and will simplify future changes.
4973 * character.c (string_escape_byte8): Likewise.
4974 * lisp.h (string_overflow): New decl.
4976 Fixups, following up to the user-interface timestamp change.
4977 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4978 for UI timestamps, instead of unsigned long.
4979 * msdos.c (mouse_get_pos): Likewise.
4980 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4981 * w32gui.h (Time): Define by including "systime.h" rather than by
4982 declaring it ourselves. (Bug#8664)
4984 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4985 * image.c (clear_image_cache): Likewise.
4987 * term.c (term_mouse_position): Don't assume time_t wraparound.
4989 Be more systematic about user-interface timestamps.
4990 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4991 and sometimes 'EMACS_UINT', to represent these timestamps.
4992 This change causes it to use 'Time' uniformly, as that's what X uses.
4993 This makes the code easier to follow, and makes it easier to catch
4994 integer overflow bugs such as Bug#8664.
4995 * frame.c (Fmouse_position, Fmouse_pixel_position):
4996 Use Time, not unsigned long, for user-interface timestamps.
4997 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4998 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4999 * keyboard.h (last_event_timestamp): Likewise.
5000 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5001 * menu.h (xmenu_show): Likewise.
5002 * term.c (term_mouse_position): Likewise.
5003 * termhooks.h (struct input_event.timestamp): Likewise.
5004 (struct terminal.mouse_position_hook): Likewise.
5005 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5006 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5007 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5008 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5010 * menu.h, termhooks.h: Include "systime.h", for Time.
5012 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5013 Don't assume that the difference between two unsigned long values
5014 can fit into an integer. At this point, we know button_down_time
5015 <= event->timestamp, so the difference must be nonnegative, so
5016 there's no need to cast the result if double-click-time is
5017 nonnegative, as it should be; check that it's nonnegative, just in
5018 case. This bug is triggered when events are more than 2**31 ms
5019 apart (about 25 days). (Bug#8664)
5021 * xselect.c (last_event_timestamp): Remove duplicate decl.
5022 (x_own_selection): Remove needless cast to unsigned long.
5024 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5025 that always fit in int. Use a sentinel instead of a counter, to
5026 avoid a temp and to allay GCC's concerns about possible int overflow.
5027 * frame.h (struct frame): Use int for menu_bar_items_used
5028 instead of EMACS_INT, since it always fits in int.
5030 * menu.c (grow_menu_items): Check for int overflow.
5032 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5034 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5035 Before, the code was not consistent. These values cannot exceed
5036 2**31 - 1 so there's no need to make them unsigned.
5037 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5038 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5039 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5041 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5043 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5044 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5045 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5046 presumably because the widths might not match.
5048 * window.c (size_window): Avoid needless test at loop start.
5050 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5052 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5054 2011-05-12 Drew Adams <drew.adams@oracle.com>
5056 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5058 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5060 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5061 `width' to `bar_area_x' and `bar_area_width', respectively.
5062 (x_scroll_run): Take account of fringe background extension.
5064 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5065 Rename local vars `left' and `width' to `bar_area_x' and
5066 `bar_area_width', respectively.
5067 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5068 background extension.
5070 2011-05-10 Jim Meyering <meyering@redhat.com>
5072 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5074 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5076 * image.c (Finit_image_library): Return t for built-in image types,
5077 like pbm and xbm. (Bug#8640)
5079 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5081 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5083 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5085 * w32console.c (Fset_screen_color): Doc fix.
5086 (Fget_screen_color): New function.
5087 (syms_of_ntterm): Defsubr it.
5089 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5090 unlink the temporary file if Fcall_process didn't create it in the
5092 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5093 child process will be redirected to a file specified with `:file'.
5094 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5095 cue to call_process_cleanup not to close that handle.
5097 2011-05-07 Ben Key <bkey76@gmail.com>
5099 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5100 one of two shell specific rules, either bootstrap-temacs-CMD or
5101 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5102 to the previous implementation of the bootstrap-temacs rule.
5103 The bootstrap-temacs-CMD rule is similar to the previous
5104 implementation of the bootstrap-temacs rule except that it
5105 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5108 These changes, along with some changes to nt/configure.bat,
5109 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5110 earlier fix to add support for --cflags and --ldflags options
5111 that include quotes so that it works whether make uses cmd or
5114 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5116 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5117 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5119 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5120 a string. Handle both cases.
5121 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5122 (Fdbus_register_method): Use Qinvalid_function.
5124 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5126 * makefile.w32-in: Update dependencies.
5127 (LISP_H): Add inttypes.h and stdin.h.
5128 (PROCESS_H): Add unistd.h.
5130 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5132 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5133 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5135 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5137 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5139 * term.c (vfatal): Remove stray call to va_end.
5140 It's not needed and the C Standard doesn't allow it here anyway.
5142 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5143 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5145 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5148 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5150 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5152 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5154 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5156 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5158 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5159 * charset.c (Fdefine_charset_internal): Don't initialize
5160 charset.code_space[15]. The value was garbage, on hosts with
5161 32-bit int (Bug#8600).
5163 * lread.c (read_integer): Be more consistent with string-to-number.
5164 Use string_to_number to do the actual conversion; this avoids
5165 rounding errors and fixes some other screwups. Without this fix,
5166 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5167 (digit_to_number): Move earlier, for benefit of read_integer.
5168 Return -1 if the digit is out of range for the base, -2 if it is
5169 not a digit in any supported base. (Bug#8602)
5171 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5173 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5174 to match comment at start of function. This also removes a
5175 GCC warning about overflow in a 32+64-bit port.
5177 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5179 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5180 Reported by Stefan Monnier in
5181 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5182 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5183 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5185 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5186 (EMACS_UINTPTR): Likewise, with uintptr_t.
5188 * lisp.h: Prefer 64-bit EMACS_INT if available.
5189 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5190 on 32-bit hosts that have 64-bit int, so that they can access
5192 However, temporarily disable this change unless the temporary
5193 symbol WIDE_EMACS_INT is defined.
5195 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5197 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5198 This removes an assumption that EMACS_INT and long are the same
5199 width as pointers. The assumption is true for Emacs porting targets
5200 now, but we want to make other targets possible.
5201 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5202 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5203 In the rest of the code, change types of integers that hold casted
5204 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5205 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5206 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5207 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5208 No need to cast type when ORing.
5209 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5210 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5211 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5212 assume EMACS_INT is the same width as char *.
5213 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5214 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5215 Remove no-longer-needed casts.
5216 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5217 (xg_tool_bar_help_callback, xg_make_tool_item):
5218 Use EMACS_INTPTR to hold an integer
5219 that will be cast to void *; this can avoid a GCC warning
5220 if EMACS_INT is not the same width as void *.
5221 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5222 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5223 (current_message_1, set_message_1):
5224 Use a local to convert to proper width without a cast.
5225 * xmenu.c (dialog_selection_callback): Likewise.
5227 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5228 Also, don't assume VALBITS / RAND_BITS is less than 5,
5229 and don't rely on undefined behavior when shifting a 1 left into
5231 * lisp.h (get_random): Change signature to match.
5233 * lread.c (hash_string): Use size_t, not int, for hash computation.
5234 Normally we prefer signed values; but hashing is special, because
5235 it's better to use unsigned division on hash table sizes so that
5236 the remainder is nonnegative. Also, size_t is the natural width
5237 for hashing into memory. The previous code used 'int', which doesn't
5238 retain enough info to hash well into very large tables.
5239 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5241 * dbusbind.c: Don't possibly lose pointer info when converting.
5242 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5243 Use XPNTR rather than XHASH, so that the high-order bits of
5244 the pointer aren't lost when converting through void *.
5246 * eval.c (Fautoload): Don't double-shift a pointer.
5248 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5250 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5252 * gnutls.c (DEF_GNUTLS_FN):
5253 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5255 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5257 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5260 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5262 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5263 New version that can reserve upto 2GB of heap space.
5265 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5267 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5269 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5271 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5272 `gnutls_certificate_set_x509_key_file'.
5274 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5276 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5277 Update dependencies.
5279 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5281 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5282 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5283 Remove unused parameter `fildes'.
5284 * process.c (read_process_output, send_process): Don't pass it.
5286 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5288 Fix previous change: the library cache is defined in w32.c.
5289 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5290 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5292 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5294 Implement dynamic loading of GnuTLS on Windows.
5296 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5297 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5298 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5301 * gnutls.c (Qgnutls_dll): Define.
5302 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5303 (gnutls_*): Declare function pointers.
5304 (init_gnutls_functions): New function to initialize function pointers.
5305 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5306 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5307 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5308 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5309 (emacs_gnutls_write, emacs_gnutls_read)
5310 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5311 (Fgnutls_available_p): New function.
5312 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5313 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5314 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5316 * image.c: Include w32.h.
5317 (Vimage_type_cache): Delete.
5318 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5319 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5320 (w32_delayed_load): Move to w32.c.
5322 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5324 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5325 (w32_delayed_load): Move from image.c. When loading a library, record
5326 its filename in the :loaded-from property of the library id.
5327 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5328 Initialize and staticpro them.
5329 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5331 * process.c: Include lisp.h before w32.h, not after.
5332 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5333 instead of gnutls_record_check_pending.
5335 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5337 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5339 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5340 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5343 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5345 * xterm.c (x_set_frame_alpha): Do not set property on anything
5346 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5348 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5350 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5352 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5354 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5355 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5356 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5357 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5358 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5359 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5360 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5361 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5362 (Qgnutls_bootprop_callbacks_verify): Make static.
5364 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5366 * callproc.c: Indentation fixup.
5368 * sysdep.c (wait_for_termination_1): Make static.
5369 (wait_for_termination, interruptible_wait_for_termination):
5370 Move after wait_for_termination_1.
5372 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5374 * sysdep.c (interruptible_wait_for_termination): New function
5375 which is like wait_for_termination, but allows keyboard
5378 * callproc.c (Fcall_process): Add (:file "file") as an option for
5380 (Fcall_process_region): Ditto.
5382 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5384 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5385 rather than `XVECTOR (FOO)->size'.
5387 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5388 inttypes.h, as a gnulib replacement is used if it not available in
5391 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5393 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5394 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5395 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5397 * coding.c (coding_alloc_by_realloc): Error out if destination
5398 will grow beyond MOST_POSITIVE_FIXNUM.
5399 (decode_coding_emacs_mule): Abort if there isn't enough place in
5400 charbuf for the composition carryover bytes. Reserve an extra
5401 space for up to 2 characters produced in a loop.
5402 (decode_coding_iso_2022): Abort if there isn't enough place in
5403 charbuf for the composition carryover bytes.
5405 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5407 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5408 aborting when %lld or %lll format is passed.
5409 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5410 %llo or %llx format is passed. (Bug#8545)
5412 * window.c (window_scroll_line_based): Use a marker instead of
5413 simple variables to record original value of point. (Bug#7952)
5415 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5416 produced by %s or %c overflows available buffer space. (Bug#8545)
5418 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5420 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5421 (SIZE_MAX): Move defn after all includes, as they might #define it.
5423 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5425 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5427 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5429 * keyboard.c (Qdelayed_warnings_hook): Define.
5430 (command_loop_1): Run `delayed-warnings-hook'
5431 if Vdelayed_warnings_list is non-nil.
5432 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5433 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5435 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5437 * doprnt.c (doprnt): Don't return value smaller than the buffer
5438 size if the message was truncated. (Bug#8545).
5440 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5442 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5443 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5445 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5447 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5449 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5451 * makefile.w32-in: Update dependencies.
5453 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5455 Improve `doprnt' and its usage. (Bug#8545)
5456 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5457 `format_end'. Remove support for %l as a conversion specifier.
5458 Don't use xrealloc. Improve diagnostics when the %l size modifier
5459 is used. Update the commentary.
5461 * eval.c (verror): Simplify calculation of size_t.
5463 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5466 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5468 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5471 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5473 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5474 This makes this file independent of the recent pseudovector change.
5476 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5478 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5480 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5481 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5482 Remove unused local.
5483 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5485 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5486 GCC 4.6.0 optimizes based on type-based alias analysis.
5487 For example, if b is of type struct buffer * and v of type struct
5488 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5489 != &v->size, and therefore "v->size = 1; b->size = 2; return
5490 v->size;" must therefore return 1. This assumption is incorrect
5491 for Emacs, since it type-puns struct Lisp_Vector * with many other
5492 types. To fix this problem, this patch adds a new type struct
5493 vectorlike_header that documents the constraints on layout of vectors
5494 and pseudovectors, and helps optimizing compilers not get fooled
5495 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5496 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5497 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5499 (XSETPVECTYPE): Rewrite in terms of new macro.
5500 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5501 This is a bit clearer, and further avoids the possibility of
5502 undesirable aliasing.
5503 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5504 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5505 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5506 since Lisp_Subr is a special case (no "next" field).
5507 (ASIZE): Now uses header.size rather than size.
5508 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5509 to avoid the hassle of writing XVECTOR (foo)->header.size.
5510 (struct vectorlike_header): New type.
5511 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5512 object, to help avoid aliasing.
5513 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5514 (SUBRP): Likewise, since Lisp_Subr is a special case.
5515 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5516 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5517 (struct Lisp_Hash_Table): Combine first two members into a single
5518 struct vectorlike_header member. All uses of "size" and "next" members
5519 changed to be "header.size" and "header.next".
5520 * buffer.h (struct buffer): Likewise.
5521 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5522 * frame.h (struct frame): Likewise.
5523 * process.h (struct Lisp_Process): Likewise.
5524 * termhooks.h (struct terminal): Likewise.
5525 * window.c (struct save_window_data, struct saved_window): Likewise.
5526 * window.h (struct window): Likewise.
5527 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5528 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5529 * buffer.c (init_buffer_once): Likewise.
5530 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5532 * process.c (Fformat_network_address): Use local var for size,
5535 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5537 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5538 * data.c (atof): Remove decl; no longer used or needed.
5539 (digit_to_number): Move to lread.c.
5540 (Fstring_to_number): Use new string_to_number function, to be
5541 consistent with how the Lisp reader treats infinities and NaNs.
5542 Do not assume that floating-point numbers represent EMACS_INT
5543 without losing information; this is not true on most 64-bit hosts.
5544 Avoid double-rounding errors, by insisting on integers when
5545 parsing non-base-10 numbers, as the documentation specifies.
5546 * lisp.h (string_to_number): New decl, replacing ...
5547 (isfloat_string): Remove.
5548 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5549 (read1): Do not accept +. and -. as integers; this
5550 appears to have been a coding error. Similarly, do not accept
5551 strings like +-1e0 as floating point numbers. Do not report
5552 overflow for integer overflows unless the base is not 10 which
5553 means we have no simple and reliable way to continue.
5554 Break out the floating-point parsing into a new
5555 function string_to_number, so that Fstring_to_number parses
5556 floating point numbers consistently with the Lisp reader.
5557 (digit_to_number): Move here from data.c. Make it static inline.
5558 (E_CHAR, EXP_INT): Remove, replacing with ...
5559 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5560 (string_to_number): New function, replacing isfloat_string.
5561 This function checks for valid syntax and produces the resulting
5562 Lisp float number too. Rework it so that string-to-number
5563 no longer mishandles examples like "1.0e+". Use strtoumax,
5564 so that overflow for non-base-10 numbers is reported only when
5565 there's no portable and simple way to convert to floating point.
5567 * textprop.c (set_text_properties_1): Rewrite for clarity,
5568 and to avoid GCC warning about integer overflow.
5570 * intervals.h (struct interval): Use EMACS_INT for members
5571 where EMACS_UINT might cause problems. See
5572 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5573 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5574 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5576 (offset_intervals): Tell GCC not to worry about length overflow
5577 when negating a negative length.
5579 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5580 (overrun_check_free): Likewise.
5582 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5583 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5586 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5587 (gnutls_make_error): Rename local to avoid shadowing.
5588 (gnutls_emacs_global_deinit): ifdef out; not used.
5589 (Fgnutls_boot): Use const for pointer to readonly storage.
5590 Comment out unused local. Fix pointer signedness problems.
5592 * lread.c (openp): Don't stuff size_t into an 'int'.
5593 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5594 about possible signed overflow.
5596 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5597 (GDK_KEY_g): Don't define if already defined.
5598 (xg_prepare_tooltip): Avoid pointer signedness problem.
5599 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5601 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5602 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5604 * xfns.c (Fx_window_property): Simplify a bit,
5605 to make a bit faster and to avoid GCC 4.6.0 warning.
5606 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5608 * fns.c (internal_equal): Don't assume size_t fits in int.
5610 * alloc.c (compact_small_strings): Tighten assertion a little.
5612 Replace pEd with more-general pI, and fix some printf arg casts.
5613 * lisp.h (pI): New macro, generalizing old pEd macro to other
5614 conversion specifiers. For example, use "...%"pI"d..." rather
5615 than "...%"pEd"...".
5616 (pEd): Remove. All uses replaced with similar uses of pI.
5617 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5618 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5619 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5620 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5621 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5622 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5623 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5625 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5626 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5627 * print.c (safe_debug_print, print_object): Likewise.
5628 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5630 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5631 avoiding the 0 flag, which is not portable.
5632 * process.c (Fmake_network_process): Use pI to avoid cast.
5633 * region-cache.c (pp_cache): Likewise.
5634 * xdisp.c (decode_mode_spec): Likewise.
5635 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5636 behavior on 64-bit hosts with printf arg.
5637 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5638 (x_stop_queuing_selection_requests): Likewise.
5639 (x_get_window_property): Don't truncate byte count to an 'int'
5642 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5643 here, since it parses constructs like leading '-' and spaces,
5644 which are not wanted; and it overflows with large numbers.
5645 Instead, simply match F[0-9]+, which is what is wanted anyway.
5647 * alloc.c: Remove unportable assumptions about struct layout.
5648 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5649 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5650 (allocate_vectorlike, make_pure_vector): Use the new macros,
5651 plus offsetof, to remove unportable assumptions about struct layout.
5652 These assumptions hold on all porting targets that I know of, but
5653 they are not guaranteed, they're easy to remove, and removing them
5654 makes further changes easier.
5656 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5657 This doesn't fix a bug but makes the code clearer.
5658 (string_overrun_cookie): Now const. Use initializers that
5659 don't formally overflow signed char, to avoid warnings.
5660 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5661 can cause Emacs to crash when string overrun checking is enabled.
5662 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5663 multiple of sizeof (EMACS_INT); it need not be, if
5664 alignof(EMACS_INT) < sizeof (EMACS_INT).
5665 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5667 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5669 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5671 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5673 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5674 supposed to be handshaking. (Bug#8556)
5675 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5677 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5679 * lisp.h (Qdebug): List symbol.
5680 * eval.c (Qdebug): Restore global linkage.
5681 * keyboard.c (debug-on-event): New variable.
5682 (handle_user_signal): Break into debugger when debug-on-event
5683 matches the current signal symbol.
5685 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5687 * alloc.c (check_sblock, check_string_bytes)
5688 (check_string_free_list): Convert to standard C.
5690 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5692 * w32.c (emacs_gnutls_push): Fix typo.
5694 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5696 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5697 "cast to pointer from integer of different size".
5699 Improve doprnt and its use in verror. (Bug#8545)
5700 * doprnt.c (doprnt): Document the set of format control sequences
5701 supported by the function. Use SAFE_ALLOCA instead of always
5704 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5705 is one byte too soon. Don't use xrealloc; instead xfree and
5708 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5710 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5713 * gnutls.c: Renamed global_initialized to
5714 gnutls_global_initialized. Added internals for the
5715 :verify-hostname-error, :verify-error, and :verify-flags
5716 parameters of `gnutls-boot' and documented those parameters in the
5717 docstring. Start callback support.
5718 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5719 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5720 on error. Return error code.
5721 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5722 (emacs_gnutls_read): Likewise.
5723 (Fgnutls_boot): Return handshake error code.
5724 (emacs_gnutls_handle_error): New function.
5725 (wsaerror_to_errno): Likewise.
5727 * w32.h (emacs_gnutls_pull): Add prototype.
5728 (emacs_gnutls_push): Likewise.
5730 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5731 (emacs_gnutls_push): Likewise.
5733 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5735 * process.c (wait_reading_process_output): Check if GnuTLS
5736 buffered some data internally if no FDs are set for TLS
5739 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5740 (LIBS): Link to USER_LIBS.
5741 ($(BLD)/gnutls.$(0)): New target.
5743 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5745 * xdisp.c (handle_single_display_spec): Rename the
5746 display_replaced_before_p argument into display_replaced_p, to
5747 make it consistent with the commentary. Fix typos in the
5750 * textprop.c (syms_of_textprop): Remove dead code.
5751 (copy_text_properties): Delete obsolete commentary about an
5752 interface that was deleted long ago. Fix typos in the description
5755 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5756 to changes in oldXMenu/XMenu.h from 2011-04-16.
5757 <menu_help_message, prev_menu_help_message>: Constify.
5758 (IT_menu_make_room): menu->help_text is now `const char **';
5761 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5762 to changes in oldXMenu/XMenu.h from 2011-04-16.
5763 (struct XMenu): Declare `help_text' `const char **'.
5765 * xfaces.c <Qunspecified>: Make extern again.
5767 * syntax.c: Include sys/types.h before including regex.h, as
5770 * doc.c (get_doc_string): Improve the format passed to `error'.
5772 * doprnt.c (doprnt): Improve commentary.
5774 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5776 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5779 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5780 changes in globals.h immediately force recompilation.
5781 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5782 $(CURDIR)/s/ms-w32.h.
5783 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5785 * character.c (Fchar_direction): Function deleted.
5786 (syms_of_character): Don't defsubr it.
5787 <char-direction-table>: Deleted.
5789 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5791 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5792 * doprnt.c: Include limits.h.
5793 (SIZE_MAX): New macro.
5794 (doprnt): Return a size_t value. 2nd arg is now size_t.
5795 Many local variables are now size_t instead of int or unsigned.
5796 Improve overflow protection. Support `l' modifier for integer
5797 conversions. Support %l conversion. Don't assume an EMACS_INT
5798 argument for integer conversions and for %c.
5800 * lisp.h (doprnt): Restore prototype.
5802 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5805 * Makefile.in (base_obj): Add back doprnt.o.
5807 * deps.mk (doprnt.o): Add back prerequisites.
5808 (callint.o): Depend on character.h.
5810 * eval.c (internal_lisp_condition_case): Include the handler
5811 representation in the error message.
5812 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5813 when breaking from the loop.
5815 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5817 * callint.c (Fcall_interactively): When displaying error message
5818 about invalid control letter, pass the character's codepoint, not
5819 a pointer to its multibyte form. Improve display of the character
5820 in octal and display also its hex code.
5822 * character.c (char_string): Use %x to display the (unsigned)
5823 codepoint of an invalid character, to avoid displaying a bogus
5826 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5827 `error', not SYMBOL_NAME itself.
5829 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5830 character arguments to `error'.
5832 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5833 to `error' in error message about FINAL_CHAR argument. Make sure
5834 FINAL_CHAR is a character, and use %c when it is passed as
5835 argument to `error'.
5837 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5839 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5841 * w32.c: Include <time.h>.
5842 (sys_localtime): New function.
5844 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5846 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5848 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5850 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5852 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5855 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5857 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5858 gl_state.e_property when gl_state.object is Qt.
5860 * insdel.c (make_gap_larger): Remove limitation of buffer size
5863 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5865 * xdisp.c (lookup_glyphless_char_display)
5866 (produce_glyphless_glyph): Handle cons cell entry in
5867 glyphless-char-display.
5868 (Vglyphless_char_display): Document it.
5870 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5871 glyphless-char-display.
5873 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5875 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5877 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5879 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5880 definition for no-X builds.
5882 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5884 Static checks with GCC 4.6.0 and non-default toolkits.
5886 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5888 * process.c (keyboard_bit_set): Define only if SIGIO.
5889 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5890 (send_process): Repair possible setjmp clobbering.
5892 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5894 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5896 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5898 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5899 Define only if needed.
5901 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5902 by pacifying GCC about it. Maybe it's time to retire it?
5903 * xfaces.c (USG, __TIMEVAL__): Likewise.
5905 * dispextern.h (struct redisplay_interface): Rename param
5907 * termhooks.h (struct terminal): Likewise.
5908 * xterm.c (xembed_send_message): Likewise.
5910 * insdel.c (make_gap_smaller): Define only if
5911 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5913 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5916 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5917 so that we aren't warned about unused symbols.
5919 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5921 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5923 * xfns.c (x_real_positions): Mark locals as initialized.
5925 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5927 * xterm.c: Fix problems found by static analysis with other toolkits.
5928 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5929 (x_dispatch_event): Declare static if USE_GTK, and
5930 define if USE_GTK || USE_X_TOOLKIT.
5931 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5932 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5933 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5934 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5936 * xmenu.c (menu_help_callback): Pointer type fixes.
5937 Use const pointers when pointing at readonly data. Avoid pointer
5939 (FALSE): Remove unused macro.
5940 (update_frame_menubar): Remove unused decl.
5942 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5944 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5945 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5946 (single_menu_item): Rename local to avoid shadowing.
5948 * keyboard.c (make_lispy_event): Remove unused local var.
5950 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5951 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5953 * bitmaps: Change bitmaps from unsigned char back to the X11
5954 compatible char. Avoid the old compiler warnings about
5955 out-of-range initializers by using, for example, '\xab' rather
5958 * xgselect.c (xgselect_initialize): Check vs interface
5959 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5961 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5963 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5964 to read-only memory.
5966 * fns.c (vector): Remove; this old hack is no longer needed.
5968 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5970 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5972 * xrdb.c (x_load_resources): Omit unused local.
5974 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5975 (x_window): Rename locals to avoid shadowing.
5976 (USG): Use the kludged USG macro, to pacify gcc.
5978 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5979 (x_term_init): Remove local to avoid shadowing.
5981 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5983 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5984 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5986 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5988 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5990 Fix regex.c, syntax.c and friends for buffers > 2GB.
5991 * syntax.h (struct gl_state_s): Declare character position members
5994 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5996 * textprop.c (verify_interval_modification, interval_of):
5997 Declare arguments EMACS_INT.
5999 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6002 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6004 * indent.c (Fvertical_motion): Local variable it_start is now
6007 * regex.c (re_match, re_match_2, re_match_2_internal)
6008 (bcmp_translate, regcomp, regexec, print_double_string)
6009 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6010 (re_compile_pattern, re_exec): Declare arguments and local
6011 variables `size_t' and `ssize_t' and return values `regoff_t', as
6013 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6014 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6015 <compile_stack_type>: `size' and `avail' are now `size_t'.
6017 * regex.h <regoff_t>: Use ssize_t, not int.
6018 (re_search, re_search_2, re_match, re_match_2): Arguments that
6019 specify buffer/string position and length are now ssize_t and
6020 size_t. Return type is regoff_t.
6022 2011-04-16 Ben Key <bkey76@gmail.com>
6024 * nsfont.m: Fixed bugs in ns_get_family and
6025 ns_descriptor_to_entity that were caused by using free to
6026 deallocate memory blocks that were allocated by xmalloc (via
6027 xstrdup). This caused Emacs to crash when compiled with
6028 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6029 --enable-checking=xmallocoverrun). xfree is now used to
6030 deallocate these memory blocks.
6032 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6034 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6036 emacs_write: Accept and return EMACS_INT for sizes.
6037 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6039 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6040 Accept and return EMACS_INT.
6041 (emacs_gnutls_write): Return the number of bytes written on
6043 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6044 (emacs_read, emacs_write): Remove check for negative size, as the
6045 Emacs source code has been audited now.
6046 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6047 (emacs_read, emacs_write): Use it.
6048 * process.c (send_process): Adjust to the new signatures of
6049 emacs_write and emacs_gnutls_write. Do not attempt to store
6050 a byte offset into an 'int'; it might overflow.
6051 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6053 * sound.c: Don't assume sizes fit in 'int'.
6054 (struct sound_device.period_size, alsa_period_size):
6055 Return EMACS_INT, not int.
6056 (struct sound_device.write, vox_write, alsa_write):
6057 Accept EMACS_INT, not int.
6058 (wav_play, au_play): Use EMACS_INT to store sizes and to
6059 record read return values.
6061 2011-04-15 Ben Key <bkey76@gmail.com>
6063 * keyboard.c (Qundefined): Don't declare static since it is used
6065 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6066 static since they are used in nsfont.m.
6068 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6070 * process.c (Qprocessp): Don't declare static.
6071 * lisp.h (Qprocessp): Declare again.
6073 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6075 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6077 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6079 Improve C-level modularity by making more things 'static'.
6081 Don't publish debugger-only interfaces to other modules.
6082 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6083 (verify_bytepos, count_markers): Move decls to the only modules
6085 * region-cache.h (pp_cache): Likewise.
6086 * window.h (check_all_windows): Likewise.
6087 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6089 * sysdep.c (croak): Now static, if
6090 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6091 * syssignal.h (croak): Declare only if not static.
6093 * alloc.c (refill_memory_reserve): Now static if
6094 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6095 * lisp.h (refill_memory_reserve): Declare only if not static.
6097 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6098 Define only if USE_LUCID.
6100 * xrdb.c (x_customization_string, x_rm_string): Now static.
6102 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6103 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6105 * xdisp.c (draw_row_with_mouse_face): Now static.
6106 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6108 * window.h (check_all_windows): Mark externally visible.
6110 * window.c (window_deletion_count): Now static.
6112 * undo.c: Make symbols static if they're not exported.
6113 (last_undo_buffer, last_boundary_position, pending_boundary):
6116 * textprop.c (interval_insert_behind_hooks): Now static.
6117 (interval_insert_in_front_hooks): Likewise.
6119 * term.c: Make symbols static if they're not exported.
6120 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6121 (max_frame_lines, tty_set_terminal_modes):
6122 (tty_reset_terminal_modes, tty_turn_off_highlight):
6123 (get_tty_terminal): Now static.
6124 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6125 * termhooks.h (term_mouse_moveto): Do not declare if
6127 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6128 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6130 * sysdep.c: Make symbols static if they're not exported.
6131 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6133 (sigprocmask_set, full_mask): Remove; unused.
6134 (wait_debugging): Mark as visible.
6135 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6136 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6138 * syntax.c (syntax_temp): Define only if !__GNUC__.
6140 * sound.c (current_sound_device, current_sound): Now static.
6142 * search.c (searchbufs, searchbuf_head): Now static.
6144 * scroll.c (scroll_cost): Remove; unused.
6145 * dispextern.h (scroll_cost): Remove decl.
6147 * region-cache.h (pp_cache): Mark as externally visible.
6149 * process.c: Make symbols static if they're not exported.
6150 (process_tick, update_tick, create_process, chan_process):
6151 (Vprocess_alist, proc_buffered_char, datagram_access):
6152 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6153 (deactivate_process): Mark defn as static, as well as decl.
6154 * lisp.h (create_process): Remove decl.
6155 * process.h (chan_process, Vprocess_alist): Remove decls.
6157 * print.c: Make symbols static if they're not exported.
6158 (print_depth, new_backquote_output, being_printed, print_buffer):
6159 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6160 (print_interval, print_number_index, initial_stderr_stream):
6162 * lisp.h (Fprinc): Remove decl.
6163 (debug_output_compilation_hack): Mark as externally visible.
6165 * sysdep.c (croak): Move decl from here to syssignal.h.
6166 * syssignal.h (croak): Put it here, so the API can be checked when
6167 'croak' is called from dissociate_if_controlling_tty.
6169 * minibuf.c: Make symbols static if they're not exported.
6170 (minibuf_save_list, choose_minibuf_frame): Now static.
6171 * lisp.h (choose_minibuf_frame): Remove decl.
6173 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6175 * lread.c: Make symbols static if they're not exported.
6176 (read_objects, initial_obarray, oblookup_last_bucket_number):
6178 (make_symbol): Remove; unused.
6179 * lisp.h (initial_obarray, make_symbol): Remove decls.
6181 * keyboard.c: Make symbols static if they're not exported.
6182 (single_kboard, recent_keys_index, total_keys, recent_keys):
6183 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6184 (this_single_command_key_start, echoing, last_auto_save):
6185 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6186 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6187 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6188 (Vlispy_mouse_stem, double_click_count):
6190 (force_auto_save_soon): Define only if SIGDANGER.
6191 (ignore_mouse_drag_p): Now static if
6192 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6193 (print_help): Remove; unused.
6194 (stop_character, last_timer_event): Mark as externally visible.
6195 * keyboard.h (ignore_mouse_drag_p): Declare only if
6196 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6197 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6198 * lisp.h (echoing): Remove decl.
6199 (force_auto_save_soon): Declare only if SIGDANGER.
6200 * xdisp.c (redisplay_window): Simplify code, to make it more
6201 obvious that ignore_mouse_drag_p is not accessed if !defined
6202 USE_GTK && !defined HAVE_NS.
6204 * intervals.c: Make symbols static if they're not exported.
6205 (merge_properties_sticky, merge_interval_right, delete_interval):
6207 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6209 * insdel.c: Make symbols static if they're not exported.
6210 However, leave prepare_to_modify_buffer alone. It's never
6211 called from outside this function, but that appears to be a bug.
6212 (combine_after_change_list, combine_after_change_buffer):
6213 (adjust_after_replace, signal_before_change): Now static.
6214 (adjust_after_replace_noundo): Remove; unused.
6215 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6216 (signal_before_change): Remove decls.
6218 * indent.c (val_compute_motion, val_vmotion): Now static.
6220 * image.c: Make symbols static if they're not exported.
6221 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6223 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6224 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6226 * fringe.c (standard_bitmaps): Now static.
6227 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6229 * frame.c: Make symbols static if they're not exported.
6230 (x_report_frame_params, make_terminal_frame): Now static.
6231 (get_frame_param): Now static, unless HAVE_NS.
6232 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6233 (x_get_resource_string): Remove; not used.
6234 * frame.h (make_terminal_frame, x_report_frame_params):
6235 (x_get_resource_string); Remove decls.
6236 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6237 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6239 * font.c, fontset.c: Make symbols static if they're not exported.
6240 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6241 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6242 * font.c (font_close_object): Now static.
6243 * font.h (font_close_object): Remove.
6244 * fontset.c (FONTSET_OBJLIST): Remove.
6245 (free_realized_fontset) #if-0 the body, which does nothing.
6246 (face_suitable_for_char_p): #if-0, as it's never called.
6247 * fontset.h (face_suitable_for_char_p): Remove decl.
6248 * xfaces.c (face_at_string_position):
6249 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6250 since 0 is always ASCII.
6252 * fns.c (weak_hash_tables): Now static.
6254 * fileio.c: Make symbols static if they're not exported.
6255 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6256 (Vwrite_region_annotation_buffers): Now static.
6258 * eval.c: Make symbols static if they're not exported.
6259 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6260 * lisp.h (backtrace_list): Remove decl.
6262 * emacs.c: Make symbols static if they're not exported.
6263 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6264 (fatal_error_code, fatal_error_signal_hook, standard_args):
6266 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6267 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6268 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6269 * lisp.h (fatal_error_signal_hook): Remove decl.
6270 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6272 * editfns.c: Move a (normally-unused) function to its only use.
6273 * editfns.c, lisp.h (get_operating_system_release): Remove.
6274 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6275 worth the hassle of breaking this out.
6277 * xterm.c: Make symbols static if they're not exported.
6278 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6279 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6280 (x_destroy_window, x_delete_display):
6282 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6283 (x_mouse_leave): Remove; unused.
6284 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6285 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6286 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6288 (x_mouse_leave): Declare only if WINDOWSNT.
6289 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6290 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6293 * ftxfont.c: Make symbols static if they're not exported.
6294 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6296 * font.h (ftxfont_driver): Likewise.
6298 * xfns.c: Make symbols static if they're not exported.
6299 (x_last_font_name, x_display_info_for_name):
6300 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6301 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6302 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6303 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6304 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6305 (last_show_tip_args): Now static.
6306 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6307 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6308 (x_screen_planes): Remove; unused.
6309 * dispextern.h (x_screen_planes): Remove decl.
6311 * dispnew.c: Make symbols static if they're not exported.
6312 * dispextern.h (redraw_garbaged_frames, scrolling):
6313 (increment_row_positions): Remove.
6314 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6315 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6317 (redraw_garbaged_frames): Remove; unused.
6319 * xfaces.c: Make symbols static if they're not exported.
6320 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6322 * xterm.h (defined_color): Remove decls.
6323 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6324 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6325 (menu_face_changed_default, defined_color, free_realized_face):
6326 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6327 (ascii_face_of_lisp_face): Remove; unused.
6329 * xdisp.c: Make symbols static if they're not exported.
6330 * dispextern.h (scratch_glyph_row, window_box_edges):
6331 (glyph_to_pixel_coords, set_cursor_from_row):
6332 (get_next_display_element, set_iterator_to_next):
6333 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6334 (show_mouse_face): Remove decls
6335 * frame.h (message_buf_print): Likewise.
6336 * lisp.h (pop_message, set_message, check_point_in_composition):
6338 * xterm.h (set_vertical_scroll_bar): Likewise.
6339 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6340 (message_buf_print, scratch_glyph_row, displayed_buffer):
6341 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6342 (get_next_display_element, show_mouse_face, window_box_edges):
6343 (frame_to_window_pixel_xy, check_point_in_composition):
6344 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6345 (glyph_to_pixel_coords): Remove; unused.
6347 * dired.c (file_name_completion): Now static.
6349 * dbusbind.c (xd_in_read_queued_messages): Now static.
6351 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6352 * data.c (circular_list_error): Remove.
6354 * commands.h (last_point_position, last_point_position_buffer):
6355 (last_point_position_window): Remove decls.
6356 * keyboard.c: Make these variables static.
6358 * coding.h (coding, code_convert_region, encode_coding_gap):
6360 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6361 (iso_code_class, detect_coding, code_convert_region): Now static.
6362 (encode_coding_gap): Remove; unused.
6364 * chartab.c (chartab_chars, chartab_bits): Now static.
6366 * charset.h (charset_iso_8859_1): Remove decl.
6367 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6370 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6371 * ccl.c (Vccl_program_table): Now static.
6372 (check_ccl_update): Remove; unused.
6374 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6375 * category.h: ... from here.
6376 * category.c (check_category_table, set_category_set): Now static.
6378 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6379 * lisp.h: Remove these decls.
6381 * buffer.c (buffer_count): Remove unused var.
6383 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6384 so that it's not optimized away.
6385 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6386 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6387 exported only to the debugger.
6389 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6390 * atimer.h (run_all_atimers): Remove; not exported.
6392 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6393 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6394 was inaccessible from Lisp.
6395 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6396 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6398 alloc.c: Import and export fewer symbols, and remove unused items.
6399 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6401 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6402 it's not optimized away by whole-program optimization.
6403 (message_enable_multibyte, free_misc): Remove.
6404 (catchlist, handlerlist, mark_backtrace):
6405 Declare only if BYTE_MARK_STACK.
6406 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6407 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6408 (message_enable_multibyte): Remove decl.
6409 (free_misc, interval_free_list, float_block, float_block_index):
6410 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6411 (cons_free_list, last_marked_index):
6413 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6414 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6415 (mark_backtrace): Define only if BYTE_MARK_STACK.
6416 * xdisp.c (message_enable_multibyte): Now static.
6418 Declare Lisp_Object Q* variables to be 'static' if not exported.
6419 This makes it easier for human readers (and static analyzers)
6420 to see whether these variables are used from other modules.
6421 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6422 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6423 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6424 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6425 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6426 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6427 * xmenu.c, xselect.c:
6428 Declare Q* vars static if they are not used in other modules.
6429 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6430 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6431 Remove decls of unexported vars.
6432 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6434 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6436 Make Emacs functions such as Fatom 'static' by default.
6437 This makes it easier for human readers (and static analyzers)
6438 to see whether these functions can be called from other modules.
6439 DEFUN now defines a static function. To make the function external
6440 so that it can be used in other C modules, use the new macro DEFUE.
6441 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6442 (Finit_image_library):
6443 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6444 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6445 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6446 Remove decls, since these functions are now static.
6447 (Funintern, Fget_internal_run_time): New decls, since these functions
6448 were already external.
6450 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6451 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6452 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6453 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6454 * keyboard.c, keymap.c, lread.c:
6455 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6456 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6457 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6458 Mark functions with DEFUE instead of DEFUN,
6459 if they are used in other modules.
6460 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6461 decls for now-static functions.
6462 * buffer.h (Fdelete_overlay): Remove decl.
6463 * callproc.c (Fgetenv_internal): Mark as internal.
6464 * composite.c (Fremove_list_of_text_properties): Remove decl.
6465 (Fcomposition_get_gstring): New forward static decl.
6466 * composite.h (Fcomposite_get_gstring): Remove decl.
6467 * dired.c (Ffile_attributes): New forward static decl.
6468 * doc.c (Fdocumntation_property): New forward static decl.
6469 * eval.c (Ffetch_bytecode): New forward static decl.
6470 (Funintern): Remove extern decl; now in .h file where it belongs.
6471 * fileio.c (Fmake_symbolic_link): New forward static decl.
6472 * image.c (Finit_image_library): New forward static decl.
6473 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6474 * intervals.h (Fprevious_property_change):
6475 (Fremove_list_of_text_properties): Remove decls.
6476 * keyboard.c (Fthis_command_keys): Remove decl.
6477 (Fcommand_execute): New forward static decl.
6478 * keymap.c (Flookup_key): New forward static decl.
6479 (Fcopy_keymap): Now static.
6480 * keymap.h (Flookup_key): Remove decl.
6481 * process.c (Fget_process): New forward static decl.
6482 (Fprocess_datagram_address): Mark as internal.
6483 * syntax.c (Fsyntax_table_p): New forward static decl.
6484 (skip_chars): Remove duplicate decl.
6485 * textprop.c (Fprevious_property_change): New forward static decl.
6486 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6488 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6489 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6491 * editfns.c (Fformat): Remove unreachable code.
6493 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6495 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6498 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6500 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6501 when at ZV. (Bug#8487)
6503 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6505 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6507 * keyboard.c (parse_tool_bar_item): Likewise.
6508 * sound.c (sound_cleanup, alsa_close): Likewise.
6509 * termcap.c (tgetent): Likewise.
6510 * xfns.c (x_default_font_parameter): Likewise.
6511 * xsettings.c (read_and_apply_settings): Likewise.
6513 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6514 (overrun_check_free): Protoize.
6516 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6518 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6519 since callers should never pass a negative size.
6520 Change the signature to match that of plain 'read' and 'write'; see
6521 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6522 * lisp.h: Update prototypes of emacs_write and emacs_read.
6524 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6526 * xdisp.c (redisplay_window): Don't try to determine the character
6527 position of the scroll margin if the window start point w->startp
6528 is outside the buffer's accessible region. (Bug#8468)
6530 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6532 Fix write-region and its subroutines for buffers > 2GB.
6533 * fileio.c (a_write, e_write): Modify declaration of arguments and
6534 local variables to support buffers larger than 2GB.
6535 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6537 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6538 argument, local variables, and return value.
6540 * lisp.h: Update prototypes of emacs_write and emacs_read.
6542 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6544 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6546 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6548 Fix more problems found by GCC 4.6.0's static checks.
6550 * xdisp.c (vmessage): Use a better test for character truncation.
6552 * charset.c (load_charset_map): <, not <=, for optimization,
6553 and to avoid potential problems with integer overflow.
6554 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6555 * casetab.c (set_identity, shuffle): Likewise.
6556 * editfns.c (Fformat): Likewise.
6557 * syntax.c (skip_chars): Likewise.
6559 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6560 This also lets GCC 4.6.0 generate slightly better loop code.
6562 * callint.c (Fcall_interactively): <, not <=, for optimization.
6563 (Fcall_interactively): Count the number of arguments produced,
6564 not the number of arguments given. This is simpler and lets GCC
6565 4.6.0 generate slightly better code.
6567 * ftfont.c: Distingish more carefully between FcChar8 and char.
6568 The previous code passed unsigned char * to a functions like
6569 strlen and xstrcasecmp that expect char *, which does not
6570 conform to the C standard.
6571 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6572 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6573 char * when the C standard requires it.
6575 * keyboard.c (read_char): Remove unused var.
6577 * eval.c: Port to Windows vsnprintf (Bug#8435).
6579 (SIZE_MAX): Define if the headers do not.
6580 (verror): Do not give up if vsnprintf returns a negative count.
6581 Instead, grow the buffer. This ports to Windows vsnprintf, which
6582 does not conform to C99. Problem reported by Eli Zaretskii.
6583 Also, simplify the allocation scheme, by avoiding the need for
6584 calling realloc, and removing the ALLOCATED variable.
6586 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6588 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6589 But keep the doprint source code for now, as we might revamp it
6590 and use it again (Bug#8435).
6591 * lisp.h (doprnt): Remove.
6592 * Makefile.in (base_obj): Remove doprnt.o.
6593 * deps.mk (doprnt.o): Remove.
6595 error: Print 32- and 64-bit integers portably (Bug#8435).
6596 Without this change, on typical 64-bit hosts error ("...%d...", N)
6597 was used to print both 32- and 64-bit integers N, which relied on
6599 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6601 * lisp.h (error, verror): Mark as printf-like functions.
6602 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6603 Report overflow in size calculations when allocating printf buffer.
6604 Do not truncate output string at its first null byte.
6605 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6606 Truncate the output at a character boundary, since vsnprintf does not
6608 * charset.c (check_iso_charset_parameter): Convert internal
6609 character to string before calling 'error', since %c now has the
6611 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6612 overflow when computing char to be passed to 'error'. Do not
6613 pass Lisp_Object to 'error'; pass the integer instead.
6614 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6615 formatted with plain %d.
6617 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6619 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6621 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6623 * xterm.c (x_catch_errors): Remove duplicate declaration.
6625 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6627 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6629 2011-04-10 Jim Meyering <meyering@redhat.com>
6631 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6632 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6633 return ssize_t not "int", and use size_t as the buffer length.
6634 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6635 * gnutls.h: Update declarations.
6636 * process.c (read_process_output): Use ssize_t, to match.
6637 (send_process): Likewise.
6639 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6641 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6643 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6645 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6646 Use unsigned char, to match FcChar8 type definition.
6648 * xterm.c (handle_one_xevent):
6649 * xmenu.c (create_and_show_popup_menu):
6650 * xselect.c (x_decline_selection_request)
6651 (x_reply_selection_request): Avoid type-punned deref of X events.
6653 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6655 Fix some uses of `int' instead of EMACS_INT.
6656 * search.c (string_match_1, fast_string_match)
6657 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6658 (scan_buffer, find_next_newline_no_quit)
6659 (find_before_next_newline, search_command, Freplace_match)
6660 (Fmatch_data): Make some `int' variables be EMACS_INT.
6662 * xdisp.c (display_count_lines): 3rd argument and return value now
6663 EMACS_INT. All callers changed.
6664 (pint2hrstr): Last argument is now EMACS_INT.
6666 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6667 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6668 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6669 (decode_coding_utf_16, decode_coding_emacs_mule)
6670 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6671 (decode_coding_ccl, decode_coding_charset)
6672 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6673 (decode_coding_iso_2022, decode_coding_emacs_mule)
6674 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6675 <char_offset, last_offset>: Declare EMACS_INT.
6676 (encode_coding_utf_8, encode_coding_utf_16)
6677 (encode_coding_emacs_mule, encode_invocation_designation)
6678 (encode_designation_at_bol, encode_coding_iso_2022)
6679 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6680 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6682 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6683 (encode_invocation_designation): Last argument P_NCHARS is now
6685 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6686 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6688 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6691 * ccl.c (Fccl_execute_on_string): Declare some variables
6694 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6696 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6698 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6700 * process.c (Fformat_network_address): Doc fix.
6702 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6704 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6706 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6708 * keyboard.c (read_char): Call Lisp function help-form-show,
6709 instead of using internal_with_output_to_temp_buffer.
6710 (Qhelp_form_show): New var.
6711 (syms_of_keyboard): Use DEFSYM macro.
6713 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6715 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6717 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6719 * process.c (Flist_processes): Remove to Lisp.
6720 (list_processes_1): Delete.
6722 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6724 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6726 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6728 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6730 Fix more problems found by GCC 4.6.0's static checks.
6732 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6734 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6736 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6738 * xdisp.c (vmessage): Mark as a printf-like function.
6740 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6742 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6744 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6745 printf-like functions.
6746 (tiff_load): Add casts to remove these marks before passing them
6747 to system-supplied API.
6749 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6751 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6752 This avoids several warnings with gcc -Wstrict-overflow.
6753 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6754 directly, rather than having caller test rule sign. This avoids
6755 some unnecessary tests.
6756 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6757 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6758 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6760 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6761 (xfont_open): Avoid unnecessary tests.
6763 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6765 * composite.h, composite.c (composition_gstring_put_cache):
6766 Use EMACS_INT, not int, for length.
6768 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6769 breaking out part of COMPOSITION_DECODE_RULE.
6770 (COMPOSITION_DECODE_RULE): Use it.
6771 * composite.c (get_composition_id): Remove unused local vars,
6772 by using the new macro.
6774 * textprop.c (set_text_properties_1): Change while to do-while,
6775 since the condition is always true at first.
6777 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6778 (interval_deletion_adjustment): Return unsigned value.
6781 * process.c (list_processes_1, create_pty, read_process_output):
6782 (exec_sentinel): Remove vars that were set but not used.
6783 (create_pty): Remove unnecessary "volatile"s.
6784 (Fnetwork_interface_info): Avoid possibility of int overflow.
6785 (read_process_output): Do adaptive read buffering even if carryover.
6786 (read_process_output): Simplify nbytes computation if buffered.
6788 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6790 * syntax.c (scan_words): Remove var that was set but not used.
6791 (update_syntax_table): Use unsigned instead of int.
6793 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6794 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6795 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6797 * print.c (print_error_message): Avoid int overflow.
6799 * font.c (font_list_entities): Redo for clarity,
6800 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6802 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6803 (font_score): Avoid potential overflow in diff calculation.
6805 * fns.c (substring_both): Remove var that is set but not used.
6806 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6808 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6810 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6811 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6812 can always succeed if overflow has undefined behavior.
6814 * search.c (boyer_moore, wordify): Remove vars set but not used.
6815 (wordify): Omit three unnecessary tests.
6817 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6818 All callers changed. This avoids the need for an unused var.
6820 * casefiddle.c (casify_region): Remove var that is set but not used.
6822 * dired.c (file_name_completion): Remove var that is set but not used.
6824 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6826 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6827 (Finsert_file_contents): Remove unnecessary code checking fd.
6829 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6830 Check for integer overflow on size calculations.
6832 * buffer.c (Fprevious_overlay_change): Remove var that is set
6835 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6836 Remove vars that are set but not used.
6837 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6838 (timer_check_2): Mark vars as initialized.
6840 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6842 * image.c (lookup_image): Remove var that is set but not used.
6843 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6845 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6846 that are set but not used.
6848 * xfns.c (make_invisible_cursor): Don't return garbage
6849 if XCreateBitmapFromData fails (Bug#8410).
6851 * xselect.c (x_get_local_selection, x_handle_property_notify):
6852 Remove vars that are set but not used.
6854 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6855 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6857 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6858 Remove var that is set but not used.
6859 (scroll_bar_windows_size): Now size_t, not int.
6860 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6863 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6864 (map_tty_color) [!defined MSDOS]: Likewise.
6866 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6868 * coding.c: Remove vars that are set but not used.
6869 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6870 All callers changed.
6871 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6872 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6873 (decode_coding_charset): Remove vars that are set but not used.
6875 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6876 that is set but not used.
6878 * print.c (print_object): Remove var that is set but not used.
6880 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6881 The gnulib version avoids calling malloc in the usual case,
6882 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6883 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6884 * filelock.c (current_lock_owner): Likewise.
6885 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6886 * sysdep.c: Include allocator.h, careadlinkat.h.
6887 (emacs_no_realloc_allocator): New static constant.
6888 (emacs_readlink): New function.
6889 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6890 ../lib/careadlinkat.h.
6892 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6894 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6895 first non-nil return value).
6897 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6899 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6900 if not defined (Bug#8403).
6902 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6904 * xdisp.c (display_count_lines): Remove parameter `start',
6905 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6906 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6907 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6908 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6909 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6910 and thereabouts. All callers changed.
6911 (get_per_char_metric): Remove parameter `f', unused since
6912 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6914 2011-04-02 Jim Meyering <meyering@redhat.com>
6916 do not dereference NULL upon failed strdup
6917 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6918 (ns_get_family): Likewise.
6920 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6922 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6924 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6926 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6929 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6931 Add lexical binding.
6933 * window.c (Ftemp_output_buffer_show): New fun.
6934 (Fsave_window_excursion):
6935 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6937 * lread.c (lisp_file_lexically_bound_p): New function.
6938 (Fload): Bind Qlexical_binding.
6939 (readevalloop): Remove `evalfun' arg.
6940 Bind Qinternal_interpreter_environment.
6941 (Feval_buffer): Bind Qlexical_binding.
6942 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6944 (syms_of_lread): Declare `lexical-binding'.
6946 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6948 * keyboard.c (eval_dyn): New fun.
6949 (menu_item_eval_property): Use it.
6951 * image.c (parse_image_spec): Use Ffunctionp.
6953 * fns.c (concat, mapcar1): Accept byte-code-functions.
6955 * eval.c (Fsetq): Handle lexical vars.
6956 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6957 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6958 (FletX, Flet): Obey lexical binding.
6959 (Fcommandp): Handle closures.
6960 (Feval): New `lexical' arg.
6961 (eval_sub): New function extracted from Feval. Use it almost
6962 everywhere where Feval was used. Look up vars in lexical env.
6964 (Ffunctionp): Move from subr.el.
6965 (Ffuncall): Handle closures.
6966 (apply_lambda): Remove `eval_flags'.
6967 (funcall_lambda): Handle closures and new byte-code-functions.
6968 (Fspecial_variable_p): New function.
6969 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6970 but without exporting it to Lisp.
6972 * doc.c (Fdocumentation, store_function_docstring):
6973 * data.c (Finteractive_form): Handle closures.
6975 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6978 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6980 (exec_byte_code): New function extracted from Fbyte_code to handle new
6981 calling convention for byte-code-functions. Add new byte-codes.
6983 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6985 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6987 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6989 * xdisp.c (redisplay_internal): Fix prototype.
6991 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6993 * xdisp.c (SCROLL_LIMIT): New macro.
6994 (try_scrolling): Use it when setting scroll_limit.
6995 Limit scrolling to 100 screen lines.
6996 (redisplay_window): Even when falling back on "recentering",
6997 position point in the window according to scroll-conservatively,
6998 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7000 (try_scrolling): When point is above the window, allow searching
7001 as far as scroll_max, or one screenful, to compute vertical
7002 distance from PT to the scroll margin position. This prevents
7003 try_scrolling from unnecessarily failing when
7004 scroll-conservatively is set to a value slightly larger than the
7005 window height. Clean up the case of PT below the margin at bottom
7006 of window: scroll_max can no longer be INT_MAX. When aggressive
7007 scrolling is in use, don't let point enter the opposite scroll
7008 margin as result of the scroll.
7009 (syms_of_xdisp) <scroll-conservatively>: Document the
7010 threshold of 100 lines for never-recentering scrolling.
7012 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7014 * dispextern.h (move_it_by_lines):
7015 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7016 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7017 (message_log_check_duplicate): Remove parameters `prev_bol' and
7018 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7019 (redisplay_internal): Remove parameter `preserve_echo_area',
7020 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7022 * indent.c (Fvertical_motion):
7023 * window.c (window_scroll_pixel_based, Frecenter):
7024 Don't pass `need_y_p' to `move_it_by_lines'.
7026 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7028 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7029 steal a few bits to be more compact.
7030 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7031 Remove unneeded casts.
7033 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7035 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7037 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7038 binding" message (bug#7967).
7040 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7042 Fix more problems found by GCC 4.6.0's static checks.
7044 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7045 Remove unused local var.
7047 * editfns.c (Fmessage_box): Remove unused local var.
7049 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7050 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7051 Omit unused local vars.
7052 * window.c (shrink_windows): Omit unused local var.
7053 * menu.c (digest_single_submenu): Omit unused local var.
7054 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7055 Omit unused local var.
7057 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7058 Don't assume string length fits in int.
7059 (keyremap_step, read_key_sequence): Use size_t for sizes.
7060 (read_key_sequence): Don't check last_real_key_start redundantly.
7062 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7063 instead of alloca (Bug#8344).
7065 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7066 (Fbacktrace_frame): Don't assume nframes fits in int.
7068 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7070 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7073 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7075 * cm.c (calccost): Turn while-do into do-while, for clarity.
7077 * keyboard.c (syms_of_keyboard): Use the same style as later
7078 in this function when indexing through an array. This also
7079 works around GCC bug 48267.
7081 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7083 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7085 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7086 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7088 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7089 This avoids undefined behavior on integer overflow, and is a bit
7090 more convenient anyway since it is compared to a size_t variable.
7092 Variadic C functions now count arguments with size_t, not int.
7093 This avoids an unnecessary limitation on 64-bit machines, which
7094 caused (substring ...) to crash on large vectors (Bug#8344).
7095 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7096 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7097 All variadic functions and their callers changed accordingly.
7098 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7099 * data.c (arith_driver, float_arith_driver): Likewise.
7100 * editfns.c (general_insert_function): Likewise.
7101 * eval.c (struct backtrace.nargs, interactive_p)
7102 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7103 (funcall_lambda, mark_backtrace): Likewise.
7104 * fns.c (concat): Likewise.
7105 * frame.c (x_set_frame_parameters): Likewise.
7106 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7107 0 if not found, not -1. All callers changed.
7109 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7110 (stack_copy_size): Now size_t, not int.
7111 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7113 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7115 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7116 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7117 All callers changed.
7119 * lisp.h (multibyte_char_to_unibyte):
7120 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7121 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7122 * character.h (CHAR_TO_BYTE8):
7123 * cmds.c (internal_self_insert):
7124 * editfns.c (general_insert_function):
7125 * keymap.c (push_key_description):
7126 * search.c (Freplace_match):
7127 * xdisp.c (message_dolog, set_message_1): All callers changed.
7129 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7131 * keyboard.c (safe_run_hook_funcall): New function.
7132 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7133 don't set the hook to nil, but remove the offending function instead.
7134 (Qcommand_hook_internal): Remove, unused.
7135 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7136 Vcommand_hook_internal.
7138 * eval.c (enum run_hooks_condition): Remove.
7139 (funcall_nil, funcall_not): New functions.
7140 (run_hook_with_args): Call each function through a `funcall' argument.
7141 Remove `cond' argument, now redundant.
7142 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7143 (Frun_hook_with_args_until_failure): Adjust accordingly.
7144 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7146 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7148 * dispextern.h (string_buffer_position): Remove declaration.
7150 * print.c (strout): Remove parameter `multibyte', unused since
7151 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7153 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7154 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7155 All callers changed.
7157 * w32.c (_wsa_errlist): Use braces for struct initializers.
7159 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7160 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7161 All callers changed.
7162 (string_buffer_position): Likewise. Also, make static (it's never
7163 used outside xdisp.c).
7164 (cursor_row_p): Remove parameter `w', unused since
7165 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7166 (decode_mode_spec): Remove parameter `precision', introduced during
7167 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7168 All callers changed.
7170 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7172 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7174 2011-03-27 Anders Lindgren <andlind@gmail.com>
7176 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7177 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7178 (ns_update_auto_hide_menu_bar): New functions.
7179 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7180 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7181 ns_constrain_all_frames.
7182 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7183 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7185 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7187 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7189 2011-03-27 Glenn Morris <rgm@gnu.org>
7191 * syssignal.h: Replace RETSIGTYPE with void.
7192 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7193 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7194 Replace SIGTYPE with void everywhere.
7195 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7196 * s/template.h (SIGTYPE): Remove commented out definition.
7198 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7200 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7201 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7203 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7205 * w32.c (read_unc_volume): Use parameter `henum', instead of
7206 global variable `wget_enum_handle'.
7208 * keymap.c (describe_vector): Remove parameters `indices' and
7209 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7210 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7212 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7214 * keyboard.c (timer_check): Remove parameter `do_it_now',
7215 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7216 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7217 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7219 * keyboard.c (read_char):
7220 * w32menu.c (w32_menu_display_help):
7221 * xmenu.c (show_help_event, menu_help_callback):
7222 Adjust calls to `show_help_echo'.
7224 * gtkutil.c (xg_maybe_add_timer):
7225 * keyboard.c (readable_events):
7226 * process.c (wait_reading_process_output):
7227 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7229 * insdel.c (adjust_markers_gap_motion):
7230 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7231 (gap_left, gap_right): Don't call it.
7233 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7235 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7236 incurred during fontification.
7238 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7240 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7241 (DEFVAR_PER_BUFFER): Don't pass it.
7243 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7244 (scrolling_window): Don't pass it.
7246 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7248 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7250 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7252 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7253 of variables specific to SELinux and computation of `encoded_absname'.
7255 * image.c (XPutPixel): Remove unused variable `height'.
7257 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7259 * unexw32.c (get_section_info): Remove unused variable `section'.
7261 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7262 (system_process_attributes): Remove unused variable `sess'.
7263 (sys_read): Remove unused variable `err'.
7265 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7266 (w32_wnd_proc): Remove unused variable `isdead'.
7267 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7268 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7269 (x_create_tip_frame): Remove unused variable `tem'.
7271 * w32inevt.c (w32_console_read_socket):
7272 Remove unused variable `no_events'.
7274 * w32term.c (x_draw_composite_glyph_string_foreground):
7275 Remove unused variable `width'.
7277 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7279 * w32term.c (x_set_glyph_string_clipping):
7280 Don't pass uninitialized region to CombineRgn.
7282 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7284 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7285 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7286 (Fx_close_connection): Remove unused variable `i'.
7288 * w32font.c (w32font_draw): Return number of glyphs.
7289 (w32font_open_internal): Remove unused variable `i'.
7290 (w32font_driver): Add missing initializer.
7292 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7293 (fill_in_menu): Remove unused variable `items_added'.
7295 * w32term.c (last_mouse_press_frame): Remove static global variable.
7296 (w32_clip_to_row): Remove unused variable `f'.
7297 (x_delete_terminal): Remove unused variable `i'.
7299 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7300 (NOTHING): Remove unused static global variable.
7301 (uniscribe_check_otf): Remove unused variable `table'.
7302 (uniscribe_font_driver): Add missing initializers.
7304 2011-03-23 Julien Danjou <julien@danjou.info>
7306 * term.c (Fsuspend_tty, Fresume_tty):
7307 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7308 * window.c (temp_output_buffer_show):
7309 * insdel.c (signal_before_change):
7310 * frame.c (Fhandle_switch_frame):
7311 * fileio.c (Fdo_auto_save):
7312 * emacs.c (Fkill_emacs):
7313 * editfns.c (save_excursion_restore):
7314 * cmds.c (internal_self_insert):
7315 * callint.c (Fcall_interactively):
7316 * buffer.c (Fkill_all_local_variables):
7317 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7319 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7320 unconditionnaly since it does the check itself.
7322 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7324 Fix more problems found by GCC 4.5.2's static checks.
7326 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7327 the first time through the loop, since we know p0 < p1 then.
7328 This also avoids a gcc -Wstrict-overflow warning.
7330 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7331 leading to a memory leak, possible in functions like
7332 load_charset_map_from_file that can allocate an unbounded number
7333 of objects (Bug#8318).
7335 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7336 that could (at least in theory) be that large.
7338 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7339 This is less likely to overflow, and avoids undefined behavior if
7340 overflow does occur. All callers changed. Use strtoul to scan
7341 for the unsigned long integer.
7342 (pint2hrstr): Simplify and tune code slightly.
7343 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7345 * scroll.c (do_scrolling): Work around GCC bug 48228.
7346 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7348 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7349 This also avoids a warning with gcc -Wstrict-overflow.
7350 (validate_x_resource_name): Simplify count usage.
7351 This also avoids a warning with gcc -Wstrict-overflow.
7353 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7356 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7358 * process.c (Fmake_network_process): Use socklen_t, not int,
7359 where POSIX says socklen_t is required in portable programs.
7360 This fixes a porting bug on hosts like 64-bit HP-UX, where
7361 socklen_t is wider than int (Bug#8277).
7362 (Fmake_network_process, server_accept_connection):
7363 (wait_reading_process_output, read_process_output):
7366 * process.c: Rename or move locals to avoid shadowing.
7367 (list_processes_1, Fmake_network_process):
7368 (read_process_output_error_handler, exec_sentinel_error_handler):
7369 Rename or move locals.
7370 (Fmake_network_process): Define label "retry_connect" only if needed.
7371 (Fnetwork_interface_info): Fix pointer signedness.
7372 (process_send_signal): Add cast to avoid pointer signedness problem.
7373 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7374 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7376 Make tparam.h and terminfo.c consistent.
7377 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7378 Include tparam.h instead, since it declares them.
7379 * cm.h (PC): Remove extern decl; tparam.h now does this.
7380 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7381 * terminfo.c: Include tparam.h, to check interfaces.
7382 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7383 (tparam): Adjust signature to match interface in tparam.h;
7384 this removes some undefined behavior. Check that outstring and len
7385 are zero, which they always are with Emacs.
7386 * tparam.h (PC, BC, UP): New extern decls.
7388 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7389 (xftfont_open): Rename locals to avoid shadowing.
7391 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7392 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7393 (OTF_TAG_SYM): Omit macro if not needed.
7394 (ftfont_list): Remove unused local.
7395 (get_adstyle_property, ftfont_pattern_entity):
7396 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7397 Rename locals to avoid shadowing.
7399 * xfont.c (xfont_list_family): Mark var as initialized.
7401 * xml.c (make_dom): Now static.
7403 * composite.c (composition_compute_stop_pos): Rename local to
7405 (composition_reseat_it): Remove unused locals.
7406 (find_automatic_composition, composition_adjust_point): Likewise.
7407 (composition_update_it): Mark var as initialized.
7408 (find_automatic_composition): Mark vars as initialized,
7409 with a FIXME (Bug#8290).
7411 character.h: Rename locals to avoid shadowing.
7412 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7413 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7414 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7415 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7418 * textprop.c (property_change_between_p): Remove; unused.
7420 * intervals.c (interval_start_pos): Now static.
7422 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7424 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7425 Rename locals to avoid shadowing.
7427 * sound.c (wav_play, au_play, Fplay_sound_internal):
7428 Fix pointer signedness.
7429 (alsa_choose_format): Remove unused local var.
7430 (wav_play): Initialize a variable to 0, to prevent undefined
7431 behavior (Bug#8278).
7433 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7435 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7437 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7438 clobbering (Bug#8298).
7439 * sysdep.c (sys_subshell): Likewise.
7440 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7442 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7443 This should get cleaned up, so that child_setup has the
7444 same signature on all platforms.
7446 * callproc.c (call_process_cleanup): Now static.
7447 (relocate_fd): Rename locals to avoid shadowing.
7449 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7451 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7452 not to be necessary, and produces flickering.
7454 2011-03-20 Glenn Morris <rgm@gnu.org>
7456 * config.in: Remove file.
7458 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7460 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7461 are now in src/globals.h.
7462 (syms_of_minibuf): Remove spurious & from previous change.
7464 2011-03-20 Leo <sdl.web@gmail.com>
7466 * minibuf.c (completing-read-function): New variable.
7467 (completing-read-default): Rename from completing-read.
7468 (completing-read): Call completing-read-function.
7470 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7472 * xfaces.c (Fx_load_color_file):
7473 Read color file from absolute filename (bug#8250).
7475 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7477 * makefile.w32-in: Update dependencies.
7479 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7481 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7483 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7485 Fix more problems found by GCC 4.5.2's static checks.
7487 * process.c (make_serial_process_unwind, send_process_trap):
7488 (sigchld_handler): Now static.
7490 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7491 That way, the code declares only the vars that it needs.
7492 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7493 * s/cygwin.h (PTY_ITERATION): Likewise.
7494 * s/darwin.h (PTY_ITERATION): Likewise.
7495 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7497 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7498 * process.c (allocate_pty): Don't declare stb unless it's needed.
7500 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7501 (CONSTANTLIM): Remove; unused.
7502 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7503 Define only if needed.
7505 * unexelf.c (unexec): Name an expression,
7506 to avoid gcc -Wbad-function-cast warning.
7507 Use a different way to cause a compilation error if anyone uses
7508 n rather than nn, a way that does not involve shadowing.
7509 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7511 * deps.mk (unexalpha.o): Remove; unused.
7513 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7514 * unexec.h: New file.
7515 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7516 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7518 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7519 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7520 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7521 Change as necessary to match prototype in unexec.h.
7523 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7525 (back_comment, skip_chars): Mark vars as initialized.
7527 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7528 Rename locals to avoid shadowing.
7530 * lread.c (read1): Rewrite so as not to use empty "else".
7531 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7533 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7535 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7536 warning when compiling print.c.
7538 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7539 instead of using an uninitialized var.
7540 (font_sort_entities): Mark var as initialized.
7542 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7544 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7545 pointers to constants.
7546 (font_parse_fcname): Remove unused vars.
7547 (font_delete_unmatched): Now static.
7548 (font_get_spec): Remove; unused.
7549 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7550 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7551 Rename or move locals to avoid shadowing.
7553 * fns.c (require_nesting_list, require_unwind): Now static.
7554 (Ffillarray): Rename locals to avoid shadowing.
7556 * floatfns.c (domain_error2): Define only if needed.
7557 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7559 * alloc.c (mark_backtrace): Move decl from here ...
7560 * lisp.h: ... to here, so that it can be checked.
7562 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7563 (Fdefvar): Rewrite so as not to use empty "else".
7564 (lisp_indirect_variable): Name an expression,
7565 to avoid gcc -Wbad-function-cast warning.
7566 (Fdefvar): Rename locals to avoid shadowing.
7568 * callint.c (quotify_arg, quotify_args): Now static.
7569 (Fcall_interactively): Rename locals to avoid shadowing.
7570 Use const pointer when appropriate.
7572 * lisp.h (get_system_name, get_operating_system_release):
7573 Move decls here, to check interfaces.
7574 * process.c (get_operating_system_release): Move decl to lisp.h.
7575 * xrdb.c (get_system_name): Likewise.
7576 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7577 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7578 some of which prompt warnings from gcc -Wbad-function-cast.
7579 (Fformat_time_string, Fencode_time, Finsert_char):
7580 (Ftranslate_region_internal, Fformat):
7581 Rename or remove local vars to avoid shadowing.
7582 (Ftranslate_region_internal): Mark var as initialized.
7584 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7587 * lisp.h (eassert): Check that the argument compiles, even if
7588 ENABLE_CHECKING is not defined.
7590 * data.c (Findirect_variable): Name an expression, to avoid
7591 gcc -Wbad-function-cast warning.
7592 (default_value, arithcompare, arith_driver, arith_error): Now static.
7593 (store_symval_forwarding): Rename local to avoid shadowing.
7594 (Fmake_variable_buffer_local, Fmake_local_variable):
7595 Mark variables as initialized.
7596 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7598 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7599 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7600 Rename locals to avoid shadowing.
7601 (mark_stack): Move local variables into the #ifdef region where
7603 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7604 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7606 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7607 (GC_STRING_CHARS): Remove; not used.
7608 (Fmemory_limit): Cast sbrk's returned value to char *.
7610 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7611 avoids undefined behavior in theory.
7613 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7615 Use functions, not macros, for up- and down-casing (Bug#8254).
7616 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7617 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7618 to use the following functions instead of these macros.
7619 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7620 EMACS_INT, since callers assume the returned value fits in int.
7621 (upcase1): Likewise, for UPCASE_TABLE.
7622 (uppercasep, lowercasep, upcase): New static inline functions.
7623 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7624 the race-condition problem in the old DOWNCASE.
7626 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7627 Rename locals to avoid shadowing.
7628 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7629 (regex_compile, re_search_2, re_match_2_internal):
7630 Remove unused local vars.
7631 (FREE_VAR): Rewrite so as not to use empty "else",
7632 which gcc can warn about.
7633 (regex_compile, re_match_2_internal): Mark locals as initialized.
7634 (RETALLOC_IF): Define only if needed.
7635 (WORDCHAR_P): Likewise. This one is never needed, but is used
7636 only in a comment talking about a compiler bug, so put inside
7637 the #if 0 of that comment.
7638 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7639 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7642 * search.c (boyer_moore): Rename locals to avoid shadowing.
7643 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7644 (PREV_CHAR_BOUNDARY): Likewise.
7646 * search.c (simple_search): Remove unused var.
7648 * dired.c (compile_pattern): Move decl from here ...
7649 * lisp.h: ... to here, so that it can be checked.
7650 (struct re_registers): New forward decl.
7652 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7654 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7656 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7657 Rename locals to avoid shadowing.
7658 (Fvertical_motion): Mark locals as initialized.
7660 * casefiddle.c (casify_object, casify_region): Now static.
7661 (casify_region): Mark local as initialized.
7663 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7665 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7666 New macros, so that the caller can use some names other than
7667 gcpro1, gcpro2, etc.
7668 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7670 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7671 argument, for consistency with GCPRO2_VAR, etc: it is now the
7672 prefix of the variable, not the variable itself. All uses
7674 * dired.c (directory_files_internal, file_name_completion):
7675 Rename locals to avoid shadowing.
7677 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7678 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7679 dired.c's scmp function, had undefined behavior.
7680 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7681 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7682 * buffer.h: ... to here, because these macros use current_buffer,
7683 and the new implementation with inline functions needs to have
7684 current_buffer in scope now, rather than later when the macros
7686 (downcase, upcase1): New static inline functions.
7687 (DOWNCASE, UPCASE1): Reimplement using these functions.
7688 This avoids undefined behavior in expressions like
7689 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7690 from race conditions in accessing the global variables
7691 case_temp1 and case_temp2.
7692 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7693 * lisp.h (case_temp1, case_temp2): Remove their decls.
7694 * character.h (ASCII_CHAR_P): Move from here ...
7695 * lisp.h: ... to here, so that the inline functions mentioned
7698 * dired.c (directory_files_internal_unwind): Now static.
7700 * fileio.c (file_name_as_directory, directory_file_name):
7701 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7703 (file_name_as_directory): Use const pointers when appropriate.
7704 (Fexpand_file_name): Likewise. In particular, newdir might
7705 point at constant storage, so make it a const pointer.
7706 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7707 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7709 (Fset_file_times, Finsert_file_contents, auto_save_error):
7710 Rename locals to avoid shadowing.
7712 * minibuf.c (choose_minibuf_frame_1): Now static.
7713 (Ftry_completion, Fall_completions): Rename or remove locals
7716 * marker.c (bytepos_to_charpos): Remove; unused.
7718 * lisp.h (verify_bytepos, count_markers): New decls,
7719 so that gcc does not warn that these functions aren't declared.
7721 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7722 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7723 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7724 (copy_text): Remove unused local var.
7726 * filelock.c (within_one_second): Now static.
7727 (lock_file_1): Rename local to avoid shadowing.
7729 * buffer.c (fix_overlays_before): Mark locals as initialized.
7730 (fix_start_end_in_overlays): Likewise. This function should be
7731 simplified by using pointers-to-pointers, but that's a different
7733 (switch_to_buffer_1): Now static.
7734 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7735 (report_overlay_modification): Rename locals to avoid shadowing.
7737 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7738 Fix pointer signedness issue.
7739 (sys_subshell): Mark local as volatile if checking for lint,
7740 to suppress a gcc -Wclobbered warning that does not seem to be right.
7741 (MAXPATHLEN): Define only if needed.
7743 * process.c (serial_open, serial_configure): Move decls from here ...
7744 * systty.h: ... to here, so that they can be checked.
7746 * fns.c (get_random, seed_random): Move extern decls from here ...
7747 * lisp.h: ... to here, so that they can be checked.
7749 * sysdep.c (reset_io): Now static.
7750 (wait_for_termination_signal): Remove; unused.
7752 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7753 (copy_keymap_item, append_key, push_text_char_description):
7755 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7756 (DENSE_TABLE_SIZE): Remove; unused.
7757 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7758 (describe_map_tree):
7759 Rename locals to avoid shadowing.
7761 * keyboard.c: Declare functions static if they are not used elsewhere.
7762 (echo_char, echo_dash, cmd_error, top_level_2):
7763 (poll_for_input, handle_async_input): Now static.
7764 (read_char, kbd_buffer_get_event, make_lispy_position):
7765 (make_lispy_event, make_lispy_movement, apply_modifiers):
7766 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7767 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7768 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7769 (read_key_sequence, read_char): Mark locals as initialized.
7770 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7772 * keyboard.h (make_ctrl_char): New decl.
7773 (mark_kboards): Move decl here ...
7774 * alloc.c (mark_kboards): ... from here.
7776 * lisp.h (force_auto_save_soon): New decl.
7778 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7779 (DEFINE_DUMMY_FUNCTION): New macro.
7780 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7782 (main): Add casts to avoid warnings
7783 if GCC considers string literals to be constants.
7785 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7787 * dbusbind.c: Pointer signedness fixes.
7788 (xd_signature, xd_append_arg, xd_initialize):
7789 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7790 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7791 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7792 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7794 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7795 if GCC considers string literals to be constants.
7796 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7798 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7800 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7801 (print_preprocess, print_object): New macro to fix last change.
7803 * print.c (print_preprocess): Don't forget font objects.
7805 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7807 * emacs.c (USAGE3): Doc fixes.
7809 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7811 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7814 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7816 * lisp.h (VWindow_system, Qfile_name_history):
7817 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7818 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7819 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7821 * w32select.c: Don't #include "keyboard.h".
7822 (run_protected): Add extern declaration for waiting_for_input.
7824 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7825 * w32console.c (detect_input_pending, read_input_pending)
7826 (encode_terminal_code):
7827 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7828 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7829 (w32_system_caret_y, Qfile_name_history):
7830 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7831 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7832 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7833 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7834 * w32proc.c (Qlocal, report_file_error):
7835 * w32term.c (Vwindow_system, updating_frame):
7836 * w32uniscribe.c (initialized, uniscribe_font_driver):
7837 Remove unneeded extern declarations.
7839 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7841 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7843 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7845 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7846 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7847 These macros can no longer be used for assignment.
7849 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7850 Assign struct members directly, instead of using BUF_BEGV etc.
7851 (record_buffer_markers, fetch_buffer_markers): New functions for
7852 recording and fetching special buffer markers.
7853 (set_buffer_internal_1, set_buffer_temp): Use them.
7855 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7857 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7859 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7860 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7862 * xdisp.c (hscroll_window_tree):
7863 (reconsider_clip_changes): Use PT instead of BUF_PT.
7865 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7867 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7868 $(EMACS_ROOT)/lib/intprops.h.
7870 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7872 Fix more problems found by GCC 4.5.2's static checks.
7874 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7875 to unsigned char * to avoid compiler diagnostic.
7876 (xg_free_frame_widgets): Make it clear that a local variable is
7877 needed only if USE_GTK_TOOLTIP.
7878 (gdk_window_get_screen): Make it clear that this macro is needed
7879 only if USE_GTK_TOOLTIP.
7880 (int_gtk_range_get_value): New function, which avoids a diagnostic
7881 from gcc -Wbad-function-cast.
7882 (xg_set_toolkit_scroll_bar_thumb): Use it.
7883 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7884 diagnostic from gcc -Wbad-function-cast.
7885 (get_utf8_string, xg_get_file_with_chooser):
7886 Rename locals to avoid shadowing.
7887 (create_dialog): Move locals to avoid shadowing.
7889 * xgselect.c (xg_select): Remove unused var.
7891 * image.c (four_corners_best): Mark locals as initialized.
7892 (gif_load): Initialize transparent_p to zero (Bug#8238).
7893 Mark another local as initialized.
7894 (my_png_error, my_error_exit): Mark with NO_RETURN.
7896 * image.c (clear_image_cache): Now static.
7897 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7898 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7899 (x_edge_detection): Remove unnecessary cast that
7900 gcc -Wbad-function-cast diagnoses.
7901 (gif_load): Fix pointer signedness.
7902 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7903 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7905 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7907 Improve quality of tests for time stamp overflow.
7908 For example, without this patch (encode-time 0 0 0 1 1
7909 1152921504606846976) returns the obviously-bogus value (-948597
7910 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7911 reports time overflow. See
7912 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7913 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7914 * editfns.c: Include limits.h and intprops.h.
7915 (TIME_T_MIN, TIME_T_MAX): New macros.
7916 (time_overflow): Move earlier, to before first use.
7917 (hi_time, lo_time): New functions, for an accurate test for
7919 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7920 (Fget_internal_run_time): Don't assume time_t fits in int.
7921 (make_time): Use list2 instead of Fcons twice.
7922 (Fdecode_time): More accurate test for out-of-range times.
7923 (check_tm_member): New function.
7924 (Fencode_time): Use it, to test for out-of-range times.
7925 (lisp_time_argument): Don't rely on undefined left-shift and
7926 right-shift behavior when checking for time stamp overflow.
7928 * editfns.c (time_overflow): New function, refactoring common code.
7929 (Fformat_time_string, Fdecode_time, Fencode_time):
7930 (Fcurrent_time_string): Use it.
7932 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7933 * dired.c (make_time): Move to ...
7934 * editfns.c (make_time): ... here.
7935 * systime.h: Note the move.
7937 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7939 * fringe.c (update_window_fringes): Remove unused variables.
7941 * unexmacosx.c (copy_data_segment): Also copy __got section.
7944 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7946 * termcap.c [MSDOS]: Include "msdos.h".
7947 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7948 Constify `char *' arguments and their references according to
7949 prototypes in tparam.h.
7951 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7953 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7954 Adapt all references accordingly.
7956 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7958 2011-03-11 Tom Tromey <tromey@redhat.com>
7960 * buffer.c (syms_of_buffer): Remove obsolete comment.
7962 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7964 * termhooks.h (encode_terminal_code): Declare prototype.
7966 * msdos.c (encode_terminal_code): Don't declare prototype.
7968 * term.c (encode_terminal_code): Now external again, used by
7969 w32console.c and msdos.c.
7971 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7972 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7974 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7976 Fix some minor problems found by GCC 4.5.2's static checks.
7978 * fringe.c (update_window_fringes): Mark locals as initialized
7980 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7982 * alloc.c (mark_fringe_data): Move decl from here ...
7983 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7984 to check its interface.
7985 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7987 * fontset.c (free_realized_fontset): Now static.
7988 (Fset_fontset_font): Rename local to avoid shadowing.
7989 (fontset_font): Mark local as initialized.
7990 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7992 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7994 * xselect.c (x_disown_buffer_selections): Remove; not used.
7995 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7996 (x_own_selection, Fx_disown_selection_internal): Rename locals
7998 (x_handle_dnd_message): Remove local to avoid shadowing.
8000 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8001 so that the caller can use some name other than gcpro1.
8002 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8003 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8004 (Fx_backspace_delete_keys_p):
8005 Use them to avoid shadowing, and rename vars to avoid shadowing.
8006 (x_decode_color, x_set_name, x_window): Now static.
8007 (Fx_create_frame): Add braces to silence GCC warning.
8008 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8009 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8010 Remove unused locals.
8011 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8012 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8013 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8016 * xterm.h (x_mouse_leave): New decl.
8018 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8019 Remove unused functions.
8020 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8021 (x_calc_absolute_position): Now static.
8022 (XTread_socket): Don't define label "out" unless it's used.
8023 Don't declare local "event" unless it's used.
8024 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8025 unless they are used.
8026 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8027 (x_fatal_error_signal): Remove; not used.
8028 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8029 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8030 (x_error_catcher, x_connection_closed, x_error_handler):
8031 (x_error_quitter, xembed_send_message, x_iconify_frame):
8032 (my_log_handler): Rename locals to avoid shadowing.
8033 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8034 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8036 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8037 Rename or move locals to avoid shadowing.
8038 (tty_defined_color, merge_face_heights): Now static.
8039 (free_realized_faces_for_fontset): Remove; not used.
8040 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8041 does not deduce is never used uninitialized.
8042 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8043 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8045 * terminal.c (store_terminal_param): Now static.
8047 * xmenu.c (menu_highlight_callback): Now static.
8048 (set_frame_menubar): Remove unused local.
8049 (xmenu_show): Rename parameter to avoid shadowing.
8050 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8051 since they might point to immutable storage.
8052 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8053 since it's unused otherwise.
8055 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8056 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8057 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8058 avoids a gcc -Wuninitialized diagnostic.
8059 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8060 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8061 does not deduce are never used uninitialized.
8063 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8065 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8066 * window.c (window_loop, size_window):
8067 (run_window_configuration_change_hook, enlarge_window): Likewise.
8069 * window.c (display_buffer): Now static.
8070 (size_window): Mark variables that gcc -Wuninitialized
8071 does not deduce are never used uninitialized.
8072 * window.h (check_all_windows): New decl, to forestall
8073 gcc -Wmissing-prototypes diagnostic.
8074 * dispextern.h (bidi_dump_cached_states): Likewise.
8076 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8078 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8080 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8081 and to avoid gcc -Wuninitialized warning.
8082 (load_charset_map): Mark variables that gcc -Wuninitialized
8083 does not deduce are never used uninitialized.
8084 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8086 * coding.c (coding_set_source, coding_set_destination):
8087 Use "else { /* comment */ }" rather than "else /* comment */;"
8088 for clarity, and to avoid gcc -Wempty-body warning.
8089 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8090 a block, when the outer 'i' will do.
8091 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8092 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8093 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8094 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8095 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8096 Rename locals to avoid shadowing.
8097 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8098 * coding.c (emacs_mule_char, encode_invocation_designation):
8099 Now static, since they're not used elsewhere.
8100 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8101 (decode_coding_object, encode_coding_object, detect_coding_system):
8102 (decode_coding_emacs_mule): Mark variables that gcc
8103 -Wuninitialized does not deduce are never used uninitialized.
8104 (detect_coding_iso_2022): Initialize a local variable that might
8105 be used uninitialized. Leave a FIXME because it's not clear that
8106 this initialization is needed. (Bug#8211)
8107 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8108 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8109 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8110 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8111 Remove unused macros.
8113 * category.c (hash_get_category_set): Remove unused local var.
8114 (copy_category_table): Now static, since it's not used elsewhere.
8115 * character.c (string_count_byte8): Likewise.
8117 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8118 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8120 * chartab.c (copy_sub_char_table): Now static, since it's not used
8122 (sub_char_table_ref_and_range, char_table_ref_and_range):
8123 Rename locals to avoid shadowing.
8124 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8126 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8127 (BIDI_BOB): Remove unused macro.
8129 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8130 deduce are never used uninitialized.
8131 * term.c (encode_terminal_code): Likewise.
8133 * term.c (encode_terminal_code): Now static. Remove unused local.
8135 * tparam.h: New file.
8136 * term.c, tparam.h: Include it.
8137 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8138 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8139 Move these decls to tparam.h, and make them agree with what
8140 is actually in tparam.c. The previous trick of using incompatible
8141 decls in different modules does not conform to the C standard.
8142 All callers of tparam changed to use tparam's actual API.
8143 * tparam.c (tparam1, tparam, tgoto):
8144 Use const pointers where appropriate.
8146 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8147 * cm.h (struct cm): Likewise.
8148 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8149 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8150 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8151 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8152 (turn_on_face, init_tty): Likewise.
8153 * termchar.h (struct tty_display_info): Likewise.
8155 * term.c (term_mouse_position): Rename local to avoid shadowing.
8157 * alloc.c (mark_ttys): Move decl from here ...
8158 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8160 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8162 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8164 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8166 * search.c (compile_pattern_1): Remove argument regp, unused since
8167 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8168 (compile_pattern): Don't pass it.
8170 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8172 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8173 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8175 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8177 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8179 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8180 gdk_window_get_screen, gdk_window_get_geometry,
8181 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8182 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8183 (xg_get_pixbuf_from_pixmap): New function.
8184 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8185 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8186 Call xg_get_pixbuf_from_pixmap instead of
8187 gdk_pixbuf_get_from_drawable.
8188 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8189 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8190 (xg_check_special_colors): Use GtkStyleContext and its functions
8192 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8193 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8194 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8195 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8196 Call gtk_widget_get_preferred_size.
8197 (xg_frame_resized): gdk_window_get_geometry only takes 5
8199 (xg_win_to_widget, xg_event_is_for_menubar):
8200 Call gdk_x11_window_lookup_for_display.
8201 (xg_set_widget_bg): New function.
8202 (delete_cb): New function.
8203 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8204 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8205 (xg_set_background_color): Call xg_set_widget_bg.
8206 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8207 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8208 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8209 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8211 (update_frame_tool_bar): Call gtk_widget_hide.
8212 (xg_initialize): Use GDK_KEY_g.
8214 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8216 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8218 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8219 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8220 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8222 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8224 * w32xfns.c (select_palette): Check success of RealizePalette against
8225 GDI_ERROR, not zero.
8227 See ChangeLog.11 for earlier changes.
8233 Copyright (C) 2011 Free Software Foundation, Inc.
8235 This file is part of GNU Emacs.
8237 GNU Emacs is free software: you can redistribute it and/or modify
8238 it under the terms of the GNU General Public License as published by
8239 the Free Software Foundation, either version 3 of the License, or
8240 (at your option) any later version.
8242 GNU Emacs is distributed in the hope that it will be useful,
8243 but WITHOUT ANY WARRANTY; without even the implied warranty of
8244 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8245 GNU General Public License for more details.
8247 You should have received a copy of the GNU General Public License
8248 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.