1 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3 * dbusbind.c (Fdbus_register_signal): Add match rule to
4 Vdbus_registered_objects_table. (Bug#9581)
5 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
8 2011-09-24 Jim Meyering <meyering@redhat.com>
10 do not ignore write error for any output size
11 The previous change was incomplete.
12 While it makes emacs --batch detect the vast majority of stdout
13 write failures, errors were still ignored whenever the output size is
14 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
15 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
16 && echo FAIL: ignored write error
17 FAIL: ignored write error
18 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
19 && echo FAIL: ignored write error
20 FAIL: ignored write error
21 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
23 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
25 * emacs.c (Fkill_emacs): In noninteractive mode exit
26 non-successfully if a write error occurred on stdout. (Bug#9574)
28 2011-09-21 Eli Zaretskii <eliz@gnu.org>
30 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
33 * dispextern.h (struct it): Update the comment documenting what
36 2011-09-20 Eli Zaretskii <eliz@gnu.org>
38 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
39 a display string, extend search for cursor position to end of row.
40 (find_row_edges): If the row ends in a newline from a display
41 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
42 Handle the case of a display string with multiple newlines.
43 (Fcurrent_bidi_paragraph_direction): Fix search for previous
44 non-empty line. Fixes confusing cursor motion with arrow keys at
45 the beginning of a line that starts with whitespace.
47 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
49 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
52 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
54 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
57 2011-09-18 Eli Zaretskii <eliz@gnu.org>
59 * xdisp.c (display_line): Record maximum and minimum buffer
60 positions even if no glyphs were produced (e.g., by a zero-width
61 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
62 buffer positions that will be removed from the glyph row because
64 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
65 column is beyond frame width: don't subtract 1 "pixel" when
66 computing width of the stretch.
67 (reseat_at_next_visible_line_start): Undo the change made on
68 2011-09-17 that saved paragraph information and restored it after
69 the call to `reseat'. (Bug#9545)
71 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
73 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
74 and turn window cursor on if cleared (Bug#9415).
76 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
78 * search.c (boyer_moore): Take unibyte characters from pattern
81 2011-09-18 Eli Zaretskii <eliz@gnu.org>
83 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
85 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
87 Fix minor problem found by static checking.
88 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
89 initialized, to pacify gcc -Wuninitialized.
91 * fileio.c: Report proper errno when syscall falls.
92 (Finsert_file_contents): Save and restore errno,
93 so that report_file_error outputs the correct diagnostic.
94 (Fwrite_region) [CLASH_DETECTION]: Likewise.
96 2011-09-18 Eli Zaretskii <eliz@gnu.org>
98 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
100 2011-09-17 Eli Zaretskii <eliz@gnu.org>
102 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
103 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
105 2011-09-17 Eli Zaretskii <eliz@gnu.org>
107 * xdisp.c (reseat_at_next_visible_line_start): Keep information
108 about the current paragraph and restore it after the call to
111 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
112 (bidi_find_paragraph_start): Search back for paragraph beginning
113 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
114 (bidi_move_to_visually_next): Only trigger paragraph-related
115 computations when the last character is a newline or at EOB, not
116 just any NEUTRAL_B. (Bug#9470)
118 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
119 truncated lines if point is covered by a display string. (Bug#9524)
121 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
123 * xselect.c: Relax test for outgoing X longs (Bug#9498).
124 (cons_to_x_long): New function.
125 (lisp_data_to_selection_data): Use it. Correct the test for
126 short-versus-long data; it was negated. Break out of vector
127 loop, for efficiency, when a long datum is discovered.
129 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
131 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
133 2011-09-16 Eli Zaretskii <eliz@gnu.org>
135 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
136 GCC PR/17406) by declaring this function with external scope.
138 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
140 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
141 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
143 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
145 * editfns.c (Fformat): Correctly handle text properties on "%%".
147 2011-09-15 Eli Zaretskii <eliz@gnu.org>
149 * xterm.c (x_draw_composite_glyph_string_foreground):
150 * w32term.c (x_draw_composite_glyph_string_foreground):
151 * term.c (encode_terminal_code):
152 * composite.c (composition_update_it, get_composition_id):
153 * xdisp.c (get_next_display_element)
154 (fill_composite_glyph_string): Add comments about special meaning
155 of TAB characters in a composition.
157 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
159 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
160 This occurs when processing a multibyte format.
161 Problem reported by Wolfgang Jenker.
163 2011-09-15 Johan Bockgård <bojohan@gnu.org>
165 * xdisp.c (try_cursor_movement): Only check for exact match if
166 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
168 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
170 Remove unused external symbols.
171 * dispextern.h (calc_pixel_width_or_height): Remove decl.
172 * xdisp.c (calc_pixel_width_or_height): Now static.
173 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
174 * indent.c (check_display_width):
175 * w32term.c: Fix comment to match code.
176 * xterm.c, xterm.h (x_catching_errors): Remove.
178 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
180 * xselect.c: Use signed conversions more consistently (Bug#9498).
181 (selection_data_to_lisp_data): Assume incoming selection data are
182 signed integers, not unsigned. This is to be consistent with
183 outgoing selection data, which was modified to use signed integers
184 in as part of the fix to Bug#9196 in response to Jan D.'s comment
185 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
186 expects long, not unsigned long.
188 2011-09-14 Eli Zaretskii <eliz@gnu.org>
190 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
191 computation of loop end. Reported by Johan Bockgård
194 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
196 * frame.c (Fother_visible_frames_p): Function deleted.
198 2011-09-12 Eli Zaretskii <eliz@gnu.org>
200 * indent.c (compute_motion): Process display vector front to back
201 rather than the other way around. (Bug#2496)
203 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
205 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
207 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
209 * minibuf.c (Fread_from_minibuffer): Doc fix.
211 2011-09-11 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
214 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
216 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
218 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
219 value for non-existent files.
221 2011-09-11 Eli Zaretskii <eliz@gnu.org>
223 * fileio.c (Finsert_file_contents): If the file cannot be opened,
224 set its "size" to -1. This will set the modtime_size field of
225 the corresponding buffer to -1, which is what
226 verify-visited-file-modtime expects for files that do not exist.
229 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
231 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
233 * lisp.h: ... from here. push_key_description is no longer
234 defined in keyboard.c, so its declaration should not be in
235 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
236 logically belongs with push_key_description.
238 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
240 * buffer.h: Include <sys/types.h> instead of <time.h>.
241 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
242 Problem reported by Herbert J. Skuhra.
244 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
246 * xml.c (parse_region): Make the parsing work for
247 non-comment-starting XML files again (bug#9144).
249 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
251 * image.c (gif_load): Fix calculation of bottom and right corner.
254 2011-09-10 Eli Zaretskii <eliz@gnu.org>
256 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
257 redisplay in small windows.
259 2011-09-09 Eli Zaretskii <eliz@gnu.org>
261 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
263 2011-09-08 Martin Rudalics <rudalics@gmx.at>
265 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
266 Operate on live windows only.
268 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
270 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
272 2011-09-07 Eli Zaretskii <eliz@gnu.org>
274 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
275 only under bidi iteration.
277 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
279 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
281 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
283 isnan: Fix porting problem to Solaris 10 with bundled gcc.
284 Without this fix, the command to link temacs failed due to an
285 undefined symbol __builtin_isnan. This is because
286 /usr/include/iso/math_c99.h #defines isnan(x) to
287 __builtin_isnan(x), but the bundled gcc, which identifies itself
288 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
290 * floatfns.c (isnan): #undef, and then #define to a clone of
292 (Fisnan): Always define, since it's always available now.
293 (syms_of_floatfns): Always define isnan at the Lisp level.
295 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
297 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
299 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
301 * fileio.c: Fix bugs with large file offsets (Bug#9428).
302 The previous code assumed that file offsets (off_t values) fit in
303 EMACS_INT variables, which is not true on typical 32-bit hosts.
304 The code messed up by falsely reporting buffer overflow in cases
305 such as (insert-file-contents "big" nil 1 2) into an empty buffer
306 when "big" contains more than 2**29 bytes, even though this
307 inserts just one byte and does not overflow the buffer.
308 (Finsert_file_contents): Store file offsets as off_t
309 values, not as EMACS_INT values. Check for overflow when
310 converting between EMACS_INT and off_t. When checking for
311 buffer overflow or for overlap, take the offsets into account.
312 Don't use EMACS_INT for small values where int suffices.
313 When checking for overlap, fix a typo: ZV was used where
314 ZV_BYTE was intended.
315 (Fwrite_region): Don't assume off_t fits into 'long'.
316 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
318 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
320 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
322 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
324 sprintf-related integer and memory overflow issues (Bug#9412).
326 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
327 (esprintf, exprintf, evxprintf): New functions.
328 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
329 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
330 (modify_event_symbol): Do not assume that the length of
331 name_alist_or_stem is safe to alloca and fits in int.
332 (Fexecute_extended_command): Likewise for function name and binding.
333 (Frecursion_depth): Wrap around reliably on integer overflow.
334 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
335 since some callers pass EMACS_INT values.
336 (Fsingle_key_description): Don't crash if symbol name contains more
337 than MAX_ALLOCA bytes.
338 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
339 (get_minibuffer): Arg is now EMACS_INT, not int.
340 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
341 (esprintf, exprintf, evxprintf): New decls.
342 * window.h (command_loop_level, minibuf_level): Reflect API changes.
344 * dbusbind.c (signature_cat): New function.
345 (xd_signature, Fdbus_register_signal):
346 Do not overrun buffer; instead, report string overflow.
348 * dispnew.c (add_window_display_history): Don't overrun buffer.
349 Truncate instead; this is OK since it's just a log.
351 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
352 even if the time zone offset is outlandishly large.
353 Don't mishandle offset == INT_MIN.
355 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
356 when creating daemon; the previous buffer-overflow check was incorrect.
358 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
359 which has the guts of the old verror function.
361 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
362 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
364 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
365 (font_unparse_xlfd): Don't blindly alloca long strings.
366 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
367 fits in int, when using sprintf. Use single snprintf to count
368 length of string rather than counting it via multiple sprintfs;
369 that's simpler and more reliable.
370 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
371 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
372 sprintf, in case result does not fit in int.
374 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
375 (fontset_from_font): Print it.
377 * frame.c (tty_frame_count): Now printmax_t, not int.
378 (make_terminal_frame, set_term_frame_name): Print it.
379 (x_report_frame_params): In X, window IDs are unsigned long,
380 not signed long, so print them as unsigned.
381 (validate_x_resource_name): Check for implausibly long names,
382 and don't assume name length fits in 'int'.
383 (x_get_resource_string): Don't blindly alloca invocation name;
384 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
387 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
388 (xg_check_special_colors, xg_set_geometry):
389 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
391 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
392 Use esprintf, not sprintf, in case result does not fit in int.
394 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
395 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
396 it as a large positive number.
397 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
398 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
400 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
401 in case result does not fit in int.
403 * print.c (float_to_string): Detect width overflow more reliably.
404 (print_object): Make sprintf buffer a bit bigger, to avoid potential
405 buffer overrun. Don't assume list length fits in 'int'. Treat
406 print length of 0 as 0, not as infinity; to be consistent with other
407 uses of print length in this function. Don't overflow print length
408 index. Don't assume hash table size fits in 'long', or that
409 vectorlike size fits in 'unsigned long'.
411 * process.c (make_process): Use printmax_t, not int, to format
412 process-name gensyms.
414 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
416 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
417 to avoid potential buffer overrun.
419 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
420 if X resource line is longer than 512 bytes.
422 * xfns.c (x_window): Make sprintf buffer a bit bigger
423 to avoid potential buffer overrun.
425 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
427 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
429 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
431 Integer overflow fixes for scrolling, etc.
432 Without these, Emacs silently mishandles large integers sometimes.
433 For example, "C-u 4294967297 M-x recenter" was treated as if
434 it were "C-u 1 M-x recenter" on a typical 64-bit host.
436 * xdisp.c (try_window_id): Check Emacs fixnum range before
439 * window.c (window_scroll_line_based, Frecenter):
440 Check that an Emacs fixnum is in range before assigning it to 'int'.
441 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
442 values converted from Emacs fixnums.
443 (Frecenter): Don't wrap around a line count if it is out of 'int'
444 range; instead, treat it as an extreme value.
445 (Fset_window_configuration, compare_window_configurations):
446 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
448 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
449 that can exceed INT_MAX. Check that EMACS_INT value is in range
450 before assigning it to the (possibly-narrower) index.
451 (match_limit): Don't assume that a fixnum can fit in 'int'.
453 * print.c (print_object): Use ptrdiff_t, not int, for index that can
456 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
457 (Fvertical_motion): Don't wrap around LINES values that don't fit
458 in 'int'. Instead, treat them as extreme values. This is good
459 enough for windows, which can't have more than INT_MAX lines anyway.
461 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
463 * Require libxml/parser.h to avoid compilation warning.
465 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
467 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
468 since this reportedly can destroy thread storage.
470 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
472 * syntax.c (find_defun_start): Update all cache variables if
473 exiting early (Bug#9401).
475 2011-08-30 Eli Zaretskii <eliz@gnu.org>
477 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
479 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
480 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
481 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
483 * term.c (tty_append_glyph): New function.
484 (produce_stretch_glyph): Static function and its prototype deleted.
486 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
489 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
491 * image.c (parse_image_spec): Check for nonnegative, not for positive,
492 when checking :margin (Bug#9390).
493 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
494 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
495 so that the name doesn't mislead. All uses changed.
497 2011-08-28 Johan Bockgård <bojohan@gnu.org>
499 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
502 2011-08-27 Eli Zaretskii <eliz@gnu.org>
504 * xdisp.c (move_it_to): Don't bail out early when reaching
505 position beyond to_charpos, if we are scanning backwards.
506 (move_it_vertically_backward): When DY == 0, make sure we get to
507 the first character in the line after the newline.
509 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
511 * ccl.c: Improve and simplify overflow checking (Bug#9196).
512 (ccl_driver): Do not generate an out-of-range pointer.
513 (Fccl_execute_on_string): Remove unnecessary check for
514 integer overflow, noted by Stefan Monnier in
515 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
516 Remove a FIXME that didn't need fixing.
517 Simplify the newly-introduced buffer reallocation code.
519 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
521 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
523 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
525 Integer and memory overflow issues (Bug#9196).
527 * doc.c (get_doc_string): Rework so that
528 get_doc_string_buffer_size is the actual buffer size, rather than
529 being 1 less than the actual buffer size; this makes xpalloc more
532 * image.c (x_allocate_bitmap_record, cache_image):
533 * xselect.c (Fx_register_dnd_atom):
534 Simplify previous changes by using xpalloc.
536 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
537 since either will do and ptrdiff_t is convenient with xpalloc.
539 * charset.c (charset_table_size)
540 (struct charset_sort_data.priority): Now ptrdiff_t.
541 (charset_compare): Don't overflow if priorities differ greatly.
542 (Fsort_charsets): Don't assume list length fits in int.
543 Check for size-calculation overflow when allocating sort data.
544 (syms_of_charset): Allocate an initial charset table that is
545 just under 64 KiB, to avoid problems with glibc malloc and mmap.
547 * cmds.c (internal_self_insert): Check for size-calculation overflow.
549 * composite.h (struct composition.glyph_len): Now int, not unsigned.
550 The actual value is always <= INT_MAX, and leaving it unsigned made
551 overflow checking harder.
553 * dispextern.h (struct glyph_matrix.rows_allocated)
554 (struct face_cache.size): Now ptrdiff_t, for convenience in use
555 with xpalloc. The values are still always <= INT_MAX.
557 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
559 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
560 (SAFE_NALLOCA): New macro.
562 * region-cache.c (struct boundary.pos, find_cache_boundary)
563 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
564 (set_cache_region, invalidate_region_cache)
565 (revalidate_region_cache, know_region_cache, region_cache_forward)
566 (region_cache_backward, pp_cache):
567 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
568 so that ptrdiff_t * can be passed to xpalloc.
569 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
570 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
571 (pp_cache): Don't assume cache_len fits in int.
572 * region-cache.h: Adjust extern decls to match.
574 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
575 EMACS_INT, since either will do, for xpalloc.
577 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
578 (xnmalloc, xnrealloc, xpalloc): New functions.
580 * bidi.c (bidi_shelve_header_size): New constant.
581 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
582 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
584 * bidi.c (bidi_cache_shrink):
585 * buffer.c (overlays_at, overlays_in, record_overlay_string)
587 Don't update size of array until after memory allocation succeeds,
588 because xmalloc/xrealloc may not return.
589 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
590 now that we have proper integer overflow checking.
591 (record_overlay_string, overlay_strings): Catch overflows when
592 calculating size of overlay_str_buf.
594 * callproc.c (Fcall_process): Check for size overflow when
595 calculating size of args2.
596 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
597 Normally we prefer signed values, but sticking with ptrdiff_t would
598 require adding more-complicated checks.
600 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
601 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
602 Redo buffer-overflow calculations to avoid integer overflow.
603 Add a FIXME comment where memory seems to be over-allocated.
605 * character.c (Fstring): Check for size-calculation overflow.
607 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
608 unnecessary integer overflow. Check for size overflow.
609 (encode_coding_object): Don't update size until xmalloc succeeds.
611 * composite.c (get_composition_id): Check for overflow in glyph
614 Integer and memory overflow fixes for display code.
615 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
616 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
617 (scrolling_window): Check for overflow in size calculations.
618 (line_draw_cost, realloc_glyph_pool, add_row_entry):
619 Don't assume glyph table len fits in int.
620 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
621 (row_table_size): Now ptrdiff_t, not int.
622 (scrolling_window): Avoid overflow in size calculations.
623 Don't update size until allocation succeeds.
624 * fns.c (concat): Check for overflow in size calculations.
625 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
626 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
627 (NEXT_ALMOST_PRIME_LIMIT): New constant.
629 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
630 (get_doc_string): Check for size calculation overflow.
631 Don't update size until allocation succeeds.
632 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
633 EMACS_INT, where ptrdiff_t will do.
634 (Fsubstitute_command_keys): Check for string overflow.
636 * editfns.c (set_time_zone_rule): Don't assume environment length
638 (message_length): Now ptrdiff_t, not int.
639 (Fmessage_box): Don't update size until allocation succeeds.
640 Don't assume message length fits in int.
641 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
643 * emacs.c (main): Do not reallocate argv, since there is a null at
644 the end that can be overwritten, and this way there's no need to
645 worry about size-calculation overflow.
646 (sort_args): Check for size-calculation overflow.
648 * eval.c (init_eval_once, grow_specpdl): Don't update size until
650 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
652 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
653 (x_set_scroll_bar_width, x_figure_window_size):
654 Check for integer overflow.
655 (x_set_alpha): Do not assume XINT fits in int.
657 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
658 This is for the members text_lines, text_cols, total_lines, total_cols,
659 where the system imposes an 'int' limit.
661 * fringe.c (Fdefine_fringe_bitmap):
662 Don't update size until alloc works.
664 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
665 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
667 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
668 Check for size-calculation overflow.
669 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
670 do, as we prefer signed integers.
671 (id_to_widget.max_size, id_to_widget.used)
672 (xg_store_widget_in_map, xg_remove_widget_from_map)
673 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
674 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
675 Use and return ptrdiff_t, not int.
676 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
677 * gtkutil.h: Change prototypes to match the above.
679 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
680 are duplicate now that they've been promoted to lisp.h.
681 (x_allocate_bitmap_record, x_alloc_image_color)
682 (make_image_cache, cache_image, xpm_load):
683 Don't update size until alloc is done.
684 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
686 Check for size calculation overflow.
687 (ct_colors_allocated_max): New constant.
688 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
691 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
692 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
693 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
694 Use ptrdiff_t, not int, to count maps.
695 (read_char_minibuf_menu_prompt): Check for overflow in size
696 calculations. Don't update size until allocation succeeds. Redo
697 calculations to avoid overflow.
698 * keyboard.h: Change prototypes to match the above.
700 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
702 (current_minor_maps): Check for size calculation overflow.
703 * keymap.h: Change prototypes to match the above.
705 * lread.c (read1, init_obarray): Don't update size until alloc done.
707 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
708 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
710 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
711 Now ptrdiff_t, not int.
712 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
713 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
715 * process.c (Fnetwork_interface_list): Check for overflow
718 * region-cache.c (move_cache_gap): Check for size calculation overflow.
720 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
721 overflow. Don't bother calling xmalloc when xrealloc will do.
723 * search.c (Freplace_match): Check for size calculation overflow.
724 (Fset_match_data): Don't assume list lengths fit in 'int'.
726 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
727 for command line length. Do not attempt to address one before the
728 beginning of an array, as that's not portable.
730 * term.c (max_frame_lines): Remove; unused.
731 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
733 (encode_terminal_code, calculate_costs): Check for size
734 calculation overflow.
735 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
736 table lengths and related sizes. Don't update size until alloc
737 done. Redo calculations to avoid overflow.
738 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
740 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
741 subtracting pointers.
742 (gobble_line): Check for overflow more carefully. Don't update size
745 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
746 Don't update size until alloc done.
747 Redo size calculations to avoid overflow.
748 Check for size calculation overflow.
749 (main) [DEBUG]: Fix typo in invoking tparam1.
751 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
752 Use ptrdiff_t, not int, for sizes.
753 (store_mode_line_noprop_char): Don't update size until alloc done.
755 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
756 Use ptrdiff_t, not int, for sizes.
757 (Finternal_make_lisp_face, cache_face):
758 Check for size calculation overflow.
759 (cache_face): Treat size calculation overflows as if they were
760 memory exhaustion (the usual treatment), rather than aborting.
762 * xfns.c (x_encode_text, x_set_name_internal)
763 (Fx_change_window_property): Use ptrdiff_t, not int, to count
764 sizes, since they can exceed INT_MAX in size. Check for size
765 calculation overflow.
767 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
768 (xg_select): Check for size calculation overflow.
769 Don't update size until alloc done.
771 * xrdb.c (get_environ_db): Don't assume path length fits in int,
772 as sprintf is limited to int lengths.
774 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
775 (X_LONG_MIN): New macros.
776 Use them to make the following changes clearer.
777 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
778 This change doesn't affect the value now, but it may help remind
779 future maintainers not to raise the value too much later.
780 (SELECTION_QUANTUM): Remove, replacing with ...
781 (selection_quantum): ... new function, which avoids overflow.
783 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
784 assumption that selection length fits in 'int'.
785 (x_reply_selection_request, x_handle_selection_request)
786 (x_get_window_property, receive_incremental_selection)
787 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
788 (lisp_data_to_selection_data, clean_local_selection_data):
789 Use ptrdiff_t, not int, to record length of selection.
790 (x_reply_selection_request, x_get_window_property)
791 (receive_incremental_selection, x_property_data_to_lisp):
792 Redo calculations to avoid overflow.
793 (x_reply_selection_request): When sending hint, ceiling it at
794 X_LONG_MAX rather than relying on wraparound overflow to send
796 (x_get_window_property, receive_incremental_selection)
797 (lisp_data_to_selection_data, x_property_data_to_lisp):
798 Check for size-calculation overflow.
799 (x_get_window_property, receive_incremental_selection)
800 (lisp_data_to_selection_data, Fx_register_dnd_atom):
801 Don't store size until memory allocation succeeds.
802 (x_get_window_property): Plug memory leak on memory exhaustion.
803 Don't double-block input; malloc is safe here. Don't assume 2**34
804 - 4 fits in unsigned long. Add an xassert to check
805 XGetWindowProperty overflow. Be more careful about overflow
806 calculations, and distinguish size from memory overflow better.
807 (receive_incremental_selection): When tracing, don't assume
808 unsigned int is less than INT_MAX.
809 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
810 harmful) conversions of unsigned short to int.
811 (lisp_data_to_selection_data): Don't assume that integers
812 in the range -65535 through -1 fit in an X unsigned short.
813 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
814 result parameters unless successful. Rely on cons_to_unsigned
815 to report problems with elements; the old code wasn't right anyway.
816 (x_check_property_data): Check for int overflow; we cannot use
817 a wider type due to X limits.
818 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
820 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
822 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
823 (x_term_init): Check for size calculation overflow.
824 (x_color_cells): Don't store size until memory allocation succeeds.
825 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
826 Don't assume alloca size is less than MAX_ALLOCA.
827 (x_term_init): Don't assume length fits in int (sprintf is limited
830 Use ptrdiff_t for composition IDs.
831 * character.c (lisp_string_width):
832 * composite.c (composition_table_size, n_compositions)
833 (get_composition_id, composition_gstring_from_id):
834 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
835 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
836 * window.c (Frecenter):
837 Use ptrdiff_t, not int, for composition IDs.
838 * composite.c (get_composition_id): Check for integer overflow.
839 * composite.h: Adjust prototypes to match the above changes.
841 Use ptrdiff_t for hash table indexes.
842 * category.c (hash_get_category_set):
843 * ccl.c (ccl_driver):
844 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
845 * coding.c (coding_system_charset_list, detect_coding_system):
846 * coding.h (struct coding_system.id):
847 * composite.c (get_composition_id, gstring_lookup_cache):
848 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
849 * image.c (xpm_get_color_table_h):
850 * lisp.h (hash_lookup, hash_put):
851 * minibuf.c (Ftest_completion):
852 Use ptrdiff_t for hash table indexes, not int (which is too
853 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
854 32-bit --with-wide-int hosts).
856 * charset.c (Fdefine_charset_internal): Check for integer overflow.
857 Add a FIXME comment about memory leaks.
858 (syms_of_charset): Don't assume xmalloc returns.
860 Don't assume that stated character widths fit in int.
861 * character.c (Fchar_width, c_string_width, lisp_string_width):
862 * character.h (CHAR_WIDTH):
863 * indent.c (MULTIBYTE_BYTES_WIDTH):
864 Use sanitize_char_width to avoid undefined and/or bad behavior
865 with outlandish widths.
866 * character.h (sanitize_tab_width): Renamed from sanitize_width,
867 now that we have two such functions. All uses changed.
868 (sanitize_char_width): New inline function.
870 Don't assume that tab-width fits in int.
871 * character.h (sanitize_width): New inline function.
872 (SANE_TAB_WIDTH): New macro.
873 (ASCII_CHAR_WIDTH): Use it.
874 * indent.c (sane_tab_width): Remove. All uses replaced by
875 SANE_TAB_WIDTH (current_buffer).
876 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
878 * fileio.c: Integer overflow issues with file modes.
879 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
881 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
882 Remove unreachable code.
883 (read_hex, load_charset_map_from_file): Check for integer overflow.
885 * xterm.c: don't go over XClientMessageEvent limit
886 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
887 (x_send_scroll_bar_event): Likewise. Check that the size does not
888 exceed limits imposed by XClientMessageEvent, as well as the usual
889 ptrdiff_t and size_t limits.
891 * keyboard.c: Overflow, signedness and related fixes.
892 (make_lispy_movement): Use same integer type in forward decl
893 that is used in the definition.
894 (read_key_sequence, keyremap_step):
895 Change bufsize argument back to int, undoing my 2011-03-30 change.
896 We prefer signed types, and int is wide enough here.
897 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
898 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
899 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
900 length, not size_t. Use ptrdiff_t for index, not int.
901 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
902 possibility of integer overflow.
904 Overflow, signedness and related fixes for images.
906 * dispextern.h (struct it.stack[0].u.image.image_id)
907 (struct_it.image_id, struct image.id, struct image_cache.size)
908 (struct image_cache.used, struct image_cache.ref_count):
909 * gtkutil.c (update_frame_tool_bar):
910 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
911 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
912 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
913 * nsmenu.m (update_frame_tool_bar):
914 * xdisp.c (calc_pixel_width_or_height):
915 * xfns.c (image_cache_refcount):
916 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
917 on typical 64-bit hosts.
919 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
920 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
921 Omit unnecessary casts to int.
922 (parse_image_spec): Check that integers fall into 'int' range
923 when the callers expect that.
924 (image_ascent): Redo ascent calculation to avoid int overflow.
925 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
926 (lookup_image): Remove unnecessary tests.
927 (xbm_image_p): Locals are now of int, not EMACS_INT,
928 since parse_image_check makes sure they fit into int.
929 (png_load, gif_load, svg_load_image):
930 Prefer int to unsigned where either will do.
931 (tiff_handler): New function, combining the cores of the
932 old tiff_error_handler and tiff_warning_handler. This
933 function is rewritten to use vsnprintf and thereby avoid
934 stack buffer overflows. It uses only the features of vsnprintf
935 that are common to both POSIX and native Microsoft.
936 (tiff_error_handler, tiff_warning_handler): Use it.
937 (tiff_load, gif_load, imagemagick_load_image):
938 Don't assume :index value fits in 'int'.
939 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
940 (imagemagick_load_image): Check that crop parameters fit into
941 the integer types that MagickCropImage accepts. Don't assume
942 Vimagemagick_render_type has a nonnegative value. Don't assume
943 size_t fits in 'long'.
944 (gs_load): Use printmax_t to print the widest integers possible.
945 Check for integer overflow when computing image height and width.
947 2011-08-26 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (redisplay_window): Don't force window start if point
950 will be invisible in the resulting window. (Bug#9324)
952 2011-08-25 Eli Zaretskii <eliz@gnu.org>
954 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
955 the display spec is of the form `(space ...)'.
956 (handle_display_spec): Return the value returned by
957 handle_single_display_spec, not just 1 or zero.
958 (handle_single_display_spec): If the display spec is of the form
959 `(space ...)', and specifies display in the text area, return 2
961 (try_cursor_movement): Check for the need to scroll more
962 accurately, and prefer exact match for point under bidi. Don't
963 advance `row' beyond the last row of the window.
965 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
966 into disp_prop; all users changed.
968 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
969 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
970 for the text covered by the display property.
972 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
974 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
975 Change return value to nil.
976 (Frecord_buffer): Delete unused function.
978 2011-08-24 Eli Zaretskii <eliz@gnu.org>
980 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
981 buffers, return left-to-right.
982 (set_cursor_from_row): Consider candidate row a win if its glyph
983 represents a newline and point is on that newline. Fixes cursor
984 positioning on the newline at EOL of R2L text within L2R
985 paragraph, and vice versa.
986 (try_cursor_movement): Check continued rows, in addition to
987 continuation rows. Fixes unwarranted scroll when point enters a
988 continued line of R2L text within an L2R paragraph, or vice versa.
989 (cursor_row_p): Consider the case of point being equal to
990 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
991 from the end of a short line to the beginning of a continued line
992 of R2L text within L2R paragraph.
993 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
996 * bidi.c (bidi_check_type): Use xassert.
997 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1000 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1002 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1005 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1007 * nsfont.m (ns_otf_to_script): Fix typo.
1009 2011-08-22 Kenichi Handa <handa@m17n.org>
1011 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1012 extra slot even if the purpose is char-code-property-table.
1014 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1016 * xdisp.c (redisplay_window): When computing centering_position,
1017 account for the height of the header line. (Bug#8874)
1019 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1020 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1021 candidate is selected by the mouse, and that candidate has a
1022 composed character under the mouse.
1024 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1025 coordinates reported by pos-visible-in-window-p for a composed
1026 character in column zero.
1028 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1030 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1032 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1034 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1035 consider it a hit if to_charpos is anywhere in the range of the
1036 composed buffer positions.
1038 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1040 * image.c (gif_load): Don't assume that each subimage has the same
1041 dimensions as the base image. Handle disposal method that is
1042 "undefined" by the gif spec (Bug#9335).
1044 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1046 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1047 (Fcondition_case): Document `debug' symbol in error handler.
1049 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1051 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1052 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1053 from an Org mode buffer to a Speedbar frame.
1055 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1056 a composition, take its buffer position from IT->cmp_it.charpos.
1057 Fixes cursor positioning at the beginning of a line that begins
1058 with a composed character.
1060 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1062 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1063 character bidirectional type, use STRONG_L instead. Fixes crashes
1064 in a buffer produced by `describe-categories'.
1066 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1067 members before the level stack, so they would be saved and
1068 restored when copying iterator state. Fixes incorrect reordering
1069 around TABs covered by display properties.
1071 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1073 * process.c (Fnetwork_interface_list): Correctly determine buffer
1076 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1078 * eval.c (internal_condition_case, internal_condition_case_1)
1079 (internal_condition_case_2, internal_condition_case_n):
1080 Remove unnecessary aborts (Bug#9081).
1082 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1084 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1085 has no `load' handler, try opening the file locally. (Bug#9311)
1087 2011-08-16 Ken Brown <kbrown@cornell.edu>
1089 * gmalloc.c: Expand comment.
1091 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1093 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1094 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1096 2011-08-16 Ken Brown <kbrown@cornell.edu>
1098 Fix memory allocation problems in Cygwin build (Bug#9273).
1100 * unexcw.c ( __malloc_initialized): Declare external variable.
1101 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1103 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1105 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1107 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1109 [CYGWIN] (special_realloc): New function.
1110 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1111 requests to realloc storage in the static heap.
1113 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1115 * bidi.c (bidi_initialize): Remove unused local.
1117 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1119 * biditype.h: File removed.
1121 * bidimirror.h: File removed.
1123 * deps.mk (bidi.o): Remove biditype.h and
1126 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1129 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1131 * chartab.c: Improve commentary for the uniprop_table API.
1133 * bidi.c (bidi_paragraph_init): Support zero value of
1134 bidi_ignore_explicit_marks_for_paragraph_level.
1135 (bidi_initialize): Use uniprop_table instead of including
1136 biditype.h and bidimirror.h.
1138 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1139 coordinates of the iterator when restoring from ppos_it.
1142 2011-08-14 Kenichi Handa <handa@m17n.org>
1144 * process.c (create_process): Call setup_process_coding_systems
1145 after the pid of the process is set to -1 (Bug#8162).
1147 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1149 * xdisp.c (move_it_in_display_line_to): Don't invoke
1150 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1151 ppos_it. Fixes vertical cursor motion when line beginning is
1152 covered by an image. (Bug#9296)
1154 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1156 * nsterm.h (ns_run_ascript): Declare.
1157 (NSAPP_DATA2_RUNASSCRIPT): Define.
1159 * nsfns.m (as_script, as_result, as_status): New static variables.
1160 (ns_run_ascript): New function.
1161 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1162 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1163 the event loop. Get status from as_status (Bug#7276).
1165 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1166 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1167 the event loop (Bug#7276).
1169 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1171 * gnutls.c (QCgnutls_bootprop_priority)
1172 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1173 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1174 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1175 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1176 (QCgnutls_bootprop_verify_hostname_error)
1177 (QCgnutls_bootprop_callbacks_verify): Rename from
1178 Qgnutls_bootprop_..., all uses changed.
1180 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1183 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1185 * xfaces.c (Qframe_set_background_mode): Now static.
1186 * dispextern.h (Qframe_set_background_mode): Remove decl.
1188 * process.c (Fnetwork_interface_info): Declare local only if needed.
1190 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1192 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1193 (Fnetwork_interface_list): Allocate in increments of bytes instead
1194 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1195 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1197 (struct ifflag_def): notrailers is smart on OSX.
1198 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1199 Get hardware address with getifaddrs if available.
1201 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1203 * xdisp.c (iterate_out_of_display_property): xassert that
1204 IT->position is set to within IT->object's boundaries. Break from
1205 the loop as soon as EOB is reached; avoids infloops in redisplay
1206 when IT->position is set up wrongly due to some bug.
1207 Set IT->current to match the bidi iterator unconditionally.
1208 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1209 entry. Force push_it to save on the stack the current
1210 buffer/string position, to be restored by pop_it. Fix flags in
1211 the iterator structure wrt the object coming from a display
1212 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1213 properties. (Bug#9284)
1215 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1217 * fontset.c (fontset_get_font_group): Add proper type checks.
1220 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1222 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1223 and LC_VERSION_MIN_MACOSX.
1224 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1225 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1227 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1229 * xdisp.c (forward_to_next_line_start): Allow to use the
1230 no-display-properties-and-no-overlays under bidi display.
1231 Set disp_pos in the bidi iterator to avoid searches for display
1232 properties and overlays.
1234 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1236 * editfns.c (Fset_time_zone_rule): Document relationship with the
1239 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1240 the font entity extracted from the cache (Bug#8109).
1242 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1244 * composite.c (autocmp_chars): Don't reset point. That is done by
1245 restore_point_unwind (Bug#5984).
1247 2011-08-07 Juri Linkov <juri@jurta.org>
1249 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1250 to show the arg `TIME' instead of `TIMEVAL'.
1252 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1254 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1255 display property strides EOL and includes a newline, as in
1256 longlines-mode. (Bug#9254)
1257 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1258 word-wrap under bidirectional display. (Bug#9224)
1260 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1261 is non-zero, even if the data buffer is NULL. Fixes a crash in
1262 vertical-motion with longlines-mode. (Bug#9254)
1264 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1266 * bidi.c <bidi_cache_total_alloc>: Now static.
1267 (bidi_initialize): Initialize bidi_cache_total_alloc.
1269 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1272 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1273 amount allocated this far in `bidi_cache_total_alloc'.
1274 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1275 non-zero, only free the data buffer without restoring the cache
1276 contents. All callers changed.
1278 * dispextern.h (bidi_unshelve_cache): Update prototype.
1280 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1281 (move_it_in_display_line, move_it_to)
1282 (move_it_vertically_backward, move_it_by_lines): Replace the call
1283 to xfree to an equivalent call to bidi_unshelve_cache.
1284 (move_it_in_display_line_to): Fix logic of returning
1285 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1287 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1289 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1290 came from a string character with a `cursor' property. (Bug#9229)
1292 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1294 * Makefile.in (LIB_PTHREAD): New variable.
1295 (LIBES): Add LIB_PTHREAD (Bug#9216).
1297 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1298 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1300 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1302 * regex.c (re_iswctype): Remove some redundant boolean
1305 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1307 * xterm.c (x_find_topmost_parent): New function.
1308 (x_set_frame_alpha): Find topmost parent window with
1309 x_find_topmost_parent and set the property there also (bug#9181).
1310 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1312 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1314 * callproc.c (Fcall_process): Avoid vfork clobbering
1315 the local vars buffer, coding_systems, current_dir.
1317 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1319 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1321 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1323 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1324 so that it is not optimized away.
1326 * xdisp.c (compute_display_string_pos): Remove unused local.
1328 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1330 Fix slow cursor motion and scrolling in large buffers with
1331 selective display, like Org Mode buffers. (Bug#9218)
1333 * dispextern.h (struct bidi_it): New member disp_prop_p.
1335 * xdisp.c: Remove one-slot cache of display string positions.
1336 (compute_display_string_pos): Accept an additional argument
1337 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1338 for a display string or property. If found, set DISP_PROP_P
1341 * bidi.c (bidi_fetch_char): Accept an additional argument
1342 DISP_PROP_P, and pass it to compute_display_string_pos.
1343 Only handle text covered by a display string if DISP_PROP_P is returned
1344 non-zero. All callers of bidi_fetch_char changed.
1346 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1348 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1350 2010-12-03 Don March <don@ohspite.net>
1352 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1353 last character M-[char] is translated to ESC [char] (bug#7541).
1355 2011-08-02 Kenichi Handa <handa@m17n.org>
1357 * lisp.h (uniprop_table): Extern it.
1359 * chartab.c (uniprop_table): Make it non-static.
1361 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1363 * xdisp.c (forward_to_next_line_start): Accept additional argument
1364 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1366 (reseat_at_next_visible_line_start): Use the bidi iterator state
1367 returned by forward_to_next_line_start to restore the state of
1368 it->bidi_it after backing up to previous newline. (Bug#9212)
1370 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1372 * regex.c (re_comp): Protoize.
1373 (re_exec): Fix return type.
1374 (regexec): Fix type of `ret'. (Bug#9203)
1376 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1378 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1379 This is needed if max-image-size is a floating-point number.
1381 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1383 * print.c (print_object): Print empty symbol as ##.
1385 * lread.c (read1): Read ## as empty symbol.
1387 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1389 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1390 setting frame foreground color (Bug#9175).
1391 (x_set_background_color): Likewise.
1393 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1394 contents (Bug#9176).
1395 (EmacsTooltip -init): Remove bezels and add shadows to
1398 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1399 or scroll bar (Bug#8470).
1401 * nsfont.m (nsfont_open): Remove assignment to voffset and
1402 unnecessary vars hshink, expand, hd, full_height, min_height.
1403 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1405 * nsterm.h (nsfont_info): Remove voffset field.
1407 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1409 Implement strike-through and overline on NextStep (Bug#8863).
1411 * nsfont.m (nsfont_open): Use underline position provided by font,
1412 instead of hard-coded value of 2.
1413 (nsfont_draw): Call ns_draw_text_decoration instead.
1415 * nsterm.h: Add declaration for ns_draw_text_decoration.
1417 * nsterm.m (ns_draw_text_decoration): New function for drawing
1418 underline, overline, and strike-through.
1419 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1420 ns_draw_text_decoration. Change treatment of cursor drawing to
1421 accommodate underlining, etc.
1423 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1425 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1428 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1430 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1431 Without this fix, if a signal arrives just after memory fills up,
1432 'malloc' might be invoked reentrantly.
1434 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1435 In other words, assume that every image size is allowed, on non-X
1436 hosts. This assumption is probably wrong, but it lets Emacs compile.
1438 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1440 * regex.c (re_iswctype): Convert return values to boolean.
1442 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1444 * xdisp.c (compute_display_string_pos): Don't use cached display
1445 string position if the buffer had its restriction changed.
1448 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1450 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1452 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1454 Integer signedness and overflow and related fixes. (Bug#9079)
1456 * bidi.c: Integer size and overflow fixes.
1457 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1458 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1459 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1460 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1461 (bidi_find_other_level_edge):
1462 Use ptrdiff_t instead of EMACS_INT where either will do.
1463 This works better on 32-bit hosts configured --with-wide-int.
1464 (bidi_cache_ensure_space): Check for size-calculation overflow.
1465 Use % rather than repeated addition, for better worst-case speed.
1466 Don't set bidi_cache_size until after xrealloc returns, because it
1468 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1469 (bidi_cache_ensure_space): Also check that the bidi cache size
1470 does not exceed that of the largest Lisp string or buffer. See Eli
1471 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1473 * alloc.c (__malloc_size_t): Remove.
1474 All uses replaced by size_t. See Andreas Schwab's note
1475 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1477 * image.c: Improve checking for integer overflow.
1478 (check_image_size): Assume that f is nonnull, since
1479 it is always nonnull in practice. This is one less thing to
1480 worry about when checking for integer overflow later.
1481 (x_check_image_size): New function, which checks for integer
1482 overflow issues inside X.
1483 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1484 This removes the need for a memory_full check.
1485 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1486 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1487 (xbm_read_bitmap_data): Change locals back to 'int', since
1488 their values must fit in 'int'.
1489 (xpm_load_image, png_load, tiff_load):
1490 Invoke x_create_x_image_and_pixmap earlier,
1491 to avoid much needless work if the image is too large.
1492 (tiff_load): Treat overly large images as if
1493 x_create_x_image_and_pixmap failed, not as malloc failures.
1494 (gs_load): Use x_check_image_size.
1496 * gtkutil.c: Omit integer casts.
1497 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1498 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1500 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1502 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1503 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1504 would wrongly return t on a 64-bit host.
1506 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1507 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1508 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1509 and therefore cause GCC to emit a bogus diagnostic in some cases.
1511 * image.c: Integer signedness and overflow and related fixes.
1512 This is not an exhaustive set of fixes, but it's time to
1513 record what I've got.
1514 (lookup_pixel_color, check_image_size): Remove redundant decls.
1515 (check_image_size): Don't assume that arbitrary EMACS_INT values
1516 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1517 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1518 (tiff_load, imagemagick_load_image):
1519 Check for overflow in size calculations.
1520 (x_create_x_image_and_pixmap): Remove unnecessary test for
1521 xmalloc returning NULL; that can't happen.
1522 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1523 (xpm_color_bucket): Use better integer hashing function.
1524 (xpm_cache_color): Don't possibly over-allocate memory.
1525 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1526 (gif_memory_source):
1527 Use ptrdiff_t, not int or size_t, to record sizes.
1528 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1529 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1530 either works, as we prefer signed integers.
1531 (tiff_read_from_memory, tiff_write_from_memory):
1532 Return tsize_t, not size_t, since that's what the TIFF API wants.
1533 (tiff_read_from_memory): Don't fail simply because the read would
1534 go past EOF; instead, return a short read.
1535 (tiff_load): Omit no-longer-needed casts.
1536 (Fimagemagick_types): Don't assume size fits into 'int'.
1538 Improve hashing quality when configured --with-wide-int.
1539 * fns.c (hash_string): New function, taken from sxhash_string.
1540 Do not discard information about ASCII character case; this
1541 discarding is no longer needed.
1542 (sxhash-string): Use it. Change sig to match it. Caller changed.
1543 * lisp.h: Declare it.
1544 * lread.c (hash_string): Remove, since we now use fns.c's version.
1545 The fns.c version returns a wider integer if --with-wide-int is
1546 specified, so this should help the quality of the hashing a bit.
1548 * emacs.c: Integer overflow minor fix.
1549 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1550 Define only if GNU_LINUX.
1551 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1553 * dispnew.c: Integer signedness and overflow fixes.
1554 Remove unnecessary forward decls, that were a maintenance hassle.
1555 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1557 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1558 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1559 (prepare_desired_row, line_draw_cost):
1560 Use int, not unsigned, where either works.
1561 (save_current_matrix, restore_current_matrix):
1562 Use ptrdiff_t, not size_t, where either works.
1563 (init_display): Check for overflow more accurately, and without
1564 relying on undefined behavior.
1566 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1567 Remove, replacing with the new symbols in lisp.h. All uses changed.
1568 * fileio.c (make_temp_name):
1569 * filelock.c (lock_file_1, lock_file):
1570 * xdisp.c (message_dolog):
1571 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1572 Use pMd etc. instead.
1573 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1574 replacing the pWIDE etc. symbols removed from editfns.c.
1576 * keyboard.h (num_input_events): Now uintmax_t.
1577 This is (very slightly) less likely to mess up due to wraparound.
1580 * buffer.c: Integer signedness fixes.
1581 (alloc_buffer_text, enlarge_buffer_text):
1582 Use ptrdiff_t rather than size_t when either will do, as we prefer
1585 * alloc.c: Integer signedness and overflow fixes.
1586 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1587 (__malloc_size_t): Default to size_t, not to int.
1588 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1589 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1590 Prefer ptrdiff_t to size_t when either would do, as we prefer
1592 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1593 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1594 Now const. Initialize with values that are in range even if char
1596 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1597 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1598 These functions do the right thing with sizes > 2**32.
1599 (check_depth): Now ptrdiff_t, not int.
1600 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1601 Adjust to new way of storing sizes. Check for size overflow bugs
1603 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1604 slightly wrong anyway, as it missed one instance of
1605 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1606 (refill_memory_reserve): Omit needless cast to size_t.
1607 (mark_object_loop_halt): Mark as externally visible.
1609 * xselect.c: Integer signedness and overflow fixes.
1610 (Fx_register_dnd_atom, x_handle_dnd_message):
1611 Use ptrdiff_t, not size_t, since we prefer signed.
1612 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1613 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1614 x_dnd_atoms_size and x_dnd_atoms_length.
1616 * doprnt.c: Prefer signed to unsigned when either works.
1618 * doprnt.c (doprnt):
1620 * xdisp.c (vmessage):
1621 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1622 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1623 prefer signed arithmetic to avoid comparison confusion.
1624 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1625 but is a bit tricky.
1627 Assume freestanding C89 headers, string.h, stdlib.h.
1628 * data.c, doprnt.c, floatfns.c, print.c:
1629 Include float.h unconditionally.
1630 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1631 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1632 * regex.c: Likewise for stddef.h, string.h.
1633 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1634 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1635 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1636 (STDC_HEADERS): Remove obsolete defines.
1637 * sysdep.c: Include limits.h unconditionally.
1639 Assume support for memcmp, memcpy, memmove, memset.
1640 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1641 * regex.c (memcmp, memcpy):
1642 Remove; we assume C89 now.
1644 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1645 (__malloc_safe_bcopy): Remove; no longer needed.
1647 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1648 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1649 well either way, and we prefer signed to unsigned.
1651 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1653 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1654 closes the connection while we're reading (bug#9182).
1656 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1658 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1659 are specified (Bug#9168).
1661 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1663 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1664 Found by GCC static checking and --with-wide-int on a 32-bit host.
1666 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1668 * xdisp.c (compute_display_string_pos): Fix logic of caching
1669 previous display string position. Initialize cached_prev_pos to
1670 -1. Fixes slow-down at the beginning of a buffer.
1672 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1674 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1675 for attrs[LFACE_FONTSET_INDEX].
1677 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1679 * xml.c (parse_region): Remove unused local
1680 that was recently introduced.
1682 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1684 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1685 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1687 * xdisp.c (move_it_in_display_line_to): Record the best matching
1688 position for TO_CHARPOS while scanning the line, and restore it on
1689 exit if none of the characters scanned was an exact match.
1690 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1691 when exact match is impossible due to invisible text, and the
1692 lines are truncated.
1694 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1696 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1699 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1701 Fix a significant slow-down of cursor motion with C-n, C-p,
1702 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1703 auto-repeat under bidi redisplay in fontified buffers.
1704 * xdisp.c (compute_stop_pos_backwards): New function.
1705 (next_element_from_buffer): Call compute_stop_pos_backwards to
1706 find a suitable prev_stop when we find ourselves before
1708 (reseat): Don't look for prev_stop, as that could mean a very long
1710 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1711 <cached_disp_overlay_modiff>: Cache for last found display string
1713 (compute_display_string_pos): Return the cached position if asked
1714 about the same buffer in the same area of character positions, and
1715 the buffer wasn't changed since the time the display string
1716 position was cached.
1718 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1720 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1721 is an integer, which is important for empty lines. (Bug#9149)
1723 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1725 * frame.c (Fmodify_frame_parameters): In tty case, update the
1726 default face if necessary (Bug#4238).
1728 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1730 * editfns.c (Fstring_to_char): No need to explain what a character
1731 is in the docstring (Bug#6576).
1733 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1735 * xml.c (parse_region): Make sure we always return a tree.
1737 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1739 * xml.c (parse_region): If a document contains only comments,
1742 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1744 * xml.c (make_dom): Return comments, too.
1746 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1749 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1750 and the surrounding thread.
1751 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1752 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1753 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1755 * s/openbsd.h (BROKEN_SIGIO): Define.
1756 * unexelf.c (unexec) [__OpenBSD__]:
1757 Don't update the .mdebug section of the Alpha COFF symbol table.
1759 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1761 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1764 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1766 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1767 This fixes some race conditions on the permissions of any newly
1770 * alloc.c (valid_pointer_p): Use pipe, not open.
1771 This fixes some permissions issues when debugging.
1773 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1774 If fchown fails to set both uid and gid, try to set just gid,
1775 as that is sometimes allowed. Adjust the file's mode to eliminate
1776 setuid or setgid bits that are inappropriate if fchown fails.
1778 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1780 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1781 to compare Lisp_Objects.
1782 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1783 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1784 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1786 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1788 * lread.c (read_integer): Unread even EOF character.
1789 (read1): Likewise. Properly record start position of symbol.
1791 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1792 symbol character follows.
1794 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1796 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1797 This works around a problem with the previous change to Fcopy_file.
1798 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1799 and without this change, GCC might complain about discarding
1800 fchown's return value.
1802 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1804 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1806 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1808 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1810 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1812 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1813 it's used from the C level.
1815 * process.c: Use the same condition for POLL_FOR_INPUT in both
1816 keyboard.c and process.c (bug#1858).
1818 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1820 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1821 (Fgnutls_boot): Use it.
1823 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1825 * doc.c (Fsubstitute_command_keys): Revert last change.
1827 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1829 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1830 quotes the next character, and doesn't affect other longer
1831 sequences (bug#8935).
1833 * lread.c (syms_of_lread): Clarify that is isn't only
1834 `eval-buffer' and `eval-defun' that's affected by
1835 `lexical-binding' (bug#8460).
1837 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1839 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1840 bidi redisplay when a line includes both an image and is
1843 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1845 Fix minor problems found by static checking.
1846 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1847 (elsz): Now a signed constant, not a size_t var. We prefer signed
1848 types to unsigned, to avoid integer comparison confusion. Without
1849 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1850 "cannot optimize loop, the loop counter may overflow", a symptom
1852 * indent.c (Fvertical_motion): Mark locals as initialized.
1853 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1855 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1857 * search.c (Fre_search_backward): Mention `case-fold-search' in
1858 all the re_search_* functions (bug#8138).
1860 * keyboard.c (Fopen_dribble_file): Document when the file is
1863 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1865 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1868 Support bidi reordering of display and overlay strings.
1869 * xdisp.c (compute_display_string_pos)
1870 (compute_display_string_end): Accept additional argument STRING.
1871 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1872 (reseat_to_string): Initialize bidi_it->string.s and
1873 bidi_it->string.schars.
1874 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1875 NULL (avoids a crash in bidi_paragraph_init).
1876 Initialize itb.string.lstring.
1877 (init_iterator): Call bidi_init_it only of a valid
1878 buffer position was specified. Initialize paragraph_embedding to
1880 (reseat_to_string): Initialize the bidi iterator.
1881 (display_string): If we need to ignore text properties of
1882 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1883 original value of -1 will not work with bidi.)
1884 (compute_display_string_pos): First arg is now struct
1885 `text_pos *'; all callers changed. Support display properties on
1887 (compute_display_string_end): Support display properties on Lisp
1889 (init_iterator, reseat_1, reseat_to_string): Initialize the
1890 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1891 when iterating on a string not from display properties).
1892 (compute_display_string_pos, compute_display_string_end):
1893 Fix calculation of the object to scan. Fixes an error when using
1895 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1896 base_level_stop; instead, set base_level_stop to BEGV.
1897 Fixes crashes in vertical-motion.
1898 (next_element_from_buffer): Improve commentary for when
1899 the iterator is before prev_stop.
1900 (init_iterator): Initialize bidi_p from the default value of
1901 bidi-display-reordering, not from buffer-local value. Use the
1902 buffer-local value only if initializing for buffer iteration.
1903 (handle_invisible_prop): Support invisible properties on strings
1904 that are being bidi-reordered.
1905 (set_iterator_to_next): Support bidi reordering of C strings and
1907 (next_element_from_string): Support bidi reordering of Lisp
1909 (handle_stop_backwards): Support Lisp strings as well.
1910 (display_string): Support display of R2L glyph rows.
1911 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1912 (init_iterator): Don't initialize it->bidi_p for strings
1914 (reseat_to_string): Initialize it->bidi_p for strings here.
1915 (next_element_from_string, next_element_from_c_string)
1916 (next_element_from_buffer): Add xassert's for correspondence
1917 between IT's object being iterated and it->bidi_it.string
1919 (face_before_or_after_it_pos): Support bidi iteration.
1920 (next_element_from_c_string): Handle the case of the first string
1921 character that is not the first one in the visual order.
1922 (get_visually_first_element): New function, refactored from common
1923 parts of next_element_from_buffer, next_element_from_string, and
1924 next_element_from_c_string.
1925 (tool_bar_lines_needed, redisplay_tool_bar)
1926 (display_menu_bar): Force left-to-right direction. Add a FIXME
1927 comment for making that be controlled by a user option.
1928 (push_it, pop_it): Save and restore the state of the
1929 bidi iterator. Save and restore the bidi_p flag.
1930 (pop_it): Iterate out of display property for string iteration as
1932 (iterate_out_of_display_property): Support iteration over strings.
1933 (handle_single_display_spec): Set up it->bidi_it for iteration
1934 over a display string, and call bidi_init_it.
1935 (handle_single_display_spec, next_overlay_string)
1936 (get_overlay_strings_1, push_display_prop): Set up the bidi
1937 iterator for displaying display or overlay strings.
1938 (forward_to_next_line_start): Don't use the shortcut if
1940 (back_to_previous_visible_line_start): If handle_display_prop
1941 pushed the iterator stack, restore the internal state of the bidi
1942 iterator by calling bidi_pop_it same number of times.
1943 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1944 and we are bidi-iterating, don't decrement the iterator position;
1945 instead, set the first_elt flag in the bidi iterator, to produce
1947 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1948 (push_display_prop): xassert that we are iterating a buffer.
1949 (push_it, pop_it): Save and restore paragraph_embedding member.
1950 (handle_single_display_spec, next_overlay_string)
1951 (get_overlay_strings_1, reseat_1, reseat_to_string)
1952 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1953 correctly. Don't assume unibyte strings are not bidi-reordered.
1954 (compute_display_string_pos)
1955 (compute_display_string_end): Fix handling the case of C string.
1956 (push_it, pop_it): Save and restore from_disp_prop_p.
1957 (handle_single_display_spec, push_display_prop): Set the
1958 from_disp_prop_p flag.
1959 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1960 (pop_it): Call iterate_out_of_display_property only if we are
1961 popping after iteration over a string that came from a display
1962 property. Fix a typo in popping stretch info. Add an assertion
1963 for verifying that the iterator position is in sync with the bidi
1965 (handle_single_display_spec, get_overlay_strings_1)
1966 (push_display_prop): Fix initialization of paragraph direction for
1967 string when that of the parent object is not yet determined.
1968 (reseat_1): Call bidi_init_it to resync the bidi
1969 iterator with IT's position. (Bug#7616)
1970 (find_row_edges): If ROW->start.pos gives position
1971 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1972 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1973 Reset the from_disp_prop_p flag.
1974 (SAVE_IT, RESTORE_IT): New macros.
1975 (pos_visible_p, face_before_or_after_it_pos)
1976 (back_to_previous_visible_line_start)
1977 (move_it_in_display_line_to, move_it_in_display_line)
1978 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1979 (try_scrolling, redisplay_window, display_line): Use them when
1980 saving a temporary copy of the iterator and restoring it back.
1981 (back_to_previous_visible_line_start, reseat_1)
1982 (init_iterator): Empty the bidi cache "stack".
1983 (move_it_in_display_line_to): If iterator ended up at
1984 EOL, but we never saw any buffer positions smaller than
1985 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1986 motion in bidi-reordered lines.
1987 (move_it_in_display_line_to): Record prev_method and prev_pos
1988 immediately before the call to set_iterator_to_next. Fixes cursor
1989 motion in bidi-reordered lines with stretch glyphs and strings
1990 displayed in margins. (Bug#8133) (Bug#8867)
1991 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1993 (pos_visible_p): Support positions in bidi-reordered lines.
1994 Save and restore bidi cache.
1996 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1997 (bidi_paragraph_info): Delete unused struct.
1998 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1999 (bidi_cache_start): New variable.
2000 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2002 (bidi_cache_fetch_state, bidi_cache_search)
2003 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2004 (bidi_cache_find, bidi_peek_at_next_level)
2005 (bidi_level_of_next_char, bidi_find_other_level_edge)
2006 (bidi_move_to_visually_next): Compare cache index with
2007 bidi_cache_start rather than with zero.
2008 (bidi_fetch_char): Accept new argument STRING; all callers
2009 changed. Support iteration over a string. Support strings with
2010 display properties. Support unibyte strings. Fix the type of
2011 `len' according to what STRING_CHAR_AND_LENGTH expects.
2012 (bidi_paragraph_init, bidi_resolve_explicit_1)
2013 (bidi_resolve_explicit, bidi_resolve_weak)
2014 (bidi_level_of_next_char, bidi_move_to_visually_next):
2015 Support iteration over a string.
2016 (bidi_set_sor_type, bidi_resolve_explicit_1)
2017 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2018 can now be zero (for strings); special values 0 and -1 were
2019 changed to -1 and -2, respectively.
2020 (bidi_char_at_pos): New function.
2021 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2022 Call it instead of FETCH_MULTIBYTE_CHAR.
2023 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2024 initialized to valid values.
2025 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2027 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2028 the test for valid cached positions. Fix the logic for looking up
2029 the sentinel state in the cache. GCPRO the Lisp string we are
2031 (bidi_push_it, bidi_pop_it): New functions.
2032 (bidi_initialize): Initialize the bidi cache start stack pointer.
2033 (bidi_cache_ensure_space): New function, refactored from part of
2034 bidi_cache_iterator_state. Don't assume the required size is just
2035 one BIDI_CACHE_CHUNK away.
2036 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2037 (bidi_count_bytes, bidi_char_at_pos): New functions.
2038 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2039 always valid if bidi_cache_idx is valid.
2040 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2041 is valid if it's going to be used.
2042 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2043 (bidi_cache_fetch_state, bidi_cache_search)
2044 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2045 (bidi_cache_iterator_state, bidi_cache_find)
2046 (bidi_find_other_level_edge, bidi_cache_start_stack):
2047 All variables related to cache indices are now EMACS_INT.
2049 * dispextern.h (struct bidi_string_data): New structure.
2050 (struct bidi_it): New member `string'. Make flag members be 1-bit
2051 fields, and put them last in the struct.
2052 (compute_display_string_pos, compute_display_string_end):
2054 (bidi_push_it, bidi_pop_it): Add prototypes.
2055 (struct iterator_stack_entry): New members bidi_p,
2056 paragraph_embedding, and from_disp_prop_p.
2057 (struct it): Member bidi_p is now a bit field 1 bit wide.
2058 (bidi_shelve_cache, bidi_unshelve_cache):
2061 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2062 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2063 and vector-like objects.
2065 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2066 cache around display iteration.
2068 * window.c (Fwindow_end, window_scroll_pixel_based)
2069 (displayed_window_lines, Frecenter): Save and restore the bidi
2070 cache around display iteration.
2072 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2074 * editfns.c (Fdelete_region): Clarify the use of the named
2075 parameters (bug#6788).
2077 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2079 * indent.c (Fvertical_motion): Set and restore w->pointm when
2080 saving and restoring the window's buffer (Bug#9006).
2082 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2084 * editfns.c (Fstring_to_char): Clarify just what is returned
2085 (bug#6576). Text by Eli Zaretskii.
2087 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2089 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2091 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2093 * buffer.c (mmap_find): Fix a typo.
2095 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2097 Fix execution of x selection hooks.
2098 * xselect.c (Qx_lost_selection_functions)
2099 (Qx_sent_selection_functions): New vars.
2100 (syms_of_xselect): DEFSYM them.
2101 (x_handle_selection_request): Pass Qx_sent_selection_functions
2102 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2103 (x_handle_selection_clear,x_clear_frame_selections):
2104 Pass Qx_lost_selection_functions rather than
2105 Vx_lost_selection_functions to Frun_hook_with_args.
2107 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2109 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2110 The old code sometimes used this field without initializing it.
2112 * alloc.c (gc_sweep): Don't read past end of array.
2113 In theory, the old code could also have corrupted Emacs internals,
2114 though it'd be very unlikely.
2116 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2118 * character.c (Fcharacterp): Don't advertise optional ignored
2119 argument. (Bug#4026)
2121 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2123 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2126 * window.c (Fset_window_start): Doc fix (bug#4199).
2127 (Fset_window_hscroll): Ditto.
2129 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2131 Fix minor new problems caught by GCC 4.6.1.
2132 * term.c (init_tty): Remove unused local.
2133 * xsettings.c (store_monospaced_changed): Define this function only
2134 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2137 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2139 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2141 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2143 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2144 are the mini-buffer and the echo area (bug#3320).
2146 * term.c (init_tty): Remove support for supdup, c10 and perq
2147 terminals, which are no longer supported (bug#1482).
2149 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2151 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2153 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2155 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2156 for non-popups (Bug#3642).
2158 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2160 * alloc.c (reset_malloc_hooks): Protoize.
2161 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2162 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2163 * cm.c (losecursor): Likewise.
2164 * data.c (fmod): Likewise.
2165 * dispnew.c (swap_glyphs_in_rows): Likewise.
2166 * emacs.c (memory_warning_signal): Likewise.
2167 * floatfns.c (float_error): Likewise.
2168 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2169 (otf_open, font_otf_capability, generate_otf_features)
2170 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2172 * image.c (pbm_read_file): Likewise.
2173 * indent.c (string_display_width): Likewise.
2174 * intervals.c (check_for_interval, search_for_interval)
2175 (inc_interval_count, count_intervals, root_interval)
2176 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2177 * lread.c (defalias): Likewise.
2178 * ralloc.c (r_alloc_check): Likewise.
2179 * regex.c (set_image_of_range_1, set_image_of_range)
2180 (regex_grow_registers): Likewise.
2181 * sysdep.c (strerror): Likewise.
2182 * termcap.c (valid_filename_p, tprint, main): Likewise.
2183 * tparam.c (main): Likewise.
2184 * unexhp9k800.c (run_time_remap, save_data_space)
2185 (update_file_ptrs, read_header, write_header, calculate_checksum)
2186 (copy_file, copy_rest, display_header): Likewise.
2187 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2189 * xdisp.c (check_it): Likewise.
2190 * xfaces.c (register_color, unregister_color, unregister_colors):
2192 * xfns.c (print_fontset_result): Likewise.
2193 * xrdb.c (member, fatal, main): Likewise.
2195 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2197 Fix minor problems found by static checking (Bug#9031).
2198 * chartab.c (char_table_set_range, map_sub_char_table):
2199 Remove unused locals.
2200 (uniprop_table): Now static.
2201 * composite.c (_work_char): Remove unused static var.
2203 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2205 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2207 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2209 * gtkutil.c (qttip_cb): Remove code without function.
2211 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2213 * w32.c (pthread_sigmask): New stub.
2215 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2217 Use pthread_sigmask, not sigprocmask (Bug#9010).
2218 sigprocmask is portable only for single-threaded applications, and
2219 Emacs can be multi-threaded when it uses GTK.
2220 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2222 * callproc.c (Fcall_process):
2223 * process.c (create_process):
2224 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2225 Use pthread_sigmask, not sigprocmask.
2227 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2229 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2230 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2233 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2235 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2236 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2237 (xg_hide_tooltip): Fix comment.
2239 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2240 in registerServicesMenuSendTypes.
2241 (validRequestorForSendType): Don't check ns_return_types.
2243 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2246 2011-07-08 Jason Rumney <jasonr@gnu.org>
2248 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2249 frame struct members of non-existent frames (Bug#6284).
2251 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2253 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2254 variable firstTime not needed on OSX >= 10.6.
2255 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2256 >= 10.5. Use setKnobProportion, setDoubleValue.
2258 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2259 (MAC_OS_X_VERSION_10_5): Define if not defined.
2260 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2261 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2262 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2264 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2265 cString and lossyCString on OSX >= 10.4
2267 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2268 sizeToFit on OSX >= 10.2.
2270 * nsimage.m (allocInitFromFile): Don't use deprecated method
2271 bestRepresentationForDevice on OSX >= 10.6.
2273 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2276 * emacs.c: Declare unexec_init_emacs_zone.
2278 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2280 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2282 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2283 on svcsMenu (Bug#8842).
2285 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2287 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2289 * nsterm.m (QUTF8_STRING): Declare.
2290 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2291 (validRequestorForSendType): Return type is (id).
2292 Change indexOfObjectIdenticalTo to indexOfObject.
2293 Check if we have local selection before returning self (Bug#8842).
2294 (writeSelectionToPasteboard): Put local selection into paste board
2295 if we have a local selection (Bug#8842).
2296 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2298 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2299 (ns_get_local_selection): Declare.
2301 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2303 * keymap.c (describe_map_tree): Don't insert a double newline at
2304 the end of the buffer (bug#1169) and return whether we inserted
2307 * callint.c (Fcall_interactively): Change "reading args" to
2308 "providing args" to try to clarify what it does (bug#1010).
2310 2011-07-07 Kenichi Handa <handa@m17n.org>
2312 * composite.c (composition_compute_stop_pos): Ignore a static
2313 composition starting before CHARPOS (Bug#8915).
2315 * xdisp.c (handle_composition_prop): Likewise.
2317 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2319 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2322 2011-07-07 Kenichi Handa <handa@m17n.org>
2324 * character.h (unicode_category_t): New enum type.
2326 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2327 (Qchar_code_property_table): New variable.
2328 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2329 (UNIPROP_COMPRESSED_FORM_P): New macros.
2330 (char_table_ascii): Uncompress the compressed values.
2331 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2332 Uncompress the compressed values.
2333 (sub_char_table_ref_and_range): Likewise.
2334 (char_table_ref_and_range): Uncompress the compressed values.
2335 (sub_char_table_set): New arg is_uniprop. Callers changed.
2336 Uncompress the compressed values.
2337 (sub_char_table_set_range): Args changed. Callers changed.
2338 (char_table_set_range): Adjuted for the above change.
2339 (map_sub_char_table): Delete args default_val and parent. Add arg
2340 top. Give decoded values to a Lisp function.
2341 (map_char_table): Adjust for the above change. Give decoded
2342 values to a Lisp function. Gcpro more variables.
2343 (uniprop_table_uncompress)
2344 (uniprop_decode_value_run_length): New functions.
2345 (uniprop_decoder, uniprop_decoder_count): New variables.
2346 (uniprop_get_decoder, uniprop_encode_value_character)
2347 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2349 (uniprop_encoder, uniprop_encoder_count): New variables.
2350 (uniprop_get_encoder, uniprop_table)
2351 (Funicode_property_table_internal, Fget_unicode_property_internal)
2352 (Fput_unicode_property_internal): New functions.
2353 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2354 Sunicode_property_table_internal, Sget_unicode_property_internal,
2355 and Sput_unicode_property_internal. Defvar_lisp
2356 char-code-property-alist.
2358 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2359 Vunicode_category_table.
2361 * font.c (font_range): Adjust for the change of
2362 Vunicode_category_table.
2364 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2366 * m/iris4d.h: Remove file, move contents ...
2367 * s/irix6-5.h: ... here.
2369 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2371 Remove unportable assumption about struct layout (Bug#8884).
2372 * alloc.c (mark_buffer):
2373 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2374 (clone_per_buffer_values): Don't assume that
2375 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2376 This isn't true in general, and it's particularly not true
2377 if Emacs is configured with --with-wide-int.
2378 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2379 New macros, used in the buffer.c change.
2381 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2383 * xsettings.c: Use both GConf and GSettings if both are available.
2384 (store_config_changed_event): Add comment.
2385 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2386 (store_tool_bar_style_changed): New functions.
2387 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2388 (struct xsettings): Move font inside HAVE_XFT.
2389 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2390 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2391 Move inside HAVE_XFT.
2392 (something_changed_gsettingsCB): Rename from something_changedCB.
2393 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2395 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2396 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2397 (something_changed_gconfCB): Rename from something_changedCB.
2398 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2399 (parse_settings): Move check for font inside HAVE_XFT.
2400 (read_settings, apply_xft_settings): Add comment.
2401 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2402 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2403 call store_font_name_changed.
2404 (xft_settings_event): Add comment.
2405 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2406 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2407 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2408 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2409 (xsettings_initialize): Call init_gsettings last.
2410 (xsettings_get_system_font, xsettings_get_system_normal_font):
2413 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2415 Random fixes. E.g., (random) never returned negative values.
2416 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2417 subseconds part to the entropy, as that's a bit more random.
2418 Prefer signed to unsigned, since the signedness doesn't matter and
2419 in general we prefer signed. When given a limit, use a
2420 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2421 latter isn't right if USE_2_TAGS_FOR_INTS.
2422 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2423 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2425 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2427 * textprop.c (text_property_stickiness):
2428 Obey Vtext_property_default_nonsticky.
2429 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2430 * w32fns.c (syms_of_w32fns):
2431 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2433 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2435 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2436 This is more efficient than Ffile_directory_p and avoids a minor race.
2438 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2440 * buffer.c (Foverlay_put): Say what the return value is
2443 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2444 is a directory before asking whether to use the file name
2446 (barf_or_query_if_file_exists): Make the "File is a directory"
2447 error be more correct.
2449 * fns.c (Frequire): Remove the mention of the .gz files, since
2450 that's installation-specific, but keep the mention of
2451 `get-load-suffixes'.
2453 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2455 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2456 Report string overflow if the output is too long.
2458 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2460 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2461 (syms_of_gnutls): Remove duplicate DEFSYM for
2462 Qgnutls_bootprop_verify_hostname_error, an error for
2463 Qgnutls_bootprop_verify_error (which is no longer used).
2465 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2466 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2467 Also (re)move comments that are misplaced or no longer relevant.
2469 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2471 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2473 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2475 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2476 and background color parameters if they have been changed.
2478 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2480 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2482 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2484 * xsettings.c (SYSTEM_FONT): Define only when used.
2485 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2487 * keymap.c (access_keymap_1): Now static.
2489 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2491 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2492 leave any prefix arg for the up event (Bug#1586).
2494 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2496 * lread.c (syms_of_lread): Mention single symbols defined by
2497 `defvar' or `defconst' (bug#7154).
2499 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2500 (Frequire): Mention get-load-suffixes.
2502 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2504 * window.h (window): Remove clone_number slot.
2505 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2507 (make_parent_window, make_window, saved_window)
2508 (Fset_window_configuration, save_window_save): Don't deal with
2510 * buffer.c (Qclone_number): Remove declaration.
2511 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2513 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2515 Add multiple inheritance to keymaps.
2516 * keymap.c (Fmake_composed_keymap): New function.
2517 (Fset_keymap_parent): Simplify.
2518 (fix_submap_inheritance): Remove.
2519 (access_keymap_1): New function extracted from access_keymap to handle
2520 embedded parents and handle lists of maps.
2521 (access_keymap): Use it.
2522 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2523 (Fcopy_keymap): Handle embedded parents.
2524 (Fcommand_remapping, define_as_prefix): Simplify.
2525 (Fkey_binding): Simplify.
2526 (syms_of_keymap): Move minibuffer-local-completion-map,
2527 minibuffer-local-filename-completion-map,
2528 minibuffer-local-must-match-map, and
2529 minibuffer-local-filename-must-match-map to Elisp.
2530 (syms_of_keymap): Defsubr make-composed-keymap.
2531 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2532 (parse_menu_item): Trivial simplification.
2534 2011-07-01 Glenn Morris <rgm@gnu.org>
2536 * Makefile.in (SETTINGS_LIBS): Fix typo.
2538 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2540 * coding.c (Fencode_coding_string): Record the last coding system
2541 used, as the function doc string says (bug#8738).
2543 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2545 * xsettings.c (store_monospaced_changed): Take new font as arg and
2546 check for change against current_mono_font.
2547 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2548 (emacs_settings_constructor, emacs_settings_get_property)
2549 (emacs_settings_set_property, emacs_settings_class_init)
2550 (emacs_settings_init, gsettings_obj): Remove.
2551 (something_changedCB): New function for HAVE_GSETTINGS.
2552 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2553 with value as argument.
2554 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2555 g_settings_new (Bug#8967). Do not create gsettings_obj.
2556 Remove calls to g_settings_bind. Connect something_changedCB to
2559 * xgselect.c: Add defined (HAVE_GSETTINGS).
2560 (xgselect_initialize): Ditto.
2562 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2563 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2566 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2568 * eval.c (struct backtrace): Simplify and port the data structure.
2569 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2570 signed bit field, as this assumption is not portable and it makes
2571 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2572 "char debug_on_exit : 1" as this is not portable either; instead,
2573 use the portable "unsigned int debug_on_exit : 1". Remove unused
2574 member evalargs. Remove obsolete comments about cc bombing out.
2576 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2578 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2579 Let HAVE_GSETTINGS override HAVE_GCONF.
2580 (store_monospaced_changed): New function.
2581 (EMACS_SETTINGS): A new type derived from GObject to handle
2582 GSettings notifications.
2583 (emacs_settings_constructor, emacs_settings_get_property)
2584 (emacs_settings_set_property, emacs_settings_class_init):
2586 (gsettings_client, gsettings_obj): New variables.
2587 (GSETTINGS_SCHEMA): New define.
2588 (something_changedCB): Call store_monospaced_changed.
2589 (init_gsettings): New function.
2590 (xsettings_initialize): Call init_gsettings.
2591 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2594 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2597 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2599 * window.c (resize_root_window, grow_mini_window)
2600 (shrink_mini_window): Rename Qresize_root_window to
2601 Qwindow_resize_root_window and Qresize_root_window_vertically to
2602 Qwindow_resize_root_window_vertically.
2604 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2606 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2608 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2610 * makefile.w32-in: Redesign dependencies so they reflect more
2611 clearly which files are directly included by each source file,
2612 and not through other includes.
2614 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2616 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2617 (sort_overlays, overlay_strings): When an overlay's clone number
2618 matches the window's clone number process the overlay even if
2619 the overlay's window property doesn't match the current window.
2621 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2622 (Fwindow_hchild): Rename to Fwindow_left_child.
2623 (Fwindow_next): Rename to Fwindow_next_sibling.
2624 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2625 (resize_window_check): Rename to window_resize_check.
2626 (resize_window_apply): Rename to window_resize_apply.
2627 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2628 (Fdelete_other_windows_internal, resize_frame_windows)
2629 (Fsplit_window_internal, Fdelete_window_internal)
2630 (grow_mini_window, shrink_mini_window)
2631 (Fresize_mini_window_internal): Fix callers accordingly.
2633 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2635 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2636 (emacs_fixed_set_min_size): Remove.
2637 (emacs_fixed_new): Take frame as argument.
2639 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2640 (_EmacsFixedPrivate): Remove minwidth/height.
2641 Add struct frame *f.
2642 (emacs_fixed_init): Initialize priv->f.
2643 (get_parent_class, emacs_fixed_set_min_size): Remove.
2644 (emacs_fixed_new): Set priv->f to argument.
2645 (emacs_fixed_get_preferred_width)
2646 (emacs_fixed_get_preferred_height): Use min_width/height from
2647 frames size_hint to set minimum and natural (Bug#8919).
2648 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2649 and use min_width/height from frames size_hint to set
2650 min_width/height (Bug#8919).
2652 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2653 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2656 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2658 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2659 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2662 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2664 * process.c (wait_reading_process_output): Bypass select if
2665 waiting for a cell while ignoring keyboard input, and input is
2666 pending. Suggested by Jan Djärv (Bug#8869).
2668 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2670 Use gnulib's dup2 module instead of rolling our own.
2671 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2673 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2675 * dispnew.c (scrolling_window): Before scrolling, turn off a
2676 mouse-highlight in the window being scrolled.
2678 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2680 Move DEFSYM to lisp.h and use everywhere.
2682 * character.h (DEFSYM): Move declaration...
2683 * lisp.h (DEFSYM): ...here.
2689 * w32select.c: Don't include character.h.
2691 * alloc.c (syms_of_alloc):
2692 * buffer.c (syms_of_buffer):
2693 * bytecode.c (syms_of_bytecode):
2694 * callint.c (syms_of_callint):
2695 * casefiddle.c (syms_of_casefiddle):
2696 * casetab.c (init_casetab_once):
2697 * category.c (init_category_once, syms_of_category):
2698 * ccl.c (syms_of_ccl):
2699 * cmds.c (syms_of_cmds):
2700 * composite.c (syms_of_composite):
2701 * dbusbind.c (syms_of_dbusbind):
2702 * dired.c (syms_of_dired):
2703 * dispnew.c (syms_of_display):
2704 * doc.c (syms_of_doc):
2705 * editfns.c (syms_of_editfns):
2706 * emacs.c (syms_of_emacs):
2707 * eval.c (syms_of_eval):
2708 * fileio.c (syms_of_fileio):
2709 * fns.c (syms_of_fns):
2710 * frame.c (syms_of_frame):
2711 * fringe.c (syms_of_fringe):
2712 * insdel.c (syms_of_insdel):
2713 * keymap.c (syms_of_keymap):
2714 * lread.c (init_obarray, syms_of_lread):
2715 * macros.c (syms_of_macros):
2716 * msdos.c (syms_of_msdos):
2717 * print.c (syms_of_print):
2718 * process.c (syms_of_process):
2719 * search.c (syms_of_search):
2720 * sound.c (syms_of_sound):
2721 * syntax.c (init_syntax_once, syms_of_syntax):
2722 * terminal.c (syms_of_terminal):
2723 * textprop.c (syms_of_textprop):
2724 * undo.c (syms_of_undo):
2725 * w32.c (globals_of_w32):
2726 * window.c (syms_of_window):
2727 * xdisp.c (syms_of_xdisp):
2728 * xfaces.c (syms_of_xfaces):
2729 * xfns.c (syms_of_xfns):
2730 * xmenu.c (syms_of_xmenu):
2731 * xsettings.c (syms_of_xsettings):
2732 * xterm.c (syms_of_xterm): Use DEFSYM.
2734 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2736 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2738 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2740 Integer and buffer overflow fixes (Bug#8873).
2742 * print.c (printchar, strout): Check for string overflow.
2743 (PRINTPREPARE, printchar, strout):
2744 Don't set size unless allocation succeeds.
2746 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2747 for sizes. Check for string overflow more accurately.
2748 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2750 * macros.c: Integer and buffer overflow fixes.
2751 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2752 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2753 Use ptrdiff_t, not int, for sizes.
2754 Don't increment bufsize until after realloc succeeds.
2755 Check for size-calculation overflow.
2756 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2758 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2760 * lread.c: Integer overflow fixes.
2761 (read_integer): Radix is now EMACS_INT, not int,
2762 to improve quality of diagnostics for out-of-range radices.
2763 Calculate buffer size correctly for out-of-range radices.
2764 (read1): Check for integer overflow in radices, and in
2765 read-circle numbers.
2766 (read_escape): Avoid int overflow.
2767 (Fload, openp, read_buffer_size, read1)
2768 (substitute_object_recurse, read_vector, read_list, map_obarray):
2769 Use ptrdiff_t, not int, for sizes.
2770 (read1): Use EMACS_INT, not int, for sizes.
2771 Check for size overflow.
2773 * image.c (cache_image): Check for size arithmetic overflow.
2775 * lread.c: Integer overflow issues.
2776 (saved_doc_string_size, saved_doc_string_length)
2777 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2778 Now ptrdiff_t, not int.
2779 (read1): Don't assume doc string length fits in int. Check for
2780 out-of-range doc string lengths.
2781 (read_list): Don't assume file position fits in int.
2782 (read_escape): Check for hex character overflow.
2784 2011-06-22 Leo Liu <sdl.web@gmail.com>
2786 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2787 Move to minibuffer.el.
2789 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2791 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2792 The following patches are for when GLYPH_DEBUG && !XASSERT.
2793 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2794 * dispnew.c (flush_stdout):
2795 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2796 Mark as externally visible.
2797 * dispnew.c (check_window_matrix_pointers): Now static.
2798 * dispnew.c (window_to_frame_vpos):
2799 * xfns.c (unwind_create_frame):
2800 * xterm.c (x_check_font): Remove unused local.
2801 * scroll.c (CHECK_BOUNDS):
2802 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2803 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2804 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2805 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2806 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2808 (debug_method_add): Use va_list and vsprintf rather than relying
2809 on undefined behavior with wrong number of arguments.
2810 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2811 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2812 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2813 since we're not interested in debugging glyphs with old libraries.
2814 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2815 GCC 4.6.0's static checking.
2817 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2819 Integer overflow and signedness fixes (Bug#8873).
2820 A few related buffer overrun fixes, too.
2822 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2824 * dispextern.h (struct face.stipple):
2825 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2826 (x_bitmap_mask, x_allocate_bitmap_record)
2827 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2828 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2829 (x_create_bitmap_from_xpm_data):
2830 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2831 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2833 * xfaces.c (load_pixmap):
2834 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2835 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2836 (.bitmaps_last, struct x_output.icon_bitmap):
2837 Use ptrdiff_t, not int, for bitmap indexes.
2838 (x_allocate_bitmap_record): Check for size overflow.
2839 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2841 Use ptrdiff_t, not int, for overlay counts.
2842 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2843 * editfns.c (overlays_around, get_pos_property):
2844 * textprop.c (get_char_property_and_overlay):
2845 * xdisp.c (next_overlay_change, note_mouse_highlight):
2846 * xfaces.c (face_at_buffer_position):
2847 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2848 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2849 (Fnext_overlay_change, Fprevious_overlay_change)
2850 (mouse_face_overlay_overlaps, Foverlays_in):
2851 Use ptrdiff_t, not int, for sizes.
2852 (overlays_at, overlays_in): Check for size-calculation overflow.
2854 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2856 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2857 (x_session_initialize): Do not assume string length fits in int.
2859 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2860 This is unlikely, but can occur if DPI is outlandish.
2862 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2863 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2865 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2866 * xrdb.c (magic_file_p, search_magic_path):
2867 Omit last arg SUFFIX; it was always 0. All callers changed.
2868 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2870 * xfont.c (xfont_match): Avoid need for strlen.
2872 * xfns.c: Don't assume strlen fits in int.
2873 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2875 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2876 not unsigned long, as we prefer signed integers. All callers changed.
2877 Detect integer overflow in repeat count.
2878 (message_dolog): Don't assume print length fits in 39 bytes.
2879 (display_mode_element): Don't assume strlen fits in int.
2881 * termcap.c: Don't assume sizes fit in int and never overflow.
2882 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2883 (gobble_line): Check for size-calculation overflow.
2885 * minibuf.c (Fread_buffer):
2886 * lread.c (intern, intern_c_string):
2887 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2888 Don't assume string length fits in int.
2890 * keyboard.c (parse_tool_bar_item):
2891 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2893 * font.c: Don't assume string length fits in int.
2894 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2895 Use ptrdiff_t, not int.
2896 (font_intern_prop): Don't assume string length fits in int.
2897 Don't assume integer property fits in fixnum.
2898 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2900 * filelock.c: Fix some buffer overrun and integer overflow issues.
2901 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2902 Reformulate so as not to need the command string.
2903 Invoke gzip -cd rather than gunzip, as it's more portable.
2904 (lock_info_type, lock_file_1, lock_file):
2905 Don't assume pid_t and time_t fit in unsigned long.
2906 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2907 (current_lock_owner): Prefer signed type for sizes.
2908 Use memcpy, not strncpy, where memcpy is what is really wanted.
2909 Don't assume (via atoi) that time_t and pid_t fit in int.
2910 Check for time_t and/or pid_t out of range, e.g., via a network share.
2911 Don't alloca where an auto var works fine.
2913 * fileio.c: Fix some integer overflow issues.
2914 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2915 Don't assume string length fits in int.
2916 (directory_file_name): Don't assume string length fits in long.
2917 (make_temp_name): Don't assume pid fits in int, or that its print
2918 length is less than 20.
2920 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2922 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2924 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2926 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2927 We prefer signed integers, even for size calculations.
2929 * emacs.c: Don't assume string length fits in 'int'.
2930 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2931 (main): Don't invoke strlen when not needed.
2933 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2934 (XD_DEBUG_MESSAGE): Don't waste a byte.
2936 * callproc.c (getenv_internal_1, getenv_internal)
2938 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2940 * lread.c (invalid_syntax): Omit length argument.
2941 All uses changed. This doesn't fix a bug, but it simplifies the
2942 code away from its former Hollerith-constant appearance, and it's
2943 one less 'int' to worry about when looking at integer-overflow issues.
2944 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2946 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2947 This didn't break anything, but it didn't help either.
2948 It's confusing to put a bogus integer in a place where the actual
2949 value does not matter.
2950 (LIST_END_P): Remove unused macro and its bogus comment.
2951 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2953 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2954 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2956 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2957 We prefer signed types, and the value cannot exceed the EMACS_INT
2958 range anyway (because otherwise the length would not be representable).
2959 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2960 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2961 This avoids a GCC warning when WIDE_EMACS_INT.
2963 * indent.c (sane_tab_width): New function.
2964 (current_column, scan_for_column, Findent_to, position_indentation)
2965 (compute_motion): Use it. This is just for clarity.
2966 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2968 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2970 * lisp.h (lint_assume): New macro.
2971 * composite.c (composition_gstring_put_cache):
2972 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2974 * editfns.c, insdel.c:
2975 Omit unnecessary forward decls, to simplify future changes.
2977 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2979 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2981 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2982 Use much-faster test for byte-length change.
2983 Don't assume string byte-length fits in 'int'.
2984 Check that character arg fits in 'int'.
2985 (mapcar1): Declare byte as byte, for clarity.
2987 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2989 * fns.c (concat): Catch string overflow earlier.
2990 Do not rely on integer wraparound.
2992 * dispextern.h (struct it.overlay_strings_charpos)
2993 (struct it.selective): Now EMACS_INT, not int.
2994 * xdisp.c (forward_to_next_line_start)
2995 (back_to_previous_visible_line_start)
2996 (reseat_at_next_visible_line_start, next_element_from_buffer):
2997 Don't arbitrarily truncate the value of 'selective' to int.
2999 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3001 * composite.c: Don't truncate sizes to 'int'.
3002 (composition_gstring_p, composition_reseat_it)
3003 (composition_adjust_point): Use EMACS_INT, not int.
3004 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3005 not EMACS_UINT, for indexes.
3007 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3009 * buffer.c: Include <verify.h>.
3010 (struct sortvec.priority, struct sortstr.priority):
3011 Now EMACS_INT, not int.
3012 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3013 (struct sortstr.size, record_overlay_string)
3014 (struct sortstrlist.size, struct sortlist.used):
3015 Don't truncate size to int.
3016 (record_overlay_string): Check for size-calculation overflow.
3017 (init_buffer_once): Check at compile-time, not run-time.
3019 2011-06-22 Jim Meyering <meyering@redhat.com>
3021 Don't leak an XBM-image-sized buffer
3022 * image.c (xbm_load): Free the image buffer after using it.
3024 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3027 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3028 that Sun C diagnosed.
3029 * fns.c (secure_hash): Fix pointer signedness issue.
3030 * intervals.c (static_offset_intervals): New function.
3031 (offset_intervals): Use it.
3033 2011-06-21 Leo Liu <sdl.web@gmail.com>
3036 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3039 * fns.c (secure_hash): Rename from crypto_hash_function and change
3040 the first arg to accept symbols.
3041 (Fsecure_hash): New primitive.
3042 (syms_of_fns): New symbols.
3044 2011-06-20 Deniz Dogan <deniz@dogan.se>
3046 * process.c (Fset_process_buffer): Clarify return value in
3049 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3051 * dispnew.c (add_window_display_history): Use BVAR.
3053 * xdisp.c (debug_method_add): Use BVAR.
3054 (check_window_end, dump_glyph_matrix, dump_glyph)
3055 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3057 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3060 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3061 check till after the cache is created in init_frame_faces.
3063 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3065 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3067 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3069 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3070 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3071 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3073 Improve buffer-overflow checking (Bug#8873).
3074 * fileio.c (Finsert_file_contents):
3075 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3076 Remove the old (too-loose) buffer overflow checks.
3077 They weren't needed, since make_gap checks for buffer overflow.
3078 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3079 The old code merely checked for Emacs fixnum overflow, and relied
3080 on undefined (wraparound) behavior. The new code avoids undefined
3081 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3083 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3084 Tune. Don't use wider integers than needed. Don't use alloca.
3085 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3087 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3089 * insdel.c, lisp.h (buffer_overflow): New function.
3090 (insert_from_buffer_1, replace_range, replace_range_2):
3091 * insdel.c (make_gap_larger):
3092 * editfns.c (Finsert_char):
3093 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3095 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3097 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3099 Integer overflow and signedness fixes (Bug#8873).
3101 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3102 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3104 * fileio.c: Don't assume EMACS_INT fits in off_t.
3105 (emacs_lseek): New static function.
3106 (Finsert_file_contents, Fwrite_region): Use it.
3107 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3109 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3111 * fns.c: Don't overflow int when computing a list length.
3112 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3113 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3114 truncation on 64-bit hosts. Check for QUIT every
3115 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3116 faster and is responsive enough.
3117 (Flength): Report an error instead of overflowing an integer.
3118 (Fsafe_length): Return a float if the value is not representable
3119 as a fixnum. This shouldn't happen except in contrived situations.
3120 (Fnthcdr, Fsort): Don't assume list length fits in int.
3121 (Fcopy_sequence): Don't assume vector length fits in int.
3123 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3124 (header_size, word_size): New constants.
3125 (allocate_vectorlike): Don't check size overflow here.
3126 (allocate_vector): Check it here instead, since this is the only
3127 caller of allocate_vectorlike that could cause overflow.
3128 Check that the new vector's length is representable as a fixnum.
3130 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3131 The previous code was bogus. For example, next_almost_prime (32)
3132 returned 39, which is undesirable as it is a multiple of 3; and
3133 next_almost_prime (24) returned 25, which is a multiple of 5 so
3134 why was the code bothering to check for multiples of 7?
3136 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3138 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3140 Variadic C functions now count arguments with ptrdiff_t.
3141 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3142 Back then I didn't know that the Emacs coding style prefers signed int.
3143 Also, in the meantime I found a few more instances where arguments
3144 were being counted with int, which may truncate counts on 64-bit
3145 machines, or EMACS_INT, which may be unnecessarily wide.
3146 * lisp.h (struct Lisp_Subr.function.aMANY)
3147 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3148 Arg counts are now ptrdiff_t, not size_t.
3149 All variadic functions and their callers changed accordingly.
3150 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3151 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3152 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3153 * callint.c (Fcall_interactively): Check arg count for overflow,
3154 to avoid potential buffer overrun. Use signed char, not 'int',
3155 for 'varies' array, so that we needn't bother to check its size
3156 calculation for overflow.
3157 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3158 * eval.c (apply_lambda):
3159 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3160 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3161 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3163 * callint.c (Fcall_interactively): Don't use index var as event count.
3165 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3166 * mem-limits.h (SIZE): Remove; no longer used.
3168 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3170 Remove unnecessary casts.
3171 * xterm.c (x_term_init):
3172 * xfns.c (x_set_border_pixel):
3173 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3174 These aren't needed now that we assume ANSI C.
3176 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3177 It's more likely to cause problems (due to unsigned overflow)
3180 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3182 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3184 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3186 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3188 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3190 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3192 GLYPH_CODE_FACE returns EMACS_INT, not int.
3193 * dispextern.h (merge_faces):
3194 * xfaces.c (merge_faces):
3195 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3196 Don't assume EMACS_INT fits in int.
3198 * character.h (CHAR_VALID_P): Remove unused parameter.
3199 * fontset.c, lisp.h, xdisp.c: All uses changed.
3201 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3203 * fns.c (concat): Minor tuning based on overflow analysis.
3204 This doesn't fix any bugs. Use int to hold character, instead
3205 of constantly refetching from Emacs object. Use XFASTINT, not
3206 XINT, for value known to be a character. Don't bother comparing
3207 a single byte to 0400, as it's always less.
3209 * floatfns.c (Fexpt):
3210 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3212 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3215 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3217 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3218 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3219 incorrectly succeed when S was a string, because 4294967386 was
3220 truncated before it was used.
3222 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3223 Otherwise, an out-of-range integer could cause undefined behavior
3226 * composite.c: Use int, not EMACS_INT, for characters.
3227 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3228 EMACS_INT, for values that are known to be in character range.
3229 This doesn't fix any bugs but is the usual style inside Emacs and
3230 may generate better code on 32-bit machines.
3232 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3233 This is for reasons similar to the recent CHAR_STRING fix.
3234 * charset.c (Fencode_char): Check that character arg is actually
3235 a character. Pass an int to ENCODE_CHAR.
3236 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3237 wider than 'int', as a compile-time check to prevent future regressions
3240 * character.c (char_string): Remove unnecessary casts.
3242 Make sure a 64-bit char is never passed to CHAR_STRING.
3243 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3244 by silently ignoring the top 32 bits, allowing some values
3245 that were far too large to be valid characters.
3246 * character.h: Include <verify.h>.
3247 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3248 arguments are no wider than unsigned, as a compile-time check
3249 to prevent future regressions in this area.
3251 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3252 (Fsubst_char_in_region):
3254 * xdisp.c (decode_mode_spec_coding):
3255 Adjust to CHAR_STRING's new requirement.
3256 * editfns.c (Finsert_char, Fsubst_char_in_region):
3257 * fns.c (concat): Check that character args are actually
3258 characters. Without this test, these functions did the wrong
3259 thing with wildly out-of-range values on 64-bit hosts.
3261 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3262 These casts should not be needed on 32-bit hosts, either.
3263 * keyboard.c (read_char):
3264 * lread.c (Fload): Remove casts to unsigned.
3266 * lisp.h (UNSIGNED_CMP): New macro.
3267 This fixes comparison bugs on 64-bit hosts.
3268 (ASCII_CHAR_P): Use it.
3269 * casefiddle.c (casify_object):
3270 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3271 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3272 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3273 * dispextern.h (FACE_FROM_ID):
3274 * keyboard.c (read_char): Use UNSIGNED_CMP.
3276 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3277 not to EMACS_INT, to avoid GCC warning.
3279 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3281 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3282 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3283 isn't needed on 32-bit machines.
3285 * buffer.c (Fgenerate_new_buffer_name):
3286 Use EMACS_INT for count, not int.
3287 (advance_to_char_boundary): Return EMACS_INT, not int.
3289 * data.c (Qcompiled_function): Now static.
3291 * window.c (window_body_lines): Now static.
3293 * image.c (gif_load): Rename local to avoid shadowing.
3295 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3296 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3297 * alloc.c (make_save_value): Integer argument is now of type
3299 (mark_object): Use ptrdiff_t, not int.
3300 * lisp.h (pD): New macro.
3301 * print.c (print_object): Use it.
3303 * alloc.c: Use EMACS_INT, not int, to count objects.
3304 (total_conses, total_markers, total_symbols, total_vector_size)
3305 (total_free_conses, total_free_markers, total_free_symbols)
3306 (total_free_floats, total_floats, total_free_intervals)
3307 (total_intervals, total_strings, total_free_strings):
3308 Now EMACS_INT, not int. All uses changed.
3309 (Fgarbage_collect): Compute overall total using a double, so that
3310 integer overflow is less likely to be a problem. Check for overflow
3311 when converting back to an integer.
3312 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3313 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3314 These were 'int' variables that could overflow on 64-bit hosts;
3315 they were never used, so remove them instead of repairing them.
3316 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3317 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3318 Previously, this ceilinged at INT_MAX, but that doesn't work on
3320 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3322 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3323 (allocate_vectorlike): Check for ptrdiff_t overflow.
3324 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3325 when a (possibly-narrower) signed value would do just as well.
3326 We prefer using signed arithmetic, to avoid comparison confusion.
3328 * alloc.c: Catch some string size overflows that we were missing.
3329 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3330 for convenience in STRING_BYTES_MAX.
3331 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3332 The definition here is exact; the one in lisp.h was approximate.
3333 (allocate_string_data): Check for string overflow. This catches
3334 some instances we weren't catching before. Also, it catches
3335 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3336 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3337 and ptrdiff_t and EMACS_INT are both 64 bits.
3339 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3340 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3341 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3343 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3345 * alloc.c (Fmake_string): Check for out-of-range init.
3347 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3349 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3351 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3353 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3354 xg_get_default_scrollbar_width.
3356 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3357 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3358 (style_changed_cb): Call update_theme_scrollbar_width and call
3359 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3360 all frames (Bug#8505).
3361 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3362 Call gtk_window_set_resizable if HAVE_GTK3.
3363 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3364 and height if HAVE_GTK3 (Bug#8505).
3365 (scroll_bar_width_for_theme): New variable.
3366 (update_theme_scrollbar_width): New function.
3367 (xg_get_default_scrollbar_width): Move code to
3368 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3369 (xg_initialize): Call update_theme_scrollbar_width.
3371 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3373 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3375 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3377 * frame.c (make_frame): Call other_buffer_safely instead of
3380 * window.c (temp_output_buffer_show): Call display_buffer with
3381 second argument Vtemp_buffer_show_specifiers and reset latter
3382 immediately after the call.
3383 (Vtemp_buffer_show_specifiers): New variable.
3384 (auto_window_vscroll_p, next_screen_context_lines)
3385 (Vscroll_preserve_screen_position): Remove leading asterisks from
3388 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3390 Fix minor problems found by GCC 4.6.0 static checking.
3391 * buffer.c (Qclone_number): Remove for now, as it's unused.
3392 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3393 (record_buffer): Remove unused local.
3394 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3395 (set_frame_buffer_list): Remove; unused.
3396 * frame.h (other_visible_frames): Remove decl.
3397 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3398 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3399 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3401 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3402 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3403 Define only if HAVE_GPM.
3404 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3405 (update_hints_inhibit): Remove; never set. All uses removed.
3406 * widgetprv.h (emacsFrameClassRec): Remove decl.
3407 * window.c (delete_deletable_window): Now returns void, since it
3408 wasn't returning anything.
3409 (compare_window_configurations): Remove unused locals.
3410 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3411 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3412 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3413 the same widths as pointers. This follows up on the 2011-05-06 patch.
3414 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3415 * xterm.h: Likewise.
3416 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3418 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3420 * makefile.w32-in: Update dependencies.
3421 (LISP_H): Add lib/intprops.h.
3423 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3425 * image.c (gif_load): Add animation frame delay to the metadata.
3426 (syms_of_image): Use DEFSYM. New symbol `delay'.
3428 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3430 * window.c (delete_deletable_window): Re-add.
3431 (Fset_window_configuration): Rewrite to handle dead buffers and
3432 consequently deletable windows.
3433 (window_tree, Fwindow_tree): Remove. Supply functionality in
3435 (compare_window_configurations): Simplify code.
3437 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3439 * image.c (imagemagick_load_image): Fix type mismatch.
3440 (Fimagemagick_types): Likewise.
3442 * window.h (replace_buffer_in_windows): Declare.
3444 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3446 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3447 Qclone_number. Remove external declaration of Qdelete_window.
3448 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3450 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3451 Run Qbuffer_list_update_hook if allowed.
3452 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3453 buffer list implementation.
3454 (other_buffer_safely): New function.
3455 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3456 calls to replace_buffer_in_windows and
3457 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3459 (record_buffer): Inhibit quitting and rewrite using quittable
3460 functions. Run Qbuffer_list_update_hook if allowed.
3461 (Frecord_buffer, Funrecord_buffer): New functions.
3462 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3463 Move switch-to-buffer to window.el.
3464 (bury-buffer): Move to window.el.
3465 (Vbuffer_list_update_hook): New variable.
3467 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3470 * window.h (resize_frame_windows): Move up in code.
3471 (Fwindow_frame): Remove EXFUN.
3472 (replace_buffer_in_all_windows): Remove prototype.
3473 (replace_buffer_in_windows_safely): Add prototype.
3475 * window.c: Declare Qdelete_window static again. Move down
3476 declaration of select_count.
3477 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3478 (Fother_window): Move to window.el.
3479 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3480 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3481 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3483 (replace_buffer_in_windows): Implement by calling
3484 Qreplace_buffer_in_windows.
3485 (replace_buffer_in_all_windows): Remove with some functionality
3486 moved into replace_buffer_in_windows_safely.
3487 (replace_buffer_in_windows_safely): New function.
3488 (select_window_norecord, select_frame_norecord): Move in front
3489 of run_window_configuration_change_hook. Remove now obsolete
3491 (Fset_window_buffer): Rewrite doc-string.
3492 Call Qrecord_window_buffer.
3493 (keys_of_window): Move binding for other-window to window.el.
3495 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3497 * dispextern.h (struct image): Replace data member, whose int_val
3498 and ptr_val fields were not used by anything, with a single
3501 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3502 (gif_clear_image, gif_load, imagemagick_load_image)
3503 (gs_clear_image, gs_load): Callers changed.
3505 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3507 * buffer.h: Include <time.h>, for time_t.
3508 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3510 Fix minor problems found by static checking.
3512 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3514 Make identifiers static if they are not used in other modules.
3515 * data.c (Qcompiled_function, Qframe, Qvector):
3516 * image.c (QimageMagick, Qsvg):
3517 * minibuf.c (Qmetadata):
3518 * window.c (resize_window_check, resize_root_window): Now static.
3519 * window.h (resize_window_check, resize_root_window): Remove decls.
3521 * window.c (window_deletion_count, delete_deletable_window):
3523 (window_body_lines): Now static.
3524 (Fdelete_other_windows_internal): Mark vars as initialized.
3525 Make sure 'resize_failed' is initialized.
3526 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3527 (resize_window_apply): Remove unused local.
3528 * window.h (delete_deletable_window): Remove decl.
3530 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3531 (imagemagick_load_image): Fix pointer signedness problem by changing
3532 last arg from unsigned char * to char *. All uses changed.
3533 Also, fix a local for similar reasons.
3534 Remove unused locals. Remove locals to avoid shadowing.
3535 (fn_rsvg_handle_free): Remove; unused.
3536 (svg_load, svg_load_image): Fix pointer signedness problem.
3537 (imagemagick_load_image): Don't use garbage pointer image_wand.
3539 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3541 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3543 * image.c (gif_load): Fix omitted cast error introduced by
3546 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3548 * window.h (resize_proportionally, orig_total_lines)
3549 (orig_top_line): Remove from window structure.
3550 (set_window_height, set_window_width, change_window_heights)
3551 (Fdelete_window): Remove prototypes.
3552 (resize_frame_windows): Remove duplicate declaration.
3554 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3556 * window.h (resize_frame_windows, resize_window_check)
3557 (delete_deletable_window, resize_root_window)
3558 (resize_frame_windows): Declare prototypes.
3560 * window.c (resize_window_apply): Make definition be "static" to
3561 match the prototype.
3563 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3565 * window.c: Remove declarations of Qwindow_size_fixed,
3566 window_min_size_1, window_min_size_2, window_min_size,
3567 size_window, window_fixed_size_p, enlarge_window, delete_window.
3568 Remove static from declaration of Qdelete_window, it's
3569 temporarily needed by Fbury_buffer.
3570 (replace_window): Don't assign orig_top_line and
3572 (Fdelete_window, delete_window): Remove. Window deletion is
3573 handled by window.el.
3574 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3575 Replace Fdelete_window calls with calls to Qdelete_window.
3576 (Fdelete_other_windows): Remove. Deleting other windows is
3577 handled by window.el.
3578 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3579 handled in window.el.
3580 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3581 Window minimum sizes are handled in window.el.
3582 (shrink_windows, size_window, set_window_height)
3583 (set_window_width, change_window_heights, window_height)
3584 (window_width, CURBEG, CURSIZE, enlarge_window)
3585 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3586 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3587 handled in window.el.
3588 (make_dummy_parent): Rename to make_parent_window and give it a
3589 second argument horflag.
3590 (make_window): Don't set resize_proportionally any more.
3591 (Fsplit_window): Remove. Windows are split in window.el.
3592 (save_restore_action, save_restore_orig_size)
3593 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3594 Resize mini windows in window.el.
3595 (grow_mini_window, shrink_mini_window): Implement by calling
3596 Qresize_root_window_vertically, resize_window_check and
3597 resize_window_apply.
3598 (saved_window, Fset_window_configuration, save_window_save):
3599 Do not handle orig_top_line, orig_total_lines, and
3600 resize_proportionally.
3601 (window_min_height, window_min_width): Move to window.el.
3602 (keys_of_window): Move bindings for delete-other-windows,
3603 split-window, delete-window and enlarge-window to window.el.
3605 * buffer.c: Temporarily extern Qdelete_window.
3606 (Fbury_buffer): Temporarily call Qdelete_window instead of
3607 Fdelete_window (Fbury_buffer will move to window.el soon).
3609 * frame.c (set_menu_bar_lines_1): Remove code handling
3610 orig_top_line and orig_total_lines.
3612 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3613 set_window_height but set heights directly.
3614 (change_frame_size_1): Use resize_frame_windows.
3616 * xdisp.c (init_xdisp): Don't use set_window_height but set
3619 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3620 Use resize_frame_windows instead of change_window_heights and run
3621 run_window_configuration_change_hook.
3623 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3624 instead of change_window_heights and run
3625 run_window_configuration_change_hook.
3627 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3629 * window.c (replace_window): Rename second argument REPLACEMENT to
3630 NEW. New third argument SETFLAG. Rewrite.
3631 (delete_window, make_dummy_parent): Call replace_window with
3633 (window_list_1): Move down in code.
3634 (run_window_configuration_change_hook): Move set_buffer part
3635 before select_frame_norecord part in order to unwind correctly.
3636 Rename count1 to count.
3637 (recombine_windows, delete_deletable_window, resize_root_window)
3638 (Fdelete_other_windows_internal)
3639 (Frun_window_configuration_change_hook, make_parent_window)
3640 (resize_window_check, resize_window_apply, Fresize_window_apply)
3641 (resize_frame_windows, Fsplit_window_internal)
3642 (Fdelete_window_internal, Fresize_mini_window_internal):
3644 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3646 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3648 * window.h (window): Add some new members to window structure -
3649 normal_lines, normal_cols, new_total, new_normal, clone_number,
3650 splits, nest, prev_buffers, next_buffers.
3651 (WINDOW_TOTAL_SIZE): Move here from window.c.
3652 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3654 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3656 (make_dummy_parent): Set new members of windows structure.
3657 (make_window): Move down in code. Handle new members of window
3659 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3660 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3661 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3662 (Fset_window_prev_buffers, Fwindow_next_buffers)
3663 (Fset_window_next_buffers, Fset_window_clone_number):
3665 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3666 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3668 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3669 Argument WINDOW can be now internal window too.
3670 (Fwindow_use_time): Move up in code.
3671 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3673 (Fset_window_configuration, saved_window)
3674 (Fcurrent_window_configuration, save_window_save): Handle new
3675 members of window structure.
3676 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3677 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3678 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3679 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3680 Qget_mru_window, Qresize_root_window,
3681 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3682 Qauto_buffer_name; staticpro them.
3684 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3686 * window.c (Fwindow_total_size, Fwindow_left_column)
3687 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3688 (Fwindow_list_1): New functions.
3689 (window_box_text_cols): Replace with window_body_cols.
3690 (Fwindow_width, Fscroll_left, Fscroll_right):
3691 Use window_body_cols instead of window_box_text_cols.
3692 (delete_window, Fset_window_configuration):
3693 Call delete_all_subwindows with window as argument.
3694 (delete_all_subwindows): Take a window as argument and not a
3696 (window_loop): Remove handling of GET_LRU_WINDOW and
3698 (Fget_lru_window, Fget_largest_window): Move to window.el.
3700 * window.h: Extern window_body_cols instead of
3701 window_box_text_cols. delete_all_subwindows now takes a
3702 Lisp_Object as argument.
3704 * indent.c (compute_motion, Fcompute_motion):
3705 Use window_body_cols instead of window_box_text_cols.
3707 * frame.c (delete_frame): Call delete_all_subwindows with root
3710 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3712 * fns.c (Fputhash): Document return value.
3714 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3716 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3718 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3720 Cons<->int and similar integer overflow fixes (Bug#8794).
3722 Check for overflow when converting integer to cons and back.
3723 * charset.c (Fdefine_charset_internal, Fdecode_char):
3724 Use cons_to_unsigned to catch overflow.
3725 (Fencode_char): Use INTEGER_TO_CONS.
3726 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3727 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3728 * data.c (long_to_cons, cons_to_long): Remove.
3729 (cons_to_unsigned, cons_to_signed): New functions.
3730 These signal an error for invalid or out-of-range values.
3731 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3732 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3733 * font.c (Ffont_variation_glyphs):
3734 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3735 * lisp.h: Include <intprops.h>.
3736 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3737 (cons_to_signed, cons_to_unsigned): New decls.
3738 (long_to_cons, cons_to_long): Remove decls.
3739 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3740 (Fprimitive_undo): Use CONS_TO_INTEGER.
3741 * xfns.c (Fx_window_property): Likewise.
3742 * xselect.c: Include <limits.h>.
3743 (x_own_selection, selection_data_to_lisp_data):
3744 Use INTEGER_TO_CONS.
3745 (x_handle_selection_request, x_handle_selection_clear)
3746 (x_get_foreign_selection, Fx_disown_selection_internal)
3747 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3748 (lisp_data_to_selection_data): Use cons_to_unsigned.
3749 (x_fill_property_data): Use cons_to_signed.
3750 Report values out of range.
3752 Check for buffer and string overflow more precisely.
3753 * buffer.h (BUF_BYTES_MAX): New macro.
3754 * lisp.h (STRING_BYTES_MAX): New macro.
3755 * alloc.c (Fmake_string):
3756 * character.c (string_escape_byte8):
3757 * coding.c (coding_alloc_by_realloc):
3758 * doprnt.c (doprnt):
3759 * editfns.c (Fformat):
3761 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3762 since they may not be the same number.
3763 * editfns.c (Finsert_char):
3764 * fileio.c (Finsert_file_contents):
3765 Likewise for BUF_BYTES_MAX.
3767 * image.c: Use ptrdiff_t, not int, for sizes.
3768 (slurp_file): Switch from int to ptrdiff_t.
3770 (slurp_file): Check that file size fits in both size_t (for
3771 malloc) and ptrdiff_t (for sanity and safety).
3773 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3774 if b->modtime has its maximal value.
3776 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3778 Don't assume time_t can fit into int.
3779 * buffer.h (struct buffer.modtime): Now time_t, not int.
3780 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3781 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3783 Minor fixes for signed vs unsigned integers.
3784 * character.h (MAYBE_UNIFY_CHAR):
3785 * charset.c (maybe_unify_char):
3786 * keyboard.c (read_char, reorder_modifiers):
3787 XINT -> XFASTINT, since the integer must be nonnegative.
3788 * ftfont.c (ftfont_spec_pattern):
3789 * keymap.c (access_keymap, silly_event_symbol_error):
3790 XUINT -> XFASTINT, since the integer must be nonnegative.
3791 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3792 since it makes no difference and we prefer signed.
3793 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3794 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3797 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3799 * window.h (Fwindow_frame): Declare.
3801 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3803 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3804 (SPARE_MEMORY): Always define.
3805 (LARGE_REQUEST): Remove.
3806 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3808 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3810 * lisp.h: Move EXFUNS for Fframe_root_window,
3811 Fframe_first_window and Fset_frame_selected_window to window.h.
3813 * window.h: Move EXFUNS for Fframe_root_window,
3814 Fframe_first_window and Fset_frame_selected_window here from
3817 * frame.c (Fwindow_frame, Fframe_first_window)
3818 (Fframe_root_window, Fframe_selected_window)
3819 (Fset_frame_selected_window): Move to window.c.
3820 (Factive_minibuffer_window): Move to minibuf.c.
3821 (Fother_visible_frames_p): New function.
3823 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3825 * window.c (decode_window, decode_any_window): Move up in code.
3826 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3827 (inhibit_frame_unsplittable): Remove unused variable.
3828 (Fwindow_buffer): Move up and rewrite doc-string.
3829 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3830 (Fwindow_prev): New functions.
3831 (Fwindow_frame): Move here from frame.c. Accept any window as
3833 (Fframe_root_window, Fframe_first_window)
3834 (Fframe_selected_window): Move here from frame.c. Accept frame
3835 or arbitrary window as argument. Update doc-strings.
3836 (Fminibuffer_window): Move up in code.
3837 (Fwindow_minibuffer_p): Move up in code and simplify.
3838 (Fset_frame_selected_window): Move here from frame.c.
3840 (Fselected_window, select_window, Fselect_window): Move up in
3841 code. Minor doc-string fixes.
3843 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3845 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3846 Do not assume that spare memory exists; that assumption is valid
3847 only if SYSTEM_MALLOC.
3848 (LARGE_REQUEST): New macro, so that the issue of large requests
3849 is separated from the issue of spare memory.
3851 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3853 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3856 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3858 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3861 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3863 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3865 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3867 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3868 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3870 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3872 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3874 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3876 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3877 (x_clipboard_manager_save): Add return value.
3878 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3880 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3881 Obey Vx_select_enable_clipboard_manager. Catch errors in
3882 x_clipboard_manager_save (Bug#8779).
3883 (Vx_select_enable_clipboard_manager): New variable.
3884 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3886 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3888 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3890 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3892 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3893 in the current matrix if keep_current_p is non-zero.
3895 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3897 * bidi.c (bidi_level_of_next_char): Fix last change.
3899 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3901 Support bidi reordering of text covered by display properties.
3903 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3904 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3905 (bidi_cache_search, bidi_cache_iterator_state)
3906 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3907 (bidi_level_of_next_char, bidi_move_to_visually_next):
3908 Support character positions inside a run of characters covered by a
3910 (bidi_paragraph_init, bidi_resolve_explicit_1)
3911 (bidi_level_of_next_char): Call bidi_fetch_char and
3912 bidi_fetch_char_advance instead of FETCH_CHAR and
3914 (bidi_init_it): Initialize new members.
3915 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3917 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3918 instead of using explicit *_CHAR codes.
3919 (bidi_resolve_explicit, bidi_resolve_weak):
3920 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3921 bidirectional text is supported only in multibyte buffers.
3922 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3923 it to initialize the frame_window_p member of struct bidi_it.
3924 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3925 (bidi_resolve_explicit, bidi_resolve_weak)
3926 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3927 bidi_it->nchars is non-positive.
3928 (bidi_level_of_next_char): Don't try to lookup the cache for the
3929 next/previous character if nothing is cached there yet, or if we
3930 were just reseat()'ed to a new position.
3932 * xdisp.c (set_cursor_from_row): Set start and stop points
3933 according to the row's direction when priming the loop that looks
3934 for the glyph on which to display cursor.
3935 (single_display_spec_intangible_p): Function deleted.
3936 (display_prop_intangible_p): Reimplement to call
3937 handle_display_spec instead of single_display_spec_intangible_p.
3938 Accept 3 additional arguments needed by handle_display_spec.
3939 This fixes incorrect cursor motion across display property with complex
3940 values: lists, `(when COND...)' forms, etc.
3941 (single_display_spec_string_p): Support property values that are
3942 lists with the argument STRING its top-level element.
3943 (display_prop_string_p): Fix the condition for processing a
3944 property that is a list to be consistent with handle_display_spec.
3945 (handle_display_spec): New function, refactored from the
3946 last portion of handle_display_prop.
3947 (compute_display_string_pos): Accept additional argument
3948 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3949 value of a `display' property is a "replacing spec".
3950 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3951 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3952 the display property, but just return a value indicating whether
3953 the display property will replace the characters it covers.
3954 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3955 frame_window_p members of struct bidi_it.
3956 (compute_display_string_pos, compute_display_string_end):
3958 (push_it): Accept second argument POSITION, where pop_it should
3959 jump to continue iteration.
3960 (reseat_1): Initialize bidi_it.disp_pos.
3962 * keyboard.c (adjust_point_for_property): Adjust the call to
3963 display_prop_intangible_p to its new signature.
3965 * dispextern.h (struct bidi_it): New member frame_window_p.
3966 (bidi_init_it): Update prototypes.
3967 (display_prop_intangible_p): Update prototype.
3968 (compute_display_string_pos, compute_display_string_end):
3970 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3973 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3975 Malloc failure behavior now depends on size of allocation.
3976 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3977 * lisp.h: Change signatures accordingly.
3978 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3979 All callers changed. (Bug#8762)
3981 * gnutls.c: Use Emacs's memory allocators.
3982 Without this change, the gnutls library would invoke malloc etc.
3983 directly, which causes problems on non-SYNC_INPUT hosts, and which
3984 runs afoul of improving memory_full behavior. (Bug#8761)
3985 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3986 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3987 xfree instead of the default malloc, realloc, free.
3988 (Fgnutls_boot): No need to check for memory allocation failure,
3989 since xmalloc does that for us.
3991 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3992 * category.c (hash_get_category_set):
3993 * ccl.c (ccl_driver):
3994 * charset.c (Fdefine_charset_internal):
3995 * charset.h (struct charset.hash_index):
3996 * composite.c (get_composition_id, gstring_lookup_cache)
3997 (composition_gstring_put_cache):
3998 * composite.h (struct composition.hash_index):
3999 * dispextern.h (struct image.hash):
4000 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4001 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4002 (hashfn_equal, hashfn_user_defined, make_hash_table)
4003 (maybe_resize_hash_table, hash_lookup, hash_put)
4004 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4005 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4006 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4007 * image.c (make_image, search_image_cache, lookup_image)
4008 (xpm_put_color_table_h):
4009 * lisp.h (struct Lisp_Hash_Table):
4010 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4011 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4012 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4013 * alloc.c (allocate_vectorlike):
4014 Check for overflow in vector size calculations.
4015 * ccl.c (ccl_driver):
4016 Check for overflow when converting EMACS_INT to int.
4017 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4018 need to be updated by these changes.
4019 * fns.c (make_hash_table, maybe_resize_hash_table):
4020 Check for integer overflow with large hash tables.
4021 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4022 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4023 (SXHASH_REDUCE): New macro.
4024 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4025 Use it instead of discarding useful hash info with large hash values.
4026 (sxhash_float): New function.
4027 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4028 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4029 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4030 Rewrite to use FIXNUM_BITS, as this simplifies things.
4031 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4032 Adjust signatures to match updated version of code.
4033 (consing_since_gc): Now EMACS_INT, since a single hash table can
4034 use more than INT_MAX bytes.
4036 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4038 Make it possible to build with GCC-4.6+ -O2 -flto.
4040 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4042 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4044 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4045 Call minibuffer-inactive-mode.
4047 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4049 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4050 Update dependencies.
4052 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4054 * data.c (init_data): Remove code for UTS, this system is not
4057 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4059 Don't force ./temacs to start in terminal mode.
4061 * frame.c (make_initial_frame): Initialize faces in all cases, not
4062 only when CANNOT_DUMP is defined.
4063 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4065 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4067 * dispnew.c (add_window_display_history): Use const for the string
4068 pointer. Remove declaration, not needed.
4070 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4072 Use 'inline', not 'INLINE'.
4073 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4074 * alloc.c, fontset.c (INLINE): Remove.
4075 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4076 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4077 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4078 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4079 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4081 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4083 Make it possible to run ./temacs.
4085 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4086 syms_of_callproc does the same thing. Remove test for
4087 "initialized", do it in the caller.
4088 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4090 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4092 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4093 (read_minibuf): Use get_minibuffer.
4094 (syms_of_minibuf): Use DEFSYM.
4095 (Qmetadata): New var.
4096 * data.c (Qbuffer): Don't make it static.
4097 (syms_of_data): Use DEFSYM.
4099 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4101 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4102 (CCL_CODE_MIN): New macro.
4104 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4106 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4108 * eval.c (Qdebug): Now static.
4109 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4110 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4111 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4113 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4115 * image.c: Various fixes to ImageMagick code comments.
4116 (Fimagemagick_types): Doc fix.
4118 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4120 Minor fixes prompted by GCC 4.6.0 warnings.
4122 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4124 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4125 (x_clipboard_manager_save_all): Move extern decl to ...
4126 * xterm.h: ... here, so that it can be checked for consistency.
4128 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4130 * xselect.c (x_clipboard_manager_save_frame)
4131 (x_clipboard_manager_save_all): New functions.
4132 (Fx_clipboard_manager_save): Lisp function deleted.
4134 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4135 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4137 * xterm.h: Update prototype.
4139 2011-05-28 William Xu <william.xwl@gmail.com>
4141 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4144 2011-05-28 Jim Meyering <meyering@redhat.com>
4146 Avoid a sign-extension bug in crypto_hash_function.
4147 * fns.c (to_uchar): Define.
4148 (crypto_hash_function): Use it to convert some newly-signed
4149 variables to unsigned, to avoid sign-extension bugs. For example,
4150 without this change, (md5 "truc") would evaluate to
4151 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4152 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4153 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4155 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4157 Integer overflow fixes.
4159 * dbusbind.c: Serial number integer overflow fixes.
4160 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4161 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4162 to hold a serial number that is too large for a fixnum.
4163 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4164 Check for serial numbers out of range. Decode any serial number
4165 that was so large that it became a float. (Bug#8722)
4167 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4168 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4169 Use XFASTINT rather than XUINT when numbers are nonnegative.
4170 (xd_append_arg, Fdbus_method_return_internal):
4171 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4172 arguments, check that Lisp number is nonnegative, rather than
4173 silently wrapping negative numbers around. (Bug#8722)
4174 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4177 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4179 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4181 ccl: add integer overflow checks
4182 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4183 (IN_INT_RANGE): New macros.
4184 (ccl_driver): Use them to check for integer overflow when
4185 decoding a CCL program. Many of the new checks are whether XINT (x)
4186 fits in int; it doesn't always, on 64-bit hosts. The new version
4187 doesn't catch all possible integer overflows, but it's an
4188 improvement. (Bug#8719)
4190 * alloc.c (make_event_array): Use XINT, not XUINT.
4191 There's no need for unsigned here.
4193 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4194 This follows up to the 2011-05-06 change that substituted uintptr_t
4195 for EMACS_INT. This case wasn't caught back then.
4197 Rework Fformat to avoid integer overflow issues.
4198 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4199 now (part of C89). Include <verify.h>.
4200 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4201 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4202 (Fformat): Avoid the prepass trying to compute sizes; it was only
4203 approximate and thus did not catch overflow reliably. Instead, walk
4204 through the format just once, formatting and computing sizes as we go,
4205 checking for integer overflow at every step, and allocating a larger
4206 buffer as needed. Keep track separately whether the format is
4207 multibyte. Keep only the most-recently calculated precision, rather
4208 than them all. Record whether each argument has been converted to
4209 string. Use EMACS_INT, not int, for byte and char and arg counts.
4210 Support field widths and precisions larger than INT_MAX. Avoid
4211 sprintf's undefined behavior with conversion specifications such as %#d
4212 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4213 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4214 formatting out-of-range floating point numbers with int
4217 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4219 * data.c: Avoid integer truncation in expressions involving floats.
4220 * data.c: Include <intprops.h>.
4221 (arith_driver): When there's an integer overflow in an expression
4222 involving floating point, convert the integers to floating point
4223 so that the resulting value does not suffer from catastrophic
4224 integer truncation. For example, on a 64-bit host (* 4
4225 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4226 Do not rely on undefined behavior after integer overflow.
4228 merge count_size_as_multibyte, parse_str_to_multibyte
4229 * character.c, character.h (count_size_as_multibyte):
4230 Rename from parse_str_to_multibyte; all uses changed.
4231 Check for integer overflow.
4232 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4233 since it's now a duplicate of the other. This is more of
4234 a character than a buffer op, so better that it's in character.c.
4235 * fns.c, print.c: Adjust to above changes.
4237 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4239 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4241 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4243 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4244 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4245 (x_clipboard_manager_save): Now static.
4246 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4248 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4249 (crypto_hash_function): Now static.
4250 Fix pointer signedness problems. Avoid unnecessary initializations.
4252 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4254 * termhooks.h (Vselection_alist): Make it terminal-local.
4256 * terminal.c (create_terminal): Initialize it.
4258 * xselect.c: Support for clipboard managers.
4259 (Vselection_alist): Move to termhooks.h as terminal-local var.
4260 (LOCAL_SELECTION): New macro.
4261 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4262 (symbol_to_x_atom): Remove gratuitous arg.
4263 (x_handle_selection_request, lisp_data_to_selection_data)
4264 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4265 (x_own_selection, x_get_local_selection, x_convert_selection):
4266 New arg, specifying work frame. Use terminal-local Vselection_alist.
4267 (some_frame_on_display): Delete unused function.
4268 (Fx_own_selection_internal, Fx_get_selection_internal)
4269 (Fx_disown_selection_internal, Fx_selection_owner_p)
4270 (Fx_selection_exists_p): New optional frame arg.
4271 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4272 (x_handle_selection_clear): Don't treat other terminals with the
4273 same keyboard specially. Use the terminal-local Vselection_alist.
4274 (x_clear_frame_selections): Use Frun_hook_with_args.
4276 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4278 * xterm.h: Add support for those atoms.
4280 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4282 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4283 (converted_selections, conversion_fail_tag): New global variables.
4284 (x_selection_request_lisp_error): Free the above.
4285 (x_get_local_selection): Remove unnecessary code.
4286 (x_reply_selection_request): Args changed; handle arbitrary array
4287 of converted selections stored in converted_selections.
4288 Separate the XChangeProperty and SelectionNotify steps.
4289 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4290 (x_convert_selection): New function.
4291 (x_handle_selection_event): Simplify.
4292 (x_get_foreign_selection): Don't ignore incoming requests while
4293 waiting for an answer; this will fail when we implement
4294 SAVE_TARGETS, and seems unnecessary anyway.
4295 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4296 (Vx_sent_selection_functions): Doc fix.
4298 2011-05-26 Leo Liu <sdl.web@gmail.com>
4300 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4302 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4304 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4306 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4307 for fringe update if it has periodic bitmap.
4308 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4309 and fringe_bitmap_periodic_p.
4311 * fringe.c (get_fringe_bitmap_data): New function.
4312 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4313 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4314 row. Mark glyph row for fringe update if periodicity changed.
4316 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4317 for fringe update unless it has periodic bitmap.
4319 2011-05-25 Kenichi Handa <handa@m17n.org>
4321 * xdisp.c (get_next_display_element): Set correct it->face_id for
4322 a static composition.
4324 2011-05-24 Leo Liu <sdl.web@gmail.com>
4327 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4329 * fns.c (crypto_hash_function, Fsha1): New function.
4330 (Fmd5): Use crypto_hash_function.
4331 (syms_of_fns): Add Ssha1.
4333 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4335 * gnutls.c: Remove unused macros.
4336 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4337 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4338 Remove macros that are defined and never used.
4339 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4341 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4343 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4344 (Fx_get_selection_internal): Minor cleanup.
4345 (Fx_own_selection_internal): Rename arguments for consistency with
4348 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4350 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4352 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4354 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4356 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4358 * dispnew.c (scrolling_window): Don't exclude the case that the
4359 last enabled row in the desired matrix touches the bottom boundary.
4361 2011-05-21 Glenn Morris <rgm@gnu.org>
4363 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4364 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4365 and add some more files.
4367 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4369 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4370 report_file_error introduced by the change from 2011-05-07.
4372 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4374 * systime.h (Time): Define only if emacs is defined.
4375 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4376 where the include path doesn't have X11/X.h by default. See
4377 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4379 2011-05-20 Kenichi Handa <handa@m17n.org>
4381 * composite.c (find_automatic_composition): Fix previous change.
4383 2011-05-20 Glenn Morris <rgm@gnu.org>
4385 * lisp.mk: New file, split from Makefile.in.
4386 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4387 (shortlisp): Remove.
4388 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4390 2011-05-19 Glenn Morris <rgm@gnu.org>
4392 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4393 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4394 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4395 (lisp): Set the order to that of loadup.el.
4396 (shortlisp): Make it a copy of $lisp.
4397 (SOME_MACHINE_LISP): Remove.
4398 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4399 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4401 2011-05-18 Kenichi Handa <handa@m17n.org>
4403 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4404 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4405 (find_automatic_composition): Mostly rewrite for efficiency.
4407 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4409 * makefile.w32-in: Update dependencies.
4411 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4413 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4414 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4416 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4418 Fix some integer overflow issues, such as string length overflow.
4420 * insdel.c (count_size_as_multibyte): Check for string overflow.
4422 * character.c (lisp_string_width): Check for string overflow.
4423 Use EMACS_INT, not int, for string indexes and lengths; in
4424 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4425 the resulting string length overflows an EMACS_INT; instead,
4426 report a string overflow if no precision given. When checking for
4427 precision exhaustion, use a check that cannot possibly have
4428 integer overflow. (Bug#8675)
4429 * character.h (lisp_string_width): Adjust to new signature.
4431 * alloc.c (string_overflow): New function.
4432 (Fmake_string): Use it. This doesn't change behavior, but saves
4433 a few bytes and will simplify future changes.
4434 * character.c (string_escape_byte8): Likewise.
4435 * lisp.h (string_overflow): New decl.
4437 Fixups, following up to the user-interface timestamp change.
4438 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4439 for UI timestamps, instead of unsigned long.
4440 * msdos.c (mouse_get_pos): Likewise.
4441 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4442 * w32gui.h (Time): Define by including "systime.h" rather than by
4443 declaring it ourselves. (Bug#8664)
4445 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4446 * image.c (clear_image_cache): Likewise.
4448 * term.c (term_mouse_position): Don't assume time_t wraparound.
4450 Be more systematic about user-interface timestamps.
4451 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4452 and sometimes 'EMACS_UINT', to represent these timestamps.
4453 This change causes it to use 'Time' uniformly, as that's what X uses.
4454 This makes the code easier to follow, and makes it easier to catch
4455 integer overflow bugs such as Bug#8664.
4456 * frame.c (Fmouse_position, Fmouse_pixel_position):
4457 Use Time, not unsigned long, for user-interface timestamps.
4458 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4459 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4460 * keyboard.h (last_event_timestamp): Likewise.
4461 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4462 * menu.h (xmenu_show): Likewise.
4463 * term.c (term_mouse_position): Likewise.
4464 * termhooks.h (struct input_event.timestamp): Likewise.
4465 (struct terminal.mouse_position_hook): Likewise.
4466 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4467 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4468 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4469 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4471 * menu.h, termhooks.h: Include "systime.h", for Time.
4473 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4474 Don't assume that the difference between two unsigned long values
4475 can fit into an integer. At this point, we know button_down_time
4476 <= event->timestamp, so the difference must be nonnegative, so
4477 there's no need to cast the result if double-click-time is
4478 nonnegative, as it should be; check that it's nonnegative, just in
4479 case. This bug is triggered when events are more than 2**31 ms
4480 apart (about 25 days). (Bug#8664)
4482 * xselect.c (last_event_timestamp): Remove duplicate decl.
4483 (x_own_selection): Remove needless cast to unsigned long.
4485 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4486 that always fit in int. Use a sentinel instead of a counter, to
4487 avoid a temp and to allay GCC's concerns about possible int overflow.
4488 * frame.h (struct frame): Use int for menu_bar_items_used
4489 instead of EMACS_INT, since it always fits in int.
4491 * menu.c (grow_menu_items): Check for int overflow.
4493 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4495 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4496 Before, the code was not consistent. These values cannot exceed
4497 2**31 - 1 so there's no need to make them unsigned.
4498 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4499 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4500 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4502 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4504 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4505 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4506 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4507 presumably because the widths might not match.
4509 * window.c (size_window): Avoid needless test at loop start.
4511 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4513 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4515 2011-05-12 Drew Adams <drew.adams@oracle.com>
4517 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4519 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4521 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4522 `width' to `bar_area_x' and `bar_area_width', respectively.
4523 (x_scroll_run): Take account of fringe background extension.
4525 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4526 Rename local vars `left' and `width' to `bar_area_x' and
4527 `bar_area_width', respectively.
4528 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4529 background extension.
4531 2011-05-10 Jim Meyering <meyering@redhat.com>
4533 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4535 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4537 * image.c (Finit_image_library): Return t for built-in image types,
4538 like pbm and xbm. (Bug#8640)
4540 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4542 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4544 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4546 * w32console.c (Fset_screen_color): Doc fix.
4547 (Fget_screen_color): New function.
4548 (syms_of_ntterm): Defsubr it.
4550 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4551 unlink the temporary file if Fcall_process didn't create it in the
4553 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4554 child process will be redirected to a file specified with `:file'.
4555 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4556 cue to call_process_cleanup not to close that handle.
4558 2011-05-07 Ben Key <bkey76@gmail.com>
4560 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4561 one of two shell specific rules, either bootstrap-temacs-CMD or
4562 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4563 to the previous implementation of the bootstrap-temacs rule.
4564 The bootstrap-temacs-CMD rule is similar to the previous
4565 implementation of the bootstrap-temacs rule except that it
4566 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4569 These changes, along with some changes to nt/configure.bat,
4570 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4571 earlier fix to add support for --cflags and --ldflags options
4572 that include quotes so that it works whether make uses cmd or
4575 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4577 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4578 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4580 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4581 a string. Handle both cases.
4582 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4583 (Fdbus_register_method): Use Qinvalid_function.
4585 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4587 * makefile.w32-in: Update dependencies.
4588 (LISP_H): Add inttypes.h and stdin.h.
4589 (PROCESS_H): Add unistd.h.
4591 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4593 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4594 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4596 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4598 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4600 * term.c (vfatal): Remove stray call to va_end.
4601 It's not needed and the C Standard doesn't allow it here anyway.
4603 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4604 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4606 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4609 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4611 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4613 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4615 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4617 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4619 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4620 * charset.c (Fdefine_charset_internal): Don't initialize
4621 charset.code_space[15]. The value was garbage, on hosts with
4622 32-bit int (Bug#8600).
4624 * lread.c (read_integer): Be more consistent with string-to-number.
4625 Use string_to_number to do the actual conversion; this avoids
4626 rounding errors and fixes some other screwups. Without this fix,
4627 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4628 (digit_to_number): Move earlier, for benefit of read_integer.
4629 Return -1 if the digit is out of range for the base, -2 if it is
4630 not a digit in any supported base. (Bug#8602)
4632 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4634 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4635 to match comment at start of function. This also removes a
4636 GCC warning about overflow in a 32+64-bit port.
4638 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4640 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4641 Reported by Stefan Monnier in
4642 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4643 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4644 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4646 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4647 (EMACS_UINTPTR): Likewise, with uintptr_t.
4649 * lisp.h: Prefer 64-bit EMACS_INT if available.
4650 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4651 on 32-bit hosts that have 64-bit int, so that they can access
4653 However, temporarily disable this change unless the temporary
4654 symbol WIDE_EMACS_INT is defined.
4656 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4658 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4659 This removes an assumption that EMACS_INT and long are the same
4660 width as pointers. The assumption is true for Emacs porting targets
4661 now, but we want to make other targets possible.
4662 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4663 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4664 In the rest of the code, change types of integers that hold casted
4665 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4666 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4667 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4668 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4669 No need to cast type when ORing.
4670 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4671 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4672 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4673 assume EMACS_INT is the same width as char *.
4674 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4675 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4676 Remove no-longer-needed casts.
4677 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4678 (xg_tool_bar_help_callback, xg_make_tool_item):
4679 Use EMACS_INTPTR to hold an integer
4680 that will be cast to void *; this can avoid a GCC warning
4681 if EMACS_INT is not the same width as void *.
4682 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4683 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4684 (current_message_1, set_message_1):
4685 Use a local to convert to proper width without a cast.
4686 * xmenu.c (dialog_selection_callback): Likewise.
4688 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4689 Also, don't assume VALBITS / RAND_BITS is less than 5,
4690 and don't rely on undefined behavior when shifting a 1 left into
4692 * lisp.h (get_random): Change signature to match.
4694 * lread.c (hash_string): Use size_t, not int, for hash computation.
4695 Normally we prefer signed values; but hashing is special, because
4696 it's better to use unsigned division on hash table sizes so that
4697 the remainder is nonnegative. Also, size_t is the natural width
4698 for hashing into memory. The previous code used 'int', which doesn't
4699 retain enough info to hash well into very large tables.
4700 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4702 * dbusbind.c: Don't possibly lose pointer info when converting.
4703 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4704 Use XPNTR rather than XHASH, so that the high-order bits of
4705 the pointer aren't lost when converting through void *.
4707 * eval.c (Fautoload): Don't double-shift a pointer.
4709 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4711 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4713 * gnutls.c (DEF_GNUTLS_FN):
4714 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4716 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4718 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4721 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4723 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4724 New version that can reserve upto 2GB of heap space.
4726 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4728 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4730 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4732 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4733 `gnutls_certificate_set_x509_key_file'.
4735 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4737 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4738 Update dependencies.
4740 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4742 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4743 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4744 Remove unused parameter `fildes'.
4745 * process.c (read_process_output, send_process): Don't pass it.
4747 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4749 Fix previous change: the library cache is defined in w32.c.
4750 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4751 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4753 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4755 Implement dynamic loading of GnuTLS on Windows.
4757 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4758 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4759 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4762 * gnutls.c (Qgnutls_dll): Define.
4763 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4764 (gnutls_*): Declare function pointers.
4765 (init_gnutls_functions): New function to initialize function pointers.
4766 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4767 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4768 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4769 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4770 (emacs_gnutls_write, emacs_gnutls_read)
4771 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4772 (Fgnutls_available_p): New function.
4773 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4774 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4775 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4777 * image.c: Include w32.h.
4778 (Vimage_type_cache): Delete.
4779 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4780 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4781 (w32_delayed_load): Move to w32.c.
4783 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4785 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4786 (w32_delayed_load): Move from image.c. When loading a library, record
4787 its filename in the :loaded-from property of the library id.
4788 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4789 Initialize and staticpro them.
4790 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4792 * process.c: Include lisp.h before w32.h, not after.
4793 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4794 instead of gnutls_record_check_pending.
4796 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4798 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4800 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4801 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4804 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4806 * xterm.c (x_set_frame_alpha): Do not set property on anything
4807 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4809 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4811 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4813 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4815 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4816 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4817 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4818 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4819 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4820 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4821 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4822 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4823 (Qgnutls_bootprop_callbacks_verify): Make static.
4825 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4827 * callproc.c: Indentation fixup.
4829 * sysdep.c (wait_for_termination_1): Make static.
4830 (wait_for_termination, interruptible_wait_for_termination):
4831 Move after wait_for_termination_1.
4833 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4835 * sysdep.c (interruptible_wait_for_termination): New function
4836 which is like wait_for_termination, but allows keyboard
4839 * callproc.c (Fcall_process): Add (:file "file") as an option for
4841 (Fcall_process_region): Ditto.
4843 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4845 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4846 rather than `XVECTOR (FOO)->size'.
4848 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4849 inttypes.h, as a gnulib replacement is used if it not available in
4852 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4854 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4855 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4856 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4858 * coding.c (coding_alloc_by_realloc): Error out if destination
4859 will grow beyond MOST_POSITIVE_FIXNUM.
4860 (decode_coding_emacs_mule): Abort if there isn't enough place in
4861 charbuf for the composition carryover bytes. Reserve an extra
4862 space for up to 2 characters produced in a loop.
4863 (decode_coding_iso_2022): Abort if there isn't enough place in
4864 charbuf for the composition carryover bytes.
4866 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4868 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4869 aborting when %lld or %lll format is passed.
4870 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4871 %llo or %llx format is passed. (Bug#8545)
4873 * window.c (window_scroll_line_based): Use a marker instead of
4874 simple variables to record original value of point. (Bug#7952)
4876 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4877 produced by %s or %c overflows available buffer space. (Bug#8545)
4879 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4881 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4882 (SIZE_MAX): Move defn after all includes, as they might #define it.
4884 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4886 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4888 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4890 * keyboard.c (Qdelayed_warnings_hook): Define.
4891 (command_loop_1): Run `delayed-warnings-hook'
4892 if Vdelayed_warnings_list is non-nil.
4893 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4894 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4896 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4898 * doprnt.c (doprnt): Don't return value smaller than the buffer
4899 size if the message was truncated. (Bug#8545).
4901 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4903 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4904 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4906 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4908 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4910 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4912 * makefile.w32-in: Update dependencies.
4914 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4916 Improve `doprnt' and its usage. (Bug#8545)
4917 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4918 `format_end'. Remove support for %l as a conversion specifier.
4919 Don't use xrealloc. Improve diagnostics when the %l size modifier
4920 is used. Update the commentary.
4922 * eval.c (verror): Simplify calculation of size_t.
4924 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4927 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4929 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4932 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4934 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4935 This makes this file independent of the recent pseudovector change.
4937 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4939 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4941 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4942 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4943 Remove unused local.
4944 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4946 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4947 GCC 4.6.0 optimizes based on type-based alias analysis.
4948 For example, if b is of type struct buffer * and v of type struct
4949 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4950 != &v->size, and therefore "v->size = 1; b->size = 2; return
4951 v->size;" must therefore return 1. This assumption is incorrect
4952 for Emacs, since it type-puns struct Lisp_Vector * with many other
4953 types. To fix this problem, this patch adds a new type struct
4954 vectorlike_header that documents the constraints on layout of vectors
4955 and pseudovectors, and helps optimizing compilers not get fooled
4956 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4957 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4958 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4960 (XSETPVECTYPE): Rewrite in terms of new macro.
4961 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4962 This is a bit clearer, and further avoids the possibility of
4963 undesirable aliasing.
4964 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4965 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4966 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4967 since Lisp_Subr is a special case (no "next" field).
4968 (ASIZE): Now uses header.size rather than size.
4969 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4970 to avoid the hassle of writing XVECTOR (foo)->header.size.
4971 (struct vectorlike_header): New type.
4972 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4973 object, to help avoid aliasing.
4974 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4975 (SUBRP): Likewise, since Lisp_Subr is a special case.
4976 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4977 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4978 (struct Lisp_Hash_Table): Combine first two members into a single
4979 struct vectorlike_header member. All uses of "size" and "next" members
4980 changed to be "header.size" and "header.next".
4981 * buffer.h (struct buffer): Likewise.
4982 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4983 * frame.h (struct frame): Likewise.
4984 * process.h (struct Lisp_Process): Likewise.
4985 * termhooks.h (struct terminal): Likewise.
4986 * window.c (struct save_window_data, struct saved_window): Likewise.
4987 * window.h (struct window): Likewise.
4988 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4989 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4990 * buffer.c (init_buffer_once): Likewise.
4991 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4993 * process.c (Fformat_network_address): Use local var for size,
4996 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4998 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4999 * data.c (atof): Remove decl; no longer used or needed.
5000 (digit_to_number): Move to lread.c.
5001 (Fstring_to_number): Use new string_to_number function, to be
5002 consistent with how the Lisp reader treats infinities and NaNs.
5003 Do not assume that floating-point numbers represent EMACS_INT
5004 without losing information; this is not true on most 64-bit hosts.
5005 Avoid double-rounding errors, by insisting on integers when
5006 parsing non-base-10 numbers, as the documentation specifies.
5007 * lisp.h (string_to_number): New decl, replacing ...
5008 (isfloat_string): Remove.
5009 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5010 (read1): Do not accept +. and -. as integers; this
5011 appears to have been a coding error. Similarly, do not accept
5012 strings like +-1e0 as floating point numbers. Do not report
5013 overflow for integer overflows unless the base is not 10 which
5014 means we have no simple and reliable way to continue.
5015 Break out the floating-point parsing into a new
5016 function string_to_number, so that Fstring_to_number parses
5017 floating point numbers consistently with the Lisp reader.
5018 (digit_to_number): Move here from data.c. Make it static inline.
5019 (E_CHAR, EXP_INT): Remove, replacing with ...
5020 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5021 (string_to_number): New function, replacing isfloat_string.
5022 This function checks for valid syntax and produces the resulting
5023 Lisp float number too. Rework it so that string-to-number
5024 no longer mishandles examples like "1.0e+". Use strtoumax,
5025 so that overflow for non-base-10 numbers is reported only when
5026 there's no portable and simple way to convert to floating point.
5028 * textprop.c (set_text_properties_1): Rewrite for clarity,
5029 and to avoid GCC warning about integer overflow.
5031 * intervals.h (struct interval): Use EMACS_INT for members
5032 where EMACS_UINT might cause problems. See
5033 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5034 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5035 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5037 (offset_intervals): Tell GCC not to worry about length overflow
5038 when negating a negative length.
5040 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5041 (overrun_check_free): Likewise.
5043 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5044 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5047 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5048 (gnutls_make_error): Rename local to avoid shadowing.
5049 (gnutls_emacs_global_deinit): ifdef out; not used.
5050 (Fgnutls_boot): Use const for pointer to readonly storage.
5051 Comment out unused local. Fix pointer signedness problems.
5053 * lread.c (openp): Don't stuff size_t into an 'int'.
5054 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5055 about possible signed overflow.
5057 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5058 (GDK_KEY_g): Don't define if already defined.
5059 (xg_prepare_tooltip): Avoid pointer signedness problem.
5060 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5062 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5063 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5065 * xfns.c (Fx_window_property): Simplify a bit,
5066 to make a bit faster and to avoid GCC 4.6.0 warning.
5067 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5069 * fns.c (internal_equal): Don't assume size_t fits in int.
5071 * alloc.c (compact_small_strings): Tighten assertion a little.
5073 Replace pEd with more-general pI, and fix some printf arg casts.
5074 * lisp.h (pI): New macro, generalizing old pEd macro to other
5075 conversion specifiers. For example, use "...%"pI"d..." rather
5076 than "...%"pEd"...".
5077 (pEd): Remove. All uses replaced with similar uses of pI.
5078 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5079 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5080 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5081 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5082 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5083 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5084 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5086 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5087 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5088 * print.c (safe_debug_print, print_object): Likewise.
5089 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5091 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5092 avoiding the 0 flag, which is not portable.
5093 * process.c (Fmake_network_process): Use pI to avoid cast.
5094 * region-cache.c (pp_cache): Likewise.
5095 * xdisp.c (decode_mode_spec): Likewise.
5096 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5097 behavior on 64-bit hosts with printf arg.
5098 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5099 (x_stop_queuing_selection_requests): Likewise.
5100 (x_get_window_property): Don't truncate byte count to an 'int'
5103 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5104 here, since it parses constructs like leading '-' and spaces,
5105 which are not wanted; and it overflows with large numbers.
5106 Instead, simply match F[0-9]+, which is what is wanted anyway.
5108 * alloc.c: Remove unportable assumptions about struct layout.
5109 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5110 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5111 (allocate_vectorlike, make_pure_vector): Use the new macros,
5112 plus offsetof, to remove unportable assumptions about struct layout.
5113 These assumptions hold on all porting targets that I know of, but
5114 they are not guaranteed, they're easy to remove, and removing them
5115 makes further changes easier.
5117 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5118 This doesn't fix a bug but makes the code clearer.
5119 (string_overrun_cookie): Now const. Use initializers that
5120 don't formally overflow signed char, to avoid warnings.
5121 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5122 can cause Emacs to crash when string overrun checking is enabled.
5123 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5124 multiple of sizeof (EMACS_INT); it need not be, if
5125 alignof(EMACS_INT) < sizeof (EMACS_INT).
5126 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5128 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5130 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5132 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5134 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5135 supposed to be handshaking. (Bug#8556)
5136 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5138 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5140 * lisp.h (Qdebug): List symbol.
5141 * eval.c (Qdebug): Restore global linkage.
5142 * keyboard.c (debug-on-event): New variable.
5143 (handle_user_signal): Break into debugger when debug-on-event
5144 matches the current signal symbol.
5146 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5148 * alloc.c (check_sblock, check_string_bytes)
5149 (check_string_free_list): Convert to standard C.
5151 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5153 * w32.c (emacs_gnutls_push): Fix typo.
5155 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5157 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5158 "cast to pointer from integer of different size".
5160 Improve doprnt and its use in verror. (Bug#8545)
5161 * doprnt.c (doprnt): Document the set of format control sequences
5162 supported by the function. Use SAFE_ALLOCA instead of always
5165 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5166 is one byte too soon. Don't use xrealloc; instead xfree and
5169 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5171 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5174 * gnutls.c: Renamed global_initialized to
5175 gnutls_global_initialized. Added internals for the
5176 :verify-hostname-error, :verify-error, and :verify-flags
5177 parameters of `gnutls-boot' and documented those parameters in the
5178 docstring. Start callback support.
5179 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5180 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5181 on error. Return error code.
5182 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5183 (emacs_gnutls_read): Likewise.
5184 (Fgnutls_boot): Return handshake error code.
5185 (emacs_gnutls_handle_error): New function.
5186 (wsaerror_to_errno): Likewise.
5188 * w32.h (emacs_gnutls_pull): Add prototype.
5189 (emacs_gnutls_push): Likewise.
5191 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5192 (emacs_gnutls_push): Likewise.
5194 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5196 * process.c (wait_reading_process_output): Check if GnuTLS
5197 buffered some data internally if no FDs are set for TLS
5200 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5201 (LIBS): Link to USER_LIBS.
5202 ($(BLD)/gnutls.$(0)): New target.
5204 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5206 * xdisp.c (handle_single_display_spec): Rename the
5207 display_replaced_before_p argument into display_replaced_p, to
5208 make it consistent with the commentary. Fix typos in the
5211 * textprop.c (syms_of_textprop): Remove dead code.
5212 (copy_text_properties): Delete obsolete commentary about an
5213 interface that was deleted long ago. Fix typos in the description
5216 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5217 to changes in oldXMenu/XMenu.h from 2011-04-16.
5218 <menu_help_message, prev_menu_help_message>: Constify.
5219 (IT_menu_make_room): menu->help_text is now `const char **';
5222 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5223 to changes in oldXMenu/XMenu.h from 2011-04-16.
5224 (struct XMenu): Declare `help_text' `const char **'.
5226 * xfaces.c <Qunspecified>: Make extern again.
5228 * syntax.c: Include sys/types.h before including regex.h, as
5231 * doc.c (get_doc_string): Improve the format passed to `error'.
5233 * doprnt.c (doprnt): Improve commentary.
5235 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5237 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5240 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5241 changes in globals.h immediately force recompilation.
5242 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5243 $(CURDIR)/s/ms-w32.h.
5244 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5246 * character.c (Fchar_direction): Function deleted.
5247 (syms_of_character): Don't defsubr it.
5248 <char-direction-table>: Deleted.
5250 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5252 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5253 * doprnt.c: Include limits.h.
5254 (SIZE_MAX): New macro.
5255 (doprnt): Return a size_t value. 2nd arg is now size_t.
5256 Many local variables are now size_t instead of int or unsigned.
5257 Improve overflow protection. Support `l' modifier for integer
5258 conversions. Support %l conversion. Don't assume an EMACS_INT
5259 argument for integer conversions and for %c.
5261 * lisp.h (doprnt): Restore prototype.
5263 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5266 * Makefile.in (base_obj): Add back doprnt.o.
5268 * deps.mk (doprnt.o): Add back prerequisites.
5269 (callint.o): Depend on character.h.
5271 * eval.c (internal_lisp_condition_case): Include the handler
5272 representation in the error message.
5273 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5274 when breaking from the loop.
5276 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5278 * callint.c (Fcall_interactively): When displaying error message
5279 about invalid control letter, pass the character's codepoint, not
5280 a pointer to its multibyte form. Improve display of the character
5281 in octal and display also its hex code.
5283 * character.c (char_string): Use %x to display the (unsigned)
5284 codepoint of an invalid character, to avoid displaying a bogus
5287 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5288 `error', not SYMBOL_NAME itself.
5290 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5291 character arguments to `error'.
5293 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5294 to `error' in error message about FINAL_CHAR argument. Make sure
5295 FINAL_CHAR is a character, and use %c when it is passed as
5296 argument to `error'.
5298 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5300 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5302 * w32.c: Include <time.h>.
5303 (sys_localtime): New function.
5305 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5307 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5309 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5311 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5313 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5316 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5318 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5319 gl_state.e_property when gl_state.object is Qt.
5321 * insdel.c (make_gap_larger): Remove limitation of buffer size
5324 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5326 * xdisp.c (lookup_glyphless_char_display)
5327 (produce_glyphless_glyph): Handle cons cell entry in
5328 glyphless-char-display.
5329 (Vglyphless_char_display): Document it.
5331 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5332 glyphless-char-display.
5334 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5336 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5338 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5340 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5341 definition for no-X builds.
5343 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5345 Static checks with GCC 4.6.0 and non-default toolkits.
5347 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5349 * process.c (keyboard_bit_set): Define only if SIGIO.
5350 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5351 (send_process): Repair possible setjmp clobbering.
5353 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5355 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5357 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5359 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5360 Define only if needed.
5362 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5363 by pacifying GCC about it. Maybe it's time to retire it?
5364 * xfaces.c (USG, __TIMEVAL__): Likewise.
5366 * dispextern.h (struct redisplay_interface): Rename param
5368 * termhooks.h (struct terminal): Likewise.
5369 * xterm.c (xembed_send_message): Likewise.
5371 * insdel.c (make_gap_smaller): Define only if
5372 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5374 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5377 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5378 so that we aren't warned about unused symbols.
5380 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5382 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5384 * xfns.c (x_real_positions): Mark locals as initialized.
5386 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5388 * xterm.c: Fix problems found by static analysis with other toolkits.
5389 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5390 (x_dispatch_event): Declare static if USE_GTK, and
5391 define if USE_GTK || USE_X_TOOLKIT.
5392 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5393 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5394 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5395 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5397 * xmenu.c (menu_help_callback): Pointer type fixes.
5398 Use const pointers when pointing at readonly data. Avoid pointer
5400 (FALSE): Remove unused macro.
5401 (update_frame_menubar): Remove unused decl.
5403 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5405 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5406 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5407 (single_menu_item): Rename local to avoid shadowing.
5409 * keyboard.c (make_lispy_event): Remove unused local var.
5411 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5412 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5414 * bitmaps: Change bitmaps from unsigned char back to the X11
5415 compatible char. Avoid the old compiler warnings about
5416 out-of-range initializers by using, for example, '\xab' rather
5419 * xgselect.c (xgselect_initialize): Check vs interface
5420 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5422 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5424 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5425 to read-only memory.
5427 * fns.c (vector): Remove; this old hack is no longer needed.
5429 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5431 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5433 * xrdb.c (x_load_resources): Omit unused local.
5435 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5436 (x_window): Rename locals to avoid shadowing.
5437 (USG): Use the kludged USG macro, to pacify gcc.
5439 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5440 (x_term_init): Remove local to avoid shadowing.
5442 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5444 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5445 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5447 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5449 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5451 Fix regex.c, syntax.c and friends for buffers > 2GB.
5452 * syntax.h (struct gl_state_s): Declare character position members
5455 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5457 * textprop.c (verify_interval_modification, interval_of):
5458 Declare arguments EMACS_INT.
5460 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5463 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5465 * indent.c (Fvertical_motion): Local variable it_start is now
5468 * regex.c (re_match, re_match_2, re_match_2_internal)
5469 (bcmp_translate, regcomp, regexec, print_double_string)
5470 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5471 (re_compile_pattern, re_exec): Declare arguments and local
5472 variables `size_t' and `ssize_t' and return values `regoff_t', as
5474 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5475 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5476 <compile_stack_type>: `size' and `avail' are now `size_t'.
5478 * regex.h <regoff_t>: Use ssize_t, not int.
5479 (re_search, re_search_2, re_match, re_match_2): Arguments that
5480 specify buffer/string position and length are now ssize_t and
5481 size_t. Return type is regoff_t.
5483 2011-04-16 Ben Key <bkey76@gmail.com>
5485 * nsfont.m: Fixed bugs in ns_get_family and
5486 ns_descriptor_to_entity that were caused by using free to
5487 deallocate memory blocks that were allocated by xmalloc (via
5488 xstrdup). This caused Emacs to crash when compiled with
5489 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5490 --enable-checking=xmallocoverrun). xfree is now used to
5491 deallocate these memory blocks.
5493 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5495 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5497 emacs_write: Accept and return EMACS_INT for sizes.
5498 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5500 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5501 Accept and return EMACS_INT.
5502 (emacs_gnutls_write): Return the number of bytes written on
5504 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5505 (emacs_read, emacs_write): Remove check for negative size, as the
5506 Emacs source code has been audited now.
5507 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5508 (emacs_read, emacs_write): Use it.
5509 * process.c (send_process): Adjust to the new signatures of
5510 emacs_write and emacs_gnutls_write. Do not attempt to store
5511 a byte offset into an 'int'; it might overflow.
5512 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5514 * sound.c: Don't assume sizes fit in 'int'.
5515 (struct sound_device.period_size, alsa_period_size):
5516 Return EMACS_INT, not int.
5517 (struct sound_device.write, vox_write, alsa_write):
5518 Accept EMACS_INT, not int.
5519 (wav_play, au_play): Use EMACS_INT to store sizes and to
5520 record read return values.
5522 2011-04-15 Ben Key <bkey76@gmail.com>
5524 * keyboard.c (Qundefined): Don't declare static since it is used
5526 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5527 static since they are used in nsfont.m.
5529 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5531 * process.c (Qprocessp): Don't declare static.
5532 * lisp.h (Qprocessp): Declare again.
5534 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5536 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5538 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5540 Improve C-level modularity by making more things 'static'.
5542 Don't publish debugger-only interfaces to other modules.
5543 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5544 (verify_bytepos, count_markers): Move decls to the only modules
5546 * region-cache.h (pp_cache): Likewise.
5547 * window.h (check_all_windows): Likewise.
5548 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5550 * sysdep.c (croak): Now static, if
5551 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5552 * syssignal.h (croak): Declare only if not static.
5554 * alloc.c (refill_memory_reserve): Now static if
5555 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5556 * lisp.h (refill_memory_reserve): Declare only if not static.
5558 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5559 Define only if USE_LUCID.
5561 * xrdb.c (x_customization_string, x_rm_string): Now static.
5563 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5564 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5566 * xdisp.c (draw_row_with_mouse_face): Now static.
5567 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5569 * window.h (check_all_windows): Mark externally visible.
5571 * window.c (window_deletion_count): Now static.
5573 * undo.c: Make symbols static if they're not exported.
5574 (last_undo_buffer, last_boundary_position, pending_boundary):
5577 * textprop.c (interval_insert_behind_hooks): Now static.
5578 (interval_insert_in_front_hooks): Likewise.
5580 * term.c: Make symbols static if they're not exported.
5581 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5582 (max_frame_lines, tty_set_terminal_modes):
5583 (tty_reset_terminal_modes, tty_turn_off_highlight):
5584 (get_tty_terminal): Now static.
5585 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5586 * termhooks.h (term_mouse_moveto): Do not declare if
5588 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5589 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5591 * sysdep.c: Make symbols static if they're not exported.
5592 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5594 (sigprocmask_set, full_mask): Remove; unused.
5595 (wait_debugging): Mark as visible.
5596 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5597 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5599 * syntax.c (syntax_temp): Define only if !__GNUC__.
5601 * sound.c (current_sound_device, current_sound): Now static.
5603 * search.c (searchbufs, searchbuf_head): Now static.
5605 * scroll.c (scroll_cost): Remove; unused.
5606 * dispextern.h (scroll_cost): Remove decl.
5608 * region-cache.h (pp_cache): Mark as externally visible.
5610 * process.c: Make symbols static if they're not exported.
5611 (process_tick, update_tick, create_process, chan_process):
5612 (Vprocess_alist, proc_buffered_char, datagram_access):
5613 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5614 (deactivate_process): Mark defn as static, as well as decl.
5615 * lisp.h (create_process): Remove decl.
5616 * process.h (chan_process, Vprocess_alist): Remove decls.
5618 * print.c: Make symbols static if they're not exported.
5619 (print_depth, new_backquote_output, being_printed, print_buffer):
5620 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5621 (print_interval, print_number_index, initial_stderr_stream):
5623 * lisp.h (Fprinc): Remove decl.
5624 (debug_output_compilation_hack): Mark as externally visible.
5626 * sysdep.c (croak): Move decl from here to syssignal.h.
5627 * syssignal.h (croak): Put it here, so the API can be checked when
5628 'croak' is called from dissociate_if_controlling_tty.
5630 * minibuf.c: Make symbols static if they're not exported.
5631 (minibuf_save_list, choose_minibuf_frame): Now static.
5632 * lisp.h (choose_minibuf_frame): Remove decl.
5634 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5636 * lread.c: Make symbols static if they're not exported.
5637 (read_objects, initial_obarray, oblookup_last_bucket_number):
5639 (make_symbol): Remove; unused.
5640 * lisp.h (initial_obarray, make_symbol): Remove decls.
5642 * keyboard.c: Make symbols static if they're not exported.
5643 (single_kboard, recent_keys_index, total_keys, recent_keys):
5644 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5645 (this_single_command_key_start, echoing, last_auto_save):
5646 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5647 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5648 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5649 (Vlispy_mouse_stem, double_click_count):
5651 (force_auto_save_soon): Define only if SIGDANGER.
5652 (ignore_mouse_drag_p): Now static if
5653 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5654 (print_help): Remove; unused.
5655 (stop_character, last_timer_event): Mark as externally visible.
5656 * keyboard.h (ignore_mouse_drag_p): Declare only if
5657 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5658 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5659 * lisp.h (echoing): Remove decl.
5660 (force_auto_save_soon): Declare only if SIGDANGER.
5661 * xdisp.c (redisplay_window): Simplify code, to make it more
5662 obvious that ignore_mouse_drag_p is not accessed if !defined
5663 USE_GTK && !defined HAVE_NS.
5665 * intervals.c: Make symbols static if they're not exported.
5666 (merge_properties_sticky, merge_interval_right, delete_interval):
5668 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5670 * insdel.c: Make symbols static if they're not exported.
5671 However, leave prepare_to_modify_buffer alone. It's never
5672 called from outside this function, but that appears to be a bug.
5673 (combine_after_change_list, combine_after_change_buffer):
5674 (adjust_after_replace, signal_before_change): Now static.
5675 (adjust_after_replace_noundo): Remove; unused.
5676 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5677 (signal_before_change): Remove decls.
5679 * indent.c (val_compute_motion, val_vmotion): Now static.
5681 * image.c: Make symbols static if they're not exported.
5682 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5684 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5685 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5687 * fringe.c (standard_bitmaps): Now static.
5688 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5690 * frame.c: Make symbols static if they're not exported.
5691 (x_report_frame_params, make_terminal_frame): Now static.
5692 (get_frame_param): Now static, unless HAVE_NS.
5693 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5694 (x_get_resource_string): Remove; not used.
5695 * frame.h (make_terminal_frame, x_report_frame_params):
5696 (x_get_resource_string); Remove decls.
5697 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5698 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5700 * font.c, fontset.c: Make symbols static if they're not exported.
5701 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5702 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5703 * font.c (font_close_object): Now static.
5704 * font.h (font_close_object): Remove.
5705 * fontset.c (FONTSET_OBJLIST): Remove.
5706 (free_realized_fontset) #if-0 the body, which does nothing.
5707 (face_suitable_for_char_p): #if-0, as it's never called.
5708 * fontset.h (face_suitable_for_char_p): Remove decl.
5709 * xfaces.c (face_at_string_position):
5710 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5711 since 0 is always ASCII.
5713 * fns.c (weak_hash_tables): Now static.
5715 * fileio.c: Make symbols static if they're not exported.
5716 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5717 (Vwrite_region_annotation_buffers): Now static.
5719 * eval.c: Make symbols static if they're not exported.
5720 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5721 * lisp.h (backtrace_list): Remove decl.
5723 * emacs.c: Make symbols static if they're not exported.
5724 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5725 (fatal_error_code, fatal_error_signal_hook, standard_args):
5727 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5728 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5729 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5730 * lisp.h (fatal_error_signal_hook): Remove decl.
5731 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5733 * editfns.c: Move a (normally-unused) function to its only use.
5734 * editfns.c, lisp.h (get_operating_system_release): Remove.
5735 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5736 worth the hassle of breaking this out.
5738 * xterm.c: Make symbols static if they're not exported.
5739 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5740 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5741 (x_destroy_window, x_delete_display):
5743 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5744 (x_mouse_leave): Remove; unused.
5745 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5746 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5747 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5749 (x_mouse_leave): Declare only if WINDOWSNT.
5750 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5751 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5754 * ftxfont.c: Make symbols static if they're not exported.
5755 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5757 * font.h (ftxfont_driver): Likewise.
5759 * xfns.c: Make symbols static if they're not exported.
5760 (x_last_font_name, x_display_info_for_name):
5761 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5762 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5763 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5764 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5765 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5766 (last_show_tip_args): Now static.
5767 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5768 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5769 (x_screen_planes): Remove; unused.
5770 * dispextern.h (x_screen_planes): Remove decl.
5772 * dispnew.c: Make symbols static if they're not exported.
5773 * dispextern.h (redraw_garbaged_frames, scrolling):
5774 (increment_row_positions): Remove.
5775 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5776 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5778 (redraw_garbaged_frames): Remove; unused.
5780 * xfaces.c: Make symbols static if they're not exported.
5781 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5783 * xterm.h (defined_color): Remove decls.
5784 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5785 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5786 (menu_face_changed_default, defined_color, free_realized_face):
5787 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5788 (ascii_face_of_lisp_face): Remove; unused.
5790 * xdisp.c: Make symbols static if they're not exported.
5791 * dispextern.h (scratch_glyph_row, window_box_edges):
5792 (glyph_to_pixel_coords, set_cursor_from_row):
5793 (get_next_display_element, set_iterator_to_next):
5794 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5795 (show_mouse_face): Remove decls
5796 * frame.h (message_buf_print): Likewise.
5797 * lisp.h (pop_message, set_message, check_point_in_composition):
5799 * xterm.h (set_vertical_scroll_bar): Likewise.
5800 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5801 (message_buf_print, scratch_glyph_row, displayed_buffer):
5802 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5803 (get_next_display_element, show_mouse_face, window_box_edges):
5804 (frame_to_window_pixel_xy, check_point_in_composition):
5805 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5806 (glyph_to_pixel_coords): Remove; unused.
5808 * dired.c (file_name_completion): Now static.
5810 * dbusbind.c (xd_in_read_queued_messages): Now static.
5812 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5813 * data.c (circular_list_error): Remove.
5815 * commands.h (last_point_position, last_point_position_buffer):
5816 (last_point_position_window): Remove decls.
5817 * keyboard.c: Make these variables static.
5819 * coding.h (coding, code_convert_region, encode_coding_gap):
5821 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5822 (iso_code_class, detect_coding, code_convert_region): Now static.
5823 (encode_coding_gap): Remove; unused.
5825 * chartab.c (chartab_chars, chartab_bits): Now static.
5827 * charset.h (charset_iso_8859_1): Remove decl.
5828 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5831 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5832 * ccl.c (Vccl_program_table): Now static.
5833 (check_ccl_update): Remove; unused.
5835 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5836 * category.h: ... from here.
5837 * category.c (check_category_table, set_category_set): Now static.
5839 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5840 * lisp.h: Remove these decls.
5842 * buffer.c (buffer_count): Remove unused var.
5844 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5845 so that it's not optimized away.
5846 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5847 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5848 exported only to the debugger.
5850 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5851 * atimer.h (run_all_atimers): Remove; not exported.
5853 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5854 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5855 was inaccessible from Lisp.
5856 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5857 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5859 alloc.c: Import and export fewer symbols, and remove unused items.
5860 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5862 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5863 it's not optimized away by whole-program optimization.
5864 (message_enable_multibyte, free_misc): Remove.
5865 (catchlist, handlerlist, mark_backtrace):
5866 Declare only if BYTE_MARK_STACK.
5867 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5868 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5869 (message_enable_multibyte): Remove decl.
5870 (free_misc, interval_free_list, float_block, float_block_index):
5871 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5872 (cons_free_list, last_marked_index):
5874 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5875 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5876 (mark_backtrace): Define only if BYTE_MARK_STACK.
5877 * xdisp.c (message_enable_multibyte): Now static.
5879 Declare Lisp_Object Q* variables to be 'static' if not exported.
5880 This makes it easier for human readers (and static analyzers)
5881 to see whether these variables are used from other modules.
5882 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5883 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5884 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5885 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5886 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5887 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5888 * xmenu.c, xselect.c:
5889 Declare Q* vars static if they are not used in other modules.
5890 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5891 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5892 Remove decls of unexported vars.
5893 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5895 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5897 Make Emacs functions such as Fatom 'static' by default.
5898 This makes it easier for human readers (and static analyzers)
5899 to see whether these functions can be called from other modules.
5900 DEFUN now defines a static function. To make the function external
5901 so that it can be used in other C modules, use the new macro DEFUE.
5902 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5903 (Finit_image_library):
5904 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5905 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5906 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5907 Remove decls, since these functions are now static.
5908 (Funintern, Fget_internal_run_time): New decls, since these functions
5909 were already external.
5911 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5912 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5913 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5914 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5915 * keyboard.c, keymap.c, lread.c:
5916 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5917 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5918 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5919 Mark functions with DEFUE instead of DEFUN,
5920 if they are used in other modules.
5921 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5922 decls for now-static functions.
5923 * buffer.h (Fdelete_overlay): Remove decl.
5924 * callproc.c (Fgetenv_internal): Mark as internal.
5925 * composite.c (Fremove_list_of_text_properties): Remove decl.
5926 (Fcomposition_get_gstring): New forward static decl.
5927 * composite.h (Fcomposite_get_gstring): Remove decl.
5928 * dired.c (Ffile_attributes): New forward static decl.
5929 * doc.c (Fdocumntation_property): New forward static decl.
5930 * eval.c (Ffetch_bytecode): New forward static decl.
5931 (Funintern): Remove extern decl; now in .h file where it belongs.
5932 * fileio.c (Fmake_symbolic_link): New forward static decl.
5933 * image.c (Finit_image_library): New forward static decl.
5934 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5935 * intervals.h (Fprevious_property_change):
5936 (Fremove_list_of_text_properties): Remove decls.
5937 * keyboard.c (Fthis_command_keys): Remove decl.
5938 (Fcommand_execute): New forward static decl.
5939 * keymap.c (Flookup_key): New forward static decl.
5940 (Fcopy_keymap): Now static.
5941 * keymap.h (Flookup_key): Remove decl.
5942 * process.c (Fget_process): New forward static decl.
5943 (Fprocess_datagram_address): Mark as internal.
5944 * syntax.c (Fsyntax_table_p): New forward static decl.
5945 (skip_chars): Remove duplicate decl.
5946 * textprop.c (Fprevious_property_change): New forward static decl.
5947 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5949 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5950 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5952 * editfns.c (Fformat): Remove unreachable code.
5954 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5956 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5959 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5961 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5962 when at ZV. (Bug#8487)
5964 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5966 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5968 * keyboard.c (parse_tool_bar_item): Likewise.
5969 * sound.c (sound_cleanup, alsa_close): Likewise.
5970 * termcap.c (tgetent): Likewise.
5971 * xfns.c (x_default_font_parameter): Likewise.
5972 * xsettings.c (read_and_apply_settings): Likewise.
5974 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5975 (overrun_check_free): Protoize.
5977 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5979 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5980 since callers should never pass a negative size.
5981 Change the signature to match that of plain 'read' and 'write'; see
5982 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5983 * lisp.h: Update prototypes of emacs_write and emacs_read.
5985 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5987 * xdisp.c (redisplay_window): Don't try to determine the character
5988 position of the scroll margin if the window start point w->startp
5989 is outside the buffer's accessible region. (Bug#8468)
5991 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5993 Fix write-region and its subroutines for buffers > 2GB.
5994 * fileio.c (a_write, e_write): Modify declaration of arguments and
5995 local variables to support buffers larger than 2GB.
5996 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5998 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5999 argument, local variables, and return value.
6001 * lisp.h: Update prototypes of emacs_write and emacs_read.
6003 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6005 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6007 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6009 Fix more problems found by GCC 4.6.0's static checks.
6011 * xdisp.c (vmessage): Use a better test for character truncation.
6013 * charset.c (load_charset_map): <, not <=, for optimization,
6014 and to avoid potential problems with integer overflow.
6015 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6016 * casetab.c (set_identity, shuffle): Likewise.
6017 * editfns.c (Fformat): Likewise.
6018 * syntax.c (skip_chars): Likewise.
6020 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6021 This also lets GCC 4.6.0 generate slightly better loop code.
6023 * callint.c (Fcall_interactively): <, not <=, for optimization.
6024 (Fcall_interactively): Count the number of arguments produced,
6025 not the number of arguments given. This is simpler and lets GCC
6026 4.6.0 generate slightly better code.
6028 * ftfont.c: Distingish more carefully between FcChar8 and char.
6029 The previous code passed unsigned char * to a functions like
6030 strlen and xstrcasecmp that expect char *, which does not
6031 conform to the C standard.
6032 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6033 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6034 char * when the C standard requires it.
6036 * keyboard.c (read_char): Remove unused var.
6038 * eval.c: Port to Windows vsnprintf (Bug#8435).
6040 (SIZE_MAX): Define if the headers do not.
6041 (verror): Do not give up if vsnprintf returns a negative count.
6042 Instead, grow the buffer. This ports to Windows vsnprintf, which
6043 does not conform to C99. Problem reported by Eli Zaretskii.
6044 Also, simplify the allocation scheme, by avoiding the need for
6045 calling realloc, and removing the ALLOCATED variable.
6047 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6049 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6050 But keep the doprint source code for now, as we might revamp it
6051 and use it again (Bug#8435).
6052 * lisp.h (doprnt): Remove.
6053 * Makefile.in (base_obj): Remove doprnt.o.
6054 * deps.mk (doprnt.o): Remove.
6056 error: Print 32- and 64-bit integers portably (Bug#8435).
6057 Without this change, on typical 64-bit hosts error ("...%d...", N)
6058 was used to print both 32- and 64-bit integers N, which relied on
6060 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6062 * lisp.h (error, verror): Mark as printf-like functions.
6063 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6064 Report overflow in size calculations when allocating printf buffer.
6065 Do not truncate output string at its first null byte.
6066 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6067 Truncate the output at a character boundary, since vsnprintf does not
6069 * charset.c (check_iso_charset_parameter): Convert internal
6070 character to string before calling 'error', since %c now has the
6072 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6073 overflow when computing char to be passed to 'error'. Do not
6074 pass Lisp_Object to 'error'; pass the integer instead.
6075 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6076 formatted with plain %d.
6078 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6080 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6082 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6084 * xterm.c (x_catch_errors): Remove duplicate declaration.
6086 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6088 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6090 2011-04-10 Jim Meyering <meyering@redhat.com>
6092 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6093 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6094 return ssize_t not "int", and use size_t as the buffer length.
6095 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6096 * gnutls.h: Update declarations.
6097 * process.c (read_process_output): Use ssize_t, to match.
6098 (send_process): Likewise.
6100 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6102 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6104 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6106 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6107 Use unsigned char, to match FcChar8 type definition.
6109 * xterm.c (handle_one_xevent):
6110 * xmenu.c (create_and_show_popup_menu):
6111 * xselect.c (x_decline_selection_request)
6112 (x_reply_selection_request): Avoid type-punned deref of X events.
6114 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6116 Fix some uses of `int' instead of EMACS_INT.
6117 * search.c (string_match_1, fast_string_match)
6118 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6119 (scan_buffer, find_next_newline_no_quit)
6120 (find_before_next_newline, search_command, Freplace_match)
6121 (Fmatch_data): Make some `int' variables be EMACS_INT.
6123 * xdisp.c (display_count_lines): 3rd argument and return value now
6124 EMACS_INT. All callers changed.
6125 (pint2hrstr): Last argument is now EMACS_INT.
6127 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6128 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6129 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6130 (decode_coding_utf_16, decode_coding_emacs_mule)
6131 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6132 (decode_coding_ccl, decode_coding_charset)
6133 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6134 (decode_coding_iso_2022, decode_coding_emacs_mule)
6135 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6136 <char_offset, last_offset>: Declare EMACS_INT.
6137 (encode_coding_utf_8, encode_coding_utf_16)
6138 (encode_coding_emacs_mule, encode_invocation_designation)
6139 (encode_designation_at_bol, encode_coding_iso_2022)
6140 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6141 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6143 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6144 (encode_invocation_designation): Last argument P_NCHARS is now
6146 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6147 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6149 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6152 * ccl.c (Fccl_execute_on_string): Declare some variables
6155 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6157 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6159 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6161 * process.c (Fformat_network_address): Doc fix.
6163 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6165 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6167 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6169 * keyboard.c (read_char): Call Lisp function help-form-show,
6170 instead of using internal_with_output_to_temp_buffer.
6171 (Qhelp_form_show): New var.
6172 (syms_of_keyboard): Use DEFSYM macro.
6174 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6176 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6178 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6180 * process.c (Flist_processes): Remove to Lisp.
6181 (list_processes_1): Delete.
6183 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6185 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6187 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6189 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6191 Fix more problems found by GCC 4.6.0's static checks.
6193 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6195 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6197 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6199 * xdisp.c (vmessage): Mark as a printf-like function.
6201 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6203 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6205 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6206 printf-like functions.
6207 (tiff_load): Add casts to remove these marks before passing them
6208 to system-supplied API.
6210 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6212 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6213 This avoids several warnings with gcc -Wstrict-overflow.
6214 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6215 directly, rather than having caller test rule sign. This avoids
6216 some unnecessary tests.
6217 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6218 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6219 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6221 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6222 (xfont_open): Avoid unnecessary tests.
6224 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6226 * composite.h, composite.c (composition_gstring_put_cache):
6227 Use EMACS_INT, not int, for length.
6229 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6230 breaking out part of COMPOSITION_DECODE_RULE.
6231 (COMPOSITION_DECODE_RULE): Use it.
6232 * composite.c (get_composition_id): Remove unused local vars,
6233 by using the new macro.
6235 * textprop.c (set_text_properties_1): Change while to do-while,
6236 since the condition is always true at first.
6238 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6239 (interval_deletion_adjustment): Return unsigned value.
6242 * process.c (list_processes_1, create_pty, read_process_output):
6243 (exec_sentinel): Remove vars that were set but not used.
6244 (create_pty): Remove unnecessary "volatile"s.
6245 (Fnetwork_interface_info): Avoid possibility of int overflow.
6246 (read_process_output): Do adaptive read buffering even if carryover.
6247 (read_process_output): Simplify nbytes computation if buffered.
6249 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6251 * syntax.c (scan_words): Remove var that was set but not used.
6252 (update_syntax_table): Use unsigned instead of int.
6254 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6255 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6256 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6258 * print.c (print_error_message): Avoid int overflow.
6260 * font.c (font_list_entities): Redo for clarity,
6261 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6263 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6264 (font_score): Avoid potential overflow in diff calculation.
6266 * fns.c (substring_both): Remove var that is set but not used.
6267 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6269 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6271 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6272 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6273 can always succeed if overflow has undefined behavior.
6275 * search.c (boyer_moore, wordify): Remove vars set but not used.
6276 (wordify): Omit three unnecessary tests.
6278 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6279 All callers changed. This avoids the need for an unused var.
6281 * casefiddle.c (casify_region): Remove var that is set but not used.
6283 * dired.c (file_name_completion): Remove var that is set but not used.
6285 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6287 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6288 (Finsert_file_contents): Remove unnecessary code checking fd.
6290 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6291 Check for integer overflow on size calculations.
6293 * buffer.c (Fprevious_overlay_change): Remove var that is set
6296 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6297 Remove vars that are set but not used.
6298 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6299 (timer_check_2): Mark vars as initialized.
6301 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6303 * image.c (lookup_image): Remove var that is set but not used.
6304 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6306 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6307 that are set but not used.
6309 * xfns.c (make_invisible_cursor): Don't return garbage
6310 if XCreateBitmapFromData fails (Bug#8410).
6312 * xselect.c (x_get_local_selection, x_handle_property_notify):
6313 Remove vars that are set but not used.
6315 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6316 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6318 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6319 Remove var that is set but not used.
6320 (scroll_bar_windows_size): Now size_t, not int.
6321 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6324 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6325 (map_tty_color) [!defined MSDOS]: Likewise.
6327 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6329 * coding.c: Remove vars that are set but not used.
6330 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6331 All callers changed.
6332 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6333 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6334 (decode_coding_charset): Remove vars that are set but not used.
6336 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6337 that is set but not used.
6339 * print.c (print_object): Remove var that is set but not used.
6341 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6342 The gnulib version avoids calling malloc in the usual case,
6343 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6344 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6345 * filelock.c (current_lock_owner): Likewise.
6346 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6347 * sysdep.c: Include allocator.h, careadlinkat.h.
6348 (emacs_no_realloc_allocator): New static constant.
6349 (emacs_readlink): New function.
6350 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6351 ../lib/careadlinkat.h.
6353 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6355 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6356 first non-nil return value).
6358 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6360 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6361 if not defined (Bug#8403).
6363 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6365 * xdisp.c (display_count_lines): Remove parameter `start',
6366 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6367 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6368 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6369 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6370 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6371 and thereabouts. All callers changed.
6372 (get_per_char_metric): Remove parameter `f', unused since
6373 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6375 2011-04-02 Jim Meyering <meyering@redhat.com>
6377 do not dereference NULL upon failed strdup
6378 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6379 (ns_get_family): Likewise.
6381 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6383 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6385 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6387 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6390 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6392 Add lexical binding.
6394 * window.c (Ftemp_output_buffer_show): New fun.
6395 (Fsave_window_excursion):
6396 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6398 * lread.c (lisp_file_lexically_bound_p): New function.
6399 (Fload): Bind Qlexical_binding.
6400 (readevalloop): Remove `evalfun' arg.
6401 Bind Qinternal_interpreter_environment.
6402 (Feval_buffer): Bind Qlexical_binding.
6403 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6405 (syms_of_lread): Declare `lexical-binding'.
6407 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6409 * keyboard.c (eval_dyn): New fun.
6410 (menu_item_eval_property): Use it.
6412 * image.c (parse_image_spec): Use Ffunctionp.
6414 * fns.c (concat, mapcar1): Accept byte-code-functions.
6416 * eval.c (Fsetq): Handle lexical vars.
6417 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6418 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6419 (FletX, Flet): Obey lexical binding.
6420 (Fcommandp): Handle closures.
6421 (Feval): New `lexical' arg.
6422 (eval_sub): New function extracted from Feval. Use it almost
6423 everywhere where Feval was used. Look up vars in lexical env.
6425 (Ffunctionp): Move from subr.el.
6426 (Ffuncall): Handle closures.
6427 (apply_lambda): Remove `eval_flags'.
6428 (funcall_lambda): Handle closures and new byte-code-functions.
6429 (Fspecial_variable_p): New function.
6430 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6431 but without exporting it to Lisp.
6433 * doc.c (Fdocumentation, store_function_docstring):
6434 * data.c (Finteractive_form): Handle closures.
6436 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6439 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6441 (exec_byte_code): New function extracted from Fbyte_code to handle new
6442 calling convention for byte-code-functions. Add new byte-codes.
6444 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6446 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6448 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6450 * xdisp.c (redisplay_internal): Fix prototype.
6452 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6454 * xdisp.c (SCROLL_LIMIT): New macro.
6455 (try_scrolling): Use it when setting scroll_limit.
6456 Limit scrolling to 100 screen lines.
6457 (redisplay_window): Even when falling back on "recentering",
6458 position point in the window according to scroll-conservatively,
6459 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6461 (try_scrolling): When point is above the window, allow searching
6462 as far as scroll_max, or one screenful, to compute vertical
6463 distance from PT to the scroll margin position. This prevents
6464 try_scrolling from unnecessarily failing when
6465 scroll-conservatively is set to a value slightly larger than the
6466 window height. Clean up the case of PT below the margin at bottom
6467 of window: scroll_max can no longer be INT_MAX. When aggressive
6468 scrolling is in use, don't let point enter the opposite scroll
6469 margin as result of the scroll.
6470 (syms_of_xdisp) <scroll-conservatively>: Document the
6471 threshold of 100 lines for never-recentering scrolling.
6473 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6475 * dispextern.h (move_it_by_lines):
6476 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6477 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6478 (message_log_check_duplicate): Remove parameters `prev_bol' and
6479 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6480 (redisplay_internal): Remove parameter `preserve_echo_area',
6481 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6483 * indent.c (Fvertical_motion):
6484 * window.c (window_scroll_pixel_based, Frecenter):
6485 Don't pass `need_y_p' to `move_it_by_lines'.
6487 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6489 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6490 steal a few bits to be more compact.
6491 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6492 Remove unneeded casts.
6494 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6496 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6498 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6499 binding" message (bug#7967).
6501 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6503 Fix more problems found by GCC 4.6.0's static checks.
6505 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6506 Remove unused local var.
6508 * editfns.c (Fmessage_box): Remove unused local var.
6510 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6511 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6512 Omit unused local vars.
6513 * window.c (shrink_windows): Omit unused local var.
6514 * menu.c (digest_single_submenu): Omit unused local var.
6515 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6516 Omit unused local var.
6518 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6519 Don't assume string length fits in int.
6520 (keyremap_step, read_key_sequence): Use size_t for sizes.
6521 (read_key_sequence): Don't check last_real_key_start redundantly.
6523 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6524 instead of alloca (Bug#8344).
6526 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6527 (Fbacktrace_frame): Don't assume nframes fits in int.
6529 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6531 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6534 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6536 * cm.c (calccost): Turn while-do into do-while, for clarity.
6538 * keyboard.c (syms_of_keyboard): Use the same style as later
6539 in this function when indexing through an array. This also
6540 works around GCC bug 48267.
6542 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6544 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6546 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6547 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6549 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6550 This avoids undefined behavior on integer overflow, and is a bit
6551 more convenient anyway since it is compared to a size_t variable.
6553 Variadic C functions now count arguments with size_t, not int.
6554 This avoids an unnecessary limitation on 64-bit machines, which
6555 caused (substring ...) to crash on large vectors (Bug#8344).
6556 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6557 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6558 All variadic functions and their callers changed accordingly.
6559 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6560 * data.c (arith_driver, float_arith_driver): Likewise.
6561 * editfns.c (general_insert_function): Likewise.
6562 * eval.c (struct backtrace.nargs, interactive_p)
6563 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6564 (funcall_lambda, mark_backtrace): Likewise.
6565 * fns.c (concat): Likewise.
6566 * frame.c (x_set_frame_parameters): Likewise.
6567 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6568 0 if not found, not -1. All callers changed.
6570 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6571 (stack_copy_size): Now size_t, not int.
6572 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6574 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6576 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6577 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6578 All callers changed.
6580 * lisp.h (multibyte_char_to_unibyte):
6581 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6582 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6583 * character.h (CHAR_TO_BYTE8):
6584 * cmds.c (internal_self_insert):
6585 * editfns.c (general_insert_function):
6586 * keymap.c (push_key_description):
6587 * search.c (Freplace_match):
6588 * xdisp.c (message_dolog, set_message_1): All callers changed.
6590 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6592 * keyboard.c (safe_run_hook_funcall): New function.
6593 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6594 don't set the hook to nil, but remove the offending function instead.
6595 (Qcommand_hook_internal): Remove, unused.
6596 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6597 Vcommand_hook_internal.
6599 * eval.c (enum run_hooks_condition): Remove.
6600 (funcall_nil, funcall_not): New functions.
6601 (run_hook_with_args): Call each function through a `funcall' argument.
6602 Remove `cond' argument, now redundant.
6603 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6604 (Frun_hook_with_args_until_failure): Adjust accordingly.
6605 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6607 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6609 * dispextern.h (string_buffer_position): Remove declaration.
6611 * print.c (strout): Remove parameter `multibyte', unused since
6612 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6614 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6615 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6616 All callers changed.
6618 * w32.c (_wsa_errlist): Use braces for struct initializers.
6620 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6621 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6622 All callers changed.
6623 (string_buffer_position): Likewise. Also, make static (it's never
6624 used outside xdisp.c).
6625 (cursor_row_p): Remove parameter `w', unused since
6626 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6627 (decode_mode_spec): Remove parameter `precision', introduced during
6628 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6629 All callers changed.
6631 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6633 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6635 2011-03-27 Anders Lindgren <andlind@gmail.com>
6637 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6638 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6639 (ns_update_auto_hide_menu_bar): New functions.
6640 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6641 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6642 ns_constrain_all_frames.
6643 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6644 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6646 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6648 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6650 2011-03-27 Glenn Morris <rgm@gnu.org>
6652 * syssignal.h: Replace RETSIGTYPE with void.
6653 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6654 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6655 Replace SIGTYPE with void everywhere.
6656 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6657 * s/template.h (SIGTYPE): Remove commented out definition.
6659 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6661 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6662 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6664 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6666 * w32.c (read_unc_volume): Use parameter `henum', instead of
6667 global variable `wget_enum_handle'.
6669 * keymap.c (describe_vector): Remove parameters `indices' and
6670 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6671 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6673 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6675 * keyboard.c (timer_check): Remove parameter `do_it_now',
6676 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6677 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6678 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6680 * keyboard.c (read_char):
6681 * w32menu.c (w32_menu_display_help):
6682 * xmenu.c (show_help_event, menu_help_callback):
6683 Adjust calls to `show_help_echo'.
6685 * gtkutil.c (xg_maybe_add_timer):
6686 * keyboard.c (readable_events):
6687 * process.c (wait_reading_process_output):
6688 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6690 * insdel.c (adjust_markers_gap_motion):
6691 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6692 (gap_left, gap_right): Don't call it.
6694 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6696 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6697 incurred during fontification.
6699 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6701 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6702 (DEFVAR_PER_BUFFER): Don't pass it.
6704 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6705 (scrolling_window): Don't pass it.
6707 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6709 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6711 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6713 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6714 of variables specific to SELinux and computation of `encoded_absname'.
6716 * image.c (XPutPixel): Remove unused variable `height'.
6718 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6720 * unexw32.c (get_section_info): Remove unused variable `section'.
6722 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6723 (system_process_attributes): Remove unused variable `sess'.
6724 (sys_read): Remove unused variable `err'.
6726 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6727 (w32_wnd_proc): Remove unused variable `isdead'.
6728 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6729 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6730 (x_create_tip_frame): Remove unused variable `tem'.
6732 * w32inevt.c (w32_console_read_socket):
6733 Remove unused variable `no_events'.
6735 * w32term.c (x_draw_composite_glyph_string_foreground):
6736 Remove unused variable `width'.
6738 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6740 * w32term.c (x_set_glyph_string_clipping):
6741 Don't pass uninitialized region to CombineRgn.
6743 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6745 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6746 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6747 (Fx_close_connection): Remove unused variable `i'.
6749 * w32font.c (w32font_draw): Return number of glyphs.
6750 (w32font_open_internal): Remove unused variable `i'.
6751 (w32font_driver): Add missing initializer.
6753 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6754 (fill_in_menu): Remove unused variable `items_added'.
6756 * w32term.c (last_mouse_press_frame): Remove static global variable.
6757 (w32_clip_to_row): Remove unused variable `f'.
6758 (x_delete_terminal): Remove unused variable `i'.
6760 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6761 (NOTHING): Remove unused static global variable.
6762 (uniscribe_check_otf): Remove unused variable `table'.
6763 (uniscribe_font_driver): Add missing initializers.
6765 2011-03-23 Julien Danjou <julien@danjou.info>
6767 * term.c (Fsuspend_tty, Fresume_tty):
6768 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6769 * window.c (temp_output_buffer_show):
6770 * insdel.c (signal_before_change):
6771 * frame.c (Fhandle_switch_frame):
6772 * fileio.c (Fdo_auto_save):
6773 * emacs.c (Fkill_emacs):
6774 * editfns.c (save_excursion_restore):
6775 * cmds.c (internal_self_insert):
6776 * callint.c (Fcall_interactively):
6777 * buffer.c (Fkill_all_local_variables):
6778 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6780 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6781 unconditionnaly since it does the check itself.
6783 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6785 Fix more problems found by GCC 4.5.2's static checks.
6787 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6788 the first time through the loop, since we know p0 < p1 then.
6789 This also avoids a gcc -Wstrict-overflow warning.
6791 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6792 leading to a memory leak, possible in functions like
6793 load_charset_map_from_file that can allocate an unbounded number
6794 of objects (Bug#8318).
6796 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6797 that could (at least in theory) be that large.
6799 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6800 This is less likely to overflow, and avoids undefined behavior if
6801 overflow does occur. All callers changed. Use strtoul to scan
6802 for the unsigned long integer.
6803 (pint2hrstr): Simplify and tune code slightly.
6804 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6806 * scroll.c (do_scrolling): Work around GCC bug 48228.
6807 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6809 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6810 This also avoids a warning with gcc -Wstrict-overflow.
6811 (validate_x_resource_name): Simplify count usage.
6812 This also avoids a warning with gcc -Wstrict-overflow.
6814 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6817 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6819 * process.c (Fmake_network_process): Use socklen_t, not int,
6820 where POSIX says socklen_t is required in portable programs.
6821 This fixes a porting bug on hosts like 64-bit HP-UX, where
6822 socklen_t is wider than int (Bug#8277).
6823 (Fmake_network_process, server_accept_connection):
6824 (wait_reading_process_output, read_process_output):
6827 * process.c: Rename or move locals to avoid shadowing.
6828 (list_processes_1, Fmake_network_process):
6829 (read_process_output_error_handler, exec_sentinel_error_handler):
6830 Rename or move locals.
6831 (Fmake_network_process): Define label "retry_connect" only if needed.
6832 (Fnetwork_interface_info): Fix pointer signedness.
6833 (process_send_signal): Add cast to avoid pointer signedness problem.
6834 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6835 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6837 Make tparam.h and terminfo.c consistent.
6838 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6839 Include tparam.h instead, since it declares them.
6840 * cm.h (PC): Remove extern decl; tparam.h now does this.
6841 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6842 * terminfo.c: Include tparam.h, to check interfaces.
6843 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6844 (tparam): Adjust signature to match interface in tparam.h;
6845 this removes some undefined behavior. Check that outstring and len
6846 are zero, which they always are with Emacs.
6847 * tparam.h (PC, BC, UP): New extern decls.
6849 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6850 (xftfont_open): Rename locals to avoid shadowing.
6852 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6853 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6854 (OTF_TAG_SYM): Omit macro if not needed.
6855 (ftfont_list): Remove unused local.
6856 (get_adstyle_property, ftfont_pattern_entity):
6857 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6858 Rename locals to avoid shadowing.
6860 * xfont.c (xfont_list_family): Mark var as initialized.
6862 * xml.c (make_dom): Now static.
6864 * composite.c (composition_compute_stop_pos): Rename local to
6866 (composition_reseat_it): Remove unused locals.
6867 (find_automatic_composition, composition_adjust_point): Likewise.
6868 (composition_update_it): Mark var as initialized.
6869 (find_automatic_composition): Mark vars as initialized,
6870 with a FIXME (Bug#8290).
6872 character.h: Rename locals to avoid shadowing.
6873 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6874 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6875 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6876 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6879 * textprop.c (property_change_between_p): Remove; unused.
6881 * intervals.c (interval_start_pos): Now static.
6883 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6885 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6886 Rename locals to avoid shadowing.
6888 * sound.c (wav_play, au_play, Fplay_sound_internal):
6889 Fix pointer signedness.
6890 (alsa_choose_format): Remove unused local var.
6891 (wav_play): Initialize a variable to 0, to prevent undefined
6892 behavior (Bug#8278).
6894 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6896 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6898 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6899 clobbering (Bug#8298).
6900 * sysdep.c (sys_subshell): Likewise.
6901 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6903 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6904 This should get cleaned up, so that child_setup has the
6905 same signature on all platforms.
6907 * callproc.c (call_process_cleanup): Now static.
6908 (relocate_fd): Rename locals to avoid shadowing.
6910 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6912 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6913 not to be necessary, and produces flickering.
6915 2011-03-20 Glenn Morris <rgm@gnu.org>
6917 * config.in: Remove file.
6919 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6921 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6922 are now in src/globals.h.
6923 (syms_of_minibuf): Remove spurious & from previous change.
6925 2011-03-20 Leo <sdl.web@gmail.com>
6927 * minibuf.c (completing-read-function): New variable.
6928 (completing-read-default): Rename from completing-read.
6929 (completing-read): Call completing-read-function.
6931 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6933 * xfaces.c (Fx_load_color_file):
6934 Read color file from absolute filename (bug#8250).
6936 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6938 * makefile.w32-in: Update dependencies.
6940 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6942 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6944 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6946 Fix more problems found by GCC 4.5.2's static checks.
6948 * process.c (make_serial_process_unwind, send_process_trap):
6949 (sigchld_handler): Now static.
6951 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6952 That way, the code declares only the vars that it needs.
6953 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6954 * s/cygwin.h (PTY_ITERATION): Likewise.
6955 * s/darwin.h (PTY_ITERATION): Likewise.
6956 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6958 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6959 * process.c (allocate_pty): Don't declare stb unless it's needed.
6961 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6962 (CONSTANTLIM): Remove; unused.
6963 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6964 Define only if needed.
6966 * unexelf.c (unexec): Name an expression,
6967 to avoid gcc -Wbad-function-cast warning.
6968 Use a different way to cause a compilation error if anyone uses
6969 n rather than nn, a way that does not involve shadowing.
6970 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6972 * deps.mk (unexalpha.o): Remove; unused.
6974 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6975 * unexec.h: New file.
6976 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6977 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6979 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6980 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6981 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6982 Change as necessary to match prototype in unexec.h.
6984 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6986 (back_comment, skip_chars): Mark vars as initialized.
6988 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6989 Rename locals to avoid shadowing.
6991 * lread.c (read1): Rewrite so as not to use empty "else".
6992 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6994 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6996 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6997 warning when compiling print.c.
6999 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7000 instead of using an uninitialized var.
7001 (font_sort_entities): Mark var as initialized.
7003 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7005 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7006 pointers to constants.
7007 (font_parse_fcname): Remove unused vars.
7008 (font_delete_unmatched): Now static.
7009 (font_get_spec): Remove; unused.
7010 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7011 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7012 Rename or move locals to avoid shadowing.
7014 * fns.c (require_nesting_list, require_unwind): Now static.
7015 (Ffillarray): Rename locals to avoid shadowing.
7017 * floatfns.c (domain_error2): Define only if needed.
7018 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7020 * alloc.c (mark_backtrace): Move decl from here ...
7021 * lisp.h: ... to here, so that it can be checked.
7023 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7024 (Fdefvar): Rewrite so as not to use empty "else".
7025 (lisp_indirect_variable): Name an expression,
7026 to avoid gcc -Wbad-function-cast warning.
7027 (Fdefvar): Rename locals to avoid shadowing.
7029 * callint.c (quotify_arg, quotify_args): Now static.
7030 (Fcall_interactively): Rename locals to avoid shadowing.
7031 Use const pointer when appropriate.
7033 * lisp.h (get_system_name, get_operating_system_release):
7034 Move decls here, to check interfaces.
7035 * process.c (get_operating_system_release): Move decl to lisp.h.
7036 * xrdb.c (get_system_name): Likewise.
7037 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7038 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7039 some of which prompt warnings from gcc -Wbad-function-cast.
7040 (Fformat_time_string, Fencode_time, Finsert_char):
7041 (Ftranslate_region_internal, Fformat):
7042 Rename or remove local vars to avoid shadowing.
7043 (Ftranslate_region_internal): Mark var as initialized.
7045 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7048 * lisp.h (eassert): Check that the argument compiles, even if
7049 ENABLE_CHECKING is not defined.
7051 * data.c (Findirect_variable): Name an expression, to avoid
7052 gcc -Wbad-function-cast warning.
7053 (default_value, arithcompare, arith_driver, arith_error): Now static.
7054 (store_symval_forwarding): Rename local to avoid shadowing.
7055 (Fmake_variable_buffer_local, Fmake_local_variable):
7056 Mark variables as initialized.
7057 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7059 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7060 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7061 Rename locals to avoid shadowing.
7062 (mark_stack): Move local variables into the #ifdef region where
7064 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7065 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7067 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7068 (GC_STRING_CHARS): Remove; not used.
7069 (Fmemory_limit): Cast sbrk's returned value to char *.
7071 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7072 avoids undefined behavior in theory.
7074 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7076 Use functions, not macros, for up- and down-casing (Bug#8254).
7077 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7078 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7079 to use the following functions instead of these macros.
7080 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7081 EMACS_INT, since callers assume the returned value fits in int.
7082 (upcase1): Likewise, for UPCASE_TABLE.
7083 (uppercasep, lowercasep, upcase): New static inline functions.
7084 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7085 the race-condition problem in the old DOWNCASE.
7087 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7088 Rename locals to avoid shadowing.
7089 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7090 (regex_compile, re_search_2, re_match_2_internal):
7091 Remove unused local vars.
7092 (FREE_VAR): Rewrite so as not to use empty "else",
7093 which gcc can warn about.
7094 (regex_compile, re_match_2_internal): Mark locals as initialized.
7095 (RETALLOC_IF): Define only if needed.
7096 (WORDCHAR_P): Likewise. This one is never needed, but is used
7097 only in a comment talking about a compiler bug, so put inside
7098 the #if 0 of that comment.
7099 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7100 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7103 * search.c (boyer_moore): Rename locals to avoid shadowing.
7104 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7105 (PREV_CHAR_BOUNDARY): Likewise.
7107 * search.c (simple_search): Remove unused var.
7109 * dired.c (compile_pattern): Move decl from here ...
7110 * lisp.h: ... to here, so that it can be checked.
7111 (struct re_registers): New forward decl.
7113 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7115 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7117 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7118 Rename locals to avoid shadowing.
7119 (Fvertical_motion): Mark locals as initialized.
7121 * casefiddle.c (casify_object, casify_region): Now static.
7122 (casify_region): Mark local as initialized.
7124 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7126 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7127 New macros, so that the caller can use some names other than
7128 gcpro1, gcpro2, etc.
7129 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7131 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7132 argument, for consistency with GCPRO2_VAR, etc: it is now the
7133 prefix of the variable, not the variable itself. All uses
7135 * dired.c (directory_files_internal, file_name_completion):
7136 Rename locals to avoid shadowing.
7138 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7139 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7140 dired.c's scmp function, had undefined behavior.
7141 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7142 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7143 * buffer.h: ... to here, because these macros use current_buffer,
7144 and the new implementation with inline functions needs to have
7145 current_buffer in scope now, rather than later when the macros
7147 (downcase, upcase1): New static inline functions.
7148 (DOWNCASE, UPCASE1): Reimplement using these functions.
7149 This avoids undefined behavior in expressions like
7150 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7151 from race conditions in accessing the global variables
7152 case_temp1 and case_temp2.
7153 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7154 * lisp.h (case_temp1, case_temp2): Remove their decls.
7155 * character.h (ASCII_CHAR_P): Move from here ...
7156 * lisp.h: ... to here, so that the inline functions mentioned
7159 * dired.c (directory_files_internal_unwind): Now static.
7161 * fileio.c (file_name_as_directory, directory_file_name):
7162 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7164 (file_name_as_directory): Use const pointers when appropriate.
7165 (Fexpand_file_name): Likewise. In particular, newdir might
7166 point at constant storage, so make it a const pointer.
7167 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7168 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7170 (Fset_file_times, Finsert_file_contents, auto_save_error):
7171 Rename locals to avoid shadowing.
7173 * minibuf.c (choose_minibuf_frame_1): Now static.
7174 (Ftry_completion, Fall_completions): Rename or remove locals
7177 * marker.c (bytepos_to_charpos): Remove; unused.
7179 * lisp.h (verify_bytepos, count_markers): New decls,
7180 so that gcc does not warn that these functions aren't declared.
7182 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7183 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7184 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7185 (copy_text): Remove unused local var.
7187 * filelock.c (within_one_second): Now static.
7188 (lock_file_1): Rename local to avoid shadowing.
7190 * buffer.c (fix_overlays_before): Mark locals as initialized.
7191 (fix_start_end_in_overlays): Likewise. This function should be
7192 simplified by using pointers-to-pointers, but that's a different
7194 (switch_to_buffer_1): Now static.
7195 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7196 (report_overlay_modification): Rename locals to avoid shadowing.
7198 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7199 Fix pointer signedness issue.
7200 (sys_subshell): Mark local as volatile if checking for lint,
7201 to suppress a gcc -Wclobbered warning that does not seem to be right.
7202 (MAXPATHLEN): Define only if needed.
7204 * process.c (serial_open, serial_configure): Move decls from here ...
7205 * systty.h: ... to here, so that they can be checked.
7207 * fns.c (get_random, seed_random): Move extern decls from here ...
7208 * lisp.h: ... to here, so that they can be checked.
7210 * sysdep.c (reset_io): Now static.
7211 (wait_for_termination_signal): Remove; unused.
7213 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7214 (copy_keymap_item, append_key, push_text_char_description):
7216 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7217 (DENSE_TABLE_SIZE): Remove; unused.
7218 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7219 (describe_map_tree):
7220 Rename locals to avoid shadowing.
7222 * keyboard.c: Declare functions static if they are not used elsewhere.
7223 (echo_char, echo_dash, cmd_error, top_level_2):
7224 (poll_for_input, handle_async_input): Now static.
7225 (read_char, kbd_buffer_get_event, make_lispy_position):
7226 (make_lispy_event, make_lispy_movement, apply_modifiers):
7227 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7228 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7229 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7230 (read_key_sequence, read_char): Mark locals as initialized.
7231 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7233 * keyboard.h (make_ctrl_char): New decl.
7234 (mark_kboards): Move decl here ...
7235 * alloc.c (mark_kboards): ... from here.
7237 * lisp.h (force_auto_save_soon): New decl.
7239 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7240 (DEFINE_DUMMY_FUNCTION): New macro.
7241 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7243 (main): Add casts to avoid warnings
7244 if GCC considers string literals to be constants.
7246 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7248 * dbusbind.c: Pointer signedness fixes.
7249 (xd_signature, xd_append_arg, xd_initialize):
7250 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7251 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7252 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7253 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7255 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7256 if GCC considers string literals to be constants.
7257 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7259 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7261 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7262 (print_preprocess, print_object): New macro to fix last change.
7264 * print.c (print_preprocess): Don't forget font objects.
7266 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7268 * emacs.c (USAGE3): Doc fixes.
7270 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7272 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7275 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7277 * lisp.h (VWindow_system, Qfile_name_history):
7278 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7279 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7280 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7282 * w32select.c: Don't #include "keyboard.h".
7283 (run_protected): Add extern declaration for waiting_for_input.
7285 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7286 * w32console.c (detect_input_pending, read_input_pending)
7287 (encode_terminal_code):
7288 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7289 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7290 (w32_system_caret_y, Qfile_name_history):
7291 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7292 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7293 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7294 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7295 * w32proc.c (Qlocal, report_file_error):
7296 * w32term.c (Vwindow_system, updating_frame):
7297 * w32uniscribe.c (initialized, uniscribe_font_driver):
7298 Remove unneeded extern declarations.
7300 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7302 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7304 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7306 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7307 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7308 These macros can no longer be used for assignment.
7310 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7311 Assign struct members directly, instead of using BUF_BEGV etc.
7312 (record_buffer_markers, fetch_buffer_markers): New functions for
7313 recording and fetching special buffer markers.
7314 (set_buffer_internal_1, set_buffer_temp): Use them.
7316 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7318 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7320 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7321 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7323 * xdisp.c (hscroll_window_tree):
7324 (reconsider_clip_changes): Use PT instead of BUF_PT.
7326 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7328 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7329 $(EMACS_ROOT)/lib/intprops.h.
7331 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7333 Fix more problems found by GCC 4.5.2's static checks.
7335 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7336 to unsigned char * to avoid compiler diagnostic.
7337 (xg_free_frame_widgets): Make it clear that a local variable is
7338 needed only if USE_GTK_TOOLTIP.
7339 (gdk_window_get_screen): Make it clear that this macro is needed
7340 only if USE_GTK_TOOLTIP.
7341 (int_gtk_range_get_value): New function, which avoids a diagnostic
7342 from gcc -Wbad-function-cast.
7343 (xg_set_toolkit_scroll_bar_thumb): Use it.
7344 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7345 diagnostic from gcc -Wbad-function-cast.
7346 (get_utf8_string, xg_get_file_with_chooser):
7347 Rename locals to avoid shadowing.
7348 (create_dialog): Move locals to avoid shadowing.
7350 * xgselect.c (xg_select): Remove unused var.
7352 * image.c (four_corners_best): Mark locals as initialized.
7353 (gif_load): Initialize transparent_p to zero (Bug#8238).
7354 Mark another local as initialized.
7355 (my_png_error, my_error_exit): Mark with NO_RETURN.
7357 * image.c (clear_image_cache): Now static.
7358 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7359 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7360 (x_edge_detection): Remove unnecessary cast that
7361 gcc -Wbad-function-cast diagnoses.
7362 (gif_load): Fix pointer signedness.
7363 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7364 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7366 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7368 Improve quality of tests for time stamp overflow.
7369 For example, without this patch (encode-time 0 0 0 1 1
7370 1152921504606846976) returns the obviously-bogus value (-948597
7371 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7372 reports time overflow. See
7373 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7374 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7375 * editfns.c: Include limits.h and intprops.h.
7376 (TIME_T_MIN, TIME_T_MAX): New macros.
7377 (time_overflow): Move earlier, to before first use.
7378 (hi_time, lo_time): New functions, for an accurate test for
7380 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7381 (Fget_internal_run_time): Don't assume time_t fits in int.
7382 (make_time): Use list2 instead of Fcons twice.
7383 (Fdecode_time): More accurate test for out-of-range times.
7384 (check_tm_member): New function.
7385 (Fencode_time): Use it, to test for out-of-range times.
7386 (lisp_time_argument): Don't rely on undefined left-shift and
7387 right-shift behavior when checking for time stamp overflow.
7389 * editfns.c (time_overflow): New function, refactoring common code.
7390 (Fformat_time_string, Fdecode_time, Fencode_time):
7391 (Fcurrent_time_string): Use it.
7393 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7394 * dired.c (make_time): Move to ...
7395 * editfns.c (make_time): ... here.
7396 * systime.h: Note the move.
7398 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7400 * fringe.c (update_window_fringes): Remove unused variables.
7402 * unexmacosx.c (copy_data_segment): Also copy __got section.
7405 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7407 * termcap.c [MSDOS]: Include "msdos.h".
7408 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7409 Constify `char *' arguments and their references according to
7410 prototypes in tparam.h.
7412 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7414 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7415 Adapt all references accordingly.
7417 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7419 2011-03-11 Tom Tromey <tromey@redhat.com>
7421 * buffer.c (syms_of_buffer): Remove obsolete comment.
7423 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7425 * termhooks.h (encode_terminal_code): Declare prototype.
7427 * msdos.c (encode_terminal_code): Don't declare prototype.
7429 * term.c (encode_terminal_code): Now external again, used by
7430 w32console.c and msdos.c.
7432 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7433 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7435 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7437 Fix some minor problems found by GCC 4.5.2's static checks.
7439 * fringe.c (update_window_fringes): Mark locals as initialized
7441 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7443 * alloc.c (mark_fringe_data): Move decl from here ...
7444 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7445 to check its interface.
7446 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7448 * fontset.c (free_realized_fontset): Now static.
7449 (Fset_fontset_font): Rename local to avoid shadowing.
7450 (fontset_font): Mark local as initialized.
7451 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7453 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7455 * xselect.c (x_disown_buffer_selections): Remove; not used.
7456 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7457 (x_own_selection, Fx_disown_selection_internal): Rename locals
7459 (x_handle_dnd_message): Remove local to avoid shadowing.
7461 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7462 so that the caller can use some name other than gcpro1.
7463 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7464 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7465 (Fx_backspace_delete_keys_p):
7466 Use them to avoid shadowing, and rename vars to avoid shadowing.
7467 (x_decode_color, x_set_name, x_window): Now static.
7468 (Fx_create_frame): Add braces to silence GCC warning.
7469 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7470 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7471 Remove unused locals.
7472 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7473 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7474 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7477 * xterm.h (x_mouse_leave): New decl.
7479 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7480 Remove unused functions.
7481 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7482 (x_calc_absolute_position): Now static.
7483 (XTread_socket): Don't define label "out" unless it's used.
7484 Don't declare local "event" unless it's used.
7485 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7486 unless they are used.
7487 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7488 (x_fatal_error_signal): Remove; not used.
7489 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7490 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7491 (x_error_catcher, x_connection_closed, x_error_handler):
7492 (x_error_quitter, xembed_send_message, x_iconify_frame):
7493 (my_log_handler): Rename locals to avoid shadowing.
7494 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7495 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7497 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7498 Rename or move locals to avoid shadowing.
7499 (tty_defined_color, merge_face_heights): Now static.
7500 (free_realized_faces_for_fontset): Remove; not used.
7501 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7502 does not deduce is never used uninitialized.
7503 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7504 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7506 * terminal.c (store_terminal_param): Now static.
7508 * xmenu.c (menu_highlight_callback): Now static.
7509 (set_frame_menubar): Remove unused local.
7510 (xmenu_show): Rename parameter to avoid shadowing.
7511 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7512 since they might point to immutable storage.
7513 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7514 since it's unused otherwise.
7516 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7517 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7518 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7519 avoids a gcc -Wuninitialized diagnostic.
7520 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7521 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7522 does not deduce are never used uninitialized.
7524 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7526 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7527 * window.c (window_loop, size_window):
7528 (run_window_configuration_change_hook, enlarge_window): Likewise.
7530 * window.c (display_buffer): Now static.
7531 (size_window): Mark variables that gcc -Wuninitialized
7532 does not deduce are never used uninitialized.
7533 * window.h (check_all_windows): New decl, to forestall
7534 gcc -Wmissing-prototypes diagnostic.
7535 * dispextern.h (bidi_dump_cached_states): Likewise.
7537 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7539 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7541 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7542 and to avoid gcc -Wuninitialized warning.
7543 (load_charset_map): Mark variables that gcc -Wuninitialized
7544 does not deduce are never used uninitialized.
7545 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7547 * coding.c (coding_set_source, coding_set_destination):
7548 Use "else { /* comment */ }" rather than "else /* comment */;"
7549 for clarity, and to avoid gcc -Wempty-body warning.
7550 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7551 a block, when the outer 'i' will do.
7552 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7553 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7554 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7555 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7556 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7557 Rename locals to avoid shadowing.
7558 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7559 * coding.c (emacs_mule_char, encode_invocation_designation):
7560 Now static, since they're not used elsewhere.
7561 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7562 (decode_coding_object, encode_coding_object, detect_coding_system):
7563 (decode_coding_emacs_mule): Mark variables that gcc
7564 -Wuninitialized does not deduce are never used uninitialized.
7565 (detect_coding_iso_2022): Initialize a local variable that might
7566 be used uninitialized. Leave a FIXME because it's not clear that
7567 this initialization is needed. (Bug#8211)
7568 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7569 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7570 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7571 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7572 Remove unused macros.
7574 * category.c (hash_get_category_set): Remove unused local var.
7575 (copy_category_table): Now static, since it's not used elsewhere.
7576 * character.c (string_count_byte8): Likewise.
7578 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7579 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7581 * chartab.c (copy_sub_char_table): Now static, since it's not used
7583 (sub_char_table_ref_and_range, char_table_ref_and_range):
7584 Rename locals to avoid shadowing.
7585 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7587 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7588 (BIDI_BOB): Remove unused macro.
7590 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7591 deduce are never used uninitialized.
7592 * term.c (encode_terminal_code): Likewise.
7594 * term.c (encode_terminal_code): Now static. Remove unused local.
7596 * tparam.h: New file.
7597 * term.c, tparam.h: Include it.
7598 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7599 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7600 Move these decls to tparam.h, and make them agree with what
7601 is actually in tparam.c. The previous trick of using incompatible
7602 decls in different modules does not conform to the C standard.
7603 All callers of tparam changed to use tparam's actual API.
7604 * tparam.c (tparam1, tparam, tgoto):
7605 Use const pointers where appropriate.
7607 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7608 * cm.h (struct cm): Likewise.
7609 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7610 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7611 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7612 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7613 (turn_on_face, init_tty): Likewise.
7614 * termchar.h (struct tty_display_info): Likewise.
7616 * term.c (term_mouse_position): Rename local to avoid shadowing.
7618 * alloc.c (mark_ttys): Move decl from here ...
7619 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7621 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7623 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7625 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7627 * search.c (compile_pattern_1): Remove argument regp, unused since
7628 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7629 (compile_pattern): Don't pass it.
7631 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7633 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7634 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7636 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7638 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7640 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7641 gdk_window_get_screen, gdk_window_get_geometry,
7642 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7643 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7644 (xg_get_pixbuf_from_pixmap): New function.
7645 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7646 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7647 Call xg_get_pixbuf_from_pixmap instead of
7648 gdk_pixbuf_get_from_drawable.
7649 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7650 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7651 (xg_check_special_colors): Use GtkStyleContext and its functions
7653 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7654 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7655 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7656 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7657 Call gtk_widget_get_preferred_size.
7658 (xg_frame_resized): gdk_window_get_geometry only takes 5
7660 (xg_win_to_widget, xg_event_is_for_menubar):
7661 Call gdk_x11_window_lookup_for_display.
7662 (xg_set_widget_bg): New function.
7663 (delete_cb): New function.
7664 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7665 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7666 (xg_set_background_color): Call xg_set_widget_bg.
7667 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7668 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7669 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7670 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7672 (update_frame_tool_bar): Call gtk_widget_hide.
7673 (xg_initialize): Use GDK_KEY_g.
7675 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7677 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7679 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7680 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7681 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7683 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7685 * w32xfns.c (select_palette): Check success of RealizePalette against
7686 GDI_ERROR, not zero.
7688 See ChangeLog.11 for earlier changes.
7694 Copyright (C) 2011 Free Software Foundation, Inc.
7696 This file is part of GNU Emacs.
7698 GNU Emacs is free software: you can redistribute it and/or modify
7699 it under the terms of the GNU General Public License as published by
7700 the Free Software Foundation, either version 3 of the License, or
7701 (at your option) any later version.
7703 GNU Emacs is distributed in the hope that it will be useful,
7704 but WITHOUT ANY WARRANTY; without even the implied warranty of
7705 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7706 GNU General Public License for more details.
7708 You should have received a copy of the GNU General Public License
7709 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.